- wine-devel - winehq.org

Re: [PATCH 1/2] oleaut32: Convert ITypeInfo implementation to use standard linked list
by Alexandre Julliard 13 Dec '10

13 Dec '10

Andrew Eikum <aeikum(a)codeweavers.com> writes: > - /* search element n in list */ > - for(i=0; i < index; i++) > + i = 0; > + LIST_FOR_EACH_ENTRY (pTypeInfo, &This->typeinfo_list, ITypeInfoImpl, entry) > + { > + if(i >= index) > + break; > + ++i; > + } It looks like an array would be more appropriate than a list. -- Alexandre Julliard julliard(a)winehq.org

2 4

Removal of wineaudioio.drv
by Michael Stefaniuc 13 Dec '10

13 Dec '10

Hello guys, I have just submitted a patch to remove wineaudioio.drv from Wine. It was used by Solaris but the Solaris versions 9 and 10 that are "supported" by Wine do not have it any more. Solaris is using ESD at the moment and newer version will move to OSS4. If anybody has a reason why wineaudioio.drv should stay in please speak up *now*. This is your chance. Of course if you do speak up you volunteer to maintain wineaudioio.drv ;) bye michael

1 1

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 4)
by Chris Robinson 13 Dec '10

13 Dec '10

On Sunday, December 12, 2010 2:19:42 pm Louis Lenders wrote: > +#define USER_HZ_TO_TICKSPERSEC(x,y) (ULONGLONG)10000000 * x / y I'd recommend adding proper parenthesis, to avoid potential problems with order-of-operations. #define USER_HZ_TO_TICKSPERSEC(x,y) ((ULONGLONG)10000000 * (x) / (y)) That way it won't break if you do math in the argument for some reason, like with USER_HZ_TO_TICKSPERSEC(val+1, user_hz) or USER_HZ_TO_TICKSPERSEC(val, user_hz*2) > + static long user_hz; > + > + user_hz = sysconf(_SC_CLK_TCK); There's no real point to making it static if you're always going to (re)set the variable. It would be better to just make the call once: static long user_hz; i(user_hz == 0) user_hz = sysconf(_SC_CLK_TCK); You could also make it an inline function to avoid making user_hz a parameter: /* Convert system clock to 100ns tics */ static long user_hz; static inline ULONGLONG ClockToTics(ULONGLONG val) { i(user_hz == 0) user_hz = sysconf(_SC_CLK_TCK); return val * 10000000 / user_hz; } ... sppi->IdleTime.QuadPart = ClockToTics(idle); sppi->KernelTime.QuadPart = ClockToTics(sys); ...etc... Though I'll defer judgement to others as to what's better.

2 1

Re: msi: Fix testfailure on some 2k3 machines (try 2)
by Marvin 13 Dec '10

13 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7572 Your paranoid android. === WVISTAADM (32 bit msi) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: msi: Fix testfailure on some 2k3 machines
by Hans Leidekker 13 Dec '10

13 Dec '10

On Sun, 2010-12-12 at 22:44 +0100, André Hentschel wrote: > r = MsiOpenProductA(prodcode, &hprod); > - ok(r == ERROR_INSTALL_PACKAGE_OPEN_FAILED || r == ERROR_SUCCESS, > - "Expected ERROR_INSTALL_PACKAGE_OPEN_FAILED or ERROR_SUCCESS, got %d\n", r); > + ok(r == ERROR_INSTALL_PACKAGE_OPEN_FAILED || ERROR_INSTALL_PACKAGE_REJECTED || r == ERROR_SUCCESS, > + "Expected ERROR_INSTALL_PACKAGE_OPEN_FAILED, ERROR_INSTALL_PACKAGE_REJECTED or ERROR_SUCCESS, got %d\n", r); ERROR_INSTALL_PACKAGE_REJECTED means the user has insufficient rights. Look at how action.c handles this error, for example.

2 1

Re: [PATCH] cmd: Allow GOTO to a label, which has a following whitespace, with test
by Marvin 12 Dec '10

12 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7571 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 4)
by Nikolay Sivov 12 Dec '10

12 Dec '10

On 12/13/2010 01:19, Louis Lenders wrote: > Change from try 3: improved macro as per Juan's suggestion, and made user_hz a static variable > > /proc/stat measures the times > in units of USER_HZ, whereas Windows uses 100ns ticks. > This should fix http://bugs.winehq.org/show_bug.cgi?id=23847 > @@ -1591,6 +1593,9 @@ NTSTATUS WINAPI NtQuerySystemInformation( > int count; > char name[10]; > char line[255]; > + static long user_hz; > + > + user_hz = sysconf(_SC_CLK_TCK); This change doesn't make any difference, I think the idea was to make it global.

1 0

wine's configure says "gst/gstpad.h usability... No"
by wylda＠volny.cz 12 Dec '10

12 Dec '10

Hi guys, i'm overworked so wanted to relax a bit with wine :-D and noticed that Debian Squeeze says: gstreamer-0.10 development files not found, gstreamer support disabled but "dpkg -l | grep -i gst": ii libgstreamer-plugins-base0.10-0 0.10.30-1 ii libgstreamer0.10-0 0.10.30-1 ii libgstreamer0.10-0-dbg 0.10.30-1 ii libgstreamer0.10-dev 0.10.30-1 also "find / -iname gstpad.h": /usr/include/gstreamer-0.10/gst/gstpad.h Thanks for any tips to enjoy your new release. Adding config.log if that helps somehow. W.

5 5

Re: shdocvw: Fix testfailure on some NT4 machines
by Marvin 12 Dec '10

12 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7562 Your paranoid android. === WVISTAADM (32 bit shdocvw) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 5/6] mshtml: Added IHTMLWindow2::open test.
by Paul Vriens 12 Dec '10

12 Dec '10

Hi Jacek, On 06/14/2010 02:20 AM, Jacek Caban wrote: > --- > dlls/mshtml/tests/htmldoc.c | 100 > ++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 98 insertions(+), 2 deletions(-) > Some of these tests fail on IE6 SP1: http://test.winehq.org/data/tests/mshtml:htmldoc.html What would be the best approach to fix these? We can add a broken() for the 3577 todo_wine 3578 ok(new_window == NULL, "new_window != NULL\n"); but what about the 3582 todo_wine 3583 CHECK_CALLED(EvaluateNewWindow); introduce a CHECK_CALLED_BROKEN also in this file? -- Cheers, Paul.

2 1

Please ban spammer from the forum
by Rosanne DiMesio 12 Dec '10

12 Dec '10

Dan or Jeremy-- Please ban user hary from the forum. Right now he's posting spam as fast as I'm deleting it. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: Wine: Use GCC's -Wlogical-op if supported.
by Alexandre Julliard 11 Dec '10

11 Dec '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > In the past this has found a dozen or two real issues and lead to some > simplifications. Now the tree is clean in that regard, so we can make > this a default. I still see a ton of warnings here (gcc 4.4.5), mostly because of the glibc string macros. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 3)
by Juan Lang 11 Dec '10

11 Dec '10

Hi Louis, +#define USER_HZ_TO_TICKSPERSEC(x) (ULONGLONG)10000000 * x / user_hz It's poor style to assume in a macro that user_hz exists. Pass it as a macro parameter instead. Also, this is a question rather than a suggestion for a fix: + long user_hz = sysconf(_SC_CLK_TCK); Can this value change during the lifetime of a program? I expect not, but I could be mistaken. If not, why not make it static and initialize it only once? --Juan

1 0

wine-1.3.8 regression for the curses backend to wineconsole
by Alan W. Irwin 11 Dec '10

11 Dec '10

The command wineconsole --backend=curses cmd hangs with the following error message for 1.3.8: err:ntdll:RtlpWaitForCriticalSection section 0x7ee17dec "?" wait timed out in thread 0065, blocked by 0000, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7ee17dec "?" wait timed out in thread 004d, blocked by 0000, retrying (60 sec) There are no such issues for the default wineconsole backend, but I have always preferred using the curses backend because cut and paste was available for it. That backend worked fine (according to my notes) for wine-1.1.41. I built wine-1.3.8 on my Debian testing box a week ago, but saved the output of all build steps. The configure stage had the following curses-related messages: software@raven> grep curses configure.out checking curses.h usability... yes checking curses.h presence... yes checking for curses.h... yes checking ncurses.h usability... yes checking ncurses.h presence... yes checking for ncurses.h... yes checking for -lncurses... libncurses.so.5 These seem fine, and all curses-related output of the "make depend", "make", and "make install" steps seem fine as well. I am generally pretty happy with wine-1.3.8 except for this one curses backend regression. Can others confirm this issue? Is there some workaround such as using a different version of ncurses? Here are the curses-related packages I have installed at the moment on Debian testing: irwin@raven> dpkg --list |grep curse ii lib32ncurses5 5.7+20100313-4 shared libraries for terminal handling (32-bit) ii lib32ncurses5-dev 5.7+20100313-4 developer's libraries for ncurses (32-bit) ii libncurses5 5.7+20100313-4 shared libraries for terminal handling ii libncurses5-dev 5.7+20100313-4 developer's libraries and docs for ncurses ii libncursesw5 5.7+20100313-4 shared libraries for terminal handling (wide character support) ii ncurses-base 5.7+20100313-4 basic terminal type definitions ii ncurses-bin 5.7+20100313-4 terminal-related programs and man pages Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

3 4

Re: [PATCH] ntdll: Handle executable file mappings from noexec filesystems
by Alexandre Julliard 11 Dec '10

11 Dec '10

Marcus Meissner <meissner(a)suse.de> writes: > Hi, > > regression from my previous patch, which forced EXEC permissions on > some mappings, which in turn gets EPERM when the filesystem is > "noexec" mounted. I don't think that's a good idea. If the filesystem is no exec we should report it and fail. -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: msi/tests: Fix some test failures on Wow64.
by Marvin 11 Dec '10

11 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7542 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 07/10] mshtml: Added QueryService(SID_SBindHost) implementation
by Marvin 10 Dec '10

10 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7538 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

winedbg --gdb shows multiple segfaults during any app startup
by Ilya Basin 10 Dec '10

10 Dec '10

In both 1.3.8 and git winedbg --gdb or plain gdb catches several segfaults, but if I ignore them, the program works. $ CC="ccache gcc" ./configure CFLAGS="-g -O0" make ./wine winedbg.exe --gdb notepad Wine-gdb> cont Continuing. Program received signal SIGSEGV, Segmentation fault. 0x7e942cf4 in create_alpha_bitmap (color=0x33c, mask=0x338, src_info=0x1319a8, color_bits=0x7ebf411c) at cursoricon.c:664 664 ptr[0] = ptr[0] * alpha / 255; Wine-gdb> Continuing. ... Program exited normally. Wine-gdb> quit

2 1

None
by paulo lesgaz 10 Dec '10

10 Dec '10

http://webpage.lv/page.php

1 0

Re: ntdll: Change NtQuerySystemInformation to return 100ns ticks for SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION info class (try 2)
by Alexandre Julliard 10 Dec '10

10 Dec '10

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c > index 7ad56e4..d9f0398 100644 > --- a/dlls/ntdll/nt.c > +++ b/dlls/ntdll/nt.c > @@ -64,6 +64,8 @@ > #include <mach/vm_map.h> > #endif > > +#define USER_HZ_TO_TICKSPERSEC(x) (ULONGLONG)10000000 * x / sysconf(_SC_CLK_TCK) Don't hide sysconf in a macro, call it just once where needed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Cross-DLL toolbar bitmaps
by Erich Hoover 10 Dec '10

10 Dec '10

I was looking into adding better bitmaps for the toolbar controls in hhctrl.ocx (now that we have fancy alpha transparency support) and I wanted to make sure that the bitmaps used matched everywhere else in Wine. Looking into how this works currently, I noticed that keeping all the toolbar bitmaps in sync is currently done manually. For example, dlls/shell32/idb_tb_large.bmp uses older icons for backward and forward where dlls/shdocvw/ietoolbar.bmp and dlls/comctl32/idb_std_large.bmp use the new icons. So, my thought was that it might be desirable to split apart the individual icons, move them all to one centralized location, and then institute a makefile rule for chaining the icons together into toolbar bitmaps. Any other thoughts? Does this sound reasonable and worth pursuing? Erich Hoover ehoover(a)mines.edu

2 3

64-bit down to 11 failures !!
by Austin English 10 Dec '10

10 Dec '10

2 2

Re: riched20/tests: Mark behaviour at 120 dpi as broken
by Marvin 09 Dec '10

09 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7522 Your paranoid android. === W7PROX64 (32 bit editor) === editor.c:4702: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4720: Test failed: test paste: strcmp = 1 editor.c:4732: Test failed: test paste: strcmp = -1 editor.c:4762: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5977: Test failed: Cursor is at 0 instead of 4 editor.c:5983: Test failed: Cursor is at 0 instead of 9 editor.c:5989: Test failed: Cursor is at 0 instead of 4 editor.c:6003: Test failed: Cursor is at 8 instead of 9 editor.c:6011: Test failed: Cursor is at 11 instead of 9 editor.c:6022: Test failed: Cursor is at 0 instead of 8 editor.c:6047: Test failed: Cursor is at 0 instead of 8 === W7PROX64 (64 bit editor) === editor.c:4702: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4720: Test failed: test paste: strcmp = 1 editor.c:4732: Test failed: test paste: strcmp = -1 editor.c:4762: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5977: Test failed: Cursor is at 0 instead of 4 editor.c:5983: Test failed: Cursor is at 0 instead of 9 editor.c:5989: Test failed: Cursor is at 0 instead of 4 editor.c:6003: Test failed: Cursor is at 8 instead of 9 editor.c:6011: Test failed: Cursor is at 11 instead of 9 editor.c:6022: Test failed: Cursor is at 0 instead of 8 editor.c:6047: Test failed: Cursor is at 0 instead of 8

1 0

Re: riched20/tests: Mark behaviour at 120 dpi as broken
by James Mckenzie 09 Dec '10

09 Dec '10

Andre: My computer is set up for 125 dpi (Large Fonts on WindowsXP). Should we be testing for this as well? This should give different results than what is stated here. Maybe there is a better way to test this than using a fixed value of 39 in the ok comparision. James McKenzie -----Original Message----- >From: André Hentschel <nerv(a)dawncrow.de> >Sent: Dec 9, 2010 11:38 AM >To: wine-patches <wine-patches(a)winehq.org> >Subject: riched20/tests: Mark behaviour at 120 dpi as broken > >comparison to 96 dpi can be found at http://test.winehq.org/data/23906816d87795c363f0199f33ff70f2732c6ab5/index_… >--- > dlls/riched20/tests/editor.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c >index efd2023..5321d07 100644 >--- a/dlls/riched20/tests/editor.c >+++ b/dlls/riched20/tests/editor.c >@@ -6082,7 +6082,9 @@ static void test_EM_CHARFROMPOS(void) > point.x = 1000; > point.y = 40; > result = SendMessage(hwnd, EM_CHARFROMPOS, 0, (LPARAM)&point); >- todo_wine ok(result == 39, "expected character index of 39 but got %d\n", result); >+ todo_wine ok(result == 39, >+ broken(result == 34) /* 120 dpi */, >+ "expected character index of 39 but got %d\n", result); > > point.x = 1000; > point.y = -1; >-- > >Best Regards, André Hentschel > >

1 0

Trace/breakpoint trap using VS2008 remote debugger
by Joe Dluzen 09 Dec '10

09 Dec '10

Hi all, I've got the Visual Studio Remote Debugger working with breakpoints, but not with forcing the process to pause. It immediately exits with "Trace/breakpoint trap." I've tried looking up the error, but it seems that no one has this specific set of circumstances. Any ideas? Thanks, Joe

2 2

Re: [1/2] msi: Don't try to install or remove ODBC drivers if the component is disabled.
by Joris Huizer 09 Dec '10

09 Dec '10

Hello, I noticed in this patch, exactly the same lines are added in all the functions; wouldn't it be better to add a(n) (inline) function isComponentEnabled(rec,package) to reduce the repetition? HTH, Joris

2 1

Re: [1/2] winetest: Add a trace in the log when skipping a subtest.
by Alexandre Julliard 09 Dec '10

09 Dec '10

Francois Gouget <fgouget(a)free.fr> writes: > I'm not happy with the situation when we skip a whole test executable. > One issue is that in such a case we don't even extract the executable > right now, thus making it impossible to print the subtest name. So we'd > need a different skip line format for that case. Or we could decide to > extract all the files and query their subtest names anyway and only > disable actually running the tests. The problem with this is that one of the reasons for skipping a test is that loading the test binary crashes the system, so loading it to get the subtest names wouldn't help. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] mshtml: Added GUID_CUSTOM_CONFIRMOBJECTSAFETY with CONFIRMSAFETYACTION_LOADOBJECT flag tests
by Marvin 09 Dec '10

09 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7515 Your paranoid android. === WXPPROSP3 (32 bit script) === script.c:1462: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1393: Test failed: policy = 0, expected 3 script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1586: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1587: Test failed: policy = 0, expected 3 === WVISTAADM (32 bit script) === script.c:1462: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1393: Test failed: policy = 0, expected 3 script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1407: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1586: Test failed: expected AXSetInterfaceSafetyOptions_IDispatch_data script.c:1587: Test failed: policy = 0, expected 3

1 0

Re: [2/2] ntdll: Implement missing 64 bit shifts (try 2)
by Alexandre Julliard 09 Dec '10

09 Dec '10

Mike Gibson <mike.gibson(a)storagecraft.com> writes: > @@ -144,8 +144,23 @@ LONGLONG WINAPI RtlLargeIntegerShiftRight( LONGLONG a, INT count ) > */ > LONGLONG WINAPI RtlLargeIntegerArithmeticShift( LONGLONG a, INT count ) > { > - /* FIXME: gcc does arithmetic shift here, but it may not be true on all platforms */ > - return a >> count; > +#ifdef HAVE_SIMPLE_ARITHMETIC_RIGHT_SHIFT > + return a >> count; > +#else > + /* create mask to extend the sign bit */ > + LONGLONG mask; > + mask = ( LONGLONG ) 1 << 63; > + mask &= a; > + mask >>= count; That's an arithmetic shift, you are only moving the problem. Also your calling convention for the _allsh* functions isn't correct, as a simple test case demonstrates. Do you really have an app that uses this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dsound: Standardize the COM usage in duplex.c.
by Alexandre Julliard 09 Dec '10

09 Dec '10

Michael Stefaniuc <mstefani(a)redhat.de> writes: > --- > dlls/dsound/duplex.c | 86 ++++++++++++++++++++++++++++++------------------- > 1 files changed, 53 insertions(+), 33 deletions(-) > > diff --git a/dlls/dsound/duplex.c b/dlls/dsound/duplex.c > index 4a1fbd2..2fcf64c 100644 > --- a/dlls/dsound/duplex.c > +++ b/dlls/dsound/duplex.c > @@ -44,7 +44,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(dsound); > typedef struct IDirectSoundFullDuplexImpl > { > /* IUnknown fields */ > - const IDirectSoundFullDuplexVtbl *lpVtbl; > + IDirectSoundFullDuplex IDirectSoundFullDuplex_iface; > LONG ref; > > /* IDirectSoundFullDuplexImpl fields */ > @@ -57,23 +57,43 @@ typedef struct IDirectSoundFullDuplexImpl > } IDirectSoundFullDuplexImpl; > > typedef struct IDirectSoundFullDuplex_IUnknown { > - const IUnknownVtbl *lpVtbl; > + IUnknown IUnknown_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IUnknown; > > typedef struct IDirectSoundFullDuplex_IDirectSound8 { > - const IDirectSound8Vtbl *lpVtbl; > + IDirectSound8 IDirectSound8_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IDirectSound8; > > typedef struct IDirectSoundFullDuplex_IDirectSoundCapture { > - const IDirectSoundCaptureVtbl *lpVtbl; > + IDirectSoundCapture IDirectSoundCapture_iface; > LONG ref; > IDirectSoundFullDuplexImpl *pdsfd; > } IDirectSoundFullDuplex_IDirectSoundCapture; All these objects are redundant, they should be merged. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Outlook-friendly stub for CreatePrivateObjectSecurity
by James Mckenzie 08 Dec '10

08 Dec '10

Nick Sukharev <nicksukharev(a)gmail.com> wrote: > >Tab characters fixed. You need to resubmit as [Try 2] if you make a correction in the future in a new message, please. James McKenzie

1 0

Re: Outlook-friendly stub for CreatePrivateObjectSecurity
by Dmitry Timoshkov 08 Dec '10

08 Dec '10

Nick Sukharev <nicksukharev(a)gmail.com> wrote: > + if (!InitializeSecurityDescriptor(*NewDescriptor, SECURITY_DESCRIPTOR_REVISION)) { > + HeapFree(GetProcessHeap(), 0, *NewDescriptor); > + return FALSE; > + } You are mixing tabs and spaces. -- Dmitry.

1 0

CreatePrivateObjectSecurity implementation
by Nick Sukharev 08 Dec '10

08 Dec '10

I found that stub implementation for CreatePrivateObjectSecurity / DestroyPrivateObjectSecurity prevents Microsoft Exchange client from working properly. After changing these stubs to return an empty security descriptor and destroy it Exchange works much better. It can now read mail and calendar. I'm looking for suggestions what minimal implementation for these functions would be acceptable as a patch. Thank you PS. Sorry for double-post. It looks like I shouldn't be using nabble to post to wine-devel

1 0

Re: [PATCH 1/4] wineaddon.cpl: Added initial Wine Add-ons Manager stub.
by Alexandre Julliard 08 Dec '10

08 Dec '10

Jacek Caban <jacek(a)codeweavers.com> writes: > The following series of patches is a first step towards Wine Add-ons > tool. These patches move Gecko installation to wineaddon.cpl. They do > nothing about making install code generic nor provide any new GUI yet. > They only place the code in the right place so that it can be improved > further. Is a separate control panel really the right place? It seems to me that it would be preferable if add-ons were treated more like normal packages, and in particular registered in the installed packages list. This would make it possible to manage them from the appwiz control panel, and from other tools that use install information like uninstaller. -- Alexandre Julliard julliard(a)winehq.org

9 18

Re: ntdll: Implement missing 64 bit shifts
by Alexandre Julliard 08 Dec '10

08 Dec '10

Mike Gibson <mike.gibson(a)storagecraft.com> writes: > +/****************************************************************************** > + * _allshr (NTDLL.@) > + * > + * Right arithmetic shift a 64 bit integer > + * > + * PARAMS > + * a [I] Initial number. > + * count [I] Number of bits to shift by. > + * > + * RETURNS > + * The value of a following the shift. > + */ > +LONGLONG WINAPI _allshr( LONGLONG a, INT count ) > +{ > + return a >> count; > +} There's no guarantee that this would be an arithmetic shift, it's compiler-dependent. -- Alexandre Julliard julliard(a)winehq.org

3 2

winetricks dotnet30 install seems to be working again
by Dan Kegel 07 Dec '10

07 Dec '10

For me, with today's winetricks from svn and wine from git, winetricks dotnet30 seems to work well. It appears to hang at the end because of http://bugs.winehq.org/show_bug.cgi?id=25059 but that's cosmetic; if you look for the icon hiding on the taskbar, you'll see the installer completed. Don't know if the resulting package works, but at least it installed for me just now once. Ship it! :-)

1 0

Re: winemenubuilder: Include icons in .url menus
by Paul Vriens 07 Dec '10

07 Dec '10

On 12/07/2010 06:45 PM, Andrew Bogott wrote: > > This should supersede the previous version of this patch. This one plugs > a memory leak present in the last version. > Hi Andrew, The previous patch has already been committed. -- Cheers, Paul.

2 1

re: [SOLVED] Cannot install Python on wine
by Alan W. Irwin 07 Dec '10

07 Dec '10

On 2010-12-06 18:49-0800 Dan Kegel wrote: > Does > winetricks python26 > work for you? The answer to your question (for wine-1.3.8, at least) is yes it does, and that lead to a complete solution! I am CCing to the list as well because others will be interested in that solution to my original question. The command above essentially downloads python-2.6.2.msi then executes wine msiexec /i python-2.6.2.msi ALLUSERS=1 which worked and is very similar to what I tried independently with python-2.7.1, i.e., wine msiexec /i python-2.7.1.amd64.msi which returned with no GUI and error message at all. I then realized from that name this was likely a 64-bit issue. I then downloaded the 32-bit MSI version, (from http://www.python.org/download/releases/2.7.1/) After that download wine msiexec /i python-2.7.1.msi worked like a charm! (I don't understand the significance of ALLUSERS=1 so I left it off.) So problem solved for python-2.7.1. Thanks for your helpful winetricks suggestion which gave me an excellent start on the road to finding the solution for the latest python2. One issue is you will likely want to incorporate the latest version of python2 in winetricks as well as python3 from http://www.python.org/download/releases/3.1.3/. The remaining issue is the complete lack of any error messages when executing the 64-bit MSI file. Shall I file a msiexec bug report about that? There is also no mention of 64-bit versus 32-bit MSI files at http://wiki.jswindle.com/index.php/Wine_MSI. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

1 0

How to deal with variables where the size differs for 32 and 64bit
by Paul Vriens 07 Dec '10

07 Dec '10

Hi, Just found the fix for the oledb32:convert tests on 64bit. We need to adjust our oledb.idl (see patch attached). How should I deal with the ok() messages where we currently specify the 32bit variant? I mean this will of course introduce warnings on the 64bit side. Do I need to create a wrapper for the ok() messages, with a _WIN64 check somewhere? Or use a different printf format identifier? The same is also true for the TRACE() messages in our implementation. -- Cheers, Paul.

4 3

Cannot install Python on wine
by Alan W. Irwin 07 Dec '10

07 Dec '10

Here is what I have tried to install Python under wine so far following what is recommended in http://wiki.jswindle.com/index.php/Wine_MSI. This was done using wine-1.3.8 with WINEDEBUG set to nothing (i.e., "WINEDEBUG=") so that all warning/error messages would be output. wine@raven> wine msiexec /i python-2.7.1.amd64.msi fixme:storage:create_storagefile Storage share mode not implemented. fixme:advapi:LookupAccountNameW (null) L"wine" (nil) 0x32f130 (nil) 0x32f134 0x32f128 - stub fixme:advapi:LookupAccountNameW (null) L"wine" 0x179f10 0x32f130 0x176bf8 0x32f134 0x32f128 - stub The lack of err: messages is encouraging. In particular notice these results have no err:msi:call_script Could not find CLSID for Windows Script which seemed to be an issue for another wine user that has attempted this with prior wine versions. So I had some hope that the above command actually worked, but it returned very quickly with no other response than above, and "find -name python.exe found nothing created by it in the whole wine account area I have set up to deal with wine matters. Thus, I don't think it worked. Is there some clue in the above fixme messages that indicates something fatal happened with msiexec? Is there anything else I should be doing? Another thread about a prior unsuccessful attempt to install Python under wine had this quote: "I have downloaded http://www.dll-files.com/dllindex/dll-files.shtml?msvcirt and placed it in the .wine/drive_c/windows/system directory." I don't have a clue about the significance of that step since I have no Windows experience and little wine experience. Is that step important or is it no longer necessary with wine-1.3.8? Anyhow, my test above was without that step since I didn't understand its necessity/significance. To give you some background about my use case, my development environment has been exclusively Linux since 1996, and I have no Microsoft Windows experience at all. Nevertheless, I help with developing the PLplot package which works on all of Linux, Mac OS X, and Windows so I try to help out the PLplot Windows developers by attempting to build PLplot under wine to follow/confirm what they do and any errors they find. As part of that work, I would like to test the optional PLplot Python bindings under wine which motivates my interest in installing the Windows version of Python under wine. Any help with the proper procedure for installing Python under wine would be much appreciated. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

2 1

CreatePrivateObjectSecurity implementation
by nicksukharev 06 Dec '10

06 Dec '10

I found that stub implementation for CreatePrivateObjectSecurity / DestroyPrivateObjectSecurity prevents Microsoft Exchange client from working properly. After changing these stubs to return an empty security descriptor and destroy it Exchange works much better. It can now read mail and calendar. I'm looking for suggestions what minimal implementation for these functions would be acceptable as a patch. -- View this message in context: http://wine.1045685.n5.nabble.com/CreatePrivateObjectSecurity-implementatio… Sent from the Wine - Devel mailing list archive at Nabble.com.

1 0

Re: [PATCH 2/7] quartz: Add support for filtermapper3 to filtergraph, try 2
by Alexandre Julliard 06 Dec '10

06 Dec '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -177,7 +177,7 @@ typedef struct _IFilterGraphImpl { > > LONG ref; > IUnknown *punkFilterMapper2; > - IFilterMapper2 * pFilterMapper2; > + IFilterMapper3 * pFilterMapper2; You should rename it then. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/11] mshtml: Added IOleControl calls test.
by Marvin 05 Dec '10

05 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7457 Your paranoid android. === WXPPROSP3 (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === WVISTAADM (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === W7PRO (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === W7PROX64 (32 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE === W7PROX64 (64 bit activex) === activex.c:127: Test failed: unexpected call FreezeEvents_TRUE activex.c:129: Test failed: unexpected call FreezeEvents_FALSE

1 0

Re: [1/4] shdocvw: skip some tests if a modern IE is not present
by Paul Vriens 05 Dec '10

05 Dec '10

On 12/02/2010 04:38 AM, Andrew Bogott wrote: > As suggested by Jacek. > Hi Andrew, Even IE6 does things differently as can be seen: http://test.winehq.org/data/tests/shdocvw:intshcut.html Just a matter of adding a broken() statement and bailing out (with cleanup) if the IPropertyStorage_ReadMultiple() fails? -- Cheers, Paul.

1 0

Use of the L prefix for wide strings in resource files
by Paul Vriens 05 Dec '10

05 Dec '10

Hi, Yaron just made me aware of something he and I discussed briefly a few weeks ago. The shlwapi resource files uses the following: PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Cancel", IDCANCEL, 160, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Yes", IDYES, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&No", IDNO, 160, 40, 50, 14, WS_GROUP | WS_TABSTOP There doesn't seem to be an issue with most of the languages as our resource compiler seem to do things just right. I did however see strangeness for some languages and also the not yet submitted Hebrew translation (maybe more?): http://source.winehq.org/transl/resource.php?branch=master&lang=011%3A01&re… http://source.winehq.org/transl/resource.php?branch=master&lang=022%3A01&re… ResHacker shows the same strangeness so it appears not only to be the translation site. Any idea where to start looking? -- Cheers, Paul.

3 3

Hebrew website issues
by Yaron Shahrabani 04 Dec '10

04 Dec '10

The following picture demonstrates the issues: http://lh3.ggpht.com/_QXJR6RTu0qE/TPpTZnza_wI/AAAAAAAADak/yGzX7y8sQI8/winew… <http://lh3.ggpht.com/_QXJR6RTu0qE/TPpTZnza_wI/AAAAAAAADak/yGzX7y8sQI8/winew…>1. The flags are left aligned instead of right aligned (All browsers) 2. The search box is right aligned instead of left aligned (Chromium mostly, sometimes also happens in Firefox) Kind regards, Yaron Shahrabani <Hebrew translator>

1 0

Re: Death to win9x?
by K.King 04 Dec '10

04 Dec '10

<<< A majority of that effort is rewriting tests to make win9x happy, not rewriting behavior to fix win9x applications. >>> Understood <<< Few people (if any) want to intentionally break win9x applications, but spending a large amount of developer effort to maintain the tests there isn't really the best investment, when it could instead be spent fixing real bugs. >>> Regressions are a normal part of large scale development. Regressions are real bugs. Unless you are becoming what you imitate:-) <<< I could drop the Win9x tests and concentrate on Windows 2000 and higher. Would this be a good course of action? >>> Drop seems harsh, prioritize seems reasonable. If you are 199% confident nothing you do would affect Win9x (famous developer last words) Or AJ says put the Win9x users in the lifeboat then it's a good course for you And a not so good one for Win9x users.

5 4

Re: [try 2] msvcrt: Implement wcsnicoll
by Andrew Nguyen 04 Dec '10

04 Dec '10

On Fri, Dec 3, 2010 at 11:21 AM, Mike Gibson <mike.gibson(a)storagecraft.com> wrote: > Had a typo in the first try. > --- > dlls/msvcr100/msvcr100.spec | 2 +- > dlls/msvcr70/msvcr70.spec | 2 +- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/wcs.c | 9 +++++++++ > include/msvcrt/string.h | 1 + > include/msvcrt/wchar.h | 1 + > 8 files changed, 16 insertions(+), 5 deletions(-) > > > You forgot to attach the patch.

1 0

Re: [PATCH 2/6] quartz: Add support for filtermapper3 to filtergraph
by Alexandre Julliard 03 Dec '10

03 Dec '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -269,6 +269,9 @@ static HRESULT WINAPI FilterGraphInner_QueryInterface(IUnknown * iface, > } else if (IsEqualGUID(&IID_IFilterMapper2, riid)) { > *ppvObj = This->pFilterMapper2; > TRACE(" returning IFilterMapper2 interface from aggregated filtermapper (%p)\n", *ppvObj); > + } else if (IsEqualGUID(&IID_IFilterMapper3, riid)) { > + *ppvObj = This->pFilterMapper2; > + TRACE(" returning IFilterMapper3 interface from aggregated filtermapper (%p)\n", *ppvObj); You have to query that interface first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32/tests: Disable IME for msg tests.
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7434 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH] user32/tests: Close second window in DBCS WM_CHAR tests.
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7432 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/7] urlmon: Standardize COM implementation of IUri
by Alexandre Julliard 03 Dec '10

03 Dec '10

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > @@ -3567,7 +3567,7 @@ static HRESULT set_builder_component(LPWSTR *component, DWORD *component_len, LP > return S_OK; > } > > -#define URI(x) ((IUri*) &(x)->lpIUriVtbl) > +#define URI(x) ((IUri*) &(x)->IUri_iface.lpVtbl) > #define URIBUILDER(x) ((IUriBuilder*) &(x)->lpIUriBuilderVtbl) You should also get rid of these macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Death to win9x?
by James Mckenzie 03 Dec '10

03 Dec '10

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Dec 2, 2010 6:30 AM >To: Joerg-Cyril.Hoehle(a)t-systems.com >Cc: wine-devel(a)winehq.org >Subject: Re: Death to win9x? > ><Joerg-Cyril.Hoehle(a)t-systems.com> writes: > >> However, this only allows to run one test at a time, i.e. the big picture is missing. >> Therefore I'd suggest running winetest.exe on all testbot machines once a week >> or some such, e.g. only for releases. > >That's not useful. The whole point is that we don't want to spend the >effort required to keep the tests error-free on platforms that we don't >care about. That makes it easier to write tests for platforms that >actually matter, which is a more productive use of everybody's time. > YOU might not care about them AJ, but we have Wine users that are still using Windows95 programs with Wine on Linux and there are NO suitable replacements for them. Several recent user reports have asked how do I get program X (released for Windows95) to work on Wine. One of my test programs is dOOmII, released in 1996 and I use Wine to run it. Should I just go out and find a copy of Windows98SE and VirtualBox to run this on? Your reply makes it sound like the Wine program just does not care if Windows9x functionality does not matter, it does. I do agree that not much effort should be expended to incorporate more 'A' functionality, but breaking what does work is not reflect well on this project. Remember the original purpose and I think it is still the purpose is to build out the ENTIRE Windows64/32 API, not just a portion of it. If I'm wrong, feel free to chastise me. James McKenzie

3 3

Re: ddeml: More calling convention fixes
by Dmitry Timoshkov 03 Dec '10

03 Dec '10

Tristan Schmelcher <tristan_schmelcher(a)alumni.uwaterloo.ca> wrote: > + if (cbData != (DWORD)-1) > + { > + /* pData is not a pointer if cbData is -1, so we linearize the address > + * here rather than in the calling code. */ > + pData = MapSL((SEGPTR)pData); > + } -1 here should be replaced by CBR_BLOCK, and this piece of the patch should be sent separately from .spec file fixes. -- Dmitry.

2 2

Re: msvcrt: Implement wcsnicoll
by Juan Lang 03 Dec '10

03 Dec '10

Hi Mike, --- a/dlls/msvcr70/msvcr70.spec +++ b/dlls/msvcr70/msvcr70.spec @@ -601,7 +601,7 @@ @ cdecl _wcslwr(wstr) msvcrt._wcslwr @ stub _wcsncoll @ cdecl _wcsnicmp(wstr wstr long) msvcrt._wcsnicmp -@ stub _wcsnicoll +@ cdecl _wcsnicoll(wstr wstr long) msvcrt._wcsnicmp Typo?

1 0

Re: [3/7] urlmon: Implemented PARSE_PATH_FROM_URL for CoInternetParseIUri
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7419 Your paranoid android. === WVISTAADM (32 bit uri) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework
by C.W. Betts 03 Dec '10

03 Dec '10

The main problem when using the QuickTime C APIs is that the majority, if not all of it, is deprecated and not available on 64-bit code. I would suggest using the Objective-C QTKit, but apparently Objective-C code is a no-no in Wine. On Nov 29, 2010, at 10:31 AM, Aric Stewart wrote: > --- > configure | 8 +- > configure.ac | 5 + > dlls/wineqtdecoder/Makefile.in | 11 + > dlls/wineqtdecoder/main.c | 135 +++++++++ > dlls/wineqtdecoder/qtvdecoder.c | 536 +++++++++++++++++++++++++++++++++ > dlls/wineqtdecoder/version.rc | 26 ++ > dlls/wineqtdecoder/wineqtdecoder.spec | 4 + > 7 files changed, 724 insertions(+), 1 deletions(-) > create mode 100644 dlls/wineqtdecoder/Makefile.in > create mode 100644 dlls/wineqtdecoder/main.c > create mode 100644 dlls/wineqtdecoder/qtvdecoder.c > create mode 100644 dlls/wineqtdecoder/version.rc > create mode 100644 dlls/wineqtdecoder/wineqtdecoder.spec > > > <89fa3b1cdaca45ec01cde9e2350010b82c985666.diff>

3 3

Re: user32/tests: skip more input tests on 98 and ME
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7412 Your paranoid android. === WVISTAADM (32 bit input) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: d3d8/d3d9: fix compiler warnings on non x86/x86_64
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7411 Your paranoid android. === WVISTAADM (32 bit device) === device.c:2512: Test failed: Expected foreground window 000101D6, got 000101D2. === W7PRO (32 bit device) === device.c:2512: Test failed: Expected foreground window 00020158, got 00020058. device.c:2651: Test failed: Expected foreground window 00030158, got 00020058. === W7PROX64 (64 bit device) === device.c:2512: Test failed: Expected foreground window 00000000000F0176, got 0000000000010068. device.c:2651: Test failed: Expected foreground window 0000000000100176, got 0000000000010068.

1 0

Re: d3d8/d3d9: fix compiler warnings on non x86/x86_64
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7410 Your paranoid android. === W2K8SE (32 bit device) === device.c:1671: Test failed: Expected foreground window 00010126, got 0001011A. === W7PROX64 (32 bit device) === device.c:1671: Test failed: Expected foreground window 00030186, got 00010068. device.c:1810: Test failed: Expected foreground window 00040186, got 00010068.

1 0

Re: Death to win9x?
by James Mckenzie 02 Dec '10

02 Dec '10

Austin English <austinenglish(a)gmail.com> wrote: > >On Thu, Dec 2, 2010 at 8:00 PM, K.King <k.king177(a)ntlworld.com> wrote: >> <<< >> That's not useful. The whole point is that we don't want to spend the >> effort required to keep the tests error-free on platforms that we don't >> care about. That makes it easier to write tests for platforms that >> actually matter, which is a more productive use of everybody's time. >>>>> >> You may not care, but I know a number of people who do. >> For some running the older software is more important, of interest, or use. > >A majority of that effort is rewriting tests to make win9x happy, not >rewriting behavior to fix win9x applications. > >Few people (if any) want to intentionally break win9x applications, >but spending a large amount of developer effort to maintain the tests >there isn't really the best investment, when it could instead be spent >fixing real bugs. > This I do agree with. I'm working on tests for richedit and the expected reaction of the Win9x version is much different than the reaction of the WindowsXP version. I could drop the Win9x tests and concentrate on Windows 2000 and higher. Would this be a good course of action? James McKenzie

1 0

Re: Death to win9x?
by K.King 02 Dec '10

02 Dec '10

<<< That's not useful. The whole point is that we don't want to spend the effort required to keep the tests error-free on platforms that we don't care about. That makes it easier to write tests for platforms that actually matter, which is a more productive use of everybody's time. >>> You may not care, but I know a number of people who do. For some running the older software is more important, of interest, or use.

2 1

Re: [PATCH 5/7] npmshtml: Added Mozilla plugin for mshtml ActiveX controls.
by Alexandre Julliard 02 Dec '10

02 Dec '10

Jacek Caban <jacek(a)codeweavers.com> writes: > I know that this patch is the most questionable. Gecko expects us to > give it a DLL named np*.dll, so we can't do it in mshtml. Also, this > plugin will be visible to other NPAPI-based browsers running in Wine > (that's a matter of change in the next Gecko release), so it's good > that it's a tiny wrapper that fails to load if mshtml is not loaded > (meaning that we're not running in Wine Gecko). This prevents the dll registration code from running, since mshtml is not loaded at that point. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [1/2] wininet: Use proper error code define instead of its value
by Alexandre Julliard 02 Dec '10

02 Dec '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -270,7 +270,7 @@ static DWORD netconn_verify_cert(PCCERT_CONTEXT cert, HCERTSTORE store, > else if (chain->TrustStatus.dwErrorStatus & ~supportedErrors) > err = ERROR_INTERNET_SEC_INVALID_CERT; > } > - if (!err) > + if (err == ERROR_SUCCESS) There's no reason to change this. 0 meaning success is a common convention, and at least as clear as using an error code for no error. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wineps.drv: return error if unable to select a builtin font
by Alexandre Julliard 02 Dec '10

02 Dec '10

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -191,6 +191,12 @@ BOOL PSDRV_SelectBuiltinFont(PSDRV_PDEVICE *physDev, HFONT hfont, > if(!family) > family = physDev->pi->Fonts; > > + if (!family) > + { > + ERR("Unable to get any font for printer\n"); > + return FALSE; > + } If this is something that can legitimately happen it should be handled correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] shdocvw: In PersistFile_Save, output the Icon Path and Icon Index properties
by Damjan Jovanovic 02 Dec '10

02 Dec '10

On Thu, Dec 2, 2010 at 5:39 AM, Andrew Bogott <Andrew(a)codeweavers.com> wrote: > This gets Icon Path and Icon Index written out to .url files if they've been > set previously. > > > > I think you leak a reference to pPropStgRead here. Nice patch set otherwise :-) Damjan

1 0

Re: [2/2] msi: Clear last error on success in MsiQueryFeatureState and MsiQueryProductState.
by Marvin 02 Dec '10

02 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7392 Your paranoid android. === W2KPROSP4 (32 bit msi) === msi.c:618: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:633: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:646: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:666: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:677: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:695: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:705: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:716: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:727: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:736: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:972: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:979: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:994: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1004: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1028: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1037: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1046: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1055: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1064: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1086: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1095: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1104: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1114: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1124: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1134: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1144: Test failed: expected ERROR_SUCCESS, got 1008 msi.c:1154: Test failed: expected ERROR_SUCCESS, got 1008

1 0

poor Wine performance creating fat dialogs
by Andreas Pflug 02 Dec '10

02 Dec '10

I'm investigating running a commercial ERP system under Wine (only binary available). It mostly works, but creating the main dialogs for item, customer and such will need around 25 seconds, while running on Wxx it takes 2-3 seconds. After that, there's no serious performance impact working on these dialogs. The dialogs contain a lot of controls, like 500 or so each, so I suspect that's what makes things slow. I'm willing to investigate this in the wine sources, if it makes sense. So before I start I'd like to know if there are known or suspected inefficient code regions that might cause the problem? Maybe some win<->x11 translation tables that degrade with 1000+ windows? Or has this been observed before, and the problem is outside of wine's scope? Any hint appreciated. Regards, Andreas

3 3

Re: [PATCH] shell32/tests: Fixed SHPathPrepareForWriteW tests on Asian platforms.
by Marvin 02 Dec '10

02 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7381 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2207: Test failed: SHGetNewLinkInfoA succeeded

1 0

Death to win9x?
by Dan Kegel 01 Dec '10

01 Dec '10

I'm all for removing stuff that nobody needs anymore. I imagine there are still a few popular older apps that will force us to keep some old win9x behaviors around, though, so we probably won't be able to remove the 'emulate win98' choice from winecfg any time soon.

3 3

Re: [PATCH 4/5] quartz: Add quality control to sound renderer
by Alexandre Julliard 01 Dec '10

01 Dec '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > --- > dlls/quartz/dsoundrender.c | 29 +++++++++++++++++++++++++++++ > 1 files changed, 29 insertions(+), 0 deletions(-) It breaks here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so dsoundrender.c && touch dsoundrender.ok dsoundrender.c:153: Test succeeded inside todo block: IUnknown_QueryInterface returned 0 dsoundrender.c:153: Test succeeded inside todo block: Pointer is NULL dsoundrender.c:154: Test succeeded inside todo block: IUnknown_Release should return 1, got 1 make: *** [dsoundrender.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Stopping Win9x testing
by Greg Geldorp 01 Dec '10

01 Dec '10

> From: Wolfram Sang > > > I'll mark the Win9x VMs offline when there's nothing queued to run on them. > > Then in a weeks time I can delete them after all jobs referring to them > > have been retired/deleted (referential integrity in the database). > > That means they even won't be available then for some specific corner-case > tests (in which they are selected manually)? Hmm, is there much overhead > involved to keep them "just in case"? Yeah, that might be a good idea. Currently VMs are divided into a "Base" and a "Extra" group, I can add a "Retired" group to hold the Win9x VMs. VMs in this group wouldn't participate in the daily winetest run, wouldn't be used for verification of wine-patches submissions and wouldn't be selected by default when manually submitting a job. However, they would be available for selection if you click "Show all VMs" button when submitting a job. This will require some changes to the code, but nothing major. I'll look into it. Greg.

1 0

Re: [PATCH 2/2] opencl: Basic OpenCL 1.0 implementation. (try 2)
by Alexandre Julliard 01 Dec '10

01 Dec '10

Peter Urbanec <winehq.org(a)urbanec.net> writes: > +static BOOL load_funcs(void *handle) > +{ > +#define LOAD_FUNCPTR(f) if((p##f = (void*)wine_dlsym(handle, #f, NULL, 0)) == NULL) \ > + { ERR("Can not find " #f "\n"); return FALSE; } else { TRACE("Loaded function " #f "\n"); }; > + > + /* Platform API */ > + LOAD_FUNCPTR(clGetPlatformIDs) > + LOAD_FUNCPTR(clGetPlatformInfo) > + > + /* Device APIs */ > + LOAD_FUNCPTR(clGetDeviceIDs) > + LOAD_FUNCPTR(clGetDeviceInfo) Why are you loading everything dynamically instead of simply linking to it? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 2/2] opencl: Basic OpenCL 1.0 implementation. (try 2)
by Roderick Colenbrander 01 Dec '10

01 Dec '10

It looks fine to me, but I'm worried whether it can work properly in the end. A few months ago I worked on Cuda support for something (I implemented nvcuda.dll which is what cuda runtime libraries like cudart or physx are using). Certain lowlevel nvcuda applications worked, but more fancy applications didn't. I had some contact with Nvidia about it and it was not possible to support Cuda without assistance on their side. OpenCL is a little different of course, but I fear that not all OpenCL implementations will like wrapping. What OpenCL applications have you tried so far? The Nvidia GPU Computing SDK (or whatever it was called) has a ton of samples for both Cuda and OpenCL. Do all their OpenCL samples work? Roderick On Mon, Nov 29, 2010 at 2:39 PM, Peter Urbanec <winehq.org(a)urbanec.net> wrote: > Resending because previous patch was mangled by Thunderbird. > > --- > dlls/opencl/opencl.c | 1142 > +++++++++++++++++++++++++++++++++++++++++++++++ > dlls/opencl/opencl.spec | 159 ++++--- > 2 files changed, 1232 insertions(+), 69 deletions(-) > > > > > >

2 1

Re: include: Fix error logic
by Alexandre Julliard 01 Dec '10

01 Dec '10

André Hentschel <nerv(a)dawncrow.de> writes: > The file is nearly always used with one of both, so "or" makes no sense. > Also if you have a look through tchar.h you see it catches all cases, > but not the case where both are defined It doesn't make any sense to define both. -- Alexandre Julliard julliard(a)winehq.org

1 0

Stopping Win9x testing
by Greg Geldorp 01 Dec '10

01 Dec '10

> From: Paul Vriens > > On 11/30/2010 04:41 PM, Alexandre Julliard wrote: > > The value of running tests on Win9x these days is certainly questionable. > > We don't try to emulate the Win9x behavior anyway, except in a very few > > cases (which most likely don't have tests...) so it only serves to > > document historical behavior that nobody cares about any longer. > > > > I wouldn't be opposed to switching off win9x test runs and getting rid > > of the corresponding broken(). > > So the first thing is a patch to winetest.exe and the winetest website > and at the same time tell Greg to exclude it from 'patchwatcher' and the > batch running of the (almost) daily winetests. I'll mark the Win9x VMs offline when there's nothing queued to run on them. Then in a weeks time I can delete them after all jobs referring to them have been retired/deleted (referential integrity in the database). So for the next week you'll see a red dot with "One or more VMs are offline" on the testbot main page, don't be alarmed by this. Greg.

2 1

Re: mshtml: Added beginning ActiveX tests.
by Paul Vriens 30 Nov '10

30 Nov '10

Hi Jacek, On 11/30/2010 01:38 PM, Jacek Caban wrote: > +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) > +{ > + if(dispID == DISPID_READYSTATE){ > + BSTR state; > + HRESULT hres; > + > + static const WCHAR completeW[] = {'c','o','m','p','l','e','t','e',0}; > + > + hres = IHTMLDocument2_get_readyState(notif_doc,&state); > + ok(hres == S_OK, "get_readyState failed: %08x\n", hres); > + > + if(!lstrcmpW(state, completeW)) This will always succeed on Win9x. > +static HWND create_container_window(void) > +{ > + static const WCHAR wszHTMLDocumentTest[] = > + {'H','T','M','L','D','o','c','u','m','e','n','t','T','e','s','t',0}; > + static WNDCLASSEXW wndclass = { > + sizeof(WNDCLASSEXW), > + 0, > + wnd_proc, > + 0, 0, NULL, NULL, NULL, NULL, NULL, > + wszHTMLDocumentTest, > + NULL > + }; > + > + RegisterClassExW(&wndclass); > + return CreateWindowW(wszHTMLDocumentTest, wszHTMLDocumentTest, > + WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, CW_USEDEFAULT, > + 515, 530, NULL, NULL, NULL, NULL); > +} This will not work on Win9x as well. My Win98 box runs IE6 so it will run these tests I guess (unlike the win98 testbot). -- Cheers, Paul.

3 6

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework
by Alexandre Julliard 30 Nov '10

30 Nov '10

Aric Stewart <aric(a)codeweavers.com> writes: > --- > configure | 8 +- > configure.ac | 5 + > dlls/wineqtdecoder/Makefile.in | 11 + > dlls/wineqtdecoder/main.c | 135 +++++++++ > dlls/wineqtdecoder/qtvdecoder.c | 536 > +++++++++++++++++++++++++++++++++ > dlls/wineqtdecoder/version.rc | 26 ++ > dlls/wineqtdecoder/wineqtdecoder.spec | 4 + > 7 files changed, 724 insertions(+), 1 deletions(-) > create mode 100644 dlls/wineqtdecoder/Makefile.in > create mode 100644 dlls/wineqtdecoder/main.c > create mode 100644 dlls/wineqtdecoder/qtvdecoder.c > create mode 100644 dlls/wineqtdecoder/version.rc > create mode 100644 dlls/wineqtdecoder/wineqtdecoder.spec This is showing many deprecated function warnings even on Leopard. We should try to avoid that in new code. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.
by Dmitry Timoshkov 30 Nov '10

30 Nov '10

Alexander Puzankov <alxpnv(a)gmail.com> wrote: > + lpProc = mmioInstallIOProc(FOURCC_DOS, (LPMMIOPROC)mmio_test_IOProc, MMIO_INSTALLPROC); > + ok(lpProc == (LPMMIOPROC)mmio_test_IOProc, "mmioInstallIOProc error\n"); Please try to avoid this kind of casts, they hide the bugs. Also, if the tests depend on the following patches in sequence to pass, the tests should be sent as a last patch ('make test' should succeed after each patch in the sequence). -- Dmitry.

2 2

Translation patches for wine-1.2.2
by Michael Stefaniuc 30 Nov '10

30 Nov '10

Hello Alexandre, attached is the list of translation patches for wine-1.2.2. This time I manually checked the changes to the En.rc files if they are indeed a wine-1.2 incompatible change. Thus there are some patches in the list that I missed for wine-1.2.1 with the automatic "stop at first En.rc file change". Some other things to note: - There are 4 of my janitorial patches in; you can skip them like the last time and fix up the patches that don't cherry-pick cleanly. - "winhlp32: Use a standard About dialog, with the proper icon" seemed inconspicuous enough to include and thus allow translation patches for winhlp32 after that commit. - Does it make sense to include the Arab and Hebrew translations? Support for mirroring is only in wine-1.3.x. bye michael

1 0

Re: [PATCH 3/5] mshtml: Added SetUIHandler tests.
by Paul Vriens 30 Nov '10

30 Nov '10

Hi Jacek, On 11/29/2010 12:18 AM, Jacek Caban wrote: > --- > dlls/mshtml/tests/htmldoc.c | 111 > ++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 104 insertions(+), 7 deletions(-) This one introduced some test failures: http://test.winehq.org/data/tests/mshtml:htmldoc.html Just a matter of adding 3000024 and 3000025 to the switch in PropertyNotifySink_OnChanged()? -- Cheers, Paul.

2 1

Re: shdocvw: Do not annoy user when he disabled winemenubuilder
by Alexandre Julliard 30 Nov '10

30 Nov '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -85,6 +85,9 @@ static BOOL run_winemenubuilder( const WCHAR *args ) > GetSystemDirectoryW( app, MAX_PATH - sizeof(menubuilder)/sizeof(WCHAR) ); > strcatW( app, menubuilder ); > > + if( GetFileAttributesW(app) == INVALID_FILE_ATTRIBUTES) > + return FALSE; Checking for file existence doesn't make much sense for builtins. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] opencl: Initial stub implementation of OpenCL 1.0 (try 2)
by C.W. Betts 30 Nov '10

30 Nov '10

It doesn't look like you look for Apple's OpenCL implementation, which uses <OpenCL/opencl.h>. You can do this: #ifdef __APPLE__ #include <OpenCL/opencl.h> #else #include <CL/opencl.h> #endif On Nov 29, 2010, at 7:39 AM, Peter Urbanec wrote: > Resending because previous patch was mangled by Thunderbird. > > --- > configure.ac | 13 ++++++++ > dlls/opencl/Makefile.in | 6 ++++ > dlls/opencl/opencl.c | 29 ++++++++++++++++++ > dlls/opencl/opencl.spec | 75 +++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 123 insertions(+), 0 deletions(-) > create mode 100644 dlls/opencl/Makefile.in > create mode 100644 dlls/opencl/opencl.c > create mode 100644 dlls/opencl/opencl.spec > > > <0001-opencl-Initial-stub-implementation-of-OpenCL-1.0.patch>

2 1

Re: [PATCH 1/5] ddraw/tests: Fix a typo.
by Marvin 30 Nov '10

30 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7343 Your paranoid android. === W98SE (32 bit dsurface) === dsurface: unhandled exception c0000005 at 00415849

1 0

Re: [PATCH 3/5] wined3d: Pass an IWineD3DDeviceImpl pointer to drawStridedSlow().
by Henri Verbeet 29 Nov '10

29 Nov '10

On 2010-11-29 23:08, Henri Verbeet wrote: > --- > dlls/wined3d/device.c | 12 ++++---- > dlls/wined3d/drawprim.c | 59 ++++++++++++++++++--------------------- > dlls/wined3d/wined3d_private.h | 2 +- > 3 files changed, 34 insertions(+), 39 deletions(-) > I messed up the commit message, this is for drawPrimitive() of course.

1 0

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. Take 4.
by Alexandre Julliard 29 Nov '10

29 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 306 +++++++++++++++++++++++++++++++++---------------- > 1 files changed, 206 insertions(+), 100 deletions(-) This is causing strange crashes during prefix creation on 64-bit (there's no backtrace unfortunately). -- Alexandre Julliard julliard(a)winehq.org

1 0

Crappy Deb build scripts
by Ben Klein 29 Nov '10

29 Nov '10

By request of Austin, my crappy build scripts. I finally had the concentration to bundle all the right files together!

3 4

Re: user32/tests: Remove obsolete comment
by Marvin 29 Nov '10

29 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7336 Your paranoid android. === W7PRO (32 bit input) === input.c:817: Test failed: 0 (a4/0): the msg sequence is not complete: expected 0000 - actual c0ae

1 0

Re: dsound.h: Undefine INTERFACE before using it.
by Alexandre Julliard 29 Nov '10

29 Nov '10

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -419,6 +419,7 @@ extern HRESULT WINAPI GetDeviceID(LPCGUID lpGuidSrc, LPGUID lpGuidDest); > /***************************************************************************** > * IDirectSound interface > */ > +#undef INTERFACE > #define INTERFACE IDirectSound > DECLARE_INTERFACE_(IDirectSound,IUnknown) The preferred pattern is to undefine it after use. If there are files that don't do this they should be fixed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] [Kernel32, Server]: fixed a couple of bugs when reading bare console input with overlapped operations
by Alexandre Julliard 29 Nov '10

29 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -3011,6 +3014,7 @@ BOOL CONSOLE_Init(RTL_USER_PROCESS_PARAMETERS *params) > /* reply->event shouldn't be created by server */ > } > SERVER_END_REQ; > + fcntl( 0, F_SETFL, O_NONBLOCK ); I don't think that's a good idea, the calling process may not expect that. Also using overlapped I/O seems overkill considering that you already have a Unix fd. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11: remove unused field
by Vincent Povirk 29 Nov '10

29 Nov '10

I don't know much about this area of Wine, but I think the change is incorrect. The DC's transform is applied to the font when it is rendered. To do this correctly, the glyphs must be transformed when they are rasterized and uploaded. Note that we only appear to use the first four fields of XFORM (they are copied to a shorter FMAT2 struct) to rasterize the glyphs. The last two fields of XFORM only specify an offset, so I think they can be safely ignored. 2010/11/28 Ričardas Barkauskas <miegalius(a)gmail.com>: > Makes Steam store page scrolling smoother. > Didn't find where this field would be used or what relevant difference > between fonts it would indicate for this caching. > Without it lots of fonts differing only by fields in this structure are > created in such a way that they get marked as unused almost immediately and > thus cache entries get reused fast. > Hacking to allow for much more generous cache growth resulted ~880 entries > (in short run) in font cache and it still managed not to find font in cache > quite often. > With this I didn't notice any such growth, no visual changes and no tests > complained (that don't complain usually). > Don't know what if any tests I could write for this (or more likely I simply > wouldn't be able :P). > > Rčardas Barkauskas > REalm > > > >

2 1

[PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo
by James Eder 29 Nov '10

29 Nov '10

On 11/26/10 12:15 AM, Damjan Jovanovic wrote: > On Fri, Nov 26, 2010 at 6:56 AM, Vitaliy Margolen > <wine-devel at kievinfo.com> wrote: >> On 11/24/2010 07:19 PM, James McKenzie wrote: >>> On 11/24/10 6:56 PM, Vitaliy Margolen wrote: >>>> On 11/24/2010 12:23 PM, jimportal at gmail.com wrote: >>>>> From: James Eder<jimportal at gmail.com> >>>>> >>>>> - while (fgets(line,200,f) != NULL) >>>>> + while (fgets(line,450,f) != NULL) >>>> You might as well then change this to "sizeof(line)". >>> Just for my edification, is there not a better way then setting the >>> variable >>> line to a flexible length for this purpose. >> Unless I didn't understand your question - you can't set a buffer to a >> "variable length". You have to provide fgets() a size of the buffer so it >> can read at most that many characters -1 for terminating \0. >> >> Vitaliy. >> >> >> > So read lines dynamically instead: > It would be nice to not reinvent that wheel all the time. I don't suppose your function could be pulled out of winemenubuilder.c and placed in a more accessible location. Should I just copy and paste it? It's a good function and it would fit just fine in my opinion. Alternatively, I doubt 2k or 4k worth of processor features ("flags") are going to show up for some years, but I don't know. At any rate, at least it would fix it for current systems. -- Jim

3 4

Re: winex11: remove unused field
by Dmitry Timoshkov 29 Nov '10

29 Nov '10

Ričardas Barkauskas <miegalius(a)gmail.com> wrote: > typedef struct > { > LOGFONTW lf; > - XFORM xform; > SIZE devsize; /* size in device coords */ > DWORD hash; > } LFANDSIZE; > @@ -639,7 +638,6 @@ static BOOL fontcmp(LFANDSIZE *p1, LFANDSIZE *p2) > { > if(p1->hash != p2->hash) return TRUE; > if(memcmp(&p1->devsize, &p2->devsize, sizeof(p1->devsize))) return TRUE; > - if(memcmp(&p1->xform, &p2->xform, sizeof(p1->xform))) return TRUE; > if(memcmp(&p1->lf, &p2->lf, offsetof(LOGFONTW, lfFaceName))) return TRUE; > return strcmpiW(p1->lf.lfFaceName, p2->lf.lfFaceName); > } It's not useless, probably you need to check the DC graphics mode before storing the XFORM in the cache, like dlls/gdi32/freetype.c,WineEngCreateFontInstance() is doing. -- Dmitry.

1 0

Re: [PATCH] user32/tests: Fix test failures by disabling IME when testing unicode input.
by Marvin 29 Nov '10

29 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7331 Your paranoid android. === W7PRO (32 bit input) === input.c:817: Test failed: 0 (a4/0): the msg sequence is not complete: expected 0000 - actual c0ae

1 0

Packaging 1.3.7 and newer, lucid?
by Trygve Vea 29 Nov '10

29 Nov '10

Hello, I can't seem to find wine 1.3.7 / 1.3.8 packages for lucid in the ppa-repository. Does anyone know if this is on purpose? Regards -- Trygve Vea

3 3

Re: quartz: Start DirectSound renderer as soon as possible.
by Erich Hoover 28 Nov '10

28 Nov '10

I've been working on a set of patches (compiled together and attached for your convenience) to fix the background music in Fallout 3 (Bug #24478) and I've run into some trouble recently with commit 64b14c0ecdd13530a92ff636c451523a99253a0b. Before that commit (or removing that commit in current git) and applying the patches allows the music to function in both the main menu, properly stop when the menu is closed, and later play again when the user is in the game. With said commit applied these patches still permit the background music to work when at the main menu; however, the moment the "stop" occurs on exiting the menu then all audio in the entire game ceases to function. I would really appreciate any feedback you can provide or pointers on where to look for the source of this problem. Thanks in advance! Erich Hoover ehoover(a)mines.edu

2 3

Re: [2/2] atl: add support for binary values in IRegistrar
by Paul Vriens 28 Nov '10

28 Nov '10

Hi Damjan, On 11/24/2010 10:10 AM, Damjan Jovanovic wrote: > Changelog: > * atl: add support for binary values in IRegistrar > > It appears that 'm' (REG_MULTI_SZ) values do not work on Windows (not > even the MSDN example on > http://msdn.microsoft.com/en-us/library/ttd53fhh(VS.71).aspx), so this > concludes the patch set. > I see some failures on test.winehq.org: http://test.winehq.org/data/tests/atl:registrar.html My Win95 also fails and all the Windows boxes that fail, fail with 0x80020009 (DISP_E_EXCEPTION). Removing both binary values from textA (and the corresponding tests of course) makes the tests succeed on my Win95 box. Does that makes sense? I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7. So what decides if binary values are supported? -- Cheers, Paul.

2 3

re: msvcrt: Fixed problem parsing multi-byte characters in _mbspbrk.
by Dan Kegel 28 Nov '10

28 Nov '10

http://en.wiktionary.org/wiki/negato says Adjective negato m. (f. negata, m plural negati, f plural negate) 1. denied, refused negato m. (f. negata, m plural negati, f plural negate) (per) or (in) 1. useless, hopeless (at) Neither that, nor the William Gates pseudonym, are particularly helpful. Wine is built on a web of trust, and if we have no idea who you are -- and if you act like you have something to hide -- we might have to assume that you've purloined Windows source code, and refuse your patch to protect ourselves. So, who are you, really? - Dan

1 0

Re: msvcrt: Fixed problem parsing multi-byte characters in _mbspbrk.
by William Gates 28 Nov '10

28 Nov '10

Who's to say this is not my real name? On Sat, Nov 27, 2010 at 5:08 PM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > On 11/26/10 11:41 AM, William Gates wrote: > > You have to send in patches with your real name. > > James McKenzie > > > >

2 1

Re: atl/tests: Fix test in test_registrar.
by Paul Vriens 27 Nov '10

27 Nov '10

Hi Gerald, On 11/27/2010 10:19 PM, Gerald Pfeifer wrote: > An obvious one I'd say... > > Gerald > --- > dlls/atl/tests/registrar.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/atl/tests/registrar.c b/dlls/atl/tests/registrar.c > index 422608b..268765f 100644 > --- a/dlls/atl/tests/registrar.c > +++ b/dlls/atl/tests/registrar.c > @@ -106,7 +106,7 @@ static void test_registrar(void) > size = 4; > lret = RegQueryValueExA(key, "binary_quoted", NULL, NULL, bytes,&size); > ok(lret == ERROR_SUCCESS, "RegQueryValueA, failed, error %d\n", lret); > - ok(bytes[0] = 0xde&& bytes[1] == 0xad&& bytes[2] == 0xbe&& bytes[3] == 0xef, > + ok(bytes[0] == 0xde&& bytes[1] == 0xad&& bytes[2] == 0xbe&& bytes[3] == 0xef, > "binary quoted value was not preserved (it's 0x%02X%02X%02X%02X)\n", > 0xff& bytes[0], 0xff& bytes[1], 0xff& bytes[2], 0xff& bytes[3]); > There are two of these actually. Do you mind me sending in one big patch to fix the stuff you found and the fix for Win95/NT that don't support binary values? -- Cheers, Paul.

1 0

Re: Added unit test suite for process functions (try 4)
by James McKenzie 27 Nov '10

27 Nov '10

On 11/27/10 9:03 AM, Borut Razem wrote: > On 11/27/2010 03:48 AM, Marvin wrote: > > process.c:133: Test failed: _pclose should return after 2 seconds, > but it returned after 6 seconds > > It seems that the "paranoid android" Marvin was very busy... > Looks like something else went busy too as I received about ten copies on the Wine Patches list. James McKenzie

1 0

Could these changes break Wine? Fwd: gcc in natty now passes --as-needed by default to the linker
by Scott Ritchie 27 Nov '10

27 Nov '10

Trying to head off a problem before it's a problem... -------- Original Message -------- Subject: gcc in natty now passes --as-needed by default to the linker Date: Mon, 15 Nov 2010 12:26:27 +0100 From: Matthias Klose <doko(a)ubuntu.com> Reply-To: ubuntu-devel-discuss(a)lists.ubuntu.com To: ubuntu-devel <ubuntu-devel-announce(a)lists.ubuntu.com>, ubuntu-devel <ubuntu-devel(a)lists.ubuntu.com> There is a second change to the linking in natty; as announced in [1], --no-add-needed/--no-copy-dt-needed-entries is passed by default, with the current gcc in natty, --as-needed is passed as well. Please see [2] for implications (runtime failures) and a list of packages which might be affected. To revert this change on a per package basis, pass --no-as-needed to the linker (-Wl,--no-as-needed in LDFLAGS). To add an explicit dependency on a library use --no-as-needed -lfoo --as-needed. Please tag bug reports with `as-needed' if you see runtime failures caused by this change (mostly unresolvable symbols referenced by plugins and ldopened objects). Matthias [1] https://lists.ubuntu.com/archives/ubuntu-devel-announce/2010-October/000772… [2] http://wiki.debian.org/ToolChain/DSOLinking#Onlylinkwithneededlibraries

3 2

Re: Added unit test suite for process functions (try 3)
by Marvin 27 Nov '10

27 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7294 Your paranoid android. === WVISTAADM (32 bit process) === process.c:133: Test failed: _pclose should return after 2 seconds, but it returned after 6 seconds === W2K8SE (32 bit process) === process.c:133: Test failed: _pclose should return after 2 seconds, but it returned after 6 seconds

1 0

Re: [PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo
by Vitaliy Margolen 26 Nov '10

26 Nov '10

On 11/24/2010 12:23 PM, jimportal(a)gmail.com wrote: > From: James Eder<jimportal(a)gmail.com> > > - while (fgets(line,200,f) != NULL) > + while (fgets(line,450,f) != NULL) You might as well then change this to "sizeof(line)". Vitaliy.

3 5

Re: [1/4] msi: Fix the Create/RemoveFolders actions to actually create and remove empty folders.
by Marvin 26 Nov '10

26 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7281 Your paranoid android. === W2K8SE (32 bit action) === Timeout

1 0

re: dockFill problem
by Dan Kegel 26 Nov '10

26 Nov '10

.bill wrote: > I have the following problem in a .NET application. > A form resides in a maximized MDI window. > On startup the MDI gets maximized but the form is not although the dockFill property is set. Sounds interesting. If you're not already, please try the latest version of wine (1.3.7 or built from git). If the problem persists, please file a bug, and we'll give you suggestions about debugging there. If you can include the source and binary for a tiny program that demonstrates the problem, that would help greatly. - Dan

2 2

Re: wined3d: Allow color key processing for surfaces with alpha channel
by Stefan Dösinger 26 Nov '10

26 Nov '10

Am Mittwoch 24 November 2010, 12:38:00 schrieb Ilya Shpigor: > Hello! > > This is new patch for bug: > http://bugs.winehq.org/show_bug.cgi?id=23750 > > I have tested color key processing for SURFACE_OPENGL and SURFACE_GDI > surfaces with alpha channel in Windows.The color key has been processed > for both surface types. I'm not sure I understand - SURFACE_OPENGL and SURFACE_GDI are wine specific, how did you test on Windows? > I don't know how to write correct Wine test for this problem. Can anybody > help me? > Is this Wine test realy needed? Yes, we need a test for this patch, as it contradicts documentation I have previously read. A Nvidia document about color keying emulation states that Nvidia drivers ignore color keying on Alpha 3D textures. Thus we need a test to (a) be sure that the patch is correct and (b) make sure we don't revert the patch if reverting it happens to fix some app in the future. Take a look at dlls/ddraw/tests/dsurface.c and dlls/ddraw/tests/visual.c. The best would be to write a test for the 2D blitting path in dsurface.c and a test for drawing with a color keyed 3D texture in visual.c

1 0

Wine runs IE7!
by Hans Leidekker 26 Nov '10

26 Nov '10

Well, sort of. I found bugs in shell32, rpcrt4, comctl32 and wininet that I had to implement, stub and override my way past before it would render a page, but finally, here's the obligatory screenshot. -Hans

3 2

Re: [PATCH 1/2] kernel32: Don't print a FIXME for languages with ANSI codepage 0.
by Dmitry Timoshkov 26 Nov '10

26 Nov '10

Michael Stefaniuc <mstefani(a)redhat.de> wrote: > if (!(cp = get_lcid_codepage( locale ))) > { > - FIXME("For locale %04x using current ANSI code page\n", locale); > + TRACE("No ANSI codepage for locale %04x. Using current ANSI code page\n", locale); > cp = GetACP(); > } A better changelog would probably sound like "kernel32: Don't print a FIXME for unicode-only languages." since ANSI code page 0 does not exist. -- Dmitry.

2 2

dockFill problem
by Vassilis Virvilis 26 Nov '10

26 Nov '10

Hi everybody, I have the following problem in a .NET application. A form resides in a maximized MDI window. On startup the MDI gets maximized but the form is not although the dockFill property is set. Needless to say that it works on windows. 1) My question is how to debug this - What are the relevant wine debug channels? (+win) 2) What it should happen? Should the application get a maximization message that is missing? 3) Any idea / old patch I could try on wine? 4) Any workaround at the application level I could try to make the application run properly? Thanks .bill

1 0

Wineconf 2011 venue suggestion
by Keith Muir 25 Nov '10

25 Nov '10

Hi, I know 2010 has just finished but could I recommend Edinburgh for 2011? voted above London and Paris by Tripadvisor and Conde nast as a destination and amongst the top ten cities in the world 2008 by Wanderlust. Regards, Keith Muir

3 2

Re: wininet: add a stub for InternetShowSecurityInfoByURL
by Paul Vriens 25 Nov '10

25 Nov '10

On 11/25/2010 03:29 AM, Austin English wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=25278 > Shouldn't you create the A-version and forward to that one in the .spec? -- Cheers, Paul.

2 2

Wineconf pictures
by Marcus Meissner 25 Nov '10

25 Nov '10

Hi folks, Here are my Wineconf pictures: http://www.flickr.com/photos/marcusmeissner/sets/72157625430516298/ (I need to add Jeremy to the group picture as someone noticed. Or photoshop a better one, or at least Martin and Andrew better ;) I also took video of Alexandres keynote as a test, but the audio quality is quite low. Also uploading a 5 minute part takes 2 - 3 hours, so its not yet fully done. http://www.youtube.com/user/msmeissn (reminder to next time dont take it in HD ... as my hands were shaky anyway and I could have taken 20 minutes in 1 piece) Ciao, Marcus

1 0

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status
by James McKenzie 25 Nov '10

25 Nov '10

On 11/24/10 2:23 PM, Borut Razem wrote: > Attached is the forth attempt for the patch. It is traditional to append or suffix with [Try #] so that those who are manually tracking patches can do so and so AJ can skip over your previous attempts if you made several tries between times that he looks at patches. James McKenzie

1 0

Re: Added unit test suite for process functions
by Marvin 25 Nov '10

25 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7260 Your paranoid android. === W98SE (32 bit process) === process.c:59: Test failed: unexpected number of characters: read 0, expected 7 process.c:64: Test failed: unexpected string read: read "", expected "stdout\x0a" process.c:86: Test failed: unexpected number of characters: read 0, expected 8 process.c:91: Test failed: unexpected string read: read "", expected "stdout\x0d\x0a" process.c:108: Test failed: _pclose should return after 2 seconds, but it returned after 0 seconds process.c:119: Test failed: _pclose should return 123, but it returned 0 === WNT4WSSP6 (32 bit process) === process.c:108: Test failed: _pclose should return after 2 seconds, but it returned after 0 seconds process.c:119: Test failed: _pclose should return 123, but it returned 0 === W2KPROSP4 (32 bit process) === process.c:108: Test failed: _pclose should return after 2 seconds, but it returned after 0 seconds === WXPPROSP3 (32 bit process) === process.c:108: Test failed: _pclose should return after 2 seconds, but it returned after 0 seconds === W2K3R2SESP2 (32 bit process) === process.c:108: Test failed: _pclose should return after 2 seconds, but it returned after 0 seconds === W7PROX64 (32 bit process) === process.c:108: Test failed: _pclose should return after 2 seconds, but it returned after 0 seconds === W7PROX64 (64 bit process) === process.c:108: Test failed: _pclose should return after 2 seconds, but it returned after 0 seconds

1 0

Re: msxml3/tests: move domdoc.c schema-related tests to schema.c
by Marvin 25 Nov '10

25 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7259 Your paranoid android. === WVISTAADM (32 bit schema) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [1/2] opengl32/tests: Add tests for special case of SetPixelFormat
by Roderick Colenbrander 24 Nov '10

24 Nov '10

Hi Matijn, What 3D API is this game using? Is it using Direct3D or OpenGL? If it is Direct3D then I have the feeling the 'issue' is getting fixed in the wrong layer. Further I'm not really sure whether we want to allow pixel format 1 to be used at all. In case of Wine all pixel formats are hardware accelerated (okay, the bitmaps one are set to indirect rendering so might be software based depending on the GLX implementation). On Windows you essentially have two GL implementations namely the Microsoft GDI renderer and the OpenGL ICD driver. The first several pixel formats are the ones from the software based GDI renderer... So even though Windows might allow setting pixel format 1 on HDC 0, I don't think it is the right thing to do. Roderick On Sun, Nov 14, 2010 at 9:55 AM, Matijn Woudt <tijnema(a)gmail.com> wrote: > Add tests for special case of SetPixelFormat > > Tests pass on my Windows XP laptop and Windows 7 PC. > The game 'Heart's Medicine Season One' depends on this behaviour. > > > >

4 12

Re: ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class
by Marvin 24 Nov '10

24 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7217 Your paranoid android. === W98SE (32 bit file) === No test summary line found

2 1

Re: [1/2] msvcrt: Fixes multi-byte detection problem with MSVCRT_isleadbyte() (try 2)
by Piotr Caban 24 Nov '10

24 Nov '10

_mbspbrk function needs to be fixed, not isleadbyte. Cheers, Piotr

2 1

Volunteer needed - a Lurker would be perfect!
by Jeremy White 24 Nov '10

24 Nov '10

Hi Folks, Throughout the years, Wine has been lucky to have a procession of great volunteers who work on areas outside the code. And right now, we find ourselves in need of a new Wine Weekly News editor. Zachary Goldberg, our current editor, has really not been able to find the time to keep up and would appreciate it if someone else was willing to volunteer. What we need is someone who is willing to read wine-devel, and perhaps scan wine-users, and put together a periodic high level description of activity within Wine. It probably wouldn't have to be weekly; monthly would be just fine. The only requirements are enough technical background that you can make some sense of the mailing list information, some modest skills with the written word, and the willingness to help. In exchange, you'll earn fame, fortune (well, okay, maybe a free beverage once a year), and the deep satisfaction of being a critical voice for the Wine project. If you're interested, email me privately. Cheers, Jeremy

1 0

Wineconf notes?
by Damjan Jovanovic 24 Nov '10

24 Nov '10

Hi Can those of us that didn't go to Wineconf this year please see some videos/slides/notes from those that did? Thank you Damjan Jovanovic

2 1

Re: msvcrt: Add missing dereference of the time pointer.
by Eryk Wieliczko 24 Nov '10

24 Nov '10

Yes, you're right. Thank you for spotting. Eryk 2010/11/24 Michael Stefaniuc <mstefani(a)redhat.de>: > --- > Eryk, > > I guess this is what you had in mind as checking the pointer for greater > 0 is redundant as it is already not-NULL. > > > > > dlls/msvcrt/time.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/time.c b/dlls/msvcrt/time.c > index 7ccdc7d..4150156 100644 > --- a/dlls/msvcrt/time.c > +++ b/dlls/msvcrt/time.c > @@ -913,7 +913,7 @@ int CDECL MSVCRT__ctime64_s(char *res, MSVCRT_size_t len, const MSVCRT___time64_ > return MSVCRT_EINVAL; > } > res[0] = '\0'; > - if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( time > 0 ) ) > + if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( *time > 0 ) ) > { > *MSVCRT__errno() = MSVCRT_EINVAL; > return MSVCRT_EINVAL; > @@ -946,7 +946,7 @@ int CDECL MSVCRT__ctime32_s(char *res, MSVCRT_size_t len, const MSVCRT___time32_ > return MSVCRT_EINVAL; > } > res[0] = '\0'; > - if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( time > 0 ) ) > + if( !MSVCRT_CHECK_PMT( time != NULL ) || !MSVCRT_CHECK_PMT( *time > 0 ) ) > { > *MSVCRT__errno() = MSVCRT_EINVAL; > return MSVCRT_EINVAL; > -- > 1.7.3.2 >

1 0

COM implementation clean up
by Jacek Caban 24 Nov '10

24 Nov '10

Hi all, As many of you probably know, we currently have no standard way for implementing COM objects in Wine. We use different techniques all over the place. Some of them are better, other are worse or even ugly. Together with Alexandre, we've chosen the technique that we believe is the best known ATM. I've described it on the wiki page: http://wiki.winehq.org/COMGuideline There is a janitorial task to change all our existing code to follow the guideline. Michael is going to use his scripting magics to do the work. The plan is that all the new code should follow the guideline, so if you are touching COM stuff in Wine, please get familiar with it. Any comments are welcomed. Cheers, Jacek

3 2

Re: ntdll: return some sane values for the FileFsVolumeInformation class members in NtQueryVolumeInformationFile.
by Vitaliy Margolen 24 Nov '10

24 Nov '10

On 11/23/2010 01:05 PM, Louis Lenders wrote: > This patch makes previously tests pass and fixes > http://bugs.winehq.org/show_bug.cgi?id=21466. (A search through the registry > on windows showed that at least the VolumeLabel and SerialNumber are not > stored in the registry, so we just return some sane values) > + static const WCHAR volumelabelW[] = {'w','i','n','e','_','d','i','s','k',0}; > + > + info->VolumeSerialNumber = 0x15112000; You should take that info from the volume (as it's done now in GetVolumeInformation) instead of hard-coded invalid values. I'm guessing some of that kernel32 functionality will need to be moved to ntdll. Vitaliy.

1 0

Re: services: Allow one more combined service type
by Paul Vriens 23 Nov '10

23 Nov '10

Hi André, On 11/23/2010 08:45 PM, André Hentschel wrote: > I have a service with type 3, this patch allows him to run. > It runs perfectly and does not produce FIXMEs or ERRORs, so it's fine. > --- Do you have some more information? It's not possible (at least on XP) to create a service that has 'SERVICE_KERNEL_DRIVER | SERVICE_FILE_SYSTEM_DRIVER'. -- Cheers, Paul.

2 2

Re: crypt32/tests: Add tests for decoding enveloped messages.
by Paul Vriens 23 Nov '10

23 Nov '10

Hi Alexander, On 11/02/2010 01:56 PM, Alexander Morozov wrote: > + CryptAcquireContextA(&hCryptProv, NULL, MS_ENHANCED_PROV_A, PROV_RSA_FULL, > + CRYPT_VERIFYCONTEXT); Other calls use pCryptAcquireContextA but I guess that had to do with some platforms in the past that didn't export CryptAcquireContextA. > + SetLastError(0xdeadbeef); > + ret = CryptImportKey(hCryptProv, publicPrivateKeyPair, > + sizeof(publicPrivateKeyPair), 0, 0,&key); > + ok(ret, "CryptImportKey failed: %08x\n", GetLastError()); This one fails on some WinME/NT4 (80090010 aka NTE_PERM) and crashes on some Win98: http://test.winehq.org/data/tests/crypt32:msg.html Could you have a look? If you need me to test something on my boxes (pv-winme and pv-nt4srvr) let me know (not all testbot machines fail here). -- Cheers, Paul.

2 1

Trying to figure out the website redirects
by Scott Ritchie 23 Nov '10

23 Nov '10

Why does http://www.winehq.org/todo redirect to http://wiki.winehq.org/KnownIssues ? The only list of redirects I see in the source is in include/htaccess.sample, however it lists /todo as redirecting to http://wiki.winehq.org/TodoList (which itself isn't a redirect) Are there redirects on the server that aren't in the git source? -Scott Ritchie

1 0

Re: [include] add new macro WINELIB_NAME_W for support in the unicode functions of msvcr* dlls
by Alexandre Julliard 23 Nov '10

23 Nov '10

Vijay Kiran Kamuju <infyquest(a)gmail.com> writes: > Changelog > --------------- > [include] add new macro WINELIB_NAME_W for support in the unicode functions > of msvcr* dlls > It helps functions like _RTC_error_fn and _CRT_RTC_INIT That's not really useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] msvcr90 - rename the stat64i32 functions
by Alexandre Julliard 23 Nov '10

23 Nov '10

Vijay Kiran Kamuju <infyquest(a)gmail.com> writes: > [PATCH 1/2] msvcr90 - rename the stat64i32 functions Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status
by Alexandre Julliard 23 Nov '10

23 Nov '10

Borut Razem <borut.razem(a)siol.net> writes: > +/* TODO: this shold be same as MSVCRT_MAX_FILES defined in file.c. > + The define should be moved to a common header file. Is msvcrt.h the right one? */ > +#define MSVCRT_MAX_FILES 2048 There's no reason to use this here. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine git doesn't build on 10.6.5
by C.W.Betts 23 Nov '10

23 Nov '10

When I try to build wine git on Mac OS X 10.6.5, I get the following error (on clang. I get similar errors using GCC): clang -m32 -c -I../../../wine-git/./dlls/atl -I. -I../../../wine-git/./include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -I/sw/include -m32 -I/sw/include -m32 -o registrar.o ../../../wine-git/./dlls/atl/registrar.c ../../../wine-git/./dlls/atl/registrar.c:747:8: error: use of undeclared identifier 'CLSID_Registrar'; did you mean 'CLSID_ATLRegistrar'? if(IsEqualGUID(&CLSID_Registrar, clsid)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../wine-git/./dlls/atl/registrar.c:747:21: note: instantiated from: if(IsEqualGUID(&CLSID_Registrar, clsid)) ^~~~~~~~~~~~~~~ CLSID_ATLRegistrar In file included from ../../../wine-git/./dlls/atl/registrar.c:32: ./atliface.h:259:1: note: 'CLSID_ATLRegistrar' declared here DEFINE_GUID(... ^ ./atliface.h:259:13: note: instantiated from: DEFINE_GUID(CLSID_ATLRegistrar,... ^ ../../../wine-git/./dlls/atl/registrar.c:796:22: error: use of undeclared identifier 'CLSID_Registrar'; did you mean 'CLSID_RegistrarW'? StringFromGUID2(&CLSID_Registrar, clsid_str, ... ^~~~~~~~~~~~~~~ CLSID_RegistrarW ../../../wine-git/./dlls/atl/registrar.c:789:24: note: 'CLSID_RegistrarW' declared here static const WCHAR CLSID_RegistrarW[] = ^ ../../../wine-git/./dlls/atl/registrar.c:796:21: warning: incompatible pointer types passing 'WCHAR const (*)[16]' to parameter of type 'GUID const *' StringFromGUID2(&CLSID_Registrar, clsid_str, ... ^~~~~~~~~~~~~~~~

2 1

Re: [website 1/2] Add a Donation Page with more Options
by Jeremy White 22 Nov '10

22 Nov '10

Hi André, Several thoughts. I'm not aware of any source of revenue that comes to us via Amazon or CDNow. We might want to remove that. I'm also a bit concerned about the T-shirts; we should get a report on that, I don't know that we've gotten much. Also, we should track this; after we change, we should see how much donations are, and then see if we think it's better or worse than what it was before. It's hard, as donations are quite variable in timing and amount. Cheers, Jeremy

2 1

Re: ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class
by Marvin 22 Nov '10

22 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7222 Your paranoid android. === W98SE (32 bit file) === No test summary line found

1 0

Re: Alexandre Julliard : configure: Disable Fortify if it's enabled by default, it's too broken.
by Marcus Meissner 22 Nov '10

22 Nov '10

On Fri, Oct 22, 2010 at 12:30:48PM -0500, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 105793bff75f6a869bd9ccfb390b2f88fa861235 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=105793bff75f6a869bd9ccfb3… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Oct 22 17:13:57 2010 +0200 > > configure: Disable Fortify if it's enabled by default, it's too broken. What is broken? I could leverage my connections with gcc :/ Ciao, Marcus

2 1

Re: ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class
by Paul Vriens 22 Nov '10

22 Nov '10

On 11/22/2010 07:59 PM, Louis Lenders wrote: > + status = NtQueryVolumeInformationFile( dir,&io, buf, sizeof(buf), FileFsVolumeInformation ); You have to use the 'p' one here to please Win9x where this function is not exported. -- Cheers, Paul.

1 0

Re: [mscoree/tests 4/4] Fix test failures on W2K and earlier
by Vincent Povirk 22 Nov '10

22 Nov '10

I think this test can be removed. I wanted to verify that LoadLibraryShim would succeed for a dll that is absent from the .NET system directory but present in system32. I had heard of LoadLibraryShim succeeding for gdiplus, so I was very surprised when this failed. I was so surprised that I did the same test with gdi32, because I was sure that would never be duplicated. (And it looks like it isn't.) I think that the older versions must have gdiplus in the .NET system directory so that the System.Drawing libraries (which are a thin wrapper around gdiplus) can load it. I guess that .NET searches for libraries in the .NET system directory and the regular path, meaning this is not needed on later versions of Windows that have gdiplus in system32. Anyway, I think this shows that the success or failure is not important in this case, and we don't need the test. On Mon, Nov 22, 2010 at 1:37 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Changelog > Fix test failures on W2K and earlier > > -- > Cheers, > > Paul. > > > > >

2 1

Re: [resend]: [dlls/dbgeng]: add initial stub dll implementation
by Paul Vriens 21 Nov '10

21 Nov '10

On 11/19/2010 03:50 PM, Volodymyr Shcherbyna wrote: > (I am re-sending this patch as gmail did extra formattings to previous > patches) Hi, +MODULE = dbgeng.dll +IMPORTLIB = dbgebg Typo? You also have to use your own wording for the comments, if needed at all, to the functions. You can't just copy-paste from MSDN. -- Cheers, Paul.

4 5

Re: cmd: Fix Italian translation
by Matteo Bruni 21 Nov '10

21 Nov '10

> -L'etichetta che è l'obiettivo di un GOTO può essere lunga fino a 255 caratteri\n\ > +L'etichetta che è la destinazione di un GOTO può essere lunga fino a 255 caratteri\n\ I believe this sentence as a whole sounds quite awkward. Maybe something like "Un'etichetta che sia destinazione di un GOTO..." or simply "L'etichetta di destinazione di un GOTO..." would be better.

2 1

Re: [comctl32/tests 2/2] Get rid of some commented out lines
by Marvin 20 Nov '10

20 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7197 Your paranoid android. === W7PRO (32 bit propsheet) === propsheet.c:524: Test failed: The Add button has not been pressed! propsheet.c:681: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead === W7PROX64 (32 bit propsheet) === propsheet.c:524: Test failed: The Add button has not been pressed! propsheet.c:681: Test failed: property sheet with custom window proc: the msg 0x001c was expected, but got msg 0x0047 instead

1 0

building a winelib dll?
by Seth Burleigh 20 Nov '10

20 Nov '10

Im trying to build a simple winelib. Its not working and is returning 'error 127'. I have some question: (1) how do i determine which functions are exported by wine? All i see using nm zmq.dll.so is the names of my proxy function (add_proxy) instead of the name that is going to be called by the windows program (add) (2) whats the point of a spec file? what im saying is that i can build my files without a spec file and no error message is produced. In what stage of building is the spec file actually used? (3) is there any way to debug just specifically the errors produced by my stub dll under wine? somehow specify a debug channel where the real reason for 'error 127' is? The stub dll being dynamically loaded by a program for which i have no source code. I am using these simple test files: //in zmq.c #include "zmq.h" #include "wine/debug.h" #include <windef.h> long WINAPI add_proxy(long a,long b) { return a+b; } ;;in zmq.dll.spec @ stdcall add( long long ) add_proxy and then i do winegcc -c -o zmq.o zmq.c winegcc -shared -o zmq.dll.so zmq.o However, i notice that i can just get rid of the spec file and no error messages are produced which makes no sense since the dll is supposed to redirect calls to add to add_proxy. And once i use the windows program to call function add, i get the 'error 127', which means it cant find the function 'add.'

1 2

Group Picture Wineconf 2010
by Marcus Meissner 20 Nov '10

20 Nov '10

Hi, The group picture taken this morning: http://www.flickr.com/photos/marcusmeissner/5191522943/ For all the ones who staid at home ;) Ciao, Marcus

2 1

Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status
by Borut Razem 20 Nov '10

20 Nov '10

On 11/18/2010 02:54 PM, Alexandre Julliard wrote > Yes, you need to grow it dynamically. That doesn't mean you need a linear search. Here is the new patch: dynamically allocated array of process handles indexed by fd, no linear search. The patch compiles without errors but I haven't done any tests yet. Please review it and let me know if you are satisfied with the approach. In case of the positive answer I'll do some testing ant let you know about results. P.S.: MSVCRT_MAX_FILES is (re)defined in process.c and should be same as MSVCRT_MAX_FILES in file.c. It would be better to define it only once in a header file, for example in msvcrt.h. Do you agree? Borut --- dlls/msvcrt/process.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 99 insertions(+), 2 deletions(-)

1 0

RE: [dlls/dbgeng]: add initial stub dll implementation
by Volodymyr Shcherbyna 19 Nov '10

19 Nov '10

Hello Alexandre, I assume you were checking my patch (id: 68619) ( http://source.winehq.org/patches/data/68619) and marked it as "Apply Failure". If so, can you please double check? For the sake of the test, I setup wine-git on another machine to see if this patch works, and it seems to be OK. The following commands: patch -p1 < 0001-Implementing-stub-version-of-dbgeng.dll-Debugger-Eng.txt git add dlls/dbgeng/Makefile.in ./tools/make_makefiles autoconf ./configure make properly integrate and build dbgeng in wine tree. I was following exact guidelines from http://wiki.winehq.org/Developers-Hints , and I it seems like the patch is OK, or I am missing something not documented on the wiki :) Well, I am a newbie in wine/linux, so, of course I can be wrong ... P.S. I attach patch to this email just in case (the same patch I sent to wine patch list). Thanks, -- avec meilleures salutations, Volodymyr

2 2

Re: [2/3] msxml3: Validate node content in xmlnode_put_dataType() (resend)
by Jacek Caban 19 Nov '10

19 Nov '10

On 11/19/10 6:22 AM, Adam Martinson wrote: > --- > dlls/msxml3/msxml_private.h | 1 + > dlls/msxml3/node.c | 113 > ++++++++++++++++++++++++++----------------- > dlls/msxml3/schema.c | 94 +++++++++++++++++++++++++++++++++-- > 3 files changed, 158 insertions(+), 50 deletions(-) > @@ -887,71 +891,92 @@ static HRESULT WINAPI xmlnode_put_dataType( { xmlnode *This = impl_from_IXMLDOMNode( iface ); HRESULT hr = E_FAIL; + xmlChar *str; + XDR_DT dt; TRACE("(%p)->(%s)\n", This, debugstr_w(dataTypeName)); if(dataTypeName == NULL) return E_INVALIDARG; + if (This->node->type != XML_ELEMENT_NODE) + return E_FAIL; Again, this should go to element object then. Jacek

1 0

Re: [PATCH 2/3] ws2_32: fix up iovecs after transmission in WS2_send instead of WS2_sendto
by Marvin 19 Nov '10

19 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7173 Your paranoid android. === WXPPROSP3 (32 bit sock) === sock.c:3404: Test failed: Expected event sequence [FD_READ(0)], got [] sock.c:3411: Test failed: Expected event sequence [], got [FD_READ(0)] === WVISTAADM (32 bit sock) === sock.c:862: Test failed: gethostbyname() failed unexpectedly: 11004

1 0

Re: [PATCH 2/3] ws2_32: fix up iovecs after transmission in WS2_send instead of WS2_sendto
by Marvin 19 Nov '10

19 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7171 Your paranoid android. === W98SE (32 bit sock) === sock.c:2661: Test failed: Failed to start overlapped send 0 - 0 - 1048576/1048576

1 0

Re: [PATCH 1/3] ws2_32/tests: add a test for an overlapped send
by Marvin 19 Nov '10

19 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7170 Your paranoid android. === W98SE (32 bit sock) === sock.c:2661: Test failed: Failed to start overlapped send 0 - 0 - 1048576/1048576

1 0

Re: dlls/oledb32: added conversions for I1, I8, UI2, DEC and GetConversionSize
by Dan Kegel 18 Nov '10

18 Nov '10

Hi Andreas, Thanks for helping Wine! A few administrivial issues: Please submit only one attachment per post. Also, please avoid sending HTML mail to wine-patches. See http://wiki.winehq.org/SubmittingPatches - Dan On Thu, Nov 18, 2010 at 4:05 AM, Andreas Pflug <pflug(a)pse-consulting.de> wrote: > > This complements my previous post, which is included for completeness' sake below (0001-OLEDB-xxx) > > convert_DataConvert is extended for the types DBTYPE_I1, DBTYPE_I8 ,DBTYPE_UI2, DBTYPE_DECIMAL. The conversions are performed using the OLEAUT32-Functions VarXXXFromYYY, as far as they exist which made this mostly a carefully handled copy/paste job. > > Conversion DBTYPE_TIMESTAMP<->DBTYPE_DATE have been successfully tested using a commercial app (HIW Rendite 10). > > GetConversionLength has been implemented trivially for fixed-length dstTypes, and partially for var-length types (as far as the app required it). > > > -------- Original-Nachricht -------- > Betreff: dlls/oledb32: added conversions for R8,BOOL,DATE,DBTIMESTAMP > Datum: Wed, 17 Nov 2010 13:45:25 +0100 > Von: Andreas Pflug <pflug(a)pse-consulting.de> > An: wine-patches(a)winehq.org > > convert_DataConvert now know the types DBTYPE_R8, DBTYPE_BOOL, > DBTYPE_DATE and will convert from all source types supported by > VarXXXFromYYY functions. > DBTYPE_TIMESTAMP is supported to convert from and to DBTYPE_DATE. > get_length is extended accordingly. > >

1 0

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. Take 3.
by Alexandre Julliard 18 Nov '10

18 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 304 +++++++++++++++++++++++++++++++++---------------- > 1 files changed, 205 insertions(+), 99 deletions(-) It doesn't build on Mac: gcc -m32 -c -I. -I. -I../../include -I../../include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11/include -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -g -O2 -o freetype.o freetype.c freetype.c: In function 'load_font': freetype.c:1418: error: 'fake_family' undeclared (first use in this function) freetype.c:1418: error: (Each undeclared identifier is reported only once freetype.c:1418: error: for each function it appears in.) make[1]: *** [freetype.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] wined3d: Disallow empty surfaces.
by Stefan Dösinger 18 Nov '10

18 Nov '10

Am Donnerstag 18 November 2010, 12:21:39 schrieb Henri Verbeet: > + if (!resource_size) return WINED3DERR_INVALIDCALL; Shouldn't we add a format flag that controls wether a format can be used to create a resource instead? I'm thinking about the NULL fourcc code that also has a resource size of zero but can be used to create a surface.

2 1

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status
by Alexandre Julliard 18 Nov '10

18 Nov '10

Borut Razem <borut.razem(a)siol.net> writes: > +static void msvcrt_add_handle(MSVCRT_FILE *fp, HANDLE *hProcess) > +{ > + LOCK_POPEN; > + if (fp2handle == NULL) > + { > + /* array not allocated yet: allocate it */ > + if ((fp2handle = MSVCRT_malloc(sizeof (struct fp2handle_s) * 16)) != NULL) > + { > + /* write handles to the first slot */ > + fp2handle[0].fp = fp; > + fp2handle[0].hProcess = hProcess; > + > + /* zero the remaining space */ > + memset(&fp2handle[1], 0, sizeof (struct fp2handle_s) * (16 - 1)); > + > + /* update the number of slots */ > + fp2handle_entries = 16; > + } > + } > + else > + { > + int i; > + > + /* search for free or slot with the same fp */ > + for (i = 0; i < fp2handle_entries; ++i) > + { > + if (fp2handle[i].fp == NULL || fp2handle[i].fp == fp) > + { > + /* found: write handles to the slot */ > + fp2handle[i].fp = fp; > + fp2handle[i].hProcess = hProcess; > + break; > + } > + } > + if (i >= fp2handle_entries) > + { > + /* no space left: double the array size */ > + struct fp2handle_s *newFp2handle; > + > + if ((newFp2handle = MSVCRT_realloc(fp2handle, sizeof (struct fp2handle_s) * (fp2handle_entries * 2))) != NULL) > + { > + fp2handle = newFp2handle; > + > + /* write handles to the first exetended slot */ > + fp2handle[fp2handle_entries].fp = fp; > + fp2handle[fp2handle_entries].hProcess = hProcess; > + > + /* zero the remaining extended space */ > + memset(&fp2handle[fp2handle_entries + 1], 0, sizeof (struct fp2handle_s) * (fp2handle_entries - 1)); > + > + /* update the number of slots */ > + fp2handle_entries *= 2; > + } > + } > + } > + UNLOCK_POPEN; > +} That's an awful lot of code for such a simple thing. You probably want to use an array indexed by file descriptor or something like that. Also please don't add a comment before every line stating what the line does, that should be clear from the code itself. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [3/5] gdi32: Add the ability to load a scalable font resource. Take 3.
by Alexandre Julliard 18 Nov '10

18 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + if (!ReadFile(hfile, &dos, sizeof(dos), NULL, NULL)) > + goto errexit; > + > + if (dos.e_magic != IMAGE_DOS_SIGNATURE) > + goto errexit; > + > + if (SetFilePointer(hfile, dos.e_lfanew, NULL, FILE_BEGIN) == INVALID_SET_FILE_POINTER) > + goto errexit; > + > + if (!ReadFile(hfile, &os2, sizeof(os2), NULL, NULL)) > + goto errexit; Again that's inefficient, you don't want to read it bit by bit. You should read the whole file in one go, or use a memory mapping. If using ReadFile you also have to check the returned size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] ddraw: Return DDERR_INVALIDPARAMS for 0 width / height surface creation.
by Marvin 18 Nov '10

18 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7157 Your paranoid android. === W98SE (32 bit dsurface) === dsurface: unhandled exception c0000005 at 00415849

1 0

RFC: flipping more than one backbuffer on swapchain
by Pavel Procházka 18 Nov '10

18 Nov '10

I had patched IWineGDISwapChainImpl_Present, which can now fully support looping behavior on swapchain for more than one backbuffer. Patch 2/3 allows more backbuffers creation for GDI surfaces, and last patch is test to ddraw.

1 0

Re: mshtml: Removed tests failing on IE7.
by Marvin 18 Nov '10

18 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7145 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [1/3] d3dx9: Implement D3DXFillTexture function.
by Henri Verbeet 17 Nov '10

17 Nov '10

On 17 November 2010 17:23, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > +static BOOL color_match(DWORD *value, DWORD *expected) Those should probably be const.

1 0

wanted: test.avi resource
by Joerg-Cyril.Hoehle＠t-systems.com 17 Nov '10

17 Nov '10

Hi, Currently there are no tests in Wine of mciavi or mciqtz. The reason is incredibly trivial: I'd need a test.avi with defined properties that the tests check, and of course the file should be as small as possible to not weight too much in git. If you happen to know clock.avi (found in some versions of MS-Windows), this comes close. It displays an analog clock with a single clock hand plus numbers from 1 to 12. It ticks one frame per second, showing numbers from 1 to 12 in addition to moving the hand. What I think would be useful is a video with - frames: key - key - delta - key (if delta is possible) - displaying digits 1 - 2 - 3 - 4 - speed: one frame per second - sound would be very useful, but it might increase the file size a lot (3 seconds of sound...). Perhaps MS-ADPCM might well compress a sound file that beeps, then pauses for most of the rest of every second. Beeps at different frequencies would be best. - simplify graphics to minimize disk space. Actually, I don't know whether such an animation with 4 frames would play for 3 seconds (final frame displayed at the end) or 4 (final frame displayed for one second, like the others, then stop). Any volunteer? How would that be incorporated into winetest.exe? As a resource, copied at execution time to the current directory? Thank you for your help, Jörg Höhle

3 2

mciavi should be rewritten using the AVIFile interface
by Joerg-Cyril.Hoehle＠t-systems.com 17 Nov '10

17 Nov '10

Hi, MSDN documents (and I verified) that the MCIAVI allows to access an open AVIFile object via the special name @NN...NN (decimal address). Conversely, open @-1024 type avivideo alias a crashes native at address ffffc000 -- except on w95 (KB140750). This makes it likely that MCIAVI internally uses the AVIFile API (it might also pull the MMIO file handle out of the AVIFile structure). Furthermore, other parameters that the MCI exports, e.g. MCI_ANIM_*_SPEED, map to what the AVIFile objects provide and is not present in MMIO handling, reinforcing the hypothesis that the MCIAVI uses the AVIFile API. Hence mciavi.c should be rewritten to use the AVIFile API. I hope that doing so will prevent a skew that I've observed with some apps, where sound and video rendering do not match after a few seconds. Any volunteers? Any excellent sample code using AVIFile to render both video and audio? Regards, Jörg Höhle

3 2

Re: msvcrt: Add implementation of _strncoll
by Piotr Caban 17 Nov '10

17 Nov '10

Hi, + char * nstr1 = HeapAlloc(GetProcessHeap(), 0, count + 1); + char * nstr2 = HeapAlloc(GetProcessHeap(), 0, count + 1); + + memcpy(nstr1, str1, count + 1); strncoll is used to compare at most count characters (you can't access data after nullbyte). You're not null terminating nstr1 and nstr2 strings. This function should be implemented without memory allocations. Cheers, Piotr

2 4

Re: msvcrt: Add implementation of _strncoll (try 2)
by Dmitry Timoshkov 17 Nov '10

17 Nov '10

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + result = strcoll(nstr1, nstr2); System strcoll() for strings in different encoding won't work properly. -- Dmitry.

1 0

Re: [PATCH 4/4] ddraw/tests: Fix some failure messages.
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7119 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:1376: Test failed: Got color 000a246a, expected 00000080 or near visual.c:1382: Test failed: Got color 006b8bbd, expected 000000ff or near visual.c:1388: Test failed: Got color 00ffffff, expected 00000080 or near visual.c:1394: Test failed: Got color 00ffffff, expected 000000ff or near

1 0

Icons for hh and winebrowser
by Damjan Jovanovic 17 Nov '10

17 Nov '10

Hi Could whoever draws icons for Wine please add icons for programs/hh and programs/winebrowser? I've made a patch (http://source.winehq.org/patches/data/68572) which generates icons for Wine applications in the file browser "Open with" list, and these applications are just getting a wineglass. Thank you Damjan Jovanovic

2 1

Re: [1/3] msxml3: Use the associated schema for domelem_get_dataType()
by Jacek Caban 17 Nov '10

17 Nov '10

Hi Adam, On 11/16/10 23:00, Adam Martinson wrote: > --- > dlls/msxml3/element.c | 95 +++++++++++++- > dlls/msxml3/msxml_private.h | 1 + > dlls/msxml3/node.c | 248 ++++++++++++++++++++++++++++++++++-- > dlls/msxml3/tests/domdoc.c | 301 > +++++++++++++++++++++++++++++++++++-------- > 4 files changed, 574 insertions(+), 71 deletions(-) + if(This->node->type == XML_ELEMENT_NODE) + { + XDR_DT dt = element_get_dt(This->node); + content = xmlNodeGetContent(This->node); + hres = VARIANT_from_DT(dt, content, typedValue); + xmlFree(content); + } + else if (This->node->type == XML_TEXT_NODE || + This->node->type == XML_ENTITY_REF_NODE) + { Please use inheritance for this. We're in process of getting rid of xmlnode_* functions. Such differences in implementation should be handled in node type-specific objects. Jacek

1 0

Re: [1/2] comctl32/treeview: Use a code set by dispinfo holder to convert data encoding after TVN_GETDISPINFO
by Alexandre Julliard 17 Nov '10

17 Nov '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > hTree = create_treeview_control(); > - fill_tree(hTree); > +// fill_tree(hTree); You probably don't want this. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] [Kernel32,Server]: implemented GetConsoleProcessList
by Alexandre Julliard 17 Nov '10

17 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > + if ((cpl.console = console_input_get( req->handle, FILE_READ_PROPERTIES ))) > + { > + data_size_t sz; > + > + reply->num_processes = sz = cpl.console->num_proc; > + > + if ((sz *= sizeof(process_id_t)) <= get_reply_max_size()) That's much harder to read than necessary. Please set sz in a more conventional manner. > +/* Get console's process list */ > +@REQ(get_console_process_list) > + obj_handle_t handle; /* handle to console input (0 for current process console) */ > +@REPLY > + int num_processes; /* number of processes attached to this console */ > + VARARG(pidlist,ints); /* process list */ Please add a proper tracing function for process ids, they would be hard to recognize as ints. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] msxml3: Use the associated schema for domelem_get_dataType()
by Alexandre Julliard 17 Nov '10

17 Nov '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > + todo_wine ole_check(IXMLDOMNode_get_nodeTypedValue(node, &v)); > + /* TODO: which platforms return VT_UI8? */ > + todo_wine ok(V_VT(&v) == VT_NULL, "got variant type %i\n", V_VT(&v)); > + if (V_VT(&v) == VT_UI8) > + todo_wine ok(V_UI8(&v) == 0xFFFFFFFFFFFFFFFFULL, "got %016llx\n", V_UI8(&v)); Please avoid long long constants and printf formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

mciseq should be rewritten using winmm's midiStreamOut interface
by Joerg-Cyril.Hoehle＠t-systems.com 17 Nov '10

17 Nov '10

Hi, midiOutShortMsg() is an incredibly bad API for SW synths. It's just good enough at the lowest level, to throw bytes to the serial hardware. It is antithetical to buffering. The machine is stressed to obey the event ASAP, which is travelling across several threads that hence need be set as time-critical each, until a note is eventually produced. No wonder there's stuttering with some apps. OTOH, analyzing several events in advance in a stream buffer, the SW synth would have a lot of time to produce excellent quality output. Consequently, Wine's MCISEQ should use WINMM's midiStream interface. Then, the individual audio drivers should implement MIDICAPS_STREAM. (Alas I don't know what MODM_ message corresponds to this.) WineOSS.drv could then make use of SEQ_DELTA_TIME() and throw a whole buffer of events at OSS' MIDI interface, instead of relying on SEQ_DUMPBUF() to immediately start processing a tiny one note "buffer". This implies that Wine must be able to mix several streams by event timestamp, duplicating what MacOS' CoreMIDI can. Perhaps this can be delegated to the OS? Unless it's easier to leave mixing in the file parser, which is what MIDI_mciFindNextEvent() currently does, generating one stream per file instead of one per track. Converting a .mid to streams of MIDIEVENT might be useful as well should Wine ever implement DirectMusic. It may also help implement MCI_SEQ_FORMAT_SONGPTR which is MCISEQ's default time format on native for all .mid files I tried, not milliseconds or bytes. Tests with MCI_SEEK show that the native MCI cannot seek exactly to arbitrary milliseconds, instead it steps in units of "song pointer". Any volunteers? What's the recommended place (what Wiki page?) to add this as Wine task so every potential taker looking for a job can see it? Regards, Jörg Höhle

1 0

TestBot IPv6 enabled
by Greg Geldorp 17 Nov '10

17 Nov '10

Hi, All TestBot VMs (with the exception of the Win9x ones) now have IPv6 connectivity. I was surprised that there was even a IPv6 stack available for NT4, it was produced by Microsoft Research. The VMs are (and always have been) behind a IPv4 NAT router. That same router now acts as a IPv6 router/firewall, with full outbound access but blocked inbound access. The website is also IPv6 capable, just waiting for the AAAA record to be added to the nameserver. Greg.

3 6

Re: 回复： how to use wcslen() in wine?
by Damjan Jovanovic 17 Nov '10

17 Nov '10

Add -DUNICODE to the wineg++ options. TCHAR is char without it. 2010/11/17 飞翔 <gengjia.ding(a)qq.com> > I try as you said in my program as below: > #include <windows.h> > #include <stdio.h> > #include <wchar.h> > > int main() > { > DWORD dwItems = 1; > TCHAR ptszIPAddress[32] = TEXT("125.216.242.251"); > dwItems = (DWORD)wcslen((const wchar_t*)ptszIPAddress) + 1; > printf("dwItems %d\n", dwItems); > return 0; > } > but the result of the variable dwItems is 9, while in Windows environment > is 16, why? > > > > > ------------------ 原始邮件 ------------------ > *发件人:* "Damjan Jovanovic"<damjan.jov(a)gmail.com>; > *发送时间:* 2010年11月16日(星期二) 凌晨2:14 > *收件人:* "飞翔"<gengjia.ding(a)qq.com>; > *抄送:* "wine-devel"<wine-devel(a)winehq.org>; > *主题:* Re: how to use wcslen() in wine? > > Try: > wineg++ -I /usr/include/wine/include/msvcrt file.cpp -o file -lmsvcrt > > 2010/11/15 飞翔 <gengjia.ding(a)qq.com> > > > > > > > > hello, I'm developing under Wine environment. > > I'm using Unicode and I want to be able to use standard library call > wcslen, but I don't know how to change my C library from the native glibc C > library to the msvcrt C library. > > As it is described in "Winelib_User's_Guide":"In these cases you should > use msvcrt to provide your C runtime calls. > > import msvcrt.dll > > to your applications .spec file." > > I'm using wineg++ to compile the .cpp & .h files, there is no .spec file, > how can I import the DLL? > > May you please help me? Thanks very much! > > > > > > ------------------ > > Where there is a will, there is a way! > > ------------------ > > 丁耿佳 > > Gavin-Ding > > Computer Science and Technology，South China University of Technology > > Email: gj.ding(a)mail.scut.edu.cn > > gengjia.ding(a)gmail.com > > gengjia.ding(a)qq.com > > Mailing Address: 339, Building C12, SCUT, GuangzhouHigher Education Mega > Center, Guangzhou, China > > Postcode:510006 > > > > > > > > > > >

1 0

Re: [1/2] comctl32/treeview: Use a code set by dispinfo holder to convert data encoding after TVN_GETDISPINFO
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7104 Your paranoid android. === WVISTAADM (32 bit treeview) === treeview.c:1349: Test failed: got 0xffffffff treeview.c:1355: Test failed: got 0xffffffff

2 1

Re: [2/3] oleaut32: Use strtoull() instead of multiplication during variant conversion
by Nikolay Sivov 17 Nov '10

17 Nov '10

On 11/17/2010 02:00, Adam Martinson wrote: > --- > dlls/msxml3/tests/domdoc.c | 4 ++-- > dlls/oleaut32/variant.c | 17 +++++++++-------- > 2 files changed, 11 insertions(+), 10 deletions(-) > If oleaut32 needs a fix like this, please add a test for it in oleaut32/tests, fixed msxml tests will be a side effect. > */ > BOOL bOverflow = FALSE, bNegative; > ULONG64 ul64 = 0; You don't need this initialization now. > + char tmp[1024], *end; Does this buffer size really make sense if you're getting ULONG64 from this string? > int i; > > /* Convert the integer part of the number into a UI8 */ > - for (i = 0; i< wholeNumberDigits; i++) > + for (i = 0; i< wholeNumberDigits; ++i) > + tmp[i] = rgbDig[i] + '0'; > + tmp[wholeNumberDigits] = 0; > + > + ul64 = strtoull(tmp,&end, 10); > + if (end !=&tmp[wholeNumberDigits]) > { > - if (ul64> (UI8_MAX / 10 - rgbDig[i])) > - { > - TRACE("Overflow multiplying digits\n"); > - bOverflow = TRUE; > - break; > - } > - ul64 = ul64 * 10 + rgbDig[i]; > + TRACE("Overflow reading digits\n"); > + bOverflow = TRUE; > } >

1 0

Re: comctl32/listview: Use a code set by dispinfo holder to convert data encoding after LVN_GETDISPINFO
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7103 Your paranoid android. === W7PRO (32 bit listview) === listview.c:4458: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4463: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === W7PROX64 (32 bit listview) === listview.c:4458: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4463: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Re: [PATCH 5/5] shell32/tests: Added SHPropStg* tests (try2)
by Alexandre Julliard 16 Nov '10

16 Nov '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/shell32/tests/Makefile.in | 1 + > dlls/shell32/tests/misc.c | 437 > ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 438 insertions(+), 0 deletions(-) > create mode 100644 dlls/shell32/tests/misc.c It would be better to either put those in an existing file, or create a shellole.c file. misc.c is not a very informative name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: Avoid console flood with an ERR message
by Alexandre Julliard 16 Nov '10

16 Nov '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -3657,7 +3657,14 @@ HRESULT WINAPI CoWaitForMultipleHandles(DWORD dwFlags, DWORD dwTimeout, > } > else > { > - ERR("Unexpected wait termination: %d, %d\n", res, GetLastError()); > + static DWORD old_res; > + static DWORD old_lasterror; > + if ((res != old_res) || (GetLastError() != old_lasterror)) > + { > + old_res = res; > + old_lasterror = GetLastError(); > + ERR("Unexpected wait termination: %d, %d\n", res, GetLastError()); > + } That's just hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] gdi32: Implement CreateScalableFontResource, based on a patch by Jeremy White.
by Alexandre Julliard 16 Nov '10

16 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + /* empty type info */ > + memset(&rc_type, 0, sizeof(rc_type)); > + if (!WriteFile(hfile, &rc_type, sizeof(rc_type), &dummy, NULL)) return FALSE; > + > + if (!WriteFile(hfile, "\7FONTDIR", 8, &dummy, NULL)) return FALSE; > + str_len = strlen(resident_name); > + if (!WriteFile(hfile, &str_len, 1, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, resident_name, str_len, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, filler, 5, &dummy, NULL)) return FALSE; > + > + str_len = strlen(non_resident_name); > + if (!WriteFile(hfile, &str_len, 1, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, non_resident_name, str_len, &dummy, NULL)) return FALSE; > + /* terminator */ > + if (!WriteFile(hfile, filler, 1, &dummy, NULL)) return FALSE; > + > + /* empty ne_modtab and ne_imptab */ > + if (!WriteFile(hfile, filler, 2, &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; > + > + if (!WriteFile(hfile, fd, fd->dfSize, &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; > + > + if (!WriteFile(hfile, ttf_file_nameA, strlen(ttf_file_nameA), &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; That's ugly and inefficient. The data should be built into a memory buffer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. (resend)
by Alexandre Julliard 16 Nov '10

16 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -365,7 +365,7 @@ static struct list system_links = LIST_INIT(system_links); > > static struct list font_subst_list = LIST_INIT(font_subst_list); > > -static struct list font_list = LIST_INIT(font_list); > +static struct list global_font_list = LIST_INIT(global_font_list); I don't see any reason to rename the variable, that makes the patch much larger than necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add new debuglevel 2 for showing broken behaviours as failed
by Alexandre Julliard 16 Nov '10

16 Nov '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -285,7 +285,7 @@ void winetest_set_location( const char* file, int line ) > > int broken( int condition ) > { > - return (strcmp(winetest_platform, "windows") == 0) && condition; > + return (strcmp(winetest_platform, "windows") == 0) && condition && winetest_debug < 2; > } You can already change the platform, there's no need for a new mechanism. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Set alpha channel to 0 for pixels with color key
by Henri Verbeet 16 Nov '10

16 Nov '10

On 16 November 2010 12:46, Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > Hello, > > This is patch for bug: > http://bugs.winehq.org/show_bug.cgi?id=23750 > > Current DirectDraw implementation doesn't process color key correctly. > I have add manually pixels color checking on surface loading because don't > able to find GL function to do this. > This patch is wrong. Color key processing happens mostly in d3dfmt_convert_surface(), you should try to figure out why it isn't happening for this application. Some more general points are that perform_color_key() would need to be static, casting void pointer is redundant, the color key is a range, not a single value, and try to use consistent formatting.

2 1

Re: [PATCH 5/5] shell32/tests: Added SHPropStg* tests
by Marvin 16 Nov '10

16 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7088 Your paranoid android. === WVISTAADM (32 bit misc) === misc: unhandled exception c0000005 at 767CA659 === W2K8SE (32 bit misc) === misc: unhandled exception c0000005 at 75A29E4D === W7PRO (32 bit misc) === misc: unhandled exception c0000005 at 76C59DAE === W7PROX64 (32 bit misc) === misc: unhandled exception c0000005 at 74D79DAE === W7PROX64 (64 bit misc) === Timeout

1 0

Developing on 64 bit Ubuntu? Add the Wine PPA for new ia32-libs that supports gstreamer codecs
by Scott Ritchie 16 Nov '10

16 Nov '10

The ia32-libs that ships with Ubuntu doesn't contain 32 bit libraries for all the useful codecs of gstreamer. There's enough to build Wine, but not enough to actually show a video. I've fixed this in the ia32-libs on the Wine PPA by adding _73_ new libraries to it. This is something you'll want even if you're not using the wine packages and just doing Wine development. Thankfully, ia32-libs should be finally obsolete by 11.04 with multiarch, but in the meantime we can use the PPA. I'll work on porting the ia32-libs changes to 10.04 and 9.10, but it's less of a priority. On those we have other problems (such as old GCC versions causing problems). Thanks, Scott Ritchie

1 0

Re: [PATCH] console: fix output for console handles opened with GENERIC_WRITE access
by Martin Wilck 15 Nov '10

15 Nov '10

Hi Eric, hi everyone, as you may already know, my patch is obsoleted by your commit 91e3a40e412a6c04cfaf8f6d0d3d16a1a4c4bfdb. Thanks! Martin -- Dr. Martin Wilck <Martin.Wilck(a)particle-dynamics.de> Physicist and Software Engineer particle dynamics GmbH, Leipzig Geschäftsführer (Director): Markus Fait Handelsregister (Trade Register): HRB 19578 AG Leipzig Richterstr. 1, 04105 Leipzig, Germany Tel. ++49-341-9849387 Fax. ++49-341-9849377 http://www.particle-dynamics.de

1 0

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::swap implementation. (try 2)
by Piotr Caban 15 Nov '10

15 Nov '10

On 11/15/10 18:26, Vincas Miliūnas wrote: > The way I see this is that the code above handles the case when lhs string is in the local buffer and rhs is allocated. The exchange requires copying (lhs->data->buf into rhs->data->buf and rhs->data->ptr into lhs->data->ptr), since setting one's ptr to other's buf would be illegal. Also, the ptr and buf are in an union construct and overlap, therefore only one can be stored at a time. You can copy whole union without knowing what field is used. This way you can implement it with only one else statement. + if (this == str) + { Please try to follow coding style used in modified file (no space after if, new block bracket in the same line).

1 0

how to use wcslen() in wine?
by 飞翔 15 Nov '10

15 Nov '10

hello, I'm developing under Wine environment. I'm using Unicode and I want to be able to use standard library call wcslen, but I don't know how to change my C library from the native glibc C library to the msvcrt C library. As it is described in "Winelib_User's_Guide":"In these cases you should use msvcrt to provide your C runtime calls. import msvcrt.dll to your applications .spec file." I'm using wineg++ to compile the .cpp & .h files, there is no .spec file, how can I import the DLL? May you please help me? Thanks very much! ------------------ Where there is a will, there is a way! ------------------ 丁耿佳 Gavin-Ding Computer Science and Technology， South China University of Technology Email: gj.ding(a)mail.scut.edu.cn gengjia.ding(a)gmail.com gengjia.ding(a)qq.com Mailing Address: 339, Building C12, SCUT, Guangzhou Higher Education Mega Center, Guangzhou, China Postcode:510006

2 1

Kernel APC in Wine?
by Joerg-Cyril.Hoehle＠t-systems.com 15 Nov '10

15 Nov '10

Hi, my WINMM callback tests (cf. bug #3930, comments 37+38) showed that most MOM_ callbacks were executed in my own thread! The only way I know how to achieve this is to use an APC as in QueueUserAPC(). However, reading MSDN again, it seems like user-mode APC are never invoked unless the app uses the Wait*Ex() functions instead of the regular ones likes WaitForMultipleObjects() or Sleep(). As I can't expect a random app to use these, I assume that either - something confused me and I'm on the wrong track, or - native's winmm uses kernel APC, not user ones, and kernel APC are invoked even with plain Wait* calls, or - user APC are executed with plain Sleep/Wait*() (non ~Ex) too. Does Wine have something like kernel APC? What other mechanism exist that could allow a player loop inside WINMM to invoke callbacks in the application's thread context? BTW, I find it's a good idea from MS to execute callbacks in the caller's thread. This avoids common pitfalls and nasty bugs. Is there potential trouble with APC in Wine on 64 bit? MSDN recommends against posting an APC to a thread in another process. Thank you for your help, Jörg Höhle

1 0

Re: winecoreaudio: OSStatus is not necessarily a FOURCC.
by Michael Stefaniuc 15 Nov '10

15 Nov '10

Hi! Joerg-Cyril.Hoehle(a)t-systems.com wrote: > This fixes the string from midi.ok mentioned in bug #21589 > err:wave:AudioUnit_GetVolume > AudioUnitGetParameter return an error "\xff\xff\xd5\x8e" > Now it will print a signed integer instead: > -10866 aka. kAudioUnitErr_InvalidScope > > As to whether that function should stay "inline", I don't know. Doesn't really matter as "inline" is just a hint to the compiler and the compiler is free to ignore it. bye michael

1 0

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::swap implementation.
by Piotr Caban 15 Nov '10

15 Nov '10

On 11/11/10 18:55, Vincas Miliūnas wrote: > This implementation handles cases when basic_strings are allocated using different allocators, however WINE's implementation seems to ignore allocators. It's not ignoring allocators (but it's not setting allocator field). There's no legal way of accessing it by end user, so there's no point of setting it, unless it's needed internally (and it's not needed for correct implementation of basic_string_char_swap function). +/* Helper function for MSVCP_basic_string_char_swap */ +void basic_string_char_swap_bufxptr_same_alloc(basic_string_char * lhs, basic_string_char * rhs) +{ + char * const ptr = rhs->data.ptr; + const size_t size = rhs->size; + const size_t res = rhs->res; + + memcpy(rhs->data.buf, lhs->data.buf, lhs->size * sizeof(char)); This function should work in constant time. It should only swap pointers and lengths. +/* Helper function for MSVCP_basic_string_char_swap */ +MSVCP_BOOL basic_string_char_swap_bufxptr_diff_alloc(basic_string_char * lhs, basic_string_char * rhs) +{ + char tmp[BUF_SIZE_CHAR]; + const size_t size = lhs->size; + const size_t res = lhs->res; + memcpy(tmp, lhs->data.buf, lhs->size * sizeof(char)); + + char * const ptr = MSVCP_allocator_char_allocate(lhs->allocator, rhs->res); You can't pass unknown data to MSVCP_allocator_char_allocate, this is the implementation of default char allocator. When other allocators are in use compiler will use templates. The function you're implementing is only used when two basic_string_char are swapped, because there's no legal way of modifying allocator field there's only one case - the same allocators are used. Cheers, Piotr

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6
by James McKenzie 14 Nov '10

14 Nov '10

On 11/5/10 8:17 AM, Charles Davis wrote: > Changes since try 5: > o All case-sensitivity logic has been absorbed into find_file_in_dir(). > o Eliminated one more stat(2) that I missed last time. > o Eliminated a statfs(2) call on Linux. > > This is a far as I think I can take it without gutting it completely. If > any of you have better ideas, I'd like to hear them. > --- > dlls/ntdll/directory.c | 233 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 229 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c > index 865c2fa..2891792 100644 > --- a/dlls/ntdll/directory.c > +++ b/dlls/ntdll/directory.c > @@ -41,6 +41,9 @@ > #ifdef HAVE_SYS_STAT_H > # include<sys/stat.h> > #endif > +#ifdef HAVE_SYS_ATTR_H > +#include<sys/attr.h> > +#endif > #ifdef HAVE_SYS_IOCTL_H > #include<sys/ioctl.h> > #endif > @@ -56,6 +59,9 @@ > #ifdef HAVE_SYS_MOUNT_H > #include<sys/mount.h> > #endif > +#ifdef HAVE_SYS_STATFS_H > +#include<sys/statfs.h> > +#endif > #include<time.h> > #ifdef HAVE_UNISTD_H > # include<unistd.h> > @@ -130,6 +136,35 @@ static inline int getdents64( int fd, char *de, unsigned int size ) > > #endif /* linux */ > > +#if defined(HAVE_GETATTRLIST) > + > +struct get_fsid > +{ > + ULONG size; > + dev_t dev; > + fsid_t fsid; > +}; > + > +struct fs_cache > +{ > + dev_t dev; > + fsid_t fsid; > + BOOLEAN case_sensitive; > +} fs_cache[64]; > + > +#if defined(ATTR_VOL_CAPABILITIES)&& defined(VOL_CAPABILITIES_FORMAT)&& \ > + defined(VOL_CAP_FMT_CASE_SENSITIVE) > + > +struct vol_caps > +{ > + ULONG size; > + vol_capabilities_attr_t caps; > +}; > + > +#endif /* ATTR_VOL_CAPABILITIES */ > + > +#endif /* HAVE_GETATTRLIST */ > + > #define IS_OPTION_TRUE(ch) ((ch) == 'y' || (ch) == 'Y' || (ch) == 't' || (ch) == 'T' || (ch) == '1') > #define IS_SEPARATOR(ch) ((ch) == '\\' || (ch) == '/') > > @@ -783,6 +818,192 @@ static char *get_device_mount_point( dev_t dev ) > } > > > + > +#ifdef HAVE_GETATTRLIST > +/*********************************************************************** > + * look_up_fs_cache > + * > + * Checks if the specified file system is in the cache. > + */ > +static struct fs_cache *look_up_fs_cache( dev_t dev ) > +{ > + int i; > + for (i = 0; i< sizeof(fs_cache)/sizeof(fs_cache[0]); i++) > + if (fs_cache[i].dev == dev) > + return fs_cache+i; > + return NULL; > +} > + > +/*********************************************************************** > + * add_fs_cache > + * > + * Adds the specified file system to the cache. > + */ > +static void add_fs_cache( dev_t dev, fsid_t fsid, BOOLEAN case_sensitive ) > +{ > + int i; > + struct fs_cache *entry = look_up_fs_cache( dev ); > + static int once = 0; > + if (entry) > + { > + /* Update the cache */ > + entry->fsid = fsid; > + entry->case_sensitive = case_sensitive; > + return; > + } > + > + /* Add a new entry */ > + for (i = 0; i< sizeof(fs_cache)/sizeof(fs_cache[0]); i++) > + if (fs_cache[i].dev == 0) > + { > + /* This entry is empty, use it */ > + fs_cache[i].dev = dev; > + fs_cache[i].fsid = fsid; > + fs_cache[i].case_sensitive = case_sensitive; > + return; > + } > + > + /* Cache is out of space, warn */ > + if (once++) > + WARN( "FS cache is out of space, expect performance problems\n" ); > +} > +#endif > + > +/*********************************************************************** > + * get_dir_case_sensitivity > + * > + * Checks if the volume containing the specified directory is case > + * sensitive or not. > + */ > +static BOOLEAN get_dir_case_sensitivity( const char *dir ) > +{ > +#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > + struct statfs stfs; > +#elif defined(__NetBSD__) > + struct statvfs stfs; > +#elif defined(__linux__) > + struct stat st; > + char *cifile; > +#endif > + > +#if defined(HAVE_GETATTRLIST)&& defined(ATTR_VOL_CAPABILITIES)&& \ > + defined(VOL_CAPABILITIES_FORMAT)&& defined(VOL_CAP_FMT_CASE_SENSITIVE) > + char *mntpoint = NULL; > + struct attrlist attr; > + struct vol_caps caps; > + struct get_fsid get_fsid; > + struct fs_cache *entry; > + > + /* First get the FS ID of the volume */ > + attr.bitmapcount = ATTR_BIT_MAP_COUNT; > + attr.reserved = 0; > + attr.commonattr = ATTR_CMN_DEVID|ATTR_CMN_FSID; > + attr.volattr = attr.dirattr = attr.fileattr = attr.forkattr = 0; > + get_fsid.size = 0; > + if (getattrlist( dir,&attr,&get_fsid, sizeof(get_fsid), 0 ) != 0 || > + get_fsid.size != sizeof(get_fsid)) > + return TRUE; > + /* Try to look it up in the cache */ > + entry = look_up_fs_cache( get_fsid.dev ); > + if (entry&& !memcmp(&entry->fsid,&get_fsid.fsid, sizeof(fsid_t) )) > + /* Cache lookup succeeded */ > + return entry->case_sensitive; > + /* Cache is stale at this point, we have to update it */ > + > + mntpoint = get_device_mount_point( get_fsid.dev ); > + /* Now look up the case-sensitivity */ > + attr.commonattr = 0; > + attr.volattr = ATTR_VOL_INFO|ATTR_VOL_CAPABILITIES; > + if (getattrlist( mntpoint,&attr,&caps, sizeof(caps), 0 ) == 0) > + { > + if (caps.size == sizeof(caps)&& > + (caps.caps.valid[VOL_CAPABILITIES_FORMAT]& > + (VOL_CAP_FMT_CASE_SENSITIVE | VOL_CAP_FMT_CASE_PRESERVING)) == > + (VOL_CAP_FMT_CASE_SENSITIVE | VOL_CAP_FMT_CASE_PRESERVING)) > + { > + BOOLEAN ret; > + > + RtlFreeHeap( GetProcessHeap(), 0, mntpoint ); > + if ((caps.caps.capabilities[VOL_CAPABILITIES_FORMAT]& > + VOL_CAP_FMT_CASE_SENSITIVE) != VOL_CAP_FMT_CASE_SENSITIVE) > + ret = FALSE; > + ret = TRUE; > + /* Update the cache */ > + add_fs_cache( get_fsid.dev, get_fsid.fsid, ret ); > + return ret; > + } > + } > + RtlFreeHeap( GetProcessHeap(), 0, mntpoint ); > + /* Fall through */ > +#endif > +#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > + statfs( dir,&stfs ); > + /* Assume these file systems are always case insensitive on Mac OS. Don't do this. Quake2 and quake2 turn out to be different (and I tried to move to a directory called Quake2 using cd $HOME/wine.../drive_c/quake2 and received an error this morning [Yes, I'm playing Quake2 on my Mac, I really, really need the stress relief, it is really hard to explain.}) > + * For FreeBSD, only assume CIOPFS is case insensitive (AFAIK, Mac OS > + * is the only UNIX that supports case-insensitive lookup). > + */

2 1

Haiku talking about wine
by Dan Kegel 14 Nov '10

14 Nov '10

Seems to have been a long thread recently about restarting a port of Wine to Haiku, see http://haikuware.com/bounty-discussion/1533-wine-bounty I don't think there was anything really happening, though.

1 0

Re: [PATCH] d3dcompiler: Add initial reflection parsing.
by Henri Verbeet 14 Nov '10

14 Nov '10

2010/11/14 Rico Schüller <kgbricola(a)web.de>: > +HRESULT d3dcompiler_shader_reflection_init(const void *data, SIZE_T data_size, void **reflector) Allocation and initialization are different things. Either way, it's unnecessary to make "reflector" void **. > + if (!IsEqualGUID(riid, &IID_ID3D11ShaderReflection)) > { > - ERR("Failed to allocate D3D compiler shader reflection object memory\n"); > - return E_OUTOFMEMORY; > + WARN("Wrong riid %s, accept only %s!\n", debugstr_guid(riid), debugstr_guid(&IID_ID3D11ShaderReflection)); > + return E_FAIL; > } I'm not sure if you have tests for this returning E_FAIL, but typically you'd expect E_NOINTERFACE for something like that.

1 0

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite
by Henri Verbeet 14 Nov '10

14 Nov '10

On 12 November 2010 21:08, Travis Athougies <iammisc(a)gmail.com> wrote: > + static struct hlsl_probe_info sin_probes[] = This should be const. As a general rule, try to pay attention to at least other patches to the same module. I fixed a couple of these about two weeks ago. Same goes for calculating the probe count. > + { > + {0, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {1, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {2, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {3, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {4, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {5, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {6, 0, {0.9620f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {7, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {8, 0, {1.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {9, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {10, 0, {0.9619f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {11, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {12, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {13, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {14, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {15, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {16, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {17, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {18, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {19, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {20, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {21, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {22, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {23, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {24, 0, {0.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {25, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {26, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {27, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {28, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {29, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {30, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {31, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + }; > + 32 probes is probably a bit excessive, but I guess it's not a major problem. Note that you can easily return the cosine results in the .y component though, instead of duplicating the complete test.

1 0

Re: wined3d: remove a useless variable
by Nikolay Sivov 14 Nov '10

14 Nov '10

On 11/14/2010 22:17, David Adam wrote: > if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > return; > } Why is it useless?

2 3

Re: wined3d: remove a useless variable
by André Hentschel 14 Nov '10

14 Nov '10

> > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > Why is that useless? It supresses console flooding. -- Best Regards, André Hentschel

1 0

Re: [msi/tests] Cleanup properly on Win9x
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7053 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [PATCH 10/10] mshtml: Added document fragment cloneNode implementation.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7048 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/10] mshtml: Correctly handle DOCUMENT_FRAGMENT_NODE in IHTMLDOMNode::get_nodeType.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7045 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [5/5] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7042 Your paranoid android. === W98SE (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: [4/4] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7041 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Compilation error with latest wine
by Luca Bennati 14 Nov '10

14 Nov '10

I get this: registrar.c: In function ‘DllGetClassObject’: registrar.c:747:18: error: ‘CLSID_Registrar’ undeclared (first use in this function) registrar.c:747:18: note: each undeclared identifier is reported only once for each function it appears in registrar.c: In function ‘do_register_server’: registrar.c:796:22: error: ‘CLSID_Registrar’ undeclared (first use in this function) make[1]: *** [registrar.o] Error 1 make[1]: Leaving directory `/home/luca/wine-git/dlls/atl' make: *** [dlls/atl] Error 2 make: *** Waiting for unfinished jobs.... I'm compiling with "CFLAGS=' -g -O0 -pipe' CXXFLAGS=' -g -O0 -pipe' ./configure --prefix=/usr --sysconfdir=/etc --with-x --without-capi --without-gsm --without-icns" after a make distclean What's wrong here?

6 8

Re: widl: Fix for typelib generation when unaligned access to memory is not allowed
by Marcus Meissner 13 Nov '10

13 Nov '10

On Sat, Nov 13, 2010 at 07:02:02PM +0100, André Hentschel wrote: > caused a "Bus error" on sparc > --- > tools/widl/write_msft.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index da4eb25..5175b73 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -1208,7 +1208,11 @@ static void write_value(msft_typelib_t* typelib, int *out, int vt, const void *v > int len = strlen(s), seg_len = (len + 6 + 3) & ~0x3; > int offset = ctl2_alloc_segment(typelib, MSFT_SEG_CUSTDATA, seg_len, 0); > *((unsigned short *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset]) = vt; > - *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#ifdef ALLOW_UNALIGNED_ACCESS > + *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#else > + memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2], &len, sizeof(len)); > +#endif > memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+6], value, len); Just do the memcpy unconditional. Ciao, Marcus

1 0

Re: [PATCH 3/4] shell32: Some events are sent twice in SHChangeNotify
by Marvin 13 Nov '10

13 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7032 Your paranoid android. === W98SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called === WNT4WSSP6 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2KPROSP4 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === WVISTAADM (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2K8SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PRO (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (64 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel