- wine-devel - winehq.org

Re: [1/2] comctl32/treeview: Use a code set by dispinfo holder to convert data encoding after TVN_GETDISPINFO
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7104 Your paranoid android. === WVISTAADM (32 bit treeview) === treeview.c:1349: Test failed: got 0xffffffff treeview.c:1355: Test failed: got 0xffffffff

2 1

Re: [2/3] oleaut32: Use strtoull() instead of multiplication during variant conversion
by Nikolay Sivov 17 Nov '10

17 Nov '10

On 11/17/2010 02:00, Adam Martinson wrote: > --- > dlls/msxml3/tests/domdoc.c | 4 ++-- > dlls/oleaut32/variant.c | 17 +++++++++-------- > 2 files changed, 11 insertions(+), 10 deletions(-) > If oleaut32 needs a fix like this, please add a test for it in oleaut32/tests, fixed msxml tests will be a side effect. > */ > BOOL bOverflow = FALSE, bNegative; > ULONG64 ul64 = 0; You don't need this initialization now. > + char tmp[1024], *end; Does this buffer size really make sense if you're getting ULONG64 from this string? > int i; > > /* Convert the integer part of the number into a UI8 */ > - for (i = 0; i< wholeNumberDigits; i++) > + for (i = 0; i< wholeNumberDigits; ++i) > + tmp[i] = rgbDig[i] + '0'; > + tmp[wholeNumberDigits] = 0; > + > + ul64 = strtoull(tmp,&end, 10); > + if (end !=&tmp[wholeNumberDigits]) > { > - if (ul64> (UI8_MAX / 10 - rgbDig[i])) > - { > - TRACE("Overflow multiplying digits\n"); > - bOverflow = TRUE; > - break; > - } > - ul64 = ul64 * 10 + rgbDig[i]; > + TRACE("Overflow reading digits\n"); > + bOverflow = TRUE; > } >

1 0

Re: comctl32/listview: Use a code set by dispinfo holder to convert data encoding after LVN_GETDISPINFO
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7103 Your paranoid android. === W7PRO (32 bit listview) === listview.c:4458: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4463: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === W7PROX64 (32 bit listview) === listview.c:4458: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4463: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Re: [PATCH 5/5] shell32/tests: Added SHPropStg* tests (try2)
by Alexandre Julliard 16 Nov '10

16 Nov '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/shell32/tests/Makefile.in | 1 + > dlls/shell32/tests/misc.c | 437 > ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 438 insertions(+), 0 deletions(-) > create mode 100644 dlls/shell32/tests/misc.c It would be better to either put those in an existing file, or create a shellole.c file. misc.c is not a very informative name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ole32: Avoid console flood with an ERR message
by Alexandre Julliard 16 Nov '10

16 Nov '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -3657,7 +3657,14 @@ HRESULT WINAPI CoWaitForMultipleHandles(DWORD dwFlags, DWORD dwTimeout, > } > else > { > - ERR("Unexpected wait termination: %d, %d\n", res, GetLastError()); > + static DWORD old_res; > + static DWORD old_lasterror; > + if ((res != old_res) || (GetLastError() != old_lasterror)) > + { > + old_res = res; > + old_lasterror = GetLastError(); > + ERR("Unexpected wait termination: %d, %d\n", res, GetLastError()); > + } That's just hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] gdi32: Implement CreateScalableFontResource, based on a patch by Jeremy White.
by Alexandre Julliard 16 Nov '10

16 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + /* empty type info */ > + memset(&rc_type, 0, sizeof(rc_type)); > + if (!WriteFile(hfile, &rc_type, sizeof(rc_type), &dummy, NULL)) return FALSE; > + > + if (!WriteFile(hfile, "\7FONTDIR", 8, &dummy, NULL)) return FALSE; > + str_len = strlen(resident_name); > + if (!WriteFile(hfile, &str_len, 1, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, resident_name, str_len, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, filler, 5, &dummy, NULL)) return FALSE; > + > + str_len = strlen(non_resident_name); > + if (!WriteFile(hfile, &str_len, 1, &dummy, NULL)) return FALSE; > + if (!WriteFile(hfile, non_resident_name, str_len, &dummy, NULL)) return FALSE; > + /* terminator */ > + if (!WriteFile(hfile, filler, 1, &dummy, NULL)) return FALSE; > + > + /* empty ne_modtab and ne_imptab */ > + if (!WriteFile(hfile, filler, 2, &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; > + > + if (!WriteFile(hfile, fd, fd->dfSize, &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; > + > + if (!WriteFile(hfile, ttf_file_nameA, strlen(ttf_file_nameA), &dummy, NULL)) return FALSE; > + > + if (!write_pad(hfile)) return FALSE; That's ugly and inefficient. The data should be built into a memory buffer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. (resend)
by Alexandre Julliard 16 Nov '10

16 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -365,7 +365,7 @@ static struct list system_links = LIST_INIT(system_links); > > static struct list font_subst_list = LIST_INIT(font_subst_list); > > -static struct list font_list = LIST_INIT(font_list); > +static struct list global_font_list = LIST_INIT(global_font_list); I don't see any reason to rename the variable, that makes the patch much larger than necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add new debuglevel 2 for showing broken behaviours as failed
by Alexandre Julliard 16 Nov '10

16 Nov '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -285,7 +285,7 @@ void winetest_set_location( const char* file, int line ) > > int broken( int condition ) > { > - return (strcmp(winetest_platform, "windows") == 0) && condition; > + return (strcmp(winetest_platform, "windows") == 0) && condition && winetest_debug < 2; > } You can already change the platform, there's no need for a new mechanism. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Set alpha channel to 0 for pixels with color key
by Henri Verbeet 16 Nov '10

16 Nov '10

On 16 November 2010 12:46, Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > Hello, > > This is patch for bug: > http://bugs.winehq.org/show_bug.cgi?id=23750 > > Current DirectDraw implementation doesn't process color key correctly. > I have add manually pixels color checking on surface loading because don't > able to find GL function to do this. > This patch is wrong. Color key processing happens mostly in d3dfmt_convert_surface(), you should try to figure out why it isn't happening for this application. Some more general points are that perform_color_key() would need to be static, casting void pointer is redundant, the color key is a range, not a single value, and try to use consistent formatting.

2 1

Re: [PATCH 5/5] shell32/tests: Added SHPropStg* tests
by Marvin 16 Nov '10

16 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7088 Your paranoid android. === WVISTAADM (32 bit misc) === misc: unhandled exception c0000005 at 767CA659 === W2K8SE (32 bit misc) === misc: unhandled exception c0000005 at 75A29E4D === W7PRO (32 bit misc) === misc: unhandled exception c0000005 at 76C59DAE === W7PROX64 (32 bit misc) === misc: unhandled exception c0000005 at 74D79DAE === W7PROX64 (64 bit misc) === Timeout

1 0

Developing on 64 bit Ubuntu? Add the Wine PPA for new ia32-libs that supports gstreamer codecs
by Scott Ritchie 16 Nov '10

16 Nov '10

The ia32-libs that ships with Ubuntu doesn't contain 32 bit libraries for all the useful codecs of gstreamer. There's enough to build Wine, but not enough to actually show a video. I've fixed this in the ia32-libs on the Wine PPA by adding _73_ new libraries to it. This is something you'll want even if you're not using the wine packages and just doing Wine development. Thankfully, ia32-libs should be finally obsolete by 11.04 with multiarch, but in the meantime we can use the PPA. I'll work on porting the ia32-libs changes to 10.04 and 9.10, but it's less of a priority. On those we have other problems (such as old GCC versions causing problems). Thanks, Scott Ritchie

1 0

Re: [PATCH] console: fix output for console handles opened with GENERIC_WRITE access
by Martin Wilck 15 Nov '10

15 Nov '10

Hi Eric, hi everyone, as you may already know, my patch is obsoleted by your commit 91e3a40e412a6c04cfaf8f6d0d3d16a1a4c4bfdb. Thanks! Martin -- Dr. Martin Wilck <Martin.Wilck(a)particle-dynamics.de> Physicist and Software Engineer particle dynamics GmbH, Leipzig Geschäftsführer (Director): Markus Fait Handelsregister (Trade Register): HRB 19578 AG Leipzig Richterstr. 1, 04105 Leipzig, Germany Tel. ++49-341-9849387 Fax. ++49-341-9849377 http://www.particle-dynamics.de

1 0

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::swap implementation. (try 2)
by Piotr Caban 15 Nov '10

15 Nov '10

On 11/15/10 18:26, Vincas Miliūnas wrote: > The way I see this is that the code above handles the case when lhs string is in the local buffer and rhs is allocated. The exchange requires copying (lhs->data->buf into rhs->data->buf and rhs->data->ptr into lhs->data->ptr), since setting one's ptr to other's buf would be illegal. Also, the ptr and buf are in an union construct and overlap, therefore only one can be stored at a time. You can copy whole union without knowing what field is used. This way you can implement it with only one else statement. + if (this == str) + { Please try to follow coding style used in modified file (no space after if, new block bracket in the same line).

1 0

how to use wcslen() in wine?
by 飞翔 15 Nov '10

15 Nov '10

hello, I'm developing under Wine environment. I'm using Unicode and I want to be able to use standard library call wcslen, but I don't know how to change my C library from the native glibc C library to the msvcrt C library. As it is described in "Winelib_User's_Guide":"In these cases you should use msvcrt to provide your C runtime calls. import msvcrt.dll to your applications .spec file." I'm using wineg++ to compile the .cpp & .h files, there is no .spec file, how can I import the DLL? May you please help me? Thanks very much! ------------------ Where there is a will, there is a way! ------------------ 丁耿佳 Gavin-Ding Computer Science and Technology， South China University of Technology Email: gj.ding(a)mail.scut.edu.cn gengjia.ding(a)gmail.com gengjia.ding(a)qq.com Mailing Address: 339, Building C12, SCUT, Guangzhou Higher Education Mega Center, Guangzhou, China Postcode:510006

2 1

Kernel APC in Wine?
by Joerg-Cyril.Hoehle＠t-systems.com 15 Nov '10

15 Nov '10

Hi, my WINMM callback tests (cf. bug #3930, comments 37+38) showed that most MOM_ callbacks were executed in my own thread! The only way I know how to achieve this is to use an APC as in QueueUserAPC(). However, reading MSDN again, it seems like user-mode APC are never invoked unless the app uses the Wait*Ex() functions instead of the regular ones likes WaitForMultipleObjects() or Sleep(). As I can't expect a random app to use these, I assume that either - something confused me and I'm on the wrong track, or - native's winmm uses kernel APC, not user ones, and kernel APC are invoked even with plain Wait* calls, or - user APC are executed with plain Sleep/Wait*() (non ~Ex) too. Does Wine have something like kernel APC? What other mechanism exist that could allow a player loop inside WINMM to invoke callbacks in the application's thread context? BTW, I find it's a good idea from MS to execute callbacks in the caller's thread. This avoids common pitfalls and nasty bugs. Is there potential trouble with APC in Wine on 64 bit? MSDN recommends against posting an APC to a thread in another process. Thank you for your help, Jörg Höhle

1 0

Re: winecoreaudio: OSStatus is not necessarily a FOURCC.
by Michael Stefaniuc 15 Nov '10

15 Nov '10

Hi! Joerg-Cyril.Hoehle(a)t-systems.com wrote: > This fixes the string from midi.ok mentioned in bug #21589 > err:wave:AudioUnit_GetVolume > AudioUnitGetParameter return an error "\xff\xff\xd5\x8e" > Now it will print a signed integer instead: > -10866 aka. kAudioUnitErr_InvalidScope > > As to whether that function should stay "inline", I don't know. Doesn't really matter as "inline" is just a hint to the compiler and the compiler is free to ignore it. bye michael

1 0

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::swap implementation.
by Piotr Caban 15 Nov '10

15 Nov '10

On 11/11/10 18:55, Vincas Miliūnas wrote: > This implementation handles cases when basic_strings are allocated using different allocators, however WINE's implementation seems to ignore allocators. It's not ignoring allocators (but it's not setting allocator field). There's no legal way of accessing it by end user, so there's no point of setting it, unless it's needed internally (and it's not needed for correct implementation of basic_string_char_swap function). +/* Helper function for MSVCP_basic_string_char_swap */ +void basic_string_char_swap_bufxptr_same_alloc(basic_string_char * lhs, basic_string_char * rhs) +{ + char * const ptr = rhs->data.ptr; + const size_t size = rhs->size; + const size_t res = rhs->res; + + memcpy(rhs->data.buf, lhs->data.buf, lhs->size * sizeof(char)); This function should work in constant time. It should only swap pointers and lengths. +/* Helper function for MSVCP_basic_string_char_swap */ +MSVCP_BOOL basic_string_char_swap_bufxptr_diff_alloc(basic_string_char * lhs, basic_string_char * rhs) +{ + char tmp[BUF_SIZE_CHAR]; + const size_t size = lhs->size; + const size_t res = lhs->res; + memcpy(tmp, lhs->data.buf, lhs->size * sizeof(char)); + + char * const ptr = MSVCP_allocator_char_allocate(lhs->allocator, rhs->res); You can't pass unknown data to MSVCP_allocator_char_allocate, this is the implementation of default char allocator. When other allocators are in use compiler will use templates. The function you're implementing is only used when two basic_string_char are swapped, because there's no legal way of modifying allocator field there's only one case - the same allocators are used. Cheers, Piotr

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6
by James McKenzie 14 Nov '10

14 Nov '10

On 11/5/10 8:17 AM, Charles Davis wrote: > Changes since try 5: > o All case-sensitivity logic has been absorbed into find_file_in_dir(). > o Eliminated one more stat(2) that I missed last time. > o Eliminated a statfs(2) call on Linux. > > This is a far as I think I can take it without gutting it completely. If > any of you have better ideas, I'd like to hear them. > --- > dlls/ntdll/directory.c | 233 +++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 229 insertions(+), 4 deletions(-) > > diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c > index 865c2fa..2891792 100644 > --- a/dlls/ntdll/directory.c > +++ b/dlls/ntdll/directory.c > @@ -41,6 +41,9 @@ > #ifdef HAVE_SYS_STAT_H > # include<sys/stat.h> > #endif > +#ifdef HAVE_SYS_ATTR_H > +#include<sys/attr.h> > +#endif > #ifdef HAVE_SYS_IOCTL_H > #include<sys/ioctl.h> > #endif > @@ -56,6 +59,9 @@ > #ifdef HAVE_SYS_MOUNT_H > #include<sys/mount.h> > #endif > +#ifdef HAVE_SYS_STATFS_H > +#include<sys/statfs.h> > +#endif > #include<time.h> > #ifdef HAVE_UNISTD_H > # include<unistd.h> > @@ -130,6 +136,35 @@ static inline int getdents64( int fd, char *de, unsigned int size ) > > #endif /* linux */ > > +#if defined(HAVE_GETATTRLIST) > + > +struct get_fsid > +{ > + ULONG size; > + dev_t dev; > + fsid_t fsid; > +}; > + > +struct fs_cache > +{ > + dev_t dev; > + fsid_t fsid; > + BOOLEAN case_sensitive; > +} fs_cache[64]; > + > +#if defined(ATTR_VOL_CAPABILITIES)&& defined(VOL_CAPABILITIES_FORMAT)&& \ > + defined(VOL_CAP_FMT_CASE_SENSITIVE) > + > +struct vol_caps > +{ > + ULONG size; > + vol_capabilities_attr_t caps; > +}; > + > +#endif /* ATTR_VOL_CAPABILITIES */ > + > +#endif /* HAVE_GETATTRLIST */ > + > #define IS_OPTION_TRUE(ch) ((ch) == 'y' || (ch) == 'Y' || (ch) == 't' || (ch) == 'T' || (ch) == '1') > #define IS_SEPARATOR(ch) ((ch) == '\\' || (ch) == '/') > > @@ -783,6 +818,192 @@ static char *get_device_mount_point( dev_t dev ) > } > > > + > +#ifdef HAVE_GETATTRLIST > +/*********************************************************************** > + * look_up_fs_cache > + * > + * Checks if the specified file system is in the cache. > + */ > +static struct fs_cache *look_up_fs_cache( dev_t dev ) > +{ > + int i; > + for (i = 0; i< sizeof(fs_cache)/sizeof(fs_cache[0]); i++) > + if (fs_cache[i].dev == dev) > + return fs_cache+i; > + return NULL; > +} > + > +/*********************************************************************** > + * add_fs_cache > + * > + * Adds the specified file system to the cache. > + */ > +static void add_fs_cache( dev_t dev, fsid_t fsid, BOOLEAN case_sensitive ) > +{ > + int i; > + struct fs_cache *entry = look_up_fs_cache( dev ); > + static int once = 0; > + if (entry) > + { > + /* Update the cache */ > + entry->fsid = fsid; > + entry->case_sensitive = case_sensitive; > + return; > + } > + > + /* Add a new entry */ > + for (i = 0; i< sizeof(fs_cache)/sizeof(fs_cache[0]); i++) > + if (fs_cache[i].dev == 0) > + { > + /* This entry is empty, use it */ > + fs_cache[i].dev = dev; > + fs_cache[i].fsid = fsid; > + fs_cache[i].case_sensitive = case_sensitive; > + return; > + } > + > + /* Cache is out of space, warn */ > + if (once++) > + WARN( "FS cache is out of space, expect performance problems\n" ); > +} > +#endif > + > +/*********************************************************************** > + * get_dir_case_sensitivity > + * > + * Checks if the volume containing the specified directory is case > + * sensitive or not. > + */ > +static BOOLEAN get_dir_case_sensitivity( const char *dir ) > +{ > +#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > + struct statfs stfs; > +#elif defined(__NetBSD__) > + struct statvfs stfs; > +#elif defined(__linux__) > + struct stat st; > + char *cifile; > +#endif > + > +#if defined(HAVE_GETATTRLIST)&& defined(ATTR_VOL_CAPABILITIES)&& \ > + defined(VOL_CAPABILITIES_FORMAT)&& defined(VOL_CAP_FMT_CASE_SENSITIVE) > + char *mntpoint = NULL; > + struct attrlist attr; > + struct vol_caps caps; > + struct get_fsid get_fsid; > + struct fs_cache *entry; > + > + /* First get the FS ID of the volume */ > + attr.bitmapcount = ATTR_BIT_MAP_COUNT; > + attr.reserved = 0; > + attr.commonattr = ATTR_CMN_DEVID|ATTR_CMN_FSID; > + attr.volattr = attr.dirattr = attr.fileattr = attr.forkattr = 0; > + get_fsid.size = 0; > + if (getattrlist( dir,&attr,&get_fsid, sizeof(get_fsid), 0 ) != 0 || > + get_fsid.size != sizeof(get_fsid)) > + return TRUE; > + /* Try to look it up in the cache */ > + entry = look_up_fs_cache( get_fsid.dev ); > + if (entry&& !memcmp(&entry->fsid,&get_fsid.fsid, sizeof(fsid_t) )) > + /* Cache lookup succeeded */ > + return entry->case_sensitive; > + /* Cache is stale at this point, we have to update it */ > + > + mntpoint = get_device_mount_point( get_fsid.dev ); > + /* Now look up the case-sensitivity */ > + attr.commonattr = 0; > + attr.volattr = ATTR_VOL_INFO|ATTR_VOL_CAPABILITIES; > + if (getattrlist( mntpoint,&attr,&caps, sizeof(caps), 0 ) == 0) > + { > + if (caps.size == sizeof(caps)&& > + (caps.caps.valid[VOL_CAPABILITIES_FORMAT]& > + (VOL_CAP_FMT_CASE_SENSITIVE | VOL_CAP_FMT_CASE_PRESERVING)) == > + (VOL_CAP_FMT_CASE_SENSITIVE | VOL_CAP_FMT_CASE_PRESERVING)) > + { > + BOOLEAN ret; > + > + RtlFreeHeap( GetProcessHeap(), 0, mntpoint ); > + if ((caps.caps.capabilities[VOL_CAPABILITIES_FORMAT]& > + VOL_CAP_FMT_CASE_SENSITIVE) != VOL_CAP_FMT_CASE_SENSITIVE) > + ret = FALSE; > + ret = TRUE; > + /* Update the cache */ > + add_fs_cache( get_fsid.dev, get_fsid.fsid, ret ); > + return ret; > + } > + } > + RtlFreeHeap( GetProcessHeap(), 0, mntpoint ); > + /* Fall through */ > +#endif > +#if defined(__APPLE__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) > + statfs( dir,&stfs ); > + /* Assume these file systems are always case insensitive on Mac OS. Don't do this. Quake2 and quake2 turn out to be different (and I tried to move to a directory called Quake2 using cd $HOME/wine.../drive_c/quake2 and received an error this morning [Yes, I'm playing Quake2 on my Mac, I really, really need the stress relief, it is really hard to explain.}) > + * For FreeBSD, only assume CIOPFS is case insensitive (AFAIK, Mac OS > + * is the only UNIX that supports case-insensitive lookup). > + */

2 1

Haiku talking about wine
by Dan Kegel 14 Nov '10

14 Nov '10

Seems to have been a long thread recently about restarting a port of Wine to Haiku, see http://haikuware.com/bounty-discussion/1533-wine-bounty I don't think there was anything really happening, though.

1 0

Re: [PATCH] d3dcompiler: Add initial reflection parsing.
by Henri Verbeet 14 Nov '10

14 Nov '10

2010/11/14 Rico Schüller <kgbricola(a)web.de>: > +HRESULT d3dcompiler_shader_reflection_init(const void *data, SIZE_T data_size, void **reflector) Allocation and initialization are different things. Either way, it's unnecessary to make "reflector" void **. > + if (!IsEqualGUID(riid, &IID_ID3D11ShaderReflection)) > { > - ERR("Failed to allocate D3D compiler shader reflection object memory\n"); > - return E_OUTOFMEMORY; > + WARN("Wrong riid %s, accept only %s!\n", debugstr_guid(riid), debugstr_guid(&IID_ID3D11ShaderReflection)); > + return E_FAIL; > } I'm not sure if you have tests for this returning E_FAIL, but typically you'd expect E_NOINTERFACE for something like that.

1 0

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite
by Henri Verbeet 14 Nov '10

14 Nov '10

On 12 November 2010 21:08, Travis Athougies <iammisc(a)gmail.com> wrote: > + static struct hlsl_probe_info sin_probes[] = This should be const. As a general rule, try to pay attention to at least other patches to the same module. I fixed a couple of these about two weeks ago. Same goes for calculating the probe count. > + { > + {0, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {1, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {2, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {3, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {4, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {5, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {6, 0, {0.9620f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {7, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {8, 0, {1.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {9, 0, {0.9904f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {10, 0, {0.9619f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {11, 0, {0.9157f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {12, 0, {0.8536f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {13, 0, {0.7778f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {14, 0, {0.6913f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {15, 0, {0.5975f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {16, 0, {0.5000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {17, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {18, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {19, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {20, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {21, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {22, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {23, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {24, 0, {0.0000f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {25, 0, {0.0096f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {26, 0, {0.0381f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {27, 0, {0.0843f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {28, 0, {0.1464f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {29, 0, {0.2222f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {30, 0, {0.3087f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + {31, 0, {0.4025f, 0.0f, 0.0f, 0.0f}, 0.001f, "sin test failed"}, > + }; > + 32 probes is probably a bit excessive, but I guess it's not a major problem. Note that you can easily return the cosine results in the .y component though, instead of duplicating the complete test.

1 0

Re: wined3d: remove a useless variable
by Nikolay Sivov 14 Nov '10

14 Nov '10

On 11/14/2010 22:17, David Adam wrote: > if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) { > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > return; > } Why is it useless?

2 3

Re: wined3d: remove a useless variable
by André Hentschel 14 Nov '10

14 Nov '10

> > - static BOOL warned = FALSE; > - if(!warned) { > - ERR("The application tries to lock the render target, but render target locking is disabled\n"); > - warned = TRUE; > - } > + ERR("The application tries to lock the render target, but render target locking is disabled\n"); > Why is that useless? It supresses console flooding. -- Best Regards, André Hentschel

1 0

Re: [msi/tests] Cleanup properly on Win9x
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7053 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [PATCH 10/10] mshtml: Added document fragment cloneNode implementation.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7048 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 07/10] mshtml: Correctly handle DOCUMENT_FRAGMENT_NODE in IHTMLDOMNode::get_nodeType.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7045 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [5/5] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7042 Your paranoid android. === W98SE (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: [4/4] gdi32: Add a buch of CreateScalableFontResource() tests.
by Marvin 14 Nov '10

14 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7041 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Compilation error with latest wine
by Luca Bennati 14 Nov '10

14 Nov '10

I get this: registrar.c: In function ‘DllGetClassObject’: registrar.c:747:18: error: ‘CLSID_Registrar’ undeclared (first use in this function) registrar.c:747:18: note: each undeclared identifier is reported only once for each function it appears in registrar.c: In function ‘do_register_server’: registrar.c:796:22: error: ‘CLSID_Registrar’ undeclared (first use in this function) make[1]: *** [registrar.o] Error 1 make[1]: Leaving directory `/home/luca/wine-git/dlls/atl' make: *** [dlls/atl] Error 2 make: *** Waiting for unfinished jobs.... I'm compiling with "CFLAGS=' -g -O0 -pipe' CXXFLAGS=' -g -O0 -pipe' ./configure --prefix=/usr --sysconfdir=/etc --with-x --without-capi --without-gsm --without-icns" after a make distclean What's wrong here?

6 8

Re: widl: Fix for typelib generation when unaligned access to memory is not allowed
by Marcus Meissner 13 Nov '10

13 Nov '10

On Sat, Nov 13, 2010 at 07:02:02PM +0100, André Hentschel wrote: > caused a "Bus error" on sparc > --- > tools/widl/write_msft.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index da4eb25..5175b73 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -1208,7 +1208,11 @@ static void write_value(msft_typelib_t* typelib, int *out, int vt, const void *v > int len = strlen(s), seg_len = (len + 6 + 3) & ~0x3; > int offset = ctl2_alloc_segment(typelib, MSFT_SEG_CUSTDATA, seg_len, 0); > *((unsigned short *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset]) = vt; > - *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#ifdef ALLOW_UNALIGNED_ACCESS > + *((unsigned int *)&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2]) = len; > +#else > + memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+2], &len, sizeof(len)); > +#endif > memcpy(&typelib->typelib_segment_data[MSFT_SEG_CUSTDATA][offset+6], value, len); Just do the memcpy unconditional. Ciao, Marcus

1 0

Re: [PATCH 3/4] shell32: Some events are sent twice in SHChangeNotify
by Marvin 13 Nov '10

13 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7032 Your paranoid android. === W98SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called === WNT4WSSP6 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2KPROSP4 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === WVISTAADM (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W2K8SE (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PRO (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (32 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called === W7PROX64 (64 bit shlfolder) === shlfolder.c:4339: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEITEM: Expected wndproc to be called shlfolder.c:4339: Test failed: RENAMEFOLDER: Expected wndproc to be called shlfolder.c:4350: Test failed: RENAMEFOLDER: Expected wndproc to be called

2 1

Re: [try 2] Test for window messages of a property sheet with custom dialog proc (bug 12104)
by Paul Vriens 13 Nov '10

13 Nov '10

On 11/06/2010 11:16 AM, Bernhard Übelacker wrote: > Hello, > this patch checks for correct arrival of messages to a subclassed property page. > > For this bug http://bugs.winehq.org/show_bug.cgi?id=12104 specifically > the first WM_SIZE message is interesting which is not sent in wine. > > I have changed the patch based on the feedback I got on my first mail. > (http://www.winehq.org/pipermail/wine-devel/2010-October/087474.html) > > Now I am using the msg.h facilities for checking the messages. > > Kind regards, > Bernhard > Hi, Ever since this patch the shell32:shlexec tests fail on NT4 and W2K: http://test.winehq.org/data/tests/shell32:shlexec.html I can reproduce easily by running (on a clean Windows box): winetest-latest.exe comctl32:propsheet shell32:shlexec This will throw some error dialog boxes and I'm also unable to double-click items in the "Windows Explorer". Thoughts/Ideas/Suggestions? -- Cheers, Paul.

2 2

Re: regedit: add a manpage
by Alexandre Julliard 13 Nov '10

13 Nov '10

Austin English <austinenglish(a)gmail.com> writes: > While looking at the Debian Wine sources, I found they have manpages > for several of our bulitin programs :-) Then you should ask them to submit patches. You can't just grab the manpages and submit under your name. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: loader: On Mac, reserve the process's original thread for the frameworks. (try 2)
by Alexandre Julliard 13 Nov '10

13 Nov '10

Ken Thomases <ken(a)codeweavers.com> writes: > + { > + CFRunLoopAddSource( CFRunLoopGetMain(), source, kCFRunLoopCommonModes ); > + CFRunLoopSourceSignal( source ); > + CFRunLoopWakeUp( CFRunLoopGetMain() ); > + CFRelease( source ); > + > + /* This is a hack. We want to wait until the main thread has > + * really exited in response to our signal. However, Mac OS X > + * doesn't let us join the main thread for whatever reason. > + * It results in a SIGBUS. So, we just sleep for a bit and hope > + * it got enough time. */ > + usleep(100); We need something more reliable than this. (The pthread_join crash is a bug in libsystem, I filed a bug a while back but haven't heard anything). -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] ntdll/tests: Added qsort_s tests. (try 5)
by Marvin 13 Nov '10

13 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7037 Your paranoid android. === WVISTAADM (32 bit string) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Help with 'WineAPI' wiki
by Max TenEyck Woodbury 12 Nov '10

12 Nov '10

As I mentioned before, I am trying to establish a place where the Windows API can be discussed that is not under the control of Microsoft. While the name I have chosen is debatable, it is not beyond reason and conveys enough about its intended contents that it should not be too hard to find. It currently consists of two major pieces: * The Wine piece follows the distribution directory structure with pages for each directory and many of the files. * The API piece currently consists of an index of all the APIs I found in the .spec files. * Other projects that use the windows API can put the information specific to their project in directory trees similar to the one I have set up for Wine. I am having a few specific problems: * Some of the .spec files contain more information than can be displayed on a single Wiki page. This information has to be split up into a reasonable number of sub-pages and organized so the information needed can be found fairly easily. I can handle the technical aspects of setting up the pages, and have some idea of where the splits should be, but I am uncertain enough that I want advice. * This is the first Wiki I have had administrative responsibility for and I frankly do not know what I am doing. Advice and help with the administration of the Wiki and the project would help. * Some of the technical choices have been based on my technical limits. I am simply ignorant of possible alternatives. Again, I think advice would help. * I know some of the sections are just plain ugly. I am mostly concerned with getting accurate and current information into the Wiki at this point, but the presentation does need improvement and again, I think some advice would be helpful. * My dyslexia has bitten me more than once. Someone to review what I am doing might help. - Max

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 6
by Charles Davis 12 Nov '10

12 Nov '10

What's wrong now? Chip

1 1

re: d3d9: Improve CheckDeviceState stub to run Firefox 4 Beta 7
by Dan Kegel 12 Nov '10

12 Nov '10

I think that's a clue that you need a better name than 'i'. Maybe 'fixme_shown'.

1 0

Re: [2/11] update Simplified Chinese translation: notepad
by Paul Vriens 12 Nov '10

12 Nov '10

On 11/12/2010 02:26 PM, cheer_xiao wrote: > Here is my update for the Simplified Chinese translation. I have "make"d > all corresponding files to ensure that they don't get broken. Copyright > info has been included (if not present). > > > > Hi, Most of your emails don't contain the actual patches. -- Cheers, Paul.

1 0

Re: [PATCH 1/4] shdocvw: Implement DocHostUIHandler::TranslateAccelerator.
by Jacek Caban 12 Nov '10

12 Nov '10

Hi David, On 11/12/10 8:49 AM, David Hedberg wrote: > --- > dlls/shdocvw/dochost.c | 9 +- > dlls/shdocvw/tests/webbrowser.c | 251 ++++++++++++++++++++++++++++++++++++++- > 2 files changed, 253 insertions(+), 7 deletions(-) > > diff --git a/dlls/shdocvw/tests/webbrowser.c b/dlls/shdocvw/tests/webbrowser.c > index babfe11..fd1c7f8 100644 > --- a/dlls/shdocvw/tests/webbrowser.c > +++ b/dlls/shdocvw/tests/webbrowser.c > @@ -122,8 +122,12 @@ DEFINE_EXPECT(QueryStatus_SETPROGRESSTEXT); > DEFINE_EXPECT(QueryStatus_STOP); > DEFINE_EXPECT(DocHost_EnableModeless_TRUE); > DEFINE_EXPECT(DocHost_EnableModeless_FALSE); > +DEFINE_EXPECT(DocHost_TranslateAccelerator); > DEFINE_EXPECT(GetDropTarget); > DEFINE_EXPECT(TranslateUrl); > +DEFINE_EXPECT(ShowUI); > +DEFINE_EXPECT(HideUI); > +DEFINE_EXPECT(RequestUIActivate); > > static const WCHAR wszItem[] = {'i','t','e','m',0}; > static const WCHAR emptyW[] = {0}; > @@ -133,6 +137,7 @@ static IWebBrowser2 *wb; > > static HWND container_hwnd, shell_embedding_hwnd; > static BOOL is_downloading, is_first_load; > +static HRESULT hr_dochost_TranslateAccelerator = E_NOTIMPL; > static const char *current_url; > > #define DWL_EXPECT_BEFORE_NAVIGATE 0x01 > @@ -249,6 +254,10 @@ static HRESULT WINAPI OleCommandTarget_Exec(IOleCommandTarget *iface, const GUID > { > if(!pguidCmdGroup) { > switch(nCmdID) { > + case OLECMDID_UPDATECOMMANDS: > + ok(nCmdexecopt == 2, "nCmdexecopts=%08x\n", nCmdexecopt); > + ok(pvaIn == NULL, "Got non-null pvaIn\n"); > + break; This should also use CHECK_EXPECT() > case OLECMDID_SETPROGRESSMAX: > CHECK_EXPECT2(Exec_SETPROGRESSMAX); > ok(nCmdexecopt == OLECMDEXECOPT_DONTPROMPTUSER, "nCmdexecopts=%08x\n", nCmdexecopt); > @@ -1128,7 +1137,7 @@ static HRESULT WINAPI InPlaceSite_OnInPlaceDeactivateEx(IOleInPlaceSiteEx *iface > > static HRESULT WINAPI InPlaceSite_RequestUIActivate(IOleInPlaceSiteEx *iface) > { > - ok(0, "unexpected call\n"); > + CHECK_EXPECT2(RequestUIActivate); > return S_OK; > } > > @@ -1195,13 +1204,13 @@ static HRESULT WINAPI DocHostUIHandler_ShowUI(IDocHostUIHandler2 *iface, DWORD d > IOleInPlaceActiveObject *pActiveObject, IOleCommandTarget *pCommandTarget, > IOleInPlaceFrame *pFrame, IOleInPlaceUIWindow *pDoc) > { > - ok(0, "unexpected call\n"); > + CHECK_EXPECT(ShowUI); > return E_NOTIMPL; > } > > static HRESULT WINAPI DocHostUIHandler_HideUI(IDocHostUIHandler2 *iface) > { > - ok(0, "unexpected call\n"); > + CHECK_EXPECT(HideUI); > return E_NOTIMPL; > } > > @@ -1243,8 +1252,12 @@ static HRESULT WINAPI DocHostUIHandler_ResizeBorder(IDocHostUIHandler2 *iface, L > static HRESULT WINAPI DocHostUIHandler_TranslateAccelerator(IDocHostUIHandler2 *iface, LPMSG lpMsg, > const GUID *pguidCmdGroup, DWORD nCmdID) > { > - ok(0, "unexpected call\n"); > - return E_NOTIMPL; > + CHECK_EXPECT(DocHost_TranslateAccelerator); > + ok(pguidCmdGroup != NULL, "Got NULL pguidCmdGroup.\n"); > + if(pguidCmdGroup) > + ok(IsEqualGUID(pguidCmdGroup,&CGID_MSHTML), "Unexpected pguidCmdGroup\n"); > + ok(lpMsg != NULL, "Got NULL lpMsg.\n"); > + return hr_dochost_TranslateAccelerator; > } > > static HRESULT WINAPI DocHostUIHandler_GetOptionKeyPath(IDocHostUIHandler2 *iface, > @@ -2483,6 +2496,233 @@ static void test_QueryInterface(IUnknown *unk) > > } > > +static void translate_messages(void) > +{ > + MSG msg; > + UINT i; > + for(i = 0; i< 100; i++) { > + while(PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) { > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > + Sleep(5); > + } > +} > +static void test_TranslateAccelerator(IUnknown *unk) > +{ > + IWebBrowser2 *pwb2; > + IOleObject *pobj; > + HRESULT hr; > + DWORD keycode; > + IDispatch *disp_html; > + VARIANT url; > + MSG msg_a = { > + container_hwnd, > + 0, 0, 0, > + GetTickCount(), > + {5, 5} > + }; > + > + is_downloading = TRUE; > + > + hr = IUnknown_QueryInterface(unk,&IID_IWebBrowser2, (void**)&pwb2); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(FAILED(hr)) { > + skip("Failed to get IWebBrowser2\n"); /* This should never happen */ > + return; > + } > + > + disp_html = (void*)0xdeadbeef; > + hr = IWebBrowser2_get_Document(pwb2,&disp_html); > + todo_wine ok(hr == S_FALSE || broken(hr == S_OK) /*< IE7 */, "Got 0x%08x\n", hr); > + ok(disp_html == NULL, "Received doc.\n"); > + if(disp_html != NULL) > + IDispatch_Release(disp_html); > + > + /* Activate */ > + SET_EXPECT(GetContainer); > + SET_EXPECT(Site_GetWindow); > + SET_EXPECT(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); > + SET_EXPECT(Invoke_AMBIENT_SILENT); > + > + hr = IUnknown_QueryInterface(unk,&IID_IOleObject, (void**)&pobj); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) { > + hr = IOleObject_SetClientSite(pobj,&ClientSite); > + ok(hr == S_OK, "SetClientSite failed: %08x\n", hr); > + > + IOleObject_Release(pobj); > + } > + > + CHECK_CALLED(GetContainer); > + CHECK_CALLED(Site_GetWindow); > + CHECK_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); > + CHECK_CALLED(Invoke_AMBIENT_SILENT); Please use test_ClientSite here. If for some reason you want to avoid its additional tests, simply add a flag argument to it. > + SET_EXPECT(Invoke_AMBIENT_USERMODE); > + SET_EXPECT(Exec_SETDOWNLOADSTATE_1); > + SET_EXPECT(GetHostInfo); > + SET_EXPECT(Invoke_AMBIENT_DLCONTROL); > + SET_EXPECT(Invoke_AMBIENT_USERAGENT); > + SET_EXPECT(Invoke_AMBIENT_PALETTE); > + SET_EXPECT(GetOptionKeyPath); > + SET_EXPECT(GetOverridesKeyPath); > + SET_EXPECT(QueryStatus_SETPROGRESSTEXT); > + SET_EXPECT(Exec_SETPROGRESSMAX); > + SET_EXPECT(Exec_SETPROGRESSPOS); > + SET_EXPECT(Exec_SETDOWNLOADSTATE_0); > + SET_EXPECT(DocHost_EnableModeless_FALSE); > + SET_EXPECT(DocHost_EnableModeless_TRUE); > + > + SET_EXPECT(UpdateUI); /* Wine */ > + > + V_VT(&url) = VT_BSTR; > + V_BSTR(&url) = a2bstr("about:blank"); > + current_url = "about:blank"; > + hr = IWebBrowser2_Navigate2(pwb2,&url, NULL, NULL, NULL, NULL); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + > + translate_messages(); Use test_Navigate2 here. > + > + todo_wine ok(expect_UpdateUI, "UpdateUI called.\n"); > + CLEAR_CALLED(UpdateUI); This is not the right way to deal with it. I have a proper fix for test failures on Windows that should help here. I need to make it work on Wine before sending. I will try to send it today. > + > + CHECK_CALLED(Invoke_AMBIENT_USERMODE); > + todo_wine CHECK_CALLED(Exec_SETDOWNLOADSTATE_1); > + CHECK_CALLED(GetHostInfo); > + CHECK_CALLED(Invoke_AMBIENT_DLCONTROL); > + CHECK_CALLED(Invoke_AMBIENT_USERAGENT); > + CHECK_CALLED(Invoke_AMBIENT_PALETTE); > + CHECK_CALLED(GetOptionKeyPath); > + CHECK_CALLED(GetOverridesKeyPath); > + todo_wine CHECK_CALLED(QueryStatus_SETPROGRESSTEXT); > + todo_wine CHECK_CALLED(Exec_SETPROGRESSMAX); > + todo_wine CHECK_CALLED(Exec_SETDOWNLOADSTATE_0); > + > + /* Set the document */ > + hr = IWebBrowser2_get_Document(pwb2,&disp_html); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + ok(disp_html != NULL, "Got %p\n", disp_html); > + if(SUCCEEDED(hr)) { > + IHTMLDocument2 *doc_html; > + > + hr = IDispatch_QueryInterface(disp_html,&IID_IHTMLDocument2, (void**)&doc_html); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) { > + IOleDocumentView *odc_view; > + > + hr = IHTMLDocument2_QueryInterface(doc_html,&IID_IOleDocumentView, (void**)&odc_view); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) { > + SET_EXPECT(Exec_SETPROGRESSMAX); > + SET_EXPECT(Exec_SETDOWNLOADSTATE_0); > + SET_EXPECT(Exec_SETDOWNLOADSTATE_1); > + SET_EXPECT(RequestUIActivate); > + SET_EXPECT(ShowUI); > + SET_EXPECT(HideUI); > + SET_EXPECT(GetDropTarget); > + SET_EXPECT(UpdateUI); > + SET_EXPECT(QueryStatus_STOP); > + > + hr = IOleDocumentView_UIActivate(odc_view, TRUE); > + todo_wine ok(hr == S_OK, "Got 0x%08x\n", hr); > + > + translate_messages(); > + > + todo_wine CHECK_CALLED(Exec_SETPROGRESSMAX); > + todo_wine CHECK_CALLED(Exec_SETDOWNLOADSTATE_0); > + todo_wine CHECK_CALLED(Exec_SETDOWNLOADSTATE_1); > + todo_wine CHECK_CALLED(RequestUIActivate); > + todo_wine CHECK_CALLED(ShowUI); > + todo_wine CHECK_CALLED(HideUI); > + todo_wine CHECK_CALLED(GetDropTarget); > + CHECK_CALLED(UpdateUI); > + todo_wine CHECK_CALLED(QueryStatus_STOP); > + > + IOleDocumentView_Release(odc_view); > + } > + IHTMLDocument2_Release(doc_html); > + } > + IDispatch_Release(disp_html); > + } > + > + /* Call shdocvw _TranslateAccelerators from the other side */ > + disp_html = (void*)0xdeadbeef; > + hr = IWebBrowser2_get_Document(pwb2,&disp_html); > + ok(hr == S_OK, "Got 0x%08x\n", hr); Use get_document helper function. > + ok(disp_html != NULL, "Got %p\n", disp_html); > + if(SUCCEEDED(hr)) { > + IHTMLDocument2 *doc_html; > + hr = IDispatch_QueryInterface(disp_html,&IID_IHTMLDocument2, (void**)&doc_html); > + ok(hr == S_OK, "Got 0x%08x\n", hr); You don't need it. > + if(SUCCEEDED(hr)) { > + IOleObject *html_obj; > + hr = IHTMLDocument2_QueryInterface(doc_html,&IID_IOleObject, (void**)&html_obj); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) { > + IOleClientSite *the_site; > + > + hr = IOleObject_GetClientSite(html_obj,&the_site); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) { > + IDocHostUIHandler2 *html_dochost; > + IUnknown *punk_test; > + > + hr = IOleClientSite_QueryInterface(the_site,&IID_IOleInPlaceFrame, (void**)&punk_test); > + ok(hr == E_NOINTERFACE, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) IUnknown_Release(punk_test); > + > + hr = IOleClientSite_QueryInterface(the_site,&IID_IDocHostShowUI, (void**)&punk_test); > + todo_wine ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) IUnknown_Release(punk_test); > + > + hr = IOleClientSite_QueryInterface(the_site,&IID_IDocHostUIHandler, (void**)&punk_test); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) IUnknown_Release(punk_test); > + > + hr = IOleClientSite_QueryInterface(the_site,&IID_IDocHostUIHandler2, (void**)&html_dochost); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) { > + > + msg_a.message = WM_KEYDOWN; > + hr_dochost_TranslateAccelerator = 0xdeadbeef; > + for(keycode = 0; keycode<= 0x100; keycode++) { > + msg_a.wParam = keycode; > + SET_EXPECT(DocHost_TranslateAccelerator); > + hr = IDocHostUIHandler_TranslateAccelerator(html_dochost,&msg_a,&CGID_MSHTML, 1234); > + ok(hr == 0xdeadbeef, "Got 0x%08x\n", hr); > + CHECK_CALLED(DocHost_TranslateAccelerator); > + } > + hr_dochost_TranslateAccelerator = E_NOTIMPL; > + > + SET_EXPECT(DocHost_TranslateAccelerator); > + hr = IDocHostUIHandler_TranslateAccelerator(html_dochost,&msg_a,&CGID_MSHTML, 1234); > + ok(hr == E_NOTIMPL, "Got 0x%08x\n", hr); > + CHECK_CALLED(DocHost_TranslateAccelerator); > + > + IDocHostUIHandler2_Release(html_dochost); > + } > + IOleClientSite_Release(the_site); > + } > + IOleObject_Release(html_obj); > + } > + IHTMLDocument2_Release(doc_html); > + } > + IDispatch_Release(disp_html); > + } > + > + hr = IUnknown_QueryInterface(unk,&IID_IOleObject, (void**)&pobj); > + ok(hr == S_OK, "Got 0x%08x\n", hr); > + if(SUCCEEDED(hr)) { > + hr = IOleObject_SetClientSite(pobj, NULL); > + ok(hr == S_OK, "SetClientSite failed: %08x\n", hr); > + IOleObject_Release(pobj); > + } Use test_ClientSite here. Jacek

1 0

Re: [PATCH 1/2] msvcrt: Added qsort_s implementation. (try 4)
by Alexandre Julliard 12 Nov '10

12 Nov '10

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> writes: > +/********************************************************************* > + * Helper function for MSVCRT_qsort_s. > + * > + * Based on http://github.com/git/git/blob/master/compat/qsort.c > + * > + */ We already have a qsort in ntdll, I'd suggest to copy that (and/or merge possible improvements into it). We don't need two implementations from two different sources. > +/********************************************************************* > + * qsort_s (MSVCRT.@) > + * > + * Based on http://github.com/git/git/blob/master/compat/qsort.c > + * > + */ > +void CDECL MSVCRT_qsort_s(void *b, size_t n, size_t s, > + _QSORT_S_COMPARE_FN cmp, void *context) > +{ > + const size_t size = n * s; You probably want to check for overflow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] shdocvw: Implement InPlaceActiveObject::TranslateAccelerator.
by Marvin 12 Nov '10

12 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7011 Your paranoid android. === WVISTAADM (32 bit webbrowser) === webbrowser.c:1308: Test failed: unexpected call UpdateUI webbrowser.c:241: Test failed: unexpected call QueryStatus_STOP === W2K8SE (32 bit webbrowser) === webbrowser.c:1308: Test failed: unexpected call UpdateUI webbrowser.c:241: Test failed: unexpected call QueryStatus_STOP webbrowser.c:1308: Test failed: unexpected call UpdateUI webbrowser.c:241: Test failed: unexpected call QueryStatus_STOP webbrowser.c:301: Test failed: unexpected nsCmdID 28 === W7PRO (32 bit webbrowser) === webbrowser.c:1308: Test failed: unexpected call UpdateUI webbrowser.c:241: Test failed: unexpected call QueryStatus_STOP

1 0

Re: [PATCH] console: fix output for console handles opened with GENERIC_WRITE access
by Eric Pouech 12 Nov '10

12 Nov '10

this has already been discussed on wine-devel a couple of days ago the "right" fix is either to fix WriteConsole so that it doesn't require read access (actually FILE_READ_PROPERTIES), or to grant this access user side so the fix in the server will be rejected A+ 2010/11/12 Martin Wilck <Martin.Wilck(a)particle-dynamics.de> > > Writing to a console handle obtained with a requested access mode > GENERIC_WRITE > produces no output. This happens because get_console_mode() requires > FILE_READ_PROPERTIES access on the handle, which a handle created with > GENERIC_WRITE doesn't have. > > This affects many Microsoft console applications, e.g. nmake and cl from > VC++ > express 2005. > > It can be tested with the following minimal test program (compiled with > VC 2005 & run with native mscvr80): > > int main(void) > { > _cprintf("Hi.\n"); > return 0; > } > > This behaves as follows: > > trace:console:OpenConsoleW (L"CONOUT$", 0x40000000, 0, 3) > 0009: open_console( from=0001, access=40000000, attributes=00000000, > share=3 ) > 0009: open_console() = 0 { handle=0028 } > trace:console:WriteConsoleW 0x2b L"H" 1 0x33fb78 (nil) > 0009: get_console_mode( handle=0028 ) > 0009: get_console_mode() = ACCESS_DENIED { mode=0, is_bare=0 } > > Because of the ACCESS_DENIED, this program produces no output on current > wine. > This patch fixies this with a new map_access() function for the console. > > Signed-off-by: Martin Wilck <martin.wilck(a)particle-dynamics.de> > --- > server/console.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) > > > -- -- Eric Pouech

1 0

Re: [PATCH 3/4] shdocvw: Implement ControlSite::TranslateAccelerator.
by Marvin 12 Nov '10

12 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7010 Your paranoid android. === WVISTAADM (32 bit webbrowser) === webbrowser.c:1301: Test failed: unexpected call UpdateUI webbrowser.c:241: Test failed: unexpected call QueryStatus_STOP === W7PRO (32 bit webbrowser) === webbrowser.c:1301: Test failed: unexpected call UpdateUI webbrowser.c:241: Test failed: unexpected call QueryStatus_STOP

1 0

Re: [PATCH 1/4] shdocvw: Implement DocHostUIHandler::TranslateAccelerator.
by Marvin 12 Nov '10

12 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7009 Your paranoid android. === WVISTAADM (32 bit webbrowser) === webbrowser.c:1219: Test failed: unexpected call UpdateUI webbrowser.c:238: Test failed: unexpected call QueryStatus_STOP === W2K8SE (32 bit webbrowser) === webbrowser.c:1219: Test failed: unexpected call UpdateUI webbrowser.c:238: Test failed: unexpected call QueryStatus_STOP webbrowser.c:1219: Test failed: unexpected call UpdateUI webbrowser.c:238: Test failed: unexpected call QueryStatus_STOP webbrowser.c:298: Test failed: unexpected nsCmdID 28 === W7PRO (32 bit webbrowser) === webbrowser.c:1219: Test failed: unexpected call UpdateUI webbrowser.c:238: Test failed: unexpected call QueryStatus_STOP === W7PROX64 (32 bit webbrowser) === webbrowser.c:1219: Test failed: unexpected call UpdateUI webbrowser.c:238: Test failed: unexpected call QueryStatus_STOP

1 0

kernel32: Add a stub for SetProcessDEPPolicy
by Detlef Riekenberg 11 Nov '10

11 Nov '10

Any comments available for this Patch? http://source.winehq.org/patches/data/68113 -- By by ... Detlef

1 0

Fwd: Re: d3d9: Improve CheckDeviceState stub to run Firefox 4 Beta 7
by André Hentschel 11 Nov '10

11 Nov '10

> From: Lats <lats(a)yless4u.com.au> > Subject: Re: d3d9: Improve CheckDeviceState stub to run Firefox 4 Beta 7 > Message-Id: <4CDC607D.5070507(a)yless4u.com.au> > Date: Fri, 12 Nov 2010 08:30:37 +1100 > > On 11/12/2010 06:35 AM, André Hentschel wrote: >> + static int i; >> >> - return WINED3DERR_INVALIDCALL; >> + TRACE("iface %p, dst_window %p stub!\n", iface, dst_window); >> + >> + if (!i++) >> + FIXME("iface %p, dst_window %p stub!\n", iface, dst_window); >> > Can you tell me what is the purpose of introducing the static int i? It makes the FIXME only display once, so you don't get flooded(just if you want to per trace) -- Best Regards, André Hentschel

1 0

Re: d3d9: Improve CheckDeviceState stub to run Firefox 4 Beta 7
by Austin English 11 Nov '10

11 Nov '10

On Thu, Nov 11, 2010 at 9:30 PM, Lats <lats(a)yless4u.com.au> wrote: > On 11/12/2010 06:35 AM, André Hentschel wrote: >> >> + static int i; >> >> - return WINED3DERR_INVALIDCALL; >> + TRACE("iface %p, dst_window %p stub!\n", iface, dst_window); >> + >> + if (!i++) >> + FIXME("iface %p, dst_window %p stub!\n", iface, dst_window); >> > Can you tell me what is the purpose of introducing the static int i? To prevent a flood of FIXME's. The FIXME will only display once, subsequently, there will be a TRACE for each call. -- -Austin

1 0

Re: mshtml/tests: Add some broken 2k8 values
by Jacek Caban 11 Nov '10

11 Nov '10

Hi André, On 11/10/10 9:01 PM, André Hentschel wrote: > That really only happens on some 2008: > http://test.winehq.org/data/tests/mshtml:htmldoc.html > --- > dlls/mshtml/tests/htmldoc.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) AFAIR these failures are regression after commit 3b20cb11c8c61f141950bc5c71cfae14a35deea0. Looking at the patch it seems that these failures are strange and unexpected. Given that it worked before, we should be able to make it not without using broken() macro. Otherwise we won't be testing refcount leaks on Windows just because exactly one box has strange behavior. Jacek

2 1

Re: AUTHORS list and the C locale on Mac OS X
by James Mckenzie 11 Nov '10

11 Nov '10

Charles Davis <cdavis(a)mymail.mines.edu> wrote: > >On 11/9/10 12:13 PM, James Mckenzie wrote: >> No, it is not a bug in GNU sed. The authors.c file needs to have the erroneous characters for the language used by >> MacOSX changed to be acceptable? >That ain't gonna fly. I think we should explicitly use a UTF-8 locale >(like en_US.UTF-8 or some such) instead of the C locale when sed goes >over the AUTHORS file. Don't shoot the messenger. Maybe we can force the use of sed if it exists in the /usr/bin directory then to get around the 'brokenness' of GNU sed on the Mac? If not, it is a real bear to set the language on a Mac per previous discussions on the Users list. James McKenzie

5 12

Re: winmm/tests: Fix test failure in multi-byte locale.
by Marvin 11 Nov '10

11 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6989 Your paranoid android. === W98SE (32 bit mci) === mci.c:1007: Test failed: mci status position: 128

1 0

Re: [1/4] msxml3/domdoc: Fix duplicated declarations after document ::get_xml()
by Alexandre Julliard 11 Nov '10

11 Nov '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From 13c41e51047445591cb1b718f835a13bfe28c53d Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Sat, 6 Nov 2010 22:07:11 +0300 > Subject: [PATCH 1/4] Fix duplicated declarations after document ::get_xml() > > --- > dlls/msxml3/domdoc.c | 50 ++++++++++++++++++++++++++++++++++++++++- > dlls/msxml3/msxml_private.h | 2 + > dlls/msxml3/node.c | 2 +- > dlls/msxml3/tests/domdoc.c | 46 +++++++++++++++++++++++++++++++++++++ > dlls/msxml3/tests/saxreader.c | 1 + > 5 files changed, 99 insertions(+), 2 deletions(-) Sorry for not catching this sooner, this one breaks with libxml 2.6.16: ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./msxml3.spec attribute.o bsc.o cdata.o comment.o dispex.o docfrag.o doctype.o domdoc.o domimpl.o element.o entityref.o factory.o httprequest.o main.o node.o nodelist.o nodemap.o parseerror.o pi.o queryresult.o regsvr.o saxreader.o schema.o text.o uuid.o xmldoc.o xmlelem.o xslpattern.tab.o xslpattern.yy.o version.res -o msxml3.dll.so -luuid -lurlmon -lshlwapi -loleaut32 -lole32 -luser32 -ladvapi32 ../../libs/port/libwine_port.a -L/usr/lib -lxml2 -lz -lpthread -licucore -lm Undefined symbols: "_xmlSaveToBuffer", referenced from: _domdoc_get_xml in domdoc.o ld: symbol(s) not found collect2: ld returned 1 exit status winegcc: gcc failed make[1]: *** [msxml3.dll.so] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: inetcpl.cpl: Added Portuguese (Brazilian) translation (try 2)
by Paul Vriens 11 Nov '10

11 Nov '10

On 11/11/2010 03:13 PM, Eu wrote: > I had forgotten to configure the author name and e-mail, resending patch. > Hi Gustavo, The header says "English resources for the Internet control panel applet". You also need only one "LANGUAGE LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN" at the beginning. There is no need to have this for every resource. -- Cheers, Paul.

1 0

Re: [1/2] version: zero pad section up to virtual size
by Alexandre Julliard 11 Nov '10

11 Nov '10

Ričardas Barkauskas <miegalius(a)gmail.com> writes: > @@ -282,8 +282,12 @@ static BOOL find_pe_resource( HFILE lzfd, DWORD *resLen, DWORD *resOff ) > } > > /* Read in resource section */ > - resSectionSize = sections[i].SizeOfRawData; > - resSection = HeapAlloc( GetProcessHeap(), 0, resSectionSize ); > + if ( sections[i].SizeOfRawData < sections[i].Misc.VirtualSize ) > + resSectionSize = sections[i].SizeOfRawData; > + else > + resSectionSize = sections[i].Misc.VirtualSize; > + > + resSection = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sections[i].Misc.VirtualSize ); That won't work, the data won't be zero since you'll be reading from the filepast the end of the section. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winspool.drv: skip tests when no printer is installed
by Marvin 11 Nov '10

11 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6979 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Website copyright notice?
by Scott Ritchie 11 Nov '10

11 Nov '10

I was looking at the Wine wikipedia article and some jerk is nominating the logo image for deletion for copyright reasons. I wanted to correct the error and point to the license for the file, but couldn't actually find a license to point at. Have we asked this question before? Part of me just assumed the website had the same license as Wine itself (LGPL 2.1 or greater), is that the case? Thanks, Scott Ritchie

2 2

Re: mshtml/tests: Add some broken 2k8 values
by Marvin 10 Nov '10

10 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6958 Your paranoid android. === W7PRO (32 bit htmldoc) === htmldoc.c:2241: Test failed: unexpected call UpdateUI htmldoc.c:2466: Test failed: unexpected call Exec_UPDATECOMMANDS

2 1

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)
by Alexandre Julliard 10 Nov '10

10 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does > Hence the wrappers inside msvcr90 around _itoa_s and _itow_s calls. Do you have an app that depends on this? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [2/2] oledb32/tests: Add the XP+ behaviour and mark it as todo_wine
by Alex Villacís Lasso 10 Nov '10

10 Nov '10

El 10/11/10 15:02, André Hentschel escribió: > That's the behaviour of XP and up: > http://test.winehq.org/data/tests/oledb32:convert.html > > It's tricky to fix in Wine as you really don't know how much space you have in dst and assuming space breaks other tests. > > --- > dlls/oledb32/tests/convert.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/dlls/oledb32/tests/convert.c b/dlls/oledb32/tests/convert.c > index b9ef71f..cdae859 100644 > --- a/dlls/oledb32/tests/convert.c > +++ b/dlls/oledb32/tests/convert.c > @@ -1469,10 +1469,15 @@ static void test_converttostr(void) > memset(dst, 0xcc, sizeof(dst)); > dst_len = 0x1234; > hr = IDataConvert_DataConvert(convert, DBTYPE_I2, DBTYPE_STR, 0,&dst_len, src, dst, 0, 0,&dst_status, 0, 0, 0); > - ok(hr == DB_E_ERRORSOCCURRED, "got %08x\n", hr); > - ok(dst_status == DBSTATUS_E_DATAOVERFLOW, "got %08x\n", dst_status); > + todo_wine ok(hr == S_OK || > + broken(hr == DB_E_ERRORSOCCURRED /* Win9x, WinMe, NT4 and 2k */), > + "got %08x\n", hr); > + todo_wine ok(dst_status == DBSTATUS_S_OK || > + broken(dst_status == DBSTATUS_E_DATAOVERFLOW /* Win9x, WinMe, NT4 and 2k */), > + "got %08x\n", dst_status); > ok(dst_len == 4, "got %d\n", dst_len); > - ok(dst[0] == (char)0xcc, "got %02x\n", dst[0]); > + todo_wine ok(dst[0] == '4' || > + broken(dst[0] == (char)0xcc /* Win9x, WinMe, NT4 and 2k */), "got %02x\n", dst[0]); > > *(short *)src = 4321; > memset(dst, 0xcc, sizeof(dst)); > Weird. When I wrote that test, the WinXP-SP2 virtual machine did return DB_E_ERRORSOCCURRED/DBSTATUS_E_DATAOVERFLOW on this condition (available space equal to zero), and did not touch the output buffer in the process. In my opinion, Win9x behavior is actually OK, and the behavior you observe is the one that should be flagged as broken. It is hard to imagine the newer behavior (apparently "assume unbounded output buffer if reported space is zero") as more correct than the Win9x behavior. I think this should be treated the same as your 1/2 patch, which flags the behavior as Vista-only brokenness.

2 1

Re: msvcrt: Fixed (_w)fopen_s with test. (try 3)
by Marvin 10 Nov '10

10 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6935 Your paranoid android. === W98SE (32 bit file) === file.c:999: Test failed: smaller size block: Wrong error data () file.c:1007: Test failed: smaller size block: Stdout file shouldn't contain data

2 1

Re: msvcrt: Implement strncat_s.
by Alexandre Julliard 10 Nov '10

10 Nov '10

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > +int CDECL MSVCRT_strncat_s( char* dst, MSVCRT_size_t elem, const char* src, MSVCRT_size_t count ) > +{ > + MSVCRT_size_t i, j; > + if(!dst) return MSVCRT_EINVAL; > + if(elem == 0) return MSVCRT_EINVAL; > + if(!src) > + { > + dst[0] = '\0'; > + return MSVCRT_EINVAL; > + } Again, you should be using the parameter checking macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

website: 404 Translated to Hebrew
by Yaron Shahrabani 10 Nov '10

10 Nov '10

Kind regards, Yaron Shahrabani <Hebrew translator>

2 1

Re: [PATCH 2/2 resend] urlmon: Added more IInternetProtocolEx tests.
by Marvin 10 Nov '10

10 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6947 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:978: Test failed: hrResult = 800c0007, expected: 00000000 protocol.c:983: Test failed: dwError == ERROR_SUCCESS protocol.c:2776: Test failed: Read failed: 800c0007 (0 bytes) Timeout

1 0

Re: msvcrt: Fixed (_w)fopen_s with test. (try 2)
by Dmitry Timoshkov 10 Nov '10

10 Nov '10

Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > + if (!p_fopen_s) > + { > + win_skip("Skipping fopen_s test\n"); > + return; > + } > + else > + { > + /* testing fopen_s */ > + ret = p_fopen_s(&file, name, "w"); > + ok(ret == 0, "fopen_s failed with %d\n", ret); > + ok(file != 0, "fopen_s failed to return value\n"); > + fwrite(name, sizeof(name), 1, file); > + > + ret = fclose(file); > + ok(ret != EOF, "File failed to close\n"); > + > + file = fopen(name, "r"); > + ok(file != 0, "fopen failed\n"); > + len = fread(buff, 1, sizeof(name), file); > + ok(len == sizeof(name), "File length supposed to be %d, not %d\n", sizeof(name), len); > + buff[sizeof(name)] = '\0'; > + ok(strcmp(name, buff) == 0, "File content mismatch! Got %s, expected %s\n", buff, name); > + > + ret = fclose(file); > + ok(ret != EOF, "File failed to close\n"); > + > + ok(_unlink(name) == 0, "Couldn't unlink file named '%s'\n", name); > + } > +} The whole 'else { }' block is not necessary, same for the test below. -- Dmitry.

1 0

GetSystemPaletteEntries() patch
by Eric Durbin 10 Nov '10

10 Nov '10

What was wrong with the patch sent in this post? http://article.gmane.org/gmane.comp.emulators.wine.devel/54403%29

1 0

Re: msvcrt: Fixed (_w)fopen_s with test. (try 2)
by Marvin 10 Nov '10

10 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6922 Your paranoid android. === W98SE (32 bit file) === file.c:999: Test failed: smaller size block: Wrong error data () file.c:1007: Test failed: smaller size block: Stdout file shouldn't contain data

1 0

Re: krnl386.exe: Mention dosemu
by Charles Davis 09 Nov '10

09 Nov '10

On 11/9/10 4:20 PM, André Hentschel wrote: > @@ -643,7 +643,7 @@ static DWORD WINAPI MZ_DOSVM( LPVOID lpExtra ) > > if (GetLastError() == ERROR_NOT_SUPPORTED) > MESSAGE( "wine: Cannot start DOS application %s\n" > - " because vm86 mode is not supported on this platform.\n", > + " because vm86 mode is not supported on this platform, try dosemu.\n", You mean DOSBox, right? dosemu needs vm86(2) anyway, and AFAIK isn't even available on non-Linux. Chip

1 0

Re: msvcrt: Fixed (_w)fopen_s always fails.
by Austin English 09 Nov '10

09 Nov '10

On Tue, Nov 9, 2010 at 9:38 PM, Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > (_w)fopen_s were always failing due to regression introduced in > commit 00f07046c0be658d97c47f69e1b4c518bc06b3a2 > --- > dlls/msvcrt/file.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c > index 329cdeb..91cd448 100644 > --- a/dlls/msvcrt/file.c > +++ b/dlls/msvcrt/file.c > @@ -2742,7 +2742,7 @@ int CDECL MSVCRT_fopen_s(MSVCRT_FILE** pFile, > const char *filename, const char *mode) > { > if (!MSVCRT_CHECK_PMT(pFile != NULL) || !MSVCRT_CHECK_PMT(filename != NULL) || > - MSVCRT_CHECK_PMT(mode != NULL)) { > + !MSVCRT_CHECK_PMT(mode != NULL)) { > *MSVCRT__errno() = MSVCRT_EINVAL; > return MSVCRT_EINVAL; > } > @@ -2769,7 +2769,7 @@ int CDECL MSVCRT__wfopen_s(MSVCRT_FILE** pFile, const MSVCRT_wchar_t *filename, > const MSVCRT_wchar_t *mode) > { > if (!MSVCRT_CHECK_PMT(pFile != NULL) || !MSVCRT_CHECK_PMT(filename != NULL) || > - MSVCRT_CHECK_PMT(mode != NULL)) { > + !MSVCRT_CHECK_PMT(mode != NULL)) { > *MSVCRT__errno() = MSVCRT_EINVAL; > return MSVCRT_EINVAL; > } > -- > 1.7.0.4 Sounds like a good reason to add a unit test to prevent it from happening again, then. -- -Austin

1 0

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.
by Henri Verbeet 09 Nov '10

09 Nov '10

2010/11/8 Rico Schüller <kgbricola(a)web.de>: > - object->vtbl = &d3dcompiler_shader_reflection_vtbl; > - object->refcount = 1; > + hr = d3dcompiler_shader_reflection_init(object, data, data_size, riid); > + if (FAILED(hr)) > + { > + WARN("Failed to initialize shader reflection\n"); > + IUnknown_Release((IUnknown *)object); > + return hr; > + } You can't do that. Since d3dcompiler_shader_reflection_init() is responsible for setting the vtbl, you can't assume it's set if d3dcompiler_shader_reflection_init() fails. You'll have to use HeapFree() here. > + if (!IsEqualGUID(riid, &IID_ID3D11ShaderReflection)) > + { > + WARN("Wrong rrid %s, accept only %s!\n", debugstr_guid(riid), debugstr_guid(&IID_ID3D11ShaderReflection)); > + return E_FAIL; > + } This can be done in D3DReflect() before even allocating the reflection object. (Also, "rrid" is a typo.)

2 3

Re: AUTHORS list and the C locale on Mac OS X
by James Mckenzie 09 Nov '10

09 Nov '10

Charles Davis <cdavis(a)mymail.mines.edu> wrote: > >Hi, > >There may be a problem with the way the authors.c file is generated on a >Mac with GNU sed installed. > >On Mac OS X, the C locale's default encoding is MacRoman, not UTF-8. >This has some pretty surprising consequences. For example, since the >AUTHORS file contains UTF-8 multibyte sequences that aren't valid in the >MacRoman encoding, GNU sed doesn't match those sequences in the .* >regexp, and the authors.c file comes out wrong. Mac OS sed does not have >this problem. So now I'm stuck changing the Makefile to use the system >sed (in /usr/bin) instead of GNU sed. > I found this a long time ago. Fink just modifies the Authors.c file to remove those sequences. I went one better and removed GNU sed from my Mac (fink purge sed) as I found that MacOSX version of sed would do everything that GNU sed did and I did not have to edit the file. >I could uninstall GNU sed, but there's one small problem. I have a >Gentoo prefix set up. It is the reason I have GNU sed installed. If I >install or upgrade practically anything in my Gentoo prefix, then GNU >sed will just get pulled right back in. > >Reading the manual for GNU sed tells me that this is by design and that >this behavior--not matching characters that are invalid in the current >locale--is in fact mandated by POSIX. If that's the case, then the >LC_ALL= statement in the Makefile needs to change. To what, I don't >know. I'm hoping one of you has an idea. > >If you think, however, that this is a bug in GNU sed, then I will gladly >write a report to the maintainer about it. > No, it is not a bug in GNU sed. The authors.c file needs to have the erroneous characters for the language used by MacOSX changed to be acceptable? James McKenzie

2 1

AUTHORS list and the C locale on Mac OS X
by Charles Davis 09 Nov '10

09 Nov '10

Hi, There may be a problem with the way the authors.c file is generated on a Mac with GNU sed installed. On Mac OS X, the C locale's default encoding is MacRoman, not UTF-8. This has some pretty surprising consequences. For example, since the AUTHORS file contains UTF-8 multibyte sequences that aren't valid in the MacRoman encoding, GNU sed doesn't match those sequences in the .* regexp, and the authors.c file comes out wrong. Mac OS sed does not have this problem. So now I'm stuck changing the Makefile to use the system sed (in /usr/bin) instead of GNU sed. I could uninstall GNU sed, but there's one small problem. I have a Gentoo prefix set up. It is the reason I have GNU sed installed. If I install or upgrade practically anything in my Gentoo prefix, then GNU sed will just get pulled right back in. Reading the manual for GNU sed tells me that this is by design and that this behavior--not matching characters that are invalid in the current locale--is in fact mandated by POSIX. If that's the case, then the LC_ALL= statement in the Makefile needs to change. To what, I don't know. I'm hoping one of you has an idea. If you think, however, that this is a bug in GNU sed, then I will gladly write a report to the maintainer about it. Chip

1 0

Re: gdi32: Remove broken check for WinXP.
by Marvin 09 Nov '10

09 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6910 Your paranoid android. === W2KPROSP4 (32 bit font) === Failure running script in VM: Exceeded timeout limit of 315 sec

1 0

Re: [PATCH 10/14] [Msvcrt*]: implemented _vc(w)printf
by Alexandre Julliard 09 Nov '10

09 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > +int CDECL _vcprintf(const char* format, __ms_va_list xvalist) > { > char buf[2048], *mem = buf; > int written, resize = sizeof(buf), retval; > - __ms_va_list valist; > + __ms_va_list valist = xvalist; You can't copy a valist. This needs to be integrated properly with the other printf functions. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)
by Eric Pouech 09 Nov '10

09 Nov '10

to sum up the recent discrepencies between msvcrt and msvcrN0 Dlls: - msvcrt doesn't raise exception on _s functions while msvcrN0 does - (likely) in _s functions returning an errno_t value, msvcrt does set errno to the returned value, while msvcrN0 doesn't change the errno value (tested on _itoa_s and wcsncat_s) I wonder if should challenge the current scheme of forwarding all APIs from msvcrN0 to msvcrt (and writing wrappers in msvcr90 to cope with the various discrepencies) we could let msvcrt behave differently when loaded from our msvcrN0 DLLs than when loaded standalone, and factorize the discrepencies within msvcrt itself comments welcome A+ -- Eric Pouech

1 0

(no subject)
by Greg Geldorp 08 Nov '10

08 Nov '10

> From: Eric Pouech > > how come I got two different test results for the same patch ? > moreover one is perfectly ok, while the other shows strange results > any idea ? Yeah, that's a bit weird. The only thing I can think of is some kind of timing issue, but looking at the code that seems unlikely in this case. So basically, I don't have a clue. Ge.

3 2

wine cannot handle fc-cache (64bit) but fc-cache32 is okay
by Per Olesen 08 Nov '10

08 Nov '10

Hi Is it as-it-should-be, that wine only handles 32bit fc-cache? Is it known, that executing the 64bit version /usr/sbin/fc-cache will make the font-cache fail for wine, hence making wine *very* slow to startup? Rebuilding the cache with fc-cache32 makes wine start quickly again. It seems that the actual font cache format for fc-cache has changed between architectures. ? Regards, Per

1 0

Re: winegcc: Add Macho-o lib detection support
by Charles Davis 08 Nov '10

08 Nov '10

On 11/8/10 10:52 AM, André Hentschel wrote: > @@ -321,7 +321,8 @@ static int check_platform( struct options *opts, const char *file ) > unsigned char header[16]; > if (read( fd, header, sizeof(header) ) == sizeof(header)) > { > - /* FIXME: only ELF is supported, platform is not checked beyond 32/64 */ > + /* FIXME: only ELF and Macho-o is supported, platform is not checked beyond 32/64 */ Typo 'Macho-o'. > @@ -331,6 +332,15 @@ static int check_platform( struct options *opts, const char *file ) > ret = (opts->force_pointer_size == 4 || > (!opts->force_pointer_size && opts->target_cpu != CPU_x86_64)); > } > + /* Big Endian or Little Endian Mach-o File */ > + else if (!memcmp( header, "\376\355\372\316", 4 ) || !memcmp( header, "\316\372\355\376", 4 )) For 64-bit files, the magic number is 0xfeedfacf, not 0xfeedface. (Notice how the 64-bit magic is one more than the 32-bit magic.) You should check for that, too. I would like to take this time to point out that on Mac OS, there are no separate 32-bit and 64-bit library directories (i.e. no lib32 and lib64, only lib). If you want a 32-bit and a 64-bit version of a binary or library installed, you're expected to build a fat binary/library. Nearly all of the system libraries and binaries installed with Mac OS X are in fact fat. Chip

2 1

'winetricks dotnet35' starting to work
by Dan Kegel 08 Nov '10

08 Nov '10

In svn ( http://winezeug.googlecode.com/svn/trunk/winetricks ), I've added Louis' workaround from http://bugs.winehq.org/show_bug.cgi?id=22551#c5 to winetricks dotnet35. This let the game Bloodline Champions at least show its splash screen. Perhaps it will be useful for other apps, too. With wine-1.3.4 or earlier, anyway; dotnet30 explodes with wine-1.3.5 or later, see http://bugs.winehq.org/show_bug.cgi?id=25074

2 1

Re: [PATCH] comctl32/tests: Change expect_band_content test into a macro to ensure line numbers are reported correctly on test failure.
by Alexandre Julliard 08 Nov '10

08 Nov '10

Austin Lund <austin.lund(a)gmail.com> writes: > +#define expect_band_content(hRebar, uBand, fStylep, clrForep, clrBackp, \ > + lpTextp, iImagep, hwndChildp, cxMinChildp, cyMinChildp, cxp, hbmBackp, \ > + wIDp, cyChildp, cyMaxChildp, cyIntegralp, cxIdealp, lParamp, cxHeaderp, cxHeader_brokenp) \ > +{ \ > + CHAR buf[MAX_PATH] = "abc"; \ > + REBARBANDINFOA rb; \ > + memset(&rb, 0xdd, sizeof(rb)); \ > + rb.cbSize = REBARBANDINFOA_V6_SIZE; \ > + rb.fMask = RBBIM_BACKGROUND | RBBIM_CHILD | RBBIM_CHILDSIZE | RBBIM_COLORS \ > + | RBBIM_HEADERSIZE | RBBIM_ID | RBBIM_IDEALSIZE | RBBIM_IMAGE | RBBIM_LPARAM \ > + | RBBIM_SIZE | RBBIM_STYLE | RBBIM_TEXT; \ > + rb.lpText = buf; \ > + rb.cch = MAX_PATH; \ > + ok(SendMessageA(hRebar, RB_GETBANDINFOA, uBand, (LPARAM)&rb), "RB_GETBANDINFO failed\n"); \ > + expect_eq(rb.fStyle, fStylep, int, "%x"); \ > + expect_eq(rb.clrFore, clrForep, COLORREF, "%x"); \ > + expect_eq(rb.clrBack, clrBackp, COLORREF, "%x"); \ > + expect_eq(strcmp(rb.lpText, lpTextp), 0, int, "%d"); \ > + expect_eq(rb.iImage, iImagep, int, "%x"); \ > + expect_eq(rb.hwndChild, hwndChildp, HWND, "%p"); \ > + expect_eq(rb.cxMinChild, cxMinChildp, int, "%d"); \ > + expect_eq(rb.cyMinChild, cyMinChildp, int, "%d"); \ > + expect_eq(rb.cx, cxp, int, "%d"); \ > + expect_eq(rb.hbmBack, hbmBackp, HBITMAP, "%p"); \ > + expect_eq(rb.wID, wIDp, int, "%d"); \ > + /* the values of cyChild, cyMaxChild and cyIntegral can't be read unless the band is RBBS_VARIABLEHEIGHT */ \ > + expect_eq(rb.cyChild, cyChildp, int, "%x"); \ > + expect_eq(rb.cyMaxChild, cyMaxChildp, int, "%x"); \ > + expect_eq(rb.cyIntegral, cyIntegralp, int, "%x"); \ > + expect_eq(rb.cxIdeal, cxIdealp, int, "%d"); \ > + expect_eq(rb.lParam, (LPARAM)lParamp, LPARAM, "%ld"); \ > + ok( rb.cxHeader == cxHeaderp || broken(rb.cxHeader == cxHeader_brokenp), \ > + "expected %d for %d\n", cxHeaderp, rb.cxHeader ); \ Please don't define huge macros like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] mshtml: Don't free string that will be cleared by SafeArrayDestroy.
by Michael Stefaniuc 08 Nov '10

08 Nov '10

Hello Jacek, Jacek Caban wrote: > --- > dlls/mshtml/tests/dom.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) in that case "str" becomes unused and can be removed like in the attached patch. bye michael

2 1

Re: [PATCH 4/4] mshtml: Moved tid declaration to separated file.
by Alexandre Julliard 08 Nov '10

08 Nov '10

Jacek Caban <jacek(a)codeweavers.com> writes: > Doing define/include tricks isn't perfect solution, but the current > state is even worse. > --- > dlls/mshtml/dispex.c | 93 ++--------------------------------------- > dlls/mshtml/mshtml_private.h | 94 ++--------------------------------------- > dlls/mshtml/tid.inc | 88 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 98 insertions(+), 177 deletions(-) > create mode 100644 dlls/mshtml/tid.inc Please don't create a separate file, particularly not with a non-standard extension. You can do this with a macro in mshtml_private.h. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/8] d3dcompiler: Add ID3D11ShaderReflectionType stub interface.
by Henri Verbeet 08 Nov '10

08 Nov '10

2010/11/7 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3dcompiler_43/d3dcompiler_private.h | 7 ++ > dlls/d3dcompiler_43/reflection.c | 106 > +++++++++++++++++++++++++++++ > 2 files changed, 113 insertions(+), 0 deletions(-) > You're adding dead code. Also, I expect there to be no reason to for the vtbl and implementation structure to be visible outside of reflection.c.

1 0

Re: [PATCH 4/8] d3dcompiler: Add initial reflection parsing.
by Henri Verbeet 08 Nov '10

08 Nov '10

2010/11/7 Rico Schüller <kgbricola(a)web.de>: > + hr = d3dcompiler_parse_reflection(data, data_size, riid, object); > + if (FAILED(hr)) > + { > + WARN("Failed to parse shader reflection\n"); > + IUnknown_Release((IUnknown *)object); > + return hr; > + } You might as well create a function along the lines of d3dc_shader_reflection_init(), call that here, and keep the vtbl and d3dcompiler_parse_reflection() internal to reflect.c. > +static void d3dcompiler_parse_unknown(const char *data, DWORD data_size) > +{ > + const char *ptr = data; > + > + skip_dword_unknown(&ptr, data_size >> 2); > + > + return; > +} I don't think this is very useful in general, it's just going to create a lot of console spam.

1 0

Re: [PATCH 3/5] ddraw: Setup the device window in SetCooperativeLevel().
by Marvin 08 Nov '10

08 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6885 Your paranoid android. === W98SE (32 bit ddrawmodes) === ddrawmodes: unhandled exception c0000005 at 004122E8 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH] wined3d: correctly guess_card_vendor() for gallium r600 drivers
by Austin English 08 Nov '10

08 Nov '10

On Sun, Nov 7, 2010 at 2:08 PM, Brian Paterni <bpaterni(a)gmail.com> wrote: > Hello, I've been receiving a couple "unrecognized GL_VENDOR" fixme's lately and > decided to poke around wine's source. I've found that wined3d_guess_card_vendor > does not return the correct enum for people running mesa's r600g driver, and now > that r600g returns "AMD <gpu chip>" as part of openGL's renderer string, we can > easily use that to check for AMD (ATI) hardware: > > --- > dlls/wined3d/directx.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 32d2431..3908c5f 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1373,11 +1373,10 @@ static enum wined3d_pci_vendor wined3d_guess_card_vendor(const char *gl_vendor_s > if (strstr(gl_vendor_string, "ATI") > || strstr(gl_vendor_string, "Advanced Micro Devices, Inc.") > || strstr(gl_vendor_string, "X.Org R300 Project") > + || (strstr(gl_vendor_string, "X.Org") && strstr(gl_renderer, "AMD")) > || strstr(gl_renderer, "R100") > || strstr(gl_renderer, "R200") > - || strstr(gl_renderer, "R300") > - || strstr(gl_renderer, "R600") > - || strstr(gl_renderer, "R700")) > + || strstr(gl_renderer, "R300")) > return HW_VENDOR_ATI; > > if (strstr(gl_vendor_string, "Intel(R)") > -- > 1.7.2.3 Howdy Brian, You're mixing tabs and spaces. Please use consistent spacing, as the rest of the file does. -- -Austin

3 2

Where in the code does wine read fonts?
by Per Olesen 08 Nov '10

08 Nov '10

Hi! I am trying to figure out how wine reads fonts on startup but am having a little trouble. I checked out the source and found a lot of good stuff in "winex11.drv/xfont.c", but I am not sure this is actually the code, that gets executed when my wine boots. What I experience, is that wine reads the X fonts, using the fontconfig library. Is that correct? Maybe I should say *why* I am digging into the font handling in the code. When I rebuild the system fontcache (using "fc-cache"), wine suddenly gets painfully slow to boot. When I revert to the old cache I had before rebuild, it gets fast again. Listing the cache content (using "fc-list") yields the same amount of fonts before and after rebuild, so I find it strange with the extra boot time. Actually, it would be better for me to NOT have wine read the X fonts (I think). So, I tried digging in to understand it better from the code. Is there a central place in the source code I am missing, that could lead me to the lightsource :-) Regards, Per

2 1

Re: [PATCH] comctl32/tests: Change expect_band_content test into a macro to ensure line numbers are reported correctly on test failure.
by Nikolay Sivov 08 Nov '10

08 Nov '10

On 11/8/2010 13:29, Austin Lund wrote: > --- > dlls/comctl32/tests/rebar.c | 69 ++++++++++++++++++++---------------------- > 1 files changed, 33 insertions(+), 36 deletions(-) It's better to use ok_() for that, and a one line macro to pass a line number.

1 0

Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.
by Vitaliy Margolen 08 Nov '10

08 Nov '10

On 11/07/2010 04:06 PM, David Hedberg wrote: > - ok(hr == S_OK, "got (0x%08x)\n", hr); > + ok(hr == S_OK || hr == E_FAIL /* Win7 */, "got (0x%08x)\n", hr); This can't be correct. It either works or it fails. Can't be both at the same time. You should look into why it's failing on Win7 and correct the test so it succeeds. Vitaliy

5 5

PGP key signing party at WineConf
by Shachar Shemesh 08 Nov '10

08 Nov '10

Hi all, During WineConf we will be holding a key signing party, organized by your truly. The wiki page for WineConf has been updated with details on how to participate, and I have set up a page explaining the process for people who have never participated before. Please email your keys to me, with the subject "WineConf key signing" (so that my spam filters don't eat it up). The wineconf wiki page, in case you are not up to date, is at http://wiki.winehq.org/WineConf2010 The key signing page is at http://wiki.winehq.org/KeySigningParty Shachar -- Shachar Shemesh Lingnu Open Source Consulting Ltd. http://www.lingnu.com

2 2

Strange test bot results
by Eric Pouech 07 Nov '10

07 Nov '10

Hi Ge, how come I got two different test results for the same patch ? moreover one is perfectly ok, while the other shows strange results any idea ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [PATCH 2/6] [Msvcrt*]: now using the macros for parameter checking for wcsncat_s (and fixed the test)
by Marvin 07 Nov '10

07 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6861 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === WVISTAADM (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W2K8SE (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PRO (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (32 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (64 bit msvcr90) === msvcr90.c:307: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:315: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:324: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:333: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:342: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:352: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:362: Test failed: Expected errno to be ERANGE, got 9

1 0

Re: [PATCH 1/6] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)
by Marvin 07 Nov '10

07 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6859 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W2K3R2SESP2 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === WVISTAADM (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W2K8SE (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PRO (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (32 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9 === W7PROX64 (64 bit msvcr90) === msvcr90.c:306: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:314: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:323: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:332: Test failed: Expected errno to be EINVAL, got 9 msvcr90.c:341: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:351: Test failed: Expected errno to be ERANGE, got 9 msvcr90.c:361: Test failed: Expected errno to be ERANGE, got 9

1 0

Re: [PATCH 2/4] quartz: Fix PullPin_EnumMediaTypes
by Erich Hoover 07 Nov '10

07 Nov '10

Is there some reason you chose to add an additional function for this, rather than fill in pPinImpl->pin.pFuncsTable? I ask because I was working on this issue last night and submitted an attachment to Bug #24782 for people to try: http://bugs2.winehq.org/attachment.cgi?id=31770 Erich Hoover ehoover(a)mines.edu

2 1

Re: [PATCH 3/4] mshtml: Added IDispatchEx support to HTMLStyleSheetsCollection object.
by Marvin 07 Nov '10

07 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6856 Your paranoid android. === W2K3R2SESP2 (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PRO (32 bit dom) === dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B} dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (32 bit dom) === dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B} dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (64 bit dom) === dom.c:5854: Test failed: unexpected guid {3050F547-98B5-11CF-BB82-00AA00BDCE0B} dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}

1 0

Re: [PATCH 2/4] mshtml: Added IOmNavigator::get_plugins implementation.
by Marvin 07 Nov '10

07 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6855 Your paranoid android. === W2K3R2SESP2 (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PRO (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (32 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B} === W7PROX64 (64 bit dom) === dom.c:3607: Test failed: unexpected guid {3050F54A-98B5-11CF-BB82-00AA00BDCE0B}

1 0

Re: [PATCH 2/4] comctl32/tests: Change toolbar size test data to load dynamically.
by Alexandre Julliard 07 Nov '10

07 Nov '10

Austin Lund <austin.lund(a)gmail.com> writes: > +static void init_tbsize_results(void) { > + tbsize_results = (tbsize_result_t *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 24*sizeof(tbsize_result_t)); > + tbsize_results[0] = (tbsize_result_t) { {0, 0, 672, 26}, {100, 22}, 5, { > + { 0, 2, 23, 24}, { 23, 2, 46, 24}, { 46, 2, 54, 24}, > + { 54, 2, 77, 24}, { 77, 2, 100, 24} } }; That syntax is not portable, please avoid it. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite
by Henri Verbeet 07 Nov '10

07 Nov '10

On 2 November 2010 07:20, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Repeatedly call a shader 32 times with linearly varying values and test the results against > + an array of floats using the given epsilon */ Why can't this just use the existing framework?

2 1

Re: jscript: Added Date.setYear stub implementation.
by Marvin 06 Nov '10

06 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6844 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

New winetricks 20101106: mostly just bugfixes and updates
by Dan Kegel 06 Nov '10

06 Nov '10

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English - add amstream verb - bump firefox to 3.6.12 - fix dotnet11 install on recent wine - if user is using a 64-bit prefix, tell them how to create a 32-bit one instead. - initial 64-bit cleanup - update eadm sha1sum - update flash sha1sum - update utorrent sha1sum - don't initialize wine just to show the help menu. (Issue 182) - version shouldn't initialize Wine either (part 2 of Issue 182). Dan Kegel - update shockwave, utorrent sha1sum - added verbs l3codecx and dmsynth, and added devenum to directmusic; for winehq bug 24911 - allow continuing partial downloads if WINETRICKS_CONTINUE_DOWNLOAD is set

2 2

Re: Voting for bugs (Was: Re: [Bug 20969])
by James Mckenzie 06 Nov '10

06 Nov '10

Tom Spear <speeddymon(a)gmail.com> wrote: [Message arranged in top to bottom posting order to comply with mailing list rules/guidelines] >On Tue, Nov 2, 2010 at 12:01 PM, <wine-bugs(a)winehq.org> wrote: > >> http://bugs.winehq.org/show_bug.cgi?id=20969 >> >> --- Comment #19 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-11-02 >> 12:01:23 CDT --- >> (In reply to comment #18) >> > Those of you with this issue, make sure you vote for this in bugzilla so >> that >> > it can be confirmed, if you haven't already. >> >> Voting for bugs in Wine bugzilla is useless and does nothing except adding >> noise. >> > >Can/should voting for bugs be disabled if it is 'useless and does nothing >except adding noise'? > >Thanks > >Tom > > Tom: Voting for bugs does two things, and I don't think Dmitry wants to do the first: 1. It confirms that a bug does exists and possibly on multiple platforms. 2. It advises developers that more than one system/configuration is affected by a bug. I agree that adding thousands of votes to a long standing bug is 'noise'. Given that we have a limited resource of developers, having users verify bugs and to vote for them to give an idea of how severe a bug is might be helpful. Just my .02 USD here. James McKenzie

6 8

re: Function strstr and MinGW
by Dan Kegel 05 Nov '10

05 Nov '10

You forgot to null-terminate escaped_space[].

1 0

Re: Function strstr and MinGW
by GOUJON Alexandre 05 Nov '10

05 Nov '10

On 11/05/2010 09:11 PM, Ozan Türkyılmaz wrote: > \0 ending? > I think you're right. I forgot '\0' at the end of escaped_space. That's so stupid ! Well, sorry for the noise and thanks for your help. It remember me a sentence a teacher told me: "When there are errors, we know a program doesn't work but when he runs fine, we're not sure it doesn't contains any error" So thanks again !

1 0

Function strstr and MinGW
by GOUJON Alexandre 05 Nov '10

05 Nov '10

Hi everyone, I'm still trying to improve wine cmd but I'm stuck with my patch making tests failing. After some investigations, I've found that my function which replace all @space@ by real spaces does not always work. So I've written a test_case (attached code). It runs perfectly on Ubuntu (compiled with gcc) but does nothing on Windows (compiled with i586-mingw32msvc-gcc). In fact, on windows, strstr fails and so never goes into the while{ } loop. Is MinGW the culprit ? Should I use another function ? Any idea ? [Why *standard* function don't even work on Windows ?] Thanks in advance !

2 1

Re: [PATCH 2/2] slc/tests: Add tests for SLGetWindowsInformationDWORD [try 2]
by Marvin 05 Nov '10

05 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6829 Your paranoid android. === WVISTAADM (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W2K8SE (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W7PRO (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W7PROX64 (32 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED) === W7PROX64 (64 bit slc) === slc.c:71: Test failed: got 0xc004f012 and 0xdeadbeef (expected SL_E_RIGHT_NOT_GRANTED)

1 0

Re: [PATCH 5/5] quartz: Remove position from filtergraph
by Alexandre Julliard 05 Nov '10

05 Nov '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > --- > dlls/quartz/filtergraph.c | 59 +++++++++++++++++++------------------------- > 1 files changed, 26 insertions(+), 33 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so filtergraph.c && touch filtergraph.ok filtergraph.c:272: Test failed: GetCurrentPosition failed: 80004001 filtergraph.c:283: Test failed: GetCurrentPosition failed: 80004001 make: *** [filtergraph.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: raise ulimit -n if possible, warn if very low
by Alexandre Julliard 05 Nov '10

05 Nov '10

Dan Kegel <dank(a)kegel.com> writes: > void sock_init(void) > { > + struct rlimit lim; > + > + if (!getrlimit(RLIMIT_NOFILE, &lim) && lim.rlim_cur < lim.rlim_max) { > + lim.rlim_cur = lim.rlim_max; > + setrlimit(RLIMIT_NOFILE, &lim); > + } This is already done in the Wine loader, there's no need to do it twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Transparent windows
by Vassilis Virvilis 05 Nov '10

05 Nov '10

Hi everybody, I am trying to run a pretty complex dotnet (3.5) app which renders flash contents via flash in a box http://www.f-in-box.com/ I have to say that congratulations are in order to everybody involved because the whole thing works remarkably well for such a complex amalgam of technologies and platforms. The problem I am trying to debug right now is that transparent windows comes out black in wine. So the question is: 1) What are the wine debug channels I have to turn on in order to understand what's happening? 2) Any ideas where the code responsible might be located (gdi, user32, wineserver)? 2a) Is it some window creation flag responsible for this? 2b) Is it X-Window dependent? Does it require OpenGL and 3D effects enabled? Thanks in advance .bill

4 6

banning spammer from the forum
by Rosanne DiMesio 04 Nov '10

04 Nov '10

Jeremy, Please ban ebook1210 from the forum. I've had to delete multiple spam posts from him/her over the past couple of days. -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 1

Re: msvcrt: Implement _asctime_s and _wasctime_s.
by Alexandre Julliard 04 Nov '10

04 Nov '10

Eryk Wieliczko <ewdevel(a)gmail.com> writes: > +MSVCRT_long CDECL MSVCRT_asctime_s(char *output, MSVCRT_size_t max, const struct MSVCRT_tm *mstm) > +{ > + char *buffer; > + MSVCRT_size_t bufflen; > + > + if (output && max > 0) > + output[0] = '\0'; > + if (!output) > + { > + *MSVCRT__errno() = MSVCRT_EINVAL; > + return MSVCRT_EINVAL; > + } You probably want to use the new parameter checking macros. Also the first check is redundant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] slc: Implement SLGetWindowsInformationDWORD
by Alexandre Julliard 04 Nov '10

04 Nov '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > +HRESULT WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue) > +{ > + FIXME("(%s, %p): semi-stub\n", debugstr_w(lpszValueName), pdwValue); > + > + if (!lpszValueName || !pdwValue) > + return E_INVALIDARG; > + > + if (!*lpszValueName) > + return SL_E_RIGHT_NOT_GRANTED; > + > + /* We have always a genuine Wine */ > + *pdwValue = 1; > + return S_OK; There's no reason that this dword would represent the genuine flag, it can be just about anything. Returning value not found would probably be preferable, or else do a real attempt at determining what value would be expected for the specified name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (resend try 5)
by Alexandre Julliard 04 Nov '10

04 Nov '10

Charles Davis <cdavis(a)mymail.mines.edu> writes: > If the volume is indeed case insensitive, we skip searching through the > whole directory ourselves, and just stat() each portion of the path. You still have extra stat calls. You should stop trying to pass a case_sensitive flag to find_file_in_dir and have it take care of everything internally, if and only if a case insensitive search seems to be required. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fwd: msvcrt: Implement _get_tzname.
by Eryk Wieliczko 04 Nov '10

04 Nov '10

http://msdn.microsoft.com/en-us/library/4ssfs1ya.aspx _get_tzname should simply copy the contents of _tzname. In my opinion it should be ok. According to this document it's the default value. In my Polish XP it's also "PST" and "PDT", which is of course irracional ( Poland is in Europe ). So I would assume static char tzname_std[64] = ""; static char tzname_dst[64] = ""; more of a hack. 2010/11/3 Dmitry Timoshkov <dmitry(a)codeweavers.com>: > Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > This is not an implementation, this is a quick and dirty hack. > > -- > Dmitry. >

2 1

RFC: Fixing comctl32 toolbar tests for different system font heights
by Austin Lund 04 Nov '10

04 Nov '10

I'm trying to fix these test failures: http://test.winehq.org/data/d4f64121e83671ac10ed6ead04f1c19eb5586cb0/xp_wtb… These failures occur because the system font metrics are different to what is assumed for the hard-coded numbers. Attached is my go at fixing these (in a three part patch set). Is this approach even close to being the right way to do this?

1 0

Re: [PATCH 3/5] d3d9/tests: Check for multiple expected messages in test_wndproc().
by Marvin 04 Nov '10

04 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6786 Your paranoid android. === WVISTAADM (32 bit device) === device.c:2650: Test failed: Expected foreground window 000301CA, got 000201C8.

1 0

Re: [PATCH 2/5] d3d8/tests: Check for multiple expected messages in test_wndproc().
by Marvin 04 Nov '10

04 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6785 Your paranoid android. === WVISTAADM (32 bit device) === device.c:1670: Test failed: Expected foreground window 000201D4, got 000101D2. === W2K8SE (32 bit device) === device.c:1670: Test failed: Expected foreground window 00010126, got 0001011A.

1 0

Re: [PATCH] kernel32: Add a stub for SetProcessDEPPolicy
by Marcus Meissner 04 Nov '10

04 Nov '10

On Wed, Nov 03, 2010 at 11:54:33PM +0100, Detlef Riekenberg wrote: > --- > dlls/kernel32/kernel32.spec | 1 + > dlls/kernel32/process.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 8381ae8..f32371e 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec > @@ -1053,6 +1053,7 @@ > @ stdcall SetNamedPipeHandleState(long ptr ptr ptr) > @ stdcall SetPriorityClass(long long) > @ stdcall SetProcessAffinityMask(long long) > +@ stdcall SetProcessDEPPolicy(long) > @ stdcall SetProcessPriorityBoost(long long) > @ stdcall SetProcessShutdownParameters(long long) > @ stdcall SetProcessWorkingSetSize(long long long) > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index fdd19db..86747d9 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -3394,3 +3394,11 @@ DEP_SYSTEM_POLICY_TYPE WINAPI GetSystemDEPPolicy(void) > FIXME("stub\n"); > return OptIn; > } > +/********************************************************************** > + * SetProcessDEPPolicy (KERNEL32.@) > + */ > +BOOL WINAPI SetProcessDEPPolicy(DWORD newDEP) > +{ > + FIXME("(%d): stub\n", newDEP); > + return TRUE; > +} Perhaps return FALSE; and SetLastError(..NOTIMPLEMENTED...) as we did not actually do it. (always better not to lie with security related functions.) Ciao, MArcus

1 0

Re: msvcrt/tests: _itow_s tests (try 3)
by Marvin 04 Nov '10

04 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6779 Your paranoid android. === WVISTAADM (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W2K8SE (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W7PRO (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W7PROX64 (32 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler === W7PROX64 (64 bit string) === string.c:1446: Test failed: expected invalid_parameter_handler string.c:1455: Test failed: expected invalid_parameter_handler string.c:1464: Test failed: expected invalid_parameter_handler string.c:1473: Test failed: expected invalid_parameter_handler string.c:1485: Test failed: expected invalid_parameter_handler string.c:1497: Test failed: expected invalid_parameter_handler string.c:1509: Test failed: expected invalid_parameter_handler

1 0

Re: [2/2] msvcrt/tests: qsort_s implementation and tests (try 3)
by Marvin 04 Nov '10

04 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6778 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

re: First contact
by Dan Kegel 04 Nov '10

04 Nov '10

It's probably your game's copy protection. We can't advise you on circumventing it. The question probably belongs on wine-users, not wine-devel...

1 0

First contact
by Andréas LIVET 03 Nov '10

03 Nov '10

Hi all wine developers, I read this mailing list for about one year I guess but I think I never send a message. Because until this Monday, I was a spectator, now I wanna become an "actor", I want to learn how to hack wine :). I don't have a lot of time, 1 hour/week, maybe more, but I just want to fix some bugs, if I find some, and maybe more in the future. I'll take my time. For info, I'm a video game developers for 2 years, so I'm a C++ programmer, I know nothing about C (except what I know from the C++) and even if I'm using exclusively linux (ubuntu) for 3/4 years at home, I'm not comfortable with the POSIX development environment... Not that I'm a fan of Visual C++/Visual Assist but I always use those tools (at school and then at work) and wanted to learn something else. I decided to start with a game (Paraworld, but it could be anything) which can't load a level : when I hit the start game button, I got the loading screen, the music etc. but nothing append. The mouse is still reacting, the music still playing but nothing is loading. There is nothing in the trace too, so I tried with the "WINEDEBUG=+relay", error!! I ended quickly with a log > 300Mo before seeing the main menu! I've seen that there is a patch which allows user to control when debug trace will be display, but I don't know how to find it. I found this page : http://www.mail-archive.com/wine-devel@winehq.org/msg05542.html But I can't find the archive (the patch file), is there a place where we could download patches? Maybe my question is very simple, but I'm a beginner so be indulgent, please :). Other question, is there a way with winedbg to "pause" program execution without having set any breakpoint. In my case, I don't know where to put the breakpoint so I wanted to break the program execution and see where it ends. This is possible with VCC, maybe it's not with winedbg? Anyway, thank you for your time, and I want to congratulate all the wine developers for their amazing work, win is getting better and better everyday thanks to you, Andréas --Not sent from an iPhone.

3 7

Re: [PATCH] more stubs for mprapi.dll
by Austin English 03 Nov '10

03 Nov '10

On Wed, Nov 3, 2010 at 6:39 PM, <netzimme(a)aim.com> wrote: > [PATCH] more stubs for mprapi.dll The patch is gibberish. Additionally, please include your full real name when submitting patches to wine. -- -Austin

1 0

make crosstest fails for _fseeki64 and _ftelli64
by Eryk Wieliczko 03 Nov '10

03 Nov '10

I am working on a test for _fseeki64 and _ftelli64. brutalcomputer@brutalcomputer-laptop:~/wine-git/dlls/msvcrt/tests$ vim file.c brutalcomputer@brutalcomputer-laptop:~/wine-git/dlls/msvcrt/tests$ make crosstest i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include -I../../../include/msvcrt -I./.. -DWINE_STRICT_PROTOTYPES -DWINE_CROSSTEST -Wall -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o file.cross.o file.c file.c: In function ‘create_io_inherit_block’: file.c:942: warning: dereferencing type-punned pointer will break strict-aliasing rules ../../../tools/winegcc/winegcc -b i586-mingw32msvc -B../../../tools/winebuild --sysroot=../../.. --lib-suffix=.cross.a cpp.cross.o data.cross.o dir.cross.o environ.cross.o file.cross.o headers.cross.o heap.cross.o locale.cross.o misc.cross.o printf.cross.o scanf.cross.o signal.cross.o string.cross.o time.cross.o testlist.cross.o -o msvcrt_crosstest.exe file.cross.o: In function `func_file': /home/brutalcomputer/wine-git/dlls/msvcrt/tests/file.c:1474: undefined reference to `__ftelli64' collect2: ld returned 1 exit status winegcc: i586-mingw32msvc-gcc failed make: *** [msvcrt_crosstest.exe] Error 2 brutalcomputer@brutalcomputer-laptop:~/wine-git/dlls/msvcrt/tests$ of course make test works perfectly. My guess is that mingw doesn't support _ftelli64 and _fseeki64. What should I do in this situation?

1 0

Re: [6/6] msvcr80/tests: _itow_s tests (try 2)
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6768 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [5/6] msvcr80/tests: qsort_s tests (try 2)
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6767 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/6] msvcr80/tests: install test files (try 2)
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6766 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/6] msvcr80: qsort_s implementation (try 2)
by Alexandre Julliard 03 Nov '10

03 Nov '10

"Vincas Miliūnas" <vincas.miliunas(a)gmail.com> writes: > qsort_s and _itow_s implementation and tests for bug #24925. These should go in msvcrt, and the tests in msvcr90. msvcr80 is a simple forwarding dll. -- Alexandre Julliard julliard(a)winehq.org

1 1

Re: [4/4] msxml3: Fix node_get_text() whitespace handling (resend)
by Alexandre Julliard 03 Nov '10

03 Nov '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > @@ -68,6 +68,8 @@ static const WCHAR szBinHex[] = {'b','i','n','.','h','e','x',0}; > > static const IID IID_xmlnode = {0x4f2f4ba2,0xb822,0x11df,{0x8b,0x8a,0x68,0x50,0xdf,0xd7,0x20,0x85}}; > > +BOOL is_preserving_whitespace(xmlNodePtr node); Please put function prototypes in msxml_private.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add IDirect3DRMWinDevice interface (try 2)
by Henri Verbeet 03 Nov '10

03 Nov '10

On 2 November 2010 23:28, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > +#include <d3drm.h> > + > +#include <d3drm.h> I'd expect once to be enough.

1 0

Re: xlive: add initial stub dll (1/3)
by Alexandre Julliard 03 Nov '10

03 Nov '10

Austin English <austinenglish(a)gmail.com> writes: > This dll is not a core part of windows (at least, not yet), but I > think it should be considered for inclusion in Wine. A bit of > explanation is necessary: > > xlive.dll comes from Games for Windows (1,2), whose installer depends > on .Net 3.5 (can be skipped with the /nodotnet parameter). Native > fails on wine, however, unless a native msasn1.dll is provided, > because xlive.dll is digitally signed (so implementing our own > msasn1.dll won't help). As it currently stands, users can't play any > 'Game for Windows' that doesn't have a Windows license. That's not a good enough reason, particularly considering how ugly the resulting code is. And it seems unlikely that this is ever going to move beyond the nasty hack stage, given the lack of documentation. -- Alexandre Julliard julliard(a)winehq.org

5 4

Re: [PATCH 01/14] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)
by Alexandre Julliard 03 Nov '10

03 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > +/* As of today, native and builtin msvcr80, msvcr90, msvcr100 raise an exception on CRT > + * parameter checking on "secure" > + * As Wine forwards most of the APIs of those msvcrNN DLLs to msvcrt, builtin msvcrt does > + * raise an exception on those cases > + * Testing shows that native msvcrt doesn't > + * So we make this test always succeed under Windows > + */ That's not very useful. This should be tested in msvcr90, where we can properly check whether the handler is called. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Implement _get_tzname.
by Dmitry Timoshkov 03 Nov '10

03 Nov '10

Eryk Wieliczko <ewdevel(a)gmail.com> wrote: > -static char tzname_std[64] = ""; > -static char tzname_dst[64] = ""; > +static char tzname_std[64] = "PST"; > +static char tzname_dst[64] = "PDT"; > char *MSVCRT__tzname[2] = { tzname_std, tzname_dst }; ... This is not an implementation, this is a quick and dirty hack. -- Dmitry.

1 0

Re: [6/6] msvcr80/tests: _itow_s tests
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6762 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [5/6] msvcr80/tests: qsort_s tests
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6761 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/6] msvcr80/tests: install test files
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6760 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: ddraw: Exclusive mode is the corner case for SetCooperative, not the normal mode.
by Marvin 03 Nov '10

03 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6757 Your paranoid android. === W98SE (32 bit ddrawmodes) === ddrawmodes: unhandled exception c0000005 at 004122E8 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Use of uninitialized variable in combine_uri()
by Gerald Pfeifer 03 Nov '10

03 Nov '10

Hi Thomas, the following change of yours commit bced2e21dbc548ef9d41e3ff11384d7ad964c929 Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Sat Oct 9 11:02:17 2010 -0400 urlmon: Implemented base case for CoInternetCombineIUri. introduces a new warning, use of uninitialized variable in the line marked "HERE" below. +static HRESULT combine_uri(Uri *base, Uri *relative, DWORD flags, IUri **result + Uri *ret; + HRESULT hr; + parse_data data; + + /* Base case is when the relative Uri has a scheme name, + * if it does, then 'result' will contain the same data + * as the relative Uri. + */ + if(relative->scheme_start > -1) { + DWORD create_flags = 0; + + memset(&data, 0, sizeof(parse_data)); + + data.uri = SysAllocString(relative->raw_uri); + if(!data.uri) { + IUri_Release(URI(ret)); <================== HERE + *result = NULL; + return E_OUTOFMEMORY; + } >From all I can tell this is a legitimate warning, that is, the code really invokes undefined behavior. Would you mind having a look? Gerald

2 1

re: xlive and msasn1.dll
by Dan Kegel 02 Nov '10

02 Nov '10

Austin wrote: > xlive.dll comes from Games for Windows ... [and] > fails on wine, however, unless a native msasn1.dll is provided, > because xlive.dll is digitally signed (so implementing our own > msasn1.dll won't help). That's interesting. I wonder what other modules Microsoft is checking signatures on, and whether they're planning on doing that more often in the future.

2 1

(no subject)
by Matijn Woudt 02 Nov '10

02 Nov '10

1 0

Voting for bugs (Was: Re: [Bug 20969])
by Tom Spear 02 Nov '10

02 Nov '10

Can/should voting for bugs be disabled if it is 'useless and does nothing except adding noise'? Thanks Tom On Tue, Nov 2, 2010 at 12:01 PM, <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=20969 > > --- Comment #19 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-11-02 > 12:01:23 CDT --- > (In reply to comment #18) > > Those of you with this issue, make sure you vote for this in bugzilla so > that > > it can be confirmed, if you haven't already. > > Voting for bugs in Wine bugzilla is useless and does nothing except adding > noise. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. >

1 0

Re: [4/4] msxml3: Implement domdoc schema validation (resend)
by Alexandre Julliard 02 Nov '10

02 Nov '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > dlls/msxml3/domdoc.c | 127 > ++++++++++++++++++++++++++++++++------------ > dlls/msxml3/tests/domdoc.c | 2 +- > 2 files changed, 93 insertions(+), 36 deletions(-) This one breaks on libxml 2.6.16 too: gcc -m32 -c -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -g -O2 -o domdoc.o domdoc.c domdoc.c: In function 'domdoc_validateNode': domdoc.c:2496: error: 'struct _xmlDoc' has no member named 'properties' domdoc.c:2496: error: 'XML_DOC_WELLFORMED' undeclared (first use in this function) domdoc.c:2496: error: (Each undeclared identifier is reported only once domdoc.c:2496: error: for each function it appears in.) make: *** [domdoc.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: xlive: add initial tests, make them pass under Wine
by James Mckenzie 02 Nov '10

02 Nov '10

Austin English <austinenglish(a)gmail.com> wrote: Resend them all. The 'bot' cannot apply just one patch in a series (AJ has pointed this out as well as Ge.) James McKenzie

1 0

Quick Question About GDI
by Aaron Tyler 02 Nov '10

02 Nov '10

Hello, I was searching online to find more info about GDI and I came across your information. Can you tell me, are you still involved with GDI? If you are, how are things going for you? Please let me know. Sincerely, Aaron Tyler

1 0

Re: [PATCH 1/2 resend] urlmon: Added IInternetProtocolEx support to BindProtocol.
by Alexandre Julliard 02 Nov '10

02 Nov '10

Jacek Caban <jacek(a)codeweavers.com> writes: > This patch was previously rejected due to test failure in gameux. The > failure no longer happens for me. It's still failing here: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw/tests: Remove a space before a '\n'.
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6711 Your paranoid android. === W98SE (32 bit ddrawmodes) === ddrawmodes: unhandled exception c0000005 at 004122E8 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH 1/3] include: Add macros for retrieving control message headers (try 2).
by Alexandre Julliard 02 Nov '10

02 Nov '10

Erich Hoover <ehoover(a)mines.edu> writes: > This patch adds the windows version of the macros for retrieving > control message headers (such as IP_PKTINFO control header responses). > This structure is required by later patches in this series in order > to implement IP_PKTINFO. In this version the macros are moved to > ws2def.h and WSA_CMSG_NXTHDR is an actual macro (dependent upon a > couple "custom" macros for clarity), rather than an inline function. Please don't add custom macros that don't exist on Windows, it's not necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw/tests: Fix compilation on systems that don't support nameless unions.
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6710 Your paranoid android. === W98SE (32 bit dsurface) === dsurface: unhandled exception c0000005 at 00415109

1 0

rasphone.exe, rasapi32.dll and rasdlg.dll
by Gerold Jens Wucherpfennig 02 Nov '10

02 Nov '10

Hi, I want to contribute a rasphone.exe, rasapi32.dll and rasdlg.dll to the Wine project :-). The rasphone.exe is already completed, but I have still to do a lot of work for rasapi32.dll and rasdlg.dll. For the RAS-Connection I use wvdial. Right now all my work is coded into the rasphone.exe, but I will change that and use a rasapi32.dll and rasdlg.dll. I will post my code when it's ready... I hope you will all enjoy my work, best regards Gerold Jens Wucherpfennig -- Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail

1 0

Re: xlive: add initial tests, make them pass under Wine (3/3)
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6709 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Unable to regenerate dlls/xlive/Makefile Make failed

1 0

Re: xlive: add initial tests, make them pass under Wine
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6708 Your paranoid android. === WINEBUILD (build) === Patch failed to apply Make failed

2 1

[RFC] cmd: Add a space at the end of the first echo'ed batch line [try5]
by GOUJON Alexandre 02 Nov '10

02 Nov '10

Hi everyone, I'm trying to fix the wine cmd behavior but as this 5th try differs greatly with the previous one, I'd like to have some feedback before submitting it. If you have any question, just let me know. Thanks is advance.

4 5

Re: [5/5] msxml3: Fix node_get_text() whitespace handling
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6694 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

DDRAW: New implementation of SetCooperativeLevel (a new try)
by paulo lesgaz 02 Nov '10

02 Nov '10

Hello, In waiting for my last patch of test for SetCooperativeLevel being accepted, I send to the list my attempt to fix this function. With the attached patch,all the already implemented and all the forecoming tests succeded. I tried to implement Henri's idea about the logic of this function (see http://www.winehq.org/pipermail/wine-devel/2010-August/086201.html ) Any feedback of this patch would be welcomed. Thanks in advance. A+ David

1 0

Re: [4/4] msxml3: Implement domdoc schema validation (resend)
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6691 Your paranoid android. === WINEBUILD (build) === Make of import library failed Make of import library failed

1 0

Re: [3/4] msxml3: Add error code defines (resend)
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6690 Your paranoid android. === WINEBUILD (build) === Make of import library failed Make of import library failed

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try6]
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6689 Your paranoid android. === WNT4WSSP6 (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === W2KPROSP4 (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === WXPPROSP3 (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === W2K3R2SESP2 (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === WVISTAADM (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === W2K8SE (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === W7PRO (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === W7PROX64 (32 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space === W7PROX64 (64 bit batch) === batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space batch.c:173: Test failed: expected space

1 0

Re: ddraw: Add tests for SetCooperativeLevel with a NULL window
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6682 Your paranoid android. === W98SE (32 bit ddrawmodes) === ddrawmodes: unhandled exception c0000005 at 004122E8 === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: [PATCH 1/3] winmm: mciSendString always returns a response string (albeit empty). [resend]
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6679 Your paranoid android. === W98SE (32 bit mci) === mci.c:846: Test failed: Expect message 0001 from play to 250 wait notify mci.c:853: Test failed: got 0004 instead of MCI_NOTIFY_xyz 0000 from command after close

1 0

Re: [PATCH 2/2] hlink: Site data should only be set if the hlink has an HlinkSite
by Marvin 02 Nov '10

02 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6677 Your paranoid android. === W2K8SE (32 bit htmldoc) === htmldoc.c:2241: Test failed: unexpected call UpdateUI htmldoc.c:2466: Test failed: unexpected call Exec_UPDATECOMMANDS

1 0

Re: include: Add new Button control styles
by Nikolay Sivov 01 Nov '10

01 Nov '10

On 11/2/2010 01:45, André Hentschel wrote: > BS_TYPEMASK is already defined some lines above that > --- > include/winuser.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/winuser.h b/include/winuser.h > index 4114756..e04e8ad 100644 > --- a/include/winuser.h > +++ b/include/winuser.h > @@ -712,8 +712,12 @@ typedef struct tagWINDOWPLACEMENT > #define BS_GROUPBOX 0x00000007L > #define BS_USERBUTTON 0x00000008L > #define BS_AUTORADIOBUTTON 0x00000009L > +#define BS_PUSHBOX 0x0000000AL > #define BS_OWNERDRAW 0x0000000BL > -#define BS_TYPEMASK 0x0000000FL > +#define BS_SPLITBUTTON 0x0000000CL > +#define BS_DEFSPLITBUTTON 0x0000000DL > +#define BS_COMMANDLINK 0x0000000EL > +#define BS_DEFCOMMANDLINK 0x0000000FL > #define BS_LEFTTEXT 0x00000020L > #define BS_RIGHTBUTTON BS_LEFTTEXT > New styles should go to commctrl.h, and you can't remove BS_TYPEMASK.

1 0

Re: [PATCH 3/3] winmm: MCI_INFO doesn't change the output buffer in case of error.
by Marvin 01 Nov '10

01 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6668 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W98SE (32 bit mci) === mci.c:835: Test failed: Expect message 0001 from play to 250 wait notify mci.c:842: Test failed: got 0004 instead of MCI_NOTIFY_xyz 0000 from command after close mci.c:903: Test failed: not enough time elapsed 58ms

1 0

Re: [PATCH 2/3] winmm: MCI_SYSINFO doesn't change the output buffer in case of error.
by Marvin 01 Nov '10

01 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6667 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W98SE (32 bit mci) === mci.c:959: Test failed: mci status position: 70 mci.c:1006: Test failed: mci pause wait returned MMSYSERR 5 mci.c:1020: Test failed: mci pause (space) wait returned MMSYSERR 5 mci.c:1023: Test failed: mci pause wait returned MMSYSERR 5 mci.c:1037: Test failed: Expect message 0004 from play (aborted by close)

1 0

Re: [PATCH 1/3] winmm: mciSendString always returns a response string (albeit empty).
by Marvin 01 Nov '10

01 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6666 Your paranoid android. === WINEBUILD (build) === Patch failed to apply === W98SE (32 bit mci) === mci.c:903: Test failed: not enough time elapsed 58ms mci.c:959: Test failed: mci status position: 58 mci.c:1006: Test failed: mci pause wait returned MMSYSERR 5 mci.c:1020: Test failed: mci pause (space) wait returned MMSYSERR 5 mci.c:1023: Test failed: mci pause wait returned MMSYSERR 5 mci.c:1037: Test failed: Expect message 0004 from play (aborted by close)

1 0

Re: Problems with Test
by James Mckenzie 01 Nov '10

01 Nov '10

Charles Davis <cdavis(a)mymail.mines.edu> wrote: > >On 10/31/10 9:23 PM, James McKenzie wrote: >> All: >> >> I'm trying to convert one integer number using a float number factor. >> Here is the code: >> >> int ry = 125; >> double ryf; >> >> ryf = ry/1440; >> >> The result is 0 and should be 0.06666666667 (or even more sixes.) >And why should it be? None of the values in the expression 'ry/1440' are >of type 'double'. They're both 'int's, so the compiler sees it as >integer division instead of FP division. The C language spec doesn't >require the compiler to infer that you wanted FP division when you >assign to a variable of FP type. Ah, the wonders of 'c'. Thank you for the reminder that this is what happens during this division process. Been a long time since I've tried this. > >> What am I doing 'incorrectly'? >Now, if your assignment looked like this: > >ryf = ry/1440.0; > >then it would work correctly. Now the 1440 is of type 'double', so the >compiler emits a floating-point division. > Got it. I tried to cast ry to double, but that did not work. Guess my version of gcc has a problem or I did it wrong. Will try changing the division this evening and see what happens. James McKenzie

2 1

Re: [try 2] crypt32/tests: Add tests for enveloped messages.
by Marvin 01 Nov '10

01 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6658 Your paranoid android. === WNT4WSSP6 (32 bit msg) === msg: unhandled exception c0000005 at 5CF308F4

1 0

[do not apply] Re: crypt32/tests: Add tests for enveloped messages.
by Alexander Morozov 01 Nov '10

01 Nov '10

Please do not apply this patch. Use [try 2]

1 0

Re: [PATCH 2/2] comdlg32/tests: Add GetSaveFileName extension tests.
by Marvin 01 Nov '10

01 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6657 Your paranoid android. === W98SE (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === WNT4WSSP6 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W2KPROSP4 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === WXPPROSP3 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W2K3R2SESP2 (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === WVISTAADM (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W2K8SE (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W7PRO (32 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef === W7PROX64 (32 bit filedlg) === filedlg: unhandled exception c0000005 at 750B4C19 === W7PROX64 (64 bit filedlg) === filedlg.c:1094: Test failed: Filename is beef.txt, expected deadbeef

1 0

Re: [4/4] d3d9: Add a sRGB format test
by Henri Verbeet 01 Nov '10

01 Nov '10

On 1 November 2010 11:41, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > Am 01.11.2010 um 10:41 schrieb Henri Verbeet: > >> On 31 October 2010 22:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >>> + static const struct >>> + { >>> + float x, y, z; >>> + float u, v; >>> + } >>> + quad[] = >>> + { >>> + {-1.0, -1.0, 0.1, 0.0, 0.0}, >>> + {-1.0, 1.0, 0.1, 1.0, 0.0}, >>> + { 1.0, -1.0, 0.1, 0.0, 1.0}, >>> + { 1.0, 1.0, 0.1, 1.0, 1.0} >>> + }; >> Not that I care all that much, but notice that those literals are >> actually doubles. > Now that I've fixed a number of those I guess we should stick to caring about that. You should probably do the Clear()'s too then.

1 0

Re: [PATCH 2/4] include: Add macros for retrieving control message headers.
by Alexandre Julliard 01 Nov '10

01 Nov '10

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -185,6 +185,25 @@ VOID WINAPI GetAcceptExSockaddrs(PVOID, DWORD, DWORD, DWORD, struct WS(sockaddr) > BOOL WINAPI TransmitFile(SOCKET, HANDLE, DWORD, DWORD, LPOVERLAPPED, LPTRANSMIT_FILE_BUFFERS, DWORD); > INT WINAPI WSARecvEx(SOCKET, char *, INT, INT *); > > +/* > + * Macros for retrieving control message data returned by WSARecvMsg() > + */ > +#define WSA_CMSG_DATA(cmsg) ((UCHAR*)((WSACMSGHDR*)(cmsg)+1)) > +#define WSA_CMSG_FIRSTHDR(mhdr) \ > + ((size_t) (mhdr)->Control.len >= sizeof(WSACMSGHDR) \ > + ? (WSACMSGHDR *) (mhdr)->Control.buf : (WSACMSGHDR *) 0) > +#define WSA_CMSG_ALIGN(len) (((len) + sizeof (size_t) - 1) \ > + & (size_t) ~(sizeof (size_t) - 1)) > +static inline WSACMSGHDR *WSA_CMSG_NXTHDR(WSAMSG *msg, WSACMSGHDR *cmsg) > +{ > + if ((size_t)(msg)->Control.len<sizeof(WSACMSGHDR)) return 0; > + cmsg = (WSACMSGHDR*)((unsigned char*)cmsg + WSA_CMSG_ALIGN(cmsg->cmsg_len)); > + if ((unsigned char*)(cmsg+1) > ((unsigned char*)msg->Control.buf + msg->Control.len) > + || ((unsigned char*)cmsg + WSA_CMSG_ALIGN(cmsg->cmsg_len) > ((unsigned char *)msg->Control.buf + msg->Control.len)) ) > + return 0; > + return cmsg; > +} This should go into ws2def.h. Also WSA_CMSG_NXTHDR is supposed to be a macro, not an inline function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] d3d9: Add a sRGB format test
by Henri Verbeet 01 Nov '10

01 Nov '10

On 31 October 2010 22:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + static const struct > + { > + float x, y, z; > + float u, v; > + } > + quad[] = > + { > + {-1.0, -1.0, 0.1, 0.0, 0.0}, > + {-1.0, 1.0, 0.1, 1.0, 0.0}, > + { 1.0, -1.0, 0.1, 0.0, 1.0}, > + { 1.0, 1.0, 0.1, 1.0, 1.0} > + }; Not that I care all that much, but notice that those literals are actually doubles. > + hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_TRIANGLESTRIP, 2, quad, sizeof(float) * 5); Now that you're using a proper structure for "quad", "sizeof(float) * 5" is really just the same as "sizeof(*quad)".

1 0

Problems with Test
by James McKenzie 01 Nov '10

01 Nov '10

All: I'm trying to convert one integer number using a float number factor. Here is the code: int ry = 125; double ryf; ryf = ry/1440; The result is 0 and should be 0.06666666667 (or even more sixes.) BTW, if I change ry to 1440 the result is 1.00000. What am I doing 'incorrectly'? James McKenzie

2 1

Re: [PATCH 4/4] ws2_32/tests: Add regression tests for WSARecvMsg and IP_PKTINFO.
by testbot＠testbot.winehq.org 31 Oct '10

31 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6625 Your paranoid android. === W7PROX64 (64 bit sock) === sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20). sock.c:1175: Test failed: WSARecvMsg() failed error: 10014 sock.c:1186: Test failed: WSARecvMsg() failed error: 10040 (flags: 512) sock.c:1237: Test failed: WSARecvMsg() control length mismatch (24 != 20).

1 0

up for a quick challenge? "Test Drive Unlimited 2" open beta this weekend only...
by Dan Kegel 31 Oct '10

31 Oct '10

and installs ok with dotnet20... but it's stuck on "Checking files, please wait". http://appdb.winehq.org/objectManager.php?sClass=version&iId=21811 http://en.wikipedia.org/wiki/Test_Drive_Unlimited_2 (Wikipedia says it will require .net 3.5, ugh.) While it's sitting, it outputs stuff like fixme:thread:NtQueryInformationThread info class 16 not supported yet fixme:ole:Context_CC_ContextCallback (0x4956060/0x4956064)->(0x79f277a5, 0x2a7e4e8, {d7174f82-36b8-4aa8-800a-e963ab2dfab9}, 2, (nil)) fixme:thread:NtQueryInformationThread info class 16 not supported yet I guess the next step is to look at the packets on the wire on windows and see if it's getting stuck trying to phone home...

1 0

Re: comctl32/treeview: Make item data layout partially compatible with native one
by testbot＠testbot.winehq.org 31 Oct '10

31 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6609 Your paranoid android. === WNT4WSSP6 (32 bit treeview) === No test summary line found === W2KPROSP4 (32 bit treeview) === No test summary line found

1 0

Purist keyword?
by Austin English 31 Oct '10

31 Oct '10

I see quite a few people filing bugs that are only exposed when bundled native dlls are removed. I think it would be good to be able to group these bugs, perhaps with a 'purist' keyword. Anyone opposed?

5 6

RFC: quartz: Don't block indefinitely when pausing after end of stream
by Vladimir Panteleev 31 Oct '10

31 Oct '10

The attached patch attempts to fix http://bugs.winehq.org/show_bug.cgi?id=24869 , but due to my limited knowledge of DirectShow I'm not certain about its correctness. Can anyone point out if there's anything wrong with it?

1 0

Re: Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken.
by Vitaliy Margolen 31 Oct '10

31 Oct '10

On 10/30/2010 06:12 AM, Sami Aario wrote: > Added TokenOwner and TokenPrimaryGroup cases to NtSetInformationToken. > > From: Sami Aario <saempy(a)hima.(none)> Your e-mail isn't set correctly in git configuration. > dlls/ntdll/nt.c | 63 ++++++++++++++++++++++++++++++++++++++++ > include/wine/server_protocol.h | 18 +++++++++++- > server/protocol.def | 6 ++++ > server/request.h | 5 +++ > server/token.c | 36 +++++++++++++++++++++++ > server/trace.c | 10 ++++++ Please don't include changes to automatically generated files (server_protocol.h, request.h, trace.c). > + SERVER_START_REQ( set_token_sid ) > + { > + SID *sid = ((TOKEN_OWNER *)TokenInformation)->Owner; > + WORD size; > + > + if (sid) size = RtlLengthRequiredSid(sid->SubAuthorityCount); > + else size = 0; > + > + TRACE("size=%d\n", size); > + > + req->handle = wine_server_obj_handle( TokenHandle ); > + req->which_sid = TokenInformationClass; > + wine_server_add_data( req, sid, size ); > + ret = wine_server_call( req ); > + } > + SERVER_END_REQ; Please get everything outside of SERVER_START_REQ()/SERVER_END_REQ except actual wine_server function calls and handling of returned result(s). Some functions can do their own server calls and you will have a deadlock. > + case TokenOwner: > + free( token->user ); > + token->user = NULL; > + > + if (sid_len) > + token->user = memdup( sid, sid_len ); > + break; This is wrong, you can't clear token user - it always have to be set, or you risking an assert in get_token_sid. Which means you have to validate the data user passes in. Vitaliy.

1 0

re: Purist keyword?
by Dan Kegel 30 Oct '10

30 Oct '10

The keyword might be useful for a pragmatist looking for bugs to fix, who didn't want to fix bugs masked by a bundled native DLL. I don't know how many such people there are, though. Best to wait until somebody says they need the keyword before we add it... until then, we can just use the word 'purist' in the body of the bug as we've started doing.

1 0

re: WINE Performance and Evernote 4.0 Windows Client
by Dan Kegel 30 Oct '10

30 Oct '10

Hi Martin, > http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks for letting us know. Looking at that thread, your message, and the appdb entry http://appdb.winehq.org/objectManager.php?sClass=version&iId=21775 it looks like people are reporting four or so problems: - autoupdate doesn't work - pdf preview hangs or is slow - switching notebooks is slow - clicking on menu is slow It would probably help to have Wine bug reports at http://bugs.winehq.org for each individual problem, with clear instructions for non-Evernote users on how to reproduce them. (I'd file a couple myself, but I don't have time to experiment at the moment.) - Dan

1 0

ddraw [try 3]: Add tests for the foreground window set by SetCooperativeLevel
by David Adam 30 Oct '10

30 Oct '10

Any problem with this patch? A+ David

1 0

WINE Performance and Evernote 4.0 Windows Client
by Martin Packer 30 Oct '10

30 Oct '10

Evernote are in the process of releasing 4.0 of their Windows client. This is completely rewritten to avoid the use of things that would stop it running under WINE. (This WASN'T their target - it was more about device drivers that had been problematic.) It runs reasonably well on the latest WINE. However it runs slowly (in a way it doesn't under "real" Windows) and also the autoupdater doesn't seem to work. Is anyone here willing to work with them and us to help it run faster? (I haven't got commitment from Evernote to make changes but I have got their attention now.) :-) Hopefully you can see this thread on the Evernote bulletin board: http://forum.evernote.com/phpbb/viewtopic.php?f=56&t=18674 Thanks, Martin Martin Packer, Mainframe Performance Consultant, zChampion Worldwide Banking Center of Excellence, IBM +44-7802-245-584 email: martin_packer(a)uk.ibm.com Twitter / Facebook IDs: MartinPacker Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

1 0

Linux kernel and game performance?
by Dan Kegel 29 Oct '10

29 Oct '10

Hey folks, I've run into two web sites that claim that the Linux kernel causes performance problems in particular games (see below). Anybody know of others? And has anybody found concrete improvements in performance of a particular app (other than an audio workstation app) from using a realtime kernel? Thanks! - Dan First: http://wiki.archlinux.org/index.php/World_of_Warcraft#Kernel_Timing_Bug says in a section dated September 2008: "If you are having problems with choppy video every 15 seconds or so, it is related to the kernel scheduler... to fix, add CONFIG_SCHED_DEBUG=y to your kernel config, then set kernel.sched_features=21 kernel.sched_batch_wakeup_granularity_ns=25000000 kernel.sched_min_granularity_ns=4000000 in /etc/sysctl.cfg." Yikes. Any truth to that rumor? Second: http://hisouten.koumakan.jp/wiki/Linux_support#Resolved_bugs says "The game runs too slowly Symptoms: Instead of running at about 60-62fps, like the game is supposed to, it'll run closer to 53fps. This is not ideal. The bug: This is a Linux timing issue. The game runs a secondary timing thread with THREAD_PRIORITY_TIME_CRITICAL, where it simply sleeps for 16ms and sends events to the main thread to tell it that a new frame is needed. On Linux the necessary timing accuracy is not available, so it wavers between 16ms and 20ms. The fix: I hacked around this by setting the timer period to 14ms. This leads to a steady 62-63fps. Which is close enough for use, really. For a constant 60fps turn on vsync in your video drivers."

4 5

Re: Windows Installer change in behaviour Wine 1.3.5.
by James Mckenzie 29 Oct '10

29 Oct '10

Damian Dixon <damian.dixon(a)gmail.com> wrote: {Please send replies only to the Wine Devel mailing list.} > >I have installed my application under Wine 1.3.5 however with this version >of Wine the registry is not updated by the installer. Name of application, Linux distribution please. Also please file a bug report, if one does not exist. > >The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as >it has worked before with older versions of Wine. > Looks like a regression to me. However, 1.3.6 is about to be released (maybe today.) Would have been great to catch this. James McKenzie

1 0

Re: [3/3] gdi32: Make AddFontToList return a pointer to first loaded face.
by Alexandre Julliard 29 Oct '10

29 Oct '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 35 ++++++++++++++++++++--------------- > 1 files changed, 20 insertions(+), 15 deletions(-) You are lucky, it turns out that I screwed up and committed your original patch by mistake ;-) But I still don't see why you are returning that pointer, could you please send the code that makes use of this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Crash bug in Wine 1.3.5 in advapi32/service.c
by Damian Dixon 29 Oct '10

29 Oct '10

Hi, In file dlls/advapi32/service.c, line 1135 a memory copy occurs, however the lpservicestatus is not checked to see if the value is NULL. This causes a crash in an application that has worked before under wine. My naive change is: if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcStatusData, sizeof(SERVICE_STATUS)) ; Regards Damian

2 1

Windows Installer change in behaviour Wine 1.3.5.
by Damian Dixon 29 Oct '10

29 Oct '10

Hi, I have installed my application under Wine 1.3.5 however with this version of Wine the registry is not updated by the installer. The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as it has worked before with older versions of Wine. I've not had the time to investigate but thought someone my be interested. Regards Damian

1 0

Re: [4/5] msxml3: Add XSLPattern nodeType() method
by testbot＠testbot.winehq.org 29 Oct '10

29 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6591 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === WVISTAADM (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PRO (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PROX64 (32 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1 === W7PROX64 (64 bit domdoc) === domdoc.c:6733: Test failed: Invalid node list: C2.E3.E3.D1, expected T3.E3.E3.D1

1 0

Re: [5/5] msxml3: Implement XSLPattern collection methods
by Alexandre Julliard 29 Oct '10

29 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > From d7dfd1e50a295c9bae15f83ed418cfa5f0890d58 Mon Sep 17 00:00:00 2001 > From: Adam Martinson <amartinson(a)codeweavers.com> > Date: Thu, 28 Oct 2010 20:22:22 -0500 > Subject: [PATCH 8/8] msxml3: Implement XSLPattern collection methods > To: wine-patches <wine-patches(a)winehq.org> This one causes some scary warnings: bison -p xslpattern_ -o xslpattern.tab.c -d xslpattern.y xslpattern.y: conflicts: 14 shift/reduce, 42 reduce/reduce xslpattern.y:298.31-42: warning: rule useless in parser due to conflicts: PrimaryExpr: FunctionCall -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] include: Better distinguish ARM's endianess
by Paul Chitescu 29 Oct '10

29 Oct '10

On Friday 29 October 2010 05:34:31 pm André Hentschel wrote: > --- > include/basetsd.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index 6ce0102..aa6e86d 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -291,7 +291,11 @@ typedef ULONG_PTR KAFFINITY, *PKAFFINITY; > # undef WORDS_BIGENDIAN > # undef BITFIELDS_BIGENDIAN > # undef ALLOW_UNALIGNED_ACCESS > -#elif defined(__arm__) > +#elif defined(__ARMEB__) > +# define WORDS_BIGENDIAN > +# define BITFIELDS_BIGENDIAN > +# undef ALLOW_UNALIGNED_ACCESS > +#elif defined(__ARMEL__) > # undef WORDS_BIGENDIAN > # undef BITFIELDS_BIGENDIAN > # undef ALLOW_UNALIGNED_ACCESS Not relevant just here but please note that in little endian ARM the hardware coprocessor compatible double type is cross endian (octets are: 5 6 7 8=MSB 1=LSB 2 3 4) while big endian is normal (8=MSB 7 6 5 4 3 2 1=LSB). The processor swaps octets in the 32 bit halves of the type but not the halves themselves. On Linuxes compiled for FP emulator the above octet order is used. If soft floats are used the usual little endian is used on doubles too. Not sure what the WinCE ABI does.

1 0

Re: [PATCH 2/3] wer: Add stubs for WerReportCreate + WerReportCloseHandle
by Alexandre Julliard 29 Oct '10

29 Oct '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -2,6 +2,7 @@ MODULE = wer.dll > IMPORTLIB = wer > > C_SRCS = \ > - main.c > + main.c \ > + report.c I don't think we need multiple source files at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] msxml3: Add error code definitions (resend)
by testbot＠testbot.winehq.org 29 Oct '10

29 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6586 Your paranoid android. === WVISTAADM (32 bit domdoc) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.
by Greg Geldorp 29 Oct '10

29 Oct '10

Hi Chip, > From: Charles Davis > > On 10/27/10 8:43 PM, (Marvin) wrote: > > === WINEBUILD (build) === > > Failure running script in VM: Exceeded timeout limit of 300 sec > > Huh? I've never seen that happen before. I can't tell why my patch would > cause this. Ge? Your thoughts? Your patch contained a change to the configure script. Because of that, the bot rebuilt a lot of stuff. Rebuilding a lot of stuff takes time and caused the timeout limit to be exceeded. I've adjusted the build script to handle changes to configure better. Greg.

1 0

Re: [1/3] msxml3: Add a function to validate a tree against a schema cache (try 2)
by Nikolay Sivov 29 Oct '10

29 Oct '10

On 10/29/2010 10:27, Adam Martinson wrote: > + #if LIBXML_VERSION>= 20621 > + xmlSchemaSetValidStructuredErrors(svctx, validate_serror, NULL); > + #endif I think a common and preferable way is to add configure define and check for presence of this call.

1 0

Re: advapi32: Implement EnumServicesStatusExA/W.
by testbot＠testbot.winehq.org 29 Oct '10

29 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6585 Your paranoid android. === WINEBUILD (build) === Performing reconfig in include dir Making build dependencies Making test executable Performing reconfig in include dir Making build dependencies Making test executable

1 0

Re: [PATCH] kernel32/tests: Fix the mixed-case short path test to actually test something.
by testbot＠testbot.winehq.org 29 Oct '10

29 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6579 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

1 0

Re: [1/4] msxml3/tests: Some encoding switching tests
by testbot＠testbot.winehq.org 29 Oct '10

29 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6578 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

2 1

Re: [PATCH 3/3] wer/tests: Add initial tests for WerReportCreate + WerReportCloseHandle
by testbot＠testbot.winehq.org 29 Oct '10

29 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6575 Your paranoid android. === WINEBUILD (build) === Rebuilding wer import lib Performing tests reconfig Making build dependencies Making test executable Rebuilding wer import lib Performing tests reconfig Making build dependencies Making test executable

1 0

Re: [2/4] msxml3: add a function to validate a tree against a schema cache (resend)
by Alexandre Julliard 28 Oct '10

28 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > dlls/msxml3/msxml_private.h | 1 + > dlls/msxml3/schema.c | 75 > +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 76 insertions(+), 0 deletions(-) This doesn't build on Leopard (libxml 2.6.16): ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./msxml3.spec attribute.o bsc.o cdata.o comment.o dispex.o docfrag.o domdoc.o domimpl.o element.o entityref.o factory.o httprequest.o main.o node.o nodelist.o nodemap.o parseerror.o pi.o queryresult.o regsvr.o saxreader.o schema.o text.o uuid.o xmldoc.o xmlelem.o xslpattern.tab.o xslpattern.yy.o version.res -o msxml3.dll.so -luuid -lurlmon -lshlwapi -loleaut32 -lole32 -luser32 -ladvapi32 ../../libs/port/libwine_port.a -L/usr/lib -lxml2 -lz -lpthread -licucore -lm Undefined symbols: "_xmlSchemaSetValidStructuredErrors", referenced from: _SchemaCache_validate_tree in schema.o ld: symbol(s) not found -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: usp10/tests: update test_ScriptStringXtoCP_CPtoX to test both rtl and ltr characters
by testbot＠testbot.winehq.org 28 Oct '10

28 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6574 Your paranoid android. === WINEBUILD (build) === Making test executable Making test executable

1 0

Sane.ds units
by Yaron Shahrabani 28 Oct '10

28 Oct '10

Can someone please explain the units in the twain module (sane.ds)? There are: px - pixels b - ? (bytes) dpi - dots per inch mm - milimeters % - percent ns - ? (nanosecond) I will add comments to the file so it will be clearer for other translators, thanks! Yaron Shahrabani <Hebrew translator>

2 2

Re: (resend)[3/4]winegstreamer: add gstreamer mp3 transform filter
by Alexandre Julliard 28 Oct '10

28 Oct '10

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/winegstreamer/gst_guids.h | 1 + > dlls/winegstreamer/gst_private.h | 1 + > dlls/winegstreamer/gsttffilter.c | 125 > ++++++++++++++++++++++++++++++++++++++ > dlls/winegstreamer/main.c | 35 +++++++++++ > 4 files changed, 162 insertions(+), 0 deletions(-) It doesn't work here: ../../../../wine/tools/runtest -q -P wine -M qedit.dll -T ../../.. -p qedit_test.exe.so ../../../../wine/dlls/qedit/tests/mediadet.c && touch mediadet.ok mediadet.c:151: Test failed: IMediaDet_put_Filename -> 80040207 mediadet.c:162: Test failed: IMediaDet_get_StreamMediaType mediadet.c:214: Test failed: IMediaDet_get_StreamMediaType mediadet.c:222: Test failed: IMediaDet_get_FrameRate mediadet.c:223: Test failed: IMediaDet_get_FrameRate mediadet.c:238: Test failed: IMediaDet_put_Filename -> 80040207 mediadet.c:243: Test failed: IMediaDet_get_OutputStreams mediadet.c:259: Test failed: IMediaDet_put_CurrentStream mediadet.c:264: Test failed: IMediaDet_get_CurrentStream mediadet.c:283: Test failed: IMediaDet_get_StreamMediaType mediadet.c:291: Test failed: IMediaDet_get_CurrentStream make: *** [mediadet.ok] Error 11 -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel