- wine-devel - winehq.org

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.
by testbot＠testbot.winehq.org 28 Oct '10

28 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6562 Your paranoid android. === WINEBUILD (build) === Failure running script in VM: Exceeded timeout limit of 300 sec

2 1

RE: [1/3] mscoree: Add tests for LoadLibraryShim.
by Vincent Povirk 27 Oct '10

27 Oct '10

Well, in practice, it's a detail that I don't expect to be very important, so it's probably not worth the trouble. Mostly I just want to elminiate the call fusion makes back into mscoree, since it is so blatantly wrong and causes the change I really want to break the tests. We could probably even get away with a hard-coded path, since our ngen.exe doesn't work anyway, and that's essentially what we're doing now given the semi-stub status of GetCORVersion. If/when we need to use the CLR version in fusion for something other than finding the precompiled assembly cache, this may become more important, but even then I don't think we'll need multiple simultaneous instances to work properly. We'll just need to know the correct version to use when only one instance is loaded. Multiple simultaneous runtimes is a case I'm thinking about and trying to account for, but I don't expect to ever see it used. If you prefer, I can add a test for fusion instead that compares the version we get out of GetCachePath(ASM_CACHE_ZAP) to the one we pass to LoadLibraryShim, in cases where more than one runtime is installed, assuming only one instance will be loaded at once. I can fix that without any changes to the loader, but it will mean adding a wine-specific export to fusion. OR mscoree could lie about which .NET versions are installed when Mono isn't available, until there's a real need to load Mono. -----Original Message----- From: Alexandre Julliard [mailto:julliard@winehq.org] Sent: Wednesday, October 27, 2010 2:15 PM To: Vincent Povirk Cc: WineHQ Development Mailing List Subject: Re: [1/3] mscoree: Add tests for LoadLibraryShim. "Vincent Povirk" <vincent(a)codeweavers.com> writes: > There is another minor problem highlighted by this test, which is that > I can make up any path and end up with a loaded dll, as long as > there's a builtin dll filename at the end. That's a feature, the idea is that builtin dlls are independent from the actual dll files. That's also why asking for the path name of a builtin doesn't make sense. This could conceivably be changed now that we have the fake dlls mechanism, but it would be a pretty fundamental redesign. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: [1/3] mscoree: Add tests for LoadLibraryShim.
by Vincent Povirk 27 Oct '10

27 Oct '10

Well, I don't think we can do it properly without having multiple instances of a builtin dll. I believe that native fusion.dll is different for each .NET version, and it probably has the version number baked in. If we can't have multiple instances of a builtin dll, I still believe testing the path is the best way to determine which version was given to LoadLibraryShim, if that's possible. If testing the path is not possible, we can have LoadLibraryShim use a wine-specific exported function to inform fusion.dll of the version, but this approach won't work if someone loads fusion.dll directly from a .NET system directory. There is another minor problem highlighted by this test, which is that I can make up any path and end up with a loaded dll, as long as there's a builtin dll filename at the end. -----Original Message----- From: Alexandre Julliard [mailto:julliard@winehq.org] Sent: Wednesday, October 27, 2010 1:31 PM To: Vincent Povirk Cc: WineHQ Development Mailing List Subject: Re: [1/3] mscoree: Add tests for LoadLibraryShim. "Vincent Povirk" <vincent(a)codeweavers.com> writes: > This is needed so that fusion.dll can find out which .NET version it's > expected to use without loading mscoree.dll. Native has the capability > of loading multiple .NET versions in a single process, so the current > approach is unworkable. Testing the filename doesn't seem much more workable, you can't load multiple instances of a builtin dll anyway. How are you planning to handle this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] mscoree: Add tests for LoadLibraryShim.
by Alexandre Julliard 27 Oct '10

27 Oct '10

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This is needed so that fusion.dll can find out which .NET version it's > expected to use without loading mscoree.dll. Native has the capability > of loading multiple .NET versions in a single process, so the current > approach is unworkable. Testing the filename doesn't seem much more workable, you can't load multiple instances of a builtin dll anyway. How are you planning to handle this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (resend try 4)
by Alexandre Julliard 27 Oct '10

27 Oct '10

Charles Davis <cdavis(a)mymail.mines.edu> writes: > If the volume is indeed case insensitive, we skip searching through the > whole directory ourselves, and just stat() each portion of the path. You still have extra stat() calls in the fast path, as well as some unnecessary changes. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [3/3] mscoree: Implement LoadLibraryShim.
by testbot＠testbot.winehq.org 27 Oct '10

27 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6541 Your paranoid android. === W2K3R2SESP2 (32 bit mscoree) === mscoree.c:176: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === WVISTAADM (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W2K8SE (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W7PRO (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (64 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL"

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes. (try 4)
by Charles Davis 27 Oct '10

27 Oct '10

Any concerns? I've gone over this patch, and I don't see anything major. If it will make you feel any better, I just ran the tests under a WoW64 environment on Linux, and they passed. Chip

2 2

Re: [1/3] mscoree: Add tests for LoadLibraryShim.
by testbot＠testbot.winehq.org 27 Oct '10

27 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6540 Your paranoid android. === W2K3R2SESP2 (32 bit mscoree) === mscoree.c:176: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === WVISTAADM (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W2K8SE (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 === W7PRO (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (32 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework\\v2.0.50727\\fusion.DLL" === W7PROX64 (64 bit mscoree) === mscoree.c:162: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:184: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL" mscoree.c:190: Test failed: LoadLibraryShim failed, hr=80070006 mscoree.c:213: Test failed: incorrect fusion.dll path L"C:\\Windows\\Microsoft.NET\\Framework64\\v2.0.50727\\fusion.DLL"

1 0

Re: [PATCH] [Server]: fix access rights for console creation (#24792)
by Alexandre Julliard 27 Oct '10

27 Oct '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > + if (access & GENERIC_READ) access |= FILE_GENERIC_READ; > + /* FIXME: we add FILE_READ_PROPERTIES access even in write-only mode. > + * As tested on Windows, this is not correct (ie GetConsoleMode() on with GENERIC_WRITE only > + * access fails). > + * But, this is currently needed as part of kernel32/console.c client side code relies on the > + * fact that it can read properties: lots of 'set' functions like WriteConsole, > + * ScrollConsoleScreenBuffer, SetConsoleCursorPosition (and many others) do call 'get' > + * functions. > + */ These should be fixed then. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] gdi32: Make AddFontToList skip adding a face into global lists if the font is not supposed to be enumerated, and return a pointer to first loaded face.
by Alexandre Julliard 27 Oct '10

27 Oct '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1207,15 +1207,17 @@ static void AddFaceToFamily(Face *face, Family *family) > > #define ADDFONT_EXTERNAL_FONT 0x01 > #define ADDFONT_FORCE_BITMAP 0x02 > -static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, char *fake_family, const WCHAR *target_family, DWORD flags) > +#define ADDFONT_HIDDEN 0x04 > +static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_size, > + char *fake_family, const WCHAR *target_family, DWORD flags, Face **face_to_return) The face_to_return pointer doesn't seem to be used anywhere. If it's really needed for something else it should be a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: First contact
by Dan Kegel 26 Oct '10

26 Oct '10

On Tue, Oct 26, 2010 at 10:58 PM, Andréas LIVET <andreas.livet at gmail.com> wrote: > For the patch, I think I understand the concept (I never use git before and > never apply a patch), I have to selection the diff text and save it into a > file (let's say debug.patch) Copy and paste sometimes screws up patches. Better to save the patch to a file some other way. In particular, I usually use wget. For the patch you mentioned, one command to fetch the patch is wget http://repo.or.cz/w/wine/hacks.git/patch/2daf55e8eeca89d5c2bb82381151277b6f… http://marc.info/?l=wine-patches is another good place to search for uncommitted patches; that site does a good job of saving the patches as hyperlinks you can use with wget. See also http://kegel.com/academy/opensource.html and http://kegel.com/wine/qa/ for a few tips. Welcome aboard. I hope you have more than 1 hour / week, it takes a while to come up the learning curve. - Dan

1 0

Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
by Alexandre Julliard 26 Oct '10

26 Oct '10

David Adam <david.adam.cnrs(a)gmail.com> writes: > @@ -33,8 +33,9 @@ static LPDIRECTDRAW lpDD = NULL; > static LPDIRECTDRAWSURFACE lpDDSPrimary = NULL; > static LPDIRECTDRAWSURFACE lpDDSBack = NULL; > static WNDCLASS wc; > -static HWND hwnd; > +static HWND hwnd, hwnd2; > static int modes_cnt; > +static BOOL success; That boolean make much sense, especially with this name. If you want to check that you have a valid window you should test the window handle. Same with your createwindow function, it should simply return the handle. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] msxml3: libxml2 error/warning callback functions (try 2)
by Alexandre Julliard 26 Oct '10

26 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > + len = vsnprintf(NULL, 0, msg, ap); > + buf = heap_alloc(len+1); > + vsnprintf(buf, len+1, msg, ap); vsnprintf can also return -1, check how this is done in other places. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Alexandre Julliard 26 Oct '10

26 Oct '10

Aric Stewart <aric(a)codeweavers.com> writes: > + ERR("++++++++++++++++ perform byte seek ------------------\n"); You still have a ton of such debug ERRs in there. > + *buf = NULL; > + TRACE("Requesting %llu %u\n", ofs, len); Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] kernel32: Export recent wer functions
by Alexandre Julliard 26 Oct '10

26 Oct '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1156,7 +1156,20 @@ > @ stdcall WaitForSingleObjectEx(long long long) > @ stdcall WaitNamedPipeA (str long) > @ stdcall WaitNamedPipeW (wstr long) > +@ stub WerGetFlags > @ stdcall WerRegisterFile(wstr long long) > +@ stub WerRegisterMemoryBlock > +@ stub WerRegisterRuntimeExceptionModule > +@ stub WerSetFlags > +@ stub WerUnregisterFile > +@ stub WerUnregisterMemoryBlock > +@ stub WerUnregisterRuntimeExceptionModule > +@ stub WerpCleanupMessageMapping > +@ stub WerpInitiateRemoteRecovery > +@ stub WerpNotifyLoadStringResource > +@ stub WerpNotifyLoadStringResourceEx > +@ stub WerpNotifyUseStringResource > +@ stub WerpStringLookup Adding stubs is not a good idea. If you have an app that calls these you need to provide a proper stub function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] wer/tests: Add initial tests
by testbot＠testbot.winehq.org 26 Oct '10

26 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6514 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: comdlg32: Added Hebrew translation.
by Yaron Shahrabani 26 Oct '10

26 Oct '10

What is wrong with the patch? Yaron Shahrabani <Hebrew translator> 2010/10/23 Yaron Shahrabani <sh.yaron(a)gmail.com> > Verified by Paul Vriens >

2 1

ddraw: Add tests for the foreground window set by SetCooperativeLevel
by David Adam 26 Oct '10

26 Oct '10

Any problems with patch? A+ David ---------- Forwarded message ---------- From: David Adam <david.adam.cnrs(a)gmail.com> Date: 2010/10/24 Subject: ddraw: Add tests for the foreground window set by SetCooperativeLevel To: wine-patches <wine-patches(a)winehq.org>

2 2

comdlg32/cdlg: removed 16 bit dependency
by CJ 26 Oct '10

26 Oct '10

Removed wownt32.h from the includes of cdlg32.h and modified fontdlg.c so that it no longer relies on the 16 bit dependency. -- Carl J. Raffaele

2 1

Re: msxml3/domdoc: Handle passed BSTR argument as a WCHAR string in ::createProcessingInstruction()
by Jacek Caban 25 Oct '10

25 Oct '10

On 10/25/10 10:38 PM, Nikolay Sivov wrote: > Should help with http://bugs.winehq.org/show_bug.cgi?id=22607 > > > + V_VT(&v) = VT_BSTR; + V_BSTR(&v) = SysAllocString(data); - hr = node_put_value(node_obj,&v_data); Allocating a string only because it's needed for VariantChangeType (back to the string) seems like a bad design. How about moving xmlNodeSetContent call (and supporting xmlChar_from_wchar) to separated function (node_set_content?) from node_put_value and call it directly here? Jacek

2 1

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter
by Vitaliy Margolen 25 Oct '10

25 Oct '10

On 10/25/2010 07:45 AM, Aric Stewart wrote: > --- > + ERR("++++++++++++++++ perform byte seek ------------------\n"); > + if (1 || This->initial) { > + ERR("Relinked\n"); > + FIXME("Seeking %i %i\n", format, GST_FORMAT_BYTES); > + FIXME("using \"%s\"\n", name); Some debug leftovers? > + AM_MEDIA_TYPE amt = { }; > .. > + ZeroMemory(&amt, sizeof(amt)); This is redundant. > sizeof(piOutput.achName) / sizeof(*piOutput.achName) The more common construct in Wine is sizeof(array)/sizeof(array[0]). IMHO it's better to stick with one Also could you please put an empty line in each function after variable declarations? Your patches look inconsistent. Vitaliy.

2 1

Re: explorer: Create a standalone tray window wrapper if the driver doesn't provide native implementation. Take 2.
by Alexandre Julliard 25 Oct '10

25 Oct '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch makes sure that "Shell_TrayWnd" window doesn't have a caption > since some apps depend on it being empty. The bug #20129 lists one of such > applications. It does FindWindow("Shell_TrayWnd", "") and expects that it > returns a valid tray window handle. This looks ugly when moving the window. The real systray should most likely be kept off-screen. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] [Server]: fix access rights for console creation (#24792)
by Alexandre Julliard 25 Oct '10

25 Oct '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > server/console.c | 15 +++++++++++++-- > 1 files changed, 13 insertions(+), 2 deletions(-) It's not correct: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so console.c && touch console.ok console.c:789: Test failed: Shouldn't succeed console.c:790: Test failed: GetLastError: expecting 6 got 0 make: *** [console.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] wininet: added one missing buffersize check in URLCache_CopyEntry (Coverity)
by Alexandre Julliard 25 Oct '10

25 Oct '10

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > CID 831, indirectly spotted by Coverity, one missing > check for (*lpdwBufferSize >= dwRequiredSize) added. It doesn't work: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so urlcache.c && touch urlcache.ok urlcache.c:219: Test failed: RetrieveUrlCacheEntryFile failed with error 122 wine: Unhandled page fault on read access to 0x00000000 at address 0x6820cb08 (thread 0028), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] [Kernel32]: don't force winedbg startup when no AeDebug key is present (#24524)
by Alexandre Julliard 25 Oct '10

25 Oct '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > - cmdline = HeapAlloc(GetProcessHeap(), 0, 80); > - snprintf(cmdline, 80, "winedbg --auto %ld %ld", /* as in tools/wine.inf */ > - (long)GetCurrentProcessId(), (long)HandleToLong(hEvent)); > + /* no AeDebug key present, just kill the program */ > + return FALSE; This means you don't get a backtrace if there's a crash before the initial registry creation is complete. I don't think that's a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] [Msvcrt]: put in place the full scheme for paramter validation (the _s family of functions)
by Piotr Caban 24 Oct '10

24 Oct '10

Hi, Only debugging version of the dll is passing data to invalid_paramter_handler. I guess it's why we shouldn't do it. There already is a test for it in msvcr90 (see strtoi64 tests). Because it was not strict enough it will not show it very well. Currently it will not show that it was expecting invalid_parameter_handler to be invoked (but will fail checking errno that should not be changed). Of course this behavior may vary between msvcrXX dlls, I have tested it only with msvcr90 and msvcrt on Windows XP. Cheers, Piotr

1 0

Re: [3/4] ddraw: fix DDSCAPS_3DDEVICE surfaces always setting DDSCAPS_VISIBLE
by testbot＠testbot.winehq.org 24 Oct '10

24 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6460 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [2/4] ddraw/tests: test some more caps combinations
by testbot＠testbot.winehq.org 24 Oct '10

24 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6459 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

re: disabling FORTIFY_SOURCE
by Dan Kegel 24 Oct '10

24 Oct '10

Hi Kees, sure, supporting Fortify in Wine would be great, but it's not clear how long it will take to fix Wine so it works with Fortify. Which would you prefer: 1) have Wine broken for an unknown and possibly long time or 2) have Wine working, but without Fortify, until the bugs are fixed ?

5 6

Test for window messages of a property sheet with custom dialog proc (bug 12104)
by Bernhard Übelacker 24 Oct '10

24 Oct '10

Hello, the attached patch consists of a test case for following bug: http://bugs.winehq.org/show_bug.cgi?id=12104 This test shows how cygwin's setup checks if a WM_SIZE message was received (by the custom window proc). In wine only the property page gets such a message - not the sheet. If I got it right, tests which would fail in wine are prefixed with todo_wine? I want to ask if this patch looks right for inclusion and if the location (dlls/comctl32/tests/) is right? Kind regards, Bernhard

2 1

missing tests in test.winehq.org
by paulo lesgaz 24 Oct '10

24 Oct '10

Hello, looking at http://test.winehq.org, i remarked that the file ddraw/tests/ddrawmodes does not exist and so it is never tested. Does anyone have an explanation for this fact? A+ David

3 4

disabling FORTIFY_SOURCE
by Kees Cook 24 Oct '10

24 Oct '10

Hi, It seems to me that disabling FORTIFY_SOURCE is a mistake. It offers a great many protections, and virtually every distribution has very intentionally turned on this compiler flag by default. Given Wine's size[1], I would argue the benefits[2] outweigh the hassle of rearranging the structures and accessors to not trick the compiler into allocating memory beyond the end of the structure for incoming strings. It has found, at least in other projects, a lot of potential problems, and better yet, has repeatedly turned exploitable vulnerabilities into simple denial of services. I realize it's a bit of a pain to work with given how you're building some of the structures, but I'd like to ask that it not be globally disabled. Thanks, -Kees [1] $ find . -type f -name '*.[ch]' | xargs wc -l | grep total 2678911 total [2] Some details at https://wiki.ubuntu.com/CompilerFlags#-D_FORTIFY_SOURCE=2 but at least the following... Compile time: - static buffer length checks - missed return values - open() checks for missing mode when used with O_CREAT Run time: - dynamic buffer length checks - dynamic format string safety check - dynamic format position safety checks Functions with buffer length (or other) checks: asprintf confstr dprintf fgets fgetws fprintf fread fwprintf getcwd getdomainname getgroups gethostname getlogin_r gets getwd longjmp mbsnrtowcs mbsrtowcs mbstowcs memcpy memmove mempcpy memset pread64 pread printf ptsname_r read readlinkat readlink realpath recv recvfrom snprintf sprintf stpcpy stpncpy strcat strcpy strncat strncpy swprintf syslog ttyname_r vasprintf vdprintf vfprintf vfwprintf vprintf vsnprintf vsprintf vswprintf vsyslog vwprintf wcpcpy wcpncpy wcrtomb wcscat wcscpy wcsncat wcsncpy wcsnrtombs wcsrtombs wcstombs wctomb wmemcpy wmemmove wmempcpy wmemset wprintf -- Kees Cook Ubuntu Security Team

2 1

new
by Michael Sgier 24 Oct '10

24 Oct '10

HiI'm new to this but know that MS Flight Simulator would one need little tweak to run flight school etc. (already worked once)So I've downloaded git and would be thankful for hints on how to proceed and find those bugs in FS9. I also would prefer using Eclipse/Linux, but anyway thanks for help.Many thanksMichael

2 2

Re: ddraw: Add tests for the foreground window set by SetCooperativeLevel
by testbot＠testbot.winehq.org 24 Oct '10

24 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6448 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Between IGF Demo is Unresponsive (Steam Client and Wine 1.3.2)
by "Singapore Citizen Mr. Teo En Ming (Zhang E nming) 张恩鸣 " 24 Oct '10

24 Oct '10

Dear All, When I click on the Play button for Between IGF Demo in Steam client, a window pops up and hangs there. Nothing is displayed in the popped up window. It just hangs there. Anybody know what happens? Please refer to screenshot. [1] http://imgur.com/3Mky4.png [2] http://i55.tinypic.com/dxz6nq.png [3] http://img218.imageshack.us/img218/4595/aa3steamclientwine132.png [4] http://img2.uploadhouse.com/fileuploads/6751/67514722a40f9a6544b45081e58dd0… Please assist in troubleshooting the problem. Thank you very much for your kind assistance. -- Yours sincerely, Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Singapore Identity Card No.: S78*6*2*H Location: Bedok Reservoir Road, Singapore ZIP: 470103 Mobile Phone (Starhub Pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com My Youtube videos: http://www.youtube.com/user/enmingteo Alma Maters: [1] Singapore Polytechnic (Graduated 1998) [2] National University of Singapore (Graduated 2006) My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #1: http://i54.tinypic.com/2415z7t.jpg Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #2: http://img842.imageshack.us/img842/7534/enmingteodscf2511.jpg

1 0

Alien Swarm Does Not Launch (Steam Client and Wine 1.3.2)
by "Singapore Citizen Mr. Teo En Ming (Zhang E nming) 张恩鸣 " 24 Oct '10

24 Oct '10

Dear All, When I try to click the Play button for Alien Swarm in the Steam client, the game does not launch at all. Do you know what happens? Please assist in troubleshooting the problem. Thank you very much for your kind assistance. -- Yours sincerely, Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Singapore Identity Card No.: S78*6*2*H Location: Bedok Reservoir Road, Singapore ZIP: 470103 Mobile Phone (Starhub Pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com My Youtube videos: http://www.youtube.com/user/enmingteo Alma Maters: [1] Singapore Polytechnic (Graduated 1998) [2] National University of Singapore (Graduated 2006) My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #1: http://i54.tinypic.com/2415z7t.jpg Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #2: http://img842.imageshack.us/img842/7534/enmingteodscf2511.jpg

1 0

America's Army 3 (AA3Game.exe) Crashes with Steam Client and Wine 1.3.2
by "Singapore Citizen Mr. Teo En Ming (Zhang E nming) 张恩鸣 " 24 Oct '10

24 Oct '10

Dear All, Please refer to attached screenshot of America's Army 3 Program Error. [1] http://imgur.com/3Mky4.png [2] http://i55.tinypic.com/dxz6nq.png [3] http://img218.imageshack.us/img218/4595/aa3steamclientwine132.png [4] http://img2.uploadhouse.com/fileuploads/6751/67514722a40f9a6544b45081e58dd0… Please assist in troubleshooting the problem. I have set the Default Settings in Application Settings in winecfg to "Windows 7". Thank you very much for your kind assistance. -- Yours sincerely, Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Singapore Identity Card No.: S78*6*2*H Location: Bedok Reservoir Road, Singapore ZIP: 470103 Mobile Phone (Starhub Pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com My Youtube videos: http://www.youtube.com/user/enmingteo Alma Maters: [1] Singapore Polytechnic (Graduated 1998) [2] National University of Singapore (Graduated 2006) My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #1: http://i54.tinypic.com/2415z7t.jpg Photo of Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 #2: http://img842.imageshack.us/img842/7534/enmingteodscf2511.jpg

1 0

Re: [PATCH 7/7] configure: disable fortify the right way
by Alexandre Julliard 23 Oct '10

23 Oct '10

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > $EXTRACFLAGS is used before $CFLAGS, so the previous try would not work. > > Also just -U the define. Won't this break if the default is set through a header? Do all distros do this only through CFLAGS? -- Alexandre Julliard julliard(a)winehq.org

3 3

Font config in Desktop Integration broken when switching locales
by cheer_xiao 23 Oct '10

23 Oct '10

---------- Forwarded message ---------- From: cheer_xiao <xiaqqaix(a)gmail.com> Date: Fri, Oct 22, 2010 at 5:06 PM Subject: Font config in Desktop Integration broken when switching locales To: wine-users(a)winehq.org As a translator, It is frequent for me to switch between locales (en_US.utf8 and zh_CN.utf8 for me), but the font configurations in winecfg/'Desktop Integration' gets broken under certain circumstances. To demonstrate, I run winecfg with LANG=zh_CN.utf8, and set the 'Menu Text' (菜单文字) font to 'WenQuanYi Zen Hei Sharp' (文泉驿点阵正黑) 10pt (shot00.png). It turns out fine (shot01.png), but with LANG=en_US.utf8 the menu text font is a mess (shot02.png). The configuration under zh_CN.utf8 fails to work under en_US.utf8. However, if I run winecfg with LANG=en_US.utf8, and redo the setting (shot10.png, shot11.png), the configuration works under both locales (shot12.png, shot13.png). The configuration made under en_US.utf8 is more "portable". An interesting phonomenum is that in shot10.png, the font configuration seems to have been "reset", ie. it is the font on the top of the list, with the minimum size. This also happens when you configure the font (menu text font here) for the very first time so it must be some kind of default value. The configuration under zh_CN.utf8 was not recognized by winecfg under en_US.utf8, thus falling back to the default. However, during font rendering such fallbacks are not functioning properly (the fallback itself shouldn't be happening though), resulting in the boxes in shot02.png. I guess this issue is due to a bug of how winecfg saves the font configurations and/or how these configurations are used during font rendering. Could anyone explain and/or fix this? I have been looking up the registry but the configurations appear to be stored somewhere else. BTW: Another problem is also observed. Every time I run wine programs (like winecfg, notepad) with LANG=zh_CN.utf8 I get lots of: fixme:msvcrt:_setmbcp trail bytes data not available for DBCS codepage 0 - assuming all bytes I run Wine compiled from the git repo (just a day or two ago) on Ubuntu 10.10. Default locale is en_US.utf8.

1 0

winegstreamer error with 'make install'
by Paul Vriens 22 Oct '10

22 Oct '10

Hi, Current Git (Fedora 13) gives me: /usr/bin/install -c winegstreamer.so /usr/local/lib64/wine/winegstreamer.so /usr/bin/install: cannot stat `winegstreamer.so': No such file or directory There is a winegstreamer.dll.so in this directory. Anyone? -- Cheers, Paul.

2 2

Re: explorer: Create a standalone tray window wrapper if the driver doesn't provide native implementation. Take 2.
by testbot＠testbot.winehq.org 22 Oct '10

22 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6432 Your paranoid android. === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [3/3] msxml3: implement domdoc schema validation
by Nikolay Sivov 22 Oct '10

22 Oct '10

On 10/22/2010 01:27, Adam Martinson wrote: > --- > dlls/msxml3/domdoc.c | 127 > ++++++++++++++++++++++++++++++++------------ > dlls/msxml3/tests/domdoc.c | 4 +- > 2 files changed, 94 insertions(+), 37 deletions(-) > + TRACE("doc not well-formed, returning error 0xC00CE223\n"); > if (err) > - *err = create_parseError(0, NULL, NULL, NULL, 0, 0, 0); > + *err = create_parseError(0xC00CE223, NULL, NULL, NULL, 0, 0, 0); You should add corresponding error code defines for that. This one is E_XML_NOTWF.

1 0

Re: [1/3] msxml3: libxml2 error/warning callback functions
by Alexandre Julliard 22 Oct '10

22 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define LIBXML2_OUTPUT_CALLBACK void __WINE_PRINTF_ATTR(2,3) > +#define LIBXML2_OUTPUT_CALLBACK_BODY(caller, dbcl, msg) \ > + do { \ > + va_list ap; \ > + char* buf; \ > + int len; \ > + va_start(ap, msg); \ > + len = vsnprintf(NULL, 0, msg, ap); \ > + buf = heap_alloc(len+1); \ > + vsnprintf(buf, len+1, msg, ap); \ > + va_end(ap); \ > + wine_dbg_log(__WINE_DBCL##dbcl, __wine_dbch___default, #caller, buf); \ > + heap_free(buf); \ > + } while (0) > + > +#define LIBXML2_XMLERROR_CALLBACK void > +#define LIBXML2_XMLERROR_CALLBACK_BODY(caller, err) \ > + do { \ > + enum __wine_debug_class dbcl = __WINE_DBCL_ERR; \ > + switch (err->level) \ > + { \ > + case XML_ERR_NONE: \ > + dbcl = __WINE_DBCL_TRACE; \ > + break; \ > + case XML_ERR_WARNING: \ > + dbcl = __WINE_DBCL_WARN; \ > + break; \ > + default: \ > + break; \ > + } \ > + wine_dbg_log(dbcl, __wine_dbch___default, #caller, err->message); \ > + } while (0) That's ugly, please write the code explicitly instead of using macros, it's not that much code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fwd: Invitation: Apply to be a Mentoring Organization for GCI
by Dan Kegel 22 Oct '10

22 Oct '10

This looks interesting... ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Oct 18, 2010 at 3:10 PM Subject: Invitation: Apply to be a Mentoring Organization for GCI To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi everyone, Starting today we are accepting applications from organizations who have participated in a previous Google Summer of Code (you!) to get involved with our contest for 13-18 year olds, Google Code-in [0]. If you haven’t read up about Google Code-in, you can check out our announcement [1] to this list from a couple weeks ago or read our blog post [2] about the contest. If your org has decided it would like to apply to participate in the contest, you can fill out the application [3] on Melange now. The deadline for applications is 29 October at 23:00 UTC. Also, if you want to look over the rules for the contest before applying to participate they can be found on the organization application [3] at the bottom. They will also be posted on the Google Code-in website [0] in the next couple days in other languages. We hope your org will consider participating. [0] - http://code.google.com/gci [1] - http://groups.google.com/group/google-summer-of-code-mentors-list/msg/0985e… [2] - http://google-opensource.blogspot.com/2010/10/google-code-in-schools-out-co… [3] - http://socghop.appspot.com/gci/org_app/take/gci_program/google/gci2010/orga… Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Mentors List" group. To post to this group, send email to google-summer-of-code-mentors-list(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-mentors-list+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-mentors-list?hl=en.

1 0

Re: explorer: Create a standalone tray window wrapper if the driver doesn't provide native implementation.
by Alexandre Julliard 22 Oct '10

22 Oct '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch makes sure that "Shell_TrayWnd" window doesn't have a caption > since some apps depend on it being empty. The bug #20129 lists one of such > applications. It does FindWindow("Shell_TrayWnd", "") and expects that it > returns a valid tray window handle. It can't work the way you are doing it, FindWindow won't find a child window. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend) [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS in from_bmformat( BMFORMAT format ) which is used by TranslateBitmapBits
by Hans Leidekker 22 Oct '10

22 Oct '10

On Thu, 2010-10-21 at 17:52 +0200, Tomasz Michno wrote: Please mark your patches with something like (try X) and comment on the changes you made in the same e-mail. Use (resend) when you resend a patch without making any changes. > +/* defines copied from lcms.h: > + */ > +#define INTENT_PERCEPTUAL 0 > +#define INTENT_RELATIVE_COLORIMETRIC 1 > +#define INTENT_SATURATION 2 > +#define INTENT_ABSOLUTE_COLORIMETRIC 3 These should be added to icm.h. I'll send a patch. > + ret=pTranslateBitmapBits(transform, (void*)bitmapBits, > + ok( ret, "BGR: TranslateBitmapBits() succeeded (%d)\n", There's no need to cast to void *. The sense of that error message is wrong. It's displayed when the condition evaluates to false, so it should be 'failed'. And it happens to fail on Windows: transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87)

1 0

Re: ddraw [patch 2/2 | RESEND]: SETFOCUSWINDOW lives independently of other flags
by testbot＠testbot.winehq.org 22 Oct '10

22 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6427 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: ddraw [patch 2/2]: SETFOCUSWINDOW lives independently of other flags
by testbot＠testbot.winehq.org 21 Oct '10

21 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6424 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: (resend) [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS in from_bmformat( BMFORMAT format ) which is used by Translat
by testbot＠testbot.winehq.org 21 Oct '10

21 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6423 Your paranoid android. === W98SE (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W2KPROSP4 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === WXPPROSP3 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W2K3R2SESP2 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === WVISTAADM (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W2K8SE (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W7PRO (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W7PROX64 (32 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87) === W7PROX64 (64 bit transform) === transform.c:127: Test failed: RGB: TranslateBitmapBits() succeeded (87) transform.c:137: Test failed: BGR: TranslateBitmapBits() succeeded (87) transform.c:142: Test failed: GRAY: TranslateBitmapBits() succeeded (87) transform.c:155: Test failed: xRGB/1: TranslateBitmapBits() succeeded (87) transform.c:167: Test failed: xRGB/2: TranslateBitmapBits() succeeded (87)

1 0

Re: ddraw [patch 1/2]: Remove a useless else
by Henri Verbeet 21 Oct '10

21 Oct '10

On 21 October 2010 22:28, David Adam <david.adam.cnrs(a)gmail.com> wrote: > Trailing spaces.

1 0

Reflection interfaces
by Rico Schüller 21 Oct '10

21 Oct '10

Hi, I've a question concerning d3dcompiler, d3d10 and d3dx10 dlls in combination with the shader reflection interfaces. It seems there are 4 different known interfaces: IID_ID3D10ShaderReflection -> d3d10.dll (D3D10ReflectShader()) IID_ID3D10ShaderReflection1 -> d3dx10_xx.dll (D3DX10ReflectShader()) IID_ID3D11ShaderReflection_42 -> d3dcompiler_(40-42).dll (D3DReflect()) IID_ID3D11ShaderReflection -> d3dcompiler_(43).dll (D3DReflect()) The IID_ID3D11ShaderReflection_42 is just a new name for a IID_ID3D11ShaderReflection interface for version 40-42. In d3dcompiler 43 the interface changed and now has a new IID. What's the preferred way to implement the different interfaces? 1. Implement a parser which parses the shader (RDEF, STAT), and implement 4 independent interfaces (each in its own dll). Only reuse the parser. 2. Like 1, but all 4 implementations have there own parser, which leads to a lot of duplicated code. But it is the most flexible way. It could easily parse all possible shader blobs (theoretically they could differ from version to version, I have no test for that, yet). 3. Forward all interfaces to d3dcompiler_43.dll and this will contain all interfaces and the parser. This way the codebase is the smallest possible one, but it will offer all interfaces, which isn't what native does. Also all further interfaces would go to d3dcompiler_43.dll. This could get tricky. Attached is a test program and the output. The programm is compiled with "i686-pc-mingw32-gcc -I./wine/build/include -I./wine/git/include compilertest.c". The test for D3DReflectCode() doesn't work, so please ignore that part. Cheers Rico

2 2

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS in from_bmformat( BMFORMAT format ) which is used by TranslateBitmapBits
by Hans Leidekker 21 Oct '10

21 Oct '10

On Wed, 2010-10-20 at 12:45 +0200, Tomasz Michno wrote: > C_SRCS = \ > - profile.c > + profile.c \ > + transform.c You are copying quite a bit a infrastructure from profile.c, so it would be better to add the tests to that file. We can always split them up later. > +#include "mscms_priv.h" This is not needed. > +void test_TranslateBitmapBits(void){ > + BOOL ret=TRUE; > + COLOR bitmapBits[bitmapSize]; > + COLOR bitmapBitsResult[bitmapSize]; > + #ifdef HAVE_LCMS You can't use that define in tests. > + HPROFILE hProfile; > ... > + transform = pCreateMultiProfileTransform(&hProfile, 2, &intent, 1, > + // test already handled BMFORMATs: This won't work, you say you have 2 profiles but pass only one. Don't use // for comments.

2 1

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.
by Rolf Kalbermatter 21 Oct '10

21 Oct '10

On Tue, Oct 13, 2010 at 16:30 PM, Erich Hoover <ehoover(a)mines.edu> wrote: >> ... >> + int newsize = (int)*maxsize; >> + >> + /* Make sure there is at least enough room for this entry */ >> + newsize -= sizeof(WSACMSGHDR) + CMSG_ALIGN(len); >> + if (newsize < 0) >> + return 0; >> + *maxsize = (ULONG)newsize; >> Just declare it as a ULONG/size_t so you don't have to cast. > >I can obviously change this around a little bit, but the reason for this conversion is that as a >ULONG the "if (newsize < 0)" comparison is not going to work. Then following code would work better: ULONG newsize = sizeof(WSACMSGHDR) + CMSG_ALIGN(len); /* Make sure there is at least enough room for this entry */ if (newsize > *maxsize) return 0; /* else */ *maxsize -= newsize; Rolf Kalbermatter

3 5

current state of full screen on MacOS?
by Joerg-Cyril.Hoehle＠t-systems.com 21 Oct '10

21 Oct '10

Hi, I'd like to know whether a MacOSX user can expect full screen modes to work, as I've heard only rumors and too little facts. My experience is this: + winecfg's window opens fine even with desktop set uo full screen, no window. E.g. as in the initial setting after rm -rf ~/.wine; wine winecfg. + Likewise, other programs opening windows work fine (regedit, notepad etc.). - Programs that offer a "select screen resolution" requester present a list whose largest vertical/Y resolution is 22 pixel less than what the monitor offers. I believe OSX reserves some place for its menu bar. Lower resolution entries, e.g. 1024x768 and 800x600, are listed normally. They work in desktop window mode. - Programs that want to make use of full screen fail or hang somehow. The issue may be two-fold: a) full screen does not work at all, or b) switching to full screen resolutions less than my LCD's native resolution does not work, and applications do not cope with that. E.g. many want to display a low-resolution intro video. - Approx. two monthes ago, a hybrid desktop mode was implemented in Wine: eliminate the desktop window when it matches the full screen size; recreate it when switching back to lower resolutions. I've not observed that effect either, but the idea is brilliant. I've heard that OSX would not switch to lower resolutions like Linux machines do with e.g. xrandr -s 1 or -s 2 etc. My LCD monitor can stretch low resolution VGA signals, e.g. when plugged to a Linux netbook. However the "early 2009" nVidia Macs do not produce analog video signals anymore, and I'm using the DVI-D output. What's the current state of Wine (and Darwine) w.r.t. full screen mode? Is it just my digital DVI + LCD setting or is there an issue with Wine? I've built Wine-1.1.24 with OSX 10.5.7 and XQuartz 2.3.3.2. Thank you, Jörg Höhle.

3 2

Re: About: d3dx9: Store transform matrix per-sprite.
by Joris Huizer 20 Oct '10

20 Oct '10

--- On Tue, 10/19/10, Austin English <austinenglish(a)gmail.com> wrote: > While these emails are very helpful, can you please do a > reply to the > original thread? It makes it easier for those of us using > clients with > threaded mode to follow. > > Thanks! > > -- > -Austin > I can understand that's easier, less messy - I didn't do so up until now as it is quite a number of emails per day (especially if tracking both wine-devel and wine-patch) -- and my contributions/'contributions' are rare; Is there a way to do this other than registering to get the emails daily sent to me? I usually browse through the updates via the web (the mail archive and the patch watcher at http://source.winehq.org/patches/), and as far as I know there is no way of replying on either ? I think I will register to receive emails from the wine-devel and wine-patch mailing lists unless there's an other way to reply to thread. Best regards, Joris

2 1

Re: Translation of the AppDB
by James Mckenzie 20 Oct '10

20 Oct '10

Yaron Shahrabani <sh.yaron(a)gmail.com> wrote: > >On Wed, Oct 20, 2010 at 6:48 AM, James McKenzie ><jjmckenzie51(a)earthlink.net>wrote: > [snip] >So you mean you have got to get some input and there's no other way of >getting input from the users without typing... >Do you feel like you get enough feedback or that automating parts of the >reporting system would make it more widely used. >I'm maintaining lots of translations in the open source world, I never feel >like I get enough feedback and I truly think that if the input was at the >user's fingertips it would help a lot, just my way of looking at it... > Correct. There is quite a wide variation of what can and cannot work that having a bunch of selections would be tedious at best, confusing at worst. >> >> There are many 'drop down' menus that it would be nice to input Hebrew and >> have English populate them. Would this be a good idea? >> >The drop down boxes would be great, the simplest way of interaction is what >needed, no ways of typing Hebrew... > Again, the existing drop downs could be translated into Hebrew and then used to select the English equivilent. However, the text boxes will have to remain due to wide variations in 'What works' and 'What does not work'. Too many selections can be confusing and makes the web site appear to be slow (I work with a web application that has 35,000+ selections, it takes about two minutes for the menu to load on a high speed connection and not all Wine users have that luxury.) >(I was thinking of a small Javascript code that will check for foreign >scripts and if the script is different than the Latin script, a Red message >will appear on top of the box and after clicking the button a message will >pop up saying that this message contains non-universal characters and ask >the user if he is sure about sending this report). > I would just block it. Again, English, for now, is the world's universal language. If someone does not know English, there are sites like Babblefish that cover just about all languages, including (but not limited to) Hebrew, Farsi, Persian, Arabic, Simplified and Traditional Chinese. Users can avail themselves of them and copy/paste into the boxes. I can understand quite a bit of 'translated' English. James McKenzie

2 1

Re: [1/2] msvcrt: Implement _mbsnbcat_s.
by Piotr Caban 20 Oct '10

20 Oct '10

Hi, On 10/20/10 08:49, Andrew Nguyen wrote: + * a lead byte and move the pointer back by one for later overwrite. */ + if (get_locale()->locinfo->mb_cur_max > 1 && MSVCRT_isleadbyte(*(ptr - 1))) + size++, ptr--; You may access dst-1. + ok(errno == EINVAL, "Expected errno to be EINVAL, got %d\n", ret); Printing ret here may be misleading. Cheers, Piotr

1 0

Re: [3/4]strmbase: implement OLE registration in AMovieDllRegisterServer2
by Alexandre Julliard 20 Oct '10

20 Oct '10

Aric Stewart <aric(a)codeweavers.com> writes: > HRESULT WINAPI AMovieDllRegisterServer2(BOOL bRegister) > { > HRESULT hr; > int i; > IFilterMapper2 *pIFM2 = NULL; > + HMODULE psapi; > + fnGetModuleFileNameExW pFunc; > + WCHAR szFileName[MAX_PATH]; > + > + psapi = LoadLibraryA("psapi.dll"); > + if (psapi) > + { > + pFunc = (fnGetModuleFileNameExW)GetProcAddress(psapi, "GetModuleFileNameExW"); > + if (pFunc) > + { > + if (!pFunc(GetCurrentProcess(), g_hInst, szFileName, MAX_PATH)) > + { > + ERR("Failed to get module file name for registration\n"); > + return E_FAIL; > + } > + } > + else > + { > + ERR("Failed to get get function GetModuleFileNameExW\n"); > + return E_FAIL; > + } > + } > + else > + { > + ERR("Failed to load psapi.dll\n"); > + return E_FAIL; > + } > + FreeLibrary(psapi); There's no reason to use psapi for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32/tests: Better reflect the naming scheme
by Alexandre Julliard 20 Oct '10

20 Oct '10

André Hentschel <webmaster(a)dawncrow.de> writes: > @@ -10,7 +10,7 @@ C_SRCS = \ > typelib.c \ > usrmarshal.c \ > varformat.c \ > - vartest.c \ > + variant.c \ > vartype.c Renaming tests should be avoided, it makes it hard to follow the history on test.winehq.org. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/7] msxml3/tests: internal schema doc storage tests (resend)
by Alexandre Julliard 20 Oct '10

20 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define _create(cls) cls, #cls > + > +#define _obj(cls, ...) &_create(cls ## __VA_ARGS__) You can't do that, varargs macros are not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Translation of the AppDB
by Yaron Shahrabani 20 Oct '10

20 Oct '10

Is there any way to localize the AppDB? The Israeli community assumes that having a Hebrew system will make more users report issues. Kind regards, Yaron Shahrabani <Hebrew translator>

4 6

Re: msxml3/domdoc: Partially implement ::setAttributeNode()
by testbot＠testbot.winehq.org 20 Oct '10

20 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6343 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === WVISTAADM (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K8SE (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PRO (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (64 bit domdoc) === domdoc.c:6872: Test failed: got 1

1 0

Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle
by Vincent Povirk 20 Oct '10

20 Oct '10

+1 + if (!prc) + { + UINT width, height; + hr = IWICBitmapSource_GetSize(This->source, &width, &height); + if (FAILED(hr)) return hr; + rc.X = 0; + rc.Y = 0; + rc.Width = width; + rc.Height = height; + prc = &rc; + } Any reason you didn't use this approach in the other functions?

5 6

Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)
by Alexandre Julliard 19 Oct '10

19 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > dlls/msxml3/tests/schema.c | 438 > +++++++++++++++++++++++++++++++++----------- > 1 files changed, 334 insertions(+), 104 deletions(-) Please don't resend just a patch marked 3/6, resend a proper series numbered from 1 so that winetestbot can figure it out. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )
by Hans Leidekker 19 Oct '10

19 Oct '10

On Mon, 2010-10-18 at 18:10 +0200, Tomasz Michno wrote: > +/* unfortunately GetProcAddress cannot return proper pointer to > from_bmformat() function, but for this function it's not a problem, > using copy from ../transform.c */ That's not how it's done in Wine, you will need to go through the API. In this case that means you need to define a bitmap in the appropriate format, create a color transform and then call TranslateBitmapBits. Note that Wine doesn't bundle a color profile, so you need to install one, or configure your X server to use one and retrieve it via GetICMProfile.

2 2

Re: [1/2] windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle (try 2).
by Alexandre Julliard 19 Oct '10

19 Oct '10

Krzysztof Nowicki <krissn(a)op.pl> writes: > I've decided to keep the optimisation in copy_pixels() that checks if the source > and dest rectangles + strides matches and if yes, does a straight memcpy of the > whole bitmap. Please do this as a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Surprise surprise, "Tmax Window OS" was a complete hoax
by James Mckenzie 19 Oct '10

19 Oct '10

Scott Ritchie <scott(a)open-vote.org> wrote: > >About a year or so ago a Korean company called Tmax was claiming to have >developed a new operating system that was 100% fully Windows compatible. > They also claimed to have their own office suite, web browser, and >more, all developed with their own special Korean engineering to keep >the license proprietary. > And they would be 'busted' anyway as Korea is one of the signaturs to the World Digital Copyright agreement. Thanks for seeing them for what they were: False. James McKenzie

1 0

About: d3dx9: Store transform matrix per-sprite.
by Joris Huizer 19 Oct '10

19 Oct '10

Hello, In this patch ID3DXSpriteImpl_Flush is adapted; the new loop being like: int i, count, start; /* ... */ for(start=0;start<This->sprite_count;start+=count,count=0) { i=start; while(i<This->sprite_count && (count==0 || This->sprites[i].texture==This->sprites[i-1].texture)) { /* filling in array */ } /* rest of the outer loop, using array and count */ } It seems count is used uninitialised here on the first iteration ? HTH, Joris

2 1

Re: [PATCH 3/3] jscript: Add index, input and lastIndex properties to regexp funtions results
by testbot＠testbot.winehq.org 19 Oct '10

19 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6322 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: user32: FindWindow() should treat an empty title same way as NULL. (Resend)
by testbot＠testbot.winehq.org 19 Oct '10

19 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6315 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2684: Test failed: GetActiveWindow() = 00000000 win.c:2684: Test failed: GetFocus() = 00000000 win.c:2710: Test failed: GetActiveWindow() = 00000000 win.c:2710: Test failed: GetFocus() = 00000000 win.c:2769: Test failed: GetActiveWindow() = 00000000 win.c:2769: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Surprise surprise, "Tmax Window OS" was a complete hoax
by Scott Ritchie 19 Oct '10

19 Oct '10

About a year or so ago a Korean company called Tmax was claiming to have developed a new operating system that was 100% fully Windows compatible. They also claimed to have their own office suite, web browser, and more, all developed with their own special Korean engineering to keep the license proprietary. This lead some here to justifiably worry that they were using Wine code without permission, as well as dozens of other free software projects. At the time I called it an obvious fraud. Anyway I check backed in on it and, no surprise, Tmax Soft has disavowed all knowledge of the project -- the website is dead, no news about it has appeared since the "launch", and although there are several quicksearches on their main website for the product they return no results. Fortunately, with the exception of a few particularly bad tech journalists, no one seems to have been actually fooled. -Scott Ritchie

1 0

Re: [PATCH 6/8] jscript: Added VBArray.getItem() implementation
by testbot＠testbot.winehq.org 19 Oct '10

19 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6284 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 8/8] jscript: Added VBArray handling to to_object()
by testbot＠testbot.winehq.org 19 Oct '10

19 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6286 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Fwd: Invitation: Apply to be a Mentoring Organization for GCI
by Austin English 19 Oct '10

19 Oct '10

I hadn't see any talk about this, so passing this along from Google: -- -Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Oct 18, 2010 at 8:10 AM Subject: Invitation: Apply to be a Mentoring Organization for GCI To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi everyone, Starting today we are accepting applications from organizations who have participated in a previous Google Summer of Code (you!) to get involved with our contest for 13-18 year olds, Google Code-in [0]. If you haven’t read up about Google Code-in, you can check out our announcement [1] to this list from a couple weeks ago or read our blog post [2] about the contest. If your org has decided it would like to apply to participate in the contest, you can fill out the application [3] on Melange now. The deadline for applications is 29 October at 23:00 UTC. Also, if you want to look over the rules for the contest before applying to participate they can be found on the organization application [3] at the bottom. They will also be posted on the Google Code-in website [0] in the next couple days in other languages. We hope your org will consider participating. [0] - http://code.google.com/gci [1] - http://groups.google.com/group/google-summer-of-code-mentors-list/msg/0985e… [2] - http://google-opensource.blogspot.com/2010/10/google-code-in-schools-out-co… [3] - http://socghop.appspot.com/gci/org_app/take/gci_program/google/gci2010/orga… Cheers, Carol

1 0

Apps for Wine on ARM
by Detlef Riekenberg 18 Oct '10

18 Oct '10

Here is a free compiler to create apps on ARM: http://www.smorgasbordet.com/pellesc/ (Untested, how this app works in Wine) -- By by ... Detlef

1 0

Re: [PATCH 7/8] jscript: Added VBArray.toArray() implementation
by testbot＠testbot.winehq.org 18 Oct '10

18 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6285 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] urlmon: Added IInternetProtocolEx support to BindProtocol.
by Alexandre Julliard 18 Oct '10

18 Oct '10

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/bindprot.c | 343 +++++++++++++++++++++++++++++------------------ > 1 files changed, 212 insertions(+), 131 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/8] jscript: Added VBArray.dimensions() implementation
by testbot＠testbot.winehq.org 18 Oct '10

18 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6283 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/8] jscript: Implement VBArray constructor
by Jacek Caban 18 Oct '10

18 Oct '10

Hi Piotr, +(tmp = new VBArray(createArray())).f = Object.prototype.toString; +ok(tmp.f() === "[object Object]", "tmp.f() = " + tmp.f()); We have Function.call implemented now, you can use String.prototype.toString.call(new VBArray ...). + case DISPATCH_METHOD: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + VariantCopy(retv, arg); Please add error handling. Also a test would be nice, at least something like getVT(createArray()). + case DISPATCH_CONSTRUCT: + if(arg_cnt(dp)<1 || V_VT((arg = get_arg(dp, 0)))!=(VT_ARRAY|VT_VARIANT)) + return throw_type_error(ctx, ei, IDS_NOT_VBARRAY, NULL); + + hres = alloc_vbarray(ctx, NULL,&vbarray); + if(FAILED(hres)) + return hres; + SafeArrayCopy(V_ARRAY(arg),&vbarray->safearray); Error handling. (From 'PATCH 4/8] jscript: Added VBArray.ubound() implementation'): + if(retv) + num_set_val(retv, dim); num_set_val is for DOUBLE and eventually abused for integers out of VT_I4 range. You can set value directly here to avoid conversions. It might be a good idea to introduce something like var_set_int helper given that we could use it in quite a few places. (From '[PATCH 6/8] jscript: Added VBArray.getItem() implementation'): + size = arg_cnt(dp); + if(size< SafeArrayGetDim(vbarray->safearray)) + return throw_range_error(ctx, ei, IDS_SUBSCRIPT_OUT_OF_RANGE, NULL); + + indexes = heap_alloc(sizeof(int)*size); Error handling. (From '[PATCH 8/8] jscript: Added VBArray handling to to_object()'): -exception_test(function() {(new VBArray(createArray())).lbound("aaa");}, "RangeError", -2146828279); -exception_test(function() {(new VBArray(createArray())).lbound(3);}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound("aaa");}, "RangeError", -2146828279); +exception_test(function() {createArray().lbound(3);}, "RangeError", -2146828279); There is no reason to change these tests, esp. that they were better before the change. Please add proper to_object tests, for example by calling Object() function or doing proper call on explicitly converted object. + SafeArrayCopy(sa,&vbarray->safearray); Error handling. Jacek

1 0

Re: [PATCH 4/8] jscript: Added VBArray.ubound() implementation
by testbot＠testbot.winehq.org 18 Oct '10

18 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6282 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/8] jscrpt: Added VBScript.lbound() implementation
by testbot＠testbot.winehq.org 18 Oct '10

18 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6281 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Alexandre Julliard 18 Oct '10

18 Oct '10

Charles Davis <cdavis(a)mymail.mines.edu> writes: > @@ -1828,13 +2054,24 @@ static NTSTATUS find_file_in_dir( char *unix_name, int pos, const WCHAR *name, i > if (ret >= 0 && !used_default) > { > unix_name[pos + ret] = 0; > - if (!stat( unix_name, &st )) > + /* when checking case on a case insensitive but case preserving > + * fs, don't even bother doing the stat(), so we don't match the > + * file case-insensitively. > + */ > + if ((case_sensitive || !check_case) && !stat( unix_name, &st )) > { > if (is_win_dir) *is_win_dir = is_same_file( &windir, &st ); > return STATUS_SUCCESS; > } This still doesn't make sense. There's no reason to ever skip the stat. > @@ -2455,6 +2713,10 @@ static NTSTATUS lookup_unix_name( const WCHAR *name, int name_len, char **buffer > const WCHAR *end, *next; > int is_win_dir = 0; > > + unix_name[pos] = 0; > + stat( unix_name, &st ); > + unix_name[pos] = '/'; You can't add extra stat calls to the normal path. This is supposed to be an optimization. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 1/8] jscript: Added VBArray stub
by testbot＠testbot.winehq.org 18 Oct '10

18 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6279 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

About: [PATCH 2/2] ntdll: Check for case-insensitive volumes.
by Joris Huizer 18 Oct '10

18 Oct '10

Hello, In the proposed patch "[PATCH 2/2] ntdll: Check for case-insensitive volumes.", I found this piece: + /* Add a new entry */ + for (i = 0; i < sizeof(fs_cache)/sizeof(fs_cache[0]); i++) + if (fs_cache[i].dev == 0) + { + /* This entry is empty, use it */ + fs_cache[i].dev = dev; + fs_cache[i].fsid = fsid; + fs_cache[i].case_sensitive = case_sensitive; + } Maybe I'm missing something, but shouldn't you return from the function when finding a cache entry to fill? This seems to be filling every empty cache entry? HTH, Joris

2 1

About: msxml3: Partially implement ::setAttributeNode()
by Joris Huizer 18 Oct '10

18 Oct '10

Hello, In proposed patch msxml3: Partially implement ::setAttributeNode() I think I found a little possible memory leak: + name = xmlChar_from_wchar(nameW); + value = xmlChar_from_wchar(V_BSTR(&valueW)); + + if (!name || !value) + { + SysFreeString(nameW); + VariantClear(&valueW); + return E_OUTOFMEMORY; + } Wouldn't you need to free memory allocated for both name and value, in case one of the allocations succeeded ? HTH, Joris

2 1

Re: [1/4]winegstreamer: add wine gstreamer parser filter
by Damjan Jovanovic 18 Oct '10

18 Oct '10

On Mon, Oct 18, 2010 at 3:26 PM, Aric Stewart <aric(a)codeweavers.com> wrote: > --- > dlls/winegstreamer/regsvr.c | 951 +++++++++++++++++++ Please consider IRegistrar or inf file based registration instead, regsvr.c is the worst way to support DLL registration, especially if you have to customize it the way you have. Damjan

1 0

Re: [1/4] msxml3: Get rid of ::get_dataType() forward to IXMLDOMNode interface
by Jacek Caban 18 Oct '10

18 Oct '10

Hi Nikolay, On 10/18/10 11:26 AM, Nikolay Sivov wrote: > Get rid of ::get_dataType() forward to IXMLDOMNode interface > switch ( This->node->type ) { case XML_ELEMENT_NODE: On of points of such patches is to get rid of such switches. In this case it seems like introducing new helper return_null_var, adding FIXME to extityref implementation and moving element-specific part to element.c is way to go. Also it would be nice to have consistent TRACEs, so moving them to node-specific objects would be nice. Jacek

2 3

Re: [PATCH 3/3] winspool: Use UNICODE for CUPS printer names [fixes bug 6437]
by Alexandre Julliard 18 Oct '10

18 Oct '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > or do we have to remove all related "const" from the strings? Yes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try4]
by Alexandre Julliard 18 Oct '10

18 Oct '10

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > I was looking for a forbidden char in batch files but just I found accentuated chars whereas I wanted a single (not wide) char. > Finally, I found it in the ASCII table. > The \x1a character name is SUBSTITUTE and is exactly what we need. It means end of file on Windows, so it's not a good choice. Please don't add magic control chars, do a @space@ style of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/4] msxml3: Partially implement ::setAttributeNode()
by testbot＠testbot.winehq.org 18 Oct '10

18 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6265 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === WVISTAADM (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K8SE (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PRO (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (64 bit domdoc) === domdoc.c:6872: Test failed: got 1

1 0

Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps
by Hans Leidekker 18 Oct '10

18 Oct '10

Hi Tomasz, Please use a more specific subject such as "mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in TranslateBitmapBits".

1 0

Re: [PATCH] mscms: patch for problem with displaying images with enabled color management in system and some apps
by Nikolay Sivov 17 Oct '10

17 Oct '10

On 10/17/2010 22:46, Tomasz Michno wrote: > --- > dlls/mscms/tests/Makefile.in | 3 ++- > dlls/mscms/transform.c | 2 ++ > 2 files changed, 4 insertions(+), 1 deletions(-) > > > You forgot to add new file to a patch.

1 0

[PATCH] Compiling Wine at Ubuntu 10.10
by Gerold Jens Wucherpfennig 17 Oct '10

17 Oct '10

You will need this patch to compile Wine at Ubuntu 10.10, because of the new Xorg Server 1.9. If you still get a compilation error in dlls/winex11.drv you will need to add the flag "-lXxf86vm". With kind regards, Gerold Jens Wucherpfennnig

4 5

Re: Set base direction of web site to RTL language for Hebrew
by Yaron Shahrabani 17 Oct '10

17 Oct '10

Waste of time, there are several objects that should be LTR (like the news list) and some images that need to be flipped horizontally, plus I have already done all the stuff I said, basically this patch is useless...

2 4

Ubuntu Package Archive is back!
by Scott Ritchie 17 Oct '10

17 Oct '10

When I switched Ubuntu package hosting to a launchpad PPA (away from manual .deb hosting), one thing lost was the ease of archiving old versions, since Launchpad doesn't provide this. I've written some scripts to manually copy the packages from the PPA to form a new archive and am hosting it at the old location http://wine.budgetdedicated.com/archive/ -- currently it carries all the Wine packages that have been on the Ubuntu Wine PPA since 1.3.3 or so. The main use of the archive is to aid in regression testing - installing from packages is much easier/quicker than recompiling from source, and will help you narrow down the last working/nonworking wine version before doing a proper git bisect. All I have to do is run the script every time I update the PPA with new Wine packages, and it's good. Due to server space issues, I don't plan to archive daily package builds (which is my next project). Thanks, Scott Ritchie

2 1

RTL in console windows
by Yaron Shahrabani 17 Oct '10

17 Oct '10

Hi there guys, My name is Yaron Shahrabani and I'm an active translator of Wine to Hebrew. As probably some of you may know Hebrew is written from right-to-left meaning that the GUI and text rendering should work in a reversed/mirror order as opposed to Latin text. Due to some recent work doen by Alexander (Thanks! AJ, great work!), Hebrew is better supported now by wine GUI mechanism but as a translator I ran into some dillemas about the translation of strings that appear in console window, well apparently this is a tough question. Paul (Vriens) sent me 2 screenshots the other day that showed the way Hebrew is handled by the different command line platforms: The first one is the VTE (Virtual Terminal Emulator) which most of us know as gnome-vte or gnome-terminal, this app emulates a command line interface for X11. As opposed to Konsole (The same app only for KDE) gnome's vte cannot handle Hebrew correctly (is there any need to attach bugs or you'll just believe me?). gnome-terminal can show the Hebrew glyphs but they all appear in reversed order, same thing happens for wine apps that present a command line output (such as reg, ipconfig, etc.) when running via gnome-terminal. The other option to display and work with a CLI app is via wineconsole, since wineconsole does not support Hebrew our of the box we have to install the msttcorefonts package in order to do so. At the second screenshot that Paul sent me with the wineconsole screenshot of reg (I translated the app but since I'm not sure how it will work I haven't submitted it to wine-patches yet but I will send it here if needed) Ive seen some blanks with ":" at the end meaning that the glyphs were missing, few minutes later Paul sent me an updated screenshot after installing the missing glyphs, the Hebrew looked absolutely perfect, the only problem was that the semicolon still appeared to the right of the text instead of to the left (where the sentence ends in Hebrew). So my dillema is as follows: Should we continue helping improving the support of displaying RTL languages in wineconsole or should we just ignore the CLI strings like MS did with all of their OSes (Since Windows XP Hebrew is no longer supported officially, meaning that you have to apply 3rd party patches in order to make Hebrew text appear in cmd), Hebrew in command line is only used by some old healthcare services and lots of old games and ancient word processors and database apps (some of them died after Windows dominated the market). Another vital question I want to to this message is to ask our fellow Arabic and Persian speakers what do they have to say about this issue and if their propriatery operating systems has the same issues... I would love to clarify any misclarifications. Thank you all, Kind regards, Yaron Shahrabani <Hebrew translator>

2 2

Website: Change language string
by Yaron Shahrabani 17 Oct '10

17 Oct '10

Where does the translation of "Change Language" string at the bottom of the page and in the lang.template come from? (The current term used is male specific, I want to make it genderless). Kind regards, Yaron Shahrabani <Hebrew translator>

2 2

Packagers: cups-bsd/cupsys-bsd (lpr and friends) no longer needed
by Detlef Riekenberg 16 Oct '10

16 Oct '10

Hi Wine packing Team. Cups has a compatibility package for the BSD style printing system (lpr, lpq, lprm, lpc and related files). The package is named cups-bsd on ubuntu and cupsys-bsd on debian. This compatibility package is no longer needed since Wine-1.3.5, when cups is installed: http://source.winehq.org/git/wine.git/?a=commit;h=f69a4ef07f7b1b0017e1bf335… Thanks for updating the Wine dependency. -- By by ... Detlef

2 1

Re: user32: Update last active popup for all parents
by testbot＠testbot.winehq.org 16 Oct '10

16 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6225 Your paranoid android. === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH] problem with color management with mscms and gdi
by Detlef Riekenberg 16 Oct '10

16 Oct '10

Hi Tomasz. Welcome to Wine. You already fixed your missing real name in your first patch. That is good, but there are more suggestions. > For applications which uses EnumICMProfiles to detect monitor icc profile, > there should be a copy of monitor profile in > windows\system32\spool\drivers\color\monitor.icc. If there is no monitor.icc > in this directory, application works the same as if there were no color > management enabled (but image is displayed ok). A description for the issue is a good idea. > INT WINAPI EnumICMProfilesA(HDC hdc, ICMENUMPROCA func, LPARAM > lparam) > { > FIXME("%p, %p, 0x%08lx stub\n", hdc, func, lparam); > - return -1; > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); > + FIXME("partially fixed: force C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc\n"); > + return 1; > } What you wrote in your patch is a hack and hacks are missing the code quality to be accepted in Wine. Wine development is test driven. You should add some tests for this function and try to invent a real implementation, which match the tests. - Does this function handle a NULL parameter for hdc and/or for func? (If a NULL produce a crash on Windows, there is no need to check for a NULL in the implementation in Wine) - What does the function return, when the directory does not exist or when there are no icc profiles in the directory? - A HDC for a window on the monitor is not the only type for an HDC. (memory, printers, metafiles) Implementing all possible types is not a requirement (as long, as an app does not need it), but the usual way in Wine is at least printing a FIXME for the unimplemented part of the API. - There are usable API functions, to get the icc profile path. - Reading the directory and calling the user func for every file is not very difficult, as wine has examples in the source. You can ask for help for the implementation or for the tests on wine-devel or use #winehackers on freenode. There is has also http://testbot.winehq.org and later http://tests.winehq.org > INT WINAPI EnumICMProfilesW(HDC hdc, ICMENUMPROCW func, LPARAM ... > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); Providing an ANSI Path to a UNICODE callback will never work. > /********************************************************************** > diff --git a/dlls/mscms/transform.c b/dlls/mscms/transform.c This is a separate Patch I know, that the starting step is not easy, but once you contributed successfully to Wine, your Development results (patches) are much better. Did you read http://wiki.winehq.org/DeveloperFaq and http://wiki.winehq.org/SubmittingPatches ? Overview: http://wiki.winehq.org/Developers -- By by ... Detlef

1 0

Re: [PATCH] problem with color management with mscms and gdi
by André Hentschel 16 Oct '10

16 Oct '10

Hi and welcome to wine development, your patch is wrapped. see the gdi part of it at http://source.winehq.org/patches/. so you should check your mailclient. Further you might want to split it per module (gdi and mscms, one patch each) -- Best Regards, André Hentschel

2 1

Re: [PATCH] problem with color management with mscms and gdi
by Hans Leidekker 16 Oct '10

16 Oct '10

Hi Tomasz, This patch is wrapped, unlike your first attempt were you attached the patch. > dlls/gdi32/icm.c | 8 ++++++-- > dlls/mscms/transform.c | 2 ++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dlls/gdi32/icm.c b/dlls/gdi32/icm.c > index 0e346ee..d75c528 100644 > --- a/dlls/gdi32/icm.c > +++ b/dlls/gdi32/icm.c > @@ -44,7 +44,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(icm); > INT WINAPI EnumICMProfilesA(HDC hdc, ICMENUMPROCA func, LPARAM > lparam) > { > FIXME("%p, %p, 0x%08lx stub\n", hdc, func, lparam); > - return -1; > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); > + FIXME("partially fixed: force C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc\n"); > + return 1; > } You can't hardcode the filename like that. EnumICMProfiles should call down into the driver and probably enumerate a registry key. > /********************************************************************** > diff --git a/dlls/mscms/transform.c b/dlls/mscms/transform.c > index a795386..e7a3faa 100644 > --- a/dlls/mscms/transform.c > +++ b/dlls/mscms/transform.c > @@ -65,6 +65,8 @@ static DWORD from_bmformat( BMFORMAT format ) > { > case BM_RGBTRIPLETS: return TYPE_RGB_8; > case BM_BGRTRIPLETS: return TYPE_BGR_8; > + case BM_xRGBQUADS: return TYPE_RGBA_8; > + case BM_xBGRQUADS: return TYPE_ABGR_8; > case BM_GRAY: return TYPE_GRAY_8; > default: > if (quietfixme == 0) You should send this as a separate patch.

1 0

Re: [Website] Foundation of the Hebrew website
by James McKenzie 16 Oct '10

16 Oct '10

On 10/11/10 9:28 AM, Yaron Shahrabani wrote: > Started some translation work, there is still much more RTLing work to > do so we will settle for an LTR for now and I will handle it soon. > Yaron Shahrabani > > <Hebrew translator> > > > > Yaron: Since the web site works runs on a Web Server, should you not be building the work RTL rather than LTR? Just a thought, mind you and it might save work later. James McKenzie

2 4

Re: [2/6] msxml3: IXMLDOMSchemaCollection/XMLSchemaCache backend
by Nikolay Sivov 16 Oct '10

16 Oct '10

On 10/15/2010 18:25, Adam Martinson wrote: > > Implemented on top of libxml's hash table. > --- > dlls/msxml3/schema.c | 376 > +++++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 326 insertions(+), 50 deletions(-) > +static LONG cache_entry_release(cache_entry* entry) > { > - schema_t *This = impl_from_IXMLDOMSchemaCollection( iface ); > + LONG ref = InterlockedDecrement(&entry->ref); > + TRACE("%p new ref %d\n", entry, ref); > > - TRACE("(%p)->(%s %p)\n", This, debugstr_guid( riid ), ppvObject ); > + if (ref == 0) > + { > + if (entry->type == SCHEMA_TYPE_XSD) > + { > + xmldoc_release(entry->doc); > + entry->schema->doc = NULL; > + xmlSchemaFree(entry->schema); > + heap_free(entry); > + } > + else /* SCHEMA_TYPE_XDR */ > + { > + xmldoc_release(entry->doc); > + heap_free(entry); > + } > + } > + return ref; > +} Looks a but redundant. xmldoc_release() and heap_free(entry) are always used, so only xmlSchemaFree() and doc reset before it should be under condition. > + xmlNodePtr root; > + if (schema) > + root = xmlDocGetRootElement(schema); > + if (root&& root->ns) > + { root uninitialized? If this never happens practically then remove if (schema) condition. > - IXMLDOMSchemaCollection_AddRef( iface ); > + IXMLDOMSchemaCollection_AddRef(iface); > > return S_OK; > } > > -static ULONG WINAPI schema_cache_AddRef( IXMLDOMSchemaCollection *iface ) > +static ULONG WINAPI schema_cache_AddRef(IXMLDOMSchemaCollection *iface) No need for such changes here and later in this patch, even some new added lines use white-spaces in such cases. > + IXMLDOMNode* domnode = NULL; > + IDispatch_QueryInterface(V_DISPATCH(&var),&IID_IXMLDOMNode, (void**)&domnode); > + > + if (domnode) > + doc = xmlNodePtr_from_domnode(domnode, XML_DOCUMENT_NODE)->doc; Not sure about that, I'd say it's better to test for hr == S_OK and return value from QueryInterface, is this branch tested?

1 0

Re: [1/6] msxml3: add a function to initialize xmlDoc->_private data
by Nikolay Sivov 16 Oct '10

16 Oct '10

On 10/15/2010 18:25, Adam Martinson wrote: > > Needed to associate an internal ref count, etc with a xmlDoc > outside of domdoc.c, without creating the whole domdoc struct. > --- > dlls/msxml3/domdoc.c | 6 ++++++ > dlls/msxml3/msxml_private.h | 1 + > 2 files changed, 7 insertions(+), 0 deletions(-) Why not use this helper in DOMDocument_create() ?

1 0

Re: [6/6] msxml3: implement schema_cache_addCollection()
by testbot＠testbot.winehq.org 16 Oct '10

16 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6213 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: [5/6] msxml3: implement schema_cache_remove()
by testbot＠testbot.winehq.org 16 Oct '10

16 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6212 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: [4/6] msxml3: implement schema_cache_get_length()
by testbot＠testbot.winehq.org 16 Oct '10

16 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6211 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:445: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:446: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:447: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:449: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: [3/6] msxml3/tests: internal schema doc storage tests
by testbot＠testbot.winehq.org 16 Oct '10

16 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6210 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:339: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:343: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0

Re: Updated Norwegian translation.
by Austin English 15 Oct '10

15 Oct '10

2010/10/14 Trygve Vea <trygve.vea(a)gmail.com>: > Hello, > > This is my first patch to Wine - this one fixes some translation > errors - and adds some new translations. > I hope this is not the last patch I will send to Wine. > > Any feedback is welcome. Hello Trygve, Thanks for the translations. However, patches should be split, 1 patch per module. In other words, one patch for dlls/crypt32, one for dlls/jscript, and so on. I can't judge the rest, I don't speak Norweigan :-). Cheers, -Austin

3 2

Re: oleaut32: Updated Norwegian translation.
by Alexander Nicolaysen Sørnes 15 Oct '10

15 Oct '10

Fredag 15 oktober 2010 07:48:17 skrev Trygve Vea : > What is being changed here? Alexander N. Sørnes

1 0

Re: jscript: Updated Norwegian translation.
by Alexander Nicolaysen Sørnes 15 Oct '10

15 Oct '10

Fredag 15 oktober 2010 07:46:51 skrev Trygve Vea : > This should be discarded. I've made some comments to the patch that contained all the translations in one, and the overall quality of the patches is good. Alexander N. Sørnes

1 0

Accessibility in wine
by Seth Shelnutt 14 Oct '10

14 Oct '10

I can't seem to find much info on this. What is wine's support for MSAA or the newer UIAutomation? I see that there is the oleacc dll which is the main dll for MSAA. According to the API site, is seems there are still 10 stubs. Looking at the source code there hasn't been any updates in over a year. We don't have the UIAutomation dll yet. Does anyone know the status of MSAA/UIAutomation support in wine? I'm trying to get NVDA working and still running into some issues with it requiring UIAutomation.dll, when according to them, that dll is optional. After I get that worked out I'm hoping to see what needs to be done to get MSAA supported under wine. Thanks, Seth Shelnutt

2 2

Re: msi/tests: Move test coverage for standard actions to a separate module.
by Greg Geldorp 14 Oct '10

14 Oct '10

> From: Hans Leidekker <hans(a)codeweavers.com> > > This is to get rid of the remaining timeouts on testbot. We now have > a clean test run: > > http://testbot.winehq.org/JobDetails.pl?Key=6167 > > On platforms where we need to create a restore point the install tests > still take over two minutes, so depending on the load on testbot we > might still see some timeouts. This is great! If needed, I can probably turn off System Restore, which disables creation of restore points altogether. Greg.

1 0

Re: msi/tests: Move test coverage for standard actions to a separate module.
by Hans Leidekker 14 Oct '10

14 Oct '10

This is to get rid of the remaining timeouts on testbot. We now have a clean test run: http://testbot.winehq.org/JobDetails.pl?Key=6167 On platforms where we need to create a restore point the install tests still take over two minutes, so depending on the load on testbot we might still see some timeouts.

2 2

Re: [PATCH 4/5] d3d10core: Add a stub ID3D10Texture3D implementation.
by testbot＠testbot.winehq.org 14 Oct '10

14 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6168 Your paranoid android. === WINEBUILD (build) === Patch failed

3 2

Google Summer of Code Mentors?
by Jeremy White 14 Oct '10

14 Oct '10

Did we have an 'official' leader for GSOC this past year? If not, could I ask someone (*cough* Kai *cough*) to nominate themselves? We need to coordinate getting some information to the SFC so that we can collect the mentor stipend from Google. Cheers, Jeremy

3 2

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.
by Mike Kaplinskiy 14 Oct '10

14 Oct '10

On Tue, Oct 12, 2010 at 8:01 PM, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > While searching for something else I discovered a bug relevant to the > interface-bound UDP broadcast patches I've been working on. Apparently, > IP_PKTINFO does work on Windows when used with the special WSARecvMsg > function (Bug #19493). The attached patch addresses this issue by > implementing WSARecvMsg through WS2_recvfrom and by converting the Unix > IP_PKTINFO response to the Windows equivalent. > ChangeLog: > ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO. > > > > Sorry I must have missed the RFC when reading my mail. These comments are purely mine, and may not have any value for getting your patch in :). +static inline WSACMSGHDR *create_control_message(int level, int type, WSACMSGHDR *current, ULONG *maxsize, void *data, int len) This doesn't seem like a "create", more like a "fill" or "write". + int newsize = (int)*maxsize; + + /* Make sure there is at least enough room for this entry */ + newsize -= sizeof(WSACMSGHDR) + CMSG_ALIGN(len); + if (newsize < 0) + return 0; + *maxsize = (ULONG)newsize; Just declare it as a ULONG/size_t so you don't have to cast. +static inline int convert_control_headers(struct msghdr *hdr, ULONG *maxsize) You shouldn't mix using memory as unix-style CMSGs and windows-style CMSGs. Just allocate something to store the unix messages, read them in and convert them into the user-passed buffer. This seems similar to what we do for address conversion. + memset(cmsg_win, 0x00, sizeof(WSACMSGHDR)); /* Don't use garbage data if no headers are found */ I think in general that is discouraged at wine (don't quote me on that). You should just initialize the values manually. + if (wsa->control && !convert_control_headers(&hdr, wsa->controllen)) + { + /* Insufficient room for control headers */ + errno = EINVAL; + return -1; + } This should probably be in an #ifdef of some sort. + msg->dwFlags |= WINE_MSG_HASCTRL; + memcpy(buftmp, msg->lpBuffers, msg->dwBufferCount * sizeof(WSABUF)); + buftmp[msg->dwBufferCount] = msg->Control; + ret = WS2_recvfrom( s, buftmp, msg->dwBufferCount, lpNumberOfBytesRecvd, + &msg->dwFlags, msg->name, &msg->namelen, + lpOverlapped, lpCompletionRoutine ); You shouldn't add internal flags like that. Just rewrite WS2_recvfrom to allow returning message headers instead of hacking around it. +static int (WINAPI *pWSARecvMsg)(SOCKET,LPWSAMSG,LPDWORD,LPWSAOVERLAPPED,LPWSAOVERLAPPED_COMPLETION_ROUTINE) = 0; +GUID WSARecvMsg_GUID = WSAID_WSARECVMSG; For one reason or another the convention is to get it during your test function (see AcceptEx & ConnectEx). (This does have some merit as SIO_GET_EXTENSION_FUNCTION_POINTER can vary with the socket that's passed) + s1addr.sin_family = AF_INET; + s1addr.sin_port = htons(9375); + s2addr.sin_family = AF_INET; + s2addr.sin_port = htons(9375); You should probably bind to 0 and then use getsockname to get the actual port you bound to. + s1=socket(AF_INET, SOCK_DGRAM, 0); + ok(s1!=INVALID_SOCKET, "socket() failed error: %d\n", WSAGetLastError()); Spaces around = & != would make me happy (and below). Also you don't error out correctly if socket creation fails. diff --git a/include/mswsock.h b/include/mswsock.h index 322ab20..5749e59 100644 --- a/include/mswsock.h +++ b/include/mswsock.h This should be a separate patch. diff --git a/include/ws2ipdef.h b/include/ws2ipdef.h index 11b3689..ec0b85a 100644 --- a/include/ws2ipdef.h +++ b/include/ws2ipdef.h Same here. Mike.

2 2

Ongoing Debian package maintenance.
by Ben Klein 14 Oct '10

14 Oct '10

Hello everyone, My health has not improved at all since my last call for help with the Debian package management. I really need someone to take over from me, or at least some help to devise a new set of (semi-)automated build scripts. Any volunteers? Kind regards, Ben

5 11

Removal of very very old versions from bugzilla?
by Scott Ritchie 13 Oct '10

13 Oct '10

Wise idea or no? If not is there at least a way to hide them from the report bug page? I'm talking about the 2001-era version numbers, before 0.9 even. -Scott Ritchie

2 1

Re: [PATCH] jscript/tests: add tests for ActiveScriptSite_OnScriptError and IActiveScriptError. [try 3]
by Reece Dunn 13 Oct '10

13 Oct '10

On 9 October 2010 15:51, Reece Dunn <msclrhd(a)googlemail.com> wrote: > try 1 -- initial series (1-3) > try 2 -- revised test infrastructure based on Jacek's comments > try 3 -- fleshed out the tests to complete the test coverage for > IActiveScriptError Any reason this has not been committed yet? Thanks, - Reece

1 0

Re: [5/5] msi/tests: Don't create a nested restore point on recent versions of MSI.
by testbot＠testbot.winehq.org 13 Oct '10

13 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6155 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout === W2K3R2SESP2 (32 bit install) === Timeout

1 0

Re: [4/5] mscoree: Use the new search methods for GetCORVersion/GetCORSystemDirectory. (try 2)
by Alexandre Julliard 13 Oct '10

13 Oct '10

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This shouldn't introduce a failure if Mono is missing. I'm afraid it does: ../../../tools/runtest -q -P wine -M fusion.dll -T ../../.. -p fusion_test.exe.so fusion.c && touch fusion.ok wine: Install the Windows version of Mono to run .NET executables fusion.c:193: Test failed: Expected S_OK, got 80131700 fusion.c:194: Test failed: Expected "C:\windows\assembly\NativeImages_el32.dll_32", got "nochange" make: *** [fusion.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

RFC: Fixing imagelist control tests for 16bpp
by Austin Lund 13 Oct '10

13 Oct '10

It seems that the imagelist control on XP has some strange device dependence even though the tests use device independent bitmaps. Attached is a patch to try and correct the test for what is broken. Is this the right approach?

1 0

Re: [transl] Deal with WS_EX_LAYOUTRTL for RTL languages
by Yaron Shahrabani 12 Oct '10

12 Oct '10

On Tue, Oct 12, 2010 at 11:08 AM, Paul Vriens <paul.vriens.wine(a)gmail.com>wrote: > Hi, > > This patch makes sure that a missing WS_EX_LAYOUTRTL for EXSTYLE is flagged > for RTL languages and that it's ignored if present. > > It's not ideal yet as the potential errors shown on the webpage do not > fully explain the issue/error. More changes are needed to get that into > place but this patch at least makes sure that the real errors are catched > and don't get lost in the multitude of errors we have now (for Hebrew for > example). > > Changelog > Deal with WS_EX_LAYOUTRTL for RTL languages > Hey Paul, I think these should apply to several other languages: Divehi Syriac Urdu (There are several other languages but I took the following out of the following list: http://source.winehq.org/transl/) Another language which I'm not sure about is Pujabi since it has 3 popular scripts: Gurmukhi and Devanagari are RTL written while Shahmukhi is RTL, Wikipedia in written in the RTL script while Ubuntu is translated using the LTR scripts (can't determine which though). Its all about location, Pakistanies are writing in RTL whille all others write with the LTR scripts, It all depends on who you ask :) Your patch to the translation check is working great, thanks alot! Yaron Shahrabani <Hebrew translator> > > -- > Cheers, > > Paul. > > > >

1 0

Re: [4/5] mscoree: Use the new search methods for GetCORVersion/GetCORSystemDirectory.
by Vincent Povirk 12 Oct '10

12 Oct '10

Hang on, this one will also introduce a failure. On Tue, Oct 12, 2010 at 12:51 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

1 0

Re: [PATCH 5/5] shlwapi/tests: Add more tests
by testbot＠testbot.winehq.org 12 Oct '10

12 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6118 Your paranoid android. === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1793: Test failed: got 29 ordinal.c:1843: Test failed: got 29 ordinal.c:1851: Test failed: got 29 ordinal.c:1859: Test failed: got 40, length 41 ordinal.c:1870: Test failed: got 43 === W7PROX64 (64 bit ordinal) === ordinal.c:1787: Test failed: got 10 ordinal.c:1808: Test failed: got 7 ordinal.c:1821: Test failed: got 10 ordinal.c:1829: Test failed: got 10 ordinal.c:1859: Test failed: got 36, length 37 ordinal.c:1870: Test failed: got 39 ordinal.c:1881: Test failed: got 21 ordinal.c:1892: Test failed: got 24

2 1

Re: [PATCH 1/5] shlwapi: Improved SHGetShellKey implementation
by testbot＠testbot.winehq.org 12 Oct '10

12 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6117 Your paranoid android. === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1789: Test failed: got 29 ordinal.c:1839: Test failed: got 29 ordinal.c:1847: Test failed: got 29 ordinal.c:1855: Test failed: got 40, length 41 ordinal.c:1866: Test failed: got 43 === W7PROX64 (64 bit ordinal) === ordinal.c:1783: Test failed: got 10 ordinal.c:1804: Test failed: got 7 ordinal.c:1817: Test failed: got 10 ordinal.c:1825: Test failed: got 10 ordinal.c:1855: Test failed: got 36, length 37 ordinal.c:1866: Test failed: got 39 ordinal.c:1877: Test failed: got 21 ordinal.c:1888: Test failed: got 24

1 0

Re: [PATCH 1/5] ddraw: Use a linear filter in ddraw_surface7_Blt().
by Stefan Dösinger 12 Oct '10

12 Oct '10

Am 12.10.2010 um 13:40 schrieb Henri Verbeet: > + hr = IWineD3DSurface_Blt(This->WineD3DSurface, DestRect, Src ? Src->WineD3DSurface : NULL, > + SrcRect, Flags, (WINEDDBLTFX *)DDBltFx, WINED3DTEXF_LINEAR); Why do you think a linear filter is correct? I was under the impression that ddraw only uses point filters.

2 2

Re: setupapi/tests: Fix wow64 failures
by Alexandre Julliard 12 Oct '10

12 Oct '10

André Hentschel <nerv(a)dawncrow.de> writes: > This removes problems on wow64 on windows platforms (wine can't even handle the normal case yet) > See http://test.winehq.org/data/tests/setupapi:devinst.html > --- > dlls/setupapi/tests/devinst.c | 44 +++++++++++++++++++++++++++-------------- > 1 files changed, 29 insertions(+), 15 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M setupapi.dll -T ../../.. -p setupapi_test.exe.so devinst.c && touch devinst.ok devinst.c:1120: Test succeeded inside todo block: Unexpected path \\?\ROOT#LEGACY_BOGUS#0001#{6A55B5A4-3F65-11DB-B704-0011955C2BDB} make[1]: *** [devinst.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] d3dx9/tests: Fix a failure on 64 bits.
by Alexandre Julliard 12 Oct '10

12 Oct '10

Matteo Bruni <matteo.mystral(a)gmail.com> writes: > @@ -131,7 +131,9 @@ static void test_get_shader_constant_table_ex(void) > > /* With invalid CTAB data */ > hr = D3DXGetShaderConstantTableEx(shader_with_invalid_ctab, 0, &constant_table); > - ok(hr == D3DXERR_INVALIDDATA, "Got result %x, expected %x (D3DXERR_INVALIDDATA)\n", hr, D3DXERR_INVALIDDATA); > + /* Native on 64 bit doesn't check for invalid data */ > + ok(hr == D3DXERR_INVALIDDATA || (hr == D3D_OK && sizeof(DWORD) != sizeof(DWORD_PTR)), > + "Got result %x, expected %x (D3DXERR_INVALIDDATA)\n", hr, D3DXERR_INVALIDDATA); This doesn't seem to have much to do with 64-bit, it looks more like a broken implementation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: libs/wine: make lack of LDT support an #error
by Alexandre Julliard 12 Oct '10

12 Oct '10

Austin English <austinenglish(a)gmail.com> writes: > Nothing runs without it. The error is pretty obvious, I don't think there's a need to break the build. Besides, you don't need LDT for 32-bit apps if you have GDT support. -- Alexandre Julliard julliard(a)winehq.org

1 0

LLVM compilation
by Jeff Cook 11 Oct '10

11 Oct '10

Just wondering if anyone has experimented building WINE with LLVM instead of GCC. For those who haven't been following it closely, LLVM/Clang is fairly mature now and can now build some really mammoth projects. Has anyone experimented in building WINE with LLVM/Clang? If so, what results were gotten? My understanding is that WINE tries hard to be pretty portable and non-GCC-specific, so I would expect good results... Thanks From Jeff

6 5

IDE for Wine Development?
by Evil Jay 11 Oct '10

11 Oct '10

The small patches I've submitted previously have been very minor code changes that I put together in a text editor. But today I've been perusing the available bug list, and see a couple of more ambitious things I would like to try to tackle. My question is: Which IDE/editors do you "real" devs prefer for your work on Wine? This topic doesn't seem to be mentioned in the dev faq/guides on WineHQ. I googled to see if others had asked before, but if they did I must have not phrased my searches very well. I've been playing with KDevelop 4.0.2 for the last hour. It's beautiful, but I haven't had the best experience with it: It randomly crashed 3 times within a short period of first using it. Oddly, it's not crashed since I restarted it from the command line so that I could attempt to figure out what the problem is. -J

5 4

Re: [1/2] kernel32: Implement GetSystemRegistryQuota as a semi-stub.
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6079 Your paranoid android. === W98SE (32 bit process) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: [6/6] msi/tests: Reduce the UI level for a couple of tests.
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6078 Your paranoid android. === W2K8SE (32 bit install) === Timeout

1 0

Re: [2/3] msxml3/httprequest: Implement POST support with supplied body data
by Alexandre Julliard 11 Oct '10

11 Oct '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Implement POST support with supplied body data It crashes here: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok wine: Unhandled page fault on read access to 0x00610054 at address 0x556c7d55 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00610054 in 32-bit code (0x556c7d55). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:556c7d55 ESP:0032fad0 EBP:0032fb28 EFLAGS:00010202( R- -- I - - - ) EAX:00130f98 EBX:5570b4ec ECX:0061004c EDX:000401e8 ESI:68f31924 EDI:0032fbd4 Stack dump: 0x0032fad0: 00130f98 001259d8 00000000 68f31924 0x0032fae0: 0032fb0c 0012b0a4 0032fb08 687e878b 0x0032faf0: 68894798 00000000 7bc49ceb 000401e8 0x0032fb00: 001329b8 00000000 0032fb68 00130f98 0x0032fb10: 001329b8 55704230 0032fbd8 5570b4ec 0x0032fb20: 68f31924 001329b8 0032fb88 556de570 Backtrace: =>0 0x556c7d55 bind_to_storage+0x145(url="http://crossover.codeweavers.com/xmltest.xml", pbc=0x1259d8, riid=0x68f31924, ppv=0x32fbd4) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1623] in urlmon (0x0032fb88) 1 0x556de570 URLMoniker_BindToStorage+0x7f(iface=0x1329b8, pbc=0x1259d8, pmkToLeft=(nil), riid=0x68f31924, ppvObject=0x32fbd4) [/home/julliard/wine/wine/dlls/urlmon/umon.c:226] in urlmon (0x0032fbf8) 2 0x68f0ac2f httprequest_send+0x29e(iface=0x132560, body={n1={n2={vt=0, wReserved1=0, wReserved2=0x549f, wReserved3=0x7bc3, n3={cVal=-92, uiVal=0x25a4, ulVal=0x1325a4, intVal=0x1325a4, uintVal=0x1325a4, bVal=-92, iVal=0x25a4, lVal=0x1325a4, fltVal=0.000000, dblVal=115829032902964642774731102830373123138357386478391680597607917204841224939855876815354089977900578056271309531616954000897843059241707444154521072387433862091187643543289869583516710016022354436402931544267598795367270420594576483624868777837530808994684936908624353063660385789867458560.000000, boolVal=0x25a4, scode=0x1325a4, date=115829032902964642774731102830373123138357386478391680597607917204841224939855876815354089977900578056271309531616954000897843059241707444154521072387433862091187643543289869583516710016022354436402931544267598795367270420594576483624868777837530808994684936908624353063660385789867458560.000000, bstrVal="GET", cyVal={={Lo=0x1325a4, Hi=0x7b88577c}, int64=0x7b88577c001325a4}, punkVal=0x1325a4, pdispVal=0x1325a4, parray=0x1325a4, llVal=0x7b88577c001325a4, ullVal=0x7b88577c001325a4, pcVal="G", puiVal="GET", pulVal=0x1325a4, pintVal=0x1325a4, puintVal=0x1325a4, pbVal="G", piVal=0x1325a4, plVal=0x1325a4, pfltVal=0x1325a4, pdblVal=0x1325a4, pboolVal=0x1325a4, pscode=0x1325a4, pdate=0x1325a4, pbstrVal=0x1325a4, pvarVal=0x1325a4, byref=0x1325a4, pcyVal=0x1325a4, pdecVal=0x1325a4, ppunkVal=0x1325a4, ppdispVal=0x1325a4, pparray=0x1325a4, pllVal=0x1325a4, pullVal=0x1325a4, brecVal={pvRecord=0x1325a4, pRecInfo=0x7b88577c}}}, decVal={wReserved=0, u={={scale=0, sign=0}, signscale=0}, Hi32=0x7bc3549f, u1={={Lo32=0x1325a4, Mid32=0x7b88577c}, Lo64=0x7b88577c001325a4}}}}) [/home/julliard/wine/wine/dlls/msxml3/httprequest.c:472] in msxml3 (0x0032fd38) 3 0x6868d935 func_domdoc+0x1104() [/home/julliard/wine/wine/dlls/msxml3/tests/domdoc.c:3370] in msxml3_test (0x0032fd88) 4 0x6869e92e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/msxml3/tests/../../../include/wine/test.h:556] in msxml3_test (0x0032fe48) 5 0x6869eb27 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/msxml3/tests/../../../include/wine/test.h:624] in msxml3_test (0x0032fe90) 6 0x6869f6ac __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msxml3_test (0x0032fea8) 7 0x7b856cfc call_process_entry+0xb() in kernel32 (0x0032fee8) 8 0x7b8591fb start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 9 0x7bc72d30 call_thread_func+0xb() in ntdll (0x0032ffc8) 10 0x7bc72f00 call_thread_entry_point+0x6f(entry=0x7b8591a0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 11 0x7bc4db1a start_process+0x29(kernel_start=0x7b8591a0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x556c7d55 bind_to_storage+0x145 [/home/julliard/wine/wine/dlls/urlmon/binding.c:1623] in urlmon: call *0x8(%ecx) 1623 IBinding_Release(BINDING(binding)); -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9: Fix D3DXPlaneNormalize on 64 bits.
by Henri Verbeet 11 Oct '10

11 Oct '10

On 8 October 2010 16:32, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > This patch changes D3DXPlaneNormalize to behave as native on 64 bits, > returning infinity in the fourth plane component when the norm is 0. > If this is not appropriate, I can resend without the implementation > changes, just fixing the tests. > I can't say this is necessarily wrong, but I do think it looks suspicious.

3 2

Re: [5/6] msi/tests: Set the MSIFASTINSTALL property.
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6077 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: [1/6] msi/tests: Determine Wow64 mode just once.
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6073 Your paranoid android. === W2K8SE (32 bit install) === Timeout === W7PROX64 (64 bit install) === install.c:10489: Test failed: key not created

1 0

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Henri Verbeet 11 Oct '10

11 Oct '10

On 7 October 2010 19:49, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Draw a full screen quad */ > +static void draw_quad_with_shader9(IDirect3DDevice9 *device, IDirect3DVertexBuffer9 *quad_geometry) > +{ > + HRESULT hr; > + D3DXMATRIX projection_matrix; > + > + D3DXMatrixOrthoLH(&projection_matrix, 2.0f, 2.0f, 0.0f, 1.0f); > + IDirect3DDevice9_SetTransform(device, D3DTS_PROJECTION, &projection_matrix); > + > + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, D3DCOLOR_XRGB(0, 0, 0), 1.0f, 0); > + ok(hr == D3D_OK, "IDirect3DDevice9_Clear returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_BeginScene(device); > + ok(hr == D3D_OK, "IDirect3DDevice9_BeginScene returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_SetStreamSource(device, 0, quad_geometry, 0, sizeof(struct vertex)); > + ok(hr == D3D_OK, "IDirect3DDevice9_SetStreamSource returned: %08x\n", hr); > + hr = IDirect3DDevice9_DrawPrimitive(device, D3DPT_TRIANGLESTRIP, 0, 2); > + ok(hr == D3D_OK, "IDirect3DDevice9_DrawPrimitive returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_EndScene(device); > + ok(hr == D3D_OK, "IDirect3DDevice9_EndScene returned: %08x\n", hr); > + > + hr = IDirect3DDevice9_Present(device, NULL, NULL, NULL, NULL); > + ok(hr == D3D_OK, "IDirect3DDevice9_Present returned: %08x\n", hr); > +} > + Backbuffer contents are undefined after present.

1 0

Re: ddraw/test: Add more combinaison tests for SetCooperativeLevels
by testbot＠testbot.winehq.org 11 Oct '10

11 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6071 Your paranoid android. === W98SE (32 bit ddrawmodes) === No test summary line found === W7PROX64 (64 bit ddrawmodes) === Timeout

1 0

Re: cabinet/tests: Reformated output in case of test failure (try 3)
by Alexandre Julliard 11 Oct '10

11 Oct '10

Marko Nikolic <grkoma(a)gmail.com> writes: > @@ -109,9 +109,9 @@ static void test_FDICreate(void) > ok(hfdi != NULL, "Expected non-NULL context\n"); > ok(GetLastError() == 0xdeadbeef, > "Expected 0xdeadbeef, got %d\n", GetLastError()); > - ok(erf.erfOper == 0x1abe11ed, "Expected 0x1abe11ed, got %d\n", erf.erfOper); > - ok(erf.erfType == 0x5eed1e55, "Expected 0x5eed1e55, got %d\n", erf.erfType); > - ok(erf.fError == 0x1ead1e55, "Expected 0x1ead1e55, got %d\n", erf.fError); > + ok(erf.erfOper == 0x1abe11ed, "Expected 0x1abe11ed, got %x\n", erf.erfOper); > + ok(erf.erfType == 0x5eed1e55, "Expected 0x5eed1e55, got %x\n", erf.erfType); > + ok(erf.fError == 0x1ead1e55, "Expected 0x1ead1e55, got %x\n", erf.fError); Most of these are error codes too, they should be in decimal. I don't see why you want to change this at all. If you think having the expected value printed in hex is confusing just get rid of it, it's useless anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try3]
by Alexandre Julliard 11 Oct '10

11 Oct '10

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -11,6 +25,8 @@ echo. > echo . > echo.word > echo .word > +echo word > +echo word You need some escaping mechanism for these trailing spaces too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: toolhelp: Document InterruptRegister16
by Alexandre Julliard 11 Oct '10

11 Oct '10

Thomas Bleher <ThomasBleher(a)gmx.de> writes: > @@ -593,6 +593,29 @@ BOOL16 WINAPI StackTraceNext16(STACKTRACEENTRY *ste) > > /*********************************************************************** > * InterruptRegister (TOOLHELP.75) > + * > + * Registers a callback to intercept certain special events from any process. > + * > + * The special events are (TODO: There may be other events not listed here; > + * these are the ones documented in the patent mentioned below): These are standard x86 traps, they don't need special constants or documentation. Besides, if there's really a patent about this we can't implement it anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.
by Alexandre Julliard 11 Oct '10

11 Oct '10

Jeff Cook <jeff(a)deserettechnology.com> writes: > @@ -520,7 +520,12 @@ static void ALSA_MixerInit(void) > } > > /* Add master channel, uncounted channels and an extra for capture */ > - mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + 1; > + /* Do not add the extra channel needed for capture on half-duplex capture cards > + like snd_usb_audio mics */ > + if (micelem && !mastelem && !captelem) > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem; > + else > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem + 1; This statement wasn't exactly clear before, but now it's really impossible to follow. Please rewrite this in a way that makes sense to a casual reader. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATCH] riched20/tests: Cleaned up ITextServices::TxGetNaturalSize test and fixed test failures. (try 2)
by Austin Lund 11 Oct '10

11 Oct '10

On 11 October 2010 13:46, Austin Lund <austin.lund(a)gmail.com> wrote: > > + todo_wine ok(result == S_OK || broken(result == E_FAIL), /* WINXP Arabic Language */ > + "TxGetNaturalSize gave unexpected return value (result = %x)\n", result); I know it's slightly unorthodox to reply to your own patch, but if anyone can throw any light on why this fails for this version of windows it would be much appreciated. My guess is a problem with RTL fonts, but I'm not sure.

1 0

Re: iphlpapi: Use Windows rather than Unix values to determine family
by André Hentschel 11 Oct '10

11 Oct '10

Hi "lats", you should please provide your real name in your mail, otherwise your patch has bad chances to get in. Normally you can configure git, so that it reports your name in the "From:" field. -- Best Regards, André Hentschel

2 1

RFC: Patch to implement WSARecvMsg and IP_PKTINFO
by Erich Hoover 11 Oct '10

11 Oct '10

While searching for something else I discovered a bug relevant to the interface-bound UDP broadcast patches I've been working on. Apparently, IP_PKTINFO does work on Windows when used with the WSARecvMsg function (Bug #19493). I've attached a patch to address this issue (including tests), and I would appreciate any comments on it. This patch approaches the problem by: 1) Implementing WSARecvMsg through WS2_recvfrom 2) Passing the control buffer as an additional WSABUF with an internal flag (cleared internally to prevent confusing applications) 3) Converting the returned Unix IP_PKTINFO data to the equivalent Windows version in WS2_recv() by utilizing a temporary buffer Thanks in advance for your feedback. Erich Hoover ehoover(a)mines.edu

1 0

Re: urlmon: Added ProtocolStream_Stat implementation.
by testbot＠testbot.winehq.org 10 Oct '10

10 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6022 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: user32/tests: Test FindWindowEx for empty window title (try 3)
by testbot＠testbot.winehq.org 10 Oct '10

10 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6017 Your paranoid android. === W98SE (32 bit win) === win.c:2970: Test failed: message 000f available win.c:2982: Test failed: message 000f available win.c:2991: Test failed: message 000f available win.c:3000: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 6)
by Vitaliy Margolen 10 Oct '10

10 Oct '10

On 10/08/2010 12:22 PM, Rudolf Mayerhofer wrote: > +static SYSTEM_LOGICAL_PROCESSOR_INFORMATION cached_lpi[1024]; You think there are systems with that many CPUs running Wine? > + for (i = 0; i < (sizeof(cached_lpi) / sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION)); i++) To make it easier to understand what you doing here please calculate number of elements in cached_lpi array with: sizeof(cached_lpi) / sizeof(cached_lpi[0]); This way people don't need to look up what type cached_lpi is. > @@ -1069,6 +1193,160 @@ void fill_cpu_info(void) > } > } > fclose(f); > + > + /* Parse Logical Processor Information in SysFS */ > + { > + int coreflags = (cached_sci.FeatureSet & CPU_FEATURE_HTT) ? 1 : 0; > + int cpucount = 0, cachecount, nodecount, i; > + ULONG_PTR fullprocessormask = 0, processormask; > + Please don't do this. Don't create a block just so you can declare variables. Put variable declaration at the top of the outer block. > + while ((processormask = sysfs_cpu_topology_getmap(cpucount, "thread_siblings")) > 0) > + { > + /* Core information */ > + { > + /* Unique cores are found multiple times during iteration, add only once */ > + for (i = 0; i < (sizeof(cached_lpi) / sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION)); i++) > + { ... > + } > + } ... > + } Same thing here. > +static int sysfs_cpucache_getint(int cpu, int cache, const char *type) > + /* Cache information */ > + cachecount = 0; > + while ((processormask = sysfs_cpucache_cpumap(cpucount, cachecount)) > 0) > + { > + /* Empty Processormasks are invalid, ignore them */ What does this comment refers too? If it's for the above while() condition, then please put comment above it, not inside the block. > + BYTE level = sysfs_cpucache_getint(cpucount, cachecount, "level"); > + BYTE associativity = sysfs_cpucache_getint(cpucount, cachecount, "ways_of_associativity"); > + WORD linesize = sysfs_cpucache_getint(cpucount, cachecount, "coherency_line_size"); > + DWORD size = sysfs_cpucache_getint(cpucount, cachecount, "size"); I've already told you before - do not mix signed and unsigned. If result of sysfs_cpucache_getint is always assigned to an unsigned variable then change it's return type to unsigned type too. > + /* Determine Cachetype */ > + if (typestring[0] == 'D') > + { > + type = CacheData; > + } > + else if (typestring[0] == 'I') > + { > + type = CacheInstruction; > + } > + else if (typestring[0] == 'U') > + { > + type = CacheUnified; > + } > + else if (typestring[0] == 'T') > + { > + type = CacheTrace; > + } Either use swith case construct here or use complete words and stricmp. > + if ((processormask = sysfs_numanode_cpumap(nodecount)) > 0) > + { > + /* Numa Nodes are already unique. just add them */ > + do > + { > + } > + while ((processormask = sysfs_numanode_cpumap(nodecount)) > 0); > + } > + else > + { > + } People already asked you not to do this. From looking at the code it appears that there is always one node. So get rid of everything except do{} while() block. It will do exactly what you want with extra if()s. Vitaliy.

2 5

Re: shlwapi: Skip more tests on too old shlwapi.dll.
by testbot＠testbot.winehq.org 10 Oct '10

10 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6009 Your paranoid android. === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1796: Test failed: got 13 ordinal.c:1832: Test failed: got 13 ordinal.c:1877: Test failed: got 23 ordinal.c:1888: Test failed: got 26 === W7PROX64 (32 bit ordinal) === ordinal.c:1796: Test failed: got 13 ordinal.c:1832: Test failed: got 13 ordinal.c:1877: Test failed: got 21 ordinal.c:1888: Test failed: got 24 === W7PROX64 (64 bit ordinal) === ordinal.c:1783: Test failed: got 10 ordinal.c:1789: Test failed: got 26 ordinal.c:1796: Test failed: got 13 ordinal.c:1804: Test failed: got 7 ordinal.c:1817: Test failed: got 10 ordinal.c:1825: Test failed: got 10 ordinal.c:1832: Test failed: got 13 ordinal.c:1839: Test failed: got 26 ordinal.c:1847: Test failed: got 26 ordinal.c:1877: Test failed: got 21 ordinal.c:1888: Test failed: got 24

1 0

Re: cabinet/tests: Reformated output in case of test failure (try 2)
by Alexandre Julliard 09 Oct '10

09 Oct '10

Marko Nikolic <grkoma(a)gmail.com> writes: > In case of test failure, expected and received values are traced. > Format for the two values was different, corrected so both values > are traced as hex. Error values are in general more useful in decimal. -- Alexandre Julliard julliard(a)winehq.org

2 1

Debugging 64-bit Wine Apps with winedbg
by Tom Grubbe 09 Oct '10

09 Oct '10

Hello, we're the developers of a large 64-bit Windows application that uses Wine 1.3.0 64-bit on Linux. When testing began we discovered several crashes inside our windows code on startup and needed to debug them. But the problem seems to be getting any kind of stack trace information from the 64-bit winedbg. This used to work with the 32-bit version of winedbg. Even if I write a 64-bit "hello world" app that intentionally crashes I still can't get a clean stack trace from winedbg. We get a register dump and a stack dump but no back trace. So in our app, we have to resort to calculating the address of the crash in our DLLs using a MAP file and adding a bunch of printfs to try and locate the source of the SEGV. This is awkward, slow and just a bad way to debug. So here's my question - Has anyone had any luck getting a debugger stack trace using the 64-bit winedbg? Some relevant info: * We build wine 64-bit 1.3.0 ourselves * We're running on RHEL 5.5 (Tikanga) 2.6.18-194.el5 64-bit * We get the same non-results from both release and debug windows binaries * Using winedbg --gdb crashes gdb * We tried using msvsmon.exe to attach to and debug the wine process using Visual Studio but it hasn't been helpful * Setting WINEDEBUG to several debug channels has helped some but is difficult to sift through all the noise So any info on strategies to debug 64-bit Wine applications is welcome, or if you need more info I'll be glad to supply it. Thanks for your help! --Tom Grubbe ESRI

4 6

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 5)
by Alexandre Julliard 08 Oct '10

08 Oct '10

Rudolf Mayerhofer <rm(a)eightyfive.net> writes: > +/*********************************************************************** > + * Several methods to retrieve data from SysFS (/sys) > + * used to retrieve cached_lpi in fill_cpu_info() > + */ > +static int sysfs_cpu_exists(int cpu) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/cpu/cpu%d", cpu); > + return access(buf, F_OK) == 0; > +} > + > +static int sysfs_cpucache_exists(int cpu, int cache) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/cpu/cpu%d/cache/index%d", cpu, cache); > + return access(buf, F_OK) == 0; > +} > + > +static int sysfs_numanode_exists(int node) > +{ > + char buf[256]; > + > + sprintf(buf, "/sys/devices/system/node/node%d", node); > + return access(buf, F_OK) == 0; > +} Don't do that sort of thing. You should handle failures to open the files at the point where you need them instead of doing redundant checks. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2 (try2)] shlwapi: Handle URL_WININET_COMPATIBLITY flag in UrlCanonicalize
by Alexandre Julliard 08 Oct '10

08 Oct '10

Andrew Eikum <aeikum(a)codeweavers.com> writes: > try2: Rebase on top of [1/2]. > > dlls/shlwapi/tests/url.c | 4 ++++ > dlls/shlwapi/url.c | 6 ++++-- > 2 files changed, 8 insertions(+), 2 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok cryptnet.c:353: Test failed: File URLs not supported make: *** [cryptnet.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32: Avoid relying on PATH_MAX in import_certs_from_dir helper.
by Austin English 08 Oct '10

08 Oct '10

On Thu, Oct 7, 2010 at 6:56 PM, Andrew Nguyen <anguyen(a)codeweavers.com> wrote: > > PATH_MAX is not guaranteed to be available on all platforms, and it is > inadequate as a hardcoded buffer size anyway. Also fixes the first compiler error on GNU Hurd. Thanks Andrew! -- -Austin

1 0

New winetricks 20101008: new verbs abiword, dsound, nvidiasdk9, vd, xinput
by Dan Kegel 08 Oct '10

08 Oct '10

Another fortnight-and-a-half, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes since 20100917: Austin English: - add dsound verb. (Issue 175) - add xinput verb - dxsdk_nov2006, add support for quiet install. - fix dotnet installs for wine 1.2 (broken in recent winetricks release) - introduce $appdata_win/$appdata_unix variables, use it for Safari - refuse to run in 64-bit WINEPREFIX's - remove deprecated pbuffer option - update eadm sha1sum - update flash sha1sums - update kde to 0.9.7-0 - update utorrent sha1sum/url Dan Kegel: - add nvidiasdk9 - remove bogus msvcr80 installed by dotnet20; fixes issue 164. - use symbolic variable uniformly in set_videomemorysize - add abiword, ie6_full - fix two spots WINETRICKS_TMP wasn't quoted; this broke WINEPREFIXes containing spaces. Reported by Roberto Neri. - add vd=1024x768, vd=off options. Fixes bug 172. Scott Ritchie: - new verb cjkfonts (individual verb names may still change) - Add Quicktime 7.6, update quicktimes to depend on vcrun2005 Erik Inge Bolsø - reenable mscoree after directx9 install; fixes issue 25.

3 2

Re: [4/4] msxml3/httprequest: Implement ::get_responseBody()
by testbot＠testbot.winehq.org 08 Oct '10

08 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5972 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:3312: Test failed: got 1, expected 1 === W2KPROSP4 (32 bit domdoc) === domdoc.c:3312: Test failed: got 1, expected 1

1 0

Re: [2/4] msxml3/httprequest: Implement ::abort()
by testbot＠testbot.winehq.org 08 Oct '10

08 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5971 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:3311: Test failed: got 1, expected 1 === W2KPROSP4 (32 bit domdoc) === domdoc.c:3311: Test failed: got 1, expected 1

1 0

Re: [PATCH 1/3] jscript: test that ActiveScriptSite_OnScriptError is called on script failure. (resend)
by Reece Dunn 07 Oct '10

07 Oct '10

On 7 October 2010 14:35, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Reece, > > These tests need more thoughts. They should show how jscript exceptions are > translated into IActiveScriptError. Your code doesn't provide mechanism to > do so, so I would suggest to wait with sending patches that don't move us > any forward until you have a clue how it should work. Otherwise you will > have to deal with eventually bad decisions for no good reason. Ok, so if I keep the current tests/ActiveScriptSite as they are and have something like: test_script_error(source, scode, description, lineno, charpos, linesource) { EXPECT CALL ActiveScriptSite_OnScriptError hres = parse_script_with_error(source); ok(hres == 0x8012345, ...) CHECK CALL ActiveScriptSite_OnScriptError ok(script_excep.scode == scode, ...) ok(script_excep.bstrDescription == description, ...) ok(script_lineno == lineno, ...) ok(script_charpos == charpos, ...) ok(script_linesource == linesource, ...) } test_script_errors() { test_script_error("var foo = new Object();\nfoo.bar;", 0x8012345, "Object does not support this property", 20, 11, "foo.bar;") test_script_error("new <>%^^;", 0x8012322, "Syntax error", 0, 0, "new <>%^^;") ... } where parse_script_with_error does the same thing as parse_script, but uses an ActiveScriptSite implementation that checks OnScriptError calls and stores the IActiveScriptError object for testing within test_script_error (like with my 3rd patch, but checking specific values). 1/ Does this look like a sensible approach to you? 2/ Do we care about the tests working on non-English locales (not sure how to get the above working on other languages -- specifically the description text)? 3/ Are we ok with making wine match the error description strings exactly, given the above tests? NOTE: 2 and 3 can be avoided by just checking the scode and checking that the description is set and non-NULL (as per my 3rd patch). > Also merging parsing_htmlscript is not a good idea. Its purpose is different > than parse_script. Ok, I'll keep them separate. - Reece

2 1

Re: [PATCH 1/2] shlwapi/tests: Mark Win98 failures as broken
by Jacek Caban 07 Oct '10

07 Oct '10

Hi Andrew, Can we please find a way to detect such old (broken) shlwapi and just skip the whole test (preferable all tests in the file)? Failing UrlGetPart would do the trick, hopefully there is better way. This will result in cleaner code and will save us time in future. Jacek

1 0

Re: ntdll: fix compile on systems without termios.port.c_ispeed/termios.port.c_ospeed structs
by Alexandre Julliard 07 Oct '10

07 Oct '10

Austin English <austinenglish(a)gmail.com> writes: > @@ -498,7 +498,7 @@ static NTSTATUS set_baud_rate(int fd, const SERIAL_BAUD_RATE* sbr) > return STATUS_NOT_SUPPORTED; > #endif /* Don't have linux/serial.h or lack TIOCSSERIAL */ > } > -#elif !defined(__EMX__) > +#elif !defined(__EMX__) && defined (_HAVE_STRUCT_TERMIOS_C_ISPEED) && defined (_HAVE_STRUCT_TERMIOS_C_OSPEED) > switch (sbr->BaudRate) > { > case 0: port.c_ospeed = B0; break; You'd want to use the cflag method in this case. Which platform needs this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Mentor summit for Google Summer of Code - time sensitive
by Jeremy White 07 Oct '10

07 Oct '10

As a heads up, Bradley reminds me that the Mentor summit for GSOC: http://gsoc-wiki.osuosl.org/index.php/2010 is coming up; the registration deadline is tomorrow. Google may reimburse travel expenses, so if cost is an issue, we may be able to help with that. If you need such help, let me know, and I'll connect you with Bradley. Cheers, Jeremy

1 0

Re: [6/6]strmbase: Implement BaseFilter in strmbase
by Alexandre Julliard 07 Oct '10

07 Oct '10

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/qcap/vfwcapture.c | 134 +++++-------------------- > dlls/quartz/acmwrapper.c | 20 ++-- > dlls/quartz/avidec.c | 12 +- > dlls/quartz/avisplit.c | 6 +- > dlls/quartz/dsoundrender.c | 223 > ++++++++++++------------------------------- > dlls/quartz/filesource.c | 129 +++++-------------------- > dlls/quartz/mpegsplit.c | 4 +- > dlls/quartz/nullrenderer.c | 177 ++++++++-------------------------- > dlls/quartz/parser.c | 156 ++++++++++-------------------- > dlls/quartz/parser.h | 9 +-- > dlls/quartz/transform.c | 201 ++++++++------------------------------- > dlls/quartz/transform.h | 10 +-- > dlls/quartz/videorenderer.c | 226 > +++++++++++++------------------------------ > dlls/quartz/waveparser.c | 4 +- > dlls/strmbase/Makefile.in | 1 + > dlls/strmbase/filter.c | 158 ++++++++++++++++++++++++++++++ > include/wine/strmbase.h | 23 +++++ > 17 files changed, 517 insertions(+), 976 deletions(-) > create mode 100644 dlls/strmbase/filter.c I'm seeing occasional crashes in the qedit:mediadet test with this patch. Unfortunately the debugger fails to get a backtrace. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wine_call_on_stack Sparc Edition
by André Hentschel 07 Oct '10

07 Oct '10

Oops, wrong address, sry for the noise -- Best Regards, André Hentschel

1 0

Re: psapi/tests: get rid of an ugly test macro
by testbot＠testbot.winehq.org 07 Oct '10

07 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5941 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:110: Test failed: cbNeeded=108

1 0

Re: [PATCH] d3d9/tests: Fix test failure for IDirect3D9::CreateDevice in test_set_stream_source
by testbot＠testbot.winehq.org 07 Oct '10

07 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5923 Your paranoid android. === W2K8SE (32 bit device) === device.c:2474: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2612: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (32 bit device) === device.c:2474: Test failed: Expected foreground window 0002019A, got 00010092. device.c:2612: Test failed: Expected foreground window 0003019A, got 00010092.

1 0

Re: usp10: when checking font for shaping the font needs at least 1 of the features but does not need all.
by Dmitry Timoshkov 07 Oct '10

07 Oct '10

Aric Stewart <aric(a)codeweavers.com> wrote: > - while (ShapingData[psa->eScript].requiredFeatures[i]) > + while (ShapingData[psa->eScript].requiredFeatures[i] && !found) > { > feature = load_GSUB_feature(hdc, psa, psc, ShapingData[psa->eScript].requiredFeatures[i]); > - if (!feature) > - return USP_E_SCRIPT_NOT_IN_FONT; > + if (feature) > + found = TRUE; Why not return S_OK right away here, and return USP_E_SCRIPT_NOT_IN_FONT right after the while loop? That would eliminate a need for an intermediate variable and simplify the code. -- Dmitry.

1 0

Test failures on Windows XP Japanese due to fonts selection differences
by Austin Lund 07 Oct '10

07 Oct '10

There are a number of test failures due to hardcoded sizes in test which fail for particular platforms, e.g. http://test.winehq.org/data/6e89a61446088dbe029913896dfae467bb8d37a1/xp_wtb… It seems the reason for this is that it is impossible to select the system font with height 16 on this platform. (No idea why, any ideas?) Should these tests be written so that a particular font selection is forced across platforms (e.g. ANSI, 16 point, System), or should the hardcoded values instead be computed for each particular instance?

1 0

New version of exe-thumbnailer (0.7)
by Scott Ritchie 07 Oct '10

07 Oct '10

Includes much prettier icons, support for Vista icons (with icoutils 0.29.1) and more. Screenshots and a description are at: http://wiki.winehq.org/exe-thumbnailer -Scott Ritchie

4 6

Re: [PATCH 06/10] urlmon: Added IBinding::Abort and binding without callback tests.
by testbot＠testbot.winehq.org 07 Oct '10

07 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5914 Your paranoid android. === W2K8SE (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL === W7PROX64 (32 bit url) === url.c:1553: Test failed: binding failed: 800c0005, expected 00000000 url.c:2558: Test failed: IMoniker_BindToStorage failed: 800c0005 url.c:2559: Test failed: unk == NULL

1 0

Translation patches for wine-1.2.1
by Michael Stefaniuc 06 Oct '10

06 Oct '10

Hello Alexandre, attached is the list with the translation patches to cherry-pick for wine-1.2.1. The list was generated with the attached crud patch (modified from the version I used for 1.0.1) and then I have manually removed all my janitorial patches that didn't produce conflicts. Though the removal of the unneeded "Remove the ignored common resource attributes" patches makes "wrc --verify-translation" produce DIFF lines for resources that were added at a later time as those don't have the ignored common resource attributes. bye michael

2 2

Re: [PATCH 3/9] urlmon: Added IBinding::Abort implementation.
by Alexandre Julliard 06 Oct '10

06 Oct '10

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 20 +++++++++++++++++--- > 1 files changed, 17 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmllocation.c && touch htmllocation.ok wine: Unhandled page fault on read access to 0x00000110 at address 0x555d325a (thread 001f), starting debugger... Unhandled exception: page fault on read access to 0x00000110 in 32-bit code (0x555d325a). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:555d325a ESP:0032dfd0 EBP:0032e038 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00ed2bf4 EBX:5561bc84 ECX:002078c0 EDX:555d31c0 ESI:0126f400 EDI:00000000 Stack dump: 0x0032dfd0: 00ed2b98 0032e3a8 0032e008 6ad698bc 0x0032dfe0: 002078b0 00000001 00000001 0032e078 0x0032dff0: 6adbe4f5 002078b0 0032e018 00000000 0x0032e000: 002078b0 6b127f9c 0032e028 6ad697d8 0x0032e010: 002078b0 0032e074 00000001 00000000 0x0032e020: 002078a8 0032e074 0032e068 012ad758 Backtrace: =>0 0x555d325a handle_load+0x9a(iface=0x126f5c0, event=0x12ad758) [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml (0x0032e158) 1 0x6a02f1db in xul (+0x3ef1da) (0x0032e1d8) 2 0x6aca1e00 in xul (+0x1061dff) (0x0032e208) 3 0x6aca1fe1 in xul (+0x1061fe0) (0x0032e258) 4 0x6a047958 in xul (+0x407957) (0x0032e2a8) 5 0x6a04819c in xul (+0x40819b) (0x0032e378) 6 0x69dc9c12 in xul (+0x189c11) (0x0032e408) 7 0x6a53d3a0 in xul (+0x8fd39f) (0x0032e698) 8 0x6a53ced6 in xul (+0x8fced5) (0x0032e718) 9 0x6a5574c8 in xul (+0x9174c7) (0x0032e768) 10 0x6a556567 in xul (+0x916566) (0x0032e798) 11 0x6a556371 in xul (+0x916370) (0x0032e7e8) 12 0x6a555fa2 in xul (+0x915fa1) (0x0032e858) 13 0x69c66091 in xul (+0x26090) (0x0032e898) 14 0x555cbc1b on_stop_nsrequest+0x8a(This=0xed4da0, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8d8) 15 0x555cbc1b on_stop_nsrequest+0x8a(This=0x10, result=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1011] in mshtml (0x0032e8e8) 16 0x555cca5f nsChannelBSC_stop_binding+0x1e(bsc=0x126fe08, result=0x555d31c0) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1184] in mshtml (0x0032e928) 17 0x555cb126 BindStatusCallback_OnStopBinding+0x35(iface=0x126fe08, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:360] in mshtml (0x0032e968) 18 0x68f3f838 BindStatusCallback_OnStopBinding+0x87(iface=0x129b090, hresult=0xffffffff80004004, szError=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindctx.c:178] in urlmon (0x0032e988) 19 0x68f40c5d stop_binding+0x3c(binding=0x129b118, hres=0xffffffff80004004, str=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:221] in urlmon (0x0032e9d8) 20 0x68f41dde InternetProtocolSink_ReportResult+0x8d(iface=0x129b11c, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/binding.c:1149] in urlmon (0x0032ea28) 21 0x68f47abd BPInternetProtocolSink_ReportResult+0xec(iface=0x129b578, hrResult=0xffffffff80004004, dwError=0, szResult=0x0(nil)) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:1184] in urlmon (0x0032ea48) 22 0x68f50b5d report_result+0x3c() in urlmon (0x0032ea58) 23 0x68f50c1d protocol_abort+0x2c(protocol=0x2078c0, reason=0xffffffff80004004) [/home/julliard/wine/wine/dlls/urlmon/protocol.c:439] in urlmon (0x0032ea98) 24 0x68f4cbd4 HttpProtocol_Abort+0x73(iface=0x129b764, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/http.c:445] in urlmon (0x0032eae8) 25 0x68f452b0 ProtocolHandler_Abort+0x5f(iface=0x129b580, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:662] in urlmon (0x0032eb38) 26 0x68f459db BindProtocol_Abort+0x7a(iface=0x129b568, hrReason=0xffffffff80004004, dwOptions=0) [/home/julliard/wine/wine/dlls/urlmon/bindprot.c:429] in urlmon (0x0032eb68) 27 0x68f4140b Binding_Abort+0x5a(iface=0x129b118) [/home/julliard/wine/wine/dlls/urlmon/binding.c:892] in urlmon (0x0032eb88) 28 0x555ca834 set_window_bscallback+0x23(window=0xed2b98, callback=(nil)) [/home/julliard/wine/wine/dlls/mshtml/navigate.c:1349] in mshtml (0x0032ebd8) 29 0x555c54a1 HTMLWindow2_Release+0x70(iface=0xed2ba8) [/home/julliard/wine/wine/dlls/mshtml/htmlwindow.c:228] in mshtml (0x0032ec18) 30 0x55580881 CustomDoc_Release+0x80(iface=0x129db0) [/home/julliard/wine/wine/dlls/mshtml/htmldoc.c:2021] in mshtml (0x0032ec38) 31 0x5557ea04 HTMLDocument_Release+0x13(iface=0x129ca8) [/home/julliard/wine/wine/dlls/mshtml/mshtml_private.h:376] in mshtml (0x0032fd08) 32 0x686a82f5 perform_test+0xd34(test=0x686c24c3) [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:348] in mshtml_test (0x0032fd38) 33 0x686a838e func_htmllocation+0x3d() [/home/julliard/wine/wine/dlls/mshtml/tests/htmllocation.c:360] in mshtml_test (0x0032fd88) 34 0x686b535e run_test+0x15d(name=<is not available>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:556] in mshtml_test (0x0032fe48) 35 0x686b5557 main+0x156(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/mshtml/tests/../../../include/wine/test.h:624] in mshtml_test (0x0032fe90) 36 0x686b60dc __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in mshtml_test (0x0032fea8) 37 0x7b856c4c call_process_entry+0xb() in kernel32 (0x0032fee8) 38 0x7b85914b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:994] in kernel32 (0x0032fef8) 39 0x7bc72b80 call_thread_func+0xb() in ntdll (0x0032ffc8) 40 0x7bc72d50 call_thread_entry_point+0x6f(entry=0x7b8590f0, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0032ffe8) 41 0x7bc4da6a start_process+0x29(kernel_start=0x7b8590f0) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) 0x555d325a handle_load+0x9a [/home/julliard/wine/wine/dlls/mshtml/nsevents.c:226] in mshtml: movl 0x110(%edi),%eax 226 if(doc_obj->nscontainer->editor_controller) { -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: cryptui: Fix a crash with certification path (resend)
by Alexandre Julliard 06 Oct '10

06 Oct '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data) > */ > tvis.u.item.iImage = 2; > } > - else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus. > - dwErrorStatus == 0) > + else if (i > 1 && > + provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0) What is this change for? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [1/2] explorer: Do not set the caption for "Shell_TrayWnd", some applications depend on it being empty.
by Alexandre Julliard 06 Oct '10

06 Oct '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > The bug #20129 lists one of such applications. > > It does FindWindow("Shell_TrayWnd", "") and expects that it returns a valid > tray window handle. Currently FindWindow() is broken, but my next patch makes > the above call succeed. This will cause the stand-alone tray window to not have a title, that doesn't look nice. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: cryptui: Fix a crash with certification path
by Juan Lang 06 Oct '10

06 Oct '10

Hi André, I see your patch didn't get committed. In case it's waiting for a comment from me, it looks fine: I assume you've imported a certificate that isn't otherwise trusted, and viewing it results in a crash? I don't see the crash here. Thanks, --Juan

2 1

Re: [7/7] msi/tests: Fix some test failures on 64-bit.
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5900 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10500: Test failed: key not created

1 0

Re: [2/6]strmbase: move enumpins from quartz to strmbase
by Alexandre Julliard 06 Oct '10

06 Oct '10

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/qcap/Makefile.in | 1 - > dlls/qcap/enumpins.c | 186 ------------------------------------- > dlls/qcap/qcap_main.h | 8 -- > dlls/qcap/vfwcapture.c | 28 +++++- > dlls/quartz/Makefile.in | 1 - > dlls/quartz/dsoundrender.c | 26 ++++-- > dlls/quartz/enumpins.c | 211 > ------------------------------------------ > dlls/quartz/filesource.c | 32 +++++-- > dlls/quartz/nullrenderer.c | 25 +++-- > dlls/quartz/parser.c | 29 ++++-- > dlls/quartz/quartz_private.h | 3 - > dlls/quartz/transform.c | 27 ++++-- > dlls/quartz/videorenderer.c | 25 +++-- > dlls/strmbase/Makefile.in | 1 + > dlls/strmbase/enumpins.c | 207 > +++++++++++++++++++++++++++++++++++++++++ > include/wine/strmbase.h | 6 + > 16 files changed, 346 insertions(+), 470 deletions(-) > delete mode 100644 dlls/qcap/enumpins.c > delete mode 100644 dlls/quartz/enumpins.c > create mode 100644 dlls/strmbase/enumpins.c It doesn't work here: ../../../tools/runtest -q -P wine -M quartz.dll -T ../../.. -p quartz_test.exe.so avisplitter.c && touch avisplitter.ok avisplitter.c:164: Test failed: pins[1] = (nil) avisplitter.c:210: Tests skipped: Could not read test file "test.avi", skipping test make: *** [avisplitter.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/7] msi: Use strcmpW instead of lstrcmpW to compare database strings.
by Alexandre Julliard 06 Oct '10

06 Oct '10

Hans Leidekker <hans(a)codeweavers.com> writes: > An installer I have here uses \1 and \2 as delimiters in property strings. > It turns out that on Wine lstrcmp("\1", "\2") returns 0, not -1, which causes > the string table implementation to return the wrong value. This should be fixed, > but it's better if database string comparisons do not depend on thread locale. Yes, but isn't it supposed to follow Unicode sorting rules instead of simply comparing code point values? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/7] msi: Add package validation tests.
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5898 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10164: Test failed: key not removed install.c:10174: Test failed: key not removed install.c:10185: Test failed: key not removed install.c:10476: Test failed: key not created

1 0

Re: [PATCH 9/9] urlmon: Added IInternetProtocolEx support to http protocol handler.
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5895 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:977: Test failed: hrResult = 800c0005, expected: 00000000 Timeout

1 0

Re: [PATCH 6/9] urlmon: Added IBinding::Abort and binding without callback tests.
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5893 Your paranoid android. === WXPPROSP3 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K3R2SESP2 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === WVISTAADM (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W2K8SE (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PRO (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (32 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable No test summary line found === W7PROX64 (64 bit url) === url.c:490: Test failed: expected Read url.c:492: Test failed: expected OnProgress_DOWNLOADINGDATA url.c:493: Test failed: expected OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1428: Test failed: unexpected call OnProgress_DOWNLOADINGDATA url.c:1597: Test failed: unexpected call OnDataAvailable url.c:1597: Test failed: unexpected call OnDataAvailable

1 0

Re: [PATCH 1/9] urlmon: Return correct error in get_protocol_handler for unknown protocol types.
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5892 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:459: Test failed: expected ReportProgress_SENDINGREQUEST

1 0

Re: [PATCH 3/3] d3d9/tests: Add window proc tests for switching between fullscreen and windowed.
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5888 Your paranoid android. === W2K8SE (32 bit device) === device.c:2473: Test failed: Expected foreground window 00040182, got 0001004C. device.c:2611: Test failed: Expected foreground window 00030114, got 0001004C. === W7PROX64 (64 bit device) === device.c:2473: Test failed: Expected foreground window 0000000000020198, got 0000000000010092. device.c:2611: Test failed: Expected foreground window 0000000000030198, got 0000000000010092.

1 0

Re: [1/5] mscoree: Implement ICLRMetaHost_GetRuntime.
by Alexandre Julliard 06 Oct '10

06 Oct '10

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > This will cause the tests to fail if Mono is not available. We'll have to start providing a Mono package then. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32(10/10): Set correct error when encountering unsupported critical extensions in the base and SSL policy
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5874 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4117: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 4)
by Mike Kaplinskiy 06 Oct '10

06 Oct '10

There are still a few style issues with your patch. You have inconsistent spacing after ifs ("if (" vs "if("), missing spaces after commas, and a few more "}else{"s. You also create a few blocks for no reason other than to get around the C declarations on top of block rule. Please organize these in tune with the surrounding code. Only create a "useless" block (ie a block without a control flow statement) if there is an #ifdef around it with other implementations. Also please don't do things like "if (x) { do {...} while(x); }". More importantly you seem to be missing the tests for this. (sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post) Mike. On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" <rm(a)eightyfive.net> wrote: > Try 2: > - Exchange Patches #2 and #3. > - Fix errors in formatting > - Check that fopen succeeds, return default value otherwise > - default return value is now 0 for all parser functions > > Try 3: > - Add missing checks for valid processor mask and cache values > > Try 4: > - More comments in the parsing code > - Some additional code cleanup > > --- > dlls/ntdll/nt.c | 343 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 343 insertions(+), 0 deletions(-) >

1 0

Re: crypt32/tests(8/10): Add macros to declare tests
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5873 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(7/10): Add name to test to help identify test failures
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5872 Your paranoid android. === W98SE (32 bit chain) === chain.c:4117: Test failed: ignoredInvalidDateBasePolicyCheck[0](#0001): expected 800b0101, got 800b0102 chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102 chain.c:4117: Test failed: iTunesPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: googlePolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0101 chain.c:4117: Test failed: opensslPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: opensslPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithMatchingName[0](#0004): expected 00000000, got 800b0109 chain.c:4117: Test failed: stanfordPolicyCheckWithoutMatchingName[0](#0004): expected 800b010f, got 800b0109 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4108: Test failed: invalidExtensionPolicyCheck[0](#0001): expected 800b0105, got 800b0102

1 0

Re: crypt32(6/10): Set CERT_TRUST_HAS_NOT_SUPPORTED_CRITICAL_EXT when appropriate
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5871 Your paranoid android. === W98SE (32 bit chain) === chain.c:4113: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(5/10): Test the base and SSL policies against a certificate with an invalid critical extension
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5870 Your paranoid android. === W98SE (32 bit chain) === chain.c:4113: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2 === WNT4WSSP6 (32 bit chain) === chain.c:4105: Test failed: #0001[0]: expected 800b0105, got 800b0102

1 0

Re: crypt32/tests(4/10): Test invalid critical extension in intermediate cert
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5869 Your paranoid android. === W98SE (32 bit chain) === chain.c:4108: Test failed: #0001[0]: expected 800b0101, got 800b0102 chain.c:2752: Test failed: Chain 31: expected error 00000001, got 00000003. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,1]: expected error 00000000, got 00000002. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2674: Test failed: Chain 31, element [0,2]: expected error 00000000, got 00000001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2752: Test failed: Chain 32: expected error 00000001, got 00010001. 00000020 is expected if no valid Verisign root certificate is available. chain.c:2712: Test failed: Chain 32: expected 3 elements, got 2

1 0

Re: crypt32(2/10): Improve error checking for the base policy
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5868 Your paranoid android. === W98SE (32 bit chain) === chain.c:4015: Test failed: #0001[0]: expected 800b0101, got 800b0102

1 0

Re: crypt32/tests(1/10): Add more tests of verifying the base policy, including flags to ignore certain errors
by testbot＠testbot.winehq.org 06 Oct '10

06 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5867 Your paranoid android. === W98SE (32 bit chain) === chain.c:4012: Test failed: #0001[0]: expected 800b0101, got 800b0102

1 0

Re: (6th try) winhlp32: Added Hebrew translation
by Paul Vriens 05 Oct '10

05 Oct '10

Hi Yaron, I'm see this one is still not applied. Maybe because there are still some small issues? See below. On 10/03/2010 11:12 PM, Yaron Shahrabani wrote: > +LANGUAGE LANG_HEBREW, SUBLANG_DEFAULT This line should go, it's redundant (it's already stated at the beginning). This line was present in the English resources because there is a difference between SUBLANG_DEFAULT and SUBLANG_NEUTRAL in that resource file. For example 'colors' vs. 'colours'. > + > +IDD_INDEX DIALOG 0, 0, 200, 190 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU | WS_EX_LAYOUTRTL You should move the WS_EX_LAYOUTRTL to an EXSTYLE like the IDD_SEARCH_DIALOG below. Adding it to the STYLE has no effect. > +FONT 8, "MS Shell Dlg" > +CAPTION "מפתח" > +{ > + LISTBOX IDC_INDEXLIST, 10, 10, 180, 150, LBS_NOINTEGRALHEIGHT | WS_VSCROLL | WS_BORDER > +} > + > +IDD_SEARCH DIALOG 0, 0, 200, 190 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +EXSTYLE WS_EX_LAYOUTRTL > +FONT 8, "MS Shell Dlg" -- Cheers, Paul.

1 0

Re: user32/tests: Test FindWindowEx for empty window title (try 2)
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5829 Your paranoid android. === W98SE (32 bit win) === win.c:2970: Test failed: message 000f available win.c:2982: Test failed: message 000f available win.c:2991: Test failed: message 000f available win.c:3000: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH] shlwapi: Handle URL_WININET_COMPATIBLITY flag in UrlCanonicalize
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5828 Your paranoid android. === W98SE (32 bit url) === url.c:746: Test failed: UrlCanonicalizeA dwFlags 0x00000000 url 'c:dir\file' Expected "file:///c:dir/file", but got "file:///c:/dir/file", index 46

1 0

winmm/tests: Don't test the non-default Midi devices if the 'PreferredOnly' Windows setting is set.
by Joerg-Cyril.Hoehle＠t-systems.com 05 Oct '10

05 Oct '10

Hi, a few month ago when the discussion about "PreferredOnly" registry setting came up, I queried Google and found that many more users use this setting than one may believe - i.e. it is not exotic. Therefore, I don't think it's that great an idea to reduce the number of devices that the tests stress using that method: we'll get less feedback from a number of real machines. OTOH, I have no solution to the vmware MIDI trouble on Francois' machines. Regards, Jörg Höhle

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel