- wine-devel - winehq.org

Re: msi: Put the uninstall key for 32-bit packages under Wow6432Node on 64-bit.
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5824 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10427: Test failed: key not created

2 1

Re: [2/3] kernel32/process: Implement GetLogicalProcessorInformation using NtQuerySystemInformation
by Vitaliy Margolen 05 Oct '10

05 Oct '10

On 10/05/2010 04:46 AM, Rudolf Mayerhofer wrote: > --- > dlls/kernel32/process.c | 21 ++++++++++++++++++--- > 1 files changed, 18 insertions(+), 3 deletions(-) > Please exchange patches 2 and 3. And everywhere in your patches, please stick to _THE SAME_ formatting as the rest of the file you editing. Examples: > + if (status != STATUS_SUCCESS) > + { > + if( status == STATUS_INFO_LENGTH_MISMATCH ) Here you adding 2 differently formatted if () statements. > +static ULONG_PTR sysfs_cpu_topology_getmap(int cpu, const char *type) > +{ > + char buf[256]; > + FILE *fd; > + ULONG_PTR result; > + sprintf(buf, "/sys/devices/system/cpu/cpu%d/topology/%s",cpu,type); Please add empty line between variable declarations and the rest of the code. All commas should always be followed by a space. > + fd = fopen(buf,"r"); > + if(fscanf(fd,"%lx",&result) != 1) You are not checking if fopen() succeeded. > +static int sysfs_cpucache_getint(int cpu, int cache, const char *type) > +{ > + }else{ > + val = -1; > + } > + fclose(fd); > + return val; > +} > ... > + BYTE level = sysfs_cpucache_getint(cpucount,cachecount,"level"); Don't mix signed and unsigned integers. Especially that you return -1 in case of error. In that entire file curly braces go on a separate line. Vitaliy.

1 0

[1/2] user32: fix FindWindowEx behavior if window name is an empty charachter
by Louis Lenders 05 Oct '10

05 Oct '10

>It would be better to avoid duplicate GetWindowTextW() calls. I thought a long time how to fix this, but i couldn't find another way than this one, because we need to find out whether or not the window title is empty, and afaik we can only do that by calling GetWindowText (again). If you have another way that i overlooked, please let me know Regards Louis

3 2

Re: winex11: Add support for animated cursors in X11 driver (try 5).
by Alexandre Julliard 05 Oct '10

05 Oct '10

Erich Hoover <ehoover(a)mines.edu> writes: > + imgs[nFrames++] = image; > + if (!(imgstmp = HeapReAlloc( GetProcessHeap(), 0, imgs, nFrames*sizeof(XcursorImage*) ))) goto cleanup; > + imgs = imgstmp; This is still broken. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ImmReleaseContext() function implementation
by Aric Stewart 05 Oct '10

05 Oct '10

I do not believe this is correct. You would be destroying the context every time it is released and that is clearly not what we want to be doing ass ImmGetContext and ImmReleaseContext as a pair are called over and over again in a typical application. -aric On 10/4/10 1:25 PM, Mikhail Gorbunov wrote: > This patch implements (with a basic sanity check) a behaviour of > ImmReleaseContext() > function as described in msdn and in the way ImmGetContext() has already been > impleneted. > > From 56f78bcd9584350b456ca0b0514a357b7ee8cdfd Mon Sep 17 00:00:00 2001 > From: Mikhail Gorbunov<mikhail.gorbunov(a)gmail.com> > Date: Mon, 4 Oct 2010 21:47:17 +0400 > Subject: [PATCH] ImmReleaseContext() function implementation > > --- > dlls/imm32/imm.c | 24 ++++++++++++++++++------ > 1 files changed, 18 insertions(+), 6 deletions(-) > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 28f482c..87b4c14 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -2009,13 +2009,25 @@ BOOL WINAPI ImmRegisterWordW( > */ > BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) > { > - static int shown = 0; > + TRACE("(%p, %p)\n", hWnd, hIMC); > > - if (!shown) { > - FIXME("(%p, %p): stub\n", hWnd, hIMC); > - shown = 1; > - } > - return TRUE; > + if (hIMC) > + { > + InputContextData *data = hIMC; > + > + if (data->IMC.hWnd != hWnd) > + { > + FIXME("(%p, %p): data->IMC.hWnd = %p :: err\n", > + hWnd, hIMC, data->IMC.hWnd); > + return TRUE; > + } > + else > + { > + return ImmDestroyContext(hIMC); > + } > + } > + else > + return TRUE; > } > > /***********************************************************************

1 0

Re: [PATCH 1/6] urlmon: Report error on synchronous bindings that don't have a cache file and are not read in callback.
by Alexandre Julliard 05 Oct '10

05 Oct '10

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 17 ++++++++++++----- > 1 files changed, 12 insertions(+), 5 deletions(-) This breaks the gameux tests: ../../../tools/runtest -q -P wine -M gameux.dll -T ../../.. -p gameux_test.exe.so gameexplorer.c && touch gameexplorer.ok gameexplorer.c:571: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:589: Test failed: IGameExplorer::AddGame failed (error 0x80004005) gameexplorer.c:640: Test failed: IGameExplorer2::InstallGame failed (error 0x80004005) gameexplorer.c:643: Test failed: cannot find game with GDF path L"Z:\\home\\julliard\\wine\\wine\\dlls\\gameux\\tests\\gameux_test.exe" in scope 2 make: *** [gameexplorer.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)
by Rudolf Mayerhofer 05 Oct '10

05 Oct '10

>I don't know much about kernel32/ntdll, but I'm pretty sure that you >could get this to work through ntdll. NtQuerySystemInformation with >SystemProcessorInformation/SystemLogicalProcessorInformation (see >http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/Syste…) >should help. http://native-nt-toolkit.googlecode.com/svn/trunk/ndk/extypes.h >(read, don't copy) seems to have a pretty exhaustive set of >definitions, but even that's not complete. Some tests for the NT >version would be useful. > >Mike. SystemLogicalProcessorInformation seems to be the right SystemClass for NtQuerySystemInformation. But here's the Problem. I don't have any idea how i could any information about the struct returned by calling NtQuerySystemInformation with SystemLogicalProcessorInformation (= 73). The only windows machine i have access to a the moment keeps throwing status 0xC0000005 (ACCESS_VIOLATION) at me which doesn't help at all and i'm pretty much stuck right now. If i could get my hands on the struct returned by NtQuerySystemInformation it should be easy to change the patch to do the parsing in ntdll and just call that from kernel32.

2 2

Re: [1/2] user32: fix FindWindowEx behavior if window name is an empty charachter
by Dmitry Timoshkov 05 Oct '10

05 Oct '10

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > @@ -1756,6 +1756,10 @@ HWND WINAPI FindWindowExW( HWND parent, HWND child, LPCWSTR className, LPCWSTR t > { > while (list[i]) > { > + /* Handle special case where empty title bar or no title bar exists, so GetWindowsText would return NULL > + but if title is also an empty char we still have a match */ > + if (!GetWindowTextW( list[i], buffer, len + 1 ) && !title[0]) break; > + > if (GetWindowTextW( list[i], buffer, len + 1 ) && !strcmpiW( buffer, title )) break; > i++; > } It would be better to avoid duplicate GetWindowTextW() calls. -- Dmitry.

1 0

Re: psapi/tests: macro cleanup
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5813 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:111: Test failed: cbNeeded=108

1 0

Re: [PATCH] comctl32/tests: Add tests for negative subitems independent of local settings
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5811 Your paranoid android. === W7PROX64 (64 bit listview) === listview.c:4449: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4454: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

1 0

Re: [2/2] user32/tests: Test FindWindowEx for empty window title
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5803 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2684: Test failed: GetActiveWindow() = 00000000 win.c:2684: Test failed: GetFocus() = 00000000 win.c:2710: Test failed: GetActiveWindow() = 00000000 win.c:2710: Test failed: GetFocus() = 00000000 win.c:2769: Test failed: GetActiveWindow() = 00000000 win.c:2769: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH 2/3] urlmon: Added Abort tests.
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5782 Your paranoid android. === W2K3R2SESP2 (32 bit protocol) === protocol.c:824: Test failed: hrResult = 800c0005, expected: 00000000 Timeout === WVISTAADM (32 bit protocol) === protocol.c:509: Test failed: unexpected call Switch

1 0

Re: [PATCH 3/3] urlmon: Added Abort support to BindProtocol.
by testbot＠testbot.winehq.org 05 Oct '10

05 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5783 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: include: Added d3d10_1.idl.
by Rico Schüller 04 Oct '10

04 Oct '10

Am 02.10.2010 15:29, schrieb Jacek Caban: +typedef enum D3D10_SRV_DIMENSION1 +{ + D3D10_1_SRV_DIMENSION_UNKNOWN = 0, ... + D3D10_1_SRV_DIMENSION_TEXTURECUBE = 9, + D3D10_1_SRV_DIMENSION_TEXTURECUBEARRAY = 10 +} D3D10_SRV_DIMENSION1; You probably might add those to d3dcommon.h and only add a typedef. It was changed in one of the sdks. Cheers Rico

2 2

Re: winspool.drv: return maximum possible size of the buffer when no buffer specified
by Alexandre Julliard 04 Oct '10

04 Oct '10

Vitaly Perov <vitperov(a)etersoft.ru> writes: > @@ -1398,7 +1398,7 @@ static void convert_printerinfo_W_to_A(LPBYTE out, LPBYTE pPrintersW, > dmA = DEVMODEdupWtoA(piW->pDevMode); > if (dmA) { > /* align DEVMODEA to a DWORD boundary */ > - len = (4 - ( (DWORD_PTR) ptr & 3)) & 3; > + len = ptr ? (4 - ( (DWORD_PTR) ptr & 3)) & 3 : 3; That doesn't make any sense. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: psapi/tests: remove an ugly macro
by testbot＠testbot.winehq.org 04 Oct '10

04 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5776 Your paranoid android. === WVISTAADM (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=100 === W2K8SE (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=100 === W7PRO (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=96 === W7PROX64 (32 bit psapi_main) === psapi_main.c:116: Test failed: cbNeeded=108

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line [try2]
by Alexandre Julliard 04 Oct '10

04 Oct '10

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > -@pwd@>echo Tests for cmd's builtin commands@todo_space@ > +@pwd@>echo Tests for cmd's builtin commands You'll need to define a @space@ symbol, normal trailing spaces will get mangled. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11: choose header exclusiv
by Alexandre Julliard 04 Oct '10

04 Oct '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -29,8 +29,7 @@ > > #ifdef HAVE_X11_EXTENSIONS_XF86VMODE_H > #include <X11/extensions/xf86vmode.h> > -#endif > -#ifdef HAVE_X11_EXTENSIONS_XF86VMPROTO_H > +#elif defined (HAVE_X11_EXTENSIONS_XF86VMPROTO_H) > #include <X11/extensions/xf86vmproto.h> > #endif This doesn't make sense, all it will most likely achieve is to disable the gamma support. -- Alexandre Julliard julliard(a)winehq.org

1 0

mono packaging, for wine packagers or anyone else who wants to follow along
by Vincent Povirk 04 Oct '10

04 Oct '10

Buried in the 1.3.4 announcement is a tiny, insignificant little change that makes it possible for distributors to package Mono for Wine: mscoree: Search for Mono in some predefined paths before using the registry. As happy as I am to have sneaked this in under the radar, as it were, I guess I'm going to have to tell someone if it's ever going to be useful. I have no plans to make an official Wine Mono distribution. It should be easy enough for anyone to build. We currently do not require any changes in Mono for use with Wine. When we do (and it will be soon), I will try very hard to get the things we need merged upstream. Any managed libraries we need instead of or in addition to those shipped with Mono will have to go in Wine. We don't need a fork yet, and I hope we can keep it that way. Mono installs are generally self-contained and do not interfere with each other. Mono does not have to be installed into a bottle before it can be used. Therefore, I have not programmed any sort of install process into Wine. It will simply search for Mono as needed. If you are a distributor, here is how I recommend you distribute Mono for use with Wine: Download and extract the mono 2.6.7 source tarball from http://ftp.novell.com/pub/mono/sources/mono/mono-2.6.7.tar.bz2 Use the instructions at http://wiki.winehq.org/Mono to cross-compile Mono 2.6.7 using mingw32. Tweak the script if you have to (or just want to), but consider contributing any fixes you have to make back to winezeug. This will create a directory named mono-2.6.7. The contents of that directory should be installed to /usr/share/mono/mono-1.0. To make sure this worked, you should try a simple "Hello World" .NET application in Wine. Wikipedia has an example at https://secure.wikimedia.org/wikipedia/en/wiki/C_sharp_programming_language… that you should be able to save as a .cs file and compile to a .exe file using gmcs. If all is well, you should be able to run that exe file in a clean Wine prefix. In the future, we'll need a mono-2.0 directory as well, so we can keep using newer versions of Mono and get .NET 4.0 support. But we're not there yet. In case all these numbers have not confused you yet, the current version of Mono is 2.6.7. This version uses the Mono Embedding API version 1.0, which is why it needs to be placed in a directory named mono-1.0. It normally includes .NET 1.1 and 2.0 runtimes. It can optionally be compiled with a 4.0 runtime as well, but I don't recommend it. I'm expecting to see Mono 2.8 released "soon". That version will use the Embedding API version 2.0, which Wine can't support yet, but when the time comes it will need to be in a directory named mono-2.0. It will include .NET 2.0 and 4.0 runtimes. .NET 3.0 and 3.5 are not runtimes, which is why they were not included in that list. They use the .NET 2.0 runtime. While Mono 2.8 (and eventually 3.0) is the way forward for .NET 2.0 and 4.0 support, we'll need to also have the 2.6 series available so that we can have a .NET 1.1 runtime. Wine will detect which versions are available and what runtimes they have using a system that I'm working on and hope to have ready "soon", and it will select the correct runtime for whatever it's trying to run, or whatever the program selects using the .NET embedding API. (Also coming soon: the .NET embedding API.) I'm treating Mono as an optional dependency, much like the many native libraries Wine already uses. If it's not there, Wine will gracefully report failure to applications that try to use it, which probably won't work, and print some things to the console. I plan to send some changes soon that happen to cause a Wine without Mono to fail some tests, so I do consider an install that's missing Mono to be broken. But for the most part, the user experience will remain the same as it was before if Mono is missing.

2 1

Question on use of TextMetricsW
by James McKenzie 04 Oct '10

04 Oct '10

All: I am running code like the following in a richedit control to set the font to Courier 12 point font: + static const WCHAR courier[] = {'C','o','u','r','i','e','r',0}; + testFont1 = CreateFontW (12,0,0,0,FW_LIGHT, 0, 0, 0, ANSI_CHARSET, + OUT_DEFAULT_PRECIS, CLIP_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH | + FF_DONTCARE, courier); + + /*Set test font to be Courier font */ + SendMessageW(hwndRichEdit, WM_SETFONT, (WPARAM)testFont1, MAKELPARAM(TRUE, 0)); + /*Verify font is set */ + SendMessageW(hwndRichEdit, EM_GETCHARFORMAT, SCF_DEFAULT, (LPARAM) &CharFont1Unicode); + GetObjectW(testFont1, sizeof(LOGFONTW), &sentLogFont); + ok (!lstrcmpW(sentLogFont.lfFaceName, CharFont1Unicode.szFaceName), "WM_SETFONT set wrong font. " \ + "Font was set to %s or %s, was supposed to be \"Courier\".\n", wine_dbgstr_w(CharFont1Unicode.szFaceName), wine_dbgstr_w(sentLogFont.lfFaceName)); + + ret = GetTextMetricsW (hdc, &tmw); + ok (ret, "GetTextMetricsW failed\n"); + + ok (7 == tmw.tmAveCharWidth, "Average Character Width for Courier 12 is %d\n", tmw.tmAveCharWidth); I also set the font to MS Sans Serif, and two different font sizes for Arial. However, the tmAveCharWidth value remains at 7 and I am of the opinion that this should change for each font change and also for the font size change. Am I doing something improper? Should I clear the tmw structure between calls to GetTextMetricsW? When I run this on native WindowsXP (which I have access to) the average character width changes to 9, but remains the same for all four font types. TTIA. James McKenzie

2 3

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)
by Mike Kaplinskiy 03 Oct '10

03 Oct '10

On Sun, Oct 3, 2010 at 10:25 AM, Rudolf Mayerhofer <rm(a)eightyfive.net> wrote: >>A rewrite of my previously sent patches in order to avoid changing >>SYSTEM_CPU_INFORMATION. > >>This patch supersedes my previously sent patches: >>[PATCH1/3] include/winternl: Add Logical Processor Information to >>SYSTEM_CPU_INFORMATION (try 3) >>[PATCH2/3] kernel32/process: Implement GetLogicalProcessorInformation() (try > 2) >>[PATCH3/3] ntdll: Retrieve Logical Processor Information from SysFS (try 4) > > Try 2 removes a FIXME which is not needed. > Try 3 changes a FIXME to a WARN when an unknown cache type is found > > > --- > dlls/kernel32/process.c | 272 > ++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 270 insertions(+), 2 deletions(-) > > > > > I don't know much about kernel32/ntdll, but I'm pretty sure that you could get this to work through ntdll. NtQuerySystemInformation with SystemProcessorInformation/SystemLogicalProcessorInformation (see http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/Syste…) should help. http://native-nt-toolkit.googlecode.com/svn/trunk/ndk/extypes.h (read, don't copy) seems to have a pretty exhaustive set of definitions, but even that's not complete. Some tests for the NT version would be useful. Mike.

1 0

Re: [3/5] mscoree: Add test for creating CLRMetaHost.
by Greg Geldorp 03 Oct '10

03 Oct '10

> While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=5753 > > Your paranoid android. > > === WINEBUILD (build) === > Make in include dir failed Caused by a problem in TestBot, should be fixed now. Greg.

1 0

Re: [5/5] mscoree: Add a test that enumerates .NET runtimes.
by testbot＠testbot.winehq.org 03 Oct '10

03 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5754 Your paranoid android. === WINEBUILD (build) === Make in include dir failed

1 0

Re: [3/5] mscoree: Add test for creating CLRMetaHost.
by testbot＠testbot.winehq.org 03 Oct '10

03 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5753 Your paranoid android. === WINEBUILD (build) === Make in include dir failed

1 0

Re: (5th try) winhlp32: Added Hebrew translation
by Paul Vriens 03 Oct '10

03 Oct '10

On 10/03/2010 05:04 PM, Yaron Shahrabani wrote: > + > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > + Hi Yaron, This piece should go. And I still have an apply warning for your Makefile.in patch. -- Cheers, Paul.

1 0

Re: cmd: Add a space at the end of the first echo'ed batch line
by Jacek Caban 03 Oct '10

03 Oct '10

On 10/3/10 1:18 PM, Alexandre Goujon wrote: > --- > programs/cmd/tests/batch.c | 2 +- > programs/cmd/wcmdmain.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/programs/cmd/tests/batch.c b/programs/cmd/tests/batch.c > index cc8c020..d7a5e84 100644 > --- a/programs/cmd/tests/batch.c > +++ b/programs/cmd/tests/batch.c > @@ -131,7 +131,7 @@ static const char *compare_line(const char *out_line, const char *out_end, const > }else if(exp_ptr+sizeof(todo_space_cmd)<= exp_end > && !memcmp(exp_ptr, todo_space_cmd, sizeof(todo_space_cmd))) { > exp_ptr += sizeof(todo_space_cmd); > - todo_wine ok(*out_ptr == ' ', "expected space\n"); > + ok(*out_ptr == ' ', "expected space\n"); @todo_space@ is meant to do tests in todo_wine block. You should change @todo_space@ to spec in .exp file instead. If we're convinced that the whole keyword is not useful anymore, the whole handling code should be removed (although I think we'd better keep it). > if(out_ptr< out_end&& *out_ptr == ' ') > out_ptr++; > continue; > diff --git a/programs/cmd/wcmdmain.c b/programs/cmd/wcmdmain.c > index b50512e..247457a 100644 > --- a/programs/cmd/wcmdmain.c > +++ b/programs/cmd/wcmdmain.c > @@ -1779,8 +1779,11 @@ WCHAR *WCMD_ReadAndParseLine(WCHAR *optionalcmd, CMD_LIST **output, HANDLE readF > if (context) handleExpansion(extraSpace, FALSE, NULL, NULL); > /* Show prompt before batch line IF echo is on and in batch program */ > if (context&& echo_mode&& extraSpace[0]&& (extraSpace[0] != '@')) { > + const WCHAR spc[] = {' ','\0'}; > WCMD_show_prompt(); > WCMD_output_asis(extraSpace); > + /* I don't know why Windows puts a space here but it does */ > + WCMD_output_asis(spc); More tests would be nice. Jacek

2 1

Re: [PATCH1/3] include/winternl: Add Logical Processor Information to SYSTEM_CPU_INFORMATION
by Dmitry Timoshkov 03 Oct '10

03 Oct '10

Rudolf Mayerhofer <rm(a)eightyfive.net> wrote: > /* System Information Class 0x01 */ > +typedef struct _SYSTEM_CPU_CACHE_INFORMATION { > + ULONG ProcessorMask; > + CACHE_DESCRIPTOR CacheInformation; > +} SYSTEM_CPU_CACHE_INFORMATION, *PSYSTEM_CPU_CACHE_INFORMATION; > > typedef struct _SYSTEM_CPU_INFORMATION { > WORD Architecture; > @@ -1100,6 +1104,10 @@ typedef struct _SYSTEM_CPU_INFORMATION { > WORD Revision; /* combination of CPU model and stepping */ > WORD Reserved; /* always zero */ > DWORD FeatureSet; /* see bit flags below */ > + ULONG Cores[64]; /* Contains a Processormask for each physical core. Index is CoreID*/ > + ULONG ProcessorPackages[64]; /* Contains a Processormask for each processorpackage. Index is ProcessorPackage ID*/ > + ULONG NumaNodes[64]; /* Contains a Processormask for each numa node. Index is NumaNodeNumber */ > + SYSTEM_CPU_CACHE_INFORMATION Caches[256]; /* Contains all cpu cache entries found */ > } SYSTEM_CPU_INFORMATION, *PSYSTEM_CPU_INFORMATION; Where does this come from? At least the processor mask is supposed to be an ULONG_PTR. -- Dmitry.

4 8

Re: [PATCH 1/2] mshtml: add support for the HTMLWindow.onunload event.
by Jacek Caban 03 Oct '10

03 Oct '10

On 10/3/10 2:24 PM, Reece Dunn wrote: > Implements HTMLWindow_get/put_onunload. + {unloadW, onunloadW, EVENTT_NONE, DISPID_EVMETH_ONUNLOAD, + EVENT_DEFAULTLISTENER|EVENT_FORWARDBODY} EVENT_DEFAULTLISTENER won't work well here. Same for your onerror patch. Jacek

1 0

Re: oleaut32/tests: added tests for negative fractional variant dates.
by testbot＠testbot.winehq.org 03 Oct '10

03 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5729 Your paranoid android. === W98SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WNT4WSSP6 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2KPROSP4 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WXPPROSP3 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K3R2SESP2 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === WVISTAADM (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W2K8SE (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PRO (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (32 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926 === W7PROX64 (64 bit vartest) === vartest.c:1685: Test failed: expected 0, -5.99998846, got 0, -5.999988425925926

3 3

Git server down?
by Joel Holdsworth 02 Oct '10

02 Oct '10

"nmap source.winehq.org" shows no git port. Any ideas?

3 2

Re: cabinet/tests: Reformated output in case of test failure
by testbot＠testbot.winehq.org 02 Oct '10

02 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5725 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH] winmm/tests: Set a struct member to 0 is obsolete, after adding a memset
by testbot＠testbot.winehq.org 02 Oct '10

02 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5717 Your paranoid android. === W7PRO (32 bit midi) === midi.c:238: Test failed: bad message 1e/0 from midiOutOpen, expect 3c7/0 midi.c:295: Test failed: bad message 1e/0 from midiOutLong unprepared, expect 0/feedf00d midi.c:321: Test failed: bad message 1e/0 from midiOutClose, expect 3c8/0 midi.c:322: Test failed: bad message 3c7/0 from midiOut over, expect 0/feedf00d midi.c:398: Test failed: bad message 3c8/0 from midiStreamOpen, expect 3c7/0 midi.c:419: Test failed: bad message 3c7/0 from midiOutLong unprepared, expect 0/feedf00d

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 3]
by testbot＠testbot.winehq.org 02 Oct '10

02 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5709 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: mshtml.inf: Add default GeckoCabDir
by Austin English 02 Oct '10

02 Oct '10

On Fri, Oct 1, 2010 at 4:29 AM, Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > diff --git a/dlls/mshtml/mshtml.inf b/dlls/mshtml/mshtml.inf > index d7d2428..dea1712 100644 > --- a/dlls/mshtml/mshtml.inf > +++ b/dlls/mshtml/mshtml.inf > @@ -273,6 +273,7 @@ HKLM,"Software\Microsoft\Internet Explorer\Default Behaviors","TIME",, "CLSID:47 > > [WineGecko.Reg] > HKCU,Software\Wine\MSHTML,"GeckoUrl",,"http://source.winehq.org/winegecko.php" > +HKCU,Software\Wine\MSHTML,"GeckoCabDir",,"/usr/share/wine/gecko/" The directory isn't always /usr/share, it's relative to where wine is installed -- -Austin

6 10

Re: ntdll: Fix 64 bit issue within NTDLL_mergesort().
by Marcus Meissner 02 Oct '10

02 Oct '10

On Sat, Oct 02, 2010 at 12:31:03AM +0200, Stefan Oberhumer wrote: > --- > dlls/ntdll/misc.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > What is the alleged 64bit problem here? left and right are indexes, not sizes actually. Ciao, Marcus > diff --git a/dlls/ntdll/misc.c b/dlls/ntdll/misc.c > index 2d7c0a7..39b0ad3 100644 > --- a/dlls/ntdll/misc.c > +++ b/dlls/ntdll/misc.c > @@ -255,11 +255,11 @@ double CDECL NTDLL_tan( double d ) > > /* Merge Sort. Algorithm taken from http://www.linux-related.de/index.html?/coding/sort/sort_merge.htm */ > static void > -NTDLL_mergesort( void *arr, void *barr, int elemsize, int(__cdecl *compar)(const void *, const void *), > - int left, int right ) > +NTDLL_mergesort( void *arr, void *barr, size_t elemsize, int(__cdecl *compar)(const void *, const void *), > + size_t left, size_t right ) > { > if(right>left) { > - int i, j, k, m; > + size_t i, j, k, m; > m=(right+left)/2; > NTDLL_mergesort( arr, barr, elemsize, compar, left, m); > NTDLL_mergesort( arr, barr, elemsize, compar, m+1, right); > >

1 0

Re: msxml3: Use the existing READYSTAT type instead of creating our own enum READYSTAT (and mixing the two).
by Nikolay Sivov 02 Oct '10

02 Oct '10

> If there_is_ a reason to keep the two separate, I strongly suggest to > use different names (having a typedef READYSTAT as well as an enum by > that name is tricky) and someone needs to look in the mixing of types > that happens in line 277. Makes sense, yes. Honestly I didn't check for this type to be defined already, and it just happens to use the same name.

1 0

Re: oleaut32/tests: added tests for negative fractional variant dates.
by Jeremy Drake 02 Oct '10

02 Oct '10

Oops, those empty parens () were intended to cite the URL for the article. Unfortunately, I can't seem to find it now. However, I found an MSDN page that describes the behavior I am testing here: http://msdn.microsoft.com/en-us/library/system.datetime.fromoadate.aspx This is actually documentation of a .NET method, but see the Remarks section for a description of the format. On Fri, 1 Oct 2010, Jeremy Drake wrote: > I recently read an article () mentioning some of the oddities that show up > in negative variant dates with non-zero (midnight) times, and I noticed > that wine had no test coverage for these cases. Until now. > > > > --- > dlls/oleaut32/tests/vartest.c | 32 +++++++++++++++++++++++--------- > 1 files changed, 23 insertions(+), 9 deletions(-) -- Egotist, n.: A person of low taste, more interested in himself than me. -- Ambrose Bierce, "The Devil's Dictionary"

1 0

Re: wininet(4/5): Support querying the cipher strength of an SSL connection
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5670 Your paranoid android. === W98SE (32 bit http) === No test summary line found === W2K8SE (32 bit http) === http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 0 times http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:771: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:774: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:775: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:776: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:777: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:780: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:899: Test failed: failed to read any of the document http.c:2893: Test failed: InternetQueryOption failed: 12018 http.c:2894: Test failed: expected INTERNET_HANDLE_TYPE_HTTP_REQUEST, got 0 http.c:2899: Test failed: HttpQueryInfo failed http.c:2900: Test failed: expected size > 0 http.c:2974: Test failed: 3062: expected status 11 got 100 http.c:3074: Test failed: expected ERROR_INTERNET_INCORRECT_HANDLE_STATE got 12150 http.c:3081: Test failed: InternetWriteFile failed 12019 http.c:3082: Test failed: expected 0 got 21 http.c:2974: Test failed: 3093: expected status 20 got 100 http.c:2975: Test failed: 3093: expected function 3 got 5 http.c:2974: Test failed: 3101: expected status 21 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:2974: Test failed: 3101: expected status 30 got 70 http.c:2975: Test failed: 3101: expected function 3 got 6 http.c:2978: Test failed: 3101: expected thread 3900 got 3900 http.c:1136: Test failed: file size = 0 http.c:1144: Test failed: file size = 100

2 1

Re: [PATCH] user32: Implement GetMenuBarInfo
by Andrew Eikum 01 Oct '10

01 Oct '10

On 09/24/2010 02:59 PM, Andrew Eikum wrote: > Likely fixes bug 18776. > > This patch is based heavily on a patch from Rein Klazes which was > rejected last summer. According to comments on the bug, Rein's patch > appears abandoned. > <http://www.winehq.org/pipermail/wine-patches/2009-June/074119.html> > > The style has been cleaned up, as well as some minor improvements to the > tests to pass on more platforms. These tests don't fail for me. What failures are you seeing?

2 2

Re: [2/2] msi: Set more 64-bit properties.
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5687 Your paranoid android. === W7PROX64 (64 bit install) === install.c:10040: Test failed: key not removed install.c:10050: Test failed: key not removed install.c:10061: Test failed: key not removed install.c:10352: Test failed: key not created

1 0

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Henri Verbeet 01 Oct '10

01 Oct '10

I think this is going in the right direction, but I still have a couple of comments. On 1 October 2010 00:43, Travis Athougies <iammisc(a)gmail.com> wrote: > +/* Macro to compare two floating point numbers */ > +#define F_EQ(a, b, epsilon) (fabs(a - b) <= epsilon) There's no reason this can't be an inline function. > +/* Color macro to simplify handling of D3DXCOLOR */ > +#define COLOR(r, g, b, a) {r, g, b, a} This looks pretty pointless. > +/* Signals the end of a probe list */ > +#define PROBE_END {-1, 0, {0.0f, 0.0f, 0.0f, 0.0f}, 0.0f, ""} You'll probably want to just pass a count to compute_shader_probe9(). > + /* The x and y coordinate, the width and the height of the region to check. > + When x < 0, this is the last probe */ > + int x, y; There's no width and height here. > + setup_device9(device, &render_target, &readback, D3DFMT_A32B32G32R32F, > + width, height, vshader, pshader); You can't use D3DFMT_A32B32G32R32F without checking if it's available using CheckDeviceFormat() first. > + /* Now go through the probes and check each one */ > + for(;probes->x >= 0;probes++) { > + int index = probes->x + (probes->y * lr.Pitch); > + ok(F_EQ(probes->c.a, pbits_data[index].a, probes->epsilon), > + "In alpha component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.a, pbits_data[index].a); > + ok(F_EQ(probes->c.b, pbits_data[index].b, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.b, pbits_data[index].b); > + ok(F_EQ(probes->c.g, pbits_data[index].g, probes->epsilon), > + "In green component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.g, pbits_data[index].g); > + ok(F_EQ(probes->c.r, pbits_data[index].r, probes->epsilon), > + "In blue component at (%d, %d): %s: Expected %f, got %f\n", probes->x, probes->y, > + probes->message, probes->c.r, pbits_data[index].r); > + } You'll probably want to have a function to compare two D3DXCOLORs. Also, please include the line number of the caller of compute_shader_probe9() somewhere. > + if (caps.PixelShaderVersion >= 0xffff0200) You can still just use D3DPS_VERSION(2, 0) here.

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Jacek Caban 01 Oct '10

01 Oct '10

On 10/1/10 9:59 AM, Reece Dunn wrote: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). We most likely should use to_object here. Please add a comment about it. - return E_FAIL; + return throw_type_error(ctx->parser->script, ei, V_DISPATCH(&constr) ? IDS_OBJECT_EXPECTED : IDS_NO_PROPERTY, NULL); You can't access V_DISPATCH(&constr) here as you don't know if constr is of VT_DISPATCH type. Jacek

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by Ricardo Filipe 01 Oct '10

01 Oct '10

2010/10/1 Reece Dunn <msclrhd(a)googlemail.com>: > Hi, > > try 1 -- throw TypeError if T in 'new T' is not an object. > try 2 -- handle the case when using a null dispatch pointer: `new nullDisp;` > > NOTE: given `new 3;` the engine should report IDS_UNSUPPORTED_ACTION > instead of IDS_NO_PROPERTY but this requires more changes to the code > (constr.vt is VT_EMPTY in both of these cases in engine.c). > > - Reece > > > > wouldn't this be more readable in separate lines? one less condition, just repeating the VariantClear...

1 0

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object. [try 2]
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5679 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: wininet(3/5): Returned certificate strings are always ASCII
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5669 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0

Re: wininet(2/5): Add some secure connection tests
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5668 Your paranoid android. === W98SE (32 bit http) === No test summary line found

1 0

Re: gdiplus: Don't try to free invalid or already-freed images.
by testbot＠testbot.winehq.org 01 Oct '10

01 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5652 Your paranoid android. === WVISTAADM (32 bit image) === No test summary line found

1 0

Wineconf 2010: You're running out of procrastination time...act now! Supplies are limited!
by Jeremy White 30 Sep '10

30 Sep '10

Alright, we're now down to about six weeks out. Soon, flights and the rooms will go up in price. So book your travel now! One new favor - if you are coming, please RSVP here: http://www.winehq.org/wineconf/rsvp/ so we can have counts for meals and such. Again, if money is an issue, please write to me; the Wine Party Fund may be able to help. And, as always, the Wiki page has the latest scoop: http://wiki.winehq.org/WineConf2010 and most chatter is happening on the wineconf(a)winehq.org mailing list (except for pushy loud mouthed types like myself :-/). Cheers, Jeremy

1 0

Re: [PATCH 1/4] gameux: initial implementation of loading game statistics
by Alexandre Julliard 30 Sep '10

30 Sep '10

Mariusz Pluciński <vshader(a)gmail.com> writes: > +static BOOL GAMEUX_isFileExists(LPCWSTR sFile) > +{ > + HANDLE hFile; > + > + hFile = CreateFileW(sFile, GENERIC_READ, 0, > + NULL, OPEN_EXISTING, 0, NULL); > + > + if(hFile == INVALID_HANDLE_VALUE) > + return FALSE; > + > + CloseHandle(hFile); > + return TRUE; > +} This sort of thing is not a good idea in general, even if it had a more grammatically correct function name ;-) If you need to load a file you have to open it anyway, so you can check for errors at that point. Checking for existence beforehand is only doing duplicate work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Error path issues with "gameux: Add implementation of IGameStatisticsMgr::RemoveGameStatistics."
by Joris Huizer 30 Sep '10

30 Sep '10

Hello, I noticed the committed patch "gameux: Add implementation of IGameStatisticsMgr::RemoveGameStatistics." (5cac9d2cb2c020802a56a5b1b28348316f1087ba) The GAMEUX_getAppIdFromGDFPath() function now ends with: + HeapFree(GetProcessHeap(), 0, lpRegistryPath); + + TRACE("found app id: %s, return: %#x\n", debugstr_w(lpApplicationId), hr); + return hr; In most of the error paths, lpRegistryPath is not initialized, so it's pointing to garbage; I think just initializing to NULL should be sufficient; Similarly, in that case, lpApplicationId is not initialized, so it contains garbage; Tracing will probably print some random stack bytes before hitting a zero byte. I'm not completely sure what should be done about this issue; I think it should probably only be traced on success, perhaps tracing the error otherwise; Any ideas? HTH, Joris

2 1

Re: [PATCH 2/2] msxml3: implement preserveWhiteSpace property
by Alexandre Julliard 30 Sep '10

30 Sep '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define WS_CHECK_IGNORED(doc) \ > + ole_check(IXMLDOMDocument2_selectNodes(doc, _bstr_("//*[local-name()='html']"), &list));\ > + ole_check(IXMLDOMNodeList_get_item(list, 0, &node1));\ > + ole_check(IXMLDOMNodeList_get_item(list, 1, &node2));\ > + ole_check(IXMLDOMNodeList_reset(list));\ > + expect_list_and_release(list, "E1.E4.E1.E2.D1 E2.E4.E1.E2.D1");\ > + \ > + ole_check(IXMLDOMNode_get_childNodes(node1, &list));\ > + expect_list_and_release(list, "T1.E1.E4.E1.E2.D1 E2.E1.E4.E1.E2.D1 E3.E1.E4.E1.E2.D1 T4.E1.E4.E1.E2.D1 E5.E1.E4.E1.E2.D1");\ > + IXMLDOMNode_Release(node1);\ > + ole_check(IXMLDOMNode_get_childNodes(node2, &list));\ > + expect_list_and_release(list, "T1.E2.E4.E1.E2.D1 E2.E2.E4.E1.E2.D1 T3.E2.E4.E1.E2.D1 E4.E2.E4.E1.E2.D1 T5.E2.E4.E1.E2.D1 E6.E2.E4.E1.E2.D1 T7.E2.E4.E1.E2.D1");\ > + IXMLDOMNode_Release(node2) Please don't write such large macros. Put this in a helper function instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msxml3/httprequest: Add basic bind callback for moniker binding (try2)
by Alexandre Julliard 30 Sep '10

30 Sep '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > +#define DEFINE_THIS2(cls,ifc,iface) ((cls*)((BYTE*)(iface)-offsetof(cls,ifc))) > +#define DEFINE_THIS(cls,ifc,iface) DEFINE_THIS2(cls,lp ## ifc ## Vtbl,iface) Don't do that, follow the standard impl_from_xxx inline function pattern. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11: Add support for animated cursors in X11 driver (try 4).
by Alexandre Julliard 30 Sep '10

30 Sep '10

Erich Hoover <ehoover(a)mines.edu> writes: > + /* Build an X cursor out of all of the frames */ > + if (!(images = pXcursorImagesCreate( nFrames ))) goto cleanup; > + for (images->nimage = 0; images->nimage < nFrames; images->nimage++) > + images->images[images->nimage] = imgs[images->nimage]; > wine_tsx11_lock(); > - cursor = pXcursorImageLoadCursor( gdi_display, image ); > - pXcursorImageDestroy( image ); > + cursor = pXcursorImagesLoadCursor( gdi_display, images ); > wine_tsx11_unlock(); > + pXcursorImagesDestroy( images ); /* Note: XcursorImagesDestroy is called on each frame */ The note isn't clear, does it destroy the individual images or not? Either way your cleanup code needs more work. > +cleanup: > + /* Cleanup all of the resources used to obtain the frame data */ > + if (imgs && !cursor) > + { > + int i; > + > + for (i = 0; i < nFrames; i++) > + pXcursorImageDestroy( image ); And this can't possibly work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Backtraces in crash window
by Jerome Leclanche 30 Sep '10

30 Sep '10

Adding copypastable backtraces to the crash window might go a long way to prevent this sort of attachments: http://bugs2.winehq.org/attachment.cgi?id=31033 Maybe under a "Crash information" link or something similar. It wouldn't always do the trick (seeing as most of the time the error only shows in the fixmes, if not the traces), but at least it would get rid of some completely useless attachments, imho. Has this been discussed before? J. Leclanche

2 1

Need to retrieve VS_VERSION_INFO for 16, 32, 64 bit windows binaries
by Kapil Arora 30 Sep '10

30 Sep '10

Hi, I've created a small executable on windows which calls GetFileVersionInfo() and VerQueryValue() to extract VS_VERSION_INFO from various windows binary files. I want to use this utility under wine on linux system. Everything works fine for most of the files but for some older dlls I'm not getting correct version information. In the wine sources I found some of the functions for previous (16- bit) version info extraction to be stubs. I tried replacing version.dll in $HOME/.wine/drive_c/windows/system32 with the one on my windows XP box but nothing happens. I still don't get complete information. Is there a way to achieve this. Thanks, Kapil.

2 1

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.
by Jacek Caban 30 Sep '10

30 Sep '10

Hi Reece, On 9/30/10 12:20 AM, Reece Dunn wrote: > This addresses a fixme in the jscript code that is currently triggered > when running the Big Fish Games client, with a test. if(V_VT(&constr) != VT_DISPATCH) { - FIXME("throw TypeError\n"); + hres = throw_type_error(ctx->parser->script, ei, IDS_OBJECT_EXPECTED, NULL); VariantClear(&constr); - return E_FAIL; + return hres; It would be cleaner to clear constr before throw_type_error so that you can return its result directly, without storing it in hres. exception_test(function() {"test" in null;}, "TypeError", -2146823281); exception_test(function() {"test" in nullDisp;}, "TypeError", -2146823281); +exception_test(function() {new null;}, "TypeError", -2146823281); While you're at this, it would be nice to add a test (and fix) for nullDisp and test some other types (eg. undefined and number). Jacek

2 1

Re: Right-To-Left (RTL) languages and Wine
by James Mckenzie 30 Sep '10

30 Sep '10

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Sep 29, 2010 11:25 AM >To: Shachar Shemesh <shachar(a)shemesh.biz> >Cc: Paul Vriens <paul.vriens.wine(a)gmail.com>, "'wine-devel(a)winehq.org'" <wine-devel(a)winehq.org> >Subject: Re: Right-To-Left (RTL) languages and Wine > >Shachar Shemesh <shachar(a)shemesh.biz> writes: > >> Did I mention that the automatic mirroring is a broken idea >> implemented in a broken way already? > >What do you consider broken about it? > >> Aside from notepad, for which the difference is very small, and most >> people would regard a default LTR control as the correct behavior >> anyway, what other applications are you concerned over? > >Pretty much all of them. For example, Wordpad has combo boxes in the >toolbars, those won't be RTL without changing the process layout. >Winefile and Regedit have treeviews that would need mirroring, etc. > And Microsoft Office appears different in RTL rather than LTR. I used to work with someone that had the Arabic version of these programs and it would switch from RTL when typing in Arabic to LTR when typing in a Latin-based language. As AJ has stated, there is more to do than just 'mirroring' to get RTL into Wine. I remember this was quite difficult to get into OpenOffice.org as well when I was testing it (I think I still have Hebrew and Arabic test files for Writer in OpenDocument (.odt) format.) James McKenzie

3 3

Re: [PATCH] jscript: throw TypeError if T in 'new T' is not an object.
by testbot＠testbot.winehq.org 30 Sep '10

30 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5608 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: msxml3/httprequest: Add basic bind callback for moniker binding
by testbot＠testbot.winehq.org 30 Sep '10

30 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5605 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2917: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x8000ffff === W2KPROSP4 (32 bit domdoc) === domdoc.c:2917: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x8000ffff

1 0

Right-To-Left (RTL) languages and Wine
by Paul Vriens 29 Sep '10

29 Sep '10

Hi, I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I run an English winmine.exe on an Arabic box (thanks to the testbot) the main window will shows as normal LTR window layout with the menu's left justified as well. So eventhough the locale is set to Arabic it doesn't turn 'everything' into RTL. If we don't change the resource files for the RTL languages, that same logic will give us LTR Wine applications or am I wrong here? -- Cheers, Paul.

4 16

Wanted: small C program to drop all capabilities but cap_sys_ptrace
by Scott Ritchie 29 Sep '10

29 Sep '10

Ubuntu 10.10 is coming out soon, and its new kernel settings prevent Wine apps from looking at each others' memory. This breaks World of Warcraft, among other things. See: http://bugs.winehq.org/show_bug.cgi?id=24193 What's needed is a very small shim for Wine that can be setuid 0, but then release all capabilities except what Wine actually needs -- what a normal user has, and cap_sys_ptrace. On an Ubuntu system, this is very similar to what DHCP and PING do -- setuid 0, however they drop all privs except cap_net_rawio at the start. Existing code can be used: http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/dapper/dhcp3/dapper/ann… http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/dapper/dhcp3/dapper/ann… Basically, I need someone to write this shim for me. The long term solution is probably to just package Wine such that the wine binary itself has cap_sys_ptrace, however currently Ubuntu has no support for this kind of extended attribute in the packaging system so workarounds like the above for DHCP need to be done. I suspect other distros have similar issues. Thanks, Scott Ritchie

5 6

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite
by Stefan Dösinger 29 Sep '10

29 Sep '10

Am 26.09.2010 um 19:51 schrieb Travis Athougies: > + data = compute_shader_fullscreen9(device, vshader_passthru, pshader, quad_geometry, > + D3DFMT_A8R8G8B8, 1, 1); > + > + ok(data[0] == D3DCOLOR_ARGB(0, 0, 255, 255), > + "swizzle_test: Got color %08x (should be 0x0000FFFF)\n", data[0]); You leak the returned data here. On the big picture of this, I don't like the void * blob returned from compute_shader_fullscreen. As far as I can see the only position dependent aspect of HLSL is vpos(or rather, the HLSL equivalent). For all others it would be OK to return a ARGB color. > + /* The Direct3D 9 docs state that we cannot lock a render target surface, > + instead we must copy the render target onto this surface to lock it */ I think you can, if you create it with D3DUSAGE_DYNAMIC | D3DUSAGE_RENDERTARGET. If you want the backbuffer to be lockable you'll need some device creation flag whose name I forgot.

3 5

Re: winex11: Add support for animated cursors in X11 driver (try 2).
by Henri Verbeet 29 Sep '10

29 Sep '10

I didn't really look at the patch at all, but that's not how HeapReAlloc() works.

2 1

mshtml and friends
by Reece Dunn 29 Sep '10

29 Sep '10

Hi, The current state of support for the Internet Explorer components in Wine is good, but there are applications that don't work with it because they are dependent on more of the functionality provided by Internet Explorer via the WebBrowser control. I have had a scan through some of the mshtml code, and see various things not handled -- such as the onload handler of the HTMLBody element -- but I am not very familiar with this area. I am interested in helping out to improve this area -- my aim is to not require the `winetricks ie6` command to get some of these applications (specifically the Big Fish Games client) to a usable state. Therefore, I am wondering if anyone knows where the best place is to start looking (e.g. known areas of missing functionality) or how to debug applications (and interpret WINEDEBUG output) to identify where the issues are. Thanks, - Reece

2 7

Re: [PATCH] mshtml: implement ActiveScriptSite_OnScriptError.
by Jacek Caban 29 Sep '10

29 Sep '10

On 9/29/10 9:39 AM, Reece Dunn wrote: > Hi, > > This reports any errors sent to the mshtml ActiveScriptSite > OnScriptError handler to the user and traces it to ERR to aid > debugging. static HRESULT WINAPI ActiveScriptSite_OnScriptError(IActiveScriptSite *iface, IActiveScriptError *pscripterror) { ScriptHost *This = ACTSCPSITE_THIS(iface); - FIXME("(%p)->(%p)\n", This, pscripterror); - return E_NOTIMPL; + EXCEPINFO excep; + HRESULT hr; + + TRACE("(%p)->(%p)\n", This, pscripterror); + + hr = IActiveScriptError_GetExceptionInfo(pscripterror,&excep); + + ERR("ActiveScript Error: %s source: %s\n", + debugstr_w(excep.bstrDescription), debugstr_w(excep.bstrSource)); ERR is not appropriate in this case. + MessageBoxW(NULL, excep.bstrDescription, excep.bstrSource, MB_OK|MB_ICONERROR); This is not how this function should work. If you want to implement it, please start with a test case. It probably should fire onerror event. Jacek

2 1

Re: wined3d: Keep track of textures projection state in compiled pixel shaders. [try 2]
by Henri Verbeet 29 Sep '10

29 Sep '10

On 28 September 2010 23:07, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > You still need to use this state in the shader backends, instead of getting it from the stateblock.

1 0

winscard.dll
by viny 29 Sep '10

29 Sep '10

Hi all, Is anyone working on winscard.dll ? If not, may I propose patches ? I would like to have a working winscard.dll in wine. -- Vincent

7 10

Wine and security
by Dan Kegel 29 Sep '10

29 Sep '10

I keep seeing people asking about wine and security, e.g. http://bugs.winehq.org/show_bug.cgi?id=24550 or http://forum.winehq.org/viewtopic.php?t=9770 or https://answers.launchpad.net/ubuntu/+source/wine/+question/59148 ... It seems worth listing the things one can do to partially lock down wine, so I started a page at http://wiki.winehq.org/SecuringWine which is appropriately morose, yet lists a few things one could do if one really wanted to. Corrections or additions welcome.

2 1

Re: comctl32/tab: Fix DRAWITEMSTRUCT filling when extra item data of a custom size is used (try2)
by testbot＠testbot.winehq.org 29 Sep '10

29 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5580 Your paranoid android. === W98SE (32 bit tab) === tab.c:1354: Test failed: got 0xdedede, expected 0xdededede === W7PROX64 (64 bit tab) === tab.c:1354: Test failed: got 0xdededede, expected 0xdededede

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try3)
by testbot＠testbot.winehq.org 29 Sep '10

29 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5575 Your paranoid android. === WVISTAADM (32 bit win) === win.c:835: Test failed: wrong dwStyle: 84cb0000 != 94cb0000 for 000201C0 in hook HCBT_MINMAX win.c:3236: Test failed: Expected GetUpdateRect to return non-zero, got 0 win.c:3237: Test failed: Update rectangle is empty! win.c:3581: Test failed: pixel should be black, color is ffffffff win.c:3601: Test failed: pixel should be black, color is ffffffff win.c:3643: Test failed: wrong update region win.c:3656: Test failed: wrong update region win.c:3674: Test failed: wrong update region win.c:3684: Test failed: wrong update region in excessive scroll win.c:3706: Test failed: wrong update region win.c:3715: Test failed: wrong update region win.c:3724: Test failed: wrong update region win.c:3739: Test failed: wrong update region win.c:3819: Test failed: pixel should be black, color is ffffffff win.c:3823: Test failed: pixel should be black, color is ffffffff win.c:3831: Test failed: rects do not match (0,0-0,0) / (0,0-100,100) win.c:3838: Test failed: wrong update region win.c:3848: Test failed: wrong update region win.c:2322: Test failed: rgn right 0 not inside win rect -31700 win.c:2324: Test failed: rgn bottom 0 not inside win rect -31700 === W7PROX64 (32 bit win) === win.c:2684: Test failed: GetActiveWindow() = 00000000 win.c:2684: Test failed: GetFocus() = 00000000 win.c:2710: Test failed: GetActiveWindow() = 00000000 win.c:2710: Test failed: GetFocus() = 00000000 win.c:2769: Test failed: GetActiveWindow() = 00000000 win.c:2769: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [1/7] msvcrt: Initialize the environ global variables on DLL load.
by Alexandre Julliard 28 Sep '10

28 Sep '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > + ok( environ != NULL, "Expected the environ global variable to be initialized on startup\n" ); > + ok( _wenviron != NULL, "Expected the _wenviron global variable to be initialized on startup\n" ); This won't test what you want, importing variables is not supported on Wine, you have to load the variables explicitly with GetProcAddress, -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] winex11: Add support for animated cursors in X11 driver.
by Alexandre Julliard 28 Sep '10

28 Sep '10

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -508,35 +517,90 @@ static Cursor create_xcursor_cursor( HDC hdc, ICONINFO *icon, int width, int hei > info->bmiHeader.biYPelsPerMeter = 0; > info->bmiHeader.biClrUsed = 0; > info->bmiHeader.biClrImportant = 0; > - GetDIBits( hdc, icon->hbmColor, 0, height, image->pixels, info, DIB_RGB_COLORS ); > + hbmColor = CreateDIBSection( hdc, info, DIB_RGB_COLORS, (VOID **) &mem_bits, NULL, 0); > + if (!hbmColor) > + { > + ERR("Failed to create DIB section for image!\n"); > + goto cleanup; > + } > + SelectObject( hdc, hbmColor ); > + if (!DrawIconEx( hdc, 0, 0, icon, width, height, istep, NULL, DI_NORMAL )) > + { > + TRACE("Could not draw frame %d (walk past end of frames).\n", istep); > + goto cleanup; > + } > + memcpy(image->pixels, mem_bits, info->bmiHeader.biSizeImage); You should be reusing the info, DC and bitmap objects for all frames instead of always recreating everything from scratch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: widl: Explicitly declare default function's calling convention to avoid win64 problems.
by Alexandre Julliard 28 Sep '10

28 Sep '10

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -369,7 +369,7 @@ static void write_type_v(FILE *h, type_t *t, int is_field, int declonly, const c > if (type_get_type_detect_alias(pt) == TYPE_FUNCTION) { > int i; > const char *callconv = get_attrp(pt->attrs, ATTR_CALLCONV); > - if (!callconv && is_object_interface) callconv = "STDMETHODCALLTYPE"; > + if (!callconv) callconv = is_object_interface ? "STDMETHODCALLTYPE" : "__cdecl"; It may be useful to be able to declare functions that use the native calling convention, I don't think we want to prevent that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().(try 2)
by Henri Verbeet 28 Sep '10

28 Sep '10

2010/9/27 Rico Schüller <kgbricola(a)web.de>: > !strcmp("unrecognized", debug_d3dcompiler_d3d_blob_part(part)) Oh, and please don't do that, I think it's very fragile.

1 0

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().(try 2)
by Henri Verbeet 28 Sep '10

28 Sep '10

2010/9/27 Rico Schüller <kgbricola(a)web.de>: > --- Wouldn't it be nicer if the "count" parameter to dxbc_init() was more of a hint? I.e., allow the sections array to grow if needed. For parse_dxbc() this works fine, because you know the number of sections in advance, but as you must have noticed, for creating the destination blob it's much more inconvenient.

1 0

Re: [PATCH 2/6] msxml3: ignore whitespace nodes
by Nikolay Sivov 28 Sep '10

28 Sep '10

On 9/28/2010 05:37, Adam Martinson wrote: > From 1f8661342ae63290f212429e382b5776e07b9ebc Mon Sep 17 00:00:00 2001 > From: Adam Martinson<amartinson(a)codeweavers.com> > Date: Mon, 27 Sep 2010 19:29:04 -0500 > Subject: [PATCH 2/6] msxml3: ignore whitespace nodes > > --- > dlls/msxml3/msxml_private.h | 15 +++++++++++++++ > dlls/msxml3/node.c | 9 +++++++++ > dlls/msxml3/nodelist.c | 8 ++++++-- > dlls/msxml3/tests/domdoc.c | 14 ++++++++++++++ > 4 files changed, 44 insertions(+), 2 deletions(-) This should be affected by ::preserveWhiteSpace() property I guess.

2 1

Re: ws2_32(3/3): Implement WSAIoctl for SIO_ROUTING_INTERFACE_QUERY
by Alexandre Julliard 28 Sep '10

28 Sep '10

Juan Lang <juan.lang(a)gmail.com> writes: > This one may cause test failures on systems that don't have a route to > the loopback address. As far as I can tell, Windows systems always > have such a route, whereas on *ix it isn't guaranteed. I'm not sure > how to handle that, as broken() isn't allowed for Wine, and such a > networking configuration is at least strange. If it's really always present on Windows and apps depend on it, you'll have to fake a route. Otherwise just don't test it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32/tests: Send zero byte to any connected IrDA device (resend)
by Alexandre Julliard 28 Sep '10

28 Sep '10

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > Test for bug #19397. > Test only executed, if remote IrDA device is present. > Otherwise test is skipped. (Proposal from Mike Kaplinskiy) I'm not sure this is very useful. It's unlikely to be run on any of the test boxes, and AFAICS this is a kernel bug anyway, it should be a Unix test case not a Wine one. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] comctl32/tab: Fix DRAWITEMSTRUCT filling when large enough extra item data is used (try2)
by Alexandre Julliard 28 Sep '10

28 Sep '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Fix DRAWITEMSTRUCT filling when large enough extra item data is used I'd like to see a test with smaller sizes too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (still try3)
by Jacek Caban 28 Sep '10

28 Sep '10

Hi Nikolay, + entry = heap_alloc(sizeof(*entry)); + if (!entry) return E_OUTOFMEMORY; + + /* new header */ + list_add_head(&This->reqheaders,&entry->entry); + + return S_OK; It seems like filling the new header's name and value is missing here. Jacek

1 0

Re: [1/2] msxml3/httprequest: Store passed data for IXMLHttpRequest::open()
by Jacek Caban 28 Sep '10

28 Sep '10

Hi Nikolay, On 9/28/10 1:30 PM, Nikolay Sivov wrote: > Resent for series completeness. + hr = VariantChangeType(&str,&user, 0, VT_BSTR); + if (hr == S_OK) + { + This->user = SysAllocString(V_BSTR(&str)); + VariantClear(&str); + } You already own the reference to string in str VARIANT, so you can just use it |This->user = V_BSTR(&str);| and remove VariantClear call. + hr = VariantChangeType(&str,&password, 0, VT_BSTR); + if (hr == S_OK) + { + This->password = SysAllocString(V_BSTR(&str)); + VariantClear(&str); + } Same here. Jacek

1 0

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (try3)
by Alexandre Julliard 28 Sep '10

28 Sep '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try3: fixed some test failures > > Should still be applied over [1/2] patch, let me know if I should > resend both. Yes please, otherwise testbot won't be able to figure out the sequence. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/7] msvcrt: Initialize the environ global variables on DLL load.
by testbot＠testbot.winehq.org 28 Sep '10

28 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5546 Your paranoid android. === W7PROX64 (64 bit environ) === Timeout

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)
by Dmitry Timoshkov 28 Sep '10

28 Sep '10

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > + SetLastError(0xdadadada); > + retval = UpdateWindow(NULL); > + ok( !retval, "Expected 0, got %d\n", retval); > + ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || broken(GetLastError() == 0xdadadada) /* win9x */, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); It's better to use a commonly accepted 0xdeadbeef as an invalid last error value, and limit the line length somewhere at 80. -- Dmitry.

3 2

Re: [2/2] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader() (try2)
by testbot＠testbot.winehq.org 28 Sep '10

28 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5538 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === W2KPROSP4 (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === WXPPROSP3 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd +tests (try 2)
by testbot＠testbot.winehq.org 28 Sep '10

28 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5530 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2683: Test failed: GetActiveWindow() = 00000000 win.c:2683: Test failed: GetFocus() = 00000000 win.c:2709: Test failed: GetActiveWindow() = 00000000 win.c:2709: Test failed: GetFocus() = 00000000 win.c:2768: Test failed: GetActiveWindow() = 00000000 win.c:2768: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd + test
by testbot＠testbot.winehq.org 28 Sep '10

28 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5529 Your paranoid android. === W7PROX64 (32 bit win) === win.c:2683: Test failed: GetActiveWindow() = 00000000 win.c:2683: Test failed: GetFocus() = 00000000 win.c:2709: Test failed: GetActiveWindow() = 00000000 win.c:2709: Test failed: GetFocus() = 00000000 win.c:2768: Test failed: GetActiveWindow() = 00000000 win.c:2768: Test failed: GetFocus() = 00000000 === W7PROX64 (64 bit win) === win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000

1 0

Re: ws2_32(3/3): Implement WSAIoctl for SIO_ROUTING_INTERFACE_QUERY
by testbot＠testbot.winehq.org 28 Sep '10

28 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5526 Your paranoid android. === W2K3R2SESP2 (32 bit sock) === sock.c:2329: Test failed: gethostbyname("w2k3r2sesp2") returned 127.0.0.1 not 127.12.34.56

1 0

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd + test
by Austin English 27 Sep '10

27 Sep '10

On Mon, Sep 27, 2010 at 7:27 PM, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, this fixes http://bugs.winehq.org/show_bug.cgi?id=24527 Howdy Louis, + ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || /* win98 */ GetLastError() == 0xdadadada, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); shouldn't that win98 path be enclosed in broken()? -- -Austin

1 0

Re: [1/5] urlmon: Implemented validation of the host name component of a IUriBuilder
by Alexandre Julliard 27 Sep '10

27 Sep '10

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > -#define ALLOW_NULL_TERM_SCHEME 0x1 > -#define ALLOW_NULL_TERM_USER_NAME 0x2 > -#define ALLOW_NULL_TERM_PASSWORD 0x4 > +#define ALLOW_NULL_TERM_SCHEME 0x1 > +#define ALLOW_NULL_TERM_USER_NAME 0x2 > +#define ALLOW_NULL_TERM_PASSWORD 0x4 > +#define ALLOW_BRACKETLESS_IP_LITERAL 0x8 > +#define SKIP_IP_FUTURE_CHECK 0x16 > +#define IGNORE_PORT_DELIMITER 0x32 These won't work as flags... -- Alexandre Julliard julliard(a)winehq.org

1 0

Sound on TestBot
by Joerg-Cyril.Hoehle＠t-systems.com 27 Sep '10

27 Sep '10

Greg Geldorp wrote: >I've found a way to add a soundcard to most of the TestBot VMs (using >the virtual soundcard driver from VMware View). This is excellent news. It even has MIDI-out! Alas, capture.c:661: found 0 WaveIn devices means that most mci.c tests (which are mostly mciwave tests) are skipped because the tests depend on the ability to record, then play back. mci.c:651: Tests skipped: Please install audio driver. Everything is skipped. Hopefully Francois Gouget will update his vmware machines with these drivers (or the ones Paul Vriens' uses) so that the timeouts will disappear. http://test.winehq.org/data/190c3518d66df44cfa464d8dc1ca3fd50ff6c361/xp_fg-… Earlier this year, Julius Schwartzenberg found out that the timeouts in winmm tests on vmware could be avoided by installing another driver. http://www.winehq.org/pipermail/wine-devel/2010-March/082118.html capture.c:674: Test failed: waveInGetDevCapsA(WAVE_MAPPER): got MMSYSERR_NOERROR capture.c:691: Test failed: waveInGetDevCapsW(1): got MMSYSERR_NOERROR Weird. waveOutGetDevCaps (in wave.c) behaves as expected. Looks like a driver bug. Perhaps one explanation for the WAVE_MAPPER case is found in my mci.c tests: * However some w2k8/w7 machines return no error when there's no wave * input device (perhaps querying waveOutGetNumDevs instead of waveIn?), * still the record command below fails with MCIERR_WAVE_INPUTSUNSUITABLE. * Don't skip here, record will fail below. */ err = mciSendString("set x format tag pcm", NULL, 0, NULL); I should feed testbot a patch to call wave_in_test_device(1) despite numdevs=0 to see what happens. Regards, Jörg Höhle

3 2

Re: [1/3] comctl32/tab: Add a test for TCM_SETITEMEXTRA
by Vitaliy Margolen 27 Sep '10

27 Sep '10

On 09/26/2010 05:08 PM, Nikolay Sivov wrote: > Add a test for TCM_SETITEMEXTRA > > > > > +static HWND parent_wnd; > -static void test_curfocus(HWND parent_wnd, INT nTabs) > +static void test_curfocus(void) > { > - hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, nTabs); > + hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, 5); So how is the global better then function parameter? Or a magic number? Vitaliy.

2 3

Re: [4/5] msxml3/httprequest: Store user defined request headers on transaction beginning
by Jacek Caban 27 Sep '10

27 Sep '10

Hi Nikolay, On 9/25/10 10:16 PM, Nikolay Sivov wrote: > Store user defined request headers on transaction beginning + buff = CoTaskMemAlloc((size+1)*sizeof(WCHAR)); + if (!buff) return E_OUTOFMEMORY; + + LIST_FOR_EACH_ENTRY(entry,&This->request->reqheaders, struct reqheader, entry) + { + LONG header_size = SysStringLen(entry->header) + SysStringLen(entry->value) + 4 /* colon, space, CRLF */; + + /* get large enough buffer */ + while (freech< header_size) + { + WCHAR *buff2; + + freech += size; + size *= 2; + buff2 = CoTaskMemRealloc(buff, (size+1)*sizeof(WCHAR)); This is very inefficient. You can compute header size before doing allocation, so that no reallocation is needed. And even when doing reallocation, the inner loop may be easily avoided. Jacek

1 0

Re: [1/5] msxml3/httprequest: Store passed data for IXMLHttpRequest::open()
by Jacek Caban 27 Sep '10

27 Sep '10

Hi Nikolay, On 9/25/10 10:15 PM, Nikolay Sivov wrote: > Store passed data for IXMLHttpRequest::open() + hr = VariantChangeType(&async,&async, 0, VT_BOOL); + This->async = (hr == S_OK) ? V_BOOL(&async) : FALSE; You mix BOOL and VARIANT_BOOL here. |This->async = (hr == S_OK) && V_BOOL(&async)| will do what you want. + hr = VariantChangeType(&user,&user, 0, VT_BSTR); + if (hr == S_OK) + This->user = SysAllocString(V_BSTR(&user)); You potentially leak here. + hr = VariantChangeType(&password,&password, 0, VT_BSTR); + if (hr == S_OK) + This->password = SysAllocString(V_BSTR(&password)); And here. + { + return SysReAllocString(&entry->value, value) == TRUE ? S_OK : E_OUTOFMEMORY; + You shouldn't compare to TRUE value. This should be |return SysReAllocString(...) ? S_OK : E_OUTOFMEMORY|. + *bind_flags = BINDF_FROMURLMON; Are you sure you need BINDF_FROMURLMON here? This flag is set by urlmon before calling protocol handler. + hr = BindStatusCallback_create(This,&bsc); + if (FAILED(hr)) return hr; + + ERR("%x\n", hr); Debugging code left? Jacek

1 0

Re: d3d9: Add a sRGB format test
by Henri Verbeet 27 Sep '10

27 Sep '10

On 25 September 2010 23:45, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + struct > + { > + D3DFORMAT fmt; > + const char *name; > + } > + formats[] = > + { > + { D3DFMT_R5G6B5, "D3DFMT_R5G6B5" }, > + { D3DFMT_X8R8G8B8, "D3DFMT_X8R8G8B8" }, > + { D3DFMT_A8R8G8B8, "D3DFMT_A8R8G8B8" }, > + { D3DFMT_A16B16G16R16F, "D3DFMT_A16B16G16R16F" }, > + { D3DFMT_A32B32G32R32F, "D3DFMT_A32B32G32R32F" }, > + }; This should be static const. I recently fixed a number of these. > + const float quad[] = { > + -1.0, -1.0, 0.1, 0.0, 0.0, > + -1.0, 1.0, 0.1, 1.0, 0.0, > + 1.0, -1.0, 0.1, 0.0, 1.0, > + 1.0, 1.0, 0.1, 1.0, 1.0 > + }; Please use a proper structure?

1 0

hey, saw a job ad that mentions wine!
by Dan Kegel 27 Sep '10

27 Sep '10

I do periodic searches in google blogsearch and twitter for references to wine, sometimes I find interesting tidbits that way. Tonight I also tried searching on indeed.com, and one job popped up: http://storagecraft.iapplicants.com/ViewJob-106203.html They're only looking for wine users, but still, it's nice to see.

2 1

Wine test bot failure?
by Travis Athougies 27 Sep '10

27 Sep '10

Hi, I was trying to run my HLSL test suite patch through wine test bot and the build failed. However, it's not a compilation failure. Instead it complains about not being able to copy some executable file. Also, the build fails almost instantaneously. It also complains about a missing command. The results are at https://testbot.winehq.org/JobDetails.pl?Key=5449&log_101=1#k101 How can I get this to builid and run? Travis Athougies. -- Travis Athougies

6 9

what's the proper way to define a COM interface that takes function pointers as arguments?
by Vincent Povirk 26 Sep '10

26 Sep '10

I am trying to define the ICLRRuntimeHost interface. It has this method: http://msdn.microsoft.com/en-us/library/ms164410.aspx One of the arguments is a function pointer type: http://msdn.microsoft.com/en-us/library/aa964757.aspx Widl fails when I try to define a function pointer type using C syntax. So, what's the proper way to do this? Does widl need to be fixed?

1 1

Re: [PATCH 1/5] gameux: Add implementation of IGameStatistics::SetCategoryTitle
by Nikolay Sivov 26 Sep '10

26 Sep '10

On 9/26/2010 16:59, Mariusz Pluciński wrote: > --- > dlls/gameux/gamestatistics.c | 50 > ++++++++++++++++++++++++++++++++++- > dlls/gameux/tests/gamestatistics.c | 14 +++++----- > 2 files changed, 55 insertions(+), 9 deletions(-) > @@ -177,8 +201,30 @@ static HRESULT WINAPI GameStatisticsImpl_SetCategoryTitle( > WORD categoryIndex, > LPCWSTR title) > { > - FIXME("stub\n"); > - return E_NOTIMPL; > + HRESULT hr = S_OK; > + DWORD dwLength; > + GameStatisticsImpl *This = impl_from_IGameStatistics(iface); > + > + TRACE("(%p, %d, %s)\n", This, categoryIndex, debugstr_w(title)); > + > + if(!title || categoryIndex>= MAX_CATEGORIES) > + hr = E_INVALIDARG; Just return here and be done with it, this will save you hr initialization and unnecessary if (SUCCEEDED(hr)) after that. > + > + if(SUCCEEDED(hr)) > + { > + dwLength = lstrlenW(title); > + > + if(dwLength> MAX_CATEGORY_LENGTH) > + { > + hr = S_FALSE; > + dwLength = MAX_CATEGORY_LENGTH; > + } Does it really copy with hr == S_FALSE ? > + > + lstrcpynW(This->stats.categories[categoryIndex].sName, > + title, dwLength+1); > + } > + > + return hr; > } >

2 1

RFC [PATCH] ddraw: Prevent refcount underflow
by Vincent Pelletier 26 Sep '10

26 Sep '10

Hi. Attached patch fixes a problem with Beetle Crazy Cup's VideoSetup.exe, which hangs at exit because some code tries to free ddraw surface on which a refcount underflow happened earlier in the execution. Executing it with winedbg shows that the first call causing the underflow is triggered from game's binary: Stopped on breakpoint 3 at 0x7ed494fc ddraw1_Release+0x2c [/home/vincent/git/wine/dlls/ddraw/ddraw.c:476] in ddraw 476 ULONG ref = InterlockedDecrement(&ddraw->ref1); Wine-dbg>print ddraw->ref1 0 Wine-dbg>bt Backtrace: =>0 0x7ed494fc ddraw1_Release+0x2c(iface=0x129e10) [/home/vincent/git/wine/dlls/ddraw/ddraw.c:476] in ddraw (0x0033fd24) 1 0x00401d2c in videosetup (+0x1d2b) (0x0033fd5c) 2 0x0040342b in videosetup (+0x342a) (0x0033fd84) 3 0x004034f5 in videosetup (+0x34f4) (0x0033fda0) 4 0x00402f65 in videosetup (+0x2f64) (0x0033fe04) 5 0x00404a4e in videosetup (+0x4a4d) (0x0033fe90) 6 0x7b8565bc call_process_entry+0xb() in kernel32 (0x0033fea8) 7 0x7b8565bc call_process_entry+0xb() in kernel32 (0x0033fee8) 8 0x7b858a9b start_process+0x5a(peb=0x536430) [/home/vincent/git/wine/dlls/kernel32/process.c:994] in kernel32 (0x0033fef8) 9 0x7bc715f0 call_thread_func+0xb() in ntdll (0x0033ffc8) 10 0x7bc717c0 call_thread_entry_point+0x6f(entry=0x7b858a40, arg=0x7ffdf000) [/home/vincent/git/wine/dlls/ntdll/signal_i386.c:2473] in ntdll (0x0033ffe8) 11 0x7bc4cefa start_process+0x29(kernel_start=0x7b858a40) [/home/vincent/git/wine/dlls/ntdll/loader.c:2610] in ntdll (0x00000000) Points on which I would like opinions: - getting rid of the magic number - need to check after InterlockedDecrement (in doubt I did, but the code is much less readable this way) - couldn't it actually hide a refcount problem in wine ? - if not, then would it be good to extend to other refcounts aswell or include in [a local wrapper for] InterlockedDecrement ? Regards, --- dlls/ddraw/ddraw.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)

2 1

Re: comctl32/treeview: Erase background when painting over supplied hdc
by testbot＠testbot.winehq.org 26 Sep '10

26 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5489 Your paranoid android. === W98SE (32 bit treeview) === treeview.c:1293: Test failed: got 0x0

1 0

RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)
by Erich Hoover 26 Sep '10

26 Sep '10

I realize it's been some time since I've submitted something for the networking problems with the C&C games, but I believe I've come up with something that resolves the major show-stopping issue that was discussed previously. Here is the original thread, for reference: http://www.winehq.org/pipermail/wine-devel/2009-October/079099.html Specifically, this set of patches is revised to address the problem of throwing away packets destined for the incorrect interface in a multi-threaded/multi-process environment. The approach used here is to create a global (named) POSIX.1-2001 semaphore for each socket with the form wine-ifacelock-FD , where "FD" is the Unix file descriptor corresponding to the socket at hand. These semaphores are only created for UDP sockets bound to a specific interface and are locked/unlocked by both the Wine user-space and the Wine server. These patches are against wine-1.3.3 and are split apart according to function. The most revised portions since the original set are 2/6 (server-side creation of semaphore), 3/6 (locking and unlocking), and 6/6 (server-side locking and unlocking). If I could get some feedback on these patches then I would greatly appreciate it, it'd be really nice to finally get this issue resolved. Thanks in advance! [1/6] ws2_32/tests: Add UDP broadcast tests: http://www.compholio.com/wine-kane/patches/2010-09-18/0001-ws2_32-tests-Add… [2/6] server: Add mechanism for storing an interface ID with a socket: http://www.compholio.com/wine-kane/patches/2010-09-18/0002-server-Add-mecha… [3/6] ws2_32: Patch to selectively bind to interfaces while still allowing broadcast packets: http://www.compholio.com/wine-kane/patches/2010-09-18/0003-ws2_32-Patch-to-… [4/6] ws2_32: Ensure select does not wake up on packets with an interface mismatch: http://www.compholio.com/wine-kane/patches/2010-09-18/0004-ws2_32-Ensure-se… [5/6] ws2_32: Ensure Async WSARecv does not wake up on packets with an interface mismatch: http://www.compholio.com/wine-kane/patches/2010-09-18/0005-ws2_32-Ensure-As… [6/6] server: Ensure Async ReadFile does not wake up on packets with an interface mismatch: http://www.compholio.com/wine-kane/patches/2010-09-18/0006-server-Ensure-As… Erich Hoover ehoover(a)mines.edu

3 6

Request for Assistance/Advice for Richedit EM_SETMARGINS test
by James McKenzie 25 Sep '10

25 Sep '10

All: I've been trying to get the attached patch to pass on both the testbot and a copy of WindowsXP that I possess. It appears that the statement in MSDN that the USEFONTINFO information is either incorrect or I'm doing something wrong. The MSDN page for this information is: http://msdn.microsoft.com/en-us/library/bb761649%28VS.85%29.aspx I remember that WindowsXP does have Richedit 3.0 Thank you. James McKenzie

1 0

Re: [5/5] msxml3/httprequest: Implement ::get_status()
by testbot＠testbot.winehq.org 25 Sep '10

25 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5483 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2922: Test failed: got 0x8000ffff domdoc.c:2939: Test failed: got 0x8000ffff domdoc.c:2945: Test failed: got 0x8000ffff domdoc.c:2961: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x00000000 domdoc.c:3003: Test failed: got 0x8000ffff === W2KPROSP4 (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2922: Test failed: got 0x8000ffff domdoc.c:2939: Test failed: got 0x8000ffff domdoc.c:2945: Test failed: got 0x8000ffff domdoc.c:2961: Test failed: got 0x8000ffff domdoc.c:2979: Test failed: got 0x00000000 domdoc.c:3003: Test failed: got 0x8000ffff === WXPPROSP3 (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2979: Test failed: got 0x00000000

1 0

Re: [3/5] msxml3/httprequest: Add basic bind callback for moniker binding
by testbot＠testbot.winehq.org 25 Sep '10

25 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5482 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2930: Test failed: got 0x8000ffff domdoc.c:2936: Test failed: got 0x8000ffff domdoc.c:2964: Test failed: got 0x00000000 domdoc.c:2979: Test failed: got 0x8000ffff === W2KPROSP4 (32 bit domdoc) === domdoc.c:2914: Test failed: got 0x8000ffff domdoc.c:2930: Test failed: got 0x8000ffff domdoc.c:2936: Test failed: got 0x8000ffff domdoc.c:2964: Test failed: got 0x00000000 domdoc.c:2979: Test failed: got 0x8000ffff === WXPPROSP3 (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2964: Test failed: got 0x00000000

1 0

Memory Management
by Luis Carlos Busquets Pérez 25 Sep '10

25 Sep '10

Concerning the e-mail http://www.winehq.org/pipermail/wine-devel/2010-April/082900.html it seems that it is broken because in wine there is no way to ensure that the string will be in the lower 2GB. Actually, according to the Windows Memory Management model: http://www.intellectualheaven.com/Articles/WinMM.pdf only the 2 lower Gb are able to be used in user mode in Windows. So actually in Windows OS you have a way to ensure that all user things will be in the lower 2Gb. Is there something similar in WINE, If not, would it not be logical to replicate also that behaviour, so that then d3dxhandle can rely in the MSB? What is more, if there is not that way to ensure that, and I guess that the d3dxx_xx.dll might rely on that to distinguish between strings and d3dxhandle, there might be cases even using the original d3dx, programmes would crash in wine when the wine implementation allocates strings in memory positions where then MSB = 1.

3 2

Re: [2/5] msxml3/httprequest: Implement IXMLHttpRequest::setRequestHeader()
by testbot＠testbot.winehq.org 25 Sep '10

25 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5481 Your paranoid android. === W98SE (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === W2KPROSP4 (32 bit domdoc) === domdoc.c:2926: Test failed: got 0x8000ffff domdoc.c:2932: Test failed: got 0x8000ffff domdoc.c:2960: Test failed: got 0x00000000 === WXPPROSP3 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === WVISTAADM (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W2K8SE (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PRO (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (32 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000 === W7PROX64 (64 bit domdoc) === domdoc.c:2960: Test failed: got 0x00000000

1 0

WineAPI wiki status update
by Max TenEyck Woodbury 25 Sep '10

25 Sep '10

The wiki is at http://sourceforge.net/apps/mediawiki/wineapi/index.php and this address should *not* require a Sourceforge login. At least one person has complained that this project is too Wine specific. They want it to be more generic. I do *not* plan to remove the Wine specific content, but I have labeled it with the prefix 'Wine/' so there will be space for content specific to other projects. I have to admit that the format is pretty UGLY with too much information crammed into too little space. I have received some suggestions on how this can be improved. I intend to act on those suggestions, but not right now. I need to put the content in and assure that it is correct before I get into aesthetics. If someone wants to help with this, let me know. There are now links to every directory and file in the repository and a mechanism is in place to assure that this will continue to be the case. Significant repository entries have their own wiki pages with at least one place where editable content can be added that will not be over-written by the automatic update process. There are also the usual wiki discussion pages. Most of the file related pages are simply place holders at this time, with the exception of '.spec' file pages. Please see the section below on plans before complaining about this. Statistics (very approximate) 400 Directories 3000 Files 55000 APIs identified Plans and problems. The current maintenance process is based on bash scripts with different scripts doing different parts of the analysis. Scheduling is based on a list of work items. The scripts add work items as they are discovered and remove work items as they are finished. If someone wants to try their hand at them, let me know and I'll post them to the wiki. I expect that re-writes in other languages are in order, but I do bash scripts well. My other strong languages are C and C++. I am very interested in learning Python, Perl and others. Some of the pages are HUGE and cause problems when some wiki operations are tried. In particular there are at least two '.spec' files with more than 8000 entries. The scripts need to be taught how to split these monsters into managable pieces. Some of the APIs are class-object based and their names have been mangled in the usual C++ manner. They are currently displayed in their raw form. De-mangling is needed and a separate hierarchy should be established for indexing them. A section in each standard directory has been set aside to hold API descriptions for each executable but are currently empty (and invisible as a result). Once the names have been de-mangled, I plan to fill in these sections. Header and code analysis are on queue after that, as is improving the page format. There are a bunch of old pages without the 'Wine/' prefix. They are being removed. Advice on wiki-bots would be helpful. - Max

1 0

Re: [PATCH] user32: Update Finnish translation.
by Paul Vriens 25 Sep '10

25 Sep '10

On 09/25/2010 03:43 PM, Lauri Kenttä wrote: > Hi! > >> Great to see that someone is picking up the Finnish translations >> again (last real contribution is from 2006). > > I'm a bit sorry I didn't have time for this before the 1.2 release, but > better late than never. :) My girlfriend will maybe send patches as > well. No problem. We are all volunteers and a life besides Wine ;) Two volunteers for Finish is even better. > > I seem to remember that you know a lot about these resource things, so > I'll bother you with a few questions: > > - Is it ok to use the same accelerator key for multiple items? Maybe in > different submenus (File> &Save and Other> &Something)? One shouldn't have the same accelerators in one submenu. Different submenu's with same accelerators is no problem. So your example is correct. Maybe we should teach our resource compiler to warn about duplicate accelerators (or maybe even error out). > > - Is there some easy way to know which strings should NOT be > translated, e.g. "Microsoft\\Windows\\GameExplorer" and "OEM Links" and > such? Or does the resource file contain only the things that basically > should be translated? I guess 99% is translatable. The ones you mention have more to do with how a Finish Windows version would show up. These should be translated if users would otherwise be confused. > > - What about the license? FSF doesn't provide a Finnish version. Which > one is best: English only, unofficial translation only, or both? If there is no official LGPL license in your language, you can just use the English one. > > Thanks for your help. > It's is me/us who should thank you! -- Cheers, Paul.

1 0

parallel make broken somehow
by Marcus Meissner 25 Sep '10

25 Sep '10

Hi, + make -j4 depend config.status: creating tools/Makefile config.status: creating tools/Makefile make[1]: Entering directory `/usr/src/packages/BUILD/wine-1.3.3.20100924/tools' gcc -c -I. -I. -I../include -I../include -I/usr/include/freetype2 -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wno-unused-result -DLDAP_DEPRECATED=1 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -o makedep.o makedep.c make[1]: Entering directory `/usr/src/packages/BUILD/wine-1.3.3.20100924/tools' gcc -DLDAP_DEPRECATED=1 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -o makedep makedep.o makedep.o: file not recognized: File truncated collect2: ld returned 1 exit status make[1]: *** [makedep] Error 1 make[1]: Leaving directory `/usr/src/packages/BUILD/wine-1.3.3.20100924/tools It seems we start to build tools/ twice at the same time. Ciao, Marcus

2 1

Re: [PATCH] user32: Implement GetMenuBarInfo
by testbot＠testbot.winehq.org 24 Sep '10

24 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5468 Your paranoid android. === WVISTAADM (32 bit menu) === menu.c:2115: Test failed: test 13: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 13: GetMenuBarInfo.fFocused (1) is wrong === W7PROX64 (32 bit menu) === menu.c:2115: Test failed: test 21: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 21: GetMenuBarInfo.fFocused (1) is wrong menu.c:2128: Test failed: test 21: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2115: Test failed: test 27: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 27: GetMenuBarInfo.fFocused (1) is wrong menu.c:2128: Test failed: test 27: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2115: Test failed: test 30: GetMenuBarInfo.fBarFocused (1) is wrong menu.c:2117: Test failed: test 30: GetMenuBarInfo.fFocused (1) is wrong menu.c:2128: Test failed: test 30: GetMenuBarInfo.fBarFocused (1) is wrong

1 0

Re: [PATCH] ole32: Create a FORMATETC if one is not given in OleCreate
by testbot＠testbot.winehq.org 24 Sep '10

24 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5461 Your paranoid android. === W98SE (32 bit ole2) === ole2.c:1082: Test failed: Expected draw_continue to be called instead of DataObject_DAdvise ole2.c:1091: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1318: Test failed: Method sequence starting from DataObject_DUnadvise not called ole2.c:1026: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1026: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1026: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1390: Test failed: Method sequence starting from DataObject_GetData not called

1 0

Re: Wine test bot failure?
by James Mckenzie 24 Sep '10

24 Sep '10

Travis Athougies <iammisc(a)gmail.com> wrote: > >Hi, > >I was trying to run my HLSL test suite patch through wine test bot and >the build failed. However, it's not a compilation failure. Instead it >complains about not being able to copy some executable file. Also, the >build fails almost instantaneously. It also complains about a missing >command. > >The results are at >https://testbot.winehq.org/JobDetails.pl?Key=5449&log_101=1#k101 > Read the log file from the build failure and fix what it tells you to fix. I've encountered plenty of test failures due to incorrect spellings or missing variables because I did not declare them properly. The alternative is to build the testing file using the same method that the testbot does and using it for the upload. James McKenzie

1 0

Can we please have a "packaging" bugzilla component and not close packaging bugs?
by Scott Ritchie 24 Sep '10

24 Sep '10

Sometimes it's not 100% clear whether a problem is in the packaging or upstream part of Wine, and packaging bugs are just as much legitimate problems as normal Wine bugs. WineHQ is often the best place to have that discussion as 1) more than one packager would see it, and 2) if we're doing something wrong a developer can tell us too. I think we discussed this idea last wineconf informally, although I'm not sure anyone committed to making it happen. Thanks, Scott Ritchie

3 2

ie6 download failing
by Dan Kegel 23 Sep '10

23 Sep '10

Looks like Microsoft has been letting the ie6 download servers rot. Over the last few weeks, 'winetricks ie6' has been hanging occasionally, and today, it's failing right off the bat with wget http://www.microsoft.com/windows/ie/ie6sp1/download/rtw/x86/ie6sites.dat ... Resolving www.microsoft.com... 65.55.12.249 Connecting to www.microsoft.com|65.55.12.249|:80... connected. HTTP request sent, awaiting response... 500 Internal Server Error Personally, I think it's great that ie6 is getting the shaft, but it does make life with wine a bit more difficult. I hope this error is transient.

2 1

Re: [PATCH 1/3] msxml3: Implement SelectionNamespaces property for XPath
by Alexandre Julliard 23 Sep '10

23 Sep '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > Ignore the previous stuff from me, rebased & split into a patch set. > > From bdc1ce7957ee1be31f4b39484285a164bc4ba6b2 Mon Sep 17 00:00:00 2001 > From: Adam Martinson <amartinson(a)codeweavers.com> > Date: Wed, 22 Sep 2010 14:02:47 -0500 > Subject: [PATCH 1/3] msxml3: Implement SelectionNamespaces property for XPath It fails make test: ../../../tools/runtest -q -P wine -M msxml3.dll -T ../../.. -p msxml3_test.exe.so domdoc.c && touch domdoc.ok XPath error : Invalid context position xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed domdoc.c:514: Test succeeded inside todo block: IXMLDOMNodeList_get_length(list, &len) returned 0 domdoc.c:520: Test succeeded inside todo block: IXMLDOMNodeList_nextNode(list, &node) returned 0 domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000000) domdoc.c:469: Test succeeded inside todo block: IXMLDOMNode_get_nodeType(node, &type) returned 0 domdoc.c:446: Test succeeded inside todo block: get_previousSibling failed domdoc.c:492: Test succeeded inside todo block: get_parentNode failed (00000001) XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed XPath error : Undefined namespace prefix xmlXPathEval: evaluation failed wine: Unhandled page fault on write access to 0x00000000 at address 0x7bc48a27 (thread 001c), starting debugger... err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x7bc49c6b make: *** [domdoc.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mscoree: Search for Mono in some predefined paths before using the registry. (try 2)
by Alexandre Julliard 23 Sep '10

23 Sep '10

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > + /* Last: the registry */ > + return get_mono_path_from_registry(path); You probably want to check the registry first, to make it possible to override the global install if necessary. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 8/8] gameux: IGameStatistics::GetMaxStatsPerCategory implementation
by testbot＠testbot.winehq.org 23 Sep '10

23 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5432 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: configure: Detect resolver functionality on FreeBSD.
by Alexandre Julliard 23 Sep '10

23 Sep '10

Tijl Coosemans <tijl(a)coosemans.org> writes: > @@ -1270,13 +1270,12 @@ AC_SUBST(RESOLVLIBS,"") > if test "$ac_cv_header_resolv_h" = "yes" > then > ac_save_LIBS="$LIBS" > - LIBS="$LIBS -lresolv" > - AC_LINK_IFELSE([AC_LANG_PROGRAM([[#ifdef HAVE_NETINET_IN_H > -#include <netinet/in.h> > -#endif > -#include <resolv.h>]],[[res_init();]])], > - [AC_DEFINE(HAVE_RESOLV, 1, [Define if you have the resolver library and header]) > - RESOLVLIBS="-lresolv"]) > + AC_SEARCH_LIBS(res_init, resolv, > + AC_DEFINE(HAVE_RESOLV, 1, [Define if you have the resolver library and header])) > + case "$ac_cv_search_res_init" in > + no*) ;; > + *) RESOLVLIBS="$ac_cv_search_res_init" ;; > + esac This breaks on Linux. res_init() can be a macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 6/8] gameux: IGameStatistics::GetMaxValueLength implementation
by testbot＠testbot.winehq.org 23 Sep '10

23 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5430 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 1/8] gameux/tests: Add test of storing and reading game statistics (try2)
by testbot＠testbot.winehq.org 23 Sep '10

23 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5426 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 5/8] gameux: IGameStatistics::GetMaxNameLength implementation
by testbot＠testbot.winehq.org 23 Sep '10

23 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5429 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 4/8] gameux: IGameStatistics::GetMaxCategoryLength implementation
by testbot＠testbot.winehq.org 23 Sep '10

23 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5428 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 3/8] gameux: Add stub of IGameStatistics interface implementation (resend)
by testbot＠testbot.winehq.org 23 Sep '10

23 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5427 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3)
by James Mckenzie 23 Sep '10

23 Sep '10

-----Original Message----- >From: Ricardo Filipe <ricardojdfilipe(a)gmail.com> >Sent: Sep 22, 2010 1:18 PM >To: wine-devel(a)winehq.org >Subject: Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3) > >2010/9/21 Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com>: >> Thanks for the feedback Alexandre. The complexity of the wine APC & >> I/O system never stops amazing me. Third time's the charm? >> >> try 3: correctly use an apc to free internal async structures (which >> would explain why we have the apc parameter...). Strangely moving >> SetEvent & AddCompletion to the apc makes it not work (...an exercise >> for another time) >> try 2: use the new async i/o callbacks >> --- >> dlls/ws2_32/socket.c | 257 +++++++++++++++++++++++++++++++++++++++++++++- >> dlls/ws2_32/tests/sock.c | 14 ++- >> 2 files changed, 263 insertions(+), 8 deletions(-) >> >> >> >> > >thank you for the perseverence to make this possible in the main tree. > > +1. Thank you Mike. James McKenzie

2 1

Re: [PATCH 2/2] comctl32/tests: Default listview width appears to be 1 inch.
by testbot＠testbot.winehq.org 22 Sep '10

22 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5396 Your paranoid android. === W2K8SE (32 bit listview) === listview.c:4433: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4438: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === W7PROX64 (32 bit listview) === listview.c:4433: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4438: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3)
by Ricardo Filipe 22 Sep '10

22 Sep '10

2010/9/21 Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com>: > Thanks for the feedback Alexandre. The complexity of the wine APC & > I/O system never stops amazing me. Third time's the charm? > > try 3: correctly use an apc to free internal async structures (which > would explain why we have the apc parameter...). Strangely moving > SetEvent & AddCompletion to the apc makes it not work (...an exercise > for another time) > try 2: use the new async i/o callbacks > --- > dlls/ws2_32/socket.c | 257 +++++++++++++++++++++++++++++++++++++++++++++- > dlls/ws2_32/tests/sock.c | 14 ++- > 2 files changed, 263 insertions(+), 8 deletions(-) > > > > thank you for the perseverence to make this possible in the main tree.

2 1

Re: [1/2] d3dx9_36: D3DXDeclaratorFromFVF returns D3DERR_INVALIDCALL when an invalid declarator is passed.
by Henri Verbeet 22 Sep '10

22 Sep '10

On 22 September 2010 03:26, Misha Koshelev <misha680(a)gmail.com> wrote: > Credit for the idea of comparing the result of D3DXDeclaratorFromFVF > to D3DXFVFFromDeclarator goes to Tony Wasserka: > http://repo.or.cz/w/wine/d3dx9TW.git/blob/Merge:/dlls/d3dx9_36/mesh.c > (see line 405, and his comparison is vice versa - i.e., > D3DXDeclaratorFromFVF to D3DXFVFFromDeclarator) > --- That's insane. Any FVF validation should be done before starting the conversion, not afterwards by calling D3DXFVFFromDeclarator().

2 3

Re: [PATCH 1/4] kernel32: add test for WaitForSingleObject with lower 2 bits of handles set
by Paul Vriens 22 Sep '10

22 Sep '10

On 09/22/2010 07:53 PM, Peter Oberndorfer wrote: > + if(GetVersion()& 0x80000000) > + { > + win_skip("Handles work differently on win9x\n"); > + return; > + } > + > + signaled = CreateEventW(NULL, TRUE, TRUE, NULL); Hi Peter, You could just as easily check for the last error of CreateEventW which would be ERROR_CALL_NOT_IMPLEMENTED on win9x/winME. This is usually prefered above GetVersion(). I must say that I do see other GetVersion() calls in the kernel32 tests. The fact that you are using win_skip will make the tests fail if you run Wine in Win98 mode, but I guess nobody does that. -- Cheers, Paul.

1 0

Re: mscoree: Search for Mono in some predefined paths before using the registry.
by Alexandre Julliard 22 Sep '10

22 Sep '10

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > + hfind = FindFirstFileW(wildcard, &find_data); > + > + if (hfind == INVALID_HANDLE_VALUE) return FALSE; > + > + do { > + if (find_data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) > + { > + strcpyW(mono_path, folder); > + strcatW(mono_path, slash); > + strcatW(mono_path, find_data.cFileName); > + > + found = find_mono_dll(mono_path, mono_dll_path, &abi_version); > + } > + } while (!found && FindNextFileW(hfind, &find_data)); That seems quite dangerous. I don't think we want to use any random mono dll we find, especially in a way where we can't predict which one will be used. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] kernel32: add test for WaitForSingleObject with lower 2 bits of handles set
by testbot＠testbot.winehq.org 22 Sep '10

22 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5404 Your paranoid android. === W2K8SE (32 bit sync) === sync.c:856: Test failed: DeleteTimerQueueTimer sync.c:857: Test failed: ChangeTimerQueueTimer

1 0

Re: About the Gallium Direct3D 10/11 work
by Luca Barbieri 22 Sep '10

22 Sep '10

> I do have a concern which I addressed in the Wine Users mailing list: > > Wine is not only used with Linux, it is also used with other *nix implementations, to include the one that use, MacOSX. Will there be a port to this platform or some > sort of 'hook' that will allow the use of your drivers on this platform. If you want to use the Gallium D3D10/11 implementation on Mac OS X, you will need a Gallium driver that can run on Mac OS X. The software renderers probably already work. For hardware acceleration, my proposal is to write a new Gallium driver that uses OpenGL underneath and can thus run on any platform providing OpenGL. I think that implementing such a Gallium driver is easier than implementing D3D10/11 from scratch, and will also benefit Mesa, since it will be possible to test additions to the Gallium interface without needing to write hardware-specific code or writing software rasterization code. I'm not sure if I'll write such a Gallium driver myself. Contributions would be greatly welcome. It's a fun project and certainly much easier than writing an actual hardware driver. Alternatively, you could port the kernel DRM and drivers to Mac OS X and other systems, but that's much harder and much less user friendly. At any rate, nothing stops Wine from also implementing D3D10/11 using WineD3D or OpenGL, and using that if a Gallium driver is not available. Note however that D3D10/11 are totally different from D3D9, so I'm not sure how much you can share (especially if you want a fast implementation, which may be impossible anyway over OpenGL).

1 0

About the Gallium Direct3D 10/11 work
by Luca Barbieri 22 Sep '10

22 Sep '10

> If any one wishes to make any comments I'll include those as well as > contacting Luca Barbieri (?) or who ever is relevant to this over at > Gallium3D. Here I am :) As you have read, this is an initial (but working and with most of the code there) implementation of the D3D10/11 APIs. The plan is to ship all the core interfaces (ID3D10Device, ID3D11Device, ID3D11DeviceContext and supporting ones) in Mesa/Gallium, and make it available to native Linux applications. In addition, some Wine dlls will be provided with just the minimal amount of code to hook the Gallium implementation to Wine's HWNDs. They could be shipped either as part of Mesa or as part of Wine. The initial plan would be to ship them as part of Mesa, but if having anything else than Wine ship Wine DLLs is a problem, this could be revisited. Wine would however need to provide all the non-core APIs, such as D3DX and effects, which I don't think anyone will implement for Gallium. The HLSL compiler might come from the GLSL compiler, especially if the Intel team writing it were to decide to support Cg in addition to GLSL. Alternatively Wine could provide it. In the meantime, Microsoft DLLs will be used for all these. > like the fact that it's C++ C++ dramatically increases productivity, especially when implementing COM interfaces, which in C require a lot of unnecessary boilerplate. >needs X11 windows, The current implementation does, but it's very easy to port to anything else supported by Gallium (currently KMS consoles, fbdev and GDI). > and is limited to Mesa drivers, It's limited to Gallium drivers. If desired, this limitation can be circumvented by writing a Gallium driver that uses GL3/4 underneath. I think this could be the best way forward. Even if Wine were to finish its own D3D10/11 implementation over OpenGL, Gallium would still have its own implementation, because going through OpenGL causes massive unnecessary overhead, reliability problems and difficulty of debugging. Furthermore, this allows to provide Direct3D 10/11 features even if Mesa doesn't yet support the corresponding OpenGL features. In fact it's possible that Mesa will make available features like Direct3D 11 tessellation first in the d3d11 state tracker, and only later in the OpenGL state tracker. >from talking to Luca on IRC it sounds > like this is just the "easy" parts like e.g. resource transfers, > texture format conversion and basic draw calls Not at all. This is a full implementation of ID3D10Device, ID3D11Device, ID3D11DeviceContext and all the interfaces required by them, except for deferred contexts and things not yet supported by Gallium. It should support almost everything in the D3D 9.3 feature level, some of the D3D10.0 feature level and almost nothing of the D3D11 feature level. This is mostly due to the current limitations of Gallium. It includes a shader translator which supports all SM4 opcodes, although not all addressing modes and declarations are supported, and it has been tested quite little. Also some things like resinfo and switch/case/default/endswitch aren't yet implemented by most Gallium drivers. It supports texturing with separate resource and samplers by putting every (resource, sampler) pair in a traditional "texture unit". This will change for DX10 hardware once Gallium gets support for distinct resources and samplers. Of course, it's a very young implementation with almost no tests, so it will surely need a lot of small bug fixes to get fully working. It's much more advanced than the Wine implementation, which apparently doesn't seem to even implement OMSetRenderTargets, which is obviously essential for rendering anything. > The *hard* parts are figuring out things > like the shader and effect formats in a clean way. Both are fully documented. Microsoft ships an header for the shaders and source code for Effects11 at least. Shader parsing is already fully done. The "hard part" is doing the Gallium hardware drivers, and making them competitive with the proprietary ones. Implementing Direct3D 10/11 doesn't really have any truly hard part, just a lot of work, especially for the auxiliary parts like the HLSL compiler, D3DX and effects. >Luca took a bit of > a shortcut there by not doing effects at all, and using the DDK for > the shader format. Yes, and that's seem a reasonable move. Effects can be layered on top of the core API and thus are out of the scope of a Gallium state tracker. > That may or may not be ok, depending on what's > actually in the DDK, but I'm not going to take that risk for no good > reason. As far as I can tell, there is no risk. The EULA doesn't even attempt to prevent alternative implementations and it's just an header file, not source code. As far as I can tell, the DDK license does not seem more restrictive than the Windows SDK one > To my knowledge the effect format > isn't documented anywhere.) As far as I know, Microsoft ships full source code for the Direct3D 11 effects implementation at least, and thus it is fully documented in that. Even if Wine developers don't want to just read the Microsoft source code, you can have someone read it and document it. At any rate, reading source code and implementing based on the ideas learned is perfectly legal. Note however that this has _not_ been done for the code in Gallium, especially because it only implements core APIs, and Microsoft (obviously) doesn't release source code for them at all. Even the C++ IUnknown implementation and COM smart pointer is _not_ based on the ones in ATL or MFC, which I haven't even examined. > Suffice it to say that I'm extremely unhappy with > the way D3D development is currently going. I think this is unjustified. Getting a new, working, Direct3D 10 and 11 implementation seems to me quite a positive thing for Wine. It would be great if we could get past this initial impression and have Mesa and Wine work together on this. If you have any concerns, they can be addressed.

1 0

Re: winspool.drv: Support pDevMode field in {Get/Set}Job
by Detlef Riekenberg 22 Sep '10

22 Sep '10

Hi Vitaly. Thanks for fixing printing issues. You use sizeof(DEVMODEW) in you patch, but the correct size is: devmodeW->dmSize + devmodeW->dmDriverExtra You should change the FIXME in the comment of get_job_info_2 to a real FIXME, when unicode is FALSE I'm fine with the unicode - only patch for now, as the related code has to move to localspl later (localspl is unicode only). Thanks -- By by ... Detlef

2 1

Re: user32: Uncomment the GetWindowPlacement() test, fill the test data with real values. Take 2.
by testbot＠testbot.winehq.org 22 Sep '10

22 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5397 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: USB Device Support
by Damjan Jovanovic 22 Sep '10

22 Sep '10

On Wed, Sep 15, 2010 at 1:39 AM, Eric Durbin <eadurbin(a)gmail.com> wrote: > > > On Tue, Sep 14, 2010 at 10:48 AM, Damjan Jovanovic <damjan.jov(a)gmail.com> > wrote: >> >> When last I heard from Alexander Morozov (October 2009), he wasn't >> working on those patches much, and had no interest in sending them to >> wine-patches. >> >> I did some work on USB since then, and sent some patches starting from >> around March 2010 (too many attempts to list, search for them). Most >> were rejected. >> >> The USB story goes as follows: >> >> My libusb patch was rejected IIRC because the libusb situation was >> unclear. There's the old libusb-0.1 and the new more powerful >> libusb-1.0. IIRC each *nix hacked up its own specific variation of >> libusb that had to be detected specifically, and some *nixes didn't >> support the libusb-1.0 interface yet (libusb-1.0 itself only supports >> Linux and MacOS when last I checked, and they were doing a Windows >> port). >> >> The ntoskrnl that Wine currently emulates is total bogus: one process >> per driver, drivers all in separate processes from each other. On >> Windows there's a single address space for all drivers and they can >> communicate amongst themselves. I don't think inter-driver >> communication is that crucial initially, but it will be eventually >> (eg. last I heard, the iPod driver stacks on top of USBSTOR.SYS, and >> multi-function USB devices can use a different driver for each >> interface - these may communicate among themselves with private ioctl >> requests). The big problem with the multi process situation is >> hardware sharing: how do you set it up so each driver accesses its own >> and only its own hardware? >> >> Drivers either start on system startup (Wine starts those with the >> first process that starts), or get loaded on-demand as the hardware is >> plugged in. Most drivers should install themselves to be loaded >> on-demand. Who loads those and how? >> >> Windows uses USBHUB.SYS to do device I/O and load drivers on demand. >> Alexandre didn't want that dll because it exports nothing (all its >> features are accessible via internal ioctls), and suggested adding the >> features to USBD.SYS instead, which we already have and which has >> exports. Now USBD.SYS is linked to by most (but not all) USB drivers >> so (most of the time) it automatically gets loaded into each one - >> great right? - but it has no idea which driver it got loaded with, nor >> a straightforward way to determine which device(s!) that driver wants >> to drive. Also, since most drivers only load on-demand, the driver >> will never load, and thus this won't work unless we load those drivers >> on startup instead. The other approach, which I tried, was to get >> Wine's mountmgr.sys to detect USB devices using HAL, then pass them to >> a loaded-on-startup instance of USBHUB.SYS using a Wine-private ioctl, >> which would detect the driver for the device and launch a new instance >> of itself that would make a device object and load the driver to >> attach to it. This was all a bit a hack (USBHUB.SYS uses environment >> variables to tell the child which device and driver to run) and >> Alexandre also didn't the the Wine-private ioctls. Alexander Morozov's >> patch did things the Windows way: all drivers in one ntoskrnl process >> - this won't work properly in Wine for years, if ever, since ntoskrnl >> is so incomplete and one bad driver will crash them all. Another >> possibility could be to keep drivers in separate processes, but allow >> inter-process communication, but I see serializing IRPs between >> processes as being complex and very slow. >> >> Driver installation is also quite a mission. Windows detects that the >> hardware doesn't have a driver installed, and then generates the >> device ID and compatible IDs and searches .INF files for one that can >> support it. Our setupapi needs to be substantially improved to be able >> to do the same, and some newdev.dll and manual INF parsing work to >> install the driver may also be necessary, and I can already think of >> cases where even class installers will be necessary too :-(. >> >> Wine only sends DeviceIoControl to drivers. For anything non-trivial, >> other file-related user-space functions (at least ReadFile, WriteFile) >> need to go to the driver too. The infrastructure for this does not >> even exist yet, and would probably affects wineserver as well. >> >> Regression tests for ntosnkrl.exe and kernel drivers don't exist, and >> are difficult to come up with, since we'd have to compile and load >> drivers on Windows and run tests that don't crash Windows :-). >> >> So the architecture for USB support is tricky to say the least. But >> I'd still like to resume work on my USB patches some time soon, would >> you like to help? > > I'd be willing to help if you want some assistance. I don't know much about > the subject yet, but I'm reading programming the wdm atm. Firstly I'd like to find a cheap simple USB device that we can actually get working quickly. Earlier I was experimenting with my Blackberry driver, but that's not going far quickly, since it's a multi-protocol device (modem, mass storage, and proprietary protocols, etc.). I've got a USB scanner that's unsupported by SANE, but that needs ReadFile/WriteFile which is a lot of work by itself. Same with USB flash sticks. I can get hold of an iPod but that's probably the most complex, needing to stack on top of USBSTOR.SYS IIRC. Ironically drivers for the easy hardware (USB mice) are unnecessary anyway, since the Linux drivers are good enough, and the Windows drivers probably need to be driven from user-space by bits Wine doesn't have. Maybe I should give up and just get something partially working, add the rest later gradually. Any ideas? Then it's largely a matter of design. I think Alexandre's idea (process per driver, host all USB code in USBD.SYS) is good enough initially. Essentially the first steps would be: 1. libusb integration 2. driver loading hacks 3. driver -> devices lookup 4. usb bus enumeration for devices 5. create pdo and fdo for each device 6. AddDevice to driver 7. perform I/O for IRPs coming down from the driver using libusb I/O functions That should get a very basic driver (that only uses the control pipe) working. I'll try to get some of this done later this week/weekend. Damjan

3 11

D3D via Gallium
by Zachary Goldberg 22 Sep '10

22 Sep '10

Hello, I found the following article/commit very interesting this morning. Has anybody else been looking at this and put thought into whether it will work with Wine? http://cgit.freedesktop.org/mesa/mesa/commit/?id=92617aeac109481258f0c3863d… http://www.phoronix.com/scan.php?page=article&item=mesa_gallium3d_d3d11&num… -Zach

5 5

Re: user32: Uncomment the GetWindowPlacement() test, fill the test data with real values.
by Alexandre Julliard 21 Sep '10

21 Sep '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/user32/tests/msg.c | 141 +++++++++++++++++++++++++--------------------- > 1 files changed, 77 insertions(+), 64 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:10881: Test succeeded inside todo block: expected 120,120-210,210 got 120,120-210,210 msg.c:11314: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' make[1]: *** [msg.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] mscoree: Store the AppDomain from CorExeMain, for use in other functions.
by Vincent Povirk 21 Sep '10

21 Sep '10

On second thought, please don't commit this. It'll be better to design this around the COM interface in .NET 4, and easier to do that while the current code is simple. On Mon, Sep 20, 2010 at 4:15 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

1 0

Re: user32: Make sure that SendInput always initializes the time field.
by Alexandre Julliard 21 Sep '10

21 Sep '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch should fix the problem reported in the bug 24435. I don't think you want to modify the structure passed by the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures
by Alexandre Julliard 21 Sep '10

21 Sep '10

Mike Frysinger <vapier(a)gentoo.org> writes: > Newer versions of gcc/glibc with fortify checks enabled will complain > about the handling of the network's szNames field. Currently it is > always defined with a length of one which means writing more then a > single byte will trigger: > In function 'strcpy', inlined from '_ILCreateEntireNetwork' at > dlls/shell32/pidl.c:1762:15: > warning: call to __builtin___strcpy_chk will always overflow destination buffer > and then at runtime, we hit an abort(). > > Since this field is really serving as the header to an arbitrary buffer, > using a flexible array instead should solve the issue. What you want is ANYSIZE_ARRAY, which already exists. -- Alexandre Julliard julliard(a)winehq.org

6 12

Re: kernel32: fix use-after-close in create_process
by Dmitry Timoshkov 21 Sep '10

21 Sep '10

Dan Kegel <dank(a)kegel.com> wrote: > Spotted by Guillaume ORTEGA. He reports this fixes > http://bugs.winehq.org/show_bug.cgi?id=24101 > > Passes kernel32 tests. That's not a use after close, client's fd passed in the server call is used just as an association of the server side. -- Dmitry.

2 1

Re: ole32: Call the draw_continue function.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5372 Your paranoid android. === W98SE (32 bit ole2) === ole2.c:1284: Test failed: IViewObject_Draw with draw_continue_false returns 0x00000000 ole2.c:1063: Test failed: Expected draw_continue to be called instead of DataObject_DAdvise ole2.c:1063: Test failed: Expected draw_continue_false to be called instead of DataObject_DAdvise ole2.c:1072: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1072: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1308: Test failed: Method sequence starting from DataObject_DUnadvise not called ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1380: Test failed: Method sequence starting from DataObject_GetData not called

1 0

Re: user32: Uncomment the GetWindowPlacement() test, fill the test data with real values.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5370 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: ipconfig: Add the Polish translation.
by Paul Vriens 21 Sep '10

21 Sep '10

On 09/19/2010 11:11 AM, Łukasz Wojniłowicz wrote: > +#include "ipconfig.h" > + > +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT > + > +STRINGTABLE Hi Łukasz, This newly created file is UTF-8 so you should add the needed pragma (or convert to something else). Compiling this one results in: Warning: string "Spos�b u�ycia: ipconfig [ /? | /all ] " seems to be UTF-8 but codepage 1250 is in use. Warning: string "B��d: Nierozpoznany lub niepe�ny wiersz polecenia " seems to be UTF-8 but codepage 1250 is in use. Warning: string "Sufiks DNS konkretnego po��czenia" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Typ w�z�a" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Przekierowywanie IP w��czone" seems to be UTF-8 but codepage 1250 is in use. Warning: string "DHCP w��czone" seems to be UTF-8 but codepage 1250 is in use. The same is true for your "inetcpl: Add the Polish translation" patch. -- Cheers, Paul.

1 1

Re: user32: Do not test window state on the HCBT_SETFOCUS event, it's undefined.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5367 Your paranoid android. === W98SE (32 bit win) === win.c:2968: Test failed: message 000f available win.c:2980: Test failed: message 000f available win.c:2989: Test failed: message 000f available win.c:2998: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2682: Test failed: GetActiveWindow() = 0000000000000000 win.c:2682: Test failed: GetFocus() = 0000000000000000 win.c:2708: Test failed: GetActiveWindow() = 0000000000000000 win.c:2708: Test failed: GetFocus() = 0000000000000000 win.c:2767: Test failed: GetActiveWindow() = 0000000000000000 win.c:2767: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: UpdateLayeredWindow() should fail on non-layered or already initialized window.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5366 Your paranoid android. === W98SE (32 bit win) === win.c:2946: Test failed: hwnd 000004C4 message 0112 win.c:2948: Test failed: message 0100 available win.c:2969: Test failed: message 000f available win.c:2981: Test failed: message 000f available win.c:2990: Test failed: message 000f available win.c:2999: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006C01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006E01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000301A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006F01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000501A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000 win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000C016A fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000003301A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000003401A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000002019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000006019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000007019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000008201A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0000000000020198 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000C016A fg 0000000000010092 in hook HCBT_SETFOCUS

1 0

Re: [1/3] dinput: Add top level HID Collection detection to OSX joystick driver
by Vitaliy Margolen 21 Sep '10

21 Sep '10

On 09/19/2010 03:21 PM, Zachary Smith wrote: > This Patch: > Here I add find_osx_top_level() to the file, which is designed to identify > top level HID collections. It is independent from patch [2/3] but required > for patch [3/3] Your formatting does not match the rest of the file (curly braces on separate line), no space between opening / closing parentheses and content. And you should merge your 3 patches into one. First two just add dead code. Vitaliy.

2 2

[RFC] mmap override patch
by Chris Robinson 21 Sep '10

21 Sep '10

This is a patch that attempts to override mmap, mmap64, and munmap so that host libs can used memory from the Wine heap instead of being restricted to the address space Wine leaves unreserved. It is based on Albert Lee's patch found here: http://bugs.winehq.org/show_bug.cgi?id=13335#c170 It has been enhanced to fix the problem with using off64_t in the wine/library.h header by using ULONGLONG instead, and it should override the aforementioned functions with the correct prototype in 32-bit and 64-bit in a much simpler way. It currently relies on the system having mmap or mmap64 that uses a 64-bit offset type, though if that's a problem, an extra wrapper can probably be made. It also relies on ULONGLONG being a 64-bit type, but from what I can tell, that will always true. If there's a problem with it, or some way it can be improved, please let me know. :)

1 0

BugZilla: Changings for Bug 24177
by Joerg Schiermeier 20 Sep '10

20 Sep '10

--- skins/custom/index.css | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/skins/custom/index.css b/skins/custom/index.css index 2c40719..bf064c4 100644 --- a/skins/custom/index.css +++ b/skins/custom/index.css @@ -7,6 +7,8 @@ } div#login_box { position: relative; - top: 205px; +/** -causes an error- + * top: 205px; + */ text-align: left; } \ No newline at end of file -- 1.7.1

2 1

Any recommendations on 64-bit debugging tools?
by Ben Parker 20 Sep '10

20 Sep '10

For those of you who have developed 64-bit apps with wine, I'd like to ask what debugging tools and techniques you found most effective in that environment. Anyone have good luck with the 64-bit winedbg or remote debugging using Visual Studio? Thanks, Ben Parker ESRI

1 0

Re: libwine: Make addresses above 0x82000000 available on FreeBSD.
by Alexandre Julliard 20 Sep '10

20 Sep '10

Tijl Coosemans <tijl(a)coosemans.org> writes: > With this patch it is possible that a .dll.so is loaded beyond the > 2GiB limit, but this does not seem to be a problem in practice. All > mmap calls from within Wine and thus all .dll stay below 2GiB and core > .dll.so such as ntdll, kernel32, user32,... are also loaded below 2GiB > because they are loaded early and are placed in the 32MiB mentioned > above. Also note that a .dll.so is only loaded above 2GiB when needed, > i.e. the program wouldn't have worked at all without this patch. It is > preferred that Wine at least makes an attempt at running the program > and therefore loosens the restriction on the use of addresses above > 2GiB, especially since it seems to work so far. It would be better to fix this properly. If there's no way to convince FreeBSD's mmap to use all available space, you'll have to move the loader down to make some room. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 2/6] d3dcompiler: Implement D3DGetBlobPart().
by Henri Verbeet 20 Sep '10

20 Sep '10

I think it's close, but not entirely what I had in mind. You can avoid both the callback and some of the data copies if you just let parse_dxbc() create a list / array of sections. So you'd have something like this: struct dxbc_section { DWORD tag; const char *data; SIZE_T data_size; }; struct dxbc { UINT section_size; UINT section_count; struct dxbc_section *sections; }; with parse_dxbc() just calling something like dxbc_add_section() instead of chunk_handler(). The sections can just refer to the original data in the dxbc blob, it's then the responsibility of the caller to either make sure that data stays around for as long as the sections are needed or make a copy of the data. d3dcompiler_get_blob_part() would then just iterate over all the sections and add the relevant ones to a second dxbc struct, which it would pass to dxbc_write_blob() afterwards. I don't think dxbc_remove_section() is very useful in general, you'll pretty much always just want to add sections to a new section list. It's also simply unused in your current patch. dxbc_release() should be called dxbc_destroy(), you're not doing any reference counting, and the naming would be more consistent if you renamed parse_dxbc() to dxbc_parse().

2 3

Re: [PATCH 4/4] gameux: Add stub of IGameStatistics interface implementation
by testbot＠testbot.winehq.org 20 Sep '10

20 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5355 Your paranoid android. === W98SE (32 bit gamestatistics) === Failure running script in VM: Exceeded timeout limit of 315 sec === W7PRO (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists === W7PROX64 (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists

1 0

Re: [PATCH 2/4] gameux/tests: Add test of storing and reading game statistics
by testbot＠testbot.winehq.org 20 Sep '10

20 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5354 Your paranoid android. === W98SE (32 bit gamestatistics) === Failure running script in VM: Exceeded timeout limit of 315 sec === W7PRO (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists === W7PROX64 (32 bit gamestatistics) === gamestatistics.c:314: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists gamestatistics.c:396: Test failed: statistics file L"C:\\Users\\winetest\\AppData\\Local\\Microsoft\\Windows\\GameExplorer\\GameStatistics.gamestats1{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}\\{17A6558E-60BE-4078-B66F-9C3ADA2A32E6}.gamestats1" does not exists

1 0

Re: [PATCH 6/6] d3dcompiler: Implement D3DGetDebugInfo().
by Henri Verbeet 20 Sep '10

20 Sep '10

2010/9/19 Rico Schüller <kgbricola(a)web.de>: > --- I don't think this makes a lot of sense. D3DGetDebugInfo() clearly doesn't return a DXBC, so I think you should just memcpy it into the blob directly instead of trying to abuse dxbc_write(). This change would also make it impossible to write any DXBC containing an SDBG chunk, like e.g. the one you'd be parsing for D3DGetDebugInfo().

2 2

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 2)
by Alexandre Julliard 20 Sep '10

20 Sep '10

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > + wsa->read = HeapAlloc( GetProcessHeap(), 0, sizeof(*wsa->read) ); > + if (!wsa->read) > + { > + status = STATUS_NO_MEMORY; > + goto finish; > + } > + wsa->read->hSocket = wsa->accept_socket; > + wsa->read->flags = 0; > + wsa->read->addr = NULL; > + wsa->read->addrlen.ptr = NULL; > + wsa->read->n_iovecs = 1; > + wsa->read->first_iovec = 0; > + /* Includes 1 iovec, and that's all we need */ > + wsa->read->iovec[0].iov_base = wsa->buf; > + wsa->read->iovec[0].iov_len = wsa->data_len; > + SERVER_START_REQ( register_async ) > + { > + req->type = ASYNC_TYPE_READ; > + req->async.handle = wine_server_obj_handle( wsa->accept_socket ); > + req->async.callback = wine_server_client_ptr( WS2_async_recv_accept ); > + req->async.iosb = wine_server_client_ptr( iosb ); > + req->async.arg = wine_server_client_ptr( wsa ); > + status = wine_server_call( req ); > + } > + SERVER_END_REQ; > + > + if (status != STATUS_PENDING) > + goto finish; > + > + return STATUS_SUCCESS; > + > +finish: > + iosb->u.Status = status; > + iosb->Information = 0; > + > + if (wsa->user_overlapped->hEvent) > + SetEvent(wsa->user_overlapped->hEvent); > + if (wsa->cvalue) > + WS_AddCompletion( HANDLE2SOCKET(wsa->listen_socket), wsa->cvalue, iosb->u.Status, iosb->Information ); > + HeapFree( GetProcessHeap(), 0, wsa->read ); > + HeapFree( GetProcessHeap(), 0, wsa ); > + > + return status; > +} You cannot allocate or free memory in an async callback, because it can be called from a signal handler. All needed memory needs to be allocated beforehand, and freed in the user apc callback. -- Alexandre Julliard julliard(a)winehq.org

1 0

Regsvr32 running through Gecko
by James McKenzie 20 Sep '10

20 Sep '10

Interestingly enough, when Wine goes to update my .wine prefix, the updater is trying to run regsvr32 through Gecko. Of course, this crashes and the debugger cannot attach to the process as it terminates. err:ole:TLB_ReadTypeLib Loading of typelib L"C:\\windows\\system32\\msdatsrc.tlb" failed with error 2 Is this the desired action or should I 'flush' my .wine and start over? James McKenzie

2 2

Re: user32: Implement support for getting class data GCLP_HBRBACKGROUND on other process window
by Alexandre Julliard 20 Sep '10

20 Sep '10

Aleksey Bragin <aleksey(a)reactos.org> writes: > diff --git a/server/class.c b/server/class.c > index 0e402ba..90ab436 100644 > --- a/server/class.c > +++ b/server/class.c > @@ -47,6 +47,7 @@ struct window_class > int local; /* local class? */ > atom_t atom; /* class atom */ > mod_handle_t instance; /* module instance */ > + user_handle_t background; /* background brush handle */ > unsigned int style; /* class style */ > int win_extra; /* number of window extra bytes */ > client_ptr_t client_ptr; /* pointer to class in client address space */ Brushes are not user handles, and it doesn't make much sense to share them since the handles are process-local currently. -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] shell32: use flexible arrays to avoid fortify failures
by Joerg-Cyril.Hoehle＠t-systems.com 20 Sep '10

20 Sep '10

Hi, Alexandre Julliard wrote: >> it needs to be "foo[]". ANYSIZE_ARRAY is defined as 1 >True, you don't want to change the public one, but you can define a >shell32-specific version of it. At least then it looks like a normal >array declaration. Thank you for pointing to ANYSIZE_ARRAY. Why not cope with the way MS people recommend and use foo[ANYSIZE_ARRAY], together with the FIELD_OFFSET() macro? I found this article useful: http://blogs.msdn.com/b/oldnewthing/archive/2004/08/26/220873.aspx and made a note to use that in future patches. It explains why ANYSIZE_ARRAY MUST be 1. Should somebody submit patches to replace foo[1] with foo[ANYSIZE_ARRAY] where needed in Wine's include/*.h ? E.g. wingdi.h: BITMAPINFO comes to mind, it uses RGBQUAD bmiColors[1]; http://source.winehq.org/source/include/wingdi.h#L1912 ANYSIZE_ARRAY would be a perfect match here. Perhaps one can teach fortify about ANYSIZE_ARRAY? Regards, Jörg Höhle

1 0

Re: [PATCH 1/6] d3dcompiler: Add D3DGetBlobPart() stub.
by Henri Verbeet 20 Sep '10

20 Sep '10

2010/9/19 Rico Schüller <kgbricola(a)web.de>: > + FIXME("data %p, data_size %lu, part %#x, flags %u, blob %p stub!\n", data, data_size, part, flags, blob); I think %#x is more appropriate than %u for flags.

1 0

Re: [msi/tests] Prevent a popup on Windows NT
by testbot＠testbot.winehq.org 20 Sep '10

20 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5346 Your paranoid android. === W2KPROSP4 (32 bit install) === Timeout === WXPPROSP3 (32 bit install) === Timeout

1 0

Re: ipconfig: Add the Polish translation.
by Andrew Nguyen 19 Sep '10

19 Sep '10

2010/9/19 Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com>: > +/* > + * IP configuration utility > + * English language support > + * Pedantically, that should probably be "Polish language support".

2 2

Re: kernel32: Remove unused variable
by Vitaliy Margolen 19 Sep '10

19 Sep '10

On 09/19/2010 01:47 AM, Luca Bennati wrote: > > Found with scan-build provided by clang/llvm > > diff --git a/dlls/kernel32/virtual.c b/dlls/kernel32/virtual.c > index dcd5b85..a10bb6c 100644 > --- a/dlls/kernel32/virtual.c > +++ b/dlls/kernel32/virtual.c > @@ -648,17 +648,13 @@ BOOL WINAPI IsBadReadPtr( LPCVOID ptr, UINT size ) > __TRY > { > volatile const char *p = ptr; > - char dummy; > UINT count = size; > > while (count > page_size) > { > - dummy = *p; > p += page_size; > count -= page_size; > } > - dummy = p[0]; > - dummy = p[count - 1]; You can't do that. That's the whole point of this function - to test if particular address is readable. Vitaliy.

1 0

Wine without X? Failing in dlls/winex11.drv
by Gerald Pfeifer 19 Sep '10

19 Sep '10

Trying to build Wine on a new tester which initially had too few packages installed I ran into the following. In file included from bitblt.c:33: x11drv.h:30:22: error: X11/Xlib.h: No such file or directory x11drv.h:31:27: error: X11/Xresource.h: No such file or directory x11drv.h:32:23: error: X11/Xutil.h: No such file or directory x11drv.h:33:23: error: X11/Xatom.h: No such file or directory x11drv.h:44:21: error: X11/Xmd.h: No such file or directory x11drv.h:45:24: error: X11/Xproto.h: No such file or directory Indeed include/config.h has HAVE_X11_XLIB_H undefined since, well, all these headers indeed are missing. On the other hand, configure did not halt. In fact, configure did not even warn about this situation unlike it does in other cases. How to fix this? Should dlls/winex11.drv just not be built in such a case? Should configure error out? (We do have --without-x, too, though.) Anything else? Currently we do pass configure and then run into a compile failure later on. Gerald

3 3

Re: ws2_32: Fail when select is called with an invalid fd. (try 2)
by Alexandre Julliard 19 Sep '10

19 Sep '10

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > Fixed the pollfds leak from try 1. You are still leaking the file descriptors. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [urlmon/tests] Fix test failures on Win9x/WinMe by using more A-functions
by testbot＠testbot.winehq.org 19 Sep '10

19 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5328 Your paranoid android. === W2K8SE (32 bit url) === url.c:1337: Test failed: unexpected call OnProgress_SENDINGREQUEST

1 0

Re: user32: warnings (around uninitialized variables).
by Alexandre Julliard 19 Sep '10

19 Sep '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -388,6 +388,8 @@ static int DIB_GetBitmapInfo( const BITMAPINFOHEADER *header, LONG *width, > *compr = header->biCompression; > return 1; > } > + > + *width = *height = 0; > ERR("(%d): unknown/wrong size for header\n", header->biSize ); > return -1; > } 0 is not valid for a bitmap, these should never be used in the error case. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Fwd: Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by Alexander Morozov 19 Sep '10

19 Sep '10

> I have attached DVEdit.log.txt. In addition to problem with loading npf.sys, icdusb2.sys tries to use KeInitializeDeviceQueue which is not implemented and crashes.

2 2

autoconf 2.62 failure due to AS_VAR_IF
by Gerald Pfeifer 19 Sep '10

19 Sep '10

Using autoconf 2.62 on my primary test system I am getting: configure:26081: error: possibly undefined macro: AS_VAR_IF Indeed use of AS_VAR_IF appears relatively new, and it seems this may be similar to AS_VAR_APPEND where we have the following in configure.ac: dnl autoconf versions before 2.63b don't have AS_VAR_APPEND m4_ifdef([AS_VAR_APPEND],,[as_fn_append () { eval $[1]=\$$[1]\$[2]; } AC_DEFUN([AS_VAR_APPEND],[as_fn_append $1 $2])])dnl I assume we need something similar here, too? I am really far from an autoconf hacker -- is this something one of you could look into? Gerald

1 1

Re: Remove code which has been #if 0-ed for 11 years from DOSCONF_Device and DOSCONF_Install. (RESEND)
by Alexandre Julliard 19 Sep '10

19 Sep '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > An alternate patch would be putting #if 0 around the first occurrence > of loadhigh, too, but this code has been marked dead for more than 11 > years, so I really think it can / should go? It doesn't make sense to parse and not do anything with it. If you want to remove dead code you can remove essentially the entire file. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Use GCC's -Wlogical-op if possible
by Austin English 19 Sep '10

19 Sep '10

On Thu, Jun 18, 2009 at 12:32 PM, Gerald Pfeifer<gerald(a)pfeifer.com> wrote: > I verified this does not cause any extra warnings with GCC 4.4, whereas > GCC 4.5 will become quite a bit more useful in that regard and thus help > spot any issues. > > As with -Wtype-limits that I suggested last year, I pledge to keep close > an eye on this and to address any issues proactively as part of my nightly > test builds. > > Gerald > > ChangeLog: > Use GCC's -Wlogical-op if possible. > > diff --git a/configure.ac b/configure.ac > index bef311e..3f7a657 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1385,8 +1385,9 @@ then > WINE_TRY_CFLAGS([-fno-builtin],[AC_SUBST(BUILTINFLAG,"-fno-builtin")]) > WINE_TRY_CFLAGS([-fno-strict-aliasing]) > WINE_TRY_CFLAGS([-Wdeclaration-after-statement]) > - WINE_TRY_CFLAGS([-Wwrite-strings]) > + WINE_TRY_CFLAGS([-Wlogical-op]) > WINE_TRY_CFLAGS([-Wtype-limits]) > + WINE_TRY_CFLAGS([-Wwrite-strings]) > > dnl Check for noisy string.h > saved_CFLAGS="$CFLAGS" > > > Causes 106 more warnings on 4.3.3 of this sort: tab.c:693: warning: logical ‘&&’ with non-zero constant will always evaluate as true cert.c:1627: warning: logical ‘||’ with non-zero constant will always evaluate as true -- -Austin

8 18

GDI32 Font Test Errors with MacOSX build
by James McKenzie 19 Sep '10

19 Sep '10

Just wanted to see if any other Mac Wine user has the time to run the gdi32 tests and see if they get errors in the Font test. Thank you. James Mckenzie

2 1

wine performance wiki page
by Dan Kegel 19 Sep '10

19 Sep '10

Wine's performance is good, but in some areas doesn't match that of Windows. I figured a wiki page on the topic would be useful, so I created http://wiki.winehq.org/Performance It was kind of sparse, but Stefan just added a great 3d performance debugging tutorial to it. If there's anything important missing from that page, please feel free to add it. Hopefully this will help people hunt down performance bottlenecks in Wine.

2 2

Winetricks command
by M Hack 19 Sep '10

19 Sep '10

I have Ubuntu 10.04 and the repository ppa:ubuntu-wine/ppa installed. When following your instructions (http://wiki.winehq.org/winetricks) to run winetricks I encountered a problem Entering sh winetricks in a terminal window gave me the following error Cannot find wineprefixcreate (wineprefixcreate) With blind luck I tried entering just winetricks which worked, ie sh winetricks is not necessary. The error message was not informative and evidently is a hold over. It would help if this was stated on your wiki Mark <><

2 1

Unused code patch in: "mshtml: Added nsIURL::GetQuery implementation."
by Joris Huizer 18 Sep '10

18 Sep '10

Hello, I found a bit of unused code was introduced in commit ffe9cc87c0e759dffe2a19a96a1e5c7746c7ad62 "mshtml: Added nsIURL::GetQuery implementation." + ptr_end = url.lpszExtraInfo+url.dwExtraInfoLength; + for(ptr = url.lpszExtraInfo; ptr < ptr_end; ptr++) { + if(*ptr == '#') + break; + } + + ptr = url.lpszExtraInfo; Either the loop is leftover code, or the last (unconditional) assignment is wrong. HTH, Joris

2 1

Re: [Wine] Fwd: Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by "Mr. Teo En Ming (Zhang Enming) 张恩鸣 o f Singapore" 17 Sep '10

17 Sep '10

Dear James McKenzie, Yes, I have already applied the USB patches written by Alexander Morozov. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Citizenship: Singapore Citizen/Singaporean Facebook account: Teo En Ming (Zhang Enming) Facebook link: http://www.facebook.com/profile.php?id=100000750083982 Facebook photos: http://www.facebook.com/profile.php?id=100000750083982#!/profile.php?id=100… Facebook videos: http://www.facebook.com/profile.php?id=100000750083982&v=app_2392950137 Mobile Phone (Starhub pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com Location: Bedok Reservoir Road, Singapore ZIP: 470103 My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Mr. Teo En Ming (Zhang Enming) 张恩鸣 of Singapore: http://img543.imageshack.us/img543/5052/mrteoenmingzhangenmingo.jpg On 09/17/2010 11:18 PM, James Mckenzie wrote: > Alexander Morozov<amorozov(a)etersoft.ru> > >> >>> I have attached DVEdit.log.txt. >>> >> In addition to problem with loading npf.sys, icdusb2.sys tries to use >> KeInitializeDeviceQueue which is not implemented and crashes. >> >> > I suppose this is with your USB patches applied? > > [Sending to list in case personal message is bounced by my ISP.] > > James McKenzie > > > >

1 0

Re: Fwd: Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by "Mr. Teo En Ming (Zhang Enming) 张恩鸣 o f Singapore" 17 Sep '10

17 Sep '10

Dear Alexander Morozov, The debugging output is as follows: err:module:import_dll Library NDIS.SYS (which is needed by L"C:\\windows\\system32\\drivers\\npf.sys") not found err:winedevice:ServiceMain driver L"npf" failed to load fixme:ntoskrnl:KeInitializeSpinLock stub: 0x757e54 wine: Call from 0x7b837072 to unimplemented function ntoskrnl.exe.KeInitializeDeviceQueue, aborting wine: Unhandled page fault on read access to 0xbd1bf7ab at address 0x63b818 (thread 0036), starting debugger... fixme:dbghelp_msc:pe_load_debug_directory This guy has FPO information fixme:ntdll:server_ioctl_file Unsupported ioctl 2d1400 (device=2d access=0 func=500 method=0) fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub ALSA lib seq_hw.c:457:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory ALSA lib pcm.c:2171:(snd_pcm_open_conf) Cannot open shared library /usr/lib/alsa-lib/libasound_module_pcm_pulse.so ALSA lib pcm.c:2171:(snd_pcm_open_conf) Cannot open shared library /usr/lib/alsa-lib/libasound_module_pcm_pulse.so fixme:shell:SIC_IconAppend iconlists out of sync 0x4 0x3 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SIC_IconAppend iconlists out of sync 0x5 0x4 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SIC_IconAppend iconlists out of sync 0x6 0x5 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SIC_IconAppend iconlists out of sync 0x7 0x6 fixme:shell:SIC_IconAppend iconlists out of sync 0x8 0x7 fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub fixme:shell:SHGetDataFromIDListA SHGDFIL 3 stub Thank you. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Citizenship: Singapore Citizen/Singaporean Facebook account: Teo En Ming (Zhang Enming) Facebook link: http://www.facebook.com/profile.php?id=100000750083982 Facebook photos: http://www.facebook.com/profile.php?id=100000750083982#!/profile.php?id=100… Facebook videos: http://www.facebook.com/profile.php?id=100000750083982&v=app_2392950137 Mobile Phone (Starhub pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com Location: Bedok Reservoir Road, Singapore ZIP: 470103 My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Mr. Teo En Ming (Zhang Enming) 张恩鸣 of Singapore: http://img543.imageshack.us/img543/5052/mrteoenmingzhangenmingo.jpg On 09/17/2010 09:17 PM, Alexander Morozov wrote: > Dear Teo En Ming, > > There may be many reasons for this: > 1) a program uses some not fully implemented setupapi functions to find a > device > 2) a program can not open a device file created by a driver (driver did not > create device file due to some errors) > 3) a program is trying to use Read/WriteFile for device file, this is not > supported now > 4) may be something else > > Try WINEDEBUG=+setupapi,+file,+winedevice,+ntoskrnl,+usbhub > > Best regards, > Alexander Morozov > > On Friday 17 September 2010 14:12:30 Mr. Teo En Ming (Zhang Enming) 张恩鸣 of > Singapore wrote: > >> Dear Alexander Morozov, >> >> From the output of the command "ps -ef | grep wine", we can observe >> that the native Windows USB driver ICDUSB2.sys for the Sony IC Recorder >> gets loaded with winedevice.exe. >> >> enming 18814 18781 0 16:15 ? 00:00:00 >> C:\windows\system32\winedevice.exe ICDUSB2 >> >> However, Digital Voice Editor 3 (under Wine) simply would not detect the >> Sony IC Recorder. The dialog box says: >> >> "Could not communicate with IC Recorder. >> Make sure that the cable is connected properly. >> >> Remove the cable from the IC Recorder and then connect it again. >> >> If another user is operating the Digital Voice Editor, quit the software." >> >

2 2

Re: Fwd: Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by "Mr. Teo En Ming (Zhang Enming) 张恩鸣 o f Singapore" 17 Sep '10

17 Sep '10

Dear Alexander Morozov, Thank you for your response. I have tried to ensure that the permissions for the Sony IC Recorder in /dev/bus/usb/005/009 is crw-rw-rw- by executing the following command: chmod o+rw /dev/bus/usb/005/009 However, Sony Digital Voice Editor 3 still cannot detect the IC Recorder. Do you have any more ideas? Thank you. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Citizenship: Singapore Citizen/Singaporean Facebook account: Teo En Ming (Zhang Enming) Facebook link: http://www.facebook.com/profile.php?id=100000750083982 Facebook photos: http://www.facebook.com/profile.php?id=100000750083982#!/profile.php?id=100… Facebook videos: http://www.facebook.com/profile.php?id=100000750083982&v=app_2392950137 Mobile Phone (Starhub pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com Location: Bedok Reservoir Road, Singapore ZIP: 470103 My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Mr. Teo En Ming (Zhang Enming) 张恩鸣 of Singapore: http://img543.imageshack.us/img543/5052/mrteoenmingzhangenmingo.jpg On 09/17/2010 09:21 PM, Alexander Morozov wrote: > Dear Teo En Ming, > > Do you set +rw permission for a device in /dev/bus/usb/<bus>/<device> ? > > Best regards, > Alexander Morozov > > On Friday 17 September 2010 14:12:30 Mr. Teo En Ming (Zhang Enming) 张恩鸣 of > Singapore wrote: > >> Dear Alexander Morozov, >> >> From the output of the command "ps -ef | grep wine", we can observe >> that the native Windows USB driver ICDUSB2.sys for the Sony IC Recorder >> gets loaded with winedevice.exe. >> >> enming 18814 18781 0 16:15 ? 00:00:00 >> C:\windows\system32\winedevice.exe ICDUSB2 >> >> However, Digital Voice Editor 3 (under Wine) simply would not detect the >> Sony IC Recorder. The dialog box says: >> >> "Could not communicate with IC Recorder. >> Make sure that the cable is connected properly. >> >> Remove the cable from the IC Recorder and then connect it again. >> >> If another user is operating the Digital Voice Editor, quit the software." >> > >

2 2

Re: inetcpl: Implement LaunchSiteCertDialog on top of cryptui.CryptUIDlgCertMgr
by Juan Lang 17 Sep '10

17 Sep '10

Hi Detlef, I have no issue with the patch, just a question: are you sure native does this? Or does it call wintrust.OpenPersonalTrustDBDialog? I'm really not sure myself, I just recall that, when using native inetcpl, clicking on the Certificates... button in the Content tab (in the English locale, names are of course different in other locales) resulted in a call to wintrust.OpenPersonalTrustDBDialog, which in turn calls crypui.CryptUIDlgCertMgr. Regards, --Juan

2 2

Re: user32: Implement support for getting class data GCLP_HBRBACKGROUND on other process window
by Aleksey Bragin 17 Sep '10

17 Sep '10

Some comments regarding this patch. It's a beginning of a series of patches aimed to improve the desktop mode of Wine, including support for a real Explorer-alike environment (which is Martin Fuchs' explorer at the moment). So this patch implements required GetClassLong functionality of getting background brush handle of another process window's class. I think other apps also require this (e.g. I saw a similar bug in Wine's Bugzilla regarding Microsoft Project 2000), but it is not so critical as in Martin's explorer. WBR, Aleksey Bragin. On Sep 17, 2010, at 10:13 PM, Aleksey Bragin wrote: > <0001-user32-Implement-support-for-getting-class-data-GCL.patch> >

2 1

Re: winhlp32: Added Hebrew translation
by Paul Vriens 17 Sep '10

17 Sep '10

On 09/17/2010 06:31 PM, Yaron Shahrabani wrote: > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > + Hi Sharon, This line should be removed. It results in: winebuild: duplicate resource type 0004 name f001 language 0409 winebuild: duplicate resource type 0005 name 0150 language 0409 winebuild: duplicate resource type 0005 name 0152 language 0409 winebuild: duplicate resource type 0006 name 0013 language 0409 winebuild: duplicate resource type 0006 name 0014 language 0409 winegcc: ../../tools/winebuild/winebuild failed Why didn't you add the 'WS_EX_LAYOUTRTL' to the dialogs btw? -- Cheers, Paul.

1 0

Re: d3dx9: Constant table parsing foundations.
by testbot＠testbot.winehq.org 17 Sep '10

17 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5298 Your paranoid android. === W7PROX64 (64 bit shader) === shader.c:151: Test failed: Got result 0, expected 88760b59 (D3DXERR_INVALIDDATA)

1 0

New winetricks 20100917: new verbs crypt32, devenum, d3dx9_26, winhttp
by Dan Kegel 17 Sep '10

17 Sep '10

Another fortnight, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: crypt32: added (Issue 162). devenum: added (Issue 163). divx: update sha1sum dotnet30: fix breakage from last release dxsdk_nov2006: support silent install firefox: update to 3.6.10 mingw: fix downwload urls winhttp: added (for e.g. ffxiv) Andrew Nguyen: fix gecko-dbg for new gecko Dan Kegel: d3dx9_26: added (for e.g. civ4_demo)

1 0

Re: mshtml: Update the Polish translation.
by Jacek Caban 17 Sep '10

17 Sep '10

Hi Łukasz, On 9/17/10 10:02 AM, Łukasz Wojniłowicz wrote: > --- > dlls/mshtml/Pl.rc | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/dlls/mshtml/Pl.rc b/dlls/mshtml/Pl.rc > index 9e0a635..0c37be4 100644 > --- a/dlls/mshtml/Pl.rc > +++ b/dlls/mshtml/Pl.rc > @@ -22,6 +22,12 @@ > > LANGUAGE LANG_POLISH, SUBLANG_DEFAULT > > +STRINGTABLE > +{ > + IDS_STATUS_DONE "Sko�czone" > + IDS_STATUS_DOWNLOADINGFROM "Pobieranie od %s..." 'Pobieranie z %s...' seems better in this case (although I think there should be a better translation). Jacek

1 0

Unable to Get Sony IC Recorder (Digital Voice Editor 3.3.01) to Work with 32-bit Wine (Windows Emulator) in 64-bit Fedora 11 x86_64 Linux
by "Mr. Teo En Ming (Zhang Enming) 张恩鸣 o f Singapore" 17 Sep '10

17 Sep '10

Dear All, With reference to the article entitled "USB device support in wine" by Alexander Morozov at http://wiki.winehq.org/USB, here is the list of steps I have taken to download, configure, compile and install Wine. git clone git://source.winehq.org/git/wine.git ~/wine-git cd ~/wine-git Check out the development release of Wine. git checkout wine-1.3.2 wget ftp://ftp.etersoft.ru/pub/people/amorozov/usb/1.3.2/0001-Add-support-of-native-Windows-drivers-for-USB-tokens.txt wget ftp://ftp.etersoft.ru/pub/people/amorozov/usb/1.3.2/0002-Re-generate-some-files.txt git am 0001-Add-support-of-native-Windows-drivers-for-USB-tokens.txt 0002-Re-generate-some-files.txt tools/make_makefiles Install dependencies before building and installing Wine. Please refer to the article entitled "WineOn64bit" at http://wiki.winehq.org/WineOn64bit#head-9cca3efe8b57810a966d04db51d8000e601… Switch to superuser. yum install alsa-lib-devel.i586 alsa-lib-devel audiofile-devel.i586 audiofile-devel cups-devel.i586 cups-devel dbus-devel.i586 dbus-devel esound-devel.i586 esound-devel fontconfig-devel.i586 fontconfig-devel freetype-devel.i586 freetype-devel giflib-devel.i586 giflib-devel hal-devel.i586 hal-devel lcms-devel.i586 lcms-devel libICE-devel.i586 libICE-devel libjpeg-devel.i586 libjpeg-devel libpng-devel.i586 libpng-devel libSM-devel.i586 libSM-devel libusb-devel.i586 libusb-devel libX11-devel.i586 libX11-devel libXau-devel.i586 libXau-devel libXcomposite-devel.i586 libXcomposite-devel libXcursor-devel.i586 libXcursor-devel libXext-devel.i586 libXext-devel libXi-devel.i586 libXi-devel libXinerama-devel.i586 libXinerama-devel libxml2-devel.i586 libxml2-devel libXrandr-devel.i586 libXrandr-devel libXrender-devel.i586 libXrender-devel libxslt-devel.i586 libxslt-devel libXt-devel.i586 libXt-devel libXv-devel.i586 libXv-devel libXxf86vm-devel.i586 libXxf86vm-devel mesa-libGL-devel.i586 mesa-libGL-devel mesa-libGLU-devel.i586 mesa-libGLU-devel ncurses-devel.i586 ncurses-devel openldap-devel.i586 openldap-devel openssl-devel.i586 openssl-devel zlib-devel.i586 pkgconfig sane-backends-devel.i586 sane-backends-devel xorg-x11-proto-devel glibc-devel.i586 prelink fontforge flex bison Log out of superuser. Install libusb 1.0 development headers. Binary packages are located at http://ringtail.its.monash.edu.au/pub/fedora/linux/updates/11/i386/ wget http://ringtail.its.monash.edu.au/pub/fedora/linux/updates/11/i386/libusb1-… wget http://ringtail.its.monash.edu.au/pub/fedora/linux/updates/11/i386/libusb1-… wget http://ringtail.its.monash.edu.au/pub/fedora/linux/updates/11/i386/libusb1-… Switch to superuser. rpm -ivh libusb1-1.0.6-1.fc11.i586.rpm rpm -ivh libusb1-devel-1.0.6-1.fc11.i586.rpm rpm -ivh libusb1-static-1.0.6-1.fc11.i586.rpm cd /usr/include ln -s /usr/include/libusb-1.0/libusb.h Log out of superuser. cd ~/wine-git ./configure Check config.log to ensure that libusb 1.0 is detected. grep libusb config.log make depend make Switch to superuser. make install Log out of superuser. Install Sony Digital Voice Editor 3.3.01 in Wine. cd ~/downloads wine DVESetup_EN.exe Export the following three files (01.reg, 02.reg, and 03.reg) from the registry in native Windows. 01.reg ==== Windows Registry Editor Version 5.00 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\Vid_054c&Pid_0271\5&2c3081c&0&2] "DeviceDesc"="Sony IC Recorder (P)" "LocationInformation"="Sony IC Recorder (P)" "Capabilities"=dword:00000084 "UINumber"=dword:00000000 "HardwareID"=hex(7):55,00,53,00,42,00,5c,00,56,00,69,00,64,00,5f,00,30,00,35,\ 00,34,00,63,00,26,00,50,00,69,00,64,00,5f,00,30,00,32,00,37,00,31,00,26,00,\ 52,00,65,00,76,00,5f,00,30,00,31,00,30,00,30,00,00,00,55,00,53,00,42,00,5c,\ 00,56,00,69,00,64,00,5f,00,30,00,35,00,34,00,63,00,26,00,50,00,69,00,64,00,\ 5f,00,30,00,32,00,37,00,31,00,00,00,00,00 "CompatibleIDs"=hex(7):55,00,53,00,42,00,5c,00,43,00,6c,00,61,00,73,00,73,00,\ 5f,00,66,00,66,00,26,00,53,00,75,00,62,00,43,00,6c,00,61,00,73,00,73,00,5f,\ 00,30,00,30,00,26,00,50,00,72,00,6f,00,74,00,5f,00,30,00,30,00,00,00,55,00,\ 53,00,42,00,5c,00,43,00,6c,00,61,00,73,00,73,00,5f,00,66,00,66,00,26,00,53,\ 00,75,00,62,00,43,00,6c,00,61,00,73,00,73,00,5f,00,30,00,30,00,00,00,55,00,\ 53,00,42,00,5c,00,43,00,6c,00,61,00,73,00,73,00,5f,00,66,00,66,00,00,00,00,\ 00 "ClassGUID"="{36FC9E60-C465-11CF-8056-444553540000}" "Class"="USB" "Driver"="{36FC9E60-C465-11CF-8056-444553540000}\\0003" "Mfg"="Sony Corporation" "Service"="ICDUSB2" "ConfigFlags"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\Vid_054c&Pid_0271\5&2c3081c&0&2\Device Parameters] "ExtPropDescSemaphore"=dword:00000001 "SymbolicName"="\\??\\USB#Vid_054c&Pid_0271#5&2c3081c&0&2#{a5dcbf10-6530-11d2-901f-00c04fb951ed}" [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\Vid_054c&Pid_0271\5&2c3081c&0&2\LogConf] 02.reg ==== Windows Registry Editor Version 5.00 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\Vid_054c&Pid_0271\6&3a9497ab&0&8] "DeviceDesc"="Sony IC Recorder (P)" "LocationInformation"="Sony IC Recorder (P)" "Capabilities"=dword:00000084 "UINumber"=dword:00000000 "HardwareID"=hex(7):55,00,53,00,42,00,5c,00,56,00,69,00,64,00,5f,00,30,00,35,\ 00,34,00,63,00,26,00,50,00,69,00,64,00,5f,00,30,00,32,00,37,00,31,00,26,00,\ 52,00,65,00,76,00,5f,00,30,00,31,00,30,00,30,00,00,00,55,00,53,00,42,00,5c,\ 00,56,00,69,00,64,00,5f,00,30,00,35,00,34,00,63,00,26,00,50,00,69,00,64,00,\ 5f,00,30,00,32,00,37,00,31,00,00,00,00,00 "CompatibleIDs"=hex(7):55,00,53,00,42,00,5c,00,43,00,6c,00,61,00,73,00,73,00,\ 5f,00,66,00,66,00,26,00,53,00,75,00,62,00,43,00,6c,00,61,00,73,00,73,00,5f,\ 00,30,00,30,00,26,00,50,00,72,00,6f,00,74,00,5f,00,30,00,30,00,00,00,55,00,\ 53,00,42,00,5c,00,43,00,6c,00,61,00,73,00,73,00,5f,00,66,00,66,00,26,00,53,\ 00,75,00,62,00,43,00,6c,00,61,00,73,00,73,00,5f,00,30,00,30,00,00,00,55,00,\ 53,00,42,00,5c,00,43,00,6c,00,61,00,73,00,73,00,5f,00,66,00,66,00,00,00,00,\ 00 "ClassGUID"="{36FC9E60-C465-11CF-8056-444553540000}" "Class"="USB" "Driver"="{36FC9E60-C465-11CF-8056-444553540000}\\0007" "Mfg"="Sony Corporation" "Service"="ICDUSB2" "ConfigFlags"=dword:00000000 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\Vid_054c&Pid_0271\6&3a9497ab&0&8\Device Parameters] "ExtPropDescSemaphore"=dword:00000001 "SymbolicName"="\\??\\USB#Vid_054c&Pid_0271#6&3a9497ab&0&8#{a5dcbf10-6530-11d2-901f-00c04fb951ed}" [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\USB\Vid_054c&Pid_0271\6&3a9497ab&0&8\LogConf] 03.reg ==== Windows Registry Editor Version 5.00 [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\ICDUSB2] "Type"=dword:00000001 "Start"=dword:00000003 "ErrorControl"=dword:00000001 "ImagePath"="c:\windows\system32\drivers\ICDUSB2.sys" "DisplayName"="Sony IC Recorder (P)" [HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\ICDUSB2\Security] "Security"=hex:01,00,14,80,90,00,00,00,9c,00,00,00,14,00,00,00,30,00,00,00,02,\ 00,1c,00,01,00,00,00,02,80,14,00,ff,01,0f,00,01,01,00,00,00,00,00,01,00,00,\ 00,00,02,00,60,00,04,00,00,00,00,00,14,00,fd,01,02,00,01,01,00,00,00,00,00,\ 05,12,00,00,00,00,00,18,00,ff,01,0f,00,01,02,00,00,00,00,00,05,20,00,00,00,\ 20,02,00,00,00,00,14,00,8d,01,02,00,01,01,00,00,00,00,00,05,0b,00,00,00,00,\ 00,18,00,fd,01,02,00,01,02,00,00,00,00,00,05,20,00,00,00,23,02,00,00,01,01,\ 00,00,00,00,00,05,12,00,00,00,01,01,00,00,00,00,00,05,12,00,00,00 Import the above three files (01.reg, 02.reg and 03.reg) into the Wine registry. cd cd .wine/drive_c/Program\ Files/Sony/ICD-P\ Series\ Driver/ cp IcdUSB2.sys ../../../windows/system32/drivers/ Double click on the Digital Voice Editor 3 icon which has been installed by Wine on the GNOME Desktop to launch Digital Voice Editor 3. ps -ef | grep wine enming 18777 1 1 16:15 ? 00:00:00 /usr/local/bin/wineserver enming 18783 18781 0 16:15 ? 00:00:00 C:\windows\system32\winedevice.exe MountMgr enming 18788 18783 0 16:15 ? 00:00:00 C:\windows\system32\winedevice.exe enming 18800 18781 0 16:15 ? 00:00:00 C:\windows\system32\winedevice.exe PxHelp20 enming 18806 18781 0 16:15 ? 00:00:00 C:\windows\system32\winedevice.exe Usbhub enming 18814 18781 0 16:15 ? 00:00:00 C:\windows\system32\winedevice.exe ICDUSB2 The Digital Voice Editor is unable to detect the Sony IC Recorder which has been plugged into the system via an USB cable. lsusb Bus 005 Device 006: ID 054c:0271 Sony Corp. IC Recorder (P) There are no kernel modules for the Sony IC Recorder and hence no device node entries in /dev. Please advise. Thank you very much. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Citizenship: Singapore Citizen/Singaporean Facebook account: Teo En Ming (Zhang Enming) Facebook link: http://www.facebook.com/profile.php?id=100000750083982 Facebook photos: http://www.facebook.com/profile.php?id=100000750083982#!/profile.php?id=100… Facebook videos: http://www.facebook.com/profile.php?id=100000750083982&v=app_2392950137 Mobile Phone (Starhub pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com Location: Bedok Reservoir Road, Singapore ZIP: 470103 My Open Letter (Plea for Medical Help/Assistance) to World Leaders (Updated 28 August 2010):- http://lists.mcs.anl.gov/pipermail/mpich-discuss/2010-August/007811.html http://mythtv.org/pipermail/mythtv-users/2010-August/295952.html http://archives.gentoo.org/gentoo-user/msg_f6a341d9623fda17880159b137c07335… Photo of Mr. Teo En Ming (Zhang Enming) 张恩鸣 of Singapore: http://img543.imageshack.us/img543/5052/mrteoenmingzhangenmingo.jpg

1 0

Sound on TestBot
by Greg Geldorp 17 Sep '10

17 Sep '10

I've found a way to add a soundcard to most of the TestBot VMs (using the virtual soundcard driver from VMware View). Yesterday, I added one to WXPHMNLSP3 just to see how it works out. Seems to do ok, it is now actually running sound tests, see e.g. http://test.winehq.org/data/190c3518d66df44cfa464d8dc1ca3fd50ff6c361/xp_wtb…. It does introduce some test failures though, see http://test.winehq.org/data/190c3518d66df44cfa464d8dc1ca3fd50ff6c361/xp_wtb…. I intend to add soundcards to other VMs over the weekend, this message is basically a heads up that more sound test failures might show up, not because the tests have suddenly degraded, but because they will be run on additional VMs. Ge.

1 0

Re: secur32: Handle extra data in schan_InitializeSecurityContextW (try2)
by testbot＠testbot.winehq.org 17 Sep '10

17 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5288 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === No test summary line found

1 0

Re: ddraw: Add checking of SURFACEDESC type/nullness into CreateSurface methods.
by testbot＠testbot.winehq.org 17 Sep '10

17 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5285 Your paranoid android. === W98SE (32 bit dsurface) === No test summary line found

1 0

Re: [4/4] msxml3/tests: Store test data as a table for ::nodeTypedValue() tests
by testbot＠testbot.winehq.org 17 Sep '10

17 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5279 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:5089: Test failed: expected 7322.9371, got L"7322,9371" domdoc.c:5082: Test failed: expected 40135.14, got L"40135,14" domdoc.c:5082: Test failed: expected 37813.59, got L"37813,59" domdoc.c:5082: Test failed: expected 0.5813889, got L"0,5813889" domdoc.c:5082: Test failed: expected 1.112512, got L"1,112512" domdoc.c:5089: Test failed: expected 0.412, got L"0,412" domdoc.c:5089: Test failed: expected 41221.421, got L"41221,421" === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:5089: Test failed: expected 7322.9371, got L"7322,9371" domdoc.c:5082: Test failed: expected 40135.14, got L"40135,14" domdoc.c:5082: Test failed: expected 37813.59, got L"37813,59" domdoc.c:5082: Test failed: expected 0.5813889, got L"0,5813889" domdoc.c:5082: Test failed: expected 1.112512, got L"1,112512" domdoc.c:5089: Test failed: expected 0.412, got L"0,412" domdoc.c:5089: Test failed: expected 41221.421, got L"41221,421" === W7PROX64 (32 bit domdoc) === domdoc.c:5089: Test failed: expected 7322.9371, got L"7322,9371" domdoc.c:5082: Test failed: expected 40135.14, got L"40135,14" domdoc.c:5082: Test failed: expected 37813.59, got L"37813,59" domdoc.c:5082: Test failed: expected 0.5813889, got L"0,5813889" domdoc.c:5082: Test failed: expected 1.112512, got L"1,112512" domdoc.c:5089: Test failed: expected 0.412, got L"0,412" domdoc.c:5089: Test failed: expected 41221.421, got L"41221,421" === W7PROX64 (64 bit domdoc) === domdoc.c:5089: Test failed: expected 7322.9371, got L"7322,9371" domdoc.c:5082: Test failed: expected 40135.14, got L"40135,14" domdoc.c:5082: Test failed: expected 37813.59, got L"37813,59" domdoc.c:5082: Test failed: expected 0.5813889, got L"0,5813889" domdoc.c:5082: Test failed: expected 1.112512, got L"1,112512" domdoc.c:5089: Test failed: expected 0.412, got L"0,412" domdoc.c:5089: Test failed: expected 41221.421, got L"41221,421"

2 1

Re: secur32: Handle extra data in schan_InitializeSecurityContextW.
by testbot＠testbot.winehq.org 17 Sep '10

17 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5281 Your paranoid android. === WNT4WSSP6 (32 bit schannel) === No test summary line found === W2KPROSP4 (32 bit schannel) === schannel.c:654: Test failed: status = 80090304 schannel.c:661: Test failed: status = 80090301 schannel.c:671: Test failed: InitializeSecurityContext failed: 80090301 No test summary line found === WXPPROSP3 (32 bit schannel) === schannel.c:654: Test failed: status = 80090304 schannel.c:661: Test failed: status = 80090301 schannel.c:671: Test failed: InitializeSecurityContext failed: 80090301 schannel.c:693: Test failed: EncryptMessage failed: 80090301 === W2K3R2SESP2 (32 bit schannel) === schannel.c:671: Test failed: InitializeSecurityContext failed: 80090321 schannel.c:693: Test failed: EncryptMessage failed: 80090301 === WVISTAADM (32 bit schannel) === schannel.c:654: Test failed: status = 80090318 schannel.c:661: Test failed: status = 80090318 schannel.c:654: Test failed: status = 00000000 schannel.c:661: Test failed: status = 80090321 schannel.c:671: Test failed: InitializeSecurityContext failed: 80090308 === W2K8SE (32 bit schannel) === schannel.c:654: Test failed: status = 80090318 schannel.c:661: Test failed: status = 80090318 schannel.c:654: Test failed: status = 00000000 schannel.c:661: Test failed: status = 80090321 schannel.c:671: Test failed: InitializeSecurityContext failed: 80090308 === W7PRO (32 bit schannel) === schannel.c:654: Test failed: status = 00090312 schannel.c:661: Test failed: status = 80090326 schannel.c:671: Test failed: InitializeSecurityContext failed: 80090300 schannel.c:693: Test failed: EncryptMessage failed: 80090301 === W7PROX64 (32 bit schannel) === schannel.c:654: Test failed: status = 00090312 schannel.c:661: Test failed: status = 80090326 schannel.c:671: Test failed: InitializeSecurityContext failed: 80090300 No test summary line found === W7PROX64 (64 bit schannel) === schannel.c:654: Test failed: status = 00090312 schannel.c:661: Test failed: status = 80090326 schannel.c:671: Test failed: InitializeSecurityContext failed: 80090300 schannel.c:693: Test failed: EncryptMessage failed: 80090301

1 0

Re: [1/2]user32: remove unnecessary code (try 2)
by Alexandre Julliard 16 Sep '10

16 Sep '10

André Hentschel <nerv(a)dawncrow.de> writes: > that code is in an else-case of an other "if (!(uFlags & DFCS_TRANSPARENT))" No it's not. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/2]user32: remove superfluous code
by Juan Lang 16 Sep '10

16 Sep '10

Hi André, > that code is in an else-case of an other "if (!(uFlags & DFCS_TRANSPARENT))" In that case, can't you remove the ternary operation in this line? UITOOLS95_DrawRectEdge(dc, r, edge, (uFlags & DFCS_FLAT) | ((uFlags & DFCS_TRANSPARENT) ? 0 : BF_MIDDLE) | BF_RECT | BF_SOFT); --Juan

1 0

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword
by Dmitry Timoshkov 16 Sep '10

16 Sep '10

Marcus Meissner <marcus(a)jet.franken.de> wrote: > + unk = NULL; > hr = IDropTarget_QueryInterface(pDropTarget, &IID_IUnknown, (void**)&unk); > if(FAILED(hr)) > { > IStream_Release(stream); > return hr; > } > + if (!unk) { > + WARN("hr was %d, but unk is NULL.\n", hr); > + IStream_Release(stream); > + return E_NOINTERFACE; > + } > hr = CoMarshalInterface(stream, &IID_IDropTarget, unk, MSHCTX_LOCAL, NULL, MSHLFLAGS_TABLESTRONG); > IUnknown_Release(unk); Huw suggested a more simple solution which doesn't lead to duplicated code: + unk = NULL; hr = IDropTarget_QueryInterface(pDropTarget, &IID_IUnknown, (void**)&unk); + if (!unk) hr = E_NOINTERFACE; if(FAILED(hr)) -- Dmitry.

1 0

User-settable limit on desktop window size?
by Joerg-Cyril.Hoehle＠t-systems.com 16 Sep '10

16 Sep '10

Hi, Alexandre Julliard wrote in another thread: >The destop window is supposed to be the size of the whole screen. Is there something to have Wine consistently lie about the real size, i.e. report no resolution above 1024x768? I'm asking because I can remember some apps whose "centered" logos or requesters appear almost outside the virtual desktop window, towards the lower right, as if their coordinates were based on the physical dimension of the display. This is more and more problematic for old apps that may not work well on today's huge monitors (e.g. 1920x...) and need a virtual desktop to work (full screen mode may not be adequate or supported). OTOH I find it good when (other) apps can resize an initially small virtual desktop window (Motocross Madness 2 comes to mind, whose menu uses 640x480 only and resizes to much larger resolutions during race). Thank you for your help, Jörg Höhle

2 1

Re: d3dx9_36: Implement D3DXCreateMesh and initial ID3DXMesh methods. (try 3)
by Henri Verbeet 16 Sep '10

16 Sep '10

On 15 September 2010 01:55, Misha Koshelev <misha680(a)gmail.com> wrote: > + while (count < MAX_FVF_DECL_SIZE && (count == 0 || declaration[count-1].Stream != 0xFF)) > + { > + count++; > + } ...and similarly you'd want to use D3DXGetDeclLength() here, though I wonder if implementing DrawSubset() isn't going to require creating a vertex declaration anyway. > + if (!ref) > + { > + if (This->index_buffer) IDirect3DIndexBuffer9_Release(This->index_buffer); > + if (This->vertex_buffer) IDirect3DVertexBuffer9_Release(This->vertex_buffer); > + if (This->device) IDirect3DDevice9_Release(This->device); > + HeapFree(GetProcessHeap(), 0, This); > + } In which cases can these be NULL?

3 4

Re: Add Intel GM45 detection
by Henri Verbeet 16 Sep '10

16 Sep '10

You also have some trailing spaces.

1 0

Re: [PATCH 2/2] winmm: Auto-open MCI core commands only.
by testbot＠testbot.winehq.org 16 Sep '10

16 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5258 Your paranoid android. === W98SE (32 bit mci) === mci.c:903: Test failed: not enough time elapsed 58ms

1 0

Re: Add Intel GM45 detection
by Dmitry Timoshkov 16 Sep '10

16 Sep '10

Jaime Rave <jaimerave(a)ubuntu-co.com> wrote: > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1109,7 +1109,8 @@ static const struct gpu_description gpu_description_table[] = > {HW_VENDOR_INTEL, CARD_INTEL_I915G, "Intel(R) 82915G/GV/910GL Express Chipset Family", DRIVER_INTEL_GMA900, 64 }, > {HW_VENDOR_INTEL, CARD_INTEL_I915GM, "Mobile Intel(R) 915GM/GMS,910GML Express Chipset Family", DRIVER_INTEL_GMA900, 64 }, > {HW_VENDOR_INTEL, CARD_INTEL_I945GM, "Mobile Intel(R) 945GM Express Chipset Family", DRIVER_INTEL_GMA950, 64 }, > - {HW_VENDOR_INTEL, CARD_INTEL_X3100, "Mobile Intel(R) 965 Express Chipset Family", DRIVER_INTEL_GMA3000, 128} > + {HW_VENDOR_INTEL, CARD_INTEL_X3100, "Mobile Intel(R) 965 Express Chipset Family", DRIVER_INTEL_GMA3000, 128}, > + {HW_VENDOR_INTEL, CARD_INTEL_GM45, "Mobile Intel(R) GM45 Express Chipset Family", DRIVER_INTEL_GMA3000, 512} > }; Please keep the spacing consistent. -- Dmitry.

1 0

Re: msxml3/tests: Skip tests if IXMLDOMDocument2 can't be obtained
by Nikolay Sivov 16 Sep '10

16 Sep '10

On 9/16/2010 02:27, Nikolay Sivov wrote: > This is supposed to fix test bot failures. > Please ignore this one.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel