- wine-devel - winehq.org

Re: [7/7] msi/tests: Fix some more wow64 test failures.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3722 Your paranoid android. === W7PROX64 (32 bit install) === install.c:3565: Test failed: Expected imaname, got ðõ install.c:3570: Test failed: Expected ERROR_FILE_NOT_FOUND, got 6 install.c:3575: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3576: Test failed: Expected 314, got 12 install.c:3581: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3582: Test failed: Expected OrderTestValue, got ðõ install.c:3606: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3629: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3652: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3675: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4829: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5316: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5319: Test failed: Key doesn't exist or wrong type install.c:5354: Test failed: Key doesn't exist or wrong type install.c:5754: Test failed: Key doesn't exist or wrong type install.c:5755: Test failed: Key doesn't exist or wrong type install.c:5756: Test failed: Key doesn't exist or wrong type install.c:5757: Test failed: Key doesn't exist or wrong type install.c:5758: Test failed: Key doesn't exist or wrong type install.c:5759: Test failed: Key doesn't exist or wrong type install.c:5760: Test failed: Key doesn't exist or wrong type install.c:5761: Test failed: Key doesn't exist or wrong type install.c:5762: Test failed: Key doesn't exist or wrong type install.c:5763: Test failed: Key doesn't exist or wrong type install.c:5764: Test failed: Key doesn't exist or wrong type install.c:5765: Test failed: Key doesn't exist or wrong type install.c:5766: Test failed: Key doesn't exist or wrong type install.c:5767: Test failed: Key doesn't exist or wrong type install.c:5768: Test failed: Key doesn't exist or wrong type install.c:5769: Test failed: Key doesn't exist or wrong type install.c:5770: Test failed: Key doesn't exist or wrong type install.c:5771: Test failed: Key doesn't exist or wrong type install.c:5772: Test failed: Key doesn't exist or wrong type install.c:5773: Test failed: Key doesn't exist or wrong type install.c:5776: Test failed: Key doesn't exist or wrong type install.c:5828: Test failed: Key doesn't exist or wrong type install.c:5829: Test failed: Key doesn't exist or wrong type install.c:5830: Test failed: Key doesn't exist or wrong type install.c:5831: Test failed: Key doesn't exist or wrong type install.c:5832: Test failed: Key doesn't exist or wrong type install.c:5833: Test failed: Key doesn't exist or wrong type install.c:5834: Test failed: Key doesn't exist or wrong type install.c:5835: Test failed: Key doesn't exist or wrong type install.c:5836: Test failed: Key doesn't exist or wrong type install.c:5837: Test failed: Key doesn't exist or wrong type install.c:5838: Test failed: Key doesn't exist or wrong type install.c:5839: Test failed: Key doesn't exist or wrong type install.c:5840: Test failed: Key doesn't exist or wrong type install.c:5841: Test failed: Key doesn't exist or wrong type install.c:5842: Test failed: Key doesn't exist or wrong type install.c:5843: Test failed: Key doesn't exist or wrong type install.c:5844: Test failed: Key doesn't exist or wrong type install.c:5845: Test failed: Key doesn't exist or wrong type install.c:5846: Test failed: Key doesn't exist or wrong type install.c:5847: Test failed: Key doesn't exist or wrong type install.c:5850: Test failed: Key doesn't exist or wrong type install.c:5904: Test failed: Key doesn't exist or wrong type install.c:5905: Test failed: Key doesn't exist or wrong type install.c:5906: Test failed: Key doesn't exist or wrong type install.c:5907: Test failed: Key doesn't exist or wrong type install.c:5908: Test failed: Key doesn't exist or wrong type install.c:5909: Test failed: Key doesn't exist or wrong type install.c:5910: Test failed: Key doesn't exist or wrong type install.c:5911: Test failed: Key doesn't exist or wrong type install.c:5912: Test failed: Key doesn't exist or wrong type install.c:5913: Test failed: Key doesn't exist or wrong type install.c:5914: Test failed: Key doesn't exist or wrong type install.c:5915: Test failed: Key doesn't exist or wrong type install.c:5916: Test failed: Key doesn't exist or wrong type install.c:5917: Test failed: Key doesn't exist or wrong type install.c:5918: Test failed: Key doesn't exist or wrong type install.c:5919: Test failed: Key doesn't exist or wrong type install.c:5920: Test failed: Key doesn't exist or wrong type install.c:5921: Test failed: Key doesn't exist or wrong type install.c:5922: Test failed: Key doesn't exist or wrong type install.c:5925: Test failed: Key doesn't exist or wrong type install.c:5956: Test failed: Key doesn't exist or wrong type install.c:5957: Test failed: Key doesn't exist or wrong type install.c:5958: Test failed: Key doesn't exist or wrong type install.c:5959: Test failed: Key doesn't exist or wrong type install.c:5960: Test failed: Key doesn't exist or wrong type install.c:5961: Test failed: Key doesn't exist or wrong type install.c:5962: Test failed: Key doesn't exist or wrong type install.c:5963: Test failed: Key doesn't exist or wrong type install.c:5964: Test failed: Key doesn't exist or wrong type install.c:5965: Test failed: Key doesn't exist or wrong type install.c:5966: Test failed: Key doesn't exist or wrong type install.c:5967: Test failed: Key doesn't exist or wrong type install.c:5968: Test failed: Key doesn't exist or wrong type install.c:5969: Test failed: Key doesn't exist or wrong type install.c:5970: Test failed: Key doesn't exist or wrong type install.c:5971: Test failed: Key doesn't exist or wrong type install.c:5972: Test failed: Key doesn't exist or wrong type install.c:5973: Test failed: Key doesn't exist or wrong type install.c:5974: Test failed: Key doesn't exist or wrong type install.c:5977: Test failed: Key doesn't exist or wrong type install.c:6005: Test failed: Key doesn't exist or wrong type install.c:6006: Test failed: Key doesn't exist or wrong type install.c:6007: Test failed: Key doesn't exist or wrong type install.c:6008: Test failed: Key doesn't exist or wrong type install.c:6009: Test failed: Key doesn't exist or wrong type install.c:6010: Test failed: Key doesn't exist or wrong type install.c:6011: Test failed: Key doesn't exist or wrong type install.c:6012: Test failed: Key doesn't exist or wrong type install.c:6013: Test failed: Key doesn't exist or wrong type install.c:6014: Test failed: Key doesn't exist or wrong type install.c:6015: Test failed: Key doesn't exist or wrong type install.c:6016: Test failed: Key doesn't exist or wrong type install.c:6017: Test failed: Key doesn't exist or wrong type install.c:6018: Test failed: Key doesn't exist or wrong type install.c:6019: Test failed: Key doesn't exist or wrong type install.c:6020: Test failed: Key doesn't exist or wrong type install.c:6021: Test failed: Key doesn't exist or wrong type install.c:6022: Test failed: Key doesn't exist or wrong type install.c:6023: Test failed: Key doesn't exist or wrong type install.c:6024: Test failed: Key doesn't exist or wrong type install.c:6025: Test failed: Key doesn't exist or wrong type install.c:6026: Test failed: Key doesn't exist or wrong type install.c:6029: Test failed: Key doesn't exist or wrong type install.c:6080: Test failed: Key doesn't exist or wrong type install.c:6081: Test failed: Key doesn't exist or wrong type install.c:6082: Test failed: Key doesn't exist or wrong type install.c:6083: Test failed: Key doesn't exist or wrong type install.c:6084: Test failed: Key doesn't exist or wrong type install.c:6085: Test failed: Key doesn't exist or wrong type install.c:6086: Test failed: Key doesn't exist or wrong type install.c:6087: Test failed: Key doesn't exist or wrong type install.c:6088: Test failed: Key doesn't exist or wrong type install.c:6089: Test failed: Key doesn't exist or wrong type install.c:6090: Test failed: Key doesn't exist or wrong type install.c:6091: Test failed: Key doesn't exist or wrong type install.c:6092: Test failed: Key doesn't exist or wrong type install.c:6093: Test failed: Key doesn't exist or wrong type install.c:6094: Test failed: Key doesn't exist or wrong type install.c:6095: Test failed: Key doesn't exist or wrong type install.c:6096: Test failed: Key doesn't exist or wrong type install.c:6097: Test failed: Key doesn't exist or wrong type install.c:6098: Test failed: Key doesn't exist or wrong type install.c:6099: Test failed: Key doesn't exist or wrong type install.c:6100: Test failed: Key doesn't exist or wrong type install.c:6101: Test failed: Key doesn't exist or wrong type install.c:6104: Test failed: Key doesn't exist or wrong type install.c:7146: Test failed: Wrong multi-sz data install.c:7147: Test failed: Expected 15, got 260 install.c:9582: Test failed: key not removed install.c:9592: Test failed: key not removed install.c:9603: Test failed: key not removed === W7PROX64 (64 bit install) === install.c:7139: Test failed: Expected ERROR_SUCCESS, got 2 install.c:7145: Test failed: Expected ERROR_SUCCESS, got 6 install.c:7146: Test failed: Wrong multi-sz data install.c:7147: Test failed: Expected 15, got 260 install.c:9582: Test failed: key not removed install.c:9592: Test failed: key not removed install.c:9603: Test failed: key not removed install.c:9871: Test failed: key not created === W7PROX64 (32 bit automation) === automation.c:2523: Test failed: Expected ERROR_SUCCESS, got 6 automation.c:2524: Test failed: Expected imaname, got automation.c:2529: Test failed: Expected ERROR_FILE_NOT_FOUND, got 6 automation.c:2534: Test failed: Expected ERROR_SUCCESS, got 6 automation.c:2535: Test failed: Expected 314, got 1997498257 automation.c:2540: Test failed: Expected ERROR_SUCCESS, got 6 automation.c:2541: Test failed: Expected imaname, got automation.c:2546: Test failed: Expected ERROR_SUCCESS, got 2 automation.c:2551: Test failed: Expected ERROR_SUCCESS, got 2 === W7PROX64 (64 bit automation) === automation.c:2524: Test failed: Expected imaname, got ï" automation.c:2541: Test failed: Expected imaname, got ï" === W7PROX64 (32 bit package) === package.c:8269: Test failed: Expected "regszdata", got "" package.c:8275: Test failed: Expected "#42", got "" package.c:8280: Test failed: Expected "#-42", got "" package.c:8299: Test failed: Expected "C:\Program Files\VMware\VMware Tools\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\", got "" package.c:8308: Test failed: Expected "my%NOVAR%", got "" package.c:8316: Test failed: Expected "\0one\0two\0\0" package.c:8324: Test failed: Expected "#xCDAB3412EF907856", got "" package.c:8329: Test failed: Expected "##regszdata", got "" package.c:8336: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8347: Test failed: Expected "C:\winetest\", got "" package.c:8358: Test failed: Expected "C:\winetest\", got "" package.c:8389: Test failed: Expected "defvalue", got "" package.c:8408: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8419: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8428: Test failed: Expected "C:\", got "" package.c:8434: Test failed: Expected "C:\winetest\", got "" package.c:8455: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8464: Test failed: Expected "C:\winetest\FileName1", got "" === W7PROX64 (64 bit package) === package.c:8336: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8347: Test failed: Expected "C:\winetest\", got "" package.c:8358: Test failed: Expected "C:\winetest\", got "" package.c:8408: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8419: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8428: Test failed: Expected "C:\", got "" package.c:8434: Test failed: Expected "C:\winetest\", got "" package.c:8455: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8464: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: [1/5] kernel32: only strip the wine_get_dos_file_name NTDLL path prefix if is present
by Alexandre Julliard 22 Jul '10

22 Jul '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * kernel32: only strip the wine_get_dos_file_name NTDLL path prefix if > is present It will always be present. \\?\ is used by kernel, not ntdll. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 3/3] msvcp90: Add exception throwing function
by Alexandre Julliard 22 Jul '10

22 Jul '10

Piotr Caban <piotr(a)codeweavers.com> writes: > Some of the exception data is filled in fill_exception_data > function. Is it acceptable? It would be nicer to avoid calling thiscall functions across dlls. The exception vtable is exported so you can access it directly, and replicate the constructor code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [6/7] msi/tests: Avoid a long timeout in the test for DeleteServices.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3721 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5531: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5550: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5575: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5594: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:7092: Test failed: Expected ERROR_SUCCESS, got 2 install.c:7098: Test failed: Expected ERROR_SUCCESS, got 6 install.c:7099: Test failed: Wrong multi-sz data install.c:7100: Test failed: Expected 15, got 260 install.c:9516: Test failed: key not removed install.c:9526: Test failed: key not removed install.c:9537: Test failed: key not removed install.c:9805: Test failed: key not created

1 0

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)
by Alexandre Julliard 22 Jul '10

22 Jul '10

David Hedberg <david.hedberg(a)gmail.com> writes: > + > + /* Check that all the messages received can be found in vista_plus_msgs. */ > +#define verify_vista_plus_msgs() \ > + do { \ > + UINT i,j, failcount = 0; \ > + for(i = 0; i < sequences[LISTVIEW_SEQ_INDEX]->count; i++) { \ > + BOOL found = FALSE; \ > + UINT msg = sequences[LISTVIEW_SEQ_INDEX]->sequence[i].message; \ > + for(j = 0; vista_plus_msgs[j] != 0; j++) \ > + if(vista_plus_msgs[j] == msg) found = TRUE; \ > + if(!found) { \ > + failcount++; \ > + trace("Unexpected messaged %d\n", msg); \ > + } \ > + } \ > + ok(!failcount,"Failed (%d).\n", failcount); \ > + flush_sequences(sequences, NUM_MSG_SEQUENCES); \ > + } while(0) > + Please avoid that sort of thing, make it a separate function instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/7] msi/tests: Skip tests when the current user has insufficient rights.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3720 Your paranoid android. === W7PROX64 (32 bit package) === package.c:7703: Test failed: Expected "C:\winetest\FileName1", got "" package.c:7709: Test failed: Expected "C:\winetest\FileName2", got "" package.c:7715: Test failed: Expected "C:\winetest\FileName3", got "" package.c:7727: Test failed: Expected "C:\winetest\FileName5", got "" package.c:7733: Test failed: Expected "C:\winetest\", got "" package.c:7739: Test failed: Expected "C:\winetest\", got "" package.c:7755: Test failed: Expected "C:\winetest\FileName8.dll", got "" package.c:7766: Test failed: Expected "C:\winetest\FileName10.dll", got "" === W7PROX64 (64 bit package) === package.c:8319: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8330: Test failed: Expected "C:\winetest\", got "" package.c:8341: Test failed: Expected "C:\winetest\", got "" package.c:8391: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8402: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8411: Test failed: Expected "C:\", got "" package.c:8417: Test failed: Expected "C:\winetest\", got "" package.c:8438: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8447: Test failed: Expected "C:\winetest\FileName1", got "" === W98SE (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === WNT4WSSP6 (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === W2KPROSP4 (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === WXPPROSP3 (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === W2K3R2SESP2 (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === WVISTAADM (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === W2K8SE (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === W7PRO (32 bit install) === install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === W7PROX64 (32 bit install) === install.c:5512: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5531: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5556: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5575: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 === W7PROX64 (64 bit install) === install.c:7073: Test failed: Expected ERROR_SUCCESS, got 2 install.c:7079: Test failed: Expected ERROR_SUCCESS, got 6 install.c:7080: Test failed: Wrong multi-sz data install.c:7081: Test failed: Expected 15, got 260 install.c:9098: Test failed: Expected ERROR_SUCCESS, got 1605 install.c:9491: Test failed: key not removed install.c:9501: Test failed: key not removed install.c:9512: Test failed: key not removed install.c:9780: Test failed: key not created

1 0

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.
by Paul Vriens 22 Jul '10

22 Jul '10

On 07/20/2010 06:14 AM, Andrew Nguyen wrote: > --- > dlls/shlwapi/tests/string.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) This patchset introduces crashes in these tests on W2K, XP and W2K3: http://test.winehq.org/data/tests/shlwapi:string.html Further than that it seems that none of the test are run on several platforms now. If I look at my Win98 box I get "The xx.exe file is linked to missing export SHELL32.DLL:StrChrA" and on some Vista+ boxes (not on my Vista for example): http://testbot.winehq.org/JobDetails.pl?Key=3663&scrshot_106=1#k106 Could you have a look? Notice the mentioning of SHELL32 in those errors. -- Cheers, Paul.

3 9

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.
by Louis Lenders 22 Jul '10

22 Jul '10

Hi Henri >I mean that I don't think the "rotation" argument to > GetAdapterDisplayMode() should be allowed to be NULL. I tested IDirect3D9Ex::GetAdapterDisplayModeEx and that allows pRotation to be NULL, and still happily retrieves all other (D3DDISPLAYMODEEX) info. So it's seems logical IWineD3DGetAdapterDisplayMode is allowed to have it's rotation parameter NULL as well. I attached a new series of patches to the bug http://bugs.winehq.org/show_bug.cgi?id=18640 >It probably also makes sense to properly start adding the required > support from the bottom. XRandR should be able to retrieve the display > rotation, but if that's not available you can just let winex11.drv > return an identity rotation. I fear i'm completely unfamiliar with XRandr; i think right now it's beyond the scope of this patch series, the patch series is really meant to (partly) tackle bug 18640

2 1

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.
by Greg Geldorp 22 Jul '10

22 Jul '10

> From: Paul Vriens <paul.vriens.wine(a)gmail.com> > > The first thing winetest does is run a "<dll>_test.exe --list" for each > dll. If there is a missing export (or import library) it will not > include this dll in the tests (so none of the subtests will run). Just ran shlwapi_test.exe --list manually on WVISTAADM, "The procedure entry point StrCpyNW could not be located in the dynamic link library shell32.dll." Ge.

1 0

Re: [PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere.
by Henri Verbeet 22 Jul '10

22 Jul '10

On 21 July 2010 21:56, Misha Koshelev <misha680(a)gmail.com> wrote: > + /* first vertex and normal */ > + vertex = 0; > + test_vertex_data[vertex].position.x = 0.0f; > + test_vertex_data[vertex].position.y = 0.0f; > + test_vertex_data[vertex].position.z = radius; > + test_vertex_data[vertex].normal.x = 0.0f; > + test_vertex_data[vertex].normal.y = 0.0f; > + test_vertex_data[vertex].normal.z = 1.0f; > + vertex++; > + assert(vertex < MAX_VERTICES); An assert probably isn't very useful after the fact, but it seems to me that dynamically allocating an array of the appropriate size is nicer anyway. > +static DWORD compute_sphere_test_index_data(FLOAT radius, UINT slices, UINT stacks) I haven't really thought this through yet, but would it perhaps be simpler to calculate the faces a vertex is part of, instead of the other way around?

1 0

Re: [4/5] d3dx9: Implement D3DXCreateTexture plus tests
by Henri Verbeet 22 Jul '10

22 Jul '10

On 21 July 2010 16:06, Owen Rudge <owen(a)owenrudge.net> wrote: > + hr = D3DXCreateTexture(device, D3DX_DEFAULT, 63, 0, 0, 0, D3DPOOL_DEFAULT, &texture); > + ok(hr == D3D_OK, "D3DXCreateTexture returned %#x, expected %#x\n", hr, D3D_OK); > + > + if (texture) > + { > + hr = IDirect3DTexture9_GetLevelDesc(texture, 0, &desc); > + > + ok(desc.Width == 63, "Returned width %d, expected %d\n", desc.Width, 63); > + ok(desc.Height == 63, "Returned height %d, expected %d\n", desc.Height, 63); > + > + IDirect3DTexture9_Release(texture); > + } I (still) think that depends on NPOT texture support in the device. I.e., if the device doesn't support NPOT textures, I suppose the call can either fail, or create a texture with different dimension like 64x64, but it can't create 63x63 textures. Note that D3DPTEXTURECAPS_NONPOW2CONDITIONAL also affects NPOT capabilities.

1 0

Re: [2/5] d3dx9: Implement D3DXCheckTextureRequirements
by Henri Verbeet 22 Jul '10

22 Jul '10

On 21 July 2010 16:06, Owen Rudge <owen(a)owenrudge.net> wrote: > +/* Returns TRUE if num is a power of 2, FALSE otherwise */ > +BOOL is_pow2(UINT num) > +{ > + return !(num & (num - 1)); > +} Minor, but this returns TRUE if num is power of two, *or zero*. That's fine for how it's used, but please mention it. > +/* Returns the smallest power of 2 which is greater than or equal to num */ > +UINT make_pow2(UINT num) > +{ > + UINT result = 1; > + > + while (result < num) > + result <<= 1; > + > + return result; > +} There's a danger of this looping forever if you pass it something > 0x80000000. I'm not sure if we care though, maybe that simply falls under the heading of "so don't do that". > + if (!width && !height) > + max_mipmaps = 9; This looks like the number of mipmaps in a 256x256 texture, i.e. log2i(256) + 1. That doesn't match the values of w and h in that case though, so I think a comment for clarification wouldn't hurt there. > + while (mip_width > 1 || mip_height > 1) > + { > + mip_width >>= 1; > + mip_height >>= 1; > + max_mipmaps++; > + } This one is also minor, but if you don't need mip_width / mip_height for anything else, you can just take max(w, h) before the loop. It's probably not worth the trouble for a single instance of this calculation, but note that wined3d has a wined3d_log2i() function in dlls/wined3d/utils.c.

1 0

Re: [4/7] msi/tests: Return an error code from helper_createpackage and package_from_db.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3719 Your paranoid android. === W7PROX64 (32 bit package) === package.c:7618: Test failed: Expected "C:\winetest\FileName1", got "" package.c:7624: Test failed: Expected "C:\winetest\FileName2", got "" package.c:7630: Test failed: Expected "C:\winetest\FileName3", got "" package.c:7642: Test failed: Expected "C:\winetest\FileName5", got "" package.c:7648: Test failed: Expected "C:\winetest\", got "" package.c:7654: Test failed: Expected "C:\winetest\", got "" package.c:7670: Test failed: Expected "C:\winetest\FileName8.dll", got "" package.c:7681: Test failed: Expected "C:\winetest\FileName10.dll", got "" === W7PROX64 (64 bit package) === package.c:8227: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8238: Test failed: Expected "C:\winetest\", got "" package.c:8249: Test failed: Expected "C:\winetest\", got "" package.c:8299: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8310: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8319: Test failed: Expected "C:\", got "" package.c:8325: Test failed: Expected "C:\winetest\", got "" package.c:8346: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8355: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: [3/7] msi/tests: Fix test failures on wow64.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3718 Your paranoid android. === W7PROX64 (32 bit package) === package.c:7614: Test failed: Expected "C:\winetest\FileName1", got "" package.c:7620: Test failed: Expected "C:\winetest\FileName2", got "" package.c:7626: Test failed: Expected "C:\winetest\FileName3", got "" package.c:7638: Test failed: Expected "C:\winetest\FileName5", got "" package.c:7644: Test failed: Expected "C:\winetest\", got "" package.c:7650: Test failed: Expected "C:\winetest\", got "" package.c:7666: Test failed: Expected "C:\winetest\FileName8.dll", got "" package.c:7677: Test failed: Expected "C:\winetest\FileName10.dll", got "" === W7PROX64 (64 bit package) === package.c:8223: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8234: Test failed: Expected "C:\winetest\", got "" package.c:8245: Test failed: Expected "C:\winetest\", got "" package.c:8295: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8306: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8315: Test failed: Expected "C:\", got "" package.c:8321: Test failed: Expected "C:\winetest\", got "" package.c:8342: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8351: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: winex11.drv: Remember last window that had the XIC focus and use it in ToUnicode() to make dead keys work more reliably.
by Alexandre Julliard 22 Jul '10

22 Jul '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -2541,9 +2541,13 @@ INT CDECL X11DRV_ToUnicodeEx(UINT virtKey, UINT scanCode, const BYTE *lpKeyState > e.state = 0; > e.type = KeyPress; > > - focus = GetFocus(); > - if (focus) focus = GetAncestor( focus, GA_ROOT ); > - if (!focus) focus = GetActiveWindow(); > + focus = x11drv_thread_data()->last_xic_hwnd; > + if (!focus) > + { > + HWND focus = GetFocus(); > + if (focus) focus = GetAncestor( focus, GA_ROOT ); > + if (!focus) focus = GetActiveWindow(); > + } Have you tested that code path? This can't possibly work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wordpad: Allow objects & images to be added with native riched20. (resend)
by Alexandre Julliard 22 Jul '10

22 Jul '10

Dylan Smith <dylan.ah.smith(a)gmail.com> writes: > @@ -264,3 +267,6 @@ void registry_read_maximized(DWORD*); > void registry_set_filelist(LPCWSTR, HWND); > void registry_set_formatopts_all(DWORD[], DWORD[]); > void registry_set_options(HWND); > + > +/* olecallback.c */ > +HRESULT SetupRichEditOleCallback(HWND hEditorWnd); Please follow the naming convention of the other internal functions; in particular, don't name an internal function in a way that looks like a Windows API. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include/wine/debug.h: ... and uses of '_ONCE' variants.
by Max TenEyck Woodbury 22 Jul '10

22 Jul '10

Please discard this series of patches. They will not work with compilers that do not support macros with variable numbers of arguments. While most modern compilers do provide variadic macros, some older compilers do not. To do this right a non-intuitive syntax would be required. (i.e. 'FIXME_ONCE((...));'.) Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on the use of any particular compiler. -Max

2 3

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.
by Louis Lenders 22 Jul '10

22 Jul '10

ok, now i really need a break, the test i wrote 10 minutes ago had a mistake, IDirect3D9Ex::GetAdapterDisplayModeEx _does_ allow D3DDISPLAYROTATION pointer to be NULL. I'll just send the test to wine-patches. Again sorry for the noise

1 0

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.
by Louis Lenders 22 Jul '10

22 Jul '10

Hi Henri >>I mean that I don't think the "rotation" argument to >> GetAdapterDisplayMode() should be allowed to be NULL. >I tested IDirect3D9Ex::GetAdapterDisplayModeEx and that allows pRotation to >be NULL, hmm, I remembered to have tested this, but to be sure I tested again a few minutes ago, and looks you were right in the end. I guess i'll have to rework the patch series again. sorry for the noise

1 0

Re: [PATCH 2/3] msvcp90/tests: Added allocator<char> tests
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3704 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shlwapi: Improved UrlCanonicalizeW implementation
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3702 Your paranoid android. === W98SE (32 bit url) === Failure running script in VM: Exceeded timeout limit of 315 sec === WVISTAADM (32 bit url) === Timeout === W2K8SE (32 bit url) === Timeout === W7PRO (32 bit url) === Timeout === W7PROX64 (32 bit url) === Timeout === W7PROX64 (64 bit url) === Timeout

1 0

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces. (try 2)
by Oldřich Jedlička 22 Jul '10

22 Jul '10

Hi all, I've made one discovery - the explicit BACKBUFFER creation (as shown in logs) works only for IID_IDirectDraw interface, not for any newer (on my Windows XP). I will do some more testing, add tests into a separate patch and send it afterwards. Regards, Oldrich. On Wednesday 21 July 2010 20:51:49 Oldřich Jedlička wrote: > Old DirectX interfaces allowed creation of explicit back buffers, so move > the restrictive check to DirectX 7 implementation. > > This fixes bug #9008. > --- > dlls/ddraw/ddraw.c | 35 ++++++++++++++++++++++++++++------- > 1 files changed, 28 insertions(+), 7 deletions(-) > > diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c > index e55ac5b..9f13c8b 100644 > --- a/dlls/ddraw/ddraw.c > +++ b/dlls/ddraw/ddraw.c > @@ -2967,7 +2967,7 @@ static HRESULT > ddraw_create_gdi_swapchain(IDirectDrawImpl *ddraw, IDirectDrawSur * > DDERR_* if an error occurs > * > > ************************************************************************** > ***/ -static HRESULT WINAPI ddraw7_CreateSurface(IDirectDraw7 *iface, > +static HRESULT WINAPI CreateSurface(IDirectDraw7 *iface, > DDSURFACEDESC2 *DDSD, IDirectDrawSurface7 **Surf, IUnknown > *UnkOuter) { > IDirectDrawImpl *This = (IDirectDrawImpl *)iface; > @@ -3030,8 +3030,8 @@ static HRESULT WINAPI > ddraw7_CreateSurface(IDirectDraw7 *iface, return DDERR_NOEXCLUSIVEMODE; > } > > - if(DDSD->ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_BACKBUFFER)) > { - WARN("Application tried to create an explicit front or back > buffer\n"); + if(DDSD->ddsCaps.dwCaps & DDSCAPS_FRONTBUFFER) { > + WARN("Application tried to create an explicit front buffer\n"); > LeaveCriticalSection(&ddraw_cs); > return DDERR_INVALIDCAPS; > } > @@ -3391,6 +3391,27 @@ static HRESULT WINAPI > ddraw7_CreateSurface(IDirectDraw7 *iface, return hr; > } > > +static HRESULT WINAPI ddraw7_CreateSurface(IDirectDraw7 *iface, > + DDSURFACEDESC2 *surface_desc, IDirectDrawSurface7 **surface, > IUnknown *outer_unknown) +{ > + TRACE("iface %p, surface_desc %p, surface %p, outer_unknown %p.\n", > + iface, surface_desc, surface, outer_unknown); > + > + if(surface_desc->ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | > DDSCAPS_BACKBUFFER)) + { > + if (TRACE_ON(ddraw)) > + { > + TRACE(" (%p) Requesting surface desc :\n", iface); > + DDRAW_dump_surface_desc(surface_desc); > + } > + > + WARN("Application tried to create an explicit front or back > buffer\n"); + return DDERR_INVALIDCAPS; > + } > + > + return CreateSurface(iface, surface_desc, surface, outer_unknown); > +} > + > static HRESULT WINAPI ddraw4_CreateSurface(IDirectDraw4 *iface, > DDSURFACEDESC2 *surface_desc, IDirectDrawSurface4 **surface, > IUnknown *outer_unknown) { > @@ -3401,7 +3422,7 @@ static HRESULT WINAPI > ddraw4_CreateSurface(IDirectDraw4 *iface, TRACE("iface %p, surface_desc > %p, surface %p, outer_unknown %p.\n", iface, surface_desc, surface, > outer_unknown); > > - hr = ddraw7_CreateSurface((IDirectDraw7 *)ddraw, surface_desc, > (IDirectDrawSurface7 **)surface, outer_unknown); + hr = > CreateSurface((IDirectDraw7 *)ddraw, surface_desc, (IDirectDrawSurface7 > **)surface, outer_unknown); impl = (IDirectDrawSurfaceImpl *)*surface; > if (SUCCEEDED(hr) && impl) > { > @@ -3425,7 +3446,7 @@ static HRESULT WINAPI > ddraw3_CreateSurface(IDirectDraw3 *iface, TRACE("iface %p, surface_desc > %p, surface %p, outer_unknown %p.\n", iface, surface_desc, surface, > outer_unknown); > > - hr = ddraw7_CreateSurface((IDirectDraw7 *)ddraw, (DDSURFACEDESC2 > *)surface_desc, &surface7, outer_unknown); + hr = > CreateSurface((IDirectDraw7 *)ddraw, (DDSURFACEDESC2 *)surface_desc, > &surface7, outer_unknown); if (FAILED(hr)) > { > *surface = NULL; > @@ -3453,7 +3474,7 @@ static HRESULT WINAPI > ddraw2_CreateSurface(IDirectDraw2 *iface, TRACE("iface %p, surface_desc > %p, surface %p, outer_unknown %p.\n", iface, surface_desc, surface, > outer_unknown); > > - hr = ddraw7_CreateSurface((IDirectDraw7 *)ddraw, (DDSURFACEDESC2 > *)surface_desc, &surface7, outer_unknown); + hr = > CreateSurface((IDirectDraw7 *)ddraw, (DDSURFACEDESC2 *)surface_desc, > &surface7, outer_unknown); if (FAILED(hr)) > { > *surface = NULL; > @@ -3483,7 +3504,7 @@ static HRESULT WINAPI > ddraw1_CreateSurface(IDirectDraw *iface, /* Remove front buffer flag, this > causes failure in v7, and its added to normal * primaries anyway. */ > surface_desc->ddsCaps.dwCaps &= ~DDSCAPS_FRONTBUFFER; > - hr = ddraw7_CreateSurface((IDirectDraw7 *)ddraw, (DDSURFACEDESC2 > *)surface_desc, &surface7, outer_unknown); + hr = > CreateSurface((IDirectDraw7 *)ddraw, (DDSURFACEDESC2 *)surface_desc, > &surface7, outer_unknown); if (FAILED(hr)) > { > *surface = NULL;

2 2

Re: oleaut32: Remove the ignored common resource attributes.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3687 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: user32: Remove the ignored common resource attributes.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3686 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: comdlg32: Remove the ignored common resource attributes.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3685 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: comctl32: Remove the ignored common resource attributes.
by testbot＠testbot.winehq.org 22 Jul '10

22 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3684 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/2] shlwapi: Implement SHSetIniStringW
by testbot＠testbot.winehq.org 21 Jul '10

21 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3668 Your paranoid android. === W98SE (32 bit ordinal) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit ordinal) === ordinal.c:604: Test failed: GetShellSecurityDescriptor should fail ordinal.c:627: Test failed: returned value is not valid SD No test summary line found === WVISTAADM (32 bit ordinal) === Timeout === W2K8SE (32 bit ordinal) === Timeout === W7PRO (32 bit ordinal) === Timeout === W7PROX64 (32 bit ordinal) === Timeout === W7PROX64 (64 bit ordinal) === Timeout

1 0

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW
by testbot＠testbot.winehq.org 21 Jul '10

21 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3667 Your paranoid android. === W98SE (32 bit ordinal) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit ordinal) === ordinal.c:603: Test failed: GetShellSecurityDescriptor should fail ordinal.c:626: Test failed: returned value is not valid SD No test summary line found === WVISTAADM (32 bit ordinal) === Timeout === W2K8SE (32 bit ordinal) === Timeout === W7PRO (32 bit ordinal) === Timeout === W7PROX64 (32 bit ordinal) === Timeout === W7PROX64 (64 bit ordinal) === Timeout

1 0

Re: winhlp32 italian translation update
by Paul Vriens 21 Jul '10

21 Jul '10

Hi Davide, On 07/21/2010 11:31 PM, Davide Pizzetti wrote: > @@ -53,9 +53,9 @@ MAIN_MENU MENU LANGUAGE LANG_ITALIAN, SUBLANG_NEUTRAL Your tree is not up-to-date. The above per-resource LANGUAGE settings have been removed by 6e8c900d1960e804227e83826a529f075e09443e. -- Cheers, Paul.

1 0

Re: [PATCH 4/4] wined3d: Use a more consistent name for the normalized texrect "extension".
by Stefan Dösinger 21 Jul '10

21 Jul '10

Am 20.07.2010 um 18:51 schrieb Henri Verbeet: > - || gl_info->supported[WINE_NORMALIZED_TEXRECT]) > + || gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT]) I understand the WINE->WINED3D part - it's a wined3d specific thing, nothing wine global. But why did you add GL to the name?

2 5

[1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info. Henri Verbeet hverbeet at gmail.com
by Louis Lenders 21 Jul '10

21 Jul '10

Hi, @Chris: thanks for the remarks, i'll adjust patch [3\4] accordingly @Henry also thanks, i made a new patch here: http://pastebin.com/y5Kv52h0 would that be ok? >I also think the wined3d call should simply >retrieve all info, d3d9ex can discard it again if it feels like it. I don't exactly get what you mean here. Currently we can't retrieve display orientation as wine's EnumDisplaySettingsExW doesn't work as expected. Once EnumDisplaySettingsExW is implemented enough (for rotated stuff), IWineD3DImpl_GetAdapterDisplayMode will pass back the correct display orientation. Is that what you meant by remark above? Regards

2 1

Re: wined3d: Add Nvidia 8800GTX detection
by Luke Bratch 21 Jul '10

21 Jul '10

--- On Tue, 20/7/10, Henri Verbeet <hverbeet(a)gmail.com> wrote: > Negative on using experimental extensions I'm afraid. > Writing a proof > of concept patch is ok, of course, and I'd be willing to > review that, > but it can't go in until the extension is finalized. Note > that this > wouldn't allow you to get rid of the current code though, > you still > need a fallback. It would just allow for more accurate > reporting on > cards that do support that extension. The attached uses that experimental extension [1] to report the correct total memory for cards that support it, while sticking with the existing hard coded values and code layout for those that don't. I would appreciate any comments. Thanks Luke Bratch [1] http://developer.download.nvidia.com/opengl/specs/GL_NVX_gpu_memory_info.txt

5 8

Re: [2/6] shdocvw: Implement InterneExplorer::ExecWB
by Jacek Caban 21 Jul '10

21 Jul '10

On 7/21/10 2:08 PM, Alexander Nicolaysen Sørnes wrote: > Implement InterneExplorer::ExecWB > > + if(IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, (LPVOID*)&Target) != S_OK) + { + return E_NOTIMPL; It doesn't seem like a right error code. + } else + { You don't really need else block if you return in if anyway. + HRESULT ret = IOleCommandTarget_Exec(Target,&CGID_MSHTML, cmdID, cmdexecopt, pvaIn, pvaOut); Did you test that it should use CGID_MSHTML? I'm not saying that it's wrong and writing a test for winetest would be tricky, but I'd like to know that it's somehow confirmed, esp. because you depend on it in next patches. Jacek

2 2

D3DXCreateTeapot
by Ian Macfarlane 21 Jul '10

21 Jul '10

Following the question as to how to implement D3DXCreateTeapot, might I suggest making it in the form of a wine glass? Given that is unlikely to negatively affect anything (indeed the entire method does border on the ridiculous) I think it would make a nice hidden touch. Regards Ian

6 5

Re: kernel32: make wine_get_dos_file_name independent from drive mappings
by Alexandre Julliard 21 Jul '10

21 Jul '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * kernel32: make wine_get_dos_file_name independent from drive mappings > > ... by returning \\?\unix/home/user/path/to/file.txt style paths. That should actually be done in wine_unix_to_nt_file_name, and only when there is no suitable DOS drive. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32.dll: implementation of GetVolumePathNamesForVolumeNameA/W (try 2)
by Vitaliy Margolen 21 Jul '10

21 Jul '10

Thanks for the patch. However it has number of issues: On 07/20/2010 08:33 PM, Tuomo Mattila wrote: > @ stdcall GetVolumeNameForVolumeMountPointW(wstr ptr long) > @ stdcall GetVolumePathNameA(str ptr long) > @ stdcall GetVolumePathNameW(wstr ptr long) > -# @ stub GetVolumePathNamesForVolumeNameA > +@ stdcall GetVolumePathNamesForVolumeNameA(str ptr long ptr) Broken formatting. > + /* FIXME: The winxp version of this function raises an exception (access violation) if called with a NULL volumename or volumepathname argument. Alternatively, we might want to set an error code and return a failure */ > +/* > + if (volumename == NULL || volumepathname == NULL) That indicates that you shouldn't be doing any null checks here. Commented out code is not accepted into Wine. Also please don't use such long lines, especially comments. leek > + { > + return FALSE; > + } > +*/ > + > + volumepathnameW = HeapAlloc(GetProcessHeap(), 0, buflen*sizeof(WCHAR)); > + if (volumepathnameW == NULL) return FALSE; This should probably set LastError as well. Need a test to verify. > + > + if ((volumenameW = FILE_name_AtoW(volumename, TRUE)) == 0) return FALSE; You leaking volumepathnameW here. > + WCHAR volumename2string[50]; > + LPWSTR volumename2 = volumename2string; Don't do that. Unless you need to do some extra pointer arithmetic don't create extra pointer that points to a buffer. > - FIXME("(%s, %p, %d, %p), stub!\n", debugstr_w(volumename), volumepathname, buflen, returnlen); You should replace FIXME with appropriate TRACE. > + if (strncmpW(volumename, volname_prefix, 11) != 0 || volumename[19] != '-' || volumename[24] != '-' || volumename[29] != '-' || volumename[34] != '-' || volumename[47] != '}') You are not checking the length of the volumename. If it's too short you accessing it past the end. Also comment about what exactly you are looking for and how volume string is supposed to look like will be good. > + /* FIXME: combination of the above may set other error codes */ Such as? Need a test for that. > + memset(volumename2string, 0, sizeof(volumename2string)); Don't do this sort of thing. There is never a need to clear the entire buffer, especially on each iteration. > + if (available_drives& (1<<(letter-'A'))) > + { > + pstr[0] = letter; > + if( (GetVolumeNameForVolumeMountPointW(pathstring, volumename2, 50))&& (!strncmpW(volumename, volumename2, 50))) Don't use magic numbers. Always use sizeof() when need a buffer size. And as I said before you should use volumename2string directly here. Vitaliy.

1 0

Re: [4/6] shdocvw: Add About dialog to IE
by Jacek Caban 21 Jul '10

21 Jul '10

On 7/21/10 2:09 PM, Alexander Nicolaysen Sørnes wrote: > Add About dialog to IE > +static void ie_dialog_about(HWND hwnd) +{ + HICON icon = LoadImageW(GetModuleHandleW(0), MAKEINTRESOURCEW(IDI_APPICON), IMAGE_ICON, 48, 48, LR_SHARED); + + ShellAboutW(hwnd, wszWineInternetExplorer, NULL, icon); +} You leak icon here. Jacek

1 0

Re: [1/2] shlwapi: Partially implement SHGetShellKey (try2)
by testbot＠testbot.winehq.org 21 Jul '10

21 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3649 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1768: Test failed: got 28 ordinal.c:1818: Test failed: got 28 ordinal.c:1826: Test failed: got 28 ordinal.c:1834: Test failed: got 39, length 40 ordinal.c:1845: Test failed: got 42 === W7PROX64 (32 bit ordinal) === ordinal.c:1768: Test failed: got 25 ordinal.c:1818: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1834: Test failed: got 34, length 35 ordinal.c:1845: Test failed: got 37 === W7PROX64 (64 bit ordinal) === ordinal.c:1762: Test failed: got 10 ordinal.c:1783: Test failed: got 7 ordinal.c:1796: Test failed: got 10 ordinal.c:1804: Test failed: got 10 ordinal.c:1834: Test failed: got 34, length 35 ordinal.c:1845: Test failed: got 37 ordinal.c:1856: Test failed: got 20 ordinal.c:1867: Test failed: got 23

1 0

Re: [1/6] shdocvw: Add menu bar to Internet Explorer
by Jacek Caban 21 Jul '10

21 Jul '10

Hi Alexander, On 7/21/10 2:07 PM, Alexander Nicolaysen Sørnes wrote: > This series adds a menu bar and Open URL dialog box to Wine's IE. - FIXME("(%p)->(%x)\n", This, Value); - return E_NOTIMPL; + HMENU hMenu = NULL; Please use better names (without type prefix) like 'menu'. + + TRACE("(%p)->(%x)\n", This, Value); + + if(Value == VARIANT_TRUE) You shouldn't compare Value directly to VARIANT_TRUE. + hMenu = LoadMenuW(shdocvw_hinstance, MAKEINTRESOURCEW(IDR_BROWSE_MAIN_MENU)); + + if(!SetMenu(This->frame_hwnd, hMenu)) + return HRESULT_FROM_WIN32(GetLastError()); + + + return S_OK; You leak hMenu here. Jacek

1 0

Re: dmusic: remove unused variable
by Nikolay Sivov 21 Jul '10

21 Jul '10

On 7/21/2010 08:31, Austin English wrote: > HRESULT WINAPI DMUSIC_CreateDirectMusicPortImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter, LPDMUS_PORTPARAMS pPortParams, LPDMUS_PORTCAPS pPortCaps) { > IDirectMusicPortImpl *obj; > - HRESULT hr = E_FAIL; > UINT j; > > TRACE("(%p,%p,%p)\n", lpcGUID, ppobj, pUnkOuter); > @@ -381,7 +380,6 @@ HRESULT WINAPI DMUSIC_CreateDirectMusicPortImpl (LPCGUID lpcGUID, LPVOID *ppobj, > obj->caps = *pPortCaps; > obj->pDirectSound = NULL; > obj->pLatencyClock = NULL; > - hr = DMUSIC_CreateReferenceClockImpl(&IID_IReferenceClock, (LPVOID*)&obj->pLatencyClock, NULL); > > if(0) > { I doubt you could remove a call here. And probably return value should be used to exit earlier on a failure.

3 3

Re: [PATCH 4/7] msvcp90: Added char_traits<unsigned short> implementation (try3)
by Paul Vriens 21 Jul '10

21 Jul '10

(Forgot to cc: wine-devel). On 07/21/2010 11:10 AM, Piotr Caban wrote: > +void CDECL MSVCP_char_trauts_short_assign(unsigned short *ch, ^ I guess his should have been "MSVCP_char_traits_short_assign" -- Cheers, Paul.

1 0

Re: [1\4]wined3d: Extend IWineD3D_GetAdapterDisplayMode with an extra paramater to pass back some extra adapter info.
by Henri Verbeet 21 Jul '10

21 Jul '10

On 20 July 2010 23:25, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > +struct wined3d_adapter_info_ex > +{ > + WINED3DSCANLINEORDERING ScanLineOrdering; > + WINED3DDISPLAYROTATION Rotation; > +}; You can at least add the scanline ordering to WINED3DDISPLAYMODE, it doesn't need to be compatible with D3DDISPLAYMODE. I guess the reason the rotation is separate in d3d9ex is because it doesn't make much sense for enumerations like e.g. EnumAdapterModesEx(), so keeping that one separate makes sense. I also think the wined3d call should simply retrieve all info, d3d9ex can discard it again if it feels like it.

1 0

Re: [PATCH 4/7] msvcp90: Added char_traits<unsigned short> implementation (try2)
by Alexandre Julliard 21 Jul '10

21 Jul '10

Piotr Caban <piotr(a)codeweavers.com> writes: > +/* ?not_eof@?$char_traits@G@std@@SAGABG@Z */ > +unsigned short CDECL MSVCP_char_traits_short_not_eof(const unsigned short *in) > +{ > + return (*in==0 ? !0 : *in); > +} Aren't you supposed to return 0 for eof? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [7/8] msi/tests: Double null-terminate a REG_MULTI_SZ string.
by testbot＠testbot.winehq.org 21 Jul '10

21 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3642 Your paranoid android. === W7PROX64 (32 bit msi) === msi.c:2129: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2147: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2162: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2177: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2195: Test failed: Expected {B88234A0-3235-44D6-9896-5C2F4FECBCA3}, got prod msi.c:2224: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2242: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2257: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2272: Test failed: Expected {199806F7-4914-4AD4-A534-621BD19AB132}, got prod msi.c:2290: Test failed: Expected {B88234A0-3235-44D6-9896-5C2F4FECBCA3}, got prod msi.c:2371: Test failed: Expected {B7AD5430-68AC-40AC-A2B7-AC3921BEC0BB}, got msi.c:2377: Test failed: Expected {B7AD5430-68AC-40AC-A2B7-AC3921BEC0BB}, got msi.c:2401: Test failed: Expected {B7AD5430-68AC-40AC-A2B7-AC3921BEC0BB} or {585F89C0-75DE-4B38-8A34-5B7E4D13554C}, got msi.c:2408: Test failed: Expected {B7AD5430-68AC-40AC-A2B7-AC3921BEC0BB} or {585F89C0-75DE-4B38-8A34-5B7E4D13554C}, got msi.c:2442: Test failed: Expected {B7AD5430-68AC-40AC-A2B7-AC3921BEC0BB}, got msi.c:2471: Test failed: Expected {B7AD5430-68AC-40AC-A2B7-AC3921BEC0BB} or {585F89C0-75DE-4B38-8A34-5B7E4D13554C}, got msi.c:2478: Test failed: Expected {B7AD5430-68AC-40AC-A2B7-AC3921BEC0BB} or {585F89C0-75DE-4B38-8A34-5B7E4D13554C}, got msi.c:7467: Test failed: Expected "{C3232306-263D-4B13-8407-D7D348E8AAAC}", got "C:\winetest\\winetest.msi" msi.c:7536: Test failed: Expected "{C3232306-263D-4B13-8407-D7D348E8AAAC}", got "C:\winetest\\winetest.msi" msi.c:7603: Test failed: Expected "{C3232306-263D-4B13-8407-D7D348E8AAAC}", got "C:\winetest\\winetest.msi" msi.c:7827: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:7829: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:7888: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:7906: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:7924: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:7926: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:7942: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:7944: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:7961: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:7963: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:7982: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:7984: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:8001: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:8003: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:8119: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:8121: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:8166: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:8168: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:8192: Test failed: Expected "{3E071142-9810-482F-A3BC-307835CE5064}", got "apple" msi.c:8194: Test failed: Expected "{AFCF83EE-1910-4D2B-9431-E5D213087128}", got "banana" msi.c:7827: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:7829: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:7888: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:7906: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:7924: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:7926: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:7942: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:7944: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:7961: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:7963: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:7982: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:7984: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:8001: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:8003: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:8119: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:8121: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:8166: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:8168: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:8192: Test failed: Expected "{C6C5E819-A8C9-472A-A6C4-0B25C4BE950C}", got "apple" msi.c:8194: Test failed: Expected "{19FD8C6F-AF94-4735-B9F4-CB6E80553C15}", got "banana" msi.c:7827: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:7829: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:7888: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:7906: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:7924: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:7926: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:7942: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:7944: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:7961: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:7963: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:7982: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:7984: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:8001: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:8003: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:8119: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:8121: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:8166: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:8168: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:8192: Test failed: Expected "{45A5585C-BBBF-4370-8B8B-2A47AFB6085F}", got "apple" msi.c:8194: Test failed: Expected "{DD02D28F-89E8-4870-B935-0A8BCE2DAB81}", got "banana" msi.c:8446: Test failed: Expected "{04E77E6E-BA67-4A5E-90F3-C9B4299BA046}", got "apple" msi.c:8448: Test failed: Expected "{1BBD0F20-AAFC-4501-9FF9-AF6193A9DCA1}", got "banana" msi.c:8568: Test failed: Expected "{04E77E6E-BA67-4A5E-90F3-C9B4299BA046}", got "apple" msi.c:8570: Test failed: Expected "{1BBD0F20-AAFC-4501-9FF9-AF6193A9DCA1}", got "banana" msi.c:8615: Test failed: Expected "{04E77E6E-BA67-4A5E-90F3-C9B4299BA046}", got "apple" msi.c:8617: Test failed: Expected "{1BBD0F20-AAFC-4501-9FF9-AF6193A9DCA1}", got "banana" msi.c:8641: Test failed: Expected "{04E77E6E-BA67-4A5E-90F3-C9B4299BA046}", got "apple" msi.c:8643: Test failed: Expected "{1BBD0F20-AAFC-4501-9FF9-AF6193A9DCA1}", got "banana" msi.c:8446: Test failed: Expected "{D9AB86F5-8CB4-4B0C-ABB7-537444F6E35F}", got "apple" msi.c:8448: Test failed: Expected "{912A7620-4EBD-4231-85EE-AB96CF738149}", got "banana" msi.c:8568: Test failed: Expected "{D9AB86F5-8CB4-4B0C-ABB7-537444F6E35F}", got "apple" msi.c:8570: Test failed: Expected "{912A7620-4EBD-4231-85EE-AB96CF738149}", got "banana" msi.c:8615: Test failed: Expected "{D9AB86F5-8CB4-4B0C-ABB7-537444F6E35F}", got "apple" msi.c:8617: Test failed: Expected "{912A7620-4EBD-4231-85EE-AB96CF738149}", got "banana" msi.c:8641: Test failed: Expected "{D9AB86F5-8CB4-4B0C-ABB7-537444F6E35F}", got "apple" msi.c:8643: Test failed: Expected "{912A7620-4EBD-4231-85EE-AB96CF738149}", got "banana" msi.c:8938: Test failed: Expected patchcode to be unchanged, got {CF399255-56B3-4687-A3A0-7F251EA1CADD} msi.c:8940: Test failed: Expected targetprod to be unchanged, got {17BDACDF-1FCC-4FAB-89DF-428846E3A7D7} msi.c:9009: Test failed: Expected "{CF399255-56B3-4687-A3A0-7F251EA1CADD}", got "apple" msi.c:9011: Test failed: Expected "{17BDACDF-1FCC-4FAB-89DF-428846E3A7D7}", got "banana" msi.c:9054: Test failed: Expected "{CF399255-56B3-4687-A3A0-7F251EA1CADD}", got "apple" msi.c:9056: Test failed: Expected "{17BDACDF-1FCC-4FAB-89DF-428846E3A7D7}", got "banana" msi.c:9600: Test failed: Expected "{6043D85C-0E7F-4F78-9F6F-8FB0D4D9C7C7}", got "apple" msi.c:9643: Test failed: Expected "{6043D85C-0E7F-4F78-9F6F-8FB0D4D9C7C7}", got "apple" msi.c:9820: Test failed: Expected "{6043D85C-0E7F-4F78-9F6F-8FB0D4D9C7C7}", got "apple"

1 0

Re: [3/8] msi: Move the component enabled check into the standard actions.
by testbot＠testbot.winehq.org 21 Jul '10

21 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3641 Your paranoid android. === WXPPROSP3 (32 bit install) === Timeout === W2K8SE (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:5409: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5428: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5453: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5472: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:5654: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5656: Test failed: Key doesn't exist or wrong type install.c:5657: Test failed: Key doesn't exist or wrong type install.c:5658: Test failed: Key doesn't exist or wrong type install.c:5659: Test failed: Key doesn't exist or wrong type install.c:5660: Test failed: Key doesn't exist or wrong type install.c:5661: Test failed: Key doesn't exist or wrong type install.c:5662: Test failed: Key doesn't exist or wrong type install.c:5663: Test failed: Key doesn't exist or wrong type install.c:5664: Test failed: Key doesn't exist or wrong type install.c:5665: Test failed: Key doesn't exist or wrong type install.c:5666: Test failed: Key doesn't exist or wrong type install.c:5667: Test failed: Key doesn't exist or wrong type install.c:5668: Test failed: Key doesn't exist or wrong type install.c:5669: Test failed: Key doesn't exist or wrong type install.c:5670: Test failed: Key doesn't exist or wrong type install.c:5671: Test failed: Key doesn't exist or wrong type install.c:5672: Test failed: Key doesn't exist or wrong type install.c:5673: Test failed: Key doesn't exist or wrong type install.c:5674: Test failed: Key doesn't exist or wrong type install.c:5675: Test failed: Key doesn't exist or wrong type install.c:5676: Test failed: Key doesn't exist or wrong type install.c:5677: Test failed: Key doesn't exist or wrong type install.c:5680: Test failed: Key doesn't exist or wrong type install.c:5729: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5731: Test failed: Key doesn't exist or wrong type install.c:5732: Test failed: Key doesn't exist or wrong type install.c:5733: Test failed: Key doesn't exist or wrong type install.c:5734: Test failed: Key doesn't exist or wrong type install.c:5735: Test failed: Key doesn't exist or wrong type install.c:5736: Test failed: Key doesn't exist or wrong type install.c:5737: Test failed: Key doesn't exist or wrong type install.c:5738: Test failed: Key doesn't exist or wrong type install.c:5739: Test failed: Key doesn't exist or wrong type install.c:5740: Test failed: Key doesn't exist or wrong type install.c:5741: Test failed: Key doesn't exist or wrong type install.c:5742: Test failed: Key doesn't exist or wrong type install.c:5743: Test failed: Key doesn't exist or wrong type install.c:5744: Test failed: Key doesn't exist or wrong type install.c:5745: Test failed: Key doesn't exist or wrong type install.c:5746: Test failed: Key doesn't exist or wrong type install.c:5747: Test failed: Key doesn't exist or wrong type install.c:5748: Test failed: Key doesn't exist or wrong type install.c:5749: Test failed: Key doesn't exist or wrong type install.c:5750: Test failed: Key doesn't exist or wrong type install.c:5751: Test failed: Key doesn't exist or wrong type install.c:5752: Test failed: Key doesn't exist or wrong type install.c:5755: Test failed: Key doesn't exist or wrong type install.c:5781: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5783: Test failed: Key doesn't exist or wrong type install.c:5784: Test failed: Key doesn't exist or wrong type install.c:5785: Test failed: Key doesn't exist or wrong type install.c:5786: Test failed: Key doesn't exist or wrong type install.c:5787: Test failed: Key doesn't exist or wrong type install.c:5788: Test failed: Key doesn't exist or wrong type install.c:5789: Test failed: Key doesn't exist or wrong type install.c:5790: Test failed: Key doesn't exist or wrong type install.c:5791: Test failed: Key doesn't exist or wrong type install.c:5792: Test failed: Key doesn't exist or wrong type install.c:5793: Test failed: Key doesn't exist or wrong type install.c:5794: Test failed: Key doesn't exist or wrong type install.c:5795: Test failed: Key doesn't exist or wrong type install.c:5796: Test failed: Key doesn't exist or wrong type install.c:5797: Test failed: Key doesn't exist or wrong type install.c:5798: Test failed: Key doesn't exist or wrong type install.c:5799: Test failed: Key doesn't exist or wrong type install.c:5800: Test failed: Key doesn't exist or wrong type install.c:5801: Test failed: Key doesn't exist or wrong type install.c:5802: Test failed: Key doesn't exist or wrong type install.c:5803: Test failed: Key doesn't exist or wrong type install.c:5804: Test failed: Key doesn't exist or wrong type install.c:5807: Test failed: Key doesn't exist or wrong type install.c:5833: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5835: Test failed: Key doesn't exist or wrong type install.c:5836: Test failed: Key doesn't exist or wrong type install.c:5837: Test failed: Key doesn't exist or wrong type install.c:5838: Test failed: Key doesn't exist or wrong type install.c:5839: Test failed: Key doesn't exist or wrong type install.c:5840: Test failed: Key doesn't exist or wrong type install.c:5841: Test failed: Key doesn't exist or wrong type install.c:5842: Test failed: Key doesn't exist or wrong type install.c:5843: Test failed: Key doesn't exist or wrong type install.c:5844: Test failed: Key doesn't exist or wrong type install.c:5845: Test failed: Key doesn't exist or wrong type install.c:5846: Test failed: Key doesn't exist or wrong type install.c:5847: Test failed: Key doesn't exist or wrong type install.c:5848: Test failed: Key doesn't exist or wrong type install.c:5849: Test failed: Key doesn't exist or wrong type install.c:5850: Test failed: Key doesn't exist or wrong type install.c:5851: Test failed: Key doesn't exist or wrong type install.c:5852: Test failed: Key doesn't exist or wrong type install.c:5853: Test failed: Key doesn't exist or wrong type install.c:5854: Test failed: Key doesn't exist or wrong type install.c:5855: Test failed: Key doesn't exist or wrong type install.c:5856: Test failed: Key doesn't exist or wrong type install.c:5859: Test failed: Key doesn't exist or wrong type install.c:5908: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5910: Test failed: Key doesn't exist or wrong type install.c:5911: Test failed: Key doesn't exist or wrong type install.c:5912: Test failed: Key doesn't exist or wrong type install.c:5913: Test failed: Key doesn't exist or wrong type install.c:5914: Test failed: Key doesn't exist or wrong type install.c:5915: Test failed: Key doesn't exist or wrong type install.c:5916: Test failed: Key doesn't exist or wrong type install.c:5917: Test failed: Key doesn't exist or wrong type install.c:5918: Test failed: Key doesn't exist or wrong type install.c:5919: Test failed: Key doesn't exist or wrong type install.c:5920: Test failed: Key doesn't exist or wrong type install.c:5921: Test failed: Key doesn't exist or wrong type install.c:5922: Test failed: Key doesn't exist or wrong type install.c:5923: Test failed: Key doesn't exist or wrong type install.c:5924: Test failed: Key doesn't exist or wrong type install.c:5925: Test failed: Key doesn't exist or wrong type install.c:5926: Test failed: Key doesn't exist or wrong type install.c:5927: Test failed: Key doesn't exist or wrong type install.c:5928: Test failed: Key doesn't exist or wrong type install.c:5929: Test failed: Key doesn't exist or wrong type install.c:5930: Test failed: Key doesn't exist or wrong type install.c:5931: Test failed: Key doesn't exist or wrong type install.c:5934: Test failed: Key doesn't exist or wrong type install.c:6879: Test failed: Expected ERROR_SUCCESS, got 2 install.c:6885: Test failed: Expected ERROR_SUCCESS, got 6 install.c:6886: Test failed: Wrong multi-sz data install.c:6887: Test failed: Expected 15, got 260 install.c:9079: Test failed: key not removed install.c:9089: Test failed: key not removed install.c:9100: Test failed: key not removed install.c:9330: Test failed: key not created

1 0

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.
by Stefan Dösinger 21 Jul '10

21 Jul '10

Allowing the creation of the surface is most likely not enough, the backbuffer has to be useable after it has been created. Specifically, when the app attaches the backbuffer to the frontbuffer(assuming this works, needs a test) wined3d has to be made aware of the change - there's a SetFrontBackBuffers method in the wined3d device to reconfigure the primary swapchain. Am 19.07.2010 um 19:27 schrieb Oldřich Jedlička: > This fixes bug #9008. > --- > dlls/ddraw/ddraw.c | 25 +++++++++++++++++++++---- > dlls/ddraw/ddraw_private.h | 3 +++ > dlls/ddraw/ddraw_thunks.c | 24 ++++++++++++------------ > 3 files changed, 36 insertions(+), 16 deletions(-) > > diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c > index 05c8c62..cf90c39 100644 > --- a/dlls/ddraw/ddraw.c > +++ b/dlls/ddraw/ddraw.c > @@ -2295,6 +2295,7 @@ static HRESULT IDirectDrawImpl_CreateGDISwapChain(IDirectDrawImpl *ddraw, IDirec > * Surf: Address to store the interface pointer at > * UnkOuter: Basically for aggregation support, but ddraw doesn't support > * aggregation, so it has to be NULL > + * AllowBackBuffer: Allow (TRUE) creation of explicit back buffer > * > * Returns: > * DD_OK on success > @@ -2302,11 +2303,12 @@ static HRESULT IDirectDrawImpl_CreateGDISwapChain(IDirectDrawImpl *ddraw, IDirec > * DDERR_* if an error occurs > * > *****************************************************************************/ > -static HRESULT WINAPI > +HRESULT WINAPI > IDirectDrawImpl_CreateSurface(IDirectDraw7 *iface, > DDSURFACEDESC2 *DDSD, > IDirectDrawSurface7 **Surf, > - IUnknown *UnkOuter) > + IUnknown *UnkOuter, > + BOOL AllowBackBuffer) > { > IDirectDrawImpl *This = (IDirectDrawImpl *)iface; > IDirectDrawSurfaceImpl *object = NULL; > @@ -2368,7 +2370,13 @@ IDirectDrawImpl_CreateSurface(IDirectDraw7 *iface, > return DDERR_NOEXCLUSIVEMODE; > } > > - if(DDSD->ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_BACKBUFFER)) { > + if(AllowBackBuffer && (DDSD->ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER))) { > + WARN("Application tried to create an explicit front buffer\n"); > + LeaveCriticalSection(&ddraw_cs); > + return DDERR_INVALIDCAPS; > + } > + > + if (!AllowBackBuffer && (DDSD->ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_BACKBUFFER))) { > WARN("Application tried to create an explicit front or back buffer\n"); > LeaveCriticalSection(&ddraw_cs); > return DDERR_INVALIDCAPS; > @@ -2727,6 +2735,15 @@ IDirectDrawImpl_CreateSurface(IDirectDraw7 *iface, > return hr; > } > > +static HRESULT WINAPI > +IDirectDraw7Impl_CreateSurface(IDirectDraw7 *iface, > + DDSURFACEDESC2 *DDSD, > + IDirectDrawSurface7 **Surf, > + IUnknown *UnkOuter) > +{ > + return IDirectDrawImpl_CreateSurface(iface, DDSD, Surf, UnkOuter, FALSE); > +} > + > #define DDENUMSURFACES_SEARCHTYPE (DDENUMSURFACES_CANBECREATED|DDENUMSURFACES_DOESEXIST) > #define DDENUMSURFACES_MATCHTYPE (DDENUMSURFACES_ALL|DDENUMSURFACES_MATCH|DDENUMSURFACES_NOMATCH) > > @@ -3105,7 +3122,7 @@ const IDirectDraw7Vtbl IDirectDraw7_Vtbl = > IDirectDrawImpl_Compact, > IDirectDrawImpl_CreateClipper, > IDirectDrawImpl_CreatePalette, > - IDirectDrawImpl_CreateSurface, > + IDirectDraw7Impl_CreateSurface, > IDirectDrawImpl_DuplicateSurface, > IDirectDrawImpl_EnumDisplayModes, > IDirectDrawImpl_EnumSurfaces, > diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h > index 3de8668..9810c6f 100644 > --- a/dlls/ddraw/ddraw_private.h > +++ b/dlls/ddraw/ddraw_private.h > @@ -303,6 +303,9 @@ extern const IDirectDrawGammaControlVtbl IDirectDrawGammaControl_Vtbl DECLSPEC_H > extern const IDirect3DTexture2Vtbl IDirect3DTexture2_Vtbl DECLSPEC_HIDDEN; > extern const IDirect3DTextureVtbl IDirect3DTexture1_Vtbl DECLSPEC_HIDDEN; > > +HRESULT WINAPI IDirectDrawImpl_CreateSurface(IDirectDraw7 *iface, DDSURFACEDESC2 *DDSD, > + IDirectDrawSurface7 **Surf, IUnknown *UnkOuter, BOOL AllowBackBuffer) DECLSPEC_HIDDEN; > + > HRESULT WINAPI IDirectDrawSurfaceImpl_AddAttachedSurface(IDirectDrawSurfaceImpl *This, > IDirectDrawSurfaceImpl *Surf) DECLSPEC_HIDDEN; > void IDirectDrawSurfaceImpl_Destroy(IDirectDrawSurfaceImpl *This) DECLSPEC_HIDDEN; > diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c > index 2c205e9..7d6396c 100644 > --- a/dlls/ddraw/ddraw_thunks.c > +++ b/dlls/ddraw/ddraw_thunks.c > @@ -331,9 +331,9 @@ static void set_surf_version(IDirectDrawSurfaceImpl *surf, int version) > } > > static HRESULT WINAPI > -IDirectDrawImpl_CreateSurface(LPDIRECTDRAW This, LPDDSURFACEDESC pSDesc, > - LPDIRECTDRAWSURFACE *ppSurface, > - IUnknown *pUnkOuter) > +IDirectDraw1Impl_CreateSurface(LPDIRECTDRAW This, LPDDSURFACEDESC pSDesc, > + LPDIRECTDRAWSURFACE *ppSurface, > + IUnknown *pUnkOuter) > { > LPDIRECTDRAWSURFACE7 pSurface7; > IDirectDrawSurfaceImpl *impl; > @@ -345,8 +345,8 @@ IDirectDrawImpl_CreateSurface(LPDIRECTDRAW This, LPDDSURFACEDESC pSDesc, > pSDesc->ddsCaps.dwCaps &= ~DDSCAPS_FRONTBUFFER; > /* the LPDDSURFACEDESC -> LPDDSURFACEDESC2 conversion should be ok, > * since the data layout is the same */ > - hr = IDirectDraw7_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw1(This), > - (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter); > + hr = IDirectDrawImpl_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw1(This), > + (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter, TRUE); > if (FAILED(hr)) > { > *ppSurface = NULL; > @@ -371,8 +371,8 @@ IDirectDraw2Impl_CreateSurface(LPDIRECTDRAW2 This, LPDDSURFACEDESC pSDesc, > IDirectDrawSurfaceImpl *impl; > HRESULT hr; > > - hr = IDirectDraw7_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw2(This), > - (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter); > + hr = IDirectDrawImpl_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw2(This), > + (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter, TRUE); > if (FAILED(hr)) > { > *ppSurface = NULL; > @@ -397,8 +397,8 @@ IDirectDraw3Impl_CreateSurface(LPDIRECTDRAW3 This, LPDDSURFACEDESC pSDesc, > IDirectDrawSurfaceImpl *impl; > HRESULT hr; > > - hr = IDirectDraw7_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw3(This), > - (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter); > + hr = IDirectDrawImpl_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw3(This), > + (LPDDSURFACEDESC2)pSDesc, &pSurface7, pUnkOuter, TRUE); > if (FAILED(hr)) > { > *ppSurface = NULL; > @@ -423,8 +423,8 @@ IDirectDraw4Impl_CreateSurface(LPDIRECTDRAW4 This, LPDDSURFACEDESC2 pSDesc, > HRESULT hr; > IDirectDrawSurfaceImpl *impl; > > - hr = IDirectDraw7_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw4(This), > - pSDesc, (LPDIRECTDRAWSURFACE7 *)ppSurface, pUnkOuter); > + hr = IDirectDrawImpl_CreateSurface((IDirectDraw7 *)ddraw_from_ddraw4(This), > + pSDesc, (LPDIRECTDRAWSURFACE7 *)ppSurface, pUnkOuter, TRUE); > impl = (IDirectDrawSurfaceImpl *)*ppSurface; > if(SUCCEEDED(hr) && impl) > { > @@ -1092,7 +1092,7 @@ const IDirectDrawVtbl IDirectDraw1_Vtbl = > IDirectDrawImpl_Compact, > IDirectDrawImpl_CreateClipper, > IDirectDrawImpl_CreatePalette, > - IDirectDrawImpl_CreateSurface, > + IDirectDraw1Impl_CreateSurface, > IDirectDrawImpl_DuplicateSurface, > IDirectDrawImpl_EnumDisplayModes, > IDirectDrawImpl_EnumSurfaces, > -- > 1.7.1.1 > > >

3 6

Re: [2/2] user32: Prevent resize of minimized windows from SetWindowPos (Bug 1719).
by testbot＠testbot.winehq.org 21 Jul '10

21 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3631 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E01AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007001AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000601A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A2 fg 00030050 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00040146 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002E01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002F01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007101AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007501AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007601AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 001801A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A8 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00040146 fg 00030050 in hook HCBT_SETFOCUS

2 1

Re: [1/2] user32/tests: Minimized windows shouldn't be resizable.
by testbot＠testbot.winehq.org 21 Jul '10

21 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3630 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E01AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007001AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000601A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A2 fg 00030050 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00030144 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 009901AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 009A01AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000601A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 001801A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A8 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00030144 fg 00030050 in hook HCBT_SETFOCUS

1 0

Re: [PATCH] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by testbot＠testbot.winehq.org 20 Jul '10

20 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3623 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found === WVISTAADM (32 bit ordinal) === No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1768: Test failed: got 28 ordinal.c:1818: Test failed: got 28 ordinal.c:1826: Test failed: got 28 ordinal.c:1834: Test failed: got 39, length 40 ordinal.c:1845: Test failed: got 42 === W7PROX64 (32 bit ordinal) === ordinal.c:1762: Test failed: got 9 ordinal.c:1768: Test failed: got 25 ordinal.c:1783: Test failed: got 6 ordinal.c:1796: Test failed: got 9 ordinal.c:1804: Test failed: got 9 ordinal.c:1818: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1856: Test failed: got 19 ordinal.c:1867: Test failed: got 22

1 0

Re: [3\4] d3d9: Partially implement GetAdapterDisplayModeEx
by Chris Robinson 20 Jul '10

20 Jul '10

On Tuesday, July 20, 2010 2:28:44 pm Louis Lenders wrote: > + TRACE("iface %p, adapter %u, mode %p.\n", iface, adapter, mode); > + TRACE("iface %p, adapter %u, mode %p, rotation %p\n", iface, adapter, > mode, rotation); This doesn't look right. You probably only need the second TRACE statement, there. It also looks like adapterinfo is being leaked. Any reason you HeapAlloc one to pass in, instead of passing a pointer to a stack object? Eg: struct wined3d_adapter_info_ex adapterinfo; ... hr = IWineD3D_GetAdapterDisplayMode(This->WineD3D, adapter, &m, &adapterinfo);

1 0

Quick legal question... teapot related
by Misha Koshelev 20 Jul '10

20 Jul '10

If I take a publicly available teaset: http://www.sjbaker.org/teapot/teaset.tgz And run it through a Microsoft function: http://msdn.microsoft.com/en-us/library/bb205470%28v=VS.85%29.aspx D3DXTesselateRectPatch for example And then copy the vertex buffer and index buffer and save them... Do I have the rights to use the vertex and index buffers? I am assuming yes... but wanted to double check first. Thank you Misha

4 4

Fyi patch submission information on wiki updated for GitHub
by Misha Koshelev 20 Jul '10

20 Jul '10

My apologies, but it seems that only such a convoluted shell script seems to achieve the correct results for different remotes: http://wiki.winehq.org/GitWine#head-3fe70b8c0310e61d94ba30fe7edf19bd0630e1ef If anyone has a simpler solution, I can definitely update. Unfortunately, the more intuitive git format-patch -k --stdout HEAD~79..HEAD~78 > /tmp/patch.old does not seem to result in patches that can be properly applied onto a different (upstream) remote (see below). Thank you Misha p.s. For the curious I have attached both the patch.old generated using the command above, as well as the patch generated by: git format-patch -k -o out --branches --not --remotes=wine-git I have also attached relevant diff at the very bottom. Output of: diff /tmp/patch.old out/0001 Thank you --- misha@misha-d630:~/src/wine-git$ git reset --hard origin HEAD is now at 15c6057 shlwapi: Implement StrStrNIW. misha@misha-d630:~/src/wine-git$ git am /tmp/patch.old Applying: d3dx9: Add tests for D3DXCreateSphere vertex buffer description. error: patch failed: dlls/d3dx9_36/tests/mesh.c:489 error: dlls/d3dx9_36/tests/mesh.c: patch does not apply Patch failed at 0001 d3dx9: Add tests for D3DXCreateSphere vertex buffer description. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". misha@misha-d630:~/src/wine-git$

2 3

Re: [PATCH 7/7] d3d10: Implement D3D10ReflectShader().
by Henri Verbeet 20 Jul '10

20 Jul '10

2010/7/19 Rico Schüller <kgbricola(a)web.de>: > + e[i].SemanticName = get_semantic(data + name_offset); I'm not sure this will work, I was under the impression semantics can be arbitrary strings. (Which is also why d3d10core goes through the trouble of copying the string data.)

2 1

Re: wined3d: Add Nvidia 8800GTX detection
by Henri Verbeet 20 Jul '10

20 Jul '10

On 20 July 2010 15:49, Luke Bratch <l_bratch(a)yahoo.co.uk> wrote: > Adds detection for the Nvidia 8800GTX card and sets its video memory correctly. > > I have sent this patch in the past but it got rejected, as this method of calculating video card type/memory wasn't supposed to stay around forever, but another similar patch got accepted yesterday so I'm trying again. > I mostly let Roderick worry about card detection, but at the very least this patch has a trailing tab and a driver version number that's inconsistent with the other entries.

2 2

Re: kernel32: Enhance EndUpdateResource
by Alexandre Julliard 20 Jul '10

20 Jul '10

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > Fixes bugs 12017 and 22812 > --- > dlls/kernel32/resource.c | 113 +++++++++++---- > dlls/kernel32/tests/resource.c | 307 > +++++++++++++++++++++++++++++++--------- > 2 files changed, 326 insertions(+), 94 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so package.c && touch package.ok package.c:7660: Test failed: Expected "", got "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName9.dll" package.c:8289: Test failed: Expected "", got "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName4.dll" package.c:8626: Test failed: Expected "", got "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName3.dll" package.c:8905: Test failed: Expected "Z:\home\julliard\wine\wine\dlls\msi\tests\FileName3.dll", got "" make: *** [package.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/kernel32/volume
by Alexandre Julliard 20 Jul '10

20 Jul '10

stephenmsmith(a)blueyonder.co.uk writes: > diff --git a/dlls/kernel32/volume.c b/dlls/kernel32/volume.c > index 7596864..4908739 100644 > --- a/dlls/kernel32/volume.c > +++ b/dlls/kernel32/volume.c > @@ -526,10 +526,17 @@ BOOL WINAPI GetVolumeInformationW( LPCWSTR root, LPWSTR label, DWORD label_len, > } > else > { > - if (!root[0] || root[1] != ':' || root[lstrlenW(root)-1] != '\\' ) > + if (!isalphaW(root[0]) || root[1] != ':' || root[lstrlenW(root)-1] != '\\') > { > - SetLastError( ERROR_INVALID_NAME ); > - return FALSE; > + WCHAR curpath[MAX_PATH],winpath[MAX_PATH]; > + GetCurrentDirectoryW(MAX_PATH,curpath); > + GetWindowsDirectoryW(winpath,MAX_PATH); > + > + if(lstrlenW(curpath) > 3 && root[0] == winpath[0]) > + { > + SetLastError( ERROR_INVALID_NAME ); > + return FALSE; > + } This clearly makes no sense, path syntax doesn't depend on the windows directory. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/5] msi: Add a test for MsiSetFeatureState.
by testbot＠testbot.winehq.org 20 Jul '10

20 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3600 Your paranoid android. === W7PROX64 (32 bit package) === package.c:7603: Test failed: Expected "C:\winetest\FileName1", got "" package.c:7609: Test failed: Expected "C:\winetest\FileName2", got "" package.c:7615: Test failed: Expected "C:\winetest\FileName3", got "" package.c:7627: Test failed: Expected "C:\winetest\FileName5", got "" package.c:7633: Test failed: Expected "C:\winetest\", got "" package.c:7639: Test failed: Expected "C:\winetest\", got "" package.c:7655: Test failed: Expected "C:\winetest\FileName8.dll", got "" package.c:7666: Test failed: Expected "C:\winetest\FileName10.dll", got "" package.c:11679: Test failed: Expected "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11706: Test failed: Expected first 3 chars of "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11716: Test failed: Expected first 37 chars of "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11726: Test failed: Expected "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" package.c:11758: Test failed: Expected "{295F085F-224B-4C34-9A18-C7DBA5A9AC1A}", got "apple" === W7PROX64 (64 bit package) === package.c:8212: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8223: Test failed: Expected "C:\winetest\", got "" package.c:8234: Test failed: Expected "C:\winetest\", got "" package.c:8284: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8295: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8304: Test failed: Expected "C:\", got "" package.c:8310: Test failed: Expected "C:\winetest\", got "" package.c:8331: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8340: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

NPTL and kthreads in the developer guide
by Peter Davies 20 Jul '10

20 Jul '10

Since kthreads has now been removed, references to it in the developer's guide should presumably be removed. What about NPTL? Should discussion comparing it to kthreads be removed? Peter

1 0

Re: [2/2] winhttp: Handle errors from SSL_read.
by testbot＠testbot.winehq.org 20 Jul '10

20 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3599 Your paranoid android. === W2K3R2SESP2 (32 bit winhttp) === winhttp.c:219: Test failed: WinHttpSendRequest failed: 12007

1 0

Re: [1/2] winhttp: Add a partial implementation of WINHTTP_OPTION_SECURITY_CERTIFICATE_STRUCT.
by testbot＠testbot.winehq.org 20 Jul '10

20 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3598 Your paranoid android. === W2K3R2SESP2 (32 bit winhttp) === winhttp.c:219: Test failed: WinHttpSendRequest failed: 12007 winhttp.c:301: Test failed: WinHttpSendRequest failed: 12007 winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:317: Test failed: Expected ERROR_INVALID_PARAMETER got 12019. winhttp.c:318: Test failed: Expected bytes_rw to remain unchanged. winhttp.c:323: Test failed: WinHttpReceiveResponse failed: 12017. winhttp.c:327: Test failed: WinHttpReadData failed: 12019. winhttp.c:329: Test failed: Read 0 bytes instead of 15. winhttp.c:795: Test failed: failed to send request 12007 === W7PRO (32 bit winhttp) === winhttp.c:810: Test failed: failed to send request 12030

1 0

Re: [PATCH 4/8] include: Add INameSpaceTreeControlCustomDraw interface declaration. (try 2)
by Alexandre Julliard 20 Jul '10

20 Jul '10

David Hedberg <david.hedberg(a)gmail.com> writes: > +/***************************************************************************** > + * INameSpaceTreeControlCustomDraw interface > + */ > +[ > + object, > + uuid(2D3BA758-33EE-42D5-BB7B-5F3431D86C78), > + local > +] > + > +interface INameSpaceTreeControlCustomDraw : IUnknown > +{ > + typedef DWORD NSTCCUSTOMDRAW; /*FIXME*/ Why aren't you defining this properly? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/4] d3dx9: Add shift modifiers parsing to the shader assembler.
by Henri Verbeet 20 Jul '10

20 Jul '10

On 20 July 2010 15:11, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > + const char *shiftstrings[] = { Minor, but you should probably declare that as "static const char * const shiftstrings[]".

1 0

Re: mmio: Wrap TRACE strings with debugstr_a / debugstr_an (try 2)
by Nicolas Le Cam 20 Jul '10

20 Jul '10

2010/7/20 Tim Cadogan-Cowper <tccowper(a)yahoo.com.au>: > Fixes bug 10280 (http://bugs.winehq.org/show_bug.cgi?id=10280). Thanks to Eric > Pouech for some feedback on previous attempt and to Maarten Lankhorst for > pointing out a more appropriate way to solve the mmio TRACE buffer overflow > problem. > > IDs of the previous attempt and discussion (now redundant) are 63620, 63625 and > 63725. > > Tim > > Hi Tim, Format specifiers shouldn't be necessary now that you use debugstr_an. -- Nicolas Le Cam

1 0

Re: [5/5] msi: Set feature states to the installed state if the Preselected property is not set.
by Hans Leidekker 20 Jul '10

20 Jul '10

Please ignore this one.

1 0

Re: [PATCH 1/7] msvcp90: Added stub dll
by Alexandre Julliard 20 Jul '10

20 Jul '10

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -0,0 +1,3189 @@ > +#stub ??$?5DU?$char_traits@D@std@@@std@@YAAAV?$basic_istream@DU?$char_traits@D@std@@@0@AAV10@AAD@Z > +#stub ??$?5DU?$char_traits@D@std@@@std@@YAAAV?$basic_istream@DU?$char_traits@D@std@@@0@AAV10@PAD@Z > +#stub ??$?5DU?$char_traits@D@std@@V?$allocator@D@1@@std@@YAAAV?$basic_istream@DU?$char_traits@D@std@@@0@AAV10@AAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@0@@Z > +#stub ??$?5GU?$char_traits@G@std@@@std@@YAAAV?$basic_istream@GU?$char_traits@G@std@@@0@AAV10@AAG@Z > +#stub ??$?5GU?$char_traits@G@std@@@std@@YAAAV?$basic_istream@GU?$char_traits@G@std@@@0@AAV10@PAG@Z > +#stub ??$?5GU?$char_traits@G@std@@V?$allocator@G@1@@std@@YAAAV?$basic_istream@GU?$char_traits@G@std@@@0@AAV10@AAV?$basic_string@GU?$char_traits@G@std@@V?$allocator@G@2@@0@@Z Why are they commented out? Why not define real stubs? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ole32: Implement cross-process drag and drop.
by Huw Davies 20 Jul '10

20 Jul '10

On Mon, Jul 19, 2010 at 04:42:40PM +0100, Huw Davies wrote: > Fix a typo in a comment spotted by Detlef. > --- > dlls/ole32/ole2.c | 199 ++++++++++++++++++++++++++++++++++++++++++++-------- > 1 files changed, 168 insertions(+), 31 deletions(-) Sorry, this is still broken, please ignore. Huw.

1 0

Re: [PATCH 4/9] include: Add INameSpaceTreeControl, INameSpaceTreeControl2 and INameSpaceTreeControlEvents interface declarations.
by Alexandre Julliard 20 Jul '10

20 Jul '10

David Hedberg <david.hedberg(a)gmail.com> writes: > + HRESULT OnItemClick( > + [in, annotation("__in")] IShellItem *psi, > + [in, annotation("__in")] NSTCEHITTEST nstceHitTest, > + [in, annotation("__in")] NSTCECLICKTYPE nstceClickType); > + > + HRESULT OnPropertyItemCommit( > + [in, annotation("__in")] IShellItem *psi); Please don't add these annotations, that's redundant. If we want that sort of things in the generated headers one day we can make widl generate them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] winemenubuilder: use windowscodecs for some ICO to PNG conversion
by Alexandre Julliard 20 Jul '10

20 Jul '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > + dosPNGFileName = wine_get_dos_file_name(pngFileName); > + if (dosPNGFileName == NULL) > + { > + WINE_ERR("error converting %s to DOS file name\n", pngFileName); > + goto end; > + } You can't rely on having a valid DOS name here. You should use the \\?\unix format, or maybe better fix wine_get_dos_file_name() to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: Add an error code
by Alexandre Julliard 20 Jul '10

20 Jul '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -670,7 +670,7 @@ static const DWORD table_c0000001[411] = > 0, /* c0000116 (STATUS_ABIOS_INVALID_SELECTOR) */ > ERROR_INVALID_THREAD_ID, /* c0000117 (STATUS_NO_LDT) */ > 0, /* c0000118 (STATUS_INVALID_LDT_SIZE) */ > - 0, /* c0000119 (STATUS_INVALID_LDT_OFFSET) */ > + ERROR_INVALID_LDT_OFFSET, /* c0000119 (STATUS_INVALID_LDT_OFFSET) */ > 0, /* c000011a (STATUS_INVALID_LDT_DESCRIPTOR) */ > ERROR_BAD_EXE_FORMAT, /* c000011b (STATUS_INVALID_IMAGE_NE_FORMAT) */ > ERROR_RXACT_INVALID_STATE, /* c000011c (STATUS_RXACT_INVALID_STATE) */ You should add the other LDT ones while you are at it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] shlwapi/ordinal: Partially implement SHGetShellKey
by Alexandre Julliard 20 Jul '10

20 Jul '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -2398,6 +2457,7 @@ START_TEST(ordinal) > { > hShlwapi = GetModuleHandleA("shlwapi.dll"); > is_win2k_and_lower = GetProcAddress(hShlwapi, "StrChrNW") == 0; > + is_win9x = (GetVersion() & 0x80000000); You should never check the version, check for features instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name. (try 2)
by testbot＠testbot.winehq.org 20 Jul '10

20 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3576 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2195: Test failed: SHGetNewLinkInfoA succeeded

2 1

Fwd: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6]
by Dan Kegel 20 Jul '10

20 Jul '10

Quoth Linus: "Ask the Wine people what strange open-function-from-hell they are interested in." Full message follows. Discussion archived at e.g. http://marc.info/?l=linux-kernel&m=127955270231189&w=2 ---------- Forwarded message ---------- From: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Mon, Jul 19, 2010 at 8:17 AM Subject: Re: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6] To: David Howells <dhowells(a)redhat.com> Cc: linux-cifs(a)vger.kernel.org, linux-nfs(a)vger.kernel.org, samba-technical(a)lists.samba.org, linux-kernel(a)vger.kernel.org, viro(a)zeniv.linux.org.uk, linux-fsdevel(a)vger.kernel.org, linux-ext4(a)vger.kernel.org On Wed, Jul 14, 2010 at 7:17 PM, David Howells <dhowells(a)redhat.com> wrote: > > ssize_t ret = xstat(int dfd, > const char *filename, > unsigned flags, > const struct xstat_parameters *params, > struct xstat *buffer, > size_t buflen); Ugh. So I think this is pretty disgusting. For a few reasons: - that whole xstat buffer handling is just a mess. I think you already fixed the "xstat_parameters" crud and just made it a simple unsigned long and a direct argument, but the "buffer+buflen" thing is still disgusting. Why not just leave a few empty fields at the end, and make the rule be: "We don't just add random crap, so don't expect it to grow widely in the future". - you use "long long" all over the place. Don't do that. If you want a fixed size, say so, and use "u64/s64". That's the _real_ fixed size, and "long long" just _happens_ to be the same size on all current architectures. Put another way: "long" just _happened_ to be 32 bits way back when on pretty much all targets. That's where all the 64-bit compatibility mess came from. Don't make the same mistake. Besides, if the point is to make things be the same, _document_ that point by using a type that is explicitly sized. - why create that new kind of xstat() that realistically absolutely nobody will use outside of some very special cases, and that has no real advantages for 99.9% of all people? You could make it a "atomic stat+open" by replacing the useless "size" return value with a "fd" return value, add a flag saying "we're also interested in opening it" (in the same result set flags), and instead of that stupid "buflen" input, give the "mode" input that open needs. Tadaa! You now have something that more people might be interested in, if only because it avoids a system call and might be a performance win. Who knows. Ask the Wine people what strange open-function-from-hell they are interested in. > ssize_t ret = fxstat(unsigned fd, Quite frankly, my gut feel is that once you do "xstat(dfd, filename, ...)" then it's damn stupid to do a separate "fxstat()", when you might as well say that "xtstat(dfd, NULL, ...)" is the same as "fxstat(fd, ...)" Now, the difference between adding one or two system calls may not be huge, but just from a cleanliness angle, I really don't see the point of having another fstat variant when the extended xstat() already very naturally supports the thing. And let's face it, using a NULL path pointer just makes sense if you don't have a path. You already passed it a target file descriptor in the dfd. Anyway, I didn't look at whether the new xstat fields made any sense, but I hated the interface enough that I can't be bothered to. Don't make up baroque new things that will never be used. Make a better argument for why anybody would use them despite the lack of standardization etc. And make sure they are as simple as possible (which is why I hate that "buflen" thing etc). Linus

2 1

shell32_test64.exe shlexec: 5-6 DDE tests always fail on testbot W7PROX64
by Ilya Basin 20 Jul '10

20 Jul '10

M> VM Status Number of test failures M> WINEBUILD completed M> W98SE completed 0 M> WNT4WSSP6 completed 0 M> W2KPROSP4 completed 0 M> WXPPROSP3 completed 0 M> W2K3R2SESP2 completed 0 M> WVISTAADM completed 0 M> W2K8SE completed 0 M> W7PRO completed 0 M> W7PROX64 completed 0 M> W7PROX64 completed 5 M> === WINEBUILD (build) === M> No build failures found M> === W98SE (32 bit shlexec) === M> No test failures found M> === WNT4WSSP6 (32 bit shlexec) === M> No test failures found M> === W2KPROSP4 (32 bit shlexec) === M> No test failures found M> === WXPPROSP3 (32 bit shlexec) === M> No test failures found M> === W2K3R2SESP2 (32 bit shlexec) === M> No test failures found M> === WVISTAADM (32 bit shlexec) === M> No test failures found M> === W2K8SE (32 bit shlexec) === M> No test failures found M> === W7PRO (32 bit shlexec) === M> No test failures found M> === W7PROX64 (32 bit shlexec) === M> No test failures found M> === W7PROX64 (64 bit shlexec) === M> shell32: M> shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt7045.tmp\test file.sde", null, null) failed: rc=29 err=2 M> shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt7045.tmp\test file.sde", null, null) failed: rc=29 err=2 M> shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt7045.tmp\test file.sde", null, null) failed: rc=29 err=2 M> shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt7045.tmp\test file.sde", null, null) failed: rc=29 err=2 M> shlexec.c:1738: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt7045.tmp\test file.sde", null, null) failed: rc=29 err=2 Hi! I sent multiple different patches for shlexec and ever since W7PROX64 (64 bit shlexec) is used by testbot, 5 DDE tests always fail on it. I can't reproduce it on local W7PROX64: No shlexec tests fail. test.winehq.org has the same problem http://test.winehq.org/data/d494bda30f1b5b9bc37f094bd8874d3aeeaf8840/win7_w… Another question: winetest64-latest.exe extracts individual test binaries to the temp folder and runs them. How do you extract the binaries without running? --

3 2

Re: ddraw: Allow creating back buffer for pre-DirectX 7 interfaces.
by Henri Verbeet 20 Jul '10

20 Jul '10

2010/7/19 Oldřich Jedlička <oldium.pro(a)seznam.cz>: > This fixes bug #9008. Please provide a more descriptive log message, and consider writing a test. I'm also pretty sure this will conflict with http://source.winehq.org/patches/data/63676.

4 6

Re: [PATCH 7/7] msvcp90/tests: Added char_traits<char>::_Copy_s tests
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3549 Your paranoid android. === W7PROX64 (64 bit misc) === Timeout

1 0

My sincerest sincerest apologies
by Misha Koshelev 19 Jul '10

19 Jul '10

Dear All: I am very very sorry for the spam I have created via my testbot failures. I have struggled quite a bit merging my git repository with upstream Wine today. In fact, when I generated individual patches using git-format-patch from my GitHub repository and then used git-am on the corresponding single files, the patches applied successfully. In fact, I just tried this and they still do. However, for some reason, when I generate a patchset to stdout with git-format-patch rather than individual patches, and then use git-am to apply the resulting file to wine-git, the patches no longer apply. I will investigate this further. Additionally, as I seem to find proper patch difficult at the moment, and have now acquired a winetestbot account, I will, in the future, run my patches through testbot first until I am able to work out the process. Further, I have made some edits regarding merging with GitHub at: wiki.winehq.org/WineGit I will update these comments as I figure out why I was not able to rebase/merge successfully. In any case, I appreciate very much your patience with me as I work these git issues out, and hope that my documentation of my experiences on the Wiki will, in the future, help others who may want to contribute to Wine during a code freeze and do so through the GitHub system. Thank you and my sincerest apologies. Yours Misha P.s. I am looking very much forward to finally meeting some of you at WineConf.

1 0

Re: [PATCH 2/2] d3dx9: Test raw vertex data for D3DXCreateSphere.
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3542 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 2/2] d3dx9: Test raw vertex data for D3DXCreateSphere.
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3542 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 1/2] d3dx9: Add tests for D3DXCreateSphere vertex buffer description.
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3541 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [2/2] fusion: Implement IAssemblyNameImpl_GetDisplayName more completely
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3538 Your paranoid android. === W2K3R2SESP2 (32 bit asmname) === asmname.c:738: Test failed: Expected "wine, processorArchitecture=x86", got "wine" asmname.c:739: Test failed: Expected 32, got 5 asmname.c:751: Test failed: Expected "wine, processorArchitecture=AMD64", got "wine" asmname.c:752: Test failed: Expected 34, got 5 asmname.c:764: Test failed: Expected "wine, processorArchitecture=IA64", got "wine" asmname.c:765: Test failed: Expected 33, got 5 asmname.c:777: Test failed: Expected "wine, processorArchitecture=MSIL", got "wine" asmname.c:778: Test failed: Expected 33, got 5

1 0

Re: shlwapi/tests: Fix GLE for SHFormatDateTimeA
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3535 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:593: Test failed: GetShellSecurityDescriptor should fail ordinal.c:616: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1760: Test failed: got 13 ordinal.c:1766: Test failed: got 26 ordinal.c:1781: Test failed: got 10 ordinal.c:1794: Test failed: got 13 ordinal.c:1802: Test failed: got 13 ordinal.c:1816: Test failed: got 26 ordinal.c:1824: Test failed: got 26 ordinal.c:1832: Test failed: got 38, length 39 ordinal.c:1843: Test failed: got 41 ordinal.c:1854: Test failed: got 23 ordinal.c:1865: Test failed: got 26 === W7PROX64 (32 bit ordinal) === ordinal.c:1760: Test failed: got 9 ordinal.c:1781: Test failed: got 6 ordinal.c:1794: Test failed: got 9 ordinal.c:1802: Test failed: got 9 ordinal.c:1832: Test failed: got 32, length 33 ordinal.c:1843: Test failed: got 35 ordinal.c:1854: Test failed: got 19 ordinal.c:1865: Test failed: got 22 === W7PROX64 (64 bit ordinal) === ordinal.c:1760: Test failed: got 9 ordinal.c:1781: Test failed: got 6 ordinal.c:1794: Test failed: got 9 ordinal.c:1802: Test failed: got 9 ordinal.c:1832: Test failed: got 32, length 33 ordinal.c:1843: Test failed: got 35 ordinal.c:1854: Test failed: got 19 ordinal.c:1865: Test failed: got 22

1 0

Re: ntdll: also parse asmv1 assemblies (with test)
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3533 Your paranoid android. === WXPPROSP3 (32 bit actctx) === actctx.c:603: Test failed: handle == INVALID_HANDLE_VALUE, error 14001 === W2K3R2SESP2 (32 bit actctx) === actctx.c:603: Test failed: handle == INVALID_HANDLE_VALUE, error 14001 === WVISTAADM (32 bit actctx) === actctx.c:603: Test failed: handle == INVALID_HANDLE_VALUE, error 14001 === W2K8SE (32 bit actctx) === actctx.c:603: Test failed: handle == INVALID_HANDLE_VALUE, error 14001 === W7PRO (32 bit actctx) === actctx.c:603: Test failed: handle == INVALID_HANDLE_VALUE, error 14001 === W7PROX64 (32 bit actctx) === actctx.c:603: Test failed: handle == INVALID_HANDLE_VALUE, error 14001 === W7PROX64 (64 bit actctx) === actctx.c:603: Test failed: handle == INVALID_HANDLE_VALUE, error 14001

1 0

Quick license question for teapot
by Misha Koshelev 19 Jul '10

19 Jul '10

Dear All: Sorry to bother - apparently Owen Rudge has done quite a bit of basic texture work, so I will await his patches to start my texture work. As for teapot, Henri recommends looking at freeglut. I know wine is: http://www.winehq.org/license GPL 2.1 Freeglut is "freeglut is released under the X-Consortium license." http://freeglut.sourceforge.net/index.php#download Just wanted to double check if these are compatible. Thx Misha

4 4

MS compatible interface to xulrunner?
by Thomas Kaltenbrunner 19 Jul '10

19 Jul '10

Hello, I am interested to port the wine interface to the xulrunner back to mswindows to access the xulrunner via a IE compatible interface. So it would be easy to replace an embedded IE with the gecko-engine. After some code browsing I thing it will be some of the "DLLs", especially mshtml and shdocvw. I just wanted to hear from you an opinion about that project. What will be the main changes to the wine code - besides renaming of the dlls? Where do you see problems? Did somebody else worked on that or implemented it already? Thanks Thomas Kaltenbrunner -- OPC® cardsystems GmbH Mobil: +49 151 52628082 Skype: tj-opc Zentrale: +49 651 8408 0 Geschäftsführer: Torsten Hülsmann, Dipl.-Ing. (FH) Klaus Dieter Schömer Registergericht: Amtsgericht Wittlich HRB-Nr.: 3903

3 3

Re: [2/7] shlwapi/tests: Add tests for StrStrA.
by Detlef Riekenberg 19 Jul '10

19 Jul '10

Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to read and understand. Please change the name in your Patchset. -- By by ... Detlef ___________________________________________________________ Neu: GMX De-Mail - Einfach wie E-Mail, sicher wie ein Brief! Jetzt De-Mail-Adresse reservieren: http://portal.gmx.net/de/go/demail

2 1

Re: WineD3D: Only perform sRGB write correction on formats that advertise it
by Henri Verbeet 19 Jul '10

19 Jul '10

On 19 July 2010 17:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (((IWineD3DDeviceImpl *)shader->baseShader.device)->strided_streams.position_transformed) > + if (device->strided_streams.position_transformed) You might as well replace both instances.

1 0

Re: ole32: Implement cross-process drag and drop.
by Huw Davies 19 Jul '10

19 Jul '10

On Mon, Jul 19, 2010 at 01:58:07PM +0100, Huw Davies wrote: > --- > dlls/ole32/ole2.c | 199 ++++++++++++++++++++++++++++++++++++++++++++-------- > 1 files changed, 168 insertions(+), 31 deletions(-) Please use the updated version which has fixed a typo in a comment (spotted by Detlef).

1 0

Re: misc: remove references to wineprefixcreate
by Alexandre Julliard 19 Jul '10

19 Jul '10

Austin English <austinenglish(a)gmail.com> writes: > diff --git a/dlls/dinput8/dinput8_main.c b/dlls/dinput8/dinput8_main.c > index 87dd07b..416e355 100644 > --- a/dlls/dinput8/dinput8_main.c > +++ b/dlls/dinput8/dinput8_main.c > @@ -66,7 +66,7 @@ HRESULT WINAPI DECLSPEC_HOTPATCH DirectInput8Create(HINSTANCE hinst, DWORD dwVer > > hr = CoCreateInstance( &CLSID_DirectInput8, punkOuter, CLSCTX_INPROC_SERVER, riid, ppDI); > if(FAILED(hr)) { > - ERR("CoCreateInstance failed with hr = %d; Try running wineprefixcreate to fix it.\n", hr); > + ERR("CoCreateInstance failed with hr = %d; Try running `wineboot -u` to fix it.\n", hr); It doesn't make sense to recommend wineboot instead, users should never have to do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] gameux: Add IClassFactory implementation
by Henri Verbeet 19 Jul '10

19 Jul '10

2010/7/18 Mariusz Pluciński <vshader(a)gmail.com>: > +static HRESULT WINAPI gameuxcf_QueryInterface( > + IClassFactory *iface, > + REFIID riid, > + LPVOID *ppobj ) > +{ > + if (IsEqualGUID(riid, &IID_IUnknown) || > + IsEqualGUID(riid, &IID_IClassFactory)) > + { > + IClassFactory_AddRef( iface ); > + *ppobj = iface; > + return S_OK; > + } > + > + FIXME("interface %s not implemented\n", debugstr_guid(riid)); > + return E_NOINTERFACE; > +} QueryInterface() is usually supposed to set "*ppobj" to NULL if the interface is not implemented by the object, any reason for not doing that here?

1 0

Re: kernel32: Stubs for GetLogicalProcessorInformation(Ex) (resent)
by Alexandre Julliard 19 Jul '10

19 Jul '10

Paul Chitescu <paulc(a)voip.null.ro> writes: > @@ -3323,6 +3323,26 @@ HANDLE WINAPI GetCurrentProcess(void) > } > > /*********************************************************************** > + * GetLogicalProcessorInformation (KERNEL32.@) > + */ > +BOOL WINAPI GetLogicalProcessorInformation(void *buffer, PDWORD pBufLen) That's not the correct prototype. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name.
by Alexandre Julliard 19 Jul '10

19 Jul '10

David Hedberg <david.hedberg(a)gmail.com> writes: > --- > dlls/shell32/shell32.spec | 2 +- > dlls/shell32/shell32_main.h | 5 ----- > dlls/shell32/shlmenu.c | 2 +- > dlls/shell32/tests/shlfileop.c | 14 +++++++------- > dlls/shell32/undocshell.h | 4 ---- > include/shlobj.h | 6 ++++++ > 6 files changed, 15 insertions(+), 18 deletions(-) It should still be imported by ordinal, and you shouldn't need to change the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] shlwapi/ordinal: Partially implement SHGetShellKey
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3514 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found

1 0

Re: user32: Add a test showing that SetForegroundWindow() on a visible child of invisible parent does activate the parent an
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3510 Your paranoid android. === W2KPROSP4 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000900A6 fg 000600AE in hook HCBT_SETFOCUS === WXPPROSP3 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000900F4 fg 000400F2 in hook HCBT_SETFOCUS === W2K3R2SESP2 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000200C8 fg 00040102 in hook HCBT_SETFOCUS === WVISTAADM (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0002018A fg 00070202 in hook HCBT_SETFOCUS === W2K8SE (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070184 fg 000C0152 in hook HCBT_SETFOCUS === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E01AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007001AE fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS win.c:2687: Test failed: GetActiveWindow() = 00000000 win.c:2687: Test failed: GetFocus() = 00000000 win.c:2713: Test failed: GetActiveWindow() = 00000000 win.c:2713: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000601A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A2 fg 00030050 in hook HCBT_SETFOCUS win.c:2772: Test failed: GetActiveWindow() = 00000000 win.c:2772: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009016C fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002E01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 002F01A2 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501B0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000901B0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A01B0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 001801A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000401A8 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009016C fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0009016C fg 00060128 in hook HCBT_SETFOCUS === W7PROX64 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0007017C fg 002302AA in hook HCBT_SETFOCUS === W7PROX64 (64 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000007017C fg 00000000002302AA in hook HCBT_SETFOCUS

1 0

Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)
by Henri Verbeet 19 Jul '10

19 Jul '10

On 17 July 2010 21:14, Misha Koshelev <misha680(a)gmail.com> wrote: > @@ -636,6 +636,10 @@ static void D3DXCreateBoxTest(void) > IDirect3DVertexBuffer9_Release(vertex_buffer); > } > > + /* Index buffer */ > + number_of_faces = box->lpVtbl->GetNumFaces(box); > + todo_wine ok( number_of_faces == 12, "Got result %u, expected 12\n",number_of_faces); > + > box->lpVtbl->Release(box); > } > I think this could easily have been part of the original test as well. It's good to send small patches that make sense on their own, but I don't think there's much to be gained by splitting up a patch that adds a test for a single function.

1 0

Re: [PATCH 05/10] d3dx9: Add comment to delineate vertex buffer and index buffer tests. (try 2)
by Henri Verbeet 19 Jul '10

19 Jul '10

On 17 July 2010 21:13, Misha Koshelev <misha680(a)gmail.com> wrote: > --- > dlls/d3dx9_36/tests/mesh.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c > index cac515e..401e61e 100644 > --- a/dlls/d3dx9_36/tests/mesh.c > +++ b/dlls/d3dx9_36/tests/mesh.c > @@ -546,6 +546,7 @@ static void D3DXCreateBoxTest(void) > > if (hr == D3D_OK && box) > { > + /* Vertex buffer */ > number_of_vertices = box->lpVtbl->GetNumVertices(box); > todo_wine ok( number_of_vertices == 24, "Got result %u, expected 24\n",number_of_vertices); > > @@ -704,6 +705,7 @@ static void D3DXCreateSphereTest(void) > > if (sphere) > { > + /* Vertex buffer */ > number_of_vertices = sphere->lpVtbl->GetNumVertices(sphere); > todo_wine ok( number_of_vertices == 4, "Got result %u, expected 4\n",number_of_vertices); > Why didn't you add these in the original patches?

1 0

Re: [PATCH 04/10] d3dx9: Add tests for D3DXCreateBox. (try 2)
by Henri Verbeet 19 Jul '10

19 Jul '10

Same comments apply as for the previous patches. With this being a larger dataset it makes even more sense to calculate the vertices instead of hardcoding them.

1 0

Re: [PATCH 03/10] d3dx9: Test raw vertex data for D3DXCreateSphere. (try 2)
by Henri Verbeet 19 Jul '10

19 Jul '10

On 17 July 2010 21:13, Misha Koshelev <misha680(a)gmail.com> wrote: > +#include <assert.h> You don't use that in this patch. > + D3DXVECTOR3 test_vertex_data[8]; I think it makes sense to use the same kind of structure you're using in your implementation of D3DXCreateSphere() here. > + if (vertex_data) > + { > + test_vertex_data[0].x = 0.0f; test_vertex_data[0].y = 0.0f; test_vertex_data[0].z = 1.0f; > + test_vertex_data[1].x = 0.0f; test_vertex_data[1].y = 0.0f; test_vertex_data[1].z = 1.0f; > + test_vertex_data[2].x = 0.0f; test_vertex_data[2].y = 1.0f; test_vertex_data[2].z = -4.37114e-008f; > + test_vertex_data[3].x = 0.0f; test_vertex_data[3].y = 1.0f; test_vertex_data[3].z = -4.37114e-008f; > + test_vertex_data[4].x = -8.74228e-008f; test_vertex_data[4].y = -1.0f; test_vertex_data[4].z = -4.37114e-008f; > + test_vertex_data[5].x = -8.74228e-008f; test_vertex_data[5].y = -1.0f; test_vertex_data[5].z = -4.37114e-008f; > + test_vertex_data[6].x = 0.0f; test_vertex_data[6].y = 0.0f; test_vertex_data[6].z = -1.0f; > + test_vertex_data[7].x = 0.0f; test_vertex_data[7].y = 0.0f; test_vertex_data[7].z = -1.0f; > + Note that you can simply initialize test_vertex_data with these values. On the other hand, you could also just calculate the expected values.

1 0

Re: [PATCH 02/10] d3dx9: Add tests for D3DXCreateSphere vertex buffer description. (try 2)
by Henri Verbeet 19 Jul '10

19 Jul '10

On 17 July 2010 21:13, Misha Koshelev <misha680(a)gmail.com> wrote: > + if (hr == D3D_OK) > + { > + todo_wine ok( vertex_buffer_description.Format == D3DFMT_VERTEXDATA, "Got result %x, expected %x (D3DFMT_VERTEXDATA)\n",vertex_buffer_description.Format,D3DFMT_VERTEXDATA); > + todo_wine ok( vertex_buffer_description.Type == D3DRTYPE_VERTEXBUFFER, "Got result %x, expected %x (D3DRTYPE_VERTEXBUFFER)\n",vertex_buffer_description.Type,D3DRTYPE_VERTEXBUFFER); > + todo_wine ok( vertex_buffer_description.Usage == 0, "Got result %x, expected %x\n",vertex_buffer_description.Usage,0); > + todo_wine ok( vertex_buffer_description.Pool == D3DPOOL_MANAGED, "Got result %x, expected %x (D3DPOOL_DEFAULT)\n",vertex_buffer_description.Pool,D3DPOOL_DEFAULT); > + expected = number_of_vertices * sizeof(D3DXVECTOR3) * 2; > + todo_wine ok( vertex_buffer_description.Size == expected, "Got result %x, expected %x\n",vertex_buffer_description.Size,expected); > + todo_wine ok( vertex_buffer_description.FVF == (D3DFVF_XYZ | D3DFVF_NORMAL), "Got result %x, expected %x (D3DFVF_XYZ | D3DFVF_NORMAL)\n",vertex_buffer_description.FVF,D3DFVF_XYZ | D3DFVF_NORMAL); > + } > + Those shouldn't need to be todo_wine, the tests shouldn't even get run with current Wine. I guess it doesn't matter much though.

1 0

Re: user32: Make sure that main window state is consistent during the tests. (Resend)
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3509 Your paranoid android. === WVISTAADM (32 bit win) === win.c:2271: Test failed: 001401C8: expected prev 001001C6, got 003B01B4 win.c:2272: Test failed: 001001C6: expected next 001401C8, got 003B01B4 win.c:2198: Test failed: 005C01BE: expected next 000C01B6, got 001201C2 win.c:2271: Test failed: 003C01B4: expected prev 001601C8, got 001301C2 win.c:2272: Test failed: 001601C8: expected next 003C01B4, got 001301C2 === W2K8SE (32 bit win) === win.c:2271: Test failed: 00190116: expected prev 000F0144, got 002F0114 win.c:2272: Test failed: 000F0144: expected next 00190116, got 002F0114 win.c:2198: Test failed: 005D0118: expected next 000B0126, got 00270122 win.c:2271: Test failed: 00300114: expected prev 001B0116, got 00280122 win.c:2272: Test failed: 001B0116: expected next 00300114, got 00280122 === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E01A4 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007001A4 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501AA fg 00030050 in hook HCBT_SETFOCUS win.c:2674: Test failed: GetActiveWindow() = 00000000 win.c:2674: Test failed: GetFocus() = 00000000 win.c:2700: Test failed: GetActiveWindow() = 00000000 win.c:2700: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007101A4 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000701AA fg 00030050 in hook HCBT_SETFOCUS win.c:2759: Test failed: GetActiveWindow() = 00000000 win.c:2759: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 003001AA fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 003101AA fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A0136 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000E0136 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000F0136 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 008301A4 fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0007014E fg 00030050 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000501A0 fg 00030050 in hook HCBT_SETFOCUS

1 0

Re: [PATCH 1/2] include/shell32: Shell_MergeMenus should be declared in shlobj.h and exported by name.
by testbot＠testbot.winehq.org 19 Jul '10

19 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3414 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2197: Test failed: SHGetNewLinkInfoA succeeded

2 1

Re: kernel32: add a test for CreateFileA()
by Nikolay Sivov 19 Jul '10

19 Jul '10

On 7/18/2010 10:17, Austin English wrote: > Passed all the vm's on wtb. Hi, Austin. This looks strange: > + > + hFile = CreateFileA("c:\\*.*", GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL ); > + ok(GetLastError() == ERROR_INVALID_NAME || broken(GetLastError() == ERROR_FILE_NOT_FOUND) || broken(GetLastError() == ERROR_PATH_NOT_FOUND), > + "CreateFileA should have returned ERROR_INVALID_NAME on %s, but got %u\n", filename, GetLastError()); > + CloseHandle( hFile ); If a call failed then you should test for null hFile I suppose and remove CloseHandle(). Also when testing for last error a common rule is to set it first before the call. Does anything depend on this having 3 possible return values?

3 2

Re: kernel32: add a test for CreateFileA()
by James McKenzie 19 Jul '10

19 Jul '10

Austin English wrote: > Passed all the vm's on wtb. > > > ------------------------------------------------------------------------ > > + hFile = CreateFileA("c:\\*.*", GENERIC_READ,FILE_SHARE_READ,NULL,OPEN_EXISTING,FILE_ATTRIBUTE_NORMAL,NULL ); + ok(GetLastError() == ERROR_INVALID_NAME || broken(GetLastError() == ERROR_FILE_NOT_FOUND) || broken(GetLastError() == ERROR_PATH_NOT_FOUND), + "CreateFileA should have returned ERROR_INVALID_NAME on %s, but got %u\n", filename, GetLastError()); + CloseHandle( hFile ); Nice negative test, but how about one that should pass? James McKenzie

2 1

re: D3DXCreateTeapot and reverse engineering?
by Dan Kegel 19 Jul '10

19 Jul '10

IMHO, our criterion is "we only need to implement what apps really need", and for the moment, that app probably could live with a stub for D3DXCreateTeapot. When we run into a complaint about our lousy teapot, we can create a better one. So relax, just do a stub, and move on to more important things. Also, as Roderick says, sucking tables out of Windows is not ok, for copyright reasons.

5 6

D3DXCreateTeapot and reverse engineering?
by Misha Koshelev 18 Jul '10

18 Jul '10

Dear All: I just wanted to double check before I do anything with D3DXCreateTeapot. I have several options for implementing this: Option A -------- One, the slightly harder option, involves the original dataset: http://www.sjbaker.org/teapot/teaset.tgz Option B -------- Another, much simpler method, would be to: a) Call D3DXCreateTeapot b) D3DXCreateTeapot returns a vertex and index buffer c) I can easily use these to create a header file that _exactly_ reproduces the vertices and indices created by Windows. My question: is Option B allowed, and if not, why not? Thank you Misha p.s. This is for this bug: http://bugs.winehq.org/show_bug.cgi?id=22918

3 2

re: dlls/user.exec16/user.c: Use FIXME_ONCE for quieter reports
by Dan Kegel 18 Jul '10

18 Jul '10

James wrote: > This whole line of thought was rejected, at least once. Yes, but see his later patchset. I think he's now just trying to provide a uniform abstraction for the existing ad-hoc single-shot FIXMEs without adding any new ones, following Henri's advice in http://www.winehq.org/pipermail/wine-devel/2010-July/085069.html

2 1

Re:
by GOUJON Alexandre 18 Jul '10

18 Jul '10

On 07/18/2010 04:17 PM, Tom Wickline wrote: > You forgot to attach the patches :) and a subjust is nice as well. > > Tom > > On Sun, Jul 18, 2010 at 6:16 PM, Alexandre Goujon > <ale.goujon(a)gmail.com <mailto:ale.goujon@gmail.com>> wrote: > > > Here is another big path; should fix bug #18071. > These tests crash on NT4 but I don't really know how to handle this. > I found #ifdef CRASHES_ON_NT40 in advapi32/tests/crypt.c so I'm > using it. > > I don't know if I have to do git reset before submitting another > patch so let me know. > Yeah you're right. I did "git send-email --compse out" which let me type this comment (http://source.winehq.org/patches/data/63618) explaining data/63619. Then, I git-apply'ed another patch and I did again the same command. So the http://source.winehq.org/patches/data/63621 comment is for data/6362[2-3] As you can see, data/63623 is the same patch as data/63619 : I did't do git-reset but I rm'ed out/ What I want is to add a comment to some patch before the --- dlls/advapi32/security.c | 69 ++++++++++++++++++++++++++++----------- dlls/advapi32/tests/security.c | 27 +++++++++++++++ 2 files changed, 76 insertions(+), 20 deletions(-) for instance. Any idea how to do that ?

2 1

Re: mmio: Ensure FOURCC string conversions are null-terminated.
by Eric Pouech 18 Jul '10

18 Jul '10

the explanations for the bug fix look really strange all the printf use %4.4s form, which will limit output to only 4 chars, whatever the string is terminated or not so the crash doesn't come from here looking quickly at the patch, several remark arise - in the second & third modification to the TRACE call, are you sure the test to srcType is relevant (I don't have the code handy, but it may be a wrong cut & paste) - more importantly, as the %4.4s form implies a 4 char strings, the strings used in case of NULL value must be 4 characters long, instead we may get into trouble A+ 2010/7/18 Tim Cadogan-Cowper <tccowper(a)yahoo.com.au> > Three TRACE debug calls in the mmioDescend function of mmio.c attempt > to print FOURCC data, by directly casting it to LPCSTR. This is > dangerous as: (i) FOURCC data types are DWORDs, i.e. four bytes (one for > each char), with no null terminating byte (see > http://msdn.microsoft.com/en-us/library/dd375802%28VS.85%29.aspx); and > (ii) it assumes the byte order on the host architecture is little endian. > > Because the LPCSTR casts are not necessarily null-terminated there will > occasionally be buffer overflows in mmio's TRACE debug strings, with a > consequent crash to desktop and debug output beginning with > 'wine_dbg_vprintf: > debugstr buffer overflow...' For a consistent and predictable case where > this > occurs, see Bug 10280 "Oblivion: Horse Armour Crash" > (http://bugs.winehq.org/show_bug.cgi?id=10280). > > This patch fixes the problem (and any crashes caused by it) by using a > new internal function in mmio - mmioFOURCCToString - which converts FOURCC > data to strings that are correctly null-terminated and respect byte order. > I have tested with Oblivion and can confirm it fixes Bug 10280 on my > machine (ubuntu 10.04). Furthermore the patch will ensure that chunk IDs > and > fourccTypes are correctly printed in the mmio debug channel (at the moment > they are not). > > Tim > > > > > > -- -- Eric Pouech

1 0

re: Anotated 'make test' log
by Dan Kegel 18 Jul '10

18 Jul '10

What problem are you trying to solve? I gather you're just plowing through the output of 'make test', looking at each bit of noise, and trying to figure out a way to improve the tests? While that's a noble quest, and I'd like to encourage people to improve the tests, it might be more productive to do so around areas of pain for users. For instance, you could look at bugs in bugzilla that have patches attached that aren't committed yet because tests are needed, and write those tests. - Dan

4 6

Re: [4/5] gameux/tests: Add creating test for IGameExplorer
by Nikolay Sivov 18 Jul '10

18 Jul '10

On 7/18/2010 15:59, Mariusz Pluciński wrote: > + /* interface available up from Vista */ > + hr = CoCreateInstance(&CLSID_GameExplorer, NULL, CLSCTX_INPROC_SERVER,&IID_IGameExplorer, (LPVOID*)&ge); > + ok(ge&& hr == S_OK, "IGameExplorer creating failed (result false)\n"); > + if(ge) > + { > + IGameExplorer_Release(ge); > + } It's still better to properly skip even if automated run won't try this test cause gameux module is missing. Nice way is to try to create object inside main function of a test, before any other test_* functions and skip properly with win_skip or skip (if wine can't create it either at this point).

1 0

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview. (try 2)
by testbot＠testbot.winehq.org 18 Jul '10

18 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3459 Your paranoid android. === WXPPROSP3 (32 bit shlview) === shlview.c:921: Test failed: Failed to subclass listview

2 1

Re: [4/5] gameux/tests: Add creating test for IGameExplorer
by testbot＠testbot.winehq.org 18 Jul '10

18 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3456 Your paranoid android. === W98SE (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === WNT4WSSP6 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2KPROSP4 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === WXPPROSP3 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2K3R2SESP2 (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false) === W2K8SE (32 bit gameexplorer) === gameexplorer.c:42: Test failed: IGameExplorer creating failed (result false)

1 0

Re: [PATCH 1/5 try2] jscript: Fixed sort_cmp for non-string arguments.
by testbot＠testbot.winehq.org 18 Jul '10

18 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3449 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [1/2] imagehlp: Add tests for ImageGetDigestStream
by Henri Verbeet 18 Jul '10

18 Jul '10

On 17 July 2010 09:07, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > +#ifdef NONAMELESSUNION > +# define U(x) (x).u > +#else > +# define U(x) (x) > +#endif I think this is already done in wine/test.h? > +static BOOL WINAPI accumulating_stream_output(DIGEST_HANDLE handle, BYTE *pb, > + DWORD cb) "pb" can probably be const.

2 1

Re: kernel32: Enhance EndUpdateResource
by Henri Verbeet 18 Jul '10

18 Jul '10

On 17 July 2010 09:06, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > + if (nt->OptionalHeader.FileAlignment <= 0) I can't comment much on the changes themselves, but FileAlignment is unsigned, so can't be < 0.

2 1

Re: user32: RegisterClassEx should check for invalid cbSize field.
by Dmitry Timoshkov 18 Jul '10

18 Jul '10

Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > + wcexA.cbSize = 0; > + wcexA.style = cls.style; > + wcexA.lpfnWndProc = cls.lpfnWndProc; > + wcexA.cbClsExtra = cls.cbClsExtra; > + wcexA.cbWndExtra = cls.cbWndExtra; > + wcexA.hInstance = cls.hInstance; > + wcexA.hIcon = cls.hIcon; > + wcexA.hCursor = cls.hCursor; > + wcexA.hbrBackground = cls.hbrBackground; > + wcexA.lpszMenuName = cls.lpszMenuName; > + wcexA.lpszClassName = cls.lpszClassName; > + wcexA.hIconSm = 0; > + ok( ((RegisterClassExA( &wcexA ) == 0) && (GetLastError() == ERROR_INVALID_PARAMETER)), > + "Failed with invalid number of cbSize bytes\n"); Testing other values besides 0 would be helpful, in particular values like sizeof(class) - 1 and sizeof(class) + 1. Did you inspect all the places in Wine which call RegisterClassEx()? Also, GetClassInfoEx() in Wine is an obvious offender, and this needs a test (and a fix) too. -- Dmitry.

2 1

Re: dlls/user.exec16/user.c: Use FIXME_ONCE for quieter reports
by James McKenzie 18 Jul '10

18 Jul '10

Max TenEyck Woodbury wrote: > --- > dlls/user.exe16/user.c | 48 ++++++++++++++++++++++++------------------------ > 1 files changed, 24 insertions(+), 24 deletions(-) > > This whole line of thought was rejected, at least once. What is your justification to add this to the project. This should be in the changelog section. Also, if this is a resubmission due to the code freeze, this should have a (resend) at the end of the title. James McKenzie

1 0

Re: [Resend] Add '_ONCE' variants of DPRINTF, FIXME, WARN.
by Mike Kaplinskiy 18 Jul '10

18 Jul '10

On Sat, Jul 17, 2010 at 1:29 AM, Max TenEyck Woodbury <max(a)mtew.isa-geek.net> wrote: > +#define WINE_FIXME_ONCE(args...) do { } while(0) > +#define WINE_FIXME_ONCE_ONCE_(ch) WINE_FIXME_ONCE I think you want WINE_FIXME_ONCE_ not WINE_FIXME_ONCE_ONCE_. > +#define WINE_FIXME_ONCE(args...) do { } while(0) > +#define WINE_FIXME_ONCE_ONCE_(ch) WINE_FIXME_ONCE Ditto > +#define __WINE_DPRINTF_ONCE(dbcl,dbch) /* FIXME */ \ > + (!__WINE_GET_DEBUGGING(dbcl,(dbch)) || \ > + (wine_dbg_log(__WINE_DBCL##dbcl,(dbch),__FILE__,"%d: ",__LINE__) == -1)) ? \ > + (void)0 : (void)wine_dbg_printf > + Ask if you don't know how to do it. I don't think we bite too much :). I have no idea what compilers need this instead of the versions for GNU and SunPro. In fact, I don't actually know what compilers those would be (clang may be one of them?). But in the worst case I would suggest at least #error 'ing if someone uses __WINE_DPRINTF_ONCE on these instead of falling back to non-once behavior. > +#define WARN_ONCE_(ch) WINE_WARE_ONCE_(ch) typo > +#define ERR_ONCE WINE_ERR_ONCEE typo

1 0

Re: ws2_32: socket.c: wrapped WSASendTo/WSARecvFrom with a different function name
by Mike Kaplinskiy 17 Jul '10

17 Jul '10

On Sat, Jul 17, 2010 at 7:02 AM, Pigeon <pigeon(a)pigeond.net> wrote: > > WSASendTo/WSARecvFrom, wrapped in a different function name, so that > internal calls from ws2_32 itself will not trigger programs like Garena, > which catches WSASendTo/WSARecvFrom calls. > > Reference: Wine Bug Id #16047 > > --- > dlls/ws2_32/socket.c | 73 ++++++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 59 insertions(+), 14 deletions(-) > > > > > The helpers shouldn't need a WINAPI (those are for exported functions only). And don't use INT in helpers (int is fine). You might also want to give them better names. The names tend to be something like WS2_(lower_case_with_underscore_for_space) in that file. You may want to align the arguments as they were before, but now I'm just nitpicking :). If this does get in, we may want to nominate it for stable - it's a pretty simple change. Mike.

1 0

[PATCH] winealsa.drv: Always scan devices, even if a default device exists.
by Jeff Cook 17 Jul '10

17 Jul '10

Let me know what you guys think of this one, I think it will be somewhat controversial. There is a registry key to enable this currently, but it should really occur by default and maybe be unchangeable. If you have multiple cards, like a USB mic for capture, scan_devices to 0, as would occur on many configurations currently, is undesirable and most users won't be able to work around it. I'm not sure why scan_devices would be 0, maybe to prevent bugs while probing or something, but I don't see much reason to disable scanning all reported audio devices. Thoughts? Please let me know if I'm missing anything. From Jeff --- dlls/winealsa.drv/waveinit.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)

1 0

Re: ws2_32: socket.c: wrapped WSASendTo/WSARecvFrom with a different function name
by John Klehm 17 Jul '10

17 Jul '10

On Sat, Jul 17, 2010 at 6:02 AM, Pigeon <pigeon(a)pigeond.net> wrote: > > WSASendTo/WSARecvFrom, wrapped in a different function name, so that > internal calls from ws2_32 itself will not trigger programs like Garena, > which catches WSASendTo/WSARecvFrom calls. > > Reference: Wine Bug Id #16047 > > --- Need your real name when submitting a patch. See http://wiki.winehq.org/SubmittingPatches item 1. Regards, --John

1 0

[RFC PATCH 2/2] wined3d: Let GetRasterStatus return D3DERR_INVALIDCALL.
by Florian Köberle 17 Jul '10

17 Jul '10

--- dlls/d3d9/tests/device.c | 1 - dlls/wined3d/swapchain_base.c | 2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 0acedcb..2345c34 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -2771,7 +2771,6 @@ static void test_get_raster_status(void) if ((caps.Caps & D3DCAPS_READ_SCANLINE) == 0) { ZeroMemory( &rasterStatus, sizeof(rasterStatus) ); hr = IDirect3DDevice9_GetRasterStatus(pDevice, 0, &rasterStatus); - todo_wine ok(hr == D3DERR_INVALIDCALL, "GetRasterStatus should return D3DERR_INVALIDCALL\n"); } else { skip("Device supports D3DCAPS_READ_SCANLINE\n"); diff --git a/dlls/wined3d/swapchain_base.c b/dlls/wined3d/swapchain_base.c index 1817de2..3f2a4e5 100644 --- a/dlls/wined3d/swapchain_base.c +++ b/dlls/wined3d/swapchain_base.c @@ -131,7 +131,7 @@ HRESULT WINAPI IWineD3DBaseSwapChainImpl_GetRasterStatus(IWineD3DSwapChain *ifac FIXME("iface %p, raster_status %p stub!\n", iface, pRasterStatus); warned = TRUE; } - return WINED3D_OK; + return WINED3DERR_INVALIDCALL; } HRESULT WINAPI IWineD3DBaseSwapChainImpl_GetDisplayMode(IWineD3DSwapChain *iface, WINED3DDISPLAYMODE*pMode) { -- 1.7.0.4

2 1

[RFC PATCH 1/2] d3d9/tests: Test that GetRasterStatus returns D3DERR_INVALIDCALL if D3DCAPS_READ_SCANLINE isn't set.
by Florian Köberle 17 Jul '10

17 Jul '10

--- dlls/d3d9/tests/device.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index ba25760..0acedcb 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -2735,6 +2735,58 @@ done: if (d3d9) IDirect3D9_Release(d3d9); } +static void test_get_raster_status(void) +{ + HRESULT hr; + HWND hwnd = NULL; + IDirect3D9 *pD3d = NULL; + IDirect3DDevice9 *pDevice = NULL; + D3DPRESENT_PARAMETERS d3dpp; + D3DDISPLAYMODE d3ddm; + D3DCAPS9 caps; + D3DRASTER_STATUS rasterStatus; + + pD3d = pDirect3DCreate9( D3D_SDK_VERSION ); + ok(pD3d != NULL, "Failed to create IDirect3D9 object\n"); + hwnd = CreateWindow( "static", "d3d9_test", WS_OVERLAPPEDWINDOW, 100, 100, 160, 160, NULL, NULL, NULL, NULL ); + ok(hwnd != NULL, "Failed to create window\n"); + if (!pD3d || !hwnd) goto cleanup; + + IDirect3D9_GetAdapterDisplayMode( pD3d, D3DADAPTER_DEFAULT, &d3ddm ); + ZeroMemory( &d3dpp, sizeof(d3dpp) ); + d3dpp.Windowed = TRUE; + d3dpp.SwapEffect = D3DSWAPEFFECT_DISCARD; + d3dpp.BackBufferFormat = d3ddm.Format; + d3dpp.BackBufferCount = 0; + + hr = IDirect3D9_CreateDevice( pD3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd, + D3DCREATE_SOFTWARE_VERTEXPROCESSING, &d3dpp, &pDevice ); + ok(hr == S_OK || hr == D3DERR_NOTAVAILABLE, + "Failed to create IDirect3D9Device (%08x)\n", hr); + if (FAILED(hr)) goto cleanup; + + hr = IDirect3DDevice9_GetDeviceCaps(pDevice, &caps); + ok(hr == D3D_OK, "IDirect3DDevice9_GetCaps failed with %08x\n", hr); + + if ((caps.Caps & D3DCAPS_READ_SCANLINE) == 0) { + ZeroMemory( &rasterStatus, sizeof(rasterStatus) ); + hr = IDirect3DDevice9_GetRasterStatus(pDevice, 0, &rasterStatus); + todo_wine + ok(hr == D3DERR_INVALIDCALL, "GetRasterStatus should return D3DERR_INVALIDCALL\n"); + } else { + skip("Device supports D3DCAPS_READ_SCANLINE\n"); + } + +cleanup: + if (pDevice) + { + UINT refcount = IDirect3DDevice9_Release(pDevice); + ok(!refcount, "Device has %u references left.\n", refcount); + } + if (pD3d) IDirect3D9_Release(pD3d); + DestroyWindow( hwnd ); +} + START_TEST(device) { HMODULE d3d9_handle = LoadLibraryA( "d3d9.dll" ); @@ -2778,5 +2830,6 @@ START_TEST(device) test_scissor_size(); test_wndproc(); test_wndproc_windowed(); + test_get_raster_status(); } } -- 1.7.0.4

2 1

Re: [PATCH 1/5] jscript: Fixed sort_cmp for non-string arguments.
by Henri Verbeet 17 Jul '10

17 Jul '10

On 17 July 2010 13:28, Jacek Caban <jacek(a)codeweavers.com> wrote: > + }else if(V_VT(v1) == VT_EMPTY) { > + *cmp = V_VT(v1) == VT_EMPTY ? 0 : 1; That looks wrong, should that read "*cmp = V_VT(v2) == VT_EMPTY ? 0 : 1;" instead?

1 0

re: [2/2] imagehlp: Implement ImageGetDigestStream
by Dan Kegel 17 Jul '10

17 Jul '10

I was worried that mapping the file will fail if you're low on address space and are running this function on a large PE file. It ought to be possible to write a test to see how the function behaves when you've used up oodles of address space, though it'd be tricky to make the test reliable. I see that Windows has a similar problem in MapFileAndCheckSum (which is said to be a caller of this function) http://www.daniweb.com/forums/thread122484.html so who knows, maybe Windows also maps the file...

2 1

Re: [PATCH 10/10] d3dx9: Add basic test for D3DXCreateBox vertex buffer declaration. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3426 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 09/10] d3dx9: Implement D3DXCreateBox for the case of incorrect parameters. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3425 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 08/10] d3dx9: Add NULL mesh parameter test to D3DXCreateBox. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3424 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 07/10] d3dx9: Add tests for D3DXCreateBox index buffer description. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3423 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 06/10] d3dx9: Add test for number of faces in D3DXCreateBox. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3422 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 05/10] d3dx9: Add comment to delineate vertex buffer and index buffer tests. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3421 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 04/10] d3dx9: Add tests for D3DXCreateBox. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3420 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 03/10] d3dx9: Test raw vertex data for D3DXCreateSphere. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3419 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 02/10] d3dx9: Add tests for D3DXCreateSphere vertex buffer description. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3418 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [PATCH 01/10] d3dx9: Test number of vertices for D3DXCreateSphere, retrieve vertex buffer. (try 2)
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3417 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Sending patches for bug #22918
by Misha Koshelev 17 Jul '10

17 Jul '10

Dear All: Congrats on 1.2! I have begun sending my patches from my repository: http://github.com/misha680/wine/commits/master Specifically, I have sent the first 10 patches (of approx 70 currently). I look forward to your comments/commits ;) Also, if anyone knows how to make git format-patch only output the 10 _bottom-most_ patches, please let me know. I tried: git format-patch -n --stdout origin --branches --not --remotes=upstream -10 | git imap-send (note the -10 in the command above) but that sends the 10 topmost patches, sadly :( Thanks again! Misha

6 7

Re: shell32: Implement Set/GetCurrentViewMode in the default shellview.
by Nikolay Sivov 17 Jul '10

17 Jul '10

On 7/17/2010 19:08, David Hedberg wrote: > static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT mode) > { > - IShellViewImpl *This = impl_from_IFolderView(iface); > - FIXME("(%p)->(%u), stub\n", This, mode); > - return E_NOTIMPL; > + IShellViewImpl *This = impl_from_IFolderView(iface); > + RECT rc; > + TRACE("(%p)->(%u), stub\n", This, mode); > + > + if((mode< FVM_FIRST || mode> FVM_LAST)&& > + (mode != FVM_AUTO)) > + return E_INVALIDARG; > + > + /* Destroy the previous listview */ > + ShellView_DestroyView(This); > + > + /* Change the viewmode */ > + This->FolderSettings.ViewMode = mode; > + > + /* Create a new listview */ > + ShellView_CreateView(This); > + > + /* Size the new listview properly. */ > + GetClientRect(This->hWnd,&rc); > + MoveWindow(This->hWndList, 0, 0, rc.right, rc.bottom, TRUE); > + > + return S_OK; > } Why do you think you should destroy Listview here? It's not obvious at all. I think it's only about changing style.

2 4

If we can't open a device as stereo, try mono. This is necessary for snd-usb-audio mics.
by Jeff Cook 17 Jul '10

17 Jul '10

--- dlls/winealsa.drv/waveinit.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)

2 1

Re: shell32: Implement IPersistFolder2 for the desktop folder.
by Nikolay Sivov 17 Jul '10

17 Jul '10

On 7/17/2010 19:08, David Hedberg wrote: > +static HRESULT WINAPI ISF_Desktop_IPersistFolder2_fnInitialize( > + IPersistFolder2 *iface, LPCITEMIDLIST pidl) > +{ > + FIXME("Not implemented.\n"); > + return E_NOTIMPL; Call it just "stub" and dump parameters please. > + > + pidl = NULL; > + hr = IPersistFolder2_GetCurFolder(ppf2,&pidl); > + ok(hr == S_OK, "got %08x\n", hr); > + ok(pidl != NULL, "pidl was NULL.\n"); > + > + IPersistFolder2_Release(ppf2); > + } You're leaking pidl here.

1 0

Re: Please remove / block user from bugzilla
by James Mckenzie 17 Jul '10

17 Jul '10

>> Would it be possible to add a line to the text above the comment entry box >> (by the "do not paste logs" warning) telling people more explicitly what sorts >> of comments are appropriate, and directing them to the forum for user support? >> Yes, I know some people will ignore it anyway, but it might help cut down on the >> noise. > >As you point out, people don't read... it might be more useful to >put a length limit check so that posting a long comment requires >privileges. Maybe that could be done as simply as "if this is user's >first bug, don't let him post more than ten lines". > Dan: Rosanne and you have a good point, but I would restrict it the limit to four lines. You should be able to describe a valid bug in that space. Anything more, and it becomes an attachement. This would take care of the log file that was dropped in one bug and the 'I can't figure this out so here's five screenshots' in another. +1 to the limit for my vote. James McKenzie

6 9

Re: [PATCH 5/5] mshtml: Added IHTMLDocument3::detachEvent implementation.
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3405 Your paranoid android. === WVISTAADM (32 bit events) === Timeout

1 0

Init mixer on cards with a single Mic control, like snd_usb_audio mics
by Jeff Cook 17 Jul '10

17 Jul '10

This patch fixes bug #12706 and creates a mixer for snd-usb-audio cards, which have only a single Mic control and nothing else. Subsequent patches may be needed to make this useful depending on configuration. I am including this here for commentary before I submit to wine-patches. This is my first patchset to WINE, so please forgive and correct me if I am "doing it wrong". Thanks Jeff --- dlls/winealsa.drv/mixer.c | 58 ++++++++++++++++++++++++++++++++++----------- 1 files changed, 44 insertions(+), 14 deletions(-)

1 0

Re: [RFC PATCH 0/2] GetRasterStatus: Needs to be tested on Windows
by Florian Köberle 17 Jul '10

17 Jul '10

Sorry for the big attachment, didn't realize that crosstests executables are so large.

1 1

Re: [PATCH 1/5] jscript: Fixed sort_cmp for non-string arguments.
by testbot＠testbot.winehq.org 17 Jul '10

17 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3401 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH] WEBSITE: fixed 1.2 tarball link
by Marcus Meissner 17 Jul '10

17 Jul '10

On Sat, Jul 17, 2010 at 01:21:19PM +0200, Marcus Meissner wrote: > --- > news/de/2010071601.xml | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/news/de/2010071601.xml b/news/de/2010071601.xml > index b521984..5dc2a1a 100644 > --- a/news/de/2010071601.xml > +++ b/news/de/2010071601.xml > @@ -1,10 +1,10 @@ > <news> > <date>16. Juli 2010</date> > -<title>Wine 1.2 Freigegeben</title> > +<title>Wine 1.f Freigegeben</title> gnh, forget this patch. > <body> > Das Wine Team ist stolz verk??nden zu d??rfen, dass die stabile Version Wine 1.2 freigegeben wurde. > Dieses Release repr??sentiert zwei Jahre Entwicklungsaufwand und ??ber 23000 ??nderungen. Die haupts??chlichen Highlights sind die Unterst??tzung f??r 64-Bit Programme und die neuen, auf dem Tango Standard basierten Grafiken. > Weiterhin enthalten sind viele Verbesserungen quer durch die Bank und ??ber 3000 Fehlerbehebungen. Siehe auch den <a href="{$root}/announce/1.2">Freigabevermerk</a> f??r eine Zusammenstellung gr????erer ??nderungen. > -Der Quellcode ist jetzt <a href="http://prdownloads.sourceforge.net/wine/wine-1.2-rc7.tar.bz2">verfügbar</a>. > +Der Quellcode ist jetzt <a href="http://prdownloads.sourceforge.net/wine/wine-1.2.tar.bz2">verfügbar</a>. > Binär-Downloads werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Download-Seiten</a> zur Verfügung. > </body></news> > -- > 1.5.6 > >

1 0

Post-release plans
by Alexandre Julliard 17 Jul '10

17 Jul '10

Folks, First I want to thank everybody for your great work of the past two years. I'm very happy with what we have achieved with 1.2 (even if we didn't manage to get the regression numbers down ;-) You should all go out and have a drink to celebrate. Code freeze is of course lifted now, so once you have recovered from your hangover you can go wild with patches again. Please resubmit any patch that was marked deferred (rebased to the current tip of course). Releases will be made from the 1.3.x development branch every two weeks as usual. The 'stable' git branch has been reset to point to 1.2. Fixes can be nominated for cherry-picking to the stable branch by setting the '1.2.x' milestone in bugzilla. Please only nominate bugs that are already fixed in the tip and that contain the sha1 of the corresponding commit. There will be a 1.2.1 release in a couple of months. There may be further stable releases if enough fixes can be still be cherry-picked cleanly to make it worth it. Bugs that are currently on the 1.2 milestone should not be automatically carried forward to the 1.4 milestone. We'll want to reevaluate which bugs are really important for 1.4, based on the release criteria once these are defined. But of course fixing the remaining 1.2-nominated bugs is still allowed... -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [resubmit] cmd: Fix cmd's mishandling of quote-enclosed command strings
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3367 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === W2KPROSP4 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === WXPPROSP3 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === W2K3R2SESP2 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === WVISTAADM (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === W2K8SE (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === W7PRO (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === W7PROX64 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74 === W7PROX64 (64 bit) === batch.c:188: Test failed: unexpected end of output in line 48, expected 0x74

1 0

Re: [PATCH 01/10] d3dx9: Add stub and basic test for D3DXCreateSphere.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3357 Your paranoid android. === WINEBUILD (build) === Make failed

2 1

Re: [PATCH 10/10] d3dx9: Add NULL mesh parameter test to D3DXCreateBox.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3366 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 09/10] d3dx9: Implement D3DXCreateBox for the case of incorrect parameters.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3365 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 08/10] d3dx9: Add tests for D3DXCreateBox index buffer description.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3364 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 07/10] d3dx9: Add test for number of faces in D3DXCreateBox.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3363 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 06/10] d3dx9: Add comment to delineate vertex buffer and index buffer tests.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3362 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 05/10] d3dx9: Add tests for D3DXCreateBox.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3361 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 04/10] d3dx9: Test raw vertex data for D3DXCreateSphere.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3360 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 03/10] d3dx9: Add tests for D3DXCreateSphere vertex buffer description.
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3359 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.
by Michael Stefaniuc 16 Jul '10

16 Jul '10

Hello Max, are you replacing all FIXME with FIXME_ONCE? While I do agree that we need the _ONCE variant changing all FIXME is not useful. bye michael On 07/14/2010 09:02 PM, Max TenEyck Woodbury wrote: > --- > dlls/ntdll/file.c | 40 ++++++++++++++++++---------------------- > 1 files changed, 18 insertions(+), 22 deletions(-) > > diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c > index 0a6ee55..0b59765 100644 > --- a/dlls/ntdll/file.c > +++ b/dlls/ntdll/file.c > @@ -117,7 +117,7 @@ static NTSTATUS FILE_CreateFile( PHANDLE handle, ACCESS_MASK access, POBJECT_ATT > > if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; > > - if (alloc_size) FIXME( "alloc_size not supported\n" ); > + if (alloc_size) FIXME_ONCE( "alloc_size not supported\n" ); > > if (options& FILE_OPEN_BY_FILE_ID) > io->u.Status = file_id_to_unix_file_name( attr,&unix_name ); > @@ -1484,7 +1484,7 @@ NTSTATUS WINAPI NtFsControlFile(HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc > break; > > case FSCTL_PIPE_IMPERSONATE: > - FIXME("FSCTL_PIPE_IMPERSONATE: impersonating self\n"); > + FIXME_ONCE("FSCTL_PIPE_IMPERSONATE: impersonating self\n"); > status = RtlImpersonateSelf( SecurityImpersonation ); > break; > > @@ -1531,7 +1531,7 @@ NTSTATUS WINAPI NtSetVolumeInformationFile( > ULONG Length, > FS_INFORMATION_CLASS FsInformationClass) > { > - FIXME("(%p,%p,%p,0x%08x,0x%08x) stub\n", > + FIXME_ONCE("(%p,%p,%p,0x%08x,0x%08x) stub\n", > FileHandle,IoStatusBlock,FsInformation,Length,FsInformationClass); > return 0; > } > @@ -2397,8 +2397,7 @@ static NTSTATUS get_device_info( int fd, FILE_FS_DEVICE_INFORMATION *info ) > } > } > #else > - static int warned; > - if (!warned++) FIXME( "device info not properly supported on this platform\n" ); > + FIXME_ONCE( "device info not properly supported on this platform\n" ); > info->DeviceType = FILE_DEVICE_DISK_FILE_SYSTEM; > #endif > info->Characteristics |= FILE_DEVICE_IS_MOUNTED; > @@ -2430,7 +2429,6 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io > { > int fd, needs_close; > struct stat st; > - static int once; > > if ((io->u.Status = server_get_unix_fd( handle, 0,&fd,&needs_close, NULL, NULL )) != STATUS_SUCCESS) > return io->u.Status; > @@ -2441,10 +2439,10 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io > switch( info_class ) > { > case FileFsVolumeInformation: > - if (!once++) FIXME( "%p: volume info not supported\n", handle ); > + FIXME_ONCE( "%p: volume info not supported\n", handle ); > break; > case FileFsLabelInformation: > - FIXME( "%p: label info not supported\n", handle ); > + FIXME_ONCE( "%p: label info not supported\n", handle ); > break; > case FileFsSizeInformation: > if (length< sizeof(FILE_FS_SIZE_INFORMATION)) > @@ -2513,19 +2511,19 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io > } > break; > case FileFsAttributeInformation: > - FIXME( "%p: attribute info not supported\n", handle ); > + FIXME_ONCE( "%p: attribute info not supported\n", handle ); > break; > case FileFsControlInformation: > - FIXME( "%p: control info not supported\n", handle ); > + FIXME_ONCE( "%p: control info not supported\n", handle ); > break; > case FileFsFullSizeInformation: > - FIXME( "%p: full size info not supported\n", handle ); > + FIXME_ONCE( "%p: full size info not supported\n", handle ); > break; > case FileFsObjectIdInformation: > - FIXME( "%p: object id info not supported\n", handle ); > + FIXME_ONCE( "%p: object id info not supported\n", handle ); > break; > case FileFsMaximumInformation: > - FIXME( "%p: maximum info not supported\n", handle ); > + FIXME_ONCE( "%p: maximum info not supported\n", handle ); > break; > default: > io->u.Status = STATUS_INVALID_PARAMETER; > @@ -2560,7 +2558,7 @@ NTSTATUS WINAPI NtQueryEaFile( HANDLE hFile, PIO_STATUS_BLOCK iosb, PVOID buffer > BOOLEAN single_entry, PVOID ea_list, ULONG ea_list_len, > PULONG ea_index, BOOLEAN restart ) > { > - FIXME("(%p,%p,%p,%d,%d,%p,%d,%p,%d) stub\n", > + FIXME_ONCE("(%p,%p,%p,%d,%d,%p,%d,%p,%d) stub\n", > hFile, iosb, buffer, length, single_entry, ea_list, > ea_list_len, ea_index, restart); > return STATUS_ACCESS_DENIED; > @@ -2584,7 +2582,7 @@ NTSTATUS WINAPI NtQueryEaFile( HANDLE hFile, PIO_STATUS_BLOCK iosb, PVOID buffer > */ > NTSTATUS WINAPI NtSetEaFile( HANDLE hFile, PIO_STATUS_BLOCK iosb, PVOID buffer, ULONG length ) > { > - FIXME("(%p,%p,%p,%d) stub\n", hFile, iosb, buffer, length); > + FIXME_ONCE("(%p,%p,%p,%d) stub\n", hFile, iosb, buffer, length); > return STATUS_ACCESS_DENIED; > } > > @@ -2636,18 +2634,16 @@ NTSTATUS WINAPI NtLockFile( HANDLE hFile, HANDLE lock_granted_event, > NTSTATUS ret; > HANDLE handle; > BOOLEAN async; > - static BOOLEAN warn = TRUE; > > if (apc || io_status || key) > { > - FIXME("Unimplemented yet parameter\n"); > + FIXME_ONCE("Unimplemented yet parameter\n"); > return STATUS_NOT_IMPLEMENTED; > } > > - if (apc_user&& warn) > + if (apc_user ) > { > - FIXME("I/O completion on lock not implemented yet\n"); > - warn = FALSE; > + FIXME_ONCE("I/O completion on lock not implemented yet\n"); > } > > for (;;) > @@ -2672,7 +2668,7 @@ NTSTATUS WINAPI NtLockFile( HANDLE hFile, HANDLE lock_granted_event, > > if (async) > { > - FIXME( "Async I/O lock wait not implemented, might deadlock\n" ); > + FIXME_ONCE( "Async I/O lock wait not implemented, might deadlock\n" ); > if (handle) NtClose( handle ); > return STATUS_PENDING; > } > @@ -2710,7 +2706,7 @@ NTSTATUS WINAPI NtUnlockFile( HANDLE hFile, PIO_STATUS_BLOCK io_status, > > if (io_status || key) > { > - FIXME("Unimplemented yet parameter\n"); > + FIXME_ONCE("Unimplemented yet parameter\n"); > return STATUS_NOT_IMPLEMENTED; > } >

7 12

Administrative privileges and running tests under Windows
by Mariusz Pluciński 16 Jul '10

16 Jul '10

Hi wine-devel I have problems with tests I written last time. The problem is connected with privileges levels under Windows. The method I'm testing is IGameExplorer::AddGame, which registers given game in Windows Game Explorer. One of it's parameters (installScope) defines if game should be registered for all users or only currently logged one. The problem is that routine's behaviour depends on if application was started with administrative privileges or not. If I call method with GIS_ALL_USERS parameter, it succeeds only with administrative privileges (fails if I run it as normal user). If I call it with GIS_CURRENT_USER parameter, it succeeds under normal user level, and fails (sic!) under administrative. My question is, how I should write tests to support both of these cases. Both seems to be exclusive, and I prefer first to ask, rather than trying implement it in some odd (and probably wrong) way. I also want to make it available to run under Wine project's test machines, but I don't know how they're configured and will them allow me to test administrative case.

2 2

Re: [website] German translation of stable release news 1.2
by Paul Vriens 16 Jul '10

16 Jul '10

On 07/16/2010 05:50 PM, André Hentschel wrote: > +Der Quellcode ist jetzt<a href="http://prdownloads.sourceforge.net/wine/wine-1.2-rc7.tar.bz2">verfügbar</a>. Hi André, You've listed the wrong download. -- Cheers, Paul.

1 0

re: Please remove / block user from bugzilla
by Dan Kegel 16 Jul '10

16 Jul '10

I only see one post from him ever, and he was *trying* to be helpful. Everybody should get a few chances. A warning should suffice. If you ask me, http://bugs.winehq.org/show_bug.cgi?id=6971#c371 is more objectionable, because it shows the Wine community to be ill-mannered and hostile to newbies. - Dan

7 19

RFC: Detecting the wine prefix
by Paul Chitescu 16 Jul '10

16 Jul '10

Hi! I would want to implement a change in where the wine prefix is assumed by default. The current behavior of only considering WINEPREFIX is cumbersome and risky. Slip a finger, forget a letter and you end running a potential disastrous command in the wrong prefix. I ruined my main prefix by accidenatlly running "winetricks ie6" in it... To fix that I use a wrapper script (unimaginatively named "win") that detects the proper prefix from the current directory and calls wine or other programs (winecfg, wineserver, winetricks, etc.) after setting WINEPREFIX. I am satisfied by this wrapper but has several disadvantages: - You need to remember to run it instead of wine. - You may paste a command from somewhere and forget to add "win" in front. - Needs to be distributed. The proposed solution is to incorporate the prefix detection logic in wine itself so no wrapper is needed. The modified behavior would be like this: - If WINEPREFIX is set obey that, user knows better. This is also required to create a new prefix. - Starting from current working directory descend towards root looking for a directory that: 1. Has a dosdevices/ subdirectory and a system.reg file or 2. Has a .wine symlink pointing to a directory matching condition 1. or 3. Holds a .wine regular file whose content is the name of a directory matching condition 1. - If a valid prefix (matches condition 1. above) is found use it for wine - Else use the default ~/.wine The extra checks 2. and 3. are to be able to handle the case when the current directory is on a path that is symlinked from inside the prefix. In particular test 3. is used when the files are on a FAT (or other symlink incapable) partition. I have several wine prefixes whose "Program Files" is located on a much larger FAT32 partition shared with you know what. What do you think about this? Should I go on coding it? Paul Chitescu

4 6

Re: Please remove / block user from bugzilla
by James Mckenzie 16 Jul '10

16 Jul '10

Luke Benstead <kazade(a)gmail.com> wrote: >Sent: Jul 16, 2010 7:18 AM >To: Henri Verbeet <hverbeet(a)gmail.com> >Cc: wine-devel(a)winehq.org, Dan Kegel <dank(a)kegel.com> >Subject: Re: Please remove / block user from bugzilla > >> How do frequent wine committers, and especially Alexandre, feel about >> > these two issues? >> I'd say Alexandre's opinion is pretty clear, as always: >> http://www.winehq.org/pipermail/wine-devel/2010-February/081744.html. >> >> >That's doesn't settle this at all, Alexandre is almost certainly referring >to the bug number in the patch itself there, rather than the subject line. Actually, during the first part of the Wine 1.2 rc set, it was suggested to put the bug number somewhere in either the changelog or in the subject line. What I seen in the message is that AJ wanted something more meaningful in the code than just "testing for bug XXXX". The comment could become part of the Wine code base and is not clear. James McKenzie

1 0

Cascading test failures
by Greg Geldorp 16 Jul '10

16 Jul '10

Ideally, tests should be independent on each other. That's not the case right now. A clear example is msi:package, which often fails (on XP) with 1574 errors, see http://test.winehq.org/data/tests/msi:package.html. For all the cases I've checked, when these 1574 errors occur the preceding msi:install test timed out (the reverse is not true, I see msi:install timeouts followed by a successful msi:package). My current theory is that the Windows Installer service gets confused when the msi:install test times out and is bluntly terminated by the winetest wrapper. A possible solution might be to introduce a cleanup mechanism invoked by winetest.exe when it detects a timeout or crash in one of the test executables. After terminating the test executable, winetest.exe would then call "testname_test.exe --cleanup failed_test_name". The --cleanup argument could be handled by the tests main(), just like --list is handled by main(). A test executable would be able to register a cleanup function by setting a global function pointer to its cleanup function. In the case of msi_test.exe, that cleanup function could try to stop and restart the Windows Installer service. Does this sound worthwhile to pursue? Any other/better ideas? Ge.

5 6

Re: kernel32: Update the Dutch translation
by Paul Vriens 16 Jul '10

16 Jul '10

On 07/16/2010 03:05 PM, Sven Baars wrote: > MessageId=1207 > SymbolicName=ERROR_NOT_CONTAINER > Language=NLD > -Not a container > +Geen > . You are missing something here I guess. -- Cheers, Paul.

2 1

Re: wineboot: fix Serbian Latin translation
by Paul Vriens 16 Jul '10

16 Jul '10

On 07/14/2010 09:40 AM, Damjan Jovanovic wrote: > Changelog: > * wineboot: fix Serbian Latin translation > > Damjan Jovanovic > Hi Damjan, Thanks for looking into this. I guess we need the pragma statement now as you are introducing UTF-8, not? I did talk to Nenad about the fact that his translations appeared to be all ASCII (and I did see some non-ASCII ones on wikipedia) but no response so I'd figured it was correct. -- Cheers, Paul.

3 4

Re: cmd: Fix cmd's mishandling of quote-enclosed command strings
by Jacek Caban 16 Jul '10

16 Jul '10

On 7/16/10 1:16 PM, Wilbert Ho wrote: > cmd mishandles quote-enclosed command strings because the leading > quote is included in the string when wine searches through the > built-in commands (dir is a builtin, but "dir is not). > > $ ./wine cmd.exe /c "dir README" > wine: cannot find L"C:\\windows\\system32\\dir.exe" > File not found > > To fix this, offset the string being compared to the array of builtins > by the number of leading quotes before doing the comparison. > +dir /b Makefile test_builtins.cmd +dir /b Makefile +dir /b test_builtins.cmd +dir /b "Makefile" +dir /b "test_builtins.cmd" +"dir /b Makefile" +"dir /b test_builtins.cmd" You can't assume that these files are present when running the test. If you need additional files for test, you have to create them in runtime. In this particular case it looks like you could choose other builtin command for test that doesn't require any additional file. Jacek

1 0

Re: cmd: Fix cmd's mishandling of quote-enclosed command strings
by testbot＠testbot.winehq.org 16 Jul '10

16 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3340 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === W2KPROSP4 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === WXPPROSP3 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === W2K3R2SESP2 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === WVISTAADM (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === W2K8SE (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === W7PRO (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === W7PROX64 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d === W7PROX64 (64 bit) === batch.c:188: Test failed: unexpected end of output in line 46, expected 0x4d

1 0

Use of broken()
by James McKenzie 16 Jul '10

16 Jul '10

All: I've been making statements on the mailing list about some of the less documented features of Wine coding. I've also stated that asking questions is much better than asking permission....(in a very round about way.) So here goes: I am building a test for the EM_FINDWORDBREAK function in riched20. There are eight different test cases, but I found differences in one of them: WB_CLASSIFY: For the input value 0x85, Windows 7 returns the value 0x14. Windows 2000 and Windows NT 4 return a zero. Would it be appropriate to use the broken() function at this point? This has been the case for all test runs against these particular VMs on the testbot. I thank you in advance for assistance rendered. James McKenzie

1 0

Re: Please remove / block user from bugzilla
by James Mckenzie 16 Jul '10

16 Jul '10

Henri Verbeet <hverbeet(a)gmail.com> wrote: > >On 14 July 2010 16:26, Dan Kegel <dank(a)kegel.com> wrote: >> If you ask me, >> http://bugs.winehq.org/show_bug.cgi?id=6971#c371 >> is more objectionable, because it shows the Wine >> community to be ill-mannered and hostile to newbies. >Sure, it could have been worded more carefully, but I don't buy the >"taints us all" theory. > >However, if we're talking about being harmful to the project, I think >it's far more insidious and actively harmful to pretend being an >active / respected Wine developer and giving potential new developers >bad advice from that position. Because what happens is that those >people take that advice in good faith, start writing patches, and >perhaps even develop some habits based on it. But when those patches >then hit wine-patches and get shot down during review, it's the >reviewers that get blamed for being "picky" or "harsh", while in some >cases the entire premise on which those patches are based is simply >wrong. I think that does far more harm to new developers than "being >mean to someone on the internet". > >Of course with Wine being an open project there's not a whole lot we >can do about people saying whatever they like, except perhaps teaching >potential new developers about things like "git shortlog -s -n >--since={5year}". > On that vein of thought, why don't we have a code standard page? I've been asking this question and maybe this should be my next area of concern after the release of Wine 1.2 and the reinput of my patches. This way, I can use my 'years of expertise' and what I've learned about this project as far as coding practices. I don't want to wait on AJ to do this. James McKenzie

3 2

WINE - ODBC - MSSQL Server
by Sarves K 15 Jul '10

15 Jul '10

Hi I just tried to configure an windows application which requires a connection from a remote mssql server. But I not succeded in it. I am getting Connection failed : SQLState : '01000' SQL Server Error : 10061 ..................... Connection failed : SQLState : '08001' SQL Server Error : 17 .......... I set the connection type as TCP/IP and port number also were correct. What could be the reason.. Thanks Sarves Sri Lanka

1 0

re: Test questions: defining test structures as global variables and quick floating point reference
by Dan Kegel 15 Jul '10

15 Jul '10

Misha wrote: > 2) Finally, as you have noticed, per Dan's advice, I have implemented > this function: > ... > These seem, if anything, much simpler, and, I have noticed in the case > of very complicated test data, more accurate. > > I am going to change my code to use these latter functions, even though > they are not technically as good comparators as my current ones. If the simpler routines work, that's fine, go with what's most readable. It's still good to know about the issues raised in http://www.cygnus-software.com/papers/comparingfloats/comparingfloats.htm for those times when it's hard to figure out the right epsilon ahead of time. - Dan

1 0

Re: WineConf 2010
by James Mckenzie 15 Jul '10

15 Jul '10

Francois Gouget <fgouget(a)free.fr> wrote: > >Hi, > > >WineConf 2010 is taking shape: the date has been set and we are now in >the final stages of picking the venue. > >The host city: Paris > Paris is a big city, where is the venue? James McKenzie

2 1

Test questions: defining test structures as global variables and quick floating point reference
by Misha Koshelev 15 Jul '10

15 Jul '10

Dear All: Thank you again for all your help. To remind you, I am working on fixing: http://bugs.winehq.org/show_bug.cgi?id=22918 And, as we are currently in code freeze, I have a GitHub repo here in which I am making relevant changes: http://github.com/misha680/wine/commits/master I am going over my patches and had a few questions with which I'd appreciate your help. Specifically, I'd like to know the answers, if possible, sooner rather than later, so that in case things come up later when I submit patches, I can simply reference the relevant wine-devel discussions. My questions are as follows. 1) In some tests, I need to declare global variables to store test data. For example, in this patch: http://github.com/misha680/wine/commit/17d2bb17d5868bd533dba6f1e1f9d8e6753b… I declare these structures: #define MAX_CYLINDER_VERTICES 1000 /* arbitrary */ D3DXVECTOR3 cylinder_test_vertex_data[MAX_CYLINDER_VERTICES]; 1a) Is this kosher? The other option would be to dynamically allocate, but this seems like a lot of overhead for a test. If I declare such structures _within_ functions, I seem to have problems with memory access to these structures (perhaps they are too big for stack)? 1b) I utilize similar structures in other tests. Currently, I declare a separate structure for each test? Is it preferable to: i) _declare a separate structure for each test, say: #define MAX_CYLINDER_VERTICES 1000 /* arbitrary */ D3DXVECTOR3 cylinder_test_vertex_data[MAX_CYLINDER_VERTICES]; #define MAX_SPHERE_VERTICES 1000 /* arbitrary */ D3DXVECTOR3 sphere_test_vertex_data[MAX_CYLINDER_VERTICES]; or ii) _declare a common structure for _all_ tests #define MAX_ALL_TEST_VERTICES 1000 /* arbitrary */ D3DXVECTOR3 all_test_vertex_data[MAX_CYLINDER_VERTICES]; and use such a structure in all my tests? 2) Finally, as you have noticed, per Dan's advice, I have implemented this function: /* http://www.cygnus-software.com/papers/comparingfloats/comparingfloats.htm * "I think the answer is 10,000 but since floating point math is imperfect I’ll accept the maxUlps floats above and the maxUlps floats below that value." */ static BOOLEAN AlmostEqual2sComplement(float A, float B, int maxUlps) { int aInt, bInt, intDiff; /* Make sure maxUlps is non-negative and small enough that the * default NAN won't compare as equal to anything. */ assert(maxUlps > 0 && maxUlps < 4 * 1024 * 1024); aInt= *(int*)&A; /* Make aInt lexicographically ordered as a twos-complement int */ if (aInt < 0) aInt = 0x80000000 - aInt; /* Make bInt lexicographically ordered as a twos-complement int */ bInt = *(int*)&B; if (bInt < 0) bInt = 0x80000000 - bInt; intDiff = abs(aInt - bInt); if (intDiff <= maxUlps) return TRUE; return FALSE; } It works very nicely, and is most accurate. However, I have since noticed that mesh.c has the following functions defined: #define admitted_error 0.0001f #define compare_vertex_sizes(type, exp) \ got=D3DXGetFVFVertexSize(type); \ ok(got==exp, "Expected: %d, Got: %d\n", exp, got); static BOOL compare(FLOAT u, FLOAT v) { return (fabs(u-v) < admitted_error); } static BOOL compare_vec3(D3DXVECTOR3 u, D3DXVECTOR3 v) { return ( compare(u.x, v.x) && compare(u.y, v.y) && compare(u.z, v.z) ); } These seem, if anything, much simpler, and, I have noticed in the case of very complicated test data, more accurate. I am going to change my code to use these latter functions, even though they are not technically as good comparators as my current ones. If there are any objections/comments re this, please let me know. Thank you Misha

1 0

WineConf 2010
by Francois Gouget 15 Jul '10

15 Jul '10

Hi, WineConf 2010 is taking shape: the date has been set and we are now in the final stages of picking the venue. The host city: Paris The date: Saturday 20th and Sunday 21st of November So mark the date in your calendar and start booking your plane tickets; this will be the place to be for Wine developers. Note that most further communication will happen on the wineconf(a)winehq.org mailing list so subscribe there to get all the details. You will also find all the details you need as they become available on WineConf 2010's Wiki page: http://wiki.winehq.org/WineConf2010 -- Francois Gouget <fgouget(a)free.fr>

1 0

added some Git morsels
by Misha Koshelev 15 Jul '10

15 Jul '10

Dear All: Hope you are all doing well. Per Dan's suggestions, and since I have been working with GitHub, I have added some morsels to the Wiki page: http://wiki.winehq.org/GitWine * Per Mike Kaplinskiy's great advice, removing trailing whitespace: http://wiki.winehq.org/GitWine * For git-rebase -i, my own caveats about losing patches: http://wiki.winehq.org/GitWine#head-079f5369fdb9346845a4a8c82475eb7a198312be * Finally, a GitHub guide, with some of my own morsels: http://wiki.winehq.org/GitWine#head-0e6d3133a16d3a26de956c500675e5e623462a9e Hopefully this will be useful to future Wine developers. I am coming close to having D3DXCreateCylinder and Sphere working... however, unfortunately the real world calls (apparently my car is declared "totaled" per my insurance company... sigh). In any case, hoping 1.2 is just around the corner. Thank you Misha

1 0

Re: dlls/wined3d/query.c: Use FIXME_ONCE for quieter reports.
by Henri Verbeet 14 Jul '10

14 Jul '10

As others have already pointed out, I don't think so. I'd accept patches replacing existing constructions with FIXME_ONCE though.

1 0

Re: cryptdlg: Add Norwegian Bokmål translation
by Paul Vriens 14 Jul '10

14 Jul '10

On 07/13/2010 01:37 PM, Alexander Nicolaysen Sørnes wrote: > This should bring the Norwegian translation to 100% :D > And indeed it does!! Many thanks for that. -- Cheers, Paul.

1 0

Re: Please remove / block user from bugzilla
by James Mckenzie 14 Jul '10

14 Jul '10

Austin English <austinenglish(a)gmail.com> wrote: >Sent: Jul 13, 2010 10:57 PM >To: Vitaliy Margolen <wine-devel(a)kievinfo.com> >Cc: Wine Develop <wine-devel(a)winehq.org>, matthewdchisholm(a)gmail.com >Subject: Re: Please remove / block user from bugzilla > >On Tue, Jul 13, 2010 at 11:12 PM, Vitaliy Margolen ><wine-devel(a)kievinfo.com> wrote: >> Please remove Matt Chisholm <matthewdchisholm(a)gmail.com> from bugazilla >> and/or block him from posting. Also please remove this post: >> http://bugs.winehq.org/show_bug.cgi?id=6971#c370 >> >> Vitaliy. > >(Repeating my comment from the bug): > >While I agree that comment doesn't belong on this bug, I see no reason >why his account should be removed. A warning is in order, not a ban. > +1. A friendly reminder that bugzilla is for bug reports is in order. BTW, that kind of post is allowed in some project's bug reporting areas. James McKenzie

1 0

Please remove / block user from bugzilla
by Vitaliy Margolen 14 Jul '10

14 Jul '10

Please remove Matt Chisholm <matthewdchisholm(a)gmail.com> from bugazilla and/or block him from posting. Also please remove this post: http://bugs.winehq.org/show_bug.cgi?id=6971#c370 Vitaliy.

2 1

[RFC] gameux.dll partial implementation
by Mariusz Pluciński 13 Jul '10

13 Jul '10

Hi The library I was working on last weeks - gameux.dll - is now partially complete. IGameExplorer and IGameExplorer2 interfaces are working and stores data in Windows-compatible format (attached tests confirm it). Last two interfaces - IGameStatistics and IGameStatisticsMgr has initial work done, but, as their task is only read and save data files, it's not much work to complete them. Please review my code and give some feedback about it. Thanks in advance.

2 4

Re: kernel32: Stubs for GetLogicalProcessorInformation(Ex) (try 2)
by Paul Chitescu 13 Jul '10

13 Jul '10

On Tuesday 13 July 2010 05:52:23 pm Paul Chitescu wrote: > Changelog: > kernel32: Stubs for GetLogicalProcessorInformation(Ex) > > These calls are implemented by XP SP3 or higher. > > This patch allows starting the MTG - Duel of the Planeswalkers demo on Steam > (crashes much later after starting the game on a missing shader or so). > > This version: > - fixed a typo in comments and changelog > "Fixes bug #23392"

1 0

New static analysis tool recommended by Mozilla: sixgill.org
by Scott Ritchie 13 Jul '10

13 Jul '10

I was watching this presentation on Mozilla's static analysis tools: http://www.galois.com/blog/2010/07/09/galois-tech-talk-video-large-scale-st… He is very fond of a new tool made by a recent PHD that was capable of handling Mozilla's massive codebase: sixgill.org I noticed it's not listed at http://wiki.winehq.org/StaticAnalysis, so maybe there's some benefit to using it as well. Thanks, Scott Ritchie

2 2

Re: README: update for 1.2
by Frédéric Delanoy 13 Jul '10

13 Jul '10

In this hunk, - wine notepad.exe /parameter1 -parameter2 parameter3 - (calling program with parameters) + wine notepad.exe readme.txt (calling program with parameters) shouldn't the /parameter1 and -parameter2 remain? i.e. are '/' and '-' interchangeable? Frédéric

3 2

Re: kernel32: Partially update the Dutch translation
by Henri Verbeet 13 Jul '10

13 Jul '10

On 13 July 2010 00:22, Sven Baars <sven.wine(a)gmail.com> wrote: > -Te veel open bestanden > +Teveel open bestanden Actually, I think the original was more correct. AFAIK "teveel" is a noun. > MessageId=102 > SymbolicName=ERROR_SEM_IS_SET > Language=NLD > -Semaphore is set > +Semafoor is een set I guess it depends on the context of the message, but it would make more sense to me if that's the verb "set" instead of the noun. I.e., as in "is in use" instead of "is a set".

2 1

[TRY 2] wined3d/directx.c: Corrected Nvidia 8400 and 8500 reporting
by Seth Shelnutt 13 Jul '10

13 Jul '10

This patches moved the Nvidia 8400 and 8500 reporting to it's own if statement and own return value. This will enable CUDA programs that check the renderer and compare it to a list of cuda capable devices to run on these cards. The 8300, which they currently are reported as, is not a CUDA capable device and thus is the reason for programs such as Folding@Home to fail in wine when using these cards. Thanks, Seth Shelnutt

1 0

wine explorer /desktop=Title,0x0 app.exe for fullscreen?
by Joerg-Cyril.Hoehle＠t-systems.com 13 Jul '10

13 Jul '10

Hi, on MacOS, I've setup winecfg with a default virtual desktop because full screen apps generally don't work. However, all windowing apps (e.g. notepad, regedit) would benefit from not using this desktop window. They nicely open resizable windows when run in full screen. The FAQ recommends wine explorer /desktop=Title,800x600 for running apps inside windows when fullscreen is the default setting. What I need is the exact opposite. Looking at the source, I found out that the converse works using wine explorer /desktop=Title,0x0 regedit.exe opens a regedit window without a virtual desktop one. Can that behaviour be blessed officially and documented? Or is it accidental? Regards, Jörg Höhle

4 4

Re: shlwapi/tests: Fix GLE for SHFormatDateTimeA
by testbot＠testbot.winehq.org 13 Jul '10

13 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3297 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:593: Test failed: GetShellSecurityDescriptor should fail ordinal.c:616: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1766: Test failed: got 26 ordinal.c:1816: Test failed: got 26 ordinal.c:1824: Test failed: got 26 ordinal.c:1832: Test failed: got 37, length 38 ordinal.c:1843: Test failed: got 40 === W7PROX64 (32 bit ordinal) === ordinal.c:1760: Test failed: got 9 ordinal.c:1781: Test failed: got 6 ordinal.c:1794: Test failed: got 9 ordinal.c:1802: Test failed: got 9 ordinal.c:1832: Test failed: got 32, length 33 ordinal.c:1843: Test failed: got 35 ordinal.c:1854: Test failed: got 19 ordinal.c:1865: Test failed: got 22

1 0

Having some trouble implementing D3DXComputeNormals... any hints/advice?
by Misha Koshelev 12 Jul '10

12 Jul '10

Dear All: Hope you are having a nice Sunday. I have decided that, as all the D3DXCreate... functions return vertex normals in addition to vertices themselves, it is more efficient to implement D3DXComputeNormals and use this function rather than calculate normals individually for each shape (or create an internal function that does the same thing). As you can see from this patch: http://github.com/misha680/wine/commit/0e975e7360f403eb123055b6ff996137e0b2… the normals computed by D3DXComputeNormals are almost equal to those originally returned by D3DXCreateCylinder for complex enough values of the radii, length, slices, and stacks (these values are within 10^-6 of each other). I have taken the following description from MSDN: "A normal for a vertex is generated by averaging the normals of all faces that share that vertex. If adjacency is provided, replicated vertices are ignored and 'smoothed' over. If adjacency is not provided, replicated vertices will have normals averaged in from only the faces explicitly referencing them." and implemented it in a test case (attached - code, compilation script, and compiled executable via MingW). For a very simplified cylinder (radii 1.0f, length 0.0f, 3 slices, 2 stacks) all seems well, and my normals match perfectly to those created by D3DXComputeNormals. However, for a more complicated case: static const FLOAT radius = 1.0f; static const FLOAT length = 1.0f; static const UINT slices = 10; static const UINT stacks = 20; You can see something quite perplexing. Specifically, below you can see all 3 triangles that contain vertex #11 (11, 21, and 12 are vertex indices, below you will see the actual vertex X,Y,Z values, and finally the computed normal for the specific triangle). Below, you can see under "Averaged Normals", first the normal computed by averaging and normalizing the normals for each of the triangles, and then the original normal computed by D3DXComputeNormals. Notice that they are quite (significantly) different. This does not happen for a lot of vertices, but for quite a few (say 5-10%). Index Buffer: 11,21,12, {0,1,-0.5}, {0,1,-0.45}, {0.587785,0.809017,-0.5}, {0.00954915,0.0293893,0}, 20,30,11, {-0.587785,0.809017,-0.5}, {-0.587785,0.809017,-0.45}, {0,1,-0.5}, {-0.00954915,0.0293893,0}, 11,30,21, {0,1,-0.5}, {-0.587785,0.809017,-0.45}, {0,1,-0.45}, {-0.00954915,0.0293893,0}, Averaged Normals: 11 {-0.107677,0.994186,0} {-1.99491e-008,1,0}, I have used the equivalent statement for D3DXComputeNormals: if (!SUCCEEDED(D3DXComputeTangentFrameEx(mesh, D3DX_DEFAULT, 0, D3DX_DEFAULT, 0, D3DX_DEFAULT, 0, D3DDECLUSAGE_NORMAL, 0, D3DXTANGENT_GENERATE_IN_PLACE | D3DXTANGENT_CALCULATE_NORMALS, NULL, -1.01f, -0.01f, -1.01f, NULL, NULL))) and tried to vary the parameters listed below, but honestly am a bit stumped... I will investigate further, but if perhaps I am missing something simple, would be great to know! Thanks Misha p.s. Fyi these are the relevant parameters for D3DXComputeTangentFrameEx from http://msdn.microsoft.com/en-us/library/bb172745%28v=VS.85%29.aspx Thank you! Misha fPartialEdgeThreshold [in] FLOAT Specifies the maximum cosine of the angle at which two partial derivatives are deemed to be incompatible with each other. If the dot product of the direction of the two partial derivatives in adjacent triangles is less than or equal to this threshold, then the vertices shared between these triangles will be split. fSingularPointThreshold [in] FLOAT Specifies the maximum magnitude of a partial derivative at which a vertex will be deemed singular. As multiple triangles are incident on a point that have nearby tangent frames, but altogether cancel each other out (such as at the top of a sphere), the magnitude of the partial derivative will decrease. If the magnitude is less than or equal to this threshold, then the vertex will be split for every triangle that contains it. fNormalEdgeThreshold [in] FLOAT Similar to fPartialEdgeThreshold, specifies the maximum cosine of the angle between two normals that is a threshold beyond which vertices shared between triangles will be split. If the dot product of the two normals is less than the threshold, the shared vertices will be split, forming a hard edge between neighboring triangles. If the dot product is more than the threshold, neighboring triangles will have their normals interpolated.

2 5

xrender.c is does not find fontconfig.h on OS X Tiger
by Mike Kronenberg 12 Jul '10

12 Jul '10

Dear List OS X Tiger does has not have fontconfig, so I'm building it in ~/buildwine/usr to keep it out of /usr. I include the headers and libs from ~/buildwine/usr with CPPFLAGS and CFLAGS. This worked fine until 1.2-rc1 and 1.2-rc2. Compiling xrender.c now exits with an error that FC_WEIGHT_THIN etc is not defined. configure leaves me with SONAME_LIBFONTCONFIG='libfontconfig.1.dylib' FONTCONFIGINCL='' in the config.log. No luck even if I export FONTCONFIGINCL="-I//$HOME/buildwine/usr/include/fontconfig -I//$HOME/buildwine/usr/include' which resulted in a correct FONTCONFIGINCL, but the compiling still failed. All the other custom compiled deps are working as usual. Any hint what I might missing? txs Mike

2 2

Re: wined3d/directx.c: Corrected Nvidia 8400 and 8500 reporting
by Roderick Colenbrander 12 Jul '10

12 Jul '10

Hi Seth, It is not a good idea to advertise a 8400 and a 8500 as a 8600GT. All Geforce8 GPUs have the same features (except, some have different purevideo capabilities). As mentioned before even CUDA is allowed on all GPUs but only if they have 256MB or more. Likely the app you are using either disallows this GPU based on the wrong number of video memory Wine reports or it just disallows poor GPUs because it is not worth the effort to use them for CUDA computations because they don't have enough computation power. The Geforce 8600GT is (depending on the configuration) upto 4x faster (if you just look at shaders + clock speeds), so it is really not a good idea to mark the 8400/8500 as a 8600GT. This could really cause issues for games which use the PCI id to select a performance profile at startup. It would be better to add a separate 8500GT entry with 256MB. I'm not sure if we want to merge it with the 8400 though since the 8500 has 256-1024 (depending on the model) and the 8400 has 128-512MB. A lot of modern games like to have around 256MB. I guess it is best to keep the 8400 tied to the 8300. Roderick On Sun, Jul 11, 2010 at 7:04 PM, Seth Shelnutt <shelnutt2(a)gmail.com> wrote: > Moves the Nvidia Geforce 8400 and 8500 to be reported as 8600GT as they have > feature parity. This is needed for CUDA applications to support these two > cards. They are currently reported as an 8300 which is not CUDA capable. > > Thanks, > > Seth Shelnutt > > > >

2 2

Old documentation changelogs to be kept?
by Frédéric Delanoy 12 Jul '10

12 Jul '10

In the documentation directory, there are ChangeLog.ALPHA, ChangeLog.BETA and ChangeLog.OLD. Are these files still useful (most recent entry is dated 2008-06-16)? Or are they simply kept as a log of the good old pre-git days? Frédéric

1 0

Manifests, Microsoft.VC90.CRT and vc_redist
by Peter Urbanec 12 Jul '10

12 Jul '10

I'm trying to get my head around the mess generated by SxS, isolated apps, embedded manifests, local deployment and all the other "solutions" to DLL hell. It's hard enough to make it work on Windows, but making it work well under wine is another challenge. In a nutshell, I'd like to ship a custom wine64 RPM package that can co-exist with distribution provided wine32 RPMs. I also want to make a couple of companion RPMs, which provide x64 apps that depend on my wine64 RPM. I don't want to require an installation of the x64 packages under Wine. i.e. I want to avoid the requirement to run vcredist_x64.exe for each user. The most obvious solution to this seems to be to include the DLLs from "Microsoft Visual Studio 9.0\VC\redist\amd64\Microsoft.VC90.CRT" in the same dir as the x64 application executable, known as "application local deployment". Now, this is where I get confused. The VC redist files provide DLLs with version 9.0.30729.1, whereas the manifest embedded in the application has version 9.0.21022.8. When the 9.0.30729.1 VC redist files are installed in the windows dir, the associated policies will redirect requests for 9.0.21022.8 to use 9.0.30729.1, but this does not seem to work when the DLLs are deployed in the app directory. Wine itself provides msvcr90.dll.so, which as far as I can tell doesn't play the manifest games or provide any particular version number. Should I be using msvcr90.dll from VC redist? Should I be using msvcr90.dll.so provided by wine? If so, how do I tell wine to ignore manifests and just load the DLLs found in the app dir? Thanks for any insights you could provide.

3 3

Re: [PATCH 2/2] uninstaller: Update the Czech translation.
by Michael Stefaniuc 12 Jul '10

12 Jul '10

Forgot to remove the "[PATCH 2/2]". There is no dependency for this patch. bye michael Michael Stefaniuc wrote: > Translation by Radek Vokal. > --- > programs/uninstaller/Cs.rc | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/programs/uninstaller/Cs.rc b/programs/uninstaller/Cs.rc > index ed73cd3..f6ee8cc 100644 > --- a/programs/uninstaller/Cs.rc > +++ b/programs/uninstaller/Cs.rc > @@ -1,5 +1,4 @@ > -/* Hey, Emacs, open this file with -*- coding: cp1250 -*- > - * > +/* > * Uninstaller (Czech Resources) > * > * > @@ -22,9 +21,9 @@ > > LANGUAGE LANG_CZECH, SUBLANG_NEUTRAL > > -/* Czech strings in CP1250 */ > - > +#pragma code_page(65001) > > STRINGTABLE DISCARDABLE { > - IDS_APPNAME, "Deinstalátor" > + IDS_APPNAME, "DeinstalÃ¡tor" > + IDS_UNINSTALLFAILED, "SpuÅ¡tÄ›nÃ pÅ™Ãkazu %s selhalo, moÅ¾nÃ¡ pÅ™ÃÄÃna je chybÄ›jÃcÃ aplikace.\nPÅ™ejete si odstranit instalaÄnÃ zÃ¡znam z registru?" > }

1 0

Re: user32: Add a test showing that SetForegroundWindow() on a visible child of invisible parent does activate the parent an
by testbot＠testbot.winehq.org 12 Jul '10

12 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3291 Your paranoid android. === W98SE (32 bit win) === win.c:2950: Test failed: hwnd 000004C4 message 0112 win.c:2952: Test failed: message 0112 available win.c:2959: Test failed: hwnd 000004C4 message 0100 win.c:2961: Test failed: message 0100 available win.c:2973: Test failed: message 000f available win.c:2985: Test failed: message 000f available win.c:2994: Test failed: message 000f available win.c:3003: Test failed: message 000f available === W2KPROSP4 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000900A6 fg 000600AE in hook HCBT_SETFOCUS === WXPPROSP3 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000700F0 fg 000A0148 in hook HCBT_SETFOCUS === W2K3R2SESP2 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000500D8 fg 000B00BE in hook HCBT_SETFOCUS === WVISTAADM (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000D0108 fg 000E0106 in hook HCBT_SETFOCUS === W2K8SE (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000500FE fg 00040152 in hook HCBT_SETFOCUS === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0005015A fg 00090132 in hook HCBT_SETFOCUS === W7PROX64 (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0005016E fg 000401B0 in hook HCBT_SETFOCUS === W7PROX64 (64 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0000000000050170 fg 00000000000301B0 in hook HCBT_SETFOCUS

1 0

Re: user32: Make sure that main window state is consistent during the tests.
by testbot＠testbot.winehq.org 12 Jul '10

12 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3290 Your paranoid android. === W98SE (32 bit win) === Timeout === WVISTAADM (32 bit win) === win.c:2271: Test failed: 000F0200: expected prev 000D01D8, got 003301D2 win.c:2272: Test failed: 000D01D8: expected next 000F0200, got 003301D2 win.c:2198: Test failed: 00BF01D0: expected next 00040208, got 000E01E0 win.c:2271: Test failed: 003401D2: expected prev 00110200, got 000F01E0 win.c:2272: Test failed: 00110200: expected next 003401D2, got 000F01E0 === W2K8SE (32 bit win) === win.c:2271: Test failed: 000E0110: expected prev 000B0116, got 009000FC win.c:2272: Test failed: 000B0116: expected next 000E0110, got 009000FC win.c:2198: Test failed: 0052010E: expected next 000500F4, got 000C0114 win.c:2271: Test failed: 009100FC: expected prev 00100110, got 000D0114 win.c:2272: Test failed: 00100110: expected next 009100FC, got 000D0114

2 1

Re: winhlp32: Remove an untranslated resource from multiple translations.
by Dmitry Timoshkov 12 Jul '10

12 Jul '10

Michael Stefaniuc <mstefani(a)redhat.de> wrote: > This affects the Bg, Cs, Da, Eo, Fi, Hu, Sk, Tr and Wa translations. It's better to have it, even not translated. String resources should be fully filled up. Why do remove this one and leave the others? -- Dmitry.

2 1

Request: please add your expertise to the release announcement!
by Scott Ritchie 12 Jul '10

12 Jul '10

Alexandre has said -rc7 is likely to be the last rc before release, which means we're quickly running out of time to get a good release announcement. Please add whatever you think might be interesting to the wiki page. It's ok if it's not a complete sentence at this point, I can clean that stuff up myself -- what the page really needs is content. http://wiki.winehq.org/Wine1.2Announcement In particular, we need examples of new platinum-quality apps and new neat technical features you're proud of. Thanks, Scott Ritchie

2 1

Re: List of Video cards in directx.c
by Seth Shelnutt 12 Jul '10

12 Jul '10

On Sun, Jul 11, 2010 at 4:21 PM, Roderick Colenbrander < thunderbird2k(a)gmail.com> wrote: > > The PCI id is something else. For instance run 'lspci -x': > 01:00.1 Audio device: ATI Technologies Inc RV620 Audio device [Radeon > HD 34xx Series] > 00: 02 10 28 aa 07 01 10 40 00 00 03 04 10 00 80 00 > .. > > This line shows a part of the PCI configuration header. The first two > bytes contain the PCI vendor id (0x1002 = ATI; you have to swap the > bytes) and byte 3 and 4 contain the PCI device id (0xaa28 = radeon > 3450). Each device has such information and it is used by the > operating system to detect which hardware is around. > > A lot of games use the PCI id, since it can be easier to parse than > the renderer strings. > > That makes sense. I had based my thinking on the following comment, A Direct3D device object contains the PCI id (vendor + device) of the videocard which is used for rendering. I had assumed vendor + device meant the strings. > We have to keep the current static database. Extending it with video > memory reporting is likely the best way to go. So now and then it just > means that we have to refine it a little. > > Roderick > Thinking things over I think you are right. Trying to add any kind of dynamic support at this stage is not worth it. Even the memory reporting is very recent and new. Maybe in a couple years more support will have materialized from opengl or the drivers to help with this issue. For now though I just submitted a patch to deal with the issue of a 8500/8400 being reported as a 8300. I moved the detection to be reported as an 8600. I thought about creating a new 8500 in the database but I realized that an 8600 is of feature parity and has the same video memory minimum. Thanks, Seth Shelnutt

1 0

Re: shlwapi: Partially implement SHGetShellKey (try5)
by testbot＠testbot.winehq.org 11 Jul '10

11 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3283 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1761: Test failed: got 13 ordinal.c:1782: Test failed: got 10 ordinal.c:1795: Test failed: got 13 ordinal.c:1803: Test failed: got 13 ordinal.c:1833: Test failed: got 37, length 38 ordinal.c:1844: Test failed: got 40 ordinal.c:1855: Test failed: got 23 ordinal.c:1866: Test failed: got 26 === W7PROX64 (32 bit ordinal) === ordinal.c:1774: Test failed: got 12 ordinal.c:1810: Test failed: got 12 ordinal.c:1855: Test failed: got 20 ordinal.c:1866: Test failed: got 23 === W7PROX64 (64 bit ordinal) === ordinal.c:1761: Test failed: got 10 ordinal.c:1767: Test failed: got 23 ordinal.c:1782: Test failed: got 7 ordinal.c:1795: Test failed: got 10 ordinal.c:1803: Test failed: got 10 ordinal.c:1817: Test failed: got 23 ordinal.c:1825: Test failed: got 23 ordinal.c:1833: Test failed: got 32, length 33 ordinal.c:1844: Test failed: got 35 ordinal.c:1855: Test failed: got 20 ordinal.c:1866: Test failed: got 23

1 0

List of Video cards in directx.c
by Seth Shelnutt 11 Jul '10

11 Jul '10

I'm not sure if this is appropriate for a code freeze or not but I think it is. We just ran into an issue with the folding gpu client in wine with someone. Turns out it's because wine reports the card as a 8300 not an 8500. Looking at directx.c I see that that is probably because an 8500 is not listed. I've got a patch to add the single line for 8500 but I was wondering, would it not be beneficial to add a list of all graphic cards dating back to a certain point? There are even less ATI cards listed than Nvidia. All that is required is going to say wikipedia or Nvidia/Ati.com and just go through the list of the cards. Thanks, Seth Shelnutt

5 6

sorry one more question: assert statements in tests
by Misha Koshelev 10 Jul '10

10 Jul '10

I am implementing my tests as follows: * patch 1: general test for a D3DX function (D3DXCreateBox for example, testing specific vertices and indices for _specific_ dimensions). * patch 2: separate into function that works with arbitrary dimensions for the box, etc. I restrict to the dimensions from patch 1 using assert statements. * patch 3: expand to allow arbitrary parameters to the function, e.g., arbitrary dimensions, removing the assert statements. For example, see patch 2 = http://github.com/misha680/wine/commit/6291ca28593c78761ccef3137b1014bae87d… patch 3 = http://github.com/misha680/wine/commit/7b09cfb661bf1d03fd80195c0cd2b7b3bb9f… Is assert the right way to do this? If not, what is? Thank you Misha

2 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel