- wine-devel - winehq.org

Re: winex11.drv: warn and return when UploadGlyph fails in X11DRV_XRender_ExtTextOut
by Alexandre Julliard 22 Jun '10

22 Jun '10

Aric Stewart <aric(a)codeweavers.com> writes: > commit 082bc5ccbcc35e2058f1a3cd5c52345edf760631 > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Tue Jun 22 16:58:38 2010 +0900 > > winex11.drv: warn and return when UploadGlyph fails in X11DRV_XRender_ExtTextOut > > this prevents crashing later when we are assuming that all the glyphs in the string have been realized and have valid data. Missing glyphs should be replaced by the font default char or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Allow HTTPREQ_ReadFileEx read more then one data chunk
by Alexandre Julliard 22 Jun '10

22 Jun '10

Piotr Caban <piotr(a)codeweavers.com> writes: > + read = 0; > + size = buffers->dwBufferLength; > + > + EnterCriticalSection( &req->read_section ); > + while(1) { > + res = HTTPREQ_Read(req, (char*)buffers->lpvBuffer+read, size-read, > + &buffers->dwBufferLength, !(flags & IRF_NO_WAIT)); > + if(res == ERROR_SUCCESS) > + read += buffers->dwBufferLength; > + else > + break; > + > + if(!req->read_chunked || read==size || req->dwContentLength!=req->dwContentRead > + || !req->dwContentLength || (req->gzip_stream && req->gzip_stream->end_of_data)) > + break; > + > + INTERNET_SendCallback(&req->hdr, req->hdr.dwContext, INTERNET_STATUS_RESPONSE_RECEIVED, > + &buffers->dwBufferLength, sizeof(buffers->dwBufferLength)); > + INTERNET_SendCallback(&req->hdr, req->hdr.dwContext, > + INTERNET_STATUS_RECEIVING_RESPONSE, NULL, 0); Calling the callbacks while holding the critical section is not a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ddraw: Grow indexbuffer as needed
by Henri Verbeet 22 Jun '10

22 Jun '10

On 22 June 2010 09:15, Mikko Rasa <tdb(a)tdb.fi> wrote: > --- > dlls/ddraw/device.c | 27 ++++++++++++++++++++++++++- > 1 files changed, 26 insertions(+), 1 deletions(-) > This looks mostly ok, except for two things: - We'll probably want to grow the buffer by doubling the size until it's large enough (but be careful not to overflow the maximum value of an UINT) - The "child" pointer of "parent" will still be set to the old index buffer, so the relevant code in IDirect3DDeviceImpl_7_Release() / IParentImpl_Release() is going to try to release the old index buffer again.

1 0

damnit, X is crashing *every* time I run 3dmark2000
by Dan Kegel 22 Jun '10

22 Jun '10

And always after test 17 of 20, I think. I updated to the latest nvidia driver supported by Ubuntu 10.04, no change. The crash persists even with WINEDEBUG=+d3d,+d3d7,+synchronous. I guess my next move is to drop 3dmark2000.

4 4

Re: winecfg: Update Portuguese translation
by Frédéric Delanoy 22 Jun '10

22 Jun '10

2010/6/22 Gustavo <gugamilare(a)gmail.com> > Second try. > > Gustavo Henrique Milaré > gugamilare(a)gmail.com If you resend the same patch, append (resend), if it was changed, append (try N). Cf. http://wiki.winehq.org/SubmittingPatches#head-2753aa29adcd5dfc10a88d4370973… Frédéric Delanoy

1 0

Re: Patches for Hebrew and Arabic
by Austin English 21 Jun '10

21 Jun '10

On Mon, Jun 21, 2010 at 4:00 PM, Yaron Shahrabani <sh.yaron(a)gmail.com> wrote: > > Yaron Shahrabani There's a few problems... A) Please send one patch per email. B) The patches are incorrect: 0002-Arabic-Patch.patch: --- programs/notepad/Makefile.in | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/programs/notepad/Makefile.in b/programs/notepad/Makefile.in index 6b1fcdd..a0598e7 100644 --- a/programs/notepad/Makefile.in +++ b/programs/notepad/Makefile.in @@ -24,7 +24,6 @@ RC_SRCS = \ Es.rc \ Fi.rc \ Fr.rc \ - He.rc Hu.rc \ It.rc \ Ja.rc \ -- 1.7.0.4 You're removing the Hebrew rc file, but nothing else. 0003-Hebrew-Patch.patch: --- programs/notepad/Makefile.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/notepad/Makefile.in b/programs/notepad/Makefile.in index a0598e7..372390e 100644 --- a/programs/notepad/Makefile.in +++ b/programs/notepad/Makefile.in @@ -14,7 +14,6 @@ C_SRCS = \ main.c RC_SRCS = \ - Ar.rc \ Bg.rc \ Cs.rc \ Da.rc \ @@ -24,6 +23,7 @@ RC_SRCS = \ Es.rc \ Fi.rc \ Fr.rc \ + He.rc \ Hu.rc \ It.rc \ Ja.rc \ -- 1.7.0.4 You're adding Hebrew back and removing Arabic. Neither patch actually adds a translation. You probably forgot to use 'git add' to tell git to add the file in your commit. You should also use a more helpful commit message. For example: notepad: add Hebrew translation Thanks for helping Wine! -- -Austin

1 0

Re: kernel32: Fix test output
by testbot＠testbot.winehq.org 21 Jun '10

21 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2813 Your paranoid android. === W7PRO (32 bit thread) === thread.c:443: Test failed: threadFunc2 did not exit during 100 ms === W7PROX64 (64 bit thread) === thread.c:1394: Test failed: Expected FPU control word 0x27f, got 0x37f.

1 0

Re: [APPDB] Updated test_appData
by Alexander Nicolaysen Sørnes 21 Jun '10

21 Jun '10

Mandag 21. juni 2010 20.52.20 skrev Alexandru Băluț : > Updated test_appData, because using downloadurl objects does not work > anymore, because appData.listSubmittedBy() ignores queued downloadurls. > I also fixed a bug in url.php: after creating an Url, the create function > does not update the object properly. > Hello, It's great that you're submitting patches! You could split this patch in two, since it contains two separate changes. Also, I see that you're using GIT to generate the patches. Could you do that with 'git format-patch -o out' and send the files generated in out/? Alexander N. Sørnes

2 2

Fwd: Italian translation of Wine at 100%
by Luca Bennati 21 Jun '10

21 Jun '10

---------- Forwarded message ---------- From: Luca Bennati <lucak3(a)gmail.com> Date: 2010/6/21 Subject: Re: Italian translation of Wine at 100% To: Paul Vriens <paul.vriens.wine(a)gmail.com> 2010/6/21 Paul Vriens <paul.vriens.wine(a)gmail.com> Hi, > > And another one at a 100% !!! > > Many thanks to Luca for his efforts to get us this far. > > -- > Cheers, > > Paul. > Having completed this target before 1.2 release, i'm very happy, but surely the best is that now it won't be as strenous to keep it up to date. :) good luck to all the others translators.

1 0

Italian translation of Wine at 100%
by Paul Vriens 21 Jun '10

21 Jun '10

Hi, And another one at a 100% !!! Many thanks to Luca for his efforts to get us this far. -- Cheers, Paul.

1 0

Re: Richedit: Initial tests for EM_FINDWORDBREAK
by testbot＠testbot.winehq.org 21 Jun '10

21 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2806 Your paranoid android. === W7PRO (32 bit editor) === editor.c:4696: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4714: Test failed: test paste: strcmp = 1 editor.c:4726: Test failed: test paste: strcmp = -1 editor.c:4756: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5971: Test failed: Cursor is at 0 instead of 4 editor.c:5977: Test failed: Cursor is at 0 instead of 9 editor.c:5983: Test failed: Cursor is at 0 instead of 4 editor.c:5997: Test failed: Cursor is at 8 instead of 9 editor.c:6005: Test failed: Cursor is at 11 instead of 9 editor.c:6016: Test failed: Cursor is at 0 instead of 8 editor.c:6041: Test failed: Cursor is at 0 instead of 8

2 1

Re: [2/2] kernel32/tests: add test for CT_TYPE1 of GetStringTypeW
by James McKenzie 21 Jun '10

21 Jun '10

Aric Stewart wrote: > ------------------------------------------------------------------------ > > Aric: Where did you find the new values for C1_TYPE? James McKenzie

2 1

Re: ntdll: fix race in NtRead/WriteFile
by Eric Pouech 21 Jun '10

21 Jun '10

why not simply setting send_completion to cvalue instead of TRUE, and remove the now unneeded test to cvalue ? - send_completion = TRUE; + send_completion = cvalue != 0; .... - if (send_completion && cvalue) .... + if (send_completion) .... A+ 2010/6/21 Andrey Turkin <andrey.turkin(a)gmail.com> > Long overdue patch to fix bug 11188 - make sure to send i/o completions > after all interactions with i/o status block are performed. > --- > dlls/ntdll/file.c | 24 ++++++++++++++++++++---- > 1 files changed, 20 insertions(+), 4 deletions(-) > > > > > -- -- Eric Pouech

1 0

Is the appData table still holding bug links?
by Alexandru Băluț 21 Jun '10

21 Jun '10

Hi, I see the "type" column in the appData table is an enum('screenshot','url','bug','downloadurl'), and I noticed that when linking a bug to a Version, a row is added in the buglinks table, not in appData. Is it ok to change the type of that column to enum('screenshot','url','downloadurl') - or shall I add a comment and say that it's obsolete, and that buglinks should be used instead? Thanks, Alex

1 0

Speed/latency issues for development in a Wine environment
by Alan W. Irwin 21 Jun '10

21 Jun '10

To introduce myself to this list, I am a complete Wine newbie with no Windows experience at all, but I do have years of experience developing software on Linux, and in the interests of testing that software on a free Windows platform, I have recently been using the combination of Windows native versions of MinGW and CMake to build and test applications and libraries under Wine. That is, I run a Windows version of cmake under wine to configure Makefiles followed by running a Windows version of MinGW make under Wine (which in turn runs MinGW gcc and other applications under Wine to build and test the software). So far this idea is going rather well, but I have run into some issues which I have been reporting on the wine-users mailing list. I find such preliminary discussion useful to help prepare a good bug report, but following a suggestion from Alexandre Julliard, I am moving the discussion of these issues here. Since at least some of you have already seen my posts on wine-users, I will only summarize the issues as I currently see them. The rest of this post concerns a slow software build issue I have discovered under Wine, and I will deal with a second issue in a later post. The issue is that Wine builds of software take roughly a factor of 5 longer than the equivalent Linux builds. This issue appears to be caused mostly by command startup latency. What I mean by that phrase is wine cmake --version (and the "--version" option for many commands you can run under wine) take roughly 150 ms (with wine-1.2-rc3 built with the -O3 option and running that wine version with WINEDEBUG='-all' and wineserver -p) to complete while Linux versions of the same commands require 1 ms to complete. It is a startup latency in the commands run under wine rather than a startup latency issue with the wine command itself because that command returns much faster than 150 ms if you give it an unknown command. Because many thousands of commands (e.g., "gcc"; several "cmake -E" variants per gcc command to help report progress; figure out dependencies, etc.; and various further make commands generated by the initial make command) are used to complete a typical build (say of cmake itself or PLplot), the startup latency for each of those commands accumulates and is a major factor which slows down the build (by roughly a factor of 5) compared to the equivalent Linux build. So a reduction of the command startup latency under Wine by an order of magnitude should largely solve the problem. I find the command startup latency depends very much on what X server I am using. Of course, the actual commands I am using (cmake, MinGW make, MinGW gcc, etc.) to build software under wine have nothing to do with X. So I am hoping if I build a stripped down version of wine configured to ignore X and all other systems (sound, etc.) that are not required for builds, then I might achieve the reduced command startup latency that I need. Before I try that, however, is there some less brute-force way to reduce command startup latency? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ---------- Forwarded message ---------- Date: Sat, 12 Jun 2010 14:10:31 -0700 (PDT) From: Alan W. Irwin <irwin(a)beluga.phys.uvic.ca> To: wine-users(a)winehq.org Subject: Re: [Wine] Speed/latency issues for development in a Wine environment On 2010-06-11 18:09-0700 Alan W. Irwin wrote: The previous timing numbers were done with wine-1.1.42. Following a suggestion made off-list to me, I have built wine-1.2-rc3 today (with CFLAG=-O3) and immediately noticed the start-up latency for simple commands (e.g., cmake --version) was reduced from about 0.25 s to about 0.15 s. I don't know how the previous Debian wine-1.1.42 packages were optimized so that difference may just be due to an optimization difference or an actual improvement in the Wine code from 1.1.42 to 1.2-rc3. However, to see how -O3 optimized wine-1.2-rc3 does with the full tests, I have redone my timing tests for I. (cmake), II (make install), and III (make install latency) and the following reductions have been observed. > Wine I. > wine@raven> time wine cmake -G "MinGW Makefiles" \ > "-DCMAKE_INSTALL_PREFIX=z:/home/wine/cmake/install1" \ > z:/home/software/cmake/cmake-2.8.1_patched/ >& cmake.out > > real 14m17.124s ==> real 8m18.041s > Wine II. > > wine@raven> time wine mingw32-make install >& make_install.out > > real 20m13.421s ==> real 12m4.198s > Wine III. > wine@raven> time wine mingw32-make install >& make_install.out1 > > real 1m39.018s ==> real 0m51.045s For reference here are the corresponding Linux numbers which are still much better than the corresponding Wine-1.2-rc3 results. > Linux I. > > wine@raven> time cmake -G "Unix Makefiles" \ > "-DCMAKE_INSTALL_PREFIX=/home/wine/cmake/install_linux" \ > /home/software/cmake/cmake-2.8.1_patched/ >& cmake.out > > real 0m34.015s > Linux II. > > wine@raven> time make install >& make_install.out > > real 2m12.805s > Linux III. > > wine@raven> time make install >& make_install.out1 > > real 0m0.869s To summarize these findings, it appears that changes in startup latency for simple commands strongly correlates with timing results for build steps I, II, and III on Wine. This makes sense since we know that several thousand commands are run for, e.g., build step II so startup latency of hundreds of milliseconds per command must be a real build performance killer. So what can be done to reduce the simple startup latency from the current ~150 ms on Wine down much closer to the Linux startup latency for the same commands which is typically 1 ms? Simple commands requiring 150 ms to start must have an awful lot of extra start baggage. Is all that baggage really needed for command-line commands such as cmake, mingw32-make, gcc, etc.? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

5 10

RFC: Patch to add EM_FINDWORDBREAK tests
by James McKenzie 21 Jun '10

21 Jun '10

All: While working on a problem with The Sword (a bible program), I noticed that an empty yellow box kept appearing. I then ran the program from the terminal and up popped what looked like a never ending stream of EM_FINDWORDBREAK stub entries. A further investigation (with Google's help) reveals that Brian Chang submitted implementation of this function with tests. I then found Dan's reply that one of the tests needed. I attempted to add this test and am requesting assistance, and if possible crosstest file so I can run it on XP. Thank you. James McKenzie

1 0

*_queue.php files in AppDB
by Alexandru Băluț 20 Jun '10

20 Jun '10

Hi, Why exactly are these AppDB files needed? ./include/testData_queue.php ./include/version_queue.php ./include/application_queue.php Thanks, Alex

2 1

Re: richedit: Add WB_ISDELIMITER value to richedit.h
by Dylan Smith 20 Jun '10

20 Jun '10

On Sun, Jun 20, 2010 at 6:00 PM, James McKenzie <jjmckenzie51(a)earthlink.net>wrote: > While looking for implementation guidance at google.com, came across the > value for WB_ISDELIMITER which was not in richedit.h. This patch adds this > value which will be necessary for full implementation of this function. > > WB_LEFT, WB_RIGHT, and WB_ISDELIMITER are defined in winuser.h because they are used by the normal edit control. The other WB_* constants are used by the richedit control, so are defined in richedit.h. Just include winuser.h.

2 1

Help wanted for bug#3023
by Eliot Blennerhassett 20 Jun '10

20 Jun '10

Greetings, I'm hoping to get some with disposing of http://bugs.winehq.org/show_bug.cgi?id=3023 Short summary: Commenting line 934 of dlls/user32/dialog.c in EndDialog makes OrCad (electronic schematic cad package) usable (otherwise several essential functions don't work) EndDialog( HWND hwnd, INT_PTR retval ) { ... // comment the following line if (hwnd == GetActiveWindow()) WINPOS_ActivateOtherWindow( hwnd ); ... } MSDN says "HWND A handle to the dialog box to be destroyed. Dialog boxes created by the DialogBox, DialogBoxParam, DialogBoxIndirect, and DialogBoxIndirectParam functions must be destroyed using the EndDialog function. An application calls EndDialog from within the dialog box procedure; the function must not be used for any other purpose. " Now, can anybody explain what the purpose of the suspect line is? or what possible bad things might happen if it was removed? I have run Wine for several years with this one line patch, and seen no ill effects AFAIK. If removing the line completely is not an option, is there a way to conditinally avoid executing it based on environment or registry? eg if (!ALLOW_ORCAD_TO_WORK) { original code } thanks -- Eliot Blennerhassett 5 years of recompiling wine from source with a 1 line patch...

1 0

Help wanted re Bugzilla#3023 (one line fix for Orcad add new elements)
by Eliot Blennerhassett 20 Jun '10

20 Jun '10

Greetings, Help wanted Re: http://bugs.winehq.org/show_bug.cgi?id=3023 Short summary: Commenting line 934 of dlls/user32/dialog.c in EndDialog makes OrCad usable. EndDialog( HWND hwnd, INT_PTR retval ) { ... // comment the following line if (hwnd == GetActiveWindow()) WINPOS_ActivateOtherWindow( hwnd ); ... } MSDN says "HWND A handle to the dialog box to be destroyed. Dialog boxes created by the DialogBox, DialogBoxParam, DialogBoxIndirect, and DialogBoxIndirectParam functions must be destroyed using the EndDialog function. An application calls EndDialog from within the dialog box procedure; the function must not be used for any other purpose. " Now, can anybody explain what the purpose of the suspect line is? or what possible bad things might happen if it was removed. I have run Wine for several years with this one line patch, and seen no ill effects AFAIK. If removing the line completely is not an option, is there a way to conditinally avoid executing it based on environment or registry? eg if (!ALLOW_ORCAD_TO_WORK) { original code } thanks -- Eliot Blennerhassett

1 0

WineSkin v0.01
by Joel Holdsworth 20 Jun '10

20 Jun '10

Hi All, I just wanted to highlight my new project - WineSkin http://www.airwebreathe.org.uk/wineskin/ WineSkin is an attempt to create a set of scripts that auto-generate the necessary themes, visual styles and registry keys to visually integrate wine with the host desktop environment. At the moment I only support integrating 5 icons with the host, when the DE is Gnome. I'm hoping that the project will grow and eventually I'll be able to integrate with KDE and MacOS. For now I'm just focussing on trying to get any kind of good integration going. If anyone has any thoughts or comments, let me know; I'd love to hear them. All the best Joel

4 3

New flags in LoadLibraryEx
by Mariusz Pluciński 20 Jun '10

20 Jun '10

Hello, wine-devel It seems, that Microsoft introduced new flags for kernel32.LoadLibraryEx function, which are not yet available in Wine. Those flags are: LOAD_IGNORE_CODE_AUTHZ_LEVEL, LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE, LOAD_LIBRARY_AS_IMAGE_RESOURCE and LOAD_LIBRARY_REQUIRE_SIGNED_TARGET. Most of them were added with Vista introduction, and the last one is not documented in MSDN. I don't want to implement them (at least, not now), but want to add some "stubby" support. So, I added flags into winuser.h and the following code on the beginning of kernel32.load_library routine: if( flags & LOAD_IGNORE_CODE_AUTHZ_LEVEL ) FIXME("unsupported flag: LOAD_IGNORE_CODE_AUTHZ_LEVEL\n"); if( flags & LOAD_LIBRARY_AS_IMAGE_RESOURCE ) FIXME("unsupported flag: LOAD_LIBRARY_AS_IMAGE_RESOURCE\n"); if( flags & LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE ) { FIXME("unsupported flag: LOAD_LIBRARY_AS_DATAFILE_EXCLUSIVE\n"); /* temporary solution which should let some application working */ flags |= LOAD_LIBRARY_AS_DATAFILE; } if( flags & LOAD_LIBRARY_REQUIRE_SIGNED_TARGET ) FIXME("unsupported flag: LOAD_LIBRARY_REQUIRE_SIGNED_TARGET\n"); Of course it works, but is it acceptable by Wine project?

2 1

DIBEngine and gdi32/user32 controls drawing loop performance
by Amico Amico 20 Jun '10

20 Jun '10

Hello, since I had a poor performance in drawing many buttons and text input fields at the same time into a window with wine, I applied the DIBEngine patch (http://wiki.winehq.org/DIBEngine) that is available for wine 1.1.44 (http://bugs.winehq.org/attachment.cgi?id=27879) to the 1.1.44 version of wine and started my application program that needs to draw many button and text input fields in a single window with the enviroment variable "WINEDIB=ON wine ./App.exe". Now that the DIBEngine patch is applied a little speedup in the drawing of the buttons and the text input fields is shown, but now the problem is that they are still drawn in blocks of a subset of the total number and then wine waits a little bit, then it draws another block of text input fields and buttons and then wine still waits, then it draws, and so on. The result is that my App.exe application window that is full of buttons and text input fields is drawn in subsequent times, and groups of buttons and input fields are drawn in blocks with a delay between the drawing of a group of controls and the others. The fact that not all the controls are drawn at a time but in more times is frustrating, since the CPU is a core2duo, and I think that it is powerful enough to draw all of the controls in the window at a time, specially with the DIBEngine patch applied and the DIBEngine activated. So I thought that the problem could be in the main event loop that manages the App.exe application window, and in particular the problem could be that the loop yields the drawing of the controls after a certain number of controls have been drawn in order to avoid CPU high load and then the loop starts again to draw other controls after a while and then it stops and yields and waits again, and so on. Where can I modify such a behaviour? In particular my App.exe program use many gdi32 drawing commands for drawing buttons and text input fields, so the files dlls/user32/button.c and dlls/user32/edit.c are involved. I think that the dlls/user32/winproc.c file, where the Code: LRESULT WINAPI EditWndProcA( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam ) { return wow_handlers.edit_proc( hwnd, msg, wParam, lParam, FALSE ); } function is defined is the file where I should do some changes; this function calls Code: LRESULT EditWndProc_common( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, BOOL unicode ) that is implemented in the dlls/user32/edit.c file, but the fact is that in the EditWndProc_common function there are many cases like this one that manages the various edit messages and window messages sent Code: switch (msg) { case EM_GETSEL: result = EDIT_EM_GetSel(es, (PUINT)wParam, (PUINT)lParam); break; .... and I don't know how to modify the fact that the main loop of the window should handle more messages in order to draw all of the controls at a time and that it should not yield for waiting and then starting drawing again after some time. What can I do? Thanks in advance, AmoxT _________________________________________________________________ Taglia i costi. Chiama e videochiama da Messenger http://www.messenger.it/videoconversazioni.aspx

2 1

[RFC] gameux.dll implementation stub [try 2]
by Mariusz Pluciński 20 Jun '10

20 Jun '10

Hi I fixed noted problems with my initial implementation of gameux.dll. The code freeze is still the fact, but I hope for some feedback. Thanks

3 2

new winetricks 20100618: new verbs dxsdk_nov2006, windowscodecs
by Dan Kegel 20 Jun '10

20 Jun '10

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Dan Kegel Add dxsdk_nov2006, document how to use it etc. at http://kegel.com/wine/cl-howto-win7sdk.html directx9: override dxdiag.exe, too Update divx sha1sum Andrew Nguyen Add windowscodecs Jeff Zaroyko Fix vjrun20 path in non-quiet mode Austin English Update OpenWatcom to version 1.9

6 7

gnome-exe-thumbnailer -- using embedded icons for .exe and .dll files
by Scott Ritchie 20 Jun '10

20 Jun '10

Screenshot/blog here: http://yokozar.org/blog/archives/225 A bug was fixed recently in Gnome that allows thumbnailers to not be 96x96 pixels. Combine this with a standard Wine icon, icoutils for extracting an exe/dll's embedded icon, and a bit of magic and you can get icons like those above. The version numbers come from the .exe metadata. I think it's really slick, and will try and have it installed by default with Wine 1.2. At the moment it exists as thumbnailer code for Gnome, which means other desktops won't benefit, however provided they can be told to run a script to generate an icon it should be fairly easy to port. Code is available in the gnome-exe-thumbnailer source package here: https://edge.launchpad.net/~ubuntu-wine/+archive/ppa Please note that this is an updated version of the proof of concept gnome-exe-thumbnailer package I put in Lucid (which is ugly and uses the overly large 96x96 icons, and is thus not default and has so far gone unnoticed). Thanks, Scott Ritchie

3 4

Re: [PATCH 3/3] shdocvw: Return IHTMLDocument2's IDispatch in get_Document.
by testbot＠testbot.winehq.org 19 Jun '10

19 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2780 Your paranoid android. === WXPPROSP3 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W2K3R2SESP2 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === WVISTAADM (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W2K8SE (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PRO (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PROX64 (32 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex === W7PROX64 (64 bit htmldoc) === htmldoc.c:4524: Test failed: disp != dispex htmldoc.c:4524: Test failed: disp != dispex

1 0

Re: [PATCH 3/3] shdocvw: Return IHTMLDocument2's IDispatch in get_Document.
by testbot＠testbot.winehq.org 19 Jun '10

19 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2779 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2485: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2485: Test failed: CoCreateInterface failed: 80040154 === W2K8SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP

1 0

Re: [PATCH] [Mmsystem.drv]: always map parameters for all callback kinds
by Juan Lang 19 Jun '10

19 Jun '10

Hi Eric, minor comment on this patch: + case CALLBACK_FUNCTION: + TRACE("Function (32 bit) !\n"); + /* 16 bit func, call it */ + TRACE("Function (16 bit) %x!\n", thunk->callback); The back-to-back traces look a little strange. So does the indenting here. --Juan

1 0

Apologies for the marketing message
by Jeremy White 19 Jun '10

19 Jun '10

It's not clear how it happened; it was not intended. These are direct emails James sends periodically to customers reaching the end of their support period. We speculate that someone signed up with the mailing list address as 'their' address. At any rate, by way of apology I'd like to remind everyone that all contributors to Wine are entitled to VIP status with CodeWeavers, which gets you free lifetime subscriptions to CrossOver. (This way, there is no chance James could ever sell you anything <grin>). Write to me if you'd like me to set you up. We are deeply grateful for everyones contributions to Wine, and very sorry for the off topic emails. Cheers, Jeremy

1 0

Re: new winetricks 20100618: new verbs dxsdk_nov2006, windowscodecs
by Vincent Povirk 19 Jun '10

19 Jun '10

On Sat, Jun 19, 2010 at 9:31 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > On 6/19/2010 18:25, Vincent Povirk wrote: >>> >>> Is it possible to add this in existing target d3dx dll that will be using >>> new decoder? >>> >> >> Yes, but they'll have to share the decoder for the DDS format somehow. >> It doesn't make much sense for d3dx9 to load d3dx11 for this. >> > > If native d3dx11 uses d3dx9 for that it's not a problem, cause this will be > still separated and both overrides will work. > If not - it's sad, additional winetricks re-registration will be needed, > etc. And if our windowscodecs is complete enough > we should probably forget about all of that and never use its override. Well, we need to register a decoder coclass to do this most cleanly, using WIC's built-in image format detection. These classes aren't present on any native dll's. Even if we didn't use a coclass, we'd need some sort of extension to a builtin dll. Most of the extra formats are only needed by d3dx9 (it seems native d3dx10 and d3dx11 use WIC, so they mostly support the WIC formats). DDS, however, can be loaded in d3dx9, d3dx10, and d3dx11. If we put a coclass for DDS in one of these dll's, the other two will have to load it when a program needs to read a DDS file.

1 0

kernel32 translation question
by Luca Bennati 19 Jun '10

19 Jun '10

I found out why it didn't build: a numeric code in the first lines was in a wrong format. But now i need help to know what exactly i need to put there, because i don't know anymore. The lines are these (example got from french file): LanguageNames=(FRA=0x0c:winerr) CodePages=(FRA=65001:0) The problem is only the hexadecimal code in the first line: where i find the right value for ITA? The one i put (incorrectly) was from ita.nls ...

3 2

Re: hhctrl.ocx - null pointer bug
by Dmitry Timoshkov 19 Jun '10

19 Jun '10

Jaroslav Šmíd <jardasmid(a)gmail.com> wrote: > Patch http://www.winehq.org/pipermail/wine-patches/2010-June/089135.html > sent by Dmitry Timoshkov contains bug resulting in wine crash due to > possible null pointer dereference. Please, see bug report at > http://bugs.winehq.org/show_bug.cgi?id=23247 for more information. You need to fix dlls/hhctrl.ocx/chm.c,LoadWinTypeFromCHM() to fill defaults in all cases instead. Is that a real or just "possible" crash? From your description and the bug report it sounds like a theoretical issue. -- Dmitry.

2 1

Re: hhctrl.ocx - null pointer bug
by Juan Lang 18 Jun '10

18 Jun '10

Hi Jaroslav, - if (!*caption) caption = info->pCHMInfo->defTitle; + if (!caption) caption = info->pCHMInfo->defTitle; I suspect a better fix would be: + if (!caption || !*caption) caption = info->pCHMInfo->defTitle; That is, either a NULL caption or an empty one results in info->pCHMInfo->defTitle getting used. --Juan

2 1

New wisotool 20100618: 19 new verbs (blur, spore, photoshop cs5, ...), and 75 old ones
by Dan Kegel 18 Jun '10

18 Jun '10

wisotool is a handy winetricks-like script for automatically installing games from .iso or .mds files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except, for now, it prompts for your password so it can mount the .iso file). Wisotool currently supports about 95 games and/or benchmarks (see below). Please consider contributing support for your favorite game, it's not (too) hard. I'm especially interested in recent or beta games; ideally wisotool would support good games or betas on or near their day of release. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100530: Austin English: New verbs proevolution2010_demo pscs5 pscs5_pickle pscs5_unpickle Dan Kegel: New verbs bioshock_demo blur rom Various bugfixes Eleazar Galano: New verbs avatar_demo braid braid_demo darknesswithin2_demo hegemonypom_demo hphbp_demo nfsps_demo popsot spore Travis Athougies: New verbs 7million msaoe_demo Vincent Pelletier: New verb beneath_a_steel_sky_gog Here's the current help message: Script to install games automatically. Usage: wisotool [options] package [package] ... Options: -q quieter -v verbose -V display Version Packages: 3dmark03 3D Mark 03 (Futuremark, 2003) [download] 3dmark05 3D Mark 05 (Futuremark, 2005) [download] 3dmark06 3D Mark 06 (Futuremark, 2006) [download] 3dmark2000 3DMark2000 (MadOnion.com, 2000) [download] 3dmark2001 3DMark2001 (MadOnion.com, 2001) [download] 7million 7Million (Deep Silver, 2009) [download] [broken on wine] abes_exoddus_gog Abes Exoddus (GOG.com) abes_oddysee_gog Abes Oddysee (GOG.com) assassinscreed Assassins Creed (Ubisoft, 2008) avatar_demo James Camerons Avatar The Game Demo (Ubisoft, 2009) [download] baldursgate2 Baldurs Gate 2 - Shadows of Amn (Bioware, 2000) battle_chess_gog Battle Chess (GOG.com) beneath_a_steel_sky_gog Beneath a Steel Sky (GOG.com, free) beyond_good_and_evil_gog Beyond Good and Evil (GOG.com) bfbc2 Battlefield Bad Company 2 (EA, 2010) bioshock Bioshock (2K Games, 2007) bioshock_demo Bioshock Demo (2K Games, 2007) blur Blur (Activision, 2010) braid Braid (Number None, 2009) [download] braid_demo Braid Demo (Number None, 2009) [download] codmw2 Call of Duty Modern Warfare 2 (Activision, 2009) [broken] darknesswithin2_demo Darkness Within 2 Demo (Zoetrope Interactive, 2010) [download] descent_1_2_gog Descent and Descent 2 (GOG.com) descent_3_gog Descent 3 (GOG.com) diablo2 Diablo II (Blizzard, 2000) dragonage Dragon Age: Origins (Bioware, 2009) dukenukem3d_gog Duke Nukem 3D (GOG.com) dukenukemmp_gog Duke Nukem Manhattan Project (GOG.com) earth_2150_trilogy_gog Earth 2150 trilogy (GOG.com) earth_2160_gog Earth 2160 (GOG.com) earthworm_jim_1_2_gog Earthworm Jim 1 & 2 (GOG.com) earthworm_jim_3d_gog Earthworm Jim 3D (GOG.com) empire_earth_gold_gog Empire Earth Gold (GOG.com) evil_genius_gog Evil Genius (GOG.com) fallout_2_gog Fallout 2 (GOG.com) fallout_gog Fallout (GOG.com) fallout_tactics_gog Fallout Tactics (GOG.com) far_cry_gog Far Cry (GOG.com) flatout_gog FlatOut (GOG.com) freespace_2_gog Freespace 2 (GOG.com) freespace_gog Freespace (GOG.com) ghost_master_gog Ghost Master (GOG.com) ground_control_2_gog Ground Control 2 (GOG.com) gta_vc Grand Theft Auto: Vice City (Rockstar, 2003) half_life_goty Half Life: Game of the Year Edition (Sierra, 2000) hegemonypom_demo Hegemony: Philip of Macedon Demo (Longbow Games, 2010) [download] help How to use this tool hon Heroes of Newerth (S2 Games, 2010) [download] hphbp_demo Harry Potter & The Half Blood Prince Demo (EA, 2009) [download] lswcs Lego Star Wars Complete Saga (Lucasarts, 2009) manhole The Manhole Masterpiece Edition (Cyan, 1994) masseffect2 Mass Effect 2 (BioWare, 2010) mdk2_gog MDK 2 (GOG.com) mdk_gog MDK (GOG.com) mnbw_demo Mount & Blade Warband Demo (Taleworlds, 2010) [download] morrowind The Elder Scrolls III: Morrowind (Bethesda, 2002) msaoe_demo Age of Empires Demo (Microsoft, 1997) [download] neighbours_from_hell_compilation_gog Neighbours From Hell 1 & 2 (GOG.com) nfsps_demo Need For Speed: Pro Street Demo (EA, 2007) operation_flashpoint_goty_gog Operation Flashpoint GOTY (GOG.com) orangebox Orange Box (Valve, 2007) painkiller_black_gog Painkiller Black (GOG.com) pcmark04 PC Mark 04 (Futuremark, 2004) [download] pcmark05 PC Mark 05 (Futuremark, 2005) [download] perimeter_gog Perimeter (GOG.com) plantsvszombies Plants vs. Zombies (PopCap Games, 2009) [download] popsot Prince of Persia Sands of Time (Ubisoft, 2003) popsot_demo Prince of Persia Sands of Time Demo (Ubisoft, 2003) praetorians_gog Praetorians (GOG.com) procycling08_demo Pro Cycling Manager 2008 Demo (Cyanide, 2008) [download, broken in wine] procycling09_nda Pro Cycling Manager 2009 (Cyanide, 2009) proevolution2010_demo Pro Evolution Soccer 2010 Demo (Konami, 2009) [download] pscs5 Photoshop CS5 Demo (Adobe, 2010) pscs5_pickle save Photoshop CS5 Demo to tarball pscs5_unpickle restore Photoshop CS5 Demo from tarball psychonauts_gog Psychonauts (GOG.com) quake3 Quake 3 (ID Software, 1999) re5bench Resident Evil 5 Benchmark (Capcom, 2009) [download] redneck_rampage_gog Redneck Rampage (GOG.com) robinson_requiem_collection_gog Robinson Requiem & Deus (GOG.com) rom Runes of Magic (Frogster Interactive, 2009) [download] settlers_2_gold_gog The Settlers 2 Gold (GOG.com) shogo_gog Shogo Mobile Armor Division (GOG.com) sims3 The Sims 3 (EA, 2009) splitsecond Split Second (Black Rock Studios, 2010) [wine bug 22865] splitsecond_demo Split Second Demo (Black Rock Studios, 2010) [wine bug 22865] spore Spore (EA, 2008) starcraft Starcraft Battle Chest (Blizzard, 1998) starcraft2 Starcraft II beta (Blizzard, 2010) stfu Starwars: The Force Unleashed (Aspyr, 2009) sto Star Trek Online (Cryptic, 2010) tex_murphy_1_and_2_gog Tex Murphy 1 & 2 (GOG.com) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) [download] unreal_2_se_gog Unreal 2: The awakening Special Edition (GOG.com) unreal_gold_gog Unreal Gold Edition (GOG.com) ut2004_gog Unreal Tournament 2004 (GOG.com) ut_goty_gog Unreal Tournament GOTY (GOG.com) wog World of Goo demo (2D Boy, 2008) [download] wowbc World of Warcraft: Battle Chest (Blizzard, 2008) Pseudopackages: load Load a disc into the iso cache load=KEY Load a disc with given key; only works from commandline at moment ------------------------------------------------------ If the game is not marked with {download} or {loaded} in the menu, you have to insert its disc and give the 'load' command before you can choose that game in the menu. If the game has multiple discs, you have to do this for each disc. ------------------------------------------------------ ------------------------------------------------------ If the game has an install key, you have to enter that when loading the first disc. (You have to do that from the commandline, e.g. sh wisotool load=XXXX-YYYY-ZZZZ.) ------------------------------------------------------

1 0

Happy Father's Day From CodeWeavers: Get CrossOver Mac for 60% Off (This Weekend Only)
by James Ramey 18 Jun '10

18 Jun '10

Thank you for your past patronage of CrossOver Mac. We appreciate your business, and I was hoping to tempt you with an enticing offer to continue supporting our software. For this weekend only, you can purchase CrossOver (any version) for 60% off the list price. All you need to do is enter SPECIAL DEAL CODE: FATHERSDAY in the Special Deal Box in the cart screen (has to be the cart screen) of the order process. You'll see the discount applied before you complete your transaction. It's a quick and easy way to save money on your purchase of CrossOver. · A couple of factoids you might want to consider in making this purchase: · CrossOver 9.1 is due out within the next 45 days. CrossOver 9.1 should be an especially good release of CrossOver, and the upgrade to this version is included in your purchase. · CrossOver Mac Professional includes a license for CrossOver Mac Games. CrossOver Mac Games is now playing many new titles including Star Trek On-line. If you have an interest in playing games, you may want to consider purchasing CrossOver Mac Professional using the SPECIAL DEAL CODE. · All volume and educational discounts are still valid with this promotion. If you have an educational entitlement, you'll get your educational discount in addition to the SPECIAL DEAL CODE. Likewise if you purchase more than one license, you'll also get volume discounts. Again, this SPECIAL DEAL CODE is easy to use and will save you money!! · The SPECIAL DEAL CODE expires on Monday, June 21. Don't wait to buy. If you're interested, make your purchase now as this special deal is limited to only past customers and only to this weekend. · If this SPECIAL DEAL CODE isn't your cup of tea, I understand. This is the only e-mail that you will receive from me about renewing your support. You'll receive a nag e-mail or two from our system reminding you to renew your maintenance. Once those have past, we will not contact you again (ever) unless you have signed up for one of our many mailing lists. Finally, everyone at CodeWeavers appreciates your business. We appreciate your patience as we work to make our software ever better. We understand that it's not always easy to use our software and that our software doesn't always provide the support you want or need. We want you to know this and that we are making efforts to make the software better. Again, thank you. We sincerely appreciate your support of our software and our efforts to make our software better. With my best regards, James B. Ramey Vice President, Sales CodeWeavers, Inc. jramey(a)codeweavers.com

1 0

The __WINE__ macro does not identify the Wine platform
by Alan W. Irwin 18 Jun '10

18 Jun '10

According to some old discussion (http://www.mail-archive.com/wine-devel@winehq.com/msg15669.html) on wine-devel it appears that __WINE__ was going to be the macro used to identify the Wine platform, However, that doesn't appear to work for Windows native MinGW on wine. To show this, I attach results from running wine gcc -E -dM foo.c >| /tmp/wine_gcc_dM.out where foo.c is an empty file, and gcc is the MinGW 4.5.0-1 version. The equivalent command under Linux gcc shows several macros, (e.g., __linux__) are defined to identify that platform, but I cannot find anything in the attached file that similarly identifies the Wine platform. Furthermore, I have compiled and run a simple test code under Wine that shows that __WINE__ is not available (see previous post on wine-users for details). An excellent general motivation for such an identifying macro for wine is given in the above older wine-devel discussion, and I understand the CMake developers have an immediate use for such a macro within the CMake code itself. Is the lack of a macro to identify the wine platform a bug I should report or am I missing something? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________

7 11

Re: user32: Lock user32 in alloc_user_handle to fix races with get_user_handle_ptr
by Dan Kegel 18 Jun '10

18 Jun '10

On Fri, Jun 18, 2010 at 9:18 AM, Paul Chitescu <paulc(a)voip.null.ro> wrote: > On Friday 18 June 2010 07:04:14 pm Dan Kegel wrote: >> Say, that sounds like a kind of test we should have in our test suite. >> >> What apps does this fix? > > Sysinternal's autoruns.exe which populates a number of list/tree views with a > large number of icons extracted them the exes. It seems to do so from > different threads and it doesn't stop if one thread crashes (I wonder - > intentionally?) > > Unfortunately it's a race condition that doesn't always happen. Adding just a > TRACE suppressed the error. Adding if (...) ERR(...) showed that only 1-2 out > of about 150 icon creations would crash. Thanks for the info.

1 0

Re: advapi32/tests: Fixed -Wsign-compare warnings in security tests (try 2)
by Alexandre Julliard 18 Jun '10

18 Jun '10

Marko Nikolic <grkoma(a)gmail.com> writes: > Fixed test failures in 64-bit build. It would be better to choose a more appropriate invalid value for a BOOL variable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Force a minimum character size of 1x1 to prevent divisions by zero if setting the font failed
by Alexandre Julliard 18 Jun '10

18 Jun '10

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > user32: Force a minimum character size of 1x1 to prevent divisions by zero if > setting the font failed > > Failing to set any font is unusual but can happen - for example: > DISPLAY= wine notepad It sounds like a gdi bug. It should be able to provide metrics even without a display. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by Alexandre Julliard 18 Jun '10

18 Jun '10

Aric Stewart <aric(a)codeweavers.com> writes: > commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 > Author: Aric Stewart <aric(a)codeweavers.com> > Date: Fri Jun 18 13:21:56 2010 +0900 > > comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons It would probably be better to not disable buttons that don't need it. What is this fixing? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons
by James Mckenzie 18 Jun '10

18 Jun '10

Aric Stewart <aric(a)codeweavers.com> wrote: > >Alexandre Julliard wrote: >> Aric Stewart <aric(a)codeweavers.com> writes: >> >>> commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 >>> Author: Aric Stewart <aric(a)codeweavers.com> >>> Date: Fri Jun 18 13:21:56 2010 +0900 >>> >>> comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons >> >> It would probably be better to not disable buttons that don't need >> it. What is this fixing? >> > >I can modify the patch to do that. > >This is triggering a bug on the mac that causes the window manager to >loose track of where to send messages causing the resulting dialog to be >unable to get mouse events. > Thank you for taking time to fix this. What is the bug report number so that I can go out and vote for it. I've experienced this lately while running some regression tests and I thought that it was just my system messing up (I've had to reboot it several times in the last week or so.) BTW, 10.6.4 has been released, 700MB download :( James McKenzie

1 0

Re: ddraw: Better validation of IDirectDrawSurface::BltFast parameters.
by Henri Verbeet 18 Jun '10

18 Jun '10

On 18 June 2010 15:52, Iain Arnell <iarnell(a)gmail.com> wrote: > - dsty + rsrc->bottom - rsrc->top > This->surface_desc.dwHeight) > + dsty + rsrc->bottom - rsrc->top > This->surface_desc.dwHeight || > + (dstx | dsty) & (1<<(sizeof(DWORD)*8-1)) /* dstx or dsty negative */ ) That's not very pretty. This looks like it's just an integer overflow, so that's probably also how you should handle it.

1 0

Re: Michael Stefaniuc : notepad: Fix an error in the Bulgarian translation.
by Eric Ahn 18 Jun '10

18 Jun '10

unsubscribe

1 0

Re: notepad: substitute the page number in the footer
by Alexandre Julliard 18 Jun '10

18 Jun '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * notepad: substitute the page number in the footer This needs to be more generic, there are other possible substitutions. At the very least it should handle escaped ampersands. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Add the Romanian translation. (2nd try)
by Octavian Voicu 18 Jun '10

18 Jun '10

On Fri, Jun 18, 2010 at 12:14 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > + IDS_INVALID_CALL_ARG "Apel de procedură sau argument nevalid" > + IDS_SEMICOLON "„;” presupus" > + IDS_LBRACKET "„(” presupus" > + IDS_RBRACKET "„)” presupus" > + IDS_UNTERMINATED_STR "Constantă de șir nedeterminată" > + IDS_NOT_FUNC "Funcție presupusă" > + IDS_NOT_NUM "Număr presupus" > + IDS_OBJECT_EXPECTED "Obiect presupus" > + IDS_NOT_BOOL "Obiect boolean presupus" > + IDS_JSCRIPT_EXPECTED "Obiect JScript presupus" > + IDS_REGEXP_SYNTAX_ERROR "Eroare de sintaxă în expresie rațională" > + IDS_URI_INVALID_CHAR "URI care trebuie codificat conține caractere nevalide" > + IDS_ARRAY_EXPECTED "Obiect matrice presupus" "expresie rațională" should be translated as "expresie regulată" (I've also seen "regulară", but never "rațională") [1] "nevalid" sounds really odd and it's almost never used; imho "invalid" should be used instead [2] "presupus" sounds really confusing; something in the lines of "Se aștepta un obiect" sounds better to me and seems more standard [3] I really think we should try to make translations a bit standard, especially when it comes to technical terms. Octavian [1] http://ro.wikipedia.org/wiki/Expresie_regulat%C4%83 [2] http://ro.wikipedia.org/wiki/Special:C%C4%83utare/Invalid [3] http://translationproject.org/latest/coreutils/ro.po

2 2

Re: jscript: Add the Romanian translation. (2nd try)
by Octavian Voicu 18 Jun '10

18 Jun '10

On Fri, Jun 18, 2010 at 12:14 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > + IDS_UNTERMINATED_STR "Constantă de șir nedeterminată" Forgot about this one, maybe try "Constantă șir neterminată" [1]. When not sure how to translate a term, maybe this will help: google for "UNKNOWN TERM ro.po site:http://translationproject.org/". Octavian [1] http://translationproject.org/PO-files/ro/indent-2.2.8.ro.po

1 0

Xinput / DirectInput xbox360 controller support
by Roderick Colenbrander 18 Jun '10

18 Jun '10

Hi all, I'm interested in adding Xbox 360 controller support to Wine. For people who don't know how this works and what's so special I will first give a small introduction. The Xbox 360 controller is a normal USB device which you can use from 'xinput*.dll' (typically xinput1_3.dll is used). The xinput API is very easy (and it is the same what is used on the Xbox360) and in total it exports a handful of functions. Basically there is a call to query the capabilities, a call to poll which button was pressed and a call to 'set the controller to a certain state' (rumble stuff) and a few other not so important calls. The dll can ONLY be used for xbox 360 compatible controllers and other controllers should use dinput. In Wine we have a stubbed xinput implementation. Last year Michael Gruber submitted a number of patches which added implementations for most calls but the code wasn't added. I tested his XInput code on current Wine and it actually works well in DirectX SDK examples including force feedback! After he submitted the code there was a short discussion on wine-devel but then it stopped. Michael his xinput code directly interfaces with the Linux input event interface. It was asked whether XInput can't be layered on top of DirectInput but that's not possible since DirectInput doesn't expose all the needed functionality (it doesn't support the Xbox360 force feedback). The other way around is also not possible because XInput is only for Xbox 360 controllers/joysticks while DirectInput also supports keyboard and mouse. I'm wondering how to proceed with XInput. My main issue is the 'joystick access part'. Would it be fine to directly access the controller from Xinput (so we would need multiple hardware backends later on). Code size won't be a problem though since XInput doesn't support much functionality at all (the current mostly working version is less than 500 lines of code; half of that is for the Linux backend). One small issue is though that DirectInput and XInput might have to cooperate since typically games use DirectInput to enumerate all joysticks, see for instance http://msdn.microsoft.com/en-us/library/ee417014%28VS.85%29.aspx Roderick

4 6

Help with simple winelib dll
by Seth Burleigh 18 Jun '10

18 Jun '10

Im attempting to build a dll which a windows program running under wine can dynamically load. The dll will be a wrapper around a linux library. In preparation ive tried to follow the instructions here http://www.winehq.org/docs/winelib-guide/bindlls with a simple example but have not succeeded. Below is the contents of the files in my directory and the commands i executed. Can anyone help out? Thanks! MyLinuxFunc.c int MyLinuxFunc(int a,int b) { return a+b; } ----------------------------- MyLinuxFunc.h int MyLinuxFunc(int,int); ----------------------------- libMyLinuxFunc.so ----------------------------- MyWin.dll.spec 2 stdcall MyWinFunc (long long) MyProxyWinFunc ----------------------------- MyWin.c #include <MyLinuxFunc.h> #include <windef.h> int WINAPI MyProxyWinFunc (int a,int b) { return MyLinuxFunc(a,b); } ----------------------------- winemaker . --nosource-fix --dll --single-target MyWin --nomfc -I"." -L"." -iMyLinuxFunc make winegcc -o MyWin.so MyLinuxFunc.o MyWin.o -L. -lMyLinuxFunc MyWin.o: In function `MyProxyWinFunc': MyWin.c:(.text+0x20): undefined reference to `MyLinuxFunc' /usr/lib/wine/libwinecrt0.a(exe_main.o): In function `main': (.text+0xa0): undefined reference to `WinMain' collect2: ld returned 1 exit status winegcc: i486-linux-gnu-gcc failed make: *** [MyWin.so] Error 2

4 7

Brazilian Portuguese translation of winecfg
by Gustavo 18 Jun '10

18 Jun '10

Hello, I've updated the translation of winecfg in Brazilian Portuguese. Making comparisons, I also noted that the "Windows Version" (Versão do Windows) drop-down menu disappeared and the Browse... (Localização:) text in the Drives was cut to half when you execute wine with LANG="pt_PT.UTF-8" (the Portuguese from Portugal). I've managed to fix that as well. So I sent two separate patches: one with the Brazilian translation and another with the Portuguese fixes. Let me know if I did anything wrong. Gustavo Henrique Milaré

1 1

Re: comctl32: Update English resource
by Juan Lang 17 Jun '10

17 Jun '10

Hi Ken, +LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_CAN + +IDD_TBCUSTOMIZE DIALOG DISCARDABLE 10, 20, 357, 125 +STYLE DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU +CAPTION "Customize Toolbar" +FONT 8, "MS Shell Dlg" +BEGIN + DEFPUSHBUTTON "&Close", IDCANCEL,308,6,44,14 + PUSHBUTTON "R&eset", IDC_RESET_BTN,308,23,44,14 + PUSHBUTTON "&Help", IDC_HELP_BTN,308,40,44,14 + PUSHBUTTON "Move &Up", IDC_MOVEUP_BTN,308,74,44,14 + PUSHBUTTON "Move &Down", IDC_MOVEDN_BTN,308,91,44,14 + LTEXT "A&vailable buttons:", -1,4,5,84,10 + LISTBOX IDC_AVAILBTN_LBOX,4,17,120,100, LBS_NOTIFY | LBS_OWNERDRAWFIXED | LBS_HASSTRINGS | LBS_NOINTEGRALHEIGHT | LBS_DISABLENOSCROLL | WS_BORDER | WS_VSCROLL | WS_HSCROLL | WS_TABSTOP + PUSHBUTTON "&Add ->", IDOK, 131, 42, 44, 14 + PUSHBUTTON "<- &Remove", IDC_REMOVE_BTN,131,62,44,14 + LTEXT "&Toolbar buttons:", -1,182,5,78,10 + LISTBOX IDC_TOOLBARBTN_LBOX, 182,17,120,100,LBS_NOTIFY | LBS_OWNERDRAWFIXED | LBS_HASSTRINGS | LBS_NOINTEGRALHEIGHT | LBS_DISABLENOSCROLL | WS_BORDER | WS_VSCROLL | WS_HSCROLL | WS_TABSTOP +END I don't understand why you would want to create multiple "translations" when their content is identical. If it's because the statistics you're generating claim a particular variant of English is incomplete, then you should fix the tool you're using to generate the statistics: unless there's an actual difference between American English and the variant, there's no need for a translation. --Juan

3 3

Brazilian Portuguese translation
by Gustavo 17 Jun '10

17 Jun '10

Hello, I can see that the Brazilian translation is bad, so I'm translating winecfg. I followed the instruction in the wiki [1] to create a .po file. At first I tried to recover from the file Pt.rc rc2po -t En.rc Pt.rc Pt.po but I didn't have much luck, no existing translations are shown. Adding the options --lang=LANG_PORTUGUESE --sublang=SUBLANG_PORTUGUESE_BRAZILIAN or even just --lang=LANG_PORTUGUESE fails to create the file. Not much of a problem, I started from scratch. The problem is, when I use the .po file to create the .rc file po2rc --lang=LANG_PORTUGUESE --sublang=SUBLANG_PORTUGUESE_BRAZILIAN -t En.rc Pt.po Pt.rc only Brazilian Portuguese entries are created, and the Pt.rc file had "Portuguese Portuguese" entries as well. What should I do? Gustavo. [1] http://wiki.winehq.org/Translating

3 4

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior
by lats 17 Jun '10

17 Jun '10

When does this unpredictability occur? The tests have always run ok for me.

2 1

wined3d: Add NPOT quirk for GeforceFX 5200
by Roderick Colenbrander 17 Jun '10

17 Jun '10

1 0

Re: msvcrt/tests: Re-order tests to work around weird win_skip failure bug. (try 2)
by Alexandre Julliard 17 Jun '10

17 Jun '10

Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> writes: > Try 2: Re-order function bodies as well. > > From a51f6b7f855ccb1d9252a3d5e2698cdbe73ad053 Mon Sep 17 00:00:00 2001 > From: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> > Date: Fri, 11 Jun 2010 14:13:52 +0100 > Subject: msvcrt/tests: Re-order tests to work around weird win_skip failure bug. > > Paul Vriens found which test caused the breakage. There's no need to reorder the functions, but there's a need to understand why that test is breaking win_skip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2]kernel32/tests: Test the collation table much more
by Alexandre Julliard 17 Jun '10

17 Jun '10

André Hentschel <nerv(a)dawncrow.de> writes: > I added some ranges to test, so it is easy extensible That's still not a very convincing test... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend) usp10/tests: Windows 95 does not set invalid glyphs to 0 but instead 0x80
by testbot＠testbot.winehq.org 17 Jun '10

17 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2742 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: usp10/tests: Windows 95 does not set invalid glyphs to 0 but instead 0x80
by testbot＠testbot.winehq.org 17 Jun '10

17 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2739 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: [PATCH] winspool/tests: Handle the Windows bug in GetPrinterDataEx
by testbot＠testbot.winehq.org 17 Jun '10

17 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2720 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: PGO and wine
by Peter Davies 17 Jun '10

17 Jun '10

On 16 June 2010 02:37, Dan Kegel <dank(a)kegel.com> wrote: > But does PGO improve performance measurably? > Probably, to test it I need a program that runs wine like a typical program, that I can run autonomously. Anyone have any ideas? Peter

5 4

wrong link between bug and AppDB
by wylda＠volny.cz 16 Jun '10

16 Jun '10

Hi, i just made a mistake and linked bug 9264 with http://appdb.winehq.org/objectManager.php?sClass=version&iId=20179. But i wanted to link 19264 instead of 9264. What are the correct steps to fix this mistake? -- Kaspersky Internet Security 2010 + Kaspersky Mobile Security jen za 1199,-Kč. Ochraňte svůj počítač i mobil před zneužitím či ztrátou dat. Kupte si 2 produkty za cenu jednoho. www.kaspersky.cz

2 1

Re: [PATCH] ntdll: The FPU control word for newly created threads is 0x27f.
by Alexandre Julliard 16 Jun '10

16 Jun '10

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 36f1499..0d383bd 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -384,6 +384,7 @@ static void start_thread( struct startup_info *info ) > thread_data->pthread_id = pthread_self(); > > signal_init_thread( teb ); > + signal_init_thread_fpu(); > server_init_thread( func ); > pthread_sigmask( SIG_UNBLOCK, &server_block_set, NULL ); This should be done inside signal_init_thread(), that's already meant for platform-specific setup, there's no need to add a separate entry point. Also you may want to do an fninit if new threads are not supposed to inherit FPU state. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] ntdll: The FPU control word for newly created threads is 0x27f.
by Henri Verbeet 16 Jun '10

16 Jun '10

I forgot to mention this, but this fixes a regression introduced by commit e6611e22fb037a879205f1330d1a3485f9f18705.

1 0

Re: [RESEND 2] Changes to enable the use of gcov and PGO
by Alexandre Julliard 16 Jun '10

16 Jun '10

Peter Davies <ultratwo(a)gmail.com> writes: > @@ -72,7 +72,7 @@ MAKECTESTS = $(TOOLSDIR)/tools/make_ctests$(TOOLSEXT) > WRC = $(TOOLSDIR)/tools/wrc/wrc$(TOOLSEXT) > WMC = $(TOOLSDIR)/tools/wmc/wmc$(TOOLSEXT) > WIDL = $(TOOLSDIR)/tools/widl/widl$(TOOLSEXT) > -WINEGCC = $(TOOLSDIR)/tools/winegcc/winegcc $(TARGETFLAGS) -B$(TOOLSDIR)/tools/winebuild --sysroot=$(TOPOBJDIR) @UNWINDFLAGS@ > +WINEGCC = $(TOOLSDIR)/tools/winegcc/winegcc $(TARGETFLAGS) -B$(TOOLSDIR)/tools/winebuild --sysroot=$(TOPOBJDIR) @UNWINDFLAGS@ $(LDFLAGS) LDFLAGS are already passed to winegcc where appropriate. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Anotated 'make test' log
by Max TenEyck Woodbury 16 Jun '10

16 Jun '10

Dan wrote: > OK. I'd suggest starting by looking at > http://bugs.winehq.org/show_bug.cgi?id=15435 > "Wine logs too verbose, quieter fixme's needed" and sending > in a patch to make one of the overly-verbose fixme's a bit > quieter. Thanks. I'll look at it. > Also, check your mail system; I can't email to you directly, > it bounces. And that's going to be a problem communicating > with other developers. A system disk failed this past weekend and I've been trying to get everything back up. I got test messages through starting about two hours ago. I've been checking the mailing list archive. (Yes, messages do not get properly threaded that way.) I'm also in the process of reinstalling much software. That machine is not very fast... - Max

1 1

Re: [2/9] setupapi: Validate the cabinet filename parameter in SetupIterateCabinetA.
by Alexandre Julliard 16 Jun '10

16 Jun '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > dlls/setupapi/setupcab.c | 7 ++- > dlls/setupapi/tests/Makefile.in | 1 + > dlls/setupapi/tests/setupcab.c | 121 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 128 insertions(+), 1 deletions(-) > create mode 100644 dlls/setupapi/tests/setupcab.c It doesn't work here: wine: Unhandled page fault on write access to 0x6864dd7b at address 0x686a1c89 (thread 003a), starting debugger... Unhandled exception: page fault on write access to 0x6864dd7b in 32-bit code (0x686a1c89). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:686a1c89 ESP:0032f6e0 EBP:0032fa68 EFLAGS:00010246( R- -- I Z- -P- ) EAX:6864dd7b EBX:686b2cfc ECX:00000000 EDX:00000024 ESI:6865d68f EDI:0032f838 Stack dump: 0x0032f6e0: 0032f93c 6864dd7b 0032f838 0032fa4c 0x0032f6f0: 686a14e0 00000000 0032f724 ffffffff 0x0032f700: 0032fa40 0032f9e4 0032f768 7bc70be0 0x0032f710: 0000000e 00000002 00000001 0032f93c 0x0032f720: 00110060 acabfeed 00121100 00000000 0x0032f730: 00000000 00038080 2e366338 00706d74 Backtrace: =>0 0x686a1c89 SetupIterateCabinetA+0xc9(CabinetFile="", Reserved=0, MsgHandler=0x6864b9a0, Context=0x0(nil)) [/home/julliard/wine/wine/dlls/setupapi/setupcab.c:588] in setupapi (0x0032fd38) 1 0x6864bd95 test_invalid_parametersA+0x384() [/home/julliard/wine/wine/dlls/setupapi/tests/setupcab.c:108] in setupapi_test (0x0032fd88) 2 0x6864df0e run_test+0x14d(name=<is not available>) [/home/julliard/wine/wine/dlls/setupapi/tests/../../../include/wine/test.h:557] in setupapi_test (0x0032fe48) 3 0x6864e0e2 main+0x131(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/setupapi/tests/../../../include/wine/test.h:607] in setupapi_test (0x0032fe90) 4 0x6864e27c __wine_spec_exe_entry+0x7b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in setupapi_test (0x0032fea8) 5 0x7b854ebc call_process_entry+0xb() in kernel32 (0x0032fee8) 6 0x7b85756b start_process+0x5a(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/kernel32/process.c:996] in kernel32 (0x0032fef8) 7 0x7bc71a40 call_thread_func+0xb() in ntdll (0x0032ffc8) 8 0x7bc71c10 call_thread_entry_point+0x6f(entry=0x7b857510, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2466] in ntdll (0x0032ffe8) 9 0x7bc4d5ca start_process+0x29(kernel_start=0x7b857510) [/home/julliard/wine/wine/dlls/ntdll/loader.c:2612] in ntdll (0x00000000) 0x686a1c89 SetupIterateCabinetA+0xc9 [/home/julliard/wine/wine/dlls/setupapi/setupcab.c:588] in setupapi: movb $0x0,0x0(%eax) 588 *p = '\0'; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: try to not raise exceptions when checking for atl thunks
by Alexandre Julliard 16 Jun '10

16 Jun '10

Markus Amsler <markus.amsler(a)oribi.org> writes: > + * Windows checks the following conditions before emulating an ATL thunk: > + * - DEP policy allows emulating > + * - thunk has memory type MEM_PRIVATE and is readable > + * - jmp func is executable > + * - thunk signature (movl, jmp) matches > + * - a "secret" flag is set: > + * The flag gets set before calling WndProc and cleared after WndProc > + * or a thunk was emulated. > + * In Windows XP SP 3 this flag is located at TEB+0xfb4. > */ Where does that information come from? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: kernel32: stop CopyFile from overwriting a file with itself
by Alexandre Julliard 16 Jun '10

16 Jun '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > + if (h2 != INVALID_HANDLE_VALUE) > + { > + BY_HANDLE_FILE_INFORMATION info2; > + if (GetFileInformationByHandle( h2, &info2 )) > + { > + if (info.dwVolumeSerialNumber == info2.dwVolumeSerialNumber && > + info.nFileIndexLow == info2.nFileIndexLow && > + info.nFileIndexHigh == info2.nFileIndexHigh) The volume serial number is not the appropriate check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior
by testbot＠testbot.winehq.org 16 Jun '10

16 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2695 Your paranoid android. === WVISTAADM (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W2K8SE (32 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000 === W7PROX64 (64 bit usp10) === usp10.c:1395: Test failed: ScriptStringFree should return E_INVALIDARG or E_FAIL not 00000000

1 0

Re: winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to close a window
by Vitaliy Margolen 16 Jun '10

16 Jun '10

On 06/15/2010 05:36 AM, Paul Chitescu wrote: > Changelog: > winex11.drv: Post a WM_SYSCOMMAND SC_CLOSE when the Window Manager asks to > close a window > + GetCursorPos( &pt ); > + PostMessageW( hwnd, WM_SYSCOMMAND, SC_CLOSE, MAKELPARAM( pt.x, pt.y ) ); You can't do that. Cursor can be anywhere, even outside Wine when WM decides to remove Wine's window. According to MSDN (which means it requires validation) you can pass either -1 or 0 for lparam here. Otherwise I think WM_SYSCOMMAN should be the correct behavior. Vitaliy.

1 0

Re: [PATCH] winspool: Return ERROR_MORE_DATA, when the app probe for the needed buffersize [BUG 19624]
by testbot＠testbot.winehq.org 16 Jun '10

16 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2686 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: propsys: mention that the functions are stubs
by James Mckenzie 15 Jun '10

15 Jun '10

Hans Leidekker <hans(a)codeweavers.com> wrote: > >On Tue, 2010-06-15 at 10:25 +0200, Francois Gouget wrote: > >> Just to confirm what André said, if the FIXME does not contain the word >> 'stub', then apistats has no way to know it's a (pseudo-)stub. > >Wouldn't it be sufficient for our purposes to just count every first >fixme in a WINAPI function as a stub? As it is now there's a large >percentage of fixmes that don't include the 'stub' keyword. > I tend to disagree. Stubs should be identified, if possible, for each call. Some calls will not activate a specific sequence of FIXMEs and in some cases, users have become confused as they don't have the technical knowledge to determine why their program is failing. > >> I would further argue that even a human reading the log would have no >> way to know as quite a few implemented functions still dump their parameters. >> So even for humans it's better to add 'stub' to the FIXME message. > >I'd say we need turn those into traces and add fixmes for the >unimplemented parts, if needed. > This actually might be better, but don't TRACES only appear if you are running in debug mode? We do want to inform our user base that a failure happened due to partially implemented code rather than give them the impression that we don't care or only implement code to make certain programs work (hacky code...) Note: This is only a statement of opinion, not a request for direction within the project. If a fixme had 'stub' that means that we have implemented code to 'fake' windows functionality, whereas a real fixme means there is a problem with the code and it needs to be corrected. James McKenzie

2 1

Re: avifil32: Update English resource
by Alexandre Julliard 15 Jun '10

15 Jun '10

Ken Sharp <kennybobs(a)o2.co.uk> writes: > @@ -50,3 +51,43 @@ STRINGTABLE DISCARDABLE > IDS_AVIFILETYPE "Wine AVI-default-filehandler" > IDS_UNCOMPRESSED "uncompressed" > } > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL > +/* Same as SUBLANG_DEFAULT */ If they are the same there's no reason to duplicate them. Also you should never submit 60 patches in one go; 10-15 is the maximum for a patch series, and that's only if you are absolutely confident that they are correct. Otherwise send only a couple until you are sure to get it right on the first try. -- Alexandre Julliard julliard(a)winehq.org

5 9

Gcov and PGO
by Peter Davies 15 Jun '10

15 Jun '10

After applying my "[RESEND 2] Changes to enable the use of gcov and PGO" patch To use gcov: Run "make EXTRACFLAGS=--coverage LDFLAGS=--coverage" Run program (presumably test suite) Run "gcov file.c" (multiple files like "gcov *.c" doesn't work for some reason) To use PGO Run "make EXTRACFLAGS=-fprofile-generate LDFLAGS=-fprofile-generate" Run sample program (test suite is inappropriate because it doesn't represent normal usage). Run "make clean" Run "make EXTRACFLAGS=-fprofile-use LDFLAGS=-fprofile-use" Peter

1 0

Re: propsys: mention that the functions are stubs
by Hans Leidekker 15 Jun '10

15 Jun '10

On Mon, 2010-06-14 at 21:26 +0200, André Hentschel wrote: > Hans might have missed that No, to me a fixme that prints a parameter list without further explanation implies that the function is a stub.

5 8

Re: [PATCH 2/2] winspool/tests: Test GetPrinterData/Ex for the printspooler
by testbot＠testbot.winehq.org 15 Jun '10

15 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2673 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [8/9] setupapi: Only extract the first MSZIP cabinet file in SetupDecompressOrExtractFile.
by Alexandre Julliard 15 Jun '10

15 Jun '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -1458,24 +1458,25 @@ static DWORD decompress_file_lz( LPCWSTR source, LPCWSTR target ) > > static UINT CALLBACK decompress_or_copy_callback( PVOID context, UINT notification, UINT_PTR param1, UINT_PTR param2 ) > { > + static int has_extracted; > + This is not reentrant. Also you need to point out which bugs these patches are fixing that justifies putting them in during code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Changes to enable the use of gcov
by James McKenzie 15 Jun '10

15 Jun '10

Peter Davies wrote: > To use gcov you must pass --coverage at both compile and link time. > This patch means that "make CFLAGS=--coverage LDFLAGS=--coverage", "make test", > "gcov file.c" is sufficient generate .gcov files. > > Peter: Somehow this patch got munged in transit and will not apply to current git. Can you update it and send it again? James McKenzie

3 2

New Wine stuff in FreeWear.org
by Ismael Barros² 15 Jun '10

15 Jun '10

Hello, We have decided to renew our offer of Wine T-shirts, as the current T-shirt has had mostly no success at all, probably because users don't feel identified nor appealed with the design. I'm attaching the pdf with our new proposals (we hope you like them!). We decided to offer the design in black garment, as in our experience it works much better. We want to be transparent, so I'm attaching also a spreadsheet with our expenses, donations and profits for each model. We usually collaborate with FOSS events, sending them stuff from our catalogue for its sale on the event. In these cases, we make a double donation: one to the organization of the event (higher, as they are in charge of the sales) and another one to the corresponding FOSS organization for the sold article. You can see the details in the spreadsheet. If you have no objection, we'll send Wine stuff to the event that require it. Currently, almost all organizations we work with have us linked from their website. This helps boosting the sales, and therefore the donations, so that everybody wins. We would be very glad if we could get a link somewhere at winehq.org, or alternatively a news item, which for us has the downside of having a limited front-page life-span, but works nonetheless. We hope you like and approve the design. Suggestions are welcome. When the design is approved, we'll upload it to our website. Kind regards, Ismael

2 2

Re: [PATCH] atl: allow additioanl struct size on 64bit and test for it
by Alexandre Julliard 15 Jun '10

15 Jun '10

Marcus Meissner <marcus(a)jet.franken.de> writes: > Testruns show that on 32bit we have 100 and 132 as struct size, > while on 64bit we have 176, 240, and also 248. > > See this page for a loop from 1..300: > https://testbot.winehq.org/JobDetails.pl?Key=2643 So why aren't you doing that loop in the final test? As it is, it doesn't really prove anything. Also please use sizeof and friends instead of hardcoded numbers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Updating the 1.2 release announcement text
by Dan Kegel 15 Jun '10

15 Jun '10

http://wiki.winehq.org/Wine1.2Announcement could use some work if anyone has time...

4 4

Re:Anotated 'make test' log
by Max TenEyck Woodbury 15 Jun '10

15 Jun '10

Thank you Dan. > What problem are you trying to solve? Curing my ignorance and rebuild my self-confidence. :) > I gather you're just plowing through the output of 'make test', > looking at each bit of noise, and trying to figure out a way > to improve the tests? Sort of. I needed a place to start, so I started at the top of the log. I expect that to change once I become more sure that I have the mechanics correct. There are several things I'm trying to do. First is to find the place where each 'bit of noise' is generated. I seem to be doing that right. Then I look at why the noise was generated and to show that I've understood why, I wrote a note on how the 'noise' could be turned off without changing the test. I labelled these 'fixup:'. I then looked at the test code and added 'Note:'s where I thought the test could be improved. > While that's a noble quest, and I'd like to encourage people > to improve the tests, it might be more productive to do so > around areas of pain for users. > For instance, you could look at bugs in bugzilla that have > patches attached that aren't committed yet because tests are > needed, and write those tests. > - Dan That sounds useful. I also have a few issues I'd like fixed too. However, it's been more than five years since I've done serious coding; things happened that destroyed my self-confidence. A little reassurance that I am not crazy and have the social skills needed to contribute to the community are what I need at the moment. - Max

1 0

Inviting users to look for regressions in wine-1.2rc3?
by Dan Kegel 15 Jun '10

15 Jun '10

How close are we to release? Maybe it'd be worth it to publicise the upcoming wine release by flogging rc3 in various news sites and getting more people to look for regressions. The thread about Wylda's statistics reminded me about http://wiki.winehq.org/PlatinumRegressionHunt We mentioned that in the first 1.0 rc announcement: http://www.winehq.org/announce/1.0-rc1 but not in http://www.winehq.org/announce/1.2-rc1 How 'bout we mention it in the rc4 release announcement and/or blogs?

8 10

Re: Two enhancement requests for winetricks
by James Mckenzie 15 Jun '10

15 Jun '10

Jan Hoogenraad <jan-winehq(a)h-i-s.nl> Jun 14, 2010 8:05 AM wrote: >OK. New version of the script: it also finds uppercase filename matches. >It also removed: > > 131072 1999-01-15 04:37 system32/MAPISTUB.DLL > 70656 2008-10-06 23:30 system32/MSVCIRT.DLL > 326656 2008-10-06 23:30 system32/MSVCRT40.DLL > 492304 2008-10-06 23:30 system32/OLEAUT32.DLL These are the files that Wine creates. You may have broken your Wine install now. OLEAUT32.DLL contains partial code that links to a file OLEAUT32.dll.so in the /usr/lib directory (or the file should be there.) James McKenzie

2 2

Re: msvcrt: Add _wmakepath_s implementation
by testbot＠testbot.winehq.org 15 Jun '10

15 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2647 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

RFC: Standardize paths in shell32.SHChangeNotify [Bug 18606]
by Andrew Eikum 14 Jun '10

14 Jun '10

Hey folks, I have a fix here for bug 18606. I think it's decent, but I could use another few sets of eyes to make sure I didn't miss anything, or even that I'm not way on the wrong track. The problem and solution are described in patch 3. In brief, SHChangeNotify notifies windows when a change to the filesystem occurs that the window asked to be notified about. For example, a window might tell SHChangeNotifyRegister "Inform me about changes to C:\". Bug 18606 occurs because the new directory is passed to SHChangeNotify as '/home/user/.wine/drive_c/New Directory', which doesn't match the IDList created for 'C:\'. This patchset fixes that by converting all paths in SHChangeNotify to UNIX paths, resolving symlinks etc, and comparing the ID lists created from those paths. That way, the paths being compared are standardized and compared fairly. Unfortunately, this is hard to write tests for. You'd have to make an ID list that is significantly different from the one SHChangeNotifyRegister will create, but that actually refers to the same directory. This is easy in Wine, but less obvious in Windows. Suggestions for how to accomplish this are welcome. Logically, though, I think the problem and solution make sense. Please take a look. Any feedback is appreciated. Andrew

1 0

Portuguese translations of Wine back at 100%
by Paul Vriens 14 Jun '10

14 Jun '10

Hi, Just a note to thank Ricardo for getting the Portuguese translations back to 100%. -- Cheers, Paul.

1 0

Polish translations of Wine at 100%
by Paul Vriens 14 Jun '10

14 Jun '10

Hi, Łukasz did it, Polish translations of Wine reached the 100% mark !!! Great job done. -- Cheers, Paul.

1 0

Make depend
by Peter Davies 14 Jun '10

14 Jun '10

How often do I need to run "make depend"? Peter

4 4

Re: mshtml: Check if event_table entry is allocated before using it in remove_event_handler.
by testbot＠testbot.winehq.org 14 Jun '10

14 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2632 Your paranoid android. === W2K3R2SESP2 (32 bit events) === events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -89 events.c:847: Test failed: clientY = -89 events.c:847: Test failed: offsetY = -91 events.c:847: Test failed: screenY = 0 === W7PRO (32 bit events) === events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -155 events.c:847: Test failed: clientY = -155 events.c:847: Test failed: offsetY = -157 events.c:847: Test failed: screenY = 0 === W7PROX64 (32 bit events) === events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: y = -80 events.c:847: Test failed: clientY = -80 events.c:847: Test failed: offsetY = -82 events.c:847: Test failed: screenY = 0 === W7PROX64 (64 bit events) === events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0 events.c:847: Test failed: x = -33 events.c:847: Test failed: y = -205 events.c:847: Test failed: clientX = -33 events.c:847: Test failed: clientY = -205 events.c:847: Test failed: offsetX = -35 events.c:847: Test failed: offsetY = -207 events.c:847: Test failed: screenY = 0

1 0

Re: [2/2] msi: Add tests for MsiLocateComponent and make them pass.
by testbot＠testbot.winehq.org 14 Jun '10

14 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2626 Your paranoid android. === W7PROX64 (32 bit msi) === msi.c:1622: Test failed: Expected C:\imapath, got msi.c:1629: Test failed: Expected C:\imapath, got msi.c:1648: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1649: Test failed: Expected C:\imapath, got msi.c:1650: Test failed: Expected 10, got 260 msi.c:1655: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1656: Test failed: Expected C:\imapath, got msi.c:1657: Test failed: Expected 10, got 260 msi.c:1666: Test failed: Expected C:\imapath, got msi.c:1672: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1673: Test failed: Expected C:\imapath, got msi.c:1674: Test failed: Expected 10, got 260 msi.c:1712: Test failed: Expected C:\imapath, got msi.c:1719: Test failed: Expected C:\imapath, got msi.c:1738: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1739: Test failed: Expected C:\imapath, got msi.c:1740: Test failed: Expected 10, got 260 msi.c:1745: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1746: Test failed: Expected C:\imapath, got msi.c:1747: Test failed: Expected 10, got 260 msi.c:1756: Test failed: Expected C:\imapath, got msi.c:1762: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1763: Test failed: Expected C:\imapath, got msi.c:1764: Test failed: Expected 10, got 260 msi.c:1822: Test failed: Expected C:\imapath, got msi.c:1829: Test failed: Expected C:\imapath, got msi.c:1848: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1849: Test failed: Expected C:\imapath, got msi.c:1850: Test failed: Expected 10, got 260 msi.c:1855: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1856: Test failed: Expected C:\imapath, got msi.c:1857: Test failed: Expected 10, got 260 msi.c:1866: Test failed: Expected C:\imapath, got msi.c:1872: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1873: Test failed: Expected C:\imapath, got msi.c:1874: Test failed: Expected 10, got 260 msi.c:1931: Test failed: Expected C:\imapath, got msi.c:1937: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:1938: Test failed: Expected C:\imapath, got msi.c:1939: Test failed: Expected 10, got 260 msi.c:1948: Test failed: Expected C:\imapath, got msi.c:1954: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:1955: Test failed: Expected C:\imapath, got msi.c:1956: Test failed: Expected 10, got 260 msi.c:2008: Test failed: Expected C:\imapath, got msi.c:2014: Test failed: Expected INSTALLSTATE_ABSENT, got -1 msi.c:2015: Test failed: Expected C:\imapath, got msi.c:2016: Test failed: Expected 10, got 260 msi.c:2025: Test failed: Expected C:\imapath, got msi.c:2031: Test failed: Expected INSTALLSTATE_LOCAL, got -1 msi.c:2032: Test failed: Expected C:\imapath, got msi.c:2033: Test failed: Expected 10, got 260 msi.c:2129: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2147: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2162: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2177: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2195: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2224: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2242: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2257: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2272: Test failed: Expected {B17945B9-5F97-4738-B874-FF7B552A1E25}, got prod msi.c:2290: Test failed: Expected {5CB8DCA4-4B34-40D5-AD1E-9874BCA53203}, got prod msi.c:2371: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2377: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2401: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2408: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2442: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3}, got msi.c:2471: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:2478: Test failed: Expected {28BC538F-96F5-498D-8DAC-CA47778052B3} or {688EC092-AFAC-4069-BD8E-9888B886BB64}, got msi.c:7467: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7536: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7603: Test failed: Expected "{42EEE0BE-35DA-4E3C-B4C0-646658D66EBD}", got "C:\winetest\\winetest.msi" msi.c:7827: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7829: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7888: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7906: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7924: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7926: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7942: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7944: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7961: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7963: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7982: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:7984: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8001: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8003: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8119: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8121: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8166: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8168: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:8192: Test failed: Expected "{506C84C3-1FD0-41C9-AD55-E907E5853A10}", got "apple" msi.c:8194: Test failed: Expected "{8EE2D442-E6F5-4A24-82B6-CBCE22D79720}", got "banana" msi.c:7827: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7829: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7888: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7906: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7924: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7926: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7942: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7944: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7961: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7963: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7982: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:7984: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8001: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8003: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8119: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8121: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8166: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8168: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:8192: Test failed: Expected "{20EA3E76-0D37-42E6-A81D-9D437781F133}", got "apple" msi.c:8194: Test failed: Expected "{DFD373CA-1A2D-4D20-93BB-BF8DC5332E4D}", got "banana" msi.c:7827: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7829: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7888: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7906: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7924: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7926: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7942: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7944: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7961: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7963: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:7982: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:7984: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8001: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8003: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8119: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8121: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8166: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8168: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8192: Test failed: Expected "{DEDA6F64-216E-4BFC-9CAE-1CD6DD94AA4D}", got "apple" msi.c:8194: Test failed: Expected "{E57CD40C-D6FA-4BDA-B5E6-00C195BB9BD1}", got "banana" msi.c:8445: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8447: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8567: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8569: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8614: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8616: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8640: Test failed: Expected "{6DDBA159-7933-4C1D-A414-1D347F9F08DE}", got "apple" msi.c:8642: Test failed: Expected "{7FF6476B-04D5-46D3-8ED7-64D5FAEBE790}", got "banana" msi.c:8445: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8447: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8567: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8569: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8614: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8616: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8640: Test failed: Expected "{90700551-3020-46AD-BDD2-738598196B87}", got "apple" msi.c:8642: Test failed: Expected "{DD5EF5C4-6492-445B-8B43-BBFACAF50296}", got "banana" msi.c:8937: Test failed: Expected patchcode to be unchanged, got {2B8A9453-54F5-4090-A3A4-951258440C67} msi.c:8939: Test failed: Expected targetprod to be unchanged, got {A549CAF1-986B-4834-AD1A-3744EFAB33EC} msi.c:9008: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9010: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9053: Test failed: Expected "{2B8A9453-54F5-4090-A3A4-951258440C67}", got "apple" msi.c:9055: Test failed: Expected "{A549CAF1-986B-4834-AD1A-3744EFAB33EC}", got "banana" msi.c:9599: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9642: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple" msi.c:9819: Test failed: Expected "{0E189282-7F89-4A0B-9747-4B16E8942EE5}", got "apple"

1 0

Re: [PATCH] atl: Do not fail on Wine64
by Maarten Lankhorst 14 Jun '10

14 Jun '10

Hi Marcus, 2010/6/13 Marcus Meissner <marcus(a)jet.franken.de>: > Hi, > > The size is 248 on Wine64 ... (expected 240), so we miss > perhaps a pointer or some alignment. > > Its not fully clear what. > > It at least does not crash when ignoring the size change. Seems wrong to me, does it allow size 240 on 64-bits, or does it allow 248 only? ~Maarten

3 2

RE: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()
by Greg Geldorp 14 Jun '10

14 Jun '10

> From: Reece Dunn <msclrhd(a)googlemail.com> > > msxml3 is not present on NT4, so CLSID_XMLHTTPRequest is not > registered. This does not fail on the test page, as the msxml3 tests > are skipped when msxml3.dll is not present. > > It would probably be better to issue a win_skip in this instance, but > it is not relevant to your change. TestBot uses a different algorithm to check if a test should be skipped. Winetest.exe checks the name of the test and obtains the name of the DLL being tested from that (msxml3_test.exe => msxml3.dll). If that DLL is not present, winetest.exe skips the test. TestBot checks the import table of the test executable, and if any of the statically imported DLLs are missing it skips the test. In this case, msxml3.dll is not statically linked, so it will not be skipped by TestBot on NT4. TestBot should probably check the test name too. Ge.

1 0

Two enhancement requests for winetricks
by Joerg-Cyril.Hoehle＠t-systems.com 14 Jun '10

14 Jun '10

Hi, Jan Hoogenraad wrote: >Each debugging request for wine states that I should remove all winetricks. AppDB should request something similar: minimal use of winetricks. >However I have no way to tell, and no way to safely remove them. IMHO one solution to your problem is to learn to use different .wine prefixes. Both developers and AppDB users want a repeatable process to make the app run (or crash). If you install all your software into a single .wine hierarchy (like you'd do on MS-Windows), then you cannot tell anyone what you did to make the app work in Wine. All you have is "I started with Wine-0.9.48, upgraded to wine-1.1.6 at some time, now to wine-1.2rc2, used "winetricks X" and Y, perhaps I used "winetricks directx" but I can't remember for sure, I installed apps A, B and C (they may have installed more components) and I edited the registry a few times. Given all that, app Z works fine in on my machine." This is a mess much like a typical MS-Windows installation. With Wine, you can do better than that. What people want to hear from you is as follows: - Create a fresh .wine prefix with wine-X.Y; - Install Indeo Video codecs via "winetricks indeo" because I found out that the app expects them but does not install them itself; - Install the app from CD; - From a DirectX install into a separate .wine-* prefix, solely copy d3dx9_36.dll into system32/ (or the app's directory) - Change setting Y in winecfg, e.g. native d3dx9_36; - App Z works (or crashes like that ...). That is a minimal instruction set. I have like a dozen .wine-* directory hierarchies. I never use .wine itself except for regression testing, such that I can rm -rf ~/.wine and create a fresh one at any time. That's why I don't need an uninstaller. rm -rf ~/.wine-xyz or rm -rf ~/wineapps/... *is* the uninstaller (.wine-xyz/drive_c/Programs/Apps/ symlinks to $HOME/wineapps such that the apps live independently on a particular .wine prefix). Regards, Jörg Höhle

3 2

Re: [PATCH 4/6] shdocvw: Silence QueryService traces in non-interactive runs.
by testbot＠testbot.winehq.org 14 Jun '10

14 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2620 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2479: Test failed: CoCreateInterface failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === Timeout === W2K8SE (32 bit webbrowser) === webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:1216: Test failed: unexpected call UpdateUI webbrowser.c:295: Test failed: unexpected nsCmdID 21 webbrowser.c:239: Test failed: unexpected call QueryStatus_STOP webbrowser.c:295: Test failed: unexpected nsCmdID 28

1 0

Re: msxml3: Avoid SysStringLen() testing for an empty string in ::createNode()
by testbot＠testbot.winehq.org 13 Jun '10

13 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2617 Your paranoid android. === WNT4WSSP6 (32 bit domdoc) === domdoc.c:2743: Test failed: CoCreateInstance(CLSID_XMLHTTPRequest) should have succeeded instead of failing with 0x80040154

3 2

Re: [1/4] Riched20:Moved-code-to-update-wrap-position-to-ME_WrapTextParagraph
by Austin English 13 Jun '10

13 Jun '10

On Sun, Jun 13, 2010 at 1:02 PM, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > This is patch 1/4 to implement EM_FORMATRANGE. This patch does not change > any of the code but moves code from ME_WrapMarkedParagraphs to > ME_WrapTextParagraph. > > The bug report #6254, which this is a solution to is marked as needed for > Wine 1.2 > > Thanks to Dylan Smith who helped segegrate and clean up the original code > proposed by Tony Rollo and further worked on by Lei Zhang and myself. You forgot the patch. -- -Austin

2 1

Re: msi: Print more information on error
by Alexandre Julliard 13 Jun '10

13 Jun '10

André Hentschel <nerv(a)dawncrow.de> writes: > i had that case with > err:msi:ACTION_CallDllFunction GetProcAddress for function L"findApplications" in dll L"C:\\users\\dawncrow\\Temp\\msi94eb.tmp" failed > so you see that just the function is not info enough. I don't see that. The name of the temp file is not meaningful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Anotated 'make test' log
by Max TenEyck Woodbury 13 Jun '10

13 Jun '10

I'm trying to get a start on helping with wine development. I'm still in the process of reading the developer's guide, and I think I am making progress on that. As a test of my understanding, I started to annotate the output of 'make -k test'. I'd like your opinion on the usefulness of this. A few reservations: * I started from the top of the log. If I continue, I will be selecting sections that I find interesting. * I am not going to produce patches until someone says that the annotations are going in the right direction. This will change when I become more familiar with the community's opinion of my efforts. ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so cred.c && touch cred.ok Note: This test is expected to produce 2 error reports call is pCredReadA(TEST_TARGET_NAME, -1, 0, &cred) implementation at dll/advavi32/cred.c - CredReadA parameter names: TargetName, Type, Flags, *Credentials conversion to CreadReadW implementation at same - CredReadW fixme:cred:CredReadW unhandled type -1 Fixup: Convert 'if (Type != CRED_TYPE_GENERIC && Type != CRED_TYPE_DOMAIN_PASSWORD)' to a switch(case?) with all known types enumerated. Put unimplemented types at the end with a 'fixup' then fall through to the default case which sets the error code and fails. Note: In other words, don't request fixup for improper type codes. call is pCredReadA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef, &cred) see above for details fixme:cred:CredReadW unhandled flags 0xdeadbeef Fixup: Get a list of all known flags. Build a mask for all of them. Check for any unknown flags set and issue a warning if there are any. Build a mask of all implemented flags (currently none) and issue a fixme if any of those are set. Note: In other words, don't request fixup for undefined flags set. Question: Should this be an failure exit? Alternatively, should there be a list of flags that, if set trigger a failure exit? Note: Only fail if the flags indicate an option that can not be ignored. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredWriteA(&new_cred, 0) implementation at same - CredWriteA parameter names: Credential, Flags new_cred.UserName = 'winetest' new_cred.TargetName = TEST_TARGET_NAME conversion to CredWriteW implementation at same - CredWriteW err:cred:CredWriteW bad username L"winetest" Note: This is an expected error. Note: Should it mention 'syntax' since it is checking for \ and @? Note: No bad flags test - Fixup per CredReadW above. Note: No bad type test - Fixup per CredReadW above. call is pCredWriteA(&new_cred, 0) see above for details. new_cred.UserName = NULL err:cred:CredWriteW bad username (null) Note: This is an expected error. Note: No sucess tests. Note: Possible memory leak of returned credentials buffers? call is pCredDeleteA(TEST_TARGET_NAME, -1, 0) implementation at same - CredDeleteA parameter names: TargetName, Type, Flags conversion to CredDeleteW fixme:cred:CredDeleteW unhandled type -1 Fixup: see CredReadA above call is pCredDeleteA(TEST_TARGET_NAME, CRED_TYPE_GENERIC, 0xdeadbeef) se above for details. fixme:cred:CredDeleteW unhandled flags 0xdeadbeef fixup: see CreadReadA above Note: No sucess tests. Note: Test order is questionable. A better order would be Write, Read then Delete with tests that are expected to succeed added. call is pCredReadDomainCredentialsA(&info, 0, &count, &creds implementation at same - CredReadDomainCredentialsA parameter names: TargetInformation, Flags, *Size, **Credentials conversion to CredReadDomainCredentialsW fixme:cred:CredReadDomainCredentialsW (0x15ddf8, 0x0, 0x33fd18, 0x33fc4c) stub Fixup: No suggestion

1 0

re: WINE and demoscene products
by Dan Kegel 12 Jun '10

12 Jun '10

Yeah, that's pretty cool. I ran Lifeforce as a demo at several talks last year, it was very convincing. (Although, frankly, running retail DVD-ROM games on day of beta or release is an even more convincing feat if we can pull it off.) As somebody else pointed out, there are already appdb entries for quite a few demos: http://appdb.winehq.org/objectManager.php?sClass=category&iId=95 It'd be nice if someone filled in any missing ones there. (I'm not sure how much overlap there is between demos and real games, but the idea of a really small graphical app is appealing, one would expect they'd be easier to diagnose?) - Dan

2 1

Three year sever outstanding bug requiring minor fix
by velociraptor Genjix 12 Jun '10

12 Jun '10

Hey, Please look into this issue, http://bugs.winehq.org/show_bug.cgi?id=15118 It seems like a fairly trivial fix which renders this application useless. A detailed description of the implementation needed is provided in that ticket. Thank you _________________________________________________________________ http://clk.atdmt.com/UKM/go/197222280/direct/01/ Do you have a story that started on Hotmail? Tell us now

5 4

snoop,relay,trace
by Hin-Tak Leung 12 Jun '10

12 Jun '10

I am thinking of going barbaric and doing WINEDEBUG=+relay,+snoop,+trace to see how mt.exe get the wrong image size in http://bugs.winehq.org/show_bug.cgi?id=22812 and just grep for the wrong/right sizes (0x "2b000", "176128", 0x "2b200", "176640" ) to see where mt gets it from but none turn up. Since it is a relatively simple command line I thought that would work. or is there any other WINEDEBUG= is worth trying? Also I am thinking since the image size is normally padded to 0x1000, (and it says so), so a PE with an image size that looks like NNNNN200 is automatically wrong, is that correct?

1 0

WINE and demoscene products
by Wolfram Sang 12 Jun '10

12 Jun '10

Hi, demos [1] from the demoscene are pretty demanding and freely available stresstests, especially for everything 3D-related. The size-optimized productions (4KB, 64KB) might also exploit some lesser known side effects of bringing up a program. A review of running the most popular demos with wine 1.2-rc2 was recently posted here [2]. Out of 25, 14 are flawless and 4 OK - pretty good numbers IMO. (BTW the demos can be downloaded using the search function of the website.) Regards, Wolfram [1] http://en.wikipedia.org/wiki/Demo_%28computer_programming%29 [2] http://pouet.net/topic.php?which=7400

1 0

Test suite success rate
by Peter Davies 11 Jun '10

11 Jun '10

How do I get the test suite to report it success rate (as a whole) in a "%d tests executed (%d marked as todo, %d %s), %d skipped.\n" style. Peter

3 2

Re: gdi32: Add CreateFontIndirectEx implementation (try2)
by Alexandre Julliard 11 Jun '10

11 Jun '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > try2: function body moved to *Ex call, and CreateFontIndirect use it. You should also print FIXMEs if the ignored data is used by the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

No test summary line found
by GOUJON Alexandre 11 Jun '10

11 Jun '10

Hi, I'm wondering if my patch (62325) hasn't been reviewed yet or if you expect a strict error-free patch. Indeed, http://source.winehq.org/patches/data/62325.testfail shows a "No test summary line found" for WNT4WSSP6. If it's an issue, how to fix it ? Thanks

2 6

Re: [PATCH 2/5] include: Add IEnumShellItems interface declaration.
by Huw Davies 11 Jun '10

11 Jun '10

On 11 Jun 2010, at 12:17, David Hedberg <david.hedberg(a)gmail.com> wrote: > --- > dlls/actxprxy/usrmarshal.c | 21 +++++++++++++++++++++ > include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+), 0 deletions(-) > > diff --git a/dlls/actxprxy/usrmarshal.c b/dlls/actxprxy/usrmarshal.c > index f2aacf8..85e534c 100644 > --- a/dlls/actxprxy/usrmarshal.c > +++ b/dlls/actxprxy/usrmarshal.c > + > +HRESULT CALLBACK IEnumShellItems_Next_Proxy( > + IEnumShellItems *This, > + ULONG celt, > + IShellItem **rgelt, > + ULONG *pceltFetched) > +{ > + TRACE("(%p)\n", This); > + return IEnumShellItems_RemoteNext_Proxy( This, celt, rgelt, > pceltFetched ); > +} pceltFetched could be a NULL ptr here, so you should pass the address of a local variable in that case. See ole32/usrmarshal.c for examples on how to marshal IEnum*_Next Huw.

1 0

Re: Updating Ukrainian translations to kernel32
by Dmitry Timoshkov 11 Jun '10

11 Jun '10

Igor Paliychuk <igor-hkr(a)mail.ru> wrote: > Updating Ukrainian translations to kernel32(ukr.nls). > file : ukrainian-kernel32-ukr-nls.patch You forgot to mention what's wrong with current ukr.nls. -- Dmitry.

2 1

Re: gdi32: CreateFontIndirectEx implementation on top of CreateFontIndirect
by Alexandre Julliard 11 Jun '10

11 Jun '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From fb4317a2a39475c225fe04946795892c4891cd26 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Fri, 11 Jun 2010 01:42:06 +0400 > Subject: [PATCH] CreateFontIndirectEx implementation on top of CreateFontIndirect It should of course be the other way around. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access()
by Andrew Nguyen 11 Jun '10

11 Jun '10

On Sun, Jun 6, 2010 at 2:50 AM, Austin English <austinenglish(a)gmail.com> wrote: > See http://bugs.winehq.org/show_bug.cgi?id=23003 > > -- > -Austin > > > > You should probably drop the snd_pcm_hw_params_get_access argument check, both because it's not the function that's being tested, and because, as far as I can tell from the alsa-lib git repo, the prototype for the function has never changed.

3 5

IDL trouble (patch: adding IEnumShellItems interface declaration.)
by David Hedberg 11 Jun '10

11 Jun '10

Hello everyone, I'm having some trouble with this simple patch. Specifically, it breaks compiling of dlls/actxprxy, producing the message: ***** ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -fasynchronous-unwind-tables -shared ./actxprxy.spec usrmarshal.o actxprxy_activscp_p.o actxprxy_comcat_p.o actxprxy_docobj_p.o actxprxy_hlink_p.o actxprxy_htiframe_p.o actxprxy_objsafe_p.o actxprxy_ocmm_p.o actxprxy_servprov_p.o actxprxy_shobjidl_p.o actxprxy_urlhist_p.o dlldata.o -o actxprxy.dll.so -luuid -loleaut32 -lole32 -lrpcrt4 -lkernel32 -lntdll ../../libs/port/libwine_port.a -L/usr/local/valgrind-svn/lib actxprxy_shobjidl_p.o: In function `IEnumShellItems_RemoteNext_Stub': /home/david/Projects/wine/git/dlls/actxprxy/actxprxy_shobjidl_p.c:6507: undefined reference to `IEnumShellItems_Next_Stub' actxprxy_shobjidl_p.o:(.data.rel.ro+0xf0): undefined reference to `IEnumShellItems_Next_Proxy' ***** It compiles if I remove the [call_as] attribute, but I guess that would kind of break the interface. Any obvious mistakes in the patch, or grammar not supported by widl? Thanks, David --- include/shobjidl.idl | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/include/shobjidl.idl b/include/shobjidl.idl index 6bd0244..97cd82f 100644 --- a/include/shobjidl.idl +++ b/include/shobjidl.idl @@ -385,6 +385,36 @@ typedef enum tagNWMF { } NWMF; /***************************************************************************** + * IEnumShellItems interface + */ +[ + object, + uuid(70629033-E363-4A28-A567-0DB78006E6D7), + pointer_default(unique) +] +interface IEnumShellItems : IUnknown +{ + [local] HRESULT Next( + [in, annotation("__in")] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched), annotation("__out_ecount_part(celt, *pceltFetched)")] + IShellItem **rgelt, + [out, annotation("__out_opt __deref_out_range(0, celt)")] ULONG *pceltFetched); + + [call_as(Next)] HRESULT RemoteNext( + [in] ULONG celt, + [out, size_is(celt), length_is(*pceltFetched)] IShellItem **rgelt, + [out] ULONG *pceltFetched); + + HRESULT Skip( + [in] ULONG celt); + + HRESULT Reset(); + + HRESULT Clone( + [out] IEnumShellItems **ppenum); +} + +/***************************************************************************** * FOLDERSETTINGS */ typedef char *LPVIEWSETTINGS; -- 1.7.1

2 1

Re: Three year sever outstanding bug requiring minor fix
by James Mckenzie 11 Jun '10

11 Jun '10

velociraptor Genjix <aphidia(a)hotmail.com> wrote at Jun 9, 2010 8:52 AM > >Hey, >Please look into this issue, >http://bugs.winehq.org/show_bug.cgi?id=15118 >It seems like a fairly trivial fix which renders this application useless. A detailed >description of the implementation needed is provided in that ticket. If it were a 'trival' fix, it would have been a long time ago. Something that looks, on the surface, to be simple, maybe very complex. For instance, I have been working on a fix for one function in the richedit area has taken over four years. Now as to your concern, tough. This project, for the most part is volunteer. So, if you want it fixed, do it yourself or find someone who can. Otherwise, you'll have to wait for someone to come by, find this interesting and then fix it. There is a part of the project that is paid, and they work for a company called CodeWeavers. Maybe they have found a fix and incorporated it into their product line. That you'll have to pay for. Remember, we fix things as WE find the time and the incorporation process is very strict. This takes time and some folks will pick up a project, only to set it down because they become busy with other things in life or they just don't have the tenancity to see it through. James McKenzie

2 1

Re: [1/3] d3dx9: Allow sampler declaration without sampler type.
by Stefan Dösinger 11 Jun '10

11 Jun '10

Am 10.06.2010 um 16:06 schrieb Matteo Bruni: > <0001-d3dx9-Allow-sampler-declaration-without-sampler-type.txt> The patch looks ok, but I am wondering if the validator complains about typeless samplers. And if not, I guess the interesting question is how those declarations are treated at shader runtime...

3 4

Re: resources: Convert Polish resources to UTF8.
by Frédéric Delanoy 11 Jun '10

11 Jun '10

Hi. I see this patch has been "Rejected" in http://source.winehq.org/patches/, but I just wondered why: - are the UTF8 resources not preferred over custom codepages? - or is the patch simply too big to review? Splitting into many tiny patches seemed a bit overkill for such a simple change, no? Or maybe is it simply because Polish translations is still in progress, and it can/will cause conflict? I'm a bit confused here... Frédéric NB: I didn't touch any nls file in this patch so it shouldn't cause regressions (and had a subset of it tested by Łukasz Wojniłowicz, a native Polish speaker)

5 5

Tests crash
by Peter Davies 11 Jun '10

11 Jun '10

Some tests crash for me (eg. http://bugs.winehq.org/show_bug.cgi?id=22903 segfaults). This means I can't run the entire test suite with "make test", what should I do? Peter

3 2

Re: [PATCH] ntdll: Show one-time ERR if NOFILE limit is reached.
by Octavian Voicu 11 Jun '10

11 Jun '10

Forgot to mention, this fixes http://bugs.winehq.org/show_bug.cgi?id=19861. Octavian

2 3

size_t usage in wine
by Marko Nikolic 11 Jun '10

11 Jun '10

Hi, I have found in wine documentation that it is recommended to avoid long data type, since it is different in Win64 and Unix64. This is reasonable, however, is there some similar policy regarding size_t/ssize_t usage? Those types are often defined as long type, so they could produce the same problem with 64 bit. On the other hand, many standard functions expect or return size_t values, so I guess it could be ok to use it in such cases. Is there any advice/position on this? Thanks, Marko

2 1

"IWineGDISurfaceImpl_UnLoad: Please report to wine-devel"
by Marcin Baczyński 10 Jun '10

10 Jun '10

Hi, running a simple game on wine-1.2-rc2-250-g950919e fails with "Interface not supported" message box and following messages in the terminal: $ ./wine ~/.wine/drive_c/Program\ Files/MarBit/Clicks/clicks.exe fixme:dsalsa:IDsDriverBufferImpl_SetVolumePan (0x146740,0x146b78): stub fixme:win:EnumDisplayDevicesW ((null),0,0x32f480,0x00000000), stub! fixme:d3d:swapchain_init Add OpenGL context recreation support to context_validate_onscreen_formats err:d3drm:IDirect3DRMImpl_QueryInterface (0x135678)->({4516ecc8-8f20-11d0-9b6d-0000c0781bc3},0x5a2e90),not found err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): UnLoad is not supported on X11 surfaces! err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): Most likely the parent library did something wrong. err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x137d70): Please report to wine-devel fixme:d3d:IWineD3DDeviceImpl_Release (0x1e7a20) Device released with resources still bound, acceptable but unexpected fixme:d3d:IWineD3DDeviceImpl_Release Leftover resource 0x137d70 with type WINED3DRTYPE_SURFACE (0x1). The game can be downloaded here: http://marbit.com.pl/index.php?name=Downloads&req=getit&lid=1 Installation fails saying that it cannot create a shortcut, but the files get copied to the destination directory. Thanks, Marcin

1 0

Re: winefile: Update English resource for AUS, NZ and UK
by Michael Stefaniuc 10 Jun '10

10 Jun '10

Hello Ken, Ken Sharp wrote: > Australian, British and New Zealand English prefers -ise over -ize > (strongly so in Aus and NZ). > > http://en.wikipedia.org/wiki/En-AU#Spelling > http://en.wikipedia.org/wiki/New_Zealand_English#Spelling if the translation is the same for UK, AU and NZ then please add only one copy of it and mark it as LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL That will do as the LANG_ENGLISH family will inherit first from SUBLANG_NEUTRAL and only if that doesn't exist from SUBLANG_DEFAULT. thanks bye michael

1 0

A Handle Cache?
by Max TenEyck Woodbury 10 Jun '10

10 Jun '10

While Reading the developer's guide, I noticed that it said that translating windows' handles was always done by the server. I may have misunderstood this. Since interaction between the client and server requires at least two context switches and context switches are fairly heavy duty operations, would it make sense to cache handle lookups on the client?

2 1

gameux.dll implementation stub
by Mariusz Pluciński 09 Jun '10

09 Jun '10

Hello As you maybe know, I'm working on implementation of Game Explorer in the Google Summer of Code. Main part of my work is now implementing gaming APIs stored in gameux.dll library. I already sent patches with headers, and I'm currently in the stage when stubs are ready to start real implementation. Unfortunately (for me) Wine is now in freeze stage, so I can't send patches with new library to wine-patches. Instead, Vincent Povirk suggested me to send them here to get feedback. It's very important to me to know is my way of implementation valid, cause changing something now is probably easier than modifying it in future. Attached patches creates initial implementation of gameux library, adds implementation of IClassFactory interface and stubs of four interfaces' implementations: IGameExplorer, IGameExplorer2, IGameStatistics and IGameStatisticsMgr. They also add initial tests for each interface. Each test now checks behavior of CoCreateInstance function while trying to create given interface. To create library, I used parts of code created by Alistair Leslie-Hughes, attached by him to bug 21261. Thanks in advance

3 2

Call for translators
by Paul Vriens 09 Jun '10

09 Jun '10

Hi, The code freeze for Wine-1.2 has started and we are now in a weekly release candidate cycle. This is an ideal moment for translation work. The current translations status page http://source.winehq.org/transl/index.php shows four (4) languages at a 100%. Please help us have more fully translated languages for Wine-1.2. Also fixing the errors in the translations (21 languages affected) would be greatly appreciated. Most translators are not programmers and are probably intimidated by Wine's translation system. If you are comfortable editing resource file than please go ahead, create patches and sent them to wine-patches. The wiki-page http://wiki.winehq.org/Translating gives some more background information if needed. If you like to help out Wine but don't want to touch any of these resource files we can help you out. Please sent us an email with the language you'd like to translate Wine into and we will sent you the more familiar po files. These files show all the translatable strings from a resource file but in a less intriguing format. Once translated, you can sent these files back and we will turn them into the proper resource files. 'We' for now are Michael Stefaniuc and Paul Vriens but I guess others will chime in if needed. -- Cheers, Paul.

7 21

Re: Change a malloc() to a HeapAlloc()
by Peter Davies 09 Jun '10

09 Jun '10

> We use real names here. This patch probably will not be committed until it > is resubmitted. Ops! I've mis-configured my mail client > The patch is also wrong. Why? What difference does malloc() over HeapAlloc() make? (this is arguably a case for not sending the patch in the first place) There is nothing that bugs me more than not being told why I'm wrong. Peter

3 2

Re: [PATCH] [WinHelp]: implemented ExecFile macro (fix for #23054)
by Alexandre Julliard 09 Jun '10

09 Jun '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > +static void CALLBACK MACRO_ExecFile(LPCSTR pgm, LPCSTR args, LONG cmd_show, LPCSTR topic) > { > - WINE_FIXME("(\"%s\", \"%s\", %u, \"%s\")\n", str1, str2, u, str3); > + static HINSTANCE (WINAPI *shell_exec)(HWND, LPCSTR, LPCSTR, LPCSTR, LPCSTR, INT); > + HINSTANCE ret = 0; > + > + WINE_TRACE("(\"%s\", \"%s\", %u, \"%s\")\n", pgm, args, cmd_show, topic); > + if (!shell_exec) > + { > + HANDLE h; > + > + if ((!(h = GetModuleHandle("shell32.dll")) && !(h = LoadLibraryA("shell32.dll"))) || > + !(shell_exec = (void*)GetProcAddress(h, "ShellExecuteA"))) > + { > + WINE_ERR("Couldn't load shell32.ShellExecute\n"); > + } > + } Why not call ShellExecuteA directly? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: How to change text on winehq.org ?
by Marco Meijer 09 Jun '10

09 Jun '10

Hi WineDevs, I made the patch to change the text on winehq and sent it to wine-patches but still no change. Do I have to do something else ? link to patch: http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html kind regards, Marco Meijer http://www.winehq.org/pipermail/wine-patches/2010-May/088377.html Op 6-5-10 17:57, James Mckenzie schreef: >> Hi WineDevs, >> >> If make the packages for mandriva on sourceforge. And the text on the >> download page on the website (winehq,org) for mandriva is getting old. >> Who can I write a mail to change the text ? I already tried web-admin ad >> winehq.org some weeks ago but no reaction so far. >> >> > The source code for winehq is available. You then make the changes you feel are necessary to the source code, create a difference file and submit this to wine-patches. > > Are you familiar with this process? > > James McKenzie > > >

2 1

Re: [1/3] msi: Create directories right before installing files.
by testbot＠testbot.winehq.org 09 Jun '10

09 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2538 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5408: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5427: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5452: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5471: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8261: Test failed: RegQueryValueExA failed 2 (0) install.c:9173: Test failed: got 6 expected 0 install.c:9179: Test failed: got 6 expected 0 install.c:9182: Test failed: got 6 expected 0 install.c:9184: Test failed: file removed install.c:9329: Test failed: key not created

1 0

wine in the news in spain
by Dan Kegel 09 Jun '10

09 Jun '10

Saw this just now: http://www.osor.eu/news/es-zaragozas-move-to-complete-open-source-desktop-g… "Zaragoza's move to complete open source desktop going to plan by Gijs Hillenius — published on Jun 08, 2010 The move by the city of Zaragoza to an open source desktop is making good progress. All of the city's civil servants now use open source tools including Thunderbird, VLC, Firefox and OpenOffice. And this year some seven hundred of the city's 2800 desktop PCs will have seen their proprietary operating system replaced by the Linux open source alternative. ... "It is not possible to move all applications to the open source platform. For example tools for Computer Aided Design and Optical Character Recognition, can't be replaced by open source alternatives. But proprietary and open source software can live together. And if we really can't find an open source option, we resort to Virtualbox and Wine to provide users their proprietary application." ... Their web site does mention a bit about wine, too: http://zaragozaciudad.net/azlinux/2009/septiembre.php (autotranslated): "24/09/2009 How we use WINE ... Microsoft Access: Access we have hundreds of applications that lack of time and means we can not migrate to an Open Source environment. WINE can emulate many of them even though the code should be reviewed, compiled and compacted again. A particular case is still unresolved are the Access applications that generate a mail merge with Word documents. OCR: for now we have not found an efficient alternative to the use of OCR software that "emulate" Windows OCR software with WINE Transactional environment: the client for our transactional environment is old and only works for Windows environments so that the use of WINE has been indispensable In contrast we must also say that some applications could not be emulated with WINE as Presto or Nokia PC Suite. So far WINE has not been useful to emulate CAD applications. In conclusion we can say that WINE is a useful tool in some cases and allows us to move forward in the migration to Open Source environment as alternatives to proprietary software are available and the height of these." Hmm, I wonder what "Presto" is, and which CAD suites they use. - Dan

2 1

Re: Change a malloc() to a HeapAlloc()
by James McKenzie 09 Jun '10

09 Jun '10

Ultra two wrote: > --- > We use real names here. This patch probably will not be committed until it is resubmitted. James McKenzie

2 1

Re: [PATCH 3/3] winecfg: Cosmetic improvements to the about panel
by Joel Holdsworth 08 Jun '10

08 Jun '10

On Wed, 2010-06-02 at 23:56 +0100, Joel Holdsworth wrote: > Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> > --- > programs/winecfg/Bg.rc | 19 +++++---- > programs/winecfg/Cs.rc | 19 +++++---- > programs/winecfg/Da.rc | 19 +++++---- > programs/winecfg/De.rc | 19 +++++---- > programs/winecfg/En.rc | 19 +++++---- > programs/winecfg/Es.rc | 19 +++++---- > programs/winecfg/Fi.rc | 19 +++++---- > programs/winecfg/Fr.rc | 19 +++++---- > programs/winecfg/Hu.rc | 19 +++++---- > programs/winecfg/It.rc | 19 +++++---- > programs/winecfg/Ja.rc | 19 +++++---- > programs/winecfg/Ko.rc | 19 +++++---- > programs/winecfg/Lt.rc | 19 +++++---- > programs/winecfg/Nl.rc | 19 +++++---- > programs/winecfg/No.rc | 19 +++++---- > programs/winecfg/Pl.rc | 19 +++++---- > programs/winecfg/Pt.rc | 32 +++++++------- > programs/winecfg/Ro.rc | 19 +++++---- > programs/winecfg/Ru.rc | 19 +++++---- > programs/winecfg/Si.rc | 19 +++++---- > programs/winecfg/Sv.rc | 19 +++++---- > programs/winecfg/Tr.rc | 19 +++++---- > programs/winecfg/Zh.rc | 38 +++++++++-------- > programs/winecfg/about.c | 88 +++++++++++++++++++++++++++++++++++++++++ > programs/winecfg/idb_wine.bmp | Bin 14614 -> 0 bytes > programs/winecfg/resource.h | 7 +++- > programs/winecfg/winecfg.rc | 4 +- > 27 files changed, 342 insertions(+), 226 deletions(-) > delete mode 100644 programs/winecfg/idb_wine.bmp Any thoughts about this patch? I guess there's a reason why 1/3 was merged but not 2/3 and 3/3. Anything I can fix?

4 5

Two enhancement requests for winetricks
by Jan Hoogenraad 08 Jun '10

08 Jun '10

I cannot access the login to Google (Google won't let me for some technical reason) , into http://code.google.com/p/winezeug/issues/list so I use this mail list to report 2 enhancement requests 1) Can winetricks also include a REMOVE script for each of the tricks ? It seems that a user is now advised to remove some (for the user often illogical) files in the windows directories. This is error prone, and lags the nice installation interface. 2) Can winetricks also include a status check for each of the tricks ? This could be as simple as checking if the files provided by wine have the latest wine time stamp and/or version signature. Alternately, a list of installed (by the UI selected) tricks can be provided. Each debugging request for wine states that I should remove all winetricks. However I have no way to tell, and no way to safely remove them. For example, my ~/.wine/drive_c/windows/sys*/* contains the files below, for which I suspect a wine trick, based on the time stamp. However, they may also be installed by some piece of windows software that I have installed. Thus, simply removing them does not make sense to me. Could somebody file this request in the issue database for me ? ------------------- 1032 2010-04-25 12:00 system32/ngen.exe 10204 2010-04-25 12:00 system32/view.exe 210420 2010-04-25 12:00 system32/cmdlgtst.exe 924432 2008-10-06 23:30 system32/MFC40.DLL 499712 2008-10-06 23:30 system32/msvcp71.dll 348160 2008-10-06 23:30 system32/msvcr71.dll 326656 2008-10-06 23:30 system32/MSVCRT40.DLL 492304 2008-10-06 23:30 system32/OLEAUT32.DLL 258352 2008-10-06 23:30 system32/unicows.dll 21936 2008-10-06 23:30 system32/help.exe 995383 2008-10-06 23:30 system32/MFC42.DLL 70656 2008-10-06 23:30 system32/MSVCIRT.DLL 195124 2008-10-06 23:30 system32/wcmd.exe 322832 2008-10-06 23:30 system/mfc30.dll 921872 2008-10-06 23:30 system/mfc40.dll 696 2003-12-04 16:07 system32/jetodbc.rsp 60224 2003-12-03 09:56 system32/odbcji32.dll 621104 2003-12-02 15:00 system32/mswstr10.dll 158256 2003-12-02 14:59 system32/msjint40.dll 354864 2003-11-12 13:17 system32/msjetoledb40.dll 559656 2003-11-12 13:17 system32/msrepl40.dll 326184 2003-11-12 13:16 system32/msexcl40.dll 1514024 2003-11-12 13:16 system32/msjet40.dll 354856 2003-11-12 13:16 system32/mspbde40.dll 285224 2003-11-12 13:16 system32/odbcjt32.dll 248360 2003-11-12 13:16 system32/msjtes40.dll 354856 2003-11-12 13:16 system32/msxbde40.dll 264744 2003-11-12 13:16 system32/mstext40.dll 27464 2003-11-12 13:15 system32/odexl32.dll 27464 2003-11-12 13:15 system32/odtext32.dll 27464 2003-11-12 13:15 system32/oddbse32.dll 27464 2003-11-12 13:15 system32/odfox32.dll 27464 2003-11-12 13:15 system32/odpdx32.dll 838240 2003-06-02 10:15 system32/mswdat10.dll 518752 2003-06-02 10:15 system32/msexch40.dll 428640 2003-06-02 10:15 system32/msrd2x40.dll 387680 2003-06-02 10:14 system32/expsrv.dll 322144 2003-06-02 10:14 system32/msrd3x40.dll 219744 2003-06-02 10:14 system32/msltus40.dll 60000 2003-06-02 10:14 system32/msjter40.dll 37472 2003-06-02 10:14 system32/vbajet32.dll 322832 2000-02-29 02:39 system32/MFC30.DLL -- Jan Hoogenraad

1 0

Re: gameux.dll implementation stub
by James Mckenzie 08 Jun '10

08 Jun '10

Mariusz Pluciński <vshader(a)gmail.com> wrote at Jun 8, 2010 6:56 AM > >Hello Greetings. >As you maybe know, I'm working on implementation of Game Explorer in >the Google Summer of Code. Main part of my work is now implementing >gaming APIs stored in gameux.dll library. I already sent patches >with headers, and I'm currently in the stage when stubs are ready to >start real implementation. > To prevent some of us out here from thinking you sent your patches to the wrong place, could you preface the subject of your messages like this one with RFC: That will allow us to run the patches and look closely at them to give them a critical review. Also, you can still submit your patches, it looks like Alexandre committed the first two and might commit the remaining three you submitted. Lastly, it looks like Release Candidate three for Wine 1.2 will be out on Friday and this may be the last one before the final release. James McKenzie

1 0

Re: Implement ID3DXConstantTable::GetConstantDesc
by testbot＠testbot.winehq.org 08 Jun '10

08 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2526 Your paranoid android. === WINEBUILD (build) === Patch failed

2 1

msvcrt printf test failed on NT4,win95
by Thomas Heckel 08 Jun '10

08 Jun '10

Hi Alexander, I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d "Proberly skip if functions are not available" made test errors on NT4 and Win95 test instead of a skip while it works on newer windows platforms as expected. Could this be the case because GetModuleHandle and these failing platforms are not widechar compatible? So maybe it needs using GetModuleHandleA? kind regards Thomas

3 3

Re: kernel32: CopyFile cannot overwrite a file with itself (try 2)
by Alexandre Julliard 08 Jun '10

08 Jun '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * kernel32: CopyFile cannot overwrite a file with itself This breaks a number of things, particularly msi. It would need much more detailed tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: regedit: use binary mode when doing file import/export (try 2)
by Alexandre Julliard 08 Jun '10

08 Jun '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * regedit: use binary mode when doing file import/export I don't think it will work properly for output. -- Alexandre Julliard julliard(a)winehq.org

1 0

Making AppDB look nice
by Alexandru Băluț 08 Jun '10

08 Jun '10

Hi, I think the AppDB pages look bad, and I want to spend some time to make them look better. For example: - In the page that shows a version of an application, the background color in the list of test results depends on the rating of each test result, and it looks very messy, that rating color should be used somehow only in the Rating column. - More generally, get rid of the colored gray background colors, and eventually use discrete alternate colors like Bugzilla when listing bugs. - Get rid of the whole-row clicking, for example in the Top-10 tables in the first page, because it works weird when you middle-click. (This is more than improving looks, but still, it's on my TODO list) If you have specific suggestions on how to make the AppDB pages look better, and consistent with the rest of the winehq sites, please tell me. Thanks, Alex

1 0

Re: Track the number of audio bytes played as a 64 bit number
by Maarten Lankhorst 07 Jun '10

07 Jun '10

Hello Dmitry, 2010/6/7 Dmitry Baryshev <ksquirrel.iv(a)gmail.com>: > Make wine-1.1.43 track the number of audio bytes played as a 64 bit number > rather than a 32 bit number to avoid overflows. It may happen happen on > constantly used audio content, possibly causing inbound voice to stop > working > in some voice applications. Please send patches in the format "module: Description", and your patch mangled the tabs in winealsa :) Likely other patches are affected too. Cheers, Maarten

1 0

Gecko64 status
by Jacek Caban 07 Jun '10

07 Jun '10

Hi all, I'd like to share with you progress on gecko64. First of all, I think that it was never said in public, although I've been asked about it: there won't be gecko64 for 1.2 release. I think we will have Gecko release in the second half of this year it will support 64-bit, but it's not yet clear when exactly. We may try to do it near the next Firefox release, but time will show how it will work. However, it doesn't mean that nothing is going on around Wine Gecko. I've recently switched to mingw-w64 for 32-bit builds. I've very pleased with it. They are far better in co-operation, don't have senseless politics like mingw and their quality of headers and libraries is far better. We won't need to maintain fixes to build envinonment anymore. (I've been even talking about better co-operation between our projects, but that's OT here and I will report progress when there will be more to say). We're much nearer to allow packagers to build their own Gecko now. Back to gecko64, I've completed the first step. I have a working 64-bit Firefox crosscompiled with mingw-w64. See: https://bugzilla.mozilla.org/show_bug.cgi?id=570342 for details. It starts and runs on Windows. Now I wait for patches to be committed to Mozilla. It may take awhile :/ Before we may think about support for gecko64 in MSHTML, we have to fix its issues in Wine. Firefox is a good Gecko test and it needs to be fixed first. Unfortunately it currently doesn't even start. I've put a build on server in case anyone would like to try it: http://gerwazy.lo3.wroc.pl/~jcaban/wine/firefox-mingw-w64.tar.bz2 Volunteers on working on Wine side are very welcomed. There are also some other tests from Mozilla code. Note that before fixing any more sophisticated bug, it's worth to make sure on Windows, that the bug is in Wine, not in the build. All I verified is that Firefox should start and basic functionality works (and doesn't work on Wine). Any comments and suggestions are welcomed. Cheers, Jacek

6 9

Re: [3/5] gameux: Add declaration of IGameStatistics interface (try 2)
by Alexandre Julliard 07 Jun '10

07 Jun '10

Mariusz Pluciński <vshader(a)gmail.com> writes: > [ > + object, > + uuid(3887C9CA-04A0-42ae-BC4C-5FA6C7721145) > + ] > + interface IGameStatistics : IUnknown > + { > + HRESULT GetCategoryTitle([in] WORD categoryIndex, > + [out, optional] LPWSTR* pTitle); > + > + HRESULT GetLastPlayedCategory([out] UINT* pCategoryIndex); > + > + HRESULT GetMaxCategories([out] WORD* pMax); > + > + HRESULT GetMaxCategoryLength([out] UINT* cch); > + > + HRESULT GetMaxNameLength([out] UINT* cch); > + > + HRESULT GetMaxStatsPerCategory([out] WORD* pMax); > + > + HRESULT GetMaxValueLength([out] UINT* cch); > + > + HRESULT GetStatistic([in] WORD categoryIndex, > + [in] WORD statIndex, > + [out, optional] LPWSTR* pName, > + [out, optional] LPWSTR* pValue); > + > + HRESULT Save([in] BOOL trackChanges); > + > + HRESULT SetCategoryTitle([in] WORD categoryIndex, > + [in] LPCWSTR title); > + > + HRESULT SetLastPlayedCategory([in] UINT categoryIndex); > + > + HRESULT SetStatistic([in] WORD categoryIndex, > + [in] WORD statIndex, > + [in, optional] LPCWSTR name, > + [in, optional] LPCWSTR value); This doesn't match the PSDK. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests (try 3)
by testbot＠testbot.winehq.org 07 Jun '10

07 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2512 Your paranoid android. === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests (try 2)
by testbot＠testbot.winehq.org 07 Jun '10

07 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2510 Your paranoid android. === WNT4WSSP6 (32 bit registry) === registry.c:2003: Test failed: could not open user class key, error 2 === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: kernel32: CopyFile cannot overwrite a file with itself
by testbot＠testbot.winehq.org 07 Jun '10

07 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2509 Your paranoid android. === W98SE (32 bit file) === file.c:603: Test failed: copying a file to itself didn't fail (ret=0, err=80)

1 0

Re: advapi32: add HKCU\Software\Classes and HKLM\Software\Classes merge tests
by testbot＠testbot.winehq.org 07 Jun '10

07 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2508 Your paranoid android. === WNT4WSSP6 (32 bit registry) === registry.c:2003: Test failed: could not open user class key, error 2 registry.c:2009: Test failed: could not create guid key, error 6 === W2KPROSP4 (32 bit registry) === No test summary line found === WXPPROSP3 (32 bit registry) === Timeout

1 0

Re: [7/7] msvcrt/test: Add some simple _vsnwprintf_s tests. (try 2)
by Austin English 07 Jun '10

07 Jun '10

On Sun, Jun 6, 2010 at 11:36 PM, Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> wrote: > try 2: todo_wines removed since _vsnwprintf_s is fixed by patch 5. The todo_wine's need to be removed in the same patch in which they are fixed, otherwise, the tests will "fail". -- -Austin

2 2

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access() (try 2)
by Andrew Nguyen 06 Jun '10

06 Jun '10

I hate to nitpick once more, but there are a few things I noticed. My alsa-lib tells me: include/pcm.h:int snd_pcm_recover(snd_pcm_t *pcm, int err, int silent); Therefore, the statement "int ret = snd_pcm_recover(NULL, NULL, NULL);" is somewhat incorrect. Secondly, I think it should be sufficient to drop the AC_COMPILE_IFELSE macro entirely. The purpose in the original test was to distinguish between the version supplied in ALSA 0.9.x and ALSA 1.x, so, while I don't feel strongly about the matter either way, just checking for the existence of the function should be sufficient, as is done in other tests.

1 0

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access() (try 2)
by Marcus Meissner 06 Jun '10

06 Jun '10

On Sun, Jun 06, 2010 at 02:21:33PM -0500, Austin English wrote: > -- > -Austin > diff --git a/configure.ac b/configure.ac > index 21c0203..46ac100 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1,4 +1,4 @@ > -dnl Process this file with autoconf to produce a configure script. > +/dnl Process this file with autoconf to produce a configure script. Bad. Ciao, Marcus

1 0

Running tests on wine
by GOUJON Alexandre 06 Jun '10

06 Jun '10

Hi, I would like to do some (typelib) tests on wine. So I followed the instructions at http://www.winehq.org/docs/winedev-guide/testing-wine ( cd dlls/oleaut32/tests/ ; rm typelib.ok && make typelib.ok in my case) but I have err's and fixme's whereas the output on wineTestBot is quite different (http://test.winehq.org/data/9aa9a1229f2195a8b3ac575645a10242ae6e9bc8/wine_n…) I tried WINETEST_DEBUG=1 make typelib.ok but it's the same output. Am I missing something ? Thanks

3 3

Re: [PATCH 3/3] shlwapi: Implement SHSetIniStringW
by testbot＠testbot.winehq.org 06 Jun '10

06 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2490 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:604: Test failed: GetShellSecurityDescriptor should fail ordinal.c:627: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1776: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1834: Test failed: got 25 ordinal.c:1842: Test failed: got 36, length 37 ordinal.c:1853: Test failed: got 39 === W7PROX64 (32 bit ordinal) === ordinal.c:1776: Test failed: got 22 ordinal.c:1826: Test failed: got 22 ordinal.c:1834: Test failed: got 22 ordinal.c:1842: Test failed: got 31, length 32 ordinal.c:1853: Test failed: got 34 === W7PROX64 (64 bit ordinal) === ordinal.c:1776: Test failed: got 22 ordinal.c:1826: Test failed: got 22 ordinal.c:1834: Test failed: got 22 ordinal.c:1842: Test failed: got 31, length 32 ordinal.c:1853: Test failed: got 34

1 0

Re: [PATCH 2/3] shlwapi: Implement SHGetIniStringW
by testbot＠testbot.winehq.org 06 Jun '10

06 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2489 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:603: Test failed: GetShellSecurityDescriptor should fail ordinal.c:626: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1775: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 25 ordinal.c:1841: Test failed: got 36, length 37 ordinal.c:1852: Test failed: got 39 === W7PROX64 (32 bit ordinal) === ordinal.c:1775: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 22 ordinal.c:1841: Test failed: got 31, length 32 ordinal.c:1852: Test failed: got 34 === W7PROX64 (64 bit ordinal) === ordinal.c:1775: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 22 ordinal.c:1841: Test failed: got 31, length 32 ordinal.c:1852: Test failed: got 34

1 0

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by testbot＠testbot.winehq.org 06 Jun '10

06 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2488 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1767: Test failed: got 25 ordinal.c:1817: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 36, length 37 ordinal.c:1844: Test failed: got 39 === W7PROX64 (32 bit ordinal) === ordinal.c:1767: Test failed: got 22 ordinal.c:1817: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 31, length 32 ordinal.c:1844: Test failed: got 34 === W7PROX64 (64 bit ordinal) === ordinal.c:1767: Test failed: got 22 ordinal.c:1817: Test failed: got 22 ordinal.c:1825: Test failed: got 22 ordinal.c:1833: Test failed: got 31, length 32 ordinal.c:1844: Test failed: got 34

1 0

Re: appwiz: Add the Polish translation
by Sven Baars 06 Jun '10

06 Jun '10

Hey Łukasz, all your translations are written in UTF-8, but to actually use UTF-8, you also have to include a #pragma code_page(65001) on top of the file. In this case for example +#include "res.h" + +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT + +#pragma code_page(65001) Atm, if you compile wine with this patch applied you see: sven@sven-desktop:~/wine-git/dlls/appwiz.cpl$ make LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -foPl.res Pl.rc Warning: string "Aby doda� program z dysku, p�yty CD-ROM lub dyskietki, kliknij przycisk Zainstaluj" seems to be UTF-8 but codepage 1250 is in use. Warning: string "To oprogramowanie mo�e by� usuni�te automatycznie. Aby usun�� program lub zmieni� jego zainstalowane komponenty, zaznacz go z listy i naci�nij Zmie�/Usu�." seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Zmie�..." seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Usu�..." seems to be UTF-8 but codepage 1250 is in use. Warning: string "Podane informacje mog� by� przydatne przy otrzymaniu pomocy technicznej dla %s:" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Dodaj/Usu� programy" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Pozwala na instalacj� nowego lub usuni�cie ju� istniej�cego oprogramowania z twojego komputera." seems to be UTF-8 but codepage 1250 is in use. Warning: string "Nie mo�na uruchomi� programu odinstalowuj�cego, '%s'. Czy chcesz usun�� wpis o tym programie z rejestru?" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Nie okre�lone" seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Usu�..." seems to be UTF-8 but codepage 1250 is in use. Warning: string "&Zmie�/Usu�..." seems to be UTF-8 but codepage 1250 is in use. You get warnings like this for every patch that you sent in. You can check it yourself by running "make depend" from the git directory and then "make" from the directory that contains the program or dll. This is at least how I got them. Regards, Sven P.S. You're not the only one making this mistake. I also made it the first time ;) Łukasz Wojniłowicz wrote: > --- > dlls/appwiz.cpl/Makefile.in | 1 + > dlls/appwiz.cpl/Pl.rc | 84 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+), 0 deletions(-) > create mode 100644 dlls/appwiz.cpl/Pl.rc >

1 0

Release plans
by Alexandre Julliard 06 Jun '10

06 Jun '10

Folks, The 64-bit support is now more or less complete, and we have most of the fancy new icons, so it's time to think about the next stable release. Unless some major problems come up, 1.1.44 will be the last of the 1.1.x series. The next release will be 1.2-rc1, which will mark the beginning of the code freeze. This should result in a 1.2 final sometime in June. As usual the code freeze will become more and more drastic as we get closer to release, so if you have major changes to make, now is pretty much the last minute. I'd encourage everyone to look through the list of nominated 1.2 bugs, and also to check the regression reports for anything that might be in your area. We should strive to have as few regressions from 1.0 as possible, so regressions fixes will have priority during code freeze. And of course changes that don't impact the code, like translations or test fixes, can go in until quite late. -- Alexandre Julliard julliard(a)winehq.org

14 26

re: Advice about a new project, and similarity to Wine's start
by Dan Kegel 06 Jun '10

06 Jun '10

Alessandro Pignotti wrote: > how did Wine choose the feature set to support first? Pragmatically - by trying to get particular popular apps running. (Starting with solitaire :-) > Did people use the early releases of Wine, even if they were missing features? Yes, as soon as they ran their favorite app. So in your case, as soon as your flash player can handle youtube.com (or whatever free software afficianados can't live without), a few people will start using it. > Is the AppDB software available for use on other projects? Should be. > Any misc advice? The Wine project started moving faster when we switched to test-driven development. I highly recommend it. Do you have a test suite? And/or can you share existing test suites ( e.g. http://wiki.gnashdev.org/Testcases ) ? That said, visual stuff is hard to test automatically, so mostly our automated tests only test the API level. Visual tests are done manually and much less often (say, only when changing directly affected code). Automated performance benchmarks are a good idea, though we haven't done as much of that. Good luck! - Dan

2 1

Advice about a new project, and similarity to Wine's start
by Alessandro Pignotti 06 Jun '10

06 Jun '10

Hi everyone, first of all congratulations. The current maturity of Wine is really, really impressive. Thanks for your work. Let's introduce myself, I'm the author of the Lightspark project (http://lightspark.sf.net): a modern, open source, flash player implementation. The project is currently in a very good shape, featuring scripting support, a JIT compiler and OpenGL accelerated rendering. But, although the core VM is mostly complete, a huge part of the runtime library is still missing. I'm asking advice here because this is probably a condition similar to the one faced by early Wine developers. I'm currently pretty confused about the roadmap of my project. Although some interest gathered after the announcement of the 0.3.0 release and some bug reports appeared I've not yet managed to gather the needed community feedback. Moreover, beside supporting the most popular flash applications (e.g. YouTube, which is mostly supported), I've no idea about what to do later and how to prioritize features. So my question is: how did Wine choose the feature set to support first? Did people use the early releases of Wine, even if they were missing features? Is the AppDB software available for use on other projects? Any misc advice? Thanks a lot for your help. and sorry for the quite OT message, Alessandro Pignotti

2 1

Wine code comments
by John Voltz 05 Jun '10

05 Jun '10

Hi everyone, I have a question about comments in the Wine code. I noticed while tracking down a bug that a lot of the code comments are using the block comment marker /*. This is a royal pain when trying to comment out large sections of code where there are a bunch of /* foo */ comments. Why is this allowed? Is there are way around it without having to change them all to //? Regards, John Voltz

6 8

Re: shdoclc: Add the Polish translation (try 2)
by Paul Vriens 05 Jun '10

05 Jun '10

On 06/05/2010 01:38 PM, Łukasz Wojniłowicz wrote: > + MENUITEM "&Odœwie¿ > +", _IDM_REFRESH Hi Łukasz, Something went wrong here. -- Cheers, Paul.

1 0

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by Nikolay Sivov 05 Jun '10

05 Jun '10

On 6/3/2010 23:35, Andrew Eikum wrote: > > This fixes a bug with Internet Explorer 6's Favorites menu. > > This function used to be named IUnknown_EnumObjects, so my guess is > that the original implementor thought it'd be wise to verify the type > of the object before executing IShellFolder's methods on it. Since > it's now called IShellFolder_EnumObjects and explicitly takes an > LPSHELLFOLDER parameter, I see no reason to do the typecheck. And where is a test for that? > > --- > dlls/shlwapi/ordinal.c | 19 +------------------ > dlls/shlwapi/tests/Makefile.in | 2 +- > dlls/shlwapi/tests/ordinal.c | 32 ++++++++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+), 19 deletions(-)

2 9

Re: shdoclc: Add the Polish translation
by Paul Vriens 05 Jun '10

05 Jun '10

On 06/04/2010 04:33 PM, Łukasz Wojniłowicz wrote: > + > +LANGUAGE LANG_POLISH, SUBLANG_NEUTRAL > + > +IDR_BROWSE_CONTEXT_MENU MENU Hi Łukasz, Sorry if I wasn't clearer before. You are having effectively two blocks with the same translations now. The reason the English resource file has two blocks is because it has effectively two translations (one for SUBLANG_DEFAULT and one for SUBLANG_NEUTRAL). There is no need to do that in most of the other resource files like Polish as there is only one Polish language (as far as resource files are concerned). Could you also add something to the Subject when resending? So for example "(Resend)" when sending the same patch again or "(Try x)" when you sent a new version of the patch. -- Cheers, Paul.

1 0

Wine on MIPS?
by André Hentschel 05 Jun '10

05 Jun '10

Hi, i just read that MIPS is planning to get on the mobil market. It will be available in 4G Smartphones with Android. Wine has a MIPS port which should also run those obsolete Win32 MIPS Apps, so i guess the winelib side is more interesting. So here my question: did anyone recently tried to compile Wine on MIPS and did it worked? If not, is anybody able to? -- Best Regards, André Hentschel

1 0

Re: [1/2]wineps.drv: make use of MAKEINTRESOURCEW
by Dmitry Timoshkov 04 Jun '10

04 Jun '10

André Hentschel <nerv(a)dawncrow.de> wrote: > +#define PAPER 99 > #define IDD_PAPERS 100 > #define IDD_ORIENT_PORTRAIT 101 > #define IDD_ORIENT_LANDSCAPE 102 You could try to find a less generic name for this. -- Dmitry.

1 0

Re: [2/2]wineps.drv: Import comctl32 instead of loading it
by Dmitry Timoshkov 04 Jun '10

04 Jun '10

André Hentschel <nerv(a)dawncrow.de> wrote: > -IMPORTS = user32 gdi32 winspool advapi32 kernel32 > +IMPORTS = user32 gdi32 winspool advapi32 kernel32 comctl32 It's being loaded for a reason. You can make it delay loaded though. -- Dmitry.

1 0

Re: [PATCH] msi/tests: Fix install tests for Win9x
by testbot＠testbot.winehq.org 04 Jun '10

04 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2470 Your paranoid android. === WNT4WSSP6 (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:5411: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5430: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5455: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5474: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:3534: Test failed: Expected 314, got 1 install.c:8264: Test failed: RegQueryValueExA failed 2 (0)

1 0

Re: shdoclc: Add the Polish translation
by Paul Vriens 04 Jun '10

04 Jun '10

On 06/04/2010 01:05 PM, Łukasz Wojniłowicz wrote: > + > +LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL This doesn't look correct for Polish ;) -- Cheers, Paul.

1 0

Re: appwiz: Add the Polish translation
by Paul Vriens 04 Jun '10

04 Jun '10

On 06/04/2010 01:05 PM, Łukasz Wojniłowicz wrote: > dlls/appwiz.cpl/Makefile.in | 1 + > dlls/appwiz.cpl/Pl.rc | 84 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 85 insertions(+), 0 deletions(-) > create mode 100755 dlls/appwiz.cpl/Pl.rc Hi Łukasz, Wrong mode here. Should be the normal 100644 (like you other recent patches). -- Cheers, Paul.

1 0

Re: [PATCH 2/2] cmd: Update Dutch translation
by Frédéric Delanoy 04 Jun '10

04 Jun '10

2010/6/2 Sven Baars <sven.wine(a)gmail.com> > --- > programs/cmd/Nl.rc | 194 > ++++++++++++++++++++++++++++----------------------- > 1 files changed, 106 insertions(+), 88 deletions(-) > Hi Sven, Some remarks: - You shouldn't change the line length as it makes the patch unnecessarily big, for no change in text (for the affected hunks) - "bestaat keert de controle terug naar het bestand dat het aanriep. DE CALL\n\" => "DE" should be "De" Frédéric

3 2

CUDA Wrapper err:module:import_dl
by Seth Shelnutt 04 Jun '10

04 Jun '10

Alright, I'm stumped and everyone else is too. Few years ago we did everything we are doing now and it all worked fine. Now using wine 1.2rc2 we can't get a wrapper I compiled to work. What this wrapper does is it translates/wraps the calls made to the cuda runtime dll (cudart.dll or nvcuda.dll, same file different names) and sends it to the linux library. The linux library and windows are identical except for some missing dx functions in the linux library. My sources can be found here. http://shelnutt2.host56.com/cudart/ and http://shelnutt2.host56.com/cufft/(However we aren't even getting to the second dll yet). Anytime we try to run folding at home in wine, we are getting the following. FAH checks for nvcuda.dll first because that comes with the driver installs on windows, if it doesn't find it, it defaults to cudart.dll which is packaged with fah, or can be installed separately. We have replaced all the cuda dlls with the compiled wrapper or sum linked to the compiled wrapper, just like we use to with the original cuda wrapper that we came up with. err:module:import_dll Loading library nvcuda.dll (which is needed by L"Z:\\home\\sidicas\\.FAHGPU3\\FahCore_11.exe") failed (error c0000020). err:module:import_dll Loading library cudart.dll (which is needed by L"Z:\\home\\sidicas\\.FAHGPU3\\FahCore_11.exe") failed (error c0000020). sidicas@Belldandy:~/.FAHGPU3$ ls -al *.dll -rw-r--r-- 1 sidicas sidicas 1617920 2010-06-03 01:48 amdcalcl.dll -rw-r--r-- 1 sidicas sidicas 2486272 2010-06-03 01:48 amdcalrt.dll -rw-r--r-- 1 sidicas sidicas 124540 2010-06-02 07:50 cudart32_30_14.dll -rw-r--r-- 1 sidicas sidicas 124540 2010-06-02 07:50 cudart.dll -rw-r--r-- 1 sidicas sidicas 82699 2010-06-01 21:39 cufft32_30_14.dll -rw-r--r-- 1 sidicas sidicas 82699 2010-06-01 21:39 cufft.dll lrwxrwxrwx 1 sidicas sidicas 10 2010-06-03 02:12 nvcuda.dll -> cudart.dll sidicas@Belldandy:~/.FAHGPU3$ sidicas@Belldandy:~/.FAHGPU3$ uname -a Linux Belldandy 2.6.26-2-amd64 #1 SMP Sun Jun 21 04:47:08 UTC 2009 x86_64 GNU/Linux sidicas@Belldandy:~/.FAHGPU3$ nvcc --version nvcc: NVIDIA (R) Cuda compiler driver Copyright (c) 2005-2009 NVIDIA Corporation Built on Fri_Feb_19_18:18:31_PST_2010 Cuda compilation tools, release 3.0, V0.2.1221 sidicas@Belldandy:~/.FAHGPU3$ ldd ./cudart.dll linux-gate.so.1 => (0xf7ee3000) libcudart.so.3 => /usr/local/cuda/lib/libcudart.so.3 (0xf7e83000) libwine.so.1 => /usr/lib/libwine.so.1 (0xf7d2d000) libm.so.6 => /lib32/libm.so.6 (0xf7d09000) libc.so.6 => /lib32/libc.so.6 (0xf7bb6000) libdl.so.2 => /lib32/libdl.so.2 (0xf7bb2000) libpthread.so.0 => /lib32/libpthread.so.0 (0xf7b9b000) librt.so.1 => /lib32/librt.so.1 (0xf7b92000) libstdc++.so.6 => /usr/lib32/libstdc++.so.6 (0xf7aa4000) libgcc_s.so.1 => /usr/lib32/libgcc_s.so.1 (0xf7a97000) /lib/ld-linux.so.2 (0xf7ee4000) sidicas@Belldandy:~/.FAHGPU3$ sidicas@Belldandy:~/.FAHGPU3$ ldd ./cufft.dll linux-gate.so.1 => (0xf7f29000) libcufft.so.3 => /usr/local/cuda/lib/libcufft.so.3 (0xf7308000) libwine.so.1 => /usr/lib/libwine.so.1 (0xf71b2000) libm.so.6 => /lib32/libm.so.6 (0xf718e000) libc.so.6 => /lib32/libc.so.6 (0xf703b000) libdl.so.2 => /lib32/libdl.so.2 (0xf7037000) libpthread.so.0 => /lib32/libpthread.so.0 (0xf7020000) libcudart.so.3 => /usr/local/cuda/lib/libcudart.so.3 (0xf6fdf000) libstdc++.so.6 => /usr/lib32/libstdc++.so.6 (0xf6ef1000) libgcc_s.so.1 => /usr/lib32/libgcc_s.so.1 (0xf6ee4000) /lib/ld-linux.so.2 (0xf7f2a000) librt.so.1 => /lib32/librt.so.1 (0xf6eda000) sidicas@Belldandy:~/.FAHGPU3$ sidicas@Belldandy:~/.FAHGPU3$ More thorugh testing has been done, http://foldingforum.org/viewtopic.php?f=54&t=14673&start=105#p146177 . When we makes reference to gpu2 wrapper, that is our original cuda wrapper designed for cuda 2.0-2.2 built couple years ago. The GPU3 wrapper is what we are having problems with. It is our cuda 3.0 wrapper. The .dll files are in the folder (we even tried in system32), ldd shows they are properly linked, yet it does not work. If we use the old wrapper compile before it works fine with cuda 2.x or with cuda 3.0 we just have to sym link the cuda lib to the old name it's expecting. I've tried compiling the old wrapper and linking it to cuda 2.3 however this fails. So I am thinking that if when I compile the old wrapper which is shown to work (when an old compiled version is used) but does not work when I compile on my funtoo box it must be some weird compiling issue. I have wine installed (without 64bit support), and I installed cuda runtime from nvidia's site as the one in portage installs to /opt/ and I wanted to make sure there wasn't any weird issues linking with that. I do get a few warnings when I compile but they aren't anything that would effect this. s.shelnutt@funtoo-64 ~/gpu3/wrapper/cudart $ make winegcc -c -mno-cygwin -m32 -I/usr/local/cuda/include/ -o cudart.o cudart.c In file included from /usr/local/cuda/include/cuda_runtime_api.h:53, from /usr/local/cuda/include/crt/host_runtime.h:108, from cudart.c:7: /usr/local/cuda/include/host_defines.h:57:1: warning: "__cdecl" redefined <command-line>: warning: this is the location of the previous definition cudart.c: In function 'wine_cudaGetTextureReference': cudart.c:430: warning: passing argument 1 of 'cudaGetTextureReference' from incompatible pointer type /usr/local/cuda/include/cuda_runtime_api.h:189: note: expected 'const struct textureReference **' but argument is of type 'struct textureReference **' cudart.c: In function 'wine_cudaRegisterFatBinary': cudart.c:800: warning: return makes pointer from integer without a cast cudart.c: In function 'wine_cudaUnregisterFatBinary': cudart.c:805: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterVar': cudart.c:810: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterTexture': cudart.c:815: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterShared': cudart.c:820: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterSharedVar': cudart.c:825: warning: 'return' with a value, in function returning void cudart.c: In function 'wine_cudaRegisterFunction': cudart.c:831: warning: 'return' with a value, in function returning void winegcc -shared cudart.dll.spec -mno-cygwin -o cudart.dll.so cudart.o -L/usr/local/cuda/lib/ -lcudart -lodbc32 -lole32 -loleaut32 -lwinspool -lodbccp32 -luuid If anyone has any ideas about why this doesn't work, that would be great. I've exhausted everything I could think of. Thanks, Seth Shelnutt

2 1

Re: advapi32: Fix GetSecurityInfo with NULL descriptor
by testbot＠testbot.winehq.org 04 Jun '10

04 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2467 Your paranoid android. === WNT4WSSP6 (32 bit security) === No test summary line found

1 0

Re: advapi32: Fix GetSecurityInfo with NULL descriptor (try2:typo)
by testbot＠testbot.winehq.org 04 Jun '10

04 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2466 Your paranoid android. === WNT4WSSP6 (32 bit security) === No test summary line found

1 0

Re: [PATCH 3/3] shlwapi: Implement SHSetIniStringW
by testbot＠testbot.winehq.org 03 Jun '10

03 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2454 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:604: Test failed: GetShellSecurityDescriptor should fail ordinal.c:627: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1770: Test failed: got 13 ordinal.c:1776: Test failed: got 27 ordinal.c:1791: Test failed: got 10 ordinal.c:1804: Test failed: got 13 ordinal.c:1812: Test failed: got 13 ordinal.c:1826: Test failed: got 27 ordinal.c:1834: Test failed: got 27 ordinal.c:1864: Test failed: got 22 ordinal.c:1875: Test failed: got 25 === W7PROX64 (32 bit ordinal) === ordinal.c:1776: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1834: Test failed: got 25 ordinal.c:1842: Test failed: got 34, length 35 ordinal.c:1853: Test failed: got 37 === W7PROX64 (64 bit ordinal) === ordinal.c:1776: Test failed: got 25 ordinal.c:1826: Test failed: got 25 ordinal.c:1834: Test failed: got 25 ordinal.c:1842: Test failed: got 34, length 35 ordinal.c:1853: Test failed: got 37

1 0

Re: [PATCH 2/3] shlwapi: Implement SHGetIniStringW
by testbot＠testbot.winehq.org 03 Jun '10

03 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2453 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:603: Test failed: GetShellSecurityDescriptor should fail ordinal.c:626: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1769: Test failed: got 13 ordinal.c:1775: Test failed: got 27 ordinal.c:1790: Test failed: got 10 ordinal.c:1803: Test failed: got 13 ordinal.c:1811: Test failed: got 13 ordinal.c:1825: Test failed: got 27 ordinal.c:1833: Test failed: got 27 ordinal.c:1863: Test failed: got 22 ordinal.c:1874: Test failed: got 25 === W7PROX64 (32 bit ordinal) === ordinal.c:1775: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 25 ordinal.c:1841: Test failed: got 34, length 35 ordinal.c:1852: Test failed: got 37 === W7PROX64 (64 bit ordinal) === ordinal.c:1775: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 25 ordinal.c:1841: Test failed: got 34, length 35 ordinal.c:1852: Test failed: got 37

1 0

Re: [PATCH 1/3] shlwapi: Be less strict on which type of IShellFolder can be enumerated
by testbot＠testbot.winehq.org 03 Jun '10

03 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2452 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:595: Test failed: GetShellSecurityDescriptor should fail ordinal.c:618: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1767: Test failed: got 27 ordinal.c:1817: Test failed: got 27 ordinal.c:1825: Test failed: got 27 ordinal.c:1833: Test failed: got 38, length 39 ordinal.c:1844: Test failed: got 41 === W7PROX64 (32 bit ordinal) === ordinal.c:1767: Test failed: got 25 ordinal.c:1817: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 34, length 35 ordinal.c:1844: Test failed: got 37 === W7PROX64 (64 bit ordinal) === ordinal.c:1767: Test failed: got 25 ordinal.c:1817: Test failed: got 25 ordinal.c:1825: Test failed: got 25 ordinal.c:1833: Test failed: got 34, length 35 ordinal.c:1844: Test failed: got 37

1 0

Re: Fully translate partially translated modules in Polish
by Jacek Caban 03 Jun '10

03 Jun '10

Hi Łukasz, Great work, but it needs some polishing:-) First of all, please split the patch to the series of smaller patches, preferably one per module. On 6/3/10 11:51 AM, Łukasz Wojniłowicz wrote: > --- > dlls/mshtml/Pl.rc | 18 +- > dlls/setupapi/Pl.rc | 23 + > dlls/shell32/shell32_Pl.rc | 25 +- > dlls/wininet/wininet_Pl.rc | 25 +- > programs/notepad/Pl.rc | 21 +- > programs/reg/Pl.rc | 6 + > programs/regedit/Pl.rc | 14 +- > programs/taskmgr/Pl.rc | 1063 ++++++++++++++++++++----------------- > programs/wineboot/wineboot_Pl.rc | 11 + > programs/winecfg/Pl.rc | 35 +- > programs/winhlp32/Pl.rc | 29 +- > programs/wordpad/Pl.rc | 40 +- > 12 files changed, 762 insertions(+), 548 deletions(-) > mode change 100644 => 100755 programs/taskmgr/Pl.rc > > diff --git a/dlls/mshtml/Pl.rc b/dlls/mshtml/Pl.rc > index 8aa357e..b5713f8 100644 > --- a/dlls/mshtml/Pl.rc > +++ b/dlls/mshtml/Pl.rc > @@ -1,6 +1,7 @@ > /* > * Copyright 2005-2006 Jacek Caban > * Copyright 2008 Mikolaj Zalewski > + * Copyright 2010 £ukasz Wojni³owicz > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -34,9 +35,9 @@ STYLE DS_MODALFRAME | DS_CENTER | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMEN > CAPTION "Instalator Wine Gecko" > FONT 8, "MS Shell Dlg" > { > - LTEXT "Wine could not find a Gecko package which is needed for applications embedding HTML " \ > - "to work correctly. Wine can automatically download and install it for you.\n\n" \ > - "Note: it's recommended to use distro packages instead. See http://wiki.winehq.org/Gecko for details.", > + LTEXT "Wine nie znalaz³o paczki Gecko potrzebnej do prawid³owego dzia³ania aplikacji " \ > That doesn't sound grammatically correct to me. I'd say that it should be "Wine nie znalazł..." or better "Nie znaleziono...". > + "zawieraj¹cych kod HTML . Wine mo¿e automatycznie pobraæ i zainstalowaæ t¹ paczkê dla ciebie.\n\n" \ > + "Notka: Lepiej jednak u¿yæ paczki z twojej dystrybucji. Po szczegó³y zajrzyj na http://wiki.winehq.org/Gecko.", > "Uwaga: " would be better choice IMO. Thanks, Jacek

1 0

Re: Removed sign comparison warning.
by Michael Stefaniuc 03 Jun '10

03 Jun '10

Hello Marko, thank you for your patch and welcome to Wine development. While in general patches to make Wine use proper types are accepted there is a slight problem with this patch. On 06/01/2010 11:42 PM, grkoma(a)gmail.com wrote: > From: Marko Nikolic<grkoma(a)gmail.com> > > --- > libs/wine/config.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libs/wine/config.c b/libs/wine/config.c > index 6bb87b0..c04b704 100644 > --- a/libs/wine/config.c > +++ b/libs/wine/config.c > @@ -146,10 +146,10 @@ static char *get_runtime_bindir( const char *argv0 ) > #ifdef linux > for (size = 256; ; size *= 2) > { > - int ret; > + ssize_t ret; > if (!(bindir = malloc( size ))) break; > if ((ret = readlink( "/proc/self/exe", bindir, size )) == -1) break; > - if (ret != size) > + if ((size_t)ret != size) /* Safe to cast, ret is> 0 here */ Having to use a cast to silence a -Wsign-compare is worse than keeping the warning; especially as that is an extra warning not included in the -Wall used by Wine. Though in this specific case by using the proper types the warning can be eliminated without resorting to casts. > { > if (!(p = memrchr( bindir, '/', ret ))) break; > if (p == bindir) p++; bye michael

2 1

Re: Fully translate partially translated modules in Polish
by Paul Vriens 03 Jun '10

03 Jun '10

Hi Łukasz On 06/03/2010 11:51 AM, Łukasz Wojniłowicz wrote: > --- > dlls/mshtml/Pl.rc | 18 +- > dlls/setupapi/Pl.rc | 23 + > dlls/shell32/shell32_Pl.rc | 25 +- > dlls/wininet/wininet_Pl.rc | 25 +- > programs/notepad/Pl.rc | 21 +- > programs/reg/Pl.rc | 6 + > programs/regedit/Pl.rc | 14 +- > programs/taskmgr/Pl.rc | 1063 ++++++++++++++++++++----------------- > programs/wineboot/wineboot_Pl.rc | 11 + > programs/winecfg/Pl.rc | 35 +- > programs/winhlp32/Pl.rc | 29 +- > programs/wordpad/Pl.rc | 40 +- > 12 files changed, 762 insertions(+), 548 deletions(-) I think it's better to send separate patches (so 1 per module) although I must admit I don't have such an issue with this as they are translations. Nonetheless it could be worthwhile resending them to potentially avoid any delay once AJ comes back (and maybe he wants them to be split). > mode change 100644 => 100755 programs/taskmgr/Pl.rc > You have to resend anyway because this change is not needed. Thanks for helping the Polish translation get to 100% !! -- Cheers, Paul.

1 0

Re: advapi32/tests: Fixed -Wsign-compare warnings in security tests.
by testbot＠testbot.winehq.org 03 Jun '10

03 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2444 Your paranoid android. === W7PROX64 (64 bit security) === security.c:922: Test failed: Access and/or AccessStatus were changed! security.c:939: Test failed: Access and/or AccessStatus were changed! security.c:950: Test failed: Access and/or AccessStatus were changed! security.c:961: Test failed: Access and/or AccessStatus were changed! security.c:972: Test failed: Access and/or AccessStatus were changed! security.c:994: Test failed: Access and/or AccessStatus were changed! security.c:1009: Test failed: Access and/or AccessStatus were changed! security.c:1022: Test failed: Access and/or AccessStatus were changed! security.c:1035: Test failed: Access and/or AccessStatus were changed!

1 0

[RFC] advapi32 -- GetNamedSecurityInfo
by GOUJON Alexandre 03 Jun '10

03 Jun '10

Hi, I'm trying to fix bug 18071 but I don't know anything about ACLs. I wrote some tests (see attached patch and https://testbot.winehq.org/JobDetails.pl?Key=2442) and I modified the source according to my understanding of the issue (wich may be totally wrong). But as I'm not familiar with ACLs and because my changes are quite important, I'm sending here my patches hoping a advapi32 coder could have a look at it. Thanks in advance

2 2

Re: [msi/tests] Testcases for CREATE TABLE
by testbot＠testbot.winehq.org 03 Jun '10

03 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2443 Your paranoid android. === W98SE (32 bit db) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit db) === Timeout

3 2

Re: msi: Update the version strings to match Windows Installer 4.5.
by Hans Leidekker 03 Jun '10

03 Jun '10

On Thu, 2010-06-03 at 03:01 -0500, Andrew Nguyen wrote: > This pleases the Actel Libero IDE installer. > --- > dlls/msi/version.rc | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) I think we should delay this until 1.2 is released because it may trigger some installers to use unimplemented functionality in msi.

2 1

Re: gameux: Add declaration of IGameExplorer2 interface
by Vincent Povirk 02 Jun '10

02 Jun '10

I think you want to leave the configure change out of this patch. 2010/6/1 Mariusz Pluciński <vshader(a)gmail.com>: > --- > configure | 1 + > configure.ac | 1 + > include/gameux.idl | 16 ++++++++++++++++ > 3 files changed, 18 insertions(+), 0 deletions(-) > > > > > > >

4 6

msacm32: Remove dead "code" from rc files.
by Frédéric Delanoy 02 Jun '10

02 Jun '10

7 years old untouched cruft

1 0

Release schedule
by Alexandre Julliard 02 Jun '10

02 Jun '10

Folks, The weekly rc schedule won't be quite weekly this week, I'll be out for the next few days so there won't be a release this Friday. The weekly schedule will resume with rc3 next Friday. Don't let that stop you, there are still enough regressions for everybody... -- Alexandre Julliard julliard(a)winehq.org

1 0

GPU driver version reporting
by Seth Shelnutt 02 Jun '10

02 Jun '10

I am trying to get folding at home gpu client working. The issue we are having now is that it detects the driver version and says it is not right, and it won't proceed. I've searched through the lines of a WINEDEBUG=+trace and I think the issue is: 0009:trace:d3d:init_driver_info OS version 5.1. 0009:trace:d3d_caps:init_driver_info Found card 10de:05e2 in driver DB. 0009:trace:d3d_caps:init_driver_info Reporting (fake) driver version 0x0006000f-0x000b21aa. It could also be from: 0009:trace:reg:NtSetValueKey (0x14,L"Driver",1,0xff883b94,20) 0009: set_key_value( hkey=0014, type=1, namelen=12, name=L"Driver", data={57,00,49,00,4e,00,45,00,20,00,53,00,43,00,53,00,49,00,00,00} ) But I think that is just trying to set a registry key, not get a registry key (i.e. the driver version from the registry). What I can't figure out is what version this is reporting. I've searched but I can't find this driver DB, so I don't know what 0x0006000f-0x000b21aa corespondent too. Can someone point me in the right directions? Thanks, Seth Shelnutt

3 4

Re: [msi]update korean resource
by Paul Vriens 02 Jun '10

02 Jun '10

On 06/02/2010 09:10 AM, Hwang YunSong(황윤성) wrote: > > updated Hi, the comments at the top look a bit funny now: /* * Korean resources for MSI - * - * Copyright 2005 YunSong Hwang - * + * + * Copyright 2005 Mike McCormack + * Copyright 2010 Detlef Riekenberg + * Copyright 2010 YunSong Hwang + * -- Cheers, Paul.

1 0

Meaning of "Certificate Manifold" (crypt32/*.rc)
by Frédéric Delanoy 02 Jun '10

02 Jun '10

Hi, I'm reviewing Fr translation and am stuck on the 'IDS_CERT_MANIFOLD "Certificate Manifold"' part. I tried to STFW for it, but apart from OID for "Microsoft Enrollment Infrastructure", did not find explaining stuff. Can someone please explain me what it means? Thanks, Frédéric

3 2

bricscad goes native
by Dan Kegel 02 Jun '10

02 Jun '10

I've long predicted that companies might use Wine for a while to ship Linux-compatible products, and later switch to a native build once they know they have users. Well, now we have at least one example of this: Bricscad (see http://www.bricsys.com ). This is a *good* thing, and validates somewhat the idea that Wine is a catalyst to enable a global shift from Windows to Linux.

6 10

Re: 0003-winecfg-Update-spanish-translation
by Paul Vriens 02 Jun '10

02 Jun '10

On 06/01/2010 09:35 PM, jose rostagno wrote: > + PUSHBUTTON "Cancel",IDCANCEL,105,30,45,14,WS_GROUP Shouldn't that be "Cancelar" ? -- Cheers, Paul.

1 0

Re: [PATCH 4/4] winecfg: Cosmetic improvements to the about panel
by Alexandre Julliard 01 Jun '10

01 Jun '10

Joel Holdsworth <joel(a)airwebreathe.org.uk> writes: > +GpImage* LoadPNGResourceW(HINSTANCE hInst, LPCWSTR lpName) > +{ You should be able to use an icon for this, there shouldn't be any need to involve gdiplus. -- Alexandre Julliard julliard(a)winehq.org

2 6

AppDB 64 bit flag?
by André Hentschel 01 Jun '10

01 Jun '10

Hi, what about an AppDB input in test reports to mention if the test were made with the 32 or 64 bit version of the app? -- Best Regards, André Hentschel

3 2

kernel32 nls file codepage conversion
by Frédéric Delanoy 01 Jun '10

01 Jun '10

Hi folks, I'm intending to convert dlls/kernel32/nls/fr.nls from CP 1252 to CP 65001 (UTF-8), but I've some questions first: - most nls files are non-UTF8... is it intended? or just "legacy"? - can LOCALE_IDEFAULTANSICODEPAGE be set to 65001 or should it be left at its current "1252" value, i.e. is it necessary for compatibility with older win versions where UTF-8 is not the default (correct me if I'm wrong)? - LOCALE_SCURRENCY is set to char code 80 (<80> in vim). What is that exactly? The code for the euro sign in a specific code page? which one? Frédéric

4 10

Re: [PATCH] shlwapi: Implement SHGetIniStringW
by testbot＠testbot.winehq.org 01 Jun '10

01 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2417 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:601: Test failed: GetShellSecurityDescriptor should fail ordinal.c:624: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1773: Test failed: got 26 ordinal.c:1780: Test failed: got 11 ordinal.c:1816: Test failed: got 11 ordinal.c:1823: Test failed: got 26 ordinal.c:1831: Test failed: got 26 ordinal.c:1839: Test failed: got 37, length 38 ordinal.c:1850: Test failed: got 40 ordinal.c:1861: Test failed: got 21 === W7PROX64 (32 bit ordinal) === ordinal.c:1780: Test failed: got 11 ordinal.c:1816: Test failed: got 11 ordinal.c:1861: Test failed: got 19 ordinal.c:1872: Test failed: got 22 === W7PROX64 (64 bit ordinal) === ordinal.c:1767: Test failed: got 10 ordinal.c:1788: Test failed: got 7 ordinal.c:1801: Test failed: got 10 ordinal.c:1809: Test failed: got 10 ordinal.c:1839: Test failed: got 32, length 33 ordinal.c:1850: Test failed: got 35 ordinal.c:1861: Test failed: got 19 ordinal.c:1872: Test failed: got 22

1 0

Assigning bugs, and how new developers can find bugs to work on
by Alexandru Băluț 31 May '10

31 May '10

Hi Paul, I was wondering what is the best way to pick bugs, for a developer aspiring to fix nonspecific Wine bugs. Normally, our hero would look at the unassigned bugs to find one to work on. For some bugs, a fix appeared with no notification that somebody is working on them, for example: http://bugs.winehq.org/show_bug.cgi?id=22263 - julliard@ unexpectedly announced that the bug should be fixed by a specific patch. http://bugs.winehq.org/show_bug.cgi?id=22845 - arethusa26@ unexpectedly mentioned that the bug should be fixed by somebody else's specific patch. Notice both are marked as FIXED, but none of them have been assigned! Let's say our hero picks a bug; should he ask on the bug page whether anybody is already working on it, or ask on wine-devel, or #wine-hackers? Or is it fine to just announce, in the bug page, that you'll work on that bug? See, for example, this comment: http://bugs.winehq.org/show_bug.cgi?id=22264#c9 Any suggestions about improving this process are welcome. I think people will show up, wanting to help, and it would be nice to help them find something to work on fast. ;) In the meanwhile, please assign the bugs, and spare others of spending time on them. As a bonus, it would be nice to see accurate numbers about how many bugs are on nobody's plate vs how many are on somebody's plate. Data! :) At the moment, there are 15 assigned bugs (ignored 11 assigned to wine-bugs@), vs 5580 unconfirmed/new/reopened bugs, for the Wine component. Thanks, Alex On Thu, May 27, 2010 at 20:00, Paul Vriens <paul.vriens.wine(a)gmail.com>wrote: > On 05/27/2010 07:48 PM, belnac wrote: > >> What about dev work, is any available? >> > > Did you ever have a look at our bugzilla ;) > > There is plenty of stuff to do besides fixing bugs of course. What you want > to do depends on many things like skills, interest, the amount of time you > have etc.. > > Remember that we are in code freeze now so looking at bugs and trying to > figure out what could be wrong or even providing information that could lead > to fixing the bugs is welcome. > > -- > Cheers, > > Paul. > > >

3 4

Re: RFC: msvcrt: support dates after year 2038 in mktime64
by testbot＠testbot.winehq.org 31 May '10

31 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2394 Your paranoid android. === WINEBUILD (build) === Patch failed

3 4

Re: New wisotool 20100530: new verbs galore
by wylda＠volny.cz 31 May '10

31 May '10

> > Does bioshock install ok manually from .mds for you > with cdemu? Yes, without any problem. I always double check each image, i.e. first i test the image under winxp and when the image is ok, i take it under wine. Bioshock passed both these tests successfully, i.e. installs and runs without originals (just the mounted image, no cracks of course). BTW: if you have a non-working image under winxp (have to work - necessary condition) check your available drive speeds. For SecuROM is recommended: CD medium: Use lowest available speed for DPM DVD medium: use highest available speed for DPM But my personal experience is different. For example DVD F.E.A.R. Extraction Point i succeeded after 4th try in case of highest DPM speed. Then i tried lowest DPM speed even for DVD and succeeded in every test. So since this i use in alcohol120: * 8x (CD-ROM read) * 4x (DVD-ROM read) Those are lowest speeds for my Samsung SH-S223F. It _should_ work setting 1x and the drive should choose lowest possible, but it happened sometimes to me, that max DPM speed was chosen instead. So i set the speeds explicitly. Unfortunately i also have DVD drives which will _never_ be capable of making working image (to name one: Sony/Optiarc AD-5200S). So if you can't succeed with image creation for longer time, send your drive to trash ;) What makes the image successful is .mds file (mdf should be always the same for different tries). So in case you have non-working image, you can ask someone just for .mds (but .mdf must have same size - i.e. same language DVD or gamebox). > > That's a familiar error. We can and should fix that > before you try again. OK :) > > Also how do you handle multi CD games whit this tool? > > I have 8 virtual drives... > The script can handle unmounting the 1st disc and mounting > the 2nd, but maybe we should mount multiple as you suggest. > (That's a bit more complicated to script because we want the > script to run on windows, too). > - Dan I met games, which are hard to persuade even with "wine eject" and also then you usually need to confirm "OK CD2 is in drive". So to me it looks easier to mount all CDs/DVDs before installation begins. (I'm not a programmer so maybe i'm wrong here;)

1 0

Last Minute Submission: Winecfg>About
by Joerg-Cyril.Hoehle＠t-systems.com 31 May '10

31 May '10

Hi, Joel Holdsworth wrote: >http://www.airwebreathe.org.uk/space/new-about-screen.png winecfg's window seems very tall. I'd like it if somebody took care that it displays correctly in a 800x600 screen or virtual desktop. Currently, the ok & cancel buttons at the bottom are cut off :-( Regards, Jörg Höhle

3 2

Re: comdlg32: Fix Italian translation
by Matteo Bruni 31 May '10

31 May '10

> - LTEXT "File di &Tipo:", 1089, 6, 104, 90, 9 > + LTEXT "&Tippo del file:", 1089, 6, 104, 90, 9 One 'p' is enough :). More importantly, this and the shell32 patch have mangled accented letters (maybe the conversion to UTF8 didn't work out well?). No problems in the taskmgr patch though. By the way, thank you for your translations!

2 2

New wisotool 20100530: new verbs galore
by Dan Kegel 31 May '10

31 May '10

wisotool is a handy winetricks-like script for automatically installing games from .iso or .mds files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except, for now, it prompts for the root password so it can mount the .iso file; later it will use fuse instead). Wisotool currently supports 60 games and/or benchmarks (see list below). Please consider contributing support for your favorite game, it's not (too) hard. I'm especially interested in recent or beta games; ideally wisotool would support (worthwhile) games on the day they are released. Wisotool is available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/ Changes since version 20100424: Austin English - Added new verb half_life_goty (Half Life: Game of the Year edition) - Add draft verb codmw2 (Call of Duty: Modern Warfare 2) - Add initial support for mounting .mds (Alchol 120%) images, use it for Bioshock - Remove helper macros from Morrowind, use button names instead of text to internationalize - Use download() to get winetricks if it's missing Dan Kegel - Added new verb lswcs (Lego Star Wars Complete Saga) - Added draft verbs orangebox, pro cycling mgr 08 demo - Cleanups on many verbs - Add env var to make it easier to point to a read-only .wisotool. - Relax read-only check for .wisotool. - Improve download error handling - Fix three little problems related to unmounting - Add error checking to abort if someone puts an apostrophe in a description - Moved hand-written postinstall scripts out of cache - Start adding uniform way to start apps (c:\run-VERB.bat) Eleazar Galano - Added new verbs hon (Heroes of Newearth), masseffect2, popsot_demo (Prince of Persia Sands of Time Demo), splitsecond, splitsecond_demo, sto (Star Trek Online), wowbc (World of Warcraft Battle Chest) - Added draft verb bfbc2 (Battlefield Bad Company 2) Vincent Pelletier - Add support for 40 GOG.com games (!): ebes_exoddus_gog (Abes Exoddus) abes_oddysee_gog (Abes Oddysee) battle_chess_gog (Battle Chess) beyond_good_and_evil_gog (Beyond Good and Evil) descent_1_2_gog (Descent and Descent 2) descent_3_gog (Descent 3) dukenukem3d_gog (Duke Nukem 3D) dukenukemmp_gog (Duke Nukem Manhattan Project) earth_2150_trilogy_gog (Earth 2150 trilogy) earth_2160_gog (Earth 2160) earthworm_jim_1_2_gog (Earthworm Jim 1 & 2) earthworm_jim_3d_gog (Earthworm Jim 3D) empire_earth_gold_gog (Empire Earth Gold) evil_genius_gog (Evil Genius) fallout_2_gog (Fallout 2) fallout_gog (Fallout) fallout_tactics_gog (Fallout Tactics) far_cry_gog (Far Cry) flatout_gog (FlatOut) freespace_2_gog (Freespace 2) freespace_gog (Freespace) ghost_master_gog (Ghost Master) ground_control_2_gog (Ground Control 2) mdk2_gog (MDK 2) mdk_gog (MDK) neighbours_from_hell_compilation_gog (Neighbours From Hell 1 & 2) operation_flashpoint_goty_gog (Operation Flashpoint GOTY) painkiller_black_gog (Painkiller Black) perimeter_gog (Perimeter) praetorians_gog (Praetorians) psychonauts_gog (Psychonauts) redneck_rampage_gog (Redneck Rampage) robinson_requiem_collection_gog (Robinson Requiem & Deus) settlers_2_gold_gog (The Settlers 2 Gold) shogo_gog (Shogo Mobile Armor Division) tex_murphy_1_and_2_gog (Tex Murphy 1 & 2) unreal_2_se_gog (Unreal 2: The awakening Special Edition) unreal_gold_gog (Unreal Gold Edition) ut2004_gog (Unreal Tournament 2004) ut_goty_gog (Unreal Tournament GOTY) Here is its current help text: Script to install games automatically. Usage: wisotool [options] package [package] ... Options: -q quieter -v verbose -V display Version Packages: 3dmark03 3D Mark 03 (Futuremark, 2003) [download] 3dmark05 3D Mark 05 (Futuremark, 2005) [download] 3dmark06 3D Mark 06 (Futuremark, 2006) [download] 3dmark2000 3DMark2000 (MadOnion.com, 2000) [download] 3dmark2001 3DMark2001 (MadOnion.com, 2001) [download] abes_exoddus_gog Abes Exoddus (GOG.com) abes_oddysee_gog Abes Oddysee (GOG.com) assassinscreed Assassins Creed (Ubisoft, 2008) baldursgate2 Baldurs Gate 2 - Shadows of Amn (Bioware, 2000) battle_chess_gog Battle Chess (GOG.com) beyond_good_and_evil_gog Beyond Good and Evil (GOG.com) bfbc2 Battlefield Bad Company 2 (EA, 2010) bioshock Bioshock (2K Games, 2007) codmw2 Call of Duty Modern Warfare 2 (Activision, 2009) [broken] descent_1_2_gog Descent and Descent 2 (GOG.com) descent_3_gog Descent 3 (GOG.com) dragonage Dragon Age: Origins (Bioware, 2009) dukenukem3d_gog Duke Nukem 3D (GOG.com) dukenukemmp_gog Duke Nukem Manhattan Project (GOG.com) earth_2150_trilogy_gog Earth 2150 trilogy (GOG.com) earth_2160_gog Earth 2160 (GOG.com) earthworm_jim_1_2_gog Earthworm Jim 1 & 2 (GOG.com) earthworm_jim_3d_gog Earthworm Jim 3D (GOG.com) empire_earth_gold_gog Empire Earth Gold (GOG.com) evil_genius_gog Evil Genius (GOG.com) fallout_2_gog Fallout 2 (GOG.com) fallout_gog Fallout (GOG.com) fallout_tactics_gog Fallout Tactics (GOG.com) far_cry_gog Far Cry (GOG.com) flatout_gog FlatOut (GOG.com) freespace_2_gog Freespace 2 (GOG.com) freespace_gog Freespace (GOG.com) ghost_master_gog Ghost Master (GOG.com) ground_control_2_gog Ground Control 2 (GOG.com) gta_vc Grand Theft Auto: Vice City (Rockstar, 2003) half_life_goty Half Life: Game of the Year Edition (Sierra, 2000) help How to use this tool hon Heroes of Newerth (S2 Games, 2010) [download] lswcs Lego Star Wars Complete Saga (Lucasarts, 2009) manhole The Manhole Masterpiece Edition (Cyan, 1994) masseffect2 Mass Effect 2 (BioWare, 2010) mdk2_gog MDK 2 (GOG.com) mdk_gog MDK (GOG.com) morrowind The Elder Scrolls III: Morrowind (Bethesda, 2002) neighbours_from_hell_compilation_gog Neighbours From Hell 1 & 2 (GOG.com) operation_flashpoint_goty_gog Operation Flashpoint GOTY (GOG.com) orangebox Orange Box (Valve, 2007) painkiller_black_gog Painkiller Black (GOG.com) pcmark04 PC Mark 04 (Futuremark, 2004) [download] pcmark05 PC Mark 05 (Futuremark, 2005) [download] perimeter_gog Perimeter (GOG.com) plantsvszombies Plants vs. Zombies (PopCap Games, 2009) [download] popsot_demo Prince of Persia Sands of Time Demo (Ubisoft, 2003) praetorians_gog Praetorians (GOG.com) procycling08_demo Pro Cycling Manager 2008 Demo (Cyanide, 2008) [download, broken in wine] procycling09_nda Pro Cycling Manager 2009 (Cyanide, 2009) psychonauts_gog Psychonauts (GOG.com) quake3 Quake 3 (ID Software, 1999) re5bench Resident Evil 5 Benchmark (Capcom, 2009) [download] redneck_rampage_gog Redneck Rampage (GOG.com) robinson_requiem_collection_gog Robinson Requiem & Deus (GOG.com) settlers_2_gold_gog The Settlers 2 Gold (GOG.com) shogo_gog Shogo Mobile Armor Division (GOG.com) sims3 The Sims 3 (EA, 2009) splitsecond Split Second (Black Rock Studios, 2010) [wine bug 22865] splitsecond_demo Split Second Demo (Black Rock Studios, 2010) [wine bug 22865] starcraft Starcraft Battle Chest (Blizzard, 1998) starcraft2 Starcraft II beta (Blizzard, 2010) stfu Starwars: The Force Unleashed (Aspyr, 2009) sto Star Trek Online (Cryptic, 2010) tex_murphy_1_and_2_gog Tex Murphy 1 & 2 (GOG.com) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) [download] unreal_2_se_gog Unreal 2: The awakening Special Edition (GOG.com) unreal_gold_gog Unreal Gold Edition (GOG.com) ut2004_gog Unreal Tournament 2004 (GOG.com) ut_goty_gog Unreal Tournament GOTY (GOG.com) wog World of Goo demo (2D Boy, 2008) [download] wowbc World of Warcraft: Battle Chest (Blizzard, 2008) Pseudopackages: load Load a disc into the iso cache load=KEY Load a disc with given key; only works from commandline at moment ------------------------------------------------------ If the game is not marked with {download} or {loaded} in the menu, you have to insert its disc and give the 'load' command before you can choose that game in the menu. If the game has multiple discs, you have to do this for each disc. ------------------------------------------------------ ------------------------------------------------------ If the game has an install key, you have to enter that when loading the first disc. (You have to do that from the commandline, e.g. sh wisotool load=XXXX-YYYY-ZZZZ.) ------------------------------------------------------

2 1

Last Minute Submission: Winecfg>About
by Joel Holdsworth 31 May '10

31 May '10

Hi All, I know it's late and we're in freeze mode now, but I wanted to offer some work I've been doing: http://www.airwebreathe.org.uk/space/new-about-screen.png Basically I've been giving the about page of winecfg a face lift. It seemed like a good idea to put some polish on it in time for the release. Is there any interest in pushing this? or is it too late? The patches are all fairly straightforward. The only gotcha is that the modification to the page layout has to be carried across all languages without introducing any errors. I'm planning to do this with a simple script, but is there a simple way of switching between languages quickly? So I can check the layout doesn't get broken? Also, if I submit these patches - to be merged now or later, would it be better to submit all the resource language patches inidividually? or language by language? What do people think? Joel

5 6

Re: d3dx9: Implement D3DXDeclaratorFromFvF
by James Mckenzie 31 May '10

31 May '10

>Hi, > >I think I solved problems with this patch: > >Use the already implemented D3DXGetDeclVertexSize to compute the offset. >This saves to introduce new internal functions. >Simplify the checks for the index. >Clean a little bit the code > David: It is customary to label retries of patch submissions as Try 2, Try 3, and so on in increasing numbers somewhere in the patch name so that Alexandre will look at your latest attempt. Thank you. James McKenzie

1 0

d3dx: need someone to test on Windows box
by David Adam 31 May '10

31 May '10

Hello, I tried these tests with my Vista box. All they passed. Can anyone test on a real Windows XP box or a real Windows box? Thanks in advance David

3 3

Re: wined3d: fix size of buffer in swapchain_create_context_for_thread()
by Stefan Dösinger 31 May '10

31 May '10

The patch seems OK to me. Am 31.05.2010 um 07:09 schrieb Dan Kegel: > While testing Battlefield: Bad Company 2, I saw a glibc memory corruption error, > so I ran with +heap,+relay,+d3d. That showed > err:heap:HEAP_ValidateInUseArena Heap 0x110000: block 0x13ef80 tail > overwritten at 0x13ef85 (byte 0/11 == 0x40) > Inspection of code before the block in question was allocated led me > to the lines > > dlls/wined3d/swapchain.c:972: > newArray = HeapAlloc(GetProcessHeap(), 0, sizeof(*newArray) * > This->num_contexts + 1); > ... > newArray[This->num_contexts] = ctx; > which seem to be missing some parentheses. > > Sure enough, the attached patch got rid of the heap error. > <swapchain.patch>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel