- wine-devel - winehq.org

Implementing d3dx9_36.dll.D3DXCreateTextureFromFileExA
by Alexandre Tolmos 31 May '10

31 May '10

Hello all, I tried to run the submarine simulation game Silent Hunter 4 on my Mac (MacOS X 10.6.3 Snow Leopard) and it crashes because the D3DX function D3DXCreateTextureFromFileExA is not implemented. I know OpenGL so maybe I can help... Let me know. Regards, Alexandre -- "That which is not dead which can eternal lie, and with strange aeons even death may die." - Abdul Alhazred

2 1

Re: msvcrt/tests: convert file to UTF-8
by Frédéric Delanoy 30 May '10

30 May '10

On Mon, May 31, 2010 at 00:23, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin Not sure about it, but shouldn't this file stay in CP1252? After all the specific locale is tested using CP1252 no? Frédéric

2 1

Re: msvcrt/tests: convert file to UTF-8
by testbot＠testbot.winehq.org 30 May '10

30 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2395 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Allowed reverse engineering methods
by Mariusz Pluciński 30 May '10

30 May '10

Hello I'm working on implementation of Games Explorer for Wine (in Google Summer of Code). My work gets progress, but to finish it, I need to get more information about Windows implementation. My question is: which reverse engineering methods are legal and accepted while working in Wine project? Only information I found is located on Wine's wiki page (http://wiki.winehq.org/SummerOfCode): > * You are not allowed to read or reuse Windows source code >(leaked source / Windows >Research Kernel* / ...) >(* we are following the SFLC's advice) > * You are not allowed to reverse engineer Windows files by >disassembling or >decompiling them > * You are not allowed to analyze Windows files with the >trace functions of Wine But which methods are allowed? I assume that "obvious" methods (reading header files, registry dumps, etc.) are acceptable, but can I e.g. analyze .pdb symbol files (availble in e.g. Microsoft's DirectX SDK)? Can I copy executable from Windows (.exe) and analyze it in Wine using winedebug's "relay" channel? (last point from website I linked above says that I can't analyze "Windows files" this way, but I'm not sure is it apply for executables in way I described). Mariusz Pluciński

4 3

Replacement of "#if 0" by "if (0)" blocks
by Frédéric Delanoy 30 May '10

30 May '10

Hi folks, after seeing aafef7cdd56e488d2f42eb01190e51ce6148b664 (Use if(0) instead of #if 0 to make sure code still compiles), IMHO, except special cases (like maybe in headers files), those '#if 0' have no advantages compared to "if (0)" (besides being highlighted in vim), because they may induce code rot and hence prevent maintenance (and why not delete them to begin with?)... I'm looking at the remaining cases, and have some questions: - should this situation be changed/cleaned up (I wouldn't want to spend time only to see my patches automatically refused...)? Are there any reasons for those #if blocks other than easier commenting? - if yes, is it preferable to (1) delete those sections or (2) replace them with "if" blocks (and delete them if they don't compile?)? Frédéric

2 1

"Powered by Mozilla" somewhere subtle on winehq?
by Scott Ritchie 30 May '10

30 May '10

http://www.mozilla.org/projects/powered-by.html Mozilla has a small campaign to mention projects that depend on them in various fashions. I think it'd be neat to get listed there on that page. Mozilla in turn would like us to mention Mozilla somewhere on our site. This seems like something we should do anyway, along with all our other dependencies - I'm thinking a link off the about page would be nice. Thoughts? Thanks, Scott Ritchie

3 2

Re: localspl: Add Italian translation
by Sven Baars 30 May '10

30 May '10

Luca Bennati wrote: > +/* + * English resources for localspl + * + * Copyright 2005 Huw > Davies + * Copyright 2006 Detlef Riekenberg + * Hey Luca, This should probably be +/* + * Italian resources for localspl + * + * Copyright 2010Luca Bennati + * Same for your other patches ;) Sven

2 1

Building a CUDA 3.0 dll wrapper, compile errors
by Seth Shelnutt 30 May '10

30 May '10

I've done this before, with no problems for cuda 2.x, but it's been a while and I'm having troubles. I think I have everything configured right, as I got the cufft dll wrapper compiled but the cudart dll wrapper is acting like I am not linking it to the linux libcudart.so, but I am. I've noticed a few changed in winemaker, and I thought I'd get some to check my make file / see if they can see anything wrong. My source can be found here, http://shelnutt2.host56.com/cudart/ . I'm assuming your cuda toolkit is installed in the default location of /usr/local/cuda . My errors are: winegcc -shared cudart.dll.spec -mno-cygwin -o cudart.dll.so cudart.o -L/usr/local/cuda/lib/ -lcudart -lodbc32 -lole32 -loleaut32 -lwinspool -lodbccp32 -luuid cudart.o: In function `__saturatef': cudart.c:(.text+0x3b6c): undefined reference to `__cuda___isnanf' cudart.o: In function `__sad': cudart.c:(.text+0x3bfc): undefined reference to `__cuda_llabs' cudart.o: In function `__usad': cudart.c:(.text+0x3c47): undefined reference to `__cuda_llabs' cudart.o: In function `__internal_float2ll_kernel': cudart.c:(.text+0x3d2b): undefined reference to `__cuda___isnanf' cudart.o: In function `__internal_float2ull_kernel': cudart.c:(.text+0x4082): undefined reference to `__cuda___isnanf' cudart.o: In function `__fdividef': cudart.c:(.text+0x4eaa): undefined reference to `__cuda_fabsf' cudart.c:(.text+0x4ecf): undefined reference to `__cuda_fabsf' cudart.o: In function `__expf': cudart.c:(.text+0x5085): undefined reference to `__cuda_exp2f' cudart.o: In function `__exp10f': cudart.c:(.text+0x50b6): undefined reference to `__cuda_exp2f' cudart.o: In function `__powf': cudart.c:(.text+0x5140): undefined reference to `__cuda_exp2f' cudart.o: In function `__internal_double2ll_kernel': cudart.c:(.text+0x6130): undefined reference to `__cuda___isnan' cudart.o: In function `__internal_double2ull_kernel': cudart.c:(.text+0x6383): undefined reference to `__cuda___isnan' cudart.o: In function `clock64': cudart.c:(.text+0x7f61): undefined reference to `__cuda_clock' Thanks, Seth Shelnutt

2 1

Re: comctl32/tests: Added a test that checks whether setting a custom default button in a property sheet works
by Nikolay Sivov 29 May '10

29 May '10

On 5/30/2010 02:12, Alexandru Băluț wrote: > The test I added checks that in a property sheet the custom default > button is pressed when the ENTER key is pressed and a different > control, a combobox, has the keyboard focus. The test succeeds when > running on Vista, and fails when running on Wine, that's why I added > "todo_wine" before it. > > This problem is described in bug 22862: "Setting the default button in > a PropertySheetPage does not work". You forgot a patch.

1 0

Re: [Wine] How do I fix the 'fixme's
by Frédéric Delanoy 29 May '10

29 May '10

On Sat, May 29, 2010 at 02:53, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > trapspringer wrote: >> >> How can i fix this? >> > > Become a Wine developer and write the code that implements these features! > Fixme's are for code that is missing to implement functions that exist in > the Win32/Win64 APIs that are partially implemented and need further work to > become fully implemented. I always found this naming a bit confusing. "fixme" sounds like "there's a bug/workaround here" IMHO. (That's not the first post I read about this IIRC) "todo" or similar would be more consistent, don't you think? > James McKenzie Frédéric

2 1

Regression Statistics
by Michael Stefaniuc 29 May '10

29 May '10

Hello guys, I thought about doing a regression report like Rafael Wysocki is doing for the Linux Kernel http://marc.info/?l=linux-kernel&m=127344241607730&w=4 but I got cured when looking at the regression list on bugs.winehq.org. We have at least by a factor of three too many regressions. So here is just a high level overview; the numbers were taken on 2010/05/29 at 10:00 UTC. Regressions ----------- Open: 316 Status Regressions Patch Download Download+Patch UNCONFIRMED 164 3 46 0 NEW 139 20 85 11 REOPENED 10 2 2 0 ASSIGNED 3 1 1 0 Of course there should be no UNCONFIRMED regression with a "download" keyword, right? Alexandre also said on irc that most of the open regressions are valid so the UNCONFIRMED count could be even lower. While gathering those numbers bugzilla presented me with the proper wisdom: "Don't let a bug in your wine bother you. Just remove it." If somebody is desperately looking for an interesting challenge during the boring feature freeze times the regression list on bugs.winehq.org has it! As always: "Limited stock available; first come first serve". :) bye michael

1 0

d3dx9effect.h; Errors in h files are bugs?
by Luis Busquets 29 May '10

29 May '10

winehq in include/d3dx9effect.h adds in the definition of ID3DXEffectCompiler the methods: STDMETHOD(SetPixelShader)(THIS_ D3DXHANDLE parameter, LPDIRECT3DPIXELSHADER9 pshader) PURE; STDMETHOD(SetVertexShader)(THIS_ D3DXHANDLE parameter, LPDIRECT3DVERTEXSHADER9 vshader) PURE; None of this methods is part of ID3DXBaseEffect (the group of the methods ID3DXEffectCompiler in which they are set) and none is part of the specific methods of ID3DXEffectCompiler Thus, these two methods should be removed from the .h file? Does this qualify as a bug to put in winebugs or is the winehq policy to report these kind of source code bugs to the wine-devel list?

2 1

Re: [PATCH] msi: Publish icons into the correct directory
by testbot＠testbot.winehq.org 29 May '10

29 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2384 Your paranoid android. === W98SE (32 bit install) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:5402: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5421: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5446: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5465: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:3525: Test failed: Expected 314, got 30 install.c:8255: Test failed: RegQueryValueExA failed 2 (0)

1 0

Fwd: Call for translators
by David Gerard 28 May '10

28 May '10

to list as well! ---------- Forwarded message ---------- From: David Gerard <dgerard(a)gmail.com> Date: 28 May 2010 21:07 Subject: Re: Call for translators To: Paul Vriens <paul.vriens.wine(a)gmail.com> 2010/5/28 Paul Vriens <paul.vriens.wine(a)gmail.com>: > I totally agree (and have already talked to Francois a few times about this) > that we need a nicer/better way for translators to help us out. Participate in TranslateWiki? http://translatewiki.net - started doing translations for Wikimedia projects, now does them for other people too. - d.

1 0

Fwd: Re: About Win API Stats page
by André Hentschel 28 May '10

28 May '10

Am 28.05.2010 21:24, schrieb Paul Vriens: > On 05/28/2010 07:25 PM, André Hentschel wrote: >> Am 28.05.2010 19:14, schrieb GOUJON Alexandre: >>> Hi, >>> >>> There is a Win API Stats page available at >>> http://www.winehq.org/winapi_stats. >>> But as you can see, it's not updated since about a year. >>> >>> So here is my question : (as wine-1.2 is coming) Should we update the >>> page or simply remove it ? >>> I think a cleanup is preferable to avoid confusion but an updated table >>> may interest some people. >>> >>> What do you think ? >>> >>> >> +1 for update >> It's obvious that a script does that, so someone should run it :) >> Further i'd say that the data are facts, so it should not be too much >> confusing. >> > > There were some changes in July last year: > > http://www.winehq.org/pipermail/wine-devel/2009-July/077481.html > I sent some patches, that fixed it for me. Library API count % implemented Total stubs Real stubs Pseudo stubs Forwards Year Total 33512 66% 11301 9782 1519 10017 2009 Total 40241 69% 12169 12169 0 13623 2010 But now i see what was ment with "pseudo", my patches ignores the pseudo stubs... -- Best Regards, André Hentschel

1 0

About Win API Stats page
by GOUJON Alexandre 28 May '10

28 May '10

Hi, There is a Win API Stats page available at http://www.winehq.org/winapi_stats. But as you can see, it's not updated since about a year. So here is my question : (as wine-1.2 is coming) Should we update the page or simply remove it ? I think a cleanup is preferable to avoid confusion but an updated table may interest some people. What do you think ?

5 4

Rome total war
by Keith Muir 28 May '10

28 May '10

Hi, No don't have time to bisect this also I'm no trained to do it I'm also fed up being told it's so easy cos its not and why don't you have one guy trained who can be contacted to do it for others? or show others how to do it? I'm the maintainer for Rome total war latest report is the install fails got to be a regression fix it worked on 1.44 Regards, Keith

5 4

removed as supermaintainer of Microsoft Office installer
by Rosanne DiMesio 28 May '10

28 May '10

Someone, obviously another admin, has removed me as supermaintainer of the Microsoft Office installer entry. I would like to know who, and why. Yes, I am royally pissed off. -- Rosanne DiMesio <dimesio(a)earthlink.net>

4 4

Re: README: Fix some problems with words order in phrases
by Dmitry Timoshkov 28 May '10

28 May '10

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + Wine должен работать на большинстве файловых системах. This one sounds wrong, I'd change it to Wine должен работать на большинстве файловых систем. -- Dmitry.

2 1

new winetricks 20100526: new verbs alldlls=builtin, forcemono, mmdevapi=disabled, utorrent
by Dan Kegel 28 May '10

28 May '10

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Dan Kegel: - Added mmdevapi=disabled verb - Don't require ~/.winetrickscache to be owned by the user, to allow a readonly cache owned by root. - Sandbox: disable updating of wineprefix when wine version changes to keep unix shell filesystem from being re-enabled. - Mention that steam crashes if corefonts not installed - Steam now defaults to embedded chrome instead of ie, so don't need as many prereqs. - Add alldlls=builtin, alldlls=default verbs Eleazar Galano: - Added utorrent verb (patch by eg) Austin English: - Update shockwave sha1sum - Add 'forcemono' to aid in dotnet/mono debugging - Update Mono to 2.6.4 Andrew Nguyen: - Register the extracted wsh57 dll's.

2 2

Re: [PATCH 0/2] Native case-insensitive file-system support on Mac OS
by Charles Davis 28 May '10

28 May '10

I've been running with this set for... it's been so long, I can't remember! What's preventing it from being committed? (I know it's not the impending release, because otherwise the Patch list would say they're "Deferred".) Chip

3 4

d3dx: should NULL defines be accepted?
by Luis Busquets 28 May '10

28 May '10

The current code for the functions: D3DXCreateEffectFromFileExW <http://source.winehq.org/ident?i=D3DXCreateEffectFromFileExW> D3DXCreateEffectFromFileExA <http://source.winehq.org/ident?i=D3DXCreateEffectFromFileExA> D3DXCreateEffectFromResourceExW <http://source.winehq.org/ident?i=D3DXCreateEffectFromResourceExA> D3DXCreateEffectFromResourceExA <http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileW> D3DXCreateEffectCompilerFromFileW <http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileW> D3DXCreateEffectCompilerFromFileA <http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileA> includes a check of defines and will returnD3DERR_INVALIDCALL <http://source.winehq.org/ident?i=D3DERR_INVALIDCALL> if defines are NULL. However I see nothing wrong in calling any of those functions with defines being NULL. Actually, usually defines are NULL and it is only in specific cases when they are set. Is this a bug? If not, please let me know why. regards,

2 1

gcc64 float bug
by Maarten Lankhorst 27 May '10

27 May '10

Hi AJ, I isolated and fixed the gcc bug, but it will take some time before the changes make it into wine stable. Should I add a testcase to configure to detect a broken version of gcc, and refuse to build wine64 if this is the case? See this link for the fix, and the testcase: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43869 gdiplus tests seem to pass now, no weird test failures any more. I put my test results at: http://test.winehq.org/data/033bb8a2f9bd57000e64d5566f1b52a1cdf3f730/index_… I have no idea why it claims to have crashed, a few of them that claimed to have crashed ran succesfully till the end, but apart from that a few more testcases succeed. A few tests crash for me, but this appears to be a side effect from running gcc-svn, since it happens with and without the patch. I'm getting a lot of fixmes about DW_CFA_remember_state/DW_CFA_restore_state not being implemented. Cheers, Maarten

4 3

Re: Release plans
by James Mckenzie 27 May '10

27 May '10

Austin English <austinenglish(a)gmail.com> wrote: > >On Fri, May 21, 2010 at 3:47 AM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: >>>> And I didn't write trivial Mac patches either, e.g. to have >>>> wineprefixcreate symlink c:\users\xyz\ Desktop + Videos + Documents + >>>> Music to /Users/xyz/Desktop/ etc. This happens on Linux, not on MacOS. >>>> That's another (example of a) missing element. >>>> (Why didn't I write it? Because I was unsure where to put the #ifdef) >>>Isn't that linking done relative to $HOME, which should resolve to >>>/Users/xyz on Mac? >> That's not the problem. What I also don't know is whether I could hardcode >> the directories ~/Documents etc. (these already exist in my /Users/xyz, >> (but what about Tiger?)), or whether I ought to call some OSX API that >> yields the name of the dir (and possibly creates it if it does not yet exist). >> I'm not familiar at all with Mac APIs, but it sounds like an easy patch >> for somebody with a little MacOS programming knowledge. > >I haven't used Tiger in ages, but at least for me on Snow Leopard, I >can't delete those directories, since OSX considers them 'essential to >OS function'. The likelihood of them missing is small, IMHO. > Correct. However, you are free to create new directories for these functions and use them, except the Desktop. The location of these files could be changed but that is mostly beyond most Mac Users. Defaulting to $HOME/Desktop and $HOME/Documents is a good first step. James McKenzie

3 3

Re: user32/tests: check return value of GetUpdateRect in test_validatergn (try 3)
by testbot＠testbot.winehq.org 27 May '10

27 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2337 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070136 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00300136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006F0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00730178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00740178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00190138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS

1 0

Re: [PATCH 7/7] jsciprt: Added leftContext and rightCont4ext tests.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2331 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] jscript: Treat no argument as "undefined" in RegExp.test.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2330 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] jscript: Store builtin constructor's length in instance object.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2329 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

re: Alexandre Julliard : user32: Copy icon bits by hand in CreateIconIndirect if the bitmaps can' t be selected into a DC.
by Dan Kegel 26 May '10

26 May '10

Should that || 1 be there? + if (!SelectObject( hdc, src ) || 1) /* do it the hard way */

2 1

Re: [1/2] shell32/tests: Explicitly link all tests to IL* calls by ordinals
by Alexandre Julliard 26 May '10

26 May '10

Nikolay Sivov <bunglehead(a)gmail.com> writes: > Explicitly link all tests to IL* calls by ordinals There's no reason to do this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup
by Stefan Dösinger 26 May '10

26 May '10

Am 19.05.2010 um 00:38 schrieb Roderick Colenbrander: > This patch series removes the responsibility for enabling/disabling the > texture_target from the 'set_shader' stage of the blit_shader. I disagree with this patch. glEnable(GL_TEXTURE_2D) is the fixed function pipline's way of putting the right texture target into the "TEX dst, src, sampler, dimension" instruction. They are in the ARB blitter only because of my laziness - it is using the fixed function pipeline instead of an equivalent shader. So if you want to get rid of the glEnable / glDisable calls you should instead use ARB shaders which match the fixed function pipeline's functionality, e.g. TEX result.color, fragment.texcoord[0], texture[0], 2D; (for the 2D case) ffp_blit will keep calling glEnable / glDisable GL_TEXTURE_... > At a later stage I might disallow calling set_shader when we don't need the shader. How does the caller know when a shader is needed?

3 7

Re: [PATCH] wininternet: check for NULL lpwhh (Coverity)
by Nikolay Sivov 26 May '10

26 May '10

On 5/26/2010 11:53, Marcus Meissner wrote: > Hi, > > the other cases also check for NULL lpwhh, so do it too. > > Ciao, Marcus > --- > dlls/wininet/internet.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 5b1913a..fd93276 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -2581,6 +2581,11 @@ BOOL WINAPI InternetSetOptionW(HINTERNET hInternet, DWORD dwOption, > } > case INTERNET_OPTION_CONTEXT_VALUE: > { > + if (!lpwhh) > + { > + SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE); > + return FALSE; > + } > if (!lpBuffer || dwBufferLength != sizeof(DWORD_PTR)) > { > SetLastError(ERROR_INVALID_PARAMETER); > Could you add a test for that?

1 0

Re: [PATCH 1/2] d3d8: Set the FPU control word on device creation.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2319 Your paranoid android. === WVISTAADM (32 bit device) === device.c:1598: Test failed: Expected foreground window 00020210, got 00020260.

1 0

How to Create a Windows shared link in Wine(Ubuntu)
by Harsha Angadi 26 May '10

26 May '10

Hi, I have installed Windows 2003 Server, on that i have installed VMware and in VMware i have installed Ubuntu.Now my requirement is i want to run a Windows Application shortcut from Ubuntu, for that i have installed wine on Ubuntu.Now i have copied and pasted the Shortcut of that Windows Application on Ubuntu's Desktop. When i check the Windows Application shortcut properties its path will be something like this * \\192.168.1.15\Application\Application.exe*, but i am unable to run that Application shortcut in Ubuntu. If i try samething on the other windows system on network it works fine. Actually its a thin client server architecture where i want my thin client to use ubuntu and access the windows application shortcut and run the windows application shortcut on ubuntu.Please help me in this regard. If this is not clear please tell me how should be my input. Thanking you in advance. With Regards, Harsha S Angadi http://www.google.com/profiles/harsha.angadi http://www.linkedin.com/in/harshaangadi http://www.nammagokak.com/discuss

2 1

Re: Voting for own bugs not allowed?
by James Mckenzie 26 May '10

26 May '10

> >On Tue, May 25, 2010 at 8:59 AM, Vitaliy Margolen ><wine-devel(a)kievinfo.com> wrote: >> On 05/25/2010 03:50 AM, Maarten Lankhorst wrote: >>> I'm for a patch to remove voting altogether. >> +1 >> Actually no patch needed. Voting can be disabled via option "usevotes". > >Let's disable it then, but that's no reason to close otherwise valid >bugs as invalid. > Actually, I like Rosanne's idea. Make the field 'Can you reproduce this bug' and not allow the 'confirmed by votes' function. Only a bug report that has been confirmed by an interested developer should be moved into that status and immediately followed by a work-in-progress type status with a dev name associated with it. And I agree that people who report bugs should not be able to confirm, but they can supply hacks/patches that fix the problem... James McKenzie

1 0

Voting for own bugs not allowed?
by Florian Köberle 26 May '10

26 May '10

Hello, just someone informed me that I MUST NOT vote for my own bugs. Is there a reason for it? I like to vote for those of my own bugs which are important to me. It really surprised me that there is this kind of rule and that it can make your bug being closed as invalid: http://bugs.winehq.org/show_bug.cgi?id=22857 Best regards, Florian

8 12

Re: atl: reuse code of AtlModuleRegisterWndClassInfoW for AtlModuleRegisterWndClassInfoA (try 2)
by Andrey Turkin 25 May '10

25 May '10

25.05.2010 18:51, André Hentschel wrote: > --- a/dlls/atl/atlwin.h > +++ b/dlls/atl/atlwin.h > @@ -43,7 +43,7 @@ typedef struct _ATL_WNDCLASSINFOW_TAG > WCHAR m_szAutoName[14]; > } _ATL_WNDCLASSINFOW; > > -ATOM WINAPI AtlModuleRegisterWndClassInfoA(_ATL_MODULEW *pm, _ATL_WNDCLASSINFOA *wci, WNDPROC *pProc); > +ATOM WINAPI AtlModuleRegisterWndClassInfoA(_ATL_MODULEA *pm, _ATL_WNDCLASSINFOA *wci, WNDPROC *pProc); > ATOM WINAPI AtlModuleRegisterWndClassInfoW(_ATL_MODULEW *pm, _ATL_WNDCLASSINFOW *wci, WNDPROC *pProc); > > HDC WINAPI AtlCreateTargetDC(HDC hdc, DVTARGETDEVICE *ptd); > Are you sure about this change?

2 2

Re: winemenubuilder: use the full path to start.exe (try 2)
by Alexandre Julliard 25 May '10

25 May '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * use the full path to start.exe Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [4/4] wininet: Add tests for setting and retrieving the context value.
by testbot＠testbot.winehq.org 25 May '10

25 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2306 Your paranoid android. === W2K3R2SESP2 (32 bit http) === http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 0 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:410: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:413: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:414: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:415: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:416: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:418: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:443: Test failed: Wrong URL http://test.winehq.org/testredirect http.c:148: Test failed: unexpected status 10 (INTERNET_STATUS_RESOLVING_NAME) http.c:771: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times http.c:774: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 0 times http.c:775: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 0 times http.c:776: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 0 times http.c:777: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 0 times http.c:780: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times http.c:899: Test failed: failed to read any of the document http.c:2719: Test failed: InternetQueryOption failed: 12018 http.c:2720: Test failed: expected INTERNET_HANDLE_TYPE_HTTP_REQUEST, got 0 http.c:2725: Test failed: HttpQueryInfo failed http.c:2726: Test failed: expected size > 0 Timeout

1 0

Re: [3/3] msi: End the search for a directory signature if the parent cannot be found.
by testbot＠testbot.winehq.org 25 May '10

25 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2305 Your paranoid android. === W7PROX64 (32 bit package) === package.c:7603: Test failed: Expected "C:\winetest\FileName1", got "" package.c:7609: Test failed: Expected "C:\winetest\FileName2", got "" package.c:7615: Test failed: Expected "C:\winetest\FileName3", got "" package.c:7627: Test failed: Expected "C:\winetest\FileName5", got "" package.c:7633: Test failed: Expected "C:\winetest\", got "" package.c:7639: Test failed: Expected "C:\winetest\", got "" package.c:7655: Test failed: Expected "C:\winetest\FileName8.dll", got "" package.c:7666: Test failed: Expected "C:\winetest\FileName10.dll", got "" package.c:11676: Test failed: Expected "{2C5EE045-5C09-40BD-93F8-086EC36919FF}", got "apple" package.c:11703: Test failed: Expected first 3 chars of "{2C5EE045-5C09-40BD-93F8-086EC36919FF}", got "apple" package.c:11713: Test failed: Expected first 37 chars of "{2C5EE045-5C09-40BD-93F8-086EC36919FF}", got "apple" package.c:11723: Test failed: Expected "{2C5EE045-5C09-40BD-93F8-086EC36919FF}", got "apple" package.c:11755: Test failed: Expected "{2C5EE045-5C09-40BD-93F8-086EC36919FF}", got "apple" === W7PROX64 (64 bit package) === package.c:8212: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8223: Test failed: Expected "C:\winetest\", got "" package.c:8234: Test failed: Expected "C:\winetest\", got "" package.c:8284: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8295: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8304: Test failed: Expected "C:\", got "" package.c:8310: Test failed: Expected "C:\winetest\", got "" package.c:8331: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8340: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: [PATCH] shlwapi: initial implement of SHAutoComplete (Retry)
by Nikolay Sivov 25 May '10

25 May '10

On 5/25/2010 03:29, Hirofumi Katayama wrote: > See attachment. > Hi. > + list = (LPWSTR) malloc(len); > + free(list); Use HeapAlloc()/HeapFree() for that and others allocations. > + fUnicode = IsWindowUnicode(hwndEdit); > + if (fUnicode) > + pProp = (AUTOCOMPLETEPROP *) GetPropW(hwndEdit, szPropNameW); > + else > + pProp = (AUTOCOMPLETEPROP *) GetPropA(hwndEdit, szPropNameA); This is unrelated thing. You can use GetPropW for non-Unicode windows as well.

1 0

Re: gdi32: Properly restore the DC in MF_PlayMetaFile. (RESEND)
by Alexandre Julliard 25 May '10

25 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Any reason why this hasn't been applied yet? It's the updated/fixed > patch per Alexandre's guidance. It breaks the tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: Export lowlevel PIDL manipulation calls by name too (try2)
by testbot＠testbot.winehq.org 25 May '10

25 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2299 Your paranoid android. === WXPPROSP3 (32 bit shlfileop) === Can't copy TestLauncher to VM: The command is not recognized by the Guest OS tools

2 1

Re: msvcrt (1/2): add fstat64i32
by Piotr Caban 24 May '10

24 May '10

Hi, fstat64i32 and stat64i32 are not exported by native msvcrt.dll. This functions should be implemented in msvcr90. Cheers, Piotr

2 2

Release plans
by Joerg-Cyril.Hoehle＠t-systems.com 24 May '10

24 May '10

Hi, >The 64-bit support is now more or less complete I hope I can finish my MCI parser patches in time. Without them, every 64bit app using MCI string commands is likely to crash (OTOH MCI commands work (those using the MCI_*_PARAMS structures)). What can Mac users expect from this release? Yesterday I installed an app with wine-1.1.44 on Mac OS (instead of moving it from a Linux install). It was disappointing from a user POV: - Wine created .desktop files that work on Linux but don't make sense on Mac OS. Here I've been thinking about a simple patch that would instead generate a .command file like I've described in the FAQ. OTOH, Steven Edwards IIRC once had a much more elaborate patch about better Mac OS integration, rejected last year. - In the hidden directory ~/.local/share/icons/ it created .xpm files that the Finder does not display. .png would be displayed. I have no idea how the other packages built atop Wine behave on MacOS behave: - Kronenberg's WineBottler - doh's WineSkin - Macports build - CodeWeaver's CrossOver4Mac I assume they create nice icons that the user can click after an install. Regarding the former 2 packages, I've always been wondering why there's some sort of split in the Wine+Mac user community. Obviously the stock Wine fails to meet the Mac user's expectations, such that several people start and write something better integrated with the GUI -- but not integrated into the Wine source. And I didn't write trivial Mac patches either, e.g. to have wineprefixcreate symlink c:\users\xyz\ Desktop + Videos + Documents + Music to /Users/xyz/Desktop/ etc. This happens on Linux, not on MacOS. That's another (example of a) missing element. (Why didn't I write it? Because I was unsure where to put the #ifdef) Regards, Jörg Höhle

5 12

Re: [PATCH 4/4] shell32: Add IShellBrowser stub to ExplorerBrowser.
by testbot＠testbot.winehq.org 24 May '10

24 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2284 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by testbot＠testbot.winehq.org 24 May '10

24 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2283 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [PATCH 3/4] shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by testbot＠testbot.winehq.org 24 May '10

24 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2280 Your paranoid android. === WINEBUILD (build) === Make failed

3 2

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by Nikolay Sivov 24 May '10

24 May '10

On 5/24/2010 16:25, David Hedberg wrote: Hi, David. > +} > + > +static ULONG WINAPI IExplorerBrowser_fnRelease(IExplorerBrowser *iface) > +{ > + ExplorerBrowserImpl *This = (ExplorerBrowserImpl*)iface; > + TRACE("This: %p\n", This); > + > + This->ref--; > + TRACE("Ref: %d\n", This->ref); > Use interlocked increment/decrement here. > + > +static HRESULT WINAPI IExplorerBrowser_fnSetRect( > + IExplorerBrowser *iface, > + HDWP *phdwp, > + RECT rcBrowser) > +{ > + ExplorerBrowserImpl *This = (ExplorerBrowserImpl*)iface; > + TRACE("This: %p\n", This); > + > + return E_NOTIMPL; > If it isn't tested to really return E_NOTIMPL you should output a FIXME() with a stub comment. }; > > diff --git a/dlls/shell32/shell32_main.h b/dlls/shell32/shell32_main.h > index 8f51850..78b37a8 100644 > --- a/dlls/shell32/shell32_main.h > +++ b/dlls/shell32/shell32_main.h > @@ -99,6 +99,7 @@ HRESULT WINAPI FolderShortcut_Constructor(IUnknown * pUnkOuter, REFIID riid, LPV > HRESULT WINAPI MyDocuments_Constructor(IUnknown * pUnkOuter, REFIID riid, LPVOID *ppv); > HRESULT WINAPI RecycleBin_Constructor(IUnknown * pUnkOuter, REFIID riif, LPVOID *ppv); > HRESULT WINAPI QueryAssociations_Constructor(IUnknown *pUnkOuter, REFIID riid, LPVOID *ppOutput); > +HRESULT WINAPI ExplorerBrowser_Constructor(IUnknown *pUnkOuter, REFIID riid, LPVOID *ppv); > extern HRESULT CPanel_GetIconLocationW(LPCITEMIDLIST, LPWSTR, UINT, int*); > HRESULT WINAPI CPanel_ExtractIconA(LPITEMIDLIST pidl, LPCSTR pszFile, UINT nIconIndex, HICON *phiconLarge, HICON *phiconSmall, UINT nIconSize); > HRESULT WINAPI CPanel_ExtractIconW(LPITEMIDLIST pidl, LPCWSTR pszFile, UINT nIconIndex, HICON *phiconLarge, HICON *phiconSmall, UINT nIconSize); > diff --git a/dlls/shell32/shellole.c b/dlls/shell32/shellole.c > index 10244fd..54ae017 100644 > --- a/dlls/shell32/shellole.c > +++ b/dlls/shell32/shellole.c > @@ -77,6 +77,7 @@ static const struct { > {&CLSID_ShellLink, IShellLink_Constructor}, > {&CLSID_UnixDosFolder, UnixDosFolder_Constructor}, > {&CLSID_UnixFolder, UnixFolder_Constructor}, > + {&CLSID_ExplorerBrowser,ExplorerBrowser_Constructor}, > {NULL, NULL} > }; > Use consistent indentation style please. > + } > + > + ZeroMemory(&rc, sizeof(RECT)); > You don't test for a rectangle later, so there's no point to initialize it. > + > + hres = IExplorerBrowser_Initialize(lpEB, hwnd,&rc, NULL); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > + > + hres = IExplorerBrowser_Destroy(lpEB); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > + > + /* Initialize again */ > + IExplorerBrowser_Initialize(lpEB, hwnd,&rc, NULL); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > + > + /* Initialize twice */ > + IExplorerBrowser_Initialize(lpEB, hwnd,&rc, NULL); > + ok(SUCCEEDED(hres), "got (0x%08x)\n", hres); > Please avoid these HRESULT macros in tests, use explicit return values like S_OK. SUCCEEDED() hides things.

2 2

Re: [PATCH 4/4] shell32: Add IShellBrowser stub to ExplorerBrowser.
by testbot＠testbot.winehq.org 24 May '10

24 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2281 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: shell32: Add IShellBrowser stub to ExplorerBrowser.
by testbot＠testbot.winehq.org 24 May '10

24 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2279 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: shell32: Add ExplorerBrowser with IExplorerBrowser interface stub.
by testbot＠testbot.winehq.org 24 May '10

24 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2278 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: d3drm [patch 4/4]: Put private definitions in private header
by Alexandre Julliard 24 May '10

24 May '10

David Adam <david.adam.cnrs(a)gmail.com> writes: > From ee208ac901d7defe8ae5ddacfd4c65e36d290c4a Mon Sep 17 00:00:00 2001 > From: David Adam <david.adam.cnrs(a)gmail.com> > Date: Sun, 23 May 2010 05:37:35 +0200 > Subject: Put private definitions in the private header > > --- > dlls/d3drm/d3drm_private.h | 25 +++++++++++++++++++++++++ > dlls/d3drm/meshbuilder.c | 25 ------------------------- > 2 files changed, 25 insertions(+), 25 deletions(-) That's not an improvement. If the definitions are only needed in one file they should be in that file, not in a shared header. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9_36: Implement ID3DXLine_GetDevice with tests
by testbot＠testbot.winehq.org 24 May '10

24 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2276 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

software built and worked under wine but not in vista?
by Hin-Tak Leung 24 May '10

24 May '10

I have encountered a slightly strange issue with building the windows self-extracting installer release of ghostscript (http://www.ghostscript.com/) - the self-extracting installer is created with the winzip self-extractor package, which can be manually unzipped. The curious thing is that I can build the self-extracting installer under 32-bit wine with the win 7 SDK (on 64-bit linux). but when I tried to run the self-installer under Vista, it says %1 is not a valid win32 application. Manually unpacking the selft-extracting installer and run 'setupgs.exe' (the setup program) also gives 'setupgs.ese is not a valid win32 application' message. But the main ghostcript executable seems operational. (the setup program mostly only just copy the extracted files to "Program Files" and set up a few registry entries, but ghostscript doesn't not require those to work). So it seems that setupgs.exe is mis-compiled under wine with win7 sdk but just happened to also work under wine. Any idea how it might happen? I have checked things like end-of-line, but it is curious why the setupgs program works under wine but not in vista, the reverse situation compared to most.

5 11

too much dynamic loading?
by Marcus Meissner 24 May '10

24 May '10

Hi, As libjpeg and libpng bumped their major versions in the last months I had to adjust some of my library requires in my wine.spec file. This caused me thinking if it is really necessary to dynamically load nearly every library. Can we make some of those direct linking? libjpeg and libpng and some other lowlevel libraries might be useful. Opinions? Ciao, Marcus

6 10

Re: comctl32/listview: Fix vertical position offset for subitem rectangle
by testbot＠testbot.winehq.org 23 May '10

23 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2274 Your paranoid android. === W98SE (32 bit listview) === listview.c:2214: Test failed: got 1 === WNT4WSSP6 (32 bit listview) === listview.c:2214: Test failed: got 1 === W2KPROSP4 (32 bit listview) === listview.c:2214: Test failed: got 1 === WXPPROSP3 (32 bit listview) === listview.c:2214: Test failed: got 1 === W2K3R2SESP2 (32 bit listview) === listview.c:2214: Test failed: got 1 === WVISTAADM (32 bit listview) === listview.c:2214: Test failed: got 1 === W2K8SE (32 bit listview) === listview.c:2214: Test failed: got 1 === W7PRO (32 bit listview) === listview.c:2214: Test failed: got 1 === W7PROX64 (32 bit listview) === listview.c:2214: Test failed: got 1 === W7PROX64 (64 bit listview) === listview.c:2214: Test failed: got 1

1 0

Re: [1/2] shell32: Export lowlevel PIDL manipulation calls by name too
by testbot＠testbot.winehq.org 23 May '10

23 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2273 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2202: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: [PATCH] shlwapi: initial implement of SHAutoComplete
by Nikolay Sivov 23 May '10

23 May '10

On 5/23/2010 05:09, Hirofumi Katayama wrote: > See attachment. > Hi, some comments here. > +/****************************************************************************/ > + > +static const WCHAR szMRUList[] = L"MRUList"; > +static const WCHAR szRunMRU[] = > + L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\RunMRU"; > + > Don't use this L"" specifier for strings, use array initialization style instead. > +void *my_malloc(UINT size) > +{ > + return HeapAlloc(GetProcessHeap(), 0, size); > +} > + > +void *my_realloc(void *p, UINT size) > +{ > + if (p == NULL) > + return my_malloc(size); > + return HeapReAlloc(GetProcessHeap(), 0, p, size); > +} > + > +void my_free(void *p) > +{ > + HeapFree(GetProcessHeap(), 0, p); > +} > + > This isn't very useful, I think it's not a pain to use direct calls for this file. > +#define malloc my_malloc > +#define realloc my_realloc > +#define free my_free > +#define _wcsdup my__wcsdup > Don't do that. > + > +STDMETHODIMP IEnumString_fnQueryInterface(IEnumString *pEnumString, REFIID riid, void** ppvObject); > +STDMETHODIMP_(ULONG) IEnumString_fnAddRef(IEnumString *pEnumString); > +STDMETHODIMP_(ULONG) IEnumString_fnRelease(IEnumString *pEnumString); > +STDMETHODIMP IEnumString_fnNext(IEnumString *pEnumString, ULONG celt, LPOLESTR *rgelt, ULONG *pceltFetched); > +STDMETHODIMP IEnumString_fnSkip(IEnumString *pEnumString, ULONG celt); > +STDMETHODIMP IEnumString_fnReset(IEnumString *pEnumString); > +STDMETHODIMP IEnumString_fnClone(IEnumString *pEnumString, IEnumString **ppenum); > STDMETHODIMP isn't used in Wine code, use explicit WINAPI please. Also forward declaration for methods isn't used, usually a vtable is initialized just after all methods bodies. > +typedef struct > +{ > + IEnumStringVtbl *lpVtbl; > + LONG m_lRef; > + IMalloc * m_pMalloc; > + INT m_i; > + INT m_c; > + LPWSTR * m_strings; > +} EnumStringImpl; > Please avoid this MFC style like m_* for members, and use more descriptive names. > +EnumStringImpl *IEnumString_construct(VOID) > +{ > + EnumStringImpl *pEnumString; > + > + pEnumString = (EnumStringImpl *) malloc(sizeof(EnumStringImpl)); > + if (pEnumString != NULL) > + { > + pEnumString->lpVtbl =&EnumStringVtbl; > + pEnumString->m_lRef = 0; > + pEnumString->m_pMalloc = NULL; > + SHGetMalloc(&pEnumString->m_pMalloc); > + pEnumString->m_i = 0; > + pEnumString->m_strings = GetMRUStrings(&pEnumString->m_c); > + } > + return pEnumString; > +} > This is wrong. Initial refcount should be 1. > +EnumStringImpl *IEnumString_construct(VOID) > > + > +VOID IEnumString_destruct(EnumStringImpl *pEnumString) > Should be static both, and methods too of course. > + pEnumString->lpVtbl->AddRef(pEnumString); > No need for that, use defined macros to call methods from vtables. > +STDMETHODIMP_(ULONG) IEnumString_fnAddRef(IEnumString *pEnumString) > +{ > + EnumStringImpl *this = (EnumStringImpl *) pEnumString; > + this->m_lRef++; > + return (ULONG) this->m_lRef; > +} > You should use interlocked increment here (same for _Release()). > + pProp->fnOldWndProc = (WNDPROC) SetWindowLongPtr(hwndEdit, GWLP_WNDPROC, (LONG_PTR) AutoCompleteEditWndProc); > Did you ever build it? I think we have a blocking things for using implicit A/W calls.

1 0

make "bisected" a keyword in bugzilla?
by Wolfram Sang 23 May '10

23 May '10

Hi, I noticed that Wylda uses "--private keyword: bisected" when appropriate. IMHO this could be useful as a real keyword, e.g. if you search for bugs you'd like to try tackling. Has this been considered already? Regards, Wolfram

8 10

Re: kernel32/tests: check return value of alarmThread in test_NamedPipe_2() (try 2)
by Andrew Nguyen 22 May '10

22 May '10

On Sat, May 22, 2010 at 5:02 AM, Austin English <austinenglish(a)gmail.com> wrote: > Changes from try 1: > Fix another typo. > Set LastError before checking it > Print LastError as a decimal > Don't check for INVALID_HANDLE_VALUE as a return value of > CreateThread, instead make sure serverThread is not NULL. > > -- > -Austin > > > > You're calling SetLastError(0xdeadbeef) at the wrong time in the pipe server subtests. If CreateThread fails, you will unconditionally print the decimal representation of 0xdeadbeef in the failure messages. SetLastError has to be called before CreateThread to ensure that the failure messages print a last error that the preceding CreateThread call sets.

2 1

Re: [5/5] winemenubuilder: remove legacy PNG and XPM conversion code
by Vincent Povirk 22 May '10

22 May '10

Fools! With this patch, the WIC empire shall finally be complete. Er, I mean, this is pretty cool. And thanks for the ICO decoder fix. On Sat, May 22, 2010 at 11:01 AM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * winemenubuilder: remove legacy PNG and XPM conversion code > > The patch may look frighteningly long but the majority is just > harmless deletions :-). > > Damjan Jovanovic > > > >

1 0

Re: crypt32: use ret in compareStore() (try 2)
by Juan Lang 22 May '10

22 May '10

Hi Austin, + SetLastError(0xdeadbeef); ret = CertSaveStore(store, X509_ASN_ENCODING, CERT_STORE_SAVE_AS_STORE, CERT_STORE_SAVE_TO_MEMORY, &blob, 0); + todo_wine ok(ret && GetLastError() == CRYPT_E_NOT_FOUND, "CertSaveStore failed. Expected CRYPT_E_NOT_FOUND, got %d\n", GetLastError()); In general we don't check last error when a function succeeds. I think an ok(ret, ...) would be fine here. Also, I think it's neater to print crypt errors as %08x, as the errors are generally 0x8009.... Thanks for fixing this, I was just sloppy not to have checked ret in the first place! --Juan

1 0

Re: user32/tests: check return value of GetUpdateRect in test_validatergn (try 2)
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2258 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00730134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00750134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00770134 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00040224 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00A00134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00A10134 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00190138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00040224 fg 00010040 in hook HCBT_SETFOCUS

1 0

Re: kernel32/tests: use ret in load_blackbox() (try 2)
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2254 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:302: Test failed: Timed out waiting for the child to crash debugger.c:316: Test failed: wrong exit code : 00000103 debugger.c:327: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtDCAB.tmp': read=0 debugger.c:332: Test failed: wrong debugger argument count: -28562032 debugger.c:333: Test failed: the child and debugged pids don't match: 368 != 2046 debugger.c:302: Test failed: Timed out waiting for the child to crash debugger.c:309: Test failed: wrong exit code : 00000103 debugger.c:327: Test failed: Timed out waiting for the debugger debugger.c:149: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtB1BC.tmp': read=0 debugger.c:332: Test failed: wrong debugger argument count: -28562032 debugger.c:333: Test failed: the child and debugged pids don't match: 2404 != 2046 Timeout

1 0

Re: kernel32/tests: check return value of alarmThread in test_NamedPipe_2()
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > alarmThread = CreateThread(NULL, 0, alarmThreadMain, (void *) 20000, 0, &alarmThreadId); > + ok(alarmThread != INVALID_HANDLE_VALUE, "CreateThread\n"); CreateThread doesn't return INVALID_HANDLE_VALUE on failure. Clarifying the error message and printing last error (in decimal) would be better. -- Dmitry.

2 1

Re: user32/tests: check return value of GetUpdateRect in test_validatergn
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2251 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070136 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00300138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00090136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000D0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000E0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 007F0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS

1 0

Re: Re: user32/tests: check return value of DdeClientTransaction in test_initialisation()
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2250 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:2042: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: user32/tests: check return value of GetUpdateRect in test_validatergn
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > ValidateRect( hwnd, &rc); > ret = GetUpdateRect( child, &rc2, 0); > + ok(!ret, "GetUpdateRect failed %08x\n", GetLastError()); > ok( rc2.left == 0 && rc2.top == 0 && rc2.right == 0 && rc2.bottom == 0, > "Update rectangle %d,%d-%d,%d is not empty!\n", rc2.left, rc2.top, > rc2.right, rc2.bottom); > @@ -3228,6 +3230,7 @@ static void test_validatergn(HWND hwnd) > rgn = CreateRectRgnIndirect( &rc); > ValidateRgn( hwnd, rgn); > ret = GetUpdateRect( child, &rc2, 0); > + ok(!ret, "GetUpdateRect failed %08x\n", GetLastError()); Please set last error to 0xdeadbeef prior checking it, and print last error value in decimal. -- Dmitry.

1 0

Re: kernel32/tests: use ret in load_blackbox()
by testbot＠testbot.winehq.org 22 May '10

22 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2243 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:301: Test failed: Timed out waiting for the child to crash debugger.c:315: Test failed: wrong exit code : 00000103 debugger.c:326: Test failed: Timed out waiting for the debugger debugger.c:148: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wtADEB.tmp': read=0 debugger.c:331: Test failed: wrong debugger argument count: -28562032 debugger.c:332: Test failed: the child and debugged pids don't match: 2612 != 2046 debugger.c:301: Test failed: Timed out waiting for the child to crash debugger.c:308: Test failed: wrong exit code : 00000103 debugger.c:326: Test failed: Timed out waiting for the debugger debugger.c:148: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wt82DC.tmp': read=0 debugger.c:331: Test failed: wrong debugger argument count: -28562032 debugger.c:332: Test failed: the child and debugged pids don't match: 2412 != 2046 Timeout

1 0

Re: kernel32/tests: use ret in load_blackbox()
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > ret=ReadFile(hFile, blackbox, size, &read, NULL); > + ok(ret, "ReadFile failed: %08x\n", GetLastError()); Printing last error without prior setting it to 0xdeadfeef won't really help. Also errors returned by GetLastError() are defined in decimal in winerror.h. -- Dmitry.

1 0

Re: gdi32/tests: use ret in test_CreateFontIndirect()
by Dmitry Timoshkov 22 May '10

22 May '10

Austin English <austinenglish(a)gmail.com> wrote: > @@ -3096,6 +3096,7 @@ static void test_CreateFontIndirect(void) > hfont = CreateFontIndirectA(&lf); > ok(hfont != 0, "CreateFontIndirectA failed\n"); > ret = GetObject(hfont, sizeof(getobj_lf), &getobj_lf); > + ok(ret, "GetObject failed: %08x\n", GetLastError()); Printing last error without prior setting it to 0xdeadfeef won't really help. Also errors returned by GetLastError() are defined in decimal in winerror.h. -- Dmitry.

1 0

Re: kernel32/tests: check return value of alarmThread in test_NamedPipe_2()
by Andrew Nguyen 22 May '10

22 May '10

On Sat, May 22, 2010 at 2:06 AM, Austin English <austinenglish(a)gmail.com> wrote: > Also fix a typo. > > Passes WTB: > https://testbot.winehq.org/JobDetails.pl?Key=2242 > > -- > -Austin > > > > While you're at it, you might as well fix the "change" typo.

1 0

Re: crypt32/tests: remove ret from testAddSerialized, where it's not really used
by Nikolay Sivov 22 May '10

22 May '10

On 5/21/2010 22:45, Austin English wrote: > Gerald's made good progress here, there's only 81 of these left in > wine-1.1.44-427-ga06a191. > > - BOOL ret; > CRYPT_DATA_BLOB blob = { 0, NULL }; > > - ret = CertSaveStore(store, X509_ASN_ENCODING, CERT_STORE_SAVE_AS_STORE, > + CertSaveStore(store, X509_ASN_ENCODING, CERT_STORE_SAVE_AS_STORE, > Why not test for it?

2 1

Re: winemp3.acm: Avoid using the long type.
by Chris Robinson 21 May '10

21 May '10

Now to the list... On Friday, May 21, 2010 9:32:17 am you wrote: > Chris Robinson wrote: > > On Friday, May 21, 2010 3:13:36 am Michael Stefaniuc wrote: > >> @@ -191,7 +191,7 @@ static void mp3_horse(PACMDRVSTREAMINSTANCE adsi, > >> > >> if (ret == MPG123_NEW_FORMAT) > >> { > >> > >> - long rate; > >> + LONG_PTR rate; > >> > >> int channels, enc; > >> mpg123_getformat(amd->mh, &rate, &channels, &enc); > > > > I'm not sure this change is correct, when the function itself is > > expecting a pointer to an actual long. > > Yes, that's why I used LONG_PTR. That's the Win32 way of saying "I want > a real 'long' like everybody else is using" aka one that has the same > size as a pointer. A LONG_PTR is a signed integer large enough to hold a pointer value. A long may or may not be the same size. This would break if built for 64-bit Windows, for example, where a long is still 32 bits (and what the 64-bit Windows version of the lib will expect), while a LONG_PTR is 64 bits.

2 2

Fw: Re: Release plans
by James Mckenzie 21 May '10

21 May '10

To the list. -----Forwarded Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: May 21, 2010 8:20 AM >To: Joerg-Cyril.Hoehle(a)t-systems.com >Subject: Re: Release plans > >Joerg-Cyril.Hoehle(a)t-systems.com wrote: >> >>>> And I didn't write trivial Mac patches either, e.g. to have >>>> wineprefixcreate symlink c:\users\xyz\ Desktop + Videos + Documents + >>>> Music to /Users/xyz/Desktop/ etc. This happens on Linux, not on MacOS. >>>> That's another (example of a) missing element. >>>> (Why didn't I write it? Because I was unsure where to put the #ifdef) >>>Isn't that linking done relative to $HOME, which should resolve to >>>/Users/xyz on Mac? >>That's not the problem. What I also don't know is whether I could hardcode >>the directories ~/Documents etc. > >AFIAK, I would not hard code them, but give a default of $HOME/Documents and $HOME/Desktop (this would allow users to change the directory, maybe through the registry or through environment variables. (these already exist in my /Users/xyz, >>but what about Tiger? > >I don't think there are many Intel Macs running Tiger anymore and Darwine is completely dead. > >>or whether I ought to call some OSX API that >>yields the name of the dir (and possibly creates it if it does not yet exist). > >This is a third idea that we may want to look at. > >>I'm not familiar at all with Mac APIs, but it sounds like an easy patch >>for somebody with a little MacOS programming knowledge. >> >Hmmm. >> >>>> What can Mac users expect from this release? >>>Hopefully, conversion to Linux :-). >>Actually, one day I was fed up with the Gnome and KDE4 GUIs, >>so I started looking for something else. The Mac Mini with >>NVidia came out right at that time: extremely silent (except >>for the CD-ROM), excellent graphics (by far better than >>any onboard Intel I knew previously) and it's a UNIX. >> >My feelings exactly. If Gnome and KDE were so good, why are there other Linux windows management tools? > >James McKenzie

1 0

[website] German translation of Only support Ubuntu 9.10 and 10.04
by André Hentschel 21 May '10

21 May '10

--- templates/de/download.template | 2 +- templates/de/download/deb.template | 77 +++++++---------------------------- 2 files changed, 17 insertions(+), 62 deletions(-) -- Best Regards, André Hentschel

1 0

Re: software built and worked under wine but not in vista?
by Hin-Tak Leung 21 May '10

21 May '10

--- On Fri, 21/5/10, Hin-Tak Leung <hintak_leung(a)yahoo.co.uk> wrote: > Krasuckas <saulius2(a)ar.fi.lt> > wrote: > > > > > > http://www.ghostscript.com/~hintak/setupgs-vista.exe > > > > http://www.ghostscript.com/~hintak/setupgs-wine.exe > > > > > > There are a few differences I spotted between the > two > > executables: > > > 1) setupgs-wine.exe has wrong image size, > changing it > > from 0x2b200 to > > > 0x2b000 makes the executable working under win7. But that has to be a bug in wine - that it doesn't check the image size and loads PE with an invalid image size? (how that end up being invalid is a different issue).

2 1

Re: winemp3.acm: Avoid using the long type.
by Chris Robinson 21 May '10

21 May '10

On Friday, May 21, 2010 3:13:36 am Michael Stefaniuc wrote: > @@ -191,7 +191,7 @@ static void mp3_horse(PACMDRVSTREAMINSTANCE adsi, > > if (ret == MPG123_NEW_FORMAT) > { > - long rate; > + LONG_PTR rate; > int channels, enc; > mpg123_getformat(amd->mh, &rate, &channels, &enc); I'm not sure this change is correct, when the function itself is expecting a pointer to an actual long.

2 1

dinput2
by David Adam 21 May '10

21 May '10

Hello many distro ship the X-server with dinput2. More and more old games work pretty well now with Wine, but the mouse. Does anyone plan to work on the infamous bug 6971? It would be great if it could be implemented for the official release of Wine. It would do a big buzz :D Cheers David

6 6

Re: taskmgr: Update Slovenian translation [resend]
by Paul Vriens 21 May '10

21 May '10

On 05/21/2010 05:48 PM, Matej Špindler wrote: > Anything wrong with this patch? I sent it a week ago and didn't receive > any comments. > > > > Hi Matej, If you look at http://source.winehq.org/patches/ you will see that your patch (number 61589) had an apply failure. I tried your patch just now and I don't have an apply failure here, so I'm not sure what went wrong. -- Cheers, Paul.

1 0

Fw: Re: Release plans
by James Mckenzie 21 May '10

21 May '10

To the list.... -----Forwarded Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: May 20, 2010 12:49 PM >To: Damjan Jovanovic <damjan.jov(a)gmail.com> >Subject: Re: Release plans > >> >>On Fri, May 14, 2010 at 12:31 PM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: >>> Hi, >> >>Hi >> >>>>The 64-bit support is now more or less complete >>> I hope I can finish my MCI parser patches in time. Without them, >>> every 64bit app using MCI string commands is likely to crash (OTOH >>> MCI commands work (those using the MCI_*_PARAMS structures)). >>> >>> >>> What can Mac users expect from this release? >> >>Hopefully, conversion to Linux :-). >> >No. BTW, I've used: > >TRSDOS (Model III) >MS-DOS 1.0/2.0/3.0/4.0/5.0/6.0 (6.22) and updates >DR-DOS 4.0/5.0 >Windows 3.1, 3.11WFW, 95, 98, NT 3.51, NT 4.0, XP and Vista >OS/2 >Linux, Linux and more Linux (it is still user unfriendly) >Mac Classic >MacOSX 10.3/.4/.5 > >I consider MacOSX the most polished as a User Experience of all of them. > >>> Yesterday I installed an app with wine-1.1.44 on Mac OS (instead of >>> moving it from a Linux install). It was disappointing from a user POV: >>> >>> - Wine created .desktop files that work on Linux but don't make sense >>> on Mac OS. Here I've been thinking about a simple patch that would >>> instead generate a .command file like I've described in the FAQ. >>> OTOH, Steven Edwards IIRC once had a much more elaborate patch about >>> better Mac OS integration, rejected last year. >>> >>> - In the hidden directory ~/.local/share/icons/ it created .xpm files >>> that the Finder does not display. .png would be displayed. >> >>winemenubuilder generates .png only for 24 and 32 bits-per-pixel >>icons, all other resolutions get converted to .xpm. I am planning to >>change it to make .png's for everything, since thumbnailing .lnk files >>requires .png as output, and then keep .xpm only as a fallback when >>libpng is not installed and we're not thumbnailing. This should help >>you on MacOS too. > >Thank you. It is not a good thing that MacOSX cannot use .xpm files "out of the box". >> >>> I have no idea how the other packages built atop Wine behave on MacOS behave: >>> - Kronenberg's WineBottler >>> - doh's WineSkin >>> - Macports build >>> - CodeWeaver's CrossOver4Mac >>> I assume they create nice icons that the user can click after an install. >>> >>> Regarding the former 2 packages, I've always been wondering why >>> there's some sort of split in the Wine+Mac user community. Obviously >>> the stock Wine fails to meet the Mac user's expectations, such that >>> several people start and write something better integrated with the >>> GUI -- but not integrated into the Wine source. >> >>From visiting the websites, I see Kronenberg's Winebottler doesn't >>provide source (the source link takes you to an empty repository; >>interestingly the LGPL requires you to provide the changed source if >>you distribute the software...) > >That's because Mike no longer makes any changes directly to the Wine code. He states that on the site (or did.) >>Wineskin is a complete installation >>wrapper that I would guess does the desktop integration itself, > >That's what doh123 states. It is a wrapper program that builds an exportable .app product that will start Wine and then any program that you wrap with it. He also gets the files for specific programs using winetricks. > >>macports.org is down but http://wine.darwinports.com/ doesn't have any >>relevant patches, and I don't have CrossOver4Mac or a Mac to test it >>and see what it does. >> >CrossOver Mac is and will remain a commercial product. They do all sorts of magic to fix the brokenness of Apple/XQuartz(s) X11's inability to display full screen and other enhancements specific to making Wine work better on the MacOSX platform. > >>Maybe it's that Linux users generally expect the free software to be >>good, while Mac users generally expect good software to cost money, so >>when someone develops the extra bits for Wine on Mac, they either keep >>them to themselves or sell them? Also, I think more Wine developers >>use Linux than Mac, so there's less interest in fixing Wine on Mac. >> >No. Mac users expect Mac software to just damn work. We don't want to 'tweek' and 'twist' and apply patch after patch after patch. If it don't work, out of the box, it goes. We don't have time to 'play'. So, many of us use Crossover. We pay for others to fix that which is broken. That being said, there are those of us that really like the challange of making Windows software work on the Mac as well as making Linux software work on the Mac. And we EXPECT to get paid for it. > >Please be aware that 'free' software NEVER IS. The phrase "You get what you pay for" really applies here. Again, Mac users have been conditioned to 'it works'. Wine is not, at the present time, ready for this level of acceptance and may never be. And no, Mac users are not going to switch to Linux. Some may run Ubuntu, but a vast majority unpack the system, plug it in and go to work. > >>> And I didn't write trivial Mac patches either, e.g. to have >>> wineprefixcreate symlink c:\users\xyz\ Desktop + Videos + Documents + >>> Music to /Users/xyz/Desktop/ etc. This happens on Linux, not on MacOS. >>> That's another (example of a) missing element. >>> (Why didn't I write it? Because I was unsure where to put the #ifdef) >> >>Isn't that linking done relative to $HOME, which should resolve to >>/Users/xyz on Mac? >> >Correct. When a new user is created on the Mac, the user name, less spaces and special characters, is used for the folder name. The Desktop folder IS the Mac Aqua desktop and I highly suggest NOT placing .desktop and .lnk files there. Unlike Windows users, most Mac users like to keep their desktops 'clean'. Doing what you desire will take more work and a good poll of the Mac community before implementation. This is part of the reason that Apple has used the Dock and created Documents/Download folders on it. Maybe that would be a good place to put Wine application icons. > >Please keep in mind that this is not to bash Linux or Windows users. Each category of user has their own method of OS and system use. > >James McKenzie

1 0

TRACE(...., debugstr_w(uninitialised data))?
by Joerg-Cyril.Hoehle＠t-systems.com 21 May '10

21 May '10

Hi, winmm/mci.c contains some code like this: TRACE("=> 1/ %x (%s)\n", dwRet, debugstr_w(lpstrRet)); However, in case of error, the lpstrRet buffer is likely not initialised. This could cause 1. debugstr_w to choke on bad/unconvertible data (not even 0-terminated); 2. Valgrind errors (I don't know whether the Valgrind warnings I observe are due to this line of code). Am I worrying too much or should any such piece of code be protected by TRACE("=> 1/ %x (%s)\n", dwRet, LOWORD(dwRet) ? "" : debugstr_w(lpstrRet)); (actually, an even more convoluted test is needed because of MCI_INTEGER_RETURNED) Or is it not worth careing about because it's within TRACE() only? I assume that debugstr_w is not executed when that channel is not traced. Correct? Regards, Jörg Höhle

2 1

Re: yesterday's benchmark results: xubuntu makes 3dmark happier
by Dan Kegel 21 May '10

21 May '10

On Fri, May 21, 2010 at 7:10 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > Do you run your normal-Ubuntu tests with Compiz enabled? Apparently with > the nVidia drivers in particular that can make a big difference: > > http://www.phoronix.com/scan.php?page=article&item=compiz_speed_test&num=5 No, I think I had that solidly disabled for all runs. It wouldn't hurt for my script to check all these things, though.

1 0

yesterday's benchmark results: xubuntu makes 3dmark happier
by Dan Kegel 21 May '10

21 May '10

Yesterday's results were 8 hours late because of an internet outage here. http://kegel.com/wine/yagmarkdata/00index.html http://kegel.com/wine/yagmarkdata/E8400-GT_220-Ubuntu_10.04_LTS-e8400-wine-… Looking at the graphs, it seems that all benchmarks are happier under xubuntu with nonessential services shut down as described yesterday. 3dmark (all versions) is affected lots more than Heaven.

1 0

Re: [2/2] winemenubuilder: add thumbnail mode for .lnk files
by Hans Leidekker 21 May '10

21 May '10

On Fri, 2010-05-21 at 07:52 +0200, Damjan Jovanovic wrote: > --- winemenubuilder00.c 2010-05-21 07:44:48.195864397 +0200 > +++ winemenubuilder.c 2010-05-21 07:47:25.591878489 +0200 This will not apply from the root. This patch set needs your previous patches to make sense, right? > Changelog: > * winemenubuilder: add thumbnail mode for .lnk files winemenubuilder is a winelib app, it may not run in the prefix that the .lnk file was created in. So while these patches get rid of duplicate launchers on the desktop, we lose support for multiple prefixes.

2 1

Trying to fix a bug, stuck at cross-compiling
by Alexandru Băluț 21 May '10

21 May '10

Hi, I'm trying to fix bug 12804, and made some changes to winecfg, and I need to test how it works on Windows. I followed the instructions from http://wiki.winehq.org/CompilingDLLsUsingMingw - Cross Compiling the Whole Tree, but I get an error: $ ../wine-crossc/configure --host=i586-mingw32msvc --with-wine-tools=../build-native --without-freetype --without-x [...] checking for the directory containing the Wine tools... configure: error: could not find Wine tools in ../build-native This seems to happen because the ../build-native/tools/winebuild directory does not exist. When I ran "make tools", in ../build-native, no error occurred. Any idea why this happens? Is there another way to build winecfg as an exe? Thanks, Alex

4 5

Re: wined3d: Avoid using the long type.
by Henri Verbeet 21 May '10

21 May '10

This will conflict with my patches from earlier today.

1 0

Re: [4/6] d3dx9: Implement D3DXCreateTexture plus tests
by Henri Verbeet 21 May '10

21 May '10

On 20 May 2010 23:05, Owen Rudge <orudge(a)codeweavers.com> wrote: > + hr = D3DXCreateTexture(device, D3DX_DEFAULT, 63, 0, 0, 0, D3DPOOL_DEFAULT, &texture); > + ok(hr == D3D_OK, "D3DXCreateTexture returned %#x, expected %#x\n", hr, D3D_OK); > + > + if (texture) > + { > + hr = IDirect3DTexture9_GetLevelDesc(texture, 0, &desc); > + > + ok(desc.Width == 63, "Returned width %d, expected %d\n", desc.Width, 63); > + ok(desc.Height == 63, "Returned height %d, expected %d\n", desc.Height, 63); Doesn't that depend on NPOT texture support in the device?

1 0

Re: [2/6] d3dx9: Implement D3DXCheckTextureRequirements
by Henri Verbeet 21 May '10

21 May '10

On 20 May 2010 23:05, Owen Rudge <orudge(a)codeweavers.com> wrote: > +BOOL is_pow2(UINT num); > +UINT make_pow2(UINT num); I'm not so convinced these are going to be very useful for anything outside texture.c. > +BOOL is_pow2(UINT num) > +{ > + if (!num) return FALSE; > + > + return !(num & (num - 1)); > +} Do you really care that 0 is not a real power of two for these texture functions? It's not a valid width / height anyway. > + if ((caps.TextureCaps & D3DPTEXTURECAPS_POW2) && (!is_pow2(*width))) > + make_pow2(*width); ... > + if ((caps.TextureCaps & D3DPTEXTURECAPS_POW2) && (!is_pow2(*height))) > + make_pow2(*height); You have to assign to result to something for it to be of any use. > + max_mipmaps = 9; Where does that 9 come from? (I can easily guess, but...) > + hr = IDirect3DDevice9_GetDirect3D(device, &d3d); > + > + if (SUCCEEDED(hr)) > + IDirect3DDevice9_GetCreationParameters(device, &params); > + > + if (SUCCEEDED(hr)) > + IDirect3DDevice9_GetDisplayMode(device, 0, &mode); > + > + if (SUCCEEDED(hr)) It's probably nicer to check for failure and jump to some cleanup code. Also, you should check all the calls for errors, not just GetDirect3D(). The width / height handling looks a bit complicated to me. You should probably first calculate the width and height using local variables, and only assign those to *width/*height afterwards. Something along these lines: { UINT w = (width && *width) ? *width : 1; UINT h = (height && *height) ? *height : 1; if (w == D3DX_DEFAULT && h == D3DX_DEFAULT) w = h = 256; else if (w == D3DX_DEFAULT) w = h; else if (h == D3DX_DEFAULT) h = w; ... if (width) *width = w; if (height) *height = h; }

1 0

Re: [5/6] d3dx9: Add basic implementation of D3DXFilterTexture, plus tests
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2207 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: [2/2] shell32: Export ILFree by name
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2202 Your paranoid android. === WNT4WSSP6 (32 bit shlfileop) === shlfileop.c:2202: Test failed: SHGetNewLinkInfoA succeeded

1 0

Re: comctl32/listview: Don't forward WM_COMMAND to parent if we don't have an Edit box (resent)
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2201 Your paranoid android. === W7PRO (32 bit listview) === listview.c:4393: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4398: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

1 0

Re: [3/9] ole32: Validate pointer parameters in MkParseDisplayName.
by Alexandre Julliard 20 May '10

20 May '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -814,12 +814,53 @@ static void test_MkParseDisplayName(void) > static const WCHAR wszDisplayNameProgId1[] = {'S','t','d','F','o','n','t',':',0}; > static const WCHAR wszDisplayNameProgId2[] = {'@','S','t','d','F','o','n','t',0}; > static const WCHAR wszDisplayNameProgIdFail[] = {'S','t','d','F','o','n','t',0}; > + static const WCHAR wszEmpty[] = {0}; > char szDisplayNameFile[256]; > WCHAR wszDisplayNameFile[256]; > + int i; > + > + const struct > + { > + LPBC pbc; > + LPCOLESTR szDisplayName; > + LPDWORD pchEaten; > + LPMONIKER *ppmk; > + } invalid_parameters[] = > + { > + {NULL, NULL, NULL, NULL}, > + {NULL, NULL, NULL, &pmk}, > + {NULL, NULL, &eaten, NULL}, > + {NULL, NULL, &eaten, &pmk}, > + {NULL, wszEmpty, NULL, NULL}, > + {NULL, wszEmpty, NULL, &pmk}, > + {NULL, wszEmpty, &eaten, NULL}, > + {NULL, wszEmpty, &eaten, &pmk}, > + {pbc, NULL, NULL, NULL}, > + {pbc, NULL, NULL, &pmk}, > + {pbc, NULL, &eaten, NULL}, > + {pbc, NULL, &eaten, &pmk}, > + {pbc, wszEmpty, NULL, NULL}, > + {pbc, wszEmpty, NULL, &pmk}, > + {pbc, wszEmpty, &eaten, NULL}, > + {pbc, wszEmpty, &eaten, &pmk}, > + }; This won't do what you want, there's nothing in pbc at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg audio tab contents
by Maarten Lankhorst 20 May '10

20 May '10

Hello Joerg, On 18-05-10 15:33, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > did you notice that in winecfg-1.1.44, the audio tab content > is broken: nothing is displayed below ALSA, and OSS lists 5 > things only. There used to be much more content. > This is likely a side effect from not calling DRVM_INIT before calling GETNUMDEVS, meaning the devices are closed. I sent in a bunch of patches so that things aren't initialized before they are used. Manually calling DRVM_INIT might help, but then you would have to make sure you're not using ANY of the winmm functions that also talk to the driver. a patch like this would probably fix it: - if (wodMessagePtr) + if (wodMessagePtr && wodMessagePtr(0, DRVM_INIT, 0, 0, 0)) num_wod = wodMessagePtr(0, WODM_GETNUMDEVS, 0, 0, 0); However, it is best to make sure that DRVM_INIT is only called once to avoid ill side effects. I wouldn't worry about it much, After 1.2 is shipped the audio tab will be all gone anyhow. :) Cheers, Maarten

2 1

Re: msi: Avoid a potential NULL pointer dereference (coccicheck).
by Paul Vriens 20 May '10

20 May '10

On 05/20/2010 01:15 AM, Michael Stefaniuc wrote: > The last "goto done" is for si == NULL. When MSI_GetSummaryInformationW > returns NULL there is a crash. > --- > dlls/msi/msi.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c > index 3170e6d..9c08d1b 100644 > --- a/dlls/msi/msi.c > +++ b/dlls/msi/msi.c > @@ -551,7 +551,8 @@ static UINT MSI_ApplicablePatchW( MSIPACKAGE *package, LPCWSTR patch ) > > done: > msiobj_release(&patch_db->hdr ); > - msiobj_release(&si->hdr ); > + if (si) > + msiobj_release(&si->hdr ); > return r; > } > Hi Michael, This one is mentioned by Coverity (#970). Marcus marked this one as 'FALSE' with the remark: "hdr is at position 0, so this will be NULL and msiobj_release handles it." Thoughts? -- Cheers, Paul.

4 8

Re: [7/7] msi: Add more tests for feature overrides.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2196 Your paranoid android. === W2K8SE (32 bit install) === Timeout === W7PROX64 (32 bit install) === install.c:5350: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5369: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5394: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5413: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8203: Test failed: RegQueryValueExA failed 2 (0) install.c:8466: Test failed: file not installed install.c:8478: Test failed: file not installed install.c:8479: Test failed: file not installed install.c:8487: Test failed: file removed install.c:8488: Test failed: directory removed install.c:8494: Test failed: file not installed install.c:8495: Test failed: file not installed install.c:8503: Test failed: file removed install.c:8504: Test failed: directory removed install.c:8892: Test failed: file not created install.c:8893: Test failed: file not created install.c:8959: Test failed: file not created install.c:8960: Test failed: file not created install.c:8962: Test failed: file not created install.c:8968: Test failed: file removed install.c:8973: Test failed: directory removed install.c:9020: Test failed: key not removed install.c:9030: Test failed: key not removed install.c:9041: Test failed: key not removed install.c:9115: Test failed: got 6 expected 0 install.c:9121: Test failed: got 6 expected 0 install.c:9124: Test failed: got 6 expected 0 install.c:9126: Test failed: file removed install.c:9271: Test failed: key not created

1 0

Re: [6/7] msi: Test the reference count on the installer object retrieved from a session object.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2195 Your paranoid android. === W7PROX64 (64 bit automation) === automation.c:2468: Test failed: Expected imaname, got automation.c:2485: Test failed: Expected imaname, got

1 0

Re: [TRY 2] shdocvw: Added IOleLink stub implementation.
by Jacek Caban 20 May '10

20 May '10

On 5/20/10 9:33 AM, Ilya Shpigor wrote: +void WebBrowser_OleLink_Init(WebBrowser *This) +{ + This->lpOleLinkVtbl =&OleLinkVtbl; +} You don't need a separated function for that. Just use WebBrowser_OleObject_Init. Jacek

1 0

Re: winmm: Have MCI drivers handle notification for MCI_OPEN.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2193 Your paranoid android. === W98SE (32 bit mci) === mci.c:613: Test failed: Expect message 0001 from play to 250 wait notify mci.c:620: Test failed: got 0004 instead of MCI_NOTIFY_xyz 0000 from command after close mci.c:784: Test failed: mci pause wait returned MMSYSERR 5 mci.c:798: Test failed: mci pause (space) wait returned MMSYSERR 5 mci.c:801: Test failed: mci pause wait returned MMSYSERR 5 mci.c:815: Test failed: Expect message 0004 from play (aborted by close)

2 1

Re: quartz: Avoid using the long type.
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2159 Your paranoid android. === WNT4WSSP6 (32 bit referenceclock) === referenceclock.c:99: Test failed: Unable to create reference clock from system clock 80040154

2 1

Re: comctl32/listview: Don't forward WM_COMMAND to parent if we don't have an Edit box
by testbot＠testbot.winehq.org 20 May '10

20 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2163 Your paranoid android. === W7PRO (32 bit listview) === listview.c:4393: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:4398: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

D3DX9: how to implement D3DXDeclaratorFromFVF
by David Adam 20 May '10

20 May '10

Hello, I would like to implement the function D3DXDeclaratorFromFVF. My numerous attempts to do this were rejected (specially my copy/paste of the function vdecl_convert_fvf from d3d9/vertexdeclaration.c. Does anyone know a way to implement it? Thanks in advance David

1 0

performance bot results - this time with screensaver off
by Dan Kegel 20 May '10

20 May '10

Every benchmark did at least a little better, and 3dmark2001 did a lot better, today: http://kegel.com/wine/yagmarkdata/E8400-GT_220-Ubuntu_10.04_LTS-e8400-wine-… Why? Well, there are oodles of processes running in Gnome by default, plus the workrave app I use for my RSI. I had killed some of them on the benchmark machine earlier, but forgot to kill them again after rebooting; just noticed that last night. Today's results are with three more processes killed: workrave, gnome-screensaver, and bluetooth-applet. That might help explain the results a bit. I did 'sudo apt-get install xubuntu-desktop' just now, rebooted, edited ~/.pulse/client.conf to disable pulseaudio autospawn, and killed pulseaudio xscreensaver update-notifier /usr/share/system-config-printer/applet.py /usr/lib/gvfs//gvfs-fuse-daemon bluetooth-applet There are now 'only' 148 or so processes in my idle system, only 29 of which are the interactive user; it seems fairly stripped down. I also ran nvidia-settings again to pick 'maximum performance' rather than adaptive, and told xfce to never blank the monitor. Let's see if all that makes a difference. (I need to make a big checklist of Things To Do After Rebooting.) - Dan

1 0

The WineHQ About page needs a picture
by Scott Ritchie 19 May '10

19 May '10

I was doing some housecleaning work looking at the WineHQ website, and I realized we still have an awful lot of flat, wide text on the About page. This is the perfect place to collapse it into a column and fill the right side of the screen with an image. But...what image? Thanks, Scott Ritchie

3 2

re: wininet: Combine certificate errors in HTTP_OpenConnection
by Dan Kegel 19 May '10

19 May '10

>> Test can't be easily added to wine because we don't have pages to test >> certificate errors on. > >That should be addressed, no? E.g. with a page hosted at winehq.org >with a self-signed certificate? Or look at how Chromium does its ssl unit tests, by launching a little server written in python: http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=net/sock… http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=net/sock… - Dan

3 3

Re: [PATCH 4/4] wininet: Fix variables values after redirection in HTTP_HttpSendRequestW
by Alexandre Julliard 19 May '10

19 May '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/wininet/http.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:405: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 1 times, received 2 times http.c:406: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 1 times, received 2 times make: *** [http.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Heaven 2 benchmark in good shape...
by Dan Kegel 19 May '10

19 May '10

Yesterday's performance bot results, http://kegel.com/wine/yagmarkdata/E8400-GT_220-Ubuntu_10.04_LTS-e8400-wine-… show that the Heaven 2 d3d9 benchmark had a couple 10% improvements in the past week (up from 10 to 11 and then 12 fps). If we're going to see improvements in a benchmark, that's the best one, since it probably matches modern games more closely than the others. 3dmark2001 had a very good day (http://kegel.com/wine/yagmarkdata/wine-1.1.44-19-vs-wine-1.1.44-72.txt) but returned to its poor scores thereafter. No idea why the one-day blip. (There was also an upward blip in heaven2_gl that day, but it was quite small.)

1 0

Re: d3dx9: Add some version-specific checks in the shader assembler.
by Stefan Dösinger 19 May '10

19 May '10

Am 18.05.2010 um 14:55 schrieb Matteo Bruni: > + if(!check_reg_type(src, vs_3_reg_allowed)) { > + asmparser_message(This, "Line %u: Source register %s not supported in VS 3.0\n", > + This->line_no, > + debug_print_srcreg(src, ST_VERTEX)); > + set_parse_status(This, PARSE_ERR); > + } I realize the patch has been committed already, but I'm wondering: Does the native assembler check the register numbers too? Or just the types? You have to be careful with error checking in the assembler, because the native assembler checks for very few error conditions. More complex checks like uninitialized registers or unwritten output registers are checked by the shader validator, an undocumented interface in d3d9.dll(which is called by vsa.exe / psa.exe) If my memory is correct, all the other error conditions you check for are checked by the native *assembler*, but I'm not sure about the register numbers. I think more unit tests would be helpful.

2 1

Re: winemp3.acm: Fixes the Mac-specific code (try 2)
by Aric Stewart 19 May '10

19 May '10

Hi, I was excited to try out this patch but now it is giving me a crash. (OS/X 10.5.8) Backtrace: =>0 0xffff12a9 (0x0033d81c) 1 0xffff086e (0x0033d838) 2 0x936f5a47 _ZN14CodecConverter14AppendNewInputEmPcmRmP28AudioStreamPacketDescription+0xb6() in audiotoolbox (0x0033d888) 3 0x936f564b _ZN14CodecConverter13CallInputProcERm+0x1ca() in audiotoolbox (0x0033d8f8) 4 0x936f513d _ZN14CodecConverter17DecoderFillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0x47c() in audiotoolbox (0x0033d9c8) 5 0x936e9b61 _ZN22BufferedAudioConverter13GetInputBytesEmRmRPK12CABufferList+0xa0() in audiotoolbox (0x0033d9f8) 6 0x936e9a1d _ZN12CBRConverter12RenderOutputEP12CABufferListmRmP28AudioStreamPacketDescription+0x7c() in audiotoolbox (0x0033da38) 7 0x936e978c _ZN22BufferedAudioConverter10FillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0xeb() in audiotoolbox (0x0033da98) 8 0x936e9b61 _ZN22BufferedAudioConverter13GetInputBytesEmRmRPK12CABufferList+0xa0() in audiotoolbox (0x0033dac8) 9 0x936e9a1d _ZN12CBRConverter12RenderOutputEP12CABufferListmRmP28AudioStreamPacketDescription+0x7c() in audiotoolbox (0x0033db08) 10 0x936e978c _ZN22BufferedAudioConverter10FillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0xeb() in audiotoolbox (0x0033db68) 11 0x936e9914 _ZN19AudioConverterChain12RenderOutputEP12CABufferListmRmP28AudioStreamPacketDescription+0x63() in audiotoolbox (0x0033dba8) 12 0x936e978c _ZN22BufferedAudioConverter10FillBufferERmR15AudioBufferListP28AudioStreamPacketDescription+0xeb() in audiotoolbox (0x0033dc08) 13 0x93700b23 AudioConverterFillComplexBuffer+0x112() in audiotoolbox (0x0033dc58) 14 0x57b4f560 _mp3_leopard_horse+0x2bf() in winemp3 (0x0033dd08) 15 0x57b4f9a5 _MPEG3_DriverProc+0xf4() in winemp3 (0x0033ddd8) Here is the mpeg log snipit from just before the crash: trace:mpeg3:MPEG3_DriverProc (00000000 0x27af350 0003 00000000 0033de0c); trace:mpeg3:MPEG3_DriverProc (00000001 0x27af350 601b 0033dea8 00000000); trace:mpeg3:MPEG3_DriverProc (00000000 0x1114418 0003 00000000 0033dd9c); trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 604c 008f757c 00000000); trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 604e 008f757c 0033deb0); trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 6051 008f757c 0033df44); trace:mpeg3:MPEG3_DriverProc (00000001 0x1114418 604f 008f757c 0033df44); trace:mpeg3:mp3_leopard_horse ndst 147456 0x3127860 <- 19901 0x3122a94 trace:mpeg3:mp3_leopard_horse First 16 bytes to input: "\x00\x1f\x84\n\x92_\x81h\x00\x00\x00\x00\x00\x00\x00\x00" I am also getting quite a number of build warning that i dont know if should be concerning. Anything more I can do to test for you? -aric Kristofer Henriksson wrote: > Second submission, which improves the previous patch by properly > syncing to the initial MP3 frame header. > > The current winemp3.acm does not work if the Mac-specific code is > used. This rewrites the relevant portion to fix, for example, > background music on things like Oblivion. > > > ------------------------------------------------------------------------ > >

1 0

Re: Work on WineQuartz for MacOSX
by James Mckenzie 19 May '10

19 May '10

Roderick Colenbrander wrote: >On Sun, May 16, 2010 at 6:02 PM, C.W. Betts <computers57(a)hotmail.com> wrote: >> On May 16, 2010, at 9:31 AM, James Mckenzie wrote: >>> All: >>> >>> There was or is a quite lengthy thread on this project. >>> >>> What is the status of work? Any progress on Emmanuel's work from 2008? >>> >>> Thank you. >>> >>> James McKenzie >>> >> If memory serves, the main reason why there hasn't been any work done is because of the >> dependency of Objective-C, which the project administrator has said "no" to. >> >The fact that Cocoa is objective C is one of the issues (Charles Davis >made some C wrapper I think). The most problematic thing is that it >really need is a DIB engine. The Cocoa graphics APIs are similar to >Cairo / XRender / Direct2D and other modern APIs. These APIs are great >for vector drawing, alpha blending and other fancy operations but they >are not low-level 2D APIs. For instance they lack most classic >(bitwise) 2D ROPs. The classic rendering stuff (Windows 7 does it this >way as well) has to be performed in software by a DIB engine. > >Roderick > Charles Davis did not 'make a c wrapper', Apple did. However you are more correct in that we need a fully functional DIB engine in order to fully move the Apple interface from X11 to Aqua. I was inquiring if both of these actions have occurred. Max was working diligently on a DIB engine until AJ basically shot his work full of holes and he left. Again, what is the status of updating/upgrading Emmanuel's work? Has it been left for dead or is someone working in the background on it? I would like to pick it up and start looking at it again and seeing if the Obj-C code could be converted to plain 'c' or if we have to bring up a sidebar version of Wine that will be Aqua complaint. Having been through this with the OpenOffice.org and NeoOffice.org projects, this is a political area I really don't want to visit, but if it has to be that way, then it will head off in that direction. James McKenzie

4 4

Re: [PATCH 2/4] wininet: Added INTERNET_OPTION_ERROR_MASK flag handling to InternetSetOptionW (try2)
by Austin English 19 May '10

19 May '10

On Tue, May 18, 2010 at 8:28 PM, Piotr Caban <piotr(a)codeweavers.com> wrote: > Try2: > - Commented out test that fails on Win2000 (there were no new failures on > Win98). Any reason you didn't use broken() instead? -- -Austin

1 0

Re: ntdll: add stub for NtRaiseHardError (try 2)
by James McKenzie 19 May '10

19 May '10

Austin English wrote: > On Tue, May 18, 2010 at 1:17 PM, Austin English <austinenglish(a)gmail.com> wrote: > >> This time returning STATUS_NOT_IMPLEMENTED instead of E_NOTIMPL, to >> match the rest of ntdll. Thanks to Juan for pointing that out. >> > > Today's not my day... > > Wasn't mine either. Spent the entire day at 'work' chasing an error. Finally figured it out 1/2 hour before I left. Now to fix 140,000 or so database entries. James McKenzie

1 0

Steam hardware survey causing crashes (so next round of statistics will under-represent Wine users)
by Scott Ritchie 19 May '10

19 May '10

Just a small note but occasionally we hear from Valve about steam statistics and the percentage of Wine users. I just got a crash from running the survey. It makes me pretty unlikely to click the button again, even if it doesn't crash in the future. I imagine other users would feel similarly. This means we might be substantially underestimating Wine users if we use the Valve hardware survey as a basis. Last I remember we were at 0.4% or so, but that was over a year ago. Thanks, Scott Ritchie

2 1

Re: [PATCH 3/4] wininet: Combine certificate errors in HTTP_OpenConnection
by Juan Lang 19 May '10

19 May '10

Hi Piotr, + if((lpwhr->hdr.ErrorMask&INTERNET_ERROR_MASK_COMBINED_SEC_CERT) && ( + res == ERROR_INTERNET_SEC_CERT_DATE_INVALID + || res == ERROR_INTERNET_INVALID_CA + || res == ERROR_INTERNET_SEC_CERT_NO_REV + || res == ERROR_INTERNET_SEC_CERT_REV_FAILED + || res == ERROR_INTERNET_SEC_CERT_REVOKED + || res == ERROR_INTERNET_SEC_INVALID_CERT + || res == ERROR_INTERNET_SEC_CERT_CN_INVALID)) + res = ERROR_INTERNET_SEC_CERT_ERRORS; I'm confused. Is there evidence that native does the same? This would be surprising to me, given the existence of INTERNET_OPTION_SECURITY_FLAGS to mask particular errors. When are you trying to accomplish with this patch? Tests would certainly help. Thanks, --Juan

2 2

Re: [PATCH 2/4] wininet: Added INTERNET_OPTION_ERROR_MASK flag handling to InternetSetOptionW
by testbot＠testbot.winehq.org 19 May '10

19 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2142 Your paranoid android. === W98SE (32 bit internet) === internet.c:969: Test failed: Retrieved proxy server should've been L"proxy.example", was: L"\0001\a000\2684X\0fb4h\0200" internet.c:975: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1003: Test failed: Retrieved flags should've been PROXY_TYPE_DIRECT, was: 5767180 internet.c:1006: Test failed: Expected regtype to be REG_DWORD, was: 3 internet.c:1033: Test failed: Retrieved flags should've been PROXY_TYPE_PROXY | PROXY_TYPE_DIRECT, was: 5767180 internet.c:1036: Test failed: Expected regtype to be REG_DWORD, was: 3 === W2KPROSP4 (32 bit internet) === Timeout

1 0

SONAME_LIBFONTCONFIG undeclared
by GOUJON Alexandre 18 May '10

18 May '10

Hi, I just updated my local tree and ran CFLAGS="-g -O0" ./configure --disable-tests && make and I got make[1]: Entering directory `/home/alex/Projects/wine/dlls/winex11.drv' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o xrender.o xrender.c xrender.c: In function 'X11DRV_XRender_Init': xrender.c:398: error: 'SONAME_LIBFONTCONFIG' undeclared (first use in this function) xrender.c:398: error: (Each undeclared identifier is reported only once xrender.c:398: error: for each function it appears in.) xrender.c:401: error: 'pFcConfigSubstitute' undeclared (first use in this function) xrender.c:402: error: 'pFcDefaultSubstitute' undeclared (first use in this function) xrender.c:403: error: 'pFcFontMatch' undeclared (first use in this function) xrender.c:404: error: 'pFcInit' undeclared (first use in this function) xrender.c:405: error: 'pFcPatternCreate' undeclared (first use in this function) xrender.c:406: error: 'pFcPatternDestroy' undeclared (first use in this function) xrender.c:407: error: 'pFcPatternAddInteger' undeclared (first use in this function) xrender.c:408: error: 'pFcPatternAddString' undeclared (first use in this function) xrender.c:409: error: 'pFcPatternGetInteger' undeclared (first use in this function) xrender.c:411: error: 'fontconfig_installed' undeclared (first use in this function) xrender.c:411: warning: implicit declaration of function 'pFcInit' xrender.c:413: error: expected ')' before 'SONAME_LIBFONTCONFIG' make[1]: *** [xrender.o] Error 1 make[1]: Leaving directory `/home/alex/Projects/wine/dlls/winex11.drv' make: *** [dlls/winex11.drv] Error 2 Is anyone else experiencing this ?

3 4

Re: ntdll: add stub for NtRaiseHardError (try 2)
by Reece Dunn 18 May '10

18 May '10

On 18 May 2010 19:17, Austin English <austinenglish(a)gmail.com> wrote: > This time returning STATUS_NOT_IMPLEMENTED instead of E_NOTIMPL, to > match the rest of ntdll. Thanks to Juan for pointing that out. > > -- > -Austin Patch? - Reece

1 0

Re: ntdll: add stub for NtRaiseHardError
by Juan Lang 18 May '10

18 May '10

Hi Austin, + return E_NOTIMPL; I'm thinking this should return STATUS_NOT_IMPLEMENTED instead. --Juan

2 1

Nightly performance regression graphs
by Dan Kegel 18 May '10

18 May '10

I finally threw together some graphs, see http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html Not sure what to make of the results yet. They use svg, so a modern browser is required.

5 6

Re: setupx.dll16: Fix error handling in VCP_VirtnodeCreate. (RETRY)
by Alexandre Julliard 18 May '10

18 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This was not applied and I also did not see any feedback (and even > checked the list archives) so I am resending it. If you are going to return an error you have to handle the error properly and free the data structures etc. It's not clear that this is the right thing to do though. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] wininet: Fix error handling in HTTP_HttpSendRequestW
by Alexandre Julliard 18 May '10

18 May '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/wininet/http.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so http.c && touch http.ok http.c:2692: Test failed: 2780: expected status 21 got 30 http.c:2692: Test failed: 2780: expected status 30 got 31 http.c:2692: Test failed: 2780: expected status 31 got 100 http.c:2692: Test failed: 2797: expected status 100 got 30 http.c:2693: Test failed: 2797: expected function 3 got 4 http.c:2696: Test failed: 2797: expected thread 68 got 68 http.c:2692: Test failed: 2797: expected status 30 got 31 http.c:2692: Test failed: 2811: expected status 31 got 40 http.c:2693: Test failed: 2811: expected function 4 got 5 http.c:2692: Test failed: 2819: expected status 40 got 41 http.c:2693: Test failed: 2819: expected function 5 got 6 http.c:2692: Test failed: 2819: expected status 41 got 100 http.c:2693: Test failed: 2819: expected function 5 got 6 http.c:2692: Test failed: 2819: expected status 100 got 50 http.c:2693: Test failed: 2819: expected function 5 got 6 http.c:2701: Test succeeded inside todo block: 2819: expected status 70 got 70 http.c:2703: Test succeeded inside todo block: 2819: expected function 6 got 6 make[1]: *** [http.ok] Error 17 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Nightly performance regression graphs
by Dan Kegel 18 May '10

18 May '10

On Tue, May 18, 2010 at 3:07 AM, Scott Ritchie <scott(a)open-vote.org> wrote: > > http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > > What tool are you using to make them? gnuplot. The script (if you can call it that) I use is at http://code.google.com/p/winezeug/source/browse/trunk/yagmark-plot.sh > I recommend cairoplot, it's the tool I used in the model I made here: > http://yokozar.org/blog/archives/48 > > It outputs svgs just the same, but is nice and pretty and pythonic. We > could then script interesting things automatically, such as having the > chart automatically use the previous max benchmark as its first or > second node. I'll improve what I've got a bit, but at the moment I don't see a reason to switch away from gnuplot. - Dan

2 1

Re: Nightly performance regression graphs
by Dan Kegel 18 May '10

18 May '10

On Tue, May 18, 2010 at 1:13 AM, Sven Baars <sven.wine(a)gmail.com> wrote: >> http://kegel.com/wine/yagmarkdata/wine-1.1.44-245.html > > Just a question. What's this about? > > Vista Wine ratio > heaven2_d3d9_Video_memory 1024.00 256.00 0.25 The video card definitely has a gigabyte of video memory, and I just confirmed that the wineprefix running the test has user.reg:"VideoMemorySize"="1024" so I have no idea. Sounds like a bug, but I doubt it affects the results. A little quality time with +relay would probably show what's going on. (Or Wine could buy a copy of the source code for this benchmark. We might want one anyway...) - Dan

1 0

Re: [PATCH 1/4] wined3d: only activate blit_shader in arbfp_blit_surface for source fixups
by Henri Verbeet 18 May '10

18 May '10

On 18 May 2010 09:30, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > - arbfp_blit_set((IWineD3DDevice *)device, src_surface); > + if (is_complex_fixup(src_surface->resource.format_desc->color_fixup) && > + !is_complex_fixup(dst_surface->resource.format_desc->color_fixup)) > + arbfp_blit_set((IWineD3DDevice *)device, src_surface); > - This doesn't do what your subject line says it does. - Why do you think this patch makes sense?

2 4

Re: [PATCH 3/4] wined3d: allow complex -> complex blits in arbfp blit_shader under special circumstances
by Henri Verbeet 18 May '10

18 May '10

On 18 May 2010 09:30, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch should also address bug 22575 when using the arbfp backend. A similar fix is needed > for the ffp backend. That's meaningless as a Changelog entry. > + && (dst_usage & WINED3DUSAGE_RENDERTARGET)) What is that condition for?

2 1

Re: advapi32: Remove redundant "is NULL and error out" code (coccicheck).
by Michael Stefaniuc 18 May '10

18 May '10

Alexandre, please disregard this patch as I missed somehow that the error codes are different. And to figure out which to use needs a test. bye michael Michael Stefaniuc wrote: > --- > dlls/advapi32/crypt.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c > index bb019d0..395879f 100644 > --- a/dlls/advapi32/crypt.c > +++ b/dlls/advapi32/crypt.c > @@ -1413,11 +1413,6 @@ BOOL WINAPI CryptGenKey (HCRYPTPROV hProv, ALG_ID Algid, DWORD dwFlags, HCRYPTKE > > TRACE("(0x%lx, %d, %08x, %p)\n", hProv, Algid, dwFlags, phKey); > > - if (!prov) > - { > - SetLastError(ERROR_INVALID_HANDLE); > - return FALSE; > - } > if (!phKey || !prov || prov->dwMagic != MAGIC_CRYPTPROV) > { > SetLastError(ERROR_INVALID_PARAMETER);

1 0

Re: [PATCH 4/4] wined3d: remove unneeded memory cleanup code from BltOverride
by Henri Verbeet 18 May '10

18 May '10

On 18 May 2010 09:30, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > We think the code is not needed and the code was wrong anyway since it didn't check whether the pointers it freed > where valid. In which cases can it be invalid?

1 0

Re: [PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)
by Charles Davis 18 May '10

18 May '10

What's wrong with my patch now? It's a really simple fix; in fact, this is as about as simple as it gets. How does this "break libwine compatibility"? Chip

3 7

Re: [PATCH] comctl32/listview: Derive subitem rect from listview origin
by Nikolay Sivov 17 May '10

17 May '10

On 5/18/2010 02:36, Andrew Eikum wrote: > > The old code used the containing item's position to determine the > subitem's rect. Instead, we should be using the entire listview's > origin as the offset, since the item position can change as columns > are inserted and re-arranged, leading to broken listviews. > --- > dlls/comctl32/listview.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Looks right. Seems to be (one?) of remaining problem that comes out after I added column reordering. Please add a minimal test case for this to prevent a regression. All you need - add 2 columns, add item, reorder columns with a LVM_SETCOLUMNORDERARRAY and test rectangle.

1 0

Re: [PATCH 4/4] wined3d: add BLIT_OP_COMPLEX_UPLOAD
by Henri Verbeet 17 May '10

17 May '10

On 17 May 2010 13:11, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch introduces a new blit operation to allow complex uploads from LoadLocation. It allows hw accelerated > p8 uploads to function again (I broke them by accident). Without this blit_operation there is no way to detect > this single case at the moment in which we allow the P8 shader (remember both the source and destination have > complex fixups set, so this doesn't pass). I'm not so convinced this needs a separate blit operation, it should always be possible to do blits between surfaces with the same formats as long as no stretching is involved.

2 1

Re: urlmon: Added tests for some of the property methods. Added a dependency to urlmon for oleaut32
by Jacek Caban 17 May '10

17 May '10

Hi Thomas, On 5/17/10 3:05 AM, Thomas Mullaly wrote: > Added tests to make sure IUri_GetPropertyBSTR / IUri_GetPropertyDWORD > / IUri_GetPropertyLength handle invalid arguments correctly. Fixed > up/added some comments. > > Had to add a dependency to urlmon for oleaut32. This is because the > Uri interface returns all the string properties of a URI as BSTR's and > it needs the SysAllocString/SysFreeString functions in oleau32. I > checked on windows using Dependency Walker and the native version of > urlmon has this same dependency. -IMPORTS = uuid ole32 rpcrt4 shlwapi wininet user32 advapi32 kernel32 ntdll +IMPORTS = uuid ole32 oleaut32 rpcrt4 shlwapi wininet user32 advapi32 kernel32 ntdll You should add oleaut32 dependency in a patch that uses its functions. hr = IUri_GetPropertyBSTR(uri, i,&str, 0); + todo_wine { + ok(hr == S_OK, "Error: GetPropertyBSTR returned 0x%08x, expected 0x%08x. property=%d\n", + hr, S_OK, i); + } + todo_wine { ok(str != NULL, "Error: Expected the BSTR not to be NULL, property=%d\n", i); } + ok(!SysStringLen(str), "Error: Expected the BSTR to be of length 0, but it was %d instead. property=%d\n", + SysStringLen(str), i); You will have to add tests for the exact values returned sooner or later, so this will be tested better then. There is not much value in tests like this. + if(str) SysFreeString(str); You don't need NULL check here. Thanks, Jacek

1 0

Re: riched20: Avoid using long.
by testbot＠testbot.winehq.org 17 May '10

17 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2105 Your paranoid android. === W7PRO (32 bit editor) === editor.c:4696: Test failed: test paste: strcmp = 1, text='testing paste editor.c:4714: Test failed: test paste: strcmp = 1 editor.c:4726: Test failed: test paste: strcmp = -1 editor.c:4756: Test failed: test paste: strcmp = -1, actual = 'Ts' editor.c:5971: Test failed: Cursor is at 0 instead of 4 editor.c:5977: Test failed: Cursor is at 0 instead of 9 editor.c:5983: Test failed: Cursor is at 0 instead of 4 editor.c:5997: Test failed: Cursor is at 8 instead of 9 editor.c:6005: Test failed: Cursor is at 11 instead of 9 editor.c:6016: Test failed: Cursor is at 0 instead of 8 editor.c:6041: Test failed: Cursor is at 0 instead of 8

2 1

Work on WineQuartz for MacOSX
by James Mckenzie 16 May '10

16 May '10

All: There was or is a quite lengthy thread on this project. What is the status of work? Any progress on Emmanuel's work from 2008? Thank you. James McKenzie

3 2

Re: Work on WineQuartz for MacOSX
by C.W. Betts 16 May '10

16 May '10

On May 16, 2010, at 12:29 PM, James Mckenzie wrote: > C.W. > > The page referred to by this message no longer exists.... > > Time for an update. Include the period at the end. It works then. I was able to get the code and compile it fine under 32-bit mode. Apparently there has been a few changes in 64-bit mode that doesn't make it work quite as well. > > James McKenzie > > > > -----Original Message----- >> From: "C.W. Betts" <computers57(a)hotmail.com> >> Sent: May 16, 2010 10:06 AM >> To: wine-devel(a)winehq.org >> Subject: Fwd: Work on WineQuartz for MacOSX >> >> >> >> Begin forwarded message: >> >>> From: Erich Hoover <ehoover(a)mines.edu> >>> Date: May 16, 2010 10:10:29 AM MDT >>> To: "C.W. Betts" <computers57(a)hotmail.com> >>> Subject: Re: Work on WineQuartz for MacOSX >>> >>> On Sun, May 16, 2010 at 10:02 AM, C.W. Betts <computers57(a)hotmail.com> wrote: >>> If memory serves, the main reason why there hasn't been any work done is because of the dependency of Objective-C, which the project administrator has said "no" to. >>> ... >>> >>> I don't know/remember if anyone brought this up previously, but there are ways to connect to an Objective-C library in a flat C project. I've been keeping this example handy in case I ever need to do it: >>> http://www.smipple.net/snippet/moriyoshi/Using%20Objective-C%20ABI%20from%2…. >>> >>> Erich Hoover >>> ehoover(a)mines.edu >> > >

1 0

Fwd: Work on WineQuartz for MacOSX
by C.W. Betts 16 May '10

16 May '10

Begin forwarded message: > From: Erich Hoover <ehoover(a)mines.edu> > Date: May 16, 2010 10:10:29 AM MDT > To: "C.W. Betts" <computers57(a)hotmail.com> > Subject: Re: Work on WineQuartz for MacOSX > > On Sun, May 16, 2010 at 10:02 AM, C.W. Betts <computers57(a)hotmail.com> wrote: > If memory serves, the main reason why there hasn't been any work done is because of the dependency of Objective-C, which the project administrator has said "no" to. > ... > > I don't know/remember if anyone brought this up previously, but there are ways to connect to an Objective-C library in a flat C project. I've been keeping this example handy in case I ever need to do it: > http://www.smipple.net/snippet/moriyoshi/Using%20Objective-C%20ABI%20from%2…. > > Erich Hoover > ehoover(a)mines.edu

1 0

Fwd: [AppDB] patch: Request for UTF8-encoded results from MySQL when querying the bugs DB.
by Alexandru Băluț 16 May '10

16 May '10

Hi, Is anyone reviewing patches for AppDB? Thanks, Alex ---------- Forwarded message ---------- From: Alexandru Balut <alexandru.balut(a)gmail.com> Date: Sat, May 1, 2010 at 17:29 Subject: [AppDB] patch: Request for UTF8-encoded results from MySQL when querying the bugs DB. To: wine-patches(a)winehq.org Resending because I got no response and the patch has not been committed yet. Partial fix for bug http://bugs.winehq.org/show_bug.cgi?id=16514 - some characters from the bug summary do not appear correctly when a linked bug is displayed in the page showing a version of an app. For example, see http://appdb.winehq.org/objectManager.php?sClass=version&iId=17511 and look in that page for bug 21156. Tested in Chrome, and Firefox, with the following chars in the title: Iñtërnâtiônàlizætiøn 素晴らしい翻訳はここ笑

2 1

Re: [PATCH 1/9] tools: Modified the ICO render script to render BMPs (resend)
by Alexandre Julliard 16 May '10

16 May '10

Joel Holdsworth <joel(a)airwebreathe.org.uk> writes: > + # Convert it into a bmp > + if($depth == 32) { > + # Alpha channel is negated as a work around for an ImageMagick bug > + shell $convert, "png:$pngFile", "-channel", "Alpha", "-negate", $outFileName; Which ImageMagick version needs this? Mine (6.6.0) doesn't. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Release plans
by James Mckenzie 16 May '10

16 May '10

> > >Hi, > >some time passed and because statistics are somewhat popular here, i >did one ;) > >340 regressions <-- release announcement >356 regressions <-- release announcement + 1week > Not a good statistic, but maybe we caused a few folks to decide to submit overdue regressions now that Wine 1.2 was announced. > >I hope that fixing them all is the right way, which will save me time >with nominating. +1 to this thought. Fixing now is better than fixing later... James McKenzie

1 0

Change default library paths
by Danila Sentiabov 16 May '10

16 May '10

Hi. I have a set of home-made scripts for compiling and using different Wine versions with different prefixes (no system-wide Wine installed at all). I build new versions on Ubuntu VM (./configure --prefix=/home/build-user/wine-build/binaries), then copy compiled binaries to designated folder of my openSUSE box (this folder does not match with configured --prefix, e.g. /home/my-user/wine/binaries/1.1.40) and run it, setting correct PATH, WINELOADER and WINEPREFIX. Everything went OK until now. I've updated my building VM from Ubuntu 8.04 to 10.04 and built Wine 1.1.44. Now it refuse to run with wine: failed to initialize: /home/build-user/wine-build/binaries/lib/wine/ ntdll.dll.so: cannot open shared object file: No such file or directory Setting WINEDLLPATH does not help - it searches for dlls only in default precompiled location. What I'm doing wrong? -- Best regards, Danila Sentiabov aka dsent

1 0

More benchmarks of 3d performance comparing windows and linux
by Dan Kegel 16 May '10

16 May '10

http://kegel.com/wine/yagmarkdata/ now has data from 3dmark2000, 2001, and 06 running on a beefy i7 960 with an equally beefy Nvidia GTX 295 with either Windows 7 or Linux+Wine (all tests run at 1024x768). Here are the results of one run for each plucked at random (sorry, no breakdown of 3dmark06 results yet): Win 7 Wine units 3dmark2000_3DMark_Result: 39587 26278 3Dmarks 3dmark2000_CPU_Speed: 1269 1276 CPU_3Dmarks 3dmark2000_Game_1_Helicopter_Low_Detail: 689.7 415.2 FPS 3dmark2000_Game_1_Helicopter_Medium_Detail: 526.8 319.4 FPS 3dmark2000_Game_1_Helicopter_High_Detail: 412.1 260.1 FPS 3dmark2000_Game_2_Adventure_Low_Detail: 981.2 648.4 FPS 3dmark2000_Game_2_Adventure_Medium_Detail: 429.0 334.9 FPS 3dmark2000_Game_2_Adventure_High_Detail: 260.2 211.8 FPS 3dmark2001_3DMark_Score 46297 28194 3DMarks 3dmark2001_Game_1_Car_Chase_Low_Detail 551.3 314.6 fps 3dmark2001_Game_1_Car_Chase_High_Detail 111.5 133.0 fps 3dmark2001_Game_2_Dragothic_Low_Detail 678.0 462.2 fps 3dmark2001_Game_2_Dragothic_High_Detail 399.6 184.2 fps 3dmark2001_Game_3_Lobby_Low_Detail 602.7 371.5 fps 3dmark2001_Game_3_Lobby_High_Detail 294.0 135.5 fps 3dmark2001_Game_4_Nature 593.9 382.9 fps 3DMark06_result: 21519 6038 3dmarks This might not be all that useful on its own, but once I have daily automatic runs going, it ought to be helpful in looking for performance regressions. These results are probably only accurate to +- 5%. Later on I'll do multiple runs and compute the median to reduce the noise level. Notes: On really big screens, at least under wine, 3dmark2000 seems to lose its mind and put up a warning dialog behind the main window (thus hanging the test). I had to set the screen size down to something closer to 1024x768 for it to calm down and run the benchmark. 3dmark2000 and 3dmark2001 need to be run in xp compatibility mode on Windows 7, or they complain of insufficient memory. Again, this was done by running http://code.google.com/p/winezeug/source/browse/trunk/yagmark - Dan

5 16

msvcp80 redux: easier than we thought (for some apps, at least)?
by Dan Kegel 16 May '10

16 May '10

A little over a year ago, somebody asked how Wine planned to deal with msvcp80: http://www.winehq.org/pipermail/wine-devel/2008-December/071440.html Back then, the answer was "winetricks vcrun2005 unless you want to start implementing it yourself": http://www.winehq.org/pipermail/wine-devel/2008-December/071444.html Now that msvcr80 is in pretty good shape, perhaps it would make sense to look at whether msvcp80 could be implemented. Perhaps some programs only use a small subset. Starcraft II, for instance, only needs the following seven functions from msvcp80: 1637 ?compare@?$char_traits@D@std@@SAHPBD0I@Z 1498 ?_Xlen@_String_base@std@@SAXXZ 1499 ?_Xran@_String_base@std@@SAXXZ 377 ??0?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAE@PBD@Z 1581 ?c_str@?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QBEPBDXZ c475b2 606 ??1?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAE@XZ 370 ??0?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAE@ABV01@@Z I've added this info to http://bugs.winehq.org/show_bug.cgi?id=22501 Perhaps we can make a little progress here more easily than we thought. Or are more references lurking somewhere? - Dan

1 0

Re: [2/2] dlls/crypt32: unit test PFXImportCertStore() (2nd try)
by testbot＠testbot.winehq.org 14 May '10

14 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2067 Your paranoid android. === W98SE (32 bit decode) === decode.c:236: Test failed: succeeded in importing garbage certificate {0x57} decode.c:249: Test failed: could not import the certificate store with a blank password {0x57} === WNT4WSSP6 (32 bit decode) === decode.c:236: Test failed: succeeded in importing garbage certificate {0x57} decode.c:249: Test failed: could not import the certificate store with a blank password {0x57}

1 0

Re: [PATCH 1/3] wined3d: fix texture conversion flag bug
by Henri Verbeet 14 May '10

14 May '10

The patch looks like it makes sense at first sight (though the double conversion check is less than ideal), but you really want something more descriptive for the Changelog.

1 0

Re: winedump: Print the network share name in .lnk files.
by Eric Pouech 14 May '10

14 May '10

> > @@ -245,6 +254,18 @@ static int dump_location(void) > } > printf("\n"); > > + /* dump information about the network volume the link points to */ > + printf("Network volume ofs = %08x ", loc->dwNetworkVolTableOfs); > + if (loc->dwNetworkVolTableOfs && > (loc->dwNetworkVolTableOfs<loc->dwTotalSize)) > me wonders if if (loc->dwNetworkVolTableOfs && (loc->dwNetworkVolTableOfs + sizeof(NETWORK_VOLUME_INFO)<loc->dwTotalSize)) wouldn't be better (same also would apply for test in old code above for dwVolTableOfs -- -- Eric Pouech

1 0

Re: Sudden increase of Valgrind errors
by Dan Kegel 14 May '10

14 May '10

Two things: I moved to karmic (and now more modules are enabled, since it comes with new-enough libraries), and I updated valgrind. I haven't had time to dig in to the differences. The suppressions file also needs updating for karmic. On Feb 28, 2010 5:43 AM, "Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: Hi Dan, As of Feb-25 there is a sudden increase in Valgrind errors reported at http://kegel.com/wine/valgrind/logs. The errors are in loads of modules which make me believe something generic has changed (there are also errors in modules that haven't been touched in a while). Any idea? -- Cheers, Paul.

2 2

Re: shdocvw: Added IDataObject stub implementation.
by Alexandre Julliard 14 May '10

14 May '10

Ilya Shpigor <shpigor(a)etersoft.ru> writes: > --- > dlls/shdocvw/Makefile.in | 1 + > dlls/shdocvw/dataobject.c | 127 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/shdocvw/shdocvw.h | 3 + > dlls/shdocvw/webbrowser.c | 4 ++ > 4 files changed, 135 insertions(+), 0 deletions(-) > create mode 100644 dlls/shdocvw/dataobject.c Please don't create a new file for every interface. There are enough existing files where this can go. Same for IOleLink. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] user32: Convert data in WM_DDE_EXECUTE to ansi when expected.
by testbot＠testbot.winehq.org 14 May '10

14 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2059 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:659: Test failed: Expected 1, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:700: Test failed: Expected 1, got 0 dde.c:922: Test failed: Expected FALSE, got 1 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:942: Test failed: Expected poke, got dde.c:943: Test failed: Expected 4, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:935: Test failed: Expected empty string, got 4 dde.c:731: Test failed: Expected '[Command(Var)]', got (null) dde.c:732: Test failed: Expected 15, got 12 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:750: Test failed: DdeGetData should have returned 17 not 0 dde.c:756: Test failed: Expected '[Command-2(Var)]' got t dde.c:757: Test failed: Expected 17, got 0 dde.c:886: Test failed: Execpted execute hglobal, got 00000000 dde.c:892: Test failed: Expected '[Command(Var)]', got (null) dde.c:737: Test failed: Expected '[BadCommand(Var)]', got [Command(Var)] dde.c:738: Test failed: Expected 18, got 32 dde.c:895: Test failed: Expected TRUE, got 0 dde.c:896: Test failed: Expected '[Command-2(Var)]', got [Command(Var)] dde.c:714: Test failed: Expected 9 or 11, got 12 dde.c:901: Test failed: Expected '[BadCommand(Var)]', got [Command-2(Var)] dde.c:714: Test failed: Expected 9 or 11, got 13 dde.c:857: Test failed: Expected 2, 3, 4, 6, 7, 8, 9, 10 or 11, got 12 dde.c:918: Test failed: Expected TRUE, got 0 dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:812: Test failed: client failed with 15 error(s) dde.c:2040: Test failed: Expected 0xcafebabe, got 00000884 dde.c:2041: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: [1/3] user32: Convert data in WM_DDE_EXECUTE to unicode when expected.
by testbot＠testbot.winehq.org 14 May '10

14 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2058 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:659: Test failed: Expected 1, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:700: Test failed: Expected 1, got 0 dde.c:922: Test failed: Expected FALSE, got 1 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:942: Test failed: Expected poke, got dde.c:943: Test failed: Expected 4, got 0 dde.c:692: Test failed: Expected 12, got 28 dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:935: Test failed: Expected empty string, got 4 dde.c:731: Test failed: Expected '[Command(Var)]', got (null) dde.c:732: Test failed: Expected 15, got 12 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:750: Test failed: DdeGetData should have returned 17 not 0 dde.c:756: Test failed: Expected '[Command-2(Var)]' got t dde.c:757: Test failed: Expected 17, got 0 dde.c:886: Test failed: Execpted execute hglobal, got 00000000 dde.c:892: Test failed: Expected '[Command(Var)]', got (null) dde.c:737: Test failed: Expected '[BadCommand(Var)]', got [Command(Var)] dde.c:738: Test failed: Expected 18, got 32 dde.c:895: Test failed: Expected TRUE, got 0 dde.c:896: Test failed: Expected '[Command-2(Var)]', got [Command(Var)] dde.c:714: Test failed: Expected 9 or 11, got 12 dde.c:901: Test failed: Expected '[BadCommand(Var)]', got [Command-2(Var)] dde.c:714: Test failed: Expected 9 or 11, got 13 dde.c:857: Test failed: Expected 2, 3, 4, 6, 7, 8, 9, 10 or 11, got 12 dde.c:918: Test failed: Expected TRUE, got 0 dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:812: Test failed: client failed with 15 error(s) dde.c:2040: Test failed: Expected 0xcafebabe, got 00000884 dde.c:2041: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: wineps.drv: Remove variables scale_xx, scale_xy, scale_yx, and scale_yy and two dozen lines of dead code from append_complex_glyph.
by Nikolay Sivov 14 May '10

14 May '10

On 5/8/2010 01:36, Gerald Pfeifer wrote: > This one felt a bit like peeling an onion, but indeed while we have been > setting those three variables, we're never using them. And also ptr is > not used beyond this point, so we can remove a bunch of dead code. > I don't think it's dead. Variable ptr is used in a cycle.

2 1

Re: gdi32/tests: Remove variable oldPen which is not really used from test_widenpath.
by Vitaliy Margolen 13 May '10

13 May '10

On 05/07/2010 01:06 PM, Gerald Pfeifer wrote: > - oldPen = SelectObject(hdc, greenPen); > + SelectObject(hdc, greenPen); If it's not used it's a bug. Everything should be reset to original state to prevent influence on following tests. There are number of such places in Wine's test suite that makes it impossible to isolate the problem. Vitaliy

2 1

Re: comctl32/tests: Remove variable res which is not really used from test_monthcal_size.
by Nikolay Sivov 13 May '10

13 May '10

On 5/6/2010 02:11, Gerald Pfeifer wrote: > Also in other places don't we check the result of SendMessage, and that's > not really what we want to test here, either, from what I can tell. > > > - res = SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); > + SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); > > Actually it won't hurt to test for it here.

2 1

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]
by Aric Stewart 13 May '10

13 May '10

Hi, I will admit that my understanding of both ACM drivers as well as the os x audio libraries are not perfect and mostly come from work on this code itself. So i will fully admit it is most likely full of areas needing improvement. Kristofer Henriksson wrote: > Aric, > > I may have been operating under some faulty assumptions. I thought > that all mp3 files would "begin at the beginning" and also keep track > of how much of the source data the convert function said that it used. > I am very careful to set the value of *nsrc to agree with how much > source data was successfully used and assume that the calling function > with resend the data that is not used. If this is done, it ensures a > valid frame at the start of each invocation. Yes, a proper application should do just that. It should be tracking the value in nsrc and resend unused data at the beginning of the next buffer. You get a lot of the expected source stream format from MPEG3_StreamOpen. With that i wonder if the presence of an ID3 tag becomes optional. My familiarity with mp3 format makes me unsure if a packet header would also be required. > > As far as using AudioFileStream, I tried for a bit to get it to work > before I wrote my own custom mp3 parser. I'm running Snow Leopard > (10.6.3) and never got the background music to work in Oblivion. One > of the problems is that Mp3AudioConverterComplexInputDataProc needs to > return an error if it will have more data in the future, rather than > returning zero. However, even changing this, AudioFileStream seemed to > be skipping a lot of mp3 frames. > The lack of an error in that return is probably an oversight on my part. All the mp3 clips in the game i was working with where sent in one piece so there was only one pass through the loop that consumed all of the data. I am unsure why skipping mp3 frames would occure. My guess is that I am feeding the data in incorrectly and on those boundries between feeds frames are being ignored/corrupted or the like. > If you tell me what are more appropriate assumptions I should be > making in my parser, I can fix it to work the way it should. I suppose > I am also assuming that it will usually receive at least one full > packet, and if this is unjustified I can fix this as well. If I should > expect calling functions to ignore the value of *nsrc, then I can just > implement an internal single-packet buffer, and this should take care > of the problem. > I think the assumptions we need to investigate is the one about there being a packet header at the beginning. Maybe for non variable bit rate mp3s we just get the data given to us when the stream is opened. In fact, going on a hunch i just got your code to work great with my game! What i did was this: I added PACMDRVSTREAMINSTANCE adsi to Mp3GetPacketLength and then when you would return -1 if you could not determin the header I instead returned (192000 * 144) / adsi->pwfxDst->nSamplesPerSec. I picked that because it shows up in other areas of the code where we need to get a length. This is exciting also because there where a few mp3s that whre returning 'Fmt?' errors from the stream code and would not play. But with your patch and this change those clips played as well. Does that give you something to work with? You clearly understand mp3 format better than I. -aric

2 2

Re: [PATCH 5/5] server: get rid of sock_try_event
by Alexandre Julliard 13 May '10

13 May '10

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > We *might* need to ignore POLLERR messages for UDP sockets, as the > condition is actually temporary and sock_try_event was hiding this. It doesn't work here: ../../../tools/runtest -q -P wine -M ws2_32.dll -T ../../.. -p ws2_32_test.exe.so sock.c && touch sock.ok sock.c:941: Test failed: some threads have not completed: 102 sock.c:3567: Tests skipped: WSAIoctl failed to get AcceptEx with ret -1 + errno 10045 make: *** [sock.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: urlmon: CreateUri should return E_INVALIDARG for NULL args.
by Paul Vriens 13 May '10

13 May '10

On 05/13/2010 04:49 AM, Thomas Mullaly wrote: > @@ -75,6 +77,22 @@ static void test_CreateUri_InvalidFlags(void) { > } > } > > +/* > + * CreateUri returns E_INVALIDARG if the IUri it recieves is NULL. > + * CreateUri returns E_INVALIDARG if the uri string is NULL and sets the IUri to NULL. > + */ I don't think these comments are needed as the same is shown in the tests below (I was actually triggered by the wrong spelling of 'receives' btw). > +static void test_CreateUri_InvalidArgs(void) { > + HRESULT hr; > + IUri*uri = (void*) 0xdeadbeef; > + > + hr = pCreateUri(http_urlW, 0, 0, NULL); > + ok(hr == E_INVALIDARG, "Error: CreateUri returned 0x%08x, expected 0x%08x\n", hr, E_INVALIDARG); > + > + hr = pCreateUri(NULL, 0, 0,&uri); > + ok(hr == E_INVALIDARG, "Error: CreateUri returned 0x%08x, expected 0x%08x\n", hr, E_INVALIDARG); > + ok(uri == NULL, "Error: Expected the IUri to be NULL, but it was %p instead\n", uri); > +} -- Cheers, Paul.

2 1

Re: winemp3.acm: Fixes the Mac-specific code
by Aric Stewart 13 May '10

13 May '10

Hi, It is good to see someone working on this code. But your patch makes it so that all the mp3 sound clips in the game that I was coding for stop working. trace:mpeg3:mp3_leopard_horse ndst 147456 0x2eab348 <- 19901 0x2ea657c trace:mpeg3:mp3_leopard_horse First 16 bytes to input: "\x00\x1f\x84\n\x92_\x81h\x00\x00\x00\x00\x00\x00\x00\x00" trace:mpeg3:mp3_leopard_horse Invalid header at 0x2ea657c I was also under the impression that a single input stream could come through as a series of ACMDM_STREAM_CONVERT messages that may or may not align as containing full packets or have a header on each call. This may not be what is happening here since it appear to be happening at the beginning of a given sound clip. But that is why I used the AudioFileStream (that and i was seeing apple documentation recommending so) -aric Kristofer Henriksson wrote: > The current winemp3.acm does not work if the Mac-specific code is > used. This rewrites the relevant portion to fix, for example, > background music on things like Oblivion. > > > ------------------------------------------------------------------------ > >

1 0

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X
by Ken Thomases 13 May '10

13 May '10

On May 12, 2010, at 2:30 PM, Charles Davis wrote: > In Mac OS X 10.5, mmap() was changed to conform to UNIX '03. Among other > things, this means that mmap() no longer supports unaligned file offsets > (like Linux). What problems does this cause? > However, by reading Darwin source, I learned that the check for unaligned > file offsets is done at the library level, and not in the kernel. This is > to support older binaries compiled for Tiger and earlier. This means that Wine > compiled for Tiger should support unaligned file offsets, like want. But it > also means that, if we make the syscall ourselves instead of calling libc, we > can support them on Leopard (and by extension, Snow Leopard) too! This patch > series does just that. Can't we achieve that just by avoiding the mapping of the "mmap" identifier to the _mmap$UNIX2003 symbol? http://developer.apple.com/mac/library/releasenotes/Darwin/SymbolVariantsRe… It may be sufficient to #define _NONSTD_SOURCE, #include <sys/mman.h> as the first header, #undef _NONSTD_SOURCE, and then continue to include any other headers. Alternatively, you can probably use an approach like this: http://source.winehq.org/git/wine.git/?a=commitdiff;h=028b763f2f51e78084129… Regards, Ken

3 4

Re: [kernel32] Return the correct processor arch and type in wow64 mode
by testbot＠testbot.winehq.org 13 May '10

13 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2036 Your paranoid android. === W98SE (32 bit process) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: [WineHQ][WWN] WWN 362 - Brought to you by Edward Savage
by Sven Baars 13 May '10

13 May '10

Zachary Goldberg wrote: > +<topic>AppDB / BugZilla</topic> > +<center>BugZilla Changes:</center> > + > +<center> > +<table border="1" bordercolor="#222222" cellspacing="0" cellpadding="3"> > +<tr> > +<td align="center"> > + Category > +</td> > +<td> > +Total Bugs Last Issue > +</td> > +<td> > + Total Bugs This Issue > +</td> > +<td> > + Net Change > +</td> > +</tr> > + > +<tr> > +<td align="center"> > + UNCONFIRMED > +</td> > +<td align="center"> > + 2795 > +</td> > +<td align="center"> > + 2821 > +</td> > + > +<td align="center"> > + +26 > +</td> > +</tr> > + > +<tr> > +<td align="center"> > + NEW > +</td> > +<td align="center"> > + 2677 > +</td> > +<td align="center"> > + 2683 > +</td> > + > +<td align="center"> > + +6 > +</td> > +</tr> > + > +<tr> > +<td align="center"> > + ASSIGNED > +</td> > +<td align="center"> > + 28 > +</td> > +<td align="center"> > + 26 > +</td> > + > +<td align="center"> > + -2 > +</td> > +</tr> > + > +<tr> > +<td align="center"> > + REOPENED > +</td> > +<td align="center"> > + 119 > +</td> > +<td align="center"> > + 117 > +</td> > + > +<td align="center"> > + -2 > +</td> > +</tr> > + > +<tr> > +<td align="center"> > + CLOSED > +</td> > +<td align="center"> > + 3 > +</td> > +<td align="center"> > + 1 > +</td> > + > +<td align="center"> > + -2 > +</td> > +</tr> > + > +<tr> > +<td align="center"> > + TOTAL OPEN > +</td> > +<td align="center"> > + 5619 > +</td> > +<td align="center"> > + 5647 > +</td> > +<td align="center"> > + +28 > +</td> > +</tr> > +<tr> > +<td align="center"> > + TOTAL > +</td> > +<td align="center"> > + 5622 > +</td> > +<td align="center"> > + 5648 > +</td> > +<td align="center"> > + +26 > +</td> > +</tr> > +</table> > Hey Zach, This says that there is 1 closed bug, while there must be thousands. That can't be right. Also, it doesn't say anything about not-closed resolved bugs (like fixed ones), so it doesn't say anything about the real total. Sven

1 0

Re: wine-devel Digest, Vol 58, Issue 30
by Maik Masling 12 May '10

12 May '10

Am 12.05.2010 19:00, schrieb wine-devel-request(a)winehq.org: > Send wine-devel mailing list submissions to > wine-devel(a)winehq.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.winehq.org/mailman/listinfo/wine-devel > or, via email, send a message with subject or body 'help' to > wine-devel-request(a)winehq.org > > You can reach the person managing the list at > wine-devel-owner(a)winehq.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of wine-devel digest..." > > > Today's Topics: > > 1. Re: Release plans (Alexandre Julliard) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 12 May 2010 18:55:21 +0200 > From: Alexandre Julliard<julliard(a)winehq.org> > Subject: Re: Release plans > To: Scott Ritchie<scott(a)open-vote.org> > Cc: wine-devel(a)winehq.org > Message-ID:<87k4r93vra.fsf(a)wine.dyndns.org> > Content-Type: text/plain; charset=us-ascii > > Scott Ritchie<scott(a)open-vote.org> writes: > > >> On 05/09/2010 05:00 PM, Alexandre Julliard wrote: >> >>> We definitely need a release changelog, yes. >>> >> It seems to me what we really want is more than a changelog but a proper >> release announcement. I want a journalist who has hardly heard of Wine >> to read the page and understand what we've done and why it's great. >> > Sure, that's the press release, we should have one too, but it's a > different thing. A changelog would be a detailed description of changes > that matter from a user point of view. It would list for instance new > builtin programs, new configuration options, new behaviors, new system > dependencies, backwards compatibility concerns, etc. You can't put that > sort of things in the press release. > > That is a certain point. If the changelog would nounce namely working programs in series 1.2, than people would be more attracted into testing those but could be more dissappointed, because in fact more regressions to those "featured program"-list would pop up, especially after changes and with following 1.2.x. To tell a non-programmer from a user-perspective point of view the advantages in featuring functionalities and supported application of the wine-project stable snapshots must not be like coding it again in foolish human language. What I think the announcement really need to be is giving me/us a focus on the range of the advantages. "What is the evolutionary point?" I would be perfectly informed and proud to see it just like that: Some few new famous massively used and working single/multiplayer games or programs that people heavily rely on. For example top 10 games + top 10 applications that work platinum with 1.2 plus an numeral overview of the status quo compared to 1.1 in platin,gold,silver,bronce,fixed bugs etc. Compared: 1.0 / 1.1 Platin: # / # Gold: " Silver: " Bronce: " Fixed Bugs: " What i really liked in earlier days was the animation with the gold,silver,bronce-bars, because that would easily visualise those process. Wow, user thinks "How comes?" and we give him a additional sum-up of the changelogs main-points from all 1.1.* announcements plus the standard "additional/other/various bugfixes/improvements"-sentences that are regularly in part of the announcements. I see no problem in just announcing it within WWN. We could also just put the techie point inside of WWN and refer to it in the press release for a more detailed technical overvie of the advantages.

1 0

Re: Release plans
by James Mckenzie 12 May '10

12 May '10

> >On 05/09/2010 05:00 PM, Alexandre Julliard wrote: >> Edward Savage <epssyis(a)gmail.com> writes: >> >>> On Sun, May 9, 2010 at 4:42 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: >>>> >>>> Unless some major problems come up, 1.1.44 will be the last of the 1.1.x >>>> series. The next release will be 1.2-rc1, which will mark the beginning >>>> of the code freeze. This should result in a 1.2 final sometime in June. >>>> >>> >>> Would it be worthwhile to put together some sort of release >>> announcement detailing changes and improvements in Wine between 1 and >>> 1.2? Some thing similar to what other projects release that tech sites >>> can pickup and talk about. Maybe even a more formal press release >>> style document. >> >> We definitely need a release changelog, yes. >> > >It seems to me what we really want is more than a changelog but a proper >release announcement. I want a journalist who has hardly heard of Wine >to read the page and understand what we've done and why it's great. > We need BOTH a change log and the press release. The Press release needs to highlight the changes like adding Windows-on-Windows 64 code and the ability to work with .NET 2.0. The Changelog should be extremely detailed and directed at the user to advise what was fixed and what is still broken or will be broken by using this release. >I've created a rough skeleton of things to have here: >http://wiki.winehq.org/Wine1.2Announcement > >I'm very busy at the Ubuntu Developer Summit at the moment but I'll put >some good work into it soon. > Thank you for starting work on the announcement. The changelog will be a much more lengthy work. James McKenzie

1 0

Re: [PATCH 1/5] ws2_32/tests: add some socket event tests
by testbot＠testbot.winehq.org 12 May '10

12 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2019 Your paranoid android. === W98SE (32 bit sock) === sock.c:3280: Test failed: Failed to empty buffer: 0 - 0 sock.c:3281: Test failed: Expected event sequence [FD_READ(0)], got [FD_CLOSE(0)] sock.c:3285: Test failed: Failed to empty buffer: 0 - 0 sock.c:3171: Test failed: Expected event sequence [], got [FD_READ(0)]

1 0

Absynth 4 though fst
by Salvatore De Paolis 11 May '10

11 May '10

Hi, i'm trying to run Absynth 4 using fst, the plugin loads but it doesn't show the GUI, just a black screen. Here's the debug log http://filebin.ca/hwgvnw/absynth4.log i'm running wine git version under debian sid do you have idea what's wrong? regards S.

2 1

today's performance results
by Dan Kegel 11 May '10

11 May '10

http://kegel.com/wine/yagmarkdata/wine-1.1.44-19-vs-wine-1.1.44-72.txt shows yesterday's wine's performance compared to today's. Highlights: Comparing wine-1.1.44-19 with wine-1.1.44-72 benchmark_variable wine-1.1.44-19 wine-1.1.44-72 ratio 3dmark06_3DMark_Score 3377.00 3388.00 1.00 3dmark2000_3DMark_Result 16662.00 16917.00 1.02 3dmark2001_3DMark_Score 15691.00 17633.00 1.12 heaven2_d3d9_FPS 9.31 11.08 1.19 heaven2_gl_FPS 16.12 16.21 1.01 Golly, looks like http://www.winehq.org/pipermail/wine-cvs/2010-May/066833.html was a win. Here are a few notes about the raw results. A couple benchmarks (really short ones?) seem to have strongly bimodal distributions on Wine. For instance, here are ten measurements on each OS of 3dmark06_CPU2_Red_Valley: wine-1.1.44-19 1.33 1.36 1.36 1.36 1.37 1.37 1.37 1.37 1.37 1.37 wine-1.1.44-72 1.30 1.31 1.31 1.31 1.31 1.32 1.32 1.32 1.32 1.38 Vista 1.39 1.39 1.39 1.39 1.39 1.39 1.39 1.39 1.39 1.39 For some reason, today's wine usually had the slow result, whereas yesterday it usually had the fast result. Vista didn't suffer from this, and was slightly faster, too. Why does Wine return a slow result sometimes? 3dmark2000_Game_1_Helicopter_High_Detail was quite variable under Wine (and slightly better today), but hardly varied at all on Vista: wine-1.1.44-19 133.70 133.90 141.60 145.00 145.40 151.60 159.30 161.80 164.40 173.60 wine-1.1.44-72 139.50 144.70 154.10 157.40 157.90 162.40 170.50 178.80 180.80 198.60 Vista 281.60 282.50 282.90 283.20 283.40 283.60 283.70 283.80 284.00 284.50 What can explain such variability? heaven2_d3d9_FPS, on the other hand, didn't vary much on Wine - and was quite a bit better today: wine-1.1.44-19 9.23 9.28 9.30 9.30 9.30 9.31 9.31 9.32 9.32 9.32 wine-1.1.44-72 11.05 11.07 11.07 11.07 11.08 11.08 11.08 11.09 11.10 11.10 Vista 18.37 18.37 18.38 18.38 18.38 18.38 18.38 18.38 18.38 18.38 Perhaps I should strip down my system and run fvwm95 rather than Gnome, etc., to see if I can reduce the noise a bit more. - Dan

3 4

Re: [6/6] msi: Set the SourceDir property to the registered source if the product is installed.
by testbot＠testbot.winehq.org 11 May '10

11 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1998 Your paranoid android. === W98SE (32 bit patch) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit patch) === Timeout === W2KPROSP4 (32 bit patch) === Timeout

1 0

Re: [2/6] msi: Add more patch registration tests.
by Paul Vriens 11 May '10

11 May '10

On 05/11/2010 02:02 PM, Hans Leidekker wrote: > --- > dlls/msi/tests/patch.c | 23 +++++++++++++++++++++-- > 1 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/dlls/msi/tests/patch.c b/dlls/msi/tests/patch.c > index ad581d1..a835e1d 100644 > --- a/dlls/msi/tests/patch.c > +++ b/dlls/msi/tests/patch.c > @@ -33,6 +33,8 @@ > static UINT (WINAPI *pMsiApplyPatchA)( LPCSTR, LPCSTR, INSTALLTYPE, LPCSTR ); > static UINT (WINAPI *pMsiGetPatchInfoExA)( LPCSTR, LPCSTR, LPCSTR, MSIINSTALLCONTEXT, > LPCSTR, LPSTR, DWORD * ); > +static UINT (WINAPI *pMsiEnumPatchesExA)( LPCSTR, LPCSTR, DWORD, DWORD, DWORD, LPSTR, > + LPSTR, MSIINSTALLCONTEXT *, LPSTR, LPDWORD ); > > static const char *msifile = "winetest-patch.msi"; > static const char *mspfile = "winetest-patch.msp"; > @@ -143,6 +145,7 @@ static void init_function_pointers( void ) > > GET_PROC( hmsi, MsiApplyPatchA ); > GET_PROC( hmsi, MsiGetPatchInfoExA ); > + GET_PROC( hmsi, MsiEnumPatchesExA ); > #undef GET_PROC > } > > @@ -988,9 +991,9 @@ static void test_system_tables( void ) > static void test_patch_registration( void ) > { > UINT r, size; > - char buffer[MAX_PATH]; > + char buffer[MAX_PATH], patch_code[39]; > > - if (!pMsiApplyPatchA || !pMsiGetPatchInfoExA) > + if (!pMsiApplyPatchA || !pMsiGetPatchInfoExA || !pMsiEnumPatchesExA) > { > win_skip("required functions not available\n"); > return; > @@ -1043,6 +1046,22 @@ static void test_patch_registration( void ) > ok( r == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", r ); > ok( !buffer[0], "got %s\n", buffer ); > > + r = MsiEnumPatchesExA( "{913B8D18-FBB6-4CAC-A239-C74C11E3FA74}", > + NULL, MSIINSTALLCONTEXT_USERUNMANAGED, MSIPATCHSTATE_APPLIED, > + 0, patch_code, NULL, NULL, NULL, NULL ); > + ok( r == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", r ); > + ok( !strcmp( patch_code, "{0F96CDC0-4CDF-4304-B283-7B9264889EF7}" ), "wrong patch code\n" ); > + > + r = MsiEnumPatchesExA( "{913B8D18-FBB6-4CAC-A239-C74C11E3FA74}", > + NULL, MSIINSTALLCONTEXT_MACHINE, MSIPATCHSTATE_APPLIED, > + 0, patch_code, NULL, NULL, NULL, NULL ); > + ok( r == ERROR_NO_MORE_ITEMS, "expected ERROR_NO_MORE_ITEMS, got %u\n", r ); > + > + r = MsiEnumPatchesExA( "{913B8D18-FBB6-4CAC-A239-C74C11E3FA74}", > + NULL, MSIINSTALLCONTEXT_USERMANAGED, MSIPATCHSTATE_APPLIED, > + 0, patch_code, NULL, NULL, NULL, NULL ); > + ok( r == ERROR_NO_MORE_ITEMS, "expected ERROR_NO_MORE_ITEMS, got %u\n", r ); > + > r = MsiInstallProductA( msifile, "REMOVE=ALL" ); > ok( r == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", r ); > You forgot to actually use pMsiEnumPatchesExA in some of these calls (hence the WTB failures). -- Cheers, Paul.

1 0

Re: [3/6] msi: Add a test to show that the InstallSource property is unchanged after an upgrade.
by testbot＠testbot.winehq.org 11 May '10

11 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1997 Your paranoid android. === W98SE (32 bit patch) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit patch) === Timeout === W2KPROSP4 (32 bit patch) === Timeout

1 0

Re: [2/6] msi: Add more patch registration tests.
by testbot＠testbot.winehq.org 11 May '10

11 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1996 Your paranoid android. === W98SE (32 bit patch) === Failure running script in VM: Exceeded timeout limit of 315 sec === WNT4WSSP6 (32 bit patch) === Timeout === W2KPROSP4 (32 bit patch) === Timeout

1 0

Re: kernel32/tests: Remove variable ret which is not really used from load_blackbox. (RESEND)
by testbot＠testbot.winehq.org 11 May '10

11 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1969 Your paranoid android. === W7PROX64 (64 bit debugger) === debugger.c:299: Test failed: Timed out waiting for the child to crash debugger.c:313: Test failed: wrong exit code : 00000103 debugger.c:324: Test failed: Timed out waiting for the debugger debugger.c:146: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wt5825.tmp': read=0 debugger.c:329: Test failed: wrong debugger argument count: -28562032 debugger.c:330: Test failed: the child and debugged pids don't match: 660 != 2046 debugger.c:299: Test failed: Timed out waiting for the child to crash debugger.c:306: Test failed: wrong exit code : 00000103 debugger.c:324: Test failed: Timed out waiting for the debugger debugger.c:146: Test failed: wrong size for 'C:\Users\winetest\AppData\Local\Temp\wt2D25.tmp': read=0 debugger.c:329: Test failed: wrong debugger argument count: -28562032 debugger.c:330: Test failed: the child and debugged pids don't match: 1368 != 2046 Timeout

2 1

Re: Remove variable hFont which is not really used from MF_PlayMetaFile. (RESEND)
by Alexandre Julliard 11 May '10

11 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > --- > dlls/gdi32/metafile.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) It seems pretty clear that it should be used, not removed. -- Alexandre Julliard julliard(a)winehq.org

2 1

On Ubuntu Lucid? Add the Wine PPA!
by David Gerard 10 May '10

10 May '10

I updated to Lucid in early March and have only just realised I haven't been getting Wine updates. Did you forget too? Then, per the upgrades page: sudo add-apt-repository ppa:ubuntu-wine/ppa - then update and upgrade. Much nicer! - d.

1 0

RFC on console management
by Eric Pouech 10 May '10

10 May '10

There are a couple of shortcomings in our current console implementation. To name a few: - the "bare console handles" concept has very short limitations (see bug reports #5541, or #13189). Globally, bare handles are actually handles to files, whereas lots of programs expect them to behave like console handles. Among the known shortcomings: + A1: GetFileType() returns wrong value, + A2: the console functions should return correct/default values, starting with codepage (in your xterm locale if UTF.8 for example, cmd output is bogus). + A3: no line edition is supported on bare handles There are also issues with the wineconsole back-ends: - B1: wineconsole --backend=curses mypgm.exe doesn't support the redirection of unix default handles (ie. wineconsole --backend=curses mypgm.exe > foo sends all ANSI escapes to the foo file, which isn't what we expect. - B2: in Windows, a GUI program doesn't inherit the console of its parent (it only does if it's a CUI program) - B3: when being nasty, one could create several wineconsole instances for the same TTY, whereas popular wisdom would claim that one is (more than) sufficient - B4: console allocation and inheritance is not properly managed. Let's take the following example: + we have two exes (Cui and CuiChild), CuiChild being started by Cui. Cui is started from command line. + Cui does, in this order: FreeConsole AllocConsole CreateProcess("CuiChild") ExitProcess + AllocConsole spawns an instance of wineconsole, inheriting the Unix fd:s from Cui. + CuiChild inherits the wine console from it's parent + when Cui dies, it also, from the Unix standpoint detaches from the Unix console, and wineconsole loses access to the TTY as it's Unix parent has died. And we lose all input/output for all apps tied to this wineconsole. - B5: job control. We poorly interact with unix console job control I'd like to get feedback on the best way to go in order to put console management on a reliable architecture. Scenario I (aka Client side) ---------------------------- Create simple wineserver objects (ie not linked to wineconsole) for bare console handles. All the management would be done in kernel32, by distinguishing bare console handles from wineserver console handles. Scenario II (aka Wineconsole side) ---------------------------------- Extend the current console objects in wineserver and wineconsole to support a line oriented mode (instead of current mode which takes control of the full screen for both curses and user backends). Comparison (for each criteria, scenarios are ranked best to worse): Size of changes: I,II ScI will require less changes Maintainability: II,I - for ScII, in kernel32, we only deal with console objects, we all behave the same - for ScII all term/termcap support is centralized in wineconsole (A3 would require term/termcap to get the correct keys) Speed: I,II - ScII will require app <=> wineserver <=> wineconsole messages in order to work (ScI will read all fd:s directly). ScII could be enhanced by having messages directly managed between app and wineconsole and bypassing wineserver, but still would be slower Inheritance: II,I - all required mechanisms (except B4) would be similar - for B4, ScI will be hard to implement, as we don't have an app that will keep the control on the unix terminal until all children have died. The most viable solutions (in the wording of B4 above): + don't exit Cui until all its children, grand children... have died. Possible to do, but we may want at some point to hide this running (Unix) app from the list of running (Windows) app, and this will be tricky + create a (Unix) wrapper app that will be kept open until all children have died. Possible but will hinder a lot the tracking/debugging tools (gdb, valgrind) - it may be a bit simpler for ScII, as wineconsole could play the role of the controling app (but with potentially the same limitations) Functionalities: II,I - ScII will ease the job control integration, as wineconsole would gain control of the unix terminal, and hence convert properly the unix events to the windows one. I'd rather favor ScII, but the differences are not that big, so your comments are welcome. -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Re: Improve error handling in scmdatabase_autostart_services. (RESEND)
by Alexandre Julliard 10 May '10

10 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I noticed that we are not using the error code coming from service_start, > and indeed there was a FIXME there already. Would it make sense to handle > this (at least) somehow like the patch below? > > If preferred, I could also yank the err variable, but I figured you'd > prefer the error handling. (Or is there a mistake I made when adding > that handling?) Printing an ERR is not error handling. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advpack: Remove two variables which are not really used and two extraneous invocations of get_parameter from RegisterOCX. (RESEND)
by Alexandre Julliard 10 May '10

10 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > This passes testing fine for me and there are no further invocations of > get_parameter in this function (which operates on a copy), so this also > looks like an optimization? They should be used, as the comment above indicates. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: How to change text on winehq.org ?
by marco 10 May '10

10 May '10

Thank you all for your reply, I'm not familiar with this process , but I will try to find out how this works. Do I have to install git en download the complete source of the website, or can I only download the download.template change that and submit that somewhere ? Marco On 06-05-10 17:57, James Mckenzie wrote: >> Hi WineDevs, >> >> If make the packages for mandriva on sourceforge. And the text on the >> download page on the website (winehq,org) for mandriva is getting old. >> Who can I write a mail to change the text ? I already tried web-admin ad >> winehq.org some weeks ago but no reaction so far. >> >> > The source code for winehq is available. You then make the changes you feel are necessary to the source code, create a difference file and submit this to wine-patches. > > Are you familiar with this process? > > James McKenzie > > >

3 2

Re: shdocvw: implement IWebBrowser2::get_LocationName
by Jacek Caban 10 May '10

10 May '10

Hi Andrey, On 5/9/10 9:30 PM, Andrey Turkin wrote: > --- > dlls/shdocvw/tests/webbrowser.c | 27 ++++++++++++++++++++++++--- > dlls/shdocvw/webbrowser.c | 24 ++++++++++++++++++++++-- > 2 files changed, 46 insertions(+), 5 deletions(-) + if (This->doc_host.document&& SUCCEEDED(IUnknown_QueryInterface( + This->doc_host.document,&IID_IHTMLDocument2, (void**)&doc))) { + hres = IHTMLDocument2_get_title(doc, LocationName); + IHTMLDocument2_Release(doc); There is no reason to make this MSHTML-specific by using IHTMLDocument2 here. Jacek

2 1

CVS repository problem
by Paul Chitescu 10 May '10

10 May '10

Hi! Something is - again - wrong with CVS. Although I fetched a wine with git I tried to verify some patches I had in the CVS tree. cvs -z3 -q up -APd cvs update: failed to create lock directory for `/home/wine/wine/dlls/acledit' (/home/wine/wine/dlls/acledit/#cvs.lock): Permission denied cvs update: failed to obtain dir lock in repository `/home/wine/wine/dlls/acledit' cvs [update aborted]: read lock failed - giving up Maybe a chown -R would help? Paul Chitescu

2 2

Re: gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject
by Jerome Leclanche 10 May '10

10 May '10

On Sun, May 9, 2010 at 11:55 PM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Testcase for bug 18864. > > J. Leclanche > This patch reveals a crash in GetObject in wine which I'm unsure how to fix. Someone proposed using IsBadWritePtr(), but from what I understand, this is not a recommended solution. Any idea?

2 3

Re: comctl32: Remove unused parameter bEnable from LISTVIEW_Enable.
by Vitaliy Margolen 10 May '10

10 May '10

On 05/09/2010 07:06 AM, Gerald Pfeifer wrote: > --- > case WM_ENABLE: > - return LISTVIEW_Enable(infoPtr, (BOOL)wParam); > + return LISTVIEW_Enable(infoPtr); This indicates a bug. The parameter should really be used by LISTVIEW_Enable(). Vitaliy.

1 0

Re: Added check for PROCESS_VM_WRITE, without which, some programs go into an infinite loop Henry Blum <henry.blum@gmail.com>
by Andrey Turkin 10 May '10

10 May '10

08.05.2010 9:10, Henry Blum wrote: > --- > dlls/kernel32/process.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 9a1f2f5..6dcad8f 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -2657,7 +2657,7 @@ HANDLE WINAPI OpenProcess( DWORD access, BOOL > inherit, DWORD id ) > if (GetVersion() & 0x80000000) access = PROCESS_ALL_ACCESS; > status = NtOpenProcess(&handle, access, &attr, &cid); > - if (status != STATUS_SUCCESS) > + if (status != STATUS_SUCCESS || (access & PROCESS_VM_WRITE)) > { > SetLastError( RtlNtStatusToDosError(status) ); > return NULL; Wouldn't this pretend operation failed for every request with PROCESS_VM_WRITE, even if NtOpenProcess succeeded, and leak a handle? Which bug should it fix?

3 2

Re: urlmon/tests: Added a new test file for testing the IUri interface
by testbot＠testbot.winehq.org 10 May '10

10 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1987 Your paranoid android. === W98SE (32 bit uri) === Failure running script in VM: Exceeded timeout limit of 315 sec === W2KPROSP4 (32 bit uri) === Timeout === W2K3R2SESP2 (32 bit uri) === Timeout

1 0

Re: user32/tests: Remove variable atom which is not really used from test_Expose.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1983 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2666: Test failed: GetActiveWindow() = 00000000 win.c:2666: Test failed: GetFocus() = 00000000 win.c:2692: Test failed: GetActiveWindow() = 00000000 win.c:2692: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070136 fg 00010040 in hook HCBT_SETFOCUS win.c:2751: Test failed: GetActiveWindow() = 00000000 win.c:2751: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0003015A fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00300136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000301A0 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000701A0 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000801A0 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00190138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0003015A fg 00010040 in hook HCBT_SETFOCUS

2 1

Re: user32/tests: Remove SetShellWindowEx from test_shell_window.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1974 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006F0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00080138 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B012C fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00320138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000A0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B0136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00810178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000B012C fg 00010040 in hook HCBT_SETFOCUS

2 1

Compilation failure in wine-1.1.44
by wylda＠volny.cz 09 May '10

09 May '10

Hi guys, i can't compile wine-1.1.44 (1.1.43 is OK here like all the ones before)... As i guess you would not release a wine, which can't be compiled, than i suspect there could be a trouble in my system (Debian Lenny 32bit). For this reason, i did not bother to fill a bug ;) as it would be marked invalid... Any suggestion? I wanted to give some bugs a retest, but i'm stuck ;) ... make[2]: Leaving directory `/home/pavel/install/wine/src/wine-1.1.44/tools' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o config.o ./config.c -DBINDIR='"/usr/local/bin"' -DDLLDIR='"/usr/local/lib/wine"' -DLIB_TO_BINDIR=\"`../../tools/relpath /usr/local/lib /usr/local/bin`\" -DLIB_TO_DLLDIR=\"`../../tools/relpath /usr/local/lib /usr/local/lib/wine`\" -DBIN_TO_DLLDIR=\"`../../tools/relpath /usr/local/bin /usr/local/lib/wine`\" -DBIN_TO_DATADIR=\"`../../tools/relpath /usr/local/bin /usr/local/share/wine`\" gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o cptable.o cptable.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o debug.o debug.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o fold.o fold.c gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DWINE_UNICODE_API="" -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -g -O0 -o ldt.o ldt.c {standard input}: Assembler messages: {standard input}:1472: Error: symbol `wine_get_fs' is already defined {standard input}:1502: Error: symbol `wine_set_fs' is already defined make[1]: *** [ldt.o] Error 1 make[1]: Leaving directory `/home/pavel/install/wine/src/wine-1.1.44/libs/wine' make: *** [libs/wine] Error 2

7 9

Re: gdi32/tests: Add a test to check for ERROR_NOACCESS when passing an invalid buffer to GetObject
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1981 Your paranoid android. === W98SE (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === WNT4WSSP6 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W2KPROSP4 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === WXPPROSP3 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W2K3R2SESP2 (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === WVISTAADM (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W2K8SE (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W7PRO (32 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559 === W7PROX64 (64 bit gdiobj) === gdiobj.c:68: Test failed: GetObject(invalid buff), expected 0, ERROR_NOACCESS, got 0, 3735928559

1 0

Wine should warn when ulimit -n needs raising
by Octavian Voicu 09 May '10

09 May '10

I was looking at http://bugs.winehq.org/show_bug.cgi?id=19861 and it seemed pretty easy to fix. In my opinion, the warning should either go in server/file.c - file_set_error() or in server/fd.c - open_fd(). open_fd() is pretty much the only place where open() is called, so it's a good candidate. On the other hand, having the check in file_set_error() might detect the condition in more instances, but it might also impact performance (file_set_error() is called really often; having lots of code in one branch might make the compiler generate slower code). The warning would go on the ENFILE/EMFILE branches, and maybe also print the value of getrlimit(RLIMIT_NOFILE) and suggest a fix (editing /etc/security/limits.conf). Octavian

2 2

Re: shdocvw: implement IWebBrowser2::get_LocationName
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1977 Your paranoid android. === W98SE (32 bit webbrowser) === webbrowser.c:1236: Test failed: unexpected call UpdateUI webbrowser.c:315: Test failed: unexpected nsCmdID 21 webbrowser.c:259: Test failed: unexpected call QueryStatus_STOP === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:2497: Test failed: CoCreateInterface failed: 80040154 webbrowser.c:2497: Test failed: CoCreateInterface failed: 80040154

1 0

Re: wined3d: Make forced reading of a byte in flush_to_framebuffer_drawpixels more reliable.
by Stefan Dösinger 09 May '10

09 May '10

I think this should be removed entirely. I added it in 2005 because Mesa back then choked on our protected memory(X server freeze or kernel panic). Around 2008 I checked if this bug still exists, and it seems to be fixed. If anyone still runs into this bug he should seriously consider upgrading his Mesa installation... Am 07.05.2010 um 23:20 schrieb Gerald Pfeifer: > Looking at the current code in flush_to_framebuffer_drawpixels it occurs > to me that we really need to mark the memory we want to _read_ volatile, > not the local variable that is used to "force" reading said memory. > > That is more direct, more logical, and even more efficient. > > Looking at the generated code of all of dlls/wined3d/surface.c the > only material difference is > > movb %al, -25(%ebp) > > which is saving the byte we are trying to read onto the stack and into > the local variable. And that is the part that indeed is not necessary. > > Gerald > > --- > dlls/wined3d/surface.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index bb18b95..199a1bd 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -1839,8 +1839,7 @@ static void flush_to_framebuffer_drawpixels(IWineD3DSurfaceImpl *This, GLenum fm > * ReleaseDC, and the app won't use the dc any more afterwards. > */ > if((This->Flags & SFLAG_DIBSECTION) && !(This->Flags & SFLAG_PBO)) { > - volatile BYTE read; > - read = This->resource.allocatedMemory[0]; > + *(volatile BYTE*)This->resource.allocatedMemory; > } > > if(This->Flags & SFLAG_PBO) { > -- > 1.6.6.2 >

1 0

Re: localspl/tests: Improve the tests in test_XcvDataPort_AddPort by properly checking return values and avoiding a duplicat
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1970 Your paranoid android. === WINEBUILD (build) === Patch failed

2 1

Re: [PATCH] ntdll: Reimplement qsort() using generic mergesort
by Vincent Pelletier 09 May '10

09 May '10

Le dimanche 09 mai 2010 13:09:47, Marcus Meissner a écrit : > As __cdecl (for the compare function) is not the UNIX cdecl in Win64 > anymore, we need to reimplement sort to call the right comparator > functions. Not that it's important, but that reminded me of this: http://docs.python.org/library/ctypes.html#callback-functions (scroll a bit for qsort example on windows vs. linux) It would be interesting (though probably futile) to see how this code behaves. -- Vincent Pelletier

1 0

re: Release plans
by Dan Kegel 09 May '10

09 May '10

Tom Wickline wrote: >> http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bu… > > Three releases to fix 88 nasty bugs? The sad fact is that it would take a lot more than that to fix them all, and it probably doesn't make sense to hold up the release until it's perfect. We probably want to update http://wiki.winehq.org/WineReleaseCriteria with the current release criteria. Some other interesting searches: Bugs marked as 'regression' (340!): http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bu… Bugs marked 'bisected': http://bugs.winehq.org/buglist.cgi?quicksearch=bisected Anything A.F. has analyzed : http://bugs.winehq.org/buglist.cgi?product=Wine&bug_status=UNCONFIRMED&bug_… - Dan

6 9

RFC kernel32: add test for FindFirstFileA with a path ending with "/>"
by Vincent Pelletier 09 May '10

09 May '10

This test passes on win2k & winxp, fails on wine. That failure causes cdkey verification problems in "Earth 2160" as sold on GOG.com: Once the installation is finished, the installers generates a registry key value based (among other things) on the ctime of installed directory. Looked-up path has trailing "/>", causing the registry key to be incorrect and the game rejects it. I have no idea how to solve this error at the moment, nor the whole set of acceptable path trails. Please advise me if you have insight on this, and I'll see if I can fix it. This is the reason why I didn't add a todo_wine in the test. --- dlls/kernel32/tests/file.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)

2 3

Re: shell32/tests: Remove variable res which is not really used from init_strings.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1972 Your paranoid android. === W2KPROSP4 (32 bit progman_dde) === progman_dde.c:442: Test failed: CreateGroup Group1: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [C_G:2] === W2K3R2SESP2 (32 bit progman_dde) === progman_dde.c:507: Test failed: DeleteGroup Group1: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_G:13] progman_dde.c:587: Test failed: Compound String [CreateGroup(Group3)][AddItem(C:\WINDOWS\TEMP\dde14.tmp,f1g3Name)][AddItem(C:\WINDOWS\TEMP\dde15.tmp,f2g3Name)]: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [CPD:14] progman_dde.c:507: Test failed: DeleteGroup Group3: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_G:15] === W7PRO (32 bit progman_dde) === progman_dde.c:369: Test failed: Window "Group1" was not created in 45 seconds - assumed failure. [S_G:12]

1 0

Re: Added check for PROCESS_VM_WRITE, without which, some programs go into an infinite loop Henry Blum <henry.blum@gmail.com>
by Charles Davis 09 May '10

09 May '10

On 5/7/10 11:10 PM, Henry Blum wrote: > - if (status != STATUS_SUCCESS) > + if (status != STATUS_SUCCESS || (access & PROCESS_VM_WRITE)) According to this, opening a process and specifying the PROCESS_VM_WRITE access right causes OpenProcess() to fail. Why do you need this? And what about programs that legitimately need to write to another process's VM? Chip

1 0

Re: [2/2] gdiplus: Implement GdipGetImageThumbnail.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1960 Your paranoid android. === W2K3R2SESP2 (32 bit image) === No test summary line found === WVISTAADM (32 bit image) === Timeout

1 0

Re: [1/2] gdiplus: Add test for GdipGetImageThumbnail.
by testbot＠testbot.winehq.org 09 May '10

09 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1959 Your paranoid android. === W2K3R2SESP2 (32 bit image) === No test summary line found === WVISTAADM (32 bit image) === Timeout

1 0

Re: user32: Fix selected brush color for caret bitmap creation
by Nikolay Sivov 08 May '10

08 May '10

On 5/8/2010 22:20, Nikolay Sivov wrote: > Fixes bug 1733. > > Selected brush color should depend on current window color or other system settings, it just inverts hdc colors. (should -> shouldn't)

1 0

Re: gdiplus: Implement bitmap color keying.
by testbot＠testbot.winehq.org 08 May '10

08 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1955 Your paranoid android. === W2K3R2SESP2 (32 bit image) === No test summary line found === WVISTAADM (32 bit image) === Timeout

1 0

Re: mshtml/tests: Fix return value of ActiveScript_SetScriptState.
by Jacek Caban 08 May '10

08 May '10

Hi Gerald, On 5/2/10 9:16 PM, Gerald Pfeifer wrote: > IActiveScriptSite_OnStateChange is described to return S_OK upon > success, so instead of ignoring its return value and unconditionally > returning S_OK it strikes me that we should return its result instead. > In this case returning S_OK is fine, but there is missing test for OnStateChange return value. Jacek

2 2

Re: mshtml: Fix return type value for HTMLBodyElement_put_text.
by Jacek Caban 08 May '10

08 May '10

On 5/8/10 1:07 PM, Gerald Pfeifer wrote: > The current code does not handle an error coming out of > nsIDOMHTMLBodyElement_SetText and actually discards whatever nsres > is set to. > > Jacek, is a patch like this okay, should we just remove nsres, or > is it more complicated than that? > We can't mix nsresult with HRESULT. We should check for failure and return something like E_FAIL (and preferably print an error, there is something seriously wrong if SetText fails). Thanks, Jacek

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel