- wine-devel - winehq.org

Re: Add tests for ImageGetDigestStream
by testbot＠testbot.winehq.org 08 May '10

08 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1950 Your paranoid android. === W7PROX64 (64 bit image) === image.c:324: Test failed: ImageGetDigestStream failed: 87 image.c:187: Test failed: flags = 0: expected 7 updates, got 3 image.c:194: Test failed: flags = 0, update 2: unexpected value image.c:187: Test failed: flags = CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO: expected 5 updates, got 3 image.c:194: Test failed: flags = CERT_PE_IMAGE_DIGEST_ALL_IMPORT_INFO, update 2: unexpected value

1 0

Re: gdi32/tests: Remove two variables which are not really used from test_clipping.
by Nikolay Sivov 07 May '10

07 May '10

On 5/3/2010 03:48, Gerald Pfeifer wrote: > --- > dlls/gdi32/tests/bitmap.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index 882d548..b570a8a 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -2810,9 +2810,7 @@ static void test_GdiAlphaBlend(void) > static void test_clipping(void) > { > HBITMAP bmpDst; > - HBITMAP oldDst; > HBITMAP bmpSrc; > - HBITMAP oldSrc; > HRGN hRgn; > LPVOID bits; > BOOL result; > @@ -2830,11 +2828,9 @@ static void test_clipping(void) > > bmpDst = CreateDIBSection( hdcDst,&bmpinfo, DIB_RGB_COLORS,&bits, NULL, 0 ); > ok(bmpDst != NULL, "Couldn't create destination bitmap\n"); > - oldDst = SelectObject( hdcDst, bmpDst ); > > bmpSrc = CreateDIBSection( hdcSrc,&bmpinfo, DIB_RGB_COLORS,&bits, NULL, 0 ); > ok(bmpSrc != NULL, "Couldn't create source bitmap\n"); > - oldSrc = SelectObject( hdcSrc, bmpSrc ); > > result = BitBlt( hdcDst, 0, 0, 100, 100, hdcSrc, 100, 100, SRCCOPY ); > ok(result, "BitBlt failed\n"); > Bitmap are useless after this change.

2 2

mciseq: Prevent busy-wait while paused.
by Joerg-Cyril.Hoehle＠t-systems.com 07 May '10

07 May '10

Hi, any comment on that patch? It's currently the bottommost in source.winehq.org/patches hence may fall into the bitbucket anytime. I had noticed that the MCI MIDI player would busy loop while paused because of a while(xyz) ; statement therein. Test it using these MCI commands open c:\data\foo.mid alias m play m pause m So I simply added a Sleep() and wrote: >7 ms is arbitrary. It allows to sleep well yet be responsive enough >so the app doesn't wait too long should the next command be MCI_Stop. >For the ear, an even larger sleep would be good enough. Sleep is a sort of stop gap until someone invents a notification/setEvent/Resume patch or whatever would be TRT. Regards, Jörg Höhle

2 3

Re: Valgrind's wine_cp_wcstombs warnings
by Dan Kegel 07 May '10

07 May '10

Hi Joerg, did you try the --track-origins option? That can sometimes give more detail (see e.g. the traces in this old message): On Thu, Jul 31, 2008 at 10:14 AM, Dan Kegel <dank(a)kegel.com> wrote: > Hi Colin, > your change > http://source.winehq.org/git/wine.git/?a=commitdiff;h=c2c1a55f1c08f35ae02b8… > seems to have triggered some valgrind warnings, > http://kegel.com/wine/valgrind/logs/2008-07-31-07.46/vg-kernel32_codepage-d… > e.g. > > + Use of uninitialised value of size 4 > + at wcstombs_sbcs (wctomb.c:186) > + by wine_cp_wcstombs (wctomb.c:457) > + by WideCharToMultiByte (locale.c:1936) > + by test_string_conversion (codepage.c:288) > + by func_codepage (codepage.c:351) > + by run_test (test.h:488) > + by main (test.h:537) > + Uninitialised value was created by a stack allocation > + at test_string_conversion (codepage.c:216) > > + Use of uninitialised value of size 4 > + at wcstombs_sbcs_slow (wctomb.c:246) > + by wine_cp_wcstombs (wctomb.c:453) > + by WideCharToMultiByte (locale.c:1936) > + by test_string_conversion (codepage.c:288) > + by func_codepage (codepage.c:352) > + by run_test (test.h:488) > + by main (test.h:537) > + Uninitialised value was created by a stack allocation > + at test_string_conversion (codepage.c:216) > > Could you have a look? >

2 3

How to change text on winehq.org ?
by Marco Meijer 07 May '10

07 May '10

Hi WineDevs, If make the packages for mandriva on sourceforge. And the text on the download page on the website (winehq,org) for mandriva is getting old. Who can I write a mail to change the text ? I already tried web-admin ad winehq.org some weeks ago but no reaction so far. greetings Marco

4 3

Re: [PATCH] wordpad: add units (in/inch/pt)
by Dylan Smith 06 May '10

06 May '10

>- /* FIXME: Allow other units and convert between them */ > if(!lstrcmpA(endptr, units_cmA)) >+ { >+ if (punit != NULL) *punit = UNIT_CM; >+ endptr += 2; >+ } >+ else if (!lstrcmpA(endptr, units_inA)) >+ { >+ if (punit != NULL) *punit = UNIT_INCH; >+ endptr += 2; >+ } >+ else if (!lstrcmpA(endptr, units_inchA)) >+ { >+ if (punit != NULL) *punit = UNIT_INCH; >+ endptr += 4; >+ } >+ else if (!lstrcmpA(endptr, units_ptA)) >+ { >+ if (punit != NULL) *punit = UNIT_PT; > endptr += 2; >+ } > > return *endptr == '\0'; > } You should really use strlen(units_*A) instead of a constant for incrementing endptr since these strings may be different lengths once localized. For instance I believe inch in French is "pouce" which is 5 characters so the null byte would truncate it to "pouc". This should have already been done with "cm" units even though no translation has made it different from 2 characters in length.

1 0

Re: Stack corruption in dsound.c
by Dan Kegel 06 May '10

06 May '10

>* Can i make assumption, that log produced by wine is not buffered anywhere >and is written to console sequentially and immediately when that event >happened? (in other words log output doesn't outrun each other lines) Sadly, not in a multithreaded program. >* Is HEAP_ValidateInUseArena called automatically when HeapAlloc() or >HeapFree() is called? When WINEDEBUG=+heap, it's called on HeapFree, HeapReAlloc, or HeapSize. See http://source.winehq.org/ident?i=HEAP_ValidateInUseArena http://source.winehq.org/ident?i=validate_block_pointer Now that you know there is heap corruption, you may be able to pinpoint the line of code that causes it using Valgrind. See http://wiki.winehq.org/Wine_and_Valgrind (It's slow and uses lots of memory, so it's not practical for all apps, but when it works it's great.)

1 0

Stack corruption in dsound.c
by wylda＠volny.cz 06 May '10

06 May '10

Hi, for those of readers who don't know yet, i'm a "Hello word" programmer, so sorry for bad wording or speculation etc. I decided to look into a regression since wine 1.1.30, who nobody apparently not know what to do, otherwise it would be solved ;) The game freezes during sound initialization and i tracked it down by printf debugging to heap allocation in DirectSoundDevice_Create(). Game goes: ... DirectSoundDevice_Create() //HeapAlloc OK ... OpenAL Init ... DirectSoundDevice_Create() //HeapAlloc returns insane values ... fixme:dbghelp:validate_addr64 Unsupported address ffffffffb5e70000 fixme:dbghelp:validate_addr64 Unsupported address ffffffffb5a60000 fixme:dbghelp:validate_addr64 Unsupported address ffffffffb5a40000 fixme:dbghelp:validate_addr64 Unsupported address ffffffffb5950000 fixme:dbghelp:validate_addr64 Unsupported address ffffffffb5940000 fixme:dbghelp:validate_addr64 Unsupported address ffffffffb5920000 Frozen This happens only when builtin OpenAL is used. In this case HeapAlloc gives values always beginning with 0x234vwxyz. Builtin OpenAL example (*** BAD - Game freezes ***): device = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(DirectSoundDevice)); First call of DirectSoundDevice_Create(): 0x0014f908 = HeapAlloc(0x00110000, 0x00000008, 0x000003d4) Second call of DirectSoundDevice_Create(): 0x234228e0 = HeapAlloc(0x00110000, 0x00000008, 0x000003d4) Native OpenAL example(*** OK - Game runs***): First call of DirectSoundDevice_Create(): 0x0014fa30 = HeapAlloc(0x00110000, 0x00000008, 0x000003d4) Second call of DirectSoundDevice_Create(): 0x001566c0 = HeapAlloc(0x00110000, 0x00000008, 0x000003d4) So how do i find out, why HeapAlloc does not return sane values like in first call of DirectSoundDevice_Create()?

5 10

Wine looses a bit gaming and wins mobility?
by André Hentschel 06 May '10

06 May '10

Hi Folks, Steam seems to add a Linux client in the near future, so maybe Wine will not be needed anymore for that. or did i get something wrong? That might reduce our "market share" a bit as i guess that many Wineusers play steam games. On the other hand Intel presented its Z600, which is basically x86 but without IDE, SATA or a BIOS. Thats the reason that it cant run Windows. So Linux runs and so should Wine i guess. So we might see some mobil advantures in the near future? -- Best Regards, André Hentschel

9 14

Re: usp10: implement mirroring for bidi support
by testbot＠testbot.winehq.org 06 May '10

06 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1920 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

LinuxTag Berlin - call for projects
by Jan Gerrit Möltgen 06 May '10

06 May '10

Hello together, I'm not sure, if this is the right place for my question, but I thought it's better than the user-list. The LinuxTag in Berlin makes a call for projects ( http://wiki.linuxtag.org/w/fp:Call_for_Projects ) and in my oppinion Wine should be represented there. Has somebody already submitted an application? If yes, I would like to support, otherwise I'd like to submit an application and would be happy about every helping hand. Greetings, Jan Gerrit -- Dipl.-Wirt.-Inf. Jan Gerrit Möltgen . . . . . .gerrit.moeltgen(a)itomig.de ITOMIG GmbH . . . . . . . . . . . . . . . . . . Tel.: +49 7031 389 25 06 Otto-Lilienthal-Str. 36 . . . . . . . . . . . . . . http://www.itomig.de D-71034 Böblingen . . . . . . . . . . . . . . . http://www.itomig.de/fr Geschäftsführer: David Gümbel . . . . . HRB 728519 Amtsgericht Stuttgart Sitz der Gesellschaft: Böblingen . . . . . . . . . . . . . . . . . . . .

3 5

A revision for common PageSetup dialog
by Love Nystrom 05 May '10

05 May '10

File: dlls\comdlg32\printdlg.c Function: static void subclass_margin_edits(HWND hDlg) Hi WineDevs, I have a revision for the common page setup dialog for You. I'm not a Wine dev, but a participant in ReactOS, and we synchronize ComDlg32 with You regularly, so this revision _should_ go to You. I'll submit the full function, not a patch, since I don't work in the Wine source tree. The ReactOS sync has a different path, and most likely line numbers too, so a patch merge would go astray. I've registered with the wine-patches and wine-devel mailing lists so You can notify in case You need something else from me. Since this is not a straight 'diff' mail-body I'll post it here on wine-devel first, as I'm unsure how You handle wine-patches mail. Now to the small revision: This revision adds an error check on the winproc pointer returned by SetWindowLongPtr(.. GWLP_WNDPROC ..) and fixes a build warning issued because GCC thinks 'old_proc' is computed but never used.. I assume the reason for repeating the attempt to set 'edit_proc' is because we're not certain which editors will be present, so there _should_ be a fail-check on 'old_proc' anyway. If you _know_ 'edt4' will always be present, it would be better to move the assign for 'edit_proc' out of the loop, and avoid the repeated conditional assign. Both variants are #if'ed in the patch. Just remove the variant you don't want. --- code begin --- static void subclass_margin_edits(HWND hDlg) { int id; WNDPROC old_proc; #if 1 for(id = edt4; id <= edt7; id++) { old_proc = (WNDPROC)SetWindowLongPtrW(GetDlgItem(hDlg, id), GWLP_WNDPROC, (ULONG_PTR)pagesetup_margin_editproc); /* InterlockedCompareExchangePointer((void**)&edit_wndproc, old_proc, NULL); */ if ((edit_wndproc == NULL) && (old_proc != NULL)) edit_wndproc = old_proc; } #else old_proc = (WNDPROC) SetWindowLongPtrW ( GetDlgItem( hDlg, edt4 ), GWLP_WNDPROC, (ULONG_PTR) pagesetup_margin_editproc ); if ((edit_wndproc == NULL) && (old_proc != NULL)) edit_wndproc = old_proc; for( id = edt5; id <= edt7; id++ ) SetWindowLongPtrW ( GetDlgItem( hDlg, id ), GWLP_WNDPROC, (ULONG_PTR) pagesetup_margin_editproc ); #endif } --- code end --- The reason for the build warning is that the definition of InterlockedCompareExchangePointer() confuses GCC. It thinks 'old_proc' is computed but never used, and issues an over-sensitive, even misleading, warning. It seems like GCC doesn't realize that an intrinsic uses the value. It would be good to fix InterlockedCompareExchangePointer, or GCC. Sadly, I can't figure out how to do that. Best Regards Love N

2 1

[rfc] server: Use rtkit to set realtime priority, try 3
by Maarten Lankhorst 05 May '10

05 May '10

--- Hi gus, Thought I'd try again :) This is a cleaned up version. The license on rtkit.c will still have to change, but since it's so heavily modified to get it into a shape for wine, that only a few lines in make_realtime are still original, so it would be easy to rewrite the remainder of that function to get it fully lgplv2.1. See also https://tango.0pointer.de/pipermail/pulseaudio-discuss/2010-May/007058.html Are there any issues left, or shall I submit this one to wine-patches after the patch linked above is merged into rtkit.git ? Cheers, Maarten

1 0

Re: kernel32/tests: Remove variable len which is not really used from test_CommandLine.
by testbot＠testbot.winehq.org 05 May '10

05 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1901 Your paranoid android. === W98SE (32 bit process) === Failure running script in VM: Exceeded timeout limit of 315 sec

2 1

Re: wined3d: Remove variable blue_shift which is not really used from IWineGDISurfaceImpl_SaveSnapshot. (RESEND)
by Alexandre Julliard 05 May '10

05 May '10

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > I didn't see any response, directly or on wine-devel, so I assume > this one just fell through the cracks; thus resending (now in git > format-patch format and proper Subject). It's very unlikely that we'd want to use red and green but not blue... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Remove variable blue_shift which is not really used from IWineGDISurfaceImpl_SaveSnapshot. (RESEND)
by Henri Verbeet 05 May '10

05 May '10

On 5 May 2010 00:24, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > I didn't see any response, directly or on wine-devel, so I assume > this one just fell through the cracks; thus resending (now in git > format-patch format and proper Subject). > It probably should be used. At first sight it looks like that's not the only issue with that function though.

1 0

Trying again
by Joakim Tjernlund 05 May '10

05 May '10

This didn't show up in the archives, so trying again. >From 7882df972ec827f0e7b7b622c01be2644e54d122 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> Date: Mon, 3 May 2010 20:30:32 +0200 Subject: [PATCH] RegisterWaitForSingleObject() fix special tmo == 0 case. At http://msdn.microsoft.com/en-us/library/aa332406%28VS.71%29.aspx one can read: "If the timeOutInterval parameter is not zero (0) and the executeOnlyOnce parameter is false, the timer is reset every time the event is signaled or the time-out interval elapses." timeOutInterval == 0 makes the above false and the timer should NOT be reset, fix that. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> --- dlls/ntdll/threadpool.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 44afb01..f6c9fb4 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -377,7 +377,8 @@ static DWORD CALLBACK wait_thread_proc(LPVOID Arg) wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); wait_work_item->CallbackInProgress = FALSE; - if (wait_work_item->Flags & WT_EXECUTEONLYONCE) + if (!wait_work_item->Milliseconds || + wait_work_item->Flags & WT_EXECUTEONLYONCE) break; } else -- 1.6.4.4

2 1

What is the point of mincore() in reserve_area() in libs/wine/mmap.c?
by Johann "Myrkraverk" Oskarsson 05 May '10

05 May '10

Hi all, In the Solaris/BSD implementation of reserve_area() in libs/wine/mmap.c there is for (i = 0; i < size; i += pagesize) if (mincore( (caddr_t)addr + i, pagesize, &vec ) != -1) break; &vec is never used again in that function. What is the point of mincore() ? I'm looking at this in reference to bug 22033. Johann

3 2

Re: user32/tests: Remove variable hdata which is not really used from test_initialisation.
by testbot＠testbot.winehq.org 05 May '10

05 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1902 Your paranoid android. === W98SE (32 bit dde) === dde.c:586: Test failed: Expected TestDDEServer(, got TestDDEServer:(04dc) dde.c:588: Test failed: Got size 20 for TestDDEServer:(04dc) dde.c:934: Test failed: Expected 0, got 0000c1ae dde.c:737: Test failed: Expected '[BadCommand(Var)]', got [Command-2(Var)] dde.c:738: Test failed: Expected 18, got 32 dde.c:714: Test failed: Expected 9 or 11, got 12 dde.c:939: Test failed: Expected item atom, got 00000000 dde.c:939: Test failed: Expected item atom, got 008307f4 dde.c:812: Test failed: client failed with 14 error(s) dde.c:2040: Test failed: Expected 0xdeadbeef, got 00000083

1 0

Re: RegisterWaitForSingleObject() fix special tmo == 0 case.
by Charles Davis 04 May '10

04 May '10

On 5/4/10 12:06 AM, Joakim Tjernlund wrote: > > Here are two versions Generally, it's a bad idea to put two patches in one mail. You should instead have two separate emails, one for each patch. Chip

1 0

Re: [PATCH 1/2] tools: Added a script to build BMPs from SVGs
by Alexandre Julliard 04 May '10

04 May '10

Joel Holdsworth <joel(a)airwebreathe.org.uk> writes: > Signed-off-by: Joel Holdsworth <joel(a)airwebreathe.org.uk> > --- > Make.rules.in | 5 +-- > tools/buildbitmap | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 92 insertions(+), 3 deletions(-) > create mode 100755 tools/buildbitmap This could go in the buildicon script, most of the code is the same. -- Alexandre Julliard julliard(a)winehq.org

1 0

Winebuild b0rken on Mac OS X?
by Charles Davis 04 May '10

04 May '10

While building Wine (latest git) on Mac OS X, I noticed this: /usr/bin/nm: object: amstream_test.MDsdpi.o malformed object (LC_SEGMENT command 0 filesize field greater than vmsize field) Undefined symbols: "_GetDesktopWindow", referenced from: _func_amstream in amstream.o "_TlsGetValue", referenced from: _get_tls_data in testlist.o "_MultiByteToWideChar", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_CloseHandle", referenced from: _func_amstream in amstream.o "_TlsSetValue", referenced from: _get_tls_data in testlist.o "_DirectDrawCreate", referenced from: _func_amstream in amstream.o "_CoCreateInstance", referenced from: _create_ammultimediastream in amstream.o "_WaitForSingleObject", referenced from: _winetest_wait_child_process in testlist.o "_CoInitializeEx", referenced from: _func_amstream in amstream.o "_HeapAlloc", referenced from: _get_tls_data in testlist.o "_CoUninitialize", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_GetExitCodeProcess", referenced from: _winetest_wait_child_process in testlist.o "_GetEnvironmentVariableA", referenced from: _main in testlist.o _main in testlist.o _main in testlist.o _main in testlist.o "_ExitProcess", referenced from: _exit_process in testlist.o ___wine_spec_exe_entry in libwinecrt0.a(exe_entry.o) "_CreateFileA", referenced from: _func_amstream in amstream.o _func_amstream in amstream.o "_TlsAlloc", referenced from: _run_test in testlist.o ld: symbol(s) not found collect2: ld returned 1 exit status winegcc: gcc failed make[1]: *** [amstream_test.exe.so] Error 2 make: *** [dlls/amstream/tests] Error 2 Something's gone horribly wrong. Winebuild shouldn't be generating b0rken Mach-O files. What gives?

2 3

Re: [12/13]docs/wineusr: unix paths are supported
by Austin English 04 May '10

04 May '10

2010/5/4 André Hentschel <nerv(a)dawncrow.de>: > --- > en/wineusr-running.sgml | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/en/wineusr-running.sgml b/en/wineusr-running.sgml > index f36383f..106be37 100644 > --- a/en/wineusr-running.sgml > +++ b/en/wineusr-running.sgml > @@ -90,8 +90,8 @@ Usage: wine PROGRAM [ARGUMENTS...] Run the specified program > in the <parameter>Path</parameter> environment variable, you can > simply give the executable file name. However, if the executable > is not in <parameter>Path</parameter>, you must give the full path to > - the executable (in Windows format, not UNIX format!). For > - example, given a <parameter>Path</parameter> of the following: > + the executable. For example, given a <parameter>Path</parameter> > + of the following: > </para> > <screen> > Path="c:\windows;c:\windows\system;e:\;e:\test;f:\" > @@ -112,7 +112,11 @@ Path="c:\windows;c:\windows\system;e:\;e:\test;f:\" > </screen> > <para> > (note the backslash-escaped "\" !) > + or: > </para> > + <screen> > +<prompt>$</prompt> <userinput>wine ~/.wine/drive_c/myapps/foo.exe</userinput> > + </screen> > <para> > For details on running text mode (CUI) executables, read the > <link linkend="CUI-programs">section</link> below. > -- A lot of programs break when using Unix paths. I don't think we should encourage it. Perhaps instead put an example using wine start /unix. -- -Austin

2 1

Re: gdi32: Fix underline and strikeout for clipped to the rectangle text
by Alexandre Julliard 04 May '10

04 May '10

Ilya Shpigor <shpigor(a)etersoft.ru> writes: > There is bug with underline and strikeout font in ExtTextOutW. > > The text is clipped if the ETO_CLIPPED flag have been set and rectangle > smaller then needed for text. But underline and strikeout lines is drawed > same as when text fit in the rectangle. > > The problem screenshot (wine below): > http://bugs.etersoft.ru/attachment.cgi?id=1678 > > I suggest to check if the y coordinate of line is smaller then text rectangle > bottom. That's of course not sufficient for correct clipping. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Valgrind's wine_cp_wcstombs warnings
by Jordan Ayers 04 May '10

04 May '10

> Hi, > > running the MCI tests with Valgrind generates a lot of output like follows > > ==13170== Use of uninitialised value of size 4 > ==13170== at 0x4035369: wine_cp_wcstombs (wctomb.c:147) > ...[every line from 148 to 161] > ==13170== Use of uninitialised value of size 4 > ==13170== at 0x403550A: wine_cp_wcstombs (wctomb.c:162) > > I suspect the A<->W mapping is still not fully correct (I know at > least one more case, but I'm not sure it gets triggered by the tests) > but perhaps it's also the W->UNIX.UTF-8 conversions internal to Wine > which cause these hits. How do I tell? > > Is there any way to get more precise reporting for the above messages > (e.g. a backtrace)? The present output is not helpful at identifying > the origin of the uninitialised read. > > Perhaps Valgrind is broken? Why does it mention "size 4" when all > access in the offending function is either "char *" or "short *" > according to the source > http://source.winehq.org/source/libs/wine/wctomb.c#L145 ? > > Thanks for your help, > Jörg Höhle Joerg, If you're on a 32-bit system, your pointers would be where the 'size 4' is coming from. It looks like Valgrind thinks a pointer being dereferenced isn't initialized. (maybe src?) Jordan Ayers

1 0

Re: [3/3] rundll32: Recognize entry points passed as ordinal numbers. (try 2)
by Alexandre Julliard 04 May '10

04 May '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > @@ -119,30 +119,43 @@ static FARPROC16 get_entry_point16( HINSTANCE16 inst, LPCWSTR entry ) > static void *get_entry_point32( HMODULE module, LPCWSTR entry, BOOL *unicode ) > { > void *ret; > - DWORD len = WideCharToMultiByte( CP_ACP, 0, entry, -1, NULL, 0, NULL, NULL ); > - char *entryA = HeapAlloc( GetProcessHeap(), 0, len + 1 ); > - > - if (!entryA) > - return NULL; > > - WideCharToMultiByte( CP_ACP, 0, entry, -1, entryA, len, NULL, NULL ); > + /* determine if the entry point is an ordinal */ > + if (entry[0] == '#') > + { > + int ordinal = atoiW( entry + 1 ); > + if (ordinal <= 0) > + return NULL; You don't set the unicode flag in this case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wined3d: Fix some complaints in d3d9 texture test
by Henri Verbeet 04 May '10

04 May '10

2010/5/4 Ričardas Barkauskas <miegalius(a)gmail.com>: > Fixes some GL_INVALID_ENUM fixmes in d3d9 texture tests and bug 11167. > Why are you setting GL_GENERATE_MIPMAP_SGIS?

2 1

Re: [PATCH 4/5] d3d9/tests: Allow D3DFMT_A2R10G10B10 as supported adapter mode.
by testbot＠testbot.winehq.org 03 May '10

03 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1890 Your paranoid android. === W7PRO (32 bit device) === device.c:2442: Test failed: Expected foreground window 00020142, got 00010040. device.c:2578: Test failed: Expected foreground window 00030142, got 00010040.

1 0

Re: [1/2] dlls/crypt32: implement PFXImportCertStore()
by Juan Lang 03 May '10

03 May '10

Hi Phillippe, this attempt looks pretty incomplete. First off: + ret = pPKCS12_verify_mac(pkcs12, password, len); + if (ret == 0) + ERR_(crypt)("failed to verify pkcs12 {%p} with password \"%s\" using func {%p}\n", pkcs12, password, pPKCS12_verify_mac); + else + TRACE_(crypt)("verified pkcs12 {%p} with password \"%s\" using func {%p}\n", pkcs12, password, pPKCS12_verify_mac); You accept the PKCS12 file even if the password is incorrect. This is clearly wrong. + /* extract private key and certificate */ + ret = pPKCS12_parse(pkcs12, password, &pkey, &cert, NULL); You don't support more than a single certificate in the PKCS12 file. This may be fine for the majority of uses, but at least a warning indicating more certificates are present would be helpful. Also, a PKCS12 file can contain more than just certificates, and the tests ought at least to check this. For example, what about a PKCS12 file with a CRL in it? OpenSSL also supports at least a couple of attributes associated with the certificates. From the man page for PKCS12_parse: The friendlyName and localKeyID attributes (if present) on each certificate will be stored in the alias and keyid attributes of the X509 structure. The Crypto API also supports setting such attributes, and if you aren't going to support these, at least the tests should cover them (and marked todo_wine) so we know they're still not done. More questions: + const WCHAR storeName[] = {'S', 't', 'o', 'r', 'e', ' ', 'N', 'a', 'm', 'e', 0}; + store = CertOpenStore(CERT_STORE_PROV_MEMORY, 0, (HCRYPTPROV)NULL, CERT_STORE_CREATE_NEW_FLAG, storeName); What's the purpose of the store name? Does the native implementation do this? If not, it can be omitted. If so, the tests should check it. Thanks, --Juan

2 5

[PATCH] RegisterWaitForSingleObject() fix special tmo == 0 case.
by Joakim Tjernlund 03 May '10

03 May '10

At http://msdn.microsoft.com/en-us/library/aa332406%28VS.71%29.aspx one can read: "If the timeOutInterval parameter is not zero (0) and the executeOnlyOnce parameter is false, the timer is reset every time the event is signaled or the time-out interval elapses." timeOutInterval == 0 makes the above false and the timer should NOT be reset, fix that. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> --- Forget the earlier patches, this feels like the right fix. dlls/ntdll/threadpool.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 44afb01..f6c9fb4 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -377,7 +377,8 @@ static DWORD CALLBACK wait_thread_proc(LPVOID Arg) wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); wait_work_item->CallbackInProgress = FALSE; - if (wait_work_item->Flags & WT_EXECUTEONLYONCE) + if (!wait_work_item->Milliseconds || + wait_work_item->Flags & WT_EXECUTEONLYONCE) break; } else -- 1.6.4.4

1 0

Why reserve space below 2G without preloader? wrt. patch 1aa749d & bug 22033
by Johann "Myrkraverk" Oskarsson 03 May '10

03 May '10

Hi all, Out of sheer curiousity, why is it important to reserve space below 2G when there is no preloader? Patch 1aa749d, is libwine: Reserve some low memory space even without a preloader. has the comment: /* if we don't have a preloader, try to reserve some space below 2Gb */ and is the regression for bug 22033. http://bugs.winehq.org/show_bug.cgi?id=22033 I will be trying to determine the excact cause of the bug later. Johann

3 2

Re: [2/5] rundll32: Fail if a rundll32 window cannot be created.
by Alexandre Julliard 03 May '10

03 May '10

Andrew Nguyen <anguyen(a)codeweavers.com> writes: > --- > programs/rundll32/rundll32.c | 16 +++++++++++++--- > 1 files changed, 13 insertions(+), 3 deletions(-) This will prevent initializing the prefix without an X display. Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Valgrind's wine_cp_wcstombs warnings
by Joerg-Cyril.Hoehle＠t-systems.com 03 May '10

03 May '10

Hi, running the MCI tests with Valgrind generates a lot of output like follows ==13170== Use of uninitialised value of size 4 ==13170== at 0x4035369: wine_cp_wcstombs (wctomb.c:147) ...[every line from 148 to 161] ==13170== Use of uninitialised value of size 4 ==13170== at 0x403550A: wine_cp_wcstombs (wctomb.c:162) I suspect the A<->W mapping is still not fully correct (I know at least one more case, but I'm not sure it gets triggered by the tests) but perhaps it's also the W->UNIX.UTF-8 conversions internal to Wine which cause these hits. How do I tell? Is there any way to get more precise reporting for the above messages (e.g. a backtrace)? The present output is not helpful at identifying the origin of the uninitialised read. Perhaps Valgrind is broken? Why does it mention "size 4" when all access in the offending function is either "char *" or "short *" according to the source http://source.winehq.org/source/libs/wine/wctomb.c#L145 ? Thanks for your help, Jörg Höhle

1 0

Re: ddraw: Fix missing D3D misc caps
by Stefan Dösinger 03 May '10

03 May '10

Am 02.05.2010 um 22:07 schrieb Ričardas Barkauskas: > Fixes missing D3D misc caps needed by Independence War 2: Edge Of Chaos (bug 7012) The patch seems ok

1 0

Re: [ddraw] Fix discrepancy in alpha mask for WINED3DFMT_B2G3R3A8_UNORM.
by Stefan Dösinger 03 May '10

03 May '10

Am 02.05.2010 um 08:26 schrieb Vincent Pelletier: > > PixelFormat_DD2WineD3D returns WINED3DFMT_B2G3R3A8_UNORM when alpha mask > is 0xFF00, which is consistent with constant name (A8). The patch looks ok to me.

1 0

Re: [PATCH] Fix Unicode escape string occurring when calling GetClipboardData(CF_TEXT).
by Dmitry Timoshkov 03 May '10

03 May '10

Sin-ta Hsiea <ibmibmibm.tw(a)gmail.com> wrote: > Here's a patch that fetch UTF8 string, and convert to local codepage. > + count = WideCharToMultiByte(CP_OEMCP, 0, lpwstr, -1, NULL, 0, NULL, NULL); > + hText = GlobalAlloc(GMEM_MOVEABLE | GMEM_DDESHARE, count); > + > + if (hText) > + { > + CHAR *text = GlobalLock(hText); > + WideCharToMultiByte(CP_OEMCP, 0, lpwstr, -1, text, -1, NULL, NULL); > + GlobalUnlock(hText); > + } CP_OEMCP is not a local codepage. -- Dmitry.

1 0

Re: [Wine] Potential bug in RtlRegisterWait()
by Joakim Tjernlund 03 May '10

03 May '10

Charles Davis <cdavis(a)mymail.mines.edu> wrote on 2010/05/03 01:18:25: > > On 5/2/10 3:02 PM, Joakim Tjernlund wrote: > > > > Noticed that RtlRegisterWait() will approve a zero timeout value(Milliseconds == 0) > > > > This makes ies4linux spin the CPU 100% when visiting a > > https page. The below crude patch fixes it: > > > > --- dlls/ntdll/threadpool.c.org 2010-05-02 22:37:08.000000000 +0200 > > +++ dlls/ntdll/threadpool.c 2010-05-02 22:46:45.000000000 +0200 > > @@ -427,6 +427,9 @@ > > > > TRACE( "(%p, %p, %p, %p, %d, 0x%x)\n", NewWaitObject, Object, Callback, > Context, Milliseconds, Flags ); > > > > + if (!Milliseconds) > > + return RPC_NT_INVALID_TIMEOUT; > > + > > wait_work_item = RtlAllocateHeap( GetProcessHeap(), 0, sizeof(*wait_work_item) ); > > if (!wait_work_item) > > return STATUS_NO_MEMORY; > > > > On a related note, whitout this patch wineserver also goes into an endless > > loop, doing brk() calls over and over until memory is exausted. Seems > > like a bug that too. > This looks like something you should post to wine-devel. Right, posting there but with a new patch. I think the orginal fix was wrong. Here is a new one: >From 2f5e169e286265bb82b17f76023c463bc2a96703 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund <Joakim.Tjernlund(a)transmode.se> Date: Mon, 3 May 2010 09:03:09 +0200 Subject: [PATCH] RegisterWaitForSingleObjectX(), fix tmo == 0 Timeout == 0 is special, from the manual: The time-out interval, in milliseconds. The function returns if the interval elapses, even if the object's state is nonsignaled. If dwMilliseconds is zero, the function tests the object's state and returns immediately. If dwMilliseconds is INFINITE, the function's time-out interval never elapses. 1) Only call Callback iff signaled 2) Implies WT_EXECUTEONLYONCE. 3) Callback should be called before returning. This is a crude fix not impl. 3) but is enough to get ies4linux around the 100% CPU problem. Not sure tmo == 0 implies returning a NULL ptr for phNewWaitObject too. --- dlls/ntdll/threadpool.c | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index 44afb01..159baee 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -373,11 +373,17 @@ static DWORD CALLBACK wait_thread_proc(LPVOID Arg) wait_work_item->Context ); TimerOrWaitFired = TRUE; } - wait_work_item->CallbackInProgress = TRUE; - wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); - wait_work_item->CallbackInProgress = FALSE; + /* Milliseconds == 0 is special, only call Callback iff + signaled and treat as WT_EXECUTEONLYONCE */ + if (wait_work_item->Milliseconds || !TimerOrWaitFired) + { + wait_work_item->CallbackInProgress = TRUE; + wait_work_item->Callback( wait_work_item->Context, TimerOrWaitFired ); + wait_work_item->CallbackInProgress = FALSE; + } - if (wait_work_item->Flags & WT_EXECUTEONLYONCE) + if (!wait_work_item->Milliseconds || + wait_work_item->Flags & WT_EXECUTEONLYONCE) break; } else -- 1.6.4.4

1 0

Re: localspl/tests: Improve the tests in test_XcvDataPort_AddPort by properly checking return values and avoiding a duplicat
by testbot＠testbot.winehq.org 03 May '10

03 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1881 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: Minor dlls/localspl/tests/localmon.c simplificiation
by Nikolay Sivov 02 May '10

02 May '10

On 4/23/2010 16:50, Gerald Pfeifer wrote: > In addition to just building this patch as is, I also gave it a spin > changing the if (0) to if (1) to ensure this still builds (it should, > of course, and it does, but...) > > Gerald > > ChangeLog: > Remove variable res which is not really used from test_XcvClosePort. > We should better test for return value than remove it.

2 3

Re: quartz: Properly return E_POINTER when ppFilters is null
by Nikolay Sivov 02 May '10

02 May '10

On 5/3/2010 02:17, Jerome Leclanche wrote: > Fixes bug 22563. Also fix broken indent right below. > > J. Leclanche > Please, add a test for this, it looks trivial to test.

1 0

Re: Minor dlls/comctl32/tests/listview.c simplification
by Nikolay Sivov 02 May '10

02 May '10

On 4/21/2010 21:32, Gerald Pfeifer wrote: > ChangeLog: > Remove variable hwndheader which is not really used from test_items. > > diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c > index 2c5ef70..06f2ddd 100644 > --- a/dlls/comctl32/tests/listview.c > +++ b/dlls/comctl32/tests/listview.c > @@ -1182,7 +1182,7 @@ static void test_items(void) > > static void test_columns(void) > { > - HWND hwnd, hwndheader; > + HWND hwnd; > LVCOLUMN column; > DWORD rc; > INT order[2]; > @@ -1207,7 +1207,6 @@ static void test_columns(void) > > /* LVM_GETCOLUMNORDERARRAY */ > hwnd = create_listview_control(LVS_REPORT); > - hwndheader = subclass_header(hwnd); > > memset(&column, 0, sizeof(column)); > column.mask = LVCF_WIDTH; > Hi, Gerald. You can't do this, subclassing is important thing here. And you will see it if you run a test (that you should do before sending patch actually).

2 1

Re: Francois Gouget : winedbg: Fix compilation with gcc 2. 95 and non-GNU compilers.
by Eric Pouech 02 May '10

02 May '10

Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: 51dfd9adb11885daec878737f18f89fb05c1516c > URL: http://source.winehq.org/git/wine.git/?a=commit;h=51dfd9adb11885daec878737f… > > Author: Francois Gouget <fgouget(a)free.fr> > Date: Sat Mar 27 16:55:27 2010 +0100 > > winedbg: Fix compilation with gcc 2.95 and non-GNU compilers. > François, what was the exact issue here ? I guess that the ; at the end of the attribute definition for GNUCC compiler was missing for the non gnu C compilers ? your fix is wrong as dbg_printf doesn't take a va_list as argument (you'd want dbg_vprintf which doesn't exist) does the attached patch work in your configuration ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams) diff --git a/programs/winedbg/db_disasm64.c b/programs/winedbg/db_disasm64.c index 98f7ef2..88fa0dd 100644 --- a/programs/winedbg/db_disasm64.c +++ b/programs/winedbg/db_disasm64.c @@ -32,24 +32,13 @@ #include <stdio.h> #include "debugger.h" -#ifndef __GNUC__ -#define __attribute__(X) +#ifdef __GNUC__ +static int (*db_printf)(const char* format, ...) __attribute__((format (printf,1,2))); +#else +static int (*db_printf)(const char* format, ...); #endif -static int db_debug = 0; -static int db_printf(const char* format, ...) __attribute__((format (printf,1,2))); -int db_printf(const char* format, ...) -{ - va_list valist; - int len = 0; - if (db_debug) - { - va_start(valist, format); - len = dbg_printf(format, valist); - va_end(valist); - } - return len; -} +static int no_printf(const char* format, ...) {return 0;} typedef DWORD_PTR db_addr_t; typedef BOOL boolean_t; @@ -93,7 +82,7 @@ static ULONG64 db_get_value(db_addr_t addr, int size, int is_signed) static void db_printsym(db_addr_t addr, unsigned unused) { - if (db_debug) + if (db_printf != no_printf) { ADDRESS64 a; @@ -1656,6 +1645,6 @@ db_disasm(db_addr_t loc, boolean_t altfmt) void be_x86_64_disasm_one_insn(ADDRESS64 *addr, int display) { - db_debug = display; + db_printf = display ? dbg_printf : no_printf; addr->Offset = db_disasm(addr->Offset, TRUE); }

2 3

Fullscreen Borderlands at Desktop Resolution
by Erich Hoover 02 May '10

02 May '10

I've been playing the game Borderlands at less than my desktop resolution due to a strange bug and finally decided to try and track it down. The issue is that whenever the resolution of Borderlands is set to the same resolution as the desktop then the game window does not appear in the upper left hand corner and the size of the window is about 1/2 of the display size for both the width and the height. After some exploration, this appears to be two separate issues with the Wine's X11 driver. 1) sync_window_position() will not move an iconified managed window, so the window is never repositioned to the upper left corner. 2) set_size_hints() checks to see if a window is the size of the display (or larger) and does not resize the window if that is the case. Another interesting point is that these issues only occur when using compiz, when using metacity the following warnings are displayed: --- Window manager warning: Window 0x4200005 (Borderland) sets an MWM hint indicating it isn't resizable, but sets min size 1 x 1 and max size 2147483647 x 2147483647; this doesn't make much sense. Window manager warning: Treating resize request of legacy application 0x4200005 (Borderland) as a fullscreen request --- I've attached a patch that overcomes these issues, but I'm suspicious that there are unintended consequences. I would appreciate it if someone could take a look. Erich Hoover ehoover(a)mines.edu

1 0

Re: Remove variable doRecursive which is not really used from WCMD_for.
by Nikolay Sivov 02 May '10

02 May '10

On 5/1/2010 18:24, Gerald Pfeifer wrote: > --- > programs/cmd/builtins.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > Please use consistent naming for patches and mail subjects. It's described in http://wiki.winehq.org/SubmittingPatches. I'm not sure it makes sense to resend all these, but GERALD: as a start word is unacceptable of course.

2 1

Re: Minor dlls/dbghelp/dwarf.c simplification
by Gerald Pfeifer 02 May '10

02 May '10

Eric Pouech wrote: > this is wrong: dwarf_parse family set makes the pointer in the cxt > advance by the size of the object which is being parse You're right. I had, in fact, checked this very question, but doing so just again I see where I missed the += in the code. Thanks for catching this, Eric! > and actually, the correct fix would be to make use of those variables > (like checking if the version is a known one), instead of throwing > things away Are you planning to go into that direction? If not, I'd suggest the patch below. (I'm not sure whether checking for the DWARF version is going to help -- do we want to abort for newer versions when these actually should be compatible?) Gerald From: Gerald Pfeifer <gerald(a)pfeifer.com> Date: Sun, 2 May 2010 22:05:20 Subject: dbghelp: Remove two variables which are not really used in dwarf2_parse_line_numbers. --- dlls/dbghelp/dwarf.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index 4be0f6a..99960d8 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -1920,7 +1920,7 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, { dwarf2_traverse_context_t traverse; unsigned long length; - unsigned version, header_len, insn_size, default_stmt; + unsigned insn_size, default_stmt; unsigned line_range, opcode_base; int line_base; const unsigned char* opcode_len; @@ -1939,8 +1939,8 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, length = dwarf2_parse_u4(&traverse); traverse.end_data = sections[section_line].address + offset + length; - version = dwarf2_parse_u2(&traverse); - header_len = dwarf2_parse_u4(&traverse); + dwarf2_parse_u2(&traverse); + dwarf2_parse_u4(&traverse); insn_size = dwarf2_parse_byte(&traverse); default_stmt = dwarf2_parse_byte(&traverse); line_base = (signed char)dwarf2_parse_byte(&traverse); -- 1.6.6.2

1 0

Unable to start WoW from git 1.1.29 while 1.1.29 tarball works.
by Johann "Myrkraverk" Oskarsson 02 May '10

02 May '10

Hello all. I am unable to start WoW when I compile release 1.1.29 from the git repo, while compiling the 1.1.29 release tarball allows me to play WoW. System info: % uname -a; isainfo -k SunOS asuka 5.11 snv_115 i86pc i386 i86pc amd64 Git compile steps taken: git checkout wine-1.1.29 git clean -x -f ./configure --prefix=/opt/myrkraverk/wine-git && gmake depend && gmake WoW now fails to start with some console output like: [johann@asuka]~/src/external/git/wine/wine% Can't attach process 0011: error 6 wine: Call from 7fd69d43 to unimplemented function user32.dll.UserRegisterWowHandlers, aborting fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for 80000100 err:module:DelayLoadFailureHook failed to delay load user32.dll.LoadStringW More pastes here: http://paste.lisp.org/display/98679 I did not use any special flags or environment variables to compile the tarball, apart from the prefix. This is my showstopper to regression test bug 22033: http://bugs.winehq.org/show_bug.cgi?id=22033 Any help apreciated. Johann

1 1

new wisotool 20100424: new verbs 3dmark2000, 3dmark2001, 3dmark03, 3dmark05, 3dmark06, baldursgate2, gta_vc, pcmark04, pcmark05, unigine_heaven
by Dan Kegel 02 May '10

02 May '10

wisotool is a handy winetricks-like script for automatically installing games from .iso files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except, for now, it prompts for the root password so it can mount the .iso file; later it will use fuse instead). This version is the first to be called a release. Currently supported apps are: 3dmark03 3D Mark 03 (Futuremark, 2003) [download] 3dmark05 3D Mark 05 (Futuremark, 2005) [download] 3dmark06 3D Mark 06 (Futuremark, 2006) [download] 3dmark2000 3DMark2000 (MadOnion.com, 2000) [download] 3dmark2001 3DMark2001 (MadOnion.com, 2001) [download] assassinscreed Assassins Creed (Ubisoft, 2008) baldursgate2 Baldurs Gate 2 - Shadows of Amn (Bioware, 2000) diablo2 Diablo II (Blizzard, 2000) dragonage Dragon Age: Origins (Bioware, 2009) gta_vc Grand Theft Auto: Vice City (Rockstar, 2003) morrowind The Elder Scrolls III: Morrowind (Bethesda, 2002) pcmark04 PC Mark 04 (Futuremark, 2004) [download] pcmark05 PC Mark 05 (Futuremark, 2005) [download] plantsvszombies Plants vs. Zombies (PopCap Games, 2009) [download] quake3 Quake 3 (ID Software, 1999) re5bench Resident Evil 5 Benchmark (Capcom, 2009) [download] sims3 The Sims 3 (EA, 2009) starcraft2 Starcraft II beta (Blizzard, 2010) starcraft Starcraft Battle Chest (Blizzard, 1998) stfu Starwars: The Force Unleashed (Aspyr, 2009) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) [download] wog World of Goo demo (2D Boy, 2008) [download] It's available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/

3 5

3dmark2000, 3dmark06 results on both Wine and Vista
by Dan Kegel 02 May '10

02 May '10

I did some apples-to-apples 3d benchmarking today on a dual boot system. It looks offhand like Windows is about twice as fast as Wine on these benchmarks on my system. cpu: e8400 ram: 4GB video card: nvidia GT 240 Ubuntu 32 10.04 video drivers: 195.36.15 Vista 64 video drivers: 8.17.11.9713 Test procedure: On Ubuntu, grab latest wine from git, apply patch from http://bugs.winehq.org/show_bug.cgi?id=9210 so 3dmark06 will run. On Windows, install cygwin and a few of its packages (cabextract, wget, svn, etc.) Then on both systems do svn checkout http://winezeug.googlecode.com/svn/trunk/ winezeug sh winezeug sh yagmarktest That will run the tests in a loop and save a report for each run in the current directory. Results at http://kegel.com/wine/yagmarkdata/e8400/ Summary: Ubuntu: 6 runs 3dmark2000: min 4145, median 4154, max 4170 3dmark2001: min 18884, median 19261, max 19520 3dmark2006: min 17315, median 18154, max 18498 Vista: 2 runs: 3dmark2000: 8206, 8219 3dmark2006: 30278, 32384 Notes: 1) 3dmark2001 hangs for me on vista 64 bits, so no results for that test on that OS, I had to edit yagmarktest to remove it from the loop. Does it work for anyone else? 2) nvidia drivers occasionally crash X when running or quitting 3dmark2000 or 3dmark06; it's happened to me three times. 3) test script is fragile, don't touch the mouse or keyboard while it's running 4) shadows appear to be missing on wine in firefly forest in 3dmark06 and giant mecha truck test in 3dmark01? 5) format of my log files is ugly and will change.

6 8

Re: Destroy the window we created at the end of wait_idle_thread.
by testbot＠testbot.winehq.org 02 May '10

02 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1857 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: user32: Focus editboxes when the context menu is opened. (try 3)
by Paul Vriens 01 May '10

01 May '10

On 04/24/2010 10:08 PM, Vincent Povirk wrote: > + case WM_CAPTURECHANGED: > + if (hWnd != (HWND)lParam) > + { > + got_wm_capturechanged = 1; > + EndMenu(); > + } > + break; Hi Vincent, EndMenu is not available on Win95 so no user32 tests are run on that platform at the moment. Can we skip just this call to EndMenu on Win95, should we skip this whole new test (test_contextmenu_focus) on Win95 or is there an alternative? -- Cheers, Paul.

2 2

Re: Minor dlls/mshtml/htmlbody.c simplification (RESEND)
by Nikolay Sivov 01 May '10

01 May '10

On 5/1/2010 04:04, Gerald Pfeifer wrote: > On Wed, 28 Apr 2010, Nikolay Sivov wrote: > >> Please follow wine-devel comments: >> >> http://www.winehq.org/pipermail/wine-devel/2010-April/083175.html >> > Ouch, I had missed this message -- certainly did not mean to ignore > the good feedback. > > Is the following what you had in mind? > > Gerald > > > ChangeLog: > Fix return value for HTMLBodyElement_get_text. > > --- > dlls/mshtml/htmlbody.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c > index 5c66e65..65aa549 100644 > --- a/dlls/mshtml/htmlbody.c > +++ b/dlls/mshtml/htmlbody.c > @@ -443,7 +443,7 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > HTMLBodyElement *This = HTMLBODY_THIS(iface); > nsAString text; > nsresult nsres; > - HRESULT hres; > + HRESULT hres = S_OK; > > TRACE("(%p)->(%p)\n", This, p); > > @@ -462,7 +462,7 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > > nsAString_Finish(&text); > > - return S_OK; > + return hres; > } > > static HRESULT WINAPI HTMLBodyElement_put_link(IHTMLBodyElement *iface, VARIANT v) > Yes, but you don't have to initialize it to S_OK.

1 0

Re: [2/4] rsaenh: Fixing a testfailure because Win7 seems to support salt with AES
by Juan Lang 30 Apr '10

30 Apr '10

Hi Andre, I don't object to this patch per se, but: - ok(!result && (GetLastError() == NTE_BAD_KEY || GetLastError() == ERROR_NO_TOKEN /* Win7 */), - "expected NTE_BAD_KEY or ERROR_NO_TOKEN, got %08x\n", GetLastError()); + todo_wine ok(broken(!result && GetLastError() == NTE_BAD_KEY) || result /* Win7 */, + "CryptGetKeyParam failed, got %08x\n", GetLastError()); Why don't you fix rsaenh while you're at it? It'd be an exceedingly easy patch. Look for KP_SALT in rsaenh.c, and you'll see what I mean. --Juan

2 1

South East Linux Fest
by Steven Edwards 30 Apr '10

30 Apr '10

Hi, I'm going to be running a both at the South East Linux Fest in Spartanburg SC June 11th-13th. If any wine hackers or lurkers from the South Eastern United States want to come out and help, drop me a note privately. I can't offer much in accommodation but I'll provide beer. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: (resend) shell32: handle NULL pName in ShellLink fnSetDescription.
by testbot＠testbot.winehq.org 30 Apr '10

30 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1835 Your paranoid android. === WNT4WSSP6 (32 bit shelllink) === shelllink.c:144: Test failed: GetDescription returned 'Some description'

1 0

Bugzilla not updated on server
by Vitaliy Margolen 30 Apr '10

30 Apr '10

Alexandre committed a patch to remove few no longer working links. But the bugzilla on Wine's server still showing those links. Is the bugzilla automatically being pulled from git? Vitaliy.

1 0

Re: Benchmarking D3D?
by Roderick Colenbrander 30 Apr '10

30 Apr '10

On Sun, Apr 18, 2010 at 8:32 PM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > Am 18.04.2010 um 18:33 schrieb Roderick Colenbrander: >> There's not much better than can be done. Some games use the same >> calculation as in Wine while others take into account previous >> results. Here I have adjusted the code to basically: current_fps = >> 0.1*last_fps + 0.9*frames/(current_time - prev_time) and adjusted the >> sample period to 1s. This made the fps a bit more accurate. > My main concern here is separating different parts of the runs. A while ago the ATI developers asked for a fps average for the entire runtime of the app. That is good for their small samples, but if you use this with e.g. HL2 the time it takes to load the game from disk comes into play. > > I'm not saying that benchmarking load times is bad, but you want to separate that from the play benchmark. With the apps I use the game knows when it stops loading and when it starts rendering, which is why I consider the game's results more trustworthy than the +fps channel. > > --snip 1-- > > While we're talking about it, I've brought my "amd64" test box live again, so we should get fresh test results from a GF7600 card. I have a new Linux box with an ATI card, and I've set up the tests there as well, but before I can run them reasonably I have to wait for the next fglrx release to get the FBO crash fixed. > > --snip 2-- > > I am thinking about extending this a bit, and write a wrapper d3d9.dll that can monitor d3d calls, and catch e.g. a shader that signals that the main game rendering has started / stopped, etc. With such a setup we can start thinking about taking screenshots(in a separate run of course) to see if the rendering result is roughly what we expect. If I extend the idea a little, make it slightly less Wine and D3D specific and find a fancy title(e.g. "Quality Assurance in interactive 3D applications") I might get a master's thesis out of it. > > Implementation details aside it would be very useful if a mechanism can take advantage of GPU monitor APIs like the ones from nvidia perfkit and GL_AMD_performance_monitor. This would also allow us to monitor what is holding up the GPU. I have been looking into nvperfkit the past few days. The current Linux version is based on the 173.x drivers (ancient but they would work fine for your geforce 7600). As a workaround I have been experimenting a bit on Windows mostly in the hope to get NVPerfkit running on WineD3D there. In the end WineD3D worked and perfkit also installed (there were some issues for 32-bit apps on Win7) but then it appeared that my GPU is too new yet (it is a GTS 360M), so it doesn't work yet. In case of AMD no special drivers are needed, so perhaps I'll give GL_AMD_performance_monitor a shot but they say that on Linux due to lack of good tools it is a bit hard to use. Roderick

3 3

new wisotool 20100424: new verbs 3dmark2000, 3dmark2001, 3dmark03, 3dmark05, 3dmark06, baldursgate2, gta_vc, pcmark04, pcmark05, unigine_heaven
by wylda＠volny.cz 30 Apr '10

30 Apr '10

> I'm ripping it now, but it's pretty slow, comparatively. Tons of: > Found L-EC error at sector 1589216 - ignored. Good luck and hopefully your DVD drive will survive it ;) After long tests, i choosed (year ago) Alcohol 120% as the ripping tool, because it produced most number of working backup copies and makes them fast. However, if the safedisc image will work most depends on DVD drive. Again from personal test of 5 bought drives Samsung SH-S223F is winner for me. And for loading such image under linux i use http://www.cdemu.org so mounting an image is done by: cdemu load 0 my_image.mds cdemu unload 0 my_image.mds This SW need a kernel module, so it's not easy as other tools, but the reward is, you can SafeDisc/SecuROM working without needing a crack (of course the image have to firstly work under WinXP and wine have to support such protection like SecuROM v7.30.0014). Unfortunately SecuROM v7.27.0014 doen't work in wine, because of "Unsupported ioctl 2d0c04", but bug 20935 Anastasius how to overcome, but i don't know where to put the heck 0. So if wisotool would support "cdemu load", that would be tool even for me ;)

2 1

Re: shell32: add configure option --disable-unixfs
by Alexandre Julliard 29 Apr '10

29 Apr '10

Dan Kegel <dank(a)kegel.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=22450 There's no reason to do that in configure. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32: negate return value of SIOCATMARK (try 2)
by Mike Kaplinskiy 29 Apr '10

29 Apr '10

2010/4/28 André Hentschel <nerv(a)dawncrow.de>: > confirmed by Mike Kaplinskiy > > try 1 was on 4th November 2009 > > --- > dlls/ws2_32/socket.c | 16 ++++++++++++++-- > dlls/ws2_32/tests/sock.c | 2 +- > 2 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index e6a6973..62598d2 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -2800,8 +2800,20 @@ int WINAPI WS_ioctlsocket(SOCKET s, LONG cmd, WS_u_long *argp) > return 0; > > case WS_SIOCATMARK: > - newcmd=SIOCATMARK; > - break; > + fd = get_sock_fd( s, 0, NULL ); > + if (fd != -1) > + { > + if( ioctl(fd, newcmd, (char*)argp ) == 0 ) > + { > + release_sock_fd( s, fd ); > + /* return value must be inverted here */ > + *argp = !*argp; > + return 0; > + } > + SetLastError((errno == EBADF) ? WSAENOTSOCK : wsaErrno()); > + release_sock_fd( s, fd ); > + } > + return SOCKET_ERROR; > > case WS_FIOASYNC: > WARN("Warning: WS1.1 shouldn't be using async I/O\n"); > diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c > index 88b62e3..7a7c688 100644 > --- a/dlls/ws2_32/tests/sock.c > +++ b/dlls/ws2_32/tests/sock.c > @@ -2486,7 +2486,7 @@ static void test_ioctlsocket(void) > > ret = ioctlsocket(sock, SIOCATMARK, &arg); > if(ret != SOCKET_ERROR) > - todo_wine ok(arg, "expected a non-zero value\n"); > + ok(arg, "expected a non-zero value\n"); > } > > static int drain_pause=0; > -- > > Best Regards, André Hentschel > > > > Hey André, I don't think we should rush this. The documentation says that the return values are basically opposites, but I think we need more tests with actual OOB data and different settings of SO_OOBINBLINE. MSDN has far too little information about SIOCATMARK and some things they say don't make a lot of sense. Mike.

2 1

Re: winex11: use XkbKeycodeToKeysym when using XKB
by Alexandre Julliard 29 Apr '10

29 Apr '10

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -609,6 +609,11 @@ extern HMODULE x11drv_module; > extern BYTE key_state_table[256]; > extern POINT cursor_pos; > > +#ifdef HAVE_XKB > +#define XKeycodeToKeysym(dpy,kc,i) \ > + ( use_xkb ? XkbKeycodeToKeysym(dpy, kc, 0, i) : XKeycodeToKeysym(dpy, kc, i) ) > +#endif > + That would make the code very confusing. You should define some explicit inline function instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] mshtml: Added support for accessing select options by index.
by testbot＠testbot.winehq.org 29 Apr '10

29 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1828 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

2 1

Re: [PATCH 1/2] user32: convert screen coordinates for send WM_SIZING message (resend)
by Alexandre Julliard 29 Apr '10

29 Apr '10

Konstantin Kondratyuk <kondratyuk(a)etersoft.ru> writes: > @@ -2575,11 +2576,24 @@ void WINPOS_SysCommandSizeMove( HWND hwnd, WPARAM wParam ) > if(!iconic && !DragFullWindows) draw_moving_frame( hdc, &sizingRect, thickframe ); > capturePoint = pt; > > + /* convert to screen coordinates */ > + if(parent) > + { > + POINT* p = (POINT*) &newRect; > + ClientToScreen( parent, p ); > + ClientToScreen( parent, ++p ); > + converted = TRUE; > + } > + > /* determine the hit location */ > if (hittest >= HTLEFT && hittest <= HTBOTTOMRIGHT) > wpSizingHit = WMSZ_LEFT + (hittest - HTLEFT); > SendMessageW( hwnd, WM_SIZING, wpSizingHit, (LPARAM)&newRect ); > > + /* convert back to client coordinates id needed */ > + if(converted) > + MapWindowPoints( 0, parent, (POINT*)&newRect, 2 ); > + You should be using MapWindowPoints for the first case too, and there's no need for that extra boolean variable. -- Alexandre Julliard julliard(a)winehq.org

1 0

winmm/tests: Silence test about play from 0 to 0 not immediately stopped.
by Joerg-Cyril.Hoehle＠t-systems.com 29 Apr '10

29 Apr '10

Hi, This intermittent failure seems independent on all the other intermittent failures so let's silence it. Experiments with Sleep() were unsuccessful to quiet it. I'm wondering whether it only happens on vmware. Another possible explanation that needs more testing is that it might behave like MCI_CUE: the player starts, does not send a notification (since it's still running) and is waiting for another, "real", command. But then, repeatable behaviour would be expected. Regards, Jörg Höhle

1 0

Re: [1/6] msi: Fix some test failures on Windows.
by testbot＠testbot.winehq.org 29 Apr '10

29 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1817 Your paranoid android. === W7PROX64 (32 bit package) === package.c:7603: Test failed: Expected "C:\winetest\FileName1", got "" package.c:7609: Test failed: Expected "C:\winetest\FileName2", got "" package.c:7615: Test failed: Expected "C:\winetest\FileName3", got "" package.c:7627: Test failed: Expected "C:\winetest\FileName5", got "" package.c:7633: Test failed: Expected "C:\winetest\", got "" package.c:7639: Test failed: Expected "C:\winetest\", got "" package.c:7655: Test failed: Expected "C:\winetest\FileName8.dll", got "" package.c:7666: Test failed: Expected "C:\winetest\FileName10.dll", got "" package.c:11655: Test failed: Expected "{0BE69954-7B96-4254-93F8-567F63E9B7B4}", got "apple" package.c:11682: Test failed: Expected first 3 chars of "{0BE69954-7B96-4254-93F8-567F63E9B7B4}", got "apple" package.c:11692: Test failed: Expected first 37 chars of "{0BE69954-7B96-4254-93F8-567F63E9B7B4}", got "apple" package.c:11702: Test failed: Expected "{0BE69954-7B96-4254-93F8-567F63E9B7B4}", got "apple" package.c:11734: Test failed: Expected "{0BE69954-7B96-4254-93F8-567F63E9B7B4}", got "apple" === W7PROX64 (64 bit package) === package.c:8212: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8223: Test failed: Expected "C:\winetest\", got "" package.c:8234: Test failed: Expected "C:\winetest\", got "" package.c:8284: Test failed: Expected "C:\winetest\FileName3.dll", got "" package.c:8295: Test failed: Expected "C:\winetest\FileName5.dll", got "" package.c:8304: Test failed: Expected "C:\", got "" package.c:8310: Test failed: Expected "C:\winetest\", got "" package.c:8331: Test failed: Expected "C:\winetest\FileName1", got "" package.c:8340: Test failed: Expected "C:\winetest\FileName1", got ""

1 0

Re: [PATCH] kernel32: lstrlen does not call SetLastError.
by testbot＠testbot.winehq.org 29 Apr '10

29 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1815 Your paranoid android. === W98SE (32 bit string) === string.c:41: Test failed: Expected 0xdeadbeef, got 0x00000057 string.c:47: Test failed: Expected 0xdeadbeef, got 0x00000057 string.c:53: Test failed: Expected 0xdeadbeef, got 0x00000057 string.c:59: Test failed: Expected 0xdeadbeef, got 0x00000057

2 1

New SCSI Driver for Mac OS X
by Charles Davis 29 Apr '10

29 Apr '10

Hi, A while ago on this list, I was talking about implementing SCSI support on Mac OS X in Wine, and we all agreed the best way to do that would be to have a custom driver that provides an IOCTL interface. I've attached the driver (which is now finished) here. I've tested it on my system, and it works with this small test program that's also attached. But I want to make sure it's totally stable before I start working on the Wine side. So if you've got a Mac, and you're feeling brave, feel free to install my driver and run my test program. Extract the archive, then cd to the directory inside: tar jxf ExtMediaBSDClient.tar.bz2 cd ExtMediaBSDClient Install the extension to /Library/Extensions: cp -r ExtMediaBSDClient.kext /Library/Extensions If you're feeling really brave, you can install it to /System/Library/Extensions (and then it will be loaded on boot): cp -r ExtMediaBSDClient.kext /System/Library/Extensions The driver bundle has to be owned by root and belong to the wheel group, so make sure it does before trying to load it: sudo chown -R root:wheel /path/to/ExtMediaBSDClient.kext You can load the driver with the kextload command: kextload /path/to/ExtMediaBSDClient.kext You can verify that the driver loaded by running: kextstat | grep "ExtMediaBSDClient" Once it's loaded, all SCSI disks that are inserted afterward will accept the IOCTL. All disks that were inserted before won't however. To make sure a disk is using my driver, run the ioreg tool (it's part of Xcode) and look for "ExtMediaBSDClient": ioreg | grep "ExtMediaBSDClient" To test it, run the program 'ExtMediaTest' that I included. Pass it the filename of a device file for the disk (it should be one of the raw device files, e.g. /dev/rdisk1 instead of /dev/disk1) on which you want to test this: ./ExtMediaTest /path/to/device/file If it works, the program will print some of the INQUIRY data for that disk to the Terminal. If it doesn't work, it will print an error to the Terminal (and the driver will have logged something in the kernel log; see the Console app), or worse, the kernel will panic. (If it says "Inappropriate ioctl for device", that probably means it's not using my driver. Try ejecting the disk and reinserting it. And if it says the device is busy, try the program on one of the slices, e.g. /dev/rdisk1s1 instead of /dev/rdisk1.) If anything goes wrong (error messages, kernel panics, etc.), I want to know about it. If you get an error, paste the whole error message. If it's from ExtMediaTest, show me the lines in the kernel log that came from the driver (they have "ExtMediaBSDClient" or some such in them). If the kernel panics, attach the panic log. Also, tell me which version of Mac OS X you're using (so I know which KernelDebugKit to use). As soon as I verify that the driver works well, I'm going to start submitting patches to implement support for it in Wine. Chip

4 13

X11 keyboard detection bitrot on Linux?
by Joerg-Cyril.Hoehle＠t-systems.com 28 Apr '10

28 Apr '10

Hi, Perhaps there's some bitrot that affects the handling of alt/altGr keys on Linux? Using WINEDEBUG=+keyboard on Macos yields exepected results. The 3rd and 4th characters (|\ etc.) below show what's obtained when pressing the alt key: trace:key:X11DRV_KEYBOARD_DetectLayout mismatch for keycode 34, got 7/|\ trace:key:X11DRV_KEYBOARD_DetectLayout mismatch for keycode 36, got 8({ trace:key:X11DRV_KEYBOARD_DetectLayout mismatch for keycode 58, got <>?? trace:key:X11DRV_KEYBOARD_DetectLayout mismatch for keycode 73, got ,,.. On Linux instead: warn:keyboard:X11DRV_KEYBOARD_DetectLayout 7 keysyms per keycode not supported, set to 4 trace:key:X11DRV_KEYBOARD_DetectLayout mismatch for keycode 16, got 7/7/ trace:key:X11DRV_KEYBOARD_DetectLayout mismatch for keycode 17, got 8(8( None of the {[]}\ keys reached via AltGr-7/8/9/0 on the German keyboard is printed by the keyboard detection code. This causes warnings for all keyboards (not printed by default) because none matches, which presumably was not the case back when that code was written. What has changed? Regards, Jörg Höhle

3 2

Re: [PATCH 3/4] wined3d: fix texm3x3spec coordinate mask bug
by Henri Verbeet 28 Apr '10

28 Apr '10

On 28 April 2010 14:29, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch fixes an issue in "King's Bounty: The Legend" for which a shader of the form: > 'texture2D(sampler2D, tmp0.xyz)' was generated. The nvidia GLSL compiler wants to have tmp0.xyz. We talked about this on IRC yesterday, the reason this happens is that the sampler type is wrong.

2 2

Re: kernel32: Add tests for lstrcmpW (try 3)
by Dmitry Timoshkov 28 Apr '10

28 Apr '10

André Hentschel <nerv(a)dawncrow.de> wrote: > + for (r = 0; r < 0xFFFF; r++) > + { > + if (ignorewchar(r)) > + { > + markerW[2] = r; > + todo_wine > + { > + ok(!lstrcmpW(markerW, nomarkerW), "expected the character 0x%x to be ignored within the string\n", r); > + ok(CompareStringW(LOCALE_SYSTEM_DEFAULT, 0, markerW, -1, nomarkerW, -1) == 2, > + "expected the character 0x%x to be ignored within the string\n", r); > + ok(CompareStringW(LOCALE_SYSTEM_DEFAULT, NORM_IGNORECASE|NORM_IGNORENONSPACE|NORM_IGNORESYMBOLS| > + SORT_STRINGSORT|NORM_IGNOREKANATYPE|NORM_IGNOREWIDTH|LOCALE_USE_CP_ACP, > + markerW, -1, nomarkerW, -1) == 2, > + "expected the character 0x%x to be ignored within the string\n", r); > + } > + } > + } This is not better, my comments for your previous attempts still apply. In addition to those: 1. if you decided to use some specific flags in the CompareString call, you may want to test other variants of them. Using LOCALE_USE_CP_ACP in a W version of the API doesn't look useful. 2. return value of CompareString has symblic names. -- Dmitry.

1 0

Re: [PATCH 1/4] wined3d: fix flip_surface flag copying bug
by Roderick Colenbrander 28 Apr '10

28 Apr '10

Ignore patch 1/4 and 2/4 for now. I missed a reply from Henri to the bug report. Roderick On Wed, Apr 28, 2010 at 2:29 PM, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch fixes a part of bug 22356. The issue is that Jedi Knight performs a full surface copy > from the back to the front buffer which in the end uses flip_surface. flip_surface swaps > the surface flags which causes an issue in this case because only one of the buffers > ever had SFLAG_CONVERTED set. This means that SFLAG_CONVERTED is set for the odd frame > and unset for the even frame. > --- > dlls/wined3d/surface.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index fcdfec8..d14dbd0 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -2917,10 +2917,13 @@ void flip_surface(IWineD3DSurfaceImpl *front, IWineD3DSurfaceImpl *back) { > front->texture_name_srgb = tmp; > } > > + /* Copy location flags */ > { > DWORD tmp_flags = back->Flags; > - back->Flags = front->Flags; > - front->Flags = tmp_flags; > + back->Flags &= ~SFLAG_LOCATIONS; > + back->Flags |= front->Flags & SFLAG_LOCATIONS; > + front->Flags &= ~SFLAG_LOCATIONS; > + front->Flags |= tmp_flags & SFLAG_LOCATIONS; > } > } > > -- > 1.6.3.3 > >

1 0

Re: Minor dlls/mshtml/htmlbody.c simplification (RESEND)
by Nikolay Sivov 28 Apr '10

28 Apr '10

On 4/28/2010 14:02, Gerald Pfeifer wrote: > ChangeLog: > Remove variable hres which is not really used from HTMLBodyElement_get_text. > > diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c > index 5c66e65..c6b202b 100644 > --- a/dlls/mshtml/htmlbody.c > +++ b/dlls/mshtml/htmlbody.c > @@ -443,7 +443,6 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > HTMLBodyElement *This = HTMLBODY_THIS(iface); > nsAString text; > nsresult nsres; > - HRESULT hres; > > TRACE("(%p)->(%p)\n", This, p); > > @@ -454,10 +453,8 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > > nsAString_GetData(&text,&color); > V_VT(p) = VT_BSTR; > - hres = nscolor_to_str(color,&V_BSTR(p)); > }else { > ERR("GetText failed: %08x\n", nsres); > - hres = E_FAIL; > } > > nsAString_Finish(&text); > Please follow wine-devel comments: http://www.winehq.org/pipermail/wine-devel/2010-April/083175.html

1 0

bt all broken?
by Dan Kegel 28 Apr '10

28 Apr '10

winedbg's bt all seems broken since sometime between 1.1.40 and now. Has anybody else seen this?

3 4

RE: user32: Fix some tests on 2K8R2 and win7
by Greg Geldorp 27 Apr '10

27 Apr '10

> From: André Hentschel > > Yepp, the bot doesnt compare results with an unpatched state... Actually, it does. It compares the results of patch jobs against the most recent winetest.exe job for the same VM, which in this case would be https://testbot.winehq.org/JobDetails.pl?Key=1749. That job didn't list any failures for the user32:win.c test, which is why the failures produced by the patch are listed as new failures. Of course, it is still possible that this is a false positive, we've seen more differences between individual test runs and winetest.exe runs. BTW, the bot now reports test results back to Alexandre's patch tracker at http://source.winehq.org/patches Ge.

1 0

Re: user32: Fix some tests on 2K8R2 and win7
by testbot＠testbot.winehq.org 27 Apr '10

27 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1768 Your paranoid android. === W98SE (32 bit win) === win.c:2929: Test failed: hwnd 000004C4 message 0112 win.c:2931: Test failed: message 0112 available win.c:2938: Test failed: hwnd 000004C4 message 0100 win.c:2940: Test failed: message 0100 available win.c:2952: Test failed: message 000f available win.c:2964: Test failed: message 000f available win.c:2973: Test failed: message 000f available win.c:2982: Test failed: message 000f available

2 1

Re: Slackware download description line updated to latest package binary format
by Jeremy Newman 27 Apr '10

27 Apr '10

This patch does not apply against the current git tree. Please always submit patches using "git format-patch". Also, it helps if you prefix the subject with [website] so I can tell which patches are meant for the website without scanning the body. -Newman Ing. Simone. Giustetti wrote: > Hi all, > > The download page description for Slackware was updated because someone pointed > to me it was not clear if the new txz package format was supported or not. > The attached patch contains the updated line for the template in 3 languages. > > Bye > Simone > > > > ------------------------------------------------------------------------ > >

1 0

Re: [3/5] msi/tests: Use a unique product code when testing MsiConfigureFeature parameter validation.
by testbot＠testbot.winehq.org 27 Apr '10

27 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1761 Your paranoid android. === W7PROX64 (32 bit msi) === msi.c:1596: Test failed: Expected C:\imapath, got <à( msi.c:1615: Test failed: Expected C:\imapath, got <à( msi.c:1624: Test failed: Expected C:\imapath, got <à( msi.c:1657: Test failed: Expected C:\imapath, got <à( msi.c:1676: Test failed: Expected C:\imapath, got <à( msi.c:1685: Test failed: Expected C:\imapath, got <à( msi.c:1733: Test failed: Expected C:\imapath, got <à( msi.c:1752: Test failed: Expected C:\imapath, got <à( msi.c:1761: Test failed: Expected C:\imapath, got <à( msi.c:1808: Test failed: Expected C:\imapath, got <à( msi.c:1817: Test failed: Expected C:\imapath, got <à( msi.c:1859: Test failed: Expected C:\imapath, got <à( msi.c:1868: Test failed: Expected C:\imapath, got <à( msi.c:1965: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:1983: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:1998: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:2013: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:2031: Test failed: Expected {62D87153-CBAE-4699-86D4-C37EEE2A9901}, got prod msi.c:2060: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:2078: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:2093: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:2108: Test failed: Expected {8BA3F294-2904-42D3-B780-7C569244693E}, got prod msi.c:2126: Test failed: Expected {62D87153-CBAE-4699-86D4-C37EEE2A9901}, got prod msi.c:2207: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD}, got msi.c:2213: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD}, got msi.c:2237: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or {4DF189B9-4720-46F4-B870-D7B6B32A204E}, got msi.c:2244: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or {4DF189B9-4720-46F4-B870-D7B6B32A204E}, got msi.c:2278: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD}, got msi.c:2307: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or {4DF189B9-4720-46F4-B870-D7B6B32A204E}, got msi.c:2314: Test failed: Expected {B8311ECD-C0EF-4937-81A1-73E7A63065CD} or {4DF189B9-4720-46F4-B870-D7B6B32A204E}, got msi.c:7303: Test failed: Expected "{805BDA38-C6AE-424D-8178-45836DB8D4D3}", got "C:\winetest\\winetest.msi" msi.c:7372: Test failed: Expected "{805BDA38-C6AE-424D-8178-45836DB8D4D3}", got "C:\winetest\\winetest.msi" msi.c:7439: Test failed: Expected "{805BDA38-C6AE-424D-8178-45836DB8D4D3}", got "C:\winetest\\winetest.msi" msi.c:7663: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7665: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7724: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7742: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7760: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7762: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7778: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7780: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7797: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7799: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7818: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7820: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7837: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7839: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7955: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:7957: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:8002: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:8004: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:8028: Test failed: Expected "{74818EE1-8A72-4B5E-BD11-2628E1090FDC}", got "apple" msi.c:8030: Test failed: Expected "{7ED2C8EE-9E50-42A4-BEDF-E42E1AA119E2}", got "banana" msi.c:7663: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7665: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7724: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7742: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7760: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7762: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7778: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7780: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7797: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7799: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7818: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7820: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7837: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7839: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7955: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:7957: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:8002: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:8004: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:8028: Test failed: Expected "{44750609-7030-4563-A080-485647446DEE}", got "apple" msi.c:8030: Test failed: Expected "{BAC6C3BA-B9D7-4696-BDDE-9A4176BC56A2}", got "banana" msi.c:7663: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7665: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:7724: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:7742: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7760: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7762: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:7778: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7780: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:7797: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7799: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:7818: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7820: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:7837: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7839: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:7955: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:7957: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:8002: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:8004: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:8028: Test failed: Expected "{CCF1B2FF-D172-488B-8D4B-E39DF415EC05}", got "apple" msi.c:8030: Test failed: Expected "{D10217FC-E007-454E-A664-ABB810B6A9D4}", got "banana" msi.c:8281: Test failed: Expected "{372082F7-058A-409C-905E-2169F35495CA}", got "apple" msi.c:8283: Test failed: Expected "{7AC4AF3E-8A34-43A2-943A-3C047E041E35}", got "banana" msi.c:8403: Test failed: Expected "{372082F7-058A-409C-905E-2169F35495CA}", got "apple" msi.c:8405: Test failed: Expected "{7AC4AF3E-8A34-43A2-943A-3C047E041E35}", got "banana" msi.c:8450: Test failed: Expected "{372082F7-058A-409C-905E-2169F35495CA}", got "apple" msi.c:8452: Test failed: Expected "{7AC4AF3E-8A34-43A2-943A-3C047E041E35}", got "banana" msi.c:8476: Test failed: Expected "{372082F7-058A-409C-905E-2169F35495CA}", got "apple" msi.c:8478: Test failed: Expected "{7AC4AF3E-8A34-43A2-943A-3C047E041E35}", got "banana" msi.c:8281: Test failed: Expected "{1269E876-F059-41C5-8D5D-B9E636E6833E}", got "apple" msi.c:8283: Test failed: Expected "{965A5D65-6BC6-4AC6-B106-342368801CD1}", got "banana" msi.c:8403: Test failed: Expected "{1269E876-F059-41C5-8D5D-B9E636E6833E}", got "apple" msi.c:8405: Test failed: Expected "{965A5D65-6BC6-4AC6-B106-342368801CD1}", got "banana" msi.c:8450: Test failed: Expected "{1269E876-F059-41C5-8D5D-B9E636E6833E}", got "apple" msi.c:8452: Test failed: Expected "{965A5D65-6BC6-4AC6-B106-342368801CD1}", got "banana" msi.c:8476: Test failed: Expected "{1269E876-F059-41C5-8D5D-B9E636E6833E}", got "apple" msi.c:8478: Test failed: Expected "{965A5D65-6BC6-4AC6-B106-342368801CD1}", got "banana" msi.c:8773: Test failed: Expected patchcode to be unchanged, got {8B602740-836D-4D2F-9A48-0A77827D8057} msi.c:8775: Test failed: Expected targetprod to be unchanged, got {676CA140-B885-480C-89F7-254D1A7BDED6} msi.c:8844: Test failed: Expected "{8B602740-836D-4D2F-9A48-0A77827D8057}", got "apple" msi.c:8846: Test failed: Expected "{676CA140-B885-480C-89F7-254D1A7BDED6}", got "banana" msi.c:8889: Test failed: Expected "{8B602740-836D-4D2F-9A48-0A77827D8057}", got "apple" msi.c:8891: Test failed: Expected "{676CA140-B885-480C-89F7-254D1A7BDED6}", got "banana" msi.c:9435: Test failed: Expected "{C450F244-0D1A-4A58-840B-E3612F065798}", got "apple" msi.c:9478: Test failed: Expected "{C450F244-0D1A-4A58-840B-E3612F065798}", got "apple" msi.c:9655: Test failed: Expected "{C450F244-0D1A-4A58-840B-E3612F065798}", got "apple"

1 0

Re: [1/5] msi/tests: Return INVALID_FILE_SIZE from get_pf_file_size if the file can't be opened.
by testbot＠testbot.winehq.org 27 Apr '10

27 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1760 Your paranoid android. === W7PROX64 (32 bit install) === install.c:5279: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5298: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5323: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5342: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" === W7PROX64 (64 bit install) === install.c:8132: Test failed: RegQueryValueExA failed 2 (0) install.c:8855: Test failed: file not created install.c:8856: Test failed: file not created install.c:8858: Test failed: file not created install.c:8864: Test failed: file removed install.c:8869: Test failed: directory removed install.c:8916: Test failed: key not removed install.c:8926: Test failed: key not removed install.c:8937: Test failed: key not removed install.c:9011: Test failed: got 6 expected 0 install.c:9017: Test failed: got 6 expected 0 install.c:9020: Test failed: got 6 expected 0 install.c:9022: Test failed: file removed install.c:9167: Test failed: key not created === W7PROX64 (64 bit patch) === patch.c:698: Test failed: expected 1000, got 4294967295 patch.c:711: Test failed: expected 1002, got 4294967295

1 0

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"
by testbot＠testbot.winehq.org 27 Apr '10

27 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1753 Your paranoid android. === W98SE (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] === WNT4WSSP6 (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)]

3 2

Re: [7/9] msi: Implement the UnregisterMIMEInfo standard action.
by Vincent Pelletier 27 Apr '10

27 Apr '10

Le vendredi 02 avril 2010 10:40:07, Hans Leidekker a écrit : > + MSI_RecordSetStringW( uirow, 2, mime->Extension->Extension ); I have a segfault on this line when executing GOG.com embedded Adobe Reader installer (as of duke_nukem_manhattan_project.exe, SHA1SUM 98e6056472368867d302f5dc00c6a317de96e713 at least): wine: Unhandled page fault on read access to 0x00000008 at address 0x7ecf3750 (thread 0042), starting debugger... Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x7ecf3750). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ecf3750 ESP:0033f8e0 EBP:0033f938 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:7ed72e80 ECX:00000000 EDX:00000000 ESI:005630d8 EDI:00563028 Stack dump: 0x0033f8e0: 00000002 7ed7f4f8 7ed5dfc6 7ed5ddeb 0x0033f8f0: 00000000 f76df7e1 7ed2e89b 7ed72e80 0x0033f900: 00131f00 0055eae0 7ed5ddeb 7ed5dfc6 0x0033f910: 7ed5dfa0 00563370 7ed5df60 00131f60 0x0033f920: 7ed7f4b8 7ed7f4b8 7ecf34fb 7ed72e80 0x0033f930: 00522dc0 00000044 0033f998 7ecda25e Backtrace: =>0 0x7ecf3750 ACTION_UnregisterMIMEInfo+0x260(package=0x131f00) [/home/vincent/git/wine/dlls/msi/classes.c:1516] in msi (0x0033f998) 1 0x7ecda25e ACTION_HandleStandardAction+0x1dd(package=<is not available>, action="UnregisterMIMEInfo", rc=0x33f9cc, force=0x0001) [/home/vincent/git/wine/dlls/msi/action.c:7089] in msi (0x0033f9e8) Note: of-by-one line count, as I added a WARN to log mime->Extension value, which confirms the problem (3rd line): warn:msi:ACTION_UnregisterMIMEInfo Unregistering MIME type L"application/pdf" warn:msi:ACTION_UnregisterMIMEInfo Failed to delete MIME key 2 warn:msi:ACTION_UnregisterMIMEInfo mime->Extension = (nil) I believe the mime->InstallMe condition is too relaxed, as it does check mime- >Extension, but with || (reindented code, for wordwrap): > + mime->InstallMe = (mime->InstallMe || > + (mime->Class && mime->Class->Installed) || > + (mime->Extension && mime->Extension->Installed)); Regards, -- Vincent Pelletier

2 1

Re: [PATCH] Remove variable dbgtext which is not really used frommake_number.
by James McKenzie 27 Apr '10

27 Apr '10

Gerald Pfeifer wrote: > >From 722b0215c6e767d516844bdd492b479831f98557 Mon Sep 17 00:00:00 2001 > From: Gerald Pfeifer <gerald(a)pfeifer.com> > Date: Sat, 24 Apr 2010 12:13:33 +0200 > > > Gerald: Could you help us who are trying to match up what has changed by putting the module name in braces like this: [riched20] somewhere in the title? Thank you. James McKenzie

2 1

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"
by testbot＠testbot.winehq.org 27 Apr '10

27 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1754 Your paranoid android. === W98SE (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] === WNT4WSSP6 (32 bit dib) === dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 227, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 103, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 61, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 33, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=false, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)] dib.c:159: Test failed: Bitmap data not matching. [bTopDown=true, StretchDIBits(hMemDC, 0, 0, 663, 459, 0, 0, 663, 459, pBitmapData, &bmi, DIB_RGB_COLORS, SRCCOPY)]

1 0

Re: [PATCH 4/5] wgl: improve wglDeleteContext threading behavior
by Roderick Colenbrander 26 Apr '10

26 Apr '10

You caught me! I guess Ge will kill me. Roderick On Mon, Apr 26, 2010 at 9:05 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On 04/26/2010 08:29 PM, Roderick Colenbrander wrote: >> >> This is actually patch 1/2 and the other 2/2. I should submit patches >> in another way next time (either use --annotate, or edit them or >> whatever). >> >> Roderick >> >> > > It's a good way to bypass the testbot though ;) > > -- > Cheers, > > Paul. >

1 0

Google Summer of Code 2010: Let the bonding begin!
by Austin English 26 Apr '10

26 Apr '10

Howdy all, Wine has 5 Summer of Code students this year: Alexander Soernes, Improving Wine's Internet Explorer GUI, mentored by Maarten Lankhorst David Hedberg, Implementing IExplorerBrowser, mentored by Eric Durbin Mariusz Plucinski, Implementation of Windows Game Explorer equivalent, mentored by Vincent Povirk Thomas Mullaly, Implementing the IUri interface, mentored by Jacek Caban Wilbert Ho, Wine cmd improvements, mentored by Maarten Lankhorst Welcome students, and best of luck coding on Wine! For more details, see: http://socghop.appspot.com/gsoc/org/home/google/gsoc2010/wine -- -Austin

1 0

Re: [PATCH 4/5] wgl: improve wglDeleteContext threading behavior
by Roderick Colenbrander 26 Apr '10

26 Apr '10

This is actually patch 1/2 and the other 2/2. I should submit patches in another way next time (either use --annotate, or edit them or whatever). Roderick

1 0

Re: [PATCH] msvcr80,msvcr90: sync exports to msvcrt
by Alexandre Julliard 26 Apr '10

26 Apr '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -55,8 +55,8 @@ > @ cdecl ?_set_se_translator@@YAP6AXIPAU_EXCEPTION_POINTERS@@@ZP6AXI0@Z@Z(ptr) msvcrt.?_set_se_translator@@YAP6AXIPAU_EXCEPTION_POINTERS@@@ZP6AXI0@Z@Z > @ cdecl ?_sopen@@YAHPBDHHH@Z(str long long long) msvcrt._sopen > @ stub ?_type_info_dtor_internal_method@type_info@@QAEXXZ > -@ cdecl ?_wopen@@YAHPB_WHH@Z(wstr long long) msvcrt._wopen > -@ cdecl ?_wsopen@@YAHPB_WHHH@Z(wstr long long long) msvcrt._wsopen > +@ varargs ?_wopen@@YAHPB_WHH@Z(wstr long long) msvcrt._wopen > +@ varargs ?_wsopen@@YAHPB_WHHH@Z(wstr long long long) msvcrt._wsopen Not that it makes a lot of difference, but these are actually cdecl, not varargs. -- Alexandre Julliard julliard(a)winehq.org

1 0

kernel32: First try on creating a framework for DOS testing
by Morten Rønne 26 Apr '10

26 Apr '10

Hi Since nobody at the moment can point to any other way of testing DOS, I have chosen to continue with the assembler path. Included is my first try at creating a 32 bit program which can run a 16 bit program (as .com file) written in assembler. Notes about about the changes: I have changed configure.ac to look for nasm (the compiler I have chosen to use). If no nasm is found, a notice is output saying what you wont get. I have changed Make.rules.in to include .asm and .com suffixes so the auto rules work. I have added rules to Makefile.in in dlls/kernel32/tests/Makefile.in to compile the assembler. The code is not compiled automatically for now. You need to do make asm in the test directory. The test program will silently ignore missing programs, so if no compiled programs exists, no tests is run. All in all this change should make no change for people that doesn't have nasm installed. I have added one simple assembler program which test some basic parts of int 21h. Things that are missing: The program can't at the moment show unexpected succes in any test. The test will simply pass as working, instead of todo. How does it work: The .com program is expected to output a file called test.rep. The first letter of the line, tells the outcome of the test: w - Working t - Todo e - Error (It should have worked but failed, regression failure) The rest of line is any message that will be output in case of failure. Limitations: Since the test program doesn't run the tests directly line numbers from the test program is quite useless. I don't know how Martin (wine-testbot) will have it with these changes. I haven't completely figured out how a cross test is done from the wine enviroment, so things needed for windows might be missing. I only have an Windows XP, so that is all that has been tested with the program (direct run, not using test framework). This will fail on other platforms until I get all known versions number added to the list of known versions. Since this is a first try, and Dmitry thinks that it is the wrong direction, I prefer to post it to wine-devel to get some initial comments on this. BR Morten Rønne >From c2b8d7a1ce56247f5379348a1aa2dae4313cc70b Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Morten=20R=C3=B8nne?= <morten.roenne(a)tdcadsl.dk> Date: Mon, 26 Apr 2010 10:25:23 +0200 Subject: Added a DOS test to kernel32 based on assembler code. --- dlls/kernel32/tests/dosasm.c | 129 +++++ dlls/kernel32/tests/int21.asm | 1069 +++++++++++++++++++++++++++++++++++++++ dlls/kernel32/tests/rep_dat.inc | 4 + dlls/kernel32/tests/report.inc | 48 ++ 4 files changed, 1250 insertions(+), 0 deletions(-) create mode 100644 dlls/kernel32/tests/dosasm.c create mode 100644 dlls/kernel32/tests/int21.asm create mode 100644 dlls/kernel32/tests/rep_dat.inc create mode 100644 dlls/kernel32/tests/report.inc diff --git a/dlls/kernel32/tests/dosasm.c b/dlls/kernel32/tests/dosasm.c new file mode 100644 index 0000000..5b1e7f0 --- /dev/null +++ b/dlls/kernel32/tests/dosasm.c @@ -0,0 +1,129 @@ +/* + * Copyright 2010 Morten Rønne + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "wine/test.h" +#include <winbase.h> + +static DWORD pos, end; +char buffer[8192]; + +static int read_line (HANDLE *file, char *text) +{ + DWORD o; + + o = 0; + if(pos == end) { + ReadFile(file, buffer, 8192, &end, NULL); + pos = 0; + } + while(pos < end) { + switch(buffer[pos]) { + case '\n': + text[o++] = '\n'; + text[o++] = '\0'; + pos++; + return 1; + case '\r': break; + default: + if(o < 510) + text[o++] = buffer[pos]; + } + pos++; + if(pos == end) { + ReadFile(file, buffer, 8192, &end, NULL); + pos = 0; + } + } + return 0; +} + +static int read_test_file(char *name) { + HANDLE file; + char line[512]; + + file = CreateFileA("test.rep", GENERIC_READ, 0, NULL, OPEN_EXISTING, + FILE_ATTRIBUTE_NORMAL, NULL); + ok(file != INVALID_HANDLE_VALUE, "CreateFile failed for test.rep: %08x\n", + GetLastError()); + if(file == INVALID_HANDLE_VALUE) + return 0; + + pos = 0; + end = 0; + + /* Read each line and make report */ + while(read_line(file, line)) { + if(line[1] == ':' && line[2] == ' ') { + switch(line[0]) { + case 't': + todo_wine { + ok(FALSE, "%s: %s", name, &line[3]); + } + break; + case 'w': + ok(TRUE, "%s: %s", name, &line[3]); + break; + default: + ok(FALSE, "%s: %s", name, &line[3]); + } + } + } + + CloseHandle(file); + return 1; +} + +static int run_program(LPSTR name) +{ + STARTUPINFOA si; + PROCESS_INFORMATION pi; + + /* The file is not found, then tests are not run, so we return TRUE */ + if(GetFileAttributes(name) == INVALID_FILE_ATTRIBUTES) + return TRUE; + memset(&si, 0, sizeof(si)); + si.cb = sizeof(si); + if (CreateProcessA(NULL, name, NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi)) + { + /* Wait for the process to finish */ + WaitForSingleObject( pi.hProcess, INFINITE ); + CloseHandle(pi.hThread); + CloseHandle(pi.hProcess); + if(read_test_file(name)) + return TRUE; + } + return FALSE; +} + + +START_TEST(dosasm) +{ + /* + * We are testing DOS functions which requires 16 bit mode. + * But this program runs in 32 bit mode. + * So we load a 16 bit test program to do the actual testing. + * After that reports are gathered and tested based on file created + * by the run program. + * So to affect todo's, change the 16 bit program not this. + */ + + /* First test int 21 which are required by all the others */ + ok(run_program((LPSTR)"int21.com") == TRUE, + "Failed to run int 21 tests. Last Error: 0x%04x", GetLastError()); +} + diff --git a/dlls/kernel32/tests/int21.asm b/dlls/kernel32/tests/int21.asm new file mode 100644 index 0000000..57450b6 --- /dev/null +++ b/dlls/kernel32/tests/int21.asm @@ -0,0 +1,1069 @@ +; +; Copyright 2010 Morten Rønne +; +; This library is free software; you can redistribute it and/or +; modify it under the terms of the GNU Lesser General Public +; License as published by the Free Software Foundation; either +; version 2.1 of the License, or (at your option) any later version. +; +; This library is distributed in the hope that it will be useful, +; but WITHOUT ANY WARRANTY; without even the implied warranty of +; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +; Lesser General Public License for more details. +; +; You should have received a copy of the GNU Lesser General Public +; License along with this library; if not, write to the Free Software +; Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + +; +; Test of selected int21 functions +; +; File open/write/close functions are expected to work in order +; to write the report file. +; But more extensive tests will be done. +; + +section .text + org 100h; + +_start: + + call open_report + + call test_version_number + + call test_stdin + + call test_curr_drive + + call test_free_spc + + call test_sys_time + + ;call test_country + + call test_mem_alloc + + ;=============================================================== + ; + ; Test file FCB functions + ; Should we do this? + ; Also Get/Set Disk Transfer Area + ; + ;=============================================================== + + ;=============================================================== + ; + ; Get/Set interrupt vector + ; + ;=============================================================== + + ; 25/35 + + ;=============================================================== + ; + ; Create New program segment prefix + ; + ;=============================================================== + + ; 26h, DX = segment at which to create PSP + + + ;=============================================================== + ; + ; Close report file + ; + ;=============================================================== + + call close_report + + ; Exit the program + + mov ax,4C00h + int 21h + retn + + ;=============================================================== + ; + ; Test version number + ; + ;=============================================================== + +test_version_number: + + ; Get version number + mov ax,3000h + int 21h + + ; AL = Major, AH = Minor, BH = flag, BL:CX = Serial number + or bl,bl + jnz .ser_err + or cx,cx + jnz .ser_err + mov byte [serial_err_str],'w' +.ser_err: + push ax + mov dx,serial_err_str + mov cx,serial_err_len + call report + pop ax + +check_version: + mov bp,known_versions +.loop: + mov dx,[bp] + add bp,2 + cmp dx,0 + jz .version_error + + cmp ax,dx + jz .dos_version_ok + jmp .loop + +.dos_version_ok: + mov byte [version_err_str],'w' + +.version_error: + mov di,version_output + call ax_as_hex + + mov dx,version_err_str + mov cx,version_err_len + call report + +test_oem: + ; Get OEM version number + mov ax,3001h + int 21h + +.check_version: + mov bp,known_oem_versions +.loop: + mov dx,[bp] + add bp,2 + cmp dx,0 + jz .version_error + + cmp ax,dx + jz .oem_version_ok + jmp .loop + +.oem_version_ok: + mov byte [vers_oem_err_str],'w' + +.version_error: + mov di,vers_oem_err_out + call ax_as_hex + + mov dx,vers_oem_err_str + mov cx,vers_oem_err_len + call report + retn + + ;=============================================================== + ; + ; Test system date/time + ; + ;=============================================================== + +test_sys_time: + mov cx,0ffffh + mov dx,0ffffh + mov al,0ffh + + ; Get system date + mov ah,2ah + int 21h + ; CX = Year, DH = Month, DL = Day, AL = Day of Week + + mov byte [sysdate_check],'1' + cmp cx,2009 + jc .sys_date_fail + + mov byte [sysdate_check],'2' + cmp cx,2050 + jnc .sys_date_fail + + mov byte [sysdate_check],'3' + cmp al,7 + jnc .sys_date_fail + + mov byte [sysdate_check],'4' + cmp dh,13 + jnc .sys_date_fail + + mov byte [sysdate_check],'5' + cmp dl,32 + jnc .sys_date_fail + + mov byte [sysdate_str],'w' +.sys_date_fail: + + mov dx,sysdate_str + mov cx,sysdate_len + call report + +test_systime: + + mov cx,0ffffh + mov dx,0ffffh + + ; Get System time + mov ah,2ch + int 21h + ; CH = Hour, CL = Min, DH = sec, DL = millisec + + mov byte [systime_check],'1' + cmp ch,24 + jnc .sys_time_fail + + mov byte [systime_check],'2' + cmp cl,60 + jnc .sys_time_fail + + mov byte [systime_check],'3' + cmp dh,60 + jnc .sys_time_fail + + mov byte [systime_str],'w' + +.sys_time_fail: + mov dx,systime_str + mov cx,systime_len + call report + retn + + ;=============================================================== + ; + ; Test stdin status + ; Should return no character available + ; + ;=============================================================== + +test_stdin: + mov ah,0bh + mov al,20h + int 21h + cmp al,00h + jz .ok_status + cmp al,0ffh + jnz .err_status +.ok_status: + mov byte [stdin_err_str],'w' + +.err_status: + mov di,stdin_status + call al_as_hex + + mov dx,stdin_err_str + mov cx,stdin_err_len + call report + retn + + ;=============================================================== + ; + ; Test current drive + ; + ;=============================================================== + +test_curr_drive: + mov ax,19ffh + int 21h + mov [current_drive],al + + cmp al,26 + jnc .drive_err + + mov byte [curr_drive_str],'w' + +.drive_err: + mov di,curr_drive_hex + call al_as_hex + + mov dx,curr_drive_str + mov cx,curr_drive_len + call report + + ; TODO: 0eh - Set current drive + + retn + + ;=============================================================== + ; + ; Test free space of C: + ; + ;=============================================================== + +test_free_spc: + mov ah,36h + mov dl,[current_drive] + inc dl + cmp dl,25 + jnz .notz + mov dl,3 ; If run from wine Z: use disk C: instead +.notz: + int 21h + cmp ax,0ffffh + jz .free_err + + mov byte [freespace_str],'w' + +.free_err: + mov di,freespace_sector + call ax_as_hex + + mov di,freespace_free + mov ax,bx + call ax_as_hex + + mov di,freespace_bytes + mov ax,cx + call ax_as_hex + + mov di,freespace_total + mov dx,ax + call ax_as_hex + + mov dx,freespace_str + mov cx,freespace_len + call report + retn + + ;=============================================================== + ; + ; Check country information + ; + ;=============================================================== + +test_country: + ; Get default country + mov ax,3800h + mov dx,country_default + int 21h + jc country_error + + ; Check all the known languages + mov dx,0ffffh + mov bp,country_known +.country_loop: + mov ax,[bp] + cmp ax,0ffffh + jz country_error + + cmp ax,0ffh + jc .lowval + mov bx,ax + mov al,0ffh +.lowval: + mov ah,38h + mov dx,country_buffer + int 21h + jnc country_ok + inc bp + inc bp + jmp .country_loop + +country_ok: + mov byte [country_err],'w' + +country_error: + mov dx,country_err + mov cx,country_len + call report + retn + + ;=============================================================== + ; + ; Test memory functions + ; + ;=============================================================== + +test_mem_alloc: + + ; Get segment of first byte after from PSP + mov ax,[2] + + ; Do some size calculation based on PSP values. + mov bx,es + sub ax,bx + mov [psp_mem_size],ax ; Size of largest block + + mov ax,[2] + call dump_mcb + + ; Check that it points to valid end MCB + + ; As .COM program we should have all low memory + ; So we resize to 64K first + mov ah,4ah + mov bx,4096 + int 21h + jc .cant_decrease1 + + mov ax,bx + + mov di,resize_out + call ax_as_hex + + mov dx,resize_str + mov ah,9 + int 21h + + ; Resize to max should reallocate all memory again + mov ah,4ah + mov bx,0ffffh + int 21h + jnc .unexpected_succes + + cmp bx,[psp_mem_size] + jnz .resize_wrong + + ; And resize to 64K again, so we can check memory alloc + + mov ah,4ah + mov bx,4096 + int 21h + jc .cant_decrease2 + + mov ax,bx + + mov di,resize_out + call ax_as_hex + + mov dx,resize_str + mov ah,9 + int 21h + + ; + ; Allocate 1M. This should fail + mov bx,0ffffh + mov ah,48h + int 21h + jnc .unexpected_succes + + mov [largest],bx + + mov ax,bx + + mov di,large + call ax_as_hex + + mov dx,large_str + mov ah,9 + int 21h + + ; Calculate the size we should have gotten + mov ax,[psp_mem_size] + sub ax,1001h + cmp ax,[largest] + jnz .memory_failed + + ; Allocate a fresh 4K block + mov ah,48h + mov bx,100h + int 21h + jc .memory_failed + mov [new_memory],ax + mov es,ax + + ; Try resize above possible + mov ah,4ah + mov bx,0ffffh + int 21h + jnc .unexpected_succes + + ; BX should be largest + cmp bx,[largest] + jnz .resize_failed + + ; Now we should have all normal memory + + ; We should get a upper memory block now + mov ah,4ah + mov bx,100h + int 21h + jc .upper_failed + + cmp ax,0a000h + jnc .upper_failed + + jmp .memory_ok + + ; Now lets resize the original memory (which can't expand) + mov ax,ds + mov es,ax + + mov ah,48h + mov bx,2000h + int 21h + jnc .resize_didnt_fail + + cmp bx,1000h + jnz .resize_size_err + mov byte [resize_no_out],'w' +.resize_size_err: + + mov ax,bx + mov di,resize_no_out + call ax_as_hex + + mov dx,resize_no_str + mov cx,resize_no_len + call report + +.unexpected_succes: + ; This may succed if run in protected mode + mov dx,memory_ok_err + mov cx,memory_ok_len + call report + + jmp .memory_ok + +.resize_wrong: + mov ax,bx + mov di,resize_up1_got + call ax_as_hex + + mov ax,[psp_mem_size] + mov di,resize_up1_expect + call ax_as_hex + + mov dx,resize_up1_err + mov cx,resize_up1_len + call report + + jmp .memory_ok + +.cant_decrease1: + mov dx,decrease1_err + mov cx,decrease1_len + call report + jmp .memory_ok + +.cant_decrease2: + mov dx,decrease2_err + mov cx,decrease2_len + call report + jmp .memory_ok + +.resize_failed: + mov dx,resize_fail_err + mov cx,resize_fail_len + call report + jmp .memory_ok + +.resize_didnt_fail: + mov dx,no_resize_err + mov cx,no_resize_len + call report + jmp .memory_ok + +.upper_failed: + mov dx,upper_fail_err + mov cx,upper_fail_len + call report + jmp .memory_ok + +.memory_failed: + mov dx,memory_fail_err + mov cx,memory_fail_len + call report + +.memory_ok: + ; Cleanup + mov ax,[new_memory] + or ax,ax + jz .free_upper + mov es,ax + ; We clear new_memory now, to avoid trying freeing it again + xor ax,ax + mov [new_memory],ax + + mov ah,49h + int 21h + jc .memory_failed + +.free_upper: + mov ax,[upper_mem] + or ax,ax + jz .free_done + + mov es,ax + ; We clear uper_mem now, to avoid trying freeing it again + xor ax,ax + mov [upper_mem],ax + + mov ah,49h + int 21h + jc .upper_failed + +.free_done: + mov ax,ds + mov es,ax + retn + +dump_mcb: + + mov si,0 + mov di,mcb_dump + mov bx,ax + +.loop: + push ds + mov ds,bx + mov al,[si] + pop ds + call al_as_hex + inc di + inc si + cmp si,16 + jnz .loop + + mov dx,mcb_str + mov ah,09h + int 21h + retn + + ;=============================================================== + ; + ; Test file handle functions + ; + ;=============================================================== + +test_file_handle: + ; 3ch create or truncate file + ; 3dh open file + ; 3eh close file + ; 3fh read from file + ; 40h write to file + ; 41h delete file + ; 42h Set current file position + ; 43h Get file attributes + ; 43h Set file attributes + ; 3bh Set current directory + ; 39h Create directory + ; 3ah Delete directory + ; 47h Get current directory + ; 56h Rename file + ; 57h Get last-written date and time + ; 57h Set last-written date and time + + ; Open file for writing + ; Write a string to file + ; Close file + + ; Open file for reading + ; Read string from file + ; Close file + + ; Compare to stored string + ; Create directory + ; Change to directory + ; Repeat file test above + ; Delete file + ; Change to old current directory + ; Delete directory + + ; Position checking + + ; Get verify flag + ; Set verify flag + retn + +move_string: + push si +.loop: + mov al,[si] + cmp al,0 + jz .clear + inc si + mov [di],al + inc di + dec cx + jz .exit + jmp .loop + +.clear: + mov byte [di],' ' + inc di + dec cx + jnz .clear +.exit: + pop si + retn + +ax_as_hex: + push ax + mov al,ah + call al_as_hex + pop ax +al_as_hex: + push ax + ror al,4 + call .digit + pop ax +.digit: + and al,0fh + add al,48 + cmp al,58 + jc .nothex + add al,7 +.nothex: + mov [di],al + inc di + retn + +%include "report.inc" + +section .data + +output_handle dw 0 +largest dw 0 +avail dw 0 +new_memory dw 0 +upper_mem dw 0 + +psp_mem_size dw 0 +resize_mem_size dw 0 + +current_drive db 0 + + +country_known dw 001h ; (1) United States + dw 002h ; (2) Canadian-French + dw 003h ; (3) Latin America + dw 004h ; (4) Canada (English) + dw 007h ; (7) Russia + dw 014h ; (20) Egypt + dw 01Bh ; (27) South Africa + dw 01Eh ; (30) Greece + dw 01Fh ; (31) Netherlands + dw 020h ; (32) Belgium + dw 021h ; (33) France + dw 022h ; (34) Spain + dw 023h ; (35) Bulgaria??? + dw 024h ; (36) Hungary (not supported by DR DOS 5.0) + dw 026h ; (38) Yugoslavia (not supported by DR DOS 5.0) -- obsolete + dw 027h ; (39) Italy / San Marino / Vatican City + dw 028h ; (40) Romania + dw 029h ; (41) Switzerland / Liechtenstein + dw 02Ah ; (42) Czechoslovakia / Tjekia / Slovakia (not supported by DR DOS 5.0) + dw 02Bh ; (43) Austria (DR DOS 5.0) + dw 02Ch ; (44) United Kingdom + dw 02Dh ; (45) Denmark + dw 02Eh ; (46) Sweden + dw 02Fh ; (47) Norway + dw 030h ; (48) Poland (not supported by DR DOS 5.0) + dw 031h ; (49) Germany + dw 033h ; (51) Peru + dw 034h ; (52) Mexico + dw 035h ; (53) Cuba + dw 036h ; (54) Argentina + dw 037h ; (55) Brazil (not supported by DR DOS 5.0) + dw 038h ; (56) Chile + dw 039h ; (57) Columbia + dw 03Ah ; (58) Venezuela + dw 03Ch ; (60) Malaysia + dw 03Dh ; (61) International English / Australia + dw 03Eh ; (62) Indonesia / East Timor + dw 03Fh ; (63) Philippines + dw 040h ; (64) New Zealand + dw 041h ; (65) Singapore + dw 042h ; (66) Thailand (or Taiwan???) + dw 051h ; (81) Japan (DR DOS 5.0, MS-DOS 5.0+) + dw 052h ; (82) South Korea (DR DOS 5.0) + dw 054h ; (84) Vietnam + dw 056h ; (86) China (MS-DOS 5.0+) + dw 058h ; (88) Taiwan (MS-DOS 5.0+) + dw 05Ah ; (90) Turkey (MS-DOS 5.0+) + dw 05Bh ; (91) India + dw 05Ch ; (92) Pakistan + dw 05Dh ; (93) Afghanistan + dw 05Eh ; (94) Sri Lanka + dw 062h ; (98) Iran + dw 063h ; (99) Asia (English) + dw 066h ; (102) ??? (Hebrew MS-DOS 5.0) + dw 070h ; (112) Belarus + dw 0C8h ; (200) Thailand (PC DOS 6.1+) + ; (reported as 01h due to a bug in PC DOS COUNTRY.SYS) + dw 0D4h ; (212) Morocco + dw 0D5h ; (213) Algeria + dw 0D8h ; (216) Tunisia + dw 0DAh ; (218) Libya + dw 0DCh ; (220) Gambia + dw 0DDh ; (221) Senegal + dw 0DEh ; (222) Maruitania + dw 0DFh ; (223) Mali + dw 0E0h ; (224) African Guinea + dw 0E1h ; (225) Ivory Coast + dw 0E2h ; (226) Burkina Faso + dw 0E3h ; (227) Niger + dw 0E4h ; (228) Togo + dw 0E5h ; (229) Benin + dw 0E6h ; (230) Mauritius + dw 0E7h ; (231) Liberia + dw 0E8h ; (232) Sierra Leone + dw 0E9h ; (233) Ghana + dw 0EAh ; (234) Nigeria + dw 0EBh ; (235) Chad + dw 0ECh ; (236) Centra African Republic + dw 0EDh ; (237) Cameroon + dw 0EEh ; (238) Cape Verde Islands + dw 0EFh ; (239) Sao Tome and Principe + dw 0F0h ; (240) Equatorial Guinea + dw 0F1h ; (241) Gabon + dw 0F2h ; (242) Congo + dw 0F3h ; (243) Zaire + dw 0F4h ; (244) Angola + dw 0F5h ; (245) Guinea-Bissau + dw 0F6h ; (246) Diego Garcia + dw 0F7h ; (247) Ascension Isle + dw 0F8h ; (248) Seychelles + dw 0F9h ; (249) Sudan + dw 0FAh ; (250) Rwhanda + dw 0FBh ; (251) Ethiopia + dw 0FCh ; (252) Somalia + dw 0FDh ; (253) Djibouti + dw 0FEh ; (254) Kenya + dw 0FFh ; (255) Tanzania + dw 100h ; (256) Uganda + dw 101h ; (257) Burundi + dw 103h ; (259) Mozambique + dw 104h ; (260) Zambia + dw 105h ; (261) Madagascar + dw 106h ; (262) Reunion Island + dw 107h ; (263) Zimbabwe + dw 108h ; (264) Namibia + dw 109h ; (265) Malawi + dw 10Ah ; (266) Lesotho + dw 10Bh ; (267) Botswana + dw 10Ch ; (268) Swaziland + dw 10Dh ; (269) Comoros + dw 10Eh ; (270) Mayotte + dw 122h ; (290) St. Helena + dw 129h ; (297) Aruba + dw 12Ah ; (298) Faroe Islands + dw 12Bh ; (299) Greenland + dw 15Eh ; (350) Gibraltar + dw 15Fh ; (351) Portugal + dw 160h ; (352) Luxembourg + dw 161h ; (353) Ireland + dw 162h ; (354) Iceland + dw 163h ; (355) Albania + dw 164h ; (356) Malta + dw 165h ; (357) Cyprus + dw 166h ; (358) Finland + dw 167h ; (359) Bulgaria + dw 172h ; (370) Lithuania (reported as 372 due to a bug in MS-DOS COUNTRY.SYS) + dw 173h ; (371) Latvia (reported as 372 due to a bug in MS-DOS COUNTRY.SYS) + dw 174h ; (372) Estonia + dw 175h ; (373) Moldova + dw 177h ; (375) ??? (MS-DOS 7.10 / Windows98) + dw 17Ch ; (380) Ukraine + dw 17Dh ; (381) Serbia / Montenegro + dw 180h ; (384) Croatia + dw 181h ; (385) Croatia (PC DOS 7+) + dw 182h ; (386) Slovenia + dw 183h ; (387) Bosnia-Herzegovina (Latin) + dw 184h ; (388) Bosnia-Herzegovina (Cyrillic) (PC DOS 7+) + ; (reported as 381 due to a bug in PC DOS COUNTRY.SYS) + dw 185h ; (389) FYR Macedonia + dw 1A5h ; (421) Czech Republic / Tjekia (PC DOS 7+) + dw 1A6h ; (422) Slovakia + ; (reported as 421 due to a bug in COUNTRY.SYS) + dw 1F4h ; (500) Falkland Islands + dw 1F5h ; (501) Belize + dw 1F6h ; (502) Guatemala + dw 1F7h ; (503) El Salvador + dw 1F8h ; (504) Honduras + dw 1F9h ; (505) Nicraragua + dw 1FAh ; (506) Costa Rica + dw 1FBh ; (507) Panama + dw 1FCh ; (508) St. Pierre and Miquelon + dw 1FDh ; (509) Haiti + dw 24Eh ; (590) Guadeloupe + dw 24Fh ; (591) Bolivia + dw 250h ; (592) Guyana + dw 251h ; (593) Ecuador + dw 252h ; (594) rench Guiana + dw 253h ; (595) Paraguay + dw 254h ; (596) Martinique / French Antilles + dw 255h ; (597) Suriname + dw 256h ; (598) Uruguay + dw 257h ; (599) Netherland Antilles + dw 29Ah ; (666) Russia??? (PTS-DOS 6.51 KEYB) + dw 29Bh ; (667) Poland??? (PTS-DOS 6.51 KEYB) + dw 29Ch ; (668) Poland??? (Slavic???) (PTS-DOS 6.51 KEYB) + dw 29Eh ; (670) Saipan / N. Mariana Island + dw 29Fh ; (671) Guam + dw 2A0h ; (672) Norfolk Island (Australia) / Christmas Island/Cocos Islands / Antartica + dw 2A1h ; (673) Brunei Darussalam + dw 2A2h ; (674) Nauru + dw 2A3h ; (675) Papua New Guinea + dw 2A4h ; (676) Tonga Islands + dw 2A5h ; (677) Solomon Islands + dw 2A6h ; (678) Vanuatu + dw 2A7h ; (679) Fiji + dw 2A8h ; (680) Palau + dw 2A9h ; (681) Wallis & Futuna + dw 2AAh ; (682) Cook Islands + dw 2ABh ; (683) Niue + dw 2ACh ; (684) American Samoa + dw 2ADh ; (685) Western Samoa + dw 2AEh ; (686) Kiribati + dw 2AFh ; (687) New Caledonia + dw 2B0h ; (688) Tuvalu + dw 2B1h ; (689) French Polynesia + dw 2B2h ; (690) Tokealu + dw 2B3h ; (691) Micronesia + dw 2B4h ; (692) Marshall Islands + dw 2C7h ; (711) ??? (currency = EA$, code pages 437,737,850,852,855,857) + dw 311h ; (785) Arabic (Middle East/Saudi Arabia/etc.) + dw 324h ; (804) Ukraine + dw 329h ; (809) Antigua and Barbuda and more + dw 352h ; (850) North Korea + dw 354h ; (852) Hong Kong + dw 355h ; (853) Macao + dw 357h ; (855) Cambodia + dw 358h ; (856) Laos + dw 370h ; (880) Bangladesh + dw 376h ; (886) Taiwan (MS-DOS 6.22+) + dw 3C0h ; (960) Maldives + dw 3C1h ; (961) Lebanon + dw 3C2h ; (962) Jordan + dw 3C3h ; (963) Syria / Syrian Arab Republic + dw 3C4h ; (964) Iraq + dw 3C5h ; (965) Kuwait + dw 3C6h ; (966) Saudi Arabia + dw 3C7h ; (967) Yemen + dw 3C8h ; (968) Oman + dw 3C9h ; (969) Yemen??? (Arabic MS-DOS 5.0) + dw 3CBh ; (971) United Arab Emirates + dw 3CCh ; (972) Israel (Hebrew) (DR DOS 5.0,MS-DOS 5.0+) + dw 3CDh ; (973) Bahrain + dw 3CEh ; (974) Qatar + dw 3CFh ; (975) Bhutan + dw 3D0h ; (976) Mongolia + dw 3D1h ; (977) Nepal + dw 3E3h ; (995) Myanmar (Burma) + dw 0ffffh ; End marker + +; +; Each known version takes 2 words +; The order is minor/major with 2 hexdigits for each +; This is due to way the value is returned +; +known_versions: + dw 0005h + dw 0006h + dw 0007h + dw 0 ; end marker + +known_oem_versions: + dw 0005h + dw 0006h + dw 0007h + dw 0 ; end marker + +%include "rep_dat.inc" + +serial_err_str db "t: Serial number is zero",13,10 +serial_err_len equ $ - serial_err_str + +version_err_str db "t: DOS version match known list: " +version_output db '????' + db 13,10 +version_err_len equ $ - version_err_str + +vers_oem_err_str db "t: OEM Version match known list: " +vers_oem_err_out db '????' + db 13,10 +vers_oem_err_len equ $ - vers_oem_err_str + +stdin_err_str db 'e: Stdin status 00 or FFh, Got ' +stdin_status db '??' + db 13,10 +stdin_err_len equ $- stdin_err_str + +curr_drive_str db 'e: Current drive in expected range 0x00-0x19.' + db ' Return: ' +curr_drive_hex db '??h.' + db 13,10 +curr_drive_len equ $- curr_drive_str + +sysdate_str db 'e: System date ok. Check no ' +sysdate_check db '?',13,10 +sysdate_len equ $- sysdate_str + +systime_str db 'e: System time ok. Check no ' +systime_check db '?',13,10 +systime_len equ $- systime_str + +freespace_str db 'e: Free disk space check. Sectors pr. Cluster: ' +freespace_sector db '????h. Bytes pr. sector: ' +freespace_bytes db '????h. Free clusters: ' +freespace_free db '????h. Total clusters: ' +freespace_total db '????h.' + db 13,10 +freespace_len equ $- freespace_str + +country_err db 't: No specific country returned information.',13,10 +country_len equ $ - country_err + +upper_fail_err db 't: Failed to allocate upper memory block.',13,10 +upper_fail_len equ $ - upper_fail_err + +resize_fail_err db "t: Resize failure. Didn't return correct size",13,10 +resize_fail_len equ $ - resize_fail_err + +no_resize_err db "e: Resize didn',39,'t fail as it should.",13,10 +no_resize_len equ $ - no_resize_err + +memory_fail_err db 'e: Memory allocation failed',13,10 +memory_fail_len equ $ - memory_fail_err + +memory_ok_err db 'e: Unexpect succes of memory allocation.',13,10 +memory_ok_len equ $ - memory_ok_err + +decrease1_err db 'e: Couldn',39,'t decrease size to 64K first time.',13,10 +decrease1_len equ $ - decrease1_err + +decrease2_err db 'e: Couldn',39,'t decrease size to 64K second time.',13,10 +decrease2_len equ $ - decrease2_err + +resize_up1_err db 't: Couldn',39,'t resize original size to max. Expected ' +resize_up1_expect db '????. Got ' +resize_up1_got db '????.',13,10 +resize_up1_len equ $ - resize_up1_err + +resize_no_str db 't: Resize to 128K and no memory available.' + db ' Expected 1000h, BX=' +resize_no_out db '????h.',13,10 +resize_no_len equ $ - resize_no_str + +avail_str db 'Available ' +avail_out db '????',13,10,'$' + +psp_str db 'PSP size ' +psp_out db '????',13,10,'$' + +resize_str db 'Resize to 64K, BX=' +resize_out db '????',13,10,'$' + +maxsize_str db 'Resize to max alloc, BX=' +maxsize_out db '????',13,10,'$' + +large_str db 'Largest ' +large db '????',13,10,'$' + +mcb_str db 'MCB: ' +mcb_dump db '?? ?? ?? ?? ?? ?? ?? ?? ' + db '?? ?? ?? ?? ?? ?? ?? ??' + db 13,10,'$' +section .bss + + ; Buffer for country information +country_buffer resb 64 +country_default resb 64 + +stack resb 1024 diff --git a/dlls/kernel32/tests/rep_dat.inc b/dlls/kernel32/tests/rep_dat.inc new file mode 100644 index 0000000..3dd741b --- /dev/null +++ b/dlls/kernel32/tests/rep_dat.inc @@ -0,0 +1,4 @@ +output_filename db 'test.rep',0 + +failed_output db "Can't create report file test.rep",13,10,'$' +failed_write db "Can't write to report file test.rep",13,10,'$' diff --git a/dlls/kernel32/tests/report.inc b/dlls/kernel32/tests/report.inc new file mode 100644 index 0000000..44dbe16 --- /dev/null +++ b/dlls/kernel32/tests/report.inc @@ -0,0 +1,48 @@ + +open_report: + ; Open test output report file + mov ah,3ch + mov cx,0000h + mov dx,output_filename + int 21h + jnc test_go + + ; Can't write to output file + mov ah,09h + mov dx,failed_output + int 21h + + mov ax,4c01h + int 21h + +test_go: + + mov [output_handle],ax + retn + + ; Report the string pointer at dx, length cx + ; String is written to report file + +report: + mov ah,40h + mov bx,[output_handle] + int 21h + jc .err + retn + +.err: + mov dx,failed_write + mov ah,9 + int 21h + + ; Terminate + mov ax,4c01h + int 21h + retn + +close_report: + mov ah,2eh + mov bx,[output_handle] + int 21h + retn + -- 1.6.3.3 >From 479a3f49c5e166cf77aad7323a74f3732db9bdbd Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Morten=20R=C3=B8nne?= <morten.roenne(a)tdcadsl.dk> Date: Mon, 26 Apr 2010 13:51:33 +0200 Subject: Added needed definitions to detect and use assembler to build DOS test programs. --- Make.rules.in | 2 +- configure.ac | 10 ++++++++++ dlls/kernel32/tests/Makefile.in | 17 +++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index 7b571ed..b5f87d8 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -136,7 +136,7 @@ filter: dummy # Implicit rules -.SUFFIXES: .mc .rc .mc.rc .res .idl .tlb .h .y .l .tab.c .tab.h .yy.c .ok .man.in .man _c.c _i.c _p.c _s.c .cross.o @MAINTAINER_MODE@ .sfd .ttf .svg .ico +.SUFFIXES: .mc .rc .mc.rc .res .idl .tlb .h .y .l .tab.c .tab.h .yy.c .ok .man.in .man _c.c _i.c _p.c _s.c .cross.o .asm .com @MAINTAINER_MODE@ .sfd .ttf .svg .ico .c.o: $(CC) -c $(ALLCFLAGS) -o $@ $< diff --git a/configure.ac b/configure.ac index 83b3240..bc230d1 100644 --- a/configure.ac +++ b/configure.ac @@ -314,6 +314,16 @@ then fi +AC_CHECK_PROGS(ASM, [nasm], false) + case "$ASM" in + false) + WINE_NOTICE([Assembler not found. Unable to create DOS programs for testing.]) + ;; + nasm) + AC_SUBST(ASM_FLAGS, "-f bin -w+orphan-labels") + ;; + esac + case $host_cpu in *i[[3456789]]86*) AC_PATH_PROG(PRELINK, prelink, false, [/sbin /usr/sbin $PATH]) diff --git a/dlls/kernel32/tests/Makefile.in b/dlls/kernel32/tests/Makefile.in index ed2d6e6..3d00454 100644 --- a/dlls/kernel32/tests/Makefile.in +++ b/dlls/kernel32/tests/Makefile.in @@ -42,4 +42,21 @@ C_SRCS = \ RC_SRCS = resource.rc +ASM_SRCS = int21.asm + @MAKE_TEST_RULES@ + +ASM = @ASM@ + +ASM_FLAGS = @ASM_FLAGS@ + +COM_OBJS = $(ASM_SRCS:.asm=.com) + +ifdef ASM + +asm: $(COM_OBJS) + +.asm.com: + $(ASM) $(ASM_FLAGS) -o $@ $< + +endif -- 1.6.3.3

2 2

RE: Handling of DDB in tests?
by Greg Geldorp 26 Apr '10

26 Apr '10

> From: Wolfram Sang > > while trying to deliver a testcase for Bug #14891 (Bitmaps with offset > bits do not display correctly) I tried this patch: > > https://testbot.winehq.org/JobDetails.pl?Key=1740 > > Two VMs reported the correct pixel as 0x0000ffff instead of 0x00ffffff. > (The truly failed pixel would have 0x00010101 or similar). I'd assume that > is because they use 16 bit display-depth? Yes, both of these VMs (W98SE and WNT4SP6) use 16 bit displays. Best regards, Ge.

1 0

Re: configure: Refuse to build wine64 with buggy gcc
by Michael Stefaniuc 26 Apr '10

26 Apr '10

Maarten Lankhorst wrote: > --- > ;D As there is no fixed gcc out there I'd rather see configure warn here instead of aborting. We do want to make it easy for people to compile Wine64. bye michael

3 2

Handling of DDB in tests?
by Wolfram Sang 26 Apr '10

26 Apr '10

Hi, while trying to deliver a testcase for Bug #14891 (Bitmaps with offset bits do not display correctly) I tried this patch: https://testbot.winehq.org/JobDetails.pl?Key=1740 Two VMs reported the correct pixel as 0x0000ffff instead of 0x00ffffff. (The truly failed pixel would have 0x00010101 or similar). I'd assume that is because they use 16 bit display-depth? If so, is it "good enough" to check for both of these values as expected results? I am a bit confused because LoadImage creates a DDB (via CreateCompatibleBitmap()) and the pixeldata is thus allowed to look like anything. Still, there are checks with GetPixelData and memcmp in the other tests (gdi32/tests/bitmap.c). But maybe I am wrong or missing something? Thanks, Wolfram

1 0

Re: shell32/tests: Skip Listview interaction tests on Vista+, list doesn't contain any items for some reason.
by testbot＠testbot.winehq.org 25 Apr '10

25 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1735 Your paranoid android. === W98SE (32 bit shlview) === shlview.c:520: Test failed: expected not empty folder Timeout === WNT4WSSP6 (32 bit shlview) === No test summary line found

1 0

re: Phoronix might provide per-commit performance testing for Wine (Awesome!!!)
by Dan Kegel 25 Apr '10

25 Apr '10

That would totally rock. Are there instructions yet for running Phoronix under windows?

1 0

Phoronix might provide per-commit performance testing for Wine (Awesome!!!)
by Scott Ritchie 25 Apr '10

25 Apr '10

http://www.phoronix.com/scan.php?page=news_item&px=ODA3Ng "Earlier today we then called out for benchmarking requests as what we should track next using our testing and execution framework (so far the likely contender is seeing how Wine's performance is evolving on a per-commit basis, but let us know what you think)" This would be incredibly helpful and I think we should collaborate more directly. I'd like to see Phoronix Test Suite's (under development) Windows version run regularly in Wine as well. I've copied Michael Larabel from Phoronix here, I'm hoping he will join the discussion. I'm willing to help Michael get Windows Phoronix working in Wine, if need be. Needless to say, thanks in advance :) Thanks, Scott Ritchie

2 1

new winetricks 20100424: new verbs directmusic, dsoundbug9612, mono26, strictdrawordering, quartz, videomemorysize
by Dan Kegel 24 Apr '10

24 Apr '10

Another month, another Winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes: Austin English: - add a strictdrawordering enabled/disabled option, use it for Dragon Age in wisotool - add quartz verb - add directmusic verb, use it along with directplay for directx-beta - bump Firefox to 3.6.3 - for AutoHotKey, cd AFTER downloading, otherwise download() puts us in the wrong place - update windows scripting host to version 5.7, shim 5.6 around 5.7 - 'esound' isn't a driver, 'esd' is. (Issue 109) - add a missing try_unzip() - cd to $WINETRICKS_CACHE before running AutoHotKey installer (needed for cygwin). - don't die for missing unzip, unless it's actually needed. - if neither wget or curl is available, give the user a better explanation. Also fix indentation in download(). - fix typo in vcrun2005 Dan Kegel: - remove Z: symlink in sandbox verb (!) - work even if drive Z isn't mapped - added very specific d3dx9_28, d3dx9_36 verbs - Mention license in comments at top - add videomemorysize={512,1024,default} - never install ie6 on real windows - vcrun2005 needs an extra override to actually do anything now that we have our own msvcr80 Erik Inge Bolsø: - physx refresh - fix issue 110 (7zip menu item doesn't show up) - add override to vcrun2008 as well - add dsoundbug9612 verb Andrew Nguyen: - Improve wine-gecko prerequisite checking and extraction. Vincent Povirk: - add mono26 verb Pavel Zinin: - add mwo, npm-repack,psm,vsm-hard verbs

1 0

Re: shell32: Fix tests to apply to Vista+
by Nikolay Sivov 24 Apr '10

24 Apr '10

On 4/23/2010 16:56, André Hentschel wrote: > --- > dlls/shell32/tests/shlfolder.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c > index f63bf6e..634c3d3 100644 > --- a/dlls/shell32/tests/shlfolder.c > +++ b/dlls/shell32/tests/shlfolder.c > @@ -2048,7 +2048,10 @@ if (0) > ok(hr == S_OK, "failed %08x\n", hr); > > ret = pILIsEqual(pidl1, pidl2); > - ok(ret == TRUE, "expected equal idls\n"); > + todo_wine > + ok(broken(ret) || > + !ret, /* Vista+ */ > + "expected different idls\n"); > pILFree(pidl1); > pILFree(pidl2); > > There's no point to silence this. We need to figure out what's this pidl about on Vista+, e.g. dump it data and then probably review Wine handling of this.

5 6

Top wine-using country: Russia?
by Dan Kegel 24 Apr '10

24 Apr '10

It might be interesting to know which countries use Wine the most. I have no idea how to measure that, but the top three countries in http://www.google.com/trends?q=winetricks,+playonlinux are Russia, Czech, and Ukraine!

3 2

re: Remove NoAppDBEntry keyword?
by Dan Kegel 24 Apr '10

24 Apr '10

Jerome Leclanche wrote: > Austin English <austinenglish at gmail.com> wrote: >> Anyone opposed to removing that keyword? > > +1 on removing it. > It would be nice to have a bugzilla filter to replace it, too. > > Are we keeping "tasklist" and "tasklet" keywords as well? theres > barely a dozen very old bugs for both of them. I think it'd be fine to remove noappdbentry, tasklist, and tasklet. If there are no objections by next weekend, let's go ahead and do it. - Dan

4 4

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]
by Greg Geldorp 24 Apr '10

24 Apr '10

> From: Ilya Basin <basinilya(a)gmail.com> > > Then postponing till my next slack period, the more so I got another > e-mail: > > === W7PROX64 (32 bit shlexec) === > No test failures found > > === W7PROX64 (64 bit shlexec) === > > shell32: > shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2 > shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2 > shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2 > shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2 > shlexec.c:1609: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt1F81.tmp\test file.sde", null, null) failed: rc=29 err=2 > > Strange, isn't it? I wonder if the tests succeeded without my patch. Those failures are also present without your patch, see https://testbot.winehq.org/JobDetails.pl?Key=1696#k105 Ge.

1 0

Re: [1/2] gdiplus: Add test for GdipCreateBitmapFromGdiDib.
by Greg Geldorp 24 Apr '10

24 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1718 Your paranoid android. === W2K3R2SESP2 (32 bit image) === No test summary line found === WVISTAADM (32 bit image) === Timeout

1 0

Re: Minor dlls/dbghelp/dwarf.c simplification
by Eric Pouech 24 Apr '10

24 Apr '10

Gerald Pfeifer a écrit : > ChangeLog: > Remove two variables which are not really used in > dwarf2_parse_line_numbers. > > diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c > index 4be0f6a..69d7357 100644 > --- a/dlls/dbghelp/dwarf.c > +++ b/dlls/dbghelp/dwarf.c > @@ -1920,7 +1920,7 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, > { > dwarf2_traverse_context_t traverse; > unsigned long length; > - unsigned version, header_len, insn_size, default_stmt; > + unsigned insn_size, default_stmt; > unsigned line_range, opcode_base; > int line_base; > const unsigned char* opcode_len; > @@ -1939,8 +1939,6 @@ static BOOL dwarf2_parse_line_numbers(const dwarf2_section_t* sections, > length = dwarf2_parse_u4(&traverse); > traverse.end_data = sections[section_line].address + offset + length; > > - version = dwarf2_parse_u2(&traverse); > - header_len = dwarf2_parse_u4(&traverse); > insn_size = dwarf2_parse_byte(&traverse); > default_stmt = dwarf2_parse_byte(&traverse); > line_base = (signed char)dwarf2_parse_byte(&traverse); > > > > > this is wrong: dwarf_parse family set makes the pointer in the cxt advance by the size of the object which is being parse and actually, the correct fix would be to make use of those variables (like checking if the version is a known one), instead of throwing things away A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]
by Paul Vriens 24 Apr '10

24 Apr '10

On 04/24/2010 10:53 AM, Ilya Basin wrote: > 1) removes the block of code that splits lpFile into filename and > parameters and removes '"'s from filename . Even without this block > ShellExecute not fails with quoted lpFile. > > 2) removes 2 corresponding todo_wine's from tests. > > The real application affected by this bug is uTorrent: if you have 2 > downloads containing, say, > "foo/bar.avi" and "foo 2/baz.avi", when you double click the latter > avi file, it'll open the explorer in folder "foo" instead. > > try 2: > disabled todo_wine for "%s\\masked file.shlexec" > instead of disabling all todo_wine's in the loop > > try 3: > try 2 didn't apply cleanly in git: ok() format string changed. > Hi Ilya, In your last email on wine-devel about this subject you mentioned adding some extra tests. There was at least some communication with you and the author of that piece you are now removing. The reason for that piece was shown in a code-snippet he gave and adding tests for that specific case would be worthwhile I think. -- Cheers, Paul.

2 1

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 3]
by Nikolay Sivov 24 Apr '10

24 Apr '10

On 4/24/2010 12:53, Ilya Basin wrote: > 1) removes the block of code that splits lpFile into filename and > parameters and removes '"'s from filename . Even without this block > ShellExecute not fails with quoted lpFile. > > 2) removes 2 corresponding todo_wine's from tests. > > The real application affected by this bug is uTorrent: if you have 2 > downloads containing, say, > "foo/bar.avi" and "foo 2/baz.avi", when you double click the latter > avi file, it'll open the explorer in folder "foo" instead. > > try 2: > disabled todo_wine for "%s\\masked file.shlexec" > instead of disabling all todo_wine's in the loop > > try 3: > try 2 didn't apply cleanly in git: ok() format string changed. > > --- > dlls/shell32/shlexec.c | 62 +----------------------------------------- > dlls/shell32/tests/shlexec.c | 16 +++++------ > 2 files changed, 8 insertions(+), 70 deletions(-) > > diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c > index a81cada..b89bb08 100644 > --- a/dlls/shell32/shlexec.c > +++ b/dlls/shell32/shlexec.c > @@ -1678,67 +1678,7 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc ) > /* Else, try to execute the filename */ > TRACE("execute:%s,%s,%s\n", debugstr_w(wszApplicationName), debugstr_w(wszParameters), debugstr_w(wszDir)); > > - /* separate out command line arguments from executable file name */ > Where are tests for this separation path? You know, it's suspicious to just remove it to solve for not-clearly related problem to this code block.

1 0

wine + rtkit, take 2
by Maarten Lankhorst 24 Apr '10

24 Apr '10

Hi all, Just thought I'd try my luck again with rtkit, so here's what I came up with this time without a bizarre dbus call in ntdll. :) This requires a patch to rtkit, since I'm setting the realtime priority of a different process. However since rtkit will validate the pid/tid, userid and starting time independently, so it is guaranteed that we won't be able to ddos. wine-rtkit.patch has to be applied to wine. the rtkit patch to rtkit. Of course it's still a proof of concept. If AJ is interested in merging this after rtkit has merged a patch, then I will clean up the hardcoded dlopen. ;) Open for feedback. Cheers, Maarten

1 0

re: cmd: Fix builtin for with /f parameter
by Dan Kegel 24 Apr '10

24 Apr '10

Thanks. Can you add a test, too, please? 'Just' add a section to test_builtins.cmd and the corresponding expected output to test_builtins.exp.

1 0

Internet Explorer in Wine
by Detlef Riekenberg 23 Apr '10

23 Apr '10

I test sometimes native IE in Wine with the least possible changes. With my implementation of shlwapi,SHCreateThreadRef this week, the native IE UI came up in Wine, using our shell replacement, mshtml with gecko and all that low level stuff: http://www.myimg.de/?img=ieinwineef89e.png The related COM interfaces for the IE Style UI are implemented in shdocvw (IWebBrowser and IInternetExplorer) and browseui (for user elements: Menu, Addressbar) You need to copy shdocvw.dll, browseui.dll and browselc.dll to ~/.wine_drive_c/windows/system32/ and override shdocvw and browseui to native. (native browseui.dll needs browselc.dll) It works, but it's unstable and the Menu as well as the Addressbar are absend (not registered in Wine). register browseui.dll (or use regedit for minimal changes) "Menu Band" CLSID: {5b4dae26-b807-11d0-9815-00c04fd91972} InProcServer32 is "%systemroot%\system32\browseui.dll" and ThreadingModel is Apartment "Address" has CLSID {01E04581-4EEE-11D0-BFE9-00AA005B4383} InProcServer32 is "%systemroot%\system32\browseui.dll", ThreadingModel is Apartment and Implemented Categories need the subkey {00021492-0000-0000-C000-000000000046} (IE8 has still the full IE6 style UI available) Happy testing, and don't forget to fill bugzilla. -- By by ... Detlef

1 0

Re: [1/2] imm32: Fix ImmAssociateContextEx Parameter Handling
by Nikolay Sivov 23 Apr '10

23 Apr '10

On 4/23/2010 16:14, André Hentschel wrote: > --- > dlls/imm32/imm.c | 13 ++++++++++--- > dlls/imm32/tests/imm32.c | 8 ++++---- > 2 files changed, 14 insertions(+), 7 deletions(-) > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 2a85b70..2fd6477 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -516,12 +516,19 @@ static BOOL CALLBACK _ImmAssociateContextExEnumProc(HWND hwnd, LPARAM lParam) > */ > BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > { > - TRACE("(%p, %p, %d): stub\n", hWnd, hIMC, dwFlags); > + TRACE("(%p, %p, 0x%x):\n", hWnd, hIMC, dwFlags); > > if (!IMM_GetThreadData()->defaultContext) > IMM_GetThreadData()->defaultContext = ImmCreateContext(); > > - if (dwFlags == IACE_DEFAULT) > + if (!hWnd) return FALSE; > + > + if (!dwFlags) > + { > + ImmAssociateContext(hWnd,hIMC); > + return TRUE; > + } > + else if (dwFlags == IACE_DEFAULT) > { > ImmAssociateContext(hWnd,IMM_GetThreadData()->defaultContext); > return TRUE; > @@ -539,7 +546,7 @@ BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > } > else > { > - ERR("Unknown dwFlags 0x%x\n",dwFlags); > + FIXME("Unknown dwFlags 0x%x\n",dwFlags); > return FALSE; > } > } > Some comments for this. Why return value from ImmAssociateContext is never used? Also it nicely turns to switch() for this dwFlags parameter, but it's a matter of taste.

1 0

DNS-sd Patch V.4
by C.W. Betts 23 Apr '10

23 Apr '10

Due to the fact that Mac OS X has the dns-sd functions in it's main library (libSystem.B.dylib), I thought it unwise to try to unload it. This patch The Photoshop CS3 installer seems to stall during installation due to the lack of Bonjour (bug 15590). This patch attempts to fix it.

3 4

Re: Intercept relay_call causes seh:raise_exception code=c0000005
by Jui-Hao Chiang 22 Apr '10

22 Apr '10

Hi, All: I also find out 2 special things (1) The address of the array which causes the exception happens to be the memory-mapped address of comctl32.dll (check the /proc/../smaps) (2) If the address of the array is pointing to heap (from my malloc), or some other places which are not occupied by any dll, then "no" exception will occur Originally I doubt the exception may be the bug of the RPC library I am using (libc6-dev package inside Ubuntu). However, if that's the case, my malloc pointer should also cause exception (but it doesn't) Still hope someone can give a hint on how to debug this question Best wishes, Jui-Hao > > Message: 11 > Date: Wed, 21 Apr 2010 09:37:53 -0400 > From: Jui-Hao Chiang <windtracekimo(a)gmail.com> > Subject: Intercept relay_call causes seh:raise_exception code=c0000005 > To: wine-devel(a)winehq.org > Message-ID: > <i2h52cf60ee1004210637gc7f20e5dq9b958127331b18cf(a)mail.gmail.com> > Content-Type: text/plain; charset=ISO-8859-1 > > Hi, All, I am currently using the WINEDEBUG=relay feature to intercept > function calls as the following > > 1. in dlls/ntdll/relay.c, insert code snippet in > static LONGLONG WINAPI relay_call( struct relay_descr *descr, unsigned > int idx, const INT_PTR *stack ) > { > ..... > my_own_function(entry_point->name, nb_args stack); /* added by myself */ > ret = call_entry_point( entry_point->orig_func, nb_args, stack + 1 ); > /* original Wine code*/ > .... > } > > LONGLONG > my_own_function(const char *funcname, int nb_args, const INT_PTR *stack) > { > /* CreateBitmap has 5 parameters, the 5th one is pointing to an array > while others are native type as the following > HBITMAP WINAPI CreateBitmap( INT width, INT height, UINT planes, > UINT bpp, LPCVOID bits ) > */ > if (strcmp(funcname, "CreateBitmap") == 0) > Rpc_CreateBitmap(*(stack+1), *(stack+2), *(stack+3), > *(stack+4), *(stack+5)); // this function just try to forward all > parameters to remote RPC server for record > } > > 2. Run program with WINEDEBUG=trace+all,relay wine notepad > dump 2>&1 > 3. If I only pass the parameter 1 to 4 to Rpc_CreateBitmap, then there > is no problem, but if I add the 5th one (which points to some array), > then the notepad aborts with he following debug message > > 0009:Call gdi32.CreateBitmap(00000008,00000008,00000001,00000001,7e95d822) > ret=7e8da083 > 0009:trace:seh:raise_exception code=c0000005 flags=0 addr=0xb754a21d > ip=b754a21d tid=0009 > 0009:trace:seh:raise_exception info[0]=00000001 > 0009:trace:seh:raise_exception info[1]=7e95d822 > 0009:trace:seh:raise_exception eax=00000055 ebx=b7593ff4 ecx=0033fa4c > edx=00000001 esi=7e95d822 edi=00000001 > 0009:trace:seh:raise_exception ebp=0033fa54 esp=0033fa44 cs=0073 > ds=007b es=007b fs=0033 gs=003b flags=00010202 > 0009:trace:seh:call_vectored_handlers calling handler at 0x7b83fd50 > code=c0000005 flags=0 > 0009:trace:seh:call_vectored_handlers handler at 0x7b83fd50 returned 0 > 0009:trace:seh:call_stack_handlers calling handler at 0x7bc4a480 > code=c0000005 flags=0 > 0009:trace:seh:__regs_RtlUnwind code=c0000005 flags=2 > 0009:trace:seh:__regs_RtlUnwind calling handler at 0x7bc6bc50 > code=c0000005 flags=2 > 0009:trace:seh:__regs_RtlUnwind handler at 0x7bc6bc50 returned 1 > 0009:exception in PE entry point > (proc=0x7e95a890,module=0x7e8c0000,reason=PROCESS_ATTACH,res=0x1) > > 4. But if I use malloc to copy the content of the array pointed by 5th > parameter, then there is no problem > LONGLONG > my_own_function(const char *funcname, int nb_args, const INT_PTR *stack) > { > char *buffer = NULL; > if (strcmp(funcname, "CreateBitmap") == 0) { > buffer = (char*)malloc(.....); > memcpy(buffer, *(stack+5), ....); > Rpc_CreateBitmap(*(stack+1), *(stack+2), *(stack+3), > *(stack+4), buffer); /* No exception if I do this */ > } > > Can anyone gives me a hint that what's happening here? or I am doing > some illegal operations? > Appreciate any comments, > Jui-Hao >

2 2

Re: imm32: Add tests for ImmAssociateContextEx (try 2)
by Alexandre Julliard 22 Apr '10

22 Apr '10

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/imm32/tests/imm32.c | 56 +++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 51 insertions(+), 5 deletions(-) It fails here: ../../../tools/runtest -q -P wine -M imm32.dll -T ../../.. -p imm32_test.exe.so imm32.c && touch imm32.ok imm32.c:350: Test succeeded inside todo block: ImmAssociateContextEx failed make[1]: *** [imm32.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10/tests: [Resend] add tests for CR and LF chars and remove some trailing white space
by Alexandre Julliard 22 Apr '10

22 Apr '10

Jeff Latimer <lats(a)yless4u.com.au> writes: > The presence of numerics, linefeeds and carriage returns etc causes a > new ScriptItem to be created. This patch tests that ScriptItems are > created for LF and CR characters. It also tidies up the test strings > and removes whitepace. It fails here: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:804: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14) usp10.c:807: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (2076397231) usp10.c:810: Test failed: Start pos [4] not = 13 (2076397231) or end [5] pos not = 16 (0), cInChars = 14 usp10.c:834: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 make[1]: *** [usp10.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

Writing test programs for dlls/krnl386.exe16
by Morten Rønne 21 Apr '10

21 Apr '10

Hi I would like to write some tests for the krnl386.exe16 part of wine, or more precisely the DOS parts of that. But there is no starting point at the moment. As far as I can understand other tests are run as 32/64 bit programs, which makes sense since they test the 32/64 parts of wine. But in order to test the DOS part I need to run as 16 bit (32 bit might be ok) and use the old style int 21h functions and so on. A "simple" solution to this would be to create a 32 bit program which executes the 16 bit DOS program through a fitting 32 bit windows call. The 16 bit program writes a file which the 32 bit program reads in order to do the reporting. So what I have been trying to find out, is how to create programs that do exactly that. For the windows part I hope this should be able to startup a 16 bit program: memset(&si, 0, sizeof(si)); si.cb = sizeof(si); if (CreateProcessA(NULL, name, NULL, NULL, FALSE, 0, NULL, NULL, &si, &pi)) { CloseHandle(pi.hThread); CloseHandle(pi.hProcess); if(read_test_file()) return TRUE; } For the DOS part the most logical thing would be to use assembler langage, as this will allow me to write the most specific tests and know what is being tested. It might also be possible to find various "old" education samples or other tests that might form a base for testing. I have no problem writing the programs in assembler. The assembler can be done 2 ways as I see it, as true assembler (e.g. nasm or something like that) or written as inline assembler in a C program. I am not sure which method is best for wine. The other problems is how to link the programs into an executable DOS program. So far my searching on the internet hasn't provided me with anything that I could use. So I looking for input on this work and how to move forward. Can anyone give me some pointers on how to do this (within the wine enviroment)? Can mingw used for the cross compiling also be used for this, given the correct parameters? I believe that the tests should be able to be skipped if a proper enviroment isn't present, in case the building of the test requires something extra, .e.g, an assembler otherwise not needed for wine. Best Regards Morten Rønne

2 5

Graphics Driver Interface Standardization
by Charles Davis 21 Apr '10

21 Apr '10

Hi, I'm getting ready to implement the Quartz Driver. For those of you who don't know, this is a special graphics driver that only works on Mac OS X, and uses its native Core Graphics (aka, Quartz) system to draw. But before I can do this, there are two things that need to be done: 1. Wine currently assumes that the current graphics driver is the X11 driver. It directly GetModuleHandle()'s winex11.drv in order to call driver functions. This needs to be fixed. 2. The driver interface needs to be standardized. I can fix the first problem by adding a Wine-specific export to GDI32, then updating all the winex11 clients to call this function, but the second problem will make writing a non-X11 driver problematic. The GDI and USER interfaces are already somewhat standardized, but the reason many clients call winex11.drv directly is to call the "Thread-Safe X11" locking routines. Also, Explorer calls winex11 to create the desktop and notification area ("systray") windows. Therefore, I propose this interface. It's largely based off of winex11, but with some small modifications. It's attached to this mail. What do you think of this? And don't tell me that we need a DIB engine before I get started on winequartz. I intend to use Mac OS X native APIs (like Core Image) to accelerate DIBs, in much the same way winex11 uses Xrender. Chip

2 1

OPOS in wine
by Joni Salmela 21 Apr '10

21 Apr '10

Hello all mighty wine people..... this might not be the best place to do this and for that I apologize for this inconvenience... anyway I am about to try to configure OPOS in ubuntu 9.10 karmic using wine since most of the printer drivers etc... are executed in the user space and the OPOS itself just contains a series of interfaces registered to the good old COM server... I have had some success so far with a laptop.. but now I am about to get my hands into a real reception computer a one I am in liberty to install a Linux on it.. so what I would like to ask is any pointers and stuff or if anybody has already done this with success if have I have not found any leads on it... anyway thanks in advance Joni Salmela PS if this really is the wrong place to post stuff like this would please correct me then thanks again

2 1

Fwd: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx.
by Alexander Scott-Johns 21 Apr '10

21 Apr '10

Forgot to Reply All ---------- Forwarded message ---------- From: Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> Date: 21 April 2010 16:40 Subject: Re: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx. To: Dmitry Timoshkov <dmitry(a)codeweavers.com> On 21 April 2010 16:08, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> wrote: > >> Using GetCPInfoEx was a nice idea, but unfortunately its output is not >> localized, and on Windows, the codepage identifier is tacked on the beginnning. > > You should fix GetCPInfoEx instead, it returns localized strings under Windows. > Same comment for your other patch. I don't think Windows Notepad uses GetCPInfoEx either, and on my Windows XP box, Wine Notepad's menu ended up looking something like: 1252 ANSI Latin 1 Unicode (UTF-16) Unicode (UTF-16 big-endian) 65001 Unicode (UTF-8) Yes, GetCPInfoEx should be fixed. But Wine Notepad will still be slightly broken.

1 0

Re: user32: Add BM_SETSTATE/BM_SETCHECK message tests for a button, make them pass under Wine.
by Greg Geldorp 21 Apr '10

21 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1645 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

3 3

Re: dlls/d3dx9_36/shader.c: replace malloc with HeapAlloc
by Henri Verbeet 21 Apr '10

21 Apr '10

On 21 April 2010 17:19, Joris Huizer <joris_huizer(a)yahoo.com> wrote: > - path = malloc(strlen(filename) + 1); > + path = HeapAlloc(GetProcessHeap(), 0, strlen(filename) + 1); No, malloc() is correct, wpp frees it again with free().

1 0

Re: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx.
by Dmitry Timoshkov 21 Apr '10

21 Apr '10

Alexander Scott-Johns <alexander.scott.johns(a)googlemail.com> wrote: > Using GetCPInfoEx was a nice idea, but unfortunately its output is not > localized, and on Windows, the codepage identifier is tacked on the beginnning. You should fix GetCPInfoEx instead, it returns localized strings under Windows. Same comment for your other patch. -- Dmitry.

1 0

Re: [1/2] include/wine: add option to specify the unittest target via environment variable
by Paul Vriens 21 Apr '10

21 Apr '10

On 04/19/2010 11:44 PM, Stefan Leichter wrote: > --- > include/wine/test.h | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > Hi Stefan, What's the idea/thought behind this (or what problem are you trying to solve)? -- Cheers, Paul.

3 6

Re: [PATCH] msiexec: Use resource in msi for a Help Dialog to allow translation
by Hans Leidekker 21 Apr '10

21 Apr '10

On Wed, 2010-04-21 at 16:18 +0200, Detlef Riekenberg wrote: > static void ShowUsage(int ExitCode) > { > - printf(UsageStr); > + WCHAR msiexec_version[40]; > + WCHAR msiexec_help[4096]; > + WCHAR msi_res[4050]; You should use dynamically sized heap buffers here.

1 0

Re: [1/2] include: Add asptlb.idl (try 2)
by Michael Stefaniuc 21 Apr '10

21 Apr '10

Hello Alistair, Alistair Leslie-Hughes wrote: > Change long -> LONG thanks but that isn't really necessary. "long" is always 32bits in IDL files. widl will replace that with LONG in the generated files. > Changelog: > include: Add asptlb.idl bye michael

1 0

Re: (resend) imm32: rework storage of thread default contexts
by Alexandre Julliard 21 Apr '10

21 Apr '10

Aric Stewart <aric(a)codeweavers.com> writes: > any thread needs to be able to access the default context for any > other thread in the process for ImmGetContext. This looks very suspicious, and not at all thread-safe. There has to be a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Intercept relay_call causes seh:raise_exception code=c0000005
by Jui-Hao Chiang 21 Apr '10

21 Apr '10

Hi, All, I am currently using the WINEDEBUG=relay feature to intercept function calls as the following 1. in dlls/ntdll/relay.c, insert code snippet in static LONGLONG WINAPI relay_call( struct relay_descr *descr, unsigned int idx, const INT_PTR *stack ) { ..... my_own_function(entry_point->name, nb_args stack); /* added by myself */ ret = call_entry_point( entry_point->orig_func, nb_args, stack + 1 ); /* original Wine code*/ .... } LONGLONG my_own_function(const char *funcname, int nb_args, const INT_PTR *stack) { /* CreateBitmap has 5 parameters, the 5th one is pointing to an array while others are native type as the following HBITMAP WINAPI CreateBitmap( INT width, INT height, UINT planes, UINT bpp, LPCVOID bits ) */ if (strcmp(funcname, "CreateBitmap") == 0) Rpc_CreateBitmap(*(stack+1), *(stack+2), *(stack+3), *(stack+4), *(stack+5)); // this function just try to forward all parameters to remote RPC server for record } 2. Run program with WINEDEBUG=trace+all,relay wine notepad > dump 2>&1 3. If I only pass the parameter 1 to 4 to Rpc_CreateBitmap, then there is no problem, but if I add the 5th one (which points to some array), then the notepad aborts with he following debug message 0009:Call gdi32.CreateBitmap(00000008,00000008,00000001,00000001,7e95d822) ret=7e8da083 0009:trace:seh:raise_exception code=c0000005 flags=0 addr=0xb754a21d ip=b754a21d tid=0009 0009:trace:seh:raise_exception info[0]=00000001 0009:trace:seh:raise_exception info[1]=7e95d822 0009:trace:seh:raise_exception eax=00000055 ebx=b7593ff4 ecx=0033fa4c edx=00000001 esi=7e95d822 edi=00000001 0009:trace:seh:raise_exception ebp=0033fa54 esp=0033fa44 cs=0073 ds=007b es=007b fs=0033 gs=003b flags=00010202 0009:trace:seh:call_vectored_handlers calling handler at 0x7b83fd50 code=c0000005 flags=0 0009:trace:seh:call_vectored_handlers handler at 0x7b83fd50 returned 0 0009:trace:seh:call_stack_handlers calling handler at 0x7bc4a480 code=c0000005 flags=0 0009:trace:seh:__regs_RtlUnwind code=c0000005 flags=2 0009:trace:seh:__regs_RtlUnwind calling handler at 0x7bc6bc50 code=c0000005 flags=2 0009:trace:seh:__regs_RtlUnwind handler at 0x7bc6bc50 returned 1 0009:exception in PE entry point (proc=0x7e95a890,module=0x7e8c0000,reason=PROCESS_ATTACH,res=0x1) 4. But if I use malloc to copy the content of the array pointed by 5th parameter, then there is no problem LONGLONG my_own_function(const char *funcname, int nb_args, const INT_PTR *stack) { char *buffer = NULL; if (strcmp(funcname, "CreateBitmap") == 0) { buffer = (char*)malloc(.....); memcpy(buffer, *(stack+5), ....); Rpc_CreateBitmap(*(stack+1), *(stack+2), *(stack+3), *(stack+4), buffer); /* No exception if I do this */ } Can anyone gives me a hint that what's happening here? or I am doing some illegal operations? Appreciate any comments, Jui-Hao

1 0

Re: Minor dlls/mshtml/htmlbody.c simplification
by Jacek Caban 21 Apr '10

21 Apr '10

Hi Gerald, On 4/21/10 1:45 PM, Gerald Pfeifer wrote: > ChangeLog: > Remove variable hres which is not really used from HTMLBodyElement_get_text. > > diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c > index 5c66e65..c6b202b 100644 > --- a/dlls/mshtml/htmlbody.c > +++ b/dlls/mshtml/htmlbody.c > @@ -443,7 +443,6 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > HTMLBodyElement *This = HTMLBODY_THIS(iface); > nsAString text; > nsresult nsres; > - HRESULT hres; > > TRACE("(%p)->(%p)\n", This, p); > > @@ -454,10 +453,8 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT > > nsAString_GetData(&text,&color); > V_VT(p) = VT_BSTR; > - hres = nscolor_to_str(color,&V_BSTR(p)); > }else { > ERR("GetText failed: %08x\n", nsres); > - hres = E_FAIL; > } > > nsAString_Finish(&text); > hres should be returned in this case, not removed. Jacek

1 0

Re: [2/2] msxml3: Rewrite IXMLDOMDocument2 save to behave more like msxml3
by Nikolay Sivov 21 Apr '10

21 Apr '10

On 4/21/2010 13:14, Alistair Leslie-Hughes wrote: > + ret = IUnknown_QueryInterface(pUnk,&IID_IUnknown, (void**)&pUnkRemote); > There's no point to do it. You already have IUnknown pointer. It's better to remove test for that case I think.

1 0

Re: [2/2] msxml3: Rewrite IXMLDOMDocument2 save to behave more like msxml3
by Nikolay Sivov 21 Apr '10

21 Apr '10

On 4/21/2010 07:13, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Rewrite IXMLDOMDocument2 save to behave more like msxml3 > > Best Regards > Alistair Leslie-Hughes > > > Hi, you forgot a patch.

1 0

Re: [PATCH 4/6] [WineGcc]: when specifying -m32, force i386 cpu when compiling on x86_64 boxes
by André Hentschel 21 Apr '10

21 Apr '10

Hi Eric, That will not be enough as it will still just find the 64-bit libs. Maybe we should implement a check in utils.c if it is a ELF32 or ELF64 lib which we try to import. -- Best Regards, André Hentschel

3 2

Re: winex11: use XkbKeycodeToKeysym instead of (deprecated) XKeycodeToKeysym (see http://bugs.freedesktop.org/show_bug.cgi?id=5349)
by Dmitry Timoshkov 21 Apr '10

21 Apr '10

Alexandre Goujon <ale.goujon(a)gmail.com> wrote: > - if (!(keysym = XKeycodeToKeysym (display, keyc, i))) continue; > + if (!(keysym = XkbKeycodeToKeysym (display, keyc, 0, i))) continue; Not every X11 implementation has the XKB extenstion. You may want to take into account 'use_xkb' and 'HAVE_XKB'. -- Dmitry.

1 0

Adding translation for wineprefixcreate manpage
by Frédéric Delanoy 20 Apr '10

20 Apr '10

Hi folks, A couple of days ago, I submitted a patch to add French manpage of wineprefixcreate, which was discarded (see attachment). I modeled it after German winemaker addition (SHA d53e75af1474d0bd9c8b8660827baaf8fe708f4c) by adding - entries in tools/Makefile.in - a .gitignore entry for the generated manpage - actual translated manpage I guess the patch was refused because of problems in tools/Makefile.in. Basically what I added was - entry in MANPAGES - french dir in INSTALLDIRS - entries in "install install-lib" and "install install-dev" - uninstall entry In the process, I also added the wineprefixcreate En manpage in the "install install-dev". Is that problematic? Could so please tell me what I did wrong so I can fix and resubmit the patch? Thanks in advance. Frédéric

2 1

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests
by Tony Wasserka 20 Apr '10

20 Apr '10

> +static inline void check_ref(IUnknown *obj, int exp) > +static inline void check_release(IUnknown *obj, int exp) We shouldn't use these function definitions anymore IMO, either do the ref check in the code itself, or replace the check_ref and check_release functions with macros; the reason is that if there really is a test error, the given line refers to the function source and thus won't help us at all, i.e. before actually examining an error you'd first have to find out what check actually failed... Also I'm not too sure whether it's necessary to include resources.h ... > + if (SUCCEEDED(hr)) { > + if (*format == D3DFMT_UNKNOWN || *format == D3DX_DEFAULT) *format = D3DFMT_A8R8G8B8; > + > + hr = IDirect3D9_CheckDeviceFormat(d3d, params.AdapterOrdinal, params.DeviceType, mode.Format, usage, > + D3DRTYPE_TEXTURE, *format); > + } > + > + if (d3d) > + IDirect3D9_Release(d3d); > + > + if (FAILED(hr)) > + return D3DERR_INVALIDCALL; Maybe we should add a FIXME within that if (FAILED(hr)), since that part is something which still needs to be implemented. Best regards, Tony

2 3

ImageCapture Wine TWAIN plug-in
by C.W. Betts 20 Apr '10

20 Apr '10

Anybody else up for the idea of an ImageCapture (Mac OS X) plug-in for Wine's TWAIN? It would fit the role of sane.ds and gphoto.ds, as it can both scan and access cameras. ImageCapture can also use Mac OS X TWAIN drivers.

1 0

Re: imm32: rework storage of thread default contexts
by André Hentschel 20 Apr '10

20 Apr '10

Hi Aric, You should have a second look at the Function heads in the tests (imm32.c). I doubt WINAPI should be used and the functions should be static. -- Best Regards, André Hentschel

2 1

Re: [2/2] dlls/shell32/tests: add some tests for ShellExecuteEx
by Greg Geldorp 20 Apr '10

20 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1612 Your paranoid android. === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === Timeout === W7PROX64 (Windows 7 Professional 64 bit) === shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2 shlexec.c:1662: Test failed: ShellExecuteEx(null, "C:\Users\winetest\AppData\Local\Temp\wt6C9.tmp\test file.sde", null, null) failed: rc=29 err=2

1 0

Re: [shell32/tests] Fix a test failure on Windows 2000
by Paul Vriens 20 Apr '10

20 Apr '10

On 04/19/2010 08:22 PM, Paul Vriens wrote: > Hi, > > NT4 and lower don't run these tests so maybe it should be "shell32 5.0 > and lower" instead of "Windows 2000". > > This one was reported by the testbot to wine-devel btw. > > Changelog > Fix a test failure on Windows 2000 > Please ignore this one. Nikolay will sent a better fix -- Cheers, Paul.

1 0

Future of the WWN
by Zachary Goldberg 19 Apr '10

19 Apr '10

Hey folks. I plan on releasing one WWN per Wine release which at a minimum will include a very short news section and the bugzilla/appdb stats. I will also be "crown sourcing" news via the Wine Wiki: http://wiki.winehq.org/RecentNewsQueue. If you would like to get a news article into the WWN please add your post there and please do not forget to add your name for attribution! Thanks, Zach

2 2

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more
by Maarten Lankhorst 19 Apr '10

19 Apr '10

Hi Marcus, 2010/4/19 Marcus Meissner <meissner(a)suse.de>: > Hi, > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > For MMX/SSE operations we however need to have the stack aligned > to 16 (2^4). > > So specify this explicitly. > > (This should probably be even part of attribute((stdcall)) perhaps > in gcc. Not sure though.) Are you sure this is the case in win64 too? I'd assume that it would probably be 16 byte aligned there, since the first 4 arguments would be passed in registers and it could ensure stack alignment since they owned the abi from the start. If not it would definitely be 8. Cheers, Maarten

2 1

Re: winecfg: Add SP2 for Vista
by Austin English 19 Apr '10

19 Apr '10

2010/4/19 André Hentschel <nerv(a)dawncrow.de>: > Internet Explorer 9 Preview needs it. > --- > programs/winecfg/appdefaults.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/appdefaults.c b/programs/winecfg/appdefaults.c > index 8d28b0a..cf07fe8 100644 > --- a/programs/winecfg/appdefaults.c > +++ b/programs/winecfg/appdefaults.c > @@ -50,7 +50,7 @@ static const struct > { > { "win7", "Windows 7", 6, 1, 0x1DB0,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, > { "win2008", "Windows 2008", 6, 0, 0x1771,VER_PLATFORM_WIN32_NT, "Service Pack 1", 0, 0, "ServerNT"}, > - { "vista", "Windows Vista", 6, 0, 0x1770,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, > + { "vista", "Windows Vista", 6, 0, 0x1772,VER_PLATFORM_WIN32_NT, "Service Pack 2", 2, 0, "WinNT"}, > { "win2003", "Windows 2003", 5, 2, 0xECE, VER_PLATFORM_WIN32_NT, "Service Pack 1", 1, 0, "ServerNT"}, > { "winxp", "Windows XP", 5, 1, 0xA28, VER_PLATFORM_WIN32_NT, "Service Pack 3", 3, 0, "WinNT"}, > { "win2k", "Windows 2000", 5, 0, 0x893, VER_PLATFORM_WIN32_NT, "Service Pack 4", 4, 0, "WinNT"}, Please change dlls/ntdll/version.c to keep them in sync. -- -Austin

1 0

Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests
by Henri Verbeet 19 Apr '10

19 Apr '10

On 19 April 2010 09:43, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +BOOL is_pow2(UINT num) > +{ > + UINT i; > + > + if (!num) return FALSE; > + for (i = 0; num >> 1; i++) num >>= 1; > + > + return (num << i) == num; > +} This should at least be static. You can also just replace it with "return !(num & (num - 1));". You don't care about 0, since you already check that earlier in D3DXCheckTextureRequirements(). make_pow2() can probably be simplified as well.

4 5

ISP causes winhttp test failures
by Stefan Dösinger 19 Apr '10

19 Apr '10

Hi, I get winhttp test failures on all my machines: http://test.winehq.org/data/780981bc7a2c8e173bea580a2d748fd7cb242468/wine_s… I suspect my ISP is to blame. When try to resolve a nonexistant domain name I don't get an error, instead I get a search page: http://suche.upc.at/upcatassist/dnsassist/main/?domain=www.sreaverwdoc.moc $ ping www.sreaverwdoc.moc PING www.sreaverwdoc.moc (67.63.50.48): 56 data bytes Request timeout for icmp_seq 0 ... Verisign was once ordered not to this. But that was in the US. What should we do about this error? I don't think there's any way I can get a DNS error back from my stupid provider :-/ Stefan

6 8

Re: Jacek Caban : jscript: Fixed String. match implementation for non-global regexps.
by Paul Chitescu 19 Apr '10

19 Apr '10

On Thursday 15 April 2010 07:37:36 pm Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 6f17fa5298449114a8532778b8a6c0f8a5c505de > URL: http://source.winehq.org/git/wine.git/?a=commit;h=6f17fa5298449114a8532778b… > > Author: Jacek Caban <jacek(a)codeweavers.com> > Date: Thu Apr 15 12:38:38 2010 +0200 > > jscript: Fixed String.match implementation for non-global regexps. > > --- > > dlls/jscript/jscript.h | 1 + > dlls/jscript/regexp.c | 81 ++++++++++++++++++++++++++++++++++++++++++ > dlls/jscript/string.c | 59 +++++------------------------- > dlls/jscript/tests/regexp.js | 27 ++++++++++++++ > 4 files changed, 119 insertions(+), 49 deletions(-) This patch is somehow b0rked in CVS. regexp.c and tests/regexp.js were commited and then reverted. Is it possible to have them synched back to git? Thanks, Paul Chitescu

2 1

wine in press
by Stefan Leichter 19 Apr '10

19 Apr '10

Hi, while reading the german heise news i came across an article about wine. Luckily there is an english version too: http://www.h-online.com/open/news/item/Wine-update-improves-Direct3D-and-64… german version: http://www.heise.de/open/meldung/Wine-mit-verbesserter-3D-und-64-Bit-Unters… Bye Stefan

1 0

Re: winmm: Rewrite time.c using windows timer queues
by Alexandre Julliard 19 Apr '10

19 Apr '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -50,16 +33,14 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(mmtime); > > -typedef struct tagWINE_TIMERENTRY { > - struct list entry; > - UINT wDelay; > - UINT wResol; > - LPTIMECALLBACK lpFunc; /* can be lots of things */ > - DWORD_PTR dwUser; > - UINT16 wFlags; > - UINT16 wTimerID; > - DWORD dwTriggerTime; > -} WINE_TIMERENTRY, *LPWINE_TIMERENTRY; > +typedef struct { > + struct list entry; /* must be first item */ There's no reason that it needs to be the first item if you use the list macros correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] shlwapi: Implement SHCreateThreadRef
by Alexandre Julliard 19 Apr '10

19 Apr '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -120,6 +120,89 @@ typedef struct tagSHLWAPI_THREAD_INFO > IUnknown *refIE; /* Reference to the IE process */ > } SHLWAPI_THREAD_INFO, *LPSHLWAPI_THREAD_INFO; > > +typedef struct > +{ > + void* lpVtbl; > + LONG *ref; > +} threadref; You need to use correct pointer types, a vtbl is not a void*. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/6] msi: Add beginnings of a test module that concentrates on patches.
by Greg Geldorp 19 Apr '10

19 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1590 Your paranoid android. === W7PROX64 (Windows 7 Professional 64 bit) === patch.c:696: Test failed: expected 1000, got 0 patch.c:709: Test failed: expected 1002, got 0

1 0

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more
by Alexandre Julliard 19 Apr '10

19 Apr '10

Marcus Meissner <meissner(a)suse.de> writes: > Hi, > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > For MMX/SSE operations we however need to have the stack aligned > to 16 (2^4). > > So specify this explicitly. > > (This should probably be even part of attribute((stdcall)) perhaps > in gcc. Not sure though.) It needs to be the default in gcc. It's not specific to stdcall or to Wine, there's plenty of Linux code that doesn't align the stack either. gcc can't start generating code that assumes 16-byte alignment on Linux. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [8/11] shell32: Complete IFolderView::ItemCount() implementation
by Greg Geldorp 19 Apr '10

19 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1576 Your paranoid android. === WVISTAADM (Windows Vista (English, IE7)) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W2K8SE (Server 2008 Standard Edition) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W7PRO (Windows 7 Professional (English, IE8)) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W7PROX64 (Windows 7 Professional 64 bit) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000 === W7PROX64 (Windows 7 Professional 64 bit) === shlview.c:629: Test failed: IFolderView::ItemCount - SVGIO_ALLVIEW: the msg sequence is not complete: expected 1004 - actual 0000 shlview.c:635: Test failed: IFolderView::ItemCount - SVGIO_SELECTION: the msg sequence is not complete: expected 1032 - actual 0000 shlview.c:641: Test failed: IFolderView::ItemCount - SVGIO_BACKGROUND: the msg sequence is not complete: expected 1004 - actual 0000

1 0

Re: [5/11] shell32: Load shell folder column names as A/W strings depending on 9x/NT selector
by Greg Geldorp 19 Apr '10

19 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1574 Your paranoid android. === W2KPROSP4 (Windows 2000 Professional SP4) === shfldr_special.c:188: Test failed: got 0x80004001 shfldr_special.c:189: Test failed: got 2294136

1 0

TestBot changes
by Greg Geldorp 19 Apr '10

19 Apr '10

I've made a bunch of changes to TestBot, aimed at improving its reliability for processing wine-patches submissions and preventing false positives (where the bot incorrectly claims a patch introduces a new failure.) For the moment it won't send error reports directly to wine-devel, instead it sends them to me and I'll manually forward after checking. - Skip tests if required DLL is not available Previously, when running e.g. urlmon_test.exe on NT4, the test would fail to start if a statically imported DLL (urlmon.dll in the NT4 case) was not present on the system. Eventually the test would time out and this would be registered as a failure. The new behavior is to skip the test entirely and not treat it as a failure (this is the same behavior as that of winetest-latest.exe.) - Add support for programs tests We've had cmd tests in programs/cmd/tests for a while now, patches to these tests were not handled properly. This should be fixed now (and obviously not only for programs/cmd but for any test under programs/.) - Avoid false positives when comparing logs The bot tries to figure out whether new errors have been introduced by a patch. It does this by comparing the log generated by running the patched test against the log from the last winetest-latest.exe run. If there are new "Test failed" lines they will be flagged as new errors. When searching for these new lines, we have to disregard the source line numbers that are present in the log lines (log lines have the form "testfile.c:999: Test failed: Description"), since the source line numbers can easily change if the patch adds or removes lines near the start of the file. - Use both author email address and max patch number for set determination We discussed this last week, this should be an improvement but still does not catch all possible scenarios. - Run intermediate tests too When submitting a 4 part set, where part 2 and 3 contain changes to a test, we'd previously wait until all 4 parts were available, create one big patch file out of parts 1-4, apply that and run the tests. Now, we'll detect that part 2 contains a test change, apply 1-2 and run tests. Then when part 3 becomes available we detect that it too contains a test change, apply 1-3 and run tests again. More TestBot changes to come. Ge.

2 3

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more
by Marcus Meissner 19 Apr '10

19 Apr '10

On Sun, Apr 18, 2010 at 04:28:54PM -0600, Charles Davis wrote: > On 4/18/10 4:17 PM, Marcus Meissner wrote: > > Hi, > > > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > > For MMX/SSE operations we however need to have the stack aligned > > to 16 (2^4). > > > > So specify this explicitly. > > > > (This should probably be even part of attribute((stdcall)) perhaps > > in gcc. Not sure though.) > From windef.h: > > # ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a > 4-byte one */ > # define __stdcall __attribute__((__stdcall__)) > __attribute__((__force_align_arg_pointer__)) > # else > # define __stdcall __attribute__((__stdcall__)) > # endif > > Maybe then it's time we got rid of the #ifdef __APPLE__ block, then, and > used the OS X definition everywhere? Or, we could use your switch, and > that would obviate the need for __force_align_arg_pointer__ with gcc > (but not clang, because it doesn't implement that switch yet). Hmm. Sounds like an idea. I will test and send a patch. Ciao, Marcus

1 0

Re: [PATCH 2/8] urlmon/tests: CoInternetCreateZoneManager not present on W95B
by Paul Vriens 19 Apr '10

19 Apr '10

On 04/16/2010 12:20 AM, Detlef Riekenberg wrote: > --- > dlls/urlmon/tests/sec_mgr.c | 29 +++++++++++++++++++++-------- > 1 files changed, 21 insertions(+), 8 deletions(-) > Hi Detlef, After this patch none of the tests are actually run on W95B and we have loads of win_skip's. Wouldn't it be better to just check for one (or all) and bail out with a (only one) win_skip()? I guess if one is not present, none are? -- Cheers, Paul.

2 2

d3dx9: Add a stubbed D3DXDeclaratorFromFVF
by David Adam 19 Apr '10

19 Apr '10

Hi, patch from Tony Wasserka. A+ David

1 0

my god, it's full of benchmarks
by Dan Kegel 19 Apr '10

19 Apr '10

Turns out everybody and his brother are writing game benchmarks and game benchmark tools. There are a whole mess of them at http://downloads.guru3d.com/Benchmarks-&-Demo's_c6.html which I'll probably take a look at sometime soon. Has anyone been running any of these (beyond the obvious 3dmarkXX's) on Wine?

1 0

Crash when executing custom action in msi
by Octavian Voicu 18 Apr '10

18 Apr '10

Hello, I'm trying to get the Adobe Photoshop Elements 8.0 installer to work and noticed the license screen doesn't show up when running the installer using wine. A trace shows that a custom action (CA_EULA_ExtractEulaFiles) generates a page fault. The cause of the crash is that MsiGetActiveDatabase is called on a remote handle that is actually a database handle (not a package handle as expected). A simple proof of concept would be to call this from a custom action handler in a dll: MsiGetActiveDatabase(MsiGetActiveDatabase(hPackage)); MsiGetActiveDatabase will call msi_get_remote and cast the result to IWineMsiRemotePackage, then call IWineMsiRemotePackage_GetActiveDatabase. Because our handle is actually a database handle, instead of calling mrp_GetActiveDatabase, it will call mrd_GetPrimaryKeys. This leads to a crash (see attached log). The correct behavior for MsiGetActiveDatabase is to return 0 when called with an invalid handle. I made a patch for this (also attached). In order to check if the com object is actually an IWineMsiRemotePackage, I compare the IUnknown->lpVtbl pointer against msi_remote_package_vtbl. This looks a bit messy, but I found no other way to do it. I'm posting the patch here for review first. Octavian

2 2

Re: [3/3]usp10/tests: add Thaana itemize tests
by Greg Geldorp 18 Apr '10

18 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1558 Your paranoid android. === W98SE (Windows 98 Second Edition) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel === W2KPROSP4 (Windows 2000 Professional SP4) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel === WXPPROSP3 (XP Professional SP3 (English, IE6)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W2K3R2SESP2 (Server 2003 R2 Standard Edition SP2) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === WVISTAADM (Windows Vista (English, IE7)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W2K8SE (Server 2008 Standard Edition) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W7PRO (Windows 7 Professional (English, IE8)) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:423: Test failed: Wrong fRTL usp10.c:424: Test failed: Wrong fLayoutRTL usp10.c:425: Test failed: Wrong BidiLevel usp10.c:436: Test failed: Wrong fRTL usp10.c:437: Test failed: Wrong fLayoutRTL usp10.c:438: Test failed: Wrong BidiLevel usp10.c:461: Test failed: Wrong fRTL usp10.c:462: Test failed: Wrong fLayoutRTL usp10.c:463: Test failed: Wrong BidiLevel usp10.c:470: Test failed: Wrong fRTL usp10.c:471: Test failed: Wrong fLayoutRTL usp10.c:472: Test failed: Wrong BidiLevel usp10.c:487: Test failed: Wrong fRTL usp10.c:488: Test failed: Wrong fLayoutRTL usp10.c:489: Test failed: Wrong BidiLevel usp10.c:500: Test failed: Wrong fRTL usp10.c:501: Test failed: Wrong fLayoutRTL usp10.c:502: Test failed: Wrong BidiLevel usp10.c:525: Test failed: Wrong fRTL usp10.c:526: Test failed: Wrong fLayoutRTL usp10.c:527: Test failed: Wrong BidiLevel usp10.c:534: Test failed: Wrong fRTL usp10.c:535: Test failed: Wrong fLayoutRTL usp10.c:536: Test failed: Wrong BidiLevel

1 0

Re: [PATCH 4/8] server: send the proper status code in case of socket error
by Greg Geldorp 18 Apr '10

18 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1520 Your paranoid android. === W7PROX64 (Windows 7 Professional 64 bit) === sock.c:3162: Test failed: Expected event sequence [FD_OOB(0) bad(65)], got [FD_OOB(0)]

2 1

Benchmarking D3D?
by Dan Kegel 18 Apr '10

18 Apr '10

I've added four benchmarks to wisotool: 3dmark03 3D Mark 03 (Futuremark, 2003) 3dmark06 3D Mark 06 (Futuremark, 2006) re5bench Resident Evil 5 Benchmark (Capcom, 2009) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) Are there others worth using (besides, I suppose, 3dmark05)? (3dmark03 isn't working for me because I can't bypass the sysinfo crash, see http://bugs.winehq.org/show_bug.cgi?id=22392 )

6 10

Wine 2.0
by Remco 18 Apr '10

18 Apr '10

How about, instead of calling the next major release version 1.2, call it version 2.0? The reason is purely marketing: an x.0 number will attract more press. Last major release was 1.0. It seems fitting to have the next major release be 2.0. Besides, is there any reason to have multiple levels of "major releases"? I somehow doubt that a "2.0" can ever be justified if regular major releases use 1.x. -- Remco

3 2

(no subject)
by Oleg Krylov 17 Apr '10

17 Apr '10

http://IvanaKalmus0627.co.cc

1 0

Re: usp10/tests: add tests for CR and LF chars and remove some trailing white space
by Greg Geldorp 17 Apr '10

17 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1506 Your paranoid android. === W98SE (Windows 98 Second Edition) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W2KPROSP4 (Windows 2000 Professional SP4) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === WXPPROSP3 (XP Professional SP3 (English, IE6)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W2K3R2SESP2 (Server 2003 R2 Standard Edition SP2) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === WVISTAADM (Windows Vista (English, IE7)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W2K8SE (Server 2008 Standard Edition) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W7PRO (Windows 7 Professional (English, IE8)) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16 === W7PROX64 (Windows 7 Professional 64 bit) === usp10.c:613: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 12 (14)nusp10.c:616: Test failed: Start pos [3] not = 12 (14) or end [4] pos not = 13 (11) usp10.c:619: Test failed: Start pos [4] not = 13 (11) or end [5] pos not = 16 (14), cInChars = 14 usp10.c:643: Test failed: Start pos [2] not = 11 (11) or end [3] pos not = 14 (12), cInChars = 16

2 1

[rfc] realtime priority patch based on rtkit
by Maarten Lankhorst 17 Apr '10

17 Apr '10

Hi all, I decided to dig through the sample documentation for rtkit and see if I could find a way to make it work for wine. There's still a few things missing: hardcoded libdbus soname, no checking if dbus is available, -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include should be added to ntdll/Makefile and SIGXCPU should demote all threads of the application back to normal priority The server queues an APC to the target thread that signals it should try to acquire rt prio for it. the thread makes a request to rtkit over dbus to say it wants realtime. This is because rtkit requires the affected process to call dbus. Any moral objections to this approach? Cheers, Maarten

2 2

re: Wine 2.0
by Dan Kegel 17 Apr '10

17 Apr '10

I would be fine with calling this wine 2.0, since it adds a major new feature (64 bit compatibility).

1 0

Re: winecfg italian translation update
by Nikolay Sivov 17 Apr '10

17 Apr '10

On 4/17/2010 15:14, Davide Pizzetti wrote: > Here's an italian translation update of winecfg > > - LTEXT "Le Dynamic Link Libraries possono essere specificate indiv > + LTEXT "Le Dynamic Link Libraries possono essere specificate indiv > ,IDC_STATIC,16,16,220,32 > You mail client ate the rest of lines (or something else does).

1 0

Re: winegcc: Fix compiling of 32-bit Winelib Apps on shared 32/64-bit setups
by Marcus Meissner 16 Apr '10

16 Apr '10

On Fri, Apr 16, 2010 at 10:51:29PM +0200, André Hentschel wrote: > --- > tools/winegcc/winegcc.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index 7023ff4..f780a69 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -1252,6 +1252,14 @@ int main(int argc, char **argv) > opts.unicode_app = 1; > else if (strcmp("-m32", argv[i]) == 0) > { > + if (opts.target_cpu == CPU_x86_64) > + { > + const char *stdlib32path[] = { "/usr/lib32/wine", "/usr/local/lib32/wine", "/lib32/wine" }; lib32 is almost never used in the Linux distros though e.g. for SUSE: /usr/lib is the 32bit path on x86, ppc, s390 /usr/lib64 the 64bit path on x86_64, ppc64, s390x Just ia64 is an exception and has /usr/lib (and the compat libs somewhere weird). Ciao, Marcus

2 1

Re: winegcc: Fix compiling of 32-bit Winelib Apps on shared 32/64-bit setups
by Charles Davis 16 Apr '10

16 Apr '10

On 4/16/10 2:51 PM, André Hentschel wrote: > --- > tools/winegcc/winegcc.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index 7023ff4..f780a69 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -1252,6 +1252,14 @@ int main(int argc, char **argv) > opts.unicode_app = 1; > else if (strcmp("-m32", argv[i]) == 0) > { > + if (opts.target_cpu == CPU_x86_64) > + { > + const char *stdlib32path[] = { "/usr/lib32/wine", "/usr/local/lib32/wine", "/lib32/wine" }; That's great for Linux, FreeBSD, etc., but in a world of universal binaries (read: Mac OS X), this ain't gonna fly. I'm pretty sure that when 64-bit Wine support does come to Mac OS X, people are going to want to build it universal (i.e. 32-bit and 64-bit binaries in the same file); I know I do. Chip

1 0

FYI: Wine is used for TeamViewer
by André Hentschel 16 Apr '10

16 Apr '10

Hey, you might take that as spam, but i just saw that Wine seems to be used for the Linux Version of http://www.teamviewer.com I did not yet had a look if they use wine64 for their 64-bit packages... -- Best Regards, André Hentschel

1 0

ICM tests and top-down DIB
by Joerg-Cyril.Hoehle＠t-systems.com 16 Apr '10

16 Apr '10

Hi, any suggestions about how could one reasonably test the ICM codecs? I found no test at all in Wine (but the 4 Austin and I once wrote). I was considering adding the ability to deal with a negative biHeight values (native amstream seems to use this to work around bug #17893) but I feel uncomfortable at touching the always sensitive graphics area without good tests to start with. Upside-down support in the codecs could start a landslide in other places. Negative biHeight indicates top-down bitmaps, see http://msdn.microsoft.com/en-us/library/dd183376.aspx Grepping through dlls/* revealed only few places that deal with them. Thanks for your help, Jörg Höhle.

1 0

Re: [PATCH] ntdll: split out sort and handle win64 cdecl
by Alexandre Julliard 16 Apr '10

16 Apr '10

Marcus Meissner <meissner(a)suse.de> writes: > qsort() calls a cdecl routine, but Win64 cdecl is sadly > not UNIX cdecl... So we need a wrapper. > > Hope this kind of ifdef magic is acceptable, I don't want > it for win32. That looks quite inefficient, not to mention not thread-safe. It would be better to reimplement these functions, that's not hard. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/4] wined3d: Separate AMD Radeon HD2300 from other HD2xxx/HD3xxx GPUs since it is D3D9 instead of D3D10.
by Roderick Colenbrander 16 Apr '10

16 Apr '10

Obviously this patch and the same for 4/4 can be dropped. I'm still a bit new to git send-email and my out directory wasn't empty, so it picked these two up. Roderick On Fri, Apr 16, 2010 at 8:49 AM, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > Just some clever AMD rebranding for China I believe. > --- > dlls/wined3d/directx.c | 30 ++++++++++++++++++------------ > dlls/wined3d/wined3d_private.h | 2 +- > 2 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 6498859..7e22dbc 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1021,7 +1021,7 @@ static const struct driver_version_information driver_version_table[] = > {HW_VENDOR_ATI, CARD_ATI_RADEON_9500, "ATI Radeon 9500", 14, 10, 6764 }, > {HW_VENDOR_ATI, CARD_ATI_RADEON_X700, "ATI Radeon X700 SE", 14, 10, 6764 }, > {HW_VENDOR_ATI, CARD_ATI_RADEON_X1600, "ATI Radeon X1600 Series", 14, 10, 6764 }, > - {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2300, "ATI Mobility Radeon HD 2300", 14, 10, 6764 }, > + {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2350, "ATI Mobility Radeon HD 2350", 14, 10, 6764 }, > {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2600, "ATI Mobility Radeon HD 2600", 14, 10, 6764 }, > {HW_VENDOR_ATI, CARD_ATI_RADEON_HD2900, "ATI Radeon HD 2900 XT", 14, 10, 6764 }, > {HW_VENDOR_ATI, CARD_ATI_RADEON_HD4350, "ATI Radeon HD 4350", 14, 10, 6764 }, > @@ -1581,16 +1581,17 @@ static enum wined3d_pci_device select_card_ati_binary(const struct wined3d_gl_in > return CARD_ATI_RADEON_HD2600; > } > > - /* Radeon R6xx HD2300/HD2400/HD3400 - lowend */ > - if (strstr(gl_renderer, "HD 2300") > + /* Radeon R6xx HD2350/HD2400/HD3400 - lowend > + * Note HD2300=DX9, HD2350=DX10 */ > + if (strstr(gl_renderer, "HD 2350") > || strstr(gl_renderer, "HD 2400") > || strstr(gl_renderer, "HD 3470") > || strstr(gl_renderer, "HD 3450") > || strstr(gl_renderer, "HD 3430") > || strstr(gl_renderer, "HD 3400")) > { > - *vidmem = 128; /* HD2300 uses at least 128MB, HD2400 uses 256MB */ > - return CARD_ATI_RADEON_HD2300; > + *vidmem = 256; /* HD2350/2400 use 256MB, HD34xx use 256-512MB */ > + return CARD_ATI_RADEON_HD2350; > } > > /* Radeon R6xx/R7xx integrated */ > @@ -1613,14 +1614,19 @@ static enum wined3d_pci_device select_card_ati_binary(const struct wined3d_gl_in > return CARD_ATI_RADEON_X1600; > } > > - /* Radeon R4xx + X1300/X1400/X1450/X1550/X2300 (lowend R5xx) */ > + /* Radeon R4xx + X1300/X1400/X1450/X1550/X2300/X2500/HD2300 (lowend R5xx) > + * Note X2300/X2500/HD2300 are R5xx GPUs with a 2xxx naming but they are still DX9-only */ > if (strstr(gl_renderer, "X700") > || strstr(gl_renderer, "X800") > || strstr(gl_renderer, "X850") > || strstr(gl_renderer, "X1300") > || strstr(gl_renderer, "X1400") > || strstr(gl_renderer, "X1450") > - || strstr(gl_renderer, "X1550")) > + || strstr(gl_renderer, "X1550") > + || strstr(gl_renderer, "X2300") > + || strstr(gl_renderer, "X2500") > + || strstr(gl_renderer, "HD 2300") > + ) > { > *vidmem = 128; /* x700/x8*0 use 128-256MB, >=x1300 128-512MB */ > return CARD_ATI_RADEON_X700; > @@ -1737,12 +1743,12 @@ static enum wined3d_pci_device select_card_ati_mesa(const struct wined3d_gl_info > return CARD_ATI_RADEON_HD2600; > } > > - /* Radeon R6xx HD2300/HD2400/HD3400 - lowend */ > + /* Radeon R6xx HD2350/HD2400/HD3400 - lowend */ > if (strstr(gl_renderer, "RV610") > || strstr(gl_renderer, "RV620")) > { > - *vidmem = 128; /* HD2300 uses at least 128MB, HD2400 uses 256MB */ > - return CARD_ATI_RADEON_HD2300; > + *vidmem = 256; /* HD2350/2400 use 256MB, HD34xx use 256-512MB */ > + return CARD_ATI_RADEON_HD2350; > } > > /* Radeon R6xx/R7xx integrated */ > @@ -1860,8 +1866,8 @@ static enum wined3d_pci_device select_card_ati_mesa(const struct wined3d_gl_info > if (strstr(gl_renderer, "(RV610") > || strstr(gl_renderer, "(RV620")) > { > - *vidmem = 128; /* HD2300 uses at least 128MB, HD2400 uses 256MB */ > - return CARD_ATI_RADEON_HD2300; > + *vidmem = 256; /* HD2350/2400 use 256MB, HD34xx use 256-512MB */ > + return CARD_ATI_RADEON_HD2350; > } > > /* Radeon R6xx/R7xx integrated */ > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 4652be5..53200ce 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -1301,7 +1301,7 @@ enum wined3d_pci_device > CARD_ATI_RADEON_XPRESS_200M = 0x5955, > CARD_ATI_RADEON_X700 = 0x5e4c, > CARD_ATI_RADEON_X1600 = 0x71c2, > - CARD_ATI_RADEON_HD2300 = 0x7210, > + CARD_ATI_RADEON_HD2350 = 0x94c7, > CARD_ATI_RADEON_HD2600 = 0x9581, > CARD_ATI_RADEON_HD2900 = 0x9400, > CARD_ATI_RADEON_HD3200 = 0x9620, > -- > 1.6.3.3 > >

1 0

Re: loader: Fix French translation of wine manpage (resent)
by Frédéric Delanoy 15 Apr '10

15 Apr '10

Hi. Could someone please tell me why this patch was silently discarded ? Is there some something awfully wrong in the changes in tools/Makefile.in ? Or some other trivial mistake ? Frédéric

1 0

Re: [PATCH] RFC: C99: rewrote some extern inline to static inline
by Albert Lee 15 Apr '10

15 Apr '10

On Thu, 15 Apr 2010 11:56:32 +0200, Yann Droneaud <yann(a)droneaud.fr> wrote: > In order to build with CLANG with default arguments, extern inline > declaration > must be changed. > > By default CLANG uses C99's "extern inline" semantic which is like > gcc's "inline", and not the expected gcc's "extern inline" behavor. > > Additionnaly LLVM/CLANG don't support multiple function definitions with > different linkage in the same module (source file) : so it's not > possible to have a static inline definition in a header included in a > source file with a externally visible function of the same name. > C99's inline differs from GNU C's in that it will never cause a function definition to be emitted, so you should be able to replace GNU C's "extern inline" with plain inline. This has an advantage over static inline if you need to define an externally visible function, since you can avoid the copying the definition from the header to a source file by making sure the translation unit declares the function as C99 extern inline before including the inline definition. > This patch convert extern inline to static inline, so > embedded functions are not globally visible. > > This could be a problem if those symbols are needed. But currently, > I'm not able to give you any status: i was only able to run "cmd.exe", > before going further with LLVM/CLANG. I'm fighting with LLVM/CLANG bug > instead. > > If they are so symbols needed or if the binaries size grow to much, > the "extern inline" attribute will have to be converted to a macro, > expanded to "extern inline" with gcc in default behavor, and "inline" with > a C99 compatible compiler. > With C99 static inline, there should be no function definitions emitted so the size should not be much different. > See for example how this work in GMP: > http://gmplib.org:8000/gmp/file/da5903b6e386/gmp-h.in#l414 > Thanks for helping Wine get closer to C standards conformance! -Albert

1 0

Re: winex11: add support for 32-bit DDBs
by Erich Hoover 15 Apr '10

15 Apr '10

I noticed a problem with the icons in Wine when alt+tabbing today. After doing a regression test it appears that commit c29cf0591976f96c3adb30c3c3b6db59f4983251 results in pixmaps that do not always display properly when alt+tabbing (see attached screenshot). Erich Hoover ehoover(a)mines.edu

2 3

Re: [1/1] wcmd/tests: Attrib tests (resend)
by Alexandre Julliard 15 Apr '10

15 Apr '10

Eleazar Galano <eg.galano(a)gmail.com> writes: >> Dan Kegel is helping me get started with Wine development. To prepare >> for modifications to the ATTRIB function of CMD.EXE, I have added test >> cases for the current functionality of ATTRIB. It seems to me this should go in programs/attrib. Also it should test that the attributes actually changed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw: Do not restore the display mode from inside SetCooperativeLevel (resend)
by Alexandre Julliard 15 Apr '10

15 Apr '10

Johan Gill <johan.gill(a)gmail.com> writes: > dlls/ddraw/ddraw.c | 3 --- > dlls/ddraw/tests/ddrawmodes.c | 25 +++++++++++++++++++++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) This causes the test to not restore the display mode properly on exit. -- Alexandre Julliard julliard(a)winehq.org

1 0

HLSL Compiler and d3dcompiler_xx.dll
by Matijn Woudt 15 Apr '10

15 Apr '10

Hi, I'm about to implement the HLSL compiler, but I want to make sure I'm taking the right direction. For the compiler: preprocessor(wpp)->hlslparser/compiler(lex/bison)->bytecode writer(same as for the shader assembler). Now the question is where to implement the compiler. It can be called from at least 3 places, d3dx9_xx, d3d10_xx and d3dcompiler_xx. It seems to me that d3dx9_xx and d3d10_xx are forwarding their calls to d3dcompiler_xx. My proposal is: 1) Create the d3dcompiler_xx.dll structure in wine. Is it legal to use a program like dll export viewer to get the exported functions for each dll? 2) Move the assembler to d3dcompiler_xx.dll and forward calls from d3dx9. This is needed because the assembler and compiler can share the same bytecode writer this way. 3) Implement the compiler in d3dcompiler_xx. Regards, Matijn

8 23

Re: oleaut32: be more explicit with locale dependent parsing of dates (try 2)
by Nikolay Sivov 15 Apr '10

15 Apr '10

On 4/14/2010 22:51, André Hentschel wrote: > case 0x3: /* TTT TTTDD TTTDDD */ > - if (iDate&& dp.dwCount == 3) > + if (dp.dwCount == 3&& !strncmp(ShortDate,"dd.MM.yy",8)) > > > case 0x1B: /* localized DDDTTT */ > - if (!iDate) > + if (strncmp(ShortDate,"dd.MM.yy",8)) > { > hRet = DISP_E_TYPEMISMATCH; > break; > This looks like a workaround. I don't think you should hard code it this way, what's so special with this format? And what is a initial problem with that?

2 2

Re: kernel32: Add tests for lstrcmpW (try 2)
by Dmitry Timoshkov 15 Apr '10

15 Apr '10

André Hentschel <nerv(a)dawncrow.de> wrote: > - Design similar to ntdll/tests/error.c > - Passes all Machines on WTB > - with check for existance of function > - just the known 2 instead of 4510 > - intendation for todo_wine choosen so that it can be easy removed without touching the tests You need to test CompareStringW instead, and try to avoid using any macros at all. Probably the very first thing you need to do in the test is to call GetStringType and verify that the character you want to test is supported and has the expected attributes. -- Dmitry.

1 0

Packaging Wine 64bit
by Michael Stefaniuc 14 Apr '10

14 Apr '10

Hello guys! Wine 64bit (the one able to run 64bit Windows application) is nearly feature complete. As of wine-1.1.42 Wine supports shared 32/64-bit setups; though we do not recommend it yet for general consumption. This is more of a "heads up" info as the next stable Wine release aka 1.2 is "imminent" (about one month until code freeze and then an additional month for the stabilization period). Proper Wine 64bit support poses some challenges for packaging as it requires *both* 64bit as well as 32bit libraries and binaries. This makes Wine 64bit packaging different from the normal other 64bit packages. To ease the pain we have created a wiki page with information pertinent to packagers/distributions: http://wiki.winehq.org/Wine64ForPackagers Do not hesitate to contact us either by email to wine-devel or on irc on Freenode in #winehackers if you have any questions or suggestions. The above page actually evolved from discussions on irc. If you do know about Wine packagers on other Linux distributions please forward them this info; we are pretty sure that we missed a few. We didn't forget about the non-Linux OSes but Wine 64bit is at the moment a Linux only feature; patches to change that are of course welcome ;) bye michael

1 0

Re: [PATCH 2/2] mmdevapi: Add pulseaudio on ignore for older openal-soft's
by Michael Stefaniuc 14 Apr '10

14 Apr '10

On 04/14/2010 09:24 PM, Maarten Lankhorst wrote: > --- > I cannot query the version string unless a device context is created. > Since OpenAL-1.12 added support for thread local contexts I use that to > determine whether pulseaudio should be ignored or not. OpenAL 1.10 and > older will crash on pulseaudio. Since other os's don't support > pulseaudio it is safe. > +static void boycott_pulse(const char *devstr, const char **defstr) { The function is badly named. It doesn't "boycott" PA but doesn't uses it on older OpenAL versions. > + if (!blacklist_pulse && !local_contexts) { > + WARN("Disabling pulseaudio because of old openal version\n"); > + blacklist_pulse = 1; > + } > + if (!blacklist_pulse || !devstr || strncmp(*defstr, "PulseAudio ", 11)) > + return; > + while (*devstr && !strncmp(devstr, "PulseAudio ", 11)) { > + devstr += strlen(devstr) + 1; > + } > + TRACE("New default: %s\n", devstr); > + *defstr = devstr; > +} > + bye michael

1 0

Re: usbhub.sys: add stubbed usbhub.sys
by Alexandre Julliard 14 Apr '10

14 Apr '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * usbhub.sys: add stubbed usbhub.sys What is this going to be useful for? -- Alexandre Julliard julliard(a)winehq.org

3 12

Future implementation
by Luis Busquets 14 Apr '10

14 Apr '10

Could someone please confirm the following points?: 1. Sound system. The configuration that wine will implement is: winmm --> WASAPI --> OpenAL and DirectSound --> OpenAL After that is done wineoss, winejack, winealsa, ... will be removed from the tree. 2. Integration of DosBOX or other emulator. How this will be done? Is the plan to use them when wine detects that the programme is compiled for real mode? Does that mean that the sake of wine is to provide compatibility only for applications built to be run on protected mode? 3. Direct3D10 and Direct3D11, Is there a target date for them?

8 7

Re: configure: when compiling with CLANG, set -std=gnu89
by Alexandre Julliard 14 Apr '10

14 Apr '10

Austin English <austinenglish(a)gmail.com> writes: > Clang defaults to compiling in C99 mode, which breaks the compile. Of course the compile should be fixed instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] urlmon/tests: CoInternetCreateSecurityManager not present on W95B
by Jacek Caban 14 Apr '10

14 Apr '10

On 4/13/10 11:49 PM, Detlef Riekenberg wrote: > --- > dlls/urlmon/tests/sec_mgr.c | 17 ++++++++++++----- > 1 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/dlls/urlmon/tests/sec_mgr.c b/dlls/urlmon/tests/sec_mgr.c > index e758115..8e39301 100644 > --- a/dlls/urlmon/tests/sec_mgr.c > +++ b/dlls/urlmon/tests/sec_mgr.c > @@ -107,8 +107,10 @@ static void test_SecurityManager(void) > DWORD zone, size, policy; > HRESULT hres; > > - hres = CoInternetCreateSecurityManager(NULL,&secmgr, 0); > - ok(hres == S_OK, "CoInternetCreateSecurityManager failed: %08x\n", hres); > + hres = CoCreateInstance(&CLSID_InternetSecurityManager, NULL, CLSCTX_INPROC_SERVER, > +&IID_IInternetSecurityManager, (void **)&secmgr); > + > + ok(hres == S_OK, "CoCreateInstance for IInternetSecurityManager failed: %08x\n", hres); > if(FAILED(hres)) > return; > You're changing what we test here. If you only want to fix tests on win98 it's a nice excuse to skip tests. If you want to test CLSID_InternetSecurityManager anyway, you should test both CLSID_InternetSecurityManager and CoInternetCreateSecurityManager. Same for zone manager patch. Jacek

1 0

Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon
by Paul Vriens 14 Apr '10

14 Apr '10

On 04/13/2010 10:59 PM, Joel Holdsworth wrote: > Signed-off-by: Joel Holdsworth<joel(a)airwebreathe.org.uk> > --- > dlls/shell32/mycomputer.ico | Bin 15086 -> 25214 bytes > dlls/shell32/mycomputer.svg | 2400 ++++++++++++++++++++++++++----------------- > 2 files changed, 1477 insertions(+), 923 deletions(-) > > > > > > Hi Joel, I think this has been mentioned before, but the monitor icons (32-bit and 8-bit for size 32) show a wider lower half of the monitor compared to the upper half (I think the 32-bit size 22 as well). -- Cheers, Paul.

3 4

Re: [PATCH 5/5] winex11.drv: Allow OpenGL on minimized windows.
by Florian Köberle 14 Apr '10

14 Apr '10

Hello Henri, your patch fixes bug 12611: http://bugs.winehq.org/show_bug.cgi?id=12611 Thanks for your great work! You have worked on quite a few bugs I have voted for. Would be buying Crossover Games (again) the correct way to support your work? Best regards, Florian

2 1

Re: [PATCH 3/5] wined3d: Disable strict draw ordering by default.
by Stefan Dösinger 14 Apr '10

14 Apr '10

Am 13.04.2010 um 20:46 schrieb Henri Verbeet: > + if (wined3d_settings.strict_draw_ordering) wglFlush(); /* Flush to ensure ordering across contexts. */ I'd prefer to have this in an (inline) function.

2 3

Re: user32: BM_SETSTATE handler needs to repaint the button including focus rectangle.
by Alexandre Julliard 14 Apr '10

14 Apr '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > While playing with the button painting bug I noticed that the button doesn't > repaint its focus when you hold mouse button and move it outside and then back > to the button. It looks to me that you should fix the push button paint routine, instead of changing the notification type. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/1] wcmd/tests: Attrib tests (resend)
by testbot＠testbot.winehq.org 13 Apr '10

13 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1423 Your paranoid android. === WINEBUILD (Wine build VM) === Make failed

1 0

Re: [5/5] msi: Move application of substorage transforms out of msi_parse_patch_summary.
by testbot＠testbot.winehq.org 13 Apr '10

13 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.nl/JobDetails.pl?Key=1407 Your paranoid android. === W7PROX64 (Windows 7 Professional 64 bit) === install.c:4613: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4616: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4636: Test failed: Key doesn't exist or wrong type install.c:4637: Test failed: Key doesn't exist or wrong type install.c:4639: Test failed: Key doesn't exist or wrong type install.c:4640: Test failed: Key doesn't exist or wrong type install.c:4643: Test failed: Key doesn't exist or wrong type install.c:4652: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4661: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4663: Test failed: Key doesn't exist or wrong type install.c:4712: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4715: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4735: Test failed: Key doesn't exist or wrong type install.c:4736: Test failed: Key doesn't exist or wrong type install.c:4738: Test failed: Key doesn't exist or wrong type install.c:4739: Test failed: Key doesn't exist or wrong type install.c:4742: Test failed: Key doesn't exist or wrong type install.c:4751: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4760: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4762: Test failed: Key doesn't exist or wrong type install.c:5047: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5049: Test failed: Key doesn't exist or wrong type install.c:5050: Test failed: Key doesn't exist or wrong type install.c:5082: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5084: Test failed: Key doesn't exist or wrong type install.c:5085: Test failed: Key doesn't exist or wrong type install.c:5191: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5193: Test failed: Key doesn't exist or wrong type install.c:5194: Test failed: Key doesn't exist or wrong type install.c:5195: Test failed: Key doesn't exist or wrong type install.c:5212: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5214: Test failed: Key doesn't exist or wrong type install.c:5215: Test failed: Key doesn't exist or wrong type install.c:5216: Test failed: Key doesn't exist or wrong type install.c:5269: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5274: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5279: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5292: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5297: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5298: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5317: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5322: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5323: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5336: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5341: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5342: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5390: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5400: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 install.c:5401: Test failed: Expected INSTALLSTATE_UNKNOWN, got 3 install.c:5413: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5423: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 install.c:5424: Test failed: Expected INSTALLSTATE_UNKNOWN, got 3 install.c:5446: Test failed: Expected ERROR_UNKNOWN_COMPONENT, got 0 install.c:5447: Test failed: Expected INSTALLSTATE_UNKNOWN, got 3 install.c:5487: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5501: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:5550: Test failed: Expected 12 or -12, got 24 install.c:5562: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5576: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:5625: Test failed: Expected 12 or -12, got 36 install.c:5677: Test failed: Expected 12 or -12, got 36 install.c:5729: Test failed: Expected 12 or -20, got 36 install.c:5741: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5755: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:5804: Test failed: Expected 12 or -12, got 48 install.c:5816: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5830: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:7455: Test failed: Expected ERROR_SUCCESS, got 2 install.c:7459: Test failed: Expected ERROR_SUCCESS, got 6 install.c:7465: Test failed: Expected ERROR_INSTALL_SOURCE_ABSENT, got 0 install.c:7467: Test failed: File not installed install.c:7468: Test failed: File not installed install.c:7469: Test failed: File not installed install.c:7470: Test failed: File not installed install.c:7479: Test failed: Expected ERROR_SUCCESS, got 1605 install.c:7498: Test failed: Expected ERROR_SUCCESS, got 2 install.c:7502: Test failed: Expected ERROR_SUCCESS, got 6 install.c:7524: Test failed: Expected ERROR_INSTALL_SOURCE_ABSENT, got 0 install.c:7526: Test failed: File not installed install.c:7527: Test failed: File not installed install.c:7528: Test failed: File not installed install.c:7529: Test failed: File not installed install.c:7534: Test failed: Expected ERROR_SUCCESS, got 1018 install.c:7540: Test failed: Expected ERROR_SUCCESS, got 1605 === W7PROX64 (Windows 7 Professional 64 bit) === install.c:3378: Test failed: File not installed install.c:3379: Test failed: File not installed install.c:3380: Test failed: File not installed install.c:3381: Test failed: File not installed install.c:3382: Test failed: File not installed install.c:3385: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3390: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3391: Test failed: Expected imaname, got install.c:3396: Test failed: Expected ERROR_FILE_NOT_FOUND, got 6 install.c:3401: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3402: Test failed: Expected 314, got 2047 install.c:3407: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3408: Test failed: Expected OrderTestValue, got install.c:3425: Test failed: File not installed install.c:3426: Test failed: File not installed install.c:3427: Test failed: File not installed install.c:3428: Test failed: File not installed install.c:3429: Test failed: File not installed install.c:3432: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3448: Test failed: File not installed install.c:3449: Test failed: File not installed install.c:3450: Test failed: File not installed install.c:3451: Test failed: File not installed install.c:3452: Test failed: File not installed install.c:3455: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3471: Test failed: File not installed install.c:3472: Test failed: File not installed install.c:3473: Test failed: File not installed install.c:3474: Test failed: File not installed install.c:3475: Test failed: File not installed install.c:3478: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3494: Test failed: File not installed install.c:3495: Test failed: File not installed install.c:3496: Test failed: File not installed install.c:3497: Test failed: File not installed install.c:3498: Test failed: File not installed install.c:3501: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3517: Test failed: File not installed install.c:3518: Test failed: File not installed install.c:3519: Test failed: File not installed install.c:3520: Test failed: File not installed install.c:3521: Test failed: File not installed install.c:3539: Test failed: File not installed install.c:3540: Test failed: File not installed install.c:3541: Test failed: File not installed install.c:3542: Test failed: File not installed install.c:3543: Test failed: File not installed install.c:3561: Test failed: File not installed install.c:3562: Test failed: File not installed install.c:3563: Test failed: File not installed install.c:3564: Test failed: File not installed install.c:3565: Test failed: File not installed install.c:3583: Test failed: File not installed install.c:3584: Test failed: File not installed install.c:3585: Test failed: File not installed install.c:3586: Test failed: File not installed install.c:3587: Test failed: File not installed install.c:3605: Test failed: File not installed install.c:3606: Test failed: File not installed install.c:3607: Test failed: File not installed install.c:3608: Test failed: File not installed install.c:3609: Test failed: File not installed install.c:3788: Test failed: File not installed install.c:3789: Test failed: File not installed install.c:3790: Test failed: File not installed install.c:3791: Test failed: File not installed install.c:3804: Test failed: File not installed install.c:3806: Test failed: File not installed install.c:3807: Test failed: File not installed install.c:3808: Test failed: File not installed install.c:3832: Test failed: Expected ERROR_INSTALL_FAILURE, got 0 install.c:3864: Test failed: Expected ERROR_INSTALL_FAILURE, got 0 install.c:3914: Test failed: File not installed install.c:3915: Test failed: File not installed install.c:3916: Test failed: File not installed install.c:3917: Test failed: File not installed install.c:3941: Test failed: File not installed install.c:3942: Test failed: File not installed install.c:3943: Test failed: File not installed install.c:3944: Test failed: File not installed install.c:3965: Test failed: File not installed install.c:3966: Test failed: File not installed install.c:3967: Test failed: File not installed install.c:4016: Test failed: Expected file to be overwritten install.c:4017: Test failed: File not installed install.c:4018: Test failed: File not installed install.c:4064: Test failed: Expected file to be overwritten, got '' install.c:4065: Test failed: File not installed install.c:4066: Test failed: File not installed install.c:4251: Test failed: File not installed install.c:4252: Test failed: File not installed install.c:4280: Test failed: File not installed install.c:4281: Test failed: File not installed install.c:4282: Test failed: File not installed install.c:4283: Test failed: File not installed install.c:4284: Test failed: File not installed install.c:4318: Test failed: File not installed install.c:4319: Test failed: File not installed install.c:4325: Test failed: File not installed install.c:4327: Test failed: File not installed install.c:4364: Test failed: File not installed install.c:4365: Test failed: File not installed install.c:4572: Test failed: File not installed install.c:4573: Test failed: File not installed install.c:4579: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4598: Test failed: Key doesn't exist or wrong type install.c:4599: Test failed: Key doesn't exist or wrong type install.c:4601: Test failed: Key doesn't exist or wrong type install.c:4602: Test failed: Key doesn't exist or wrong type install.c:4605: Test failed: Key doesn't exist or wrong type install.c:4671: Test failed: File not installed install.c:4672: Test failed: File not installed install.c:4678: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4697: Test failed: Key doesn't exist or wrong type install.c:4698: Test failed: Key doesn't exist or wrong type install.c:4700: Test failed: Key doesn't exist or wrong type install.c:4701: Test failed: Key doesn't exist or wrong type install.c:4704: Test failed: Key doesn't exist or wrong type install.c:4813: Test failed: File not installed install.c:4814: Test failed: File not installed install.c:4911: Test failed: File not installed install.c:4912: Test failed: File not installed install.c:5025: Test failed: File not installed install.c:5026: Test failed: File not installed install.c:5060: Test failed: File not installed install.c:5061: Test failed: File not installed install.c:5185: Test failed: File not installed install.c:5186: Test failed: File not installed install.c:5206: Test failed: File not installed install.c:5207: Test failed: File not installed install.c:5263: Test failed: File not installed install.c:5264: Test failed: File not installed install.c:5279: Test failed: Expected "C:\Program Files\msitest\maximus", got "C:\Program Files (x86)\msitest\maximus" install.c:5311: Test failed: File not installed install.c:5312: Test failed: File not installed install.c:5323: Test failed: Expected "C:\Program Files\msitest\maximus", got "C:\Program Files (x86)\msitest\maximus" install.c:5450: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5469: Test failed: Key doesn't exist or wrong type install.c:5470: Test failed: Key doesn't exist or wrong type install.c:5472: Test failed: Key doesn't exist or wrong type install.c:5473: Test failed: Key doesn't exist or wrong type install.c:5476: Test failed: Key doesn't exist or wrong type install.c:5524: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5543: Test failed: Key doesn't exist or wrong type install.c:5544: Test failed: Key doesn't exist or wrong type install.c:5546: Test failed: Key doesn't exist or wrong type install.c:5547: Test failed: Key doesn't exist or wrong type install.c:5550: Test failed: Key doesn't exist or wrong type install.c:5558: Test failed: File not deleted install.c:5559: Test failed: Directory not deleted install.c:5599: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5618: Test failed: Key doesn't exist or wrong type install.c:5619: Test failed: Key doesn't exist or wrong type install.c:5621: Test failed: Key doesn't exist or wrong type install.c:5622: Test failed: Key doesn't exist or wrong type install.c:5625: Test failed: Key doesn't exist or wrong type install.c:5651: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5670: Test failed: Key doesn't exist or wrong type install.c:5671: Test failed: Key doesn't exist or wrong type install.c:5673: Test failed: Key doesn't exist or wrong type install.c:5674: Test failed: Key doesn't exist or wrong type install.c:5677: Test failed: Key doesn't exist or wrong type install.c:5703: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5722: Test failed: Key doesn't exist or wrong type install.c:5723: Test failed: Key doesn't exist or wrong type install.c:5725: Test failed: Key doesn't exist or wrong type install.c:5726: Test failed: Key doesn't exist or wrong type install.c:5729: Test failed: Key doesn't exist or wrong type install.c:5737: Test failed: File not deleted install.c:5738: Test failed: Directory not deleted install.c:5778: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5797: Test failed: Key doesn't exist or wrong type install.c:5798: Test failed: Key doesn't exist or wrong type install.c:5800: Test failed: Key doesn't exist or wrong type install.c:5801: Test failed: Key doesn't exist or wrong type install.c:5804: Test failed: Key doesn't exist or wrong type install.c:5812: Test failed: File not deleted install.c:5813: Test failed: Directory not deleted install.c:5864: Test failed: File not installed install.c:5865: Test failed: File not installed install.c:5886: Test failed: File not installed install.c:5887: Test failed: File not installed install.c:5908: Test failed: File not installed install.c:5909: Test failed: File not installed install.c:5930: Test failed: File not installed install.c:5931: Test failed: File not installed install.c:5952: Test failed: File not installed install.c:5953: Test failed: File not installed install.c:6219: Test failed: File not installed install.c:6220: Test failed: File not installed install.c:6258: Test failed: File not installed install.c:6259: Test failed: File not installed install.c:6275: Test failed: File not installed install.c:6276: Test failed: File not installed install.c:6392: Test failed: File installed install.c:6393: Test failed: File installed install.c:6431: Test failed: File not installed install.c:6433: Test failed: File not installed install.c:6434: Test failed: File not installed install.c:6440: Test failed: File deleted install.c:6441: Test failed: File deleted install.c:6457: Test failed: File not deleted install.c:6460: Test failed: File deleted install.c:6479: Test failed: File not installed install.c:6480: Test failed: File not deleted install.c:6486: Test failed: File not deleted install.c:6487: Test failed: File not deleted install.c:6488: Test failed: File not deleted install.c:6501: Test failed: File not deleted install.c:6503: Test failed: File deleted install.c:6507: Test failed: File not deleted install.c:6508: Test failed: File not deleted install.c:6510: Test failed: File not deleted install.c:6511: Test failed: File not deleted install.c:6518: Test failed: File not installed install.c:6520: Test failed: File not installed install.c:6528: Test failed: Directory not deleted install.c:6584: Test failed: File not installed install.c:6586: Test failed: File not copied install.c:6587: Test failed: File not moved install.c:6591: Test failed: File not moved install.c:6594: Test failed: File not moved install.c:6597: Test failed: File not moved install.c:6600: Test failed: File not moved install.c:6603: Test failed: File not moved install.c:6609: Test failed: File not moved install.c:6612: Test failed: File not moved install.c:6613: Test failed: File not moved install.c:6615: Test failed: File not moved install.c:6616: Test failed: File not moved install.c:6618: Test failed: File not installed install.c:6715: Test failed: File not installed install.c:6716: Test failed: File not duplicated install.c:6717: Test failed: File not duplicated install.c:6718: Test failed: File not duplicated install.c:6719: Test failed: File not duplicated install.c:6720: Test failed: File not duplicated install.c:6721: Test failed: File not installed install.c:6745: Test failed: File installed install.c:6746: Test failed: File installed install.c:6749: Test failed: Expected ERROR_SUCCESS, got 2 install.c:6755: Test failed: Expected ERROR_SUCCESS, got 6 install.c:6756: Test failed: Wrong multi-sz data install.c:6757: Test failed: Expected 15, got 260 install.c:6780: Test failed: Expected ERROR_INSTALL_FAILURE, got 0 install.c:6816: Test failed: File installed install.c:6817: Test failed: File installed install.c:6848: Test failed: File not installed install.c:6850: Test failed: File not installed install.c:6851: Test failed: File not installed install.c:6860: Test failed: File not installed install.c:6866: Test failed: File not installed install.c:6869: Test failed: File not installed install.c:6870: Test failed: File not installed install.c:6872: Test failed: File not installed install.c:6876: Test failed: File not installed install.c:6880: Test failed: File not installed install.c:6883: Test failed: File not installed install.c:6886: Test failed: File not installed install.c:6892: Test failed: File not installed install.c:7371: Test failed: File not installed install.c:7372: Test failed: File not installed install.c:7373: Test failed: File not installed install.c:7374: Test failed: File not installed install.c:7396: Test failed: File not installed install.c:7397: Test failed: File not installed install.c:7398: Test failed: File not installed install.c:7399: Test failed: File not installed install.c:7421: Test failed: File not installed install.c:7422: Test failed: File not installed install.c:7423: Test failed: File not installed install.c:7424: Test failed: File not installed install.c:7443: Test failed: File not installed install.c:7444: Test failed: File not installed install.c:7445: Test failed: File not installed install.c:7446: Test failed: File not installed install.c:7467: Test failed: File not installed install.c:7468: Test failed: File not installed install.c:7469: Test failed: File not installed install.c:7470: Test failed: File not installed install.c:7488: Test failed: File not installed install.c:7489: Test failed: File not installed install.c:7490: Test failed: File not installed install.c:7491: Test failed: File not installed install.c:7526: Test failed: File not installed install.c:7527: Test failed: File not installed install.c:7528: Test failed: File not installed install.c:7529: Test failed: File not installed install.c:7571: Test failed: File not installed install.c:7572: Test failed: File not installed install.c:7573: Test failed: File not installed install.c:7575: Test failed: File not installed install.c:7607: Test failed: File installed install.c:7608: Test failed: File installed install.c:7621: Test failed: File installed install.c:7622: Test failed: File installed install.c:7661: Test failed: File not installed install.c:7662: Test failed: File not installed install.c:7663: Test failed: File not installed install.c:7664: Test failed: File not installed install.c:7665: Test failed: File not installed install.c:7695: Test failed: File not installed install.c:7696: Test failed: File not installed install.c:7937: Test failed: File not installed install.c:7948: Test failed: File not installed install.c:7951: Test failed: File not installed install.c:7952: Test failed: File not installed install.c:7954: Test failed: File not installed install.c:7955: Test failed: File not installed install.c:7982: Test failed: File not installed install.c:7985: Test failed: File not installed install.c:7986: Test failed: File not installed install.c:7987: Test failed: File installed install.c:7988: Test failed: File not installed install.c:7989: Test failed: File not installed install.c:8234: Test failed: Expected ERROR_SUCCESS_REBOOT_REQUIRED got 0 install.c:8132: Test failed: RegQueryValueExA failed 2 (0) install.c:8173: Test failed: Expected a 'msitest' entry install.c:8194: Test failed: Expected file to match install.c:8285: Test failed: Expected ERROR_SUCCESS_REBOOT_REQUIRED got 0 install.c:8173: Test failed: Expected a 'msitest' entry install.c:8194: Test failed: Expected file to match install.c:8014: Test failed: File not installed install.c:8017: Test failed: File not installed install.c:8018: Test failed: File not installed install.c:8019: Test failed: File installed install.c:8020: Test failed: File not installed install.c:8021: Test failed: File not installed install.c:8041: Test failed: File not installed install.c:8044: Test failed: File not installed install.c:8045: Test failed: File not installed install.c:8046: Test failed: File installed install.c:8047: Test failed: File not installed install.c:8048: Test failed: File not installed install.c:8068: Test failed: File not installed install.c:8071: Test failed: File not installed install.c:8072: Test failed: File not installed install.c:8073: Test failed: File installed install.c:8074: Test failed: File not installed install.c:8075: Test failed: File not installed install.c:8401: Test failed: File not installed install.c:8403: Test failed: File not installed install.c:8547: Test failed: File not installed install.c:8548: Test failed: Directory not created install.c:8549: Test failed: File not installed install.c:8550: Test failed: Directory not created install.c:8552: Test failed: Directory not created install.c:8553: Test failed: File not installed install.c:8554: Test failed: Directory not created install.c:8555: Test failed: File not installed install.c:8556: Test failed: File not installed install.c:8557: Test failed: File not installed install.c:8558: Test failed: Directory not created install.c:8589: Test failed: File not installed install.c:8590: Test failed: Directory not created install.c:8591: Test failed: File not installed install.c:8592: Test failed: Directory not created install.c:8594: Test failed: Directory not created install.c:8595: Test failed: File not installed install.c:8596: Test failed: Directory not created install.c:8597: Test failed: File not installed install.c:8598: Test failed: File not installed install.c:8599: Test failed: File not installed install.c:8600: Test failed: Directory not created install.c:8617: Test failed: File not installed install.c:8618: Test failed: Directory not created install.c:8619: Test failed: File not installed install.c:8620: Test failed: Directory not created install.c:8622: Test failed: Directory not created install.c:8623: Test failed: File not installed install.c:8624: Test failed: Directory not created install.c:8625: Test failed: File not installed install.c:8626: Test failed: File not installed install.c:8627: Test failed: File not installed install.c:8628: Test failed: Directory not created install.c:8692: Test failed: File not installed install.c:8693: Test failed: Directory not created install.c:8694: Test failed: File not installed install.c:8695: Test failed: Directory not created install.c:8697: Test failed: Directory not created install.c:8698: Test failed: File not installed install.c:8699: Test failed: Directory not created install.c:8700: Test failed: File not installed install.c:8701: Test failed: File not installed install.c:8702: Test failed: File not installed install.c:8703: Test failed: Directory not created install.c:8725: Test failed: file not created install.c:8726: Test failed: file not created install.c:8727: Test failed: file not created install.c:8728: Test failed: file not created install.c:8729: Test failed: file not created install.c:8788: Test failed: file not created install.c:8789: Test failed: file not created install.c:8855: Test failed: file not created install.c:8856: Test failed: file not created install.c:8858: Test failed: file not created install.c:8864: Test failed: file removed install.c:8869: Test failed: directory removed install.c:8916: Test failed: key not removed install.c:8926: Test failed: key not removed install.c:8937: Test failed: key not removed install.c:9011: Test failed: got 6 expected 0 install.c:9017: Test failed: got 6 expected 0 install.c:9020: Test failed: got 6 expected 0 install.c:9022: Test failed: file removed install.c:9167: Test failed: key not created

4 3

Re: ddraw: Do not restore the display mode from inside SetCooperativeLevel
by Johan Gill 13 Apr '10

13 Apr '10

It seems this patch wasn't accepted yet. Are there any issues I should know about? Regards Johan Gill

1 0

Re: Detecting patch sets
by Dan Kegel 13 Apr '10

13 Apr '10

Hi Ge, when I was running patchwatcher, taking the number of patches in the series helped more than it hurt. (It's fairly frequent for people to submit two patchsets, and fairly infrequent for the second patchset to have the same number of patches.) The darn interface needed babysitting, though, since there were always malformed and/or partial series. I think it'd be cool to have a UI where developers could correct their detected patchsets if they don't like what the automated extractor did. That could morph into a way of submitting patchsets in the first place later on. It'd also be cool if other tools - say, a buildbot or a patchwatcher - could monitor the detected patchset stream (to save them from having to maintain their own). - Dan

3 2

Working on "DOS" VGA.
by Morten Rønne 13 Apr '10

13 Apr '10

Hi Wine-devel My name is Morten and I would like for some of my old DOS/WIN95 games to work with wine. :) I know that I most likely could solve this by using DOSbox and/or DOSemu. But I don't consider either of them user friendly in it's raw form. And I hope in the future it could be more of a Go to this menu item, click a few choices and then play game thing. So I have been looking into what one of them is needing (XCOM Apocalypse). The first thing that needs work is the VGA screen driver. The game needs one of the unsupported video modes. After looking further into it, I can see that the current screen driver, needs to be more of an emulator than just a copy of the framebuffer/RAM window to/from the DirectDraw surface. But since I need to do a lot rewrite of the code, to get a emulator into things, I would of course like to test all the stuff that I don't touch (in term of videomodes). But there isn't a test catalog in dlls/krnl386.exe16. That could of course be due to the fact that it is pretty hard to write test for that old platform and get proper test on a live version. Or am I missing something here? Looking over the list of videomodes, I can see that a lot of them says supported. Is that really true or do they simply not break? Again is there anyway to test that those modes are truely supported in my code change (and in the current code)? Another problem that I am facing at a later stage is that most of the games needs to be installed in win95 mode. But I think that most people will run with something like XP, Vista or Win7 as default mode. That will break most of the old installers as DOS version becomes 5.0 or something "silly" like that. So I am thinking about having to create a wrapper program where you can install your old programs through so the mode gets set correctly during install. And perhaps also creates some proper shortcuts in the menu. And perhaps even into the new game database that new windows version have. And thoughts/ideas on this? Another way to handle this would be to do something like a MD5 on the install.exe (hoping that they differ) and then look up in the AppDB, to see which mode to use as installer mode (and run mode). Yes, that would most likely require changes to AppDB. But I can see a use for this even for the above wrapper program (Autodetect using AppDB). Once I get a new VGA "driver" running, I will most likely start looking into INT10h and others that try to interface to the VGA "driver". Best Regards Morten Rønne

7 8

Re: 1/3 d3d9: Add an initial ColorFill regression test.
by Stefan Dösinger 13 Apr '10

13 Apr '10

Ideas for future tests: * default pool textures * default pool rendertarget textures * default pool depth stencil textures * managed pool textures * default pool depthstencil surfaces Am 12.04.2010 um 21:06 schrieb Roderick Colenbrander: > > <0008-d3d9-Add-an-initial-ColorFill-regression-test.patch>

1 0

Re: winmm: MCI system commands are not eligible for auto-open. (try 2)
by Dmitry Timoshkov 13 Apr '10

13 Apr '10

<Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > + FIXME("(%04x) vkey %04X stub\n", dwFlags, lpParms->nVirtKey); That change is unwanted. > - if (dwFlags & MCI_NOTIFY) > - mciDriverNotify((HWND)lpParms->dwCallback, wDevID, > - (dwRet == 0) ? MCI_NOTIFY_SUCCESSFUL : MCI_NOTIFY_FAILURE); > - > + if (MMSYSERR_NOERROR==dwRet && (dwFlags & MCI_NOTIFY)) > + mciDriverNotify((HWND)lpParms->dwCallback, wDevID, MCI_NOTIFY_SUCCESSFUL); > return dwRet; > } > > @@ -1903,10 +1906,9 @@ static DWORD MCI_Sound(UINT wDevID, DWORD dwFlags, LPMCI_SOUND_PARMSW lpParms) > dwRet = sndPlaySoundW(lpParms->lpstrSoundName, SND_SYNC) ? MMSYSERR_NOERROR : MMSYSERR_ERROR; > else > dwRet = MMSYSERR_ERROR; /* what should be done ??? */ > - if (dwFlags & MCI_NOTIFY) > - mciDriverNotify((HWND)lpParms->dwCallback, wDevID, > - (dwRet == 0) ? MCI_NOTIFY_SUCCESSFUL : MCI_NOTIFY_FAILURE); > > + if (MMSYSERR_NOERROR==dwRet && (dwFlags & MCI_NOTIFY)) > + mciDriverNotify((HWND)lpParms->dwCallback, wDevID, MCI_NOTIFY_SUCCESSFUL); > return dwRet; > } Do you have a test case which shows that notofication is not sent is the failure case? Also 'if (MMSYSERR_NOERROR==dwRet' misses spaces, and having comparison reversed doesn't match the style of the surrounding code. -- 1.5.6.3 [text/plain (2B)] -- Dmitry.

4 8

Re: [PATCH 7/7] wined3d: Move A4L4 conversion to the formats table.
by winetestbot＠geldorp.nl 13 Apr '10

13 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.geldorp.nl/JobDetails.pl?Key=1399 Your paranoid android. === WINEBUILD (Wine build VM) === Patch failed

7 9

TestBot moved to new address
by Greg Geldorp 13 Apr '10

13 Apr '10

The TestBot has moved to a new location: http://testbot.winehq.org You will be automatically redirected if you use the old address. Thanks to Jeremy Newman who helped me set this up. Ge.

1 0

Re: [PATCH] d3dx9_36/tests: Move surface tests into surface.c (try 2)
by winetestbot＠geldorp.nl 12 Apr '10

12 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.geldorp.nl/JobDetails.pl?Key=1401 Your paranoid android. === WINEBUILD (Wine build VM) === Make failed

1 0

Re: winmm: MCI system commands are not eligible for auto-open. (try 2)
by Dmitry Timoshkov 12 Apr '10

12 Apr '10

[cc:ing wine-devel] <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > this is the second time that AJ commits a patch of mine despite > a comment of yours. I think that Alexandre has commited your patch slightly in a hurry, usually he waits at least several hours unless the patch is obviously correct (which is not the case here IMO). > Should I send a subsequent patch that takes > all your comments into consideration? In my opinion your patch should be reverted until all the changes have appropriate test cases, and that patch makes the tests pass (i.e. remove existing todo_wine statements). -- Dmitry.

1 0

Re: d3dx9: Implement D3DXDeclaratorFromFVF with tests
by Henri Verbeet 12 Apr '10

12 Apr '10

Formatting, among others.

2 2

Re: [PATCH 10/10] wined3d: Add BLT_OP_COLOR_FILL to blit_supported and use it in BltOverride.
by Henri Verbeet 12 Apr '10

12 Apr '10

On 12 April 2010 12:44, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > + if (ffp_blit.blit_supported(&myDevice->adapter->gl_info, BLIT_OP_COLOR_FILL, > + NULL, 0, 0, NULL, > + &dst_rect, This->resource.usage, This->resource.pool, This->resource.format_desc)) > + { > + return ffp_blit.color_fill(myDevice, This, &dst_rect, color); > } > > - return ffp_blit.color_fill(myDevice, This, &dst_rect, color); > + return cpu_blit.color_fill(myDevice, This, &dst_rect, color); > } > } > Going through struct blit_shader means that you should also check if cpu_blit can do that operation.

1 0

Re: [PATCH 09/10] wined3d: Improve FBO support in ClearSurface.
by Henri Verbeet 12 Apr '10

12 Apr '10

On 12 April 2010 12:44, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > - context = context_acquire(This, (IWineD3DSurface *)target, CTXUSAGE_CLEAR); > + if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) > + { > + if (!surface_is_offscreen((IWineD3DSurface *)target)) > + { > + TRACE("Surface %p is onscreen\n", target); > + > + context = context_acquire(This, (IWineD3DSurface *)target, CTXUSAGE_RESOURCELOAD); > + ENTER_GL(); > + context_bind_fbo(context, GL_FRAMEBUFFER, NULL); > + context_set_draw_buffer(context, surface_get_gl_buffer((IWineD3DSurface *)target)); > + LEAVE_GL(); > + } > + else > + { > + TRACE("Surface %p is offscreen\n", target); > + > + context = context_acquire(This, NULL, CTXUSAGE_RESOURCELOAD); > + ENTER_GL(); > + context_bind_fbo(context, GL_FRAMEBUFFER, &context->dst_fbo); > + context_attach_surface_fbo(context, GL_FRAMEBUFFER, 0, (IWineD3DSurface *)target); > + context_attach_depth_stencil_fbo(context, GL_FRAMEBUFFER, NULL, FALSE); > + LEAVE_GL(); > + } > + } > + else > + { > + context = context_acquire(This, (IWineD3DSurface *)target, CTXUSAGE_CLEAR); > + } > + That doesn't work of course, CTXUSAGE_CLEAR isn't there just for show.

1 0

Re: [PATCH 03/10] wined3d: Move D24X4S4 to the formats table.
by Henri Verbeet 12 Apr '10

12 Apr '10

On 12 April 2010 12:44, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > {WINED3DFMT_D16_UNORM, GL_DEPTH_COMPONENT24_ARB, GL_DEPTH_COMPONENT24_ARB, 0, > GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT, 0, > WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING | WINED3DFMT_FLAG_FILTERING | WINED3DFMT_FLAG_DEPTH, > - ARB_DEPTH_TEXTURE, NULL}, > + ARB_DEPTH_TEXTURE, &convert_s4x4_uint_d24_unorm}, That's wrong.

1 0

Re: wineserver: Fix French manpage
by Nicolas Le Cam 12 Apr '10

12 Apr '10

Hi Frédéric, >+processus clients se sont terminés. Ceci évite le coût inhérent à l'arrêt sont -> soient >+\fIwineserver\fR dans le chemin système ou quelques autres emplacements vraisemblables. "potentiels" or "possibles" suit better. -- Nicolas Le Cam

2 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel