- wine-devel - winehq.org

Future implementation
by Luis Busquets 14 Apr '10

14 Apr '10

Could someone please confirm the following points?: 1. Sound system. The configuration that wine will implement is: winmm --> WASAPI --> OpenAL and DirectSound --> OpenAL After that is done wineoss, winejack, winealsa, ... will be removed from the tree. 2. Integration of DosBOX or other emulator. How this will be done? Is the plan to use them when wine detects that the programme is compiled for real mode? Does that mean that the sake of wine is to provide compatibility only for applications built to be run on protected mode? 3. Direct3D10 and Direct3D11, Is there a target date for them?

8 7

Re: configure: when compiling with CLANG, set -std=gnu89
by Alexandre Julliard 14 Apr '10

14 Apr '10

Austin English <austinenglish(a)gmail.com> writes: > Clang defaults to compiling in C99 mode, which breaks the compile. Of course the compile should be fixed instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] urlmon/tests: CoInternetCreateSecurityManager not present on W95B
by Jacek Caban 14 Apr '10

14 Apr '10

On 4/13/10 11:49 PM, Detlef Riekenberg wrote: > --- > dlls/urlmon/tests/sec_mgr.c | 17 ++++++++++++----- > 1 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/dlls/urlmon/tests/sec_mgr.c b/dlls/urlmon/tests/sec_mgr.c > index e758115..8e39301 100644 > --- a/dlls/urlmon/tests/sec_mgr.c > +++ b/dlls/urlmon/tests/sec_mgr.c > @@ -107,8 +107,10 @@ static void test_SecurityManager(void) > DWORD zone, size, policy; > HRESULT hres; > > - hres = CoInternetCreateSecurityManager(NULL,&secmgr, 0); > - ok(hres == S_OK, "CoInternetCreateSecurityManager failed: %08x\n", hres); > + hres = CoCreateInstance(&CLSID_InternetSecurityManager, NULL, CLSCTX_INPROC_SERVER, > +&IID_IInternetSecurityManager, (void **)&secmgr); > + > + ok(hres == S_OK, "CoCreateInstance for IInternetSecurityManager failed: %08x\n", hres); > if(FAILED(hres)) > return; > You're changing what we test here. If you only want to fix tests on win98 it's a nice excuse to skip tests. If you want to test CLSID_InternetSecurityManager anyway, you should test both CLSID_InternetSecurityManager and CoInternetCreateSecurityManager. Same for zone manager patch. Jacek

1 0

Re: [PATCH 09/16] Replaced mycomputer.ico with a Tango compliant icon
by Paul Vriens 14 Apr '10

14 Apr '10

On 04/13/2010 10:59 PM, Joel Holdsworth wrote: > Signed-off-by: Joel Holdsworth<joel(a)airwebreathe.org.uk> > --- > dlls/shell32/mycomputer.ico | Bin 15086 -> 25214 bytes > dlls/shell32/mycomputer.svg | 2400 ++++++++++++++++++++++++++----------------- > 2 files changed, 1477 insertions(+), 923 deletions(-) > > > > > > Hi Joel, I think this has been mentioned before, but the monitor icons (32-bit and 8-bit for size 32) show a wider lower half of the monitor compared to the upper half (I think the 32-bit size 22 as well). -- Cheers, Paul.

3 4

Re: [PATCH 5/5] winex11.drv: Allow OpenGL on minimized windows.
by Florian Köberle 14 Apr '10

14 Apr '10

Hello Henri, your patch fixes bug 12611: http://bugs.winehq.org/show_bug.cgi?id=12611 Thanks for your great work! You have worked on quite a few bugs I have voted for. Would be buying Crossover Games (again) the correct way to support your work? Best regards, Florian

2 1

Re: [PATCH 3/5] wined3d: Disable strict draw ordering by default.
by Stefan Dösinger 14 Apr '10

14 Apr '10

Am 13.04.2010 um 20:46 schrieb Henri Verbeet: > + if (wined3d_settings.strict_draw_ordering) wglFlush(); /* Flush to ensure ordering across contexts. */ I'd prefer to have this in an (inline) function.

2 3

Re: user32: BM_SETSTATE handler needs to repaint the button including focus rectangle.
by Alexandre Julliard 14 Apr '10

14 Apr '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > While playing with the button painting bug I noticed that the button doesn't > repaint its focus when you hold mouse button and move it outside and then back > to the button. It looks to me that you should fix the push button paint routine, instead of changing the notification type. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/1] wcmd/tests: Attrib tests (resend)
by testbot＠testbot.winehq.org 13 Apr '10

13 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1423 Your paranoid android. === WINEBUILD (Wine build VM) === Make failed

1 0

Re: [5/5] msi: Move application of substorage transforms out of msi_parse_patch_summary.
by testbot＠testbot.winehq.org 13 Apr '10

13 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.nl/JobDetails.pl?Key=1407 Your paranoid android. === W7PROX64 (Windows 7 Professional 64 bit) === install.c:4613: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4616: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4636: Test failed: Key doesn't exist or wrong type install.c:4637: Test failed: Key doesn't exist or wrong type install.c:4639: Test failed: Key doesn't exist or wrong type install.c:4640: Test failed: Key doesn't exist or wrong type install.c:4643: Test failed: Key doesn't exist or wrong type install.c:4652: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4661: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4663: Test failed: Key doesn't exist or wrong type install.c:4712: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4715: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4735: Test failed: Key doesn't exist or wrong type install.c:4736: Test failed: Key doesn't exist or wrong type install.c:4738: Test failed: Key doesn't exist or wrong type install.c:4739: Test failed: Key doesn't exist or wrong type install.c:4742: Test failed: Key doesn't exist or wrong type install.c:4751: Test failed: Expected ERROR_SUCCESS, got 6 install.c:4760: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4762: Test failed: Key doesn't exist or wrong type install.c:5047: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5049: Test failed: Key doesn't exist or wrong type install.c:5050: Test failed: Key doesn't exist or wrong type install.c:5082: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5084: Test failed: Key doesn't exist or wrong type install.c:5085: Test failed: Key doesn't exist or wrong type install.c:5191: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5193: Test failed: Key doesn't exist or wrong type install.c:5194: Test failed: Key doesn't exist or wrong type install.c:5195: Test failed: Key doesn't exist or wrong type install.c:5212: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5214: Test failed: Key doesn't exist or wrong type install.c:5215: Test failed: Key doesn't exist or wrong type install.c:5216: Test failed: Key doesn't exist or wrong type install.c:5269: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5274: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5279: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5292: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5297: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5298: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5317: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5322: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5323: Test failed: Expected "C:\Program Files (x86)\msitest\maximus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5336: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5341: Test failed: Expected ERROR_SUCCESS, got 6 install.c:5342: Test failed: Expected "01\msitest\augustus", got "Software\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Products\84A88FD7F6998CE40A22FB59F6B9C2BB\InstallProperties" install.c:5390: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5400: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 install.c:5401: Test failed: Expected INSTALLSTATE_UNKNOWN, got 3 install.c:5413: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5423: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 install.c:5424: Test failed: Expected INSTALLSTATE_UNKNOWN, got 3 install.c:5446: Test failed: Expected ERROR_UNKNOWN_COMPONENT, got 0 install.c:5447: Test failed: Expected INSTALLSTATE_UNKNOWN, got 3 install.c:5487: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5501: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:5550: Test failed: Expected 12 or -12, got 24 install.c:5562: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5576: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:5625: Test failed: Expected 12 or -12, got 36 install.c:5677: Test failed: Expected 12 or -12, got 36 install.c:5729: Test failed: Expected 12 or -20, got 36 install.c:5741: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5755: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:5804: Test failed: Expected 12 or -12, got 48 install.c:5816: Test failed: Expected INSTALLSTATE_UNKNOWN, got 2 install.c:5830: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:7455: Test failed: Expected ERROR_SUCCESS, got 2 install.c:7459: Test failed: Expected ERROR_SUCCESS, got 6 install.c:7465: Test failed: Expected ERROR_INSTALL_SOURCE_ABSENT, got 0 install.c:7467: Test failed: File not installed install.c:7468: Test failed: File not installed install.c:7469: Test failed: File not installed install.c:7470: Test failed: File not installed install.c:7479: Test failed: Expected ERROR_SUCCESS, got 1605 install.c:7498: Test failed: Expected ERROR_SUCCESS, got 2 install.c:7502: Test failed: Expected ERROR_SUCCESS, got 6 install.c:7524: Test failed: Expected ERROR_INSTALL_SOURCE_ABSENT, got 0 install.c:7526: Test failed: File not installed install.c:7527: Test failed: File not installed install.c:7528: Test failed: File not installed install.c:7529: Test failed: File not installed install.c:7534: Test failed: Expected ERROR_SUCCESS, got 1018 install.c:7540: Test failed: Expected ERROR_SUCCESS, got 1605 === W7PROX64 (Windows 7 Professional 64 bit) === install.c:3378: Test failed: File not installed install.c:3379: Test failed: File not installed install.c:3380: Test failed: File not installed install.c:3381: Test failed: File not installed install.c:3382: Test failed: File not installed install.c:3385: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3390: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3391: Test failed: Expected imaname, got install.c:3396: Test failed: Expected ERROR_FILE_NOT_FOUND, got 6 install.c:3401: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3402: Test failed: Expected 314, got 2047 install.c:3407: Test failed: Expected ERROR_SUCCESS, got 6 install.c:3408: Test failed: Expected OrderTestValue, got install.c:3425: Test failed: File not installed install.c:3426: Test failed: File not installed install.c:3427: Test failed: File not installed install.c:3428: Test failed: File not installed install.c:3429: Test failed: File not installed install.c:3432: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3448: Test failed: File not installed install.c:3449: Test failed: File not installed install.c:3450: Test failed: File not installed install.c:3451: Test failed: File not installed install.c:3452: Test failed: File not installed install.c:3455: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3471: Test failed: File not installed install.c:3472: Test failed: File not installed install.c:3473: Test failed: File not installed install.c:3474: Test failed: File not installed install.c:3475: Test failed: File not installed install.c:3478: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3494: Test failed: File not installed install.c:3495: Test failed: File not installed install.c:3496: Test failed: File not installed install.c:3497: Test failed: File not installed install.c:3498: Test failed: File not installed install.c:3501: Test failed: Expected ERROR_SUCCESS, got 2 install.c:3517: Test failed: File not installed install.c:3518: Test failed: File not installed install.c:3519: Test failed: File not installed install.c:3520: Test failed: File not installed install.c:3521: Test failed: File not installed install.c:3539: Test failed: File not installed install.c:3540: Test failed: File not installed install.c:3541: Test failed: File not installed install.c:3542: Test failed: File not installed install.c:3543: Test failed: File not installed install.c:3561: Test failed: File not installed install.c:3562: Test failed: File not installed install.c:3563: Test failed: File not installed install.c:3564: Test failed: File not installed install.c:3565: Test failed: File not installed install.c:3583: Test failed: File not installed install.c:3584: Test failed: File not installed install.c:3585: Test failed: File not installed install.c:3586: Test failed: File not installed install.c:3587: Test failed: File not installed install.c:3605: Test failed: File not installed install.c:3606: Test failed: File not installed install.c:3607: Test failed: File not installed install.c:3608: Test failed: File not installed install.c:3609: Test failed: File not installed install.c:3788: Test failed: File not installed install.c:3789: Test failed: File not installed install.c:3790: Test failed: File not installed install.c:3791: Test failed: File not installed install.c:3804: Test failed: File not installed install.c:3806: Test failed: File not installed install.c:3807: Test failed: File not installed install.c:3808: Test failed: File not installed install.c:3832: Test failed: Expected ERROR_INSTALL_FAILURE, got 0 install.c:3864: Test failed: Expected ERROR_INSTALL_FAILURE, got 0 install.c:3914: Test failed: File not installed install.c:3915: Test failed: File not installed install.c:3916: Test failed: File not installed install.c:3917: Test failed: File not installed install.c:3941: Test failed: File not installed install.c:3942: Test failed: File not installed install.c:3943: Test failed: File not installed install.c:3944: Test failed: File not installed install.c:3965: Test failed: File not installed install.c:3966: Test failed: File not installed install.c:3967: Test failed: File not installed install.c:4016: Test failed: Expected file to be overwritten install.c:4017: Test failed: File not installed install.c:4018: Test failed: File not installed install.c:4064: Test failed: Expected file to be overwritten, got '' install.c:4065: Test failed: File not installed install.c:4066: Test failed: File not installed install.c:4251: Test failed: File not installed install.c:4252: Test failed: File not installed install.c:4280: Test failed: File not installed install.c:4281: Test failed: File not installed install.c:4282: Test failed: File not installed install.c:4283: Test failed: File not installed install.c:4284: Test failed: File not installed install.c:4318: Test failed: File not installed install.c:4319: Test failed: File not installed install.c:4325: Test failed: File not installed install.c:4327: Test failed: File not installed install.c:4364: Test failed: File not installed install.c:4365: Test failed: File not installed install.c:4572: Test failed: File not installed install.c:4573: Test failed: File not installed install.c:4579: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4598: Test failed: Key doesn't exist or wrong type install.c:4599: Test failed: Key doesn't exist or wrong type install.c:4601: Test failed: Key doesn't exist or wrong type install.c:4602: Test failed: Key doesn't exist or wrong type install.c:4605: Test failed: Key doesn't exist or wrong type install.c:4671: Test failed: File not installed install.c:4672: Test failed: File not installed install.c:4678: Test failed: Expected ERROR_SUCCESS, got 2 install.c:4697: Test failed: Key doesn't exist or wrong type install.c:4698: Test failed: Key doesn't exist or wrong type install.c:4700: Test failed: Key doesn't exist or wrong type install.c:4701: Test failed: Key doesn't exist or wrong type install.c:4704: Test failed: Key doesn't exist or wrong type install.c:4813: Test failed: File not installed install.c:4814: Test failed: File not installed install.c:4911: Test failed: File not installed install.c:4912: Test failed: File not installed install.c:5025: Test failed: File not installed install.c:5026: Test failed: File not installed install.c:5060: Test failed: File not installed install.c:5061: Test failed: File not installed install.c:5185: Test failed: File not installed install.c:5186: Test failed: File not installed install.c:5206: Test failed: File not installed install.c:5207: Test failed: File not installed install.c:5263: Test failed: File not installed install.c:5264: Test failed: File not installed install.c:5279: Test failed: Expected "C:\Program Files\msitest\maximus", got "C:\Program Files (x86)\msitest\maximus" install.c:5311: Test failed: File not installed install.c:5312: Test failed: File not installed install.c:5323: Test failed: Expected "C:\Program Files\msitest\maximus", got "C:\Program Files (x86)\msitest\maximus" install.c:5450: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5469: Test failed: Key doesn't exist or wrong type install.c:5470: Test failed: Key doesn't exist or wrong type install.c:5472: Test failed: Key doesn't exist or wrong type install.c:5473: Test failed: Key doesn't exist or wrong type install.c:5476: Test failed: Key doesn't exist or wrong type install.c:5524: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5543: Test failed: Key doesn't exist or wrong type install.c:5544: Test failed: Key doesn't exist or wrong type install.c:5546: Test failed: Key doesn't exist or wrong type install.c:5547: Test failed: Key doesn't exist or wrong type install.c:5550: Test failed: Key doesn't exist or wrong type install.c:5558: Test failed: File not deleted install.c:5559: Test failed: Directory not deleted install.c:5599: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5618: Test failed: Key doesn't exist or wrong type install.c:5619: Test failed: Key doesn't exist or wrong type install.c:5621: Test failed: Key doesn't exist or wrong type install.c:5622: Test failed: Key doesn't exist or wrong type install.c:5625: Test failed: Key doesn't exist or wrong type install.c:5651: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5670: Test failed: Key doesn't exist or wrong type install.c:5671: Test failed: Key doesn't exist or wrong type install.c:5673: Test failed: Key doesn't exist or wrong type install.c:5674: Test failed: Key doesn't exist or wrong type install.c:5677: Test failed: Key doesn't exist or wrong type install.c:5703: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5722: Test failed: Key doesn't exist or wrong type install.c:5723: Test failed: Key doesn't exist or wrong type install.c:5725: Test failed: Key doesn't exist or wrong type install.c:5726: Test failed: Key doesn't exist or wrong type install.c:5729: Test failed: Key doesn't exist or wrong type install.c:5737: Test failed: File not deleted install.c:5738: Test failed: Directory not deleted install.c:5778: Test failed: Expected ERROR_SUCCESS, got 2 install.c:5797: Test failed: Key doesn't exist or wrong type install.c:5798: Test failed: Key doesn't exist or wrong type install.c:5800: Test failed: Key doesn't exist or wrong type install.c:5801: Test failed: Key doesn't exist or wrong type install.c:5804: Test failed: Key doesn't exist or wrong type install.c:5812: Test failed: File not deleted install.c:5813: Test failed: Directory not deleted install.c:5864: Test failed: File not installed install.c:5865: Test failed: File not installed install.c:5886: Test failed: File not installed install.c:5887: Test failed: File not installed install.c:5908: Test failed: File not installed install.c:5909: Test failed: File not installed install.c:5930: Test failed: File not installed install.c:5931: Test failed: File not installed install.c:5952: Test failed: File not installed install.c:5953: Test failed: File not installed install.c:6219: Test failed: File not installed install.c:6220: Test failed: File not installed install.c:6258: Test failed: File not installed install.c:6259: Test failed: File not installed install.c:6275: Test failed: File not installed install.c:6276: Test failed: File not installed install.c:6392: Test failed: File installed install.c:6393: Test failed: File installed install.c:6431: Test failed: File not installed install.c:6433: Test failed: File not installed install.c:6434: Test failed: File not installed install.c:6440: Test failed: File deleted install.c:6441: Test failed: File deleted install.c:6457: Test failed: File not deleted install.c:6460: Test failed: File deleted install.c:6479: Test failed: File not installed install.c:6480: Test failed: File not deleted install.c:6486: Test failed: File not deleted install.c:6487: Test failed: File not deleted install.c:6488: Test failed: File not deleted install.c:6501: Test failed: File not deleted install.c:6503: Test failed: File deleted install.c:6507: Test failed: File not deleted install.c:6508: Test failed: File not deleted install.c:6510: Test failed: File not deleted install.c:6511: Test failed: File not deleted install.c:6518: Test failed: File not installed install.c:6520: Test failed: File not installed install.c:6528: Test failed: Directory not deleted install.c:6584: Test failed: File not installed install.c:6586: Test failed: File not copied install.c:6587: Test failed: File not moved install.c:6591: Test failed: File not moved install.c:6594: Test failed: File not moved install.c:6597: Test failed: File not moved install.c:6600: Test failed: File not moved install.c:6603: Test failed: File not moved install.c:6609: Test failed: File not moved install.c:6612: Test failed: File not moved install.c:6613: Test failed: File not moved install.c:6615: Test failed: File not moved install.c:6616: Test failed: File not moved install.c:6618: Test failed: File not installed install.c:6715: Test failed: File not installed install.c:6716: Test failed: File not duplicated install.c:6717: Test failed: File not duplicated install.c:6718: Test failed: File not duplicated install.c:6719: Test failed: File not duplicated install.c:6720: Test failed: File not duplicated install.c:6721: Test failed: File not installed install.c:6745: Test failed: File installed install.c:6746: Test failed: File installed install.c:6749: Test failed: Expected ERROR_SUCCESS, got 2 install.c:6755: Test failed: Expected ERROR_SUCCESS, got 6 install.c:6756: Test failed: Wrong multi-sz data install.c:6757: Test failed: Expected 15, got 260 install.c:6780: Test failed: Expected ERROR_INSTALL_FAILURE, got 0 install.c:6816: Test failed: File installed install.c:6817: Test failed: File installed install.c:6848: Test failed: File not installed install.c:6850: Test failed: File not installed install.c:6851: Test failed: File not installed install.c:6860: Test failed: File not installed install.c:6866: Test failed: File not installed install.c:6869: Test failed: File not installed install.c:6870: Test failed: File not installed install.c:6872: Test failed: File not installed install.c:6876: Test failed: File not installed install.c:6880: Test failed: File not installed install.c:6883: Test failed: File not installed install.c:6886: Test failed: File not installed install.c:6892: Test failed: File not installed install.c:7371: Test failed: File not installed install.c:7372: Test failed: File not installed install.c:7373: Test failed: File not installed install.c:7374: Test failed: File not installed install.c:7396: Test failed: File not installed install.c:7397: Test failed: File not installed install.c:7398: Test failed: File not installed install.c:7399: Test failed: File not installed install.c:7421: Test failed: File not installed install.c:7422: Test failed: File not installed install.c:7423: Test failed: File not installed install.c:7424: Test failed: File not installed install.c:7443: Test failed: File not installed install.c:7444: Test failed: File not installed install.c:7445: Test failed: File not installed install.c:7446: Test failed: File not installed install.c:7467: Test failed: File not installed install.c:7468: Test failed: File not installed install.c:7469: Test failed: File not installed install.c:7470: Test failed: File not installed install.c:7488: Test failed: File not installed install.c:7489: Test failed: File not installed install.c:7490: Test failed: File not installed install.c:7491: Test failed: File not installed install.c:7526: Test failed: File not installed install.c:7527: Test failed: File not installed install.c:7528: Test failed: File not installed install.c:7529: Test failed: File not installed install.c:7571: Test failed: File not installed install.c:7572: Test failed: File not installed install.c:7573: Test failed: File not installed install.c:7575: Test failed: File not installed install.c:7607: Test failed: File installed install.c:7608: Test failed: File installed install.c:7621: Test failed: File installed install.c:7622: Test failed: File installed install.c:7661: Test failed: File not installed install.c:7662: Test failed: File not installed install.c:7663: Test failed: File not installed install.c:7664: Test failed: File not installed install.c:7665: Test failed: File not installed install.c:7695: Test failed: File not installed install.c:7696: Test failed: File not installed install.c:7937: Test failed: File not installed install.c:7948: Test failed: File not installed install.c:7951: Test failed: File not installed install.c:7952: Test failed: File not installed install.c:7954: Test failed: File not installed install.c:7955: Test failed: File not installed install.c:7982: Test failed: File not installed install.c:7985: Test failed: File not installed install.c:7986: Test failed: File not installed install.c:7987: Test failed: File installed install.c:7988: Test failed: File not installed install.c:7989: Test failed: File not installed install.c:8234: Test failed: Expected ERROR_SUCCESS_REBOOT_REQUIRED got 0 install.c:8132: Test failed: RegQueryValueExA failed 2 (0) install.c:8173: Test failed: Expected a 'msitest' entry install.c:8194: Test failed: Expected file to match install.c:8285: Test failed: Expected ERROR_SUCCESS_REBOOT_REQUIRED got 0 install.c:8173: Test failed: Expected a 'msitest' entry install.c:8194: Test failed: Expected file to match install.c:8014: Test failed: File not installed install.c:8017: Test failed: File not installed install.c:8018: Test failed: File not installed install.c:8019: Test failed: File installed install.c:8020: Test failed: File not installed install.c:8021: Test failed: File not installed install.c:8041: Test failed: File not installed install.c:8044: Test failed: File not installed install.c:8045: Test failed: File not installed install.c:8046: Test failed: File installed install.c:8047: Test failed: File not installed install.c:8048: Test failed: File not installed install.c:8068: Test failed: File not installed install.c:8071: Test failed: File not installed install.c:8072: Test failed: File not installed install.c:8073: Test failed: File installed install.c:8074: Test failed: File not installed install.c:8075: Test failed: File not installed install.c:8401: Test failed: File not installed install.c:8403: Test failed: File not installed install.c:8547: Test failed: File not installed install.c:8548: Test failed: Directory not created install.c:8549: Test failed: File not installed install.c:8550: Test failed: Directory not created install.c:8552: Test failed: Directory not created install.c:8553: Test failed: File not installed install.c:8554: Test failed: Directory not created install.c:8555: Test failed: File not installed install.c:8556: Test failed: File not installed install.c:8557: Test failed: File not installed install.c:8558: Test failed: Directory not created install.c:8589: Test failed: File not installed install.c:8590: Test failed: Directory not created install.c:8591: Test failed: File not installed install.c:8592: Test failed: Directory not created install.c:8594: Test failed: Directory not created install.c:8595: Test failed: File not installed install.c:8596: Test failed: Directory not created install.c:8597: Test failed: File not installed install.c:8598: Test failed: File not installed install.c:8599: Test failed: File not installed install.c:8600: Test failed: Directory not created install.c:8617: Test failed: File not installed install.c:8618: Test failed: Directory not created install.c:8619: Test failed: File not installed install.c:8620: Test failed: Directory not created install.c:8622: Test failed: Directory not created install.c:8623: Test failed: File not installed install.c:8624: Test failed: Directory not created install.c:8625: Test failed: File not installed install.c:8626: Test failed: File not installed install.c:8627: Test failed: File not installed install.c:8628: Test failed: Directory not created install.c:8692: Test failed: File not installed install.c:8693: Test failed: Directory not created install.c:8694: Test failed: File not installed install.c:8695: Test failed: Directory not created install.c:8697: Test failed: Directory not created install.c:8698: Test failed: File not installed install.c:8699: Test failed: Directory not created install.c:8700: Test failed: File not installed install.c:8701: Test failed: File not installed install.c:8702: Test failed: File not installed install.c:8703: Test failed: Directory not created install.c:8725: Test failed: file not created install.c:8726: Test failed: file not created install.c:8727: Test failed: file not created install.c:8728: Test failed: file not created install.c:8729: Test failed: file not created install.c:8788: Test failed: file not created install.c:8789: Test failed: file not created install.c:8855: Test failed: file not created install.c:8856: Test failed: file not created install.c:8858: Test failed: file not created install.c:8864: Test failed: file removed install.c:8869: Test failed: directory removed install.c:8916: Test failed: key not removed install.c:8926: Test failed: key not removed install.c:8937: Test failed: key not removed install.c:9011: Test failed: got 6 expected 0 install.c:9017: Test failed: got 6 expected 0 install.c:9020: Test failed: got 6 expected 0 install.c:9022: Test failed: file removed install.c:9167: Test failed: key not created

4 3

Re: ddraw: Do not restore the display mode from inside SetCooperativeLevel
by Johan Gill 13 Apr '10

13 Apr '10

It seems this patch wasn't accepted yet. Are there any issues I should know about? Regards Johan Gill

1 0

Re: Detecting patch sets
by Dan Kegel 13 Apr '10

13 Apr '10

Hi Ge, when I was running patchwatcher, taking the number of patches in the series helped more than it hurt. (It's fairly frequent for people to submit two patchsets, and fairly infrequent for the second patchset to have the same number of patches.) The darn interface needed babysitting, though, since there were always malformed and/or partial series. I think it'd be cool to have a UI where developers could correct their detected patchsets if they don't like what the automated extractor did. That could morph into a way of submitting patchsets in the first place later on. It'd also be cool if other tools - say, a buildbot or a patchwatcher - could monitor the detected patchset stream (to save them from having to maintain their own). - Dan

3 2

Working on "DOS" VGA.
by Morten Rønne 13 Apr '10

13 Apr '10

Hi Wine-devel My name is Morten and I would like for some of my old DOS/WIN95 games to work with wine. :) I know that I most likely could solve this by using DOSbox and/or DOSemu. But I don't consider either of them user friendly in it's raw form. And I hope in the future it could be more of a Go to this menu item, click a few choices and then play game thing. So I have been looking into what one of them is needing (XCOM Apocalypse). The first thing that needs work is the VGA screen driver. The game needs one of the unsupported video modes. After looking further into it, I can see that the current screen driver, needs to be more of an emulator than just a copy of the framebuffer/RAM window to/from the DirectDraw surface. But since I need to do a lot rewrite of the code, to get a emulator into things, I would of course like to test all the stuff that I don't touch (in term of videomodes). But there isn't a test catalog in dlls/krnl386.exe16. That could of course be due to the fact that it is pretty hard to write test for that old platform and get proper test on a live version. Or am I missing something here? Looking over the list of videomodes, I can see that a lot of them says supported. Is that really true or do they simply not break? Again is there anyway to test that those modes are truely supported in my code change (and in the current code)? Another problem that I am facing at a later stage is that most of the games needs to be installed in win95 mode. But I think that most people will run with something like XP, Vista or Win7 as default mode. That will break most of the old installers as DOS version becomes 5.0 or something "silly" like that. So I am thinking about having to create a wrapper program where you can install your old programs through so the mode gets set correctly during install. And perhaps also creates some proper shortcuts in the menu. And perhaps even into the new game database that new windows version have. And thoughts/ideas on this? Another way to handle this would be to do something like a MD5 on the install.exe (hoping that they differ) and then look up in the AppDB, to see which mode to use as installer mode (and run mode). Yes, that would most likely require changes to AppDB. But I can see a use for this even for the above wrapper program (Autodetect using AppDB). Once I get a new VGA "driver" running, I will most likely start looking into INT10h and others that try to interface to the VGA "driver". Best Regards Morten Rønne

7 8

Re: 1/3 d3d9: Add an initial ColorFill regression test.
by Stefan Dösinger 13 Apr '10

13 Apr '10

Ideas for future tests: * default pool textures * default pool rendertarget textures * default pool depth stencil textures * managed pool textures * default pool depthstencil surfaces Am 12.04.2010 um 21:06 schrieb Roderick Colenbrander: > > <0008-d3d9-Add-an-initial-ColorFill-regression-test.patch>

1 0

Re: winmm: MCI system commands are not eligible for auto-open. (try 2)
by Dmitry Timoshkov 13 Apr '10

13 Apr '10

<Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > + FIXME("(%04x) vkey %04X stub\n", dwFlags, lpParms->nVirtKey); That change is unwanted. > - if (dwFlags & MCI_NOTIFY) > - mciDriverNotify((HWND)lpParms->dwCallback, wDevID, > - (dwRet == 0) ? MCI_NOTIFY_SUCCESSFUL : MCI_NOTIFY_FAILURE); > - > + if (MMSYSERR_NOERROR==dwRet && (dwFlags & MCI_NOTIFY)) > + mciDriverNotify((HWND)lpParms->dwCallback, wDevID, MCI_NOTIFY_SUCCESSFUL); > return dwRet; > } > > @@ -1903,10 +1906,9 @@ static DWORD MCI_Sound(UINT wDevID, DWORD dwFlags, LPMCI_SOUND_PARMSW lpParms) > dwRet = sndPlaySoundW(lpParms->lpstrSoundName, SND_SYNC) ? MMSYSERR_NOERROR : MMSYSERR_ERROR; > else > dwRet = MMSYSERR_ERROR; /* what should be done ??? */ > - if (dwFlags & MCI_NOTIFY) > - mciDriverNotify((HWND)lpParms->dwCallback, wDevID, > - (dwRet == 0) ? MCI_NOTIFY_SUCCESSFUL : MCI_NOTIFY_FAILURE); > > + if (MMSYSERR_NOERROR==dwRet && (dwFlags & MCI_NOTIFY)) > + mciDriverNotify((HWND)lpParms->dwCallback, wDevID, MCI_NOTIFY_SUCCESSFUL); > return dwRet; > } Do you have a test case which shows that notofication is not sent is the failure case? Also 'if (MMSYSERR_NOERROR==dwRet' misses spaces, and having comparison reversed doesn't match the style of the surrounding code. -- 1.5.6.3 [text/plain (2B)] -- Dmitry.

4 8

Re: [PATCH 7/7] wined3d: Move A4L4 conversion to the formats table.
by winetestbot＠geldorp.nl 13 Apr '10

13 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.geldorp.nl/JobDetails.pl?Key=1399 Your paranoid android. === WINEBUILD (Wine build VM) === Patch failed

7 9

TestBot moved to new address
by Greg Geldorp 13 Apr '10

13 Apr '10

The TestBot has moved to a new location: http://testbot.winehq.org You will be automatically redirected if you use the old address. Thanks to Jeremy Newman who helped me set this up. Ge.

1 0

Re: [PATCH] d3dx9_36/tests: Move surface tests into surface.c (try 2)
by winetestbot＠geldorp.nl 12 Apr '10

12 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.geldorp.nl/JobDetails.pl?Key=1401 Your paranoid android. === WINEBUILD (Wine build VM) === Make failed

1 0

Re: winmm: MCI system commands are not eligible for auto-open. (try 2)
by Dmitry Timoshkov 12 Apr '10

12 Apr '10

[cc:ing wine-devel] <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > this is the second time that AJ commits a patch of mine despite > a comment of yours. I think that Alexandre has commited your patch slightly in a hurry, usually he waits at least several hours unless the patch is obviously correct (which is not the case here IMO). > Should I send a subsequent patch that takes > all your comments into consideration? In my opinion your patch should be reverted until all the changes have appropriate test cases, and that patch makes the tests pass (i.e. remove existing todo_wine statements). -- Dmitry.

1 0

Re: d3dx9: Implement D3DXDeclaratorFromFVF with tests
by Henri Verbeet 12 Apr '10

12 Apr '10

Formatting, among others.

2 2

Re: [PATCH 10/10] wined3d: Add BLT_OP_COLOR_FILL to blit_supported and use it in BltOverride.
by Henri Verbeet 12 Apr '10

12 Apr '10

On 12 April 2010 12:44, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > + if (ffp_blit.blit_supported(&myDevice->adapter->gl_info, BLIT_OP_COLOR_FILL, > + NULL, 0, 0, NULL, > + &dst_rect, This->resource.usage, This->resource.pool, This->resource.format_desc)) > + { > + return ffp_blit.color_fill(myDevice, This, &dst_rect, color); > } > > - return ffp_blit.color_fill(myDevice, This, &dst_rect, color); > + return cpu_blit.color_fill(myDevice, This, &dst_rect, color); > } > } > Going through struct blit_shader means that you should also check if cpu_blit can do that operation.

1 0

Re: [PATCH 09/10] wined3d: Improve FBO support in ClearSurface.
by Henri Verbeet 12 Apr '10

12 Apr '10

On 12 April 2010 12:44, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > - context = context_acquire(This, (IWineD3DSurface *)target, CTXUSAGE_CLEAR); > + if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) > + { > + if (!surface_is_offscreen((IWineD3DSurface *)target)) > + { > + TRACE("Surface %p is onscreen\n", target); > + > + context = context_acquire(This, (IWineD3DSurface *)target, CTXUSAGE_RESOURCELOAD); > + ENTER_GL(); > + context_bind_fbo(context, GL_FRAMEBUFFER, NULL); > + context_set_draw_buffer(context, surface_get_gl_buffer((IWineD3DSurface *)target)); > + LEAVE_GL(); > + } > + else > + { > + TRACE("Surface %p is offscreen\n", target); > + > + context = context_acquire(This, NULL, CTXUSAGE_RESOURCELOAD); > + ENTER_GL(); > + context_bind_fbo(context, GL_FRAMEBUFFER, &context->dst_fbo); > + context_attach_surface_fbo(context, GL_FRAMEBUFFER, 0, (IWineD3DSurface *)target); > + context_attach_depth_stencil_fbo(context, GL_FRAMEBUFFER, NULL, FALSE); > + LEAVE_GL(); > + } > + } > + else > + { > + context = context_acquire(This, (IWineD3DSurface *)target, CTXUSAGE_CLEAR); > + } > + That doesn't work of course, CTXUSAGE_CLEAR isn't there just for show.

1 0

Re: [PATCH 03/10] wined3d: Move D24X4S4 to the formats table.
by Henri Verbeet 12 Apr '10

12 Apr '10

On 12 April 2010 12:44, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > {WINED3DFMT_D16_UNORM, GL_DEPTH_COMPONENT24_ARB, GL_DEPTH_COMPONENT24_ARB, 0, > GL_DEPTH_COMPONENT, GL_UNSIGNED_SHORT, 0, > WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING | WINED3DFMT_FLAG_FILTERING | WINED3DFMT_FLAG_DEPTH, > - ARB_DEPTH_TEXTURE, NULL}, > + ARB_DEPTH_TEXTURE, &convert_s4x4_uint_d24_unorm}, That's wrong.

1 0

Re: wineserver: Fix French manpage
by Nicolas Le Cam 12 Apr '10

12 Apr '10

Hi Frédéric, >+processus clients se sont terminés. Ceci évite le coût inhérent à l'arrêt sont -> soient >+\fIwineserver\fR dans le chemin système ou quelques autres emplacements vraisemblables. "potentiels" or "possibles" suit better. -- Nicolas Le Cam

2 5

Re: [PATCH] d3dx9_36/tests: Move surface tests into surface.c
by winetestbot＠geldorp.nl 12 Apr '10

12 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.geldorp.nl/JobDetails.pl?Key=1363 Your paranoid android. === W98SE (Windows 98 Second Edition) === No test summary line found === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === Failure running script in VM: Exceeded timeout limit of 300 sec === W2KPROSP4 (Windows 2000 Professional SP4) === No test summary line found === WXPPROSP3 (XP Professional SP3 (English, IE6)) === No test summary line found === W2K3R2SESP2 (Server 2003 R2 Standard Edition SP2) === No test summary line found === WVISTAADM (Windows Vista (English, IE7)) === Failure running script in VM: Exceeded timeout limit of 300 sec === W2K8SE (Server 2008 Standard Edition) === Failure running script in VM: Exceeded timeout limit of 300 sec === W7PRO (Windows 7 Professional (English, IE8)) === No test summary line found === W7PROX64 (Windows 7 Professional 64 bit) === No test summary line found === W7PROX64 (Windows 7 Professional 64 bit) === No test summary line found

2 1

winetricks failed, expecting "system32" where I have "System32" and so on
by Helge Hafting 12 Apr '10

12 Apr '10

I just tried installing gdiplus using winetricks, on a debian testing system. This failed, as winetricks tried to copy stuff into windows/system32, where I happen to have Windows/System32. I first tried making symlinks windows->Windows and system32->System32. winetricks would run, but the app using gdiplus.dll now failed to find it. The file was in Windows/System32 as expected. So I removed my links, and used search&replace on winetricks, to replace all occurences of "windows" and "system32" with captialized versions. Then I ran winetricks again. The installation succeeded this time too, but the app could still not find the dll in System32. I finally gave up and copied the dll into the directory where the app is installed. This worked, but is problematic; it will have to be done for every app that uses this dll. Helge Hafting

4 4

Re: tools: Add French translation of wineprefixcreate manpage
by Nicolas Le Cam 12 Apr '10

12 Apr '10

Hi Frédéric, >+N'afficher aucun message de statut. It doesn't really matter but as you don't use infinitive form elsewhere perhaps "N'affiche" could be better. Thanks again for your work. -- Nicolas Le Cam

2 3

updated winetricks directx-beta verb
by Austin English 12 Apr '10

12 Apr '10

Howdy all, I've updated winetricks's directx-beta verb to hopefully workaround the problems it has in wine. Using directx-beta now installs directx in winxp mode, then also extracts and regsvr's the directplay and directmusic dll's (using the winetricks directplay and the new winetricks directmusic options). Please test on your applications that need native directx dlls. I don't have an application that needs directmusic, so if it doesn't work, please let me know. If something is missing from directx-beta that is installed in win2k mode, please let me know. Get it at http://winezeug.googlecode.com/svn/trunk/winetricks -- -Austin

2 2

compiling just user32.dll
by Benzakhar 12 Apr '10

12 Apr '10

I got wine sources and I'm on a debian system. So I want to edit the function GetMenuBarInfo in user32.dll to just fill in the menu structure with some fake/resonable/constant values. I want to do this cause I think visual boy advance looks at those values and resets the screen size. And unfortunatly everytime it does it I have to press ALT+click to move it up to see the resize on bottom right and resize. I'm thinking just put some fake values especialy for the rect sturcture and have wine use it. I don't want to recompile the whole thing I'm just hoping I can compile just the user32.dll put it into windows/system32 and tell wine (which is installed from package manager) via winecfg to simply use that dll. Is it possible and easy for me? I already found GetMenuBarInfo and it just calls FIXME; I need to change it to modify the structure and compile user32.dll. Thank you

3 2

re: Is it possible to merge/integrate wine window and qt window?
by Dan Kegel 12 Apr '10

12 Apr '10

xfzheng asked: > [We're porting a Windows app to Linux, and would like to mix > native Linux GUI code and Windows GUI code.] You're probably not going to have much luck with that. Better (and easier, I bet) to do a pure port. Even easier to run the Windows version in Wine. Have you tried that yet? There are ways (see Google's Picasa) to hide drive letters from the user somewhat. - Dan

1 0

Is it possible to merge/integrate wine window and qt window?
by xfzheng 12 Apr '10

12 Apr '10

Our product both have windows version and QT version, the windows version has more functions. we MUST move all of function to Linux OS. The windows version has already move to linux currently, some of code has been rewritten. Here comes the questions, as we know ,both wine and qt choose X11 as its windows implemention, is there any way to implement QWindow or QWidget using MFC ? thanks in advance. xfzheng.

1 0

Re: d3dx9: Implement D3DXDeclaratorFromFVF with tests
by winetestbot＠geldorp.nl 12 Apr '10

12 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.geldorp.nl/JobDetails.pl?Key=1361 Your paranoid android. === WINEBUILD (Wine build VM) === Make failed

1 0

WineTestBot: phase 3 implemented
by Greg Geldorp 11 Apr '10

11 Apr '10

I'm happy to announce that WineTestBot (http://winetestbot.geldorp.nl) is now actively scanning wine-patches submissions for changes to tests. If it finds a test change, it will apply the changes, build the affected test executables and run them on the base VMs. Results will be mailed back to the submitter. It will also try to determine if new failures were introduced, by comparing the test results to the most recent run using winetest.exe from WineHQ. If it thinks there are new failures, a message is sent to the author with a copy to wine-devel. The bot will only process complete series, so it will queue up patches that appear to be part of a series. Then when the series is complete, it generates one big patch file by adding all the individual patches from the series together before submitting it. We'll have to see how robust this is, it is quite possible to mess up this algorithm. Only patches that contain changes to tests are run. It checks to see if any dlls/<dllname>/tests/* files were changed, if so it is deemed a change to the tests. This should cover most cases, but again is not 100% correct all the time (if you only change a file in include/ then the tests depending on the header files don't get run). In the end we still have the daily run that's done when Alexandre publishes a new winetest.exe. There's a new item in the WineTestBot menu, "Wine-patches". It will show which patches have been received via the mailing list and what the bot has done with them. Of course, you'll still be able to manually submit a patch to the bot too. These run at higher priority than the jobs generated from wine-patches submissions. Happy testing, Ge.

2 1

Re: loader: Fix French translation of wine manpage
by Nicolas Le Cam 09 Apr '10

09 Apr '10

Le 9 avril 2010 13:37, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : > 2010/4/9 Nicolas Le Cam <niko.lecam(a)gmail.com>: >> Hi Frédéric, >> >>>+\fIwineserver\fR dans le chemin système ou quelques autres emplacements vraisemblables. >>>[...] >>>+"wine" dans le chemin système ou quelques autres emplacements vraisemblables. >> Even if "likely" literally means "vraisemblable" I think the previous >> use of "potentiel" or even "possible" suits better. > > See my comments in the mail "wineserver: Fix French manpage" >> >>>+n'est spécifiée, le caractère + peut être omis. Notez que les espaces ne sont pas >>>+autorisées dans cette chaîne de caractères. >> Should be "autorisés" > > "espace" is feminine when talking about the typographical sign (cf > http://fr.wikipedia.org/wiki/Espace_typographique). > Now if \t or similar had been relevant in that sentence, it would have > been "caractères d'espacement". Oh didn't know that. Thanks for the explanation. >> >>>+Définit le type de remplacement et l'ordre de chargement des DLL utilisées lors du >>>+processus de chargement d'une DLL. Le comportement par défaut est spécifié dans le >>>+fichier de configuration. Deux types de bibliothèques peuvent actuellement être chargées >>>+dans l'espace d'adressage d'un processus : les DLL natives de >>>+Windows >> Should be "chargés" > > What's loaded? The types or the libraries? I think the latter... It's the "two types of libraries" that can be loaded. -- Nicolas Le Cam

1 0

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events
by Alexandre Julliard 09 Apr '10

09 Apr '10

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > Remove the fd from the poll list so we don't get POLLHUP/POLLERR > messages when we ask for no events This is wrong, even when selecting for no events you want to receive POLLHUP/POLLERR. If you really don't want any events you have to use -1 to remove the fd from the loop. But in general ignoring POLLHUP/POLLERR is a bug. -- Alexandre Julliard julliard(a)winehq.org

2 7

new icons
by wylda＠volny.cz 09 Apr '10

09 Apr '10

Hi, this will be just a short note... I noticed some new icons and i like them! W.

2 1

re: winetricks failed, expecting "system32" where I have "System32" and so on
by Dan Kegel 09 Apr '10

09 Apr '10

Helge wrote: > I happen to have Windows/System32. Hang on right there. Why? Once I understand that, the rest will be easier. Winetricks does handle the case where users renamed windows/fonts to windows/Fonts, because it was observed happening in the wild (one can imagine users doing thiis when manually installing fonts). But this is the first I've heard of a System32 rather than a system32. - Dan

3 3

Re: kernel32: Add tests for lstrcmpW
by Dmitry Timoshkov 09 Apr '10

09 Apr '10

André Hentschel <nerv(a)dawncrow.de> wrote: > +#define TESTMARKER(w) \ > + markerW[2] = w; \ > + ok(!lstrcmpW(markerW,nomarkerW), "expected the character 0x%x to be ignored within the string\n", w); > + > +static void test_lstrcmpW(void) > +{ > + static const WCHAR nomarkerW[] = {'t','e','s','t',0}; > + static WCHAR markerW[] = {'t','e','r','s','t',0}; > + > + todo_wine > + { > + TESTMARKER(0x034f); > + TESTMARKER(0x0378); What this test is supposed to show? Is there a bug that prevents real world application not to function properly under Wine? Besides, lstrcmpW() is just a wrapper for CompareStringW(), and there is a bunch of tests for it already. Testing explicit unicode values is not useful, Wine uses different unicode tables than Windows does. -- Dmitry.

1 0

Re: [PATCH 6/7] wined3d: Add an initial fbo_blit_supported implementation.
by Henri Verbeet 09 Apr '10

09 Apr '10

On 8 April 2010 22:49, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > + /* Source and/or destination need to be on the GL side */ > + if (src_pool == WINED3DPOOL_SYSTEMMEM || dst_pool == WINED3DPOOL_SYSTEMMEM) > + return FALSE; ... > + if (!is_identity_fixup(src_format_desc->color_fixup) || > + !is_identity_fixup(dst_format_desc->color_fixup)) > + return FALSE; These weren't in the original function. Perhaps they should but, but as separate patches, please. > + if (!(src_format_desc->format == dst_format_desc->format > + || (is_identity_fixup(src_format_desc->color_fixup) > + && is_identity_fixup(dst_format_desc->color_fixup)))) > + return FALSE; This entire check would be redundant after the is_identity_fixup() checks above.

1 0

Re: kernel32: Add tests for lstrcmpW
by Paul Vriens 09 Apr '10

09 Apr '10

On 04/09/2010 01:12 PM, André Hentschel wrote: > +#define TESTMARKER(w) \ > + markerW[2] = w; \ > + ok(!lstrcmpW(markerW,nomarkerW), "expected the character 0x%x to be ignored within the string\n", w); Hi André, lstrcmpW is not implemented on Win95/98/Me so these tests will always succeed. You should probably add a lstrcmpW call at the beginning and skip when not implemented, something like: SetLastError(0xdeadbeef); lstrcmpW(markerW, nomarkerW); if (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) { win_skip("lstrcmpW is not implemented\n"); return; } -- Cheers, Paul.

1 0

Re: [PATCH] d3dx9_36: Beginning of constants parsing + tests (based on work from Luis Busquets) (try 3) (resend)
by Alexandre Julliard 09 Apr '10

09 Apr '10

Christian Costa <titan.costa(a)wanadoo.fr> writes: > @@ -650,6 +650,29 @@ HRESULT WINAPI D3DXCompileShader(LPCSTR pSrcData, > return D3DERR_INVALIDCALL; > } > > +typedef struct ctab_constant ctab_constant; > + > +struct ctab_constant { > + D3DXCONSTANT_DESC desc; > + ctab_constant* members; > +}; > + > +inline ctab_constant* get_constant(D3DXHANDLE ptr) > +{ > + if (!ptr) return NULL; > + return (ctab_constant*)~((UINT_PTR)ptr); > +} > + > +inline D3DXHANDLE get_handle(ctab_constant* ptr) > +{ > + return (D3DXHANDLE)~((UINT_PTR)ptr); > +} > + > +inline BOOL isstring(D3DXHANDLE ptr) > +{ > + return !(((UINT_PTR)ptr) & (1 << (sizeof(UINT_PTR)*8-1))); > +} This is broken, you can't make assumptions about the high bit of pointer values. The handle management needs more thought. -- Alexandre Julliard julliard(a)winehq.org

2 1

tuxradar's map of linux audio
by Dan Kegel 09 Apr '10

09 Apr '10

This seemed like a useful overview of how the various layers relate to each other: http://tuxradar.com/content/how-it-works-linux-audio-explained

5 5

Re: shlwapi: Skip tests on IE < 6 (try 2)
by Alexandre Julliard 09 Apr '10

09 Apr '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -617,6 +617,12 @@ static void test_UrlGetPart(void) > dwSize = sizeof szPart; > szPart[0]='x'; szPart[1]=0; > res = pUrlGetPartA("hi", szPart, &dwSize, URL_PART_SCHEME, 0); > + > + if (res) { > + win_skip("probably too old IE\n"); > + return; > + } There's no reason to skip the whole thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: be more explicit with locale dependent parsing of dates
by Alexandre Julliard 09 Apr '10

09 Apr '10

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -7708,7 +7708,7 @@ HRESULT WINAPI VarDateFromStr(OLECHAR* strIn, LCID lcid, ULONG dwFlags, DATE* pd > break; > > case 0x1B: /* localized DDDTTT */ > - if (!iDate) > + if (PRIMARYLANGID(lcid) != LANG_GERMAN) Obviously you cannot hardcode specific locales like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: loader: Fix French translation of wine manpage
by Nicolas Le Cam 09 Apr '10

09 Apr '10

Hi Frédéric, >+\fIwineserver\fR dans le chemin système ou quelques autres emplacements vraisemblables. >[...] >+"wine" dans le chemin système ou quelques autres emplacements vraisemblables. Even if "likely" literally means "vraisemblable" I think the previous use of "potentiel" or even "possible" suits better. >+n'est spécifiée, le caractère + peut être omis. Notez que les espaces ne sont pas >+autorisées dans cette chaîne de caractères. Should be "autorisés" >+Définit le type de remplacement et l'ordre de chargement des DLL utilisées lors du >+processus de chargement d'une DLL. Le comportement par défaut est spécifié dans le >+fichier de configuration. Deux types de bibliothèques peuvent actuellement être chargées >+dans l'espace d'adressage d'un processus : les DLL natives de >+Windows Should be "chargés" Thanks for your work. -- Nicolas Le Cam

1 0

Google Summer of Code
by Jasneet Singh 08 Apr '10

08 Apr '10

Respected, I would like to contribute to the Wine development under the Google Summer Code. Have a knowledge of C Language and Vast Experience on Operating Systems I have worked and managed various OS ( OPERATING SYSTEMS ) of various PLATFORMS like:- * * * * *LINUX Platform* Ubuntu 6.10 Ubuntu 7.04 Ubuntu 7.10 Ubuntu 8.04 Ubuntu 8.10 Ubutnu 9.04 Ubuntu Server 9.04 Fedora 9 Suse *Microsoft Windows Platform* Microsoft Windows 3x Microsoft Windows 95 Microsoft Windows 98 Microsoft Windows ME Microsoft Windows Server 2000 Microsoft Windows XP Microsoft Windows Server 2003 Microsoft Windows Vista Microsoft Windows 7 * * *Macintosh Platform* Tiger MAC OSX 10.4 ** Leopard MAC OSX 10.5 Opensource is what i promote and as is visible from my mention above, I am a Linux ( opensource supported ). >My idea/purposal would be to make wine, powerful-enough interms of its felxibilty to automatically find the .dll and other lib files req. for the functioning of .exe files in the Linux OS. Inturn making the Opensource world more friendly to the Other side. Like the MACFUSE on Mac OS X utilises a folder approach i.e. it creates a folder with a file index so that the efficiency of MAC is maintained while making NTFS 3G compatible with HFS+, similarly as Wine can identify the Windows Drive, it should also be able to think like a windows OS not as a Program on Linux running .exe files. To this there are two approaches:- 1. Decrypting the .exe file to its skin and recompiling it to run in the Linux way 2. Making the .exe files a better illusion of windows while providing a better experience of the Linux world to the User I'm keen to learn as much as I can from this opportunity provided and contribute to the Development to the best of my caliber. Regards Jasneet Singh Kandhari Chandigarh India

2 1

a new trick to add to winetricks
by Troy Wolbrink 08 Apr '10

08 Apr '10

I've found the winetricks script invaluable in trying to get my app running on Wine. But I found that when installing msxml6, I needed to change the overrides for msi.dll and msiexec.exe to "builtin,native". I previously installed the native msi20, and msxml6 wouldn't install with the native installer. It installs fine with the builtin installer. Thanks, Troy

4 7

[GSoC] IUri Implementations
by Thomas Mullaly 08 Apr '10

08 Apr '10

Hi, my name is Thomas Mullaly and I am a undergraduate in the Computer Science department at Kent State University and I would very much like to participate in this years GSoC. I saw under your project ideas page that the IUri API still needs implemented and I thought that this would be a good project for me, but, before I submit a proposal on it I have a few questions about the project itself. Firstly, on the project page it says that the main goal is to have the IUri interface and CreateUri function implemented, but, on MSDN they also have functions and interfaces for creating/manipulating IUriBuilder's and I was wondering if these were also part of the project goals. If not can they be or would this be to ambitious to have finished by the end of the summer. Secondly (more of a design question), I see that the Uri structure and functions are already stubbed out in the "dlls/urlmon/uri.c" file and I was thinking for my implementation I would add another BSTR* member to the Uri struct, which will point to the encoded version of the URI (which will be generated during the CreateUri() call). Since most of the functions that interact with the IUri return components of the URI (e.g. scheme, host, query, etc.) I was thinking about adding more data members to the Uri struct which store the location in the encoded Uri string where each component exists (or -1 if it does not exist) and by doing this the runtimes of the IUri functions will be reduced since the function will already know where to look inside the encoded string for the component it needs. A drawback to this design is that each Uri struct will be bloated with a decent amount of ints which may or may not be used depending on the type of the URI that the IUri represents. The second approach I was thinking of is to not store any locations inside the Uri struct and to compute them on the fly every time the IUri is queried for one of its components, this would result in a smaller memory footprint of the Uri structure but will increase the runtimes of all the functions that access the URI. I was wondering if anyone might have suggestions for which way they think might be better. Any input will be greatly appreciated! -Thomas Mullaly

3 6

Re: winmm: MCI system commands are not eligible for auto-open.
by Alexandre Julliard 08 Apr '10

08 Apr '10

<Joerg-Cyril.Hoehle(a)t-systems.com> writes: > @@ -1341,6 +1343,7 @@ DWORD WINAPI mciSendStringW(LPCWSTR lpstrCommand, LPWSTR lpstrRet, > if (wmd) > data[4] = wmd->wType; > } > + } else if (!strcmpW(verb, wszSound) || !strcmpW(verb, wszBreak)) { > } else if ((MCI_ALL_DEVICE_ID != uDevID) && !(wmd = MCI_GetDriver(mciGetDeviceIDW(dev)))) { You should at the very least add a comment to that empty block. Also it fails here: ../../../tools/runtest -q -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so mci.c && touch mci.ok mci.c:808: Test failed: got 0008 instead of MCI_NOTIFY_xyz 0000 from command sound notify mci.c:820: Tests skipped: Skipping auto-open tests in Wine make[1]: *** [mci.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] d3dx9: Add swizzle and writemask support to the shader assembler.
by Henri Verbeet 08 Apr '10

08 Apr '10

On 8 April 2010 14:20, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > Wouldn't it make a lot more sense to simply define a swizzle as something like "([xyzw]{1,4})|([rgba]{1,4})" and handle write masks separately?

1 0

[PATCH 1/2] ntdll: Queue WT_EXECUTEINTIMERTHREAD timers as APC
by Joerg-Cyril.Hoehle＠t-systems.com 08 Apr '10

08 Apr '10

>According to the windows documentation about CreateTimerQueueTimer its >how its done. Indeed, and I believe MS puts APC to even more uses than documented, c.f. http://bugs.winehq.org/show_bug.cgi?id=3930#c37 Maybe there are other places where Wine ought to use APC. One issue with APC for WINMM is that one needs further tests to investigate which call causes memoization of the GetCurrentThread() field to which the callback will be delivered? - Is is the thread that called midiOpen? - The thread that called midiWrite? BTW, would it be ok for Wine to a) include a patch that introduces version-specific behaviour (as mentioned in the above bug)? b) Or should Wine's WINMM generally behave like Win9X because it's old and many newer apps use another API? c) Like W2k/xp/7 because that's what's current now. Regards, Jörg Höhle

1 0

Re: [3/3] d3dx9: Add source register modifiers (sm 2+) support to the shader assembler.
by Greg Geldorp 08 Apr '10

08 Apr '10

Hi Matteo, This causes the test to crash on Vista and Windows 2008, see http://winetestbot.geldorp.nl/JobDetails.pl?Key=1315 Ge.

1 0

Re: [PATCH 3/4] wined3d: Start moving texture format fixups to the formats table.
by Henri Verbeet 08 Apr '10

08 Apr '10

On 7 April 2010 23:12, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > @@ -236,9 +236,55 @@ struct wined3d_format_texture_info > GLint gl_format; > GLint gl_type; > unsigned int flags; > + unsigned int conv_byte_count; > GL_SupportedExt extension; > + void (*convert)(const BYTE *src, BYTE *dst, UINT pitch, UINT width, UINT height); > }; > ... > - GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE, > + GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE, 0, > WINED3DFMT_FLAG_FILTERING, > - WINED3D_GL_EXT_NONE}, > + WINED3D_GL_EXT_NONE, NULL}, Did you test this patch much?

2 1

Re: [PATCH 2/4] wined3d: Let d3dfmt_get_conv return a wined3d_format_desc. This required some code shuffling mostly in the SRGB area.
by Henri Verbeet 08 Apr '10

08 Apr '10

On 7 April 2010 23:12, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > --- > dlls/wined3d/device.c | 5 +- > dlls/wined3d/surface.c | 169 +++++++++++++++++++++++----------------- > dlls/wined3d/utils.c | 1 + > dlls/wined3d/wined3d_private.h | 5 +- > 4 files changed, 102 insertions(+), 78 deletions(-) > I'm not so convinced by the idea of having mutable format descriptions. What problem are you solving, and why is this the best solution? At the very least the patch looks like it could be split though.

2 1

Re: [PATCH 4/4] wined3d: Add an initial fbo_blit implementation.
by Henri Verbeet 08 Apr '10

08 Apr '10

I don't think so. Looking at cpu_blit, that "blitter" has exactly a single function that's actually used, and it might as well have been a function on its own. I've twice pointed out how to avoid that situation, but for some reason you ignored that. In the case of cpu_blit I went along with that in the assumption that later patches would fix it, but I'm not having another implementation like that.

1 0

Direct3D testing project (GSoC)
by Conrad Buck 08 Apr '10

08 Apr '10

Hello devels, I'm looking at submitting a SoC proposal to the wine project, but I'm feeling a little overwhelmed as my current coding experience is all over the place, and very little of it working with existing projects. My most recent work has been looking low-level code and algorithms behind basic OpenGL, so I thought perhaps I might be able to make relevant contributions to the project of testing and improving Direct3D support. Can anyone that knows more about whats under the hood for that sort of functionality in wine tell me what kind of magnitude of project I might be looking at? Only a limited number of bug reports have been filed, but all seem to be indicative of fairly major issues. Once I get more of an idea of what I might be dealing with (and examine some of the problems myself) I can fine-tune my proposal. Thanks, Conrad

2 1

Re: winebrowser: Fix obtaining of the ASCII strings through the DDE
by Dmitry Timoshkov 08 Apr '10

08 Apr '10

Ilya Shpigor <shpigor(a)etersoft.ru> wrote: [skipped] If it could be that easy this would be fixed already. There is a bug in bugzilla with the details about this problem. -- Dmitry.

1 0

Re: [PATCH] [Server]: correctly set the DR0..7 registers on Linux for x86_64 architecture
by Dmitry Timoshkov 08 Apr '10

08 Apr '10

Eric Pouech <eric.pouech(a)orange.fr> wrote: > + case CPU_x86_64: > + context->debug.x86_64_regs.dr0 = data[0]; > + context->debug.x86_64_regs.dr1 = data[1]; > + context->debug.x86_64_regs.dr2 = data[2]; > + context->debug.x86_64_regs.dr3 = data[3]; > + context->debug.x86_64_regs.dr6 = data[6]; > + context->debug.x86_64_regs.dr7 = data[7]; > + default: > + set_error( STATUS_INVALID_PARAMETER ); > + goto done; > + } You forgot 'break'. > + case CPU_x86_64: > + if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(0), context->debug.x86_64_regs.dr0 ) == -1) goto error; > + if (thread->context) thread->context->debug.x86_64_regs.dr0 = context->debug.x86_64_regs.dr0; > + if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(1), context->debug.x86_64_regs.dr1 ) == -1) goto error; > + if (thread->context) thread->context->debug.x86_64_regs.dr1 = context->debug.x86_64_regs.dr1; > + if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(2), context->debug.x86_64_regs.dr2 ) == -1) goto error; > + if (thread->context) thread->context->debug.x86_64_regs.dr2 = context->debug.x86_64_regs.dr2; > + if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(3), context->debug.x86_64_regs.dr3 ) == -1) goto error; > + if (thread->context) thread->context->debug.x86_64_regs.dr3 = context->debug.x86_64_regs.dr3; > + if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(6), context->debug.x86_64_regs.dr6 ) == -1) goto error; > + if (thread->context) thread->context->debug.x86_64_regs.dr6 = context->debug.x86_64_regs.dr6; > + if (ptrace( PTRACE_POKEUSER, pid, DR_OFFSET(7), context->debug.x86_64_regs.dr7 ) == -1) goto error; > + if (thread->context) thread->context->debug.x86_64_regs.dr7 = context->debug.x86_64_regs.dr7; > + default: > + set_error( STATUS_INVALID_PARAMETER ); > + } Same here. -- Dmitry.

1 0

Re: (try2)[PATCH 3/4] d3d10: Implement ID3DEffectVariable::GetInputSignatureElementDesc().
by Henri Verbeet 07 Apr '10

07 Apr '10

2010/4/7 Rico Schüller <kgbricola(a)web.de>: > + /* Check desc for NULL, this crashes on W7/DX10 */ > + if (!desc) > + { > + WARN("This should crash on W7/DX10!\n"); > + return E_FAIL; > + } It's perfectly fine to require a parameter to be non-NULL, and just crash if it isn't. You'll get a nice backtrace, or at least an exception, which helps debugging as well. > + /* Check shader_index, this crashes on W7/DX10 */ > + if (shader_index >= This->effect->used_shader_count) > + { > + WARN("This should crash on W7/DX10!\n"); > + return E_FAIL; > + } Similar as above. In general if Windows doesn't check something, we don't either. However, it's worth noting that if we'd be writing to that index we sometimes do check those, because there's the potential for memory corruption in those cases.

1 0

Mac OS X technologies
by C.W. Betts 07 Apr '10

07 Apr '10

There is a long list of technologies in Mac OS X that could be used to improve Wine on OS X. One of them is ColorSync. ColorSync is a color management software that is HEAVILY integrated into the Mac OS. For instance, you can calibrate your monitor and when OS X starts up, it will read the color profile file and adjust the graphics card output. It will also do color correction automatically in, e.g. Preview to get the best out of an image. However, I do not know how ColorSync influences Mac OS X's X11 system. It is possible that in order to take full advantage of ColorSync, a Mac OS X native front-end will need to be developed. Another interesting Mac OS X technology is Image Capture. This technology is used by the OS to scan images from a scanner as well as import images from a camera (iPhoto). It provides a wrapper around TWAIN drivers so they can be used by applications that don't support TWAIN. This is a purely C Framework. Although a sub-framework of the Carbon Framework, the functions are available in 64-bit code. This should not be confused with the ImageCaptureKit framework, which is most likely an Objective-c wrapper around the main Image Capture framework.

1 0

Re: [PATCH 2/4] d3d10: Move the effect shader input signature into a separate struct.
by Henri Verbeet 07 Apr '10

07 Apr '10

2010/4/6 Rico Schüller <kgbricola(a)web.de>: > +struct d3d10_effect_shader_signature { That isn't going to apply. Did you edit the patch? (And please keep the formatting consistent with the existing code.)

2 2

Re: About Wine Test Bot
by Greg Geldorp 07 Apr '10

07 Apr '10

Hi Alexandre, > Ok so I could not run any test until compiling on cygwin works. > But the idea was to be able to remotly compile wine with some of our patches > applied. > > I was told "you can't do that, it will break minGW". > The WINEBUILD VM exists but we can't use it (or tell me how to do that) The WINEBUILD VM is only used to cross-compile tests in case you submit a patch and not a test executable to the bot. Running tests on Wine is outside the scope of WineTestBot (perhaps it should be called WinTestBot...), it is aimed at making sure that the tests themselves are correct (by checking that they don't fail on Windows). Ge van Geldorp.

1 0

About Wine Test Bot
by Alexandre Goujon 07 Apr '10

07 Apr '10

Hi, I have a suggestion about wineTestBot. It's maybe the wrong place but I'm quite sure interested people read wine-devel. I think it would be great if we could not only run tests (as it already does) but also check if a patch does not break wine (on minGW, on cygwin or on MAC for instance). Thus, we could choose a kind of WINEBUILD VM to tell wineTestBot to only compile wine with our patch. Currently, I can't compile on Linux and cygwin is very slow. So it would make my life easier if I could rely on wineTestBot... Comments are welcome Thanks

3 5

winmm: Improve MCI A/W mapping slightly.
by Joerg-Cyril.Hoehle＠t-systems.com 07 Apr '10

07 Apr '10

Hi, I forgot to mention that this patch was rebased against 1.1.42, supersedes the former "Fix A/W mapping for 64bit Wine" patch and is not dependent on prior 64bit patches. Currently, I can't think of a fully general solution to the A/W mapping problem. In theory, an unknown driver with new unknown commands and keywords could be registered. We have little idea how large the structure is and which flags controls the validity of the nth slot, e.g. when to call strdupAtoW(). One could think about parsing the command table to obtain this information. However, a) I see no guarantee that there's a unique MCI_STRING value for a given bit that is set in the flags parameter. b) This does not help with baroque commands like SYSINFO which sometimes put a string, sometimes a DWORD into the result buffer or which are documented to count buffer sizes in bytes, unlike other commands. This latter example reveals that calling MCI_Cleanup() before unwrapping is unfortunate, as valuable type information is lost. It is currently encapsulated inside mciSendCommandW. Open questions: - Does Wine actually support hooking in a new native MCI driver? (beside DLL overrides) - Why does Wine copy dwCallback only when MCI_NOTIFY is set? It is not wrong, but why care? To prevent a Valgrind message when that slot was not filled by the caller? BTW, my (unpublished) testing reveals that unlike what MSDN says, dwRetSize is counted in characters in MCI_SYSINFO_PARMSW, not bytes (at least on w2k with SYSINFO_NAME [OPEN]). But that shall be the subject of another patch. Regards, Jörg Höhle

1 0

Participation in GSoC
by "Alexander N. Sørnes" 07 Apr '10

07 Apr '10

Hello, I'm a student interested in participating in Google's Summer of Code. This isn't my first mail to the wine-devel list; I was a GSoC partiicpant in 2007, where I worked on WIne's WordPad clone. I have also done some work on the AppDB as well as minor bug fixes and lately a (little) work on some dsound tests. Other, non-Wine related code I've written include work with low-level keyboard hoo There are a few projects I have in mind. I've had a look at the Wiki, and both 'Implementing the Internet Explorer GUI' and working on the Control Panel applets seem like interesting projects. Have any students applied for these yet? My only COM experience so far has been implementing a few stubs for DirectPlay, as well as some dsound tests: http://www.winehq.org/pipermail/wine-patches/2010-February/084748.html http://www.winehq.org/pipermail/wine-patches/2010-February/084881.html As for my own project ideas, I think it would have been interesting to implement IPX over TCP in winsock, since most of the games that use IPX require root access for it to work. This feature could perhaps be enabled in winecfg or the Control Panel. I don't have any experience with networkking, though, so I'm concerned that this might be a bit amibitous. I would appreciate feedback of any kind, and yes, I know that time is running out with respect to the application deadline :) Regards, Alexander N. Sørnes

2 1

Re: [PATCH 2/5] [Server]: correctly set the DR0..7 registers on Linux for x86_64 architecture
by Alexandre Julliard 07 Apr '10

07 Apr '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -549,12 +549,21 @@ void get_thread_context( struct thread *thread, context_t *context, unsigned int > goto done; > } > } > +#ifdef __i386__ > context->debug.i386_regs.dr0 = data[0]; > context->debug.i386_regs.dr1 = data[1]; > context->debug.i386_regs.dr2 = data[2]; > context->debug.i386_regs.dr3 = data[3]; > context->debug.i386_regs.dr6 = data[6]; > context->debug.i386_regs.dr7 = data[7]; > +#else /* __x86_64__ */ > + context->debug.x86_64_regs.dr0 = data[0]; > + context->debug.x86_64_regs.dr1 = data[1]; > + context->debug.x86_64_regs.dr2 = data[2]; > + context->debug.x86_64_regs.dr3 = data[3]; > + context->debug.x86_64_regs.dr6 = data[6]; > + context->debug.x86_64_regs.dr7 = data[7]; > +#endif You can't use ifdefs, this needs to depend on the CPU type of the client process. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw/tests: Added todo_wine test to verify resizing of fullscreen windows
by Henri Verbeet 07 Apr '10

07 Apr '10

On 6 April 2010 23:14, Johan Gill <johan.gill(a)gmail.com> wrote: > +»······»·······if (!EqualRect(&scrn, &orig_rect)) { > +»······»······· /* Check that the client rect was resized */ > +»······»······· rc = GetClientRect(hwnd, &test); > +»······»······· ok(rc!=0, "GetClientRect returned %x\n", rc); > +»······»······· rc = EqualRect(&scrn, &test); > +»······»······· todo_wine ok(rc!=0, "Fullscreen window has wrong size\n"); > +»······»·······} Please don't mix tabs and spaces, just use 4 space indent.

1 0

Re: [PATCH] user32: honor bfOffBits in BITMAP_Load
by Dmitry Timoshkov 07 Apr '10

07 Apr '10

Wolfram Sang <wolfram(a)the-dreams.de> wrote: > + offbits = bmfh->bfOffBits - sizeof(BITMAPFILEHEADER); > + bits = (char *)info + (offbits ?: size); The purpose of offbits is not clear. Besides "?:" is absolutely not readable, putting an explicit 0 there would help a bit. Adding a test case wouldn't hurt either. -- Dmitry.

3 3

Re: winmm: Rewrite time.c using ntdll timers
by Steven Edwards 06 Apr '10

06 Apr '10

On Tue, Apr 6, 2010 at 6:08 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > --- > Should fix bug 22252 as a side effect. It should also make it possible to > run our winmm on windows for wave playback because the timers are now using > win32 apis. :) Thanks, I've been waiting for something like this since 0383e4e4990e414a7dcaba51e6b81bf60499944a ;) -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Wine FIXME Report March 2010
by Michael Stefaniuc 06 Apr '10

06 Apr '10

Wine FIXME Report March 2010 ============================ The data for this report comprise the emails from March 2010 archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 6867 (emails: 6282, bugzilla attachments: 585) Files (logs) with FIXME/ERR/WARN: 517 Type | Total | Unique ------+---------+------- fixme | 191778 | 22303 err | 101542 | 3632 warn | 6125 | 1199 Most Frequent Messages By Logs ------------------------------ Messages that are present in most Wine output logs collected. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 68 | 200 | 2.94 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 62 | 82 | 1.32 | system:SetProcessDPIAware stub! 51 | 92 | 1.80 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 37 | 62 | 1.68 | urlmon:URLMoniker_BindToObject use running object table 35 | 36 | 1.03 | sync:CreateMemoryResourceNotification (0) stub 33 | 57 | 1.73 | shdocvw:ClOleCommandTarget_QueryStatus command_0: 27, 0x0 31 | 43 | 1.39 | resource:GetGuiResources (0xffffffff,0): stub 31 | 72 | 2.32 | shdocvw:PropertyNotifySink_OnChanged unimplemented dispid 1005 28 | 66 | 2.36 | d3d9:Direct3DShaderValidatorCreate9 stub 24 | 85 | 3.54 | shdocvw:BindStatusCallback_OnProgress status code 11 ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 31 | 31 | 1.00 | ole:CoGetContextToken apartment not initialised 24 | 35 | 1.46 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 24 | 35 | 1.46 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 22 | 44 | 2.00 | ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded 21 | 55 | 2.62 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 20 | 220 | 11.00 | ole:ClientIdentity_QueryMultipleInterfaces IRemUnknown_RemQueryInterface failed with error 0x80004002 15 | 15 | 1.00 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded 14 | 49 | 3.50 | ole:CoUninitialize Mismatched CoUninitialize 13 | 13 | 1.00 | ole:apartment_getclassobject DllGetClassObject returned error 0x80040111 10 | 15 | 1.50 | eventlog:ReportEventW L"0" Most Frequent Messages By Mean Lines Per Logs --------------------------------------------- This are the messages which show up in at least 1% of the logs and have the highest mean lines per logs ratio. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 15 | 2307 | 153.80 | advapi:SetSecurityInfo stub 11 | 1655 | 150.45 | d3d:debug_d3dformat Unrecognized 909200449 (as fourcc: AL16) WINED3DFORMAT! 11 | 1655 | 150.45 | d3d:debug_d3dformat Unrecognized 909201952 (as fourcc: R16) WINED3DFORMAT! 11 | 1655 | 150.45 | d3d:getFormatDescEntry Can't find format unrecognized(909200449) in the format lookup table 11 | 1655 | 150.45 | d3d:getFormatDescEntry Can't find format unrecognized(909201952) in the format lookup table 14 | 1706 | 121.86 | gdiplus:GdipCreateHalftonePalette 7 | 715 | 102.14 | d3d:buffer_PreLoad Too many full buffer conversions, stopping converting 13 | 565 | 43.46 | gdiplus:GdipGetFamilyName No support for handling of multiple languages! 21 | 423 | 20.14 | wininet:InternetLockRequestFile STUB 7 | 110 | 15.71 | shell:URL_ParseUrl failed to parse L"cdbxpp.resources" ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 7 | 7295 |1042.14 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R32G32B32A32_FLOAT 7 | 7295 |1042.14 | d3d:getColorBits Unsupported format: WINED3DFMT_R32G32B32A32_FLOAT 6 | 347 | 57.83 | d3d_surface:surface_set_texture_name Surface has SFLAG_INTEXTURE set, but no texture name 7 | 211 | 30.14 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 7 | 211 | 30.14 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 20 | 220 | 11.00 | ole:ClientIdentity_QueryMultipleInterfaces IRemUnknown_RemQueryInterface failed with error 0x80004002 8 | 66 | 8.25 | ole:CoCreateInstance apartment not initialised 7 | 48 | 6.86 | richedit:ReadStyleSheet skipping optional destination 7 | 28 | 4.00 | imm:ImmAssociateContextEx Unknown dwFlags 0x0 14 | 49 | 3.50 | ole:CoUninitialize Mismatched CoUninitialize Functions With Most Messages By Mean Lines Per Logs --------------------------------------------------- This are the functions which show up in at least 1% of the logs and have the highest mean lines per logs ratio. FIXME: Logs | Lines | Mean | Channel:Function ------+-------+--------+----------------- 7 | 6082 | 868.86 | d3d_draw:drawStridedFast 80 | 19784 | 247.30 | d3d_surface:IWineD3DVolumeImpl_LockBox 15 | 2307 | 153.80 | advapi:SetSecurityInfo 117 | 16272 | 139.08 | d3d:context_check_fbo_status 14 | 1706 | 121.86 | gdiplus:GdipCreateHalftonePalette 6 | 464 | 77.33 | d3d:IWineD3DDeviceImpl_ClearSurface 6 | 352 | 58.67 | shell:IDropTargetHelper_fnDragOver 57 | 2695 | 47.28 | dsound:IDirectSoundBufferImpl_AcquireResources 14 | 566 | 40.43 | gdiplus:GdipGetFamilyName 22 | 847 | 38.50 | d3d:buffer_PreLoad ERR: Logs | Lines | Mean | Channel:Function ------+-------+--------+----------------- 29 | 46357 |1598.52 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt 29 | 46357 |1598.52 | d3d:getColorBits 7 | 349 | 49.86 | d3d_surface:surface_set_texture_name 14 | 422 | 30.14 | ddraw:PixelFormat_WineD3DtoDD 21 | 222 | 10.57 | ole:ClientIdentity_QueryMultipleInterfaces 8 | 66 | 8.25 | ole:CoCreateInstance 10 | 71 | 7.10 | richedit:ReadStyleSheet 16 | 89 | 5.56 | ole:ITypeInfo_fnInvoke 47 | 245 | 5.21 | ole:marshal_object 7 | 28 | 4.00 | imm:ImmAssociateContextEx Messages With The Highest Repetition Count ------------------------------------------ The messages with the highest repetition count in a single log file. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 1 | 76325 |76325.0 | d3d7:IDirect3DDeviceImpl_3_SetLightState D3DLIGHTSTATE_MATERIAL called with NULL material !!! 1 | 17648 |17648.0 | d3d_surface:IWineD3DVolumeImpl_LockBox (0x129fc038) : pBox=0xbff040 stub 1 | 4256 | 4256.0 | d3d_texture:basetexture_generate_mipmaps iface 0x4b577a0 stub! 1 | 2977 | 2977.0 | d3d:debug_d3dusagequery Unrecognized usage query flag(s) 0x1 1 | 2717 | 2717.0 | d3d:context_check_fbo_status Color attachment 0: (0x38eebdc0) WINED3DFMT_B8G8R8A8_UNORM 1280x1024 1 | 2717 | 2717.0 | d3d:context_check_fbo_status Depth attachment: (0x1a6668) WINED3DFMT_D24_UNORM_S8_UINT 1280x1024 1 | 2717 | 2717.0 | d3d:context_check_fbo_status FBO status GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT (0x8cd6) 1 | 2552 | 2552.0 | d3d_draw:drawStridedFast >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glDrawElements @ drawprim.c / 46 1 | 2129 | 2129.0 | d3d_surface:IWineD3DBaseSurfaceImpl_Blt Filters not supported in software blit 4 | 2074 | 518.5 | d3d:context_check_fbo_status FBO status GL_FRAMEBUFFER_UNSUPPORTED (0x8cdd) ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 1 | 2990 | 2990.0 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R16G16B16A16_UNORM 1 | 2990 | 2990.0 | d3d:getColorBits Unsupported format: WINED3DFMT_R16G16B16A16_UNORM 4 | 2950 | 737.5 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R32G32_FLOAT 4 | 2950 | 737.5 | d3d:getColorBits Unsupported format: WINED3DFMT_R32G32_FLOAT 4 | 2880 | 720.0 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R16G16B16A16_FLOAT 4 | 2880 | 720.0 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R16G16_FLOAT 4 | 2880 | 720.0 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R16_FLOAT 7 | 2880 | 411.4 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R32G32B32A32_FLOAT 4 | 2880 | 720.0 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R32_FLOAT 4 | 2880 | 720.0 | d3d:getColorBits Unsupported format: WINED3DFMT_R16G16B16A16_FLOAT Further Info: ============= The sqlite3 database and the perl script to output the above report can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/201003/ bye michael

1 0

re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found
by Dan Kegel 06 Apr '10

06 Apr '10

"Mikhail Maroukhine" <mikolg at connectivegames.com> wrote: > user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found > Behavior checked on Windows XP Welcome to Wine development! Poker playing penguins salute you. As Dmitry wrote, adding a test case would be a good idea; see http://wiki.winehq.org/WritingConformanceTests - Dan

2 1

Native Windows web Browser plugins for Linux Mozilla
by Joni Salmela 06 Apr '10

06 Apr '10

I have an idea how to get native windows mozilla plugins to work in native Linux mozilla... as you know in Chrome each new tab is its own independent process yet they all share a parent x-window so... if you could create a Windows which would host an active-x plugin or just the mozilla NP_PAPI plugin it could serve as an wrapper okay so create a generic "plugin wrapper" for mozilla and start a new instance of wine the application that hosts the active-x plugin and set its parent as the mozillas window... this hosting an Active-X plugin via NP_PAPI does work in Windows btw... sincerely Joni Salmela. joni.salmela(a)hesburger.fi

3 2

msvidc32/msvideo1 question: upside down buffers?
by Joerg-Cyril.Hoehle＠t-systems.com 06 Apr '10

06 Apr '10

Hi, does anybody know why msvideo_decode_8bit(), when imported from the FFmpeg project in 2004, was changed such that the pixels[] array became filled upside down? See how #ifdef ORIGINAL, which shows the original FFmpeg code, differs from the #else branch in msvideo1.c Do buffers in Wine work upside down and backwards? Why can't Wine use exactly FFmpeg's code? I'm asking because no similar set of changes was applied to msvideo_decode_16bit(). I have files that are rendered incorrectly and even suspect of crashing Wine because of this. I could write a patch but need to know. Thank you for your help, Jörg Höhle

2 1

Re: Working on "DOS" VGA.
by chris ahrendt 06 Apr '10

06 Apr '10

Just my 2 phennings worth on this... Why reinvent the wheel... I would say instead of doing the emulator inside wine... or a JIT... why not have wine intersept the call to start the vm86 mode.. and forks off and starts DOSEMU or whatever DOS box system is configured.. That way wine doesnt have to worry about it... chris

9 10

[PATCH 1/5] winmm: Improve MCI's Sysinfo command.
by Joerg-Cyril.Hoehle＠t-systems.com 06 Apr '10

06 Apr '10

Hi, Eric Pouech wrote: >did you test the 16 => 32 bit conversion for the MCI_ALL_DEVICE ? Which ones do you have in mind? There are tests involving MCI_ALL_DEVICE_ID that pass on both win9x and later (also in patch #5). I wrote a few more MCI tests privately. Generally, I added (UINT16) casts in Wine when I saw test failures on Win9x platforms, then kept doing so (i.e. I'm not sure I've tested SYSINFO with a 0000FFFF deviceID on Win9x in particular or whether I simply use that pattern everywhere now after having been burnt once). There are a few patches already in git that fix a few MCI_ALL_DEVICE_ID here and there, but as you wrote yourself in the TODO header long ago, support for it is incomplete. Making "close all", "play all" etc. work is on my private TODO list, but I never started working on this particular item. >actually, I'd say it belongs to the 16=>32 mci message mapper, not in >generic 32bit code Do you mean dlls/mmsystem.dll16? I never looked at it but I don't think that's the correct place, see below. Do you mean the A/W (un)mapping? That's distinct, because it deals with string conversions only, as the name suggests, and it does not mogrify dwParam1. Current test results suggest that MCI_ALL_DEVICE_ID is not only a 16/32 issue -- at least when I equate 16 with MS-Windows 3.x -- Have a look at the mciGetDeviceID("all") test case, which returns a 16bit FFFF on Win9x, not FFFFFFFF. Therefore I believe Wine must be prepared for receiving 0000FFFF as ALL_ID from old Win9X apps or drivers -- possibly regardless of them using the A or W function entry points. Of course, a single (or few) central place(s) to convert wDeviceID=(MCIDEVICEID)(WORD)wDeviceID or wDeviceID= wDeviceID==0xFFFF ? MCI_DEVICE_ALL_ID : wDeviceID is a nice idea. That could be a distinct patch. I'm convinced this handle is truly a 16 bit entity, even after it has been upgraded to a UINT/DWORD type at some time in the past. Still, SYSINFO is a special case, as it receives a device ID not only as function argument but also in its PARMS structure. Regards, Jörg Höhle.

2 4

Icon Patches Feedback
by Joel Holdsworth 06 Apr '10

06 Apr '10

Hi, Are there any thoughts about my latest round of icon patches? Thanks Joel

1 0

wisotool: now supports seven games, runs on windows, too
by Dan Kegel 06 Apr '10

06 Apr '10

My little automated app installer tool, wisotool, now supports seven apps: assassinscreed, diablo2, dragonage, morrowind, sims3, starcraft, and wog (world of goo) It also seems to run on Windows ok in Cygwin (though I've only barely tested that). Thanks to Austin for dragonage, morrowind, and some windows fixes, and Eleazar Galano for a draft of the assassinscreed verb. I've updated the doc at http://wiki.winehq.org/wisotool It has a section explaining the difference between wisotool and somewhat related things like appinstall and PlayOnLinux. (In a nutshell, wisotool is a winetricks-like tool for installing games automatically, with no user interaction. It caches .iso files to automate disc-swapping for multiple-disc apps, and caches cd keys to automate installers that need keys, but you have to load the cache from your real copy of the cds or dvds first.) - Dan

1 0

Application period ends in ~4 days
by Maarten Lankhorst 05 Apr '10

05 Apr '10

Hi all, I've seen a few very good proposals on the mailing list, but not enough of them ended up as a proposal on the official summer of code app. So if you haven't done so already please apply there now. You can still modify your proposal there after submitting it based on feedback, but you'll have to submit something there soon. Cheers, Maarten

1 0

Re: [PATCH 6/6] Due to code rewrites is_color_fixup_supported is not needed anymore in RealizePalette. The code in question should be executed in all cases. This also fixes palette refresh issues when shaders / paletted textures aren't around.
by Stefan Dösinger 05 Apr '10

05 Apr '10

Am 05.04.2010 um 20:05 schrieb Roderick Colenbrander: > - IWineD3DDeviceImpl *device = This->resource.device; > - if((This->resource.usage & WINED3DUSAGE_RENDERTARGET) && > - device->blitter->color_fixup_supported(&device->adapter->gl_info, This->resource.format_desc->color_fixup)) > + if(This->resource.usage & WINED3DUSAGE_RENDERTARGET) It's a problem with the existing code, but checking the usage here doesn't make much sense. It should check if the surface is a front buffer on any swapchain(or, as long as we store a P8 surface as ARGB in GL this code also applies to backbuffers)

2 1

Re: [PATCH 2/6] d3dx9_36: Beginning of constants parsing + tests (based on work from Luis Busquets) (try 2)
by Henri Verbeet 05 Apr '10

05 Apr '10

On 5 April 2010 20:28, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +inline ctab_constant* get_constant(D3DXHANDLE ptr) > +{ > + if (!ptr) return NULL; > + return (ctab_constant*)~(UINT)ptr; > +} > + > +inline D3DXHANDLE get_handle(ctab_constant* ptr) > +{ > + return (D3DXHANDLE)~((UINT)ptr); > +} How is that different? You'd have to cast to UINT_PTR to fit a 64-bit pointer in there, although of course that only works if D3DXHANDLE is also a 64-bit value on 64-bit Windows (didn't check).

2 1

Re: [PATCH 3/6] d3dx9_36: Implement D3DXGetImageInfoFromFileInMemory using WindowsCodecs (based on work from Tony Wasserka) (try 2)
by Vincent Povirk 05 Apr '10

05 Apr '10

+ hr = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); + if (FAILED(hr)) + return E_FAIL; You should continue in this case, but don't call CoUninitialize at the end. On Mon, Apr 5, 2010 at 1:28 PM, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > Check return of CoInitializeEx and some WIC calls. Return an error for unsupported file and pixel formats. > --- > > dlls/d3dx9_36/Makefile.in | 2 - > dlls/d3dx9_36/surface.c | 113 ++++++++++++++++++++++++++++++++++++++++- > dlls/d3dx9_36/tests/texture.c | 40 ++++++--------- > 3 files changed, 127 insertions(+), 28 deletions(-) > > > >

1 0

Re: [PATCH 3/7] d3dx9_36: Beginning of constants parsing + tests (based on work from Luis Busquets)
by Henri Verbeet 05 Apr '10

05 Apr '10

On 5 April 2010 10:30, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > +inline ctab_constant* get_constant(D3DXHANDLE ptr) > +{ > + if (!ptr) return NULL; > + return (ctab_constant*)~(DWORD)ptr; > +} > + > +inline D3DXHANDLE get_handle(ctab_constant* ptr) > +{ > + return (D3DXHANDLE)~((DWORD)ptr); > +} These look like they would be problematic on 64-bit, does it really work like that?

2 1

Hello, All! Interested in GSoC
by Bradley Tucker 05 Apr '10

05 Apr '10

Hello everyone, I am Bradley Tucker, a junior computer science major at Tennessee Tech University, and I am very interested in participating in the Google Summer of Code. I have a strong passion for developing video games, and it sounds like working with the Wine Project this summer would be incredibly helpful, informative, and fun. I'm not sure exactly what I'm supposed to do to get started, so I'll just tell you a little about me and what I'd like to do. First of all, I am primarily a Windows user who is trying learn more about Linux and all the wonderful things it can do. I have experience programming in C++ and Java, but I am a quick learner and would gladly become fluent in another language, if necessary. I do not have any experience working in an open-source community, but again, I am always ready to learn and to try new things. I would like to participate in the Google Summer of Code because I feel it will help me gain necessary skills and knowledge that will help me once I graduate, while benefiting all others who use open-source software. While I may not be the most qualified individual right now, I promise that if I am selected to work for the Wine Project this summer, I will quickly do whatever I can to become as qualified as possible. I am a sociable and easy-to-get-along-with sort of guy, but I am extremely determined and hard-working, and I will do whatever I can to help the project progress. As I said before, I am very interested in gaming, so naturally Wine is project that I believe I will thoroughly enjoy working on. Firstly, I would be very interested in improving or testing any Direct3D features. Testing and finding bugs for recent releases would be tremendously beneficial in helping me get ready for a career in the gaming industry. So, finding bugs and ways to optimize recent releases would probably be my top choice for working on a project with Wine. I also enjoy playing classic games as much as the latest releases. The suggested idea of "implementing DOS graphics modes more faithfully" is one I would find tremendously interesting and hopefully informative. I don't know enough about Wine yet to give many specifics, but I would gladly work on any bugs or features that my mentor would find most crucial. While these are the topics that stood out most to me, I would honestly be willing to help out in any area that could use my help. As I said, I don't know if this is the best way to introduce myself or if this is the best way to present the ideas I would like to possibly work on. But, here I am, willing and able to help in whatever ways you would like. My e-mail address is bradley-tucker(a)hotmail.com, so feel free to contact me whenever you please, with any questions or comments. I am a student with classes, so I may not be able to respond right away. Thanks, and I hope to working with you this summer! Bradley Tucker Computer Science Major Junior, Tennessee Tech University bradley-tucker(a)hotmail.com _________________________________________________________________ The New Busy think 9 to 5 is a cute idea. Combine multiple calendars with Hotmail. http://www.windowslive.com/campaign/thenewbusy?tile=multicalendar&ocid=PID2…

1 0

Re: [PATCH 4/7] d3dx9_36: Implement D3DXGetImageInfoFromFileInMemory using WindowsCodecs (based on work from Tony Wasserka)
by Vincent Povirk 05 Apr '10

05 Apr '10

> + CoUninitialize(); You should call this function only if your original CoInitializeEx call succeeded. It may fail in a multithreaded apartment (in which case WIC won't work either, but that's a bug), and in that case the uninitialize is not needed. Also, you seem to be leaving things uninitialized if you get an unrecognized container format or pixel format. That's probably not a good policy.

1 0

Re: [PATCH 1/2] amstream: Expose also IMultiMediaStream which is the base interface of IAMMultiMediaStream (patch from Qingchuan Wang)
by Henri Verbeet 05 Apr '10

05 Apr '10

On 5 April 2010 10:55, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > The proper way to do attribution is by adding an appropriate From: line to the patch, preferably by simply passing --author with the right information to git commit.

1 0

Re: [PATCH 6/7] d3dx9_36: Add stub for D3DXCreateTextureFromFileA
by Henri Verbeet 05 Apr '10

05 Apr '10

On 5 April 2010 10:30, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + FIXME("(%p, %s, %p): stub\n", device, srcfile, texture); "srcfile" is an external string, this should use debugstr_a().

1 0

Re: [PATCH 2/7] d3dx9_36: Improve FIXMEs and TRACEs for surface
by Henri Verbeet 05 Apr '10

05 Apr '10

On 5 April 2010 10:30, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > @@ -71,7 +71,8 @@ HRESULT WINAPI D3DXGetImageInfoFromFileA(LPCSTR file, D3DXIMAGE_INFO *info) > LPWSTR widename; > HRESULT hr; > int strlength; > - TRACE("(void): relay\n"); > + > + TRACE("(%s, %p): relay\n", file, info); You should use debugstr_a() here (and in a few other places).

1 0

Re: user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found
by Dmitry Timoshkov 05 Apr '10

05 Apr '10

"Mikhail Maroukhine" <mikolg(a)connectivegames.com> wrote: > user32/dialog.c: GetNextDlgTabItem returns hwndDlg if next item not found > Behavior checked on Windows XP Please add a test case for this. > + return retWnd ? retWnd : (hwndCtrl ? hwndCtrl : hwndDlg); Using an 'if' case would be more readable IMO. -- Dmitry.

1 0

[GSOC] dshow/gst branch rebased and commented
by Edward Hervey 05 Apr '10

05 Apr '10

Hi all, I took some time this morning to rebase tdavenport's gst/dshow branch against current master and added my comments/reviews in the last commit. The branch can be found here : http://github.com/bilboed/wine/tree/tdaven-rebased I'm putting this out so that if any student is interested, he could carry on this work during GSOC. The current status is that using gstreamer as a backend for dshow has been proven to work within a very limited use-case. What remains: * Making it more efficient, flexible and lightweight (see all my comments) * Allowing it to automatically pick up whatever GStreamer element is available on the system and make it available through dshow. A good goal for example would be to make the various audio/video gstreamer sinks available through dshow (for example picking up the pulse sink), and the various audio/video decoders. Having it working with a native windows application (pick a player or an audio/video app using dshow) would be a must. Don't hesitate to ask questions/comments, Edward

2 1

re: GSoC WPKG and test.winehq.org
by Dan Kegel 05 Apr '10

05 Apr '10

> Converting the wpkg scripts to appinstall doesn't > seem like that difficult of a task, mostly just time consuming. It's harder than it sounds to actually get a few useful app tests written. Plus there'll be some work writing up and fixing the bugs it uncovers. > That is why I thinking working on tying it into test.winehq.org is more worthy. > I still think tying appinstall and patchwatcher together would be > beneficial and allow people submitting patches to see where > regressions pop up in software, and to see > what new software works with each submitted patch. > Perhaps a project of implementing all of this and adding wpkg scripts would be accepted? Arjun Comar is going to propose something similar, but using Buildbot as the point of integration. - Dan

4 7

Re: Working on "DOS" VGA.
by Chris Ahrendt 03 Apr '10

03 Apr '10

On 4/3/2010 11:34 AM, Alexandre Julliard wrote: > Stefan Dösinger<stefandoesinger(a)gmx.at> writes: > > >> Am 02.04.2010 um 02:08 schrieb chris ahrendt: >> >> >>> Just my 2 phennings worth on this... >>> Why reinvent the wheel... I would say instead of doing the emulator inside wine... or a JIT... why not have >>> wine intersept the call to start the vm86 mode.. and forks off and starts DOSEMU or whatever DOS box system is >>> configured.. That way wine doesnt have to worry about it... >>> >> Because you can mix modes in one executable. Take for example the >> average modern dos game: They start as real mode apps, then switch to >> a 32 bit protected mode dos extender(e.g. dos4gw.exe). I wouldn't be >> surprised if the app can transform itself into a Win16 app that tries >> to pop up a window. Wouldn't work well in Linux dosemu. >> > DOS apps can't do that. Pretty much the only thing you really have to > share is the filesystem, and it should be easy to configure DosBox to > mount ~/.wine/drive_c, and to invoke Wine when a DOS app starts a > Windows binary. > > There's no reason to replicate DosBox inside Wine. On the contrary, a > nice project would be to improve integration with an external DOS > emulator and then rip out the half-broken vm86 support from Wine. > > That is what I would think should be done... chris

1 0

re: win16 patches
by Dan Kegel 03 Apr '10

03 Apr '10

C.W. Betts asked: > I am curious why these patches weren't applied in the first place. Because of problems like the ones Juan referred to. > > For another thing, one patch per email, please. > "One patch per email"? Please elaborate. Do you mean per Wine component? He means each post to wine-patches should fix just one bug. http://bugs.winehq.org/show_bug.cgi?id=9850 is a bad bug report, really; it needs to be broken up into individual bugs, and then a clean patch sent for each. - Dan

1 0

Re: win16 patches
by Juan Lang 03 Apr '10

03 Apr '10

Hi C.W., this isn't going to fly. For one thing, diff --git a/dlls/kernel32/comm.c b/dlls/kernel32/comm.c index f4edfd3..a85f158 100644 --- a/dlls/kernel32/comm.c There's no attribution in this patch. It can't get committed without valid attribution. For another thing, one patch per email, please. For another, - if(!vga_text_console) +// if(!vga_text_console) C++ comments aren't allowed, and removing a line by commenting it out is frowned upon. If it's really not needed, just remove it. But you need to justify why it's no longer needed. More errors remain, but I'll stop at these. This set is well below acceptable yet, I'm afraid. --Juan

2 1

re: regarding the participation in gsoc 2010
by Dan Kegel 03 Apr '10

03 Apr '10

Hi Nitheesh, it does sound like DOS is near and dear to your heart. What's the first small problem you would solve? Sending a good patch for that would be an eloquent way of framing your proposal. - Dan

1 0

Re: Polish translation for release 1.1.42
by Jacek Caban 03 Apr '10

03 Apr '10

Hi Łukasz, On 4/3/10 9:04 AM, Łukasz Wojniłowicz wrote: > --- > news/pl/2010040201.xml | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > create mode 100644 news/pl/2010040201.xml > > +<li>Wsparcie dla wspÃ³Å‚dzielonych 32/64-bitowych instalatorÃ³w.</li> That's not what English version says. Jacek

1 0

regarding the participation in gsoc 2010
by nitheesh kl 03 Apr '10

03 Apr '10

hello sir, i am nitheesh.k.l. i am a second year engineering student of computer science studying in PES institute of technology,Bangalore,India. in this summer i'm willing to participate in the google summer of code and i was really interested in your idea to solve the vga display modes problem in wine. i work on both windows and linux and previously used to work in dos. i do most of my work in linux and i use wine to run some of my dos and windows programs. but for a long time now i'm not able to run some of my dos programs properly in wine. i've tried my ways but was not successful.since people in wine have come forward to solve this i feel that i can work with you guys to solve the problem. my experience: as mentioned before i used to work on dos and done some work in it. 1) i written some small system diagnostics tools. the first is the ports diagnostics tool.it helps the user to check whether his ports are working fine or not. it includes both serial and parallel port and checks for all the baud rated. it provides both software loop back and hardware tests for user satisfaction, and it also comes with an simple and attractive gui. i've also implemented a small tool just like norton utilities(NU in dos)which is about 75% complete(could not complete as my exams started) 2) i've also worked on building an editor in dos and as my part in it i've created the gui for the editor. i've also designed a gui for an antivirus in dos 3) last summer i developed some small games for some of the problems in computer science of which the towers of hanoi is the major one. it has a gui which displays the disks of various sizes and the pegs to move them around.it initially ask for the number of disk and once the specified number of disks are created the user can then move them around using the arrow keys to complete the solution. my major intention in developing this is that the younger students can use this to understand the problem and its solution in a fun and enjoyable way. 4) As a hobby ive also developed a software to burn the hex file to a microcontroller. it has a very user friendly user interface(similar to turbo c++) through which the user can select the required file and then dump it to the device.it provides support for two major microcontroller used in our college. the software displays the complete hex file,its ascii equivalent and the actual hex code that runs on the device. i feel that since i've worked on both platforms and personally experienced the problem, i can and am interested in fixing the bugs. so with this experience am i eligible to work with you in this years gsoc. if so then i'll send my application immediately.i kindly request you to reply sir. thank you. Nitheesh

1 0

Mono integration
by Vincent Povirk 03 Apr '10

03 Apr '10

I wrote a wiki page yesterday about the current state of Mono integration in Wine and what I think needs to be done about it. That is at: http://wiki.winehq.org/Mono Basically, if you install Mono in Wine, Wine will use it to run .NET programs. However, the combination doesn't work for any of the programs I've tried. There are a number of things wrong (listed on the wiki page), but none of them appear to affect a lot of programs. My theory is that it just happens to not work very well because of random bugs. I think it's important that we improve this, so that we have an alternative to MS .NET. I am amazed that the licensing allows us to use MS .NET now (if indeed it really does), and I don't know how long that will continue. So here is what I'd like to ask from the community: * Try some .NET programs with Mono (use the mono26 verb in winetricks), and file Wine bugs when they don't work. Even if the bug is in Mono, we should investigate it and give them a nice report, since we are using Mono in a strange way. Use the dotnet keyword. * If an installer for something other than .NET tries to install .NET, file a bug for that with the dotnet keyword. * Someone other than me, please try to make a Windows build of Mono and run the Mono test suite under Wine. I want to make sure that the instructions make sense and that someone other than me can do this.

5 8

Re: [PATCH 4/4] mshtml: Always load FTP, HTTP, and HTTPS URLs through Wine
by Jacek Caban 03 Apr '10

03 Apr '10

Hi Andrew, On 4/3/10 12:31 AM, Andrew Eikum wrote: > --- > dlls/mshtml/nsio.c | 10 +++------- > 1 files changed, 3 insertions(+), 7 deletions(-) - if(!strncmp(spec, "wine:", 5)) { - spec += 5; You can't remove this part. We don't want to pass "wine:" prefix to set_wine_url. + }else if(strncmp(spec, "ftp:", 4) + || strncmp(spec, "http:", 5) + || strncmp(spec, "https:", 6)) { After removing is_wine_url, the else part should be always executed. Jacek

1 0

rfc: mscoree: Use the mono embedding api instead of invoking mono.exe.
by Vincent Povirk 02 Apr '10

02 Apr '10

This is a patch that has mscoree.dll load mono.dll in-process rather than starting mono.exe. This is needed so that (among other things), the running process gets the correct values from GetCommandLine and GetModuleFileName(0). The code quality is probably not very good, so I'm sending it to wine-devel for feedback first.

2 1

Re: [PATCH 5/5] Rename color_fixup_supported to blit_supported support and add additional checks.
by Henri Verbeet 02 Apr '10

02 Apr '10

On 1 April 2010 23:58, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > + /* In general we don't support any destination fixups except for P8. P8 fixup > + * can occur in three cases: > + * 1) Blit from p8 source to p8 destination, this is a source fixup and the > + * destination fixup can be ignored. > + * 2) LockRect on surface, LoadLocation takes care of the 'destination fixup'. > + * 3) RealizePalette refreshes the palette of a surface. The surface is then > + * both the source (the sysmem / texture copy) and the destination (drawable). > + * But you don't know all that. All you know is that you've got two surfaces with certain properties. You could argue that since the source and destination fixups are the same they cancel out, so that you can do that blit as long as you either don't stretch or the fixup is linear. However, in that case you also need to make sure the blitter actually behaves like that.

2 3

A possible way to fix cygwin issue
by GOUJON Alexandre 02 Apr '10

02 Apr '10

Hi, I'm just wondering if this approach may solve the issue. I'm maybe totally wrong but there's no harm in trying...

2 1

Re: winedump: code cleanup
by Alexandre Julliard 02 Apr '10

02 Apr '10

"Mikhail Maroukhine" <mikolg(a)yandex.ru> writes: > - winedump/search.c::get_type - cleanup variable usage That's not much better. It would be cleaner to stop abusing the passed argument as a local variable. -- Alexandre Julliard julliard(a)winehq.org

2 3

MicroOLAP Database Designer for PostgreSQL
by Tom Wickline 02 Apr '10

02 Apr '10

This might be considered spam but I thought I would share it. MicroOLAP Database Designer for PostgreSQL with enhanced WineHQ support released. MicroOLAP Database Designer for PostgreSQL is an easy CASE tool with intuitive graphical interface allowing you to build a clear and effective database structure visually, see the complete picture (diagram) representing all the tables, references between them, views, stored procedures and other objects. Then you can easily generate a physical database on a server, modify it according to any changes you made to the diagram using fast ALTER statements. http://www.wine-reviews.net/wine-reviews/news/microolap-database-designer-f… Cheers, Tom

1 0

Re: [PATCH 3/5] Move palette uploading code over to arbfp blit_shader. [try 2]
by Henri Verbeet 02 Apr '10

02 Apr '10

On 2 April 2010 12:19, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > +void d3dfmt_p8_init_palette(IWineD3DSurfaceImpl *This, BYTE table[256][4], BOOL colorkey); That function is internal to wined3d.

1 0

Re: [PATCH 3/5] Move palette uploading code over to arbfp blit_shader.
by Henri Verbeet 02 Apr '10

02 Apr '10

On 1 April 2010 23:58, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > > +static void upload_palette(IWineD3DSurfaceImpl *surface) > +{ > + BYTE table[256][4]; > + IWineD3DDeviceImpl *device = surface->resource.device; > + BOOL colorkey = (surface->CKeyFlags & WINEDDSD_CKSRCBLT) ? TRUE : FALSE; > + > + d3dfmt_p8_init_palette(surface, table, colorkey); If that's really what you want, you need to add this function to wined3d_private.h. Right now it will generate a warning. Perhaps it should just be in surface.c though? This function depends on having an active context. Where is "palette_texture" deleted?

1 0

re: [PATCH 0/4] Unwinding the stack with Dwarf (CFA) information on i386
by Dan Kegel 02 Apr '10

02 Apr '10

Eric wrote: > With this patch set, one can get rid of most of the non visible parameters values > while using a backtrace in winedbg. That's great news, thanks, hope it goes in soon!

1 0

Re: [PATCH 2/2] Revert prev. Hack, as Bug 10000 is still present.
by John Klehm 02 Apr '10

02 Apr '10

On Thu, Apr 1, 2010 at 11:16 AM, Detlef Riekenberg <wine.dev(a)web.de> wrote: > With greeting from the current day. > hehe nice

2 1

winmm: For MCI parsing, use 64bit compatible structures.
by Joerg-Cyril.Hoehle＠t-systems.com 01 Apr '10

01 Apr '10

Hi, Eric Pouech wrote: >this patch is ugly as hell... Please qualify. To me, - data[3] = (DWORD_PTR)dev; + parms.open.lpstrElementName = dev; looks more robust than before: - no magic offsets, - no casts that may silence warnings. The one #ifdef WIN64 is a pure performance optimization on Win32. The other one with the TRACE() is indeed ugly, but I don't feel it's safe to call debugstr_w() on misaligned data in Wine64. Even if it were, printing data[3] as string may be wrong, because it may be data[4] (+5) that holds a pointer, not (3+4). Therefore I decided to renounce to print string contents on 64bit, despite their value in the logs. > and it still believe we can do the MCI >parser without knowing about MCI structures internals What do you mean? Quite to the contrary, the parser depends on knowing the internals of some commands (like MCI_OPEN) as well as the convention about the return value as 2nd (+3rd) slot after the callback. The parser bridges the gap between the resource definition files winmm_res.rc that are now in git and are known to work well with 32bit and the mixed DWORD/DWORD_PTR MCI_..._PARMS definitions whose correctness has been (partially) validated by tests. What we don't know is whether Win64 introduced a different winmm_res.rc. I'd sure would be pleased if somebody could describe whether there have been changes to the resources to accommodate 64bit pointers in MS-Windows. Everybody, please visit bug #22146 if you can contribute such knowledge. (Part of) my patch is needed even if there were (thanks to lack of magic offsets). Regards, Jörg Höhle

2 1

Another proposal for your critique: improving .NET 3.5
by John Koelndorfer 01 Apr '10

01 Apr '10

Wine-devel, Still looking at my options for summer projects and I thought this might be a good one that would work towards my goal of improving gaming for folks. As always, comments and critiques are very appreciated. I would request that, in addition to commenting on the general idea, that people also comment on the actual proposal. Does it look/sound good enough to be accepted? I fancy myself a fairly good writer but writing a proposal is still pretty new to me. :-) Thanks! John

4 5

Re: [PATCH 4/4] Add a blit method to arbfp_blit.
by Henri Verbeet 01 Apr '10

01 Apr '10

On 1 April 2010 12:50, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > - if (is_identity_fixup(src_format_desc->color_fixup)) > - { > - TRACE("[OK]\n"); > - return TRUE; > - } > - When did we stop supporting those? > + arbfp_blit.set_shader((IWineD3DDevice *)device, src_surface->resource.format_desc, > + src_surface->texture_target, src_surface->pow2Width, src_surface->pow2Height); You might as well call arbfp_blit_set() directly.

2 2

WineD3D BltOverride overhaul
by Roderick Colenbrander 01 Apr '10

01 Apr '10

Hi, For a while we have been discussing on how to clean up / rewrite some parts of the surface code in WineD3D. I did submit a number of patches to initiate a rewrite of some parts but not all patches were correct and it wasn't clear what final design I had in mind. I'm posting my ideas to here to get some feedback on how to proceed. For people outside wined3d this might not be that interesting but I'll give a short overview of the problems, so that you could also understand it a little bit. The main issue is that pieces of modern code and legacy DirectDraw code are entangled in a way which is not easy to untangle. There are various places which can be improved but for now I want to limit myself to 'BltOverride'. It is a big function shared between DirectDraw/D3D7 blitting and D3D8 CopyRects / D3D9 StretchRect and over the years it has become large and very ugly. The way I thought about simplifying this call is to move some parts to helper functions and to remove legacy functionality (e.g. move colorfill back to Blt). A lot of the work which has to be done is not just about moving code around. Some functionality can these days be implemented in a nicer way thanks to functionality like shaders. Below I have some pseudo code on how I think a chunk of BltOverride and the blit_shader calls it uses, should be implemented. The main idea is to move the majority of the code to the blit_shader. Unless color keying / 8-bit is required, I expect that no actual shader is needed. In case we need a shader, there are two cases namely when blit_shader is implemented using GPU shaders and the case we need a fall back. In case of the fall back, I think we need big chunks of the 'old' BltOverride code which needs to be moved over to ffp_blit. BltOverride (color keyed) offscreen surface -> render target blitting { if(orm_fbo && can_stretch) stretch_rect_fbo <-- this check is around now; but I guess we ultimately want a IWineD3DDevice_StretchRect which contains this code and which can fall back to BltOverride) context = context_acquire(CTXUSAGE_BLIT) blit_shader->set_shader(src_surface) blit_shader->draw_quad(src_surface, src_rect, dst_rect) blit_shader->unset_shader(); } arb_blit_shader based implementation { blit_shader->set_shader(src_surface) { generate_shader (if needed) activate_shader if(color_keying_active) upload_colorkey_to_shader if(p8_active) load_p8_palette } blit_shader->draw(src_surface, src_rect, dst_rect) { surface_internal_preload(src_surface) { under the hood, LoadTexture/LoadLocation should not perform surface conversion for us basically the issue is how to distinguish between 2d and 3d color keying and how to separete this } /* drawing */ if(fbo_blit) fbo_blit() else draw_quad() } blit_shader->unset_shader(); } ffp_blit implementation { blit_shader->set_shader(src_surface) { if(p8_active) load_palette else not_much_todo } blit_shader->draw(src_surface, src_rect, dst_rect) { if(need_color_keying) play_with_color_keying_flags (like current BltOverride does) surface_internal_preload(src_surface); if(need_color_keying) restore_color_keying flags activate_alpha_test_magic draw_quad() } blit_shader->unset_shader(); } I think the design described above could work (perhaps I missed something, please correct me then). One of the issues is color keying. Right now color key conversion is performed in LoadLocation based on some flag magic. In case of a 2d blit using shaders this is not needed but for Direct3D purposes it is needed. I'm not sure how to handle this in a clear way. (I fear that we also get some new issues when a game alternates between 2d and 3d color keying). I don't expect issues regarding 8-bit as long as we implement them in software and use opengl only during the upload (UnlockRect). If we would allow hardware blitting, it would need to be 8-bit -> 8-bit blits and no converted blits else we need hacks like paletteOverride which I would like to eliminate. Roderick

3 10

Re: [PATCH 3/4] Rename blit_shader color_fixup_supported to blit_supported.
by Henri Verbeet 01 Apr '10

01 Apr '10

On 1 April 2010 12:50, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > --- > dlls/wined3d/arb_program_shader.c | 20 +++++++++++----- > dlls/wined3d/directx.c | 2 +- > dlls/wined3d/surface.c | 46 +++++++++++++++++++++++++----------- > dlls/wined3d/wined3d_private.h | 9 ++++++- > 4 files changed, 55 insertions(+), 22 deletions(-) > This does quite a bit more than just renaming things. More importantly, these implementations will now claim that blits with destination fixups are supported, while they aren't. You should pass an appropriate pool (i.e., WINED3DPOOL_DEFAULT) in CheckSurfaceCapability(), and I don't think passing NULL for the destination format makes a lot of sense for blits.

1 0

GSoC - keyboard input
by wylda＠volny.cz 01 Apr '10

01 Apr '10

Hi guys, if it is not too late, i would have a proposal for GSoC. I'm waiting quite long for "BuildActionMap, SetActionMap, EnumDevicesBySemantics & co", i.e. to make games like need for speed happy/playable (bug 8754). Thanks for reading, W.

3 3

Re: [PATCH 4/5] mmdevapi: Add dependency on openal
by Chris Robinson 01 Apr '10

01 Apr '10

On Wednesday 31 March 2010 2:00:57 pm Maarten Lankhorst wrote: > + local_contexts = palcIsExtensionPresent(NULL, "ALC_EXTX_thread_local_context"); Missed a spot? Don't forget to use the correct function names for the completed extension, too.

2 1

re: Implementation of WIndows Gaming APIs as GSoC project
by Mariusz Pluciński 31 Mar '10

31 Mar '10

2010/3/30 Dan Kegel <dank(a)kegel.com> Sounds good to me -- and you could start right now by checking in stubs, > if we don't have them already... > > The question is, though, how useful are these APIs (aside from > needing them to play some games)? Which games make use of them? > According to research made by Vincent Povirk (described at bugzilla: http://bugs.winehq.org/show_bug.cgi?id=21261), some games already use it. In my opinion, importance of this interface will be growing in the future. And MS will probably extend it to add new features. So, it would be easier to create these interfaces now, before moment they will become really big and complicated, like others Microsoft's APIs. Microsoft also solved problem with older games - they created some kind of games database which allows some older games to be visible in Games Explorer without using new APIs. Of couse, Wine project should not use Microsoft's database, but there's already Wine's Application Database, which after some extension may be used in similar way.

3 4

re: A proposal for implementing dxdiag.exe: thoughts?
by Dan Kegel 31 Mar '10

31 Mar '10

John wrote: >OK -- it would definitely not make sense to redo the work if the tests >are completed to satisfaction. >In that case, I would recommend renaming/clarifying the suggested GSOC >project on the Wine wiki. >It seems to suggest that conformance tests need to be written. Well, yes, but for the library that dxdiag.exe uses, dxdiagn.dll. I'm not clear on how complete the tests for our dxdiagn.dll are; if they're already complete enough, you could skip this step. See http://msdn.microsoft.com/en-us/library/ee416987(v=VS.85).aspx for the public interface to this library. - Dan

1 0

A proposal for implementing dxdiag.exe: thoughts?
by John Koelndorfer 31 Mar '10

31 Mar '10

I've written a proposal for what my plan would be regarding implementation of Wine's dxdiag based on my own thoughts and the suggestions of other wine-devel list members. I plan to submit proposals for other projects as well but before I write them I'd like to get a better feel for what's expected (I did look at PGSQL's tips as per the GSOC wiki page). Anyways, it's attached. Please let me know what you think.

3 5

re: [1/2] wcmd/setshow_attrib: Moved from internal to external attrib.exe
by Dan Kegel 31 Mar '10

31 Mar '10

Welcome to wine development! Problems with your patch: - you forgot to add your test to rsrc.rc - you forgot to include an expected output file - don't change .h files in patches that don't need the changes Please submit just the tests first, make sure 'make test' runs your tests, and make sure the .exe produced by 'make crosstest' passes on winetestbot. You might want to send the next patch to me for review before posting to wine-patches; you'll probably run into several more gotchas that it'd be nice to have cleared up before you post again. - Dan

1 0

re: Summer of Code applicant with ambition!
by Dan Kegel 31 Mar '10

31 Mar '10

John Koelndorfer wrote: >I've again gone over the list of possible projects on >the Summer of Code page and one that particularly piqued my interest >was "Direct3D - Conformance / Performance / Interactive tests". This >seems like it may be a good fit given my lack of previous experience >in the Wine codebase. I haven't written any code for 3D-ish games but >I can't imagine that would be a huge setback. Maybe Dan Kegel or >someone else who has worked on D3D can comment here? (Correction: I've never worked on D3D :-) Offhand, if you're not already a 3d person, that might be kind of hard? Although maybe the "get dxdiag working" task might be easy enough. (The only problem with that is it involves committing someone else's code, which isn't a good focus for a GSOC project.) >If that is not feasible, I think I would be a strong candidate for the >"Test Suite" project since my scripting-fu is fairly strong. Sure, you could find and fix tons of problems that way, I bet. - Dan

7 10

Congratulations!
by Juan Lang 30 Mar '10

30 Mar '10

Hi Matteo, just wanted to congratulate you on getting your DRDXAssembleShader patches accepted. I know it can take a fair amount of persistence to get something substantial committed, and it seems that many lack the patience. Well done! --Juan

2 1

Re: [PATCH 6/7] Use surface_is_offscreen instead of directly looking at the swapchain.
by Henri Verbeet 30 Mar '10

30 Mar '10

On 30 March 2010 21:19, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > @@ -4062,7 +4062,7 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, const > * Also beware that the front buffer's surface size is screen width x screen height, > * whereas the real gl drawable size is the size of the window. > */ > - if (dstSwapchain && (IWineD3DSurface *)This == dstSwapchain->frontBuffer) { > + if (!surface_is_offscreen((IWineD3DSurface *)This)) { > RECT windowsize; > POINT offset = {0,0}; > UINT h; This looks wrong, the code is checking if the surface is the front buffer, not if it's onscreen.

1 0

Summer of Code applicant with ambition!
by John Koelndorfer 30 Mar '10

30 Mar '10

Hello wine-devel, My name is John and I'm a computer science major at the University of Minnesota, Twin Cities campus. I've made quite a bit of use of Wine before (and I have purchased Crossover) and I'm inspired to give something back to the project. I have fairly ambitious goals for myself (maybe too much so) so I wanted to let you guys know who I am and what I'd like to do, then hopefully gain some insight into whether or not what I am considering is reasonable. My experience is roughly as follows: * I am familiar with C. I'm not an expert developer by any stretch but I can certainly get by. I have some knowledge of Git. * I don't have any Windows development experience outside of some exposure to .NET a long time ago. * I have not submitted a patch to the Wine project. I hope to change this in the near future. I've looked at a little bit of the source code. * I have high standards for myself. Whether or not they are high enough to meet Alexandre's expectations... perhaps time will tell. :-) * I'm a really fast learner. Maybe this is my single most redeeming quality. All that being said, my goal for the summer would be to really dig into the D3D stuff, optimizing what is already completed and adding to what is not. I'm a gamer myself, so I have an arsenal of programs with which to test (and a Windows installation to compare to). Do you think this goal is reasonable? If not, I could start somewhere smaller and work my way up. I'm certainly open to suggestions. Thanks! John

2 2

Implementation of WIndows Gaming APIs as GSoC project
by Mariusz Pluciński 30 Mar '10

30 Mar '10

Hello I'm Mariusz Pluciński, student of Information Technology in Gdańsk University of Technology (Poland). I decided to apply to Google Summer of Code in your project, cause I've been fascinated in Wine for a long time (without Wine, migration to open source OS would not be possible for me). In my opinion, one of the biggest problem for Wine is problems with support games written for MS Windows, so making progress in this area is something which I want to work on. I know C programming language very well, just as programming in Microsoft Windows APIs and Microsoft's COM technology. I also have some experience in working on open source - in Kdenlive project (video editor). I do a polish translation there, but I have also sent several patches to source code. In the past I was also reading some parts of Wine source code, so I know somewhat about how Wine's works and how it's code looks. In Google Summer of Code, I'm interested in implementation of new gaming APIs created by Microsoft for Windows Vista and enlarged in Windows 7. Main part of this is implementation of four COM interfaces: IGameExplorer, IGameExplorer2, IGameStatistics and IGameStatisticsMgr. In the bugzilla there's stub implementation of IGameExplorer interface, which may be good start point for me in development. Main parts of task will probably be creation of database to store games' data and parser of GDF files (Game Definition File). In favorable circumstances, if the APIs implementation is done fast enough, I will start work on simple equivalent of Windows Game Explorer application. It would be nice for Wine's users to control their games from one application, similar way as they do it in MS Windows. Also, application will use Game Statistics interfaces, so it will be good practical test for these interfaces. I hope my idea will get your acceptance. Thanks

1 0

Re: 10/10 wined3d: use RECT instead of WINED3DRECT in stretch_rect_fbo [try2]
by Alexandre Julliard 30 Mar '10

30 Mar '10

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > Hi, > > While working on some other patches, I spotted a small error in the > call to surface_get_rect for the source rectangle. I was passing > 'This' (destination) instead of Src. It doesn't work: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so visual.c && touch visual.ok wine: Unhandled page fault on read access to 0x00000050 at address 0x68e87fc9 (thread 0024), starting debugger... Unhandled exception: page fault on read access to 0x00000050 in 32-bit code (0x68e87fc9). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68e87fc9 ESP:0032f110 EBP:0032f248 EFLAGS:00010246( R- -- I Z- -P- ) EAX:00000001 EBX:68ed8d20 ECX:00000280 EDX:00000000 ESI:00000000 EDI:000001e0 Stack dump: 0x0032f110: 00146350 68ed2dbc 0032f228 00110014 0x0032f120: beef0202 7d7fb5c0 7bc4907b 68ed8d20 0x0032f130: 00147240 00000072 0032f198 68df9e66 0x0032f140: 00147240 00000080 00000080 00000001 0x0032f150: 0012fc70 00000000 00000072 00000000 0x0032f160: 00147000 686cb060 00000000 00010000 Backtrace: =>0 0x68e87fc9 IWineD3DSurfaceImpl_BltOverride+0x1529(This=<is not available>, DestRect=<is not available>, SrcSurface=(nil), SrcRect=(nil), Flags=0x1000400, DDBltFx=0x32fa9c, Filter=WINED3DTEXF_POINT) [/home/julliard/wine/wine/dlls/wined3d/surface.c:284] in wined3d (0x0032f248) 1 0x68e8b1e7 IWineD3DSurfaceImpl_Blt+0xb7(iface=<register ESI not in topmost frame>, DestRect=(nil), SrcSurface=<register EDI not in topmost frame>, SrcRect=(nil), Flags=0x1000400, DDBltFx=0x32fa9c, Filter=WINED3DTEXF_POINT) [/home/julliard/wine/wine/dlls/wined3d/surface.c:4271] in wined3d (0x0032f2d8) 2 0x686ae1bb IDirectDrawSurfaceImpl_Blt+0x1ab(iface=0x12b888, DestRect=<register ESI not in topmost frame>, SrcSurface=(nil), SrcRect=(nil), Flags=<register EDI not in topmost frame>, DDBltFx=0x32fa9c) [/home/julliard/wine/wine/dlls/ddraw/surface.c:806] in ddraw (0x0032f348) 3 0x686b0717 IDirectDrawSurface3Impl_Blt+0x47(This=0x12b88c, prcDst=(nil), pSrcSurf=(nil), prcSrc=(nil), dwFlags=0x1000400, pFX=0x32fa9c) [/home/julliard/wine/wine/dlls/ddraw/surface_thunks.c:113] in ddraw (0x0032f378) 4 0x68663213 D3D1_TextureMapBlendTest+0x263() [/home/julliard/wine/wine/dlls/ddraw/tests/visual.c:1302] in ddraw_test (0x0032fb88) 5 0x68669bb5 func_visual+0x1375() [/home/julliard/wine/wine/dlls/ddraw/tests/visual.c:2979] in ddraw_test (0x0032fd48) 6 0x6866a82e run_test+0x14e(name=<is not available>) [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:543] in ddraw_test (0x0032fd98) 7 0x6866aa02 main+0x132(argc=<couldn't compute location>, argv=<couldn't compute location>) [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:592] in ddraw_test (0x0032fe58) 8 0x6866ab9c __wine_spec_exe_entry+0x7c(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:37] in ddraw_test (0x0032fea8) 9 0x7b8584c4 start_process+0x54(peb=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/kernel32/process.c:989] in kernel32 (0x0032fee8) 10 0x7bc71344 call_thread_func+0xc() in ntdll (0x0032fef8) 11 0x7bc71510 call_thread_entry_point+0x70(entry=0x7b858470, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2459] in ntdll (0x0032ffc8) 12 0x7bc4cfca in ntdll (+0x3cfca) (0x0032ffe8) 0x68e87fc9 IWineD3DSurfaceImpl_BltOverride+0x1529 [/home/julliard/wine/wine/dlls/wined3d/surface.c:284] in wined3d: movl 0x50(%edx),%eax 284 rect_out->right = This->currentDesc.Width; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winmm: For MCI parsing, use 64bit compatible structures.
by Eric Pouech 29 Mar '10

29 Mar '10

Joerg-Cyril.Hoehle(a)t-systems.com a écrit : > Hi, > > I believe this patch can stand on its own, regardless of whether > we discover an MCI_INTEGER64 type or similar later (cf. bug 22146). > > It is not all about Wine64. I have two others in my queue: > - One deals with HWND and the like in the MCI_XYZ_PARMS. > - Another adds more tests that do not depend on sound being configured. > These are not ready yet for submission. > > Yet this first patch is good enough to start gathering results on test.winehq. > André's machine basically passed the MCI tests no worse than Wine32 with it. > > This patch depends on the Sysinfo patch from earlier today. > > Regards, > Jörg Höhle > > ------------------------------------------------------------------------ > > > this patch is ugly as hell... and it still believe we can do the MCI parser without knowing about MCI structures internals A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [PATCH 1/5] winmm: Improve MCI's Sysinfo command.
by Eric Pouech 29 Mar '10

29 Mar '10

Joerg-Cyril.Hoehle(a)t-systems.com a écrit : > Hi, > > this is the first of a series of patches I started writing last year. > It suffered from the typical "some patches are 100% complete but > follow others that are only 80%" syndrome. Now I filled in the missing parts. > > The fifth implements more tests to prove the pertinence of the code patches. > > Regards, > Jörg Höhle > > ------------------------------------------------------------------------ > > > did you test the 16 => 32 bit conversion for the MCI_ALL_DEVICE ? actually, I'd say it belongs to the 16=>32 mci message mapper, not in generic 32bit code A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

on most hated "OS" in the history of computing
by Saulius Krasuckas 29 Mar '10

29 Mar '10

Hello, This article is about Windows 3.x history and "architecture": http://www.openwatcom.org/index.php/Exploring_Windows_3.x It was nice sunday reading :) for me. S.

3 5

Re: kernel32: Fix moving a file to the same one
by Alexandre Julliard 29 Mar '10

29 Mar '10

André Hentschel <nerv(a)dawncrow.de> writes: > diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c > index 2b69e8c..d34b3a7 100644 > --- a/dlls/kernel32/path.c > +++ b/dlls/kernel32/path.c > @@ -1031,6 +1031,9 @@ BOOL WINAPI MoveFileWithProgressW( LPCWSTR source, LPCWSTR dest, > if (flag & MOVEFILE_WRITE_THROUGH) > FIXME("MOVEFILE_WRITE_THROUGH unimplemented\n"); > > + if (!strcmpiW( source, dest )) > + return TRUE; /* we are done */ > + There's a lot more to this than simply comparing the specified paths. -- Alexandre Julliard julliard(a)winehq.org

1 0

Reorganizing msvcrt related dlls implementation
by Piotr Caban 29 Mar '10

29 Mar '10

Hi, Recently I was working on some msvcrt/msvcr90 functions. I found few problems related to how the implementation is organized: - Some of the functions are invoking invalid_parameter, msvcrt is not allowing to change it, msvcr90 exports _set_invalid_parameter_handler. - create_locale (not available on msvcrt) needs almost exactly the same internal functions as set_locale. I see few ways of implementing this functions: - Copy implementations of functions that are invoking invalid_parameter_handler to msvcr90. This will introduce lots of code duplication in future (currently most of functions that should invoke invalid_parameter_handler are not implemented or are not calling it). Almost whole locale.c file will be copied. - Create wine specific dll, forward msvcrt and msvcr90 calls to it. - Move implementation of some functions from msvcrt to msvcr90. It'll probably introduce similar problems when newer msvcrXX appears. What solution is preferred? Any other ideas? Cheers, Piotr

2 1

Re: [TRY 4] [PATCH] user32: horizontal and vertical scrolling of selection in edit control
by Dmitry Timoshkov 29 Mar '10

29 Mar '10

Henry Kroll III <henry(a)comptune.com> wrote: > + if (es->region_posx < 0)EDIT_EM_LineScroll(es,-10,0); > + else if (es->region_posx > 0)EDIT_EM_LineScroll(es,10,0); > + if (es->region_posy < 0)EDIT_EM_LineScroll(es,0,-1); > + else if (es->region_posy > 0)EDIT_EM_LineScroll(es,0,1); Where do -/+10,-/+1 come from? A test case wouldn't hurt. Also please add some spacing and try to follow the indentation style of existing code. -- Dmitry.

1 0

Re: [PATCH 5/8] msvcr90: Added _get/set_invalid_parameter_handler implementation (try4)
by Paul Vriens 29 Mar '10

29 Mar '10

On 03/24/2010 10:39 PM, Piotr Caban wrote: > + p_invalid_parameter = (void *)GetProcAddress( hMsvcrt,"_invalid_parameter"); > + if(p_invalid_parameter) > + *p_invalid_parameter = test_invalid_parameter_handler; Hi Piotr, That last assignment makes the tests crash on Vista+. Could you have a look? -- Cheers, Paul.

1 0

Re: on most hated "OS" in the history of computing
by James Mckenzie 29 Mar '10

29 Mar '10

Saulius Krasuckas <saulius2(a)ar.fi.lt> wrote: > >Hello, > >This article is about Windows 3.x history and "architecture": >http://www.openwatcom.org/index.php/Exploring_Windows_3.x > >It was nice sunday reading :) for me. > Interesting that ANYONE would consider any version of Windows 3.x as an operating system. Now, computing environment is a different answer. Programming for it was an adventure. You should see what happens when 'resources' empty out. As to the openwatcom question, I used to have programming books for Windows 3.1 that came with the full MS build environment... Those were the days....Setting up NICs on Windows 3.1.1 for an enterprise level test... James McKenzie

2 1

Re: [PATCH 3/3] gdiplus: Implement GdipSetPathGradientSurroundColorsWithCount and GdipGetPathGradientSurroundColorCount [Try 2]
by Vincent Povirk 29 Mar '10

29 Mar '10

You should also update GdipCloneBrush so that it makes a copy of this new array. On Sun, Mar 28, 2010 at 11:22 PM, Justin Chevrier <jchevrier(a)gmail.com> wrote: > Now taking a copy of the color array. Thanks Nikolay > --- > dlls/gdiplus/brush.c | 27 +++++++++++++++++++-------- > dlls/gdiplus/gdiplus_private.h | 2 ++ > dlls/gdiplus/tests/brush.c | 6 +++--- > 3 files changed, 24 insertions(+), 11 deletions(-) > > diff --git a/dlls/gdiplus/brush.c b/dlls/gdiplus/brush.c > index 8994b87..7f5c8f7 100644 > --- a/dlls/gdiplus/brush.c > +++ b/dlls/gdiplus/brush.c > @@ -578,9 +578,10 @@ GpStatus WINGDIPAPI GdipCreatePathGradient(GDIPCONST GpPointF* points, > GdipFree(*grad); > return OutOfMemory; > } > - (*grad)->blendfac[0] = 1.0; > - (*grad)->blendpos = NULL; > - (*grad)->blendcount = 1; > + (*grad)->blendfac[0] = 1.0; > + (*grad)->blendpos = NULL; > + (*grad)->blendcount = 1; > + (*grad)->surroundcolors = NULL; > > (*grad)->pathdata.Count = count; > (*grad)->pathdata.Points = GdipAlloc(count * sizeof(PointF)); > @@ -946,6 +947,7 @@ GpStatus WINGDIPAPI GdipDeleteBrush(GpBrush *brush) > GdipFree(((GpPathGradient*) brush)->pathdata.Types); > GdipFree(((GpPathGradient*) brush)->blendfac); > GdipFree(((GpPathGradient*) brush)->blendpos); > + GdipFree(((GpPathGradient*) brush)->surroundcolors); > break; > case BrushTypeSolidColor: > if (((GpSolidFill*)brush)->bmp) > @@ -1174,7 +1176,9 @@ GpStatus WINGDIPAPI GdipGetPathGradientSurroundColorCount(GpPathGradient *brush, > if (!brush || !count) > return InvalidParameter; > > - return NotImplemented; > + *count = brush->surroundcolorcount; > + > + return Ok; > } > > GpStatus WINGDIPAPI GdipGetPathGradientWrapMode(GpPathGradient *brush, > @@ -1544,7 +1548,7 @@ GpStatus WINGDIPAPI GdipSetPathGradientSigmaBlend(GpPathGradient *grad, > GpStatus WINGDIPAPI GdipSetPathGradientSurroundColorsWithCount(GpPathGradient > *grad, GDIPCONST ARGB *argb, INT *count) > { > - static int calls; > + ARGB *new_colors; > > TRACE("(%p,%p,%p)\n", grad, argb, count); > > @@ -1552,10 +1556,17 @@ GpStatus WINGDIPAPI GdipSetPathGradientSurroundColorsWithCount(GpPathGradient > (*count > grad->pathdata.Count)) > return InvalidParameter; > > - if(!(calls++)) > - FIXME("not implemented\n"); > + new_colors = GdipAlloc(*count * sizeof(ARGB)); > + if (!new_colors) return OutOfMemory; > > - return NotImplemented; > + memcpy(new_colors, argb, *count * sizeof(ARGB)); > + > + GdipFree(grad->surroundcolors); > + > + grad->surroundcolorcount = *count; > + grad->surroundcolors = new_colors; > + > + return Ok; > } > > GpStatus WINGDIPAPI GdipSetPathGradientWrapMode(GpPathGradient *grad, > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index ca1cba6..eddde11 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -151,6 +151,8 @@ struct GpPathGradient{ > GpBrush brush; > PathData pathdata; > ARGB centercolor; > + INT surroundcolorcount; > + ARGB* surroundcolors; > GpWrapMode wrap; > BOOL gamma; > GpPointF center; > diff --git a/dlls/gdiplus/tests/brush.c b/dlls/gdiplus/tests/brush.c > index 0effcf4..820cb4e 100644 > --- a/dlls/gdiplus/tests/brush.c > +++ b/dlls/gdiplus/tests/brush.c > @@ -683,7 +683,7 @@ static void test_gradientsurroundcolorcount(void) > } > > status = GdipSetPathGradientSurroundColorsWithCount(grad, color, &count); > - todo_wine expect(Ok, status); > + expect(Ok, status); > expect(2, count); > > status = GdipGetPathGradientSurroundColorCount(NULL, &count); > @@ -694,8 +694,8 @@ static void test_gradientsurroundcolorcount(void) > > count = 0; > status = GdipGetPathGradientSurroundColorCount(grad, &count); > - todo_wine expect(Ok, status); > - todo_wine expect(2, count); > + expect(Ok, status); > + expect(2, count); > > GdipFree(color); > GdipDeleteBrush((GpBrush*)grad); > -- > 1.6.5.rc1 > > > >

1 0

Wine and OpenSearch
by GOUJON Alexandre 28 Mar '10

28 Mar '10

Hi, When your app doesn't work on wine, you need to open a wine source file and try to understand what does it do and what goes wrong. Even if they're named explicitly, you may have to look at its code. And so you're asking where can this function be defined ? You can use the command line with find but I prefer using "grep" feature available at http://source.winehq.org/git/wine.git/?a=shortlog because you can then open in your web browser the file exactly where you want. And you may read something like "solved by commit xxx" on bugzilla without a link. In this case, I also open the same URL as above and click on any commitdiff link. I cut the end of the new URL and paste what I read previously. So, I wondered : "Hey ! Why don't you use your search plugins to do that !" (I'm on Firefox but all web browsers have this feature too) Here is why I wrote these two xml. Two lines have to be included on the server side. And the good news is it's even compatible with IE. Should I send these at wine-patches ? Any comment ?

2 2

Wine FIXME Report February 2010
by Michael Stefaniuc 27 Mar '10

27 Mar '10

Update ====== The February report has following changes to the previous report: - More understandable table titles and descriptions (thanks Francois!). - All tables have the same column layout (thanks Francois!). - Introduced new "Mean" column for the mean lines per logs ratio. Wine FIXME Report February 2010 =============================== The data for this report comprise the emails from February 2010 archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 6058 (emails: 5505, bugzilla attachments: 553) Files (logs) with FIXME/ERR/WARN: 496 Type | Total | Unique ------+---------+------- fixme | 108062 | 27062 warn | 53510 | 2347 err | 4516 | 1230 Most Frequent Messages By Logs ------------------------------ Messages that are present in most Wine output logs collected. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 68 | 222 | 3.26 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 56 | 62 | 1.11 | system:SetProcessDPIAware stub! 49 | 71 | 1.45 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 36 | 58 | 1.61 | mixer:ALSA_MixerInit No master control found on HDA ATI HDMI, disabling mixer 32 | 163 | 5.09 | d3d9:Direct3DShaderValidatorCreate9 stub 29 | 78 | 2.69 | urlmon:URLMoniker_BindToObject use running object table 27 | 62 | 2.30 | shdocvw:BindStatusCallback_OnProgress status code 11 25 | 68 | 2.72 | crypt:CRYPT_CriticalExtensionsSupported unsupported critical extension "2.5.29.32" 24 | 96 | 4.00 | advapi:DeregisterEventSource (0xcafe4242) stub 23 | 48 | 2.09 | shdocvw:PropertyNotifySink_OnChanged unimplemented dispid 1005 ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 20 | 29 | 1.45 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 19 | 26 | 1.37 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 18 | 61 | 3.39 | ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded 14 | 32 | 2.29 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded 14 | 59 | 4.21 | ole:CoUninitialize Mismatched CoUninitialize 13 | 32 | 2.46 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 13 | 30 | 2.31 | rpc:I_RpcGetBuffer no binding 11 | 12 | 1.09 | ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. Most Frequent Messages By Mean Lines Per Logs --------------------------------------------- This are the messages which show up in at least 1% of the logs and have the highest mean lines per logs ratio. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 5 | 987 | 197.40 | d3d_surface:IWineD3DBaseSurfaceImpl_Blt Filters not supported in software blit 12 | 269 | 22.42 | d3d:debug_d3dformat Unrecognized 909200449 (as fourcc: AL16) WINED3DFORMAT! 12 | 269 | 22.42 | d3d:debug_d3dformat Unrecognized 909201952 (as fourcc: R16) WINED3DFORMAT! 12 | 269 | 22.42 | d3d:getFormatDescEntry Can't find format unrecognized(909200449) in the format lookup table 12 | 269 | 22.42 | d3d:getFormatDescEntry Can't find format unrecognized(909201952) in the format lookup table 7 | 137 | 19.57 | msi:ACTION_CustomAction Rollback only action... rollbacks not supported yet 5 | 97 | 19.40 | shdocvw:OleControl_OnAmbientPropertyChange Unknown dispID -701 5 | 94 | 18.80 | shdocvw:OleControl_OnAmbientPropertyChange Unknown dispID -703 5 | 94 | 18.80 | shdocvw:OleControl_OnAmbientPropertyChange Unknown dispID -704 6 | 92 | 15.33 | advapi:LsaClose (0xcafe) stub ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 5 | 335 | 67.00 | toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 7 | 65 | 9.29 | ole:CoCreateInstance apartment not initialised 8 | 62 | 7.75 | richedit:ReadStyleSheet skipping optional destination 14 | 59 | 4.21 | ole:CoUninitialize Mismatched CoUninitialize 18 | 61 | 3.39 | ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded 13 | 32 | 2.46 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 13 | 34 | 2.62 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 11 | 25 | 2.27 | ole:CoGetContextToken apartment not initialised 14 | 32 | 2.29 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded Functions With Most Messages By Mean Lines Per Logs --------------------------------------------------- This are the functions which show up in at least 1% of the logs and have the highest mean lines per logs ratio. FIXME: Logs | Lines | Mean | Channel:Function ------+-------+--------+----------------- 9 | 7269 | 807.67 | d3d_draw:drawStridedFast 40 | 7033 | 175.82 | mcimidi:MIDI_mciPlay 6 | 988 | 164.67 | d3d_surface:IWineD3DBaseSurfaceImpl_Blt 5 | 637 | 127.40 | d3d_surface:surface_convert_format 33 | 1752 | 53.09 | ole:OleQueryLinkFromData 6 | 208 | 34.67 | mshtml:HTMLBodyElement_put_scroll 32 | 1107 | 34.59 | winsock:WSAIoctl 289 | 8490 | 29.38 | dinput:_dump_diactionformatA 13 | 385 | 29.62 | xrender:X11DRV_AlphaBlend 5 | 139 | 27.80 | d3d_surface:surface_upload_data ERR: Logs | Lines | Mean | Channel:Function ------+-------+--------+----------------- 7 | 558 | 79.71 | msxml:xmlnode_get_baseName 5 | 335 | 67.00 | toolbar:TOOLBAR_GetImageListForDrawing 9 | 555 | 61.67 | d3d:state_colorwrite 7 | 81 | 11.57 | d3d:getColorBits 7 | 65 | 9.29 | ole:CoCreateInstance 8 | 62 | 7.75 | richedit:ReadStyleSheet 6 | 33 | 5.50 | ole:marshal_object 33 | 149 | 4.52 | ole:CoInitializeEx 14 | 59 | 4.21 | ole:CoUninitialize 26 | 113 | 4.35 | ole:create_server Messages With The Highest Repetition Count ------------------------------------------ The messages with the highest repetition count in a single log file. FIXME: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 1 | 6628 | 6628.0 | d3d_draw:drawStridedFast >>>>>>>>>>>>>>>>> GL_OUT_OF_MEMORY (0x505) from glDrawElements @ drawprim.c / 47 1 | 5906 | 5906.0 | d3d_texture:apply_wrap Unrecognized or unsupported WINED3DTEXTUREADDRESS 0. 3 | 4044 | 1348.0 | d3d:IWineD3DSwapChainImpl_Present Render-to-fbo with WINED3DSWAPEFFECT_FLIP 1 | 2977 | 2977.0 | d3d:debug_d3dusagequery Unrecognized usage query flag(s) 0x1 1 | 2128 | 2128.0 | d3d:context_set_draw_buffer >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glDrawBuffer() @ context.c / 2130 3 | 1740 | 580.0 | d3d:state_clipping Clipping disabled, but ARB_depth_clamp isn't supported. 1 | 1334 | 1334.0 | d3d_shader:shader_glsl_select >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from glUseProgram ObjectARB @ glsl_shader.c / 4562 1 | 1075 | 1075.0 | d3d7:IDirect3DDeviceImpl_7_GetClipStatus (0x16fc330)->(0x4fbe60): Stub! 1 | 1075 | 1075.0 | d3d7:IDirect3DDeviceImpl_7_SetClipStatus (0x16fc330)->(0x4fbe60): Stub! 1 | 1048 | 1048.0 | winsock:WSAIoctl SIO_GET_EXTENSION_FUNCTION_POINTER {25a207b9-ddf3-4660-8ee9-76e58c74063e}: stub ERR: Logs | Lines | Mean | Channel:Function Text ------+-------+--------+---------------------- 1 | 480 | 480.0 | dsound:DSOUND_MixOne Fatal error. Under/Overflow? primary_done=82908, mixpos=40832/176400 (40832/176400), primary_mixpos=40832, writepos=46124, mixlen=128 4 | 297 | 74.2 | d3d:state_colorwrite (WINED3DRS_COLORWRITEENABLE1/2/3,0,0,0) not yet implemented. Missing of cap D3DPMISCCAPS_INDEPENDENTWRITEMASKS wasn't honored? 3 | 275 | 91.7 | msxml:xmlnode_get_baseName Unhandled type 8 5 | 145 | 29.0 | toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 3 | 111 | 37.0 | xrender:get_xrender_format_from_color_shifts No XRender format found! 1 | 56 | 56.0 | ole:CoInitializeEx Attempt to change threading model of this apartment from 1 | 51 | 51.0 | ole:CoGetClassObject class {88d969c0-f192-11d4-a65f-0040963251e5} not registered 1 | 51 | 51.0 | ole:CoGetClassObject no class object {88d969c0-f192-11d4-a65f-0040963251e5} could be created for context 0x5 2 | 51 | 25.5 | ole:create_server class {88d969c0-f192-11d4-a65f-0040963251e5} not registered 1 | 44 | 44.0 | threadpool:iocp_poller NtRemoveIoCompletion failed: 0xc0000008 Further Info: ============= The sqlite3 database and the perl script to output the above report can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/201002/ bye michael

1 0

[patch] DNS_SD bridge, v2
by C.W. Betts 27 Mar '10

27 Mar '10

The following is an updated patch that actually builds and links. The patch does patch configure and config.h.in, both of which were generated with an older version of autoconf and autoheader.

3 4

Re: [PATCH 3/3] gdiplus: Implement GdipSetPathGradientSurroundColorsWithCount and GdipGetPathGradientSurroundColorCount
by Nikolay Sivov 27 Mar '10

27 Mar '10

On 3/28/2010 00:55, Justin Chevrier wrote: > GpStatus WINGDIPAPI GdipGetPathGradientWrapMode(GpPathGradient *brush, > @@ -1544,18 +1546,16 @@ GpStatus WINGDIPAPI GdipSetPathGradientSigmaBlend(GpPathGradient *grad, > GpStatus WINGDIPAPI GdipSetPathGradientSurroundColorsWithCount(GpPathGradient > *grad, GDIPCONST ARGB *argb, INT *count) > { > - static int calls; > - > TRACE("(%p,%p,%p)\n", grad, argb, count); > > if(!grad || !argb || !count || (*count<= 0) || > (*count> grad->pathdata.Count)) > return InvalidParameter; > > - if(!(calls++)) > - FIXME("not implemented\n"); > + grad->surroundcolorcount = *count; > + grad->surroundcolors = argb; > > - return NotImplemented; > + return Ok; > } > You should make a copy of colors array here. Wrapper method will free array after a call.

1 0

Google Summer of Code ideas
by Charles Davis 27 Mar '10

27 Mar '10

Hi, I intend to participate in the Google Summer of Code this year, and I have several ideas for Wine that I'd like to bounce off you guys to see what you think. Note that all my proposals are Mac OS-based (I run Mac OS X), so many of you will never see the results of what I'm working on. Here they are: 1. Quartz Driver. This is something a lot of Wine-on-Mac users (myself included) have been wanting for while now. Of course, the entire driver itself is a big project, so I would limit the scope to implementing a small piece of it--say, windowing (which shouldn't be too hard thanks to my new "Deobjectivizer" tool)--and then finishing what I started after SoC ends. 2. QuickTime backend for DirectShow. This is is similar to the GStreamer backend, but it won't require people to install GStreamer on Mac just to get this support. To get 64-bit support, we have to use the Cocoa version of QuickTime, but again, thanks to Deobjectivizer, we can avoid writing it in Objective-C. 3. Implementing SCSI support on Mac OS X. I had patches to do this, but I deleted them because I thought they were inadequate. I want to do this to get copy protection working for some games on Mac OS X. Comments welcome. Chip

4 4

wisotool: a script to automate multi-cd installs
by Dan Kegel 27 Mar '10

27 Mar '10

I was looking at the bookshelf full of old games I've collected over the years, and was annoyed that there wasn't any sort of unattended regression test for their installers... 'course, that's hard, since you'd have to somehow insert the cd-roms automatically. But you can kind of fake it by mounting .iso files, at least for some games, so I tried doing it for Diablo II. And it seems to work! I wrapped it up in an extensible script, with a menu and some functions stolen from winetricks. It's at http://code.google.com/p/winezeug/source/browse/trunk/wisotool (though you have to check out that directory from svn to run it, as it currently depends on two other files there). The idea is you run the script like this to load a cd-rom into its cache of .iso files: sh wisotool load If the cd-rom has a key associated with it, specify it like this: sh wisotool load=XXX-YYY-ZZZ-WWW The .iso files are cached in ~/.wisotoolcache in filenames named after their sha1sums (so best run on a fast machine :-) Then (assuming somebody has added a verb for the app to the script), you can then run the script to install from the .iso files. For instance, sh wisotool diablo2 or sh wisotool morrowind It only supports those two games at the moment, it doesn't run on windows yet (though it should eventually), and the diablo2 verb starts the game (I couldn't figure out how to stop it). It's kind of like playonlinux in that it has separate scripts (well, functions) for each game it supports, but utterly unlike playonlinux because it doesn't try to patch or futz with wine in any way (beyond running winetricks if needed), and the installs are totally unattended (unlike playonlinux, where you have to click things and insert discs). I have no idea how many games this will work for, but heck, may as well try it. I expect to use this in automated testing sometime, and welcome additional verbs if people feel like writing them. - Dan

1 1

Verbose explanation about the cygwin issue
by GOUJON Alexandre 26 Mar '10

26 Mar '10

Alexandre, (I hope I'm not being direspectful) your patch (561a3e643ea8b35adfc032d3afa979c622fcec23) did not work. I know that there is no Cygwin VM in WineTestBot yet to test such a patch. I think I was not very clear about the issue on cygwin so this time I'll be more .. verbose. Here is the relevant call stack of winegcc on cygwin : 1093 _int main(int argc, char **argv) 1373 _ else if (linking) build(&opts); 559 _static void build(struct options* opts) 722 _ strarray_add(link_args, mingw_unicode_hack(opts)); 547 _static const char *mingw_unicode_hack( struct options *opts ) 556 _ return compile_to_object( opts, main_stub, NULL ); 457 _static const char* compile_to_object(struct options* opts, const char* file, const char* lang) 470 _ compile(&copts, lang); 309 _static void compile(struct options* opts, const char* lang) ...here your patch didn't change anything because it hasn't been read 453 _ spawn(opts->prefix, comp_args, 0); so winegcc [1] calls ccache gcc-4 -D__WINE__ -c -o cmd.exe-2VhiZq-6BngcL.o cmd.exe-2VhiZq.c -I../../include that leads to cmd.exe-2VhiZq.c: In function ‘main’: cmd.exe-2VhiZq.c:5: error: ‘__wargv’ undeclared (first use in this function) cmd.exe-2VhiZq.c:5: error: (Each undeclared identifier is reported only once cmd.exe-2VhiZq.c:5: error: for each function it appears in.) winegcc: ccache failed make: *** [cmd.exe] Error 2 To fix it, we need to add msvcrt include (not to link with msvcrt : it's a .o) ccache gcc-4 -D__WINE__ -c -o cmd.exe-iqnSoR-q4unrB.o cmd.exe-iqnSoR.c -I../../include -I../../include/msvcrt/ succeeds. At this point, we return from mingw_unicode_hack to line 722. And winegcc goes on: 779 _ if (!opts->shared && (opts->use_msvcrt || opts->unicode_app)) strarray_add(link_args, "-lmsvcrt"); ...your patch 781 _if (res_o_name) compile_resources_to_object( opts, resources, res_o_name ); ...the previous line works, no errors but 783 _ spawn(opts->prefix, link_args, 0); ..fails Indeed, the linker [2] wants to link with msvcrt but don't know where the library is : /usr/lib/gcc/i686-pc-cygwin/4.3.4/../../../../i686-pc-cygwin/bin/ld: cannot find -lmsvcrt collect2: ld returned 1 exit status winegcc: ccache failed make: *** [cmd.exe] Error 2 Finally, adding -L option [3], all's right. Sorry for this looong mail. I think I won't send a patch but if you ask me. So thanks again and have a nice week end. --- [1] ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -mconsole -municode batch.o builtins.o directory.o wcmdmain.o Cs.res Da.res De.res En.res Es.res Fr.res It.res Ja.res Ko.res Lt.res Nl.res No.res Pl.res Pt.res Ru.res Si.res Tr.res wcmdrc.res -o cmd.exe -lshell32 -luser32 -ladvapi32 -lkernel32 -lwine ../../libs/port/libwine_port.a [2] ccache gcc-4 -mconsole -o cmd.exe cmd.exe-iqnSoR-q4unrB.o -L../../dlls -L../../libs/wine batch.o builtins.o directory.o wcmdmain.o cmd.exe-XiDu0i.res.o -L../../dlls/shell32 -lshell32 -L../../dlls/user32 -luser32 -L../../dlls/advapi32 -ladvapi32 -L../../dlls/kernel32 -lkernel32 -L../../libs/wine -lwine -L../../libs/port -lwine_port -L../../dlls/winecrt0 -lwinecrt0 -lmsvcrt [3] ccache gcc-4 -mconsole -o cmd.exe cmd.exe-mfRWfQ-uwdRsu.o -L../../dlls -L../../libs/wine batch.o builtins.o directory.o wcmdmain.o cmd.exe-1DumDa.res.o -L../../dlls/shell32 -lshell32 -L../../dlls/user32 -luser32 -L../../dlls/advapi32 -ladvapi32 -L../../dlls/kernel32 -lkernel32 -L../../libs/wine -lwine -L../../libs/port -lwine_port -L../../dlls/winecrt0 -lwinecrt0 -lmsvcrt -L../../dlls/msvcr

5 9

Latest Git Fails tools/install
by chris ahrendt 26 Mar '10

26 Mar '10

> Compiling Wine. Grab a lunch or two, rent a video, or whatever, > in the meantime... > > config.status: executing Makefile commands > cat: Make.tmp: No such file or directory > config.status: error: could not create Makefile > make: *** [Makefile] Error 1 > config.status: executing Makefile commands > cat: Make.tmp: No such file or directory > config.status: error: could not create Makefile > make: *** [Makefile] Error 1 > > Compilation failed, aborting install. Ideas? Chris

5 6

Re: [PATCH 4/4] mshtml: Added IHTMLElement:removeAttribute tests.
by Paul Vriens 26 Mar '10

26 Mar '10

Hi Jacek, On 03/24/2010 08:01 PM, Jacek Caban wrote: > +function test_removeAttribute(e) { > + ok(e.removeAttribute('nonexisting') === false, "removeAttribute('nonexisting') didn't return false"); > + > + e.title = "title"; > + ok(e.removeAttribute('title') === true, "removeAttribute('title') didn't return true"); > + ok(e.title === "", "e.title = " + e.title); > + ok(("title" in e) === true, "title is not in e"); (commenting that one) > + > + e["myattr"] = "test"; > + ok(e.removeAttribute('myattr') === true, "removeAttribute('myattr') didn't return true"); > + ok(e["myattr"] === undefined, "e['myattr'] = " + e['myattr']); (and that one) > + ok(("myattr" in e) === false, "myattr is in e"); (and that one makes the tests run again). > + > +} These new tests introduce timeouts on IE5 (and lower?). If I just open the jstest.html in a IE5 browser I get a warning for some of the lines: > + ok(("title" in e) === true, "title is not in e"); > + ok(("myattr" in e) === false, "myattr is in e"); shows: Line: 14 Char: 17 (18 for that second one of course) Error: Expected ')' -- Cheers, Paul.

2 1

Re: 3/4 wined3d: add color_fill to blit_shader [try 2]
by Henri Verbeet 26 Mar '10

26 Mar '10

That's more reasonable, but you still have a NULL function pointer in arbfp_blit for color_fill(), and blit_operation is unused.

1 0

Re: 3/4 wined3d: add color_fill to blit_shader
by Henri Verbeet 25 Mar '10

25 Mar '10

On 25 March 2010 23:04, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This patch adds a first part of the new blit_shader infrastructure. In > a few days I plan to submit more parts of it which will extend the > blit_shader and rewrite parts in the end. > This is patch is pretty hacky. > +static const struct blit_shader *blitters[] = > +{ > + &ffp_blit, > + &cpu_blit > +}; This doesn't make much sense here. You'll probably want to make it a variable local to surface_select_blitter() as a start, but eventually it should be stored in the device / adapter. > +const struct blit_shader *surface_select_blitter(const struct wined3d_gl_info *gl_info, IWineD3DSurfaceImpl *src, IWineD3DSurfaceImpl *dst, enum blit_operation op) Why do we have both this and select_blit_implementation() now? Also, static. > + switch(op) > + { > + case BLIT_OP_COLOR_FILL: > + return TRUE; > + default: > + return FALSE; > + } This is a silly way to write "return op == BLIT_OP_COLOR_FILL;". > +const struct blit_shader cpu_blit = { > + NULL, /* alloc_private */ > + NULL, /* free_private */ > + NULL, /* set_shader */ > + NULL, /* unset_shader */ > + NULL, /* color_fixup_supported */ > + cpu_blit_can_blit, > + cpu_blit_color_fill > }; You can't do that, callers don't check these for NULL. > +typedef enum blit_operation > +{ > + BLIT_OP_COLOR_FILL=1, > + BLIT_OP_BLIT_SYSMEM_TO_DRAWABLE=2, > + BLIT_OP_BLIT_DRAWABLE_TO_TEXTURE=3 > +} blit_operation; Besides being unused, the distinction between "SYSMEM_TO_DRAWABLE", "DRAWABLE_TO_TEXTURE", and other potential variants is an implementation detail callers shouldn't care about. Also, we don't care about the exact values of the enum elements, and the typedef only obscures the type of "blit_operation". > BOOL (*color_fixup_supported)(const struct wined3d_gl_info *gl_info, struct color_fixup_desc fixup); > + BOOL (*can_blit)(const struct wined3d_gl_info *gl_info, blit_operation op, IWineD3DSurfaceImpl *src_surface, IWineD3DSurfaceImpl *dst_surface); The functionality of "can_blit" is a superset of "color_fixup_supported". > + IWineD3DSurface_GetContainer((IWineD3DSurface*)dst_surface, &IID_IWineD3DSwapChain, (void **)&dst_swapchain); > + if(dst_swapchain) IWineD3DSwapChain_Release((IWineD3DSwapChain *) dst_swapchain); That's three different styles of doing a cast, in two lines of code. And code that's supposedly being rewritten at that. At this point I don't even care about the exact style you're using (although I do have a preference), but try to at least care about consistency. Same goes for these: > + if(dst_swapchain) IWineD3DSwapChain_Release((IWineD3DSwapChain *) dst_swapchain); > + switch(op) > + if ((IWineD3DSurface*)dst_surface != device->render_targets[0] && > +const struct blit_shader *surface_select_blitter(const struct wined3d_gl_info *gl_info, IWineD3DSurfaceImpl *src, IWineD3DSurfaceImpl *dst, enum blit_operation op) This line is a bit long for my taste. I think I have relatively large screens, but this takes up over half a screen. Personally I think 120 characters is a reasonable upper limit, but there are probably plenty of people that would be happier with 80. Essentially, I think you're trying to take too large steps. E.g. splitting of functionality into cpu_blit_color_fill(), ffp_blit_color_fill(), etc. is ok, hacking it into struct blit_shader isn't. Extending color_fixup_supported() into something like blit_supported() could also be a reasonable patch, on its own, but trying to do it all at the same time becomes hacky pretty quickly.

1 0

Re: 1/4 wined3d: Move argb_to_fmt to utils.c as a helper function to be used in more places.
by Stefan Dösinger 25 Mar '10

25 Mar '10

Am Donnerstag 25 März 2010 23:02:33 schrieb Roderick Colenbrander: > +DWORD color_convert_argb_to_fmt(DWORD color, WINED3DFORMAT destfmt) This only works with formats that are encoded in integers with 32 bit or less. Do we care about this limitation?

3 2

Re: [PATCH 6/8] msvcrt: Added _strtoi64 implementation (try4)
by Alexandre Julliard 25 Mar '10

25 Mar '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcr80/msvcr80.spec | 4 +- > dlls/msvcr90/msvcr90.spec | 4 +- > dlls/msvcrt/msvcrt.h | 44 ++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 4 +- > dlls/msvcrt/string.c | 80 ++++++++++++++++++++++++++++ > dlls/msvcrt/tests/string.c | 123 > ++++++++++++++++++++++++++++++++++++++++++++ > include/msvcrt/crtdefs.h | 52 ++++++++++++++++++ > 7 files changed, 305 insertions(+), 6 deletions(-) This one doesn't build on Mingw either, because of crtdefs.h conflicts. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] dlls/crypt32: unit test PFXImportCertStore()
by Juan Lang 25 Mar '10

25 Mar '10

Hi Philippe, in addition to the question I had on patch 1/2, I'd like to know, what is the purpose of this test? +static void test_createCertificateStore(void) +{ + HCERTSTORE certStore = NULL; + + certStore = CertOpenStore(CERT_STORE_PROV_SYSTEM, 0, (HCRYPTPROV)NULL, + CERT_SYSTEM_STORE_CURRENT_USER, L"Test Store"); + ok(certStore != NULL, "could not open the system certificate store\n"); + if (certStore) + { + CertCloseStore(certStore, 0); + } This is already covered by tests in store.c, and you're not using "Test Store" elsewhere in the tests, so I don't see why this is necessary. For future reference, L"" string constants aren't portable, don't use them in the tests. And, please use CertOpenStoreW if you're going to use a wide-string parameter to it, or CertOpenStoreA if you're going to use an ASCII string. Thanks, --Juan

2 1

Re: Patch: Bug 19668 cmd /c doesn't wait before exiting
by André Hentschel 25 Mar '10

25 Mar '10

Hi Anh and Welcome to Wine! It seems your patch got mangled in transit, e.g. git apply says: fatal: corrupt patch at line 33 If you have a look at it at http://source.winehq.org/patches/ you see that the lines are wrapped. -- Best Regards, André Hentschel

1 0

inconsistencies in MCI headers w.r.t. to 64bit
by Joerg-Cyril.Hoehle＠t-systems.com 25 Mar '10

25 Mar '10

Dmitry, On 1/1/2004 you changed include/digitalv.h: DWORD dwReturn to DWORD_PTR However mmsystem.h uses DWORD. This is indeed what MSDN documents http://msdn.microsoft.com/en-us/library/dd798406%28VS.85%29.aspx http://msdn.microsoft.com/en-us/library/dd743409%28VS.85%29.aspx yet I refuse to believe it. I believe that all the MCI_XYZ_PARMS structures are consistent, so that a generic MCI string command parser is possible. That requires regular types. Eric Pouech wrote: http://www.winehq.org/pipermail/wine-devel/2010-February/081660.html >in that case, we (likely) need to write integral values as DWORD (on >both 32 and 64 bit systems) and strings & pointers as DWORD_PTR Indeed I believe that MCI_INTEGER (and hence dwReturn) should be mapped to DWORD and MCI_STRING (hence lpstrReturn) to DWORD_PTR. I believe EPP and part of AJ's recent winmm patches are wrong about 64bit. That could explain crashes or timeouts test.winehq shows for all machines running 64bit Wine (as opposed to 64bit Linux systems running 32bit Wine) in the mci tests. What evidence did you have for these changes? MSDN only or tests with natively compiled programs on native 64bit systems? Michael Stefaniuc wrote: http://www.winehq.org/pipermail/wine-devel/2010-February/081853.html >WTB uses Mingw to build the tests I could write a patch, but how to test it? WTB has 64bit boxes, but I don't know what headers WTB uses for compilation (MingW or Wine ones?) and thus whether to trust binaries compiled on WTB. OTOH, it might be that MS is really so messy that incompatible structure definitions are used and that the MCI command string parser is full of special fixes for particular devices. This might not be the first time. I already spotted a case with AVIVIDEO where the resource and structure layout are not in the same order: Look up SETVIDEO Quality and Algorithm and see for yourself. This means that Wine's regular parser -- and perhaps native as well, who knows -- fill the structure in an order incompatible with MCI_DGV_SETVIDEO_PARMS. It is possible that native's parser knows about this and fixes the order. As I don't know how to test that function, I never publicly wrote about this before. In the end, - what headers does WTB's MingW use for compilation? - Does anyone have an other idea why the mci and midi tests hang or crash on systems running wine64? Regards, Jörg Höhle

4 4

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests
by Greg Geldorp 25 Mar '10

25 Mar '10

Hi Mike, > From: Mike Kaplinskiy > > I recently discovered > that winetestbot doesn't run on win98 by default - will keep that in > mind in the future. Is there any reason for that? Not really, apart from a certain amount of hate on my side towards Win9x. I've added W98SE (which you might have guessed runs Windows 98 Second Edition) to the default set. Ge.

1 0

Re: [1/3] WineD3D: check the GL flags in CheckDepthStencilCapability, not the static info
by Henri Verbeet 25 Mar '10

25 Mar '10

On 24 March 2010 23:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > These flags will be unset if the format is not supported by GL and is consistent with the other > depth stencil check functions. So what happens if the GL implementation doesn't support ARB_depth_texture, for example?

3 7

Re: [PATCH] user32: end scrollbar tracking if the mouse capture is lost (retry)
by Paul Vriens 25 Mar '10

25 Mar '10

On 03/25/2010 09:15 AM, Sébastien Ramage wrote: > --- > dlls/user32/scroll.c | 5 +---- > dlls/user32/tests/scroll.c | 16 +++++++++++++++- > 2 files changed, 16 insertions(+), 5 deletions(-) > Hi You can see at http://source.winehq.org/patches/ that your patch '59740' had an apply failure. And fair enough: $ patch -p 1 -i /home/paul/0001-PATCH-user32-end-scrollbar-tracking-if-the-mouse-captu.txt (Stripping trailing CRs from patch.) patching file dlls/user32/scroll.c (Stripping trailing CRs from patch.) patching file dlls/user32/tests/scroll.c You have DOS line endings in your patch. A simple dos2unix fixes this. -- Cheers, Paul.

2 2

Re: [PATCH 2/8] msvcr90: Implement _encode_pointer and _decode_pointer (try4)
by Alexandre Julliard 25 Mar '10

25 Mar '10

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcr80/msvcr80.spec | 4 ++-- > dlls/msvcr90/msvcr90.c | 21 +++++++++++++++++++++ > dlls/msvcr90/msvcr90.spec | 4 ++-- > dlls/msvcr90/tests/msvcr90.c | 26 +++++++++++++++++++++++++- > 4 files changed, 50 insertions(+), 5 deletions(-) Still doesn't build on Mingw I'm afraid: make[1]: Entering directory `/home/julliard/wine/build/obj-pe64/dlls/msvcr80' ../../../obj-elf64/tools/winegcc/winegcc -b x86_64-pc-mingw32 -m64 -B../../../obj-elf64/tools/winebuild --sysroot=../.. -shared ../../../wine/dlls/msvcr80/msvcr80.spec msvcr80.o -o msvcr80.dll -lmsvcrt -lmsvcr90 -lkernel32 ../../libs/port/libwine_port.a /home/julliard/wine/mingw/mingw64/bin/../lib/gcc/x86_64-pc-mingw32/4.5.0/../../../../x86_64-pc-mingw32/lib/libmingw32.a(lib64_libmingw32_a-mingw_helpers.o): In function `_decode_pointer': /home/buildbot/mingwslave/linux-x86_64/build/mingw/obj/../mingw-w64-crt/crt/mingw_helpers.c:20: multiple definition of `__decode_pointer' ../../dlls/msvcr90/libmsvcr90.a(dwaes00111.o):(.text+0x0): first defined here /home/julliard/wine/mingw/mingw64/bin/../lib/gcc/x86_64-pc-mingw32/4.5.0/../../../../x86_64-pc-mingw32/lib/libmingw32.a(lib64_libmingw32_a-mingw_helpers.o): In function `_encode_pointer': /home/buildbot/mingwslave/linux-x86_64/build/mingw/obj/../mingw-w64-crt/crt/mingw_helpers.c:26: multiple definition of `__encode_pointer' ../../dlls/msvcr90/libmsvcr90.a(dwaes00118.o):(.text+0x0): first defined here collect2: ld returned 1 exit status x86_64-pc-mingw32-dllwrap: x86_64-pc-mingw32-gcc exited with status 1 winegcc: x86_64-pc-mingw32-dllwrap failed make[1]: *** [msvcr80.dll] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces
by Dmitry Timoshkov 25 Mar '10

25 Mar '10

Eric Pouech <eric.pouech(a)orange.fr> wrote: > > Eric Pouech <eric.pouech(a)orange.fr> wrote: > > > > > Gdb uses decimal notation by default for integers, so do we. > > > > GDB can use anything their developers think appropriate, my patch > > to use hex was intended to match Wine's relay traces and win32 > > header constants. This patch will make finding matches impossible > > again. > bt /x will do what you want. How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all required information is already there in appropriate and ready to use/easy to understand format? -- Dmitry.

4 12

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages
by Alexandre Julliard 24 Mar '10

24 Mar '10

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > --- > server/async.c | 8 ++++++++ > server/file.h | 1 + > server/sock.c | 26 +++++++++++--------------- > 3 files changed, 20 insertions(+), 15 deletions(-) This doesn't look right. You shouldn't ignore POLLIN/POLLOUT, they shouldn't have been selected in the first place. If you do get them you have to do something with them and unselect them. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests
by Paul Vriens 24 Mar '10

24 Mar '10

On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote: > --- > dlls/ws2_32/tests/Makefile.in | 2 +- > dlls/ws2_32/tests/sock.c | 735 +++++++++++++++++++++++++++++++++++++---- > 2 files changed, 672 insertions(+), 65 deletions(-) > Hi Mike, I took the liberty of running your new tests on winetestbot. It shows failures on Win98: https://winetestbot.geldorp.nl/JobDetails.pl?Key=1164 (Win95 fails of course due to missing ws2_32.dll so these tests won't even run via winetest.exe). -- Cheers, Paul.

2 2

Re: [PATCH] d3dxof: Increase MAX_SUBOBJECTS and do the corresponding checks at the right place
by Henri Verbeet 24 Mar '10

24 Mar '10

I notice several of these limits have been increased in the past, sometimes multiple times. What exactly are these supposed to protect against?

2 1

Re: configure.ac: detect libusb-1.0
by Albert Lee 24 Mar '10

24 Mar '10

On Wed, 24 Mar 2010 16:15:59 +0200, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * configure.ac: detect libusb-1.0 > There are multiple libusb implementations (notably, Solaris libusb and FreeBSD libusb20) and it would be necessary to do an API test for those, rather than using pkgconfig. -Albert

3 3

d3dx9_36: Add stubbed interface for ID3DXEffect
by David Adam 24 Mar '10

24 Mar '10

Hello, the 2 lines + #include "d3dx9.h" + #include "d3dx9effect.h" in the d3dx9_36/effect.c file are useless, since in the d3dx9_private file, one calls d3dx9.h file which calls d3dx9effect.h A+ David

2 3

i7 920 not quite twice as fast as Q9300 at building wine
by Dan Kegel 24 Mar '10

24 Mar '10

Not as exciting an improvement as I'd hoped: 4 GB RAM Intel(R) Core(TM)2 Quad CPU Q9300 @ 2.50GHz make -j5 real 7m35.985s user 24m54.741s sys 3m15.628s 6 GB RAM model name : Intel(R) Core(TM) i7 CPU 920 @ 2.67GHz make -j9 real 4m39.577s user 30m43.651s sys 2m30.109s

2 3

Re: crypt32: Don't dereference a potentially NULL pointer without checking it (Coverity)
by Alexandre Julliard 24 Mar '10

24 Mar '10

Juan Lang <juan.lang(a)gmail.com> writes: > Fixes Coverity ids 1046 and 1047. Thanks to Paul Vriens for bringing > it to my attention. Setting sep to an empty string would probably make the whole thing a lot cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/8] msvcrt: Update msvcrt.spec (try3)
by Alexandre Julliard 24 Mar '10

24 Mar '10

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -826,3 +826,579 @@ > @ cdecl wctomb(ptr long) MSVCRT_wctomb > @ varargs wprintf(wstr) MSVCRT_wprintf > @ varargs wscanf(wstr) MSVCRT_wscanf > +@ stub ??0bad_cast@@AAE@PBQBD@Z > +@ stub ??0bad_cast@@QAE@PBD@Z > +@ stub ??0exception@@QAE@ABQBDH@Z The added functions should be properly sorted with the rest of the spec file, and they should be commented out. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add some multimedia defines not present in win9x.
by Dmitry Timoshkov 24 Mar '10

24 Mar '10

<Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > +#define MOD_WAVETABLE 6 /* hardware watetable internal synth */ A typo? -- Dmitry.

1 0

steam regressed?
by Dan Kegel 24 Mar '10

24 Mar '10

Hmm. I can't start steam anymore. This worked until quite recently...?

5 7

Re: [PATCH 2/2] ws2_32/tests: test a WSARecv error condition
by Paul Vriens 24 Mar '10

24 Mar '10

On 03/22/2010 07:56 PM, Mike Kaplinskiy wrote: > + > + bret = GetOverlappedResult((HANDLE)dest,&ov,&bytesReturned, FALSE); > + todo_wine ok(!bret&& GetLastError() == ERROR_NETNAME_DELETED, "Did not get disconnect event: %d, error %d\n", bret, GetLastError()); Hi Mike, This one fails on Win98 and WinMe with what appears just a different last error: http://test.winehq.org/data/tests/ws2_32:sock.html Could you have a look? Maybe it also makes sense to add a SetLastError(0xdeadbeef) before the actual call as we are testing the last error afterwards. That way we are sure that the last error is indeed set to the expected. -- Cheers, Paul.

2 1

Re: [PATCH 4/5] mmdevapi: Use OpenAL for finding devices
by Chris Robinson 23 Mar '10

23 Mar '10

FWIW, you can query ALC_DEFAULT_ALL_DEVICES_SPECIFIER (with ENUMERATE_ALL), ALC_DEFAULT_DEVICE_SPECIFIER (standard playback), and ALC_CAPTURE_DEVICE_SPECIFIER (record) to get the default device as seen by OpenAL, instead of taking the first as the default. Just make sure to query the default after the device list, since querying the device list can invoke a re-probing of available devices/backends.

1 0

Re: includes: Add private alext header for OpenAL
by Chris Robinson 23 Mar '10

23 Mar '10

It may be a good idea to remove the experimental extensions from the file: AL_EXT_buffer_sub_data AL_EXT_sample_buffer_object ALC_EXT_thread_local_context until they're finalized. I'm hoping ALC_EXT_thread_local_context will be done in time for OpenAL Soft 1.12, but there could still be changes to it (namely, changing a function name).

1 0

Re: [1/2] wdm.h: fix IoGetCurrentIrpStackLocation
by Alexandre Julliard 23 Mar '10

23 Mar '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -1021,7 +1021,7 @@ typedef enum _MM_SYSTEM_SIZE > > NTSTATUS WINAPI ObCloseHandle(IN HANDLE handle); > > -#define IoGetCurrentIrpStackLocation(_Irp) ((_Irp)->Tail.Overlay.CurrentStackLocation) > +#define IoGetCurrentIrpStackLocation(_Irp) ((_Irp)->Tail.Overlay.s.u2.CurrentStackLocation) This would have to depend on the NONAMELESSUNION etc defines. -- Alexandre Julliard julliard(a)winehq.org

1 0

msvcrt and co.
by André Hentschel 23 Mar '10

23 Mar '10

Hi Folks, We have actually some dlls like msvcr80 that forward to msvcrt or msvcr90. The question is, should we test these forwarding dlls for the case they behave different? If yes, how? We would have to cherrypick the tests from e.g. msvcrt which tests those functions... -- Best Regards, André Hentschel

1 0

Re: [2/2] dxdiagn: Successfully copy to destination variants with an invalid type in IDxDiagContainer::GetProp.
by Alexandre Julliard 23 Mar '10

23 Mar '10

Andrew Nguyen <arethusa26(a)gmail.com> writes: > @@ -221,9 +221,17 @@ static HRESULT WINAPI IDxDiagContainerImpl_GetProp(PDXDIAGCONTAINER iface, LPCWS > > p = This->properties; > while (NULL != p) { > - if (0 == lstrcmpW(p->vName, pwszPropName)) { > - VariantCopy(pvarProp, &p->v); > - return S_OK; > + if (0 == lstrcmpW(p->vName, pwszPropName)) { > + HRESULT hr = VariantClear(pvarProp); > + if (hr == DISP_E_ARRAYISLOCKED) > + { > + while (SafeArrayUnlock(V_ARRAY(pvarProp)) == S_OK); > + VariantClear(pvarProp); This looks suspicious. Do you have evidence that the array should be forcibly unlocked and destroyed? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 02/48] Added new icon build rule
by Alexandre Julliard 23 Mar '10

23 Mar '10

Joel Holdsworth <joel(a)airwebreathe.org.uk> writes: > @@ -188,6 +188,11 @@ filter: dummy > .man.in.man: > LC_ALL=C sed -e 's,@bindir\@,$(bindir),g' -e 's,@dlldir\@,$(dlldir),g' -e 's,@PACKAGE_STRING\@,@PACKAGE_STRING@,g' $< >$@ || ($(RM) $@ && false) > > +# Rules for icons > + > +ifdef SVG_SRCS > + > +# Depreciated icon build rule > .svg.ico: > $(RSVG) -w 16 -h 16 -f png $< $*-16.png > $(RSVG) -w 32 -h 32 -f png $< $*-32.png > @@ -195,6 +200,17 @@ filter: dummy > $(ICOTOOL) -c -o $@ $*-16.png $*-32.png $*-48.png > $(RM) $*-16.png $*-32.png $*-48.png > > +else > + > +resources/%-32.png: resources/%.svg > + $(RSVG) -f png $< $@ > + > +resources/%.ico : resources/%-*-4.png resources/%-*-8.png \ > + resources/%-16-32.png resources/%-32-32.png resources/%-48-32.png > + $(ICOTOOL) -c -o $@ $^ > + > +endif That's GNU make specific, you can't do that. Also please don't send such a huge patch series. The first step should be to get just one icon committed with the proper infrastructure. Then you can consider sending more of them, preferably one dll at a time. -- Alexandre Julliard julliard(a)winehq.org

3 10

re: dlls/msxml3: Using strlenW instead of SysStringLen to check node name length
by Dan Kegel 23 Mar '10

23 Mar '10

Hi Eric, welcome to Wine! http://msdn.microsoft.com/en-us/library/ms221240.aspx says the only time those two functions disagree on valid bstr's is if there are embedded nul chars, in which case SysStringLength probably returns a larger value. Are you quite, quite sure that your bstrs are valid? (In general, the best way to answer questions like that is to add a test case to your patch, and make sure it passes on Windows as well as Wine before submitting to wine-patches.) - Dan

3 3

Re: 1/2 wined3d: add helper function for retrieving front buffer coordinates
by Henri Verbeet 23 Mar '10

23 Mar '10

On 23 March 2010 14:14, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > + IWineD3DSwapChainImpl *swapchain = (IWineD3DSwapChainImpl *) This->container; That cast isn't safe unless you already know the surface is on a swapchain.

1 0

Re: [PATCH] user32: end scrollbar tracking if the mouse capture is lost
by Dmitry Timoshkov 23 Mar '10

23 Mar '10

Sébastien Ramage <sebastien.ramage(a)gmail.com> wrote: > - } while (msg.message != WM_LBUTTONUP); > + } while (msg.message != WM_LBUTTONUP&& GetCapture() == hwnd); Please fix the spacing above. > + SendMessage( hScroll, WM_LBUTTONDOWN, 0, 0x10001); 0 for lParam would work just fine. A magic value needs either explanation or MAKELPARAM(1, 1) if you really need coordinates. -- Dmitry.

1 0

Re: [PATCH] user32: end scrollbar tracking if the mouse capture is lost
by Paul Vriens 23 Mar '10

23 Mar '10

On 03/23/2010 02:08 PM, Sébastien Ramage wrote: > Fixes bug #16595 > --- > dlls/user32/scroll.c | 5 +---- > dlls/user32/tests/scroll.c | 17 ++++++++++++++++- > 2 files changed, 17 insertions(+), 5 deletions(-) Hi Sébastien Can comment too much on the patch but this patch doesn't apply cleanly to current Git. Please make sure that all patches are based on top of current. > > diff --git a/dlls/user32/scroll.c b/dlls/user32/scroll.c > index 93f85f2..91adb74 100644 > --- a/dlls/user32/scroll.c > +++ b/dlls/user32/scroll.c > @@ -1105,11 +1105,8 @@ void SCROLL_TrackScrollBar( HWND hwnd, INT > scrollbar, POINT pt ) > DispatchMessageW(&msg ); > } > if (!IsWindow( hwnd )) > - { > ReleaseCapture(); > - break; > - } > - } while (msg.message != WM_LBUTTONUP); > + } while (msg.message != WM_LBUTTONUP&& GetCapture() == hwnd); > } While you're at it please add a space before the '&&'. -- Cheers, Paul.

1 0

Re: [8/10] shell32: Implement some IShellFolderView methods over IFolderView
by Paul Vriens 23 Mar '10

23 Mar '10

On 03/22/2010 01:01 PM, Nikolay Sivov wrote: > Implement some IShellFolderView methods over IFolderView > Hi Nikolay, + /* ::MoveIcons */ + hr = IShellFolderView_MoveIcons(folderview, NULL); + ok(hr == E_NOTIMPL, "got (0x%08x)\n", hr); + This one makes Win98 and win95 (both with shell32.dll version 4.72.x) crash. The same is true for the one from patch "Add IShellFolderView::SetRedraw implementation": + /* ::SetRedraw without list created */ + hr = IShellFolderView_SetRedraw(folderview, TRUE); + ok(hr == S_OK, "got (0x%08x)\n", hr); + (Changing TRUE to FALSE doesn't make this test crash!). There is nothing in those tests yet that indicates version 5.0 (if that's what makes these tests succeed) or higher. It's easy enough to skip on Win9x but that also means no tests or WinMe or don't we care in this case? -- Cheers, Paul.

2 4

Re: 1/4 wined3d: pass surface to blit_shader->set_shader
by Alexandre Julliard 23 Mar '10

23 Mar '10

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > In a future patch I will move 8-bit palette handling to the shader and > for that I need to retrieve the palette from the surface. This patch > prepares for that and it simplifies the interface to the shader. It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:7725: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:9843: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9847: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9843: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9847: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY visual.c:9843: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9847: Test failed: Input 0x00ff0000: Got color 0x00ffffff for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9843: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_UYVY etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 4/4 wined3d: move color keyed blitting in its own function [try 2]
by Henri Verbeet 23 Mar '10

23 Mar '10

On 23 March 2010 12:08, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > This version takes into account the 'This -> Dest' change as suggested by Henri. > But not the more general point.

1 0

Re: [shell32/tests] Fix a crash on shell32 < 5.0
by Paul Vriens 23 Mar '10

23 Mar '10

On 03/23/2010 11:29 AM, Paul Vriens wrote: > Hi, > > This fixes a crash. We only run this test now when SHGetFolderLocation > (introduces in 5.0) is available. There is not much else we can go on to > deduce whether we are 4.x or lower without skipping also on WinMe and > others. > > Changelog > Fix a crash on shell32 < 5.0 > Forgot to mention, this applies on top of Nikolay's patches. -- Cheers, Paul.

1 0

Fastcall calling convention
by Damjan Jovanovic 23 Mar '10

23 Mar '10

Hi Wine doesn't seem to support the fastcall calling convention: include/winternl.h: /* These are implemented as __fastcall, so we can't let Winelib apps link with them */ dlls/hal/hal.c: #ifdef __i386__ #define DEFINE_FASTCALL1_ENTRYPOINT( name ) \ __ASM_STDCALL_FUNC( name, 4, \ "popl %eax\n\t" \ "pushl %ecx\n\t" \ "pushl %eax\n\t" \ "jmp " __ASM_NAME("__regs_") #name __ASM_STDCALL(4)) GCC seems to support fastcall from version 3.4: http://www.ohse.de/uwe/articles/gcc-attributes.html Should we support it? Its absence makes kernel driver code a lot uglier (eg. irp->Tail.Overlay.s.u2.CurrentStackLocation instead of IoGetCurrentIrpStackLocation()). We also can't declare fastcall functions in header files, so some functions that are actually implemented are missing from header files and thus unusable from inside Wine. Thank you Damjan Jovanovic

2 2

Re: [PATCH 2/7] msvcr90: Added strnlen implementation (try2)
by Alexandre Julliard 23 Mar '10

23 Mar '10

Piotr Caban <piotr(a)codeweavers.com> writes: > diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec > index ed283d9..cc900ca 100644 > --- a/dlls/msvcr80/msvcr80.spec > +++ b/dlls/msvcr80/msvcr80.spec > @@ -1389,7 +1389,7 @@ > @ cdecl strncmp(str str long) msvcrt.strncmp > @ cdecl strncpy(ptr str long) msvcrt.strncpy > @ stub strncpy_s > -@ stub strnlen > +@ cdecl strnlen(str long) msvcr90.strnlen > @ cdecl strpbrk(str str) msvcrt.strpbrk > @ cdecl strrchr(str long) msvcrt.strrchr > @ cdecl strspn(str str) msvcrt.strspn This should be added to msvcrt and forwarded to it. Same for the other functions like strtoi64 that exist in recent msvcrt. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: rpcrt4: Added stub function CreateStubFromTypeInfo
by Nikolay Sivov 23 Mar '10

23 Mar '10

On 3/22/2010 12:32, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > rpcrt4: Added stub function CreateStubFromTypeInfo > > + typedef INT (WINAPI *MessageBoxA)(HWND,LPCSTR,LPCSTR,UINT); > + HMODULE hUser32 = LoadLibraryA("user32"); > + MessageBoxA pMessageBoxA = (void *)GetProcAddress(hUser32, "MessageBoxA"); > + > + FIXME("%p %s %p %p\n", pTypeInfo, debugstr_guid(riid), pUnkServer, ppStub); > + if (pMessageBoxA) > + { > + pMessageBoxA(NULL, > + "The native implementation of OLEAUT32.DLL cannot be used " > + "with Wine's RPCRT4.DLL. Remove OLEAUT32.DLL and try again.\n", > + "Wine: Unimplemented CreateProxyFromTypeInfo", > + 0x10); > + ExitProcess(1); > + } > + return E_NOTIMPL; > Displaying messagebox is a bit questionable, ExitProcess is even worse. If you mean here that native oleaut32 uses this call, a general FIXME is enough. If you really don't want to survive from such call you don't need this stub at all.

2 1

Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile [try 2]
by Ilya Basin 23 Mar '10

23 Mar '10

Hi! Sorry for being annoying, will you accept my patch? http://www.winehq.org/pipermail/wine-patches/2010-March/086009.html --

2 2

Re: [PATCH 5/6] msvcr90: Implement _encode_pointer and _decode_pointer
by Alexandre Julliard 23 Mar '10

23 Mar '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > --- > dlls/msvcr90/msvcr90.c | 21 +++++++++++++++++++++ > dlls/msvcr90/msvcr90.spec | 4 ++-- > 2 files changed, 23 insertions(+), 2 deletions(-) This doesn't build on 64-bit Mingw because it comes with its own version of these functions. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: 4/4 wined3d: move color keyed blitting in its own function
by Henri Verbeet 22 Mar '10

22 Mar '10

On 22 March 2010 22:36, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > +static HRESULT surface_blt_color_keyed_surface_to_drawable(IWineD3DSurfaceImpl *This, const RECT *DestRect, IWineD3DSurfaceImpl *Src, const RECT *SrcRect, DWORD Flags, WINEDDCOLORKEY SrcColorkey) Calling the destination surface "This" isn't a sane naming convention. When you create a "new" function, try to make it at least somewhat sane and consistent, rather than just cutting and pasting something together.

1 0

[PATCH] dlls/msxml3: Using strlenW instead of SysStringLen to check node name length
by Eric Lanz 22 Mar '10

22 Mar '10

Hello, Decided to keep it simple for my first patch. SysStringLen was returning 0 for bstrs from our updater application which caused the domdoc_createNode function to exit early even though the bstr actually contained a valid name. It seems that other functions in this file use strlenW for this purpose which seems to always return the correct length. Eric

2 2

Re : shell32: Add IShellFolderView:: GetSelectedObjects implementation for IShellView.
by Juan Lang 22 Mar '10

22 Mar '10

Hi Nikolay, I know this one's already been comitted, but I have a small complaint about a comment: + /* it's documented that caller shouldn't PIDLs, only array itself */ I think you're missing a verb there. A caller shouldn't do what to PIDLs, exactly? Perhaps it should be obvious to me, but I couldn't guess by looking at it. Thanks, --Juan

2 1

Re: [PATCH 1/7] msvcr90: Added _encode_pointer and _decode_pointer tests
by Paul Vriens 22 Mar '10

22 Mar '10

On 03/22/2010 05:01 PM, Piotr Caban wrote: > + if(!p_encode_pointer || !p_decode_pointer) { > + skip("_encode_pointer or _decode_pointer not found\n"); > + return; > + } win_skip() is more appropriate as these are implemented on Wine. -- Cheers, Paul.

1 0

Warnings on ignored returned values
by Octavian Voicu 22 Mar '10

22 Mar '10

Hello, I'm trying to compile wine with --enable-maintainer-mode and I get lots of errors like `ignoring return value of ‘xxx’, declared with attribute warn_unused_result'. I would like to submit a few patches to fix them. I noticed there's a page on the wiki for this: http://wiki.winehq.org/IgnoredReturnValues On the other hand, there are no indications on the policy of handling them. Sometimes we just don't care about the return value, but I haven't found a way to tell this to the compiler other than actually using the return value. In other cases, errors might be relevant. For example, for the code: if (newdir) chdir(newdir); would the following be an acceptable fix? if (newdir) if (chdir(newdir) == -1) /* ignore error */ ; Should I use WARNs to print the error, in cases where it might be relevant? Thanks, Octavian

4 5

Re: [PATCH 01/11] ws2_32: use ntstatus in overlapped functions (try 3)
by Alexandre Julliard 22 Mar '10

22 Mar '10

Mike Kaplinskiy <mike.kaplinskiy(a)gmail.com> writes: > Make get_sock_events return error codes in unix format. Also some > style fixes. Sorry for the fuss over this :) The server should not be returning errno values directly. It should return NT status codes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/8] [Include]: added a wine/dwarf.h to share dwarf2 debug information data where needed
by Alexandre Julliard 22 Mar '10

22 Mar '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > A+ > --- > > dlls/dbghelp/dwarf.c | 2 > dlls/dbghelp/dwarf.h | 420 ---------------------------------------- > dlls/ntdll/signal_x86_64.c | 207 -------------------- > include/wine/dwarf.h | 465 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 467 insertions(+), 627 deletions(-) > delete mode 100644 dlls/dbghelp/dwarf.h > create mode 100644 include/wine/dwarf.h I don't think we need a Wine global header for this. It's OK to keep it in dbghelp and copy only the few necessary defines in ntdll. That's even more true for the unwind info. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: makefiles: Use the standard C_SRCS variable as the list of test files
by Ilya Basin 22 Mar '10

22 Mar '10

Looks like after this commit: http://source.winehq.org/git/wine.git/?a=commit;h=6164ce2d820546ae5b26eb504… the command ./tools/winapi/msvcmaker --no-wine silently fails: only 'winetest.dsp' created

1 0

Re: shell32: Add IPersistFile::GetCurFile implementation for IShellLink
by Paul Vriens 21 Mar '10

21 Mar '10

On 03/18/2010 10:55 PM, Nikolay Sivov wrote: > Fixes http://bugs.winehq.org/show_bug.cgi?id=19627 from 1.2 list. > Hi Nikolay, This introduces some test failures on Win9x (not WinMe) and NT4 in the shlexec tests. Could you agree with the attached patch? -- Cheers, Paul.

2 1

Re: winegcc: Link with msvcrt on windows because of __wargv
by James McKenzie 21 Mar '10

21 Mar '10

Alexandre Goujon wrote: > --- > tools/winegcc/winegcc.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index c2e7876..a929214 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -555,6 +555,10 @@ static const char *mingw_unicode_hack( struct options *opts ) > { > char *main_stub = get_temp_file( opts->output_name, ".c" ); > > + /* we need to link with msvcrt because of __wargv */ > + if (!opts->use_msvcrt) > + opts->use_msvcrt = 1; > + > create_file( main_stub, 0644, > "#include <stdlib.h>\n" > "extern int wmain(int,wchar_t**);\n" > Please use [try 2] for any second send. Keeps things in order and lets others know that you have responded to errors. Also, put comments in the same message as the patch they apply to at the top of the message. Thank you. James McKenzie

2 2

Wanted: Summer of Code Mentors
by Maarten Lankhorst 20 Mar '10

20 Mar '10

Hi all, Any contributing wine members wishing to mentor for summer of code, or help out with ranking proposals, please sign up as mentor for wine at http://socghop.appspot.com/gsoc Of course if you want to apply as student, you can't be a mentor. More feedback on the proposals is appreciated as well. :) Cheers, Maarten

2 1

Re: FIXME: shader trailing '\n's.
by Henri Verbeet 20 Mar '10

20 Mar '10

On 20 March 2010 15:27, Francois Gouget <fgouget(a)free.fr> wrote: > On Sat, 20 Mar 2010, Francois Gouget wrote: > >> --- >> dlls/wined3d/shader.c | 132 ++++++++++++++++++++++++------------------------ >> 1 files changed, 66 insertions(+), 66 deletions(-) > > Argh! > > Ignore this one. I need to check it out and did not mean to send it > (hence the FIXME). > I didn't check all of them, but the majority of those are intentional. There are probably nicer ways to trace the D3D shader assembly though.

1 0

Re: oleaut32: Use FADF_HAVEVARTYPE before FADF_RECORD for safearrays
by Alexandre Julliard 20 Mar '10

20 Mar '10

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Both FADF_HAVEVARTYPE and FADF_RECORD both store information at > negative 4 in the safearray, and ODBC(native MDAC) can attempt to copy > an array with both of these flags set. A test case would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcr90/tests: Add tests for _initterm_e [try 2]
by Piotr Caban 20 Mar '10

20 Mar '10

Hi, You forgot to attach changes to configure.ac. Regards, Piotr

2 1

winetricks bug?
by Igor Zakharoff 20 Mar '10

20 Mar '10

Hi. I am using WINE 1.1.40 on Arch Linux. When I run winetricks (version 20100317) and try to install anything from the list I get the error ------------------------------------------------------ winepath -u C:\Program Files "" returned empty string ------------------------------------------------------ $ ls -l /home/igor/.wine/drive_c/ итого 16 drwxr-xr-x 4 igor users 4096 Мар 19 23:06 Program Files drwxr-xr-x 4 igor users 4096 Мар 19 23:06 users drwxr-xr-x 10 igor users 4096 Мар 19 23:06 windows drwxr-xr-x 2 igor users 4096 Мар 19 23:06 winetrickstmp I've tried removing ~/.wine directory but it doesn't help.

2 1

Re: Updated game checklist - columns now sortable
by Dan Kegel 20 Mar '10

20 Mar '10

On Thu, Mar 18, 2010 at 10:31 PM, Edward Savage <epssyis(a)gmail.com> wrote: > I would think a logical extension to this sort of work would be a > triage list of important bugs and regressions to be dealt with in > quick order. Well... that's kind of what bugzilla and the appdb are for. > I'm raising this as it seems very few gamers who use wine seem to > report bugs or do regression tests. At most they seem to report that > there is a problem on the forums or on the app page comments and leave > it at that. Yeah, historically, a few people (me included) have spent time watching the forums for that kind of report, and turned them into real bug reports. > If there was a centralised method of telling other gamers who are > prepared to do tests and reports that there is a specific problem with > xyz games it may improve the quality of information bug fixers have to > work with and get problems sorted out in a timely fashion. I suppose a way to make it really easy to test one's favorite set of games on the latest wine (as well as on any earlier release), and just click a big red 'Regression' button the moment one found one, might help. > Games are probably the biggest single application instance usage of > wine so having a specific case for this genre of application make > sense to me. Agreed. > As another suggestion I'd be prepared to write a WWN style monthly > report on the state of games running in wine. Including which ones no > longer work, what new ones work, and what major efforts need to be > undertaken for new games to work. I did a journalism elective last > semester so it probably wouldn't suck as bad as my last attempt at > writing a WWN. I would assume it would be totally independent of WWN > releases. Nah, just add it in to WWN, no reason to do anything separate. Start small! Just write a little section in http://wiki.winehq.org/RecentNewsQueue Heck, it is about time for another WWN, isn't it? - Dan [resending to list with permission]

1 0

Re: [PATCH 4/7] [Include]: created a wine only unwind.h include file for CPU specific unwind information
by Charles Davis 19 Mar '10

19 Mar '10

On 3/19/10 3:02 PM, Eric Pouech wrote: > > (and maps the definition to what MSDN states as field names) > > A+ > --- > > dlls/ntdll/signal_x86_64.c | 144 ++++++++++++++++++-------------------------- > 1 files changed, 58 insertions(+), 86 deletions(-) You forgot unwind.h. Chip

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel