- wine-devel - winehq.org

Re: msxml3: Accept IObjectSafety for query from IXMLDOMDocument, fix its implementation.
by Paul Vriens 19 Feb '10

19 Feb '10

On 02/19/2010 11:48 AM, Nikolay Sivov wrote: > Accept IObjectSafety for query from IXMLDOMDocument, fix its implementation > Hi Nikolay, This one introduces some test failures: http://test.winehq.org/data/tests/msxml3:domdoc.html Could you have a look? -- Cheers, Paul.

2 1

Re: [PATCH] shell32: Allow copy operation to overwrite an existing write protected file + tests
by Nikolay Sivov 19 Feb '10

19 Feb '10

On 2/19/2010 17:34, Christian Costa wrote: > --- > > dlls/shell32/shlfileop.c | 10 +++++++++- > dlls/shell32/tests/shlfileop.c | 20 ++++++++++++++++++++ > 2 files changed, 29 insertions(+), 1 deletions(-) > Correct me if I'm wrong, but isn't SetFileAttributes dependent on user security permissions? I mean will it work as expected if this call fails for that reason?

2 1

Re: [PATCH 3/3] kernel32/tests: Test for 'all processors' now valid (try 2).
by Charles Davis 19 Feb '10

19 Feb '10

Erich Hoover wrote: > Real Name: > Erich Hoover > Description: > Patch 2 added support for the "all processors" flag, so this is > no-longer a todo. This version is against the revised patch 1, please > note that patch 2 is unchanged. > ChangeLog: > kernel32/tests: Test for 'all processors' now valid. Patches 2 and 3 should be merged. If patch 2 is applied without patch 3, then we'll get "test succeeded inside todo block" failures. Chip

3 2

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer (try 2).
by Henri Verbeet 19 Feb '10

19 Feb '10

On 19 February 2010 05:22, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > The attached patch adds a test for > SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and > newer. This version uses broken() rather than specifically testing > versions. Note that this "all processors" flag is not documented, but > was discovered tracking down another issue. Please see the wine-devel > thread for more information: > http://www.winehq.org/pipermail/wine-devel/2010-February/081879.html > ChangeLog: > kernel32/tests: Add test for 'all processors' flag on Vista and newer. > Shouldn't this need tests for NtSetInformationThread() and NtQueryInformationThread() as well?

1 0

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.
by Andrew Nguyen 19 Feb '10

19 Feb '10

On Thu, Feb 18, 2010 at 8:51 PM, Erich Hoover <ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > The attached patch adds a test for > SetThreadAffinityMask(thread,-1), which succeeds on Windows Vista and > newer. This "all processors" flag is not documented, but was > discovered tracking down another issue. Please see the wine-devel > thread for more information: > http://www.winehq.org/pipermail/wine-devel/2010-February/081879.html > ChangeLog: > kernel32/tests: Add test for 'all processors' flag on Vista and newer. > > > > The test shouldn't query the Windows version explicitly. Instead, the older return value on pre-Vista version should be denoted by the broken() macro.

3 5

Multi-processor difference between Windows versions
by Erich Hoover 18 Feb '10

18 Feb '10

In exploring a bug in a game we* ran across an interesting difference between how Windows versions handle a multiple-processor request. In essence, this supposedly invalid request will succeed on newer Windows versions **: SetThreadAffinityMask(curthread,(-1)); So, the question I have is whether Wine should support this behavior as a matter of course or if it should only support this request when the emulated version is set to Vista or greater. It seems to me like this should be supported as a matter of course, since anyone who uses this "feature" is unlikely to have properly tested it on multiple versions of Windows. However, I'm unfamiliar with the policy on these version-difference matters and figured I should ask before putting something together. Erich Hoover ehoover(a)mines.edu * http://bugs.winehq.org/show_bug.cgi?id=21165 ** https://winetestbot.geldorp.nl/JobDetails.pl?Key=747

2 1

Intercepting GDI calls
by Jui-Hao Chiang 18 Feb '10

18 Feb '10

Hi, all: I am currently starting a project which tries to run a window application on one (source) machine, and display on another (destination) machine. Of course, the VNC or X11 forwarding technique can achieve the same goal, but I am trying to reduce the bandwidth by "not" transferring the video frame buffer but transfer the GDI function calls instead. The way I can see is try to intercept all the calls inside gdi32.dll, and forward the calls and parameters to remote machine by using some RPC library, and then replay the GDI calls on the destination machine. However, I have two doubts: (1) It seems like the user32.dll is actually handling the window, menu, and cursor. Does the drawing of menu and cursor depends on user-level gdi32.dll? or other kernel-level dlls? (2) It seems that there is no corresponding win32k.sys implementation in wine, and the user-level GDI calls seems to be forwarded to winex11.drv, right? I wander is there any good way or a place inside the source to do this kind of interception? Appreciate any suggestions, Jui-Hao

8 11

Re: advapi32/tests: Avoid crashing if ReadEventLogA fails.
by Paul Vriens 18 Feb '10

18 Feb '10

Hi Alexandre, + if (ReadEventLogA(handle, EVENTLOG_SEQUENTIAL_READ | EVENTLOG_FORWARDS_READ, + 0, buf, sizeof(EVENTLOGRECORD), &read, &needed)) + { I don't think this is correct. The first call will always fail as the buffer is not big enough. This now introduces a test failure on Vista without a servicepack (what this piece of code was meant to check). I guess a 'better' fix would have been to set needed to 0 in our implementation until ReadEventLog is fully implemented. -- Cheers, Paul.

1 0

Is this a bug or feature incompleteness
by MD.IMAM HOSSAIN 18 Feb '10

18 Feb '10

The bug is from DirectX 8.1 SDK, C++ samples, Direct3D samples, SkinnedMesh. Please, see the attached file for clear idea. Tested with latest wine 1.1.38 Best regards, MD. IMAM HOSSAIN

2 1

Re: [2/2] msi: Implement MSIRUNMODE_MAINTENANCE and MSIRUNMODE_REBOOTATEND for MsiGetMode.
by James Hawkins 18 Feb '10

18 Feb '10

On Thu, Feb 18, 2010 at 3:47 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > --- > dlls/msi/install.c | 12 +++++++++++- > dlls/msi/tests/automation.c | 4 ++-- > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/dlls/msi/install.c b/dlls/msi/install.c > index 7a71867..6e19863 100644 > --- a/dlls/msi/install.c > +++ b/dlls/msi/install.c > @@ -661,6 +661,8 @@ BOOL WINAPI MsiGetMode(MSIHANDLE hInstall, MSIRUNMODE iRunMode) > MSIPACKAGE *package; > BOOL r = FALSE; > > + TRACE("%d %d\n", hInstall, iRunMode); > + > package = msihandle2msiinfo(hInstall, MSIHANDLETYPE_PACKAGE); > if (!package) > { > @@ -706,8 +708,16 @@ BOOL WINAPI MsiGetMode(MSIHANDLE hInstall, MSIRUNMODE iRunMode) > r = package->commit_action_running; > break; > > + case MSIRUNMODE_MAINTENANCE: > + r = msi_get_property_int( package, szInstalled, 0 ) != 0; > + break; > + > + case MSIRUNMODE_REBOOTATEND: > + r = package->need_reboot; > + break; > + > default: > - FIXME("%d %d\n", hInstall, iRunMode); > + FIXME("unimplemented run mode\n"); > r = TRUE; > } > It's nice to see which run mode we're not handling by quickly looking at the FIXME. Any reason you removed this? Keep in mind most general user logs won't have +msi logging, if any. -- James Hawkins

2 1

Re: comctl32: listview should accept both unicode and ansi notifications.
by Nikolay Sivov 18 Feb '10

18 Feb '10

On 2/18/2010 15:46, Dmitry Timoshkov wrote: > Listview receives notifications not only from built-in header control, > but also from custom or subclassed application controls, there is no > need to assert(0) on application input, printing a FIXME is the maximum > we can do on an unknown input. > > The question actually is how does it react on it. Your test only check for return value and most likely doesn't use this conversion path (I'm not sure). The this is so strict probably was that we set notification format when header query for it, and we expect proper codes after that. Anyway change looks a bit confusing cause logically we shouldn't convert to ansi if we have ansi already. > Added test case passes under XP, but listview in Wine intentionally > crashes itself on an absolutely valid input. > Yes, FIXME is ok here.

1 0

Re: [cmd] Don't change case of the batch filename
by Alexandre Julliard 18 Feb '10

18 Feb '10

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > diff --git a/programs/cmd/batch.c b/programs/cmd/batch.c > index 28744d4..6cb732c 100644 > --- a/programs/cmd/batch.c > +++ b/programs/cmd/batch.c > @@ -91,7 +91,7 @@ void WCMD_batch (WCHAR *file, WCHAR *command, int called, WCHAR *startLabel, HAN > prev_context = context; > context = LocalAlloc (LMEM_FIXED, sizeof (BATCH_CONTEXT)); > context -> h = h; > - context->batchfileW = WCMD_strdupW(string); > + context->batchfileW = WCMD_strdupW(file); That whole function is broken, it should not be lowering the string in the first place. It does this in order to use strstrW, but that's not the right way to check the extension anyway. In any case the test environment needs to be comparing paths in a case-insensitive way, it doesn't make sense to require exact case. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [cmd] Don't change case of the batch filename
by Paul Vriens 18 Feb '10

18 Feb '10

On 02/18/2010 02:35 PM, Paul Vriens wrote: > Hi, > > This should fix the test failures for Wine (on test.winehq.org). > > Not sure how to write a (simple) test for this. The test is there in > fact but it will only show up on test.winehq.org or when doing a "make > batch.ok" from a directory with an uppercase letter in the path. > > Maybe we should create an uppercase directory in %TEMP% and run our > tests from there instead of the current directory? > > Changelog > Don't change case of the batch filename > Ignore this one. Needs more thought. -- Cheers, Paul.

1 0

Re: [PATCH 5/5] cmd: rename reference file from .out to .exp to avoid clash with gnu make builtin rule
by Paul Vriens 18 Feb '10

18 Feb '10

On 02/16/2010 10:08 PM, Dan Kegel wrote: > Without this, editing the .cmd file and then running make would > cause make to overwrite the .out file with a copy of the .cmd file! > Evidently '.out' is not appropriate as a suffix for a nongenerated > source file. The arbitrarily-chosen .exp suffix works better > (if anyone asks, it stands for 'expected output'). > --- > programs/cmd/tests/batch.c | 4 ++-- > programs/cmd/tests/rsrc.rc | 4 ++-- > programs/cmd/tests/test_builtins.cmd.exp | 18 ++++++++++++++++++ > programs/cmd/tests/test_builtins.cmd.out | 18 ------------------ > 4 files changed, 22 insertions(+), 22 deletions(-) > create mode 100644 programs/cmd/tests/test_builtins.cmd.exp > delete mode 100644 programs/cmd/tests/test_builtins.cmd.out > > Hi Dan, These last changes introduce several test failures on some W2K, XP and W2K3 boxes but on all Wine ones: http://test.winehq.org/data/tests/cmd.exe:batch.html One thing I've noticed is that the succeeding ones run 12 tests whereas the failing ones run 14 tests. Could you have a look? -- Cheers, Paul.

1 3

Re: [PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled (try 2)
by Henri Verbeet 18 Feb '10

18 Feb '10

On 17 February 2010 17:54, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + if (TRACE_ON(d3d_shader)) > + { > + int size = strlen(comment) + 1; > + char* str = (char*)HeapAlloc(GetProcessHeap(), 0, size); > + int i = 0; > + char* line = str; > + memcpy(str, comment, size); > + DPRINTF("//"); > + while (i < size) > + { > + /* Find end of line */ > + while ((str[i] != 0) && (str[i] != 0x0a)) > + i++; > + /* Terminate line and remove preceding 0x0d if any */ > + if (i && (str[i-1] == 0x0d)) > + str[i-1] = 0; > + else > + str[i] = 0; > + /* Display line and prepare next line */ > + DPRINTF("%s\n", debugstr_an(line, strlen(line))); > + i++; > + line = str + i; > + } > + } This code has several obvious issues.

2 1

Re: tools/wine.inf: Add a symlink for WindowsNT.CurrentVersion.Print.Printers
by Alexandre Julliard 17 Feb '10

17 Feb '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -905,6 +905,7 @@ HKLM,%CurrentVersionNT%\Ports,"COM1:",2,"9600,n,8,1" > HKLM,%CurrentVersionNT%\Ports,"COM2:",2,"9600,n,8,1" > HKLM,%CurrentVersionNT%\Ports,"COM3:",2,"9600,n,8,1" > HKLM,%CurrentVersionNT%\Ports,"COM4:",2,"9600,n,8,1" > +HKLM,%CurrentVersionNT%\Print\Printers,"SymbolicLinkValue",0x60000,"\Registry\Machine\%Control%\Print\Printers" It looks like it should be the other way around. -- Alexandre Julliard julliard(a)winehq.org

2 2

re: Status of Patchwatcher
by Dan Kegel 17 Feb '10

17 Feb '10

Seth Shelnutt wrote: > I am wondering what that status of patchwatcher is? It's waiting around for somebody to have time to start it up again. It's ugly code, written in shell and perl, which scares most people off. One has to wonder whether it shouldn't be done over again using buildbot, just to avoid scaring people. But it could live on in its present form given time and attention. Another problem is that the code for watching for patch series is fragile. We might conceivably move to driving it from a web submission form like WineTestBot uses, that would solve that. (I've been focusing my precious Wine time on the daily valgrind runs. It would be cool to run those tests on Patchwatcher; that was the whole goal of patchwatcher, actually. I think to do it fast enough we'd have to take a shortcut, like only valgrind the tests most obviously related to the change.) > I saw the ideals for converting UnitTestSuit and wpkg scripts to Appinstall. I > definitely think this is a good idea and needed; however I was thinking that > linking patchwatcher and appinstall testing would be even more beneficial. You're referring to http://wiki.winehq.org/SummerOfCode#head-6e93309cf25ab1bb55e35698562cac148d… and http://wiki.winehq.org/UnitTestSuites A daily run of appinstall is probably sufficient. Austin does that already. The main downside is that the results aren't tied in to test.winehq.org. It'd be really great to invoke lots of wpkg installs from inside Appinstall, and file bugs for whatever that turns up. (And fix them, maybe.) UnitTestSuites is a bit more programmer-oriented. I'd recommend that if you're interested in becoming a developer. Grinding through and automating builds for a few open source apps on wine would probably teach you a lot. - Dan

4 3

compiling for 64bit: types and format strings
by Joerg-Cyril.Hoehle＠t-systems.com 17 Feb '10

17 Feb '10

Hi, While I have no 64bit system, I recently submitted a compilation job to WTB and saw dozens of warnings unknown to me so far, mostly about printf format strings. The reason for the warnings is that WTB compiles in 64 bit mode, while I only know 32bit systems. Is there anything us 32bit users can do to prevent such warnings or shall we patiently wait until AJ checks in 64bit fixes? (BTW, thank you for the recent winmm one). Or compile every patch on WTB first? More specifically, regarding format strings, I'm unsure whether it's actually possible to find %d/%ld formats that work on both systems for all types one comes across (UINT, MMRESULT etc.) What's the receipe? Thank you, Jörg Höhle

3 2

Re: [PATCH] wined3d: Split comments in separate line to avoid buffer overflow when traces are enabled
by Henri Verbeet 17 Feb '10

17 Feb '10

On 17 February 2010 11:47, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > It should use debugstr_an() in the first place. You could have a go at splitting it into separate lines if needed after that, but I can't think of a whole lot of cases where the comments are really useful.

3 3

Re: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 2]
by Ilya Basin 17 Feb '10

17 Feb '10

Hi! Please comment on "try 2" of the patch. Will you accept it? IB> Hi! This should expose this bug: IB> http://bugs.winehq.org/show_bug.cgi?id=19385 ( the 'wine start' IB> launcher does not open MS Office documents that have spaces in their IB> path ). Although the title is misleading, many other tickets are IB> marked as duplicates of it. IB> It's not about spaces. It's about sometimes unneeded parsing of IB> SHELLEXECUTEINFO.lpFile, trying to extract arguments from it. Why? IB> Or maybe some other part of wine relies on this behavior? IB> Succeeds on 98 se, 2k & xp. IB> 4 tests fail on wine IB> --- IB> dlls/shell32/tests/shlexec.c | 87 ++++++++++++++++++++++++++++++++++++++++++ IB> 1 files changed, 87 insertions(+), 0 deletions(-) IB> diff --git a/dlls/shell32/tests/shlexec.c b/dlls/shell32/tests/shlexec.c IB> index c673f0a..d575d22 100644 IB> --- a/dlls/shell32/tests/shlexec.c IB> +++ b/dlls/shell32/tests/shlexec.c IB> @@ -797,6 +797,10 @@ static const char* testfiles[]= IB> "%s\\test file.sde", IB> "%s\\test file.exe", IB> "%s\\test2.exe", IB> + "%s\\simple.shlexec", IB> + "%s\\drawback_file.noassoc", IB> + "%s\\drawback_file.noassoc foo.shlexec", IB> + "%s\\drawback_nonexist.noassoc foo.shlexec", IB> NULL IB> }; IB> IB> @@ -852,6 +856,88 @@ static filename_tests_t noquotes_tests[]= IB> {NULL, NULL, 0} IB> }; IB> IB> +static void test_lpFile_parsed(void) IB> +{ IB> + /* basename tmpdir */ IB> + const char* shorttmpdir; IB> + IB> + const char *testfile; IB> + char fileA[MAX_PATH]; IB> + IB> + int rc; IB> + int expected; IB> + IB> + HMODULE hkernel32 = GetModuleHandle("kernel32"); IB> + BOOL isreallyXP2k3plus = NULL != GetProcAddress(hkernel32, "AttachConsole"); IB> + IB> + GetTempPathA(sizeof(fileA), fileA); IB> + shorttmpdir = tmpdir + strlen(fileA); IB> + IB> + /* ensure tmpdir is in %TEMP%: GetTempPath() can succeed even if TEMP is undefined */ IB> + SetEnvironmentVariableA("TEMP", fileA); IB> + IB> + #define TEST_LPFILE_PARSED_OK_() (rc==expected || rc>32 && expected>32) IB> + #define TEST_LPFILE_PARSED_OK() ok(TEST_LPFILE_PARSED_OK_(), "expected %s (%d), got %s (%d), lpFile: %s \n", expected==33 ? "success" : "failure", expected, rc > 32 ? "success" : "failure", rc, fileA) IB> + IB> + /* existing "drawback_file.noassoc" prevents finding "drawback_file.noassoc foo.shlexec" on wine */ IB> + testfile = "%s\\drawback_file.noassoc foo.shlexec"; IB> + expected = 33; sprintf(fileA, testfile, tmpdir); IB> + rc=shell_execute(NULL, fileA, NULL, NULL); IB> + todo_wine { TEST_LPFILE_PARSED_OK(); } IB> + IB> + /* if quoted, existing "drawback_file.noassoc" not prevents finding "drawback_file.noassoc foo.shlexec" on wine */ IB> + testfile = "\"%s\\drawback_file.noassoc foo.shlexec\""; IB> + expected = 33; sprintf(fileA, testfile, tmpdir); IB> + rc=shell_execute(NULL, fileA, NULL, NULL); IB> + TEST_LPFILE_PARSED_OK(); IB> + IB> + /* error should be 2, not 31 */ IB> + testfile = "\"%s\\drawback_file.noassoc\" foo.shlexec"; IB> + expected = 2; sprintf(fileA, testfile, tmpdir); IB> + rc=shell_execute(NULL, fileA, NULL, NULL); IB> + TEST_LPFILE_PARSED_OK(); IB> + IB> + /* ""command"" not works on wine (and real win9x and w2k) */ IB> + if (isreallyXP2k3plus) { IB> + testfile = "\"\"%s\\simple.shlexec\"\""; IB> + expected = 33; sprintf(fileA, testfile, tmpdir); IB> + rc=shell_execute(NULL, fileA, NULL, NULL); IB> + todo_wine { TEST_LPFILE_PARSED_OK(); } IB> + } else { IB> + win_skip("ShellExecute('\"\"command\"\"', ...) only works on XP/2k3 or newer\n"); IB> + } IB> + IB> + /* nonexisting "drawback_nonexist.noassoc" not prevents finding "drawback_nonexist.noassoc foo.shlexec" on wine */ IB> + testfile = "%s\\drawback_nonexist.noassoc foo.shlexec"; IB> + expected = 33; sprintf(fileA, testfile, tmpdir); IB> + rc=shell_execute(NULL, fileA, NULL, NULL); IB> + TEST_LPFILE_PARSED_OK(); IB> + IB> + /* is SEE_MASK_DOENVSUBST default flag? Should only be when XP emulates 9x (XP bug or real 95 or ME behavior ?) */ IB> + testfile = "%%TEMP%%\\%s\\simple.shlexec"; IB> + expected = 2; sprintf(fileA, testfile, shorttmpdir); IB> + rc=shell_execute(NULL, fileA, NULL, NULL); IB> + todo_wine { TEST_LPFILE_PARSED_OK(); } IB> + IB> + /* quoted */ IB> + testfile = "\"%%TEMP%%\\%s\\simple.shlexec\""; IB> + expected = 2; sprintf(fileA, testfile, shorttmpdir); IB> + rc=shell_execute(NULL, fileA, NULL, NULL); IB> + todo_wine { TEST_LPFILE_PARSED_OK(); } IB> + IB> + /* test SEE_MASK_DOENVSUBST works */ IB> + testfile = "%%TEMP%%\\%s\\simple.shlexec"; IB> + expected = 33; sprintf(fileA, testfile, shorttmpdir); IB> + rc=shell_execute_ex(SEE_MASK_DOENVSUBST | SEE_MASK_FLAG_NO_UI, NULL, fileA, NULL, NULL); IB> + TEST_LPFILE_PARSED_OK(); IB> + IB> + /* quoted */ IB> + testfile = "\"%%TEMP%%\\%s\\simple.shlexec\""; IB> + expected = 33; sprintf(fileA, testfile, shorttmpdir); IB> + rc=shell_execute_ex(SEE_MASK_DOENVSUBST | SEE_MASK_FLAG_NO_UI, NULL, fileA, NULL, NULL); IB> + TEST_LPFILE_PARSED_OK(); IB> +} IB> + IB> static void test_filename(void) IB> { IB> char filename[MAX_PATH]; IB> @@ -1938,6 +2024,7 @@ START_TEST(shlexec) IB> IB> init_test(); IB> IB> + test_lpFile_parsed(); IB> test_filename(); IB> test_find_executable(); IB> test_lnks(); --

2 2

Re: [PATCH] d3d8: Display FIXME only once in ValidatePixelShader and ValidateVertexShader
by Henri Verbeet 17 Feb '10

17 Feb '10

On 17 February 2010 11:47, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > I'm not much of a fan of the whole "let's disable the scary debug output" idea, especially since now the function becomes invisible after the first call for people doing actual debugging, unless you run with +relay. WINEDEBUG="-all" is much more effective at shutting up debug output, and tends to have minor performance advantages as well.

2 1

Re: [PATCH] wined3d: Display state in state_undefined
by Henri Verbeet 17 Feb '10

17 Feb '10

On 16 February 2010 11:49, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > - ERR("Undefined state.\n"); > + ERR("Undefined state %d\n", state); Did you test this? "state" is supposed to be always 0. Also, debug_d3dstate() is much more readable than the state number.

3 11

Re: [jscript]add korean translation(resend)
by Paul Vriens 17 Feb '10

17 Feb '10

On 02/16/2010 01:25 AM, Hwang YunSong(황윤성) wrote: > > I append patch file > > <http://www.dreamwiz.com/> http://www.dreamwiz.com/ > > <http://dreamwiz.gmarket.co.kr/redirect2.dwz?http://www.gmarket.co.kr/challe…> > <http://banner.auction.co.kr/bn_redirect.asp?ID=BN00008749&lpurl=http://corn…> > > --- a/dlls/jscript/Makefile.in 2010-02-12 10:23:39.603312863 +0900 +++ b/dlls/jscript/Makefile.in 2010-02-10 09:58:16.684464491 +0900 @@ -13,6 +13,7 @@ jscript_Nl.rc \ jscript_Pt.rc \ jscript_Ru.rc \ + jscript_Ko.rc \ rsrc.rc But you didn't fix the sorting in Makefile.in. -- Cheers, Paul.

1 0

Re: [PATCH] configure: Check for the -Wno-force-align-arg-pointer compiler switch.
by Charles Davis 17 Feb '10

17 Feb '10

Charles Davis wrote: > I added this to clang yesterday. Now clang will warn every time it > encounters the force_align_arg_pointer attribute applied to a function > pointer. This isn't a problem on Linux, but on Mac OS X those warnings > are going to clutter the output, since we use it so liberally. All right, since you're not convinced this is a good idea, let me, well, convince you. The conversation I had on the cfe-commits mailing list: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027361.… (my original commit) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027392.… (someone suggesting the warning) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027395.… (someone else seconding it) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027396.… (me saying no) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027397.… (a third person suggesting the switch) http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100208/027420.… (me caving) An incomplete list of projects that use force_align_arg_pointer: - liboil - ffmpeg - x264 - Gallium3D - KDE Just do a Google search for 'force_align_arg_pointer' and you'll see a whole bunch of pages about this! Now are you convinced this is a good idea? Chip

2 2

Re: [PATCH] shell32: replace strcpy by memcpy due to slightly undefined struct handling
by Maarten Lankhorst 16 Feb '10

16 Feb '10

Hello Marcus, 2010/2/15, Marcus Meissner <meissner(a)suse.de>: > Hi, > > Writing over the end of a struct via char[1] is only well defined if the > struct > is standalone and not contained in another struct. > > So for gcc 4.5 the strcpy triggers a fortify overflow error and we > better use memcpy. > > Ciao, Marcus > --- > dlls/shell32/pidl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index 3e61144..a7704b3 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -1606,7 +1606,7 @@ LPITEMIDLIST _ILCreateEntireNetwork(void) > LPPIDLDATA pData = _ILGetDataPointer(pidlOut); > > pData->u.network.dummy = 0; > - strcpy(pData->u.network.szNames, "Entire Network"); > + memcpy(pData->u.network.szNames, "Entire Network", sizeof("Entire > Network")+1); This is wrong, sizeof() already takes the nul character in account, either use sizeof() or strlen() + 1. Cheers, Maarten.

1 0

Re: mciwave: Stub a boundary case in Save.
by Dmitry Timoshkov 16 Feb '10

16 Feb '10

<Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > This will allow me to enable one more testcase when I'll eventually > submit the long awaited update to mciwave tests. > - if (dwFlags & MCI_WAIT) > - { > - FIXME("MCI_WAIT not implemented\n"); > + if (wmw->hFile == 0) { > + FIXME("Save file with zero-length sample\n"); > + return MCIERR_INTERNAL; > } > - WAVE_mciStop(wDevID, 0, NULL); > + WAVE_mciStop(wDevID, MCI_WAIT, NULL); Please don't change the indentation style of the code. Also, it's not clear to me why you have removed the MCI_WAIT fixme, added MCI_WAIT to mciStop, and treat hFile == 0 as a zero-length sample. -- Dmitry.

2 1

Re: [PATCH 1/4] msctf: Add ITfLangBarMgr Interface [Try 3]
by Alexandre Julliard 16 Feb '10

16 Feb '10

Justin Chevrier <jchevrier(a)gmail.com> writes: > @@ -1357,3 +1362,52 @@ interface ITfThreadFocusSink : IUnknown > > HRESULT OnKillThreadFocus(); > }; > + > +[ > + object, > + uuid(95380031-955c-4710-a2ed-4a2fafe17fe8), > + pointer_default(unique) > +] > +interface ITfLangBarMgr: IUnknown This isn't declared in msctf.idl in the PSDK. -- Alexandre Julliard julliard(a)winehq.org

3 4

Adding wikipedia links to appdb?
by Dan Kegel 16 Feb '10

16 Feb '10

I often want to learn more about an app while I'm in the appdb, and particularly, I want to know whether it has a good reputation. Wikipedia can often tell me what I need to know. It might be handy to have a wikipedia url field in the appdb, and an option in Browse Apps that says "only show apps with wikipedia links". What do folks think about the idea?

7 8

Re: [PATCH 1/3] user32/winex11: Move 32-bit cursor/icon structure to 32-bit header.
by Alexandre Julliard 16 Feb '10

16 Feb '10

Erich Hoover <ehoover(a)mines.edu> writes: > --- a/include/winuser.h > +++ b/include/winuser.h > @@ -98,6 +98,17 @@ typedef HANDLE HDWP; > #define WSF_VISIBLE 1 > #define DF_ALLOWOTHERACCOUNTHOOK 1 > > +typedef struct tagWINECURSORICON { > + POINT ptHotSpot; > + WORD nWidth; > + WORD nHeight; > + WORD nWidthBytes; > + BYTE bPlanes; > + BYTE bBitsPerPixel; > + DWORD frame_size_and; > + DWORD frame_size_xor; > +} WINECURSORICON; You can't do that, private structures have nothing to do in public header files. They also can't be part of the user driver API. -- Alexandre Julliard julliard(a)winehq.org

3 3

Status of Patchwatcher
by Seth Shelnutt 15 Feb '10

15 Feb '10

Hey guys, I am wondering what that status of patchwatcher is? I haven't seen anything on it since August where Scott Richie said he and Luke were working on reviving it. I see the code is still on Dan's google page. I am looking to do a GSoC project on appinstall and patchwatcher. I saw the ideals for converting UnitTestSuit and wpkg scripts to Appinstall. I definitely think this is a good idea and needed; however I was thinking that linking patchwatcher and appinstall testing would be even more beneficial. That is assuming patchwatcher is still alive. Before I make any formal announcement of my intent I'm just trying to see how things stand now. Thanks, Seth Shelnutt

1 0

Patch 1 for EM_FORMATRANGE
by James McKenzie 15 Feb '10

15 Feb '10

All: I am working on the final version of the EM_FORMATRANGE patches. Thanks to Dylan Smith who has provided much feedback and corrections to these patches. James McKenzie

1 0

Re: shlwapi: URL_ParseUrl should not fail if there is not :\\
by Nikolay Sivov 15 Feb '10

15 Feb '10

On 2/15/2010 22:07, Aric Stewart wrote: > > allows acceptance of urls such as about:blank > --- > dlls/shlwapi/url.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) Could you add a small test for that?

2 1

Re: [PATCH 4/4] msctf: Implement stubbed out TF_CreateLangBarMgr [Try 2]
by Aric Stewart 15 Feb '10

15 Feb '10

Hi, I am really happy that you are helping with the msctf stuff I started. Very cool! 2 quick things. 1) typedef struct tagACLMulti, don't call it tagACLMulti. I am sure this is from copying from threadmgr.c where it is a copy/paste thing from when I started that framework. It has always bugged me (though not enough to submit a patch just to change it), but it would be nice not to see it propagated even more. 2) you add pITfLangBarMgr to the ActivatedTextService, but dont do anything with it. Does the Activated TextService need to have a reference to the ITfLangBarMgr? My quick read though does not seem to reveal that. When should it get set and initialized and where would it be used? thanks! -aric

2 1

Re: Current status of XI2 mouse stuff now that Lucid Lynx includes XI2?
by Roderick Colenbrander 15 Feb '10

15 Feb '10

On Mon, Feb 15, 2010 at 3:40 PM, Warren Dumortier <nwarrenfl(a)gmail.com> wrote: > As a simple user i have a question. > Will WIne include the patch once it exists and is accepted or will the > Wine team only include it once all major distros use the new Xorg? > I'm really looking forward XInput2 in Wine, but maybe both could be in > the Wine source, but enabling XInput 2 by a compiler flag or registry > key? > The presence of an X extension can be discovered at run-time, so when XInput2 isn't around we would fall back to the old code. Roderick

1 0

Re: [PATCH] shell32: replace strcpy by memcpy due to slightly undefined struct handling
by Paul Chitescu 15 Feb '10

15 Feb '10

> - strcpy(pData->u.network.szNames, "Entire Network"); > + memcpy(pData->u.network.szNames, "Entire Network", sizeof("Entire Network")+1); Please use a const buffer as "Entire Network" is a string literal, not something with a clearly defined size (not even talking about length). const char entireNetwork[] = "Entire Network"; ... memcpy(pData->u.network.szNames, entireNetwork, sizeof(entireNetwork)); The final NUL is part of the char array. Regardless, we may still copy some garbage after the NUL depending if/how the compiler pads the buffer. Probably a better way would be to simply cast (char*)pData->u.network.szNames since the length is not checked anyway. Regards, Paul

2 1

Current status of XI2 mouse stuff now that Lucid Lynx includes XI2?
by Dan Kegel 15 Feb '10

15 Feb '10

I recall that Paul Hampson did a first cut at using XI2, linked to from the bottom of http://wiki.winehq.org/DInput, and http://wiki.winehq.org/Bug6971 says "the new XInput2 X11 extension (which is part of XOrg 7.5) provides relative mouse motion events. Once this extension is more common, we will be able to fix Wine properly." Well, here it is, and XI2 is said to be included in Ubuntu Lucid Lynx Alpha 2; so it's about to get a lot more common. Has anybody tried it out lately? What's Paul's status? Incidentally, I just noticed a page about how somebody made the transition to XI2 on another project, see http://www.clearchain.com/blog/posts/xinput-1-xinput-2-conversion-guide - Dan

4 4

Re: [jscript]add korean translation
by James McKenzie 15 Feb '10

15 Feb '10

Hwangsee: This needs to be resubmitted in UTF format, not HTML as Piotr pointed out. Very good work otherwise. Also, thank you for using the formal version rather than the informal. James McKenize Hwang YunSong(황윤성) wrote: > --- a/dlls/jscript/Makefile.in 2010-02-12 10:23:39.603312863 +0900 > +++ b/dlls/jscript/Makefile.in 2010-02-10 09:58:16.684464491 +0900 > @@ -13,6 +13,7 @@ > jscript_Nl.rc \ > jscript_Pt.rc \ > jscript_Ru.rc \ > + jscript_Ko.rc \ > rsrc.rc > > C_SRCS = \ > --- /dev/null 2010-02-13 09:55:10.082328150 +0900 > +++ b/dlls/jscript/jscript_Ko.rc 2010-02-13 22:29:04.960003941 +0900 > @@ -0,0 +1,51 @@ > +/* > + * Copyright 2009 Piotr Caban > + * Copyright 2010 YunSong Hwang > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > 02110-1301, USA > + */ > + > +#include "resource.h" > + > +/* UTF-8 */ > +#pragma code_page(65001) > + > +LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT > + > +STRINGTABLE DISCARDABLE > +{ > + IDS_TO_PRIMITIVE "객페를 기본 형식으로 변환하는 중에 에러 발생" > + IDS_INVALID_CALL_ARG "올바르지 않은 프로시져 호출이나 인수" > + IDS_CREATE_OBJ_ERROR "자동화 서버가 객체를 만들 수 없습니다" > + IDS_NO_PROPERTY "객체는 이 속성이나 메소드를 지원하지 않습니다" > + IDS_ARG_NOT_OPT "인수는 옵션이 아닙니다" > + IDS_SYNTAX_ERROR "문법 에러" > + IDS_SEMICOLON "';' 가 필요합니다" > + IDS_LBRACKET "'(' 가 필요합니다" > + IDS_RBRACKET "')' 가 필요합니다" > + IDS_UNTERMINATED_STR "띁나지 않은 문자열 상수" > + IDS_NOT_FUNC "함수가 필요합니다" > + IDS_NOT_DATE "'[객체]' 는 날짜 객체가 아닙니다" > + IDS_NOT_NUM "숫자가 필요합니다" > + IDS_OBJECT_EXPECTED "객체가 필요합니다" > + IDS_ILLEGAL_ASSIGN "잘못된 할당" > + IDS_UNDEFINED "'|' 는 정의되지 않았습니다" > + IDS_NOT_BOOL "볼린 객제가 필요합니다" > + IDS_JSCRIPT_EXPECTED "JScript 객체가 필요합니다" > + IDS_REGEXP_SYNTAX_ERROR "정규 표현식에 문법에러가 있습니다" > + IDS_URI_INVALID_CHAR "URI 는 올바르지 않은 문자를 포함해서 인코딩되 > 었습니다" > + IDS_INVALID_LENGTH "배열 길이는 반드시 한정된 양의 정수이어야 합니다" > + IDS_ARRAY_EXPECTED "배열 객체가 필요합니다" > +} > > <http://www.dreamwiz.com/> http://www.dreamwiz.com/ > > <http://dreamwiz.gmarket.co.kr/redirect2.dwz?http://www.gmarket.co.kr/challe…> > <http://banner.auction.co.kr/bn_redirect.asp?ID=BN00008749&lpurl=http://corn…> > > ------------------------------------------------------------------------ > > >

1 0

Re: [ddraw/tests] Fix a test failure on VMware and VirtualBox on W2K and below
by Henri Verbeet 15 Feb '10

15 Feb '10

On 15 February 2010 13:50, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Henri agrees that this looks like it's broken on these platforms and thus > marked as such. I've used an explicit color value for the broken() > statement. > > Changelog > Fix a test failure on VMware and VirtualBox on W2K and below > The broken() is ok, but the comment is misleading. The failure happens because the reference rasterizer is used, not due to something specific to VirtualBox or VMware display drivers.

2 1

Re: [jscript]add korean translation
by Paul Vriens 15 Feb '10

15 Feb '10

On 02/15/2010 01:20 AM, Hwang YunSong(황윤성) wrote: > --- a/dlls/jscript/Makefile.in 2010-02-12 10:23:39.603312863 +0900 > +++ b/dlls/jscript/Makefile.in 2010-02-10 09:58:16.684464491 +0900 > @@ -13,6 +13,7 @@ > jscript_Nl.rc \ > jscript_Pt.rc \ > jscript_Ru.rc \ > + jscript_Ko.rc \ > rsrc.rc Please keep this list sorted. It's usually not an issue (if done correctly) to inline your patch but please not in HTML format. -- Cheers, Paul.

1 0

Re: [PATCH 4/5] ddraw: Add depth clamp tests.
by Paul Vriens 15 Feb '10

15 Feb '10

On 01/26/2010 06:31 PM, Henri Verbeet wrote: > + color = getPixelColor(device, 150, 150); > + todo_wine ok(color_match(color, 0x00ffffff, 1), "color 0x%08x.\n", color); Hi Henri, This particular test fails on some VMware and VirtualBox boxes. We've been through this before about whether broken() is appropriate or not. The attached patch adds an explicit broken color value instead of some color_match(). Not sure what's the best way though. We don't have many test runs on real Windows for these new tests so I can't be a 100% sure if it's just VMware/VirtualBox. Some real boxes have run the ddraw:visual tests but not these new ones as they bailed out because of other issues. Any thoughts on this one? -- Cheers, Paul.

2 1

recent winmm/midimap tests
by Saulius Krasuckas 14 Feb '10

14 Feb '10

Hi folks is it only me getting short midi-like sounds during non-interactive run of Winetest, or is this known new bug already? S.

2 1

Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries
by Alexandre Julliard 14 Feb '10

14 Feb '10

A C Hurst <A.Hurst(a)sheffield.ac.uk> writes: > Fixes bug 11811 [http://bugs.winehq.org/show_bug.cgi?id=11811] and its duplicates. > This patch sent some time back (over a year) was ignored/lost in noise. > Could someone review please? It has already been explained that this belongs in mountmgr, and should be based on the actual devices as reported by HAL. It should also create the corresponding NT devices and symlinks. -- Alexandre Julliard julliard(a)winehq.org

3 2

Wine HQ Down?
by James McKenzie 14 Feb '10

14 Feb '10

Greetings: Cannot connect to www.winehq.org this morning. Scheduled downtime or did the site drop again? James McKenzie

1 0

Game engines and wine
by Dan Kegel 14 Feb '10

14 Feb '10

The use of game engines has increased quite a bit over the last couple years; there are now something like 250 that support Windows. (And maybe five to ten that are important commercially.) It's tempting to consider focusing some effort on supporting a few of them better in Wine, on the theory that then games built with those engines would stand a better chance of running on Wine. The two main commercial ones with freely downloadable SDKs that I know about are Unity3D ( http://appdb.winehq.org/objectManager.php?sClass=version&iId=19268 ) and Unreal ( Unreal's UDK requires .net 3.5, so it can't be installed at the moment ). Looks like Unity3D is close to working, according to the appdb. I'm afraid to guess how long it'll be before we can even install Unreal's UDK... I've written up a few notes and links on the subject at http://wiki.winehq.org/GameEngines - Dan

2 2

Re: cmd: Add test for %~dp0 expansion (bug 21382)
by Alexandre Julliard 13 Feb '10

13 Feb '10

Dan Kegel <dank(a)kegel.com> writes: > --- /dev/null > +++ b/programs/cmd/tests/test_dp0.cmd > @@ -0,0 +1,10 @@ > +@echo off > +echo Begin test for bug 21382 > +rem On old wine, ~dp0 was always current directory rather than "directory containing batch file" > +echo %~dp0 > +mkdir dummydir > +cd dummydir > +echo %~dp0 > +cd .. > +rmdir dummydir > +echo End test for bug 21382 > diff --git a/programs/cmd/tests/test_dp0.cmd.out b/programs/cmd/tests/test_dp0.cmd.out > new file mode 100644 > index 0000000..8c38153 > --- /dev/null > +++ b/programs/cmd/tests/test_dp0.cmd.out > @@ -0,0 +1,4 @@ > +Begin test for bug 21382 > +@pwd@\ > +@pwd@\ > +End test for bug 21382 Please don't create new files for every small test, this will become unmanageable very quickly. Unless there are reasons to split them, everything should go in a single .cmd file. Also don't use bug numbers, add some meaningful message instead. The code must be understandable without reference to bugzilla. -- Alexandre Julliard julliard(a)winehq.org

3 5

valgrind warnings in new d3d10/effect tests
by Dan Kegel 13 Feb '10

13 Feb '10

Hi Rico, please have a look at the two new warnings in http://kegel.com/wine/valgrind/logs/2010-02-12-20.25/diff-d3d10_effect.txt http://kegel.com/wine/valgrind/logs/2010-02-12-20.25/vg-d3d10_effect.txt Invalid free() / delete / delete[] at notify_free (heap.c:262) by RtlFreeHeap (heap.c:1746) by d3d10_effect_Release (effect.c:1954) by test_effect_local_shader (effect.c:3441) by func_effect (effect.c:3462) by run_test (test.h:535) by main (test.h:585) Address 0x7f000c4c is 60 bytes inside a block of size 768 alloc'd at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1700) by parse_fx10_body (effect.c:1576) by parse_fx10 (effect.c:1691) by fx10_chunk_handler (effect.c:1705) by parse_dxbc (effect.c:195) by d3d10_effect_parse (effect.c:1715) by D3D10CreateEffectFromMemory (d3d10_main.c:230) by create_effect (effect.c:55) by test_effect_local_shader (effect.c:2660) by func_effect (effect.c:3462) by run_test (test.h:535) by main (test.h:585) 80 bytes in 6 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1700) by copy_name (effect.c:214) by parse_fx10_anonymous_shader (effect.c:874) by parse_fx10_object (effect.c:995) by parse_fx10_pass (effect.c:1087) by parse_fx10_technique (effect.c:1148) by parse_fx10_body (effect.c:1620) by parse_fx10 (effect.c:1691) by fx10_chunk_handler (effect.c:1705) by parse_dxbc (effect.c:195) by d3d10_effect_parse (effect.c:1715) by D3D10CreateEffectFromMemory (d3d10_main.c:230) by create_effect (effect.c:55) by test_effect_local_shader (effect.c:2660) by func_effect (effect.c:3462) by run_test (test.h:535) by main (test.h:585) probably from commit f816210c214318b0beba5ed6b90c6cd32dd3fd96 Author: Rico Schüller <kgbricola(a)web.de> Date: Thu Feb 11 19:49:24 2010 +0100 d3d10/tests: Add effect shader test. - Dan

1 0

Re: msxml4: Added support for SAXXMLReader40
by Nikolay Sivov 13 Feb '10

13 Feb '10

On 2/13/2010 15:01, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml4: Added support for SAXXMLReader40 > > Best Regards > Alistair Leslie-Hughes Hi, Alistair. You missed a registration part for in msxml4.

1 0

Re: shell32[1/2]: implements shell link's GetCurFile (with tests, fixes bug #21297) [try3]
by Paul Vriens 13 Feb '10

13 Feb '10

On 02/13/2010 11:49 AM, Mikołaj Zalewski wrote: > +#define expect_eq_ws(expected, actual) \ > + do { \ > + LPCWSTR value = (actual); \ > + ok(lstrcmpW((expected), value) == 0, "Expected " #actual " to be %s (" #expected ") is %s\n", \ > + wine_dbgstr_w(expected), wine_dbgstr_w(value)); \ > + } while (0) Hi Mikołaj, lstrcmpW is not implemented on Win9x/WinMe and will always return 0. -- Cheers, Paul.

1 0

Re: Re[2]: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)
by James Mckenzie 12 Feb '10

12 Feb '10

Ilya Basin <basinilya(a)gmail.com> wrote at Feb 12, 2010 4:39 AM about Re[2]: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend) > >Thanks for review. Not sending to wine-patches this time. New patch is >in the bottom. What's better, to attach a generated patch or to use it >as a message body? > Generated patch, if at all possible. That way we can use git apply to install. James McKenzie

1 0

Re: wined3d: Add surface conversion function from WINED3DFMT_YUY2 to WINED3DFMT_B8G8R8X8_UNORM (try 2)
by Stefan Dösinger 12 Feb '10

12 Feb '10

> + dst_line[x] = 0xff000000 > + | cliptobyte((c2 + r2) >> 8) << 16 /* red */ > + | cliptobyte((c2 + g2) >> 8) << 8 /* green */ > + | cliptobyte((c2 + b2) >> 8); /* blue */ I'm not sure if 0xff is the correct value for the X channel, but technically it shouldn't really matter since the X is ignored. Is there a specific reason why you set it to 0xff? Otherwise the patch looks ok to me, but I think Henri might want to take a look at it as well before it is committed.

1 0

Student Interested in Contributing to Wine
by Michael Griepentrog 12 Feb '10

12 Feb '10

Hi, I'm interested in contributing to Wine, and I'm posting here for guidance on how to get started. I'll start off with a bit about myself: I'm currently a senior majoring in Computer Science at the University of Wisconsin - Madison and will be graduating in May. Most of my upper-level coursework has pertained to operating systems and networking, but I also have experience with OpenGL and Cocoa/Objective-C. I haven't really contributed to any other projects, so this is both new and foreign to me. I'm primarily interested in improving the Wine experience on OS X. I read pages from http://wiki.winehq.org/MacOSX, but I'm not sure how much of that reflects the current direction of Wine development on Mac. What are the immediate needs for improving Wine on OS X? Off hand, I know Wine doesn't compile on Snow Leopard as a 64-bit binary (http://forum.winehq.org/viewtopic.php?p=31321), but it seems like this issue isn't limited to OS X. I'm also curious about the status of the Quartz driver, and if it's something that is still being pursued. Creating a binary distributable also seems like something that should be addressed, but I understand that isn't necessarily easy given how applications are "installed" on OS X. So whatever the current direction is for the OS X port, I would like to get involved in making it better. I look forward to hearing what suggestions you have for me. Thanks, Michael Griepentrog

2 1

Re: New Spanish translations [1/4]: dlls/hhctrl.ocx
by Paul Vriens 12 Feb '10

12 Feb '10

On 02/11/2010 02:36 PM, José Manuel Ferrer Ortiz wrote: > As requested, I'll resend these patches, splitting them one message per > module. This way it looks a lot more professional :D > > I've also fixed a few things that were wrong or could be better: > - Switched to UTF-8 encoding, and added the required 'pragma'. > - Changed language to SUBLANG_NEUTRAL. > > Thank you, Nikolay, for making me aware of these mistakes. > > Regards, > José Manuel > > Hi José, Your patches don't apply. See: http://source.winehq.org/patches/ I've spotted two issues: 1. Patches should be generated from the top-level. 2. As these are new files you also need changes to the corresponding Makefile.in file. -- Cheers, Paul.

2 2

Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries
by James Mckenzie 12 Feb '10

12 Feb '10

Alexandre Julliard wrote at Feb 12, 2010 5:00 AM (Arizona Time Zone) about Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries > >A C Hurst <A.Hurst(a)sheffield.ac.uk> writes: > >> Fixes bug 11811 [http://bugs.winehq.org/show_bug.cgi?id=11811] and its duplicates. >> This patch sent some time back (over a year) was ignored/lost in noise. >> Could someone review please? > >It has already been explained that this belongs in mountmgr, and should >be based on the actual devices as reported by HAL. It should also create >the corresponding NT devices and symlinks. > Alexandre: libhal does not work on Macs and I don't think it works on Sparc based equipment. How would this work for MacOSX/Solaris? James McKenzie

2 1

Re: rpcrt4: Add tests for multi-dimensional conformant arrays.
by Paul Vriens 12 Feb '10

12 Feb '10

On 02/11/2010 05:18 PM, Huw Davies wrote: > + ptr = NdrSimpleStructMarshall(&StubMsg, (unsigned char *)&memsrc, > +&fmtstr_complex_array[32] ); Hi Huw, This particular test crashes on Win9x, WinMe and NT4. They all show: ndr_marshall.c:1973: Test failed: length 96 just before the crash so maybe that would be our means to bail out? -- Cheers, Paul.

2 2

AppDB: add graphic card info field?
by burp＠nurfuerspam.de 12 Feb '10

12 Feb '10

Hi, currently the AppDB test results include (besides the obvious wine related fields) only the distribution as distinguishing attribute for a test(er). Now, my view point is the game(r) perspective. Maybe that's far too narrow, but still... Many times I looked at test results and wished to see which graphic card and driver/version was used for the test for obvious reasons: - Owners of NVidia cards with binary drivers are quite often not seeing the same set of bugs as owners of ATI cards with binary drivers - Owners of the same card are quite often having very different results with different driver versions, and it happened multiple times that an older version was working where a newer wasn't (though the other way around is naturally more common...) Recently this has become even worse IMO due to people trying to play games with the open source stack on ATI cards which is a completely different experience angle. An example for the matter is Runes of Magic: The game doesn't work on ATI cards at all, on older NVidia cards there's a workaround by disabling the GLSL shader, on newer NVidia cards it works also with GLSL shader. Most recent test results are all silver/gold/platinum based on NVidia cards, looking at the full history there's a nice spectrum of garbage/bronze (ATI) alternating with silver/gold/platinum (NVidia). As an average user, this tends to be quite confusing if you don't look at the details. This is *not* just a matter of bugs, but also of features: World of Warcraft on ATI/Catalyst wasn't showing an indoor map for about 2 years (no pbuffers in ATI drivers), while the feature was fine on NVidia, while OpenGL hardware cursor is still available on neither card (missing feature of WoW's OpenGL backend). (TLDR starts here >>) How are the chances that a patch to include graphics chip, driver name and version into test results would be accepted? Or would it be more welcome to split affected applications into versions by graphic card/driver? (I.e.: Runes of Magic: 2.x on ATI/Catalyst, World of Warcraft: 3.3.x on Intel/OpenSource, ...) Cheers, $B1 $28 -- GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT! Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01

1 0

Re: [msi/tests] Fix a test failure on Win9x/WinMe
by Hans Leidekker 12 Feb '10

12 Feb '10

On Friday 12 February 2010 12:15:48 Paul Vriens wrote: > Changelog > Fix a test failure on Win9x/WinMe Can you find the string "msi test font" anywhere in the registry after running that test? -Hans

2 1

Re: [PATCH] shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile (resend)
by Paul Vriens 12 Feb '10

12 Feb '10

On 02/11/2010 03:37 PM, Ilya Basin wrote: > Hi! This should expose this bug: > http://bugs.winehq.org/show_bug.cgi?id=19385 ( the 'wine start' > launcher does not open MS Office documents that have spaces in their > path ). Although the title is misleading, many other tickets are > marked as duplicates of it. > It's not about spaces. It's about sometimes unneeded parsing of > SHELLEXECUTEINFO.lpFile, trying to extract arguments from it. Why? > Or maybe some other part of wine relies on this behavior? > Tested on 98 se, 2k& xp. > > ...obvious mistakes become visible only after you hit the "send" > button. So I apologize beforehand. Hi Ilya, As Wine doesn't do the right thing (according to your tests), all failing Wine tests should be marked as such. We have a todo_wine construct for that. > > --- > dlls/shell32/tests/shlexec.c | 106 ++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 106 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/tests/shlexec.c b/dlls/shell32/tests/shlexec.c > index c673f0a..fb5e6b7 100644 > --- a/dlls/shell32/tests/shlexec.c > +++ b/dlls/shell32/tests/shlexec.c > @@ -797,6 +797,10 @@ static const char* testfiles[]= > "%s\\test file.sde", > "%s\\test file.exe", > "%s\\test2.exe", > + "%s\\simple.shlexec", > + "%s\\drawback_file.noassoc", > + "%s\\drawback_file.noassoc foo.shlexec", > + "%s\\drawback_nonexist.noassoc foo.shlexec", > NULL > }; > > @@ -852,6 +856,107 @@ static filename_tests_t noquotes_tests[]= > {NULL, NULL, 0} > }; > > +static void test_lpFile_parsed(void) > +{ > + /* basename tmpdir */ > + const char* shorttmpdir; > + > + const char *testfile; > + char fileA[MAX_PATH]; > + > + int rc; > + int expected; > + > + BOOL iswin9x = FALSE; > + BOOL isreallyNT = FALSE; > + > + /* detect win ver */ > + { > + DWORD dwVersion = GetVersion(); > + DWORD dwWindowsMajorVersion = (DWORD)(LOBYTE(LOWORD(dwVersion))); > + DWORD dwMinorVersion = (DWORD)(HIBYTE(LOWORD(dwVersion))); > + DWORD dwBuild; > + > + if (dwVersion< 0x80000000) // Windows NT/2000, Whistler No C++ comments please. > + dwBuild = (DWORD)(HIWORD(dwVersion)); > + else if (dwWindowsMajorVersion< 4) // Win32s > + dwBuild = (DWORD)(HIWORD(dwVersion)& ~0x8000); > + else // Windows 95/98/Me > + { > + dwBuild = 0; > + iswin9x = TRUE; > + isreallyNT = NULL != GetModuleHandle("ntdll"); > + } > + } We generally do not want any real version checking in the tests. Tests should decide based on behavior on what platform they are. > + > + GetTempPathA(sizeof(fileA), fileA); > + shorttmpdir = tmpdir + strlen(fileA); > + > + /* ensure tmpdir is in %TEMP% */ > + SetEnvironmentVariableA("TEMP", fileA); Why is this necessary? > + > + #define TEST_LPFILE_PARSED_OK_() (rc==expected || rc>32&& expected>32) > + #define TEST_LPFILE_PARSED_OK() ok(TEST_LPFILE_PARSED_OK_(), "expected %s (%d), got %s (%d), lpFile: %s \n", expected==33 ? "success" : "failure", expected, rc> 32 ? "success" : "failure", rc, fileA) > + > + /* existing "drawback_file.noassoc" prevents finding "drawback_file.noassoc foo.shlexec" on wine */ > + testfile = "%s\\drawback_file.noassoc foo.shlexec"; > + expected = 33; sprintf(fileA, testfile, tmpdir); > + rc=shell_execute(NULL, fileA, NULL, NULL); > + TEST_LPFILE_PARSED_OK(); > + > + /* if quoted, existing "drawback_file.noassoc" not prevents finding "drawback_file.noassoc foo.shlexec" on wine */ > + testfile = "\"%s\\drawback_file.noassoc foo.shlexec\""; > + expected = 33; sprintf(fileA, testfile, tmpdir); > + rc=shell_execute(NULL, fileA, NULL, NULL); > + TEST_LPFILE_PARSED_OK(); > + > + /* error should be 2, not 31 */ > + testfile = "\"%s\\drawback_file.noassoc\" foo.shlexec"; > + expected = 2; sprintf(fileA, testfile, tmpdir); > + rc=shell_execute(NULL, fileA, NULL, NULL); > + TEST_LPFILE_PARSED_OK(); > + > + /* ""command"" not works on wine (and real win9x and w2k) */ > + testfile = "\"\"%s\\drawback_file.noassoc foo.shlexec\"\""; > + expected = iswin9x&& !isreallyNT || dllver.dwMajorVersion<= 5 ? 2 : 33; sprintf(fileA, testfile, tmpdir); > + rc=shell_execute(NULL, fileA, NULL, NULL); > + TEST_LPFILE_PARSED_OK(); > + > + /* nonexisting "drawback_nonexist.noassoc" not prevents finding "drawback_nonexist.noassoc foo.shlexec" on wine */ > + testfile = "%s\\drawback_nonexist.noassoc foo.shlexec"; > + expected = 33; sprintf(fileA, testfile, tmpdir); > + rc=shell_execute(NULL, fileA, NULL, NULL); > + TEST_LPFILE_PARSED_OK(); > + > + /* is SEE_MASK_DOENVSUBST default flag? Should only be when XP emulates 9x */ > + { Any particular reason for this indentation? -- Cheers, Paul.

2 2

Building list of great demos for Wine
by Dan Kegel 11 Feb '10

11 Feb '10

[Sent this to wine-users, but maybe wine-devel folks are more likely to give demos and need a list like this.] I'm putting together a list of impressive freely-downloadable demos (or apps) that run flawlessly under Wine. i.e. platinum (no hacks, patches, or recipes needed), high production values, and good enough to have gotten some notice and approval at Amazon, Wikipedia, or some other authoritative site. What I've got so far is at http://wiki.winehq.org/GreatDemos I'll keep plugging away at it, but it'd be great if other people could add known great demos there. Thanks! - Dan

5 7

Re: msxml3/tests: Some refcount tests
by Nikolay Sivov 11 Feb '10

11 Feb '10

Forget about it, not so useful yet but adds even more questions. Ref count still doesn't match anyway.

1 0

Did today's git compile properly?
by Susan Cragin 11 Feb '10

11 Feb '10

It's probably me... But I got the following: .1 make[1]: Leaving directory `/home/susan/wine/loader' make[1]: Entering directory `/home/susan/wine/programs' rm -f /usr/local/bin/`dirname programs/msiexec/__installprog__` && /usr/bin/install -c wineapploader /usr/local/bin/`dirname programs/msiexec/__installprog__` /usr/bin/install: cannot create regular file `/usr/local/bin/programs/msiexec': No such file or directory make[1]: *** [programs/msiexec/__installprog__] Error 1 make[1]: Leaving directory `/home/susan/wine/programs' make: *** [programs/__install__] Error 2 susan@ubuntu:~/wine$

2 1

Re: shell32[1/2]: implements shell link's GetCurFile (with tests, fixes bug #21297)
by Austin English 11 Feb '10

11 Feb '10

2010/2/10 Mikołaj Zalewski <mikolaj(a)zalewski.pl>: > Some installers require this. + expect_eq_x(S_FALSE, IPersistFile_IsDirty(pf)); + expect_eq_x(S_FALSE, IPersistFile_GetCurFile(pf, &string)); + expect_eq_p(NULL, string); + expect_eq_x(S_OK, IShellLinkA_GetHotkey(link, &hotkey)); + expect_eq_x(0, hotkey); + expect_eq_x(S_FALSE, IPersistFile_IsDirty(pf)); + // Setting the same value will not set IsDirty... + expect_eq_x(S_OK, IShellLinkA_SetHotkey(link, 0)); + todo_wine expect_eq_x(S_FALSE, IPersistFile_IsDirty(pf)); + // ... but a different one will. You've got C++ comments in there... -- -Austin

3 2

Make issue with latest git
by chris ahrendt 11 Feb '10

11 Feb '10

Just did the latest git and got the following : all -c wineapploader /usr/local/bin/`dirname programs/msiexec/__installprog__` /usr/bin/install: cannot create regular file `/usr/local/bin/programs/msiexec': No such file or directory make[1]: *** [programs/msiexec/__installprog__] Error 1 make[1]: Leaving directory `/work/wine-git/programs' make: *** [programs/__install__] Error 2 if I went into the /usr/local/bin there is no programs directory so made the directory and reran make install or tools/install and worked fine... Did not need this until todays git as yesterdays worked just fine without the directory... chris

2 1

Re: [PATCH 1/7] msctf: Add langbarmgr.c
by Justin Chevrier 11 Feb '10

11 Feb '10

Thanks for the feedback. Would submitting this as one patch be acceptable? My intention was really to have all this applied in one go. If not, I'll split as recommended. I've got some fixing up to do and I'll resubmit. Justin On Thu, Feb 11, 2010 at 1:27 PM, Justin Chevrier <jchevrier(a)gmail.com> wrote: > Hi Justin, > > It's good that you're splitting patches, but you did it wrong. No patch may > depend on another patch that is later in series. After applying each patch > the tree must be in good state. That said, Wine won't compile after patch > #1 until patch #6 is applied and patch #2 there will cause compile warning > until patch #7 is applied. Also it's not good to add code that is dead, > such as your patch #1 until patch #3 is applied and part of patch #3 > without patch #4 (although such patches are sometimes accepted). I'd > suggest sending in order: > - patch #6 (note that the interface is called ITfLangBarMgr) > - patch #5 > - patch #4 (with better changelog) > - joined patches 1,2,3,7 > > Also langbarmgr.c seems to be better place for TF_CreateLangBarMgrJacek > implementation. > > > Jacek >

2 1

Re: [PATCH 1/7] msctf: Add langbarmgr.c
by Nikolay Sivov 11 Feb '10

11 Feb '10

On 2/11/2010 19:51, Justin Chevrier wrote: > --- > dlls/msctf/langbarmgr.c | 193 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 193 insertions(+), 0 deletions(-) > create mode 100644 dlls/msctf/langbarmgr.c > > > + This = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(LangBarMgr)); > > You don't need HEAP_ZERO_MEMORY here, cause you will set all fields anyway. Also it looks like you specially split to several patches to have only one file per patch, that's not needed.

2 2

Re: [PATCH 1/7] msctf: Add langbarmgr.c
by Jacek Caban 11 Feb '10

11 Feb '10

Hi Justin, It's good that you're splitting patches, but you did it wrong. No patch may depend on another patch that is later in series. After applying each patch the tree must be in good state. That said, Wine won't compile after patch #1 until patch #6 is applied and patch #2 there will cause compile warning until patch #7 is applied. Also it's not good to add code that is dead, such as your patch #1 until patch #3 is applied and part of patch #3 without patch #4 (although such patches are sometimes accepted). I'd suggest sending in order: - patch #6 (note that the interface is called ITfLangBarMgr) - patch #5 - patch #4 (with better changelog) - joined patches 1,2,3,7 Also langbarmgr.c seems to be better place for TF_CreateLangBarMgrJacek implementation. Jacek

1 0

Re: oleaut32: Fix rounding
by Alexandre Julliard 11 Feb '10

11 Feb '10

André Hentschel <nerv(a)dawncrow.de> writes: > --- > dlls/oleaut32/tests/varformat.c | 10 ++++++++-- > dlls/oleaut32/varformat.c | 3 ++- > dlls/oleaut32/variant.c | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so vartest.c && touch vartest.ok vartest.c:1347: Test failed: Expected cDig = 1, got 2 vartest.c:1348: Test failed: Digit[0], expected 1, got 0 vartest.c:1348: Test failed: Digit[1], expected 255, got 1 make[1]: *** [vartest.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Remove leftover HINSTANCE16 code from LoadCursor/LoadIcon.
by Alexandre Julliard 11 Feb '10

11 Feb '10

Michael Stefaniuc <mstefani(a)redhat.de> writes: > The Wine code doesn't seem to pass a 16bit hinstance to > LoadCursor/LoadIcon; the only calls to those functions from 16bit code > use a 0 hinstance which is fine. 16-bit instances can come from 32-bit calls too, if we are dealing with a 16-bit window. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: runtest: search also for Applicationtests
by Alexandre Julliard 11 Feb '10

11 Feb '10

André Hentschel <nerv(a)dawncrow.de> writes: > So it works with cmd.exe_test.exe.so now You should compute the right name based on the directory instead of guessing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Adding wikipedia links to appdb?
by Joerg-Cyril.Hoehle＠t-systems.com 11 Feb '10

11 Feb '10

-1 1. AFAIK, one can add (after submission, i.e. maintainers only) as many URL's as one wants. So one could well add one labeled "Wikipedia article" 2. I already have half a dozen of AppDB entries yet to write simply because it costs me a lot of time :-( - Research a possible URL for that 10 year old app - What name to use: publisher, distributor or developer (where do I find this), what URL? E.g. Is Ubi Soft a distributor or a publisher or a reseller? Is it appropriate at all? - Scanning for duplicates - Are English and German releases different versions or different entries? - What's the original/English title (e.g. for what's known as "Backpacker" in Germany but seems to come from Sweden)? - Mindboggingly buggy JavaScript editor (adding white space here and there as well as spurious - signs at the end of texts), requiring at least 6 preview iterations. - Are my installation receipies & caveats reproducible? - Try to test and play long enough (esp. adventure games) to be able to submit thrustworthy results, before the version of wine used for installation fades out of AppDB and I'm refused the addition of the version I tested. I don't want to feel obliged to supply even more data. Currently, I'm really p.o.'ed that I cannot submit test data for older releases of Wine. I've apps that used to work and currently don't. I very much prefer an old gold entry in AppDB, along with bugzilla regressions rather than a single garbage entry for the current version, perhaps saying "this used to work in wine-1.1.18". But I digress. Regards, Jörg Höhle

1 0

Re: Adding wikipedia links to appdb?
by David Gerard 11 Feb '10

11 Feb '10

[to list as well, *cough*] On 11 February 2010 11:35, Rosanne DiMesio <dimesio(a)earthlink.net> wrote: > On Wed, 10 Feb 2010 21:38:56 -0800 > Dan Kegel <dank(a)kegel.com> wrote: >> I often want to learn more about an app while >> I'm in the appdb, and particularly, I want to know >> whether it has a good reputation. Wikipedia >> can often tell me what I need to know. It >> might be handy to have a wikipedia url field >> in the appdb, and an option in Browse Apps >> that says "only show apps with wikipedia links". >> What do folks think about the idea? > I think the AppDB is for information about how well an app works in Wine, not the merits of the app itself. Having an entry in Wikipedia has more to do with Wikipedia's notions of "notability" than any actual merits of the app. A quite horrible app could have a Wikipedia entry if its horribleness is famous enough ;-) However, a Wikipedia link field may be a useful thing to have. - d.

1 0

Re: dsound/tests: DirectSound3DListener_QueryInterface should accept IKsPropertySet
by Joerg-Cyril.Hoehle＠t-systems.com 11 Feb '10

11 Feb '10

Hi, I don't know how others feel about this pattern: + ok(rc==DS_OK && temp_buffer!=NULL, ... + if(temp_buffer) IKsPropertySet_Release(temp_buffer); I'd rather code like this if (rc==DS_OK && temp_buffer) Release(). The reason is that the typical invariant is "Any output variable is correctly set if and only if the called function indicated success on return". And the corollar: If it failed, output variables may generally be filled with garbage. Similarly, access errno only after an I/O function returned failure. I do not dispute that it is good style for the callee to only set output variables when returning success. But that is a requirement hard to maintain in SW and often violated. E.g. there's a lot of code like: ... if (some) return ERROR; *outparam1= xyz; ... if (more) return ERROR; ... *outparam2= abc; ... return SUCCESS; See how p1 may contain garbage? Regards, Jörg Höhle

1 0

mountmgr removable media woes
by louis＠museresearch.com 10 Feb '10

10 Feb '10

Hi all, I'm troubleshooting some removable media mounting issues with WINE 1.1.7. It seems that when using an auto-mounting program such as gnome-volume-manager or thunar-volman that WINE's mountmgr misses a HAL notification. This happens when WINE is already running and a new disk is inserted. I am mostly testing it with a flash reader, but I saw that it happens with optical media too. What appears to be happening is this: HAL first sends out that a new device is available with a null mount point. The volume manager picks that up, mounts the partition, and then tells HAL. HAL then sends out a property_modified message with the new mount point. Mountmgr gets the first notification, tries to register a watch in time, but is usually too slow and misses the mount point changed notice. I tried moving the watch registration to the top of the new_device function (it is currently at the bottom), which caused only certain apps to work such as winefile, but not notepad (winefile did not seem to be doing anything special other than responding to a new device with a slow redraw). Gnome-volume-manager and thunar-volman both watch all HAL devices from the start. I notice that doing this in mountmgr causes it to work. Is there a reason I should not do this? Cheers, Louis

1 0

Re: Some new Spanish translations
by Nikolay Sivov 10 Feb '10

10 Feb '10

On 2/10/2010 20:28, José Manuel Ferrer Ortiz wrote: > Hello all. Here you are a few newly translated Spanish resource files, > for hhctrl, iccvid, localspl and mapi32 dlls. > > Regards, > José Manuel Hi, Jose. Use UTF-8 encoding with corresponding pragma directive. > +#include "localspl_private.h" > + > +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT > + > +STRINGTABLE DISCARDABLE > +{ > + IDS_LOCALPORT "Puerto local" > + IDS_LOCALMONITOR "Monitor local" > +} > You forgot to change ID here. Also split this to several patches, one per module.

1 0

Wine FIXME Report January 2010
by Michael Stefaniuc 10 Feb '10

10 Feb '10

Wine FIXME Report January 2010 ============================== The data for this report comprise the emails from January 2010 archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 6364 (emails: 5850, bugzilla attachments: 514) Files with FIXME/ERR/WARN: 436 Type | Total | Unique ------+---------+------- fixme | 1354429 | 8122 err | 24115 | 993 warn | 3491 | 404 The Most Popular Messages ------------------------- This are the most prevalent ERR and FIXME messages aka the number of files where they show up. FIXME: Files | Lines | Channel:Function Text ------+-------+---------------------- 59 | 119 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 42 | 45 | system:SetProcessDPIAware stub! 36 | 46 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 33 | 61 | mixer:ALSA_MixerInit No master control found on HDA ATI HDMI, disabling mixer 29 | 57 | urlmon:URLMoniker_BindToObject use running object table 22 | 41 | shdocvw:BindStatusCallback_OnProgress status code 11 19 | 21 | system:SystemParametersInfoW Unimplemented action: 59 (SPI_SETSTICKYKEYS) 18 | 21 | resource:GetGuiResources (0xffffffff,0): stub 18 | 37 | shdocvw:PropertyNotifySink_OnChanged unimplemented dispid 1005 17 | 71 | storage:StgCreateDocfile Storage share mode not implemented. ERR: Files | Lines | Channel:Function Text ------+-------+---------------------- 22 | 41 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 18 | 25 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 18 | 26 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 15 | 1646 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 14 | 1645 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 12 | 44 | ole:CoGetClassObject class {6c736db1-bd94-11d0-8a23-00aa00b58e10} not registered 12 | 44 | ole:CoGetClassObject no class object {6c736db1-bd94-11d0-8a23-00aa00b58e10} could be created for context 0x1 12 | 114 | ole:apartment_getclassobject DllGetClassObject returned error 0x80040111 10 | 18 | rpc:I_RpcGetBuffer no binding 9 | 12 | ole:CoGetClassObject class {77f10cf0-3db5-4966-b520-b7c54fd35ed6} not registered Noisy Popular Messages ---------------------- The noisiest messages that show up at least in 1% of the collected reports. FIXME: Lines | Files | Channel:Function Text ------+-------+---------------------- 223 | 7 | mshtml:nsChannel_GetSecurityInfo default action not implemented 155 | 11 | ole:CoGetClassObject CLSCTX_REMOTE_SERVER not supported 144 | 12 | wininet:InternetLockRequestFile STUB 119 | 59 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 110 | 9 | advapi:LsaClose (0xcafe) stub 99 | 8 | font:WineEngAddFontResourceEx Ignoring flags 10 92 | 5 | wininet:GetUrlCacheEntryInfoExW Undocumented flag(s): 100 75 | 7 | file:MoveFileWithProgressW MOVEFILE_WRITE_THROUGH unimplemented 71 | 17 | storage:StgCreateDocfile Storage share mode not implemented. 61 | 33 | mixer:ALSA_MixerInit No master control found on HDA ATI HDMI, disabling mixer ERR: Lines | Files | Channel:Function Text ------+-------+---------------------- 1646 | 15 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 1645 | 14 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 114 | 12 | ole:apartment_getclassobject DllGetClassObject returned error 0x80040111 113 | 6 | ole:ClientIdentity_QueryMultipleInterfaces IRemUnknown_RemQueryInterface failed with error 0x80004002 66 | 7 | ole:ITypeInfo_fnInvoke did not find member id -504, flags 0x2! 66 | 7 | ole:ITypeInfo_fnInvoke did not find member id -514, flags 0x2! 62 | 6 | shell:SHGetFileInfoW pidl is null! 44 | 12 | ole:CoGetClassObject class {6c736db1-bd94-11d0-8a23-00aa00b58e10} not registered 44 | 12 | ole:CoGetClassObject no class object {6c736db1-bd94-11d0-8a23-00aa00b58e10} could be created for context 0x1 41 | 22 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element Noisy Popular Functions ----------------------- The noisiest functions that show up at least in 1% of the collected reports. FIXME: Lines | Files | Channel:Function ------+-------+----------------- 434041 | 716 | ole:NdrCorrelationInitialize 434009 | 716 | ole:NdrCorrelationFree 7620 | 6 | d3d:context_check_fbo_status 2716 | 100 | d3d_surface:IWineD3DVolumeImpl_LockBox 2052 | 8 | d3d_surface:IWineD3DBaseSurfaceImpl_Blt 1531 | 156 | d3d:IWineD3DOcclusionQueryImpl_GetData 738 | 78 | d3d_surface:IWineD3DSurfaceImpl_LoadLocation 653 | 497 | shdocvw:ClOleCommandTarget_Exec 466 | 84 | dsound:IDirectSoundBufferImpl_AcquireResources 418 | 197 | mshtml:nsChannel_GetSecurityInfo ERR: Lines | Files | Channel:Function ------+-------+----------------- 16107 | 37 | ole:ITypeInfo_fnInvoke 3291 | 29 | ddraw:PixelFormat_WineD3DtoDD 872 | 201 | ole:CoGetClassObject 180 | 27 | x11settings:X11DRV_ChangeDisplaySettingsEx 174 | 26 | ole:create_server 121 | 16 | ole:apartment_getclassobject 113 | 6 | ole:ClientIdentity_QueryMultipleInterfaces 113 | 6 | ole:marshal_object 69 | 63 | eventlog:ReportEventW 62 | 6 | shell:SHGetFileInfoW The Top Ten Single Charts ------------------------- This are the messages with the most occurrences in a single file. FIXME: Lines | Files | Channel:Function Text ------+-------+---------------------- 433829 | 4 | rpc:NdrStubCall2 new correlation description not implemented 61256 | 1 | ole:NdrCorrelationFree (0x33df38): stub 61224 | 1 | ole:NdrCorrelationInitialize (0x33df38, 0x33db38, 1024, 0x0): stub 60612 | 1 | ole:NdrCorrelationInitialize (0x33d414, 0x33d014, 1024, 0x0): stub 60611 | 1 | ole:NdrCorrelationFree (0x33d414): stub 50370 | 1 | ole:NdrCorrelationInitialize (0x33d694, 0x33d294, 1024, 0x0): stub 50364 | 1 | ole:NdrCorrelationFree (0x33d694): stub 29000 | 1 | ole:NdrCorrelationInitialize (0x33d764, 0x33d364, 1024, 0x0): stub 28994 | 1 | ole:NdrCorrelationFree (0x33d764): stub 17768 | 1 | ole:NdrCorrelationInitialize (0x33d6ec, 0x33d2ec, 1024, 0x0): stub ERR: Lines | Files | Channel:Function Text ------+-------+---------------------- 13032 | 1 | ole:ITypeInfo_fnInvoke did not find member id 512, flags 0x4! 1728 | 1 | ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_I4 from VT_BSTR 864 | 1 | ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_BOOL from VT_BSTR 837 | 15 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 58 837 | 14 | ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 64 756 | 1 | d3d_surface:IWineD3DBaseSurfaceImpl_CreateDIBSection CreateDIBSection failed! 331 | 1 | d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R32G32B32A32_FLOAT 331 | 1 | d3d:getColorBits Unsupported format: WINED3DFMT_R32G32B32A32_FLOAT 288 | 1 | ole:ITypeInfo_fnInvoke did not find member id 854, flags 0x4! 198 | 3 | d3d:state_undefined Undefined state. Further Info: ------------- The sqlite3 database and the SQL commands to output the above info can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/201001/ bye michael

4 9

Re: wined3d: Add surface conversion function from WINED3DFMT_YUY2 to WINED3DFMT_B8G8R8X8_UNORM
by Stefan Dösinger 10 Feb '10

10 Feb '10

Am 09.02.2010 um 18:11 schrieb Sandijs Ribaks: > This is a patch for http://bugs.winehq.org/show_bug.cgi?id=21629 . It seems ok in concept, just a few points: > +static void convert_yuy2_x8r8g8b8(const BYTE *src, BYTE *dst, > + DWORD pitch_in, DWORD pitch_out, unsigned int w, unsigned int h) > ... > + const BYTE *src_line = (const BYTE *)(src + y * pitch_in); The cast here is redundant > + if (!(x & 1)) { /* for every even pixel, read new U and V */ The placement of the { is inconsistent with the rest of the patch. > + dst_line[x] = 0xff000000 > + | cliptobyte((c2 + r2) >> 8) << 16 /* red */ > + | cliptobyte((c2 + g2) >> 8) << 8 /* green */ > + | cliptobyte((c2 + b2) >> 8); /* blue */ I recommend to add a comment explaining that (x >> 8) << 8 is not redundant but in used to mask out lower bits. Just to make sure I understand this correctly: > + r2 = 409 * e + 128; > + g2 = - 100 * d - 208 * e + 128; > + b2 = 516 * d + 128; The +128 here is for proper rounding in the right shift step afterwards?

1 0

Understanding 64bit implications and wine64
by Joerg-Cyril.Hoehle＠t-systems.com 10 Feb '10

10 Feb '10

Hi, I've trouble understanding some of the 64bit issues. Lacking a 64bit machine, I'm left asking questions ;-) My understanding is that wine64 is the effort to make Wine work on 64bit UNIX systems, i.e. pointer size = 64bit, isn't it? DWORD_PTR is 64 bit wide on a wine64 system, 32 bit otherwise, correct? A priori, this has nothing to do with MS-Windows' LARGE_ADDRESS_SPACE_AWARE(sp?) API, which I believe allows 32bit apps to nevertheless make use of more than 1,5/2/4GBof RAM, isn't it? The wine64 challenge seems to let 32bit MS-windows apps work even though the UNIX side has to manage pointer addresses >2^32, i.e. above the lower 4GB address range. Is there some address translation involved or only mmap'ing? What must the Wine developer know to write correct code for wine64? For instance, I fail to understand Erich Pouech's recent commit 5cab72bc95ec2d864e19952fff2df99610ba7537 winmm: For MCI parsing, use 64bit compatible variables. If you look closely at the definitions of MCI_xyz_PARMS in MMSYSTEM.H, you'll notice that (at least on 32bit systems), despite the different types (DWORD, LPSTR, UINT) these structures are originally an array of 32bit values. This regular structure is essential, because the MCI command parser has very limited means to know about different sizes. All it knows is MCI_INTEGER, MCI_STRING, MCI_CONSTANT. An app that sends an MCI_xyz command sends a pointer to such an array, decorated as MCI_xyz_PARMSA/W for nicer access. Alternatively, when using mciSendString, the MCI parser builds this array of DWORD elements, then calls the MCI command. In recent Wine, this has become an array of DWORD_PTR instead. wine-tests may work because Wine is cnosistent with itself, but How can this possibly work without breaking binary compatibility? Thanks for your help, Jörg Höhle

8 7

Re: msxml4: Prefer to use the native version
by Nikolay Sivov 09 Feb '10

09 Feb '10

On 2/9/2010 11:50, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml4: Prefer to use the native version > > Best Regards > Alistair Leslie-Hughes Why do you need this?

2 3

Re: ws2_32: warn the user if broadcasts are failing because of a missing route to 255.255.255.255
by Austin English 09 Feb '10

09 Feb '10

On Mon, Feb 8, 2010 at 2:07 PM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Changelog: > * ws2_32: warn the user if broadcasts are failing because of a missing > route to 255.255.255.255 diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 9a65cb0..ac55e50 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -1430,7 +1431,13 @@ static int WS2_send( int fd, struct ws2_async *wsa ) hdr.msg_flags = 0; #endif - return sendmsg(fd, &hdr, wsa->flags); + ret = sendmsg(fd, &hdr, wsa->flags); + if (ret < 0 && errno == ENETUNREACH && wsa->addr && wsa->addr->sa_family == AF_INET && + ((struct WS_sockaddr_in*)wsa->addr)->sin_addr.WS_s_addr == 0xFFFFFFFF) + { + FIXME("broadcast failed, you need to add a route to 255.255.255.255\n"); That doesn't look like a WARN() to me. Anyway, it seems an ERR() would be more appropriate. -- -Austin

2 1

Re: cmd: Added cmd.exe tests. [try2]
by Alexandre Julliard 09 Feb '10

09 Feb '10

Jacek Caban <jacek(a)codeweavers.com> writes: > In previous version CRs were lost in their way to wine-patches. Also > this version has a few improvements made together with Dan that should > help writing tests, mostly no need to care about CRs (they are > skipped) and better failure messages. It doesn't work here: ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok batch.c:162: Test failed: too long output make: *** [batch.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winhlp32: Impove Tab view [try 5]
by Nikolay Sivov 09 Feb '10

09 Feb '10

On 2/9/2010 20:57, Vladimir Pankratov wrote: > Hello all. > > changes since try 4: > changed buffer size to 257 > > Thanks to Nikolay Sivov. > + WCHAR wszSearchText[257]; /* Native uses only first 256 symbols + trailing \0 */ > That's not exactly what I meant. Native winhlp32 as I can see doesn't allow more than 256 characters to be typed in. So it's not the same as to ignore the rest.

1 0

Re: winhlp32: Improve Tab view [try 3]
by Nikolay Sivov 09 Feb '10

09 Feb '10

Replying with wine-devel, cause my gmail account reported failed delivery to Vladimir's mail address. You have a kind of forwarding or I don't know what. > -------- Original Message -------- > Subject: Re: winhlp32: Improve Tab view [try 3] > Date: Tue, 09 Feb 2010 21:14:04 +0500 > From: Vladimir Pankratov <scriptkid(a)mail.ru> > Reply-To: scriptkid(a)mail.ru > To: Nikolay Sivov <bunglehead(a)gmail.com> > > > > You wrote: > > On 2/8/2010 16:59, Vladimir Pankratov wrote: > >> Hello all. > >> > >> changes since try 2: > >> removed files without IDD_INDEX dialog > >> + WCHAR wszText[255]; > >> > > Isn't it possible to use some defined name here? MAX_PATH probably. > AJ said: MAX_PATH doesn't make sense here, this is not a file name. What to do? > I was my guess only, about MAX_PATH, cause it's 260 and you used 255. What to do? Something I replied on previous try. You should figure out using native program how bigger this string could be and just use this length. If I got it right it's a kind of UI element you could easily access in native program too. Just type and count, that's all. After that put a constant and a comment that you verified it. P.S. Just checked. And it supports 256 characters, so you need 257 buffer I suppose.

1 0

Re: winhlp32: Improve Index tab [try 4][Resend]
by Alexandre Julliard 09 Feb '10

09 Feb '10

Vladimir Pankratov <scriptkid(a)mail.ru> writes: > Hello all. > > changes since try3: > changed variables size to MAX_PATH MAX_PATH doesn't make sense here, this is not a file name. -- Alexandre Julliard julliard(a)winehq.org

1 0

iPod synced with iTunes v7.6!
by Eric Badiere 09 Feb '10

09 Feb '10

Hello, Is there any site that can tell me what patches I need to apply to do this? At work I've been assigned the task of testing an iPhone app, and I run mint 8 on my laptop. I am no apple fan boy, so I am not planning on buying my own mac to do this, and I am trying to avoid windoze. Any help would be appreciated. Best Regards, Eric

2 1

problem with wine
by David Adam 09 Feb '10

09 Feb '10

Hello, since one month I have problem with Wine. With the wine-git or the Wine binary provided by Mandriva, since I try to launch any application I have the following message: [david@Thakur Téléchargement]$ wine t3_demo_uk.exe err:process:__wine_kernel_init boot event wait timed out err:seh:raise_exception Exception frame is not in stack limits => unable to dispatch exception. [david@Thakur Téléchargement]$ That happens for any application. Obviously, the application does not start. But for builtin application, everything is fine. For instance, wine notepad works fine. Any clue to fix my problem? A+ David

3 2

winetest now wants an email address
by Alexandre Julliard 08 Feb '10

08 Feb '10

Folks, As of today, winetest requires an email address to submit results to test.winehq.org. This is because it's often necessary to contact the submitter of a test to get more details, or to ask them to fix their setup, and it's often hard to guess the identity of the submitter from the tag name. If you are morally offended at the idea of your email showing up in the result log, you can use some obfuscated format, or use your real name or IRC nick if you are well-known around these parts. The important thing is that Wine developers must be able to get in touch with you easily. If you have some automated scripts submitting results, you'll need to fix them to pass a -m option to winetest. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function. [try 3]
by James Mckenzie 08 Feb '10

08 Feb '10

>> Well, in 2010 I've only done little changes. The real development on >> this was in 2009. What's the policy in these cases? I believe I can >> put the 2010 safely. >I have seen people adjust the years for simple fixes, although I don't know if there is a formal >policy. Since your patches are going in now I guess anything from "2009", "2009, 2010" to "2010" is >warranted. > >Since most countries don't require a copyright notice any longer(although still recommend it) I guess >there is no real legal significance to the year. In most places copyright expiration doesn't depend on >the publication date but on the year of the death of the last surviving creator. > >IANAL, somebody who knows this better please correct me. > I thought that AJ only wanted a copyright notification if significant contributions were added. As to the date the format 2009-2010 would be most suitable in this case. James McKenzie

1 0

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function. [try 3]
by Stefan Dösinger 08 Feb '10

08 Feb '10

Am 08.02.2010 um 16:33 schrieb Matteo Bruni: > Other than the things Henri last mentioned, there are some more small > changes (make some struct const/static, whitespace fixes, remove some > useless cruft, ...) particularly in patches 2 and 3. > <0001-d3dx9-Partial-implementation-of-D3DXAssembleShader-fun.txt> Henri is on holidays this week(I think), here are 3 things I noticed: > + static const struct wpp_callbacks wpp_callbacks = { > + wpp_lookup_mem, > + wpp_open_mem, The placement of the { is not consistent with the rest of the patch (and the entire patch 1 is inconsistent with patch 2 and 3). It seems to me the predominant style in d3dx9 is the one used by patch 1, although there are some inconsistencies. > +void wpp_write_message(const char *fmt, va_list args) > +{ Unless I am missing some wpp magic here you can make this function(and others) static as well. > + * Copyright 2009 Matteo Bruni Maybe make this 2009-2010?

2 2

grrrrr
by Dan Kegel 08 Feb '10

08 Feb '10

http://www.pro-linux.de/NB3/news/1/15259/starmoney-stellt-linux-variante-ei… Looks like Star Money is blaming Wine for its troubles... IIRC, they switched to .net or something without asking whether it would work on Wine. Grr.

3 2

Re: winhlp32: Improve Index tab [try 4]
by Nikolay Sivov 08 Feb '10

08 Feb '10

On 2/8/2010 20:09, Vladimir Pankratov wrote: > Hello all. > > changes since try3: > changed variables size to MAX_PATH > Actually it was just a guess. It's better to try with native and limit Edit accordingly, after that you could query for its length or use static buffer of the same limit. > Thanks to all

1 0

Re: [PATCH] shlwapi: Improve error handling in UrlGetPart
by Alexandre Julliard 08 Feb '10

08 Feb '10

Andrew Eikum <aeikum(a)codeweavers.com> writes: > --- > dlls/shlwapi/tests/url.c | 25 ++++++++++++++++++--- > dlls/shlwapi/url.c | 52 > +++++++++++++++++++++++++++++++++++---------- > 2 files changed, 61 insertions(+), 16 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so misc.c && touch misc.ok misc.c:348: Test failed: [1] domain failed: 00000000 make: *** [misc.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] user32: make wineserver calls to get and set window droptargets [try 2]
by Alexandre Julliard 08 Feb '10

08 Feb '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > Changelog: > * user32: make wineserver calls to get and set window droptargets > > Get and set the window drop targets from user32.dll, and not ole32.dll > like in try 1. That's not much better, you are still having ole32 do server calls, only hidden behind a Wine-specific export. You should be able to do this with only standard user32 APIs, or you need to make a very convincing case that it's impossible without private exports. -- Alexandre Julliard julliard(a)winehq.org

2 2

Status of USB patches?
by Scott Ritchie 08 Feb '10

08 Feb '10

I wanted to experiment with these, but I'm not sure of their current state. Do they still apply cleanly? Are they on track for eventual inclusion? I'm willing to help provide community testing by putting them in a special package repository. Thanks, Scott Ritchie

3 4

Getting start with IXMLHTTPRequest
by Nikolay Sivov 08 Feb '10

08 Feb '10

Hi. Recently I tried to start with this interface. It looks trivial enough but since it's first time i'm using winhttp, there could be some problems, especially cause IXMLHTTPRequest supports asynchronous requests. Could someone with winhttp knowledge review this patch before it goes to far from reality? P.S. any comments are welcome actually.

3 9

Re: winhlp32: Improve Tab view [try 3]
by Nikolay Sivov 08 Feb '10

08 Feb '10

On 2/8/2010 16:59, Vladimir Pankratov wrote: > Hello all. > > changes since try 2: > removed files without IDD_INDEX dialog > + WCHAR wszText[255]; > Isn't it possible to use some defined name here? MAX_PATH probably.

1 0

Re: [PATCH 2/5] qedit: Add pins, IMemInputPin implementation and grabbing to SampleGrabber (try 4)
by Nikolay Sivov 08 Feb '10

08 Feb '10

On 2/5/2010 17:54, Paul Chitescu wrote: > Changelog: > qedit: Add pins, IMemInputPin implementation and grabbing to SampleGrabber > > This time I checked it applies. Sorry. > --- +/* Sample Grabber pin implementation */ +typedef struct _SG_Pin { + IPin pin; This should be const IPinVtbl. + PIN_DIRECTION dir; + WCHAR const *name; + struct _SG_Impl *sg; + IPin *pair; If it's a list why not SG_Pin* here? +} SG_Pin; --- Also I don't see why such helpers are needed: --- static ULONG SampleGrabber_addref(SG_Impl *This) --- Why not use common Ixxxx_AddRef() on grabber anywhere you need it?

2 1

Re: winhlp32: Improve Index tab
by Michael Stefaniuc 08 Feb '10

08 Feb '10

Hello Vladimir, Vladimir Pankratov wrote: > Improved Index tab view please do not add the IDD_INDEX dialog to the languages that don't have it as the fallback to English happens automatically. That way it is easier to detect that something needs to be translated. Only the languages that already have the IDD_INDEX dialog need to be modified to prevent display errors. thanks bye michael

1 0

Re: [PATCH] user32/tests: make the MDI client take up the whole client area
by Dmitry Timoshkov 08 Feb '10

08 Feb '10

Reece Dunn <msclrhd(a)googlemail.com> wrote: > The MDI tests in user32/tests/msg.c were using an MDI client of zero > size (0,0 - 0,0). This means that the tests are not realistic for > real-world applications that use MDI, as their frame windows size the > client window to fit the frame's client area. It would be better IMO to create MDI client with the correct size at the first place instead of resizing it later. That would prevent any confusion, and perhaps even more problems once somebody adds tests before the MoveWindow() call. -- Dmitry.

2 1

Re: iphlpapi: _res is per-thread in glibc with pthreads
by John Klehm 08 Feb '10

08 Feb '10

On Mon, Feb 8, 2010 at 12:01 AM, Dan Kegel <dank(a)kegel.com> wrote: > With test. Without the fix, the test case crashes on my machine. > Fixes crash in bug http://bugs.winehq.org/show_bug.cgi?id=21624 > > Same fix probably needed in dnsapi, or maybe iphlpapi should > use dnsapi rather than unix dns api. > > Thanks to AF for the analysis. > testWin98OnlyFunctions(); testWinNT4Functions(); - testWin98Functions(); + thread = CreateThread(NULL, 0, testWin98Functions, NULL, 0, &threadId); + testWin98Functions(NULL); + WaitForSingleObject( thread, INFINITE ); Is that extra non threaded testWin98Functions(NULL) supposed to be in there? Regards, --John Klehm

1 0

idea: display drivers
by C.W. Betts 08 Feb '10

08 Feb '10

An idea that popped into my head when I was thinking about a Quartz (OS X) driver that perhaps there could be separate drivers for Quartz (OS X) and X11. Such drivers would include OpenGL and DirectX "Drivers".

9 16

Re: idea: display drivers
by James McKenzie 07 Feb '10

07 Feb '10

Roderick Colenbrander wrote: > On Sun, Feb 7, 2010 at 6:41 PM, James McKenzie > <jjmckenzie51(a)earthlink.net> wrote: > >> Correct. But why keep the old stuff around? It might be confusing to >> the Wine beginner. >> >> > > The new style driver would only work on modern hardware like windows7 does. > > That makes sense. However, how long are we going to support 'older' hardware? Most manufacturers give up after two years. James McKenzie

1 0

Re: [4/6] wininet: Clean up locks after closing libssl and libcrypto.
by Paul Vriens 07 Feb '10

07 Feb '10

On 02/07/2010 04:56 PM, Paul Vriens wrote: > On 02/07/2010 04:46 PM, Hans Leidekker wrote: >> On Sunday 07 February 2010 16:24:11 Paul Vriens wrote: >> >>>> if (OpenSSL_ssl_handle) >>>> @@ -305,6 +297,12 @@ void NETCON_unload(void) >>>> pSSL_CTX_free(ctx); >>>> wine_dlclose(OpenSSL_ssl_handle, NULL, 0); >>>> } >>>> + if (ssl_locks) >>>> + { >>>> + int i; >>>> + for (i = 0; i< pCRYPTO_num_locks(); i++) >>>> DeleteCriticalSection(&ssl_locks[i]); >>>> + HeapFree(GetProcessHeap(), 0, ssl_locks); >>>> + } >>>> #endif >>>> } >>>> >>> Hi Hans, >>> >>> I was checking a crash in an installer (the AkamaiDownloadManager to >>> download CS4 for example) and it looks like we are accessing a ssl >>> function CRYPTO_num_locks() after we've closed the library? >>> >>> Can you confirm this? >> >> Yes, looks like I fixed this in winhttp but forgot to send the same >> patch for >> wininet. Try this patch. >> >> -Hans > > Yup, crash is gone, thanks. > Forgot to include wine-devel. -- Cheers, Paul.

1 0

Re: [4/6] wininet: Clean up locks after closing libssl and libcrypto.
by Paul Vriens 07 Feb '10

07 Feb '10

On 10/27/2009 10:04 AM, Hans Leidekker wrote: > Found by valgrind. > --- > dlls/wininet/netconnection.c | 14 ++++++-------- > 1 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/dlls/wininet/netconnection.c b/dlls/wininet/netconnection.c > index 97c764f..16cce40 100644 > --- a/dlls/wininet/netconnection.c > +++ b/dlls/wininet/netconnection.c > @@ -289,14 +289,6 @@ void NETCON_unload(void) > #if defined(SONAME_LIBSSL)&& defined(SONAME_LIBCRYPTO) > if (OpenSSL_crypto_handle) > { > - if (ssl_locks) > - { > - int i; > - > - for (i = 0; i< pCRYPTO_num_locks(); i++) > - DeleteCriticalSection(&ssl_locks[i]); > - HeapFree(GetProcessHeap(), 0, ssl_locks); > - } > wine_dlclose(OpenSSL_crypto_handle, NULL, 0); > } > if (OpenSSL_ssl_handle) > @@ -305,6 +297,12 @@ void NETCON_unload(void) > pSSL_CTX_free(ctx); > wine_dlclose(OpenSSL_ssl_handle, NULL, 0); > } > + if (ssl_locks) > + { > + int i; > + for (i = 0; i< pCRYPTO_num_locks(); i++) DeleteCriticalSection(&ssl_locks[i]); > + HeapFree(GetProcessHeap(), 0, ssl_locks); > + } > #endif > } > Hi Hans, I was checking a crash in an installer (the AkamaiDownloadManager to download CS4 for example) and it looks like we are accessing a ssl function CRYPTO_num_locks() after we've closed the library? Can you confirm this? -- Cheers, Paul.

2 1

re: Forward SHLocalAlloc to kernel32 LocalAlloc
by Dan Kegel 07 Feb '10

07 Feb '10

What app needs this? It's been discussed before a bit; Win 98 explorer used it, http://www.winehq.org/pipermail/wine-devel/2005-August/039487.html but http://www.geoffchappell.com/viewer.htm?doc=studies/windows/shell/shell32/a… says that ordinal 200 was later taken over by SHCreateDesktop. Unless we have a real good reason, we probably want to go with the later scheme. - Dan

1 0

Participate to GSoC
by Warren Dumortier 07 Feb '10

07 Feb '10

Hello everybody! First i'll present myself. So my name's Warren Dumortier and i live in Belgium, i've been using Wine for 4 years and i've always been interrested on how it works Also i'm quite active on AppDB for submitting apps. I actively program in C on Linux since 3 years as Gfire (our program) developer. As i actively program in C and would like to develop for WINE, i had a look at the GSoC wiki page. This year i could finally participate as i'm legally allowed now. Are there any specific things to know in order to be accepted as a GSoC student for WINE? These are the two ideas i'd like to implement: Theming - Implement Wine GTK/QT theming support Vista Game Explorer API - Implement the core functionality of this dll I don't know which one i would choose yet, but how are ideas assigned to students, are there requirements needed for each idea? Then i could for example get familiar with the idea before the GSoC starts... When can i ask to be GSoC student? Thanks in advance, kind regards.

2 1

Re: [ mshtml missing function ]
by lementec fabien 06 Feb '10

06 Feb '10

2010/2/6 lementec fabien <fabien.lementec(a)gmail.com>: > hi, > > thanks for the patch but it doesnot make > solidwork works actually, even if it solves > the previous issue. The error is now: > fixme:mshtml:HTMLBodyElement_put_leftMargin > > I will file a bug, > > Regards, > > Fabien. > > 2010/2/6 Jacek Caban <jacek(a)codeweavers.com>: >> On 2/6/10 10:11 PM, lementec fabien wrote: >>> >>> Hi, >>> >>> I have mostly managed to make solidworks2010 work >>> under the latest version of wine. The following function >>> has a missing feature when called with the variant set to >>> 3: >>> dlls/mshtml.c::HTMLStyle_put_width >>> >> >> You may try the attached patch (compile tested only). >> >>> I dont know anything related to mshtml, >> >> Then please file a bug instead of writing to wine-devel. >> >>> so it would be >>> great if anyone is interested in implementing it... would >>> make this great software works with wine. >>> >> >> I'd be skeptical about this, it's probably more work. >> >> >> Jacek >> >> >> >> > > > > -- > the number of UNIX installations has grown to 10, with more expected. > The unix programmer's manual, June, 1972 > -- the number of UNIX installations has grown to 10, with more expected. The unix programmer's manual, June, 1972

1 0

[ mshtml missing function ]
by lementec fabien 06 Feb '10

06 Feb '10

Hi, I have mostly managed to make solidworks2010 work under the latest version of wine. The following function has a missing feature when called with the variant set to 3: dlls/mshtml.c::HTMLStyle_put_width I dont know anything related to mshtml, so it would be great if anyone is interested in implementing it... would make this great software works with wine. Regards, Fabien. -- the number of UNIX installations has grown to 10, with more expected. The unix programmer's manual, June, 1972

3 2

winedbg: output of the bt command misses sometimes a frame
by Bernhard Übelacker 06 Feb '10

06 Feb '10

Hello, as I was debugging in wine I wondered if following behaviour is intended or could be considered a bug (and should be filed in bugtracker?). When the debugger's current position is on the opening curly bracket of a function a "bt" command writes a different stack as if the current position is on the next instruction in this function. What me makes wonder is the frame 0 is always correct but the calling function is not in the stack at all in the first bt: Wine-dbg>bt Backtrace: =>0 0x7ebe3622 IsWindow(hwnd=0x20060) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:2503] in user32 (0x0033b500) 1 0x7e25429d create_window16+0x5c(cs=0x33b53c, className="QWidget", instance=0x400000, unicode=1) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user.exe16/message.c:2670] in user.exe16 (0x0033b520) 2 0x7ebe0f91 CreateWindowExW+0x7e(exStyle=1024, className="QWidget", windowName="pica", style=114032640, x=-2147483648, y=-2147483648, width=-2147483648, height=-2147483648, parent=(nil), menu=(nil), instance=0x400000, data=0x0(nil)) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:1500] in user32 (0x0033b570) 3 0x650778f3 in qtgui4 (+0x778f3) (0x80000000) Wine-dbg>next 2507 if (!(ptr = WIN_GetPtr( hwnd ))) return FALSE; Wine-dbg>bt Backtrace: =>0 0x7ebe3637 IsWindow+0x15(hwnd=0x20060) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:2507] in user32 (0x0033b2b0) 1 0x7ebe0bda WIN_CreateWindowEx+0x1201(cs=0x33b53c, className="QWidget", module=0x400000, unicode=1) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:1406] in user32 (0x0033b500) 2 0x7e25429d create_window16+0x5c(cs=0x33b53c, className="QWidget", instance=0x400000, unicode=1) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user.exe16/message.c:2670] in user.exe16 (0x0033b520) 3 0x7ebe0f91 CreateWindowExW+0x7e(exStyle=1024, className="QWidget", windowName="pica", style=114032640, x=-2147483648, y=-2147483648, width=-2147483648, height=-2147483648, parent=(nil), menu=(nil), instance=0x400000, data=0x0(nil)) [/home/bernhard/data/entwicklung/2010/wine/wine-git/dlls/user32/win.c:1500] in user32 (0x0033b570) 4 0x650778f3 in qtgui4 (+0x778f3) (0x80000000) Wine-dbg> Kind regards Bernhard

3 2

Re: msxml3: implement-domtext_replaceData
by Nikolay Sivov 06 Feb '10

06 Feb '10

On 2/6/2010 04:36, jose rostagno wrote: > implement domtext_replaceData function > <http://www.descubrewindowslive.com/hotmail/anti-spam.asp> > + if(offset == 0){ > + IXMLDOMText_substringData(iface, count, len - count,&str); > + hr = IXMLDOMText_put_data(iface, str); > + if(hr == S_OK) > + hr = IXMLDOMText_put_data(iface, p); > This is obviously wrong. As a result just p will be stored as new data. Let's deal with previous patch first, next patch should most likely just duplicate it.

1 0

libpng dependency issue
by Luca Bennati 06 Feb '10

06 Feb '10

First: should i open a bug for this? The problem is from the new libpng 1.4.0: this evening i just updated this lib, and now i get compile error in dlls/windowscodecs/pngformat.c I'm still investigating the issue to find a solution, but the change that introduced this is clear, directly from their README: Removed deprecated functions png_read_init, png_write_init, png_info_init, png_permit_empty_plte, png_set_gray_1_2_4_to_8, and removed the deprecated macro PNG_MAX_UINT. So, what should WINE do? I see two actions that need to be performed: 1- check the libpng version in configure 2- adjust pngformat.c to work with the new lib. For a short term solution, needed also in the long term one (in the beginning), configure should give error if libpng isn't < 1.4.0 In the long term, while distros begin to ship libpng 1.4.0, the main developers of windowscodecs should work out a code solution. What is that i cannot say, since i don't really know the code, but i think it won't be a few minutes of work... This could apply also to libjpeg since it bumped to 8.0, but i didn't try that part yet.

4 16

Re: msxml3-implement-domcomment_replaceData
by Nikolay Sivov 06 Feb '10

06 Feb '10

On 2/5/2010 20:18, jose rostagno wrote: > implement missing domcomment_replaceData > + if((offset == 0) || ((count + offset)>= len)) > + { > + if(offset == 0){ > + IXMLDOMComment_substringData(iface, count, len - count,&str); > + hr = IXMLDOMComment_put_data(iface, str); > + if(hr == S_OK) > + hr = IXMLDOMComment_appendData(iface, p); > This doesn't look right. You're appending replacement string to the rest of initial string data, and offset == 0 means to replace from the start (if I didn't miss something). Also we really need some tests here, and it's trivial to test here (look at existing test I recently added for deleteData() for example). Especially test for a case count != (p string length) is interesting. Minor things: - watch for indentation and please avoid tabs - most lines are indented with spaces, - don't use 'if () {' style. The rest of this file uses '{' on the next line, - correct your name in author filed to start with uppercase.

1 0

MDI client repaint issues (client and children) and conformance tests for this
by Reece Dunn 06 Feb '10

06 Feb '10

Hi, I have been looking at http://bugs.winehq.org/show_bug.cgi?id=14312 which shows up as the MDI client window not being repainted properly when a new child is created given an already maximised child window being present. There is a related issue here that sometimes the child window frames are not being redrawn properly. I am trying to understand where this problem is occurring, and am failing to see the big picture. As I understand it, WM_MDIRESTORE is sent for the maximised child window, which calls ShowWindow(SW_RESTORE) on the child. This is then (from what I can tell) is handled by the windowing code (with the client behaving like a desktop window), which is taking care of the positioning and layout of the child windows. For some reason, the parent window (the client) is not being updated properly (i.e. a WM_ERASEBKGND+WM_PAINT is not being sent). Likewise, the child windows don't appear to be handling and/or receiving a WM_NCPAINT message to redraw their frame. In addition to this, looking at the message trail tests in user32/tests/msg.c, only some of these are testing a WM_ERASEBKGND+WM_PAINT message is being sent. How accurate are these with respect to WM_PAINT messages (that is, are WM_PAINT messages ignored in message trails unless explicitly tested for?). And in terms of a fix, what is the best approach for fixing the issue? That is, Alexandre does not like an explicit call to InvalidateRect in the WM_MDICREATE handler, so I assume that the repaint logic should be done in a more specific place or figure out why it is not being called for the MDI client. - Reece

2 3

Winehq donation and DATA COMPRESSION
by Gerold Jens Wucherpfennig 06 Feb '10

06 Feb '10

Hi, I've donated some bucks to winehq by PayPal and want to spend more... Can I decide for which things will be spend? When donating money, how much of it will go to PayPal? Is there a better way than using PayPal (by the donate link of the winehq front-page)? BTW I've done some cabinet.dll stuff some years ago. Can anybody give me a hint to some easy-to-understand data compression documentation? I want to complete the cabinet.dll archive creation compression, if I get the required knowledge. It's so difficult... :-( Thanks and Bye, Gerold

6 5

Display drivers
by C.W. Betts 06 Feb '10

06 Feb '10

An idea that popped into my head when I was thinking about a Quartz (OS X) driver that perhaps there could be separate drivers for Quartz (OS X) and X11. Such drivers would include OpenGL and DirectX "Drivers".

1 0

Implement D3DXDeclaratorFromFVF
by paulo lesgaz 06 Feb '10

06 Feb '10

The patch is a copy/paste from the file d3d9/verdeclaration.c. So this file should be simplified too, if we simplify the d3dx9_36/mesh.c implementation. Obviously, to compute the size of the vertex, we can use D3DXGetDeclVertexSize, but we gain very few. So, what do you think about this? A+ David

1 0

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function. [try 2]
by Henri Verbeet 05 Feb '10

05 Feb '10

On 4 February 2010 19:26, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > +void wpp_write_message_var(const char *fmt, ...) PRINTF_ATTR(1,2); > +void wpp_write_message_var(const char *fmt, ...) You can just do the following: +void PRINTF_ATTR(1,2) wpp_write_message_var(const char *fmt, ...) > + desc = HeapAlloc(GetProcessHeap(), 0, sizeof(struct mem_file_desc)); sizeof(*desc) is generally easier, but that's minor of course. > + if(desc->pos + len > desc->size) len = desc->size - desc->pos; It's usually safer to write expressions like that as "if (len > desc->size - desc->pos)" because "desc->pos + len" can wrap around if len is large, while "desc->size - desc->pos" should always be safe. Perhaps the caller is expected to always pass sane values here, but it's a somewhat dangerous construction in the general case in terms of reading/writing past the end of buffers. It can also be simplified to "len = min(len, desc->size - desc->pos);" here. > + if(wpp_output_size + len > wpp_output_capacity) Similar issue as above. > +int wpp_close_output(void) > +{ > + /* trim buffer to the effective size */ > + char *new_wpp_output = HeapReAlloc(GetProcessHeap(), 0, wpp_output, > + wpp_output_size + 1); > + if(!new_wpp_output) return 0; > + wpp_output[wpp_output_size]='\0'; > + return 1; > +} This doesn't really make sense. The comment is misleading, because you actually grow the buffer if "wpp_output_size == wpp_output_capacity". If you didn't, you wouldn't care about HeapRealloc() failure because the worst thing that could happen was that the buffer was a bit larger than it strictly needed to be. More importantly though, you assume new_wpp_output is the same pointer as wpp_output after a successful HeapReAlloc(), which isn't necessarily true. > + current_shader.buffer = HeapAlloc(GetProcessHeap(), 0, data_len + 1); ... > + ret = wpp_parse("", NULL); > + if(!wpp_close_output()) > + ret = 1; > + if(ret) > + { > + TRACE("Error during shader preprocessing\n"); > + HeapFree(GetProcessHeap(), 0, current_shader.buffer); I don't think it's very nice to have the HeapAlloc() and HeapFree() on different levels of the code like that. I.e., either have both in wpp_open_mem()/wpp_close_mem() or have both in the caller. The current scheme has the allocation in the caller and the deallocation in wpp_close_mem(), except sometimes when wpp_parse() fails to call wpp_close_mem(). (Can that even happen? Looking at the source of wpp_parse() it's not clear to me how.) Also, does wpp_parse() really need the input to be zero-terminated?

3 5

CJK default fonts for packagers to set
by Scott Ritchie 05 Feb '10

05 Feb '10

My notes from Wineconf remind me that I need to create some manual links in the registry to whatever default CJK fonts are on the system. Can someone tell me what these are supposed to look like? Thanks, Scott Ritchie

3 3

Git does not build properly after daily pull -- font errors
by Susan Cragin 05 Feb '10

05 Feb '10

What's up with the git repository? I do the following: git pull sudo make uninstall ./configure --enable-win64 && make distclean ./configure --enable-win64 && make depend && make and I get the following: warning: System 16: missing glyph for char f8c8 make[1]: *** No rule to make target `marlett.ttf', needed by `all'. Stop. make[1]: Leaving directory `/home/susan/wine/fonts' make: *** [fonts] Error 2 So I delete the git repository and download a new one.

3 2

Re: Git does not build properly after daily pull -- font errors
by Susan Cragin 05 Feb '10

05 Feb '10

>Susan Cragin wrote: >> ./configure --enable-win64 && make distclean >> ./configure --enable-win64 && make depend && make >Huh? Are you actually trying to build the 64-bit version of Wine? Why >would you want to do that? Especially when 64-bit Wine isn't mature yet. > >Did you try it without --enable-win64? >> >> and I get the following: >> >> warning: System 16: missing glyph for char f8c8 >> make[1]: *** No rule to make target `marlett.ttf', needed by `all'. Stop. >> make[1]: Leaving directory `/home/susan/wine/fonts' >> make: *** [fonts] Error 2 >Check out commit 8350aafd5495c77ad4ba005dc4ae3f61a1ad1147: > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Feb 4 20:29:23 2010 +0100 > > fonts: Remove the rules for font symlinks and go back to standard VPATH >usage. > >I'll bet that has something to do with it... >> >> So I delete the git repository and download a new one. >OK? Then what happened? Did it work, or didn't it? The new git repository worked. I've been doing --enable-win64 because it has worked for me. I've been doing it for a couple of weeks and haven't had a problem. Susan

1 0

Re: confirm af48973b6246cef737c553415eed7349e89b5944
by L. Rahyen 05 Feb '10

05 Feb '10

On 2010-02-02 (February, Tuesday) 15:00:01 wine-devel-request(a)winehq.org wrote: > Your membership in the mailing list wine-devel has been disabled due > to excessive bounces The last bounce received from you was dated > 26-Jan-2010. You will not get any more messages from this list until > you re-enable your membership. You will receive 2 more reminders like > this before your membership in the list is deleted. > > To re-enable your membership, you can simply respond to this message > (leaving the Subject: line intact), or visit the confirmation page at > > > http://www.winehq.org/mailman/confirm/wine-devel/af48973b6246cef737c553415 > eed7349e89b5944 > > > You can also visit your membership page at > > http://www.winehq.org/mailman/options/wine-devel/research%40science.su > > > On your membership page, you can change various delivery options such > as your email address and whether you get digests or not. As a > reminder, your membership password is > > xearaxon > > If you have any questions or problems, you can contact the list owner > at > > wine-devel-owner(a)winehq.org >

1 0

Re: kernel32: Add support for InterlockedCompareExchange64, try 2
by Alexandre Julliard 05 Feb '10

05 Feb '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > --- > Fix the definitions in winbase.h, and the inline assembly :) There are still several problems with your assembly, and I don't understand why you want to reinvent the wheel when we have a perfectly fine interlocked_cmpxchg64 implementation already. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3dx9: Implement D3DXDeclaratorFromFVF
by Henri Verbeet 05 Feb '10

05 Feb '10

On 5 February 2010 05:09, David Adam <david.adam.cnrs(a)gmail.com> wrote: > This patch is from Tony Wasserka. It comes from his git repertory. He > authorized to pick up patches (see Wine-devel) to submit to Wine. > I just cleanup it a little bit. I let Tony as the author of this patch. All > the tests pass in a real Windows Vista box. > Looks more complicated than needed.

1 0

Re: Today's git has unimplemented function msxml4 leading to stack dump when installing dragon naturallyspeaking
by Susan Cragin 04 Feb '10

04 Feb '10

>On 2/4/2010 00:08, Susan Cragin wrote: >> wine-1.1.37-412-g9a92f9c >> With today's git got a debug, dump, etc., while installing dragon naturallyspeaking. >> have log >> >> wine: Call from 0x7b8364e2 to unimplemented function msxml4.dll.DllRegisterServer, aborting >> wine: Unimplemented function msxml4.dll.DllRegisterServer called at address 0x7b8364e2 (thread 0027), starting debugger... >> >Susan, please try with current, patch is in. Let me know if you still >have a problem with it. Bug has gone.... BTW -- DNS did install yesterday even with the bug.

1 0

Today's git has unimplemented function msxml4 leading to stack dump when installing dragon naturallyspeaking
by Susan Cragin 04 Feb '10

04 Feb '10

wine-1.1.37-412-g9a92f9c With today's git got a debug, dump, etc., while installing dragon naturallyspeaking. have log wine: Call from 0x7b8364e2 to unimplemented function msxml4.dll.DllRegisterServer, aborting wine: Unimplemented function msxml4.dll.DllRegisterServer called at address 0x7b8364e2 (thread 0027), starting debugger... --------------------------------- relevant portion below --------------------------------- fixme:reg:GetNativeSystemInfo (0x8b1754) using GetSystemInfo() fixme:msi:msi_unimplemented_action_stub SetODBCFolders -> 234 ignored L"Directory" table values fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies -> 8 ignored L"MsiAssembly" table values fixme:msi:msi_unimplemented_action_stub SelfUnregModules -> 1 ignored L"SelfReg" table values wine: Call from 0x7b8364e2 to unimplemented function msxml4.dll.DllRegisterServer, aborting wine: Unimplemented function msxml4.dll.DllRegisterServer called at address 0x7b8364e2 (thread 0027), starting debugger... Unhandled exception: unimplemented function msxml4.dll.DllRegisterServer called in 32-bit code (0x7b8364e2). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7b8364e2 ESP:0033fd24 EBP:0033fd88 EFLAGS:00000207( - -- I - -P-C) EAX:7b826105 EBX:7b881ff4 ECX:33b50814 EDX:0033fd44 ESI:80000100 EDI:00110429 Stack dump: 0x0033fd24: 0033fda8 00000008 0000003c 80000100 0x0033fd34: 00000001 00000000 7b8364e2 00000002 0x0033fd44: 33b50814 33b50831 68311ff4 33b40000 0x0033fd54: 0033fd74 0033fd88 7b84e9dd 33b40000 0x0033fd64: 0033fd74 00000000 0033fd7c 7ffd8c00 0x0033fd74: 00120011 6830ff9d 7b83649a 68311ff4 Backtrace: =>0 0x7b8364e2 RaiseException+0x52(code=2147483904, flags=1, nbargs=2, args=0x33fda8) [/home/susan/wine/dlls/kernel32/except.c:84] in kernel32 (0x0033fd88) 1 0x33b507b8 __wine_spec_unimplemented_stub+0x38(module="msxml4.dll", function="DllRegisterServer") [/home/susan/wine/dlls/winecrt0/stub.c:34] in msxml4 (0x0033fdb8) 2 0x33b50588 __wine_stub_DllUnregisterServer() in msxml4 (0x0033fe58) 3 0x6830fe0c __wine_spec_exe_entry+0x7c(peb=0x7ffdf000) [/home/susan/wine/dlls/winecrt0/exe_entry.c:37] in regsvr32 (0x0033fea8) 4 0x7b8586d4 start_process+0x54(peb=<register ESI not in topmost frame>) [/home/susan/wine/dlls/kernel32/process.c:1026] in kernel32 (0x0033fee8) 5 0x7bc6ed54 call_thread_func+0xc() in ntdll (0x0033fef8) 6 0x7bc6ef20 call_thread_entry_point+0x70(entry=0x7b858680, arg=0x7ffdf000) [/home/susan/wine/dlls/ntdll/signal_i386.c:2426] in ntdll (0x0033ffc8) 7 0x7bc4aefa in ntdll (+0x3aefa) (0x0033ffe8) 0x7b8364e2 RaiseException+0x52 [/home/susan/wine/dlls/kernel32/except.c:84] in kernel32: subl $4,%esp 84 RtlRaiseException( &record ); Modules: Module Address Debug info Name (70 modules) ELF 33b3f000-33b53000 Dwarf msxml4<elf> \-PE 33b40000-33b53000 \ msxml4 ELF 68000000-6801d000 Deferred ld-linux.so.2 ELF 6801d000-68158000 Deferred libwine.so.1 ELF 68158000-68171000 Deferred libpthread.so.0 ELF 68171000-682c5000 Deferred libc.so.6 ELF 682c5000-682c9000 Deferred libdl.so.2 ELF 682c9000-682d1000 Deferred libnss_compat.so.2 ELF 682d1000-682e8000 Deferred libnsl.so.1 ELF 682e8000-682f2000 Deferred libnss_nis.so.2 ELF 682f2000-682fe000 Deferred libnss_files.so.2 ELF 682fe000-68313000 Dwarf regsvr32<elf> \-PE 68300000-68313000 \ regsvr32 ELF 68313000-6836b000 Deferred advapi32<elf> \-PE 68320000-6836b000 \ advapi32 ELF 6836b000-683db000 Deferred rpcrt4<elf> \-PE 68380000-683db000 \ rpcrt4 ELF 683db000-684e8000 Deferred user32<elf> \-PE 683f0000-684e8000 \ user32 ELF 684e8000-68572000 Deferred gdi32<elf> \-PE 684f0000-68572000 \ gdi32 ELF 68572000-68610000 Deferred krnl386.exe16.so PE 68580000-68610000 Deferred krnl386.exe16 ELF 68610000-68625000 Deferred system.drv16.so PE 68620000-68625000 Deferred system.drv16 ELF 68625000-68639000 Deferred comm.drv16.so PE 68630000-68639000 Deferred comm.drv16 ELF 68639000-68664000 Deferred gdi.exe16.so PE 68640000-68664000 Deferred gdi.exe16 ELF 68664000-686da000 Deferred libfreetype.so.6 ELF 686da000-686ef000 Deferred libz.so.1 ELF 686ef000-6871f000 Deferred libfontconfig.so.1 ELF 6871f000-68746000 Deferred libexpat.so.1 ELF 68746000-68788000 Deferred user.exe16.so PE 68750000-68788000 Deferred user.exe16 ELF 68788000-687ab000 Deferred mpr<elf> \-PE 68790000-687ab000 \ mpr ELF 687ab000-687c0000 Deferred display.drv16.so PE 687b0000-687c0000 Deferred display.drv16 ELF 687c0000-687d5000 Deferred keyboard.drv16.so PE 687d0000-687d5000 Deferred keyboard.drv16 ELF 687d5000-687e9000 Deferred mouse.drv16.so PE 687e0000-687e9000 Deferred mouse.drv16 ELF 687e9000-68888000 Deferred winex11<elf> \-PE 68800000-68888000 \ winex11 ELF 68888000-68891000 Deferred libsm.so.6 ELF 68891000-688aa000 Deferred libice.so.6 ELF 688aa000-688ba000 Deferred libxext.so.6 ELF 688ba000-689d7000 Deferred libx11.so.6 ELF 689d7000-689dc000 Deferred libuuid.so.1 ELF 689dc000-689f6000 Deferred libxcb.so.1 ELF 689f6000-689fa000 Deferred libxau.so.6 ELF 689fa000-68a00000 Deferred libxdmcp.so.6 ELF 68a00000-68a21000 Deferred imm32<elf> \-PE 68a10000-68a21000 \ imm32 ELF 68a21000-68a25000 Deferred libxinerama.so.1 ELF 68a25000-68a2b000 Deferred libxxf86vm.so.1 ELF 68a2b000-68a35000 Deferred libxrender.so.1 ELF 68a35000-68a3b000 Deferred libxfixes.so.3 ELF 68a3b000-68a45000 Deferred libxcursor.so.1 ELF 6ae42000-6af3f000 Deferred ole32<elf> \-PE 6ae60000-6af3f000 \ ole32 ELF 6d30c000-6d315000 Deferred libxrandr.so.2 ELF 6e429000-6e42d000 Deferred libxcomposite.so.1 ELF 7753e000-77564000 Deferred libm.so.6 ELF 7b800000-7b93a000 Dwarf kernel32<elf> \-PE 7b810000-7b93a000 \ kernel32 ELF 7bc00000-7bcb5000 Dwarf ntdll<elf> \-PE 7bc10000-7bcb5000 \ ntdll ELF 7bf00000-7bf04000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000008 setup.exe 00000009 0 0000000e services.exe 00000015 0 00000014 0 00000010 0 0000000f 0 00000011 winedevice.exe 00000016 0 00000013 0 00000012 0 00000018 explorer.exe 00000019 0 0000001a vcruntime.exe 0000001b 0 0000001c msiexec.exe 00000020 0 0000001d 0 00000026 (D) C:\windows\system32\regsvr32.exe 00000027 0 <== Backtrace: =>0 0x7b8364e2 RaiseException+0x52(code=2147483904, flags=1, nbargs=2, args=0x33fda8) [/home/susan/wine/dlls/kernel32/except.c:84] in kernel32 (0x0033fd88) 1 0x33b507b8 __wine_spec_unimplemented_stub+0x38(module="msxml4.dll", function="DllRegisterServer") [/home/susan/wine/dlls/winecrt0/stub.c:34] in msxml4 (0x0033fdb8) 2 0x33b50588 __wine_stub_DllUnregisterServer() in msxml4 (0x0033fe58) 3 0x6830fe0c __wine_spec_exe_entry+0x7c(peb=0x7ffdf000) [/home/susan/wine/dlls/winecrt0/exe_entry.c:37] in regsvr32 (0x0033fea8) 4 0x7b8586d4 start_process+0x54(peb=<register ESI not in topmost frame>) [/home/susan/wine/dlls/kernel32/process.c:1026] in kernel32 (0x0033fee8) 5 0x7bc6ed54 call_thread_func+0xc() in ntdll (0x0033fef8) 6 0x7bc6ef20 call_thread_entry_point+0x70(entry=0x7b858680, arg=0x7ffdf000) [/home/susan/wine/dlls/ntdll/signal_i386.c:2426] in ntdll (0x0033ffc8) 7 0x7bc4aefa in ntdll (+0x3aefa) (0x0033ffe8) wine: Call from 0x7b8364e2 to unimplemented function msxml4.dll.DllRegisterServer, aborting fixme:mscoree:LoadLibraryShim (0x746cdf8c L"fusion.dll", (nil), (nil), 0x33f90c): semi-stub

3 3

chromium in wine now works with gmail
by Dan Kegel 04 Feb '10

04 Feb '10

This message is being sent in gmail in Chromium running on Wine with options --no-sandbox --use-nss-for-ssl. (--use-nss-for-ssl turns on a new alternate https stack that works in wine.) This copy of Chromium was built in Wine, too. It took 1 hour 55 minutes to compile and link from scratch using Visual C++ 2005 in Wine on a q9300. (And that's compiling with /MP to use all cores; wthout /MP, it takes three and a half hours, IIRC.) See http://wiki.winehq.org/BuildAndTestChromium for easy instructions on how to do this. - Dan

6 7

Re: chromium in wine now works with gmail
by Dan Kegel 04 Feb '10

04 Feb '10

The 'new' ssl stack is just the one from Firefox. On Linux, chromium uses the system's ssl. On Feb 4, 2010 7:11 AM, "Ben Klein" <shacklein(a)gmail.com> wrote: On 5 February 2010 01:54, Dan Kegel <dank(a)kegel.com> wrote: > This message is being sent in gmail in... Google seriously needs to depend on system libraries rather than build the whole damned thing themselves. I can forgive them for rolling their own webkit, but with gigabytes of space required to compile and almost 2 hours on that high-speed quadcore ... No, they're doing something wrong. In other news, well done with getting it to work! > See http://wiki.winehq.org/BuildAndTestChromium for easy > instructions on how to do this. > - Da...

1 0

Re: kernel32: Add support for InterlockedCompareExchange64
by Alexandre Julliard 04 Feb '10

04 Feb '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > +extern inline LONG WINAPI InterlockedCompareExchange64( LONG64 volatile *dest, LONG64 xchg, LONG64 compare ); > +extern inline LONG WINAPI InterlockedCompareExchange64( LONG64 volatile *dest, LONG64 xchg, LONG64 compare ) > +{ > + LONG64 ret; > + __asm__ __volatile__( "lock; cmpxchg8b (%1)" > + : "=a" (ret) : "r" (dest), "r" (xchg), "0" (compare) : "memory" ); > + return ret; > +} This can't possibly work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] shlwapi/tests: Use defined settings, when testing GetAcceptLanguages
by Alexandre Julliard 04 Feb '10

04 Feb '10

Detlef Riekenberg <wine.dev(a)web.de> writes: > The old tests depend on user language settings, used > SetLastError(ERROR_SUCCESS) before and GetLastError() > after the api call for a function, that returns a HRESULT > and didn't know how the default language fallback works > > Tested on all winetestbot machines It doesn't work on Wine: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so ordinal.c && touch ordinal.ok ordinal.c:92: Test failed: RegOpenKey(Software\Microsoft\Internet Explorer\International) failed: 2 make[2]: *** [ordinal.ok] Error 1 Also please fix the compiler warnings before resending. -- Alexandre Julliard julliard(a)winehq.org

1 0

mmdevapi update
by Maarten Lankhorst 04 Feb '10

04 Feb '10

Hi all, Just thought I'd post an update on my work, after working a few weeks on it I am finally at the point where the first applications that use this new sound api start to work. Currently it's at http://repo.or.cz/w/wine/multimedia.git/shortlog/refs/heads/mmdevapi but I will clean it up, split it into separate patches and merge it back to wine slowly. So far the only 'application' that will work is directsound from windows 7. World of warcraft tries to use mmdevapi if you set the windows version to 7, and the main screen sound works, if you change dlls/mmdevapi/audio.c AL_FORMAT_STEREO_FLOAT32 to AL_FORMAT_STEREO16, but that will break dsound. It's not ready for mainstream use yet, but I thought it would be nice to post this update. Note that you most likely won't get any sound if you try it yourself, I only tested a simple dsound playback application, left4dead2+win7 dsound for example seems completely silent after the intro, and many things simply aren't handled yet. It's also untested on the mac, but it probably works there, since I use no specific extension. However, this code means that it should eventually be possible to port dsound over to use openal, after mmdevapi is done. Cheers, Maarten.

1 0

Re: [1/2] server: store each window's drop target
by Alexandre Julliard 04 Feb '10

04 Feb '10

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > * server: store each window's drop target > > The patch series allows OLE drag and drop to work across process boundaries. ole32 has no business making wineserver calls. This should go through standard user32 functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] wined3d: Remove the unused device type parameter from the fragment pipe's get_caps() function.
by Stefan Dösinger 04 Feb '10

04 Feb '10

Am 03.02.2010 um 18:17 schrieb Henri Verbeet: > On the subject of actually supporting software devices, we should probably > implement those by creating a software or reference adapter with appropriate > gl_info and pipe implementations and creating a device based on that. Wouldn't that conflict with how adapters work in the d3d8/9 API? There an adapter identifies the display hardware, not necessarily the rendering device. Or, to phrase it in API terms: > static HRESULT WINAPI IWineD3DImpl_CreateDevice(IWineD3D *iface, UINT adapter_idx, > WINED3DDEVTYPE device_type, HWND focus_window, DWORD flags, IUnknown *parent, > IWineD3DDeviceParent *device_parent, IWineD3DDevice **device) You'd want to remove device_type from here as well if we merge it into the adapter(and then deal with splitting up wined3d adapters into d3d8/9 adapters and device types in the client libs)

2 2

Check out my photos on Facebook
by Kirn Gill 04 Feb '10

04 Feb '10

Hi Wine-devel, I set up a Facebook profile where I can post my pictures, videos and events and I want to add you as a friend so you can see it. First, you need to join Facebook! Once you join, you can also create your own profile. Thanks, Kirn To sign up for Facebook, follow the link below: http://www.facebook.com/p.php?i=1311167334&k=Z3D4XXPXVZT14JDIWK662USUVWFJ5T… Already have an account? Add this email address to your account http://www.facebook.com/n/?merge_accounts.php&e=wine-devel@winehq.org&c=af7… was invited to join Facebook by Kirn Gill. If you do not wish to receive this type of email from Facebook in the future, please click on the link below to unsubscribe. http://www.facebook.com/o.php?k=dd3238&u=728096903&mid=1d44feaG2b65e087G0G8 Facebook's offices are located at 1601 S. California Ave., Palo Alto, CA 94304.

1 0

make crosstest issue
by Christian Costa 03 Feb '10

03 Feb '10

Hi, make crosstest gives the following output : ../../../tools/winegcc/winegcc -b i586-mingw32msvc -B../../../tools/winebuild --sysroot=../../.. --lib-suffix=.cross.a d3drm.cross.o vector.cross.o testlist.cross.o -o d3drm_crosstest.exe -lkernel32 /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/bin/ld: cannot find -lwinecrt0 collect2: ld a retourné 1 code d'état d'exécution winegcc: i586-mingw32msvc-gcc failed make: *** [d3drm_crosstest.exe] Erreur 2 This was working before. Any Idea ? Bye Christian

3 3

Wine FIXME Report 2009 Aug - Dec
by Michael Stefaniuc 03 Feb '10

03 Feb '10

Hello! Introduction ============ Back at the last WineConf after the wineoops presentation I have been asked if the wineoops could collect FIXME/ERR messages too and do some statistics on those. Well, it doesn't and I didn't want to introduce scope creep thus this new "project" winefixme was created (while reusing a lot of code). As the complexity of this problem is a lot easier than the one tackled by wineoops it goes into "production" first. After this initial report covering the month August to December of 2009 I will do a monthly report at the beginning of every month covering the previous month; the report for January 2010 is to be expected in the first week of February 2010. Wine FIXME Report 2009 Aug to Dec ================================= The data for this report comprise the emails from the 2009 Aug to Dec archives of the mailing lists wine-{bugs,devel,users} as well as the bugzilla attachments referenced by the wine-bugs emails. Although WARN messages were collected too they aren't handled in this report. File parsed: 35369 (emails: 32631, bugzilla attachments: 2738) Files with FIXME/ERR/WARN: 2256 Type | Total | Unique ------+--------+-------- fixme | 170639 | 36113 err | 67789 | 2958 warn | 29367 | 9283 The Most Popular Messages ------------------------- This are the most prevalent ERR and FIXME messages aka the number of files where they show up. FIXME: Files | Lines | Channel:Text ------+-------+------------- 220 | 246 | system:SetProcessDPIAware stub! 213 | 285 | iphlpapi:GetAdaptersAddresses no support for IPv6 addresses 209 | 559 | d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface 209 | 877 | shell:DllCanUnloadNow stub 133 | 501 | urlmon:URLMoniker_BindToObject use running object table 110 | 118 | resource:GetGuiResources (0xffffffff,0): stub 94 | 386 | shdocvw:BindStatusCallback_OnProgress status code 11 81 | 1002 | wininet:InternetLockRequestFile STUB 79 | 125 | msi:ACTION_HandleStandardAction unhandled standard action L"SetODBCFolders" 76 | 269 | advapi:DeregisterEventSource (0xcafe4242) stub ERR: Files | Lines | Channel:Text ------+-------+------------- 77 | 99 | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1 75 | 98 | ole:CoGetClassObject class {9a5ea990-3034-4d6f-9128-01f3c61022bc} not registered 58 | 3052 | ole:CoCreateInstance apartment not initialised 57 | 139 | alsa:ALSA_CheckSetVolume Could not find 'PCM Playback Volume' element 52 | 87 | ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. 52 | 84 | ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. 46 | 92 | ole:CoUninitialize Mismatched CoUninitialize 45 | 89 | ole:CoGetClassObject no class object {6c736db1-bd94-11d0-8a23-00aa00b58e10} could be created for context 0x1 45 | 186 | ole:CoInitializeEx Attempt to change threading model of this apartment from apartment threaded to multi-threaded 44 | 88 | ole:CoGetClassObject class {6c736db1-bd94-11d0-8a23-00aa00b58e10} not registered The Top Ten Single Charts ------------------------- This are the messages with the most occurrences in a single file. FIXME: Lines | Files | Channel:Text ------+-------+------------- 5270 | 1 | d3d_surface:surface_download_data Read back converted textures unsupported, format=WINED3DFMT_B5G6R5_UNORM 3436 | 1 | d3d7:IDirect3DDeviceImpl_3_SetLightState D3DLIGHTSTATE_MATERIAL called with NULL material !!! 2456 | 1 | d3d_surface:surface_load_ds_location (0x1a7c50) Not supported with fixed up depth stencil 2346 | 4 | mlang:fnIMultiLanguage2_ConvertStringToUnicodeEx 1852 | 36 | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000109 1468 | 1 | d3d_draw:drawStridedInstanced >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glDrawElements @ drawprim.c / 547 1451 | 1 | ddraw:IDirectDrawImpl_WaitForVerticalBlank (0xa2204e0)->(1,0x0): Stub 1430 | 1 | d3d:IWineD3DSwapChainImpl_Present Unhandled present options 0x32fc94/0x32fca4 1404 | 6 | rpc:NdrStubCall2 new correlation description not implemented 1279 | 1 | rpc:RpcImpersonateClient ((nil)): stub ERR: Lines | Files | Channel:Text ------+-------+------------- 3561 | 3 | win:DefWindowProcW called for other process window 0x10020 3110 | 6 | d3d:resource_init Out of adapter memory 3110 | 2 | ddraw:IDirectDrawImpl_CreateNewSurface IWineD3DDevice::CreateSurface failed. hr = 8876017c 3098 | 2 | ddraw:IDirectDrawImpl_CreateSurface IDirectDrawImpl_CreateNewSurface failed with 8876017c 2436 | 2 | d3d_surface:IWineGDISurfaceImpl_LockRect heapMemory=(nil) allocatedMemory=0x1b50000 dib.bitmap_data=0x1b50000 1217 | 2 | d3d_surface:IWineGDISurfaceImpl_LockRect heapMemory=(nil) allocatedMemory=0x1a60000 dib.bitmap_data=0x1a60000 751 | 2 | ole:CoGetClassObject no class object {33246f92-d56f-4e34-837a-9a49bfc91df3} could be created for context 0x4 750 | 2 | ole:create_server class {33246f92-d56f-4e34-837a-9a49bfc91df3} not registered 700 | 1 | d3d_surface:IWineD3DBaseSurfaceImpl_CreateDIBSection CreateDIBSection failed! 584 | 58 | ole:CoCreateInstance apartment not initialised The Most Chatty Channels ------------------------ Includes the ERR and FIXME messages for a channel sorted by the number of lines. Channel | Lines -----------+------ d3d | 34496 d3d_surface| 19381 ole | 19172 shdocvw | 16462 ddraw | 15058 shell | 13980 msi | 9177 dinput | 8476 win | 6566 wininet | 5625 Further Info: ------------- The sqlite3 database and the SQL commands to output the above info can be downloaded from http://people.redhat.com/mstefani/winefixme/reports/200908-200912/ Questions and feedback are welcome! bye michael

9 13

Re: [PATCH] msi: call Custom function via wrapper
by Henri Verbeet 03 Feb '10

03 Feb '10

On 3 February 2010 16:57, Marcus Meissner <meissner(a)suse.de> wrote: > The difference to other packages is that 11.2 Wine builts with > -fomit-frame-pointer. > Sounds like a questionable thing to do, this is probably not the only place where the frame pointer saves broken applications.

1 0

Re: d3d10/test: Add effect shader test.
by Stefan Dösinger 03 Feb '10

03 Feb '10

Am 03.02.2010 um 18:52 schrieb Rico Schüller: > Hi, > > this patch adds a test case for d3d10 shader parsing and ID3D10EffectPass::Get*ShaderDesc() functions. > +static DWORD fx_local_shader[] = { > +0x43425844, 0x95577e13, 0xab5facae, 0xd06d9eab, > +0x8b127be0, 0x00000001, 0x00001652, 0x00000001, > ... the binary shader is pretty long. Wouldn't it be better to load the bytes from an external file, or if that makes the tests too complicated, put the DWORD[] into a separate .c or .h file? > + hr = D3D10CreateEffectFromMemory(fx_local_shader, fx_local_shader[6], 0, device, NULL, &effect); Is there a reason for using fx_local_shader[6] instead of sizeof(fx_local_shader)? I see that the other tests do it as well.

3 2

Re: [PATCH 1/5] qedit: Mostly stubbed out implementation of SampleGrabber filter
by Alexandre Julliard 03 Feb '10

03 Feb '10

Paul Chitescu <paulc(a)voip.null.ro> writes: > +/* Macro to get the SampleGrabber This pointer from interface pointer */ > +#define GET_THIS(ptr,iface) ((SG_Impl *)((char *)(ptr) - FIELD_OFFSET(SG_Impl,iface ## _Vtbl))) Please define an inline function for that sort of thing. Look at shelllink.c for examples. -- Alexandre Julliard julliard(a)winehq.org

2 2

re: msi: copy InstallerImpl_LastErrorRecord to use it for DatabaseImpl (resend)
by Dan Kegel 03 Feb '10

03 Feb '10

André Hentschel wrote > makes the installer in http://tinyurl.com/y9gy6c4 run farther Thanks for including the link. (For the curious, see http://www.boschrexroth.com/business_units/brc/de/information_de/software_d… http://www.boschrexroth.com/country_units/america/united_states/en/products… It looks like a pretty cool CAD simulation package.)

1 0

Re: [PATCH] mdi: fix drawing the MDI client area when creating children.
by Alexandre Julliard 03 Feb '10

03 Feb '10

Reece Dunn <msclrhd(a)googlemail.com> writes: > diff --git a/dlls/user32/mdi.c b/dlls/user32/mdi.c > index 631d477..0850282 100644 > --- a/dlls/user32/mdi.c > +++ b/dlls/user32/mdi.c > @@ -1132,6 +1132,7 @@ LRESULT MDIClientWndProc_common( HWND hwnd, UINT message, WPARAM wParam, LPARAM > hwnd, 0, csA->hOwner, > (LPVOID)csA->lParam); > } > + InvalidateRect(hwnd, NULL, TRUE); > return (LRESULT)child; The window should have been exposed and repainted when the children got resized. If this doesn't happen it's a bug, but invalidating by hand is only hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] d3dx9: Partial implementation of D3DXAssembleShader function.
by Henri Verbeet 03 Feb '10

03 Feb '10

On 2 February 2010 18:11, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > +void wpp_write_message_var(const char *fmt, ...) This is probably not strictly required, but if you add the gcc format attribute to the function, gcc will check if the parameters types match the ones in the format string. You can look at the PRINTF_ATTR macro in dlls/wined3d/wined3d_private and similar macros in other places for examples. > + if(current_include == NULL) > + { > + ERR("current_include == NULL, desc == %p, buffer = %s\n", > + desc, desc->buffer); > + HeapFree(GetProcessHeap(), 0, desc); > + return; > + } > + ID3DXInclude_Close(current_include, desc->buffer); > + HeapFree(GetProcessHeap(), 0, desc); > + return; Something like the following is probably nicer: + if (current_include) + ID3DXInclude_Close(current_include, desc->buffer); + else + ERR("current_include == NULL, desc == %p, buffer = %s\n", desc, desc->buffer); + + HeapFree(GetProcessHeap(), 0, desc); + return; > + struct wpp_callbacks wpp_callbacks = { > + wpp_lookup_mem, > + wpp_open_mem, > + wpp_close_mem, > + wpp_read_mem, > + wpp_write_mem, > + wpp_error, > + wpp_warning, > + }; This should be static const. > + TRACE("Shader source:\n"); > + for(i=0;i<data_len;i++) > + { > + TRACE("%c", data[i]); > + } > + TRACE("\n"); This doesn't look right. You should be using debugstr_an(), since this is external data you're tracing.

1 0

Re: [PATCH 2/2] d3drm: Improve IDirect3DRMMeshBuilderImpl_Load and corresponding test
by Paul Vriens 03 Feb '10

03 Feb '10

On 02/03/2010 08:38 AM, Christian Costa wrote: > > --- > > dlls/d3drm/meshbuilder.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- > dlls/d3drm/tests/d3drm.c | 32 ++++++++++++++++++++++++-------- > 2 files changed, 69 insertions(+), 9 deletions(-) > > > > Hi Christian, I ran your tests on winetestbot and it shows some failures on several platforms: https://winetestbot.geldorp.nl/JobDetails.pl?Key=562 -- Cheers, Paul.

2 1

Re: [PATCH 4/5] d3drm: Add some tests
by Stefan Dösinger 03 Feb '10

03 Feb '10

On Monday 01 February 2010 08:18:42 Christian Costa wrote: > +void Test(void) > +{ > ... > Test(); I think the function name Test() won't be too helpful once more tests are added. You can also make it static, unless you plan to call it from another .c file.

3 7

Re: [1/2] msxml3/doc: Implement IXMLDOMDocument::get_url() with some tests
by Jacek Caban 03 Feb '10

03 Feb '10

Hi Nikolay, On 2/2/10 11:23 PM, Nikolay Sivov wrote: > Implement IXMLDOMDocument::get_url() with some tests > You probably should use GetDisplayName result of moniker used to load the document to obtain its URL. Thanks, Jacek

2 2

re: msi: copy InstallerImpl_LastErrorRecord to use it for DatabaseImpl
by Dan Kegel 02 Feb '10

02 Feb '10

> makes an installer run farther Please, when posting patches like that, mention *which* installer, unless you have some good reason to keep it private. Thanks!

1 0

Several msxmlX modules
by Nikolay Sivov 02 Feb '10

02 Feb '10

Hi. Wine currently has only one module for MSXML parser - msxml3. Since the third one v4 and v6 are already out. Judging from file size I don't think native modules reuse some code between them, instead it looks like a completely independent builds. What Wine's policy should be about that? Is that really necessary to have several modules to look like native does (forwarding class creation to msxml3 of course)? The other way is a bit misleading - having msxml3 that responds to v4 interface creation I mean (and lot of application depend on version fourth today). After that I thought about renaming msxml3 to msxml but I'm not sure that won't break some apps. I'd like to see some opinions on this.

3 5

Re: ws2_32: Fix parameter validation order in getpeername.
by Alexandre Julliard 02 Feb '10

02 Feb '10

Andrew Nguyen <arethusa26(a)gmail.com> writes: > Invalid pointers appear to be handled by getpeername in all versions > of Windows, so adding an exception handler seems to be justified. It's only justified if there is a real app that passes a bad pointer that is not the result of some other Wine bug. Please provide more details. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] userenv: Implement DestroyEnvironmentBlock().
by Maarten Lankhorst 02 Feb '10

02 Feb '10

Hi Lei, 2010/2/2 Lei Zhang <thestig(a)google.com>: > Hi, > > Over the weekend, someone wrote a Chromium base unit test that calls > DestroyEnvironmentBlock(). So I guess it's time to implement it. The > modified Wine test case passed on my WinXP machine. Are you sure that DestroyEnvironmentBlock needs that null pointer check? ~Maarten

2 1

Re: [1/3] gdiplus: Implement GdipSetImageAttributesGamma.
by Paul Vriens 02 Feb '10

02 Feb '10

On 01/31/2010 02:03 AM, Vincent Povirk wrote: > + stat = GdipBitmapGetPixel(bitmap2, 0, 0,&color); > + expect(Ok, stat); > + todo_wine expect(0xff20ffff, color); Hi Vincent, This one introduces a test failure on what appears to be mostly VMware boxes. Not all VMware boxes show this failure btw and I did see the same failure on a real WinMe box. Would a color_match (like we use in several other tests) be more appropriate or maybe a broken()? -- Cheers, Paul.

2 1

Re: [PATCH 1/5] qedit: Mostly stubbed out implementation of SampleGrabber filter
by Nikolay Sivov 02 Feb '10

02 Feb '10

On 2/2/2010 16:21, Paul Chitescu wrote: > Changelog: > qedit: Mostly stubbed out implementation of SampleGrabber filter > > Until the last patch component is applied most application will crash as they > rarely check for errors. > > + if (IsEqualIID(riid,&IID_IUnknown) || > + IsEqualIID(riid,&IID_IPersist) || > + IsEqualIID(riid,&IID_IMediaFilter) || > + IsEqualIID(riid,&IID_IBaseFilter)) { > + InterlockedIncrement(&This->refCount); > + *ppvObject =&(This->IBaseFilter_Vtbl); > + return S_OK; > + } > You should use ISampleGrabber_AddRef() here on success to keep increment call in one place. It's a common practice as far as i can see in Wine code.

2 1

user32: A window is after a call to SetParent invisible when hwnd and newParent is equal (bug 21497)
by Bernhard Übelacker 02 Feb '10

02 Feb '10

(Resent, my first mail has not appeared on the list?) Hello, in SetParent the window (hwnd) get hidden by ShowWindow( hwnd, SW_HIDE ), then a call to wineserver is done and then the window is made visible again. If this call to wineserver fails the window stays invisible. This patch at least avoids this when hwnd and newParent is equal. (If there are other cases this call could fail the window stays invisble.) It could be observed in http://bugs.winehq.org/show_bug.cgi?id=21497 I want to ask for some comments what to change or if it could be sent to wine-patches as it is? Kind regards Bernhard --- dlls/user32/tests/win.c | 6 ++++++ dlls/user32/win.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 6fb6ce0..82caccb 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -445,6 +445,12 @@ static void test_parent_owner(void) ret = SetParent( test, child ); ok( ret == desktop, "SetParent return value %p expected %p\n", ret, desktop ); check_parents( test, child, child, 0, 0, hwndMain, test ); + + ShowWindow( test, SW_SHOW ); + ret = SetParent( test, test ); + ok( ret == NULL, "SetParent return value %p expected %p\n", ret, NULL ); + ok( GetWindowLongA( test, GWL_STYLE ) & WS_VISIBLE, "window is not visible after SetParent\n" ); + check_parents( test, child, child, 0, 0, hwndMain, test ); DestroyWindow( test ); /* owned popup */ diff --git a/dlls/user32/win.c b/dlls/user32/win.c index acf70a3..8308ba8 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -2690,8 +2690,8 @@ HWND WINAPI SetParent( HWND hwnd, HWND parent ) return 0; } - /* Some applications try to set a child as a parent */ - if (IsChild(hwnd, parent)) + /* Some applications try to set a child as a parent or itself */ + if (IsChild(hwnd, parent) || hwnd == parent) { SetLastError( ERROR_INVALID_PARAMETER ); return 0; -- 1.6.5

1 0

Qemu using the appdb code for their OS support list.
by Paul Vriens 02 Feb '10

02 Feb '10

Hi, Just saw this: http://www.claunia.com/qemu/ -- Cheers, Paul.

1 0

MS installer frustration: "compressed file wasn't extracted"
by Dan Kegel 02 Feb '10

02 Feb '10

Now that plain old Visual C++ 2005 installs pretty well, I've been trying to get Visual C++ 2005 sp1 and Visual C++ 2008 to install. The latter requires .net 3.5. And all of them appear to be blocked by "err:msi:ACTION_InstallFiles compressed file wasn't extracted", http://bugs.winehq.org/show_bug.cgi?id=20110 Grrr. On the bright side, with Jaun's fix today, .net 3.0's runtime installer seems to kinda work.

1 0

New winetricks 20100201: new verbs d3dx10, directx-beta, ddr=, mspaint, multisampling=, rtlm=, sound=disabled, usp10, vc2005hotfix, vc2005load/vc2005save,
by Dan Kegel 02 Feb '10

02 Feb '10

Oh, my, we've been busy. Lots and lots of improvements. Runs better on Windows, too. Cygwin is kinda broken with current wine, so we've rewound back to an old version, but you have to copy and paste a URL from winetricks' output into the mirror selector to use it. Sigh. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Dan Kegel: Add AF's speedup to dotnet30 verb; unpack dotnet35 before running its setup. Remove trailing CR in programfilesdir_win; add vc2005save and vc2005load verbs fix glaring thinko in how we decided whether to run gksudo (i.e. it was horribly broken) Quote more paths Abort if sudo or gksudo fails Work around strange NULs in argument to zenity Internatinalize VirtualCloneDrive code. Support caching cygwin packages (manually for now) Finished vc2005hotfix verb Fixed WINETRICKS_CACHE_WIN value on XP Make vc2005trial verb work on XP Make vcrun2005 work on windows. vc2005trial verb returned before install was really done, tsk. Fix bad font check Work around wine bug 21206, fix cygwin for now by using an old copy. Fix calls to try_regedit to also work on Windows Fix append_path to work on both Windows and Linux (though maybe not solaris?) Austin English: Update shockwave sha1sum Add d3dx10 verb Fix icodec url Add native MSPaint verb. Woohoo stick figures! Fix permission checkign on symlink'ed $HOME's (issue 88) Add option to disable sound (Issue 87) Bump firefox to 3.5.6 Add multisampling enable/disable options Add directdrawrenderer gdi/opengl options Add RenderTargetLockMode override options winetrickstest: move vc2005express to broken, add a note in winetricks Add directx-beta verb (winver=XP, not 2k). Fixes winezeug 71. Andrew Nguyen: Suppress error output from xlsfonts. Hans Leidekker: Add usp10 verb

1 0

Re: msi: Fix crash with access to component
by Hans Leidekker 01 Feb '10

01 Feb '10

On Saturday 30 January 2010 12:55:21 André Hentschel wrote: > --- > dlls/msi/files.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/msi/files.c b/dlls/msi/files.c > index 7e74dca..afeb451 100644 > --- a/dlls/msi/files.c > +++ b/dlls/msi/files.c > @@ -363,6 +363,8 @@ static UINT ITERATE_DuplicateFiles(MSIRECORD *row, LPVOID param) > { > TRACE("Skipping copy due to disabled component %s\n", > debugstr_w(component)); > + if (!comp) > + return ERROR_INSTALL_FAILURE; > > /* the action taken was the same as the current install state */ > comp->Action = comp->Installed; Where do you see that crash? Are you sure ERROR_INSTALL_FAILURE is appropriate? -Hans

3 2

Re: msi: Don't fail if the service to start is already running.
by Paul Vriens 01 Feb '10

01 Feb '10

On 02/01/2010 09:55 AM, Hans Leidekker wrote: > + > + scm = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); > + ok(scm != NULL, "Failed to open the SC Manager\n"); > + > + service = OpenService(scm, "TermService", SC_MANAGER_ALL_ACCESS); > + ok(service != NULL, "Failed to open TermService\n"); Hi Hans, Win9x/WinMe don't have the notion of services. 'TermService' is not available on all platforms. We could use 'Spooler' and bail out if we get ERROR_SERVICE_DOES_NOT_EXIST? Let me know and I'll create/send a patch. -- Cheers, Paul.

2 4

Re: [2/5] WineD3D: Implement dynamic buffers with GL_ARB_map_buffer_range
by Henri Verbeet 01 Feb '10

01 Feb '10

On 1 February 2010 13:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > On Monday 01 February 2010 11:27:48 Henri Verbeet wrote: >> On 30 January 2010 12:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> > + const struct wined3d_gl_info *gl_info = >> > &device->adapter->gl_info; >> >> I think you should retrieve gl_info from the context where possible. > Done > Missed the one in buffer_Unmap().

1 0

Re: oleaut32: rewrite RollUdate to be easier to change and to support more conversions
by Alexandre Julliard 01 Feb '10

01 Feb '10

André Hentschel <nerv(a)dawncrow.de> writes: > Old version of that function only used if-statements which is not the best solution for a math problem. It doesn't work here: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so vartest.c && touch vartest.ok vartest.c:1759: Test failed: expected 1, 29189, got 1, 29159 make[2]: *** [vartest.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: includes: Add amaudio.h
by Henri Verbeet 01 Feb '10

01 Feb '10

On 31 January 2010 20:34, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > + STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID riid, void** ppvObject) Looking at some other headers this seems a common thing to do, but is there really a reason to use STDMETHOD_(HRESULT,QueryInterface) over just STDMETHOD(QueryInterface)?

1 0

Re: dwmapi: add a stub for DwmDefWindowProc
by Nikolay Sivov 01 Feb '10

01 Feb '10

On 2/1/2010 07:35, Austin English wrote: > See http://bugs.winehq.org/show_bug.cgi?id=20443 > > > + FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); > Also don't forget to correct format here.

2 1

Re: wined3d: Add newer ATI/AMD cards vendor recognition
by Henri Verbeet 01 Feb '10

01 Feb '10

On 31 January 2010 14:59, Luca Bennati <lucak3(a)gmail.com> wrote: > As seen in bug #21515, newer ATI cards used with radeon open driver return a > GL_VENDOR string not present in wined3d_guess_vendor(). > This oneliner merely adds that so that the function return VENDOR_MESA > instead of VENDOR_WINE that could make apps crash. > I think this patch is ok. We will need to distinguish between card vendor and GL implementation vendor, but that's beyond the scope of this patch, I'll fix that. Just reporting VENDOR_ATI here without making that distinction first would mean we potentially apply fglrx quirks for Mesa.

2 1

Re: d3dx9: Implement point filtering of ARGB surface data in D3DXLoadSurfaceFromMemory
by Henri Verbeet 01 Feb '10

01 Feb '10

On 31 January 2010 13:00, Tony Wasserka <tony.wasserka(a)freenet.de> wrote: > - the other filters basically do the same, but the end effect looks > nice, so we can fallback to point filtering for linear, triangle and box > filters for now. > - apparently, D3DERR_INVALIDCALL gets returned if the specified > destination rect exceeds the actual surface boundaries > It looks like this patch is doing a couple of different things, you should probably split it up.

1 0

Re: [3/5] d3d9: Test buffer lock flags (try 2)
by Henri Verbeet 01 Feb '10

01 Feb '10

On 30 January 2010 12:38, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static HMODULE d3d9_handle = 0; That's still redundant. Note that the variable doesn't have to be static in the first place though, you can just pass it to init_d3d9().

1 0

Re: [2/5] WineD3D: Implement dynamic buffers with GL_ARB_map_buffer_range
by Henri Verbeet 01 Feb '10

01 Feb '10

On 30 January 2010 12:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + const struct wined3d_gl_info *gl_info = &device->adapter->gl_info; I think you should retrieve gl_info from the context where possible.

1 0

Re: [1/5] WineD3D: Add GL_ARB_map_buffer_range
by Henri Verbeet 01 Feb '10

01 Feb '10

On 30 January 2010 12:35, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +/* GL_ARB_map_buffer_range */ > +#ifndef GL_ARB_map_buffer_range > +#define GL_ARB_map_buffer_range > +typedef GLvoid *(WINE_GLAPI *PGLFNMAPBUFFERRANGE)(GLenum target, GLintptr offset, GLsizeiptr length, GLbitfield access); > +typedef void (WINE_GLAPI *PGLFNFLUSHMAPPEDBUFFERRANGE)(GLenum target, GLintptr offset, GLsizeiptr length); > +#define GL_MAP_READ_BIT 0x0001 > +#define GL_MAP_WRITE_BIT 0x0002 > +#define GL_MAP_INVALIDATE_RANGE_BIT 0x0004 > +#define GL_MAP_INVALIDATE_BUFFER_BIT 0x0008 > +#define GL_MAP_FLUSH_EXPLICIT_BIT 0x0010 > +#define GL_MAP_UNSYNCHRONIZED_BIT 0x0020 > +#endif Please keep these definitions consistent with the rest of the file, I just fixed all of them.

1 0

Re: dwmapi: add a stub for DwmDefWindowProc
by Reece Dunn 01 Feb '10

01 Feb '10

On 1 February 2010 04:35, Austin English <austinenglish(a)gmail.com> wrote: + BOOL WINAPI DwmDefWindowProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam, LRESULT *plResult) Minor nitpick here -- there is a space before the BOOL return type. +{ + FIXME("(%p, %d, %p, %p, %p ) stub\n", hwnd, msg); + + return E_NOTIMPL; But more importantly, you are returning a HRESULT instead of a BOOL return value. MSDN (http://msdn.microsoft.com/en-us/library/aa969507%28VS.85%29.aspx) says that it is a BOOL and should return FALSE if the message was not handled. - Reece

2 1

Re: wined3d: Add newer ATI/AMD cards vendor recognition
by Stefan Dösinger 01 Feb '10

01 Feb '10

Am 31.01.2010 um 14:59 schrieb Luca Bennati: > As seen in bug #21515, newer ATI cards used with radeon open driver return a GL_VENDOR string not present in wined3d_guess_vendor(). > This oneliner merely adds that so that the function return VENDOR_MESA instead of VENDOR_WINE that could make apps crash. > <0001-wined3d-Add-newer-ATI-AMD-cards-vendor-recognition.txt> I think VENDOR_ATI would be better here. VENDOR_MESA is later replaced with VENDOR_NVIDIA and a generic NVIDIA card is found. Besides this we should make sure that intel cards driven by the mesa driver are always reported as VENDOR_INTEL, and older ATI cards with the r200 and r300 driver are reported as VENDOR_ATI as well. Obviously we'll also need a function to roughly match the Rxyz GPU IDs to card PCI IDs. Can you post a backtrace of an app crashing due to VENDOR_WINE? Such an app would be pretty buggy, or we're not watching out properly in wined3d somewhere.

1 0

New valgrind results - with fixes for two kinds of false positives
by Dan Kegel 31 Jan '10

31 Jan '10

Julian kindly pointed out that --vex-iropt-precise-memory-exns=yes is needed to avoid false positives in tricky signal handlers like the one involved in GetBitmapBits(). Adding that didn't slow things down much if any, and got rid of lots of valgrind-specific GetBitmapBits() crashes. Also, I applied what seems like an obvious fix for the subheap_notify_free_all false positives (see http://bugs.winehq.org/show_bug.cgi?id=21553 ), and it got rid of them. I've updated http://wiki.winehq.org/Wine_and_Valgrind correspondingly (and made it a bunch clearer, too). Current results at http://kegel.com/wine/valgrind/logs/2010-01-31-09.46/ Current stats: http://kegel.com/wine/valgrind/logs/2010-01-31-09.46.errs.txt 1 Invalid free/ delete / delete[] 2 Source and destination overlap in memcpy 2 Syscall param writev 3 Use of uninitialised value of size 4 6 Invalid write of size 4 7 Invalid read of size 2 12 Invalid write of size 1 22 Invalid read of size 4 48 Conditional jump or move depends on uninitialised value 78 Invalid read of size 1 283 XXX bytes in XXX blocks are definitely lost total: 464 *All* of the "Invalid read of size 1" errors are in the heap tests, so I'll suppress them for the next run. So we're at 386 warnings currently, a bit better than last time I reported figures, http://www.winehq.org/pipermail/wine-devel/2010-January/080989.html

1 0

Re: [d3d10core/tests] Fix a test failure when no adapters are present
by Paul Vriens 31 Jan '10

31 Jan '10

On 01/28/2010 05:14 PM, Henri Verbeet wrote: > Paul Vriens wrote: >> Hi, >> >> On VMware with the "Standard VGA" adapter and on VirtualBox there are no >> adapters returned when enumerating. >> >> I didn't use broken() as 'no adapters' seems somehow a valid return >> (added Henri to the cc: to prove me wrong). There is a skip() anyway if >> the creation failed. >> >> There will be a patch for dxgi as well along these same lines but I'm >> waiting for responses on this one. >> > This issue has come up before, and although it's a valid return value it > still seems suspicious that VMware / VirtualBox would claim the system > has no graphics adapters. If someone could figure out the reason for > that it would be appreciated. I also seem to remember this being unique > to Windows 7. That said, in principle the patch is ok with me. > Well, it's Windows 7 and Windows 2008. The various VMware graphics drivers all act a bit differently. VMware drivers are getting better and in theory it's possible to enable "Accelerate 3D Graphics" on several platforms but that leads to crashes (the whole guest that is) for one or more of the ddraw tests. So the drivers are not there yet I guess. Doesn't the DXGI_ERROR_NOT_FOUND return value tell us there is no D3D10 capable adapter (instead of any adapter)? -- Cheers, Paul.

2 4

Re: [PATCH] Implement OleCreatePropertyFrame (try 3)
by Geoffrey Hausheer 30 Jan '10

30 Jan '10

On Fri, Jan 29, 2010 at 11:10 AM, Stefan Leichter Stefan. wrote: > Am Friday 29 January 2010 15:01:55 schrieb Geoffrey Hausheer: > > Is there anything I can do to move this patch forward? I've fixed all > the > > issues that have been raised so far. I have no dea what it is waiting > on, > > and if there is anything I can do to get it committed or if it is just a > > question of being patient. As I said previously I'd happily write a test > > for it, but I couldn't find any examples of how to test a modal dialog > box > > in Wine, so I just don't know what the right way to do that is. > > According to http://source.winehq.org/patches/ the patch is pending. You > may > have more luck if you send some test cases for the unit tests first. > > Which, as I tried to explain in my mail, I have no idea how to do because the function is basically (from user-space) atomic and implements a Modal dialog box, and I haven't seen any Wine tests that deal with anything remotely like that. So I am at a loss as to how to write tests for this function. If that is what is needed to get it committed, then I need guidance as to how to go about it.

2 1

Re: [PATCH] shlwapi/tests: ChrCmpI* not present on Win95B (winetestbot)
by Nikolay Sivov 30 Jan '10

30 Jan '10

On 1/30/2010 18:25, Detlef Riekenberg wrote: > > @@ -608,9 +610,13 @@ static void test_StrCmpA(void) > static const char str2[] = {'a','B','c','d','e','f'}; > ok(0 != StrCmpNA(str1, str2, 6), "StrCmpNA is case-insensitive\n"); > ok(0 == StrCmpNIA(str1, str2, 6), "StrCmpNIA is case-sensitive\n"); > - ok(!ChrCmpIA('a', 'a'), "ChrCmpIA doesn't work at all!\n"); > - ok(!ChrCmpIA('b', 'B'), "ChrCmpIA is not case-insensitive\n"); > - ok(ChrCmpIA('a', 'z'), "ChrCmpIA believes that a == z!\n"); > + if (pChrCmpIA) { > + ok(!pChrCmpIA('a', 'a'), "ChrCmpIA doesn't work at all!\n"); > + ok(!pChrCmpIA('b', 'B'), "ChrCmpIA is not case-insensitive\n"); > + ok(pChrCmpIA('a', 'z'), "ChrCmpIA believes that a == z!\n"); > + } > + else > + win_skip("ChrCmpIW() is not available\n"); > > Should be ChrCmpIA() in message.

1 0

new valgrind results...
by Dan Kegel 30 Jan '10

30 Jan '10

This is with an almost-unpatched trunk (the only patch is my tweak to handle bogus environment variables), so it's now using Alexandre's heap patches rather than mine. There are some interesting new warnings, not sure quite what to make of them yet. Logs at http://kegel.com/wine/valgrind/logs/2010-01-29-20.52/ Stats at http://kegel.com/wine/valgrind/logs/2010-01-29-20.52.errs.txt 2 Source and destination overlap in memcpy 2 Syscall param writev 3 Use of uninitialised value of size 4 7 Invalid read of size 2 10 Invalid write of size 4 20 Invalid write of size 1 29 Invalid free/ delete / delete[] 30 Invalid read of size 4 46 Conditional jump or move depends on uninitialised value 86 Invalid read of size 1 279 XXX bytes in XXX blocks are definitely lost total: 514

1 0

Re: Student Interested in Google Summer of Code 2010
by Tony Wasserka 29 Jan '10

29 Jan '10

Hi, We've had two D3DX projects last year - one implementing shaders, the other (which was mine) implementing meshes, fonts and texturing code. Both have only partially been integrated, yet (as far as I know), but most of the other stuff in d3dx9 is still untouched, you can take a look at the msdn documentation to see the whole list of interfaces. I guess the most profitable would be implementing the effect interfaces, since these are the most used ones next to shaders and textures. I'm not sure how much has been implemented in D3D10's effect area (they merged the effect interfaces from d3dx into d3d10), but you should maybe clarify with some d3d devs how much code can be shared here before. Just my suggestion, there might be other interesting areas of d3dx and Wine in general as well of course. Best Regards, Tony

13 30

Re: [PATCH] Implement OleCreatePropertyFrame (try 3)
by Geoffrey Hausheer 29 Jan '10

29 Jan '10

Is there anything I can do to move this patch forward? I've fixed all the issues that have been raised so far. I have no dea what it is waiting on, and if there is anything I can do to get it committed or if it is just a question of being patient. As I said previously I'd happily write a test for it, but I couldn't find any examples of how to test a modal dialog box in Wine, so I just don't know what the right way to do that is.

2 1

relay log problem
by Stefan Leichter 29 Jan '10

29 Jan '10

Hello, does anyone notice a problem that the lines of the logging are written over each other as in the attached log? My system has an AMD Phenom(tm) II X2 550 Processor on a NVIDIA GeForce 8300 Chipset running running Debian Lenny 32 bit Is this a know problem? Is a work around available? -- Stefan

7 13

Re: [2/5] d3d9: Test invalid buffer lock parameters
by Henri Verbeet 29 Jan '10

29 Jan '10

On 29 January 2010 11:35, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static HMODULE d3d9_handle = 0; This is redundant. > + hr = IDirect3DVertexBuffer9_Lock(buffer, 0, 0, (void *) &bufstart, 0); > + ok(hr == D3D_OK, "IDirect3DVertexBuffer9_Lock failed, 0x%08x\n", hr); > + hr = IDirect3DVertexBuffer9_Unlock(buffer); > + ok(hr == D3D_OK, "IDirect3DVertexBuffer9_Unlock failed, 0x%08x\n", hr); > + > + hr = IDirect3DVertexBuffer9_Lock(buffer, 0, 1024, (void *) &data, 0); > + ok(hr == D3D_OK, "IDirect3DVertexBuffer9_Lock failed, 0x%08x\n", hr); > + hr = IDirect3DVertexBuffer9_Unlock(buffer); > + ok(hr == D3D_OK, "IDirect3DVertexBuffer9_Unlock failed, 0x%08x\n", hr); > + ok(bufstart == data, "Two locks returned different addresses: %p, %p\n", bufstart, data); > Why would we care if the buffer is always mapped at the same address? Also note that the test doesn't necessarily prove this is the case. > + /* This happily wraps around the address space */ > + hr = IDirect3DVertexBuffer9_Lock(buffer, ~0U, 1024, (void *) &data, 0); > + ok(hr == D3D_OK, "IDirect3DVertexBuffer9_Lock(start ~0U) failed, 0x%08x\n", hr); > + hr = IDirect3DVertexBuffer9_Unlock(buffer); > + ok(hr == D3D_OK, "IDirect3DVertexBuffer9_Unlock failed, 0x%08x\n", hr); > + ok(bufstart -1 == data, "~0U start lock returned unexpected address: expected %p, got %p\n", bufstart - 1, data); > I'd expect this to break on 64 bit. Also, like the previous test, why do we care? Do you seriously have an application that does this?

2 1

Re: [PATCH 3/5] wined3d: Prune invalid states from the state table.
by Stefan Dösinger 29 Jan '10

29 Jan '10

On Thursday 28 January 2010 23:40:25 Henri Verbeet wrote: > +static void prune_invalid_states(struct StateEntry *state_table, const > struct wined3d_gl_info *gl_info) +{ > + unsigned int start, last, i; > + > + start = STATE_TEXTURESTAGE(gl_info->limits.texture_stages, 0); > + last = STATE_TEXTURESTAGE(MAX_TEXTURES - 1, > WINED3D_HIGHEST_TEXTURE_STATE); + for (i = start; i <= last; ++i) > + { > + state_table[i].representative = 0; > + state_table[i].apply = state_undefined; > + } Please use the number of texture blend stages reported from the fragment pipeline rather than gl_limits.texture_stages. texture_stages only works with the nvrc and ffp pipelines, but not arbfp or atifs(it works out ok by chance on most GL cards). There's a deeper issue with how we manage texture limits, because currently the extension loading code picks limits.texture_stages, already anticipating which pipeline we'll choose later. We should handle this in the way shader constants are handled: Rename limits.texture_stages to limits.max_nv_general_combiners, make only the nvrc and nvts pipelines read this extension specific value, and use the pipeline reported d3d texture blend stages in fragment pipeline independent code. We're also (still) mixing up blend stages with fixed function vertex coordinates. Regarding masking out unsupported / invalid states, Ivan once suggested the idea to make the pipeline template's needed extension field more powerful, e.g. via a callback function. That way the pipeline would have more control over which state handlers it registers. I am fine with a pipeline independent function, I guess it will work just fine for our needs, just digging out the old idea.

2 4

Re: [2/5] d3d9: Test invalid buffer lock parameters
by Henri Verbeet 29 Jan '10

29 Jan '10

On 28 January 2010 22:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + * Copyright (C) 2010 Stefan Dösinger(For CodeWeavers) Please use UTF-8 like the other source files. (I'd also suggest a space and a lowercase 'F').

2 1

Loader, mapping and sharing issues with main exe
by Jason Edmeades 29 Jan '10

29 Jan '10

Hello, I've been debugging a problem with an application which checks itself for consistency before it runs. It does this extremely simply and fails in a trivial way under wine, but for the life of me I do not know how to fix it, and I would appreciate any thoughts - its not everyday I delve into the loader and server logic! I have cut this down to a 2 line test program, which basically fails because a native executable called eg. test.exe subsequently calls CreateFile(".\\test.exe", GENERIC_READ, 0 /* no share*/ - ie it's opening itself for read access and non-shared access. It suffers a sharing violation on wine whereas it works fine on windows Diagnosing the wine side, we are in trouble here - the act of loading a module ends up in load_dll which call find_dll_file which in turn calls NtOpenFile for GENERIC_READ access. This returns a file handle which is then used to create the in memory file mapping for the executable code, and the handle returned from the NtOpenFile is then closed. However, when we come along to the application code and try the open we end up checking the sharing and there are 3 things on the inode->open chain: The original open, with access of read The mapping, with access of mapping The open in progress (which is ignored for sharing checks) which does not want to SHARE_READ,and hence the sharing violation occurs. For reference we are failing in the 3rd (last) case of check_sharing returning STATUS_SHARING_VIOLATION, ie existing access if for read purposes, but the requested sharing doesnt allow this. What I dont understand is why the NtClose for the handle does not remove it from the 'open' list - I think from my reading of the fd_destroy code it will put it onto the closed list if there are other references to the same inode, although thats where my debugging will head next. This whole area has me confused now! Can anyone shed some light on how its all supposed to work please? Thanks, Jason

2 2

Quick multiple-patch submission question
by Erich Hoover 29 Jan '10

29 Jan '10

When submitting multiple patches that apply to the same component but each patch is unrelated (ie. each one fixes a different issue), is it still appropriate to label the patches with the [PATCH X/Y] notation? In the case I have at hand the patches are even for different files of the same component, so the apply order completely doesn't matter. Erich Hoover ehoover(a)mines.edu

4 3

Re: [2/2] kernel32: Fix GetVolumeNameForVolumeMountPointW to match
by srrose 28 Jan '10

28 Jan '10

What does this mean? Iim using a USB 2.0 Flash Drive and a LAUNCHU3.EXE file says it is linked to a missing export. It then says KERNEL32.DLL:GetVolumeMountPointW. Can you help me? Thank you!! srrose(a)commspeed.net

2 1

Windows-version dependent callback?
by Joerg-Cyril.Hoehle＠t-systems.com 28 Jan '10

28 Jan '10

Hi, my (unreleased) MIDI tests have spotted that not all versions of MS-Windows seem to send out the MM_MOM_POSITIONCB callback/notification resulting from a MEVT_F_CALLBACK event in midiStreamOut(). w9X/ME appears not to know about it. Machines since NT honour it (even though I've seen mixed results about w2k). More generally, I'm wondering whether Wine should behave similarly based on the version setting in winecfg? What is Wine.wisdom on this topic? We've seen apps hang because of missing callbacks or notifications from Wine. Perhaps an app receiving extra callbacks or messages that it does not know about will cause as much trouble? Thanks for your help, Jörg Höhle

3 2

tell wine not to use the mouse
by Mihai Donțu 28 Jan '10

28 Jan '10

Hi, I use wine to run cl.exe and build some dll-s. However, each time make invokes wine, my mouse short-jumps from one position to another or stops responding for a brief period of time. Is there any way to tell wine to skip any GUI initialization or to not touch the mouse? Thanks, -- Mihai Donțu

1 1

Re: [PATCH 3/5] wined3d: Ensure draw ordering across contexts.
by Stefan Dösinger 28 Jan '10

28 Jan '10

> - if (SUCCEEDED(IWineD3DSurface_GetContainer((IWineD3DSurface *)target, &IID_IWineD3DSwapChain, (void **)&swapchain))) { > - if (target == (IWineD3DSurfaceImpl*) swapchain->frontBuffer) { > - wglFlush(); > - } > - IWineD3DSwapChain_Release((IWineD3DSwapChain *) swapchain); > - } > + wglFlush(); /* Flush to ensure ordering across contexts. */ Why do we have to do this even when there is only one context? In the event another context is created after the draw?

2 1

WINEDLLPATH and /usr/lib/wine
by Michael Ost 28 Jan '10

28 Jan '10

Hi, I am wanting to direct wine to launch a specific APP.exe.so program by using WINEDLLPATH during the development of APP.exe. Unfortunately (and undocumented-ely if you know what I mean) WINEDLLPATH is superseded by /usr/lib/wine. So if /usr/lib/wine/APP.exe.so exists, WINEDLLPATH will find that one instead of the one I am trying to target. So, if these files exist: /usr/lib/wine/APP.exe.so /MY_DIR/APP.exe.so Then this command... WINEDLLPATH=MY_DIR wine APP.exe ... will start /usr/lib/wine/APP.exe.so and not /MY_DIR/APP.exe.so. Is this on purpose? It doesn't seem right at first glance. I would assume that WINEDLLPATH would take precedence. Otherwise what purpose would it serve? Thanks for tips or background, Michael Ost Muse Research, Inc.

4 22

re: Student Interested in Google Summer of Code 2010
by Dan Kegel 27 Jan '10

27 Jan '10

Howdy! While you're figuring out your proposal, you might want to look over the code from previous SoC (or university) Wine projects that didn't quite make it in. One easy one might be the dxdiag written by the UCLA students. Dusting it off and bringing some of its features into the wine tree might be a nice way to warm up. - Dan

1 0

Re: GSoC D3DX9 work
by Tony Wasserka 27 Jan '10

27 Jan '10

> Hello, > I might be interested as a side project. I've been poking around in the > wine code looking for something interesting for the last few weeks and > this might be it. However I know I wouldn't have much interest in it if > it doesn't actually help me, so I'd like to know a few additional > details about it. > > * Do you have list of bugs that your changes are known to fix? > * Same question for what bugs a completed work should fix. > * Could I see the TODO list to get a better idea of what needs to be done? > > Thank you. > (note that I replied to wine-devel since this might be useful for someone else as well) Okay, so here we go: Generally, I don't have visual (wine) tests for any of the stuff I wrote, not sure whether they're needed actually though. font code: - Probably the easiest to start with, although it might be a bit confusing if you're unfamiliar with the code. - Requires D3DXFilterTexture with D3DX_DEFAULT filter on A8R8G8B8 textures first though (that one's relatively easy to implement). - Requires this http://repo.or.cz/w/wine/d3dx9TW.git?a=commit;h=e4dfdb7c2cc4264bbe89ef938c9… patch to be applied first (fixes a bug in D3DXSprite implementation) - Not sure whether PreloadGlyphs was working correctly when I last worked on it. Glyphs are cached into textures and if an app caches to many glyphs new textures must be generated, which I didn't do first. I added this functionality but can't tell if it still works. Could be tested pretty easy with my testing demos. - Glyph positions in the texture cache (which are returned by GetGlyphData) differ by 1 or 2 from the native dll. At least they did, maybe I figured out why and fixed it meanwhile. It doesn't really matter anyways since it doesn't really affect applications, but just wanted to tell you ;) - two flags in DrawText aren't implemented, yet (DT_NOCLIP could be important to speed up things). Generally that one function (and its bunch of helper functions) really needs some cleanup before actually submitting it to wine-patches. It's forked from user32 code (or whereever DrawText is implemented in), so it's not /that/ clean. In conclusion, the only problematic bit here should be the last one. texture code, D3DXLoadSurfaceFromMemory: - implement other color conversion and filtering routines, you REALLY should talk to me in case you really want to do this, since I have thought much about how to organize code to be efficient and relatively clean as well, and I'm having a fairly good idea how it probably should be done. - What's missing for color conversion: about any format which is not unsigned 1,2,3 or 4 b(yte)pp ARGB, but my design allows fairly easy addition of support for large ARGB formats, signed formats, luminance channels and other non-compressed stuff. compressed formats might be hard, but not a necessarity to implement in the first place anyway. - other filters to be implemented: point filtering is the only one necessary here actually, since it can be used as a fallback for more advanced filters for now. texture code, other stuff: - not really much to fix here, it just all depends on a working D3DXLoadSurfaceFromMemory implementation. - only thing: my d3dx9 implementation implements W(indows)I(maging)C(omponent) codecs, and I'm not really sure how to integrate that one into Wine. right now they reside in the d3dx9 folder itself, but it could also be possible to create a new dll for it (since it might be usefull for d3dx10 as well)... you should talk to madewokherd (sorry if I'm misspelling that nick; he's the one who implemented most of the WIC stuff) and julliard (since he is the one to decide whether the integration method actually goes into mainline) on IRC about how to it properly I guess. mesh code: - right now dependent on d3dxof for .x file loading routines, but d3dx9 actually provides its own file loading routines, which should be reimplemented using d3dxof's methods. The current code must be ported over to using the d3dx9 methods. - Optimize() is not really implemented, I have a few ideas how to do it, but it's not of greates priority anyway - D3DXCreateMesh might work with some vertex declarations which do NOT map directy to a FVF, this might require architectural changes to the core code... - generally, the COM interfaces might not be implemented cleanly (maybe they are though, I wasn't sure how to do it properly since dsound and wined3d are doing this different, I went for the way wined3d does it). - .x file parsing doesn't read texture file names... this one might be trivial but I just couldn't get it working, for whatever reason - D3DXFVFFromDeclarator might not cover everything - I just forked it from some wined3d or d3d9 code (it does work fairly good at least) As for the affected bug reports, just search for the "d3dx" or "createtexture" terms on bugzilla ;) No non-DX-SDK apps are really dependant on the mesh stuff AFAIK, only few on the font stuff (e.g. the Dolphin emulator), so there aren't really any bug reports for them. - generally there aren't that many bugs, since most d3dx9 code just wasn't implemented, yet... There are numerous games though which don't run with our d3dx9 implementation, since they often require the texture loading functions.

2 2

Re: wintrust: Close file handle on error loading a message from it
by Alexandre Julliard 27 Jan '10

27 Jan '10

Juan Lang <juan.lang(a)gmail.com> writes: > Fix for bug 21501. It doesn't work here: ../../../tools/runtest -q -P wine -M wintrust.dll -T ../../.. -p wintrust_test.exe.so softpub.c && touch softpub.ok softpub.c:491: Test failed: expected TRUST_E_NOSIGNATURE or CRYPT_E_FILE_ERROR, got 00000006 make[2]: *** [softpub.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Tests for the codepages supported by TranslateCharsetInfo
by Dmitry Timoshkov 27 Jan '10

27 Jan '10

Ilya Shpigor <shpigor(a)etersoft.ru> wrote: > +static void test_TranslateCharsetInfo(void) > +{ > + /* Any other codepages are not supported > + * by TranslateCharsetInfo in Windows XP > + */ > + test_codepage(42, 2); > + test_codepage(874, 222); > + test_codepage(932, 128); > + test_codepage(936, 134); > + test_codepage(949, 129); > + test_codepage(950, 136); > + test_codepage(1250, 238); > + test_codepage(1251, 204); > + test_codepage(1252, 0); > + test_codepage(1253, 161); > + test_codepage(1254, 162); > + test_codepage(1255, 177); > + test_codepage(1256, 178); > + test_codepage(1257, 186); > + test_codepage(1258, 163); > + test_codepage(1361, 130); It would be better to create a table and run the tests in the loop, use symbolic charset names, and actually test some codepages which would fail. -- Dmitry.

1 0

Re: gdi32: Tests for the codepages supported by TranslateCharsetInfo
by Paul Vriens 27 Jan '10

27 Jan '10

On 01/27/2010 11:01 AM, Ilya Shpigor wrote: > Hi Ilya, These tests introduce failures on Win9x/NT4: https://winetestbot.geldorp.nl/JobDetails.pl?Key=456 It would maybe be worthwhile to add some more info to the traces by using __LINE__ for example (see examples in other tests). You can request an account on this winetestbot so you can check other platforms yourself if needed. -- Cheers, Paul.

1 0

trace() and testing asynchronous callbacks and concurrency
by Joerg-Cyril.Hoehle＠t-systems.com 27 Jan '10

27 Jan '10

Hi, I'm seeking advice and ideas about 2 issues: A) I've added trace() output to a callback function. On a dual-core XP box, output comes out like follows: mmidiid.ci:56.: Ccall:bac7k! 9m: sTg=e3c9s 1t2 fef58 a0 iled: Message 3c9 from command midiStreamOut which is a mixture of characters from: midi.c:56: Callback! msg=3c9... and midi.c:79:Test fa[iled...] What can I do if trace() may produce such valuable output that I don't want to miss it from a test log, i.e. I don't want to remove the trace() entirely? BTW, this is interesting on its own because it proves that at least the MM_MOM_DONE (3c9) callback from midiStreamOut may be sent from another thread than the application's. B) How to sanely test the effects of callbacks yet be compatible with ok() and broken()? The reason is that some callbacks are not invoked on w2k. They are on XP. If you look at my test_notification() pattern in winmm/tests/mci.c, you'll notice that while it's barely useable with ok(), it does not work together with broken(). What I need to express is rc = midiXYZ() ok(callback=MM_MOM_3c9 || broken(callback=none) /* w2k and presumably w9x */) Yet this is incomplete: Not only must the type be tested (MM_MOM_xyz), but also the parameters and other slots of the MSG (e.g. msg.hwnd) or callback function (e.g. midihdr). That's why I created the function test_notification(x,y,z) back then for MCI, which does all that. A possibility may be get_notification() /* retrieve data from callback function or message */ ok(cb_type == MM_MOM_3c9 || broken(cb_type==0)) if (cb_type==MM_MOM_3c9) { if (cb_type==CALLBACK_WINDOW || THREAD) { ok(cb_hwnd == hwnd); } ok(cb_parm1 == mhdr && cb_parm2 == 0); ...} This is getting too verbose fast. Any better suggestion? Thanks for your help, Jörg Höhle

1 0

GSoC 2010 is on
by Kai Blin 27 Jan '10

27 Jan '10

Hi folks, Google announced this year's GSoC incarnation. It would be nice if everybody could have a look at http://wiki.winehq.org/SummerOfCode and check if the project they want to mentor is on there. Also, feel free to propose new projects, assuming a student with low prior knowledge about Wine can complete them in 2 months of time. (They have 3 months, but past experience tells us this almost always takes longer than planned). Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Student Interested in Google Summer of Code 2010
by Arjun Comar 27 Jan '10

27 Jan '10

Hey all, I'm new here and interested in the Wine project for GSoC this year and figured I'd start by introducing myself and hopefully getting to know who's who on this list. I'm a Sophomore CS major at Rose-Hulman Institute of Technology, a science and engineering school in Indiana. I've been writing code since I taught myself how in 7th grade, and I've been using Linux since around that same time. In high school, I volunteered large chunks of my time to various open source projects: Ubuntu, Compiz, etc.. Now that I'm in college, I regret not having quite as much time as I'd like to devote to the Linux community as a whole, so I'm hoping to spend this summer giving something back. A quick explanation of what experience I have (relevant stuff only): Linux, C, OpenGL I've been scanning the wiki for GSoC from last year and noticed that most of the projects didn't have any sort of a status associated with them. I checked in the irc channel, and was told that most of the projects were still open. Of those that don't have a status listed, I'm kinda interested in the d3d9_xx DLLs problem. While I'm not too familiar with DirectX, I figure if I start now I'll have plenty of time to get up to speed. Is this still a problem that needs work? If so, is the mentor listed on the page still accurate? I attempted to contact the listed mentor but wasn't successful. I'd also be interested in working on almost anything else, that project just stuck out to me as something important that hadn't gotten done in a long time. If you have any suggestions for useful projects, or how to go about getting caught up to speed on what I need to know (Windows API, DirectX, and/or the Wine codebase itself), I would appreciate that. It's slow going trying to find all the information on my own, but I'm sure other people have had the same problem before and have found good resources to solve it. I'm very interested in working with all of you for the next few months and hopefully through the summer and beyond. If anyone would like more information, feel free to ask. I've never done this before, so I'm not too sure what kind of information you guys are looking for in a GSoC candidate. Any critique/commentary is appreciated. TL;DR: I'm a student interested in GSoC, help me out! --- Arjun Comar, Rose-Hulman '12 Computer Science

1 0

Re: [PATCH 2/5] d3d9: Add depth clamp tests.
by Stefan Dösinger 26 Jan '10

26 Jan '10

Am 26.01.2010 um 18:31 schrieb Henri Verbeet: > +/* This test tests depth clamping / clipping behaviour: > + * - When D3DRS_CLIPPING is disabled depth values are *clamped* to the > + * minimum/maximum z value.+ hr = IDirect3DDevice9_SetRenderState(device, D3DRS_ZFUNC, D3DCMP_LESSEQUAL); > + ok(SUCCEEDED(hr), "SetRenderState failed, hr %#x.\n", hr); It would be interesting to see how D3DCMP_GREATER behaves with clipping off. Does the clamping occur before the depth test, or after the test but before writing the values into the depth buffer. (ie, is 3.0 > 1.0 or is 3.0 == 1.0) A floating point depth buffer might be interesting as well to see if the clamping is done explicitly, or if just happens due to the limited value range in the depth buffer. I'm fine with postponing this until we get serious about float depth buffers though. (fwiw, ARB_depth_buffer_float suggests that the app will be able to use depths outside 0;1, but doesn't expose this yet, and is left open for future extensions)

2 2

Wine coding style
by Uwe Bonnes 26 Jan '10

26 Jan '10

Hello, are there any examples for Editor settings (e.g. emacs c-mode) resulting in acceptable indentation? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

4 3

Re: [PATCH] [Include]: push/pop pack fixes on 64 bit platforms
by Alexandre Julliard 26 Jan '10

26 Jan '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > (try #2) > > A+ > --- > > include/commctrl.h | 16 ++++++++++++++++ > include/fci.h | 4 ++++ > include/fdi.h | 8 ++++++++ > include/mmsystem.h | 4 ++++ > include/richedit.h | 4 ++++ > include/shlwapi.h | 6 +++++- > include/wingdi.h | 6 ++++++ > include/ws2spi.h | 4 ++++ > 8 files changed, 51 insertions(+), 1 deletions(-) Many of these don't match the PSDK. Also please split the patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [kernel32] Add testcase for bug 21292(corrected)
by Paul Vriens 26 Jan '10

26 Jan '10

On 01/25/2010 06:30 PM, Uwe Bonnes wrote: > This time deleting an eventual created file and with hopefully better > indentation Indentation is still not what it's supposed to be. You are not sticking to the surrounding style, but worse your own patch uses different styles as well. -- Cheers, Paul.

1 0

Re: [PATCH 3/3] xmllite/tests: Add test for XML declaration parsing
by Alexandre Julliard 25 Jan '10

25 Jan '10

Nikolay Sivov <bunglehead(a)gmail.com> writes: > This applies over previous 2 patches series. > > Add test for XML declaration parsing It doesn't work: ../../../tools/runtest -q -P wine -M xmllite.dll -T ../../.. -p xmllite_test.exe.so reader.c && touch reader.ok reader.c:546: Test failed: Expected (0,0), got (0,1751353550) make[2]: *** [reader.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winemp3: incorrect stream handling
by Austin English 25 Jan '10

25 Jan '10

On Sun, Jan 24, 2010 at 6:13 PM, Stefano Guidoni <s.guidoni(a)tin.it> wrote: > One of the examples in the API doc of MPG123 states: "we are not in > feeder mode, so MPG123_OK, MPG123_ERR and MPG123_NEW_FORMAT are the > only possibilities"; however in winemp3 the function MPEG3_StreamOpen > uses mpg123_open_feed(), so those are not the only possibilities in > this case. > > This patch restores background music in Irisu Syndrome > (freeware game, http://appdb.winehq.org/objectManager.php?sClass=version&iId=15598 > , in Crusader Kings and possibly other applications too (like > virtualdub, bug 21091). Please don't send patches as compressed files. -- -Austin

1 0

Re: [4/4] winhttp: Store the context passed to WinHttpSendRequest.
by Alexandre Julliard 25 Jan '10

25 Jan '10

Hans Leidekker <hans(a)codeweavers.com> writes: > See http://bugs.winehq.org/show_bug.cgi?id=21442 > --- > dlls/winhttp/request.c | 1 + > dlls/winhttp/tests/winhttp.c | 16 +++++++++++++--- > 2 files changed, 14 insertions(+), 3 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M winhttp.dll -T ../../.. -p winhttp_test.exe.so winhttp.c && touch winhttp.ok winhttp.c:297: Test failed: WinHttpQueryOption failed: 122 winhttp.c:298: Test failed: expected 0xdeadbef0, got 0 make[2]: *** [winhttp.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ukrainian-credui
by Paul Vriens 25 Jan '10

25 Jan '10

On 01/24/2010 09:23 PM, гор Хакер wrote: > ukrainian-credui > Hi, If you send a second (or higher) revision of a patch please mark it as such. For example "(Try x)" at the end. This makes it easier to discard older ones. This one supersedes the one that didn't have the pragma for example. A nicer subject would be appreciated as well. "ukrainian-credui" suggests it's a translation but why not say something like "Adding Ukrainian translations to credui" or "Fixed ...". I'm not sure if our automated patch watcher (http://source.winehq.org/patches/) can cope with non-ascii characters in the "From:" field but your patches don't show up over there. Have a look at http://wiki.winehq.org/SubmittingPatches. Your email address for this mail is different from the generated one in the patch attached to that email and the names are again different from the copyright name in the file itself. -- Cheers, Paul.

4 4

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection
by Dmitry Timoshkov 25 Jan '10

25 Jan '10

Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > The current code misdetects both Windows XP and Wine as Win9x and skips > some tests due to this. The SetParent tests were not passing on XP, so > this patch also removes the tests that fail on XP SP3. These should be 2 separate patches. And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_… SetParent tests pass under XP just fine. -- Dmitry.

3 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel