- wine-devel - winehq.org

Re: dbghelp: Make sure the ClientPointers flag is set correctly
by Henri Verbeet 29 Dec '09

29 Dec '09

2009/12/29 Jason Green <jave27(a)gmail.com>: > commit 317da09400946ca9f97361a47a227595c5bedfe3 > Author: Eric van Beurden <ericvb(a)transgaming.com> > Date: Tue Dec 29 12:35:03 2009 -0500 > > Make sure the ClientPointers flag isn't set incorrectly Mostly out of curiosity, how did you generate this patch? That looks like the kind of output git log gives, not git format-patch.

2 2

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.
by Alexandre Julliard 29 Dec '09

29 Dec '09

Matteo Bruni <matteo.mystral(a)gmail.com> writes: > + > +%option reentrant bison-bridge These won't work on old flex versions, and will get you in trouble with the flex police (aka Michael Stefaniuc ;-) -- Alexandre Julliard julliard(a)winehq.org

3 2

Guide for creating new AppInstall tests
by Sam S. 29 Dec '09

29 Dec '09

Hello Wine team! After reading the introduction to AppInstall at http://www.winehq.org/wwn/360, I decided to try and write some additional application tests for it. There are at least two freely downloadable win32 apps that I run with Wine, that have in the past (in my experience) been quite sensitive to small improvements/regressions in certain areas of wine (gecko engine and opengl, namely), so having them automatically tested daily could be useful... Unfortunately, however, the wiki page (http://wiki.winehq.org/Appinstall) doesn't really provide a guide for how to go about doing this... It explains the text that will need to be put in the actual test script (which I could have also figured out by looking at the well-documented example scripts), but almost nothing about how you need to set up your working environment, what files to put where, which commands to call, etc, for the purpose of writing/testing a new AppInstall script from scratch. In absence of such a guide, I just downloaded the whole http://winezeug.googlecode.com/svn/trunk/appinstall directory, copied it into a Windows XP environment (because according to the WWN article, you're supposed to write the tests on Windows), and started by duplicating one of the example files. However, when I open a Command Prompt window and try to run one of the .ahk files with AutoHotKey, nothing really happens - all I see is some additional Command Prompt windows popping up for a split second and disappearing again, and then the command returns - nothing downloaded, no output, no error messages, nothing. (Btw, I don't even understand where the dowloads specified in the scripts are supposed to end up...) How am I supposed to do this? More generally: Could someone who knows how to do this maybe put up a step-by-step guide for users who want to contibute by writing new AppInstall tests, with no prior knowledge? Possibly something along the lines of: - what/how do download - on Windows: what files to put where / how to set up the environment - on Windows: how to create a new test-script / where to put it - on Windows: how to get all those checksums - on Windows: how to properly test-run/debug the new script - on Linux+Wine: what files to put where / how to set up the environment - on Linux+Wine: how to test-run the new script previously created on Windows - where to upload/send finished test-scripts to Thanks! Sam PS: When will there be a new WWN?

2 3

Building and packaging Wine Gecko
by Anssi Hannula 29 Dec '09

29 Dec '09

Hi all! I see that Wine has recently started to always request installation of Gecko, and that it is recommended to use a distribution provided package. We do not yet provide a wine-gecko package in Mandriva, but we'd like to. According to our policy (and the policy of e.g. Debian, Fedora) everything in our main repositories has to be compiled by us without external binaries compiled by a third party. I noticed there are build instructions here: http://wiki.winehq.org/BuildingWineGecko However, the instructions on that page ask for copying binaries directly provided in wine-mozilla tarball, and for modifying mingw32 headers. These actions are rather unacceptable for us (I guess the latter one is workaroundable, though). I saw that http://wiki.winehq.org/Gecko says Gentoo and openSUSE package Gecko properly. I looked at the Gentoo package [1] and saw that they simply download the prebuilt cab, which we can't do. I took a look in openSUSE src.rpm [2], but found no references to Gecko, and I didn't see any separate wine-gecko src.rpm there. I did found wine-gecko OpenSUSE binary packages in Wine's SourceForge page, but no source packages or information on how it was built. Is it really not possible to build Wine Gecko from the source code, on command line, on Linux? Or is it just that nobody has written any instructions on how to do that? [1] http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-emulation/wine/wine-1.1… [2] http://download.opensuse.org/factory/repo/src-oss/suse/src/wine-1.1.28-3.4.… -- Anssi Hannula Mandriva packager

10 24

Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.
by Dmitry Timoshkov 29 Dec '09

29 Dec '09

"David Quintana (gigaherz)" <gigaherz(a)gmail.com> wrote: > Issue was caused by VK_F4 having the same exact code as a lowercase 's'. > So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed > the wrong piece of code which was meant to be ONLY for WM_KEYDOWN. Thanks for spotting this bug. Anyway the fix is not correct. Virtual key codes should be tested only in the WM_KEYDOWN handler, WM_CHAR handler should test for character codes. Also, as Nikolay asked please don't use C++ comments in Wine code. -- Dmitry.

2 1

Difficulty fixing a regression in reading text files with MSVCRT
by Erich Hoover 29 Dec '09

29 Dec '09

In a surprise last-minute request it became necessary for me to get Athena Visual Studio running under Wine again (http://appdb.winehq.org/objectManager.php?sClass=version&iId=15183). A couple of commits to MSVCRT (that are needed for other reasons) caused regressions in Wine's ability to run this application and I am having a lot of difficulty getting Athena working again. The commits that revealed the problem are: ebe4a9e321800fbe6d2004a640cd276a28d15c38: Remove CRs earlier in ascii mode. 7f3c70c52fe470d431a51b3363ed4f7336d5f7f5: Remove CRs earlier in ascii mode in fseek, too. After tracing down a lot of rabbit holes, it appears that the problem is somehow related to how the buffer boundary influences the file position reported by ftell. I've attached a test case that appears related to the issue. I can use a native MSVCRT for now, but I would appreciate some assistance so that this issue can be properly resolved at some point. Erich Hoover ehoover(a)mines.edu

2 1

Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.
by Nikolay Sivov 28 Dec '09

28 Dec '09

On 12/28/2009 22:18, David Quintana (gigaherz) wrote: > Issue was caused by VK_F4 having the same exact code as a lowercase 's'. > So the code, which treated WM_CHAR and WM_KEYDOWN as the same, executed > the wrong piece of code which was meant to be ONLY for WM_KEYDOWN. > > Patch is attached. > > > > Please resubmit without cpp style comments.

1 0

Re: [PATCH 3/5] wined3d: Introduce "context_apply_state()" to setup a context for a specific usage.
by Stefan Dösinger 28 Dec '09

28 Dec '09

Am 27.12.2009 um 19:57 schrieb Henri Verbeet: > +/* Context activation is done by the caller. */ > +static void context_apply_state(struct wined3d_context *context, IWineD3DDeviceImpl *device, enum ContextUsage usage) The patch looks ok to me, but out of curiosity: Do you intend to make this function available to other wined3d code like context_acquire is, or is the main motivation of the patch to tidy up the context_acquire() function?

2 2

Remove Macintosh platform
by Austin English 28 Dec '09

28 Dec '09

I just moved the last macintosh platforms to ppc32/x86, so can someone with the appropriate permissions remove that option. Thanks! -Austin

2 3

Re: [PATCH 1/3] wininet: Test also InternetCrackUrlW in test_crack_url.
by Paul Vriens 28 Dec '09

28 Dec '09

On 12/27/2009 01:27 AM, Jacek Caban wrote: > --- > dlls/wininet/tests/url.c | 77 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 77 insertions(+), 0 deletions(-) > Hi Jacek, Looks like these tests need at least IE7 to succeed. Could you have a look? -- Cheers, Paul.

1 0

Defining missing DirectInput constants
by Javier Kohen 28 Dec '09

28 Dec '09

Hi, I'm implementing DInput's SetActionFormat call. I need to add the DInput Action Mapping Constants to Wine's dinput.h so I can map between the user requested action and the DIJOFS_* Joystick Device Constants. Is it OK to copy constant definitions from Microsoft's SDK? If not, can somebody help me or give some pointers on how to figure them out? This API call is needed at least for the Overlord game, which now works with my XBox 360 gamepad, but all action mappings are currently wrong. Thanks,

2 1

Re: [PATCH 2/3] wininet: Always set lpszUrlPath in InternetCrackUrlW.
by Alexandre Julliard 28 Dec '09

28 Dec '09

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/wininet/internet.c | 38 +++++++++++++------------------------- > 1 files changed, 13 insertions(+), 25 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so internet.c && touch internet.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x68699521 (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x68699521). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:68699521 ESP:0032d180 EBP:0032d1f8 EFLAGS:00010297( R- -- I S -A-P-C) EAX:cbcd24a4 EBX:686b1894 ECX:3432db62 EDX:6865b6c4 ESI:00000000 EDI:00000000 Stack dump: 0x0032d180: 00000000 00000000 00000000 00000000 0x0032d190: 00000000 00000000 00000000 00000000 0x0032d1a0: 00000000 00000000 00000000 0000000c 0x0032d1b0: 00000000 00000000 6865b6b8 00000000 0x0032d1c0: 00000006 00000000 00000000 00000000 0x0032d1d0: 00000000 00000000 00000000 00000000 Backtrace: =>0 0x68699521 InternetCrackUrlW+0x3c1(lpszUrl_orig=0x6865b6b8, dwUrlLength_orig=6, dwFlags=0, lpUC=0x32fb44) [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet (0x0032d1f8) 1 0x6869cd2c INTERNET_InternetOpenUrlW+0xec(hIC=0x148d18, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2846] in wininet (0x0032fb98) 2 0x6869d34e InternetOpenUrlW+0x10e(hInternet=0x1, lpszUrl=<register EDI not in topmost frame>, lpszHeaders=(nil), dwHeadersLength=0, dwFlags=0, dwContext=0) [/home/julliard/wine/wine/dlls/wininet/internet.c:2990] in wininet (0x0032fbf8) 3 0x6864d4f3 test_null+0x3f3() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:400] in wininet_test (0x0032fca8) 4 0x6864f71b func_internet+0xbab() [/home/julliard/wine/wine/dlls/wininet/tests/internet.c:850] in wininet_test (0x0032fd98) 5 0x686560c0 run_test+0x130(name="internet.c") [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:537] in wininet_test (0x0032fdd8) 6 0x686562ae main+0x11e(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:586] in wininet_test (0x0032fe88) 7 0x68656d34 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in wininet_test (0x0032feb8) 8 0x7b8769d5 start_process+0x55(peb=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/kernel32/process.c:1038] in kernel32 (0x0032fee8) 9 0x7bc6f9e4 call_thread_func+0xc() in ntdll (0x0032fef8) 10 0x7bc6fbc0 call_thread_entry_point+0x70(entry=0x7b876980, arg=0x7ffdf000) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2391] in ntdll (0x0032ffc8) 11 0x7bc4cd5a in ntdll (+0x3cd5a) (0x0032ffe8) 0x68699521 InternetCrackUrlW+0x3c1 [/home/julliard/wine/wine/dlls/wininet/../../include/wine/unicode.h:311] in wininet: cmpw $10,0x0(%edi) 311 for (end = ptr + n; ptr < end; ptr++) if (*ptr == ch) return (WCHAR *)(ULONG_PTR)ptr; -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [TRY 2] extrac32: Create directory tree before extraction
by Ilya Shpigor 28 Dec '09

28 Dec '09

Hi, Why this patch don't have been commited? There are mistakes? I really want to make extrac32 better, but I don't know what to do if nobody answer me. -- Best regards, Ilya Shpigor.

1 0

Re: Remove cpp_quote hackery from wined3d.idl (was: tools/widl: Split expr_int_const off from expr)
by Henri Verbeet 28 Dec '09

28 Dec '09

2009/12/24 Gerald Pfeifer <gerald(a)pfeifer.com>: > On Mon, 21 Dec 2009, Henri Verbeet wrote: >>> How shall we best tackle this? >> At least for the wined3d ones, we might as well just add them to the >> enum, the macros aren't strictly necessary. > > Done thusly. We just need to move WINEMAKEFOURCC to a local header, > the rest of the cpp_quote can go and we lose a couple of dozen warning > messages (rightfully) issued by GCC 4.5 snapshots. > I already sent pretty much the same patch, http://source.winehq.org/git/wine.git/?a=commitdiff;h=3288911ae3e3cbd7124ed…

2 2

Re: msvcrt: add some demangle features
by Eric Pouech 28 Dec '09

28 Dec '09

André Hentschel a écrit : > - > + if (*sym->current == 'A') sym->current++; > I don't understand how this would be necessary? Are you sure it's needed ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Re: wined3d: adjust glPolygonOffset size
by Henri Verbeet 27 Dec '09

27 Dec '09

2009/12/27 Austin English <austinenglish(a)gmail.com>: > See bug 18993. Original author is credited in patch ( Dorek Biglari ). > This doesn't look right from my understanding of the d3d9 depth bias behaviour. Afaik D3DRS_SLOPESCALEDEPTHBIAS is a multiplication factor for the maximum depth slope (i.e. difference in z-value over distance for a polygon's vertices), just like in OpenGL. I attached an alternative patch to the bug.

1 0

Re: qedit: Implement partially the Sample Grabber filter
by Rob Shearman 26 Dec '09

26 Dec '09

2009/12/23 Paul Chitescu <paulc(a)voip.null.ro>: > Changelog: > qedit: Implement partially the Sample Grabber filter > > The IMediaPosition, IMediaSeeking and IQualityControl interfaces are currently > not implemented at all. No programs I've tested tried to query them though. > > Buffering of samples is also not implemented yet, applications usually install > an ISampleGrabberCB callback. Thread-safety is non-existent in your newly written code. DirectShow uses multiple threads so I would say thread-safety is a requirement, not a nice-to-have. -- Rob Shearman

1 0

Re: Acting as advisor for wcmd-uplift project?
by Peter Dons Tychsen 25 Dec '09

25 Dec '09

On Tue, 2009-12-22 at 15:36 -0600, Austin English wrote: > Sure. FWIW, I'm working on some AutoHotKey/Appinstall tests for cmd, > but it's a bit difficult, since the only way to capture the stdout is > to pipe it to a file first. Hey, i think a test suite for cmd is an excellent idea, and is surely what is needed to lift the quality of this module. However, i think using AutoHotKey in an external script might not be the optimal solution. Why not place the test in the source tree along with all of the other tests. Of course this requires the tests to be run from a C based file and not a AHK file, as i doubt that AJ wants AHK in git. It would however mean that one could add tests for all of the other command line utility programs much easier (not possible now at all). I don't really see "cmd" as an external tool but and integrated part of the Wine product. Therefore i think these tests belong in the main git tree. In any case, tests are better than no tests! (just to state the obvious :-)) /pedro

2 1

Re: [3/5] WineD3D: Set WINED3D_BUFFER_CREATEBO in buffer_init
by Henri Verbeet 24 Dec '09

24 Dec '09

2009/12/22 Stefan Dösinger <stefan(a)codeweavers.com>: > + conv = ((FVF & WINED3DFVF_POSITION_MASK) == WINED3DFVF_XYZRHW ) || (FVF & (WINED3DFVF_DIFFUSE | WINED3DFVF_SPECULAR)); > hr = buffer_init(object, This, Size, Usage, WINED3DFMT_VERTEXDATA, > - Pool, GL_ARRAY_BUFFER_ARB, NULL, parent, parent_ops); > + Pool, GL_ARRAY_BUFFER_ARB, NULL, parent, parent_ops, conv); This looks questionable, we use the FVF to determine that the buffer is going to need conversion, but don't pass that FVF to the buffer itself? Shouldn't this just use the existing code in buffer.c to determine when we need conversion in the first place, and just drop the VBO when the overhead becomes too large? Note that if we have EXT_vertex_array_bgra we don't need conversion for the color data in the first place.

3 3

Re: [PATCH 2/5] wined3d: Focus the focus window.
by Stefan Dösinger 24 Dec '09

24 Dec '09

Am 22.12.2009 um 18:32 schrieb Henri Verbeet: > + SetFocus(This->focus_window); > + Is this correct for windowed rendering as well?

2 1

Re: [winspool 2/6] Move the dlopen of libcups to a separate function, allowing CUPS to be used prior to the full on loading of CUPS printers.
by Detlef Riekenberg 24 Dec '09

24 Dec '09

Hi Jeremy What is your reason for your work in winspool.drv? What are your plans? Even if the Patchset changes some things, it's not the correct location to do that. winspool.drv must not do anything with the registry or the driver files. winspool.drv must not use cups at all wineps.drv must not use cups at all That all belong to a print provider, together with a print monitor. To make our live easy, the printprovider and printmonitor for CUPS and LPR will be integrated into localspl.dll (windows is using seperate provider/monitor: See inetpp.dll and lprmon.dll with friends) I have a Patch here for moving AddPrinter to localspl, that address most of your changes, but a small peace of code is only in my test app and not in the Patch yet (get default DEVMODEW from the Driver) An important issue is, that we store DEVMODEA in the registry. Code is there to handle that, bu it failed on julliards machine. My localspl.dll has a cups.c, but that need more work(i can't continue before mid januar). And IMHO, using wine_get_unix_file_name in High-level dlls is wrong by design. W2k pro and XP pro have driver directories only for supported environments. (Servers are different) When you think, that you need the driver directories, they can be created with wine.inf Please avoid ANSI strings in new code. (strdupWtoA should go away) -- By by ... Detlef ___________________________________________________________ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/

3 2

Re: gdiplus: Add stub for GdipIsVisibleClipEmpty
by Alexandre Julliard 24 Dec '09

24 Dec '09

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Changelog: > gdiplus: Add stub for GdipIsVisibleClipEmpty You might as well implement it right away, it should be fairly trivial. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] wineboot: Generate the HKCU\Volatile Environment registry key.
by Alexandre Julliard 24 Dec '09

24 Dec '09

Andrew Nguyen <arethusa26(a)gmail.com> writes: > @@ -453,7 +453,6 @@ HKLM,Software\Microsoft\DirectPlay\Service Providers\Serial Connection For Direc > HKLM,Software\Microsoft\DirectPlay\Service Providers\Serial Connection For DirectPlay,"Path",,"dpmodemx.dll" > > [Environment] > -HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"APPDATA",,"%16410%" > HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"ComSpec",0x00020000,"%11%\cmd.exe" > HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"LOCALAPPDATA",,"%16412%" > HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"PATH",0x00020002,"%11%;%10%;%11%\wbem" Looks good, but you should do the same thing for LOCALAPPDATA. -- Alexandre Julliard julliard(a)winehq.org

1 0

<kein Betreff>
by Detlef Riekenberg 24 Dec '09

24 Dec '09

___________________________________________________________ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/

1 0

Re: [PATCH 1/2] comctl32/updown: Don't update buddy text if it's the same.
by Paul Vriens 24 Dec '09

24 Dec '09

On 12/22/2009 10:43 PM, Nikolay Sivov wrote: > Don't update buddy text if it's the same. > > There's at least one application that depends on this behavior: > http://bugs.winehq.org/show_bug.cgi?id=18574 > > This bug is closed cause crash no longer occurs in 1.1.35 due > a regression it contains, the real problem is fixed by this patch. Hi Nikolay, This one introduces a test failure on NT4 but I guess it's due to comctl32 4.72 and not the OS. NT4/4.72 sends a WM_SETTEXT instead of WM_GETTEXT (just tested, it's the only message). Could you have a look? The NT4 boxes at winetestbot.geldorp.nl have this issue. -- Cheers, Paul.

2 4

Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog
by Dmitry Timoshkov 24 Dec '09

24 Dec '09

"Steven Edwards" <winehacker(a)gmail.com> wrote: > - Removed the LoadLibrary calls in favor of GetModuleHandle as suggested > by Paul Vriens > - Match the bad formating of the rest of the file Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch much smaller. Also avoiding useless typedef, making WineFile_OnRun() static, using correct casts, avoiding hungarian notation and magic flags would make the patch slightly cleaner. -- Dmitry.

2 1

Re: winefile - replace Run/Execute dialog with standard Shell32 RunFileDlg
by Paul Vriens 23 Dec '09

23 Dec '09

On 12/23/2009 07:08 PM, Steven Edwards wrote: > + hShell32 = LoadLibraryW(wszShell32); Isn't shell32 already available (it's imported, see Makefile.in)? If so a GetModuleHandleW() would suffice. -- Cheers, Paul.

2 1

trivial cmd test suite
by Dan Kegel 23 Dec '09

23 Dec '09

http://kegel.com/wine/sweng/2010/#tests now points to a trivial test suite for cmd that is currently driven by a shell script (so on windows you need to install cygwin). Later I'll replace the shell script with a C program that bundles the test data into the executable to allow its use in WineTestBot and winetest. (I'm away from my office, so I haven't tested it on Wine yet.) Austin also has a small test for cmd in http://code.google.com/p/winezeug/source/browse/trunk/appinstall/scripts/cm… The main difference between the two is that people writing tests have to do lots of escaping in Austin's (because his test data is inline in the script) but not in mine (because test data is stored in external files during authoring; it will be packed into the executable later when I translate this into C). - Dan

1 0

Patch for mmdevapi/tests/dependency.c
by Paul Vriens 23 Dec '09

23 Dec '09

Hi Maarten, Your patch to fix the test failure for boxes with no soundcard was not committed (yet?). Would the following patch be ok? It also includes more cleanup. -- Cheers, Paul.

1 0

Parser for cmd language?
by Dan Kegel 23 Dec '09

23 Dec '09

There are lots of bugs filed for little (or big) problems in wine's cmd that involve parsing the command language: 21047 cmd does not handle for %%a in ('command') 21046 cmd does not handle all operators in 'if' command 20161 cmd can't handle echo commands containing quotes and redirection 19784 cmd doesn't handle ( ) scoping; breaks firefox build 18712 cmd: "if defined ... " command crashes. 18407 cmd.exe: set command seems broken 18346 cmd does not support the "^" escape character 18057 cmd.exe: mishandled quoted built-in commands with parameters (programs/cmd/wcmdmain.c: has_space==1 && opt_s==0) 15359 cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build. The existing parser in cmd is pretty weak. I wonder if it might not be time to write a new parser -- either using some parser generator tool, or more likely, a plain old recursive descent parser -- that can handle the language better. Also, some of the builtins need to be split out into separate executables, see e.g. 18059 - Unity Indie Trial exits because attrib.exe is missing (which might relax the requirements on the parser inside cmd slightly)

5 21

Re: [1/5] WineD3D: Revert the GL usage confusion
by Roderick Colenbrander 23 Dec '09

23 Dec '09

On Tue, Dec 22, 2009 at 4:51 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > We had a discussion in wine-devel a few days ago about which GL usage is better. The red book also agrees with the GL wiki, but the GL 3.0 spec uses the confusing language the extension used. > > In my performance testing there is no difference, which suggests that this is a rather academic issue, unless you happen to run a game that is exactly hitting your card's bus transfer limits and/or video memory limits, but not the CPU and GPU ALU performance limits. > I'm not convinced the code should be changed back. All docs mention to use DYNAMIC_DRAW. On some implementations there might be a difference. I don't see a reason to change it. Did you get a response on the question you submitted to opengl.org? From what I understood the main difference between STREAM_DRAW and DYNAMIC_DRAW is that in case of dynamic, system memory which can be accessed using DMA is used and else this guarantee isn't given. I would keep it at the value which is correct as indicated by all documentation. If you want to change it, tests should be carried out on different drivers and GPUs OR wait for the feedback from opengl.org/ Roderick

2 2

Re: [2/5] WineD3D: Use unload instead of duplicating buffer remove code
by Henri Verbeet 23 Dec '09

23 Dec '09

2009/12/22 Stefan Dösinger <stefan(a)codeweavers.com>: > - HeapFree(GetProcessHeap(), 0, This->conversion_shift); > + IWineD3DBuffer_UnLoad(iface); > + This->flags &= ~WINED3D_BUFFER_CREATEBO; UnLoad() doesn't free "conversion_shift".

2 1

Status check for patches 56770/56772
by Nathan Gallaher 22 Dec '09

22 Dec '09

Seeing if there was anything I can do to help either of these patches move along. Don't want them to get lost. ~Nate

2 1

Re: gdiplus: Implement GdipGet/SetStringFormatMeasurableCharacterRanges.
by Vincent Povirk 22 Dec '09

22 Dec '09

> + format->character_ranges = GdipAlloc(rangeCount * sizeof(CharacterRange)); > + if (!format->character_ranges) > + return OutOfMemory; > > - return NotImplemented; > + memcpy(format->character_ranges, ranges, sizeof(CharacterRange) * rangeCount); > + format->range_count = rangeCount; > + > + return Ok; > } Won't this leak memory if I set it twice? -- Vincent Povirk

1 0

Re: [2/4] imagehlp/tests: Add tests for adding/removing multiple certificates
by Paul Vriens 22 Dec '09

22 Dec '09

On 12/04/2009 05:11 PM, Owen Rudge wrote: > --- > dlls/imagehlp/tests/integrity.c | 68 > +++++++++++++++++++++++++++++++-------- > 1 files changed, 54 insertions(+), 14 deletions(-) > > Hi Owen, This test fails on Win95 but only because the size of the dll is not aligned on a 16byte boundary. Using a different dll on XP for this test (my XP box has 36,921 for imeshare.dll for example) also throws up an error. Would something like this be ok: file_size_orig = get_file_size(); + if (file_size_orig % 16 != 0) + { + trace("We need to adjust the file size\n"); + file_size_orig = ((file_size_orig / 16) + 1) * 16; + } Does anybody know if '16' is indeed the alignment needed? -- Cheers, Paul.

2 3

Re: advapi32/tests: Fix test crash in Wine
by Nikolay Sivov 22 Dec '09

22 Dec '09

On 12/22/2009 20:09, Vladimir Pankratov wrote: > Hello all. > > Fixed test crash in Wine. > > changed files: > dlls/advapi32/tests/eventlog.c > > Thanks. Looks like you're hiding a real problem. BTW, I don't see any crashes on Wine in test page. How did you test it?

2 1

Re: [1/2] wininet: Always set last error in HttpSendRequest{,Ex}.
by Paul Vriens 22 Dec '09

22 Dec '09

On 12/21/2009 11:13 AM, Hans Leidekker wrote: > + SetLastError(0xdeadbeef); > r = HttpSendRequest(hr, NULL, 0, NULL, 0); > + error = GetLastError(); > ok(r, "HttpSendRequest failed\n"); > + ok(error == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %u\n", error); Hi Hans, This one introduces 5 (sometimes extra) failures on Win98/WinMe: http://test.winehq.org/data/tests/wininet:http.html Not all test_basic_request() fail btw: test_basic_request(si.port, "GET", "/test1"); /* FAILS */ test_basic_request(si.port, "POST", "/test5"); /* FAILS */ test_basic_request(si.port, "RPC_IN_DATA", "/test5"); /* SUCCEEDS */ test_basic_request(si.port, "RPC_OUT_DATA", "/test5"); /* SUCCEEDS */ test_basic_request(si.port, "GET", "/test6"); /* FAILS */ test_basic_request(si.port, "GET", "/testF"); /* FAILS */ test_basic_request(si.port, "GET", "/quit"); /* FAILS */ For simplicity we could just add a broken() although that's not a 100% correct. Or only use broken() when dealing with GEt/POST? Thoughts? -- Cheers, Paul.

1 0

Re: mshtml: Added JavaScript tests architecture and simple tests.
by Alexandre Julliard 21 Dec '09

21 Dec '09

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/tests/Makefile.in | 2 + > dlls/mshtml/tests/jstest.html | 20 ++ > dlls/mshtml/tests/rsrc.rc | 20 ++ > dlls/mshtml/tests/script.c | 735 > ++++++++++++++++++++++++++++++++++++++++- > 4 files changed, 759 insertions(+), 18 deletions(-) > create mode 100644 dlls/mshtml/tests/jstest.html > create mode 100644 dlls/mshtml/tests/rsrc.rc It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so script.c && touch script.ok 0[157e88]: IMM32: InitKeyboardLayout, aKeyboardLayout=04090409, sCodePage=1252, sIMEProperty=00090000 0[157e88]: IMM32: InitKeyboardLayout, aKeyboardLayout=04090409, sCodePage=1252, sIMEProperty=00090000 0[157e88]: file wine:res://Z:/home/julliard/wine/wine/dlls/mshtml/tests/mshtml_test.exe/jstest.html, line 5: ReferenceError: external is not defined -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: tools/widl: Split expr_int_const off from expr
by Rob Shearman 21 Dec '09

21 Dec '09

2009/6/28 Gerald Pfeifer <gerald(a)pfeifer.com>: > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index c2f1abc..01aa060 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -622,56 +633,54 @@ m_expr: { $$ = make_expr(EXPR_VOID); } > | expr > ; > > -expr: aNUM { $$ = make_exprl(EXPR_NUM, $1); } > - | aHEXNUM { $$ = make_exprl(EXPR_HEXNUM, $1); } > +expr: expr_int_const > | aDOUBLE { $$ = make_exprd(EXPR_DOUBLE, $1); } > + | '-' aDOUBLE { $$ = make_exprd(EXPR_DOUBLE, -($2)); } This is covered by the production for the binary minus operator that already exists, so I'm not sure what you're trying to achieve here. > | tFALSE { $$ = make_exprl(EXPR_TRUEFALSE, 0); } > - | tNULL { $$ = make_exprl(EXPR_NUM, 0); } > | tTRUE { $$ = make_exprl(EXPR_TRUEFALSE, 1); } > | aSTRING { $$ = make_exprs(EXPR_STRLIT, $1); } > | aWSTRING { $$ = make_exprs(EXPR_WSTRLIT, $1); } > - | aIDENTIFIER { $$ = make_exprs(EXPR_IDENTIFIER, $1); } > | expr '?' expr ':' expr { $$ = make_expr3(EXPR_COND, $1, $3, $5); } > | expr LOGICALOR expr { $$ = make_expr2(EXPR_LOGOR, $1, $3); } > | expr LOGICALAND expr { $$ = make_expr2(EXPR_LOGAND, $1, $3); } > - | expr '|' expr { $$ = make_expr2(EXPR_OR , $1, $3); } > - | expr '^' expr { $$ = make_expr2(EXPR_XOR, $1, $3); } > - | expr '&' expr { $$ = make_expr2(EXPR_AND, $1, $3); } > | expr EQUALITY expr { $$ = make_expr2(EXPR_EQUALITY, $1, $3); } > | expr INEQUALITY expr { $$ = make_expr2(EXPR_INEQUALITY, $1, $3); } > | expr '>' expr { $$ = make_expr2(EXPR_GTR, $1, $3); } > | expr '<' expr { $$ = make_expr2(EXPR_LESS, $1, $3); } > | expr GREATEREQUAL expr { $$ = make_expr2(EXPR_GTREQL, $1, $3); } > | expr LESSEQUAL expr { $$ = make_expr2(EXPR_LESSEQL, $1, $3); } > - | expr SHL expr { $$ = make_expr2(EXPR_SHL, $1, $3); } > - | expr SHR expr { $$ = make_expr2(EXPR_SHR, $1, $3); } > - | expr '+' expr { $$ = make_expr2(EXPR_ADD, $1, $3); } > - | expr '-' expr { $$ = make_expr2(EXPR_SUB, $1, $3); } > - | expr '%' expr { $$ = make_expr2(EXPR_MOD, $1, $3); } > - | expr '*' expr { $$ = make_expr2(EXPR_MUL, $1, $3); } > - | expr '/' expr { $$ = make_expr2(EXPR_DIV, $1, $3); } > | '!' expr { $$ = make_expr1(EXPR_LOGNOT, $2); } > - | '~' expr { $$ = make_expr1(EXPR_NOT, $2); } > - | '+' expr %prec POS { $$ = make_expr1(EXPR_POS, $2); } > - | '-' expr %prec NEG { $$ = make_expr1(EXPR_NEG, $2); } > | '&' expr %prec ADDRESSOF { $$ = make_expr1(EXPR_ADDRESSOF, $2); } > | '*' expr %prec PPTR { $$ = make_expr1(EXPR_PPTR, $2); } > | expr MEMBERPTR aIDENTIFIER { $$ = make_expr2(EXPR_MEMBER, make_expr1(EXPR_PPTR, $1), make_exprs(EXPR_IDENTIFIER, $3)); } > | expr '.' aIDENTIFIER { $$ = make_expr2(EXPR_MEMBER, $1, make_exprs(EXPR_IDENTIFIER, $3)); } > | '(' type ')' expr %prec CAST { $$ = make_exprt(EXPR_CAST, $2, $4); } > - | tSIZEOF '(' type ')' { $$ = make_exprt(EXPR_SIZEOF, $3, NULL); } > | expr '[' expr ']' { $$ = make_expr2(EXPR_ARRAY, $1, $3); } > - | '(' expr ')' { $$ = $2; } > ; > > expr_list_int_const: expr_int_const { $$ = append_expr( NULL, $1 ); } > | expr_list_int_const ',' expr_int_const { $$ = append_expr( $1, $3 ); } > ; > > -expr_int_const: expr { $$ = $1; > - if (!$$->is_const) > - error_loc("expression is not an integer constant\n"); > - } > +expr_int_const: aNUM { $$ = make_exprl(EXPR_NUM, $1); } > + | aHEXNUM { $$ = make_exprl(EXPR_HEXNUM, $1); } > + | tNULL { $$ = make_exprl(EXPR_NUM, 0); } > + | aIDENTIFIER { $$ = make_exprs(EXPR_IDENTIFIER, $1); } aIDENTIFIER isn't necessarily a constant expression. > + | '~' expr_int_const { $$ = make_expr1(EXPR_NOT, $2); } > + | '+' expr_int_const %prec POS { $$ = make_expr1(EXPR_POS, $2); } > + | '-' expr_int_const %prec NEG { $$ = make_expr1(EXPR_NEG, $2); } > + | expr_int_const SHL expr_int_const { $$ = make_expr2(EXPR_SHL, $1, $3); } > + | expr_int_const SHR expr_int_const { $$ = make_expr2(EXPR_SHR, $1, $3); } > + | expr_int_const '+' expr_int_const { $$ = make_expr2(EXPR_ADD, $1, $3); } > + | expr_int_const '-' expr_int_const { $$ = make_expr2(EXPR_SUB, $1, $3); } > + | expr_int_const '%' expr_int_const { $$ = make_expr2(EXPR_MOD, $1, $3); } > + | expr_int_const '*' expr_int_const { $$ = make_expr2(EXPR_MUL, $1, $3); } > + | expr_int_const '/' expr_int_const { $$ = make_expr2(EXPR_DIV, $1, $3); } > + | expr_int_const '|' expr_int_const { $$ = make_expr2(EXPR_OR , $1, $3); } > + | expr_int_const '^' expr_int_const { $$ = make_expr2(EXPR_XOR, $1, $3); } > + | expr_int_const '&' expr_int_const { $$ = make_expr2(EXPR_AND, $1, $3); } Using "expr_int_const" instead of "expr" here prevents a many forms of expressions from being parsed. > + | tSIZEOF '(' type ')' { $$ = make_exprt(EXPR_SIZEOF, $3, NULL); } > + | '(' expr ')' { $$ = $2; } > ; > > expr_const: expr { $$ = $1; It looks like you'll have to find another way of fixing the issue you are trying to fix. -- Rob Shearman

3 2

Re: qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber
by Alexandre Julliard 21 Dec '09

21 Dec '09

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > qedit.dll: Add minimal stubs for NullRenderer and SampleGrabber. > > It doesn't make much sense to break this patch in two since most applications > connect a SampleGrabber to a NullRenderer to capture frames. That doesn't mean you can't split the patch. > +#define DEF_COMMON(iface)\ > +static ULONG WINAPI NullRenderer_ ## iface ## _AddRef(iface *ptr)\ > +{\ > + return InterlockedIncrement(&GET_THIS(ptr,iface)->refCount);\ > +}\ > +static ULONG WINAPI NullRenderer_ ## iface ## _Release(iface *ptr)\ > +{\ > + NR_Impl *This = GET_THIS(ptr,iface);\ > + ULONG refCount = InterlockedDecrement(&This->refCount);\ > + if (refCount == 0) \ > + {\ > + NullRenderer_cleanup(This);\ > + CoTaskMemFree(This);\ > + return 0;\ > + }\ > + return refCount;\ > +}\ > +static HRESULT WINAPI NullRenderer_ ## iface ## _QueryInterface(iface *ptr, REFIID riid, void **ppvObject)\ > +{\ > + return NullRenderer_query(GET_THIS(ptr,iface), riid, ppvObject);\ > +} > + > +/* Macro to put common IUnknown pointers in interface's vtable */ > +#define VTBL_COMMON(iface)\ > +NullRenderer_ ## iface ## _QueryInterface,\ > +NullRenderer_ ## iface ## _AddRef,\ > +NullRenderer_ ## iface ## _Release, Please don't add ugly macros like those, spell things out explicitly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 3/4] kernel32/path: Fix last error in SearchPathA/W with tests
by Paul Vriens 21 Dec '09

21 Dec '09

On 12/21/2009 02:32 AM, Nikolay Sivov wrote: > Fix last error in SearchPathA/W with tests > Hi Nikolay, Any reason all tests are relying on both the A- and W-version being available? SearchPathA is implemented on Win98. SearchPathW is exported but not implemented. This means the current tests will fail on Win98 for example: path.c:1490: Test failed: Expected ERROR_INVALID_PARAMETER, got 2 path.c:1497: Test failed: Expected ERROR_INVALID_PARAMETER, got 78 path.c:1504: Test failed: Expected ERROR_INVALID_PARAMETER, got 78 So SearchPathA returns something different for the last error and the SearchPathW tests already fail because GetWindowsDirectoryW() is not implemented (next to SearchPathW itself not being implemented of course). -- Cheers, Paul.

2 3

some 16 bit apps crash with gcc-4.3 (Ubuntu Intrepid); work with 4.2 (Hardy) - Caesar 3
by Joerg-Cyril.Hoehle＠t-systems.com 21 Dec '09

21 Dec '09

Hi, the news is that a few 16bit apps crash in Wine, apparently depending on the gcc version used to compile Wine. This was known to affect copy-protected apps, but in the present case, copy protection is not involved. >perhaps that old wine-1.1.16 was compiled with Ubuntu Hardy, not Intrepid... Indeed that is the difference: - Meine Traumburg (children game probably nobody knows outside Germany) crashes at start; - Caesar III from Sierra (mine is the German version) aborts before the second installer screen ("error 112") with no revealing error message or stack dump using a Wine compiled in Ubuntu Intrepid. They work fine with a Wine compiled in Ubuntu Hardy. Sorry, I don't use any newer Ubuntu (yet). Wine-1.1.16 and 1.1.34 behave the same. http://wiki.winehq.org/GccVersions mentions that some versions of gcc miscompile some code relevant for copy protection. However the above apps are not protected AFAICT! (They are trivial to install on HD without the need for the CD at run-time.) So gcc (presumably) affects "regular" code in Wine. The winesrc/include/config.h file on both systems is the same except for one line about mpg123; that's why I believe gcc is to blame (or Wine does some 16bit assembly magic that's not supported by gcc and thus produces random results). Hardy uses gcc-4.2 (Wiki page says "known to work/this isn't certain") Intrepid uses gcc-4.3 (Wiki page says "not tested") It would be interesting to re-evaluate bugs.winehq for bugs with keyword "win16". Regards, Jörg Höhle

1 0

Re: [2/2] wininet: Free per-thread error info upon exit from an async procedure.
by Jacek Caban 21 Dec '09

21 Dec '09

Hi Hans. On 12/21/09 11:14 AM, Hans Leidekker wrote: > Found by Valgrind. > --- > dlls/wininet/internet.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index d749e53..2b8d767 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -3127,8 +3127,12 @@ static DWORD CALLBACK INTERNET_WorkerThreadFunc(LPVOID lpvParam) > HeapFree(GetProcessHeap(), 0, lpRequest); > > workRequest.asyncproc(&workRequest); > - > WININET_Release( workRequest.hdr ); > + > + if (g_dwTlsErrIndex != TLS_OUT_OF_INDEXES) > + { > + HeapFree(GetProcessHeap(), 0, TlsGetValue(g_dwTlsErrIndex)); > + } > You have to set TLS value to NULL otherwise it will crash on next INTERNET_SetLastError in the same thread on another async call. But the right way to fix this is to get rid of INTERNET_[GS]etLastError. This is useless and has proven to result in code that has many failure paths without last error set. I've already removed most of these calls and I'm near to getting rid of all of them except ones in ftp.c. Thanks, Jacek

2 1

Isn't it a bug?
by Luis Busquets 21 Dec '09

21 Dec '09

From some time when I run Civilization4 I get a myriad of these messages and others with other formats: err:d3d:getColorBits Unsupported format: WINED3DFMT_R16G16_FLOAT err:d3d:IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt Unable to check compatibility for Format=WINED3DFMT_R16G16_FLOAT After looking in the wine code I have found out that what happens is that Civ calls the function IDirect3D9Impl_CheckDepthStencilMatch The implementation of wine then calls IWineD3D_CheckDepthStencilMatch which then calls IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…> for each format that the adapter supports until it finds a supported format: Problem: IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…> tries to match the supported pixel format of the adapter with the requested format. If the supported pixel format of the adapter is of type WGL_TYPE_RGBA_ARB, it tries to getColorBits of the format even if the format to try is a floating format, getColorBits responds with an error and same does IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…>. Certainly, the answer is correct (FALSE) but the problem is that it fills the screen with ERR that are due to wine checking things for which there is no need as they are directly false. So my question is if it is possible to do IWineD3DImpl_IsPixelFormatCompatibleWithRenderFmt <http://source.winehq.org/ident?i=IWineD3DImpl_IsPixelFormatCompatibleWithRe…> right away check if: cfg->iPixelType ==WGL_TYPE_RGBA_ARB <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_ARB> and format_desc is a floating format then return FALSE right away no need to fill ERR same if cfg->iPixelType ==WGL_TYPE_RGBA_FLOAT_AR <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_FLOAT_ARB>B <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_ARB> and format_desc is not a floating format then return FALSE right away no need to fill ERR If you do not like this solution, getColorBits could be modified so that it does not file an error for floating point formats but just responds with 0 for all bit sizes when the format is a floating point without filling an error. What do you prefer? Can somebody propose a patch with this kind of behaviour or something better so that my Civ4 does not respond with this myriad of errors? <http://source.winehq.org/ident?i=WGL_TYPE_RGBA_ARB>

2 2

Limit Bugzilla fields access
by Nikolay Sivov 21 Dec '09

21 Dec '09

Hi. I think it's not bad to remove some not useful in Wine's bugzilla fields from bug page: - whiteboard: what is it for? - difficulty - this really means nothing, usually set by reporter and not used by developers at all; - alias - used by reporters some times, but often reset by bugzilla buys (don't know why actually). Also it might be good to enable version field only on bug creation for people with report only permissions, version is often changed after reporter tested app again on newer version, after that bugzilla maintainers change it back and so on. The less the better, should be a rule here. Don't know is some of that fields configurable or code change required, but still I'm sure it's possible. Thanks.

2 1

WineTestBot changes
by Greg Geldorp 20 Dec '09

20 Dec '09

Updates to the test bot: - Improve log parsing and error reporting - Send notification email on job completion - Run winetest64-latest.exe on 64-bit machines - Show warning message if job is submitted without command line arg - Attempt to display times in users own timezone - Add possibility to set WINETEST_DEBUG and WINETEST_REPORT_SUCCESS env vars The code (LGPL) is now hosted on SourceForge in the "wine/winetestbot" git repository. Ge.

1 0

Broken-down time (struct tm)
by Erich Hoover 20 Dec '09

20 Dec '09

I will soon have access to a network license for a piece of software that uses the Sentinel Protection Driver (ie. I do not need USB support), so I am looking into implementing ExSystemTimeToLocalTime (Bug 19395) so that the driver will work properly. In the process of researching a good way to support this feature I found that the "broken-down time structure" (struct tm) has a member for the local timezone offset from GMT (tm_gmtoff). According to the man pages this feature requires that _BSD_SOURCE be defined before including time.h; however, I found this member being used in dlls/msvcrt/time.c without this #define. So, the question I have is whether it is OK to use tm_gmtoff in Wine (whether there is a portability concern) and the proper way to include time.h to use this feature. Erich Hoover ehoover(a)mines.edu

2 2

Recent User32 <=> windowClass assembly findings
by Nikolay Sivov 20 Dec '09

20 Dec '09

Hopefully my first attempt to implement class redirection wasn't committed --- http://source.winehq.org/patches/data/56761 --- cause it's definitely incomplete. After some testing I've got new info here (to be added to patch comments above): 1) not statically linked sxs module is loaded not only on window creation but on GetClassInfo() (GetClassInfoEx() is to be tested but I think it's the same). This is a case only on vista+ systems, xp doesn't attempt to load assembly on GetClassInfo(); 2) "versioned" attribute in windowClass element affects redirection behavior, when set to "no" user32 doesn't try to load assembly at all. Second problem requires a FindActCtxSectionString() to actually fill key data with undocumented format, I did some dumping basing on length value reported: similar way it's done for dll redirection test (with a dword pointer) and useful fields are actually obvious - such as classname and module name. First problem stops me cause I don't know what way to prefer here. Any advices are welcome. P.S. Maybe it helps - native returned class data in case of vista+ and comctl32 v6 contains pointers to winproc as "FFFFxxxx" format, high word is constant. Personally I don't know what is supposed to mean, builtin classes without redirection don't show such patterns.

1 0

Re: wine autodetec 32/64 application
by Roderick Colenbrander 20 Dec '09

20 Dec '09

Hi Giuseppe, Support for 64-bit is under heavy development and it our goal for Wine 1.2. A simple script to forward execution to 32-bit or 64-bit wine is not enough. Work is going on to integrate 32-bit and 64-bit Wine. Parts of the infrastructure for this are already in place (e.g. a shared wineserver) but other bits for a shared registry and prefix are still in development. It is not clear how we will invoke 32-bit or 64-bit Wine yet. I would recommend to check out Alexandre his keynote which discusses 64-bit Wine http://haar.student.utwente.nl/~julius/wineconf/julliardkeynote2009.ogv Roderick On Sat, Dec 19, 2009 at 5:17 PM, Giuseppe Della Bianca <bepii(a)libero.it> wrote: > Hi. > > This attached wine script can autodetect the wine 32/64 and application > PE32/PE32+, and autorun the correct wine program. > > This wine script support the application with name with space, and with > windows path. > > Regards. > Gdb > > > >

2 1

Conformance tess for cmd?
by Dan Kegel 19 Dec '09

19 Dec '09

Has anyone written conformance tests for cmd? I imagine they'd mostly just be a bunch of batch files with matching expected output files.

4 6

re: Broken-down time (struct tm)
by Dan Kegel 19 Dec '09

19 Dec '09

fwiw, looks like it might be a problem when building on Solaris: https://issues.asterisk.org/view.php?id=12022 Not sure what to do when that field is missing offhand.

1 0

Re: comdlg32: Check if the shell view exists before using it to execute commands
by Nikolay Sivov 19 Dec '09

19 Dec '09

On 12/19/2009 20:47, Paul Chitescu wrote: > Changelog: > comdlg32: Check if the shell view exists before using it to execute commands. > > Prevents crashing if trying to create new folder with a R/O Registry (which is > a bug by itself in a different module). > Don't you mind add a test for that and previous patches?

2 1

Re: [2/2][tools]winetest: fix filesize limit
by Paul Vriens 19 Dec '09

19 Dec '09

Hi André, On 12/19/2009 06:01 PM, André Hentschel wrote: > if (defined $dll) { We should only get here if we've received a start of a test but not the end. > # Either winetest crashed or the report file was cut off > $_=""; > - if ($filesize == $maxfilesize) { > + if ($filesize> $maxfilesize) { This can never happen as $maxfilesize is where it is cut off. The whole reason for this check is to decide whether we have a crash or "just" a file limit reached. If the size of the file is the maximum and we didn't get an end for the test we can assume it has been cut off at the sender. -- Cheers, Paul.

2 1

ucla dxdiag sources now in separate repo...
by Dan Kegel 19 Dec '09

19 Dec '09

... until they can be merged. That seems like a better solution than just keeping the patches around in hyperspace. The tree is at http://code.google.com/p/yadxdiag/ If anyone would like to help finish this up, please let me know. The spinning cube test is pretty cool. - Dan

1 0

re: msi: fix leak in cond.y
by Nate Gallaher 18 Dec '09

18 Dec '09

I should have mentioned in the commit message that this approach took heavy inspiration from the solution to the same problem in sql.y.

1 0

re: daily 16 bit tests?
by Dan Kegel 18 Dec '09

18 Dec '09

Joerg-Cyril.Hoehle wrote: > there have been a number of 16bit changes lately (accompanied by a > few regressions) and I've been wondering whether some bot somewhere > has been setup to execute 16 bit tests (I read that there's a 16bit > testsuite somewhere, not integrated into Wine tests)? The procedure for running the 16 bit tests is given at http://code.google.com/p/win16test/source/browse/trunk/src/README It'd be great to integrate them into the daily test runs somehow. Maybe they could at least be incorporated into winetest.exe? Tips: When installing openwatcom with winetricks, be sure to select 'all' rather than 'selective', or you'll end up without the 16 bit tools you need; the symptom will be 'make all' fails because it's trying to use 32 bit headers. About four tests hang currently - you have to kill them with ^C use touch to bypass them, and rerun 'make tests'. Of the tests that don't hang, three currently fail. And it looks like a few of the tests don't pass on all windows machines, see http://code.google.com/p/win16test/issues/detail?id=1

1 0

Re: [usp10 5/6] Fix the ABC width calculations in ScriptPlace
by Alexandre Julliard 18 Dec '09

18 Dec '09

Jason Green <jave27(a)gmail.com> writes: > - if (pABC) TRACE("Total for run: abcA=%d, abcB=%d, abcC=%d\n", pABC->abcA, pABC->abcB, pABC->abcC); > + if (pABC) > + { > + ABC tmp; > + > + > + /* the compositie 'A' width is simply the padding from the first glyph in the run */ > + get_cache_glyph_widths(psc, pwGlyphs[0], &tmp); > + pABC->abcA = tmp.abcA; > + > + /* the compositie 'C' width is simply the padding from the last glyph in the run */ > + get_cache_glyph_widths(psc, pwGlyphs[cGlyphs - 1], &tmp); > + pABC->abcC = tmp.abcC; > + > + /* since the 'B' width now includes the 'A' and 'C' widths, we must adjust it slightly */ > + pABC->abcB -= pABC->abcA + pABC->abcC; > + > + TRACE("Total for run: abcA=%d, abcB=%d, abcC=%d\n", pABC->abcA, pABC->abcB, pABC->abcC); > + } That's too complicated, there's no reason to retrieve the sizes twice, just handle that in the main loop. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [usp10 3/6] Fix the handling of spaces in ScriptBreak and ScriptShape
by Alexandre Julliard 18 Dec '09

18 Dec '09

Jason Green <jave27(a)gmail.com> writes: > commit 93b60cf8b1bcdabf008437b00cde35e162bdad1c > Author: Jason Green <jason(a)transgaming.com> > Date: Thu Dec 17 10:56:39 2009 -0500 > > Fix the handling of spaces in ScriptBreak and ScriptShape > From: Eric van Beurden <ericvb(a)transgaming.com> It doesn't work: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:1245: Test failed: fWhiteSpace set usp10.c:1256: Test failed: fWhiteSpace set make[2]: *** [usp10.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mapi32: add French translation
by Nicolas Le Cam 18 Dec '09

18 Dec '09

Hi Frédéric, Using "absence" and "installé" in the same sentence doesn't sound right. Something like "L'envoi de courriel a échoué car vous n'avez pas de client mail MAPI installé." or "L'envoi de courriel a échoué du fait de l'absence de client mail MAPI." should be simpler and more correct. -- Nicolas Le Cam

2 1

gcrypt windows build is done on linux, uses wine to run test suite
by Dan Kegel 18 Dec '09

18 Dec '09

Here's an interesting tidbit. gcrypt's windows version's only supported build environment is mingw on unix/linux, and it relies on wine to run its test suite. - Dan ---------- Forwarded message ---------- From: Simon Josefsson <simon(a)josefsson.org> Date: Thu, Dec 17, 2009 at 12:57 PM Subject: Re: gcrypt windows build To: "Hoyt, David" <hoyt6(a)llnl.gov> Cc: Werner Koch <wk(a)gnupg.org>, "gcrypt-devel(a)gnupg.org" <gcrypt-devel(a)gnupg.org> "Hoyt, David" <hoyt6(a)llnl.gov> writes: >> We only support cross-builds from a POSIX platform. If you try to build it on the traget platform it may or may not work. > > How do you test a cross-compiled library? How do you run your test > programs to validate your cross-compiled libraries are working > correctly? Do you have any tips on how I could get the test programs > working? Use wine. Just install MinGW and Wine under Linux, and then build libgcrypt like this: ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu It will invoke the self-tests automatically, if you have the binfmt-support package installed. If you want a makefile that does everything, check out <http://josefsson.org/gnutls4win/Makefile>. /Simon _______________________________________________ Gcrypt-devel mailing list Gcrypt-devel(a)gnupg.org http://lists.gnupg.org/mailman/listinfo/gcrypt-devel

2 1

daily 16 bit tests?
by Joerg-Cyril.Hoehle＠t-systems.com 18 Dec '09

18 Dec '09

Hi, there have been a number of 16bit changes lately (accompanied by a few regressions) and I've been wondering whether some bot somewhere has been setup to execute 16 bit tests (I read that there's a 16bit testsuite somewhere, not integrated into Wine tests)? I believe that would be a good thing to have. BTW, I've come across a weird situation where a 16bit app crashes in "recent" Wine. Actually, I've an old build of wine-1.1.16 which works, but when I recompile 1.1.16 (or anything more recent) nowadays, the app crashes. Except for Ubuntu's security updates and installation of libmpg123, I don't see what's changed on this machine. Anybody with similar experience? Hmm, perhaps that old wine-1.1.16 was compiled with Ubuntu Hardy, not Intrepid... Regards, Jörg Höhle.

1 0

Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.
by Eric Pouech 17 Dec '09

17 Dec '09

Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: dcec342b50524562844f64d43d423ed2c83c1f97 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Dec 11 14:52:28 2009 +0100 > > user32: Add a thunking mechanism for 16-bit edit word break procedures. > > > Alexandre, shouldn't the thunk be released in EDIT_WM_NCDestroy upon EDITSTATE destruction ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 3

Re: [5/5] WineD3D: Implement buffer subrange mapping with GL_APPLE_flush_buffer_range
by Henri Verbeet 17 Dec '09

17 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -85,6 +85,21 @@ static void buffer_create_buffer_object(struct wined3d_buffer *This) ... > + This->maps = HeapAlloc(GetProcessHeap(), 0, sizeof(*This->maps)); This is the wrong place for that. Either do it in buffer_init(), or in buffer_Map(). Keeping track of maps should also be in a separate patch, and you should integrate "lock_count". > +struct map_range A "wined3d_" prefix wouldn't hurt. > + LONG maps_size; Does a signed variable really make sense here? > + /* TODO: GL_ARB_map_buffer_range */ > + return gl_info->supported[APPLE_FLUSH_BUFFER_RANGE]; As a general rule, I think it makes sense to add support for ARB extensions (when available) before vendor specific extensions.

3 7

Re: [usp10 1/6] Fix an uninitialized static variable.
by Juan Lang 17 Dec '09

17 Dec '09

Hi Jason, - static const ABC nil; + static const ABC nil = {0}; This has no effect, as static variables are implicitly initialized to 0 anyway. It might be a little less surprising this way.. --Juan

3 6

Re: [dbghelp 1/2] Check for incorrectly set ClientPointers flag
by Eric Pouech 17 Dec '09

17 Dec '09

Jason Green a écrit : I don't think it's a good idea to change the exception structure passed by the caller to the minidump creation it's better to hard wire the optimization in dump_exception_info A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Valgrind warnings down 50% from last month
by Dan Kegel 17 Dec '09

17 Dec '09

The total count of valgrind warnings in the wine test suite has gone down from about 2000 a month ago http://kegel.com/wine/valgrind/logs/2009-11-16-19.12.errs.txt to about 1000 today http://kegel.com/wine/valgrind/logs/2009-12-15-07.57.errs.txt (as computed by http://kegel.com/wine/valgrind/logs/count.sh.txt ). Thanks to everyone who has been helping clean this up! Let's see if we can cut it down another 50% by this time next month...

1 2

Re: ddraw: Fix an incorrect refcount test
by Stefan Dösinger 17 Dec '09

17 Dec '09

Am 17.12.2009 um 20:20 schrieb Luke Benstead: > Luke. > <0001-ddraw-Fix-an-incorrect-refcount-test.txt> This patch is correct. The test intends to test DDraw7, there's a DDraw4 test below. So the variable name was wrong, not the macro.

1 0

Re: [shell32/tests] Initialize an APPBARDATA struct (Valgrind)
by Alexandre Julliard 17 Dec '09

17 Dec '09

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > Fixes some Valgrind warnings. > > Changelog > Initialize an APPBARDATA struct (Valgrind) That's just hiding the problem, an app can pass the same structure. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [usrmarshal] Adjust new tests to pass on win9x platforms.
by Jacek Caban 17 Dec '09

17 Dec '09

Hi Jeremy, On 12/17/09 12:13 AM, Jeremy White wrote: > --- > dlls/oleaut32/tests/usrmarshal.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dlls/oleaut32/tests/usrmarshal.c b/dlls/oleaut32/tests/usrmarshal.c > index e9c53e9..1c770de 100644 > --- a/dlls/oleaut32/tests/usrmarshal.c > +++ b/dlls/oleaut32/tests/usrmarshal.c > @@ -306,7 +306,8 @@ static void test_marshal_LPSAFEARRAY(void) > buffer = HeapAlloc(GetProcessHeap(), 0, size); > init_user_marshal_cb(&umcb,&stub_msg,&rpc_msg, buffer, size, MSHCTX_DIFFERENTMACHINE); > next = LPSAFEARRAY_UserMarshal(&umcb.Flags, buffer,&lpsa); > - ok(next - buffer == expected, "Marshaled %u bytes, expected %u\n", (ULONG) (next - buffer), expected); > + ok(next - buffer == expected || next - buffer + sizeof(DWORD) == expected /*win9x*/, > + "Marshaled %u bytes, expected %u\n", (ULONG) (next - buffer), expected); > It looks like a good place to use broken(). Thanks, Jacek

3 2

Re: [PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.
by Paul Vriens 17 Dec '09

17 Dec '09

On 12/15/2009 09:16 PM, Jacek Caban wrote: > --- > dlls/urlmon/binding.c | 6 +++++ > dlls/urlmon/tests/url.c | 58 ++++++++++++++++++++++++++++++---------------- > 2 files changed, 44 insertions(+), 20 deletions(-) > Hi Jacek, This one introduced a test failure: http://test.winehq.org/data/tests/urlmon:url.html I didn't find anything common for the boxes/OS, race? Could you have a look? -- Cheers, Paul.

4 4

Re: [PATCH] secur32: Fix memory leak in SECUR32_addPackages. (valgrind)
by James Hawkins 17 Dec '09

17 Dec '09

On Wed, Dec 16, 2009 at 5:07 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, this is for bug 21045. > + SecurePackage *prev_package = NULL; LIST_FOR_EACH_ENTRY(package, &packageTable->table, SecurePackage, entry) { + if (prev_package) + HeapFree(GetProcessHeap(), 0, prev_package); + prev_package = package; HeapFree(GetProcessHeap(), 0, package->infoW.Name); HeapFree(GetProcessHeap(), 0, package->infoW.Comment); } + if (prev_package) + HeapFree(GetProcessHeap(), 0, prev_package); I believe the construct you're looking for is LIST_FOR_EACH_SAFE. grep through the code for examples on using that to safely free and remove elements from a list. -- James Hawkins

2 1

Re: [1/2] gdiplus: Explicitly copy the bits from dib sections to new bitmaps.
by Paul Vriens 17 Dec '09

17 Dec '09

On 12/13/2009 12:59 AM, Vincent Povirk wrote: > Hi Vincent, It appears that this one introduced a test failure: http://test.winehq.org/data/tests/gdiplus:image.html One of the tests that fails now (line 533) was there for a long time it's just that you've added some stuff before that. The other one (line 1058) is because of the other patch "Add test for image palette functions." Could you have a look? -- Cheers, Paul.

2 5

Re: [PATCH] inetcomm/smtptransport.c : Fix a typo ?
by Juan Lang 16 Dec '09

16 Dec '09

Hi Amine, -static void SMTPTransport_CallbackMessageSendTo(IInternetTransport *iface, char *pBuffer, int cbBuffer); - > The actual function is a little bit under. Um, it's called a prototype, and it's needed to compile smtptransport.c. Have you tested this patch at all? --Juan

2 2

Re: [PATCH] inetcomm/smtptransport.c : Remove some unneeded variables and assigns.
by Juan Lang 16 Dec '09

16 Dec '09

Hi Amine, this patch has no functional benefit. For example, - HRESULT hr; TRACE("\n"); - hr = SMTPTransport_ParseResponse(This, pBuffer, &response); - if (FAILED(hr)) + if (FAILED(SMTPTransport_ParseResponse(This, pBuffer, &response))) This has the dubious benefit of removing a local variable that was used before. I can't fathom why this is a good thing. --Juan

4 7

Re: inetcomm/smtptransport.c : Remove some unneeded variables and assigns.
by Austin English 16 Dec '09

16 Dec '09

On Wed, Dec 16, 2009 at 12:28 PM, Amine Khaldi <amine48rz(a)gmail.com> wrote: > WBR, > Amine Khaldi. Out of curiosity, what tool are you using to find these bugs? -- -Austin

3 3

Re: hlink/hlink_main.c : Remove an unneeded assignment.
by Jacek Caban 16 Dec '09

16 Dec '09

Hi Amine, > r = register_clsid(&CLSID_StdHlink); > if (SUCCEEDED(r)) > - r = register_clsid(&CLSID_StdHlinkBrowseContext); > + register_clsid(&CLSID_StdHlinkBrowseContext); > > return S_OK; In this case the correct fix is to return r. Please be more careful then doing janitorial work. There are more places in your patches that seem questionable. You should make sure that we want to ignore an error instead of handling it (and usually we don't) before deleting such assignments. Otherwise it's just hiding bugs. Thanks, Jacek

2 1

Re: inetcomm/smtptransport.c : Remove some unneeded variables and assigns.
by Austin English 16 Dec '09

16 Dec '09

On Wed, Dec 16, 2009 at 12:28 PM, Amine Khaldi <amine48rz(a)gmail.com> wrote: > WBR, > Amine Khaldi. Out of curiosity, what tool are you using to find these bugs? -- -Austin

1 0

Re: [PATCH 07/10] urlmon: Added PARSE_DOMAIN to CoInternetParseUrl
by Paul Vriens 16 Dec '09

16 Dec '09

On 12/15/2009 11:47 PM, Piotr Caban wrote: > --- > dlls/urlmon/internet.c | 32 ++++++++++++++++++++++++++++++++ > dlls/urlmon/tests/misc.c | 23 +++++++++++++++++------ > 2 files changed, 49 insertions(+), 6 deletions(-) > > Hi Piotr, This one has introduced some test failures: http://test.winehq.org/data/tests/urlmon:misc.html Looks more OS than IE specific? Could you have a look? -- Cheers, Paul.

1 0

chromium wine valgrind bot up...
by Dan Kegel 16 Dec '09

16 Dec '09

More progress on my http://wiki.winehq.org/UnitTestSuites effort: Lei and I are running a buildbot that runs win32 chromium's unit tests under wine under valgrind. It just came up yesterday, and we're still working out some kinks, but you can see it at http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Linux%… Running a real app's test suite under valgrind+wine can find both bugs in wine and bugs in the app; here are examples of both found today by that bot: http://bugs.winehq.org/show_bug.cgi?id=21041 (mismatched GlobalLock/HeapFree in wine?) http://code.google.com/p/chromium/issues/detail?id=30584 (app forgot to initialize a bitmap?) It'll be interesting to see what else this turns up over time.

1 0

Re: [try 2] [2/7] mapi32: Correct the Simple MAPI parameters
by Henri Verbeet 16 Dec '09

16 Dec '09

2009/12/16 Owen Rudge <orudge(a)codeweavers.com>: > +214 stdcall MAPIFindNext(ptr ptr str str long long str) The last parameter is an output parameter.

1 0

Re: [2/5] winemapi: Add Simple MAPI functions
by Henri Verbeet 16 Dec '09

16 Dec '09

2009/12/15 Owen Rudge <orudge(a)codeweavers.com>: > + 1 stdcall MAPIAddress(ptr ptr ptr long ptr long long ptr long ptr ptr) > + 6 stdcall MAPILogoff(long long long long) > +11 stdcall MAPISendMail(long long ptr long long) These don't look quite right to me. Somewhat related, LHANDLE is a ULONG in include/mapi.h, but a ULONG_PTR in my copy of the PSDK.

2 1

Re: msvcrtd: free mem after use (valgrind)
by Paul Vriens 16 Dec '09

16 Dec '09

On 12/16/2009 03:25 PM, André Hentschel wrote: > --- > dlls/msvcrtd/tests/debug.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/msvcrtd/tests/debug.c b/dlls/msvcrtd/tests/debug.c > index 71f6e4c..dc89230 100644 > --- a/dlls/msvcrtd/tests/debug.c > +++ b/dlls/msvcrtd/tests/debug.c > @@ -60,6 +60,8 @@ static void test_new(void) > > mem = pMSVCRTD_operator_new_dbg(42, _NORMAL_BLOCK, __FILE__, __LINE__); > ok(mem != NULL, "memory not allocated\n"); > + if(mem != NULL) > + HeapFree(GetProcessHeap(), 0, mem); > } Hi André, There is no need to check before calling HeapFree. -- Cheers, Paul.

2 1

Re: msvcrtd: free mem after use (valgrind)
by Nikolay Sivov 16 Dec '09

16 Dec '09

On 12/16/2009 17:25, André Hentschel wrote: > --- > dlls/msvcrtd/tests/debug.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/msvcrtd/tests/debug.c b/dlls/msvcrtd/tests/debug.c > index 71f6e4c..dc89230 100644 > --- a/dlls/msvcrtd/tests/debug.c > +++ b/dlls/msvcrtd/tests/debug.c > @@ -60,6 +60,8 @@ static void test_new(void) > > mem = pMSVCRTD_operator_new_dbg(42, _NORMAL_BLOCK, __FILE__, __LINE__); > ok(mem != NULL, "memory not allocated\n"); > + if(mem != NULL) > + HeapFree(GetProcessHeap(), 0, mem); > } > > /**********************************************************************/ > Pointer check is redundant in this case.

1 0

Re: [PATCH 2/3] mmdevapi: Add stubs for MMDevEnum, with tests
by Alexandre Julliard 16 Dec '09

16 Dec '09

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > +static ULONG WINAPI MMDevEnum_Release(IMMDeviceEnumerator *iface) > +{ > + MMDevEnumImpl *This = (MMDevEnumImpl*)iface; > + LONG ref = InterlockedDecrement(&This->ref); > + TRACE("Refcount now %i\n", ref); > + return ref; > +} Sounds like you want a static object here too... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] WineD3D: Prepare for dynamic vertex buffers
by Henri Verbeet 16 Dec '09

16 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* buffer_get_sysmem can remove the BO from dynamic buffers */ No, it can't? > @@ -540,8 +547,8 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateVertexBuffer(IWineD3DDevice *ifac > TRACE("Not creating a vbo because GL_ARB_vertex_buffer is not supported\n"); > } else if(Pool == WINED3DPOOL_SYSTEMMEM) { > TRACE("Not creating a vbo because the vertex buffer is in system memory\n"); > - } else if(Usage & WINED3DUSAGE_DYNAMIC) { > - TRACE("Not creating a vbo because the buffer has dynamic usage\n"); > + } else if(!gl_support_dynamic_buffer(gl_info) && (Usage & WINED3DUSAGE_DYNAMIC)) { > + TRACE("Not creating a vbo because the buffer has dynamic usage but GL doesn't support dynamic buffers\n"); > } else if(!(Usage & WINED3DUSAGE_OPTIMIZE) && conv) { > TRACE("Not creating a vbo because the fvf needs conversion, but VB optimization is disabled\n"); > } else { It seems to me that this and similar code in CreateIndexBuffer() should be in buffer_init() instead.

2 1

Edit control messages through Comctl32 v6 module
by Nikolay Sivov 16 Dec '09

16 Dec '09

Hi. Yesterday I looked at XP introduced messages for Edit controls (EM_SETCUEBANNER/EM_GETCUEBANNER). This definitely doesn't work without v6 module loaded. Does someone have any idea how this supposed to work? Any comments are welcome as usual. P.S. Yes, I know that comctl32 does subclass user32 control but only if theming is active (I mean Wine behavior), anyway this subclass procedure only cares about painting messages, control specific messages require control data manipulation, and this isn't a preferable of course.

4 18

Re: [PATCH 10/10] urlmon: Added tests for CoInternetGetSecurityUrl
by Paul Vriens 16 Dec '09

16 Dec '09

On 12/15/2009 11:48 PM, Piotr Caban wrote: > --- > dlls/urlmon/tests/sec_mgr.c | 31 +++++++++++++++++++++++++++++++ > 1 files changed, 31 insertions(+), 0 deletions(-) > > Hi Piotr, Is there a way to avoid using lstrmcpW as that will always fail (or the !lstrcmpW case will always succeed) on Win9x/WinMe? It looks like the rest of this file use memcmp to compare strings. -- Cheers, Paul.

2 2

Re: [10/10] rpcrt4: Add tests for RPC calls with authentication.
by Paul Vriens 16 Dec '09

16 Dec '09

Hi Rob, I took the liberty of running these tests on winetestbot. It shows two errors for W2K and above: https://winetestbot.geldorp.nl/JobDetails.pl?Key=115 -- Cheers, Paul.

3 7

strangeness under Dec 14th Wine Git
by chris ahrendt 15 Dec '09

15 Dec '09

Just a little nit I noticed with yesterdays Git tree... When you give a window other than the wine window the focus... the wine window does not go into the background... so IF I have 2 or 3 windows open with a wine app running and click on say thunderbird... or firefox to look something up I have to move the wine window to the bottom of the screen. It looses focus (turns grey) but does not go to the background... Chris

1 0

[rfc] Provide separate operator vector new and delete in msvcrt; let valgrind check them
by Dan Kegel 15 Dec '09

15 Dec '09

First draft for discussion. Not, um, well tested yet. ANSI C++ mandates separate vector versions of new and delete that do the same thing as the non-vector versions, but which can be replaced by user apps (see http://www.csci.csusb.edu/dick/c++std/cd2/lib-support.html#lib.new.delete ) So far, so good; wine does that in msvcrt. However, once in a while, a programmer will call delete when he should have called delete[], and a bunch of destructors won't get called. To detect this programming error, let's split the vector new and delete functions off from their scalar twins, and add values for the heap function flags so we can inform valgrind what kind of blocks are being wrangled. This means picking two flag bits that Microsoft doesn't use; there seem to be enough to go around. Requires the corresponding patch to valgrind ttps://bugs.kde.org/show_bug.cgi?id=218741 Thanks to Steve Vandebogart for his help on this; he wrote a bunch of it.

2 1

Tests for GetLongPathName
by Paul Vriens 15 Dec '09

15 Dec '09

Hi Alexandre, Several file related functions have a maximum path size of 32767 when using a "\\?\" prefix. Testing these large paths only works on Windows due to Linux having a maximum path limit of 4096. Does it still make sense to add these tests or should I focus on <= 4096? I guess if we/Wine have a limit due to the OS we are running on we should probably act the same as that higher limit on Windows? -- Cheers, Paul.

2 1

Re: [PATCH 1/3] mmdevapi: Add class factory
by Alexandre Julliard 15 Dec '09

15 Dec '09

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > +static ULONG WINAPI MMCF_Release(LPCLASSFACTORY iface) > +{ > + IClassFactoryImpl *This = (IClassFactoryImpl *)iface; > + ULONG ref = InterlockedDecrement(&(This->ref)); > + TRACE("(%p) ref was %d\n", This, ref + 1); > + /* static class, won't be freed */ You don't need a refcount then. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdiplus: Fix a memory leak in the tests.
by Nikolay Sivov 15 Dec '09

15 Dec '09

On 12/15/2009 14:35, Huw Davies wrote: > Found by Valgrind. > --- > dlls/gdiplus/tests/customlinecap.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Hi, Huw. This leak will be fixed with corrected GdipCreateCustomLineCap(). Return code should never be Ok here. P.S. Same with previous patch for GdipCreateFontFamilyFromNam().

2 1

Re: [3/3] WineD3D: Don't enable render_to_fbo on single buffered swapchains
by Henri Verbeet 15 Dec '09

15 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > > Am 15.12.2009 um 08:14 schrieb Henri Verbeet: > >> 2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: >>> + && present_parameters->BackBufferCount > 0 >> "BackBufferCount" is unsigned. > Not even -Wall -pedantic complains about this, but okay. This patch compares against unsigned constants. > My point was just that you might as well just write "present_parameters->BackBufferCount", since it's never going to be below zero.

1 0

Re: msi: Replace the string table hash with a sorted index.
by Hans Leidekker 15 Dec '09

15 Dec '09

On Tuesday 15 December 2009 09:51:20 Hans Leidekker wrote: > Addresses a performance bottleneck in the Visual Studio 2005 installer. > See http://bugs.winehq.org/show_bug.cgi?id=14168 > --- > dlls/msi/msipriv.h | 2 +- > dlls/msi/string.c | 147 ++++++++++++++++++++++++++++++++++++++-------------- > 2 files changed, 109 insertions(+), 40 deletions(-) Please disregard this patch, Henri pointed out some improvements that can be made. -Hans

1 0

winetricks directx testers needed
by Austin English 15 Dec '09

15 Dec '09

Howdy all, I e-mailed wine-users a few days ago, but had no volunteers. I know most of you here aren't the target audience for using winetricks directx9, but since neither Dan or I game much, we need a guinea pig ;-). Long story short, someone complained that 'winetricks directx9' crashes on OS X, but works if the windows version is set to xp instead of 2k. I've played around with it a bit, and it seems that using xp gives a different set of installed files. Which one works better for games, however, I don't know. So, test it please. If you get wine from SVN, there's a beta of it: http://winezeug.googlecode.com/svn/trunk/winetricks just use 'winetricks directx9-beta' for the XP version, and 'winetricks directx9' for windows 2k (on OS X, it forces directx9-beta). Please let me know which version works better for games that need it. Any problems, file a bug at winezeug (http://code.google.com/p/winezeug/issues/list). For faster service, shoot me an e-mail, since I don't get e-mail notifications of any new bugs there... -- -Austin

3 6

Re: [PATCH 2/5] wined3d: Filter window messages generated by switching to fullscreen and back.
by Stefan Dösinger 15 Dec '09

15 Dec '09

This looks correct to me, I'm just asking to make sure I understand this correctly: > + filter_messages = swapchain->filter_messages; > + swapchain->filter_messages = TRUE; > + > SetWindowLongW(window, GWL_STYLE, style); > SetWindowLongW(window, GWL_EXSTYLE, exstyle); > SetWindowPos(window, HWND_TOP, 0, 0, w, h, SWP_FRAMECHANGED | SWP_SHOWWINDOW); > + > + swapchain->filter_messages = filter_messages; > } I am not seeing any place where swapchain->filter_messages is set so something other than FALSE, except of the same code in restore_fullscreen_window. Am I right to assume that this construct is meant to catch situations where the app's wndproc calls wined3d when receiving a WM_DISPLAYCHANGE message? > @@ -965,6 +976,13 @@ void get_drawable_size_swapchain(struct wined3d_context *context, UINT *width, U > LRESULT swapchain_process_message(IWineD3DSwapChainImpl *swapchain, HWND window, > UINT message, WPARAM wparam, LPARAM lparam, WNDPROC proc) > { > + if (swapchain->filter_messages) > + { > + TRACE("Filtering message: window %p, message %#x, wparam %#lx, lparam %#lx.\n", > + window, message, wparam, lparam); > + return CallWindowProcW(DefWindowProcW, window, message, wparam, lparam); > + } > + This calls the default Win32 wndproc in user32, and thus bypasses the app's wndproc, correct? There's the other call below added by patch 1 which calls proc instead. I'm asking because the lack of a ! in the if condition confused me at first.

2 1

Re: [2/3] WineD3D: Properly release client storage memory
by Henri Verbeet 15 Dec '09

15 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > + This->Flags &= ~(SFLAG_ALLOCATED | SFLAG_SRGBALLOCATED); That's pretty much what surface_force_reload() does.

1 0

Re: [3/3] WineD3D: Don't enable render_to_fbo on single buffered swapchains
by Henri Verbeet 15 Dec '09

15 Dec '09

2009/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > + && present_parameters->BackBufferCount > 0 "BackBufferCount" is unsigned.

1 0

Test suite under Intel drivers
by Jaime Rave 14 Dec '09

14 Dec '09

Hi wine devs, I'm writing you to ask some help to try to fix the the Wine test suite under the Intel drivers. I have already fill a bug with freedesktop but they are asking for some wine devs to give them some openGL test to add it to the piglit testcases. The bug is: http://bugs.freedesktop.org/show_bug.cgi?id=25432 Some words from the bug: "There are probably some actual bugs in our OpenGL, and there may also be bugs in the testcase. What it'll take to fix it is somebody (probably Wine developers/fans) isolating some OpenGL testcases for inclusion in piglit that will catch the bugs that this D3D test is hitting in OpenGL." Thanks in advance for your help. -- Jaime Rave Torres Ingeniero de Sistemas Miembro de la Fundación de Software Libre de Colombia http://www.fslcol.org/ http://sobrelibertad.blogspot.com/ 3003160361

2 1

Re: [PATCH 2/2] mmdevapi: Add more tests
by Paul Vriens 14 Dec '09

14 Dec '09

On 12/14/2009 10:09 AM, Maarten Lankhorst wrote: > + hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(mme, eRender, eMultimedia,&dev); > + ok(hr == S_OK, "GetDefaultAudioEndpoint failed: 0x%08x\n", hr); > + if (hr != S_OK) > + { > + skip("GetDefaultAudioEndpoint returns 0x%08x, skipping tests\n", hr); > + return; > + } Hi Maarten, This one introduces a failure on Vista+ (obviously) for boxes with a soundcard so it seems (by looking at other tests for these boxes): http://test.winehq.org/data/tests/mmdevapi:dependency.html Could you have a look? -- Cheers, Paul.

2 1

Re: [PATCH 14/14] [WineDbg]: fix some casts issues on 64bit platform
by Alexandre Julliard 14 Dec '09

14 Dec '09

Eric Pouech <eric.pouech(a)orange.fr> writes: > diff --git a/programs/winedbg/dbg.y b/programs/winedbg/dbg.y > index 855407f..7ed6307 100644 > --- a/programs/winedbg/dbg.y > +++ b/programs/winedbg/dbg.y > @@ -281,9 +281,9 @@ info_command: > | tINFO tCLASS { info_win32_class(NULL, NULL); } > | tINFO tCLASS tSTRING { info_win32_class(NULL, $3); } > | tINFO tWND { info_win32_window(NULL, FALSE); } > - | tINFO tWND expr_rvalue { info_win32_window((HWND)$3, FALSE); } > + | tINFO tWND expr_rvalue { info_win32_window((HWND)(DWORD_PTR)$3, FALSE); } > | tINFO '*' tWND { info_win32_window(NULL, TRUE); } > - | tINFO '*' tWND expr_rvalue { info_win32_window((HWND)$4, TRUE); } > + | tINFO '*' tWND expr_rvalue { info_win32_window((HWND)(DWORD_PTR)$4, TRUE); } > | tINFO tPROCESS { info_win32_processes(); } > | tINFO tTHREAD { info_win32_threads(); } > | tINFO tEXCEPTION { info_win32_exceptions(dbg_curr_tid); } It seems to me that it's expr_rvalue itself that should be a DWORD_PTR, it can be used to specify addresses at other places too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [usrmarshal] Check the actual size of safe arrays marshaled, not just projected size.
by Paul Vriens 14 Dec '09

14 Dec '09

On 12/11/2009 04:25 PM, Jeremy White wrote: > --- > dlls/oleaut32/tests/usrmarshal.c | 41 +++++++++++++++++++++++-------------- > 1 files changed, 25 insertions(+), 16 deletions(-) > Hi Jeremy, This one looks like to have introduced some test failures on Win9x/WinME: http://test.winehq.org/data/tests/oleaut32:usrmarshal.html Could you have a look? -- Cheers, Paul.

1 0

RE: WineTestBot
by Greg Geldorp 14 Dec '09

14 Dec '09

Hi Andre, > From: Andre Hentschel > > Some Questions/Suggestions by me: > - Are the VMs running on Computer at VMWare, on some Internetserver or at your home? I have a personal box (Dell SC1435, Quad core AMD Opteron @ 2.2 GHz, 16GB RAM) collocated at a large Dutch ISP. WineTestBot and the test VMs are all running on that box. VMware is not involved (yet?). > - IMO you should add pruning to your script, we are at about 120 tests and i guess old ones can be deleted Yes, I started working on a Janitor.pl script last weekend. Should be ready some time this week. The plan is to throw everything away that's older than a week. > - Will you add one or more Wine-Machines to cover that, too? It's not a priority for me, I might look at that once I get the bot to phase 3 (where it will watch wine-patches for test changes and run them automatically). Thanks for your feedback, Ge.

1 0

Re: Rob Shearman : msvcrt: Free memory allocated in TLS slot on module unload as well as thread exit.
by Nikolay Sivov 14 Dec '09

14 Dec '09

On 12/14/2009 18:51, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: c20868e0a2f7af909cf8af2877ae8b024fa6d11e > URL: http://source.winehq.org/git/wine.git/?a=commit;h=c20868e0a2f7af909cf8af287… > > Author: Rob Shearman<robertshearman(a)gmail.com> > Date: Mon Dec 14 14:13:57 2009 +0000 > > msvcrt: Free memory allocated in TLS slot on module unload as well as thread exit. > > --- > > dlls/msvcrt/main.c | 27 +++++++++++++++------------ > 1 files changed, 15 insertions(+), 12 deletions(-) > It's a partial solution I suppose? I works for a one thread only that unloads module.

2 2

WineTestBot
by André Hentschel 14 Dec '09

14 Dec '09

Hi, First i have to thank Mr. Geldorp for this really great gift :) Some Questions/Suggestions by me: - Are the VMs running on Computer at VMWare, on some Internetserver or at your home? - IMO you should add pruning to your script, we are at about 120 tests and i guess old ones can be deleted - Will you add one or more Wine-Machines to cover that, too? -- Best Regards, André Hentschel

1 0

Re: meaning of "Hardware" field in bugzilla?
by Dan Kegel 14 Dec '09

14 Dec '09

Sure, once it's far enough along... might be a bit early yet? On Dec 11, 2009 6:15 PM, "Tom Wickline" <twickline(a)gmail.com> wrote: On Sat, Dec 12, 2009 at 2:35 AM, Austin English <austinenglish(a)gmail.com> wrote: > > > Dan and I dis... If your going to re-work this I would also add ARM to the list, their has been some work to port Wine to the ARM processor lately. Anyone have any objections to adding a ARM selection to the list? ARM -> RISC Cheers, Tom

4 5

Re: msi: Add binary search to the string table.
by Henri Verbeet 14 Dec '09

14 Dec '09

2009/12/14 Hans Leidekker <hans(a)codeweavers.com>: > Addresses a performance bottleneck in the Visual Studio 2005 installer. > See http://bugs.winehq.org/show_bug.cgi?id=14168 Does it really make sense to maintain both a hash table and a binary search tree?

3 2

re: ntdll: Ignore the hole in the FILE_PIPE_WAIT_FOR_BUFFER structure passed into NtFsControlFile before writing the structure to the server.
by Dan Kegel 14 Dec '09

14 Dec '09

Rob's patch is the most precise solution. The macro should probably go in a .h file as it might be useful elsewhere. Alternately I can suppress all errors from functions like server_ioctl_file but it'd be better to just mark the holes as defined. Thanks, Rob!

1 0

weird and funky things happen when viewing guimark in ie6 in wine...
by Dan Kegel 14 Dec '09

14 Dec '09

Austin has a workaround for the problem that makes ie6 exit immediately ( http://code.google.com/p/winezeug/issues/detail?id=78 ). While testing it on guimark, wine ~.wine/drive_c/Program\ Files/Internet\ Explorer/IEXPLORE.EXE http://www.craftymind.com/factory/guimark/GUIMark_HTML4.html I noticed something strange when I closed ie6 after running for a few seconds. Either I see some sort of file leak (and this is with a fully vanilla fresh wine): ... wine client error:10c: pipe: Too many open files fixme:wininet:InternetSetOptionW INTERNET_OPTION_COOKIES_3RD_PARTY; STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_REQUEST_PRIORITY (-1): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CODEPAGE (65001): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_ERROR_MASK(11): STUB wine client error:10d: pipe: Too many open files fixme:wininet:InternetSetOptionW INTERNET_OPTION_COOKIES_3RD_PARTY; STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_REQUEST_PRIORITY (-1): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CODEPAGE (65001): STUB fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_ERROR_MASK(11): STUB ... or I see Building font metrics. This may take some time... Font metrics: 0.0% done ... and the whole long font metric rebuilding process, which should never be happening anymore for local X servers (right?). The "wine client error" comes from ntdll/server.c. It ought to be easy to get a backtrace from the problem using winedbg by setting a breakpoint, but I haven't managed to so far. Debugging this is complicated by the fact that GuiMark seems to crash my home router; maybe it does too many fetches too quickly. Do other people see this, too? Firefox seems to handle it well in wine, and doesn't show this problem. If this turns out to be an ie6 bug, we don't care, but there's some chance it's a wine bug. Guimark seems to be quite the stress test. - Dan

3 2

Re: (resend)shlwapi: implement SHPropertyBag_ReadLONG
by Jacek Caban 14 Dec '09

14 Dec '09

Hi Aric, On 12/11/09 10:44 PM, Aric Stewart wrote: > --- > dlls/shlwapi/ordinal.c | 25 +++++++++++++++++++++++++ > dlls/shlwapi/shlwapi.spec | 2 +- > 2 files changed, 26 insertions(+), 1 deletions(-) + hr = IPropertyBag_Read(ppb, pszPropName,&var, NULL); + if (SUCCEEDED(hr)) + *pValue = V_I4(&var); You should make sure that var is of VT_I4 type and return an error or do conversion if it's not. Thanks, Jacek

2 1

Re: ws2_32: Fix allocating a hostent with no h_aliases list.
by Alexandre Julliard 14 Dec '09

14 Dec '09

Erich Hoover <ehoover(a)mines.edu> writes: > @@ -4616,11 +4620,18 @@ static struct WS_hostent *WS_create_he(char *name, int aliases, int addresses, i > sizeof(char *)*aliases + > sizeof(char *)*addresses); > > - /* Place addresses in the allocated memory, making sure to have enough > - * room for the NULL at the end of the list. > + /* NOTE: Even if the alias and address lists are "empty" the list pointer must > + * be non-NULL and contain a single NULL item. > */ > + if (aliases == 0 || addresses == 0) > + { > + FIXME("Cannot create a hostent with an empty list pointer!\n"); > + return NULL; > + } That's an internal constraint in the code, it doesn't make sense to have a FIXME. If you really want a check it should be an assert(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Upcoming WWN
by Zachary Goldberg 14 Dec '09

14 Dec '09

Greetings Folks, As is the usual excuse "real life" has gotten in the way of producing quality and timely World Wine News issues. Dan Kegel recently had the idea of putting together a wiki page where the community as a whole can contribute to the next issue. I concurred and Dan put together the following page: http://wiki.winehq.org/RecentNewsQueue Which has a preface as follows: "This is the inbox for Wine Weekly News. The WWN editor invites Wine developers and users to submit articles here for inclusion in the next edition of WWN, but reserves the right to edit mercilessly. This page will be cleared each time a new WWN is published.' So, feel free to throw up some topics you would like to see discussed and maybe some extra detail that wouldn't ordinarily have showed up on wine-devel (you can include links to wine-devel too if you feel like being really nice to the editor :)). I'll post some ideas for articles during the day tomorrow (something about dsound and OpenAL anybody?) that hopefully we can flesh out along with ideas from the community at large. Cheers, -Zach

1 0

New winetricks 20091213: ie6 and gecko fixed; new verbs vcrun6sp6, python-comtypes, richtx32; less restrictive art2kmin, clearer license text.
by Dan Kegel 14 Dec '09

14 Dec '09

Austin and Andrew have been hard at work keeping winetricks working smoothly. In particular, the ie6 and gecko verbs should work again. Thanks guys! Changes since 20091125: Austin English: Workaround wine bug for IE6 Update shockwave sha1sum Add python-comtypes verb Explain windows licensing a bit better Gdiplus no longer comes from powerpoint viewer, update description accordingly Update DivX to latest version, remove obsolete /silent option Make append_path work if called more than once When installing gecko, regsvr32 mshtml afterward, so it actually works Update KDE to 0.9.6-5 When using native mdac, also override oledb32 Bump artk2min to 2007 Access runtime (freely redistributable, wooo!) Andrew Nguyen: Update flash to latest version. Check more exit codes. Update the vb6run verb to use the Service Pack 6 variant. Revise vcrun6 verb to remove more fake DLLs and more simply extract mfc42u.dll. Add vcrun6sp6 verb. (New verb rather than update of vcrun6 as it's a huge download.) Add richtx32 verb. Dan Kegel: Add heapcheck verb (for use with the not-yet-committed heapcheck patches) Avoid double-trying regedit Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.)

1 0

Re: mshtml: Implement IHTMLImgElement get_Name
by Jacek Caban 13 Dec '09

13 Dec '09

Hi Alistair, On 12/13/09 12:11 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mshtml: Implement IHTMLImgElement get_Name + nsres = nsIDOMHTMLImageElement_GetName(This->nsimg,&src_str); + if(NS_FAILED(nsres)) { + ERR("GetName failed: %08x\n", nsres); + return E_FAIL; + } You leak src_str here. +#define test_img_name(u) _test_img_name(__LINE__,u) +static void _test_img_name(unsigned line, IUnknown *unk) +{ + IHTMLImgElement *img = _get_img_iface(line, unk); + static WCHAR sNameImage[] = {'W','i','n','e','I','m','g',0}; Please make it more generic and avoid using lstrcmpW by getting expected name as const char* argument and using strcmp_wa to compare strings. Jacek

1 0

Re: [3/6]user32/tests: Test for SwitchDesktop API
by James McKenzie 13 Dec '09

13 Dec '09

shanmukha sainath addepalli wrote: > Hi, > > The test for SwitchDesktop has not submitted earlier. This test > performs switching between two desktops using SwitchDesktop API. > Will this test and the other test compile into winetest_latest.exe and will this test give the results you expect on any version of Windows (95 through 7)? These test should be added first before adding any code to the existing Wine base and validated to have correct values. James McKenzie

1 0

Re: [1/6]user32:SwitchDesktop API Implementation (try 2)
by Vitaliy Margolen 13 Dec '09

13 Dec '09

shanmukha sainath addepalli wrote: > Hi, > > These are the series of patches for the Implementation of > SwitchDesktop and OpenInputDesktop API in user32.dll. SwitchDesktop > API is useful for switching between two desktops. Multi desktop > applications use this API functionality to switch between desktops. > Each patch have to be atomic - it should compile on it's own and work. This and other patches in your series won't compile / work. > + SERVER_START_REQ( switch_desktop ) Here you depend on a service call that's not yet defined. Wine will not compile this way. Vitaliy.

1 0

Interfacing with AppDB database
by Sean Hodges 13 Dec '09

13 Dec '09

Hey all, I'm hoping to write an application that interfaces with the AppDB database. Can anyone point me in the direction of who I can contact over this? There appears to be no Web service or obvious way to query AppDB beyond navigating the site itself. Could you CC me in any replies as well, as I'm not subscribed to this list. Thanks, Sean

3 2

Re: mshtml: Implement IHTMLImgElement get_Name
by Paul Vriens 13 Dec '09

13 Dec '09

On 12/13/2009 12:11 PM, Alistair Leslie-Hughes wrote: > + ok_(__FILE__,line) (!lstrcmpW(sNameImage, tmp), "expected '%s' got '%s'\n", wine_dbgstr_w(sNameImage), wine_dbgstr_w(tmp)); Hi Alistair, Could you use strcmp_wa instead of lstrcmpW as that function is not present on Win9x/WinMe? -- Cheers, Paul.

1 0

meaning of "Hardware" field in bugzilla?
by Dan Kegel 13 Dec '09

13 Dec '09

Does "mac" mean "powerpc mac only"? I rather thought it meant "apple macintosh", regardless of cpu. I ask because Austin has just gone through and changed lots of "mac" bugs to "pc" even though the bugs were on Intel macs, which just seems wrong.

8 8

Sound concerns
by Maarten Lankhorst 12 Dec '09

12 Dec '09

Hi all, I believe most oconcerns about OpenAL have been addressed. One of the open questions was whether midi and wave would be synced. And I think the most likely answer is that they aren't, even on windows. On windows winmm midi drivers use winmm timeGetTime or QueryPerformanceCounter for DirectMusic. Sample accurate wave is used to sync with midi, by using exclusive mode or the asio model. If there are any other open concerns, apart from packaging, let me know, since I really want to get dsound openal merged. :) If there are still concerns that are open I would like to know, especially if they affect wasapi which is defined in include/audioclient.idl and audiopolicy.idl Cheers, Maarten.

3 5

Re: [3/3] winex11.drv: Use the old method to delete the desktop window.
by Alexandre Julliard 11 Dec '09

11 Dec '09

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > @@ -516,6 +516,14 @@ static void handle_wm_protocols( HWND hwnd, XClientMessageEvent *event ) > HMENU hSysMenu; > POINT pt; > > + if (hwnd == GetDesktopWindow()) > + { > + /* The desktop window does not have a close button that we can > + * pretend to click. Therefore, we simply send it a close command. */ > + PostMessageW( hwnd, WM_X11DRV_DELETE_WINDOW, 0, 0 ); > + return; > + } You could just as well send the WM_SYSCOMMAND directly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: WineD3D: Frontbuffers are always onscreen
by Henri Verbeet 11 Dec '09

11 Dec '09

2009/12/10 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -6304,7 +6304,7 @@ HRESULT create_primary_opengl_context(IWineD3DDevice *iface, IWineD3DSwapChain * ... > - swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > + swapchain->context[0]->render_offscreen = surface_is_offscreen(target); This will introduce a warning, surface_is_offscreen() takes an IWineD3DSurface pointer. > - > - swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; ... > + if(swapchain->context[0]) > + { > + swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > + } That's pretty ugly, couple of points: - It doesn't make sense for "render_to_fbo" to be TRUE for a swapchain without back buffer. - Setting "render_offscreen" is really the responsibility of the context_create() call, similar to create_primary_opengl_context(). - The line is actually wrong, the relevant context has been setup to render to the front buffer, so "render_offscreen" should always be FALSE, even if there is a back buffer.

2 6

Valgrind errors: 893 leaks, 105 conditional depends on uninit, 63 invalid read, 12 invalid write, ...
by Dan Kegel 11 Dec '09

11 Dec '09

Here's a more detailed breakdown of the current valgrind warnings when running the wine test suite as of yesterday, with the ntdll/heap warnings suppressed (as they will be from now on): 1 --25396-- VALGRIND INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - exiting 1 vex x86->IR: unhandled instruction bytes: 0xFB 0xC3 0x0 0x0 2 Source and destination overlap 3 Use of uninitialised value of size 4 4 Invalid read of size 1 4 Invalid write of size 4 4 Unhandled exception: illegal instruction 5 Unhandled exception: page fault on write 7 Unhandled exception: page fault on read 7 Invalid free() / delete / delete[] 8 Invalid write of size 1 14 Syscall param writev(vector[...]) points to uninitialised byte(s) 19 Invalid read of size 4 40 Invalid read of size 2 105 Conditional jump or move depends on uninitialised value(s) 893 X bytes are definitely lost I think *all* the remaining invalid write errors are bogus, either they're in GetDIBits, in a video driver, or in the stack backtracing code. All of the remaining invalid free errors are in the oleaut32 vartype test: Invalid free() / delete / delete[] at notify_free (heap.c:255) by RtlFreeHeap (heap.c:1748) by SysFreeString (oleaut.c:194) by test_VarBstrFromDate (vartype.c:4910) by func_vartype (vartype.c:6276) by run_test (test.h:535) by main (test.h:585) Address 0x7f0a1560 is not stack'd, malloc'd or (recently) free'd for which I've filed http://bugs.winehq.org/show_bug.cgi?id=20992

1 0

UNC Pathname handling
by Alexandre Hardy 11 Dec '09

11 Dec '09

Hi, I have written a patch to add basic UNC pathname support which tries to handle UNC pathnames according to the MSDN spec. The patch satisfies some of the UNC pathname tests for GetLongPathNameA, but is actually intended to fix GetLongPathNameW. I am not entirely satisfied with the patch, and would appreciate some comments. Some issues: 1) Paths prefixed by '\\?\' require GetLongPathName to handle strings of length 32767. I don't like the fact that the patch creates two such large strings on the local stack, should the memory be dynamically allocated only when needed? 2) The handling of shares \\hostname\C$ is implemented, but no other shares are handled. And even in this case, only the host on which wine is executed is handled, no other hosts are handled. I have read that Windows 7 disables this share by default. So should wine be handling this particular URL, or should more general sharing be implemented? The patch is included as an attachment to this message. Kind regards Alexandre -- -------------------------------------------------- Alexandre Hardy http://www.ahardy.za.net

2 16

Re: shdocvw: Fix test for non-english IE MUI (try 2)
by Nicolas Le Cam 11 Dec '09

11 Dec '09

2009/12/11 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > > > Changelog: > shdocvw: Fix test for non-english IE MUI > > Best Regards > Alistair Leslie-Hughes > > > > Hi Alistair, - ok(!strcmp_wa(sName, "Microsoft Web Browser Control"), "got '%s', expected 'Microsoft Web Browser Control'\n", wine_dbgstr_w(sName)); + if (PRIMARYLANGID(LANGIDFROMLCID(GetThreadLocale())) == LANG_ENGLISH) + ok(!strcmp_wa(sName, "Microsoft Web Browser Control"), "got '%s', expected 'Microsoft Web Browser Control'\n", wine_dbgstr_w(sName)); + else /* Non-English cannot be blant. */ + ok(sName!=NULL, "get_Name return a NULL string.\n"); Did you mean blank ? -- Nicolas Le Cam

1 0

Re: [PATCH 2/2] server: Include user groups in file mode calculation when user is file owner
by Alexandre Julliard 11 Dec '09

11 Dec '09

"Ben Peddell" <klightspeed(a)netspace.net.au> writes: > @@ -474,7 +475,9 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) > if (access & FILE_EXECUTE) > denied_mode |= S_IXUSR|S_IXGRP|S_IXOTH; > } > - else if (security_equal_sid( sid, owner )) > + else if (security_equal_sid( sid, owner ) || > + (security_equal_sid( user, owner ) && > + token_sid_present( current->process->token, sid, TRUE ))) > { > unsigned int access = generic_file_map_access( ad_ace->Mask ); > if (access & FILE_READ_DATA) > @@ -498,7 +501,9 @@ mode_t sd_to_mode( const struct security_descriptor *sd, const SID *owner ) > if (access & FILE_EXECUTE) > new_mode |= S_IXUSR|S_IXGRP|S_IXOTH; > } > - else if (security_equal_sid( sid, owner )) > + else if (security_equal_sid( sid, owner ) || > + (security_equal_sid( user, owner ) && > + token_sid_present( current->process->token, sid, FALSE ))) You should most likely set the group permissions too in that case. -- Alexandre Julliard julliard(a)winehq.org

2 3

Unable to cleanly install cups-devel.i686 on a Fedora 12 x86_64 machine
by Alex Villacís Lasso 11 Dec '09

11 Dec '09

I have just updated my setup to Fedora 12 on 64 bits, and I want to compile Wine for this setup. I followed the instructions at: http://wiki.winehq.org/WineOn64bit on the section for Fedora 12. However, I have the following error when trying to install the packages as directed by the wiki: Error en la verificación de la transacción: file /usr/bin/cups-config from install of cups-devel-1:1.4.2-7.fc12.i686 conflicts with file from package cups-devel-1:1.4.2-7.fc12.x86_64 Resumen de errores ------------- What I understand from this is that /usr/bin/cups-config is provided by both packages, and cannot be marked as shared by both packages. I want to have both 32 and 64-bit support for compiling programs that use CUPS. Does this problem have a clean workaround? Or should I complain instead to the Fedora packagers?

5 4

Re: [2/3] wineboot: Terminate processes immediately after WM_ENDSESSION.
by Juan Lang 10 Dec '09

10 Dec '09

Hi Vincent, - /* wait for app to quit on its own for a while */ - ret = WaitForSingleObject( process_handle, PROCQUIT_TIMEOUT ); + /* Check whether the app quit on its own */ + ret = WaitForSingleObject( process_handle, 0 ); CloseHandle( process_handle ); if (ret == WAIT_TIMEOUT) I'm confused why you removed the timeout. The documented behavior[1, 2] is to wait a short timeout, show a dialog if the app hasn't quit by then, then kill it. This change makes wineboot terminate a process immediately. Is this really necessary to fix the bug? I'd expect that you want to handle the WAIT_OBJECT_0 case in addition to the WAIT_TIMEOUT case, and leave the timeout alone. --Juan [1] http://blogs.msdn.com/michen/archive/2008/04/04/Application-termination-whe… [2] http://blogs.msdn.com/oldnewthing/archive/2008/04/21/8413175.aspx

2 2

Leaks galore!
by Dan Kegel 10 Dec '09

10 Dec '09

http://kegel.com/wine/valgrind/logs/2009-12-05-01.15/ shows the same results as http://kegel.com/wine/valgrind/logs/2009-12-04-18.45/ but with a looser filter, i.e. I now even show files whose only sin is a memory leak (in the past, I had suppressed those because I cared more about non-leak errors). It also suppresses several more persistent sources of warnings, for which I've filed a couple bugs: http://bugs.winehq.org/show_bug.cgi?id=20917 http://bugs.winehq.org/show_bug.cgi?id=20919 With those changes, I now see 457 non-leak errors, (~134 of which are due to the fresh regression http://bugs.winehq.org/show_bug.cgi?id=20920 ) and 1560 leak errors (~300 of which are due to ntlm_auth, which I'm still trying to suppress), in the wine conformance test suite.

5 12

Re: [ddraw/tests] Fix some test failures on Vista+
by Stefan Dösinger 10 Dec '09

10 Dec '09

Am 10.12.2009 um 13:21 schrieb Paul Vriens: > <0004-Fix-some-test-failures-on-Vista.patch> > const char *name; > DDPIXELFORMAT fmt; > BOOL getdc_capable; > + HRESULT alt_result; > } testdata[] = { You are setting the alt_result only for the 4 failing tests. I think C sets the others to 0 because the initializer is static data I think its better to explicitly set it in all other test formats to avoid confusion

2 4

Re: winedbg: Add spanish translation
by Paul Vriens 10 Dec '09

10 Dec '09

On 12/09/2009 03:30 AM, Jaime Rave wrote: > +LANGUAGE LANG_SPANISH, SUBLANG_DEFAULT Hi, Shouldn't this one need a SUBLANG_NEUTRAL instead? Or is this translation specific to "Spanish (Traditional Sort)"? See also: http://wiki.winehq.org/SublangNeutral -- Cheers, Paul.

1 0

Re: [PATCH 2/2] mmdevapi: add some initial tests
by Alexandre Julliard 10 Dec '09

10 Dec '09

1 0

Re: [PATCH 2/7] dsound: Clean up DSPROPERTY_DescriptionW, try 2
by Detlef Riekenberg 10 Dec '09

10 Dec '09

On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote: > + { > + /* FIXME: Still a memory leak.. */ This should be fixed before sending to wine-patches -- By by ... Detlef

2 1

Re: [3/5] WineD3D: Test and fix ddraw and d3d9 GetDC differences
by Paul Vriens 10 Dec '09

10 Dec '09

On 09/05/2009 04:54 PM, Stefan Dösinger wrote: > This patch uses a d3d9-side filter in favor of adding a 2nd set of > getdc-capable format flags. > Hi Stefan, These tests have failures on Vista+ boxes: dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_X8B8G8R8 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_A4R4G4B4 surface failed(0x88760249), expected it to work dsurface.c:3243: Test failed: GetDC on a D3DFMT_X4R4G4B4 surface failed(0x88760249), expected it to work These are real ones with NVIDIA, ATI and Intel cards but also VMware boxes with the latest VMware driver "VMware SVGA 3D (Microsoft Corporation - WDDM)". Should I change the test to introduce an alternative result for these 4 formats? -- Cheers, Paul.

2 1

Re: [PATCH 3/4] jscript: Added Function constructor tests.
by Detlef Riekenberg 10 Dec '09

10 Dec '09

On Do, 2009-12-10 at 01:15 +0100, Jacek Caban wrote: > +func = new Function(); > +tmp = func(); > +ok(tmp === undefined, "func(1,3,2) = " + tmp) Greetings from Copy & Paste -- By by ... Detlef

1 0

Re: Wine performance improvement
by 임은지 09 Dec '09

09 Dec '09

Dan Kegel wrote: > > > Interesting! Clearly a long ways off from production-ready, but > it's fun to see somebody trying this. > > A few notes: > > Please clean up the patch a bit to remove lines like this: > +//FIXME("handle : %ld \n", handle); > and extra files like > dlls/ws2_32/tests/test.sh > > Please avoid hand-editing > include/wine/server_protocol.h > The start of the file even says: > * This file is automatically generated; DO NO EDIT! > * Edit server/protocol.def instead and re-run tools/make_requests > > Please switch to plain text for future posts. It's very > hard to read in the archive; see > http://www.winehq.org/pipermail/wine-devel/2009-December/080394.html > > Please identify the author(s) of the new code for copyright purposes, > and ensure they agree to licensing their code under the LGPL (for Wine) > and GPL (for Linux kernel). > > I'm sure other people will have more to say. > Thank you for your comments. I will cleanup the patch as you suggested and send it.

3 2

Re: [PATCH] kernel32: Respect the LANG environment variable on Mac OS.
by Ken Thomases 09 Dec '09

09 Dec '09

The call to setenv() has 0 (false) as its third parameter, so that LANG is not overwritten. -Ken On Nov 23, 2009, at 9:12 AM, Charles Davis wrote: > --- > dlls/kernel32/locale.c | 53 > +++++++++++++++++++++++++---------------------- > 1 files changed, 28 insertions(+), 25 deletions(-) > > > > diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c > index fb9b517..d9ea8eb 100644 > --- a/dlls/kernel32/locale.c > +++ b/dlls/kernel32/locale.c > @@ -2925,32 +2925,35 @@ void LOCALE_Init(void) > UINT ansi_cp = 1252, oem_cp = 437, mac_cp = 10000, unix_cp; > > #ifdef __APPLE__ > - /* MacOS doesn't set the locale environment variables so we have to do it ourselves */ > - CFArrayRef preferred_locales, all_locales; > CFStringRef user_language_string_ref = NULL; > - char user_locale[50]; > - char* p; > - > - CFLocaleRef user_locale_ref = CFLocaleCopyCurrent(); > - CFStringRef user_locale_string_ref = CFLocaleGetIdentifier( user_locale_ref ); > - > - CFStringGetCString( user_locale_string_ref, user_locale, sizeof(user_locale), kCFStringEncodingUTF8 ); > - CFRelease( user_locale_ref ); > - /* Strip modifiers because setlocale() can't parse them. */ > - if ((p = strchr( user_locale, '@' ))) *p = 0; > - if (!strchr( user_locale, '.' )) strcat( user_locale, ".UTF-8" ); > - unix_cp = CP_UTF8; /* default to utf-8 even if we don't get a valid locale */ > - setenv( "LANG", user_locale, 0 ); > - TRACE( "setting locale to '%s'\n", user_locale ); > - > - /* We still want to set the retrieve the preferred language as chosen in > - System Preferences.app, because it can differ from CFLocaleCopyCurrent(). > - */ > - all_locales = CFLocaleCopyAvailableLocaleIdentifiers(); > - preferred_locales = CFBundleCopyLocalizationsForPreferences( all_locales, NULL ); > - if (preferred_locales && CFArrayGetCount( preferred_locales )) > - user_language_string_ref = CFArrayGetValueAtIndex( preferred_locales, 0 ); > - CFRelease( all_locales ); > + if (!getenv( "LANG" )) > + { > + /* MacOS doesn't set the locale environment variables so we have to do it ourselves */ > + CFArrayRef preferred_locales, all_locales; > + char user_locale[50]; > + char* p; > + > + CFLocaleRef user_locale_ref = CFLocaleCopyCurrent(); > + CFStringRef user_locale_string_ref = CFLocaleGetIdentifier( user_locale_ref ); > + > + CFStringGetCString( user_locale_string_ref, user_locale, sizeof(user_locale), kCFStringEncodingUTF8 ); > + CFRelease( user_locale_ref ); > + /* Strip modifiers because setlocale() can't parse them. */ > + if ((p = strchr( user_locale, '@' ))) *p = 0; > + if (!strchr( user_locale, '.' )) strcat( user_locale, ".UTF-8" ); > + unix_cp = CP_UTF8; /* default to utf-8 even if we don't get a valid locale */ > + setenv( "LANG", user_locale, 0 ); > + TRACE( "setting locale to '%s'\n", user_locale ); > + > + /* We still want to set the retrieve the preferred language as chosen in > + System Preferences.app, because it can differ from CFLocaleCopyCurrent(). > + */ > + all_locales = CFLocaleCopyAvailableLocaleIdentifiers(); > + preferred_locales = CFBundleCopyLocalizationsForPreferences( all_locales, NULL ); > + if (preferred_locales && CFArrayGetCount( preferred_locales )) > + user_language_string_ref = CFArrayGetValueAtIndex( preferred_locales, 0 ); > + CFRelease( all_locales ); > + } > #endif /* __APPLE__ */ > > setlocale( LC_ALL, "" ); > > >

7 19

Regression on Tuesday Dec 8
by Susan Cragin 09 Dec '09

09 Dec '09

I was installing Dragon NaturallySpeaking on Tuesday with git and noticed that it was very slow to load. In addition, the "automatic" registration doesn't work as well as it used to. The link to the Scansoft site, to generate the code, does not work. Regression test? Sigh.

1 0

Re: [1/5] ole32: Change the base IStorage filename to a pointer type.
by Paul Vriens 09 Dec '09

09 Dec '09

On 12/07/2009 10:17 PM, Vincent Povirk wrote: > + /* Stat always returns the full path, even for files opened with a relative path. */ > + GetCurrentDirectoryW(MAX_PATH, prev_dir); > + > + GetTempPathW(MAX_PATH, temp); > + > + SetCurrentDirectoryW(temp); > + > + GetFullPathNameW(filename, MAX_PATH, full_path,&rel_path); > + > + r = StgCreateDocfile( rel_path, STGM_CREATE | STGM_SHARE_EXCLUSIVE | > + STGM_READWRITE |STGM_TRANSACTED, 0,&stg); Hi Vincent, These tests currently crash on Win9x/WinME due . I rewrote that test to just use A-functions but there are loads of lstrcmpW tests that of course always fail on Win9x (not implemented). Do you think it's worthwhile changing these tests to cope with Win9x/WinMe? -- Cheers, Paul.

2 2

Re: libs/wine: don't try to read() a directory
by Alexandre Julliard 09 Dec '09

09 Dec '09

Dan Kegel <dank(a)kegel.com> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=20942 Introducing an fd leak to fix a Valgrind warning is not much of an improvement ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1

[PATCH] kernel32: Respect the LANG environment variable on Mac OS.
by Joerg-Cyril.Hoehle＠t-systems.com 09 Dec '09

09 Dec '09

Hi, perhaps I should contribute to this thread given that I indirectly triggered it via bug #20377. IMHO Wine, due to its sandbox nature, needs a way to switch language/locale independently on the desktop settings. Much like gcompris allows to choose a language other than the desktop's. No discussion, the default should be the desktop setting. So here, and in bug #20377, the issue is not the default setting. The issue is how to depart from the default. Now use LANG or LC_xyz to switch? The MacOS Terminal.app (as of 10.5.8) sets/shows very few environment variables. LANG is among them, none of LC_xyz is. Therefore I argue that LANG= is the canonical and reasonable choice for a local override on MacOS. It has the additional benefit of being + what Linux users are typically told to use (quick Google survey); + what the Wine Wiki recommends in http://wiki.winehq.org/TestingLanguages What's the relationship between LC_xyz and LANG? The official answer for programs using glibc is: "the library will test the environment variables LC_ALL, LC_CTYPE, and LANG in that order" But is glibc actually used on MacOS?? The Unicode FAQ says http://www.cl.cam.ac.uk/~mgk25/unicode.html "The LANG environment variable is used to set the default locale for all categories, but the LC_* variables can be used to override individual categories." So I don't understand the isolated recommendation of using LC_MESSAGES in this thread. My use-case is how to mimick a French, or Dutch, or Turkish, or any Asian MS-Windows environment, without switching my desktop to any of these (the "sandbox" idea again). LC_MESSAGES is not enough AFAIK. Ken Thomases writes: >I see no upside at all to changing LANG into an override where that's >not how it functions in any other context. I see no override involved here. On my Mac OSX 10.5.8 which is pretty much a base install, no LC_xyz is set. Therefore LANG does not override any LC_xyz setting. All I ask about LANG is that it overrides the desktop settings. If any LC_xyz were set, I expect them to take priority over LANG, like is documented and quoted above for glib and has been done for years in Linux. >Terminal (at least, recent versions) has a setting in its preferences >to set the locale environment variables in shells it creates. However, >it really only sets LANG according to the Region selected on the Formats >tab. It does not set individual LC_* variables. It completely ignores >the user's preferred language. I fail to see the problem. Only LANG is set, no LC_xyz therefore all UNIX apps launched within Terminal.app (or at least the glibc-based ones) should give a consistent answer, dictated by the LC_xyz/LANG defaulting rules. Should the next Apple update have Terminal.app set LC_xyz instead of LANG, I'd expect wine to obey them, because they take precedence over LANG. So actually, my wish is that Wine follows the LC_ALL/LC_xyz/LANG defaulting rules. Currently it does not. (I still need to check back on the Mac whether Wine follows LC_xyz). >(e.g. Japanese language, U.S. formats) Ken, is the use-case that you have in mind a Japanese user traveling to the U.S. (Jap. language, U.S. region/format)? Terminal.app sets LANG to US which you believe is wrong? My issue is not whether Terminal.app is broken or not. My issue is that if LANG is set, it should be obeyed, so the user gets consistent results (from a UNIX environment point of view). Regards, Jörg Höhle

4 5

Re: [PATCH 1/7] dsound: Implement DSPROPERTY_WaveDeviceMappingA on top of *W
by Alexandre Julliard 09 Dec '09

09 Dec '09

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > + data.DataFlow = ppd->DataFlow; > + len = strlen(ppd->DeviceName)+1; > + data.DeviceName = HeapAlloc(GetProcessHeap(), 0, len); > + if (!data.DeviceName) > + return E_OUTOFMEMORY; > + MultiByteToWideChar(CP_ACP, 0, ppd->DeviceName, -1, data.DeviceName, len ); The W length handling is broken. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/2] dsound: Only initialize 1 guid for capture and renderer
by Alexandre Julliard 09 Dec '09

09 Dec '09

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -355,8 +357,8 @@ HRESULT WINAPI DirectSoundEnumerateW( > if (devs > 0) { > if (GetDeviceID(&DSDEVID_DefaultPlayback, &guid) == DS_OK) { > static const WCHAR empty[] = { 0 }; > - for (wod = 0; wod < devs; ++wod) { > - if (IsEqualGUID( &guid, &DSOUND_renderer_guids[wod] ) ) { > + wod = guid.Data4[7]; > + if (wod < devs) { { Now that's an interesting indentation style... -- Alexandre Julliard julliard(a)winehq.org

2 1

Cruft left behind by tests
by Greg Geldorp 09 Dec '09

09 Dec '09

Hi Dmitry, During WineConf we briefly discussed files/registry keys left behind by running winetest.exe on Windows machines. I promised to look at that and then promptly forgot about it. Anyway, this is the list of files that get left behind when running the tests on a WinXP machine: C:\CustomMsi (hidden directory, empty) %Local AppData%\DCBC2A71-70D8-4DAN-EHR8-E0D61DEA3FDF.ini (new file, not really a .ini file, contains binary data) %SystemRoot%\Debug\UserMode\userenv.log (updated) %SystemRoot%\inf\test.PNF (new) %SystemRoot%\Installer\3a964.msi (plus 4 other .msi files) %SystemSystem%\d3d8caps.dat (new) %SystemSystem%\d3d9caps.dat (new) %SystemSystem%\test.PNF (new) %SystemSystem%\CatRoot\{C689AABA-8E78-11D0-8C47-00C04FC295EE}\TimeStamp (plus 2 other GUID-named directories below CatRoot) IE Cookies and History files get updated, some files get added to the IE cache And the registry keys: HKCU\Software\Microsoft\ActiveMovie\devenum\{083863F1-70DE-11D0-BD40-00A0C911CE86}\{8DE0E022-0111-43BA-9227-175BA62326EC} HKCU\Software\Microsoft\ActiveMovie\devenum\{4EFE2452-168A-11D1-BC76-00C04FB9453B}\Default MidiOut Device HKCU\Software\Microsoft\ActiveMovie\devenum\{E0F158E1-CB04-11D0-BD4E-00A0C911CE86}\Default DirectSound Device HKCU\Software\Microsoft\Direct3D\MostRecentApplication HKCU\Software\Microsoft\DirectInput\MostRecentApplication HKCU\Software\Microsoft\Installer\Products\D37A124635D9F784DAFD3ACC0AC92055 HKCU\Software\Microsoft\Multimedia\msacm.imaadpcm HKCU\Software\Microsoft\Multimedia\msacm.msgsm610 HKCU\Software\Microsoft\Multimedia\ActiveMovie HKCU\Software\Microsoft\Windows\CurrentVersion\Shell Extensions\Cached HKCU\Software\Microsoft\Windows Script\Settings HKCU\Software\Wine HKCR\Applications\shell32_test.exe HKCR\CLSID\{178fc163-f585-4e24-9c13-4bb7faf80646} HKCR\Installer\Products\D37A124635D9F784DAFD3ACC0AC92055 HKCR\Interface\{8CC497C0-A1DF-11CE-8098-00AA0047BE5D} HKCR\Interface\{8CC497C1-A1DF-11CE-8098-00AA0047BE5D} HKCR\Interface\{8CC497C2-A1DF-11CE-8098-00AA0047BE5D} HKCR\Interface\{8CC497C3-A1DF-11CE-8098-00AA0047BE5D} HKCR\Interface\{8CC497C4-A1DF-11CE-8098-00AA0047BE5D} HKCR\Interface\{8CC497C5-A1DF-11CE-8098-00AA0047BE5D} HKCR\TestScript HKCR\TypeLib\{00020430-0000-0000-C000-000000000046}\1.0\FLAGS HKCR\TypeLib\{8CC497C9-A1DF-11CE-8098-00AA0047BE5D} HKCR\Wine.Test HKLM\SOFTWARE\Microsoft\Cryptography\OID\EncodingType 0\CryptSIPDllIsMyFileType HKLM\SOFTWARE\Microsoft\Cryptography\OID\EncodingType 1\CertDllOpenStoreProv HKLM\SOFTWARE\Microsoft\Cryptography\OID\EncodingType 1\CertDllOpenStoreProv\DEFAULT HKLM\SOFTWARE\Microsoft\Direct3D\MostRecentApplication HKLM\SOFTWARE\Microsoft\DirectDraw\MostRecentApplication HKLM\SOFTWARE\Microsoft\DownloadManager HKLM\SOFTWARE\Microsoft\ESENT\Process\iphlpapi_test HKLM\SOFTWARE\Microsoft\RFC1156Agent HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\Folders HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\Managed\S-1-5-21-606747145-1604221776-839522115-1003\Installer\Products\D37A124635D9F784DAFD3ACC0AC92055 HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-18\Components\803D6B87EA8012A4EAA3ED9844C59F21 HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Installer\UserData\S-1-5-21-606747145-1604221776-839522115-1003\Products\C589F146D32331C48B665A7F3C562E47 HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\MCD HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\ICM\RegisteredProfiles HKLM\SYSTEM\LastKnownGoodRecovery\LastGood HKLM\SYSTEM\CurrentControlSet\Control\Session Manager HKLM\SYSTEM\CurrentControlSet\Control\StillImage\Debug\wiadss.dll HKLM\SYSTEM\CurrentControlSet\Enum\USB\BOGUS HKLM\SYSTEM\CurrentControlSet\Services\BITS HKLM\SYSTEM\CurrentControlSet\Services\TestService HKU\.DEFAULT\Software\Microsoft\Windows NT\CurrentVersion\Winlogon Ge.

2 2

Re: wineserver: Use existing file permissions as base for applying ACLs, change mapping logic
by Alexandre Julliard 09 Dec '09

09 Dec '09

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > wineserver: Use existing file permissions as base for applying ACLs, change > mapping logic. > > ACLs are applied over existing permissions. An ACCESS_ALLOWED_ACE by itself > will never reduce permissions. This doesn't make sense to me. A security descriptor with ACCESS_ALLOWED entries can still result in permissions being reduced. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw: Implement refresh in webbbrowser.c
by Jacek Caban 09 Dec '09

09 Dec '09

Hi David, David Anderson wrote: > > Implements WebBrowser_Refresh in shdocvw/webbrowser.c . > > Now a VB app with a 'refresh' button works, refreshing a web page > displayed by gecko with the current web page (it used to crash the app > because refresh returned an E_NOTIMPL). > > Tested with linux winetest.exe.so on Ubuntu 9.10 > with ATI graphics card. No new fails (retests are not 100% stable, but > close to stable), I tested several times before and after the change. > Fails are like other linux-wine results shown on test.winehq.org. This is obviously not the right implementation. It's just a hack. Also we don't have any test for this function, so testing with existing tests doesn't make much sense. WebBrowser *This = WEBBROWSER_THIS(iface); - FIXME("(%p)\n", This); - return E_NOTIMPL; + BSTR url; + HRESULT res; + + TRACE("(%p)\n", This); + res = WebBrowser_get_LocationURL(iface, &url); You don't need this call, you can access WebBrowser object here. + if( res != S_OK) { + FIXME("(%p)-> ERROR calling WebBrowser_get_LocationURL\n", This); + return res; + } + TRACE("(%p)->(%s )\n", This, debugstr_w(url)); + return navigate_url(&This->doc_host, url, NULL,NULL,NULL,NULL); You leak url here. Thanks, Jacek

1 0

Re: ntdll/tests: Fix a memory leak.
by Paul Vriens 09 Dec '09

09 Dec '09

On 12/08/2009 11:44 AM, Hans Leidekker wrote: > CloseHandle( dir ); > + pRtlFreeUnicodeString(&nameW ); This one makes the tests crash on 64bit Windows 7. Any idea why? The NtQueryDirectoryFile() just before that fails with ERROR_NO_MORE_ITEMS btw, but that's also true on my 32bit Win7 box. -- Cheers, Paul.

1 0

re: Wine performance improvement
by Dan Kegel 09 Dec '09

09 Dec '09

Interesting! Clearly a long ways off from production-ready, but it's fun to see somebody trying this. A few notes: Please clean up the patch a bit to remove lines like this: +//FIXME("handle : %ld \n", handle); and extra files like dlls/ws2_32/tests/test.sh Please avoid hand-editing include/wine/server_protocol.h The start of the file even says: * This file is automatically generated; DO NO EDIT! * Edit server/protocol.def instead and re-run tools/make_requests Please switch to plain text for future posts. It's very hard to read in the archive; see http://www.winehq.org/pipermail/wine-devel/2009-December/080394.html Please identify the author(s) of the new code for copyright purposes, and ensure they agree to licensing their code under the LGPL (for Wine) and GPL (for Linux kernel). I'm sure other people will have more to say.

1 0

Wine performance improvement
by Eun-Ji, Lim 09 Dec '09

09 Dec '09

1 0

Re: winhttp/tests: Fix test error when run as non-administrator
by Paul Vriens 08 Dec '09

08 Dec '09

On 12/08/2009 12:58 AM, Juan Lang wrote: > - ok(ret, "WinHttpSetDefaultProxyConfiguration failed: %d\n", GetLastError()); > + ok(ret || GetLastError() == ERROR_ACCESS_DENIED, > + "WinHttpSetDefaultProxyConfiguration failed: %d\n", GetLastError()); > > - set_default_proxy_reg_value( saved_proxy_settings, len, type ); > + if (ret) > + set_default_proxy_reg_value( saved_proxy_settings, len, type ); > } Hi Juan, I'm not a big fan of this. In theory we can now mess up our implementation and return ERROR_ACCESS_DENIED without knowing that something is wrong as the tests will still succeed. I agree that ERROR_ACCESS_DENIED is a valid return value but I'd rather have some win_skip() or at least a skip() in there. win_skip() will work fine right now but as soon as we implement access rights to the registry (and multi-user) it should probably be a skip(). -- Cheers, Paul.

2 1

The XFORM matrix in PlgBlt is calculated incorrectly
by Alexander Almaleh 08 Dec '09

08 Dec '09

2 1

Re: Wine sound discussion summary
by Stefan Dösinger 08 Dec '09

08 Dec '09

> Though, how would MIDI be handled. I think that OpenAL doesn't handle MIDI... Good question. As far as I can see PulseAudio doesn't support MIDI either, but it is certainly available in Alsa, CoreAudio and on Windows Vista, even though its more tricky to activate HW midi on Vista. Emulating MIDI through a software synthesizer won't fly, as this will make it impossible to use hardware instruments. A related topic: How do Joysticks connected to the gameport work(which is the same hardware connector as MIDI). I think that a joystick already takes an entirely different path in the Linux kernel and it doesn't get anywhere near a sound system, so we don't have to bother about it. Is that correct?

7 18

Re: Author: Maarten Lankhorst <mlankhorst@patser.(none)>
by Stefan Dösinger 08 Dec '09

08 Dec '09

> Author: Maarten Lankhorst <mlankhorst(a)patser.(none) Did you forget to configure your email address in git?

1 0

Re: shdocvw: Fix test for non-english IE MUI
by Jacek Caban 08 Dec '09

08 Dec '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > Either use this patch or patch "Added support for non-enligh IE MUI". > > Changelog: > shdocvw: Fix test for non-english IE MUI - ok(!strcmp_wa(sName, "Microsoft Web Browser Control"), "got '%s', expected 'Microsoft Web Browser Control'\n", wine_dbgstr_w(sName)); + ok(sName, "get_Name return a NULL string.'\n"); You don't need to delete the whole test. You can check for the system language and do the compare only if it's English. Jacek

3 2

Re: 1/2 wined3d: print warning/error to winediag [try2]
by Alexandre Julliard 08 Dec '09

08 Dec '09

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > { > - ERR("Direct3D%d is not available without opengl\n", dxVersion); > + ERR_(winediag)("Unable to initialize Direct3D%d due to lack of OpenGL support.\nMake sure OpenGL drivers are installed on your system and that Wine was compiled with OpenGL support.\n", dxVersion); I don't think you want that. One of the ideas behind winediag is that it should be machine-parsable, and adding new lines in the middle of traces will make that harder. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw: Added support for non-english IE MUI
by Paul Vriens 08 Dec '09

08 Dec '09

On 12/08/2009 11:10 AM, Alistair Leslie-Hughes wrote: > Hi, > When IE has support to display non-english menus, its returns a > translated string for the control name (get_Name) for the language being > used. > > > Changelog: > shdocvw: Added support for non-english IE MUI > > Best Regards > Alistair Leslie-Hughes > Hi Alistair, Although I can agree on adding this language support to the implementation, I'm not sure we want this in the tests. Someone has to keep the translations up-to-date in the tests. Next to that the new tests assume that our translation is exactly the same as Windows, not sure if we even want that. -- Cheers, Paul.

2 1

winetest + pbuffer + nvidia 190.18 drivers = X crash
by Austin English 08 Dec '09

08 Dec '09

Been happening for a few days...not sure what triggered it, but when coming back from work I see my login screen, which explains the lack of 64-bit tests/appinstall results. I don't know if any of the D3D guys could take a look, but I'd appreciate it... -- -Austin

2 4

Re: [PATCH] user32: Make DefWindowProc handle SHIFT+F10.
by Dmitry Timoshkov 08 Dec '09

08 Dec '09

"Kusanagi Kouichi" <slash(a)ac.auone-net.jp> wrote: > According to MSDN[1], DefWindowProc generates the WM_CONTEXTMENU > message when SHIFT+F10 is typed. > > [1] http://msdn.microsoft.com/en-us/library/ms647592.aspx Usually MSDN statements/descriptions shouldn't be taken as an action guide, a test case is required to see what happens in reality. At least a quick test shows that if a menu is activated pressing Shift+F10 does nothing. dlls/user32/tests/msg.c already has some tests for VK_APPS and VK_F10 press/release, please add a new test there. -- Dmitry.

1 0

Very long printernames and test failures
by Paul Vriens 08 Dec '09

08 Dec '09

Hi Detlef, Some test failures are shown on boxes with long printernames, for example: http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/vista_… http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/win7_1… And indeed if I create a local printer with a very long name the cutoff is one bigger than what the test is currently doing. The attached patch fixes that. I don't think this is enough though. Our implementation cuts of at '-1' from the looks of it. The best test would probably to add a printer in the tests and check for the size of the name in the strcut but I don't know how easy/intrusive that is. Any thoughts? -- Cheers, Paul.

2 3

Free VMware Workstation licenses for Wine developers
by Greg Geldorp 08 Dec '09

08 Dec '09

I already announced this at WineConf, but for people who were not there: VMware wants to support the Wine project by providing free of charge Workstation 7 licenses to Wine developers. We're not going to be too picky about the definition of "Wine developer". If you have been able to get a patch past Alexandre you've shown enough dedication to qualify ;-). There are a few restrictions on these licenses: - Not for resale - Not upgradable - No support entitlement If you want a license, just send me an email (off-list). Ge.

1 0

How does --with-wine64 work?
by Austin English 08 Dec '09

08 Dec '09

Vincent asked me to get add a --with-wine64 option to my build script. I was testing around, and can't seem to get it to work: $ mkdir - p $HOME/wine{32,64} $ cd $HOME/wine64 $ ~/wine-git/configure --enable-win64 $ make -j4 $ cd $HOME/wine32 $ ~/wine-git/configure --with-wine64=~/wine64 ... > checking for the directory containing the Wine tools... configure: error: could not find Wine tools in ~/wine64/ ~/wine-git/configure --with-wine64=~/wine64/tools/ ... checking for the directory containing the Wine tools... configure: error: could not find Wine tools in ~/wine64/tools/ What am I missing? Perhaps it needs to be installed somewhere first? -- -Austin

3 4

wine rejects development (Mouse "escapes" window or is confined to an area in the full screen program NO HACKS PLEASE)
by Peter Kovacs 08 Dec '09

08 Dec '09

Hi there, I want to bring this Issue up in Development Mailinglist. This proplem is about a bug that cant be fixed within wine, and The Bugtracker doesnt help it. I think this Bug is at the moment an Epic Fail of Open Source Development. (And needs to be solved so we get a accepted Fix somewhere someday) The Bug is Deadlocked. The Problem is in this Bug roughly spoken that in some games the Mouse movement is captured and not the real position. Now X only returns the real position. This Bug is a dependance of X (If I got it right). Since this Bug appeared people worked around this Bug by improving dirty hacks (by calculating mouse movement using weird? code), and maintaining them. And when Possible to make them switchable. Now Vitaliy Margolen actively stopped the maintenance of this workarounds (in the bug called dirty hacks.), by marking the patches obsolete and changing title. The Bug exist since 2009 - 12 - 06. And has a long thread. I understand the move of Margolen here. For that you need to look at the Bug history (clicky: http://bugs.winehq.org/show_bug.cgi?id=6971). And I dont put blame on his move. But for this Bug wine needs another political solution. Just stopping people to write hacks, dirty or not will stop people reaching in more and more patches. This sole incident wont have an effect on hole development but most bugs I followed started with a dirty hack. And this is definitely giving the wrong impression on wine. What I want to say, Margolens move might be technical right, but is political pretty lame. Atm I don't see any ability that the bug will be proper fixed. 1) I Xorg may implement the Problem or may not. Maybe they are even not aware(? - Haven't took a look) The Bug-tracking in wine does not contain a Link to the Bug-tracking in Xorg. 2) I am betting wine - Dev has no one working on the Bug actively. So how can we get a proper Fix or point people towards proper fixes? Is it right to have no Dirty Hack solution which just works? Do you think by stopping Hacks you will encourage development in what (you) think is the right solution? Where is the Xorg Link for this Problem since it is a problem interesting wine but maybe not Xorg? Before anyone asks, I don't have the Time to solve this Bug. Nor I do believe does any one of the "dirty" hackers. Or they had done it Proper by now. Thanks Listening, hope you got the Problem I want to address. I am not on the list since I develop nothing for wine. I would it appreciate it a lot, if I could stay with the discussion by keeping my email address in CC Regards Peter

5 6

Wine sound discussion summary
by Stefan Dösinger 07 Dec '09

07 Dec '09

Hi, For those who didn't follow the big dsound argument thread, here is a quick summary of the main points. I originally inteded this as a summary mail, but while collecting the arguments I have instead taken the discussion off-list accidentally. But here's the current state: Pretty much everyone agrees that the current sound infrastructure is broken. In terms of how to fix it, there are 3 points to be worked out. 1) Use OpenAL or a more sophisticated driver infrastructure 2) If no OpenAL, what do we use 3) How do we get there. I'll mostly focus on (1) here, as the others depend on the decision of (1). On Wineconf we decided to give killing our entire sound infrastructure a try and replace it with a winmm and dsound based on OpenAL. That wasn't a promise by Alexandre to commit it, more an investigative study. The advantages of that would be: * A compact Wine sound system, we don't have many different sound drivers. OpenAL is available on all operating systems * We can let Linux(dmix, pulseaudio) do some or all of the mixing(with openal.so improvements) * Outsource workarounds for Alsa/PulseAudio/Coreaudio bugs to openal * Supporting DirectSound 3D is easy - openal just has it available. No need to reinvent the wheel. There are still a lot of dsound 3d games from WinXP and earlier. * Hardware accelerated 3D sound is possible. Currently there are no Linux drivers for that though. * Winmm, dsound and Windows openal.dll interaction still works fine as long as all libs interact with openal in the same way Disadvantages: * We have less control over our sound infrastructure and might get into troubles if some apps depend on the underlying driver system * We depend on the system openal. Linux distros have to keep their 32 bit openal updated. Getting bugfixes shipped to users might take years. MacOS OpenAL seems pretty broken. * Outsourcing bug workarounds is a slippery slope. It will be hard or impossible to work around problems without openal and distro help(and we need help again to get them fixed properly). * OpenAL is essentially just an abstraction layer not any system's native way to do sound. * Dsound 3D is dead in Win7, maybe we shouldn't focus our design decision on it 2) If no OpenAL, what do we use The consensus is mostly that if we don't use OpenAL for abstraction then we would aim for the Windows 7 sound driver API, or something very close to it. The goodies include a) Its the way Windows does it. b) If Win7 has user space audio driver support we might be able to use those drivers c) Technically native dsound and winmm might work, which can be helpful for debugging d) No bad surprises when apps start screwing around with the internals(e.g. load an DRM decryption APO into the sound processing chain). Problems of this sound infrastructure include: * It is very complex and maybe a lot more than we need. * The Windows 7 sound model mandates software mixing. We'd have a audiodg.exe process running that mixes all streams from all processes. Add in pulseaudio or dmix, and maybe dsound has to do its own mixing and you have 3 software mixers in a chain. But maybe that's a place where we can deviate from the MS design, or use mixing plugins provided by our drivers. * It rules out hardware accelerated dsound3d. Although a user might install Creative's openal wrapper or similar software to get back HW dsound 3D in the windows 7 way, with all its pros and cons. Most new 3D sound games use openal natively. * For full compatibility to drivers and native libs we'd need the DDK, and nobody checked the license terms so far. 3) How do we get there. This obviously depends on what we do, and we probably won't do much before the 1.2 release. For the OpenAL way, we could just throw in the code Maarten wrote so far, or Chris' Dsound->OpenAL wrapper. For Win7, one idea was to implement one more Win 3.1 sound driver in Wine that is based on the Win7 infrastructure, then implement that infrastructure and move winmm and dsound over. Once this is done, throw out the old Win 3.1 stuff. Or implement the Win7 infrastructure and maintain a separate dsound and winmm off-tree(developed on Windows), and put them in place once the Win7 driver infrastructure in Wine is solid enough.

7 15

Re: 2/2 WGL: move some traces to winediag
by Henri Verbeet 07 Dec '09

07 Dec '09

2009/12/7 Roderick Colenbrander <thunderbird2k(a)gmail.com>: > Use this version instead. The last version contained some updates to > the wined3d winediag patch. > Sending this to winediag does mean it won't show up in +wgl traces anymore. Do we want that?

2 1

Please Review - Revised OS X Application Bundle patch
by Joerg-Cyril.Hoehle＠t-systems.com 07 Dec '09

07 Dec '09

Hi, + * NOTES: An Application Bundle generally has the following layout + * + * foo.app/Contents + * foo.app/Contents/Info.plist + * foo.app/Contents/MacOS/foo (can be script or real binary) + * foo.app/Contents/Resources/appIcon.icns (Apple Icon format) + * foo.app/Contents/Resources/English.lproj/infoPlist.strings + * foo.app/Contents/Resources/English.lproj/MainMenu.nib (Menu Layout) Could you please comment on why you think that using a .app is the right approach? (please explain the goal: provide desktop icons?) What do you plan to put into that bundle? What would the menu be? (Is there one at all?) As an alternative, I've been creating .command files, as explained in the FAQ http://wiki.winehq.org/MacOSX/FAQs They seem conceptually simpler yet provide what you'll find in the xyz.desktop file that Wine produces on Linux: - Icon - Terminal window that shows Wine's log and I/O from application. Where does such output go in the .app case? - file name - Change Directory to app's directory (or any other) It does not depend on wine start /unix Isn't that missing from your patch: + fprintf(file, "#!/bin/sh\n"); + fprintf(file, "WINEPREFIX=\"%s\" wine \"%s\" %s\n\n", + wine_get_config_dir(), path, args); This information is present in the .desktop files - Move the icon anywhere you like and click to start it. There's no dependency on Applications/ or any other setting. - Easily modified by the user to change WINEPREFIX, add WINEDEBUG or whatever -- if needed at all. You'll remember that I presented my approach on 2009-09-14 in this list. I was wondering whether Wine should create such xyz.command files on MacOS instead of the xyz.desktop ones. They are so close to each other. Perhaps it is precisely that additional Terminal.app window that you or other Mac users might dislike? (I've not investigated whether there are "hide" or "auto-close on exit" properties that could be set.) Regards, Jörg Höhle

3 9

Re: [PATCH 1/6] mshtml: Forward IHTMLFrameElement::get_dispid and invoke to its content window
by Jacek Caban 07 Dec '09

07 Dec '09

Hi Andrew, This idea looks bad. What are you trying to fix? Jacek

2 1

dxgi:device tests crash on X64_64
by Paul Vriens 07 Dec '09

07 Dec '09

Hi Henri, I'm trying to fix at least the crashes on X64_64 for this test. The tests are done on a Windows 7 64bit VMware guest. The strange thing is that when I crosscompile the tests as is (64bit of course) the tests don't crash. When I add the following (first thing): BOOL is_wow64; IsWow64Process( GetCurrentProcess(), &is_wow64 ); the tests crashes at DXGID3D10CreateDevice() in create_device(). I added that IsWow64Process() just to see if I was indeed running the 64bit version of the test. Any idea what's going on? -- Cheers, Paul.

2 7

Re: [PATCH] winhttp: check for endCert being NULL (Coverity)
by Juan Lang 06 Dec '09

06 Dec '09

Hi Marcus, - if (ret) + if (ret && endCert) ret = netconn_verify_cert( endCert, store, server ); In this case you'll return TRUE if endCert is NULL, implying that the certificate chain is valid when it most likely isn't, or at least its validity couldn't be verified. If you could add an "else ret = FALSE" branch that'd be preferable. Thanks, --Juan

1 0

Re: ole32: Fix invalid memory access in storage32
by Huw Davies 06 Dec '09

06 Dec '09

Nathan Gallaher wrote: > > In StorageImpl_construct(): > For pwcsName strings shorter than DIRENTRY_NAME_BUFFER_LEN-1, an invalid > read would be noted by valgrind as the memcpy wanders off the end of the > string. Do the needful to calculate the required string length. By the way, in storage32.h the filename member of struct StorageBaseImpl is declared as WCHAR filename[DIRENTRY_NAME_BUFFER_LEN]; shouldn't it be WCHAR filename[DIRENTRY_NAME_MAX_LEN]; ? Huw.

3 2

Re: listview: Fix LISTVIEW_CancelEditLabel to not save the changed text
by Nikolay Sivov 06 Dec '09

06 Dec '09

Jeff Latimer wrote: > --- > dlls/comctl32/listview.c | 2 +- > dlls/comctl32/tests/listview.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Hi, Jeff. This is obviously wrong. Test will fail on native systems after your patch. What is a problem with current code, any bugs reported?

2 2

Using trace in tests
by James McKenzie 06 Dec '09

06 Dec '09

All: I'm asking a question again, don't 'shoot' me, but I've noticed the use of the trace() function in tests and I would like to use this to troubleshoot what is incorrect in the EM_FORMATRANGE patch as it is not passing on MacOSX builds. The test appears to pass on WindowsXP sp2 as the failures did not appear in the winetest_latest for Wine-1.1.33. So, how do I enable the trace's I've added for testing so that I can fix the patch? Thank you. James McKenzie

2 5

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now
by Robert Reif 05 Dec '09

05 Dec '09

Maarten Lankhorst wrote: > -- > As I said, I'm confident nobody uses it, since wine never implemented it properly anyway > --- > I think you will find that you will have to add it back later because both interfaces are commonly used. The private interface is used for enumerating devices and is the only way of getting some information about the actual hardware. The buffer interface is commonly used to determine special hardware effects. Programs do check even if wine doesn't implement them because most windows sound cards don't either. In fact, now that you will be using openal you might have the opportunity to actually add real effects!

8 17

Re: shdocvw: Implement IWebBrowser2_get_Name
by Paul Vriens 05 Dec '09

05 Dec '09

On 12/04/2009 12:51 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > shdocvw: Implement IWebBrowser2_get_Name > > Best Regards > Alistair Leslie-Hughes > > Hi Alistair, This one introduces a test failure on non-English boxes: https://winetestbot.geldorp.nl/JobDetails.pl?Key=49 or http://test.winehq.org/data/6b8c9aee4fd57ac1f2f949992b3c5a6702f780a2/xp_wtb… (which is the same box btw). Could you have a look? -- Cheers, Paul.

1 1

Re: shell32: Fix a test failure on 64-bit systems.
by Vincent Povirk 05 Dec '09

05 Dec '09

Don't commit this. It seems the failure does not appear on 64-bit Windows systems, which means that the test is actually correct and the implementation needs to be fixed. On Fri, Dec 4, 2009 at 11:59 AM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > > -- Vincent Povirk

1 0

Re: Juan Lang : winhttp: Check the certificate in an https connection using the crypto api.
by Michael Stefaniuc 04 Dec '09

04 Dec '09

Juan, On 12/04/2009 04:11 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 82d07c405168df59db17d298bc3b8476f13540e9 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=82d07c405168df59db17d298b… > > Author: Juan Lang<juan.lang(a)gmail.com> > Date: Thu Dec 3 11:28:40 2009 -0800 > > winhttp: Check the certificate in an https connection using the crypto api. this breaks compilation on Fedora 12; F11 works fine though. gcc -c -I/home/michi/work/wine/dlls/winhttp -I. -I/home/michi/work/wine/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o net.o /home/michi/work/wine/dlls/winhttp/net.c /home/michi/work/wine/dlls/winhttp/net.c: In function ‘netconn_secure_verify’: /home/michi/work/wine/dlls/winhttp/net.c:342: error: ‘struct stack_st_X509’ has no member named ‘num’ /home/michi/work/wine/dlls/winhttp/net.c:346: error: ‘struct stack_st_X509’ has no member named ‘data’ /home/michi/work/wine/dlls/winhttp/net.c: In function ‘netconn_init’: /home/michi/work/wine/dlls/winhttp/net.c:450: warning: assignment discards qualifiers from pointer target type make: *** [net.o] Error 1 bye michael

2 2

Re: mshtml: Added PersistStreamInit_InitNew implementation
by Jacek Caban 04 Dec '09

04 Dec '09

Hi Piotr, Piotr Caban wrote: > --- > dlls/mshtml/mshtml_private.h | 1 + > dlls/mshtml/nsevents.c | 25 ++++++----- > dlls/mshtml/persist.c | 84 +++++++++++++++++++++++++++++------- > dlls/mshtml/tests/htmldoc.c | 95 > ++++++++++++++++++++++++++++++++++++++++-- > 4 files changed, 173 insertions(+), 32 deletions(-) hres = IOleClientSite_QueryInterface(doc->client, &IID_IOleCommandTarget, (void**)&olecmd); if(SUCCEEDED(hres)) { - VARIANT state, progress; - - V_VT(&progress) = VT_I4; - V_I4(&progress) = 0; - IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSPOS, OLECMDEXECOPT_DONTPROMPTUSER, - &progress, NULL); - - V_VT(&state) = VT_I4; - V_I4(&state) = 0; - IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETDOWNLOADSTATE, OLECMDEXECOPT_DONTPROMPTUSER, - &state, NULL); + if(doc->download_state) { + VARIANT state, progress; + + V_VT(&progress) = VT_I4; + V_I4(&progress) = 0; + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSPOS, + OLECMDEXECOPT_DONTPROMPTUSER, &progress, NULL); + + V_VT(&state) = VT_I4; + V_I4(&state) = 0; + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETDOWNLOADSTATE, + OLECMDEXECOPT_DONTPROMPTUSER, &state, NULL); + } + doc->download_state = 0; You should clear download_state if client doesn't implement IOleCommandTarget interface too. Thanks, Jacek

1 0

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO
by Henri Verbeet 04 Dec '09

04 Dec '09

2009/12/4 Stefan Dösinger <stefan(a)codeweavers.com>: > hr = create_primary_opengl_context(iface, (IWineD3DSwapChain *) swapchain); > + if(SUCCEEDED(hr)) > + { > + swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > + } This should probably be part of create_primary_opengl_context(). > +static inline void swapchain_blit(IWineD3DSwapChainImpl *This, struct wined3d_context *context) It's kind of obvious because of the "context" parameter, but for consistency please document the requirement for the caller to provide an active context.

1 0

Re: [2/6] WineD3D: A function for checking if a surface is offscreen
by Henri Verbeet 04 Dec '09

04 Dec '09

2009/12/4 Stefan Dösinger <stefan(a)codeweavers.com>: > GLenum buffer = surface_get_gl_buffer((IWineD3DSurface *) This, (IWineD3DSwapChain *)swapchain); > + > + IWineD3DSurface_GetContainer((IWineD3DSurface *) This, &IID_IWineD3DSwapChain, (void **)&swapchain); That doesn't look quite right. Also, you should check the return value for GetContainer().

1 0

Locale data update request
by Nikolay Sivov 04 Dec '09

04 Dec '09

Hi, guys. I've finally got some time today to complete genitive name support in GetDateFormat(). Now to make it useful for users I'd like to ask translators to update NLS files for languages that use this month form. I'm sure it's present in some Slavonic languages like Ukrainian and Belorussian, maybe some others (Asian?) too. Thanks.

1 0

Anti aliased fonts in wine - minimum font size
by Avery Pennarun 04 Dec '09

04 Dec '09

Hi all, I'm using Microsoft Office 2002 under wine. According to the instructions here: http://www.wine-reviews.net/wine-reviews/tips-n-tricks/how-to-enable-font-a… ...I've enabled font anti-aliasing, and it does work for fonts above a particular point size. However, it seems to turn itself off below a certain size. How can I configure the minimum font size at which to allow anti-aliasing? I've looked through the wine source and didn't see any obvious references to font size in the anti-aliasing-related code. Thanks, Avery

4 7

Re: ntdll: add partial support for HEAP_FREE_CHECKING_ENABLED heap overrun detection (take 3)
by Alexandre Julliard 04 Dec '09

04 Dec '09

Dan Kegel <dank(a)kegel.com> writes: > @@ -1261,6 +1297,8 @@ HANDLE WINAPI RtlCreateHeap( ULONG flags, PVOID addr, SIZE_T totalSize, SIZE_T c > totalSize = HEAP_DEF_SIZE; > flags |= HEAP_GROWABLE; > } > + if (NtCurrentTeb() && NtCurrentTeb()->Peb && (NtCurrentTeb()->Peb->NtGlobalFlag & FLG_HEAP_ENABLE_FREE_CHECK)) > + flags |= HEAP_FREE_CHECKING_ENABLED; This can't work, you can't use NtCurrentTeb before the TEB is properly initialized. -- Alexandre Julliard julliard(a)winehq.org

1 0

WineConf 2009 videos
by Julius Schwartzenberg 04 Dec '09

04 Dec '09

Hi, All the videos from WineConf 2009 are online now. The links can be found on the wiki page: http://wiki.winehq.org/WineConf2009 Because my camera isn't the greatest, Audacity was used to remove the noise from the audio track and using Kdenlive with melt the keynote video was filtered to make things somewhat visible again (the lights were off during that presentation). Thanks a lot to Roderick Colenbrander and grub_booter from #kdenlive, who helped me a lot with all of this :) Let me know if you have any comments on the videos! Thanks, Julius

1 0

d3d8 test failure, more details.
by David Anderson 04 Dec '09

04 Dec '09

Thanks to James Mckenzie and Austin English for earlier hints. I've installed more stuff (ubuntu packages) and spent a bit more time with d3d8. I assume most people get these tests to work, so I'm a bit distressed I cannot seem to get them to work properly, 100%. The large amount of test code that 'just works' is impressive. I'd be reassured I was not breaking things in any patch I submit if I could figure out why I'm not getting 100% (that is, what the heck might I be doing wrong?). Any hints/suggestions would be welcome. In dlls/d3d8/tests/visual.c one has the call that gets errors: 1357 if (caps.VertexShaderVersion >= D3DVS_VERSION(1, 1)) 1358 { 1359 test_rcp_rsq(device_ptr); 1360 } and test_rcp_rsq() does some *VertexShade calls not made elsewhere. The last few lines of 'make test' output in d3d8/tests are: fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface fixme:d3d_draw:drawPrimitive Using software emulation because manual fog coordinates are provided visual.c:598: Test failed: Color components differ: c1 = 80, c2 = 00, c3 = 80 visual.c:632: Test failed: Color components differ: c1 = 80, c2 = 00, c3 = 80 visual.c:634: Test failed: Color component value is 80 make: *** [visual.ok] Error 3 These failures are in test_rcp_rsq(), the function called at line 1359. Note that other calls to to getPixelColor() (a function in the test code, tests/visual.c) work fine. Only when a couple of special Shaders are invoked does getPixelColor() get something the test does not expect. Possibly IDirect3DDevice8_CreateVertexShader() is not setting things up right or somehow the 'DRI' code in package libgl1-mesa-dri is not being effective? I stuck a couple sleep(5) calls in the test source (to slow things down at the error points) and I can see the shader code has an effect visually (the test code generates small-ish windows with color blocks). Compiling d3d8 and its test code -g (that is, no -O2) gets exactly the same results. Ubuntu9.10. Intel(R) Core(TM)2 Duo CPU E8500 cpu. ATI 4350 PCI graphics. q2 616: dpkg-query -l '*mesa*' Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Description +++-==============-==============-============================================ un libgl1-mesa <none> (no description available) ii libgl1-mesa-de 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- G ii libgl1-mesa-dr 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- D ii libgl1-mesa-dr 7.6.0-1ubuntu4 Debugging symbols for the Mesa DRI modules un libgl1-mesa-dr <none> (no description available) ii libgl1-mesa-gl 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- G ii libgl1-mesa-gl 7.6.0-1ubuntu4 Debugging symbols for the Mesa GLX runtime un libgl1-mesa-sw <none> (no description available) ii libglu1-mesa 7.6.0-1ubuntu4 The OpenGL utility library (GLU) ii libglu1-mesa-d 7.6.0-1ubuntu4 The OpenGL utility library -- development fi ii mesa-common-de 7.6.0-1ubuntu4 Developer documentation for Mesa un mesa-glide2-de <none> (no description available) ii mesa-utils 7.6.0-1ubuntu4 Miscellaneous Mesa GL utilities un mesag-dev <none> (no description available) un mesag3 <none> (no description available) un mesag3+ggi-dev <none> (no description available) un xlibmesa-dev <none> (no description available) un xlibmesa-dri <none> (no description available) ii xlibmesa-gl-de 1:7.4+3ubuntu1 transitional package for Debian etch un xlibmesa-glu-d <none> (no description available) un xlibmesa3 <none> (no description available) un xlibosmesa-dev <none> (no description available) The 'libgl1-mesa-swx11*' packages are not installed, swx11 seems to be incompatible with some of the mesa stuff above (according to synaptic package manager). Any hints/suggestions would be welcome.

2 1

Please Review - Revised OS X Application Bundle patch
by Steven Edwards 04 Dec '09

04 Dec '09

Hi, If any of the OS X hackers have time, could you guys take a look at the following patch? I'd like to get it in to move on to more interesting stuff like the icon generation cleanup in winemenubuilder using windowscodecs.dll, OS X association support and perhaps even proper dock integration. I've been testing this with the PowerPoint 2003 viewer and it works for me. I'd be interested in hearing if anyone has trouble with other applications. You need to have Wine installed somewhere in your path or you will need to manually hardcode the path to your wine executable in the script generator just like with the menu builder on the linux side. I don't like the amount of #ifdef'ing I had to do but didn't really see a better way. I know before Alexandre will accept he most likely will want me to - Cleanup comments a bit. - Maybe shorten some of the variable and function names So I am looking for any other feedback you have. Documentation on bundles can be found at the following location http://developer.apple.com/mac/library/documentation/CoreFoundation/Concept… Changelog: Implement Application Bundle support for OS X using the CoreFoundation to generate Information Property Lists Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: shell32: Implement IPersistFile_fnSaveCompleted
by Nikolay Sivov 03 Dec '09

03 Dec '09

Vladimir Pankratov wrote: > Hello all. > > Implemented IPersistFile_fnSaveCompleted. > > changed files: > dlls/shell32/shelllink.c > > Thanks. --- + TRACE("(%p)->(%s)\n",This,debugstr_w(pszFileName)); + return S_OK; /* MSDN says: return value S_OK, returned in all cases */ --- You shouldn't care much of what MSDN says, please provide some tests.

1 0

Fixing the kernel32:actctx tests on Vista+
by Paul Vriens 03 Dec '09

03 Dec '09

Hi Jacek, You are the original author of these tests. Is there any reason the "test3.manifest" name is reused? The tests currently crash (intermittently on some) on Vista+ and with the attached patch things seem to get better. I'm just renaming one of the manifest files so there are no duplicates in these tests. -- Cheers, Paul.

4 7

Re: [PATCH 1/2] msvcrt: Add test to check if signal(SIGBREAK, ...) works (todo_wine).
by Charles Davis 03 Dec '09

03 Dec '09

You don't get added to AUTHORS until you've hacked on Wine enough. I learned that the hard way when I tried to put my name at the top of an already-existing file. Chip

4 3

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO
by Henri Verbeet 03 Dec '09

03 Dec '09

2009/12/2 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -1082,6 +1082,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateSwapChain(IWineD3DDevice *iface, > object->wineD3DDevice = This; > object->parent = parent; > object->ref = 1; > + object->render_to_fbo = FALSE; This is redundant, the field is already initialized to 0. > @@ -1880,6 +1881,9 @@ static HRESULT WINAPI IWineD3DDeviceImpl_Init3D(IWineD3DDevice *iface, > > switch(wined3d_settings.offscreen_rendering_mode) { > case ORM_FBO: > + This->offscreenBuffer = GL_COLOR_ATTACHMENT0; This change is probably correct, but note that if it matters you're probably doing something wrong. > @@ -959,22 +963,25 @@ static void read_from_framebuffer(IWineD3DSurfaceImpl *This, CONST RECT *rect, v ... > @@ -3102,7 +3109,7 @@ static inline void fb_copy_to_texture_direct(IWineD3DSurfaceImpl *This, IWineD3D ... > @@ -3241,12 +3248,12 @@ static inline void fb_copy_to_texture_hwstretch(IWineD3DSurfaceImpl *This, IWine Most of this should be part of patch 3. Note that since we have SFLAG_SWAPCHAIN we don't really need to pass the swapchain to surface_get_gl_buffer() anymore, we can just cast This->container directly to IWineD3DSwapChainImpl *. > +static inline void swapchain_blit(IWineD3DSwapChainImpl *This, struct wined3d_context *context) We have a number of functions now that do something very similar to what this function does. Perhaps it's time to spend some time on our blitter in order to unify those?

2 3

Re: [5/6] imagehlp: Recalculate PE checksum after file modification
by Alexandre Julliard 03 Dec '09

03 Dec '09

Owen Rudge <orudge(a)codeweavers.com> writes: > +static BOOL IMAGEHLP_RecalculateChecksum(HANDLE handle) > +{ > + IMAGE_DOS_HEADER dos_hdr; > + IMAGE_NT_HEADERS nt_hdr; > + HANDLE hMapping; > + LPVOID BaseAddress; > + DWORD FileLength, count, HeaderSum, CheckSum = 0; > + BOOL r; > + > + TRACE("handle %p\n", handle); > + > + /* read the DOS header */ > + count = SetFilePointer(handle, 0, NULL, FILE_BEGIN); > + > + if (count == INVALID_SET_FILE_POINTER) > + return FALSE; > + > + count = 0; > + > + r = ReadFile(handle, &dos_hdr, sizeof dos_hdr, &count, NULL); > + > + if (!r) > + return FALSE; > + > + if (count != sizeof dos_hdr) > + return FALSE; > + > + /* verify magic number of 'MZ' */ > + if (dos_hdr.e_magic != 0x5A4D) > + return FALSE; > + > + /* read the PE header */ > + count = SetFilePointer(handle, dos_hdr.e_lfanew, NULL, FILE_BEGIN); > + > + if (count == INVALID_SET_FILE_POINTER) > + return FALSE; > + > + count = 0; > + r = ReadFile(handle, &nt_hdr, sizeof nt_hdr, &count, NULL); > + > + if (!r) > + return FALSE; > + > + if (count != sizeof nt_hdr) > + return FALSE; > + > + /* verify NT signature */ > + if (nt_hdr.Signature != IMAGE_NT_SIGNATURE) > + return FALSE; Please write a helper for this, we don't need 3 implementations of the same thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/6] imagehlp: Verify magic numbers and pad certificates to 8 byte boundaries
by Alexandre Julliard 03 Dec '09

03 Dec '09

Owen Rudge <orudge(a)codeweavers.com> writes: > @@ -64,6 +64,10 @@ static BOOL IMAGEHLP_GetSecurityDirOffset( HANDLE handle, > if( count != sizeof dos_hdr ) > return FALSE; > > + /* verify magic number of 'MZ' */ > + if( dos_hdr.e_magic != 0x5A4D ) > + return FALSE; > + > /* read the PE header */ > count = SetFilePointer( handle, dos_hdr.e_lfanew, NULL, FILE_BEGIN ); > if( count == INVALID_SET_FILE_POINTER ) > @@ -75,6 +79,10 @@ static BOOL IMAGEHLP_GetSecurityDirOffset( HANDLE handle, > if( count != sizeof nt_hdr ) > return FALSE; > > + /* verify NT signature */ > + if( nt_hdr.Signature != IMAGE_NT_SIGNATURE ) > + return FALSE; > + > sd = &nt_hdr.OptionalHeader. > DataDirectory[IMAGE_FILE_SECURITY_DIRECTORY]; You also need to check the optional header magic to differentiate between 32-bit and 64-bit PE files. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: add partial support for HEAP_FREE_CHECKING_ENABLED heap overrun detection (take 2)
by Alexandre Julliard 03 Dec '09

03 Dec '09

Dan Kegel <dank(a)kegel.com> writes: > @@ -467,6 +475,156 @@ static void test_HeapQueryInformation(void) > ok(info == 0 || info == 1 || info == 2, "expected 0, 1 or 2, got %u\n", info); > } > > +static LPVOID (WINAPI * pRtlAllocateHeap)(HANDLE,ULONG,ULONG); > +static HANDLE (WINAPI * pRtlCreateHeap)(ULONG,PVOID,SIZE_T,SIZE_T,PVOID,PRTL_HEAP_DEFINITION); > +static HANDLE (WINAPI * pRtlDestroyHeap)(HANDLE); > +static NTSTATUS (WINAPI * pRtlFreeHeap)(HANDLE, ULONG, PVOID); > +static ULONG (WINAPI * pRtlGetNtGlobalFlags)(void); > +static LPVOID (WINAPI * pRtlReAllocateHeap)(HANDLE, ULONG, PVOID, ULONG); > +static SIZE_T (WINAPI * pRtlSizeHeap)( HANDLE, ULONG, LPCVOID); > +static BOOLEAN (WINAPI * pRtlValidateHeap)(HANDLE, ULONG, LPCVOID); > + > +static HMODULE hntdll; Now that it's in kernel32 you should of course use the kernel32 heap functions instead. > @@ -348,7 +349,10 @@ HANDLE thread_init(void) > peb->NtGlobalFlag = get_global_flag(); > > /* create the process heap */ > - if (!(peb->ProcessHeap = RtlCreateHeap( HEAP_GROWABLE, NULL, 0, 0, NULL, NULL ))) > + heapflags = HEAP_GROWABLE; > + if (peb->NtGlobalFlag & FLG_HEAP_ENABLE_FREE_CHECK) > + heapflags |= HEAP_FREE_CHECKING_ENABLED; > + if (!(peb->ProcessHeap = RtlCreateHeap( heapflags, NULL, 0, 0, NULL, NULL ))) Is there any reason for not doing this for all created heaps, instead of just the main one? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/6] WineD3D: Add a function for initializing surface sysmem
by Henri Verbeet 03 Dec '09

03 Dec '09

2009/12/2 Stefan Dösinger <stefan(a)codeweavers.com>: > - updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->frontBuffer, pPresentationParameters); > + hr = updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->frontBuffer, pPresentationParameters); > + if(FAILED(hr)) > + { > + IWineD3DSwapChain_Release((IWineD3DSwapChain *) swapchain); > + return hr; > + } > + > for(i = 0; i < swapchain->presentParms.BackBufferCount; i++) { > - updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->backBuffer[i], pPresentationParameters); > + hr = updateSurfaceDesc((IWineD3DSurfaceImpl *)swapchain->backBuffer[i], pPresentationParameters); > + if(FAILED(hr)) > + { > + IWineD3DSwapChain_Release((IWineD3DSwapChain *) swapchain); > + return hr; > + } > } IWineD3DDeviceImpl_Reset() suffers from similar issues in general, so maybe we just don't care, but if one of the updateSurfaceDesc() calls fails you're left with inconsistent surface sizes. > + This->Flags |= SFLAG_INSYSMEM; Why is this in surface_init_sysmem(), instead of a ModifyLocation() call after the call to surface_init_sysmem()?

2 2

Re: RFC: dsound: Add support for enumerating capture devices through openal, try 4
by Ken Thomases 03 Dec '09

03 Dec '09

On Dec 2, 2009, at 12:11 PM, Maarten Lankhorst wrote: > This patch doesn't apply, just a rfc email to see if this approach > is correct :) > +static void *openal_handle = RTLD_DEFAULT; > +#ifdef SONAME_LIBOPENAL > + char error[128]; > + openal_handle = wine_dlopen(SONAME_LIBOPENAL, RTLD_NOW, error, > sizeof(error)); > + if (!openal_handle) > + ERR("Couldn't load " SONAME_LIBOPENAL ": %s\n", error); > +#endif > +#define LOAD_FUNCPTR(f) \ > + if((p##f = wine_dlsym(openal_handle, #f, NULL, 0)) == NULL) { \ > + ERR("Couldn't lookup %s in libopenal\n", #f); \ > + failed = 1; \ > + } > + > + LOAD_FUNCPTR(alcCreateContext); By defaulting to RTLD_DEFAULT on the Mac (where SONAME_LIBOPENAL won't be defined), is there any risk that wine_dlsym will find the symbols from Wine's openal32.dll.so rather than the linked OpenAL framework? If it does, is that a problem? I had proposed using RTLD_NEXT for the default to avoid that possibility, although it seems that RTLD_NEXT isn't universally available. We might use RTLD_NEXT if it's defined and RTLD_DEFAULT otherwise. -Ken

2 1

Slackware packager?
by Jeremy White 03 Dec '09

03 Dec '09

So Adam Schreiber reports that he's no longer doing the Slackware packages. Is there an active Packager currently? If so, can you submit a patch to remove Adam's name and insert yours? If not, I guess I'll submit a patch to remove that column for Slackware... Cheers, Jeremy

2 1

Re: [3/6] WineD3D: A function for checking if a surface is offscreen
by Henri Verbeet 03 Dec '09

03 Dec '09

2009/12/2 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -5674,7 +5674,7 @@ static void color_fill_fbo(IWineD3DDevice *iface, IWineD3DSurface *surface, > IWineD3DSwapChain *swapchain; > > swapchain = get_swapchain(surface); > - if (swapchain) { > + if (!surface_is_offscreen(surface)) { That's ok, but the code that sets up the scissor rect further down also uses "swapchain" like this. Also, some of the changes to e.g. read_from_framebuffer() in patch 4 are really the same as what you're doing in this patch. Btw, note that the surface being offscreen is the common case, and onscreen surfaces are the exception. Maybe surface_is_onscreen() makes more sense, but I'll leave that up to you.

2 1

re: RFC: winediag script
by Dan Kegel 02 Dec '09

02 Dec '09

I love the idea. Could it be packaged with wine, or do you think it would be better off being a cousin of winetricks?

2 1

Re: [3/6] imagehlp: Implement ImageRemoveCertificate
by Jacek Caban 02 Dec '09

02 Dec '09

Hi Owen, Owen Rudge wrote: > --- > dlls/imagehlp/integrity.c | 73 > +++++++++++++++++++++++++++++++++++++-- > dlls/imagehlp/tests/integrity.c | 4 +- > 2 files changed, 72 insertions(+), 5 deletions(-) + cert_data = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, data_size); + + if (!cert_data) + return FALSE; + + ret = SetFilePointer(FileHandle, offset + cert_size_padded, NULL, FILE_BEGIN); + + if (ret == INVALID_SET_FILE_POINTER) + return FALSE; + + /* Read any subsequent certificates */ + r = ReadFile(FileHandle, cert_data, data_size, &count, NULL); + + if ((!r) || (count != data_size)) + return FALSE; + + SetFilePointer(FileHandle, offset, NULL, FILE_BEGIN); + + /* Write them one index back */ + r = WriteFile(FileHandle, cert_data, data_size, &count, NULL); + + if ((!r) || (count != data_size)) + return FALSE; + + HeapFree(GetProcessHeap(), 0, cert_data); You leak cert_data on errors here. Jacek

1 0

Tests question.
by David Anderson 02 Dec '09

02 Dec '09

I am trying to get the tests to run before I submit a patch to shdocvw/webbrowser.c. My first attempts to get the tests to run. This morning I did cd /home/davea/winebld/wine git fetch; git rebase origin # make sure you're up to date ./configure && make depend && make # rebuild the tree rm -rf ~/.wine # be sure to test in a clean WINEPREFIX sudo cp /home/downloads/wine_gecko-1.0.0-x86.cab /usr/local/share/wine/gecko sh ../apps/winetricks winxp mkdir /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko /bin/echo -n "Wine Gecko 1.0.0" >/home/davea/.wine/drive_c/windows/system32/gec ko/1.0.0/wine_gecko/VERSION cat /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko/VERSION make testclean make test and it failed on an init_d3d8 call. ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok err:wgl:opengl_error No OpenGL support compiled in. err:d3d_caps:WineD3D_CreateFakeGLContext Can't find a suitable iPixelFormat. err:d3d:InitAdapters Failed to get a gl context for default adapter err:d3d:WineDirect3DCreate Direct3D8 is not available without opengl visual.c:131: Tests skipped: could not create D3D8 visual.c:1312: Test failed: Could not initialize direct3d make[2]: *** [visual.ok] Error 1 make[2]: Leaving directory `/home/davea/winebld/wine/dlls/d3d8/tests' make[1]: *** [d3d8/tests/__test__] Error 2 make[1]: Leaving directory `/home/davea/winebld/wine/dlls' make: *** [dlls/__test__] Error 2 I note that d3d8/tests/visual.c does a win_skip() when the init_d3d3() fails. Why not a skip() ? Changing the win_skip here to: if (!d3d8_ptr) { skip("could not create D3D8\n"); return NULL; } enables the test to continue. Which is right? win_skip or skip? Why? This is on Ubuntu 9.10 (32bit), open-src drivers, ATI 4350 pci card. Thanks in advance for any clues. DavidAnderson

2 1

Re: Tests question.
by James Mckenzie 02 Dec '09

02 Dec '09

>I am trying to get the tests to run before I submit a patch to >shdocvw/webbrowser.c. My first attempts to get the tests to run. > >This morning I did >cd /home/davea/winebld/wine >git fetch; git rebase origin # make sure you're up to date >./configure && make depend && make # rebuild the tree >rm -rf ~/.wine # be sure to test in a clean WINEPREFIX > >sudo cp /home/downloads/wine_gecko-1.0.0-x86.cab /usr/local/share/wine/gecko >sh ../apps/winetricks winxp >mkdir /home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko >/bin/echo -n "Wine Gecko 1.0.0" > >/home/davea/.wine/drive_c/windows/system32/gec >ko/1.0.0/wine_gecko/VERSION >cat >/home/davea/.wine/drive_c/windows/system32/gecko/1.0.0/wine_gecko/VERSION >make testclean >make test > >and it failed on an init_d3d8 call. > >../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p >d3d8_test.exe.so visual.c && touch visual.ok >err:wgl:opengl_error No OpenGL support compiled in. This is what is causing the error. I get the same error on a series of Wine builds for MacOSX and I do have openGL support compiled in as far as I know. >err:d3d_caps:WineD3D_CreateFakeGLContext Can't find a suitable iPixelFormat. >err:d3d:InitAdapters Failed to get a gl context for default adapter >err:d3d:WineDirect3DCreate Direct3D8 is not available without opengl this is where Direct3D8 cannot initialize due to the above error. >visual.c:131: Tests skipped: could not create D3D8 >visual.c:1312: Test failed: Could not initialize direct3d And finally you get this error when running the test. >make[2]: *** [visual.ok] Error 1 >make[2]: Leaving directory `/home/davea/winebld/wine/dlls/d3d8/tests' >make[1]: *** [d3d8/tests/__test__] Error 2 >make[1]: Leaving directory `/home/davea/winebld/wine/dlls' >make: *** [dlls/__test__] Error 2 > >I note that d3d8/tests/visual.c does a win_skip() when the init_d3d3() >fails. Why not a skip() ? > Because it will cause your test to pass is not a good reason to put in a skip(). Fix the OpenGL error and this test should give proper results. James McKenzie

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel