- wine-devel - winehq.org

Down to an average of 1% failures on my Windows boxes
by Paul Vriens 16 Sep '09

16 Sep '09

Hi, Just wanting to let you know that I'm down to 1% average failures on my Windows boxes (W95/W98/NT4/W2K/XP/W2K3/Vista). Short list: Sep-2009 : 1% Jun-2009 : 2% May-2009 : 3% Mar-2009 : 4% Feb-2009 : 5% So I doubt we get to zero before WineConf ;) -- Cheers, Paul.

1 0

CertGetPublicKeyLength() test failures on Win7
by Greg Geldorp 15 Sep '09

15 Sep '09

Hi Juan, I see 3 test failures related to CertGetPublicKeyLength() on Win7, crypt32/tests/cert.c lines 3146/3160/3165. All 3 failures are the same, CertGetPublicKeyLength() returns 0 with last error 0x80090004 (NTE_BAD_LEN). After looking at it for a while, I'm inclined to change the condition to ok(ret == 56 || (ok == 0 && GetLastError() == NTE_BAD_LEN), ...). Do you agree that's the correct fix or do I need to dig deeper? Thanks, Ge.

2 4

Wine at Ohloh
by Saulius Krasuckas 15 Sep '09

15 Sep '09

FYI, http://www.ohloh.net/p/wine/analyses/latest I wonder how do they find 27k lines of C++ code in Wine tree...

4 4

Re: [PATCH 2/2] dpwsockx: Implementation of Open callback
by Vitaliy Margolen 15 Sep '09

15 Sep '09

Ismael Barros wrote: > --- > +static DWORD WINAPI udp_listener_thread( LPVOID lpParameter ) > +{ > + for ( ;; ) > + { ..... > + } > +} You do not have exit from the loop. > + /* Launch thread */ > + listener->handle = CreateThread( NULL, 0, udp_listener_thread, > + listener, 0, NULL ); I haven't found the place where you closing this handle. > + /* Launch thread */ > + listener->handle = … [View More]

3 7

re: [3/4] msi: GetDriveType and GetVolumeInformation require a path terminated by a slash.
by Dan Kegel 15 Sep '09

15 Sep '09

Don't changes like this need corresponding conformance tests? Likewise with "[4/4] msi: Don't append the cabinet file name in find_published_source."

2 1

How I create wine app launcher icons on the Mac
by Joerg-Cyril.Hoehle＠t-systems.com 15 Sep '09

15 Sep '09

Hi, On Linux, I have been using .desktop files that freedesktop defines to keep a directory full of icons. They all launch Wine applications. Often enough, these desktop files are initially create by Wine in ~/.local/share/applications/wine/..., along with the icon files in ~/.local/share/icons/. Here's how I now have app launcher icons on the Mac: sips -i ~/.local/share/icons/foo.png --out foo.png # sips -i converts and *additionaly* adds icon resource to file # Alas, sips does not … [View More]

2 3

Re: [1/2] comctl32: Implement highlighting (marquee) selection support in listview
by Nikolay Sivov 14 Sep '09

14 Sep '09

Owen Rudge wrote: > These patches add support for selecting multiple items in a > multi-selection listview using the mouse (by dragging and highlighting). > > --- > dlls/comctl32/listview.c | 172 > ++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 157 insertions(+), 15 deletions(-) Hi, Owen. Some comments. --- @@ -201,6 +201,7 @@ typedef struct tagITEM_INFO LPARAM lParam; INT iIndent; ITEM_ID *id; + UINT orig_state; /* state before … [View More]

2 2

Re: [PATCH 1/1] winecoreaudio: make supported format test more restrictive
by Ken Thomases 14 Sep '09

14 Sep '09

On Sep 14, 2009, at 6:21 AM, <Joerg-Cyril.Hoehle(a)t-systems.com> <Joerg-Cyril.Hoehle(a)t-systems.com > wrote: > supportedformat() has been in OSS' audio.c since 2004, so the > coreaudio driver was forked even before that time?!? Well, the CoreAudio driver was based on the ALSA driver. So, if ALSA was copied from the OSS driver before that change was made, then effectively, yes, the CoreAudio driver was forked before that time. -Ken

1 0

Re: ddraw: complete recognition of pixelformat 19: X8L8V8U8
by Stefan Dösinger 14 Sep '09

14 Sep '09

Am Monday 14 September 2009 17:28:13 schrieb Joerg-Cyril.Hoehle(a)t-systems.com: > Hi, > > the argument for including this code is based on symmetry: Every place in > the Wine source tree (incl. ddraw, d3d9, wined3d) that handles L6V5U5 also > handles X8L8V8U8 -- except for these two places. So I closed the gap. > > This fixes > err:ddraw:PixelFormat_WineD3DtoDD Can't translate this Pixelformat 19 > Please see bug #16559 for further discussion. > > Being based … [View More]

1 0

Re: ntdll: Do not accept device control requests with invalid and/or incompatible handles
by Alexandre Julliard 14 Sep '09

14 Sep '09

Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > +static void test_device_control(void) > +{ > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + > + /* Try using a bugus handle for I/O control */ > + HANDLE handle = (HANDLE)0xdeadbeef; > + status = pNtDeviceIoControlFile(handle, NULL, NULL, NULL, &io, IOCTL_SERIAL_SET_BAUD_RATE, NULL, 0, NULL, 0); > + ok(status == STATUS_INVALID_HANDLE, "Expected %08X, got %08X\n", STATUS_INVALID_HANDLE, … [View More]

3 5

Re: Is Wine printing on MacOSX?
by Joerg-Cyril.Hoehle＠t-systems.com 14 Sep '09

14 Sep '09

Hi, Stefan Dösinger wrote: >>All that happened [with notepad] is that the printer ejected a blank page. >Printing from notepad works fine for me on both Linux and OSX, fwiw Saving to file instead of printing, notepad generated a .ps file. Reading this into Apple's preview shows the text. Converting to pdf, then viewing also shows the text. Printing this prints a blank page! So either Apple does not like the PS generated by Wine, or only the printer, or that's a problem with fonts … [View More]

1 0

Re: [3/5] comctl32/dpa: Implement DPA_SaveStream() with tests
by Vitaliy Margolen 14 Sep '09

14 Sep '09

Nikolay Sivov wrote: > Changelog: > - Implement DPA_SaveStream() with tests > > + streamData.dwSize = curr_pos.QuadPart - initial_pos.QuadPart; > + streamData.dwData2 = 1; > + streamData.dwItems = streamInfo.iPos;// + 1; c++ comment. > +#if 0 > + /* crashes on XP */ > + hRes = pDPA_SaveStream(NULL, CB_Save, pStm, NULL); > + expect(E_INVALIDARG, hRes); > + > + hRes = pDPA_SaveStream(dpa, CB_Save, NULL, NULL); > + expect(… [View More]

2 1

Re: include: Add missing definitions in af_irda.h. (try 2)
by Alexandre Julliard 13 Sep '09

13 Sep '09

Thomas Trummer <th.trummer(a)gmail.com> writes: > @@ -97,4 +100,159 @@ typedef struct _SOCKADDR_IRDA > #define LmCharSetISO_8859_9 0x09 > #define LmCharSetUNICODE 0xff > > +#define SIO_LAZY_DISCOVERY _IOR('t', 127, ULONG) > + > +#define WINDOWS_AF_IRDA 26 > +#define WINDOWS_PF_IRDA WINDOWS_AF_IRDA > + > +#define WCE_AF_IRDA 22 > +#define WCE_PF_IRDA WCE_AF_IRDA > + > +#… [View More]

4 4

Sept 11 with tools and tests removed
by chris ahrendt 13 Sep '09

13 Sep '09

Here is the run for Friday Sept. 11 with the tools and the tests directory results removed. [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 Chris

6 11

Re: wined3d: Add Intel GMA 4500MHD
by Stefan Dösinger 13 Sep '09

13 Sep '09

Am Sunday 13 September 2009 08:15:19 schrieb Jaime Rave: > More information about Intel cards: > http://en.wikipedia.org/wiki/Intel_GMA#Table_of_GMA_graphics_cores_and_chip >sets + || strstr(gl_renderer, "Intel®")) I don't know if it is safe check for the ®. I think its not part of the standard ASCII character set, so there might be codepage issues. I don't think its necessary to check for it anyway, I think "Intel" is good enough. (In which case we might change the "… [View More]

1 0

Re: wined3d: Add Intel GMA 4500MHD
by Roderick Colenbrander 13 Sep '09

13 Sep '09

Just one minor thing make sure the right email address is configured in your git repository, so that the correct email address is set in the patch Roderick On Sun, Sep 13, 2009 at 8:15 AM, Jaime Rave <jaimerave(a)ubuntu-co.com> wrote: > More information about Intel > cards: http://en.wikipedia.org/wiki/Intel_GMA#Table_of_GMA_graphics_cores_and_chip… > > > >

1 0

Re: [ntdll] Add test for NtQueryDirectoryFile [try 2]
by James McKenzie 13 Sep '09

13 Sep '09

Dan Kegel wrote: > Here's the next broken-out test patch from the series that > implements support for hidden and system attributes. > This one just adds a test for NtQueryDirectoryFile(). > It passes for me on Wine and Vista Home Basic. > > Changes since first try: > 1) fixed issues Paul found (wasn't setting hidden attribute, wasn't > cleaning up on failure) > 2) actually test reported file attributes > Dan: It looks like your original patch was approved by … [View More]

2 1

Re: DDraw: Add a few missing WINAPIs
by Henri Verbeet 12 Sep '09

12 Sep '09

2009/9/12 Stefan Dösinger <stefan(a)codeweavers.com>: > I wonder how this worked in the past, and why the compiler didn't complain. It's pretty simple really, these functions don't need WINAPI because they're ddraw internal functions "cleverly" disguised as vtable methods. IIRC it's actually harmful to add WINAPI to these on OS X due to some obscure compiler bug.

2 1

re: fixing ReadDirectoryChangesW()
by Dan Kegel 12 Sep '09

12 Sep '09

Michael Pujos wrote: > I'm willing to resubmit this patch with updated tests > against current Wine, but before I procceed > I need to be sure it won't be rejected simply because it changes the protocol. Server changes are tricky to get in. You have to be patient and persistent. I think your best next move is to file a bug describing the problem (and give the URL for the app it affects for you, if possible), and submit just the tests first (with appropriate todo_wine lines where wine … [View More]

3 2

Re: DDraw: Add a few missing WINAPIs
by Stefan Dösinger 12 Sep '09

12 Sep '09

Am Saturday 12 September 2009 23:41:00 schrieb Stefan Dösinger: > Am Saturday 12 September 2009 23:25:56 schrieb Stefan Dösinger: > > Oops: forgot the patch: Er, never mind that patch - those functions aren't used directly in the vtable. There are the FPUSetup and FPUPreserve wrappers around them, so the default calling convention is ok.

1 0

RE: Help with a native Windows test program needed (CreateFileW).
by Markus Stockhausen 12 Sep '09

12 Sep '09

Sorry for the the wrong feedback. As I have limited possibilites creating executables on Windows I relied on Thomas executable for the tests. Maybe you can post a corrected version. It is not my intention to confuse someone. Im just trying to narrow down my initial analysis. The last write access to the malicous memory address before the application dump comes from CreateFileW. Best regards. -------- Weitergeleitete Nachricht -------- Von: wine-bugs(a)winehq.org An: mst(a)collogia.de … [View More]

2 5

Re: [ntdll] Add test for NtQueryDirectoryFile
by Paul Vriens 12 Sep '09

12 Sep '09

On 09/12/2009 02:18 AM, Dan Kegel wrote: > Here's the next broken-out test patch from the series that > implements support for hidden and system attributes. > This one just adds a test for NtQueryDirectoryFile(). > It passes for me on Wine and Vista Home Basic. > > [Paul, could you test it on your box to make sure it's ok there?] Hi Dan, No failures on my NT4+ boxes (32bit). One thing I noticed is that you don't cleanup in some of the failure cases which would leave that … [View More]

1 2

Help with a native Windows test program needed (CreateFileW).
by Markus Stockhausen 12 Sep '09

12 Sep '09

Hi, as I have no Windows machine and cannot test this. I'm in need for someone who can build a small exe that gives further hints to my observations in bug #9575. The following is needed: call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) Return the result of second call. I expect it to be a valid handle on Windows whereas Wine will return an invalid handle. Thanks in advance. Markus

2 3

RE: Help with a native Windows test program needed (CreateFileW)
by Greg Geldorp 11 Sep '09

11 Sep '09

Hi Markus, > From: Markus Stockhausen <markus.stockhausen(a)collogia.de> > > as I have no Windows machine and cannot test this: I'm in need for > someone who can build a small exe that gives further hints to my > observations in bug #9575. The following is needed: > > call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) > call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) > > Return the result of second call. I expect it to be a valid … [View More]

1 0

RFC: registry keys of serial ports
by Stefan Leichter 11 Sep '09

11 Sep '09

Hi, i like to know what modifikations the attached patch needs to go into git. More things need to be done in this area. I know of: - more registry keys [1] - remove the registry keys when a serial port disappears (USB) - the links in the dosdevice directory needs to be created Patches for the items above will be created, when the current patch went into git References: 1 http://www.winehq.org/pipermail/wine-patches/2009-April/071999.html - http://www.winehq.org/pipermail/wine-devel/2009-April/074476.html -- Stefan

3 5

Help with a native Windows test program needed (CreateFileW)
by Markus Stockhausen 11 Sep '09

11 Sep '09

Hi, as I have no Windows machine and cannot test this: I'm in need for someone who can build a small exe that gives further hints to my observations in bug #9575. The following is needed: call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) call CreateFileW( 'testfile.txt', ..., dwShareMode = 0, ...) Return the result of second call. I expect it to be a valid handle on Windows whereas Wine will return an invalid handle. Thanks in advance. Markus

2 1

fixing ReadDirectoryChangesW()
by Michael Pujos 11 Sep '09

11 Sep '09

A few months ago I wrote a patch that addressed the following issues with ReadDirectoryChangesW(): "1. move and rename of files and directories in a monitored directory are not notified 2. the current implementation allow to only get one change (FILE_NOTIFY_INFORMATION structure) at a time. No change is actually lost but the calling application using ReadDirectoryChangesW() expect to retrieve all changes since the last call. With the current implementation it would only get the first and … [View More]

1 0

Re: [PATCH 2/4] mshtml: Added http loading test.
by Paul Vriens 11 Sep '09

11 Sep '09

On 09/02/2009 12:27 PM, Jacek Caban wrote: > --- > dlls/mshtml/tests/htmldoc.c | 270 > +++++++++++++++++++++++++++++-------------- > 1 files changed, 182 insertions(+), 88 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Looks like this one introduced 2 test failures on some boxes, I couldn't find a common denominator though. The failures happen on IE6, IE7 and IE8 on different platforms (NT4 and higher)… [View More]

2 1

Re: [ntdll] Add tests for NtQueryInformationFile
by Paul Vriens 11 Sep '09

11 Sep '09

On 09/09/2009 02:41 PM, Dan Kegel wrote: > Alexandre said I should break up the big xattr patch, > so here are just the NtQueryInformationFile tests, > improved a bit. Once these are in I'll submit the > NtQueryDirectoryFile tests. > > Passes on both Wine and Vista. > > > ------------------------------------------------------------------------ > > Hi Dan, This patch introduces some issues on NT4 and higher. Attached patch fixes it but I'm not sure if you are … [View More]

2 4

Mirror Space
by Marty Cannon 11 Sep '09

11 Sep '09

Hey guys, Since the wine.budgetdedicated.com server was down all weekend, I thought I'd offer an additional mirror location. I currently mirror several major linux distributions, and would love to contribute to something as valuable to the community as the wine project is. My site currently runs around 3500GB per month, so a few hundred GB worth of transfer shouldn't make much difference. I've never set up an apt mirror, but with some instruction and googling, I bet I can do it. At the very … [View More]

6 12

Fixing the user32/dde tests on Win9x/WinMe
by Paul Vriens 11 Sep '09

11 Sep '09

Hi, DdeInitializeW is not implemented on the mentioned platforms but it's not just a matter of skipping some tests when that W-function is found to be not implemented. Any idea what the best way would be to fix these tests? -- Cheers, Paul.

1 0

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer
by Roderick Colenbrander 11 Sep '09

11 Sep '09

Recently Nikolay Sivov wrote some tests for this call. His tests didn't make it in yet but I think those should enter and then based on those results changes should be made. Roderick On Thu, Sep 10, 2009 at 10:56 PM, Markus Stockhausen <markus.stockhausen(a)collogia.de> wrote: > Hi, > > http://bugs.winehq.org/show_bug.cgi?id=18041 reveals a bug where > GdiAlphaBlend will crash in Teamviewer application when a NULL pointer > is handed over. The attached check fixes that … [View More]

4 7

Status of LoadLibrary and .so
by Joe Dluzen 11 Sep '09

11 Sep '09

Hi all, back a few years ago it didn't: http://www.winehq.org/pipermail/wine-devel/2003-July/018498.html Does anyone know of the status of LoadLibrary and a .so? Can it load directly or is there a workaround that does not involve multiple processes and some sort of IPC? thanks, Joe

3 2

Wineconf drumbeat - don't sleep on the streets!
by Jeremy White 11 Sep '09

11 Sep '09

Hi Folks, It's now close enough to November that you can't blow this email off <grin>. We've got all the info here: http://wiki.winehq.org/WineConf2009 Our challenge this year is that we're managing the booking, so we need a firm head count ahead of time. Again, if money is an issue, and you haven't already, please contact me privately. So if you're thinking of coming, email Hans. Now. Please. Failure to do so may result in your sleeping on the streets of Enschede *grin*. Cheers, Jeremy

2 2

Re: [2/4] WineD3D: Make context_attach_surface_fbo srgb aware
by Henri Verbeet 10 Sep '09

10 Sep '09

2009/9/10 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -402,7 +433,7 @@ static void context_apply_fbo_entry(struct wined3d_context *context, struct fbo_ > for (i = 0; i < GL_LIMITS(buffers); ++i) > { > IWineD3DSurface *render_target = device->render_targets[i]; > - context_attach_surface_fbo(context, GL_FRAMEBUFFER_EXT, i, render_target); > + context_attach_surface_fbo(context, GL_FRAMEBUFFER_EXT, i, … [View More]render_target, SRGB_ANY); > } > > /* Apply depth targets */ I don't think SRGB_ANY is correct here. context_apply_fbo_entry() very much cares about which texture is attached to the FBO. If rendering to sRGB textures was supported properly this would depend on the sRGB write state, but since it isn't this should aways be SRGB_RGB. > @@ -2041,7 +2072,7 @@ struct wined3d_context *ActivateContext(IWineD3DDeviceImpl *This, IWineD3DSurfac > FIXME("Activating for CTXUSAGE_BLIT for an offscreen target with ORM_FBO. This should be avoided.\n"); > ENTER_GL(); > context_bind_fbo(context, GL_FRAMEBUFFER_EXT, &context->dst_fbo); > - context_attach_surface_fbo(context, GL_FRAMEBUFFER_EXT, 0, target); > + context_attach_surface_fbo(context, GL_FRAMEBUFFER_EXT, 0, target, SRGB_ANY); > context_attach_depth_stencil_fbo(context, GL_FRAMEBUFFER_EXT, NULL, FALSE); > LEAVE_GL(); > } else { Similar to above. > @@ -6045,7 +6045,7 @@ static void color_fill_fbo(IWineD3DDevice *iface, IWineD3DSurface *surface, > context = ActivateContext(This, NULL, CTXUSAGE_RESOURCELOAD); > ENTER_GL(); > context_bind_fbo(context, GL_FRAMEBUFFER_EXT, &context->dst_fbo); > - context_attach_surface_fbo(context, GL_FRAMEBUFFER_EXT, 0, surface); > + context_attach_surface_fbo(context, GL_FRAMEBUFFER_EXT, 0, surface, SRGB_ANY); > context_attach_depth_stencil_fbo(context, GL_FRAMEBUFFER_EXT, NULL, FALSE); > } Afaik color fill colors are specified in RGB space. Unless you have a test that shows otherwise, this should be SRGB_RGB. > @@ -6463,7 +6463,7 @@ void stretch_rect_fbo(IWineD3DDevice *iface, IWineD3DSurface *src_surface, WINED > TRACE("Source surface %p is offscreen\n", src_surface); > ENTER_GL(); > context_bind_fbo(context, GL_READ_FRAMEBUFFER_EXT, &context->src_fbo); > - context_attach_surface_fbo(context, GL_READ_FRAMEBUFFER_EXT, 0, src_surface); > + context_attach_surface_fbo(context, GL_READ_FRAMEBUFFER_EXT, 0, src_surface, SRGB_ANY); > glReadBuffer(GL_COLOR_ATTACHMENT0_EXT); > checkGLcall("glReadBuffer()"); > context_attach_depth_stencil_fbo(context, GL_READ_FRAMEBUFFER_EXT, NULL, FALSE); > @@ -6503,7 +6503,7 @@ void stretch_rect_fbo(IWineD3DDevice *iface, IWineD3DSurface *src_surface, WINED > > ENTER_GL(); > context_bind_fbo(context, GL_DRAW_FRAMEBUFFER_EXT, &context->dst_fbo); > - context_attach_surface_fbo(context, GL_DRAW_FRAMEBUFFER_EXT, 0, dst_surface); > + context_attach_surface_fbo(context, GL_DRAW_FRAMEBUFFER_EXT, 0, dst_surface, SRGB_ANY); > glDrawBuffer(GL_COLOR_ATTACHMENT0_EXT); > checkGLcall("glDrawBuffer()"); > context_attach_depth_stencil_fbo(context, GL_DRAW_FRAMEBUFFER_EXT, NULL, FALSE); This doesn't work either. While it probably doesn't matter if the blit is done in RGB or sRGB space, it still needs to be the same color space for both surfaces (and one of those can be onscreen). On a higher level, I'm not really happy with how sRGB textures currently fit in and how that's starting to spread to everything that has to deal with surfaces. [View Less]

2 1

Re: [3/4] WineD3D: Perform the srgb copy with fbo_blit if possible
by Henri Verbeet 10 Sep '09

10 Sep '09

2009/9/10 Stefan Dösinger <stefan(a)codeweavers.com>: > + if (context->current_fbo) { > + context_bind_fbo(context, GL_FRAMEBUFFER_EXT, &context->current_fbo->id); > + } else { > + context_bind_fbo(context, GL_FRAMEBUFFER_EXT, NULL); > + } This shouldn't be needed. > + /* Need FBOs obviously */ > + if(wined3d_settings.offscreen_rendering_mode != ORM_FBO) return FALSE; > + /* Need framebuffer blit */ > + if(!… [View More]

1 0

Re: bitblt.c - GdiAlphaBlend : Check for NULL Pointer
by Paul Vriens 10 Sep '09

10 Sep '09

On 09/10/2009 10:56 PM, Markus Stockhausen wrote: > Hi, > > http://bugs.winehq.org/show_bug.cgi?id=18041 reveals a bug where > GdiAlphaBlend will crash in Teamviewer application when a NULL pointer > is handed over. The attached check fixes that behaviour. > > Tanks in advance. > > Markus > > > > ------------------------------------------------------------------------ > > No comments on the validity of the patch but you should add a test for this to … [View More]

1 0

Re: winehq: Fix some HTML markup
by Jeremy Newman 10 Sep '09

10 Sep '09

The reason I left the XHTML markup in was eventually the goal was to convert the entire website to XHTML. The only issue with leaving them in while still in HTML4/Transitional is that the pages do not pass W3C validation. I am still willing to live with non-valid working HTML to save some work down the road. -N André Hentschel wrote: > --- > templates/de/about.template | 2 +- > templates/de/contributing.template | 8 +++--- > templates/de/download.template … [View More]

3 3

Asynchronus serial port
by Fenixk19 10 Sep '09

10 Sep '09

Hello! I've already post the bug(http://bugs.winehq.org/show_bug.cgi?id=19713) on this subject, but i need more help. So I've decided to write here. There is a problem in wine. When I use asynchronous serial port read, data never comes. Event, caused by select comes. But operation status stays pending, and i can't do anything to this serial port anymore. In windows it never get pending, and port can be accessed just after data arrival. Seems to be wineserver problem, but i don't know, where to … [View More]

4 4

Re: [PATCH 12/12] openal32: fixed ctx null ptr debug (Coverity)
by Chris Robinson 10 Sep '09

10 Sep '09

I have a different patch that will fix this, that also fixes a problem with error states.

1 0

Re: server: Use kernel support for thread affinity when available
by Chris Robinson 10 Sep '09

10 Sep '09

On Thursday 10 September 2009 9:43:02 am Juan Lang wrote: > +/* Define to 1 if you have the `sched_getaffinity' function. */ > +#undef HAVE_SCHED_GETAFFINITY > + ... > +#ifdef HAVE_SCHED_GET_AFFINITY > +#define __USE_GNU > +#include <sched.h> > +#endif Looks like a typo there.

1 0

Re: winex11: Make X11DRV_PALETTE_ComputeColorShifts() static.
by Roderick Colenbrander 10 Sep '09

10 Sep '09

In a next patch ComputeChannelShift will be called from outside palette.c and for this reason I made it non-static. Roderick On Thu, Sep 10, 2009 at 5:58 PM, Francois Gouget <fgouget(a)free.fr> wrote: > --- > dlls/winex11.drv/palette.c | 115 ++++++++++++++++++++++---------------------- > dlls/winex11.drv/x11drv.h | 1 - > 2 files changed, 57 insertions(+), 59 deletions(-) > > diff --git a/dlls/winex11.drv/palette.c b/dlls/… [View More]winex11.drv/palette.c > index 81bb73b..cdbfb21 100644 > --- a/dlls/winex11.drv/palette.c > +++ b/dlls/winex11.drv/palette.c > @@ -131,6 +131,63 @@ static void palette_set_mapping( HPALETTE hpal, int *mapping ) > wine_tsx11_unlock(); > } > > +/*********************************************************************** > + * X11DRV_PALETTE_ComputeChannelShift > + * > + * Calculate conversion parameters for a given color mask > + */ > +static void X11DRV_PALETTE_ComputeChannelShift(unsigned long maskbits, ChannelShift *physical, ChannelShift *to_logical) > +{ > + int i; > + > + if (maskbits==0) > + { > + physical->shift=0; > + physical->scale=0; > + physical->max=0; > + to_logical->shift=0; > + to_logical->scale=0; > + to_logical->max=0; > + return; > + } > + > + for(i=0;!(maskbits&1);i++) > + maskbits >>= 1; > + > + physical->shift = i; > + physical->max = maskbits; > + > + for(i=0;maskbits!=0;i++) > + maskbits >>= 1; > + physical->scale = i; > + > + if (physical->scale>8) > + { > + /* On FreeBSD, VNC's default 32bpp mode is bgrabb (ffc00000,3ff800,7ff)! > + * So we adjust the shifts to also normalize the color fields to > + * the Win32 standard of 8 bits per color. > + */ > + to_logical->shift=physical->shift+(physical->scale-8); > + to_logical->scale=8; > + to_logical->max=0xff; > + } else { > + to_logical->shift=physical->shift; > + to_logical->scale=physical->scale; > + to_logical->max=physical->max; > + } > +} > + > +/*********************************************************************** > + * X11DRV_PALETTE_ComputeColorShifts > + * > + * Calculate conversion parameters for a given color > + */ > +static void X11DRV_PALETTE_ComputeColorShifts(ColorShifts *shifts, unsigned long redMask, unsigned long greenMask, unsigned long blueMask) > +{ > + X11DRV_PALETTE_ComputeChannelShift(redMask, &shifts->physicalRed, &shifts->logicalRed); > + X11DRV_PALETTE_ComputeChannelShift(greenMask, &shifts->physicalGreen, &shifts->logicalGreen); > + X11DRV_PALETTE_ComputeChannelShift(blueMask, &shifts->physicalBlue, &shifts->logicalBlue); > +} > > /*********************************************************************** > * COLOR_Init > @@ -278,64 +335,6 @@ void X11DRV_PALETTE_Cleanup(void) > } > > /*********************************************************************** > - * X11DRV_PALETTE_ComputeChannelShift > - * > - * Calculate conversion parameters for a given color mask > - */ > -static void X11DRV_PALETTE_ComputeChannelShift(unsigned long maskbits, ChannelShift *physical, ChannelShift *to_logical) > -{ > - int i; > - > - if (maskbits==0) > - { > - physical->shift=0; > - physical->scale=0; > - physical->max=0; > - to_logical->shift=0; > - to_logical->scale=0; > - to_logical->max=0; > - return; > - } > - > - for(i=0;!(maskbits&1);i++) > - maskbits >>= 1; > - > - physical->shift = i; > - physical->max = maskbits; > - > - for(i=0;maskbits!=0;i++) > - maskbits >>= 1; > - physical->scale = i; > - > - if (physical->scale>8) > - { > - /* On FreeBSD, VNC's default 32bpp mode is bgrabb (ffc00000,3ff800,7ff)! > - * So we adjust the shifts to also normalize the color fields to > - * the Win32 standard of 8 bits per color. > - */ > - to_logical->shift=physical->shift+(physical->scale-8); > - to_logical->scale=8; > - to_logical->max=0xff; > - } else { > - to_logical->shift=physical->shift; > - to_logical->scale=physical->scale; > - to_logical->max=physical->max; > - } > -} > - > -/*********************************************************************** > - * X11DRV_PALETTE_ComputeColorShifts > - * > - * Calculate conversion parameters for a given color > - */ > -void X11DRV_PALETTE_ComputeColorShifts(ColorShifts *shifts, unsigned long redMask, unsigned long greenMask, unsigned long blueMask) > -{ > - X11DRV_PALETTE_ComputeChannelShift(redMask, &shifts->physicalRed, &shifts->logicalRed); > - X11DRV_PALETTE_ComputeChannelShift(greenMask, &shifts->physicalGreen, &shifts->logicalGreen); > - X11DRV_PALETTE_ComputeChannelShift(blueMask, &shifts->physicalBlue, &shifts->logicalBlue); > -} > - > -/*********************************************************************** > * X11DRV_PALETTE_BuildPrivateMap > * > * Allocate colorcells and initialize mapping tables. > diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h > index 62b0d63..844af31 100644 > --- a/dlls/winex11.drv/x11drv.h > +++ b/dlls/winex11.drv/x11drv.h > @@ -494,7 +494,6 @@ extern BOOL X11DRV_IsSolidColor(COLORREF color); > extern COLORREF X11DRV_PALETTE_ToLogical(X11DRV_PDEVICE *physDev, int pixel); > extern int X11DRV_PALETTE_ToPhysical(X11DRV_PDEVICE *physDev, COLORREF color); > extern int X11DRV_PALETTE_LookupPixel(COLORREF color); > -extern void X11DRV_PALETTE_ComputeColorShifts(ColorShifts *shifts, unsigned long redMask, unsigned long greenMask, unsigned long blueMask); > > extern unsigned int depth_to_bpp( unsigned int depth ); > > -- > 1.6.3.3 > > > [View Less]

1 0

Re: mshtml: Add support for Reference BSTR when setting styles.
by Paul Vriens 10 Sep '09

10 Sep '09

On 09/10/2009 12:00 PM, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mshtml: Add support for Reference BSTR when setting styles. > > Best Regards > Alistair Leslie-Hughes > > > ------------------------------------------------------------------------ > > Hi Alistair, Now VT_BSTR is used in two case-statements. -- Cheers, Paul.

1 1

Re: msi: Ignore CoInitialize failure in ACTION_CreateShortcuts.
by Hans Leidekker 10 Sep '09

10 Sep '09

> Fixes http://bugs.winehq.org/show_bug.cgi?id=19636 Or it doesn't: err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded err:shell:ShellLink_QueryInterface -- Interface: E_NOINTERFACE Because IShellLink is apartment-threaded only? -Hans

1 0

Performance tag for Bugzilla?
by Scott Ritchie 10 Sep '09

10 Sep '09

We have a wiki page functioning as sort of a wannabe performance tag here: http://wiki.winehq.org/Performance-related_bugs Is this a reasonable tag to have? Thanks, Scott Ritchie

1 0

http://bugs.winehq.org/show_bug.cgi?id=18337
by Frank Gruman 10 Sep '09

10 Sep '09

I have been using wine for various tools and utilities at work and home for some time now. Recently I tried to use wine to run the VMware Infrastructure Client and ran into bug 18337 (http://bugs.winehq.org/show_bug.cgi?id=18337). I am pasting my comments on that bug here to avoid repetition (http://bugs.winehq.org/show_bug.cgi?id=18337#c4). <paste> So - I looked through the code (current git @1.1.29) and compared to the 1.0 release (because of comment 1) and did not see that … [View More]

2 3

ddraw: Added support for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM to PixelFormat_WineD3DtoDD
by Joerg-Cyril.Hoehle＠t-systems.com 10 Sep '09

10 Sep '09

Stephan, All the patches proposed to bug #16559 forget one thing: it cannot be right to patch only PixelFormat_WineD3DtoDD without patching its converse function in the same file, PixelFormat_DD2WineD3D. There's no gain in silencing a fixme by introducing internal inconsistency in the source code. I had my own patch which changed both but for X8L8V8U8 only, but never published it because I observed no visual difference in the one app I tested, and had no time for 3 other ones I own, nor the … [View More]

2 1

Re: CPPCheck for Sept 8th
by chris ahrendt 09 Sep '09

09 Sep '09

Nicolas Le Cam wrote: > 2009/9/9 Alexandre Julliard <julliard(a)winehq.org>: >> chris ahrendt <celticht32(a)yahoo.com> writes: >> >>> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd >> This is the only one that looks a real bug, all the rest are false >> positives. Please filter them out from future reports. >> >> -- >> Alexandre Julliard >> julliard(a)winehq.org >> >> >&… [View More]

2 1

CPPCheck for Sept 8th
by chris ahrendt 09 Sep '09

09 Sep '09

[/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd [/home/cahrendt/wine-git/dlls/ntdll/… [View More]

3 2

Re: CPPCheck for Sept 8th
by chris ahrendt 09 Sep '09

09 Sep '09

Alexandre Julliard wrote: > chris ahrendt <celticht32(a)yahoo.com> writes: > >> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd > > This is the only one that looks a real bug, all the rest are false > positives. Please filter them out from future reports. > Is there any others? So ignore the tests findings and the tools findings? Are These the ones that may be a bug then : [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]:… [View More]

1 0

Re: CPPCheck for Sept 8th
by chris ahrendt 09 Sep '09

09 Sep '09

Alexandre Julliard wrote: > chris ahrendt <celticht32(a)yahoo.com> writes: > >> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd > > This is the only one that looks a real bug, all the rest are false > positives. Please filter them out from future reports. > Alexandre, I will filter them as best I can going forward... Chris

1 0

Re: CPP Run for Sept 8
by Stefan Dösinger 09 Sep '09

09 Sep '09

hi, I think its better to send these reports to wine-devel instead of wine-patches

1 0

Re: gdi32/tests: Some GdiAlphaBlend tests
by Roderick Colenbrander 09 Sep '09

09 Sep '09

Regarding the zero source DC, what happens visually? On Wed, Sep 9, 2009 at 1:30 PM, Nikolay Sivov<bunglehead(a)gmail.com> wrote: > Bug http://bugs.winehq.org/show_bug.cgi?id=18041 shows this commented crash. > I'm not sure how to fix it, but I think this call can't do anything > without source context. > > Another question is where to place such check - in gdi32 or winex11...any > advices are welcome. > > Changelog: > - Some GdiAlphaBlend tests &… [View More]

2 1

Re: mfc42: Stub implementation with the message where to get it from
by Alexandre Julliard 09 Sep '09

09 Sep '09

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > This is more of the testing waters type of patch. If this approach is > fine then we can do the same for all other dlls that are shipped with > Windows but not really a part of an O/S. I don't think you can put up a message box on attach, that could potentially become very annoying since it will trigger also for version checks etc. That sort of thing should be done at the loader level. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: Handle OEM_CHARSET
by Dmitry Timoshkov 09 Sep '09

09 Sep '09

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > --- a/dlls/gdi32/freetype.c 2009-08-08 13:27:23.000000000 +0500 > +++ b/dlls/gdi32/freetype.c 2009-09-07 19:58:58.000000000 +0500 > @@ -3576,6 +3576,7 @@ > if(!TranslateCharsetInfo((DWORD*)(INT_PTR)lf.lfCharSet, &csi, TCI_SRCCHARSET)) { > switch(lf.lfCharSet) { > case DEFAULT_CHARSET: > + case OEM_CHARSET: > csi.fs.fsCsb[0] = 0; > break; > default: How is this different from the … [View More]

2 1

Re: [PATCH 02/10] d3d10: Implement annotation parsing.
by Henri Verbeet 09 Sep '09

09 Sep '09

2009/9/9 Rico Schüller <kgbricola(a)web.de>: > -static void parse_fx10_annotation(const char **ptr) > +static HRESULT parse_fx10_annotation(struct d3d10_effect_variable *a, const char **ptr, const char *data) > { > - skip_dword_unknown(ptr, 3); > + DWORD offset; > + > + read_dword(ptr, &offset); > + TRACE("Annotation name at offset %#x.\n", offset); > + > + a->name = copy_name(data + offset); > + if (!a->name) > + { > +… [View More]

2 1

Re: msxml3: Add IDispatchEx support to IXMLDOMElement (resend 2)
by Alexandre Julliard 09 Sep '09

09 Sep '09

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Feedback if something is wrong would be great. domdoc.c:601: warning: ISO C90 forbids mixed declarations and code -- Alexandre Julliard julliard(a)winehq.org

1 0

Google Summer of Code mentor summit Oct 24th-25th
by Kai Blin 09 Sep '09

09 Sep '09

Hi folks, Wine gets to send two delegates to the Google Summer of Code mentor summit in Mountain View, CA, this October. Is anybody who mentored interested in going? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: CPPCheck Sept 8 GIT
by Marcus Meissner 09 Sep '09

09 Sep '09

On Tue, Sep 08, 2009 at 07:21:03PM -0700, chris ahrendt wrote: > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) > Deallocating a deallocated pointer: stream2 > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource > leak: stream3 > [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource > leak: stream4 > [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) > Memory leak: mem > [/home/cahrendt/… [View More]

1 0

Re: [ntdll, cmd] Implement file attributes with xattr on mac and linux (fixes bug 15679)
by Kai Blin 08 Sep '09

08 Sep '09

On Tuesday 08 September 2009 16:11:06 Dan Kegel wrote: > This patch uses filesystem extended attributes in > a way compatible with Samba 3 to store the win32 attribute bits. > It builds and runs on mac and linux, passes tests on linux and vista, > and should be easy-ish to port to solaris (though who knows > what xattr solaris' native cifs server uses, hopefully it's the > same as what samba 3 does). As JRA already replied with more Samba3-specific things, just a word about … [View More]

1 0

Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER
by Nicholas LaRoche 08 Sep '09

08 Sep '09

I ran into a bug last week regarding the lack of SIO_GET_EXTENSION_FUNCTION_POINTER support in WSAIoctl. Are there any outstanding issues preventing it's implementation? Perhaps if anyone has worked in this area, are there any things I should look out for when trying to implement it? At first glance it looks like returning an arbitrary pointer may prove tricky since wine likes to relocate DLLs to unpredictable addresses at runtime. (i.e. kernel32.dll is not predictably mapped to a single … [View More]

2 5

Re: [3/3]msctf/tests: test ITfThreadMgr::AssociateFocus
by Paul Vriens 08 Sep '09

08 Sep '09

On 09/01/2009 02:08 PM, Aric Stewart wrote: > --- > dlls/msctf/tests/inputprocessor.c | 141 > ++++++++++++++++++++++++++++++++++++- > 1 files changed, 139 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Aric, This one introduced some test failures on Vista and higher. Could you have a look? -- Cheers, Paul.

2 1

Re: [wined3d][1/3] Allow infinity count of backbuffers in IWineD3DDeviceImpl_CreateSwapChain()
by Henri Verbeet 08 Sep '09

08 Sep '09

- Please don't use TCHAR etc. in Wine. - You still didn't prove you need to copy the data for each backbuffer. - You still have whitespace errors.

1 0

[RFC] Implement file attributes with xattr on mac and linux (fixes bug 15679)
by Dan Kegel 08 Sep '09

08 Sep '09

Builds and runs on mac and linux, passes tests on linux and vista. Fixes http://bugs.winehq.org/show_bug.cgi?id=15679 It's worth discussing a bit before posting to wine-patches. This patch uses filesystem extended attributes to store the win32 attribute bits. These are available fairly widely finally - I think current Linux, Mac, and Solaris all support some form of extended attributes. Because the extended attribute API varies somewhat wildly between operating systems, I went whole-hog and … [View More]

2 1

Re: wined3d: Fix vendor detection when using an Intel X4500HD
by Austin English 08 Sep '09

08 Sep '09

On Mon, Sep 7, 2009 at 11:52 PM, Jaime Rave<jaimerave(a)gmail.com> wrote: > This patch fix the fixme: > > fixme:d3d_caps:wined3d_guess_vendor Received unrecognized GL_VENDOR > "Tungsten Graphics, Inc". Returning VENDOR_WINE. > > > > Forgot the patch. -- -Austin

1 0

Re: msvcrt: dont overwrite the standard streams (with test, try 5)
by Eric Pouech 07 Sep '09

07 Sep '09

André Hentschel a écrit : > Some Apps e.g. mingw-apps use lpReserved2 to pass some data to the child-process, this data starts with 4 Byte of Zeros(unsinged 0) to tell msvcrt not to read that as an inherit-block. > Hi André a couple of comments to your patch > See also Bug 18479 > --- > dlls/msvcrt/file.c | 2 +- > dlls/msvcrt/tests/Makefile.in | 2 +- > dlls/msvcrt/tests/file.c | 50 +++++++++++++++++++++++++++++++++++++++++ > 3 files changed,… [View More]

2 3

Re: [5/5] WineD3D: Use GL_ATI_meminfo if available
by Henri Verbeet 07 Sep '09

07 Sep '09

2009/9/5 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* All GL_ATI_meminfo enums return 4 ints, even the (undocumented) > + * GL_TOTAL_PHYSICAL_MEMORY_ATI one, which returns {mem, 0, 0, 0} */ > + GLint mem[4]; > + /* Returns the vidmem in KB */ > + glGetIntegerv(GL_TOTAL_PHYSICAL_MEMORY_ATI, mem); > + checkGLcall("glGetIntegerv(GL_TOTAL_PHYSICAL_MEMORY_ATI, mem)"); > + > + /* The first driver version that … [View More]

3 4

Finding IDB_VIEW_SMALL_COLOR
by Joel Holdsworth 07 Sep '09

07 Sep '09

Hi All, Does anyone know what DLL the image 32-bit version the standard image list IDB_VIEW_SMALL_COLOR is stored in in Windows? You can see some of it in this screenshot: http://www.airwebreathe.org.uk/IDB_VIEW_SMALL_COLOR.png. I might expect it to be in comctl32.dll with the other common image lists... but it's not - only the old 4-bit version of the image. Does anyone know where the 32-bit one is? Thanks Joel

3 3

Re: ddraw: Added support for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM to PixelFormat_WineD3DtoDD
by James McKenzie 07 Sep '09

07 Sep '09

Stephan Rose wrote: > Sets up DDPixelFormat for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM formats. > > Fixes errors in the game http://www.alawar.com/game/tikibar/ that keep it from running due missing pixel format conversions of the above bump map formats. Stephan: You have trailing spaces in the break; line. Please remove them. James McKenzie + DDPixelFormat->u5.dwLuminanceAlphaBitMask = 0x000000FF; + break; + case WINED3DFMT_R16G16_SNORM:

1 0

Re: [4/5] WineD3D: Add GL_ATI_meminfo to the extension table
by Henri Verbeet 06 Sep '09

06 Sep '09

2009/9/5 Stefan Dösinger <stefan(a)codeweavers.com>: > So far ATI hasn't updated the extension spec, but the code works nevertheless, > and I don't have any problem with using this functionality if available. > The implication is that when someone implements ATI_meminfo as documented in the actual spec it won't work properly with Wine. I don't think we really want to go there. I'm also not sure it's even possible to introduce additional tokens into already published extensions, … [View More]

1 0

Re: ddraw: Added support for WINED3DFMT_X8L8V8U8, WINED3DFMT_R8G8B8A8_SNORM and WINED3DFMT_R16G16_SNORM to PixelFormat_WineD3DtoDD
by Henri Verbeet 06 Sep '09

06 Sep '09

2009/9/3 Stephan Rose <kermos(a)somrek.net>: > + case WINED3DFMT_R8G8B8A8_SNORM: > + DDPixelFormat->dwFlags = DDPF_BUMPDUDV; > + DDPixelFormat->dwFourCC = 0; > + DDPixelFormat->u1.dwBumpBitCount = 32; > + DDPixelFormat->u2.dwBumpDuBitMask = 0xFF000000; > + DDPixelFormat->u3.dwBumpDvBitMask = 0x00FF0000; > + DDPixelFormat->u4.dwBumpLuminanceBitMask = … [View More]

1 0

Re: [PATCH 0/3] Make GetAsyncKeyState really Async (now it checks current window only)
by Tom Wickline 06 Sep '09

06 Sep '09

You forgot the patch :) 2009/9/6 Rafał Miłecki <zajec5(a)gmail.com> > Hi, > > This patchset fixes bug #5623 [1]. I've tested this with EasyUO app > and other random apps run in the same wineserver. > > I've run tests in user32 to check for regressions, no changes. I've > checked compilation & user32's test after applying each patch. > > Hope everything is alright with this patchset. > > [1] http://bugs.winehq.org/show_bug.cgi?id=5623 > > -- &… [View More]

2 1

Re: Game Engine
by Ben Klein 06 Sep '09

06 Sep '09

2009/9/6 Keith Muir <keith.muir(a)blueyonder.co.uk>: > My understanding is that all Total War games work off the Rome Total War > engine and you are correct the wine project under no circumstances should it > focus on individual applications. That said if there is a game engine which > several games use in this case fixing the problems the engine has will fix > multiple games. So the justification is there. Also I am the maintainer for > Medieval II and no it doest work … [View More]

2 1

re: winex11: fix Steam color regression
by Dan Kegel 06 Sep '09

06 Sep '09

wineconsole also became invisible with that regression. Your patch fixes it, thank goodness.

2 1

Game Engine
by Keith Muir 06 Sep '09

06 Sep '09

Hi, The Total war engine continues to bounce between garbage and silver never rising above that level given the installed user base would it be worth devoting more time to fixing the problems wine has with this? as of 1.29 its freezing and unusable. Wine project has to prioritize but success drives the project when people hear they can now do this or that that they couldn't before everyone is inspired its a virtuous circle. Regards, Keith

2 1

Re: Is Wine printing on MacOSX?
by James Mckenzie 04 Sep '09

04 Sep '09

On Fri, Sep 4, Roderick Colenbrander <thunderbird2k(a)gmail.com> > >On Fri, Sep 4, 2009 at 7:04 PM, Dylan Smith<dylan.ah.smith(a)gmail.com> wrote: >> On Wed, Sep 2, 2009 at 12:15 PM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: >>> Hi, >>> >>> although wine in MacOSX works generally good enough (see test.winehq.org about >>> release 1.1.28), I recently visited the print menu in notepad and wordpad to >>> see whether … [View More]

2 1

CPP Run for Sept 3
by chris ahrendt 04 Sep '09

04 Sep '09

[../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [../wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/dlls/ntdll/server.c:882]… [View More]

2 1

Re: winebrowser: Fix broken handling of DDE type XTYP_EXECUTE
by Paul Chitescu 04 Sep '09

04 Sep '09

On Wednesday 02 September 2009 04:15:22 Peter Dons Tychsen wrote: > XTYPE_EXECUTE DDE transaction for winebrowser is broken. > The handler currently expects a MultiByte character input, which is > wrong. > > The handler is win-unicode, and will always receive such strings. > The encoding of the string can be seen in WDML_BuildExecuteCommand(). > > This fixes programs which use DDE to show a web-link via winebrowser, > e.g. the "Last Chaos" web-installer: > http://… [View More]

1 0

Is Wine printing on MacOSX?
by Joerg-Cyril.Hoehle＠t-systems.com 04 Sep '09

04 Sep '09

Hi, although wine in MacOSX works generally good enough (see test.winehq.org about release 1.1.28), I recently visited the print menu in notepad and wordpad to see whether printing would work (in order to complete the FAQ). All that happened is that the printer ejected a blank page. Was anyone more successful than me at printing? - My printer appears in Notepad's and Wordpad's menus, so that's a start. - The page size and portrait/landscape selection dialogue appears. - The OSX printer … [View More]

3 2

Re: urlmon: Add test for IsValidURL [try 2]
by Vladimir Pankratov 04 Sep '09

04 Sep '09

Hello all. What do you think about this? What's wrong in this patch? Any comments? Vladimir Pankratov wrote: > Hello all. > > Added test for IsValidURL. > > Now test shows error codes and tests exact code. > > Thanks Jacek. > > changed files: > dlls/urlmon/tests/misc.c > > Thanks. > > > > > ------------------------------------------------------------------------ > > diff -u -r a/dlls/urlmon/tests/misc.c b/dlls/urlmon/tests/… [View More]misc.c > --- a/dlls/urlmon/tests/misc.c 2009-08-21 23:34:16.000000000 +0500 > +++ b/dlls/urlmon/tests/misc.c 2009-09-01 18:53:08.000000000 +0500 > @@ -1326,6 +1326,44 @@ > IBindCtx_Release(bctx); > } > > +static void test_IsValidURL(void) > +{ > + HRESULT hr; > + int i; > + static const WCHAR good_urls[][100] = { > + {'f','i','l','e',':','/','/','c',':','\\','b','o','o','t','.','i','n','i',0}, > + {'h','t','t','p',':','/','/','w','w','w','.','w','i','n','e','h','q','.','o','r','g',0}, > + {'h','t','t','p','s',':','/','/','s','e','c','u','r','e','.','h','o','s','t','.','d','o','m',0}, > + {'f','t','p',':','/','/','s','o','u','r','c','e','f','o','r','g','e','.','o','r','g',0}, > + {'c',':','\\','b','o','o','t','.','i','n','i',0}, > + {'m','k',0}, > + {'h','t','t','p','s',0} > + }; > + static const WCHAR bad_urls[][100] = { > + {'w','i','n','e','h','q','.','o','r','g',0}, > + {'l','o','c','a','l','h','o','s','t',0}, > + {'t','e','s','t',0}, > + {'1','2','7','.','0','.','0','.','1',0}, > + {'b','o','o','t','.','i','n','i',0} > + }; > + > + hr = IsValidURL(NULL, 0, 10); > + > + ok(hr == E_INVALIDARG, "IsValidURL should fail, expected E_INVALIDARG, got %08x.\n", hr); > + > + for(i = 0; i < sizeof(good_urls)/sizeof(good_urls[0]); i++) > + { > + hr = IsValidURL(NULL, good_urls[i], 0); > + ok(hr == S_OK, "URL %s must be valid, expected S_OK, got %08x.\n", wine_dbgstr_w(good_urls[i]), hr); > + } > + > + for(i = 0; i < sizeof(bad_urls)/sizeof(bad_urls[0]); i++) > + { > + hr = IsValidURL(NULL, bad_urls[i], 0); > + ok(hr == S_FALSE, "URL %s must be invalid, expected S_FALSE, got %08x.\n", wine_dbgstr_w(bad_urls[i]), hr); > + } > +} > + > START_TEST(misc) > { > OleInitialize(NULL); > @@ -1345,6 +1383,7 @@ > test_UrlMkGetSessionOption(); > test_user_agent(); > test_MkParseDisplayNameEx(); > + todo_wine test_IsValidURL(); > > OleUninitialize(); > } [View Less]

2 1

Re: gdi32/tests: Add test for SelectClipRgn in metafile
by Dmitry Timoshkov 04 Sep '09

04 Sep '09

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + hdc = CreateEnhMetaFileA(0, NULL, NULL, NULL); > + > + SetRect(&rc_sclip, 100, 100, GetSystemMetrics(SM_CXSCREEN), GetSystemMetrics(SM_CYSCREEN)); > + hrgn = CreateRectRgn(rc_sclip.left, rc_sclip.top, rc_sclip.right, rc_sclip.bottom); > + SelectClipRgn(hdc, hrgn); > + GetClipBox(hdc, &rc_res); > + todo_wine ok(EqualRect(&rc_res, &rc_sclip), > + "expected rc_res (%d, … [View More]

1 0

font-shape/font-query related regression in wine 1.1.28
by Hin-Tak Leung 04 Sep '09

04 Sep '09

My favourite mono/.net application dies with 'Style Regular isn't supported by font Tahoma' in 1.1.28. I did a git bisect and commit 0b9ba054f6c8a2d96c898e7325087f56a6224644 Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Aug 12 19:19:32 2009 +0200 was the entry that breaks, but just reversing it in 1.1.28 does not fix the problem - i.e. more problematic commits later?; however, replacing the wine-shipped tahoma fonts with those from Vista does cure the problem; so does simply … [View More]

3 4

New winetricks 20090902: new verbs vc2005trial, python26
by Dan Kegel 03 Sep '09

03 Sep '09

Another week, another winetricks. The only interesting changes are new verbs vc2005trial and python26. These are only of interest to developers. vc2005trial is the 180 day Team Server edition of Visual C++ 2005. The winetricks verb for this is a bit odd - it prompts you for your password so it can mount the volume before installation. If you have a better idea, please let me know. I haven't done a KDE version of the prompt; patches welcome. I also haven't implemented -q for this; it's hard to … [View More]

2 3

re: Wine t-shirts?
by Dan Kegel 03 Sep '09

03 Sep '09

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

Re: [1/3] riched20: Implement handling of WM_KEYDOWN VK_RETURN in a dialog mode.
by Dylan Smith 02 Sep '09

02 Sep '09

On Tue, Sep 1, 2009 at 4:18 AM, Sergey Khodych <khodych(a)gmail.com> wrote: > @@ -2145,6 +2145,31 @@ ME_KeyDown(ME_TextEditor *editor, WORD nKey) > ME_SendRequestResize(editor, FALSE); > return TRUE; > case VK_RETURN: > + if (editor->bDialogMode) > + { > + DWORD dwStyle; > + > + if (ctrl_is_down) > + &… [View More]

2 3

Re: [PATCH 5/5] wined3d: Print a warning when an ARB program exceeds the native resource limits.
by Stefan Dösinger 02 Sep '09

02 Sep '09

Am Wednesday 02 September 2009 09:27:58 schrieb Henri Verbeet: > + GL_EXTCALL(glGetProgramivARB(GL_FRAGMENT_PROGRAM_ARB, > GL_PROGRAM_UNDER_NATIVE_LIMITS_ARB, &native)); + > checkGLcall("glGetProgramivARB()"); > + if (!native) WARN("Program exceeds native resource limits.\n"); > + } shouldn't that be a FIXME? The most likely reasons for this are either that we advertise incorrect caps, or our privately added code breaks the limits, or that the driver … [View More]

2 2

Re: gdiplus/tests: Fix test on Win7
by Vincent Povirk 02 Sep '09

02 Sep '09

- gdiplusStartupInput.GdiplusVersion = 2; + gdiplusStartupInput.GdiplusVersion = 42; Could you please test the intermediate versions to determine what's supported? You could use a loop to determine the highest supported version (making sure the return is UnsupportedGdiplusVersion if it's not Ok) followed by a test that the highest supported version is between 1 and some constant. In fact, knowing the supported version would be helpful in any case, and it would be nice to have a trace() … [View More]

1 1

Re: [PATCH 1/3] jscript: Added to_primitive on hosting objects test.
by Alexandre Julliard 02 Sep '09

02 Sep '09

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/jscript/tests/run.c | 32 ++++++++++++++++++++++++++++---- > 1 files changed, 28 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M jscript.dll -T ../../.. -p jscript_test.exe.so run.c && touch run.ok run.c:216: Test failed: V_VT(pvarRes) = 63784 make[2]: *** [run.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

cpp check run monday Aug 31
by chris ahrendt 02 Sep '09

02 Sep '09

I ran CPP check against the monday git tree using the latest CPP check off their git tree. here is the result : [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:320]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:336]: (error) Division by zero [/home/cahrendt/wine-git/dlls/ddraw/tests/d3d.c:340]: (error) Division by zero [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/… [View More]msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:842]: (error) Division by zero [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:843]: (error) Division by zero [/home/cahrendt/wine-git/dlls/sane.ds/ui.c:863]: (error) Division by zero [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:336]: (error) Division by zero [/home/cahrendt/wine-git/dlls/windowscodecs/bmpencode.c:337]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:218]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:219]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:240]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wined3d/wined3d_private.h:241]: (error) Division by zero [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:150]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:211]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 [/home/cahrendt/wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer dereference: hWndCreated [/home/cahrendt/wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/fnt2fon.c:387]: (error) Memory leak: file_lens [/home/cahrendt/wine-git/tools/makedep.c:953]: (error) Resource leak: file [/home/cahrendt/wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [/home/cahrendt/wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/winedump/msmangle.c:164]: (possible error) Memory leak: function_name [/home/cahrendt/wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map chris [View Less]

3 3

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha
by Austin English 01 Sep '09

01 Sep '09

On Tue, Sep 1, 2009 at 3:23 PM, Eric Pouech<eric.pouech(a)orange.fr> wrote: > > > > A+ > --- > > programs/winedbg/be_alpha.c | 8 ++++---- > programs/winedbg/be_ppc.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > > diff --git a/programs/winedbg/be_alpha.c b/programs/winedbg/be_alpha.c > index aeeb79a..8ced1d6 100644 > --- a/programs/winedbg/be_alpha.c > +++ b/programs/… [View More]winedbg/be_alpha.c > @@ -60,25 +60,25 @@ static const struct dbg_internal_var* be_alpha_init_registers(CONTEXT* ctx) > return be_alpha_ctx; > } > > -static unsigned be_alpha_is_step_over_insn(void* insn) > +static unsigned be_alpha_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_function_return(void* insn) > +static unsigned be_alpha_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_break_insn(void* insn) > +static unsigned be_alpha_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_func_call(void* insn, void** insn_callee) > +static unsigned be_alpha_is_func_call(const void* insn, ADDRESS64* callee) > { > return FALSE; > } > diff --git a/programs/winedbg/be_ppc.c b/programs/winedbg/be_ppc.c > index 2e8826e..bff1571 100644 > --- a/programs/winedbg/be_ppc.c > +++ b/programs/winedbg/be_ppc.c > @@ -73,25 +73,25 @@ static const struct dbg_internal_var* be_ppc_init_registers(CONTEXT* ctx) > return be_ppc_ctx; > } > > -static unsigned be_ppc_is_step_over_insn(void* insn) > +static unsigned be_ppc_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_function_return(void* insn) > +static unsigned be_ppc_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_break_insn(void* insn) > +static unsigned be_ppc_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_func_call(void* insn, void** insn_callee) > +static unsigned be_ppc_is_func_call(const void* insn, ADDRESS64* callee) > { > return FALSE; > } > > > > > > Works for PPC. -- -Austin [View Less]

1 0

Re: [PATCH 09/10] mshtml: Added function object tests.
by Paul Vriens 01 Sep '09

01 Sep '09

Jacek Caban wrote: > --- > dlls/mshtml/tests/script.c | 99 > +++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 98 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Looks like this patch introduced test failures on IE6 and IE7 (only? as a box with IE5 succeeded and IE8 seems ok as well). Could you have a look? -- Cheers, Paul.

2 1

Re: urlmon: Add test for IsValidURL
by Jacek Caban 01 Sep '09

01 Sep '09

Hi Vladimir, Vladimir Pankratov wrote: > Hello all. > > Added test for IsValidURL. > > changed files: > dlls/urlmon/tests/misc.c + { + hr = IsValidURL(NULL, bad_urls[i], 0); + ok(hr != S_OK, "URL %s must be invalid\n", wine_dbgstr_w(bad_urls[i])); It would be better to test the exact error code here. Jacek

1 0

Re: [PATCH 1/7] dpwsockx: Stub implementation
by Henri Verbeet 01 Sep '09

01 Sep '09

2009/9/1 Ismael Barros <razielmine(a)gmail.com>: > --- > dlls/dpwsockx/Makefile.in | 2 +- > dlls/dpwsockx/dpwsockx_main.c | 164 ++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 163 insertions(+), 3 deletions(-) > This patch seems to assume the application will never pass NULL for "data", is that safe to assume? If applications aren't allowed to pass NULL it's ok to crash, although it might make your life simpler … [View More]

2 1

Re: [PATCH 4/4] openal32: Add thunks for EFX functions
by Henri Verbeet 01 Sep '09

01 Sep '09

I suppose 32-bit reads are atomic on x86, provided the variable is aligned correctly, but shouldn't access to CurrentCtx technically be synchronized?

2 1

Re: shlwapi: Implement stubs for missing functions required by IE6
by Dmitry Timoshkov 01 Sep '09

01 Sep '09

"Owen Rudge" <orudge(a)codeweavers.com> wrote: > +HRESULT WINAPI IUnknown_UIActivateIO(IUnknown *lpUnknown, BOOL fActivate, LPMSG lpMsg) > +HRESULT WINAPI SHCreatePropertyBagOnRegKey (HKEY hKey, LPCWSTR pszSubKey, > + DWORD grfMode, REFIID riid, void **ppv) > +HRESULT WINAPI SHGetViewStatePropertyBag(LPCITEMIDLIST pidl, LPWSTR lpszBagName, > +INT WINAPI SHFormatDateTimeW(const FILETIME UNALIGNED *fileTime, DWORD *flags, > +INT WINAPI SHFormatDateTimeA(const FILETIME … [View More]

1 0

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)
by James Mckenzie 01 Sep '09

01 Sep '09

> >Fixed a small typing error in the italian translation of clock.exe in >the property menu label (Properietà -> Proprietà). >Compiled and tested correctly on Ubuntu 9.04 64bit. > >(My first patch I send, so please be kind for any error, I'll be happy >to correct it if pointed to, thanks) > >P.S.: For some reason the previous mail attachment showed up empty in >the archives list, even if sent mail is correct, and using Thunderbird I >prefer not to paste … [View More]

2 4

Re: [PATCH] [WineDbg]: fix backend prototypes for PowerPC and Alpha
by Austin English 01 Sep '09

01 Sep '09

On Mon, Aug 31, 2009 at 3:02 PM, Eric Pouech<eric.pouech(a)orange.fr> wrote: > > > > A+ > --- > > programs/winedbg/be_alpha.c | 8 ++++---- > programs/winedbg/be_ppc.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > > diff --git a/programs/winedbg/be_alpha.c b/programs/winedbg/be_alpha.c > index aeeb79a..5f40f71 100644 > --- a/programs/winedbg/be_alpha.c > +++ b/programs/… [View More]winedbg/be_alpha.c > @@ -60,25 +60,25 @@ static const struct dbg_internal_var* be_alpha_init_registers(CONTEXT* ctx) > return be_alpha_ctx; > } > > -static unsigned be_alpha_is_step_over_insn(void* insn) > +static unsigned be_alpha_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_function_return(void* insn) > +static unsigned be_alpha_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_break_insn(void* insn) > +static unsigned be_alpha_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_alpha_is_func_call(void* insn, void** insn_callee) > +static unsigned be_alpha_is_func_call(const void* insn, void** insn_callee) > { > return FALSE; > } > diff --git a/programs/winedbg/be_ppc.c b/programs/winedbg/be_ppc.c > index 2e8826e..c2bc431 100644 > --- a/programs/winedbg/be_ppc.c > +++ b/programs/winedbg/be_ppc.c > @@ -73,25 +73,25 @@ static const struct dbg_internal_var* be_ppc_init_registers(CONTEXT* ctx) > return be_ppc_ctx; > } > > -static unsigned be_ppc_is_step_over_insn(void* insn) > +static unsigned be_ppc_is_step_over_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_function_return(void* insn) > +static unsigned be_ppc_is_function_return(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } > > -static unsigned be_ppc_is_break_insn(void* insn) > +static unsigned be_ppc_is_break_insn(const void* insn) > { > dbg_printf("not done\n"); > return FALSE; > } These all work fine on PPC. > -static unsigned be_ppc_is_func_call(void* insn, void** insn_callee) > +static unsigned be_ppc_is_func_call(const void* insn, void** insn_callee) > { > return FALSE; > } Still got a warning here. -- -Austin [View Less]

1 0

Re: oleaut32: use WIC to decode JPEG images
by Vincent Povirk 31 Aug '09

31 Aug '09

Of course it would probably help if I remembered to attach the patch. On Mon, Aug 31, 2009 at 5:08 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > This needs an updated prefix to work. > > > > -- Vincent Povirk

1 0

What's wrong with my patch?
by Jan de Mooij 31 Aug '09

31 Aug '09

Hello. Subject says it all. I suppose the tests I added may fail on other locales, but there is no other way to test my patch? Should i send it without the tests? Thanks in advance. Jan ---------- Forwarded message ---------- From: Jan de Mooij <jandemooij(a)gmail.com> Date: Mon, Aug 31, 2009 at 2:24 PM Subject: comctl32/propsheet: update position of hidden buttons too To: wine-patches(a)winehq.org eMule iterates all buttons to find the left-most button, and then uses the x and y … [View More]

3 4

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)
by Alexandre Julliard 31 Aug '09

31 Aug '09

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -250,3 +250,25 @@ int CDECL __STRINGTOLD( MSVCRT__LDOUBLE *value, char **endptr, const char *str, > #endif > return 0; > } > + > +/****************************************************************** > + * strtol (MSVCRT.@) > + */ > +long int MSVCRT_strtol(const char* nptr, char** end, int base) > +{ > + /* wrapper to forward libc error code to msvcrt's error codes */ > + long ret = strtol(… [View More]

3 3

Re: [4/7] [try 2] mapi32: Load and store MAPI function pointers after loading MAPI providers
by Henri Verbeet 31 Aug '09

31 Aug '09

2009/8/31 Owen Rudge <orudge(a)codeweavers.com>: > + mapiFunctions.MAPIAddress = (void*) get_mapi_function("MAPIAddress"); That's redundant now. Since you load the pointers all at once, you don't need get_mapi_function() to do the NULL check on the module. You can just enclose the entire block in an if and use GetProcAddress().

1 0

Re: [1/7] [try 2] mapi32: Add stub functions for loading/unloading MAPI providers
by Henri Verbeet 31 Aug '09

31 Aug '09

2009/8/31 Owen Rudge <orudge(a)codeweavers.com>: > +BOOL load_mapi_providers(); > +void unload_mapi_providers(); That doesn't do what you think it does. Also, a return value isn't very useful if you're just going to ignore it.

1 0

Re: msxml3: Add IDispatchEx support to IXMLDOMElement
by Jacek Caban 31 Aug '09

31 Aug '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IDispatchEx support to IXMLDOMElement +static const tid_t domelem_iface_tids[] = { + IXMLDOMNode_tid, + IXMLDOMElement_tid, IXMLDOMElement inherits from IXMLDOMNode, so there is not need to add IXMLDOMNode here. Jacek

1 0

d3dx9: Implement converting and copying surface data in D3DXLoadSurfaceFromMemory (review please)
by Tony Wasserka 31 Aug '09

31 Aug '09

Hi everyone, D3DXLoadSurfaceFromMemory is used to load a chunk of pixel data into a surface, performing any pixel format conversion from signed/unsigned ARGB, floating point or FourCC formats to any other format and also performs various types of filtering actions (one of copying, point filtering, linear filtering, triangular filtering and bov filtering and additionally dithering). I've partially implemented this function during my GSoC project, supporting only unsigned ARGB formats (with 1-4 … [View More]bytes) and copying for now (supporting signed formats and point filtering is trivial to add to this version), but due to the huge functionality of the function it's a hard task to get the code right without either being somewhat slower than the native dll or having thousands of lines of code for each conversion/filtering scenario. My current approach is to implement various specific converters (which actually do converting AND filtering): - converting from and to "small" signed/unsigned ARGB formats - converting "large" ARGB formats to small ones - converting "large" ARGB formats to other large ARGB formats - converting DXT formats to other DXT formats - converting DXT formats to small ARGB formats - .... - additionally, I plan to a function for each filter which filters data when the source and destination formats are the same (which gives a huge performance boost which is e.g. necessary for mipmap generation) As you can see, that's still a great bunch of code, but we don't necessarily need to implement all of these (we could just implement the to/from small ARGB part for each format type and use a buffer if we need to convert from one "unusual" format to another unusual one). These converters will need to be duplicated across the various filter types. This architecture is the only way I could think of managing the implementation of this function without macros (although they would really improve the code in this scenario) and still keeping up to speed with the native dll. I have attached a patch providing my current implementation, providing support for copying data from small unsigned ARGB data to small unsigned ARGB data. A few notes on these few lines of code: 1. if(DestFormat.rbits) { 2. if(SrcFormat.rbits) { 3. for(shift = DestShiftR; shift > DestFormat.rshift; shift -= SrcFormat.rbits) *pPixel |= r << shift; 4. *pPixel |= (r >> (DestFormat.rshift - shift)) << DestFormat.rshift; 5. } else *pPixel |= DestFormat.rmask; 6. } 1: There's no need to mess around with the red component if we don't need it in the destination color anyways 2/5: If the source color does not provide a red component, we assume the maximum red value (which is the red mask) 3/4: These lines convert the source color component to the destination color component; the for loop is needed to make sure that e.g. an R5 0b11111 maps to an 0b11111111 in R8 instead of 0b11111000 (the for loop is faster than using floating point calculation for this) The actual D3DXLoadSurfaceFromMemory implementation doesn't do anything special, the "critical" stuff happens in copy_simple_data. I hope the code is understandable in the other parts, my few main questions are: Do you agree that the architecture is the best approach or can you think of a better one? would using macros be legal here since it could really help reduce code duplication when implementing the other filters? Is the code itself okay? Suggestions about coding style or other things are welcome. Is there any optimization I missed? - I spend a somewhat large amount of time getting the right balance between wide format support and good performance, but maybe things can be improved a bit more. Right now my implementation is about 10 % slower than the native one. Any other comments which could be interesting to me at this point are also appreciated, of course. Best regards, Tony [View Less]

4 8

RFC: Fixing kernel32:locale tests on Vista and higher
by Ge van Geldorp 31 Aug '09

31 Aug '09

There are quite a few failures in kernel32:locale on Vista+. The attached patch tries to address those. Although any comment on the patch is welcome, I'm particularly interested in feedback on the changes to test_FoldStringW() (the part that starts at "@@ -2081,43 +2136,49 @@ static void test_FoldStringW(void)".) The problem with this test was that FoldStringW() behaves very differently on Vista+ for the MAP_FOLDCZONE and MAP_EXPAND_LIGATURES cases. The tests were broken off after more than 50 … [View More]

5 5

Missing libxml2 -> msxml3 compilation error
by Francois Gouget 31 Aug '09

31 Aug '09

It turns out I was missing libxml2 in one of my environments and this lead to the following compilation error: $ gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings -Wpointer-arith -g -O2 -o dispex.o dispex.c dispex.c:49: field `tid' has incomplete type dispex.c:76: `LAST_tid' undeclared here (not in a function) dispex.c:115: parameter `tid' has incomplete type ... The problem is that tid_t … [View More]

2 1

Re: RFC: Fixing kernel32:locale tests on Vista and higher
by Greg Geldorp 30 Aug '09

30 Aug '09

From: Reece Dunn > Does anyone understand what these are doing and (in a general sense) > what the changes to Vista are? When you specify the MAP_FOLDCZONE flag, FoldStringW() on Vista will try to return a "simple" presentation for the Unicode characters. For example, if you pass in 0x01c7 ("LATIN CAPITAL LETTER LJ", L and J combined into a single Unicode character, see http://www.fileformat.info/info/unicode/char/01c7/index.htm) then FoldStringW() will return two characters: the letter … [View More]

1 0

Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt 30 Aug '09

30 Aug '09

This is the result of running cppcheck 1.35 with the --all parm against the august 27th Git tree: [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of bounds [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of bounds [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak:… [View More] stream4 [../wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [../wine-git/dlls/shell32/cpanelfolder.c:562]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_desktop.c:437]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_fs.c:577]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_mycomp.c:474]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/shell32/shfldr_netplaces.c:352]: (error) Possible null pointer dereference: rgfInOut [../wine-git/dlls/user32/tests/msg.c:63]: (error) Invalid number of character ({). Can't process file. [../wine-git/dlls/winealsa.drv/waveinit.c:745]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:907]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:915]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3416]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3418]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3519]: (possible error) Buffer overrun [../wine-git/dlls/wined3d/glsl_shader.c:3521]: (possible error) Buffer overrun [../wine-git/dlls/wineoss.drv/mixer.c:1458]: (possible error) Buffer overrun [../wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW [../wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer dereference: hWndCreated [../wine-git/programs/winetest/main.c:114]: (possible error) Buffer overrun [../wine-git/programs/winetest/main.c:116]: (possible error) Buffer overrun [../wine-git/programs/winetest/main.c:119]: (possible error) Buffer overrun [../wine-git/programs/winetest/main.c:121]: (possible error) Buffer overrun [../wine-git/server/file.c:235]: (possible error) Buffer overrun [../wine-git/tools/fnt2bdf.c:656]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:303]: (error) Memory leak: file_lens [../wine-git/tools/makedep.c:337]: (error) Resource leak: file [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd [../wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map Chris [View Less]

7 7

re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation
by Dan Kegel 30 Aug '09

30 Aug '09

It'd be cool if you mentioned what this patch series does for users. Does it fix some app that's broken? You probably need to include conformance tests for the new functions you implement. You may find that the maintainer is very picky about changes to wineserver. Don't be discouraged if your patch series isn't accepted at first, just keep improving it, addressing the issues people raise, and resubmitting.

1 0

Re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation
by Mike Kaplinskiy 29 Aug '09

29 Aug '09

On Sat, Aug 29, 2009 at 1:51 AM, shanmukha sainath addepalli<sainath.addepalli(a)gmail.com> wrote: > > Hi, > > These are the series of patches for SwitchDesktop and > OpenInputDesktop API implementation in user32.dll > > SwitchDesktop API when called switches to another desktop and makes > it active. > > First patch is the implementation of … [View More]

1 0

Re: write initial italian translation
by James Mckenzie 29 Aug '09

29 Aug '09

> >Here's the initial italian translation for write. Again, this is not acceptable. The input file should be /dev/null with the difference against your file. You are running a difference against the en_US.rc file after renaming it. Please correct and resubmit. This is the same problem that was pointed out to you with your prior rejected translations. James McKenzie

1 0

Re: wordpad - initial italian translation
by James Mckenzie 29 Aug '09

29 Aug '09

> >Here's the initial italian translation for wordpad. This is STILL WRONG! You are not listening. If this is an initial translation, the input file should be /dev/null, not en_US.rc which is what you are using. Please correct and resubmit. James McKenzie

1 0

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)
by Henri Verbeet 29 Aug '09

29 Aug '09

2009/8/29 Riccardo Loti <contez(a)gmail.com>: > P.S.: For some reason the previous mail attachment showed up empty in the > archives list, even if sent mail is correct, and using Thunderbird I prefer > not to paste it int he message body. Sorry for double sending. > The archives are a bit flawed, and created a separate mail for the attachment: http://www.winehq.org/pipermail/wine-patches/2009-August/077889.html The mail itself looked ok.

1 0

Re: [PATCH 1/3] dpwsockx: Stub implementation
by Stefan Dösinger 29 Aug '09

29 Aug '09

Yay, Dplay work! A few suggestions though: From patch 1: > +static HRESULT WINAPI DPWSCB_GetCaps( LPDPSP_GETCAPSDATA data ) > +{ > + TRACE( "(%d,%p,0x%08x,%p)\n", > + data->idPlayer, data->lpCaps, data->dwFlags, data->lpISP ); >+ return DP_OK; > +} Is there any reason this one writes a TRACE instread of a FIXME? I noticed that patch 3 implements it, perhaps you missed this when separating the patches? > +static HRESULT WINAPI DPWSCB_Open( … [View More]

2 1

Re: configure: Detect and use tools executable extensions for makefiles. (try2)
by John Klehm 29 Aug '09

29 Aug '09

On Fri, Aug 28, 2009 at 3:13 PM, Dylan Smith<dylan.ah.smith(a)gmail.com> wrote: > (used sed to get the EXEEXT from the wine-tools/Make.rules file) > > When compiling Wine on windows, the non-script tools will have an .exe > extension, but the makefile rules assumed that the tools never have an > extention, so try to incorrectly remake the tools when they are already > built. > Is this patch solving the same thing that this one did? http://www.winehq.org/pipermail/wine-cvs/2009-August/058936.html

2 1

Re: progress of sound update -- REVISED
by Susan Cragin 29 Aug '09

29 Aug '09

>>Why do you need to install esound? >ALSA has shipped with "dmix" by default since shortly after 1.0 was >released, though I think Ubuntu's pulse config can screw with it even >after pulseaudio is removed. I'd forgotten about dmix, it's been so long. Good old dmix and dsnoop (which is what I need for incoming sound). I THINK MAYBE dmix works and dsnoop does not, because it's listed when I open Audacity. I'll have to give it a try. However, without installing esound, I don'… [View More]

2 1

Re: Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt 28 Aug '09

28 Aug '09

Mike Kaplinskiy wrote: > On Thu, Aug 27, 2009 at 3:52 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> This is the result of running cppcheck 1.35 with the --all parm against >> the august 27th Git tree: >> >> [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of >> bounds >> [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of >> bounds >> > > False positive, apparently the … [View More]numbers are hardcoded as: > 72 char msg[128]; > 88 msg[10 + 3 * 16] = ' '; // = 58<127 > 89 msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127 > > >> [../wine-git/dlls/shell32/cpanelfolder.c:562]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_desktop.c:437]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_fs.c:577]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_mycomp.c:474]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_netplaces.c:352]: (error) Possible null >> pointer dereference: rgfInOut >> > > It doesn't like the ternary operator? These lines are TRACE lines with > one of the args being ``rgfInOut ? *rgfInOut : 0''. False positive. > > >> [../wine-git/dlls/user32/tests/msg.c:63]: (error) Invalid number of >> character ({). Can't process file. >> [../wine-git/dlls/winealsa.drv/waveinit.c:745]: (possible error) Buffer >> overrun >> > > 739 char defaultpcmname[256]; > 745 sprintf(defaultpcmname, "default"); > > Something is wrong with cppcheck... False positive. > > >> [../wine-git/dlls/wined3d/arb_program_shader.c:907]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/arb_program_shader.c:915]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3416]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3418]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3519]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3521]: (possible error) Buffer >> overrun >> > > Not checking those - i don't even pretend to understand how modern > graphics works. > > >> [../wine-git/dlls/wineoss.drv/mixer.c:1458]: (possible error) Buffer overrun >> > > So...it picks > 1455 char name[32]; > 1458 sprintf(name, "/dev/mixer"); > > as an error, but not: > > 1460 sprintf(name, "/dev/mixer%d", i); > > False positive. > > >> [../wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer >> dereference: dmW >> > > This one is actually a bug, the null check is below this line. All the > callers check for nulls, though. > > >> [../wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer >> dereference: hWndCreated >> > > Also a bug, and a very real one. Coincidentally, the null check on the > next line is also wrong (should be if (!*hWndCreated) ) > > >> [../wine-git/programs/winetest/main.c:114]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:116]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:119]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:121]: (possible error) Buffer overrun >> > > More of sprintf with just a string nonsense. False positive. > > >> [../wine-git/server/file.c:235]: (possible error) Buffer overrun >> > > Also sprintf nonsense, but slightly more dangerous. The buffer is > declared with [16] and the string is of length 14+1, so a few more > bytes wouldn't hurt. :) > >> Chris >> >> > > If someone could send patches for the few bugs that would be nice. > > Chris - cppcheck is clearly crazy about sprintf's and ternary > operators. You might want to report that. > > Mike. > > > Mike While yes the hard coded one above is a false positive... I would argue its still a bug that probably needs to get fixed... chris [View Less]

5 6

Recent ntdll performance information patches
by Steven Edwards 28 Aug '09

28 Aug '09

Since the last few rounds of patches to NtQuerySystemInformation I am now getting this error when trying to build with llvm-gcc from the latest Xcode nt.c: In function ‘NtQuerySystemInformation’: nt.c:1012: error: ‘struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION’ has no member named ‘liIdleTime’ nt.c:1013: error: ‘struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION’ has no member named ‘liKernelTime’ nt.c:1014: error: ‘struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION’ has no member named ‘… [View More]

1 0

Re: [PATCH 6/7] ws2_32: implement AcceptEx
by Juan Lang 28 Aug '09

28 Aug '09

Hi Mike, I have one minor nit on this patch: + if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read ); Please don't check if (wsa->read) is NULL before calling HeapFree. HeapFree already does the correct thing given NULL, and we had a bunch of patches to remove checks like this. --Juan

2 1

WINE and the LSB, or installations Picasa style
by Joe Dluzen 28 Aug '09

28 Aug '09

Hello all, any updates on the progress of compiling WINE against the LSB? I know Dan was attempting to here http://www.mail-archive.com/wine-devel@winehq.org/msg47916.html but there's been no recent updates. Or, does anyone have any tips or tutorials or best practices to deploy a self contained WINE installation, e.g. Picasa style? Thanks, j

1 0

Re: progress of sound update -- REVISED
by Susan Cragin 28 Aug '09

28 Aug '09

Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound -------- Why do you need to install esound? I don't know. I've taken it for granted that some kind of mixer is needed. Perhaps because I don't use the default sound card, the on-board card. Maybe I don't need esound at all. Or maybe if I could … [View More]

2 1

Re: netapi32/tests: Add acceptable error codes for Win7
by André Hentschel 28 Aug '09

28 Aug '09

adding "|| RPC_S_SERVER_UNAVAILABLE" is surely not what you wanted, i think you mean "|| rc == RPC_S_SERVER_UNAVAILABLE" -- Best Regards, André Hentschel

2 1

Re: progress of sound update -- REVISED
by Susan Cragin 28 Aug '09

28 Aug '09

Change -- The program I test with is Dragon NaturallySpeaking. Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound sudo nano /etc/pulse/client.conf autospawn = no Then every time your computer starts, run killall pulseaudio in terminal first. (Because the Startup Applications menu doesn't really work.)… [View More]

2 1

progress of sound update
by Susan Cragin 28 Aug '09

28 Aug '09

Yesterday's Ubuntu updates produced a rash of pulseaudio changes, and suddenly alsa works with wine, without stumbling. Today's secret to making it work: In System/Preferences/Startup applications, uncheck pulseaudio sudo apt-get install esound sudo nano /etc/pulse/client.conf autospawn = no Then every time your computer starts, run killall pulseaudio in terminal first. (Because the Startup Applications menu doesn't really work.) I trained and ran pulseaudio without a problem. I also tried … [View More]

1 0

Re: Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt 28 Aug '09

28 Aug '09

James McKenzie wrote: > chris ahrendt wrote: > >> ----- Original Message ---- >> From: Ben Klein <shacklein(a)gmail.com> >> To: chris ahrendt <celticht32(a)yahoo.com> >> Cc: wine-devel(a)winehq.org >> Sent: Thursday, August 27, 2009 10:06:56 PM >> Subject: Re: Weekly cppcheck run against Aug 27 Git Tree >> >> 2009/8/28 chris ahrendt <celticht32(a)yahoo.com>: >> >> >>> Mike Kaplinskiy wrote: &… [View More]

1 0

Re: Weekly cppcheck run against Aug 27 Git Tree
by chris ahrendt 28 Aug '09

28 Aug '09

Mike Kaplinskiy wrote: > On Thu, Aug 27, 2009 at 3:52 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> This is the result of running cppcheck 1.35 with the --all parm against >> the august 27th Git tree: >> >> [../wine-git/dlls/dbghelp/msc.c:88]: (possible error) Array index out of >> bounds >> [../wine-git/dlls/dbghelp/msc.c:89]: (possible error) Array index out of >> bounds >> > > False positive, apparently the … [View More]numbers are hardcoded as: > 72 char msg[128]; > 88 msg[10 + 3 * 16] = ' '; // = 58<127 > 89 msg[10 + 3 * 16 + 1 + 16] = '\0'; // = 75<127 > > >> [../wine-git/dlls/shell32/cpanelfolder.c:562]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_desktop.c:437]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_fs.c:577]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_mycomp.c:474]: (error) Possible null >> pointer dereference: rgfInOut >> [../wine-git/dlls/shell32/shfldr_netplaces.c:352]: (error) Possible null >> pointer dereference: rgfInOut >> > > It doesn't like the ternary operator? These lines are TRACE lines with > one of the args being ``rgfInOut ? *rgfInOut : 0''. False positive. > > >> [../wine-git/dlls/user32/tests/msg.c:63]: (error) Invalid number of >> character ({). Can't process file. >> [../wine-git/dlls/winealsa.drv/waveinit.c:745]: (possible error) Buffer >> overrun >> > > 739 char defaultpcmname[256]; > 745 sprintf(defaultpcmname, "default"); > > Something is wrong with cppcheck... False positive. > > >> [../wine-git/dlls/wined3d/arb_program_shader.c:907]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/arb_program_shader.c:915]: (possible error) >> Buffer overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3416]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3418]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3519]: (possible error) Buffer >> overrun >> [../wine-git/dlls/wined3d/glsl_shader.c:3521]: (possible error) Buffer >> overrun >> > > Not checking those - i don't even pretend to understand how modern > graphics works. > > >> [../wine-git/dlls/wineoss.drv/mixer.c:1458]: (possible error) Buffer overrun >> > > So...it picks > 1455 char name[32]; > 1458 sprintf(name, "/dev/mixer"); > > as an error, but not: > > 1460 sprintf(name, "/dev/mixer%d", i); > > False positive. > > >> [../wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer >> dereference: dmW >> > > This one is actually a bug, the null check is below this line. All the > callers check for nulls, though. > > >> [../wine-git/programs/oleview/pane.c:152]: (error) Possible null pointer >> dereference: hWndCreated >> > > Also a bug, and a very real one. Coincidentally, the null check on the > next line is also wrong (should be if (!*hWndCreated) ) > > >> [../wine-git/programs/winetest/main.c:114]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:116]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:119]: (possible error) Buffer overrun >> [../wine-git/programs/winetest/main.c:121]: (possible error) Buffer overrun >> > > More of sprintf with just a string nonsense. False positive. > > >> [../wine-git/server/file.c:235]: (possible error) Buffer overrun >> > > Also sprintf nonsense, but slightly more dangerous. The buffer is > declared with [16] and the string is of length 14+1, so a few more > bytes wouldn't hurt. :) > >> Chris >> >> > > If someone could send patches for the few bugs that would be nice. > > Chris - cppcheck is clearly crazy about sprintf's and ternary > operators. You might want to report that. > > Mike. > > > Sending the report now. chris [View Less]

1 0

submitted AppDB links to bugzilla not working anymore?
by Joerg-Cyril.Hoehle＠t-systems.com 27 Aug '09

27 Aug '09

Hi, Several recent link proposals between AppDB and Buzilla acknowledged by "The bug link you submitted between Bug NNN and XYZ has been accepted." have nevertheless produced no visible bug # in AppDB nor "Show Apps affected" in Bugzilla. E.g. Bug #19773 among others. Did some recent changes to the server break that functionality? BTW, a few month ago, I was pleased to see that some links were automatically(?) created when the bug subject had the format app-name: blabla That was a useful … [View More]

3 3

RE: [2/2] shell32: Remove todo_wine from some tests [try 2]
by First Store 27 Aug '09

27 Aug '09

My domain never subscribed to this, please quit sending me these. -----Original Message----- From: wine-patches-bounces(a)winehq.org [mailto:wine-patches-bounces@winehq.org] On Behalf Of Vladimir Pankratov Sent: Thursday, August 27, 2009 10:22 AM To: wine-patches(a)winehq.org Subject: [2/2] shell32: Remove todo_wine from some tests [try 2] Hello all. Also resend this patch. Removed todo_wine from some tests. changed files: dlls/shel32/tests/shfileop.c Thanks.

1 0

Re: [2/2] shell32: Remove todo_wine from some tests [try 2]
by Juan Lang 27 Aug '09

27 Aug '09

Hi Vladimir, you can't do this in two separate patches like this. After the first patch is applied, the tests fail, and that's not allowed. You should combine the fix and removing todo_wine into a single patch. Thanks, --Juan

1 0

[RFC] Adding an OpenAL DLL thunk
by Chris Robinson 27 Aug '09

27 Aug '09

Attached is a set of patches that adds an openal32.dll thunk, allowing an app using OpenAL to use the system's lib instead of Creative's software driver. The advantages of using the system lib include: * It avoids the unnecessary step through DirectSound, instead going right to ALSA, OSS, or whichever is supported by the system implementation. This also allows for a DSound->OpenAL wrapper, since OpenAL won't create a circular dependency by using DSound. * It can provide more options … [View More]

5 9

Re: configure: Detect and use tools executable extensions for makefiles.
by Steven Edwards 27 Aug '09

27 Aug '09

On Wed, Aug 26, 2009 at 2:21 PM, Dylan Smith<dylan.ah.smith(a)gmail.com> wrote: > When compiling Wine on windows, the non-script tools will have an .exe > extension, but the makefiles assumed that the tools never have an > extention. Naturally this caused problems with the build, causing it to > fail on Windows. > > Please re-run autoconf to update the configure script. > --- > Make.rules.in | 21 +++++++++++---------- > configure.ac &… [View More]

3 6

Re: [PATCH 3/3] gdiplus: Implement GdipIsVisibleRect
by Henri Verbeet 27 Aug '09

27 Aug '09

2009/8/27 Andrew Eikum <aeikum(a)codeweavers.com>: > +GpStatus WINGDIPAPI GdipIsVisibleRectI(GpGraphics *graphics, INT x, INT y, INT width, INT height, BOOL *result) > +{ > + TRACE("(%p %d %d %d %d %p)\n", graphics, x, y, width, height, result); > + > + if(!graphics || !result) > + return InvalidParameter; > + > + if(graphics->busy) > + return ObjectBusy; > + > + return GdipIsVisibleRect(graphics, (REAL)x, (REAL)y, (REAL)width, … [View More]

1 0

Re: [4/6] mapi32: Implement MAPIInitialize, Logon, Logoff, LogonEx, Uninitialize
by Henri Verbeet 27 Aug '09

27 Aug '09

2009/8/26 Owen Rudge <orudge(a)codeweavers.com>: > --- > dlls/mapi32/mapi32_main.c | 93 > +++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 86 insertions(+), 7 deletions(-) > > Is there any special reason for not loading the function pointers at dll init?

1 0

Re: reg initial italian translation
by James McKenzie 27 Aug '09

27 Aug '09

Davide Pizzetti wrote: > Here's the initial italian translation for reg. Hope it works now > > If this were truly a new translation the input file would be a/dev/null This is not the case in your patches. Are you trying to update existing code? This goes for all of your initial translation attempts. James McKenzie

1 0

Re: mshtml: Make create_nsstream() static.
by Jacek Caban 26 Aug '09

26 Aug '09

Hi Francois, It should be completely removed as it's not used anymore. Also nsIStringInputStream may be removed. I've sent a patch, thanks for catching it. Jacek

1 0

Re: dxdiag: add basic commandline parsing (try 2)
by Jacek Caban 26 Aug '09

26 Aug '09

Hi Austin, Austin English wrote: > Please apply after the first dxdiag patch (unicode-ify). Based on a > patch by Dan Kegel. > > case 'w': + opt_given = TRUE; + while (isalpha(*s) || *s == ':') + You can't use isalpha on WCHAR. Use isalphaW instead. Jacek

2 1

new winetricks 20090826: new verbs vc2005express, psdk2003, mono24
by Dan Kegel 26 Aug '09

26 Aug '09

Another fortnight, another winetricks. Main changes are: new verbs vc2005express, psdk2003, mono24 plus some bug fixes. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes since 20090815: r653 | daniel.r.kegel | 2009-08-23 18:19:41 -0700 (Sun, 23 Aug 2009) | 4 lines Work around possible wine bug in openwatcom installer in silent install to turn on 16 bit tools installation. Promote … [View More]openwatcom to non-broken secton of winetricks again. ------------------------------------------------------------------------ r652 | daniel.r.kegel | 2009-08-23 08:24:44 -0700 (Sun, 23 Aug 2009) | 7 lines Add missing checksums. Warn people that vista sdk doesn't install yet. Fix hang in vc2005express verb introduced in last change Added missing verbs in winetrickstest Demoted a few verbs to broken list ------------------------------------------------------------------------ r651 | daniel.r.kegel | 2009-08-22 17:46:56 -0700 (Sat, 22 Aug 2009) | 5 lines vc2005express: 1) remove single quote in description that broke gui menu 2) add warning about mt.exe 3) wait until install (almost) finishes ------------------------------------------------------------------------ r650 | austinenglish | 2009-08-22 15:23:30 -0700 (Sat, 22 Aug 2009) | 2 lines winetricks: add OpenWatcom bug link ------------------------------------------------------------------------ r649 | daniel.r.kegel | 2009-08-22 13:34:25 -0700 (Sat, 22 Aug 2009) | 2 lines Added new verbs vcexpress2005, psdk2003, and psdkvista ------------------------------------------------------------------------ r647 | austinenglish | 2009-08-21 18:36:11 -0700 (Fri, 21 Aug 2009) | 2 lines winetricks: OpenWatcom's silent install is broken ------------------------------------------------------------------------ r646 | daniel.r.kegel | 2009-08-21 12:48:58 -0700 (Fri, 21 Aug 2009) | 3 lines Bump version to 20090821 ------------------------------------------------------------------------ r645 | daniel.r.kegel | 2009-08-18 12:05:53 -0700 (Tue, 18 Aug 2009) | 3 lines Added cygwin (whee!) ------------------------------------------------------------------------ r642 | daniel.r.kegel | 2009-08-16 15:56:44 -0700 (Sun, 16 Aug 2009) | 3 lines Only show GUI warnings if run without args. ------------------------------------------------------------------------ r639 | daniel.r.kegel | 2009-08-15 22:49:55 -0700 (Sat, 15 Aug 2009) | 3 lines Add mono24 Also remove one obsolete comment in mono22 [View Less]

1 0

Re: dxdiag: add basic command line parsing
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/26 Austin English <austinenglish(a)gmail.com>: > Based on Dan Kegel's patch he wrote for Louis Lenders old implementation. > It probably doesn't make much of a difference for command line parsing, but I think you want to make dxdiag explicitly unicode from the start (new programs in general, really). It also seems to me that this patch doesn't do a whole lot in practice.

3 3

Re: wined3d: delete meaningless UNIX GL driver version parsing
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/26 <Joerg-Cyril.Hoehle(a)t-systems.com>: > Hi, > > Please excuse my previous patch. It was against 1.1.27. Here it is against 1.1.28. > Ah, those were the times when I patched areas nobody else would touch ;-) > This one does happen to apply, but please send patches against current git in the future. I'm not entirely sure if this is better than just fixing the code, but if Roderick and Stefan think it's a good idea it's probably worth a try.

1 0

Re: libs/port: Use the gcc interlocked code also for pcc
by Alexandre Julliard 26 Aug '09

26 Aug '09

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -24,7 +24,7 @@ > > #ifdef __i386__ > > -#ifdef __GNUC__ > +#if defined(__GNUC__) || defined(__PCC__) A better way would be to make this case the default, it's not all that gcc-specific. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d10core/tests: Add acceptable error code for Win7
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/26 Ge van Geldorp <ggeldorp(a)vmware.com>: > hr = IDXGIFactory_EnumAdapters(factory, 0, &adapter); > - ok(SUCCEEDED(hr), "EnumAdapters failed, hr %#x\n", hr); > + ok(SUCCEEDED(hr) || hr == DXGI_ERROR_NOT_FOUND, "EnumAdapters failed, hr %#x\n", hr); Is that in a VM? It's fine to skip the test if there are no adapters, but I don't think that's supposed to happen on real hardware.

1 0

Re: wrc: Fix a memory leak on output file name (Smatch)
by Alexandre Julliard 26 Aug '09

26 Aug '09

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > The memory is released just thereafter (process end), but this is a leak anyway It's not a leak. There's no point in wasting time freeing memory in main(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg - italian translation update
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/25 Davide Pizzetti <erpizzo(a)alice.it>: > - LTEXT "Wine puÃ² simulare diverse versioni e stili di Windows per ogni applicazione", > + LTEXT "Wine può simulare diverse versioni e stili di Windows per ogni applicazione", Looks like you messed up the encoding of the original file somehow. Probably interpreted utf-8 as ISO 8859-1.

1 0

Re: [PATCH 1/2] gdiplus: Implement GdipIsVisibleRegionPoint
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/25 Andrew Eikum <aeikum(a)codeweavers.com>: > +GpStatus WINGDIPAPI GdipIsVisibleRegionPointI(GpRegion* region, INT x, INT y, GpGraphics *graphics, BOOL *res) > +{ > + TRACE("(%p, %d, %d, %p, %p)\n", region, x, y, graphics, res); > + > + if(!region || !res) > + return InvalidParameter; It's a bit redundant to do that check twice. Shouldn't hurt much though.

1 0

Re: oleview initial italian translation
by Henri Verbeet 26 Aug '09

26 Aug '09

2009/8/25 Davide Pizzetti <erpizzo(a)alice.it>: > @@ -1,6 +1,6 @@ > /* > - * OleView (En.rc) > - * English Language Support > + * OleView (It.rc) > + * Italian Language Support > * > * Copyright 2006 Piotr Caban > * That doesn't look right. How did you create these patches?

1 0

Re: [PATCH 2/2] fonts: .gitignore += *.fnt (autogenerated)
by Paul Chitescu 26 Aug '09

26 Aug '09

On Tuesday 25 August 2009 19:27:23 Kirill Smelkov wrote: > Signed-off-by: Kirill Smelkov <kirr(a)mns.spb.ru> > --- > fonts/.gitignore | 58 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 58 > insertions(+), 0 deletions(-) > > diff --git a/fonts/.gitignore b/fonts/.gitignore > index a857f0d..523a9a4 100644 > --- a/fonts/.gitignore > +++ b/fonts/.gitignore > @@ -37,3 +37,61 @@ > /vgasysg.fon > /vgasysr.fon > /vgasyst.… [View More]

2 1

Re: tools/wine.inf: fix New Zealand DST
by Dmitry Timoshkov 26 Aug '09

26 Aug '09

"Austin English" <austinenglish(a)gmail.com> wrote: > Reported in wine-users. Two points: 1. These data are auto generated. 2. Existing data for New Zealand Standard Time,"TZI" do match what XP SP3 has, a new one doesn't. -- Dmitry.

2 2

about video memory detection in wine
by Sun, Sunny 25 Aug '09

25 Aug '09

Hi You are using the hardcoded method to get the vidmem now (in function IWineD3DImpl_FillGLCaps), first you call glGetString(GL_RENDERER) to get the GPU renderer string, and then you use this string to set the vidmem in your code. Unfortunately you don't get all of the ATI GPU's string now, for our workstation GPU, the string is always like "ATI FireGL V8700", so you don't recognize this GPU and consider it as ATI_RADEON_9500, then 64MB is set which doesn't support 1280x1024 resolution (Out … [View More]

7 20

Re: [1/5] user32:edit Use a dialog mode after receiving WM_GETDLGCODE message.
by Juan Lang 25 Aug '09

25 Aug '09

Hi Sergey, one very minor comment on this patch: + len = SendMessage(hwEdit, WM_GETTEXTLENGTH, 0, 0); + ok(13 == len, "expected 11, got %d\n", len); Nit: you mean "expected 13", not 11. The same is true for every instance where 13 is the expected length. --Juan

1 0

Re: shdocvw.inf: add default registry key HKCU, "Software\Microsoft\Internet Explorer\Settings
by Alexandre Julliard 25 Aug '09

25 Aug '09

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > @@ -142,6 +142,7 @@ HKLM,"Software\Microsoft\Windows\CurrentVersion\URL\Prefixes","www",,"http://" > [Settings.Reg] > HKCU,"Software\Microsoft\Internet Explorer\Main","Start Page",2,"http://www.winehq.org" > HKCU,"Software\Microsoft\Internet Explorer\Main","Search Page",2,"http://www.google.com" > +HKCU,"Software\Microsoft\Internet Explorer\Settings",,,"" This will create an empty value that doesn't exist on … [View More]

1 0

Re: mapi32/tests: Skip tests if no default email client is installed
by Eric Pouech 25 Aug '09

25 Aug '09

+static BOOL HaveDefaultMailClient() this should be +static BOOL HaveDefaultMailClient(void) A+ -- Eric Pouech

1 0

Re: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior
by Alexandre Julliard 25 Aug '09

25 Aug '09

Jeff Zaroyko <jeffzaroyko(a)gmail.com> writes: > This fixes bug 15181, test included - passes on Windows 95, 2003, XP, > 2008, Vista and Windows 7 beta that I've tested. > > From 52ff2d29ba9fbffbe8da46a7523338e8b946bbcd Mon Sep 17 00:00:00 2001 > From: Jeff Zaroyko <jeffz(a)jeffz.name> > Date: Sun, 23 Aug 2009 12:38:17 +1000 > Subject: kernel32: set sLanguage to LOCALE_SABBREVLANGUAGE to match Windows behavior > > As a Profile entry and under Control … [View More]

2 2

Build failure on current git
by Stefan Leichter 24 Aug '09

24 Aug '09

Hello, building current git fails for me with: make: Entering directory `/usr/src/wine/wine-build/dlls/winemp3.acm' ../../tools/winegcc/winegcc -B../../tools/winebuild --sysroot=../.. -shared ../../../wine-git/dlls/winemp3.acm/winemp3.acm.spec mpegl3.o -o winemp3.acm.so -lwinmm -luser32 -lkernel32 ../../libs/port/libwine_port.a -lmpg123 mpegl3.o: In function `mp3_horse': /usr/src/wine/wine-build/dlls/winemp3.acm/../../../wine-git/dlls/winemp3.acm/mpegl3.c:153: undefined … [View More]

2 1

Re: Build failure on current git
by Robert Förster 24 Aug '09

24 Aug '09

according to the mpg123 NEWS file mpg123_feed was introduced with 1.5.0 if this is actually the lowest version to compile with, it should be checked by ./configure if possible. linking against system libmpg123 does have other issues however. im building a 32 bit wine on a 64 bit box here and i have installed a 32 bit libary of libmpg123 of course, however: mpegl3.o: In function `MPEG3_Reset': mpegl3.c:(.text+0xca): undefined reference to `mpg123_feedseek' the symbol is actually … [View More]

1 0

winemp3.acm: link to system libmpg123.so
by Robert Förster 24 Aug '09

24 Aug '09

im getting undefined references to mpg123_feedseek. im on amd64, building a 32 bit wine, so of course i have a 32 bit lib of mpg123 around, which however seems to export mpg123_feedseek_64 instead. could that be covered too please? (i have reports that this is happening on plain x86 boxes too.) Robert

1 0

Re: wined3d: delete meaningless UNIX GL driver version parsing
by Stefan Dösinger 24 Aug '09

24 Aug '09

Am Monday 24 August 2009 18:02:37 schrieb Joerg-Cyril.Hoehle(a)t-systems.com: > Hi, > > here's the patch not to report UNIX GL driver version numbers to MS-Windows > apps, as suggested by Stefan and Roderick on 2009-05-25. > > On "early 2009" NVidia MacOS, it will remove > err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 > NVIDIA-1.5.44" The patch is fine with me. On a related note, it would be helpful if people who have an Intel GPU on their … [View More]

2 1

Re: [PATCH 1/5] msdaps: Use 2 byte structure packing.
by Alexandre Julliard 24 Aug '09

24 Aug '09

Huw Davies <huw(a)codeweavers.com> writes: > diff --git a/dlls/msdaps/Makefile.in b/dlls/msdaps/Makefile.in > index d6f71a0..cebf659 100644 > --- a/dlls/msdaps/Makefile.in > +++ b/dlls/msdaps/Makefile.in > @@ -5,6 +5,7 @@ VPATH = @srcdir@ > MODULE = msdaps.dll > IMPORTS = oleaut32 rpcrt4 kernel32 ntdll > EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0x06210e88, 0x01f5, 0x11d1, { 0xb5, 0x12, 0x00, 0x80, 0xc7, 0x81, 0xc3, 0x84 } }" > +… [View More]

2 2

Re: shlwapi/tests: Remove test that crashes on Win7
by Reece Dunn 24 Aug '09

24 Aug '09

2009/8/24 Ge van Geldorp <ggeldorp(a)vmware.com>: > Changelog: > shlwapi/tests: Remove test that crashes on Win7 - ret = IStream_Clone(stream, NULL); - ok(ret == E_NOTIMPL, "expected E_NOTIMPL, got 0x%08x\n", ret); + /* Passing a NULL pointer crashes on Win7 */ If you are going to change this to a comment, could you please say which argument passing NULL to causes the crash. Thanks, - Reece

1 0

Re: ddraw: Separate reference counting for IDirectDraw7 and IDDS4 from IDDS3, IDDS2 and IDDS (try 2)
by Stefan Dösinger 24 Aug '09

24 Aug '09

I think it is better to separate the vtables first - ie, give IDirectDrawSurface4, IDirectDrawSurface2 and IDirectDrawSurface their own vtable Also the last iteration of Michael Karcher's patches missed out some getters, like IDirect3DDevice*::GetRenderTarget. There may be other functions that need to be adjusted to AddRef/Release version specific refcounts.

2 1

Re: netapi32/tests: Fix tests on Win7
by Greg Geldorp 24 Aug '09

24 Aug '09

From: Austin English > On Mon, Aug 24, 2009 at 7:19 AM, Ge van Geldorp<ggeldorp at vmware.com> wrote: > - ok(totalEntries > 0, "at least one transport\n"); > + ok(totalEntries > 0 || broken(totalEntries == 0) /* Win7 */, > > Should probably be win_skip rather than broken, so that a similar > failure on wine isn't ignored. My understanding is that broken() always returns false on Wine, so this shouldn't have any effect on Wine? Ge.

2 1

Re: netapi32/tests: Fix tests on Win7
by Austin English 24 Aug '09

24 Aug '09

On Mon, Aug 24, 2009 at 7:19 AM, Ge van Geldorp<ggeldorp(a)vmware.com> wrote: > Win7 no longer exports NetpGetComputerName() and returns a weird value for > totalEntries in the NetWkstaTransportEnum() call > > Changelog: > netapi32/tests: Fix tests on Win7 > --- > dlls/netapi32/tests/wksta.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) @@ -173,7 +173,8 @@ static void run_wkstatransportenum_tests(void) ok(… [View More]

1 0

Re: kernel32/tests: Remove test that crashes on Win7
by Austin English 24 Aug '09

24 Aug '09

On Mon, Aug 24, 2009 at 7:15 AM, Ge van Geldorp<ggeldorp(a)vmware.com> wrote: > Changelog: > kernel32/tests: Remove test that crashes on Win7 > > --- > dlls/kernel32/tests/console.c | 12 +----------- > 1 files changed, 1 insertions(+), 11 deletions(-) Rather than removing it, should probably #if 0 it out, so that it's still documented and no one tries to add a similar test in the future. -- -Austin

2 1

Easy starter bug: implement extrac32
by Dan Kegel 24 Aug '09

24 Aug '09

http://bugs.winehq.org/show_bug.cgi?id=18097 Sounds pretty easy... somebody already tried to do it, but didn't finish: http://www.winehq.org/pipermail/wine-devel/2007-July/057886.html http://www.winehq.org/pipermail/wine-patches/2007-July/041280.html http://www.winehq.org/pipermail/wine-patches/2007-July/041144.html (That code was from Etersoft; I think they ship it in their version of Wine, but got tired of trying to get it upstream.)

4 4

Behavior of realloc vs. HeapReAlloc
by Paul Chitescu 24 Aug '09

24 Aug '09

Hi! While trying to debug a crash in msi.dll I noticed that the local msi_realloc() is implemented as a (too) thin wrapper around HeapReAlloc() and differs from the expected behavior of realloc() when the old pointer or the new size are zero. The runtime realloc() works like free() if the new size is zero and it works like alloc() if the old pointer is null. HeapReAlloc never allocates or completely frees memory. realloc: http://msdn.microsoft.com/en-us/library/xbebcx7d(VS.80).aspx … [View More]

2 1

Re: [2/4] d3dx9: D3DXAssembleShader and D3DXAssembleShaderFromFile stubs
by Henri Verbeet 24 Aug '09

24 Aug '09

2009/8/21 Matteo Bruni <matteo.mystral(a)gmail.com>: > > +HRESULT WINAPI D3DXAssembleShaderFromFileA(LPCSTR pSrcFile, > + CONST D3DXMACRO* pDefines, > + LPD3DXINCLUDE pInclude, > + DWORD Flags, > + LPD3DXBUFFER* ppShader, > + LPD3DXBUFFER* ppErrorMsgs) > +{ &… [View More]

1 0

Re: [3/4] d3d10: Implement ID3D10Effect::GetVariableByIndex.
by Henri Verbeet 24 Aug '09

24 Aug '09

2009/8/21 Rico Schüller <kgbricola(a)web.de>: > + if( index < This->local_buffer_variable_count ) Please use consistent style. > + for (i = 0; i < This->local_buffer_count; ++i) > + { > + struct d3d10_effect_local_buffer *l = &This->local_buffers[i]; > + unsigned int j; > + > + for (j = 0; j < l->variable_count; ++j) > + { > + struct d3d10_effect_variable *v = &… [View More]

1 0

Re: [2/4] d3d10: Parse local variables.
by Henri Verbeet 24 Aug '09

24 Aug '09

2009/8/21 Rico Schüller <kgbricola(a)web.de>: > --- > dlls/d3d10/d3d10_private.h | 1 + > dlls/d3d10/effect.c | 64 > ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 65 insertions(+), 0 deletions(-) > Are you sure these are incompatible with buffer variables?

1 0

Linking a winelib application with a windows dll
by Thomas Trummer 23 Aug '09

23 Aug '09

Hi, I have a windows dll without source code (vendor.dll) that I want to use in a winelib application. There are two problems however: 1) Creating a vendor.def file doesn't work. The resulting file has an empty EXPORTS section: winedump spec vendor.dll winebuild --def -E vendor.spec -o vendor.def 2) According to an older mailing post it should be possbile to use the .def file to link: winegcc -o test test.o -lvendor However, this fails: /usr/bin/ld: cannot find -lvendor collect2: ld … [View More]

4 5

Re: programs/msiexec: sign compare fixes
by Jacek Caban 23 Aug '09

23 Aug '09

Hi Austin, static BOOL msi_strequal(LPCWSTR str1, LPCSTR str2) { - DWORD len, ret; + WCHAR len, ret; WCHAR doesn't look like a right type here. Although technically it's integer, it's meant for unicode chars. Jacek

1 0

Regressions when running WoW
by F Capela 23 Aug '09

23 Aug '09

I use Wine mostly to play World of Warcraft and I've had a regression in World of Warcraft (when running fullscreen inside a virtual desktop and using the opengl renderer) with patches from the last two weeks: - Patch 12d1ff8ef6c34533a20008f4cfeb73ee4c601a5d (winex11: Add handling of take focus event on the desktop window.) makes the fullscreen WoW inside the virtual desktop window lose focus when the mouse cursor returns to the virtual desktop window; as a consequence, WoW will minimize … [View More]

3 2

Re: [1/2] mshtml: Implement IHTMLDocument2_put/get_bgColor
by Alistair Leslie-Hughes 23 Aug '09

23 Aug '09

Hi Vladimir, On 08/23/2009 05:17 PM, Vladimir Pankratov wrote: >+ hres = IHTMLDocument2_get_body(iface, &elem); You need to Release "elem" when you have finished with it. Best Regards Alistair Leslie-Hughes

1 0

Re: programs/services: sign compare fixes
by Kai Blin 23 Aug '09

23 Aug '09

On Sunday 23 August 2009 10:55:39 Austin English wrote: > -- > -Austin No patch and no attachment. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

profile.c (kernel32): API broken
by Claudio Fontana 22 Aug '09

22 Aug '09

Just a reminder to everyone involved with profile.c: I have watched the git log of the somewhat recent changes to kernel32/profile.c. The profile API does not work that way. The current situation is even worse than before, when the undocumented empty string section and empty keys were not implemented at all. The current situation leads to consistent INI file corruption when the applications use the undocumented empty string section and empty keys. I tried to explain how the API works under … [View More]

2 7

Re: mshtml(2/2): Support getting the proxy settings from the environment
by Jacek Caban 22 Aug '09

22 Aug '09

Hi Juan, Your patch looks good (although I'd suggest splitting set_proxy to two function instead of doing it by gotos), but I've just sent a patch that makes mshtml use wininet for networking (via urlmon), so your patch is no longer needed. My patch is a major step forward in MSHTML/shdocvw implementation, but it's very risky, so I will not immediately remove set_proxy from the tree and wait for things to stabilize, but I don't think we want to extend it. Thanks, Jacek

2 1

AF_Irda.h header file
by Thomas Trummer 22 Aug '09

22 Aug '09

Hi, Wine was missing the AF_Irda.h header file so I decided to write one. Unfortunately someone else had the same idea and the result was commited 3 days ago... :) Nonetheless, I attached my version, it contains all definitons of the Windows SDK 7 header though is not WS_tified. Thomas

2 3

Re: [1/4] d3dx9: Add D3DXAssembleShader and related declarations
by Stefan Dösinger 22 Aug '09

22 Aug '09

Am 21.08.2009 um 23:06 schrieb Matteo Bruni: > I'm trying to follow Juan Lang suggestions on how to structure the D3D > assembler patches. I'm not yet sure on how to proceed with the bulk of > the assembler, however these preparatory patches should be safe. > <0001-d3dx9-Add-D3DXAssembleShader-and-related-declarations.txt> A part of the header seems a bit close to the DX SDK header to me

1 0

Re: CPPCheck Run for Friday August 21
by chris ahrendt 22 Aug '09

22 Aug '09

Mike Kaplinskiy wrote: > On Fri, Aug 21, 2009 at 9:21 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 >> [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a >> deallocated pointer: stream2 >> [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 >> [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 >> [../… [View More]

1 0

CPPCheck Run for Friday August 21
by chris ahrendt 22 Aug '09

22 Aug '09

[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/dlls/… [View More]

2 1

Appinstall strikes again!
by Austin English 22 Aug '09

22 Aug '09

So, I've been on vacation this past week. Before leaving, I ran 'daily ; daily ; daily ; daily ; daily' to make sure they daily build scripts still ran while I was gone. Looking at the logs, I found something interesting: wordviewer03-result.txt:wordview_en-us.exe didn't crash. Bug 19185 TODO_FIXED. wordviewer03-result.txt:C:\users\austin\Application Data\Microsoft\Installer\{90850409-6000-11D3-8CFE-0150048383C9} doesn't exist. Bug 19318 TODO_FIXED. Some TODO_FIXED...investigate! (from http://… [View More]

1 0

Re: oleaut32: Dynamic invocation for x86
by Henri Verbeet 21 Aug '09

21 Aug '09

2009/8/21 Juan Lang <juan.lang(a)gmail.com>: > Personally, I don't think the cut-and-paste approach we've been taking > to fix this works all that well for a 126-argument function, so it > seems like an assembly approach is the only tenable method. I'm not > certain whether Jon's approach is the correct one, but since it didn't > get any comment before, I'd like to know: if it isn't acceptable, why > not? > I don't know if there's a reason the general … [View More]

3 4

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.
by James Mckenzie 21 Aug '09

21 Aug '09

Rico: Which patch is the correct one? Please send it in with (try 3). James McKenzie -----Original Message----- >From: Rico Schüller <kgbricola(a)web.de> >Sent: Aug 21, 2009 9:16 AM >To: wine-patches(a)winehq.org >Subject: Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc. > >Am 21.08.2009 17:46, schrieb Rico Schüller: >> --- >> dlls/d3d10/d3d10_private.h | 3 ++- >> dlls/d3d10/effect.c | 25 ++++++++++++++++++------- &… [View More]

1 0

Re: (try 2) [1/4] d3d10: Partially implement ID3D10Effect::GetDesc.
by Rico Schüller 21 Aug '09

21 Aug '09

Am 21.08.2009 17:46, schrieb Rico Schüller: > --- > dlls/d3d10/d3d10_private.h | 3 ++- > dlls/d3d10/effect.c | 25 ++++++++++++++++++------- > 2 files changed, 20 insertions(+), 8 deletions(-) > > > ------------------------------------------------------------------------ > > > Hi, the previous patch was wrong, take this one instead of the other one. Rico

1 0

Bug for beginners
by Alexandros Dermenakis 21 Aug '09

21 Aug '09

Hi all, I studied the wine developer's guide and went a bit through the code. I would like a suggestion, a bug to start understanding better the structure of wine and familiarize myself with it in order to be able to contribute more in the future. thank you

5 6

Re: Bug for beginners
by James Mckenzie 21 Aug '09

21 Aug '09

>On Fri, Aug 21, 2009 at 12:58 AM, Andrew Eikum ><andrew(a)brightnightgames.com>wrote: > >> Alexandros Dermenakis wrote: >> >>> Hi all, >>> >>> I studied the wine developer's guide and went a bit through the code. I >>> would like a suggestion, a bug to start understanding better the structure >>> of wine and familiarize myself with it in order to be able to contribute >>> more in the future. >>> >>&… [View More]gt; thank you >>> >>> >> Hi Alexandros, >> >> When I began working on Wine, I found that the easiest way for me was to >> implement parts of Wine that have no implementation yet. Implementing new >> functions means you don't have to worry about breaking old tests or >> re-arranging and understanding someone else's code. It also gives you the >> opportunity to write new tests from the ground up, so you get used to >> exactly what the unit tests are for and how they work. >> >> Look around in Wine for functions that are labeled with FIXMEs indicating >> that they are stubs, or look in the .spec files for functions declared as >> stubs. Find a function that has an easy to understand purpose: a very clear >> input and output. Then, write unit tests in that DLL's test suite that >> prove all of the important features of that function. Run your tests on an >> actual Windows OS (look into "crosstests") and verify that they are correct. >> Finally, implement that function in Wine to make it also pass your tests. >> >> If you want a suggestion for where to look for small stubs, take a look at >> gdi32 and gdiplus. I know they still have some smallish, unimplemented or >> half-implemented functions. If graphics don't interest you, there are >> plenty of stubs elsewhere. >> >> Once you've got the hang of how the unit tests work (I mean it, the test >> cases are the most important part of getting patches into Wine), try looking >> into bugs on WineHQ until you find one you think you might be able to >> handle. Then gear up for the most fun you'll ever have reading pages and >> pages debug logs :) >> >> No matter where you begin your work, remember that Wine is a difficult >> project to work on. Because even very subtle changes can cause breakages in >> seemingly unrelated parts of Wine, the standard for patches is very high. >> You will need to prove that your patch is correct using the test suites. >> No provable tests means it's not getting in. >> >> Good luck and thanks for your interest, >> Andrew >> >> >> >As I understand from Wine's policies, functions should only be implemented >if an application requires them. If that's correct, a random search for >stubs isn't a good idea, because the follow up question would be "which >application requires this function?". > One idea is to look at Bugzilla for a problem report that exists because a specific function does not exist. For instance, I have been working on a bug with EM_FORMATRANGE and trying to update the fix included to work with the current Wine version as several programs rely on the ability to change fonts in specific windows. I have a working fix for 0.9.59 and my time was and continues to be diverted to other efforts, not necessarily this fix. However, I would like assistance in moving the patch forward and into Wine. There are other bug reports where the fix is 'hacky' and needs to be cleaned up so, in many cases a conformance/compliance test is all that is needed. This would be a great place to start where you can look at the current Wine code base, what someone came up with as a fix and what needs to make the fix workable. You don't have to look for an application that requires a certain function that works in a specific manner. James McKenzie [View Less]

1 0

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]
by Alexandre Julliard 21 Aug '09

21 Aug '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1711,32 +1713,35 @@ > } > else > { > - /* If the executable name is not quoted, we have to use this search loop here, > + /* FIXME: what versions support this? Fails on 2000/XP > + If the executable name is not quoted, we have to use this search loop here, > that in CreateProcess() is not sufficient because it does not handle shell links. */ > WCHAR … [View More]

2 3

Re: mshtml: Implement IHTMLStyle get/put wordSpacing
by Jacek Caban 21 Aug '09

21 Aug '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mshtml: Implement IHTMLStyle get/put wordSpacing static HRESULT WINAPI HTMLStyle_put_wordSpacing(IHTMLStyle *iface, VARIANT v) { - HTMLStyle *This = HTMLSTYLE_THIS(iface); - FIXME("(%p)->(v%d)\n", This, V_VT(&v)); - return E_NOTIMPL; + HTMLStyle *This = HTMLSTYLE_THIS(iface); + TRACE("(%p)->(v%d)\n", This, V_VT(&v)); + return set_nsstyle_attr_var(This->nsstyle, … [View More]

1 0

Re: kernel32: test GetPrivateProfileString with empty string as key and section
by Michael Stefaniuc 21 Aug '09

21 Aug '09

Hello Stefan, Stefan Leichter wrote: > Problem spotted from Claudio Fontana on wine-devel > > tested on Win2K > diff -ruw wine-git/dlls/kernel32/tests/profile.c wine-build/dlls/kernel32/tests/profile.c > --- wine-git/dlls/kernel32/tests/profile.c 2009-06-04 19:00:09.000000000 +0200 > +++ wine-build/dlls/kernel32/tests/profile.c 2009-08-16 23:03:37.000000000 +0200 > @@ -41,6 +41,13 @@ > UINT result9x; > }; > > +static const char *debugstr_w(LPCWSTR str) … [View More]

1 0

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt
by Alexandre Julliard 20 Aug '09

20 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > TRACE("socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n", > s, level, optname, optval, *optlen); > > + /* Some apps sign-extend the level, so mask off the higher-order bits */ > + level &= 0x0000ffff; There can be several other ways to handle this, it needs test cases to determine which way Windows is using. -- Alexandre Julliard julliard(a)winehq.org

3 5

re: old patch enabling visible icons in some applications
by Dan Kegel 20 Aug '09

20 Aug '09

trueflyingsheep wrote: > why didn't it make it into the release? Probably because there was an unsettled question: http://www.winehq.org/pipermail/wine-patches/2008-June/055490.html Please open a bug for this issue (if there isn't already one) and give a few names there for affected apps, as well as a link to the original patch, so we don't lose track of it. Thanks! - Dan

6 7

Re: [PATCH 02/12] windowscodecs: Add IWICStream_InitializeFromMemory implementation [try 2]
by Alexandre Julliard 20 Aug '09

20 Aug '09

Tony Wasserka <tony.wasserka(a)freenet.de> writes: > + * > + * Used by IWICStream_InitializeFromMemory > + * This interface is windowscodecs private only which > + * is why we don't need to implement QueryInterface and AddRef Don't do that, implement it properly even if that code is not used at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.
by Alexandre Julliard 20 Aug '09

20 Aug '09

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -84,6 +83,13 @@ static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode *iface ) > return (xmlnode *)((char*)iface - FIELD_OFFSET(xmlnode, lpVtbl)); > } > > +static inline IXMLDOMNode *_IXMLDOMNode_(xmlnode *This) > +{ > + return (IXMLDOMNode*)&This->lpVtbl; > +} That wrapper doesn't follow any established naming convention, and doesn't seem quite necessary. The standard way is to simply cast … [View More]

2 3

GSoC - Wine/Gstreamer
by Trevor Davenport 20 Aug '09

20 Aug '09

Hi, I wanted to send a mail to the list and basically state what the status of all this is and what my plans are for the future. For those unfamiliar with what i was doing, I was trying to enable using gstreamer elements as directshow filter to expand the quartz functionality available. At the start of the program I was not very familiar with quartz so it took a fair amount of learning to get up to speed with it. The basic ability to use a gstreamer element is mostly there. More work is … [View More]needed to finish up a few aspects of it though. The source commited to my github repo does expose one working element if you have the gstreamer mp3 plugin installed. A little bit more work is needed to map more formats so that more elements can be exposed. I had hoped to do this before the program deadline but it just ended up not being possible. But i plan to keep working on this. I'd like to see it commited if possible. My plans are essentially the following: * expand the format mapping so most audio elements (ones that operate on one input and one output) can be exposed * add to the quartz filter registry * clean up anything I can find (i am sure there is a leak or two, etc) * finish build setup - configure option and library finding issue (seems to pickup 64bit version on 64bit system...which won't work...) * start patch review More long term I want to start more general quartz work. Implementing some of the currently unimplemented features such as dynamic pin reconnection would help. I want to do this as well as start cleaning up a few areas I found while trying to find what was happening. I also want to continue working on this to allow more elements, specifically the demuxers from gstreamer which should be able to the take the place of avisplitter and mpegsplitter but have more features. I didn't get as far as i had wanted to due to how much I had to learn about directshow and time was constantly a issue. Nothing really uses the new filter currently expect my little test mp3 player, which is also available in the github repo (just search for tdaven, both the wine and the test programs are in my personal repo). It seems the quartz dsound element sometimes (i've had it often) does not mix well when using alsa as the audio driver over pulseaudio. If it sounds extremely slow this is the cause. I've not tracked down exactly what is going on in this case, but using raw alsa or something else has never demonstrated the issue. Took me a good while to find this was the cause though. If there are any questions I'd be glad to answer whatever. Cheers, Trevor Davenport [View Less]

1 0

Re: winemp3.acm: link to system libmpg123.so
by Alex Villacís Lasso 20 Aug '09

20 Aug '09

7 12

Re: [2/2] msxml3: Add IDispatchEx support to IXMLDOMElement
by Jacek Caban 20 Aug '09

20 Aug '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IDispatchEx support to IXMLDOMElement > + else if( IsEqualGUID( riid, &IID_IDispatch ) || + IsEqualGUID( riid, &IID_IDispatchEx ) ) + { + xmlnode *node = impl_from_IXMLDOMNode( This->node ); + + dispex_query_interface(&node->dispex, riid, ppvObject); + + return *ppvObject ? S_OK : E_NOINTERFACE; + } This should be handled by node's … [View More]

1 0

Re: wined3d: have SetAutoGenFilterType call glHint
by Henri Verbeet 20 Aug '09

20 Aug '09

2009/8/20 <Joerg-Cyril.Hoehle(a)t-systems.com>: > Hi, > > This fixes bug #11167. It depends on my previous patch. > > One unclear issue about glHint() is the scope. > What textures does it affect? When? > > An alternative would be, as Stefan Dösinger puts it: "just check if > the app ever sets two contradicting filter types" but I don't know how > "global" the effect of glHint() is (per UNIX process, per .exe, > per GL context, per active texture, per ...)… [View More]

1 0

Request for test on at least one Windows box
by Juan Lang 19 Aug '09

19 Aug '09

Hi all, could someone with the ability to build and run a test on Windows run the attached test for me? I have a fix for bug 19760, but I'd just like to double check that it's correct before sending it in (and I don't have access to Windows at the moment.) Please copy the list on the reply so not too many people end up doing it. Cheers, --Juan

2 2

Wine Development Stats
by André Hentschel 19 Aug '09

19 Aug '09

Hi, inspired by "Linux Kernel Development: How Fast it is Going, Who is Doing It, What They are Doing, and Who is Sponsoring It: An August 2009 Update" (http://www.linuxfoundation.org/publications/whowriteslinux.pdf), i thought we might do a similar analyse of the wine tree. I attach a first overview made with gitdm, the tool they used, too. Is there some interest to do a similar PDF? -- Best Regards, André Hentschel

2 1

Re: ole32: On big endian machines, copy strings to little endian order without mucking with the map they're stored in (try 2)
by Alexandre Julliard 19 Aug '09

19 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > +#ifdef WORDS_BIGENDIAN > +/* Returns a byte-swapped copy of str, to be freed with HeapFree(). */ > +static LPWSTR PropertyStorage_StringToLE(LPCWSTR str, size_t len) > +{ > + LPWSTR leStr = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + > + if (leStr) > + { > + memcpy(leStr, str, len * sizeof(WCHAR)); > + PropertyStorage_ByteSwapString(leStr, len); > + } > + return … [View More]

2 2

GSoC 2009 Final evaluations due
by Kai Blin 19 Aug '09

19 Aug '09

Hi folks, GSoC 2009 is wrapping up and the final evaluations are due. So far only one student and no mentors have filled out the surveys, so please take your time and take care of that soon. The results are due on Monday, but I'd prefer if I had some room to deal with any issues coming up, so please try to get the surveys in as soon as possible. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team … [View More]

1 0

Re: [1/3] WineD3D: Use a sane default refresh rate
by Henri Verbeet 19 Aug '09

19 Aug '09

2009/8/19 Stefan Dösinger <stefan(a)codeweavers.com>: > and its value(=0) is not sane MSDN seems to disagree. "The value of 0 indicates an adapter default."

2 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel