- wine-devel - winehq.org

Re: Bug for beginners
by James Mckenzie 21 Aug '09

21 Aug '09

>On Fri, Aug 21, 2009 at 12:58 AM, Andrew Eikum ><andrew(a)brightnightgames.com>wrote: > >> Alexandros Dermenakis wrote: >> >>> Hi all, >>> >>> I studied the wine developer's guide and went a bit through the code. I >>> would like a suggestion, a bug to start understanding better the structure >>> of wine and familiarize myself with it in order to be able to contribute >>> more in the future. >>> >>> thank you >>> >>> >> Hi Alexandros, >> >> When I began working on Wine, I found that the easiest way for me was to >> implement parts of Wine that have no implementation yet. Implementing new >> functions means you don't have to worry about breaking old tests or >> re-arranging and understanding someone else's code. It also gives you the >> opportunity to write new tests from the ground up, so you get used to >> exactly what the unit tests are for and how they work. >> >> Look around in Wine for functions that are labeled with FIXMEs indicating >> that they are stubs, or look in the .spec files for functions declared as >> stubs. Find a function that has an easy to understand purpose: a very clear >> input and output. Then, write unit tests in that DLL's test suite that >> prove all of the important features of that function. Run your tests on an >> actual Windows OS (look into "crosstests") and verify that they are correct. >> Finally, implement that function in Wine to make it also pass your tests. >> >> If you want a suggestion for where to look for small stubs, take a look at >> gdi32 and gdiplus. I know they still have some smallish, unimplemented or >> half-implemented functions. If graphics don't interest you, there are >> plenty of stubs elsewhere. >> >> Once you've got the hang of how the unit tests work (I mean it, the test >> cases are the most important part of getting patches into Wine), try looking >> into bugs on WineHQ until you find one you think you might be able to >> handle. Then gear up for the most fun you'll ever have reading pages and >> pages debug logs :) >> >> No matter where you begin your work, remember that Wine is a difficult >> project to work on. Because even very subtle changes can cause breakages in >> seemingly unrelated parts of Wine, the standard for patches is very high. >> You will need to prove that your patch is correct using the test suites. >> No provable tests means it's not getting in. >> >> Good luck and thanks for your interest, >> Andrew >> >> >> >As I understand from Wine's policies, functions should only be implemented >if an application requires them. If that's correct, a random search for >stubs isn't a good idea, because the follow up question would be "which >application requires this function?". > One idea is to look at Bugzilla for a problem report that exists because a specific function does not exist. For instance, I have been working on a bug with EM_FORMATRANGE and trying to update the fix included to work with the current Wine version as several programs rely on the ability to change fonts in specific windows. I have a working fix for 0.9.59 and my time was and continues to be diverted to other efforts, not necessarily this fix. However, I would like assistance in moving the patch forward and into Wine. There are other bug reports where the fix is 'hacky' and needs to be cleaned up so, in many cases a conformance/compliance test is all that is needed. This would be a great place to start where you can look at the current Wine code base, what someone came up with as a fix and what needs to make the fix workable. You don't have to look for an application that requires a certain function that works in a specific manner. James McKenzie

1 0

Re: (resend) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [3rd]
by Alexandre Julliard 21 Aug '09

21 Aug '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1711,32 +1713,35 @@ > } > else > { > - /* If the executable name is not quoted, we have to use this search loop here, > + /* FIXME: what versions support this? Fails on 2000/XP > + If the executable name is not quoted, we have to use this search loop here, > that in CreateProcess() is not sufficient because it does not handle shell links. */ > WCHAR buffer[MAX_PATH], xlpFile[MAX_PATH]; > - LPWSTR space, s; > + LPWSTR space; > > - LPWSTR beg = wszApplicationName/*sei_tmp.lpFile*/; > - for(s=beg; (space=strchrW(s, ' ')); s=space+1) { > - int idx = space-sei_tmp.lpFile; > - memcpy(buffer, sei_tmp.lpFile, idx * sizeof(WCHAR)); > + lstrcpynW(buffer, wszApplicationName, sizeof(buffer)/sizeof(WCHAR)); > + space = buffer + strlenW(buffer); > + do Searching from the end doesn't look right. This would need a test case. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: mshtml: Implement IHTMLStyle get/put wordSpacing
by Jacek Caban 21 Aug '09

21 Aug '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > mshtml: Implement IHTMLStyle get/put wordSpacing static HRESULT WINAPI HTMLStyle_put_wordSpacing(IHTMLStyle *iface, VARIANT v) { - HTMLStyle *This = HTMLSTYLE_THIS(iface); - FIXME("(%p)->(v%d)\n", This, V_VT(&v)); - return E_NOTIMPL; + HTMLStyle *This = HTMLSTYLE_THIS(iface); + TRACE("(%p)->(v%d)\n", This, V_VT(&v)); + return set_nsstyle_attr_var(This->nsstyle, STYLEID_WORD_SPACING, &v, 0); The indention here is wrong. + hres = IHTMLStyle_get_wordSpacing(style, &v); + ok(hres == S_OK, "get_wordSpacing: %08x\n", hres); + ok(!strcmp_wa(V_BSTR(&v), "10px"), "expected 10px = %s\n", wine_dbgstr_w(V_BSTR(&v))); + VariantClear(&v); Please add a test for V_VT(&v) == VT_BSTR. Jacek

1 0

Re: kernel32: test GetPrivateProfileString with empty string as key and section
by Michael Stefaniuc 21 Aug '09

21 Aug '09

Hello Stefan, Stefan Leichter wrote: > Problem spotted from Claudio Fontana on wine-devel > > tested on Win2K > diff -ruw wine-git/dlls/kernel32/tests/profile.c wine-build/dlls/kernel32/tests/profile.c > --- wine-git/dlls/kernel32/tests/profile.c 2009-06-04 19:00:09.000000000 +0200 > +++ wine-build/dlls/kernel32/tests/profile.c 2009-08-16 23:03:37.000000000 +0200 > @@ -41,6 +41,13 @@ > UINT result9x; > }; > > +static const char *debugstr_w(LPCWSTR str) you don't need to add a local debugstr_w implementation anymore. Alexandre added wine_dbgstr_w() to test.h two days ago with commit ee868cce5b412b103ff167deb59c3d5237363199. > +{ > + static char buf[1024]; > + WideCharToMultiByte(CP_ACP, 0, str, -1, buf, sizeof(buf), NULL, NULL); > + return buf; > +} > + > static void test_profile_int(void) > { > struct _profileInt profileInt[]={ bye michael

1 0

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt
by Alexandre Julliard 20 Aug '09

20 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > TRACE("socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n", > s, level, optname, optval, *optlen); > > + /* Some apps sign-extend the level, so mask off the higher-order bits */ > + level &= 0x0000ffff; There can be several other ways to handle this, it needs test cases to determine which way Windows is using. -- Alexandre Julliard julliard(a)winehq.org

3 5

re: old patch enabling visible icons in some applications
by Dan Kegel 20 Aug '09

20 Aug '09

trueflyingsheep wrote: > why didn't it make it into the release? Probably because there was an unsettled question: http://www.winehq.org/pipermail/wine-patches/2008-June/055490.html Please open a bug for this issue (if there isn't already one) and give a few names there for affected apps, as well as a link to the original patch, so we don't lose track of it. Thanks! - Dan

6 7

Re: [PATCH 02/12] windowscodecs: Add IWICStream_InitializeFromMemory implementation [try 2]
by Alexandre Julliard 20 Aug '09

20 Aug '09

Tony Wasserka <tony.wasserka(a)freenet.de> writes: > + * > + * Used by IWICStream_InitializeFromMemory > + * This interface is windowscodecs private only which > + * is why we don't need to implement QueryInterface and AddRef Don't do that, implement it properly even if that code is not used at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] msxml3: Return xmlnode object from create_basic_node.
by Alexandre Julliard 20 Aug '09

20 Aug '09

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -84,6 +83,13 @@ static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode *iface ) > return (xmlnode *)((char*)iface - FIELD_OFFSET(xmlnode, lpVtbl)); > } > > +static inline IXMLDOMNode *_IXMLDOMNode_(xmlnode *This) > +{ > + return (IXMLDOMNode*)&This->lpVtbl; > +} That wrapper doesn't follow any established naming convention, and doesn't seem quite necessary. The standard way is to simply cast to the interface type. If you really want a wrapper it should be called something like IXMLDOMNode_from_impl. -- Alexandre Julliard julliard(a)winehq.org

2 3

GSoC - Wine/Gstreamer
by Trevor Davenport 20 Aug '09

20 Aug '09

Hi, I wanted to send a mail to the list and basically state what the status of all this is and what my plans are for the future. For those unfamiliar with what i was doing, I was trying to enable using gstreamer elements as directshow filter to expand the quartz functionality available. At the start of the program I was not very familiar with quartz so it took a fair amount of learning to get up to speed with it. The basic ability to use a gstreamer element is mostly there. More work is needed to finish up a few aspects of it though. The source commited to my github repo does expose one working element if you have the gstreamer mp3 plugin installed. A little bit more work is needed to map more formats so that more elements can be exposed. I had hoped to do this before the program deadline but it just ended up not being possible. But i plan to keep working on this. I'd like to see it commited if possible. My plans are essentially the following: * expand the format mapping so most audio elements (ones that operate on one input and one output) can be exposed * add to the quartz filter registry * clean up anything I can find (i am sure there is a leak or two, etc) * finish build setup - configure option and library finding issue (seems to pickup 64bit version on 64bit system...which won't work...) * start patch review More long term I want to start more general quartz work. Implementing some of the currently unimplemented features such as dynamic pin reconnection would help. I want to do this as well as start cleaning up a few areas I found while trying to find what was happening. I also want to continue working on this to allow more elements, specifically the demuxers from gstreamer which should be able to the take the place of avisplitter and mpegsplitter but have more features. I didn't get as far as i had wanted to due to how much I had to learn about directshow and time was constantly a issue. Nothing really uses the new filter currently expect my little test mp3 player, which is also available in the github repo (just search for tdaven, both the wine and the test programs are in my personal repo). It seems the quartz dsound element sometimes (i've had it often) does not mix well when using alsa as the audio driver over pulseaudio. If it sounds extremely slow this is the cause. I've not tracked down exactly what is going on in this case, but using raw alsa or something else has never demonstrated the issue. Took me a good while to find this was the cause though. If there are any questions I'd be glad to answer whatever. Cheers, Trevor Davenport

1 0

Re: winemp3.acm: link to system libmpg123.so
by Alex Villacís Lasso 20 Aug '09

20 Aug '09

Aric Stewart escribió: > --- > configure.ac | 12 + > dlls/winemp3.acm/Makefile.in | 11 +- > dlls/winemp3.acm/common.c | 261 ------- > dlls/winemp3.acm/dct64_i386.c | 329 -------- > dlls/winemp3.acm/decode_i386.c | 164 ---- > dlls/winemp3.acm/huffman.h | 346 --------- > dlls/winemp3.acm/interface.c | 254 ------- > dlls/winemp3.acm/l2tables.h | 175 ----- > dlls/winemp3.acm/layer1.c | 159 ---- > dlls/winemp3.acm/layer2.c | 301 -------- > dlls/winemp3.acm/layer3.c | 1613 > ---------------------------------------- > dlls/winemp3.acm/mpegl3.c | 119 ++-- > dlls/winemp3.acm/mpg123.h | 166 ---- > dlls/winemp3.acm/mpglib.h | 69 -- > dlls/winemp3.acm/tabinit.c | 95 --- > 15 files changed, 81 insertions(+), 3993 deletions(-) > delete mode 100644 dlls/winemp3.acm/common.c > delete mode 100644 dlls/winemp3.acm/dct64_i386.c > delete mode 100644 dlls/winemp3.acm/decode_i386.c > delete mode 100644 dlls/winemp3.acm/huffman.h > delete mode 100644 dlls/winemp3.acm/interface.c > delete mode 100644 dlls/winemp3.acm/l2tables.h > delete mode 100644 dlls/winemp3.acm/layer1.c > delete mode 100644 dlls/winemp3.acm/layer2.c > delete mode 100644 dlls/winemp3.acm/layer3.c > delete mode 100644 dlls/winemp3.acm/mpg123.h > delete mode 100644 dlls/winemp3.acm/mpglib.h > delete mode 100644 dlls/winemp3.acm/tabinit.c > > > ------------------------------------------------------------------------ > > The libmpg123 library is not shipped in any rpmfusion repository for Fedora 10, and possibly for other distros. This means anyone who wants mp3 support would need to install libmpg123 from source. However, rpmfusion for Fedora 10 has libmad, lame and twolame. -- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

7 12

Re: [2/2] msxml3: Add IDispatchEx support to IXMLDOMElement
by Jacek Caban 20 Aug '09

20 Aug '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IDispatchEx support to IXMLDOMElement > + else if( IsEqualGUID( riid, &IID_IDispatch ) || + IsEqualGUID( riid, &IID_IDispatchEx ) ) + { + xmlnode *node = impl_from_IXMLDOMNode( This->node ); + + dispex_query_interface(&node->dispex, riid, ppvObject); + + return *ppvObject ? S_OK : E_NOINTERFACE; + } This should be handled by node's QueryInterface implementation. + + xmlnode = impl_from_IXMLDOMNode( This->node ); It's not about your code as you follow msxml3 design, but this is ugly and it shouldn't be needed. + init_dispex(&xmlnode->dispex, (IUnknown*)&This->lpVtbl, &domelem_dispex); init_dispex is first called in create_basic_node, so you initialize it second time here. IMO msxml3 object inheritance needs serious design changes and it would be better to do it before adding IDispatchEx support for node implementations. I will send a few first patches. Thanks, Jacek

1 0

Re: wined3d: have SetAutoGenFilterType call glHint
by Henri Verbeet 20 Aug '09

20 Aug '09

2009/8/20 <Joerg-Cyril.Hoehle(a)t-systems.com>: > Hi, > > This fixes bug #11167. It depends on my previous patch. > > One unclear issue about glHint() is the scope. > What textures does it affect? When? > > An alternative would be, as Stefan Dösinger puts it: "just check if > the app ever sets two contradicting filter types" but I don't know how > "global" the effect of glHint() is (per UNIX process, per .exe, > per GL context, per active texture, per ...)? > > Another alternative would be to replace SetAutoGen with just a FIXME > to at least get rid of the bogus >>>>>> glTexParameter call. > This isn't quite correct. The hint indeed applies to the entire context, and you should map the linear filter to GL_NICEST. We should probably generate mipmaps explicitly with glGenerateMipmapEXT() if the FBO extension is available.

1 0

Request for test on at least one Windows box
by Juan Lang 19 Aug '09

19 Aug '09

Hi all, could someone with the ability to build and run a test on Windows run the attached test for me? I have a fix for bug 19760, but I'd just like to double check that it's correct before sending it in (and I don't have access to Windows at the moment.) Please copy the list on the reply so not too many people end up doing it. Cheers, --Juan

2 2

Wine Development Stats
by André Hentschel 19 Aug '09

19 Aug '09

Hi, inspired by "Linux Kernel Development: How Fast it is Going, Who is Doing It, What They are Doing, and Who is Sponsoring It: An August 2009 Update" (http://www.linuxfoundation.org/publications/whowriteslinux.pdf), i thought we might do a similar analyse of the wine tree. I attach a first overview made with gitdm, the tool they used, too. Is there some interest to do a similar PDF? -- Best Regards, André Hentschel

2 1

Re: ole32: On big endian machines, copy strings to little endian order without mucking with the map they're stored in (try 2)
by Alexandre Julliard 19 Aug '09

19 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > +#ifdef WORDS_BIGENDIAN > +/* Returns a byte-swapped copy of str, to be freed with HeapFree(). */ > +static LPWSTR PropertyStorage_StringToLE(LPCWSTR str, size_t len) > +{ > + LPWSTR leStr = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + > + if (leStr) > + { > + memcpy(leStr, str, len * sizeof(WCHAR)); > + PropertyStorage_ByteSwapString(leStr, len); > + } > + return leStr; > +} > +#else > +#define PropertyStorage_StringToLE(s, l) (LPWSTR)(s) > +#endif You are still casting away const... -- Alexandre Julliard julliard(a)winehq.org

2 2

GSoC 2009 Final evaluations due
by Kai Blin 19 Aug '09

19 Aug '09

Hi folks, GSoC 2009 is wrapping up and the final evaluations are due. So far only one student and no mentors have filled out the surveys, so please take your time and take care of that soon. The results are due on Monday, but I'd prefer if I had some room to deal with any issues coming up, so please try to get the surveys in as soon as possible. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [1/3] WineD3D: Use a sane default refresh rate
by Henri Verbeet 19 Aug '09

19 Aug '09

2009/8/19 Stefan Dösinger <stefan(a)codeweavers.com>: > and its value(=0) is not sane MSDN seems to disagree. "The value of 0 indicates an adapter default."

2 4

Re: winelib include problem
by Maarten Lankhorst 19 Aug '09

19 Aug '09

Hi Jesse, Jesse Allen schreef: > Maartan, > > In a patch committed on 10 Jul 2008, includes: Add video mixing > renderer header, it included a construct that autogenerates this piece > of code for strmif.h > > " > typedef struct tagVMRGUID { > GUID *pGUID; > GUID GUID; > } VMRGUID; > " > > Unfortunately any C++ file that includes that header seems to miscompile. > > " > #include <strmif.h> > " > > produces with wineg++ > > In file included from blarg.c:1: > /home/jesse/build/wine/include/strmif.h:8972: error: declaration of > 'GUID tagVMRGUID::GUID' > /home/jesse/build/wine/include/guiddef.h:31: error: changes meaning of > 'GUID' from 'typedef struct _GUID GUID' > winegcc: g++ failed > > > This is also a problem in the DXSDK when compiling with g++, I > suppose. This is explained here: > http://home.clara.net/raoulgough/vidmodem/dshow.html > > I tried patching the vmrender.idl similar to this: > " > typedef struct tagVMRGUID > { > #if defined(__cplusplus) > GUID *pGUID, ::GUID; > #else > GUID *pGUID, GUID; > #endif > } VMRGUID; > " > Judging by that link you sent me, shouldn't it be: typedef struct tagVMRGUID { #if defined(__cplusplus) ::GUID *pGUID, GUID; #else GUID *pGUID, GUID; #endif } VMRGUID; Or am i reading that link wrong? > But no go. It still produces the same problem. Obviously you can't > have the ::GUID prefixed and work on gcc as much as you can have the > GUID GUID in g++. But I think we will need it, otherwise I will just > have to hack the strmif.h everytime. > > Can you take a look at the problem? I think we will want this to work > for winelib on g++ as it's pretty well dependent. > Main problem is of course the msvc compiler doesn't have that problem, but if that ifdef works perhaps it's possible to have it like that. Cheers, Maarten.

2 3

Re: [PATCH 5/5] wined3d: Hide WINED3DFMT_R16G16B16A16_UNORM again.
by Stefan Dösinger 19 Aug '09

19 Aug '09

Am Wednesday 19 August 2009 10:55:39 schrieb Henri Verbeet: > This format is broken on some cards. Hide it until we figure out a reliable > way to deal with it. Didn't you consider breaking something the best way to get the driver fixed? :-) Fwiw, I reported this to linux-bugs(a)nvidia.com, together with a testcase. No reply yet. Feel free to disable it if there are too many issues though, but maybe add a comment why it is disabled.

1 0

Re: (resend, 2nd) shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces [2nd]
by Alexandre Julliard 19 Aug '09

19 Aug '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1711,28 +1713,29 @@ > } > else > { > - /* If the executable name is not quoted, we have to use this search loop here, > + /* FIXME: what versions support this? Fails on 2000/XP > + If the executable name is not quoted, we have to use this search loop here, > that in CreateProcess() is not sufficient because it does not handle shell links. */ > WCHAR buffer[MAX_PATH], xlpFile[MAX_PATH]; > - LPWSTR space, s; > + LPWSTR space; > > - LPWSTR beg = wszApplicationName/*sei_tmp.lpFile*/; > - for(s=beg; (space=strchrW(s, ' ')); s=space+1) { > - int idx = space-sei_tmp.lpFile; > - memcpy(buffer, sei_tmp.lpFile, idx * sizeof(WCHAR)); > + lstrcpynW(buffer, wszApplicationName, sizeof(buffer)/sizeof(WCHAR)); > + while((space=strchrW(buffer, ' '))) > + { > + int idx = space-buffer; > buffer[idx] = '\0'; This will break the loop since you don't reset the buffer contents. Also the indentation is messed up, please fix your editor setup. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/18] d3dx9: Add shader assembler private definitions
by Vincent Povirk 18 Aug '09

18 Aug '09

Don't send patches that only add unused code. On Sun, Aug 16, 2009 at 12:50 PM, Matteo Bruni<matteo.mystral(a)gmail.com> wrote: > This is a long patch series that implements the D3D shader assembler > and D3DXAssembleShader function. The first part has already passed a > couple of rounds of review in wine-devel. > > > > -- Vincent Povirk

4 6

Re: [PATCH 1/3] tools/widl: A structure containing a BOGUS_ARRAY should be a BOGUS_STRUCT.
by Alexandre Julliard 18 Aug '09

18 Aug '09

Huw Davies <huw(a)codeweavers.com> writes: > @@ -280,9 +282,10 @@ unsigned char get_struct_fc(const type_t *type) > if (get_enum_fc(t) == RPC_FC_ENUM16) > return RPC_FC_BOGUS_STRUCT; > break; > - case TGT_POINTER: > case TGT_ARRAY: > - if (get_pointer_fc(t, field->attrs, FALSE) == RPC_FC_RP || pointer_size != 4) > + if(get_array_fc(t) == RPC_FC_BOGUS_ARRAY) return RPC_FC_BOGUS_STRUCT; > + case TGT_POINTER: > + if(get_pointer_fc(t, field->attrs, FALSE) == RPC_FC_RP || pointer_size != 4) This doesn't seem to match the midl behavior. For instance in the server.idl test puints_t becomes a bogus struct, but it's a simple struct with midl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: SetEntriesInAclW() should accept account name "CURRENT_USER".
by Rob Shearman 18 Aug '09

18 Aug '09

2009/8/16 Rein Klazes <wijn(a)online.nl>: > @@ -3510,7 +3511,8 @@ DWORD WINAPI SetEntriesInAclW( ULONG count, PEXPLICIT_ACCESSW pEntries, > DWORD sid_size = FIELD_OFFSET(SID, SubAuthority[SID_MAX_SUB_AUTHORITIES]); > DWORD domain_size = MAX_COMPUTERNAME_LENGTH + 1; > SID_NAME_USE use; > - if (!LookupAccountNameW(NULL, pEntries[i].Trustee.ptstrName, ppsid[i], &sid_size, NULL, &domain_size, &use)) > + if ( strcmpW( pEntries[i].Trustee.ptstrName, CURRENT_USER ) && What will the memory pointed to by ppsid[i] be set to in this case? Hint: whatever the memory was last used for, not the SID of the current user which is what is desired. > + !LookupAccountNameW(NULL, pEntries[i].Trustee.ptstrName, ppsid[i], &sid_size, NULL, &domain_size, &use)) > { > WARN("bad user name %s for trustee %d\n", debugstr_w(pEntries[i].Trustee.ptstrName), i); > ret = ERROR_INVALID_PARAMETER; -- Rob Shearman

1 0

Re: msxml3: Support loading windows file path under wine (try 2 - Resend)
by Alexandre Julliard 18 Aug '09

18 Aug '09

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Stopped converting the filename to Unicode. Obviously you still need to convert for opening it. -- Alexandre Julliard julliard(a)winehq.org

1 0

mp3 update
by Aric Stewart 18 Aug '09

18 Aug '09

Hello all, I am working on updating our winemp3.acm implementation to a modern libmpg123. We where at about 0.59r and I have 1.8.1 working very well. I have a few questions. Right now I have the smallest subset of files from libmpg123 that are needed to compile and work in the wine framework (mostly) unmodified. I have replaced all the malloc/free calls with HeapAlloc/HeapFree and worked in all the wine debugging code instead of the libmpg123 debugging code. What I am wondering about is that there is still a lot of code in these files we have no interest in. The file reader and http reader and other things that we do not use (it is accessed just by the direct stream methods) and those things dependencies. Should I leave all this code present in our version of the modules and mostly preserve the libmpg123 work to make it easier to keep updating forward? Or should i remove all the unneeded code so that the modules present in winehq are leaner and more targeted to just the things the wine needs, but then they deviate much more from the original libmpg123 source? With what I have now the mp3 source material this game i am testing is using sounds much much better. So it should be a great improvement. Thanks, -aric

11 27

add new application attrib.exe
by EA Durbin 18 Aug '09

18 Aug '09

This fixes bug 18059. If this one is not acceptable, feel free to take it and clean it up, I am abandoning this effort from here forward. _________________________________________________________________ Windows Live: Keep your friends up to date with what you do online. http://windowslive.com/Campaign/SocialNetworking?ocid=PID23285::T:WLMTAGL:O…

1 0

Re: [7/10] windowscodecs: implement CopyPixels for GIF decoder (resend 2)
by Vincent Povirk 17 Aug '09

17 Aug '09

Wait, no, this one's wrong too. Don't commit it. It's correct for odd heights but not even heights. To calculate the number of rows divisible by N, I have to divide the 0-based index of the maximum row by N and add 1 (for the ever-present row 0). However, I divided the height, which is maximum row+1. To do this correctly, I would have to do (height-1)/N+1 or the equivalent (height+(N-1))/N. I'll fix it tomorow. On Mon, Aug 17, 2009 at 3:49 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > This time with correct interlacing code in the patch that is attached. > > > > -- Vincent Povirk

1 0

Re: gdiplus: Implement GdipIsVisibleRect
by Andrew Eikum 17 Aug '09

17 Aug '09

Andrew Eikum wrote: > --- > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/graphics.c | 47 +++++++++-- > dlls/gdiplus/tests/graphics.c | 180 > +++++++++++++++++++++++++++++++++++++++++ > include/gdiplusflat.h | 2 + > 4 files changed, 221 insertions(+), 10 deletions(-) > > > > ------------------------------------------------------------------------ > > Don't apply. I just found out these should call GdipIsVisibleRegion*. Will fix shortly.

1 0

Re: [7/10] windowscodecs: implement CopyPixels for GIF decoder (resend)
by Reece Dunn 17 Aug '09

17 Aug '09

2009/8/17 Vincent Povirk <vincent(a)codeweavers.com>: > This time with correct interlacing code. Patch?

1 0

Re: [13/18] wpp: Add wpp_set_exit_on_error function
by Juan Lang 17 Aug '09

17 Aug '09

Hi Matteo, this approach seems pretty inflexible to me: +/* Whether to exit the app on errors (default: true) */ +extern void wpp_set_exit_on_error( int exit ); @@ -646,7 +654,8 @@ int ppy_error(const char *s, ...) va_start(ap, s); generic_msg(s, "Error", ppy_text, ap); va_end(ap); - exit(1); + if(pp_status.exit_on_error) exit(1); + else pp_status.state = 1; return 1; } It seems as though you might instead have a global error function that should be called, which defaults to exit(). In fact, that's what ppy_error seems to be. So I think you'd want to make ppy_error into a function pointer, and make the current definition its default value, or something like that. I can't imagine that retaining the output to stderr is all that useful in the context of the D3D9 shader assembler. You could further split this patch: this is half of it, setting and dealing with the exit_on_error flag. The other half deals with the current assumption that ppy_error never returns. You can make removing that assumption one patch, and this--changing the error function to something else--a subsequent patch. --Juan

2 1

Re: [7/10] windowscodecs: implement CopyPixels for GIF decoder
by Vincent Povirk 17 Aug '09

17 Aug '09

Don't commit this. I screwed up the interlacing. On Mon, Aug 17, 2009 at 2:01 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > > > > > > -- Vincent Povirk

1 0

Re: mshtml: Implement OmNavigator_get_appName
by Jacek Caban 17 Aug '09

17 Aug '09

Hi Vladimir, Vladimir Pankratov wrote: > Hello all. > > Implemented OmNavigator_get_appName. Please add a test. Jacek

1 0

Re: [1/18] d3dx9: Add shader assembler private definitions
by Stefan Dösinger 17 Aug '09

17 Aug '09

Am Sunday 16 August 2009 19:50:54 schrieb Matteo Bruni: > This is a long patch series that implements the D3D shader assembler > and D3DXAssembleShader function. The first part has already passed a > couple of rounds of review in wine-devel. The patches look ok for applying to me. I didn't look deeply at the later patches yet(no time), and will look later. The base structure seems ok, I know earlier versions of the ASM code, and if there are some smaller issues they can be fixed incrementally. Its probably easier to discuss and fix them(if there are any) once the base code is in. Its a new feature, so it shouldn't cause any regressions.

1 0

Re: [PATCH 6/6] wined3d: Make RTL_READTEX the default rendertarget locking method.
by Stefan Dösinger 17 Aug '09

17 Aug '09

Am Friday 14 August 2009 09:23:25 schrieb Henri Verbeet: > For most cards this should make more sense than RTL_READDRAW, even if e.g. > surface_upload_data() has some room for improvement. I don't think this is a good idea until the READDRAW code has the ability to only upload a part of the surface if a limited rectangle was locked > --- > dlls/wined3d/surface.c | 1 - > dlls/wined3d/wined3d_main.c | 2 +- > dlls/wined3d/wined3d_private.h | 1 - > 3 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 29ad00d..781a6b2 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -1518,7 +1518,6 @@ static HRESULT WINAPI > IWineD3DSurfaceImpl_UnlockRect(IWineD3DSurface *iface) { > IWineD3DSurface_LoadLocation(iface, SFLAG_INTEXTURE, NULL /* partial > texture loading not supported yet */); /* drop through */ > > - case RTL_AUTO: > case RTL_READDRAW: > IWineD3DSurface_LoadLocation(iface, SFLAG_INDRAWABLE, > fullsurface ? NULL : &This->dirtyRect); break; > diff --git a/dlls/wined3d/wined3d_main.c b/dlls/wined3d/wined3d_main.c > index 881f90e..4feb509 100644 > --- a/dlls/wined3d/wined3d_main.c > +++ b/dlls/wined3d/wined3d_main.c > @@ -41,7 +41,7 @@ wined3d_settings_t wined3d_settings = > PS_HW, /* Hardware by default */ > TRUE, /* Use of GLSL enabled by default */ > ORM_FBO, /* Use FBOs to do offscreen rendering */ > - RTL_AUTO, /* Automatically determine best locking method */ > + RTL_READTEX, /* Default render target locking method */ > PCI_VENDOR_NONE,/* PCI Vendor ID */ > PCI_DEVICE_NONE,/* PCI Device ID */ > 0, /* The default of memory is set in FillGLCaps */ > diff --git a/dlls/wined3d/wined3d_private.h > b/dlls/wined3d/wined3d_private.h index 8df99f6..5f88afd 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -267,7 +267,6 @@ static inline float float_24_to_32(DWORD in) > #define SHADER_NONE 4 > > #define RTL_DISABLE -1 > -#define RTL_AUTO 0 > #define RTL_READDRAW 1 > #define RTL_READTEX 2

3 5

Regression Testing 0.9.60/0.9.61
by James McKenzie 17 Aug '09

17 Aug '09

Looks like a patch to 0.9.61 broke the EM_FORMATRANGE patch that I was working on. I've received guidance from Dylan Smith on how to redo the patch and I will once I get the old patch working with 1.0. Guidance on how to use git to run bisect tests would be appreciated. Do I get the commit numbers from the Tag messages that AJ sends? James McKenzie

3 3

Re: winecfg: Let the user specify the drive letter of a to be added drive.
by Austin English 16 Aug '09

16 Aug '09

On Sun, Aug 16, 2009 at 1:12 PM, Rein Klazes<wijn(a)online.nl> wrote: > fixes bug#14728 > --- > programs/winecfg/Bg.rc | 10 +++++++++ > programs/winecfg/Cs.rc | 10 +++++++++ > programs/winecfg/Da.rc | 10 +++++++++ > programs/winecfg/De.rc | 10 +++++++++ > programs/winecfg/En.rc | 10 +++++++++ > programs/winecfg/Es.rc | 10 +++++++++ > programs/winecfg/Fi.rc | 10 +++++++++ > programs/winecfg/Fr.rc | 10 +++++++++ > programs/winecfg/Hu.rc | 10 +++++++++ > programs/winecfg/It.rc | 10 +++++++++ > programs/winecfg/Ja.rc | 10 +++++++++ > programs/winecfg/Ko.rc | 10 +++++++++ > programs/winecfg/Lt.rc | 10 +++++++++ > programs/winecfg/Nl.rc | 10 +++++++++ > programs/winecfg/No.rc | 10 +++++++++ > programs/winecfg/Pl.rc | 10 +++++++++ > programs/winecfg/Pt.rc | 20 +++++++++++++++++ > programs/winecfg/Ro.rc | 10 +++++++++ > programs/winecfg/Ru.rc | 10 +++++++++ > programs/winecfg/Si.rc | 10 +++++++++ > programs/winecfg/Sv.rc | 10 +++++++++ > programs/winecfg/Tr.rc | 10 +++++++++ > programs/winecfg/Zh.rc | 20 +++++++++++++++++ > programs/winecfg/driveui.c | 48 ++++++++++++++++++++++++++++++++++++++++++- > programs/winecfg/resource.h | 2 + > 25 files changed, 299 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/Bg.rc b/programs/winecfg/Bg.rc > index fcdf895..8ac2c67 100644 > --- a/programs/winecfg/Bg.rc > +++ b/programs/winecfg/Bg.rc > @@ -128,6 +128,16 @@ BEGIN > PUSHBUTTON "Îòìåíè",IDCANCEL,77,74,45,14,WS_GROUP > END > > +IDD_DRIVECHOOSE DIALOG DISCARDABLE 60, 70, 170, 60 > +STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU > +CAPTION "Select Drive Letter" > +FONT 8, "MS Shell Dlg" Howdy Rein, I don't believe you're supposed to add English resources to non-English rc files. The dialog will automatically fall back to English if not present. It messes up the translation stats.. -- -Austin

3 2

When do regressions become high priority for developers?
by Matt Perry 16 Aug '09

16 Aug '09

When do regressions become high priority for developers? I ask because I opened bug 13583 over 14 months ago, provided all the information requested, as did other people, and nothing has happened. The program worked with Wine 0.9.53 but has been broken since then. I have continued to test the program on newer versions of Wine occasionally, but the bug persists. In fact, I am starting to see more regressions in recent Wine builds that prevent me from getting to the point in the program where I can test the regression reported in the bug report. 14 months seems to be more than reasonable to repair a regression. I'm worried about having to forever maintain a separate installation of Wine just to use this program. I'll be happy to test further if someone is going to work on this bug but right now my efforts seem to be for naught. Should I bother to continue to give this bug any attention or just abandon it and focus my efforts elsewhere? Matt

5 4

Appinstall testing guide up on the wiki
by Austin English 16 Aug '09

16 Aug '09

Howdy all, James asked me to put up a guide for testing applications with Appinstall. It's on the wiki (which seems to be down at the moment) at http:/wiki.winehq.org/Appinstall_Testing. I had a couple people read over it to make sure I didn't miss anything obvious (or omit stuff that seems obvious to me). If you've got a few minutes and want to write a test for your favorite downloadable application, give it a try. AutoHotKey is pretty simple to pick up, and basic tests (e.g., making sure app launches and doesn't crash) is pretty simple to write. Send me your tests and I'll add them to the test suite. If anything in the guide is unclear, please let me know and I'll update it. If everything looks good, I'll e-mail wine-users, so users can test their favorite apps. For those who haven't followed, Appinstall is my Summer of Code project to automate application testing using AutoHotKey + a wrapper shell script. It handles the process of automatically downloading, running, verifying and testing various applications under Wine, against previously verified Windows behavior. It can test for regressions of popular applications/features, as well as making sure bugs aren't subtly fixed. The wrapper script handles fresh WINEPREFIX's, winetricks dependencies, timeouts of runaway/hung tests, and parsing of the output logs. Source is at http://winezeug.googlecode.com/svn/trunk/appinstall/ -- -Austin

4 5

Re: add spanish resource taskmgr
by lats 16 Aug '09

16 Aug '09

On 16/08/09 09:33, José Francisco Facundo Pérez wrote: When sending to wine-patches, please don't cc: wine-devel but set the Reply-To to wine-devel(a)winehq.org

1 0

Re: attrib.exe[2/4] add usage function
by Jeff Zaroyko 16 Aug '09

16 Aug '09

On Sun, Aug 16, 2009 at 2:12 PM, EA Durbin<ead1234(a)hotmail.com> wrote: > > > ________________________________ > Windows Live™: Keep your life in sync. Check it out. > > > Hi EA I posted these comments on bugzilla before I also saw that you submitted the patchset: in patch 2, you should just use one call to printf or just puts, one call per line is not necessary, just do as such: printf("foo\n" "bar\n" "baz\n"); Why does the usage function return 1? I see that you propagate it as the return value on incorrect usage, attrib.exe still returns 0 on Windows if you give an invalid option: C:\Users\jeffz>attrib +J foo Invalid switch - +J C:\Users\jeffz>echo %ERRORLEVEL% 0 -Jeff

1 0

re: When do regressions become high priority for developers?
by Dan Kegel 15 Aug '09

15 Aug '09

Matt Perry wrote: > When do regressions become high priority for developers? > [SecureCRT broke with wine-0.9.54, > http://bugs.winehq.org/show_bug.cgi?id=13583 ] > 14 months seems to be more than reasonable to repair a regression. That's a tough question. Note that Photoshop CS3 installer has been busted for months, and is in a similar limbo. (We even know how to fix it, but nobody has time at the moment.) Often people will fix regressions that pop up after their changes. In this case, the developer is no longer around. Also, this regression might be a 'we exposed a hole in wine' rather than a plain old bug, so the fix might mean writing a bunch of new code. In this case, the previous version of the app works under Wine, so perhaps that makes a fix less urgent. Sometimes it helps to attract the attention of the app's developer. I'll ping them and see what they say, maybe they can tell us where we're going wrong. Occasionally one of the true hotshots (like AF) will take an interest and diagnose the cause. That makes it a lot easier to fix, the cost to fix the bug becomes much less uncertain, and if some company needs the app to work, a paid fix becomes more affordable at that point. But even with that, sometimes it's ages before the bug bubbles up to the top of anyone's priorities. I wish I had a better answer for you! - Dan

2 1

New Wine Gecko 1.0.0 RC
by Jacek Caban 15 Aug '09

15 Aug '09

Hi, It's time for the new Wine Gecko package release. I've prepared a new package based on Mozilla code a bit newer than Firefox 3.5 and my fixes (most of them are on their way to mainstream Mozilla repository). This release fixes a few known bugs. It's not as big change as 0.9.0 release was, so I don't expect that many problems. Last time we had a few serious regressions and I'd like to avoid them now. That's why I'd like to ask you for help in testing (last time I did too, but somehow we've missed serious problems). To use it, just apply the attached patch, download the build from: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-1.0.0.cab and place it in correct location according to (note s/0.9.1/1.0.0/): http://wiki.winehq.org/Gecko Everything that uses MSHTML is interesting for testing. Please let me know about any regression. If everything goes well, I will do the release on Monday next week. Thanks, Jacek commit 63e1e5a530b27b2bbd1795a418e618b1d4692235 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jul 29 18:00:53 2009 +0200 Wine Gecko 1.0.0 release. diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c index 0cbfc06..d181458 100644 --- a/dlls/mshtml/htmlbody.c +++ b/dlls/mshtml/htmlbody.c @@ -44,6 +44,69 @@ typedef struct { #define HTMLBODY(x) (&(x)->lpHTMLBodyElementVtbl) +static const WCHAR aquaW[] = {'a','q','u','a',0}; +static const WCHAR blackW[] = {'b','l','a','c','k',0}; +static const WCHAR blueW[] = {'b','l','u','e',0}; +static const WCHAR fuchsiaW[] = {'f','u','s','h','s','i','a',0}; +static const WCHAR grayW[] = {'g','r','a','y',0}; +static const WCHAR greenW[] = {'g','r','e','e','n',0}; +static const WCHAR limeW[] = {'l','i','m','e',0}; +static const WCHAR maroonW[] = {'m','a','r','o','o','n',0}; +static const WCHAR navyW[] = {'n','a','v','y',0}; +static const WCHAR oliveW[] = {'o','l','i','v','e',0}; +static const WCHAR purpleW[] = {'p','u','r','p','l','e',0}; +static const WCHAR redW[] = {'r','e','d',0}; +static const WCHAR silverW[] = {'s','i','l','v','e','r',0}; +static const WCHAR tealW[] = {'t','e','a','l',0}; +static const WCHAR whiteW[] = {'w','h','i','t','e',0}; +static const WCHAR yellowW[] = {'y','e','l','l','o','w',0}; + +static const struct { + LPCWSTR keyword; + const WCHAR hexstr[8]; +} keyword_table[] = { + {aquaW, {'#','0','0','f','f','f','f',0}}, + {blackW, {'#','0','0','0','0','0','0',0}}, + {blueW, {'#','0','0','0','0','f','f',0}}, + {fuchsiaW, {'#','f','f','0','0','f','f',0}}, + {grayW, {'#','8','0','8','0','8','0',0}}, + {greenW, {'#','0','0','8','0','0','0',0}}, + {limeW, {'#','0','0','f','f','0','0',0}}, + {maroonW, {'#','8','0','0','0','0','0',0}}, + {navyW, {'#','0','0','0','0','8','0',0}}, + {oliveW, {'#','8','0','8','0','0','0',0}}, + {purpleW, {'#','8','0','0','0','8','0',0}}, + {redW, {'#','f','f','0','0','0','0',0}}, + {silverW, {'#','c','0','c','0','c','0',0}}, + {tealW, {'#','0','0','8','0','8','0',0}}, + {whiteW, {'#','f','f','f','f','f','f',0}}, + {yellowW, {'#','f','f','f','f','0','0',0}} +}; + +static BSTR nscolor_to_str(LPCWSTR color) +{ + int i, r, min = 0, max = sizeof(keyword_table)/sizeof(keyword_table[0])-1; + + if(!color || *color == '#') + return SysAllocString(color); + + while(min <= max) { + i = (min+max)/2; + + r = strcmpiW(color, keyword_table[i].keyword); + if(!r) + return SysAllocString(keyword_table[i].hexstr); + + if(r < 0) + max = i-1; + else + min = i+1; + } + + WARN("unknown color %s\n", debugstr_w(color)); + return SysAllocString(color); +} + static BOOL variant_to_nscolor(const VARIANT *v, nsAString *nsstr) { switch(V_VT(v)) { @@ -305,7 +368,7 @@ static HRESULT WINAPI HTMLBodyElement_get_bgColor(IHTMLBodyElement *iface, VARIA nsAString_GetData(&strColor, &color); V_VT(p) = VT_BSTR; - V_BSTR(p) = SysAllocString(color); + V_BSTR(p) = nscolor_to_str(color); nsAString_Finish(&strColor); diff --git a/dlls/mshtml/mutation.c b/dlls/mshtml/mutation.c index ab9649c..6060a8d 100644 --- a/dlls/mshtml/mutation.c +++ b/dlls/mshtml/mutation.c @@ -412,6 +412,11 @@ static void NSAPI nsDocumentObserver_CharacterDataChanged(nsIDocumentObserver *i { } +static void NSAPI nsDocumentObserver_AttributeWillChange(nsIDocumentObserver *iface, nsIDocument *aDocument, + nsIContent *aContent, PRInt32 aNameSpaceID, nsIAtom *aAttribute, PRInt32 aModType) +{ +} + static void NSAPI nsDocumentObserver_AttributeChanged(nsIDocumentObserver *iface, nsIDocument *aDocument, nsIContent *aContent, PRInt32 aNameSpaceID, nsIAtom *aAttribute, PRInt32 aModType, PRUint32 aStateMask) { @@ -563,6 +568,7 @@ static const nsIDocumentObserverVtbl nsDocumentObserverVtbl = { nsDocumentObserver_Release, nsDocumentObserver_CharacterDataWillChange, nsDocumentObserver_CharacterDataChanged, + nsDocumentObserver_AttributeWillChange, nsDocumentObserver_AttributeChanged, nsDocumentObserver_ContentAppended, nsDocumentObserver_ContentInserted, diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl index 894bb41..24c6214 100644 --- a/dlls/mshtml/nsiface.idl +++ b/dlls/mshtml/nsiface.idl @@ -23,7 +23,7 @@ * compatible with XPCOM, usable in C code. */ -cpp_quote("#define GECKO_VERSION \"0.9.1\"") +cpp_quote("#define GECKO_VERSION \"1.0.0\"") cpp_quote("#define GECKO_VERSION_STRING \"Wine Gecko \" GECKO_VERSION") import "wtypes.idl"; @@ -855,7 +855,7 @@ interface nsIDOMDocument : nsIDOMNode [ object, - uuid(533a8131-8d0c-4ebf-990b-7fad7cd51466), + uuid(09a439ad-4079-46d5-a050-4d7015d1a108), local /* NOT_FROZEN */ ] @@ -868,9 +868,9 @@ interface nsIDOMNSDocument : nsISupports nsresult GetTitle(nsAString *aTitle); nsresult SetTitle(const nsAString *aTitle); nsresult GetContentType(nsAString *aContentType); + nsresult GetReadyState(nsAString *aReadyState); nsresult GetLastModified(nsAString *aLastModified); nsresult GetReferrer(nsAString *aReferrer); - nsresult GetBoxObjectFor(nsIDOMElement *elt, nsIBoxObject **_retval); nsresult HasFocus(PRBool *_retval); nsresult GetActiveElement(nsIDOMElement **aActiveElement); nsresult GetElementsByClassName(const nsAString *classes, nsIDOMNodeList **_retval); @@ -1546,13 +1546,13 @@ interface nsIWebNavigation : nsISupports [ object, - uuid(5af07661-6477-4235-8814-4a45215855b8), + uuid(343700dd-078b-42b6-a809-b9c1d7e951d0), local /* NOT_FROZEN */ ] interface nsIPrintSettings : nsISupports { - typedef struct { char dummy; } nsMargin; + typedef struct { char dummy; } nsIntMargin; nsresult SetPrintOptions(PRInt32 aType, PRBool aTurnOnOff); nsresult GetPrintOptions(PRInt32 aType, PRBool *_retval); @@ -1672,13 +1672,13 @@ interface nsIPrintSettings : nsISupports nsresult SetIsInitializedFromPrinter(PRBool aIsInitializedFromPrinter); nsresult GetIsInitializedFromPrefs(PRBool *aIsInitializedFromPrefs); nsresult SetIsInitializedFromPrefs(PRBool aIsInitializedFromPrefs); - nsresult SetMarginInTwips(nsMargin *aMargin); - nsresult SetEdgeInTwips(nsMargin *aEdge); - nsresult GetMarginInTwips(nsMargin *aMargin); - nsresult GetEdgeInTwips(nsMargin *aEdge); + nsresult SetMarginInTwips(nsIntMargin *aMargin); + nsresult SetEdgeInTwips(nsIntMargin *aEdge); + nsresult GetMarginInTwips(nsIntMargin *aMargin); + nsresult GetEdgeInTwips(nsIntMargin *aEdge); nsresult SetupSilentPrinting(); - nsresult SetUnwriteableMarginInTwips(nsMargin *aEdge); - nsresult GetUnwriteableMarginInTwips(nsMargin *aEdge); + nsresult SetUnwriteableMarginInTwips(nsIntMargin *aEdge); + nsresult GetUnwriteableMarginInTwips(nsIntMargin *aEdge); } [ @@ -1872,7 +1872,7 @@ interface nsIIOService : nsISupports [ object, - uuid(57322c6f-f4ec-4e46-8253-b74be220de16), + uuid(a50d5516-5c0a-4f08-b427-703ca0c44ac3), local, /* NOT_FROZEN */ ] @@ -2485,7 +2485,7 @@ interface nsIHTMLEditor : nsISupports [ object, - uuid(32e68316-67d4-44a5-8d35-0d390fa9df11), + uuid(365d600b-868a-452a-8de8-f46fad8fee53), local /* NOT_FROZEN */ ] @@ -2495,6 +2495,8 @@ interface nsIMutationObserver : nsISupports void /*CharacterDataChangeInfo*/ *aInfo); void CharacterDataChanged(nsIDocument *aDocument, nsIContent *aContent, void /*CharacterDataChangeInfo*/ *aInfo); + void AttributeWillChange(nsIDocument *aDocument, nsIContent * aContent, PRInt32 aNameSpaceID, + nsIAtom *aAttribute, PRInt32 aModType); void AttributeChanged(nsIDocument *aDocument, nsIContent *aContent, PRInt32 aNameSpaceID, nsIAtom *aAttribute, PRInt32 aModType, PRUint32 aStateMask); void ContentAppended(nsIDocument *aDocument, nsIContent *aContainer, PRInt32 aNewIndexInContainer); @@ -2531,7 +2533,7 @@ interface nsIDocumentObserver : nsIMutationObserver void StyleRuleAdded(nsIDocument *aDocument, nsIStyleSheet *aStyleSheet, nsIStyleRule *aStyleRule); void StyleRuleRemoved(nsIDocument *aDocument, nsIStyleSheet *aStyleSheet, nsIStyleRule *aStyleRule); void BindToDocument(nsIDocument *aDocument, nsIContent *aContent); - void DoneAddingContent(nsIContent *aContent, PRBool aHaveNotified); + void DoneAddingChildren(nsIContent *aContent, PRBool aHaveNotified); } /* diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index a122e0c..3af8867 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -583,9 +583,6 @@ static HRESULT exec_editmode(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, debugstr_w(hostinfo.pchHostCss), debugstr_w(hostinfo.pchHostNS)); } - if(This->nscontainer) - set_ns_editmode(This->nscontainer); - update_doc(This, UPDATE_UI); if(This->mon) { @@ -609,6 +606,9 @@ static HRESULT exec_editmode(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, if(FAILED(hres)) return hres; + if(This->nscontainer) + set_ns_editmode(This->nscontainer); + if(This->ui_active) { RECT rcBorderWidths; diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index a153a14..557a789 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -2991,7 +2991,6 @@ static void test_default_style(IHTMLStyle *style) hres = IHTMLStyle_get_margin(style, &str); ok(hres == S_OK, "get_margin failed: %08x\n", hres); - todo_wine ok(!strcmp_wa(str, "1px"), "margin = %s\n", dbgstr_w(str)); hres = IHTMLStyle_put_margin(style, NULL);

2 6

Re: d3d10: Add annotation skipping.
by Henri Verbeet 15 Aug '09

15 Aug '09

2009/8/15 Rico Schüller <kgbricola(a)web.de>: > +static inline void parse_annotation(const char **ptr, unsigned int count) > +{ > + unsigned int i; > + DWORD d[3]; > + > + if(count == 0) return; > + > + FIXME("Skipping %#x annotation(s):\n", count); > + for (i = 0; i < count; ++i) > + { > + read_dword(ptr, &d[0]); > + read_dword(ptr, &d[1]); > + read_dword(ptr, &d[2]); > + FIXME("\t0x%08x 0x%08x 0x%08x\n", d[0], d[1], d[2]); > + } > +} Please try to stick to the general structure of the other parsing functions. I.e., something like this: static void parse_fx10_annotation(const char **ptr) { skip_dword_unknown(ptr, 3); } and { unsigned int i; ... read_dword(ptr, &p->annotation_count); for (i = 0; i < p->annotation_count; ++i) { parse_fx10_annotation(ptr); } ... }

2 1

Writing Conformance Tests
by Mike 15 Aug '09

15 Aug '09

Being new to wine, I was thinking about starting to learn the system by writing conformance tests. Most of us do NOT have access to machines of every flavor of Windows. Is there a standard method to deal with differences across platforms? I realize that often, this won't be an issue, but was wondering what (if any) the practice is for write across platforms without access to these platforms. Thanks, Mikey

2 1

Re: [8/21] comctl32: Add basic structure for IImageList interface
by Nikolay Sivov 15 Aug '09

15 Aug '09

Owen Rudge wrote: > --- > dlls/comctl32/imagelist.c | 318 > ++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 317 insertions(+), 1 deletions(-) Hi. +/************************************************************************* + * IImageList implementation + */ + +typedef struct { + const IImageListVtbl *lpVtbl; + LONG ref; + HIMAGELIST hImageList; +} ImageListImpl; + You can't do that. HIMAGELIST should be the same thing as IImageList. See here: 1) from commctrl.h --- #ifdef __cplusplus FORCEINLINE HIMAGELIST IImageListToHIMAGELIST(struct IImageList *himl) { return reinterpret_cast<HIMAGELIST>(himl); } #else #define IImageListToHIMAGELIST(himl) ((HIMAGELIST)(himl)) #endif --- 2) SHGetImageList docs from http://msdn.microsoft.com/en-us/library/bb762185%28VS.85%29.aspx ---* Remarks* The *IImageList* pointer type, such as that returned in the /ppv/ parameter, can be cast as an HIMAGELIST as needed; for example, for use in a list view. Conversely, an HIMAGELIST can be cast as a pointer to an *IImageList.* ---

3 5

New winetricks 20090815: new verbs directplay, openwatcom, dotnet30
by Dan Kegel 15 Aug '09

15 Aug '09

Another fortnight, another winetricks. Main changes are Solaris portability improvements, more verbs support silent install, and three new verbs: directplay will be handy for those couple dozen networked games that use that API. dotnet30 probably isn't ready for prime time, but it's there for testing. openwatcom is handy for those of us working on the win16 test suite. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Changes since 20090716: r634 | daniel.r.kegel | 2009-08-15 02:22:33 -0700 (Sat, 15 Aug 2009) | 12 lines Improve error dialog to use kde or gnome's dialog program as appropriate (important since Sun doesn't ship xmessage!) and check ownership of .winetrickscache Thanks to Matt Lewandowsky for this patch. Also fix cabextract and unzip tests to show an error dialog in gui case and fix dogui() to not explode if WINETRICKS_TMP doesn't exist yet r633 | austinenglish | 2009-08-14 09:22:45 -0700 (Fri, 14 Aug 2009) | 1 line add OpenWatcom verb r632 | austinenglish | 2009-08-14 09:20:32 -0700 (Fri, 14 Aug 2009) | 1 line ie6 can install silently too r631 | daniel.r.kegel | 2009-08-14 07:07:15 -0700 (Fri, 14 Aug 2009) | 11 lines Use die for showing the "you don't own" error, so gui users can see it Check WINEPREFIX rather than HOME if appropriate (based on a patch by Matt Lewandowsky) r629 | daniel.r.kegel | 2009-08-13 00:01:49 -0700 (Thu, 13 Aug 2009) | 4 lines Don't use test -O, as it's not present on older systems. Based on a patch by Matt Lewandowsky r628 | daniel.r.kegel | 2009-08-12 22:58:10 -0700 (Wed, 12 Aug 2009) | 4 lines Patch from Matt Lewandowsky to work on systems with classic tar instead of gnu tar (i.e. old solaris). r622 | austinenglish | 2009-08-10 19:06:28 -0700 (Mon, 10 Aug 2009) | 2 lines add directplay for Windows 98 (from Directx9) (Patch by Hugh Perkins) r619 | daniel.r.kegel | 2009-08-08 15:34:47 -0700 (Sat, 08 Aug 2009) | 4 lines Different workaround for Samyak problems (see Focht's dotnet20 appdb entry). Patch from Austin, lightly tweaked. r618 | daniel.r.kegel | 2009-08-08 15:25:26 -0700 (Sat, 08 Aug 2009) | 2 lines Update to handle new gecko. (Patch from Austin, with a few tweaks by me.) r615 | daniel.r.kegel | 2009-08-08 07:10:41 -0700 (Sat, 08 Aug 2009) | 3 lines added dotnet30. (Install finishes with current wine; haven't tried running any apps yet.) r613 | austinenglish | 2009-08-07 15:08:12 -0700 (Fri, 07 Aug 2009) | 2 lines make more installers silent, if possible. Adjust winetrickstest to match r605 | austinenglish | 2009-08-01 10:55:56 -0700 (Sat, 01 Aug 2009) | 2 lines update sha1sums/broken urls

1 0

DxDiag Demo Patch
by Allen Hair 15 Aug '09

15 Aug '09

Hello Wine Developers, Over the last couple of months I have been part of a team of students at UCLA who have been developing an implementation of the DxDiag application to release with Wine. After a long quarter, we have produced a working implementation. Some of the features are still missing but most of the functionality has been completed. I hope that our work proves useful to the Wine project. Attached is a patch that will add our code to the source tree. This patch is not meant to be committed, but should provide a demonstration of the application so far. Any feedback would be appreciated, I will try to incorporate any suggestions as I work on releasing incremental patches over the next few weeks. - Allen Hair

6 7

Conformance tests
by Keith Muir 14 Aug '09

14 Aug '09

What disturbs me about the conformance tests is that yes there are 0% failures but when you check you discover its 0% failures on virtual machines. Failures on real hardware under XP can reach as high as 6% with peaks greater than that. Windows is tolerant of all types of hardware wine still isn't. I may be stating the obvious but hardware tolerance must be a goal for the wine project if it isn't already. Regards, Keith

2 1

Re: shell32: fix program search in ShellExecuteEx, quote program name if it contains spaces (resend)
by Juan Lang 14 Aug '09

14 Aug '09

Hi Stefan, I know this is nitpicking, but: - memcpy(buffer, sei_tmp.lpFile, idx * sizeof(WCHAR)); + lstrcpynW(buffer, wszApplicationName, sizeof(buffer)/sizeof(WCHAR)); + while((space=strchrW(buffer, ' '))) You're mixing tabs and spaces here. --Juan

2 3

RE: about video memory detection in wine
by Sun, Sunny 14 Aug '09

14 Aug '09

Hi I am sorry I forgot to introduce myself. I am a software engineer at AMD, working on OpenGL graphics driver, I am working with wine issues now. Some uses complained that there are too many issues to play games with wine with AMD graphics card, so we want to improve the quality. That's all, Thanks Regards Sunny ________________________________ From: Sun, Sunny Sent: Wednesday, August 12, 2009 4:04 PM To: 'wine-devel(a)winehq.org' Cc: Jin, Jian-Rong; Hu, Li; Guan, Xiao-Feng; Wang, Robin Subject: about video memory detection in wine Hi You are using the hardcoded method to get the vidmem now (in function IWineD3DImpl_FillGLCaps), first you call glGetString(GL_RENDERER) to get the GPU renderer string, and then you use this string to set the vidmem in your code. Unfortunately you don't get all of the ATI GPU's string now, for our workstation GPU, the string is always like "ATI FireGL V8700", so you don't recognize this GPU and consider it as ATI_RADEON_9500, then 64MB is set which doesn't support 1280x1024 resolution (Out of adapter memory). I think you can first detect GL_ATI_meminfo in glGetString(GL_EXTENSIONS); if GL_ATI_meminfo exists, then you can use glGetIntegerv(GL_VBO_FREE_MEMORY_ATI, param) to get the current free video memory, you can see more info at: http://www.opengl.org/registry/specs/ATI/meminfo.txt if GL_ATI_meminfo doesn't exist, you can fall back to the original method. Please tell me if you have any questions. Regards, Sunny, Sun

2 2

Re: gdiplus: Implement GdipIsVisiblePoint
by Nikolay Sivov 14 Aug '09

14 Aug '09

Andrew Eikum wrote: > --- > dlls/gdiplus/graphics.c | 19 ++++- > dlls/gdiplus/tests/graphics.c | 162 > +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 177 insertions(+), 4 deletions(-) Could you do it in opposite direction - implement "I" version on top of GdipIsVisiblePoint? This is how the rest of similar cases already works.

2 1

CPPcheck weekly run off thursdays GIT tree
by chris ahrendt 14 Aug '09

14 Aug '09

[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [../wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [../wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/dlls/rpcrt4/tests/server.c:1189]: (all) Array index out of bounds [../wine-git/dlls/wined3d/arb_program_shader.c:820]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:821]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:966]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:977]: (all) Buffer overrun [../wine-git/dlls/wined3d/arb_program_shader.c:988]: (all) Buffer overrun [../wine-git/server/handle.c:201]: (error) Memory leak: new_entries [../wine-git/tools/fnt2bdf.c:656]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:303]: (error) Memory leak: file_lens [../wine-git/tools/makedep.c:953]: (error) Resource leak: file [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd [../wine-git/tools/winedump/pe.c:1549]: (all) Memory leak: map Chris

3 2

Re: [transl 7/8] Add pedantic possibilities to the resource page
by Aurimas Fišeras 14 Aug '09

14 Aug '09

On 2009.08.14 17:28, Paul Vriens wrote: > Hi, > > Again, passing pedantic in the URL gets a different behavior. In > pedantic mode there will always be a direct comparison with English(US) > when there are warnings. > > Changelog > Add pedantic possibilities to the resource page > You forgot the patch

1 0

Re: dbghelp: Fixed arena allocation in pool_alloc.
by Jacek Caban 14 Aug '09

14 Aug '09

> dbghelp: Fixed arena allocation in pool_alloc. Well, 'fixed' might be a wrong word, but this patch makes it more intuitive. Jacek

1 0

Re: [11/18] windowscodecs: add test for pixel format conversion
by Alexandre Julliard 14 Aug '09

14 Aug '09

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > +START_TEST(testsrc) > +{ > + CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); > + > + test_conversion(&testdata_32bppBGRA, &testdata_32bppBGR, "BGRA -> BGR", 0); > + test_conversion(&testdata_32bppBGR, &testdata_32bppBGRA, "BGR -> BGRA", 0); > + test_conversion(&testdata_32bppBGRA, &testdata_32bppBGRA, "BGRA -> BGRA", 0); > + test_invalid_conversion(); > + test_default_converter(); > + > + CoUninitialize(); > +} Much better this way, thanks. You should probably rename the test file to converter.c or something like that though. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Alexandre Julliard : libwine: Ignore libraries that are of the wrong 32/ 64 class.
by Ken Thomases 14 Aug '09

14 Aug '09

Hi Alexandre, It seems this would fail to ignore a fat Mach-O library that doesn't include the right 32/64 class. For example, a fat i386/ppc library when running 64-bit. A fat library starts with the struct fat_header defined in /usr/ include/mach-o/fat.h, followed by a number of struct fat_arch-es. Its magic is 0xcafebabe in big-endian order. This would also fail to ignore a PowerPC-only library because the magic would be big-endian, but I doubt we care about that. -Ken On Aug 11, 2009, at 10:47 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 99538272d5b4ffc852f950dd3447a7072d6316ff > URL: http://source.winehq.org/git/wine.git/?a=commit;h=99538272d5b4ffc852f950dd3… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Tue Aug 11 17:29:07 2009 +0200 > > libwine: Ignore libraries that are of the wrong 32/64 class. > > --- > > libs/wine/loader.c | 46 +++++++++++++++++++++++++++++++++++++++++++ > +-- > 1 files changed, 44 insertions(+), 2 deletions(-) > > diff --git a/libs/wine/loader.c b/libs/wine/loader.c > index d10a6e0..37c603e 100644 > --- a/libs/wine/loader.c > +++ b/libs/wine/loader.c > @@ -147,12 +147,54 @@ static void build_dll_path(void) > } > } > > +/* check if the library is the correct architecture */ > +/* only returns false for a valid library of the wrong arch */ > +static int check_library_arch( int fd ) > +{ > +#ifdef __APPLE__ > + struct /* Mach-O header */ > + { > + unsigned int magic; > + unsigned int cputype; > + } header; > + > + if (read( fd, &header, sizeof(header) ) != sizeof(header)) > return 1; > + if (header.magic != 0xfeedface) return 1; > + if (sizeof(void *) == sizeof(int)) return !(header.cputype >> > 24); > + else return (header.cputype >> 24) == 1; /* CPU_ARCH_ABI64 */ > +#else > + struct /* ELF header */ > + { > + unsigned char magic[4]; > + unsigned char class; > + unsigned char data; > + unsigned char version; > + } header; > + > + if (read( fd, &header, sizeof(header) ) != sizeof(header)) > return 1; > + if (memcmp( header.magic, "\177ELF", 4 )) return 1; > + if (header.version != 1 /* EV_CURRENT */) return 1; > +#ifdef WORDS_BIGENDIAN > + if (header.data != 2 /* ELFDATA2MSB */) return 1; > +#else > + if (header.data != 1 /* ELFDATA2LSB */) return 1; > +#endif > + if (sizeof(void *) == sizeof(int)) return header.class == 1; /* > ELFCLASS32 */ > + else return header.class == 2; /* ELFCLASS64 */ > +#endif > +} > + > /* check if a given file can be opened */ > static inline int file_exists( const char *name ) > { > + int ret = 0; > int fd = open( name, O_RDONLY ); > - if (fd != -1) close( fd ); > - return (fd != -1); > + if (fd != -1) > + { > + ret = check_library_arch( fd ); > + close( fd ); > + } > + return ret; > } > > static inline char *prepend( char *buffer, const char *str, size_t > len ) > > >

2 1

Re: msxml3: Support loading windows file path under wine (resend)
by Alexandre Julliard 14 Aug '09

14 Aug '09

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +static int wineXmlMatchCallback (char const * filename) > +{ > + static const WCHAR sColon[] = {':',0}; > + BSTR sFilename = bstr_from_xmlChar( (xmlChar*)filename); > + int nRet = 0; > + > + TRACE("%s\n", debugstr_w(sFilename)); > + > + /* > + * We will deal with loading XML files from the file system > + * We only care about files that linux cannot find. > + * e.g. C:,D: etc > + */ > + if(isalphaW(sFilename[0]) && sFilename[1] == sColon[0]) > + nRet = 1; > + > + SysFreeString(sFilename); It doesn't make sense to convert the string to Unicode just to check for a drive letter. Also the sColon string is clearly useless. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/4] ntdll: Add ProcessExecuteFlags handling to NtQueryInformationProcess
by Alexandre Julliard 14 Aug '09

14 Aug '09

Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> writes: > This patch adds todo_wine statements to the test case, as this patch > enables the test case to run on wine. It would be cleaner to store the state in process.c rather than adding yet another internal function to retrieve it. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3d9 testsuite crash since 1.1.27 in DestroyContext
by Joerg-Cyril.Hoehle＠t-systems.com 14 Aug '09

14 Aug '09

Hi, did anyone notice this recent bug? The d3d9 and d3d8 testsuites fail for me since 1.1.27. My crash backtrace is similar to that already visible in test.winehq.org "WinXP-AMD2600-1.1.27" (submitted by somebody else): http://test.winehq.org/data/b79639699766e7c8f3e236f3fef54e5daac0e5f9/index_… I'm using Ubuntu Intrepid with Intel i915 graphics. Is that worth regresion testing or is somebody already looking at this? Note that Austin English's machines show no failure in test.winehq.org, as well as Chris Ahrendt's! The bug is still present in git as of 2009-08-12. Regards, Jörg Höhle

2 1

[PATCH 3/4] kernel32: implement CancelIoEx (try 2)
by Mike Kaplinskiy 13 Aug '09

13 Aug '09

1 0

Re: add skeleton for new attrib.exe application
by Juan Lang 13 Aug '09

13 Aug '09

Hi EA, some comments on your tiny little app: +#define WIN32_LEAN_AND_MEAN + +#include "config.h" + +#include <windows.h> +#include <stdio.h> +#include <stdlib.h> You don't need to define WIN32_LEAN_AND_MEAN for compiling with Wine's headers, and you don't need to include <windows.h>, either. Also, since you never use any of the standard library functions, you don't need to include <stdio.h> or <stdlib.h>. A useful starting point when compiling with Wine's headers is: #include <stdarg.h> #include "windef.h" #include "winbase.h" +int main( int argc, char *argv[] ) +{ + exit(0); As Jeff pointed out in bug 18059, just return 0 rather than calling exit(0). I don't think you need to use wmain rather than main for an empty application, but if you ever intend to work with the command line, wmain is probably better. --Juan

1 0

Re: [trans] update Chinese translation for winecfg
by Henri Verbeet 13 Aug '09

13 Aug '09

2009/8/13 Cheer Xiao <xiaqqaix(a)gmail.com>: > Henri Verbeet<hverbeet(a)gmail.com> told me that I should provide my > full name in the file as well as in my e-mail account name. Here is > the new patch. > Actually, that patch doesn't apply. Looks like it's against a version of Wine from before commit 4e046a6759b059b3c424480bea052af01cc85ebe on Aug. 5. You should rebase it against the current git version.

1 0

D3D shader assembler (round 2)
by Matteo Bruni 13 Aug '09

13 Aug '09

2009/8/10 Stefan Dösinger <stefandoesinger(a)gmx.at>: > Hi, > A few comments - mostly things I haven't spotted earlier. Hi, I fixed the code, almost completely following your reviews (thank you, of course). I'm reporting the differences with your suggestions: > >> --- /dev/null >> +++ b/dlls/d3dx9_36/asmshader.h >> --- /dev/null >> +++ b/dlls/d3dx9_36/asmshader_private.h > I think it doesn't need two include files, especially since both of them are > d3dx9-private anyway. The question is, is it better to just merge them into > d3dx9_36_private.h, or have assembler things in a separate file? I tend > towards putting everything into d3dx9_36_private.h, but I don't have a strong > opinion about that. > I merged everything into d3dx9_36_private.h >> +%option prefix="asmshader_" >> + buffer = asmshader__scan_string(text, asm_ctx.yyscanner); > It seems that flex adds an underscore to the prefix anyway, so I guess its > fine to remove the one from the prefix option. > Removing the underscore from the flex prefix produces a (better) asmshader_scan_string function but also an ugly asmshaderlex_init. I decided to keep the underscore. >> + WINED3DSIO_NOP = 0, >> + WINED3DSIO_MOV = 1, >> + WINED3DSIO_ADD = 2, >> and others > Can you give them a different name prefix, to make it clear that they don't > have any relationship with wined3d any more? > I named them BWRITERxxxx (the same for wine_shader, now it is named bwriter_shader, enforcing the idea that that represents the bytecode writer interface). Is it ok? >>+DWORD SlWriteBytecode(const wine_shader *shader, int dxversion, DWORD > **result) { >> +static struct bc_writer *create_writer(DWORD version, DWORD dxversion) { > Does it still need the dxversion? > It's not needed, but I kept it in anticipation of D3D10 support. Can be removed anyway. > asmparser_srcreg_vs_3: >> + if(src->type != WINED3DSPR_TEMP && src->type != WINED3DSPR_INPUT && >>+ src->type != WINED3DSPR_CONST && src->type != WINED3DSPR_ADDR && >> + src->type != WINED3DSPR_CONSTBOOL && src->type != > WINED3DSPR_CONSTINT && >> + src->type != WINED3DSPR_LOOP && src->type !=WINED3DSPR_SAMPLER && >> + src->type != WINED3DSPR_LABEL && src->type != WINED3DSPR_PREDICATE) > A swich-case statement or a lookup table would probably be nicer. (A lookup > table has the disadvantage that you still have to check min and max > separately though) Looking better at this, I noticed that I wasn't checking the register number, while native has this check. So I reworked this part, and now the code is as the attached file. Regarding Henri's review, I followed everything, except keeping my_alloc/realloc/free (now asm_alloc and c.) functions, as it seems Stefan likes them very much :) Supposing my changes are ok, what should I do now? Wait for reviews of the rest? Or maybe send the updated code? In this case, should I send it again in wine-devel or have a try with wine-patches? Cheers, Matteo Bruni

3 2

Font can be changed in Dictation Box after today's git
by Susan Cragin 12 Aug '09

12 Aug '09

Yippee!! A big step forward for usability. I'll mark the bug fixed tonight.

1 0

Re: [1/2] gdiplus: Implement GdipGetVisibleClipBounds
by Henri Verbeet 12 Aug '09

12 Aug '09

2009/8/12 Andrew Eikum <aeikum(a)codeweavers.com>: > + GpStatus stat = Ok; The initialization is redundant, since you always initialize stat before using it. > + if((stat = GdipCreateRegionRect(&wnd_rectf, &wnd_rgn) != Ok)) > + return stat; I don't think that does what you want it to do.

3 2

Re: [2/2] gdiplus/tests: Add tests for GdipGetVisibleClipBounds
by Nikolay Sivov 12 Aug '09

12 Aug '09

Andrew Eikum wrote: > --- > dlls/gdiplus/tests/graphics.c | 244 > +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 244 insertions(+), 0 deletions(-) I suggest to split this: --- + ok(rectf.X == exp.X && + rectf.Y == exp.Y && + rectf.Width == exp.Width && + rectf.Height == exp.Height, + "Expected clip bounds (%0.f, %0.f, %0.f, %0.f) to be the size of " + "the screen (%0.f, %0.f, %0.f, %0.f)\n", + rectf.X, rectf.Y, rectf.Width, rectf.Height, + exp.X, exp.Y, exp.Width, exp.Height); --- to four separate tests to simplify customization in possible failures in future (mean broken() cases on native).

1 0

re: winetricks, dotnet3 and winsxs
by Dan Kegel 12 Aug '09

12 Aug '09

In http://www.winehq.org/pipermail/wine-devel/2009-August/077858.html Hin-Tak wrote >... >The last part (missing charset) seems to be some harmless thing winetrick does - instead of gtk it calls good old xlib message to pop up a message; I haven't looked at why. the code is warn() { echo "$@" case x"$GUI" in x1) xmessage -center " Winetricks error: $@ " ;; *) ;; esac } i.e. we haven't bothered to use the nicer dialog for errors. Think we should?

2 1

Re: [trans] update Chinese translation for winecfg
by Henri Verbeet 12 Aug '09

12 Aug '09

2009/8/12 xiaq <xiaqqaix(a)gmail.com>: > The patch has been reviewed by the original translator, Hongbo Ni. I > have also included my name in the file. > You need to include your full name in patches sent to Wine.

1 0

Review: winex11.drv: Add workaround for 'phantom key' presence in X
by Andrew Eikum 12 Aug '09

12 Aug '09

A bug made itself present in VkKeyScan's handling of the less-than character on US (and other) keyboard layouts. VkKeyScan('<') in Windows returns 0x1bc, which is VK_OEM_COMMA with the shift key flag set. In Wine, VkKeyScan('<') returns 0xe2, which is VK_OEM_102, or the VK for the "infamous phantom key". The root cause of this is X's XKeysymToKeycode returning the keycode for the phantom key instead of the keycode for the comma key when passed the keysym for '<' (XK_less). This isn't incorrect on X's part, but inconvenient for Wine as most US keyboards don't have the <> key, but rather use the shifted comma key. The attached patch adds a new field in the main_key_tab structure. The new field indicates which keysym, if any, should be passed to XKeysymToKeycode instead of '<'. I've filled this field in for every keyboard type already defined in keyboard.c. Since winex11.drv is a pretty touchy part of Wine, I'm sending this patch to wine-devel for review. I don't have the hardware or software setup to test other language inputs, and LoadKeyboardLayout is not implemented so I can't just test with VkKeyScanEx. If you're using a foreign keyboard, especially one with a <> key, please test VkKeyScan's handling of the '<' character with this patch applied. Thanks Andrew

3 5

Re: ws2_32(2/8): Add af_irda.h (try 3)
by Alexandre Julliard 12 Aug '09

12 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > +typedef struct _IAS_QUERY > +{ > + UCHAR irdaDeviceID[4]; > +#ifdef USE_WS_PREFIX > + char irdaClassName[WS_IAS_MAX_CLASSNAME]; > + char irdaAttribName[WS_IAS_MAX_ATTRIBNAME]; > +#else > + char irdaClassName[IAS_MAX_CLASSNAME]; > + char irdaAttribName[IAS_MAX_ATTRIBNAME]; > +#endif > + USHORT irdaAttribType; > + union { > + int irdaAttribInt; > + struct { > + ULONG Len; > + UCHAR OctetSeq[IAS_MAX_OCTET_STRING]; > + } irdaAttribOctetSeq; > + struct { > + ULONG Len; > + UCHAR CharSet; > + UCHAR UsrStr[IAS_MAX_USER_STRING]; > + } irdaAttribUsrStr; > + } irdaAttribute; > +} IAS_QUERY, *PIAS_QUERY; > + > +typedef struct _IAS_SET > +{ > +#ifdef USE_WS_PREFIX > + char irdaClassName[WS_IAS_MAX_CLASSNAME]; > + char irdaAttribName[WS_IAS_MAX_ATTRIBNAME]; > +#else > + char irdaClassName[IAS_MAX_CLASSNAME]; > + char irdaAttribName[IAS_MAX_ATTRIBNAME]; > +#endif > + union { > + int irdaAttribInt; > + struct { > + ULONG Len; > + UCHAR OctetSeq[IAS_MAX_OCTET_STRING]; > + } irdaAttribOctetSeq; > + struct { > + ULONG Len; > + UCHAR CharSet; > + UCHAR UsrStr[IAS_MAX_USER_STRING]; > + } irdaAttribUsrStr; > + } irdaAttribute; > +} IAS_SET, *PIAS_SET; > + > +#endif /* AF_IRDA_H */ These don't seem to match the PSDK headers or MSDN (which don't match each other either...) Which are the correct ones? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [7/13] windowscodecs: implement SetPixelFormat for BMP frame encoder
by Henri Verbeet 12 Aug '09

12 Aug '09

2009/8/12 Vincent Povirk <vincent(a)codeweavers.com>: > + if (memcmp(formats[i].guid, pPixelFormat, sizeof(GUID)) == 0) This works of course, but isn't IsEqualGUID() the preferred way to do that?

2 1

Re: [2/2] comctl32/listview: Block redrawing entirely after WM_SETREDRAW wParam=FALSE
by Alexandre Julliard 12 Aug '09

12 Aug '09

Nikolay Sivov <bunglehead(a)gmail.com> writes: > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index a65d832..9bca376 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -9740,6 +9740,8 @@ static LRESULT LISTVIEW_Paint(LISTVIEW_INFO *infoPtr, HDC hdc) > { > TRACE("(hdc=%p)\n", hdc); > > + if (!is_redrawing(infoPtr)) return 0; > + > if (infoPtr->bNoItemMetrics && infoPtr->nItemCount) > { > infoPtr->bNoItemMetrics = FALSE; > @@ -9790,7 +9792,13 @@ static LRESULT LISTVIEW_PrintClient(LISTVIEW_INFO *infoPtr, HDC hdc, DWORD optio > LISTVIEW_EraseBkgnd(infoPtr, hdc); > > if (options & PRF_CLIENT) > + { > + BOOL redraw_old = infoPtr->bRedraw; > + > + infoPtr->bRedraw = TRUE; > LISTVIEW_Paint(infoPtr, hdc); > + infoPtr->bRedraw = redraw_old; > + } That's not very nice. You should move the checks so that you don't have to change the flag to paint. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/6] comctl32/tests: Move v6 test initialisation routines into separate file
by Henri Verbeet 12 Aug '09

12 Aug '09

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > This is the first of a series of patches to implement the IImageList > interface into comctl32, introduced in comctl32 v6. > > This first patch splits the routines for loading v6 of comctl32 > (requiring a side-by-side manifest) out of the listview tests and into a > general file, so that it can be used by the imagelist tests too. > I don't know if there's any reason these tests should be an exception, but the general rule is that tests are supposed to be contained within their own file, to allow for easy compilation.

6 9

Re: [2/2] msxml3: IXMLDOMElement doesnt support IObjectIdentity
by Jacek Caban 12 Aug '09

12 Aug '09

Alistair Leslie-Hughes wrote: > Hi, > This is just to silence a noisy fixme. > > Changelog: > msxml3: IXMLDOMElement doesnt support IObjectIdentity It's an interface used by jscript engine, so it would be better to silence it for all object that implements IDispatch. I'd suggest to move it to dispex_query_interface. Jacek

1 0

Re: [1/2] msxml3: Add IDispatchEx support to IXMLDOMElement
by Jacek Caban 12 Aug '09

12 Aug '09

Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > msxml3: Add IDispatchEx support to IXMLDOMElement @@ -46,6 +47,9 @@ typedef struct _domelem LONG ref; IUnknown *node_unk; IXMLDOMNode *node; + + /* IDispatchEx */ + DispatchEx dispex; } domelem; It would be probably better to add DispatchEx to node object. Then other node types will reuse it (initializing with different data). See how it's done in mshtml. Jacek

1 0

Re: shdocvw: Implement OleInPlaceObject InPlaceDeactivate
by Jacek Caban 12 Aug '09

12 Aug '09

Alistair Leslie-Hughes wrote: > Hi, > This fixes bug http://bugs.winehq.org/show_bug.cgi?id=18531 > > > Changelog: > shdocvw: Implement OleInPlaceObject InPlaceDeactivate It's not an implementation, but a bit better stub. Please leave the FIXME message. Jacek

1 0

Re: [3/5] comctl32/treeview: Make tests not depend from each other, replace some magics with macros
by Paul Vriens 12 Aug '09

12 Aug '09

Nikolay Sivov wrote: > Currently tests are dependent which makes it impossible to change only one, > could be possible actually, but not always. Anyway separate tests are better. > > Changelog: > - Make test not depend from each other, replace some magics with macros > Hi Nikolay, Looks like this one introduced 1 failure on several boxes (XP, W2K3, Vista and W2K8) and 1 more on Vista boxes: http://test.winehq.org/data/tests/comctl32:treeview.html Could you have a look? -- Cheers, Paul.

2 2

Re: includes: Make vmrender.idl C++ friendly
by Maarten Lankhorst 11 Aug '09

11 Aug '09

Hi Austin, Austin English schreef: > On Tue, Aug 11, 2009 at 12:56 PM, Maarten > Lankhorst<m.b.lankhorst(a)gmail.com> wrote: > >> C++ doesn't like: GUID GUID; which is valid in C, so replace with struct >> _GUID GUID; >> > > > FYI, you're e-mail is messed up in the patch: > From: Maarten Lankhorst <mlankhorst(a)patser.(none)> > > I think AJ's scripts may prefer the patch e-mail to the sender's e-mail. > afaict it has never been a problem in the past, aj has always used sender for me Cheers, Maarten

1 0

convert a testcase into a unittest (bug #19666)
by Stefan Leichter 11 Aug '09

11 Aug '09

Hi, i got a testcase that exhibits bug #19666. Now i'm looking for a way to integrate the testcase into the testsuite. The testcase needs a program (currently c:\ShellExecuteClient.exe) that must be called without parameters. Therefore i can not use eg. shell32_test.exe itself. I'm searching for a way to build/bundle ShellExecuteClient.exe with shell32_test.exe. Can ShellExecuteClient.exe be integrated as wine-lib binary in the testsuite? Please give me comments, suggestions, solutions Bye Stefan

1 0

Re: [7/10] [try 2] comctl32: Add basic structure for IImageList interface
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/11 Owen Rudge <orudge(a)codeweavers.com>: > +static const IImageListVtbl ImageListImpl_Vtbl = { > + ImageListImpl_QueryInterface, > + ImageListImpl_AddRef, > + ImageListImpl_Release > +}; You can't do that, you need to at least implement stubs for the other methods.

2 2

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA (try 2)
by Eric Pouech 11 Aug '09

11 Aug '09

Juan Lang a écrit : > Uses %u rather than %d, based on Henri's feedback. > --Juan > > ------------------------------------------------------------------------ > > Hi Juan don't you miss a break statement (or a more likely a return 0) at the end of the block ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: ws2_32(8/8): Implement getsockopt(SOL_IRLMP, IRLMP_ENUMDEVICES)
by Henri Verbeet 11 Aug '09

11 Aug '09

Isn't getsockopt() supposed to write the size of the data actually written to optlen?

2 1

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/11 Juan Lang <juan.lang(a)gmail.com>: > + sprintf( win->irdaServiceName, "LSAP-SEL%d", uin->sir_lsap_sel ); I have no idea if this can even be an issue in practice, but "uin->sir_lsap_sel" is unsigned.

2 1

Re: Assigning a bug to myself
by James Mckenzie 11 Aug '09

11 Aug '09

>--- On Mon, 10/8/09, Ben Klein <shacklein(a)gmail.com> wrote: > >> 2009/8/10 Alexandros Dermenakis >> <alderfc7(a)gmail.com>: >> > Hi, >> > >> > I 'm now ready to start debugging wine so I'd like to >> try solving a bug. Do I >> > need to assign a bug to myself or I just start solving >> it? If I have to assign >> > it how can I do that? >> > >> > I created a bug zilla account >> >> You don't need to assign bugs to yourself. I believe this >> was covered >> in another thread. Once you have a patch to fix a bug, send >> it to >> wine-patches, following the "submitting patches" guide. >> Then, if it is >> accepted and committed, the appropriate bug can be marked >> "FIXED". > >To avoid duplication of effort (though quite unlikely among the wine community), it is probably appropriate to >stick a comment on the specific bug to that effect and put yourself to the CC:. This way, others know you >are working on it, and you get to read about others' insight to the problem if they choose to write to >comment. (this has essentially the same effect as having the bug formally assigned to oneself, without the >management/administration overhead). It is a good idea to get the bug assigned to one's self and not to rely on the use of comments. Of course, if you abandon the bug because you cannot complete the fix, it is a good idea to get the bug unassigned and leave a comment as to the status of the bug fix. > >Most bugs' status are eventually and officially closed by AJ anyway :-). ALL Wine bugs are closed by AJ after confirming that the fix is in a specific release of Wine. He has reserved this to himself. Wine Web Site bugs are closed by the person who incorporated fixes into the code for the web site. James McKenzie

1 0

Help with test
by Alistair Leslie-Hughes 11 Aug '09

11 Aug '09

Hi, I been trying to fix this bug, and have patch that works. http://bugs.winehq.org/show_bug.cgi?id=11325 The only thing is that the test case I've written fails under wine but work under Windows XP. The issue is, when using a stylesheet we can do something like <xsl:apply-templates select='document("C:\temp\ss.xsl"/bottle/etc)' />. which attempts to load a document and extracts information from it. In windows this works fine, but the linux libxsl library doesn't know about 'c:\' syntax. To get around this issue we overload the input for libxml, and handle windows file paths. (patch attached) The problem is I've attempted to reproduce this scenario as a test, but have missed something. Can someone have a look to see what I might of overlooked? Best Regards Alistair Leslie-Hughes

1 0

Re: hhctrl.ocx: Handle NULL param
by Paul Chitescu 11 Aug '09

11 Aug '09

This is a quite ugly patch, adds unnecessary wstring copying. Why not: wsprintfW(buf, url_format, full_path, (index && index[0] == '/') ? empty : slash, index);

1 1

Re: removes 1024 mb from geforce gtx 260 and adds 896mb instead directx patch
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/10 James Carthew <jcarthew(a)gmail.com>: > From 3fc1812db11e6468b9774f597993c292f36873b7 Mon Sep 17 00:00:00 2001 > From: Your Name <you(a)email.com> > Date: Mon, 10 Aug 2009 12:11:31 +0930 > Subject: [PATCH] removes 1024mb from geforce 260 gtx and adds 896mb instead to directx.c > to match real geforce 260gtx cards. Please use a proper name, e-mail address and subject.

1 0

Re: [6/6] comctl32: Add stubs for image list functions introduced in Vista
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > +@ stdcall HIMAGELIST_QueryInterface(long long long) ... > +@ stdcall ImageList_CoCreateInstance(long long long long) These should all be pointers. > + FIXME("STUB: %s %p %s %p\n",debugstr_guid(rclsid), punkOuter, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; You have some trailing white space here. Also, the white space in the FIXME is somewhat inconsistent. Personally, I'd say the wording in the comments and the parameter naming is closer to MSDN than I'd be comfortable with.

1 0

Re: [5/6] comctl32/tests: Add basic test for IImageList using SHGetImageList
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > +static BOOL test_shell_imagelist(void) ... > + test_shell_imagelist(); It's a bit pointless to add a return value if it's always going to be TRUE, and you're ignoring it anyway.

1 0

Re: [2/6] include: Define interface for comctl32 v6 (IImageList)
by Henri Verbeet 11 Aug '09

11 Aug '09

2009/8/10 Owen Rudge <orudge(a)codeweavers.com>: > +cpp_quote("#define ILIF_ALPHA 0x00000001") > You don't need cpp_quote here, you can just do something like "const UINT ILIF_ALPHA = 1;" > +interface IImageList : IUnknown ... > +}; While valid, you don't need the ; here.

1 0

Wine and XShm support
by Roderick Colenbrander 11 Aug '09

11 Aug '09

Hi, As of Wine 1.1.27, XShm support was added for the creation of DIBSECTIONs in winex11.drv. The use of XShm more closely matches to the Windows behavior and can also bring more performance. An Nvidia developer noticed this change in the ChangeLog and we both wondered why even more XShm code was added in this time because XShm has lost its use due to the emergence of EXA-like display drivers. Modern drivers disable a large amount of hardware acceleration when using XShm because they can't create the pixmaps in video memory since the client owns the memory. This could decrease performance quite a bit for most applications if they aren't hit by dibsection back-and-forth copying bottlenecks. XRender for instance falls back to software rendering for non-video memory based pixmaps. I would perhaps suggest that we should perhaps drop XShm support (or at least add a registry key for it and disable it perhaps on 'modern drivers'). What do you guys think? Regards, Roderick Colenbrander

6 8

winetricks, dotnet3 and winsxs
by Hin-Tak Leung 11 Aug '09

11 Aug '09

Hiya, I have tried playing with the new dotnet3 functionality. Actually even with a clean new wineprefix I haven't been able to get dotnet3 finishing installing - it hangs for a lonh time doing nothing much but the last it does is ngen. the process table shows nothing extra. killing all and rerun gives the option to repair (or uninstall) and this is the tail end of it: -------------- icrosoft (R) CLR Native Image Generator - Version 2.0.50727.42 Copyright (C) Microsoft Corporation 1998-2002. All rights reserved. fixme:imm:ImmDisableIME (-1): stub err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded fixme:richedit:ME_HandleMessage EM_SETMARGINS: stub fixme:richedit:ME_HandleMessage EM_SETMARGINS: stub err:ole:CoUninitialize Mismatched CoUninitialize err:ole:CoUninitialize Mismatched CoUninitialize err:ole:CoRevokeClassObject called from wrong apartment, should be called from d8000000d9 Microsoft (R) CLR Native Image Generator - Version 2.0.50727.42 Copyright (C) Microsoft Corporation 1998-2002. All rights reserved. Note: command 'wine /home/Hin-Tak/.winetrickscache/dotnet30/dotnetfx3.exe' returned status 67. Aborting. Warning: Missing charsets in String to FontSet conversion Warning: Unable to load any usable fontset --------------------- On my good old 'everything' wine prefix, running dotnet2 (which is called by dotnet3) has the effect of *removing* the MSVCRT80 winsxs from winsxs and breaks a lot of things - and I had to copy them back from the alternative clean install. Why does it do that? The last part (missing charset) seems to be some harmless thing winetrick does - instead of gtk it calls good old xlib message to pop up a message; I haven't looked at why.

2 2

GSoC 2009 final week of coding started
by Kai Blin 11 Aug '09

11 Aug '09

Hi GSoC students, hi mentors, just a little heads up that the final week of coding for GSoC started on Monday. The program timeline suggests that you start with writing documentation and tests now, but check with what your mentors think you should work on. Firm "pencils down" date is next Monday. Also see http://socghop.appspot.com/document/show/program/google/gsoc2009/timeline for the timeline. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Assigning a bug to myself
by Alexandros Dermenakis 10 Aug '09

10 Aug '09

Hi, I 'm now ready to start debugging wine so I'd like to try solving a bug. Do I need to assign a bug to myself or I just start solving it? If I have to assign it how can I do that? I created a bug zilla account

6 6

How to test cryptui's dialogs?
by Aurimas Fišeras 10 Aug '09

10 Aug '09

Hello, I've finished translating cryptui's resources, checked control sizes with resource editor and adjusted them where it was needed. But how can I run cryptui's wizards and other dialogs to confirm that everything else is translated correctly?

6 21

The next Wine Bug Day will be this Sunday, August 16
by Scott Ritchie 10 Aug '09

10 Aug '09

Wine Bug Day is a chance to help the Wine developers focus on Wine development by doing some of the QA work for them. We make sure bugs are still there in the latest Wine so they don't have to. If you'd like to get involved and maybe even have a bit of fun triaging bugs with a group of people, check out the wiki page at http://wiki.winehq.org/BugDay The wiki page has some suggestions for easy bugs to target, such as bugs in your favorite application and bugs with a free testable download. Our goal for this Bug Day will be to continue on the success of the first: http://yokozar.org/blog/archives/107 -- last time we hit over 70 bugs, and this time I'm betting we can top 100. I (and others) will be in the IRC channel during bug day fielding all your questions, so please feel free to join in and rock some bugs :) Thanks, Scott Ritchie

1 0

Re: kernel32/nls/winerr: Add Russian translation [try 3]
by Dmitry Timoshkov 10 Aug '09

10 Aug '09

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc I think it's been said enough about your "translation". I'm not going to spend more time commenting on it, I hope Alexandre will ignore all future attempts as well. -- Dmitry.

4 9

AppDB isn't working
by Igor Tarasov 10 Aug '09

10 Aug '09

AppDB displays only decorations and navigation - no content on all pages. Maybe this is due to recent commits? -- Igor

4 4

D3D shader assembler (round 2)
by Matteo Bruni 10 Aug '09

10 Aug '09

I'm sending a new version of the shader assembler, which tries to address the caveats and suggestions previously given by Henri Verbeet (http://www.winehq.org/pipermail/wine-devel/2009-July/077428.html for reference) and has a few other changes, such as making the parser reentrant and matching more faithfully native behavior in handling errors in shader programs. One point of discussion could be the internal transformations done to shaders version 1.x and 2.x, towards a sm 3.0-type representation. This is not really necessary for the assembler (which could naively keep the original instruction opcode and register type), but I think it can be useful looking at a reuse of the bytecode writer in the shader compiler: this way the compiler could be somewhat simplified, having to deal just with sm 3.0 registers and conventions, while it would be writer's responsibility to convert to the destination format (e.g. transforming some mov to texcoord in <= ps 1.3). Anyway, if this is not considered useful, it could be removed. As usual, reviews, comments and suggestions are much appreciated. Regards, Matteo Bruni.

3 2

backward binary compatibility of winelib
by Андрей Пономаренко 09 Aug '09

09 Aug '09

Hello, I'm from Institute for System Programming of Russian Academy of Sciences and we are developing a free lightweight tool for checking backward/forward binary compatibility of shared C/C++ libraries in OS Linux. It checks interface signatures and data type definitions in two library versions (headers and shared objects) and searches ABI changes that may lead to incompatibility. We have released 1.2 version of this tool and we'd like you to consider its usefulness for your project. The wiki-page with the latest release of binary compatibility checker is http://ispras.linux-foundation.org/index.php/ABI_compliance_checker Andrey Ponomarenko

2 1

re: cppcheck run against 1.27
by Dan Kegel 09 Aug '09

09 Aug '09

Chris wrote: >... >[../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >deallocated pointer: fd - This just means your freeing an already freed >resource... This is more of a warning than anything Double frees are serious errors... double closes not so much. I don't see either on that line, though...? - Dan

1 1

.net 3.5 installer happy already?!
by Dan Kegel 09 Aug '09

09 Aug '09

After the recent success with the .net 3.0 installer, I decided to try .net 3.5: $ wget http://download.microsoft.com/download/7/0/3/703455ee-a747-4cc8-bd3e-98a615… $ sha1sum dotNetFx35setup.exe b0ca05c12ebb9a3610206bad7f219e02b7873cbd dotNetFx35setup.exe $ rm -rf ~/.wine $ sh winetricks dotnet20 $ wine dotNetFx35setup.exe And surprise, although there was a crash dialog about printfilterpipelinesvc, the installer reported that it finished ok! I have no idea if the installed runtime actually works, and there are a ton of log messages after installation finishes. (Presumably the .net optimization service?) But it's nice to have gotten this far. - Dan p.s. A few of the common warnings at random: Could not load type 'System.DateTimeOffset' from assembly 'mscorlib, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. while compiling method token 0x6000723 fixme:shell:URL_ParseUrl failed to parse L"System.ServiceModel" Could not load file or assembly 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. Exception from HRESULT: 0x80070002 while compiling method token 0x60001bc Error compiling System.ServiceModel.Web, Version=3.5.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35: Could not find or load a type. (Exception from HRESULT: 0x80131522) fixme:shell:URL_ParseUrl failed to parse L"System.ServiceModel" Warning: System.IO.FileNotFoundException: Could not load file or assembly 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' or one of its dependencies. Exception from HRESULT: 0x80070002 File name: 'System.ServiceModel, Version=3.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' WRN: Assembly binding logging is turned OFF. To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. Note: There is some performance penalty associated with assembly bind failure logging. To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].

1 0

Re: wine-devel Digest, Vol 49, Issue 21
by chris ahrendt 09 Aug '09

09 Aug '09

> > Subject: > re: cppcheck run against 1.27 > From: > Dan Kegel <dank(a)kegel.com> > Date: > Sat, 8 Aug 2009 15:53:25 -0700 > To: > wine-devel(a)winehq.org > > To: > wine-devel(a)winehq.org > > > Chris wrote: > >> ... >> [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >> deallocated pointer: fd - This just means your freeing an already freed >> resource... This is more of a warning than anything >> > > Double frees are serious errors... double closes not so much. > I don't see either on that line, though...? > - Dan > I can run it with the --all option to see if it gives any clarification Chris

1 0

Building inkscape for Windows using mingw under wine
by Dan Kegel 08 Aug '09

08 Aug '09

http://bugs.winehq.org/show_bug.cgi?id=19615 shows that wine is very nearly in good enough shape to run the fetch-all-the-libs-and-sources script with cygwin, and run the inkscape win32 build system, and pop out a working inkscape.exe. We're just one little leak away from full success, I think. If you ask me, that's pretty cool. - Dan

1 2

dotnet30 and winetricks
by Dan Kegel 08 Aug '09

08 Aug '09

Thanks to AF and Hans (and Codeweavers), there's now a short recipe for installing .net 30. I've added it to winetricks. Give it a shot and let me know if it works for you...

3 3

cppcheck run against 1.27
by chris ahrendt 08 Aug '09

08 Aug '09

[../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/tools/fnt2bdf.c:219]: (error) Resource leak: fp [../wine-git/tools/fnt2bdf.c:653]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:304]: (error) Memory leak: file_lens [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd [../wine-git/tools/winebuild/res16.c:187]: (error) Resource leak: fd [../wine-git/tools/winedump/pe.c:1549]: (error) Memory leak: map Latest Check against the 1.27 Tree Chris

3 2

Re: cppcheck run against 1.27
by chris ahrendt 08 Aug '09

08 Aug '09

Marcus Meissner wrote: > On Fri, Aug 07, 2009 at 06:36:36PM -0700, chris ahrendt wrote: > >> [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd >> > > I do not fully understand the code (keep fd open to have to lock > existing?), but it is in a fatal exit path. > >> [../wine-git/tools/fnt2bdf.c:219]: (error) Resource leak: fp >> [../wine-git/tools/fnt2bdf.c:653]: (error) Resource leak: fd >> > > Fix submitted, seem necessary. > > >> [../wine-git/tools/fnt2fon.c:304]: (error) Memory leak: file_lens >> > > Fix submitted, but program is shortlived. > > >> [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a >> deallocated pointer: fd >> > > I do not understand what it mislikes about it. I think the detection > is wrong. > > >> [../wine-git/tools/winebuild/res16.c:187]: (error) Resource leak: fd >> > > Fix submitted. Small issue though. > > >> [../wine-git/tools/winedump/pe.c:1549]: (error) Memory leak: map >> > > Fix submitted. Small issue though. > > Ciao, Marcus > > > here is what its checking for : Standard checks that are always used * out of bounds * Using 'memfunc' on class * Using 'memfunc' on struct that contains a 'std::classname' * Class Base which is inherited by class Derived does not have a virtual destructor * Mismatching allocation and deallocation: varname * Memory leak <http://en.wikipedia.org/wiki/Memory_leak>: varname * Resource leak <http://en.wikipedia.org/wiki/Resource_leak>: varname * Deallocating a deallocated pointer: varname * Using 'varname' after it is deallocated / released * The given size sz is mismatching * Invalid radix in call to strtol <http://en.wikipedia.org/wiki/Strtol> or strtoul. Must be 0 or 2-36 * Overlapping data buffer varname * Unsigned division. The result will be wrong. * Unusual pointer arithmetic * Returning pointer to local array variable * Same iterator is used with both container1 and container2 * Dangerous usage of erase * After push_back or push_front, the iterator 'iterator_name' may be invalid * Wrong assignment of an auto-variable to an effective parameter of a function * Return of the address of an auto-variable * Division by zero * STL <http://en.wikipedia.org/wiki/Standard_Template_Library>: check usage of iterators after erase, as erase invalidates the iterator * STL: check usage of iterators and pointers after push_back and push_front. If using a vector the iterator or pointer may become invalid. * STL: Range checks with iterators should use != instead of < I have not run it with the following : Extra checks that you enable with "--all" These checks are not part of the standard checking because they produce false positives. * Array index out of bounds * Buffer overrun * Dangerous usage of strncat <http://en.wikipedia.org/wiki/Strcat>, possible buffer overrun * Memory leak: varname * The size argument is given as a char constant Extra checks that you enable with "--style" * The class 'classname' has no constructor * Member variable not initialized in the constructor 'classname::varname' * Unused private function 'classname::funcname' * 'operator=' should return something * C-style pointer casting * Redundant condition. It is safe to deallocate a NULL pointer * Redundant condition. The remove function in the STL will not do anything if element doesn't exist * Found redundant if condition - 'if (condition);' * struct or union member 'structname::varname' is never used * Function parameter 'parname' is passed by value. It could be passed by reference instead. * Redundant code: Found a statement that begins with type constant * Warning - using char variable as array index * Warning - using char variable in bit operation * Condition is always truefalse Checks that are enabled when both "--all" and "--style" is given * Warning: Division with signed and unsigned operators When giving "--unused-functions" * The function 'funcname' is never used I am going to start running with the --all flag going forward. So the leak with fd cppcheck thinks that you have an exit path that will leave the fd allocated still without freeing the resource. [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd so this exits without freeing the resource. [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd - This just means your freeing an already freed resource... This is more of a warning than anything Chris

1 0

re: DxDiag Demo Patch
by Dan Kegel 08 Aug '09

08 Aug '09

Henri wrote: > However, what really needs clarification is the copyright status of this. The web page about the project http://kegel.com/wine/sweng/2009/ makes it clear that the work had to be LGPL, and the students were fine with that. The final presentation about that code, http://kegel.com/wine/sweng/2009/dxdiag_presentation.ppt says "Features: ... Now free and open source Previous implementation was owned by Microsoft Could not ship with Wine" so they understood that they were writing free software that would ship with wine. The authors, according to that presentation, are Allen Hair, Brian Nguyen, David Woo, David Hwang, Linh Pham, and Edward Chang. I'm pretty sure it's ok to merge. - Dan

1 0

Re: [1/3] winex11.drv: Support KEYEVENTF_UNICODE in SendInput
by Vitaliy Margolen 08 Aug '09

08 Aug '09

Andrew Eikum wrote: > --- Why did you swapped setting internal key state and calling hook in X11DRV_send_keyboard_input()? Do you have a test to check that state is being updated _before_ calling hook, and not after? Vitaliy.

2 2

Crash in riched20 caused by cryptui
by Juan Lang 07 Aug '09

07 Aug '09

Hi Dylan, I wonder if you might be able to shed insight into this. cryptui uses riched20 to display some text, and inserting an icon into a richedit control causes a crash: Assertion failed: (~para->member.para.nFlags & MEPF_REWRAP), function ME_GetCursorCoordinates, file caret.c, line 183. If I comment out the assertion, the icon gets displayed, a little offset from where I expected it, but no other crashes appear. I'm inserting the icon with: IRichEditOle_InsertObject(richEditOle, &reObject); (in cryptui's main.c.) The call stack isn't all that interesting, so I followed the call flow a little by hand. IRichEditOle_InsertObject is a wrapper that calls IRichEditOle_fnInsertObject. This calls ME_InsertOLEFromCursor, which calls ME_InternalInsertTextFromCursor. This calls ME_InsertRunAtCursor. ME_InsertRunAtCursor sets the MEPF_REWRAP flag: cursor->pPara->member.para.nFlags |= MEPF_REWRAP; which, I believe, is what leads to the assertion. Might you shed some insight into what the assertion is protecting against, or better yet how I might avoid it? If you have any interest in looking at it, I can send you a small .c file with instructions on how to reproduce the crash. Thanks, --Juan

1 0

Re: winemp3: a fix for security alert CVE-2006-1655
by Juan Lang 07 Aug '09

07 Aug '09

Hi Aric, I'm not trying to correct you here, I just don't understand a comment, so I'm asking for clarification: + int idx; + if(sfb > 21) return; /* similarity fix related to CVE-2006-1655 */ What is a "similarity fix"? Or did you mean "similar to fix for CVE..." instead? Thanks, --Juan

2 2

Re: [3/3] user32/tests: Add tests for SendInput with unicode
by Dmitry Timoshkov 07 Aug '09

07 Aug '09

"Andrew Eikum" <aeikum(a)codeweavers.com> wrote: > --- > dlls/user32/tests/input.c | 210 > +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 210 insertions(+), 0 deletions(-) It would be more natural and would simplify the code to add these tests to msg.c. Also, please try to avoid names like g_keyStatus, lastKeyDown, UnicodeWndProc and similar. key_status, last_key_down, unicode_wnd_proc look much more readable. -- Dmitry.

2 1

Re: secur32: Implement QueryContextAttributes for SECPKG_ATTR_CONNECTION_INFO
by Henri Verbeet 07 Aug '09

07 Aug '09

2009/8/7 Juan Lang <juan.lang(a)gmail.com>: >+ return SEC_E_UNSUPPORTED_FUNCTION; Is this return value intentional?

2 1

Re: [PATCH 3/5] wined3d: Merge the context->current_rt check for rendertarget readback with the code above.
by Stefan Dösinger 07 Aug '09

07 Aug '09

Am Friday 07 August 2009 08:51:20 schrieb Henri Verbeet: > - * 3) lastActiveRenderTarget != target && oldTid != newTid: > - * This is tricky. We have to get a context with the old drawable I don't see anything wrong with this patch in particular(so go ahead and apply it), but I am wondering how the case of switching the render target from a new thread works with the new TLS-based context management. My guess is that the problem is not applicable any longer, since there isn't really such a thing as thread switching any more. Its just a new render target for the other thread. Is that right? Or are there any other considerations for this case? Now it hurts that I didn't write a test for this special case when I fixed it a while ago - I don't even remember which game triggered it - maybe Age of Empires 3, but I am not sure.

2 1

Re: comctl32: fix pressed button theming
by Dmitry Timoshkov 07 Aug '09

07 Aug '09

"André Hentschel" <nerv(a)dawncrow.de> wrote: > --- a/dlls/comctl32/theme_button.c > +++ b/dlls/comctl32/theme_button.c > @@ -30,8 +30,22 @@ > #include "uxtheme.h" > #include "tmschema.h" > #include "comctl32.h" > +#include "wine/winuser16.h" I very much doubt that win16 apps have an idea about theming, or BM_SETSTATE16 is supposed to be handled by comctl32. -- Dmitry.

1 0

Re: [lostwages] Set about page to use h3 instead of h2 as text is too large
by Yuri Khan 07 Aug '09

07 Aug '09

On Thu, Aug 6, 2009 at 19:50, Scott Ritchie<scott(a)open-vote.org> wrote: > -<h2>Open Source and User Driven</h2> > +<h3>Open Source and User Driven</h3> Font size is not a valid excuse for skipping heading levels. Presentation issues should be handled in CSS.

2 1

Request for vista testing
by Mike Kaplinskiy 07 Aug '09

07 Aug '09

Can someone test this on vista? It tests NtCancelIoFileEx. The goal is to find out the order of arguments. Thanks, Mike.

1 0

Re: kernel32/nls/winerr: Add Russian translation [try 2]
by Dmitry Timoshkov 07 Aug '09

07 Aug '09

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Thanks for suggestions. > > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc Please stop. This is not a translation. I'd suggest to stop accepting your other "translations" and patches as well. -- Dmitry.

1 0

Re: [1/2] shdocvw: Added support for IAdviseSink (resend)
by Alistair Leslie-Hughes 06 Aug '09

06 Aug '09

Hi, Could I get some feedback on this patch please? Best Regards Alistair Leslie-Hughes Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > shdocvw: Added support for IAdviseSink > > Best Regards > Alistair Leslie-Hughes > >

2 1

Re: [6/8] WineD3D: Return a different success value if D3D is not available
by Henri Verbeet 06 Aug '09

06 Aug '09

Aside from the fact that you can't know WineDirect3DCreate() failed because of a lack of OpenGL without looking at its implementation, I liked the create flags approach better.

2 7

Re: kernel32/nls/winerror: Add Russian translation
by Frédéric Delanoy 06 Aug '09

06 Aug '09

2009/8/6 Vladimir Pankratov <scriptkid(a)mail.ru>: > Hello all. > > Added Russian translation. > > Changed files: > > dlls/kernel32/nls/winerror_rus.mc > dlls/kernel32/Makefile.in > > Thanks. Message id 1221 is missing. File changed/created is winerr_rus.mc, not winerror_rus.mc BTW

1 1

Re: kernel32: Revise SetThreadIdealProcessor to return success.
by Alexandre Julliard 06 Aug '09

06 Aug '09

Andrew Nguyen <arethusa26(a)gmail.com> writes: > The image deblurring tool in bug 19548 tries to use > SetThreadIdealProcessor on multi-core systems and checks the result of > the call, which causes the application to fail. Simply reporting > success in this case allows the application to run, and is perfectly > harmless. It breaks the tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/nls/winerror: Add Russian translation
by Dmitry Timoshkov 06 Aug '09

06 Aug '09

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Added Russian translation. > > Changed files: > > dlls/kernel32/nls/winerror_rus.mc > dlls/kernel32/Makefile.in What's the point in resending the same version of the patch again and again without even answering the questions, or addressing the pointed out problems? Again, this is not a translation. -- Dmitry.

1 0

configure can't find libgsm development files, but they are installed
by Rosanne DiMesio 06 Aug '09

06 Aug '09

Since yesterday, configure has been giving me a "libgsm development files not found" warning even though they are installed on my system. This is on openSUSE 11.1, 32 bit. Is anyone else seeing this, or is something borked on my system? (Any hints as to where I might look would be appreciated.) -- Rosanne DiMesio <dimesio(a)earthlink.net>

2 3

Re: comctl32: Changed the assembly and manifest file names to mixed-case as in Windows
by Alexandre Julliard 06 Aug '09

06 Aug '09

Paul Chitescu <paulc(a)voip.null.ro> writes: > Changelog: > comctl32: Changed the assembly and manifest file names to mixed-case as in > Windows > > The MSDN says that several tools handle assembly names as case sensitive. > > Furthermore, trying to open the manifest file with wrong case can fail or take > a long time on case sensitive filesystems (pretty much all used with wine). That's OK for the assembly name, but the filenames on Vista are all lowercase too, I'm not sure we want to change that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Begin Wine Development
by Alexandros Dermenakis 06 Aug '09

06 Aug '09

Hi to everyone, I'm a software developer interested in contributing to wine. Can you guide a bit with the process? How do you become a member and get a account to submit code to the git repository? How do you get tickets with your tasks? Thanks

3 2

Re: [3/3] advapi32: Add tests for LsaLookupNames2.
by Alexandre Julliard 06 Aug '09

06 Aug '09

Hans Leidekker <hans(a)codeweavers.com> writes: > diff --git a/dlls/advapi32/tests/lsa.c b/dlls/advapi32/tests/lsa.c > index e69e4e1..991b06b 100644 > --- a/dlls/advapi32/tests/lsa.c > +++ b/dlls/advapi32/tests/lsa.c It doesn't work here: ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so lsa.c && touch lsa.ok lsa.c:314: Test failed: expected 0, got 0x00640072 make[2]: *** [lsa.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine.inf: Add the HKCU\Volatile Environment\APPDATA value.
by Alexandre Julliard 06 Aug '09

06 Aug '09

Andrew Nguyen <arethusa26(a)gmail.com> writes: > The VirtuaGirl installer explicitly queries for the APPDATA value > under HKCU\Volatile Environment. This most likely needs to be a volatile key created at startup. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Latency as of yesterday
by Susan Cragin 06 Aug '09

06 Aug '09

Current Ubuntu sound bugs relating to wine OSS 409395. ALSA 407970 -----I got this response on the Ubuntu list------ This is probably due to a libasound2-plugins and pulseaudio/rtkit skew; the latest libasound2-plugins needs at least pulseaudio 1:0.9.16~test3 and rtkit 0.3. Karmic has an older version of pulseaudio (1:0.9.15) at the moment. -------------------------------------------------------------- After further checking I determined that the current kernel changes are supposed to make the regular kernel capable of running at real-time (right now, for outgoing sound only) by activating a switch on the regular kernel. This functionality, of course, needs pulseaudio. Despite the optimism expressed above, pulseaudio 1:0.9016~test4 and the latest rtkit did not solve my problem. Wine still has no functioning sound. Stay tuned.

1 0

Re: mshtml: Implement IHTMLStyle4 get/put textOverflow
by Alistair Leslie-Hughes 06 Aug '09

06 Aug '09

Forget this patch, missed the todo_wine "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:4A7AA9A2.9060301@hotmail.com... > Hi, > > Changelog: > mshtml: Implement IHTMLStyle4 get/put textOverflow > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From 4f121dd9918252af3f1a46eeb1c1826a4830d0a8 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 18 Feb 2009 22:43:39 +1100 > Subject: [PATCH] Implement IHTMLStyle4 get/put textOverflow > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/htmlstyle.c | 3 +++ > dlls/mshtml/htmlstyle.h | 1 + > dlls/mshtml/htmlstyle3.c | 18 ++++++++++++++---- > dlls/mshtml/tests/dom.c | 30 ++++++++++++++++++++++++++++++ > 4 files changed, 48 insertions(+), 4 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index f036077..82ddf58 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -111,6 +111,8 @@ static const WCHAR attrTextAlign[] = > {'t','e','x','t','-','a','l','i','g','n',0}; > static const WCHAR attrTextDecoration[] = > {'t','e','x','t','-','d','e','c','o','r','a','t','i','o','n',0}; > +static const WCHAR attrTextOverflow[] = > + {'t','e','x','t','-','o','v','e','r','f','l','o','w',0}; > static const WCHAR attrTop[] = > {'t','o','p',0}; > static const WCHAR attrVerticalAlign[] = > @@ -166,6 +168,7 @@ static const struct{ > {attrPosition, DISPID_IHTMLSTYLE2_POSITION}, > {attrTextAlign, DISPID_IHTMLSTYLE_TEXTALIGN}, > {attrTextDecoration, DISPID_IHTMLSTYLE_TEXTDECORATION}, > + {attrTextOverflow, DISPID_IHTMLSTYLE4_TEXTOVERFLOW}, > {attrTop, DISPID_IHTMLSTYLE_TOP}, > {attrVerticalAlign, DISPID_IHTMLSTYLE_VERTICALALIGN}, > {attrVisibility, DISPID_IHTMLSTYLE_VISIBILITY}, > diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h > index 307824e..b6bdcab 100644 > --- a/dlls/mshtml/htmlstyle.h > +++ b/dlls/mshtml/htmlstyle.h > @@ -73,6 +73,7 @@ typedef enum { > STYLEID_POSITION, > STYLEID_TEXT_ALIGN, > STYLEID_TEXT_DECORATION, > + STYLEID_TEXT_OVERFLOW, > STYLEID_TOP, > STYLEID_VERTICAL_ALIGN, > STYLEID_VISIBILITY, > diff --git a/dlls/mshtml/htmlstyle3.c b/dlls/mshtml/htmlstyle3.c > index 505e91e..84b914b 100644 > --- a/dlls/mshtml/htmlstyle3.c > +++ b/dlls/mshtml/htmlstyle3.c > @@ -399,15 +399,25 @@ static HRESULT WINAPI HTMLStyle4_Invoke(IHTMLStyle4 > *iface, DISPID dispIdMember, > static HRESULT WINAPI HTMLStyle4_put_textOverflow(IHTMLStyle4 *iface, BSTR > v) > { > HTMLStyle *This = HTMLSTYLE4_THIS(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); > - return E_NOTIMPL; > + static const WCHAR styleEllipsis[] = > {'e','l','l','i','p','s','i','s',0}; > + static const WCHAR styleClip[] = {'c','l','i','p',0}; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + > + /* textOverflow can only be one of the following */ > + if(!v || strcmpiW(styleEllipsis, v) == 0 || strcmpiW(styleClip, v) > == 0) > + { > + return set_nsstyle_attr(This->nsstyle, STYLEID_TEXT_OVERFLOW, v, > 0); > + } > + > + return E_INVALIDARG; > } > > static HRESULT WINAPI HTMLStyle4_get_textOverflow(IHTMLStyle4 *iface, BSTR > *p) > { > HTMLStyle *This = HTMLSTYLE4_THIS(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, p); > + return get_nsstyle_attr(This->nsstyle, STYLEID_TEXT_OVERFLOW, p); > } > > static HRESULT WINAPI HTMLStyle4_put_minHeight(IHTMLStyle4 *iface, VARIANT > v) > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 4846848..1d283e4 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -2654,6 +2654,8 @@ static void test_style4(IHTMLStyle4 *style4) > HRESULT hres; > VARIANT v; > VARIANT vdefault; > + BSTR sdefault; > + BSTR str; > > hres = IHTMLStyle4_get_minHeight(style4, &vdefault); > ok(hres == S_OK, "get_minHeight failed: %08x\n", hres); > @@ -2672,6 +2674,34 @@ static void test_style4(IHTMLStyle4 *style4) > hres = IHTMLStyle4_put_minHeight(style4, vdefault); > ok(hres == S_OK, "put_minHeight failed: %08x\n", hres); > VariantClear(&vdefault); > + > + /* textOverflow */ > + hres = IHTMLStyle4_get_textOverflow(style4, &sdefault); > + ok(hres == S_OK, "get_minHeight failed: %08x\n", hres); > + > + str = a2bstr("invalid"); > + hres = IHTMLStyle4_put_textOverflow(style4, str); > + ok(hres == E_INVALIDARG, "put_textOverflow passed: %08x\n", hres); > + SysFreeString(str); > + > + str = a2bstr("ellipsis"); > + hres = IHTMLStyle4_put_textOverflow(style4, str); > + ok(hres == S_OK, "put_textOverflow failed: %08x\n", hres); > + SysFreeString(str); > + > + str = a2bstr("clip"); > + hres = IHTMLStyle4_put_textOverflow(style4, str); > + ok(hres == S_OK, "put_textOverflow failed: %08x\n", hres); > + SysFreeString(str); > + > + hres = IHTMLStyle4_get_textOverflow(style4, &str); > + ok(hres == S_OK, "get_textOverflow failed: %08x\n", hres); > + todo_wine ok( !strcmp_wa(str, "clip"), "expect clip got (%s)\n", > dbgstr_w(str)); > + SysFreeString(str); > + > + hres = IHTMLStyle4_put_textOverflow(style4, sdefault); > + ok(hres == S_OK, "put_textOverflow failed: %08x\n", hres); > + SysFreeString(sdefault); > } > > static void test_default_style(IHTMLStyle *style) > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Re: [7/8] WineD3D: Catch invalid getDC calls in d3d9
by Henri Verbeet 06 Aug '09

06 Aug '09

I don't feel very strong about this, but perhaps this should be handled by the format info table (in combination with the create flag).

2 2

Re: gdi32: Fix the type of a few return values.
by Michael Stefaniuc 06 Aug '09

06 Aug '09

Hello Andrew, Andrew Nguyen wrote: > It does not make sense to return a boolean for a pointer type. > diff --git a/dlls/gdi32/opengl.c b/dlls/gdi32/opengl.c > index 022fc2c..204fc2b 100644 > --- a/dlls/gdi32/opengl.c > +++ b/dlls/gdi32/opengl.c > @@ -168,7 +168,7 @@ static HDC WINAPI wglGetPbufferDCARB(void *pbuffer) > > TRACE("(%p)\n", pbuffer); > > - if (!dc) return FALSE; > + if (!dc) return 0; > > /* The display driver has to do the rest of the work because > * we need access to lowlevel datatypes which we can't access here > @@ -338,7 +338,7 @@ PROC WINAPI wglGetProcAddress(LPCSTR func) > > /* Retrieve the global hDC to get access to the driver. */ > dc = OPENGL_GetDefaultDC(); > - if (!dc) return FALSE; > + if (!dc) return NULL; > > if (!dc->funcs->pwglGetProcAddress) FIXME(" :stub\n"); > else ret = dc->funcs->pwglGetProcAddress(func); any reason why you use both "0" and "NULL" to represent a null pointer? For consistency sake just pick one. thanks bye michael

1 0

Re: [Bug 19522] Team Fortress 2 (TF2) missing menu fonts
by Vitaliy Margolen 06 Aug '09

06 Aug '09

> --- Comment #3 from Alexandre Julliard <julliard at winehq.org> 2009-08-04 13:19:16 --- > Please don't suggest that people use the --enable-maintainer-mode flag, that's > not meant for normal users. > Then how can we be sure user have all requirements installed? --verbose doesn't complain about everything which makes it kind of useless. Vitaliy.

2 1

Re: [4/8] WineD3D: Set the default psizemin in d3d8, avoid the version check
by Henri Verbeet 06 Aug '09

06 Aug '09

I think the create flags would be more robust here.

1 0

Re: [3/8] WineD3D: Get rid of a version check
by Henri Verbeet 06 Aug '09

06 Aug '09

2009/8/5 Stefan Dösinger <stefan(a)codeweavers.com>: > +void fixup_caps(WINED3DCAPS *pWineCaps) > +{ > + /* D3D8 doesn't support SM 2.0 or higher, so clamp to 1.x */ > + if(pWineCaps->PixelShaderVersion > D3DPS_VERSION(1,4)){ > + pWineCaps->PixelShaderVersion = D3DPS_VERSION(1,4); > + } > + if(pWineCaps->VertexShaderVersion > D3DVS_VERSION(1,1)){ > + pWineCaps->VertexShaderVersion = D3DVS_VERSION(1,1); > + } > + pWineCaps->MaxVertexShaderConst = min(D3D8_MAX_VERTEX_SHADER_CONSTANTF, pWineCaps->MaxVertexShaderConst); > + > + pWineCaps->StencilCaps &= ~WINED3DSTENCILCAPS_TWOSIDED; > +} Please use proper white space and naming conventions. I could live with the missing space between the control statement and the brace, if you really prefer that, but at least put *some* sort of whitespace between the closing brace and the accolade. And "pWineCaps" is just horrible.

1 0

Re: Interesting find with cppcheck..
by chris ahrendt 06 Aug '09

06 Aug '09

Austin English wrote: > On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang<juan.lang(a)gmail.com> wrote: > >>> If the group wants I can run this daily when I run wine test as well.. >>> and post it here.... just let me know >>> >> Probably not. Most of the remaining leaks are in the tests or the >> tools. Since these are short-lived programs, the leaks will get >> plugged as soon as the programs end anyway. The only exception is the >> ntdll one, and it only happens when ntdll can't connect to the >> wineserver, and the process is dying anyway. >> > > Still wouldn't hurt to fix them. > > It may not be worth running daily, but perhaps weekly and see if > anything new pops up. > > Ok will run it weekly then on fridays or want me to do it on major release's? chris

3 2

Latency as of yesterday
by Susan Cragin 06 Aug '09

06 Aug '09

I got a new kernel and a new git yesterday. One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. 2.6.31-5-generic is the new kernel. Just for "fun" I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. Susan (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.)

3 2

Re: Interesting find with cppcheck..
by chris ahrendt 05 Aug '09

05 Aug '09

Scott Ritchie wrote: > chris ahrendt wrote: > >> Austin English wrote: >> >>> On Tue, Aug 4, 2009 at 2:07 PM, Juan Lang<juan.lang(a)gmail.com> wrote: >>> >>> >>>>> If the group wants I can run this daily when I run wine test as well.. >>>>> and post it here.... just let me know >>>>> >>>>> >>>> Probably not. Most of the remaining leaks are in the tests or the >>>> tools. Since these are short-lived programs, the leaks will get >>>> plugged as soon as the programs end anyway. The only exception is the >>>> ntdll one, and it only happens when ntdll can't connect to the >>>> wineserver, and the process is dying anyway. >>>> >>>> >>> Still wouldn't hurt to fix them. >>> >>> It may not be worth running daily, but perhaps weekly and see if >>> anything new pops up. >>> >>> >>> >> Ok will run it weekly then on fridays or want me to do it on major >> release's? >> >> chris >> >> > > How about just before major releases? ;) > > Thanks, > Scott Ritchie > > > Ok what I will try and do is when . releases go out I will run them and post the results here.... chris

1 0

Re: Latency as of yesterday
by Susan Cragin 05 Aug '09

05 Aug '09

>>> I got a new kernel and a new git yesterday. >>> One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. >>> 2.6.31-5-generic is the new kernel. >>> Just for "fun" I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. >>> I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. >>> Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. >>> Susan >>> >> >>Ubuntu has bugs open for sound issues with the newer kernels. >> >>> (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.) >> >>Is there a bug logged for this? > >Yes and yes. >I looked at the bunch of Ubuntu bugs relating to sound with the newest kernel. There was nothing right on point, so I filed on of my own. >409395. >The alsa bug is: >407970 > >Bottom line -- no working sound in wine right now, that I can figure out. At all. > >In addition, purging pulseaudio has just gotten much more difficult, as of the last couple of days. I tried yesterday. Directions that worked 2 weeks ago now cause desktop to be removed. (I had to re-install system.) The problem has been identified. Stay tuned. > >This is probably due to a libasound2-plugins and pulseaudio/rtkit >skew; the latest libasound2-plugins needs at least pulseaudio >1:0.9.16~test3 and rtkit 0.3. Karmic has an older version of >pulseaudio (1:0.9.15) at the moment. >

1 0

Re: Latency as of yesterday
by Susan Cragin 05 Aug '09

05 Aug '09

>Susan Cragin wrote: >> I got a new kernel and a new git yesterday. >> One of them is causing massive latency in my sound system. I looked at the changes to git that were made yesterday, and suspect that the latency came with the kernel. >> 2.6.31-5-generic is the new kernel. >> Just for "fun" I reinstalled my entire system this morning, and the latency is the same, so it is not due to any tweaks I have made. >> I have been running using winecfg's oss sound and padsp for a week or so. It had been working fairly well. >> Anyway, before I file a bug on Ubuntu against the kernel, I thought I would ask if yesterday's git might be at fault. I don't have time to do regression testing before Friday, but I will do it if needed. >> Susan >> > >Ubuntu has bugs open for sound issues with the newer kernels. > >> (Separate issue -- I have not been able to run dragon NaturallySpeaking with alsa for several months. Timeout issues during training.) > >Is there a bug logged for this? Yes and yes. I looked at the bunch of Ubuntu bugs relating to sound with the newest kernel. There was nothing right on point, so I filed on of my own. 409395. The alsa bug is: 407970 Bottom line -- no working sound in wine right now, that I can figure out. At all. In addition, purging pulseaudio has just gotten much more difficult, as of the last couple of days. I tried yesterday. Directions that worked 2 weeks ago now cause desktop to be removed. (I had to re-install system.)

1 0

Re: comdlg32: fix problems in calculation of the size of a file dialog. (try 2)
by Alexandre Julliard 05 Aug '09

05 Aug '09

Rein Klazes <wijn(a)online.nl> writes: > fixes bug#17748 > > try 2: I forgot adding the rc file. It doesn't work here: ../../../tools/runtest -q -P wine -M comdlg32.dll -T ../../.. -p comdlg32_test.exe.so filedlg.c && touch filedlg.ok filedlg.c:352: Test failed: testid 0: dialog should not have a WS_SIZEBOX style. filedlg.c:352: Test failed: testid 1: dialog should not have a WS_SIZEBOX style. make[2]: *** [filedlg.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

re: cmd: add initial ipconfig
by Dan Kegel 05 Aug '09

05 Aug '09

Isn't ipconfig supposed to be external? This change won't help any app that tries to run ipconfig.exe... - Dan

1 0

golly, mime type integration DOES work...
by Dan Kegel 05 Aug '09

05 Aug '09

I installed Visual Studio 2005 a while ago and forgot about it. Tonight I downloaded the C test case for bug 19561 in chrome -- and dang if Visual Studio didn't open and display the source file. Repainting after scrolling was a bit lazy, and creating a new project still requires ie6, but it was a nice surprise all the same.

3 3

Re: Interesting find with cppcheck..
by chris ahrendt 05 Aug '09

05 Aug '09

Juan Lang wrote: > Hi Chris, > > >> [../wine-git/dlls/crypt32/rootstore.c:346]: (error) Resource leak: dir >> > > I just sent a patch to fix this. Thanks! > --Juan > > > If the group wants I can run this daily when I run wine test as well.. and post it here.... just let me know Chris

6 6

Re: shlwapi: Correct AssocCreate Tests
by Michael Stefaniuc 05 Aug '09

05 Aug '09

Hello Alistair, Alistair Leslie-Hughes wrote: > diff --git a/dlls/shlwapi/tests/assoc.c b/dlls/shlwapi/tests/assoc.c > index fd2b868..9a52edb 100644 > --- a/dlls/shlwapi/tests/assoc.c > +++ b/dlls/shlwapi/tests/assoc.c > @@ -252,11 +252,13 @@ static void test_assoc_create(void) > ok(hr == E_INVALIDARG, "Unexpected result : %08x\n", hr); > > hr = pAssocCreate(CLSID_QueryAssociations, &IID_NULL, (LPVOID*)&pqa); > - ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL /* win98 */ > + ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL || /* win98 */ > + hr == E_NOINTERFACE > , "Unexpected result : %08x\n", hr); this looks ugly; the 2 lines can be joined into one without exceeding 80 chars in width. > > hr = pAssocCreate(IID_NULL, &IID_IQueryAssociations, (LPVOID*)&pqa); > - ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL /* win98 */ > + ok(hr == CLASS_E_CLASSNOTAVAILABLE || hr == E_NOTIMPL || /* win98 */ > + hr == E_INVALIDARG > , "Unexpected result : %08x\n", hr); Same here. > hr = pAssocCreate(CLSID_QueryAssociations, &IID_IQueryAssociations, (LPVOID*)&pqa); bye michael

1 0

Re: [5/5] WineD3D: Replace the dxVersion with behavior flags
by Henri Verbeet 05 Aug '09

05 Aug '09

The idea is good, but this needs to be split up.

2 2

Wineboot crashes after upgrading Gecko.
by Nikolay Sivov 05 Aug '09

05 Aug '09

Hi. After upgrading to Wine-gecko 1.0.0 I've got a wineboot crashes on initial .wine directory creation (log attached). Removing cab throws a message about missed gecko engine and no crash occurred. What is it about? wine: created the configuration directory '/home/mrlarch/.wine' fixme:system:SetProcessDPIAware stub! fixme:dwmapi:DwmIsCompositionEnabled 0x33cf94 fixme:file:MoveFileWithProgressW MOVEFILE_WRITE_THROUGH unimplemented fixme:advapi:SetNamedSecurityInfoW L"C:\\windows\\system32\\gecko\\1.0.0\\wine_gecko\\components\\xpti.dat" 1 536870916 (nil) (nil) 0x1d3ca4 (nil) fixme:iphlpapi:NotifyAddrChange (Handle 0x631e918, overlapped 0x631e920): stub fixme:iphlpapi:GetAdaptersAddresses no support for IPv6 addresses fixme:file:MoveFileWithProgressW MOVEFILE_WRITE_THROUGH unimplemented fixme:advapi:SetNamedSecurityInfoW L"C:\\windows\\system32\\gecko\\1.0.0\\wine_gecko\\components\\compreg.dat" 1 536870916 (nil) (nil) 0x1ec5dc4 (nil) fixme:shell:DllCanUnloadNow stub wine: Unhandled page fault on read access to 0x019e501d at address 0x19e501d (thread 0013), starting debugger... First chance exception: page fault on read access to 0x7db84ab5 in 32-bit code (0x7db84ab5). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7db84ab5 ESP:0621b5e0 EBP:0621b698 EFLAGS:00010246( R- -- I Z- -P- ) EAX:ffffffff EBX:7db8b244 ECX:00000000 EDX:00000002 ESI:00000001 EDI:01cb1920 Stack dump: 0x0621b5e0: 01cb1920 00000001 ffffffff 00000000 0x0621b5f0: 00000000 00000000 00000000 00000000 0x0621b600: 00000000 00000000 00000000 00000000 0x0621b610: 7db8d890 7db89b71 7db88ba8 00000000 0x0621b620: 00000000 00000000 00000000 00000000 0x0621b630: 00000000 00000000 000001f4 00000000 Backtrace: =>0 0x7db84ab5 (0x0621b698) 1 0x019e79f6 (0x0621e778) 2 0x019dc01e (0x0621e798) 3 0x00699e7d (0x0621e7c8) 4 0x0069a9eb (0x0621e818) 5 0x0069a515 (0x0621e838) 6 0x011ea5b6 (0x0621e8b8) 7 0x011a3591 (0x0621e8e8) 8 0x0069a638 (0x0621e958) 9 0x011ea675 (0x0621e9d8) 10 0x011a3591 (0x0621ea08) 11 0x011e9b46 (0x0621ea68) 12 0x019dfdbb (0x0621ea88) 13 0x019e303c (0x0621eaa8) 14 0x7efbb368 call_thread_func+0xc() in ntdll (0x0621eab8) 15 0x7efbb570 call_thread_entry_point+0x70(entry=0x19e301f, arg=0x1cafc30) [/home/mrlarch/wine-git/dlls/ntdll/signal_i386.c:2301] in ntdll (0x0621eb88) 16 0x7efc4d5f start_thread+0xef(info=0x7ffd0fb8) [/home/mrlarch/wine-git/dlls/ntdll/thread.c:439] in ntdll (0x0621f3c8) 17 0xb7daf4c0 start_thread+0xc0() in libpthread.so.0 (0x0621f4c8) 18 0xb7d2d6de __clone+0x5e() in libc.so.6 (0x00000000) 0x7db84ab5: -- no code accessible -- Modules: Module Address Debug info Name (111 modules) ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7d89a000-7d8ae000 Deferred dwmapi<elf> \-PE 7d8a0000-7d8ae000 \ dwmapi ELF 7d978000-7db04000 Deferred shell32<elf> \-PE 7d990000-7db04000 \ shell32 ELF 7db04000-7db22000 Deferred advpack<elf> \-PE 7db10000-7db22000 \ advpack ELF 7db43000-7db61000 Deferred iphlpapi<elf> \-PE 7db50000-7db61000 \ iphlpapi ELF 7dcf5000-7dd17000 Deferred mpr<elf> \-PE 7dd00000-7dd17000 \ mpr ELF 7dd17000-7dd6b000 Deferred wininet<elf> \-PE 7dd20000-7dd6b000 \ wininet ELF 7dd6b000-7ddaf000 Deferred urlmon<elf> \-PE 7dd70000-7ddaf000 \ urlmon ELF 7ddaf000-7dde1000 Deferred uxtheme<elf> \-PE 7ddc0000-7dde1000 \ uxtheme ELF 7dde1000-7de3e000 Deferred shlwapi<elf> \-PE 7ddf0000-7de3e000 \ shlwapi ELF 7de3e000-7df05000 Deferred comctl32<elf> \-PE 7de50000-7df05000 \ comctl32 ELF 7df05000-7df2a000 Deferred msvfw32<elf> \-PE 7df10000-7df2a000 \ msvfw32 ELF 7df2a000-7df75000 Deferred dsound<elf> \-PE 7df30000-7df75000 \ dsound ELF 7df75000-7dfe5000 Deferred quartz<elf> \-PE 7df80000-7dfe5000 \ quartz ELF 7dfe5000-7dff9000 Deferred midimap<elf> \-PE 7dff0000-7dff9000 \ midimap ELF 7dff9000-7e010000 Deferred msacm32<elf> \-PE 7e000000-7e010000 \ msacm32 ELF 7e040000-7e127000 Deferred oleaut32<elf> \-PE 7e060000-7e127000 \ oleaut32 ELF 7e127000-7e220000 Deferred ole32<elf> \-PE 7e140000-7e220000 \ ole32 ELF 7e220000-7e2bb000 Deferred winmm<elf> \-PE 7e230000-7e2bb000 \ winmm ELF 7e2bb000-7e2e0000 Deferred msacm32<elf> \-PE 7e2c0000-7e2e0000 \ msacm32 ELF 7e2e8000-7e2fc000 Deferred avicap32<elf> \-PE 7e2f0000-7e2fc000 \ avicap32 ELF 7e2fc000-7e31c000 Deferred devenum<elf> \-PE 7e300000-7e31c000 \ devenum ELF 7e31c000-7e384000 Deferred libgcrypt.so.11 ELF 7e384000-7e388000 Deferred libgpg-error.so.0 ELF 7e388000-7e398000 Deferred libtasn1.so.3 ELF 7e398000-7e3ac000 Deferred libresolv.so.2 ELF 7e3ac000-7e3af000 Deferred libkeyutils.so.1 ELF 7e3af000-7e3e1000 Deferred libcrypt.so.1 ELF 7e3e1000-7e47e000 Deferred libgnutls.so.26 ELF 7e47e000-7e4a2000 Deferred libk5crypto.so.3 ELF 7e4a2000-7e536000 Deferred libkrb5.so.3 ELF 7e536000-7e560000 Deferred libgssapi_krb5.so.2 ELF 7e560000-7e596000 Deferred libcups.so.2 ELF 7e5a4000-7e5ad000 Deferred libxcursor.so.1 ELF 7e5ad000-7e5b2000 Deferred libxfixes.so.3 ELF 7e5b2000-7e5b5000 Deferred libxcomposite.so.1 ELF 7e5b5000-7e5bb000 Deferred libxrandr.so.2 ELF 7e5bb000-7e5c4000 Deferred libxrender.so.1 ELF 7e5c4000-7e5c9000 Deferred libxxf86vm.so.1 ELF 7e5c9000-7e5cc000 Deferred libxinerama.so.1 ELF 7e5cc000-7e5eb000 Deferred imm32<elf> \-PE 7e5d0000-7e5eb000 \ imm32 ELF 7e5eb000-7e5f0000 Deferred libxdmcp.so.6 ELF 7e5f0000-7e608000 Deferred libxcb.so.1 ELF 7e608000-7e60a000 Deferred libxcb-xlib.so.0 ELF 7e60a000-7e60d000 Deferred libxau.so.6 ELF 7e60d000-7e6fc000 Deferred libx11.so.6 ELF 7e6fc000-7e70a000 Deferred libxext.so.6 ELF 7e70a000-7e721000 Deferred libice.so.6 ELF 7e722000-7e72a000 Deferred libkrb5support.so.0 ELF 7e72a000-7e72d000 Deferred libcom_err.so.2 ELF 7e72f000-7e7cb000 Deferred winex11<elf> \-PE 7e740000-7e7cb000 \ winex11 ELF 7e7cb000-7e7f1000 Deferred libexpat.so.1 ELF 7e7f1000-7e81c000 Deferred libfontconfig.so.1 ELF 7e81c000-7e831000 Deferred libz.so.1 ELF 7e831000-7e8a6000 Deferred libfreetype.so.6 ELF 7e8a6000-7e8ae000 Deferred libsm.so.6 ELF 7e8b4000-7e920000 Deferred rpcrt4<elf> \-PE 7e8c0000-7e920000 \ rpcrt4 ELF 7e920000-7e933000 Deferred lz32<elf> \-PE 7e930000-7e933000 \ lz32 ELF 7e933000-7e94c000 Deferred version<elf> \-PE 7e940000-7e94c000 \ version ELF 7e94c000-7e9ec000 Deferred gdi32<elf> \-PE 7e960000-7e9ec000 \ gdi32 ELF 7e9ec000-7eb36000 Deferred user32<elf> \-PE 7ea10000-7eb36000 \ user32 ELF 7eb36000-7eb6b000 Deferred winspool<elf> \-PE 7eb40000-7eb6b000 \ winspool ELF 7eb6b000-7ebd9000 Deferred setupapi<elf> \-PE 7eb80000-7ebd9000 \ setupapi ELF 7ebd9000-7ec2e000 Deferred advapi32<elf> \-PE 7ebf0000-7ec2e000 \ advapi32 ELF 7ec2e000-7ec4c000 Deferred wineboot<elf> \-PE 7ec30000-7ec4c000 \ wineboot ELF 7ec4c000-7ec58000 Deferred libnss_files.so.2 ELF 7ec58000-7ec63000 Deferred libnss_nis.so.2 ELF 7ec63000-7ec7c000 Deferred libnsl.so.1 ELF 7ec7c000-7ec85000 Deferred libnss_compat.so.2 ELF 7edbf000-7ef2a000 Deferred kernel32<elf> \-PE 7ede0000-7ef2a000 \ kernel32 ELF 7ef2a000-7ef50000 Deferred libm.so.6 ELF 7ef50000-7f000000 Dwarf ntdll<elf> \-PE 7ef60000-7f000000 \ ntdll ELF b7c49000-b7c4d000 Deferred libdl.so.2 ELF b7c4d000-b7da8000 Export libc.so.6 ELF b7da9000-b7dc2000 Export libpthread.so.0 ELF b7dd0000-b7f0b000 Deferred libwine.so.1 ELF b7f0d000-b7f29000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000008 00000009 0 0000000a (D) C:\windows\system32\wineboot.exe 00000018 0 00000015 0 00000014 0 <== 00000013 0 0000000b 0 0000000c 0000001c 0 00000017 0 00000016 0 0000000e 0 0000000d 0 0000000f 00000010 0 Backtrace: =>0 0x7db84ab5 (0x0621b698) 1 0x019e79f6 (0x0621e778) 2 0x019dc01e (0x0621e798) 3 0x00699e7d (0x0621e7c8) 4 0x0069a9eb (0x0621e818) 5 0x0069a515 (0x0621e838) 6 0x011ea5b6 (0x0621e8b8) 7 0x011a3591 (0x0621e8e8) 8 0x0069a638 (0x0621e958) 9 0x011ea675 (0x0621e9d8) 10 0x011a3591 (0x0621ea08) 11 0x011e9b46 (0x0621ea68) 12 0x019dfdbb (0x0621ea88) 13 0x019e303c (0x0621eaa8) 14 0x7efbb368 call_thread_func+0xc() in ntdll (0x0621eab8) 15 0x7efbb570 call_thread_entry_point+0x70(entry=0x19e301f, arg=0x1cafc30) [/home/mrlarch/wine-git/dlls/ntdll/signal_i386.c:2301] in ntdll (0x0621eb88) 16 0x7efc4d5f start_thread+0xef(info=0x7ffd0fb8) [/home/mrlarch/wine-git/dlls/ntdll/thread.c:439] in ntdll (0x0621f3c8) 17 0xb7daf4c0 start_thread+0xc0() in libpthread.so.0 (0x0621f4c8) 18 0xb7d2d6de __clone+0x5e() in libc.so.6 (0x00000000) wine: configuration in '/home/mrlarch/.wine' has been updated.

3 3

Appdatabase racing and flightsim category
by Keith Muir 04 Aug '09

04 Aug '09

I submitted a list of flight sims for this category to Ken Sharp I notice the category has been updated with racing games but not flight anyone know what he did with my list Regards, Keith A-10 Aces high Air Attack Air warrrior II B-17 Flying Fortress Commanche 4 Condor Desert Fighters Enemy Engaged European Air War F-22 F-22 Lightning 3 F/A-18 Korea F/A-18 Operation Desert Storm F/A-18 PSF F16 Multi Role Fighter F22 Lightning 2 Falcon 4.0 Allied force Fighter Ace Fighter Squadron, Screaming Demons over Europe Flanker 2 Fly II Freespace 2 Gunship IL2 Sturmovik Independence war Independence war 2 Joint Strike Fighter - JSF jane's F-15 Janes FA-18 Janes's fighters anthology Janes's USAF LOMAC or lock on modern air combat Longbow 2 Micro Flight Mig 29 Fulcrum Pacific Fighters Red Baron 3D Red Baron II Rowan's Battle of Britain Sierra ProPilot Strike Fighters: Project 1 Tom Clancy's H.A.W. U.S. Navy Fighters Warbirds Warbirds 3

8 9

Re: cmd: add initial ipconfig
by Juan Lang 04 Aug '09

04 Aug '09

Hi Andre, ipconfig isn't a built-in command, as far as I know, it's a standalone utility (ipconfig.exe.) --Juan

1 0

Interesting find with cppcheck..
by chris ahrendt 04 Aug '09

04 Aug '09

I was working on something else and using cppcheck to make sure I was not having a memory leak and so forth and decided to try it on wine here is what is the results of the wine git tree : [../wine-git/dlls/crypt32/rootstore.c:346]: (error) Resource leak: dir [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream1 [../wine-git/dlls/msvcrt/tests/file.c:997]: (error) Resource leak: stream4 [../wine-git/dlls/msvcrt/tests/heap.c:424]: (error) Deallocating a deallocated pointer: mem [../wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [../wine-git/tools/fnt2bdf.c:219]: (error) Resource leak: fp [../wine-git/tools/fnt2bdf.c:653]: (error) Resource leak: fd [../wine-git/tools/fnt2fon.c:304]: (error) Memory leak: file_lens [../wine-git/tools/widl/write_msft.c:2540]: (error) Deallocating a deallocated pointer: fd [../wine-git/tools/winebuild/res16.c:187]: (error) Resource leak: fd [../wine-git/tools/winedump/pe.c:1549]: (error) Memory leak: map Not sure if I need to write up a bug for this or what... and no I cant touch the code due to NDA issues. Chris

3 2

Re: Make the tests of the value returned from function SHGetFileInfoA more strick, fix wine to pass the tests
by Alexandre Julliard 04 Aug '09

04 Aug '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > While looking for bug 7701 i found that the function __vbaNew2 of the > MSVBVM60.dll does not like return values from SHGetFileInfoA bigger than > 0x7fff. > > Checking the return values on windows 2000 an XP > (http://www.winehq.org/pipermail/wine-devel/2009-July/077589.html) turned out > that it is always 1 on success (as long as SHGFI_EXETYPE is not specified). You need to take SHGFI_SYSICONINDEX into account too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Always overwrite dialog's saved focus handle
by Alexandre Julliard 04 Aug '09

04 Aug '09

Andrew Eikum <aeikum(a)codeweavers.com> writes: > This fixes a problem with dialogs which would cause > controls no longer on the current dialog screen to > regain focus. This doesn't look right, please write test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] advapi32: Factor out lookup of local usernames and well-known SIDs.
by Alexandre Julliard 04 Aug '09

04 Aug '09

Hans Leidekker <hans(a)codeweavers.com> writes: > Another attempt to fix the dotnet30 installer, using LSA_UNICODE_STRING > throughout this time. You are still assuming in some places that the string is null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

How should we handle Mac users visiting winehq.org?
by Scott Ritchie 04 Aug '09

04 Aug '09

Something interesting I noticed today: our wiki page on Mac OSX is ranked 7th when doing a simple search for "Wine" (the main page and the download page of winehq are 1st and 2nd). This means that a _large_ number of people are linking directly to the wiki page from external sites. Presumably, this is due to demand, however it's also largely due to the fact that the OSX experience on the main website is so poor. For instance, if I am a Mac user and I go to the website, I may learn what Wine is, get excited about it, and even read that it's for the Mac. But then I go to the download page and I'm completely lost - we don't put an OSX icon there, and we don't even explain that Crossover is for the Mac as well. My suggestion is we do our best to explain the current situation to Mac users. Provide an Apple "download" that actually links to the wiki page, and have the wiki be up front about how it's harder to install Wine on OS X than Linux because we don't have a volunteer making binary packages. Maybe some will take the hint and go buy Crossover, maybe some will go ahead and try the instructions but get less frustrated, and maybe someone will step forward and provide packages. At the moment, though, we leave them confused until Google tells them to go to the wiki page. Thanks, Scott Ritchie

2 1

More winehq.org improvements and issues: About page now links to articles in the wiki
by Scott Ritchie 04 Aug '09

04 Aug '09

I have begun some cleanup of the website, starting with the most popular pages. In particular, the about page: http://www.winehq.org/about/ The text is much easier to read for a newcomer to get a general overview of the project. On a wide browser window, however, it looks very horizontal -- this is fixable with a good picture on the right side of the screen, however I don't have one ready yet. It's kind of hard to capture what Wine is about for a typical user in a single picture, but I think it may be doable. Regardless, for users who want more information, the About page now directly links to 4 separate wiki articles: - Why Wine is so important - Common Myths about Wine - History of the Wine Project - Organization and Leadership I'll be personally giving each of these an edit over the coming weeks, however help is of course appreciated - that's why it's in the wiki. The last article, in particular, needs to be essentially written from scratch. Thanks for your help, especially Newman for committing my patches ;) Thanks, Scott Ritchie

5 5

New Wine Gecko 1.0.0 RC
by Jacek Caban 04 Aug '09

04 Aug '09

Hi, It's time for the new Wine Gecko package release. I've prepared a new package based on Mozilla code a bit newer than Firefox 3.5 and my fixes (most of them are on their way to mainstream Mozilla repository). This release fixes a few known bugs. It's not as big change as 0.9.0 release was, so I don't expect that many problems. Last time we had a few serious regressions and I'd like to avoid them now. That's why I'd like to ask you for help in testing (last time I did too, but somehow we've missed serious problems). To use it, just apply the attached patch, download the build from: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-1.0.0.cab and place it in correct location according to (note s/0.9.1/1.0.0/): http://wiki.winehq.org/Gecko Everything that uses MSHTML is interesting for testing. Please let me know about any regression. If everything goes well, I will do the release on Monday next week. Thanks, Jacek commit 63e1e5a530b27b2bbd1795a418e618b1d4692235 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jul 29 18:00:53 2009 +0200 Wine Gecko 1.0.0 release. diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c index 0cbfc06..d181458 100644 --- a/dlls/mshtml/htmlbody.c +++ b/dlls/mshtml/htmlbody.c @@ -44,6 +44,69 @@ typedef struct { #define HTMLBODY(x) (&(x)->lpHTMLBodyElementVtbl) +static const WCHAR aquaW[] = {'a','q','u','a',0}; +static const WCHAR blackW[] = {'b','l','a','c','k',0}; +static const WCHAR blueW[] = {'b','l','u','e',0}; +static const WCHAR fuchsiaW[] = {'f','u','s','h','s','i','a',0}; +static const WCHAR grayW[] = {'g','r','a','y',0}; +static const WCHAR greenW[] = {'g','r','e','e','n',0}; +static const WCHAR limeW[] = {'l','i','m','e',0}; +static const WCHAR maroonW[] = {'m','a','r','o','o','n',0}; +static const WCHAR navyW[] = {'n','a','v','y',0}; +static const WCHAR oliveW[] = {'o','l','i','v','e',0}; +static const WCHAR purpleW[] = {'p','u','r','p','l','e',0}; +static const WCHAR redW[] = {'r','e','d',0}; +static const WCHAR silverW[] = {'s','i','l','v','e','r',0}; +static const WCHAR tealW[] = {'t','e','a','l',0}; +static const WCHAR whiteW[] = {'w','h','i','t','e',0}; +static const WCHAR yellowW[] = {'y','e','l','l','o','w',0}; + +static const struct { + LPCWSTR keyword; + const WCHAR hexstr[8]; +} keyword_table[] = { + {aquaW, {'#','0','0','f','f','f','f',0}}, + {blackW, {'#','0','0','0','0','0','0',0}}, + {blueW, {'#','0','0','0','0','f','f',0}}, + {fuchsiaW, {'#','f','f','0','0','f','f',0}}, + {grayW, {'#','8','0','8','0','8','0',0}}, + {greenW, {'#','0','0','8','0','0','0',0}}, + {limeW, {'#','0','0','f','f','0','0',0}}, + {maroonW, {'#','8','0','0','0','0','0',0}}, + {navyW, {'#','0','0','0','0','8','0',0}}, + {oliveW, {'#','8','0','8','0','0','0',0}}, + {purpleW, {'#','8','0','0','0','8','0',0}}, + {redW, {'#','f','f','0','0','0','0',0}}, + {silverW, {'#','c','0','c','0','c','0',0}}, + {tealW, {'#','0','0','8','0','8','0',0}}, + {whiteW, {'#','f','f','f','f','f','f',0}}, + {yellowW, {'#','f','f','f','f','0','0',0}} +}; + +static BSTR nscolor_to_str(LPCWSTR color) +{ + int i, r, min = 0, max = sizeof(keyword_table)/sizeof(keyword_table[0])-1; + + if(!color || *color == '#') + return SysAllocString(color); + + while(min <= max) { + i = (min+max)/2; + + r = strcmpiW(color, keyword_table[i].keyword); + if(!r) + return SysAllocString(keyword_table[i].hexstr); + + if(r < 0) + max = i-1; + else + min = i+1; + } + + WARN("unknown color %s\n", debugstr_w(color)); + return SysAllocString(color); +} + static BOOL variant_to_nscolor(const VARIANT *v, nsAString *nsstr) { switch(V_VT(v)) { @@ -305,7 +368,7 @@ static HRESULT WINAPI HTMLBodyElement_get_bgColor(IHTMLBodyElement *iface, VARIA nsAString_GetData(&strColor, &color); V_VT(p) = VT_BSTR; - V_BSTR(p) = SysAllocString(color); + V_BSTR(p) = nscolor_to_str(color); nsAString_Finish(&strColor); diff --git a/dlls/mshtml/mutation.c b/dlls/mshtml/mutation.c index ab9649c..6060a8d 100644 --- a/dlls/mshtml/mutation.c +++ b/dlls/mshtml/mutation.c @@ -412,6 +412,11 @@ static void NSAPI nsDocumentObserver_CharacterDataChanged(nsIDocumentObserver *i { } +static void NSAPI nsDocumentObserver_AttributeWillChange(nsIDocumentObserver *iface, nsIDocument *aDocument, + nsIContent *aContent, PRInt32 aNameSpaceID, nsIAtom *aAttribute, PRInt32 aModType) +{ +} + static void NSAPI nsDocumentObserver_AttributeChanged(nsIDocumentObserver *iface, nsIDocument *aDocument, nsIContent *aContent, PRInt32 aNameSpaceID, nsIAtom *aAttribute, PRInt32 aModType, PRUint32 aStateMask) { @@ -563,6 +568,7 @@ static const nsIDocumentObserverVtbl nsDocumentObserverVtbl = { nsDocumentObserver_Release, nsDocumentObserver_CharacterDataWillChange, nsDocumentObserver_CharacterDataChanged, + nsDocumentObserver_AttributeWillChange, nsDocumentObserver_AttributeChanged, nsDocumentObserver_ContentAppended, nsDocumentObserver_ContentInserted, diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl index 894bb41..24c6214 100644 --- a/dlls/mshtml/nsiface.idl +++ b/dlls/mshtml/nsiface.idl @@ -23,7 +23,7 @@ * compatible with XPCOM, usable in C code. */ -cpp_quote("#define GECKO_VERSION \"0.9.1\"") +cpp_quote("#define GECKO_VERSION \"1.0.0\"") cpp_quote("#define GECKO_VERSION_STRING \"Wine Gecko \" GECKO_VERSION") import "wtypes.idl"; @@ -855,7 +855,7 @@ interface nsIDOMDocument : nsIDOMNode [ object, - uuid(533a8131-8d0c-4ebf-990b-7fad7cd51466), + uuid(09a439ad-4079-46d5-a050-4d7015d1a108), local /* NOT_FROZEN */ ] @@ -868,9 +868,9 @@ interface nsIDOMNSDocument : nsISupports nsresult GetTitle(nsAString *aTitle); nsresult SetTitle(const nsAString *aTitle); nsresult GetContentType(nsAString *aContentType); + nsresult GetReadyState(nsAString *aReadyState); nsresult GetLastModified(nsAString *aLastModified); nsresult GetReferrer(nsAString *aReferrer); - nsresult GetBoxObjectFor(nsIDOMElement *elt, nsIBoxObject **_retval); nsresult HasFocus(PRBool *_retval); nsresult GetActiveElement(nsIDOMElement **aActiveElement); nsresult GetElementsByClassName(const nsAString *classes, nsIDOMNodeList **_retval); @@ -1546,13 +1546,13 @@ interface nsIWebNavigation : nsISupports [ object, - uuid(5af07661-6477-4235-8814-4a45215855b8), + uuid(343700dd-078b-42b6-a809-b9c1d7e951d0), local /* NOT_FROZEN */ ] interface nsIPrintSettings : nsISupports { - typedef struct { char dummy; } nsMargin; + typedef struct { char dummy; } nsIntMargin; nsresult SetPrintOptions(PRInt32 aType, PRBool aTurnOnOff); nsresult GetPrintOptions(PRInt32 aType, PRBool *_retval); @@ -1672,13 +1672,13 @@ interface nsIPrintSettings : nsISupports nsresult SetIsInitializedFromPrinter(PRBool aIsInitializedFromPrinter); nsresult GetIsInitializedFromPrefs(PRBool *aIsInitializedFromPrefs); nsresult SetIsInitializedFromPrefs(PRBool aIsInitializedFromPrefs); - nsresult SetMarginInTwips(nsMargin *aMargin); - nsresult SetEdgeInTwips(nsMargin *aEdge); - nsresult GetMarginInTwips(nsMargin *aMargin); - nsresult GetEdgeInTwips(nsMargin *aEdge); + nsresult SetMarginInTwips(nsIntMargin *aMargin); + nsresult SetEdgeInTwips(nsIntMargin *aEdge); + nsresult GetMarginInTwips(nsIntMargin *aMargin); + nsresult GetEdgeInTwips(nsIntMargin *aEdge); nsresult SetupSilentPrinting(); - nsresult SetUnwriteableMarginInTwips(nsMargin *aEdge); - nsresult GetUnwriteableMarginInTwips(nsMargin *aEdge); + nsresult SetUnwriteableMarginInTwips(nsIntMargin *aEdge); + nsresult GetUnwriteableMarginInTwips(nsIntMargin *aEdge); } [ @@ -1872,7 +1872,7 @@ interface nsIIOService : nsISupports [ object, - uuid(57322c6f-f4ec-4e46-8253-b74be220de16), + uuid(a50d5516-5c0a-4f08-b427-703ca0c44ac3), local, /* NOT_FROZEN */ ] @@ -2485,7 +2485,7 @@ interface nsIHTMLEditor : nsISupports [ object, - uuid(32e68316-67d4-44a5-8d35-0d390fa9df11), + uuid(365d600b-868a-452a-8de8-f46fad8fee53), local /* NOT_FROZEN */ ] @@ -2495,6 +2495,8 @@ interface nsIMutationObserver : nsISupports void /*CharacterDataChangeInfo*/ *aInfo); void CharacterDataChanged(nsIDocument *aDocument, nsIContent *aContent, void /*CharacterDataChangeInfo*/ *aInfo); + void AttributeWillChange(nsIDocument *aDocument, nsIContent * aContent, PRInt32 aNameSpaceID, + nsIAtom *aAttribute, PRInt32 aModType); void AttributeChanged(nsIDocument *aDocument, nsIContent *aContent, PRInt32 aNameSpaceID, nsIAtom *aAttribute, PRInt32 aModType, PRUint32 aStateMask); void ContentAppended(nsIDocument *aDocument, nsIContent *aContainer, PRInt32 aNewIndexInContainer); @@ -2531,7 +2533,7 @@ interface nsIDocumentObserver : nsIMutationObserver void StyleRuleAdded(nsIDocument *aDocument, nsIStyleSheet *aStyleSheet, nsIStyleRule *aStyleRule); void StyleRuleRemoved(nsIDocument *aDocument, nsIStyleSheet *aStyleSheet, nsIStyleRule *aStyleRule); void BindToDocument(nsIDocument *aDocument, nsIContent *aContent); - void DoneAddingContent(nsIContent *aContent, PRBool aHaveNotified); + void DoneAddingChildren(nsIContent *aContent, PRBool aHaveNotified); } /* diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c index a122e0c..3af8867 100644 --- a/dlls/mshtml/olecmd.c +++ b/dlls/mshtml/olecmd.c @@ -583,9 +583,6 @@ static HRESULT exec_editmode(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, debugstr_w(hostinfo.pchHostCss), debugstr_w(hostinfo.pchHostNS)); } - if(This->nscontainer) - set_ns_editmode(This->nscontainer); - update_doc(This, UPDATE_UI); if(This->mon) { @@ -609,6 +606,9 @@ static HRESULT exec_editmode(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, if(FAILED(hres)) return hres; + if(This->nscontainer) + set_ns_editmode(This->nscontainer); + if(This->ui_active) { RECT rcBorderWidths; diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index a153a14..557a789 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -2991,7 +2991,6 @@ static void test_default_style(IHTMLStyle *style) hres = IHTMLStyle_get_margin(style, &str); ok(hres == S_OK, "get_margin failed: %08x\n", hres); - todo_wine ok(!strcmp_wa(str, "1px"), "margin = %s\n", dbgstr_w(str)); hres = IHTMLStyle_put_margin(style, NULL);

5 4

Re: [2/4] advapi32: Add a basic implementation of LsaLookupNames2.
by Nikolay Sivov 04 Aug '09

04 Aug '09

Hans Leidekker wrote: > diff --git a/dlls/advapi32/lsa.c b/dlls/advapi32/lsa.c > index 315cce9..edb20d8 100644 > --- a/dlls/advapi32/lsa.c > +++ b/dlls/advapi32/lsa.c > @@ -297,19 +297,88 @@ NTSTATUS WINAPI LsaLookupNames( > return STATUS_NONE_MAPPED; > } > > +static BOOL lookup_name(LSA_UNICODE_STRING *name, SID *sid, DWORD *sid_size, WCHAR *domain, > + DWORD *domain_size, SID_NAME_USE *use, BOOL *handled) > +{ > + BOOL ret; > + > + ret = lookup_local_wellknown_name(name, sid, sid_size, domain, domain_size, use, handled); > + if (!handled) > + ret = lookup_local_user_name(name, sid, sid_size, domain, domain_size, use, handled); > + > + return ret; > +} > This looks strange. Shouldn't be " if (!*handled) " or " if (!ret) "?

1 0

Re: [2/2] comdlg32/tests: Fix a failing test on Win2k and above.
by Paul Vriens 04 Aug '09

04 Aug '09

Nicolas Le Cam wrote: > Hi, > > Following Rein's commit 1f825a3631c78ac08383dd6062005526fc9c483d I've > got a new failure on my Win2k box. > > I did a first patch to filter Win2k failure that happens on > GetSaveFileNameW case only but, according to test.winehq.org, Win9x > boxes are failing on more cases so I did a more general (and simple) > fix. > > -- > Nicolas Le Cam > > > ------------------------------------------------------------------------ > > Hi Nicolas, Judging by the results on test.winehq.org I'd say that W2K and below (except ME) fails these tests (and there is even a Win95 box that doesn't fail so it seems). I guess just changing that comment should do the trick, not? -- Cheers, Paul.

2 1

Re: [2/2] comdlg32/tests: Fix a failing test on Win2k and above.
by Rein Klazes 04 Aug '09

04 Aug '09

On Mon, 03 Aug 2009 21:02:30 +0200, you wrote: > > >Following Rein's commit 1f825a3631c78ac08383dd6062005526fc9c483d I've >got a new failure on my Win2k box. > >I did a first patch to filter Win2k failure that happens on >GetSaveFileNameW case only but, according to test.winehq.org, Win9x >boxes are failing on more cases so I did a more general (and simple) >fix. > ... >+ ok( maxtextrows == 0 || broken(maxtextrows == 1), /* Win2k and above */ Then I think that should be "Win2k and below". Rein.

1 0

Re: programs/start: handle /B & /I options
by Frédéric Delanoy 03 Aug '09

03 Aug '09

Well, IMHO bug 10912 should stay open since /B option is not really supported, but rather silently ignored. Frédéric On Mon, Aug 3, 2009 at 2:34 AM, Austin English<austinenglish(a)gmail.com> wrote: > Fixes bug 10912. > > -- > -Austin

2 1

Re: ws2_32: Add debug support for IPv6 addresses
by Alexandre Julliard 03 Aug '09

03 Aug '09

Juan Lang <juan.lang(a)gmail.com> writes: > + case WS_AF_INET: > + return wine_dbg_sprintf("{ family %d, address %s, port %d }", > + ((const struct sockaddr_in *)a)->sin_family, > + inet_ntoa(((const struct sockaddr_in *)a)->sin_addr), > + ntohs(((const struct sockaddr_in *)a)->sin_port)); > + case WS_AF_INET6: > + { > + char buf[46]; > + const char *p; > + struct WS_sockaddr_in6 *sin = (struct WS_sockaddr_in6 *)a; > + > + p = WS_inet_ntop( WS_AF_INET6, &sin->sin6_addr, buf, sizeof(buf) ); > + if (!p) > + p = "(unknown IPv6 address)"; > + return wine_dbg_sprintf("{ family %d, address %s, port %d }", > + sin->sin6_family, p, ntohs(sin->sin6_port)); There's no need to display family as a number since you know its value already, you could print it in symbolic form. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: Prevent page faults from ATL thunk check to reach debuggers
by Alexandre Julliard 03 Aug '09

03 Aug '09

Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> writes: > send_debug_event will not send the "first chance exception" message (or > any other) when Peb->BeingDebugged is zero. Of course you can't do that, BeingDebugged is global not per-thread. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 2/4 winex11: make sure r8g8b8 is used when using get_xrender_color
by Alexandre Julliard 03 Aug '09

03 Aug '09

Roderick Colenbrander <thunderbird2k(a)gmail.com> writes: > The text color of a physdev is in 24-bit r8g8b8 independent of the > depth, so make sure the picture format passed to get_xrender_color is > also in this format. This prepares for dibsections with support in > depths other than the screen depth. This is wrong, the text pixel is in device-specific format. The color conversion functions that are used for the text pixel and similar variables need to be expanded to take into account multiple depths (not to mention DIB color maps...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] WineD3D: Test SetRenderTarget-Stateblock recording interaction
by Henri Verbeet 03 Aug '09

03 Aug '09

I actually meant integrating it with the existing stateblock tests, i.e. test_state_management(), but I can also do that myself afterwards. Please add a test for d3d8 as well though, both render targets and stateblocks are slightly different there.

2 1

Re: [2/3] WineD3D: SetRenderTarget sets the scissor rect
by Henri Verbeet 03 Aug '09

03 Aug '09

2009/8/3 Stefan Dösinger <stefan(a)codeweavers.com>: >- ok(hr == D3D_OK, "IDirect3DDevice9_BeginStateBlock failed, hr = %08x\n", hr); >+ ok(hr == D3D_OK, "IDirect3DDevice9_EndStateBlock failed, hr = %08x\n", hr); This should have been part of the first patch.

2 1

Cursor & Icon patches
by Daniel Santos 03 Aug '09

03 Aug '09

Hello everybody! Attached is my current cursor icon patches based upon work by Henri Verbeet and Andrew Riedi for review and comment. I finished the actual code about 3 weeks ago, but it's been a lot of work for me to split it out into smaller pieces, especially being new to git. Here is a break-down of what these patches do and the theory. * Adds real 32-bit handles (instead of converting 16-bit handles to 32 bit). * Cursors & icons stored in non-moveable memory block (a.k.a., "32 bit data") in addition to existing 16-bit moveable block. * A new 'struct cursor_header' (include/wine/winuser16.h) is pre-pended to the 32-bit cursor/icon data (16-bit data format is untouched). * A new 'struct cursor_map_entry' (dlls/user32/cursoricon.c) is used to manage a cursor's association with its handles and data. * Adds more complete .ani support (I think nearly 100% complete). * Adds themed icon support (from your X-windows theme). * Fixes a lot of bugs. * And finally, moves cursors to the server. The server opaquely stores the raw 32-bit cursor/icon data. Since the client does all interaction with winex11.drv, the server doesn't really need to understand it. The client caches all objects locally, but attempts to retrieve from the server any handle it doesn't know about. Locally, the client uses a pair of rbtrees to associate cursor objects (actually struct cursor_map_entry) with their respective 16 & 32 bit handles. The 16 bit cursor data is automatically generated on the client and can still be directly manipulated from 16 bit programs; in such cases, the 32-bit cursor data will be updated from the modified 16 bit data. The CRITICAL_SECTION IconCrst is used to synchronize access to the rbtrees and ensure that data is unmodified once an operation on that data begins (in database terms, IconCrst is used to lock the entire "table" and there's no "row-level" locking). There are several new functions to query and manipulate the rbtrees: add_cursor_entry : (self-explanatory) remove_cursor_entry: (self-explanatory) get_cursor_handle16: retrieves a 16-bit handle from a 32-bit one get_cursor_handle : visa-versa Layered on top of that are a basic set of functions for higher level management of cursor/icon objects: alloc_cursor_data : allocate & initialize cursor data & header create_cursor : creates cursor and auto-generates 16-bit data destroy_cursor : destroys cursor and associated 16-bit data get_cursor_entry : will look both locally and on the server get_cursor_object : returns the cursor's data update_cursor_data16: creates or updates the 16-bit data from 32-bit data CURSORICON_refresh_cursor16: updates the 32-bit data from 16-bit data The functions add_cursor_entry and get_cursor_entry directly return a pointer to the struct cursor_map_entry and therefore require locking IconCrst in advance of calling (or will fail an assertion). Having direct access to the cursor_map_entry reduces complexity in some circumstances. One of the oddest fixes is the fake_cursor() function, which is used to accommodate deleting the active cursor, which windows doesn't mind. This isn't the only way to go about it, but the alternative was to make the cursor empty and I'm not certain that that is the visual behavior of windows when deleting the active cursor, so I'm more than open to feedback on that as well as anything else in these patches. Thanks! Daniel

5 7

Re: 2/4 winex11: make sure r8g8b8 is used when using get_xrender_color
by Henri Verbeet 03 Aug '09

03 Aug '09

2009/8/2 Roderick Colenbrander <thunderbird2k(a)gmail.com>: > Hi, > > The text color of a physdev is in 24-bit r8g8b8 independent of the > depth, so make sure the picture format passed to get_xrender_color is > also in this format. This prepares for dibsections with support in > depths other than the screen depth. > Shouldn't the format of the pixel be compatible with the picture you're using it on?

2 2

Status of XI2 mouse stuff?
by Luke Benstead 02 Aug '09

02 Aug '09

Hi all, I remember seeing an email that someone had implemented DX mouse input using the new XInput2 extensions. What's the status of that? Is it in Wine already? Cheers, Luke.

2 1

re: Begin Wine Development
by Dan Kegel 02 Aug '09

02 Aug '09

What John said! But just to be clear: only Alexandre has git commit power. The rest of us have to send patches to wine-patches and keep improving them until he relents and admits that perhaps they're worthy of inclusion. :-) Also, we tend not to worry too much about having bugs assigned. There are so many available that there is seldom any real duplication of effort. Are there any areas in particular you're interested in? If not, one great way to start is to look at bugs with keyword 'download' that have not been changed in > 90 days, see if you can reproduce the problem with current wine from git, and append your test results (either "bug still present in git" or "works for me with git") as a comment. And once you've done a few of those, maybe you'll see one you can actually try to fix. Not every wine bug is hard. - Dan

1 0

AppDB - Watchtower Library as Nr. 1 Top-10 Platinum application
by Groeschel, Volker 02 Aug '09

02 Aug '09

This looks like a manipulation for me. How is this calculated? http://appdb.winehq.org/ <http://dict.leo.org/ende?lp=ende&p=thMx..&search=manipulation>

3 2

How far away are we from .net 3.0 install working?
by Dan Kegel 01 Aug '09

01 Aug '09

http://www.winehq.org/pipermail/wine-patches/2009-June/074701.html says that the offline installer for .net 3.0 works fine with that one patch, but it didn't seem to work when I tried it. Anyone know what the story is? - Dan

4 7

RFC XRender add support for dibsections in more color depths
by Roderick Colenbrander 01 Aug '09

01 Aug '09

Hi, For some weeks I have been working on moving more 2D rendering to XRender. XRender has three advantages for Wine. First of all it allows us to perform more rendering operations using X which we previously did using a combination of software rendering and back-forth copying between the Xserver. Second XRender offers depth conversion (this gives us proper alpha support in Wine and allows us to bypass DIB color conversion in some cases!). Third XRender brings us more hardware acceleration and that way more performance. The patch attached to this thread adds support for dibsections in additional color depths. On Xservers running at 24-bit this patch offers us dibsections in 1-bit/15-bit/16-bit/24-bit/32-bit. (32-bit is for proper alpha support) Big parts of the Wine X11 Driver make assumptions about having only two color depths around (1-bit and screen_depth e.g. 24-bit). I would like to request that people apply the current patch to latest git (in combination with the Office2007 patch which I posted to wine-patches). Please report any 2D rendering issues you see and also mention possible Wine crashes due to X errors like BadMatch. Try as much programs as possible. Thanks in advance, Roderick Colenbrander

6 16

Test request for ListView applications
by Nikolay Sivov 01 Aug '09

01 Aug '09

Hi. Yesterday I attached a patch to fix longstanding bug http://bugs.winehq.org/show_bug.cgi?id=3231 . It fixes this issue, and I hope doesn't produce any new ones. Now I need to test it on a wide range of applications you use every day. If you spotted any new issues after it please let me know. Here's a direct link to attachment: http://bugs.winehq.org/attachment.cgi?id=22742 Patch should be applied on top of wine-1.1.26-232-g39876f4. Nikolay S.

1 0

Re: ntdll: For Darwin/Mac OS X, use legacy getdirentries if 64-bit inodes enabled.
by Austin English 31 Jul '09

31 Jul '09

On Fri, Jul 31, 2009 at 4:25 PM, Ken Thomases<ken(a)codeweavers.com> wrote: > > Fixes building on Snow Leopard. > --- > dlls/ntdll/directory.c | 30 ++++++++++++++++++++++++++++++ > 1 files changed, 30 insertions(+), 0 deletions(-) FWIW, NetBSD has a similar bug (http://bugs.winehq.org/show_bug.cgi?id=18166), but AJ refused the patch, saying NetBSD should fix it on their end. -- -Austin

2 1

WGL: fix usage of non-GLX visual in glXCreateContext
by Roderick Colenbrander 31 Jul '09

31 Jul '09

Hi, We should not expect that the default Wine visual supports GLX, use glXChooseVisual instead. This should fix bug 19570. Regards, Roderick Colenbrander

1 0

Re: ws2_32: Handle the formatting of IPV6 addresses and use inet_ntop function
by Juan Lang 31 Jul '09

31 Jul '09

Hi Jeff, I have a competing version of a similar patch that I was going to send in. Ordinarily I'd defer to the first poster rule, but in this case I'd rather mine were used. The difference is, you use the ternary comparison operator: + (((const struct WS_sockaddr_in *)a)->sin_family == AF_INET) ? + (void *)&((struct WS_sockaddr_in *)a)->sin_addr : + ((struct WS_sockaddr_in6 *)a)->sin6_addr.WS_s6_addr, This makes the expression rather long, and also makes it hard to extend beyond two address families. ws2_32 also supports IPX, and with any luck it'll soon support IrDA. I'll send mine in shortly, and you can complain if you like :) --Juan

7 6

Re: gdi32: Ensure child fonts have names
by Dmitry Timoshkov 31 Jul '09

31 Jul '09

"Aric Stewart" <aric(a)codeweavers.com> wrote: > @@ -5792,6 +5792,9 @@ static BOOL load_child_font(GdiFont *font, CHILD_FONT *child) > child->font->scale_y = font->scale_y; > hfontlist = HeapAlloc(GetProcessHeap(), 0, sizeof(*hfontlist)); > hfontlist->hfont = CreateFontIndirectW(&font->font_desc.lf); > + /* ensure the child font has a name */ > + if (!child->font->name) > + child->font->name = strdupW(child->font->font_desc.lf.lfFaceName); It doesn't look like an appropriate place for this. Font name is initialized explicitly in both WineEngCreateFontInstance() and GetEnumStructs(). How it could be possible that it's NULL in the above case? -- Dmitry.

2 3

Wine to be used as botnet testbed
by Maik Schulz 30 Jul '09

30 Jul '09

More in the linked New York Times article, Sandia National Labs plans to have a Dell super computer run 1 million Linux instances using Wine to host and study a botnet: http://www.nytimes.com/2009/07/28/science/28comp.html?_r=1 Does someone on the list have more detailed information on or is even involved with it? How about we post about this on winehq.org as well? Would be a departure from posing only about new releases and WWN issues, but it could make winehq.org more interesting for users... I'd volunteer... Cheers, -Maik

2 1

Re: winecfg: Add toggle for systray visibility
by Roderick Colenbrander 30 Jul '09

30 Jul '09

Hi Andrew, Good that you have removed the unneeded changes. I'm wondering where the support in winex11.drv is for the winecfg option you added. My git version doesn't have it and I can't remember seeing patches for it (though I might have missed them). If these patches indeed have not been submitted, I would urge you to submit those first. Regards, Roderick On Wed, Jul 29, 2009 at 8:20 PM, Andrew Eikum<aeikum(a)codeweavers.com> wrote: > --- > programs/winecfg/En.rc | 2 ++ > programs/winecfg/resource.h | 1 + > programs/winecfg/theme.c | 19 +++++++++++++++++++ > 3 files changed, 22 insertions(+), 0 deletions(-) > > > > > >

1 0

Re: [6/6] hnetcfg: Register interfaces.
by Austin English 30 Jul '09

30 Jul '09

On Thu, Jul 30, 2009 at 10:36 AM, Hans Leidekker<hans(a)codeweavers.com> wrote: > On Thursday 30 July 2009 05:17:07 pm you wrote: > >> What is this series for, if you don't mind my asking? >> >> The iTunes installer/other applications looking for the XP firewall? > > Yes, this brings the iTunes installer to the next bug ;-) Great work! Which bug is that? -- -Austin

2 1

Re: winecfg: Add toggle for systray visibility
by Roderick Colenbrander 30 Jul '09

30 Jul '09

Hi Andrew, First of all it seems that the patch makes more changes than needed (e.g. lost of changes in En.rc. Second why is this patch needed? Various apps need the systray for proper functioning and hiding it doesn't look that nice to me.. Roderick On Thu, Jul 30, 2009 at 5:30 PM, Andrew Eikum<aeikum(a)codeweavers.com> wrote: > --- > programs/winecfg/En.rc | 21 +++++++++++---------- > programs/winecfg/resource.h | 1 + > programs/winecfg/x11drvdlg.c | 37 +++++++++++++++++++++++++++++++------ > 3 files changed, 43 insertions(+), 16 deletions(-) > > > > > >

1 0

Question about the gphoto2.ds resources
by Paul Vriens 30 Jul '09

30 Jul '09

Hi Marcus, I've noticed some strange output with transl: http://source.winehq.org/transl/resource.php?lang=013%3A00&resfile=dlls%2Fg… When I look at the defined resources for the first dialog I see: IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU CAPTION "Files on Camera" MENU 20545 That MENU however is not defined anywhere. Can you remember (2006!) why that MENU entry was put in there? Mind you, I think transl should be able to cope with it, but I'm just checking if that entry can be removed. -- Cheers, Paul.

3 4

Adding a pedantic version of transl
by Paul Vriens 29 Jul '09

29 Jul '09

Hi, Currently transl doesn't show potential translation errors on a higher level. I'm busy implementing a more pedantic version of transl that shows the potential translation errors on the resfile pages (see attached screenshot). I'm now looking for the best way to get into pedantic mode. Will a simple link on that page do? It will always show a link to the other mode of course. We don't want this on by default as there are a lot of false positives, just think of all those "OK" buttons and it will take some performance to present this. Once this is dealt with I will start with a pedantic mode on an even higher level (the lang page). This however only if it doesn't take too much of a performance hit. -- Cheers, Paul.

2 5

Re: Revert "winealsa.drv: Re-allow fallback to waveout (regression in dsound)."
by Maarten Lankhorst 29 Jul '09

29 Jul '09

Heu, Fixing the bug would help, I replied on that bugtracker that I need more information since I'm not bit by that bug myself, but completely reverting a commit just because it has a bug for someone isn't particularly helpful. If you go to winecfg and set acceleration to emulation the old code path continues to be used, this is about using the other path. Cheers, Maarten

1 0

Re: Revert "winealsa.drv: Re-allow fallback to waveout (regression in dsound)."
by Henri Verbeet 29 Jul '09

29 Jul '09

2009/7/28 Maarten Lankhorst <m.b.lankhorst(a)gmail.com>: > This reverts commit 0addd3ba5a7c1de970d1829f77969e5331ad2be0. > > It doesn't fix anything, it just hides the bug. Wouldn't it be helpful to fix the bug first?

1 0

Testers on windows needed
by Stefan Leichter 28 Jul '09

28 Jul '09

Hello, i'm looking for some good souls testing the attached patch one windows. While looking for bug 7701 i found that the function __vbaNew2 of the MSVBVM60.dll does not like return values from SHGetFileInfoA bigger than 0x7fff Can you please report at least the results of the trace statements and if any modified test fails for you, the console output is fine for me too. Thanks for your help Stefan

3 3

coordinating efforts wrt rejected patches
by Vincent Povirk 28 Jul '09

28 Jul '09

Some people have expressed interest recently in finding patches that have been sent to wine-patches and have not yet been accepted into winehq. The hope is that we can put some effort into getting feedback to the authors of recent ones, and maybe the old abandoned patches will catch the interest of some wandering developers. Sifting them out from the wine-patches archives is unfortunately not trivial. I'm way too lazy to try to create a bot for this, but I figure there may be enough interest to do it manually, going through the wine-patches messages and searching for similarly-named messages in wine-patches and wine-cvs. We just need to make sure we don't duplicate effort. If people end up using this information effectively, maybe someone will write a bot. If not, well, then it's good no one wasted time on it. To this end, I have created this wiki page: http://wiki.winehq.org/RejectedPatches I've gone through the submissions to wine-patches over one day and added the rejected entries to that page, sorted based on whether there's been a response. Anyone is welcome to use/update this information as they see fit and to expand the range of checked messages (but not into the future, at least until we get another round of commits). -- Vincent Povirk

3 2

Re: Adding a pedantic version of transl
by Paul Vriens 28 Jul '09

28 Jul '09

Aurimas Fišeras wrote: > On 2009.07.28 11:28, Paul Vriens wrote: >> Some screenshots for the curious: >> >> lang page: http://imgshack.info/images/e2wsftgyxwt3bxetbbq.png >> resfile page: http://imgshack.info/images/2w6rs7xm5uggsfplc5ke.png >> > Nice. > > One thought, columns "translated, errors" in "Modules not translated" > and "missing, errors" in "Fully translated modules" are always zero, so > I think they should be removed. Sure, can be done but let's wait what others have to say. -- Cheers, Paul.

1 0

Cleaning up the winehq.org website
by Scott Ritchie 28 Jul '09

28 Jul '09

Lately I've been attempting to polish up the content on our website. The visual design looks great since the revamp a while back, however a lot of the actual words trouble me. There's a lot of stuff from the dark ages still lurking around that we don't actually want users to see. Accordingly, I've been rewriting and deleting a few things and will be sending lostwages patches in, however I'd like to discuss the changes here in case there's any objections. 1) Delete the "Link to us" section on the downloads page. No one uses this graphic and the information is just noise. 2) Remove the unmaintained porting status page: http://www.winehq.org/status/porting - I don't believe this data is useful to anyone, and if it is it should be imported into the wiki so it can actually be updated. 3) Remove the "Wine Features" page: http://www.winehq.org/wine_features - From a user's perspective, the main feature of Wine can be communicated very simply: run Windows programs. We can do this much more effectively earlier in the website, such as on the About page. More worrisome about the features page, though, is what it doesn't contain - a user seeing a (seemingly) exhaustive list and actually reading it might incorrectly conclude that his particular program or device doesn't work. The features page is also prone to be out of date. I'm also going to give the text on some of the content pages a focused rewrite. The About page and many of it's links are fairly wordy at the moment. I want to avoid losing any users who may potentially dismiss us as amateurish or too complicated based on our web site. Thanks, Scott Ritchie

6 9

spam post on wine-users forum...
by Dan Kegel 28 Jul '09

28 Jul '09

What's the procedure for dealing with forum spam like http://forum.winehq.org/viewtopic.php?t=5655 ?

2 1

Help resources for wine-users mailing list
by Frédéric Delanoy 27 Jul '09

27 Jul '09

Over and over, I see help requests on wine-users with responses like "installed latest wine", "read FAQ section x.y", ... Wouldn't it be useful to send a regular reminder (like every month, and on subscription)? This would contain: - how to upgrade to latest version - link to FAQ - link to bugzilla + how to look for dups before creating new bugs - <everything useful> This would avoid countless identical responses to common problems, and help reduce traffic on wine-users, hence concentrating on "difficult" problems. Frédéric

6 6

Re: [2/5] ntdll/tests: Implement tests for data execution prevention.
by Dmitry Timoshkov 27 Jul '09

27 Jul '09

"Michael Karcher" <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > The tests will be skipped on Wine until next patch, as the > not-yet-implemented NtQueryInformationProcess(...,ProcessExecuteFlags,...,...) > call is used to detect a DEP-capable platform. These tests should added to existing dlls/ntdll/tests/exception.c framework. -- Dmitry.

6 6

Re: [1/5] ntdll: Fix ProcessExecuteFlag logic
by Dmitry Timoshkov 27 Jul '09

27 Jul '09

"Michael Karcher" <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > The meaning of "enable" is the same in Windows and Wine: it enables the > execute permission, not the data execution prevention. This patch precedes > the test as the inverted logic would make the test case fail in interesting > ways. There is no sense in first adding a lot of (partly conditional) > todo_wines to the test just to make this fix come later. JFYI, I based my original patch on the information at http://www.uninformed.org/?v=2&a=4 (To enable NX support, the MEM_EXECUTE_OPTION_DISABLE flag (0x1) is specified. To disable NX support, the MEM_EXECUTE_OPTION_ENABLE flag (0x2) is specified) and Chromium sources: http://src.chromium.org/viewvc/chrome/trunk/src/sandbox/src/dep.cc -- Dmitry.

2 1

Wine on cygwin
by dominik 27 Jul '09

27 Jul '09

Hi all, I've just tried to build wine on cygwin in order to build the test suite in order to maybe find out why some tests fail on my machine. configure runs reasonably well, but when the first dll is being built, hell breaks loose. The assembler files generated from the .spec files are not accepted by "as". .section ".init","ax" yields a.0dtc3a.s: Assembler messages: a.0dtc3a.s:5: Error: junk at end of line, first unrecognized character is `"' Then there is: .hidden __wine_spec_nt_header => a.0dtc3a.s:14: Error: unknown pseudo-op: `.hidden' .type __wine_stub_EditAuditInfo,@function => a.iNk2s9.s:81: Warning: .type pseudo-op used outside of .def/.endef ignored. a.iNk2s9.s:81: Error: junk at end of line, first unrecognized character is `_' and much more ... Are those Linux-specific assembler directives ? Does anybody have an idea on how to workaround those ? Regards Dominik

5 4

Re: comctl32: stop flicker when drawing themed
by Frank Richter 26 Jul '09

26 Jul '09

On 26.07.2009 15:57, André Hentschel wrote: > ...and draw the correct image smothly. > the code shouldnt have been copied and paste from the unthemed code. This changes the appearance of progress bars: now they look always "smooth" when themed. But on Windows they look always "chunky" when themed. -f.r.

1 0

Re: ntdll: spellingfix in a comment
by Frédéric Delanoy 26 Jul '09

26 Jul '09

On 07/26/2009 02:37 PM, André Hentschel wrote: > --- > dlls/ntdll/server.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > ------------------------------------------------------------------------ iff could be an abbreviation for "if and only if" (equivalence relationship), so it may not be an error after all (but I haven't checked the code). Frédéric

2 2

[2/2] msxml3: Register Missing Components
by Pat Renton 26 Jul '09

26 Jul '09

2 1

Fun news about CodeWeavers
by Jeremy White 26 Jul '09

26 Jul '09

http://www.codeweavers.com/about/general/press/20090724/ *grin* Cheers, Jeremy

2 1

Re: Create our own temp directory to make sure it's not the Windows directory.
by Paul Vriens 25 Jul '09

25 Jul '09

Hi Alexandre, This one introduced a test failure on several W2K, XP and W2K3 boxes. No idea why (yet) though. -- Cheers, Paul.

2 6

Revised How-to for ODBC Databases: Jet/Access success
by Barry Bird 25 Jul '09

25 Jul '09

Hello folks, after email conversation with James McKenzie, here is my revised how-to Access 2000 can work with Wine, but this how-to doesn't require Microsoft Access. How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. Install Jet Service Pack 4.0 and MDAC 2.8 thus: winetricks jet40 mdac28 You need to update the registry to 'install' the Access drivers for ODBC. Under Windows, export from the Registry to a *.reg file the registry entry - HKLM\Software\ODBC all subsidiary keys and values come with it. You can carefully edit this file to remove drivers and DSNs you don't need. Import this file using the registry editor in wine: wine regedit.exe. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. Change the default setting for these DLLs using winecfg: Select Default Settings in the Applications tab. Then in the Libraries tab, select each of existing overrides for odbc32.dll and odbccp32.dll and edit them to be Native for Windows. Bring across the programs and *.mdb database files from Windows. If you need to set up (System) DSNs, enter wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel which you can use in the normal way to enter a DSN name, select its driver and the .mdb file. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe I've tried this out on a clean .wine install and it works with my test programs. Barry Bird

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel