- wine-devel - winehq.org

Re: please reduce the four registrations on the single winehq.org site.
by Dan Kegel 21 Jul '09

21 Jul '09

Steven Edwards wrote: > Based upon my recollection there was a lot of contempt for OpenID at > the last wineconf. Maybe the situation has changed recently... For those new to the story, OpenID is incredibly insecure. See for example http://marcoslot.net/apps/openid/ http://www.gnucitizen.org/blog/hijacking-openid-enabled-accounts/ http://www.techafina.com/posts/openid-benefits-and-risks/ http://kuza55.blogspot.com/2007/01/insecure-openid-features.html Moreover, it's hard to use, as shown by usability testing at Yahoo: http://www.betanews.com/article/Yahoo-usability-tests-bode-ill-for-OpenID-t… In short: if you care about your data or your identity, stay far away from OpenID. Now, if you absolutely must use OpenID, there are people working on making it more secure. For instance, Google is giving it a shot; see http://google-code-updates.blogspot.com/2009/05/google-openid-api-taking-ne… But I doubt the wine community wants to go there. Better to implement a plain old shared password database between our four services. - Dan

2 2

Re: [2/2] winapi_extract: The old C parser is not needed anymore so remove it.
by Paul Vriens 21 Jul '09

21 Jul '09

Francois Gouget wrote: > --- > tools/winapi/winapi_c_parser.pm | 264 -------------------------------- > tools/winapi/winapi_extract | 8 +- > tools/winapi/winapi_extract_options.pm | 7 +- > 3 files changed, 4 insertions(+), 275 deletions(-) > delete mode 100644 tools/winapi/winapi_c_parser.pm > Hi Francois, After this patch, we can't run "./tools/winapi/winapi_extract --pseudo-stub-statistics" any more: dlls/actxprxy/dlldata.c:21.2: file: } without {: \ It looks like this is the reason our winapi_stats webpage isn't up-to-date? (Checked after seeing that email chain on wine-devel "Status of the Status pages?"). -- Cheers, Paul.

2 1

Re: WW2 fighters fix
by Paul Vriens 21 Jul '09

21 Jul '09

Alexandre Hardy wrote: > WW2 Fighters fails to display any in game graphics when in OpenGL > mode apparantly as a result of specifying both NORMAL and FULLSCREEN > flags to Direct Draw. The patch attached prints a warning instead > of failing to apply the settings. The patch has been tested on wine-1.1.24 > and earlier versions (1.1.21, 1.1.22). > > Alexandre Hardy > > > ------------------------------------------------------------------------ > > Hi, The subject of the patch should be a but more describing what it actually does (and include the dll/module it's touching). Another thing is that these kind of changes need tests. You can extend the current tests quite easily. I don't know anything about these modes (or if the combinations I show below actually make sense) but 2 quick tests on Windows 2003: DDSCL_NORMAL | DDSCL_EXCLUSIVE : DDERR_INVALIDPARAMS DDSCL_NORMAL | DDSCL_FULLSCREEN : DD_OK -- Cheers, Paul.

2 1

Re: WW2 fighters fix
by Stefan Dösinger 21 Jul '09

21 Jul '09

Am Monday 20 July 2009 15:45:28 schrieb Alexandre Hardy: > WW2 Fighters fails to display any in game graphics when in OpenGL > mode apparantly as a result of specifying both NORMAL and FULLSCREEN > flags to Direct Draw. The patch attached prints a warning instead > of failing to apply the settings. The patch has been tested on wine-1.1.24 > and earlier versions (1.1.21, 1.1.22). Hi, Please write a test for this and add it to dlls/ddraw/tests/ddrawmodes.c It might happen that Windows returns an error in this situation. I think we already have a test that shows that DDSCL_FULLSCREEN without DDSCL_EXCLUSIVE(and vice versa) is not permitted, so I think setting DDSCL_EXCLUSIVE in the if case is wrong. Also please use the code layout of the surrounding code.

1 0

suggestions about MacOS DYLD_FALLBACK_LIBRARY_PATH patch
by Joerg-Cyril.Hoehle＠t-systems.com 21 Jul '09

21 Jul '09

Dear Mac developers, please make suggestions about the xyz_LIBRARY_PATH MacOS issue that allows libpng.so and libfreetype.so to be found at run-time in /usr/X11/lib (bug 17674). A patch appending /usr/X11/lib to DYLD_FALLBACK_LIBRARY_PATH, much like Mike Kronenberg and MacPorts do, was rejected. http://www.winehq.org/pipermail/wine-patches/2009-July/075290.html Alexandre Julliard explained to me that he feels the xyz_LIBRARY_PATH feels bad being specific to Wine. He believes that all X11 apps should be affected and this issue be solved at "system level". Why aren't X11 apps affected on my machine? From the manpages, I believe the issue is specific to dlopen(), not regular shared libraries. Few apps use dlopen(). Configure detects these libraries precisely because it does not use dlopen(). So either we can convince AJ that is issue is specific to Wine, or the best that can be done on MacOS, or file a bug with Apple, or we need another solution. - Emmanuel Maillard had a patch specific to libfreetype in wineQuartz for 0.9.58, prepending the output of get_runtime_libdir() prior to calling wine_dlopen(). I object that this would have to be repeated for every other particular .so that Wine happens to use, e.g. libpng -- not very nice. (I also don't understand why get_runtime_libdir() would have helped, /usr/X11/lib is needed for these two libraries). - Other suggestions? Thanks for your help, Jörg Höhle.

8 27

Re: [3/3] WineD3D: Update the scissor rect on a render target change
by Henri Verbeet 21 Jul '09

21 Jul '09

2009/7/20 Stefan Dösinger <stefan(a)codeweavers.com>: > + scissor.top = 0; > + scissor.left = 0; > + scissor.right = viewport.Width; > + scissor.bottom = viewport.Height; > + IWineD3DDevice_SetScissorRect(iface, &scissor); > + IWineD3DDeviceImpl_MarkStateDirty(This, STATE_SCISSORRECT); The MarkStateDirty() call looks redundant to me. Also, does this do the right thing when we're recording a stateblock?

2 3

Status of the Status pages?
by Tomas - 21 Jul '09

21 Jul '09

The status pages in general seems to have been at a standstill since around 2007. The exception is the "API Stats" page, but now this page hasn't been updated since May 22. Is there any plans/ideas on what to do with the status pages?

3 2

Re: user32/tests: show that windows avoids creating loops in a menu tree, probably by limiting the depth of such tree.
by Paul Vriens 21 Jul '09

21 Jul '09

Rein Klazes wrote: > Show the problem with the application in bug report #12171. > +todo_wine > + ok( !ret || > + broken( 0), /* win98, NT */ > + "ModifyMenu should have failed.\n"); Hi Rein, We have a test failure on NT4 below after this patch. Shouldn't the "broken( 0)" be "broken( ret)" ? -- Cheers, Paul.

2 1

re: Status of the Status pages?
by Dan Kegel 21 Jul '09

21 Jul '09

Tomas wrote: > The status pages in general seems to have been at a standstill since around 2007. > The exception is the "API Stats" page, but now this page hasn't been updated since May 22. > Is there any plans/ideas on what to do with the status pages? I'd say we should delete them. They were always a guess. Except for API Stats, which should be kept but automated; it looks like it's still kind of manual. - Dan http://www.winehq.org/winapi_stats

1 0

Re: [PATCH 2/4] dpwsockx: Stub implementation
by Alexandre Julliard 21 Jul '09

21 Jul '09

Ismael Barros <razielmine(a)gmail.com> writes: > @@ -3,10 +3,11 @@ TOPOBJDIR = ../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = dpwsockx.dll > -IMPORTS = kernel32 > +IMPORTS = kernel32 ws2_32 > > C_SRCS = \ > - dpwsockx_main.c > + dpwsockx_main.c \ > + dpwsockx.c Please choose a better file name. dpwsockx.c doesn't say anything about what's in that file. > + DPWS_SetupCallbacks( lpspData->lpCB ); > + > + /* TODO: > + The original implementation calls SetSPData, > + check what it really stores */ How do you know that? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: test a combination of CreateServiceA and GetSecurityInfo [2nd]
by Paul Vriens 21 Jul '09

21 Jul '09

Stefan Leichter wrote: > Am Monday 20 July 2009 14:13:10 schrieb Alexandre Julliard: >> You could insert that into one of the other tests that already create a >> service, so that we don't need to have too many Sleeps in there. > > This testcase demonstrates the current problem in bug 1886 > > > ------------------------------------------------------------------------ > > Hi Stefan, Please stick to the style of the file, curly braces on a separate line. (I see there is only one such style difference in the current file, but that was also introduced by you ;) ) -- Cheers, Paul.

1 0

Bug day a success!
by Scott Ritchie 21 Jul '09

21 Jul '09

I'd like to thank everyone that participated in our first Bug Day. I'm definitely going to repeat it again next release, although I may move it back a few days. Some statistics: Our bug target search (bugs unchanged since January 1st with the download tag) started at 574 bugs. Now it's down to 508. That's 66 bugs that were either resolved, confirmed, or at least checked in on. In the past two days there have been 30 bugs newly resolved. By comparison, over the previous 2 weeks before then there were only 16 bugs resolved. So, we're definitely making progress. Quite a few of us had some fun, and I personally get a real satisfaction out of transforming our bug database from a scary mess to a place we actually look forward to visiting. I'd like to give a personal thanks to Luke Benstead, who set a great example by gathering some of his real life friends to participate. Luke has shown himself to be very capable, and he deserves bugzilla permissions so he can help facilitate bug hunts in the future. Again, thank you everyone! Thanks, Scott Ritchie

1 0

Re: ws2/tests: Test AcceptEx with a deferred socket
by Paul Vriens 21 Jul '09

21 Jul '09

Mike Kaplinskiy wrote: > This tests the following AcceptEx scenario: > WSAAccept->CF_DEFER->AcceptEx > Windows seems to return the deferred socket with AcceptEx (verified on > XP & 2K3). > > Mike. > > > ------------------------------------------------------------------------ > > Hi Mike, These new tests fail on all NT4 boxes (some 6 and 1 has 4000+ failures) and what looks like to be all Windows x64_64 systems. The strange thing (or maybe not) is that the errors are the same on all of these (one box has 4000+ failures but still has those same 6). See: http://test.winehq.org/data/tests/ws2_32:sock.html Could you have a look? I can do some tests if necessary on NT4, I don't have a Windows x86_64 system however. -- Cheers, Paul.

2 6

FW: Re: please reduce the four registrations on the single winehq.org site.
by Scott Ritchie 20 Jul '09

20 Jul '09

S Page wrote: > Hey, I really want to help the Wine project out by sharing my problems > and workarounds. > > But having to register FOUR TIMES on the same winehq.com site (bugs, > AppDB, forums, wiki) is excruciatingly painful and hostile to your > would-be contributors. I realize you're just using open source > tooling, but maybe you can press those four products to > a) implement a single sign-on > b) support OpenID > > Thanks, > -- > =S Page Strangely enough, I was just talking about this today at the Community Leadership Summit. Unfortunately it seems like it's a pretty difficult problem to solve as the tools to get all these things talking to eachother haven't been written. There are packages that integrate a forum and a wiki and such together, but they don't provide an easy way to get the data out of them - switching to them also presents huge data migration issues. Mozilla are farthest on the game here, as they were working on writing some of their own custom stuff based on OpenID, however that then deals with the need of having each app support an OpenID login. I'm not sure if it's a good idea, but there may be some merit in having one of the accounts function as an OpenID Provider and then have the others be able to link to it (but still be "separate accounts"). After that it's just about being able to login by OpenID rather than have a single account moving across each place. Thanks, Scott Ritchie

3 3

D3D shader assembler
by Matteo Bruni 20 Jul '09

20 Jul '09

Hi to everybody, I'm sending here the main assembler patch for reviews and suggestions. It is bzipped as it is quite a big patch, but I couldn't find a meaningful way to split it. A quick mile-high overview: the assembler is divided in a parser and a bytecode writer. The parser is made by the flex (asmshader.l) and bison (asmshader.y) source files and the asmparser.c file. The bytecode writer is in bytecodewriter.c, btw, and asmutils.c contains some utility functions used in the assembler. With the asmshader.l SlAssembleShader function the parser processes the shader and returns an intermediate representation of it into the wine_shader struct. Then this struct is passed to the bytecode writer with the SlWriteBytecode function, which produces the assembled shader bytecode. A "point of interest": in the bottom part of asmshader.h there are some definitions borrowed from wined3d. They are used only internally, so they should not be a problem, but I'd like to hear if you think differently (ex. it is better to rename them?). Thank you, Matteo Bruni

3 8

How to expanding environmental variables?
by Austin English 20 Jul '09

20 Jul '09

Howdy all, I'm working on a automated test for Photoshop CS 2. As before, I'm trying to do so in a portable way, so it works on various locales/windows versions (or as much as possible). Because of wine/windows differences, I need a portable way to get to the shared documents folder, e.g.,: Windows XP: C:\Documents and Settings\All Users\Shared Documents WIndows Vista: C:\users\Public\Public Documents Wine: C:\users\Public\Documents Windows has several variables for this sort of thing (http://msdn.microsoft.com/en-us/library/ms933062(WinEmbedded.5).aspx). In particular, I need a way to return what %16430% is on the target system. I've tried using cmd.exe to echo it, but it's not expanding it. Does anyone know how I can expand this type of variable? I figured there's probably something in shell32 that can accomplish this, but nothing popped up at me immediately (and I'm about to run, so I wanted to e-mail before I leave). Surely there's an easy way and I'm just overlooking it... Thanks! -- -Austin

6 7

Re: netapi32: Fix a pointer conversion warning on 64-bit
by Juan Lang 20 Jul '09

20 Jul '09

Hi André, @@ -577,7 +577,7 @@ static UCHAR NetBTinetResolve(const UCHAR name[NCBNAMSZ], (*cacheEntry)->numAddresses = i; for (i = 0; i < (*cacheEntry)->numAddresses; i++) (*cacheEntry)->addresses[i] = - (DWORD)host->h_addr_list[i]; + (DWORD_PTR)host->h_addr_list[i]; This isn't correct, as the lvalue is still a DWORD, and needs to remain a DWORD. If you like you can check that the length, host->h_length, is the same as sizeof(DWORD), but this is pretty well implied by the use of gethostbyname(): it only returns addresses of type AF_INET. Basically, the warning is a false positive. --Juan

1 0

Re: XkbSetDetectableAutoRepeat not working on some platforms
by F Capela 20 Jul '09

20 Jul '09

From: Dmitry Timoshkov <dmitry(a)codeweavers.com> > "F Capela" <fabio.capela(a)yahoo.com> wrote: > > > XkbSetDetectableAutoRepeat is not working correctly on some > > distributions, including Ubuntu 9.04. In practical terms, this > > means programs running under Wine on such distros are unable to > > ignore autorepeat, doing strange things to games that use keyboard > > controls, for example. One way to work around the problem is to > > manually filter out the key release messages, which can be done > > with a few extra lines in dlls/winex11.drv/event.c . My question is, > > should I send a patch enabling this filtering? From what I have seen, > > patches to work around bugs that are clearly outside Wine are usually > > not accepted. > > Have you reported a bug to XOrg and those distros about that? > > -- Dmitry. I have not yet filled a bug with Ubuntu (which is the distro I'm using), I'll do it as soon as I find how, but while searching for information about this issue I saw a bug filled for Gentoo (which I'm not sure if it's still present), and there are two open bugs under bugs.freedesktop.org (http://bugs.freedesktop.org/show_bug.cgi?id=22194 and http://bugs.freedesktop.org/show_bug.cgi?id=22515) about XkbSetDetectableAutoRepeat not working, both filled in june, one reported under Ubuntu and the other for the GIT version. A bit of extra information, the only software I use that seems to be affected is World of Warcraft; the walk animation stutters when using the keyboard to move, and some things that should not auto repeat (jumps, spell casting, etc) do repeat. BTW, the same bug will happen (and be wine's fault) if the X server does not support DetectableAutorepeat, since when it calls XkbSetDetectableAutoRepeat in dlls/winex11.drv/x11drv_main.c, wine does not care about the function's return value or third argument (although I don't think there is any widely used version of the X server that don't support DetectableAutorepeat). Fábio Oliveira Schmidt Capela

1 0

Re: suggestions about MacOS DYLD_FALLBACK_LIBRARY_PATH patch
by James Mckenzie 20 Jul '09

20 Jul '09

>On Sun, Jul 19, 2009 at 12:23 PM, Emmanuel Maillard<mahanuu(a)free.fr> wrote: >> But it's an external appplication, your desktop environment, that handle >> *.desktop file; wine just generate them... > >As per the private email I sent. I could see that working if we can >convince Alexandre of the need of an external helper application for >OS X. Keeping the existing winemenubuilder code mostly as is and >having it write xdg menus and associations would be pretty simple. We >could just change a few lines to have it write xdg in >~/Library/Application Support/Wine/WineMenuBuilder > >> So don't choose ~/Applications but : /Applications/Wine or >> let's the user to choose if want an Applications folder in is Homedir. > >The reason for using ~/Applications as opposed to /Applications is >that Wine has no knowledge or real support for multi-user prefixes. >Each .wine being local to the user that creates it will have their own >applications, etc. If we write the menus to /Applications and another >user logs in then they won't be able to run those applications. Another good reason is that /Applications can only be written to by an administrative user using sudo. James McKenzie

1 0

RE: D3D shader assembler (Matteo Bruni)
by Matteo Bruni 20 Jul '09

20 Jul '09

2009/7/20 "Luis C. Busquets Pérez" <luis.busquets(a)ilidium.com>: > I read several months ago that the itnetion was to create the assembler > inside the wined3d and then use its functionality inside the diverse d3dx9 > implementations. Has this changed? I think it was Stefan Dösinger sho > proposed it: > > d3dx -> wined3d assembler > the wined3d will be re-usable and the d3dx functions will be extremely easy. > > > Yes, the plan changed in the meantime. Now d3dx8 isn't in Wine anymore (it wasn't used before anyway, the apps using d3dx8 are usually linked against a static version of the library) so the assembler is needed only by d3dx9. The assembler can be put into d3dx9_36 and the other d3dx9_xx dlls can forward to it, as it is for the other d3dx9 functions. DirectX 10 doesn't support anymore assembler shaders, only HLSL one, so no worry from there. That said, maybe a part of the assembler, the bytecode writer, could be useful for the shader compiler. So that part could be moved into wined3d to have it in common between the assembler and the compiler, but this is not something that will happen (if it will happen) soon.

1 0

Re: advapi32: test a combination of CreateServiceA and GetSecurityInfo
by Alexandre Julliard 20 Jul '09

20 Jul '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + /* Wait a while. The following test also does a CreateService for the > + * same servicename and this would result in an ERROR_SERVICE_MARKED_FOR_DELETE > + * error if we do this to quick. Vista seems more picky then the others. > + */ > + Sleep(1000); > + > + svc_handle1 = CreateServiceA(scm_handle, servicename, NULL, SERVICE_ALL_ACCESS, SERVICE_WIN32_SHARE_PROCESS, > + SERVICE_DEMAND_START, SERVICE_ERROR_NORMAL, pathname, NULL, NULL, NULL, NULL, NULL); > + ok(svc_handle1 != NULL, "Could not create the service : %d\n", GetLastError()); > + if (svc_handle1 != NULL) { > + PSID sidOwner, sidGroup; > + PACL dacl, sacl; > + PSECURITY_DESCRIPTOR pSD; > + HRESULT retval = GetSecurityInfo(svc_handle1,SE_SERVICE,DACL_SECURITY_INFORMATION,&sidOwner,&sidGroup,&dacl,&sacl,&pSD); > + todo_wine ok(ERROR_SUCCESS == retval, "Expected GetSecurityInfo to succeed: result %d\n",retval); > + } You could insert that into one of the other tests that already create a service, so that we don't need to have too many Sleeps in there. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dsound: Fix some pointer conversion warnings on 64-bit
by Alexandre Julliard 20 Jul '09

20 Jul '09

André Hentschel <nerv(a)dawncrow.de> writes: > --- a/dlls/dsound/propset.c > +++ b/dlls/dsound/propset.c > @@ -109,7 +109,7 @@ static HRESULT WINAPI IKsBufferPropertySetImpl_Get( > S(prop).Set = *guidPropSet; > S(prop).Id = dwPropID; > S(prop).Flags = 0; /* unused */ > - S(prop).InstanceId = (ULONG)This->dsb->device; > + S(prop).InstanceId = (ULONG_PTR)This->dsb->device; If the destination is a DWORD changing the cast is only hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Doing better than barely keeping up with bug reports - Bug Day this Monday (July 20)
by Scott Ritchie 20 Jul '09

20 Jul '09

So, briefly: Over the past few months, users have added an average of between 12 and 14 bugs every day. Since June 1st: - 412 total bugs filed - 87 bugs resolved invalid - 227 bugs resolved fixed - 133 bugs confirmed but not resolved (status new) - 292 bugs created but unconfirmed Doing some subtraction that means we have 292 new untriaged bugs, but we triaged or fixed (412-292-87-227-133) = 327 old bugs. So, we're swimming above water, which is good. But at this rate it'll be years before we triage every bug. So, let's do something :) Bug Jam this Monday! One idea that has been tried in the past is to hold regular bug days. We've had a lot of success with them in Ubuntu as a way of organizing non developer volunteers, especially when we focus the event on a particular package. Today's bug day, for instance, tackled over a 100 Synaptic bugs: https://wiki.ubuntu.com/UbuntuBugDay/20090716 I'd like to attempt this in Wine. We tried it once in the past, but no one's organizing it now. Even if it's just me and 2 people testing a handful of bugs in our favorite apps, it'll still sink a good number of bugs and help drain the swamp. I'm picking Monday for bug day for a few reasons - it's both after a new release and after the weekend, so users will have already had time to play their games and see if they're still affected. If there's any sort of success, hopefully this will become a regular event. So, if you're into bug triage, please come and join me in #winehackers this Monday. The purpose of triaging bugs is to ultimately get them fixed, so if you're a developer and would rather work on patches then by all means do that instead. I've created a wiki page for the event here: http://wiki.winehq.org/BugDay When we're done I'll poke bugzilla for some stats and we can see how much of a success the event was. Thanks, Scott Ritchie

4 4

Re: msi: Fix some pointer conversion warnings on 64-bit(try2)
by Mike Kaplinskiy 20 Jul '09

20 Jul '09

André Hentschel wrote: > didnt want to change both variables, now its fine > sry for the noise > --- > dlls/msi/join.c | 5 +++-- > dlls/msi/msiquery.c | 4 ++-- > dlls/msi/storages.c | 2 +- > dlls/msi/streams.c | 2 +- > 4 files changed, 7 insertions(+), 6 deletions(-) > > > > + UINT_PTR i > + UINT row_value; Missing a semicolon? ;) Mike.

1 0

RE: D3D shader assembler (Matteo Bruni)
by "Luis C. Busquets Pérez" 20 Jul '09

20 Jul '09

I read several months ago that the itnetion was to create the assembler inside the wined3d and then use its functionality inside the diverse d3dx9 implementations. Has this changed? I think it was Stefan Dösinger sho proposed it: d3dx -> wined3d assembler the wined3d will be re-usable and the d3dx functions will be extremely easy.

1 0

XkbSetDetectableAutoRepeat not working on some platforms
by F Capela 20 Jul '09

20 Jul '09

XkbSetDetectableAutoRepeat is not working correctly on some distributions, including Ubuntu 9.04. In practical terms, this means programs running under Wine on such distros are unable to ignore autorepeat, doing strange things to games that use keyboard controls, for example. One way to work around the problem is to manually filter out the key release messages, which can be done with a few extra lines in dlls/winex11.drv/event.c . My question is, should I send a patch enabling this filtering? From what I have seen, patches to work around bugs that are clearly outside Wine are usually not accepted. I'm adding the patch inlined in this message for those that might want to look at it; if I feel the patch do have a chance to be accepted I will resend to wine-patches. Fábio Oliveira Schmidt Capela fabio.capela(a)yahoo.com diff --git a/dlls/winex11.drv/event.c b/dlls/winex11.drv/event.c index a965b9f..793b842 100644 --- a/dlls/winex11.drv/event.c +++ b/dlls/winex11.drv/event.c @@ -283,6 +283,13 @@ static enum event_merge_action merge_events( XEvent *prev, XEvent *next ) return MERGE_DISCARD; } break; + case KeyRelease: + if (prev->xany.window == next->xany.window && next->type == KeyPress && next->xkey.time == prev->xkey.time && next->xkey.keycode == prev->xkey.keycode && next->xkey.state == prev->xkey.state) + { + TRACE( "Discarding autorepeat key release for window %lx\n", prev->xany.window ); + return MERGE_DISCARD; + } + break; } return MERGE_HANDLE; }

2 1

appinstall update: Adobe Photoshop CS 2 installer test added
by Austin English 20 Jul '09

20 Jul '09

For those interested, I've added a test for the Photoshop CS 2 demo installer (http://code.google.com/p/winezeug/source/detail?r=580 / http://winezeug.googlecode.com/svn/trunk/appinstall/scripts/photoshopcs2.ahk). Currently, the test only installs the demo and verifies the install. I'll add tests to make sure it starts up in the next day or so. Whlie it works, I found a few previously hidden bugs: http://bugs.winehq.org/show_bug.cgi?id=19342 - Adobe Photoshop CS2: Doesn't display license screen for installation (appinstall) http://bugs.winehq.org/show_bug.cgi?id=19343 - Adobe Photoshop CS2: Edit controls have wrong names (appinstall) http://bugs.winehq.org/show_bug.cgi?id=19344 - Adobe Photoshop CS2: Some files missing on installation (appinstall) If you've got a few minutes, check out those bugs and see if you have any information about them. Other than that, CS 2 seems to install fine. P.S., I'm working on some instructions for writing new tests, that I'll put on the wiki (later tomorrow-ish). While the testing framework is mostly complete, it's still pretty alpha/beta, and stuff may change, as I find different features that I need/bugs to workaround. It's at a point though that most of the 'core' stuff shouldn't change. If you'd like to help with adding tests, shoot me an e-mail if you've got more specific questions. -- -Austin

2 2

Re: Add stub for IoOpenDeviceRegistryKey
by James McKenzie 19 Jul '09

19 Jul '09

Uwe Bonnes wrote: This needs a test case to demonstrate what will happen in Windows versus what you are proposing as a stub out that always returns SUCCESS. James McKenzie

1 0

SVG Logo from the website
by Joel Holdsworth 19 Jul '09

19 Jul '09

Quick question: Does anyone have an SVG of the wine logo as used on the wine website? I'd like to use it as part of my graphics refresh to improve idb_wine.bmp as shown here: http://www.airwebreathe.org.uk/wine-icon/

3 4

Re: winealsa.drv: Re-allow fallback to waveout (regression in dsound)
by Nikolay Sivov 19 Jul '09

19 Jul '09

On Sun, Jul 19, 2009 at 9:55 AM, Erich Hoover<ehoover(a)mines.edu> wrote: > Real Name: > Erich Hoover > Description: > Commit 'f27d88e16fe0292d3efa7dac8966a0b612e62e6d' resulted in a > regression in the support of dsound, causing C&C3 and C&C3: Kane's > Wrath to crash on load (Bug #19369). This patch reverts the fallback > to waveout that was removed by the commit (code unrelated to the rest > of the patch). > Changelog: > winealsa.drv: Re-allow fallback to waveout (regression in dsound) > > > Hi, Eric. You forgot a patch.

2 1

Re: Initial italian translation for taskmgr
by Nikolay Sivov 18 Jul '09

18 Jul '09

On Sat, Jul 18, 2009 at 9:25 PM, Davide Pizzetti<erpizzo(a)alice.it> wrote: > Here's the initial translation for taskmgr > > > > Same here. Add file first with 'git add' then 'git commit' changes, and send 'git format-patch' output.

1 0

Re: Initial italian translation for reg
by Nikolay Sivov 18 Jul '09

18 Jul '09

On Sat, Jul 18, 2009 at 9:23 PM, Davide Pizzetti<erpizzo(a)alice.it> wrote: > Here's the initial italian translation for reg > Your patch should create new file It.rc, it can't be applied now.

1 0

Re: kernel32: Update French translation of error messages.
by Paul Vriens 18 Jul '09

18 Jul '09

Frédéric Delanoy wrote: > Added translation for missing string. > FWIW the Wine translation stats page (http://source.winehq.org/transl/) doesn't mention non-translated strings in kernel32/dlls/winerr_XXX.mc > Maybe this could be added... > > Frédéric > > > ------------------------------------------------------------------------ > > Hi Frédéric, I think that the issue is with wrc. Nonetheless, still worth fixing of course. -- Cheers, Paul.

1 0

Re: patch: fixed Dutch translation
by Paul Vriens 18 Jul '09

18 Jul '09

On 17 jul 2009, at 23:33, Vincent Beers <vincentbeers(a)gmail.com> wrote: > This is my first patch, ever, so please bear with me and tell me if > I made any mistakes in generating and submitting the patch. :) > > This is a simple patch that improves the Dutch translation in winecfg. > > Vincent Beers You could start by sending the patch ;) Paul

1 0

re: Doing better than barely keeping up with bug reports - Bug Day this Monday (July 20)
by Dan Kegel 18 Jul '09

18 Jul '09

> DELETED BugDay 12:33 Informations DmitryTimoshkov #01 Not useful, eveone works on bugs or features at its own preference, at its own time Dmitry's being overly negative, I think, and it's just plain rude to delete wiki pages like that. Let's put it back. That said, it might be wise to post proposals for events and let them percolate for a couple days before announcing them. (In this case, seeing a few enthusiastic replies might have made Dmitry think twice before doing what he did.) - Dan

6 8

Re: Stub implementation for ftd2xx.dll
by Jeff Zaroyko 17 Jul '09

17 Jul '09

On Sat, Jul 18, 2009 at 12:50 AM, Uwe Bonnes<bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > +/* > + * FTD2XX.dll > + * > + * Generated from FTD2XX.dll by winedump. > + * > + * DO NOT SUBMIT GENERATED DLLS FOR INCLUSION INTO WINE! > + * > + */ > + You'll probably want to fix this by inserting the appropriate copyright notice and description of the dll following the style of others. Jeff

1 0

New winetricks 20090716: new verbs droid, wenquanyi, dinput8
by Dan Kegel 17 Jul '09

17 Jul '09

Another fortnight, another winetricks. Three new verbs: two fonts (droid, wenquanyi), and one library (dinput8). (dinput8 is a subset of d3dx9 which is a subset of directx9. The fewer native dlls one installs, the better.) Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL.) Changes since 20090705: ------------------------------------------------------------------------ r576 | daniel.r.kegel | 2009-07-15 21:42:37 -0700 (Wed, 15 Jul 2009) | 2 lines Release version 20090716. ------------------------------------------------------------------------ r575 | daniel.r.kegel | 2009-07-15 21:32:32 -0700 (Wed, 15 Jul 2009) | 4 lines Added Droid verb to install Droid fonts. Don't forget to register Wan Quan Yi font. ------------------------------------------------------------------------ r574 | austinenglish | 2009-07-15 13:30:56 -0700 (Wed, 15 Jul 2009) | 1 line winetricks: Correctly invoke the Shockwave Player installer with msiexec - Patch by Andrew Nguyen ------------------------------------------------------------------------ r573 | daniel.r.kegel | 2009-07-15 09:00:12 -0700 (Wed, 15 Jul 2009) | 2 lines Added wenquanyi font (requested by Axel Xia) ------------------------------------------------------------------------ r558 | austinenglish | 2009-07-10 09:25:22 -0700 (Fri, 10 Jul 2009) | 1 line winetricks: add dinput8 verb (Patch by Erik Inge Bolsø) ------------------------------------------------------------------------ r548 | austinenglish | 2009-07-06 15:40:32 -0700 (Mon, 06 Jul 2009) | 2 lines winetricks: update AutoHotKey to latest version

5 6

Do we want to see untranslated modules on the translations page for "English (United States)"?
by Paul Vriens 17 Jul '09

17 Jul '09

Hi, If a module does not have any translatable resources (for examples dlls/atl) we don't show this module on the language pages. We do however show it on the "English (United States)" one: http://source.winehq.org/transl/lang.php?lang=009%3A01 Do we still want that, or can it be removed so that it matches the other languages? I'm asking as when you go to: http://source.winehq.org/transl/resfile.php?lang=009%3A01&resfile=dlls%2Fatl you'll see that the text is not correct (the first link will get you to this same page). So we either remove the modules that are not translatable from the "English (United States)" page or we have to change that piece of text. -- Cheers, Paul.

2 1

Re: winecfg: add the codepage-pragma for german translation
by Michael Stefaniuc 17 Jul '09

17 Jul '09

André Hentschel wrote: > add the codepage-pragma for german translation, otherwise its displayed > wrong Oops, sorry for the breakage. > --- > programs/winecfg/De.rc | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > Thanks bye michael

1 0

Re: wordpad: Change some string resource ids...
by Paul Vriens 17 Jul '09

17 Jul '09

Michael Stefaniuc wrote: > to logically group the strings in separate STRINGTABLEs. > --- > programs/wordpad/En.rc | 26 +++++++------------------- > programs/wordpad/wordpad.h | 28 ++++++++++++++-------------- > 2 files changed, 21 insertions(+), 33 deletions(-) > > diff --git a/programs/wordpad/En.rc b/programs/wordpad/En.rc > index fe92de7..b6ade3a 100644 > --- a/programs/wordpad/En.rc > +++ b/programs/wordpad/En.rc > @@ -179,10 +179,14 @@ END > > STRINGTABLE DISCARDABLE > BEGIN > - STRING_RICHTEXT_FILES_RTF, "Rich text format (*.rtf)" > + STRING_ALL_FILES, "All documents (*.*)" > STRING_TEXT_FILES_TXT, "Text documents (*.txt)" > STRING_TEXT_FILES_UNICODE_TXT, "Unicode text document (*.txt)" > - STRING_ALL_FILES, "All documents (*.*)" > + STRING_RICHTEXT_FILES_RTF, "Rich text format (*.rtf)" > + STRING_NEWFILE_RICHTEXT, "Rich text document" > + STRING_NEWFILE_TXT, "Text document" > + STRING_NEWFILE_TXT_UNICODE, "Unicode text document" > + STRING_PRINTER_FILES_PRN, "Printer files (*.PRN)" > END > > STRINGTABLE DISCARDABLE > @@ -194,18 +198,6 @@ END > > STRINGTABLE DISCARDABLE > BEGIN > - STRING_NEWFILE_RICHTEXT, "Rich text document" > - STRING_NEWFILE_TXT, "Text document" > - STRING_NEWFILE_TXT_UNICODE, "Unicode text document" > -END > - > -STRINGTABLE DISCARDABLE > -BEGIN > - STRING_PRINTER_FILES_PRN, "Printer files (*.PRN)" > -END > - > -STRINGTABLE DISCARDABLE > -BEGIN > STRING_VIEWPROPS_TITLE, "Options" > STRING_VIEWPROPS_TEXT, "Text" > STRING_VIEWPROPS_RICHTEXT, "Rich text" > @@ -219,11 +211,7 @@ BEGIN > STRING_PREVIEW_TWOPAGES, "Two pages" > STRING_PREVIEW_ONEPAGE, "One page" > STRING_PREVIEW_CLOSE, "Close" > -END > - > -STRINGTABLE DISCARDABLE > -BEGIN > - STRING_UNITS_CM, "cm" > + STRING_UNITS_CM, "cm" > END > > STRINGTABLE DISCARDABLE > diff --git a/programs/wordpad/wordpad.h b/programs/wordpad/wordpad.h > index 6d3e64a..b51bec8 100644 > --- a/programs/wordpad/wordpad.h > +++ b/programs/wordpad/wordpad.h > @@ -172,24 +172,24 @@ > #define STRING_NEWFILE_TXT 1405 > #define STRING_NEWFILE_TXT_UNICODE 1406 > > -#define STRING_ALIGN_LEFT 1407 > -#define STRING_ALIGN_RIGHT 1408 > -#define STRING_ALIGN_CENTER 1409 > +#define STRING_PRINTER_FILES_PRN 1407 > > -#define STRING_PRINTER_FILES_PRN 1410 > +#define STRING_ALIGN_LEFT 1416 > +#define STRING_ALIGN_RIGHT 1417 > +#define STRING_ALIGN_CENTER 1418 > > -#define STRING_VIEWPROPS_TITLE 1411 > -#define STRING_VIEWPROPS_TEXT 1412 > -#define STRING_VIEWPROPS_RICHTEXT 1413 > +#define STRING_VIEWPROPS_TITLE 1432 > +#define STRING_VIEWPROPS_TEXT 1433 > +#define STRING_VIEWPROPS_RICHTEXT 1434 > > -#define STRING_PREVIEW_PRINT 1414 > -#define STRING_PREVIEW_NEXTPAGE 1415 > -#define STRING_PREVIEW_PREVPAGE 1416 > -#define STRING_PREVIEW_TWOPAGES 1417 > -#define STRING_PREVIEW_ONEPAGE 1418 > -#define STRING_PREVIEW_CLOSE 1419 > +#define STRING_PREVIEW_PRINT 1448 > +#define STRING_PREVIEW_NEXTPAGE 1449 > +#define STRING_PREVIEW_PREVPAGE 1450 > +#define STRING_PREVIEW_TWOPAGES 1451 > +#define STRING_PREVIEW_ONEPAGE 1452 > +#define STRING_PREVIEW_CLOSE 1453 > > -#define STRING_UNITS_CM 1420 > +#define STRING_UNITS_CM 1454 > > #define STRING_DEFAULT_FILENAME 1700 > #define STRING_PROMPT_SAVE_CHANGES 1701 There won't be any issue for the translations (just checked with transl), but the .rc files will look totally different now. I guess we need to tell the translators to make those same changes for consistency sake? -- Cheers, Paul.

2 1

Re: [4/4] WineD3D: Don't activate a context unless we need one
by Stefan Dösinger 17 Jul '09

17 Jul '09

Am Friday 17 July 2009 11:51:40 schrieb Stefan Dösinger: Actually, the [4/4] was unintended. This is the only patch I intended to send

1 0

Request: Packaging component (or product) for Bugzilla
by Scott Ritchie 17 Jul '09

17 Jul '09

Alexandre and I were talking on IRC today about what to do with bugs caused by packaging issues. Most of these are bugs in the packages provided by WineHQ.org and not by the distributions proper (who instead ship stable Wine versions). Consequently, users expect to file the bugs in our bug tracker since there's no where else for them to go. However, non-packager Wine developers don't want to see these bugs, as they're frequently just noise and not their problem. But closing them invalid doesn't quite help, since otherwise the problem might not be fixed. That's where the packaging component (or product) comes in - once an issue is deduced to be a packaging error (say, a missing build dep), then it can just be reassigned and the relevant packager auto-subscribed. Thanks, Scott Ritchie

1 0

gdiplus errors - how to use a workaround
by Susan Cragin 16 Jul '09

16 Jul '09

A few months ago I tried compiling wine without all the dependencies that are downloaded with apt-get build-dep wine. I just used a minimum, as wine asked for them. To my surprise, in Dragon NaturallySpeaking the DragonBar came up very crudely sketched, but all the buttons worked. That hasn't happened since. I was wondering if anyone knew which wine dependencies were responsible for this. As a wild guess, I would imagine that it involves compiling without support for the fancy functions of gdiplus. FYI -- using winetricks gdiplus does not work at all. it makes the program crash.

1 0

Re: [winhttp] Fix a crash on Vista and higher
by Frédéric Delanoy 16 Jul '09

16 Jul '09

On Thu, Jul 16, 2009 at 3:48 PM, Paul Vriens<paul.vriens.wine(a)gmail.com> wrote: > Changelog > Fix a crash on Vista and higher > > -- > Cheers, > > Paul. > > From b5e1d29ba2f5d5dd8a74c5b9abb301c0f81a5cb3 Mon Sep 17 00:00:00 2001 > From: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> > Date: Thu, 16 Jul 2009 15:47:38 +0200 > Subject: [PATCH] Fix a crash on Vista and higher > > --- > dlls/winhttp/tests/winhttp.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c > index 78c4777..bce91fe 100644 > --- a/dlls/winhttp/tests/winhttp.c > +++ b/dlls/winhttp/tests/winhttp.c > @@ -905,10 +905,14 @@ static void test_set_default_proxy_config(void) > len = get_default_proxy_reg_value( saved_proxy_settings, len, &type > ); > } > > - SetLastError(0xdeadbeef); > - ret = WinHttpSetDefaultProxyConfiguration(NULL); > - ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, > - "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); > + if (0) > + { > + /* Crashes on Vista and higher */ > + SetLastError(0xdeadbeef); > + ret = WinHttpSetDefaultProxyConfiguration(NULL); > + ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, > + "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); > + } > > /* test with invalid access type */ > info.dwAccessType = 0xdeadbeef; > -- > 1.6.0.6 Maybe a stupid question, but why do you completely disable the test if "only" Vista and up are affected? Frédéric

2 1

Re: [1/2] ws2_32/tests: IPv6 tests for WSAAddressToStringW
by Alexandre Julliard 16 Jul '09

16 Jul '09

Jeff Latimer <lats(a)yless4u.com.au> writes: > @@ -1542,7 +1556,103 @@ static void test_WSAAddressToStringW(void) > ok( !ret, "WSAAddressToStringW() failed unexpectedly: %d\n", WSAGetLastError() ); > > ok( !lstrcmpW( address, expect4 ), "Expected different address string\n" ); > - ok( len == sizeof( expect4 )/sizeof( WCHAR ), "Got size %d\n", len); > + ok( len == sizeof( expect4 )/sizeof( WCHAR ), "Expected size to be %d, got %d\n", sizeof( expect4 )/sizeof( WCHAR ), len); Please don't use sizeof in traces. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] gdi32/tests: Added tests for StretchBlt
by Alexandre Julliard 16 Jul '09

16 Jul '09

Joel Holdsworth <joel(a)airwebreathe.org.uk> writes: > From a08096193c2593e8c99558814472e607696534f6 Mon Sep 17 00:00:00 2001 > From: Joel Holdsworth <joel(a)airwebreathe.org.uk> > Date: Wed, 15 Jul 2009 22:16:31 +0100 > Subject: [PATCH] Added tests for StretchBlt It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so bitmap.c && touch bitmap.ok bitmap.c:2348: Test succeeded inside todo block: StretchBlt with dwRop 1100A6. Expected 0x00000000, got 0x00000000 from line 2412 bitmap.c:2348: Test failed: StretchBlt with dwRop 5A0049. Expected 0x89D39BDB, got 0x00D39BDB from line 2417 bitmap.c:2348: Test failed: StretchBlt with dwRop 550009. Expected 0x76543210, got 0x00543210 from line 2418 bitmap.c:2348: Test failed: StretchBlt with dwRop FF0062. Expected 0xFFFFFFFF, got 0x00FFFFFF from line 2420 bitmap.c:2361: Test failed: StretchBlt expected { CAFED00D, FEEDFACE, FEDCBA98, 76543210 } got { 00FED00D, 00EDFACE, 00DCBA98, 00543210 } stretching { 0, 0, 2, 2 } to { 0, 0, 2, 2 } from line 2432 bitmap.c:2361: Test failed: StretchBlt expected { CAFED00D, 00000000, 00000000, 00000000 } got { 00FED00D, 00000000, 00000000, 00000000 } stretching { 0, 0, 1, 1 } to { 0, 0, 1, 1 } from line 2437 bitmap.c:2361: Test failed: StretchBlt expected { 00000000, 00000000, 00000000, CAFED00D } got { 00000000, 00000000, 00000000, 00FED00D } stretching { 0, 0, 2, 2 } to { 1, 1, 2, 2 } from line 2473 bitmap.c:2361: Test failed: StretchBlt expected { FEDCBA98, 76543210, CAFED00D, FEEDFACE } got { 00DCBA98, 00543210, 00FED00D, 00EDFACE } stretching { 0, 0, 2, 2 } to { 0, 0, 2, 2 } from line 2487 bitmap.c:2361: Test failed: StretchBlt expected { CAFED00D, FEEDFACE, FEDCBA98, 76543210 } got { 00FED00D, 00EDFACE, 00DCBA98, 00543210 } stretching { 0, 0, 2, 2 } to { 0, 0, 2, 2 } from line 2508 bitmap.c:2361: Test failed: StretchBlt expected { FEDCBA98, 76543210, CAFED00D, FEEDFACE } got { 00DCBA98, 00543210, 00FED00D, 00EDFACE } stretching { 0, 0, 2, 2 } to { 0, 0, 2, 2 } from line 2527 make: *** [bitmap.ok] Error 10 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: Explicitly initialize visible order of a newly added item, force visible order recalculation on redraw.
by Austin English 16 Jul '09

16 Jul '09

On Thu, Jul 16, 2009 at 3:34 AM, Dmitry Timoshkov<dmitry(a)codeweavers.com> wrote: > This patch should fix the regression reported in the bug 19338. > --- > dlls/comctl32/treeview.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Can you possibly add a testcase for this to prevent further regressions? -- -Austin

2 1

re: Wine very very slow in Chinese language of Linux
by Dan Kegel 16 Jul '09

16 Jul '09

Axel wrote: > When using WINE in Chinese environment Linux, the WINE works very very slow even opening windows / clicking buttons.... Does this happen with the latest wine (1.1.25)? If so, can you show us how to reproduce the problem on an ubuntu 9.04 system? Remember, most of us don't speak chinese, so you'll need to be very explicit with your instructions. Thanks, Dan

5 5

which release of Wine created or last updated this particular .wine/ tree?
by Joerg-Cyril.Hoehle＠t-systems.com 16 Jul '09

16 Jul '09

Hi, my HD contains a dozen .wine*/ directories created with various settings and releases of Wine, some a long time ago. A repeating question is: With what release of Wine did I create this particular .wine/ tree ? Or rather: what release last updated this .wine/ tree? It is not acceptable to run ~/src/most-current-wine/winecfg "about" on this .wine/ tree since an update that would change the bug footprint, causing the tested apps to work differently. At the time of ~0.9.60, the answer was easy because tools/wine.inf was copied into .wine/drive_c/windows/inf/wine.inf and contained a release number. Another possibility would be that I build a mini-DB of e.g. drive_c/windows/notepad's md5. Not very reliable, as notepad.exe need not change with every release. Any other ideas? Jörg Höhle.

3 3

Re: winequartz.drv Mac OS X UI discontinued?
by James Mckenzie 15 Jul '09

15 Jul '09

>Just to explain things better, I found great sample of calling Obj-C >API within pure C program: >http://www.smipple.net/snippet/moriyoshi/Using%20Objective-C%20ABI%20from%2… >. > >This is basic application that just displays a single window, and YES >it works! >BUT it is 400 lines of code, it is totally obscure. >Having it natively in Obj-C would be ~50 lines of small clean code. So >this is what a call a "nightmare", or maybe "happy coding". Or maybe job security. However, we have a requirement that any code submitted to the Wine project be either c or C++. ObjC cannot be included, however. I would like to see it 'wrapped' so that it could not be compiled and then the world would be upright (and this is how several other projects do this as well.) James McKenzie

8 12

Re: [PATCH 2/3] jscript: Improve Number_toString implementation
by Paul Vriens 15 Jul '09

15 Jul '09

Piotr Caban wrote: > --- > dlls/jscript/number.c | 113 > ++++++++++++++++++++++++++++++++++++++++++-- > dlls/jscript/tests/api.js | 50 +++++++++++++++++-- > 2 files changed, 151 insertions(+), 12 deletions(-) > > > > > ------------------------------------------------------------------------ > > Hi Piotr, These new tests fail on several platforms, see: http://test.winehq.org/data/tests/jscript:run.html Could you have a look? -- Cheers, Paul.

2 2

question about RtlGenRandom (SystemFunction036) and urandom
by winehqlist＠sub.noloop.net 15 Jul '09

15 Jul '09

Hello, I just randomly stumbled upon this old mail http://www.winehq.org/pipermail/wine-patches/2005-May/017718.html and I found the FIXME comment about (lack of) cryptographic quality slightly worrying, so I had a quick look at the gitweb to see what the implementation would look like these days. Apparently this method still uses urandom but the FIXME comment has been removed (in http://source.winehq.org/git/wine.git/?a=commitdiff;h=59f2a3312e4c16876b69f… ) Just thought I'd give it a heads-up, maybe this is still an issue that should at least be marked in the comments?

2 3

Re: gdi32: ensure that the last_resort family at least has FS_LATIN1characters.
by Dmitry Timoshkov 15 Jul '09

15 Jul '09

"Aric Stewart" <aric(a)codeweavers.com> wrote: > Corrects a large number of font issues with east asian programs. > - if(csi.fs.fsCsb[0] & (face->fs.fsCsb[0] | face->fs_links.fsCsb[0])) { > + if((csi.fs.fsCsb[0] & (face->fs.fsCsb[0] | face->fs_links.fsCsb[0])) && (face->fs.fsCsb[0] & FS_LATIN1)) > { Certainly this is a not acceptable hack. What if the app doesn't need latin glyphs at all? Say it needs only cyrillic or symbol ones? -- Dmitry.

2 4

Re: Set the encoding of the remaining German resources to UTF-8.
by Paul Vriens 15 Jul '09

15 Jul '09

Michael Stefaniuc wrote: > --- > dlls/browseui/rsrc_De.rc | 2 ++ > dlls/iccvid/iccvid_De.rc | 2 ++ > dlls/localspl/spl_De.rc | 2 ++ > dlls/mpr/mpr_De.rc | 2 ++ > dlls/msacm32/msacm_De.rc | 2 ++ > dlls/msvidc32/msvidc32_De.rc | 2 ++ > dlls/oleaut32/oleaut32_De.rc | 2 ++ > dlls/sane.ds/sane_De.rc | 2 ++ > dlls/shlwapi/shlwapi_De.rc | 2 ++ > dlls/wininet/wininet_De.rc | 2 ++ > programs/write/De.rc | 2 ++ > 11 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/dlls/browseui/rsrc_De.rc b/dlls/browseui/rsrc_De.rc > index b32400c..9a0b78e 100644 > --- a/dlls/browseui/rsrc_De.rc > +++ b/dlls/browseui/rsrc_De.rc > @@ -19,6 +19,8 @@ > > #include "resids.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > STRINGTABLE > diff --git a/dlls/iccvid/iccvid_De.rc b/dlls/iccvid/iccvid_De.rc > index 3262c91..d1a3cef 100644 > --- a/dlls/iccvid/iccvid_De.rc > +++ b/dlls/iccvid/iccvid_De.rc > @@ -19,6 +19,8 @@ > > #include "iccvid_private.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > STRINGTABLE DISCARDABLE > diff --git a/dlls/localspl/spl_De.rc b/dlls/localspl/spl_De.rc > index 4e6616e..b30e13c 100644 > --- a/dlls/localspl/spl_De.rc > +++ b/dlls/localspl/spl_De.rc > @@ -21,6 +21,8 @@ > > #include "localspl_private.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > STRINGTABLE DISCARDABLE > diff --git a/dlls/mpr/mpr_De.rc b/dlls/mpr/mpr_De.rc > index 662cad5..d8b1298 100644 > --- a/dlls/mpr/mpr_De.rc > +++ b/dlls/mpr/mpr_De.rc > @@ -20,6 +20,8 @@ > > #include "mprres.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > STRINGTABLE DISCARDABLE > diff --git a/dlls/msacm32/msacm_De.rc b/dlls/msacm32/msacm_De.rc > index cd4353a..1f35148 100644 > --- a/dlls/msacm32/msacm_De.rc > +++ b/dlls/msacm32/msacm_De.rc > @@ -20,6 +20,8 @@ > > #include "wineacm.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > DLG_ACMFORMATCHOOSE_ID DIALOG DISCARDABLE 10, 20, 225, 100 > diff --git a/dlls/msvidc32/msvidc32_De.rc b/dlls/msvidc32/msvidc32_De.rc > index c31635c..1dc777b 100644 > --- a/dlls/msvidc32/msvidc32_De.rc > +++ b/dlls/msvidc32/msvidc32_De.rc > @@ -19,6 +19,8 @@ > > #include "msvidc32_private.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > STRINGTABLE DISCARDABLE > diff --git a/dlls/oleaut32/oleaut32_De.rc b/dlls/oleaut32/oleaut32_De.rc > index e0ae38b..1dbee3e 100644 > --- a/dlls/oleaut32/oleaut32_De.rc > +++ b/dlls/oleaut32/oleaut32_De.rc > @@ -20,6 +20,8 @@ > > #include "resource.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > STRINGTABLE DISCARDABLE > diff --git a/dlls/sane.ds/sane_De.rc b/dlls/sane.ds/sane_De.rc > index a1be1e4..3f3e116 100644 > --- a/dlls/sane.ds/sane_De.rc > +++ b/dlls/sane.ds/sane_De.rc > @@ -20,6 +20,8 @@ > > #include "resource.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > IDD_DIALOG1 DIALOG DISCARDABLE 0, 0, 186, 46 > diff --git a/dlls/shlwapi/shlwapi_De.rc b/dlls/shlwapi/shlwapi_De.rc > index f0de193..f74600f 100644 > --- a/dlls/shlwapi/shlwapi_De.rc > +++ b/dlls/shlwapi/shlwapi_De.rc > @@ -20,6 +20,8 @@ > > #include "resource.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > IDD_ERR_DIALOG DIALOG MOVEABLE DISCARDABLE 0, 0, 220, 60 > diff --git a/dlls/wininet/wininet_De.rc b/dlls/wininet/wininet_De.rc > index 9b168b4..4766589 100644 > --- a/dlls/wininet/wininet_De.rc > +++ b/dlls/wininet/wininet_De.rc > @@ -18,6 +18,8 @@ > > #include "resource.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > IDD_PROXYDLG DIALOG LOADONCALL MOVEABLE DISCARDABLE 36, 24, 250, 154 > diff --git a/programs/write/De.rc b/programs/write/De.rc > index a953576..db175a0 100644 > --- a/programs/write/De.rc > +++ b/programs/write/De.rc > @@ -19,6 +19,8 @@ > > #include "resources.h" > > +#pragma code_page(65001) > + > LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL > > STRINGTABLE Is there anything against for all .rc files being UTF-8 and having that pragma by default? -- Cheers, Paul.

2 2

Re: wordpad: Fix the English NEUTRAL translation.
by Austin English 15 Jul '09

15 Jul '09

On Tue, Jul 14, 2009 at 6:45 PM, Michael Stefaniuc<mstefani(a)redhat.de> wrote: > --- > programs/wordpad/En.rc | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/programs/wordpad/En.rc b/programs/wordpad/En.rc > index fe92de7..1e1fd2e 100644 > --- a/programs/wordpad/En.rc > +++ b/programs/wordpad/En.rc > @@ -249,7 +249,17 @@ LANGUAGE LANG_ENGLISH, SUBLANG_NEUTRAL > > STRINGTABLE DISCARDABLE > BEGIN > - STRING_ALIGN_LEFT, "Left" > STRING_ALIGN_RIGHT, "Right" > STRING_ALIGN_CENTER, "Centre" Any reason you removed Left but not Right? -- -Austin

2 1

Re: Suggestions about the website of www.winehq.org
by axel_xia 15 Jul '09

15 Jul '09

Sorry that I forget to send the attachments. "Please refer to the attached pictures for the Chinese environment in Fedora 10 & Ubuntu 9.04 by only choosing Chinese language when installing Linux OS." Axel ----- 原文 ----- From:axel_xia@sohu.com Subject:Re: Suggestions about the website of www.winehq.org Hi, Dan, Thanks for your email. And please kindly see my comments below: Reply to topic 1): It is true that it is not leaglly suitable to copy MS fonts, however the open-source fonts (Wenquanyi, http://wenq.org/enindex.cgi) has been available for very long period, which also are probalble used by Fedora & Ubuntu as default Chinese fonts (even Asian/CJK fonts(maybe CKJ means "Chinese Japanese Korean"), but I am not sure). Please refer to the attached pictures for the Chinese environment in Fedora 10 & Ubuntu 9.04 by only choosing Chinese language when installing Linux OS. In my opinion, I do not think we need to add these Chinese fonts into winetricks, instead, we only need by default in wine to create a link between wine & these fonts of Linux OS, just like the way when $MS softwares are installed into Chinese version of $MS windows: the software itself does not include the fonts, but it will share the fonts in OS when displaying Chinese because the Chinese version of OS already has the Chinese fonts installed. I guess it is the best way for www.winehq.org to work together with Redhat/Fedora & Ubutun & other distributions about the fonts linking to Linux OS. Reply to topic 2): I understand that few manpower are available in wine-develop group, but what about finding someone to establish &/ take care of the Chinese version in appdb? And then assign someone in wine-devel who understand Chinese to help monitor the Chinese version of appdb or forums. If so, it allows most of Chinese evaluators to post their test into appdb, which will contribute the development of wine really a lot. And, at least some popular $MS software can be added into winetricks after tests passed, such as Xunlei, flashget, QQ, QQ games. These software are very commonly used in China but always have lots of issues in wine. Huge solutions about these issues have made many confusions but we do not know which solution is right. We then don't need to illeagaly copy $MS .dll if winetricks itself contains these additional .dll files. Reply to topic 3): I insist that different languages of www.winehq.org should be established in long term, and it is feasible to find someone who are native Chinese to monitor the Chinese winehq website. However, in the short term, we can only link to http://forum.ubuntu.org.cn/viewforum.php?f=121 for the most popular forums about wine. And also you can invite forum-monitoring volunteers via that forum and I am sure there are lots of people willing to take care of it. Best regards! Axel ----- 原文 ----- From:Dan Kegel<dank(a)kegel.com> Subject:Re: Suggestions about the website of www.winehq.org On Mon, Jul 13, 2009 at 9:47 PM, <axel_xia(a)sohu.com> wrote: > I am a Chinese user for Fedora and have be trying to use wine for very long > time. Based on my experience in wine evaluation, may I provide my > suggestions on wine development & prospect? Yes, please! But please don't cross-post. Your question probably belongs on wine-devel or wine-users. cc'ing five different mailing lists is not a good idea. > 1) There are many many discussions in the internet about the Chinese font > sets issue in wine (wine very very slow, or can not display Chinese > correctly, & etc). However, most popular Linux distributions almost have no > issues for Chinese character display nowadays, the Chinese version of $MS > windows are perfectly compatible with Chinese character and even all the > softwares for $MS windows use default $MS Chinese fonts without any issues. > So, is that possible for wine/crossover to directly use/share Chinese fonts > (even all fonts of different languages) in linux distributions? As far as I know, the MS chinese fonts are copyrighted, and their license terms do not permit redistribution. (The "microsoft core fonts" were distributed under a very permissive license, and are more or less available on all linux systems, but they don't have good chinese fonts.) If you know of any legally downloadable chinese fonts, please let me know and I'll at least add them to winetricks. If you're saying that Linux already comes with great Chinese fonts, and Wine isn't using them properly, then that sounds like a bug we need to fix. There are two bugs open right now for CJK fonts: http://bugs.winehq.org/show_bug.cgi?id=13829 (fonts aren't found properly) http://bugs.winehq.org/show_bug.cgi?id=16325 (fonts don't look good) Perhaps you should file one for the slow fonts issue. > 2) Is that possible to have someone from winehq.org to verify $MS software > applicable in wine or not(at lease which .dll should be copy into > ~./wine/.../system32)? I found thousands of $MS softwares are posted on > AppDB in www.winehq.org but only checked by evaluators. So I wonder if > possible for winehq.org people to validate these programs and even better to > tell visitors step by step to run each software in wine. I think it is > better to post the correct steps of $MS software emulation in AppDB because > we need to rely on the offical website. It is harmful that users don't think > AppDB is believable then less and less people will come to www.winehq.org > for help day by day. Sadly, we don't have enough manpower to keep appdb up to date ourselves; we rely on volunteers. Our goal is for there to be no steps needed beyond running setup and starting the app, so that's what Wine developers tend to spend their time on, and we leave appdb updating to volunteers. That said, it would be helpful for somebody to make a pass over the popular apps in the appdb and update the howtos, including converting ad hoc installation steps into winetricks steps as appropriate. Any volunteers? > 3) Is that possible to open accounts in Forums of winehq website for common > users? And also is that possible to have different forums in Chinese or in > other languages established worldwide? That's a good idea. We can also link to any other Wine forums that already exist in other languages; do you know of any in Chinese? Thanks again for writing. We've known for a long time that we have some issues with Asian languages, but since most of our developers are not fluent in Asian languages, we haven't made much progress on it. We rely on feedback like the messages you've been sending lately. - Dan 寻找童趣好游戏让你停不下来抽奖换礼，好运有你！

1 0

Re: Suggestions about the website of www.winehq.org
by Dan Kegel 15 Jul '09

15 Jul '09

On Mon, Jul 13, 2009 at 9:47 PM, <axel_xia(a)sohu.com> wrote: > I am a Chinese user for Fedora and have be trying to use wine for very long > time. Based on my experience in wine evaluation, may I provide my > suggestions on wine development & prospect? Yes, please! But please don't cross-post. Your question probably belongs on wine-devel or wine-users. cc'ing five different mailing lists is not a good idea. > 1) There are many many discussions in the internet about the Chinese font > sets issue in wine (wine very very slow, or can not display Chinese > correctly, & etc). However, most popular Linux distributions almost have no > issues for Chinese character display nowadays, the Chinese version of $MS > windows are perfectly compatible with Chinese character and even all the > softwares for $MS windows use default $MS Chinese fonts without any issues. > So, is that possible for wine/crossover to directly use/share Chinese fonts > (even all fonts of different languages) in linux distributions? As far as I know, the MS chinese fonts are copyrighted, and their license terms do not permit redistribution. (The "microsoft core fonts" were distributed under a very permissive license, and are more or less available on all linux systems, but they don't have good chinese fonts.) If you know of any legally downloadable chinese fonts, please let me know and I'll at least add them to winetricks. If you're saying that Linux already comes with great Chinese fonts, and Wine isn't using them properly, then that sounds like a bug we need to fix. There are two bugs open right now for CJK fonts: http://bugs.winehq.org/show_bug.cgi?id=13829 (fonts aren't found properly) http://bugs.winehq.org/show_bug.cgi?id=16325 (fonts don't look good) Perhaps you should file one for the slow fonts issue. > 2) Is that possible to have someone from winehq.org to verify $MS software > applicable in wine or not(at lease which .dll should be copy into > ~./wine/.../system32)? I found thousands of $MS softwares are posted on > AppDB in www.winehq.org but only checked by evaluators. So I wonder if > possible for winehq.org people to validate these programs and even better to > tell visitors step by step to run each software in wine. I think it is > better to post the correct steps of $MS software emulation in AppDB because > we need to rely on the offical website. It is harmful that users don't think > AppDB is believable then less and less people will come to www.winehq.org > for help day by day. Sadly, we don't have enough manpower to keep appdb up to date ourselves; we rely on volunteers. Our goal is for there to be no steps needed beyond running setup and starting the app, so that's what Wine developers tend to spend their time on, and we leave appdb updating to volunteers. That said, it would be helpful for somebody to make a pass over the popular apps in the appdb and update the howtos, including converting ad hoc installation steps into winetricks steps as appropriate. Any volunteers? > 3) Is that possible to open accounts in Forums of winehq website for common > users? And also is that possible to have different forums in Chinese or in > other languages established worldwide? That's a good idea. We can also link to any other Wine forums that already exist in other languages; do you know of any in Chinese? Thanks again for writing. We've known for a long time that we have some issues with Asian languages, but since most of our developers are not fluent in Asian languages, we haven't made much progress on it. We rely on feedback like the messages you've been sending lately. - Dan

2 1

Wine Appdb is down
by nn 15 Jul '09

15 Jul '09

Hi, Wine Appdb is down ---------------------------------- Warning: mysql_connect() [function.mysql-connect]: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) in /home/winehq/opt/appdb/include/query.php on line 82 Database error, please try again soon: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) ---------------------------------- ____________________________________________________________________________________ Access Yahoo!7 Mail on your mobile. Anytime. Anywhere. Show me how: http://au.mobile.yahoo.com/mail

4 3

Re: wpp: add I/O hooks [try 2]
by Juan Lang 14 Jul '09

14 Jul '09

Hi Matteo, it'd be easier to review your patch if you sent it along with a subsequent patch that made use of the I/O hooks. As it is, it's hard to know why this is necessary. Cheers, --Juan

2 1

Re: [4/4] WineD3D: Don't call glGetError if nobody is going to see our fixme
by Chris Robinson 14 Jul '09

14 Jul '09

It may still be important to do this, if glGetError is ever used directly to check for errors. Errors that are normally caught by checkGLError would then be left for a later call to glGetError to pick up.

2 1

Re: winhttp(1/12): Implement WinHttpGetDefaultProxyConfiguration
by Alexandre Julliard 14 Jul '09

14 Jul '09

Juan Lang <juan.lang(a)gmail.com> writes: > +static inline void copy_char_to_wchar_sz(const BYTE *src, DWORD len, WCHAR *dst) > +{ > + const BYTE *begin; > + > + for (begin = src; src - begin < len; src++, dst++) > + *dst = *src; > + *dst = 0; > +} That looks very wrong. Is there really evidence that Unicode chars are truncated? > + l = RegQueryValueExW( key, WinHttpSettings, NULL, &type, NULL, &size ); > + if (!l && type == REG_BINARY && size >= 5 * sizeof(DWORD)) > + { > + BYTE *buf = HeapAlloc( GetProcessHeap(), 0, size ); > + > + if (buf) > + { > + DWORD *magic = (DWORD *)buf; > + DWORD *unknown = magic + 1; > + DWORD *flags = unknown + 1; > + DWORD *len = flags + 1; Please define an appropriate structure. -- Alexandre Julliard julliard(a)winehq.org

2 2

transl question
by Aric Stewart 14 Jul '09

14 Jul '09

I am looking at the Japanese report from transl and i see something odd. looking at DIALOG MSGBOX for user32... http://source.winehq.org/transl/resource.php?lang=011%3A00&resfile=dlls%2Fu… the STYLE is reported as different, but when I look at the source they appear identical. Is it because the Japanese resource has FONT 9, "MS Shell Dlg" specified? Should that show up as an Error to be corrected? -aric

3 2

Re: 2/2 winex11: add XRender based GetSrcAreaStretch
by Aurimas Fišeras 14 Jul '09

14 Jul '09

On 07/11/2009 10:08 PM, Roderick Colenbrander wrote: > Hi, > > This patch adds a XRender based GetSrcAreaStretch. A lot of work is > offloaded to X (less round trips are needed) and it can take advantage > of hardware acceleration. On Nvidia and AMD drivers blt performance > has improved by 20% in CrystalMark2004 while more optimizations can be > added later on. I get a similar performance increase on intel driver too.

2 1

Transl: Getting rid of the conf directory (Part 1)
by Paul Vriens 14 Jul '09

14 Jul '09

Hi, In an effort to make conf more dynamic (and less depending on hardcoded configuration) I'd like to get rid of the conf directory. Let's make a first distinction here. We currently have a conf directory used by the scripts/* files and one by the php/* files. I'd like to discuss the scripts/conf directory first. Once that is done we can start discussing the php/conf directory The scripts conf directory ========================== The conf directory shows all the languages currently known by transl to be in use for translations. (We get a warning if a language is found in the source and we don't have a conf file for it.) The most prominent use of the conf directory is to create a list of languages that will show up on the index page. The conf file could hold a parameter "[ignore-sublang]". This parameter is used to change a LANG_XXX, SUBLANG_* into LANG_XXX, SUBLANG_NEUTRAL. So, if we want to get rid of the hardcoded conf directory we need some logic that replaces the above. The logic should hold the following rules: 1. LANG_XXX, SUBLANG_XXX_YYY is the highest level possible so we don't have to do anything here. 2. LANG_XXX, SUBLANG_DEFAULT (only 1 sublanguage in our code) should show LANG_XXX, SUBLANG LANG_XXX_YYY. 3. LANG_XXX, SUBLANG_DEFAULT (multiple sublanguages in our code) should show all possible LANG_XXX, SUBLANG_XXX_YYY. 4. LANG_XXX, SUBLANG_NEUTRAL (only 1 sublangugage in our code) should show LANG_XXX, SUBLANG_XXX_YYY. 5. LANG_XXX, SUBLANG_NEUTRAL (multiple sublanguages in our code) should mean show all possible LANG_XXX, SUBLANG_XXX_YYY. (This logic is already somehow in place when the Portuguese issue was solved.) I propose the following changes: 1. The first thing that should happen before any parsing is done is to get a list of all the different languages Wine is translated in. 2. Automatically create a scripts/conf directory that is based on the list found in step 1. This is temporary until the php part is converted as well. These conf files don't need the [hide] parameter or the [ignore-sublang] parameter anymore. 3. Change some of the php scripts to get rid of the two parameters mentioned in step 2. This basically means that we are not going to show pages anymore for the neutral languages (English is the exception). Note for step 2. The php scripts rely on the php/conf (copy of scripts/conf) directory for retrieving the name of a language. The kernel32 resources also have these names albeit sometimes a little different. I've noted the following differences: conf-dir kernel32 ======== ======== Chinese (Simplified) Chinese (PRC) Chinese (Traditional) Chinese (Taiwan) English (US) English (United States) English (Neutral) English Portugese (Brazilian) Portuguese (Brazil) Portugese (Portugal) Portuguese (Portugal) Do we want to go with the kernel32 names or should we have some kind of name override? To prove my point I just looked at the list of translations we have, created the necessary files in scripts/conf, got rid of the 2 parameters and ran the Master.sh script to regenerate everything. The results were as expected and looked basically the same as on our transl page. After changing the index page to not use the [hide] parameter anymore but some other logic it looked exactly the same. Thoughts, ideas, suggestions, questions on all of this? (As said he php/conf directory can/will be discussed in a second email once this is "solved"). -- Cheers, Paul.

2 8

Re: Add stub for IoOpenDeviceRegistryKey
by Paul Chitescu 14 Jul '09

14 Jul '09

+ FIXME( "stub:\n"); + return STATUS_SUCCESS; This is incorrect, since you are adding a stub you must not return success as it would imply that *DevInstRegKey is filled with a valid handle. You must either return an error or provide a full valid implementation (unlikely). Anything else is your private hack, unsuitable for including in the public wine repository since it could crash some drivers.

1 0

Re: [2/8] wbemprox: Add a stub implementation of IWbemLocator.
by Alexandre Julliard 14 Jul '09

14 Jul '09

Hans Leidekker <hans(a)codeweavers.com> writes: > diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c > index 18b4d55..785d690 100644 > --- a/dlls/uuid/uuid.c > +++ b/dlls/uuid/uuid.c > @@ -76,6 +76,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > #include "isguids.h" > #include "objsafe.h" > #include "perhist.h" > +#include "wbemcli.h" There doesn't seem to be any Wbem clsid in the Windows libuuid. -- Alexandre Julliard julliard(a)winehq.org

1 0

drive list is not refreshed in winecfg, no more disk label
by Joerg-Cyril.Hoehle＠t-systems.com 14 Jul '09

14 Jul '09

Hi, [resend, 1st message disappeared?] since somewhere between wine-1.1.6 and 1.1.21, going to winecfg's drives tab does not (re)scan all drives such as CD-ROMs anymore. So access to the tab is faster, but winecfg does not display the disk label (shown empty) and serial number (always 0) any more. wine cmd -> "dir D:" still lists a disk's label and serial number. Did I miss a voluntary change or shall I file a regression? I'm not aware that my compilation setup may have changed. hal+dbus-dev have been there for ages. Thanks, Jörg Höhle

14 27

re: Supported applications?
by Dan Kegel 13 Jul '09

13 Jul '09

Austin wrote: >Looking around the wiki/website, I can't find anywhere where the >'Supported applications' are listed (Powerpoint/Word/Excel viewer and >Adobe Photoshop CS 2, if I remember correctly). Maybe you're thinking of http://wiki.winehq.org/WineReleaseCriteria That's for 1.0 (I don't think we've decided what the criteria are for 1.2). > Are these the only applications that are being targeted for 1.2? > Should others be added? Mozilla Firefox would be a great > candidate to add... > I ask, so I know which applications to make more strenuous appinstall tests for. It's a big commitment to add an app to the "must work for 1.2 to be released" list. The criteria for that list were popular, useful, and freely downloadable applications which already run well To those criteria I would add testable using autohotkey Firefox does seem to qualify (people still use it under wine to get at particular plugins). If you're going to do that, please consider invoking the existing Firefox automated test suites; see https://developer.mozilla.org/en/Mozilla_automated_testing - Dan

2 2

Re: winequartz.drv Mac OS X UI discontinued?
by James McKenzie 13 Jul '09

13 Jul '09

Emmanuel Maillard wrote: > > Le 11 avr. 09 à 18:20, James McKenzie a écrit : > >> Emmanuel Maillard wrote: >>> >>> Le 3 janv. 09 à 04:14, James McKenzie a écrit : >>> >>>> Emmanuel Maillard wrote: >>>>> Hi, >>>>> >>>>> Le 4 juil. 08 à 12:37, Adam Strzelecki a écrit : >>>>> >>>>> >>>>>> Hi Emmanuel, hello Wine developers, >>>>>> >>>>>> Latest WineQuartz.drv patch is 0.9.58. Is there any change for >>>>>> more recent release? I tried this patch with 1.0-1 however it has >>>>>> too many conflicts. >>>>>> It would be most convenient if you had just update >>>>>> http://repo.or.cz/w/wine/winequartzdrv.git to match 1.1.0 somehow >>>>>> and include Quartz. >>>>>> >>>>> >>>>> I resolved conflicts for wine-1.0, but didn't take a look yet for >>>>> wine-1.1.0, i just know that's some changes in user32 and winex11.drv >>>>> have to be update in winequartz.drv too. >>>>> >>>>> I will see this week end if i can find free time to make a new >>>>> patch for winequartz.drv and send it to SourceForge. >>>>> (OpenGL is broken in winequartz.drv actually, because of a lack of >>>>> time to fix it) >>>>> >>>>> >>>>> >>>>>> Since Wine passed 1.0 (woohoo!) maybe someone from the direction >>>>>> can revise Mac support? Even there're numerous Emmanuel efforts >>>>>> to provide Mac UI driver instead of X11, it will be always pushed >>>>>> aside, and sentenced to death, because it is not in official >>>>>> sources. >>>>>> >>>>>> I know Alexandre Julliard's decision about NOT taking any >>>>>> Objective- C sources (.m) into the Wine, but maybe this can be >>>>>> revised, anyway all .m rules will be only present on Mac >>>>>> platforms. Using Objective- C is only way to make fair support for >>>>>> Mac OS GUI, as those whole GUI system is objective. >>>>>> Moreover then what's the point of keeping winex11.drv and all GUI >>>>>> driver infrastructure in Wine if nothing else but X11 is NOT >>>>>> accepted into official source? >>>>>> >>>>>> Forgive me what I say now, but I just it would be more fair if >>>>>> someone from Codeweavers just said that Wine's official support >>>>>> for Mac OS X is against their business with CrossOver and this is >>>>>> the real reason they reject winequartz.drv from Emmanuel Maillard. >>>>>> Frankly I'd really pay for CrossOver or Wine, if it was what 1.0-1 >>>>>> is but with native Mac UI, so each wine process has it's own dock >>>>>> icon, and no X11 is needed and native Mac font system. >>>>>> >>>>>> Regards, >>>>>> -- >>>>>> Adam Strzelecki |: nanoant.com :| >>>>>> >>>>>> >>>>> >>>>> >>>>> Cheers >>>>> Emmanuel >>>>> >>>>> >>>> Emmanuel: >>>> >>>> What is the status of winequartz.drv? It looks like your last patch >>>> was for 1.1.2. >>>> >>>> James McKenzie >>>> >>> >>> Hi, >>> >>> I didn't really work on winequartz.drv since this patch, start a new >>> version at the beginning of October, >>> but more or less waiting for DIB engine. >>> >>> Emmanuel >> >> Emmanuael: >> >> Are you still working on this or have you abandoned it? >> >> James McKenzie >> > > Hi, > > I stopped working on winequartz.drv for now ... > abandoned ? not totally, but i currently do not envisage to work again > on it. Emmanuel: At one time you stated that this work depends on a DIB engine. Have you looked at Max' work? Also, did work get finished on 1.1.2 or did that stop as well? James McKenzie

2 3

MaxVertexBlendMatrices issue
by Karl Vogel 13 Jul '09

13 Jul '09

(resend after subscribing to the ML - if the first post comes through, pls excuse the spam then :P ) Just tracked down a crash in the game Dark Age of Camelot (daoc) when pixelshaders are enabled. The game issues a GetDeviceCaps() and then checks if MaxVertexBlendMatrices >= 4, which on wine is set to zero on my videocard (Geforce 6800), whereas a windows box returns 4. I found this old post concerning MaxVertexBlendMatrices causing issues in another game (EQ): http://www.winehq.org/pipermail/wine-devel/2008-February/062432.html http://www.winehq.org/pipermail/wine-devel/2008-February/062437.html So I was wondering what the proper way to fix this would be? Should this be made overrideable by a registry setting for certain games? Or should the GL check be changed? Or is that software emulated vertex blending patch needed to correctly fix the issue? Bugzilla has 3 other games where the simple 'fix' of returning 4 makes the game work (Warhammer, EQ, Shin Megami Tensei Online): http://bugs.winehq.org/buglist.cgi?quicksearch=MaxVertexBlendMatrices -- For reference the daoc bug is http://bugs.winehq.org/show_bug.cgi?id=10832

2 3

Re: wined3d: fix empty driver description string
by Henri Verbeet 13 Jul '09

13 Jul '09

2009/7/13 <Joerg-Cyril.Hoehle(a)t-systems.com>: > Patch against wine-1.1.25 > You'll generally want to do development against git.

1 0

[Request for review] wrc: Add support for nameID with quotes
by Tijnema 13 Jul '09

13 Jul '09

Hello all, I was just checking around some old bugs and found 786 still opened. I've written a patch for it, but I want to know if I'm anywhere close to get it in. I'm sorry if I'm only wasting your time. Matijn

5 5

kernel32: Fix typos in English errors messages (updated)
by Frédéric Delanoy 13 Jul '09

13 Jul '09

After comment from Michael Stefaniuc

1 0

Supported applications?
by Austin English 13 Jul '09

13 Jul '09

Looking around the wiki/website, I can't find anywhere where the 'Supported applications' are listed (Powerpoint/Word/Excel viewer and Adobe Photoshop CS 2, if I remember correctly). Are these the only applications that are being targeted for 1.2? Should others be added? Mozilla Firefox would be a great candidate to add... I ask, so I know which applications to make more strenuous appinstall tests for. -- -Austin

1 0

Re: kernel32: Fix typos in English errors messages
by Michael Stefaniuc 13 Jul '09

13 Jul '09

Hello Frédéric, On 07/12/2009 01:16 PM, Frédéric Delanoy wrote: > @@ -3266,7 +3266,7 @@ Floating underflow > MessageId=1771 > SymbolicName=RPC_S_FP_OVERFLOW > Language=ENU > -Floating overlow > +Floating overflow That sounds strange. Shouldn't that better be "Floating point overflow"? bye michael

2 1

Re: 2/2 winex11: add XRender based GetSrcAreaStretch [with patch]
by Austin English 12 Jul '09

12 Jul '09

On Sat, Jul 11, 2009 at 2:33 PM, Roderick Colenbrander<thunderbird2k(a)gmail.com> wrote: > This time with patch. > > Roderick > > On Sat, Jul 11, 2009 at 9:08 PM, Roderick > Colenbrander<thunderbird2k(a)gmail.com> wrote: >> Hi, >> >> This patch adds a XRender based GetSrcAreaStretch. A lot of work is >> offloaded to X (less round trips are needed) and it can take advantage >> of hardware acceleration. On Nvidia and AMD drivers blt performance >> has improved by 20% in CrystalMark2004 while more optimizations can be >> added later on. >> >> Regards, >> Roderick Colenbrander Dan asked me to run appinstall with it, and when I did, found that a ton of stuff breaks. Easiest to see is 'wine control'. It runs, but takes up 100% of a cpu core, and the window never appears. Notepad++ (my dogfood text editor has the same problem). I'm working on adjusting the tests to handle this type of failure better, and will try to run the full test suite on it soon. -- -Austin

2 3

AcceptEx patchset comments
by Mike Kaplinskiy 12 Jul '09

12 Jul '09

I'm looking for comments/criticism for the above patch set. It is actually not complete yet (glaring FIXME on #6), but it is relatively close. Some notes: Patch 1: - needed to handle deferred sockets. We need to destroy the actual deferred socket without closing the handle. Patch 2: - ntdll seems to keep a cache of fd's and since the accept_socket change in patch 4 switches the underlying fd object for a socket handle, we need to flush the cache (is there a better approach?). Patch 3: - needed for patch 4 so accept() can create a socket. Patch 3+4+5: - is a tools/make_requests run required before submitting this? Patch 5: - I don't like it, but can't figure out a better way to do it. Anyone have better ideas? - just realized as I was sending this that there is a problem if acceptex is called twice on the same socket (the async from before is not released). Patch 6: - is pretty much the same as the patch by Scott Lindeneau. Just expanded it and added support for data_len. data_len won't work with completion ports yet. Sorry for the continuous spam regarding AcceptEx; I just want to make sure that this isn't going nowhere. Mike.

1 0

Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup [Resend 2]
by Nikolay Sivov 12 Jul '09

12 Jul '09

Vladimir Pankratov wrote: > Hello all. > > Fixed Lingvo 9.0 crashes on startup. > > Changed files: > > comctl32/toolbar.c > > Thanks. The very first one was better (when you fixed only division by zero). Now you're changing path earlier: --- + if(rows <= 0) rows = 1; --- There's no tests currently for that (<=0 isn't tested), could you add them (to test_setrows() I suppose)?

2 2

Re: comctl32/toolbar.c: Fix Lingvo 9.0 crashes on startup
by Nikolay Sivov 12 Jul '09

12 Jul '09

Vladimir Pankratov wrote: > Hello all. > > Fixed Lingvo 9.0 crashes on startup. > > Changed files: > > comctl32/toolbar.c > > Thanks. Maybe it's better to simplify: + idealWrap = (infoPtr->nNumButtons - hidden + (rows-1)) / ((rows == 0) ? (rows + 1) : rows); --- to something like that --- + idealWrap = (infoPtr->nNumButtons - hidden + (rows-1)) / (rows ? rows : 1);

2 1

FW: Re: winequartz.drv Mac OS X UI discontinued?
by Rolf Kalbermatter 12 Jul '09

12 Jul '09

On Thursday July 09, 2009 5:32 PM Chris Robinson wrote: >> With the same argument you could say that writing COM objects has to >> be done in C++. Yet Wine has lots and lots of COM code written all in >> standard C. > >It has to, because the class vtable layout and calling convention can >be different in Windows than how the host system's compiler will generate it. >COM objects have to interface with existing Windows code, and so need >to be setup in memory in a specific way. Not entirely sure where your "It has too" is pointed at. If it is about COM code being written in C then it is not entirly true. All the MS examples about COM nowadays are completely in C++ and some newer API headers seem to not even include the C part. But of course that code is meant to be compiled with Visual C++ and I could see trouble trying to get the exact binary layout with gcc. This is maybe not such a problem with newest gcc but was certainly a problem with older versions. >If OSX will always have Obj-C support, and the Obj-C code can be >restricted to OSX-only code, then the only sticking point, in my eyes, >would be how maintainable it is. After all, if only one or two people >can work with Obj-C code, it can bit-rot that much more quickly. I think this is in fact the major issue here. There is certainly interest in starting such a project but maintaining it is a completely different beast. Rolf Kalbermatter

3 2

winequartz.drv Mac OS X UI discontinued?
by Adam Strzelecki 11 Jul '09

11 Jul '09

Hi, I know that CodeWeavers supports quite nicely Mac builds of Wine, and CrossOver for Mac, yet all of them are X11. There was also once Darwine - an effort to provide Carbon Wine UI driver and Mac optimizations & L&F. Pretty many of those were merged back to Wine, but not winequartz.drv. Do you guys think about reviving winequartz.drv? This would greatly improve Wine on Mac as we could have native Mac fonts handling that's faster than FreeType, Dock icons for Wine applications, and few others. There's still old copy of the it hanging around, but it is abandoned, and no longer compiles with Wine. Or I think it would be cool to write new winecocoa.drv or sthing like that, as Apple officially states that Carbon is deprecated. While it is not well documented, it is pretty easy with Cocoa to make console non-bundled process to be UI foreground process and handle events and Dock: (This code is copyrighted by myself ;P) > int main(int argc, const char * argv[]) { > ProcessSerialNumber psn = {0, kCurrentProcess}; > OSStatus returnCode = TransformProcessType(&psn, > kProcessTransformToForegroundApplication); > SetFrontProcess(&psn); > > NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; > [NSApplication sharedApplication]; > > NSImage *icon = [NSImage imageNamed:@"NSApplicationIcon"]; > [NSApp setApplicationIconImage:icon]; > > [NSApp finishLaunching]; > > NSWindow *window = [[NSWindow alloc] > initWithContentRect:NSMakeRect(0, 0, 100, 100) > styleMask:NSTitledWindowMask| > NSClosableWindowMask|NSMiniaturizableWindowMask|NSResizableWindowMask > backing:NSBackingStoreBuffered defer:NO]; > [window center]; > [window setTitle:@"Test"]; > > NSButton *button = [[NSButton alloc] > initWithFrame:NSMakeRect(10, 10, 80, 80)]; > [button setTitle:@"What?"]; > [button setBezelStyle:1]; > [[window contentView] addSubview:button]; > [button release]; > > [window makeKeyAndOrderFront:NSApp]; > > while(1) { > NSEvent *event = [NSApp > nextEventMatchingMask:NSAnyEventMask > untilDate > :[NSDate distantFuture] > inMode:NSDefaultRunLoopMode > dequeue:YES > ]; > if(event) [NSApp sendEvent:event]; > } > [pool release]; > return 0; > } BTW. I heard that someone previously working for Wine project is now in Apple, it is true? Regards, -- Adam Strzelecki |: nanoant.com :|

20 55

Try #4: user32: Windows test request (cursors/icons)
by Daniel Santos 11 Jul '09

11 Jul '09

Thanks again for your feedback and assistance. This is my 4th revision. I've created a static inline is_win9x() as you suggested. I agree that this should be in include/wine/test.h. One minor complication is that some test files define a BOOL or int "is_win9x" local variable, but that is easy to overcome. A few months ago, I wrote an extensive windows version testing patch for wine/test.h, but I appear to have either mis-placed it or accidentally blown it away! =) I've added win_skip() messages where tests are skipped on win9x to avoid crashing the and I clarified the FIXME (I hope it makes more sense). I'm trying to say that we should add tests to make sure height & width are checked since CreateCursor currently doesn't validate the size of the cursor you want to create against the values returned by GetSystemMetrics(). Finally, by Griswold's suggestion, I renamed test_SetCursor and test_DestroyCursor, adding an underscore prefix and a macro that will fill in the __LINE__ to clean up the code slightly. If you can please run this again on a 9x platform and also an NT platform (XP or vista) I would greatly appreciate it! I just want to make sure everything is happy before submitting it and thanks again for all your help! Daniel

1 0

Re: 2/2 winex11: add XRender based GetSrcAreaStretch
by Austin English 11 Jul '09

11 Jul '09

On Sat, Jul 11, 2009 at 2:08 PM, Roderick Colenbrander<thunderbird2k(a)gmail.com> wrote: > Hi, > > This patch adds a XRender based GetSrcAreaStretch. A lot of work is > offloaded to X (less round trips are needed) and it can take advantage > of hardware acceleration. On Nvidia and AMD drivers blt performance > has improved by 20% in CrystalMark2004 while more optimizations can be > added later on. > > Regards, > Roderick Colenbrander > > > Forgot the patch. -- -Austin

1 0

Appinstall results down for a few days
by Austin English 11 Jul '09

11 Jul '09

My webhost had a security breach, so ssh/ftp is currently disabled. I've been monitoring the results locally, but in case anyone was curious why there haven't been new results in a couple days, now you know. -- -Austin

1 0

Need help testing (acceptex)
by Mike Kaplinskiy 11 Jul '09

11 Jul '09

Can someone try this test on win2000+? This tests the WSAAccept->Defer->AcceptEx scenario, and I've only verified the behavior on xp. Thanks, Mike

2 2

win users please test DirectX9_AutoGenFilterType patch
by Joerg-Cyril.Hoehle＠t-systems.com 11 Jul '09

11 Jul '09

Dear users of MS-Windows with access to a compiler, please compile the following addition to the Wine testsuite and report results of running on MS-Windows to me by e-mail (preferred) or to this list. The goal is to get rid of bug http://bugs.winehq.org/show_bug.cgi?id=11167 For that I need test data from MS-Windows systems. Maybe some more || broken(D3DTEXF_POINT == fltt) are needed for the tests to pass on some MS-Windows systems/gfx-drivers with limited filter types. Once proper MS-Windows behaviour is known, the patch to Wine will follow. Currently Wine fails the test below. http://msdn.microsoft.com/en-us/library/bb174327(VS.85).aspx diff --git a/dlls/d3d9/tests/texture.c b/dlls/d3d9/tests/texture.c index 4d433b1..29864a8 100644 --- a/dlls/d3d9/tests/texture.c +++ b/dlls/d3d9/tests/texture.c @@ -197,6 +197,21 @@ static void test_mipmap_gen(IDirect3DDevice9 *device) D3DFMT_X8R8G8B8, D3DPOOL_MANAGED, &texture, 0); ok(hr == D3D_OK, "IDirect3DDevice9_CreateTexture failed(%08x)\n", hr); + if (texture) { + D3DTEXTUREFILTERTYPE fltt; + fltt = IDirect3DTexture9_GetAutoGenFilterType(texture); + ok(D3DTEXF_LINEAR == fltt, "GetAutoGenFilterType returned default %d\n", fltt); + hr = IDirect3DTexture9_SetAutoGenFilterType(texture, D3DTEXF_NONE); + ok(hr == D3DERR_INVALIDCALL, "SetAutoGenFilterType D3DTEXF_NONE returned %08x\n", hr); + hr = IDirect3DTexture9_SetAutoGenFilterType(texture, D3DTEXF_ANISOTROPIC); + ok(hr == D3D_OK, "SetAutoGenFilterType D3DTEXF_ANISOTROPIC returned %08x\n", hr); + fltt = IDirect3DTexture9_GetAutoGenFilterType(texture); + ok(D3DTEXF_ANISOTROPIC == fltt /*|| broken(D3DTEXF_POINT == fltt)*/, + "GetAutoGenFilterType returned %d\n", fltt); + hr = IDirect3DTexture9_SetAutoGenFilterType(texture, D3DTEXF_LINEAR); + ok(hr == D3D_OK, "SetAutoGenFilterType D3DTEXF_LINEAR returned %08x\n", hr); + /* IDirect3DTexture9_GenerateMipSubLevels ? */ + } levels = IDirect3DTexture9_GetLevelCount(texture); ok(levels == 1, "Got %d levels, expected 1\n", levels); Thanks for your help, Jörg Höhle

3 2

MaxVertexBlendMatrices issue
by Karl Vogel 11 Jul '09

11 Jul '09

Just tracked down a crash in the game Dark Age of Camelot (daoc) when pixelshaders are enabled. The game issues a GetDeviceCaps() and then checks if MaxVertexBlendMatrices >= 4, which on wine is set to zero on my videocard (Geforce 6800), whereas a windows box returns 4. I found this old post concerning MaxVertexBlendMatrices causing issues in another game (EQ): http://www.winehq.org/pipermail/wine-devel/2008-February/062432.html http://www.winehq.org/pipermail/wine-devel/2008-February/062437.html So I was wondering what the proper way to fix this would be? Should this be made overrideable by a registry setting for certain games? Or should the GL check be changed? Or is that software emulated vertex blending patch needed to correctly fix the issue? Bugzilla has 3 other games where the simple 'fix' of returning 4 makes the game work (Warhammer, EQ, Shin Megami Tensei Online): http://bugs.winehq.org/buglist.cgi?quicksearch=MaxVertexBlendMatrices -- For reference the daoc bug is http://bugs.winehq.org/show_bug.cgi?id=10832

1 0

GSoC mid-term evaluations due
by Kai Blin 11 Jul '09

11 Jul '09

Hi GSoC students and mentors, Just a little reminder that you need to fill out your GSoC surveys by monday. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

[2/2] msxml3: Register Missing Components
by Lady Bug 11 Jul '09

11 Jul '09

2 1

Re: [1/2](resend)advapi: break the core of LookupAccountNameW out into helper functions.
by Juan Lang 10 Jul '09

10 Jul '09

Hi Aric, it strikes me that this could be broken up a bit further. This'd make it rather easier to review. For example, --- a/dlls/advapi32/advapi32_misc.h +++ b/dlls/advapi32/advapi32_misc.h @@ -24,4 +24,15 @@ const char * debugstr_sid(PSID sid); BOOL ADVAPI_IsLocalComputer(LPCWSTR ServerName); BOOL ADVAPI_GetComputerSid(PSID sid); +BOOL lookup_local_wellknown_name(LPCWSTR lpAccountName, DWORD ccAccountName, + PSID Sid, LPDWORD cbSid, + LPWSTR ReferencedDomainName, + LPDWORD cchReferencedDomainName, + PSID_NAME_USE peUse, BOOL *ret); +BOOL lookup_local_user_name(LPCWSTR lpAccountName, DWORD ccAccountName, + PSID Sid, LPDWORD cbSid, + LPWSTR ReferencedDomainName, + LPDWORD cchReferencedDomainName, + PSID_NAME_USE peUse, BOOL *ret); In the initial patch, these aren't referenced outside of security.c, so leaving them static there would make the changes smaller. A subsequent patch that does reference them from lsa.c could make them non-static. +static inline WCHAR *strnrchrW(const WCHAR *str, WCHAR ch, DWORD *len) It's not clear to me what this function does from its name, and you didn't document it. There's no corresponding strnrchr libc function, so that doesn't help either. It appears from reading it that you made a function like strrchrW that returns the location of the found ch in str, like strrchrW does, but also sets *len to the position at which it's found? If that's correct, you could accomplish the same thing by calling strrchrW and doing pointer arithmetic with its return value. These suggestions notwithstanding, it seems like introducing this helper function is one change, and deserving of its own patch. + +/* + * Helper function for LookupAccountNameW and LookupNames2 in lsa.c The second part of that comment, that it's a helper for LookupNames2, isn't correct in this first patch. It becomes true later, but the comment should be changed then, not in the first patch. (Minor nit: mentioning the file LookupNames2 is in seems superfluous.) + * returns TRUE if the AccountName is handled (even if with an error). + * returns FALSE if not. + */ + +BOOL lookup_local_wellknown_name(LPCWSTR lpAccountName, DWORD ccAccountName, + PSID Sid, LPDWORD cbSid, + LPWSTR ReferencedDomainName, + LPDWORD cchReferencedDomainName, + PSID_NAME_USE peUse, BOOL *ret) The use of two BOOLs is confusing to me. For one thing, it makes the patch larger: - ret = CreateWellKnownSid(ACCOUNT_SIDS[i].type, NULL, pSid, &sidLen); + *ret = CreateWellKnownSid(ACCOUNT_SIDS[i].type, NULL, pSid, &sidLen); This change could be avoided if you returned the old meaning of ret, and used the BOOL * parameter to indicate whether the AccountName is handled. Finally, I'd suggest that breaking out looking up well known names could be separate from breaking out looking up local names. Hope that helps, --Juan

1 0

Re: winemine: Add ellipses for menu entries that open new dialog windows (DE)
by Paul Vriens 10 Jul '09

10 Jul '09

Detlef Riekenberg wrote: > There are more winemine translations without the ellipses. > Can the changes all in one Patch? > > There are non UTF8 - resources with special characters. > Should they change to UTF8 first? > > > > > ------------------------------------------------------------------------ > > Hi Detlef, There is patch in the queue that actually gets rid of some ellipses as there was a discussion about this on wine-devel. -- Cheers, Paul.

1 0

Warnings on the translation page
by Paul Vriens 10 Jul '09

10 Jul '09

Hi, I found an anomaly on the translations page. Whenever the Makefile shows a generic rc file (last one added for RC_SRCS) the language before that shows warnings on the page. Example: http://source.winehq.org/transl/lang.php?lang=004%3A01 zh (Chinese (Traditional)) shows up most of the warning as the entries in the Makefile are sorted. Not sure yet, if this is an issue with wrc or transl. -- Cheers, Paul.

2 4

Wine very very slow in Chinese language of Linux
by axel_xia＠sohu.com 10 Jul '09

10 Jul '09

Dear Madam / Sir, How are you? I am writing email to you for the issue probably caused by Chinese fonts. When using WINE in Chinese environment Linux, the WINE works very very slow even opening windows / clicking buttons.... I search the problem in google, found lots of users have same issue regardless Fedora or Ubuntu or other distributed Linux OS. Someone presented the resolution by changing Chinese fonts configuration because they think WINE is always searching suitable GKB font sets (which sometimes are not exisiting in Linux OS), someone said it was related to X11 (not compatiable or some linux OS not using X11)..., and others guess the issue related to other reason..... So, dear Madam / Sir, could you please help the WINE fans who are using Linux in Chinese environment to figure out this kind of issue? Or is that possible to put the fixed WINE into Yum or someother software database? Hopefully, the user of different distributed Linux can be of no issue when WINE M$ software in Chinese? Thanks and best regards! Yours sincerely, Axel

1 0

Re: wined3d: Fix some checkGLcalls.
by Henri Verbeet 10 Jul '09

10 Jul '09

Most of those looked good enough to me to begin with, but I guess it doesn't hurt.

1 0

Re: Check if WINED3DRS_VERTEXBLEND is dirty in transform_world
by Henri Verbeet 09 Jul '09

09 Jul '09

2009/7/5 Lisa Denia <eiffel56(a)gmail.com>: > This fixes the flickering cursor mentioned in Bug > #14375(http://bugs.winehq.org/show_bug.cgi?id=14375). > The cursor flickers because the scene gets rendered twice a draw, which is > known and expected. The cursor is not one of that usual animated 2d things, > but a 3d object. So, in every draw, the scene gets rendered, the cursor gets > rendered, and the scene gets rendered again. The attached patch checks for > that special case. > It's not entirely clear to me why this should work.

2 1

Re: kernel32/nls: Add Lithuanian winerr translation
by Paul Vriens 09 Jul '09

09 Jul '09

Hi Aurimas, Congratulations !! -- Cheers, Paul.

2 1

image loading with windowscodecs
by Vincent Povirk 09 Jul '09

09 Jul '09

So I've been working on an implementation of windowscodecs.dll (Windows Imaging Component). This is a Vista/.NET 3.x API for manipulating image data. To the best of my knowledge, only 2 programs currently use it, and I'm not running either one. We're not likely to see it used by real programs in Wine much, since there's no redistributable. A program using it would have to require Vista or .NET 3.0, or require users to download it manually. It's documented here: http://msdn.microsoft.com/en-us/library/ms735422(VS.85).aspx Adding this dll will not increase compatibility, at least not directly. It will, however, provide Wine with a single component that can be used by any dll or program that needs to load or save a raster image. All of the code for png, gif, jpeg, etc should be migrated into this dll. If we need any image formats not supported by native, we can implement them as Wine-specific extensions. We need to do this because oleaut32 (the current home of image-loading code) sucks. I have been told that the libpng code should not be duplicated throughout the codebase. I need features in gdiplus that oleaut32 does not provide, such as access to the image dpi and metadata, and the ability to save images. In fact, much of the gdiplus image/bitmap api matches WIC 1:1. On Windows, gdiplus is known to be able to use WIC extensions to support new image types, so in theory it should use WIC (though this probably won't matter any time soon). I'm told that image loading is also useful for d3dx9 dll's. The WIC api is well-designed in my opinion and should be able to provide any operations needed by other components to load/save images. The next step is to implement the image types needed by oleaut32 and start using WIC to load them in olepicture, starting with BMP. To that end, I need a good test program. I need to see what kind of BMP files currently work (I suspect that many are broken) and what kinds will work if I replace the BMP-loading code. This will tell me at what point I can make the change without introducing a regression. After that, I'll need to do the same thing with the other file types. So I need a general-purpose image viewer that uses either gdiplus or oleaut32 to do its image loading. Does anyone know any? -- Vincent Povirk

1 0

Re: [1/2] winemine: Add ellipses for menu entries that open new dialog windows
by Yuri Khan 09 Jul '09

09 Jul '09

On Thu, Jul 9, 2009 at 15:53, Anders Jonsson<anders.jonsson(a)norsjonet.se> wrote: > POPUP "&Info" { > - MENUITEM "&Fastest Times", IDM_TIMES > + MENUITEM "&Fastest Times...", IDM_TIMES > MENUITEM "&About", IDM_ABOUT > } According to Microsoft's guidelines, an ellipsis is only necessary when the command asks for confirmation or additional parameters. "If simply viewing the window is a common action, don't use an ellipsis." http://msdn.microsoft.com/en-us/library/aa511502.aspx#ellipses

2 1

Re: transl and sublangs are not showing neutral
by Ricardo Filipe 09 Jul '09

09 Jul '09

2009/7/8 Paul Vriens <paul.vriens.wine(a)gmail.com> > Paul Vriens wrote: > >> Ricardo Filipe wrote: >> >>> hi mikolaj, >>> >>> in transl the Portuguese language (not Portugese :( ) is not showing most >>> of the neutral strings for it's sublangs (portugal and brazil). >>> i think this is not how it should be... in each sublang it should show >>> the Neutral derived strings and the warning that neutral is being used and >>> should not be used aside the language name in the main list, not put neutral >>> separate in another hidden page. >>> >>> as it is now it's hard for me to know what is translated and what's not. >>> what do you (and wine devel) think? could you please change this? >>> >>> regards, >>> Ricardo >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> Hi Ricardo, >> >> So you would be happy/happier if we show "Portuguese (Neutral)" (with the >> warning) on the main page next to the "Portuguese (Portugal)" and >> "Portuguese (Brazilian)"? >> >> Just re-read your email. What you like is to have "Portuguese (Portugal)" > show the combination of "Portuguese (Portugal)" and "Portuguese (Neutral)", > correct? With a warning for the neutral resources. > > What does this mean for "English (Neutral)" should that be treated the same > or is Portuguese an exception? > > -- > Cheers, > > Paul. > yes that is what i would like and think is correct showing. portuguese strings should defer to neutral if none is found in the sublang, with a warning that they may be incorrect. i would say english is the exception by having all translated in SUBLANG_DEFAULT and not separating sublangs as is done with portuguese resources and others. as i stated in irc one of these days, i think the solution to english is to have a SUBLANG_BRITISH or whatever and not assume neutral is for british english, how it is right now contradicts the use of wrc which is sublang -> neutral -> default (english). i'd say english should have all resources in neutral and then the different ones in sublang_british or sublang_australian or other. at least that is what makes sense to me for the process to be consistent.

2 6

Re: [PATCH 1/7] jscript: Inherit Function_valueOf from Object
by Piotr Caban 09 Jul '09

09 Jul '09

Hi, Please drop this bunch of patches (it will not apply to newest git). Piotr

1 0

Re: WineD3D: Check if GL accepts 4 component specular colors
by Henri Verbeet 09 Jul '09

09 Jul '09

Actually, while I'm at it, you're also missing ENTER_GL()/LEAVE_GL() calls in match_allows_spec_alpha(), and you should document that it depends on the caller to do context activation.

1 0

Re: comctl32: Fix dialog ('Next' button was hidden)
by Aurimas Fišeras 09 Jul '09

09 Jul '09

On 07/08/2009 10:31 PM, Frédéric Delanoy wrote: > I think it should be under the button "Finish", so that the "Finish" button can be shown in the same place instead of "Next >" on the last wizard page.

3 3

Re: WineD3D: Check if GL accepts 4 component specular colors
by Henri Verbeet 09 Jul '09

09 Jul '09

2009/7/9 Stefan Dösinger <stefan(a)codeweavers.com>: > - GL_EXTCALL(glSecondaryColorPointerEXT)(e->format_desc->gl_vtx_format, e->format_desc->gl_vtx_type, > - e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + > + if(GLINFO_LOCATION.quirks & WINED3D_QUIRK_ALLOWS_SPECULAR_ALPHA) > + { > + /* The spec disallows 4 component specular colors, but most GL drivers accept it. Try to use it, > + * since the 4th value can be passed through to pixel shaders > + */ > + GL_EXTCALL(glSecondaryColorPointerEXT)(e->format_desc->gl_vtx_format, e->format_desc->gl_vtx_type, > + e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + } > + else > + { > + GLenum type = e->format_desc->gl_vtx_type; > + GLint format = e->format_desc->gl_vtx_format; > + if(format == 4 && type == GL_UNSIGNED_BYTE) > + { > + GL_EXTCALL(glSecondaryColorPointerEXT)(3, GL_UNSIGNED_BYTE, > + e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + } > + else > + { > + FIXME("Add specular color code for type %x, fmt %u\n", type, format); > + GL_EXTCALL(glSecondaryColorPointerEXT)(format, type, > + e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + } > + } I think you should test for the specific case the quirk addresses. For example, 3 component specular color will trigger the FIXME with this code. Also, EXT_vertex_array_bgra adds GL_BGRA as a valid type/size parameter for glSecondaryColorPointer(). Just test for "type == 4" and handle it according to the quirk being present or not. Combinations that are always invalid, like e.g. 1 or 2 component data should already have been filtered by declaration_element_valid_ffp().

1 0

Re: comctl32: Fix dialog ('Next' button was hidden) [ invalid patch ]
by Frédéric Delanoy 09 Jul '09

09 Jul '09

Please discard this patch Frédéric

1 0

Translations/locale
by Ken Sharp 09 Jul '09

09 Jul '09

Can someone tell me what's going on on this page http://source.winehq.org/transl/lang.php?lang=009%3A00 ? If you click on the bottom links (locales) I see a message "Invalid resource file". Does this mean the resource file doesn't exist, or is there a little oops in the links? Thanks, Ken.

2 2

Re: winex11.drv: Handle clipboard on an auxiliary thread for windowless apps (try 3)
by Dmitry Timoshkov 09 Jul '09

09 Jul '09

"Yuri Khan" <yurivkhan(a)gmail.com> wrote: > +void selection_acquire(void) Should be 'static'. > +DWORD WINAPI selection_thread_proc(LPVOID lphwnd) Should be 'static'. What's the purpose of such a parameter name? 'dummy', 'unused' or just 'param' would be better IMO. > +{ > + HANDLE handles[1]; > + > + selection_acquire(); > + > + while (selectionAcquired) > + { > + MsgWaitForMultipleObjectsEx(0, handles, INFINITE, QS_SENDMESSAGE, 0); > + } What's the purpose of 'handles'? 'handles' is not initialized, moreover the number of passed handles is 0. MsgWaitForMultipleObjectsEx() works just fine with '0, NULL' combination. -- Dmitry.

1 0

Fwd: [Wine] Tmax Window(a propietary OS) using Wine?
by Austin English 08 Jul '09

08 Jul '09

---------- Forwarded message ---------- From: nengad24 <wineforum-user(a)winehq.org> Date: Tue, Jul 7, 2009 at 5:54 AM Subject: [Wine] Tmax Window(a propietary OS) using Wine? To: wine-users(a)winehq.org Hi, Im posting here the next doubt: Yesterday a korean company has released a new OS which is compatible with MS Windows Apps. As they state, they are a propietary OS, and i cant see any GPL code or SVN repository.Of course my lack of Korean can help to not find the open source code,but the little im able to read seems they arent going to release any source code. I know that is quite difficult to replicate Windows APIs, so i´m asking myself if this OS is using Wine code to replicate the APIs. If they are using, they could be violating GPL rules. http://www.tmaxwindow.co.kr/ If you want to have more Info, i point you to the ReactOS Forum,where a thread about this Company can be found. http://www.reactos.org/forum/viewtopic.php?f=2&t=7134&st=0&sk=t&sd=a TMax wanted to support MS Windows drivers "using ReactOS as reference(sic)" thanks to "ReactOS is GPL code" but seems they werent able to "replicate" and that they just use a Kernel(i didnt find which one)and "their Code" to support Windows Apps. I know there is somekind of not good relation between Wine and ReactOS, but it´s my obligation to aware you about this issue since we (ReactOS+Wine) are members of the Open Source Community. Wishing that my feels are wrong,and that any GPL has been violated, One Open Source Community Guy. -- -Austin

5 6

Font problem in Notepad -- regression today
by Susan Cragin 08 Jul '09

08 Jul '09

Notepad is behaving very strangely today. It crashes every time I try to change the font. However, when I tried to trace the problem using winedbg, the font changed fine, after the following fixme showed up. Then when I closed the winedbg terminal window, notepad closed too. susan@ubuntu:~$ winedbg Wine-dbg>info process pid threads parent executable (all id:s are in hex) 00000008 1 00000000 'notepad.exe' 0000000e 3 0000000a 'services.exe' 00000011 4 0000000e 'winedevice.exe' 00000018 1 00000008 'explorer.exe' Wine-dbg>attach 0x8 0x680007f0 GLIBC_2+0x7f0 in ld-linux.so.2: int $0x80 Wine-dbg>set $BreakOnFirstChance=0 Wine-dbg>cont fixme:winedbg:be_i386_is_func_call Unsupported yet call insn (0xcd) at 0x680007f0

1 0

Obsolete print dialogs in comdlg32?
by Frédéric Delanoy 08 Jul '09

08 Jul '09

Hi, During update of translation of comdlg32 dialogs, I saw that some printing dialogs seem broken, namely PRINT and PRINT_SETUP, while PRINT32 and PRINT32_SETUP look OK. I checked some programs and the PRINT[_SETUP] dialogs don't seem to be used (a casual check in the code didn't find usages). Are they still needed? Or can they simply be deleted? Frédéric

2 1

Re: winhttp(2/5): Simplify netconn_resolve when using getaddrinfo
by Hans Leidekker 08 Jul '09

08 Jul '09

Hi Juan, - *sa_len = sizeof(struct sockaddr_in); - memset( sa, 0, sizeof(struct sockaddr_in) ); - memcpy( &((struct sockaddr_in *)sa)->sin_addr, &((struct sockaddr_in *)res->ai_addr)->sin_addr, sizeof(struct in_addr) ); - ((struct sockaddr_in *)sa)->sin_family = res->ai_family; - ((struct sockaddr_in *)sa)->sin_port = htons( port ); + *sa_len = res->ai_addrlen; + memcpy( sa, res->ai_addr, res->ai_addrlen ); This causes test failures, you can't ignore the port. -Hans

2 1

Re: [comctl32/tests] Fix test failures with comctl32 <= 5.80
by Nikolay Sivov 08 Jul '09

08 Jul '09

Paul Vriens wrote: > Hi, > > Most of them are with comctl32 <= 5.80 but there seem to be some > different failures for 4.70. And not all failures for <= 5.80 are on > 4.70. I didn't think changing the comment for that is a big deal. > > I don't have 4.70 on any of my boxes but I've tested with 4.72. > > Changelog > Fix test failures with comctl32 <= 5.80 > You forgot a patch.

1 0

Re: [1/3] WineD3D: An indirect address op can adjust min and max at the same time
by Henri Verbeet 08 Jul '09

08 Jul '09

2009/7/7 Stefan Dösinger <stefan(a)codeweavers.com>: > if (reg->idx <= ((IWineD3DVertexShaderImpl *)This)->min_rel_offset) > + { > ((IWineD3DVertexShaderImpl *)This)->min_rel_offset = reg->idx; > - else if (reg->idx >= ((IWineD3DVertexShaderImpl *)This)->max_rel_offset) > + } > + if (reg->idx >= ((IWineD3DVertexShaderImpl *)This)->max_rel_offset) > + { > ((IWineD3DVertexShaderImpl *)This)->max_rel_offset = reg->idx; > + } If you're going to fix it, you might as well fix it properly. There's no point in assigning min_rel_offset or max_rel_offset if they're already the same as reg->idx.

2 1

AcceptEx Patch Comments
by Mike Kaplinskiy 08 Jul '09

08 Jul '09

I'm looking for some comments regarding my (winsock part by Scott) acceptex patch: http://bugs2.winehq.org/attachment.cgi?id=22193 . This is just preliminary and doesn't support receive (yet). The approach was done to fix the server-side issues AJ had with Scott's original patch, so server side code would be my main concern right now. Thanks, Mike.

1 0

Re: [PATCH 2/3] jscript: Changed to_primitive implementation
by Jacek Caban 08 Jul '09

08 Jul '09

Hi Piotr, Piotr Caban wrote: > --- > dlls/jscript/date.c | 2 +- > dlls/jscript/dispex.c | 2 +- > dlls/jscript/engine.c | 12 ++++---- > dlls/jscript/jscript.h | 9 ++++++- > dlls/jscript/jsutils.c | 57 > ++++++++++++++++++++++++++++++++++++++++---- > dlls/jscript/tests/api.js | 2 + > dlls/jscript/tests/lang.js | 7 +++++ > 7 files changed, 77 insertions(+), 14 deletions(-) > > + hres = jsdisp_get_id(jsdisp, hint == HINT_STRING ? toStringW : valueOfW, 0, &id); + if(SUCCEEDED(hres)) { + hres = jsdisp_call(jsdisp, id, ctx->lcid, DISPATCH_METHOD, &dp, ret, ei, NULL /*FIXME*/); + if(FAILED(hres)) { + FIXME("throw TypeError\n"); + return hres; You leak jsdisp here. + } + else if(V_VT(ret) != VT_DISPATCH) { + jsdisp_release(jsdisp); + return S_OK; + } + } You leak V_DISPATCH(ret) here. + hres = jsdisp_get_id(jsdisp, hint == HINT_STRING ? valueOfW : toStringW, 0, &id); + if(SUCCEEDED(hres)) { + hres = jsdisp_call(jsdisp, id, ctx->lcid, DISPATCH_METHOD, &dp, ret, ei, NULL /*FIXME*/); + if(FAILED(hres)) { + FIXME("throw TypeError\n"); + return hres; + } You leak jsdisp here. + else if(V_VT(ret) != VT_DISPATCH) { + jsdisp_release(jsdisp); + return S_OK; + } + } +date = new Date(); +function toString() { + return "toString"; +} +date.toString = toString; +ok(""+date === "toString", "\"\"+date = " + date); It would be nice to add a few more tests for different cases like returning objects from toString implementation. Also adding toString function to global scope is asking for a trouble in future tests, so I'd suggest construct like date.toString = function() {...} Thanks, Jacek

1 0

Re: user32/tests: Added test for infinite WM_PAINT loop (resend)
by Austin Lund 07 Jul '09

07 Jul '09

2009/7/5 Austin Lund <austin.lund(a)gmail.com>: > The last time I sent this, the patch was broken. I've tested it on > WinXPsp2 and wine-1.1.25. This patch relates to bug 10522. > Can I please have some feedback on this patch? The test is for what I found as the source of the problem, not for the loop itself. Should I be testing for the loop instead? Is there an easy way of doing this? For further rambling on the topic see the bug report (http://bugs.winehq.org/show_bug.cgi?id=10522).

1 0

Re: winhttp(0/5): add preliminary IPv6 support
by Austin English 07 Jul '09

07 Jul '09

On Tue, Jul 7, 2009 at 4:06 PM, Juan Lang<juan.lang(a)gmail.com> wrote: > Hi, this small patch series adds preliminary IPv6 support to winhttp. > I say it's preliminary because 1) it's not well tested, and 2) it > doesn't attempt to parse IPv6-specific address components such as the > scope ID. Mainly I wanted to get rid of the assumption that every > host address is represented by a struct sockaddr_in, because the > underlying library functions are more general than that. > > I'd appreciate feedback. For instance, it may well be that this > doesn't build on all systems, and that more configure magic will be > necessary. Builds fine for me on Ubuntu Jaunty and PC-BSD 7.1. OpenSolaris builds fine, but adds some warnings about visibility attribute (these are all over the tree though). I don't currently have Net/OpenBSD installed to test on, so if they're broken, I'll bug you when I test next ;-). -- -Austin

1 0

transl and sublangs are not showing neutral
by Ricardo Filipe 07 Jul '09

07 Jul '09

hi mikolaj, in transl the Portuguese language (not Portugese :( ) is not showing most of the neutral strings for it's sublangs (portugal and brazil). i think this is not how it should be... in each sublang it should show the Neutral derived strings and the warning that neutral is being used and should not be used aside the language name in the main list, not put neutral separate in another hidden page. as it is now it's hard for me to know what is translated and what's not. what do you (and wine devel) think? could you please change this? regards, Ricardo

1 0

Re: gdi32: Use a modified version of MulDiv to match native behaviour.
by Paul Vriens 07 Jul '09

07 Jul '09

Huw Davies wrote: > --- > dlls/gdi32/metafile.c | 46 ++++++++++++++++++------- > dlls/gdi32/tests/metafile.c | 79 ++++++++++++++++++++++++++++++++----------- > 2 files changed, 92 insertions(+), 33 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, You may have already seen this. The changed tests introduce a great number of test failures on Win9x/WinME. I also see 2 test failures on my NT4+ boxes (except Vista) but not for others on test.winehq.org. I had a quick look and this is again the result of my display size being 997/568 (Vmware). As soon as I go full screen these 2 tests succeed. Could you have a look? If you want me to test something just shout. -- Cheers, Paul.

1 0

Fwd: Windows 2D GDI benchmark tools?
by Luke Benstead 07 Jul '09

07 Jul '09

---------- Forwarded message ---------- From: Luke Benstead <kazade(a)gmail.com> Date: 2009/7/7 Subject: Re: Windows 2D GDI benchmark tools? To: Roderick Colenbrander <thunderbird2k(a)gmail.com> 2009/7/7 Roderick Colenbrander <thunderbird2k(a)gmail.com>: > Hi, > > I'm working on rewriting Wine its blitting code using XRender. This > has several advantages e.g. no need for depth conversion, no need for > manual stretching/mirroring, it saves a lot of back-and-forth copying > between X and further various operations will be accelerated by the > GPU using XRender. (For a big part it might eliminate the need for a > DIB engine!) > > Right now I'm looking for some 2D GDI benchmark tools which test > blitting performance and other 2D operations and which work on Wine. I > have tried Sisoft Sandra and PassMark but those don't work on Wine. > Does anyone know any other 2D benchmark tools? It would help me a lot > to isolate slow parts and optimize my code even further. > > Thanks, > Roderick > > > (To everyone this time - why am I incapable of hitting "Reply to all" ? ) Maybe this? http://crystalmark.info/software/CrystalMark/index-e.html ( I haven't tried it, just Googled for benchmarking tools - particularly see this screenshot: http://crystalmark.info/software/CrystalMark/images/CrystalMark2004R2_Resul… there is a GDI mark) Luke.

1 1

Try #3: user32: Windows test request (cursors/icons)
by Daniel Santos 07 Jul '09

07 Jul '09

Ok, I hope this one is stable on win9x. Please give it a try and let me know. Thanks Daniel

2 1

Re: winex11.drv: Handle clipboard on an auxiliary thread for windowless apps
by Alexandre Julliard 07 Jul '09

07 Jul '09

Yuri Khan <yurivkhan(a)gmail.com> writes: > @@ -239,6 +239,9 @@ static Bool filter_event( Display *display, XEvent *event, char *arg ) > case PropertyNotify: > case ClientMessage: > return (mask & QS_POSTMESSAGE) != 0; > + case SelectionClear: > + case SelectionRequest: > + return 1; > default: > return (mask & QS_SENDMESSAGE) != 0; There's no reason to change this, QS_SENDMESSAGE is perfectly appropriate for selection events. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: Start a dummy thread to initialize an MTA.
by Alexandre Julliard 07 Jul '09

07 Jul '09

Hans Leidekker <hans(a)codeweavers.com> writes: > Based on a patch by Dan Kegel. Fixes Adobe CS3/CS4 installers. > See http://bugs.winehq.org/show_bug.cgi?id=18070 That's ugly, please let's fix this the right way, we have all the necessary infrastructure now. -- Alexandre Julliard julliard(a)winehq.org

1 0

What's with winetest-latest?
by Aurimas Fišeras 07 Jul '09

07 Jul '09

I get this Error: "Can't enumerate test files: 1813". And from test.winehq.org looks like everyone is getting an error.

3 3

Can resources and translations match Windows?
by Paul Vriens 07 Jul '09

07 Jul '09

Hi, This question came to me when I saw Austin's patch about adjusting notepad resources to more closely match XP. Is there some kind of copyright on the resources? Are we allowed to use the same strings or should it always be our own words (like with comments in the source)? -- Cheers, Paul.

3 3

Windows 2D GDI benchmark tools?
by Roderick Colenbrander 07 Jul '09

07 Jul '09

Hi, I'm working on rewriting Wine its blitting code using XRender. This has several advantages e.g. no need for depth conversion, no need for manual stretching/mirroring, it saves a lot of back-and-forth copying between X and further various operations will be accelerated by the GPU using XRender. (For a big part it might eliminate the need for a DIB engine!) Right now I'm looking for some 2D GDI benchmark tools which test blitting performance and other 2D operations and which work on Wine. I have tried Sisoft Sandra and PassMark but those don't work on Wine. Does anyone know any other 2D benchmark tools? It would help me a lot to isolate slow parts and optimize my code even further. Thanks, Roderick

1 0

Build a6beb5066884 w2k-sp4-fr-netwrkdrv test results
by Nicolas Le Cam 07 Jul '09

07 Jul '09

Hello, Strangely the network drive has been disconnected during the test. Could you remove it ? I will rerun and resubmit it after checking that results are correct. -- Nicolas Le Cam

1 0

Re: [2/3] WineD3D: Make context_attach_surface_fbo fbo aware
by Henri Verbeet 06 Jul '09

06 Jul '09

2009/7/6 Stefan Dösinger <stefan(a)codeweavers.com>: > Subject: [PATCH] WineD3D: Make context_attach_surface_fbo fbo aware I hope you meant "sRGB" there. > context_apply_attachment_filter_states((IWineD3DDevice *)This, surface, TRUE); > > - GL_EXTCALL(glFramebufferTexture2DEXT(fbo_target, GL_COLOR_ATTACHMENT0_EXT + idx, surface_impl->glDescription.target, > - surface_impl->glDescription.textureName, surface_impl->glDescription.level)); > + switch(srgb) > + { > + case SRGB_BOTH: > + ERR("SRGB_BOTH fbo attachment requested\n"); > + /* drop through */ > + case SRGB_SRGB: > + GL_EXTCALL(glFramebufferTexture2DEXT(fbo_target, GL_COLOR_ATTACHMENT0_EXT > + idx, surface_impl->glDescription.target, > + surface_impl->glDescription.srgbTextureName, surface_impl->glDescription.level)); > + break; > + > + case SRGB_ANY: /* TODO: Keep track of the last use */ > + case SRGB_RGB: > + GL_EXTCALL(glFramebufferTexture2DEXT(fbo_target, GL_COLOR_ATTACHMENT0_EXT > + idx, surface_impl->glDescription.target, > + surface_impl->glDescription.textureName, surface_impl->glDescription.level)); > + break; > + } I don't think SRGB_BOTH and SRGB_ANY make sense here. I also don't think this can work like this, context_apply_attachment_filter_states() needs to be aware of which texture was requested.

2 1

Re: [3/3] WineD3D: Update sRGB copies with fbo_blit if possible
by Henri Verbeet 06 Jul '09

06 Jul '09

2009/7/6 Stefan Dösinger <stefan(a)codeweavers.com>: > +void fbo_srgb_load(IWineD3DDevice *iface, IWineD3DSurface *surface, BOOL dst_srgb) > +{ > + IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; > + IWineD3DSurfaceImpl *surf = (IWineD3DSurfaceImpl *) surface; > + > + ENTER_GL(); This code needs an active GL context.

2 1

Re: crypt32: Update german translation (depends)
by Paul Vriens 06 Jul '09

06 Jul '09

André Hentschel wrote: > This is for the case Paul Vriens patch gets in > (http://www.winehq.org/pipermail/wine-patches/2009-July/075450.html) > --- > dlls/crypt32/crypt32_De.rc | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > ------------------------------------------------------------------------ > > Hi André, There is no dependency here. I merely changed one of the English resources, I didn't add one. -- Cheers, Paul.

2 2

Re: Try #2: user32: Windows test request (cursors/icons)
by Daniel Santos 06 Jul '09

06 Jul '09

> The way you are checking for Win9x is discouraged. We > rather not have GetVersion() but instead rely on behaviour > to check for Win9x. The checks I've inserted for Win9x are strictly to prevent crashing the OS. There were some previous checks in there and since I've had to add more checks, I made an inline function for it. Prior to NT, ms wasn't checking validity of handles in many cases, so calls to SetCursor and DestroyCursor with known invalid handles are what I believe is bringing them down. All of those should now be disabled on win9x. I wouldn't normally focus on such a thing so intensively (passing invalid handles), but this is precisely the type of issue that's been causing hangs and other annoyances in Lord of the Rings Online since their upgrade late last year, which started me working on these fixes. > test_DestroyCursorIcon returns a BOOL but most of the calls > don't use the returned value. A few do but then the return > value is not checked against, for example: > 996 /* Clean up. */ > 997 ret = > test_DestroyCursorIcon(handle, TRUE, TRUE, __LINE__, > 0xdeadbeef); Yea, when I added test_DestroyCursorIcon, I replaced all of the calls to DestroyCursor and DestroyIcon that didn't have special checks like ok(!ret, broken(ret), "..."), but I wanted the return value to be available in case it was needed later in the test code. I've removed all of the cases where the return value was captured in a variable and then never used and now nothing uses the return value, but I figure it's probably better to leave it returning the value than remove it in case some test modification later needs it for something. > There are also some spelling fixes needed (minor though, > I'd guess): hehe, lots of spelling errors, thanks! > 22 * FIXME: Add tests for CreateCursor and verify > that width & hight cannot exceed > Btw. This FIXME doesn't look right. The problem is specifically with the CreateCursor function. When I analysed it, I couldn't find any place that max height & width were checked and the GetSystemMetrics calls for those values are just hard-coded to return 32. Personally, I don't understand the X Windows implications well enough to delve further at this point, but I know that we are definitely missing tests for CreateCursor as well as the hidden 16-bit API function DestroyIcon32() which I've modified in my patches (yet to be submitted). > 78 * shouldFail [I] Rather of not it should > fail > Not sure what you are trying to say here. I clarified this documentation better. Essentially, TRUE if the call to DestroyCursor or DestroyIcon is expected to fail. I think I'll have the time so I'm going to try to get a new patch to you today. Thanks! Daniel

1 0

Re: Try #2: user32: Windows test request (cursors/icons)
by Daniel Santos 06 Jul '09

06 Jul '09

Thank you again for your time, effort and feedback! I wont have much time today, but I'll get another rendition as soon as I can. Daniel --- On Mon, 7/6/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > From: Paul Vriens <paul.vriens.wine(a)gmail.com> > Subject: Re: Try #2: user32: Windows test request (cursors/icons) > To: daniel.santos(a)pobox.com > Cc: wine-devel(a)winehq.org > Date: Monday, July 6, 2009, 3:49 AM > Daniel Santos wrote: > > Thanks again for testing this for me, Paul. I > have modified the tests so that they should pass and I've > skipped tests on win9x that I suspect are causing the blue > screens (personally, I doubt it's due to VMware). > > > > I moved the new test functions to the top of the file, > but I didn't remove the comments. I can shorten them > if preferred, but I personally prefer to have functions well > documented. > > > > So if you or anybody else could test this again for > me, I would greatly appreciate it. > > > > I guess it will be AJ's call in the end if these types of > comments are necessary. I don't have a strong opinion about > them. > > The way you are checking for Win9x is discouraged. We > rather not have GetVersion() but instead rely on behaviour > to check for Win9x. > > test_DestroyCursorIcon returns a BOOL but most of the calls > don't use the returned value. A few do but then the return > value is not checked against, for example: > > 996 /* Clean up. */ > 997 ret = > test_DestroyCursorIcon(handle, TRUE, TRUE, __LINE__, > 0xdeadbeef); > > There are also some spelling fixes needed (minor though, > I'd guess): > > (hight -> height) > 22 * FIXME: Add tests for CreateCursor and verify > that width & hight cannot exceed > Btw. This FIXME doesn't look right. > > 78 * shouldFail [I] Rather of not it should > fail > Not sure what you are trying to say here. > > (consistenit -> consistent) > (accross -> across) > 166 * Only use on very simple test cases where > behavior is consistenit accross > > (destory -> destroy) > 1365 /* Try to destory a bunch of > crap */ > FWIW, I don't like the word crap, but that's probably just > me. > > Test results: > > Win95: > cursoricon.c:1003: Test failed: Last error is 3735928559 > (0xdeadbeef), expected ERROR_INVALID_CURSOR_HANDLE (1402). > cursoricon.c:1004: Test failed: Last error is 3735928559 > (0xdeadbeef), expected ERROR_INVALID_CURSOR_HANDLE (1402). > cursoricon.c:305: Test failed: DestroyCursor returned 1, > expected FALSE. > cursoricon.c:305: Test failed: Last error is 3735928559 > (0xdeadbeef), expected 1402 (0x57a). > cursoricon.c:307: Test failed: DestroyIcon returned 1, > expected FALSE. > cursoricon.c:307: Test failed: Last error is 3735928559 > (0xdeadbeef), expected 1402 (0x57a). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 495 tests executed (0 marked as todo, 6 > failures), 0 skipped. > > Running it a second time hangs the box !!! > > Win98: > > Logged the output to file but then notepad.exe crashed. > Soon after that the system hangs !!!!! > > So Win9x needs definitely some more work. > > NT4: No failures. > > XP: No failures. > > Didn't test W2K, W2K3 and Vista as the output previously > was the same as XP. > > -- Cheers, > > Paul. >

1 0

installshield and 3GB ram (affects Dragon Naturally Speaking)
by Dan Kegel 06 Jul '09

06 Jul '09

Jay, does the problem affect any other apps? Until some confirms the patch works and/or that other apps are affected, the bug might not get much attention. - Dan ---------- Forwarded message ---------- From: Jay Starkman <jay(a)starkman.com> Date: Mon, Jul 6, 2009 at 5:38 AM Subject: Bug 15708 To: bugs-admin There's a patch posted for Bug 15708, LARGE_ADDRESS_AWARE flag. In attempting to install Dragon Naturally Speaking 7.0, all of us have gotten the message "DNS requires...at least 128MB RAM. Your system has...-673MB RAM." The setup program sees negative RAM on systems with over 2G. Since the patch is already out there, is it possible to compile the next iteration WITH the patch? I tried compiling my own WINE using the patch, but it caused problems and the WINE I compiled didn't work at all. I don't see Bug 15708 in your list of Bugs Scheduled to be Fixed before WINE 2.0 is released. There appears to be a simple patch that fixes it. Wouldn't it be possible to incorporate that patch into your next Wine_1.1.26? -Jay Starkman -------------------------------------------------------------------------- Jay Starkman, CPA Voice: 404-636-1400 Fax: 404-636-1130 2531 Briarcliff Road, Suite 116 e-mail: j(a)starkman.com Atlanta, Georgia 30329 Internet: http://www.starkman.com --------------------------------------------------------------------------

1 0

Re: crypt32: Add "Disallowed" to CryptFindLocalizedName
by Paul Vriens 06 Jul '09

06 Jul '09

Aurimas Fišeras wrote: > "Disallowed" is Used in Chrome. > > > ------------------------------------------------------------------------ > > Hi Aurimas, I was trying to update the NL resources but wasn't sure what to translate to. Disallowed on an English Windows version is actually "Untrusted Certificates". I will sent a "fix" for the English resources as the above makes more sense then 'Disallowed', I think. -- Cheers, Paul.

1 0

Re: why is Kronenberg's Wine/Mac work blacklisted on winehq?
by James Mckenzie 06 Jul '09

06 Jul '09

>James McKenzie wrote: >>Something that I do have to point out is that freetype, a very >important >>library for Wine is not shipped with XCode nor MacOSX. We have to >>include it. > >Huh? On my 10.5.7 Leopard system, Wine was able to find FreeType -- with >LD_LIBRARY_PATH guidance. And I have nothing but >- MacOS (with iLife preinstalled) >- (selected packages from) the Xcode install DVD and >- XQuartz 2.3.3.2 >installed on that box. > >Did you install Apple's X11 before installing XQuartz, as the XQuartz >site recommends? > >Are you mislead by the following error message? Possibly. I will check my system and see if libfreetype exists in /usr/X11/lib. James McKenzie

1 0

Re: Direct3D 10 Current Status
by Henri Verbeet 06 Jul '09

06 Jul '09

Chris Smowton wrote: > Hello, > > First of all my apologies if you're the wrong person to ask; I got your > name by searching the wine-cvs list for who seemed to be doing most > D3D10 work. If you're not the right person to ask the following > questions, I'd appreciate if you'd advise who if anyone I'd be better > off asking. > In general, wine-devel is the most appropriate place for questions like these. > Now then, I'd like to ask you about the current state of Wine's D3D10 > support. I'm looking at how much effort will be required to gain D3D10 > support for virtual machines, and Wine's D3D9 code has of course been > used in a few virtualisation solutions. Here are my specific questions: > > 1. Would I be right in assuming that D3D10 support is currently very > basic -- at the level of user apps being able to create a device and > context, but not perform rendering as of yet? > Pretty much. We can do some rendering, but don't expect anything beyond very simple sample applications to work. > 2. What about shaders -- has the Wine project made much progress > supporting the new shader models? > We have some initial SM4 support. We can reuse a lot of the infrastructure for previous shader models, but the SM4 binary format isn't publicly documented anywhere, as far as I'm aware. > 3. Whilst of course Wine doesn't need to do this, have you gained any > insight into how the MS D3D10 usermode runtime interfaces with the DWM? > I assume that simply replacing d3d10.dll on a Windows system with the > hope of remoting rendering is not practicable because the runtime > presumably creates the window's primary surface with a shared handle, > and passes that handle on to the DWM to perform rendering. I see no > reason why that internal D3D usermode runtime <--> window manager > process interaction ought to be documented, and so a replacement for > d3d10.dll on a real Windows system would seem like it would necessarily > involve reverse engineering that process, but perhaps I'm wrong? > We didn't really look. I'd expect that to be done by dxgi rather than d3d10 or d3d10core though. Henri

1 0

[rfc] lstrcmpi: order still wrong (was "Re: Regression in lstrcmpiA (occurred in late June, NLS related)" from 2003 year)
by Yuriy Kaminskiy 06 Jul '09

06 Jul '09

Hello! Previous thread on this topic: http://www.mail-archive.com/wine-devel@winehq.org/msg01080.html I've stumbled over problem with lstrcmpi sorting is still wrong. Some japanese game engine uses binary search on presorted array, and fails with a-la "object not found" errors. Judging by object order in archive, === cut === ... conf_p.MGD----- (would fail with strcasecmp, ok with wine) conf01.MGD--/ ... title.MGD------ fails with vanilla wine title_p.MGD--/ ... === cut === proper order should be "_" < "0" (ok) and "." < "_" (fails with vanilla wine). I've replaced collation weight of '_' with 0x02560111, and now these games run fine; but that's dirty hack, of cause, and should not be applied to upstream: 1) it is modifies generated file; 2) weight for "_" chosen arbitrary and can cause conflicts somewhere else (or, rather, not can, but certainly will - there are other symbols with weight 0x0256???); 3) weight for other "_"-like chars should be modified too. Hope you can suggest better solution. FWIW, I've checked mentioned in previous thread unicode-2.1.9d8 tables - same mismatch, will not work too. I think, only proper way is somehow extract this table from windows (either directly by LCMapStringW(LC_MAP_SORTKEY), or sorting array of a[i]=i; with CompareStringW and using that order). I'm not a lawyer, but really doubt that such reproduced table can be considered copyrightable anywhere. How can anyone make compatible reimplementation without reproducing in some way this table? --

2 3

Try #2: user32: Windows test request (cursors/icons)
by Daniel Santos 06 Jul '09

06 Jul '09

Thanks again for testing this for me, Paul. I have modified the tests so that they should pass and I've skipped tests on win9x that I suspect are causing the blue screens (personally, I doubt it's due to VMware). I moved the new test functions to the top of the file, but I didn't remove the comments. I can shorten them if preferred, but I personally prefer to have functions well documented. So if you or anybody else could test this again for me, I would greatly appreciate it. Thanks! Daniel --- On Fri, 7/3/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > From: Paul Vriens <paul.vriens.wine(a)gmail.com> > Subject: Re: user32: Windows test request (cursors/icons) > To: daniel.santos(a)pobox.com > Cc: wine-devel(a)winehq.org > Date: Friday, July 3, 2009, 3:44 PM > Daniel Santos wrote: > > I don't have access to a working windows machine right > now and would appreciate if somebody can run these tests > against XP, vista and/or 9x. > > > > Thanks! > > Daniel > > > Hi Daniel, > > Tested on XP Professional SP3: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > NT4 Server SP6a: > > cursoricon.c:1363: Test failed: DestroyCursor returned 1, > expected FALSE. > cursoricon.c:1363: Test failed: Last error is 3735928559 > (0xdeadbeef), expected 1402 (0x57a). > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: DestroyIcon returned 1, > expected FALSE. > cursoricon.c:1369: Test failed: Last error is 3735928559 > (0xdeadbeef), expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 7 > failures), 0 skipped. > > W2K Professional SP4: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > W2K3 SE SP2: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 6 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 554 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > Vista Ultimate - SP2: > > cursoricon.c:1367: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1369: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:1371: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon.c:184: Test failed: Last error is 1402 (0x57a), > expected 1414 (0x586). > cursoricon: 11 tests executed (0 marked as todo, 0 > failures), 0 skipped. > cursoricon: 553 tests executed (0 marked as todo, 4 > failures), 0 skipped. > > I get a blue screen on Win95 and Win98 (VMware issue?) !! > > Some remarks on your patch: > > - Please move the new functions to the top so you don't > have to forward declare them. > - The level of comments for the 2 added functions is > something we usually expect for implementations, not for > tests ;) > > -- Cheers, > > Paul. >

2 1

"make test" redux
by Dan Kegel 06 Jul '09

06 Jul '09

We've had a test suite for six or so years now, and we keep getting closer to having it pass reliably, but we're still not quite there. I see from http://test.winehq.org that fifteen tests fail on at least one machine. There are several bugs that only cause make test to fail if you run them with WINEDEBUG=warn+heap, but those seem just as important to me. On my own machine, here are the bugs related to make test failures: http://bugs.winehq.org/show_bug.cgi?id=12925 http://bugs.winehq.org/show_bug.cgi?id=14078 http://bugs.winehq.org/show_bug.cgi?id=17414 http://bugs.winehq.org/show_bug.cgi?id=17518 http://bugs.winehq.org/show_bug.cgi?id=19183 I submitted a patch to fix http://bugs.winehq.org/show_bug.cgi?id=17518 but it'd be nice to get some love on the others. - Dan

3 3

Using tracing for tests on Wine
by Paul Vriens 06 Jul '09

06 Jul '09

Hi, I've always had a patch in my local repo that runs runtest with the '-v' flag instead if '-q' as I'm not always interested in just the failures. Having '-q' for runtest basically means that I didn't find a way to override things. WINETEST_DEBUG=<number> doesn't work when I do a 'make <test>.ok' as the debug flag will be overwritten by runtest. What would be the best approach here: - Make '-v' the real default like it is on Windows? I've sent a patch for this a long time ago but didn't receive any feedback nor was I too interested in getting that in. (See attached) - If WINETEST_DEBUG is set it will always override the '-q' or '-v' flag for runtest? - Get rid of the '-v' and '-q' altogether in runtest? Other suggestions? -- Cheers, Paul. diff --git a/dlls/Maketest.rules.in b/dlls/Maketest.rules.in index a7095a5..25ff681 100644 --- a/dlls/Maketest.rules.in +++ b/dlls/Maketest.rules.in @@ -15,7 +15,7 @@ DEFS = $(EXTRADEFS) MODULE = $(TESTDLL:%.dll=%)_test.exe TESTRESULTS = $(CTESTS:.c=.ok) TESTPROGRAM = $(MODULE)$(DLLEXT) -RUNTESTFLAGS = -q -P wine -M $(TESTDLL) -T $(TOPOBJDIR) -p $(TESTPROGRAM) +RUNTESTFLAGS = -v -P wine -M $(TESTDLL) -T $(TOPOBJDIR) -p $(TESTPROGRAM) C_SRCS = $(CTESTS) ALL_LIBS = $(IMPORTS:%=-l%) $(EXTRALIBS) $(LDFLAGS) $(LIBS)

1 0

Building problems on Intel Mac.
by Zheng Che 06 Jul '09

06 Jul '09

Screenshot attached.

4 3

New winetricks 20090705: new verb shockwave; updated xvid and firefox
by Dan Kegel 06 Jul '09

06 Jul '09

Another <insert time period here>, another winetricks. The only interesting change is the addition of shockwave, and maybe the update to firefox 3.5. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL.) Semi-interesting changes since 20090607: ------------------------------------------------------------------------ r546 | daniel.r.kegel | 2009-07-05 18:09:13 -0700 (Sun, 05 Jul 2009) | 3 lines Updated firefox, xvid; added shockwave; bumped version to 20090705 ------------------------------------------------------------------------ r521 | austinenglish | 2009-06-24 16:37:21 -0700 (Wed, 24 Jun 2009) | 2 lines winetricks: ignore 194 exit code from ie6 ------------------------------------------------------------------------ r520 | austinenglish | 2009-06-24 15:19:26 -0700 (Wed, 24 Jun 2009) | 2 lines winetricks: fix download function's renaming files when using wget ------------------------------------------------------------------------ r519 | austinenglish | 2009-06-24 15:17:34 -0700 (Wed, 24 Jun 2009) | 2 lines winetricks: fix DiVX download link

1 0

Re: cryptdlg: Translate "CPS" (Certification Practice Statement) to Lithuanian and add a comment to English resource
by Juan Lang 06 Jul '09

06 Jul '09

Hi Aurimas, - IDS_CPS "CPS" + IDS_CPS "SVN" /* Sertifikavimo Veiklos Nuostatos */ I'm not sure this is a good idea. In common usage, acronyms are not translated. In this case, the acronym CPS is part of a standard, RFC2527, so it doesn't seem like a good idea to abbreviate the translated name to a new acronym that isn't anywhere except this dialog. As another example, here's Frédéric Delanoy's recent update of the same string in French (with apologies for the mangled encoding): + IDS_CPS "Ã‰noncÃ© des pratiques de certification (CPS)" That is, the text is translated, but the acronym is not. This seems like a better approach to me. Regards, --Juan

1 0

Re: [1/3] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer
by Vincent Povirk 05 Jul '09

05 Jul '09

+ sts = GdipCloneMatrix(container->worldtrans, &newTrans); + if(sts != Ok) + return sts; + + sts = GdipCloneRegion(container->clip, &newClip); + if(sts != Ok) + return sts; This leaks a matrix if GdipCloneRegion fails. -- Vincent Povirk

1 0

Re: server/fd.c: Prevent using uninitialized pointers
by Henri Verbeet 05 Jul '09

05 Jul '09

2009/6/30 Daniel Santos <javatroubadour(a)yahoo.com>: > Some pointers are getting used prior to initialization. It would appear that the current compilers are initializing them to zero or we've been lucky. > No, the C standard specifies that these are initialized to NULL, since they have static storage duration.

4 5

Testing modal property sheets
by Nikolay Sivov 05 Jul '09

05 Jul '09

Hi. Some time ago I tried to fix bug http://bugs.winehq.org/show_bug.cgi?id=16876 . It's about wrong return codes of PropertySheet call. The question is about a proper way of testing this. I tried to exit just after creation in PSCB_INITIALIZED handler, it looks like it shows a problem, but I'm not sure is it a correct way or not. I'd like to see some advices about that Thanks. rom 56c14340af9ac298bde22cf207fca7c8ae95957c Mon Sep 17 00:00:00 2001 From: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat, 23 May 2009 19:21:08 +0400 Subject: Some propsheet tests --- dlls/comctl32/tests/propsheet.c | 128 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 128 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/tests/propsheet.c b/dlls/comctl32/tests/propsheet.c index 4164f68..37b89fd 100644 --- a/dlls/comctl32/tests/propsheet.c +++ b/dlls/comctl32/tests/propsheet.c @@ -199,9 +199,137 @@ static void test_disableowner(void) DestroyWindow(parent); } +#define PSM_PRESSBUTTON_CALLBACK(id) \ +static int CALLBACK psm_pressbutton_callback_##id (HWND hwnd, UINT msg, LPARAM lparam) \ +{\ + switch(msg)\ + {\ + case PSCB_INITIALIZED:\ + {\ + PostMessage(NULL, PSM_PRESSBUTTON, PSBTN_##id, (LPARAM)0);\ + return FALSE;\ + }\ + }\ + return FALSE;\ +} + +PSM_PRESSBUTTON_CALLBACK(OK) +PSM_PRESSBUTTON_CALLBACK(CANCEL) +PSM_PRESSBUTTON_CALLBACK(APPLYNOW) +PSM_PRESSBUTTON_CALLBACK(BACK) +PSM_PRESSBUTTON_CALLBACK(FINISH) +PSM_PRESSBUTTON_CALLBACK(HELP) +PSM_PRESSBUTTON_CALLBACK(NEXT) + +static void test_singlepressbutton(INT id, INT expected, BOOL modal, BOOL todo, int line) +{ + HPROPSHEETPAGE hpsp[1]; + PROPSHEETPAGEA psp; + PROPSHEETHEADERA psh; + HWND hdlg; + INT ret; + DWORD r; + + memset(&psp, 0, sizeof(psp)); + psp.dwSize = sizeof(psp); + psp.dwFlags = 0; + psp.hInstance = GetModuleHandleW(NULL); + U(psp).pszTemplate = "prop_page1"; + U2(psp).pszIcon = NULL; + psp.pfnDlgProc = NULL; + psp.lParam = 0; + + hpsp[0] = CreatePropertySheetPageA(&psp); + + memset(&psh, 0, sizeof(psh)); + psh.dwSize = sizeof(psh); + psh.pszCaption = "test caption"; + psh.nPages = 1; + U3(psh).phpage = hpsp; + + if (modal) + { + /* modal sheet */ + psh.dwFlags = PSH_USECALLBACK; + psh.hwndParent = NULL; + switch(id) + { + case PSBTN_BACK: + psh.pfnCallback = psm_pressbutton_callback_BACK; + break; + case PSBTN_NEXT: + psh.pfnCallback = psm_pressbutton_callback_NEXT; + break; + case PSBTN_FINISH: + psh.pfnCallback = psm_pressbutton_callback_FINISH; + break; + case PSBTN_OK: + psh.pfnCallback = psm_pressbutton_callback_OK; + break; + case PSBTN_APPLYNOW: + psh.pfnCallback = psm_pressbutton_callback_APPLYNOW; + break; + case PSBTN_CANCEL: + psh.pfnCallback = psm_pressbutton_callback_CANCEL; + break; + case PSBTN_HELP: + psh.pfnCallback = psm_pressbutton_callback_HELP; + break; + } + + ret = PropertySheetA(&psh); + if (todo) + { + todo_wine ok_(__FILE__, line)(ret == expected, "Expected %d result, got %d\n", expected, ret); + } + else + ok_(__FILE__, line)(ret == expected, "Expected %d result, got %d\n", expected, ret); + } + else + { + /* modeless sheet */ + psh.dwFlags = PSH_MODELESS; + psh.hwndParent = GetDesktopWindow(); + + hdlg = (HWND)PropertySheetA(&psh); + ok(IsWindow(hdlg), "Expected dialog handle, got %p\n", hdlg); + + SendMessage(hdlg, PSM_PRESSBUTTON, PSBTN_FINISH, 0); + ok(IsWindow(hdlg), "Expected dialog handle, got %p\n", hdlg); + r = SendMessage(hdlg, PSM_GETRESULT, 0, 0); + if (todo) + { + todo_wine ok_(__FILE__, line)(r == expected, "Expected %d result, got %d\n", expected, r); + } + else + ok_(__FILE__, line)(r == expected, "Expected %d result, got %d\n", expected, r); + + DestroyWindow(hdlg); + } +} + +static void test_psmpressbutton(void) +{ + test_singlepressbutton(PSBTN_BACK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_BACK, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_NEXT, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_NEXT, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_FINISH, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_FINISH, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_OK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_OK, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_CANCEL, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_CANCEL, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_APPLYNOW, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_APPLYNOW, IDOK, FALSE, FALSE, __LINE__); + test_singlepressbutton(PSBTN_HELP, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_HELP, IDOK, FALSE, FALSE, __LINE__); +} + START_TEST(propsheet) { test_title(); test_nopage(); test_disableowner(); + test_psmpressbutton(); } -- 1.5.6.5 >From 370b1938ce218b8be93d463267ff23adf33097bd Mon Sep 17 00:00:00 2001 From: Nikolay Sivov <bunglehead(a)gmail.com> Date: Sat, 23 May 2009 19:34:54 +0400 Subject: Fix PropertySheet return value for modal sheets --- dlls/comctl32/propsheet.c | 5 +---- dlls/comctl32/tests/propsheet.c | 14 +++++++------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/dlls/comctl32/propsheet.c b/dlls/comctl32/propsheet.c index 44151e4..7d337bd 100644 --- a/dlls/comctl32/propsheet.c +++ b/dlls/comctl32/propsheet.c @@ -1703,7 +1703,7 @@ static BOOL PROPSHEET_Finish(HWND hwndDlg) if (msgResult != 0) return FALSE; - if (psInfo->result == 0) + if (psInfo->result == 0 && psInfo->isModeless) psInfo->result = IDOK; if (psInfo->isModeless) psInfo->activeValid = FALSE; @@ -2742,10 +2742,7 @@ static INT do_loop(const PropSheetInfo *psInfo) } if(ret == 0) - { PostQuitMessage(msg.wParam); - ret = -1; - } if(ret != -1) ret = psInfo->result; diff --git a/dlls/comctl32/tests/propsheet.c b/dlls/comctl32/tests/propsheet.c index 37b89fd..b7a97cd 100644 --- a/dlls/comctl32/tests/propsheet.c +++ b/dlls/comctl32/tests/propsheet.c @@ -310,19 +310,19 @@ static void test_singlepressbutton(INT id, INT expected, BOOL modal, BOOL todo, static void test_psmpressbutton(void) { - test_singlepressbutton(PSBTN_BACK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_BACK, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_BACK, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_NEXT, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_NEXT, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_NEXT, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_FINISH, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_FINISH, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_FINISH, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_OK, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_OK, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_OK, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_CANCEL, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_CANCEL, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_CANCEL, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_APPLYNOW, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_APPLYNOW, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_APPLYNOW, IDOK, FALSE, FALSE, __LINE__); - test_singlepressbutton(PSBTN_HELP, 0, TRUE, TRUE, __LINE__); + test_singlepressbutton(PSBTN_HELP, 0, TRUE, FALSE, __LINE__); test_singlepressbutton(PSBTN_HELP, IDOK, FALSE, FALSE, __LINE__); } -- 1.5.6.5

1 0

Re: [cryptui] Show the select store text when browsing stores
by Aurimas Fišeras 05 Jul '09

05 Jul '09

On 07/05/2009 04:08 PM, Paul Vriens wrote: > Hi, > > We at least see the text now. Selecting is possible but doesn't work > (regression?). > > Changelog > Show the select store text when browsing stores > > > ------------------------------------------------------------------------ > > > + selectInfo.pwszText = LoadStringW(hInstance, IDC_STORE_TEXT, > + storeText, sizeof(storeText) / sizeof(storeText[0])); LoadStringW returns int, not string! LoadStringW(hInstance, IDC_STORE_TEXT, storeText, sizeof(storeText) / sizeof(storeText[0])); selectInfo.pwszText = storeText;

2 3

AcceptEx Proposal
by Mike Kaplinskiy 05 Jul '09

05 Jul '09

I have been thinking about the correct way to implement AcceptEx, and I was looking for comments about the approach. Note I know all of these cases will require tests, I'm just listing them for problems someone might see. Wineserver changes: - add an async* to the socket structure to track this socket's request on the listening socket's queue. (set = null on accept) - Can anything do anything wrong while trying to remove the async when the accepting socket is closed before the accept event is received? (removing another socket's async request) - When/how should we handle setting this (create a new request type (that queues & sets), create a new request type (that just sets) or somehow splice into sock_queue_async? - my vote for first, as much as I hate it) - change accept_socket to use two sockets instead of returning the accepted socket - Problem: we have to destroy the fd of the old socket. Can anything queue async reads/writes before the overlapped acceptex returns? Do we care that the fd of a socket object gets switched (you lose internal state, but I don't think you can have a lot of state on an unbound socket) - Deferred sockets are a pain: 2 clients attempt to connect->accept->defer->acceptex=which socket does it return? Also if this order happens, and we have to destroy the fd as above, would the application possibly care? - need to implement SO_UPDATE_ACCEPT_CONTEXT and have accept() call it right after getting an accept. - if we close the listener socket, what happens to sockets waiting for clients on the accepting socket? Can we reuse these sockets? ws2 changes: - exactly the same as the previous attempt, just using the above requests - more strict checks are needed on the second acceptex socket (need to check family, bound state) - accept: a = create_socket(), accept_socket(listener, a), ioctl)SO_UPDATE_ACCEPT_CONTEXT, a, &listener); I just started looking at wineserver, so don't be surprised if something above doesn't make sense. Mike.

2 2

Howto put a new rpm package on sourceforge ?
by marco 05 Jul '09

05 Jul '09

Hi all, I make the mandriva packages and put them on sourceforge. But sourceforge changed there layout and now I can not longer find the button to add new releases or to manage them? Anyone know where they are ? The sourgeforge wiki is taking about a admin button on the summary page, but it is not visible when I log in. Can someone help me ? kind regards, Marco Meijer

3 4

16-bit Code on MacOSX Leopard/XCode 3.1
by James McKenzie 05 Jul '09

05 Jul '09

I know that this was disabled, but what happens when I try to run a 16 bit app? Here is what happened when I tried to build 1.1.25 with XCode 3.1 today: checking whether 16-bit code can be built correctly... no configure: error: Xcode 3.x cannot build 16-bit code correctly. Use --disable-win16 if you don't need 16-bit support. ***** Error: Can't build wine Great catch, BTW. James McKenzie

3 3

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by James McKenzie 04 Jul '09

04 Jul '09

Christoph von Wittich wrote: As Dmitry wrote about this, I will add the comment that this does not look like the proper way to fix this problem. The proper way is to keep the pointer from overflowing in the first place and that would be to place a check where it is set and updated to either go negative (which should not be allowed) or to be incremented past INT_MAX. This can be implemented in several different ways, and since I have not looked at the code, I could not make a proper suggestion but would suggest that the pointer be checked before incrementing and after setting. James McKenzie

1 0

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by James McKenzie 04 Jul '09

04 Jul '09

Brent Roman wrote: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. > > GetSystemMenu() is always supposed to return a valid HMENU handle, but > the logic in Wine's version would return nil in some cases where > windows would return an HMENU. Specifically, when the relevant > windows dwStyle mask did not include WS_SYSMENU, wine would return > nil, but windows would still return a valid HMENU. > > To reproduce the bug: > > 1. Download and install the Quadravox AQ430 development tools from: > http://www.quadravox.com/AQ430.htm > http://appdb.winehq.org/objectManager.php?sClass=application&iId=9939 > > 2. Attempt to compile any 'C' source file. > > Before applying the patch, all such attempts will quickly fail with an > invalid read from address 0x4. You rewrote the entire function, there is no need to do this. Please use the same formatting as the rest of the code. Add new variables to the bottom of the list, you imbedded one or more. Since the rest of the function uses four spaces, use them. Avoid the use of tabs, some editors spread them to four spaces, some two and yet others eight. Makes the code look sloppy and is very hard to read. Can you provide test cases, other than 'use this program to prove it works'? The idea is to replicate Windows API functionality and some programs rely on certain functionality working in a very specific manner. If you build to the program, you might break others. Also, if you have left out some function, please insert c style notes stating this. Makes it easier to find where certain code pieces go at a later time. James McKenzie

1 0

A tiny GetSystemMetrics question
by Nikolay Sivov 04 Jul '09

04 Jul '09

Hi. Trying to fix some ListView bugs I've found that on native (XP SP2) system this call: --- GetSystemMetrics(SM_CXICONSPACING) --- doesn't return the value specified in appearance -> advanced settings of Display properties sheet. I've got 75 value for both cx and cy while I have set it to 43 in dialog box. This look weird for me. Does anybody know what is the reason of this behavior? P.S. Yes, I'm using default 96 dpi on this XP box (if it does matter).

2 2

Re: [PATCH 3/5] d3d9/tests: Add a small test for having multiple device active at the same time.
by Paul Vriens 03 Jul '09

03 Jul '09

Henri Verbeet wrote: > This is essentially the situation that caused problems with reusing the > initial GL context. > --- > dlls/d3d9/tests/device.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 65 insertions(+), 0 deletions(-) > Hi Henri, > + hr = IDirect3D9_CreateDevice(d3d9, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd1, > + D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device1); > + ok(SUCCEEDED(hr), "Failed to create a device, hr %#x\n", hr); This one seems to fail on a lot of boxes, currently only VMware and ATI so it seems. NVIDIA and Intel seem to be fine though (for now as only a few tests are in). Is D3DERR_NOTAVAILABLE an acceptable error? If so than the ok() message can be easily extended (maybe with an extra skip() message?). Could you have a look? -- Cheers, Paul.

2 1

user32: Windows test request (cursors/icons)
by Daniel Santos 03 Jul '09

03 Jul '09

I don't have access to a working windows machine right now and would appreciate if somebody can run these tests against XP, vista and/or 9x. Thanks! Daniel

2 1

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer
by Nikolay Sivov 03 Jul '09

03 Jul '09

Andrew Eikum wrote: > --- > dlls/gdiplus/gdiplus_private.h | 3 + > dlls/gdiplus/graphics.c | 154 ++++++++++++++++++++++++++++++++++++++-- > include/gdiplusflat.h | 1 + > 3 files changed, 152 insertions(+), 6 deletions(-) > This looks wrong for me cause I don't think you could pass container id created with one Graphics to Graphics.EndContainer() of another. I've just checked it and it doesn't return any error code, but generated container ids aren't the same when you call BeginContainer() for e.g. two objects as sequent steps. It looks like on native these value are module unique, some kind of handle table needed. This kills the first problem I described - passing strange value to another Graphics. Also note that Save()/Restore() functionality uses the same stack with container calls (at least msdn tells us that), for that Save/Restore we already have a test: --- static void test_save_restore(void) .... /* The same state value should never be returned twice. */ todo_wine check_no_duplicates(state_log); .... --- It clearly says that no duplicates allowed, even after multiple object deletion - it checks for values returned during the whole test.

3 7

Re: kernel32: Compile .mc files to resources as independent files.
by Paul Vriens 03 Jul '09

03 Jul '09

Hi, kernel32 translations don't show up at the translation page anymore. Do we need to teach wrc to deal with rc files being one level lower (nls directory?) or what is needed to correct this? (Before this patch the page basically showed if there was a translation or not and not whether the content was correct) -- Cheers, Paul.

2 1

Patch feedback (GetProductInfo)
by Alexander Nicolaysen Sørnes 03 Jul '09

03 Jul '09

Hello, Could someone give me a hint as to what is wrong with the following patches? http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html They only adds some defines plus a stub, so hopefully there isn't that much I can have done wrong :) Alexander N. Sørnes

2 2

Re: comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.
by Paul Vriens 03 Jul '09

03 Jul '09

Rein Klazes wrote: > fixes bug #19079 > > The application of this bug report subclasses the window proc of the file > dialog. It does not return the result in the DWLP_MSGRESULT dialog > property but the return code of the window proc. Tests are provided to > show correct behaviour in all cases, subclassed or not. > --- > dlls/comdlg32/filedlg.c | 8 ++-- > dlls/comdlg32/tests/filedlg.c | 112 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 116 insertions(+), 4 deletions(-) > Hi Rein, This one introduced extra test failures on Vista. On 1 Vista box and W2K8 the test times out (crashes?). Could you have a look. -- Cheers, Paul.

2 2

Re: [2/2] gdiplus: Implement GdipBeginContainer2 and GdipEndContainer
by Vincent Povirk 03 Jul '09

03 Jul '09

>+static GpStatus init_container(GraphicsContainerItem** container, >+ GDIPCONST GpGraphics* graphics){ >+ GpStatus sts; >+ >+ if(!container || !graphics) >+ return InvalidParameter; Since this is an internal function and you know container and graphics will always be non-NULL when you call it, you don't need to make this check. >+ sts = GdipDeleteMatrix(graphics->worldtrans); >+ if(sts != Ok) >+ return sts; >+ >+ sts = GdipCloneMatrix(container->worldtrans, &graphics->worldtrans); >+ if(sts != Ok) >+ return sts; If the delete succeeds but the clone fails, you'll have a Graphics with a deleted world transform. You should allocate the objects you need before freeing those attached to the Graphics. I think that in this case you could get away with copying pointers rather than creating new objects, and you can assume the delete functions succeed. Since the container is about to be destroyed, you would need to make sure the attached matrix and region are not destroyed with it. >+ /* did not find a matching container */ >+ if(&container->entry == &graphics->containers) >+ return Ok; That's a little strange, even though the test shows it's not an error. Personally, I would throw in a WARN for this case. I assume you meant to mark this as [1/2] and the test as [2/2]. This looks good to me. It's almost at the point where I can't predict whether it will be accepted (as opposed to being sure it won't), but Alexandre nailed me once for doing a similar "delete before allocating the replacement" thing. So I assume he cares about that. -- Vincent Povirk

1 0

Re: [1/2] gdiplus/tests: Test cases for GdipBeginContainer2
by Vincent Povirk 03 Jul '09

03 Jul '09

+ GdipGetClipBounds(graphics, &clip); + win_skip(/*fabs(defClip[0] - clip.X) < 0.0001 && + fabs(defClip[1] - clip.Y) < 0.0001 && + fabs(defClip[2] - clip.Width) < 0.0001 && + fabs(defClip[3] - clip.Height) < 0.0001,*/ + "Expected Clipping Rectangle to be restored to [%f, %f, %f, %f], got [%f, %f, %f, %f]\n", + defClip[0], defClip[1], defClip[2], defClip[3], + clip.X, clip.Y, clip.Width, clip.Height); Unconditional win_skip (or skip) does not make sense. skip indicates that some tests have been skipped, but this is not the case here. If that fails on Windows, you should fix it. -- Vincent Povirk

1 0

Appdb flight simulation sub category
by Keith Muir 02 Jul '09

02 Jul '09

Hi, Any chance of a games> simulation> flight simulation sub category? Regards, Keith

4 4

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by Dmitry Timoshkov 02 Jul '09

02 Jul '09

"Christoph von Wittich" <Christoph(a)ApiViewer.de> wrote: > + if (*pcbProvName > INT_MAX) > + *pcbProvName = INT_MAX; In which way WideCharToMultiByte is broken? It always helps to provide an explanation and if possible a test case. -- Dmitry.

2 1

Re: user32: Add a test for BM_SETSTYLE, make it pass under Wine.
by Paul Vriens 02 Jul '09

02 Jul '09

Dmitry Timoshkov wrote: > --- > dlls/user32/button.c | 14 ++++++- > dlls/user32/tests/msg.c | 86 ++++++++++++++++++++++++++++++++++++++-------- > 2 files changed, 83 insertions(+), 17 deletions(-) > Hi Dmitry, These new tests introduce some failure on Win98/WinMe. Could you have a look? -- Cheers, Paul.

1 0

Wine64: Down to 68 test failures!
by Austin English 02 Jul '09

02 Jul '09

For those of you that don't follow http://test.winehq.org/, AJ and others 64-bit work has brought down the failures to 68: http://test.winehq.org/data/fb0275dd3148a098967f5959adb57ebe41a4383e/index_… Down quite a bit from over 100 about 6 months ago. There's still a lot of work to do, of course. If you've got a 64-bit machine, give your favorite area of the wine tree a try in 64-bit mode and fix some test failures/compiler warnings. -- -Austin

1 0

Re: regedit: Implement open last key at startup [try 3]
by Michael Karcher 02 Jul '09

02 Jul '09

Am Donnerstag, den 02.07.2009, 17:42 +0500 schrieb Vladimir Pankratov: > Implement open last key at startup. Why do you use wszKey in the get code path, but wszVal in the set code path? But before you change that, read on: +static void get_set_last_key(HWND hwndTV, BOOL bget) This looks to me like the "boolean parameter to change behaviour" antipattern. I think you did it to avoid duplication of the wsz... constants for the registry path and the key name. Make them global variables (still static, so file local), and make two functions out of it. Open the key only for READ access if you want to load. Why do you copy the result of GetItemFullPath? Why don't you free the result of GetItemFullPath? Finally, I think Paul Vriens was wrong on omitting the RegCloseKey. While you really don't have to close predefined keys like HKEY_CURRENT_USER, you do have to close HKCU\Software\Microsoft\Windows \CurrentVersion\Applets\Regedit. Regards, Michael Karcher

2 2

Re: regedit: Implement open last key at startup [try 2]
by Paul Vriens 02 Jul '09

02 Jul '09

Vladimir Pankratov wrote: > Hello. > > Open last key at startup. > > Changed files: > regedit/childwin.c > > Thanks. > > > ------------------------------------------------------------------------ > > Hi Vladimir, Please use a constant instead of hardcoded 260 as suggested by Andre'. You also should be using the RegCreate variant of the function as this key does not yet exist. There is no need for the RegCloseKey as you are opening a predefined one. -- Cheers, Paul.

2 1

Re: Minor fix for include/bits1_5.idl
by Gerald Pfeifer 02 Jul '09

02 Jul '09

Strike that, I must have misread the documentation. Only thing I am wondering is do we really need the (unsigned long) here? If anyone has a pointer to clear documentation that would be nice; what I found so far leaves some questions open... Gerald On Sun, 28 Jun 2009, Gerald Pfeifer wrote: > The generated file include/bits1_5.h is the same before and after this > patch, yet somehow the original form strikes me as a bit odd at best... > > Gerald > > > ChangeLog: > Fix prototype for GetReplyData(). > > diff --git a/include/bits1_5.idl b/include/bits1_5.idl > index 274a7de..29520e2 100644 > --- a/include/bits1_5.idl > +++ b/include/bits1_5.idl > @@ -39,7 +39,7 @@ interface IBackgroundCopyJob2 : IBackgroundCopyJob > } BG_JOB_REPLY_PROGRESS; > > HRESULT GetReplyProgress([in, out] BG_JOB_REPLY_PROGRESS *progress); > - HRESULT GetReplyData([out, size_is( , (unsigned long) *pLength)] byte **pBuffer, > + HRESULT GetReplyData([out, size_is((unsigned long) *pLength)] byte **pBuffer, > [in, out, unique] UINT64 *pLength); > HRESULT SetReplyFileName([unique] LPCWSTR filename); > HRESULT GetReplyFileName([out] LPWSTR *pFilename);

2 1

Re: AppDB test results in Spanish
by Susan Cragin 02 Jul '09

02 Jul '09

>>> Who feels like translating some test results? >>> >>> http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI… >I mean someone actually replace that entry with a translated version. >I could do it via Google Translate, but I'd rather someone who *knows* >Spanish replace it with a REAL translation :) I read Spanish. Here's my take. I got as far as the load menu and one quick race. In "race" mode the videos don't work, and other modes also fail. Many things. All this was configured with Windows Vista settings. That can prove anything. No more to say. (Or, that goes without saying.)

3 2

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Alexandre Julliard 02 Jul '09

02 Jul '09

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > Last time I submitted this (pretty trivial) patch, it got ignored. What makes you think this is necessary? Did you test it? -- Alexandre Julliard julliard(a)winehq.org

2 1

AppDB test results in Spanish
by Ben Klein 02 Jul '09

02 Jul '09

Who feels like translating some test results? http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI…

3 3

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Nicolas Le Cam 02 Jul '09

02 Jul '09

Le 2 juillet 2009 09:29, Frédéric Delanoy<frederic.delanoy(a)gmail.com> a écrit : > Last time I submitted this (pretty trivial) patch, it got ignored. > If it's in a bad format, please let me know! > > Frédéric Hi Frédéric, System messages already contain a new line, you don't need to add a second one. -- Nicolas Le Cam

1 0

Re: winex11.drv: Move clipboard handling to a separate thread
by Alexandre Julliard 02 Jul '09

02 Jul '09

Yuri Khan <yurivkhan(a)gmail.com> writes: > This patch achieves this by creating an auxiliary thread that will run > in the same process that puts data on the clipboard and handle X > selection messages. That looks quite inefficient, especially since you create a new thread every time. You should limit this to the cases where it's really necessary, using clipboard from command line apps is a very uncommon operation. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by James Mckenzie 02 Jul '09

02 Jul '09

> >You probably want a separate code path in shellpath.c for the Mac. I >don't think XDG works there. > Can check, but make sure you do not use ObjC code. AJ will reject. Also pass to me, and I will add/test it. James McKenzie

1 0

Re: [PATCH 5/6] urlmon: Added user agent tests.
by Paul Vriens 01 Jul '09

01 Jul '09

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 84 > ++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 82 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, The addition of these new tests led to a Coverity warning (#947) as your using str2 in your tests. str2 is checked for NULL earlier on but only skips a few tests now if it's indeed NULL. The question is, should we just add a return after the skip() or get rid of the whole checking for NULL. (The str2 checking was not added by you btw). -- Cheers, Paul.

2 1

RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by Joerg-Cyril.Hoehle＠t-systems.com 01 Jul '09

01 Jul '09

Hi, http://bugs.winehq.org/show_bug.cgi?id=19028 winecfg on Mac OSX (10.5.6 and .7) does not link "My Videos" etc. to the equivalent directories on the Mac. Everything is linked to $HOME (or was it Desktop/?) instead. What a pity! Mac OSX uses directories named Documents/, Pictures/, Videos/, Music/ -- even in the German locale. The Finder GUI provides localized names. Unlike XDG/Gnome there are no crazy hacks at session begin to rename directories based on the session's locale. I don't know how earlier releases of Mac OSX behave, i.e. whether these directories have always been present. Does anyone know a reference? I located the relevant places that would need a patch: dlls/shell32/shellpath.c:_SHCreateSymbolicLinks and possibly dlls/shell32/xdg.c:XDG_UserDirLookup However, some design issues are unclear to me, hence prevent me from writing a patch: - In what order to add the Mac check? - When to check for a folder named "My Documents" (MS-Windows non-localized name in English locale, possibly translated), and when for "Documents" (MacOS constant name)? - Use XDG on the Mac or not? (if linked in, e.g. possibly when compiled via MacPorts, which pulls in a zillion libraries. Apple does not provide libfreedesktop.) Thanks for your comments, Jörg Höhle

3 2

Re: msctf: fully clear the Variant before setting it.
by Huw Davies 01 Jul '09

01 Jul '09

On Wed, Jul 01, 2009 at 10:29:22AM -0500, Aric Stewart wrote: > diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c > index 3afcfda..e1c7187 100644 > --- a/dlls/msctf/compartmentmgr.c > +++ b/dlls/msctf/compartmentmgr.c > @@ -537,6 +537,7 @@ static HRESULT WINAPI Compartment_GetValue(ITfCompartment *iface, > if (!pvarValue) > return E_INVALIDARG; > > + memset(pvarValue,0,sizeof(VARIANT)); > pvarValue->n1.n2.vt = VT_EMPTY; > if (!This->variant.n1.n2.vt == VT_EMPTY) > hr = VariantCopy(pvarValue,&This->variant); > This looks wrong; there's something strange going on here. Note also there's VariantInit() which is a cleaner way to set vt to VT_EMPTY. Huw.

1 0

Re: regedit: Open last key at startup
by Alexandre Julliard 01 Jul '09

01 Jul '09

Vladimir Pankratov <scriptkid(a)mail.ru> writes: > Hi all. > > Open last key at startup. Don't resend the same patch every single day, that will only get you ignored. Instead, spend some more time looking at your patch and I'm sure you can figure out why it's not going to work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Alexandre Julliard 01 Jul '09

01 Jul '09

Brent Roman <brent(a)mbari.org> writes: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. You reformatted the whole function, don't do that. Also please add a test case. -- Alexandre Julliard julliard(a)winehq.org

1 0

regression: loader: Reserve some more memory to cover the native ole32 addresses.
by Markus Amsler 01 Jul '09

01 Jul '09

commit 8d833ee2e7a1d8b82e2dccf51e0cbc20742a0833 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 25 14:19:09 2009 +0200 loader: Reserve some more memory to cover the native ole32 addresses. After this commit WoW with mesa/r500 falls back to indirect rendering. libGL tries to mmap 256M for the framebuffer but that fails with > libGL error: drmMap of framebuffer failed (Cannot allocate memory) Markus

1 0

Standard dialogs size & translation
by Frédéric Delanoy 01 Jul '09

01 Jul '09

Hi, I'm currently updating/fixing the (French translation of the) commdlg32 dialogs. There is a warning in cdlg_XX.rc saying "WARNING: DO NOT CHANGE THE SIZE OF THE STANDARD DIALOG TEMPLATES" However, e.g. in the standard "File Open" dialog, the standard size of some labels (e.g. "File name") is too small for a correct translation, and only the start of the message is shown (which is obviously wrong). I could manage to get correct translated version by modifying "internal" sizes (while keeping the total size of the dialog the same). Does the warning only apply to all localized versions, or just for the English one? What are the potential problems if a dialog is slightly adapted to fit a particular language? Frédéric

2 1

Re: [2/2] mlang: Add a test for IMultiLanguage2_IsCodePageInstallable.
by Paul Vriens 01 Jul '09

01 Jul '09

Hans Leidekker wrote: > Passes on win2k3, vista and the win7 release candidate. > Hi Hans, These are the results on Win95: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 864: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1361: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10017: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10082: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20001: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20932: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20949: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 50227: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 50229: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 54936: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 win98: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10000: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20261: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 NT4: mlang.c:2002: Test failed: 37: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 500: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 855: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 858: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 860: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 861: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 863: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 865: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 10079: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20127: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 28605: expected S_OK, got 0x80070057 mlang.c:1997: Test failed: 29001: expected S_FALSE or S_OK, got 0x80070057 mlang.c:2002: Test failed: 57002: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57003: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57004: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57005: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57006: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57007: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57008: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57009: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57010: expected S_OK, got 0x80070057 mlang.c:2002: Test failed: 57011: expected S_OK, got 0x80070057 W2K: mlang.c:2002: Test failed: 855: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 XP: mlang.c:2002: Test failed: 858: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 870: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1047: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1140: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1141: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1142: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1143: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1144: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1145: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1146: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1147: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1148: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 1149: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20105: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20106: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20107: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20108: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20269: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20273: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20277: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20278: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20280: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20284: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20285: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20297: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20423: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20871: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20880: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20905: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 20924: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21025: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 21027: expected S_OK, got 0x00000001 mlang.c:2002: Test failed: 28593: expected S_OK, got 0x00000001 Would using IsValidCodePage() be helpful here? -- Cheers, Paul.

3 7

Re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Paul Vriens 01 Jul '09

01 Jul '09

Brent Roman wrote: > Originally submitted on 6/14/09. > Resubmitted after comments on this bug: > > http://bugs.winehq.org/show_bug.cgi?id=19134 > > The attached patch against the master branch (as of today) fixes what > appears to be a long standing bug in Wine's > GetSystemMenu function in User32.dll.so. > > GetSystemMenu() is always supposed to return a valid HMENU handle, but > the logic in Wine's version would return nil in some cases where windows > would return an HMENU. Specifically, when the relevant windows dwStyle > mask did not include WS_SYSMENU, wine would return nil, but windows > would still return a valid HMENU. > > To reproduce the bug: > > 1. Download and install the Quadravox AQ430 development tools from: > http://www.quadravox.com/AQ430.htm > http://appdb.winehq.org/objectManager.php?sClass=application&iId=9939 > > 2. Attempt to compile any 'C' source file. > > Before applying the patch, all such attempts will quickly fail with an > invalid read from address 0x4. > > After applying the patch, compilations complete without (internal) > errors. It is allow possible to download binaries to > the microcontroller via the TI Flash Emulator Tool under linux > as this hardware appears to the linux kernel 2.6.30 as a serial > port. (Yea!) > > I've been using the app heavily for a couple days now without problems. > In fact, it runs faster and uses much less memory under Wine than > Win4Lin or VMplayer! Very nice. > > I do not subscribe to this list, so please email me directly if you have > any questions or concerns. > > - brent > > mailto:brent@mbari.org http://www.mbari.org/~brent > > > > ------------------------------------------------------------------------ > > Hi Brent, No comments on the real content of the patch other than you most likely will need to write one or more testcases to show your patch is correct. Please stick to the indentation and style of the file (surrounding code): - 4 space indentation instead of 2 space - curly brackets on separate lines - there are some tabs in this piece of the code, while you're at it you could change it to use 4 spaces instead. -- Cheers, Paul.

1 0

Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Andrew Eikum 01 Jul '09

01 Jul '09

Attached to this email is a rough implementation of the main GDI+ containers functions. It performs correctly in a few simple tests I ran on it, but it's not quite ready to send off to wine-patches. I'd like to get some feedback here, since I'm certain that I'm doing some things wrong. I'm wondering about two things specifically. Since the vast majority of my programming experience has been with object oriented languages, I'm not used to how to do things in C. First, where should the utility functions and variables go? Right now, they're just thrown in above the functions I'm working on. It seems messy to me to have, for example, low and high (which need to be renamed) declared where they are. Do they belong there (or, rather, near the top of graphics.c like some other utility functions), or should they be placed elsewhere? Second, I implemented a simple linked list to manage the stack of GpGraphics objects. I would imagine that there's some standard way of doing stacks, rather than creating a simple one with utility functions as I have here. Can someone point me in the direction of the proper way to do stacks like this in C? Finally, while the code's still rough and needs cleaning up, correctness checking, using Windows types and const properly, etc., am I doing anything glaringly wrong? As I mentioned, it works as expected in the tests I've done, so I can't be too far off the mark :) Thanks for taking a look, Andrew Patch attached. Also available at: http://www.brightnightgames.com/wine/gdipcontainers.patch --- dlls/gdiplus/graphics.c | 125 ++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 119 insertions(+), 6 deletions(-)

3 2

re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer
by Dan Kegel 01 Jul '09

01 Jul '09

Andrew asked: > I would imagine that there's some standard way of doing stacks See http://source.winehq.org/source/include/wine/list.h > Finally, while the code's still rough and needs cleaning up, > correctness checking, using Windows types and const properly, etc., am > I doing anything glaringly wrong? You didn't start by writing conformance tests, perhaps. - Dan

1 0

Re: [3/7] [wined3d] add NP2 fixup code to shader_arb_generate_pshader (resend)
by Stefan Dösinger 30 Jun '09

30 Jun '09

Am Monday 29 June 2009 21:41:58 schrieb Tobias Jakobi: + const UINT max_lconsts = gl_info->ps_arb_max_local_constants; Please use the GL_LIMITS macro for consistency

2 1

Re: [4/7] [wined3d] add NP2 fixup code to shader_hw_sample (ARB) (resend)
by Stefan Dösinger 30 Jun '09

30 Jun '09

Am Monday 29 June 2009 21:42:20 schrieb Tobias Jakobi: > + if (flags) FIXME("Only ordinary sampling from NP2 textures is supported.\n"); Why does projected sampling not work? Is this a limit of Tex_rect or the NP2 fixup code? TXB certainly does not work because tex_rect doesn't support mipmapping Its fine with me if projected texturing is just not implemented in this patchset currently, I'm just curious. If it is not a GL limit it should just work with the code you wrote, unless I am missing something.

2 1

Re: [2/7] [wined3d] add arb_ps_np2fixup_info structure (resend)
by Stefan Dösinger 30 Jun '09

30 Jun '09

Am Monday 29 June 2009 21:41:33 schrieb Tobias Jakobi: Is there a particular reason why you reordered many elements in struct arb_ps_np2fixup_info?

3 2

Re: server/fd.c: Prevent using uninitialized pointers
by Matteo Bruni 30 Jun '09

30 Jun '09

I'm quite sure that C standards guarantee global variables are initialized to 0. 2009/6/30 Daniel Santos <javatroubadour(a)yahoo.com>: > Some pointers are getting used prior to initialization. It would appear that the current compilers are initializing them to zero or we've been lucky. > > > > > >

1 0

Fw: Re: Removing active maintainers
by James Mckenzie 30 Jun '09

30 Jun '09

Sent to Rosanne only, meant to send it to the list as a comment to this thread. James McKenzie -----Forwarded Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: Jun 29, 2009 6:36 PM >To: Rosanne DiMesio <dimesio(a)earthlink.net> >Subject: Re: Removing active maintainers > >Rosanne DiMesio <dimesio(a)earthlink.net> Subject: Re: Removing active maintainers >> >>On Mon, 29 Jun 2009 14:56:23 +0200 >>Remco <remco47(a)gmail.com> wrote: >> >>> On Mon, Jun 29, 2009 at 2:22 PM, Rosanne DiMesio<dimesio(a)earthlink.net> wrote: >>> > That would still leave the test results sitting there unprocessed for weeks, which leaves a pretty bad impression on the users who submitted them. Test results for apps without maintainers get processed by the admins within 24 hours. >>> >>> How about mailing admins after 24 hours? Maintainers are useful to >>> offload tasks of admins. If they are away for a while, admins just get >>> the mail as if there were no maintainer. If you have to remove a >>> maintainer every time he can't respond in 24 hours, you won't have >>> many left after a while. >>> >>> Remco >> >>Nobody's suggesting a 24 hour time limit for maintainers. >> >>As for emailing the admins, I know I turned off emails from the AppDB to avoid having my mailbox overwhelmed with hundreds of useless notices every day, >>and I doubt I'm the only one who did this. http://bugs.winehq.org/show_bug.cgi?id=14755 needs to be fixed first for any solution that involves emailing >>admins to be viable. > >I see several good ideas here: > >1. Maintainers should be able to mark themselves as not available. No reason should be required. >2. Admins should have the ability to suspend a maintainer for non-response. There are several reasons for not responding and most of them would be considered an emergency. >3. Any maintainer who fails, after three suspensions, to properly carry out the functions of being a maintainer, should be banned for a specific period of time, increases to a complete ban. >4. What maintainers have to do to maintain their status should be posted on the Maintainers page when you sign up and a reminder message every 90 days or so should be sent out to keep maintainers honest. >5. Maintainers should be given the option of gracefully resigning when they no longer can perform the duties of their position. > >James McKenzie > >> >>-- >>Rosanne DiMesio <dimesio(a)earthlink.net> >> >>

2 1

Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree
by Detlef Riekenberg 30 Jun '09

30 Jun '09

On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: > With this patch, they are treated like other programs, e.g., winhlp32, > and installed, so one can use: > $ wine view > and get the same effect. That parts of configure.ac are created by tools/make_makefiles tools/make_makefiles-50-# Programs that we don't want to install at all tools/make_makefiles-51-my %dont_install = tools/make_makefiles-52-( tools/make_makefiles:53: "cmdlgtst" => 1, tools/make_makefiles-54- "view" => 1, tools/make_makefiles-55- "winetest" => 1, tools/make_makefiles-56-); -- By by ... Detlef

3 3

Re: oleaut32: Build language resource files separately
by Michael Stefaniuc 30 Jun '09

30 Jun '09

Hello Nikolay, Nikolay Sivov wrote: > Michael Stefaniuc wrote: >> instead of including them from an other rc file. >> --- >> > What is the purpose of these changes? I'm not talking it's wring :), > just interested. Well, Alexandre did the first patch for programs/clock http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342… so it must be right ;). It increases the resilience as errors in one language rc file do not propagate to the other languages. There might be some other reason but I forgot. Alexandre asked me if I could do it as it is an easy search and replace style janitorial job. bye michael

4 5

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.
by Paul Vriens 30 Jun '09

30 Jun '09

Huw Davies wrote: > --- > dlls/gdi32/tests/metafile.c | 80 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 80 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, Could you use CreateEnhMetaFileA here: + SetRect(&rc, 1000,2000, 3000, 6000); + emf_dc = CreateEnhMetaFileW(display_dc, NULL, &rc, NULL); The W-version is not implemented on Win9x so this test would crash. -- Cheers, Paul.

2 1

Removing active maintainers
by Joerg-Cyril.Hoehle＠t-systems.com 30 Jun '09

30 Jun '09

Hi, so far I found that Remco made the best suggestions. >From a quality of service point of view, unmaintained apps provide a more pleasing experience to the test data submiter: data is generally accepted within a fraction of a day. Not so for maintained apps. Why? Simple: there's a (large?) pool of general admins, so response time is low. OTOH, what response time can you expect from a single maintainer? My suggestion variant is: Delegate submissions after no more than 3 days from the maintainer to the general pool. Or what Remco suggested: accept by default pool, still notify maintainers so they can edit it afterwards. Easy to understand; easy to implement; best response time. Why look elsewhere? Find something else for removing people who volunteered(!) to maintain something. E.g. I'll be on vacation for 3 weeks, I'll never leave a ~/.vacation to please spammers, so I find the "8day response or be kicked" pretty tough. Regards, Jörg Höhle

1 0

Re: gdiplus: implement horizontal alignment in GdipDrawString
by Vincent Povirk 29 Jun '09

29 Jun '09

Whoops, forgot to check that format is not NULL. Don't commit this. Vincent Povirk On Mon, Jun 29, 2009 at 4:39 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > > > >

1 0

Remove FIXME keyword from bugzilla
by Austin English 29 Jun '09

29 Jun '09

It serves no purpose, after all, 'FIXME's are not bugs'. -- -Austin

2 1

Re: appwiz.cpl: updated French translation
by Paul Vriens 29 Jun '09

29 Jun '09

Frédéric Delanoy wrote: > Some adaptation to English dialog too: "Add/Remove" button was renamed to "Remove", since its only purpose is to uninstall apps. > > > ------------------------------------------------------------------------ > > Hi Frédéric But the message clear says "or to modify its installed components". So I guess a more appropriate text on the button would be "Modify/Remove" (or something alike). -- Cheers, Paul.

4 5

A new kid
by MD.IMAM HOSSAIN 29 Jun '09

29 Jun '09

Dear WINE Developers, A short biography of me: A University Student of Electrical & Electronics Engineering Department. Live in Bangladesh in the city of Chittagong. I am a moderate Linux User, A moderate C programmer and have little knowledge about C++ programming. I wish to contribute to the WINE Project. What I could do for it. Please, give me a path. Best regard, MD. IMAM HOSSAIN

3 2

shdocvw: would it be allright to pretend succes in IWebBrowser2::Stop?
by Louis. Lenders 29 Jun '09

29 Jun '09

Hi, i try run an app that bails out because WebBrowser_Stop returns E_NOTIMPL. Just like another app i already filed a bug for (http://bugs.winehq.org/show_bug.cgi?id=9895) it expects ERROR_SUCCESS. According to MSDN this function "Cancels a pending navigation or download, and stops dynamic page elements, such as background sounds and animations". My question is, would it be ok to just pretend ERROR_SUCCESS (as i think now), or would there be any unwanted side effects for other apps that use this function,and do we have to wait for a real implementation (maybe Jacek has a clue?) Regards Louis

1 0

re: Removing active maintainers
by Dan Kegel 29 Jun '09

29 Jun '09

A few comments: 1. I agree that it is useful to remove obsolete, uninformative comments in the appdb. (You have to be careful to leave the old informative ones, though; if somebody has a great workaround or bug that might still be useful, don't delete it.) 2. The wiki is not the place for appdb-like stuff; duplication of information silos is generally a bad idea. Yes, I created a few wiki pages for Adobe apps, but that was a temporary hack, and the appdb provides almost enough flexibility. (What's missing is the ability to add howto's and notes at the application level, i.e. one level higher than the version level where they all go right now, but that's not usually a dealbreaker.) 3. Eight days is way too quick to remove an inactive maintainer. Six months is more like it. 4. The Wine community has some abrasive characters in it. Periodically we have to ask some of them to chill out. Everyone who is very active should take care that they don't get too curt with other developers or with users. A basic level of courtesy shouldn't be too hard. Dogfights where two maintainers are asking to have each other thrown out are a good sign that both of said developers need to chill. 'Nuff said. - Dan

8 12

Re: transl: fix score-counter
by Michael Stefaniuc 29 Jun '09

29 Jun '09

André Hentschel wrote: > If e.g. 4 langs are on score 1, then next score entry is 5. > This corrects the counter, so that next score is 2 I wouldn't count that as a bug but as a matter of taste. I prefer the way it is now. There are 4 other languages before the respective language so it comes in only 5th. And changes to one of the 4 languages before it won't make the score of the language change. > --- > transl/php/index.php | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) bye michael

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel