- wine-devel - winehq.org

Re: transl: fix score-counter
by Ricardo Filipe 29 Jun '09

29 Jun '09

2009/6/29 André Hentschel <nerv(a)dawncrow.de> > If e.g. 4 langs are on score 1, then next score entry is 5. > This corrects the counter, so that next score is 2 > --- > transl/php/index.php | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > the score right now gives a count of the number of languages on that step. it's more useful than giving the order score because that we can infer by the position on the list visually, IMHO.

2 1

Re: Removing active maintainers
by Remco 29 Jun '09

29 Jun '09

On Mon, Jun 29, 2009 at 4:18 PM, Rosanne DiMesio<dimesio(a)earthlink.net> wrote: > On Mon, 29 Jun 2009 15:48:17 +0200 > Remco <remco47(a)gmail.com> wrote: >> >> Ok, I thought everybody got their AppDB updates by mail. But whichever >> way you receive notice of queued submissions without maintainers, >> that's where the maintained submissions can be sent after 24 hours. >> >> Remco > > Admins can already see all test reports in the queue. That's not the issue. The issue is removing maintainers who aren't doing their job. If we do their job for them, with no consequences to the negligent maintainer, that merely covers up the problem. So the issue is not that queued submissions aren't handled, but... what? I thought the problem was unhandled submissions, caused by negligent maintainers. But if that problem is not there, what problem are negligent maintainers causing? Remco

2 1

Re: [4/4] comctl32/rebar: Update Rebar structure
by Paul Vriens 29 Jun '09

29 Jun '09

Nikolay Sivov wrote: > Changelog: > - Update Rebar structure > >>From b0d8b14a60f391144077cf8c053df5ea36fd22c4 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Sun, 28 Jun 2009 03:40:20 +0400 > Subject: Update Rebar structure > > --- > include/commctrl.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/include/commctrl.h b/include/commctrl.h > index 2c887d0..beecb52 100644 > --- a/include/commctrl.h > +++ b/include/commctrl.h > @@ -1988,6 +1988,9 @@ typedef struct tagREBARBANDINFOA > UINT cxIdeal; > LPARAM lParam; > UINT cxHeader; > + /* _WIN32_WINNT >= 0x0600 */ > + RECT rcChevronLocation; > + UINT uChevronState; > } REBARBANDINFOA, *LPREBARBANDINFOA; > > typedef REBARBANDINFOA const *LPCREBARBANDINFOA; > @@ -2014,6 +2017,9 @@ typedef struct tagREBARBANDINFOW > UINT cxIdeal; > LPARAM lParam; > UINT cxHeader; > + /* _WIN32_WINNT >= 0x0600 */ > + RECT rcChevronLocation; > + UINT uChevronState; > } REBARBANDINFOW, *LPREBARBANDINFOW; > > typedef REBARBANDINFOW const *LPCREBARBANDINFOW; Hi Nikolay, Looks like this introduces test failures on everything below Vista. Could you check? -- Cheers, Paul.

1 0

Re: [PATCH 1/2] Include: Add fil_data.idl to describe IAMFilterData interface (resend)
by Alexandre Julliard 29 Jun '09

29 Jun '09

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > @@ -29,6 +29,7 @@ PUBLIC_IDL_H_SRCS = \ > dxgi.idl \ > dxgitype.idl \ > exdisp.idl \ > + fil_data.idl \ This file doesn't seem to be part of the SDK. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/2] makedep: Add support for multiple object file extensions.
by Alexandre Julliard 29 Jun '09

29 Jun '09

Francois Gouget <fgouget(a)free.fr> writes: > This is useful to generate dependencies for crossbuilds. -o is traditionally used for the output file, so something like -x would probably be preferable. Also specifying multiple extensions by repeating the option (-xfoo -xbar instead of -xfoo:bar) is probably nicer, especially for usage in makefiles. -- Alexandre Julliard julliard(a)winehq.org

1 0

Anyone at LinuxTag?
by Dan Kegel 29 Jun '09

29 Jun '09

According to http://www.heise.de/newsticker/Bund-foerdert-Open-Source-Projekte--/meldung… Germany's going to put 20 million euros into open source. They'll probably throw it all down a rathole, but hey, maybe some small fraction will go to useful projects. If anyone's at LinuxTag, maybe it would be worth wandering over to Halle 7.2a, Stand 111 and chat the projects up to see if any of them have any interest in Wine...

6 12

Direct3D Shader
by MD.IMAM HOSSAIN 29 Jun '09

29 Jun '09

Dear Developers, Is there any possibilities to use nVidia Cg Library for Wine's Direct3D pixel and vertex shader. It will help Linux Intel On Board Graphics Card owners. Because nVidia's Cg support all graphics card. best regards, MD. IMAM HOSSAIN

1 0

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte
by Dmitry Timoshkov 29 Jun '09

29 Jun '09

"Christoph von Wittich" <Christoph(a)ApiViewer.de> wrote: > When you would have a look at the winetests you would have noticed two > failures about passing in negative values... Which winetests should I look at? The WideCharToMultiByte ones? Then the patch is wrong. That's unusual to expect that somebody reads your mind. -- Dmitry.

1 0

Re: user32: GetTitleBarInfo: Handle hwnd and tbi when passing NULL (try 3)
by Frédéric Delanoy 29 Jun '09

29 Jun '09

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo <...> > > Andras Kovacs Not so problematic, but you can simplify 'if (IsWindow(hwnd) == FALSE)' with 'if (! IsWindow(hwnd))' Frédéric

1 0

XI2 DirectInput/RawInput/WH_*_LL hooks
by Paul TBBle Hampson 28 Jun '09

28 Jun '09

I've been thinking about the XI2 a fair bit since the last time we discussed it on the mailing list, and a few things have come to mind, which I think need sanity checking before I explore any harder. I'm assuming we want one X11 connection turning XI2 events into WH_*_LL events, RawInput events, and DirectInput events, simply because WH_*_LL events are actually sent out by wineserver to all processes, so we only want one of those per XI2 event. This leads me to retaining the current WH_*_LL-based implementation of DI, but with cursor management and control (ie all the stuff Exclusive mode brings to the table) handling via a graphics driver hook or similar. However, the mechanism for feeding the XI2 events to the wineserver as WH_*_LL events is a little tricky. XI2 events need their own thread and hence X connection, as we cannot rely on a WinMain loop hitting X11DRV_MsgWaitForMultipleObjectsEx in a timely manner, or in fact all. The three possibilities I see are: *) Most recent foreground application catches XI2 events in its own spawned thread. Need to elect a replacement on process exit. Easiest to co-ordinate with non-XI2 hook-feeding code. *) Wineserver gains an X11 connection, for XI2 use only. This is generally bad, only here for completeness. *) A new process (ala services.exe) which grabs XI2 events from X11 via its own connection and feeds them to the wineserver. I'm inclined to think the latter one is the best option of the three, and it requires simply that the winex11.drv detect XI2 presence and if found, it disable its own WH_*_LL feeding code and spawn the XI2 process if it is not already running. It avoids the complicated coordination dance you would need for the first option to avoid losing messages. Mind you, I've been thinking this away from the codebase, so it's mostly mindwork right now. But unless I get any better suggestions or criticism, I'll prolly knock up a sample implementation of the third option next time I play with this, and see if I can get the DI keyboard interface implemented. -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Marcus Brigstocke http://www.marcusbrigstocke.com/pacman.asp License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

4 4

Re: [2/2] GetTitleBarInfo tests for NULL values
by Nikolay Sivov 28 Jun '09

28 Jun '09

Kovács András wrote: > Hi, > > GetTitleBarInfo tests for NULL values. > > > Best Regards, > > Kovács András > What about this one: --- ret = GetTitleBarInfo(NULL, NULL); --- What error code will come first?

1 0

Re: [1/2] Handle hwnd and tbi when passing NULL
by Nikolay Sivov 28 Jun '09

28 Jun '09

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs > --- TRACE("(%p %p)\n", hwnd, tbi); .... + TRACE("tbi is NULL.\n"); --- That's a duplication you don't really need. This one isn't very useful too: --- + TRACE("Invalid hwnd.\n"); ---

1 0

Re: [1/2] Handle hwnd and tbi when passing NULL
by Austin English 28 Jun '09

28 Jun '09

2009/6/28 Kovács András <andras(a)csevego.net>: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs Not a big deal, but in the future, please add the component at the beginning of your e-mail's subject, e.g.: user32: Handle hwnd and tbi when passing NULL in GetTitleBarInfo it's much easier to know what the purpose of the patch is without reading it that way (for those people that only read certain sections of the code). -- -Austin

1 0

Re: [1/1] Handle hwnd and tbi when passing NULL
by Nikolay Sivov 28 Jun '09

28 Jun '09

Kovács András wrote: > Hi, > > This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti > parameter. > GTA IV tries to use this function with NULL, NULL parameters. > This doesn't hurt Windows, but crashes in wine. > Tested against Windows 7. > > Best Regards, > > Andras Kovacs > I think IsWindow() will be enough here. Also add tests for that please.

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > Il giorno dom, 28/06/2009 alle 17.43 +0400, Nikolay Sivov ha scritto: > >> Davide Pizzetti wrote: >> >>> I've got another question: i've created some new files and translated >>> them into italian. How can i submit them as a patch? I made a git diff >>> but these files i created don't appear there >>> >>> >> As I told you. Do 'git add <new file path relative to tree>'. This will >> add it to your local repo. >> >> > i used 'git add' but i can't understand how i can submit the new files > as a patch, since i get only a diff for the list of the current > languages > Do 'git commit -a' and 'git format-patch' will do what you want after that.

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > I've got another question: i've created some new files and translated > them into italian. How can i submit them as a patch? I made a git diff > but these files i created don't appear there > As I told you. Do 'git add <new file path relative to tree>'. This will add it to your local repo.

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > Il giorno dom, 28/06/2009 alle 16.39 +0400, Nikolay Sivov ha scritto: > >> Davide Pizzetti wrote: >> >>> i think i made a little mess with the files for winedbg. how do i >>> restore the situation to the previous state? >>> Il giorno dom, 28/06/2009 alle 16.14 +0400, Nikolay Sivov ha scritto: >>> >>> >>>> Davide Pizzetti wrote: >>>> >>>> >>>>> Here's the italian translation for winedbg >>>>> >>>>> >>>>> >>>> Hi, Davide. >>>> >>>> This patch is malformed too. >>>> >>>> When you need to create new file in repo, first create it in your file >>>> system, then do 'git add programs/winedbg/rsrc_It.rc' . >>>> This will add it to your repo. Don't forget to edit rsrc.rc file too to >>>> add your new created resource file. >>>> >>>> Bye. >>>> >>>> >> Save your edited files somewhere outside tree to keep your work. After >> that do 'git reset --hard origin' >> this will reset your tree head to point of last 'git fetch' update. >> >> After that proceed as described (add new file, put translation in it, etc). >> >> > > Ok, thank you. For restoring the completed works i just overwrite the > files, right? > Yeah, just paste it into new created file.

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > Another question: when i create a new language translation file, i have > to copy the english file into a new file and translate it? > > Il giorno dom, 28/06/2009 alle 16.14 +0400, Nikolay Sivov ha scritto: > >> Davide Pizzetti wrote: >> >>> Here's the italian translation for winedbg >>> >>> >> Hi, Davide. >> >> This patch is malformed too. >> >> When you need to create new file in repo, first create it in your file >> system, then do 'git add programs/winedbg/rsrc_It.rc' . >> This will add it to your repo. Don't forget to edit rsrc.rc file too to >> add your new created resource file. >> >> Bye. >> Yes, cause only english resources are complete - that's the only reason why you should sync with it.

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > i think i made a little mess with the files for winedbg. how do i > restore the situation to the previous state? > Il giorno dom, 28/06/2009 alle 16.14 +0400, Nikolay Sivov ha scritto: > >> Davide Pizzetti wrote: >> >>> Here's the italian translation for winedbg >>> >>> >> Hi, Davide. >> >> This patch is malformed too. >> >> When you need to create new file in repo, first create it in your file >> system, then do 'git add programs/winedbg/rsrc_It.rc' . >> This will add it to your repo. Don't forget to edit rsrc.rc file too to >> add your new created resource file. >> >> Bye. >> Save your edited files somewhere outside tree to keep your work. After that do 'git reset --hard origin' this will reset your tree head to point of last 'git fetch' update. After that proceed as described (add new file, put translation in it, etc).

1 0

Re: winedbg italian translation
by Nikolay Sivov 28 Jun '09

28 Jun '09

Davide Pizzetti wrote: > Here's the italian translation for winedbg > Hi, Davide. This patch is malformed too. When you need to create new file in repo, first create it in your file system, then do 'git add programs/winedbg/rsrc_It.rc' . This will add it to your repo. Don't forget to edit rsrc.rc file too to add your new created resource file. Bye.

1 0

Re: [5/6] WineD3D: Write the vshader footer in a separate function
by Ivan Gyurdiev 27 Jun '09

27 Jun '09

> Re: [5/6] WineD3D: Write the vshader footer in a separate function I like this patch - would be great to have more of these: Lines that fit on the screen in my gnome-terminal: < 50 Average size of six large ARB shader functions, before this patch: 205 (generate pshader, vshader, handle_ins, arb_declarations, init_output_register, gen_arbfp_ffp...) A couple of other shader questions/suggestions, not related to the patch: - The "handle_instruction" code seems to be moving away from the design to handle each instruction separately into its own handler - is this really necessary? Does it make sense to create a "loop" intermediate representation in baseshader if the ARB backend needs it to better handle loops? - There are some elaborate bitfields to track which instructions are called in baseshader.c. Does it make sense to have a more formal framework, where all instructions are tracked or maybe each backend requests which instructions it is interested to track? Ivan

1 0

Re: [4/6] WineD3D: Implement function calls with NV exts
by Henri Verbeet 27 Jun '09

27 Jun '09

2009/6/27 Stefan Dösinger <stefan(a)codeweavers.com>: > - || ins.handler_idx == WINED3DSIH_PHASE > - || ins.handler_idx == WINED3DSIH_RET) > + || ins.handler_idx == WINED3DSIH_PHASE) Did you test this change with GLSL?

2 2

re: Removing active maintainers
by Susan Cragin 27 Jun '09

27 Jun '09

>A basic level of courtesy shouldn't be too hard. >Dogfights where two maintainers are asking to have each other thrown >out are a good sign that both of said developers need to chill. We need more women. Susan

2 1

Fixing EOL in logging messages
by Frédéric Delanoy 27 Jun '09

27 Jun '09

Hi, I'm intending to fix some non-\n-terminated strings for different logging classes (MESSAGE, TRACE, ...) For each class, should I send (1) a patch for *each* affected module or (2) just a "generic" one ? Solution (1) seems a bit like overkill for me... Frédéric

2 1

Appinstall caught a (fixed) bug
by Austin English 27 Jun '09

27 Jun '09

Whlie checking logs today, I noticed something interesting: All tests passed builtin-gui-result.txt:Error window didn't appear. Bug 19081 fixed. TODO_FIXED. builtin-gui-result.txt:Error window didn't appear. Bug 19081 fixed. TODO_FIXED. kmeleon-152-result.txt:k-meleon.exe didn't crash. Bug 17524 TODO_FIXED. nestopia-result.txt:nestopia.exe didn't crash. Bug 19609 TODO_FIXED. Some TODO_FIXED...investigate! From:http://austinenglish.com/logs/appinstall-2009-06-26/summary.txt The builtin-gui stuff is a red herring (I need to adjust the test). The nestopia test was a real bug (http://bugs.winehq.org/show_bug.cgi?id=19069) that I added a testcase for to make sure appinstall would catch it/it doesn't break later on. The kmeleon-152 result, however, wasn't expected...apparently something in today's git fixed it (I ran it manually as well, and it's working fine). Now I need to get busy and add more tests... -- -Austin

1 0

Re: Removing active maintainers
by Susan Cragin 27 Jun '09

27 Jun '09

>> Version 9 should be entirely deleted. That refers to the early 9.0 Preferred >> release, which is not available any more. 9.0 Preferred has been replaced by >> 9.5 Preferred, which is garbage like Standard. We should not have people >> buying DNS 9 Preferred and thinking it is installable when it is not. > >Versions should not be deleted, especially not for programs sold on actual disks. A user may dig up an old copy somewhere and wonder >whether it would work. If the version is deleted, he/she will not know and/or may recreate the page with his results. > >Gert OK, but Version 9 should be re-numbered to 9.0 Preferred, with a note that version was superseded by 9.5, and new copies purchased will most likely be 9.5.

2 1

wine 1.1.23 configure message Mac OSX 10.5.7
by Maurits Lamers 27 Jun '09

27 Jun '09

Hi, while running configure of wine 1.1.23 on Mac OSX Leopard 10.5.7 the message below appeared with a request to mail it. Running XCode 3.1.2, i686-apple-darwin9-gcc-4.0.1. Please feel free to contact me if you need any extra information. greets Maurits ==== checking mach-o/dyld_images.h usability... no checking mach-o/dyld_images.h presence... yes configure: WARNING: mach-o/dyld_images.h: present but cannot be compiled configure: WARNING: mach-o/dyld_images.h: check for missing prerequisite headers? configure: WARNING: mach-o/dyld_images.h: see the Autoconf documentation configure: WARNING: mach-o/dyld_images.h: section "Present But Cannot Be Compiled" configure: WARNING: mach-o/dyld_images.h: proceeding with the preprocessor's result configure: WARNING: mach-o/dyld_images.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ##

3 3

Regression on OS X, may not be able to load dll
by Gellule Xg 26 Jun '09

26 Jun '09

Hi, (wine, almost latest git, on OS X) Trying to test the latest changes on the loader memory management with Ryzom (which I had some OpenGL related out of memory issues), I stumbled on the following: "wine client_ryzom_rd.exe" crashes with: DBG 9 dynloadlib.cpp 211 NLMISC::CLibrary::loadLibrary client_ryzom_rd.exe : Loading dynamic library 'nel_drv_opengl_win_r.dll' dyld: lazy symbol binding failed: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine dyld: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine WRN 9 dynloadlib.cpp 45 NLMISC::nlLoadLibrary client_ryzom_rd.exe : Load library 'nel_drv_opengl_win_r.dll' failed: ???????? WRN 9 dynloadlib.cpp 222 NLMISC::CLibrary::loadLibrary client_ryzom_rd.exe : Loading library nel_drv_opengl_win_r.dll failed: Verify DLL existence The application cannot load the native library 'nel_drv_opengl_win_r.dll'. winecfg also exhibits these two lines (at first launch, creating the .wine directory), but without crashing: dyld: lazy symbol binding failed: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine dyld: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine I checked out a few revisions and narrowed down the issue to be between: "kernel32: Add call frame annotations in x86 assembly code." (which works) and "loader: Reserve some more memory to cover the native ole32 addresses." (which does not). I'm ready to do some more testing if somebody could guide me. I could already start bisecting through: loader: Reserve some more memory to cover the native... ntdll: Release some address space after the process... ntdll: Don't try to decommit a heap past its initial... ntdll: Compute the free lists address at run-time inste... Best regards, -Gellule

1 0

Usage of wine-tests-results mailing list
by Frédéric Delanoy 26 Jun '09

26 Jun '09

Hi, looking at the different mailing lists of wine on http://www.winehq.org/mailman/listinfo, I found that wine-tests-results seems only filled with garbage (actually "[ERROR] winetest error report"). Has that list any use these days? Frédéric

1 0

Regression on OS X, may not be able to load native dll
by Gellule Xg 26 Jun '09

26 Jun '09

Hi, (wine, almost latest git, on OS X) Trying to test the latest changes on the loader memory management with Ryzom (which I had some OpenGL related out of memory issues), I stumbled on the following: "wine client_ryzom_rd.exe" crashes with the following. DBG 9 dynloadlib.cpp 211 NLMISC::CLibrary::loadLibrary client_ryzom_rd.exe : Loading dynamic library 'nel_drv_opengl_win_r.dll' dyld: lazy symbol binding failed: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine dyld: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine WRN 9 dynloadlib.cpp 45 NLMISC::nlLoadLibrary client_ryzom_rd.exe : Load library 'nel_drv_opengl_win_r.dll' failed: ???????? WRN 9 dynloadlib.cpp 222 NLMISC::CLibrary::loadLibrary client_ryzom_rd.exe : Loading library nel_drv_opengl_win_r.dll failed: Verify DLL existence The application cannot load the native library 'nel_drv_opengl_win_r.dll'. winecfg also exhibit these two lines, but without crashing: dyld: lazy symbol binding failed: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine dyld: lazy pointer not found at address 0x303d17af in image /opt/local/libexec/wine/wine I checked out a few revisions and narrowed down the issue to be between: "kernel32: Add call frame annotations in x86 assembly code." (which works) and "loader: Reserve some more memory to cover the native ole32 addresses." (which does not). I'm ready to do some more testing if somebody could guide me. I could already start bisecting through: loader: Reserve some more memory to cover the native... ntdll: Release some address space after the process... ntdll: Don't try to decommit a heap past its initial... ntdll: Compute the free lists address at run-time inste... Best regards, -Gellule

1 0

Removing active maintainers
by Vitaliy Margolen 26 Jun '09

26 Jun '09

Why did someone removed active maintainers from most active applications? Do you guys even care who active who not? I was the only one doing _anything_ on Steam AppDB entry. And I was removed by Ken Sharp because he didn't like 9 "oldish" posts??? WTH? This got to stop! If someone doesn't like old entries - well that's just too bad. Don't go to those apps, or fix AppDB to split comments into several pages. I'm appreciate what Ken was doing but not anymore. Please remove him from the admin role an AppDB. This is way over the head of what he's been doing. Vitaliy.

18 41

Strange issue with recv in Launchpad Enhanced
by Erich Hoover 26 Jun '09

26 Jun '09

I'm trying to track down an issue with Launchpad Enhanced were it fails to download its updates (Bug #17443). It appears that the issue stems from recv being called with a buffer from a different process, so as a result the call fails. I put together a hack that gets around the problem ( http://bugs.winehq.org/show_bug.cgi?id=17443#c2), but I'm having difficulty figuring out exactly why this is happening in the first place. Does anyone know if this is a known difference between Windows and Linux or if there is something else strange going on? Erich Hoover ehoover(a)mines.edu

2 5

Re: Removing active maintainers
by Susan Cragin 26 Jun '09

26 Jun '09

3 2

Re: clock: Reset default codepage in utf8 rc file
by Paul Chitescu 26 Jun '09

26 Jun '09

On Wednesday 24 June 2009 02:28:12 Frédéric Delanoy wrote: > clock: Reset default codepage in utf8 rc file > > In the Romanian resource file for the "clock" program, which is in utf-8 > format, the code page wasn't reset to the default code page at the end of > the file. Now that's weird... I just checked the patch I've sent to wine-patches and it had #pragma code_page(default) at the end. On the other hand the git commit didn't include it. What gives?

4 4

Re: user32/tests: Add more intensive tests for SetCursor.
by Daniel Santos 26 Jun '09

26 Jun '09

lol! I guess it's time for me to remove myself from the mailing lists I don't read anymore, I'm starting to miss replies! Anyway, I'm off for the weekend, but will rebase and re-send (with attachment) Monday or so. Thanks for the response Austin! Daniel --- On Tue, 6/9/09, Austin English <austinenglish(a)gmail.com> wrote: > From: Austin English <austinenglish(a)gmail.com> > Subject: Re: user32/tests: Add more intensive tests for SetCursor. > To: "Daniel Santos" <javatroubadour(a)yahoo.com> > Cc: "Wine Devel" <wine-devel(a)winehq.org> > Date: Tuesday, June 9, 2009, 5:15 PM > On Tue, Jun 9, 2009 at 5:13 PM, > Daniel Santos<javatroubadour(a)yahoo.com> > wrote: > > > > Hello! This is a prelude to other cursor patches to > follow (both Griswold's & my work). As requested, I > have replaced the __FILE_SPOT with the standard > ok_(file,line) mechanism (looks much better to me). I've > removed the windows version checking from tests and last > error checking on success, although I have reservations > about it (mostly the later). > > Forgot patch. > > > -- > -Austin >

1 0

As of Thursday's git, DNS runs for a bit longer.
by Susan Cragin 26 Jun '09

26 Jun '09

I have been timing Dragon NaturallySpeaking to see how fast it crashes. I start when I click on the program, and use it pretty steadily until it crashes. As of yesterday's git, it runs for about 15 minutes and 30 seconds. That's an improvement of two minutes over previous versions. :) Susan

1 0

Alpha Roadblocks
by Joel Holdsworth 26 Jun '09

26 Jun '09

Hi All, Some of you may have read some of my recent mails about my work to refresh the wine icons with Tango versions, as demonstrated in this screenshot: http://www.airwebreathe.org.uk/alpha-tango-icons.png Achieving this task isn't a simple icon replacement job, because of the inability of wine to handle the alpha channel correctly in two key areas: HICONS, and IImageLists. I've patched some of the problems, but others are roadblocked by shortcomings in x11.drv's BitBlt/StretchBlt which (usually) strip the alpha channel. This leaves me a bit stuck: AJ rightly won't accept any hacks or workabouts, which leaves me with the choice to give up (for the time being), or try and fix x11.drv myself. I'm pretty sure that fixing the blts would be a major job, but I thought I'd write and ask for some comments. Is it so hard as I think? Does anyone have any ideas what would be required? Thanks Joel

3 2

Re: [5/10] d3dx9: Implement D3DXLoadSurfaceFromSurface
by Tony Wasserka 26 Jun '09

26 Jun '09

> Watch out, some surfaces aren't lockable. I don't know the d3dx9 api too well, > but are you sure that you have a lockable surface here? > In some situations IDirect3DDevice9::UpdateSurface or > IDirect3DDevice9::StretchRect may be a faster way to achieve what this code > does(without colorkeying though). Hi, The function just fails with D3DXERR_INVALIDDATA if the surface is not lockable, just as D3DXLoadSurfaceFromMemory will when it's implemented. Of course UpdateSurface could be used, but as you said it doesn't support color keying (nor palettes I guess) or filtering and it only works in very specific cases (i.e. same dimensions, no color keying, no filtering), applications are more likely to do things like that on their own probably. D3DX has been created for the general case mostly, so optimizations like this would just make the code more complicated ;) Tony

1 0

oleaut32:usrmarshal tests on Win95
by Paul Vriens 26 Jun '09

26 Jun '09

Hi, I'm looking into the failures for the usrmarshal tests on Win95. The attached patch shows the differences between NT+ and Win95. I'm not able to pinpoint the correct way to fix these failures yet. Some other results: - older Win98 boxes behave the same as Win95 - newer Win98 boxes and WinME behave partly the same (need those '+4' every now and then) but crash later on Any ideas how to properly fix this? -- Cheers, Paul. diff --git a/dlls/oleaut32/tests/usrmarshal.c b/dlls/oleaut32/tests/usrmarshal.c index 38827b1..ce1a88f 100644 --- a/dlls/oleaut32/tests/usrmarshal.c +++ b/dlls/oleaut32/tests/usrmarshal.c @@ -572,6 +572,7 @@ static void test_marshal_VARIANT(void) LPSAFEARRAY lpsa; DECIMAL dec, dec2; HeapUnknown *heap_unknown; + int win95_correction = 4; stubMsg.RpcMsg = &rpcMsg; @@ -600,11 +601,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 21, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -614,7 +615,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(V_I1(&v) == V_I1(&v2), "got i1 %x expect %x\n", V_I1(&v), V_I1(&v2)); @@ -630,11 +631,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 22, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -644,7 +645,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(V_I2(&v) == V_I2(&v2), "got i2 %x expect %x\n", V_I2(&v), V_I2(&v2)); @@ -661,8 +662,8 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 26, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); wirev = (DWORD*)buffer; @@ -697,11 +698,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 24, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -712,7 +713,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(V_I4(&v) == V_I4(&v2), "got i4 %x expect %x\n", V_I4(&v), V_I4(&v2)); @@ -729,11 +730,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 24, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -743,7 +744,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(V_UI4(&v) == V_UI4(&v2), "got ui4 %x expect %x\n", V_UI4(&v), V_UI4(&v2)); @@ -761,8 +762,8 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 28, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); wirev = (DWORD*)buffer; @@ -794,11 +795,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 24, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -808,7 +809,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(V_R4(&v) == V_R4(&v2), "got r4 %f expect %f\n", V_R4(&v), V_R4(&v2)); @@ -890,11 +891,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 22, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -904,7 +905,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(V_BOOL(&v) == V_BOOL(&v2), "got bool %x expect %x\n", V_BOOL(&v), V_BOOL(&v2)); @@ -996,11 +997,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 20, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); if (VARIANT_UNMARSHAL_WORKS) @@ -1008,7 +1009,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); VARIANT_UserFree(&umcb.Flags, &v2); @@ -1022,11 +1023,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 20, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); if (VARIANT_UNMARSHAL_WORKS) @@ -1034,7 +1035,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); VARIANT_UserFree(&umcb.Flags, &v2); @@ -1123,11 +1124,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 152, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -1141,7 +1142,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(SafeArrayGetDim(V_ARRAY(&v)) == SafeArrayGetDim(V_ARRAY(&v)), "array dims differ\n"); SafeArrayGetLBound(V_ARRAY(&v), 1, &bound); @@ -1164,11 +1165,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength == 152, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); - wirev = (DWORD*)buffer; + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, stubMsg.BufferLength); wirev += 5; @@ -1184,7 +1185,7 @@ static void test_marshal_VARIANT(void) VariantInit(&v2); stubMsg.Buffer = buffer; next = VARIANT_UserUnmarshal(&umcb.Flags, buffer, &v2); - ok(next == buffer + stubMsg.BufferLength, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); + ok(next == buffer + stubMsg.BufferLength + win95_correction, "got %p expect %p\n", next, buffer + stubMsg.BufferLength); ok(V_VT(&v) == V_VT(&v2), "got vt %d expect %d\n", V_VT(&v), V_VT(&v2)); ok(SafeArrayGetDim(*V_ARRAYREF(&v)) == SafeArrayGetDim(*V_ARRAYREF(&v)), "array dims differ\n"); SafeArrayGetLBound(*V_ARRAYREF(&v), 1, &bound); @@ -1257,11 +1258,11 @@ static void test_marshal_VARIANT(void) rpcMsg.BufferLength = stubMsg.BufferLength = VARIANT_UserSize(&umcb.Flags, 0, &v); ok(stubMsg.BufferLength > 32, "size %d\n", stubMsg.BufferLength); - buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength); - stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength; + buffer = rpcMsg.Buffer = stubMsg.Buffer = stubMsg.BufferStart = HeapAlloc(GetProcessHeap(), 0, stubMsg.BufferLength + win95_correction); + stubMsg.BufferEnd = stubMsg.Buffer + stubMsg.BufferLength + win95_correction; memset(buffer, 0xcc, stubMsg.BufferLength); next = VARIANT_UserMarshal(&umcb.Flags, buffer, &v); - wirev = (DWORD*)buffer; + wirev = (DWORD*)(buffer + win95_correction); check_variant_header(wirev, &v, next - buffer); wirev += 5; @@ -1270,10 +1271,10 @@ static void test_marshal_VARIANT(void) *wirev == (DWORD_PTR)V_UNKNOWN(&v) + 1 /* NT */, "wv[5] %08x\n", *wirev); wirev++; todo_wine - ok(*wirev == next - buffer - 0x20, "wv[6] %08x\n", *wirev); + ok(*wirev == next - buffer - win95_correction - 0x20, "wv[6] %08x\n", *wirev); wirev++; todo_wine - ok(*wirev == next - buffer - 0x20, "wv[7] %08x\n", *wirev); + ok(*wirev == next - buffer - win95_correction - 0x20, "wv[7] %08x\n", *wirev); wirev++; todo_wine ok(*wirev == 0x574f454d, "wv[8] %08x\n", *wirev);

1 0

Re: [PATCH 1/5] wined3d: Make sure queries have an active GL context.
by Stefan Dösinger 26 Jun '09

26 Jun '09

Am Friday 26 June 2009 10:07:08 schrieb Henri Verbeet: > + ActivateContext(This->wineD3DDevice, > This->wineD3DDevice->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); + > if (((WineQueryOcclusionData *)This->extendedData)->ctx != > This->wineD3DDevice->activeContext || > This->wineD3DDevice->activeContext->tid != GetCurrentThreadId()) Wouldn't it be better to activate a context after the thread check? Ie, don't activate a context when we know that we can't make use of the GL query anyway?

2 2

Re: Potential patch for an oddity in dlls/d3d9/device.c
by Henri Verbeet 26 Jun '09

26 Jun '09

2009/6/25 Gerald Pfeifer <gerald(a)pfeifer.com>: > So, I wonder whether something like the patch below is the right fix, or > whether there is a deeper problem? > That fix is correct.

1 0

Re: Removing active maintainers
by Vitaliy Margolen 26 Jun '09

26 Jun '09

mellery wrote: > He has removed useful comments on apps I maintain too. I don't want to > complain on the dev-list but if you know who i should email about it, > I'd send an email. This is the only place that you can/should discuss this. Vitaliy

1 0

Re: [5/10] d3dx9: Implement D3DXLoadSurfaceFromSurface
by Stefan Dösinger 25 Jun '09

25 Jun '09

Am Thursday 25 June 2009 20:26:01 schrieb Tony Wasserka: Watch out, some surfaces aren't lockable. I don't know the d3dx9 api too well, but are you sure that you have a lockable surface here? In some situations IDirect3DDevice9::UpdateSurface or IDirect3DDevice9::StretchRect may be a faster way to achieve what this code does(without colorkeying though).

1 0

Re: drmclien: add stub dll
by Stefan Leichter 25 Jun '09

25 Jun '09

Am Thursday 25 June 2009 00:47:59 schrieb Austin English: > Makes IE6 installer a little happier > 0002-t2embed-add-stub-dll.txt > From 6b2a780718210b35cff17f519559a2c8faa80a07 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Mon, 4 May 2009 22:52:37 -0500 > Subject: [PATCH] t2embed: add stub dll > > configure.ac | 1 + > dlls/t2embed/Makefile.in | 13 +++++++++++++ > dlls/t2embed/main.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > dlls/t2embed/t2embed.spec | 25 +++++++++++++++++++++++++ > 4 files changed, 82 insertions(+), 0 deletions(-) > create mode 100644 dlls/t2embed/Makefile.in > create mode 100644 dlls/t2embed/main.c > create mode 100644 dlls/t2embed/t2embed.spec Did you pick the wrong patch ? This dll already exists !

2 1

Re: wine-devel Digest, Vol 47, Issue 86
by Tim Schwartz 25 Jun '09

25 Jun '09

> And Ben Klein is not the VOICE of WineHQ! > > Tom It doesn't matter who says something if what they are saying is correct. You sound like the troll to me.

2 1

ActiveX support in IE7
by arcoun 25 Jun '09

25 Jun '09

Hello, It is my understanding that IE7 installed in Wine (for exemple, by following instructions at http://www.wine-reviews.net/wine-reviews/applications/ie-7-on-linux-with-wi…) has no support for ActiveX. Does anyone know what are the missing parts (in Wine or by adding more native DLLs) to make it work ? Which native DLL is responsible for all the ActiveX stuff ? If we've got a clear understanding of what is missing and if a Wine dev is interested, I can sponsor it through a bounty. Regards, -- arcoun

5 6

Intermittent crashes in the ole32:clipboard tests
by Paul Vriens 25 Jun '09

25 Jun '09

Hi Huw, I'm having (and more systems according to test.winehq.org) intermittent crashes in these mentioned tests. It is happening in the while() loop in test_enum_fmtetc(), at least for W2K and XP. I'm able to reproduce on W2K (once every 10 runs or so) but I can't put my finger on it. Vista and higher crash intermittently as well but at another place (test_getdatahere() ?) Any ideas? -- Cheers, Paul.

1 1

Re: winedbg italian translation
by Nikolay Sivov 25 Jun '09

25 Jun '09

Davide Pizzetti wrote: > Here's the italian translation for winedbg > This is wrong of course - you broke English resource file. You need to create a new file here with same naming convention (rsrc_It.rc) and 'git add' it to your tree before commit.

2 1

Re: [1/8] windowscodecs: add stub implementation of IWICImagingFactory
by Alexandre Julliard 25 Jun '09

25 Jun '09

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > +HRESULT register_classes(void) > +{ > + int i; > + HKEY clsid_key, ips32_key; > + LONG res=0; > + HRESULT hr=S_OK; > + static const WCHAR inprocserver32W[] = {'I','n','P','r','o','c','S','e','r','v','e','r','3','2',0}; > + > + for (i=0; wic_classes[i].classid; i++) > + { > + hr = get_clsid_key(wic_classes[i].classid, KEY_READ|KEY_WRITE, &clsid_key); > + if (!SUCCEEDED(hr)) break; > + > + res = RegCreateKeyExW(clsid_key, inprocserver32W, 0, NULL, 0, > + KEY_READ|KEY_WRITE, NULL, &ips32_key, NULL); > + if (res == ERROR_SUCCESS) > + { > + res = RegSetValueExA(ips32_key, NULL, 0, REG_SZ, (CONST BYTE*)"windowscodecs.dll", lstrlenA("windowscodecs.dll") + 1); > + if (res != ERROR_SUCCESS) > + break; > + res = RegSetValueExA(ips32_key, "ThreadingModel", 0, REG_SZ, (CONST BYTE*)"Apartment", lstrlenA("Apartment") + 1); > + if (res != ERROR_SUCCESS) > + break; > + } > + else > + break; > + > + RegCloseKey(clsid_key); > + } > + > + if (res != 0) hr = HRESULT_FROM_WIN32(res); > + > + return hr; > +} Please copy the standard regsvr.c registration code instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cmdlgtst italian translation
by Nikolay Sivov 25 Jun '09

25 Jun '09

Davide Pizzetti wrote: > Here's the italian translation for cmdlgtst > - MENUITEM "Pa&ge Setup", CM_U_PAGESETUP + MENUITEM "Installazione Pa&gina", CM_U_PAGESETUP } Correct me if I'm wrong, but it looks like you treated this as 'installation page', but it really means 'print page setup' - printing properties. Looking at notepad It.rc I've found: MENUITEM "&Imposta pagina...", CMD_PAGE_SETUP for similar 'Page Setup'. Nikolay S.

1 0

Re: AW: Shameless call for game testing
by Stefan Dösinger 25 Jun '09

25 Jun '09

Am Thursday 25 June 2009 11:45:19 schrieb Joerg-Cyril.Hoehle(a)t-systems.com: > Stefan, > > >Generally, turning off GLSL turns down the advertised shader > >model to 1.x, which is the d3d8 feature set. > > Is this still the case since your mail > http://www.winehq.org/pipermail/wine-devel/2009-June/076766.html No - it is 2.0 now, or even 3.0 with the NV extensions. However, if the hardware supports less than 256 vertex shader constants, we still advertise SM 1.x. That is usually the case on HW that does not support more than SM 1.x anyway. If we advertised SM 2.0 on these cards, many shaders would very likely fall back to software rendering. > Does the Intel i915 qualify? How do I tell? How is this related to Mesa? > Would it require a Mesa much newer than Ubuntu 8.10 (yeah, I know 9.04 is > around)? In theory SM 2.0 with ARB. Mesa drivers are generally in a bad shape, especially the ones that are shipped by ubuntu, so many games are expected to fail. Shaders are just a small part of the equation. This ARB works helps Mesa insofar because it gives somewhat decent shader support without requiring a GLSL compiler. A GLSL compiler has to be pretty darn good to work properly with Wine, so before Gallium3D is stable and in use, I don't expect GLSL to work well in complex games with open source drivers. I talked to some Mesa developers on #winehackers, they might introduce their own ATI/Intel/Mesa specific extensions for SM 3.0 support on top of ARB shaders. Ie, a subset of the NV extensions that ATI cards support. (Nvidia HW supports more things than D3D makes available, and ATI cards can't support the full NV asm extensions)

1 0

Re: wined3d: fix a compiler warning
by Michael Stefaniuc 25 Jun '09

25 Jun '09

Hello Austin, On Tue, Jun 23, 2009 at 12:47:18AM -0500, Austin English wrote: > Okay'ed by Henri > are you reinventing strcpy? > diff --git a/dlls/wined3d/arb_program_shader.c > b/dlls/wined3d/arb_program_shader.c > index 44b4fce..f759372 100644 > --- a/dlls/wined3d/arb_program_shader.c > +++ b/dlls/wined3d/arb_program_shader.c > @@ -922,11 +922,11 @@ static void shader_arb_get_register_name(const > struct wined3d_shader_instruction > { > if(This->baseShader.reg_maps.shader_version.major < 3) > { > - sprintf(register_name, > ctx->texcrd_output[reg->idx]); > + sprintf(register_name, "%s", ctx->texcrd_output[reg->idx]); > } > else > { > - sprintf(register_name, ctx->vs_output[reg->idx]); > + sprintf(register_name, "%s", ctx->vs_output[reg->idx]); > } > } > break; bye michael

5 6

Re: mshtml: Add slovenian transtaltion
by Paul Vriens 25 Jun '09

25 Jun '09

Matej Spindler wrote: > My first patch to wine. Am I doing this right? > > > ------------------------------------------------------------------------ > > Hi Matej, Looks fine to me although I can't comment on the actual translations ;) Thanks for helping Wine and looking forward to more translation patches. (There is a typo in the email subject btw, should be "translation". No need to resend though I think) -- Cheers, Paul.

1 0

Re: [1/3] [wined3d] add ps_np2fixup_info structure (resend)
by Stefan Dösinger 24 Jun '09

24 Jun '09

Am Wednesday 24 June 2009 17:51:44 schrieb Tobias Jakobi: The patches look ok to me

1 0

Shameless call for game testing
by Stefan Dösinger 24 Jun '09

24 Jun '09

Hi, I need some help for people who spectate this list and use Wine mostly for gaming. In the past weeks, I have improved our ARB shader backend to support Shader Model 3.0 on cards that support GL_NV_vertex_program3 and GL_NV_fragment_program2(Geforce 6+), and 2.0 on other cards that have support for the needed shader constants(ATI Radeon 9500+, intel chips). What is this good for: *) Works better on platforms with bad GLSL support, like Macs and Mesa *) Deal with some corner cases, like texldd support on dx9 nvidia cards *) Slightly better performance in some games However, GLSL is the default right now, and we don't want to change this anytime soon, but I'd still like to get some testing of the ARB code. So I'd be happy if some people could disable GLSL(HKEY_CURRENT_USER/Software/Wine/Direct3D/UseGLSL="disabled") and see how their games work? In the ideal world, the results are like this: *) Everything that works with GLSL works with ARB on NV cards *) The ARB backend is slightly faster(I've seen approx. +10%) Can you test your games, and if something does not work that works with GLSL file a bug and assign it to me? Also please file a bug if there is a noticeable performance loss, or if ARB is MUCH faster(hints towards a GLSL shader code bug). If the game runs just fine, feel free to reply to this mail with your results and GLSL performance comparisons. Note that ATI cards do not support SM 3.0 with ARB. This is NOT a bug. Those cards just don't have any extensions that provide the additional features with ARB shaders, so you have to use GLSL there if you need SM 3.0. Thanks for your help, Stefan

1 0

Re: italian translations for winecfg
by Nikolay Sivov 24 Jun '09

24 Jun '09

Davide Pizzetti wrote: > i've got a question: how i produce a patch with 'git diff'? what is the > correct syntax of the command? > Il giorno mer, 24/06/2009 alle 19.17 +0400, Nikolay Sivov ha scritto: > >> Davide Pizzetti wrote: >> >>> Here are the italian translations for winecfg. >>> >>> >> 1. Use 'git diff' format to produce patches >> 2. Use plain text attachments. >> >> Feel free to ask here any related questions Actually it's a correct format itself: 'git diff' from a git-tree. If you did commits to your local tree use 'git format-patch' as described http://www.winehq.org/sending_patches 'git format-patch --stdout --keep-subject origin' this will output all local commits with info headers. If you didn't commit you could just use 'git diff' output which will contain all changes from current head. Also add a more descriptive subject, something like: 'winecfg: Update Italian resources' with module you're working on as a prefix. Note that your attachment should be plain text without any additional formatting (no html messages, no wrapping).

1 0

Re: italian translations for winecfg
by Nikolay Sivov 24 Jun '09

24 Jun '09

Davide Pizzetti wrote: > Here are the italian translations for winecfg. > 1. Use 'git diff' format to produce patches 2. Use plain text attachments. Feel free to ask here any related questions.

1 0

Re:
by Austin English 24 Jun '09

24 Jun '09

2009/6/24 Pavel Procházka <pavelvonlostice(a)seznam.cz>: Howdy Pavel, A few minor things: A) Please use a descriptive subject, and put your message in the e-mail body. It's easier for those that don't read every patch but only care about certain areas to skim the mailing list that way. Also, it's hard to search the archives when there's no subject on the e-mail. B) +/*MULTIBUFFERING PART*/ It's not a huge deal, but please add spaces around comments, they're hard to read that way. C) @@ -2716,5 +2909,5 @@ START_TEST(visual) return ; cleanup: - releaseObjects(); + releaseObjects(); } Now sure why that was changed...did you accidentally change the encoding or something? -- -Austin

2 1

Re: Re: wine compatible logo needed
by M. Stefanov 24 Jun '09

24 Jun '09

You're right. I'll use the full version. And an electronic manual wouldn't be practical in my case. Which is: begin "We need this." repeat "Is this what you need?"; "No, modify"; Mod_soft; until Response = "OK, this is it."; write(manual); burn(CD); install_all; end. So basically it's the end of the development cycle for that specifical program. That's why I think to specify the particular version of wine and linux distro that I'm certain it works with and throw in a note that experiences with other wine versions / linux distros / different OS may be different (with other words of course). And when/if the time comes for a v 2.0 of my soft, I'll test that against the latest wine that exists at the time of 2.0 release, and if it works, do the same with the 2.0 manual. Basically I was asking if there was a pre-existing template for such a case - a finished program which works out-of-the-box under wine at the time of the soft finalization...

2 1

free software replacement for MFC?
by karl＠gnu.org 24 Jun '09

24 Jun '09

In the course of reviewing some possible projects for GNU, Richard Stallman asked me if there was any active work going on to write a free software replacement for MFC. >From the MFC pages I found on the Wine web site (http://www.winehq.org/docs/winelib-guide/mfc), which talk about ways of working with the Microsoft classes and don't mention any alternatives, I gather this isn't a current goal of Wine itself. But still, I figured that this would be the most likely place for any such project would be known about, or even find possible developers if one was to be started. Looking on the web, all I found was the old ofc.sf.net, which appears not to have gotten very far and to have been abandoned years ago, judging from the source repository. The other projects I came across, such as wxWidgets and SmartC++, appear not to try to be a compatible replacement for MFC, but rather a functional alternative. If anyone here has corrections, additions, suggestions related to those, I'd be grateful for any replies. Thanks, karl(a)gnu.org

3 2

Re: [put the subject here]
by Dmitry Timoshkov 24 Jun '09

24 Jun '09

"Pavel Procházka" <pavelvonlostice(a)seznam.cz> wrote: > Subject:[2/3] wined3d: IWineGDISwapChainImpl_Present relevant to windows implementation > Making multibuffering working well when flip - sequence is W RGB, R GBW, G BWR, B WRG, W RGB. When W = WHITE, R = > RED, G = GREEN, B = BLUE. It is doing well for any count of backbuffers - for 1 too. Please try to make the patch subject short and clear. All additional comments put in the patch body. > - back = (IWineD3DSurfaceImpl *) This->backBuffer[0]; > + back = *((IWineD3DSurfaceImpl *)This->backBuffer[0]); /*this value can not be pointer*/ Any reason for the above change and comment? > + /*moving data from backbuffers to left - no pointers!*/ > + for(i=0;i<This->presentParms.BackBufferCount-1;i++) Some spaces wouldn't hurt, and would better match the code you are changing. -- Dmitry.

1 0

Re: avifil32: Romanian translation
by Michael Stefaniuc 24 Jun '09

24 Jun '09

Paul, Paul Chitescu wrote: > Changelog: > avifil32: Romanian translation it looks like you are missing the #pragma code_page(65001) around the translation. bye michael

1 0

Re: programs/taskmanager: Fixed missing Dutch translations
by Paul Vriens 24 Jun '09

24 Jun '09

Frans Kool wrote: > > > ------------------------------------------------------------------------ > > Beat you to it ;) http://www.winehq.org/pipermail/wine-patches/2009-June/074719.html -- Cheers, Paul.

1 0

Re: [1/3][resend] wined3d: Allowing infinity count of backbuffers
by paulo lesgaz 24 Jun '09

24 Jun '09

--- En date de : Mer 24.6.09, Henri Verbeet <hverbeet(a)gmail.com> a écrit : De: Henri Verbeet <hverbeet(a)gmail.com> Objet: Re: [1/3][resend] wined3d: Allowing infinity count of backbuffers À: wine-devel(a)winehq.org Date: Mercredi 24 Juin 2009, 11h13 2009/6/24 Pavel Procházka <pavelvonlostice(a)seznam.cz>: > Please set a proper subject on your mails. I think this has been asked before. You can't just remove the check without making it work first, the patch has to make sense on its own. I don't get what you mean. Do you suggest that Pavel merges the two first patches in one single, with a title like "Allows multibuffering in ddraw" ? David

2 1

Re: [1/3][resend] wined3d: Allowing infinity count of backbuffers
by Henri Verbeet 24 Jun '09

24 Jun '09

2009/6/24 Pavel Procházka <pavelvonlostice(a)seznam.cz>: > Please set a proper subject on your mails. I think this has been asked before. You can't just remove the check without making it work first, the patch has to make sense on its own.

1 0

Developers-Hints wiki page: Character encoding in resource file translations
by Frédéric Delanoy 24 Jun '09

24 Jun '09

Hi all, According to http://wiki.winehq.org/Developers-Hints on the "http://wiki.winehq.org/Developers-Hints", AFAICT the resource files should generally - use the default Windows codepage for the specified language or - use UTF-8 surround with "#pragma code_page(65001)" at the top of the file and "#pragma code_page(default)" at the bottom Which of the encoding is preferred? UTF-8 ? Furthermore, - the "65001" should probably be replaced by "utf8" (I checked in tools/wrc/parser.l:373) [ which would be better IMNSHO in new/updated resource file] - the link to the list of codepages is broken; it should be http://msdn.microsoft.com/en-us/library/dd317756(VS.85).aspx Frédéric

4 3

Re: wine compatible logo needed
by Metody Stefanov 24 Jun '09

24 Jun '09

Thanks for all the responses. Yes, I intend to specify the wine version and the linux distro used. I had in mind something like this for the manual: "System Requirements: [...] Hardware stuff [...] Operating system: Windows XP SP2 or later. [WORKS WITH WINE LOGO GOES HERE] wine* 1.1.24 (or should I use just 1.1?) " And then, a footnote: "Works with wine 1.1.24, openSuSe 11.1 linux, see Appendix A "Technical notes/Descriptions" (Have to come up with a better name) for more information" And then in the appendix, a small description of what wine is, something along the lines of : [wine official logo] wine: Application compatibility layer that allows running software designed for windows on other OSses. Follows a list of OSes that are supported (resp. architectures etc.) and then a note that wine is work in progress so experience with later/previous versions may vary (will think of a better way to put it). Thoughts? Cheers, Metody Stefanov (PS sorry for the distorted first post (and this one if it turns bad as well). PC I'm using at the moment has a strictly no-linux, no-other soft policy, only Microsoft pre-installed stuff. Outlook Express in this case...)

2 1

Is there any way to debug driver?
by Guan, Xiao-Feng 24 Jun '09

24 Jun '09

Hello, I'm AMD driver developer and would like to ask a question. This issue blocks us from making a better driver for WINE. Recently we have difficulty in debugging our driver with WINE. We used to start wine-pthread in gdb to debug the applications. Or else we cannot break into our driver. However, now we cannot build this executable any more in wine-1.1.23 or git repository. I wonder if there is any other method to get all symbols right in gdb. As we can see that, from version 1.1.23, all application fails to start on AMD card. We are going to investigate why it happens. If it is necessary, Would you please let us know a little more about the changes of this version? Thanks & regards. Guan Xiaofeng OpenGL Software Engineer, Graphic Product Group Shanghai R&D Center, AMD Cop. Xiao-Feng.Guan(a)amd.com <mailto:Xiao-Feng.Guan@amd.com> Tel 86 021 61601838 ext 25746

9 14

Re: wine-patches Digest, Vol 47, Issue 188
by Ricardo Filipe 23 Jun '09

23 Jun '09

2009/6/23 Pavel Procházka <pavelvonlostice(a)seznam.cz> > hello > I want to ask you if i should resend the patch in correct form, sorry for > the last patch. > Thank you for answer > do not send "normal" messages to wine-patches. send those to wine-devel, wine-patches is for messages with attached patches only. yes, you should resend your patches with the corrections and suggestions stefan and james gave you. put (resend) or (try 2) on the subject. you should avoid resending more than 2 or 3 times a week, unless you've cleared with julliard. regards.

1 0

wine compatible logo needed
by Metody Stefanov 23 Jun '09

23 Jun '09

Long story short - I've developed a small piece of software for the local govt, and it appears to work out-of-the-box under wine (openSuse 11.1). Since now I'm writing the user/admin manuals (heh, a nice way to discover some bugs BTW - "If you click this, this happens... oh wait, last time it did, now it doesn't"), I was wondering if there is an official "100% wine compatible" logo - you know, something like the "Designed for Windows" that most hardware manifacturers put on their boxes. Or any other standartized method of mentioning the fact that the software works under wine out of the box. Cheers, M. Stefanov.

6 6

Re: Pavel Procházka's commit
by James Mckenzie 23 Jun '09

23 Jun '09

Pavel Procházka <pavelvonlostice(a)seznam.cz> wrote about Pavel Procházka's commit > Needs a more descriptive title here. Need to state what module/file the patch affects. One patch per patch message. Order them in the manner they should be installed and mark with [n/x] where n is the patch number and x is the number of patch files. Need to use spacing for your patches OR follow the pattern in use in the file. Tab stops are HIGHLY discouraged. Add test cases, if needed, to demonstrate what you are attempting to do is what Windows(TM) does with the same inputs. James McKenzie

1 0

Re: advapi32: Add-some-flesh-to-LsaLookupNames2
by Paul Vriens 23 Jun '09

23 Jun '09

Louis. Lenders wrote: > Hi, this is enough added to make several .net 2.0 apps and .net 3.0 installer happy. > Patches based on patches from Aric that somehow never made it in, so i simplified it in the sense that only 1 name in the names array is handled for now. Next patch are some tests > Hi Louis, Indentation is a bit off here: + if (count != 1) + { + return STATUS_NONE_MAPPED; + } -- Cheers, Paul.

1 0

Fwd: [Wine] Bigpond Media Downloader works with Wine
by Austin English 23 Jun '09

23 Jun '09

On Tue, Jun 23, 2009 at 4:38 AM, mgray<wineforum-user(a)winehq.org> wrote: > Hi there, > > This is my first EVER linux-based post (scary!). Just to say I switched to linux (Xubuntu 9.04) yesterday from XP, and have got everything that HAD to be exe working, including Bigpond Media Downloader. Bigpond is an Australian communications network, who also sell songs, movies, etc. They have a media downloader specifically for their files, which was making me a bit nervous - it's only available for Mac and Microsoft OSs. But I used Wine, and it works totally fine. If a complete newb like me can get it to work, anybody can. 'If a complete newb like me can get it to work, anybody can.' :-) -- -Austin

1 0

Re: [2/3] ole32: Implement CoGetContextToken.
by Rob Shearman 23 Jun '09

23 Jun '09

2009/6/23 Hans Leidekker <hans(a)codeweavers.com>: > @@ -228,6 +232,7 @@ static void COM_TlsDestroy(void) > if (info->errorinfo) IErrorInfo_Release(info->errorinfo); > if (info->state) IUnknown_Release(info->state); > if (info->spy) IUnknown_Release(info->spy); > + if (info->context_token) IUnknown_Release((IUnknown *)info->context_token); > HeapFree(GetProcessHeap(), 0, info); > NtCurrentTeb()->ReservedForOle = NULL; > } Why not change the type of info->context_token to be IObjContext* or IUnknown* instead of ULONG_PTR? It shouldn't change the memory layout of the oletls structure and it will eliminate the need of these types of casts. -- Rob Shearman

1 0

RE: [comctl32] Test request
by Ge van Geldorp 23 Jun '09

23 Jun '09

> From: Nikolay Sivov <bunglehead(a)gmail.com> > > I've just prepared some simple MRU tests and I need test them on various native platfoms - > tested only on xp sp2 so this one could be skipped. > > Could somebody do it? Your tests pass on my W2K, XP, W2K3, Vista and W2K8 machines, but I get crashes which were not there before on NT4 Workstation and NT4 Server (both SP6). I haven't investigated further, I could probably determine the test case that crashes if needed. Ge.

3 5

Translation statistics page errors
by Paul Chitescu 23 Jun '09

23 Jun '09

While trying to identify missing translations: http://source.winehq.org/transl/resource.php?lang=009%3A01&resfile=dlls%2Fs… Got: Wine translations > English (US) > dlls/shell32 > STRINGTABLE #11 (strings 160..175) Dump of STRINGTABLE #11 (strings 160..175) Warning: assert() [function.assert]: Assertion failed in /home/winehq/opt/git-tools/transl/php/lib_res.php on line 343 Warning: assert() [function.assert]: Assertion failed in /home/winehq/opt/git-tools/transl/php/lib_res.php on line 343 Resource not found in *.res file

1 0

Re: urlmon: [Patch 1] Implement CreateZoneEnumerator, GetZoneAt, DestroyZoneEnumerator [try 3]
by Jacek Caban 22 Jun '09

22 Jun '09

Hi Detlef, Detlef Riekenberg wrote: > This time, we don't care about dwEnum. > That value is returned from CreateZoneEnumerator and > checked only in GetZoneAt and DestroyZoneEnumerator. > > Windows has only the Zones "0" upto "4" since IE4.0 > and no UI to add or remove a Zone. > Did you test what happens if you add zone registries manually via regedit? Thanks, Jacek

1 0

Appinstall update
by Austin English 22 Jun '09

22 Jun '09

Howdy, James has asked me to send y'all an update on my Summer of Code project, Appinstall. I've got a dozen or so app tests committed already, and several more that I'm putting the final touches on. I just finished a wrapper script to make it easy to test daily, and have begun uploading results to http://www.austinenglish.com/logs/. The logs are a bit verbose, so I've committed a fix to make the sha1sum silent on success, which should cut down the noise a lot. To get a quick look, just check summary.txt daily, which will complain if there are any failing tests or 'TODO_FIXED', the equivalent of todo_wine passing (while testing applications I often find bugs, so I've written the tests to automatically check for those bugs and report if they're fixed). The tests should now be run daily on my machine, searching for regressions and bugs that have been fixed. I've also added a couple example test scripts, to make it easier for those unfamiliar with AutoHotKey to write tests for their favorite applications. (http://winezeug.googlecode.com/svn/trunk/appinstall/examples/). Source is available on winezeug: http://code.google.com/p/winezeug/ http://winezeug.googlecode.com/svn/trunk/appinstall/ -- -Austin

1 0

Re: [PATCH 2/2] mshtml: Fixed tests on IE8 and change Wine behavior to IE8.
by Paul Vriens 22 Jun '09

22 Jun '09

Jacek Caban wrote: > --- > dlls/mshtml/dispex.c | 2 ++ > dlls/mshtml/htmllocation.c | 2 +- > dlls/mshtml/mshtml_private.h | 2 ++ > dlls/mshtml/omnavigator.c | 2 +- > dlls/mshtml/tests/dom.c | 36 ++++++++++++++++++++++++++++++------ > 5 files changed, 36 insertions(+), 8 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, Thanks for looking into the IE8 test failures. This piece however doesn't look correct: +static void _test_disp2(unsigned line, IUnknown *unk, const IID *diid, const IID *diid2) +{ + IID iid; + + if(_test_get_dispid(line, unk, &iid)) + ok_(__FILE__,line) (IsEqualGUID(&iid, diid) || broken(IsEqualGUID(&iid, diid)), + "unexpected guid %s\n", dbgstr_guid(&iid)); You are comparing twice against diid. -- Cheers, Paul.

2 1

Wine translation statistics sources
by Mikołaj Zalewski 22 Jun '09

22 Jun '09

Hi, I didn't update the translation statistics (http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my server is a bit broken and I can't run the scripts from cron but have remember to do it manually from a different computer. I have plans to fix it, but in the mean time, as some people may want fresh data, I have finished the changes I've been working on and uploaded the sources. It should be very easy to run them on ones machine and check the tree one has on disk - there is a README with explanations. The archive is available at http://www.mikolaj.zalewski.pl/dl/wine-transl.tgz . It is the latest version that adds support for dumping/diffing dialogs. Mikolaj Zalewski

8 17

Problems with ~/.wine/dosdevices symlinks on samba servers
by Dan Kegel 22 Jun '09

22 Jun '09

According to http://groups.google.com/group/Google-Labs-Picasa-for-Linux/browse_thread/t… a user is having trouble because the symlinks in ~/.wine/dosdevices don't work when on a Samba share. It's unfortunate at this late date to realize that one of the key choices Wine made isn't compatible with the cifs/samba combination... but I guess nobody expected home directories to be served with that network filesystem. If this turns out to be a real problem, what are our options? The first thing that comes to mind is to notice the problem and fall back to underscore instead of colon somehow...

2 3

Re: [PATCH 1/4] jscript: Added implementation of Date constructor with more then one argument
by Alexandre Julliard 22 Jun '09

22 Jun '09

Piotr Caban <piotr.caban(a)gmail.com> writes: > @@ -221,6 +253,62 @@ static inline DOUBLE week_day(DOUBLE time) > return ret; > } > > +static inline DOUBLE convert_time(int year, SYSTEMTIME st) > +{ > + DOUBLE time; > + int set_week_day; > + > + time = time_from_year(year); > + time += (DOUBLE)day_from_month(st.wMonth-1, in_leap_year(time)) * MS_PER_DAY; > + > + set_week_day = st.wDayOfWeek-week_day(time); > + if(set_week_day < 0) > + set_week_day += 7; > + time += set_week_day * MS_PER_DAY; > + > + time += (DOUBLE)(st.wDay-1) * 7 * MS_PER_DAY; > + if(month_from_time(time) != st.wMonth-1) > + time -= 7 * MS_PER_DAY; > + > + time += st.wHour * MS_PER_HOUR; > + time += st.wMinute * MS_PER_MINUTE; > + > + return time; > +} You should use SystemTimeToFileTime or some similar function, no need to reinvent the wheel. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Test patch
by Austin English 22 Jun '09

22 Jun '09

On Sat, Jun 20, 2009 at 9:37 PM, Joshua Reisenauer<kd7tck(a)gmail.com> wrote: > I am sending this test patch to see if I used the correct formatting. I > would like feedback on what the wine dev community likes and doesn't like in > patches. For example do you prefer .txt or .patch? .txt please, much easier to read in browser. Please avoid tabs. Many of the changes you made aren't needed, aren't appropriate. E.g., 'etc.' is right, 'etc...' is not (unless that's a British thing I don't know about). Some of the places you capitalized aren't needed. The 'patch file' listed in the README should be deleted, since it's no longer provided. -- -Austin

2 1

Re: Pavel Procházka's commit
by Stefan Dösinger 22 Jun '09

22 Jun '09

Hi, Please send one patch per email. If you have 3 patches, like in this case, please send 3 emails All the patches have trailing whitespaces in some places, and mix tabs and 4-space indentation. Please avoid trailing whitespaces and use 4 spaces for indentation everywhere. In the test: Please define BACKBUFFERCOUNT somewhere close or in TestMultibuffering I recommend to perform one flip, then check the colors, perform another flip and check again. Flipping an arbitrary amount of times and then checking the colors once makes it hard to see what is going on. The 15 flips may also by chance sum up to a no-op or lead to a wrong conclusion. > + if(!StartMultibuffering()) > + { > + skip("An error when initializing multibuffering!, skipping . . . \n"); > + return; > + } I recommend not to skip the D3D tests if the multibuffering test fails to initialize for some reason(ie, remove the return) > +LPDIRECTDRAW lpDD = NULL; The rest of the test uses IDirectDraw *DD instead of LPDIRECTDRAW for COM interfaces The infinite amount of back buffers patch: We currently don't have a test for this, but msdn says that d3d8 and d3d9 have this limit on the amount of backbuffers. If you remove it from wined3d, please add the verification to d3d8.dll and d3d9.dll to make sure they still enforce this limit. Or write a d3d9 test to prove msdn wrong. There is already a test for swapchains in dlls/d3d9/tests/device.c, test_swapchain(). It should be fairly easy to test a too high backbuffer count there. The third patch(_Present relevant to windows implementation Making multibuffering working well when flip): > back = *((IWineD3DSurfaceImpl *)This->backBuffer[0]); /*this value can not be pointer*/ I don't like this, this copies too much data. Please just backup the fields you need > { >- HDC tmp; > - tmp = front->hDC; > - front->hDC = back->hDC; > - back->hDC = tmp; > + front->hDC = back.hDC; > } This will leave this code: { front->hDC = back.hDC; } Since you're not declaring any local variable any longer, please remove the {}

1 0

W-related helper functions for our tests
by Paul Vriens 22 Jun '09

22 Jun '09

Hi, I was wondering if it would make sense to introduce several helper functions that could be used by all our tests. The main ones needed are the ones to cope with Win9x missing several W-functions. Another one used quite often in the tests is something like wine_dbgstr_w. Yet another one compares a W with an A-string. Ideas, remarks, suggestions? -- Cheers, Paul.

4 5

Re: msi: add dummy thread just to initialize an MTA; fixes bug 18070
by Hans Leidekker 21 Jun '09

21 Jun '09

Hi Dan, > +/* Dummy thread just to initialize an MTA for the benefit of custom action DLLs */ > +static HANDLE dummy_thread_event = NULL; > +static HANDLE dummy_thread_handle = NULL; > + > +DWORD WINAPI dummy_thread_proc(void *arg) It appears that calling CreateThread in DLL_PROCESS_ATTACH can cause deadlocks: http://blogs.msdn.com/mgrier/archive/2005/06/21/431378.aspx It might work if you move it to somewhere near ACTION_CallDllFunction, and wait for the thread to start up, but this remains a hack of course. Another blog explains that inheritance of an existing MTA is just a side effect of starting the custom action in a different process, one that happens to have initialized an MTA already. -Hans

2 2

disabled mail on bouncing bugzilla accounts
by Jan Zerebecki 21 Jun '09

21 Jun '09

Thanks to Jeff Zaroyko, who went through the bounce mail, I just disabled sending bug mail to a few bugzilla accounts. Anyone who is affected by this and has fixed his mail reception can ask an bugzilla admin to enable it again (e.g. by mailing me directly). Jan

1 0

Re: msi: add dummy thread just to initialize an MTA; fixes bug 18070
by Austin English 21 Jun '09

21 Jun '09

On Sat, Jun 20, 2009 at 11:23 PM, Dan Kegel<dank(a)kegel.com> wrote: > This gets Photoshop CS4 installer to start up. > Per the suggestion in > http://bugs.winehq.org/show_bug.cgi?id=18070#c6 > > I am not worthy... +DWORD WINAPI dummy_thread_proc(void *arg) +{ + DWORD dwWaitResult; + + CoInitializeEx(0, COINIT_MULTITHREADED); + + // Just wait forever for DLL to be unloaded. Dan, you of all people should know, no C++ ;-). -- -Austin

1 0

Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
by Henri Verbeet 21 Jun '09

21 Jun '09

2009/6/20 Gerald Pfeifer <gerald(a)pfeifer.com>: > This makes it more clear that ! applies to the overall condition, > not just to the first part which is then and-ed. > I happened to have the same patch. Note that this does fix a real bug, ! has higher precedence than &.

1 0

Re: Clarify logical condition in dlls/wined3d/arb_program_shader.c
by Kai Blin 20 Jun '09

20 Jun '09

On Saturday 20 June 2009 17:17:53 Gerald Pfeifer wrote: Hi Gerald, not really about this patch in specific, but would you mind sticking to the established practice of prefixing your patches with the area of wine you're affecting? That makes it easier to skim the wine-patches list for the dlls I know and care about. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: Fix error checking in dlls/ddraw/executebuffer.c
by Paul Vriens 20 Jun '09

20 Jun '09

Gerald Pfeifer wrote: > I believe, after looking at the ranges of D3DLIGHTSTATETYPE, that > the below is the actual intention of this code (to ensure we are > in range). > > Gerald > > ChangeLog: > Fix error checking in IDirect3DExecuteBufferImpl_Execute(). > > diff --git a/dlls/ddraw/executebuffer.c b/dlls/ddraw/executebuffer.c > index 73e0657..6d6d304 100644 > --- a/dlls/ddraw/executebuffer.c > +++ b/dlls/ddraw/executebuffer.c > @@ -249,7 +249,7 @@ IDirect3DExecuteBufferImpl_Execute(IDirect3DExecuteBufferImpl *This, > > TRACE("(%08x,%08x)\n", ci->u1.dlstLightStateType, ci->u2.dwArg[0]); > > - if (!ci->u1.dlstLightStateType && (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) > + if (!ci->u1.dlstLightStateType || (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) > ERR("Unexpected Light State Type\n"); Would: if ((ci->u1.dlstLightStateType < D3DLIGHTSTATE_MATERIAL) || (ci->u1.dlstLightStateType > D3DLIGHTSTATE_COLORVERTEX)) be easier to read? (Matter of taste I guess). -- Cheers, Paul.

2 1

Re: Simplify code in dlls/imm32/tests/imm32.c
by Paul Vriens 20 Jun '09

20 Jun '09

Gerald Pfeifer wrote: > Not sure how to else handle this; possibly remove this whole subtest? > > Gerald > > ChangeLog: > Simplify code in dlls/imm32/tests/imm32.c (and avoid false warning). > > diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c > index 1951242..3e35ac1 100644 > --- a/dlls/imm32/tests/imm32.c > +++ b/dlls/imm32/tests/imm32.c > @@ -210,7 +210,7 @@ static void test_ImmNotifyIME(void) { > > /* behavior differs between win9x and NT */ > ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr)); > - ok(ret || !ret, "You'll never read this.\n"); > + ok(TRUE, "You'll never read this.\n"); > We could use broken() to make sure we follow the wanted behaviour for Wine. From the patch that changed that item it should be: ok(!ret || broken(ret), .....) If you look however at test.winehq.org it looks like hardly any box meets the proper requirements to run these tests at all. So I'd say: ok(!ret, "After being cancelled the composition string is empty.\n"); (Tested on my W2K3 and Vista boxes). -- Cheers, Paul.

1 0

Simplify code in dlls/imm32/tests/imm32.c
by Joris Huizer 20 Jun '09

20 Jun '09

Hello Gerald Pfeifer, You did, /* behavior differs between win9x and NT */ ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr)); - ok(ret || !ret, "You'll never read this.\n"); + ok(TRUE, "You'll never read this.\n"); Wouldn't it be better to do something like: ok(ret || broken(!ret), "You'll never read this.\n"); or marking the other case broken()? Note that broken() should be interpreted as, "unwanted functionality for Wine" HTH, Joris

1 0

Re: Alexandre Julliard : configure: Don't accept mingw32 as target name, we need an explicit CPU specification.
by Steven Edwards 20 Jun '09

20 Jun '09

On Fri, Jun 19, 2009 at 9:27 AM, Alexandre Julliard<julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: ccbf959969e32c9d71d2b4c46dbfe4db1ad2ab3f > URL: http://source.winehq.org/git/wine.git/?a=commit;h=ccbf959969e32c9d71d2b4c46… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Jun 18 21:35:51 2009 +0200 > > configure: Don't accept mingw32 as target name, we need an explicit CPU specification. I don't think this change is right. It is a very common convention to use mingw32 as a generic convention for 32bit x86. It seems the best practice would be if mingw32 is passed then to assume a sensible lowest common default. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

4 5

Re: winex11: Get rid of glext.h in remaining locations [try 2]
by James Mckenzie 19 Jun '09

19 Jun '09

Austin English <austinenglish(a)gmail.com> wrote about Re: winex11: Get rid of glext.h in remaining locations [try 2] > >On Fri, Jun 19, 2009 at 9:02 AM, Detlef Riekenberg<wine.dev(a)web.de> wrote: >> Already removed from dlls/opengl/* by Roderick. >> winex11 on linux works without GL/glext.h (OSX untested) >> >> Now with configure.ac > >Works fine on OS X. Sorry I forgot to do this myself. > Thank you. I have not set up my build system, yet. James McKenzie

1 0

Re: winex11: Get rid of glext.h in remaining locations [try 2]
by Austin English 19 Jun '09

19 Jun '09

On Fri, Jun 19, 2009 at 9:02 AM, Detlef Riekenberg<wine.dev(a)web.de> wrote: > Already removed from dlls/opengl/* by Roderick. > winex11 on linux works without GL/glext.h (OSX untested) > > Now with configure.ac Works fine on OS X. Sorry I forgot to do this myself. -- -Austin

1 0

Re: advpack: Implement ExtractFilesW [try 2]
by James Hawkins 19 Jun '09

19 Jun '09

2009/6/11 Vladimir Pankratov <scriptkid(a)mail.ru>: > Hello all. > > Implemented ExtractFilesW > > Changed files: > advpack/files.c > + if (GetFileAttributesA(ExpandDir) == INVALID_FILE_ATTRIBUTES) + return HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND); Why are you testing this in ExtractFilesA? Almost all of the logic should be passed on to ExtractFilesW so we don't duplicate code. + if (FileList != NULL) Please don't change the style of the file. if (FileList) is fine. + WideCharToMultiByte( CP_ACP, 0, FileList, -1, szFileList, sizeof(szFileList), NULL, NULL ); + szConvertedList = convert_file_list(szFileList, &dwFileCount); I'm not sure this is the way to go. You're converting A -> W -> A. This happens because cabinet.Extract is (as far as we know) ansi-only. In this case, I think it's ok to make ExtractFilesW call into ExtractFilesA, with an appropriate comment as to why this is happening. -- James Hawkins

2 1

Looking for a fast way to clean up AppDB comments
by Florian Köberle 19 Jun '09

19 Jun '09

Hi, I now became one of the application maintainers of Warcraft 3 The Frozen Throne and got asked to cleanup the comments. I started to do so, but there are just to much comments. I stopped deleting with 459 comments remaining. See: (http://appdb.winehq.org/objectManager.php?sClass=version&iId=3126) Is there a way to delete multiple comments at once? E.g. it would be cool if I could just check the comments to delete and hit then a button "delete selected comments" which opens the dialogue for the delete reason. Or some button "Delete all comments older then one year" would be quite useful. Best regards, Florian Köberle

4 4

NT4 passing
by André Hentschel 19 Jun '09

19 Jun '09

WinNT4 is passing now for the first time since a long time(maybe since ever?). So special congratulations to Paul Vriens, who spent much time making the test-suite run on NT4. This is a great step for the test-suite. Now NT4, 2K, XP and 2K3 are passing partially. Keep it up!

4 6

Wine MIME handling
by Roderick Colenbrander 18 Jun '09

18 Jun '09

Hi, For the past few days I have been looking at MIME handling in Wine. A program I'm using uses CreateProcess to launch a pdf file and I would like to use the default native pdf viewer. Initially I wrote a simple script which calls xdg-open to launch the file offered by Wine. (xdg-open "`wine winepath -u "$1"`") The script works properly and it could be used for all sorts of file formats. It would be useful to have a 'winemime' mechanism for this in Wine (either a script, program or shell32 code). The issue could be solved in different ways. For instance there is already some XDG MIME code in shell32 which could be extended, a winebrowser-like winelib program could be written or we could use a script. Personally I would favor either of the last two solutions. The main downside of a script is that as far as I know I need to set the whole linux path (e.g. /usr/local/bin/winemime) in the registry and this could be avoided if the tool was a winelib program as it would be in the wine path by default. Second I would like not to depend on the xds-open script on linux but have this code merged inside winemime. A winelib based winemime would be very similar to winebrowser, so if we would go the winelib way might it make sense to extend winebrowser for this? I hope to get some feedback and suggestions on how to proceed before I start writing code. Thanks, Roderick Colenbrander

2 3

Re: user32/tests: Added tests for DrawIcon and DrawIconEx (try 6)
by Joel Holdsworth 18 Jun '09

18 Jun '09

> cursoricon.c:1039: Test failed: Overlaying Mask 0 on Color 00A0B0C0 with DrawIcon. Expected 00003163 (modern), or 00003868 (legacy). Got 000020B8 from line 1109 > cursoricon.c:1039: Test failed: Overlaying Mask 1 on Color 00A0B0C0 with DrawIcon. Expected 00FFCE9C (modern), or 00FFD0A0 (legacy). Got 00FFE850 from line 1110 > cursoricon.c:1039: Test failed: Overlaying Mask 0 on Color FFA0B0C0 with DrawIcon. Expected 00003163 (modern), or 00003868 (legacy). Got 000020B8 from line 1112 > cursoricon.c:1039: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIcon. Expected 00FFCE9C (modern), or 00FFD0A0 (legacy). Got 00FFE850 from line 1113 > cursoricon.c:1039: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIcon. Expected 00003163 (modern), or 00003868 (legacy). Got 000020B8 from line 1114 > cursoricon.c:1039: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIcon. Expected 00FFCE9C (modern), or 00FFD0A0 (legacy). Got 00FFE850 from line 1115 > cursoricon.c:1171: Test failed: Overlaying Mask 0 on Color 00A0B0C0 with DrawIconEx flags 00000003. Expected 00003163 (modern) or 00003868 (legacy). Got 000020B8 from line 1256 > cursoricon.c:1171: Test failed: Overlaying Mask 1 on Color 00A0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C (modern) or 00FFD0A0 (legacy). Got 00FFE850 from line 1257 > cursoricon.c:1171: Test failed: Overlaying Mask 0 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00003163 (modern) or 00003868 (legacy). Got 000020B8 from line 1259 > cursoricon.c:1171: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C (modern) or 00FFD0A0 (legacy). Got 00FFE850 from line 1260 > cursoricon.c:1171: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00003163 (modern) or 00003868 (legacy). Got 000020B8 from line 1261 > cursoricon.c:1171: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C (modern) or 00FFD0A0 (legacy). Got 00FFE850 from line 1262 > I've tracked down the problems with an NT4 VM. The problem comes when screen depth is set to less than 32-bit. Even though I'm drawing from an icon made from 32-bit bitmaps, and making DrawIcon draw to a 32-bit DIB section, old versions of windows don't respect that, and will truncate the color data. In 16-bit only the top 5 bits of a color channels emerge ungarbled, and in 8-bit and less, the colors go via the palette (logical palette?), which knocks them completely off. The most obvious solution would be something like this as a color test: const int screen_bpp = GetDeviceCaps(hdc, BITSPIXEL); ok (result == modern_expected || /* Windows 2000 and up */ broken(result == legacy_expected) || /* Windows NT 4.0, 9X and below */ broken((result & 0x00F8F8F8) == (legacy_expected & 0x00F8F8F8) && screen_bpp == 16) || broken(result != legacy_expected && screen_bpp <= 8), How acceptable would that be?

2 3

Sugestion to Wine
by Sérgio R. da Silva 18 Jun '09

18 Jun '09

Hello to all developers of wine. My name is Sergio R. da Silva, and I sent some suggestions to improve the wine. First of all I apologize for any errors in spelling, because I am Brazilian and I do not know very well and I write in English using Google Translator to send these suggestions and also send the wrong address, if possible please move to the correct department or send me an email where I send my suggestions. Here are my suggestions: 1) I suggest that in the file. Conf of wine is possible to configure other extensions without the DLL, such as OCX, EXE, CAB, etc.. or create a tab to add these extensions, this flap could be close to the tab "Libraries" and could be called "Extensions" which add extensions without which DLL that windows USA, such as. CAB,. ini (boot.ini). bat (autoexec.bat). msc (gpedit.msc). config,. sys ( pagefile.sys, etc.). This is my first suggestion will soon send more. PS: If you have any questions about my suggestion is just send me an email to sergiordasilva17(a)gmail.com

2 1

[Bug 18786] patch
by Guy Albertelli 18 Jun '09

18 Jun '09

Hello Juan, Could you look at bug 18786 and my suggested patch to get MINITAB working again. It is a partial revert of one of your patches from 6/25/08 (see comment #7). I have verified that the associated tests (dlls/inetmib1/tests/main.c) exercise that code both pre and post revert. However the tests don't detect an error either way. I know nothing about this code. Thanks, Guy

2 2

Fate of PulseAudio in WINE
by Arthur Taylor 17 Jun '09

17 Jun '09

Recent activity in http://bugs.winehq.org/show_bug.cgi?id=10495 has caused some issues. This is also a response to http://www.winehq.org/pipermail/wine-devel/2009-April/074666.html First the background. WinePulse has been an attempt to write a winmm backend for pulseaudio for wine. Currently the primary audio system used by wine is through winmm.dll which sends messages to a backend which basically represents the MS waveOut and waveIn APIs. WaveOut works through wavehdrs, a single-linked list structure which contains a data field pointing at a buffer. Applications feed wavehdrs via waveOutWrite and receive a message when they have finished being played. wavehdrs can be formed into loops using flags. This is all simple enough except for how variable it is. Applications usually allocate a set size of wavehdrs and then use them circularly. Applications usually use when a wavehdr is returned for timing purposes rather than waveOutGetPosition. The number of wavehdrs and their sizes is entirely up to the application. There are two common problems with audio drivers implementing this system. The first is drivers which return a wavehdr as soon as it is written to output (waveesd.dr for example) as it will cause timing issues for applications when large batches of wavehdrs are returned at once. The second problem is when a windows application makes a smaller buffer of wavehdrs than the backend provides. In this case wavehdrs are not returned because they have not been played, and no more data can be written to fill the buffer because all the wavehdrs are waiting to be returned from the playback that is stalled. This can happen with alsa on top of plugins. If the buffered wavehdrs and playback buffer are very close in size sometimes the audio stutters by, oscillating to and from underrun and playback. Winepulse attempts to overcome these problems. It returns wavehdrs accurately and avoids stalls by modifying the pulseaudio server buffer size. In tests it works consistently. Most of the people I've had contact with have been positive toward development of such a backend. That said, the response from wine developers has been overwhelmingly negative. I can understand the desire for only clean and maintainable code to be considered for submissions. However, often it appears that the rejection is wholly philosophical rather than logical. Continual reports of problems are always contributed to silly users who are not using ALSA on top of direct hardware. I do not dislike either ALSA nor winealsa.drv, but I do reject this skepticism toward a world of Linux audio beyond SB-16 style "direct hardware." The arguments that PulseAudio adds latency or is not suitable for professional audio are not relevant to the issue of whether or not a pulseaudio backend for wine should be added. The _addition_ of said backend _enables_ audio in wine for those who _choose_ to use pulseaudio. I can't imagine stopping pulseaudio just so I can listen to music through foobar2000, as that would stop all my voice chats, notification sounds, and other native audio, etc. For those whom pulseaudio is not appropriate, the other backends would still exist and pulseaudio can either be disabled temporarily via pasuspender, not started or not installed. That said, latency in pulseaudio is managed and through the winepulse patch exposed to the windows application. The daemon is usually run with realtime priority and will use data buffers if the requesting application locks temporarily, allowing less worry with recording. The method of audio playback and capture through waveOut and waveIn are quite broken. Even if winealsa uses the "safe ALSA api subset" it means that the poor and varied behaviours are translated to poor and varied alsa calls (DSound HEL is an exception here.) The winepulse patch attempts to overcome these issues by buffering sanely while trying to keep applications happy in a _consistant_ way. It is true that currently whitespace is an issue with the patches in the bug report. I will work to resolve this. The file was (supposed to be) indented using 4 spaces as this was the convention in all the other audio backends. Frankly, calling the code a search and replace from ALSA to PULSE is insulting. If this is true then it is therefore true that winealsa was a search and replace from OSS to ALSA. Almost all the wine audio backends share a common ancestor. The latest patch does not contain comment out code. There has been no *useful assistance* from wine developers (re "No Fucking Way"). As for which parts of the code aren't wine-64 ready, could you please expand? A detailed, constructive response with a clear vision for where the future of audio in wine lies would be appreciated. Thanks -- Arthur Taylor art(a)ified.ca theycallhimart(a)gmail.com

12 15

[review] np2 fixup patch for ARB path
by Tobias Jakobi 17 Jun '09

17 Jun '09

You can find the current patchset here: http://www.math.uni-bielefeld.de/~tjakobi/wine/np2fixup_arb/ Of course the GLSL patchset is needed as well: http://www.math.uni-bielefeld.de/~tjakobi/wine/np2fixup_glsl/ I hope both can finally go into master, so please take a look. Going to resend the GLSL part tomorrow if they don't make it in by then. Greets, Tobias

1 0

Re: [3/6] WineD3D: Handle SM 3.0 varyings in ARB
by Henri Verbeet 17 Jun '09

17 Jun '09

2009/6/17 Stefan Dösinger <stefan(a)codeweavers.com>: > > +struct wine_rb_functions sig_tree_functions = > +{ > + sig_tree_alloc, > + sig_tree_realloc, > + sig_tree_free, > + sig_tree_compare > +}; Sorry for not mentioning this before, but you can just use wined3d_rb_alloc() etc. for that. wine_rb_init() can fail, although it should be rare enough that you might not care.

1 0

Re: [3/6] WineD3D: Handle SM 3.0 varyings in ARB
by Allan Tong 17 Jun '09

17 Jun '09

On Wed, Jun 17, 2009 at 1:37 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(strcmp(rel_reg, "**aL_emul**") == 0) > + { > + DWORD idx = ctx->aL + reg->idx; > + if(idx < 10) Seems like this should be MAX_REG_INPUT instead of 10. > + { > + strcpy(register_name, ctx->ps_input[reg->idx]); Should this be "ctx->ps_input[idx]"? > + } > + else > + { > + ERR("Pixel shader input register out of bounds: %u\n", idx); > + sprintf(register_name, "out_of_bounds_%u", idx); > + } > + } - Allan

2 1

Re: [3/6] d3dx9: Implement ID3DXFont_GetDesc
by Roderick Colenbrander 17 Jun '09

17 Jun '09

Hi Tony, + WideCharToMultiByte(CP_ACP, 0, This->desc.FaceName, -1, desc->FaceName, sizeof(desc->FaceName) / sizeof(CHAR), NULL, NULL); sizeof(desc->FaceName) / sizeof(CHAR) won't give you the length of the string (remember that sizeof is evaluated at compile time, so the value is a constant) Regards, Roderick

2 2

Re: [3/6] WineD3D: Handle SM 3.0 varyings in ARB
by Henri Verbeet 17 Jun '09

17 Jun '09

> @@ -1465,9 +1471,14 @@ struct IWineD3DDeviceImpl > const struct fragment_pipeline *frag_pipe; > const struct blit_shader *blitter; > > + struct ps_signature *pshader_signatures; > + unsigned int num_pshader_signatures; > + unsigned int pshader_signatures_size; > + DWORD ps_sig_number; > + > unsigned int max_ffp_textures, max_ffp_texture_stages; > DWORD d3d_vshader_constantF, d3d_pshader_constantF; /* Advertised d3d caps, not GL ones */ > - DWORD vs_clipping; > + DWORD vs_clipping, need_ps_signatures; > > WORD view_ident : 1; /* true iff view matrix is identity */ > WORD untransformed : 1; > @@ -2730,6 +2741,7 @@ typedef struct IWineD3DPixelShaderImpl { > BOOL color0_mov; > DWORD color0_reg; > > + DWORD input_signature_idx; Please keep this private to the ARB backend. (I.e., store these in struct shader_arb_priv.) Also, it looks like you're trying to write a binary search tree. Would you like to use wine_rb_tree instead?

2 4

Re: [6/6] d3dx9: Add tests for basic ID3DXFont functions
by Roderick Colenbrander 17 Jun '09

17 Jun '09

Hi Tony, + hr = D3DXCreateFontA(device, 12, 0, FW_DONTCARE, 0, FALSE, DEFAULT_CHARSET, OUT_DEFAULT_PRECIS, DEFAULT_QUALITY, DEFAULT_PITCH, "Arial", &font); A bunch of font tests all use Arial. On Windows this font is always around, what happens on Wine when this font isn't around? Perhaps the function fails on fonts which aren't around, so this could potentially result in a lot of test failures on Wine. Not sure what should be done if this is the case though (perhaps check at run time if the font is around or perhaps use a font which is always around as a fallback). Regards, Roderick

2 1

Re: [6/6] WineD3D: Emulate clipplanes in ARB if the NV extensions are not available
by Henri Verbeet 17 Jun '09

17 Jun '09

2009/6/17 Stefan Dösinger <stefan(a)codeweavers.com>: > + //ERR("Using texcoord %u for clip\n", ps->clipplane_emulation); C99 features generally aren't allowed inside Wine code. > + if(!device->vs_clipping) > + { > + /* See if we can use fragment.texcoord[7] for clipplane emulation > + * > + * Don't do this if it is not supported, or fragment.texcoord[7] is used > + */ > + if(This->baseShader.reg_maps.shader_version.major < 3) > + { > + for(i = GL_LIMITS(texture_stages); i > 0; i--) > + { > + if(!This->baseShader.reg_maps.texcoord[i - 1]) > + { > + This->clipplane_emulation = i; > + break; > + } > + } > + } > + else > + { > + for(i = GL_LIMITS(texture_stages); i > 0; i--) > + { > + if(!This->baseShader.reg_maps.input_registers & (1 << (i - 1))) > + { > + This->clipplane_emulation = i; > + break; > + } > + } > + } > + } This is specific to ARB as well. > + char clipplane_emulation; Using a char for this is pretty useless. If you want to save memory or cachelines, use a bitfield. The compiler will just pad the structure for alignment, and if you add other elements below it you'll have a hole, like e.g. after vpos_uniform in the same structure.

2 2

Re: [4/6] d3dx9: Implement ID3DXFont_GetDC
by Stefan Dösinger 17 Jun '09

17 Jun '09

Am Wednesday 17 June 2009 18:29:57 schrieb Tony Wasserka: > @@ -300,6 +301,12 @@ HRESULT WINAPI D3DXCreateFontIndirectW(LPDIRECT3DDEVICE9 device, CONST D3DXFONT_ > object->device=device; > object->desc=*desc; > > + object->hdc = CreateCompatibleDC(NULL); Device contexts are scarce resources, please avoid holding one all the time. Instead, create it in GetDC and destroy it in ReleaseDC. Besides this, after ReleaseDC the DC is supposed to be invalid - the only way to do this is to destroy it. (Yes, I know that's broken in wined3d too. Needs fixing there as well) You'll also have to attach the DC to the font bitmap, or whatever you have, to have it draw to the correct device. I think the current code means that the DC will draw to the screen directly, which is maybe not what you want. If the font has a d3d surface underneath, you should use d3dsurface9::GetDC

2 1

Re: [4/6] WineD3D: Don't run out of varyings because of clipplanes
by Henri Verbeet 17 Jun '09

17 Jun '09

2009/6/17 Stefan Dösinger <stefan(a)codeweavers.com>: > If I have to choose between a compile failure or disabling some clipplanes > I'll throw the clipplanes under the bus. > > If the shader is using relative addressing, look at the highest directly > addressed constant register. We know that the constant array must be at least > highest_idx+1 elements large, otherwise the shader will fail for sure. If we > see this problem coming, only enable as many clipplanes as we can fit into the > hardware limit. > > Something similar should be done in GLSL, but GLSL can only support all > clipplanes or none at all. I don't think we want this for GLSL. ARB is your own responsibility, but personally I think compile errors are much nicer to debug than the kind of graphics glitches missing clipplanes will create.

2 1

Re: Request for Patchreview
by Juan Lang 17 Jun '09

17 Jun '09

Hi Andre, > I fixed the strange problems in try8 ( > http://www.winehq.org/pipermail/wine-patches/2009-June/074340.html ) and it > still dont get commit. > can you please do a review for this try? (Just say it, if it gets disturbing > you.) This one looks fine to me. And don't worry, you're not disturbing me. --Juan

1 0

Re: [PATCH 2/2] wined3d: improved ATI Radeon HD 4xxx detection
by Stefan Dösinger 17 Jun '09

17 Jun '09

The patches seem ok to me, although I'd probably merge them into one patch(there's no point in adding unused defines)

3 2

Re: oleaut32/tests: Add some tests for [lcid] parameters.
by Paul Vriens 17 Jun '09

17 Jun '09

Huw Davies wrote: > --- > dlls/oleaut32/tests/tmarshal.c | 53 +++++++++++++++++++++++++++++++- > dlls/oleaut32/tests/tmarshal.idl | 6 +++ > dlls/oleaut32/tests/tmarshal_dispids.h | 1 + > 3 files changed, 59 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > In an effort to get a green NT4, I ran your new tests on NT4: tmarshal.c:1376: Test failed: ITypeInfo_Invoke failed with error 0x80010105 tmarshal.c:1377: Test failed: got 0 tmarshal.c:1378: Test failed: got 0 On W2K3: tmarshal.c:1376: Test failed: ITypeInfo_Invoke failed with error 0x80010105 tmarshal.c:1377: Test failed: got 0 tmarshal.c:1378: Test failed: got 0 and a maybe unrelated on W2K3 (wasn't here before): tmarshal.c:605: Test failed: Struct parameter passed by pointer corrupted On W98: tmarshal.c:1376: Test failed: ITypeInfo_Invoke failed with error 0x80010105 tmarshal.c:1377: Test failed: got 0 tmarshal.c:1378: Test failed: got 0 Am I doing something wrong here? -- Cheers, Paul.

2 3

Re: Remove division from inner loop
by Henri Verbeet 17 Jun '09

17 Jun '09

2009/6/16 Michael Abbott <michael(a)araneidae.co.uk>: > - /* The depth data is normalized, so needs to be > scaled, the stencil data isn't. */ Looks like the patch got wrapped. You'll probably want to just attach the output of git format-patch.

2 1

Re: comdlg32/tests: fix file dialog resize failures on NT4 and with tiny desk tops.
by Paul Vriens 17 Jun '09

17 Jun '09

Rein Klazes wrote: > --- > dlls/comdlg32/tests/filedlg.c | 10 +++++++--- > dlls/comdlg32/tests/rsrc.rc | 16 ++++++++++++++++ > 2 files changed, 23 insertions(+), 3 deletions(-) > Thanks Rein, This fixes the failures on my boxes. -- Cheers, Paul.

1 0

RFC: dmime: Implement the DirectMusicTool8 class factory.
by Francois Gouget 16 Jun '09

16 Jun '09

--- So all the code in dlls/dmime/tool.c was unused because nothing was calling DMUSIC_CreateDirectMusicTool8Impl(). Apparently the intent was to call it from a class factory so I looked around and came up with the following patch that implements a class factory for DirectMusicTool8. However I have never implemented a class factory before and don't know much about them. So does this patch make sense? Does the fact that we have an IID_IDirectMusicTool8 instead of a CLSID_XXX hint at something I'm missing? How come this was not done when the file was first added? That said IDirectMusicTool8Impl looks like one big stub. So if it makes more sense to remove it entirely I can do that too. dlls/dmime/dmime_main.c | 56 +++++++++++++++++++++++++++++++++++++++++++- dlls/dmime/dmime_private.h | 2 +- dlls/dmime/tool.c | 2 +- 3 files changed, 57 insertions(+), 3 deletions(-) diff --git a/dlls/dmime/dmime_main.c b/dlls/dmime/dmime_main.c index f4abddd..8bd95a9 100644 --- a/dlls/dmime/dmime_main.c +++ b/dlls/dmime/dmime_main.c @@ -729,6 +729,56 @@ static const IClassFactoryVtbl WaveTrackCF_Vtbl = { static IClassFactoryImpl WaveTrack_CF = {&WaveTrackCF_Vtbl}; /****************************************************************** + * DirectMusicTool8 ClassFactory + */ +static HRESULT WINAPI Tool8CF_QueryInterface(LPCLASSFACTORY iface,REFIID riid,LPVOID *ppobj) { + FIXME("- no interface\n\tIID:\t%s\n", debugstr_guid(riid)); + + if (ppobj == NULL) return E_POINTER; + + return E_NOINTERFACE; +} + +static ULONG WINAPI Tool8CF_AddRef(LPCLASSFACTORY iface) { + DMIME_LockModule(); + + return 2; /* non-heap based object */ +} + +static ULONG WINAPI Tool8CF_Release(LPCLASSFACTORY iface) { + DMIME_UnlockModule(); + + return 1; /* non-heap based object */ +} + +static HRESULT WINAPI Tool8CF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pOuter, REFIID riid, LPVOID *ppobj) { + TRACE ("(%p, %s, %p)\n", pOuter, debugstr_dmguid(riid), ppobj); + + return DMUSIC_CreateDirectMusicTool8Impl (riid, ppobj, pOuter); +} + +static HRESULT WINAPI Tool8CF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { + TRACE("(%d)\n", dolock); + + if (dolock) + DMIME_LockModule(); + else + DMIME_UnlockModule(); + + return S_OK; +} + +static const IClassFactoryVtbl Tool8CF_Vtbl = { + Tool8CF_QueryInterface, + Tool8CF_AddRef, + Tool8CF_Release, + Tool8CF_CreateInstance, + Tool8CF_LockServer +}; + +static IClassFactoryImpl Tool8_CF = {&Tool8CF_Vtbl}; + +/****************************************************************** * DllMain * * @@ -821,7 +871,11 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) *ppv = &WaveTrack_CF; IClassFactory_AddRef((IClassFactory*)*ppv); return S_OK; - } + } else if (IsEqualCLSID (rclsid, &IID_IDirectMusicTool8) && IsEqualIID (riid, &IID_IClassFactory)) { + *ppv = &Tool8_CF; + IClassFactory_AddRef((IClassFactory*)*ppv); + return S_OK; + } WARN("(%s, %s, %p): no interface found.\n", debugstr_dmguid(rclsid), debugstr_dmguid(riid), ppv); return CLASS_E_CLASSNOTAVAILABLE; diff --git a/dlls/dmime/dmime_private.h b/dlls/dmime/dmime_private.h index 308c2c8..d21061d 100644 --- a/dlls/dmime/dmime_private.h +++ b/dlls/dmime/dmime_private.h @@ -72,7 +72,7 @@ extern HRESULT WINAPI DMUSIC_CreateDirectMusicSegmentImpl (LPCGUID lpcGUID, LPVO extern HRESULT WINAPI DMUSIC_CreateDirectMusicSegmentStateImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter); extern HRESULT WINAPI DMUSIC_CreateDirectMusicGraphImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter); extern HRESULT WINAPI DMUSIC_CreateDirectMusicAudioPathImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter); -extern HRESULT WINAPI DMUSIC_CreateDirectMusicToolImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter); +extern HRESULT WINAPI DMUSIC_CreateDirectMusicTool8Impl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter); extern HRESULT WINAPI DMUSIC_CreateDirectMusicPatternTrackImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter); extern HRESULT WINAPI DMUSIC_CreateDirectMusicLyricsTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); diff --git a/dlls/dmime/tool.c b/dlls/dmime/tool.c index 1654bb8..81f4bca 100644 --- a/dlls/dmime/tool.c +++ b/dlls/dmime/tool.c @@ -119,7 +119,7 @@ static const IDirectMusicTool8Vtbl DirectMusicTool8_Vtbl = { }; /* for ClassFactory */ -HRESULT WINAPI DMUSIC_CreateDirectMusicobjImpl (LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter) { +HRESULT WINAPI DMUSIC_CreateDirectMusicTool8Impl(LPCGUID lpcGUID, LPVOID *ppobj, LPUNKNOWN pUnkOuter) { IDirectMusicTool8Impl* obj; obj = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicTool8Impl)); -- 1.6.3.1

2 3

Re: comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.
by Paul Vriens 16 Jun '09

16 Jun '09

Rein Klazes wrote: > With tests. Fixes bug #18516 > --- > dlls/comdlg32/filedlg.c | 6 +- > dlls/comdlg32/tests/filedlg.c | 126 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 130 insertions(+), 2 deletions(-) > Hi Rein, This is introducing test failures on at least NT4. (Just as I was down to zero :( ). Could you have a look? -- Cheers, Paul.

3 4

Request for Patchreview
by André Hentschel 16 Jun '09

16 Jun '09

Can someone please review my patch http://www.winehq.org/pipermail/wine-patches/2009-June/074195.html. Its about the Installer-Button in Appwiz.cpl Thanks Best Regards André Hentschel

4 8

How to force use of DirectX8 instead of DirectX9?
by Joerg-Cyril.Hoehle＠t-systems.com 16 Jun '09

16 Jun '09

Hi, What is the recommended way not to use Wine's DirectX9 and fall back to DirectX8 instead? Some applications list DirectX 8.1 as their minimal graphics requirement, yet they come with DirectX9 on the CD and presumably use Wine's DirectX9. The author of the screenshot at http://www.adventure-treff.de/images/bild.php?bild=/features/ankh_grafikver… shows how graphics differ a lot for Ankh, depending on whether DirectX 8 or 9 is being used in MS-Windows. Perhaps forcing use of DirectX8 can help make some applications run? (Or help locate bugs) Thanks for your help, Jörg Höhle

5 4

Re: wintrust: Implement WVTAsn1SpcSpOpusInfoDecode (resend)
by Alexandre Julliard 16 Jun '09

16 Jun '09

Juan Lang <juan.lang(a)gmail.com> writes: > No difference, just a rebase. Please let me know if I'm missing > something obvious. Fixes bug 17696. It doesn't work here: ../../../tools/runtest -q -P wine -M wintrust.dll -T ../../.. -p wintrust_test.exe.so asn.c && touch asn.ok asn.c:888: Test failed: CryptDecodeObjectEx failed: c0000005 make[2]: *** [asn.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (resend) kernel32: Fix error returns from CreateFile (at least the simple ones).
by Alexandre Julliard 16 Jun '09

16 Jun '09

Guy Albertelli <galberte(a)neo.rr.com> writes: > Changelog: > - CreateFile[AW] should return ERROR_PATH_NOT_FOUND when > STATUS_FILE_IS_A_DIRECTORY is returned from NtCreateFile and > the requested filename has a trailing \ This breaks the tests: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so profile.c && touch profile.ok profile.c:968: Test failed: Expected ERROR_ACCESS_DENIED, got 3 make[2]: *** [profile.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] [wined3d] move creation of NP2 fixup uniforms into separate loop
by Henri Verbeet 16 Jun '09

16 Jun '09

2009/6/15 Tobias Jakobi <Liquid.Acid(a)gmx.net>: > Why do you need this to be in a separate loop? Also, could you please fix your mailer to set a proper Content-Type, instead of application/octet-stream?

3 6

Re: wininet: Always create a URL cache entry.
by Jacek Caban 16 Jun '09

16 Jun '09

Hi Hans, Hans Leidekker wrote: > Fixes file downloads in ie7. > > -Hans > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 8f9f404..2721427 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -3807,8 +3807,7 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWININETHTTPREQW lpwhr, LPCWSTR lpszHeaders, > } > while (loop_next); > > - /* FIXME: Better check, when we have to create the cache file */ > - if(bSuccess && (lpwhr->hdr.dwFlags & INTERNET_FLAG_NEED_FILE)) { > + if(bSuccess) { > I think we should check at least INTERNET_FLAG_NO_CACHE_WRITE flag here. Jacek

2 1

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures
by Henri Verbeet 16 Jun '09

16 Jun '09

2009/6/14 Stefan Dösinger <stefan(a)codeweavers.com>: > +static void surface_allocate_surface(IWineD3DSurfaceImpl *This, GLenum internal, GLsizei width, GLsizei height, GLenum format, GLenum type, > + DWORD client_store_flag) { I think that's ugly. More importantly, I don't see how client storage can be enabled for one texture but not the other.

2 5

Re: [2/4] [wined3d] add ps_np2fixup_info_t structure
by Stefan Dösinger 16 Jun '09

16 Jun '09

Am Montag, 15. Juni 2009 20:23:05 schrieb Tobias Jakobi: >+ * This structure is shared between the GLSL and the ARB backend.*/ > +typedef struct ps_np2fixup_info_s { > + WORD idx[MAX_FRAGMENT_SAMPLERS]; /* indices to the real constant */ > + WORD active; /* bitfield indicating if we can apply the fixup */ > + WORD num_consts; > +} ps_np2fixup_info_t; Please don't use a typedef, just use "struct ps_np2_fixup_info" in the code. We stopped using these typedefs a while ago and are removing them as we go. Other than that, the backend specific compiled shader structs and per-shader private data make it easier to use backend specific structures which use the correct data types. I'm not sure if I remember correctly, but I think the WORD was not entirely correct for ARB, it would rather use a GLuint there(and GLSL is happy with a smaller unsigned char)

1 0

Re: wined3d: Reserve two varyings for ATI DX10 cards
by Henri Verbeet 15 Jun '09

15 Jun '09

2009/6/15 Robert Key <hpestilence(a)gmail.com>: > Changelog: > * This reserves 2 varyings for gl_FrontColor and gl_FrontSecondaryColor > for ATI DX10 cards. This should fix bug #17437 once the new fglrx > drivers get released this week. > That doesn't look quite right. gl_FrontColor and gl_FrontSecondaryColor should only be used as a fallback when we're already out of regular varyings to use. What does the shader that triggers this look like?

2 3

Trouble cloning git via http
by Juan Lang 15 Jun '09

15 Jun '09

Anyone else cloning git via http? I'm behind an annoying proxy server, and when I try to clone, I get: error: Unable to find afce86b4bc6198575bbe6046d12fd77efe01cd46 under http://source.winehq.org/git/wine.git Cannot obtain needed object afce86b4bc6198575bbe6046d12fd77efe01cd46 Just curious if anyone else has seen this or knows what I could try. Thanks, --Juan

2 2

Wine Direct Input Issue
by MD.IMAM HOSSAIN 15 Jun '09

15 Jun '09

Dear Wine Developers, The latest WINE 1.1.23 has a small regression about Direct Input. The game HITMAN 3 CONTRACTS has a problem with mouse clicking. By WINE 1.1.23 and HITMAN 3 CONTRACTS mouse clicking does not work. It is worked fine with wine 1.1.11. Since the game is a third person shooter it is not playable anymore. One final thing, latest WINE has broadened Linux Gaming Field. It now supports many old games then before which did not run before. I have tested these games: 1. Knight Rider 2 [ fully working ]. 2. Turok 2 [ fully working ]. 3. Need For Speed 4 [ fully working ]. 4. Driver [ fully working ]. 5. London Racer 2 [ fully working ]. 6. Midtown Madness 2 [ fully working ]. Thank you very much for great work. Your sincerely, MD. IMAM HOSSAIN

2 1

re: Ensure that GetSystemMenu returns valid HMENU unless bRevert specified
by Dan Kegel 15 Jun '09

15 Jun '09

Brent wrote: >This was causing some apps to crash with invalid read from address 0x4. Which apps? Is there a bug report for this? - Dan

2 1

Duplicates page: Permission denied
by Ken Sharp 15 Jun '09

15 Jun '09

Since the upgrade of Bugzilla, the duplicates page reports permission denied. http://bugs.winehq.org/duplicates.cgi Can anyone with the relevant access check the permissions? This is http://bugs.winehq.org/show_bug.cgi?id=18665

2 1

Re: winapi: Fix a $blevel / $plevel mismatch.
by Francois Gouget 15 Jun '09

15 Jun '09

Ignore this one, I patched the wrong place. On Mon, 15 Jun 2009, Francois Gouget wrote: [...] > } elsif(s/^\}//) { > $blevel--; > - if($blevel <= 0) { > + if($plevel <= 0) { > $self->_parse_c_error($_, $line, $column, "file", "} without {"); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

1 0

Re: [1/5] WineD3D: Unroll loops in ARB if needed (try 2)
by Henri Verbeet 15 Jun '09

15 Jun '09

2009/6/14 Stefan Dösinger <stefan(a)codeweavers.com>: > A few fixes from the first version: > > *) Copypaste index issues fixed > *) aL is incremeted at the end of the loop, not at the beginning > *) emulated c[aL + offset] indexing works > > The loop codepath is now tested as well, not just the rep stuff - I have a > test for aL constant indexing, its deeper down in my send queue > Since I replied to the original version of this patch... Why does get_int_const() (still) return a pointer to a static int array?

1 0

Request for comments on patch
by Erich Hoover 15 Jun '09

15 Jun '09

In an effort to come up with a (hopefully palatable) solution to a couple of bugs I've put together the attached patch. Only the first of the two issues is currently handled, though the patch paves the way for the second issue. 1) Bug #15839: (not this title) Wine does not report the manufacturer driver (for example, "nv4_disp.dll" for nVidia users) 2) Wine does not always report the correct amount of video RAM (not sure if there is a bug number for this) The approach handles graphics requests like this: "manufacturer" driver --> "OS" driver (normally winex11.drv) Where the manufacturer driver (at present) forwards all requests to the OS driver. Later additions could provide driver-specific code for returning information such as the correct amount of video RAM. Also, the manufacturer driver is skipped (reverting to the current behavior) unless "HKEY_CURRENT_USER\Software\Wine\Drivers\ReportNativeVideoDriver" is set to "Y". Note: patch makes changes to configure.ac, so cover your bases: autoheader && autoconf && ./configure && make depend && make I'm particularly interested in comments related to how the driver is selected (__wine_get_video_driver in gdi32), but all feedback is welcome. Erich Hoover ehoover(a)mines.edu

5 16

Unused code in dmime.dll
by Francois Gouget 14 Jun '09

14 Jun '09

So DMUSIC_CreateDirectMusicobjImpl() is unused. What's troubling about that is that, if my analysis is correct, it means that none of the code in dlls/dmime/tool.c is used. It seems like all that's missing is something that would let applications actually get at the IDirectMusicTool8 implementation. Could someone familiar with DCOM and/or dmime look into it? It would be a shame to strip all that unused code :-( -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ La terre est une bêta...

1 0

Command for creating git patches - possible discrepancy in Wine doc pages
by Frédéric Delanoy 14 Jun '09

14 Jun '09

Hi, I'm about to generate my first wine patches and saw 2 pages in the Wine wiki giving two different commands : - on http://wiki.winehq.org/GitWine , section 3.6. Generating a patchset to submit, it says git format-patch --stdout --keep-subject origin - on http://www.winehq.org/site/sending_patches - Generating a patch for WineHQ with Git, it says git format-patch --stdout --keep-subject --attach origin (note the additional "--attach"). Being a fresh (couple of days) git user, I just wonder : which command should I use? Frédéric Delanoy

2 1

dotests script
by chris ahrendt 14 Jun '09

14 Jun '09

Does anyone have the dotests script they could send me ... I moved to a new machine and lost the script. Went to the wiki and it fails to find it when I click on the link. I get an error stating that I am unable to add an attachment (even after logging in). Chris

3 3

Re: [PATCH] wined3d: mirror d3dresourcetype
by Stefan Dösinger 14 Jun '09

14 Jun '09

Am Sonntag, 14. Juni 2009 14:26:53 schrieb Marcus Meissner: > Hi, > > gcc 4.5trunk warned that we do not handle case 7 (D3DRTYPE_INDEXBUFFER), > so add it here too. There's a reason why this doesn't exist - WineD3D has index and vertex buffers merged, so there is no such thing as a specialized index buffer. Where does this warning occur? The code that maps D3DRTYPE to WINED3DRTYPE or vice versa should be fixed to map INDEXBUFFER to BUFFER, and take care for the reverse conversion

4 5

Re: [5/5] WineD3D: Use flags instead of bools to control shader_hw_sample
by Stefan Dösinger 14 Jun '09

14 Jun '09

Am Sonntag, 14. Juni 2009 18:34:13 schrieb Tobias Jakobi: > Why not use an enum instead of the defines? Because as far as I can see the other places that deal with flags use defines to define them, not an enum type. Specifically, I looked at the WINED3D_GLSL_SAMPLE_* flags, which have the equivalent job in glsl_shader.c Besides that, using an enum for OR-able flags seems not quite right to me. If you have something like enum flags { flag1 = 1; flag2 = 2; flag3 = 4; } "flag1 | flag3" gives a value(=5) that does not exist in the enum.

1 0

winetest data generation
by André Hentschel 14 Jun '09

14 Jun '09

I need to have a look into the sourcecode of the scripts behind "test.winehq.org". Where can i find it?

2 1

user32: Test request (cursoricon)
by Daniel Santos 13 Jun '09

13 Jun '09

I've tested this on XP, but I would like to get somebody to test on 9x and maybe even vista please and thank you. These tests are the prelude to cursoricon patches including Griswold's animated cursors & themed cursors and my fixes for LOTRO (mostly handling invalid calls properly). Thanks, Daniel

2 1

Insane git output
by Dan Kegel 13 Jun '09

13 Jun '09

I did a git pull today, and saw this: copy programs/clock/rsrc.rc => dlls/d3dx9_36/tests/resources.h (57%) copy {programs/clock => dlls/d3dx9_36/tests}/rsrc.rc (57%) create mode 100644 dlls/d3dx9_36/tests/texture.c create mode 100644 dlls/d3dx9_36/util.c create mode 100644 dlls/msctf/compartmentmgr.c create mode 100644 dlls/oleacc/oleacc_De.rc create mode 100644 dlls/windowscodecs/Makefile.in rename programs/clock/rsrc.rc => dlls/windowscodecs/main.c (57%) Wha? Those are some crazy renames/copies...

2 1

Posting deletions on AppDB
by Vitaliy Margolen 13 Jun '09

13 Jun '09

I'm having a problem with these posts delition by Ken Sharp. I do not see anything wrong there. 'wine start file.msi' is _the_ correct way to "run" msi files (that's what happenes when you double click). Even if there was something wrong, removing post is a bad thing to do. Please just explain in replay why it's wrong. Or just ignore it. Vitaliy. Subject: [AppDB] Comment for Steam All Versions deleted From: AppDB <appdb-noreply(a)winehq.org> Date: Sat, 13 Jun 2009 09:41:07 -0500 To: appdb-noreply(a)winehq.org Comment for Steam All Versions deleted ------------------------------------------------------- http://appdb.winehq.org/objectManager.php?sClass=version&iId=1554 This comment was made on 2009-06-13 by Felix Zielcke Subject: can't install Steam With current git HEAD (45629dc050f46988c23ded35ad18bbd8c63e4e65) I can't install steam: $ wine start SteamInstall.msi fixme:ntoskrnl:KeInitializeSpinLock stub: 0x657d74 fixme:exec:SHELL_execute flags ignored: 0x00000100 fz@fz:/win2/downloads/spiele$ fixme:msi:MSI_OpenDatabaseW open failed r = 80030050 for L"C:\\windows\\temp\\msi339.tmp" ~/.wine/drive_c/windows/temp/ does exist. The action was performed by Ken Sharp Reasons given Learn how to use Wine! wine msiexec /i blah.msi Best regards. The AppDB team http://appdb.winehq.org/ If you don't want to receive any other e-mail, please change your preferences: http://appdb.winehq.org/preferences.php Subject: [AppDB] Comment for Steam All Versions deleted From: AppDB <appdb-noreply(a)winehq.org> Date: Sat, 13 Jun 2009 11:17:37 -0500 To: appdb-noreply(a)winehq.org Comment for Steam All Versions deleted ------------------------------------------------------- http://appdb.winehq.org/objectManager.php?sClass=version&iId=1554 This comment was made on 2009-06-13 by Felix Zielcke Subject: The action was performed by Ken Sharp Reasons given Learn how to use Wine! wine msiexec /i blah.msi I suggest you learn how to read >From THIS page: HOWTO: Installing and Running Steam 3. # Download Steam installer from http://www.steampowered.com and run it with wine start SteamInstall.msi and even your wine msiexec /i didn't work: $ wine msiexec /i SteamInstall.msi fixme:msi:MSI_OpenDatabaseW open failed r = 80030050 for L"C:\\windows\\temp\\msi120.tmp" The action was performed by Ken Sharp Reasons given Don't bother posting nonsense. Best regards. The AppDB team http://appdb.winehq.org/ If you don't want to receive any other e-mail, please change your preferences: http://appdb.winehq.org/preferences.php

2 4

CreateFileA with /dev/random as WinNT filename
by Karl Vogel 13 Jun '09

13 Jun '09

In ran into a problem with a game, Dark Age of Camelot, where it locked up after logging into the game. After some tracing it became apparent that the game was trying to read bytes from /dev/random, but due to me working remotely on the computer, not enough entropy was generated which stalled the game. I was just wondering if it would be acceptable to specifically check for /dev/random in wine_nt_to_unix_file_name() and turn that into /dev/urandom ?! Small snippet of the login.dll executable code: .text:0042C150 sub_42C150 proc near ; CODE XREF: sub_4267E0+5B0C p .text:0042C150 .text:0042C150 arg_0 = dword ptr 8 .text:0042C150 arg_4 = dword ptr 0Ch .text:0042C150 .text:0042C150 push esi .text:0042C151 push offset aRb ; "rb" .text:0042C156 push offset aDevRandom ; "/dev/random" .text:0042C15B call _fopen .text:0042C160 mov esi, eax .text:0042C162 add esp, 8 .text:0042C165 test esi, esi .text:0042C167 jz short loc_42C185 .text:0042C169 push 0 ; size_t .text:0042C16B push 4 ; int .text:0042C16D push 0 ; char * .text:0042C16F push esi ; FILE * .text:0042C170 call _setvbuf .text:0042C175 add esp, 10h .text:0042C178 test eax, eax .text:0042C17A jz short loc_42C189 .text:0042C17C push esi ; FILE * .text:0042C17D call _fclose .text:0042C182 add esp, 4 .text:0042C185 .text:0042C185 loc_42C185: ; CODE XREF: sub_42C150+17 j .text:0042C185 xor eax, eax .text:0042C187 pop esi .text:0042C188 retn

2 2

Re: PATCH - enhance the help message in expand
by Detlef Riekenberg 13 Jun '09

13 Jun '09

On Do, 2009-06-11 at 11:16 -0400, Steven Edwards wrote: > + "expand [-r] source destination\n" > + "expand -r source [destination]\n" > + "expand -D source.cab [-F:Files]\n" > + "expand source.cab -F:files destination\n" > + "\n" > + " -r Rename expanded files.\n" > + " If the -r option is given to a cabinet > containing multiple\n" > + " files, the call will fail.\n" > + " -D Display list of files in source.\n" > + " (This option is currently unimplemented)\n" > + " source Source file specification. Wildcards may be > used.\n" > + " -F:Files Name of files to expand from a .CAB.\n" > + " (This option is currently unimplemented)\n" > + " Destination Destination file | path specification.\n" > + " Destination may be a directory.\n" > + " If Source is multiple files and -r is not > specified,\n" > + " Destination must be a directory.\n" Mixing the case looks strange. (Files/files, Destination/destination) Please move the helpmsg to a resource, to make translations possible. -- By by ... Detlef

2 1

Re: [mlang/tests] Fix a test failure on Win95
by Paul Vriens 13 Jun '09

13 Jun '09

Paul Vriens wrote: > Hi, > > It's only my Win95 box that has this failure (the other ones don't even > run these particular tests). > > Changelog > Fix a test failure on Win95 > This also fixes this same test failure on some W2K boxes, so it looks like an IE version specific issue (as already indicated in the test). -- Cheers, Paul.

1 0

Re: user32: Add a test for PeekMessage((HWND)-1), make it pass under Wine.
by Paul Vriens 13 Jun '09

13 Jun '09

Dmitry Timoshkov wrote: > --- > dlls/user32/message.c | 2 + > dlls/user32/tests/msg.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++ > server/queue.c | 10 +++++++- > 3 files changed, 65 insertions(+), 1 deletions(-) > Hi Dmitry, These new tests introduce some failures on Win9x. Could you have a look? > + ok(ret && msg.hwnd == hwnd && msg.message == WM_USER+1 && > + msg.wParam == 0x1234 && msg.lParam == 0x5678, > + "got ret %d hwnd %p msg %04x wParam %08lx lParam %08lx instead of TRUE/0/WM_USER/0x1234/0x5678\n", > + ret, msg.hwnd, msg.message, msg.wParam, msg.lParam); This ok() message is also not totally correct as the msg.hwnd should not be 0 but hwnd, I guess. -- Cheers, Paul.

3 9

OS X build broken
by Austin English 13 Jun '09

13 Jun '09

AJ, looks like your 'configure: Detect the appropriate form for the __ASM_GLOBAL_FUNC macro.' patch broke the compile on OS X. Could you have a look? gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -I/Users/austin/wine-deps/usr/include -I/Users/austin/wine-deps/usr/include/libxml2 -I/Users/austin/wine-deps/usr/include/libxslt -I/Users/austin/wine-deps/usr/include/libpng12 -I/Users/austin/wine-deps/usr/include/gphoto2 -I/Users/austin/wine-deps/usr/include/sane -I/Users/austin/wine-deps/usr/include -o writer.o writer.c ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -foversion.res version.rc ../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../.. -shared ./riched20.spec caret.o clipboard.o context.o editor.o list.o paint.o para.o reader.o richole.o row.o run.o string.o style.o table.o txthost.o txtsrv.o undo.o wrap.o writer.o version.res -o riched20.dll.so -luuid -lole32 -loleaut32 -limm32 -luser32 -lgdi32 -lkernel32 ../../libs/port/libwine_port.a -L/Users/austin/wine-deps/usr/lib ld: absolute addressing (perhaps -mdynamic-no-pic) used in _itextHostStdcallVtbl from txthost.o not allowed in slidable image collect2: ld returned 1 exit status winegcc: gcc failed make[2]: *** [riched20.dll.so] Error 2 make[1]: *** [riched20] Error 2 make: *** [dlls] Error 2 -- -Austin

3 5

Wine - 1.1.23
by Noah Fields 12 Jun '09

12 Jun '09

configure: WARNING: mach-o/dyld_images.h: present but cannot be compiled configure: WARNING: mach-o/dyld_images.h: check for missing prerequisite headers? configure: WARNING: mach-o/dyld_images.h: see the Autoconf documentation configure: WARNING: mach-o/dyld_images.h: section "Present But Cannot Be Compiled" configure: WARNING: mach-o/dyld_images.h: proceeding with the preprocessor's result configure: WARNING: mach-o/dyld_images.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ##

2 1

Re: Disable forum edits
by James Mckenzie 12 Jun '09

12 Jun '09

>Subject: Re: Disable forum edits > >On Fri, Jun 12, 2009 at 12:51 PM, Jeremy Newman<jnewman(a)codeweavers.com> wrote: >> Editing disabled. >> >> -Newman > >Thanks! > +1 James

1 0

Disable forum edits
by Austin English 12 Jun '09

12 Jun '09

Users are editing their posts when asked for terminal output/wine version/etc. Those of us on the mailing list side don't get this information. -- -Austin

6 9

Re: shell32: update file type associations when requested
by Detlef Riekenberg 12 Jun '09

12 Jun '09

On Do, 2009-06-11 at 20:52 +0200, Damjan Jovanovic wrote: > + > + if (wEventId & SHCNE_ASSOCCHANGED) > + { > + TRACE("refreshing file type associations"); > + RefreshFileTypeAssociations(); > + } "\n" is missing in the TRACE. The helper function looks like an API call. Please use lcase. -- By by ... Detlef

1 0

Which virtualization software should I choose
by Paul Vriens 12 Jun '09

12 Jun '09

Hi, Just upgraded to Fedora 11 and (yet again) having issues with VMware Workstation. VMware still doesn't support Fedora (as a host) and I'm tired of fixing/patching things, again and again. I need to run several Windows versions (95 up to Vista for now) for our winetest and I really like the snapshot possibilities of VMware. Suggestions, recommendations? -- Cheers, Paul.

8 16

What does this code mean?
by LiuYuanxi 12 Jun '09

12 Jun '09

In dlls/ntdll/file.c: line 362 if ((status = server_get_unix_fd( fileio->io.handle, FILE_READ_DATA, &fd, &needs_close, NULL, NULL ))) break; Is this if always true? _________________________________________________________________ MSN 表情魔法书，改变你的对话时代！ http://im.live.cn/emoticons/

2 1

Re: Alexandre Julliard : configure: Detect the appropriate form for the __ASM_GLOBAL_FUNC macro.
by Steven Edwards 12 Jun '09

12 Jun '09

Hi, On Thu, Jun 11, 2009 at 11:54 AM, Alexandre Julliard<julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: 857f1e0924f23865038a608ee6834ef524371f20 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=857f1e0924f23865038a608ee… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Jun 11 16:32:42 2009 +0200 > > configure: Detect the appropriate form for the __ASM_GLOBAL_FUNC macro. I believe this patch is causing a problem for me on OS X Leopard gcc version 4.0.1 (Apple Inc. build 5465). When I try to compile riched20 with a clean tree at HEAD I am getting this ld: absolute addressing (perhaps -mdynamic-no-pic) used in _itextHostStdcallVtbl from txthost.o not allowed in slidable image collect2: ld returned 1 exit status winegcc: gcc failed make: *** [riched20.dll.so] Error 2 Is the __ASM_GLOBAL_FUNC stdcall wrapper in txthost.c just borked? Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: RDo we still need the regression test for 1.1.23 ?
by Ben Klein 12 Jun '09

12 Jun '09

2009/6/12 chris ahrendt <celticht32(a)yahoo.com>: > > Ben Klein wrote: >> 2009/6/11 chris ahrendt <celticht32(a)yahoo.com>: >> >>> to see what patch caused the failure on non NVIDIA cards? >>> >> >> Where's the rest of your message? Oh, I see, it's in the subject. >> >> Wasn't there already a thread about this? >> >> Back on topic, if it is definitely a regression then a regression test >> on bugzilla will be useful. Or at least, some information on how to >> reproduce it. >> >> >> > The test is easy... use a ATI card... and run 1.1.23 with or without > the Registry value to set it back to the old way of rendering. Not so easy if you don't have an ATI card, or if you don't know what apps cause the error. Wine Notepad seems to be working fine for me, no crashes.

1 0

RDo we still need the regression test for 1.1.23 ?
by chris ahrendt 12 Jun '09

12 Jun '09

to see what patch caused the failure on non NVIDIA cards? Chris

2 1

Fwd: RDo we still need the regression test for 1.1.23 ?
by Danila Sentiabov 11 Jun '09

11 Jun '09

Forwarding to mailing list... ---------- Forwarded message ---------- From: Danila Sentiabov <dsent.zen(a)gmail.com> Date: Thu, Jun 11, 2009 at 23:02 Subject: Re: RDo we still need the regression test for 1.1.23 ? To: chris ahrendt <celticht32(a)yahoo.com> I didn't follow the topic, but as far as I know, if there is a regression it's surely begging for regression test. On which application the failure can be reproduced? On Wed, Jun 10, 2009 at 22:47, chris ahrendt <celticht32(a)yahoo.com> wrote: > > to see what patch caused the failure on non NVIDIA cards? > > > Chris > -- Best regards, Danila Sentiabov aka dsent -- Best regards, Danila Sentiabov aka dsent

1 0

Re: [Bugzilla]: Refuse to accept comments with big number of logs / back traces
by Vitaliy Margolen 11 Jun '09

11 Jun '09

Vitaliy Margolen wrote: > The limits are: > 20 lines for logs (fixme, trace, err, warn) > 10 lines for back traces > --- > Bugzilla/Bug.pm | 7 +++++++ > template/en/default/global/user-error.html.tmpl | 4 ++++ > 2 files changed, 11 insertions(+), 0 deletions(-) > So who is the one to commit this? Alexandre? Jeremy? Vitaliy.

5 7

Re: winemenubuilder: generate new menus in the right directory
by Alexandre Julliard 11 Jun '09

11 Jun '09

Damjan Jovanovic <damjan.jov(a)gmail.com> writes: > @@ -882,7 +882,11 @@ static BOOL write_menu_file(const char *filename) > > while (1) > { > + char *tmpdir = getenv("TMPDIR"); > + unsetenv("TMPDIR"); > tempfilename = tempnam(xdg_config_dir, "_wine"); > + if (tmpdir) > + setenv("TMPDIR", tmpdir, 1); That's ugly. You should use mkstemps() or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fix incorrect check in WCMD_HandleTildaModifiers().
by Alexandre Julliard 11 Jun '09

11 Jun '09

Gerald Pfeifer <gerald(a)pfeifer.com> writes: >>= '0' || <= '9' always is true. :-) This patch fixes it, and > avoids two just hand coded checks altogether. > > Gerald > > ChangeLog: > Fix incorrect check in WCMD_HandleTildaModifiers(). > Use isdigit() instead of hand-coding this check. Using isdigit() on a Unicode char is not a good idea (and in this case isdigitW() wouldn't be a good idea either). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: get rid of glext.h
by Detlef Riekenberg 11 Jun '09

11 Jun '09

On Mi, 2009-06-10 at 21:56 +0200, Roderick Colenbrander wrote: > -#ifdef HAVE_GL_GLEXT_H > -# include <GL/glext.h> > -#endif The same code is used in winex11.drv/opengl.c Can this also be removed? When that's the case, then "GL/glext.h" can be removed from AC_CHECK_HEADERS in configure.ac -- By by ... Detlef

2 1

Re: [2/5] WineD3D: Implement loops with the NV extensions
by Allan Tong 11 Jun '09

11 Jun '09

> + if(vshader) > + { > + struct shader_arb_ctx_priv *priv = ins->ctx->backend_data; > + struct list *e = list_head(&priv->control_frames); > + struct control_frame *control_frame = LIST_ENTRY(e, struct control_frame, entry); > + > + if(priv->loop_depth > 1) shader_addline(buffer, "PUSHA aL;\n"); > + > + shader_addline(buffer, "ARLC aL, %s.xywz;\n", src_name); > + shader_addline(buffer, "BRA loop_%u_end (LE.x);\n", control_frame->loop_no); > + shader_addline(buffer, "loop_%u_start:\n", control_frame->loop_no); > + } Nested loops still don't work here. You need NV_vertex_program3 in order to use PUSHA and POPA. - Allan

3 3

Re: opengl32: get rid of glext.h
by Austin English 10 Jun '09

10 Jun '09

On Wed, Jun 10, 2009 at 2:56 PM, Roderick Colenbrander<thunderbird2k(a)gmail.com> wrote: > Hi, > > Since opengl32 doesn't export opengl 1.2 functions anymore from the > spec file we don't need glext.h anymore. This also helps compilation > on OSX. > > Roderick Works great. Thanks for the quick work Roderick! -- -Austin

1 0

Re: wldap32: fix a compiler warning on Mac OS X
by Stefan Leichter 10 Jun '09

10 Jun '09

Am Tuesday 09 June 2009 23:46:51 schrieb Austin English: > Cast was removed by d576c2d9342e769c01fb99c0cc200a0bc4b9cded, but > causes a compiler warning on OS X. The same cast is used ~20 lines > later. You forgot the patch -- Stefan

3 2

Re: windowscodecs: add stub implementation of IWICImagingFactory
by Vincent Povirk 10 Jun '09

10 Jun '09

This is wrong. Don't commit it. Vincent Povirk On Wed, Jun 10, 2009 at 3:08 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > > > >

1 0

Re: [4/4] ddraw: Add lock/unlock test.
by Stefan Dösinger 10 Jun '09

10 Jun '09

Am 10.06.2009 um 11:06 schrieb Rico Schüller: > > +/* See comment in dlls/d3d9/tests/visual.c for general guidelines */ I guess this was copied from dlls/ddraw/tests/visual.c, but doesn't make sense for tests that don't read back rendering results. Otherwise the patches look ok to me.

2 1

dlls/winedos/int10.c
by Gerald Pfeifer 10 Jun '09

10 Jun '09

In dlls/winedos/int10.c we currently have the following code VGA_SetBright((BL_reg(context) & 0x10) && 1); which I am not sure I understand. Is the purpose of this to only pass one of 0 or 1 to VGA_SetBright? If so, I guess I'd find "... ? 1 : 0" more intuitive, and it's only three characters more, or "!= 0" at least. Thoughts? Gerald

1 0

Default Bugzilla search does not show resolved bugs
by Ken Sharp 10 Jun '09

10 Jun '09

From http://bugs.winehq.org/show_bug.cgi?id=18790 "The default search (the search box at the top of this page) does not include closed bugs (rightly so), but it also does not include resolved bugs. This leads to duplicates that could be avoided." "This is for admin to configure in Administration->Parameters->Query Defaults->defaultquery. Add to the front of it: bug_status=RESOLVED&" Anyone with admin access that can make this change? Thanks, Ken.

3 2

Add stable Wine versions back to the AppDB
by Ken Sharp 10 Jun '09

10 Jun '09

See http://bugs.winehq.org/show_bug.cgi?id=15419 The AppDB is currently set up to query Bugzilla for its six latest Wine versions. Unfortunately this does not include the latest stable version of Wine (currently 1.0.1, and in the future 1.2 will also be omitted). A change to how the AppDB works is needed to add 1.0.1 back to the list. As 1.0.1 is listed as "stable", it would make sense that distros (Ubuntu for example) will provide support for this version only. As discussed in the bug, not having this version in the AppDB does not stop users from submitting test results anyway using any version they feel like selecting, and therefore reporting, often incorrectly (due to regressions), that apps run fine on later versions of Wine. As also discussed, if an Admin catches such test results in the queue before they are accepted, they can be rejected, but maintainers can submit whatever results they wish without admin approval. Test results are rejected daily, so this is a problem. Attached is a patch that hopefully looks something like what needs to be added to the AppDB code. This was made by me, who has never used PHP before and have given myself about an hour's "training" to figure it out. It is probably wrong. Could anybody offer some help with this issue? Thanks, Ken.

2 2

Re: (resend, 2nd) kernel32: Implement QueryFullProcessImageNameA (3rd try)
by Alexandre Julliard 10 Jun '09

10 Jun '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > Am Thursday 04 June 2009 12:49:58 schrieb Alexandre Julliard: >> >> I'd expect that error to be a side effect of WideCharToMultiByte, which >> is most likely what you want to use here. Also you have to handle buffer >> overflows correctly, with test cases. > > If you like to see more test cases for the buffer overflow, please tell me > what you like to see tested The test isn't very convincing. For instance to show that the size is not modified you should set it to something that's clearly different, not to the same length you got in the previous call. Also you should check that the length matches the contents of the buffer, with/without terminating null as the case may be. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: fix a compiler warning on Mac OS X
by Roderick Colenbrander 10 Jun '09

10 Jun '09

Actually I need to fix opengl32 properly. For some reason opengl32 is opengl 1.2 while it should be 1.1. Then GL_GLEXT_PROTOTYPES is not needed at all for compiling opengl32. Roderick On Wed, Jun 10, 2009 at 12:18 AM, Austin English<austinenglish(a)bordeauxgroup.com> wrote: > GL_GLEXT_PROTOTYPES is defined in GL/gl.h on Mac. Other #ifdef methods > end up breaking compilations elsewhere. > > -- > -Austin > > > >

2 2

Re: user32/tests: Add more intensive tests for SetCursor.
by Austin English 09 Jun '09

09 Jun '09

On Tue, Jun 9, 2009 at 5:13 PM, Daniel Santos<javatroubadour(a)yahoo.com> wrote: > > Hello! This is a prelude to other cursor patches to follow (both Griswold's & my work). As requested, I have replaced the __FILE_SPOT with the standard ok_(file,line) mechanism (looks much better to me). I've removed the windows version checking from tests and last error checking on success, although I have reservations about it (mostly the later). Forgot patch. -- -Austin

1 0

Re: gdiplus: Add stubs for GdipGetVisibleClipBoundsI, GdipDrawDriverString & GdipMeasureDriverString
by Nikolay Sivov 09 Jun '09

09 Jun '09

Ken Sharp wrote: > These stubs stop three crashes in Photoshop CS4. > >From 4e5dd892a7a577001072fd7701467c262c483b1f Mon Sep 17 00:00:00 2001 > From: Ken Sharp <kennybobs(a)o2.co.uk> > Date: Tue, 9 Jun 2009 21:48:05 +0100 > Subject: [PATCH] gdiplus: Add stubs for GdipGetVisibleClipBoundsI, GdipDrawDriverString & GdipMeasureDriverString > > This fixes three crashes in Photoshop CS4. > --- > dlls/gdiplus/gdiplus.spec | 6 +++--- > dlls/gdiplus/graphics.c | 35 ++++++++++++++++++++++++++++++++++- > 2 files changed, 37 insertions(+), 4 deletions(-) > +GpStatus WINGDIPAPI GdipMeasureDriverString(GpGraphics *graphics, GDIPCONST UINT16 *text, INT length, > + GDIPCONST GpFont *font, GDIPCONST PointF *positions, > + INT flags, GDIPCONST GpMatrix *matrix, RectF *boundingBox) > +{ > + FIXME("(%p %p %d %p %p %d %p %p): stub\n", graphics, text, length, font, positions, flags, matrix, boundingBox); > + return FALSE; > +} > + You should return NotImplemented.

1 0

How do I actually write a testcase for a 16-bit API ?
by Alex Villacís Lasso 09 Jun '09

09 Jun '09

I recently filed http://bugs.winehq.org/show_bug.cgi?id=18734 in which I showed that DlgDirList is behaving incorrectly for 16-bit apps. I also included a test program compiled with the Watcom C compiler, as well as a patch. Then a comment appeared saying that it should be possible to create a testcase for this API. So I tried. At first, I thought that since this was a 16-bit API, I should be adding -Wb,--subsystem,win16 to the Makefile. However, this results in the linker complaining that it cannot find WinMain16. So I removed it. Also, I had undefined link-time references to SendMessage16 and similar (because I want everything to go through the 16-bit APIs, else the whole point of the test is lost), so I had to manually add them to the spec files for kernel32 and user32. But after doing this and getting a test program, an attempt to create the window out of the registered class fails and triggers an assertion. I have no examples of previous 16-bit tests (as opposed to 16-bit Wine dlls) to draw upon, so I don't know how to proceed correctly to test a 16-bit API in a way that convinces everyone that the patch is correct. What do you think of this? -- perl -e '$x=2.3;printf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

5 6

How is 0.0.0.0 handled in Wine?
by Austin English 09 Jun '09

09 Jun '09

Howdy all, Doing some testing with PuTTY, I've noticed some strange behavior. I've got windows XP in a VM, and when comparing behavior to Wine, I noticed some inconsistencies with respect to the '0.0.0.0' invalid address. Windows: Putty -> 0.0.0.0: throws an error "Network error: Cannot assign requested address" ping (in cmd.exe): D:\appinstall>ping 0.0.0.0 Pinging 0.0.0.0 with 32 bytes of data: Destination specified is invalid. Destination specified is invalid. Destination specified is invalid. Destination specified is invalid. Ping statistics for 0.0.0.0: Packets: Sent = 4, Received = 0, Lost = 4 (100% loss), Wine: Putty -> 0.0.0.0 route to localhost, login succeeds (Not sure if it's routing to localhost or 127.0.0.1) FWIW, Ubuntu: ssh -> 0.0.0.0: routes to localhost, where I've got sshd running, connects fine. ping -> 0.0.0.0 routes to 127.0.0.1, succeeds Seems to me to be a bug, i.e., Wine shouldn't be able to use 0.0.0.0. It seems that we're simply passing this on to the host os, which is then routing it back to localhost. Perhaps we need to catch 0.0.0.0 as a special case and refuse? Grepping in the source code for 0.0.0.0 only shows a few hits: comctl32 (unrelated), rpcrt4 (appears unrelated) and ws2_32 (but only in the tests, not in the implementation). -- -Austin

5 13

Latest git fails compiling
by Uwe Bonnes 09 Jun '09

09 Jun '09

Hello, on a fresh tree check out and compiled successfully yesterday (090608) and updated today(090609), compile fails with: make[1]: Entering directory `/media/sda8/sdb8/spare/bon/Wine/wine-git/include' ../tools/widl/widl -I. -I. -I../include -I../include \ -h -H activaut.h activaut.idl ../tools/widl/widl -I. -I. -I../include -I../include \ -h -H activdbg.h activdbg.idl ../tools/widl/widl -I. -I. -I../include -I../include \ -h -H activscp.h activscp.idl oaidl.idl:121: error: parameter 'pvData' of (null) 'tagSAFEARRAY' \ cannot derive from void * make[1]: *** [activscp.h] Fehler 1 make[1]: Leaving directory `/media/sda8/sdb8/spare/bon/Wine/wine-git/include' This is on Suse 11.1, x86-64. I have not seens this reported before. Any hints for fixing (perhaps my setup)? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 5

Add-stub-for-IoOpenDeviceRegistryKey-needed-for-l.patch
by Uwe Bonnes 09 Jun '09

09 Jun '09

Appended stup is needed for libusb-win32-0.1x -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- >From 7216b1e26b9cbd3d4bb7eaa096757ad11d0b77b5 Mon Sep 17 00:00:00 2001 From: Uwe Bonnes <bon(a)hertz.ikp.physik.tu-darmstadt.de> Date: Tue, 9 Jun 2009 16:41:09 +0200 Subject: Add stub for IoOpenDeviceRegistryKey(), needed for libusb-win32-0.1.2 --- dlls/ntoskrnl.exe/ntoskrnl.c | 11 +++++++++++ dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 2 +- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 5a043e5..99c2847 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -2493,6 +2493,17 @@ NTSTATUS WINAPI PsSetCreateThreadNotifyRoutine( PCREATE_THREAD_NOTIFY_ROUTINE No /*********************************************************************** + * IoOpenDeviceRegistryKey (NTOSKRNL.EXE.@) + */ +NTSTATUS WINAPI IoOpenDeviceRegistryKey( PDEVICE_OBJECT DeviceObject, +ULONG DevInstKeyType, ACCESS_MASK DesiredAccess, PHANDLE DevInstRegKey) +{ + FIXME( "stub:\n"); + return STATUS_SUCCESS; +} + + +/*********************************************************************** * MmGetSystemRoutineAddress (NTOSKRNL.EXE.@) */ PVOID WINAPI MmGetSystemRoutineAddress(PUNICODE_STRING SystemRoutineName) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec index 52efd92..cda9230 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec @@ -409,7 +409,7 @@ @ stdcall IoIsWdmVersionAvailable(long long) @ stub IoMakeAssociatedIrp @ stub IoOpenDeviceInterfaceRegistryKey -@ stub IoOpenDeviceRegistryKey +@ stdcall IoOpenDeviceRegistryKey (long long long long) @ stub IoPageRead @ stub IoPnPDeliverServicePowerNotification @ stub IoQueryDeviceDescription -- 1.6.0.2

1 0

Re: wine-patches Digest, Vol 47, Issue 40
by Piotr Caban 09 Jun '09

09 Jun '09

> Message: 2 > Date: Thu, 04 Jun 2009 22:37:48 +0200 > From: Piotr Caban <piotr.caban(a)gmail.com> > Subject: jscript: Added Date_getFullYear and Date_getUTCFullYear > implementation (3/7) > To: wine-patches(a)winehq.org > Message-ID: <4A28309C.9000401(a)gmail.com> > Content-Type: text/plain; charset="utf-8" > > --- > dlls/jscript/date.c | 73 > ++++++++++++++++++++++++++++++++++++++++++-- > dlls/jscript/tests/api.js | 9 +++++ > 2 files changed, 78 insertions(+), 4 deletions(-) Whats wrong with this patch? All the date expressions (e.g. day_from_year) are copied from ECMA-262 standard specification. Because of the date range it can be keep in double without error. Piotr Caban

2 1

Re: mlang/tests: [Patch 2] Skip some tests on systems, that do not support CP_UTF8
by Alexandre Julliard 09 Jun '09

09 Jun '09

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1164,6 +1165,14 @@ static void test_GetRfc1766Info(IMultiLanguage2 *iML2) > ok(!lstrcmpA(rfc1766A, info_table[i].rfc1766), > "#%02d: got '%s' (expected '%s')\n", i, rfc1766A, info_table[i].rfc1766); > > + if (!localenameA[0]) { > + /* old win95 systems do not support CP_UTF8 */ > + if (!i) > + win_skip("CP_UTF8 not supported on this system\n"); > + > + continue; > + } You should store the table in Unicode instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Prevent second loading of a library with specified path.
by Alexandre Julliard 09 Jun '09

09 Jun '09

Alexander Morozov <amorozov(a)etersoft.ru> writes: > Changelog > Prevent second loading of a library with specified path > > This patch fixes bug #18775. I tested WinXP and Win2003. > > When a library have long name (> 8 symbols before extension) an application > can run LoadLibrary(long name) and later LoadLibrary(8.3 name). > In some cases Windows will load image second time, in other it will return > pointer to already loaded image. > I found that Windows does not load library second time in these cases: > 1) c:\dir\libliblib.dll and c:\dir\LIBLIB~1.DLL > 2) \dir\libliblib.dll and \dir\LIBLIB~1.DLL > 3) .\libliblib.dll and .\LIBLIB~1.DLL > 4) dir\libliblib.dll and dir\LIBLIB~1.DLL > and load it in cases: > 5) libliblib.dll and LIBLIB~1.DLL > 6) c:libliblib.dll and c:LIBLIB~1.DLL This should most likely be done in ntdll. Also please add tests for these different cases. -- Alexandre Julliard julliard(a)winehq.org

3 3

re: How do I actually write a testcase for a 16-bit API ?
by Dan Kegel 09 Jun '09

09 Jun '09

See also http://lists.debian.org/debian-legal/2006/07/msg00007.html I kind of doubt it will ever make it in to ubuntu. When I tried building win16 binaries with the Linux version, there were lots of path problems. That was two years ago, but I wouldn't be surprised if they're still there. These two things together make me suspect that installing the windows version in Wine is the way to go. We could make a script that does that in an alternate prefix and provides wrapper scripts that hide the wine-ness of it to some extent, maybe. That could be done as a stopgap while the test suite is refreshed and gotten ready to add into the wine tree. Once that's far enough along, it might then be worth looking at getting the linux version working and into a PPA. Or vice versa. Wish I had time to play with this stuff. I would really be happy if somebody got the win16 test suite into the wine tree! - Dan

1 0

Re: wine-devel Digest, Vol 47, Issue 32
by chris ahrendt 08 Jun '09

08 Jun '09

Did we find out what the regression is for 1.1.23 that caused the ATI and other non NVIDIA cards to start failing? Chris

1 0

Re: riched20/tests: fix test for vista
by Paul Vriens 08 Jun '09

08 Jun '09

André Hentschel wrote: > Vista turns the "(WCHAR)1234" into a "(unsigned char)1234". > This causes error on vista machines<SP2: > http://test.winehq.org/data/7aeffc442cc1b9a454f1ff7d7b3175b4bba88b05/vista_… > > editor.c:3249: Test failed: EM_GETPASSWORDCHAR returned Ò (210) when set > to 'x', instead of x (120) > --- > dlls/riched20/tests/editor.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi André, Is there anything special about this box? Could it be that the locale plays a role in this. I'm asking as my Vista box (and several others seen on test.winehq.org) doesn't have this issue. -- Cheers, Paul.

1 0

Re: d3d9: Add DF16 support
by Henri Verbeet 08 Jun '09

08 Jun '09

2009/6/7 Frank Richter <frank.richter(a)gmail.com>: > As far as I could gather DF16 is the "ATI way" of getting a renderable > 16 bit depth texture. Without knowing much about the actual format, DF16 implies this should be a floating point format, similar to the ones provided by ARB_depth_buffer_float. Also, could you please add this at the same location as the other depth formats?

5 9

Re: Try2: Website: Remove GIMP Fun Project
by Paul Vriens 08 Jun '09

08 Jun '09

Ken Sharp wrote: > Disregard first patch.. this one makes a little more sense. > > Ken Sharp wrote: >> See Bug 7976. Apparently this has already been done. >> >> >> ------------------------------------------------------------------------ >> >> > > > ------------------------------------------------------------------------ > > We have that same (or actually newer) page on the wiki: http://wiki.winehq.org/Fun_Projects Doesn't it make more sense to link this entire page to the wiki? -- Cheers, Paul.

2 1

Re: [3/3] windowscodecs: add stub implementation of IWICImagingFactory
by Alexandre Julliard 08 Jun '09

08 Jun '09

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -123,6 +123,8 @@ HKCR,.xml,"Content Type",2,"text/xml" > HKCR,.xsl,"Content Type",2,"text/xsl" > HKCR,chm.file,,2,"Compiled HTML Help File" > HKCR,chm.file\shell\open\command,,2,"%11%\hh.exe %1" > +HKCR,CLSID\{CACAF262-9370-4615-A13B-9F5539DA4C0A}\InProcServer32,,2,"windowscodecs.dll" > +HKCR,CLSID\{CACAF262-9370-4615-A13B-9F5539DA4C0A}\InProcServer32,ThreadingModel,2,"Apartment" > HKCR,cplfile,,2,"Control Panel Item" > HKCR,cplfile\shell\cplopen,,2,"Open with Control Panel" > HKCR,cplfile\shell\cplopen\command,,2,"rundll32.exe shell32.dll,Control_RunDLL ""%1"",%*" This should be done by registering the dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] This patch fixes context menu crashes for edit controlsas apparent in vb apps.
by Dmitry Timoshkov 08 Jun '09

08 Jun '09

"Michael Martin" <martinmnet(a)hotmail.com> wrote: > The following patch fixes 18130. In my tests, context menu for > the Edit window control does not send the WM_COMMAND message. > Please comment. And what is the reason of the crash? Please add a test case replicating the problem first, only then start fixing it. -- Dmitry.

1 0

Re: d3d9: ATI1N support
by Stefan Dösinger 08 Jun '09

08 Jun '09

Nice that you found a way to support this format :-) Can you separate the compressed data loading changes from the ATI1N specific changes? I will make regression testing easier if anything should break. Do you have an app that needs this format? I think a test would be a good idea. Am 07.06.2009 um 09:48 schrieb Frank Richter: > --- > dlls/wined3d/device.c | 5 +- > dlls/wined3d/directx.c | 8 +++ > dlls/wined3d/surface.c | 110 > ++++++++++++++++++++++++------------------- > dlls/wined3d/surface_base.c | 6 +- > dlls/wined3d/utils.c | 6 ++ > include/wine/wined3d.idl | 1 + > 6 files changed, 82 insertions(+), 54 deletions(-) > > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index f1dd938..a08f713 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -920,10 +920,9 @@ static HRESULT WINAPI > IWineD3DDeviceImpl_CreateSurface(IWineD3DDevice *iface, > mul_4h = (Height + 3) & ~3; > if (WINED3DFMT_UNKNOWN == Format) { > Size = 0; > - } else if (Format == WINED3DFMT_DXT1) { > - /* DXT1 is half byte per pixel */ > + } else if (Format == WINED3DFMT_DXT1 || Format == > WINED3DFMT_ATI1N) { > + /* DXT1, ATI1N are half byte per pixel */ > Size = (mul_4w * glDesc->byte_count * mul_4h) >> 1; > - > } else if (Format == WINED3DFMT_DXT2 || Format == > WINED3DFMT_DXT3 || > Format == WINED3DFMT_DXT4 || Format == > WINED3DFMT_DXT5 || > Format == WINED3DFMT_ATI2N) { > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 4a2a270..60045aa 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -2467,6 +2467,14 @@ static BOOL CheckTextureCapability(struct > WineD3DAdapter *adapter, > return FALSE; > > /* Vendor specific formats */ > + case WINED3DFMT_ATI1N: > + if(GL_SUPPORT(EXT_TEXTURE_COMPRESSION_RGTC)) { > + TRACE_(d3d_caps)("[OK]\n"); > + return TRUE; > + } > + TRACE_(d3d_caps)("[FAILED]\n"); > + return FALSE; > + > case WINED3DFMT_ATI2N: > if(GL_SUPPORT(ATI_TEXTURE_COMPRESSION_3DC) || > GL_SUPPORT(EXT_TEXTURE_COMPRESSION_RGTC)) { > shader_backend = select_shader_backend(adapter, > DeviceType); > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 2f5554f..6469fa4 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -132,6 +132,25 @@ static BOOL > primary_render_target_is_p8(IWineD3DDeviceImpl *device) > return FALSE; > } > > +/* Download data for a compressed surface */ > +static void surface_download_data_compressed(IWineD3DSurfaceImpl > *This, const struct GlPixelFormatDesc *format_desc) { > + TRACE("(%p) : Calling glGetCompressedTexImageARB level %d, > format %#x, type %#x, data %p\n", > + This, This->glDescription.level, format_desc->glFormat, > format_desc->glType, > + This->resource.allocatedMemory); > + > + if(This->Flags & SFLAG_PBO) { > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, This->pbo)); > + checkGLcall("glBindBufferARB"); > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, > This->glDescription.level, NULL)); > + checkGLcall("glGetCompressedTexImageARB()"); > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB"); > + } else { > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, > This->glDescription.level, This->resource.allocatedMemory)); > + checkGLcall("glGetCompressedTexImageARB()"); > + } > +} > + > /* This call just downloads data, the caller is responsible for > activating the > * right context and binding the correct texture. */ > static void surface_download_data(IWineD3DSurfaceImpl *This) { > @@ -145,31 +164,19 @@ static void > surface_download_data(IWineD3DSurfaceImpl *This) { > } > > ENTER_GL(); > - > - if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > - || format_desc->format == WINED3DFMT_DXT3 || > format_desc->format == WINED3DFMT_DXT4 > - || format_desc->format == WINED3DFMT_DXT5 || > format_desc->format == WINED3DFMT_ATI2N) > - { > + > + if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > + || format_desc->format == WINED3DFMT_DXT3 || format_desc- > >format == WINED3DFMT_DXT4 > + || format_desc->format == WINED3DFMT_DXT5) { > if (!GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { /* We can > assume this as the texture would not have been created otherwise */ > FIXME("(%p) : Attempting to lock a compressed texture > when texture compression isn't supported by opengl\n", This); > } else { > - TRACE("(%p) : Calling glGetCompressedTexImageARB level > %d, format %#x, type %#x, data %p\n", > - This, This->glDescription.level, format_desc- > >glFormat, format_desc->glType, > - This->resource.allocatedMemory); > - > - if(This->Flags & SFLAG_PBO) { > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, This->pbo)); > - checkGLcall("glBindBufferARB"); > - GL_EXTCALL(glGetCompressedTexImageARB(This- > >glDescription.target, This->glDescription.level, NULL)); > - checkGLcall("glGetCompressedTexImageARB()"); > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > - checkGLcall("glBindBufferARB"); > - } else { > - GL_EXTCALL(glGetCompressedTexImageARB(This- > >glDescription.target, This->glDescription.level, This- > >resource.allocatedMemory)); > - checkGLcall("glGetCompressedTexImageARB()"); > - } > + surface_download_data_compressed(This, format_desc); > } > LEAVE_GL(); > + } else if (format_desc->format == WINED3DFMT_ATI1N || > format_desc->format == WINED3DFMT_ATI2N) { > + surface_download_data_compressed(This, format_desc); > + LEAVE_GL(); > } else { > void *mem; > GLenum format = format_desc->glFormat; > @@ -286,6 +293,35 @@ static void > surface_download_data(IWineD3DSurfaceImpl *This) { > This->Flags |= SFLAG_INSYSMEM; > } > > +/* Upload data for a compressed surface */ > +static void surface_upload_data_compressed(IWineD3DSurfaceImpl > *This, const struct GlPixelFormatDesc *format_desc, > + GLenum internal, GLsizei width, GLsizei height, const > GLvoid *data) { > + /* glCompressedTexSubImage2D for uploading and glTexImage2D for > allocating does not work well on some drivers(r200 dri, MacOS ATI > driver) > + * glCompressedTexImage2D does not accept NULL pointers. So for > compressed textures surface_allocate_surface does nothing, and this > + * function uses glCompressedTexImage2D instead of the SubImage > call > + */ > + TRACE("(%p) : Calling glCompressedTexSubImage2D w %d, h %d, > data %p\n", This, width, height, data); > + ENTER_GL(); > + > + if(This->Flags & SFLAG_PBO) { > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, This->pbo)); > + checkGLcall("glBindBufferARB"); > + TRACE("(%p) pbo: %#x, data: %p\n", This, This->pbo, data); > + > + GL_EXTCALL(glCompressedTexImage2DARB(This->glDescription.target, > This->glDescription.level, internal, > + width, height, 0 /* border */, This->resource.size, NULL)); > + checkGLcall("glCompressedTexSubImage2D"); > + > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB"); > + } else { > + GL_EXTCALL(glCompressedTexImage2DARB(This->glDescription.target, > This->glDescription.level, internal, > + width, height, 0 /* border */, This->resource.size, data)); > + checkGLcall("glCompressedTexSubImage2D"); > + } > + LEAVE_GL(); > +} > + > /* This call just uploads data, the caller is responsible for > activating the > * right context and binding the correct texture. */ > static void surface_upload_data(IWineD3DSurfaceImpl *This, GLenum > internal, GLsizei width, GLsizei height, GLenum format, GLenum type, > const GLvoid *data) { > @@ -293,38 +329,16 @@ static void > surface_upload_data(IWineD3DSurfaceImpl *This, GLenum internal, GLsi > > if (format_desc->heightscale != 1.0 && format_desc->heightscale ! > = 0.0) height *= format_desc->heightscale; > > - if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > - || format_desc->format == WINED3DFMT_DXT3 || > format_desc->format == WINED3DFMT_DXT4 > - || format_desc->format == WINED3DFMT_DXT5 || > format_desc->format == WINED3DFMT_ATI2N) > - { > + if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > + || format_desc->format == WINED3DFMT_DXT3 || format_desc- > >format == WINED3DFMT_DXT4 > + || format_desc->format == WINED3DFMT_DXT5) { > if (!GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { > FIXME("Using DXT1/3/5 without advertized support\n"); > } else { > - /* glCompressedTexSubImage2D for uploading and > glTexImage2D for allocating does not work well on some drivers(r200 > dri, MacOS ATI driver) > - * glCompressedTexImage2D does not accept NULL > pointers. So for compressed textures surface_allocate_surface does > nothing, and this > - * function uses glCompressedTexImage2D instead of the > SubImage call > - */ > - TRACE("(%p) : Calling glCompressedTexSubImage2D w %d, h > %d, data %p\n", This, width, height, data); > - ENTER_GL(); > - > - if(This->Flags & SFLAG_PBO) { > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, This->pbo)); > - checkGLcall("glBindBufferARB"); > - TRACE("(%p) pbo: %#x, data: %p\n", This, This->pbo, > data); > - > - GL_EXTCALL(glCompressedTexImage2DARB(This- > >glDescription.target, This->glDescription.level, internal, > - width, height, 0 /* border */, This- > >resource.size, NULL)); > - checkGLcall("glCompressedTexSubImage2D"); > - > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, 0)); > - checkGLcall("glBindBufferARB"); > - } else { > - GL_EXTCALL(glCompressedTexImage2DARB(This- > >glDescription.target, This->glDescription.level, internal, > - width, height, 0 /* border */, This- > >resource.size, data)); > - checkGLcall("glCompressedTexSubImage2D"); > - } > - LEAVE_GL(); > + surface_upload_data_compressed(This, format_desc, internal, > width, height, data); > } > + } else if (format_desc->format == WINED3DFMT_ATI1N || > format_desc->format == WINED3DFMT_ATI2N) { > + surface_upload_data_compressed(This, format_desc, internal, width, > height, data); > } else { > TRACE("(%p) : Calling glTexSubImage2D w %d, h %d, data, %p > \n", This, width, height, data); > ENTER_GL(); > diff --git a/dlls/wined3d/surface_base.c b/dlls/wined3d/surface_base.c > index d487f80..83cbd9d 100644 > --- a/dlls/wined3d/surface_base.c > +++ b/dlls/wined3d/surface_base.c > @@ -339,7 +339,7 @@ DWORD WINAPI > IWineD3DBaseSurfaceImpl_GetPitch(IWineD3DSurface *iface) { > /* DXTn formats don't have exact pitches as they are to the new > row of blocks, > where each block is 4x4 pixels, 8 bytes (dxt1) and 16 bytes > (dxt2/3/4/5) > ie pitch = (width/4) * bytes per > block */ > - if (format == WINED3DFMT_DXT1) /* DXT1 is 8 bytes per block */ > + if (format == WINED3DFMT_DXT1 || format == WINED3DFMT_ATI1N) /* > DXT1, ATI1N are 8 bytes per block */ > ret = ((This->currentDesc.Width + 3) >> 2) << 3; > else if (format == WINED3DFMT_DXT2 || format == WINED3DFMT_DXT3 || > format == WINED3DFMT_DXT4 || format == > WINED3DFMT_DXT5) /* DXT2/3/4/5 is 16 bytes per block */ > @@ -521,8 +521,8 @@ HRESULT WINAPI > IWineD3DBaseSurfaceImpl_SetFormat(IWineD3DSurface *iface, WINED3D > TRACE("(%p) : Setting texture format to (%d,%s)\n", This, > format, debug_d3dformat(format)); > if (format == WINED3DFMT_UNKNOWN) { > This->resource.size = 0; > - } else if (format == WINED3DFMT_DXT1) { > - /* DXT1 is half byte per pixel */ > + } else if (format == WINED3DFMT_DXT1 || format == > WINED3DFMT_ATI1N) { > + /* DXT1, ATI1N are half byte per pixel */ > This->resource.size = ((max(This->pow2Width, 4) * > format_desc->byte_count) * max(This->pow2Height, 4)) >> 1; > > } else if (format == WINED3DFMT_DXT2 || format == > WINED3DFMT_DXT3 || > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index f141a3b..822ce14 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -129,6 +129,7 @@ static const struct StaticPixelFormatDesc > formats[] = > {WINED3DFMT_R32_UINT, 0x0, 0x0, > 0x0, 0x0, 4, 0, 0, FALSE}, > {WINED3DFMT_R16G16B16A16_SNORM, 0x0, 0x0, > 0x0, 0x0, 8, 0, 0, FALSE}, > /* Vendor-specific formats */ > + {WINED3DFMT_ATI1N, 0x0, 0x0, > 0x0, 0x0, 1, 0, 0, TRUE }, > {WINED3DFMT_ATI2N, 0x0, 0x0, > 0x0, 0x0, 1, 0, 0, TRUE }, > {WINED3DFMT_NVHU, 0x0, 0x0, > 0x0, 0x0, 2, 0, 0, TRUE }, > {WINED3DFMT_NVHS, 0x0, 0x0, > 0x0, 0x0, 2, 0, 0, TRUE }, > @@ -459,6 +460,10 @@ static const GlPixelFormatDescTemplate > gl_formats_template[] = { > WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL, > EXT_PACKED_DEPTH_STENCIL}, > /* Vendor-specific formats */ > + {WINED3DFMT_ATI1N, GL_COMPRESSED_RED_RGTC1_EXT, > GL_COMPRESSED_RED_RGTC1_EXT, 0, > + GL_RED, GL_UNSIGNED_BYTE, > + 0, > + EXT_TEXTURE_COMPRESSION_RGTC}, > {WINED3DFMT_ATI2N, > GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI, > GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI, 0, > GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE, > 0, > @@ -868,6 +873,7 @@ const char* debug_d3dformat(WINED3DFORMAT fmt) { > FMT_TO_STR(WINED3DFMT_D24FS8); > FMT_TO_STR(WINED3DFMT_VERTEXDATA); > FMT_TO_STR(WINED3DFMT_CxV8U8); > + FMT_TO_STR(WINED3DFMT_ATI1N); > FMT_TO_STR(WINED3DFMT_ATI2N); > FMT_TO_STR(WINED3DFMT_NVHU); > FMT_TO_STR(WINED3DFMT_NVHS); > diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl > index 51d886c..6d087fd 100644 > --- a/include/wine/wined3d.idl > +++ b/include/wine/wined3d.idl > @@ -272,6 +272,7 @@ cpp_quote("#define WINED3DFMT_MULTI2_ARGB8 > WINEMAKEFOURCC('M', 'E', 'T', '1')") > cpp_quote("#define WINED3DFMT_G8R8_G8B8 WINEMAKEFOURCC('G', 'R', > 'G', 'B')") > cpp_quote("#define WINED3DFMT_R8G8_B8G8 WINEMAKEFOURCC('R', 'G', > 'B', 'G')") > /* Vendor specific formats */ > +cpp_quote("#define WINED3DFMT_ATI1N WINEMAKEFOURCC('A', 'T', > 'I', '1')") > cpp_quote("#define WINED3DFMT_ATI2N WINEMAKEFOURCC('A', 'T', > 'I', '2')") > cpp_quote("#define WINED3DFMT_NVHU WINEMAKEFOURCC('N', 'V', > 'H', 'U')") > cpp_quote("#define WINED3DFMT_NVHS WINEMAKEFOURCC('N', 'V', > 'H', 'S')") > >

1 0

Re: gdiplus: Add support for horizontal string alignment to GdipDrawString
by Vincent Povirk 08 Jun '09

08 Jun '09

This looks wrong to me. You're only adjusting the left coordinate, but in case of a rotation in the world transform, you'll need to adjust the top as well. Also, I think you may still be able to use DT_CENTER and DT_RIGHT rather than measuring the string beforehand. Creating a rectangle something like the original is difficult, but DrawText probably only needs to know the top-center or top-right point to do these other alignments. So it should be able to align things properly if you give it a rectangle where all corners are the point where it anchors the text. DrawText doesn't need the original rectangle because gdiplus does the clipping and wrapping (and it already doesn't get the original rectangle anyway). Vincent Povirk On Sat, Jun 6, 2009 at 2:19 PM, Stephan Rose<kermos(a)somrek.net> wrote: > Adds support for horizontal string alignment to GdipDrawString without > using DT_CENTER or DT_RIGHT. > > > >

2 2

New winetricks 20090607: new verbs d3dx9, fontsmooth-foo, vb2run, vcrun2008sp1, wme9, xact
by Dan Kegel 08 Jun '09

08 Jun '09

Another, er, quarter, another winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com Thanks to Austin English for taking on most of the work keeping winetricks up to date! (And apologies for my own slowness in doing another release.) Changes since 20090116: ------------------------------------------------------------------------ r491 | daniel.r.kegel | 2009-06-07 17:36:52 -0700 (Sun, 07 Jun 2009) | 2 lines Bump version, mention that Dan still maintains too. ------------------------------------------------------------------------ r489 | daniel.r.kegel | 2009-06-07 17:14:08 -0700 (Sun, 07 Jun 2009) | 4 lines Avoid using gnu tar extensions in liberation verb. Simplifies opensolaris support. ------------------------------------------------------------------------ r479 | austinenglish | 2009-05-31 20:11:06 -0700 (Sun, 31 May 2009) | 2 lines winetricks: Dan doesn't like subshells. I agree, they're messy. Get rid of one for liberation. ------------------------------------------------------------------------ r478 | austinenglish | 2009-05-31 20:08:27 -0700 (Sun, 31 May 2009) | 2 lines winetricks: clarify volnum workaround for vcrun2008 ------------------------------------------------------------------------ r477 | austinenglish | 2009-05-31 19:52:50 -0700 (Sun, 31 May 2009) | 2 lines winetricks: make sure we 'try' for all cp's, fix case-sensitive ones with wildcards ------------------------------------------------------------------------ r476 | austinenglish | 2009-05-31 19:08:30 -0700 (Sun, 31 May 2009) | 2 lines winetricks: only output Opensolaris info if running on OpenSolaris ------------------------------------------------------------------------ r475 | austinenglish | 2009-05-31 18:56:46 -0700 (Sun, 31 May 2009) | 2 lines winetricks: fix version function to only print the version ------------------------------------------------------------------------ r474 | daniel.r.kegel | 2009-05-31 17:38:50 -0700 (Sun, 31 May 2009) | 2 lines Be slightly more descriptive in fontsmooth verbs. ------------------------------------------------------------------------ r473 | austinenglish | 2009-05-31 12:55:44 -0700 (Sun, 31 May 2009) | 2 lines winetricks: work around kde bug ------------------------------------------------------------------------ r472 | austinenglish | 2009-05-30 19:03:23 -0700 (Sat, 30 May 2009) | 2 lines winetricks: minor ie6 fixes ------------------------------------------------------------------------ r471 | austinenglish | 2009-05-30 12:07:52 -0700 (Sat, 30 May 2009) | 2 lines winetricks: fix vcrun2008sp1 for old wine versions (1.0.1) ------------------------------------------------------------------------ r470 | austinenglish | 2009-05-30 08:48:48 -0700 (Sat, 30 May 2009) | 2 lines winetricks: make sure to run gunzip in a separate shell ------------------------------------------------------------------------ r467 | austinenglish | 2009-05-28 17:01:27 -0700 (Thu, 28 May 2009) | 2 lines winetricks: add a note about fixing local keystores for OpenSolaris ------------------------------------------------------------------------ r466 | austinenglish | 2009-05-28 16:50:17 -0700 (Thu, 28 May 2009) | 2 lines winetricks: fix busted urls and make a new release ------------------------------------------------------------------------ r465 | austinenglish | 2009-05-28 16:49:11 -0700 (Thu, 28 May 2009) | 2 lines winetricks: fix typo in last patch (liberation opensolaris fix) ------------------------------------------------------------------------ r464 | austinenglish | 2009-05-28 16:35:22 -0700 (Thu, 28 May 2009) | 2 lines winetricks: fix liberation verb for systems without tar (Patch by Matt Lewandowsky) ------------------------------------------------------------------------ r462 | austinenglish | 2009-05-27 21:29:30 -0700 (Wed, 27 May 2009) | 2 lines winetricks: disable services for wmp9/wmp10 ------------------------------------------------------------------------ r461 | austinenglish | 2009-05-27 21:09:51 -0700 (Wed, 27 May 2009) | 2 lines winetricks: fix ie6 install ------------------------------------------------------------------------ r460 | austinenglish | 2009-05-27 00:38:10 -0700 (Wed, 27 May 2009) | 2 lines winetricks: fix ie6 verb for non-english locales ------------------------------------------------------------------------ r439 | austinenglish | 2009-04-20 20:26:21 -0700 (Mon, 20 Apr 2009) | 2 lines winetricks: add gecko-dbg verb ------------------------------------------------------------------------ r438 | austinenglish | 2009-04-19 18:49:30 -0700 (Sun, 19 Apr 2009) | 2 lines winetricks: add version function ------------------------------------------------------------------------ r430 | austinenglish | 2009-04-06 23:40:27 -0700 (Mon, 06 Apr 2009) | 2 lines winetricks: fix download for fontfix verb ------------------------------------------------------------------------ r422 | austinenglish | 2009-03-30 17:15:39 -0700 (Mon, 30 Mar 2009) | 2 lines winetricks: add a sanity check to prevent running as sudo ------------------------------------------------------------------------ r420 | austinenglish | 2009-03-29 14:02:50 -0700 (Sun, 29 Mar 2009) | 2 lines winetricks: override rest of d3dx9_xx dlls. Patch by Rico Schüller ------------------------------------------------------------------------ r419 | austinenglish | 2009-03-29 13:59:36 -0700 (Sun, 29 Mar 2009) | 2 lines winetricks: update directx to March 2009 release ------------------------------------------------------------------------ r416 | austinenglish | 2009-03-29 08:44:32 -0700 (Sun, 29 Mar 2009) | 2 lines winetricks: updated a couple comments ------------------------------------------------------------------------ r415 | austinenglish | 2009-03-27 16:03:28 -0700 (Fri, 27 Mar 2009) | 2 lines winetricks: fix gecko for FreeBSD ------------------------------------------------------------------------ r412 | austinenglish | 2009-03-26 21:38:19 -0700 (Thu, 26 Mar 2009) | 3 lines winetricks: avoid 'echo -n', it's not portable and breaks on Solaris. Patch by Dan Kegel. ------------------------------------------------------------------------ r403 | austinenglish | 2009-03-22 18:32:47 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: release 20090322 ------------------------------------------------------------------------ r401 | austinenglish | 2009-03-22 17:41:31 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: load wsh56 for controlpad ------------------------------------------------------------------------ r400 | austinenglish | 2009-03-22 17:32:12 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: couple minor changes ------------------------------------------------------------------------ r399 | austinenglish | 2009-03-22 17:21:16 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add native overrides for ole2 ------------------------------------------------------------------------ r398 | austinenglish | 2009-03-22 17:03:11 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: load dotnet20 for vjrun20 ------------------------------------------------------------------------ r397 | austinenglish | 2009-03-22 16:54:39 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: fix kde download link, update to latest stable ------------------------------------------------------------------------ r396 | austinenglish | 2009-03-22 16:39:09 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add fontsmoothing options ------------------------------------------------------------------------ r395 | austinenglish | 2009-03-22 16:07:21 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: fix msmask, make case insensitive ------------------------------------------------------------------------ r394 | austinenglish | 2009-03-22 16:02:27 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: update divx to divx7 ------------------------------------------------------------------------ r393 | austinenglish | 2009-03-22 12:33:55 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add a few more synonmys for some keywords ------------------------------------------------------------------------ r392 | austinenglish | 2009-03-22 12:30:17 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added xact keyword. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r391 | austinenglish | 2009-03-22 12:25:21 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: refactor directx download into a helper function. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r390 | austinenglish | 2009-03-22 12:18:24 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added vb2run keyword. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r389 | austinenglish | 2009-03-22 12:14:44 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added vcrun2008sp1 keyword. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r388 | austinenglish | 2009-03-22 11:49:44 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added d3dx9 redistributable. Based on patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r387 | austinenglish | 2009-03-22 11:13:55 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add msvcrt override for vcrun6 ------------------------------------------------------------------------ r386 | austinenglish | 2009-03-12 16:23:58 -0700 (Thu, 12 Mar 2009) | 2 lines winetricks: fix vlc download link ------------------------------------------------------------------------ r380 | daniel.r.kegel | 2009-02-27 09:04:02 -0800 (Fri, 27 Feb 2009) | 2 lines Update flash ------------------------------------------------------------------------ r376 | austinenglish | 2009-02-25 13:54:52 -0800 (Wed, 25 Feb 2009) | 2 lines Use builtin ole/rpc for a couple more builtin apps ------------------------------------------------------------------------ r343 | daniel.r.kegel | 2009-02-16 18:30:21 -0800 (Mon, 16 Feb 2009) | 2 lines Document license requirements better ------------------------------------------------------------------------ r337 | daniel.r.kegel | 2009-02-14 16:18:03 -0800 (Sat, 14 Feb 2009) | 2 lines Clarify mfc42, since people were installing both it and vcrun6 ------------------------------------------------------------------------ r335 | daniel.r.kegel | 2009-02-14 15:07:08 -0800 (Sat, 14 Feb 2009) | 3 lines Added wme9 Updated gecko for 1.1.15 ------------------------------------------------------------------------ r298 | daniel.r.kegel | 2009-02-09 08:04:49 -0800 (Mon, 09 Feb 2009) | 3 lines Fix a solaris problem, warn users that quicktime needs gdiplus, make version name obvious to someone looking at the top of the file ------------------------------------------------------------------------ r266 | daniel.r.kegel | 2009-01-21 06:55:58 -0800 (Wed, 21 Jan 2009) | 2 lines Fix tahoma to include tahomabd, needed for Steam.

1 0

Re: wined3d:
by James McKenzie 07 Jun '09

07 Jun '09

Pavel Prochazka wrote: There is an open bug for this problem, 14746. Can you clean up and attach your fix to this bug so that others can try it? I did apply it cleanly, through three steps to version 1.1.22 of Wine. James McKenzie

1 0

Re: [Bugzilla]: Refuse to accept comments with big number of logs / back traces
by Austin English 07 Jun '09

07 Jun '09

On Sun, Jun 7, 2009 at 12:25 PM, Vitaliy Margolen<wine-patches(a)kievinfo.com> wrote: > > The limits are: > 20 lines for logs (fixme, trace, err, warn) > 10 lines for back traces > --- > Bugzilla/Bug.pm | 7 +++++++ > template/en/default/global/user-error.html.tmpl | 4 ++++ > 2 files changed, 11 insertions(+), 0 deletions(-) While I'm hugely in favor of this, AFAICT, this blocks everyone from doing so, correct? What about developers that know what they're doing, or Anastasius? -- -Austin

2 1

Re: d3d9: ATI1N support
by Henri Verbeet 07 Jun '09

07 Jun '09

2009/6/7 Frank Richter <frank.richter(a)gmail.com>: > +/* Download data for a compressed surface */ > +static void surface_download_data_compressed(IWineD3DSurfaceImpl *This, const struct GlPixelFormatDesc *format_desc) { > + TRACE("(%p) : Calling glGetCompressedTexImageARB level %d, format %#x, type %#x, data %p\n", > + This, This->glDescription.level, format_desc->glFormat, format_desc->glType, > + This->resource.allocatedMemory); > + > + if(This->Flags & SFLAG_PBO) { > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, This->pbo)); > + checkGLcall("glBindBufferARB"); > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, This->glDescription.level, NULL)); > + checkGLcall("glGetCompressedTexImageARB()"); > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB"); > + } else { > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, This->glDescription.level, This->resource.allocatedMemory)); > + checkGLcall("glGetCompressedTexImageARB()"); > + } > +} Please don't add tabs. I also think wined3d would be more appropriate as module name for these patches.

1 0

Test box tagged [dr-asus]
by Nikolay Sivov 07 Jun '09

07 Jun '09

Hi. Does anyone no whose box is it (dr-asus)? It has some (actually always 10) test failures for ListView and I think it's possible to find a cause. Same failures on 2k and XP actually. I'd like to contact owner for testing some patches. Thanks.

5 4

cd-roms that need unhide
by Dan Kegel 07 Jun '09

07 Jun '09

Despite jwhite's kernel fix, http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h… I find I have to use 'norock' on some discs, e.g. Macromedia Studio 8, http://bugs.winehq.org/show_bug.cgi?id=9467 Microsoft Dynamics GP demo, http://bugs.winehq.org/show_bug.cgi?id=8178 ... and the stupid DKNY perfume promo DVD-ROM that came in the newspaper today. Running it with Wine yields... a black screen, as the flash player can't get at its data. Mounting the DKNY disc with -o unhide or -o norock lets it work fine with wine. Here's what one sees without either flag: $ ls /media/cdrom/ -l total 3668 dr-xr-xr-x 2 4294967295 4294967295 40 2007-07-24 15:54 AUDIO_TS -r-xr-xr-x 1 4294967295 4294967295 2144972 2007-07-17 20:18 DKNYDeliciousNight -r-xr-xr-x 1 4294967295 4294967295 1602372 2007-07-17 20:18 DKNYDeliciousNight.exe -r-xr-xr-x 1 4294967295 4294967295 1616 2007-02-14 06:34 Readme.txt dr--r--r-- 3 4294967295 4294967295 560 2007-07-24 15:54 VIDEO_TS (The VIDEO_TS directory is not searchable! ) Here's what one sees with unhide: dank@lappy:~$ ls -l /media/cdrom/ total 3788 dr-xr-xr-x 2 4294967295 4294967295 40 2007-07-24 15:54 AUDIO_TS -r-xr-xr-x 1 4294967295 4294967295 67 2007-07-05 11:20 autorun.inf dr-xr-xr-x 2 4294967295 4294967295 1032 2007-07-09 12:11 backgroundLoops dr-xr-xr-x 2 4294967295 4294967295 92 2007-06-25 14:48 css -rwxr-xr-x 1 4294967295 4294967295 1024 2007-01-03 08:47 Desktop DB -rwxr-xr-x 1 4294967295 4294967295 2 2007-01-03 08:47 Desktop DF -r-xr-xr-x 1 4294967295 4294967295 2144972 2007-07-17 20:18 DKNYDeliciousNight -r-xr-xr-x 1 4294967295 4294967295 1602372 2007-07-17 20:18 DKNYDeliciousNight.exe -r-xr-xr-x 1 4294967295 4294967295 97566 2007-06-27 14:30 DKNYDeliciousNight.ico dr-xr-xr-x 2 4294967295 4294967295 244 2007-07-13 09:30 exit dr-xr-xr-x 2 4294967295 4294967295 3400 2007-07-17 17:18 flv dr-xr-xr-x 9 4294967295 4294967295 684 2007-07-18 15:41 fscommand -r-xr-xr-x 1 4294967295 4294967295 1616 2007-02-14 06:34 Readme.txt dr-xr-xr-x 2 4294967295 4294967295 240 2007-07-09 12:11 soundFx dr-xr-xr-x 2 4294967295 4294967295 996 2007-07-18 18:50 swf dr--r--r-- 3 4294967295 4294967295 560 2007-07-24 15:54 VIDEO_TS dr-xr-xr-x 2 4294967295 4294967295 140 2007-07-05 09:23 xml (The VIDEO_TS directory is not searchable, but the app works anyway. ) norock is similar, but VIDEO_TS is searchable. Given that these poorly mastered discs are turning up periodically -- widely distributed -- it seems like it might be time for another kernel change, or at least some userland kludge that does a remount. The heuristic I imagine is: If the top level directory has any subdirectories that are completely nonsearchable or nonreadable, remount with unhide. What say? Would this help users more than it would hurt? - Dan

2 2

Re: [PATCH] This patch fixes context menu crashes for edit controls as apparent in vb apps.
by Reece Dunn 07 Jun '09

07 Jun '09

2009/6/7 Michael Martin <martinmnet(a)hotmail.com>: You'll need to include the patch as an attachment (renamed as a text file if your mail client messes up the encoding), instead of including it in the body text (the indentation in the patch you included has been removed by your mail client). > + BOOL selectedMenuItem; > ... > + selectedMenuItem = TrackPopupMenu(popup, TPM_LEFTALIGN | TPM_RIGHTBUTTON | > TMPRETURNCMD, x, y, 0, es->hwndSelf, NULL); > + switch (selectedMenuItem) { Despite TrackPopupMenu having a BOOL return type, using an int would make it more readable (selectedMenuItem is not being used as a boolean value, but as a command index). Alternatively, just use: switch (TrackPopupMenu(...)) { TMPRETURNCMD -- This should be TMP_RETURNCMD. Is this an error when adding the patch to the email? Thanks for contributing to Wine, - Reece

1 0

Re: [2/5] WineD3D: Implement loops with the NV extensions
by Allan Tong 07 Jun '09

07 Jun '09

This is using PUSHA and POPA without setting the NV_vertex_program3 option in the shader. - Allan

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel