- wine-devel - winehq.org

re: How do I actually write a testcase for a 16-bit API ?
by Dan Kegel 09 Jun '09

09 Jun '09

See also http://lists.debian.org/debian-legal/2006/07/msg00007.html I kind of doubt it will ever make it in to ubuntu. When I tried building win16 binaries with the Linux version, there were lots of path problems. That was two years ago, but I wouldn't be surprised if they're still there. These two things together make me suspect that installing the windows version in Wine is the way to go. We could make a script that does that in an alternate prefix and provides wrapper scripts that hide the wine-ness of it to some extent, maybe. That could be done as a stopgap while the test suite is refreshed and gotten ready to add into the wine tree. Once that's far enough along, it might then be worth looking at getting the linux version working and into a PPA. Or vice versa. Wish I had time to play with this stuff. I would really be happy if somebody got the win16 test suite into the wine tree! - Dan

1 0

Re: wine-devel Digest, Vol 47, Issue 32
by chris ahrendt 08 Jun '09

08 Jun '09

Did we find out what the regression is for 1.1.23 that caused the ATI and other non NVIDIA cards to start failing? Chris

1 0

Re: riched20/tests: fix test for vista
by Paul Vriens 08 Jun '09

08 Jun '09

André Hentschel wrote: > Vista turns the "(WCHAR)1234" into a "(unsigned char)1234". > This causes error on vista machines<SP2: > http://test.winehq.org/data/7aeffc442cc1b9a454f1ff7d7b3175b4bba88b05/vista_… > > editor.c:3249: Test failed: EM_GETPASSWORDCHAR returned Ò (210) when set > to 'x', instead of x (120) > --- > dlls/riched20/tests/editor.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi André, Is there anything special about this box? Could it be that the locale plays a role in this. I'm asking as my Vista box (and several others seen on test.winehq.org) doesn't have this issue. -- Cheers, Paul.

1 0

Re: d3d9: Add DF16 support
by Henri Verbeet 08 Jun '09

08 Jun '09

2009/6/7 Frank Richter <frank.richter(a)gmail.com>: > As far as I could gather DF16 is the "ATI way" of getting a renderable > 16 bit depth texture. Without knowing much about the actual format, DF16 implies this should be a floating point format, similar to the ones provided by ARB_depth_buffer_float. Also, could you please add this at the same location as the other depth formats?

5 9

Re: Try2: Website: Remove GIMP Fun Project
by Paul Vriens 08 Jun '09

08 Jun '09

Ken Sharp wrote: > Disregard first patch.. this one makes a little more sense. > > Ken Sharp wrote: >> See Bug 7976. Apparently this has already been done. >> >> >> ------------------------------------------------------------------------ >> >> > > > ------------------------------------------------------------------------ > > We have that same (or actually newer) page on the wiki: http://wiki.winehq.org/Fun_Projects Doesn't it make more sense to link this entire page to the wiki? -- Cheers, Paul.

2 1

Re: [3/3] windowscodecs: add stub implementation of IWICImagingFactory
by Alexandre Julliard 08 Jun '09

08 Jun '09

"Vincent Povirk" <vincent(a)codeweavers.com> writes: > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -123,6 +123,8 @@ HKCR,.xml,"Content Type",2,"text/xml" > HKCR,.xsl,"Content Type",2,"text/xsl" > HKCR,chm.file,,2,"Compiled HTML Help File" > HKCR,chm.file\shell\open\command,,2,"%11%\hh.exe %1" > +HKCR,CLSID\{CACAF262-9370-4615-A13B-9F5539DA4C0A}\InProcServer32,,2,"windowscodecs.dll" > +HKCR,CLSID\{CACAF262-9370-4615-A13B-9F5539DA4C0A}\InProcServer32,ThreadingModel,2,"Apartment" > HKCR,cplfile,,2,"Control Panel Item" > HKCR,cplfile\shell\cplopen,,2,"Open with Control Panel" > HKCR,cplfile\shell\cplopen\command,,2,"rundll32.exe shell32.dll,Control_RunDLL ""%1"",%*" This should be done by registering the dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] This patch fixes context menu crashes for edit controlsas apparent in vb apps.
by Dmitry Timoshkov 08 Jun '09

08 Jun '09

"Michael Martin" <martinmnet(a)hotmail.com> wrote: > The following patch fixes 18130. In my tests, context menu for > the Edit window control does not send the WM_COMMAND message. > Please comment. And what is the reason of the crash? Please add a test case replicating the problem first, only then start fixing it. -- Dmitry.

1 0

Re: d3d9: ATI1N support
by Stefan Dösinger 08 Jun '09

08 Jun '09

Nice that you found a way to support this format :-) Can you separate the compressed data loading changes from the ATI1N specific changes? I will make regression testing easier if anything should break. Do you have an app that needs this format? I think a test would be a good idea. Am 07.06.2009 um 09:48 schrieb Frank Richter: > --- > dlls/wined3d/device.c | 5 +- > dlls/wined3d/directx.c | 8 +++ > dlls/wined3d/surface.c | 110 > ++++++++++++++++++++++++------------------- > dlls/wined3d/surface_base.c | 6 +- > dlls/wined3d/utils.c | 6 ++ > include/wine/wined3d.idl | 1 + > 6 files changed, 82 insertions(+), 54 deletions(-) > > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index f1dd938..a08f713 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -920,10 +920,9 @@ static HRESULT WINAPI > IWineD3DDeviceImpl_CreateSurface(IWineD3DDevice *iface, > mul_4h = (Height + 3) & ~3; > if (WINED3DFMT_UNKNOWN == Format) { > Size = 0; > - } else if (Format == WINED3DFMT_DXT1) { > - /* DXT1 is half byte per pixel */ > + } else if (Format == WINED3DFMT_DXT1 || Format == > WINED3DFMT_ATI1N) { > + /* DXT1, ATI1N are half byte per pixel */ > Size = (mul_4w * glDesc->byte_count * mul_4h) >> 1; > - > } else if (Format == WINED3DFMT_DXT2 || Format == > WINED3DFMT_DXT3 || > Format == WINED3DFMT_DXT4 || Format == > WINED3DFMT_DXT5 || > Format == WINED3DFMT_ATI2N) { > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 4a2a270..60045aa 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -2467,6 +2467,14 @@ static BOOL CheckTextureCapability(struct > WineD3DAdapter *adapter, > return FALSE; > > /* Vendor specific formats */ > + case WINED3DFMT_ATI1N: > + if(GL_SUPPORT(EXT_TEXTURE_COMPRESSION_RGTC)) { > + TRACE_(d3d_caps)("[OK]\n"); > + return TRUE; > + } > + TRACE_(d3d_caps)("[FAILED]\n"); > + return FALSE; > + > case WINED3DFMT_ATI2N: > if(GL_SUPPORT(ATI_TEXTURE_COMPRESSION_3DC) || > GL_SUPPORT(EXT_TEXTURE_COMPRESSION_RGTC)) { > shader_backend = select_shader_backend(adapter, > DeviceType); > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 2f5554f..6469fa4 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -132,6 +132,25 @@ static BOOL > primary_render_target_is_p8(IWineD3DDeviceImpl *device) > return FALSE; > } > > +/* Download data for a compressed surface */ > +static void surface_download_data_compressed(IWineD3DSurfaceImpl > *This, const struct GlPixelFormatDesc *format_desc) { > + TRACE("(%p) : Calling glGetCompressedTexImageARB level %d, > format %#x, type %#x, data %p\n", > + This, This->glDescription.level, format_desc->glFormat, > format_desc->glType, > + This->resource.allocatedMemory); > + > + if(This->Flags & SFLAG_PBO) { > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, This->pbo)); > + checkGLcall("glBindBufferARB"); > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, > This->glDescription.level, NULL)); > + checkGLcall("glGetCompressedTexImageARB()"); > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB"); > + } else { > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, > This->glDescription.level, This->resource.allocatedMemory)); > + checkGLcall("glGetCompressedTexImageARB()"); > + } > +} > + > /* This call just downloads data, the caller is responsible for > activating the > * right context and binding the correct texture. */ > static void surface_download_data(IWineD3DSurfaceImpl *This) { > @@ -145,31 +164,19 @@ static void > surface_download_data(IWineD3DSurfaceImpl *This) { > } > > ENTER_GL(); > - > - if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > - || format_desc->format == WINED3DFMT_DXT3 || > format_desc->format == WINED3DFMT_DXT4 > - || format_desc->format == WINED3DFMT_DXT5 || > format_desc->format == WINED3DFMT_ATI2N) > - { > + > + if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > + || format_desc->format == WINED3DFMT_DXT3 || format_desc- > >format == WINED3DFMT_DXT4 > + || format_desc->format == WINED3DFMT_DXT5) { > if (!GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { /* We can > assume this as the texture would not have been created otherwise */ > FIXME("(%p) : Attempting to lock a compressed texture > when texture compression isn't supported by opengl\n", This); > } else { > - TRACE("(%p) : Calling glGetCompressedTexImageARB level > %d, format %#x, type %#x, data %p\n", > - This, This->glDescription.level, format_desc- > >glFormat, format_desc->glType, > - This->resource.allocatedMemory); > - > - if(This->Flags & SFLAG_PBO) { > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, This->pbo)); > - checkGLcall("glBindBufferARB"); > - GL_EXTCALL(glGetCompressedTexImageARB(This- > >glDescription.target, This->glDescription.level, NULL)); > - checkGLcall("glGetCompressedTexImageARB()"); > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > - checkGLcall("glBindBufferARB"); > - } else { > - GL_EXTCALL(glGetCompressedTexImageARB(This- > >glDescription.target, This->glDescription.level, This- > >resource.allocatedMemory)); > - checkGLcall("glGetCompressedTexImageARB()"); > - } > + surface_download_data_compressed(This, format_desc); > } > LEAVE_GL(); > + } else if (format_desc->format == WINED3DFMT_ATI1N || > format_desc->format == WINED3DFMT_ATI2N) { > + surface_download_data_compressed(This, format_desc); > + LEAVE_GL(); > } else { > void *mem; > GLenum format = format_desc->glFormat; > @@ -286,6 +293,35 @@ static void > surface_download_data(IWineD3DSurfaceImpl *This) { > This->Flags |= SFLAG_INSYSMEM; > } > > +/* Upload data for a compressed surface */ > +static void surface_upload_data_compressed(IWineD3DSurfaceImpl > *This, const struct GlPixelFormatDesc *format_desc, > + GLenum internal, GLsizei width, GLsizei height, const > GLvoid *data) { > + /* glCompressedTexSubImage2D for uploading and glTexImage2D for > allocating does not work well on some drivers(r200 dri, MacOS ATI > driver) > + * glCompressedTexImage2D does not accept NULL pointers. So for > compressed textures surface_allocate_surface does nothing, and this > + * function uses glCompressedTexImage2D instead of the SubImage > call > + */ > + TRACE("(%p) : Calling glCompressedTexSubImage2D w %d, h %d, > data %p\n", This, width, height, data); > + ENTER_GL(); > + > + if(This->Flags & SFLAG_PBO) { > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, This->pbo)); > + checkGLcall("glBindBufferARB"); > + TRACE("(%p) pbo: %#x, data: %p\n", This, This->pbo, data); > + > + GL_EXTCALL(glCompressedTexImage2DARB(This->glDescription.target, > This->glDescription.level, internal, > + width, height, 0 /* border */, This->resource.size, NULL)); > + checkGLcall("glCompressedTexSubImage2D"); > + > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB"); > + } else { > + GL_EXTCALL(glCompressedTexImage2DARB(This->glDescription.target, > This->glDescription.level, internal, > + width, height, 0 /* border */, This->resource.size, data)); > + checkGLcall("glCompressedTexSubImage2D"); > + } > + LEAVE_GL(); > +} > + > /* This call just uploads data, the caller is responsible for > activating the > * right context and binding the correct texture. */ > static void surface_upload_data(IWineD3DSurfaceImpl *This, GLenum > internal, GLsizei width, GLsizei height, GLenum format, GLenum type, > const GLvoid *data) { > @@ -293,38 +329,16 @@ static void > surface_upload_data(IWineD3DSurfaceImpl *This, GLenum internal, GLsi > > if (format_desc->heightscale != 1.0 && format_desc->heightscale ! > = 0.0) height *= format_desc->heightscale; > > - if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > - || format_desc->format == WINED3DFMT_DXT3 || > format_desc->format == WINED3DFMT_DXT4 > - || format_desc->format == WINED3DFMT_DXT5 || > format_desc->format == WINED3DFMT_ATI2N) > - { > + if (format_desc->format == WINED3DFMT_DXT1 || format_desc- > >format == WINED3DFMT_DXT2 > + || format_desc->format == WINED3DFMT_DXT3 || format_desc- > >format == WINED3DFMT_DXT4 > + || format_desc->format == WINED3DFMT_DXT5) { > if (!GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { > FIXME("Using DXT1/3/5 without advertized support\n"); > } else { > - /* glCompressedTexSubImage2D for uploading and > glTexImage2D for allocating does not work well on some drivers(r200 > dri, MacOS ATI driver) > - * glCompressedTexImage2D does not accept NULL > pointers. So for compressed textures surface_allocate_surface does > nothing, and this > - * function uses glCompressedTexImage2D instead of the > SubImage call > - */ > - TRACE("(%p) : Calling glCompressedTexSubImage2D w %d, h > %d, data %p\n", This, width, height, data); > - ENTER_GL(); > - > - if(This->Flags & SFLAG_PBO) { > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, This->pbo)); > - checkGLcall("glBindBufferARB"); > - TRACE("(%p) pbo: %#x, data: %p\n", This, This->pbo, > data); > - > - GL_EXTCALL(glCompressedTexImage2DARB(This- > >glDescription.target, This->glDescription.level, internal, > - width, height, 0 /* border */, This- > >resource.size, NULL)); > - checkGLcall("glCompressedTexSubImage2D"); > - > - > GL_EXTCALL(glBindBufferARB(GL_PIXEL_UNPACK_BUFFER_ARB, 0)); > - checkGLcall("glBindBufferARB"); > - } else { > - GL_EXTCALL(glCompressedTexImage2DARB(This- > >glDescription.target, This->glDescription.level, internal, > - width, height, 0 /* border */, This- > >resource.size, data)); > - checkGLcall("glCompressedTexSubImage2D"); > - } > - LEAVE_GL(); > + surface_upload_data_compressed(This, format_desc, internal, > width, height, data); > } > + } else if (format_desc->format == WINED3DFMT_ATI1N || > format_desc->format == WINED3DFMT_ATI2N) { > + surface_upload_data_compressed(This, format_desc, internal, width, > height, data); > } else { > TRACE("(%p) : Calling glTexSubImage2D w %d, h %d, data, %p > \n", This, width, height, data); > ENTER_GL(); > diff --git a/dlls/wined3d/surface_base.c b/dlls/wined3d/surface_base.c > index d487f80..83cbd9d 100644 > --- a/dlls/wined3d/surface_base.c > +++ b/dlls/wined3d/surface_base.c > @@ -339,7 +339,7 @@ DWORD WINAPI > IWineD3DBaseSurfaceImpl_GetPitch(IWineD3DSurface *iface) { > /* DXTn formats don't have exact pitches as they are to the new > row of blocks, > where each block is 4x4 pixels, 8 bytes (dxt1) and 16 bytes > (dxt2/3/4/5) > ie pitch = (width/4) * bytes per > block */ > - if (format == WINED3DFMT_DXT1) /* DXT1 is 8 bytes per block */ > + if (format == WINED3DFMT_DXT1 || format == WINED3DFMT_ATI1N) /* > DXT1, ATI1N are 8 bytes per block */ > ret = ((This->currentDesc.Width + 3) >> 2) << 3; > else if (format == WINED3DFMT_DXT2 || format == WINED3DFMT_DXT3 || > format == WINED3DFMT_DXT4 || format == > WINED3DFMT_DXT5) /* DXT2/3/4/5 is 16 bytes per block */ > @@ -521,8 +521,8 @@ HRESULT WINAPI > IWineD3DBaseSurfaceImpl_SetFormat(IWineD3DSurface *iface, WINED3D > TRACE("(%p) : Setting texture format to (%d,%s)\n", This, > format, debug_d3dformat(format)); > if (format == WINED3DFMT_UNKNOWN) { > This->resource.size = 0; > - } else if (format == WINED3DFMT_DXT1) { > - /* DXT1 is half byte per pixel */ > + } else if (format == WINED3DFMT_DXT1 || format == > WINED3DFMT_ATI1N) { > + /* DXT1, ATI1N are half byte per pixel */ > This->resource.size = ((max(This->pow2Width, 4) * > format_desc->byte_count) * max(This->pow2Height, 4)) >> 1; > > } else if (format == WINED3DFMT_DXT2 || format == > WINED3DFMT_DXT3 || > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index f141a3b..822ce14 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -129,6 +129,7 @@ static const struct StaticPixelFormatDesc > formats[] = > {WINED3DFMT_R32_UINT, 0x0, 0x0, > 0x0, 0x0, 4, 0, 0, FALSE}, > {WINED3DFMT_R16G16B16A16_SNORM, 0x0, 0x0, > 0x0, 0x0, 8, 0, 0, FALSE}, > /* Vendor-specific formats */ > + {WINED3DFMT_ATI1N, 0x0, 0x0, > 0x0, 0x0, 1, 0, 0, TRUE }, > {WINED3DFMT_ATI2N, 0x0, 0x0, > 0x0, 0x0, 1, 0, 0, TRUE }, > {WINED3DFMT_NVHU, 0x0, 0x0, > 0x0, 0x0, 2, 0, 0, TRUE }, > {WINED3DFMT_NVHS, 0x0, 0x0, > 0x0, 0x0, 2, 0, 0, TRUE }, > @@ -459,6 +460,10 @@ static const GlPixelFormatDescTemplate > gl_formats_template[] = { > WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL, > EXT_PACKED_DEPTH_STENCIL}, > /* Vendor-specific formats */ > + {WINED3DFMT_ATI1N, GL_COMPRESSED_RED_RGTC1_EXT, > GL_COMPRESSED_RED_RGTC1_EXT, 0, > + GL_RED, GL_UNSIGNED_BYTE, > + 0, > + EXT_TEXTURE_COMPRESSION_RGTC}, > {WINED3DFMT_ATI2N, > GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI, > GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI, 0, > GL_LUMINANCE_ALPHA, GL_UNSIGNED_BYTE, > 0, > @@ -868,6 +873,7 @@ const char* debug_d3dformat(WINED3DFORMAT fmt) { > FMT_TO_STR(WINED3DFMT_D24FS8); > FMT_TO_STR(WINED3DFMT_VERTEXDATA); > FMT_TO_STR(WINED3DFMT_CxV8U8); > + FMT_TO_STR(WINED3DFMT_ATI1N); > FMT_TO_STR(WINED3DFMT_ATI2N); > FMT_TO_STR(WINED3DFMT_NVHU); > FMT_TO_STR(WINED3DFMT_NVHS); > diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl > index 51d886c..6d087fd 100644 > --- a/include/wine/wined3d.idl > +++ b/include/wine/wined3d.idl > @@ -272,6 +272,7 @@ cpp_quote("#define WINED3DFMT_MULTI2_ARGB8 > WINEMAKEFOURCC('M', 'E', 'T', '1')") > cpp_quote("#define WINED3DFMT_G8R8_G8B8 WINEMAKEFOURCC('G', 'R', > 'G', 'B')") > cpp_quote("#define WINED3DFMT_R8G8_B8G8 WINEMAKEFOURCC('R', 'G', > 'B', 'G')") > /* Vendor specific formats */ > +cpp_quote("#define WINED3DFMT_ATI1N WINEMAKEFOURCC('A', 'T', > 'I', '1')") > cpp_quote("#define WINED3DFMT_ATI2N WINEMAKEFOURCC('A', 'T', > 'I', '2')") > cpp_quote("#define WINED3DFMT_NVHU WINEMAKEFOURCC('N', 'V', > 'H', 'U')") > cpp_quote("#define WINED3DFMT_NVHS WINEMAKEFOURCC('N', 'V', > 'H', 'S')") > >

1 0

Re: gdiplus: Add support for horizontal string alignment to GdipDrawString
by Vincent Povirk 08 Jun '09

08 Jun '09

This looks wrong to me. You're only adjusting the left coordinate, but in case of a rotation in the world transform, you'll need to adjust the top as well. Also, I think you may still be able to use DT_CENTER and DT_RIGHT rather than measuring the string beforehand. Creating a rectangle something like the original is difficult, but DrawText probably only needs to know the top-center or top-right point to do these other alignments. So it should be able to align things properly if you give it a rectangle where all corners are the point where it anchors the text. DrawText doesn't need the original rectangle because gdiplus does the clipping and wrapping (and it already doesn't get the original rectangle anyway). Vincent Povirk On Sat, Jun 6, 2009 at 2:19 PM, Stephan Rose<kermos(a)somrek.net> wrote: > Adds support for horizontal string alignment to GdipDrawString without > using DT_CENTER or DT_RIGHT. > > > >

2 2

New winetricks 20090607: new verbs d3dx9, fontsmooth-foo, vb2run, vcrun2008sp1, wme9, xact
by Dan Kegel 08 Jun '09

08 Jun '09

Another, er, quarter, another winetricks. Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com Thanks to Austin English for taking on most of the work keeping winetricks up to date! (And apologies for my own slowness in doing another release.) Changes since 20090116: ------------------------------------------------------------------------ r491 | daniel.r.kegel | 2009-06-07 17:36:52 -0700 (Sun, 07 Jun 2009) | 2 lines Bump version, mention that Dan still maintains too. ------------------------------------------------------------------------ r489 | daniel.r.kegel | 2009-06-07 17:14:08 -0700 (Sun, 07 Jun 2009) | 4 lines Avoid using gnu tar extensions in liberation verb. Simplifies opensolaris support. ------------------------------------------------------------------------ r479 | austinenglish | 2009-05-31 20:11:06 -0700 (Sun, 31 May 2009) | 2 lines winetricks: Dan doesn't like subshells. I agree, they're messy. Get rid of one for liberation. ------------------------------------------------------------------------ r478 | austinenglish | 2009-05-31 20:08:27 -0700 (Sun, 31 May 2009) | 2 lines winetricks: clarify volnum workaround for vcrun2008 ------------------------------------------------------------------------ r477 | austinenglish | 2009-05-31 19:52:50 -0700 (Sun, 31 May 2009) | 2 lines winetricks: make sure we 'try' for all cp's, fix case-sensitive ones with wildcards ------------------------------------------------------------------------ r476 | austinenglish | 2009-05-31 19:08:30 -0700 (Sun, 31 May 2009) | 2 lines winetricks: only output Opensolaris info if running on OpenSolaris ------------------------------------------------------------------------ r475 | austinenglish | 2009-05-31 18:56:46 -0700 (Sun, 31 May 2009) | 2 lines winetricks: fix version function to only print the version ------------------------------------------------------------------------ r474 | daniel.r.kegel | 2009-05-31 17:38:50 -0700 (Sun, 31 May 2009) | 2 lines Be slightly more descriptive in fontsmooth verbs. ------------------------------------------------------------------------ r473 | austinenglish | 2009-05-31 12:55:44 -0700 (Sun, 31 May 2009) | 2 lines winetricks: work around kde bug ------------------------------------------------------------------------ r472 | austinenglish | 2009-05-30 19:03:23 -0700 (Sat, 30 May 2009) | 2 lines winetricks: minor ie6 fixes ------------------------------------------------------------------------ r471 | austinenglish | 2009-05-30 12:07:52 -0700 (Sat, 30 May 2009) | 2 lines winetricks: fix vcrun2008sp1 for old wine versions (1.0.1) ------------------------------------------------------------------------ r470 | austinenglish | 2009-05-30 08:48:48 -0700 (Sat, 30 May 2009) | 2 lines winetricks: make sure to run gunzip in a separate shell ------------------------------------------------------------------------ r467 | austinenglish | 2009-05-28 17:01:27 -0700 (Thu, 28 May 2009) | 2 lines winetricks: add a note about fixing local keystores for OpenSolaris ------------------------------------------------------------------------ r466 | austinenglish | 2009-05-28 16:50:17 -0700 (Thu, 28 May 2009) | 2 lines winetricks: fix busted urls and make a new release ------------------------------------------------------------------------ r465 | austinenglish | 2009-05-28 16:49:11 -0700 (Thu, 28 May 2009) | 2 lines winetricks: fix typo in last patch (liberation opensolaris fix) ------------------------------------------------------------------------ r464 | austinenglish | 2009-05-28 16:35:22 -0700 (Thu, 28 May 2009) | 2 lines winetricks: fix liberation verb for systems without tar (Patch by Matt Lewandowsky) ------------------------------------------------------------------------ r462 | austinenglish | 2009-05-27 21:29:30 -0700 (Wed, 27 May 2009) | 2 lines winetricks: disable services for wmp9/wmp10 ------------------------------------------------------------------------ r461 | austinenglish | 2009-05-27 21:09:51 -0700 (Wed, 27 May 2009) | 2 lines winetricks: fix ie6 install ------------------------------------------------------------------------ r460 | austinenglish | 2009-05-27 00:38:10 -0700 (Wed, 27 May 2009) | 2 lines winetricks: fix ie6 verb for non-english locales ------------------------------------------------------------------------ r439 | austinenglish | 2009-04-20 20:26:21 -0700 (Mon, 20 Apr 2009) | 2 lines winetricks: add gecko-dbg verb ------------------------------------------------------------------------ r438 | austinenglish | 2009-04-19 18:49:30 -0700 (Sun, 19 Apr 2009) | 2 lines winetricks: add version function ------------------------------------------------------------------------ r430 | austinenglish | 2009-04-06 23:40:27 -0700 (Mon, 06 Apr 2009) | 2 lines winetricks: fix download for fontfix verb ------------------------------------------------------------------------ r422 | austinenglish | 2009-03-30 17:15:39 -0700 (Mon, 30 Mar 2009) | 2 lines winetricks: add a sanity check to prevent running as sudo ------------------------------------------------------------------------ r420 | austinenglish | 2009-03-29 14:02:50 -0700 (Sun, 29 Mar 2009) | 2 lines winetricks: override rest of d3dx9_xx dlls. Patch by Rico Schüller ------------------------------------------------------------------------ r419 | austinenglish | 2009-03-29 13:59:36 -0700 (Sun, 29 Mar 2009) | 2 lines winetricks: update directx to March 2009 release ------------------------------------------------------------------------ r416 | austinenglish | 2009-03-29 08:44:32 -0700 (Sun, 29 Mar 2009) | 2 lines winetricks: updated a couple comments ------------------------------------------------------------------------ r415 | austinenglish | 2009-03-27 16:03:28 -0700 (Fri, 27 Mar 2009) | 2 lines winetricks: fix gecko for FreeBSD ------------------------------------------------------------------------ r412 | austinenglish | 2009-03-26 21:38:19 -0700 (Thu, 26 Mar 2009) | 3 lines winetricks: avoid 'echo -n', it's not portable and breaks on Solaris. Patch by Dan Kegel. ------------------------------------------------------------------------ r403 | austinenglish | 2009-03-22 18:32:47 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: release 20090322 ------------------------------------------------------------------------ r401 | austinenglish | 2009-03-22 17:41:31 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: load wsh56 for controlpad ------------------------------------------------------------------------ r400 | austinenglish | 2009-03-22 17:32:12 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: couple minor changes ------------------------------------------------------------------------ r399 | austinenglish | 2009-03-22 17:21:16 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add native overrides for ole2 ------------------------------------------------------------------------ r398 | austinenglish | 2009-03-22 17:03:11 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: load dotnet20 for vjrun20 ------------------------------------------------------------------------ r397 | austinenglish | 2009-03-22 16:54:39 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: fix kde download link, update to latest stable ------------------------------------------------------------------------ r396 | austinenglish | 2009-03-22 16:39:09 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add fontsmoothing options ------------------------------------------------------------------------ r395 | austinenglish | 2009-03-22 16:07:21 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: fix msmask, make case insensitive ------------------------------------------------------------------------ r394 | austinenglish | 2009-03-22 16:02:27 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: update divx to divx7 ------------------------------------------------------------------------ r393 | austinenglish | 2009-03-22 12:33:55 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add a few more synonmys for some keywords ------------------------------------------------------------------------ r392 | austinenglish | 2009-03-22 12:30:17 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added xact keyword. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r391 | austinenglish | 2009-03-22 12:25:21 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: refactor directx download into a helper function. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r390 | austinenglish | 2009-03-22 12:18:24 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added vb2run keyword. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r389 | austinenglish | 2009-03-22 12:14:44 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added vcrun2008sp1 keyword. Patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r388 | austinenglish | 2009-03-22 11:49:44 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: added d3dx9 redistributable. Based on patch by Erik Inge Bolsø. ------------------------------------------------------------------------ r387 | austinenglish | 2009-03-22 11:13:55 -0700 (Sun, 22 Mar 2009) | 2 lines winetricks: add msvcrt override for vcrun6 ------------------------------------------------------------------------ r386 | austinenglish | 2009-03-12 16:23:58 -0700 (Thu, 12 Mar 2009) | 2 lines winetricks: fix vlc download link ------------------------------------------------------------------------ r380 | daniel.r.kegel | 2009-02-27 09:04:02 -0800 (Fri, 27 Feb 2009) | 2 lines Update flash ------------------------------------------------------------------------ r376 | austinenglish | 2009-02-25 13:54:52 -0800 (Wed, 25 Feb 2009) | 2 lines Use builtin ole/rpc for a couple more builtin apps ------------------------------------------------------------------------ r343 | daniel.r.kegel | 2009-02-16 18:30:21 -0800 (Mon, 16 Feb 2009) | 2 lines Document license requirements better ------------------------------------------------------------------------ r337 | daniel.r.kegel | 2009-02-14 16:18:03 -0800 (Sat, 14 Feb 2009) | 2 lines Clarify mfc42, since people were installing both it and vcrun6 ------------------------------------------------------------------------ r335 | daniel.r.kegel | 2009-02-14 15:07:08 -0800 (Sat, 14 Feb 2009) | 3 lines Added wme9 Updated gecko for 1.1.15 ------------------------------------------------------------------------ r298 | daniel.r.kegel | 2009-02-09 08:04:49 -0800 (Mon, 09 Feb 2009) | 3 lines Fix a solaris problem, warn users that quicktime needs gdiplus, make version name obvious to someone looking at the top of the file ------------------------------------------------------------------------ r266 | daniel.r.kegel | 2009-01-21 06:55:58 -0800 (Wed, 21 Jan 2009) | 2 lines Fix tahoma to include tahomabd, needed for Steam.

1 0

Re: wined3d:
by James McKenzie 07 Jun '09

07 Jun '09

Pavel Prochazka wrote: There is an open bug for this problem, 14746. Can you clean up and attach your fix to this bug so that others can try it? I did apply it cleanly, through three steps to version 1.1.22 of Wine. James McKenzie

1 0

Re: [Bugzilla]: Refuse to accept comments with big number of logs / back traces
by Austin English 07 Jun '09

07 Jun '09

On Sun, Jun 7, 2009 at 12:25 PM, Vitaliy Margolen<wine-patches(a)kievinfo.com> wrote: > > The limits are: > 20 lines for logs (fixme, trace, err, warn) > 10 lines for back traces > --- > Bugzilla/Bug.pm | 7 +++++++ > template/en/default/global/user-error.html.tmpl | 4 ++++ > 2 files changed, 11 insertions(+), 0 deletions(-) While I'm hugely in favor of this, AFAICT, this blocks everyone from doing so, correct? What about developers that know what they're doing, or Anastasius? -- -Austin

2 1

Re: d3d9: ATI1N support
by Henri Verbeet 07 Jun '09

07 Jun '09

2009/6/7 Frank Richter <frank.richter(a)gmail.com>: > +/* Download data for a compressed surface */ > +static void surface_download_data_compressed(IWineD3DSurfaceImpl *This, const struct GlPixelFormatDesc *format_desc) { > + TRACE("(%p) : Calling glGetCompressedTexImageARB level %d, format %#x, type %#x, data %p\n", > + This, This->glDescription.level, format_desc->glFormat, format_desc->glType, > + This->resource.allocatedMemory); > + > + if(This->Flags & SFLAG_PBO) { > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, This->pbo)); > + checkGLcall("glBindBufferARB"); > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, This->glDescription.level, NULL)); > + checkGLcall("glGetCompressedTexImageARB()"); > + GL_EXTCALL(glBindBufferARB(GL_PIXEL_PACK_BUFFER_ARB, 0)); > + checkGLcall("glBindBufferARB"); > + } else { > + GL_EXTCALL(glGetCompressedTexImageARB(This->glDescription.target, This->glDescription.level, This->resource.allocatedMemory)); > + checkGLcall("glGetCompressedTexImageARB()"); > + } > +} Please don't add tabs. I also think wined3d would be more appropriate as module name for these patches.

1 0

Test box tagged [dr-asus]
by Nikolay Sivov 07 Jun '09

07 Jun '09

Hi. Does anyone no whose box is it (dr-asus)? It has some (actually always 10) test failures for ListView and I think it's possible to find a cause. Same failures on 2k and XP actually. I'd like to contact owner for testing some patches. Thanks.

5 4

cd-roms that need unhide
by Dan Kegel 07 Jun '09

07 Jun '09

Despite jwhite's kernel fix, http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h… I find I have to use 'norock' on some discs, e.g. Macromedia Studio 8, http://bugs.winehq.org/show_bug.cgi?id=9467 Microsoft Dynamics GP demo, http://bugs.winehq.org/show_bug.cgi?id=8178 ... and the stupid DKNY perfume promo DVD-ROM that came in the newspaper today. Running it with Wine yields... a black screen, as the flash player can't get at its data. Mounting the DKNY disc with -o unhide or -o norock lets it work fine with wine. Here's what one sees without either flag: $ ls /media/cdrom/ -l total 3668 dr-xr-xr-x 2 4294967295 4294967295 40 2007-07-24 15:54 AUDIO_TS -r-xr-xr-x 1 4294967295 4294967295 2144972 2007-07-17 20:18 DKNYDeliciousNight -r-xr-xr-x 1 4294967295 4294967295 1602372 2007-07-17 20:18 DKNYDeliciousNight.exe -r-xr-xr-x 1 4294967295 4294967295 1616 2007-02-14 06:34 Readme.txt dr--r--r-- 3 4294967295 4294967295 560 2007-07-24 15:54 VIDEO_TS (The VIDEO_TS directory is not searchable! ) Here's what one sees with unhide: dank@lappy:~$ ls -l /media/cdrom/ total 3788 dr-xr-xr-x 2 4294967295 4294967295 40 2007-07-24 15:54 AUDIO_TS -r-xr-xr-x 1 4294967295 4294967295 67 2007-07-05 11:20 autorun.inf dr-xr-xr-x 2 4294967295 4294967295 1032 2007-07-09 12:11 backgroundLoops dr-xr-xr-x 2 4294967295 4294967295 92 2007-06-25 14:48 css -rwxr-xr-x 1 4294967295 4294967295 1024 2007-01-03 08:47 Desktop DB -rwxr-xr-x 1 4294967295 4294967295 2 2007-01-03 08:47 Desktop DF -r-xr-xr-x 1 4294967295 4294967295 2144972 2007-07-17 20:18 DKNYDeliciousNight -r-xr-xr-x 1 4294967295 4294967295 1602372 2007-07-17 20:18 DKNYDeliciousNight.exe -r-xr-xr-x 1 4294967295 4294967295 97566 2007-06-27 14:30 DKNYDeliciousNight.ico dr-xr-xr-x 2 4294967295 4294967295 244 2007-07-13 09:30 exit dr-xr-xr-x 2 4294967295 4294967295 3400 2007-07-17 17:18 flv dr-xr-xr-x 9 4294967295 4294967295 684 2007-07-18 15:41 fscommand -r-xr-xr-x 1 4294967295 4294967295 1616 2007-02-14 06:34 Readme.txt dr-xr-xr-x 2 4294967295 4294967295 240 2007-07-09 12:11 soundFx dr-xr-xr-x 2 4294967295 4294967295 996 2007-07-18 18:50 swf dr--r--r-- 3 4294967295 4294967295 560 2007-07-24 15:54 VIDEO_TS dr-xr-xr-x 2 4294967295 4294967295 140 2007-07-05 09:23 xml (The VIDEO_TS directory is not searchable, but the app works anyway. ) norock is similar, but VIDEO_TS is searchable. Given that these poorly mastered discs are turning up periodically -- widely distributed -- it seems like it might be time for another kernel change, or at least some userland kludge that does a remount. The heuristic I imagine is: If the top level directory has any subdirectories that are completely nonsearchable or nonreadable, remount with unhide. What say? Would this help users more than it would hurt? - Dan

2 2

Re: [PATCH] This patch fixes context menu crashes for edit controls as apparent in vb apps.
by Reece Dunn 07 Jun '09

07 Jun '09

2009/6/7 Michael Martin <martinmnet(a)hotmail.com>: You'll need to include the patch as an attachment (renamed as a text file if your mail client messes up the encoding), instead of including it in the body text (the indentation in the patch you included has been removed by your mail client). > + BOOL selectedMenuItem; > ... > + selectedMenuItem = TrackPopupMenu(popup, TPM_LEFTALIGN | TPM_RIGHTBUTTON | > TMPRETURNCMD, x, y, 0, es->hwndSelf, NULL); > + switch (selectedMenuItem) { Despite TrackPopupMenu having a BOOL return type, using an int would make it more readable (selectedMenuItem is not being used as a boolean value, but as a command index). Alternatively, just use: switch (TrackPopupMenu(...)) { TMPRETURNCMD -- This should be TMP_RETURNCMD. Is this an error when adding the patch to the email? Thanks for contributing to Wine, - Reece

1 0

Re: [2/5] WineD3D: Implement loops with the NV extensions
by Allan Tong 07 Jun '09

07 Jun '09

This is using PUSHA and POPA without setting the NV_vertex_program3 option in the shader. - Allan

1 0

Re: [3/5] WineD3D: Unroll loops in ARB if GL_NV_vertex_program2_option is not supported
by James Mckenzie 06 Jun '09

06 Jun '09

Stefan Dösinger <stefan(a)codeweavers.com> wrote about [3/5] WineD3D: Unroll loops in ARB if GL_NV_vertex_program2_option is not supported Stefan: Could this not a be a function: + for(i = 0; i < MAX_CONST_I; i++) + { + if(int_skip & (1 << i)) + { + args->loop_ctrl[i][0] = 0; + args->loop_ctrl[i][1] = 0; + args->loop_ctrl[i][2] = 0; + } + else + { + args->loop_ctrl[i][0] = stateblock->pixelShaderConstantI[i * 4]; + args->loop_ctrl[i][1] = stateblock->pixelShaderConstantI[i * 4 + 1]; + args->loop_ctrl[i][2] = stateblock->pixelShaderConstantI[i * 4 + 2]; + } + } Also, it looks like you did not count correctly: + if(vshader) + { + /* Count and aL start value are unsigned */ + ret[0] = priv->cur_vs_args->loop_ctrl[idx][0]; + ret[1] = priv->cur_vs_args->loop_ctrl[idx][1]; + /* The step/stride is signed */ + ret[2] = ((char) priv->cur_vs_args->loop_ctrl[idx][3]); + } + else + { + ret[0] = priv->cur_ps_args->loop_ctrl[idx][0]; + ret[1] = priv->cur_ps_args->loop_ctrl[idx][1]; + ret[2] = ((char) priv->cur_ps_args->loop_ctrl[idx][3]); + } + return ret; A little explanation might help here. James McKenzie

1 0

Re: [3/5] WineD3D: Unroll loops in ARB if GL_NV_vertex_program2_option is not supported
by Henri Verbeet 06 Jun '09

06 Jun '09

2009/6/7 Stefan Dösinger <stefan(a)codeweavers.com>: > +/* Not reentrant! */ > +static inline const int *get_int_const(const struct wined3d_shader_instruction *ins, IWineD3DBaseShaderImpl *This, DWORD idx) > +{ > + BOOL vshader = shader_is_vshader_version(This->baseShader.reg_maps.shader_version.type); > + WORD flag = (1 << idx); > + const local_constant *constant; > + struct shader_arb_ctx_priv *priv = ins->ctx->backend_data; > + > + if(This->baseShader.reg_maps.local_int_consts & flag) > + { > + static const int err_ret[4] = {0, 0, 0, 0}; > + /* What good is a if(bool) with a hardcoded local constant? I don't know, but handle it */ > + LIST_FOR_EACH_ENTRY(constant, &This->baseShader.constantsI, local_constant, entry) > + { > + if (constant->idx == idx) > + { > + return (int *) constant->value; > + } > + } > + ERR("Local constant not found\n"); > + return err_ret; > + } > + else > + { > + static int ret[4]; > + ret[3] = 0; > + if(vshader) > + { > + /* Count and aL start value are unsigned */ > + ret[0] = priv->cur_vs_args->loop_ctrl[idx][0]; > + ret[1] = priv->cur_vs_args->loop_ctrl[idx][1]; > + /* The step/stride is signed */ > + ret[2] = ((char) priv->cur_vs_args->loop_ctrl[idx][3]); > + } > + else > + { > + ret[0] = priv->cur_ps_args->loop_ctrl[idx][0]; > + ret[1] = priv->cur_ps_args->loop_ctrl[idx][1]; > + ret[2] = ((char) priv->cur_ps_args->loop_ctrl[idx][3]); > + } > + return ret; > + } > +} I said I wouldn't be reviewing arb_program_shader.c changes (and I'm not, in general), but I couldn't help noticing this bit of code. *blink*? > + const int *control_values = get_int_const(ins, This, ins->src[0].reg.idx); > + list_init(&priv->record); > + priv->recording = TRUE; > + control_frame->outer_loop = TRUE; > + control_frame->loop_control[0] = control_values[0]; > + control_frame->loop_control[1] = control_values[1]; > + control_frame->loop_control[1] = control_values[2]; This is either a typo or redundant.

1 0

Re: [1/5] WineD3D: Store the bumpmap ARB constants in ARB structures
by Henri Verbeet 06 Jun '09

06 Jun '09

I think the actual patch is missing.

1 0

[setupapi/tests] pSetupGetField is A or W depending on OS
by Paul Vriens 06 Jun '09

06 Jun '09

Hi, Sent to wine-devel for some feedback. I was checking for more lstrcmpW's (not supported on Win9x) and found one in setupapi/tests/parser.c. After some checking it turns out that it returns an ANSI string on Win9x and a Unicode one on NT4 and higher. There is no export of pSetupGetField[AW] on any of the platforms. The attached patch takes care of that but I have a feeling this patch could be written in a better way. Suggestions, hints, remarks? -- Cheers, Paul. diff --git a/dlls/setupapi/tests/parser.c b/dlls/setupapi/tests/parser.c index a67a5cd..3b4682e 100644 --- a/dlls/setupapi/tests/parser.c +++ b/dlls/setupapi/tests/parser.c @@ -32,14 +32,16 @@ /* function pointers */ static HMODULE hSetupAPI; -static LPCWSTR (WINAPI *pSetupGetField)(PINFCONTEXT,DWORD); +static LPCSTR (WINAPI *pSetupGetFieldA)(PINFCONTEXT,DWORD); +static LPCWSTR (WINAPI *pSetupGetFieldW)(PINFCONTEXT,DWORD); static BOOL (WINAPI *pSetupEnumInfSectionsA)( HINF hinf, UINT index, PSTR buffer, DWORD size, UINT *need ); static void init_function_pointers(void) { hSetupAPI = GetModuleHandleA("setupapi.dll"); - pSetupGetField = (void *)GetProcAddress(hSetupAPI, "pSetupGetField"); + pSetupGetFieldA = (void *)GetProcAddress(hSetupAPI, "pSetupGetField"); + pSetupGetFieldW = (void *)GetProcAddress(hSetupAPI, "pSetupGetField"); pSetupEnumInfSectionsA = (void *)GetProcAddress(hSetupAPI, "SetupEnumInfSectionsA" ); } @@ -497,7 +499,14 @@ static const char *contents = "[Version]\n" "[Strings]\n" "RTMQFE_NAME = \"RTMQFE\"\n"; -static const WCHAR getfield_res[][20] = +static const CHAR getfield_resA[][20] = +{ + "RTMQFE", + "%RTMGFE_NAME%", + "SP1RTM", +}; + +static const WCHAR getfield_resW[][20] = { {'R','T','M','Q','F','E',0}, {'%','R','T','M','G','F','E','_','N','A','M','E','%',0}, @@ -509,10 +518,18 @@ static void test_pSetupGetField(void) UINT err; BOOL ret; HINF hinf; - LPCWSTR field; + LPCSTR fieldA; + LPCWSTR fieldW; INFCONTEXT context; int i; int len; + BOOL unicode = TRUE; + + /* Nice, pSetupGetField is either A or W depending on the Windows version! */ + SetLastError(0xdeadbeef); + lstrcmpW(NULL, NULL); + if (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) + unicode = FALSE; hinf = test_file_contents( contents, &err ); ok( hinf != NULL, "Expected valid INF file\n" ); @@ -524,23 +541,47 @@ static void test_pSetupGetField(void) for ( i = 0; i < 3; i++ ) { - field = pSetupGetField( &context, i ); - ok( field != NULL, "Failed to get field %i\n", i ); - ok( !lstrcmpW( getfield_res[i], field ), "Wrong string returned\n" ); + if (unicode) + { + fieldW = pSetupGetFieldW( &context, i ); + ok( fieldW != NULL, "Failed to get field %i\n", i ); + ok( !lstrcmpW( getfield_resW[i], fieldW ), "Wrong string returned\n" ); + } + else + { + fieldA = pSetupGetFieldA( &context, i ); + ok( fieldA != NULL, "Failed to get field %i\n", i ); + ok( !lstrcmpA( getfield_resA[i], fieldA ), "Wrong string returned\n" ); + } } - field = pSetupGetField( &context, 3 ); - ok( field != NULL, "Failed to get field 3\n" ); - len = lstrlenW( field ); - ok( len == 511 /* NT4, W2K, XP and W2K3 */ || - len == 4096 /* Vista */ || - len == 256 /* Win9x and WinME */, - "Unexpected length, got %d\n", len ); - - field = pSetupGetField( &context, 4 ); - ok( field == NULL, "Expected NULL, got %p\n", field ); - ok( GetLastError() == ERROR_INVALID_PARAMETER, - "Expected ERROR_INVALID_PARAMETER, got %u\n", GetLastError() ); + if (unicode) + { + fieldW = pSetupGetFieldW( &context, 3 ); + ok( fieldW != NULL, "Failed to get field 3\n" ); + len = lstrlenW( fieldW ); + ok( len == 511 || /* NT4, W2K, XP and W2K3 */ + len == 4096, /* Vista */ + "Unexpected length, got %d\n", len ); + + fieldW = pSetupGetFieldW( &context, 4 ); + ok( fieldW == NULL, "Expected NULL, got %p\n", fieldW ); + ok( GetLastError() == ERROR_INVALID_PARAMETER, + "Expected ERROR_INVALID_PARAMETER, got %u\n", GetLastError() ); + } + else + { + fieldA = pSetupGetFieldA( &context, 3 ); + ok( fieldA != NULL, "Failed to get field 3\n" ); + len = lstrlenA( fieldA ); + ok( len == 511, /* Win9x, WinME */ + "Unexpected length, got %d\n", len ); + + fieldA = pSetupGetFieldA( &context, 4 ); + ok( fieldA == NULL, "Expected NULL, got %p\n", fieldA ); + ok( GetLastError() == ERROR_INVALID_PARAMETER, + "Expected ERROR_INVALID_PARAMETER, got %u\n", GetLastError() ); + } SetupCloseInfFile( hinf ); }

1 0

Одговор: Одговор: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by Milan Kostić 06 Jun '09

06 Jun '09

2009/6/6, Henri Verbeet <hverbeet(a)gmail.com>: > 2009/6/6 Milan Kostić <smoki00790(a)gmail.com>: >> Deafulting to fbo is good, but it should be more good to leave also >> prior working support for backbuffer on older cards who not have >> EXT_framebuffer_object. Reverting to >> "OffscreenRenderingMode"="backbuffer" is not working as expected for >> me on r200 Mesa/DRI drivers, for example in Max Payne 2 which now >> can't be even starting with backbuffer, Rayman 2 and Dungen Siege 2 >> also. In 1.1.22>= they worked. >> > Please do a regression test to find the exact commit that breaks > "OffscreenRenderingMode"="backbuffer", and file a bug report. > Sorry i can't do regression test right now, slow connection (dial-up).

1 0

Re: gdiplus: Add test cases for GdipDrawCurve [corrected]
by Andrew Eikum 06 Jun '09

06 Jun '09

This patch was submitted back on Tuesday and I haven't received a response one way or the other about it. Does anyone see anything immediately wrong with it? I more-or-less copied the functionality of test_GdipDrawBezier right above, testing each of the different input possibilities for correctness. It passes 100% on WinXP SP3 and Win7 RC1, although there are failures in Wine's GdipDrawCurve implementation. Thanks for taking a look, Andrew

3 6

Одговор: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by Milan Kostić 06 Jun '09

06 Jun '09

Deafulting to fbo is good, but it should be more good to leave also prior working support for backbuffer on older cards who not have EXT_framebuffer_object. Reverting to "OffscreenRenderingMode"="backbuffer" is not working as expected for me on r200 Mesa/DRI drivers, for example in Max Payne 2 which now can't be even starting with backbuffer, Rayman 2 and Dungen Siege 2 also. In 1.1.22>= they worked.

4 3

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 06 Jun '09

06 Jun '09

On 06/05/2009 08:15 PM, Austin English wrote: > On Fri, Jun 5, 2009 at 7:11 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> Tried it several times.. and different iterations of the registry keys >> (you will find them attached) and both cases it fails the same way any >> of the d3d tests will fail or the machine locks up. >> > ????????

7 8

Re: user32/edit: Check for Null before strlen(try2)
by Nikolay Sivov 06 Jun '09

06 Jun '09

André Hentschel wrote: > related to Bug 4742 > try2: fixed indentation > --- > dlls/user32/edit.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) --- - countA = strlen(textA) + 1; + if(textA) + countA = strlen(textA) + 1; } --- Previous lines use 2 tabs and 4 spaces after. Also a test is needed, looks like bug contains already something to start with.

3 4

Socks support in ws2_32
by Gabriele Greco 06 Jun '09

06 Jun '09

Hello guys, I'm lurking this list since a pair of weeks but I've not yet posted here. I've added socks 4/5 support right inside of ws2_32 library, I've tested it with various applications and it works correctly both with sync and async sockets (only TCP). The code works very well also with fairly intensive network apps like "world of warcraft" :) At the moment the support is activated by enviroment variables (SOCKS_SERVER/SOCKS_PROTOCOL/SOCKS_USER/...) and the code is not very clean. I've seen that wine patches are not accepted if not cleaned up, so I wanted to ask if my effort can be of any interest for the official GIT or if I'll have to mantain it for myself on my local GIT (I've written this patch mostly for personal use since I need socks support to use certain services cut down by the company firewall). Obviously if there is any interest to see socks support inside wine I'll try to clean up the patch and make it follow the specs that the wine socks support is supposed to have (for instance configurability through winecfg for example). -- Bye, Gabry

6 5

Re: [1/5] user32: Added tests for DrawIcon and DrawIconEx
by Paul Vriens 06 Jun '09

06 Jun '09

Joel Holdsworth wrote: > > ------------------------------------------------------------------------ > > Hi Joel, I've run your new tests on Win95, Win98 and NT4 (all VMware): Win95: ====== cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 00A0B0C0 with DrawIcon. Expected 00003163. Got 00003868 from line 1130 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 00A0B0C0 with DrawIcon. Expected 00FFCE9C. Got 00FFD0A0 from line 1131 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color FFA0B0C0 with DrawIcon. Expected 00003163. Got 00003868 from line 1133 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIcon. Expected 00FFCE9C. Got 00FFD0A0 from line 1134 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIcon. Expected 00003163. Got 00003868 from line 1135 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIcon. Expected 00FFCE9C. Got 00FFD0A0 from line 1136 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 00A0B0C0 with DrawIconEx flags 00000003. Expected 00003163. Got 00003868 from line 1262 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 00A0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C. Got 00FFD0A0 from line 1263 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00003163. Got 00003868 from line 1265 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C. Got 00FFD0A0 from line 1266 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00003163. Got 00003868 from line 1267 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C. Got 00FFD0A0 from line 1268 Win98: ====== cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 00A0B0C0 with DrawIcon. Expected 00003163. Got 00003868 from line 1130 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 00A0B0C0 with DrawIcon. Expected 00FFCE9C. Got 00FFD0A0 from line 1131 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color FFA0B0C0 with DrawIcon. Expected 00003163. Got 00003868 from line 1133 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIcon. Expected 00FFCE9C. Got 00FFD0A0 from line 1134 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIcon. Expected 00003163. Got 00003868 from line 1135 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIcon. Expected 00FFCE9C. Got 00FFD0A0 from line 1136 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIcon. Expected 00C0B0A0. Got 003F4F5F from line 1081 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIcon. Expected 00605850. Got 00C0B0A0 from line 1083 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIcon. Expected 00605850. Got 00C0B0A0 from line 1084 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIcon. Expected 00DFD7CF. Got 00C0B0A0 from line 1085 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIcon. Expected 00DFD7CF. Got 003F4F5F from line 1086 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 01FFFFFF with DrawIcon. Expected 00010101. Got 00FFFFFF from line 1088 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 01FFFFFF with DrawIcon. Expected 00010101. Got 00FFFFFF from line 1089 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color FEFFFFFF with DrawIcon. Expected 00FEFEFE. Got 00FFFFFF from line 1090 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color FEFFFFFF with DrawIcon. Expected 00FEFEFE. Got 00FFFFFF from line 1091 cursoricon.c:1056: Test failed: Alpha blending. Expected 00FFFFFF with DrawIcon. Got 00C0B0A0 from line 1099 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIcon. Expected 00C0B0A0. Got 003F4F5F from line 1081 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIcon. Expected 00605850. Got 00C0B0A0 from line 1083 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIcon. Expected 00605850. Got 00C0B0A0 from line 1084 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIcon. Expected 00DFD7CF. Got 00C0B0A0 from line 1085 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIcon. Expected 00DFD7CF. Got 003F4F5F from line 1086 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color 01FFFFFF with DrawIcon. Expected 00010101. Got 00FFFFFF from line 1088 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color 01FFFFFF with DrawIcon. Expected 00010101. Got 00FFFFFF from line 1089 cursoricon.c:1013: Test failed: Overlaying Mask 0 on Color FEFFFFFF with DrawIcon. Expected 00FEFEFE. Got 00FFFFFF from line 1090 cursoricon.c:1013: Test failed: Overlaying Mask 1 on Color FEFFFFFF with DrawIcon. Expected 00FEFEFE. Got 00FFFFFF from line 1091 cursoricon.c:1056: Test failed: Alpha blending. Expected 00FFFFFF with DrawIcon. Got 00C0B0A0 from line 1099 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 00A0B0C0 with DrawIconEx flags 00000003. Expected 00003163. Got 00003868 from line 1262 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 00A0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C. Got 00FFD0A0 from line 1263 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00003163. Got 00003868 from line 1265 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C. Got 00FFD0A0 from line 1266 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00003163. Got 00003868 from line 1267 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00FFCE9C. Got 00FFD0A0 from line 1268 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00C0B0A0. Got 003F4F5F from line 1213 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00605850. Got 00C0B0A0 from line 1215 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00605850. Got 00C0B0A0 from line 1216 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00DFD7CF. Got 00C0B0A0 from line 1217 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00DFD7CF. Got 003F4F5F from line 1218 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 01FFFFFF with DrawIconEx flags 00000003. Expected 00010101. Got 00FFFFFF from line 1220 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 01FFFFFF with DrawIconEx flags 00000003. Expected 00010101. Got 00FFFFFF from line 1221 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color FEFFFFFF with DrawIconEx flags 00000003. Expected 00FEFEFE. Got 00FFFFFF from line 1222 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color FEFFFFFF with DrawIconEx flags 00000003. Expected 00FEFEFE. Got 00FFFFFF from line 1223 cursoricon.c:1056: Test failed: Alpha blending. Expected 00FFFFFF with DrawIconEx. Got 00C0B0A0 from line 1231 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color FFA0B0C0 with DrawIconEx flags 00000003. Expected 00C0B0A0. Got 003F4F5F from line 1213 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00605850. Got 00C0B0A0 from line 1215 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00605850. Got 00C0B0A0 from line 1216 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00DFD7CF. Got 00C0B0A0 from line 1217 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 80A0B0C0 with DrawIconEx flags 00000003. Expected 00DFD7CF. Got 003F4F5F from line 1218 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color 01FFFFFF with DrawIconEx flags 00000003. Expected 00010101. Got 00FFFFFF from line 1220 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color 01FFFFFF with DrawIconEx flags 00000003. Expected 00010101. Got 00FFFFFF from line 1221 cursoricon.c:1028: Test failed: Overlaying Mask 0 on Color FEFFFFFF with DrawIconEx flags 00000003. Expected 00FEFEFE. Got 00FFFFFF from line 1222 cursoricon.c:1028: Test failed: Overlaying Mask 1 on Color FEFFFFFF with DrawIconEx flags 00000003. Expected 00FEFEFE. Got 00FFFFFF from line 1223 cursoricon.c:1056: Test failed: Alpha blending. Expected 00FFFFFF with DrawIconEx. Got 00C0B0A0 from line 1231 NT4: ==== No failures. Is there another way you can detect whether some XP (and up) tests can be run? We generally try not to use GetVersion() in our tests. -- Cheers, Paul.

4 7

Re: user32/edit: Check for Null before strlen
by Paul Vriens 06 Jun '09

06 Jun '09

André Hentschel wrote: > related to Bug 4742 > --- > dlls/user32/edit.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi André, Your mixing tabs and spaces. -- Cheers, Paul.

1 0

Re: website: mention bugzilla registration on sending_patches
by Henri Verbeet 06 Jun '09

06 Jun '09

2009/6/6 Jeff Zaroyko <jeffzaroyko(a)gmail.com>: > + <li>Register an account on the Wine bugzilla with the email address you use to send patches. Why would I do that?

2 2

Deadlock under Supreme Commander in d3d9 main.c
by James McKenzie 06 Jun '09

06 Jun '09

As reported in another thread, Supreme Commander's graphic display slows considerably (<1 FPS), and if run in a terminal session a large number of lines are show in the terminal, but one line in particular is interesting to the poster: > Additionally, I am using a GeForce 7600GS card with the latest drivers (180.60, I believe - I'm not in front of it right now, but it's definitely the latest) The error itself is: > > > Code: > err:ntdll:RtlpWaitForCriticalSection section 0x7e114810 "d3d9_main.c: d3d9_cs" > wait timed out in thread 001f, blocked by 0009, retrying (60 sec) > This appears to be a revisit of the deadlocking issue as reported in bug 14746, but according to another triage person, this is not so. I would like to know if code has been moved from x11drv.c to d3d9_main.c that would cause this error and for the framerate to drop considerably. Thank you. James McKenzie

2 1

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 06 Jun '09

06 Jun '09

Using this attached Reg File Is still a no go... same... (I forgot the Direct3D tag but added it and no change) Chris

2 1

re: Socks support in ws2_32
by Dan Kegel 06 Jun '09

06 Jun '09

Gabriele Greco wrote: > I've added socks 4/5 support right inside of ws2_32 library... very cool! Juan wrote: > The usual test is whether Windows supports something. If Windows > has SOCKS support in ws2_32, then certainly, we're interested. If not, > figuring out how Windows does it and adding support for that method is > more likely to get accepted. http://msdn.microsoft.com/en-us/library/aa383996(VS.85).aspx says Windows has SOCKS support in the 27KB Wsock32n.dll The public API for using it is in wininet.dll. Annoyingly, that all requires the app to be aware of socks. - Dan

1 0

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 06 Jun '09

06 Jun '09

On 06/05/2009 09:16 PM, Austin English wrote: > On Fri, Jun 5, 2009 at 8:03 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> On 06/05/2009 08:15 PM, Austin English wrote: >> >>> On Fri, Jun 5, 2009 at 7:11 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: >>> >>> >>>> Tried it several times.. and different iterations of the registry keys >>>> (you will find them attached) and both cases it fails the same way any >>>> of the d3d tests will fail or the machine locks up. >>>> >>>> >>> >> ???????? >> > Use that attached .reg file. > > > Which one I attached two and neither of them worked at all.. Chris

1 0

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 06 Jun '09

06 Jun '09

Tried it several times.. and different iterations of the registry keys (you will find them attached) and both cases it fails the same way any of the d3d tests will fail or the machine locks up.

2 1

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

On 06/05/2009 05:10 PM, Roderick Colenbrander wrote: > Check the useful registry keys page at wiki.winehq.org (it is > Direct3D/OffscreenRenderingMethod) > > Roderick > > On Fri, Jun 5, 2009 at 10:41 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> On 06/05/2009 04:32 PM, Roderick Colenbrander wrote: >> >>> As of Wine 1.1.23 wined3d made FBOs the default offscreen rendering >>> method. If you are using a non-nvidia card (those in general have >>> buggier drivers) that could explain all the failures. Setting >>> OffscreenRenderingMethod to backbuffer restores the old behavior. >>> >>> Roderick >>> >>> On Fri, Jun 5, 2009 at 10:04 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: >>> >>> >>>> Something majorly changed and is wrong with the latest GIT tree. >>>> Between the comits yesterday and today 90% of the tests get exceptions >>>> or fail. >>>> All of the d3d tests get a process exception and fail with a dialog box. >>>> >>>> >>>> Ideas? >>>> >>>> Chris >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> >> where do I set that? >> >> >> >> >> >> >> >> >> > > Added the registry key and no go... still failure... Chris

1 0

Re: Alexandre Julliard : winegcc: Create a stub main to work around the lack of Unicode support in Mingw.
by Steven Edwards 05 Jun '09

05 Jun '09

On Fri, Jun 5, 2009 at 9:56 AM, Alexandre Julliard<julliard(a)winehq.org> wrote: > winegcc: Create a stub main to work around the lack of Unicode support in Mingw. Thank you. The mingw developers policy opposing adding this entry point baffles me. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

On 06/05/2009 04:32 PM, Roderick Colenbrander wrote: > As of Wine 1.1.23 wined3d made FBOs the default offscreen rendering > method. If you are using a non-nvidia card (those in general have > buggier drivers) that could explain all the failures. Setting > OffscreenRenderingMethod to backbuffer restores the old behavior. > > Roderick > > On Fri, Jun 5, 2009 at 10:04 PM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> Something majorly changed and is wrong with the latest GIT tree. >> Between the comits yesterday and today 90% of the tests get exceptions >> or fail. >> All of the d3d tests get a process exception and fail with a dialog box. >> >> >> Ideas? >> >> Chris >> >> >> >> >> >> >> >> >> >> >> > > where do I set that?

2 1

Latest Git build 7aeffc442cc1 for Wine 1.1.23
by chris ahrendt 05 Jun '09

05 Jun '09

Something majorly changed and is wrong with the latest GIT tree. Between the comits yesterday and today 90% of the tests get exceptions or fail. All of the d3d tests get a process exception and fail with a dialog box. Ideas? Chris

2 1

Regression in "ntdll: Free old memory"
by Niklas Hambüchen 05 Jun '09

05 Jun '09

There is something wrong with commit 13a33b73c349530b17347d3ec6a1f5bb268cc917 (ntdll: Free old memory block when reallocating to a large block.). Having this this patch applied (as it is in wine-1.1.22), some applications show a strange behavior, for example Guild Wars does not start up (it keeps "repairing" on and on). git revert 13a33b73c349530b17347d3ec6a1f5bb268cc917 does the trick, but most probably this is not the solution. The regression test was: 13a33b73c349530b17347d3ec6a1f5bb268cc917 is first bad commit commit 13a33b73c349530b17347d3ec6a1f5bb268cc917 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat May 16 11:33:06 2009 +0200 ntdll: Free old memory block when reallocating to a large block. :040000 040000 e210ab3f16dee6da3a6b6b34d375737b103d5951 25abcf5a437d9a494593e654553dd2797066f616 M dlls Thank you!

2 2

Re: mpr: Added an implementation of test cases
by Stefan Leichter 05 Jun '09

05 Jun '09

Am Friday 05 June 2009 17:27:32 schrieb Vitaly Perov: You need to check if GetProcAddress succeeded. If GetProcAddress failed call win_skip and don't try to execute WNetGetUniversalNameW -- Stefan

2 1

Re: [08/10] wined3d: Use FBOs for offscreen rendering by default.
by paulo lesgaz 05 Jun '09

05 Jun '09

The point is that the tests are uncorrect: Here is I obtain in a real windows Vista box: http://test.winehq.org/data/8d0cb61bc7760c4ab254c3a5bb751bded3a6f4ed/vista_… visual.c:183: Driver string: "nvd3dum.dll" visual.c:184: Description string: "NVIDIA GeForce Go 7600" visual.c:185: Device name string: "\\.\DISPLAY1" visual.c:186: Driver version 7.15.11.7692 visual.c:8868: Tests skipped: D3DFMT_R16F textures not supported visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:9690: Test failed: Input 0xff000000: Got color 0x00008700 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x004bff1c for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00b30000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xff0000ff: Got color 0x000030e1 for pixel 2/1, expected 0x004bffff, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x00ffff00: Got color 0x00ffd01c for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x0000ffff: Got color 0x004bffff for pixel 2/1, expected 0x000030e1, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xffff00ff: Got color 0x00b300e1 for pixel 2/1, expected 0x00ff79ff, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x00b30000, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x000030e1, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 2/1, expected 0x000030e1, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0x000000ff: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_YUY2 visual.c:9686: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_YUY2 visual.c:9690: Test failed: Input 0xffff0000: Got color 0x00000000 for pixel 2/1, expected 0x00ffd01c, format D3DFMT_YUY2 So, something is wrong in wined3d implementation. David --- En date de : Ven 5.6.09, Alexandre Julliard <julliard(a)winehq.org> a écrit : De: Alexandre Julliard <julliard(a)winehq.org> Objet: Re: [08/10] wined3d: Use FBOs for offscreen rendering by default. À: "Henri Verbeet" <hverbeet(a)codeweavers.com> Cc: wine-devel(a)winehq.org Date: Vendredi 5 Juin 2009, 14h38 Henri Verbeet <hverbeet(a)codeweavers.com> writes: > Alexandre Julliard wrote: >> It doesn't work here: >> >> ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok >> visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests >> visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY >> visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY >> visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY >> visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY >> visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_UYVY >> visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00ffffff for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY >> visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_UYVY >> [...many more...] >> make: *** [visual.ok] Error 72 >> > Does the attached patch make it any better? Yes, that fixes it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] msi: Initialize some variables.
by Austin English 05 Jun '09

05 Jun '09

On Thu, Jun 4, 2009 at 3:12 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > diff --git a/dlls/msi/registry.c b/dlls/msi/registry.c > index 3ba34d1..f22c01f 100644 > --- a/dlls/msi/registry.c > +++ b/dlls/msi/registry.c > @@ -1822,7 +1822,7 @@ static UINT msi_check_product_patches(LPCWSTR prodcode, LPCWSTR usersid, > LPWSTR patch, LPWSTR targetprod, MSIINSTALLCONTEXT *targetctx, > LPWSTR targetsid, DWORD *sidsize, LPWSTR *transforms) > { > - MSIPATCHSTATE state; > + MSIPATCHSTATE state = MSIPATCHSTATE_INVALID; > LPWSTR ptr, patches = NULL; > HKEY prod, patchkey = 0; > HKEY localprod = 0, localpatch = 0; > diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c > index a9eef76..3263ec1 100644 > --- a/dlls/msi/tests/package.c > +++ b/dlls/msi/tests/package.c > @@ -939,6 +939,7 @@ static void test_settargetpath(void) > sz = sizeof tempdir - 1; > r = MsiGetTargetPath( hpkg, "TARGETDIR", tempdir, &sz ); > sprintf( file, "%srootfile.txt", tempdir ); > + buffer[0] = 0; > query_file_path( hpkg, "[#RootFile]", buffer ); > ok( r == ERROR_SUCCESS, "failed to get target path: %d\n", r); > ok( !lstrcmp(buffer, file), "Expected %s, got %s\n", file, buffer ); > @@ -11057,8 +11058,8 @@ static void test_access(void) > > static void test_emptypackage(void) > { > - MSIHANDLE hpkg, hdb, hsuminfo; > - MSIHANDLE hview, hrec; > + MSIHANDLE hpkg = 0, hdb = 0, hsuminfo = 0; > + MSIHANDLE hview = 0, hrec = 0; > MSICONDITION condition; > CHAR buffer[MAX_PATH]; > DWORD size; > > > Howdy Hans, One of your recent msi patches (I suspect this one), causes several hundred failures/succeeding todo's on my previously passing box. Could you have a look: http://test.winehq.org/data/1a0a47d60c337ca096c26da291adf82e49770f34/wine_a… -- -Austin

2 2

Re: [3/3] wininet: Add missing empty line to end of headers list
by Alexandre Julliard 05 Jun '09

05 Jun '09

Jason Green <jave27(a)gmail.com> writes: > @@ -4265,6 +4265,24 @@ static INT HTTP_GetResponseHeaders(LPWININETHTTPREQW lpwhr, BOOL clear) > } > }while(1); > > + /* make sure the response header is terminated with an empty line. Some apps really > + truly care about that empty line being there for some reason. If it's not present, > + just add it to the header. */ > + if (cchRawHeaders >= 4 && > + (strcmpW(&lpszRawHeaders[cchRawHeaders - 4], szCrLf) || > + strcmpW(&lpszRawHeaders[cchRawHeaders - 2], szCrLf))) > + { This check doesn't seem necessary, I don't see how you could already have an empty line in the buffer since we only store valid headers. -- Alexandre Julliard julliard(a)winehq.org

2 2

Implementation of User32.PrintWindow - Try 2
by Josselin Bardet 05 Jun '09

05 Jun '09

Hi Second proposition patch for User32.PrintWindows Regards Jos

1 0

Implementation of the User32.PrintWindow
by Josselin Bardet 05 Jun '09

05 Jun '09

Hi, As next of the discussion on the bug 18772 (http://bugs.winehq.org/show_bug.cgi?id=18772), I send here the implemenation for User32.PrintWindow function I've tested it with an application that was crashing because of this unimplemented function. Regards Jos

2 4

Re: [08/10] wined3d: Use FBOs for offscreen rendering by default.
by Alexandre Julliard 05 Jun '09

05 Jun '09

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > From f8dd196de73ca81019b01f3fdae56b47985e63b6 Mon Sep 17 00:00:00 2001 > From: Henri Verbeet <hverbeet(a)codeweavers.com> > Date: Fri, 5 Jun 2009 10:10:48 +0200 > Subject: wined3d: Use FBOs for offscreen rendering by default. It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:7572: Tests skipped: Card has unconditional pow2 support, skipping conditional NP2 tests visual.c:9686: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x00000000: Got color 0x00000000 for pixel 2/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 1/1, expected 0x00008700, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0xff000000: Got color 0x00000000 for pixel 2/1, expected 0x004bff1c, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0x00ff0000: Got color 0x00000000 for pixel 1/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9690: Test failed: Input 0x00ff0000: Got color 0x00ffffff for pixel 2/1, expected 0x00b30000, format D3DFMT_UYVY visual.c:9686: Test failed: Input 0x0000ff00: Got color 0x00000000 for pixel 1/1, expected 0x004bff1c, format D3DFMT_UYVY [...many more...] make: *** [visual.ok] Error 72 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: try3 [1/2] kernel32/tests: Fix tests to pass on Win9x and WinME
by Alexandre Julliard 05 Jun '09

05 Jun '09

Guy Albertelli <galberte(a)neo.rr.com> writes: > Changelog > - Fix new tests for CreateFileA to pass on Win9x and WinME > - Fix tests for when GetVolumeNameForVolumeMountPointA fails. Please send separate changes as separate patches. > @@ -829,13 +830,17 @@ static void test_CreateFileA(void) > } > /* otherwise validate results with expectations */ > else if (p[i].todo_flag) > - todo_wine ok((hFile == INVALID_HANDLE_VALUE && p[i].err == GetLastError()) || > + todo_wine ok( > + (hFile == INVALID_HANDLE_VALUE && (p[i].err == GetLastError() || > + (p[i].err2 == -1 ? TRUE : p[i].err2 == GetLastError()))) || Please don't use -1 for DWORD values. Also your check will make the test useless for cases that have only one possible error. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mlang/tests: Fix failures with IE 5.5 and below
by Paul Vriens 05 Jun '09

05 Jun '09

Detlef Riekenberg wrote: > On Mi, 2009-06-03 at 10:50 +0200, Paul Vriens wrote: >> This patch introduces test failures on what seems: >> >> - all Win95 boxes >> - some Win98 boxes >> - some W2K boxes > >> Could you have a look? > > Here is a fix. > > Hi Detlef, Is there no way to have a broken() in here: + /* IE <6.0 guess 0x412 (ko) from "kok" */ + if (lcid_table[i].alternate_lcid && (lcid_table[i].lcid != -1)) { + ok(ret == S_OK || ret == S_FALSE, + "#%02d: HRESULT 0x%x (expected S_OK or S_FALSE)\n", i, ret); and the same a bit further down? -- Cheers, Paul.

1 0

Re: gdiplus: Stub for GdipCreateBitmapFromDirectDrawSurface
by Alexandre Julliard 05 Jun '09

05 Jun '09

Andrew Eikum <andrew(a)brightnightgames.com> writes: > diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h > index 501e6ed..4ba329f 100644 > --- a/include/gdiplusflat.h > +++ b/include/gdiplusflat.h > @@ -27,6 +27,8 @@ > extern "C" { > #endif > > +#include <ddraw.h> gdiplusflat.h is not supposed to depend on ddraw.h. -- Alexandre Julliard julliard(a)winehq.org

2 1

Implementation of the User32.PrintWindow
by Josselin Bardet 04 Jun '09

04 Jun '09

Hi, As next of the discussion on the bug 18772 (http://bugs.winehq.org/show_bug.cgi?id=18772), I send here the implemenation for User32.PrintWindow function I've tested it with an application that was crashing because of this unimplemented function. Regards Jos

1 0

Today's git may have a problem -- install takes forever then crashes
by Susan Cragin 04 Jun '09

04 Jun '09

Today's git starts the installation of DNS very-very slowly. Then takes forever. I thought finally it was going to install but then it crashes at/near the end. Tail of log below. fixme:ole:CoCreateInstance no instance created for interface {d94a9b75-516c-41ec-8163-f1ac8ab03b29} of class {fff2d28f-e4ee-44d9-8104-8e71556757f6}, hres is 0xc0000005 wine: Unhandled page fault on read access to 0x00000000 at address 0x412f7d (thread 007d), starting debugger... susan@ubuntu:~/DNS$ Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00412f7d). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:00412f7d ESP:0033fb00 EBP:0033fe6c EFLAGS:00210212( R- -- I -A- - ) EAX:00000000 EBX:00000000 ECX:00000000 EDX:00000000 ESI:00475908 EDI:0046f754 Stack dump: 0x0033fb00: 001300fc 00000004 0044a687 00000000 0x0033fb10: 7b8c5ff4 0012fa88 0033fb38 7ffdf000 0x0033fb20: 7e1cfff4 00000001 7e1bc63b 7e1cfff4 0x0033fb30: 00000001 7e190000 0033fb78 7e1b1ff7 0x0033fb40: 00000003 7e1d7928 7e1c9207 7e1c7822 0x0033fb50: 7e190000 00000001 00000000 00000000 Backtrace: =>0 0x00412f7d in agent (+0x12f7d) (0x0033fe6c) 1 0x0044a767 in agent (+0x4a767) (0x0033fef8) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value szNlsKeyName (a) 2 0x7b8778ef start_process+0xdf(arg=(nil)) [/home/susan/wine/dlls/kernel32/process.c:941] in kernel32 (0x0033ffe8) 0x00412f7d: movl 0x0(%eax),%ecx Modules: Module Address Debug info Name (69 modules) PE 400000- 491000 Export agent ELF 7b800000-7b962000 Dwarf kernel32<elf> \-PE 7b820000-7b962000 \ kernel32 ELF 7bc00000-7bcb9000 Deferred ntdll<elf> \-PE 7bc10000-7bcb9000 \ ntdll ELF 7bf00000-7bf04000 Deferred <wine-loader> ELF 7e15e000-7e182000 Deferred mpr<elf> \-PE 7e160000-7e182000 \ mpr ELF 7e182000-7e1d8000 Deferred wininet<elf> \-PE 7e190000-7e1d8000 \ wininet ELF 7e226000-7e25a000 Deferred uxtheme<elf> \-PE 7e230000-7e25a000 \ uxtheme ELF 7e25a000-7e265000 Deferred libxcursor.so.1 ELF 7e265000-7e26b000 Deferred libxfixes.so.3 ELF 7e26b000-7e26f000 Deferred libxcomposite.so.1 ELF 7e26f000-7e278000 Deferred libxrandr.so.2 ELF 7e278000-7e282000 Deferred libxrender.so.1 ELF 7e282000-7e288000 Deferred libxxf86vm.so.1 ELF 7e288000-7e28b000 Deferred libxinerama.so.1 ELF 7e28b000-7e2ad000 Deferred imm32<elf> \-PE 7e290000-7e2ad000 \ imm32 ELF 7e2ad000-7e2b2000 Deferred libxdmcp.so.6 ELF 7e2b2000-7e2d0000 Deferred libxcb.so.1 ELF 7e2d0000-7e2d4000 Deferred libxau.so.6 ELF 7e2d4000-7e2d9000 Deferred libuuid.so.1 ELF 7e2d9000-7e409000 Deferred libx11.so.6 ELF 7e409000-7e419000 Deferred libxext.so.6 ELF 7e419000-7e434000 Deferred libice.so.6 ELF 7e434000-7e43d000 Deferred libsm.so.6 ELF 7e44d000-7e4ef000 Deferred winex11<elf> \-PE 7e460000-7e4ef000 \ winex11 ELF 7e51c000-7e543000 Deferred libexpat.so.1 ELF 7e543000-7e570000 Deferred libfontconfig.so.1 ELF 7e580000-7e596000 Deferred libz.so.1 ELF 7e596000-7e615000 Deferred libfreetype.so.6 ELF 7e615000-7e629000 Deferred lz32<elf> \-PE 7e620000-7e629000 \ lz32 ELF 7e629000-7e644000 Deferred version<elf> \-PE 7e630000-7e644000 \ version ELF 7e644000-7e73b000 Deferred oleaut32<elf> \-PE 7e660000-7e73b000 \ oleaut32 ELF 7e73b000-7e7ad000 Deferred rpcrt4<elf> \-PE 7e750000-7e7ad000 \ rpcrt4 ELF 7e7ad000-7e8bd000 Deferred ole32<elf> \-PE 7e7d0000-7e8bd000 \ ole32 ELF 7e8bd000-7e98b000 Deferred comctl32<elf> \-PE 7e8d0000-7e98b000 \ comctl32 ELF 7e98b000-7e9ee000 Deferred shlwapi<elf> \-PE 7e9a0000-7e9ee000 \ shlwapi ELF 7e9ee000-7eb83000 Deferred shell32<elf> \-PE 7ea00000-7eb83000 \ shell32 ELF 7eb83000-7ec2e000 Deferred gdi32<elf> \-PE 7eb90000-7ec2e000 \ gdi32 ELF 7ec2e000-7ed8a000 Deferred user32<elf> \-PE 7ec50000-7ed8a000 \ user32 ELF 7ed8a000-7ee14000 Deferred crypt32<elf> \-PE 7ed90000-7ee14000 \ crypt32 ELF 7ee14000-7ee6e000 Deferred advapi32<elf> \-PE 7ee20000-7ee6e000 \ advapi32 ELF 7ee6e000-7ee87000 Deferred libnsl.so.1 ELF 7ee87000-7ee90000 Deferred libnss_compat.so.2 ELF 7efca000-7eff0000 Deferred libm.so.6 ELF 7eff4000-7f000000 Deferred libnss_files.so.2 ELF b7c40000-b7c4b000 Deferred libnss_nis.so.2 ELF b7c4d000-b7c51000 Deferred libdl.so.2 ELF b7c51000-b7db4000 Deferred libc.so.6 ELF b7db5000-b7dce000 Deferred libpthread.so.0 ELF b7dde000-b7f1b000 Deferred libwine.so.1 ELF b7f1d000-b7f3b000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000c 00000012 0 0000000e 0 0000000d 0 0000000f 00000015 0 00000014 0 00000011 0 00000010 0 00000016 00000017 0 0000007c 0000002c 0 0000008b 0 00000093 0 0000008f 0 00000088 0 00000082 0 00000083 0 00000081 0 0000007f 0 00000096 0000007b 0 0000008c (D) C:\Program Files\Common Files\InstallShield\UpdateService\agent.exe 0000000b 0 0000008d 0 0000007d 0 <== Backtrace: =>0 0x00412f7d in agent (+0x12f7d) (0x0033fe6c) 1 0x0044a767 in agent (+0x4a767) (0x0033fef8) 2 0x7b8778ef start_process+0xdf(arg=(nil)) [/home/susan/wine/dlls/kernel32/process.c:941] in kernel32 (0x0033ffe8) susan@ubuntu:~/DNS$

1 0

re: wine question
by Dan Kegel 04 Jun '09

04 Jun '09

Anna wrote: > I am trying to call Win32 Dll (that is built in VS 2003) from C++ > Linux application ( in Ubuntu ) through wine shared object without > rebuild the application with wine. Sorry, it's not generally possible to use Windows libraries inside a Linux program directly with Wine. Wine is jealous, and wants control of the whole program right from the start. Your main options are: 1) write a small Windows program that uses the DLL, run it via Wine, and talk to it from the Linux program using sockets and/or shared memory 2) run the Windows version of the app altogether in Wine There are ways to do what you want directly without Wine, but only for very restricted types of DLLs that do not make any Windows system calls. What does the DLL do? - Dan

1 0

[RESEND] mountmgr.sys: implement forced setting of fixed/local disk
by Ben Klein 04 Jun '09

04 Jun '09

define_unix_drive in mountmgr.c includes all cases used in query_unix_drive except the DRIVE_FIXED == DEVICE_HARDDISK_VOL mapping. This patch fixes 17618 where setting the drive type to "Local disk" in winecfg does not save the change to the registry. I've CC'd wine-devel in the hope of getting some feedback this time. This is the 3rd or 4th time I've submitted this patch.

2 3

Re: (resend, 2nd) kernel32: Implement QueryFullProcessImageNameA (2nd try)
by Alexandre Julliard 04 Jun '09

04 Jun '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > /****************************************************************** > + * QueryFullProcessImageNameA (KERNEL32.@) > + */ > +BOOL WINAPI QueryFullProcessImageNameA(HANDLE hProcess, DWORD dwFlags, LPSTR lpExeName, PDWORD pdwSize) > +{ > + BOOL retval; > + DWORD pdwSizeW = *pdwSize; > + LPWSTR lpExeNameW = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, *pdwSize * sizeof(WCHAR)); > + > + retval = QueryFullProcessImageNameW(hProcess, dwFlags, lpExeNameW, &pdwSizeW); > + > + if(retval) { > + if(lpExeName) > + *pdwSize = FILE_name_WtoA(lpExeNameW, pdwSizeW, lpExeName, *pdwSize); > + else { > + /* this is a difference between the acsii and the unicode version (vista) > + * the unicode version crashes when the size is big enough to hold the result > + * ascii version throughs an error > + */ > + retval = FALSE; > + SetLastError(ERROR_INVALID_PARAMETER); > + } > + } I'd expect that error to be a side effect of WideCharToMultiByte, which is most likely what you want to use here. Also you have to handle buffer overflows correctly, with test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Fix DateConstr_value (with one argument) implementation (3/9)
by Alexandre Julliard 04 Jun '09

04 Jun '09

Piotr Caban <piotr.caban(a)gmail.com> writes: > + FILETIME ft_now, ft_epoch; > + SYSTEMTIME st_epoch; > + DOUBLE time_now, time_epoch; > + > + memset(&st_epoch, 0, sizeof(SYSTEMTIME)); > + st_epoch.wYear = 1970; > + st_epoch.wMonth = 1; > + st_epoch.wDay = 1; > + SystemTimeToFileTime(&st_epoch, &ft_epoch); > + > + GetSystemTimeAsFileTime(&ft_now); > > - GetSystemTimeAsFileTime(&time); > + time_now = (DOUBLE)ft_now.dwHighDateTime/10000*UINT_MAX > + + (DOUBLE)ft_now.dwLowDateTime/10000; > + time_epoch = (DOUBLE)ft_epoch.dwHighDateTime/10000*UINT_MAX > + + (DOUBLE)ft_epoch.dwLowDateTime/10000; This is not correct, you need a <<32. Also there's no reason to use doubles for the computation, and you shouldn't have to use SystemTimeToFileTime for the epoch, it can be a constant. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32/tests: Add tests for message sequence of window destruction at thread exit.
by Paul Vriens 04 Jun '09

04 Jun '09

Hi Alexandre, I assume you've already seen the test failures on some boxes. Looks like the WmExitThreadSeq sequence is not always the same. -- Cheers, Paul.

1 0

Re: (try2) [1/2] kernel32/tests: Add tests for CreateFile errors and opening volumes
by Paul Vriens 04 Jun '09

04 Jun '09

Guy Albertelli wrote: > Changelog: > - Add tests to verify error codes returned for certain error cases. > - Also add tests for opening volumes and handle the case where we do > not have the rights to access the volume. > --- > dlls/kernel32/tests/file.c | 326 +++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 324 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Guy, The newly added tests introduce some failures on Win9x and WinME. Could you have a look? -- Cheers, Paul.

2 1

Re: Alexandre Julliard : clock: Build resource files separately instead of including them all from a global file .
by Michael Stefaniuc 03 Jun '09

03 Jun '09

Hello Alexandre, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: aa41526c73a5fbcc2c08a9342107ee76173a2b97 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa41526c73a5fbcc2c08a9342… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Sun May 31 20:11:00 2009 +0200 > > clock: Build resource files separately instead of including them all from a global file. there is a minor problem with this approach. wrc --verify-translation becomes useless as each file is separate and a comparison to the English default resource is no longer possible. That's what Mikołaj Zalewski's Wine translation statistics webpage http://www.mikolaj.zalewski.pl/wine-transl/ is using. I also have a makefile patch/hack in my i18n branch to do a wrc --verify-translation pass for each .rc file. Very useful to find problems when doing translation work. bye michael

1 0

The present state of Direct3D in WINE
by MD.IMAM HOSSAIN 03 Jun '09

03 Jun '09

Dear, WINE Developers, Thanks to all of you for creating an environment where people can enjoy games. I very much pleased by the present state of WINE's Direct3D. In my short range of views on earlier versions of wine Grend Theft Auto San Andreas runs very slowly. But now it is very playable. On WINE 1.1.22 all the improvement made to Direct3D is good but there are some incompatibilities too. >From my experiment with recent version of WINE 1.1.22 : 3DMark 2001 has vertex shader problem (Under Game Lobby and Vertex Shader test). Hitman 2 Silent Assassin (No Human Body could be seen). Hitman 3 Contracts (No Human Body could be seen). Prince of Persia Sand of Time (Nothing could be seen). Prince of Persia Warrior Within (Nothing could be seen). I only able to test these games. I hope coming WINE release will fix these problem. Your sincerely, MD.IMAM HOSSAIN

3 4

AppDB backlog of test reports for apps with maintainers
by Rosanne DiMesio 03 Jun '09

03 Jun '09

There is a growing backlog of test reports for apps with maintainers still awaiting approval. My understanding of how things are supposed to work is that if a maintainer does not process a report within a week, they are sent a couple of reminder notices, and eventually removed as maintainer if they don't respond. This appears to not be working--the backlog goes back to May 19. I can process the reports myself, of course, but can someone check on what's going on with notifying/removing maintainers? There was a similar backlog about a month ago, but someone (I assume another admin) eventually processed all the reports, and I think the underlying cause was never looked into. -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Problem with async. comm from Wine to a USB->Serial-converter
by Henrik Jacobsson 03 Jun '09

03 Jun '09

Hi. I just got myself a USB-GPS (GlobalSat BU-353) and wanted to run SeaClearII, a navigation-program with it. Turns out that Wine got confused when the USB->Serial-driver wasn't acting like a real serial-device though. The app does what it's supposed to do, but Wine consumes 100% of the available CPU. After some googling I found a patch that resolved this issue perfectly, and I'm curious why it never made it into trunk. The patch: http://www.nabble.com/serial-04-04%3A-fix%3A-WaitCommEvent()-does-not-work-… I only managed to apply this patch to 1.1.17. Later releases had changed too much for my non-programmer-brain to cope with.. I would really appreciate if someone in the know could check the patch out and if possible apply it to wine-proper.. Thanks in advance.. /Henrik

3 3

Testing with Comctl32 6.0 (and further versions)
by Nikolay Sivov 03 Jun '09

03 Jun '09

Hi. I'm thinking about adding a possibility to test both previous comctl32 and version 6 (or greater maybe in next versions). For example if I compiled in a manifest resource for 6.0 I'll get 6.0 loaded on >= XP, but the best variant for me is to load not manifest aware version first, then unload it (if can't be done automatically) and switch to manifest specified version. Is it possible to do it for example with creating activation context manually (i'm not familiar with it)? Maybe it's easier to create another test target (e.g. comct32_v6_test.exe and its cross built counterpart) - the reason here is to run existing tests on 6.0 too, probably building with some #defines specific for V6 version to tweak test results if there are any difference. Any thoughts? Nikolay S.

1 0

wine question
by Anna Rogov 03 Jun '09

03 Jun '09

Dear Sir, I am trying to call Win32 Dll (that is built in VS 2003) from C++ Linux application ( in Ubuntu ) through wine shared object without rebuild the application with wine. I'll be glad if you can help me with this task. Looking forward for hearing from you, Thank you, Best Regards, Anna Udolovitch ( Papernova ), Cel.: 972-544-910623

1 0

Re: jscript: Fix parse_double_literal implementation
by Alexandre Julliard 03 Jun '09

03 Jun '09

Piotr Caban <piotr.caban(a)gmail.com> writes: > @@ -382,13 +383,23 @@ static int parse_double_literal(parser_ctx_t *ctx, LONG int_part, literal_t **li > } > > d = int_part; > - while(ctx->ptr < ctx->end && isdigitW(*ctx->ptr)) > - d = d*10 + *(ctx->ptr++) - '0'; > + while(ctx->ptr < ctx->end && isdigitW(*ctx->ptr)) { > + hlp = d*10 + *(ctx->ptr++) - '0'; > + if(d > LLONG_MAX/10 || hlp<0) > + exp++; > + else > + d = hlp; > + } LLONG_MAX is not portable, you'll have to provide your own definition. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mlang/tests: [Patch 4] Add tests for LcidToRfc1766
by Paul Vriens 03 Jun '09

03 Jun '09

Detlef Riekenberg wrote: > > > ------------------------------------------------------------------------ > > Hi Detlef, This patch introduces test failures on what seems: - all Win95 boxes - some Win98 boxes - some W2K boxes See: http://test.winehq.org/data/tests/mlang:mlang.html There is one XP both with a lot of failures in this test but not because of these newly added ones. Could you have a look? -- Cheers, Paul.

1 0

Re: jscript: Added NAN definition (1/10)
by Alexandre Julliard 03 Jun '09

03 Jun '09

Piotr Caban <piotr.caban(a)gmail.com> writes: > diff --git a/dlls/jscript/jscript_main.c b/dlls/jscript/jscript_main.c > index 37266e5..740bb06 100644 > --- a/dlls/jscript/jscript_main.c > +++ b/dlls/jscript/jscript_main.c > @@ -38,6 +38,21 @@ static const CLSID CLSID_JScriptAuthor = > static const CLSID CLSID_JScriptEncode = > {0xf414c262,0x6ac0,0x11cf,{0xb6,0xd1,0x00,0xaa,0x00,0xbb,0xbb,0x58}}; > > +#ifndef NAN > +DOUBLE NAN; > + > +static inline void set_jsnan(void) > +{ > + VARIANT v; > + V_UI8(&v) = (ULONGLONG)0x7ff80000<<32; > + NAN = V_R8(&v); > +} > +#else > +static inline void set_jsnan(void) > +{ > +} > +#endif > + > DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); > > static HINSTANCE jscript_hinstance; > @@ -110,6 +125,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) > return FALSE; /* prefer native version */ > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls(hInstDLL); > + set_jsnan(); > jscript_hinstance = hInstDLL; > break; The previous implementation was better, having to explicitly initialize the constant on startup is ugly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Tests passing on one more platform!
by Dan Kegel 03 Jun '09

03 Jun '09

I just had a look at http://test.winehq.org and it seems that as of a couple days ago, a Win2000 machine has started passing all the tests! That's three OSs now: Win2000, Win2003, and WinXP. (Not all systems with those OSs pass the tests, but still, having even one box per OS pass them is a nice milestone.) Congratulations and thanks to all the people (notably Paul Vriens and of course Alexandre) who have been cleaning up the tests! - Dan

3 2

Extending winemenubuilder to create Application Bundles on OS X
by Steven Edwards 03 Jun '09

03 Jun '09

Hi, Recently I've been doing a lot of hacking on my local tree for OS X projects. The lack of support in winemenubuilder to generate application bundles for installed applications from ShellLinks like we do for FreeDesktop items has been killing me. I've just been building simple wrapper scripts which is fine but very ugly. I've recently spoken with Sveinbjorn Thordarson who wrote the Platypus App Bundler (which is a very kick-ass utility) and he has allowed me to use his code under LGPL to extend winemenubuilder. Some nice things about Platypus is that while its written in Objective C, its very modular and already has an optional cli interface. I'm pretty sure I can isolate out all of the stuff we don't need in short order and extend winemenubuilder a bit with its code as a reference. I'm going to file a detailed bug report describing how we need to extend winemenubuilder, what application bundles are, and what else we will need. If anyone is interested in jumping in and helping, we still need to do conversion from *.ico to a *.icns icons which requires a bit of hacking. Currently I'm doing something like the following 1. hacked winemenubuilder converts and export the icon (*.ico file) to png 2. convert from png to tiff sips -s format tiff [png file] --out [(converted file).tiff] 3. Convert tiff to icns tiff2icns -noLarge [tiff file] [icns file] I kind of doubt Alexandre will want a patch doing all of this conversion for simple icons and I'm sure someone has to have documented icns somewhere. The iPhone App bundles seem to support *.png icons but from my reading it does not seem that standard OS X applications do. Maybe this will change in Snow Leopard, I've tried to hack my test bundles and make them use normal png images without much luck. If your interested in helping, researching this and if needed, adding exporting the icon resources straight to icns would be a good place to start. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo ---------- Forwarded message ---------- From: Sveinbjorn Thordarson <sveinbjornt(a)simnet.is> Date: Sat, May 30, 2009 at 9:13 AM Subject: Re: Web Email Form: Developing a Platypus-lite for Wine To: winehacker(a)gmail.com Hello there, I would be happy to relicense parts of the Platypus code under the LGPL. Please feel free to use it as you like under those terms. All the best, Sveinbjorn Thordarson On 30 May 2009, at 04:22, winehacker(a)gmail.com wrote: > Hi, > I am writing because I am wondering if you would be willing to relicense some code I might need under the LGPL. > > I am interested in adding support to Wine's menubuilding application which creates FreeDesktop menus and desktop launchers under Linux for Windows based applications. Currently it parses either a *.lnk or a given executable to generate a *.desktop file for use under Gnome or KDE. When running Wine under OS X, it for the most part sucks because we cannot generate menus of any type. I'd like to take platypus, rip out everything I don't need and just use parts of it in winemenubuilder. > > The only problem is Wine is LGPL and your project is GPL. Since I know NOTHING of Obj-C and am new to OS X development in general your tool would save me a lot of time as a frame of reference but I do not wish to violate your copyright in any way. > > Would it be acceptable for me to use parts of your code under the LGPL in this fashion? > > Thanks > Steven >

1 0

Re: gdiplus: Add test cases for GdipDrawCurve
by Vincent Povirk 03 Jun '09

03 Jun '09

+ /* make a graphics object and pen object */ + status = GdipCreateFromHDC(hdc, &graphics); + expect(Ok, status); + ok(hdc != NULL, "Expected HDC to be initialized\n"); + + status = GdipCreateFromHDC(hdc, &graphics); + expect(Ok, status); + ok(graphics != NULL, "Expected graphics to be initialized\n"); You're creating two graphics objects here and leaking the first one. Vincent Povirk On Tue, Jun 2, 2009 at 10:39 PM, Andrew Eikum<andrew(a)brightnightgames.com> wrote: > Tested on WinXP Professional SP3 and Win7 Ultimate RC1, all pass. > > --- > dlls/gdiplus/tests/graphics.c | 64 +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 64 insertions(+), 0 deletions(-) > > > >

3 2

Re: (resend) [1/2] kernel32/tests: Add tests for CreateFile errors and opening volumes
by Alexandre Julliard 03 Jun '09

03 Jun '09

Guy Albertelli <galberte(a)neo.rr.com> writes: > + hFile = CreateFileA( filename, GENERIC_READ | GENERIC_WRITE, > + FILE_SHARE_READ | FILE_SHARE_WRITE, > + NULL, OPEN_EXISTING, > + p[i].options, NULL ); > + if (p[i].todo_flag) > + todo_wine ok((hFile == INVALID_HANDLE_VALUE && p[i].err == GetLastError()) || > + (hFile != INVALID_HANDLE_VALUE && p[i].err == ERROR_SUCCESS), > + "CreateFileA failed on %s, hFile %p, err=%u, should be %u\n", > + filename, hFile, GetLastError(), p[i].err); > + else > + ok((hFile == INVALID_HANDLE_VALUE && p[i].err == GetLastError()) || > + (hFile != INVALID_HANDLE_VALUE && p[i].err == ERROR_SUCCESS), > + "CreateFileA failed on %s, hFile %p, err=%u, should be %u\n", > + filename, hFile, GetLastError(), p[i].err); You need to handle access denied errors here too. You can't assume that you can always open a drive for read/write access. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Alexandre Julliard : rpcrt4: Change the allocation of delegated stub methods so that we never need to free them .
by Steven Edwards 02 Jun '09

02 Jun '09

On Tue, Jun 2, 2009 at 9:44 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > +#define MAX_BLOCKS 64 /* 64k methods should be enough for anybody */ lol, best. comment. ever! -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

HICON Patches - Request for reviews
by Joel Holdsworth 02 Jun '09

02 Jun '09

Hi All, I've been working on alpha support in HICONs and HIMAGELISTs. This patch set includes my earlier test patch (plus modifications as per the comments), and fixes up DrawIcon, DrawIconEx and CURSORICON_CreateIconFromBMI. I've tested the test patch on 2k, XP, and Vista - but any other test platforms would be welcome, and any comments on the other 4 patches before I submit them. Best Regards Joel Holdsworth

1 0

Re: [2/5] libwine: Add a generic red-black tree.
by Alexandre Julliard 02 Jun '09

02 Jun '09

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > +void wine_rb_init(struct wine_rb_tree *tree, wine_rb_compare_func_t *compare) > +{ > + tree->compare = compare; > + tree->root = NULL; > + tree->stack.entries = malloc(16 * sizeof(*tree->stack.entries)); > + if (!tree->stack.entries) > + { > + ERR("Failed to allocate stack memory.\n"); > + } You can't hardcode malloc(), the allocator needs to be configurable, particularly for use from the memory management code. Also printing an ERR in that sort of code is not acceptable, errors need to be propagated correctly and handled by the user. I also still think this would be better as inline functions, at least until it stabilizes. We don't want to change the libwine interface any more than strictly necessary. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [ole32/tests] Fix a crash on NT4
by Paul Vriens 02 Jun '09

02 Jun '09

Paul Vriens wrote: > Changelog > Fix a crash on NT4 > Please don't use this one. I will soon sent a few others to replace this one. -- Cheers, Paul.

1 0

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)
by Stephan Rose 02 Jun '09

02 Jun '09

>(reply didn't go to list as I expected, grr..) > >> Naw, it should still work normally. I've done aligned & rotated text under >windows before with DrawTextW, you still pass the rect like you would if it >wasn't rotated and set the alignment flags. The world transform should take >care of getting it all rotated to where it is supposed to be with the >alignments in the right place. > >Maybe, but builtin gdiplus has its own world transform and doesn't use >the gdi32 one. That's what transform_and_round_points is for. True but you're still using the GDI32 DrawText to actually render the text. transform_and_round_points is only doing what it says, transforming the coordinates. If you rotate the text by 90 degrees, DrawText is still going to have to be aware that the text is to be rotated 90 degrees to draw it correctly or else you'll get your text at the right position, but the text direction will be wrong. Unless I'm overlooking something? > >> Ok question then, how do I separate this into two patches? Never done >anything with patches like this before so this is a first for me. > >Just make two commits in Git, and format-patch will create two patch files. > That makes sense but, one question there. Does this mean I'm going to have to restore the file to it's original state, then add the one change, commit, add the other change, then commit again? With a change of this size, that isn't that big a deal. But on larger changes I could see that being a bit problematic. But maybe I'm just not used to it. =) Thanks, Stephan

3 3

Re: kernel32/tests: Add tests for GetLocaleInfo with SUBLANG_NEUTRAL
by Paul Vriens 02 Jun '09

02 Jun '09

Detlef Riekenberg wrote: > Add tests to show, that GetLocaleInfo assume SUBLANG_DEFAULT, > when called with an LCID that provide SUBLANG_NEUTRAL > > > > > ------------------------------------------------------------------------ > > Hi Detlef, This one introduces failures on NT4 and below and on some boxes with a non-English locale. Could you have a look? -- Cheers, Paul.

2 1

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)
by Vincent Povirk 02 Jun '09

02 Jun '09

(reply didn't go to list as I expected, grr..) > Naw, it should still work normally. I've done aligned & rotated text under windows before with DrawTextW, you still pass the rect like you would if it wasn't rotated and set the alignment flags. The world transform should take care of getting it all rotated to where it is supposed to be with the alignments in the right place. Maybe, but builtin gdiplus has its own world transform and doesn't use the gdi32 one. That's what transform_and_round_points is for. > Ok question then, how do I separate this into two patches? Never done anything with patches like this before so this is a first for me. Just make two commits in Git, and format-patch will create two patch files.

1 0

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)
by Stephan Rose 02 Jun '09

02 Jun '09

>Without doing any actual testing: > >The vertical alignment stuff looks right to me. > >Horizontal alignment is suspicious. If the world transform rotates the >text 90 degrees, DrawTextW can't be getting enough information to >center the text. Then again, I'm not sure if rotation works properly >with GdipDrawString in general. I'd write a test program for rotated >text. Naw, it should still work normally. I've done aligned & rotated text under windows before with DrawTextW, you still pass the rect like you would if it wasn't rotated and set the alignment flags. The world transform should take care of getting it all rotated to where it is supposed to be with the alignments in the right place. But I agree with you though, a test with rotated text is needed. If necessary though it isn't a big deal for me to change things to align without using DT_CENTER and DT_RIGHT. I'd want to test with the alignment flags first though as it keeps the code simpler if I can stick with those. > >I would probably send this as a series of 2 patches with vertical >alignment first. Ok question then, how do I separate this into two patches? Never done anything with patches like this before so this is a first for me. > >In spite Paul Vriens' comments, don't change the formatting of code >you're not changing. I guess the existing if's are already >inconsistent enough that you can get away with either style (and that >might actually be my fault). Without looking at it, I think it was only two if statements that weren't mine that I modified formatting on. Figured my changes to the function were major enough to where getting those two consistent with everything else wouldn't matter much. Up to you all if you want me to just leave those untouched or get their formatting in line with everything else. Either way's fine by me. =) Stephan

1 0

Re: gdiplus: add support for string alignment to GdipDrawString (try 2)
by Vincent Povirk 02 Jun '09

02 Jun '09

Without doing any actual testing: The vertical alignment stuff looks right to me. Horizontal alignment is suspicious. If the world transform rotates the text 90 degrees, DrawTextW can't be getting enough information to center the text. Then again, I'm not sure if rotation works properly with GdipDrawString in general. I'd write a test program for rotated text. I would probably send this as a series of 2 patches with vertical alignment first. In spite Paul Vriens' comments, don't change the formatting of code you're not changing. I guess the existing if's are already inconsistent enough that you can get away with either style (and that might actually be my fault). Vincent Povirk On Tue, Jun 2, 2009 at 7:12 AM, Stephan Rose<kermos(a)somrek.net> wrote: > - Adds support for aligning a string inside the given bounding rectangle > for GdipDrawString. Both vertical and horizontal alignments implemented. > > - Fixed code formatting issues (tabs / spaces, location of braces) to be > consistent with existing code. > > > > > >

1 0

Re: Website: Point the Development pages entirely to the Wiki.
by Jeremy Newman 02 Jun '09

02 Jun '09

I'm holding this patch hostage until the Wiki is updated with the new theme. -Newman Jeremy White wrote: > --- > templates/en/home.template | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/templates/en/home.template b/templates/en/home.template > index bad2f62..870a934 100644 > --- a/templates/en/home.template > +++ b/templates/en/home.template > @@ -24,8 +24,8 @@ > <div class="subtitle">Documentation, Support, and Wiki.</div> > </li> > > - <li class="devel" onClick="document.location='{$root}/devel/';"> > - <div class="title"><a href="{$root}/devel/">Development</a></div> > + <li class="devel" onClick="document.location='http://wiki.winehq.org/Developers';"> > + <div class="title"><a href="http://wiki.winehq.org/Developers">Development</a></div> > <div class="subtitle">Wine source, Bug Tracking, etc.</div> > </li> > > >

3 3

Re: Implications for Wine from the Ubuntu Developer Summit -- Pulseaudio
by Susan Cragin 02 Jun '09

02 Jun '09

>2009/6/2 Scott Ritchie <scott(a)open-vote.org>: >> First, I talked with a Pulseaudio expert about what we can do to make >> things work better. He said that if we want good compatibility we will >> need our ALSA stack to use the Pulseaudio safe subset: >> http://0pointer.de/blog/projects/guide-to-sound-apis.html. I've filed a >> metabug tracking this here: >> http://bugs.winehq.org/show_bug.cgi?id=18740. Use of this unsafe subset >> can cause most problems with stuttering or even complete dropoff. > >As far as I know, this is not possible for Wine (without massive >latency issues caused by overbuffering in Wine itself) due to the fact >that Wine has to make DirectSound apps happy. It's also not very >consoling from this Pulseaudio expert that they don't seem to see a >problem with the ALSA layer on their end - "it's the apps that need to >be fixed". Wasn't the point of Pulse that you could use libasound/OSS >apps without modification? :) > >> I'm not completely familiar with how sound works in Wine, but in the >> past I remember that one complaint about PulseAudio over ALSA was >> latency. Latency issues these days are mostly due to bad kernel >> configurations > >PulseAudio will *always* have more latency than ALSA. This has nothing >to do with kernel configurations, just that using a >CONFIG_NO_HZ/CONFIG_HZ_1000 (or whatever it is) kernel from the -rt >tree makes the latency issue less severe. New kernel won't fix Wine + >Pulse problem. Forgive me in advance for interjecting dross into a technical discussion. Would part of the problem be solved if users could be given the option of installing pulseaudio? That way, some users would be made instantly happy. There is a subset of users (albeit a tiny subset) that just needs one sound application running, but wants that application running with crystal-clear sound and near-zero latency. These are certain professional audio users, and those who run Dragon NaturallySpeaking through wine. Those people may be ill-served by having pulseaudio at all. Right now, in wine, removing pulseaudio completely doesn't seem to return alsa's functionality. Wine/alsa freezes, and I have to use OSS emulation, but OSS just does not produce as high-quality a sound. PS -- The rt kernel really is wonderful for speech recognition or any other use. The repository version has problems that are being worked on. In the meantime, just compile your own.

1 0

Implications for Wine from the Ubuntu Developer Summit
by Scott Ritchie 02 Jun '09

02 Jun '09

Hello everyone, I've just returned from the Ubuntu Developer Summit in Barcelona last week. A lot of interesting stuff that concerns Wine happened there, and a lot of applies to every distro. I'll give a brief summary in this email. Audio: First, I talked with a Pulseaudio expert about what we can do to make things work better. He said that if we want good compatibility we will need our ALSA stack to use the Pulseaudio safe subset: http://0pointer.de/blog/projects/guide-to-sound-apis.html. I've filed a metabug tracking this here: http://bugs.winehq.org/show_bug.cgi?id=18740. Use of this unsafe subset can cause most problems with stuttering or even complete dropoff. I'm not completely familiar with how sound works in Wine, but in the past I remember that one complaint about PulseAudio over ALSA was latency. Latency issues these days are mostly due to bad kernel configurations, which Lennart wrote about here: https://tango.0pointer.de/pipermail/pulseaudio-discuss/2009-February/003150…. In the meantime we should develop for the future using kernels with preempt enabled at 1000 HZ. Currently neither Open SuSE nor Ubuntu are configured this way, however I know in the case of Ubuntu that this is being fixed for next release. In particular, if you develop on Ubuntu, you should either upgrade to Karmic Alphas or install a custom kernel. The -rt flavor of the kernel is known to have problems as well. Printing: A printing expert from http://openprinting.org says we should output .pdf files to cups rather than postscript. .pdf are becoming the standard for printers, and apparently they allow some good things that postscript does not. I've filed a bug on this here: http://bugs.winehq.org/show_bug.cgi?id=18741 Security and Usability: The security team thinks we should finally start respecting the execute bit - this means removing all MIME handlers for executable code from the desktop and replacing them with a single front end for programs lacking the execute bit. This front end would notify the user of the problem, scan the file for viruses, and then present some information about the path towards execution. It is still undecided whether the program should allow execution outright, however from a UI perspective this would clearly be more efficient. This creates a design challenge. In brief, we have to simultaneously manage expectations about Wine, inform the user that there are other (preferred) methods for installing software, not patronize them for installing a Windows program, tell them we scanned a file for viruses but that it may still be unsafe, make it easy to use, and make it hard to use accidentally. After input from the community and discussion with other designers, I believe I have some good ideas for how to handle these challenges. The Canonical design team has agreed to integrate the UI extensions I've gathered into their weekly user testing, so over the next few months we should be getting some real feedback on the merits of various approaches to this problem. I'll be working more on this personally, and already have a good chunk of the specifications and front end code done (thanks to some great community help). I will, of course, share it here when it's in a usable state. As far as we, as an upstream, are concerned, there's not much to change in Wine itself other than to keep making it work better and fix bugs. If I had to name one in particular, I'd have to say the "unclean removal of applications menu" entries is a particularly confusing issue for users. What I'm doing: Over the next few months I'm going to be working rather hard on the Karmic Wine Integration spec that I lead at the Summit: https://wiki.ubuntu.com/karmic-wine-integration. I'm still drafting the spec based on my notes and discussion, but at this point I have a very good idea of what I want to do. Most of the code involved is directly relevant to the Wine user, however almost none of it needs to go into Wine itself other than some icons. At this point it's mostly python scripts, modifications of other python programs, and Glade dialogs. I may set up a BZR/Git repository of the various bits once they start turning into actual packages (which I'll also be doing). Anyway, keep your eyes peeled, the next wave of distro releases are going to be very slick. Thanks, Scott Ritchie

5 6

Re: shlwapi: add test for CombineUrl
by Alexandre Julliard 02 Jun '09

02 Jun '09

Aric Stewart <aric(a)codeweavers.com> writes: > Associated with bug 18063 which is fixed. Apparently not: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so url.c && touch url.ok url.c:781: Test failed: Got length 22, expected 21 url.c:786: Test failed: Got length 22, expected 21 url.c:790: Test failed: Got length 21, expected 20 url.c:792: Test failed: Expected http://wine:1234/dir, but got http://wine:1234/dir/ url.c:798: Test failed: Got length 22, expected 21 url.c:803: Test failed: Got length 22, expected 21 url.c:807: Test failed: Got length 21, expected 20 make[2]: *** [url.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] wininet: Check for bad allocation in HeapReAlloc
by Alexandre Julliard 02 Jun '09

02 Jun '09

Jason Green <jave27(a)gmail.com> writes: > @@ -4213,10 +4213,10 @@ static INT HTTP_GetResponseHeaders(LPWININETHTTPREQW lpwhr, BOOL clear) > > /* regenerate raw headers */ > while (cchRawHeaders + buflen + strlenW(szCrLf) > cchMaxRawHeaders) > - { > cchMaxRawHeaders *= 2; > - lpszRawHeaders = HeapReAlloc(GetProcessHeap(), 0, lpszRawHeaders, (cchMaxRawHeaders+1)*sizeof(WCHAR)); > - } > + lpszRawHeaders = HeapReAlloc(GetProcessHeap(), 0, lpszRawHeaders, (cchMaxRawHeaders+1)*sizeof(WCHAR)); > + if (lpszRawHeaders == NULL) > + goto lend; If you are going to check the allocation, then you should handle the error properly too instead of leaking memory. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] d3dx9: Test the return codes of the D3DXGetImageInfo functions
by Alexandre Julliard 02 Jun '09

02 Jun '09

Tony Wasserka <tony.wasserka(a)freenet.de> writes: > + /* D3DXGetImageInfoFromFile */ > + todo_wine { > + hr = D3DXGetImageInfoFromFileA("bmp1x1.bmp", &info); > + ok(hr == D3D_OK, "D3DXGetImageInfoFromFile returned %#x, expected %#x\n", hr, D3D_OK); > + } > + > + hr = D3DXGetImageInfoFromFileA("bmp1x1.bmp", NULL); > + ok(hr == D3D_OK, "D3DXGetImageInfoFromFile returned %#x, expected %#x\n", hr, D3D_OK); > + > + hr = D3DXGetImageInfoFromFileA("testdummy.bmp", NULL); /* existing file which is not a valid image, second parameter NULL */ > + ok(hr == D3D_OK, "D3DXGetImageInfoFromFile returned %#x, expected %#x\n", hr, D3D_OK); You can't depend on external files in tests, you have to create them yourself at run-time. -- Alexandre Julliard julliard(a)winehq.org

1 0

XI2 DirectInput mouse implementation RFC (Tarballed)
by Paul TBBle Hampson 02 Jun '09

02 Jun '09

(Resend, the first email never arrived. I didn't realise one of my patches was 33k >_<) I've thrown together a rather-rough-but-working-in-a-limited-sense implementation of XInput2-based DirectInput. It's got a fair few problems, I'm mainly interested in feedback on the approach, although obviously any code or style criticisms are welcome. Current limitations: * Doesn't check for XInput2.h, so it won't build without it. (Laziness) It will _run_ without XInput2, falling back to the current dinput WndProc hooks even if compiled with XInput2 support. * Doesn't send button-ups; XI2 can't distinguish button up from down * Doesn't send events after button-down until after button-up on a window. I'm pretty sure this is an XI2 bug, but it might be a design feature. * Doesn't support exclusive mode. XI2 bug (grabs not yet implemented) Hopefully this can be implemented entirely within the dinput code in winex11drv (ie disabling and hiding the mouse on acquire. dinput already takes care of unacquiring when we are no longer the foreground app) * Mouse buttons aren't remapped nicely downwards. Need to look harder at this, my mouse reports buttons 1, 2, 3, 4, 5, 8, 9, 10, 11 and 12 under X. 4 and 5 are scroll, 6 and 7 might be horizontal scroll in which case if this is always the case we can just remap downwards. Might need to implement device querying to confirm mouse button mapping... * Only supports the Mouse. Adding keyboard support should be really trivial compared to actually getting the framework right. * Doesn't detect capabilities... A mouse with a horizontal scroll wheel'd have four axes. I haven't looked to see if DirectInput can support that, or if our dinput code can easily accomodate more axes or buttons than the current 3/8 setup. This the point we'd need another callthrough from gdimouse to the graphics driver. * Assumes a process will only try and acquire the mouse once. I'm not sure that this is a bad assumption, and it might be that dinput makes this a valid assumption for us. * Assumes no one else wants GenericEvents. Some day we'll need a GenericEvent handler system inside WineX11, particularly if wintab gets converted to XInput 2 support. Easy enough to do now if wanted. * gdimouse uses Wine Mouse GUID value. I'm not sure where these come from, if anywhere. Trivial to fix before submission. If this format is fine, then the first patch is basically ready to go, the latter two patches may need to be re-split or merged more sensibly. In the libs folder I've also attached a couple of fixes for the XI2 stuff if anyone wants to try it. One only affects 64-bit builds, and one fixes XCB locking assertions which you could probably otherwise ignore. So they're both kinda optional in the Wine context. Also one more patch, against the xinput utility from whot's git tree, to fix a compile failure in the XI2 test functionality. -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com Shorter .sig for a more eco-friendly paperless office.

4 13

Re: gdi32: Stub for GdiEntry13()
by Kovács András 02 Jun '09

02 Jun '09

Hi, I think you should add @ stdcall DdQueryDisplaySettingsUniqueness() line to gdi32.spec file, otherwise you will get message like this: err:module:find_forwarded_export function not found for forward 'gdi32.DdQueryDisplaySettingsUniqueness' used by L"C:\\windows\\system32 \\gdi32.dll". If you are using builtin L"gdi32.dll", try using the native one instead. Best regards, Andras 2009. 06. 2, kedd keltezéssel 01.37-kor Nikolay Sivov ezt írta: > Requested in bug http://bugs.winehq.org/show_bug.cgi?id=18638 > > Changelog: > - Stub for GdiEntry13() > > >From 860bd34f2f0927c306a3f58825ffe46981b522bf Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Tue, 2 Jun 2009 01:27:30 +0400 > Subject: Stub for GdiEntry13 > > --- > dlls/gdi32/driver.c | 11 +++++++++++ > dlls/gdi32/gdi32.spec | 1 + > 2 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/dlls/gdi32/driver.c b/dlls/gdi32/driver.c > index 20d3f36..8a3c7ed 100644 > --- a/dlls/gdi32/driver.c > +++ b/dlls/gdi32/driver.c > @@ -741,3 +741,14 @@ INT WINAPI NamedEscape( HDC hdc, LPCWSTR pDriver, INT nEscape, INT cbInput, LPCS > lpszOutData); > return 0; > } > + > +/******************************************************************* > + * DdQueryDisplaySettingsUniqueness [GDI32.@] > + * GdiEntry13 [GDI32.@] > + */ > +ULONG WINAPI DdQueryDisplaySettingsUniqueness(VOID) > +{ > + FIXME("stub\n"); > + > + return 0; > +} > diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec > index 36a8fb1..a50f763 100644 > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -174,6 +174,7 @@ > # @ stub GdiDrawStream > # @ stub GdiEndDocEMF > # @ stub GdiEndPageEMF > +@ stdcall GdiEntry13() gdi32.DdQueryDisplaySettingsUniqueness > # @ stub GdiFixUpHandle > @ stdcall GdiFlush() > # @ stub GdiFullscreenControl

3 2

Fw: Need a temporary list moderator
by Luke Bratch 02 Jun '09

02 Jun '09

--- On Thu, 28/5/09, Luke Bratch <l_bratch(a)yahoo.co.uk> wrote: > In a couple of weeks I'm going to be travelling around > India for about a month, from 14th June - 17th July, so I'll > need somebody to cover list moderation during that period. > > It's a simple task; you just need to bring up a web page > for each list a couple of times per day, and single out any > genuine messages that are awaiting approval, discarding the > rest. > > You'll need to do it almost every day for the whole month, > otherwise people will start to wonder where their mail is > getting to.... :) > > If you are interested, please email me directly. No responses so far - anybody? Luke

5 4

Re: gdiplus: add support for string alignment to GdipDrawString
by Paul Vriens 02 Jun '09

02 Jun '09

Stephan Rose wrote: > Adds support for aligning a string inside the given bounding rectangle > for GdipDrawString. Both vertical and horizontal alignments implemented. > > > ------------------------------------------------------------------------ > > Hi Stephan, No remarks about the real contents of the patch (not my area of expertise). You are mixing tabs and spaces in this patch. This file uses 4 space indentation, please stick to that. The use of curly brackets is also not consistent. Looks like the rest of the file puts the opening curly bracket right after the closing round bracket (not even a space in between), like you do here: + if(format){ but a bit further you do: + if(format->vertalign != StringAlignmentNear) + { Usually when patches are created, one should try to adhere to the style of the file touched. -- Cheers, Paul.

1 0

Re: gdiplus: GdipDrawString
by Stephan Rose 02 Jun '09

02 Jun '09

>I don't know why gdiplus does its own linebreaks. I haven't really >done any work in that area. > >If I had to guess, I'd say it's because StringFormatFlagsNoWrap has no >equivalent flag for DrawText. That probably means you can't pass it >off to DrawText. > >Since they'll probably have to be done differently, it's best to >implement one direction at a time. When you're happy with horizontal >alignment, you can send a patch for that regardless of the status of >vertical alignment. > >You should be able to use GdipMeasureString to get the size of the >text. In fact, the alignments will need to be implemented there too, >and it may be better to start there. Hmm the only way I can see alignments having any influence on MeasureString would be if the boundingBox of the text is to be aligned to the layoutRect based on the alignment flags. Should just be able to then take the calculated bounding rect and align that to the layout based on the flags. And you're right, if I use MeasureString I solve my issue where I don't know the height of the text ahead of time. Perfect. Thanks, Stephan

2 2

[Fwd: Re: DIB engine]
by James McKenzie 02 Jun '09

02 Jun '09

To the list as well. -------- Original Message -------- Subject: Re: DIB engine Date: Mon, 01 Jun 2009 19:09:15 -0700 From: James McKenzie <jjmckenzie51(a)earthlink.net> To: Andrew Eikum <andrew(a)brightnightgames.com> References: <a71bd89a0905301414j5bd70f74y3441d367b49bc5f0(a)mail.gmail.com> <1243755935.4535.1.camel@stephan-desktop> <4A22AD55.5020306(a)brightnightgames.com> <b6bb06270905311154w2b9ccb12jee6d64ea587f9524(a)mail.gmail.com> <4A22D65A.3030205(a)brightnightgames.com> Andrew Eikum wrote: > Austin English wrote: >> On Sun, May 31, 2009 at 11:16 AM, Andrew >> <andrew(a)brightnightgames.com> wrote: >> >>> My name's Andrew Eikum, I'm an undergraduate Computer Science >>> student at the >>> University of Minnesota. I contacted a Wine dev a few weeks ago >>> asking for >>> a small project to use to get familiar with Wine. I was pointed >>> towards the >>> gdiplus section and told to begin stubbing out the missing >>> functions, to >>> facilitate debugging. After familiarizing myself with how Wine's >>> DLLs are >>> built, and with Git, I'm now making quick progress. I expect to have a >>> (huge) patchset ready in the next week or two with most of the gdiplus >>> functions stubbed. >>> >>> After that, I plan to begin work on implementing some of the >>> functions. My >>> degree's emphasis is computer graphics, so working on gdiplus will >>> give me a >>> chance to learn more about the field as well as apply what I already >>> know. >>> I'm looking forward to working with other Wine devs on gdiplus, and >>> other >>> parts of Wine in the future. >>> >> >> Welcome to Wine! >> >> Be sure when sending patches to break them into small sets, with one >> change per patch. It makes it much easier to review that way, and if >> your patch causes a regression, much easier to identify which part if >> it's in multiple patches. >> > Thanks for the welcome! > > I am definitely doing small commits and following the WineGit wiki > page. One concern I have is that the number of patches will probably > be over 50 or even 75 -- I'm not sure if it'd be better to submit them > all in one go as they're pretty much all alike (just stubbing), or > just do batches of 5-10 every couple days as I finish them (so it's > not a deluge of patches). Any suggestions? > > > I'll second what Austin said. Please send in like the following: [1/2] Test for some gdiplus Windows function with todo_wine wrapper that demonstrates default Windows function from a source other than reverse-engineering (this is an absolute no-no.) [2/2] Code that implements the default function along with code to remove todo_wine wrapper. This way if your second code breaks something, the test will be in place and the todo_wine wrapper will remain. James McKenzie

1 0

Re: gdiplus: Stub for GdipCloneBitmapArea
by Vincent Povirk 02 Jun '09

02 Jun '09

Don't bother adding "stub" to existing FIXME's. If it's a FIXME with arguments, we know it's a stub. Vincent Povirk On Mon, Jun 1, 2009 at 8:01 PM, Andrew Eikum<andrew(a)brightnightgames.com> wrote: > Stubbing GDI+: > Add stub function for GdipCloneBitmapArea. Also add missing > prototype for GdipCloneBitmapAreaI, and add stub note to > FIXME in GdipCloneBitmapAreaI stub function. > --- > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/image.c | 10 +++++++++- > include/gdiplusflat.h | 2 ++ > 3 files changed, 12 insertions(+), 2 deletions(-) > > > >

1 0

Re: [PATCH 5/5] wininet: Test gzip encoded read.
by Paul Vriens 01 Jun '09

01 Jun '09

Jacek Caban wrote: > --- > dlls/wininet/tests/http.c | 107 > ++++++++++++++++++++++++++++++++++---------- > 1 files changed, 82 insertions(+), 25 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, This patch introduces test failures on all platforms: 1 failure with IE7 1 new failure with IE8 (there was 1 with IE8 before this patch) 5 failures with IE6 Could you have a look (test.winehq.org)? -- Cheers, Paul.

2 1

Patchwatcher not reporting failures?
by Austin English 01 Jun '09

01 Jun '09

Testing patchwatcher with a patch that simply removes two todo_wine's should've caused some failures. Indeed, looking at the log: cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20 cred.c:315: Test failed: expected NULL credentials but got 0x11d4ec cred.c:328: Test failed: expected CredentialBlobSize of 0 but got 20 cred.c:328: Test failed: expected NULL credentials but got 0x11d4d0 it did. But patchwatcher shows an 'OK'. Can you take a look? -- -Austin

3 2

gdiplus: GdipDrawString
by Stephan Rose 01 Jun '09

01 Jun '09

Ok was playing a bit with DrawString on sunday trying to get string alignments to work. I've got horizontal alignments working by simply setting drawcoord.right which currently is left uninitialized and then passing DT_CENTER and DT_RIGHT as needed to DrawTextW. So far, that worked. However, I can't do that for vertical alignments because the code manually does the line breaking and therefore draws each line individually. So my question is, why? Why aren't we letting DrawTextW do the line breaking and just letting it draw with the appropriate rect? Is the linebreaking different? Or does DrawTextW not have the proper support for rotations? As it stands right now, if necessary, I can easily enough calculate the offsets myself for doing horizontal alignments instead of using DT_CENTER and DT_RIGHT. But for vertical, this is a bit problematic. I don't know how many lines of text there are going to be until the text has already been drawn. Kind of a prerequisite for vertical alignment however. That means that if I just want to brute force it, I'd have to duplicate the drawing loop and once only have it measure the string / count lines. That then allows me to calculate the proper offset and I could then just rerun the thing again with the new position and it'd work. A bit more better solution would be to store the line break info in a small array (indices into the string should do that tell me where each line ends) to simply the drawing loop. That would require a dynamic array though which brings me to another question, what should I use? is stuff like std::vector ok or should I use something else? If of course there's a way we can just have DrawTextW handle the line breaking, I don't even need to care about any of the above. Can then just calculate the proper bounding rect and hand all the issues off to DrawTextW. Thoughts? Thanks, Stephan

2 1

Regular users right on bugzilla
by Jerome Leclanche 01 Jun '09

01 Jun '09

Since there's been some discussion about bugzilla recently... Is there any reason regular users aren't allowed to change keywords, component and dependencies on bugs they don't own on Bugzilla? Maybe marking as duplicate as well. I don't think it'd do any harm to allow those rights to every registered user. Cheers Jerome -- J. Leclanche / Adys

6 7

Re: [2/3] kernel32: fix QueryFullProcessImageNameW for output buffer being null
by Alexandre Julliard 01 Jun '09

01 Jun '09

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -3155,6 +3155,12 @@ > NTSTATUS status; > DWORD needed; > > + if(!lpExeName) > + { > + SetLastError(ERROR_INVALID_PARAMETER); > + return FALSE; > + } > + This is not correct: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so process.c && touch process.ok process.c:1670: Test failed: Expected GetLastError() to be 122 (ERROR_INSUFFICIENT_BUFFER) is 87 make[2]: *** [process.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Its Alive! Patchwatcher is reborn.
by Zachary Goldberg 01 Jun '09

01 Jun '09

All, As you may have noticed in the last WWN I have been working on getting patchwatcher back up on a rather nice server whose cpu time is graciously donated by STWing (stwing.org). I've got it running at the moment at http://winepatch.stwing.upenn.edu/results2/ There are still many, many kinks to be worked out before I would use this as reliable and/or before I even think about enabling sending to patch authors. But if you're curious thats where the results are going and will likely be in the future. -Zach p.s. Kudos to Dan Kegel for a great walkthrough in the PW readme.txt, and of course for putting patchwatcher together in the first place!

4 4

Installing ActivePython screws up PATH in Wine?
by Dan Kegel 01 Jun '09

01 Jun '09

In Wine, I can happily install mingw and add it to the global PATH by editing the registry key PATH in [System\\CurrentControlSet\\Control\\Session Manager\\Environment] However, once I install ActivePython, something gets screwed up, and from then on, 'PATH' in CMD says PATH="C:\Python26\";;C:\Python26\; even if I remove that bit from that registry key and add other directories. Anyone know what the heck is going on?

2 1

Re: Changing default severity in Bugzilla to Normal
by James Mckenzie 01 Jun '09

01 Jun '09

Austin English wrote about Re: Changing default severity in Bugzilla to Normal > >On Thu, May 28, 2009 at 1:40 PM, Ken Sharp <kennybobs(a)o2.co.uk> wrote: >> "It seems the default severity, enhancement, invites people to select a >> REALLY >> SEVERE sounding level instead. I suggest changing the default severity to >> normal in the hopes of cutting down on the yelling." >> http://bugs.winehq.org/show_bug.cgi?id=13363 >> >> Any thoughts on this? >> >> >> > >+1 > +1 James McKenzie

3 2

"How Not To Develop On Windows"
by Dan Kegel 31 May '09

31 May '09

http://pdh11.blogspot.com/2009/05/how-not-to-develop-on-windows.html is a partial guide to developing Windows GUI apps on Linux using mingw and test them with Wine. Seems like an expanded version of this might belong on the Wine wiki...

1 0

Re: winecfg: Update WinXP version to SP3
by Austin English 31 May '09

31 May '09

On Sun, May 31, 2009 at 1:36 PM, Vitaliy Margolen <wine-patches(a)kievinfo.com> wrote: > --- > programs/winecfg/appdefaults.c | 2 +- > tools/wine.inf.in | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) You forgot to update ntdll/version.c -- -Austin

1 0

re: DIB engine
by Dan Kegel 31 May '09

31 May '09

Stephan Rose wrote: > My ears perked up when the two words DIB and spec were put > together in the same sentence. One frustration I encountered > when wanting to contribute to wine a little over two years ago > was that nobody seemed to be able to say "Hey, this is what > we are missing/need, here are the specs, go implement". >... > So if anyone can drop a full spec into my lap which outlines > everything I need to write and where (given I adhere to things > as I should of course) I won't have any issues getting that accepted later on... I don't think such manna is likely to fall from heaven any time soon. If it was that easy to spec, we would have been done by now. If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked. - Dan

6 8

re: Its Alive! Patchwatcher is reborn.
by Dan Kegel 31 May '09

31 May '09

Congratulations! It's nice to see it running again! Are you running it all on one node, or are you using the distributed mode? Have you been watching patchwatcher's mailbox for partial patch series? That was the biggest chore of running Patchwatcher. At one point they blocked the pipeline of incoming patches, not sure if I fixed that. Having patches back up is bad because they rapidly go stale. - Dan

2 1

WIne DIB
by chris ahrendt 31 May '09

31 May '09

On 05/30/2009 12:59 PM, wine-devel-request(a)winehq.org wrote: > Ben Klein ha scritto: > >> >> You would be surprised at how much of Wine is NOT a hack internally. >> Wine doesn't do hacks, > > Well, well.... there are some, indeed. > Of course, it's better not add new ones :-) > > hence AJ's reluctance to include the current >> DIB proposal in Wine (to make it "correct" later will require a lot of >> hacking, as Max has objected). > > Again, my engine isn't a hack. Nor you'll need hacks to embed it on > gdi32. > Even more, some parts will be simplified because of direct access to > internal > gdi32 structures, which can't be done (without hacks....) in current > implementation. > The *only* semi-hack is the direct access of gdifont struct from > inside winedib.... > it could also be avoided, but with much useless code added. > Useless because it will be so once embedded in gdi32. >> >>> Do we even have an architectural document or guidelines to reference? >> >> This was also raised on the existing thread. No. This is a problem. >> The best we have so far is "DIB engine should be integrated into >> GDI32". This is not a problem, because both Max and AJ share this >> goal, but if I understand correctly, Max doesn't want to invest the >> effort (which is a lot) until the current design is validated by >> inclusion into upstream source. > > You got exactly the point :-) > To be precise, the effort isn't so huge, but summed with the effort of > maintaining > all in sync with current tree the global effort would be great (and > dumb, imho). >> >> >> Welcome aboard! I suggest that if you'd like to help out with the DIB >> engine (with the goal of getting it included to Wine upstream source), >> that you take a look at the code on bugzilla page #421 and talk to >> Massimo about how you might adapt it for integration into GDI32. >> > There's not too much to adapt.... moving the engine inside gdi32 is > (IMHO) > not complicated at all. More a writing effort than a coding one. > But, *before*, I guess winex11.drv (and any possible driver that does > DIBs internally) > should be patched stripping DIB handling *and* adding some stuffs for > mixed transfers. > Again, not an huge work, for somebody that knows well drivers internals. > It could also be done later, if wished... but logically that would be > the first step. > > Ciao > > Max > > Ok Max then document what you think the effort would be and what is needed to migrate your DIB engine into GDI32 Then We could send it to AJ for approval and go from there. This would be documenting the Delta which should allow AJ to go line item by line item and say yes or no to each or what needs to do. How long would that take you to do Max? Once that is done we would have a defined plan etc and going forward it would be documented. Chris

3 2

Announcing WineConf 2009
by Hans Leidekker 30 May '09

30 May '09

Dear Wine developers, You may recall that I volunteered to help host WineConf in the Netherlands in 2007 when, after a vote, an offer by Dan Kegel to host at Google's offices in Zurich won the bid. Last year WineConf went across the pond to Minnesota, so it seems natural that this year's WineConf will be hosted in the country with the highest number of Wine developers per capita ;-) At Twente University Campus to be precise, near the city of Enschede: http://maps.google.com/maps/ms?ie=UTF8&hl=en&msa=0&msid=1047705954276368339… From November 6-8 (Friday to Sunday). I chose this place because of its good facilities and relatively low costs; we want to make the conference accessible for as many developers as possible. Directions, agenda, etc. will be made available on this page: http://wiki.winehq.org/WineConf Please e-mail me at wineconf(a)meelstraat.net if you intend to come, so we can make a better estimation of the number of attendees. See you there! -Hans

5 7

Re: d3d10: Improve parse_fx10.
by Dmitry Timoshkov 30 May '09

30 May '09

"Rico Schüller" <kgbricola(a)web.de> wrote: > - /* version info? */ > - skip_dword_unknown(&ptr, 2); > + /* Compiled target version (e.g. fx_4_0=0xfeff1001, fx_4_1=0xfeff1011). */ > + read_dword(&ptr, &e->version); > + TRACE("Target: %#x\n", e->version); 0xfeff/0xfffe is a unicode byte order mark, could it serve the same purpose here? -- Dmitry.

3 2

DIB engine
by chris ahrendt 30 May '09

30 May '09

Question on this debate: Has AJ documented anywhere what the architectural issues are so they can be addressed? I have not seen this in the thread and was just wondering. If we have them documented then its a relatively easy task to address each of them. Yes it may be a hack but you would be surprised at how much of Windows is a hack internally. Do we even have an architectural document or guidelines to reference? Chris

4 3

Re: DIB engine
by Stephan Rose 30 May '09

30 May '09

>>As was said in the other thread, just designing it alone would take a >>few months work. AJ is really busy with other things, and a few months >>work is both a lot of money and a lot of wasted productivity. No one >>is stepping up to sponsor the work, so it's a bit hard for him to take >>that on. > >Who is asking AJ to do all of the work. Huw Davies and Max have worked out >what is needed to get this into Wine. All we need is guidance on what is >acceptable and how we should proceed. This seems to be a serious shortcoming >on AJs part. Without this, any further work would be futile and could end up >being very frustrating. I've seen this from Huw and it is starting to come >from Max. AJ needs to get some time together and write up what is and is not >acceptable as far as code style, fashion and what he expects out of the >development efforts for the DIB engine. Making a statement >after months of work is IHMO very unacceptable. > >Also, I don't see this as circular, but the 'snake' of getting AJ to accept >code into the codebase is. This is where I figured I'd wake up and chime in a bit. None of you all know me I suppose but I've been primarily just listening in on this list for the better part of two years now. :) My ears perked up when the two words DIB and spec were put together in the same sentence. One frustration I encountered when wanting to contribute to wine a little over two years ago was that nobody seemed to be able to say "Hey, this is what we are missing/need, here are the specs, go implement". Essentially, that's how I work and how I work well. Trying to fix random bugs in random applications in a codebase completely unfamiliar to me seemed to be rather futile so at that point in time I abandoned those efforts and just stuck to using wine. =P So that said, I've got a decent amount of experiences dealing with graphics, including full 24/32-bit color on embedded devices. Considering the environment, performance has always been a priority as well. Plus, I also really like working with graphics related code. So from where I'm standing right now, this seems to be right in my neighbourhood. So if anyone can drop a full spec into my lap which outlines everything I need to write and where (given I adhere to things as I should of course) I won't have any issues getting that accepted later on, I'd be more than willing to take on something like this. Thanks, Stephan

2 1

Re: Time to remove obsolete platforms HP, SGI, and DEC?
by James Mckenzie 30 May '09

30 May '09

> >> Why do we have versions on Mac OS X? How about we combine them all? > >It can make a big difference in the bug. The X.org version in OS X >(partially?) depends on what OS X version you have. Some bugs will >only show up in Tiger, because Leopard has them fixed on Apple's end. >(Someone correct me if I'm wrong here, this is based off of what I've >seen on wine-users). > Very much correct. MacOSX 10.5.7 with XQuartz 2.3.3 or higher correctly utilize all OpenGL features present in Wine. MacOSX 10.4.x or MacOSX 10.5.6 or MacOSX 10.5.7 without XQuartz 2.3.3 applied will not. Since I am running MacOSX 10.5.7 with XQuartz 2.3.3.2 applied, I do not know the status of backporting the fixes to the 10.4 (Tiger) baseline or even if it is possible. As far as OS/2 goes, it is still a viable operating system, but I think, for Wine purposes, it should be dropped as an available OS for bugzilla and for the AppDB. James McKenzie

2 1

Re: DIB engine
by chris ahrendt 29 May '09

29 May '09

On 05/29/2009 12:28 PM, James Mckenzie wrote: >> As was said in the other thread, just designing it alone would take a >> few months work. AJ is really busy with other things, and a few months >> work is both a lot of money and a lot of wasted productivity. No one >> is stepping up to sponsor the work, so it's a bit hard for him to take >> that on. >> > Who is asking AJ to do all of the work. Huw Davies and Max have worked out what is needed to get this into Wine. All we need is guidance on what is acceptable and how we should proceed. This seems to be a serious shortcoming on AJs part. Without this, any further work would be futile and could end up being very frustrating. I've seen this from Huw and it is starting to come from Max. AJ needs to get some time together and write up what is and is not acceptable as far as code style, fashion and what he expects out of the development efforts for the DIB engine. Making a statement > after months of work is IHMO very unacceptable. > > Also, I don't see this as circular, but the 'snake' of getting AJ to accept code into the codebase is. > > Very respectfully submitted, > > James McKenzie > > > > Agreed James, this is the exact point I am getting at I guess... what exactly is acceptable and what is not... It seems we have a working solution for DIB. I do not think that it would take that long for AJ to sit down and say here.. this is what I want or this is what is acceptable then its up to the development people to come back and say ok here is our solution and then rectify the delta's in between. If Huw and Max have a solution then what is the delta? Chris

1 0

Time to remove obsolete platforms HP, SGI, and DEC?
by Dan Kegel 29 May '09

29 May '09

The only use of these platforms was three mistaken bug reports that probably wanted PC. I don't see any reason to keep these old system types around any more. OK to remove? (Suggested in http://bugs.winehq.org/show_bug.cgi?id=13363 )

5 9

Re: DIB engine
by James Mckenzie 29 May '09

29 May '09

Luke: > >Heh, I wonder if someone should approach Autodesk and say, "Give us >sponsorship and we'll get Autocad running on Linux" they surely have >deep pockets :) > If Autodesk were interested in making AutoCad work with Linux, they would make a native version, not try to get it working with Wine. Sorry, but them's the facts. Now, if you were to speak up with your wallet and donate to the effort, that is a vastly different story. Sadly, we are on our own to get AutoCad fully working with Wine. I don't expect any assistance from AutoDesk nor any of the major Linux players. James McKenzie

2 1

Re: DIB engine
by James Mckenzie 29 May '09

29 May '09

>As was said in the other thread, just designing it alone would take a >few months work. AJ is really busy with other things, and a few months >work is both a lot of money and a lot of wasted productivity. No one >is stepping up to sponsor the work, so it's a bit hard for him to take >that on. Who is asking AJ to do all of the work. Huw Davies and Max have worked out what is needed to get this into Wine. All we need is guidance on what is acceptable and how we should proceed. This seems to be a serious shortcoming on AJs part. Without this, any further work would be futile and could end up being very frustrating. I've seen this from Huw and it is starting to come from Max. AJ needs to get some time together and write up what is and is not acceptable as far as code style, fashion and what he expects out of the development efforts for the DIB engine. Making a statement after months of work is IHMO very unacceptable. Also, I don't see this as circular, but the 'snake' of getting AJ to accept code into the codebase is. Very respectfully submitted, James McKenzie

1 0

Re: DIB engine
by chris ahrendt 29 May '09

29 May '09

On 05/29/2009 11:14 AM, Austin English wrote: > On Fri, May 29, 2009 at 10:10 AM, chris ahrendt<celticht32(a)yahoo.com> wrote: > >> Question on this debate: >> >> Has AJ documented anywhere what the architectural issues are so they can >> be addressed? >> I have not seen this in the thread and was just wondering. >> If we have them documented then its a relatively easy task to address >> each of them. >> Yes it may be a hack but you would be surprised at how much of Windows >> is a hack internally. >> >> Do we even have an architectural document or guidelines to reference? >> > If you read the entire thread, you'll see that the DIB design is not a > puzzle that can be carved out and dropped in. The DIB engine must be > designed from scratch. Designing the DIB architecture is half of the > work itself, since that involves planning a lot of the code/testing, > etc. > > He pointed out a few things he didn't like about Massimo's design, but > not a full 'here's the spec, do this exactly'. > > For more details, read the full thread and past discussions. > > -- > -Austin > > > Right Austin, I have... thats why I asked the question why not sit down and say here is what we want from the DIB engine here is the Spec do this .. I have seen the here is what I don't like. But nothing showing what exactly is needed. This would be the first step in resolving this circular argument / discussion which is what I am trying to facilitate =D. Until that is done all we can do is have this same circular argument / discussion =D chris

3 2

Re: PowerPC MacOSX work...
by mghughes＠embarqmail.com 29 May '09

29 May '09

No No No People... Please read the messages before replying. I know the difference betweeen my 6502, 6800, Z80, 68k, x86, 7400. I know Wine is focused on running MSWindows based software on x86 processors. I also know there exists PowerPC code in the wine project because people were interested in bridging the gap to running x86 code via emulation... For the record... I am not looking to run another full out emulation. The best example of what I have in mind is what Apple did when they moved their processor base from 68K to PPC. And I am wondering if the same could be done for Wine. By the looks of things some of the framework to make that happen are already there in the form of thunk code... Apple used what they called trampolines iirc. I am not sure that WineLib is what I am looking to use as the wine script & loader seems to achieve much of what I am already looking to do. My understanding is that Wine has run on PowerPC at some time via native and Qemu/Qemu-user. Since the Darwine (PowerPC work) project went dormant, I have not been able to find much of the information I am looking for... What was the last known Wine/Darwine version known to work on PowerPC? I some had thoughts of getting that version and progressing forward to see what and where things break. Am I mistaken that the connection between wine/server appears to be broken? My previous statements in my first message still apply. Michael

5 5

Re: patch wined3d
by James McKenzie 29 May '09

29 May '09

Pavel Prochazka wrote: >static HRESULT WINAPI IWineGDISwapChainImpl_Present(IWineD3DSwapChain *iface, CONST RECT *pSourceRect, CONST RECT *pDestRect, HWND hDestWindowOverride, CONST >RGNDATA *pDirtyRegion, DWORD dwFlags) { > IWineD3DSwapChainImpl *This = (IWineD3DSwapChainImpl *) iface; >- IWineD3DSurfaceImpl *front, *back; >+ IWineD3DSurfaceImpl *front, *back,*hlp1,*hlp2;; You need to keep the same spacing as the remainder of the line. - { - HDC tmp; - tmp = front->hDC; + { Get rid of the trailing whitespace, it is not needed nor necessary. - - tmp = front->resource.allocatedMemory; + Same here. You should go through your additions and make sure that no trailing whitespace exists on any line. Also, you should combine all of your fixes into one patch until it is accepted. Lastly, a description should describe what your patch does: [wine3d] Create swapchains to eliminate problems with backbuffers (bug XXX {there are at least five bugs with backbuffer problems}) Also, provide test cases to prove that your patch actually does something that Windows(TM) does and to show that you did your homework. Again, as one of the people with the backbuffer problem causing FPS slowness, I am very interested in these patches. However, they need to be cleaned up so that we can use them. James McKenzie

1 0

Re: [PATCH] _Present
by Stefan Dösinger 29 May '09

29 May '09

Am Donnerstag, 28. Mai 2009 13:01:23 schrieb Pavel Prochazka: Don't send patches on top of unapplied patches - just always send the a patch against the current wine git code. Besides that, Henri and I pointed out a few other problems in the first version of the patch. Things won't get better if you just resend the same code without addressing the issues that were pointed out.

1 0

DIB Engine : passing all tests
by Massimo Del Fedele 28 May '09

28 May '09

I posted on bug 421 page (as usual) latest update of my engine. It suld pass all tests in wine suite.... also all bitmap's todo_wines, so expect some "false positive" signaled by tests. Austin, could you please re-run it on your test machines ? Ciao Max

21 48

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.
by Nikolay Sivov 28 May '09

28 May '09

Sergey Khodych wrote: > From a2bf101f7ede3937373b7b8f9e2a8ea032b7790d Mon Sep 17 00:00:00 2001 > From: Sergey Khodych <khodych(a)gmail.com> > Date: Mon, 25 May 2009 02:21:39 +0300 > Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. > > --- > dlls/comctl32/rebar.c | 12 ++++++++---- > dlls/comctl32/tests/rebar.c | 2 +- > 2 files changed, 9 insertions(+), 5 deletions(-) Where did you test that it isn't stored?

2 6

Need a temporary list moderator
by Luke Bratch 28 May '09

28 May '09

Hi all In a couple of weeks I'm going to be travelling around India for about a month, from 14th June - 17th July, so I'll need somebody to cover list moderation during that period. It's a simple task; you just need to bring up a web page for each list a couple of times per day, and single out any genuine messages that are awaiting approval, discarding the rest. You'll need to do it almost every day for the whole month, otherwise people will start to wonder where their mail is getting to... :) If you are interested, please email me directly. Thanks, Luke.

1 0

Re: [1/2] comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. (try 2)
by Nikolay Sivov 28 May '09

28 May '09

Sergey Khodych wrote: > From 37cd774e71f8d260d94bd672715b1eab879c4b2d Mon Sep 17 00:00:00 2001 > From: Sergey Khodych <khodych(a)gmail.com> > Date: Thu, 28 May 2009 04:52:45 +0300 > Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. > > --- > dlls/comctl32/rebar.c | 12 ++++++++---- > dlls/comctl32/tests/rebar.c | 9 +++++++++ > 2 files changed, 17 insertions(+), 4 deletions(-) Commented already. You're testing one part and changing another. Add simple get/set text tests first.

1 0

Changing default severity in Bugzilla to Normal
by Ken Sharp 28 May '09

28 May '09

"It seems the default severity, enhancement, invites people to select a REALLY SEVERE sounding level instead. I suggest changing the default severity to normal in the hopes of cutting down on the yelling." http://bugs.winehq.org/show_bug.cgi?id=13363 Any thoughts on this?

2 1

Re: [PATCH] _Present
by Francois Gouget 28 May '09

28 May '09

On Thu, 28 May 2009, Pavel Prochazka wrote: > > + IWineD3DSurfaceImpl *front,*hlp1,*hlp2; > + IWineD3DSurfaceImpl back; //must be copy of struct C++ comments are not allowed in Wine. There are a few others further down. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

1 0

How to fix some oleaut32:vartest tests?
by Paul Vriens 28 May '09

28 May '09

Hi, It looks like I have two boxes (W98 and NT4) that produce test failures every now and then for the mentioned tests: vartest.c:5514: Test failed: VarCat: VT_BSTR concat with VT_DATE returned inncorrect result vartest.c:5530: Test failed: VarCat: VT_DATE concat with VT_BSTR returned inncorrect result It boils down to the result of the VarCat which is either a 2-digit or a 4-digit year but again intermittently. If I run the same test right after each other I get either 0, 1 or 2 failures. The only way I can see fixing this is by having a broken() with the 2 digit date for sz12_date and date_sz12. I mean having an explicit broken() is better then a broken() for anything but the correct result. Anyone? (I'll start with sending a patch for that spelling mistake in the output ;) ). -- Cheers, Paul.

1 0

winehq.org page importance / website statistics
by Maik Schulz 28 May '09

28 May '09

Hi, for translation (to German) purposes I wonder which pages of the winehq.org website are most frequented (are there HTTP request statistics?) and which are deemed most important so I can focus on them in order. It would also be interesting to know which pages are going to be moved to the Wiki eventually so I don't waste effort translating these. Everything that is shown on the start page plus some other pages are done and I'm looking for direction on where to continue. Cheers, -Maik

4 6

valgrind mac now on trunk!
by Dan Kegel 28 May '09

28 May '09

http://blog.mozilla.com/nnethercote/2009/05/28/mac-os-x-now-supported-on-th… So for those of you developing wine on the mac, now you have one fewer excuse not to run your changes through valgrind before sending patches :-)

1 0

Re: winebrowser: Fix unicode recognition
by Dmitry Timoshkov 28 May '09

28 May '09

"André Hentschel" <nerv(a)dawncrow.de> wrote: > This converts the DDE-Callbackfunction to Unicode. > After days of winebrowser-hacking i turned it down to this clean code. > It uses the function IsTextUnicode instead of guessing.(IsTextUnicode is guessing too, but in a cleaner way) Please add a test case which uses mixed ansi/unicode DDE client/server and only then start fixing the code. -- Dmitry.

3 4

Does wine handle virtual midi ports correct on OSX?
by Dewdman42 28 May '09

28 May '09

Does anyone know if Darwine can be fixed to handle virtual midi ports correctly? They work very sporadically right now. It seems to be related to getting the ports flushed or initialized or something. When there is a virtual midi port present (under OSX), Wine seems to see it and lists it as an available midi port, but I have not been able to consistently get that port to function correctly. Sometimes it does and sometimes it doesn't and it seems to related to switching it on and off in some fashion makes it work, though I can't seem to find a pattern that will work consistently. All I can figure is that somehow Wine is not handling midi ports in a way that is compatible with OSX virtual midi ports. Anyone have any experience or knowledge in this area? Thanks -- View this message in context: http://www.nabble.com/Does-wine-handle-virtual-midi-ports-correct-on-OSX--t… Sent from the Wine - Devel mailing list archive at Nabble.com.

6 11

PowerPC MacOSX work...
by Michael G Hughes 28 May '09

28 May '09

I have managed to get Wine compiling on a PowerMac G4, MacOSX 10.3.9, a while back... What I know so far... It does not work... Who'd a thunk it? Just trying to run winecfg gives me: fixme:seh:RTLCaptureContext not implimented on PowerPC fixme:seh:call_stack_handlers not implemented on PowerPC wine: Unhandled alignment at address 0x44010788 (thread 000d), starting debugger... err:process:__wine_kernel_init boot event wait timed out So... Some of my questions to from the people involved with chugging away at the PowerPC parts of the code... What are the known issues faced in getting the project to work on PowerPC? What critical pieces are known to be missing? What is the problem(s) with X11 on 10.3.9? How do I start testing parts of Wine on PowerPC? RTLCaptureContext... I started to impliment RTLCaptureContext... Looks like this involves adding code to winebuild in addition to RTLCaptureContext itself... Correct? Can RTLCaptureContext be implimented without mucking with the winebuild tool? Michael -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

8 9

AppDB - Incorrect entry
by Danila Sentiabov 27 May '09

27 May '09

Hi. I've found incorrect AppDB entry that needs to be merged with another one. App maintainer could not do that. Could someone (with admin access to AppDB) help? http://appdb.winehq.org/objectManager.php?sClass=version&iId=7641 -- Best regards, Danila Sentiabov aka dsent

2 1

Re: wined3d: {Name of patch here}
by James Mckenzie 27 May '09

27 May '09

Pavel: Just as a hint, can you name your patches to be more descriptive. I am looking for a fix to this problem, and will attempt to test this against DooM to see if the slowness problem I have is fixed. Thank you for contributing to the Wine Project. James McKenzie -----Original Message----- >From: Pavel Prochazka <prochapa(a)inf.upol.cz> >Sent: May 27, 2009 5:40 AM >To: wine-patches(a)winehq.org >Subject: wined3d: > >

1 0

Re: wined3d:
by Stefan Dösinger 27 May '09

27 May '09

Am Mittwoch, 27. Mai 2009 14:40:20 schrieb Pavel Prochazka: > IWineGDISwapChainImpl_Present repaired when there is only one backbuffer Hmm. Situations where flip is called on a single-buffered surface should be cought in ddraw I think. If I remember correctly, calling flip on a single buffered surface should return an error

1 0

Re: comctl32/ipaddress: Skip test on Win95 with common controls 4.70 (try2)
by Paul Vriens 27 May '09

27 May '09

Nikolay Sivov wrote: > For version 4.0 we are skipping earlier on initialization. > > Changelog: > - try2: use win_skip() > - Skip test on Win95 with common controls 4.70 > >>From 81645944ef518860de7ddcd1b64fadd11277a915 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 27 May 2009 15:39:20 +0400 > Subject: Skip test on Win95 with common controls 4.70 > > --- > dlls/comctl32/tests/ipaddress.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/dlls/comctl32/tests/ipaddress.c b/dlls/comctl32/tests/ipaddress.c > index d04223c..13af687 100644 > --- a/dlls/comctl32/tests/ipaddress.c > +++ b/dlls/comctl32/tests/ipaddress.c > @@ -33,8 +33,6 @@ static HWND create_ipaddress_control (void) > handle = CreateWindowEx(0, WC_IPADDRESS, NULL, > WS_BORDER|WS_VISIBLE, 0, 0, 0, 0, > NULL, NULL, NULL, NULL); > - assert(handle); > - > return handle; > } > > @@ -45,6 +43,12 @@ static void test_get_set_text(void) > INT r; > > hwnd = create_ipaddress_control(); > + ok(hwnd != NULL, "Expected window to be created\n"); > + if (!hwnd) > + { > + win_skip("IPAddress control not implemented\n"); > + return; > + } > > /* check text just after creation */ > r = GetWindowText(hwnd, ip, sizeof(ip)/sizeof(CHAR)); I would either get rid of the ok(hwnd ...) altogether or move it after the if(). win_skip() means we are ok with a failure on some Windows boxes so a test failure just before that doesn't make sense. -- Cheers, Paul.

2 1

Re: comctl32/ipaddress: Use ok() test instead of assert()
by Paul Vriens 27 May '09

27 May '09

Nikolay Sivov wrote: > This test fails to create window sometimes on Win95, > let's turn it into general failure. > > Changelog: > - replace assert() with ok() test > >>From b63fc6defb497505ecaab4921449327e875ab252 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 27 May 2009 14:26:37 +0400 > Subject: Use ok() test instead of assert() > > --- > dlls/comctl32/tests/ipaddress.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/dlls/comctl32/tests/ipaddress.c b/dlls/comctl32/tests/ipaddress.c > index d04223c..b8f30e4 100644 > --- a/dlls/comctl32/tests/ipaddress.c > +++ b/dlls/comctl32/tests/ipaddress.c > @@ -33,8 +33,6 @@ static HWND create_ipaddress_control (void) > handle = CreateWindowEx(0, WC_IPADDRESS, NULL, > WS_BORDER|WS_VISIBLE, 0, 0, 0, 0, > NULL, NULL, NULL, NULL); > - assert(handle); > - > return handle; > } > > @@ -45,6 +43,7 @@ static void test_get_set_text(void) > INT r; > > hwnd = create_ipaddress_control(); > + ok(hwnd != NULL, "Expected window to be created\n"); > Shouldn't you insert a return here when hwnd is NULL. The following tests will fail as well I guess. -- Cheers, Paul.

2 5

Re: [mshtml/tests] Fix 2 test failures on IE8
by Jacek Caban 27 May '09

27 May '09

Hi Paul, Paul Vriens wrote: > Changelog > Fix 2 test failures on IE8 > - ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp); + ok(disp == (void*)0xdeadbeef || + disp == NULL, /* IE8 */ This test does no longer make sense. It would be better to remove it and preferably change implementation to match IE8. Thanks, Jacek

2 2

Re: d3d9/tests: add simple test to show that QualityLevels is not zero, when we call CheckDeviceMultiSampleType with D3DMULTISAMPLE_NONE
by Jeff Zaroyko 26 May '09

26 May '09

On Wed, May 27, 2009 at 7:47 AM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > This test shows second bug in > http://www.winehq.org/pipermail/wine-bugs/2009-May/177221.html > > I tested this on my laptop (under windows) with an ATI-card, my desktop > computer (that has nvidia) only runs Linux, so i could not test it on nvidia > under windows, if anyone could do that that would be nice. > No failures on Vista, nv9800, 180.81.

1 0

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Hib Eris 26 May '09

26 May '09

On Tue, May 26, 2009 at 8:57 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Hib Eris <hib(a)hiberis.nl> writes: > >> I have looked at my new code and it does not seem wrong to me, but >> maybe it is somewhere else. Unfortunately, as I cannot reproduce this >> failure, I have no idea how to debug it. Does this fail for other >> people as well? >> >> Just a wild guess... could it have something to do with 64-bit vs. >> 32-bit? I am running on 32-bit. Alexandre, did you run the test on 32 >> or 64 bit? > > 32-bit of course, nothing works on 64-bit <g> > > It's heap corruption, you forgot to allocate space for the terminating > null in msi_import_stream_filename. And you should probably use strdupW > instead. Ahhh, I see! I will create a new patch. Thanks. A question about using strdupW: In my patch I use msi_alloc and msi_realloc to allocate memory for the returned string and use msi_free to free it again. If I would use stdupW to create a string copy instead of msi_alloc, would it then still be okay to use msi_realloc and msi_free? According to http://source.winehq.org/WineAPI/StrDupW.html I should use LocalFree to free the memory? I've seem some more places where msi_free and StdDupW were mixed, so I guess it will work. But is it considered good practice? Hib

2 1

[PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Hib Eris 26 May '09

26 May '09

Hi all, hmm, I've tested it again with current git, and it still works fine here. I have looked at my new code and it does not seem wrong to me, but maybe it is somewhere else. Unfortunately, as I cannot reproduce this failure, I have no idea how to debug it. Does this fail for other people as well? Just a wild guess... could it have something to do with 64-bit vs. 32-bit? I am running on 32-bit. Alexandre, did you run the test on 32 or 64 bit? So, I can only ask for someone to please also try http://www.winehq.org/pipermail/wine-patches/2009-May/073272.html and see if it works for him/her. Hib On Tue, May 26, 2009 at 3:30 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Hib Eris <hib(a)hiberis.nl> writes: > >> --- >> dlls/msi/database.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++--- >> dlls/msi/msipriv.h | 3 +- >> dlls/msi/record.c | 2 +- >> dlls/msi/tests/db.c | 12 +++++----- >> 4 files changed, 68 insertions(+), 12 deletions(-) > > This doesn't work here: > > ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok > wine: Unhandled page fault on write access to 0x00000004 at address 0x7bc4460e (thread 0019), starting debugger... > Unhandled exception: page fault on write access to 0x00000004 in 32-bit code (0x7bc4460e). > Register dump: > CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b > EIP:7bc4460e ESP:0032f770 EBP:0032f7e8 EFLAGS:00010202( R- -- I - - - ) > EAX:00000000 EBX:7bc94448 ECX:00110014 EDX:00000000 > ESI:0012dcc8 EDI:0012dc48 > Stack dump: > 0x0032f770: 0032f784 00110014 00000020 0012dd00 > 0x0032f780: 0032f794 4d430002 0032f7bc 0012dc58 > 0x0032f790: 0032f7a4 00110014 00000070 4d430003 > 0x0032f7a0: 00000000 4d430003 00000000 00000000 > 0x0032f7b0: 00000000 00000000 00000000 4d430000 > 0x0032f7c0: 0012dc58 00000070 00000000 00000000 > Backtrace: > =>0 0x7bc4460e HEAP_CreateFreeBlock+0x3be(subheap=0x110014, ptr=0x12dc48, size=128) [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll (0x0032f7e8) > 1 0x7bc44847 HEAP_MakeInUseBlockFree+0x57(subheap=0x110014, pArena=<is not available>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:586] in ntdll (0x0032f838) > 2 0x7bc44b3c RtlFreeHeap+0x18c(heap=0x110000, flags=2, ptr=0x12dcc8) [/home/julliard/wine/wine/dlls/ntdll/heap.c:1480] in ntdll (0x0032f898) > 3 0x6081aa8e free_table+0x3e(table=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/msipriv.h:1059] in msi (0x0032f8b8) > 4 0x6081abae free_cached_tables+0x2e(db=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/../../include/wine/list.h:133] in msi (0x0032f8c8) > 5 0x607d3ec2 MSI_CloseDatabase+0x42(arg=0x12b7e8) [/home/julliard/wine/wine/dlls/msi/database.c:66] in msi (0x0032f8e8) > 6 0x607e6b58 msiobj_release+0x48(info=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/handle.c:257] in msi (0x0032f918) > 7 0x607e6ccf MsiCloseHandle+0xbf(handle=<is not available>) [/home/julliard/wine/wine/dlls/msi/handle.c:311] in msi (0x0032f948) > 8 0x6066abda test_binary_import+0x33a() [/home/julliard/wine/wine/dlls/msi/tests/db.c:1991] in msi_test (0x0032fca8) > 9 0x60677d7e func_db+0x264e() [/home/julliard/wine/wine/dlls/msi/tests/db.c:7672] in msi_test (0x0032fde8) > 10 0x60749a80 run_test+0x130(name="db.c") [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:456] in msi_test (0x0032fe28) > 11 0x60749c6f main+0x11f(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:505] in msi_test (0x0032fed8) > 12 0x6074a484 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032ff08) > 13 0x7b878660 start_process+0x130(arg=(nil)) [/home/julliard/wine/wine/dlls/kernel32/process.c:941] in kernel32 (0x0032ffe8) > 14 0x6002bc07 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) > 0x7bc4460e HEAP_CreateFreeBlock+0x3be [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll: movl %eax,0x4(%edx) > 98 elem->next->prev = elem->prev; > > > -- > Alexandre Julliard > julliard(a)winehq.org >

2 2

Re: patch wined3d
by Stefan Dösinger 26 May '09

26 May '09

Am Dienstag, 26. Mai 2009 18:13:49 schrieb Pavel Prochazka: Is there any reason why we'd want 32 backbuffer swapchains? The currentl limit comes from d3d9(no more than 3 backbuffers allowed). We can certainly change it, but I doubt that any Windows driver supports that in ddraw. If there is no limit in ddraw(provide a test), we should remove the limit and make it dynamic.

1 0

Re: patch wined3d
by Henri Verbeet 26 May '09

26 May '09

2009/5/26 Pavel Prochazka <prochapa(a)inf.upol.cz>: > +»······int i=1; > + > +»······/*it moves all backbuffers by 1 to left form id = 1, > +»······the backbuffer swap to frontbuffer and frontbuffer swaps to the end of chain > +»······Something like this: > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······------------^»··»······· > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······|»······»·······»·······| > +»······|FrontBuffer| |BackBuffer0|BackBuffer1|Backbuffer2|....|BackbufferN| > +»······ »····»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······»·······^ > +»······»·······|---------------------------------------------------------------| > +»······»·······^ > +»······»·······|---------------------| > + > +»······»·······»·······»·······»·······»·······»·······»·······»·······»·······»······· > +»······*/ > + > +»······for(;i<This->presentParms.BackBufferCount-1;i++)· > +»······{ > +»······»·······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······»·······hlp2 = (IWineD3DSurfaceImpl *)This->backBuffer[i+1]; > +»······»·······hlp1->hDC = hlp2->hDC; > +»······»·······hlp1->dib.DIBsection = hlp2->dib.DIBsection; > +»······»·······hlp1->dib.bitmap_data = hlp2->dib.bitmap_data; > +»······»·······hlp1->resource.allocatedMemory = hlp2->resource.allocatedMemory; > +»······»·······hlp1->dib.client_memory = hlp2->dib.client_memory; > +»······} > + > +»······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······hlp1->hDC = front->hDC; > +»······hlp1 = (IWineD3DSurfaceImpl *)This->backBuffer[i]; > +»······hlp1->dib.DIBsection = front->dib.DIBsection; > +»······hlp1->dib.bitmap_data = front->dib.bitmap_data; > +»······hlp1->resource.allocatedMemory = front->resource.allocatedMemory; > +»······hlp1->dib.client_memory = front->dib.client_memory; > +»······ > +··· Style issues aside, that's not a very efficient way to implement a swapchain.

1 0

Re: [1/4] comctl32/listview: Basic LVM_GETVIEWRECT tests
by Paul Vriens 26 May '09

26 May '09

Nikolay Sivov wrote: > Changelog: > - Basic LVM_GETVIEWRECT tests > > + todo_wine expect(104, rect.right); > + expect(0, rect.top); > + expect(73, rect.bottom); The first and last one of these 3 introduces errors on several boxes (see test.winehq.org). I guess these numbers can't be hardcoded and need to be calculated somehow? Could you have a look? -- Cheers, Paul.

2 1

Problem Running Winetricks
by Michael 26 May '09

26 May '09

Hi, When I run winetricks, it consistently loops through and creates output files winetricks.1 , winetricks.2 , etc ... until I break the terminal. And doesn't do much more. Each of these files shows:

2 1

Re: [PATCH 05/10] msi: Add support for importing binary OBJECTS.
by Alexandre Julliard 26 May '09

26 May '09

Hib Eris <hib(a)hiberis.nl> writes: > --- > dlls/msi/database.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++--- > dlls/msi/msipriv.h | 3 +- > dlls/msi/record.c | 2 +- > dlls/msi/tests/db.c | 12 +++++----- > 4 files changed, 68 insertions(+), 12 deletions(-) This doesn't work here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok wine: Unhandled page fault on write access to 0x00000004 at address 0x7bc4460e (thread 0019), starting debugger... Unhandled exception: page fault on write access to 0x00000004 in 32-bit code (0x7bc4460e). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7bc4460e ESP:0032f770 EBP:0032f7e8 EFLAGS:00010202( R- -- I - - - ) EAX:00000000 EBX:7bc94448 ECX:00110014 EDX:00000000 ESI:0012dcc8 EDI:0012dc48 Stack dump: 0x0032f770: 0032f784 00110014 00000020 0012dd00 0x0032f780: 0032f794 4d430002 0032f7bc 0012dc58 0x0032f790: 0032f7a4 00110014 00000070 4d430003 0x0032f7a0: 00000000 4d430003 00000000 00000000 0x0032f7b0: 00000000 00000000 00000000 4d430000 0x0032f7c0: 0012dc58 00000070 00000000 00000000 Backtrace: =>0 0x7bc4460e HEAP_CreateFreeBlock+0x3be(subheap=0x110014, ptr=0x12dc48, size=128) [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll (0x0032f7e8) 1 0x7bc44847 HEAP_MakeInUseBlockFree+0x57(subheap=0x110014, pArena=<is not available>) [/home/julliard/wine/wine/dlls/ntdll/heap.c:586] in ntdll (0x0032f838) 2 0x7bc44b3c RtlFreeHeap+0x18c(heap=0x110000, flags=2, ptr=0x12dcc8) [/home/julliard/wine/wine/dlls/ntdll/heap.c:1480] in ntdll (0x0032f898) 3 0x6081aa8e free_table+0x3e(table=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/msipriv.h:1059] in msi (0x0032f8b8) 4 0x6081abae free_cached_tables+0x2e(db=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/../../include/wine/list.h:133] in msi (0x0032f8c8) 5 0x607d3ec2 MSI_CloseDatabase+0x42(arg=0x12b7e8) [/home/julliard/wine/wine/dlls/msi/database.c:66] in msi (0x0032f8e8) 6 0x607e6b58 msiobj_release+0x48(info=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/handle.c:257] in msi (0x0032f918) 7 0x607e6ccf MsiCloseHandle+0xbf(handle=<is not available>) [/home/julliard/wine/wine/dlls/msi/handle.c:311] in msi (0x0032f948) 8 0x6066abda test_binary_import+0x33a() [/home/julliard/wine/wine/dlls/msi/tests/db.c:1991] in msi_test (0x0032fca8) 9 0x60677d7e func_db+0x264e() [/home/julliard/wine/wine/dlls/msi/tests/db.c:7672] in msi_test (0x0032fde8) 10 0x60749a80 run_test+0x130(name="db.c") [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:456] in msi_test (0x0032fe28) 11 0x60749c6f main+0x11f(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/msi/tests/../../../include/wine/test.h:505] in msi_test (0x0032fed8) 12 0x6074a484 __wine_spec_exe_entry+0x84(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032ff08) 13 0x7b878660 start_process+0x130(arg=(nil)) [/home/julliard/wine/wine/dlls/kernel32/process.c:941] in kernel32 (0x0032ffe8) 14 0x6002bc07 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x7bc4460e HEAP_CreateFreeBlock+0x3be [/home/julliard/wine/wine/dlls/ntdll/../../include/wine/list.h:98] in ntdll: movl %eax,0x4(%edx) 98 elem->next->prev = elem->prev; -- Alexandre Julliard julliard(a)winehq.org

1 0

Mac OS X Joystick problem
by Nathan Gray 26 May '09

26 May '09

Hi all, I was happy to see that you recently added support for joysticks in OS X. (As you may or may not recall, I started to work on that problem a while back but never found time to finish it.) In any case, I was disappointed to find that my MS Sidewinder Precision Pro (USB) still doesn't work in the two games I tried -- The IL-2 Sturmovik demo and the Descent Freespace demo. The joystick seems not to be detected at all, from what I can tell. I filed a bug a while back in bugzilla[1] but it doesn't seem to have gotten any attention. Does the joystick code work for other people? Does it require any special configuration? I'm using Mike Kronenberg's 1.1.20 build. Thanks, -n8 [1] http://bugs.winehq.org/show_bug.cgi?id=18424 -- http://n8gray.org

3 6

/. wants a fork
by Remco 26 May '09

26 May '09

Oh great, now there is poison on slashdot: http://tech.slashdot.org/article.pl?sid=09/05/24/2044239 Let's not fork, shall we? Remco

15 14

wine on MacOS 10.5.7: 3/4 success
by Joerg-Cyril.Hoehle＠t-systems.com 25 May '09

25 May '09

Hi, here are my findings about compiling and using wine on an "early 2009" Mac Mini with NVidia graphics, without Fink or Macports. I hope it'll help other people. The good news first: + compilation essentially works. + Pharaoh (1.2 update, nocd) works in desktop mode. - old (16bit?) apps cause winevdm to crash, e.g. PharaohDemo's setup.exe Details follow. Bugs will be submitted separately. The setup is: + "early 2009" NVidia 9400 Mac Mini with OS 10.5.6 + XCode from DVD install disk. I did not install the whole thing, just a few packages, e.g. + gcc4.2 + DeveloperToolsCLI, + DevSDK, X11SDK, OpenGLSDK + CoreAudioSDK etc., without e.g. - gcc4.0 - MacOSX10.5 - DeveloperTools (actually, this one contains the Xcode.app but now complains that it cannot install into a non-empty directory - any ideas?) + Mac OS 10.5.7 update (includes X11 manpages) + XQuartz' X11.2.33.2 Not installing gcc-4.0, I changed the stale symlink /usr/bin/gcc->gcc-4.0 to gcc-4.2. I used neither Fink nor MacPorts. I found /usr/bin/ in MacOS full of OSS already. Like a Debian (hence Ubuntu) system, every tool has its manpage! Fink was not used because I was told it's obsolete. Macports was nuked after it started to configure and compile software as root, which violates my software acceptance policy. Another time I'll try pre-compiled binaries from Mike Kronenberg to see if that makes a difference, but as I plan to do as much regression testing as on Linux, I'll stick with git and compiling myself. ---------------- Compiling checking png.h usability... no checking png.h presence... no checking for png.h... no png is in /usr/X11/include plus /usr/X11/lib/libpng*, not /usr/include Alas, configure tests for png long before testing for X. Will submit bug. ---- checking mach-o/dyld_images.h usability... no checking mach-o/dyld_images.h presence... yes configure: WARNING: mach-o/dyld_images.h: present but cannot be compiled configure: WARNING: mach-o/dyld_images.h: check for missing prerequisite headers? configure: WARNING: mach-o/dyld_images.h: see the Autoconf documentation configure: WARNING: mach-o/dyld_images.h: section "Present But Cannot Be Compiled" configure: WARNING: mach-o/dyld_images.h: proceeding with the preprocessor's result configure: WARNING: mach-o/dyld_images.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## Ruben Hillewaere already mentioned this in http://www.winehq.org/pipermail/wine-devel/2009-May/075287.html In file included from conftest.c:67: /usr/include/mach-o/dyld_images.h:65: error: expected specifier-qualifier-list before 'bool' Perhaps a mising bool typedef? ---- configure --verbose summary configure: libhal 32-bit development files not found, no dynamic device support. configure: libgnutls 32-bit development files not found, no schannel support. configure: libsane 32-bit development files not found, scanners won't be supported. configure: libgphoto2 32-bit development files not found, digital cameras won't be supported. configure: liblcms 32-bit development files not found, Color Management won't be supported. configure: libcapi20 32-bit development files not found, ISDN won't be supported. configure: WARNING: libjpeg 32-bit development files not found, JPEG won't be supported. configure: WARNING: libpng 32-bit development files not found, PNG won't be supported. configure: Finished. Do 'make depend && make' to compile Wine. Pretty much what I know from Ubuntu (except for jpeg+hal), where I never bothered to install the lcms or sane or SSL developer packages. ---- compilation warnings In file included from opengl_ext.h:28, from opengl_ext.c:5: /usr/X11/include/GL/gl.h:1387:1: warning: "GL_GLEXT_PROTOTYPES" redefined In file included from opengl_ext.c:5: opengl_ext.h:27:1: warning: this is the location of the previous definition Looks like a bug I'll submit to the XQuartz project. audiounit.c: In function `SynthUnit_CreateDefaultSynthUnit': audiounit.c:351: warning: `AUGraphNewNode' is deprecated (declared at /System/Library/Frameworks/AudioToolbox.framework/Headers/AUGraph.h:674) This is bug #11242 Wine build complete. ---------------- Running ./wine winecfg wine: created the configuration directory '/Users/xyz/.wine' ---- FreeType library issue resolved Wine cannot find the FreeType font library. To enable Wine to use TrueType fonts please install a version of FreeType greater than or equal to 2.0.5. http://www.freetype.org Building font metrics. This may take some time... Font metrics: 0.0% done fixme:font:LFD_InitFontInfo DBCS fonts like '-daewoo-gothic-medium-r-normal--16-120-100-100-c-160-ksc5601.1987-0' are not working correctly now. [... hundreds of messages like this ...] err:font:XFONT_BuildMetrics failed to load -misc-stheiti-medium-r-normal--100-*-100-100-p-0-ibm-cp866 Font metrics: 100.0% done [... repeated anew for every process started ...] "dlopen() searches the following the following until it finds a compatible Mach-O file: $LD_LIBRARY_PATH, $DYLD_LIBRARY_PATH, current working directory, $DYLD_FALLBACK_LIBRARY_PATH Note: There are no configuration files to control dlopen searching." Set one of those to /usr/X11/lib, because that's where libfreetype* resides in MacOS. There's no need to turn to MacPorts. LD_LIBRARY_PATH=/usr/X11/lib ./wine notepad lets wine finds hundreds of fonts. BTW, Macports' wrapper uses DYLD_FALLBACK_LIBRARY_PATH The ./wine wrapper itself sets DYLD_LIBRARY_PATH to its internal .so dir. Maybe it would not be a good idea to add this directory to the official ./wine wrapper, as it could cause conflicts with Fink or Macports sets of libraries? ---- err:process:__wine_kernel_init boot event wait timed out I get this one *sometimes* on a Linux box as well... ---- no 16 bit apps? winevdm crashes with identical messages on: - Pumuckl Klabauterjagd - Minigolf 1997 (not in AppDB) - Meine Traumburg (dito) - PharaoDemo's setup.exe PharaoDemo:setup.exe "The program winevdm.exe has encountered a serious error ..." Unhandled exception: page fault on read access to 0xffffffff in 32-bit code (1017:00000c1d). Probably a lot of installers will be affected. Is this caused by the mach-o/dyld_images.h warning from configure? Is there no 16bit support on Intel MacOS yet? ---- Pharaoh console log Copying my Linux Pharaoh (1.2 update, nocd) directory over to the Mac, I was pleased to see the title screen and the application running. err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 NVIDIA-1.5.44" The string probably originates from XQuartz' X11.2.33.2. The wine source code expects a space after NVIDIA. Is it actually meningful to return the Apple 1.5 major+minor to a windows program? (On Linux, the numbers are much higher, e.g. "2.1.2 NVIDIA 173.14.09" or "2.1.0 NVIDIA 97.55" -- 2 samples from Google). fixme:d3d:IWineD3DImpl_FillGLCaps OpenGL implementation supports 16 vertex samplers and 16 total samplers fixme:d3d:IWineD3DImpl_FillGLCaps Expected vertex samplers + MAX_TEXTURES(=8) > combined_samplers fixme:win:EnumDisplayDevicesW ((null),0,0x32f664,0x00000000), stub! fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 16 well known from Linux. fixme:wave:wodDsCreate DirectSound not implemented fixme:wave:wodDsCreate The (slower) DirectSound HEL mode will be used instead. probably ok. Pharaoh plays the music. ---- full screen mode Full-screen does not work with Pharaoh. The application exits after: err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found 1024x768x16 @0! (NoRes) err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found 800x600x16 @0! (NoRes) err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found 640x480x16 @0! (NoRes) The LCD's native resolution is higher than those. Hope this helps, Jörg Höhle

2 3

Icon Refresh News (and a question)
by Joel Holdsworth 25 May '09

25 May '09

Hi All, I've been working away little by little at my icons work, and I'm beginning to make a little progress: http://www.airwebreathe.org.uk/alpha-tango-icons.png The screenshot montage shows my work on getting HICONs and HIMAGELISTs to support the alpha channel, combined with a refreshed icon set from Tango. Right now, a lot of the changes I've made are rather bodged, but I'm encouraged because at least here we see a proof of principle. To get this to work, I've basically had to go through fixing places where the alpha channel is incorrectly stripped or ignored. All of them are relatively easily fixed, except the ones in the stretch blt functions. StretchBlt, StretchDIBits et al. seem to have a fast path and a slow path. The fast path is active when no stretching or translation should occur. The slow path performs all other cases, but my tests show that only the fast path preserves the alpha channel. The reason must be that the stretch is performed in X - but this is a problem, because I don't know if it's possible for X to preserve alpha. Does anyone know? My demo has replaced the offending StretchBlts with BitBlts, which works fine, unless the icon has to be rescaled. Does anyone have any thoughts or comments? Thanks Joel

2 2

Re: winhlp32: Avoid duplicate assignment in WINHELP_GetWindowInfo(). (RESEND)
by Eric Pouech 25 May '09

25 May '09

Gerald Pfeifer a écrit : > Originally sent ten days ago; looks obvious to me? > > Gerald > > ChangeLog: > Avoid duplicate assignment in WINHELP_GetWindowInfo(). > > diff --git a/programs/winhlp32/winhelp.c b/programs/winhlp32/winhelp.c > index 7f74d8b..d1980e5 100644 > --- a/programs/winhlp32/winhelp.c > +++ b/programs/winhlp32/winhelp.c > @@ -278,7 +278,7 @@ HLPFILE_WINDOWINFO* WINHELP_GetWindowInfo(HLPFILE* hlpfile, LPCSTR name) > mwi.origin.x = mwi.origin.y = mwi.size.cx = mwi.size.cy = CW_USEDEFAULT; > mwi.style = SW_SHOW; > mwi.win_style = WS_OVERLAPPEDWINDOW; > - mwi.sr_color = mwi.sr_color = 0xFFFFFF; > + mwi.sr_color = 0xFFFFFF; > } > return &mwi; > } > > > > > fix is wrong the second should be nr_color instead of sr_color (hence the "double" assignment) A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Bugzilla: I dont stay logged in
by André Hentschel 25 May '09

25 May '09

Hi, If i log in with both Checkboxes selected, i can do exactly one thing, and then i am logged out again. For example: if i am on a bug and log in, i can write a comment and got logged out. if i log in and select "add an attachment" i can fill the form, but the next step doesnt work correct because i got logged out. can someone fix it please?

3 2

failure to recognize "early 2009" Mac Mini nVidia 9400 OpenGL version string
by Joerg-Cyril.Hoehle＠t-systems.com 25 May '09

25 May '09

Hi, as of wine-1.1.21, wine does not recognize the "early 2009" Mac Mini OpenGL version string from nVidia: err:d3d_caps:IWineD3DImpl_FillGLCaps Invalid nVidia version string: "2.0 NVIDIA-1.5.44" The string probably originates from XQuartz' X11.2.3.3.2. The wine source code expects a space after NVIDIA. On Linux, the numbers are much higher, e.g. "2.1.2 NVIDIA 173.14.09" or "2.1.0 NVIDIA 97.55" -- 2 samples from Google. Before I submit a patch to have wine recognize either space or "-" as separator, I'd like to query the list whether it actually makes sense to return major = 1, minor = 5, i.e. Apple numbers to a MS-Windows program? Or should I not care about the useage and just parse the string (i.e. submit patch)? Thanks, Jörg Höhle

3 2

DXTn textures in D3DX9
by Tony Wasserka 25 May '09

25 May '09

Hi everyone, I'm working on implementing D3DXLoadSurfaceFromFileInMemory right now, but I've got a problem. The function most convert a loaded surface's data to a user specified surface format (I did not yet find a way to do it elsehow, UpdateTexture and StretchRect are to limited for that task, suggestions welcome if I missed anything). Now, if the user specifies that D3DX9 needs to convert e.g. an R8G8B8 surface to DXT1 (or to save a surface to a DXTn compressed DDS file), I'm not sure wether I can implement that behavior; on #winehackers I was told that the (de)compression part is coverered by S3's patents, but the Gimp DDS plugin and this (http://mollyrocket.com/forums/viewtopic.php?t=392) seem to provide OSS solutions for it anways. So... Can anybody tell me for sure wether I may implement this code or not? Best regards, Tony

6 10

News on Wine 1.1.21/MacOSX/XQuartz 2.3.3
by James McKenzie 24 May '09

24 May '09

The news is good. First, if you are using Tiger, X11 is still broken and probably will remain so. Second, you do not need to upgrade to Leopard 10.5.7 to use XQuartz 2.3.3, the installer was fixed so it would install on 10.5.6. Third, Graphical games that depend on GLSL functions work. I tried dOOm, the Windows95 version, and it is definitely playable. Frame rates drop whenever you pick something up, but this also happens with CrossOver Games for Mac. This does not happen with Crossover Pro for Mac 7.1. I do not have any other programs that depend on GLSL functionality, but I suspect they will work on this combination. BTW, the version of Wine for Mac that I used for testing was built using Mike Kronenberg's Build Environment 1.1.5. James McKenzie

7 13

annoying pkg-config problem on 64 bit Ubuntu 8.10
by Dan Kegel 24 May '09

24 May '09

On Ubuntu 8.10: $ pkg-config --libs dbus-1 -L//lib -ldbus-1 This leads to configure:13190: checking for dbus_connection_close in -ldbus-1 configure:13225: gcc -m32 -o conftest -g -O2 -DDBUS_API_SUBJECT_TO_CHANGE -I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include conftest.c -ldbus-1 -L//lib -lhal -ldbus-1 >&5 /usr/bin/ld: //lib/libdbus-1.so: incompatible target configure:13253: result: no Also affects sane. Haven't checked Jaunty yet to see if it's still busted. We may need to postprocess pkg-config's output to add the missing 32 in some cases. Not sure if it's worth it.

5 5

Re: [PATCH 01/10] msi/tests: Add tests for binary OBJECTS.
by Austin English 24 May '09

24 May '09

On Sun, May 24, 2009 at 11:51 AM, Hib Eris <hib(a)hiberis.nl> wrote: > Hi, > > I will send 10 patches for msi.dll that will add support for OBJECT > types in the Msi Database and that will allow you to merge in new > tables. > > This will make the WiX (Windows Installer XML) toolkit work a lot better. > > Please review and provide feedback on what can be improved as this is > my first substantial patch series to wine. > > Kind regards, > > Hib Eris > > > --- > dlls/msi/tests/db.c | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 84 insertions(+), 0 deletions(-) > > > > Great work. Thanks for helping Wine! -- -Austin

1 0

Using Windows ODBC drivers
by martti 24 May '09

24 May '09

Types successfully tested under wine: DB Type=PostgreSQL, Usefullness=100% Wine use: 1.1.21

1 0

re: urlmon: Cache binding notif window.
by Dan Kegel 24 May '09

24 May '09

Hi Jacek, why do you have tls_list in http://www.winehq.org/pipermail/wine-patches/2009-May/072833.html ? The usual idiom is to just free each thread's data in THREAD_DETACH, isn't it? I ran into this while chasing a crash regression in Sketchup, see Anastasius' comments in http://bugs.winehq.org/show_bug.cgi?id=18601 - Dan

2 1

[comctl32] Test request
by Nikolay Sivov 24 May '09

24 May '09

Hi. I've just prepared some simple MRU tests and I need test them on various native platfoms - tested only on xp sp2 so this one could be skipped. Could somebody do it?

1 0

Updating bugs in Bugzilla
by Ken Sharp 24 May '09

24 May '09

Hi all, Is there any way I can have access to update bugs that I did not open in Bugzilla? I update a lot of bugs and some of them are not set correctly (incorrect component or incorrect URL). Wrong URLs are a real pain because it can lead to testing the wrong version of an app (see Bug 13371). At the moment I have to ask someone with access to make these changes for me, and they're not always done. I don't want to ask them repeatedly because they have better things to do, I'm sure, and it would be easier if I could do it myself. I have admin access on the AppDB for this reason. Is there any way I could have a similar access on Bugzilla? I had no idea where to send this email to... Thanks, Ken.

1 1

Static-ify rsaenh/mpi?
by Francois Gouget 23 May '09

23 May '09

So dlls/rsaenh/mpi.c defines 13 functions that are only used there. So they could be made static by tweaking mpi.c and tomcrypt.h. However my understanding is that this files has been imported in Wine from another project so maybe it's not a good idea to diverge much from them. What do you think? Should we just leave them as is? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner

2 3

re: Updating bugs in Bugzilla
by Dan Kegel 23 May '09

23 May '09

Ken Sharp asked: > [Can I have bugzilla privs?] OK, you have them now. Please them wisely.

1 0

[patch] segv on use-after-free in dsound/buffer.c
by Yuriy Kaminskiy 23 May '09

23 May '09

Hello! One of games rarely crashed with segv in line 86 of dsound/buffer.c: 85: IDirectSoundBuffer_Release((LPDIRECTSOUNDBUFFER)This->dsb); 86: This->dsb->notify = NULL; (sorry, I failed to save actual backtrace at the time). This looks like typical assign-after-free bug. I've applied attached patch (wine-1.1.7, now on 1.1.19), no crashes so far (btw, similar *Secodary*Release method down in code uses proper order - assign-NULL-then-release).

2 1

Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3
by James Mckenzie 22 May '09

22 May '09

Roderick Colenbrander wrote about Re: News on Wine 1.1.21/MacOSX/XQuartz 2.3.3 > >On Wed, May 20, 2009 at 4:04 PM, Austin English <austinenglish(a)gmail.com> wrote: >> On Wed, May 20, 2009 at 4:46 AM, Roderick Colenbrander >> <thunderbird2k(a)gmail.com> wrote: >>> On Tue, May 19, 2009 at 6:41 PM, Mike Kronenberg >>> <mike.kronenberg(a)kronenberg.org> wrote: >>>> On 18.05.2009, at 06:56, Dmitry Timoshkov wrote: >>>> >>>>> "James McKenzie" <jjmckenzie51(a)earthlink.net> wrote: >>>>> >>>>>> Austin: >>>>>> Contact Mike Kronenberg or Zach Drayer and see what they currently >>>>>> have. >>>>> >>>>> IMHO since they haven't even bothered so far to change the license from >>>>> GPL to LGPL to match Wine, and clarify what exactly is so much different >>>>> in their builds so that they insist on different naming (Darwine vs. >>>>> Wine), >>>>> they shouldn't be even considered as partners to the Wine project. >>>>> >>>>> If we could have our own Wine builds for Intel Macs, that would finally >>>>> help to avoid this confusion Darwine adds, and remove it from our Wiki >>>>> altogether (since it's apparently where the users coming to them from). >>>>> >>>>> -- >>>>> Dmitry. >>>>> >>>>> >>>> >>>> >>>> >>>> Hi, >>>> >>>> (I hope I did not double-post, but somehow my mail from yesterday was eaten >>>> by filter-gnomes) >>>> >>>> It's not about being willing to, but plain lack of time. >>>> I follow this list closely and work on solutions as time permits. >>>> After half a year, it's been four weeks now that I am able again to build >>>> and test on a regular base again. >>>> >>>> There are other components on OS X that need some love, like the >>>> winehelper.app into which I'm looking atm. >>>> >>>> License and renaming is definitely on the list. >>>> I thought to revamp the package, once the winehelper is replaced, to not >>>> double do the work. >>>> >>>> As already mentioned, I build the dependencies and store them inside the >>>> apple .app package, which allows for drag'n'drop installation and removal. >>>> >>>> Having the dependencies as frameworks would be even better, as there is a >>>> lot of trouble with PATHS, especially if multiple environments are on the >>>> system, like fink and macports. >>>> >>>> But if the name-change is the most pressing issue, I will gladly do that >>>> with this weekends release. >>>> >>>> Mike Kronenberg >>>> >>>> >>>> >>> >>> Could you also upload some docs / scripts on how to build 'DarWine' >>> from scratch? I have an app which I need to run on osx which I like to >>> package as well. I have time to help fixing osx issues (duplicating >>> the effort is not worth it). >>> >>> Roderick >>> >>> >>> >> >> It's available under 'build env': >> http://www.kronenberg.org/darwine/buildenv-1.1.5.zip >> >> -- >> -Austin >> > >Thanks, I used this to compile wine 1.1.21 for testing purposes this >week. I had to update the scripts a bit (e.g. use newere versions of >some libraries and tools because the old ones are offline). I can post >a patch against the old script. Further don't ship the opengl hack >anymore for new wine packages as you are aware it isn't needed for >xquartz 2.3.3 anymore. Everyone should move to the latest xquartz. >This might prevent some opengl bug reports which I have to close on >bugzilla as well ;) > Does XQuartz 2.3.3 apply on Tiger systems? The 'hack' is for both Tiger and Leopard so that some missing functions will work. Please list the updated libraries so that I can upgrade the script as well. James McKenzie

1 0

Entry point not found for GetDiskInfoA (wininet_crosstest.exe)
by Detlef Riekenberg 22 May '09

22 May '09

In "dlls/wininet/tests/urlcache.c", GetDiskInfoA is called, but wininet.dll (native and wine) export this function only by ordinal. When I build the crosstest, my mingw [i586-mingw32msvc-gcc (GCC) 4.2.1-sjlj (mingw32-2)] creates a named Import for GetDiskInfoA with an ordinal hint of 65. Using that executable on Windows or Wine is not possible (Entry point not found for GetDiskInfoA) The wininet_test.exe on winehq has an ordinal Import of 102 in that place. How can we fix that? (My patch to use an ordinal import in the test was dropped: http://www.winehq.org/pipermail/wine-patches/2009-May/073130.html ) -- By by ... Detlef

2 2

Handle Types: Big flaw in wine
by Daniel Santos 22 May '09

22 May '09

As I've been working with user32, adding tests & such, I've noticed that gdi32 also suffers from the same drawbacks: it appears to have no mechanism to track object types with handles. Thus, the functions (that I've examined thus far) simply assume that the caller responsibly passed a handle to the correct object type and proceeds with that assumption. This is the cause of at least one bug that I know of (18371). Right now, I'm trying to determine the best way to implement a solution and I'm still green to wine's architecture. My initial thought was a handle type table in user32 that would just contain a handle's type as a byte (or possibly two types packed in one byte since there are less than 16) using a huge ugly 64k table that directly mapped handle to entry (ugly but correct) and something more efficient later. But I'm wondering if it wouldn't be more appropriate to put something like that in kernel32's global arena table. Input appreciated. Daniel

1 0

Using TlsGetValue internally
by Daniel Santos 22 May '09

22 May '09

I'm playing with user32/cursoricon.c and winex11.drv/mouse.c and have noticed that one of the TODOs is that SetCursor (and probably lots others) clear the last error when they do not do so in windows. I tracked down the cause and winex11.drv's primary function for retrieving its per-thread data, x11drv_thread_data() calls the public kernel32 function TlsGetValue, which must set the last error to zero by specification. So, should we be using some internal function to get the TLS data that does not alter SetLastError or should we just save the last error in winex11.drv, call TlsGetValue and then restore the last error state? The later seems hack-ish, but the former sounds like a pain. Thanks, Daniel

1 0

Re: Change BITS_IBackgroundCopyJob_SetPriority to a stub so the EvE-Online patcher works.
by Ricardo Filipe 21 May '09

21 May '09

2009/5/20 Tim Wright <timw(a)splhi.com> > The EvE-online updater blows up because it's trying to set the download > priority in BITS (qmgr) and that isn't implemented. Simply stubbing it to > return S_OK is sufficient to allow it to work. > > Third attempt at sending. For some reason, it isn't being posted from > git-send-email even though the Cc: arrives just fine at another account. > Patch against git repository. This is bug 18528/12312. > > > > --- > dlls/qmgr/job.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c > index 3baa893..09693a3 100644 > --- a/dlls/qmgr/job.c > +++ b/dlls/qmgr/job.c > @@ -334,8 +334,8 @@ static HRESULT WINAPI > BITS_IBackgroundCopyJob_SetPriority( > IBackgroundCopyJob2 *iface, > BG_JOB_PRIORITY Val) > { > - FIXME("Not implemented\n"); > - return E_NOTIMPL; > + FIXME("(%p,0x%08x) stub\n", iface, Val); > + return S_OK; > } > > static HRESULT WINAPI BITS_IBackgroundCopyJob_GetPriority( > -- > 1.6.0.4 > > > > > your previous patch was already commited. check git page the next day when you send patches. http://source.winehq.org/git/wine.git/?a=commit;h=cb26244adb4e15ab60e4d02b5… ;)

2 1

Re: Bugzilla upgrade - opening attachments in browser
by Austin English 21 May '09

21 May '09

On Wed, May 20, 2009 at 6:05 AM, Igor Tarasov <tarasov.igor(a)gmail.com> wrote: > attachment.cgi shows that it relies on allow_attachment_display > parameter in bugzilla configuration. It has to be set to true. > > -- > Igor > Can a bugzilla admin please enable this? -- -Austin

3 4

Re: shell32: for FO_COPY, if the destination is an empty string, SHFileOperation should use the current directory.
by Alexandre Julliard 21 May '09

21 May '09

lionel_debroux(a)yahoo.fr writes: > @@ -1179,6 +1181,15 @@ static HRESULT copy_files(FILE_OPERATION *op, const FILE_LIST *flFrom, FILE_LIST > const FILE_ENTRY *entryToCopy; > const FILE_ENTRY *fileDest = &flTo->feFiles[0]; > > + /* If the destination is empty, SHFileOperation should use the current directory */ > + if (!fileDest) > + { > + WCHAR currd[MAX_PATH]; > + GetCurrentDirectoryW(MAX_PATH, currd); > + parse_file_list(flTo, currd); > + fileDest = &flTo->feFiles[0]; > + } This can't possibly work. parse_file_list requires a null-terminated list, and you will be overwriting the previous data. This needs more thought. -- Alexandre Julliard julliard(a)winehq.org

2 2

DIB Engine - Mostly fixed against test suite
by Massimo Del Fedele 21 May '09

21 May '09

Remaining bugs are related to : 1) Some color on monochrome bitmaps.... here I guess nobody knows how to do it right. I fixed some todo wine (most) but have 2 failures which wine does right. Seldom used anyways, and happens only on weird palettes. I guess not ever Microsoft knows what they did on this respect :-) 2) an AlphaBlend() call which should fail and doesn't. Here I really don't know why it should fail..... Uninfluent, anyways. 3) GetDIBits on a source DIB with BPP <= 8 fails to retrieve the original DIB palette, and synthesizes a new one instead. For the moment I found no simple way to grab the palette from inside GetDIBits without maintaining a linked list of HBITMAP <--> internal bitmaps. Not worth the effort for the moment anyways. If somebody notices weird colors due to it, I'll try to fix..... There are still some missing/buggy features rarely used that aren't spotted by testsuite; by now I've no time to fix them, anyways no one felt into them up to now :-) Austin, could you please retest it against test suite ? (code on Bug421 page) Ciao Max

6 9

Need help writing test
by Igor Tarasov 20 May '09

20 May '09

Hi! I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, but I have some problems. I see that there is bug, when I test it with control spy. But when I repeat it in testcase, it won't work. Here is how you can reproduce it: TB_SETBITMAPSIZE 20,20 TB_SETBUTTONSIZE 30,30 TB_SETBITMAPSIZE 10,10 Now, if you do TB_SETBUTTONSIZE, you'll see the difference. builtin comctl will return 17,16. Native - 30,16. But when I write something like this: rebuild_toolbar_with_buttons(&hToolbar); himl = ImageList_LoadImage(GetModuleHandle(NULL), MAKEINTRESOURCE(IDB_BITMAP_80x15), 20, 2, CLR_NONE, IMAGE_BITMAP, LR_DEFAULTCOLOR); ok(SendMessageA(hToolbar, TB_SETIMAGELIST, 0, (LRESULT)himl) == 0, "TB_SETIMAGELIST failed\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(20, 20)); SendMessageA(hToolbar, TB_SETBUTTONSIZE, 0, MAKELONG(30, 30)); ok(SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0) == MAKELONG(30, 30), "Unexpected button size\n"); SendMessageA(hToolbar, TB_SETBITMAPSIZE, 0, MAKELONG(10, 10)); compare((int)SendMessageA(hToolbar, TB_GETBUTTONSIZE, 0, 0), MAKELONG(30, 16), "%x"); This test fails, when I test it with native comctl32 (the size is 17,16). Why could this happen or what am I doing wrong? -- Igor

2 2

Re: gdiplus: implement partially transparent solid fill brushes
by Vincent Povirk 20 May '09

20 May '09

Don't commit this one. I forgot to pre-multiply the alpha. Vincent Povirk On Wed, May 20, 2009 at 11:33 AM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

Re: [PATCH] Add missing classes for DOMDocument in msxml, and add test-cases back it up.
by Austin English 20 May '09

20 May '09

On Tue, May 19, 2009 at 3:07 PM, Judy Devyak <judycarol(a)ameritech.net> wrote: > > > > You forgot the patch. -- -Austin

1 0

Re: [PATCH 7/8] urlmon: Added MIME filter handling in BindProtocol tests.
by Paul Vriens 20 May '09

20 May '09

Jacek Caban wrote: > --- > dlls/urlmon/tests/protocol.c | 723 > +++++++++++++++++++++++++++++++++++------- > 1 files changed, 608 insertions(+), 115 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, This introduces extra failures on what seems to be mostly on IE7 and higher; see test.winehq.org. Could you have a look? -- Cheers, Paul.

2 1

malloc() use in rpcrt4/tests/server.c
by Francois Gouget 20 May '09

20 May '09

Is there a specific reason for using malloc() in these tests? Testing that rpcrt4 does not assume HeapAlloc pointers? (but why would it even care?) Here are the relevant lines: in midl_user_allocate(): dlls/rpcrt4/tests/server.c:56: use HeapXxx(): return malloc(n); in array_tests(): dlls/rpcrt4/tests/server.c:1212: use HeapXxx(): dc = malloc(FIELD_OFFSET(doub_carr_t, a[2])); dlls/rpcrt4/tests/server.c:1214: use HeapXxx(): dc->a[0] = malloc(FIELD_OFFSET(doub_carr_1_t, a[3])); dlls/rpcrt4/tests/server.c:1219: use HeapXxx(): dc->a[1] = malloc(FIELD_OFFSET(doub_carr_1_t, a[2])); -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)
by Paul Vriens 20 May '09

20 May '09

Marcus Meissner wrote: > Hi, > > Not sure if we need to set these values in all error paths, > but definitely not in the NULL lpwhr. (lpwhdr?) > > Ciao, Marcus > --- > dlls/wininet/http.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 212ff9f..53c3743 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -3831,8 +3831,9 @@ static BOOL HTTP_OpenConnection(LPWININETHTTPREQW lpwhr) > > TRACE("-->\n"); > > + if (!lpwhr) goto lend2; > > - if (NULL == lpwhr || lpwhr->hdr.htype != WH_HHTTPREQ) > + if (lpwhr->hdr.htype != WH_HHTTPREQ) > { > INTERNET_SetLastError(ERROR_INVALID_PARAMETER); > goto lend; > @@ -3894,6 +3895,7 @@ lend: > lpwhr->read_pos = lpwhr->read_size = 0; > lpwhr->read_chunked = FALSE; > > +lend2: > TRACE("%d <--\n", bSuccess); > return bSuccess; > } Hi Marcus, After AJ's remark you marked this Coverity one as "lpwhr can not be NULL". Should we thus delete the "NULL == lpwhr" altogether? -- Cheers, Paul.

2 1

Bugzilla upgrade - opening attachments in browser
by Austin English 20 May '09

20 May '09

It seems the bugzilla upgrade stopped allowing opening attachments in browser. Not sure if that's by choice or just an unchanged setting, but having to open .txt/.jpeg/.png files in outside applications is a bit annoying...Any possibility of fixing that? -- -Austin

2 1

user32: improvements
by Daniel Santos 20 May '09

20 May '09

In the process of working on this bug (http://bugs.winehq.org/show_bug.cgi?id=18371), I have discovered that user32's SetCursor function does not ensure that the the handle passed is valid or that it is even a handle to a cursor object (and it seems that the lingo for user32 objects is "resources"). The root cause of this problem is that the app attempts to use a cursor after it already destroyed it. At first, this just causes the cursor to be blank. Then, it would appear that the handle is re-used for a different type of resource, which leads to the gibberish image & subsequent hang. When this app runs on windows, I presume that the SetCursor calls just fail and the app resumes harmlessly ignoring the failure (or correcting it, either way). In general, this flaw will affect applications which use the user32 api irresponsibly, and I'm certain that a great number of windows apps out there, to some extent, do. My 1st step is to write some tests that illustrate/prove this problem (and that it works on windows) and I'm building the tests now so I can start on that. However, I've been reading up and considering how to implement a solution. I presume that this problem affects every user32 handle & function related to them, but I have only thoroughly examined mousecursor.c, so please forgive any incorrect assumptions I still have at this point (and let me know if I'm way off!). There was a quaint MSDN article on how the windows GDI32 dll manages GDI objects that even gave the internal structure, etc. (http://msdn.microsoft.com/en-us/magazine/cc188782.aspx). Although this only covers gdi32, I'm getting the idea that what needs to happen in user32 isn't too much different. Essentially, it would seem that user32 needs to associate a handle with a type and it would *appear* at this point that would be sufficient. However, I need to gain a better understanding of the nuisances of user32 objects.. From reading this ms kb article (http://support.microsoft.com/kb/184802), it seems that the windows user32 maintains 3 different types of heaps, a global one, one for each desktop and a different (differently sized?) one for non-interactive desktops. Windows' "global heap" is where user32 stores it's handle table, presumably which, simply associates a kernel32 handle with appropriate information for user32 objects, similar to the way GDI does (as illustrated in the above referenced MSDN article). Thus, if you create a thread, it can never have the same handle value as a cursor, icon, etc. So I'm going to write my tests on my windows machine, starting with only the mousecursor.c stuff because there appears to be quite a lot of ground to cover. If anybody has any feedback, corrections to anything I've said, etc. please do reply. Daniel

1 0

Re: Detecting an invalid handle in setupapi
by Daniel Santos 19 May '09

19 May '09

oops, I meant to reply-all on this. --- On Mon, 5/18/09, Daniel Santos <javatroubadour(a)yahoo.com> wrote: From: Daniel Santos <javatroubadour(a)yahoo.com> Subject: Re: Detecting an invalid handle in setupapi To: "Paul Vriens" <paul.vriens.wine(a)gmail.com> Date: Monday, May 18, 2009, 5:43 PM I'm so very glad you brought this up Paul. I'm new to wine development and I've been working on Lord of the Rings Online issues and I have discovered and validated that the root cause of two of my problems are related (http://bugs.winehq.org/show_bug.cgi?id=18371). There are numerous places in Wine where the validity of handles are not checked. If the handle turns out to be invalid, then a NULL pointer is simply passed instead (which sometimes has an alternate meaning). Worse yet, in the code I was working with (dlls/kernel32/global16.c) the type of object the handle refers to is not stored! I see this as a critical flaw in Wine and I hope I can come up with a viable solution. I'm planning on setting up some test programs to examine the bit-data of some windows objects (starting with user32 -- where my issue lies) as any solution will have to be bit-compatibile with windows since apps like paint shop pro de-reference handles and examine the data of the underlying objects. In truth, if the LOTRO app didn't destroy objects it was still using and then try to use them, the problem wouldn't exist -- this part of wine will work perfectly if the app behaved responsibly. But development timelines and pressures frequently lead to code that works, but is incorrect and is a part of reality. Daniel --- On Sat, 5/16/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: From: Paul Vriens <paul.vriens.wine(a)gmail.com> Subject: Detecting an invalid handle in setupapi To: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> Date: Saturday, May 16, 2009, 12:18 PM Hi, I'm trying to install Microsoft's MMC (W2K3) and it crashes every now and then with different symptoms. I've tracked it down to what I think is a fault in the application that triggers a bug in Wine. All inf files that are read are closed with SetupCloseInfFile but the app is still trying to use the handle in a call to SetupFindFirstLineA. On Windows (tested on W2K3) this will lead to a failure of SetupFindFirstLineA with a last error of ERROR_INVALID_HANDLE. On Wine we don't check the handle and thus the outcome cannot be predicted (mostly crash). What ways do we have to detect invalid handles or better yet how can this be solved? -- Cheers, Paul.

1 0

Re: winemaker: add include-directory parsing
by Paul Vriens 19 May '09

19 May '09

André Hentschel wrote: > --- > tools/winemaker | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi André, Not a comment on the patch itself but this is the third time you tried with the same patch. We usually add a 'resend' to the subject of a patch that is, uuh resend. If it's another revision we add 'try x'. In your case you should probably ask (on wine-devel) for comments or contact AJ directly on irc. -- Cheers, Paul.

1 0

re: [Article] WINE and the importance of application compatibility
by Dan Kegel 19 May '09

19 May '09

James McKensie wrote: > WE need to get to the point where most of the common business type > applications will run in Wine without a bunch of twiddling and fixes. Well, yes. That was one of my goals during my big Wine push ( http://www.winehq.org/pipermail/wine-devel/2008-February/062550.html ), and I think we made a lot of progress. Still lots to do, as you know. Sure would be nice if we could convince the DoD they needed a second source for Windows :-) - Dan

9 10

Gecko installation broken?
by Stefan Dösinger 19 May '09

19 May '09

Hi, Is my setup broken, or does the gecko installation fail? In a new wine prefix, when I open builtin iexplore, I get the installation dialog. The download runs successfully, but after installation iexplore still says that HTML rendering is currently disabled. When I run iexplore again, I again see the Wine Gecko installer dialog box. My hacky nightly game tests ran into this problem. The last successfull Team Fotress 2 test run is from May 14, 2009. After that my Gecko setup script failed and did not even try to start up Steam. Cheers, Stefan

4 6

Re: ntdll/tests: Mark return value of RtlUnicodeStringToInteger("", 16) as broken for nt4.
by Paul Vriens 19 May '09

19 May '09

Huw Davies wrote: > --- > dlls/ntdll/tests/rtlstr.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi, I don't think this is correct. This test has always succeeded until March 9th. There haven't been any changes to the test in that period, but I remember an upgrade of winehq in that weekend. In other words, there is more to it. Testing a simple cross compiled version of this test doesn't yield an error on NT4. -- Cheers, Paul.

3 2

Re: gdiplus: implement GdipTransformPoints
by Nikolay Sivov 19 May '09

19 May '09

Vincent Povirk wrote: >From 1de9b2291bf9a5617ca1e3b0cba5f1260889c259 Mon Sep 17 00:00:00 2001 From: Vincent Povirk <vincent(a)codeweavers.com> Date: Mon, 23 Mar 2009 16:34:12 -0500 Subject: [PATCH] gdiplus: implement GdipTransformPoints It's a strange way to check enumeration with integer comparison, isn't it? And not clear in this particular case. > + if (stat == Ok) > + { > + unitscale = convert_unit(graphics->hdc, graphics->unit); > + > + if(graphics->unit != UnitDisplay) > + unitscale *= graphics->scale; > + > + if (src_space <= CoordinateSpaceWorld && dst_space >= CoordinateSpacePage) > + GdipMultiplyMatrix(matrix, graphics->worldtrans, MatrixOrderAppend); > + if (src_space <= CoordinateSpacePage && dst_space >= CoordinateSpaceDevice) > + GdipScaleMatrix(matrix, unitscale, unitscale, MatrixOrderAppend); > + > + if (dst_space <= CoordinateSpacePage && src_space >= CoordinateSpaceDevice) > + GdipScaleMatrix(matrix, 1.0/unitscale, 1.0/unitscale, MatrixOrderAppend); > + if (dst_space <= CoordinateSpaceWorld && src_space >= CoordinateSpacePage) > + { > + GpMatrix *inverted_transform; > + stat = GdipCloneMatrix(graphics->worldtrans, &inverted_transform); > + if (stat == Ok) > + { > + GdipInvertMatrix(inverted_transform); > + GdipMultiplyMatrix(matrix, inverted_transform, MatrixOrderAppend); > + GdipDeleteMatrix(inverted_transform); > + } > + Maybe it's better to use 'switch' for source coords with falling and ifs inside cases for destination. <= CoordinateSpaceWorld is just CoordinateSpaceWorld >= CoordinateSpaceDevice - is CoordinateSpaceDevice.

3 3

Re: [PATCH 2/2] ole32/tests: Add tests to show the WdtpInterfacePointer marshal data looks like the result of CoMarshalInterface.
by Paul Vriens 19 May '09

19 May '09

Huw Davies wrote: > --- > dlls/ole32/tests/usrmarshal.c | 38 +++++++++++++++++++++----------------- > 1 files changed, 21 insertions(+), 17 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Huw, Could you have a look at the test results are test.winehq.org> This patch and the other one against usrmarshall.c introduced some test failures on several platforms. -- Cheers, Paul.

1 1

Re: [PATCH 8/8] urlmon: Added binding with MIME filter tests.
by Alexandre Julliard 19 May '09

19 May '09

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/tests/url.c | 782 > ++++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 636 insertions(+), 146 deletions(-) This is failing here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:2939: Test failed: mon should be destroyed here url.c:2940: Test failed: bctx should be destroyed here make: *** [url.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [wintrust/tests] Add some basic CryptCATOpen tests
by Detlef Riekenberg 19 May '09

19 May '09

On Mo, 2009-05-18 at 16:07 +0200, Paul Vriens wrote: > + hcat = pCryptCATOpen(emptyW, 0, 0, 0, 0); > + todo_wine > + { > + ok(hcat != NULL && hcat != INVALID_HANDLE_VALUE, "Expected a > correct handle\n"); > + ok(GetLastError() == ERROR_SUCCESS, > + "Expected ERROR_SUCCESS, got %08x\n", GetLastError()); > + } MSDN documents INVALID_HANDLE_VALUE on failure. When NULL is valid result, then a comment about the MSDN error would be nice. Did you have an application, that need ERROR_SUCCESS? The result of GetLastError() should only be tested, when the function failed, or when GetLastError is documented to be valid on success. -- By by ... Detlef

2 1

Re: winspool.drv: implement semi-stub of EnumJobsW
by Detlef Riekenberg 18 May '09

18 May '09

On Mo, 2009-05-18 at 19:30 +0400, Vitaly Perov wrote: > --- > dlls/winspool.drv/info.c | 36 +++++++++++++++++++++++++++++++++++- > 1 files changed, 35 insertions(+), 1 deletions(-) The correct location for an implementation is localspl.dll For which Application did you changed the stub? The important thing to decide first, what Wine is allowed to return: a) Informations from Wine and from Host-OS b) Informations from Wine only (will be empty most of the time) The current code is using "b", but your Patch added: c) Informations from the Host-OS only which is not correct. I'm fine to migrate from "b" to "a". Thanks for working on printing. -- By by ... Detlef

1 0

Re: [2/3] d3dx9: Add utility functions for loading files and resources into memory
by Stefan Dösinger 18 May '09

18 May '09

Am Montag, 18. Mai 2009 17:44:17 schrieb Tony Wasserka: > +HRESULT LoadFileIntoMemoryA(LPCSTR filename, LPVOID *buffer, DWORD *length) Do you need this function? Woudn't it be better to wrap A->W at the API level and have all internal functions W only? > + handle = CreateFileW(filename, GENERIC_READ, FILE_SHARE_READ, 0, OPEN_EXISTING, 0, 0); > + if(handle == INVALID_HANDLE_VALUE) return D3DERR_INVALIDCALL; > + > + *length = GetFileSize(handle, NULL); >+ if(*length == INVALID_FILE_SIZE) return D3DERR_INVALIDCALL; > + > + *buffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, *length); Is there a particular reason not to use mmap, or whatever the Windows equivalent is?

1 0

Re: [shell32] Improve the Dutch 'about' message box
by Reece Dunn 18 May '09

18 May '09

2009/5/12 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > Changed the sizes of the buttons and window to be the same as in > English. This make sure the 'Wine license' button can be fully read in > Dutch. > > - DEFPUSHBUTTON "OK", IDOK, 153, 133, 50, 12, WS_TABSTOP > + DEFPUSHBUTTON "OK", IDOK, 153, 133, 60, 12, WS_TABSTOP According to Windows guidelines, command buttons (http://msdn.microsoft.com/en-us/library/aa511453.aspx) should be 50 x 14 DLUs (they can be wider than 50 DLUs, but only if the text is bigger than that, which it shouldn't for OK buttons) and have a 4 DLU spacing between other controls. This is so they look good in the presence of themes. - Reece

5 9

Re: [4/4]msctf: starting implementation of ITfContext::RequestEditSession and ITextStoreACPSink::OnLockGranted
by Alexandre Julliard 18 May '09

18 May '09

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/msctf/context.c | 68 > ++++++++++++++++++++++++++++++++++-- > dlls/msctf/tests/inputprocessor.c | 29 +++++++++++----- > include/textstor.idl | 2 + > 3 files changed, 86 insertions(+), 13 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M msctf.dll -T ../../.. -p msctf_test.exe.so inputprocessor.c && touch inputprocessor.ok inputprocessor.c:155: Test succeeded inside todo block: GetStatus called too many times make[2]: *** [inputprocessor.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winhttp: avoid NULL ptr dereference (Coverity 927)
by Alexandre Julliard 18 May '09

18 May '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > Not sure if we need to set these values in all error paths, > but definitely not in the NULL lpwhr. (lpwhdr?) There's no reason to have NULL checks in internal functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

[Article] WINE and the importance of application compatibility
by nn 17 May '09

17 May '09

WINE and the importance of application compatibility http://community.zdnet.co.uk/blog/0,1000000567,10012751o-2000630136b,00.htm Need a Holiday? Win a $10,000 Holiday of your choice. Enter now.http://us.lrd.yahoo.com/_ylc=X3oDMTJxN2x2ZmNpBF9zAzIwMjM2MTY2MTMEdG1fZG…

3 2

SoC 2009 / Application Test Suite Update
by Austin English 17 May '09

17 May '09

Howdy all, I've been working on the test suite. I've got a few basic tests set up with notepad, and I'm currently working on setting up the framework, using AutoHotKey to both run all the tests and parse the logs for failures/passing todo's. For those interested, here's the first 'real' script I've written. It sets up a test directory (C:\appinstall), downloads sha1sum.exe (if it doesn't exist), verifies its own sha1sum, downloads winscp.exe (portable version), sets up winscp.ini with its settings (I was going to use keyboard/mouse control, but ftp.winehq.org times out to quickly, and adjusting that setting with mouse/keyboard would be a lot more trouble), runs winscp, downloads welcome.msg, closes winscp, sha1sum's welcome.msg, and finally, deletes welcome.msg and winscp.ini. It already found one bug :-): http://bugs.winehq.org/show_bug.cgi?id=18455. On windows, when selecting the file to download, winscp pops up a dialog to allow you to put in an alternate path to save the file. On windows, it's already selected, so one can simply type a different path. On Wine, it's not selected, breaking the script. It's an easy work around (sending {HOME}, followed by {SHIFT}{END}), it's interesting that the script allows us to find such subtle bugs. Back to work... -- -Austin

3 4

WINE Intel
by MD.IMAM HOSSAIN 17 May '09

17 May '09

Dear WINE Developers, Good morning. A great journey to WINE's Direct3D support since the beginning of its life time. Now it is so mature that I can play big games like FIFA 2006-2009, Need For Speed ProStreet, Need For Speed Undercover, Hitman Blood Money and so many easily. It already has Shader Model 1, Shader Model 2, Shader Model 3 support. What is I am going to say is that all of the bits of 3D it has are only and fully supported on nVidia based graphics card due to their superior Linux driver. But nVidia is not alone in the graphics card building field. There are other manufacturer around them. Majority of the C.P.U comes up with the INTEL integrated graphics card. We all very well know that their Linux driver lack most of the modern 3D bits. But most of the user do not know about that. They just get frustrated with WINE. Some DirectX 7 games runs very well in nVidia graphics card but not in INTEL. Same thing is for some DirectX8, DirectX8.1. I do not know but I suspect that WINE's various Direct3D code utilizes OpenGL nVidia Extension or higher level OpenGL ARB Extension rather that lower one. That's why while INTEL OpenGL driver does support DirectX7, DirectX8 level 3D wine does not able to run many games on INTEL Linux graphics driver. While those many games run on nVidia Linux driver. I hope WINE will someday have better INTEL OpenGL support. Your sincerely, MD. IMAM HOSSAIN

4 3

SourceForge 2009 Community Choice Award
by André Hentschel 17 May '09

17 May '09

Last Year we got a funny award, lets nominate Wine for some serios things at http://sourceforge.net/community/cca09

1 0

Re: comdlg32: Optimize german Find and FindReplace Dialog(try2)
by James Mckenzie 16 May '09

16 May '09

Dawncrow: Your fix does not match what is displayed in W2K. What does this dialog look like in WindowsXP? James McKenzie -----Original Message----- >From: Dawncrow <webmaster(a)dawncrow.de> >Sent: May 15, 2009 11:14 AM >To: wine-patches <wine-patches(a)winehq.org> >Subject: comdlg32: Optimize german Find and FindReplace Dialog(try2) > >compare can be found here: >http://www.dritimage.de/uploads/bilder/124241122145_comdlg32winepatch.jpeg >--- > dlls/comdlg32/cdlg_De.rc | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > >

1 0

Detecting an invalid handle in setupapi
by Paul Vriens 16 May '09

16 May '09

Hi, I'm trying to install Microsoft's MMC (W2K3) and it crashes every now and then with different symptoms. I've tracked it down to what I think is a fault in the application that triggers a bug in Wine. All inf files that are read are closed with SetupCloseInfFile but the app is still trying to use the handle in a call to SetupFindFirstLineA. On Windows (tested on W2K3) this will lead to a failure of SetupFindFirstLineA with a last error of ERROR_INVALID_HANDLE. On Wine we don't check the handle and thus the outcome cannot be predicted (mostly crash). What ways do we have to detect invalid handles or better yet how can this be solved? -- Cheers, Paul.

2 1

Error in a shader compilation
by Doffle Alain 16 May '09

16 May '09

Hi, I'm trying to get rid of an error I observe in a wine trace (cf. attachement). fixme:d3d_shader:print_glsl_info_log Error received from GLSL shader #32: "0(37) : error C1068: array index out of bounds\n" In my understanding, it comes from an incompatibility between the two lines : trace:d3d_shader:shader_vaddline GL HW (2, 13) : uniform vec4 VC[253]; and trace:d3d_shader:shader_vaddline GL HW (37, 1057) : gl_Position.zw = (VC[254].xy); Can you please give me some help/hint/advice about the correct way to solve this problem please ?

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel