- wine-devel - winehq.org

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin 21 Apr '09

21 Apr '09

>>>>>Ohhh... got a nice crash after a re-boot. >>>> >>>> Never mind that. This looks more promising. At least, to me it does. The actctx error I get all the time, but I've never seen the other, and it happend right as the system froze up. >>>> >>>> fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Success >>> >>> Interesting. You are running Ubuntu studio 8.10 without pulseaudio, right? >>> >>> Have you updated the system between version runs (that may have >>> reintroduced pulseaudio, for example)? >>> >>> Are you running any other sound applications (or the sound that is >>> played after boot on Ubuntu)? >>> >>> Could you perform a git bisect to identify the guilty change? >> >>Doing some investigation, I have found >>(http://alsa.opensrc.org/index.php/HowTo_Asynchronous_Playback): >>""" >>That is basically all there is to the callback. Note however, that >>this example does not include error checking, which is a good idea of >>course. Occasionally, you may have to restore from a buffer under-run, >>in case the computer was caught up in some other process and didn't >>get to calling your callback. Whenever this happens, the first >>operation you perform on the device, in this case >>snd_pcm_avail_update, will return -EPIPE (a 'Broken Pipe' error). You >>can restore from this by calling the snd_pcm_prepare function again. >>""" >> >>This may be what you are experiencing here. I'd need to look into this >>further, but to be honest, I'm a little out of depth with the Windows >>and Wine sound interfaces. >> >>- Reece > >Reece: >I purged pulseaudio and checked that it had not been re-installed. I run Ubuntu 9.04 with all updates. I also use a test version of alsa-driver since my sound card is difficult to recognize but so far have had only great results -- no impact on wine at all. >The problem I am experiencing manifests itself in the program freezing... could be the sound, could also be the buttons doing something odd. One button's on-off toggle switches suddenly with no input on my part. >Regression test is below. >Susan > >b958dfdc4769515c0ef56c401430dd3e3980aabf is first bad commit >commit b958dfdc4769515c0ef56c401430dd3e3980aabf >Author: Huw Davies <huw(a)codeweavers.com> >Date: Thu Apr 16 11:51:45 2009 +0100 > > ole32: Change helper function to return the matching entry. > >:040000 040000 2964979dee4f353e1d565f7c20d8fdcc534f006d 8744cfee2e33db4799f58f102825103f565e18b9 M dlls I filed bug #18133, which has more detail and a screenshot. Susan

1 0

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.
by Paul Vriens 21 Apr '09

21 Apr '09

Huw Davies wrote: > --- > dlls/user32/tests/clipboard.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > > ------------------------------------------------------------------------ > > Was just about to sent a patch along those lines. Isn't it better to mark that win9x (and winME as well btw) one as broken()? -- Cheers, Paul.

2 4

Re: Article on wine development strategy
by Susan Cragin 21 Apr '09

21 Apr '09

I would like to put in my two cents for making Dragon NaturallySpeaking 10 work at about "50%." DNS 10 is a terrible program in a lot of ways. It's interface is over-engineered, clumsy, unintuitive, and packed with features that the average user never even looks at. People who don't know DNS say, "I'd love to dictate into word, format by voice command, etc." People who know DNS well, say "just give me accuracy and speed, and forget everything else." Those people usually tend to be the natural DNS constituency: either disabled or want to churn out a tremendous amount of text without typing. I think my point here is that happiness depends not only on % but on the type of program. Not all programs are created equal. Not all features are a good idea. Susan Cragin

8 9

Maybe already known stuff, but.....
by Massimo Del Fedele 21 Apr '09

21 Apr '09

Today I found this : #include "execinfo.h" void BT(void) { void *array[50]; size_t size; char **strings; size_t i; size = backtrace (array, 50); strings = backtrace_symbols (array, size); printf ("Obtained %zd stack frames.\n", size); for (i = 0; i < size; i++) printf ("%s\n", strings[i]); free (strings); } That allow to dump a backtrace (here max 50 frames) from inside a running program. Quite useful if app is non debuggable and don't run with +relay on because of copy protection. Ciao Max

2 2

NetBSD compile error
by Austin English 21 Apr '09

21 Apr '09

I just installed NetBSD 5.0RC4 on a spare hard drive, and tried compiling Wine. I hadn't seen this error before, but I'm not sure if the regression is on NetBSD or Wine's end. Google doesn't show too much for this error, other than that apparently NetBSD's libexec requires execname to not be NULL: case 2: /* ORIGIN */ if (execname == NULL) xerr(1, "execname not specified in AUX vector"); if ((ep = strrchr(p = execname, '/')) == NULL) xerr(1, "bad execname `%s' in AUX vector", execname); break; http://ftp.lahtermaher.org/pub/os/netbsd/cvs/src/libexec/ld.elf_so/expand.c… austin987$ make LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -D_ADVAPI32_ -foversion.res version.rc execname not specified in AUX vector: No such file or directory *** Error code 1 Can anyone shed some light on this error? -- -Austin

1 0

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin 21 Apr '09

21 Apr '09

>2009/4/20 Reece Dunn <msclrhd(a)googlemail.com>: >> 2009/4/20 Susan Cragin <susancragin(a)earthlink.net>: >>>>Ohhh... got a nice crash after a re-boot. >>> >>> Never mind that. This looks more promising. At least, to me it does. The actctx error I get all the time, but I've never seen the other, and it happend right as the system froze up. >>> >>> fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe >>> err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Success >> >> Interesting. You are running Ubuntu studio 8.10 without pulseaudio, right? >> >> Have you updated the system between version runs (that may have >> reintroduced pulseaudio, for example)? >> >> Are you running any other sound applications (or the sound that is >> played after boot on Ubuntu)? >> >> Could you perform a git bisect to identify the guilty change? > >Doing some investigation, I have found >(http://alsa.opensrc.org/index.php/HowTo_Asynchronous_Playback): >""" >That is basically all there is to the callback. Note however, that >this example does not include error checking, which is a good idea of >course. Occasionally, you may have to restore from a buffer under-run, >in case the computer was caught up in some other process and didn't >get to calling your callback. Whenever this happens, the first >operation you perform on the device, in this case >snd_pcm_avail_update, will return -EPIPE (a 'Broken Pipe' error). You >can restore from this by calling the snd_pcm_prepare function again. >""" > >This may be what you are experiencing here. I'd need to look into this >further, but to be honest, I'm a little out of depth with the Windows >and Wine sound interfaces. > >- Reece Reece: I purged pulseaudio and checked that it had not been re-installed. I run Ubuntu 9.04 with all updates. I also use a test version of alsa-driver since my sound card is difficult to recognize but so far have had only great results -- no impact on wine at all. The problem I am experiencing manifests itself in the program freezing... could be the sound, could also be the buttons doing something odd. One button's on-off toggle switches suddenly with no input on my part. Regression test is below. Susan b958dfdc4769515c0ef56c401430dd3e3980aabf is first bad commit commit b958dfdc4769515c0ef56c401430dd3e3980aabf Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Apr 16 11:51:45 2009 +0100 ole32: Change helper function to return the matching entry. :040000 040000 2964979dee4f353e1d565f7c20d8fdcc534f006d 8744cfee2e33db4799f58f102825103f565e18b9 M dlls

1 0

Re: dsound: Allow a special cbSize case in CreateSoundBuffer
by Maarten Lankhorst 20 Apr '09

20 Apr '09

Hey Jesse, Jesse Allen schreef: > OK now do you have comments? I have test cases. > > On Sun, Apr 19, 2009 at 6:30 PM, Jesse Allen <the3dfxdude(a)gmail.com> wrote: > >> In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for >> the cbSize and we have to allow it, but only when the SubFormat is >> KSDATAFORMAT_SUBTYPE_PCM. >> >> Includes test cases which were verified on WinXP. >> Fixes bug #11716 >> If you want me to review a patch add me to cc please. The variable size_ok is unneeded here, you can rewrite that so that it will fall through if test fails. Apart from that it looks ok to me. Cheers, Maarten.

1 0

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin 20 Apr '09

20 Apr '09

>Ohhh... got a nice crash after a re-boot. Never mind that. This looks more promising. At least, to me it does. The actctx error I get all the time, but I've never seen the other, and it happend right as the system froze up. fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Broken pipe err:wave:wodPlayer_WriteMaxFrags Error in writing wavehdr. Reason: Success

2 2

Janitor: list.h functions defined but not used
by Glenn L. McGrath 20 Apr '09

20 Apr '09

Hi all, im new to the list, im interested in grinding away at some of the warnings wine generates... make depend was complaining about some static inline functions that it thinks arent used, this patch uses __attribute__ ((used)) to disable the warning. Glenn

7 7

Re: (Try2) wininet/tests: Fix HttpSendRequestW test on Win2k platform.
by Hans Leidekker 20 Apr '09

20 Apr '09

On Monday 20 April 2009 20:14:14 Nicolas Le Cam wrote: > Win2k SP4 seems to be the only platform that follows what msdn says (see > http://msdn.microsoft.com/en-us/library/aa384247(VS.85).aspx). wininet is bundled with Internet Explorer, so it's more useful to look at the Explorer version than the Windows version. > Perhaps passing header's length to HttpSendRequest instead of adding a > broken expected value would be better. Let me know. No, the length parameter is the essence of this test. I wrote it because I saw IE7 call HttpSendRequestW like this which contradicts MSDN. The test shows that MSDN is outdated; on recent wininet HttpSendRequestW will calculate the header length for you. -Hans

2 1

Re: Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin 20 Apr '09

20 Apr '09

>Dragon NaturallySpeaking freezes up today during training, without crashing. >I will do a regression test if needed, but suspect that the freeze may be already known and/or affect many programs. >Susan Ohhh... got a nice crash after a re-boot. fixme:gdiplus:GdipCreateHBITMAPFromBitmap stub fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" (8.0.50608.0) err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ole:CoRevokeClassObject called from wrong apartment, should be called from 80000002c err:ntdll:RtlpWaitForCriticalSection section 0x7bc9c624 "loader.c: loader_section" wait timed out in thread 0040, blocked by 0042, retrying (60 sec) susan@ubuntu:~/.wine/drive_c/Program Files/Nuance/NaturallySpeaking10/Program$

1 0

Possible regression today's git wine-1.1.19-153-g55ad3fd
by Susan Cragin 20 Apr '09

20 Apr '09

Dragon NaturallySpeaking freezes up today during training, without crashing. I will do a regression test if needed, but suspect that the freeze may be already known and/or affect many programs. The terminal output was singularly unhelpful. After deleting all the lines that I see every time often enough to have memorized them, I come up with the following, but none of it happened at the point of crash. Susan err:ole:local_server_thread ConnectNamedPipe failed with error 231 fixme:wininet:set_cookie Unknown additional option L"expires = Thu, 01-Jan-2099 00:00:00 GMT" fixme:winstation:GetUserObjectInformationW not supported index 4 err:ntdll:NtQueryInformationToken Unhandled Token Information class 12! fixme:mstask:MSTASK_ITaskScheduler_Enum 0x15bd40, 0x32f088: stub fixme:mstask:MSTASK_ITask_GetExitCode (0x155c18, 0x32f124): stub fixme:mstask:MSTASK_ITaskScheduler_Enum 0x15bd40, 0x32f088: stub fixme:mstask:MSTASK_ITask_GetExitCode (0x155c18, 0x32f124): stub fixme:mstask:MSTASK_ITaskScheduler_Enum 0x15bd40, 0x32f088: stub fixme:mstask:MSTASK_ITask_GetExitCode (0x155c18, 0x32f124): stub fixme:gdiplus:GdipSetLinePresetBlend not implemented fixme:keyboard:UnregisterHotKey (0x1008c,1): stub fixme:keyboard:RegisterHotKey (0x1008c,1,0x00000000,106): stub

1 0

Re: [3/3] msi: Add tests for importing a _SummaryInformation table. (resend)
by Alexandre Julliard 20 Apr '09

20 Apr '09

Hans Leidekker <hans(a)codeweavers.com> writes: > diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c > index b2c7d06..41510c4 100644 > --- a/dlls/msi/tests/db.c > +++ b/dlls/msi/tests/db.c This fails here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c && touch db.ok db.c:1679: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1682: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1683: Test failed: Expected 14, got 0 db.c:1686: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1687: Test failed: Expected VT_I2, got 3341460 db.c:1688: Test failed: Expected 1252, got 1617263564 db.c:1692: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1693: Test failed: Expected VT_LPSTR, got 3341460 db.c:1694: Test failed: Expected 18, got 50 db.c:1695: Test failed: Expected "Installer Database", got db.c:1700: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1701: Test failed: Expected VT_LPSTR, got 3341460 db.c:1702: Test failed: Expected "Installer description", got db.c:1707: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1708: Test failed: Expected VT_LPSTR, got 3341460 db.c:1709: Test failed: Expected "WineHQ", got db.c:1714: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1715: Test failed: Expected VT_LPSTR, got 3341460 db.c:1716: Test failed: Expected "Installer", got db.c:1721: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1722: Test failed: Expected VT_LPSTR, got 3341460 db.c:1723: Test failed: Expected "Installer comments", got db.c:1728: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1729: Test failed: Expected VT_LPSTR, got 3341460 db.c:1730: Test failed: Expected "Intel;1033", got db.c:1735: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1736: Test failed: Expected VT_LPSTR, got 3341460 db.c:1737: Test failed: Expected "{12345678-1234-1234-1234-123456789012}", got db.c:1741: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1742: Test failed: Expected VT_FILETIME, got 3341460 db.c:1745: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1746: Test failed: Expected VT_FILETIME, got 3341460 db.c:1749: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1750: Test failed: Expected VT_I4, got 3341460 db.c:1751: Test failed: Expected 200, got 1617263564 db.c:1754: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1755: Test failed: Expected VT_I4, got 3341460 db.c:1756: Test failed: Expected 2, got 1617263564 db.c:1759: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1760: Test failed: Expected VT_I4, got 3341460 db.c:1761: Test failed: Expected 2, got 1617263564 db.c:1765: Test failed: Expected ERROR_SUCCESS, got 6 db.c:1766: Test failed: Expected VT_LPSTR, got 3341460 db.c:1767: Test failed: Expected "Vim", got make[2]: *** [db.ok] Error 44 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: add missing RtlReAllocateHeap valgrind hook, add tests
by Alexandre Julliard 20 Apr '09

20 Apr '09

Dan Kegel <dank(a)kegel.com> writes: > More related to http://bugs.winehq.org/show_bug.cgi?id=18067 > This adds the missing valgrind hook, and adds tests that > show up the old problem if run under valgrind. The tests should go with the other existing heap tests in kernel32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: add a couple testcases for GetNamedSecurityInfo (try 3)
by Paul Vriens 20 Apr '09

20 Apr '09

Austin English wrote: > Added win_skip for NT4, where it would crash (thanks Paul!). > > > > ------------------------------------------------------------------------ > > Discussed this one briefly with Austin. Still need a little bit of love. -- Cheers, Paul.

1 0

Abiword unit / regression testing under Wine?
by Dan Kegel 20 Apr '09

20 Apr '09

It looks like you can build Abiword for Windows on Linux: http://abiword.com/mailinglists/abiword-dev/2008/Jan/0021.html Has anybody tried running the Abiword unit or regression tests on Wine? http://www.abisource.com/wiki/Unit_Test http://svn.abisource.com/abiword-testsuite/trunk/README - Dan

3 4

Re: sxs: Implement a stub CreateAssemblyCache to make Publish or Perish install.
by Kai Blin 20 Apr '09

20 Apr '09

On Sunday 19 April 2009 23:55:14 Kai Blin wrote: > As mentioned by the authors of Publish or Perish in their FAQ > (http://www.harzing.com/pop_faq.htm#Q309), Wine exporting sxs.dll and not > providing a real CreateAssemblyCache function trips up the installer. > This patch allows Publish or Perish to install without issues. > > Thanks to Donnie Berkholz for pointing me at this issue. > --- > dlls/sxs/sxs.c | 10 ++++++++++ > dlls/sxs/sxs.spec | 2 +- > 2 files changed, 11 insertions(+), 1 deletions(-) Of course the moment I sent this, I found the real implementation in fusion.dll. Sending a forward, feel free to ignore this patch. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 2

Re: [PATCH 1/2] Handle refcount of lights when interacting with viewport.
by Henri Verbeet 19 Apr '09

19 Apr '09

2009/4/19 Christian Costa <titan.costa(a)wanadoo.fr>: > @@ -760,6 +760,8 @@ IDirect3DViewportImpl_AddLight(IDirect3DViewport3 *iface, > lpDirect3DLightImpl->activate(lpDirect3DLightImpl); > } > > + IDirect3DLight_AddRef(lpDirect3DLight); > + > LeaveCriticalSection(&ddraw_cs); > return D3D_OK; > } > @@ -798,6 +800,7 @@ IDirect3DViewportImpl_DeleteLight(IDirect3DViewport3 *iface, > cur_light->active_viewport = NULL; > This->num_lights--; > This->map_lights &= ~(1<<lpDirect3DLightImpl->dwLightIndex); > + IDirect3DLight_Release(lpDirect3DLight); > LeaveCriticalSection(&ddraw_cs); > return D3D_OK; > } The patch looks ok in principle, but I think it's nicer to keep these close to the code that actually manipulates the list.

1 0

Re: wined3d: Fix prototype for EnumAdapterModes
by Stefan Dösinger 19 Apr '09

19 Apr '09

Am Freitag, 17. April 2009 03:10:26 schrieb Brad Martin: > --- > include/wine/wined3d.idl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl > index b8691a7..6f86688 100644 > --- a/include/wine/wined3d.idl > +++ b/include/wine/wined3d.idl > @@ -2222,8 +2222,8 @@ interface IWineD3D : IWineD3DBase > ); > HRESULT EnumAdapterModes( > [in] UINT adapter_idx, > - [in] UINT mode_idx, > [in] WINED3DFORMAT format, > + [in] UINT mode_idx, > [out] WINED3DDISPLAYMODE *mode > ); > HRESULT GetAdapterDisplayMode( Are you sure you can do this without adjusting the implementation function in dlls/wined3d/directx.c and the callers in d3d9, d3d8 and ddraw? I don't have the code checked out currently, so I can't check. Maybe the calls and the implementation match and just the .idl prototype is different.

2 1

Re: gdi32: fetch child fonts by real parent font name
by Lei Zhang 19 Apr '09

19 Apr '09

On Tue, Apr 14, 2009 at 7:11 AM, Paul TBBle Hampson <Paul.Hampson(a)pobox.com> wrote: > This patch fixes bug 18044. > > Basically, the built-in FontLink functionality for subsituting > alternative fonts where a certain font is missing glyphs (used > by default for Tahoma and Microsoft Sans Serif under Windows) doesn't > work if the font is loaded via a FontSubstitution entry. > > The only place this is really likely to happen turns out to be using > MS Shell Dlg as a font name, which is generally discouraged for general > UI use (as far as I can tell, you're supposed to use a lookup function > which normally returns Tahoma or Microsoft Sans Serif directly) but > this happens to be the case for uTorrent 1.8 onwards. > -- > Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com This looks a lot like http://www.winehq.org/pipermail/wine-patches/2008-December/065543.html.

2 1

XI2 DirectInput mouse implementation RFC
by Paul TBBle Hampson 19 Apr '09

19 Apr '09

I've thrown together a rather-rough-but-working-in-a-limited-sense implementation of XInput2-based DirectInput. It's got a fair few problems, I'm mainly interested in feedback on the approach, although obviously any code or style criticisms are welcome. Current limitations: * Doesn't check for XInput2.h, so won't build without it. * Doesn't send mouse-ups. XI2 bug. * Doesn't send events after mouse-down until after mouse-up on a window. I'm pretty sure this is an XI2 bug, but it might be a design feature. * Doesn't support exclusive mode. XI2 bug (grabs not yet implemented) * Mouse buttons aren't remapped nicely downwards. Need to look harder at this, my mouse reports buttons 1, 2, 3, 4, 5, 8 and 9 under X. 4 and 5 are scroll, 6 and 7 might be horizontal scroll in which case if this is always the case we can just remap downwards. * Only supports the Mouse. Adding keyboard support should be really trivial compared to actually getting the framework right. If this format is fine, then the first patch is basically ready to go, the latter two patches may need to be re-split or merged more sensibly. I've also attached a couple of fixes for the XI2 stuff if anyone wants to try it. One only affects 64-bit builds, and one fixes XCB locking assertions which you could probably otherwise ignore. So they're both kinda option in the Wine context. And one more patch, against the xinput utility from whot's git tree, to fix a compile failure. 0001-Unlock-display-after-XIQueryVersion.patch > libXi 0001-Clear-definitions-of-X-types-defined-to-wire-types.patch > x11proto-input 0001-Ensure-we-have-a-definition-of-BYTE.patch > xinput -- Paul "TBBle" Hampson, Paul.Hampson(a)Pobox.com Shorter .sig for a more eco-friendly paperless office.

1 0

Re: [PATCH 2/4] gdi32: fetch child fonts by real parent font name
by James McKenzie 19 Apr '09

19 Apr '09

Paul TBBle Hampson wrote: > This patch fixes bug 18044. > > Basically, the built-in FontLink functionality for subsituting > alternative fonts where a certain font is missing glyphs (used > by default for Tahoma and Microsoft Sans Serif under Windows) doesn't > work if the font is loaded via a FontSubstitution entry. > > The only place this is really likely to happen turns out to be using > MS Shell Dlg as a font name, which is generally discouraged for general > UI use (as far as I can tell, you're supposed to use a lookup function > which normally returns Tahoma or Microsoft Sans Serif directly) but > this happens to be the case for uTorrent 1.8 onwards. > > Paul: Where is the patch? I could not find it. James McKenzie

2 1

Icons, logos, Tango, consistency, the user experience, and our project looks like a 2D champaign flute
by Scott Ritchie 18 Apr '09

18 Apr '09

A user submitted a bug report to launchpad complaining that the Wine icon is not Tango compliant: https://bugs.launchpad.net/ubuntu/+source/wine/+bug/358645 So, what is Tango Compliance? Well, the Tango icons all use a set of design standards, and you can find them here: http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines In short, it means the Wine icon looks very out of place when it is placed alongside all the other Tango-compliant icons on the system. If you click the Applications button on an Ubuntu system, for instance, you'll see 7 three dimensional, front perspective, on the table, lit from above, well-bordered and highlighted icons. At the bottom you see a two dimensional, heavily tilted underneath perspective, hovering in midair, lit from the lower right, thick-bordered Wine icon. In short, it's ugly, but our real goal here is usability. Making Wine blend in is part of that, however it's also important we deliver a consistent experience: as ugly as it is, I thought, that icon is our project's logo, so we should use the same image throughout. But then, I realized, we don't use the same logo consistently! If you go to winehq.org you'll see another logo, which fits in with the website theme very well but is nevertheless quite different from the Tango icons. From a user's perspective, changing the Wine icon on the system can present a very slight familiarity issue: you're jarred for a second while you realize that the old Wine icon is gone and the new icon (helpfully next to the familiar words Wine) is actually the same program. This is the main place where the user sees the Wine icon, as we don't yet display it on other areas where they may be interacting with Wine (eg, by placing a small Wine icon next to the program icon as in http://brainstorm.ubuntu.com/ideatorrent/idea/2141). Accordingly, a change here will be narrow, and if we make it now (before the icon needs to be used elsewhere) there is a minimal amount of familiarity loss. A new icon makes a program feel new, so the user will expect some change. Accordingly, I'd like to propose updating our icons when we move forward with the 1.2 release. This will coincide with the inclusion of several of the Wine integration projects I'll be including in the coming months, such that the user will see it all (with a new, consistant icon) in one big package in the October wave of distro releases like Ubuntu 9.10. So, what should that new icon be? Well, tango compliance is one major goal, as is recognizability as a Wine glass. Fortunately, someone has already made a Tango-compliant Wine logo here: http://lists.freedesktop.org/archives/tango-artists/attachments/20060331/63… Now, if you're like me, the second you saw that you went "Whoa, that doesn't look like the Wine icon! It looks completely different!" The glass on the website, for instance, is much more narrow: http://winehq.org/images/winehq_logo_glass_sm.png Now, I'm not a drinker, but I do know that real wine people can be very, very picky about these kind of things. After giving the wikipedia article (http://en.wikipedia.org/wiki/Wine_glass) and a few other websites a full read, I can categorically state one thing: we're using the wrong glass for red wine. Now, whether the icon we use should be the right kind of glass or not is an aesthetic choice. Personally I'd use a red wine glass but one with a slightly narrower bowl than in the tango icon above (a "Bordeaux" glass rather than a "Burgundy" glass) http://www.the-gift-of-wine.com/Images/glass_bordeaux.jpg http://www.the-gift-of-wine.com/Images/glass_burgundy.jpg Anyway, I suspect most of you really really won't care, as long as it looks something like a wine glass and has the words Wine next to it. But I did want to start a discussion, especially because this represents our projects logo and is, to a real extent, more than just an icon. Meanwhile, I'll try drumming up some artists to see if I can get a few different Tango-compliant icons for us to chose from. Thanks, Scott Ritchie

10 16

Article on wine development strategy
by Dan Kegel 18 Apr '09

18 Apr '09

http://yokozar.org/blog/archives/48 is a fun little look at using simulation to see how various strategies might affect Wine development. The one that worked out best was to pick some random user who's almost happy, fix the last few bugs that are keeping his apps from working, and then once he's happy, move on to the next such user. - Dan

6 9

re: Icons, logos, Tango, consistency, the user experience, and our project looks like a 2D champaign flute
by Dan Kegel 17 Apr '09

17 Apr '09

The Ubuntu Studio logos look fine. I'd be happy with adopting them if they really make Wine fit in better with modern desktops. No need to wait for 1.2, just check 'em in now, 1.2 will be along soon enough.

9 13

Re: advapi32: add testcases for GetNamedSecurityInfo (try 2)
by Paul Vriens 17 Apr '09

17 Apr '09

Austin English wrote: > Changelog: Fixed Paul's concerns. > > > > ------------------------------------------------------------------------ > > Implementation piece is not needed as GetNamedSecurityInfoW already takes care of those parameters. The second test crashes on NT4. Instead of surrounding that with an if(0) I suggest to surround it with an if(pCreateWellKnownSid). That function is available as of W2K so we skip on NT4 (and we already skip on Win9x). I also suggest to add a win_skip() if you decide to take that route. -- Cheers, Paul.

2 1

Re: [2/2] ntdll: Implement NtQueryInformationToken(TokenDefaultDacl).
by Detlef Riekenberg 17 Apr '09

17 Apr '09

On Fr, 2009-04-17 at 12:53 +0200, Hans Leidekker wrote: > + Dacl = HeapAlloc(GetProcessHeap(), 0, Size); > + ret = GetTokenInformation(Token, TokenDefaultDacl, Dacl, Size, > &Size); > + ok(ret, "GetTokenInformation(TokenDefaultDacl) failed with error > %u\n", GetLastError()); > + > CloseHandle(Token); Please cleanup properly: HeapFree(GetProcessHeap(), 0, Dacl); -- By by ... Detlef

1 0

Re: oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL
by Paul Vriens 17 Apr '09

17 Apr '09

Detlef Riekenberg wrote: > http://test.winehq.org/data/f212579ae9a1b770ebd34cec20f95e1977bb57f0/xp_dr-… > > While reading the code for a test failure on all of my Windows > installations, > the current code was already strange: > > 5436 ok(hres == VARCMP_EQ || > 5437 broken(hres == VARCMP_GT), "Expected VARCMP_EQ, got %08x\n", > hres); > > I feel bad for adding a "broken(hres == VARCMP_LT)". > > Extending vartest and inserting a trace made the localization error > obvisious: > VARCMP_LT was returned when comparing "12Falsch" and "12False". > > The failure for the similar test (VT_BOOL with True: "12Wahr" > > "12True") > was hidden by the wrong "broken(hres == VARCMP_GT)". > > We have also another XP Machine that produced this failure. > (xp-home-SP2-czech) > > > > > ------------------------------------------------------------------------ > > Hi Detlef, The lstrcpyW and lstrcatW additions to init() in the tests don't work on Win95. I guess that's where the new failures come from: http://test.winehq.org/data/ed74088d7ddf0c389e7596237add7cb751b17a0a/95_W95… Could you have a look? -- Cheers, Paul.

2 3

Re: try5 [4/4] kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr
by Austin English 17 Apr '09

17 Apr '09

n Thu, Apr 16, 2009 at 10:00 PM, Guy Albertelli <galberte(a)neo.rr.com> wrote: > mountmgr.sys uses a specific format for "unique volume name". Make > GetVolumeNameForVolumeMountPointW match that format for the returned > unique volume name. > > Changelog > - Make GetVolumeNameForVolumeMountPointW match mountmgr.sys for format of "unique volume name" > --- > dlls/kernel32/tests/volume.c | 2 -- > dlls/kernel32/volume.c | 12 +++++++++--- > 2 files changed, 9 insertions(+), 5 deletions(-) > > > > > Series worked fine this time :-). Thanks for helping Wine! -- -Austin

1 0

Fwd: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi
by Austin English 17 Apr '09

17 Apr '09

There's been a lot of this spam recently (below). Can you take a look Jeremy? Perhaps banning that IP range if it's in the same block? Thanks! -- -Austin ---------- Forwarded message ---------- From: llhhhh0 <wineforum-user(a)winehq.org> Date: Wed, Apr 15, 2009 at 3:51 AM Subject: [Wine] The easiest way to convert Mod/Tod video from JVC and any vi To: wine-users(a)winehq.org question: 1: What is .Mod and .Tod video? 2: How to convert .Mod and .Tod video to AVI, MPG, WMV, MPEG? 3. How to convert any video to the format you want? Answer: 1 .MOD and .TOD is the video format generated by most popular digital camcorders such as Panasonic SV AV100, Canon MOD Camcorders, JVC (MOD and TOD) and Panasonic (MOD only). It is not the common format, so it can not be accepted by popular portable players.

4 4

Re: ntdll: add missing valgrind hook in RtlAllocateHeap
by Rob Shearman 16 Apr '09

16 Apr '09

2009/4/15 Dan Kegel <dank(a)kegel.com>: > Two chromium unit tests reported phony errors > when run on wine on valgrind because > RtlAllocateHeap sometimes returned an > allocation without notifying valgrind about it. RtlReAllocateHeap is also missing valgrind notifications for the large block paths. It also appears that the function leaks memory in the realloc small -> large path. -- Rob Shearman

1 0

Winprinfo tool
by Saulius Krasuckas 16 Apr '09

16 Apr '09

I just have struck one tool related to Windows printer drivers [*]: | In the process of developing a Windows printer driver, we created this | winprinfo tool to allow us to query the printer system from the point of | view of an application: there are several APIs that permit a wide range | of query. This tool exercises them all and proved to be indispensible in | our development. ... | Once a printer has been opened, there are several Win32 API calls that | can be used to query the device. These are DeviceCapabilities(), | GetDeviceCaps, and EnumForms() (there may be more, but we'll add them as | we discover them. | | Driver Info / GetPrinterDriver() | By fetching a DRIVER_INFO_4 object for this printer, we're able to | show the version (kernel or user), as well as the paths used for all the | support files (driver and UI DLLs, plus the dependent files). | | DEVMODE / DeviceCapabilities() | A central data structure involved in printing is the DEVMODE, which | is a collection of settings that apply to a printjob. Each printer has a | group of default settings that are used in the absense of any user input | on the subject, and they are managed with the printer's setup GUI. | Using the DeviceCapabilities() API function, we are able to extract | a number of individual parameters from the DEVMODE and report them. | | GetDeviceCaps() | Since a printer is a "graphics device", there are some kinds of | parameters that are in common with other devices such as video displays. | The GetDeviceCaps() call returns a small set of numeric parameters, many | of which have no real interest to printer developers. | | EnumForms() | The NT print spooler supports the notion of "forms", which is simply | a way of attaching a name to a specifically-sized piece of output media. | There are built-in sizes such as Letter and Legal, but there are at | least a hundreds defined for oddball paper sizes all over the world. A | print driver can define additional forms as well, though the interaction | between the central forms database and the driver is still a little | unclear. My guess, it could usefull for guys like Detlef working on Winspool and Co. also. Then it can query printers over SMB. One more (probably) interesting note (with regard to running the tool on Wine): | We built this to run strictly on NT/Win2000/XP platforms: if it works at | all on Win95/98/ME, we'd be very surprised. [*] http://unixwiz.net/tools/winprinfo.html

2 1

Suppressing the screen saver in a full screen game
by Scott Ritchie 16 Apr '09

16 Apr '09

Ubuntu 9.04's new notification system is really nice and non obtrusive, however it can still get in the way if you need the entire screen. Accordingly, the notifications system has been designed to not draw notifications when a program such as a movie player is telling the operating system to suppress the screen saver. I propose we enable this functionality for Wine whenever we've switched to a full screen mode. I assume there's also a similar function for applications on Windows, so if we haven't done so already we should probably implement that and suppress the screen saver then as well. Thoughts? Thanks, Scott Ritchie

3 2

Re: advapi32: add testcases for GetNamedSecurityInfo
by Paul Vriens 16 Apr '09

16 Apr '09

Austin English wrote: > Testing for bug 18071. Passes under Wine/2k. > > > > ------------------------------------------------------------------------ > > We bail out on pObjectName being NULL: + if (!pObjectName || !ppSecurityDescriptor) return ERROR_INVALID_PARAMETER; + This means this if() right after that is not needed anymore: if( pObjectName ) { -- Cheers, Paul.

1 1

NTFS filesystem features -> WONTFIX?
by Austin English 16 Apr '09

16 Apr '09

See http://bugs.winehq.org/show_bug.cgi?id=17938 for background. Vitaliy closed this bug, saying it's an application bug that it depends on seeing NTFS file system type for certian program features. I don't think it should be a WONTFIX, as the only reason that change was introduced was to enable _another_ program to install successfully. Is there any reason we can't allow the reported file system to be changed? I'm sure there are other applications that test for it and change their behavior according to the file system type. A quick google search shows at least one application that does (http://boards2.sega.com/sega_board/viewtopic.php?p=2669064&sid=449f531c594a…). That install will likely now fail in Wine, because of this behavior. -- -Austin

16 29

Re: shell32: only fill used pointers
by Nikolay Sivov 16 Apr '09

16 Apr '09

André Hentschel wrote: > This is needed to bring up IE8. Otherwise there is a Backtrace: > =>0 0x7e80198d SHDefExtractIconW+0x7d(pszIconFile=0x32e310, iIndex=0, > uFlags=0, phiconLarge=(nil), phiconSmall=0x32e30c, nIconSize=1048592) > > --- > dlls/shell32/iconcache.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > I think you're leaking here: + if (phiconLarge) *phiconLarge = hIcons[0]; /* 'else' should DestroyIcon(hIcons[0]) */ + if (phiconSmall) *phiconSmall = hIcons[1]; /* 'else' should DestroyIcon(hIcons[1]) */ cause these handles won't come to caller. P.S. What about a test for that? I've tested the same patch some times ago with IE8 RC1 and it definitely goes further with it (on 1.1.19 git) but tests are required I think.

2 2

Re: dlls/shell32: Fixed Dutch translations
by Paul Vriens 16 Apr '09

16 Apr '09

Frans Kool wrote: > > ------------------------------------------------------------------------ > > You're mixing tabs and spaces. -- Cheers, Paul.

1 0

Re: try4 [2/3] kernel32: Fix GetVolumeInformation[AW] to require trailing \
by Austin English 16 Apr '09

16 Apr '09

On Tue, Apr 14, 2009 at 11:17 PM, Guy Albertelli <galberte(a)neo.rr.com> wrote: > MSDN and test verify the valid "root dirs" for GetVolumeInformation[AW] > must end in trailing '\' and if not then return ERROR_INVALID_NAME > > Changelog > - Return correct error if GetVolumeInformation[AW] "root dir" does not end with '\' > --- > dlls/kernel32/volume.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > Can you add a testcase for this? -- -Austin

2 2

Re: try4 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice
by Paul Vriens 16 Apr '09

16 Apr '09

Guy Albertelli wrote: > Fixed memory leak and changed skip to win_skip in this patch. > > Changelog: > - Enhance QueryDosDevice test for attempting to return all devices. > - Add tests for GetVolumeInformationA testing the different root dir formats. > --- > dlls/kernel32/tests/volume.c | 137 ++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 133 insertions(+), 4 deletions(-) > > > > ------------------------------------------------------------------------ > > One of the tests fails here: volume.c:290: Test failed: GetVolumeInformationA w/o '\' did not fail, last error 2 I just ran the tests as your second mail/patch suggested it fixed something. That patch however didn't contain a change to the tests. If you add tests that fail on Wine and you don't include a fixed implementation in the same patch you should mark these with todo_wine(). If you fix the implementation in a later patch you should remove the todo_wine() again if needed. Bottom line: after each patch all tests should still succeed. -- Cheers, Paul.

2 1

Re: [1/2] msi/tests: Test MsiRecordGetString on null and empty strings.
by James Hawkins 16 Apr '09

16 Apr '09

On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > While trying to solve ACTION_AppSearchDr problem revealed by my previous > patch, I discovered that MSI_RecordGetStringW was returning a buffer > length of 1 on null and empty strings. > > Here is the test, the fix follows. > > Tested on WinXP and Wine. > This patch has 39 lines of test code without a single empty line. Unit tests test one thing at a time and should be well documented and easy to read. -- James Hawkins

3 4

RFC: Resource editing and validation
by Reece Dunn 16 Apr '09

16 Apr '09

Hi, This is something I have been thinking about for a while and is triggered by a comment by Austin on the "How can we improve WINE" thread that is floating around. In short, this is aiming to discuss and seek a resolution to issues encountered when editing resource files -- in particular dialogs -- and how to resolve them. There is also the wider issue of improving the warnings produced by the resource compiler to cover usability errors, like specifying duplicate mnemonics (clashing mnemonics on a dialog), multiple mnemonics (a control having two or more mnemonics) and partial mnemonics (a control ending in an '&' character). = EDITING RESOURCES = There are various issues that need addressing here (feel free to add any more that you find): 1. editing resources - especially dialogs - is hard without some sort of graphical editor; 2. not everyone has access to graphical resource editors (e.g. Visual Studio), so it is harder for people to make dialog changes; 3. graphical resource editors tend to mess up resource files, moving things around at random (Visual Studio, I'm looking at you); 4. it is difficult to make a layout change and apply it across the various language blocks consistently; 5. resource translators would like to use a gettext-style of resource translation; 6. people editing resources don't usually follow Windows resource layout guidelines and usability guidelines. What I want to propose is to write a resource editor for Wine that follows best layout and usability guidelines, that makes it easier for people editing the resources to do so. I would like to have this handle various control sizes, borders and padding and make it simple and intuitive where Visual Studio is not. There are some questions around this on whether to have these resource representations checked into the git repository and auto-generate the RC files at build time (preferrable), or whether to keep the RC files and have the editor process them to/from the editor format. What I am thinking of at the moment is to use XUL to represent the resources and gettext po to handle the translation. The build-time tools would then handle the translation to keep the dialogs consistent. There should also be a mechanism to adjust a dialog on a specific language -- but if this is just relative size and positioning, that should be handled by the XUL+PO -> RC transformation tool. Initially, a XUL+PO <==> RC conversion utility can be written to transform between the two. A graphical editor can then be built on top of this as desired. = Layout Guidelines (Example set) = - Dialog boxes have a 7 DLU inner border. - Command buttons are 50x14 DLUs. - Any control without an explicit name (e.g. a text edit box or list view) must have a static text label that is immediately before it in tab order (for accessibility requirements). NOTE: There are various dialogs (e.g. on Winecfg) that use different spacing between controls. This gives an inconsistent look, and adds to the "Wine is ugly" effect. Thoughts? Suggestions? - Reece

3 2

Re: start: correct German translation
by Stefan Leichter 15 Apr '09

15 Apr '09

Am Tuesday 14 April 2009 19:43:13 schrieb Dawncrow: > --- > programs/start/De.rc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Please send patches with your real name. -- Stefan

1 0

Re: ntdll: Improve stubs for NtGet/SetInformationToken(TokenDefaultDacl).
by Rob Shearman 15 Apr '09

15 Apr '09

2009/4/15 Hans Leidekker <hans(a)codeweavers.com>: > @@ -441,6 +441,23 @@ NTSTATUS WINAPI NtQueryInformationToken( > } > SERVER_END_REQ; > break; > + case TokenDefaultDacl: > + if (tokeninfo) > + { > + TOKEN_DEFAULT_DACL *token = (TOKEN_DEFAULT_DACL *)tokeninfo; > + ACL *acl; > + > + FIXME("returning empty DACL\n"); > + > + acl = token->DefaultDacl = (ACL *)token + sizeof(TOKEN_DEFAULT_DACL); > + > + acl->AclRevision = ACL_REVISION; > + acl->Sbz1 = 0; > + acl->AclSize = sizeof(ACL); > + acl->AceCount = 0; > + acl->Sbz2 = 0; > + } > + break; > default: > { > ERR("Unhandled Token Information class %d!\n", tokeninfoclass); The server already tracks the default DACL of the token in the token object, so implementing these functions properly shouldn't be much more work than writing the code to marshall and unmarshall the ACL to and from the server, with two new trivial functions in the server for getting and setting the default_dacl field. -- Rob Shearman

1 0

Compile error in taskmgr before 1.1.14
by David Lee Lambert 15 Apr '09

15 Apr '09

I'm trying to use a git tree to do a regression-test for something that seems to have gotten broken somewhere between 1.0 and 1.1.19; but when I do a full "git reset _version_ ; git checkout -f ; ./configure CC='ccache gcc-3.4' ; make depend ; make" I get the following error before about 1.1.14: ccache gcc-3.4 -c -I. -I. -I../../include -I../../include -I../../include/msvcrt -DNO_LIBWINE_PORT -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -fno-builtin -o about.o about.c In file included from about.c:29: ../../include/msvcrt/memory.h:27: error: redefinition of 'memicmp' ../../include/msvcrt/string.h:132: error: previous definition of 'memicmp' was here ../../include/msvcrt/memory.h:28: error: redefinition of 'memccpy' ../../include/msvcrt/string.h:131: error: previous definition of 'memccpy' was here make[2]: *** [about.o] Error 1 make[2]: Leaving directory `/usr/src/wine-git/programs/taskmgr' make[1]: *** [taskmgr] Error 2 make[1]: Leaving directory `/usr/src/wine-git/programs' make: *** [programs] Error 2 Does anyone remember seeing this error, or is it likely to be the result of misusing git? Build system is Debian 4.0 with gcc 3.3, 3.4 and 4.1 available. -- David Lee Lambert ... Software Developer, member IEEE, ACM Cell phone: +1 586-873-8813 GPG key at http://www.lmert.com/keyring.txt IM: davidleelambert (Yahoo!) or lamber45(a)cse.msu.edu (MSN)

3 2

Re: gdi32: Don't add duplicate system_links entries
by Dmitry Timoshkov 15 Apr '09

15 Apr '09

"Paul TBBle Hampson" <Paul.Hampson(a)Pobox.com> wrote: > + /* Make sure we haven't already got an entry for this due to substitution */ > + duplicate = FALSE; > + LIST_FOR_EACH_ENTRY(system_font_link, &system_links, SYSTEM_LINKS, entry) > + { > + if(!strcmpW(system_font_link->font_name, font_link->font_name)) > + { > + duplicate = TRUE; > + break; > + } > + } Font name comparison should be case insensitive. If there are other places that do that they should be fixed. > + if(duplicate) > + { > + TRACE("\tDuplicate font_link entry, ignoring\n"); > + HeapFree(GetProcessHeap(), 0, font_link); > + continue; > + } A '\t' at the start of a trace message doesn't improve readability. -- Dmitry.

2 1

Re: msvcrt: Implement ___lc_codepage_func, ___lc_collate_cp_func and ___lc_handle_func.
by Dmitry Timoshkov 15 Apr '09

15 Apr '09

"Hans Leidekker" <hans(a)codeweavers.com> wrote: > +/********************************************************************* > + * ___lc_handle_func (MSVCRT.@) > + */ > +HANDLE * ___lc_handle_func(void) > +{ > + return MSVCRT___lc_handle; > +} > + > +/********************************************************************* > + * ___lc_codepage_func (MSVCRT.@) > + */ > +int ___lc_codepage_func(void) > +{ > + return MSVCRT___lc_codepage; > +} > + > +/********************************************************************* > + * ___lc_collate_cp_func (MSVCRT.@) > + */ > +int ___lc_collate_cp_func(void) > +{ > + return MSVCRT___lc_collate_cp; > +} All msvcrt public exports should have explicit CDECL calling convention. -- Dmitry.

1 0

Fixing the last remaining failure on W2K (rpcrt4:server)
by Paul Vriens 15 Apr '09

15 Apr '09

Hi, In an effort to fix that last failure on my box I found the culprit. I'm not comfortable enough with just excluding (yet another) that test just for the sake of having zero failures though. Any idea? -- Cheers, Paul. diff --git a/dlls/rpcrt4/tests/server.c b/dlls/rpcrt4/tests/server.c index 18cfa59..2d8c4d5 100644 --- a/dlls/rpcrt4/tests/server.c +++ b/dlls/rpcrt4/tests/server.c @@ -616,9 +616,13 @@ s_context_handle_test(void) ok(*(ULONG *)buf == 0, "attributes should have been set to 0 instead of 0x%x\n", *(ULONG *)buf); ok(!UuidIsNil((UUID *)&buf[4], &status), "uuid should not have been nil\n"); + /* Crashes on W2K */ + if (0) + { h = pNDRSContextUnmarshall2(binding, buf, NDR_LOCAL_DATA_REPRESENTATION, NULL, 0); ok(h != NULL, "NDRSContextUnmarshall2 returned NULL\n"); ok(h->userContext == (void *)0xdeadbeef, "userContext of interface didn't unmarshal properly: %p\n", h->userContext); + } /* raises ERROR_INVALID_HANDLE exception on Vista upwards */ if (0)

2 2

Re: [5/6] WineD3D: Support the full amount of constants in GLSL
by Henri Verbeet 15 Apr '09

15 Apr '09

2009/4/15 Stefan Dösinger <stefan(a)codeweavers.com>: > +void record_const_read(DWORD reg, unsigned int *array, int *num) { > + int r; > + BOOL inc = TRUE; > + for(r = 0; r < *num; r++) { > + if(array[r] == reg) { > + inc = FALSE; > + break; > + } > + } > + > + if(inc) { > + array[(*num)++] = reg; > + } > +} > + This should be static. Using a bitmap and counting the bits would be nicer, imo.

2 2

Re: [PATCH 1/2] comctl32/tests: Test expanding of a invisible sub tree.
by Florian Köberle 15 Apr '09

15 Apr '09

Nikolay Sivov wrote: > Florian Köberle wrote: >> --- >> dlls/comctl32/tests/treeview.c | 80 >> ++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 80 insertions(+), 0 deletions(-) >> >> diff --git a/dlls/comctl32/tests/treeview.c >> b/dlls/comctl32/tests/treeview.c >> index 5f310b5..7d9fcfa 100644 >> --- a/dlls/comctl32/tests/treeview.c >> +++ b/dlls/comctl32/tests/treeview.c >> @@ -748,6 +748,84 @@ static LRESULT CALLBACK MyWndProc(HWND hWnd, >> UINT msg, WPARAM wParam, LPARAM lPa >> return 0L; >> } >> >> +static void TestExpandInvisible(void) >> +{ >> + static CHAR nodeRText[] = "R", >> + nodeIText[] = "I", >> + nodeIIText[] = "II", >> + node1Text[] = "1", >> + node2Text[] = "2"; >> > Why not using array here? The code builds up a tree like this: R |- I | |- 1 | |- 2 |- II So the different types of enumeration are used to give a hint of the level of the node. If I use arrays the tree would look like this: 0 |- 1 | |- 2 | |- 3 |- 4 If this version of the tree is really wanted I can change it of course to use arrays. Do you still prefer arrays after reading my explanation?

1 0

Re: [PATCH 1/2] comctl32/tests: Test expanding of a invisible sub tree.
by Nicolas Le Cam 15 Apr '09

15 Apr '09

2009/4/15 Florian Köberle <florian(a)fkoeberle.de>: > --- > dlls/comctl32/tests/treeview.c | 80 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 80 insertions(+), 0 deletions(-) > > diff --git a/dlls/comctl32/tests/treeview.c b/dlls/comctl32/tests/treeview.c > index 5f310b5..7d9fcfa 100644 > --- a/dlls/comctl32/tests/treeview.c > +++ b/dlls/comctl32/tests/treeview.c > @@ -748,6 +748,84 @@ static LRESULT CALLBACK MyWndProc(HWND hWnd, UINT msg, WPARAM wParam, LPARAM lPa > return 0L; > } > > +static void TestExpandInvisible(void) > +{ > + static CHAR nodeRText[] = "R", > + nodeIText[] = "I", > + nodeIIText[] = "II", > + node1Text[] = "1", > + node2Text[] = "2"; > + TVINSERTSTRUCTA ins; > + HTREEITEM nodeR; > + HTREEITEM nodeI; > + HTREEITEM nodeII; > + HTREEITEM node1; > + HTREEITEM node2; > + RECT dummyRect; > + BOOL nodeIVisible; > + BOOL nodeIIVisible; > + BOOL node1Visible; > + BOOL node2Visible; > + HWND window = CreateWindowExA(0, "MyTestWnd", "treeview: TestExpandInvisible", WS_OVERLAPPEDWINDOW, > + CW_USEDEFAULT, CW_USEDEFAULT, 130, 105, NULL, NULL, GetModuleHandleA(NULL), 0); > + > + HWND tree = CreateWindowExA(WS_EX_CLIENTEDGE, WC_TREEVIEWA, NULL, WS_CHILD|WS_VISIBLE| > + TVS_LINESATROOT|TVS_HASLINES|TVS_HASBUTTONS|TVS_EDITLABELS, > + 0, 0, 120, 100, window, (HMENU)100, GetModuleHandleA(0), 0); > + > + > + ins.hParent = TVI_ROOT; > + ins.hInsertAfter = TVI_ROOT; > + U(ins).item.mask = TVIF_TEXT; > + U(ins).item.pszText = nodeRText; > + nodeR = TreeView_InsertItem(tree, &ins); > + assert(nodeR); > + > + ins.hInsertAfter = TVI_LAST; > + U(ins).item.mask = TVIF_TEXT; > + ins.hParent = nodeR; > + > + U(ins).item.pszText = nodeIText; > + nodeI = TreeView_InsertItem(tree, &ins); > + assert(nodeI); > + U(ins).item.pszText = nodeIIText; > + nodeII = TreeView_InsertItem(tree, &ins); > + assert(nodeII); > + > + ins.hParent = nodeI; > + > + U(ins).item.pszText = node1Text; > + node1 = TreeView_InsertItem(tree, &ins); > + assert(node1); > + U(ins).item.pszText = node2Text; > + node2 = TreeView_InsertItem(tree, &ins); > + assert(node1); > + > + nodeIVisible = TreeView_GetItemRect(tree, nodeI, &dummyRect, FALSE); > + ok(!nodeIVisible, "Node I should not be visible.\n"); > + node1Visible = TreeView_GetItemRect(tree, node1, &dummyRect, FALSE); > + ok(!node1Visible, "Node 1 should not be visible.\n"); > + node2Visible = TreeView_GetItemRect(tree, node2, &dummyRect, FALSE); > + ok(!node2Visible, "Node 2 should not be visible.\n"); > + nodeIIVisible = TreeView_GetItemRect(tree, nodeII, &dummyRect, FALSE); > + ok(!nodeIIVisible, "Node II should not be visible.\n"); > + > + ok(TreeView_Expand(tree, nodeI, TVE_EXPAND), "Expand of node I failed.\n"); > + > + nodeIVisible = TreeView_GetItemRect(tree, nodeI, &dummyRect, FALSE); > + ok(!nodeIVisible, "Node I should not be visible.\n"); > + node1Visible = TreeView_GetItemRect(tree, node1, &dummyRect, FALSE); > +todo_wine > + ok(!node1Visible, "Node 1 should not be visible.\n"); > + node2Visible = TreeView_GetItemRect(tree, node2, &dummyRect, FALSE); > +todo_wine > + ok(!node2Visible, "Node 2 should not be visible.\n"); > + nodeIIVisible = TreeView_GetItemRect(tree, nodeII, &dummyRect, FALSE); > +todo_wine > + ok(!nodeIIVisible, "Node II should not be visible.\n"); > +} > + > + > START_TEST(treeview) > { > HMODULE hComctl32; > @@ -819,4 +897,6 @@ START_TEST(treeview) > TranslateMessage(&msg); > DispatchMessageA(&msg); > } > + > + TestExpandInvisible(); > } > -- > 1.5.4.3 > > > > Hi Florian, I think you should use already created dialog and treeview. Place your new function just after TestCallback(), clear tree view and fill it, then just test visibility of expandable items. -- Nicolas Le Cam

1 0

Winprinfo tool
by Saulius Krasuckas 15 Apr '09

15 Apr '09

(Excuse me for the flowed format in my previous msg) I just have struck one tool related to Windows printer drivers [*]: | In the process of developing a Windows printer driver, we created this | winprinfo tool to allow us to query the printer system from the point of | view of an application: there are several APIs that permit a wide range | of query. This tool exercises them all and proved to be indispensible in | our development. ... | Once a printer has been opened, there are several Win32 API calls that | can be used to query the device. These are DeviceCapabilities(), | GetDeviceCaps, and EnumForms() (there may be more, but we'll add them as | we discover them. | | Driver Info / GetPrinterDriver() | By fetching a DRIVER_INFO_4 object for this printer, we're able to | show the version (kernel or user), as well as the paths used for all the | support files (driver and UI DLLs, plus the dependent files). | | DEVMODE / DeviceCapabilities() | A central data structure involved in printing is the DEVMODE, which | is a collection of settings that apply to a printjob. Each printer has a | group of default settings that are used in the absense of any user input | on the subject, and they are managed with the printer's setup GUI. | Using the DeviceCapabilities() API function, we are able to extract | a number of individual parameters from the DEVMODE and report them. | | GetDeviceCaps() | Since a printer is a "graphics device", there are some kinds of | parameters that are in common with other devices such as video displays. | The GetDeviceCaps() call returns a small set of numeric parameters, many | of which have no real interest to printer developers. | | EnumForms() | The NT print spooler supports the notion of "forms", which is simply | a way of attaching a name to a specifically-sized piece of output media. | There are built-in sizes such as Letter and Legal, but there are at | least a hundreds defined for oddball paper sizes all over the world. A | print driver can define additional forms as well, though the interaction | between the central forms database and the driver is still a little | unclear. My guess, it could be usefull for guys like Detlef working on Winspool (and Co.) also. Then it can query printers over SMB. One more (probably) interesting note (with regard to running the tool on Wine): | We built this to run strictly on NT/Win2000/XP platforms: if it works at | all on Win95/98/ME, we'd be very surprised. [*] http://unixwiz.net/tools/winprinfo.html

1 0

Re: [mountmgr.sys] add unittests for registry keys of serial ports
by Dmitry Timoshkov 15 Apr '09

15 Apr '09

"Stefan Leichter" <Stefan.Leichter(a)camline.com> wrote: > [mountmgr.sys] add unittests for registry keys of serial ports The closest match these tests belong to is dlls/kernel32/tests/comm.c Is there any app that checks for a registry key instead of using an API? -- Dmitry.

2 2

Re: FYI -- Dragon Naturally Speaking running a bit better today.
by Susan Cragin 15 Apr '09

15 Apr '09

>On Do, 2009-04-09 at 16:05 -0400, Susan Cragin wrote: >> Dragon Naturally Speaking ... >> the amount of time one can use it before it crashes crept up about 2 >> minutes, ... >> Today I dictated for about 14 minutes until it crashed. >> That's progress. > >Susan, thanks a lot for your sedulous testing of DNS in Wine! > >-- > >By by ... Detlef > Thank you all for making "my" program run better. 16 minutes with today's git, 14-Apr. Susan

1 0

DIB Engine - New approach (resent as first got lost...)
by Massimo Del Fedele 14 Apr '09

14 Apr '09

The approach taken so far consisted in having 2 device pointers inside GDI32, one for dib engine and the other for normal display driver. This way had the disadvantage of having to keep in sync the DC with the right driver depending on selected bitmap, which lead to many small changes spread along all gdi code; going deeper with development this approach showed many limits and problems. So I decided to start again from scratch with a completely different approach which is giving good results and is quite less invasive on gdi32 code. Instead of doing : -- DIB ENGINE / GDI32 --- \ -- X11 DRIVER I took this approach : GDI32 -- DIB ENGINE -- X11 DRIVER The (X11) display driver is loaded from inside the engine, which replaces it from gdi32 point of view. The changes in gdi32 are *very* limited, just in driver.c code, making it to load (if desired) the engine instead of normal x11 driver. No other changes needed. I added as usual the code allowing to enable/disable the engine on request by registry and/or environment variable. If the engine is not present or disabled, the driver loader falls back to usual behaviour. The Engine then loads the X11 driver in init phase and acts as a gate depending on selected BMP, forwarding to X11 driver all requests for DDB bitmaps and doing the job itself for DIB ones. This approach showed many advantages, and I' almost ready converting all old code to it. By now I'm posting here 3 patches (EDIT : posted on bug421 page, as here they disappeared....) showing the approach; the posted driver is a simple pass-throu one, so it just forwards all calls to X11 driver. The last patch of the series shows the forking behaviour of DIB/DDB processing from inside the engine, but still forwarding all to X11. I'd like some comments on the approach taken; on next days I'll post a more complete code with most of the engine implemented. Ciao Max

2 2

Re: Christian Costa : amstream/tests: Beginning of tests.
by Nikolay Sivov 14 Apr '09

14 Apr '09

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: b5dbbd4f3a16d074f0bdff39077973efdffe6c55 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5dbbd4f3a16d074f0bdff390… > > Author: Christian Costa <titan.costa(a)wanadoo.fr> > Date: Mon Apr 13 10:07:35 2009 +0200 > > amstream/tests: Beginning of tests. > > --- > > Breaks 'make crosstest' for me with unresolved GUID definitions. Looks like linking with strmiids has same affect when using uuid in tests. CLSID_AMMultiMediaStream IID_IAMMultiMediaStream should be defined inline I think.

1 0

Setting working directories for applications?
by Igor Tarasov 14 Apr '09

14 Apr '09

Hello. This might be a known issue, but anyway: Some windows applications need that shortcut (launcher) have working directory set, and that working directory sometimes different from where the .exe is located. In Linux, with gnome and kde it is not a big problem, since .desktop launchers in these DE support Path attribute. But this becomes a problem with systems that don't support this out of box. As good as I am aware, XFCE have this problem - it's launchers ignore path attribute. Also, AFAIK, there are similar problems with mac version. There might be problems in other desctop enviroments, but I am not aware of these. Currently the only way to lauch such applications is either to use terminal and cd to working directory and then run application, or create custom bash launcher, which is too complicated for not experienced users (I mean not to reproduce it step-by-step, but to solve it by themselves). Is there anything that could be done in this area? -- Igor

7 9

Re: Setting working directories for applications?
by James Mckenzie 14 Apr '09

14 Apr '09

Damjan Jovanovic <damjan.jov(a)gmail.com> wrote on April 14th: > >On Sun, Apr 12, 2009 at 8:29 AM, Igor Tarasov <tarasov.igor(a)gmail.com> wrote: > >Do our .desktop files even work on Mac? > I don't think the Aqua specification allows for .desktop files, but .lnk files are connected to the Winehelper application and they do work. If the .desktop files require a specific launcher, it may be possible to get them to work on a Mac. James McKenzie

1 0

FYI -- Dragon Naturally Speaking running a bit better today.
by Susan Cragin 14 Apr '09

14 Apr '09

Dragon Naturally Speaking crashes after prolonged use, but the amount of time one can use it before it crashes crept up about 2 minutes, using today's git. Today I dictated for about 14 minutes until it crashed. That's progress. Susan

2 1

Re: [2/2] secur32/tests: Fix GetUserNameEx() tests (try 2)
by Paul Vriens 14 Apr '09

14 Apr '09

Ge van Geldorp wrote: > Try 2: use win_skip() instead of skip() > > Changelog: > secur32/tests: Fix GetUserNameEx() tests > > --- > dlls/secur32/tests/secur32.c | 44 > +++++++++++++++++++++--------------------- > 1 files changed, 22 insertions(+), 22 deletions(-) > > > > > > ------------------------------------------------------------------------ > > Hi Ge, Why did you remove: - if (0) /* Crashes on Windows */ - rc = pGetUserNameExW(NameSamCompatible, NULL, NULL); - The point of these additions was to show/document that Windows crashes when called like this. -- Cheers, Paul.

4 5

[RFC] mountmgr.sys: keep track of local disks when requested in winecfg
by Ben Klein 14 Apr '09

14 Apr '09

I submitted this to wine-patches a while ago and haven't seen it go in. I'm confident it is correct and proper, but I'd like some feedback (which I've also asked for before) from more experienced devs. The problem is that when you set a drive to "Local disk" in winecfg, the setting isn't remembered/stored and instead it reverts to the "autodetect" method. I traced the problem to mountmgr.c, where define_unix_drive (ultimately called when changes are made to the winecfg "Drives" tab) has no case for the DRIVE_FIXED/DEVICE_HARDDISK_VOL/"Local disk" option (which is already in query_unix_drive) and it reverts to DEVICE_UNKNOWN which is handled as an "autodetect" and no registry entry is stored. The patch below fixes this, so setting "Local disk" in winecfg creates a registry entry that sets the drive type to "hd", which is then correctly reported by query_unix_drive. There is a bug report for this problem. http://bugs.winehq.org/show_bug.cgi?id=17618 diff --git a/dlls/mountmgr.sys/mountmgr.c b/dlls/mountmgr.sys/mountmgr.c index 00112b9..d2b1515 100644 --- a/dlls/mountmgr.sys/mountmgr.c +++ b/dlls/mountmgr.sys/mountmgr.c @@ -264,6 +264,7 @@ static NTSTATUS define_unix_drive( const void *in_buff, SIZE_T insize ) case DRIVE_REMOTE: type = DEVICE_NETWORK; break; case DRIVE_CDROM: type = DEVICE_CDROM; break; case DRIVE_RAMDISK: type = DEVICE_RAMDISK; break; + case DRIVE_FIXED: type = DEVICE_HARDDISK_VOL; break; } return add_dos_device( letter - 'a', NULL, device, mount_point, type ); } -- 1.6.1.3

1 0

Re: try3 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice
by Paul Vriens 14 Apr '09

14 Apr '09

Guy Albertelli wrote: > Enhance QueryDosDevice test for attempting to return all devices. > Add tests for GetVolumeInformationA testing the different root dir formats. > --- > dlls/kernel32/tests/volume.c | 132 +++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 129 insertions(+), 3 deletions(-) > > > > ------------------------------------------------------------------------ > > You're leaking memory here (although it's just a test we try to have these as clean as possible): + buffer = HeapAlloc( GetProcessHeap(), 0, buflen ); + ret = QueryDosDeviceA( NULL, buffer, buflen ); + ok(ret && GetLastError() != ERROR_INSUFFICIENT_BUFFER, + "QueryDosDevice buffer to small\n"); + if (GetLastError() == ERROR_INSUFFICIENT_BUFFER) return; Could you also change the skip()'s into win_skip()'s: + if (!pGetVolumeInformationA) { + skip("GetVolumeInformationA not found\n"); + return; + } + if (!pGetVolumeNameForVolumeMountPointA) { + skip("GetVolumeNameForVolumeMountPointA not found\n"); + return; + } That way they will only be skipped on Windows if the functions are not present. If the functions are not present on Wine (for whatever reason) a win_skip will show a failure on wine. -- Cheers, Paul.

1 0

unsubscribe
by Rich Gilson 14 Apr '09

14 Apr '09

Michael Stefaniuc wrote: > --- > dlls/opengl32/wgl.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/dlls/opengl32/wgl.c b/dlls/opengl32/wgl.c > index b73cf60..34f7f07 100644 > --- a/dlls/opengl32/wgl.c > +++ b/dlls/opengl32/wgl.c > @@ -102,8 +102,8 @@ typedef struct wine_glcontext { > > void enter_gl(void) > { > - Wine_GLContext *curctx = (Wine_GLContext *) NtCurrentTeb()->glContext; > - > + Wine_GLContext *curctx = NtCurrentTeb()->glContext; > + > if (curctx && curctx->do_escape) > { > enum x11drv_escape_codes escape = X11DRV_SYNC_PIXMAP; > @@ -230,8 +230,8 @@ PROC WINAPI wglGetProcAddress(LPCSTR lpszProc) { > > /* After that, search in the thunks to find the real name of the extension */ > ext.name = lpszProc; > - ext_ret = (const OpenGL_extension *) bsearch(&ext, extension_registry, > - extension_registry_size, sizeof(OpenGL_extension), compar); > + ext_ret = bsearch(&ext, extension_registry, extension_registry_size, > + sizeof(OpenGL_extension), compar); > > /* If nothing was found, we are looking for a WGL extension or an unknown GL extension. */ > if (ext_ret == NULL) { >

1 0

do ERR messages imply bugs?
by Vincent Povirk 13 Apr '09

13 Apr '09

Chris Ahrendt filed a few bugs recently for "err" messages encountered during test runs (17997 and 17998 at least). Vitaliy claims they are invalid. In order to explain clearly why they are invalid, I looked up the official definition of ERR in the Wine Developer's Guide: "Messages in this class indicate serious errors in Wine, such as as conditions that should never happen by design." (http://www.winehq.org/docs/winedev-guide/debugging) This goes against my preconceived notion. Bad developer's guide, bad. To my even greater astonishment, all the ERR messages I've added fit this description. Bad past self, bad. The consensus (or so I thought) seems to be that ERR messages are simply for debugging and can safely be ignored as long as nothing is going wrong in a running program (in this case, as long as the tests are not failing). "Serious errors" sounds like something that should be worth investigating, even without visible failures. How do we resolve this discrepancy? Vincent Povirk

7 23

Re: tools/wine.inf: create Microsoft Shared/TextConv directory
by Austin English 13 Apr '09

13 Apr '09

On Sun, Mar 22, 2009 at 11:40 AM, Austin English <austinenglish(a)gmail.com> wrote: > Needed by a few different installers. Now comes by default in XP SP3 > and up (verified name on a German locale, doesn't seem to be English > specific). > > Fixes bug 17257. > > -- > -Austin > Anything wrong with this one? -- -Austin

1 0

Re: [1/1]msctf/test: test Enableing and Disabling Language Profiles
by Detlef Riekenberg 13 Apr '09

13 Apr '09

On Fr, 2009-04-10 at 07:55 -0500, Aric Stewart wrote: > +static void test_Disable(void) ... > + trace("Disabling\n"); ... > + ok(SUCCEEDED(hr),"Failed to enable text service\n"); With greetings from Copy & Paste -- By by ... Detlef

1 0

Re: [1/5] resend include: bring in6_addr into line with the MS definition
by Alexandre Julliard 13 Apr '09

13 Apr '09

Jeff Latimer <lats(a)yless4u.com.au> writes: > +#ifdef USE_WS_PREFIX > +#define WS(x) WS_##x > +#else > +#define WS(x) x > +#endif > + > +struct WS(in6_addr) { > + union { > + WS(u_char) Byte[16]; > + WS(u_short) Word[8]; > + } u; > +} IN6_ADDR, *PIN6_ADDR, *LPIN6_ADDR; > + > +#define in_addr6 WS(in6_addr) > + > +#define _S6_un u > +#define _S6_u8 Byte > +#ifndef USE_WS_PREFIX > +#define s6_addr _S6_un._S6_u8 > +#else > +#define WS_s6_addr _S6_un._S6_u8 > +#endif > + > +#define s6_bytes u.Byte > +#define s6_words u.Word You need the WS prefix on all definitions that can potentially conflict with Unix. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: do ERR messages imply bugs?
by Vitaliy Margolen 13 Apr '09

13 Apr '09

Roderick Colenbrander wrote: > On Sun, Apr 12, 2009 at 6:53 PM, Vitaliy Margolen > <wine-devel(a)kievinfo.com <mailto:wine-devel@kievinfo.com>> wrote: > > Vincent Povirk wrote: > > Chris Ahrendt filed a few bugs recently for "err" messages encountered > > during test runs (17997 and 17998 at least). > > > 17997 is a bogus report - Gecko is not intalled. Nothing actually > failed. > 17998 is the same. Only I let our resident 3D gurus to respond. I > don't see > any problems with tests testing invalid conditions. This most likely > one of > those cases. > > If Chris doesn't like err messages, he can shut them off. > > Vitaliy. > > > The first ERR line in bug 17998 could indicate a real bug as a program > is trying to lock a surface which has already been locked. > > err:d3d_surface:IWineGDISurfaceImpl_LockRect (0x132280) Surface already locked > > I'm not sure about the opengl error. It could mean that some display > driver is offering some render_type flags which I'm not handling yet. > That can also cause issues. > > err:wgl:get_render_type_from_fbconfig Unknown render_type: 0 This is all well and good, but I'm seeing this errors from pretty much any 3D application. Not that all these 3D apps work flawlessly on Wine to begin with - haven't seen one yet. But it's been a policy to ignore all messages from Wine until user can show the real problem. So far no tests fail - and that is the only acceptable "problems" from tests. Vitaliy.

5 13

Re: Re : [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.
by Nicolas Le Cam 13 Apr '09

13 Apr '09

2009/4/13 James McKenzie <jjmckenzie51(a)earthlink.net>: > Nicolas Le Cam wrote: >> James, >> >> Here are updated patches for part 3 & 4 of my previous patch set. Tell >> me if you think I could submit them to wine-patches. >> >> For patch 3, the only todo_wine is when launched from root drive dir >> as explained in my previous mail. >> For patch 4, I skip a test if test is executed on root drive dir, as >> it doesn't make sense to execute it in this case. >> >> If needed I can remove the skip and change expected value to be first >> fixed drive when test is run on root drive dir. But this is already >> tested by patch 3 (when run on a root drive dir). >> >> > Did these work with WindowsXP or Windows Vista as expected? I don't > have them here to test, only Wine. > > I would defer the todo_wine to others with more experience, as this > marks the tested function needs more work with Wine and my experience > with msi is only as a user. > > James McKenzie > > > It worked as expected on Win2k and Wine. I can test it on WinXP if wanted, but I don't own any Vista. The todo_wine is to handle root drive directories where Windows output first fixed drive where Wine currently output an empty string as demonstrated on . Fix seems to be simple. We just need to break the for loop after the GetDriveType test in ACTION_SearchDirectory function in appseach.c if path is only three characters long (attr should also be checked against INVALID_FILE_ATTRIBUTES just after it). ACTION_CheckDirectory could perhaps be updated to handle root drive directories too, but I'm not certain with this one. As I don't have any experience with msi at all even as user, I will certainly wait for someone to validate what I'm saying. Thanks for review. -- Nicolas Le Cam

2 2

wininet: Add tests for asynchronous HttpSendRequestEx/HttpEndRequest.
by Nicolas Le Cam 13 Apr '09

13 Apr '09

Hi Hans, Your patch makes the test timeout on my machine (http://test.winehq.org/data/f212579ae9a1b770ebd34cec20f95e1977bb57f0/2000_w…). Timeout occurs in HttpSendRequestEx_test on HttpEndRequest call which hang. Disabling test_async_HttpSendRequestEx makes it pass again. After some tests it seems to be a timing issue, but I haven't been able to find a real solution. Just that waiting at least 500msec between the two HttpEndRequest, or waiting at least 150ms after the WaitForSingleObject that follow the second HttpEndRequest makes test pass. Reading response doesn't change anything. After reading a little bit about how this works I don't see anything wrong. Perhaps you will. thanks, Nicolas Le Cam

2 4

Re: [4/4] (Try4) msi/tests: Fix package test when run on root drive directory.
by James Hawkins 12 Apr '09

12 Apr '09

On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Try2: This time with the patch. > > Tested on Win2k/WinXP. Marked two tests as todo_wine. > I was serious before. You can't change the old tests. Please add new tests for the exposed bugs. Same goes for patch 3/4. -- James Hawkins

4 8

Re: [5/8] WineD3D: Add a more formal framework for driver quirks
by Stefan Dösinger 12 Apr '09

12 Apr '09

I accidentally deleted the mail in my inbox, so that reply is without a proper in-reply-to tag. Here's the archive for reference: http://www.winehq.org/pipermail/wine-devel/2009-April/074718.html > - I don't like how much information specific to constant fixups the > table contains. There is a lot of intended redundancy here. The minimum we need is the flag to use the ARB or GLSL constant value. I want some additional safeguards to make the fixup noisy if one of the assumptions we make about the driver isn't true any more. The patches here only handle constants, but I want to do the same for varyings. I don't like the idea of using a callback function to apply the fixups because it would repeat quite a bit of value checking and FIXME writing code for different cards, just with different constants in the code. > - The "apple" field is weird. If you're going to have a callback > function you might as well match that information there, if > appropriate. On the other hand, I don't think you really need the > callback function, you only match on vendor and card anyway. All non-apple platforms have the same graphics driver, just the Apple drivers have their own weirdness that does not occur anywhere else. Its mostly many unsupported features that are advertised and software emulated which we have to filter out. All other platforms share the same driver anyway, even Windows to a certain extend. I can replace this with a driver vendor enum or a driver vendor matching function. However, I am prepared to adjust the setup in the future if $NEWWEIRDRIVERVENDOR pops up(e.g. Gallium3D) that has different requirements. I want to keep the driver vendor match separated from the card match to allow defining fixups that apply to all cards run by a driver from a specific vendor. A later patch adds a fixup that uses the ARB constant limits on all cards if we're running on a apple driver. There are other ways to do this, like returning a matching score and using the best match, or merging two fixups into one. I think that my approach matches what we want to do best and is simpler than trying to merge fixup descs. > - What is the point of only allowing one fixup per card, and then > adding QUIRK_NO_SANITY_CHECK to allow more fixups? You might as well > just allow multiple fixups and apply them in the order they're > defined. See above - generic fixups for a driver vendor that applies across cards. Obviously a Geforce 8 has different uniform or varying limits than a Intel GMA 950, but in both cases the GLSL uniform info is no good and we should use the ARB one instead. > - Why do you store the quirk table in gl_info? It's never used from > there. (I realise the next couple of patches do use it from there). > ... > and just add a DWORD "quirk_flags" to gl_info. My patches add two fields that are accessed from other places in the code. There may or may not be more in the future. I prefer to have one pointer in the gl_info structure than multiple DWORDs containing quirk info, but I am flexible with this.

2 1

Re: i have itunes 7.60 successfully running on f10 kde 4.2
by Ben Klein 12 Apr '09

12 Apr '09

2009/4/12 Warren Dumortier <nwarrenfl(a)gmail.com>: > No latest iTunes doesn't install, in fact only 7.60 installs if i remember... > Consult bugzilla. If there are no appropriate bugs open, open a bug, and provide as detailed information as you can. You should also be willing to provide additional information on request (remarkably, some people aren't, and they believe that just submitting an obscure bug is enough to get it fixed).

1 0

Re: implement PS_USERSTYLE handling, tested with Dia(win32)
by James McKenzie 11 Apr '09

11 Apr '09

Hans Breuer wrote: > From b89af7d06fc8cbf5210c61fd58ed62caeddad968 Mon Sep 17 00:00:00 2001 > From: Hans Breuer <hans(a)breuer.org> > Date: Sun, 29 Mar 2009 18:27:29 +0200 > Subject: implement PS_USERSTYLE handling, tested with Dia(win32) - see > http://hans.breuer.org/dia/dia-wine.htm > > --- > dlls/winex11.drv/pen.c | 31 +++++++++++++++++++++++++++---- > 1 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/dlls/winex11.drv/pen.c b/dlls/winex11.drv/pen.c > index 49fe74c..039798e 100644 > --- a/dlls/winex11.drv/pen.c > +++ b/dlls/winex11.drv/pen.c > @@ -54,12 +54,33 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE > *physDev, HPEN hpen ) > elp = HeapAlloc( GetProcessHeap(), 0, size ); > > GetObjectW( hpen, size, elp ); > - /* FIXME: add support for user style pens */ > logpen.lopnStyle = elp->elpPenStyle; > logpen.lopnWidth.x = elp->elpWidth; > logpen.lopnWidth.y = 0; > logpen.lopnColor = elp->elpColor; > - > + /* support for user style pens */ > + if (MAX_DASHLEN < elp->elpNumEntries) > + { > + FIXME("PS_USERSTYLE: len(dashes)>MAX_DASHLEN %d,%d\n", > elp->elpNumEntries, MAX_DASHLEN); > + physDev->pen.dash_len = 0; > + } > + else > + { > + BOOL overflow = FALSE; > + physDev->pen.dash_len = elp->elpNumEntries; > + for (i = 0; i < elp->elpNumEntries; ++i) > + { > + if (elp->elpStyleEntry[i] > 255) > + { > + overflow = TRUE; /* can't fit the type */ > + physDev->pen.dashes[i] = 255; > + } > + else > + physDev->pen.dashes[i] = > (char)elp->elpStyleEntry[i]; > + } > + if (overflow) > + FIXME("PS_USERSTYLE: dashes clipped (type overflow)\n"); > + } > HeapFree( GetProcessHeap(), 0, elp ); > } > else > @@ -108,14 +129,16 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE > *physDev, HPEN hpen ) > memcpy(physDev->pen.dashes, PEN_alternate, > physDev->pen.dash_len); > break; > case PS_USERSTYLE: > - FIXME("PS_USERSTYLE is not supported\n"); > + /* handled above */ > + break; > /* fall through */ > default: > physDev->pen.dash_len = 0; > break; > } > if(physDev->pen.ext && physDev->pen.dash_len && > - (logpen.lopnStyle & PS_STYLE_MASK) != PS_ALTERNATE) > + (logpen.lopnStyle & PS_STYLE_MASK) != PS_ALTERNATE && > + (logpen.lopnStyle & PS_STYLE_MASK) != PS_USERSTYLE) > for(i = 0; i < physDev->pen.dash_len; i++) > physDev->pen.dashes[i] *= (physDev->pen.width ? > physDev->pen.width : 1); > This needs a conformance test to show this is what happens in Windows. If this is not supported in certain versions, you will also need to add broken() code for those versions with what happens. Look at the Wine source code and search for the use of this call. James McKenzie

2 2

Re: [2/2] secur32/tests: Fix GetUserNameEx() tests
by Austin English 11 Apr '09

11 Apr '09

On Sat, Apr 11, 2009 at 1:45 PM, Ge van Geldorp <ge(a)gse.nl> wrote: > Update tests based on more Windows test runs > > Changelog: > secur32/tests: Fix GetUserNameEx() tests > > --- > dlls/secur32/tests/secur32.c | 42 > +++++++++++++++++++++--------------------- > 1 files changed, 21 insertions(+), 21 deletions(-) @@ -242,15 +234,23 @@ START_TEST(secur32) if (pGetComputerObjectNameA) testGetComputerObjectNameA(); + else + skip("GetComputerObjectNameA not exported by secur32.dll\n"); if (pGetComputerObjectNameW) testGetComputerObjectNameW(); + else + skip("GetComputerObjectNameW not exported by secur32.dll\n"); if (pGetUserNameExA) testGetUserNameExA(); + else + skip("GetUserNameExA not exported by secur32.dll\n"); if (pGetUserNameExW) testGetUserNameExW(); + else + skip("GetUserNameExW not exported by secur32.dll\n"); test_InitSecurityInterface(); Shouldn't these be win_skip's? -- -Austin

2 1

Re: [2/3] secur32/tests: Add simple tests for GetUserNameExA/W() [try 2]
by Paul Vriens 11 Apr '09

11 Apr '09

Ge van Geldorp wrote: > Try 2: Add buffer overflow tests > > Changelog: > secur32/tests: Add simple tests for GetUserNameExA/W() > > --- > dlls/secur32/tests/secur32.c | 86 > ++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 86 insertions(+), 0 deletions(-) > > Hi Ge, The tests show a big list of possible last errors. Are these for a specific platform? If so, we should probably list that. Is the ERROR_INVALID_PARAMETER for NameUnknown also for a specific platform? The reason I'm asking is because W2K fails with ERROR_INVALID_PARAMETER for NameDnsDomain and I'm looking for the cleanest way to add that (as broken()). -- Cheers, Paul.

2 2

Re: i have itunes 7.60 successfully running on f10 kde 4.2
by EA Durbin 11 Apr '09

11 Apr '09

On Mon, Apr 6, 2009 at 1:05 PM, AllenDavidNiven <AllenDavidNiven <at> globalfone.biz> wrote: > who can i pay to make this on the wine that i have > is $100 ok ? > >That's generous of you, but also humorous. I can't remember the last >estimate we had of how much work it would take, but it's on the order >of tens of thousands of dollars. That's assuming it's not impossible >to get the ipod touch/iphone driver working in Wine. >-- >James Hawkins I don't know how many people I've shown linux who would convert if only it ran iTunes, I've demonstrated the operating system to dozens and it's a comon feedback I hear. Itunes is a major application and a huge inhibitor of linux adoption. But unless we get tens of thousands of dollars up front we shouldn't focus development effort on a huge attraction to the Linux operating system and lets ridicule someone when they do offer monetary support because it isn't significant enough. After all we don't want to vastly increase our potential customer base and potentially get several $70 per crossover professional license or $40 per standard license fees, but rather wait until someone writes a hefty check to port it up front. If you build it they will come. _________________________________________________________________ Quick access to your favorite MSN content and Windows Live with Internet Explorer 8. http://ie8.msn.com/microsoft/internet-explorer-8/en-us/ie8.aspx?ocid=B037MS…

6 7

Re: try2 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice
by Paul Vriens 11 Apr '09

11 Apr '09

Guy Albertelli wrote: > Enhance QueryDosDevice test for attempting to return all devices. > Add tests for GetVolumeInformationA testing the different root dir formats. > --- > dlls/kernel32/tests/volume.c | 134 +++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 131 insertions(+), 3 deletions(-) > > > > ------------------------------------------------------------------------ > > + char Root_Dir3[]="C:\\Windows\\System\\"; .. + Root_Dir3[0] = windowsdir[0]; This won't work on all systems as the windows directory can be different (and can be changed during installation). You could use GetSystemDirectory() instead of GetWindowsDirectory() to find out the drive letter and in the same go use the output from GetSystemDirectory() to fill Root_Dir3. As you're actually interested in an existing directory you could even use the output from GetWindowsDirectory() to fill Root_Dir3. -- Cheers, Paul.

2 1

Adding new flags?
by Igor Tarasov 10 Apr '09

10 Apr '09

Hi there! I try to implement as precise as possible one undocumented feature in comctl32, this all deals with one structure field. After lots of testing I know the following: 1. Default value for that field returned by getter is 0. 2. By default it is ignored in behavior. 3. If you change value by the setter, even to 0, behavior changes. 4. Negative values, such as (-1) also produce different behavior and cannot be used as "field not changed" flag. So, does that mean that I have to add new flag to the structure that would be set only if that field is changed, or there is another way to do that? -- Igor

3 5

Re: wined3d: don't update the screen when gdi back buffers are unlocked
by Henri Verbeet 10 Apr '09

10 Apr '09

2009/4/8 Vincent Povirk <vincent(a)codeweavers.com>: > This should fix bug 15789. > > Stefan tells me that we're supposed to update the screen when the front buffer is unlocked, as that means it could have changed. Instead, we do it when any buffer in the swapchain is unlocked. This makes for a lot of unnecessary copies. > > He also told me to make this change to fix it. I don't really understand the surrounding code. > > And he tells me that he's too busy to send the change in, and I should do it if I want it to happen soon. > For what it's worth, I think this patch makes sense. Not that the mail makes a very convincing case though :-/

1 0

Re: [2/2] wine.inf: Add HKCU\Keyboard Layout\Preload key.
by Alexandre Julliard 10 Apr '09

10 Apr '09

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -546,6 +546,7 @@ HKLM,System\CurrentControlSet\Control\Session Manager,,,"" > HKLM,System\CurrentControlSet\Control\VMM32Files,,,"" > HKCU,Software\Microsoft\Protected Storage System Provider,,,"" > HKCU,Software\Wine\MSHTML,"GeckoUrl",,"http://source.winehq.org/winegecko.php" > +HKCU,Keyboard Layout\Preload,,,"" This should be done somewhere in the keyboard layout code, not in wine.inf. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/4] msi/tests: Fix test when content indexing is disabled.
by Alexandre Julliard 10 Apr '09

10 Apr '09

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -2308,7 +2308,7 @@ static void test_setpropertyfolder(void) > > r = MsiInstallProductA(msifile, NULL); > ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r); > - if (GetFileAttributesA(path) == FILE_ATTRIBUTE_DIRECTORY) > + if (GetFileAttributesA(path) & FILE_ATTRIBUTE_DIRECTORY) > { > ok(delete_pf("msitest\\added\\maximus", TRUE), "File not installed\n"); > ok(delete_pf("msitest\\added", FALSE), "File not installed\n"); You most likely need to check for GetFileAttributesA failure first. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/4] (Try2) msi/tests: Fix package test when run on root drive directory.
by James Hawkins 10 Apr '09

10 Apr '09

On Thu, Apr 9, 2009 at 7:43 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Try2: This time with the patch. > > Tested on Win2k/WinXP. Marked two tests as todo_wine. > If you're having to add todo_wine, then you're changing the current tests, which is bad if all you're trying to do is handle another case (running on root drive directory). Adding more tests to reveal an existing problem is fine. -- James Hawkins

2 1

Re: [4/8] WineD3D: Support the full amount of constants in GLSL
by Henri Verbeet 10 Apr '09

10 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > if(pshader) { > - max_constantsF = GL_LIMITS(pshader_constantsF) - (MAX_CONST_B / 4) - MAX_CONST_I - 2; > - max_constantsF = min(This->baseShader.limits.constant_float, max_constantsF); > + /* No indirect addressing here */ > + max_constantsF = GL_LIMITS(pshader_constantsF); > } else { Actually, can't at least 2.x pixel shaders do relative addressing as well?

2 1

implement PS_USERSTYLE handling - obviously not correct ;)
by Hans Breuer 10 Apr '09

10 Apr '09

Hi, just read again http://www.winehq.org/sending_patches and noticed that my first wine patch may fall in the category of not deserving an answer at all (to your standards). The one thing I noticed is my mail client putting line-wrapping into the patch, which should be easy to correct. But before resending it, I would appreciate some feedback if something else is 'obviously' wrong with it. To me it seems to be very difficult for the issue at hand to fall into the category of being "Obvious(ly) Correct". Although the X11 and win32 concepts of extended line styles are very similar, at least I did not know the scaling issues involved without trying it out. One thing which may be considered critical is my selection of the test program. As noted it is Dia for win32 (ported by me [1]) through gdk-win32-drawing code (PS_USERSTYLE usage implemented by me [2]). So if I have misunderstood something there seven years ago, that two bugs could compensate each other ;) Another issue might be the unconditional implementation of PS_USERSTYLE. After all it is only available with NT-based windows. Should x11drv check for the version being emulated to also reproduce the failing behaviour? Or would that be too much compatibility? What can I do to increase the probability of the patch being accepted? Thanks, Hans [1] http://hans.breuer.org/dia/ [2] http://svn.gnome.org/viewvc/gtk%2B?view=revision&revision=6330 [3] http://hans.breuer.org/dia/dia-wine.htm -------- Original-Nachricht -------- Betreff: implement PS_USERSTYLE handling, tested with Dia(win32) Datum: Sun, 29 Mar 2009 19:45:05 +0200 Von: Hans Breuer <hans(a)breuer.org> An: wine-patches(a)winehq.org From b89af7d06fc8cbf5210c61fd58ed62caeddad968 Mon Sep 17 00:00:00 2001 From: Hans Breuer <hans(a)breuer.org> Date: Sun, 29 Mar 2009 18:27:29 +0200 Subject: implement PS_USERSTYLE handling, tested with Dia(win32) - see http://hans.breuer.org/dia/dia-wine.htm --- dlls/winex11.drv/pen.c | 31 +++++++++++++++++++++++++++---- 1 files changed, 27 insertions(+), 4 deletions(-) diff --git a/dlls/winex11.drv/pen.c b/dlls/winex11.drv/pen.c index 49fe74c..039798e 100644 --- a/dlls/winex11.drv/pen.c +++ b/dlls/winex11.drv/pen.c @@ -54,12 +54,33 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) elp = HeapAlloc( GetProcessHeap(), 0, size ); GetObjectW( hpen, size, elp ); - /* FIXME: add support for user style pens */ logpen.lopnStyle = elp->elpPenStyle; logpen.lopnWidth.x = elp->elpWidth; logpen.lopnWidth.y = 0; logpen.lopnColor = elp->elpColor; - + /* support for user style pens */ + if (MAX_DASHLEN < elp->elpNumEntries) + { + FIXME("PS_USERSTYLE: len(dashes)>MAX_DASHLEN %d,%d\n", elp->elpNumEntries, MAX_DASHLEN); + physDev->pen.dash_len = 0; + } + else + { + BOOL overflow = FALSE; + physDev->pen.dash_len = elp->elpNumEntries; + for (i = 0; i < elp->elpNumEntries; ++i) + { + if (elp->elpStyleEntry[i] > 255) + { + overflow = TRUE; /* can't fit the type */ + physDev->pen.dashes[i] = 255; + } + else + physDev->pen.dashes[i] = (char)elp->elpStyleEntry[i]; + } + if (overflow) + FIXME("PS_USERSTYLE: dashes clipped (type overflow)\n"); + } HeapFree( GetProcessHeap(), 0, elp ); } else @@ -108,14 +129,16 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) memcpy(physDev->pen.dashes, PEN_alternate, physDev->pen.dash_len); break; case PS_USERSTYLE: - FIXME("PS_USERSTYLE is not supported\n"); + /* handled above */ + break; /* fall through */ default: physDev->pen.dash_len = 0; break; } if(physDev->pen.ext && physDev->pen.dash_len && - (logpen.lopnStyle & PS_STYLE_MASK) != PS_ALTERNATE) + (logpen.lopnStyle & PS_STYLE_MASK) != PS_ALTERNATE && + (logpen.lopnStyle & PS_STYLE_MASK) != PS_USERSTYLE) for(i = 0; i < physDev->pen.dash_len; i++) physDev->pen.dashes[i] *= (physDev->pen.width ? physDev->pen.width : 1); -- 1.6.0.6 -------- Hans "at" Breuer "dot" Org ----------- Tell me what you need, and I'll tell you how to get along without it. -- Dilbert

3 3

Re: [3/8] WineD3D: Deal with reserved shader constants in the backend
by Henri Verbeet 10 Apr '09

10 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > + unsigned max_constantsF; This is valid C, of course, but would the extra 4 characters for "int " really hurt?

1 0

Re: [4/8] WineD3D: Support the full amount of constants in GLSL
by Henri Verbeet 10 Apr '09

10 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > Please do not apply this patch without patches 5, 6, 7 and 8. In some > circumstances, this patch can step on the toes of inefficient MacOS drivers > or old fglrx versions. The additional patches give wined3d knowledge of these > driver problems to prevent this. > If this patch depends on those patches to work properly, shouldn't it come after them? > +void record_const_read(DWORD reg, unsigned int *array, int *num) { This should be static. Wrt the implementation, there are only 16 boolean constants and 16 integer constants. Using a bitmap and doing a bitcount should be trivial.

1 0

Re: [5/8] WineD3D: Add a more formal framework for driver quirks
by Henri Verbeet 10 Apr '09

10 Apr '09

There are a couple of things I don't like about this patch. - I don't like how much information specific to constant fixups the table contains. - The "apple" field is weird. If you're going to have a callback function you might as well match that information there, if appropriate. On the other hand, I don't think you really need the callback function, you only match on vendor and card anyway. - What is the point of only allowing one fixup per card, and then adding QUIRK_NO_SANITY_CHECK to allow more fixups? You might as well just allow multiple fixups and apply them in the order they're defined. - Why do you store the quirk table in gl_info? It's never used from there. (I realise the next couple of patches do use it from there). How about something like this: struct wined3d_driver_quirk { enum wined3d_driver_platform platform; GL_Vendors vendor; GL_Cards card; void (*fixup)(WineD3D_GL_Info *gl_info) }; and just add a DWORD "quirk_flags" to gl_info.

1 0

Test: patch to add adva,ced d3d settings in winecfg
by Warren Dumortier 09 Apr '09

09 Apr '09

Hello everybody... My patch to add advanced d3d settings in winecfg is almost ready. In fact, i only have to figure out how to detect video memory size to display it when no key is set to force it or to reset. Stefan D told me to use DirectDraw, but i wouldn't find. So that is the last thing (except some better naming...) to do for this patch. Everything works well and i would like some feedback. Thanks, kind regards.

3 4

Re: Sources of noise on test.winehq.org?
by Dan Kegel 09 Apr '09

09 Apr '09

The problem with the current arrangement is that when machines pop in and out, any failures that are more likely on those machines also pop in and out, so error counts fluctuate, which obscures the smaller changes due to wine fixes or regressions. I like the current output, and don't want to change it; I just want to add another view for people who want to judge progress. Setting up a view with a fixed set of machines would do, too. Which is easier? On Apr 9, 2009 12:12 PM, "Alexandre Julliard" <julliard(a)winehq.org> wrote: Dan Kegel <dank(a)kegel.com> writes: > On Thu, Apr 9, 2009 at 10:17 AM, Alexandre Julliard <julliard@... I don't see the point. If you want statistics for a specific machine, sure, we could generate a page for that. But the global index should show all the results we have. If it shows too many failures it means the tests are not robust enough across machines and should be fixed, not ignored. -- Alexandre Julliard julliard(a)winehq.org

2 1

Sources of noise on test.winehq.org?
by Dan Kegel 09 Apr '09

09 Apr '09

(This was last discussed in February, e.g. http://www.winehq.org/pipermail/wine-devel/2009-February/073060.html ) The results on test.winehq.org seem more variable than one would expect, which makes it harder to gauge wine's progress. I can think of two sources of noise: 1) 32 and 64 bit results are mixed together 2) we don't have a stable stable (sic) of machines running the tests Removing these two sources of noise might be as simple as 1) omit 64 bit results, and 2) omit computers for which results are not consistently available throughout the time range being displayed Shouldn't be too hard for someone to whip together an alternate report that did that. Wish I had the time to... - Dan

4 12

Status of TaskDialog implementation?
by Koro 09 Apr '09

09 Apr '09

Hi, I would like to know what's the status on the TaskDialog implementation in Wine based on the code I gave to Dan Kegel months ago. Relevant threads: http://www.winehq.org/pipermail/wine-devel/2008-October/069724.html http://www.winehq.org/pipermail/wine-devel/2008-October/069800.html Thanks.

1 0

Cool animated display of wine appdb stats
by Dan Kegel 09 Apr '09

09 Apr '09

Has anyone else noticed http://commons.wikimedia.org/wiki/File:History_Of_WineAppDB.gif which is shown on the right side of http://en.wikipedia.org/wiki/Wine_(software) ? It's kind of cool. Hats off to http://en.wikipedia.org/wiki/User_talk:Estemi who put it together. - Dan

4 4

Re: SoC: DirectShow/Gstreamer
by Maarten Lankhorst 09 Apr '09

09 Apr '09

Hello Trevor, I think this is a great idea. I have no idea how gstreamer works, but a lot of quartz is automatic pulling the pipes etc together. There are 3 categories of filters in directshow: - Source filters (can be a file, can be a webcam, can be any filter that has only an output) - Intermediate filters (can decode or parse a file, multiple can be linked together) - Renderers I have only peeked at gstreamer, but it seems it is very similar. Wine's directshow however still misses a few things that are probably important, like sending information about when new segments start, etc. If you implemented a gstreamer codec, a big part of it could be to fix this to be more similar to what windows does. You will probably find graphedt.exe from the microsoft sdk useful, it used to be part of the directx sdk, but later I think it became part of the platform sdk. It will probably still run, but the save/load function for saving/restoring filtergraphs is missing. However last time I looked most other functionality from it worked, if not patches should be easy to write. Also some older directx sdk's had in the extras a debug version of windows' quartz dll which is very useful if you want to test your stuff against windows' quartz. It would output extra debug information which you could use to debug stuff. I would have to do some digging to find it back again. I have also made a stand-alone codec for schroedinger last year, which falls in the 'intermediate filters' category. It's source is available at: http://www.diracvideo.org/git?p=direct-schro.git;a=tree;h=HEAD This is a very basic filter based on wine's directshow code and using the schroedinger open source codec to do the decoding and encoding (they're separate filters). In encoder.c there is also a beginning of a properties dialog, which might be useful if you need one for the gstreamer filter. Cheers, Maarten.

3 3

Re: possible NULL dereference?
by Joris Huizer 09 Apr '09

09 Apr '09

--- On Thu, 4/9/09, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > From: Paul Vriens <paul.vriens.wine(a)gmail.com> > Subject: Re: possible NULL dereference? > To: "Joris Huizer" <joris_huizer(a)yahoo.com> > Cc: wine-devel(a)winehq.org > Date: Thursday, April 9, 2009, 7:53 AM > Joris Huizer wrote: > > Looking at git commit > dcb3e52e2dfd0d6e494164932fb2b684d463a005, it seems, passing > a NULL size pointer to GetUserNameEx[AW] is likely to > crash. > > You may want to test whether Windows versions crash on > it, and check for it if needed. > > > > HTH, Joris > > > There is also another one (mentioned by Coverity) where > passing a NULL lpNameBuffer and a big enough nSize will > crash. I tested that one on W2K3 and this also crashes on > W2K3. > > I didn't test the NULL nSize however. > > If time permits I'll add some tests and comments in the > case of crashes. If somebody wants to be beat me to > it, be my guest. > > Out of curiosity, did you find this by visual inspection? > > -- Cheers, > > Paul. > Yea I just noticed this while skimming through, now and then I look at the latest changes on git. I assume Coverity doesn't complain as it noticed you don't test the nSize pointer in any code path, so it assumes you know what you're doing. That seems like a general problem - if it could pick up the WINAPI flag (explicitly different calling convention) and realize every argument is suspect, it would find all such problems as well; Such behavior would be desirable for library functions in general, except that different projects are likely to have very different requirements about when a function is a library function to be treated like that. Specifying "what is a library function" might already be supported or perhaps it could be requested as a generally useful feature? regards, Joris

1 0

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)
by Paul Vriens 09 Apr '09

09 Apr '09

Andreas Rosenberg wrote: > > ------------------------------------------------------------------------ > > Just had a look again on your resend: this doesn't seem correct: + if ( lpcchSize && lpcchSize ) I also think that your addition of _GetAccountNameFromTokenW is holding the committing of this patch back, especially because you don't seem to use that function. -- Cheers, Paul.

2 3

RE: advapi32/tests
by Andreas Rosenberg 09 Apr '09

09 Apr '09

Paul Vriens wrote: >And the subject of the mail should be a bit more than just "advapi32/tests". Oops, sry. Read the second mail after resending in the patch containing your first suggestions. But I'm a bit confused about the meaning of todo_wine. todo_wine discards output from failed tests, if I understood that correctly. Formerly I thought the output from tests should show things that fail on Wine, which are things that should be fixed in Wine. What is the difference of test wrapped by todo_wine and test not wrapped? Regards Andreas

2 1

i have itunes 7.60 successfully running on f10 kde 4.2
by AllenDavidNiven 09 Apr '09

09 Apr '09

i have itunes 7.60 successfully running on f10 kde 4.2 but when i plug my ipod touch into the usb port it just shows icon with arrow connecting to itunes but nothing happens even if i press button and on itunes itself the sync menu item is greyed out any patches i need to apply someplace ? may i re-imburse you for your time with paypal or western union thx -- Allen David Niven CEO GlobalFone 405 Lexington Avenue, 26th floor Chrysler Building New York, NY 10174 +1-646-428-0700 office AllenDavidNiven(a)GlobalFone.biz http://www.GlobalFone.biz INSTANT MESSAGING CONTACTS - NEVER EMAIL ME AT INSTANT MESSAGE ADDRESSES - ONLY USE GLOBALFONE ADDRESS msn id: AllenDavidNiven6(a)Hotmail.com yahoo id: AllenDavidNiven6(a)Yahoo.com aol-aim id: AllenDavidNiven6 gmail id: AllenDavidNiven(a)Gmail.com skype id: AllenDavidNiven

6 13

Re: [2/2] [wined3d] GLSL: enable load_np2fixup_constants (fixed)
by Stefan Dösinger 09 Apr '09

09 Apr '09

Am Donnerstag, 9. April 2009 01:47:33 schrieb Tobias Jakobi: > Fixed patch according to stefand's suggestions. > > Please disregard the old one and use this patch instead. Looks ok to me I guess

1 0

Re: advapi32/tests
by Paul Vriens 09 Apr '09

09 Apr '09

Andreas Rosenberg wrote: > Added a test to verify result of LookupAccountSid > > > > ------------------------------------------------------------------------ > > The test fails here: security.c:1599: Test failed: LookupAccountSidA() Expected account name: paul got: INTERACTIVE I guess this is the test I recommended you to add. If so and if it's meant to show the bug you should add a todo_wine for failing tests on Wine. -- Cheers, Paul.

1 0

Re: [3/6] d3d9: Store the FVF in the d3d9 vertex buffer
by Henri Verbeet 09 Apr '09

09 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > @@ -197,7 +197,6 @@ static HRESULT WINAPI IDirect3DVertexBuffer9Impl_GetDesc(LPDIRECT3DVERTEXBUFFER9 > pDesc->Usage = desc.Usage; > pDesc->Pool = desc.Pool; > pDesc->Size = desc.Size; > - pDesc->FVF = desc.FVF; > pDesc->Type = D3DRTYPE_VERTEXBUFFER; > } I think you're missing something here.

2 1

re: win87em: always return that a 8087 coprocessor is present. (try 2)
by Christian Costa 09 Apr '09

09 Apr '09

Installed variable has always the same value. What about removing it instead ? Bye, Christian > Message du 09/04/09 07:10 > De : "Rein Klazes" > A : "wine-patches" > Copie à : > Objet : win87em: always return that a 8087 coprocessor is present. (try 2) > > > --- > dlls/win87em.dll16/win87em.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/win87em.dll16/win87em.c b/dlls/win87em.dll16/win87em.c > index 35a04c4..d3fc96a 100644 > --- a/dlls/win87em.dll16/win87em.c > +++ b/dlls/win87em.dll16/win87em.c > @@ -45,7 +45,7 @@ struct Win87EmInfoStruct > */ > /* FIXME: Still rather skeletal implementation only */ > > -static BOOL Installed = 0; > +static BOOL Installed = 1; /* 8087 is installed */ > static WORD RefCount = 0; > static WORD CtrlWord_1 = 0; > static WORD CtrlWord_2 = 0; > -- > 1.6.2.1 > > > > >

1 0

Re: [5/6] d3d: Remove the format from index buffers
by Henri Verbeet 09 Apr '09

09 Apr '09

2009/4/9 Stefan Dösinger <stefan(a)codeweavers.com>: > + hr = IWineD3DDevice_SetIndices(This->wineD3DDevice, This->indexbuffer, > + WINED3DFMT_R16_UINT /* d3d7 uses uints */); The comment is inconsistent with the code (and probably redundant to begin with).

1 0

possible NULL dereference?
by Joris Huizer 09 Apr '09

09 Apr '09

Looking at git commit dcb3e52e2dfd0d6e494164932fb2b684d463a005, it seems, passing a NULL size pointer to GetUserNameEx[AW] is likely to crash. You may want to test whether Windows versions crash on it, and check for it if needed. HTH, Joris

2 1

Re: Added PulseAudio sound driver
by Michael Stefaniuc 09 Apr '09

09 Apr '09

NACK. remi.assailly(a)free.fr wrote: > I'm submitting the PulseAudio patch from Arthur Talyor. Guys, stop doing that as it doesn't increases the chance of the patch being accepted; quite the contrary. > As most distros have PulseAudio by default Wine should provide upstream > support. No, not really. winealsa.drv works just fine with PulseAudio too. > Both Fedora and Mandriva have included this work and it is reported to > work very well. As well as the ALSA driver. > I used latest patch from http://art.ified.ca/?page_id=40 > I just did a autoconf and autoheader. > > This feature has been confirmed by popular vote at > http://bugs.winehq.org/show_bug.cgi?id=10495 They should stop voting for a redundant feature. If they want to have it they should help make the patch *PERFECT*. That's about the only chance the patch has to get in. Just taking and old version of the winealsa.drv and replacing "ALSA" with "PULSE" doesn't cut it. And the patch already bitrotted. bye michael

3 4

Re: [2/3] ntdll: don't treat DOS paths starting with / as Unix paths
by Chris Robinson 09 Apr '09

09 Apr '09

On Monday 06 April 2009 6:58:31 pm Vincent Povirk wrote: > On Mon, Apr 6, 2009 at 8:53 PM, Chris Robinson <chris.kcat(a)gmail.com> wrote: > > Isn't that the python test's fault, then? Why can't c:\bin\sh exist? > > On a real windows system, it won't. It won't by default, but can't a user create it?

15 25

Re: wined3d: don't update the screen when gdi back buffers are unlocked
by Stefan Dösinger 08 Apr '09

08 Apr '09

Am Mittwoch, 8. April 2009 17:12:01 schrieb Vincent Povirk: > This should fix bug 15789. > And he tells me that he's too busy to send the change in, and I should do > it if I want it to happen soon. Well, the main reason is that I don't have the games in question to test the patch myself. The same problem occurs in RealizePalette by the way. Otherwise the patch looks good to me

1 0

Re: wined3d: Use OpenGL vendor and renderer to pick driver and description.
by Roderick Colenbrander 08 Apr '09

08 Apr '09

Hi John, First of all this are basically two changes in one patch. Keep the vendor one separated from the device string. Second the opengl renderer string shouldn't be directly returned. In short d3d apps can query the pci id and opengl doesn't expose it (we aren't allowed to use /proc for card detection or so) and for that reason we 'estimate' what card is used based on the gpu capabilities (supported opengl extensions) and later on also the renderer string to refine the result a bit. For this reason the renderer string doesn't have to be the same as the pci id that we report. There are still some changes I have to make to the code and add a device string database. Roderick On Wed, Apr 8, 2009 at 8:40 AM, John Whitlock <John-Whitlock(a)ieee.org>wrote: > Use the OpenGL renderer for the device description > Use the OpenGL vendor to pick an appropriate XP device driver > Fixes bug 15839 > > The registry overrides seemed to make devs uncomfortable, so I'm trying > submitting without them. They are easy enough to add on top of this > change, > if the need arises in the future. > > > > >

3 2

Re: Added PulseAudio sound driver
by remi.assailly＠free.fr 08 Apr '09

08 Apr '09

Let's see. If distros include this driver, they >> This feature has been confirmed by popular vote at >> http://bugs.winehq.org/show_bug.cgi?id=10495 >They should stop voting for a redundant feature. Nobody submitted to wine-patches before, I prefer let Alexandre chose what he wants to do with it. > If they want to have it they should help make the patch *PERFECT*. That's about the only chance >the patch has to get in. So, while your work is not perfect but working you never try to submit it. Direct X support is not *PERFECT*, wine is not *PERFECT*, but you can use it and improve it.

1 0

Re: Added PulseAudio sound driver
by Marcus Meissner 08 Apr '09

08 Apr '09

On Wed, Apr 08, 2009 at 09:16:17PM +0200, remi.assailly(a)free.fr wrote: > Hi all, > > I'm submitting the PulseAudio patch from Arthur Talyor. > As most distros have PulseAudio by default Wine should provide upstream support. > Both Fedora and Mandriva have included this work and it is reported to work very well. > > I used latest patch from http://art.ified.ca/?page_id=40 > I just did a autoconf and autoheader. > > This feature has been confirmed by popular vote at http://bugs.winehq.org/show_bug.cgi?id=10495 The actual driver is missing. And split it into more pieces. (winecfg seperate for instance). Ciao, Marcus

1 0

Re: Added PulseAudio sound driver
by Nikolay Sivov 08 Apr '09

08 Apr '09

remi.assailly(a)free.fr wrote: > Hi all, > > I'm submitting the PulseAudio patch from Arthur Talyor. > As most distros have PulseAudio by default Wine should provide > upstream support. > Both Fedora and Mandriva have included this work and it is reported to > work very well. > > I used latest patch from http://art.ified.ca/?page_id=40 > I just did a autoconf and autoheader. > > This feature has been confirmed by popular vote at > http://bugs.winehq.org/show_bug.cgi?id=10495 > > Rémi > > Changelog : > added PulseAudio sound driver > Thanks to Arthur Talyor You've probably forgot to do "git add" for new files.

1 0

Re: [ 1/3] kernel32/tests: Add tests for GetVolumeInformationA and volume enumeration
by Alexandre Julliard 08 Apr '09

08 Apr '09

Guy Albertelli <galberte(a)neo.rr.com> writes: > BOOL found = FALSE; > > + buffer = VirtualAlloc( NULL, buflen, MEM_COMMIT|MEM_RESERVE, PAGE_READWRITE ); HeapAlloc is preferable. > + /* test the result of opening a volume id (no trailing \) */ > + /* this should work. It provides access to the disk volume */ > + /* starting with the first sector */ > + Volume[eos] = 0; > + hFile = CreateFileA( Volume, GENERIC_READ | GENERIC_WRITE, > + FILE_SHARE_READ | FILE_SHARE_WRITE, > + NULL, OPEN_EXISTING, > + FILE_ATTRIBUTE_NORMAL | FILE_FLAG_NO_BUFFERING, NULL ); > + /* wine currently returns 5 (ERROR_ACCESS_DENIED) for normal */ > + /* volume ids (normal drive letters, ex C: -> ..\drive_c */ > + /* **cause: side effect of opening directory */ > + /* ** gets STATUS_INVALID_PARAMETER from NtCreateFile */ > + /* ** which comes from server(create_file) */ > + /* ** which comes from server(open_fd) because the open */ > + /* ** either open writable or readonly gives EISDIR. */ > + /* ** Then NtCreateFile returns status 0xC00000BA */ > + /* ** (STATUS_FILE_IS_A_DIRECTORY which is then */ > + /* ** changed to ERROR_ACCESS_DENIED */ > + /* The only time wine works is when the unix translation is a */ > + /* special file (ex: /dev/sdx). If that special device is */ > + /* readable (or r/w) for the user then the open succeeds. This */ > + /* allows the picture keychain to work if I set its permissions */ > + /* correctly. */ > + todo_wine ok(hFile != INVALID_HANDLE_VALUE && GetLastError() == ERROR_SUCCESS, > + "CreateFileA did not work, last error %u for device <%s> on volume <%s>\n", > + GetLastError(), Dev_Name, Volume ); This will fail on many Windows platforms too, you can't always open the raw device. And the tests are not the appropriate place for documenting Wine implementation details that are subject to change. > + if (ret) > + { > + trace( "First 64 bytes of volume <%s>, for device <%s>\n", > + Volume, Dev_Name ); > + dumpmem( buffer, 64 ); > + if (pGetVolumeInformationA) > + { > + /* need the traling \ for the API */ > + Volume[eos] = '\\'; > + ret = pGetVolumeInformationA(Volume, vol_name_buf, > + vol_name_size, NULL, NULL, NULL, fs_name_buf, > + fs_name_len); > + ok(ret, "GetVolumeInformationA failed, root=%s, last error %u\n", > + Volume, GetLastError()); > + if (ret && strcmp(fs_name_buf, "NTFS")==0) > + { > + /* If the filesystem is NTFS, then NTFS is in the */ > + /* first few bytes of the first block of the fs */ > + p = (char *)(buffer + 3); > + ok(strncmp(p, "NTFS", 4)==0, > + "NTFS file system does not match block read\n"); > + } This will probably never work on Wine, what's the point of that test? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: perform case-insensitive FOURCC comparison of built-in video codecs
by Dmitry Timoshkov 08 Apr '09

08 Apr '09

<Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > +#define compare_fourcc(fcc1, fcc2) (((fcc1)^(fcc2))&~0x20202020L) You ignore case even for mixed cased fourcc codes, but test only 2 cases: all lower/upper case codes, please test that cases too. -- Dmitry.

1 0

Loading of Mingw Provided .sys files
by Uwe Bonnes 08 Apr '09

08 Apr '09

Hello, trying to use the supplied or the mingw (cross) compiled libusb0.sys from sourceforge with the USB enabled tree from http://git.etersoft.ru/people/lav/packages/wine.git loading libusb0.sys fails: trace:winedevice:ServiceMain starting service L"libusb0" trace:winedevice:load_driver loading driver L"c:\\windows\\system32\\drivers\\libusb0.sys" trace:winedevice:load_driver_module name L"c:\\windows\\system32\\drivers\\libusb0.sys" module (nil) trace:winedevice:ServiceMain driver L"libusb0" failed to load trace:winedevice:ServiceMain service L"libusb0" stopped Using some other USB driver instead of libusb0.sys at least loads: trace:winedevice:load_driver loading driver L"c:\\windows\\system32\\drivers\\ezusb.sys" trace:winedevice:load_driver_module name L"c:\\windows\\system32\\drivers\\ezusb.sys" module 0x81340000 trace:winedevice:load_driver_module L"c:\\windows\\system32\\drivers\\ezusb.sys": relocating from 0x10000 to 0x81340000 trace:winedevice:load_driver_module name L"NTOSKRNL.EXE" module 0x84b70000 trace:winedevice:load_driver_module name L"HAL.DLL" module 0x84590000 trace:winedevice:load_driver_module name L"USBD.SYS" module 0x84580000 trace:winedevice:init_driver trace:winedevice:init_driver init done for L"libusb0" obj 0x84c0a560 The failure happens in program/winedevices/devices.c: static HMODULE load_driver_module( const WCHAR *name ) { IMAGE_NT_HEADERS *nt; const IMAGE_IMPORT_DESCRIPTOR *imports; size_t page_size = getpagesize(); int i, delta; ULONG size; --> HMODULE module = LoadLibraryW( name ); if (!module) return NULL; LoadLibraryW loads the file and then calls the DriverEntry of libusb0: NTSTATUS DDKAPI DriverEntry(DRIVER_OBJECT *driver_object, UNICODE_STRING *registry_path) { int i; DEBUG_MESSAGE("DriverEntry(): loading driver"); /* initialize global variables */ debug_level = LIBUSB_DEBUG_MSG; /* initialize the driver object's dispatch table */ for(i = 0; i <= IRP_MJ_MAXIMUM_FUNCTION; i++) { driver_object->MajorFunction[i] = dispatch; } driver_object->DriverExtension->AddDevice = add_device; driver_object->DriverUnload = unload; return STATUS_SUCCESS; } While loading, the protection is set to 0014:trace:virtual:VIRTUAL_DumpView 0x68640000 - 0x68640fff c-r-- and driver_object is in the 0x68640000 pages and so writing to driver_object->MajorFunction[i] through an exception and the function fails. I guess libusb0.sys works on WIN32, so here our loader does something wrong or perhaps is not bug-to-bug compatible. Any fixes? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Re: win87em: always return that a 8087 coprocessor is present.
by Alexandre Julliard 08 Apr '09

08 Apr '09

Rein Klazes <wijn(a)online.nl> writes: > @@ -203,9 +203,9 @@ void WINAPI _fpMath( CONTEXT *context ) > context->Eax &= ~0xffff; /* set AX to 0 */ > break; > > - case 11: /* just returns the installed flag in DX:AX */ > + case 11: /* returns in ax whether a 8087 coprocessor is present, say yes */ > context->Edx &= ~0xffff; /* set DX to 0 */ > - context->Eax = (context->Eax & ~0xffff) | Installed; > + context->Eax = (context->Eax & ~0xffff) | 1; Should you set Installed to 1 instead? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/5] resend include: bring in6_addr into line with the MS definition
by Kai Blin 08 Apr '09

08 Apr '09

On Tuesday 07 April 2009 13:32:54 Jeff Latimer wrote: > The definition of in6_addr is not fully expanded as yet. This patch > adds the extra definition. This version is based on the Vista PSDK and > places the definition in in6addr.h. Is there any reason you're putting this into an extra header? The PSDK I have around keeps this in ws2ipdef.h Other than that, thanks. I've been working on a similar patch but got sidetracked. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: NTFS filesystem features -> WONTFIX?
by James Mckenzie 07 Apr '09

07 Apr '09

Kai Blin <kai.blin(a)gmail.com> wrote on April 7th: >Subject: Re: NTFS filesystem features -> WONTFIX? > >On Tuesday 07 April 2009 04:21:37 Vitaliy Margolen wrote: > >> - Implement missing functionality - will most likely be nearly impossible >> without driver support for special features. Or have to be emulated by Wine >> (then why not for any other FS?) > >We can probably get away with 80% of the apps only using 20% of the features, >as usual. I guess that apps are mostly interested in ACLs, which could be >mapped to POSIX acls, stored in file attributes or some database or simply >faked. Samba does this, I don't see why we couldn't. > Can we use Samba code in Wine to make this a reality? James McKenzie

3 2

Single login for Wine sites?
by David Gerard 07 Apr '09

07 Apr '09

What's standing in the way of unified login for the various Wine sites (appdb, wiki, Bugzilla)? Is there anyone running any of these sites who doesn't consider single unified login a good idea? - d.

5 6

Status of "USB device support in wine"
by Uwe Bonnes 07 Apr '09

07 Apr '09

Hello, Alexander Morozov <amorozov(a)etersoft.ru> did a large redesign after Alexandre's remarks from 07 October 2008. What is still needed to include this functionality? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: [3/3] wined3d: Free allocated strings for driver and description
by Henri Verbeet 07 Apr '09

07 Apr '09

2009/4/7 John Whitlock <John-Whitlock(a)ieee.org>: > + HeapFree(GetProcessHeap(), 0, wined3d_settings.video_driver); > + HeapFree(GetProcessHeap(), 0, wined3d_settings.video_description); This should be part of the first patch. (And if you're going to resend anyway, I think it makes more sense to do the autodetection first, and the registry override afterwards).

2 1

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa
by Alexandre Julliard 07 Apr '09

07 Apr '09

Jeff Latimer <lats(a)yless4u.com.au> writes: > @@ -55,6 +55,9 @@ > ok ( cond tmp, msg, GetCurrentThreadId(), err); \ > } while (0); > > +/* Function pointers */ > +static HMODULE hws2_32 = 0; > +static PCTSTR (WINAPI *pInetNtop)(int,LPVOID,LPTSTR,size_t) = 0; You can't use TCHAR types in tests. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] wined3d: Registry override for driver and description.
by Roderick Colenbrander 07 Apr '09

07 Apr '09

Hi John, Some suggestions (I think I also told Mirek at the time). Initialize the strings to NULL in wined3d_main.c where the wined3d_settings struct is initialized. Roderick On Tue, Apr 7, 2009 at 8:02 AM, John Whitlock <John-Whitlock(a)ieee.org>wrote: > This patch is from Mirek Slugen <thunder.m(a)email.cz>. See > http://www.winehq.org/pipermail/wine-patches/2009-March/070766.html > > This patch set is for bug 15839 > > > > > > > > >

1 0

Re: [2/3] wined3d: Use OpenGL for default description and OpenGL vendor for driver.
by Roderick Colenbrander 07 Apr '09

07 Apr '09

Hi John, Unfortunately this patch isn't correct. If we report a different string we have to report the right strings like in case of the vendor the right driver name e.g. for Nvidia that is 'nv4_disp.dll'. In case of the board name we also need to report the right string (the name of the board we emulate). It is quite a bit more work to get this all right. Roderick

1 0

Re: wined3d: Defaults and overrides for driver and description (bug #15839)
by Austin English 07 Apr '09

07 Apr '09

On Tue, Apr 7, 2009 at 12:13 AM, John Whitlock <John-Whitlock(a)ieee.org> wrote: > wined3d: Defaults and overrides for driver and description > > Use the OpenGL renderer for the default adapter description and the OpenGL > vendor to create the default adapter driver. Allow overriding both from > registry values. > > This fixes bug 15839. Please only one patch per e-mail. > The first patch should be credited to Mirek Slugeň (thunder.m(a)email.cz) Change the patch itself to have that contact information. -- -Austin

1 0

Re: [2/3] ntdll: don't treat DOS paths starting with / as Unix paths
by Alexandre Julliard 07 Apr '09

07 Apr '09

Vincent Povirk <madewokherd+8cd9(a)gmail.com> writes: > This patchset should fix bug 15883. Support for Unix paths is a useful feature, you can't just remove it. -- Alexandre Julliard julliard(a)winehq.org

5 7

winemenubuilder: disable debug output for .desktop files
by Joerg-Cyril.Hoehle＠t-systems.com 06 Apr '09

06 Apr '09

Hi, Austin English wrote: >> I don't think it's safe to assume that stderr will be lost if the >> program was started from a .desktop file. >The majority of users are double clicking .desktop files to start >their applications. Where do you see stderr going to in this case? It is centralised to $HOME/.xsession-errors (in Ubuntu at least). You can tell users to look there when their app crashes. The only bug IMHO -- and it's not in wine -- is that some entity in Gnome or KDE limits output to 200KB and I found no way to reset that. I.e. once this file has grown that large, output is lost until you log out. Obviously this mechanism was not expected to receive as many output as *some* wine apps produce. Alternatively, with your desktop's icon/menu editor, you can have a terminal window created for the application when it starts. Then debug output goes there. I once did that for one application which crashed at start from times to times, to get visual feedback. >Converting the fixme's to trace's/warn's may be a viable option. I think it would be good if there were semantics behind fixme & warn that users and developers can rely upon. Random conversion just to quiet messages is not nice when trying to make apps run. Of course, the pragmatics already lead to the (useful) FIXME once idiom. This winemenubuilder distinction seems superfluous. All it seemingly boils do is that some people plead for a change of wine behaviour to "by default, produce zero output. If you want some, set $WINEDEBUG (since you're in a shell anyway), because the majority of users doesn't care". I don't vote for that, since I value post-mortem analysis. Yet I admit I've been thinking myself about using WINEDEBUG=-xyz for *some* verbose apps which nevertheless work fine: once you've seen the output once, further runs are not interesting anymore. Regards, Jörg Höhle

2 1

Re: comctl32/tab: Draw hottracked tab button properly (resent)
by Vitaliy Margolen 06 Apr '09

06 Apr '09

Nikolay Sivov wrote: > With patch this time. > > This makes hottracked tab button look like it does in native. > Bounding rectangle is still wrong but it's another problem, > anyway now it looks better. Maybe you should fix that rectangle first? There were few differences I recall in size of the update regions between Wine and native. The drawing errors could be the result of those differences. Vitaliy.

2 1

Patch regarding GetUserProfileDirectory
by Andreas Rosenberg 06 Apr '09

06 Apr '09

Hi! I sent a patch regarding GetUserProfileDirectory last Monday. I didn't receive any comments/critics as on my previous attempts. The patch doesn't appear in wine-cvs, so I suppose something is still not correct. Can anybody give me a clue, please? Regards Andreas

1 0

Re: RFC: Resource editing and validation
by Reece Dunn 06 Apr '09

06 Apr '09

2009/4/6 Warren Dumortier <nwarrenfl(a)gmail.com>: > Yeah, why not. > > But that was not really hard at all, if you use a calculator to > calculate x and y coords. I could easily change winecfg for my patch. > IMO it is not really needed as winecfg doesn't change a lot... The issue is not so much that winecfg changes a lot or not. All the other dialogs are affected across other resources. Sure, you can use a calculator. However, you still need to update all the controls in the dialog you are editing, to move them to their new positions. In addition to this, the controls on the various dialogs (e.g. on winecfg, but others such as the Browse For Network Share dialog are affected as well) are inconsistently positioned. The Browse For Network Share dialog does not have 50x14 sized command buttons (OK, Cancel) -- this makes them look squashed up, especially when using themes. On the winecfg desktop tab, the "Color:" and related labels are incorrectly spaced from the control below them. This causes them to look bunched up. Also, some of the buttons are not 14 DLUs high -- causing them to look scrunched up -- and the spacing between controls is 5 DLUs. As a result of all of this (and other layout rules), the dialog looks inconsistent and unprofessional. Having an editor that takes care of this means that you get a consistent and more professional look that will also work when you have theming turned on. It also means that you don't have to spend hours with a calculator adjusting control positions by hand. Doing that is very time consuming -- I know, as I have done this, but using Visual Studio dialog guidelines. When editing a dialog, I want something that does this for me, so I don't have to worry about positioning and spend a long time fiddling with guidelines or (x, y) coordinates -- especially when making several changes to the dialogs. I also want to revive my "Usability: WineCfg Part 1 -- Desktop Integration tab" thread, and expand this to other areas of the dialog and to wine as a whole. Having the tools and infrastructure in place to do this -- especially when you consider adjusting the dialogs across the different language resources -- makes the whole thing easier. - Reece

1 0

Re: urlmon/tests: Handle certificate verification error
by Alexandre Julliard 06 Apr '09

06 Apr '09

"Ge van Geldorp" <ge(a)gse.nl> writes: > Some W2K3 boxes have problems verifying the certificate during the https > test. Just retrying the verification once fixes this. > > Changelog: > urlmon/tests: Handle certificate verification error This is causing a failure here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so protocol.c && touch protocol.ok protocol.c:444: Test succeeded inside todo block: expected ReportProgress_SENDINGREQUEST make[2]: *** [protocol.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

User forum thread: "how can we improve WINE?"
by David Gerard 06 Apr '09

06 Apr '09

http://forum.winehq.org/viewtopic.php?t=4403 Some highly impractical ideas, but certainly having the users throw ideas around should inspire wine-devel (and Codeweavers) :-) - d.

7 15

Re: [1/3] secur32: Implement GetUserNameEx(NameSamCompatible)
by Alexandre Julliard 06 Apr '09

06 Apr '09

"Ge van Geldorp" <ge(a)gse.nl> writes: > @@ -1055,15 +1056,86 @@ BOOLEAN WINAPI GetComputerObjectNameW( > BOOLEAN WINAPI GetUserNameExA( > EXTENDED_NAME_FORMAT NameFormat, LPSTR lpNameBuffer, PULONG nSize) > { > - FIXME("%d %p %p\n", NameFormat, lpNameBuffer, nSize); > - return FALSE; > + BOOLEAN rc; > + LPWSTR bufferW = NULL; > + ULONG sizeW = *nSize; > + TRACE("(%d %p %p)\n", NameFormat, lpNameBuffer, nSize); > + if (lpNameBuffer) { > + bufferW = HeapAlloc(GetProcessHeap(), 0, sizeW * sizeof(WCHAR)); > + if (bufferW == NULL) { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + } > + rc = GetUserNameExW(NameFormat, bufferW, &sizeW); > + if (rc && bufferW) { > + ULONG len = WideCharToMultiByte(CP_ACP, 0, bufferW, -1, NULL, 0, NULL, NULL); > + WideCharToMultiByte(CP_ACP, 0, bufferW, -1, lpNameBuffer, *nSize, NULL, NULL); > + *nSize = len; > + } You need to check for buffer overflows and return the appropriate error, preferably with test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

GSoC students, check that you're subscribed to updates to your proposal
by Kai Blin 06 Apr '09

06 Apr '09

Hi folks, it seems that the current GSoC webapp does not subscribe you to updates on your proposals automatically. Please log in there and make sure that you're subscribed. Otherwise you might miss comments by the mentors, which will reflect negatively on your proposal. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [urlmon/tests] Fix a test by using a better default registry key
by Nicolas Le Cam 06 Apr '09

06 Apr '09

Hi Paul, > dlls/urlmon/tests/misc.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/dlls/urlmon/tests/misc.c b/dlls/urlmon/tests/misc.c > index 7702e1e..b77924e 100644 > --- a/dlls/urlmon/tests/misc.c > +++ b/dlls/urlmon/tests/misc.c > @@ -851,7 +851,10 @@ static void test_url_action(IInternetSecurityManager > *secmgr, IInternetZoneManag > HKEY hkey; > HRESULT hres; > > - res = RegOpenKeyA(HKEY_LOCAL_MACHINE, > + /* FIXME: HKEY_CURRENT_USER is most of the time the default but this > can be changed on a system. > + * The test should should be changed to cope with that, if need be. Should should ? > + */ > + res = RegOpenKeyA(HKEY_CURRENT_USER, > "Software\\Microsoft\\Windows\\CurrentVersion\\Internet > Settings\\Zones\\3", &hkey); > if(res != ERROR_SUCCESS) { > ok(0, "Could not open zone key\n"); -- Nicolas Le Cam

1 0

Re: [1/10] d3d8, d3d9: Don't rely on the wined3d buffer type
by Henri Verbeet 06 Apr '09

06 Apr '09

2009/4/4 Stefan Dösinger <stefan(a)codeweavers.com>: > + pDesc->Usage = pDesc->Usage; > + pDesc->Pool = pDesc->Pool; > + pDesc->Size = pDesc->Size; This is just silly.

2 1

Re: [5/5] WineD3D: Merge buffer creation methods
by Henri Verbeet 05 Apr '09

05 Apr '09

2009/4/4 Stefan Dösinger <stefan(a)codeweavers.com>: > - hr = IWineD3DDevice_CreateBuffer(This->wined3d_device, &wined3d_desc, > - data ? data->pSysMem : NULL, (IUnknown *)object, &object->wined3d_buffer); > + hr = IWineD3DDevice_CreateBuffer(This->wined3d_device, 0 /* fvf */, > + WINED3DFMT_VERTEXDATA, WINED3DPOOL_DEFAULT, &wined3d_desc, > + data ? data->pSysMem : NULL, (IUnknown *)object, 0 /* SharedHandle */, &object->wined3d_buffer); Please don't introduce things like "SharedHandle" into CreateBuffer(). We should get rid of that for the other wined3d methods as well actually, it's never used anywhere, and it will probably be quite a while before we will, if ever. (DXGI and D3D9 in Vista actually allow this to be used, but I don't think it's very useful to have this at the moment). > + memset(&wined3d_desc, 0, sizeof(wined3d_desc)); > + wined3d_desc.byte_width = Size; > + wined3d_desc.usage = Usage & WINED3DUSAGE_MASK; That's not what the "usage" field was meant for. I don't think you should involve the d3d10 style CreateBuffer() in this at this point. However, if you do, it should be a separate patch for merging CreateVertexBuffer() and CreateIndexBuffer(), and *after* you've removed the format and FVF parameters. In that case you should use wined3d_buffer_desc properly, ie. pay attention to cpu_access_flags, etc. and using bind_flags instead of buffer_type_hint.

1 0

Re: [4/10] WineD3D: Merge IWineD3DIndexBuffer and IWineD3DBuffer
by Henri Verbeet 05 Apr '09

05 Apr '09

2009/4/4 Stefan Dösinger <stefan(a)codeweavers.com>: > + WINED3DRESOURCETYPE WineD3DRType; > TRACE("(%p)->(%d, %d, %d, %08x, %d, %d)\n", This, Adapter, DeviceType, AdapterFormat, Usage, RType, CheckFormat); > > + switch(RType) { > + case D3DRTYPE_VERTEXBUFFER: > + case D3DRTYPE_INDEXBUFFER: > + WineD3DRType = WINED3DRTYPE_BUFFER; > + break; > + > + default: > + WineD3DRType = RType; > + break; > + } > + This should have been in the first patch. The same goes for the other changes touching WINED3DRESOURCETYPE.

1 0

Re: [3/10] WineD3D: Merge indexbuffer and buffer implementations
by Henri Verbeet 05 Apr '09

05 Apr '09

Personally I would've eliminated the implementation differences first (the main difference is when the data is copied, unmap vs. preload), and then just killed IWineD3DIndexBufferImpl once they were the same from an implementation point of view. Eg., you can ignore the conversion if you can prove it never happens for index buffers. > - desc->FVF = This->fvf; > + > + /* Temporary hack */ > + if(This->buffer_type_hint == GL_ARRAY_BUFFER_ARB) { > + desc->FVF = This->fvf; > + } This is extremely ugly. > + /* No conversion is needed on index buffers for now */ > + if (This->resource.format_desc->format != WINED3DFMT_VERTEXDATA) return FALSE; > + This is redundant, buffer_find_decl() will never be called for index buffers. Related to that, the bind_count field now has an ambiguous name, it only refers to how often the buffer is bound as vertex data, not index data, or any other type of potential binding (eg. stream output in the future). > + if(This->buffer_type_hint == GL_ELEMENT_ARRAY_BUFFER_ARB) { I realise wined3d is pretty much unsalvageable in terms of style consistency, but buffer.c is fairly consistent at the moment. I don't care too much about style differences, but I figured I'd mention it.

1 0

new refcount for d3d ??
by paulo lesgaz 05 Apr '09

05 Apr '09

Hello, looking at the web page: http://www.nabble.com/d3d:-Bug-in-handling-of-depth-stencil-surfaces,-and-p… I read that there are problems with the ref count in d3d wine implementation. Does there exist any plan to fix it? Or can we try to implement the Jim's idea about it? David

4 6

Re: winemenubuilder: disable debug output for .desktop files
by Vincent Povirk 04 Apr '09

04 Apr '09

On Fri, Apr 3, 2009 at 4:05 PM, Vincent Povirk <madewokherd+8cd9(a)gmail.com> wrote: > I'll work on a patch for the FIXME thing. Turns out this is not "fairly easy" but actually "incredibly difficult". We have a fallback case at http://source.winehq.org/source/include/wine/debug.h#L133 with a macro that returns a statement that ends in a function call, omitting the arguments and semicolon. This allows us to do FIXME_(channel)("message\n");. I can handle this in the other cases (where the macro result ends in a macro that takes arguments), but I can't see a way to create a static variable in a statement that ends in a function call that we only execute sometimes. Vincent Povirk

3 2

urlmon/misc test and the use of URLZONEREG_DEFAULT
by Paul Vriens 04 Apr '09

04 Apr '09

Hi, Just build me a fresh W2K3 box with SP2 and all updates (including IE7). I get some errors when I run winetest: urlmon:misc misc.c:884: Test failed: (1400) policy=3, expected 0 misc.c:884: Test failed: (1e05) policy=10000, expected 20000 This particular test test_url_action() checks the registry values under HKLM and then checks with IInternetZoneManager_GetZoneActionPolicy() if it gets the same result. Obviously that failed in my case. It turns out that the returned value came from HKCU and not from HKLM. So the question is, does somebody now what URLZONEREG_DEFAULT defaults to? HKCR or HKLM and is this always the same or are there circumstances that make the default different. I guess I could write a test that checks both HKLM and HKCR and directly modifies the registry values in both hives to see what IInternetZoneManager_GetZoneActionPolicy() is using. Ideas, thoughts? -- Cheers, Paul.

2 4

Re: [2/2] shell32: Define PT_FOLDERW.
by Austin English 04 Apr '09

04 Apr '09

On Sat, Apr 4, 2009 at 6:59 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Define PT_FOLDERW in pidl.h to complete this series. You're changing the indent of some of the defines. If you're going to change some, change them all to make them consistent (PT_COMP has two tabs). -- -Austin

2 3

Re: 'Interactive' tests on Windows 2003
by Ge van Geldorp 04 Apr '09

04 Apr '09

From: "James Hawkins" <truiken(a)gmail.com> > On Fri, Jun 13, 2008 at 8:40 AM, Francois Gouget <fgouget(a)free.fr> wrote: > > > > Someone asked to check which tests require interaction when running in > > my Windows 2003 VM. However I cannot find the corresponding email (it > > might have been on irc), so I'm sending this data to the list. > > > > So the only interaction that was needed was caused by this IE > > security dialog: > > > > Content within this application coming from the Web site listed > > below is being blocked by Internet Explorer Enhanced Security > > Configuration. > > > > > > Only three tests were impacted: > > * mshtml_test dom > > -> 1508 tests run but 0 failures happened when just closing the > > dialog. > > > > * mshtml_test script (about:security_mshtml_test.exe) > > -> 21 tests run and 13 failures if the dialog is just closed, and 0 > > failures if mshtml_test is manually added to the 'allowed' list. > > > > * urlmon_test misc > > -> 923 tests run but 0 failures if the dialog is just closed. > > > > > > When run by winetest these tests just time out though. > > > > Thanks Francois (I asked on IRC a while back). I get these dialogs in > 2k3 as well. Do you think we should add a check for > winetest_interactive before the calls that bring up the permission > dialog? If anyone else knows of a better way, let us know. Actually, the interactive test is already there: http://www.winehq.org/pipermail/wine-cvs/2009-January/051706.html http://www.winehq.org/pipermail/wine-cvs/2009-January/051707.html Ge.

1 0

Re: gdi32/enhmfdrv: Actaully save the state in SaveDC and RestoreDCin the metafile
by Dmitry Timoshkov 04 Apr '09

04 Apr '09

It would be cleaner to check for GDI_NO_MORE_WORK in SaveDC/RestoreDC instead of duplicating their code. -- Dmitry.

2 1

Re: winemenubuilder: disable debug output for .desktop files
by Vincent Povirk 03 Apr '09

03 Apr '09

On Fri, Apr 3, 2009 at 4:09 PM, Austin English <austinenglish(a)gmail.com> wrote: > Why couldn't you simply use a second WINEDEBUG="fixme+all,err+all" to > override the variable in the .desktop file? The command is "env WINEPREFIX="..." WINEDEBUG=-all ...". No matter what I set WINEDEBUG to when I start that, wine will see a WINEDEBUG value of -all. Vincent Povirk

2 1

Re: winemenubuilder: disable debug output for .desktop files
by Vincent Povirk 03 Apr '09

03 Apr '09

I'm not sure if this is a good idea. I don't think it's safe to assume that stderr will be lost if the program was started from a .desktop file. If default debug output slows anything down noticeably, that should probably be fixed. Vincent Povirk On Fri, Apr 3, 2009 at 2:40 PM, Austin English <austinenglish(a)gmail.com> wrote: > Users aren't running in a terminal, so debug output only slows things down. > > -- > -Austin > > > >

2 3

Windows 7
by Fred . 03 Apr '09

03 Apr '09

I can put Windows XP, Vista, 2003, 2008. But not Windows 7.

5 9

Re: OpenBSD configure fix for cups
by Alexandre Julliard 03 Apr '09

03 Apr '09

Toni Spets <toni.spets(a)gmail.com> writes: > @@ -1221,7 +1221,7 @@ if test "x$with_cups" != "xno" > then > ac_save_CPPFLAGS="$CPPFLAGS" > ac_cups_cflags=`cups-config --cflags 2>/dev/null` > - ac_cups_libs=`cups-config --ldflags 2>/dev/null` > + ac_cups_libs=`cups-config --ldflags --libs 2>/dev/null` > CPPFLAGS="$CPPFLAGS $ac_cups_cflags" I'm afraid we can't do that, cups-config --libs returns a lot of crap that will break the build on many platforms. You should fix the OpenBSD libcups build to import the needed libraries. -- Alexandre Julliard julliard(a)winehq.org

1 0

Registry keys for serial ports
by Stefan Leichter 03 Apr '09

03 Apr '09

Hello Alexandre, you said in http://www.winehq.org/pipermail/wine-devel/2008-November/070691.html that registry entries for the serial ports should be created from the information received from hal. i 'm planing to implement this code. But before i start coding i like to know where the code should be created. Should the code go into kernel32/oldconfig.c, should i start creating serenum.sys is there any other place? Bye Stefan

2 1

Wine registry question
by Damjan Jovanovic 03 Apr '09

03 Apr '09

Hi I've noticed that Wine doesn't merge HKCU\Classes\Root into HKCR (http://bugs.winehq.org/show_bug.cgi?id=17019). Is this for compatibility with older Windows versions, or is it a Wine bug? Damjan Jovanovic

2 2

Re: (resubmit) user32: In COMBO_WindowPosChanging() do not change the height of the the dropped rectangle, if the new height is too small
by Alexandre Julliard 03 Apr '09

03 Apr '09

Rein Klazes <wijn(a)online.nl> writes: > Fixes bug #17695 > --- > dlls/user32/combo.c | 6 ++-- > dlls/user32/tests/combo.c | 46 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 49 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so combo.c && touch combo.ok combo.c:143: Tests skipped: Invalid Marlett font heights combo.c:143: Tests skipped: Invalid Marlett font heights combo.c:377: Test succeeded inside todo block: clientrect height is 24 vs 24 combo.c:377: Test succeeded inside todo block: clientrect height is 24 vs 24 make[2]: *** [combo.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something
by Joris Huizer 02 Apr '09

02 Apr '09

--- On Thu, 4/2/09, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > From: Nikolay Sivov <bunglehead(a)gmail.com> > Subject: Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something > To: wine-devel(a)winehq.org, joris_huizer(a)yahoo.com > Date: Thursday, April 2, 2009, 2:04 PM > > Joris Huizer wrote: > Hi, Joris. Thanks for spotting this, but changes you've > made will fail on Windows. I've just sent a corrected > version with one test more. > Here it is if you're interested: > http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html > > No problem :-) Sorry I didn't test with Windows just as I don't have it available; I wasn't sure what would be the proper action, to send a best-guess patch or personal email - any ideas on this in general? regards, Joris

2 1

Re: [1/4]winemaker: winresrc.h is the right name in actual wine(try10)
by Austin English 02 Apr '09

02 Apr '09

On Thu, Apr 2, 2009 at 2:58 PM, Dawncrow <webmaster(a)dawncrow.de> wrote: > --- > tools/winemaker | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > > > > > Your patch lacks your real name. -- -Austin

2 1

Re: include: Add declaration of sockaddr_storage to winsock2.h.
by Alexandre Julliard 02 Apr '09

02 Apr '09

Rob Shearman <robertshearman(a)gmail.com> writes: > @@ -437,6 +437,18 @@ typedef struct _CSADDR_INFO { > } CSADDR_INFO, *PCSADDR_INFO, *LPCSADDR_INFO; > #endif > > +#define _SS_MAXSIZE 128 > +#define _SS_ALIGNSIZE (sizeof(__int64)) > +#define _SS_PAD1SIZE (_SS_ALIGNSIZE - sizeof(short)) > +#define _SS_PAD2SIZE (_SS_MAXSIZE - 2 * _SS_ALIGNSIZE) > + > +typedef struct WS(sockaddr_storage) { > + short ss_family; > + char __ss_pad1[_SS_PAD1SIZE]; > + __int64 __ss_align; > + char __ss_pad2[_SS_PAD2SIZE]; > +} SOCKADDR_STORAGE, *PSOCKADDR_STORAGE, *LPSOCKADDR_STORAGE; This is apparently in ws2def.h in the Vista SDK. Also the #defines need a WS prefix too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] resend include: bring in6_addr into line with the MS definition
by Alexandre Julliard 02 Apr '09

02 Apr '09

Jeff Latimer <lats(a)yless4u.com.au> writes: > diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h > index a38ccda..9ddb3d1 100644 > --- a/include/ws2tcpip.h > +++ b/include/ws2tcpip.h > @@ -85,26 +85,41 @@ struct WS(ip_msfilter) { > struct WS(in_addr) imsf_slist[1]; > }; > > -typedef struct WS(in_addr6) > -{ > - WS(u_char) s6_addr[16]; /* IPv6 address */ > +struct WS(in6_addr) { > + union { > + WS(u_char) Byte[16]; > + WS(u_short) Word[8]; > + } u; > } IN6_ADDR, *PIN6_ADDR, *LPIN6_ADDR; > > +#define in_addr6 WS(in6_addr) > + > +#define _S6_un u > +#define _S6_u8 Byte > +#ifndef USE_WS_PREFIX > +#define s6_addr _S6_un._S6_u8 > +#else > +#define WS_s6_addr _S6_un._S6_u8 > +#endif > + > +#define s6_bytes u.Byte > +#define s6_words u.Word This doesn't seem to match the PSDK, I don't see anything like this in ws2tcpip.h. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something
by Nikolay Sivov 02 Apr '09

02 Apr '09

> Joris Huizer wrote: Hi, Joris. Thanks for spotting this, but changes you've made will fail on Windows. I've just sent a corrected version with one test more. Here it is if you're interested: http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html

1 0

Microsoft Office 2007 error
by Robert Lunnon 02 Apr '09

02 Apr '09

I Get the following unimplemented call in Wine 1.1.16 when using the word 2007 file-selector wine: Call from 7fbb155b to unimplemented function shdocvw.dll.IEILIsEqual, aborting Hints anyone

4 3

GSoC proposal
by cocofan 02 Apr '09

02 Apr '09

I'm a student interested in applying for Google summer of code and I was looking over your ideas. I'm familiar with wine as a user (for running an occasional windows app I'm forced to run) and I notice one of your ideas is getting old DOS games to run under wine. I'm a big fan of the original Lemmings DOS game but can't get it to work under wine (it doesn't respond to the pressing of keys or mouse clicks when the storyboard is up). Would it be possible to work on getting Lemmings to work. I'm not sure this is a problem with VGA though but I wouldn't mine working on some other old DOS classics (I kind of miss them). Also, how detailed you do want the timeline/milestones to be? I'm not familiar with the code yet and won't be by the deadline (which is Friday). I'm in the process of getting and compiling the code from the 'git' repository though. Dona Hertel

2 1

Documentation
by Fred . 02 Apr '09

02 Apr '09

I saw on http://www.winehq.org/status/wine That there Nonexistent documentation for "Initial directory structure" and Poor documentation for "Initial INI files". So I wrote documentation for those on the wiki. http://wiki.winehq.org/Initial_directory_structure http://wiki.winehq.org/Initial_INI_files Hope I helped out, and this was useful. If so, it could be linked from the /status/wine article, and maybe move to /site/docs/winedev-guide/

2 1

Re: [3/3] user32: Implemented GetWindowRgnBox with tests
by Paul Vriens 02 Apr '09

02 Apr '09

Nikolay Sivov wrote: > IE8 requested this. > > Changelog: > - Implemented GetWindowRgnBox with tests > > +static void test_winregion() > +{ > + HWND hwnd; > + RECT r; > + int ret; > + HRGN hrgn; > + > + hwnd = CreateWindowExA(0, "static", NULL, WS_VISIBLE, 10, 10, 10, 10, NULL, 0, 0, NULL); > + if (pGetWindowRgnBox) > + { > + /* NULL prect */ > + SetLastError(0xdeadbeef); > + ret = pGetWindowRgnBox(hwnd, NULL); > + ok( ret == ERROR, "Expected ERROR, got %d\n", ret); > + ok( GetLastError() == 0xdeadbeef, "Expected , got %d\n", GetLastError()); > + > + hrgn = CreateRectRgn(2, 3, 10, 15); > + ok( hrgn != NULL, "Region creation failed\n"); > + if (hrgn) > + { > + SetWindowRgn(hwnd, hrgn, FALSE); > + > + SetLastError(0xdeadbeef); > + ret = pGetWindowRgnBox(hwnd, NULL); > + ok( ret == ERROR, "Expected ERROR, got %d\n", ret); > + ok( GetLastError() == 0xdeadbeef, "Expected , got %d\n", GetLastError()); > + > + r.left = r.top = r.right = r.bottom = 0; > + ret = pGetWindowRgnBox(hwnd, &r); > + ok( ret == SIMPLEREGION, "Expected SIMPLEREGION, got %d\n", ret); > + ok( r.left == 2 && r.top == 3 && r.right == 10 && r.bottom == 15, > + "Expected (2,3,10,15), got (%d,%d,%d,%d)\n", r.left, r.top, > + r.right, r.bottom); > + DeleteObject(hrgn); > + } > + } > + else > + win_skip("GetWindowRgnBox not supported\n"); > + > + DestroyWindow(hwnd); > +} > + Why not test for pGetWindowRgnBox at the beginning and return when not available (including the win_skip() of course). That will get rid of the big indented block. -- Cheers, Paul.

2 1

Re: gdi32: don't compile printdtv16 on 64-bit
by Detlef Riekenberg 01 Apr '09

01 Apr '09

On Di, 2009-03-24 at 22:19 -0500, Austin English wrote: > +@ stdcall -i386 WriteSpool16(long ptr long) You disable Printing in Wine with that. -- By by ... Detlef

1 0

Re: mshtml/tests: Fix tests on Windows
by Ge van Geldorp 01 Apr '09

01 Apr '09

> From: Reece Dunn <msclrhd(a)googlemail.com> > 2009/4/1 Ge van Geldorp <ge(a)gse.nl>: > > Modify load_state only in ReadyState_Changed callback. > > > > Changelog: > > ?Fix tests on Windows > > > > --- > > ?dlls/mshtml/tests/htmldoc.c | ? 28 +++++++++++++++++++++++----- > > ?1 files changed, 23 insertions(+), 5 deletions(-) > > ?mode change 100644 => 100755 dlls/mshtml/tests/htmldoc.c > > Is there a reason for the mode change? > > - Reece No, there isn't. Not sure how that happened, might be because I edited that file using Visual Studio over Samba. I'll be more careful next time. Ge.

1 0

Students, get in your GSoC proposals NOW.
by Kai Blin 01 Apr '09

01 Apr '09

Hi folks, Google has asked the mentoring orgs to remind students to submit their applications now rather than later, so Google can plan ahead better. You still can edit your proposals up until the deadline. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: mshtml/tests: Fix tests on Windows
by Reece Dunn 01 Apr '09

01 Apr '09

2009/4/1 Ge van Geldorp <ge(a)gse.nl>: > Modify load_state only in ReadyState_Changed callback. > > Changelog: > Fix tests on Windows > > --- > dlls/mshtml/tests/htmldoc.c | 28 +++++++++++++++++++++++----- > 1 files changed, 23 insertions(+), 5 deletions(-) > mode change 100644 => 100755 dlls/mshtml/tests/htmldoc.c Is there a reason for the mode change? - Reece

1 0

Re: advapi32/tests: Skip some tests using English names when running on non-English locales
by Paul Vriens 01 Apr '09

01 Apr '09

Ge van Geldorp wrote: > Account names are localized. Similar to existing skip in line 1806. > > Changelog: > Skip some tests using English names when running on non-English locales > > --- > dlls/advapi32/tests/security.c | 45 > ++++++++++++++++++++++----------------- > 1 files changed, 25 insertions(+), 20 deletions(-) > > > > > > ------------------------------------------------------------------------ > > Hi Ge, Aric sent a patch yesterday to address this: http://www.winehq.org/pipermail/wine-patches/2009-March/071373.html Besides that I don't think there is a need for this big indented block. You could have just done : if() { skip() return; } -- Cheers, Paul.

1 0

Re: mciqtz32: Implement driver messages
by Detlef Riekenberg 31 Mar '09

31 Mar '09

On Sa, 2009-03-28 at 11:48 +0100, Christian Costa wrote: Thanks for working on this part of Wine. > +/************************************************************************** > + * MCIAVI_drvClose [internal] > + */ > +static DWORD MCIQTZ_drvClose(DWORD dwDevID) > +{ With greetings from copy & paste: There is no need to fix the MCIAVI != MCIQTZ mismatch in a second Patch. Fix it here, when you add the code. You use TAB in the comments and also in the Code. Don't do that. -- By by ... Detlef

2 5

Re: GetTempFileName should return 0 when the path isn't valid
by Austin English 31 Mar '09

31 Mar '09

On Sun, Mar 29, 2009 at 11:37 AM, Oskar Eisemuth <patchnow(a)gmail.com> wrote: > GetTempFileName should check the path and should return zero if it isn't a directory. > See Bug 17875 > > --- > dlls/kernel32/path.c | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > > > > Can you add a testcase for this? -- -Austin

3 3

Re: Implement [Un]RegisterHotKey with test
by Detlef Riekenberg 31 Mar '09

31 Mar '09

On Mo, 2009-03-30 at 18:17 +0500, Vladimir Pankratov wrote: > + return DefWindowProcW (hWnd, msg, wParam, lParam); > + WCHAR className[] = {'T','e','s','t','H','o','t','K','e','y',0}; > + WCHAR winName[] = {'H','o','t','K','e','y','T','e','s','t',0}; > + ATOM classatom; > + WNDCLASSW cls; > + cls.hIcon = LoadIconW (0, (LPWSTR)IDI_APPLICATION); > + cls.hCursor = LoadCursorW (0, (LPWSTR)IDC_ARROW); .... Next to the other comments, beware that UNICODE Functions are missing or not implemented in win9x. Please use ANSI Functions in the tests. -- By by ... Detlef

1 0

Re: Implement [Un]RegisterHotKey with test
by Vincent Povirk 31 Mar '09

31 Mar '09

I've been told the functionality needs to go in the server. You should be using git format-patch to create your patches (see http://winehq.org/sending_patches). You're mixing tabs and spaces. Please don't do that. Vincent Povirk 2009/3/30 Vladimir Pankratov <scriptkid(a)mail.ru>: > Hello. > > Based on Vincent Povirk's idea and patch at > http://www.winehq.com/hypermail/wine-devel/2003/02/0636.html. > > This implement RegisterHotKey and UnregisterHotKey API functions, and test. > > Thank you. > > > > >

1 0

GSoC Mentors, please start looking at the student proposals
by Kai Blin 31 Mar '09

31 Mar '09

Hi folks, the student application period is nearing it's end and the proposals are starting to come in. From what I heard the new web-app doesn't support changing the application after the deadline on April 3rd, so I'd like mentors to give as much feedback as possible before the deadline. Also, please indicate if you're willing to mentor specific proposals. Thanks, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Tracing weirdness in the kernel32:profile tests
by Paul Vriens 31 Mar '09

31 Mar '09

Hi, I'm trying to fix the remaining issues in the kernel32 profile tests. They have to do with the fact that we have extra '\r\n' on Win9x and that we need a timeout. The timeout is already in (1000 msec) but apparently that is not even enough on some boxes. If I check the current results on one of my boxes I see: profile.c:977: Test failed: File doesn't match profile.c:992: Test failed: File doesn't match profile.c:1007: Test failed: File doesn't match profile.c:1019: Test failed: File doesn't match This is exactly at the place where the ok() message is. For debugging purposes I added if (lstrcmpA(buf, data)) { trace("buf : (%s)\n", buf); trace("data : (%s)\n", data); } to check_file_data(). When I now run the test I get (and I omitted the buf/data output here): profile.c:835: Test failed: File doesn't match profile.c:835: Test failed: File doesn't match profile.c:835: Test failed: File doesn't match profile.c:835: Test failed: File doesn't match So the linenumbers are not the ones from the original ok() message but instead the ones from the last trace() message. Any idea? -- Cheers, Paul.

2 2

Re: [1/2](try 2)advapi32: alias some sids in LookupAccountName and make comparison case insensitive
by Paul Vriens 31 Mar '09

31 Mar '09

Aric Stewart wrote: > > with tests > --- > dlls/advapi32/security.c | 10 +++++-- > dlls/advapi32/tests/security.c | 56 > ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 63 insertions(+), 3 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Aric, Could you have a look at the test results as you are still busy with this stuff. - Some (all?) of the new tests fail on a Non-English locale. - None of the newly checked names are available on NT4. - LocalService and NetworkService are not available on W2K (all?) -- Cheers, Paul.

1 0

httpapi compile broken on OpenBSD
by Austin English 31 Mar '09

31 Mar '09

Howdy, The compile is broken on OpenBSD in httpapi/httpapi_main.c: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings -Wpointer-arith -I/usr/local/include -I/usr/local/include -I/usr/local/include/libpng -o httpapi_main.o httpapi_main.c In file included from ../../include/http.h:25, from httpapi_main.c:27: ../../include/ws2tcpip.h:60: error: conflicting types for `socklen_t' /usr/include/sys/types.h:163: error: previous declaration of `socklen_t' *** Error code 1 Stop in /home/austin/wine-git/dlls/httpapi (line 92 of /usr/share/mk/sys.mk). Talking with Vincent, narrowed it down to the file ignoring Wine's definition of socklen_t. Is there any reason we shouldn't be defining it, like we already do in iphlpapi/iphlpapi_main.c, winhttp/net.c, wininet/netconnection.c, wsock32/protocol.c and server/sock.c? E.g.,: diff --git a/dlls/httpapi/httpapi_main.c b/dlls/httpapi/httpapi_main.c index 7b29a15..b96f730 100644 --- a/dlls/httpapi/httpapi_main.c +++ b/dlls/httpapi/httpapi_main.c @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#define USE_WS_PREFIX + #include "config.h" #include <stdarg.h> -- -Austin

1 0

SoC: JavaScript implementation
by Piotr Caban 30 Mar '09

30 Mar '09

Hi, I'm planning to participate in Google Summer of Code this year. I was thinking about working on recently added jscript.dll implementation. Its engine looks almost complete, but I can see that there are many unimplemented APIs. That's what I'd like to improve. I've already talked about this idea with Jacek, who has written jscript.dll, and he says that he likes it. I was looking for pages that intensively use JavaScript as well as simple real life test cases. My goals would be, in order: - Look at Wine jscript.dll related bugs. These would be: 15432, 15582, 16208, 16594 and 17152. I'm not sure if they are JScript or MSHTML bugs yet as they require deeper analyze. I will fix their JScript part of problem. - Fix W3School (http://www.w3schools.com/js/default.asp) JavaScript examples. These seem to be a nice tests for me. They test commonly used APIs in real life scenarios. I believe that if these tests work, most web sides should work as well. - Test complex web pages Pages like GMail or Google Office would be really cool to have working with our JavaScript. Unfortunately I'm afraid that it may be too much work for SoC to fix them. I'd like to do some testing and find some complex web pages that I could use as tests. If someone has any more ideas about tests I'm open for suggestions. For testing JavaScript on web pages I'm planning to use IE working on Wine with built-in jscript.dll. This way I will be able to test jscript.dll on web pages that is currently impossible to do with Wine MSHTML and iexplore.exe. What do you think about this idea? Thanks, Piotr Caban

2 2

GSoC: Improving DOS graphics
by Daniel Kraft 30 Mar '09

30 Mar '09

Hi, I would be interested in working on WINE for Google Summer of Code (as I would like to get into WINE and learn more about it from the developer's side of view; I imagine this is a very educational and interesting experience in addition to being simply an interesting free software project to work on). On the ideas list is a project about improving handling of DOS graphics mode, this sounds interesting to me. I've got good experience with C, C++ and other programming languages as well as programming in general, but so far no knowledge at all about WINE apart from using it. Do you think this would be a good project to apply for and get into WINE? (Thus both useful for the community as well as a good point for me without WINE experience so far.) Regarding free software in general, I've already worked with some projects including Mozilla and GCC, so I should be familiar with standard development practices involved. Thank you very much, Daniel

2 1

Re: rpcrt4: Compile in RPC over HTTP support even if HAVE_SOCKETPAIR is not defined.
by Alexandre Julliard 30 Mar '09

30 Mar '09

Rob Shearman <robertshearman(a)gmail.com> writes: > socketpair is only needed for the server functions for ncacn_ip_tcp. > The tower implementation that ncacn_http and ncacn_ip_tcp share > doesn't depend on it. It doesn't need socketpair, but it needs getaddrinfo and friends so it still won't build on Mingw, that's why I disabled the whole thing. We could put that part inside a #ifdef HAVE_GETADDRINFO instead, but the end result would be the same. -- Alexandre Julliard julliard(a)winehq.org

2 1

16bit code generation
by Tijl Coosemans 30 Mar '09

30 Mar '09

I was reading through binutils documentation and came across this. Maybe it can be used to compile 16 bit tests. 3.2.4. 16-bit mode Binutils (2.9.1.0.25+) now fully support 16-bit mode (registers and addressing) on i386 PCs. Use .code16 and .code32 to switch between assembly modes. Also, a neat trick used by several people (including the oskit authors) is to force GCC to produce code for 16-bit real mode, using an inline assembly statement asm(".code16\n"). GCC will still emit only 32-bit addressing modes, but GAS will insert proper 32-bit prefixes for them.

8 13

Re: [1/6] WineD3D: Merge index buffers into base buffers
by Henri Verbeet 30 Mar '09

30 Mar '09

2009/3/30 Stefan Dösinger <stefan(a)codeweavers.com>: > - hr = IWineD3DDevice_CreateBuffer(This->wined3d_device, &wined3d_desc, > - (IUnknown *)object, &object->wined3d_buffer); > + hr = IWineD3DDevice_CreateBuffer(This->wined3d_device, desc->ByteWidth, > + desc->Usage, 0, WINED3DFMT_UNKNOWN, WINED3DPOOL_MANAGED,· > + &object->wined3d_buffer, 0, (IUnknown *)object); You're adding trailing space here. More importantly though, the wined3d_desc variable is now essentially unused. I already mentioned on IRC a couple of weeks ago that I don't think changing the CreateBuffer() call like this is an improvement. I also mentioned that I think the patch is too big, I really don't want to fix regressions in this. The patch can be split in at least 4 separate patches without trying too hard.

1 0

Advice on where to place new private methods and access to private methods across modules.
by Damian Dixon 30 Mar '09

30 Mar '09

Hi, I am working on creating a patch for X11DRV_AlphaBlend to allow Bitmap's with no DIBSECTION to work. The code to do this is fairly generic so I created a new method: DIB_CreateDIBSectionFromBitmap. I initially placed this in winex11.drv/dib.c, however the method required access to private methods in gdi32/dib.c. I then considered moving the method to gdi32, however again access to private methods seems to be an issue. I would prefer not to duplicate code across the dib.c files. Is there an accepted approach for acessing support methods across the modules? or should I just duplicate the necessary methods? Thanks Damian

2 1

Re: [2/2](try 2)advapi: handle fully qualified account names for well known sids in LookupAccountName
by Alexandre Julliard 30 Mar '09

30 Mar '09

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -2667,11 +2669,23 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR lpSystemName, LPCWSTR lpAccountName, PSI > } > > /* Check well known SIDs first */ > + if (strchrW(lpAccountName,'\\')) > + { > + lpAccountNamePtr = strrchrW(lpAccountName,'\\'); > + lpAccountNamePtr++; > + lpDomainNamePtr = lpAccountName; > + } > + else > + lpAccountNamePtr = lpAccountName; > > for (i = 0; i < (sizeof(ACCOUNT_SIDS) / sizeof(ACCOUNT_SIDS[0])); i++) > { > - if (!strcmpiW(lpAccountName, ACCOUNT_SIDS[i].account) || > - (ACCOUNT_SIDS[i].alias && !strcmpiW(lpAccountName, ACCOUNT_SIDS[i].alias))) > + /* check domain first */ > + if (lpDomainNamePtr && strncmpiW(lpDomainNamePtr, ACCOUNT_SIDS[i].domain, strlenW(ACCOUNT_SIDS[i].domain))) > + continue; You always need to check that the next char is a terminator when using functions like strncmpiW. -- Alexandre Julliard julliard(a)winehq.org

1 0

[RFC] Port of Stefan Dösinger's ARB_vertex_program fixed-function vertex pipeline replacement to 1.1.18
by Paul TBBle Hampson 30 Mar '09

30 Mar '09

Hi. I've rebased the arb_vertex_program ffp vertex pipeline patchset to 1.1.18. This time I managed to get the fog correct, and all the d3d9 tests pass. I also did some benchmarks this time in both 3DMark 2000 and 2001SE, and have attached the results. Generally there's a fairly large slowdown in the fixed-function code, particularly in 3DMark 2000. Some of 2001SE's tests appear unaffected, which isn't surprising since some of them are D3D8 shader-based tests, not FFP tests. The fillrate tests appeared unaffected too. This is on a Core 2 Duo machine with an nVidia 8600M GT, if it makes a difference. I wasn't watching too carefully, but I did't notice any visual artefacts in the tests. As I understand it, Stefan's not got the time or inclination to work on this at the moment, and my knowledge of ARB vertex programs and the D3D fixed-function pipeline is rather limited, so in all likelihood getting this going faster will require someone to get stuck into gen_arbvp_ffp_shader and its callees in arb_program_shader.c and get it feature-complete and sufficiently optimised to be on-par with the ffp-based vertex pipeline. I guess a GLSL-based vertex pipeline might be desired too...? Then people can add features such as vertex-blending, and get No One Lives Forever 2 and bug #6955 cleared up. As before, the code is entirely Stefans, but bugs may certainly have been introduced by me. Since it now passes the unit tests, it might be reasonable to actually consider this for mainline, with a registry key or env var to force a specific choice of fixed-function vertex pipeline. -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

3 4

dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)
by Andreas Rosenberg 30 Mar '09

30 Mar '09

2 2

Re: 16bit code generation
by Hin-Tak Leung 30 Mar '09

30 Mar '09

I wonder how bad is it to port some old version of djgpp forward? ( http://www.delorie.com/djgpp/history.html ) - it is a fork of gcc as far as I see and did support 16-bit code generation at one time?

2 1

Re: Patch for specifying video card name and driver
by Henri Verbeet 30 Mar '09

30 Mar '09

2009/3/30 John Whitlock <John-Whitlock(a)ieee.org>: > This patch adds the ability to specify the name and driver for the video > card using registry keys (Current_user/Software/Wine/Direct3D). This is > similar to existing code in wined3d, and has been used since 1.1.8 to get > Fallout 3 working. > Either you didn't write this, or you made the exact same errors as in the other patch doing the same thing I already commented on.

1 0

Re: GetTempFileName should return 0 when the path isn't valid
by Vitaliy Margolen 30 Mar '09

30 Mar '09

Oskar Eisemuth wrote: > GetTempFileName should check the path and should return zero if it isn't a directory. > See Bug 17875 > Tests verifying the behavior will be nice. Shouldn't be too hard to add. Vitaliy.

1 0

urlmon ftp protocol failures on Windows
by Ge van Geldorp 29 Mar '09

29 Mar '09

Hi Jacek, I've been investigating the failures in the urlmon ftp protocol tests that show up on quite a few WinXP and higher machines. It seems to me that there is an inherent race condition in the test. The main thread waits in line 1822 until IInternetProtocolSink_Switch has been called. It will then call CHECK_CALLED(Switch) and SET_EXPECT(Switch). However, nothing prevents a background thread from calling IInternetProtocolSink_Switch again before SET_EXPECT(Switch) in the main thread is complete. In fact, if I add a Sleep(100) between the WaitForSingleObject() in line 1822 and the CHECK_CALLED() on the next line, the failures that show up now and then on test.winehq.org become reproducible every time. I believe the attached patch fixes the problem, it breaks the current assumption that there's a 1:1 relationship between IInternetProtocolSinc_Switch() and IInternetProtocol_Read() calls. Before shipping it off to wine-patches, I'd like your opinion, do you think this is the correct solution? Thanks, Ge.

2 1

Re: mciqtz32: Add basic play capability
by Detlef Riekenberg 29 Mar '09

29 Mar '09

On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote: > + hr = CoCreateInstance(&CLSID_FilterGraph, NULL, > CLSCTX_INPROC_SERVER, &IID_IGraphBuilder, (LPVOID*)&wma->pgraph); > + if (FAILED(hr)) { > + TRACE("Cannot create filtergraph (hr = %x)\n", hr); > + return MCIERR_INTERNAL; > + } Again TABs in the Code. > + > + hr = IGraphBuilder_QueryInterface(wma->pgraph, > &IID_IMediaControl, (LPVOID*)&wma->pmctrl); > + if (FAILED(hr)) { > + TRACE("Cannot get IMediaControl interface (hr = %x)\n", hr); > + return MCIERR_INTERNAL; TAB again. And while i read this quote: You leak wma->pmctrl here. -- By by ... Detlef

2 1

Re: wined3d [try 4]: SetDepthStencilSurface is always called when AutoDepthStencil is enabled
by Henri Verbeet 29 Mar '09

29 Mar '09

2009/3/29 David Adam <david.adam.cnrs(a)gmail.com>: > - return WINED3DERR_INVALIDCALL; > + HRESULT hrc; You're still using 9 space indentation.

1 0

Re: WineD3D: Check for the presence of wglGetExtensionsStringARB
by Robert Millan 29 Mar '09

29 Mar '09

On Sun, Mar 29, 2009 at 10:11:19PM +0200, Roderick Colenbrander wrote: > Hi, > > Don't call wglGetExtensionsStringARB when it isn't around. After this patch > WineD3D can work unpatched on VirtualBox. Hi, I can confirm this works fine on VirtualBox. Thanks Roderick -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."

1 0

Re: wined3d [try3]: SetDepthStencilSurface is always called when AutoDepthStencil is enabled
by Henri Verbeet 29 Mar '09

29 Mar '09

2009/3/29 David Adam <david.adam.cnrs(a)gmail.com>: > + hrc = IWineD3DDeviceParent_CreateDepthStencilSurface(This->device_parent, > + NULL, > + pPresentationParameters->BackBufferWidth, > + pPresentationParameters->BackBufferHeight, > + pPresentationParameters->AutoDepthStencilFormat, > + pPresentationParameters->MultiSampleType, > + pPresentationParameters->MultiSampleQuality, > + FALSE, > + &This->auto_depth_stencil_buffer); Even though I don't think any implementation of IWineD3DDeviceParent_CreateDepthStencilSurface actually uses the second parameter, you should pass "This->parent" rather than NULL there. > + if (SUCCEEDED(hrc)) > + IWineD3DDevice_SetDepthStencilSurface(iface, This->auto_depth_stencil_buffer); This is redundant, the code a couple of lines down will also set the depth stencil. > + else { > + ERR("Failed to create the auto depth stencil\n");· > + return WINED3DERR_INVALIDCALL; > + } You're leaking the swapchain here. Also, not trying to be picky, but could you please fix the indentation?

1 0

winetricks:
by Rico Schüller 29 Mar '09

29 Mar '09

Hi, this patch let winetricks only overwrite d3dx9_36.dll, because all other d3dx9_xx.dlls should be redirected by wine's implementation, so this shouldn't be needed for this dlls. Cheers Rico

2 1

winetricks: update d3dx redist package.
by Rico Schüller 29 Mar '09

29 Mar '09

Hi, this patch updates the DirectX redist package in winetricks to version Mar09. Cheers Rico

2 1

Fwd: How to "bottle" applications for distribution with wine?
by David Gerard 29 Mar '09

29 Mar '09

to list as well ---------- Forwarded message ---------- From: David Gerard <dgerard(a)gmail.com> Date: 2009/3/29 Subject: Re: How to "bottle" applications for distribution with wine? To: Ben Klein <shacklein(a)gmail.com> 2009/3/29 Ben Klein <shacklein(a)gmail.com>: > He's asking if it's possible to bundle a minimal Wine with some native > app (e.g. EVE "Linux version" which was EVE for Windows with Cedega, > and the same basic principle for the "Linux version" of the Sims > shipped with some Mandrakes). > The only thing I can think of is to calculate the maximum set of > required DLLs for the application, and only ship those, but it's > probably not worth it. It's better in general to use a system-wide > Wine, due to the general-purpose nature of Wine. Mm. Look at Picasa for Linux, which really does package pretty much a whole Wine with the app. (I just run the Windows version in my system Wine ;-) ) So it won't be smaller, but it will be a single package. Are there notes anywhere on how Picasa packages Wine? - d.

1 0

strange git object
by Eric Pouech 29 Mar '09

29 Mar '09

while updating my git tree, I ran (actually not finished downloading) this pack: Resuming fetch of pack 119463f192a563f17ac18ff9b717fbe57199eed7 at byte 95266539 which size looks quite enormous to me... any idea of what's going on ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: wined3d [try 2]: SetDepthStencilSurface is always called when AutoDepethStencilBuffer is enabled
by Stefan Dösinger 29 Mar '09

29 Mar '09

Am Samstag, 28. März 2009 14:39:15 schrieb David Adam: > + hrc = IWineD3DDeviceImpl_CreateSurface(iface, > ... > + This->parent); It's not that easy unfortunately. You're using the d3d9 (or d3d8) device as parent for the depth stencil, which isn't correct. This would mean that GetDepthStencilSurface returns an IDirect3DDevice9 instead of an IDirect3DSurface9, which will obviously lead to troubles. You'll have to use a callback function similarly to the CreateDevice callback to tell d3d8 / d3d9 to create one of their surface structures and call wined3d to create a wined3d surface.

3 2

Re: How to "bottle" applications for distribution with wine?
by Tim Felgentreff 29 Mar '09

29 Mar '09

King InuYasha <ngompa13(a)gmail.com> wrote: > Hello, > I was working on setting up a Windows game to work on all the Linux machines > I have, but I don't want to install the full blown Wine on each one. Is > there a way to "bottle" Wine with application binaries and make it all work > from a single folder and have it totally self sufficient (similar to > TransGaming's Cedega for Linux with EVE Online)? Sure, you can just copy the full wine install into the wineprefix you created for your game, e.g. I usually put a "wine" folder next to the drive_c into my wine prefix for that. Then just make yourself a startup script for you game in which you set you PATH to search "$WINEPREFIX/wine/bin" first. This is basically how PlayOnLinux does it. Hope that helps -Tim

2 1

GSoC 2009
by Tim Felgentreff 29 Mar '09

29 Mar '09

Hi, I'm currently an IT student in Germany in my 2nd year. I'd like to help out with wine during the summer of code. I have never done any dll development apart from a little messing with the windows research kernel, so I'd rather work on something else. I would love to work on control panel applets or the wine config tool as in the project ideas, however, theming and the test suite would be two other things I'd be interested in. It would be great if you could give me some pointers as to where my help would be appreciated most so I dig a little deeper into that for a couple of days before I write my proposal. Regards, Tim

3 3

Re: 16bit code generation
by Hin-Tak Leung 28 Mar '09

28 Mar '09

--- On Sat, 28/3/09, Austin English <austinenglish(a)gmail.com> wrote: > > I don't know how well native linux openwatcom works as > a cross-compiler, however, but that probably doesn't matter > for this discussion? > > Quite the opposite, that's exactly what we WANT to use. Given that 1) win32 openwatcom works, 2) presumably it works correctly under wine (or relatively easy to check that if it isn't), then any difference in behavior/code-generation between win32 openwatcom under wine and native linux openwatcom working as a cross-compiler is either a bug or inconsequential, then it should be relatively straight forward to check? It is not a trivial amount of work - compiling a bunch of random code under win32 openwatcom and cross-compiling and compare, and account for any difference if there is any - but would work well as a 3-month GSoC project?

1 0

Re: 16bit code generation
by Hin-Tak Leung 28 Mar '09

28 Mar '09

--- On Sat, 28/3/09, Austin English <austinenglish(a)gmail.com> wrote: > It's also not known how well it works under Linux. There > was talk > about detecting if a user has it installed, then compiling > 16 bit code > in that case, but no one's worked to see if OpenWatcom > works when > ran/installed natively. But win32 openwatcom works under wine's cmd. :-). I don't know how well native linux openwatcom works as a cross-compiler, however, but that probably doesn't matter for this discussion?

2 1

Re: [3/4]winemaker: add workspace-parse function
by Francois Gouget 28 Mar '09

28 Mar '09

This one is wrapped also (which is only logical). There are two other problems: * there's the same case sensitivity issue as in the project parsing code. Using search_from() in the same way should fix it. * also it assumes that the project file is in the current directory. In other words, the following does not work: winemaker Chap03/HelloWin/HelloWin.dsw -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.

1 0

Re: [2/4]winemaker: add project-parse function
by Francois Gouget 28 Mar '09

28 Mar '09

This one is wrapped too. But the main problem is that it does not handle case fixes. This can be fixed by applying the attached patch on top of it. With this, if you go test with the Programming Windows 98 samples, the following scenario works: cd Chap03/HelloWin winemaker HelloWin.dsp -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel