- wine-devel - winehq.org

Re: GetTempFileName should return 0 when the path isn't valid
by Vitaliy Margolen 30 Mar '09

30 Mar '09

Oskar Eisemuth wrote: > GetTempFileName should check the path and should return zero if it isn't a directory. > See Bug 17875 > Tests verifying the behavior will be nice. Shouldn't be too hard to add. Vitaliy.

1 0

urlmon ftp protocol failures on Windows
by Ge van Geldorp 29 Mar '09

29 Mar '09

Hi Jacek, I've been investigating the failures in the urlmon ftp protocol tests that show up on quite a few WinXP and higher machines. It seems to me that there is an inherent race condition in the test. The main thread waits in line 1822 until IInternetProtocolSink_Switch has been called. It will then call CHECK_CALLED(Switch) and SET_EXPECT(Switch). However, nothing prevents a background thread from calling IInternetProtocolSink_Switch again before SET_EXPECT(Switch) in the main thread is complete. In fact, if I add a Sleep(100) between the WaitForSingleObject() in line 1822 and the CHECK_CALLED() on the next line, the failures that show up now and then on test.winehq.org become reproducible every time. I believe the attached patch fixes the problem, it breaks the current assumption that there's a 1:1 relationship between IInternetProtocolSinc_Switch() and IInternetProtocol_Read() calls. Before shipping it off to wine-patches, I'd like your opinion, do you think this is the correct solution? Thanks, Ge.

2 1

Re: mciqtz32: Add basic play capability
by Detlef Riekenberg 29 Mar '09

29 Mar '09

On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote: > + hr = CoCreateInstance(&CLSID_FilterGraph, NULL, > CLSCTX_INPROC_SERVER, &IID_IGraphBuilder, (LPVOID*)&wma->pgraph); > + if (FAILED(hr)) { > + TRACE("Cannot create filtergraph (hr = %x)\n", hr); > + return MCIERR_INTERNAL; > + } Again TABs in the Code. > + > + hr = IGraphBuilder_QueryInterface(wma->pgraph, > &IID_IMediaControl, (LPVOID*)&wma->pmctrl); > + if (FAILED(hr)) { > + TRACE("Cannot get IMediaControl interface (hr = %x)\n", hr); > + return MCIERR_INTERNAL; TAB again. And while i read this quote: You leak wma->pmctrl here. -- By by ... Detlef

2 1

Re: wined3d [try 4]: SetDepthStencilSurface is always called when AutoDepthStencil is enabled
by Henri Verbeet 29 Mar '09

29 Mar '09

2009/3/29 David Adam <david.adam.cnrs(a)gmail.com>: > - return WINED3DERR_INVALIDCALL; > + HRESULT hrc; You're still using 9 space indentation.

1 0

Re: WineD3D: Check for the presence of wglGetExtensionsStringARB
by Robert Millan 29 Mar '09

29 Mar '09

On Sun, Mar 29, 2009 at 10:11:19PM +0200, Roderick Colenbrander wrote: > Hi, > > Don't call wglGetExtensionsStringARB when it isn't around. After this patch > WineD3D can work unpatched on VirtualBox. Hi, I can confirm this works fine on VirtualBox. Thanks Roderick -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."

1 0

Re: wined3d [try3]: SetDepthStencilSurface is always called when AutoDepthStencil is enabled
by Henri Verbeet 29 Mar '09

29 Mar '09

2009/3/29 David Adam <david.adam.cnrs(a)gmail.com>: > + hrc = IWineD3DDeviceParent_CreateDepthStencilSurface(This->device_parent, > + NULL, > + pPresentationParameters->BackBufferWidth, > + pPresentationParameters->BackBufferHeight, > + pPresentationParameters->AutoDepthStencilFormat, > + pPresentationParameters->MultiSampleType, > + pPresentationParameters->MultiSampleQuality, > + FALSE, > + &This->auto_depth_stencil_buffer); Even though I don't think any implementation of IWineD3DDeviceParent_CreateDepthStencilSurface actually uses the second parameter, you should pass "This->parent" rather than NULL there. > + if (SUCCEEDED(hrc)) > + IWineD3DDevice_SetDepthStencilSurface(iface, This->auto_depth_stencil_buffer); This is redundant, the code a couple of lines down will also set the depth stencil. > + else { > + ERR("Failed to create the auto depth stencil\n");· > + return WINED3DERR_INVALIDCALL; > + } You're leaking the swapchain here. Also, not trying to be picky, but could you please fix the indentation?

1 0

winetricks:
by Rico Schüller 29 Mar '09

29 Mar '09

Hi, this patch let winetricks only overwrite d3dx9_36.dll, because all other d3dx9_xx.dlls should be redirected by wine's implementation, so this shouldn't be needed for this dlls. Cheers Rico

2 1

winetricks: update d3dx redist package.
by Rico Schüller 29 Mar '09

29 Mar '09

Hi, this patch updates the DirectX redist package in winetricks to version Mar09. Cheers Rico

2 1

Fwd: How to "bottle" applications for distribution with wine?
by David Gerard 29 Mar '09

29 Mar '09

to list as well ---------- Forwarded message ---------- From: David Gerard <dgerard(a)gmail.com> Date: 2009/3/29 Subject: Re: How to "bottle" applications for distribution with wine? To: Ben Klein <shacklein(a)gmail.com> 2009/3/29 Ben Klein <shacklein(a)gmail.com>: > He's asking if it's possible to bundle a minimal Wine with some native > app (e.g. EVE "Linux version" which was EVE for Windows with Cedega, > and the same basic principle for the "Linux version" of the Sims > shipped with some Mandrakes). > The only thing I can think of is to calculate the maximum set of > required DLLs for the application, and only ship those, but it's > probably not worth it. It's better in general to use a system-wide > Wine, due to the general-purpose nature of Wine. Mm. Look at Picasa for Linux, which really does package pretty much a whole Wine with the app. (I just run the Windows version in my system Wine ;-) ) So it won't be smaller, but it will be a single package. Are there notes anywhere on how Picasa packages Wine? - d.

1 0

strange git object
by Eric Pouech 29 Mar '09

29 Mar '09

while updating my git tree, I ran (actually not finished downloading) this pack: Resuming fetch of pack 119463f192a563f17ac18ff9b717fbe57199eed7 at byte 95266539 which size looks quite enormous to me... any idea of what's going on ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: wined3d [try 2]: SetDepthStencilSurface is always called when AutoDepethStencilBuffer is enabled
by Stefan Dösinger 29 Mar '09

29 Mar '09

Am Samstag, 28. März 2009 14:39:15 schrieb David Adam: > + hrc = IWineD3DDeviceImpl_CreateSurface(iface, > ... > + This->parent); It's not that easy unfortunately. You're using the d3d9 (or d3d8) device as parent for the depth stencil, which isn't correct. This would mean that GetDepthStencilSurface returns an IDirect3DDevice9 instead of an IDirect3DSurface9, which will obviously lead to troubles. You'll have to use a callback function similarly to the CreateDevice callback to tell d3d8 / d3d9 to create one of their surface structures and call wined3d to create a wined3d surface.

3 2

Re: How to "bottle" applications for distribution with wine?
by Tim Felgentreff 29 Mar '09

29 Mar '09

King InuYasha <ngompa13(a)gmail.com> wrote: > Hello, > I was working on setting up a Windows game to work on all the Linux machines > I have, but I don't want to install the full blown Wine on each one. Is > there a way to "bottle" Wine with application binaries and make it all work > from a single folder and have it totally self sufficient (similar to > TransGaming's Cedega for Linux with EVE Online)? Sure, you can just copy the full wine install into the wineprefix you created for your game, e.g. I usually put a "wine" folder next to the drive_c into my wine prefix for that. Then just make yourself a startup script for you game in which you set you PATH to search "$WINEPREFIX/wine/bin" first. This is basically how PlayOnLinux does it. Hope that helps -Tim

2 1

GSoC 2009
by Tim Felgentreff 29 Mar '09

29 Mar '09

Hi, I'm currently an IT student in Germany in my 2nd year. I'd like to help out with wine during the summer of code. I have never done any dll development apart from a little messing with the windows research kernel, so I'd rather work on something else. I would love to work on control panel applets or the wine config tool as in the project ideas, however, theming and the test suite would be two other things I'd be interested in. It would be great if you could give me some pointers as to where my help would be appreciated most so I dig a little deeper into that for a couple of days before I write my proposal. Regards, Tim

3 3

Re: 16bit code generation
by Hin-Tak Leung 28 Mar '09

28 Mar '09

--- On Sat, 28/3/09, Austin English <austinenglish(a)gmail.com> wrote: > > I don't know how well native linux openwatcom works as > a cross-compiler, however, but that probably doesn't matter > for this discussion? > > Quite the opposite, that's exactly what we WANT to use. Given that 1) win32 openwatcom works, 2) presumably it works correctly under wine (or relatively easy to check that if it isn't), then any difference in behavior/code-generation between win32 openwatcom under wine and native linux openwatcom working as a cross-compiler is either a bug or inconsequential, then it should be relatively straight forward to check? It is not a trivial amount of work - compiling a bunch of random code under win32 openwatcom and cross-compiling and compare, and account for any difference if there is any - but would work well as a 3-month GSoC project?

1 0

Re: 16bit code generation
by Hin-Tak Leung 28 Mar '09

28 Mar '09

--- On Sat, 28/3/09, Austin English <austinenglish(a)gmail.com> wrote: > It's also not known how well it works under Linux. There > was talk > about detecting if a user has it installed, then compiling > 16 bit code > in that case, but no one's worked to see if OpenWatcom > works when > ran/installed natively. But win32 openwatcom works under wine's cmd. :-). I don't know how well native linux openwatcom works as a cross-compiler, however, but that probably doesn't matter for this discussion?

2 1

Re: [3/4]winemaker: add workspace-parse function
by Francois Gouget 28 Mar '09

28 Mar '09

This one is wrapped also (which is only logical). There are two other problems: * there's the same case sensitivity issue as in the project parsing code. Using search_from() in the same way should fix it. * also it assumes that the project file is in the current directory. In other words, the following does not work: winemaker Chap03/HelloWin/HelloWin.dsw -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.

1 0

Re: [2/4]winemaker: add project-parse function
by Francois Gouget 28 Mar '09

28 Mar '09

This one is wrapped too. But the main problem is that it does not handle case fixes. This can be fixed by applying the attached patch on top of it. With this, if you go test with the Programming Windows 98 samples, the following scenario works: cd Chap03/HelloWin winemaker HelloWin.dsp -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Cahn's Axiom: When all else fails, read the instructions.

1 0

How to "bottle" applications for distribution with wine?
by King InuYasha 28 Mar '09

28 Mar '09

Hello, I was working on setting up a Windows game to work on all the Linux machines I have, but I don't want to install the full blown Wine on each one. Is there a way to "bottle" Wine with application binaries and make it all work from a single folder and have it totally self sufficient (similar to TransGaming's Cedega for Linux with EVE Online)? Thanks!

1 0

Re: [1/4] [wined3d] add pow2Matrix_identity flag to BaseTextureClass struct (resend)
by Stefan Dösinger 28 Mar '09

28 Mar '09

The patchset looks ok to me

1 0

Re: [1/4]winemaker: winresrc.h is the right name in actual wine
by Francois Gouget 28 Mar '09

28 Mar '09

This one is wrapped. Besides that it's ok, so if you resubmit it should go in. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ $live{free} || die "";

1 0

Re: [PATCH 00/10] Support for dumb picture keychain
by Alexandre Julliard 28 Mar '09

28 Mar '09

Guy Albertelli <galberte(a)neo.rr.com> writes: > 1/10 server: Implement FILE_NO_INTERMEDIATE_BUFFERING with O_DIRECT > 2/10 kernel32/tests: First test for CreateFile on NT unique volume name > 3/10 ntdll: Implement conversion of NT unique volume name to unix file > name > 4/10 ntdll: Implement internal aligned buffer for I/O with special devices > 5/10 kernel32: Make GetVolumeNameForVolumeMountPoint[AW] generate correct > name > 6/10 kernel32: Implement stub for DeleteVolumeMountPoint[AW] saying we > completed it. > 7/10 kernel32/tests: Add test for unique volume names to QueryDosDevice > 8/10 kernel32: Implement support in QueryDosDevice for unique volume names > 9/10 server: Fix error when opening directory r/o with O_DIRECT > 10/10 kernel32/tests: More tests of CreateFile on unique volume id All that stuff should be done in mountmgr, not in ntdll/kernel32. -- Alexandre Julliard julliard(a)winehq.org

3 5

Dwarf2 - support e0 ie DW_OP_lo_user
by Alban Browaeys 28 Mar '09

28 Mar '09

I still have to find why (probably gcc related) but under debian sid (no problems under lenny, have not tested squeeze yet) "winedbg --gdb regedit" trigger an infinite loop error: $ winedbg --gdb regedit 0017:0018: create process 'C:\windows\system32\regedit.exe'/0x110640 @0x7eb62c04 (0<0>) fixme:dbghelp_dwarf:compute_location Unhandled attr op: e0 it: dwarf.c :1355 : dwarf2_parse_variable: L'assertion « subpgm->func » a échoué. wine: Assertion failed at address 0xffffe424 (thread 0009), starting debugger... Unhandled exception: assertion failed in 32-bit code (0xffffe424). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:ffffe424 ESP:0032df04 EBP:0032df1c EFLAGS:00000202( - 00 - - I1) EAX:00000000 EBX:00003602 ECX:00003602 EDX:00000006 ESI:b7d9f157 EDI:b7dbbff4 Stack dump: 0x0032df04: 0032df1c 00000006 00003602 b7c8b640 0x0032df14: b7dbbff4 0032e03c 0032e044 b7c8d008 0x0032df24: 00000006 0032dfbc 00000000 b7dbbff4 0x0032df34: 0000005d 7c00a0f8 00000068 b7ccea0f 0x0032df44: 0032df80 7c00a100 7c00a100 b7c9f7ab 0x0032df54: b7dbbff4 0000005d b7da16ff b7da3188 Backtrace: =>0 0xffffe424 (0x0032df1c) fixme:dbghelp_dwarf:compute_location Unhandled attr op: e0 dwarf.c :1355 : dwarf2_parse_variable: L'assertion « subpgm->func » a échoué. wine: Assertion failed at address 0xffffe424 (thread 001a), starting debugger... Unhandled exception: assertion failed in 32-bit code (0xffffe424). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:ffffe424 ESP:0033e684 EBP:0033e69c EFLAGS:00000206( - 00 - -IP1) EAX:00000000 EBX:00003617 ECX:00003617 EDX:00000006 ESI:b7f16fa3 EDI:b7f33ff4 Stack dump: 0x0033e684: 0033e69c 00000006 00003617 b7e03640 0x0033e694: b7f33ff4 0033e7bc 0033e7c4 b7e05008 0x0033e6a4: 00000006 0033e73c 00000000 b7f33ff4 0x0033e6b4: 00000059 7c009fd8 00000068 b7e46a0f 0x0033e6c4: 0033e700 7c009fe0 7c009fe0 b7e177ab 0x0033e6d4: b7f33ff4 00000059 b7f196ff b7f1b188 Backtrace: =>0 0xffffe424 (0x0033e69c) (...) thus never reach the prompt. Adding the attached patch (hack I made by reading binutils readelf.c) I get to the prompt though still have some errors (but it still seems to work): $ winedbg --gdb regedit 0018:0019: create process 'C:\windows\system32\regedit.exe'/0x110640 @0x7ed690f0 (0<0>) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two52 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a9 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a10 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a11 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tc (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tf (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tt (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t9 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t10 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t11 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t12 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t13 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t14 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value shuge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pio4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pio4lo (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tiny (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value erx (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value efx (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value efx8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tiny (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value o_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value o_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value R02 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value R03 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value R04 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value R05 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S01 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S02 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S03 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S04 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u00 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u01 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u02 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u03 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u04 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u05 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u06 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v01 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v02 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v03 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v04 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r00 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r01 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r02 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r03 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s01 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s02 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s03 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s04 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s05 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two23 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a9 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a10 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a11 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tc (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tf (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tt (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t9 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t10 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t11 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t12 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t13 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value t14 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value shuge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value C1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value C2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value C3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value C4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value C5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value C6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value S6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pio4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pio4lo (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tiny (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value erx (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value efx (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value efx8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pp0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pp1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pp2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pp3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pp4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qq1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qq2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qq3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qq4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qq5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pa0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pa1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pa2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pa3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pa4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pa5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pa6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qa1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qa2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qa3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qa4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qa5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qa6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value ra7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sa8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value rb0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value rb1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value rb2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value rb3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value rb4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value rb5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value rb6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sb1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sb2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sb3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sb4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sb5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sb6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value sb7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tiny (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value o_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value o_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pio2_hi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pio2_lo (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pio4_hi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pS0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pS1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pS2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pS3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pS4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pS5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qS0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qS1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qS2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qS3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value qS4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value invsqrtpi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value pi (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two63 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value a5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value b0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value b1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value b2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value b3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value b4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tc (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tf (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tt (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value g0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value g1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value g2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value g3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value g4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value g5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value g6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value h0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value h1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value h2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value h3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value h4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value h5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value v5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value s6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value r6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w0 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w1 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w2 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w3 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w4 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w5 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w6 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value w7 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value zero (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value shuge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tiny (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value half (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value erx (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value efx (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value efx8 (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value two (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value tiny (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value o_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value o_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value u_threshold (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value huge (a) fixme:dbghelp_dwarf:dwarf2_parse_variable Unsupported form for const value one (a) 0018:0019: create thread I @0x7ed690f0 GNU gdb 6.8-debian Copyright (C) 2008 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "i486-linux-gnu". 0018:0019: loads DLL C:\windows\system32\KERNEL32.dll @0x7b820000 (0<0>) 0018:0019: loads DLL C:\windows\system32\ntdll.dll @0x7bc10000 (0<0>) 0018:0019: loads DLL C:\windows\system32\regedit.exe @0x7ed50000 (0<0>) 0018:0019: loads DLL C:\windows\system32\advapi32.dll @0x7ed00000 (0<0>) 0018:0019: loads DLL C:\windows\system32\msvcrt.dll @0x7eca0000 (0<0>) 00000018:00000019: exception code=0x80000003 warning: Target reported unsupported offsets: Text=0032fb2c;Data=b7edd001;Bss=00000000 [New Thread 25] start_process (arg=0x0) at process.c:914 914 ExitThread( entry( peb ) ); trace: 98 => 80 Wine-gdb> bt #0 start_process (arg=0x0) at process.c:914 #1 0xb7f47bb7 in wine_switch_to_stack () from /usr/local/bin/../lib/libwine.so.1 Wine-gdb> I took regedit as a simple easely reproducible example . Any help or better fix would be greatly appreciated. Alban

2 1

Re: comctl32: Fix bitmap size calculation
by Vitaliy Margolen 27 Mar '09

27 Mar '09

Aleksey Bragin wrote: > Fix bitmap size calculation in IMAGELIST_InternalExpandBitmaps and > remove unneded parameter. Memory requirements are greatly reduced after > this fix. > > The bug was an ambiguous meaning of a cx parameter, which was supposed > to be a width of an individual image inside the list, but width of a > whole bitmap was passed in thus making memory requirements huge (number > of images * width of whole bitmap = required bitmap size). > Furthermore, cx parameter is redundant because all checks are already > there (that the image list can't be reduced), and besides of that there > is no use for it anymore. Thus it's been removed. That bug was introduced while attempting to change the size of the bitmaps for the toolbar. Looking at the code it's rely iffy if image list really should be able to do that at all. Or that toolbar should handle the resize itself (most likely). The commit I'm talking about is: commit 19cef6ca1059140d00ac8b445ab3f9eb0491f239 Author: Gerard Patel <g.patel(a)wanadoo.fr> Date: Sat Jul 8 12:48:37 2000 +0000 Allow the size of bitmaps to be changed after toolbar buttons have been added. With your patch you "disable" this ability (which I don't think is working anyway). So some tests are in order. At least a test program demonstrating what's the correct behavior. Vitaliy

3 4

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A
by Paul Vriens 27 Mar '09

27 Mar '09

Andreas Rosenberg wrote: > > ------------------------------------------------------------------------ > > There is no need for that GetVersionExA call/test. Just do an if (0) and leave that comment about NT4 crashing in. -- Cheers, Paul.

1 0

X11DRV_AlphaBlend: FIXME not a DIB section
by Damian Dixon 27 Mar '09

27 Mar '09

Hi, I'm trying to get an application running as best as possible under Wine and have found that X11DRV_AlphaBlend does not handle Bitmaps which are not a DIB Section. I have also found that a number of people have submitted some fixes to X11DRV_AlphaBlend: 1. http://www.nabble.com/(re-resend)-x11drv%3A-implement-X11DRV_AlphaBlend-for… 2. http://archives.free.net.ph/message/20080602.110501.ba1ea794.el.html Is there a reason for these not being accepted? I have started doing my own patch but wish to ensure the maximium liklyhood of the patch being accepted. I am taking a slightly different approach of trying to convert the Bitmap into a DIB Section first, which would hopefully minimise any changes. Does any one have any advice on how to approach this fix? Thanks Damian

2 1

shell32: Implement IDD_MAKENEWFOLDER
by Jonathan Armond 27 Mar '09

27 Mar '09

Hi This implements the make new folder button for the SHBrowseForFolders dialog. It's my first patch, so I'm asking for comments. Note, renaming of the new folder is still not supported. Jon --- dlls/shell32/brsfolder.c | 46 +++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 43 insertions(+), 3 deletions(-) diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c index cc8a91d..ca2e2c0 100644 --- a/dlls/shell32/brsfolder.c +++ b/dlls/shell32/brsfolder.c @@ -18,7 +18,6 @@ * FIXME: * - many memory leaks * - many flags unimplemented - * - implement new dialog style "make new folder" button * - implement editbox */ @@ -35,6 +34,7 @@ #include "shell32_main.h" #include "shellapi.h" #include "shresdef.h" +#include "shellfolder.h" WINE_DEFAULT_DEBUG_CHANNEL(shell); @@ -677,8 +677,48 @@ static BOOL BrsFolder_OnCommand( browse_info *info, UINT id ) return TRUE; case IDD_MAKENEWFOLDER: - FIXME("make new folder not implemented\n"); - return TRUE; + if (info->pidlRet == NULL) + return FALSE; + else + { + WCHAR path[MAX_PATH]; + HTREEITEM hParent; + HRESULT hr; + LPITEMIDLIST pidlChild; + IShellFolder *lpsfDesktop, *lpsfParent; + ISFHelper *psfhlp; + + hr = SHGetDesktopFolder(&lpsfDesktop); + if (FAILED(hr)) { + WARN("SHGetDesktopFolder failed! hr = %08x\n", hr); + return FALSE; + } + hr = IShellFolder_BindToObject(lpsfDesktop, info->pidlRet, 0, + &IID_IShellFolder, (LPVOID*)&lpsfParent); + IShellFolder_Release(lpsfDesktop); + if (FAILED(hr)) { + WARN("IShellFolder_BindToObject failed! hr = %08x\n", hr); + return FALSE; + } + IShellFolder_QueryInterface(lpsfParent, &IID_ISFHelper, + (LPVOID*)&psfhlp); + if (!psfhlp) { + WARN("Failed to acquire ISFHelper interface.\n"); + return FALSE; + } + ISFHelper_GetUniqueName(psfhlp, path, MAX_PATH); + hr = ISFHelper_AddFolder(psfhlp, info->hwndTreeView, path, + &pidlChild); + if (FAILED(hr)) + return FALSE; + /* Insert into treeview */ + hParent = TreeView_GetSelection( info->hwndTreeView ); + InsertTreeViewItem( info, lpsfParent, pidlChild, + info->pidlRet, NULL, hParent ); + ILFree(pidlChild); + IShellFolder_Release(lpsfParent); + return TRUE; + } } return FALSE; } -- 1.6.0.4

1 0

Re: [2/11] wined3d: Create a separate function for checking a format's FBO compatibility.
by Allan Tong 27 Mar '09

27 Mar '09

> + if (check_fbo_compat(gl_info, gl_formats_template[src].glInternal)) > + { > + TRACE("Internal format of %s not supported as FBO target, using render target internal instead\n", > + debug_d3dformat(gl_formats_template[src].fmt)); > gl_info->gl_formats[dst].rtInternal = gl_formats_template[src].rtInternal; > } else { > TRACE("Format %s is supported as fbo target\n", debug_d3dformat(gl_formats_template[src].fmt)); > gl_info->gl_formats[dst].rtInternal = gl_formats_template[src].glInternal; > } Shouldn't this be "!check_fbo_compat" ? - Allan

2 1

Re: [10/10] bcrypt: Add a mostly empty bcrypt.dll.
by Alexandre Julliard 27 Mar '09

27 Mar '09

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > diff --git a/dlls/bcrypt/bcrypt.spec b/dlls/bcrypt/bcrypt.spec > new file mode 100644 > index 0000000..e69de29 Please add stubs for the exported functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: libwine: Only partially reserve memory beyond 0x80000000 on FreeBSD.
by Francois Gouget 27 Mar '09

27 Mar '09

Tijl Coosemans a écrit : > After enabling the memory reservation code on FreeBSD last week, > several games either suffer a performance loss or simply crash, often > with GL_OUT_OF_MEMORY errors or similar out of memory errors from X > libs. (Tested with nvidia driver and opensource r300 dri driver.) Which games can be used to reproduce this issue? Is one of them freely downloadable? Even better, can this issue be reproduced with a non-game application? Also, won't this patch be obsolete once Alexandre completes his current OpenGL memory allocation work? That is, doesn't it just hide the problem rather than solving it? > It also causes other problems like: > http://bugs.winehq.org/show_bug.cgi?id=17718 This bug mentions the following error: > Fatal error 'Cannot allocate red zone for initial thread' at line 384 > in file /usr/src/lib/libthr/thread/thr_init.c (errno = 2) It would be nice to figure out how we get in init_main_thread(). Apparently there are only two possible cases: * 1) Some thread routines have detected that the library hasn't yet * been initialized (_thr_initial == NULL && curthread == NULL), or * * 2) An explicit call to reinitialize after a fork (indicated * by curthread != NULL) I don't really understand why we would reallocate the stack in the first case so my guess is this happens through a fork. > This patch only partially reserves memory, enough for the shared heap, > virtual heap and wine top-down allocations, and leaves the majority > unreserved. Isn't the memory reservation supposed to prevent Unix libraries from being mapped in this memory range? If so, won't leaving holes open us to this sort of trouble again? Also, besides FreeBSD's braindead stack allocation routines, why should this patch only be used on FreeBSD? If it's supposed to help with OpenGL memory allocation then shouldn't it be used on Linux too (which has the same issue with OpenGL)? -- Francois Gouget fgouget(a)codeweavers.com

4 11

Re: wined3d: SetDepthStencilSurface is always called when AutoDepthStencil is enabled
by Henri Verbeet 27 Mar '09

27 Mar '09

2009/3/27 David Adam <david.adam.cnrs(a)gmail.com>: > Fixes bug 16846. > Could you include the test as well?

1 0

SOC 2009: Application Test Suite
by Austin English 27 Mar '09

27 Mar '09

Howdy, I'm planning on applying for Google Summer of Code 2009. I'm pretty sure most people reading this list already know me, but for those that don't, I frequently triage bugs in Bugzilla, help users on the forum, and a few other things. I've also done quite a bit of work testing wine on more obscure OS's (OpenSolaris, FreeBSD, OS X, NetBSD, OpenBSD). I'd like to implement an application test suite. It's something that's been discussed for Wine for quite a while, but has never been put into place. I took a bit of time a while back and hacked couple a couple quick scripts as a test, and got a script to automatically install Firefox 3 in Wine using AutoHotKey (http://www.autohotkey.com/). I've made a couple more scripts as well, but they don't match Windows behavior because of bug (http://bugs.winehq.org/show_bug.cgi?id=10147) hint, hint (disclaimer, I haven't tested that script in a while, been busy with exams, so that bug might be fixed...I don't think it has though). My plan to implement it is to make a script, that can be used standalone, in conjunction with Patchwatcher, or any other script, to test wine against several real world applications. I make a very quick proof of concept (attached), which is based off of winetricks. It's _REALLY_ rough at the moment, (I haven't had time to mess with it lately), but demonstrates the idea. The script setups a clean WINEPREFIX, installs autohotkey, removes the Z: symlink for braindead installers that search the entire hard drive, and sets up a link to it's install cache (essentially winetrickscache). From there, it makes a copy of this prefix, so on subsequent installers/applications, we can restore the clean prefix and save a few seconds. >From there, so far, it only installs firefox3. The plan is to add several dozen different tests, for various functions of wine. Obviously, I'd like to start with platinum rated applications, to prevent regressions. From there, the current list of applications/functions to target are: 1. Firefox3 - useful for testing lots of other things, e.g., java/flash, etc. Easy to test. 2. Microsoft Office - We've broken this a few times in recent months, so adding a test in daily git for it would help catch regressions sooner. 3. World of Warcraft - I don't play, but A) It's really popular, and B) also gives us a chance to test wininet for regressions. 4. iTunes - this installers been broken a couple times. The bonjour service should allow for testing services related regressions. 5. Adobe suite - there haven't been too many regressions here that I can remember, but it's definitely an area we should watch out for. Of course, we don't want to only test the installer's keystrokes/mouse inputs, so SHA1 checksumming of installed files would verify against corrupted files/setupapi regressions/etc. Once a few installer tests are in and working well, I plan to extend the tests further to test running the application, e.g, for photoshop by opening a file, inserting a circle, and saving it. This is a bit harder to pull off in Autohotkey in a way that's portable, so I'm saving that sort of thing for later. Also interesting would be a real application's test suite. Dan suggested using Google Chrome's, since it's squeaky clean after using lots of Valgrind and Purify. That would be good, but I'd put that after getting the test suite to pass in Wine. This should be very doable using Autohotkey's scripting functionality (pretty extensive - http://www.autohotkey.com/docs/Functions.htm, http://www.autohotkey.com/docs/Variables.htm) and good old fashioned shell scripting. I'm very familiar with bourne scripting, and currently maintain winetricks while Dan's taking a Wine vacation. I'm currently working on a build script to build Wine on several OS's, as well as running and submitting the conformance tests (http://winezeug.googlecode.com/svn/trunk/build_script/daily.sh). [I got tired of maintaining the script over several different OS's/computers]. The upside is it would be easy to add on appinstall to this daily script. I typically set it running before leaving home for work/school. It spends an hour or so building wine and running the tests in a few different configurations. Adding appinstall would allow my computer to daily test several applications for installation, running, etc. This of course isn't as useful as Patchwatcher's testing of each single patch, but I don't currently have a spare machine that it can test on. Getting a script and tests ready to do so, however, would be great for Wine. Besides, I can easily setup the script to upload the results to a webserver, so we can daily see that each test is passing. If a test is failing, the information would then be publicly available for anyone to run 'git bisect'. Wow, this turned into a really long e-mail, and I've got an exam to study for. I'd appreciate any comments, and let me know if there are any questions. -- -Austin

7 12

Re: shell32: Implement IDD_MAKENEWFOLDER.
by Juan Lang 26 Mar '09

26 Mar '09

Hi John, a few problems with this one: -{ +{ This whitespace-only change isn't needed for your patch, please omit it. + if (info->pidlRet == NULL) + return FALSE; + { This is poor style, IMHO. Surely an explicit else would be better than the implicit else block here? + MessageBoxA( info->hwndTreeView, + "You cannot create a new folder here. Choose a different location.", + "Invalid location", MB_OK ); The indentation is off, please match the surrounding code. And, these should be in resources, not in English in the source. --Juan

1 0

IOCTL_DISK_GET_DRIVE_GEOMETRY in mountmgr.sys
by Michael Ost 26 Mar '09

26 Mar '09

Hi, The ioctl handler for IOCTL_DISK_GET_DRIVE_GEOMETRY on \\\\.\\c: in mountmgr.sys doesn't work. The call returns incorrect values that change at random intervals. Since the ioctl is defined as METHOD_BUFFERED I think it should be putting DRIVE_GEOMETRY data in IRP->AssociatedIrp.SystemBuffer. Instead the handler puts the data in IRP->MdlAddress.StartVa. Then process_ioctl in ntoskrnl.exe wipes out the output data with the random stuff in the allocated SystemBuffer. I am out of my depth with windows driver handling code, but a web search (http://www.cmkrnl.com/arc-ioctlbuf.html) says that SystemBuffer should be where the data is put. Indeed, when I change to SystemBuffer the user call to DeviceIoControl gets the right values back. Am I on the right track? Thanks, Michael Ost PS: here's a proposed patch... --- wine-1.1.7/dlls/mountmgr.sys/device.c.ORIG 2009-03-23 14:04:30.000000000 -0700 +++ wine-1.1.7/dlls/mountmgr.sys/device.c 2009-03-25 17:06:24.000000000 -0700 @@ -607,7 +607,7 @@ info.TracksPerCylinder = 255; info.SectorsPerTrack = 63; info.BytesPerSector = 512; - memcpy( irp->MdlAddress->StartVa, &info, len ); + memcpy( irp->AssociatedIrp.SystemBuffer, &info, len ); irp->IoStatus.Information = len; irp->IoStatus.u.Status = STATUS_SUCCESS; break;

1 1

Re: [6/10] wined3d: Simplify remove_vbos().
by Stefan Dösinger 26 Mar '09

26 Mar '09

Am Donnerstag, 26. März 2009 10:49:17 schrieb Henri Verbeet: Doesn't that mix up named and numbered attributes?

2 1

Re: [5/10] wined3d: Remove unused attributes from WineDirect3DVertexStridedData.
by Stefan Dösinger 26 Mar '09

26 Mar '09

Am Donnerstag, 26. März 2009 10:49:13 schrieb Henri Verbeet: I think position2 and normal2 are used with fixed function tweening. Should we remove it for now and readd it if we ever implement tweening in a vertex pipeline replacement?

2 1

Re: winex11.drv: SetDIBits fails when startscan != 0
by Alexandre Julliard 26 Mar '09

26 Mar '09

Massimo Del Fedele <max(a)veneto.com> writes: > diff --git a/dlls/winex11.drv/dib.c b/dlls/winex11.drv/dib.c > index 6df4137..42d9082 100644 > --- a/dlls/winex11.drv/dib.c > +++ b/dlls/winex11.drv/dib.c > @@ -3927,6 +3927,7 @@ INT CDECL X11DRV_SetDIBits( X11DRV_PDEVICE *physDev, HBITMAP hbitmap, UINT start > X11DRV_DIB_IMAGEBITS_DESCR descr; > DIBSECTION ds; > LONG width, height, tmpheight; > + LONG widthBytes; > INT result; > > descr.physDev = physDev; > @@ -3936,6 +3937,7 @@ INT CDECL X11DRV_SetDIBits( X11DRV_PDEVICE *physDev, HBITMAP hbitmap, UINT start > if (DIB_GetBitmapInfo( &info->bmiHeader, &width, &height, > &descr.infoBpp, &descr.compression ) == -1) > return 0; > + widthBytes = ((width * descr.infoBpp +31) &~31) / 8; > > tmpheight = height; > if (height < 0) height = -height; > @@ -3977,7 +3979,7 @@ INT CDECL X11DRV_SetDIBits( X11DRV_PDEVICE *physDev, HBITMAP hbitmap, UINT start > default: break; > } > > - descr.bits = bits; > + descr.bits = (BYTE *)bits + widthBytes * (tmpheight > 0 ? (height - startscan - lines) : startscan); You shouldn't need to change the bits address. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [try 2]winex11.drv/dib.c - fix SetDIBits() for startscan != 0
by Massimo Del Fedele 26 Mar '09

26 Mar '09

Massimo Del Fedele ha scritto: > Changes from previous one : > bits shifting displaced from X11DRV_SetDIBits() to > X11DRV_DIB_SetImageBits() > Result is identical to former, the patch looks worse to me than before, > but.... > As a note, there's no way to leave 'descr->bits' untouched without > adding at least another > parameter (ySrc) to the bunch of X11DRV_DIB_SetImageBits_xxx() functions. > > Ciao > > Max > > > ------------------------------------------------------------------------ > > Please disregard this patch.... it's not correct on every case. Previous one was. I'll investigate a bit more about it. Ciao Max

1 0

how/where to implement case-insensitive fourcc check?
by Joerg-Cyril.Hoehle＠t-systems.com 26 Mar '09

26 Mar '09

Hi, I'm looking for advice about how to properly implement the case-insensitive fourcc check of video formats required by the conformance test msvfw32, i.e. how to eliminate the 2 todo_wine in http://test.winehq.org/data/tests/msvfw32:msvfw.html This would allow the AppDB rating of the application "The Alien Nations / Die Völker" to jump from garbage to silver. Cf. http://bugs.winehq.org/show_bug.cgi?id=15915 http://source.winehq.org/git/wine.git/?a=blob;f=dlls/msvfw32/tests/msvfw.c;… The quick and dirty hack (to make the game run) is to change - if (icinfo && icinfo->fccType != ICTYPE_VIDEO) into + if (icinfo && icinfo->fccType != ICTYPE_VIDEO && icinfo->fccType != mmioFOURCC('V', 'I', 'D', 'C')) in files dlls/iccvid/iccvid.c, likewise in msvidc32/msvideo1.c and msrle32/msrle32.c But I wouldn't even think of submiting that to wine-patches. Somehow a case-insensitive check is required. For instance, msvfw32/msvideo_main.c:ICOpen() uses the case-insensitive helper function compare_fourcc(). But the above may not be the correct place for this check. Any suggestions? Thanks for your help, Jörg Höhle

1 0

google summer of code applicant
by wwinthan＠purdue.edu 26 Mar '09

26 Mar '09

hi i'm Win Than Aung from Purdue university. I have found your project listed on google summer of code website. I would like to ask for a chance to present myself. would you please tell me to whom should i contact for further information? PS: i have been full-time interning at the local companies at Purdue Research Park almost 1 year as software development engineer-intern. PS: some of the projects I have done so far can be found at the following links http://keshunli.byethost15.com/wwinthan/projects.php http://keshunli.byethost15.com/searchwebserver/(php web server) http://keshunli.byethost15.com/wwinthan (simple facebook-like add friends features) thanks winthan

1 0

Re: programs/dxdiag: Create dummy application
by Austin English 25 Mar '09

25 Mar '09

On Wed, Mar 25, 2009 at 5:09 PM, Allen Hair <allen.hair(a)gmail.com> wrote: Howdy Allen Glad to see y'all are finally trying to get this committed. Couple minor things: diff --git a/programs/dxdiag/En.rc b/programs/dxdiag/En.rc new file mode 100644 index 0000000..76e93ff --- /dev/null +++ b/programs/dxdiag/En.rc @@ -0,0 +1,39 @@ +/* + * Notepad (English resources) This isn't notepad ;-). + * + * Copyright 2009 Allen Hair <allen.hair(a)gmail.com> No need to put your e-mail. git log will show that. -- -Austin

1 0

Re: programs/dxdiag: Create dummy application
by Austin English 25 Mar '09

25 Mar '09

On Wed, Mar 25, 2009 at 5:09 PM, Allen Hair <allen.hair(a)gmail.com> wrote: Howdy Allen Glad to see y'all are finally trying to get this committed. Couple minor things: diff --git a/programs/dxdiag/En.rc b/programs/dxdiag/En.rc new file mode 100644 index 0000000..76e93ff --- /dev/null +++ b/programs/dxdiag/En.rc @@ -0,0 +1,39 @@ +/* + * Notepad (English resources) This isn't notepad ;-). + * + * Copyright 2009 Allen Hair <allen.hair(a)gmail.com> No need to put your e-mail. git log will show that. -- -Austin

1 0

Re: [kernel32] Fix inf file parsing
by James Hawkins 25 Mar '09

25 Mar '09

On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > This fixes bug 17843 but I'm not sure it's a 100% correct. James didn't > change > this just for the fun of it. > If you're unsure of the correct fix, you should write a test case that fails without your patch and succeeds with your patch. -- James Hawkins

2 4

Re: msi: avoid negative index in TABLE_insert_row
by James Hawkins 25 Mar '09

25 Mar '09

On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart <aric(a)codeweavers.com> wrote: > > fixes bug Bug 17600 > --- > dlls/msi/table.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index, then there's a bug somewhere else. -- James Hawkins

2 5

Re: [4/4] [wined3d] trigger constant reloading when RECT textures change
by Stefan Dösinger 25 Mar '09

25 Mar '09

Am Mittwoch, 25. März 2009 14:52:15 schrieb Tobias Jakobi: A few comments on all the patches. I am a bit busy at university right now, so I didn't have a chance to answer earlier: From patch 4/4: > + if (!use_ps(stateblock)) { > + TRACE("Non power two matrix multiply fixup\n"); > + glMultMatrixf(((IWineD3DTextureImpl *) stateblock->textures[texUnit])->baseTexture.pow2Matrix); > + } I think a comment would be helpful why this isn't done when pixel shaders are used, as this can't be seen from the context of this code. > + if (GL_TEXTURE_RECTANGLE_ARB == IWineD3DBaseTexture_GetTextureDimensions(stateblock->textures[sampler]) && > + use_ps(stateblock)) { Maybe it would be helpful to add a flag that says if the fixup matrix is identity. WineD3D can emulate np2 textures with padded GL_TEXTURE_2D textures as well. Now I can't think of any hardware that has shaders, but not GL_ARB_texture_rectangle, but checking for GL_TEXTURE_RECTANGLE_ARB to find out if we need a fixup isn't that nice(We might do it in other places too, though) From patch 1: > + /* Bitmap for texture rect coord fixups (32 samplers max currently). > + * Increase size when MAX_FRAGMENT_SAMPLERS grows. */ > + UINT texrect_fixup; I think there's no point in supporting more than 16 samplers. That's the limit in d3d9 and will never change, and d3d10 makes unconditional NP2 support mandatory. The ps_compile_args structure is memcmp'ed every time the shader is changed, so the size matters. I also recommend to move it to the bottom of the structure, since it will be 0x0000 in most cases, so it prolongs the number of bytes the memcmp has to check before it finds a difference.(ok: In which direction does memcmp search?) General: I also think that you could merge the 4 patches into one or two. I appreciate the effort to make the patches small, but that shouldn't be a self-sufficient purpose. Patches 1 and 2 can certainly be merged, as patch 1 alone doesn't do anything. Patch 4 could be merged into patch 3 because it is required for the code in patch 3 to work correctly. The patches leave out one corner case(Subject for a separate patch though): The use of a vertex shader with fixed function fragment processing. In this case the vertex shader has to take care of the fixup. In GLSL that can conveniently be done in the pixelshader<->vertexshader glue function. It could read the same uniform and multiply the written texture coordinate. Once all the cases work in GLSL, we could experiment with the R and RG float formats from GL_NV_float_buffer, since they're supported on RECT textures only, but may come handy on pre-geforce 8 hardware which doesn't support the ARB_RG extension.

1 0

Re: comctl32: CCS_VERT flips toolbar separators' orientation
by Rob Shearman 25 Mar '09

25 Mar '09

2009/3/17 Igor Tarasov <tarasov.igor(a)gmail.com>: > Currently wine flips orientation of toolbar separators on > BTNS_DROPDOWN, which is odd, since even horizontal toolbar separators > may have this flag turned on. Tests with control spy show that native > comctl flips orientation on CCS_VERT toolbar style, which is logical. > ... > @@ -855,7 +855,7 @@ TOOLBAR_DrawButton (HWND hwnd, TBUTTON_INFO *btnPtr, HDC hdc, DWORD dwBaseCus > /* empirical tests show that iBitmap can/will be non-zero */ > /* when drawing the vertical bar... */ > if ((dwStyle & TBSTYLE_FLAT) /* && (btnPtr->iBitmap == 0) */) { > - if (btnPtr->fsStyle & BTNS_DROPDOWN) > + if (dwStyle & CCS_VERT) > TOOLBAR_DrawDDFlatSeparator (&rc, hdc, infoPtr); > else > TOOLBAR_DrawFlatSeparator (&rc, hdc, infoPtr); You should fix the name of the TOOLBAR_DrawDDFlatSeparator function and the comments above it if you think it should be called as a result of the CCS_VERT window style and not the BTNS_DROPDOWN button style. -- Rob Shearman

2 2

Re: [PATCH 3/6] kernel32: Handle writing empty sections and keys in WritePrivateProfileString.
by Paul Vriens 25 Mar '09

25 Mar '09

James Hawkins wrote: > --- > dlls/kernel32/profile.c | 32 ++++++++++++++++++++------------ > dlls/kernel32/tests/profile.c | 5 +---- > 2 files changed, 21 insertions(+), 16 deletions(-) > > > ------------------------------------------------------------------------ > > Hi James, Sorry if you've already picked the problem with this patch up (bug 17843). I tried looking into this myself but can't come up with a simple answer/fix. On a clean .wine the registry shows a lot of wrong entries (just look under HKCR, HKCU or HKLM). Any idea? -- Cheers, Paul.

1 0

Re: advapi32: stub TreeResetNamedSecurityInfo for the IE8 installer
by Alexandre Julliard 25 Mar '09

25 Mar '09

Aric Stewart <aric(a)codeweavers.com> writes: > diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c > index b6d51d8..4013171 100644 > --- a/dlls/advapi32/security.c > +++ b/dlls/advapi32/security.c > @@ -58,6 +58,9 @@ static BOOL ParseStringSecurityDescriptorToSecurityDescriptor( > LPDWORD cBytes); > static DWORD ParseAclStringFlags(LPCWSTR* StringAcl); > > +typedef VOID (*FN_PROGRESS) ( LPWSTR pObjectName, DWORD Status, > + OUT PPROG_INVOKE_SETTING pInvokeSetting, PVOID Args, BOOL SecuritySet); > + Please put this in the appropriate header. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: don't compile printdtv16 on 64-bit
by Alexandre Julliard 25 Mar '09

25 Mar '09

Austin English <austinenglish(a)gmail.com> writes: > diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec > index 36a8fb1..da77ad5 100644 > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -512,15 +512,15 @@ > ################################################################ > # Wine extensions: Win16 functions that are needed by other dlls > # > -@ stdcall CloseJob16(long) > -@ stdcall DrvGetPrinterData16(str str ptr ptr long ptr) > -@ stdcall DrvSetPrinterData16(str str long ptr long) > -@ stdcall GetDCHook(long ptr) > -@ stdcall OpenJob16(str str long) > -@ stdcall SelectVisRgn(long long) > -@ stdcall SetDCHook(long ptr long) > -@ stdcall SetHookFlags(long long) > -@ stdcall WriteSpool16(long ptr long) > +@ stdcall -i386 CloseJob16(long) > +@ stdcall -i386 DrvGetPrinterData16(str str ptr ptr long ptr) > +@ stdcall -i386 DrvSetPrinterData16(str str long ptr long) > +@ stdcall -i386 GetDCHook(long ptr) > +@ stdcall -i386 OpenJob16(str str long) > +@ stdcall -i386 SelectVisRgn(long long) > +@ stdcall -i386 SetDCHook(long ptr long) > +@ stdcall -i386 SetHookFlags(long long) > +@ stdcall -i386 WriteSpool16(long ptr long) You can't do that, 16-bit code can be disabled on i386 too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/6] kernel32: Fix an off-by-one error.
by Alexandre Julliard 24 Mar '09

24 Mar '09

James Hawkins <truiken(a)gmail.com> writes: > --- > dlls/kernel32/profile.c | 2 +- > dlls/kernel32/tests/profile.c | 30 ++++++------------------------ > 2 files changed, 7 insertions(+), 25 deletions(-) > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index 5d563a5..b6ad6d0 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -396,7 +396,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > first_section->name[0] = 0; > first_section->key = NULL; > first_section->next = NULL; > - next_section = &first_section->next; > + next_section = &first_section; This cannot be right. What happens to the original first_section then? -- Alexandre Julliard julliard(a)winehq.org

2 3

Serial port conformance tests
by Chris Teague 24 Mar '09

24 Mar '09

I'm new to wine, looking into serial communications. I have a failing scenario in a application, and I'd like to write a conformance test to demonstrate/document the issue. I looked in dlls/ntdll/tests but did not see any serial port related tests - did I miss them or do none exist yet? Assuming none exist, a very useful tool would be a serial port loopback device. Rather than require conformance testers to attach a hardware loopback device (NULL modem) to a physical port, could we create some virtual ports in wine and connect them together? Maybe com98 and com99 for example? Anything written to one of the ports would be sent to the other one. On Windows this can be done with a device driver, one example is com0com (http://com0com.sourceforge.net/). Is this a reasonable approach? Thanks, Chris

4 3

iphlpapi patch - what does it need?
by David Gerard 24 Mar '09

24 Mar '09

http://bugs.winehq.org/show_bug.cgi?id=14574 has a patch for iphlpapi that stubs GetAdaptersAddresses(). Just this stub is enough to get Safari 4 working. Patch is: http://bugs.winehq.org/attachment.cgi?id=19704 http://bugs.winehq.org/attachment.cgi?id=19705 Do these need anything done before they're fit to go in? (These are not my patches - I'd just like Safari 4 working.) - d.

1 0

Re: setupapi: Initialization fix
by Andrew Talbot 24 Mar '09

24 Mar '09

Andrew Talbot wrote: > The TRACE() potentially reporting the value of "newpath" must be placed > after where that variable is first set. > I suspect that this patch still doesn't fix the problem. Feedback or expert intervention is welcomed! Thanks. -- Andy.

1 0

Re: [PATCH 1/6] kernel32: Add tests for WritePrivateProfileString.
by Paul Vriens 24 Mar '09

24 Mar '09

James Hawkins wrote: > --- > dlls/kernel32/tests/profile.c | 227 +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 227 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Two of these new tests crash on Windows (see attached patch for a "fix" on Windows). Applying the patch triggers a failure on Wine though, which is very weird. -- Cheers, Paul. diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c index 7b57699..9dd551f 100644 --- a/dlls/kernel32/tests/profile.c +++ b/dlls/kernel32/tests/profile.c @@ -860,13 +860,16 @@ static void test_WritePrivateProfileString(void) ok(check_file_data(path, data), "File doesn't match\n"); DeleteFileA(path); - /* empty lpAppName */ + if (0) + { + /* empty lpAppName, crashes on Windows */ data = "[]\r\n" "key=string\r\n"; ret = WritePrivateProfileStringA("", "key", "string", path); ok(ret == TRUE, "Expected TRUE, got %d\n", ret); ok(check_file_data(path, data), "File doesn't match\n"); DeleteFileA(path); + } /* NULL lpKeyName */ data = ""; @@ -878,7 +881,9 @@ static void test_WritePrivateProfileString(void) } DeleteFileA(path); - /* empty lpKeyName */ + if (0) + { + /* empty lpKeyName, crashes on Windows */ data = "[App]\r\n" "=string\r\n"; ret = WritePrivateProfileStringA("App", "", "string", path); @@ -888,6 +893,7 @@ static void test_WritePrivateProfileString(void) ok(check_file_data(path, data), "File doesn't match\n"); } DeleteFileA(path); + } /* NULL lpString */ data = "";

1 0

SOC Project Idea: Winelib-aware scons
by Scott Ritchie 24 Mar '09

24 Mar '09

For a while now I've been hoping someone would tackle a pet project of mine. It occurred to me that it would be a great summer of code project. Basically, I want a magic script that can convert a visual studio project file into a winelib-aware, scons-powered, linux-compatible build system. This would make it very easy for a Windows-only Visual Studio project to be ported. Now, normally, someone writing portable code would probably want to use scons from the start instead of Visual Studio, but Winelib throws a monkey wrench into this process by making formerly non-portable code suddenly Linux compatible. As a good example application to test, the program eMule would be a good candidate - it's open source, works great in Wine, is built with Visual Studio, and has no good native equivalents. I've added a work in progress wiki page on the Wine wiki here: http://wiki.winehq.org/SconsWine I'm not sure whether this will function better as an scons summer of code project or a Wine one, nor am I sure where a student would be able to find a good mentor. Accordingly, I'm emailing both mailing lists, and hoping for some feedback, particularly if it doesn't sound feasible. Thanks, Scott Ritchie

8 11

Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.
by Francois Gouget 24 Mar '09

24 Mar '09

On Tue, 24 Mar 2009, Florian Köberle wrote: [...] > + if (handle_idx < 0 || handle_idx >= schan_handle_count) > + { > + ERR("Handle %ld is not in range [0,%ld]\n", handle_idx, schan_handle_count-1); > + return NULL; > + } A conformance test to show that Windows has this check would be nice. Otherwise this patch is just for hiding a bug and thus should not be committed. But really, finding out why this API gets called with an invalid handle would be much better... (likely harder too, I know) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

1 0

Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.
by Henri Verbeet 24 Mar '09

24 Mar '09

2009/3/24 Florian Köberle <florian(a)fkoeberle.de>: > + if (handle_idx < 0 || handle_idx >= schan_handle_count) > handle_idx can't be < 0 because it's unsigned. Printing an ERR if the handle is out of range is probably ok, but I think crashing is better than just returning NULL.

2 1

Re: gdi32/path.c -- Allow PATH_ExtTextOut() handle non printablecharacters
by Dmitry Timoshkov 24 Mar '09

24 Mar '09

"Massimo Del Fedele" <max(a)veneto.com> wrote: > PATH_ExtTextOut() uses GetGlyphOutlineW() which can return a NULL buffer > size not just on errors but also on non-printable glyphs. > Instead of aborting the function should check for such cases, get the > metrics and continue. This patch doesn't match the normal logic of ExtTextOut implemented in dlls/winex11.drv/xrender.c, also this requires a test case for both code paths. -- Dmitry.

3 7

Re: [1/3]msctf: ThreadMgr sink framework
by Alexandre Julliard 24 Mar '09

24 Mar '09

Aric Stewart <aric(a)codeweavers.com> writes: > typedef struct tagACLMulti { > const ITfThreadMgrVtbl *ThreadMgrVtbl; > const ITfSourceVtbl *SourceVtbl; > LONG refCount; > > ITfDocumentMgr *focus; > + > + /* kept as separate lists to reduce unnecessary iterations */ > + struct list pActiveLanguageProfileNotifySink; > + struct list pDisplayAttributeNotifySink; > + struct list pKeyTraceEventSink; > + struct list pPreservedKeyNotifySink; > + struct list pThreadFocusSink; > + struct list pThreadMgrEventSink; Please pick better names for your variables. Hungarian notation is not a good idea in general, but incorrect Hungarian prefixes are even worse, these are not pointers. -- Alexandre Julliard julliard(a)winehq.org

2 1

Unicode error
by Robert Lunnon 24 Mar '09

24 Mar '09

I get this error under solaris building wine. Any clues would be welcome (Things have probably changed a lot since I last hacked on Wine) make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -D_KERNEL32_ -fokernel. res kernel.rc Source: ¤Q¤ë a4 51 a4 eb Unicode: 5341 6708 Back: ¢Ì¤ë a2 cc a4 eb nls/cht.nls:84:16: Error: String ¤Q¤ë does not convert identically to Unicode and back in codepage 950. Try us ing a Unicode string instead make[2]: *** [kernel.res] Error 1 make[2]: Leaving directory `/export/home/src/wine2004/wine/dlls/kernel32' make[1]: *** [kernel32] Error 2 make[1]: Leaving directory `/export/home/src/wine2004/wine/dlls' make: *** [dlls] Error 2

6 7

WineHQ.org Downtime
by Jeremy Newman 24 Mar '09

24 Mar '09

WineHQ.org (websites [www,appdb,bugzilla,forums,source,test], git, mailing lists) will be off-line tomorrow starting at 10:00 CDT and lasting at least 2 hours. We will be putting up a temp website that will display an off-line message during the duration of the downtime. This is the planned server hardware upgrade. -Newman

2 4

Re: [PATCH 2/2] secur32: Use indices to link the free handles.
by Henri Verbeet 24 Mar '09

24 Mar '09

2009/3/24 Florian Köberle <florian(a)fkoeberle.de>: > Pointers can get invalid when the table gets moved in memory. > This can happen when the table grows. Did you actually see this happen? The table is only supposed to grow when there are no free handles.

1 0

Re: user32/tests: Check effect of magic font height value 0x7fff in dialog template (try 2)
by Vitaliy Margolen 24 Mar '09

24 Mar '09

Koro wrote: > This is the second try for my testcase that shows a discrepancy between > Wine and Windows' handling of dialog templates in the specific case > where the font size member is set to 0x7fff. > > + static unsigned char dlgTemplate[] = > + { > + /* Dialog header */ > + 0x01,0x00, /* Version */ > + 0xff,0xff, /* Extended template marker */ > + 0x00,0x00,0x00,0x00, /* Context Help ID */ > + 0x00,0x00,0x00,0x00, /* Extended style */ > + 0xc0,0x00,0xc8,0x80, /* Style (WS_SYSMENU|WS_CAPTION|WS_POPUP|DS_SETFONT|DS_MODALFRAME) */ Why don't you add this to the resource file? > + hDlg = CreateDialogIndirectParamW(g_hinst, (LPCDLGTEMPLATE)dlgTemplate, NULL, messageBoxFontDlgWinProc, 0); > + > + if (!hDlg) > + { > + todo_wine win_skip("dialog wasn't created\n"); This is wrong. It shouldn't be todo_wine. If you properly put template into resources you can use CreateDialogIndirectParamA Vitaliy.

2 1

Office 2007 installer crash in msi - Backtrace on Solaris
by Robert Lunnon 24 Mar '09

24 Mar '09

The cause might be a Null pointer into strlenW as below ::stack libwine.so.1.0`strlenW+0xf(0, 7bdef160, 7fbf8612, 7bdeef28) kernel32.dll.so`lstrlenW+0x34(0, 0, 1, 0, 80, 0) 0x7da74480(6a8c3648, 0, 0, 7da801d4, 7f09f998, 3) 0x7da65e08(2, 0, 0) msi.dll.so`ACTION_CallDllFunction+0x21c(6a8c090c, 7ffc1598, 7bdef4a8, 7f02f044) msi.dll.so`DllThread+0x79(6a8c090c, 7ffc1598, 7bdef558, 7ffa0a85, 7f02f038, 6a8c090c) 0x7ffa09fe(7f02f038, 6a8c090c, 0, 7ffa0a10) ntdll.dll.so`call_thread_func+0x85(7f02f038, 6a8c090c, 7bdeffd8, 7ffa0c34, 0, 0) ntdll.dll.so`start_thread+0x12d(7da80fb8) libc.so.1`_thr_setup+0x4e(7e770a00) libc.so.1`_lwp_start(7e770a00, 0, 0, 7bdefff8, d0dc5ca0, 7e770a00 ::dis libwine.so.1.0`strlenW+0xf: cmpw $0x0,(%eax) but eax = 0 libwine.so.1.0`strlenW+0x13: je +0xa <libwine.so.1.0`strlenW+0x1d> libwine.so.1.0`strlenW+0x15: leal -0x4(%ebp),%eax libwine.so.1.0`strlenW+0x18: addl $0x2,(%eax) libwine.so.1.0`strlenW+0x1b: jmp -0xf <libwine.so.1.0`strlenW+0xc> libwine.so.1.0`strlenW+0x1d: movl 0x8(%ebp),%edx libwine.so.1.0`strlenW+0x20: movl -0x4(%ebp),%eax libwine.so.1.0`strlenW+0x23: subl %edx,%eax libwine.so.1.0`strlenW+0x25: sarl $0x1,%eax libwine.so.1.0`strlenW+0x27: leave libwine.so.1.0`strlenW+0x28: ret Bob

1 0

Re: How to enable font anti-aliasing in Wine?
by Rick Jones 24 Mar '09

24 Mar '09

> 2009/3/15 Roderick Colenbrander <thunderbird2k at gmx.net>: > > ... A string of registry changes enabled smoothed > fonts for me: > http://forum.winehq.org/viewtopic.php?p=20061&sid=6fbbcf362e44a66b310ef88f6… I was already using FontSmoothing=2 which was some improvement over nothing, but I didn't know these other settings. FontSmoothingType=2 made things much better, the others didn't seem to have any effect. However, I then discovered that with FontSmoothingType=2, a Java app I run in Wine crashes when it opens. :( The interesting item out of the Java stack trace is: Caused by: java.lang.IllegalArgumentException: 0 incompatible with Text-specific LCD contrast key Quite why Java is getting involved at this level I don't really know. Running on Windows with the same font smoothing settings it works fine. Puzzling ...

6 5

Re: [4] [wined3d] trigger constant reloading when RECT textures change
by Henri Verbeet 24 Mar '09

24 Mar '09

2009/3/23 Tobias Jakobi <Liquid.Acid(a)gmx.net>: > + if (!use_ps(stateblock) || (stateblock->wineD3DDevice->shader_backend != &glsl_shader_backend)) { Checking which backend is used is pretty ugly.

1 0

Re: [3] [wined3d] GLSL: implement texrect coord fixup
by Henri Verbeet 24 Mar '09

24 Mar '09

2009/3/23 Tobias Jakobi <Liquid.Acid(a)gmx.net>: > > + if (prog->ps_args.texrect_fixup) { > + for (i = 0; i < MAX_FRAGMENT_SAMPLERS; ++i) { Using something like the following would avoid checking the entire prog->rectFixup_location array when only the first few samplers are used: DWORD fixup = prog->ps_args.texrect_fixup; for (i = 0; fixup; fixup >>= 1, ++i) { if (!(fixup & 1)) continue; ... } > + /* Casting to IWineD3DTextureImpl* does work here, because rectFixup_location[i] > + * only gets initialized (with value != -1) when textures[i] is of type RECT. */ > + const IWineD3DTextureImpl* const tex = (const IWineD3DTextureImpl*)stateBlock->textures[i]; It works, but it's still unecessary. You can access the pow2Matrix through IWineD3DBaseTextureImpl just fine. Also note that * is part of the declarator rather than the base type in C. > + char texrect_fixup[28] = ""; Please don't do that, handle the fixup the same way bias is handled. > + sprintf(name, "PsamplerRectFixup%d", i); i is unsigned here.

1 0

Re: [2/2] quartz: Add a libavformat based MPEG demuxer.
by Chris Robinson 24 Mar '09

24 Mar '09

I wouldn't recommend this patch as being very safe. Having dealt with ffmpeg, my experience has been that it's ABI is not stable (the .so version number increments often, forcing recompilations). And when trying to update to new lib versions, things sometimes mysteriously break. Ultimately, FFmpeg is better off as a "built-in" code base. A project wishing to use it should pick a version and include it, and not rely on it externally.

4 4

flattering words about winetricks
by Dan Kegel 24 Mar '09

24 Mar '09

http://www.vivaolinux.com.br/dica/Winetricks-turbinando-seu-wine-sem-dores-… says "created by Dan Kegel, who was in a state of grace when he had this brilliant idea..." :-) (In case anyone has forgotten, winetricks is about the sixth in a long series of front-ends that try to make it easier to install software in wine, so it was hardly my idea. But I appreciate the sentiment.) - Dan

4 3

Re: Anything wrong with these patches ?
by Ricardo Filipe 23 Mar '09

23 Mar '09

2009/3/23 Massimo Del Fedele <max(a)veneto.com> > winex11.drv: SetDIBits fails when startscan != 0 > http://www.winehq.org/pipermail/wine-patches/2009-March/070788.html > (solves a bug on SetDIBits when transfer partial bitmap) > > gdi32/path.c -- Allow PATH_ExtTextOut() handle non printable characters > http://www.winehq.org/pipermail/wine-patches/2009-March/070768.html > (solves broken text output when text contains non-printable chars, as > space) > > gdi32/path.c - Fix PATH_ExtTextOut() for MapModes != MM_TEXT > http://www.winehq.org/pipermail/wine-patches/2009-March/070770.html > (solves bad placement/scaling on text when MapModes != MM_TEXT, AutoCAD bug > 17170) > > Ciao > > Max > > > > maybe wait until tomorrow to see if they get in or not. julliard came today from holidays and hasn't see every patch. ;)

1 0

Re: comctl32: implement TCM_REMOVEIMAGE (try2)
by Vitaliy Margolen 23 Mar '09

23 Mar '09

Nikolay Sivov wrote: > Changelog: > - try2: fix for several items with a same image case > - implement TCM_REMOVEIMAGE What about this comment from msdn? --------- The tab control updates each tab's image index, so each tab remains associated with the same image as before. If a tab is using the image being removed, the tab will be set to have no image. --------- It implies that indexes should be adjusted if you remove an image somewhere at the front or middle of the image list. Don't see you doing this in your patch. Vitaliy.

2 2

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).
by Ricardo Filipe 23 Mar '09

23 Mar '09

my next task was to fix this eheh. i think it would make more sense to just change if(!params->PathBuffer && !params->PathBufferSize) to if(!params->PathBuffer) as it was talked about in irc, it doesn't make much sense to check for pathbuffersize when pathbuffer is null... the max_path removal was a mistake from following msdn documentation :\ 2009/3/22 James Hawkins <truiken(a)gmail.com> > --- > dlls/setupapi/dialog.c | 12 +++++++----- > 1 files changed, 7 insertions(+), 5 deletions(-) > > > >

2 4

Re: comctl32: Implement TCM_REMOVEIMAGE message
by Nikolay Sivov 23 Mar '09

23 Mar '09

> >/From c419ca8f87ae3103e63604d9646d3851a5d959e7 Mon Sep 17 00:00:00 2001 > /From: Nikolay Sivov <bunglehead at gmail.com <http://www.winehq.org/mailman/listinfo/wine-patches>> > Date: Sun, 22 Mar 2009 18:43:46 -0400 > Subject: Implement TCM_REMOVEIMAGE It's wrong in case when several tabs use same image. Please ignore it.

1 0

Re: wined3d: Document the correlation of gl_shaders and num_gl_shaders with an assertion (Coverity 905).
by Henri Verbeet 22 Mar '09

22 Mar '09

2009/3/22 James Hawkins <truiken(a)gmail.com>: > --- > dlls/wined3d/vertexshader.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > I guess the nicer way to make Coverity shut up would be to replace "if(shader->gl_shaders) {" with "if (shader->num_gl_shaders)". Wouldn't the code in find_gl_pshader() in pixelshader.c cause the same warning though?

2 1

Chromium unit test suite as source of Wine tests
by Dan Kegel 22 Mar '09

22 Mar '09

Hey folks, the chromium project has a very nice unit test suite, and the chromium team pores over it with purify and now, on linux, valgrind to make sure everything is clean. This makes it a rather attractive test case for Wine even if Wine isn't really trying to run Chrome itself. I just filed three bugs for the problems found by chromium's base_unittests.exe, net_unittests.exe, and test_shell_tests.exe ( http://bugs.winehq.org/show_bug.cgi?id=17813 http://bugs.winehq.org/show_bug.cgi?id=17820 http://bugs.winehq.org/show_bug.cgi?id=17810 ), on top of the old bug about running chromium's ui_tests.exe http://bugs.winehq.org/show_bug.cgi?id=16552 I also added a suggestion about this in http://wiki.winehq.org/SummerOfCode It would be cool to see this test suite run daily to look for wine regressions somehow. OK, back to the native linux port of chromium... Cheers, Dan

1 0

Re: GSoC 2009 Proposal - AppDB Assistant
by André Hentschel 22 Mar '09

22 Mar '09

Ben Klein schrieb: > Grabbing the version number of the application from the EXE metadata > could prove to be unreliable. A lot of Windows apps don't include > metadata, or include unusual values in the metadata. Then again, a lot > of apps don't make it easy to see what the version you're using is in > any other way, and as a result there are a lot of "1.0" versions on > AppDB that map to "initial retail version". > > One example is Theme Hospital, which as the original retail version > was released as "Beta 4", and Bullfrog provided a patch that upgraded > to "Beta 5". The only hint of version numbers is provided by the patch > itself, and as a result some user wanted to submit a "1.0" version to > indicate the original retail release. As I was a supermaintainer of > Theme Hospital and already had the "Beta 4" version, I removed the 1.0 > version and engaged in a lengthy email discussion over whether the > retail release was "Beta 4" or "1.0". > > I am also afraid of reading this data, but we could give the user the choice to review it and correct it. > > There has been discussion about "preconfiguring" Wine with AppDB data, > and the general consensus is that it's a bad idea. We run the risk of > becoming like wine-doors, playonlinux, and other tools we don't > support at WineHQ. The biggest problem is that there is no way to > determine if any particular configuration will still work when a new > version of Wine or a new version of the app is installed. There are > also cases where installing a workaround/native DLL for one app will > cause a whole lot of others to break. > > It is a hard discussion, so lets have it when we got the AppDB Assistant running ;) No, really, the basic idea is great, but we don't should do all at once. For GSoC i think the best parts are the basic software implementation and the communication to the server.

1 0

GSoC 2009 Proposal - AppDB Assistant
by Illya Klymov 22 Mar '09

22 Mar '09

Hi all! A new GSoC is coming, and i have an idea which can may (or may not) serve as a proposal for a Wine project. Let's speak about it not as an application (so I wouldn't tell a lot about myself) but as an idea for application. AppDB is an excellent service for helping users dealing with one or another software. Unfortunately, currently i see several problems, which decrease it's efficiency: 1) there are tons of successful (or maybe not successful) reports, which were not submitted to AppDB. People are too lazy to fill many forms. A lot of users will just go away instead of filling report about application. 2) often in order to run an application you should follow some weird instructions, which sometimes miss some important steps, or require additional research by yourself. So, let's imagine we have a software which I call "AppDB Assistant" with following functionality: 1) an ability to quickly submit a report about application to AppDB. A lot of data (Wine version, Linux distribution, wine settings) could be obtained automatically. An application information with high probability could be fetched from meta data, stored in EXE file. In general, i see that like after closing an app I see additional screen "Please take a couple of seconds and send feedback about your experience with $SOFTWARE_NAME to AppDB", and buttons "Platinum","Gold", etc. Of course this should be configured via winecfg (if user do not want to obtain such data) 2) an ability to generate a "configuration guide" - in this mode an "expert user" selects important data to be included into a guide (for example that app runs _only_ under Windows XP emulation, an important registry values etc.). As a result a special file, describing an app-specific configuration of wine is uploaded to appdb 3) an ability to "preconfigure Wine". That means that based on "configuration guide" created on step 2 "AppDB Assistant" can configure wine in one click. If any additional dlls are required a warning message is displayed with possible information where to obtain them. I see the following benefits on such software: 1) increasing appdb actuality - with a way more data from users we can provide more accurate info; 2) simplified regression testing - for example if user downloaded a "configuration guide" and it didn't work with newer wine - this is a possible regression (decreased chance of human error) I realize that this is quite a big project, involving a different parts of Wine, but I'll be glad to hear response from community about this idea and which part probably could fit best for GSoC. Feel free to ask any question if something is unclear. P.S. Sorry for my bad English, it is far away from being my mother tongue. Best regards, Illya Klymov

2 1

Re: wine web pages update
by Vít Hrachový 21 Mar '09

21 Mar '09

Apostolos Syropoulos wrote: > > > Hello, > > I believe you the person responsible for the Wine web pages. If this is not true, > please disregard the rest of this message and accept my apologies for this > uninvited intrusion. > > Previous versions of the wine web pages includes information about Solaris/OpenSolaris > binaries and info about these systems. Now there is no mention about Solaris/OpenSolaris! > For example, the first page says "Run Windows Applications on Linux, BSD and MacOS". > OK Solaris is a commercial product but so is MacOS! Since I do release binary packages > of wine for both Solaris and OpenSolaris at http://ww.sunfreepacks.com could you include > this info in the download section. Also, could you please say something like "Run Windows > Application on most Unix and Unix-like systems". This shows impartiality and is far more > friendly. > > Thanks in advance for your cooperation. > > Apostolos Syropoulos Hi Apostolos, I can see no Wine packages on the link mentioned above. Maintainers of Wine webpages could be reached on wine-devel(a)winehq.org. Including wine-devel on list. BTW. There are IPS packages of 1.0.1 for OpenSolaris available (1). Recent Wine compiles well under OpenSolaris too (1.1.17). Cheers Hark 1) 2) http://pkg.opensolaris.org/contrib/en/index.shtml

4 3

Call for mentors
by Kai Blin 21 Mar '09

21 Mar '09

Hi folks, looking over the ideas list again, there are quite some projects that don't have a person willing to mentor yet, or list Dan Kegel, who's currently taking a break. If you feel like mentoring a student this summer, please pick one of these projects and put your name in the "Possible mentor" field. Thanks, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

GStreamer plugin proposal for GSoC 2009
by Eduard - Gabriel Munteanu 20 Mar '09

20 Mar '09

Hi, I'm interested in working with you as a student to create a GStreamer plugin for Wine. First, a little background about me. I'm a 2nd year student from Bucharest, Romania; my major is Systems Engineering. Last summer I spent my time developing kmemtrace (a memory tracer for the Linux kernel) under the mentorship of Pekka Enberg <penberg(a)cs.helsinki.fi> from Linux Foundation, that is GSoC 2008. So this would be my second year in GSoC. And I do tend to stick around after the SoC is over, since it's a great opportunity to get comfortable with a code base. You can check out my coding style and performance by looking at these Git repos: Ingo Molnar's -tip tree (my current "upstream"): http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftip%2Flinux-2.6-tip.git&a=s… My repo holding kmemtrace's userspace app: http://repo.or.cz/w/kmemtrace-user.git However, I'm aware of the differences in coding style between Wine and the Linux kernel. Regarding my skills, I'm quite proficient at using Git (managing my own tree and sending patches), coding in C and using autoconf. I also know some very basic concepts about DirectX, OpenGL and Wine's architecture. Also, this isn't my first contact with Wine's source code. Even though I haven't sent any patches to the mailing-list, I've spent some time reading the source code (chasing performance issues in Direct3D, but to no avail). You might have also seen me on IRC, bugging people about those issues. :-) Now getting to the point... I find the GStreamer plugin a very good idea. Glancing over GStreamer docs, I see it's very modular and could solve more issues than those already mentioned on the GSoC ideas page. I'll focus on what hasn't already been told. Firstly, it could also improve GDI+'s handling of images, as GStreamer already handles some image formats. Secondly, I've seen a patch implementing texture handling in d3dx being rejected because there is no general image library support in Wine and FreeImage wasn't a comfortable dependency: http://archives.free.net.ph/message/20080828.215032.87fd785e.en.html So this work could also have a positive impact on the proposal regarding the implementation of d3d9_xx DLLs. Bottom line is this won't "just play movies for DirectShow/Quartz", but it has a much greater potential. I admit, my main interest in developing Wine is improving a few games (e.g. Oblivion). I find this GSoC idea quite achievable for my skills and positive towards this goal. I also hope this experience would make a good introduction to implementing better DirectX support on Wine, generally speaking. Please let me know what you think and whether I've missed something. And please keep me Cc-ed if more people pitch into the discussion, as I'm not subscribed to the mailing-list. Cheers, Eduard

1 0

XInput2 (and relative mouse movements) will be in the next X release
by Scott Ritchie 20 Mar '09

20 Mar '09

After some chatting in #xorg-devel this week to follow up on the status of the long-awaited relative mouse movements, I have an announcement: Relative mouse movements will be in XInput2, and XInput2 will be in the next x.org release. This new release will be coming out roughly in the same timeframe as Wine 1.2, which makes relative mouse movement support very feasible for our coming release. If you want to test out a GIT version of XInput2 so you can get to work, you can check out the instructions at the bottom of the DInput page in the wiki: http://wiki.winehq.org/DInput whot (from #xorg-devel) told me that if we need any API changes to do this right, we can ask him. Now is the time. Thanks, Scott Ritchie

1 0

Re: setupapi: Indentation fix
by Andrew Talbot 19 Mar '09

19 Mar '09

Andrew Talbot wrote: > It's a tabs vs spaces thing, but it looks way out on my system. > You might wish to ignore this patch. I had my tab stops set to four spaces instead of eight, which exaggerated the distortion. -- Andy.

1 0

Re: include: Deconstify a variable
by Francois Gouget 19 Mar '09

19 Mar '09

On Sat, 14 Mar 2009, Andrew Talbot wrote: > Correct me if I'm wrong, but I don't think MapLS() takes a pointer to const. [...] > --- a/include/winbase.h > +++ b/include/winbase.h [...] > -WINBASEAPI DWORD WINAPI MapLS(LPCVOID); > +WINBASEAPI DWORD WINAPI MapLS(LPVOID); I could not find MapLS declared in winbase.h in any of the SDKs I have here. However I found it in win_me/inc16/thunks.h in an old DDK (Microsoft Windows 2000 DDK) but the declaration was: DWORD WINAPI MapLS(DWORD); But this being what looks like a 16bit include it probably does not mean much. So that leaves the questions of whether my latest SDK is recent enough (6.0.6001.18000.367-20080205), and why Wine declares MapLS in winbase.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A particle is an irreducible representation of the Poincaré Group - Eugene Wigner

3 2

Re: (try 2)advapi32: base implementation of LsaLookupNames2
by Paul Vriens 19 Mar '09

19 Mar '09

Aric Stewart wrote: > > fix tests for win95 > --- > dlls/advapi32/lsa.c | 51 +++++++++++++++++++++++++++- > dlls/advapi32/tests/lsa.c | 82 > ++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 131 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Aric, Just tested this on W2K. All functions but LsaLookupNames2 are available on W2K. This means now all tests (even though there were only 6) are skipped. Not sure it's worth the effort but maybe it's better to test for the existence of LsaLookupNames2 in the appropriate test only? -- Cheers, Paul.

2 1

[AppDB] Entry for Everquest 2
by Ben Klein 19 Mar '09

19 Mar '09

I just noticed that the entry for "Everquest II", the sequel to "Everquest", is listed as version 2 under "Everquest" in AppDB. This is incorrect, as the sequel is not a new version of the original game, it is a new game. Can someone help me fix it? I'd delete the version but there's quite a bit of test data there. I've CC'd the version maintainers.

5 9

Re: shell32/tests: Fix a test on Win2k platform and above.
by Paul Vriens 19 Mar '09

19 Mar '09

Nicolas Le Cam wrote: > Try2: Follow Vincent Povirk's suggestion of removing calls to > SetWindowLongPtr before destroying windows > > Could someone test this patch on Win9x or WinNT ? > > On Win2k (and according to test.winehq.org on above platforms) an > ABN_POSCHANGED message is sent to the last window that is removed. > > This patch change the ok to a win_skip in this case. > > Tell me if you have a better solution. > > Nicolas Le Cam > > > ------------------------------------------------------------------------ > > Hi, The "got unexpected ABN_POSCHANGED notification" messages I had before are now gone on my Win95 and NT4 boxes. (It was intermittent before on NT4 btw.) -- Cheers, Paul.

2 2

Summer of Code 2009 is on
by Kai Blin 19 Mar '09

19 Mar '09

Hi folks, Wine has been accepted into the Google Summer of Code 2009. If you're a student interested in working on Wine and getting some money (and a cool t-shirt) for it, consider applying. If there is any project you still want to see on http://wiki.winehq.org/SummerOfCode, add it now. If you're a Wine developer and tou want to mentor, let me know. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 2

Re: advapi32: base implementation of LsaLookupNames2
by Paul Vriens 19 Mar '09

19 Mar '09

Aric Stewart wrote: > --- > dlls/advapi32/lsa.c | 51 ++++++++++++++++++++++++++++++- > dlls/advapi32/tests/lsa.c | 75 > +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 125 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi, LsaFreeMemory and LsaLookupNames2 are not available on at least Win95. Please use GetProcAddress for the second one. LsaFreeMemory is already taken care of and should be prefixed with a 'p'. The tests will not run on Win95 but it avoids those nasty popups and makes sure the rest of advapi32 is tested. -- Cheers, Paul.

1 0

Re: comctl32: correct handling of toolbar separators' size
by Rob Shearman 18 Mar '09

18 Mar '09

2009/3/17 Igor Tarasov <tarasov.igor(a)gmail.com>: > Currently, wine uses iBitmap property for determining toolbar > separators width all the time, stating it's an undocumented feature. > This is not correct. > > According to MSDN, iBitmap is used only on inserting separator (since > there is no cx field in TBBUTTON structure). > http://msdn.microsoft.com/en-us/library/bb760476(VS.85).aspx > > In other cases, cx property that can be updated via get/set buttoninfo > is used, as tests show. Also, tests show that this property differs > from zero only if application specifically sets. Setting it to 0 makes > separator display in default width. All this is implemented in this > patch. More tests results in bugtracker (link below). Please ensure that there are no regressions in the display of IE6's toolbars after this patch. This is the main user of undocumented toolbar features. > @@ -4428,7 +4431,7 @@ TOOLBAR_SetButtonInfoA (HWND hwnd, WPARAM wParam, LPARAM lParam) > if (lptbbi->dwMask & TBIF_LPARAM) > btnPtr->dwData = lptbbi->lParam; > if (lptbbi->dwMask & TBIF_SIZE) > - btnPtr->cx = lptbbi->cx; > + btnPtr->cx = lptbbi->cx; > if (lptbbi->dwMask & TBIF_STATE) > btnPtr->fsState = lptbbi->fsState; > if (lptbbi->dwMask & TBIF_STYLE) Whitespace only changes shouldn't be included in patches with other changes. -- Rob Shearman

2 4

Re: shell32/tests: Fix a test on Win2k platform and above.
by Nicolas Le Cam 18 Mar '09

18 Mar '09

2009/3/18 Vincent Povirk <madewokherd+8cd9(a)gmail.com>: > On Wed, Mar 18, 2009 at 11:46 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: >> Message notification comes from appbar3, I've checked hwnd handles. >> When calling last ABM_REMOVE there's no more appbars so Wine shouldn't >> send any notifications, if it does the broken macro (that will come >> with try2) will catch that. > > The window notified with ABN_POSCHANGED is never the window that > caused the notification. When a window is removed, every other window > gets a notification so it knows to update its position. > > The test is just getting that notification late. This is not broken. > > Vincent Povirk > Ok, did more testing ... It seems you're right, adding a do_events() call after each DestroyWindow() one seems to fix the test on Win2k. Do you think this is a better fix ? -- Nicolas Le Cam

2 2

Re: [urlmon/tests] Skip some tests on Vista and higher
by Jacek Caban 18 Mar '09

18 Mar '09

Hi Paul, Paul Vriens wrote: > Hi, > > The Gopher protocol has been removed from Vista (and later versions). hres = CoGetClassObject(&CLSID_GopherProtocol, CLSCTX_INPROC_SERVER, NULL, &IID_IUnknown, (void**)&unk); + if (hres == REGDB_E_CLASSNOTREG) { + win_skip("Gopher protocol has been removed as of Vista\n"); + return; + } As it was removed in newer Windows, I don't think it qualifies as missing functionality and we may consider removing it from Wine as well. I'd suggest to change existing ok() to accept REGDB_E_CLASSNOTREG and not call win_skip (perhaps trace or nothing). Thanks, Jacek

2 1

GSoC Idea: D3DXMesh
by Andrew Fenn 18 Mar '09

18 Mar '09

Just an idea I came up with for Google's summer of code is perhaps implementing some of the D3DXMesh header files and functions so that we can get on with implementing functions such as D3DXCleanMesh which I believe Assassin's Creed needs. I have no intention of applying for GSoC however it's an idea I'd like to put into the pot.

3 4

Re: shell32/tests: Fix a test on Win2k platform and above.
by Nicolas Le Cam 18 Mar '09

18 Mar '09

2009/3/18 Vincent Povirk <madewokherd+8cd9(a)gmail.com>: > On Wed, Mar 18, 2009 at 9:39 AM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: >> I don't think calling SHAppBarMessage with ABM_REMOVE destroy the >> window and the ABN_POSCHANGED notification is catched between this >> call and the DestroyWindow one. But this particular behaviour only >> happens on Win2k and perhaps previous windows versions (should be >> tested) not on XP and later ones, that's why I wanted to keep your >> approach and mark this particular behaviour as broken (even if I >> didn't use the right approach as noticed by Paul) to force wine to >> behave like recent windows versions > > Wine DOES send a notification to all other appbars when one appbar is > removed. However, Wine's SHAppBarMessage will never processes messages > in the queue, nor will DestroyWindow. > > I really think you're getting the notification from destroying > appbar2, and you just happen to be getting it late. Windows' > implementation does have a tendency to send us late messages. > > The failure does not indicate that Wine is behaving more like winxp > than win2k. It doesn't tell us anything helpful at all, as the details > are something no real app should ever rely on. Nor is it a broken way > to implement this API. > > I think this case should pass even on Wine. > > Vincent Povirk > Message notification comes from appbar3, I've checked hwnd handles. When calling last ABM_REMOVE there's no more appbars so Wine shouldn't send any notifications, if it does the broken macro (that will come with try2) will catch that. -- Nicolas Le Cam

1 0

Re: shell32/tests: Fix a test on Win2k platform and above.
by Vincent Povirk 18 Mar '09

18 Mar '09

On Tue, Mar 17, 2009 at 4:50 PM, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Tell me if you have a better solution. You should add some traces first to find out what window is getting this notification and when. The test data currently doesn't have enough information to decide on a correct fix. Vincent Povirk

2 3

Re: shell32/tests: Fix a test on Win2k platform and above.
by Paul Vriens 18 Mar '09

18 Mar '09

Nicolas Le Cam wrote: > On Win2k (and according to test.winehq.org on above platforms) an > ABN_POSCHANGED message is sent to the last window that is removed. > > This patch change the ok to a win_skip in this case. > > Tell me if you have a better solution. > > Nicolas Le Cam > > > ------------------------------------------------------------------------ > > I can see several extra notifications on W2K and below. You are now doing things different. Previously the test was to check if info is not NULL. Now you are only doing the test if info is NULL. I think a broken() would be more appropriate here. So something like: ok(info != NULL || broken(!info && !registered_count), /* W2K */ "got unexpected ABN_POSCHANGED notification\n"); Could you check the behavior on Win9x/NT4? I guess Vincent Povirk can comment better on the patch as he wrote the initial tests. -- Cheers, Paul.

3 2

Re: Registry: Set FontSmoothing as default enabled (AA)
by André Hentschel 17 Mar '09

17 Mar '09

Havin AA enabled in Gnome/KDE dont means you want it in wine and it works fine with your configuration or windows software. Mostly it will work, so it should be default. And like Dmitry said it is not a good idea: http://bugs.winehq.org/show_bug.cgi?id=16745

1 0

SoC: DirectShow/Gstreamer
by Trevor Davenport 17 Mar '09

17 Mar '09

Hi, I'm interested in applying for a GSoC project related to wine. I am looking at doing the DirectShow/Gstreamer idea that is listed in the wiki (http://wiki.winehq.org/SummerOfCode). From the idea description there are a number of factors that would make this an ideal solution. The description mentions the availability of legal codecs (from fluendo) plus the ability to use the codecs already exposed to gstreamer (ie. install a codec and native/wine applications instantly get support). Recently GStreamer has added some pipeline elements targeted at integrating with other frameworks (appsrc/appsink) which allow sending data down a gstreamer pipeline and/or recieving it. Prior to these you had to write your own element (this wasn't too much work either depending on your needs and may still be preferred for more compatibility). I am quite familiar with both C and GStreamer. I have never looked at DirectShow though from what i know they are similar in concept. GStreamer does have some DirectShow filters that allow it to use directshow elements inside GStreamer (on windows anyway). My experience with wine has been limited to my own experiments. I've played around with audio drivers for wine. I wrote one that used GStreamer and later adjusted this to use pulseaudio instead. I never got time to clean them up to the point of submitting them. I have a few questions in regard to this idea. Do you think this project would provide adequate work to occupy the SoC timeframe? I would have to learn DirectShow which I don't believe would be too difficult. I've worked with DirectSound/DirectX and would expect it to require a similiar amount of work. I've also spent a fair amount of time inside wine's source code looking into various bugs. I welcome any comments, suggestions or idea related to this. I'd love any feedback so I know this is an idea that is wanted (i would like it...i use wine quite often) and so my application is as good as it can be. Cheers, Trevor Davenport

3 3

Re: [riched20/tests] Changed tests for EM_FORMATRANGE
by James Mckenzie 17 Mar '09

17 Mar '09

Paul Vriens <paul.vriens.wine(a)gmail.com> wrote on March 16th: > >Hi, > >I've been playing with this and just wanted to see if anybody has comments on >these changed tests. > >Tests succeed on Win95/Win98 and W2K3 with every possible resolution (as we are >not relying on the resolution anymore) and 96/120 dpi. > Paul: Looks good to me. I still need someone to pick up the actual implementation code and work with it. I have other priorities right now and think that Tony Rollo's code will not work and will require major rework to function properly with RichOLE. James McKenzie

1 0

Re: SoC: DirectShow/Gstreamer
by paulo lesgaz 17 Mar '09

17 Mar '09

o --- En date de : Mar 17.3.09, Roderick Colenbrander <thunderbird2k(a)gmx.net> a écrit : De: Roderick Colenbrander <thunderbird2k(a)gmx.net> Objet: Re: SoC: DirectShow/Gstreamer À: "Trevor Davenport" <trevor.davenport(a)gmail.com>, wine-devel(a)winehq.org Date: Mardi 17 Mars 2009, 11h43 > Hi, > > I'm interested in applying for a GSoC project related to wine. I am > looking at doing the DirectShow/Gstreamer idea that is listed in the > wiki (http://wiki.winehq.org/SummerOfCode). From the idea description > there are a number of factors that would make this an ideal solution. > The description mentions the availability of legal codecs (from > fluendo) plus the ability to use the codecs already exposed to > gstreamer (ie. install a codec and native/wine applications instantly > get support). > > Recently GStreamer has added some pipeline elements targeted at > integrating with other frameworks (appsrc/appsink) which allow sending > data down a gstreamer pipeline and/or recieving it. Prior to these > you had to write your own element (this wasn't too much work either > depending on your needs and may still be preferred for more > compatibility). > > I am quite familiar with both C and GStreamer. I have never looked at > DirectShow though from what i know they are similar in concept. > GStreamer does have some DirectShow filters that allow it to use > directshow elements inside GStreamer (on windows anyway). > > My experience with wine has been limited to my own experiments. I've > played around with audio drivers for wine. I wrote one that used > GStreamer and later adjusted this to use pulseaudio instead. I never > got time to clean them up to the point of submitting them. > > I have a few questions in regard to this idea. Do you think this > project would provide adequate work to occupy the SoC timeframe? I > would have to learn DirectShow which I don't believe would be too > difficult. I've worked with DirectSound/DirectX and would expect it > to require a similiar amount of work. I've also spent a fair amount > of time inside wine's source code looking into various bugs. > > I welcome any comments, suggestions or idea related to this. I'd love > any feedback so I know this is an idea that is wanted (i would like > it...i use wine quite often) and so my application is as good as it > can be. > > Cheers, > Trevor Davenport > Hi Trevor, I was the one who put this project suggestion on the wiki. Personally I think it should be a fine soc project. The project would be quite flexible. I expect that the project is too broad and initially should be confined to some widely used audio / video codecs and some widely used rendering methods (rgb / yuv). There will likely be bugs enough to fix ;) Further I would define one or more apps you want to get working. If I remember correctly some games want to use mpeg or divx for movie playback (Warcraft III uses another codec). The ultimate app to get working using wine's quartz + gstreamer would of course be Windows Media Player ;) Though an open source media player like Media player classic which can use the same codecs is likely easier because you have the source. Roderick -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01 It would be great if the winemp3.acm decoder could be removed and that Wine can decode mpeg1 (tons of game uses this codec) Now, for the SoC application: In the past years, some SoC did not lead any patches in the Wine git tree: applicants gave up before the end, or they did not clean their patches to be put in the tree. To avoid this, the last year, it was requested for the applicants to have a few patches committed before applying. That showed that thy knew how Wine work. I think that it was a good idea. Maybe it was a consequence of that, but almost the SoC gave quite a lot of patches in the tree. Could this be done again for this year. David

1 0

New Coverity run
by Paul Vriens 17 Mar '09

17 Mar '09

Hi, Just wanted to mention that there is a new Coverity run. There were some issues the last weeks that made sure the source wasn't updated (most likely started with the disk issue on winehq.org early February). -- Cheers, Paul.

1 0

[riched20/tests] Changed tests for EM_FORMATRANGE
by Paul Vriens 16 Mar '09

16 Mar '09

Hi, I've been playing with this and just wanted to see if anybody has comments on these changed tests. Tests succeed on Win95/Win98 and W2K3 with every possible resolution (as we are not relying on the resolution anymore) and 96/120 dpi. -- Cheers, Paul. diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c index 331fd69..d72ef77 100644 --- a/dlls/riched20/tests/editor.c +++ b/dlls/riched20/tests/editor.c @@ -4706,46 +4706,95 @@ static void test_WM_PASTE(void) static void test_EM_FORMATRANGE(void) { - int r; - FORMATRANGE fr; + int i, tpp_x, tpp_y; HDC hdc; HWND hwndRichEdit = new_richedit(NULL); - - SendMessage(hwndRichEdit, WM_SETTEXT, 0, (LPARAM) haystack); + static const struct { + const char *string; /* The string */ + int first; /* First 'pagebreak', 0 for don't care */ + int second; /* Second 'pagebreak', 0 for don't care */ + } fmtstrings[] = { + {"WINE wine", 0, 0}, + {"WINE wineWine", 0, 0}, + {"WINE\r\nwine\r\nwine", 5, 10}, + {"WINE\r\nWINEwine\r\nWINEwine", 5, 14}, + {"WINE\r\n\r\nwine\r\nwine", 5, 6} + }; hdc = GetDC(hwndRichEdit); ok(hdc != NULL, "Could not get HDC\n"); + + /* Calculate the twips per pixel */ + tpp_x = 1440 / GetDeviceCaps(hdc, LOGPIXELSX); + tpp_y = 1440 / GetDeviceCaps(hdc, LOGPIXELSY); - fr.hdc = fr.hdcTarget = hdc; - fr.rc.top = fr.rcPage.top = fr.rc.left = fr.rcPage.left = 0; - fr.rc.right = fr.rcPage.right = GetDeviceCaps(hdc, HORZRES); - fr.rc.bottom = fr.rcPage.bottom = GetDeviceCaps(hdc, VERTRES); - fr.chrg.cpMin = 0; - fr.chrg.cpMax = 20; + SendMessage(hwndRichEdit, EM_FORMATRANGE, FALSE, 0); - r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, 0); - todo_wine { - ok(r == 31, "EM_FORMATRANGE expect %d, got %d\n", 31, r); - } + for (i = 0; i < sizeof(fmtstrings)/sizeof(fmtstrings[0]); i++) + { + FORMATRANGE fr; + GETTEXTLENGTHEX gtl; + SIZE stringsize; + int r, len; - r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, (LPARAM) &fr); - todo_wine { - ok(r == 20 || r == 9, "EM_FORMATRANGE expect 20 or 9, got %d\n", r); - } + SendMessage(hwndRichEdit, WM_SETTEXT, 0, (LPARAM) fmtstrings[i].string); - fr.chrg.cpMin = 0; - fr.chrg.cpMax = 10; + gtl.flags = GTL_NUMCHARS | GTL_PRECISE; + gtl.codepage = CP_ACP; + len = SendMessageA(hwndRichEdit, EM_GETTEXTLENGTHEX, (WPARAM)&gtl, 0); - r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, (LPARAM) &fr); - todo_wine { - ok(r == 10, "EM_FORMATRANGE expect %d, got %d\n", 10, r); - } + /* Get some size information for the string */ + GetTextExtentPoint32(hdc, fmtstrings[i].string, strlen(fmtstrings[i].string), &stringsize); - r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, 0); - todo_wine { - ok(r == 31, "EM_FORMATRANGE expect %d, got %d\n", 31, r); + /* Define the box to be half the width needed and a bit larger than the height. + * Changes to the width means we have at least 2 pages. Changes to the height + * is done so we can check the changing of fr.rc.bottom. + */ + fr.hdc = fr.hdcTarget = hdc; + fr.rc.top = fr.rcPage.top = fr.rc.left = fr.rcPage.left = 0; + fr.rc.right = fr.rcPage.right = (stringsize.cx / 2) * tpp_x; + fr.rc.bottom = fr.rcPage.bottom = (stringsize.cy + 10) * tpp_y; + + r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, 0); + todo_wine { + ok(r == len, "(EM_FORMATRANGE) Expected %d, got %d\n", len, r); + } + + /* We know that the page can't hold the full string. See how many characters + * are on the first one + */ + fr.chrg.cpMin = 0; + fr.chrg.cpMax = -1; + r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, (LPARAM) &fr); + todo_wine { + ok(fr.rc.bottom == (stringsize.cy * tpp_y), "Expected bottom to be %d, got %d\n", (stringsize.cy * tpp_y), fr.rc.bottom); + } + if (fmtstrings[i].first) + todo_wine { + ok(r == fmtstrings[i].first, "(EM_FORMATRANGE) Expected %d, got %d\n", fmtstrings[i].first, r); + } + else + ok(r < len, "(EM_FORMATRANGE) Expected < %d, got %d\n", len, r); + + /* Do another page */ + fr.chrg.cpMin = r; + r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, (LPARAM) &fr); + if (fmtstrings[i].second) + todo_wine { + ok(r == fmtstrings[i].second, "(EM_FORMATRANGE) Expected %d, got %d\n", fmtstrings[i].second, r); + } + else + ok (r < len, "(EM_FORMATRANGE) Expected < %d, got %d\n", len, r); + + /* There is at least on more page, but we don't care */ + + r = SendMessage(hwndRichEdit, EM_FORMATRANGE, TRUE, 0); + todo_wine { + ok(r == len, "(EM_FORMATRANGE) Expected %d, got %d\n", len, r); + } } + ReleaseDC(NULL, hdc); DestroyWindow(hwndRichEdit); }

2 1

Re: Registry: Set FontSmoothing as default enabled (AA)
by Stefan Dösinger 16 Mar '09

16 Mar '09

Am Montag, 16. März 2009 17:46:17 schrieb André Hentschel: > Many people report they are missing AA, but its already implemented. > This Patch changes the wine.inf to enable it as default. I don't know how that would be done, but wouldn't it be better to read this on startup from the KDE/Gnome system settings? That way we avoid people asking how to disable AA

1 0

Re: How to enable font anti-aliasing in Wine?
by André Hentschel 16 Mar '09

16 Mar '09

In my case there is no ~/.fonts.conf That depends too much on distribution and windows manager. I think it should be on by default and if there might be problems you can turn it off in registry.

2 1

Re: wldap32: Silence a compiler warning.
by Michael Stefaniuc 16 Mar '09

16 Mar '09

Dmitry Timoshkov wrote: > --- > dlls/wldap32/parse.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/wldap32/parse.c b/dlls/wldap32/parse.c > index f7e93dd..6439ba6 100644 > --- a/dlls/wldap32/parse.c > +++ b/dlls/wldap32/parse.c > @@ -444,7 +444,7 @@ INT CDECL ldap_parse_vlv_controlW( WLDAP32_LDAP *ld, PLDAPControlW *control, > > #ifdef HAVE_LDAP_PARSE_VLV_CONTROL > if (!(ret = ldap_parse_vlv_control( ld, controlU, &pos, &count, > - context, errcode ))) > + (struct berval **)context, errcode ))) > { > *targetpos = pos; > *listcount = count; Dmitry,, Alexandre doesn't want to accept that patch. See http://www.winehq.org/pipermail/wine-devel/2009-January/072151.html bye michael

2 1

Re: riched20: add tests for EM_FORMATRANGE
by Paul Vriens 16 Mar '09

16 Mar '09

Lei Zhang wrote: > Hi, > > In my last attempt, I submitted Troy Rollo's EM_FORMATRANGE > implementation and with my test cases. I'm not sure what was wrong > with the implementation, but the test cases should be ok. > > > ------------------------------------------------------------------------ > > Hi Lei, Pretty old patch. (June 2007) I just moved some of my VMware 'boxes' to my new laptop (laptop resolution 1024x800) and I suddenly had some failures. The resolution that VMware can use (with all those borders and the sidebar) is 1044x574. Running the tests fullscreen makes them pass again. You can replicate this by playing with the screen resolution. The smaller the resolution the more test failures. Any idea where I need to look? -- Cheers, Paul.

3 6

Re: [1/7] mshtml: Implement IHTMLStyle get/put borderLeftWidth (resend)
by Alistair Leslie-Hughes 16 Mar '09

16 Mar '09

Could I get some feedback on this patch please? Best Regards Alistair Leslie-Hughes -------------------------------------------------------------------------------- > >From 60473b955b3b35feb089ad1cbf1320ce9f971020 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Thu, 5 Mar 2009 20:44:38 +1100 > Subject: [PATCH] Implement IHTMLStyle get/put borderLeftWidth > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/htmlstyle.c | 11 +++++++---- > dlls/mshtml/htmlstyle.h | 1 + > dlls/mshtml/tests/dom.c | 19 +++++++++++++++++++ > 3 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index 7641701..10f90e1 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -59,6 +59,8 @@ static const WCHAR attrBorderLeft[] = > {'b','o','r','d','e','r','-','l','e','f','t',0}; > static const WCHAR attrBorderLeftStyle[] = > > {'b','o','r','d','e','r','-','l','e','f','t','-','s','t','y','l','e',0}; > +static const WCHAR attrBorderLeftWidth[] = > + > {'b','o','r','d','e','r','-','l','e','f','t','-','w','i','d','t','h',0}; > static const WCHAR attrBorderRightStyle[] = > > {'b','o','r','d','e','r','-','r','i','g','h','t','-','s','t','y','l','e',0}; > static const WCHAR attrBorderRightWidth[] = > @@ -138,6 +140,7 @@ static const struct{ > {attrBorderColor, DISPID_IHTMLSTYLE_BORDERCOLOR}, > {attrBorderLeft, DISPID_IHTMLSTYLE_BORDERLEFT}, > {attrBorderLeftStyle, DISPID_IHTMLSTYLE_BORDERLEFTSTYLE}, > + {attrBorderLeftWidth, DISPID_IHTMLSTYLE_BORDERLEFTWIDTH}, > {attrBorderRightStyle, DISPID_IHTMLSTYLE_BORDERRIGHTSTYLE}, > {attrBorderRightWidth, DISPID_IHTMLSTYLE_BORDERRIGHTWIDTH}, > {attrBorderStyle, DISPID_IHTMLSTYLE_BORDERSTYLE}, > @@ -1571,15 +1574,15 @@ static HRESULT WINAPI > HTMLStyle_get_borderBottomWidth(IHTMLStyle *iface, VARIANT > static HRESULT WINAPI HTMLStyle_put_borderLeftWidth(IHTMLStyle *iface, > VARIANT v) > { > HTMLStyle *This = HTMLSTYLE_THIS(iface); > - FIXME("(%p)->(v%d)\n", This, V_VT(&v)); > - return E_NOTIMPL; > + TRACE("(%p)->(v%d)\n", This, V_VT(&v)); > + return set_nsstyle_attr_var(This->nsstyle, STYLEID_BORDER_LEFT_WIDTH, > &v, 0); > } > > static HRESULT WINAPI HTMLStyle_get_borderLeftWidth(IHTMLStyle *iface, > VARIANT *p) > { > HTMLStyle *This = HTMLSTYLE_THIS(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, p); > + return get_nsstyle_attr_var(This->nsstyle, STYLEID_BORDER_LEFT_WIDTH, > p, 0); > } > > static HRESULT WINAPI HTMLStyle_put_borderStyle(IHTMLStyle *iface, BSTR v) > diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h > index 596f579..b900e67 100644 > --- a/dlls/mshtml/htmlstyle.h > +++ b/dlls/mshtml/htmlstyle.h > @@ -47,6 +47,7 @@ typedef enum { > STYLEID_BORDER_COLOR, > STYLEID_BORDER_LEFT, > STYLEID_BORDER_LEFT_STYLE, > + STYLEID_BORDER_LEFT_WIDTH, > STYLEID_BORDER_RIGHT_STYLE, > STYLEID_BORDER_RIGHT_WIDTH, > STYLEID_BORDER_STYLE, > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index f95b753..be877b2 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -3587,6 +3587,25 @@ static void test_default_style(IHTMLStyle *style) > ok(hres == S_OK, "put_borderBottomWidth: %08x\n", hres); > VariantClear(&vDefault); > > + /* borderLeftWidth */ > + hres = IHTMLStyle_get_borderLeftWidth(style, &vDefault); > + ok(hres == S_OK, "get_borderLeftWidth: %08x\n", hres); > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = a2bstr("10"); > + hres = IHTMLStyle_put_borderLeftWidth(style, v); > + ok(hres == S_OK, "put_borderLeftWidth: %08x\n", hres); > + VariantClear(&v); > + > + hres = IHTMLStyle_get_borderLeftWidth(style, &v); > + ok(hres == S_OK, "get_borderLeftWidth: %08x\n", hres); > + ok(!strcmp_wa(V_BSTR(&v), "10px"), "expected 10px = %s\n", > dbgstr_w(V_BSTR(&v))); > + VariantClear(&v); > + > + hres = IHTMLStyle_put_borderLeftWidth(style, vDefault); > + ok(hres == S_OK, "put_borderLeftWidth: %08x\n", hres); > + VariantClear(&vDefault); > + > hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, > (void**)&style2); > ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres); > if(SUCCEEDED(hres)) { > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

[PATCH] RESEND mountmgr.sys: implement tracking of fixed/hardisk devices
by Ben Klein 16 Mar '09

16 Mar '09

Out of all the drive types that can be set in winecfg, the only one that currently doesn't work is "Local disk", which should map to DRIVE_FIXED. It seems to me that define_unix_drive, which handles creation and changes to the "Drives" tab in winecfg, is missing the case for DRIVE_FIXED mapping to DEVICE_HARDISK_VOL, as it appears in the query_unix_drive later in mountmgr.c. I'd like some comment on whether this patch is appropriate. 2009/3/6 Ben Klein <shacklein(a)gmail.com>: > This fixes bug 17618, where setting a drive type to "Local disk" does not save > the appropriate change to the registry. The problem can be traced to mountmgr.c, > where define_unix_drive has no case for the type being "Local disk" > (DRIVE_FIXED).

1 0

[PATCH] RESEND programs/explorer: Allow spaces in virtual desktop names via command line /desktop option
by Ben Klein 16 Mar '09

16 Mar '09

I noticed I left off the component in the subject of a few of my recent patch submissions. Resend. I'd love to have suggestions on cleaning this up! :D 2009/3/9 Ben Klein <shacklein(a)gmail.com>: > The purpose of this patch should be pretty clear from the subject > line. Feel free to adjust the comments I've added; it seems like what > I've done here might not be completely obvious.

1 0

[Wine Documentation] GDB Help
by Andrew Look 16 Mar '09

16 Mar '09

Hello Wine Developers, Besides the winedbg --gdb mode, I found a way to run gdb directly on wine. I figured all or part of this text file I'm included could be appended to section 1.8 of the Wine documentation where other debuggers are discussed. Thanks, Andrew Look

1 0

Re: [AppDB] Entry for Everquest 2
by Ricardo Filipe 15 Mar '09

15 Mar '09

no test data was lost. it is all in the new link. i already stated the comments got lost and i'm sorry for that, i thought appdb would copy them too. and that's why i asked for the EQ maintainers to step up to be EQ2 maintainers. i apologize for the missing comments, again. 2009/3/15 John Beaulieu <john.beaulieu(a)comcast.net> > Hey, you caused comments, data, and maintainers to be removed. Thats not > cool. > > On Sun, 2009-03-15 at 11:18 +0000, Ricardo Filipe wrote: > > not really... it's a completly new game. i'll see if i can do > > something... > >

2 2

Re: [AppDB] Entry for Everquest 2
by Ricardo Filipe 15 Mar '09

15 Mar '09

actually ben, how to's and warnings also went away. i think beaulieu already found them elsewhere and updated the page with them, thanks ;) sorry about that again, i'll post a bug for moving data to also copy the rest of the page... 2009/3/15 Ben Klein <shacklein(a)gmail.com> > 2009/3/16 Ricardo Filipe <ricardojdfilipe(a)gmail.com>: > > no test data was lost. it is all in the new link. > > > > i already stated the comments got lost and i'm sorry for that, i thought > > appdb would copy them too. > > and that's why i asked for the EQ maintainers to step up to be EQ2 > > maintainers. i apologize for the missing comments, again. > > > > 2009/3/15 John Beaulieu <john.beaulieu(a)comcast.net> > >> > >> Hey, you caused comments, data, and maintainers to be removed. Thats not > >> cool. > >> > >> On Sun, 2009-03-15 at 11:18 +0000, Ricardo Filipe wrote: > >> > not really... it's a completly new game. i'll see if i can do > >> > something... > >> > > Thanks Ricardo. Pity about the comments, but Notes, HOWTOs and > Warnings are more useful than comments anyway, and comments tend to > get stale faster :) >

2 1

Re: wine - paths
by Ben Klein 15 Mar '09

15 Mar '09

2009/3/16 Joerg Schiermeier <info(a)schiermeier-software.de>: > Hello Ben, > > I update my debian including your repository to download the > wine-packages. Today in the morning the new version of wine 1.1.17 > came in. Now I saw in the list of processes this: > > ---<cite - begin>--- > UID PID PPID C STIME TTY TIME CMD > joerg 19311 3547 0 21:56 ? 00:00:00 winver > joerg 19314 1 3 21:56 ? 00:00:01 /usr/bin/../lib/../bin/wineserver > joerg 19320 1 0 21:56 ? 00:00:00 c:\windows\system32\services.exe > joerg 19322 19320 0 21:56 ? 00:00:00 c:\windows\system32\winedevice.exe cdenable > joerg 19327 19320 0 21:56 ? 00:00:00 c:\windows\system32\winedevice.exe MountMgr > joerg 19336 1 0 21:56 ? 00:00:00 c:\windows\system32\explorer.exe /desktop > joerg 19425 17858 0 21:57 pts/1 00:00:00 ps -f -u joerg > ---<cite - end>--- > (result of: ps -f -u joerg after starting winver - the wine version > info) > > This '/usr/bin/../lib/../bin/wineserver' is a little bit confused > isn't it? The executable 'wineserver' lives in '/usr/bin'. So this has to > be '/usr/bin/wineserver', or? > > What's wrong? It still works, that much demonstrates there's nothing actually "wrong". /usr/bin/../lib/../bin is the same as /usr/bin, it's just a bit roundabout. The ".." directories mean "go to the parent directory". Regardless, I've CC'd wine-devel in case it can be cleaned up.

1 0

How to enable font anti-aliasing in Wine?
by Roderick Colenbrander 15 Mar '09

15 Mar '09

Hi, This weekend I was reading the 'Dutch slashdot' (tweakers.net) about Wine 1.1.17 and a user was wondering when Wine would finally support font anti-aliasing. I said we have been supporting this for ages. I also thought I was using it on my own Debian system. When asking more and more users about it in #winehackers (Chris, Detlef, Marcus, Stefan ..) only Stefan had it working on a Wine 1.1.0 build he still had around on his system (he didn't have a newer normal Wine copy) on his Gentoo. Further nobody on Debian, Fedora, Gentoo or Suse had it working except someone on a old 1.0 Wine. For the record when anti-aliasing is around Winecfg should look like: http://stud4.tuwien.ac.at/~e0526822/winecfg.png (this on Stefan his 1.1.0). What is so special about Wine why anti-aliasing isn't working for most users? (it could be a regression) In Stefan his case it started working after installing a Windows tahoma.ttf. What is so special about this font? A modern Linux system has dozens or hundreds of fonts installed and both GNOME/KDE can use each font AA'ed without issues. Roderick -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger01

3 4

Patch for WineD3D to set Driver an Description (try 2)
by Mirek Slugeň 15 Mar '09

15 Mar '09

Hi, Fallout 3 and maybe other games or D3D apps needs such special settings, this patch should be ok, it is well tested. This patch is not hack! New wine registry settings: VideoDriver VideoDescription Patch is for current (14.03.2009) git. PS: For Fallout 3 you should use registry settings (or similar): "VideoDescription"="NVIDIA GeForce 9600 GT" "VideoDriver"="nv4_disp.dll" Mirek Slugen

2 1

Vacations
by Alexandre Julliard 15 Mar '09

15 Mar '09

Folks, There won't be any commits next week, as I'll be skiing... Release 1.1.18 should be on schedule two weeks from today, unless you send so many patches next week that I can't catch up (hint hint). See you all in a week! -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: include: Deconstify a variable
by Andrew Talbot 15 Mar '09

15 Mar '09

Oops! Please ignore this one: I only changed the prototype of MapLS() and forgot to change the definition. -- Andy.

1 0

Re: [try2] schannel/tests: Fix test on Win2k
by Paul Vriens 14 Mar '09

14 Mar '09

Nicolas Le Cam wrote: > Try2: This time with the patch... > > Win2k pro returns 1 Lsa package and 4 user packages. Mark them as > broken. > Also skip verification of second package's values if only one is > reported. > > Nicolas Le Cam > > > ------------------------------------------------------------------------ > > Hi, I did some investigations a few days ago. It looks like the comment "Second package: SChannel" is not correct. At least in the case of W2K3. I'm not sure if we need more checks (like Name)? -- Cheers, Paul.

1 0

Re: wined3d: fix wrong FIXME-Message
by André Hentschel 14 Mar '09

14 Mar '09

@Stefan Dösinger: > The if check isn't that correct either. Its correct, because gl_info <http://source.winehq.org/ident?i=gl_info>->max_vertex_samplers in my case is 32. I think it is really enough to fix the Message.

1 0

Re: wined3d: fix wrong FIXME-Message
by Stefan Dösinger 14 Mar '09

14 Mar '09

The if check isn't that correct either. If MAX_COMBINED_SAMPLERS >= 8 + 3 everything's fine too. d3d9 only supports 8 fixed function frag samplers and 3 vertex samplers at max, so even if we can't use all GL samplers together, we're still fine if we have 11 samplers available for the purpose of this test. This should silence the frag=16, vertex=16, total=16 complaint on d3d10 cards Am Samstag, 14. März 2009 15:45:58 schrieb André Hentschel: > In comment it sais: 'This is true if vsamplers + MAX_TEXTURES <= > max_samplers.' > The if-query asks for "MAX_TEXTURES + gl_info->max_vertex_samplers > > gl_info->max_combined_samplers",which is ok. > But the FIXME then has to say that it was expected to be smaller than > max_combined_samplers. > > --- > dlls/wined3d/directx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 2ec60d4..7c67638 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -912,7 +912,7 @@ static BOOL IWineD3DImpl_FillGLCaps(WineD3D_GL_Info > *gl_info) { > MAX_TEXTURES + gl_info->max_vertex_samplers > > gl_info->max_combined_samplers) { > FIXME("OpenGL implementation supports %u vertex > samplers and %u total samplers\n", > gl_info->max_vertex_samplers, > gl_info->max_combined_samplers); > - FIXME("Expected vertex samplers + MAX_TEXTURES(=8) > > > combined_samplers\n"); > > + FIXME("Expected vertex samplers + MAX_TEXTURES(=8) > <= combined_samplers\n"); > if( gl_info->max_combined_samplers > MAX_TEXTURES ) > gl_info->max_vertex_samplers = > gl_info->max_combined_samplers - MAX_TEXTURES;

2 1

[RFC] winedos: Initializations fix
by Andrew Talbot 14 Mar '09

14 Mar '09

Have I got this right? Thanks, -- Andy. --- Changelog: winedos: Initializations fix. diff --git a/dlls/winedos/int21.c b/dlls/winedos/int21.c index 0c7967f..cbce913 100644 --- a/dlls/winedos/int21.c +++ b/dlls/winedos/int21.c @@ -2182,6 +2182,7 @@ static BOOL INT21_FileAttributes( CONTEXT86 *context, else { TRACE( "SET FILE CREATION DATE AND TIME, file %s\n", fileA ); + MultiByteToWideChar(CP_OEMCP, 0, fileA, -1, fileW, MAX_PATH); handle = CreateFileW( fileW, GENERIC_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE, @@ -2207,8 +2208,8 @@ static BOOL INT21_FileAttributes( CONTEXT86 *context, INT_BARF( context, 0x21 ); else { - TRACE( "GET FILE CREATION DATE AND TIME, handle %d\n", - BX_reg(context) ); + TRACE( "GET FILE CREATION DATE AND TIME, file %s\n", fileA ); + MultiByteToWideChar(CP_OEMCP, 0, fileA, -1, fileW, MAX_PATH); handle = CreateFileW( fileW, GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE,

1 0

Wine+Java+Nvidia crashes
by Rick Jones 14 Mar '09

14 Mar '09

I'm running a Java app built for Windows (therefore needs Wine), and on a machine with Nvidia graphics it crashes when it tries to draw the main window. The exact same application and OS configuration on a different machine with Intel graphics works fine. It crashes in wined3d, although the application is only drawing plain windows and dialogs - it looks like Java awt always calls d3d9 which call wined3d :(. Relevant console output from wine is shown below, plus the stack from the app's error log. OS is Ubuntu 8.10, Wine ver. 1.1.16 on both machines. On the faiing machine the graphics is Nvidia GPU 5200 series, screen size 1280x1024. I have tried both with the accelerated Nvidia driver v.173, and with the standard Linux driver, it makes no difference. The machine that works is an Asus Eee 901 netbook, Intel graphics on 1024x600 screen. Both machines have 2GB RAM. Wine console output: fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface fixme:heap:RtlCompactHeap (0x110000, 0x0) stub fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface # # An unexpected error has been detected by Java Runtime Environment: # # EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x7d9c25c2, pid=8, tid=37 # # Java VM: Java HotSpot(TM) Client VM (11.2-b01 mixed mode, sharing windows-x86) # Problematic frame: # C [wined3d.dll+0x725c2] Stack trace: Stack: [0x03890000,0x03990000], sp=0x0398de48, free space=1015k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) C [wined3d.dll+0x725c2] C [wined3d.dll+0xaf2a0] C [d3d9.dll+0x12957] C [awt.dll+0xad577] C [awt.dll+0x9c60c] C [user32.dll+0xb06aa] C [user32.dll+0xb0afa] ... I've heard that wined3d and Nvidia don't play well together, but I don't know why this problem only shows up when running a Java app. Everything else I use works fine. If anyone would like more info let me know. -- Thanks Rick Jones

3 4

Re: server: Wineserver manpage in russian
by Andrey Turkin 13 Mar '09

13 Mar '09

Hi Nikolay, There are few issues: > +.BI wineserver\ [options] > +.SH ОПИСАНИЕ > +.B wineserver > +это сервис предоставляющая процессам Wine аналогичные набор функций, который > no comma after сервис; it should be "предоставляющий"; probably should be "набор функций, аналогичный тому, который" or something similar. > +ядро Windows предоставляет в системе Windows. > +.PP > +не задано, в качестве значения по умолчанию принимается 1. Оталдочная информация > Отладочная. > +Отображать сервер на переднем плане для более удобной отладки, например при > Sounds weird; maybe better would be "Не демонизировать сервер" or something similar, or "Не переводить wineserver в background для более удобной отладки"? > +Показать информацию о версию и выйти. > "о версии" > +.TP > +.B \-w, --wait > +Подождать пока текщий запущенный экземпляр > comma missing; "текущий". > +If set, the content of this variable is taken as the name of the directory where > +.B wineserver > +stores its data (the default is \fI$HOME/.wine\fR). Все процессы > not translated.

2 1

Re: user32: fix for the ending of menu tracking in the default handler of WM_CANCELMODE message.
by Rein Klazes 13 Mar '09

13 Mar '09

Rein Klazes schreef: > Hi, > > Proposed fix for some problems mentioned in the previous patch. > > I hope putting the logic in menu.c is an acceptable way to cross > the window<->menu border. If you want it somewhere else, let me know. > > Rein. > Several rounds of commits have gone by. Still not commited, no objections or comments to this patch and the accompanying test. Is there anything that I can do to get this moving forward? Rein.

2 2

GSoC 2009 application sent
by Kai Blin 13 Mar '09

13 Mar '09

Hi folks, I've just sent our application for this year's Summer of Code. Could everyone please have another look at the proposed projects at http://wiki.winehq.org/SummerOfCode to see if all the proposals are still current. Feel free to discuss new project ideas on the mailing list as well. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 3

Wine on Windows - wiki notes
by David Gerard 12 Mar '09

12 Mar '09

Wine on Windows is an idea of real-world usefulness, as newer versions of Microsoft Windows increasingly fail to support apps Wine still supports. I've started a wiki page: http://wiki.winehq.org/WineOnWindows This covers my experiments with the three main POSIX layers (Cygwin, MinGW and Interix) on XPsp3. Various people have told me they've got it to work before (native compilation and install on Windows), but I seem to be the one gathering data :-) If anyone who's done it could please (a) put there what they did with what versions of Wine and tools (b) check with current Wine, that would be most appreciated. - d.

4 7

Crashes on Win9x and NT4 in rpcrt4/tests/ndr_marshall
by Paul Vriens 12 Mar '09

12 Mar '09

Hi, As the authors of these tests, I'd thought to write directly to you. This rpcrt4 stuff is way over my head. The attached patch shows where Win95, Win98 and NT4 crash. The crash in test_ndr_allocate() actually happens at the assignment "mem_list_v2 = StubMsg.pMemoryList;". Any idea(s). How can I help getting this resolved? -- Cheers, Paul. diff --git a/dlls/rpcrt4/tests/ndr_marshall.c b/dlls/rpcrt4/tests/ndr_marshall.c index efbec2b..3252466 100644 --- a/dlls/rpcrt4/tests/ndr_marshall.c +++ b/dlls/rpcrt4/tests/ndr_marshall.c @@ -772,6 +772,8 @@ todo_wine { Passing a NULL ptr while we're a client && !must_alloc crashes on Windows, so we won't do that. */ + if (0) + { mem = NULL; StubMsg.IsClient = 0; StubMsg.Buffer = StubMsg.BufferStart; @@ -782,6 +784,7 @@ todo_wine { ok(my_alloc_called == num_additional_allocs, "%s: my_alloc got called %d times\n", msgpfx, my_alloc_called); my_alloc_called = 0; ok(StubMsg.MemorySize == 0, "%s: memorysize touched in unmarshal\n", msgpfx); + } /*** now must_alloc is true ***/ @@ -1383,6 +1386,11 @@ static void test_ndr_allocate(void) NdrClientInitializeNew(&RpcMessage, &StubMsg, &StubDesc, 0); ok(StubMsg.pMemoryList == NULL, "memlist %p\n", StubMsg.pMemoryList); + if (StubMsg.pMemoryList != NULL) + { + win_skip("Something is wrong\n"); + return; + } my_alloc_called = my_free_called = 0; p1 = NdrAllocate(&StubMsg, 10); p2 = NdrAllocate(&StubMsg, 24);

1 0

Re: d3d9/tests: Limit the back buffer to 800x600 in the scissor size test.
by Francois Gouget 12 Mar '09

12 Mar '09

On Thu, 12 Mar 2009, Michael Stefaniuc wrote: > Most netbooks have only a 1024x600 display size and a 1024x768 back > buffer fails on those. See > http://test.winehq.org/data/ae1802d01ba2ec12a51ffb450dc7810d03809fe9/wine_m… Maybe the test should check the screen size and skip the test if it is too small... (as a preventive mesure in case a PC has an even smaller screen) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.

4 3

Disabling File attachments on Wiki
by Vitaliy Margolen 12 Mar '09

12 Mar '09

Please disable file attachments on Wiki. There are no way to verify their validity and for the past week it's been a constant source of spam. IMHO file attachment does not belong on text only Wiki. If anyone needs to attach a patch a two - they can link it to the one in ML archives or even bugzilla. Vitaliy.

4 5

[patch review] add gl_vertex_program_point_size to state_pscale
by Erik Inge Bolsø 12 Mar '09

12 Mar '09

Hello! I'd like a review of this patch - does the approach look reasonable? (Not my code, but it fixes a bug I reported.) "The fires and smoke aren't fading, they're just not being sized properly. The game uses point sprites for these effects. No matter what distance, the pointsize is being set to 1." It fixes http://bugs.winehq.org/show_bug.cgi?id=8826 - I'm not sure if it breaks other apps yet. Patch from Cody Hamilton <codyh(a)ctzns.net> : *** state.c --- dlls/wined3d/state.c 2009-03-05 00:42:57.000000000 +1100 *************** *** 1448,1453 **** --- 1448,1461 ---- att[1] = B.f / scaleFactor; att[2] = C.f / scaleFactor; } + + if(stateblock->wineD3DDevice->shader_backend == &glsl_shader_backend) { + glEnable(GL_VERTEX_PROGRAM_POINT_SIZE); + checkGLcall("glEnable(GL_VERTEX_PROGRAM_POINT_SIZE)"); + } else { + glDisable(GL_VERTEX_PROGRAM_POINT_SIZE); + checkGLcall("glDisable(GL_VERTEX_PROGRAM_POINT_SIZE)"); + } if(GL_SUPPORT(ARB_POINT_PARAMETERS)) { GL_EXTCALL(glPointParameterfvARB)(GL_POINT_DISTANCE_ATTENUATION_ARB, att); -- -erik http://useofwords.blogspot.com/

2 1

Re: [5/6] wined3d: Get rid of some calls to getFormatDescEntry().
by Stefan Dösinger 12 Mar '09

12 Mar '09

Am Donnerstag, 12. März 2009 09:57:18 schrieb Henri Verbeet: I think these patches are a really good idea(4 and 5 specifically)! Once all the getFormatDescEntry() calls are gone from the rendering loop functions we can take out the search hack for the RGB formats in getFormatDescEntry()

1 0

Re: mshtml: Change long to LONG in mshtml.idl (HTML*Element stuff).
by Michael Stefaniuc 12 Mar '09

12 Mar '09

Alistair Leslie-Hughes wrote: > In Microsoft mshtml.idl "IHTMLElement.sourceIndex" has the long type, not LONG. LONG is typedef'ed to long in IDL. > Whats the reason for the change? long is always 32bit in IDL files but long is a 64bit integer on non-Windows 64bit OSes. Thus widl has to be fixed to output a 32bit integer for long when generating the C files. The widl fix itself is probably small but the "collateral damage" in the rest of the Wine code is one big patch with a 4 digit changed lines figure. This are preparation patches to make the final widl patch be a lot smaller. bye michael

1 0

Taking a break from Wine
by Dan Kegel 12 Mar '09

12 Mar '09

Every now and then, my wrists force me to take a break from Wine development. This time it's also a matter of focus; I would like to spend more time with my family while also focussing more on my day job. One of the three had to go, for a while at least. I will still try to update winetricks once a month, but it might be good if other folks volunteered to help out there; drop me a line if you're interested. Likewise, it would be good if someone else took on running patchwatcher. (Shame, I have these nice boxes here, just waiting to run it, and no time to do it.) I'd be happy to answer questions from anyone who wants to give it a shot. I may also still give talks about Wine here and there, if a good venue presents itself. Ta for now! - Dan

4 4

Re: Wiki challenge question on user account creation
by King InuYasha 11 Mar '09

11 Mar '09

Oops... ---------- Forwarded message ---------- From: King InuYasha <ngompa13(a)gmail.com> Date: Thu, Mar 5, 2009 at 4:34 AM Subject: Re: Wiki challenge question on user account creation To: Dmitry Timoshkov <dmitry(a)codeweavers.com> On Thu, Mar 5, 2009 at 12:07 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com>wrote: > "Dimi Paun" <dimi(a)lattica.com> wrote: > > On Wed, 2009-03-04 at 11:59 -0600, John Klehm wrote: >> >>> I wouldn't really want per save captcha either, per account creation >>> is what I was hoping would cut down the spam. If the accounts are >>> created manually not much we can do about it :( >>> >> >> I think that's the case. Which is why I think it's not worth doing, >> as we would just make it harder on most real users, while not detracting >> any of the spammers. >> > > Actually if there are a lot of user account creation every day in the Wine > wiki then there is something wrong with it. There are not that much Wine > developers and probably some active testers/appdb maintainers, who else > could pretend to have a user account in the Wine wiki? > > Moreover it will add additional maintenance >> burden on our part to keep the captchas operational. >> > > Isn't that an one time effort? > > -- > Dmitry. > > > A wiki shouldn't have users creating accounts every day, that is a bad indicator. Also, in theory, CAPTCHA code does only need a one-time effort, but most wikis do not implement the best way to do CAPTCHA, so unless Wine was to use ReCAPTCHA, they would need to make sure that the CAPTCHA made is confusing enough that a computer cannot read it, which means mixing colors, strike lines, shapes, etc. It doesn't help that WineHQ uses MoinMoin wiki, which afaik does not have a CAPTCHA extension available. Also, it's quite obvious that the Moin engine on WineHQ is modified, so even if there was one, it may not work, depending on the intensity of the changes to the engine.

3 7

Re: [ntdll] lookup_assembly function should returns STATUS_SUCCESS
by André Hentschel 11 Mar '09

11 Mar '09

STATUS_SUCCESS is 0x0, see http://source.winehq.org/source/include/ntstatus.h#L30

1 0

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c
by Jacek Caban 11 Mar '09

11 Mar '09

Hi Roman, > On parsing of manifest in PE module is possible access to zero address > and crash. It's happens because not all manifest attributes can be > specified and pointers in assembly_identity structure can be > uninitialized. This patch adds function for setting empty strings in > structure elements when they not initialized. Your patch looks like a workaround. You should fix the code to cope with NULL pointers correctly instead of allocating useless empty strings. Also initialize_assembly_identity doesn't make sense. ai is initialized a few lines later by memset call. Jacek

3 7

Re: shlwapi: Correct AssocCreate and tests (try 2)
by Jacek Caban 11 Mar '09

11 Mar '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > Added check for IUnknown, thanks Jacek. It would be better to return correct error on QueryInterface failure. Otherwise you're duplicating the code. Jacek

1 0

Re: [PATCH] 0001-Fixed-tests-in-dlls-ws2_32-tests-sock.c-for-simple_s.patch
by Juan Lang 11 Mar '09

11 Mar '09

Hi Andrew, diff --git a/dlls/dbghelp/type.c b/dlls/dbghelp/type.c index 947eb49..4e426e2 100644 --- a/dlls/dbghelp/type.c +++ b/dlls/dbghelp/type.c It seems rather unlikely that dbghelp is causing failures in the winsock tests. Perhaps dbghelp is getting invoked due to a crash? Besides, - sym_info->TypeIndex = (DWORD)type; + sym_info->TypeIndex = (DWORD_PTR)type; This doesn't appear correct. sym_info is a SYMBOL_INFO *, and SYMBOL_INFO.TypeIndex is declared as ULONG. The fix is likely to require storing an index into a table rather than a pointer in TypeIndex, since type (a struct symt **) won't fit in a ULONG. - tifp->ChildId[i] = (DWORD)*pt; + tifp->ChildId[i] = (DWORD_PTR)*pt; Same here. - WS(u_long) S_addr; + ULONG S_addr; (snip) -#define FIONBIO _IOW('f', 126, u_long) +#define FIONBIO _IOW('f', 126, ULONG) These casts are fishy. Why are ULONG and u_long (WS_u_long) different sizes? If they are, the includes are broken somehow, as there's simply no need for S_addr to be anything but 32 bits. --Juan

1 0

LookupAccountSidW returns "unexpected" username
by Andreas Rosenberg 11 Mar '09

11 Mar '09

While I did some experimenting with the proposals from Vitaliy Margolen to get an accepted patch for GetUserProfileDirectoryW, I found this behavior: OpenProcessToken(hProcess,TOKEN_QUERY,&hToken); ... GetTokenInformation( hToken, TokenUser, ptiUser, cbti, &cbti ) ... LookupAccountSidW( NULL, ptiUser->User.Sid, lpUserName, lpchSize,lpDomain, &cbDomain, &snu ); In Windows XP SP3 the LookupAccountSidW fills lpUserName with the name of the current user (same as GetUserName) Running this code in Wine results in the username: 'INTERACTIVE'. Seems like the LookupAccountSidW does something not compatible with Windows. Im thinking about writing a test code, but simply checking if the above code returns the same as GetUserNameW seems not correct, if test code should run under a different account as the actual login user. Is this a requirement for running the wine tests?

2 1

qmgr test failures
by Austin English 11 Mar '09

11 Mar '09

Howdy Rob, Looks like one of your recent qmgr patches added failure to qmgr: http://test.winehq.org/data/1b9a6fb4e9f5a76f1ca352bef121689df02d9289/#group… file.c:121: Test failed: GetRemoteName failed: 800706c6 file.c:124: Tests skipped: Unable to get remote name of test_file. file.c:138: Test failed: GetLocalName failed: 800706c6 file.c:141: Tests skipped: Unable to get local name of test_file. file: 6 tests executed (0 marked as todo, 2 failures), 2 skipped. qmgr: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. qmgr.c:217: Test failed: Adding a job in another process failed qmgr: 11 tests executed (0 marked as todo, 1 failure), 0 skipped. Could you take a look? -- -Austin

2 2

Fwd: Disabling File attachments on Wiki
by David Gerard 11 Mar '09

11 Mar '09

to list as well ---------- Forwarded message ---------- From: David Gerard <dgerard(a)gmail.com> Date: 2009/3/11 Subject: Re: Disabling File attachments on Wiki To: Dimi Paun <dimi(a)lattica.com> 2009/3/11 Dimi Paun <dimi(a)lattica.com>: > On Wed, 2009-03-11 at 08:02 -0600, Vitaliy Margolen wrote: >> Anyone? Also how about blocking this IP: 213.155.0.32 ? > Not sure how we can block that IP easily. If it has to do > with iptables, forget it. You add a line to moin_config.py : http://moinmo.in/AntiSpamFeatures#Black_Lists_--_detecting_spam_by_source MoinMoin doesn't have the sophisticated anti-vandal capabilities of MediaWiki, but it's far from helpless. - d.

1 0

Re: [3/6] wined3d: The adapters array should be owned by IWineD3DImpl.
by Allan Tong 11 Mar '09

11 Mar '09

On Wed, Mar 11, 2009 at 5:18 AM, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > @@ -4051,10 +4097,11 @@ static void WINE_GLAPI diffuse_d3dcolor(const void *data) > static void WINE_GLAPI specular_d3dcolor(const void *data) > { > DWORD specularColor = *((const DWORD *)data); > + GLbyte d[] = {D3DCOLOR_B_R(specularColor), > + D3DCOLOR_B_G(specularColor), > + D3DCOLOR_B_B(specularColor)}; > > - GL_EXTCALL(glSecondaryColor3ubEXT)(D3DCOLOR_B_R(specularColor), > - D3DCOLOR_B_G(specularColor), > - D3DCOLOR_B_B(specularColor)); > + specular_func_3ubv(d); > } > > static void WINE_GLAPI warn_no_specular_func(const void *data) > @@ -4110,6 +4157,7 @@ static void fillGLAttribFuncs(const WineD3D_GL_Info *gl_info) > } > specular_funcs[WINED3DDECLTYPE_FLOAT4] = invalid_func; > if(GL_SUPPORT(EXT_SECONDARY_COLOR)) { > + specular_func_3ubv = (glAttribFunc)GL_EXTCALL(glSecondaryColor3ubvEXT); > specular_funcs[WINED3DDECLTYPE_D3DCOLOR] = specular_d3dcolor; > } else { > specular_funcs[WINED3DDECLTYPE_D3DCOLOR] = warn_no_specular_func; This looks like an unrelated change. > @@ -4182,7 +4231,7 @@ BOOL InitAdapters(void) { > /* No need to hold any lock. The calling library makes sure only one thread calls > * wined3d simultaneously > */ > - if(numAdapters > 0) return Adapters[0].opengl; > + if (This->adapter_count) return This->adapters[0].opengl; > > TRACE("Initializing adapters\n"); Is this check still necessary? InitAdapters should only be called once per IWineD3DImpl object. - Allan

2 1

Re: [ddraw/tests 1/2] Fix a few test failures on W2K (VMware?)
by Paul Vriens 11 Mar '09

11 Mar '09

Paul Vriens wrote: > Hi, > > As acknowledged by Stefan, there is no point in testing colors if something > isn't drawn. > > I'm not sure if this is W2K specific or W2K in combination with VMware. > > Changelog > Fix a few test failures on W2K (VMware?) > Please ignore this series of 2. I'm first going to check the remark the Henri made about a possible missing EndScene. -- Cheers, Paul.

1 0

Re: [ddraw/tests 2/2] Mark some more tests are broken() on W2K
by Stefan Dösinger 11 Mar '09

11 Mar '09

Am Mittwoch, 11. März 2009 12:07:27 schrieb Paul Vriens: > + ok(hr == D3D_OK || > + broken(hr == D3DERR_SCENE_IN_SCENE), /* W2K */ > + "IDirect3DDevice7_BeginScene failed with %08x\n", hr); I don't like that one. I think I wrote those tests on Win2K partially, so I'd blame it on Vmware. Its ok to skip checking the colors to reduce follow-up tests, but I dislike accepting random errors because Vmware returns them. If you find a real Windows hardware driver that returns this error its ok to accept D3DERR_SCENE_IN_SCENE as a return value

3 2

ddraw/visual tests
by Paul Vriens 11 Mar '09

11 Mar '09

Hi Stefan, As you wrote most of the tests: I'm looking into some of the ddraw:visual failures (windows 2000 and I guess only VMware). Several tests draw quads but only if _BeginScene succeeded. Is it useful at all to check the colors afterwards if the quads are not drawn in the first place? I don't want to mark all those failures as broken() if failing _BeginScene could just do with a win_skip() for the test of a particular test. -- Cheers, Paul.

2 1

Wiki challenge question on user account creation
by John Klehm 11 Mar '09

11 Mar '09

Hey, After months of browseing the wiki recent changes rss feed I've been irked enough to try and see what could be done about it. I'm sure everyone is having fun playing whack a mole with the wikispam but I was hoping that we could do something similar to the forum account creation "Who is the maintainer of Wine" question. I'm hoping that would cut down on a large portion of the wiki spam, which is now up to several bogus posts per day. (hats off to those that have been scrubbing it clean!) Luckily it seems MoinMoin has a feature that provides exactly this: http://moinmo.in/TextCha However on that page it only mentions a challenge question for commits which wasn't quite what I wanted so I took a look at the source for stable release 1.8.2 http://hg.moinmo.in/moin/1.8/file/1f0db10c207f/MoinMoin/action/newaccount.p… Seems they have the challenge question for user account creation in that version. What's involved in upgrading? How can I get the current winehq wiki code/data? I would be interested in helping test this or patching but I'm not sure how to import the data into my test server. Regards, --John Klehm

6 11

Re: Fwd: [Wine] Re: The pros and cons of a wiki AppDB
by James Mckenzie 11 Mar '09

11 Mar '09

David Gerard <dgerard(a)gmail.com> wrote on March 8th: > >2009/3/8 James Mckenzie <jjmckenzie51(a)earthlink.net>: > >> Would you be willing to clean out the ash and trash that will show up with an open Wiki? > > >I already said I would, yes - that the only reason for not just >starting one is to avoid massive duplication of effort. > If we move to an open Wiki, be prepared to be very busy. I've seen spambots get past most, if not all, of the verification systems and bomb away. I've read where several systems had to shut them down for fear of being sued. At the present time, we have verification for exactly that reason. To keep the spam out and to pre-edit those entries that do not provide all of the information needed. > >> I don't have the time to do this and it REALLY sounds like you are volunteering since you are pushing this issue so hard. See there are VALID reasons for doing things the way we do them. > > >I'm sure there are. > I would love to see a Wiki, with pre-editing of the entries. This is possible, but would not address the problem you raised. James McKenzie

4 4

Re: mshtml: Implement IHTMLStyle4 get/put textOverflow
by Alistair Leslie-Hughes 11 Mar '09

11 Mar '09

Ignore this patch, we'll have to wait until Firefox 3.1 before CSS3 is supported. I forgot there was wine_todo. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:49B726BB.4000009@hotmail.com... > Hi, > > Changelog: > mshtml: Implement IHTMLStyle4 get/put textOverflow > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: winemaker: add project-parse function
by Francois Gouget 10 Mar '09

10 Mar '09

Here are some quick comments: You cannot add functions that are not used. So this patch should include the following lines from patch 0004: + if (defined $opt_work_dir) { + # Now scan the directory tree looking for source files and, maybe, targets + print "Scanning the source directories...\n"; + source_scan_directory(\@main_project,"","",0); + @projects=sort { @$a[$P_PATH] cmp @$b[$P_PATH] } @projects; + } elsif (defined $opt_work_file) { + if ($opt_work_file =~ /.dsp$/i or $opt_work_file =~ /.vcproj$/i) { + source_scan_project_file(\@main_project,0,$opt_work_file); + } And the relevant $opt_work_file lines so that it's functional. The vcproj parser is still pushing compilation options only to CXXEXTRA. I believe dsp files can only have one target. Can vcproj files have multiple targets? If not it should be possible to avoid the loop on %targets. Also, I think the dsp parser at least does not need @std_imports because if I'm not mistaken all the libraries to link with are explicitely mentionned in the file. It also seems like we should not have to play guessing games to 'Match sources'. So I think it should be possible to simplify that part of the code. The patch does not use $has_headers anymore but it still declares and sets it. Still a few unneeded '."' and '".' (concatenation issues). Could you move source_scan_project_file() and source_scan_workspace_file() above source_scan_directory()? That way later on the latter will be able to call the former without having to reorder the functions. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

2 1

RFC: Summer of Code Proposal: WINE XRDP Driver
by Steven Edwards 10 Mar '09

10 Mar '09

Abstract: The goal of this project is to implement rdpservice support in Wine by converting XRDP in to a Winelib application allowing the execution of Wine based applications over the RDP protocol, without the need of a X11 Session/Driver . RDP protocol offers significantly faster performance than X11 or VNC for network applications. Currently if you want to run a Wine application over XRDP you tend to run in to performance problems due to the overhead of the Win32↔X11↔VNC ↔ RDP translation. Workflow: Current Design Using XRDP and Wine (Bad) RDPClient ↔ XRDP ↔ VNC ↔ X11 ↔ X11DRIVER/Wine ↔ Win32 Application Proposed Design (Good) RDPClient ↔ Wine XRDP Daemon ↔ XRDPDriver/Wine ↔ Win32application Details: 1.I believe the most simple route will be to convert XRDP to a Winelib application. Alternatively XRDP will need to be modified to allow direct execution of Wine processes. The current design of XRDP session involves loading selected unix libraries such as a libvnc redirector or librdp redirector. Given that Wine processes tend to want to manage all of their own resources, I believe a Winelib port of XRDP is the most simple route. (I have actually built XRDP as a Winelib process in the past) . This gives us the ability to directly call Win32 functions like CreateProcess from the xrdp_wm to get a proof of concept up and going in short order. 2.a wine libXRDP driver will need to be developed to encapsulate the raw XRDP bitmaps and primitives to related Win32 functions . This of course means that it won't be feature complete for a long time, but as the Quartzdrv showed, it is possible to write a driver that works for simple Winelib applications in short order. 3.Similar to x11driver in Desktop mode, Wine is going to do all of its own Window management. Much like the idea of the SugaredWine, this session would always run explorer.exe Issues: 1.writing a Wine driver is hard. Really hard. Alexandre does not like new ones because he does not want to end up being the only one maintaining them. Also the current XRDP graphic support is very primitive. It's really going to need a DIB engine and all sorts of other magic. I expect given the speed of the RDP protocol, even without the DIB engine, its still going to be faster than running the standard X11->VNC->RDP bridge just due to the removal of many layers of redirection. 2.There are licensing issues. XRDP being based on rdesktop is GPL rather than LGPL. The xrdp_wm code is all orginal to the XRDP project and is really its own library. Based upon my discussions with the XRDP maintainer in the past, I expect we should be able to get some sort of license exception for us linking to this code. Alternatively it could be maintained out of tree by certain parties interested in this support. I know in the past CodeWeavers has expressed interest in a RDP driver and its possible there are other parties that would be willing to help maintain it once a proof of concept was developed and a business case proven. Links: http://wiki.winehq.org/SugaredWine http://wiki.winehq.org/WineExplorer http://wiki.winehq.org/DesktopWindow http://xrdp.sourceforge.net/ http://www.rdesktop.org/ -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 2

[1/5] vbscript: Added stub DLL
by Robert Wilhelm 10 Mar '09

10 Mar '09

Hi Jacek, thanks for looking at my patches. VB uses IDispatch, VBScript uses IDispatchEx. See MSDN doc for IDispatchEx. But I should probably delete this and other superfluous includes, as they currently not yet used. This is a spare time project for me in order to learn more about active scripting. Writing complete vbscript.dll is clearly too ambitious. My plan is to work further along, add more interfaces, code and finally get some "hello world" script running. Maybe this will be enough that others will join the party and e.g. start coding run-time library. Regards, Robert >Your patch series looks good for me, except one little problem: >+#include "windef.h" >+<#include "winbase.h" >+#include "winuser.h" >+#include "ole2.h" >+#include "dispex.h" >+#include "activscp.h" >+ <+ >+ > > >AFAIK VBScript is not based on IDispatchEx (except it uses just >IDispatch), so you shouldn't need to include dispex.h. (While we're at >this, also empty lines in the end of file should be removed). >BTW, are you planning working further on VBScript implementation?

1 0

problem
by savek 10 Mar '09

10 Mar '09

Hello, I have an issue with wine, which consists in: when I try run any windows binary, it shows blurry, distorsioned and illegible fonts, highly descouraging me about using it, could you give me a solution, please? I'm running ArchLinux on a P4 box, thanks.

2 1

Sufficient 1.2 release criterion: passing all tests on all platforms?
by Dan Kegel 10 Mar '09

10 Mar '09

Even without any new features, it seems to me that passing all tests on all platforms might all on its own merit a new stable release. That said, by the time we have that, we might well have 64 bit support working, too... - Dan

5 16

Fwd: SetDeviceGammaRamp
by Tom Wickline 10 Mar '09

10 Mar '09

Forward from wine-patches ---------- Forwarded message ---------- From: 郭强 <strongpan(a)163.com> Date: Tue, Mar 10, 2009 at 1:38 PM Subject: SetDeviceGammaRamp To: wine-patches(a)winehq.org Hi, I got a question about how to use SetDeviceGammaRamp Function. As in SDK, Remarks said:'*SetDeviceGammaRamp* succeeds only for devices with drivers that support downloadable gamma ramps in hardware.' And I tried in my pc, the function return FALSE. but in my friend's pc, it work well. Maybe my pc doesnot support downloadable gamma ramps. So How do I know if my device support that? What's the definition of downloadable gamma ramps ? And what kind of device support that? Thanks so much! -- ------------------------------ 网易邮箱，中国第一大电子邮件服务商 <http://www.yeah.net> -- http://www.wine-reviews.net/ http://bordeauxgroup.com/

1 0

Wow, 2003 is almost all green... only rpcrt4:server failing
by Dan Kegel 10 Mar '09

10 Mar '09

The wine test suite is making great progress towards passing on all platforms. http://test.winehq.org/data/tests/rpcrt4:server.html seems to be the sore thumb at the moment; it passes on XP and Wine, but fails everywhere else. I think this is the test that fails on the most platforms. - Dan

3 4

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share
by Francois Gouget 10 Mar '09

10 Mar '09

On Fri, 6 Mar 2009, Forest Hale wrote: > Fixed GetDriveTypeW to always report C: as DRIVE_FIXED, preventing problems with the Steam installer if /home is a network share or other special mount. > > + if (root && (root[0] == 'C' || root[0] == 'c')) return DRIVE_FIXED; I think you should not hardcode the c: drive here. Something based on GetSystemDirectory(), GetWindowsDirectory() or one of their relatives would be better (not sure exactly which should be used). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ There are 10 types of people in the world... those who understand binary and those who don't.

4 7

Re: [PATCH 1/4] gdi32/tests: Don't use bmType to skip tests on win9x - it's equal to 0 for monochrome bitmaps.
by Alexandre Julliard 10 Mar '09

10 Mar '09

Huw Davies <huw(a)codeweavers.com> writes: > --- > dlls/gdi32/tests/bitmap.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) The is_win9x test is broken, that GetWindowLongPtrW call will return 0 on all platforms, so it breaks the tests on Wine: gcc -m32 -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -Werror -o bitmap.o bitmap.c ../../../tools/winegcc/winegcc -m32 -B../../../tools/winebuild -mconsole bitmap.o brush.o clipping.o dc.o font.o gdiobj.o generated.o icm.o mapping.o metafile.o palette.o path.o pen.o testlist.o -o gdi32_test.exe.so ../../../libs/port/libwine_port.a -luser32 -lgdi32 -lkernel32 ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so bitmap.c && touch bitmap.ok bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap bitmap.c:105: Test failed: win9x does not initialize the bitmap make: *** [bitmap.ok] Error 10 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 1/5] gdi32/tests: Fix is_win9x test.
by Paul Vriens 10 Mar '09

10 Mar '09

Huw Davies wrote: > --- > dlls/gdi32/tests/bitmap.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Wouldn't it be better to do something like: SetLastError(0xdeadbeef); GetWindowLongPtrW(GetDesktopWindow(), GWLP_WNDPROC); is_win9x = (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED); The problem with actually using GetVersion() is that you should be able to run Wine in Win98 mode (winecfg) and have the tests still succeed. -- Cheers, Paul.

1 0

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (7)
by Vitaliy Margolen 10 Mar '09

10 Mar '09

Andreas Rosenberg wrote: > > ------------------------------------------------------------------------ Almost there, just few small things left. > + TRACE("%p %s %p\n", hToken, lpProfileDir, lpcchSize); Don't print output parameters[lpProfileDir] as string only as a point. Unless it's used as in/out. > + TRACE( "%p %s %p\n", hToken, debugstr_w(lpProfileDir), lpcchSize ); Same thing here. > +static const WCHAR profile_pathname[] = { > + 'S', 'o', 'f', 't', 'w', 'a', 'r', 'e', '\\', > + 'M', 'i', 'c', 'r', 'o', 's', 'o', 'f', 't', '\\', > + 'W', 'i', 'n', 'd', 'o', 'w', 's', ' ', 'N', 'T', '\\', > + 'C', 'u', 'r', 'r', 'e', 'n', 't', 'V', 'e', 'r', 's', 'i', 'o', 'n', '\\', > + 0 }; > + > +static const WCHAR profile_subkey[] = { > + 'P', 'r', 'o', 'f', 'i', 'l', 'e', 'L', 'i', 's', 't', > + 0 }; > + > +static const WCHAR profile_keyname[] = { > + 'P', 'r', 'o', 'f', 'i', 'l', 'e', 's', 'D', 'i', 'r','e', 'c', 't', 'o', 'r', 'y', > + 0 }; > + res = RegOpenKeyExW( HKEY_LOCAL_MACHINE, profile_pathname, 0L, KEY_QUERY_VALUE, &keyProfileDir ); > + res = RegGetValueW( keyProfileDir, profile_subkey, profile_keyname, RRF_RT_ANY, > + NULL, buffer, &sizePath ); /* RegGetValue expects pcbData in bytes */ You opening the wrong key and querying the wrong value. You should be opening "Software\\Microsoft\\Windows NT\\CurrentVersion\\ProfileList" key and getting the value of "ProfilesDirectory" entry. Now about those fixed size buffers in GetUserProfileDirectoryW(). Why can't you use the passed in buffer instead? And the last thing - token. Look at _GetUserSidStringFromToken() from shell32/shellpath.c how to get the user from the token. Vitaliy

2 1

[PATCH] [RFC] Make drive C always a "Local disk"
by Ben Klein 10 Mar '09

10 Mar '09

This patch should fix 17619 for new wineprefixes and other cases where C: is created. The logic is that C: should never be registered as a network share, which is the issue in 17619. It was suggested as a response to a previous patch that this should be relative to %SYSTEM% or something along those lines, but I believe that C: is a true special case, similar to how A: and B: are always reserved for floppy drives. I'm not sure if this is the right way to go, so I'd like comments :) Thanks

9 15

Re: [6/6] d3d8: Handles aren't supposed to be pointers.
by Paul Vriens 10 Mar '09

10 Mar '09

Henri Verbeet wrote: > > ------------------------------------------------------------------------ > > Hi, + EnterCriticalSection(&d3d8_cs); + *pToken = d3d8_allocate_handle(&This->handle_table, object); LeaveCriticalSection(&d3d8_cs); Is there a need for that extra EnterCriticalSection() (in _EndStateBlock)? There is one a few lines up. -- Cheers, Paul.

1 0

Re: [PATCH 1/4] mshtml: Added IHTMLElement::put_innerHTML implementation.
by Alistair Leslie-Hughes 09 Mar '09

09 Mar '09

Hi Jacek, Jacek Caban wrote: > --- > dlls/mshtml/htmlelem.c | 33 +++++++++++++++++++++++++++++++-- > dlls/mshtml/tests/dom.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 73 insertions(+), 2 deletions(-) > > > static const WCHAR xW[] = {'x',0}; + static const WCHAR yW[] = {'x',0}; > ------------------------------------------------------------------------ Should this be = {'y', 0}? Best Regards Alistair Leslie-Hughes

2 1

shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)
by Paul Vriens 09 Mar '09

09 Mar '09

Hi, I'm trying to fix the last remaining test failures for shlwapi/shreg on my Win95 box. When I crosscompile the full winetest and run "winetest shlwapi:shreg" on my Win95 box the test results are: shreg.c:248: Test failed: Expected ERROR_MORE_DATA, got (127) shreg.c:274: Test failed: Expected ERROR_MORE_DATA, got (127) When I now build just the shlwapi test the tests succeed (dwRet = 203) Any idea where these differences could come from? '203' is ERROR_ENVVAR_NOT_FOUND btw. '127' is ERROR_PROC_NOT_FOUND. Only ERROR_ENVVAR_NOT_FOUND sounds at least a little bit like a proper result as we are dealing with expanding envvars. ERROR_PROC_NOT_FOUND doesn't make sense at all. -- Cheers, Paul.

2 2

Process elevation
by Luke Benstead 09 Mar '09

09 Mar '09

Hi all, I was going to post this to #winehackers but it became too long so I'll post here instead :) When trying to run IE8 under Wine, you are greeted with the following error: err:ntdll:NtQueryInformationToken Unhandled Token Information class 18! In the TOKEN_INFORMATION_CLASS enum, 18 refers to TokenElevationType. The error occurs in NtQueryInformationToken which *should* set the value of a TOKEN_ELEVATION_TYPE ( http://msdn.microsoft.com/en-us/library/bb530718(VS.85).aspx ) instance. This basically returns whether or not a user is elevated, or can be elevated. I was going to have a go at fixing it, but I'm not sure what is the best value to set. Should Wine class a user as an admin and all processes run elevated? If so, then some applications may refuse to run as admin, and definitely the same is true that if the user isn't elevated, so programs will not run. I don't really know much about this elevation stuff (aside what I've read in the last half an hour) but I can't seem to work out what value NtQueryInformationToken should return out of: TokenElevationTypeDefault - User is a normal user and can't elevate TokenElevationTypeFull - User can and is elevated TokenElevationTypeLimited - User can elevate, but isn't currently elevated Should perhaps the elevation level be set by an environment variable, or registry setting? Luke.

2 1

Re: msi: Trace the username to help debug test failures on certain machines.
by Paul Vriens 09 Mar '09

09 Mar '09

James Hawkins wrote: > --- > dlls/msi/tests/source.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi, The issue seems to be present on boxes that are part of a domain. I guess we have to check for domain and use that in the passed username. -- Cheers, Paul.

1 0

Re: [1/6] wined3d: Buffer object ID's are supposed to be unsigned.
by Stefan Dösinger 09 Mar '09

09 Mar '09

Am Montag, 9. März 2009 14:36:57 schrieb Henri Verbeet: > - int VBO; /* Vertex buffer object this data is in */ > + unsigned int VBO; /* Vertex buffer object this data is in */ Wouldn't the really correct type be GLuint?

2 1

Re: shell32: szFullPath is needed even for SHGFI_PIDL and SHGFI_USEFILEATTRIBUTES flags combination (bug 17633)
by Alexandre Julliard 09 Mar '09

09 Mar '09

Petr Sumbera <Petr.Sumbera(a)Sun.COM> writes: > dlls/shell32/shell32_main.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c > index 78a2d57..f2f5924 100644 > --- a/dlls/shell32/shell32_main.c > +++ b/dlls/shell32/shell32_main.c > @@ -370,6 +370,8 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, > { > lstrcpynW(szFullPath, path, MAX_PATH); > } > + } else { > + ILGetDisplayNameExW(NULL, (LPCITEMIDLIST)path, szFullPath, 0); It seems to me you are just hiding the problem. If we have a pidl we shouldn't access the path directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] user32: Button should lose highlighting on focus loss (try2)
by Alexandre Julliard 09 Mar '09

09 Mar '09

Nikolay Sivov <bunglehead(a)gmail.com> writes: > You could easily reproduce this issue: > - highlight any checkbox with space key > - keep space pressed and changed focus (with arrows or tab) > After that checkbox will be unfocused but still highlighted wich is a bug. > The same applies of course to radiobuttons too. > > Changelog: > - Button should lose highlighting on focus loss It doesn't seem right to do this in two separate steps and repaint the button twice. This would need a test case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/iphlpapi/ipstats.c: #ifdef __linux__
by Austin English 09 Mar '09

09 Mar '09

On Sun, Mar 8, 2009 at 6:28 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > ChangeLog: > append_udp_row is only used on Linux. > > Index: dlls/iphlpapi/ipstats.c > =================================================================== > RCS file: /home/wine/wine/dlls/iphlpapi/ipstats.c,v > retrieving revision 1.71 > diff -u -3 -p -r1.71 ipstats.c > --- dlls/iphlpapi/ipstats.c 6 Mar 2009 16:00:36 -0000 1.71 > +++ dlls/iphlpapi/ipstats.c 8 Mar 2009 23:27:39 -0000 > @@ -1269,7 +1269,7 @@ done: > return ret; > } > > - > +#ifdef __linux__ > static MIB_UDPTABLE *append_udp_row( HANDLE heap, DWORD flags, MIB_UDPTABLE *table, > DWORD *count, const MIB_UDPROW *row ) > { > @@ -1289,6 +1289,7 @@ static MIB_UDPTABLE *append_udp_row( HAN > memcpy( &table->table[table->dwNumEntries++], row, sizeof(*row) ); > return table; > } > +#endif > > static int compare_udp_rows(const void *a, const void *b) > { > > > I already submitted this patch, but it was rejected. The function should be used on BSD, but needs to be implemented. See: http://www.winehq.org/pipermail/wine-devel/2009-March/073723.html http://www.winehq.org/pipermail/wine-devel/2009-March/073730.html -- -Austin

1 0

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop
by Paul Vriens 09 Mar '09

09 Mar '09

Jeff Latimer wrote: > MSDN defines an number of conditions that inet_ntop will return errors. > This patch tests for them. > --- > dlls/ws2_32/socket.c | 30 +++++++++++++++- > dlls/ws2_32/tests/sock.c | 83 > ++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 109 insertions(+), 4 deletions(-) > > > > ------------------------------------------------------------------------ > > I think you can get rid of these comments: /* MSDN says it returns ERROR_INVALID_PARAMETER in MSDN but Vista returns 0xc000000d - STATUS_INVALID_PARAMETER */ MSDN has proven to be wrong on occasion and there is no need to put that in the code. Secondly you shouldn't use magic number if you no the name: WSASetLastError(0xc000000d); In the tests you do: + ok(WSAGetLastError() == 0xC000000D, + "Should be ERROR_INVALID_PARAMETER not %x\n", WSAGetLastError()); Again the magic number and in this case the ok() message is wrong as that should be STATUS_INVALID_PARAMETER according to your testing. -- Cheers, Paul.

2 3

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa
by Paul Vriens 09 Mar '09

09 Mar '09

Jeff Latimer wrote: > Note that Inet_Ntop is only available in Vista and Windows 2008. This > patch removes the version testing. This one removes the redundant test > after GetModuleHandle and adds win_skip(). > --- > dlls/ws2_32/tests/sock.c | 68 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 68 insertions(+), 0 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi, There is no need to have two if (pInetNtop) statements right after each other, this could be just one. Maybe it's even better that before you start using pInetNtop, you do: if (!pInetNtop) { win_skip("InetNtop not present, not executing tests\n"); return; } You than don't need to indent the code anymore. -- Cheers, Paul.

2 1

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa
by Paul Vriens 09 Mar '09

09 Mar '09

Jeff Latimer wrote: > Note that Inet_Ntop is only available in Vista and Windows 2008. This > patch removes the version testing. > --- > dlls/ws2_32/tests/sock.c | 67 > ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 67 insertions(+), 0 deletions(-) > > > > > ------------------------------------------------------------------------ > > Two minor things: There is no need to to check the return value of GetModuleHandle as ws2_32 is already imported. Could you add a win_skip() somewhere so we know that some tests are skipped on some platforms? -- Cheers, Paul.

2 1

Re: [1/5] vbscript: Added stub DLL
by Jacek Caban 09 Mar '09

09 Mar '09

Hi Robert, Robert Wilhelm wrote: > Third try of my effort to get create vbscript skeleton similar to > jscript one. > Your patch series looks good for me, except one little problem: +#include "windef.h" +#include "winbase.h" +#include "winuser.h" +#include "ole2.h" +#include "dispex.h" +#include "activscp.h" + + + AFAIK VBScript is not based on IDispatchEx (except it uses just IDispatch), so you shouldn't need to include dispex.h. (While we're at this, also empty lines in the end of file should be removed). BTW, are you planning working further on VBScript implementation? Thanks, Jacek

1 0

Re: shlwapi: Correct AssocCreate and tests
by Jacek Caban 09 Mar '09

09 Mar '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > The spec file specified 4 parameters but it only takes 3. > Validate parameters to XP. > Added test cases. > > Tested on win98 and XP. > > Changelog: > shlwapi: Correct AssocCreate and tests > + hr = pAssocCreate(IID_NULL, &IID_NULL, NULL); + ok(hr == E_INVALIDARG, "Unexpected result : %08x\n", hr); refiid arguments looks like an interface id (and the whole function looks similar to IClassFactory::CreateInstance), so it would be interesting to add test of IID_IUnknown. Jacek

1 0

Some news about my DIB Engine.....
by Massimo Del Fedele 08 Mar '09

08 Mar '09

I've gone a bit further with my DIB Engine, mostly on gdi32 side, in order to solve the last problems, at least as seen in my favorite app, Autocad 2005. Previous version had a bug related to the *only* .net part of that app (which was obviously written by a 5 years old child, imho), the layer manager. On this one, a bitblt operation is done reading some screen part into a DIB when painting the dialog on screen. Worse than that, there are *many* small bitblt ops (like 40x1 pixels) on *large* source/destination bitmaps (like some hundred kB - MB of pixel data. Well, that stuff showed to me the big limit of the approach taken, the "mixed driver" one with different driver pointers on same DC. That's the approach taken by earlier intents of Jesse Allen and Huw Davies. So I decided to make a break, examining the problems so far and maybe discussing a bit about it. 1) Maintain DCs and bitmaps in sync with correct driver. That problem is fully solved, requiring some small hacks on many parts of gdi32, in detail in bitmap.c, dib.c and dc.c. Well, not really hacks, even if the code isn't as clean as I'd like. Difficulty here was mostly due to bmp funcs that should be identical to DC on which it's selected, on DIB creation and on BITMAP_SetOwnerDC() part. In short, that part should be quite good by now. 2) Now the big (and slow) problem : the "mixed" operations, those which uses both DIBs and DDB; BitBlt(), StretchBlt and so on. On those we can't simply use one driver because it can't handle other driver's bitmap. Well, X11 driver could do it, in theory, but having the DIB created by DIB engine makes it impossible (missing X11 physDev and related pixmap). So the problem, as correctly pointed by Jesse Allen, is to "uniformize" the DCs *before* the BlitBlt operation, *or* to make DIB engine able to deal with DDB stuffs. I discarded latter approach for obvious reasons, the engine would become a copy of X11 driver with added DIB stuffs, which would vanify the (simpler) approach taken. BTW, I'm still convinced that the "right" approach would be to rewrite X11 driver withe the engine embedded, OR to embed the engine on gdi32 taking it off X11 driver. Well, back to first approach, Jesse's one. It means to make a copy of the source bitmap *before* blitting converting it on same format of destination one. That approach is slower because it means to make a copy /conversion of the source bitmap which can be time expensive. Jesse's solution was to make a conversion of the *full* source bitmap which showed it's first limit on my Autocad testings (the layer manager part) on whith very small parts of a big image are Blitted. That means sometimes hundreds of copy/conversions of a MB sized bitmap just to transfer some 40 pixels a time..... not a real speed gain :-) So I decided to limit the copy of the needed lines of source bitmap, with help of GedDIBits/SetDIBits stuffs. Not perfect, but quite faster..... *if* working. SetDIBits seems to have some sort of bug when "startscan" and "scanlines" don't use the full bitmap's size. I'm not able to test the SetDIBits X11 code, so if somebody can check it that would be of great help to me. GetDIBits works good with those parameters selecting a stripe of full bitmap. Now, the second problem on that approach, which emerged testing the same autocad part. When blitting *from* screen device, there's no real BMP selected onto DC, so the GetDIBits approach is useless. The only way to cope with the problem is to make a (third) intermediate conversion, so DEVICE DC ---bitblt (X11 side)--->memory DC (DDB)---GetDIBits---> DIB That means 3 data transfers to make a BitBlt operation from display to a DIB destination bitmap.... Anyways, even with those bottlenecks, autocad application shows great speed improvements on TT fonts (from unusable to about the same windows xp speed) with no visible slow downs. Ciao Max

1 0

Fwd: Sufficient 1.2 release criterion: passing all tests on all platforms?
by David Gerard 08 Mar '09

08 Mar '09

to list as well ---------- Forwarded message ---------- From: David Gerard <dgerard(a)gmail.com> Date: 2009/3/8 Subject: Re: Sufficient 1.2 release criterion: passing all tests on all platforms? To: Dan Kegel <dank(a)kegel.com> 2009/3/8 Dan Kegel <dank(a)kegel.com>: > For graphics cards: > 1st tier: Nvidia 8400 or higher > 2nd tier: < 4 year old Nvidia, < 2 year old ATI, < 2 year old Intel > 3rd tier: older nvidia I would question Nvidia cards being first unless we're talking about the nv or nouveau drivers. The binary drivers are known to crash more with Wine because it puts more demands on them, and Nvidia is known not to care about this. The Intel drivers have the advantage of being good, being open source and being from a company that seriously cares about getting them right. Or, shorter: privileging a closed-source driver doesn't seem like a good idea. - d.

1 0

String expansion (%n %t)
by Rick Jones 08 Mar '09

08 Mar '09

Is there a Windows string function that expands escape sequences such as %n, %t, etc, and which is replicated by Wine? I ask because I have a Windows app that is screwing up because of something like this. It has a private .ini settings file, and some settings are stored in that kind of format, but when it runs on Wine they are wrongly retrieved (this is a 3rd party app, I don't have the source). It looks horribly like %n is being expanded to NL instead of CR-NL. If there's a Windows/Wine function for this then I might be able to use a native DLL to get round it, but I've no idea where it might reside! AFAIK GetPrivateProfileString() doesn't do this expansion inherently. Also if it is the case that the behaviour's different, then I would say it's a Wine bug. Any ideas appreciated. Rick

2 2

Running 16 bit builtin exes fails?
by Dan Kegel 08 Mar '09

08 Mar '09

With Friday's git, I can't run the new winhelp.exe16. $ cd programs/winhelp.exe16 $ wine winhelp.exe16.so fails with err:process:start_process L"Z:\\home\\dank\\wine32\\programs\\winhelp.exe16\\winhelp.exe16" doesn't have an entry point, it cannot be executed Did I miss some memo? This is on a 64 bit intel ubuntu 8.10 box, but wine was built as 32 bits. - Dan

3 5

Re: [wininet/tests 2/2] Skip some tests on IE5
by Paul Vriens 08 Mar '09

08 Mar '09

Paul Vriens wrote: > Hi, > > Ordinal 117 is CreateUrlCacheContainerA so these tests crashed on > systems with IE5. > > I also guess that IsDomainLegalCookieDomainW is only present on IE6 and > higher. > > Changelog > Skip some tests on IE5 > I of course meant to say "Ordinal 117 is CreateUrlCacheContainerA in wininet.dll that comes with IE5". -- Cheers, Paul.

1 0

Re: Sufficient 1.2 release criterion: passing all tests on all platforms?
by Paul Vriens 08 Mar '09

08 Mar '09

Dan Kegel wrote: > On Sun, Mar 8, 2009 at 5:05 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: >> For that sole reason I started with installing a basic W2K box without >> servicepacks and patches. The last remaining few failures on my boxes are >> not the easiest ones but there are loads of (easier to fix) failures still >> out there. > > But golly, there are so few failures on XP/2003/vista/2008, > how 'bout we focus on those? > (Sorry, forgot to include list) That rpcrt4 is a tricky one as it only seems to be caused by a winetest compiled on test.winehq.org. Crosscompiling myself doesn't exhibit these issues. Maybe it's not only crosscompilation but other (yet unknown) factors. -- Cheers, Paul.

1 0

Re: Sufficient 1.2 release criterion: passing all tests on all platforms?
by James Mckenzie 08 Mar '09

08 Mar '09

Dan Kegel <dank(a)kegel.com> wrote on March 8th: > >It almost feels within our grasp for midyear... how 'bout it? I would like to add that these tests should also pass on the MacOSX platform as well. +1 to the idea, Dan. James McKenzie

2 1

Re: [PATCH] [RFC] Make drive C always a
by James Mckenzie 08 Mar '09

08 Mar '09

King InuYasha <ngompa13(a)gmail.com> wrote on March 8th: > >It is definitely possible for Drive C: to be a network share on all versions >of Windows starting from Windows 95. This does not exempt Windows >XP/Vista/2k3/2k8. In fact, a public library in Indiana that I used to go to >before I moved has all their machines set up this way. It takes a LOT of >tweaking to make it work properly, because some applications expect Windows >on Drive C:, but it is possible to do it. > I think this is how Fedex Office (formerly FedEx Kinkos) does it. I know that one of the local university's was also looking into this to prevent spread of viruses and to prevent 'file sharing'. This is absolutely possible and programs should support installation to a network share as C:. Windows can also be run this way. Rather than set C: as Fixed, Wine should be set so that C: can be a network share that is NOT removable. This will take effort. Sometimes the easy solution is not the correct one. James McKenzie

1 0

Re: Fwd: [Wine] Re: The pros and cons of a wiki AppDB
by James Mckenzie 08 Mar '09

08 Mar '09

David: Would you be willing to clean out the ash and trash that will show up with an open Wiki? I don't have the time to do this and it REALLY sounds like you are volunteering since you are pushing this issue so hard. See there are VALID reasons for doing things the way we do them. BTW, I am a maintainer of exactly ONE application. I've worked with this application and would really like to get one feature working. Why am I supporting that application? This is because the author refuses to release source code and he will not be building a Mac/Linux specific version. James McKenzie -----Original Message----- >From: David Gerard <dgerard(a)gmail.com> >Sent: Mar 8, 2009 6:59 AM >To: Wine Develop <wine-devel(a)winehq.org> >Subject: Fwd: [Wine] Re: The pros and cons of a wiki AppDB > >The current appdb system doesn't actually work. Example below. > > >---------- Forwarded message ---------- >From: fcmartins <wineforum-user(a)winehq.org> >Date: 2009/3/8 >Subject: [Wine] Re: The pros and cons of a wiki AppDB >To: wine-users(a)winehq.org > > >Well, I can certainly confirm there is a barrier for drive by >submissions. As a matter of fact the barrier is even bigger than one >might anticipate (as an occasional user): >- sometime ago I submitted test data for a game. It was rejected with: >Please fill the "What does not work". I had written something like: >"I've done only initial gameplay". I believe the reply was implicitly >there, so IMO it was a unneeded barrier. Anyway, I tried to oblige >with a more explicit reply, and guess what: the submission was not >working: After submit, the form came back with the old data!! So, >another barrier. Furtermore, I sent an email to webmaster with the >issue, but never heard anything back. > >As you can imagine, this has lowered my willingness to submit test >data, and lack of updated info for newer versions of wine is THE major >problem with appdb. > >On the positive side, I had two comments in Sacred deleted by the >maintainer as a cleanup, and I felt the deletes were appropriate and >educative. > >Anyway, I think appdb mostly works and putting a wiki as a full >replacement would be a mistake. As it is, appdb has maybe a tiny bit >too much structure and bureaucracy, but going to the wiki and loose >all the structure would be silly. > >The UI and function of appdb is mostly quite good: I would look for >small tweaks lowering the barrier for contributions: some areas could >work like a wiki: the description, screenshots, and an always present >howto. The howto should be always editable and invite people to >improve it with their own tweaks, minimising the user having to go >through the comments to find a possibly inexistent needle. > >I would definitely look into a simpler form to submit test data, but >above all, I would look into having one of those wine appdb love days >(weeks) were test data is put up to date, e.g. for a forthcoming 1.2? > >

2 1

Re: [Wine] The pros and cons of a wiki AppDB
by James Mckenzie 08 Mar '09

08 Mar '09

-----Original Message----- >From: David Gerard <dgerard(a)gmail.com> >Sent: Mar 8, 2009 6:59 AM >To: wine-devel(a)winehq.org >Cc: Wine <wine-users(a)winehq.org> >Subject: Re: [Wine] The pros and cons of a wiki AppDB > >2009/3/7 IneedAname <wineappdb(a)googlemail.com>: >> On Sat, 7 Mar 2009 20:10:13 +0000 >> David Gerard <dgerard(a)gmail.com> wrote: > >>> Yep. That's why a wiki is nice. If you open it up to everyone to >>> contribute, you'll get bad stuff but you'll get good stuff you just >>> wouldn't get otherwise. It's a great format to capture that. > >> We would use the same system for edit rights that we use now. >> Make appDB account then ask to be a maintainer then you can edit the wiki page for that app. >> The wiki is only for application notes. >> Anyone can read the wiki history. >> Con: >> It would be very hard to set up. > > >Con: Becoming a maintainer is a pain in the backside. You won't get >useful drive-by contributions, and a lot of this stuff is drive-by. > Example? I've been a maintainer for over a year now. I've received two postings for the program. I don't think a lot of Linux and Mac users are using the program, or they are not experiencing problems. I will update the entry, now that you have reminded me to do so. > >> Do not cross post or you may up set people with power. > > >So when we're talking about a service to users, you're saying "God >forbid we ask the users"? > We are discussing what is a development issue. We really don't need to confuse users with this. Besides, I don't think most users really care if we are using a Wiki or a Web Application to record what is hsppening with Applications and their ability to run on Wine. James McKenzie > >- d. >

1 0

Fwd: [Wine] Re: The pros and cons of a wiki AppDB
by David Gerard 08 Mar '09

08 Mar '09

The current appdb system doesn't actually work. Example below. ---------- Forwarded message ---------- From: fcmartins <wineforum-user(a)winehq.org> Date: 2009/3/8 Subject: [Wine] Re: The pros and cons of a wiki AppDB To: wine-users(a)winehq.org Well, I can certainly confirm there is a barrier for drive by submissions. As a matter of fact the barrier is even bigger than one might anticipate (as an occasional user): - sometime ago I submitted test data for a game. It was rejected with: Please fill the "What does not work". I had written something like: "I've done only initial gameplay". I believe the reply was implicitly there, so IMO it was a unneeded barrier. Anyway, I tried to oblige with a more explicit reply, and guess what: the submission was not working: After submit, the form came back with the old data!! So, another barrier. Furtermore, I sent an email to webmaster with the issue, but never heard anything back. As you can imagine, this has lowered my willingness to submit test data, and lack of updated info for newer versions of wine is THE major problem with appdb. On the positive side, I had two comments in Sacred deleted by the maintainer as a cleanup, and I felt the deletes were appropriate and educative. Anyway, I think appdb mostly works and putting a wiki as a full replacement would be a mistake. As it is, appdb has maybe a tiny bit too much structure and bureaucracy, but going to the wiki and loose all the structure would be silly. The UI and function of appdb is mostly quite good: I would look for small tweaks lowering the barrier for contributions: some areas could work like a wiki: the description, screenshots, and an always present howto. The howto should be always editable and invite people to improve it with their own tweaks, minimising the user having to go through the comments to find a possibly inexistent needle. I would definitely look into a simpler form to submit test data, but above all, I would look into having one of those wine appdb love days (weeks) were test data is put up to date, e.g. for a forthcoming 1.2?

1 0

The pros and cons of a wiki AppDB
by David Gerard 08 Mar '09

08 Mar '09

2009/3/7 Rosanne DiMesio <dimesio(a)earthlink.net>: > I can think of one possible benefit. There are a lot of apps without maintainers, and there might be users of those apps who would be willing take a few minutes to post bits of useful information in a wiki, but don't want the responsibility of being a maintainer. Sure, they could just post info in a comment, but user comments are buried at the bottom of the page and not in a useful order for finding information quickly. The same goes for comments in test reports--I've found information on needed tweaks buried several reports down from the most recent. Yep. That's why a wiki is nice. If you open it up to everyone to contribute, you'll get bad stuff but you'll get good stuff you just wouldn't get otherwise. It's a great format to capture that. Being an app maintainer is too much like bureaucracy. It makes drive-by reports way too hard. Keep it simple, you'll get more information and therefore more good information. (Disclaimer: I'm a Wikipedia admin and press volunteer, so I think of wikis as good default solutions for lots of things ;-) What do users want from the AppDB? They want to know how well the app works with Wine, and what tweaks are needed to get it working. I'd be tempted to just go and start a wiki on the subject myself, but it'd be duplicated effort with the present AppDB. So I'd rather try to make a case for it. The present AppDB is lacking in many ways that I think a wiki would help with. I'm cc'ing this to wine-users - since I'd need to make a case for the wiki to developers, but it's actually *for* the users. Users: what's right and wrong with the AppDB? How useful is it for you? What would make it better? - d.

3 4

Re: [Wine] The pros and cons of a wiki AppDB
by Ben Klein 08 Mar '09

08 Mar '09

2009/3/8 Vincent Weber <weber.vincent(a)gmail.com>: > If it aint broken then don't fix it. Please use the "Reply to all" feature so your mail goes back to the mailing list and not just to me :)

1 0

Re: installing ie6 and directX
by Ben Klein 08 Mar '09

08 Mar '09

2009/3/8 Vincent Weber <weber.vincent(a)gmail.com>: > Why do you want to install DirectX on Wine? Wine has DirectX support. :S Some games/apps want d3dx9_## DLLs, which are currently stubs in Wine. They are distributed with the DirectX runtime redist, but that doesn't mean you want full DirectX installed. > You don't need to use IE to download DirectX. Windows uses ActiveX in IE to > update itself. You can also just download DirectX directly from the > internet. One word: winetricks.

1 0

Re: AppDB entries are being delete without contacting maintainer by Rozanne
by James Mckenzie 08 Mar '09

08 Mar '09

Austin English <austinenglish(a)gmail.com> wrote on March 6: >Sent: Mar 6, 2009 1:42 PM >To: Klaus Layer <klaus.layer(a)gmx.de>, Rosanne DiMesio <dimesio(a)earthlink.net> >Cc: Wine Develop <wine-devel(a)winehq.org> >Subject: Re: AppDB entries are being delete without contacting maintainer by Rozanne > >On Fri, Mar 6, 2009 at 2:36 PM, Klaus Layer <klaus.layer(a)gmx.de> wrote: >> Hi all, >> >> since several months a user Rozanne is changing AppDB entries without >> contacting the maintainers. Most of the changes so far were minor changes. >> But today I was informed that Rozanne just deleted an entry which was >> maintained by me. According to the email I received, there were duplicated >> entries for the programm Mapsource. I regard deleting entries from Appdb >> without giving the maintainer a chance to backup what they maintained a >> *very* unfriendly act. I would have merged the two entries under one to save >> the valuable information users added to AppDB. Just deleting entries from >> AppDB, deletes information the wine community collected to support using >> wine. Users spent a lot of time and just deleting their work is *not* >> acceptable. >> >> Can someone of the adminstrators of AppDB please make sure that Rozanne stops >> deleting entries from AppDB without informing the maintainers before. I would >> expect to be informed about such an action before and that I as a maintainer >> have the right to discuss was is being delete and what not. >> >> Thanks, >> >> Klaus >> >> >> ---------- Forwarded message ---------- >> From: AppDB <appdb-noreply(a)winehq.org> >> To: appdb-noreply(a)winehq.org >> Date: Fri, 06 Mar 2009 08:42:12 -0600 >> Subject: [AppDB] Submitter screenshots deleted >> >> Submitter screenshots deleted >> ------------------------------------------------------- >> The screenshots you submitted for MapSource 6.13.7 have been deleted because MapSource 6.13.7 was deleted. >> The action was performed by Rosanne >> Reasons given >> The parent entry was deleted. The reason given for that deletion was: >> Duplicate entry >> >> Best regards. >> The AppDB team >> http://appdb.winehq.org/ >> >> >> If you don't want to receive any other e-mail, please change your preferences: >> http://appdb.winehq.org/preferences.php >> >> >> >> > >Well, Rozanne _is_ an AppDB administrator, hence the permission to >delete those entries. > >That said, yes, notice should be given. > Also, please be aware that entries referring to ReactOS, PlayonLinux and Crossover are also being removed. The latter is actually biting the hand that feeds us. CodeWeavers, the producers of Crossover, host WineHQ. What might be a better idea is to state: "This program has been shown to work better with Crossover, please visit their web site for more details. Please be aware that Crossover is a commercial product whose developers also support Wine." James McKenzie

7 18

re: The pros and cons of a wiki AppDB
by Dan Kegel 08 Mar '09

08 Mar '09

There's already an example of an appdb wiki, in a way; see http://wiki.winehq.org/AdobeApps I did this because the appdb has ugly URLs for apps, and I was trying to post links far and wide trying to draw people in to helping test photoshop and a few other adobe apps. If the appdb had nice URLs for apps (and this has already been prototyped to some extent, but not deployed), I probably wouldn't have done it. The appdb has a few other issues (e.g. threaded discussion is awkward to use, deleting old comments takes lots of clicking and scrolling, screen real estate is wasted at the top such that users have to scroll to get to the good stuff, the way test results are selected and displayed is really confusing, etc) but in general we *need* a structured way to present the data, because otherwise we'd have chaos. So I like the appdb, even with all those faults, and I'd like to keep it and incrementally improve it rather than pitch it all and go for the chaos of a wiki. - Dan

1 0

Re: [2/6] ws2_32/tests: add tests for Inet_Ntop and inet_ntoa
by James Hawkins 08 Mar '09

08 Mar '09

On Sat, Mar 7, 2009 at 5:56 PM, Jeff Latimer <lats(a)yless4u.com.au> wrote: > Note that Inet_Ntop is only available in Vista and Windows 2008. Hence the > testing of version to avoid breaking the test suite on earlier OS's. > Checking the windows version is not allowed in the tests. -- James Hawkins

2 3

AppDB entries are being delete without contacting maintainer by Rozanne
by Klaus Layer 07 Mar '09

07 Mar '09

Hi all, since several months a user Rozanne is changing AppDB entries without contacting the maintainers. Most of the changes so far were minor changes. But today I was informed that Rozanne just deleted an entry which was maintained by me. According to the email I received, there were duplicated entries for the programm Mapsource. I regard deleting entries from Appdb without giving the maintainer a chance to backup what they maintained a *very* unfriendly act. I would have merged the two entries under one to save the valuable information users added to AppDB. Just deleting entries from AppDB, deletes information the wine community collected to support using wine. Users spent a lot of time and just deleting their work is *not* acceptable. Can someone of the adminstrators of AppDB please make sure that Rozanne stops deleting entries from AppDB without informing the maintainers before. I would expect to be informed about such an action before and that I as a maintainer have the right to discuss was is being delete and what not. Thanks, Klaus

7 10

Re: [1/12] dinput: begin joystick separation into a generic module
by Vitaliy Margolen 07 Mar '09

07 Mar '09

Aric Stewart wrote: > --- Patch set looks good with exception of - few more things can be moved out of joystick_linuxinput.c. But that can be separate patch(es). Vitaliy

2 1

Whither AppDB? (was: Re: AppDB entries are being delete without contacting maintainer by)
by David Gerard 07 Mar '09

07 Mar '09

2009/3/7 Ben Klein <shacklein(a)gmail.com>: > A wiki is likely to be highly unsuccessful for AppDB when the focus is > on test data. I would have thought the focus would be on being useful to users. > Regarding the changelog/history, it'd even be possible to use git to > manage AppDB entries. It's perfectly possible to implement a complete > history without moving to a wiki, but in my opinion only admins should > have access to the history. At present users don't have a reliable go-to place. The present AppDB's failings have been detailed at length on wine-devel. I must confess I am entirely unable to see why history data, or any data in AppDB, should be restricted. - d.

2 1

Test network under wine
by Oliver aka v1k1ng0 07 Mar '09

07 Mar '09

Hello, firstly, I'm sorry for posting in the 3 lists ... I don't know if it is a bug or if some developer can help me. I comment my problem, I've used a game named FML (football manager live) with wine previously, it worked (months ago), I don't remember the version of FML client and wine version :-( I would want play to FML again, I've downloaded the new version of fml client and I've installed the last version of wine (1.1.16), but it doesn't work. The first thing that does the fml client is connect to a server for updating it, and it doesn't work. I've tried test my network under wine (I use debian linux, unstable version, I've in my sources.list "deb http://www.lamaresh.net/apt sid main"), installing a program named "The Dude" ( http://wiki.mikrotik.com/wiki/Dude_Linux_Installation). It works, it opens, but it can't connect with localhost to a port, I think that wine doesn't work with my network config. I'm using wifi, I've an access point that provides dhcp. My linux box works with the network config perfectly. I've read the wine faq, and it says that I may look my hosts file, and it is correct. I have 127.0.0.1 for loopback, and my wifi interface IP with my FQDN and my hostname. Thanks beforehand and I'm sorry for my english, I'm spanish ;-) Thanks! Cheers...

1 0

Re: AppDB entries are being delete without contacting maintainer by Rozanne
by James Mckenzie 06 Mar '09

06 Mar '09

Austin English <austinenglish(a)gmail.com> wrote on March 6th: >Sent: Mar 6, 2009 4:47 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Develop <wine-devel(a)winehq.org> >Subject: Re: AppDB entries are being delete without contacting maintainer by Rozanne > >On Fri, Mar 6, 2009 at 3:44 PM, James Mckenzie ><jjmckenzie51(a)earthlink.net> wrote: >> Austin English <austinenglish(a)gmail.com> wrote on March 6: >>>Sent: Mar 6, 2009 1:42 PM >>>To: Klaus Layer <klaus.layer(a)gmx.de>, Rosanne DiMesio <dimesio(a)earthlink.net> >>>Cc: Wine Develop <wine-devel(a)winehq.org> >>>Subject: Re: AppDB entries are being delete without contacting maintainer by Rozanne >>> >>>On Fri, Mar 6, 2009 at 2:36 PM, Klaus Layer <klaus.layer(a)gmx.de> wrote: >>>> Hi all, >>>> >>>> since several months a user Rozanne is changing AppDB entries without >>>> contacting the maintainers. Most of the changes so far were minor changes. >>>> But today I was informed that Rozanne just deleted an entry which was >>>> maintained by me. According to the email I received, there were duplicated >>>> entries for the programm Mapsource. I regard deleting entries from Appdb >>>> without giving the maintainer a chance to backup what they maintained a >>>> *very* unfriendly act. I would have merged the two entries under one to save >>>> the valuable information users added to AppDB. Just deleting entries from >>>> AppDB, deletes information the wine community collected to support using >>>> wine. Users spent a lot of time and just deleting their work is *not* >>>> acceptable. >>>> >>>> Can someone of the adminstrators of AppDB please make sure that Rozanne stops >>>> deleting entries from AppDB without informing the maintainers before. I would >>>> expect to be informed about such an action before and that I as a maintainer >>>> have the right to discuss was is being delete and what not. >>>> >>>> Thanks, >>>> >>>> Klaus >>>> >>>> >>>> ---------- Forwarded message ---------- >>>> From: AppDB <appdb-noreply(a)winehq.org> >>>> To: appdb-noreply(a)winehq.org >>>> Date: Fri, 06 Mar 2009 08:42:12 -0600 >>>> Subject: [AppDB] Submitter screenshots deleted >>>> >>>> Submitter screenshots deleted >>>> ------------------------------------------------------- >>>> The screenshots you submitted for MapSource 6.13.7 have been deleted because MapSource 6.13.7 was deleted. >>>> The action was performed by Rosanne >>>> Reasons given >>>> The parent entry was deleted. The reason given for that deletion was: >>>> Duplicate entry >>>> >>>> Best regards. >>>> The AppDB team >>>> http://appdb.winehq.org/ >>>> >>>> >>>> If you don't want to receive any other e-mail, please change your preferences: >>>> http://appdb.winehq.org/preferences.php >>>> >>>> >>>> >>>> >>> >>>Well, Rozanne _is_ an AppDB administrator, hence the permission to >>>delete those entries. >>> >>>That said, yes, notice should be given. >>> >> Also, please be aware that entries referring to ReactOS, PlayonLinux and Crossover are also being removed. The latter is actually biting the hand that feeds us. CodeWeavers, the producers of Crossover, host WineHQ. What might be a better idea is to state: >> >> "This program has been shown to work better with Crossover, please visit their web site for more details. Please be aware that Crossover is a commercial product whose developers also support Wine." >> >> James McKenzie >> > >Codeweavers has their own AppDB type system: I am very well aware that this exists. However, folks with Wine may NOT. Putting a pointer in the AppDB for those programs that need a lot of work to run under Wine may prove helpful (remember that is the purpose of this system to get users to get their favorite Windows program running under Linux/UNIX.) We also have to remember that some folks picked up Linux/Wine because it is FREE, and sending them off to a product that may cost them money will just get the upset unless we 'warn' them first. So, my suggestion is just that, a suggestion. However, I have found that one of my favorite First Person Shooters will NOT run under Wine. No problem as it does with CrossOver (and it is actually worse under CrossOver Games for Mac), so I have it and I use it. The problem that causes the game to fail is outside of the scope of the Wine project, as CodeWeavers worked around the busted OpenGL in Apple's/XQuartz's X11 implementation. Thus if I were to write up the program under Wine it would be Garbage with a cavat that it does work under Crossover Mac. This is NOT needed for Linux as it runs just fine under most, if not all distros. I don't know or care about ReactOS or PlayOnLinux's abilities at this time. I would NOT like to see them in the AppDB for a number of reasons, mostly legal. It might also be possible to put the existance of CrossOver in the first page, but that would be up to the web masters. James McKenzie

1 0

Status of TWAIN and SANE
by Jeremy White 06 Mar '09

06 Mar '09

Alexandre is right; text files that bit rot are a rotten way to report status. Better is to write verbose emails that make people click delete quickly <grin>. I've been working on improving Wine's scanner support for the past few weeks, and it's come a long way. If anyone has a scanner, and wants to help me out, I'd sure appreciate testing. We could use other applications and other sane scanners as test data points. So here is a current status: What works For Me (TM): 1. Most of what the TWAIN 1.8 specification defines as mandatory is now implemented. I'll document the exceptions in the code shortly. 2. Scanning with IrfanView and Acrobat Professional seems to mostly behave. What doesn't work: 1. You can't use advanced Twain features like file transfer mode. 2. Memory xfer mode is almost certainly broken. 3. Acrobat lets you set a custom scan size, which we don't support (see DAT_IMAGELAYOUT, below). If anyone else wants to play, I'd appreciate it. Cheers, Jeremy

1 0

Re: Resubmit user32: TrackPopupMenu(Ex) fixes
by Reece Dunn 06 Mar '09

06 Mar '09

2009/3/6 Rein Klazes <wijn(a)online.nl>: > Hi, > > Several rounds of commits have gone by without this patch. > I thought it was rather noncontroversial, there must > be something that I am overlooking. Can I get a hint please? > > (cleaned up some white space errors, otherwise patch is unchanged. ) > > Fix another bug in the application of bug#9615. TrackMenuPopupEx is > called with a NULL menu handle, and the application crashes on the > returned NULL value in the following INITMENU message. > > for the Changelog: > Check for invalid menu handle passed to TrackPopupMenu and > TrackPopupMenuEx. > Add conformance tests for the correct handling of those invalid handles. > TrackPopupMenu should call TrackPopupMenuEx, not the other way. NOTE: I am going to refer to TrackPopupMenu as TPM and TrackPopupMenuEx as TPMEx in the rest of this reply. You probably want to split this up into 3 patches. Add the tests first - with appropriate todo_wine entries, then the fix, then the TPM -> TPMEx change. = Implementation Comments: + /* FIXME: this check is performed several times, here and in the called + functions. That could be optimized */ + if( !hMenu || !MENU_GetMenu( hMenu )) { + SetLastError( ERROR_INVALID_MENU_HANDLE) ; + return FALSE; + } Which called functions are doing this check? You should do the SetLastError call there instead (in MENU_TrackMenu?). -BOOL WINAPI TrackPopupMenuEx( HMENU hMenu, UINT wFlags, INT x, INT y, - HWND hWnd, LPTPMPARAMS lpTpm ) +BOOL WINAPI TrackPopupMenu( HMENU hMenu, UINT wFlags, INT x, INT y, + INT nReserved, HWND hWnd, const RECT *lpRect ) { - FIXME("not fully implemented\n" ); Why are you removing this FIXME? Do you know that your changes fully implement TPMEx (which does not have the FIXME in your patch)? - return TrackPopupMenu( hMenu, wFlags, x, y, 0, hWnd, - lpTpm ? &lpTpm->rcExclude : NULL ); + return TrackPopupMenuEx( hMenu, wFlags, x, y, hWnd, NULL); What is the rationale behind calling TPMEx from TPM? Is it so you can properly implement something in TPMEx that is not provided in TPM? If so, are there any tests to show that there are differences that require this change? You have two changes in this patch: fixing the last error value and calling TPMEx from TPM. These need to be separate patches as it is difficult to see what the changes are. +static int gflag_initmenupopup, Consider calling this something like gcalled_initmenupopup. +/* some TrackPopupMenu and TrackPopupMenuEx tests */ +/* the LastError values differ between NO_ERROR and invalid handle */ +/* between all windows versions tested. The first value is that valid on XP */ +/* Vista was the only that made returned different error values */ +/* between the TrackPopupMenu and TrackPopupMenuEx functions */ This is not needed - the code tells us this. + SetWindowLongPtr( hwnd, GWLP_WNDPROC, (LONG_PTR)menu_ownerdraw_wnd_proc); Why are you using the ownerdraw class? Create one for the TPM/TPMEx tests. + for( Ex = 0; Ex < 2; Ex++) { Reading the tests and trying to understand what they are doing is confusing. It is better to split it out into a TMP and a TPMEx test function (no MyTrackPopupMenu) like the SHCreateStreamOnFileA/W/Ex tests are doing (http://source.winehq.org/git/wine.git/?a=blob;f=dlls/shlwapi/tests/istream.…). You can add a trace at the top of each function so you don't need to write out which TPM/TPMEx function you are testing in every call (the Ex ? "Ex" : "" looks ugly - expecially in every trace call). Splitting it out also allows you later to do TPM or TPMEx specific tests that show the differences between these functions. + /* display the menu */ This comment is redundant. + /* start with an invalid menu handle */ Consider removing the "start with", e.g. "invalid argument tests". + ok( !(gflag_initmenupopup || gflag_entermenuloop || gflag_initmenu), + "got unexpected message(s)%s%s%s\n", + gflag_initmenupopup ? " WM_INITMENUPOPUP ": " ", + gflag_entermenuloop ? "WM_INITMENULOOP ": "", + gflag_initmenu ? "WM_INITMENU": ""); Break this out into 3 ok checks -- ok(!gflag_initmenupopup, "WM_INITMENUPOPUP should not be called on invalid arguments."). + ok( gle == NO_ERROR + || gle == ERROR_INVALID_MENU_HANDLE /* NT4, win2k and Vista in the TrackPopupMenuEx case */ In one of the above calls you have marked the NO_ERROR as broken. Why the difference? = General Use blank lines to separate out the blocks of functionality (see other tests, like the istream.c or ordinal.c (also in shlwapi) tests for examples) -- we are not constrained by the size of the source code, especially in tests. Readability is paramount in the tests. Since you are noting message sequences, see http://source.winehq.org/git/wine.git/?a=blob;f=dlls/comctl32/tests/monthca… for an example of how to do message sequence tests. = Minor Style / Grammar Nits: + /* FIXME: this check is performed several times, here and in the called + functions. That could be optimized */ You are missing a '.' at the end of the sentence. + SetLastError( ERROR_INVALID_MENU_HANDLE) ; The spacing is inconsistent here. The space at the end should be before the ), not after it. + ok( ret, "AppendMenA has failed!\n"); Typo: should be AppendMenuA. - Reece

2 2

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)
by Paul Vriens 06 Mar '09

06 Mar '09

Andreas Rosenberg wrote: > > ------------------------------------------------------------------------ > > Hi, Error during compilation: userenv_main.c:181: warning: passing argument 1 of ‘GetUserNameW’ from incompatible pointer type Shouldn't that line be: res = GetUserNameW( userName, &sizeName ); -- Cheers, Paul.

2 4

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (7)
by Paul Vriens 06 Mar '09

06 Mar '09

Andreas Rosenberg wrote: > > ------------------------------------------------------------------------ > > It's quite common for these functions to check for the needed buffersize when buffer=NULL and size=0 is passed. I did a quick check on W2K3 and this is what is returned: sizePath = 0; SetLastError( 0xDEADBEEF ); r = GetUserProfileDirectoryA( htoken , NULL, &sizePath ); userenv.c:298: (A) r : 0, sizePath : 0, GLE : 87/00000057 sizePath = 0; SetLastError( 0xDEADBEEF ); r = GetUserProfileDirectoryW( htoken , NULL, &sizePath ); userenv.c:304: (W) r : 0, sizePath : 40, GLE : 122/0000007a So one suggestion is to also add some A-checks to the tests. Another one is not to rely on buffer[MAX_PATH] but use the returned required buffersize for further processing (HeapAlloc). -- Cheers, Paul.

1 0

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)
by Nikolay Sivov 06 Mar '09

06 Mar '09

Andreas Rosenberg wrote: + if ( !lpcchSize ) { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + SetLastError(ERROR_MORE_DATA); + } + } + } + else + SetLastError(ERROR_REGISTRY_CORRUPT); + } + else + SetLastError(ERROR_REGISTRY_CORRUPT); return FALSE; All these SetLastError are still potentially wrong since you don't check this error codes in your tests.

4 8

Re: [2/6] dbghelp: Don't define 32-bit module handling functions in Win64.
by Alexandre Julliard 06 Mar '09

06 Mar '09

Mike Ruprecht <cmaiku(a)gmail.com> writes: > diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/module.c > index fcdea2e..4b6c3d6 100644 > --- a/dlls/dbghelp/module.c > +++ b/dlls/dbghelp/module.c > @@ -438,6 +438,7 @@ enum module_type module_get_type_by_name(const WCHAR* name) > return DMT_PE; > } > > +#if defined(_IMAGEHLP_SOURCE_) || !defined(_IMAGEHLP64) It doesn't make sense to test for these defines in the source. You probably want #ifndef _WIN64. -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel