- wine-devel - winehq.org

Re: gdiplus: in GdipDrawString only NULL terminate if we have room in the buffer.
by Nikolay Sivov 12 Feb '09

12 Feb '09

Aric Stewart wrote: > --- > dlls/gdiplus/graphics.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 2673042..c276a43 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -1901,7 +1901,8 @@ GpStatus WINGDIPAPI GdipDrawString(GpGraphics *graphics, GDIPCONST WCHAR *string > j++; > } > > - stringdup[j] = 0; > + if (j < … [View More]

2 1

Re: [2/2] tools/winemaker.man.in: update man-page
by Nikolay Sivov 12 Feb '09

12 Feb '09

André Hentschel wrote: > sorry, had the wrong mail-account last time. > updating the man-page of winemaker. > there were such old things, there was dust on it! > > > > No attachment here...

1 0

Re: mshtml: Implement IHTMLStyle get/put minHeight (resend)
by Jacek Caban 12 Feb '09

12 Feb '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle get/put minHeight > [get|set]_nsstyle_attr_var functions were introduces to avoid the code duplication like you do. You should use them (and probably implement VT_I4 handling in set_nsstyle_attr_var). Jacek

1 0

Is the test.winehq.org front page too pessimistic?
by Juan Lang 12 Feb '09

12 Feb '09

The front page of test.winehq.org shows statistics about failed tests, but it doesn't seem to take into account the number of individual tests that passed and failed, rather the number of files that had any failures. So, for example, about a week ago I got a fix committed for some failing mapi32 tests. Looking at the machines with test failures, before the fix was committed, 139 tests were run, with 134 of them failing, whereas after the fix was committed, the same number of tests were run, … [View More]

8 11

Re: mshtml: Implement IHTMLStyle_put_textDecorationUnderline (resend)
by Jacek Caban 12 Feb '09

12 Feb '09

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle_put_textDecorationUnderline + + return set_style_attr(This, STYLEID_TEXT_DECORATION, v == VARIANT_TRUE ? valUnderline : emptyW, 0); You shouldn't compare v to VARIANT_TRUE. The correct way to deal with bool values is 'v ? valUnderline : emptyW'. Jacek

1 0

ntdll: Avoid Potential Infinite Loop
by Paul Bryan Roberts 12 Feb '09

12 Feb '09

Hi, I expect this patch will be accepted due to precedent - a few months ago I submitted the same patch for the same problem in a different routine in a different compilation unit of ntdll. Yes, I guess the infinite loop does not occur in practice (someone would have noticed) and I guess it has been there a very long time. But it isn't exactly hard to spot - I was speed reading the code looking for something else. I've seen a lot of chatter recently about something called Coverity. I … [View More]

2 1

Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.
by Paul Vriens 12 Feb '09

12 Feb '09

Huw Davies wrote: > --- > dlls/gdi32/tests/font.c | 20 ++++++++++---------- > 1 files changed, 10 insertions(+), 10 deletions(-) > > > ------------------------------------------------------------------------ > > Looks a lot like: http://www.winehq.org/pipermail/wine-patches/2009-February/069297.html Maybe we should use yours as it has less changes to the code. -- Cheers, Paul.

2 1

Download page requires too much scrolling...
by Dan Kegel 12 Feb '09

12 Feb '09

While I was generating screenshots for my presentation, I noticed that http://www.winehq.org/download/ has too much clutter at the top. I don't mind the Codeweavers ad, but it's not good that users have to scroll down to see the useful part of the page...

2 1

Wine64 : Trying to load PE image for unsupported architecture (I386)
by Erik de Castro Lopo 12 Feb '09

12 Feb '09

Hi all, I build Wine64 using the instructions here: http://wiki.winehq.org/Wine64 While I expected it to not work with my Win64 program I was a little surprised that when running a WIn32 program I got: Trying to load PE image for unsupported architecture (I386) I realise that the Win64 stuff is experimental but I'm curions, in the longer term is it expected that one executable will be able to run both Win32 and Win64 executables? Cheers, Erik -- -----------------------------------… [View More]

6 7

Fwd: Need Your Help about "dll" on linux
by Jigar Joshi 12 Feb '09

12 Feb '09

---------- Forwarded message ---------- From: Jigar Joshi <jigarjm(a)gmail.com> Date: Mon, Feb 9, 2009 at 6:53 PM Subject: Need Your Help about "dll" on linux To: wine-devel(a)winehq.org Respected sir, i refered your post at http://www.winehq.org/pipermail/wine-devel/2007-April/055855.html i want to know have you completed successfully that project? (using dll on linux) please reply soon . actually i have dlls derived from c , i dont have c code and i need to use those dlls on … [View More]

1 0

Error on CVS server: no space left on device
by Paul Chitescu 12 Feb '09

12 Feb '09

Hi! The CVS server cvs.winehq.org is out of disk space: $ cvs -z3 -q up -APd can't create temporary directory /tmp/cvs-serv29410 No space left on device Message is received from remote server. Anyone able to fix it? Regards, Paul Chitescu

3 2

Re: itss: Replace malloc() with HeapAlloc()
by Nikolay Sivov 12 Feb '09

12 Feb '09

Andrew Talbot wrote: > Changelog: > itss: Replace malloc() with HeapAlloc(). > > diff --git a/dlls/itss/lzx.c b/dlls/itss/lzx.c > index b5fdfc7..0ffeeb6 100644 > --- a/dlls/itss/lzx.c > +++ b/dlls/itss/lzx.c > @@ -36,15 +36,17 @@ > ***************************************************************************/ > > #include "lzx.h" > +#include <stdarg.h> > #include <stdio.h> > #include <stdlib.h> > #include <string.h> … [View More]

4 5

An idea for the appdb
by Luke Benstead 12 Feb '09

12 Feb '09

Hi all, I was thinking earlier it would be quite nice if when I double clicked a Windows app in GNOME it would display a nice dialog saying something like "This Windows application may not run correctly as it is currently rated Silver. Please report any bugs to the Wine project. Continue | Cancel". Obviously this kind of functionality is not a job for Wine, but for the distro. Still, it got me thinking how this kind of functionality might be achieved. My idea is that the appdb should allow … [View More]

4 7

Re: An idea for the appdb
by James Mckenzie 11 Feb '09

11 Feb '09

-----Original Message----- >From: alex(a)centroidcafe.com >Sent: Feb 11, 2009 10:59 AM >To: wine-devel(a)winehq.org >Subject: Re: An idea for the appdb > >Sorry .. forgot to reply all. > >Automatic submission of test data could be a very handy tool. Scenario: >User A tries to run an application, it crashes due to bugs in Wine. User A >elects to submit data. Sometime in the future, User B tries to run the same >application under a similar configuration. It … [View More]

5 4

Re: winedos: Replace [c]alloc() with HeapAlloc()
by Andrew Talbot 11 Feb '09

11 Feb '09

Andrew Talbot wrote: Sorry, title should be: winedos: Replace [m|c]alloc() with HeapAlloc() -- Andy.

1 0

Re: An idea for the appdb
by alex＠centroidcafe.com 11 Feb '09

11 Feb '09

Sorry .. forgot to reply all. On Wed, 11 Feb 2009 18:08:47 +0200, Gert van den Berg <wine-devel(a)mohag.net> wrote: > On Wed, Feb 11, 2009 at 2:24 PM, Luke Benstead <kazade(a)gmail.com> wrote: >> I can also see what you mean about >> spyware, but other apps retrieve stuff from the web if there is a >> connection (CDDB, and album covers are two examples). >> > Wine transmitting every application I run to someone else would be > rather worrying... > … [View More]

2 1

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 11 Feb '09

11 Feb '09

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Feb 9, 2009 7:53 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Austin English <austinenglish(a)gmail.com>, wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >James Mckenzie <jjmckenzie51(a)earthlink.net> writes: > >> New wine installation: >> >> su (no dash so root's environment is not picked up) >> wine notepad … [View More]

13 30

Re: An idea for the appdb
by Tim Schwartz 11 Feb '09

11 Feb '09

On Wed, Feb 11, 2009 at 8:58 AM, <wine-devel-request(a)winehq.org> wrote: > Send wine-devel mailing list submissions to > wine-devel(a)winehq.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://www.winehq.org/mailman/listinfo/wine-devel > or, via email, send a message with subject or body 'help' to > wine-devel-request(a)winehq.org > > You can reach the person managing the list at > wine-devel-owner(a)winehq.… [View More]org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of wine-devel digest..." > > > Message: 2 > Date: Wed, 11 Feb 2009 23:57:48 +1100 > From: Ben Klein <shacklein(a)gmail.com> > Subject: Re: An idea for the appdb > To: Luke Benstead <kazade(a)gmail.com> > Cc: Wine Devel <wine-devel(a)winehq.org> > Message-ID: > <d7e40be30902110457t3d84c396ibfd264aead12d6e9(a)mail.gmail.com> > Content-Type: text/plain; charset=UTF-8 > > 2009/2/11 Luke Benstead <kazade(a)gmail.com>: >> 2009/2/11 Ben Klein <shacklein(a)gmail.com>: >>> 2009/2/11 Luke Benstead <kazade(a)gmail.com>: >>>> My idea is that the appdb should allow for people to associate a list >>>> of checksums with an application version. For example, WoW might have >>>> the checksum for the setup program and the game's executable, >>>> associated with the appdb entry. The other extension to the appdb >>>> would be to allow a way to programmatically retrieve information on an >>>> application's rating etc. by going to a certain address (e.g. >>>> http://appdb.winehq.org/getAppInfoFromChecksum.php?checksum=ac2b3f5928cba...) >>>> which would return the info in XML or some other format. >>> >>> You've clearly put quite some thought into this, which is highly >>> commendable. However, I would personally be against such a move, as it >>> would put a lot of extra load on AppDB (in terms of network >>> bandwidth). I'm also not too keen about something that retrieves data >>> from the net every time you run an app. It's too easy for people to >>> mistake it for spyware. >> >> Hmm.. I see your point. However would it really use that much >> bandwidth? I mean, any sane implementation of the functionality I >> described would only display the dialog the first time that >> application was used. Retrieving a tiny xml file is surely less >> bandwidth than browsing the appdb for the application (granted it will >> happen more often than people browsing the site but I still don't >> think it's masses of bandwidth). I can also see what you mean about >> spyware, but other apps retrieve stuff from the web if there is a >> connection (CDDB, and album covers are two examples). > > A request to AppDB would be at least once per user, application > version and Wine version combination. Given the number of people using > Wine, this would almost certainly be a massive load increase on AppDB, > it would repeat roughly every 2 weeks (when new releases come out), > and possibly even bring AppDB down as a worst-case scenario. What about packaging the latest appdb information with each release? Tim Schwartz Sanity Internet tim(a)sanityinternet.com [View Less]

1 0

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 11 Feb '09

11 Feb '09

Steve Brown <sbrown7(a)umbc.edu> wrote: > >On Tue, 10 Feb 2009, Vitaliy Margolen wrote: > >> Ben Klein wrote: >>> This is not a problem with Wine, this is OpenSUSE breaking the >>> environment when sudo is called. Remember, Wine is not the only X11 >>> app out there. Others will need $DISPLAY working! >> This is something called security.... > >No, the whole point of using sudo is that it removes the necessity of >anyone other than … [View More]

1 0

Re: imm32: Make space for a 64bit pointer in the IMM window.
by Aric Stewart 11 Feb '09

11 Feb '09

I am not a 64 bit expert but i do not think this is going to work. ddk/imm.h is a Microsoft header so IMEs and programs compiled with the original header will not have the expanded space. To fix this properly (I assume you are trying to support 64 bit) is that we will probibly have to store a handle instead of a pointer in the LONG value. The IME is expecting a HIMC in that value. Which leads to a more general question. What is the suggested way to generate handles like that? Working … [View More]toward 64 bit means that everywhere that we are using pointers as LONG handles is going to have problems. -aric Michael Stefaniuc wrote: > --- > Next try at fixing this problem. I didn't find any other place where > IMMGWL_IMC is used and the window classes are not my area of expertise. > > > > dlls/imm32/imm.c | 2 +- > dlls/winex11.drv/ime.c | 2 +- > include/ddk/imm.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 14178c3..bb50e5e 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -2291,7 +2291,7 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > data->imeWnd = CreateWindowExW( WS_EX_TOOLWINDOW, > data->immKbd->imeClassName, NULL, WS_POPUP, 0, 0, 1, 1, 0, > 0, data->immKbd->hIME, 0); > - SetWindowLongW(data->imeWnd, IMMGWL_IMC, (LONG)data); > + SetWindowLongPtrW(data->imeWnd, IMMGWL_IMC, (LONG_PTR)data); > IMM_GetThreadData()->hwndDefault = data->imeWnd; > } > > diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c > index 87d4faa..6d083d1 100644 > --- a/dlls/winex11.drv/ime.c > +++ b/dlls/winex11.drv/ime.c > @@ -1326,7 +1326,7 @@ static LRESULT WINAPI IME_WindowProc(HWND hwnd, UINT msg, WPARAM wParam, > * messages. > */ > > - hIMC = (HIMC)GetWindowLongW(hwnd,IMMGWL_IMC); > + hIMC = (HIMC)GetWindowLongPtrW(hwnd,IMMGWL_IMC); > if (!hIMC) > hIMC = RealIMC(FROM_X11); > > diff --git a/include/ddk/imm.h b/include/ddk/imm.h > index 6e4d42f..bc9617e 100644 > --- a/include/ddk/imm.h > +++ b/include/ddk/imm.h > @@ -114,7 +114,7 @@ HIMCC WINAPI ImmReSizeIMCC(HIMCC, DWORD); > DWORD WINAPI ImmGetIMCCSize(HIMCC); > > #define IMMGWL_IMC 0 > -#define IMMGWL_PRIVATE (sizeof(LONG)) > +#define IMMGWL_PRIVATE (sizeof(LONG_PTR)) > > /* IME Property bits */ > #define IME_PROP_END_UNLOAD 0x0001 > > > ------------------------------------------------------------------------ > > [View Less]

2 2

Re: crypt32(1/4): Add chain debugging channel for debugging certificate chaining errors
by Alexandre Julliard 11 Feb '09

11 Feb '09

Juan Lang <juan.lang(a)gmail.com> writes: > +static void dump_element(PCCERT_CONTEXT cert) > +{ > + LPWSTR name = NULL; > + DWORD len, i; > + > + TRACE_(chain)("%p\n", cert); > + len = CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, > + CERT_NAME_ISSUER_FLAG, NULL, NULL, 0); > + name = CryptMemAlloc(len * sizeof(WCHAR)); > + if (name) > + { > + CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, > + … [View More]

1 0

Re: gdiplus: add a drawing test for GdipFillRectangleI
by Nikolay Sivov 10 Feb '09

10 Feb '09

Vincent Povirk wrote: > This is a very simple drawing test that I've created to establish a precedent for drawing tests in gdiplus. > > Gdiplus currently has no tests that draw things and then check what was drawn. I've added some functions that should make this easy. It's important to get this right the first time so any feedback will be most appreciated. > As for me I'm not against it if it'll work stably, but will this really help? It's much easier to check this visually, … [View More]

2 3

Re: imagicos
by James Mckenzie 10 Feb '09

10 Feb '09

Jeremy White <jwhite(a)winehq.org> wrote: > >EA Durbin wrote: >> I just saw this linux distribution on distrowatch. They claim to be able >> to run all microsoft products. Interesting. > >Just for the record, these folks are customers of ours. > Thank you for the clarification of your relationship with this company. > >It is my belief that their distribution of CrossOver complies with all >of the terms of the LGPL; we try to make sure of that for our … [View More]

1 0

Re: Fixing AppDB once and for all
by James Mckenzie 10 Feb '09

10 Feb '09

Zachary Goldberg <zgold(a)bluesata.com> >Sent: Feb 3, 2009 10:44 AM >To: Wine Devel <wine-devel(a)winehq.org> >Cc: Jeremy Newman <jnewman(a)codeweavers.com> >Subject: Fixing AppDB once and for all > >All, >Lets (arbitrarily) set a time for the chat at: > >When: 11PM UTC (6PM EST) 2/6/09 (Friday) >Where: #winehackers > This would be too early for people on the West Coast of the United States by about three hours. No time will be satisfactory … [View More]

9 15

imagicos
by EA Durbin 10 Feb '09

10 Feb '09

I just saw this linux distribution on distrowatch. They claim to be able to run all microsoft products. Interesting. http://www.imagicos.com/ http://www.imagicos.com/microsoft.html _________________________________________________________________ Windows Live™: E-mail. Chat. Share. Get more ways to connect. http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t2_allup_explore_022009

13 21

Re: [PATCH] gdi32: handle failure in __wine_make_gdi_object_system (Coverity)
by Alexandre Julliard 10 Feb '09

10 Feb '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > @@ -445,6 +445,11 @@ static const struct DefaultFontInfo default_fonts[] = > void CDECL __wine_make_gdi_object_system( HGDIOBJ handle, BOOL set) > { > GDIOBJHDR *ptr = GDI_GetObjPtr( handle, 0 ); > + > + if (!ptr) { > + ERR("System object for handle %p not found.\n", handle); > + return; > + } That shouldn't happen, it's an internal function and the caller is supposed to pass a … [View More]

1 0

Re: mshtml/tests: Better check for installed Gecko.
by Alexandre Julliard 10 Feb '09

10 Feb '09

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -4199,9 +4199,8 @@ static void run_domtest(const char *str, domtest_t test) > } > > hres = IHTMLDocument2_get_body(doc, &body); > - ok(hres == S_OK, "get_body failed: %08x\n", hres); > - > - if(body) { > + if(hres != E_UNEXPECTED) { > + ok(hres == S_OK, "get_body failed: %08x\n", hres); > IHTMLElement_Release(body); We've been through this before, there needs to be … [View More]

1 0

Re: spoolss: Implement EnumPorts [try 2]
by Alexandre Julliard 10 Feb '09

10 Feb '09

Detlef Riekenberg <wine.dev(a)web.de> writes: > Synced to current git. It doesn't work here: ../../../tools/runtest -q -P wine -M winspool.drv -T ../../.. -p winspool.drv_test.exe.so info.c && touch info.ok info.c:505: Test failed: got 1 with 127 (expected '0' with ERROR_INVALID_PARAMETER) make: *** [info.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] winegcc: Free the temporary string arrays (Coverity)
by Alexandre Julliard 10 Feb '09

10 Feb '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > This fixes CID 883, 882, 881, 880, 879, 878, 877, > which are all basically missing strarray_free(arr)s. winegcc is a short-lived program, there's no reason to care about memory leaks. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [try2] dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path
by Ben Klein 10 Feb '09

10 Feb '09

2009/2/10 Vincent Pelletier <plr.vincent(a)gmail.com>: > On Tue, Feb 10, 2009 at 8:51 AM, Ben Klein <shacklein(a)gmail.com> wrote: >> You're taking out the strcpy into device, and replacing it with a >> strcpy into instance_name. What value will the device field hold? > > Err... strcpy from instance_name to the other struct. It's strcpy(out, in). > It's wine which is providing the windows program with names. OK, disregard everything I said ... ever ;) Well, … [View More]

1 0

Re: dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path
by Vitaliy Margolen 10 Feb '09

10 Feb '09

Vincent Pelletier wrote: > joydevs[id].name value comes from EVIOCGNAME iotcl, and is the product name. > > I think joystick device path qualifies as a "Friendly name for the instance" > (as defined for tszInstanceName on MSDN). > > If not, please tell me and I will extend the patch to generate a "Joystick %i" > name, or maybe put joydevs[id].name in both fields. > > - strcpy(lpddi->tszInstanceName, joydevs[id].name); > - strcpy(lpddi->… [View More]

3 3

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 10 Feb '09

10 Feb '09

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Feb 9, 2009 7:26 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Austin English <austinenglish(a)gmail.com>, wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >James Mckenzie <jjmckenzie51(a)earthlink.net> writes: > >> Second, the problem is that newbies, figuring that their favorite >> program will not run as an ordinary … [View More]

10 12

Regression in 1.1.14 for Athena Visual Studio
by Erich Hoover 10 Feb '09

10 Feb '09

In Wine 1.1.14 Athena Visual Studio fails to build Fortran applications and returns with an error, doing a git bisect gives this result: ---- ebe4a9e321800fbe6d2004a640cd276a28d15c38 is first bad commit commit ebe4a9e321800fbe6d2004a640cd276a28d15c38 Author: Dan Kegel <dank(a)kegel.com> Date: Sun Jan 18 19:19:46 2009 -0800 msvcrt: Remove CRs earlier in ascii mode. :040000 040000 44cfaec7cd552af4c92f220ad34a06d864eff79d 685d15aa69a9e0f91e0d4cbc933191a29837dce9 M dlls ---- … [View More]

2 1

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 10 Feb '09

10 Feb '09

Aurimas Fišeras <aurimas(a)gmail.com> wrote: >Sent: Feb 9, 2009 7:45 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >James Mckenzie wrote: >> Alexandre Julliard <julliard(a)winehq.org> wrote: >>[...] >> New wine installation: >> >> su (no dash so root's environment is not picked up) >> wine notepad >> install … [View More]

3 2

[try2] dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path
by Vincent Pelletier 10 Feb '09

10 Feb '09

Le Saturday 07 February 2009 14:16:15 Vincent Pelletier, vous avez écrit : > If not, please tell me and I will extend the patch to generate a "Joystick > %i" name, or maybe put joydevs[id].name in both fields. Same patch as first proposed on wine-devel, no reaction so I guess it's correct. -- Vincent Pelletier

2 2

Re: comctl32/tests: [try 2] Make the test dpi and Theme aware: use SM_CYSIZE
by Paul Vriens 09 Feb '09

09 Feb '09

Detlef Riekenberg wrote: > try 2: without the check for win9x > > > The status test failed on installations with 120 dpi. > > After a lot of "try and error" from 72 to 144 dpi with > different formula for the min height, different results on my machine > and a failing XP machine at 96dpi, I found the reason: > > The minimal height depends on the appearance setting > "[In]Active Title Bar", which is SM_CYSIZE. > > The test now pass on win98se, win2k … [View More]

2 1

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 09 Feb '09

09 Feb '09

Michael Stefaniuc <mstefani(a)redhat.com> wrote: >Sent: Feb 9, 2009 7:39 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >> sudo rm -rf .wine >Solution is sudo chmod -R $username.$groupname .wine > Correct. However, this is not the solution given on Wine Users. >> User now upset because everything they did is gone. >Not if you do it right. … [View More]

1 0

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 09 Feb '09

09 Feb '09

Chris Howe <mrmessiah(a)gmail.com> wrote: >Sent: Feb 9, 2009 8:06 AM >To: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >It would seem to me that the right place for this to go would be >not in Wine itself but in the likes of Crossover and Cedega - the >"distributions" and value added apps built around Wine. > >I can't reconcile in my head the case where you have a newbie >running the latest GIT of Wine … [View More]

2 1

Fwd: EVE online losing its Linux Client
by Andrew Fenn 09 Feb '09

09 Feb '09

On Mon, Feb 9, 2009 at 2:22 PM, James Mckenzie <jjmckenzie51(a)earthlink.net> wrote: > Since there is not a great Wine audience for the Mac, the Eve Online Mac client should not be abandoned just for that reason. The real reason may be that there is not a great deal of demand for an on-line game interface for the Mac. Most Mac users loath having to use X11 for any purpose, and a game tops the list. I'm pretty sure they're not abandoning the mac client which has shown growth compared … [View More]

1 0

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 09 Feb '09

09 Feb '09

David Gerard <dgerard(a)gmail.com> wrote: >Sent: Feb 9, 2009 7:45 AM >To: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >2009/2/9 James Mckenzie <jjmckenzie51(a)earthlink.net>: > >> Thus, the need for the warning. Experts tend to know what they are doing, newbies don't for the >>most part. And yes, I borked many a system as a newbie and as an expert (building kernels for >>RedHat/Fedora for my … [View More]

1 0

Re: oleaut32: Fix SAFEARRAY marshalling on 64-bit platforms.
by Alexandre Julliard 09 Feb '09

09 Feb '09

Rob Shearman <robertshearman(a)gmail.com> writes: > @@ -874,8 +874,8 @@ unsigned char * WINAPI LPSAFEARRAY_UserMarshal(ULONG *pFlags, unsigned char *Buf > > *(ULONG *)Buffer = ulCellCount; > Buffer += sizeof(ULONG); > - *(ULONG_PTR *)Buffer = (ULONG_PTR)psa->pvData; > - Buffer += sizeof(ULONG_PTR); > + *(ULONG *)Buffer = (ULONG)(ULONG_PTR)psa->pvData; > + Buffer += sizeof(ULONG); Wouldn't this break if the … [View More]

2 2

Re: ntdll: add a warning about running wine as root (resend)
by James Mckenzie 09 Feb '09

09 Feb '09

Alexandre Julliard <julliard(a)winehq.org> >Sent: Feb 9, 2009 5:56 AM >To: Austin English <austinenglish(a)gmail.com> >Cc: wine-devel(a)winehq.org >Subject: Re: ntdll: add a warning about running wine as root (resend) > >Austin English <austinenglish(a)gmail.com> writes: > >> Didn't receive any feedback on this one last time. Been seeing this a >> bit recently in the forums, so adding a warning. No actual >> functionality lost. > >… [View More]

3 2

Re: EVE online losing its Linux Client
by James Mckenzie 09 Feb '09

09 Feb '09

François Guerraz <kubrick(a)fgv6.net> wrote: >Sent: Feb 9, 2009 1:32 AM >To: Chris Robinson <chris.kcat(a)gmail.com> >Cc: wine-devel(a)winehq.org >Subject: Re: EVE online losing its Linux Client > >On 9/02/09 3:55, Chris Robinson wrote: >> On Sunday 08 February 2009 6:17:38 pm Zachary Goldberg wrote: >> >A great thing would be that they officially support Wine. > >Also, if the Mac Wine would have worked better (I know it's Apple crappy … [View More]

1 0

OFC and MFC and Winelib
by King InuYasha 09 Feb '09

09 Feb '09

Hello, I was doing my random web browsing when I stumbled on an issue with source code with MSVC++ 2005 Express, and I was searching for a solution. I think I found one, but it hasn't been maintained for years from what I can gather. Since you guys do have winelib for the purpose of building Win32 source code, I thought that I could suggest that the people that do maintain Winelib could take over this project and import it into Wine's git repository. The project is called the Open Foundation … [View More]

2 1

Re: [1/2] d3dxof: Cleanup IDirectXFileImpl_CreateEnumObject a bit
by Alexandre Julliard 09 Feb '09

09 Feb '09

Christian Costa <titan.costa(a)wanadoo.fr> writes: > commit a9d8c3f6e21439bb638e958674f9da6a648661b2 > Author: Christian Costa <titan.costa(a)wanadoo.fr> > Date: Sun Feb 8 13:25:45 2009 +0100 > > Cleanup IDirectXFileImpl_CreateEnumObject a bit. This doesn't work here: ../../../tools/runtest -q -P wine -M d3dxof.dll -T ../../.. -p d3dxof_test.exe.so d3dxof.c && touch d3dxof.ok d3dxof.c:113: Test failed: IDirectXFileEnumObject_GetNextDataObject: … [View More]

1 0

ntdll: add a warning about running wine as root (resend)
by Austin English 09 Feb '09

09 Feb '09

Didn't receive any feedback on this one last time. Been seeing this a bit recently in the forums, so adding a warning. No actual functionality lost. -- -Austin

2 1

RE: First complete test run passing on a Windows platform
by Ge van Geldorp 09 Feb '09

09 Feb '09

> From: Reece Dunn <msclrhd(a)googlemail.com> > > The Wine tests are now passing on a Windows XP machine > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group _XP). Actually, that was not the first time. On 20 Jan an XP machine passed: http://test.winehq.org/data/e9d8c9f572998054b1f9c386ea81a3570c65f2d2/#group_ XP And on 27 Jan a 2003 machine: http://test.winehq.org/data/8f829034f3fe4da3e7adce2f4685e10ba2e2fe82/#group_ 2003 > Two of the other … [View More]

5 11

Re: shell32: Make ILGetDisplayNameExA() static and fix its documentation.
by Francois Gouget 09 Feb '09

09 Feb '09

Please don't apply. I should have removed the WINAPI when making the function static. I'll resend a patch. > diff --git a/dlls/shell32/pidl.c b/dlls/shell32/pidl.c > index 5f26265..2792bc6 100644 > --- a/dlls/shell32/pidl.c > +++ b/dlls/shell32/pidl.c > @@ -75,7 +75,7 @@ static LPWSTR _ILGetTextPointerW(LPCITEMIDLIST pidl); > * RETURNS > * True if the display name could be retrieved successfully, False otherwise > */ > -BOOL WINAPI ILGetDisplayNameExA(… [View More]

1 0

Re: wininet: print better stubs for the internet options ie7 uses
by Dmitry Timoshkov 09 Feb '09

09 Feb '09

"Aric Stewart" <aric(a)codeweavers.com> wrote: > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 363f7a4..7db635d 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -2367,8 +2367,35 @@ BOOL WINAPI InternetSetOptionW(HINTERNET hInternet, DWORD dwOption, > case INTERNET_OPTION_DISABLE_AUTODIAL: > FIXME("Option INTERNET_OPTION_DISABLE_AUTODIAL; STUB\n"); > break; > - case 86: > - FIXME("86\n"); … [View More]

1 0

ioports.c change -> buffer overflow ... bug?
by Marcus Meissner 09 Feb '09

09 Feb '09

Hi Florian, You are calling get_timer_val(3) in ioports.c (if (chan == 3) ... going down to get_timer_val(chan)) Howver, tmr_8253 is just a 3 element array, so [3] will run over the end, Is your code right? The change comes from this commit: commit edbd4885542e4545439906df950a68dc48e70839 Author: Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> Date: Tue Feb 3 18:26:04 2009 +0100 winedos: Improve PIT emulation. Ciao, Marcus

2 1

EVE online losing its Linux Client
by Zachary Goldberg 09 Feb '09

09 Feb '09

http://games.slashdot.org/article.pl?sid=09/02/08/206252&from=rss It seems that a game studio found that Wine worked so well that they have given up their efforts to maintain a native client. While encouraging that Wine works so well, there is a very interesting debate which could be had as to whether or not this kind of affect is desirable. -Zach

4 5

[Fwd: Re: [Wine] imagicos]
by James McKenzie 09 Feb '09

09 Feb '09

Sent to wrong mailing list. Comment stands. Apple is almost as bad as Microsoft with trademark enforcement. James McKenzie -------- Original Message -------- Subject: Re: [Wine] imagicos Date: Sun, 08 Feb 2009 19:58:52 -0700 From: James McKenzie <jjmckenzie51(a)earthlink.net> To: IneedAname <wineappdb(a)googlemail.com> CC: Wine <wine-users(a)winehq.org> References: <COL113-W24AF1F36974642B52CBF95ABBE0(a)phx.gbl> <… [View More]

1 0

New coverity run Feb 7, 14 new warnings
by Dan Kegel 09 Feb '09

09 Feb '09

Congrats to everyone who's been cleaning up Coverity warnings, especially Marcus (http://marcusmeissner.livejournal.com/24466.html). Here are the yet-uninspected warnings that are in the Feb 7 run but not in the Jan 30 run: 884 REVERSE_INULL compile_file_regex dlls/dbghelp/symbol.c 883 RESOURCE_LEAK forward tools/winegcc/winegcc.c 882 RESOURCE_LEAK build tools/winegcc/winegcc.c 881 RESOURCE_LEAK build tools/… [View More]

3 3

Question about redirection handles in wcmd
by Erich Hoover 08 Feb '09

08 Feb '09

I tracked down an issue where an application was running into a sharing problem in WCMD_execute when it created redirects to the same file more than once. I originally hacked around this issue by changing the sharing mode for redirects, but I've now narrowed down the issue. I discovered that the file handle is not being closed when a command has completed and that this issue is caused by the "old handle" value being INVALID_HANDLE_VALUE: http://source.winehq.org/source/programs/cmd/wcmdmain.c#… [View More]

1 1

New Wine Gecko package
by Jacek Caban 08 Feb '09

08 Feb '09

Hi all, The last release of Wine Gecko caused a few regressions. Thanks to Alexandre, we've found the reason. The bad news is that the fix requires a new package. I've uploaded RC build to: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-0.9.1.cab I'd appreciate if people that observe the regression (mostly strange crashed) could retest bugs with this build. To do so, you will need the new package and the attached patch. Also quick tests with random apps would be nice. This is a … [View More]bugfix release based on the same codebase as 0.9.0 version so I don't expect any new regressions with it. Also the last debug version was accidentally stripped. It will be fixed in this release. I'm planning to do the release tomorrow, so it will be in Git on Friday. Thanks, Jacek >From 35f651d05f04dc80dd85451d48428d5c6174dac2 Mon Sep 17 00:00:00 2001 From: Jacek Caban <jacek(a)codeweavers.com> Date: Thu, 5 Feb 2009 00:17:09 +0100 Subject: [PATCH] mshtml: Wine Gecko 0.9.1 release. To: wine-patches <wine-patches(a)winehq.org> --- dlls/mshtml/htmldoc.c | 4 +++- dlls/mshtml/mshtml_private.h | 1 + dlls/mshtml/mutation.c | 15 +++++++++++++++ dlls/mshtml/nsembed.c | 4 +++- dlls/mshtml/nsiface.idl | 3 ++- 5 files changed, 24 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 32da2e0..a6aa73f 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -214,8 +214,10 @@ static ULONG WINAPI HTMLDocument_Release(IHTMLDocument2 *iface) ConnectionPointContainer_Destroy(&This->cp_container); - if(This->nsdoc) + if(This->nsdoc) { + remove_mutation_observer(This->nscontainer, This->nsdoc); nsIDOMHTMLDocument_Release(This->nsdoc); + } if(This->nscontainer) NSContainer_Release(This->nscontainer); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index e4c98a7..b67c485 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -510,6 +510,7 @@ void NSContainer_Release(NSContainer*); void init_mutation(NSContainer*); void set_mutation_observer(NSContainer*,nsIDOMHTMLDocument*); +void remove_mutation_observer(NSContainer*,nsIDOMHTMLDocument*); void HTMLDocument_LockContainer(HTMLDocument*,BOOL); void show_context_menu(HTMLDocument*,DWORD,POINT*,IDispatch*); diff --git a/dlls/mshtml/mutation.c b/dlls/mshtml/mutation.c index ea61d5a..ab9649c 100644 --- a/dlls/mshtml/mutation.c +++ b/dlls/mshtml/mutation.c @@ -55,6 +55,21 @@ void set_mutation_observer(NSContainer *nscontainer, nsIDOMHTMLDocument *nshtmld nsIDOMNSDocument_Release(nsdoc); } +void remove_mutation_observer(NSContainer *nscontainer, nsIDOMHTMLDocument *nshtmldoc) +{ + nsIDOMNSDocument *nsdoc; + nsresult nsres; + + nsres = nsIDOMHTMLDocument_QueryInterface(nshtmldoc, &IID_nsIDOMNSDocument, (void**)&nsdoc); + if(NS_FAILED(nsres)) { + ERR("Could not get nsIDOMNSDocument: %08x\n", nsres); + return; + } + + nsIDOMNSDocument_WineRemoveObserver(nsdoc, NSDOCOBS(nscontainer)); + nsIDOMNSDocument_Release(nsdoc); +} + #define IE_MAJOR_VERSION 7 #define IE_MINOR_VERSION 0 diff --git a/dlls/mshtml/nsembed.c b/dlls/mshtml/nsembed.c index ee386ac..16ac21e 100644 --- a/dlls/mshtml/nsembed.c +++ b/dlls/mshtml/nsembed.c @@ -857,8 +857,10 @@ void update_nsdocument(HTMLDocument *doc) return; } - if(doc->nsdoc) + if(doc->nsdoc) { + remove_mutation_observer(doc->nscontainer, doc->nsdoc); nsIDOMHTMLDocument_Release(doc->nsdoc); + } doc->nsdoc = nsdoc; diff --git a/dlls/mshtml/nsiface.idl b/dlls/mshtml/nsiface.idl index 219ac0c..ef64145 100644 --- a/dlls/mshtml/nsiface.idl +++ b/dlls/mshtml/nsiface.idl @@ -23,7 +23,7 @@ * compatible with XPCOM, usable in C code. */ -cpp_quote("#define GECKO_VERSION \"0.9.0\"") +cpp_quote("#define GECKO_VERSION \"0.9.1\"") cpp_quote("#define GECKO_VERSION_STRING \"Wine Gecko \" GECKO_VERSION") import "wtypes.idl"; @@ -873,6 +873,7 @@ interface nsIDOMNSDocument : nsISupports /* Wine extensions */ nsresult WineAddObserver(nsIDocumentObserver *aObserver); + nsresult WineRemoveObserver(nsIDocumentObserver *aObserver); nsresult WineAddScriptRunner(nsIRunnable *aRunnable); } -- 1.6.0.6 [View Less]

6 9

Re: mshtml/tests: skip tests if gecko is not available
by Jacek Caban 08 Feb '09

08 Feb '09

Hi Austin, Austin English wrote: - hres = IHTMLDocument2_get_body(doc, &body); - ok(hres == S_OK, "get_body failed: %08x\n", hres); - if(body) { + hres = IHTMLDocument2_get_body(doc, &body); + ok(hres == S_OK, "get_body failed: %08x\n", hres); You check body before getting it, so it can't work and these tests would always be skipped. I've sent a correct version. Jacek

1 0

LookupIconIdFromDirectory16() is unused
by Francois Gouget 08 Feb '09

08 Feb '09

dlls/user32/cursoricon.c defines a LookupIconIdFromDirectory16() function which is not used anywhere. What is strange is thar user.exe.spec exports a LookupIconIdFromDirectoryEx() function. So shouldn't it export a LookupIconIdFromDirectory() function too? In which case I suspect that LookupIconIdFromDirectory16() would be its implementation... Unfortunately I have no information about what 16bit dlls are supposed to export... -- Francois Gouget <fgouget(a)free.fr> … [View More]

4 4

tests with new DIB [2]
by Evgeny Burzak 08 Feb '09

08 Feb '09

Hello, my plays with programs here: * Flash 8 has some missing icons, fonts and i-face glitches. Also it crached when i try to paste big text piece. * Flash CS 3 seems the same, but i haven`t chance to deep in, cause it says that my license expired =) Note that both 8 & CS has big speed up when turned on full anti-aliasing. * IE6 has some broken icons and problems with fonts: strings looks like lines in one px sometimes. * Firefox 3 works veeeery slowly and has errors in pages … [View More]

1 0

Bugzilla default assignment for secur32
by Kai Blin 08 Feb '09

08 Feb '09

Hi folks, since SSL support sort of works, we're getting a large amount of SSL-related bugs. As I don't deal with the SSL-implementation at all, could some Bugzilla admin remove me as defauly assignee for secur32 bugs again? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: Support for Dragon NS in Wine
by Susan Cragin 08 Feb '09

08 Feb '09

3 2

Re: notepad: Make the Lithuanian resources SUBLANG_NEUTRAL.
by Francois Gouget 07 Feb '09

07 Feb '09

On Sat, 7 Feb 2009, Aurimas Fišeras wrote: [...] > Since there is only one sublang SUBLANG_LITHUANIAN_LITHUANIA (1) it > probably doesn't matter which one to use. > > [1] http://msdn.microsoft.com/en-us/library/dd318693(VS.85).aspx#NotesPrim Actually Wine has two: #define SUBLANG_LITHUANIAN_LITHUANIA 0x01 #define SUBLANG_LITHUANIAN_CLASSIC 0x02 Which is why, unless we know the translation is really specific to one of them, we prefer to use SUBLANG_NEUTRAL. But you'… [View More]

1 0

Re: richedit: Removed unnecessary calls to ME_WrapMarkedParagraphs.
by Massimo Del Fedele 07 Feb '09

07 Feb '09

Dylan Smith ha scritto: > These calls to ME_WrapMarkedParagraphs never do anything, and don't make > sense to be called in these places. These places are for ME_MoveCaret, > and ME_ArrowHome, which both don't involve any text being modified, and > all (direct and indirect) calls to these functions are done after the > text has already been wrapped. > --- > dlls/riched20/caret.c | 3 --- > dlls/riched20/paint.c | 2 +- > 2 files changed, 1 insertions(+), 4 … [View More]

1 0

tests with new DIB
by Evgeny Burzak 07 Feb '09

07 Feb '09

Hello, I make some tests and it show interesting results: * Archicad 10 and 11 can open plans, crashed of course and unusable, but with WINEDIB=OFF it didn`t work at all. * Flash 8 with WINEDIB=ON render fonts much faster. Screens and logs attached. colors of plans are wrong. Must be grey on white. -- Evgeny Burzak <buzzilo(a)gmael.xn--l1adi>

2 1

Re: riched20: Remove unused functions
by Dylan Smith 07 Feb '09

07 Feb '09

On Sat, Feb 7, 2009 at 9:33 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > > @@ -65,17 +65,6 @@ ME_String *ME_MakeStringR(WCHAR cRepeat, int nMaxChars) > return s; > } > > -ME_String *ME_MakeStringB(int nMaxChars) > -{ /* Create a buffer (uninitialized string) of size nMaxChars */ > - ME_String *s = ALLOC_OBJ(ME_String); > - > - s->nLen = nMaxChars; > - s->nBuffer = ME_GetOptimalBuffer(s->nLen+1); > - s->szData = … [View More]

1 0

Re: imagicos
by Ben Klein 07 Feb '09

07 Feb '09

Oops, forgot to Reply All. Sorry, Austin! 2009/2/7 Austin English <austinenglish(a)gmail.com>: > On Fri, Feb 6, 2009 at 7:30 PM, Ben Klein <shacklein(a)gmail.com> wrote: >> 2009/2/7 Austin English <austinenglish(a)gmail.com>: >>> On Fri, Feb 6, 2009 at 7:16 PM, Ben Klein <shacklein(a)gmail.com> wrote: >>>> 2009/2/7 EA Durbin <ead1234(a)hotmail.com>: >>>>> I just saw this linux distribution on distrowatch. They claim to … [View More]be able to >>>>> run all microsoft products. Interesting. >>>>> http://www.imagicos.com/ >>>>> http://www.imagicos.com/microsoft.html >>>> >>>> No they don't. It says "almost every" on the home page and "most" on >>>> the "Microsoft" page. >>>> >>>> Assuming they're talking about Wine, someone should tell them that >>>> they're wrong anyway. "quite a lot of entirely win32 applications", >>>> maybe. Almost certainly not "most". >>>> >>>> Ooh, just spotted some interesting items on their "tested applications" list. >>>> - DirectX >>>> - DirectX 6 >>>> - DirectX 7 >>>> - DirectX 8 >>>> - DirectX 9 >>>> >>>> How about we just completely ignore these idiots? >>> >>> Also: >>> # Internet Explorer 5.0 and 5.5 >>> # Internet Explorer 6.0 >> >> I've heard of some success with 6.0 (without crappy >> winedoors/ies4linux stuff), so I didn't comment. >> >>> # iPod Support in iTunes 4.0 >> >> Hmm, that seems unlikely >> >>> # Mac OS X >>> # Mac OS X Audio Input Support >> >> Well spotted, Austin! >> >> Maybe they're talking about a VM, not Wine ... in which case, you'd >> have to get a copy of Windows, which defeats the purpose of being >> proud about their Windows app support. >> > > From http://www.imagicos.com/why.html : > "Compatibility > iMagic OS can run many Microsoft Windows applications along with Linux > applications, with help from the built in Crossover software." That might just explain why "CrossOver" is on their supported/tested apps list. Then again, maybe not. > Either they've got a deal with Crossover, or bundled it somehow? > > I sent them an e-mail asking for the source, we'll see how that goes. Not that I think it's worth talking about this for much longer, but also found these amusing: # Acrobat Reader 8 because there's no Linux-native version of that, is there? Oh wait, there is, and it's called Adobe Acrobat Reader 8 for Linux! # Adobe Creative Suite 2 (CS2) ... # Illustrator CS2 # InDesign CS2 ... # Photoshop CS2 Not trying to pad it out at all, are we? # The Orange Box which is not an application, but a box. Inside the box is HL2, Portal, TF2 etc # EVE Online ... # World of Warcraft # World of Warcraft Online OOOOOooooh online versions of MMORPGs! # Windows Media Player 6.4 # Windows Media Player 6.9 And ONLY THOSE SPECIFIC VERSIONS! Thanks, EA Durbin, you've made my day :D [View Less]

1 0

Re: Stub DDE interface for Progman.exe
by Dmitry Timoshkov 07 Feb '09

07 Feb '09

"Jeremiah Flerchinger" <jeremiah.flerchinger(a)gmail.com> wrote: > Stubs basic DDE interface of Progman.exe. Similar to Progman stub in > shell32.dll. Both will need to be extended and a 3rd progman interface > will need to be added in user32. Progman DDE interface should be implemented by shell32.dll, nowhere else. -- Dmitry.

5 12

re: New Wine Gecko package
by Dan Kegel 06 Feb '09

06 Feb '09

James Mckenzie wrote: > It depends on the timeline for the 1.2 release. > If this is a long way off, it may be worth the effort. I don't know. The 1.1 branch has are lots of improvements people want; what's so special about Gecko? IMHO we should leave the 1.0 branch alone, and just get on with 1.2. Speaking of which, I wonder which of Alexandre's 1.2 wish list features will be done first? http://wiki.winehq.org/WineReleasePlan Win64 is looking like the front runner at the moment, but … [View More]

3 2

[Fwd: WINE: suspected bug in change to winealsa.drv/waveout.c]
by Deomid Ryabkov 06 Feb '09

06 Feb '09

Maarten didn't reply, widening to wine-devel@ summary: looks like a bug was introduced into WaveOut queue management back in october that causes sound to skip and stutter. -------- Original Message -------- Subject: WINE: suspected bug in change to winealsa.drv/waveout.c Date: Sun, 25 Jan 2009 03:46:09 +0000 From: Deomid Ryabkov <myself(a)rojer.pp.ru> To: m.b.lankhorst(a)gmail.com hi, Maarten. i'm a complete noob in WINE, this is the first time i delved in the source, so … [View More]

1 0

http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/smbsrv/ndl/
by Luke Kenneth Casson Leighton 06 Feb '09

06 Feb '09

holy cow. opensolaris appears to have its own smb server / idl compiler: http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/tools/ndrgen/ CDDL licensed, unfortunately (listed as incompatible with GPL. darn). but... dang :)

1 0

http://wiki.winehq.org/NamedPipes
by Luke Kenneth Casson Leighton 06 Feb '09

06 Feb '09

rob, hi, regarding the above wiki page - there is no "obstacle". you can use any of the code that i wrote for samba (about 100,000 lines of code), i released all of it into the public domain, on dec 16th, 2005. there's enough there so that you can do an entirely "hands off" approach, getting packets in and out using (see last post!) surprise,surprise, emulated named pipes. what i did for tng was to create a "packaging" system which sent security contexts (complete security descriptors and … [View More]other identifiying information) over a unix socket. it was completely transparent as far as smbd was concerned, which just "handed it around" to the appropriate daemons. i asked jeremy to add in simple support for this into main samba several times. the last time (dec 2005) once _again_ he fucked about, but did actually agree that it was a good idea. samba having "break-out" for named pipes traffic is one of those absolutely _essential_ things that should have fucking well gone into the samba source code a _long_ time ago. around 1998 would have been good. _several_ projects would enormously benefitted - including samba - if that had happened. sun microsystems, who bought the [well known to be a complete piece-of-crap] port of nt to unix, AFPS, for $USD 4m and were utterly appalled by the poor quality of the implementation of the smb server gave serious consideration to dumping it, keeping the MSRPC services, and riding off the back of samba.... .. via _guess what_! a named pipe "break-out" interface. which, of course, doesn't exist. so they couldn't do it. but gordon did discuss it with me, saying things like, "y'know, if samba had a way in to its named pipes interface..." and guess what? in order for you to do named pipes via samba, you need a named pipe "break-out" interface. guess how luke howard implemented XAD (which he sold to novell a couple of years ago)? he implemented a patch to samba which provided a named pipe "break-out" interface. that patch was released back in about 2002 and has never been incorporated into samba. the protocol for a break-out interface is very simple: you need four functions ( and they can be done in as little as about 300 lines of c-code, as a patch to samba) 1) open named pipe connection 2) read pipe 3) write pipe 4) close pipe if you implement that in a dynamically-loadable .so, style, as a vector table (see e.g. apache2 module interface for example) then you can dump a .so into a directory which samba can pick up. any data that comes in from SMB will then "activate" the .so, call the open_named_pipe function in the vector table, and you're away. you release the code of the .so under the LGPL, that gets "GPL'd" by samba, license problem is solved. so, with a small patch to samba, the means to take control of the direction of wine is within _your_ hands. because the dynamically loadable .so conforms to the "break-out" interface and is loaded _by_ samba, on demand, and the code in it is part of Wine and communicates using Wine protocols - entirely under your control. ... you know... it would actually be a lot easier to integrate wine with samba tng, because the infrastructure to communicate by emulated NamedPipes already exists. take a look at the following functions: ncalrpc_l_connect ncalrpc_l_close_socket receive_msrpc msrpc_send all of which are in lib/msrpc-client.c - you'll see in there that there are corresponding functions for the samba tng win32 port - CreateNamedPipe, ReadFile, WriteFile, WaitNamedPipeHandleState, CloseHandle etc. which will help give you some _really_ big clue-handles to understand the corresponding "emulating" functions using unix sockets. you _should_ also recognise the ncalrpc_srv_get_user_creds function and its equivalent client-side "sender" ncalrpc_l_authenticate. these two are a matched pair of functions which marshal and unmarshal an NT security context [based on a NET_USER_INFO_3 structure - recognise that one? :) it's a stub in wine - now you have some code that gives it purpose! ] basically after a connect (ncalrpc_l_connect) the client sends the user creds _immediately_, and the server picks them up, and saves them in its internal context (for later passing around etc). also they end up getting used to do seteuid() but as the entire protocol was used by root _only_ it was perfect safe to do this. the unix sockets were protected 600 with the directory they were in being protected 755 because some unixen _still_ bloody well let you access a unix domain socket even if its permissions were 600, all owned by root, all services running _as_ root, so one daemon being a client passing over a security context that told _another_ daemon running as root to seteuid to a user's uid was no big hairy deal. except that andrew thought that i was some sort of fucking 17-year-old incompetent student, and he didn't like the thought of me actually being a capable unix systems programmer. thus, this code could be justified as never going into samba (even though a similar implementation was designed _by_ him for use in winbind). _really_ interesting bit of hypocrisy going on there. the sad thing is that it's stopped _so_ much progress in free software, it's unreal. anyway - you can pick up that code with: cvs -d anoncvs@anoncvs.samba-tng.org:/home/cvsroot co tng it's anoncvs - just press return look in tng/source/lib/msrpc-client.c btw don't be fooled into thinking that just because you're on loopback - running samba and wine on the same machine and only processing requests that come in or go out over 127.0.0.1 - don't be fooled into thinking that you can throw away the security context (the NET_USER_INFO_3 stuff) - you can't. you _really_ need to keep it around, and pass it back-and-forth. so - to recap what the protocol / procedure is: * a small .so has already been dropped into samba's lib/ directory which has been dynamically-loaded; any SMB-based "NamedPipe" traffic that is NOT destined for internal samba services (such as \\PIPE\lsarpc etc) is handed to this .so. the .so, when an incoming "ConnectNamedPipe" request is made, will direct the contents, pretty much verbatim BUT pre-pending the security context "blob" (see above) to any initial connects. * any win32 programs that call CreateNamedPipe will result in a call .. ... you know what? this is getting complex - and i'm spending quite a bit of time writing it. i designed this stuff, once, and it worked. wine needs it. samba needs it. so, i'm really _really_ sorry to have to bring this up - but it's a quite important point: if you can find someone to pay for the necessary development, i'm more than happy to do the work. i'm also happy to help advise people on how this can be implemented (if the above clues and directional guides aren't enough) it's been ten years since this kind of cross-project integration stalled: i've watched the development of wine go its way, and samba go its way, and ntfs filesystem drivers for linux go _their_ way, and all of these projects don't _actually_ cooperate or link together properly. nobody's actually _paid_ any fucking money to coordinate and liase with these projects. there's people paid to work on linux; there's people paid to work on wine; there's people paid to work on samba. and the only people who really suffer for lack of this really important strategic interoperability is: users. so can we _please_ pull our collective fingers out of our arses, get some sponsorship and funding from _somewhere_ and get moving? that last said with the utmost of respect :) l. [View Less]

2 5

Re: [patch] rpcrt4_conn_np_read needs to expect and accept ERROR_MORE_DATA
by Juan Lang 06 Feb '09

06 Feb '09

Hi Luke, @@ -382,7 +382,14 @@ static int rpcrt4_conn_np_read(RpcConnection *Connection, { DWORD bytes_read; ret = ReadFile(npc->pipe, buf, bytes_left, &bytes_read, NULL); - if (!ret || !bytes_read) + if (!ret) + { + TRACE("ReadFile error, status %x\n", GetLastError()); + if (GetLastError() != ERROR_MORE_DATA) + break; + ret = TRUE; /* ERROR_MORE_DATA is an expected acceptable error code */ + } + if (!bytes_read) break; Style … [View More]

2 1

Re: Use environment variable WINE_NO_MENU_ENTRIES to prevent menu icon and menu entry creation.
by Detlef Riekenberg 06 Feb '09

06 Feb '09

On Do, 2009-02-05 at 18:02 +0100, Christoph Korn wrote: > int PASCAL WinMain (HINSTANCE hInstance, HINSTANCE prev, LPSTR > cmdline, int show) > { > + if(getenv("WINE_NO_MENU_ENTRIES")) > + { > + return 0; > + } > + > LPSTR token = NULL, p; Declaring a variable after code is C99 and not allowed in Wine. -- By by ... Detlef

2 1

Re: widl: initialize _RetVal to avoid compiler warnings
by Rob Shearman 06 Feb '09

06 Feb '09

2009/2/5 Christoph von Wittich <Christoph(a)apiviewer.de>: > --- a/tools/widl/proxy.c > +++ b/tools/widl/proxy.c > @@ -327,7 +327,12 @@ static void gen_proxy(type_t *iface, const var_t > *func, int idx, > if (has_ret) { > print_proxy( "" ); > write_type_decl_left(proxy, type_function_get_rettype(func->type)); > - print_proxy( " _RetVal;\n"); > + > + /* Initialize _RetVal properly in order to avoid compiler warnings */ > + if (is_ptr(… [View More]

1 0

Re: rpcrt4: Check for null endpoint in RpcServerUseProtseqEpExW
by Rob Shearman 06 Feb '09

06 Feb '09

2009/2/5 Nikolay Sivov <bunglehead(a)gmail.com>: > Changelog: > - Check for null endpoint in RpcServerUseProtseqEpExW. > Installed IE8 RC1 crashes on this call, parameter set is specified in > test case. > > >From 89f889b2c7a754302b599884577b4eba22b3d235 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Thu, 5 Feb 2009 22:03:48 +0300 > Subject: Check for null endpoint in RpcServerUseProtseqEpExW > > --- &… [View More]gt; dlls/rpcrt4/rpc_server.c | 6 ++++-- > dlls/rpcrt4/tests/rpc.c | 15 +++++++++++++++ > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/dlls/rpcrt4/rpc_server.c b/dlls/rpcrt4/rpc_server.c > index b6e058a..e9bed42 100644 > --- a/dlls/rpcrt4/rpc_server.c > +++ b/dlls/rpcrt4/rpc_server.c > @@ -775,8 +775,10 @@ RPC_STATUS WINAPI RpcServerUseProtseqEpExW( RPC_WSTR Protseq, UINT MaxCalls, RPC > return status; > > EndpointA = RPCRT4_strdupWtoA(Endpoint); > - status = RPCRT4_use_protseq(ps, EndpointA); > - RPCRT4_strfree(EndpointA); > + if (EndpointA) { > + status = RPCRT4_use_protseq(ps, EndpointA); > + RPCRT4_strfree(EndpointA); > + } This isn't correct, I'm afraid. The protseq open function should generate an endpoint name to use. For example, the ncacn_ip_tcp code should select a random available TCP port. > return status; > } > > diff --git a/dlls/rpcrt4/tests/rpc.c b/dlls/rpcrt4/tests/rpc.c > index bf538e4..b815acc 100644 > --- a/dlls/rpcrt4/tests/rpc.c > +++ b/dlls/rpcrt4/tests/rpc.c > @@ -830,6 +830,20 @@ static void test_UuidCreate(void) > } > } > > +static void test_RpcServerUseProtseqEpEx(void) > +{ > + RPC_STATUS status; > + RPC_POLICY policy; > + static WCHAR protW[] = {'n','c','a','l','r','p','c',0}; > + > + policy.Length = sizeof( policy ); > + policy.EndpointFlags = 0; > + policy.NICFlags = 0; > + > + status = RpcServerUseProtseqEpExW(protW, 10, NULL, NULL, &policy); > + ok(status == RPC_S_OK, "Expected RPC_S_OK, got %d\n", status); > +} This is a good start, but you should also test the bindings created as a result of doing this and then you will probably discover that the fix to RpcServerUseProtseqEpExW isn't quite correct. > START_TEST( rpc ) > { > static unsigned char ncacn_np[] = "ncacn_np"; > @@ -849,4 +863,5 @@ START_TEST( rpc ) > test_endpoint_mapper(ncalrpc, NULL, lrpc_endpoint); > test_RpcStringBindingFromBinding(); > test_UuidCreate(); > + test_RpcServerUseProtseqEpEx(); > } -- Rob Shearman [View Less]

2 2

DIB Engine - Patchset separated by original author
by Massimo Del Fedele 06 Feb '09

06 Feb '09

As asked to me, I have separated the dib engine into a patchset, trying to keep (when possible) the original author's submissions, so Huw Davies, Jesse Allen and me. I had to change some of other author's commits in order to fit my engine and to rebase it on 1.1.14, so I ask both previous authors to check if they agree on the patches. I hope this will help the review, as keeping it rebased on wine tree will become quite hard having it as a separated patchset. Attached here is a zipped … [View More]

4 4

re: gdiplus: Some tests for GdipGetLineRect
by Dan Kegel 06 Feb '09

06 Feb '09

Nikolay Sivov <bunglehead at gmail.com> wrote: > ... > + ok(rectf.X == 10.0, "Expected 10.0 got %.2f\n", rectf.X); Exact equality comparison on float is never a good idea in unit tests. You need a range test instead. See http://code.google.com/p/googletest/wiki/GoogleTestAdvancedGuide#Floating-P…

1 0

Re: widl: filter_func isn't used when USE_COMPILER_EXCEPTIONS is defined
by Rob Shearman 06 Feb '09

06 Feb '09

2009/2/6 Christoph von Wittich <Christoph(a)apiviewer.de>: > diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c > index 0dcb737..88c0e53 100644 > --- a/tools/widl/proxy.c > +++ b/tools/widl/proxy.c > @@ -122,10 +122,12 @@ static void init_proxy(const statement_list_t *stmts) > print_proxy( " void *This;\n"); > print_proxy( "};\n"); > print_proxy( "\n"); > + print_proxy("#ifndef USE_COMPILER_EXCEPTIONS\n"); > print_proxy("static int … [View More]

2 1

[patch] rpcrt4_conn_np_read needs to expect and accept ERROR_MORE_DATA
by Luke Kenneth Casson Leighton 06 Feb '09

06 Feb '09

http://bugs.winehq.org/show_bug.cgi?id=17263 hooray! very simple fix, here - allow ERROR_MORE_DATA status code as an acceptable error. ... and _check it_, afterwards. ideally, the loop to read a complete PDU should be vaguely like this: do { RpcConnection conn->ops->read(data, &len) total_read += len; if GetLastError() == ERROR_MORE_DATA if total_read == total_packet_size return FALSE; /* not ok to return ERROR_MORE_DATA at end of PDU! } while (… [View More]

2 2

wine iexplore speed test (JavaScript)
by Detlef Riekenberg 06 Feb '09

06 Feb '09

I did a speed test for JS with Wine: ######################## http://v8.googlecode.com/svn/data/benchmarks/v3/run.html wine 17666004c839a40f1dbc5c98468557091bf3e13c Score: 48.5 Richards: 47.7 DeltaBlue: 56.3 Crypto: 32.1 RayTrace: 54.9 EarleyBoyer: 65.9 RegExp: 41.9 Same System, with Firefox 3.0.5: Score: 60.4 Richards: 65.8 DeltaBlue: 76.7 Crypto: 45.1 RayTrace: 53.7 EarleyBoyer: 96.5 RegExp: 41.2 Is there a way to use our jscript.dll instead of js3250.dll? Or a way to … [View More]

2 2

IPinImpl_QueryInternalConnections() is unused
by Francois Gouget 06 Feb '09

06 Feb '09

dlls/qcap/pin.c defines an IPinImpl_QueryInternalConnections() function but it is not actually used anywhere. Is there any reason to keep it? It sort of looks like IPin is a virtual class and that IPin::QueryInternalConnections() is going to be implemented in its descendents like VfwPin as is currently the case. But then VfwPin_QueryInternalConnections() is just as much of a stub so maybe it is it that should go away? -- Francois Gouget <fgouget(a)free.fr> http://… [View More]

2 1

Re: New Wine Gecko package
by James Mckenzie 05 Feb '09

05 Feb '09

Jacek Caban <jacek(a)codeweavers.com> wrote: >Sent: Feb 5, 2009 12:28 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Scott Ritchie <scott(a)open-vote.org>, wine-devel <wine-devel(a)winehq.org> >Subject: Re: New Wine Gecko package > >James Mckenzie wrote: >> Jacek Caban <jacek(a)codeweavers.com> wrote: >> >>> Scott Ritchie wrote: >>> >>>> Is this version compatible with Wine 1.0.1 by … [View More]

1 0

Re: [PATCH] mshtml: Fixed last argument to MBtoWC
by Rob Shearman 05 Feb '09

05 Feb '09

2009/2/4 Marcus Meissner <marcus(a)jet.franken.de>: > @@ -442,7 +442,7 @@ static LPWSTR get_url(void) > > if(size > sizeof(httpW) && !memcmp(url, httpW, sizeof(httpW))) { > strcatW(url, v_formatW); > - MultiByteToWideChar(CP_ACP, 0, GECKO_VERSION, -1, url+strlenW(url), -1); > + MultiByteToWideChar(CP_ACP, 0, GECKO_VERSION, -1, url+strlenW(url), (size-strlenW(url))/sizeof(WCHAR)); Dividing a string length (which returns character … [View More]

2 1

ideas and questions for implementation of MessageMode in Named Pipes
by Luke Kenneth Casson Leighton 05 Feb '09

05 Feb '09

ok, alexandre: i tried moving named_pipe_read into wineserver - it's not possible to do completely, as you cannot do blocking-reads in wineserver but you still need blocking-read characteristics in the client (kernel32, ntdll). if you start messing with the fd, setting or clearing ioctl O_NONBLOCK in one, it interferes with the other. there's a race-condition risk. so, i have some ideas and questions. 1) is it possible for wineserver to tell a thread to wait indefinitely? is there a … [View More]

2 7

Re: New Wine Gecko package
by James Mckenzie 05 Feb '09

05 Feb '09

Jacek Caban <jacek(a)codeweavers.com> wrote: > >Scott Ritchie wrote: >> Jacek Caban wrote: >> >>> Hi all, >>> >>> The last release of Wine Gecko caused a few regressions. Thanks to >>> Alexandre, we've found the reason. The bad news is that the fix requires >>> a new package. I've uploaded RC build to: >>> >>> http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko-0.9.1.cab >>> >>> I'd … [View More]

2 1

bugzilla stuck?
by Dan Kegel 05 Feb '09

05 Feb '09

It seems hung to me at the moment...

3 3

Re: [PATCH] advapi32: fixed second buffer argument to MBtoWC and WCtoMB
by Alexandre Julliard 05 Feb '09

05 Feb '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > diff --git a/dlls/advapi32/cred.c b/dlls/advapi32/cred.c > index 9ad4fb1..ab86ed6 100644 > --- a/dlls/advapi32/cred.c > +++ b/dlls/advapi32/cred.c > @@ -940,7 +940,8 @@ static void convert_PCREDENTIALW_to_PCREDENTIALA(const CREDENTIALW *CredentialW, > if (CredentialW->TargetName) > { > CredentialA->TargetName = buffer; > - string_len = WideCharToMultiByte(CP_ACP, 0, CredentialW-… [View More]

1 0

Re: [RESEND] comctl32: Save and restore colours when adding masked images
by Alexandre Julliard 05 Feb '09

05 Feb '09

Peter Urbanec <winehq.org(a)urbanec.net> writes: > This patch will save and restore the colours when adding a masked image > to ImageList. What's the point of restoring the colors in a DC that gets deleted right away? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: avifil32: ukranian translation by Artem Reznikov
by Alexandre Julliard 05 Feb '09

05 Feb '09

Christoph von Wittich <Christoph(a)ApiViewer.de> writes: > dlls/avifil32/avifile_Uk.rc | 51 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/avifil32/rsrc.rc | 1 + > 2 files changed, 52 insertions(+), 0 deletions(-) Please add a From: line with the full name and email of the original author (or better ask him to submit the patch himself). And please fix your mail setup, all your patches are wrapped. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: DeviceIoControl: lpBytesReturned must not be NULL if lpOverlapped is NULL
by Nikolay Sivov 05 Feb '09

05 Feb '09

Christoph von Wittich wrote: > dlls/kernel32/comm.c | 55 > +++++++++++++++++++++++++++++++------------------ > 1 files changed, 35 insertions(+), 20 deletions(-) > > diff --git a/dlls/kernel32/comm.c b/dlls/kernel32/comm.c > index d83eacb..11cfda0 100644 > --- a/dlls/kernel32/comm.c > +++ b/dlls/kernel32/comm.c > @@ -551,7 +551,8 @@ BOOL WINAPI BuildCommDCBW( > */ > BOOL WINAPI SetCommBreak(HANDLE handle) > { > - return DeviceIoControl(handle, … [View More]IOCTL_SERIAL_SET_BREAK_ON, NULL, 0, > NULL, 0, NULL, NULL); > + DWORD dwBytesReturned; > + return DeviceIoControl(handle, IOCTL_SERIAL_SET_BREAK_ON, NULL, 0, > NULL, 0, &dwBytesReturned, NULL); > } > > /***************************************************************************** > @@ -573,7 +574,8 @@ BOOL WINAPI SetCommBreak(HANDLE handle) > */ > BOOL WINAPI ClearCommBreak(HANDLE handle) > { > - return DeviceIoControl(handle, IOCTL_SERIAL_SET_BREAK_OFF, NULL, 0, > NULL, 0, NULL, NULL); > + DWORD dwBytesReturned; > + return DeviceIoControl(handle, IOCTL_SERIAL_SET_BREAK_OFF, NULL, 0, > NULL, 0, &dwBytesReturned, NULL); > } > > /***************************************************************************** > @@ -595,6 +597,7 @@ BOOL WINAPI ClearCommBreak(HANDLE handle) > BOOL WINAPI EscapeCommFunction(HANDLE handle, UINT func) > { > DWORD ioc; > + DWORD dwBytesReturned; > > switch (func) > { > @@ -612,7 +615,7 @@ BOOL WINAPI EscapeCommFunction(HANDLE handle, UINT func) > SetLastError(ERROR_INVALID_PARAMETER); > return FALSE; > } > - return DeviceIoControl(handle, ioc, NULL, 0, NULL, 0, NULL, NULL); > + return DeviceIoControl(handle, ioc, NULL, 0, NULL, 0, > &dwBytesReturned, NULL); > } > > /******************************************************************** > @@ -632,8 +635,9 @@ BOOL WINAPI EscapeCommFunction(HANDLE handle, UINT func) > */ > BOOL WINAPI PurgeComm(HANDLE handle, DWORD flags) > { > + DWORD dwBytesReturned; > return DeviceIoControl(handle, IOCTL_SERIAL_PURGE, &flags, > sizeof(flags), > - NULL, 0, NULL, NULL); > + NULL, 0, &dwBytesReturned, NULL); > } > > /***************************************************************************** > @@ -654,9 +658,10 @@ BOOL WINAPI PurgeComm(HANDLE handle, DWORD flags) > BOOL WINAPI ClearCommError(HANDLE handle, LPDWORD errors, LPCOMSTAT lpStat) > { > SERIAL_STATUS ss; > + DWORD dwBytesReturned; > > if (!DeviceIoControl(handle, IOCTL_SERIAL_GET_COMMSTATUS, NULL, 0, > - &ss, sizeof(ss), NULL, NULL)) > + &ss, sizeof(ss), &dwBytesReturned, NULL)) > return FALSE; > > if (errors) > @@ -708,11 +713,12 @@ BOOL WINAPI ClearCommError(HANDLE handle, LPDWORD > errors, LPCOMSTAT lpStat) > BOOL WINAPI SetupComm(HANDLE handle, DWORD insize, DWORD outsize) > { > SERIAL_QUEUE_SIZE sqs; > + DWORD dwBytesReturned; > > sqs.InSize = insize; > sqs.OutSize = outsize; > return DeviceIoControl(handle, IOCTL_SERIAL_SET_QUEUE_SIZE, > - &sqs, sizeof(sqs), NULL, 0, NULL, NULL); > + &sqs, sizeof(sqs), NULL, 0, > &dwBytesReturned, NULL); > } > > /***************************************************************************** > @@ -732,9 +738,10 @@ BOOL WINAPI SetupComm(HANDLE handle, DWORD insize, > DWORD outsize) > */ > BOOL WINAPI GetCommMask(HANDLE handle, LPDWORD evtmask) > { > + DWORD dwBytesReturned; > TRACE("handle %p, mask %p\n", handle, evtmask); > return DeviceIoControl(handle, IOCTL_SERIAL_GET_WAIT_MASK, > - NULL, 0, evtmask, sizeof(*evtmask), NULL, NULL); > + NULL, 0, evtmask, sizeof(*evtmask), > &dwBytesReturned, NULL); > } > > /***************************************************************************** > @@ -755,9 +762,11 @@ BOOL WINAPI GetCommMask(HANDLE handle, LPDWORD evtmask) > */ > BOOL WINAPI SetCommMask(HANDLE handle, DWORD evtmask) > { > + DWORD dwBytesReturned; > + > TRACE("handle %p, mask %x\n", handle, evtmask); > return DeviceIoControl(handle, IOCTL_SERIAL_SET_WAIT_MASK, > - &evtmask, sizeof(evtmask), NULL, 0, NULL, NULL); > + &evtmask, sizeof(evtmask), NULL, 0, > &dwBytesReturned, NULL); > } > > static void dump_dcb(const DCB* lpdcb) > @@ -797,6 +806,7 @@ BOOL WINAPI SetCommState( HANDLE handle, LPDCB lpdcb) > SERIAL_LINE_CONTROL slc; > SERIAL_HANDFLOW shf; > SERIAL_CHARS sc; > + DWORD dwBytesReturned; > > if (lpdcb == NULL) > { > @@ -858,13 +868,13 @@ BOOL WINAPI SetCommState( HANDLE handle, LPDCB lpdcb) > * so flow control does not interfere. > */ > return (DeviceIoControl(handle, IOCTL_SERIAL_SET_BAUD_RATE, > - &sbr, sizeof(sbr), NULL, 0, NULL, NULL) && > + &sbr, sizeof(sbr), NULL, 0, > &dwBytesReturned, NULL) && > DeviceIoControl(handle, IOCTL_SERIAL_SET_LINE_CONTROL, > - &slc, sizeof(slc), NULL, 0, NULL, NULL) && > + &slc, sizeof(slc), NULL, 0, > &dwBytesReturned, NULL) && > DeviceIoControl(handle, IOCTL_SERIAL_SET_HANDFLOW, > - &shf, sizeof(shf), NULL, 0, NULL, NULL) && > + &shf, sizeof(shf), NULL, 0, > &dwBytesReturned, NULL) && > DeviceIoControl(handle, IOCTL_SERIAL_SET_CHARS, > - &sc, sizeof(sc), NULL, 0, NULL, NULL)); > + &sc, sizeof(sc), NULL, 0, &dwBytesReturned, > NULL)); > } > > > @@ -891,6 +901,7 @@ BOOL WINAPI GetCommState(HANDLE handle, LPDCB lpdcb) > SERIAL_LINE_CONTROL slc; > SERIAL_HANDFLOW shf; > SERIAL_CHARS sc; > + DWORD dwBytesReturned; > > TRACE("handle %p, ptr %p\n", handle, lpdcb); > > @@ -901,13 +912,13 @@ BOOL WINAPI GetCommState(HANDLE handle, LPDCB lpdcb) > } > > if (!DeviceIoControl(handle, IOCTL_SERIAL_GET_BAUD_RATE, > - NULL, 0, &sbr, sizeof(sbr), NULL, NULL) || > + NULL, 0, &sbr, sizeof(sbr), &dwBytesReturned, > NULL) || > !DeviceIoControl(handle, IOCTL_SERIAL_GET_LINE_CONTROL, > - NULL, 0, &slc, sizeof(slc), NULL, NULL) || > + NULL, 0, &slc, sizeof(slc), &dwBytesReturned, > NULL) || > !DeviceIoControl(handle, IOCTL_SERIAL_GET_HANDFLOW, > - NULL, 0, &shf, sizeof(shf), NULL, NULL) || > + NULL, 0, &shf, sizeof(shf), &dwBytesReturned, > NULL) || > !DeviceIoControl(handle, IOCTL_SERIAL_GET_CHARS, > - NULL, 0, &sc, sizeof(sc), NULL, NULL)) > + NULL, 0, &sc, sizeof(sc), &dwBytesReturned, NULL)) > return FALSE; > > memset(lpdcb, 0, sizeof(*lpdcb)); > @@ -980,8 +991,9 @@ BOOL WINAPI GetCommState(HANDLE handle, LPDCB lpdcb) > */ > BOOL WINAPI TransmitCommChar(HANDLE hComm, CHAR chTransmit) > { > + DWORD dwBytesReturned; > return DeviceIoControl(hComm, IOCTL_SERIAL_IMMEDIATE_CHAR, > - &chTransmit, sizeof(chTransmit), NULL, 0, > NULL, NULL); > + &chTransmit, sizeof(chTransmit), NULL, 0, > &dwBytesReturned, NULL); > } > > > @@ -1002,6 +1014,7 @@ BOOL WINAPI TransmitCommChar(HANDLE hComm, CHAR > chTransmit) > BOOL WINAPI GetCommTimeouts(HANDLE hComm, LPCOMMTIMEOUTS lptimeouts) > { > SERIAL_TIMEOUTS st; > + DWORD dwBytesReturned; > > TRACE("(%p, %p)\n", hComm, lptimeouts); > if (!lptimeouts) > @@ -1010,7 +1023,7 @@ BOOL WINAPI GetCommTimeouts(HANDLE hComm, > LPCOMMTIMEOUTS lptimeouts) > return FALSE; > } > if (!DeviceIoControl(hComm, IOCTL_SERIAL_GET_TIMEOUTS, > - NULL, 0, &st, sizeof(st), NULL, NULL)) > + NULL, 0, &st, sizeof(st), &dwBytesReturned, NULL)) > return FALSE; > lptimeouts->ReadIntervalTimeout = st.ReadIntervalTimeout; > lptimeouts->ReadTotalTimeoutMultiplier = > st.ReadTotalTimeoutMultiplier; > @@ -1043,6 +1056,7 @@ BOOL WINAPI GetCommTimeouts(HANDLE hComm, > LPCOMMTIMEOUTS lptimeouts) > BOOL WINAPI SetCommTimeouts(HANDLE hComm, LPCOMMTIMEOUTS lptimeouts) > { > SERIAL_TIMEOUTS st; > + DWORD dwBytesReturned; > > TRACE("(%p, %p)\n", hComm, lptimeouts); > > @@ -1058,7 +1072,7 @@ BOOL WINAPI SetCommTimeouts(HANDLE hComm, > LPCOMMTIMEOUTS lptimeouts) > st.WriteTotalTimeoutConstant = lptimeouts->WriteTotalTimeoutConstant; > > return DeviceIoControl(hComm, IOCTL_SERIAL_SET_TIMEOUTS, > - &st, sizeof(st), NULL, 0, NULL, NULL); > + &st, sizeof(st), NULL, 0, &dwBytesReturned, > NULL); > } > > /*********************************************************************** > @@ -1078,8 +1092,9 @@ BOOL WINAPI SetCommTimeouts(HANDLE hComm, > LPCOMMTIMEOUTS lptimeouts) > */ > BOOL WINAPI GetCommModemStatus(HANDLE hFile, LPDWORD lpModemStat) > { > + DWORD dwBytesReturned; > return DeviceIoControl(hFile, IOCTL_SERIAL_GET_MODEMSTATUS, > - NULL, 0, lpModemStat, sizeof(DWORD), NULL, > NULL); > + NULL, 0, lpModemStat, sizeof(DWORD), > &dwBytesReturned, NULL); > } > > /*********************************************************************** > > > Hi, your patches are corrupted by line wrapping. [View Less]

1 0

Re: include: Change some DWORD to DWORD_PTR in msacm.h.
by Uwe Bonnes 05 Feb '09

05 Feb '09

>>>>> "Michael" == Michael Stefaniuc <mstefani(a)redhat.de> writes: Michael> The change is for Win64 compatibility and it matches the DDK. -MMRESULT WINAPI acmDriverEnum(ACMDRIVERENUMCB fnCallback, DWORD dwInstance, DWORD fdwEnum) +MMRESULT WINAPI acmDriverEnum(ACMDRIVERENUMCB fnCallback, DWORD_PTR dwInstance, DWORD fdwEnum) Is the spec aentry then still right? ./dlls/msacm32/msacm32.spec:@ stdcall acmDriverDetailsW(long ptr long) -- Uwe Bonnes … [View More]

3 2

Re: [PATCH] cryptui: check NULL ptr differently (Coverity)
by Paul Vriens 05 Feb '09

05 Feb '09

Marcus Meissner wrote: > Hi, > > CID 829, cryptui fails to handle data being NULL > correctly after the if (data) branch. > > Since it is a allocation error, just return on failure. > > Ciao, Marcus > --- > dlls/cryptui/main.c | 35 +++++++++++++++++------------------ > 1 files changed, 17 insertions(+), 18 deletions(-) > > diff --git a/dlls/cryptui/main.c b/dlls/cryptui/main.c > index 498c158..1fe2ed0 100644 > --- a/dlls/cryptui/main.c > ++… [View More]

1 0

Quick and dirty testcases for MS-DOS API?
by Dan Kegel 04 Feb '09

04 Feb '09

Looking at http://bugs.winehq.org/show_bug.cgi?id=17181 I get a feeling that we really need some testcases to verify we conform to the 16 bit MS-DOS API. Yeah, even though 16 bit is on the way out, there's still some use for a few win16 programs, and they use MS-DOS for file I/O. We could merge in http://win16test.googlecode.com, but that requires the Watcom C compiler, and "apt-cache search watcom" still comes up empty (unless you're on Ark Linux, see http://www.openwatcom.org/index.php/… [View More]

7 13

Re: [PATCH] mshtml: fixed second buffer argument to MultiByteToWideChar
by Austin English 04 Feb '09

04 Feb '09

On Wed, Feb 4, 2009 at 2:11 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > Targetbuffer length must not be -1. > > Ciao, Marcus > --- > dlls/mshtml/editor.c | 2 +- > dlls/mshtml/navigate.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c > index 7cbdf2e..e92cf96 100644 > --- a/dlls/mshtml/editor.c > +++ b/dlls/mshtml/editor.c > @@ -588,7 +588,7 @@ … [View More]

2 1

Re: mshtml: Implement IHTMLStyle_put_backgroundColor
by Alistair Leslie-Hughes 04 Feb '09

04 Feb '09

Hi Ricardo, > hi alistair, > you say it implements the put method but the patch has only the get > method... typo? > Thanks for picking this up. It's a typo, Ill resend shortly. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH] mshtml: call install_cab_file() with name directly on non-Wine
by Steven Edwards 04 Feb '09

04 Feb '09

On Wed, Feb 4, 2009 at 1:11 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > A ReactOS developer told me that if the wine_get_dos_file_name() does > not return a function, we should just pass in the current filename > to install_cab_file. > > So I coded it, but the non-UNIX path is untested. > <snip> > Wonder why he does not send a patch himself. Heh maybe his Julliard ranking is not high enough. ;) > + } else { /* ReactOS mode. */ … [View More]

1 0

messagemode named pipes investigation: blocking-reads block writers indefinitely
by Luke Kenneth Casson Leighton 04 Feb '09

04 Feb '09

fascinatingly strange observation came out of writing the latest test (threadwrites) to do namedpipe interoperability testing. main process: blocking-read on namedpipe. 5 threads: write to same named pipe the writes NEVER return (this is with xp). so that WOULD indicate that there IS a per-pipe mutex (and that there are bugs in nt!) l.

1 1

X11DRV_XRandR_Cleanup() is not used
by Francois Gouget 04 Feb '09

04 Feb '09

dlls/x11drv/xrandr.c defines a X11DRV_XRandR_Cleanup() function but it is not actually used anywhere. If I remember correctly past wine-devel emails, restoring the right XRandR mode when an application exits can be tricky (especially in case of a crash). So maybe this is why the function is not called, though I'm not sure it's even related. So my question is: should this function be removed? Or should I simply send a patch calling it from x11drv_main.c:process_detach(), enclosed with the … [View More]

2 1

Re: [2/3] Add initial "write text" support for VGA graphic modes. Requires mode info unify patch
by Alexandre Julliard 04 Feb '09

04 Feb '09

Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com> writes: > else > { > - FIXME("Write %c at (%i,%i) - not yet supported in graphic modes.\n", (char)ascii, x, y); > + dat = vga_fb_window_data; > + /* get attribute values */ > + fgColor = attr & 0x0F; > + bgColor = (attr & 0x70)>>4; > + /* Create DC to draw font on */ > + hDC = CreateCompatibleDC(NULL); > + if (hDC == 0) > + … [View More]{ > + ERR("CreateCompatibleDC FAILED. \n"); > + } > + /* Create bitmap to draw font on > + * define bitmap info {size, width, height, planes, bits, compression, sizeimage} > + * origin defaults to top left. negative height makes origin at bottom left. > + */ > + hTempBmp = CreateDIBSection( hDC, &bmi, DIB_RGB_COLORS, (void**)&pSrcData, NULL, 0 ); > + if (hTempBmp == NULL) > + { > + ERR("CreateDIBSection FAILED. \n"); > + } You should actually handle the errors, not just print an ERR and go on using invalid data. > + /* get a font compatable to old IBM ROM (IBM extended character set) */ > + IBM_hFont = (HFONT) GetStockObject( OEM_FIXED_FONT ); > + GetObjectA ( IBM_hFont, sizeof(LOGFONTA), & IBM_lFont ); > + /* scale character & set attributes - FIXME tweak or make better font for smaller sizes */ > + IBM_lFont.lfWidth = ModeInfo->CharWidth; > + IBM_lFont.lfHeight = ModeInfo->CharHeight; > + /* create new font with desired properties */ > + ModIBM_hFont = CreateFontIndirectA ( & IBM_lFont ); > + if (ModIBM_hFont == NULL) > + { > + ERR("CreateFontIndirectA FAILED. \n"); > + } > + SelectObject(hDC, hTempBmp); > + SelectObject(hDC, ModIBM_hFont); > + SetTextColor(hDC, fgColor<<16); /* set text color 0x00bbggrr */ > + SetBkColor(hDC, bgColor<<16); /* set text color 0x00bbggrr */ > + /* define where char is drawn on bitmap */ > + rect.left = 0; > + rect.top = 0; > + rect.bottom = ModeInfo->CharHeight-1; > + rect.right = ModeInfo->CharWidth-1; > + /* draw char onto temporary bitmap */ > + DrawTextHeight = DrawTextA(hDC, (char *)&ascii, 1, &rect, DT_LEFT); > + if (DrawTextHeight == 0) > + { > + ERR("DrawTextA FAILED. \n"); > + } > + /* translate from TextRow & TextCol to PixelRow & PixelCol */ > + x = x * ModeInfo->CharWidth; > + y = y * ModeInfo->CharHeight; > + /* translate & copy char into display buffer */ > + for (ih = 0; ih < ModeInfo->CharHeight; ih = ih+1) Please cut down on the number of comments, there's no need to explain what each line of code is doing, that's adding more noise than information. -- Alexandre Julliard julliard(a)winehq.org [View Less]

1 0

Re: comctl32: Save and restore colours when adding masked images
by Hans Leidekker 04 Feb '09

04 Feb '09

Hi Peter, > This patch will save and restore the colours when adding a masked image > to ImageList. Some lines in this patch were wrapped, please attach it like you do in your other mails. -Hans

2 1

Re: mshtml: Implement IHTMLStyle_put_backgroundColor
by ricardo_barbano＠hotmail.com 04 Feb '09

04 Feb '09

hi alistair, you say it implements the put method but the patch has only the get method... typo? regards, ricardo -------------------------------------------------- From: "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> Sent: Wednesday, February 04, 2009 5:02 AM To: <wine-patches(a)winehq.org> Subject: mshtml: Implement IHTMLStyle_put_backgroundColor > Hi, > > Changelog: > mshtml: Implement IHTMLStyle_put_backgroundColor > > Best Regards > Alistair … [View More]

1 0

Need help for D3DXComputeSphereBounding
by paulo lesgaz 04 Feb '09

04 Feb '09

Hello, I am trying to implement D3DXComputerSphereBounding. The attached test cases success with a native d3dx9 but fail with a native d3dx8. Can anyone could explain why? Thanks in advance

1 0

Happy user says: "You’ve done the impossible, and it is good."
by Dan Kegel 04 Feb '09

04 Feb '09

A user is declaring that Wine has succeeded: http://loobin.wordpress.com/2009/01/13/wine-ascendant/ http://loobin.wordpress.com/2009/02/03/wine-going-production/

1 0

Re: MSVCRT: Still problems in ASCII Mode
by Dan Kegel 04 Feb '09

04 Feb '09

Thanks. Please don't use rand() in testcases, though. Would a constant 'a' suffice in this case? Which app did you find this in, btw? On Tue, Feb 3, 2009 at 1:55 PM, Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > Hello, > > it seems that in ASCII mode, fseek() may disturb reading. Appended patch > adds a todo_wine. > > Bye > -- > Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de > > Institut fuer Kernphysik … [View More]

2 2

Re: shdocvw: Correct OnAmbientPropertyChange regession
by Jacek Caban 04 Feb '09

04 Feb '09

Alistair Leslie-Hughes wrote: > Hi, > After testing on XP, it appears that OnAmbientPropertyChange when > passwed DISP_UNKNOWN doesnt check all properties. > > Changelog: > shdocvw: Correct OnAmbientPropertyChange regession + CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT); + CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE); + CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL); + CHECK_NOT_CALLED(… [View More]

2 1

Fixing AppDB once and for all
by Zachary Goldberg 03 Feb '09

03 Feb '09

All, So it seems to be almost every other day now when somebody mentions how broken the appdb rating system is. This "broken-ness" has had several high level discussions on Wine-Devel. There have also been many, many proposed solutions to this problem. I do not wish to discuss these problems or these solutions in this thread. It is time something was done about this. By done I mean agreed upon (probably the harder part) then implemented in code and published to the winehq server(s). I'de … [View More]

6 6

Re: Fixing AppDB once and for all
by James Mckenzie 03 Feb '09

03 Feb '09

Zachary Goldberg <zgold(a)bluesata.com> >Sent: Feb 3, 2009 12:27 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Devel <wine-devel(a)winehq.org>, Jeremy Newman <jnewman(a)codeweavers.com> >Subject: Re: Fixing AppDB once and for all > >2009/2/3 James Mckenzie <jjmckenzie51(a)earthlink.net>: >> This would be too early for people on the West Coast of the United States by about three hours. >> >> No time will be … [View More]

1 0

Re: wine honor roll slashdotted
by James Mckenzie 03 Feb '09

03 Feb '09

Dan Kegel <dank(a)kegel.com> wrote: >Sent: Feb 3, 2009 6:48 AM >To: Wine Devel <wine-devel(a)winehq.org> >Subject: wine honor roll slashdotted > >http://tech.slashdot.org/article.pl?sid=09/02/03/0112249 > >One comment mentions the grade inflation on the appdb, >i.e. platinum apps that have not been thoroughly tested >or don't really qualify as platinum... > Dan: Sadly, I agree with the grade inflation. We need a grading interface that will generate … [View More]

4 3

Re: advapi32: add Security Label sids used by IE7
by Paul Vriens 03 Feb '09

03 Feb '09

Aric Stewart wrote: > --- > dlls/advapi32/security.c | 4 ++++ > include/winnt.h | 16 +++++++++++++++- > 2 files changed, 19 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > You added WinUntrustedLabelSid to winnt.h but not to security.c. Is that correct? -- Cheers, Paul.

2 1

Re: kernel32/tests: Add a CreateMutex test. (Win9X todo)
by Dmitry Timoshkov 03 Feb '09

03 Feb '09

"Florian Tobias Schandinat" <FlorianSchandinat(a)gmx.de> wrote: > this test shows a difference between Win9X and NT. (tested on Win98SE > and WinXP) Some apps expect the Win9X behaviour to work. I don't know > what's the right way to fix it. Any advice or patch is welcome. How do that apps work under NT based Windows versions like XP or Vista? -- Dmitry.

2 1

Re: winedos: Improve PIT emulation.
by Alexandre Julliard 03 Feb '09

03 Feb '09

Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> writes: > + /* Convert: time counter -> PIT counter > + * GetSystemTimeAsFileTime: 10000000 Hz > + * PIT frequency: 1193182 Hz */ > + val = (DWORD)(val - delta*1193182./10000000.) % (maxval + 1); You should probably use QueryPerformanceCounter as it already uses the correct frequency. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shdocvw: OnAmbientPropertyChange should refresh all properties with a DISPID_UNKNOWN (try 2)
by Paul Vriens 03 Feb '09

03 Feb '09

Alistair Leslie-Hughes wrote: > Hi, > Added Tests > > Changelog: > shdocvw: OnAmbientPropertyChange should refresh all properties with > a DISPID_UNKNOWN > > Best Regards > Alistair Leslie-Hughes > > > > > > ------------------------------------------------------------------------ > > Hi, These new tests fails on W98, NT4, W2K3 and Vista (no other reports are in yet). Could you have a look? -- Cheers, Paul.

2 1

Re: propsys: Stub for PSRegisterPropertySchema (resent)
by Alexandre Julliard 03 Feb '09

03 Feb '09

Nikolay Sivov <bunglehead(a)gmail.com> writes: > @@ -0,0 +1,34 @@ > +/* > + * Property schema routines > + * > + * Copyright 2009 Nikolay Sivov > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is … [View More]

2 1

Re: Stub DDE interface for Progman.exe
by Austin English 03 Feb '09

03 Feb '09

On Mon, Feb 2, 2009 at 11:24 PM, Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com> wrote: > Stubs basic DDE interface of Progman.exe. Similar to Progman stub in > shell32.dll. Both will need to be extended and a 3rd progman interface > will need to be added in user32. > --- > programs/progman/main.c | 148 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 148 insertions(+), 0 deletions(-) > > diff --git a/programs/progman/main.c b/programs/… [View More]

1 0

wine honor roll slashdotted
by Dan Kegel 03 Feb '09

03 Feb '09

http://tech.slashdot.org/article.pl?sid=09/02/03/0112249 One comment mentions the grade inflation on the appdb, i.e. platinum apps that have not been thoroughly tested or don't really qualify as platinum...

1 0

Re: d3d9/tests : LockRect acquires the lock if D3DLOCK_NOSYSLOCK is not specified.
by Jérôme Gardou 03 Feb '09

03 Feb '09

Forget this one please.

2 1

[winetest] Make sure we can test .NET dlls on Windows (need some advice)
by Paul Vriens 03 Feb '09

03 Feb '09

Hi, Sent to wine-devel so I don't jeopardize my rating too much ;) .NET dlls cannot be found with the existing logic in winetest, mainly because they are not in the search path. If the normal loading of a dll fails we now check against a fixed set of names (fusion only for now). If it's a .NET dll we check if this one is there (according to .NET's mscoree) and get the file information. We can use to existing version checking stuff for that part as it's a normal dll. Remarks, suggestions? … [View More]

1 0

Re: ntdll: add a warning about running wine as root (try 2)
by Vincent Povirk 03 Feb '09

03 Feb '09

The patch does not apply to current master. Vincent Povirk On Mon, Feb 2, 2009 at 8:01 PM, Austin English <austinenglish(a)gmail.com> wrote: > Been seeing it quite a bit recently in the forums. While the patches > to break using sudo/su have helped a bit, seems some users are > convinced they need to run wine as root. This adds a non fatal > message, so no functionality is lost for those that _do_ need to run > as root. > > Try 2: > Made warning a bit more … [View More]

2 1

Re: jscript: Don't fail tests if IActiveScriptParse isn't supported
by Jacek Caban 03 Feb '09

03 Feb '09

Hi Juan, These failures are on Win64 where we should query for different interface. I've sent a patch to fix it: http://www.winehq.org/pipermail/wine-patches/2009-February/068760.html Jacek

2 1

Re: Simplify dlls/comctl32/rebar.c
by Francois Gouget 03 Feb '09

03 Feb '09

On Fri, 30 Jan 2009, Gerald Pfeifer wrote: > (It's not clear which parameters we'd really need if it is ever fully > implemented.) > > ChangeLog: > Simplify. [...] > > Index: dlls/comctl32/rebar.c [...] > @@ -3618,7 +3618,6 @@ REBAR_WindowProc (HWND hwnd, UINT uMsg, > > /* case RB_SETCOLORSCHEME: */ > /* case RB_SETPALETTE: */ > -/* return REBAR_GetPalette (infoPtr, wParam, lParam); */ > > case RB_SETPARENT: Once the commented out … [View More]

2 1

Re: Simple but awesome demos of Wine?
by Brian Vincent 02 Feb '09

02 Feb '09

Oh, by the way, I was using Fedora Core 10. I was pretty impressed with the distro - my Intel wireless card worked out of the box and so did sound. That's the first time I've had that happen on a Dell Latitude notebook. However, sound in Wine didn't work at all. I made absolutely no effort to fix it, but a quick look at the settings showed it was trying to use ALSA. I was hoping Wine's sound had progressed to the point where it would at least work if the underlying distro was using sound in … [View More]

2 1

deb packages archive down?
by Tom Wickline 02 Feb '09

02 Feb '09

Hello, I have been trying to access the Wine deb archives for about six hours now and Ive been receiving a "connection to the server was reset" error. I'm not sure how long this has been the case but can the maintainer of the archive please look into this failure? http://wine.budgetdedicated.com/archive/index.html Cheers, Tom -- http://www.wine-reviews.net/ http://bordeauxgroup.com/

4 3

DIB Engine - Separated in small patches
by Massimo Del Fedele 02 Feb '09

02 Feb '09

As requested I separated the engine in small patches, trying to keep original authors when possible. As the post didn't appear here (problem with zipped files, maybe ?), I've put it on bug 421 page. I whish to know if it can be ok for including on wine tree. Ciao Max

3 2

wine.budgetdedicated.com down?
by Dan Kegel 02 Feb '09

02 Feb '09

I can't download debian wine packages from wine.budgetdedicated.com today...

4 4

Re: [2/2] mshtml: Add support for IHTMLStyle4 interface
by Jacek Caban 02 Feb '09

02 Feb '09

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Add support for IHTMLStyle4 interface > --- dlls/mshtml/Makefile.in | 1 + dlls/mshtml/htmlstyle.c | 4 ++ dlls/mshtml/htmlstyle.h | 3 + dlls/mshtml/htmlstyle4.c | 135 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/tests/dom.c | 7 +++ 5 files changed, 150 insertions(+), 0 deletions(-) create mode 100644 dlls/mshtml/htmlstyle4.c This interface has very few methods so it doesn't … [View More]

1 0

Re: [1/2] mshtml: Add support for IHTMLStyle3 interface
by Jacek Caban 02 Feb '09

02 Feb '09

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Add support for IHTMLStyle3 interface > + + hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle3, (void**)&style3); + ok(hres == S_OK, "Could not get IHTMLStyle3 iface: %08x\n", hres); + if(SUCCEEDED(hres)) { + IHTMLStyle3_Release(style3); + } Please use style_iids to test QueryInterface calls. Jacek

1 0

Re: Anything wrong with this patch?
by Ben Klein 02 Feb '09

02 Feb '09

2009/1/24 Jérôme Gardou <jerome.gardou(a)gmail.com>: > Ben Klein a écrit : >> >> 2009/1/24 Jerome Leclanche <adys.wh(a)gmail.com>: >> >>> (Damnit, gmail interface) >>> Pipermail shows as empty, here. >>> >>> On Fri, Jan 23, 2009 at 10:05 PM, Jérôme Gardou <jerome.gardou(a)gmail.com> >>> wrote: >>> >>>> http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html >>>> … [View More]

3 7

Re: [2/2] mlang: Export a couple of functions by ordinal.
by Dmitry Timoshkov 02 Feb '09

02 Feb '09

"Hans Leidekker" <hans(a)codeweavers.com> wrote: > IE7 imports these and possibly others by ordinal. > > -Hans > > diff --git a/dlls/mlang/mlang.spec b/dlls/mlang/mlang.spec > index 1e8f022..689ad27 100644 > --- a/dlls/mlang/mlang.spec > +++ b/dlls/mlang/mlang.spec > @@ -1,14 +1,15 @@ > +112 stdcall ConvertINetUnicodeToMultiByte(ptr long ptr ptr ptr ptr) > +120 stdcall LcidToRfc1766A(long ptr long) > +121 stdcall LcidToRfc1766W(long ptr long) > + … [View More]

1 0

Re: BOOL WINAPI versus BOOL in d3dx9 and d3dx8
by Tony Wasserka 02 Feb '09

02 Feb '09

> Hi, > > the declaration of IntersectionTri is > BOOL IntersectionTri(.....) in d3dx8mesh.h and > BOOL WINAPI? IntersectionTri(.....) in d3dx9mesh.h . > > Is the latter one compatible with the former one (so I can forward d3dx9 function to the d3dx8 one) > or must I implement them separately? > > David It's already forwarded in d3dx9_36.spec to d3dx8, so you don't need to implement it twice. I was pretty careful when creating that specfile, i.e. it's in 99% … [View More]

2 1

wined3d and winex11 hand in hand...
by Jérôme Gardou 02 Feb '09

02 Feb '09

Quite oddly enough, wined3d and winex11 don't communicate with each other at all (well, wined3d uses WGL in gdi32, and gdi32 is based on winex11), and this leads to problems which are tricky to resolve... For instance, when a d3d application wants to disable screensavers, there is no way to do this through the windows api, but xlib provides XSetScreenSaver which is axactly what we need there. Would it be a good way to do this, as in user32 and gdi32, to create a driver structure holding … [View More]

2 2

performance issue when OffscreenRenderingMode = "pbuffer"
by Jérôme Gardou 02 Feb '09

02 Feb '09

I tried to play Supreme Commander using pbuffer option instead of fbo. I was quite happy with it, since I gained quite a bunch of performance (I mean, something I really COULD see), but after a while, the performance dropped dramatically, to ~4-5 fps. I tested quite a few thing, and I finally found that pixel bufers were not taken in account when calculating available texture memory. The game then allocated more textures, and good opengl didn't dare complain when putting them in system … [View More]

5 8

[RFC] Port of Stefan Dösinger's ARB_vertex_program fixed-function vertex pipeline replacement to 1.1.14
by Paul TBBle Hampson 01 Feb '09

01 Feb '09

From the discussion regarding the drawStridedSlow implementation of vertex blending, what shook out was the suggestion that WineD3D will need a vertex-program fixed function vertex pipeline at some point anyway, and therefore it doesn't make sense to add another software implementation to drawStridedSlow but to instead get the vertex pipeline in place and build the vertex blending functionality on top of that. Towards that aim, I've ported Stefan Dösinger's initial implementation of this from … [View More]October last year [1] to what turned out to be 1.1.14. It fails two more D3D9 tests than 1.1.14: visual.c:914: Test failed: Transformed vertex with linear vertex fog has color 0000ff00 visual.c:986: Test failed: Transformed vertex with linear vertex fog has color 0000ff00 (I don't know if these failed when it was first implemented, so I don't know if the problem is the patch, the port, or even the test. This is on my nVidia 8600 w/180.22 binary drivers, in case it makes a difference.) I haven't run it with any games yet, or profiled it. Stefan's commented since that it was slower than the current system, albeit unoptimised, and that was the reason he didn't undertake any further work on it. I don't know what games use the fixed-function pipeline, so I'm open to suggestions and bug report references. All but the last patch in this tarball are ports of Stefan's original, and were done using git-am so still retain his original headers. The sorta-nasty no_d3dcolor_swizzle code in get_color and its caller in the last patch is entirely my fault though. ^_^ The last patch is actually also from Stefan's code, but it's an attempt by me to reinsert fog code I have removed, possibly incorrectly. However, it didn't fix the above fog failures, so I left it as a separate patch. I'm not totally sure I've got all the hard parts of the port right. The two relevant changes since these patches were applied were the implementation of EXT_vertex_buffer_bgra and the rearrangement of the fog code. For EXT_vertex_array_bgra and vertex_pipe->can_convert_d3dcolor, I'm not sure if there are places that check one and should check the other, and I'm not sure if the test in state.c line 4280 (streamsrc) is doing the right thing. I think it is doing the right thing. The vertex program recognises and handles a position_transformed vertex declaration itself. Of the original 13-patch series, patches 4 and 5 were rendered completely uninteresting by the fog changes, and 7 and 13 had already gone into the main tree. There was also what I believe was a bug in patch 2, which basically left pCaps->MaxUserClipPlanes uninitialised rather than fetching the value from the vertex_pipeline's get_caps method result. Anyway, here it is. I hope this is of benefit to someone. The next thing I plan to do with this is try and wrap my head around the internals of the arbvp vertex program so I can implement vertex blending there. [1] http://www.mail-archive.com/wine-devel@winehq.org/msg49501.html -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.5/au/ ----------------------------------------------------------- [View Less]

2 1

[patch] review requested - NamedPipe Message mode (was Reliable Datagram / Stream behaviour of NT Pipes)
by Luke Kenneth Casson Leighton 01 Feb '09

01 Feb '09

http://bugs.winehq.org/attachment.cgi?id=19132 ok this is the beginnings of an implementation of messagemode, it passes the test1 and send2recv2 tests and fails the shortread test as part of PeekNamedPipe(). i'm not exactly sure why, yet. i get the distinct feeling that there's confusion over who writes into the wineserver data structures what the "availdata" is. msrpc.exe says "set availdata to 9", msrpcd.exe says "set it to 0, we did a write!" and it's all just ohhhh dear. also i have … [View More]

3 6

Fwd: A basic implementation for increased security in wine proposal
by Guillaume SH 01 Feb '09

01 Feb '09

---------- Forwarded message ---------- From: Guillaume SH <gsh.debianlists(a)gmail.com> Date: 2009/2/1 Subject: Re: A basic implementation for increased security in wine proposal To: Marcus Meissner <marcus(a)jet.franken.de> Hi Marcus, I stand corrected, as it appears I was way too naive in my understanding of software security, hence the example I provided. Regarding you explanation justifying there is no need to protect API against misuse, I am still not convinced, but I will … [View More]

2 1

Re: [PATCH] kernel32: handle section=NULL in WritePrivateProfileStructW (Coverity)
by Nikolay Sivov 01 Feb '09

01 Feb '09

Marcus Meissner wrote: > Hi, > > CID 69, section name NULL will just crash in the calls below and > without it we cannot work anyway. So return FALSE; > > Ciao, Marcus > --- > dlls/kernel32/profile.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index 3c5ef1c..5dddc23 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -1799,6 +1799,8 @@ BOOL … [View More]

1 0

Re: [PATCH] winspool.drv: Check return value of EnumPrintersA
by Detlef Riekenberg 01 Feb '09

01 Feb '09

On Sa, 2009-01-31 at 11:09 +0100, Marcus Meissner wrote: > - EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, > &num); > - if(needed) { > + if (EnumPrintersA(PRINTER_ENUM_LOCAL, NULL, 5, NULL, 0, &needed, > &num) && needed) { EnumPrinterA must always update "needed". "nedded" is 0, when EnumPrintersA failed or when no printer is installed. Line 1555 has similar code -- By by ... Detlef

2 1

A basic implementation for increased security in wine proposal
by Guillaume SH 01 Feb '09

01 Feb '09

Hi project, Following the two previous threads, I am posting here a draft patch implementing my proposal. So, to begin with I will remind you the principle : All function callable from outside wine, should be added sanity checks : if safe_mode_on and (sanity_check1_failed or sanity_check2_failed [...] ) { ExitWineCleanlyAndAdvertiseUser; } safe_mode_on value being read from registry (one and only time at wine startup). So if safe_mode_on is set to true, … [View More]sanity check are performed and in case of failure wine advertise user and terminate cleanly Else, sanity check aren't performed and on a bad input wine is crashing. I've only produced a basic implementation, clearly marking as TODO items left to be done (by the way they are too much for me to handle, as I am no match for you when it comes to implementation). My goal here is firstly to demonstrate feasibility (hardly reached) and usefulness of the proposal. Secondly it is to provide something concrete. Please note than "unsafe" mode behave exactly the same than latest git version of wine (some more operations occur, however, so is not strictly equal in term of performance) I tested the two modes with the help of wine test suite, restricted to kernel/file.c, test_overlapped and I considered only : all must-be-successful tests GetOverlappedResult(0, NULL, &result, FALSE); GetOverlappedResult(0, &ov, NULL, FALSE); (these last two cannot be used in the same run, in either mode) Results are as follow (test are wine_test calls wine on linux(1) platform only ) : 1 - all must-be-successful tests 100% succeed in the two modes 2 - in safe mode, the last two triggers the user message and wine exit 3 - in unsafe mode, the last two triggers a crash Consequently, based on theses results no regression is identified. As I received some more informations in last thread (thank you for enhancing my comprehension of the problem), I will again expose the problem, taking them into account : The problem I am considering (and I may be mistaken here as I am not an expert) is called "Unchecked Error Condition"(2) and it is a referenced weakness (CWE id 391), rated "Medium" in likelihood of exploit, by serious people. Personally, I don't mind that Microsoft is ignoring it and promote usage of early crash or whatever. You are providing a software, presenting security defects that you choose not to fix because they are compliant with your goals. Consequently, at the very least you should explicitly advertise your users, confronting them with their responsibilities. I have read(3) on winehq a warning stating that wine is beta software, not ready for general use. I have read too about the "bug for bug" compatibility. So user's advertisement about security is rather thin and implicit. Please consider the problem, you need to do something about it, it is your responsibility. And continue the good work, you rocks ! Guillaume (1) wine version : wine 1.1.14 with the attached patch applied on top of it OS : debian testing amd64 (2) http://cwe.mitre.org/data/definitions/391.html (3) http://www.winehq.org/about/ PS : I have observed that you are very active about fixing other security issues : + buffer overflow + NULL pointer dereference + variable signedness + ... I seems to me that hopefully, you performs those fixes without consideration for "Is windows doing the same ?". I will be sad the day I will see a commit "Remove resource release because Windows is doing the same" or "Remove buffer overflow fix because app A (2 million copies sold) rely on it". [View Less]

4 7

Re: dinput: Move gain support from effect to device
by Vitaliy Margolen 01 Feb '09

01 Feb '09

Vincent Pelletier wrote: > Hi. > > Windows supports setting force feedback effect gain at 2 levels: > - device > - effect > There is support for the former on Linux, but not for the latter. > > > + DWORD ff_gain; > }; ... > + This->ff_gain = max(0, (int) pd->dwData); First why do you typecase DWORD to (int) to assign to DWORD? Second DWORD will always be > 0. If you want to check it against limit then just check it being <= 10000 … [View More]

2 1

Wine magazine articles?
by Dan Kegel 01 Feb '09

01 Feb '09

Hey everyone, does Wine have a gallery of press clippings anywhere? I couldn't find one, so I started one at http://wiki.winehq.org/Reviews just for long-form reviews. If you remember any good reviews of Wine (1.0 or later especially), please link them in there. - Dan

1 0

Fw : BOOL WINAPI versus BOOL in d3dx9 and d3dx8
by paulo lesgaz 31 Jan '09

31 Jan '09

Hi, the declaration of IntersectionTri is BOOL IntersectionTri(.....) in d3dx8mesh.h and BOOL WINAPI IntersectionTri(.....) in d3dx9mesh.h . Is the latter one compatible with the former one (so I can forward d3dx9 function to the d3dx8 one) or must I implement them separately? David

1 0

Running the fusion tests
by Paul Vriens 31 Jan '09

31 Jan '09

Hi, I didn't look into this yet but currently the fusion tests are only run on Wine. I can happily run the fusion tests on my XP box if I just crossbuild these tests. It's only when run through winetest that these tests are not run. I guess it has to do with how this library should be loaded (not directly through LoadLibrary)? -- Cheers, Paul.

1 0

Reliable Datagram / Stream behaviour of NT Pipes
by Luke Kenneth Casson Leighton 31 Jan '09

31 Jan '09

folks, hi, if you recall, i implemented nt named pipes in samba tng, and also implemented the use of nt named pipes as a transport in freedce, for when i ported freedce to win32. so i have quite a bit of experience when it comes to nt named pipes. i've encountered some bugs (thanks to python again :) ) in the wine implementation of nt named pipes, and have raised it as a bug http://bugs.winehq.org/show_bug.cgi?id=17195 but it started getting complicated so i thought i'd best raise it here. the … [View More]behaviour of nt named pipes is a cross between datagrams and streams - it's the best of both worlds: * absolute inviolate message sizes (datagrams) * absolute inviolate message order (streams). the issue with the implementation of nt named pipes on top of _just_ streams (unix sockets) is this: two packets sent get blatted into one read. you _cannot_ allow this to happen - it screws applications up _royally_, as applications _critically_ depend on the number of reads and writes being interleaved, thanks to the characteristics of NamedPipes. standard unix applications / protocols (SMTP, etc) have no choice but to do manual synchronisation built-in to the protocol, because standard unix streams don't _have_ this "free feature". so, in samba tng, the emulated-implementation of nt named pipes (on top of unix sockets) i was forced to send a (32-bit) length field actually _in_ the data stream, just like is done in NetBIOS. the NetBIOS protocol (which was implemented by IBM, not microsoft) sends a 16-bit length field followed by that exact number of bytes. again, NetBIOS implements a "reliable datagram-stream" protocol on top of standard unix streams (tcp stream, this time) inexplicably, unix simply... is ... entirely... missing this concept. so, i'm sorry to have to tell you this, but you are absolutely forced to emulate it (by sending length, data, length data), just like everyone else ever has. so, send (write) is simple: write out the length field, write out the data. done. dead simple. read is... tricky. you _may_ have to keep track of having read the length, already. or, of how _much_ has been read already, of the "current packet being read". .... *walks through source code a bit...* ... i'm veery tempted to say "can i have a go at implementing this?" but... i know it'll be ... how-to-say... eeenteresting :) should i try? would an extra server message need to be added (for read), so that the server can keep track of how much data has been read back (of the current datagram)? l. [View Less]

2 3

New Coverity run
by Paul Vriens 31 Jan '09

31 Jan '09

Hi, I've been in touch with David Maxwell and he looked into the 'lack' of reports since the end of October. -- Cheers, Paul.

2 2

Re: gdi32: Remove unneeded check. (Coverity)
by Rob Shearman 31 Jan '09

31 Jan '09

2009/1/27 Kai Blin <kai.blin(a)gmail.com>: > > lcdfilter = FT_LCD_FILTER_DEFAULT is hardcoded, so the check is always true. > > This fixes Coverity CID 816 > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 1ca6953..dfbcf2f 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -4783,18 +4783,15 @@ DWORD WineEngGetGlyphOutline(GdiFont *incoming_font, UINT glyph, UINT format, > (format == … [View More]

3 2

Re: msadp32.acm : block align and adpcm extra data
by Vincent Pelletier 30 Jan '09

30 Jan '09

Le Thursday 22 January 2009 16:25:42 Stefano Guidoni, vous avez écrit : > This patch solves bug 7385: > Function ADPCM_StreamSize must return a > buffer size, which is a multiple of block align. > This buffer size is > calculated taking into account input-blockalign, output-blockalign and > adpcm-samplesperblock. Hi. Excuse me for contacting you directly, but that patch didn't enter the source tree, because of the "while" loops. I've been trying for hours to guess by … [View More]

1 0

request for windows test: GetPrivateProfileSectionNamesA
by Marcus Meissner 30 Jan '09

30 Jan '09

Hi, Could someone please test those, I want to see if the second or third crash on Windows to handle those borderline cases. Ciao & Thanks, Marcus --- dlls/kernel32/tests/profile.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c index 5292c33..feeb7b2 100644 --- a/dlls/kernel32/tests/profile.c +++ b/dlls/kernel32/tests/profile.c @@ -214,6 +214,13 @@ static void test_profile_sections_names(void)… [View More]

2 1

Re: [2/13]msctf: implement SetFocus and GetFocus
by Jacek Caban 30 Jan '09

30 Jan '09

Hi Aric, Aric Stewart wrote: > --- > dlls/msctf/threadmgr.c | 28 ++++++++++++++++++++++++---- > 1 files changed, 24 insertions(+), 4 deletions(-) > + if (!pdimFocus || FAILED(IUnknown_QueryInterface(pdimFocus,&IID_ITfDocumentMgr,(LPVOID*) &check))) + return E_INVALIDARG; + + This->focus = check; Shouldn't This->focus be released if it's already set? Jacek

2 1

Highest commits per month (ever)
by Paul Vriens 30 Jan '09

30 Jan '09

Hi, This month we hit the highest number of commits per month ever : 1307. It's a shame there is weekend coming ;) -- Cheers, Paul.

1 1

DIB Engine - Rebased on wine-1.1.14
by Massimo Del Fedele 30 Jan '09

30 Jan '09

As before, separated in 2 patches. Ciao Max

1 0

SHGetFileInfo flag SHGFI_USEFILEATTRIBUTES together with SHGFI_PIDL (regression)
by Petr Sumbera 30 Jan '09

30 Jan '09

Hi All, What is story behind following commit? This seems to broke Zoner Photo Studio (tested on OpenSolaris). According to some documentation combination of these flags is not allowed.. http://source.winehq.org/git/wine.git/?a=blobdiff;f=dlls/shell32/shell32_ma… --- a/dlls/shell32/shell32_main.c +++ b/dlls/shell32/shell32_main.c @@ -350,10 +350,6 @@ DWORD_PTR WINAPI SHGetFileInfoW(LPCWSTR path,DWORD dwFileAttributes, (flags & SHGFI_PIDL)? "pidl" : debugstr_w(path), … [View More]

1 0

Re: comctl32: Fix propsheet size calculation (resent)
by Alexandre Julliard 30 Jan '09

30 Jan '09

Vitaliy <vitaliy(a)kievinfo.com> writes: > + /* Get non-client size */ > + if (!psInfo->isModeless) > + { > + RECT rc1; > + > + GetWindowRect(hwndDlg, &rc); > + GetClientRect(hwndDlg, &rc1); > + tabOffsetX = rc.right - rc.left - (rc1.right - rc.left); > + tabOffsetY = rc.bottom - rc.top - (rc1.bottom - rc.top); That doesn't make sense. What are you trying to compute here? -- Alexandre Julliard julliard(a)winehq.org

2 3

DIB Engine - Rebased on current tree (Takes 2) - Part 2 - winedib.drv initial implementation
by Massimo Del Fedele 30 Jan '09

30 Jan '09

Here part 2. Ciao Max

1 0

DIB Engine - Rebased on current tree (Takes 2) - Part one - GDI32 patches
by Massimo Del Fedele 30 Jan '09

30 Jan '09

As there where some changes on GDI32 in latest commits, previous testing DIB Engine had to be modified too. I'm posting here (and in bug 421 page) the 2 needed patches, separated by GDI32 changes and winedib.drv folder. In order to keep patches smaller, I dropped the autogenerated 'configure', but leaving 'configure.ac'.... I guess this is the correct way, probably an autoconf is needed to regenerate the configure file. I was asked to separate the commits from Huw Davies, Jesse Allen and … [View More]

1 0

Re: gdiplus: GdipCreateBitmapFromHICON implemented (with some tests)
by Alexandre Julliard 30 Jan '09

30 Jan '09

Nikolay Sivov <bunglehead(a)gmail.com> writes: > @@ -4,7 +4,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = gdiplus.dll > IMPORTLIB = gdiplus > -IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32 > +IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32 shell32 It's a bit wasteful to import shell32 just to copy an icon. -- Alexandre Julliard julliard(a)winehq.org

2 1

Wined3d being used with VirtualBox D3D
by Zachary Goldberg 30 Jan '09

30 Jan '09

All, An interesting piece from Phoronix about new VirtualBox Direct3D support; which apparently uses WineD3D in the backend. I haven't noticed anything in particular but has Sun been filing bugs / sending patches? http://www.phoronix.com/scan.php?page=news_item&px=NzAyNA --Zach

3 2

Another MSVCRT problem, perhaps __RTDynamicCast()
by Uwe Bonnes 30 Jan '09

30 Jan '09

Hello, after registering at http://forms.analog.com/form_pages/rfcomms/adisimpll.asp?ref=ASC-PR-067 you can download ADIsimPLL Version 3.1 for free. Running the program (with richedit from winetricks) it offers to run a tutorial. In the course of clicking next in this tutorial, at some point some form gets filled with \ nonsense double values. This doesn't happen with native msvcrt. I have instrumented msvcrt._ecvt() to print out the number. The number printed is the nonsens number in the … [View More]form. Appended +relay,+msvcrt looks fishy: 0023:Call msvcrt.__RTDynamicCast(006f7a58,00000000,00543030,00544838,00000000) ret=0044019e trace:msvcrt:MSVCRT___RTDynamicCast obj: 0x6f7a58 unknown: 0 src: 0x543030 {vtable=0x521568 name=.?AVYASymbol@@ ()} dst: 0x544838 {vtable=0x521568 name=.?AVLibDouble@@ ()} do_throw: 0) trace:msvcrt:dump_obj_locator 0x524218: sig=00000000 base_offset=00000000 flags=00000000 type=0x544838 {vtable=0x521568 name=.?AVLibDouble@@ ()} hierarchy=0x524208 trace:msvcrt:dump_obj_locator hierarchy: sig=00000000 attr=00000000 len=3 base classes=0x5241f8 trace:msvcrt:dump_obj_locator base class 0x5241e0: num 2 off 0,-1,0 attr 00000000 type 0x544838 {vtable=0x521568 name=.?AVLibDouble@@ ()} trace:msvcrt:dump_obj_locator base class 0x524190: num 1 off 0,-1,0 attr 00000000 type 0x544818 {vtable=0x521568 name=.?AVLibVariable@@ ()} trace:msvcrt:dump_obj_locator base class 0x5234d8: num 0 off 0,-1,0 attr 00000000 type 0x543030 {vtable=0x521568 name=.?AVYASymbol@@ ()} 0023:Ret msvcrt.__RTDynamicCast() retval=006f7a58 ret=0044019e 0023:Call msvcrt._ecvt(00000001,5f40255f,0000000a,00328dd4,00328ddc) ret=0040a952 0023:Call KERNEL32.TlsGetValue(00000000) ret=7ec3e471 0023:Ret KERNEL32.TlsGetValue() retval=001b0678 ret=7ec3e471 trace:msvcrt:_ecvt num 6606512752554031389059083466263841847175093544956949844249843220093860018640324866\ 420498348423671822060046924282328257865959227190774155226910868635648.000000, digits 10 0023:Call ntdll.RtlAllocateHeap(00110000,00000000,00000050) ret=7ec2de07 0023:Ret ntdll.RtlAllocateHeap() retval=006e4550 ret=7ec2de07 0023:Ret msvcrt._ecvt() retval=006e4550 ret=0040a952 I suspect __RTDynamicCast() to cause the error. Having not much C++ understanding, I don't feel like writing a sensible testcase. Can anybody perhaps have a look? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- [View Less]

1 0

report on obscure issues: running out of file handles with python under wine
by Luke Kenneth Casson Leighton 30 Jan '09

30 Jan '09

hiya folks, well the saga continues with using python under wine - i thought i'd let you know the analysis and clues so far, in case it rings any bells with anyone, now or in the future. as you're probably aware, there's a limit in nt of 2048 file descriptors which has caused a large number of free software projects quite a lot of grief , e.g. this: http://bugs.mysql.com/bug.php?id=24509. it turns out that python is no different, and i'm just in the process of investigating whether compiling … [View More]

4 5

Re: D3D: Implement vertex blending in drawStridedSlow
by Henri Verbeet 30 Jan '09

30 Jan '09

2009/1/25 Claudio Ciccani <klan(a)users.sf.net>: > > + WORD vertexBlendSW : 1; /* vertexBlend software fallback used */ I'm not sure we want to implement vertex blending in software in the first place (rather than through a shader), but you can't just add a bitfield here without changing the padding.

3 9

First complete test run passing on a Windows platform
by Reece Dunn 30 Jan '09

30 Jan '09

Hi, The Wine tests are now passing on a Windows XP machine (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group…). Two of the other four only have 2 or 3 failures. The 2003 group has 3 machines with 1 failure each (urlmon:protocol on one, user32:menu on the others). Congratulations to everyone involved fixing the tests! - Reece

2 1

re: First complete test run passing on a Windows platform
by Dan Kegel 30 Jan '09

30 Jan '09

Wow, that's awesome! A day seven years in the making... 2002: the C test suite is started: http://source.winehq.org/git/wine.git/?a=commit;h=caa03388bcccc64f444f9b4ef… 2003: winetest committed: http://www.winehq.org/wwn/199#Winetest%20Integrated%20&%20Future%20Steps 2004: server to build winetest and parse winetest results set up http://www.winehq.org/wwn/216#A%20Distributed%20Test%20Environment 2009: the test suite passes for somebody besides Alexandre on Wine: http://www.winehq.… [View More]

2 1

A proposal for increased security in wine - respecting previously expressed needs
by Guillaume SH 29 Jan '09

29 Jan '09

Hi wine community, I took some time for reflexion following the thread "A step in the wrong direction, in an ocean of steps in the right direction" and to the explanations some of you kindly exposed to me. As a follow-up I am making a proposal. A - The proposal A1 - The core proposal All function callable from outside wine should implement, as the first task they perform(1), a sanity parameter check. This check hasn't to be systematic, only really used parameters should be … [View More]checked and only checks assuring those parameters can be safely used the way they are in the function implementation (or in a function called by it). Other check are superfluous and must be discarded. So to decline the proposal operationally, I will take an example(2) : BOOL WINAPI GetOverlappedResult(HANDLE hFile, LPOVERLAPPED lpOverlapped, [...]) if ( lpOverlapped == NULL ) { #Call the function ExitWineCleanlyAndAdvertiseUser } This call being justified by the statement, following some lines later : status = lpOverlapped->Internal; The function ExitWineCleanlyAndAdvertiseUser being something like that : <Result to be determined> ExitWineCleanlyAndAdvertiseUser <Parameters to be determined> #1 - Advertise user outputting a message, for example : "The application you used present a defect. Using it directly expose you to some security issue and indirectly expose others users to some other security issue." #2 - Cleanly release all still allocated resources #3 - Cleanly exit wine A2 - offering flexibility As I have understood that wine community is willing to be able to run all applications written for a Windows platform, even those relying on the worse behaviours of windows, I will propose too to add a registry key for the purpose of enabling / disabling wine "safe" mode. In this case it would make sense that "safe" mode is the default, with possibility to fall-back to "unsafe" mode when needed. B - Advantages / Drawbacks to the proposal Drawback of this solution I can think of are : 1 - It is contrary to the current consensus 2 - It implies a lot of work (even if this can be done bit by bit over a long period time, direction is what matters here) 3 - Detailed implementation of what I presented may very well not be as simple as I imagine, or even impossible 4 - Maybe all the reasons have not been expressed in the previous thread, thus not considered here 5 - It can go against the interest of the author of those apps relying on Windows's bad behaviors (large firms for example) 6 - It doesn't cover all security issue in wine and it doesn't cover at all security issue in the calling app 7 - Performance drop-down may be expected (0,01%, 0,1%, 1%, more ? I don't know how to evaluate) Advantage of this solution I can think of are : 1 - Top-notch level of service to user : I can be informed when I use an unsafe software ! 2 - Encouragement to software industry : I must provide some clean and safe software or wine can judge me "unsafe" (=promoting "best-practices") 3 - Wine is better from it, so people will have a better opinion of wine 4 - Goal reached by wine are far beyond "Windows behaviours on free-OS platform" 5 - Wine is safer so more people will want to use it and to promote its usage I think I will go no further than this proposal, so I leave the rest to you, from simply ignoring it to demonstrate me than I'm wrong or applying a variation, Guillaume (1) TRACE, variable declaration or other task may come before though (2) Please don't argue about the coding style, I am not a technical expert (unlike you) and it would be off-topic [View Less]

6 5

Re: [1/3] d3dxof: Make parsing more permissive about semicolon and comma in objects
by Paul Vriens 29 Jan '09

29 Jan '09

Christian Costa wrote: > > > ------------------------------------------------------------------------ > > Hi Christian, + if ((token != TOKEN_SEMICOLON) && (token != TOKEN_COMMA)) { /* Allow comma instead of semicolon in some specific cases */ if (!((token == TOKEN_COMMA) && ((i+1) < pt->nb_members) && (pt->members[i].type == pt->members[i+1].type) This introduced a DEADCODE warning in Coverity. The code … [View More]

2 1

Today's git installation error...
by Susan Cragin 29 Jan '09

29 Jan '09

When I installed DNS10 today, the included Visual C++ 8.0 runtime does not load, with the following message. fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f80c (nil) 0x33f810 0x33f804 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x131958 0x33f80c 0x132430 0x33f810 0x33f804 - stub ALSA lib pcm_dmix.c:1008:(snd_pcm_dmix_open) unable to open slave fixme:reg:GetNativeSystemInfo (0x7e1487b4) using GetSystemInfo() wine: Unhandled page fault on write access to 0x7de61520 at … [View More]

2 1

Re: wininet: Implement IsDomainLegalCookieDomainW.
by Juan Lang 29 Jan '09

29 Jan '09

Hi Hans, minor point: + FIXME("(%s, %s)\n", debugstr_w(s1), debugstr_w(s2)); Shouldn't that be TRACE? --Juan

2 3

Re: Ge van Geldorp : ole32/tests: Some Windows versions need the class to be registered.
by Rob Shearman 29 Jan '09

29 Jan '09

2009/1/26 Alexandre Julliard <julliard(a)winehq.org>: > hr = StringFromCLSID(&CLSID_WineTest, &pszClsid); > ok_ole_success(hr, "StringFromCLSID"); > - strcpy(buffer, "CLSID\\"); > + strcpy(buffer, "Software\\Classes\\CLSID\\"); > WideCharToMultiByte(CP_ACP, 0, pszClsid, -1, buffer + strlen(buffer), sizeof(buffer) - strlen(buffer), NULL, NULL); > CoTaskMemFree(pszClsid); > strcat(buffer, "\\InprocHandler32"); > - error = … [View More]

2 1

Wine gecko: javascript in the frame
by Konstantin Kondratyuk 29 Jan '09

29 Jan '09

Hi! Javascript which is defined in the frame doesn't work. There is a test in attachement. Run index.html in 'wine iexplore' Correct events for this test (checked up in IE and Firefox): 1. "call f_right script" message 2. "call onLoad" message during loading 3. "call myOnClick" message after click to link Wine gecko ignores all these events. Do you have any advice? Thanks. -- Best regards, Konstantin Kondratyuk.

2 1

Re: advapi32: Fix potential NULL pointer dereference in RegSetValueExA [with test] (Saturn)
by Rob Shearman 29 Jan '09

29 Jan '09

2009/1/26 Aurimas Fišeras <aurimas(a)gmail.com>: > Saturn's error report: > (INCONSISTENT USE) Possible null dereference of variable data+(count-1). > This variable is checked for Null at lines: registry.c:1051 > > Tested on Windows XP > > Changelog: > advapi32: Fix potential NULL pointer dereference in RegSetValueExA > [with test] (Saturn) Excellent, this tool has spotted a corner-case that the code doesn't handle correctly. > From … [View More]

3 9

Bug in INT32_FindNext blocking Winbench '96?
by Dan Kegel 29 Jan '09

29 Jan '09

http://bugs.winehq.org/show_bug.cgi?id=17181 seems to be a bug in our implementation of DOS FindNext. It's one of the bugs blocking Winbench 96 from running. I'm interested in Winbench 96 simply because it's the only mainstream magazine system benchmark for Windows I've ever even remotely gotten to run on Wine. And bless its soul, it carefully checks return values from DOS system calls. I've already sent in a patch for one problem, but would appreciate some help with this FindNext issue. The … [View More]

1 0

Worldbench?
by Dan Kegel 29 Jan '09

29 Jan '09

It's hard to keep the benchmark programs straight. I ran into one called Worldbench today in this review http://www.washingtonpost.com/wp-dyn/content/article/2009/01/27/AR200901270… and I see it's used quite a bit: http://www.networkworld.com/reviews/2008/102908-hps-mini-1000-a-new.html It would be nice if we didn't see reviews like this: http://www.pcworld.com/article/142724/200_linux_desktop_systems_are_no_barg… which say "Because these PCs run Linux, not Windows, we couldn't run our … [View More]

2 2

Should winetest retrieve msi log file on msi test failures?
by Dan Kegel 28 Jan '09

28 Jan '09

Looking at test.winehq.org's XP results, it seems we're doing quite well; some of the remaining failures seem to be unusual situations. For instance: msi:msi.c is passing flawlessly on 7 out of 10 computers, and on one of the computers, it has just one failure: http://test.winehq.org/data/8f829034f3fe4da3e7adce2f4685e10ba2e2fe82/xp_fg-… says dlls/msi/tests/msi.c msi.c:254: Test failed: wrong error 1618 1618 is ERROR_INSTALL_ALREADY_RUNNING. Say, can winetest retrieve and display the msi log … [View More]

2 3

Re: Implement BiDi mirroring
by Juan Lang 28 Jan '09

28 Jan '09

Hi Khaled, +void doMirror(WCHAR* ch) This should be static. + else if(*ch == mirrored[k].first) + { + *ch = mirrored[k].mirror; + return; + } The else if block is indented one level too many. Thanks, --Juan

2 2

Consistency in programs/winecfg/drivedetect.c
by Ben Klein 28 Jan '09

28 Jan '09

I just noticed my first patch got accepted, yay :) commit 8df74a0edb3304dfc26bd524327f9128f63de47f Author: Ben Klein <shacklein(a)gmail.com> Date: Wed Jan 21 21:02:12 2009 +1100 winecfg: Fix a typo in autodetect_drives. I also noticed someone removed the superfluous () around the expression in my patch. I included this for consistency in the file, and note that the same superfluous () appears on lines 244 and 272 in drivedetect.c in current git HEAD. Since this is not a … [View More]

1 0

Re: server: Use kernel support for process affinity when available (try 2)
by Alexandre Julliard 28 Jan '09

28 Jan '09

Juan Lang <juan.lang(a)gmail.com> writes: > Is this better? This trades a single call to sched_getaffinity per > process to one every time the process affinity is queried. This seems > safer, since a non-Wine process can also change a process's affinity, > but it can have higher overhead. Yes, that's better. But AFAICT sched_get/setaffinity applies to a single thread, not to the whole process. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [twain_32 2/7] Add an interactive set of tests for a selected scanner.
by Jeremy White 28 Jan '09

28 Jan '09

> + rc = pDSM_Entry(appid, source, DG_CONTROL, DAT_CAPABILITY, MSG_GET, > &cap); Bletch. Forgot to add --attach. I'll resend the series. Sorry :-/. Cheers, Jeremy

1 0

Re: setupapi: implement pSetupInstallCatalog
by Alexandre Julliard 28 Jan '09

28 Jan '09

Aric Stewart <aric(a)codeweavers.com> writes: > + if (!CryptCATAdminAcquireContext(&admin,NULL,0)) > + { > + ERR("Could not acquire security context\n"); > + return ERROR_GEN_FAILURE; > + } > + if (!(cat = CryptCATAdminAddCatalog(admin,catalog,basename,0))) > + { > + ERR("Could not add catalog\n"); > + CryptCATAdminReleaseContext(admin, 0); > + return ERROR_GEN_FAILURE; You should return proper error … [View More]

1 0

Re: [1/2]reg.exe: Implement ADD for REG_SZ
by Alexandre Julliard 28 Jan '09

28 Jan '09

Aric Stewart <aric(a)codeweavers.com> writes: > + if (key_name[0]=='\\' && key_name[1]=='\\') > + { > + static const WCHAR remoteW[] = {'U','n','a','b','l','e',' ','t','o',' ','a','d','d',' ','k','e','y','s',' ','t','o',' ','r','e','m','o','t','e',' ','m','a','c','h','i','n','e',' ','%','s','\n',0}; This should go in the resources like the other messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw: OnAmbientPropertyChange should refresh all properties with a DISPID_UNKNOWN
by Jacek Caban 28 Jan '09

28 Jan '09

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > shdocvw: OnAmbientPropertyChange should refresh all properties > with a DISPID_UNKNOWN It would be better to add test for it so we know which properties should we refresh (even if most of them would be todo_wine ATM). Thanks, Jacek

1 0

Updated DIB Engine
by Massimo Del Fedele 28 Jan '09

28 Jan '09

Here some news on my DIB Engine : Corrected some small bugs in text handling (still VERY poor) Corrected a couple of crashes Added code to enable/disable by environment or registry Made optionals all engine stubs FIXMEs (speeds up a lot....) The engine is disabled by default; can be changed by environment variable : export WINEDIB=ON (or ENABLE or ENABLED or TRUE) enables it export WINEDIB=OFF (or DISABLE or DISABLED or FALSE) disables it or by registry key : HKCU/Software/Wine/DIB … [View More]

7 16

Re: DNS10 goes 12 minutes rather than 10 before crashing.
by Susan Cragin 28 Jan '09

28 Jan '09

>> As you may know, Dragon NaturallySpeaking 10 crashes on use with predictable regularity. >> Used to be every 10 minutes. >> However, yesterday (and today) that creeped up to 12 minutes. >> It could be due to anything, but I thought one of you might say EUREKA!! it's the foobar.c part of oleacc!! or something like that. >> If not, have a good day. >> Susan > >Hi Susan, > >Is there a demo for DNS 10 and do you need to do anything special for >… [View More]

1 0

DNS10 goes 12 minutes rather than 10 before crashing.
by Susan Cragin 27 Jan '09

27 Jan '09

As you may know, Dragon NaturallySpeaking 10 crashes on use with predictable regularity. Used to be every 10 minutes. However, yesterday (and today) that creeped up to 12 minutes. It could be due to anything, but I thought one of you might say EUREKA!! it's the foobar.c part of oleacc!! or something like that. If not, have a good day. Susan

2 1

Re: include(1/1): Define flags used by CryptUIWizExport
by Alexandre Julliard 27 Jan '09

27 Jan '09

Juan Lang <juan.lang(a)gmail.com> writes: > @@ -297,6 +297,12 @@ typedef struct _CRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO > typedef const CRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO * > PCCRYPTUI_WIZ_EXPORT_CERTCONTEXT_INFO; > > +/* Values for CryptUIWizExport's dwFlags */ > +#define CRYPTUI_WIZ_IGNORE_NO_UI_FLAGS_FOR_CSPS 0x00000002 > +#define CRYPTUI_WIZ_NO_UI_EXCEPT_CSP 0x00000003 > +#define CRYPTUI_WIZ_EXPORT_PRIVATE_KEY 0x00000100 > +#define … [View More]

2 1

Wine menu creation questions
by Reece Dunn 27 Jan '09

27 Jan '09

Hi, I have noticed that when wine creates a menu item (that for example, on Ubuntu gets put in the Applications > Wine > Programs menu), the command that gets written uses 'wine' as the program to run. This means that you need to have Wine in your PATH and cannot use more than one version of Wine. For example, if I wanted to use /opt/wine-1.0, /opt/crossover and /opt/wine for different applications I cannot access these correctly from the menu items created. Additionally, the user … [View More]

6 7

Re: comctl32: Fix propsheet size calculation
by Vitaliy Margolen 27 Jan '09

27 Jan '09

Vitaliy Margolen wrote: > Size of tabs has nothing to do with the size of a window title. > Fixes bug 8522. > --- > dlls/comctl32/propsheet.c | 17 ++++++++++++++--- > 1 files changed, 14 insertions(+), 3 deletions(-) > Was there anything wrong with this patch? Adding tests for this won't work all that well - size of non-client varies from distro to distro to WM to user settings. Vitaliy

1 0

Re: [PATCH] d3d9: initialize hr (coverity)
by Alexandre Julliard 27 Jan '09

27 Jan '09

Marcus Meissner <marcus(a)jet.franken.de> writes: > Spotted in CID 864 that hr is used uninitialized > in a codepath. Using S_OK as default return. Is S_OK really appropriate here? A test case is probably in order. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32[1/2]: toolbar: Str_SetPtr* assumes the destination pointer points to allocated memory or is NULL
by Alexandre Julliard 27 Jan '09

27 Jan '09

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > @@ -2924,6 +2925,7 @@ TOOLBAR_AddStringW (HWND hwnd, WPARAM wParam, LPARAM lParam) > } > > infoPtr->strings = ReAlloc(infoPtr->strings, sizeof(LPWSTR)*(infoPtr->nNumStrings+1)); > + infoPtr->strings[infoPtr->nNumStrings] = NULL; > Str_SetPtrW(&infoPtr->strings[infoPtr->nNumStrings], p); > infoPtr->nNumStrings++; > > @@… [View More]

1 0

Could someone test this wineinet:http fix on an XP or 2003 box without IE7
by Reece Dunn 27 Jan '09

27 Jan '09

Hopefully, we will then get a clean test run on some XP boxes and have several more 2003 boxes with 1 test failure :). Thanks, - Reece

4 4

Re: shell32: Fix SHFileOperation on empty destination (FO_COPY)
by James Hawkins 27 Jan '09

27 Jan '09

On Tue, Jan 27, 2009 at 3:20 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > http://bugs.winehq.org/show_bug.cgi?id=13394 > > Changelog: > - on FO_COPY and empty destination SHFileOperation should use > current directory > > >From 1684fd3c0d47fce3fcff31d316ec7b18291cd5af Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Tue, 27 Jan 2009 12:17:42 +0300 > Subject: Fix SHFileOperation on empty destination (… [View More]FO_COPY) > > --- > dlls/shell32/shlfileop.c | 8 ++++++++ > dlls/shell32/tests/shlfileop.c | 14 ++++++++++++++ > 2 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c > index ec7ba54..78b7352 100644 > --- a/dlls/shell32/shlfileop.c > +++ b/dlls/shell32/shlfileop.c > @@ -1498,6 +1498,7 @@ int WINAPI SHFileOperationW(LPSHFILEOPSTRUCTW lpFileOp) > FILE_OPERATION op; > FILE_LIST flFrom, flTo; > int ret = 0; > + WCHAR currd[MAX_PATH]; > > if (!lpFileOp) > return ERROR_INVALID_PARAMETER; > @@ -1510,6 +1511,13 @@ int WINAPI SHFileOperationW(LPSHFILEOPSTRUCTW lpFileOp) > if ((ret = parse_file_list(&flFrom, lpFileOp->pFrom))) > return ret; > > + if ((lpFileOp->wFunc == FO_COPY) && > + (lpFileOp->pTo[0] == 0)) > + { > + GetCurrentDirectoryW(MAX_PATH, currd); > + parse_file_list(&flTo, currd); > + } > + else > if (lpFileOp->wFunc != FO_DELETE) > parse_file_list(&flTo, lpFileOp->pTo); > Style is wrong. Should be 'else if' all on one line. Regardless, this functionality should be in copy_files, not SHFileOperationW. > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > index 433a131..3c85ecd 100644 > --- a/dlls/shell32/tests/shlfileop.c > +++ b/dlls/shell32/tests/shlfileop.c > @@ -1673,6 +1673,20 @@ static void test_copy(void) > ok(DeleteFileA("ab.txt"), "Expected file to exist\n"); > ok(RemoveDirectoryA("one"), "Expected dir to exist\n"); > ok(RemoveDirectoryA("two"), "Expected dir to exist\n"); > + > + /* pFrom contains a name larger than 8.3, pTo is an empty string */ > + CreateDirectoryA("one", NULL); > + createTestFile("one\\abcdefghi.abc"); > + shfo.pFrom = "one\\abcdefghi.abc\0"; > + shfo.pTo = "\0"; > + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI | FOF_FILESONLY | > + FOF_NOCONFIRMMKDIR; > + > + retval = SHFileOperationA(&shfo); > + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); > + ok(DeleteFileA("abcdefghi.abc"), "Expected file to exist\n"); > + ok(DeleteFileA("one\\abcdefghi.abc"), "Expected file to exist\n"); > + ok(RemoveDirectoryA("one"), "Expected dir to exist\n"); > } > > /* tests the FO_MOVE action */ > -- > 1.5.6.5 > > > > > > -- James Hawkins [View Less]

1 0

Is there a way to set Z:\ as the whatever user's home folder?
by Scott Ritchie 27 Jan '09

27 Jan '09

I want to have a read-only wine prefix that multiple users might access, however I also want to have a Z:\ drive that refers to a dynamic location - a folder inside the current user's home folder. This isn't possible as far as I can tell, as Wine requires a symlink to the folder in the prefix's dosdevices directory, and a symlink can only point to a static file. Assuming this is possible, are there any downsides to using this read-only prefix? Assume for a moment that the application doesn'… [View More]

2 1

Re: [PATCH] wineps.drv: Add a simple implementation of PSDRV_SelectBitmap.
by Alexandre Julliard 27 Jan '09

27 Jan '09

Lei Zhang <thestig(a)google.com> writes: > Hi, > > This fixes bug 17103 for me. I'm not sure if PSDRV_SelectBitmap() need > to do more, but this is a start and it's better than a stub. If it doesn't do more, then removing it completely should work just as well. There doesn't seem to be much point in just storing the bitmap, this is easy to retrieve when needed. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: Implement QueryFontAssocStatus
by ricardo_barbano＠hotmail.com 27 Jan '09

27 Jan '09

i don't know what might be wrong, but in case noone answers you: maybe divide this in much smaller patches? this way you can easily pinpoint areas where the problem is, because the patch is quite big. or you could try pinging julliard by mail or on IRC... regards, ricardo -------------------------------------------------- From: "Byeongsik Jeon" <bsjeon(a)hanmail.net> Sent: Monday, January 26, 2009 11:33 PM To: <wine-devel(a)winehq.org> Subject: Re: gdi32: Implement … [View More]

1 0

Re: [PATCH] ddrawex: use stack ctx instead of uninitialized variable
by Austin English 27 Jan '09

27 Jan '09

On Mon, Jan 26, 2009 at 11:06 AM, Marcus Meissner <meissner(a)suse.de> wrote: > --- > dlls/ddrawex/ddraw.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/ddrawex/ddraw.c b/dlls/ddrawex/ddraw.c > index b581529..6607c78 100644 > --- a/dlls/ddrawex/ddraw.c > +++ b/dlls/ddrawex/ddraw.c > @@ -678,11 +678,11 @@ IDirectDraw4Impl_EnumSurfaces(IDirectDraw4 *iface, > LPDDENUMSURFACESCALLBACK2 … [View More]

1 0

Re: [REGRESSION] Fix dlls/iphlpapi/ipstats.c on FreeBSD 6.4/i386
by Austin English 27 Jan '09

27 Jan '09

On Mon, Jan 26, 2009 at 5:43 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > After Austin's recent changes (that were committed in the last 24h), > Wine no longer builds for me on FreeBSD 6.4/i386 with the following > failure mode. > > In file included from ipstats.c:71: > /usr/include/netinet/ip.h:160: error: expected specifier-qualifier-list before 'n_long' > gmake[2]: *** [ipstats.o] Error 1 > gmake[2]: Leaving directory `/sw/test/Wine/dlls/iphlpapi' > … [View More]

1 0

Making the file dialog resizable(implementing OFN_ENABLESIZING)
by Diaa Sami 26 Jan '09

26 Jan '09

Hi, The attached patch fixes the bug at http://bugs.winehq.org/show_bug.cgi?id=10394 , can you have a look at it. It's pretty much done except for some nasty bug and the repainting problem. -- Regards, Diaa Sami

1 1

Re: gdi32: Implement QueryFontAssocStatus
by Byeongsik Jeon 26 Jan '09

26 Jan '09

2009-01-19 (Mon), 09:40 +0900, Byeongsik Jeon wrote: > QueryFontAssocStatus() is the undocumented function. > This is a base patch for bug#16325. > > http://bugs.winehq.org/show_bug.cgi?id=16325 > Hmm... What is the problem of this patch? > --- > dlls/gdi32/font.c | 12 +++++++ > dlls/gdi32/freetype.c | 66 ++++++++++++++++++++++++++++++++++++++++++ > dlls/gdi32/gdi32.spec | 2 +- > dlls/gdi32/gdi_private.h | 1 + > … [View More]

1 1

[RFC] msvcrt: Implement _mbcjistojms
by David Hedberg 26 Jan '09

26 Jan '09

Hello, This function is supposed to convert a jis-encoded (Japanese) character to sjis encoding. I think I botched my last attempt up in more than one way so I've now reworked it slightly and thought I'd try again, but perhaps I should first ask if there is anything else obviously wrong with it. For example, the implementation is a bit of a (as far as I can tell working) black box, and the test of it basically tests two different things depending on the codepage, which I am not sure is a good … [View More]

1 0

Re: Two simple fixes for ListView
by Austin English 26 Jan '09

26 Jan '09

On Mon, Jan 26, 2009 at 4:29 PM, Michael James <james.me(a)gmail.com> wrote: > Here are two simple fixes before I attempt anything more complex here. > > Michael James > > From d978eb3c3eff3b44fce6257892749c2c1c34277d Mon Sep 17 00:00:00 2001 > From: Michael James <james.me(a)gmail.com> > Date: Sun, 25 Jan 2009 20:09:33 -0800 > Subject: [PATCH 1/2] Added logic to eliminate a valgrind warning in > LISTVIEW_GetItemExtT > > The original code used … [View More]correct but somewhat obscure logic. Added a test to > avoid testing uninitialized pointer for pszText when LVIF_TEXT is not indicated > in the flags. With this change, the code functions identically to what it was > doing before but will not cause a warning from valgrind. > --- > dlls/comctl32/listview.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index 172925f..f28a70e 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -5685,7 +5685,7 @@ static BOOL LISTVIEW_GetItemExtT(const > LISTVIEW_INFO *infoPtr, LPLVITEMW lpLVIte > > pszText = lpLVItem->pszText; > bResult = LISTVIEW_GetItemT(infoPtr, lpLVItem, isW); > - if (bResult && lpLVItem->pszText != pszText) > + if (bResult && (lpLVItem->mask & LVIF_TEXT) && lpLVItem->pszText > != pszText) > textcpynT(pszText, isW, lpLVItem->pszText, isW, lpLVItem->cchTextMax); > lpLVItem->pszText = pszText; > > -- > 1.6.1 > > From 8f05ae1ceca1b787f09ede7e7ab0883ee38c63b9 Mon Sep 17 00:00:00 2001 > From: Michael James <james.me(a)gmail.com> > Date: Sun, 25 Jan 2009 21:09:42 -0800 > Subject: [PATCH 2/2] Defined missing macro ListView_GetCheckState > > --- > include/commctrl.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/commctrl.h b/include/commctrl.h > index 426d70a..9cea03c 100644 > --- a/include/commctrl.h > +++ b/include/commctrl.h > @@ -3715,6 +3715,8 @@ typedef struct NMLVSCROLL > SNDMSGA(hwnd, LVM_SETITEMSTATE, (WPARAM)(UINT)i, (LPARAM) (LPLVITEMA)&_LVi);} > #define ListView_GetItemState(hwnd,i,mask) \ > (BOOL)SNDMSGA((hwnd),LVM_GETITEMSTATE,(WPARAM)(UINT)(i),(LPARAM)(UINT)(mask)) > +#define ListView_GetCheckState(hwnd,i) \ > + ((ListView_GetItemState(hwnd,i,LVIS_STATEIMAGEMASK)>>12)-1) > #define ListView_GetCountPerPage(hwnd) \ > (BOOL)SNDMSGW((hwnd),LVM_GETCOUNTPERPAGE,0,0L) > #define ListView_GetImageList(hwnd,iImageList) \ > -- > 1.6.1 > > > One patch per e-mail please. -- -Austin [View Less]

1 0

Re: Bugzilla question with respect to .NET 1.1SP1
by James Mckenzie 26 Jan '09

26 Jan '09

Austin English <austinenglish(a)gmail.com> wrote: >Sent: Jan 26, 2009 11:48 AM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Alexandre Julliard <julliard(a)winehq.org>, Paul Vriens <paul.vriens.wine(a)gmail.com>, "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> >Subject: Re: Bugzilla question with respect to .NET 1.1SP1 > >On Mon, Jan 26, 2009 at 12:34 PM, James Mckenzie ><jjmckenzie51(a)earthlink.net> wrote: >> … [View More]Alexandre Julliard <julliard(a)winehq.org> >>>Sent: Jan 26, 2009 7:21 AM >>>To: Paul Vriens <paul.vriens.wine(a)gmail.com> >>>Cc: James Mckenzie <jjmckenzie51(a)earthlink.net>, "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> >>>Subject: Re: Bugzilla question with respect to .NET 1.1SP1 >>> >>>Paul Vriens <paul.vriens.wine(a)gmail.com> writes: >>> >>>> So that means bug 14850 needs to be reopened with a link to 13995? >>> >>>No, if it's the same bug it should be a single report. If .NET doesn't >>>install then obviously all apps that try to install it will be broken, >>>it doesn't make sense to create a separate bug for each app that suffers >>>from the problem. >>> >> Actually, I have a different opinion as the reason a program will not install may, at first appearance, be the lack of .NET1.1SP1 but may be another function that Wine does not provide. Paul is 'smart enough' to figure that the problem IS the lack of .NET functionality or the inability to install, but the common user may not. I say, open the bug, mark it as a duplicate of the existing bug and then close it. Add the reporter as a cc to the original bug. When the bug is resolved, then have the user attempt to install the program, if it still fails, reopen the duplicate with whatever does not work now. This keeps the number of bugs down and lets us know how much the lack of functionality affects the Wine user base. Some users complain of being lost in the shuffle because they add to an existing bug that another program is affected. >> >> What do you say about doing this? >> >> James McKenzie >> >> >> >> > >That's messy. Have them cc themselves to the original bug, and when >its fixed, retest. No need to file a bug only to close it immediately >as a duplicate. > I realize it's ugly, but I'm thinking like a software tester not a developer. If I found three bugs in a program, I opened three bugs. If I found the same bug in a different program, I opened a second bug and attached it to the first. >If, however, you're able to workaround that bug, then make a new bug, >and have the second depend on the first. > >E.g., program foo needs native gdiplus and native richedit to install. >File bug for gdiplus problem, then file a second one for richedit, >marking it as depending on the gdiplus bug. What if the richedit bug is fixed first? Would it be impossible to test to see if the bug is fixed? If that were the case, then this is a correct scenario. If the richedit bug can be tested independently of the gdiplus bug, then this scenario is incorrect. If the gdiplug bug depends on the richedit bug being fixed first, then the linkage should be reversed. Linking two separate bugs in this case may not pass the sense test. There has to be an added, simple mechanism where a user (not a developer, or triage) can add to a list of applications affected by a specific bug. See above for what I consider a bug, this is a single application affected by a single problem. Linking together independent bugs needs to be done in a rational manner. If three applications are affected by the same bug, then they either should be linked together, reported under one bug with additional votes for the added applications and users with an updated description, or held as separate bug reports. Sorry to be so long winded about this, but proper bug reporting was and still is my primary business. James McKenzie [View Less]

2 1

Making the file dialog resizable(implementing OFN_ENABLESIZING)
by Diaa Sami 26 Jan '09

26 Jan '09

Hi, Can you please have a look at the patch at http://bugs.winehq.org/show_bug.cgi?id=10394 ? It's pretty much done except for some nasty bug and the repainting problem. -- Regards, Diaa Sami

1 0

re: advapi32: Fix potential NULL pointer dereference in LookupPrivilegeNameW [with test] (Saturn)
by Dan Kegel 26 Jan '09

26 Jan '09

Cool, I didn't know about Saturn. I've updated http://wiki.winehq.org/StaticAnalysis with info about it. Offhand it looks like neither of these were caught by Coverity...?

1 0

Making the file dialog resizable(implementing OFN_ENABLESIZING)
by Diaa Sami 26 Jan '09

26 Jan '09

Hi, Can you please have a look at the patch at http://bugs.winehq.org/show_bug.cgi?id=10394 ? It's pretty much done except for some nasty bug and the repainting problem. -- Regards, Diaa Sami

1 0

Re: Bugzilla question with respect to .NET 1.1SP1
by James Mckenzie 26 Jan '09

26 Jan '09

Alexandre Julliard <julliard(a)winehq.org> >Sent: Jan 26, 2009 7:21 AM >To: Paul Vriens <paul.vriens.wine(a)gmail.com> >Cc: James Mckenzie <jjmckenzie51(a)earthlink.net>, "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> >Subject: Re: Bugzilla question with respect to .NET 1.1SP1 > >Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > >> So that means bug 14850 needs to be reopened with a link to 13995? > >No, if it's the same bug … [View More]

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel