- wine-devel - winehq.org

mpr: fix a compiler error on PowerPC
by Steven Edwards 09 Jan '09

09 Jan '09

---------- Forwarded message ---------- From: art yerkes <art.yerkes(a)gmail.com> Date: 2009/1/9 Subject: Re: mpr: fix a compiler error on PowerPC To: Steven Edwards <winehacker(a)gmail.com> According to Art Yerkes who has a copy of PPC VC++ "Here's what I get. The first test (char) works identically to the second test (signed char), so the default has to be signed." -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: mpr: fix a compiler error on PowerPC
by Francois Gouget 09 Jan '09

09 Jan '09

On Fri, 2 Jan 2009, Austin English wrote: > CHAR defaults to unsigned char on PowerPC, so explicitly setting hi/lo > to signed char to avoid this error. CHAR is a Windows type so I don't think it's right for it to be unsigned on PowerPC. Even more so since there is a UCHAR type. So I think the right thing to do is to fix the CHAR declaration in wtypes.h and winnt.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Research is the transformation of money to knowledge. Innovation is the transformation of knowledge to money. -- Dr. Hans Meixner

3 6

MSI Patch Feedback
by Andrew Nguyen 09 Jan '09

09 Jan '09

Hello, I've written a few patches against dlls/msi/action.c in an effort to rectify a difference in behavior with an MSI-based installer between Windows and Wine with regard to environment variable processing. Behavior not explicitly enumerated by MSDN is noted when a combination of the environment table "+" name prefix and "[~]" value expression are combined. How should I attempt to test the changes I have made, and is there anything I can do to improve the quality of my changes? Feedback is appreciated! -Andrew

4 3

Re: wined3d: Add code to cleanup device multistate_funcs
by Allan Tong 09 Jan '09

09 Jan '09

On Tue, Jan 6, 2009 at 10:45 PM, Allan Tong <actong88(a)gmail.com> wrote: > Second try, replaces both "wined3d: Fix a memory leak in > compile_state_table()" and "wined3d: Free multistate_funcs when > destroying the device" patches from yesterday. Anything wrong with this patch? - Allan

1 0

Re: ntdll: Change the WinXP service pack version to 3.0
by Alexandre Julliard 09 Jan '09

09 Jan '09

"Johan Dahlin" <jdahlin(a)gmail.com> writes: > Change the XP SP version to 3.0, as required by some recent apps. You also need to fix wine.inf and winecfg. -- Alexandre Julliard julliard(a)winehq.org

1 0

Does preloader attempt to fix ASR?
by Nicholas LaRoche 09 Jan '09

09 Jan '09

On a standard installation of Fedora 10 address space randomization is enabled by default. The base address of a process started by wine seems to change.. and it is easy to see when loading Dlls and checking their base addresses. Does the preloader attempt to compensate for this? Or is it necessary to use setarch to turn off ASR completely when debugging with reproducibility? $> setarch $(uname -p) -RL Regards, Nick

2 1

Re: kernel32: implement CPU detection for OpenBSD
by Francois Gouget 09 Jan '09

09 Jan '09

On Fri, 2 Jan 2009, Austin English wrote: @@ -544,7 +544,7 @@ VOID WINAPI GetSystemInfo( } fclose (f); } -#elif defined (__NetBSD__) +#elif defined (__NetBSD__) || defined(__OpenBSD__) { int mib[2]; int value[2]; @@ -557,31 +557,55 @@ VOID WINAPI GetSystemInfo( #ifdef CPU_FPU_PRESENT mib[1] = CPU_FPU_PRESENT; value[1] = sizeof(int); - if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) +#ifdef __OpenBSD__ + if (sysctl(mib, 2, value, (size_t *)(value+1), NULL, 0) >= 0) { +#else + if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) { +#endif This was wrong to start with because even if size_t is 8 bytes, value+1 will only have space for 4. Plus the code tests whether value changed instead of testing *value! I'm sending a patch to fix that. Then you can resend your patch adding just the defined(__OpenBSD__). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ A polar bear is a cartesian bear after a coordinate transform.

1 0

Re: [shell32/tests 6/6] Skip a test on Vista
by Reece Dunn 08 Jan '09

08 Jan '09

2009/1/8 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > With this last patch all shlfileop tests succeed on all my boxes (Win95, > Win98, > NT4, W2K, W2K3 and Vista). > > Changelog > Skip a test on Vista +static BOOL on_vista = FALSE; + I don't see where this is used. Kudos for fixing the shell32:shfileop tests. - Reece

1 0

Re: setupapi/tests: Remove an unneeded cast.
by Hans Leidekker 08 Jan '09

08 Jan '09

On Thursday 08 January 2009 00:05:01 Francois Gouget wrote: > memset(buffer, 0x55, sizeof(buffer)); > - retval = pStringTableLookUpStringEx(table, uilevel, ST_CASE_SENSITIVE_COMPARE, buffer, (LPDWORD)0); > + retval = pStringTableLookUpStringEx(table, uilevel, ST_CASE_SENSITIVE_COMPARE, buffer, NULL); > ok(retval != ~0u, "failed find 'UILEVEL' in string table\n"); > ok(memcmp(buffer, &data, 4), "unexpected data\n"); This test is there to show that the prototype of StringTableLookUpStringEx is broken; the last parameter is treated as an integer instead of a pointer and this notation serves to document that fact. But I can see how this will repeatedly trigger janitorial scripts, so I do not object to this patch going in. -Hans

6 7

Dates in Wine announcement
by Ian Macfarlane 08 Jan '09

08 Jan '09

Very small suggestion - it would be helpful to have dates included somewhere (preferably near the top) of the wine announce pages, for example: http://www.winehq.org/announce/1.1.12 This will let people who come to it via search engines know what date this particular release was made on, without having to dig around. (it will also help prevent people mistaking an old development release for a new one - I'm sure most people have seen at least one news story about something where the reporter/blogger is reporting years-old news as new because they didn't look at the dates on the article, or there were no dates or they were a hard to spot grey colour). Just a small suggestion. Ian

4 3

WIDL and Windows rpcrt4
by Ge van Geldorp 08 Jan '09

08 Jan '09

Hi Rob, Is WIDL supposed to generate code that's compatible with Windows RPCRT4.DLL? Because it appears this is currently not the case. When you look at http://test.winehq.org you'll see that the rpcrt4:server test fails on pretty much any Windows version. I investigated a bit more, the failures are caused by an exception 0x6e6 ("An internal error occurred in a remote procedure call (RPC)" thrown from NdrPointerBufferSize() in server_c.c function get_name(). The mingw-crosscompiled executable doesn't handle that exception which causes the process to crash. Since this is in WIDL-generated code, I decided to take a look at what MIDL generates for the same IDL file. It turns out that MIDL treats the name_t struct as a simple structure, while WIDL treats it as a complex structure. That made comparison a bit difficult. Since WIDL never seems to generate simple structures, I tried to convince MIDL to generate a complex structure too. After a bit of fiddling around (I'm no IDL expert...) I came up with the following type, a mix of name_t and sun_t: typedef struct { [string, size_is(size)] char *name; unsigned int size; [switch_is(s)] union { [case(SUN_I)] int i; [case(SUN_F1, SUN_F2)] float f; [case(SUN_PI)] int *pi; } u; int s; } complex_t; After staring at the WIDL-generated and MIDL-generated code for a while (which still differed quite a bit), I noticed something interesting: in the type format string, "unsigned int size" gets encoded as FC_ULONG by WIDL, but as FC_LONG by MIDL. I then went back to the server_c.c and server_s.c files generated by WIDL for the tests and changed the type format strings there (replaced the "unsigned int size" encoding from FC_ULONG by FC_LONG). With this change, the get_name() test passes :-). It then crashes later on with an access violation inside NdrVaryingArrayUnmarshall() in get_5numbers(), but let's take the problems one at a time... So it appears Windows RPCRT4.dll is not happy with FC_ULONG entries within a complex structure. I added a bunch of other primitive types to my complex_t structure to see how they are treated by MIDL. See attached complex.idl file and the MIDL-generated midl_complex_c.c file (also attached WIDL-generated widl_complex_c.c for completeness). It appears that MIDL simply drops the "unsigned" from any base type, at least within complex structures. "unsigned long" gets encoded as FC_LONG, "unsigned short" as FC_SHORT and "unsigned small" as FC_SMALL. Like I said, I'm no IDL expert. Does the stuff above make sense to you? Do you think it would be a good idea to change WIDL to generate the same encodings as MIDL? Thanks, Gé.

3 3

D3D shaders
by Anton Romanov 08 Jan '09

08 Jan '09

Hi. First, sorry for maybe somewhat newbish questions/approach... but anyway. Do i understand correctly that wined3d implementation takes d3d shaders' bytecode and converts it to other format depending on hardware? What is the state of wine's d3d shaders' implementation? I'm asking because I've recently came across a MojoShader (http://icculus.org/mojoshader/) project which is a library (zlib licensed) to convert compiled Direct3D shaders from bytecode to some other format (several profiles). The library seems to work well - it is used for OpenGL renderer in Unreal Tournament 3 engine. So i wonder - can there be some benefit to wine from such a project? Thanks.

2 1

Implementing b3DAccelerationExists and b3DAccelerationEnabled in dxdiagn
by Markus 08 Jan '09

08 Jan '09

Hello, can anyone tell me where to find information about the b3DAccelerationExists and b3DAccelerationEnabled properties in the display container returned by dxdiagn.dll and when they are supposed to be false or true? In fact, MSDN does not seem to provide information about any of the properties returned by that dll. Thanks, -- Markus

3 5

Proof the new site design is superior!
by Dan Kegel 08 Jan '09

08 Jan '09

The new site design is already paying dividends. Look: http://www.zmogo.com/gear/the-new-year-linux-resolution-day-5/ says: "... I chose Wine mainly because its site is more appealing looking than VMware's, which has all the sleek design features and well-considered organization of an expired domain name..." :-)

2 1

Re: mshtml: Implement IHTMLStyle get/set Attribute
by Alistair Leslie-Hughes 08 Jan '09

08 Jan '09

Hi, Is there anything wrong with this patch? Best Regards Alistair Leslie-Hughes > From dca7b396838e3367ad78144ccb07aed24cd5917f Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Mon, 5 Jan 2009 21:22:35 +1100 > Subject: [PATCH] Implement IHTMLStyle get/set Attribute > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/htmlstyle.c | 69 > ++++++++++++++++++++++++++++++++++++++++++---- > dlls/mshtml/tests/dom.c | 36 ++++++++++++++++++++++++ > 2 files changed, 99 insertions(+), 6 deletions(-) > > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index fa4ad51..3453f7b 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -2048,18 +2048,75 @@ static HRESULT WINAPI > HTMLStyle_setAttribute(IHTMLStyle *iface, BSTR strAttribut > VARIANT AttributeValue, LONG lFlags) > { > HTMLStyle *This = HTMLSTYLE_THIS(iface); > - FIXME("(%p)->(%s v%d %08x)\n", This, debugstr_w(strAttributeName), > - V_VT(&AttributeValue), lFlags); > - return E_NOTIMPL; > + HRESULT hres; > + DISPID dispid; > + > + TRACE("(%p)->(%s v%d %08x)\n", This, debugstr_w(strAttributeName), > + V_VT(&AttributeValue), lFlags); > + > + if(!strAttributeName) > + return E_INVALIDARG; > + > + if(lFlags == 1) > + FIXME("Parameter lFlags ignored\n"); > + > + hres = HTMLStyle_GetIDsOfNames(iface, &IID_NULL, > (LPOLESTR*)&strAttributeName, 1, > + LOCALE_USER_DEFAULT, &dispid); > + if(hres == S_OK) > + { > + VARIANT ret; > + DISPID dispidNamed = DISPID_PROPERTYPUT; > + DISPPARAMS params; > + > + params.cArgs = 1; > + params.rgvarg = &AttributeValue; > + params.cNamedArgs = 1; > + params.rgdispidNamedArgs = &dispidNamed; > + > + hres = HTMLStyle_Invoke(iface, dispid, &IID_NULL, > LOCALE_SYSTEM_DEFAULT, > + DISPATCH_PROPERTYPUT, &params, &ret, NULL, NULL); > + } > + else > + { > + FIXME("Custom attributes not supported.\n"); > + } > + > + TRACE("ret: %08x\n", hres); > + > + return hres; > } > > static HRESULT WINAPI HTMLStyle_getAttribute(IHTMLStyle *iface, BSTR > strAttributeName, > LONG lFlags, VARIANT *AttributeValue) > { > HTMLStyle *This = HTMLSTYLE_THIS(iface); > - FIXME("(%p)->(%s %08x %p)\n", This, debugstr_w(strAttributeName), > - lFlags, AttributeValue); > - return E_NOTIMPL; > + HRESULT hres; > + DISPID dispid; > + > + TRACE("(%p)->(%s v%p %08x)\n", This, debugstr_w(strAttributeName), > + AttributeValue, lFlags); > + > + if(!AttributeValue || !strAttributeName) > + return E_INVALIDARG; > + > + if(lFlags == 1) > + FIXME("Parameter lFlags ignored\n"); > + > + hres = HTMLStyle_GetIDsOfNames(iface, &IID_NULL, > (LPOLESTR*)&strAttributeName, 1, > + LOCALE_USER_DEFAULT, &dispid); > + if(hres == S_OK) > + { > + DISPPARAMS params = {NULL, NULL, 0, 0 }; > + > + hres = HTMLStyle_Invoke(iface, dispid, &IID_NULL, > LOCALE_SYSTEM_DEFAULT, > + DISPATCH_PROPERTYGET, &params, AttributeValue, NULL, NULL); > + } > + else > + { > + FIXME("Custom attributes not supported.\n"); > + } > + > + return hres; > } > > static HRESULT WINAPI HTMLStyle_removeAttribute(IHTMLStyle *iface, BSTR > strAttributeName, > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index de363bb..516aa3e 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -2745,6 +2745,42 @@ static void test_default_style(IHTMLStyle *style) > ok(hres == S_OK, "put_overflow failed: %08x\n", hres); > SysFreeString(sOverflowDefault); > > + /* Attribute Tests*/ > + hres = IHTMLStyle_getAttribute(style, NULL, 1, &v); > + ok(hres == E_INVALIDARG, "getAttribute failed: %08x\n", hres); > + > + str = a2bstr("position"); > + hres = IHTMLStyle_getAttribute(style, str, 1, NULL); > + ok(hres == E_INVALIDARG, "getAttribute failed: %08x\n", hres); > + > + hres = IHTMLStyle_getAttribute(style, str, 1, &v); > + ok(hres == S_OK, "getAttribute failed: %08x\n", hres); > + ok(V_VT(&v) == VT_BSTR, "type failed: %d\n", V_VT(&v)); > + VariantClear(&v); > + > + hres = IHTMLStyle_setAttribute(style, NULL, v, 1); > + ok(hres == E_INVALIDARG, "getAttribute failed: %08x\n", hres); > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = a2bstr("absolute"); > + hres = IHTMLStyle_setAttribute(style, str, v, 1); > + ok(hres == S_OK, "setAttribute failed: %08x\n", hres); > + VariantClear(&v); > + > + hres = IHTMLStyle_getAttribute(style, str, 1, &v); > + ok(hres == S_OK, "getAttribute failed: %08x\n", hres); > + ok(V_VT(&v) == VT_BSTR, "type failed: %d\n", V_VT(&v)); > + ok(!strcmp_wa(V_BSTR(&v), "absolute"), "str=%s\n", > dbgstr_w(V_BSTR(&v))); > + VariantClear(&v); > + > + V_VT(&v) = VT_BSTR; > + V_BSTR(&v) = NULL; > + hres = IHTMLStyle_setAttribute(style, str, v, 1); > + ok(hres == S_OK, "setAttribute failed: %08x\n", hres); > + VariantClear(&v); > + > + SysFreeString(str); > + > hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, > (void**)&style2); > ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres); > if(SUCCEEDED(hres)) { > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Unused function in quartz
by Francois Gouget 07 Jan '09

07 Jan '09

Hi, In the following commit you added the OutputPin_DeliverNewSegment() function to pin.c. However today it is unused. Is there any plan to use it? Is it still relevant? commit 0a6f11c88a8da49d80e4e7d8a0236ae4b36926b7 Author: Robert Shearman <R.J.Shearman(a)warwick.ac.uk> Date: Thu Sep 25 23:50:06 2003 +0000 - A few cosmetic fixes. - Various bug fixes. - Add some OutputPin helpers. - Add a new type of pin, PullPin. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

3 2

Re: compiling python2.5 on linux under wine
by Luke Kenneth Casson Leighton 07 Jan '09

07 Jan '09

On Sat, Jan 3, 2009 at 9:22 PM, Luke Kenneth Casson Leighton <lkcl(a)lkcl.net> wrote: > hey, has anyone investigated compiling python2.5 using winegcc, under wine? some people might find this kind of thing amusing. it's considered in very obtuse circles to be "progress"... :) lkcl@gonzalez:/mnt/src/python2.5-2.5.2/Lib$ ../build/python -v Could not find platform independent libraries <prefix> Could not find platform dependent libraries <exec_prefix> Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>] # installing zipimport hook import zipimport # builtin # installed zipimport hook 'import site' failed; traceback: ImportError: No module named site Python 2.5.2 (r252:60911, Jan 7 2009, 20:33:53) [gcc] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import site fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored [....] [....] [....] import sre_compile # from Z:\mnt\src\python2.5-2.5.2\Lib\sre_compile.py fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored # wrote Z:\mnt\src\python2.5-2.5.2\Lib\sre_compile.pyc import _sre # builtin import sre_constants # from Z:\mnt\src\python2.5-2.5.2\Lib\sre_constants.py # wrote Z:\mnt\src\python2.5-2.5.2\Lib\sre_constants.pyc import sre_parse # from Z:\mnt\src\python2.5-2.5.2\Lib\sre_parse.py # wrote Z:\mnt\src\python2.5-2.5.2\Lib\sre_parse.pyc Traceback (most recent call last): File "<stdin>", line 1, in <module> File "site.py", line 415, in <module> main() File "site.py", line 406, in main aliasmbcs() File "site.py", line 356, in aliasmbcs import locale, codecs File "Z:\mnt\src\python2.5-2.5.2\Lib\locale.py", line 167, in <module> import re, operator File "Z:\mnt\src\python2.5-2.5.2\Lib\re.py", line 223, in <module> _pattern_type = type(sre_compile.compile("", 0)) File "Z:\mnt\src\python2.5-2.5.2\Lib\sre_compile.py", line 530, in compile groupindex, indexgroup OverflowError: signed integer is less than minimum >>>

1 0

Re: AppDB: Rating / Patching
by James Mckenzie 07 Jan '09

07 Jan '09

>On Tue, Jan 6, 2009 at 6:48 AM, Rosanne DiMesio <dimesio(a)earthlink.net> wrote: >> >>> Now, the story changes if the patch is conforming and has been accepted >>> by AJ and is pending the next development release. >>> >> Then the next development release can get the gold, but previous ones still shouldn't. AppDB test ratings are tied to specific releases, and intended to tell normal users how different versions of Wine will work with their app. Patching Wine is not something normal users can or want to do, and allowing ratings based on patched versions of Wine is misleading, even if the patch does eventually make it in to a later release. > >It sounds like the problem is that the version string in appdb isn't >descriptive enough. It's perfectly reasonable to wonder if a given >program can be made to work with a patched version of wine, and wonder >how well it will work. It's also reasonable to wonder how it will >work with a vanilla version. Both types of reports are useful to have >in the appdb. Having a version "x.x.x (patched)" available to >reporters would allow both types of reports to be clearly separated. > No, the appdb should not be touched. Rosanne said it correctly, ordinary users are NOT going to take the time to build Wine, nor should they. We can put in the bug report that the patch works and whether or not it has been submitted. Sometimes a patch is to rough or a real hack that breaks other programs, but with refinement is acceptable and will be incorporated into Wine. The appdb needs to stay as clean as it can. Of course, you can always add a bug report to the appdb entry, add comments and let users decide what they want to do. Rating a rogue patched Wine as Gold is very misleading. We need to keep ratings to what is available for the ordinary, unknowing user (read nOOb.) James McKenzie

7 8

New appdb checkbox: "officially supports wine"?
by Dan Kegel 07 Jan '09

07 Jan '09

http://wiki.winehq.org/AppsThatSupportWine is a nice stopgap, but perhaps it should be a report in the appdb, driven by a checkbox that maintainers can check. What do folks think?

4 3

Re: readme: add a note about UNIX paths
by James Hawkins 07 Jan '09

07 Jan '09

On Tue, Jan 6, 2009 at 7:04 PM, Austin English <austinenglish(a)gmail.com> wrote: > Adds a note discouraging use of UNIX paths, since there's seems to > have been a rash of it in recent bug reports. > If we don't recommend it, and usually advise against it, why not just remove that line from the README? -- James Hawkins

4 5

Re: AppDB: Rating / Patching
by James Mckenzie 07 Jan '09

07 Jan '09

Sparr <sparr0(a)gmail.com> wrote: >On Wed, Jan 7, 2009 at 4:47 AM, Chris Howe <mrmessiah(a)gmail.com> wrote: >> argument for some kind of WineTricks-like Wine application launcher >> that would exist as a separate project to Wine, but would apply patches, > >Re-compiling wine with patches is an extremely farfetched idea when no >one outside Cedega has ever tackled the far simpler tasks involved >with making a wine launcher. > I take offesense to that comment. Darwine does have a wine launcher and it does work. James McKenzie

1 0

Re: AppDB: Rating / Patching
by James Mckenzie 07 Jan '09

07 Jan '09

Sparr <sparr0(a)gmail.com> wrote: >On Wed, Jan 7, 2009 at 4:47 AM, Chris Howe <mrmessiah(a)gmail.com> wrote: >> argument for some kind of WineTricks-like Wine application launcher >> that would exist as a separate project to Wine, but would apply patches, > >Re-compiling wine with patches is an extremely farfetched idea when no >one outside Cedega has ever tackled the far simpler tasks involved >with making a wine launcher. > I take offesense to that comment. Darwine does have a wine launcher and it does work. James McKenzie

1 0

why are we not using pkg-config in configure
by Danny Rawlins 07 Jan '09

07 Jan '09

Hi, I would like to know if there is any issues as to why we are not using pkg-config to check for needed library's with the m4 macros. Also this question arose in #winehackers TBBle> Hmm. Is pkg-config broken under mingw? And do we care? Regards, Danny Rawlins

2 1

Re: [PATCH 1/2] Add definitions used by reparse points
by Paul Vriens 07 Jan '09

07 Jan '09

Paul TBBle Hampson wrote: > Not much to say about this. It's needed for the unit tests coming up. > > > ------------------------------------------------------------------------ > > Hi Paul, Part of your signature says: License: http://creativecommons.org/licenses/by/2.5/au/ Does this mean your patches come under this license (or is it just the signature ;))? -- Cheers, Paul.

2 1

Re: [1/2] dlls: Add loadperf.dll
by Andrew Nguyen 07 Jan '09

07 Jan '09

On Tue, Jan 6, 2009 at 8:21 AM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > .NET 1.1 uses this dll during installation > > --- > configure.ac | 1 + > dlls/loadperf/Makefile.in | 13 +++++++++++++ > dlls/loadperf/loadperf.spec | 14 ++++++++++++++ > dlls/loadperf/loadperf_main.c | 29 +++++++++++++++++++++++++++++ > 4 files changed, 57 insertions(+), 0 deletions(-) > create mode 100644 dlls/loadperf/Makefile.in > create mode 100644 dlls/loadperf/loadperf.spec > create mode 100644 dlls/loadperf/loadperf_main.c > You've forgotten to append the licensing header to loadperf_main.c.

1 0

Re: [PATCH 1/2] Add definitions used by reparse points
by Austin English 07 Jan '09

07 Jan '09

On Wed, Jan 7, 2009 at 12:05 AM, Paul TBBle Hampson <Paul.Hampson(a)pobox.com> wrote: > Not much to say about this. It's needed for the unit tests coming up. > -- > ----------------------------------------------------------- > Paul "TBBle" Hampson, B.Sc, LPI, MCSE > Very-later-year Asian Studies student, ANU > The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) > Paul.Hampson(a)Pobox.com > > Of course Pacman didn't influence us as kids. If it did, > we'd be running around in darkened rooms, popping pills and > listening to repetitive music. > -- Kristian Wilson, Nintendo, Inc, 1989 > > License: http://creativecommons.org/licenses/by/2.5/au/ > ----------------------------------------------------------- > > > > +// Used for all tags where IsReparseTagMicrosoft is false +// and for some tags where IsReparseTagMicrosoft is true Please use /* comments */, not C++ style. -- -Austin

2 1

AppDB: Rating / Patching
by Björn Krombholz 07 Jan '09

07 Jan '09

Hi, I started a discussion inside AppDB about the in my eyes "strange" Gold rating of Fallout 3 (it's actually just an example, other entries suffer the same problems). I know there was a discussion about the rating on this list last month, but as far as I could see my particular issue wasn't covered and I only just subscribed. So here goes a new thread. The appdb thread [1] is included below (prevent OT-cleanup deletion inside appdb). I don't expect anyone to read it completely, but I didn't want to repeat every argument again either. ;) The basic point is: Fallout 3 (a game) only works with a small -- but nevertheless -- patch, otherwise it will crash, no matter what dll-overrides/settings/3rd-party apps. From how I understand the wording in [2], an app that requires a patch to run, can't get a gold rating. In fact, if there is no way to get it working in a vanilla wine release, then there is no other option than "Garbage" IMO. The various arguments for that assumption (possible breaking of other apps run by the same wine installation, regression tracking, etc.) are in the quote below. The maintainer tried to convince me that a gold rating is valid, because Fallout 3 works great with the patch applied. Well obviously he failed, and the discussion went away from Fallout in particular to a more general interpretation of [2]. I'm neither saying I'm right and he's wrong, nor the other way around. IMO both interpretation can be valid, depending on how you read "some DLL overrides, other settings or third party software." My suggestion now would be: * Clarify the wording on what "other settings" really means (my interpretation is mainly registry modifications with winecfg and/or regedit). * Add an explicit statement about patched wine versions. Something like: - Any application that requires a patched wine to run MUST NOT be rated higher than "Garbage" (or whatever rating was intended for this situation). [1] http://appdb.winehq.org/objectManager.php?sClass=version&iId=14322#Comment-… [2] http://appdb.winehq.org/help/?sTopic=maintainer_ratings Björn ==== Copy from AppDB discussion [1] below ==== Björn Krombholz on Monday January 5th 2009, 10:10: Hi, I don't understand the recent ratings. I've played the game a lot under Windows and with various versions of wine, using all kinds of different tweaks and settings the game itself and wine offer. It runs pretty well and it's become even better (meaning faster) since 1.11 (no evidence, could be caused by a driver update as well). Nevertheless, as far as I can see, noone has ever managed to get past menu + the loading screen without at least applying the D3D patch attached to [1], that allows setting the VideoDescription and VideoDriver in the registry. For flawless mouse interaction, you also need the mouse hack from [2]. Considering these 2 as a fact (please correct me, if there actually is a way to run it without patches), how can it ever be rated higher than "Garbage"? My understanding of the ratings are, that they offer a quick hint on what you are able to run (nearly) without problems, while the discussion and howto sections deal with "broken" stuff and tell a user, how he might be able to run an app/game despite the garbage state. [1] http://bugs.winehq.org/show_bug.cgi?id=15839 [2] http://bugs.winehq.org/show_bug.cgi?id=6971 ----- RE: Rating / Patching by Tymoteusz Paul on Monday January 5th 2009, 10:20 Let me explain you how ranking system works, because you seem to have it confused. As expalined in http://appdb.winehq.org/help/?sTopic=maintainer_ratings gold/silver rating is ok as long as you can use it for it's purpose. All you have to do is override couple dlls and settings and then the game is working pretty much flawlessy. Garbage rating would be then if it was impossible to play the game. Ratings as is provide good info about the game, if you see that its rated as gold - then you are safe to buy it for linux playig, it may take some work to get it work but it will work and will be playable. Only rating that fits your description "hint on what you are able to run (nearly) without problems" fits platinum rating, which this game didn't get so far. Hope this will be more clear for you now. ----- RE: Rating / Patching by Björn Krombholz on Monday January 5th 2009, 14:08 I was referring to this help text as well, although I read it differently. ;) In any vanilla/clean release version of wine, Fallout 3 won't run. You get the menu, can change settings, but when you start the game to play ("purpose it was designed") it crashes, even "with some DLL overrides, other settings or third party software" you install in wine. => Garbage rating. Let's imagine the small driver patch in bug 15839 was applied to the development tree and so released with 1.1.13. The game would become playable with one major "issue". No matter what settings you change/etc. the mouse is either always stuck in the middle of the screen or it gets stuck at the screen edges (bug 9671). => Bronze rating for wine >= 1.1.13. Maybe even Silver, as it might work very well with a different kind of controller like a gamepad. Now the mouse bug gets fixed in 1.1.x. Suddenly all you need to do is to override some (actually just one) dlls and tweak some settings to make it enjoyable. => Silver (in case you consider Live functionality an important part of the program) or Gold rating. Eventually someone adds the d3dx9_38.dll to wine and the DeviceDriver + DeviceDescription settings will be automatically detected by wine. That means the game works flawlessly without touching any wine setting. => Platinum rating. IMO this makes sense, otherwise a version 1.1.x gold app, wouldn't be downgradable in its rating for 1.1.x+1 (in case version x+1 introduced a regression that breaks this app); because all you had to do to make it work again is unapply the faulty patch. In addition to that, users wouldn't be encouraged to file a bug report if there is source-patch that upgrades it to gold anyway. Anyway, I don't care much about which interpretation should be used, I just want it to be more consistent. As you can see in the reports history Fallout 3 people rated in both ways. E.g., the newest one voting gold, because it works great after patching according to the HOWTO; http://appdb.winehq.org/objectManager.php?sClass=version&iId=14322&iTesting… rating "Garbage" because "Mouse is borked and gameplay is impossible without patches. Which would be the best way to ask for a more indisputable explanation on the help page? Filing a bug report against appdb or using the "Email Us" link at the right, or ...? ----- RE: Rating / Patching by Radosław Ciechowski on Monday January 5th 2009, 15:15 Gold is for apps that "Works flawlessly with DLL overrides, third party software or other settings" so if Fallout 3 is working without bugs after applaying patches, dll-s and other settings it should be rated Gold. If there was no way to get it working or there were lots of bugs after all tweaks, then it could be rated Garbage. If game works flawlessly then no matter how mamy things you have to do, it can be rated Gold which makes sense for me. There is no sense in rating apps Garbage when they can work flawlessly ! Also there is already rating system which we are using ( http://appdb.winehq.org/help/?sTopic=maintainer_ratings ) and changing it now wouldnt be a good idea. ----- RE: Rating / Patching by Björn Krombholz on Monday January 5th 2009, 15:55 > Gold is for apps that "Works flawlessly with DLL overrides, third party software or other settings" < Indeed, that's what I'm saying. But applying a patch to the wine source and recompiling it -- which effectively makes it some _different_ version than the _release_ version you are supposed to rate -- is neither of those 3. - "DLL override": installing a custom DLL into $WINEPREFIX and adding the override) - "third party software": installing additional software into $WINEPREFIX that is needed and expected by the app you want to run - "other settings": tweak the wine registry and similar configuration None of these change the wine version, any such change would still be a "wine 1.1.x", while patches like the mouse patch might even break other software even if those are installed in a different $WINEPREFIX, because the binary changed and it's behaviour is different from the official release. You can't say "A is running well on wine 1.1.x", if in fact it is running well on wine 1.1.x+patch, while it actually breaks on wine 1.1.x. And yes, as I already said, there is a help page for the rating system. I don't ask to change, but to clarify it, as at the moment people are rating differently depending on their interpretation. This has become OT on this page - I will try to move it to the -devel list. :)

8 12

Re: PR 16828 dlls/ntdll/serial.c clear IEXTEN when clearing ICANON
by Austin English 06 Jan '09

06 Jan '09

On Tue, Jan 6, 2009 at 12:49 PM, G. Paul Ziemba <p-wine-bugs(a)ziemba.us> wrote: > FreeBSD fix for Nirvis CDJ application, PR 16828 > > > --- dlls/ntdll/serial.c.orig 2008-12-20 06:55:38.000000000 -0800 > +++ dlls/ntdll/serial.c 2009-01-05 21:35:47.000000000 -0800 > @@ -648,7 +648,9 @@ > port.c_cflag &= ~(HUPCL); > port.c_cflag |= CLOCAL | CREAD; > > - port.c_lflag &= ~(ICANON|ECHO|ISIG); > + // on FreeBSD, turning off ICANON does not disable IEXTEN, > + // so we must turn it off explicitly. No harm done on Linux. > + port.c_lflag &= ~(ICANON|ECHO|ISIG|IEXTEN); > port.c_lflag |= NOFLSH; > > bytesize = slc->WordLength; > > > -- > G. Paul Ziemba > FreeBSD unix: > 10:46AM up 12 days, 21:25, 10 users, load averages: 0.21, 0.29, 0.23 > > > Again, no C++ comments. -- -Austin

2 2

Re: PR 16592: dlls/kernel32/volume.c
by Austin English 06 Jan '09

06 Jan '09

On Tue, Jan 6, 2009 at 12:25 PM, G. Paul Ziemba <p-wine-bugs(a)ziemba.us> wrote: > Fix for PR 16592, GetVolumeInformationW() handling of unusual "root" > parameter. > > > --- dlls/kernel32/volume.c.orig 2008-12-05 08:57:45.000000000 -0800 > +++ dlls/kernel32/volume.c 2008-12-22 00:15:51.000000000 -0800 > @@ -518,7 +518,7 @@ > HANDLE handle; > enum fs_type type = FS_UNKNOWN; > > - if (!root) > + if (!root || (root && root[0] == '\\' && root[1] == ':')) > { > WCHAR path[MAX_PATH]; > GetCurrentDirectoryW( MAX_PATH, path ); > > > > --- dlls/kernel32/tests/volume.c.orig 2008-12-05 08:57:45.000000000 -0800 > +++ dlls/kernel32/tests/volume.c 2009-01-06 09:52:19.000000000 -0800 > @@ -29,6 +29,9 @@ > static BOOL (WINAPI *pFindVolumeClose)(HANDLE); > static UINT (WINAPI *pGetLogicalDriveStringsA)(UINT,LPSTR); > static UINT (WINAPI *pGetLogicalDriveStringsW)(UINT,LPWSTR); > +static BOOL (WINAPI *pGetVolumeInformationW)(LPCWSTR,LPWSTR,DWORD, > + DWORD*,DWORD*,DWORD*,LPWSTR,DWORD); > +static BOOL (WINAPI *pSetCurrentDirectoryA)(LPCSTR); > > /* ############################### */ > > @@ -216,6 +219,48 @@ > HeapFree(GetProcessHeap(), 0, buf); > } > > +static void test_GetVolumeInformationW(void) > +{ > + // > + // Check handling of root == "\\:" > + // http://bugs.winehq.org/show_bug.cgi?id=16592 > + // > + > + BOOL rc; > + WCHAR root[] = {'\\',':',0}; > + > + if (!pGetVolumeInformationW) { > + win_skip("GetVolumeInformationW not available\n"); > + return; > + } > + > + if (!pSetCurrentDirectoryA) { > + win_skip("SetCurrentDirectoryA not available\n"); > + return; > + } > + > + // > + // set current directory because GetVolumeInformationW refers > + // to it in this test case > + // > + rc = pSetCurrentDirectoryA("C:\\"); > + > + ok(rc, "SetCurrentDirectoryA(\"C:\\\\\") failed\n"); > + > + rc = pGetVolumeInformationW( > + root, // Root > + NULL, // pLabel > + 0, // LabelLen > + NULL, // pSerial > + NULL, // pFilenameLen > + NULL, // pFlags > + NULL, // pFsname > + 0 // FsnameLen > + ); > + > + ok(rc, "GetVolumeInformationW doesn't handle root == \"\\\\:\" case\n"); > +} > + > START_TEST(volume) > { > hdll = GetModuleHandleA("kernel32.dll"); > @@ -226,6 +271,8 @@ > pFindVolumeClose = (void *) GetProcAddress(hdll, "FindVolumeClose"); > pGetLogicalDriveStringsA = (void *) GetProcAddress(hdll, "GetLogicalDriveStringsA"); > pGetLogicalDriveStringsW = (void *) GetProcAddress(hdll, "GetLogicalDriveStringsW"); > + pGetVolumeInformationW = (void *) GetProcAddress(hdll, "GetVolumeInformationW"); > + pSetCurrentDirectoryA = (void *) GetProcAddress(hdll, "SetCurrentDirectoryA"); > > test_query_dos_deviceA(); > test_FindFirstVolume(); > @@ -233,4 +280,5 @@ > test_GetVolumeNameForVolumeMountPointW(); > test_GetLogicalDriveStringsA(); > test_GetLogicalDriveStringsW(); > + test_GetVolumeInformationW(); > } > > -- > G. Paul Ziemba > FreeBSD unix: > 10:11AM up 12 days, 20:50, 10 users, load averages: 0.16, 0.18, 0.19 > > > Please, no C++ comments in wine, use standard C /* comments */ instead. -- -Austin

1 0

Packagers: consider not packaging wine-1.1.12, or cherrypicking fixes
by Dan Kegel 06 Jan '09

06 Jan '09

wine-1.1.12 has a couple regressions in it: http://bugs.winehq.org/show_bug.cgi?id=16754 http://bugs.winehq.org/show_bug.cgi?id=16732 http://bugs.winehq.org/show_bug.cgi?id=16708 Please consider either cherrypicking the fixes, or skipping wine-1.1.12.

3 2

Re: wined3d: Fix a memory leak in compile_state_table()
by Rico Schüller 06 Jan '09

06 Jan '09

Allan Tong schrieb: > Wrong pointer was being passed to HeapFree. > > - Allan > > Why did you remove these two lines? Was this your intention? - dev_multistate_funcs[cur[i].state][0] = multistate_funcs[cur[i].state][0]; - dev_multistate_funcs[cur[i].state][1] = multistate_funcs[cur[i].state][1]; Cheers Rico

3 2

Re: [shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x
by Rob Shearman 06 Jan '09

06 Jan '09

2009/1/6 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > For some reason this only shows up when I use my own cross compiled tests. > > Changelog > ILFree() is only exported by ordinal on Win9x ILFree is exported using -noname in Wine, so it should be imported by ordinal. You need to investigate further as to why it isn't working for you. I suggest to start by running "winedump dump -j import shell32_crosstest.exe". -- Rob Shearman

3 3

Unused function in winhttp
by Francois Gouget 06 Jan '09

06 Jan '09

Hi, In the following commit you added the netconn_set_timeout() function to net.c. However today it is unused. Is there any plan to use it? Is it still relevant? commit 266c4b2c046b334ca44cdc1826c4434625dcb29f Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Aug 26 11:03:19 2008 +0200 winhttp: Add networking infrastructure. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

2 1

Updated wine64 page
by Dan Kegel 06 Jan '09

06 Jan '09

I updated http://wiki.winehq.org/Wine64 to no longer recommend pulling from Maarten's tree, since doing so made the instructions more complex, and the main tree does just about as good at passing conformance tests (maybe modulo a hang or two). - Dan

1 0

Re: wow32: add -noname property to WOWGetDescriptor spec
by Alistair Leslie-Hughes 06 Jan '09

06 Jan '09

Hi, > diff --git a/dlls/wow32/wow32.spec b/dlls/wow32/wow32.spec > index 227120b..4d2d6d1 100644 > --- a/dlls/wow32/wow32.spec > +++ b/dlls/wow32/wow32.spec > @@ -1,5 +1,5 @@ > # ordinal exports > -1 stdcall WOWGetDescriptor(long long) > +1 stdcall -nonanme WOWGetDescriptor(long long) spelling mistake. Best Regards Alistair Leslie-Hughes _________________________________________________________________ Net yourself a bargain. Find great deals on eBay. http://a.ninemsn.com.au/b.aspx?URL=http%3A%2F%2Frover%2Eebay%2Ecom%2Frover%…

1 0

Re: oleaut32: Only dump the EMF if tracing fixmes for the ole channel.
by Vincent Povirk 05 Jan '09

05 Jan '09

> + if (FIXME_ON(ole)) > + { > + FIXME("Unknown magic %04x, %d read bytes:\n",magic,xread); > + hr=E_FAIL; This changes the behavior of the call based on what debug channels are enabled. I don't think you want to do that.

1 0

Re: Testing DIB Engine (second part)
by Jeff Zaroyko 05 Jan '09

05 Jan '09

On Wed, Dec 24, 2008 at 11:23 AM, Massimo Del Fedele <max(a)veneto.com> wrote: > Here the second part, it contains winedib.drv code and changes to Makefiles. > > Still no way to enable/disable the engine, besides of deleting the .so > inside dlls/winedib.drv. > > I'll wait for some feedback before going fourther. > > Ciao > > Max > Instead of deleting it, you could simply set winedib.drv to disabled in winecfg? -Jeff

4 5

Re: [1/2] sfc: Export by ordinal and add missing exports.
by Alexandre Julliard 05 Jan '09

05 Jan '09

Hans Leidekker <hans(a)codeweavers.com> writes: > SfcIsKeyProtected is not exported from my copy of sfc.dll. I think > it was added by mistake in commit 7dbe9a6728064172a9d9edac484f90c421156785. It's exported on Vista. Also please don't make up names for ordinal functions, use anonymous entry points ('@') until we find out the real name. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: dlls/dinput/effect_linuxinput.c: Check return value of 'write'. (bug # 16413)
by Dan Kegel 05 Jan '09

05 Jan '09

Vitaliy Margolen wrote: >> titon barua wrote: >>> - write(*(This->fd), &event, sizeof(event)); >>> + if (write(*(This->fd), &event, sizeof(event)) == -1) perror ( NULL ); >> What's the point of your patch? What part of the comment isn't clear to you? > >GCC is complaining about the ignored return value. As Alexandre implied in http://www.winehq.org/pipermail/wine-devel/2009-January/071769.html one should not fix these warnings casually. A real fix probably involves actually handing the error rather than printing a warning. The last thing we need is an army of people papering over compiler warnings. - Dan

2 2

Re: widl: Also arrays need NULL pointer checks.
by Alexandre Julliard 05 Jan '09

05 Jan '09

Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> writes: > This is still not complete. No NULL pointer checks are emitted for parameters > that are aliases to pointers or arrays. This adds checks in places where midl doesn't have them. It breaks the service tests for instance. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/dinput/effect_linuxinput.c: Check return value of 'write'. (bug # 16413)
by Vitaliy Margolen 05 Jan '09

05 Jan '09

titon barua wrote: > --- > /* we don't care about the success or failure of this call */ > - write(*(This->fd), &event, sizeof(event)); > + /* print errors if they occur */ > + if (write(*(This->fd), &event, sizeof(event)) == -1) perror ( NULL ); What's the point of your patch? What part of the comment isn't clear to you? Also don't use perror. Wine has ERR(), WARN(), TRACE() macros for that. Vitaliy

6 6

Re: widl: Make to interfaces RPC_FC_OP instead of RPC_FC_RP
by Rob Shearman 05 Jan '09

05 Jan '09

2009/1/4 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > This eliminates the wrong null pointer check for pointers to interfaces. This isn't correct. Object pointers are generated, I believe, in the case where we have an [in, out] unique pointer, since if the pointer has been set to NULL the previous memory needs to be freed (on the client side). The correct fix for the problem you see is to implement (yet another) check in cant_be_null. -- Rob Shearman

1 0

Re: widl: use base pointer type instead of default if not overwritten.
by Rob Shearman 05 Jan '09

05 Jan '09

2009/1/4 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/tools/widl/proxy.c b/tools/widl/proxy.c > index f0e3f1d..0e5cbaf 100644 > --- a/tools/widl/proxy.c > +++ b/tools/widl/proxy.c > @@ -185,6 +185,11 @@ int needs_null_check(const var_t *v) > > if (type) > { > + if (type->type == RPC_FC_FP || > + type->type == RPC_FC_OP || > + type->type == RPC_FC_UP) > + return 0; > + > attrs = type->attrs; > type = type->ref; > } Looks good, although we should always use the type set in the type object, rather than trying to guess from the attributes. I plan to clean this up in the near future so you don't need to change the patch unless you want to. -- Rob Shearman

1 0

MaxVertexBlendMatrices, multi-matrix vertex blending and D3DX
by Paul TBBle Hampson 05 Jan '09

05 Jan '09

This is a bit of an old topic, but it relates to two active bugs, 8357 (affecting Everquest) and 14608 (affecting Warhammer Online) The rough summary of the situation is that these two games use d3dx9_30 and d3dx9_34 respectively, and at least the former uses ConvertToIndexedBlendedMesh. Anyway, they both show an odd behaviour where if the device caps report MaxVertexBlendMatrices <= 2 (or <2 maybe) then the d3dx apparently generates odd behaviour and unrecognised vertex entries, the upshot being that the character's vertices all end up on the ground at the model's world transform. If MaxVertexBlendMatrices is > 2 then the vertices come out fine, and everything seems to work. A d3d trace from Warhammer Online indicates that D3DRS_VERTEXBLEND is only ever set to 0 (only tested up to the character select screen, which is the first screen where the bug is visible) both with and without the patch. From what I understand from here and on MSDN, indexed multimatrix blending in the fixed function pipeline is generally emulated except on certain older ATI Radeon cards, so I guess that D3DX ConvertToIndexedBlended actually ends up emulating the index blending without actually using the D3DRS_VERTEXBLEND renderstates. The current workaround is to patch Wine to report MaxVertexBlendMatrices 4, but that will cause bad behaviour in programs that do use the multimatrix vertex blending, as I understand. Anyway, what I'm wondering is would it be worth throwing together a patch that implements the multimatrix blending in drawStridedSlow for cards that don't support ARB_VERTEX_BLEND (ie all of them under Linux) If this is sensible, any pointers towards the right thing to do would be greatly appreciated, this isn't an area I'm massively experienced in. The only other option I'm aware of is to await the shader-based fixed function pipeline replacement which might contain an implementation of the D3DRS_VERTEXBLEND renderstates. The last time I'm aware of this being discussed was [1], in February last year. [1] http://www.winehq.org/pipermail/wine-devel/2008-February/062433.html -- ----------------------------------------------------------- Paul "TBBle" Hampson, B.Sc, LPI, MCSE Very-later-year Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson(a)Pobox.com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.5/au/ -----------------------------------------------------------

2 1

Re: dlls/dinput/effect_linuxinput.c: Check return value of 'write'. (bug # 16413)
by Vitaliy 04 Jan '09

04 Jan '09

titon barua wrote: > --- > /* we don't care about the success or failure of this call */ > - write(*(This->fd), &event, sizeof(event)); > + /* print errors if they occur */ > + if (write(*(This->fd), &event, sizeof(event)) == -1) perror ( NULL ); What's the point of your patch? What part of the comment isn't clear to you? Also don't use perror. Wine has ERR(), WARN(), TRACE() macros for that. Vitaliy

1 0

re: Patch implementing riched20 : EM_PASTESPECIAL -- critique?
by Dan Kegel 04 Jan '09

04 Jan '09

Hi, and welcome to Wine development! Two notes on your patch: 1) does treating CF_TEXT as a CF_UNICODETEXT work? 2) you don't include a conformance test. Conformance tests are really, really helpful. I bet you could write one for this feature. Please give it a shot, and make sure the test passes on Windows. - Dan

2 1

install-wine-deps.sh can now handle 32 bit wine on 64 bit systems
by Dan Kegel 04 Jan '09

04 Jan '09

I just improved http://code.google.com/p/winezeug/source/browse/trunk/install-wine-deps.sh so it does all the futzing needed to build 32 bit wine on 64 bit systems (although at the moment it only does this for Ubuntu Intrepid). Because it puts the missing .so files in /usr/lib32, there's no need to futz with LDPATH. For example, after running the script, you can do either ./configure make to build 64 bit wine, or ./configure --target=i686-unknown-gnu-linux make to build 32 bit wine. Easy beans! - Dan

2 2

long in IDL files?
by Michael Stefaniuc 04 Jan '09

04 Jan '09

Hello guys, i guess that we need to change long to LONG in IDL files too, right? Or would that be something that widl could/should do automatically? bye michael

3 3

Linus Torvalds on Wine back in 1998
by Dan Kegel 04 Jan '09

04 Jan '09

http://fringe.davesource.com/Fringe/Computers/Linux/Manifesto.txt It's taken longer than he expected... --- snip --- WINE (the Linux emulator for Windows) works to a fairly surprising degree. You can run real Windows programs with it, but some of them don't look right, and some of them just crash. But it has been making big progress in the last year, and now you can actually run Word for Windows. It doesn't work for everybody and there are known bugs, but it's almost becoming usable. I doubt people will wake up and say, "Hey, let's get rid of the shackles of Microsoft and switch to Linux and WINE." But there are going to be more and more people who discover they really want the networking abilities of Linux, or who run a web server on it. WINE slowly expands the group of people who would find Linux or some other operating system acceptable because they really don't care about Microsoft per se; they care about a few programs. In a few years WINE will be good enough that you can actually consider running Linux instead of Windows. It won't take over 100% of the market, but that's OK, too, because when you don't have one major entity that owns most of the market, it's a much saner, competitive environment. I think that'll happen, regardless of Linux. --- snip ---

1 0

Re: Build wine with gcc-4.3 and ssp
by Stefan Reimer 04 Jan '09

04 Jan '09

> On Sat, Jan 03, 2009 at 07:52:10PM +0100, Stefan Reimer wrote: >> > On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: >> I am using gentoo hardened: >> >> gcc (Gentoo Hardened 4.3.2-r7 p1.5, ssp, fortify, pie-10.2.0) 4.3.2 glibc 2.8 >> >> Using gcc -v gives: >> >> /usr/libexec/gcc/x86_64-pc-linux-gnu/4.3.2/cc1 -quiet -v -I. -I. >> -I../include -I../include -imultilib 32 preloader.c -D_FORTIFY_SOURCE=2 -fPIE -fstack-protector -fstack-protector-all -fno-strict-overflow -quiet >> -dumpbase preloader.c -m32 -march=athlon64 -auxbase-strip preloader.o -O2 >> -Wall -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -version -fno-strict-aliasing -o - | >> /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.2/../../../../x86_64-pc-linux-gnu/bin/as -V -Qy --32 -o preloader.o - >> >> The hardened gcc specs brings in -fPIE, which is similiar to -fPIC. >> >> So YES I do ;-) >> >> Is this a problem ? > > -fPIE is a bit useless for the preloader (wine-preloader is actually loaded at a fixed > address), but it should not fail to build I guess. > > Does Wine still work afterwards? > > I don't see the patch hurting anything though. > > Ciao, Marcus > Hi, -fPIE is introduced by using the gentoo hardened profile and is applied everywhere possible. I think wine should be able to be build with -fPIE, despite not improving security be any means. Wine works like a charm btw. Sry for the double postings! Cyas Stefan

1 0

Re: shell32: add explorer toolbar bitmaps
by Juan Lang 04 Jan '09

04 Jan '09

> so I just cutted icons from other toolbars' bitmaps; Which other toolbars, specifically? You can't grab copyrighted work, you know. --Juan

6 12

Re: libs/wine/debug.c: enlcosed a 'write' function with 'if' to prevent gcc warnings. 'if' does nothing cause program exits right after the statement anyway. (bug # 16413)
by Alexandre Julliard 04 Jan '09

04 Jan '09

titon barua <titanix88(a)gmail.com> writes: > @@ -177,7 +177,8 @@ static void debug_usage(void) > "Example: WINEDEBUG=+all,warn-heap\n" > " turns on all messages except warning heap messages\n" > "Available message classes: err, warn, fixme, trace\n"; > - write( 2, usage, sizeof(usage) - 1 ); > + /* enclosed in 'if' statement to prevent gcc warnings */ > + if (write( 2, usage, sizeof(usage) - 1 )); Please don't do that sort of thing. That's much worse than the warning. -- Alexandre Julliard julliard(a)winehq.org

1 0

Use of "patch" keyword in Bugzilla
by Vitaliy Margolen 04 Jan '09

04 Jan '09

Moving this conversation to wine-devel. > What |Removed |Added > ---------------------------------------------------------------------------- > Keywords|patch | > > ------- Comment #7 From Vitaliy Margolen 2009-01-03 19:47:16 [reply] ------- > > Patch keyword is for patches attached to bugs only and not sent to > wine-patches. > > ------- Comment #8 From Austin English 2009-01-03 20:01:55 [reply] ------- > > (In reply to comment #7) >> Patch keyword is for patches attached to bugs only and not sent to >> wine-patches. >> > > It's still useful, e.g., if patch is not accepted. No it's not. The intension of that keyword was to fish all the patches out of buzilla and resubmit them to wine-patches. Or serve as a base for someone to improve upon. With mixing the two you make it nearly useless as most bugs will have it eventually. Especially all fixed ones. IMHO not even outright hacks should have "patch" keyword set. Yes they give an idea of where the problem is. But they are nothing more then investigation into the cause of the problem. Vitaliy.

2 1

Re: include: Change RPC_STATUS from long to LONG for Win64 compatibility.
by James Hawkins 04 Jan '09

04 Jan '09

On Sat, Jan 3, 2009 at 4:49 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > Also fix the compiler warnings introduced by this change. > > diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c > index 5d0b15e..8ef0a5f 100644 > --- a/dlls/advapi32/crypt.c > +++ b/dlls/advapi32/crypt.c > @@ -305,7 +305,7 @@ static void CRYPT_CreateMachineGuid(void) > '%','0','2','x','%','0','2','x', > '%','0','2','x',0 }; > > - pUuidCreate = GetProcAddress(lib, "UuidCreate"); > + pUuidCreate = (void *)GetProcAddress(lib, "UuidCreate"); > rs = pUuidCreate(&uuid); > if (rs == S_OK) > { Inadvertent change? -- James Hawkins

2 1

Re: widl: fix handling of [local] functions without [call_as]
by Rob Shearman 04 Jan '09

04 Jan '09

2009/1/3 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > @@ -548,8 +548,9 @@ static int write_proxy_methods(type_t *iface, int skip) > if (iface->funcs) LIST_FOR_EACH_ENTRY( cur, iface->funcs, const func_t, entry ) { > var_t *def = cur->def; > if (!is_callas(def->attrs)) { > + if (i != cur->idx ) error("widl internal error: method index mismatch"); > if (i) fprintf(proxy, ",\n"); > - if (skip) print_proxy( "0 /* %s_%s_Proxy */", iface->name, get_name(def)); > + if (skip || is_local(def->attrs)) print_proxy( "0 /* %s_%s_Proxy */", iface->name, get_name(def)); > else print_proxy( "%s_%s_Proxy", iface->name, get_name(def)); > i++; > } This will now cause methods with the [local] attribute and with a matching [call_as] method to no longer be included in the function table, which isn't what you want. -- Rob Shearman

2 1

Patch implementing riched20 : EM_PASTESPECIAL -- critique?
by Arren Lex 04 Jan '09

04 Jan '09

Hello, all; Attached is a patch that implements the EM_PASTESPECIAL riched20 message, which pastes with a specified clipboard format -- http://msdn.microsoft.com/en-us/library/bb774214(VS.85).aspx Because there is (apparently) no ANSI clipboard implemented, the CF_TEXT clipboard format pastes garbage, so I have put in a workaround which treats a CF_TEXT as a CF_UNICODETEXT call. It prints a fixme when it does this, and when the ANSI clipboard is implemented the "if" block can simply be taken out to start using it. This patch was written to fix bug 14530 -- http://bugs.winehq.org/show_bug.cgi?id=14530 It is made against git commit bf25837eb7c08dc7faf13b886f6aed79a02506b8 (the tagging of 1.1.12) which is the latest at the time of writing. This is my first ever patch, and I am not familiar with wine or riched20 at all, so I would love to have some feedback about it before I submit it to the patches list. Can anyone suggest improvements? Thank you, - Alexander Dorokhine

1 1

Re: Build wine with gcc-4.3 and ssp
by Stefan Reimer 04 Jan '09

04 Jan '09

> On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: >> Hi, >> to build wine using gcc 4.3 with enabled ssp (stack-smashing-protector) the following patch must be applied to loader/preloader.c >> >> see gcc source ./gcc/config/i386/i386.c around line 24391 >> >> /* For 32-bit code we can save PIC register setup by using >> __stack_chk_fail_local hidden function instead of calling >> __stack_chk_fail directly. 64-bit code doesn't need to setup any PIC >> register, so it is better to call __stack_chk_fail directly. */ >> >> Patch: >> >> diff --git a/loader/preloader.c b/loader/preloader.c >> index 5fcb974..1143972 100644 >> --- a/loader/preloader.c >> +++ b/loader/preloader.c >> @@ -163,6 +163,7 @@ void __bb_init_func(void) { return; } >> >> /* similar to the above but for -fstack-protector */ >> void *__stack_chk_guard = 0; >> +void __stack_chk_fail_local(void) { return; } >> void __stack_chk_fail(void) { return; } >> >> /* data for setting up the glibc-style thread-local storage in %gs */ > > Hmm, > > why does this work for me on openSUSE then? > > The line: > gcc -c -I. -I. -I../include -I../include -Wall -pipe > -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -W type-limits -Wpointer-arith -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funw > ind-tables -fasynchronous-unwind-tables -g -o preloader.o preloader.c > > works fine here. Are you passing in -fPIC? > > Ciao, marcus > > > Hi, I am using gentoo hardened: gcc (Gentoo Hardened 4.3.2-r7 p1.5, ssp, fortify, pie-10.2.0) 4.3.2 glibc 2.8 Using gcc -v gives: /usr/libexec/gcc/x86_64-pc-linux-gnu/4.3.2/cc1 -quiet -v -I. -I. -I../include -I../include -imultilib 32 preloader.c -D_FORTIFY_SOURCE=2 -fPIE -fstack-protector -fstack-protector-all -fno-strict-overflow -quiet -dumpbase preloader.c -m32 -march=athlon64 -auxbase-strip preloader.o -O2 -Wall -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -version -fno-strict-aliasing -o - | /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.2/../../../../x86_64-pc-linux-gnu/bin/as -V -Qy --32 -o preloader.o - The hardened gcc specs brings in -fPIE, which is similiar to -fPIC. So YES I do ;-) Is this a problem ? Cyas Stefan

2 2

REALLY EXCITING! wine iexplore.exe http://pyjs.org/examples/
by Luke Kenneth Casson Leighton 04 Jan '09

04 Jan '09

aww folks - bless you :) if all of these worked, then it means that mshtml is coming along _really_ well! i went through the kitchen sink example, and it passed - everything - with flying colours. the library unit test - passes everything! even the SVG canvas (in the addons) works! i was _just_ about to get _really_ excited, when i ran the JSONRPC example, but awwwww, i got this: fixme:mshtml:nsUploadChannel_SetUploadStream Unsupported aContentType argument: "application/x-www-form-urlencoded" darn, darn :) if that had worked first time, it would have been _unbelievable_ - and _so_ exciting. i liked especially the way that internet explorer is detected as Mozilla-compatible. to support IE's javascript features _would_ perhaps bit a _little_ too much :) but the real purpose of this message is to say WELL XXXXING DONE! l.

2 1

question on how to do language bindings to MSHTML's COM interface
by Luke Kenneth Casson Leighton 03 Jan '09

03 Jan '09

folks, hi, i have a rather intriguing issue i'd like to look at, which takes quite a bit of explaining as to why i'd like to go about it - if people are interested i can answer that, but for now i'll leave it at this: how, under linux, would i go about making an application that made _use_ of MSHTML.DLL's functionality, via its COM / DCE/RPC / MSRPC interface? in other words, if you are familiar with gecko / XUL, how would i go about making a gecko / XUL style of application, using MSHTML as the basis, and, once that was achieved, would it stand a chance of successfully running under vanilla windows, using MS's own version of MSHTML? yes i _am_ fully aware that, underneath, according to the wiki page on mshtml's implementation, mshtml underneath uses Gecko - but i don't _want_ to use the Gecko / XUL interface (mostly because it already exists! i don't like challenges that have already been done :) specifically, i'd _really_ like to have python bindings to the COM bindings to MSHTML - all under linux. so there are some _really_ weird esoteric "sub-questions" involved, such as: "what are the chances of porting pywin32 - specifically pywin32's COM bindings - to linux, thanks to widl and friends"? see http://sourceforge.net/projects/pywin32 many thanks for any advice and information. l.

2 4

[PATCH] Compile fix on Linux 2.6.28 / x86
by Pavel Troller 03 Jan '09

03 Jan '09

Hi! Due to changes in Linux kernel include file structure, the following patch is necessary to compile wine with the 2.6.28 kernel: --- wine/dlls/ntdll/serial.c.old 2009-01-03 19:31:17.000000000 +0100 +++ wine/dlls/ntdll/serial.c 2009-01-03 20:31:11.000000000 +0100 @@ -74,6 +74,10 @@ #include "wine/debug.h" #ifdef HAVE_LINUX_SERIAL_H +#include <linux/version.h> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28) +#include <asm/types.h> +#endif #include <linux/serial.h> #endif With regards, Pavel Troller

3 3

Re: Build wine with gcc-4.3 and ssp
by Marcus Meissner 03 Jan '09

03 Jan '09

On Fri, Jan 02, 2009 at 11:14:52PM +0100, Stefan Reimer wrote: > Hi, > to build wine using gcc 4.3 with enabled ssp (stack-smashing-protector) > the following patch must be applied to loader/preloader.c > > see gcc source ./gcc/config/i386/i386.c around line 24391 > > /* For 32-bit code we can save PIC register setup by using > __stack_chk_fail_local hidden function instead of calling > __stack_chk_fail directly. 64-bit code doesn't need to setup any PIC > register, so it is better to call __stack_chk_fail directly. */ > > Patch: > > diff --git a/loader/preloader.c b/loader/preloader.c > index 5fcb974..1143972 100644 > --- a/loader/preloader.c > +++ b/loader/preloader.c > @@ -163,6 +163,7 @@ void __bb_init_func(void) { return; } > > /* similar to the above but for -fstack-protector */ > void *__stack_chk_guard = 0; > +void __stack_chk_fail_local(void) { return; } > void __stack_chk_fail(void) { return; } > > /* data for setting up the glibc-style thread-local storage in %gs */ Hmm, why does this work for me on openSUSE then? The line: gcc -c -I. -I. -I../include -I../include -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -W type-limits -Wpointer-arith -march=i586 -mtune=i686 -fmessage-length=0 -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funw ind-tables -fasynchronous-unwind-tables -g -o preloader.o preloader.c works fine here. Are you passing in -fPIC? Ciao, marcus

2 2

Re: kernel32: implement CPU detection for OpenBSD
by Rob Shearman 03 Jan '09

03 Jan '09

2009/1/3 Austin English <austinenglish(a)gmail.com>: > diff --git a/dlls/kernel32/cpu.c b/dlls/kernel32/cpu.c > index 63ca277..10a8e87 100644 > --- a/dlls/kernel32/cpu.c > +++ b/dlls/kernel32/cpu.c > @@ -544,7 +544,7 @@ VOID WINAPI GetSystemInfo( > } > fclose (f); > } > -#elif defined (__NetBSD__) > +#elif defined (__NetBSD__) || defined(__OpenBSD__) > { > int mib[2]; > int value[2]; Why not just do something like the following: #ifdef __OpenBSD___ size_t value[2]; #else int value[2]; #endif And then you wouldn't have to ifdef each sysctl call. > @@ -557,31 +557,55 @@ VOID WINAPI GetSystemInfo( > #ifdef CPU_FPU_PRESENT > mib[1] = CPU_FPU_PRESENT; > value[1] = sizeof(int); > - if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) > +#ifdef __OpenBSD__ > + if (sysctl(mib, 2, value, (size_t *)(value+1), NULL, 0) >= 0) { > +#else > + if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) { > +#endif ... -- Rob Shearman

2 1

App Database Ratings
by Keith Muir 03 Jan '09

03 Jan '09

Recently read the thread on the poor quality of the ratings but changing the wording isn't going to have much of an effect. A properly structured questionnaire that then suggests a rating will. The problem with this is the amount of work required to overhaul the database in order to do it. That said the ratings are instead of being objective, which is what wine users and developers want, subjective and nearly useless.

2 1

Fwd: [Wine] Look for a Wine Expert to Possibly hire....
by Austin English 03 Jan '09

03 Jan '09

For those of you that don't read wine-users: ---------- Forwarded message ---------- From: BaseHead <wineforum-user(a)winehq.org> Date: Sat, Jan 3, 2009 at 4:18 AM Subject: [Wine] Look for a Wine Expert to Possibly hire.... To: wine-users(a)winehq.org Hey all! We make a Sound FX Database Program called BaseHead for windows. www.baseheadinc.com we would love to make it run on OS X and Linux with Wine. I did already get it up and running via Crossover which I saw is based on WINE which bought me here. It runs pretty chunky using Crossover tho.........8( We are looking to possibly hire someone to make us an all in one BaseHead/Wine Installer that is optimized to run under OS X and Linux that is custom for us. Basically we'd need someone that knows quite a bit about wine to tell us what will works good and what doesn't and if it's even possible. AND if we need to change certain coding to make it run better and what pitfalls to avoid etc.... if anyone one is interested send me an email steve 'AT' baseheadinc 'DOT' com or go to the site and use the contact forum thx!! Steve -- -Austin

1 0

Re: [PATCH 2/3] fusion: Add tests for the IAssemblyEnum interface. [try4]
by Alexandre Julliard 03 Jan '09

03 Jan '09

"James Hawkins" <truiken(a)gmail.com> writes: > Now handling different ordering of directory listings. It doesn't work here: ../../../tools/runtest -q -P wine -M fusion.dll -T ../../.. -p fusion_test.exe.so asmenum.c && touch asmenum.ok asmenum.c:445: Test failed: Expected "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0", got "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d" asmenum.c:479: Test failed: Expected "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d", got "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0" asmenum.c:492: Test failed: Expected "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0", got "Wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d" asmenum.c:573: Test failed: Expected "wine, Version=1.0.0.0, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d", got "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0" asmenum.c:586: Test failed: Expected "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=123456789abcdef0" or "wine, Version=1.0.1.2, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d", got "wine, Version=1.0.0.0, Culture=neutral, PublicKeyToken=16a3fcd171e93a8d" make: *** [asmenum.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

libwine.so "incompatible"???
by Luke Kenneth Casson Leighton 03 Jan '09

03 Jan '09

rob, anyone - any ideas? gcc -pthread -shared -o libpython2.5.so Modules/_typesmodule.o Modules/getbuildinfo.o Parser/acceler.o Parser/grammar1.o Parser/listnode.o Parser/node.o Parser/parser.o Parser/parsetok.o Parser/bitset.o Parser/metagrammar.o Parser/firstsets.o Parser/grammar.o Parser/pgen.o Parser/myreadline.o Parser/tokenizer.o Objects/abstract.o Objects/boolobject.o Objects/bufferobject.o Objects/cellobject.o Objects/classobject.o Objects/cobject.o Objects/codeobject.o Objects/complexobject.o Objects/descrobject.o Objects/enumobject.o Objects/exceptions.o Objects/genobject.o Objects/fileobject.o Objects/floatobject.o Objects/frameobject.o Objects/funcobject.o Objects/intobject.o Objects/iterobject.o Objects/listobject.o Objects/longobject.o Objects/dictobject.o Objects/methodobject.o Objects/moduleobject.o Objects/object.o Objects/obmalloc.o Objects/rangeobject.o Objects/setobject.o Objects/sliceobject.o Objects/stringobject.o Objects/structseq.o Objects/tupleobject.o Objects/typeobject.o Objects/weakrefobject.o Objects/unicodeobject.o Objects/unicodectype.o Python/Python-ast.o Python/asdl.o Python/ast.o Python/bltinmodule.o Python/ceval.o Python/compile.o Python/codecs.o Python/errors.o Python/frozen.o Python/frozenmain.o Python/future.o Python/getargs.o Python/getcompiler.o Python/getcopyright.o Python/getmtime.o Python/getplatform.o Python/getversion.o Python/graminit.o Python/import.o Python/importdl.o Python/marshal.o Python/modsupport.o Python/mystrtoul.o Python/mysnprintf.o Python/pyarena.o Python/pyfpe.o Python/pystate.o Python/pythonrun.o Python/structmember.o Python/symtable.o Python/sysmodule.o Python/traceback.o Python/getopt.o Python/pystrtod.o Python/dynload_shlib.o Python/thread.o Modules/config.o Modules/getpath.o Modules/main.o Modules/gcmodule.o Modules/threadmodule.o Modules/signalmodule.o Modules/posixmodule.o Modules/errnomodule.o Modules/pwdmodule.o Modules/_sre.o Modules/_codecsmodule.o Modules/zipimport.o Modules/symtablemodule.o Modules/xxsubtype.o -lpthread -ldl -lutil -lwine -lm; \ fi /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/4.3.2/../../../../lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib/../lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-linux-gnu/4.3.2/../../../libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/bin/../lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib64/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/lib/libwine.so when searching for -lwine /usr/bin/ld: cannot find -lwine collect2: ld returned 1 exit status

1 2

Re: winedbg: add a crash dialog for --auto mode (3rd try)
by Mikołaj Zalewski 03 Jan '09

03 Jan '09

Is there something wrong with this patch?

1 0

Re: richedit: Mask window id on WM_COMMAND notifications.
by Dmitry Timoshkov 03 Jan '09

03 Jan '09

"Dylan Smith" <dylan.ah.smith(a)gmail.com> wrote: > - SendMessageA(GetParent(hWnd), WM_COMMAND, (nCode<<16)|GetWindowLongW(hWnd, GWLP_ID), (LPARAM)hWnd); > + SendMessageA(GetParent(hWnd), WM_COMMAND, (nCode<<16)|(0xffff & GetWindowLongW(hWnd, GWLP_ID)), (LPARAM)hWnd); MAKEWPARAM and LOWORD are supposed to be used here. Also, have you tested what happens if real window id is larger than a 16-bit value, or just a negative 16-bit one? -- Dmitry.

2 1

Re: start.exe: don't use the NO_UI flag when invoked with /unix
by Austin English 03 Jan '09

03 Jan '09

On Fri, Jan 2, 2009 at 6:30 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > This makes it possible to get feedback when something goes wrong starting a non-exe file through a Linux gui. > > > You forgot the patch ;-). -- -Austin

1 0

Re: start.exe: don't use the NO_UI flag when invoked with /unix
by James Hawkins 03 Jan '09

03 Jan '09

On Fri, Jan 2, 2009 at 4:30 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > This makes it possible to get feedback when something goes wrong starting a non-exe file through a Linux gui. > Forgot the patch. -- James Hawkins

1 0

Status of dxdiagn?
by Dan Kegel 03 Jan '09

03 Jan '09

Hi Markus, what's the status of dxdiagn these days? I see a number of games that say they need a native copy: http://www.google.com/search?q=dxdiagn+site%3Aappdb.winehq.org Do you know what needs doing before we can get native dxdiag working, http://bugs.winehq.org/show_bug.cgi?id=1429 ? Also, how about your dxdiagn conformance test? http://www.winehq.org/pipermail/wine-patches/2008-May/055355.html I know it didn't do much, maybe you could have it check a few required properties? I ask because I'm looking around for a student project, and implementing dxdiag.exe came to mind; looking around a bit, I saw dxdiagn, and figured it might be nice to tie up some loose ends there, too. - Dan

2 6

Re: [PATCH] oleaut32: PICTYPE_ICON returns EFAIL for get_hPal (try 2)
by Robert Reif 03 Jan '09

03 Jan '09

Jon Griffiths wrote: > Hi, > > Smaller patch with properly static-ified icon data. > > Cheers > Jon > > > > ------------------------------------------------------------------------ > > Did this patch get dropped for a reason?

1 0

Re: [shell32 5/6] include: Add remotable stubs for non-default-marshallable shobjidl calls.
by Rob Shearman 02 Jan '09

02 Jan '09

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/include/shobjidl.idl b/include/shobjidl.idl > index a647798..c36f4ce 100644 > --- a/include/shobjidl.idl > +++ b/include/shobjidl.idl > @@ -452,6 +452,9 @@ interface IShellView : IOleWindow > [in] LPFNSVADDPROPSHEETPAGE pfn, > [in] LPARAM lparam); > > + [call_as(AddPropertySheetPages)] > + HRESULT RemoteAddPropertySheetPages(); > + > HRESULT SaveViewState(); > HRESULT SelectItem( > [in] LPCITEMIDLIST pidlItem, > @@ -582,6 +585,9 @@ cpp_quote("#endif") > [in] LPARAM lParam, > [in] LRESULT *pret); > > + [call_as(SendControlMsg)] > + HRESULT RemoteSendControlMsg(); > + > HRESULT QueryActiveShellView( [out] IShellView **ppshv ); > HRESULT OnViewWindowActive( [in] IShellView *pshv ); > > @@ -590,6 +596,8 @@ cpp_quote("#endif") > [in] LPTBBUTTONSB lpButtons, > [in] UINT nButtons, > [in] UINT uFlags); > + [call_as(SetToolbarItems)] > + HRESULT RemoteSetToolbarItems(); These shouldn't be necessary. What is it that you're trying to fix? > } > > > @@ -1441,9 +1449,12 @@ interface IAutoCompleteDropDown : IUnknown > { > cpp_quote("#define ACDD_VISIBLE 0x0001") > > - HRESULT GetDropDownStatus( > + [local] HRESULT GetDropDownStatus( > [out] DWORD *pdwFlags, > - [out, string] LPWSTR *ppwszString); > + [out] LPWSTR *ppwszString); > + > + [call_as(GetDropDownStatus)] > + HRESULT RemoteGetDropDownStatus(); This isn't correct. IAutoCompleteDropDown::GetDropDownStatus should be remoted as is. > > HRESULT ResetEnumerator(); > } -- Rob Shearman

2 4

Re: Implemented retrieval of szDeviceIdentifier property in dxdiagn
by Vitaliy Margolen 02 Jan '09

02 Jan '09

Markus wrote: Few problems with your patch: > + IDirect3D9 *(WINAPI *pDirect3DCreate9)(UINT) = NULL; > + IDirect3D9 *pD3d = NULL; No need to initialize something you'll assign to anyway. > + d3d9_handle = LoadLibraryA( "d3d9.dll" ); You need to unload it when you done. > + memset(&adapter_ident, 0, sizeof(adapter_ident)); No need to clear this structure. > + StringFromGUID2(&adapter_ident.DeviceIdentifier, adapter_ident_str, 39); Why don't you put it directly into szIdentifierBuffer? > + memcpy( szIdentifierBuffer, adapter_ident_str, sizeof(adapter_ident_str) * sizeof(WCHAR) ); sizeof() gives size in bytes. You don't need to multiply it by sizeof(WCHAR). > + WCHAR deviceIdentBuffer[256]; First why 256 if all you need is 39? Second, why do you need it at all? There is already "buffer" which is big enough. > + DXDiag_GetDisplayDeviceIdentifier( &deviceIdentBuffer ); You don't need to take a reference from array. It's already a pointer (remove "&"). Any time you pass array like that you should also pass it's size. Vitaliy.

1 0

Re: [4/5] wined3d: Convert some BOOLs to bitfields in struct IWineD3DDeviceImpl.
by Rob Shearman 02 Jan '09

02 Jan '09

2008/12/30 Henri Verbeet <hverbeet(a)codeweavers.com>: > > > From f6e4f88407491db8bb53d22d526f69b9ff761aaf Mon Sep 17 00:00:00 2001 > From: Henri Verbeet <hverbeet(a)codeweavers.com> > Date: Tue, 30 Dec 2008 14:56:49 +0100 > Subject: wined3d: Convert some BOOLs to bitfields in struct > IWineD3DDeviceImpl. > > Also fills a 3 byte hole. > --- > dlls/wined3d/device.c | 17 +++++---------- > dlls/wined3d/nvidia_texture_shader.c | 2 +- > dlls/wined3d/state.c | 4 +- > dlls/wined3d/wined3d_private.h | 36 > ++++++++++++++++----------------- > 4 files changed, 26 insertions(+), 33 deletions(-) How many instances of this structure are likely to be in a process at any one time? It seems to me as though as any memory savings gained by making the BOOLs into bitfields will be taken up by increased code size. There is also the risk that there will be a small performance penalty for this and the other similar changes too. These kinds of optimisations need to be backed up by benchmarks, for both memory and performance. -- Rob Shearman

2 1

Ubuntu popcon trivia
by Dan Kegel 02 Jan '09

02 Jan '09

Did you know that almost as many people have Wine installed as have Sun's Java 6 installed? wget http://popcon.ubuntu.com/by_inst.gz gunzip by_inst.gz awk '/wine |sun-java6-jre/' by_inst | head rank name inst vote old recent old-files 1208 sun-java6-jre 390519 68179 313376 7354 1610 (Matthias Klose) 1321 wine 338377 42513 282338 13460 66 (Scott Ritchie) The highest 'inst' value in the file is 871814, so it looks like about 39% of machines subscribed to popcon have wine installed.

2 1

Re: widl: print error on [out, string] without size_is
by Michael Karcher 01 Jan '09

01 Jan '09

Am Donnerstag, den 01.01.2009, 11:22 +0100 schrieb Michael Karcher: > The old behaviour was to emit a half-complete C statement without > any error message. This patch is bad. Please ignore. Regards, Michael Karcher

1 0

Re: ole32: Add HICON user marshalling stubs
by Rob Shearman 01 Jan '09

01 Jan '09

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec > index 79376ac..f7db2b0 100644 > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -122,6 +122,10 @@ > @ stdcall HBITMAP_UserMarshal(ptr ptr ptr) > @ stdcall HBITMAP_UserSize(ptr long ptr) > @ stdcall HBITMAP_UserUnmarshal(ptr ptr ptr) > +@ stdcall HICON_UserFree(ptr ptr) > +@ stdcall HICON_UserMarshal(ptr ptr ptr) > +@ stdcall HICON_UserSize(ptr long ptr) > +@ stdcall HICON_UserUnmarshal(ptr ptr ptr) > @ stub HBRUSH_UserFree > @ stub HBRUSH_UserMarshal > @ stub HBRUSH_UserSize The functions should be added in the correct place so that the list of functions remains sorted. -- Rob Shearman

1 0

Re: [oleaut 1/3] include: add [unique] attributes to IPropertyBag::RemoteRead args
by Rob Shearman 01 Jan '09

01 Jan '09

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/include/oaidl.idl b/include/oaidl.idl > index 1cc166a..4ee3b43 100644 > --- a/include/oaidl.idl > +++ b/include/oaidl.idl > @@ -1620,9 +1620,9 @@ interface IPropertyBag : IUnknown > HRESULT RemoteRead( > [in] LPCOLESTR pszPropName, > [out] VARIANT *pVar, > - [in] IErrorLog *pErrorLog, > + [in, unique] IErrorLog *pErrorLog, > [in] DWORD varType, > - [in] IUnknown *pUnkObj); > + [in, unique] IUnknown *pUnkObj); In the PSDK only pErrorLog is a unique pointer. However, I believe you are making this change to avoid getting RPC_X_NULL_REF_POINTER exceptions when a NULL pErrorLog parameter is passed into IPropertyBag_Read, but MIDL ignores the pointer type for interface pointers and never outputs a NULL reference pointer check for them. So widl just needs to be fixed. > > HRESULT Write( > [in] LPCOLESTR pszPropName, -- Rob Shearman

2 2

Re: [oleaut 3/3] oleaut32: Implement IPropertyBag::Read proxying
by Rob Shearman 01 Jan '09

01 Jan '09

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > + hr = IPropertyBag_RemoteRead_Proxy(This, pszPropName, &outVariant, pErrorLog, > + V_VT(pVar), pUnk); > + if(SUCCEEDED(hr)) > + hr = VariantCopy(pVar, &outVariant); > + > + return hr; You're leaking the memory in outVariant here, since VariantCopy does a deep copy of all of the data. Is there a reason you don't just pass pVar into IPropertyBag_RemoteRead_Proxy? -- Rob Shearman

2 2

Re: [oleaut 2/3] include: Add [unique] attribute to IPersistPropertyBag::Load arg
by Rob Shearman 01 Jan '09

01 Jan '09

2009/1/1 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > diff --git a/include/ocidl.idl b/include/ocidl.idl > index c40d155..d4979d7 100644 > --- a/include/ocidl.idl > +++ b/include/ocidl.idl > @@ -927,7 +927,7 @@ interface IPersistPropertyBag : IPersist > > HRESULT Load( > [in] IPropertyBag *pPropBag, > - [in] IErrorLog *pErrorLog); > + [in,unique] IErrorLog *pErrorLog); > > HRESULT Save( > [in] IPropertyBag *pPropBag, Same goes for this change. -- Rob Shearman

1 0

Drumming up qa publicity for sketchup on wine via Digg
by Dan Kegel 01 Jan '09

01 Jan '09

Sketchup seems to be working pretty well, so I just posted http://digg.com/linux_unix/Google_Sketchup_7_working_in_Wine_1_1_11 to see if I could attract some real sketchup users to find more bugs. If folks agree that's a good idea, they can support it by digging it so it can show up on the front page. Thanks, Dan

2 2

Contribution to the Toolbar common control
by Alan Feldman 01 Jan '09

01 Jan '09

Hello Wine developers, I am writing to this forum because I wanted to contribute some useful development information to your community while at the same time not have to get too involved as I currently have no plans to stay involved going forward. I wanted to say that I am *really* impressed with the codebase that you guys have developed! I stumbled across the Winehq site as I was looking for more information on Microsoft's Toolbar common control. The source code you guys have has made understanding the internals of the Toolbar control really easy and I really appreciate the work you guys have done. (I even took a peek at Microsoft's comctl32.dll disassembly to confirm a couple of the things you guys wrote and it checked out) ;-) So, anyway, in gratitude for what you guys have provided me I wanted to "give something back". I noticed that there are several Toolbar window messages which are listed as "unknown" which at the time of the writing of this e-mail are now definitely "known" and I would like to provide that information to someone to check in to your source code base. Here is my contribution: http://source.winehq.org/source/dlls/comctl32/toolbar.c Function: ToolbarWindowProc() TB_UNKWN45E is really TB_SETHOTITEM2 (WM_USER + 94) TB_UNKWN460 is really TB_SETLISTGAP (WM_USER + 96) TB_UNKWN462 is really TB_GETIMAGELISTCOUNT (WM_USER + 98) TB_UNKWN463 is really TB_GETIDEALSIZE (WM_USER + 99) TB_UNKWN467 (which is not in the Wine source yet) is really TB_GETITEMDROPDOWNRECT (WM_USER + 103) Those Toolbar window messages are currently not in the public Windows headers at this time but they have been *documented* on the MSDN Library web site now. Here are links to the MSDN Library help topics giving evidence to what I wrote up above: http://msdn.microsoft.com/en-us/library/cc835036(VS.85).aspx http://msdn.microsoft.com/en-us/library/bb787441(VS.85).aspx http://msdn.microsoft.com/en-us/library/cc835034(VS.85).aspx http://msdn.microsoft.com/en-us/library/cc835033(VS.85).aspx http://msdn.microsoft.com/en-us/library/cc835035(VS.85).aspx Also, in this source file: http://source.winehq.org/source/include/commctrl.h Someone took a REALLY good guess at the name of a Toolbar notification! TBN_WRAPHOTITEM is definitely the name of notification TBN_FIRST- 24. Good guess! I would say that the comment about this message being undocumented and just a "guess" can now be removed. Even though this message is also not in any public header file, this message is now *documented* and the documentation can be found here: http://msdn.microsoft.com/en-us/library/cc835032(VS.85).aspx Cheers! :-) Alan Feldman

3 5

Commit stats
by Hans Leidekker 01 Jan '09

01 Jan '09

$ for year in {2002..2008}; do \ count=$( git log | grep ^Date: | grep $year | wc -l ); \ echo "Number of commits in $year: $count"; \ done Number of commits in 2002: 3094 Number of commits in 2003: 3283 Number of commits in 2004: 3851 Number of commits in 2005: 6006 Number of commits in 2006: 8431 Number of commits in 2007: 9532 Number of commits in 2008: 11292 -Hans

3 2

Shell32 proxies/stubs
by Michael Karcher 01 Jan '09

01 Jan '09

Hello developers, this is just to let you know where the 3 standalone patches and three patch series I just posted to wine-devel are going: Having proxies for the COM objects of shell32.dll in actxprxy.dll, just as Windows XP and Vista does. It started with me wanting a guinea pig object that is apartment threaded and has proxies/stubs and present on every Windows installation to test a strange corner case in ole32. Looking around in my XP, I decided to use the MyComputer object that is already used in the ole32 testcase. Then I found out that Windows has them, but Wine misses them and thought to myself: Hey, this is just COM, adding a proxy should be just adding some lines to Makefile.in and widl does the rest. It turned out to be a quite fun project that revealed problems and/or missing features at nearly every component involved. The things I sent up to now fix most of the things below the proxies. What is still unsent is a three-patch-series to actxprxy to really add the proxies, and testcases for the remoting. While the shelllink testcase passes on my system even with remote calls, the shlfolder testsuite does not work correctly yet, revealing even more issues with ole32/widl I'm currently attacking. Regards, Michael Karcher

1 0

Re: dlls/user32/dde_client.c warning fixes (RESEND)
by Alexandre Julliard 31 Dec '08

31 Dec '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > The current version likely is actually broken since the ! operator has > a higher priority than bitwise & in C. Unless someone really wanted to > use a very, hmm, unusual construct here? No, it's clearly not intended, but fixing this breaks the tests, this would need to be addressed first. -- Alexandre Julliard julliard(a)winehq.org

2 1

iPod synced with iTunes v7.6!
by Michael Siebert 31 Dec '08

31 Dec '08

Hallo Maarten! I'd like to reproduce iPhone access via Wine + iTunes, but your description is not detailed enough for me. How did you actually perform steps 1.-3.? Happy New Year, Michael

1 0

Re: winmm: Check param in joyConfigChanged
by Alexandre Julliard 31 Dec '08

31 Dec '08

Christian Costa <titan.costa(a)wanadoo.fr> writes: > -MMRESULT WINAPI joyConfigChanged(DWORD flags) > +MMRESULT WINAPI joyConfigChanged(DWORD dwFlags) > { > - FIXME("(%x) - stub\n", flags); > + FIXME("(%x) - stub\n", dwFlags); > + > + if (dwFlags) > + return JOYERR_PARMS; There's no reason to rename the parameter, 'flags' is a perfectly good name. -- Alexandre Julliard julliard(a)winehq.org

2 2

Please add glut to winetricks :)
by Couannette 31 Dec '08

31 Dec '08

Hi Dan, I found winetricks very helpful ! Thank you for this very nice script ;). Could you please add glut [1] to the packages winetricks knows about ? Thank you very much, Couannette [1] http://www.opengl.org/resources/libraries/glut/glut_downloads.php

1 0

Ouch.
by Dan Kegel 31 Dec '08

31 Dec '08

http://enquiringmimes.com/wp/2008/12/30/a-rumor-we-hope-is-true/ said "WINE is the famous, this-would-be-so-cool-if-it-only-actually-worked way of running Windows on other platforms without needing Windows, kind of like how useful it might be to have your blood pumped through your body without needing a heart."

3 2

re: winhttp: Correctly parse specified ports in WinHttpCrackUrl
by Dan Kegel 31 Dec '08

31 Dec '08

Hi Paul, you wrote > Depends on my previous patch: winhttp/tests:... The way we usually express that is to prefix each patch with its position in the series of patches. For instance, your two-patch series might have used subject lines [1/2] winhttp/tests: Add tests for WinHttpCrackUrl port number handling [2/2] winhttp: Correctly parse specified ports in WinHttpCrackUrl I like how you broke out the tests into a first patch. (These days it's probably also ok to just include both the tests and and the implementation in a single patch if you prefer.) - Dan

2 1

re: CreateScalableFontResourceW
by Dan Kegel 31 Dec '08

31 Dec '08

I think Jeremy only worked on it in his spare time, and probably took a break from it after his September patch wasn't accepted. Does his 10/19 patch series make your app work? - Dan

2 1

Re: kernel32: Add GetProductInfo() stub & defines.
by Alistair Leslie-Hughes 31 Dec '08

31 Dec '08

Hi Andrew, "Andrew Riedi" wrote in message news:689de9370812301624l74fc94f9xc200587f8f07c70a@mail.gmail.com... >This patch helps bug #15638. ( http://bugs.winehq.org/show_bug.cgi?id=15638 ) > >Changelog: >kernel32: Add GetProductInfo() stub & defines. > >Based on a patch by Alexander Nicolaysen Sørnes. >@ stdcall lstrlenA(str) >@ stdcall lstrlenW(wstr) >+@ stdcall GetProductInfo(long long long long ptr) We try to keep the spec file in alphabetical order. Its in the right section, just needs to be moved up. Best Regards Alistair Leslie-Hughes _________________________________________________________________ Time for change? Find your ideal job with SEEK. http://a.ninemsn.com.au/b.aspx?URL=http%3A%2F%2Fninemsn%2Eseek%2Ecom%2Eau%2…

1 0

CreateScalableFontResourceW
by Colin Davis 30 Dec '08

30 Dec '08

Good Evening, Can anyone help me to understand what the Status of CreateScalableFontResource is? I had asked the IRC room, which directed me to wine-users, and wine-users directed me here. I have an application that uses CreateScalableFontResourceW to load a bundled font, and unfortunately, in 1.1.11 it fails to load. Looking at the souce for this method, it appears to be a stub in the current development version, but Jeremy White had created an implementation for it back in April (http://article.gmane.org/gmane.comp.emulators.wine.patches/49885) I can also see that as of 10/19, he was still working on the feature (http://article.gmane.org/gmane.comp.emulators.wine.devel/63872/match=create…) If anyone has been able to get this to work successfully, I'd love to hear about it, and to try to understand what the current blockers on this feature. Thanks for any advice, Colin

1 0

Wine 1.0 "one of the great Linux innovations of 2008"
by Dan Kegel 30 Dec '08

30 Dec '08

http://www.phoronix.com/scan.php?page=article&item=great_linux_innovations_… "WINE 1.0: When the WINE project began as a compatibility layer to run Windows programs atop Linux, the Windows 3.1 operating system was dominating the market. It took fifteen years for this free software project to come out with a version 1.0 release, but it reached this milestone in June. WINE now is able to run many Windows programs out there, and even many OpenGL / DirectX video games, but the development community has been continuing in a steadfast manner working to prepare the WINE 1.2 stable release for next year. WINE is now even being used by Google for their Picasa Linux port as well as other uses. Some of the progress that's been made this year following the 1.0 release has been support for Google Chrome, substantial JS support, X11 desktop work areas, the start of Direct3D 10.0 support, improved memory management, and many other features."

1 0

Wine Gecko packaging
by Jacek Caban 30 Dec '08

30 Dec '08

Hi, Now that we have a new Gecko, the work isn't done yet. All packages have to be updated. Wine can use only the new version now, so if a package contains an older version, it won't work and Gecko installer will be used instead. The update is as simple as providing the new file instead of the old one, so I believe it's not too much work. Note that for older Wine versions, older Gecko must be used. The problem is that we don't have a way to inform all packagers about updates (not all of them follow wine-devel) and it would be nice to have a communication channel so future releases won't have such problems. Austin suggested announcing on wine-announce. There are only a few people interested, so I could have a list of e-mail address or a Wiki page with e-mail addresses of interested people and send announcement e-mail directly. Please let me know, what works better. I know about followed affected packages: - Gentoo ebuild I've CCed maintainer. - Ubuntu package - Mandriva Marco was recently interested in providing a package - winetricks BTW, Dan, I think it's a good idea to have a Gecko option, but people should learn about http://wiki.winehq.org/Gecko if possible instead of depending on winetricks to do something that we already have implemented in Wine. I don't know about other distros, so please let me know if I've missed something. Thanks, Jacek

2 3

Re: [1/2] mshtml: Rename stucture to avoid name clash
by Jacek Caban 30 Dec '08

30 Dec '08

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > HTMLStyle clashes with one defined in the mshtml.h > > Changelog: > mshtml: Rename stucture to avoid name clash There is no need for renaming. I've sent a patch that fixes the clash. Jacek

1 0

RE: d3d9: Use the correct size for D3DFVF_XYZW [try 2]
by Stefan Dösinger 30 Dec '08

30 Dec '08

we have a similar, but not quite the same, routine in wined3d too, I think in device.c. It creates a wined3d vertex declaration from a FVF, while the d3d9 one creates a d3d9 declaration. Can you see if the wined3d routine is affected too? I didn't unify the wined3d and d3d9 code because we'd need need some wined3d->d3d9 decl backwards conversion which is probably as bug prone and maintainance heavy as an almost-clone of the FVF->decl conversion routine, and I dislike the idea of creating a d3d9 decl in wined3d. If anyone has a nice solution for this feel free to suggest it. > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Chris Robinson > Sent: Sunday, December 28, 2008 6:59 PM > To: wine-patches(a)winehq.org > Subject: d3d9: Use the correct size for D3DFVF_XYZW [try 2] > > Now with a test.

2 1

Please add glut to winetricks :)
by Michel Briand 30 Dec '08

30 Dec '08

Hi Dan, I found winetricks very helpful ! Thank you for this very nice script ;). Could you please add glut [1] to the packages winetricks knows about ? Thank you very much, Michel [1] http://www.opengl.org/resources/libraries/glut/glut_downloads.php

1 0

Wine Gecko packaging
by Jacek Caban 30 Dec '08

30 Dec '08

Hi, Now that we have a new Gecko, the work isn't done yet. All packages have to be updated. Wine can use only the new version now, so if a package contains an older version, it won't work and Gecko installer will be used instead. The update is as simple as providing the new file instead of the old one, so I believe it's not too much work. Note that for older Wine versions, older Gecko must be used. The problem is that we don't have a way to inform all packagers about updates (not all of them follow wine-devel) and it would be nice to have a communication channel so future releases won't have such problems. Austin suggested announcing on wine-announce. There are only a few people interested, so I could have a list of e-mail address or a Wiki page with e-mail addresses of interested people and send announcement e-mail directly. Please let me know, what works better. I know about followed affected packages: - Gentoo ebuild I've CCed maintainer. - Ubuntu package - Mandriva Marco was recently interested in providing a package - winetricks BTW, Dan, I think it's a good idea to have a Gecko option, but people should learn about http://wiki.winehq.org/Gecko if possible instead of depending on winetricks to do something that we already have implemented in Wine. I don't know about other distros, so please let me know if I've missed something. Thanks, Jacek

1 0

260 tests passing on win64!
by Dan Kegel 30 Dec '08

30 Dec '08

I updated http://wiki.winehq.org/Wine64 with easy instructions (thanks, Maarten!) for how to build wine's 64 bit support and try 64 bit pacman (which works!). And then I ran "make -k test". Surprisingly, I got 260 passing tests according to find . -name '*.ok' | wc and only 128 failed tests according to grep ok.*Error test.log | wc -l Ladies and gentlemen, I believe it's time for a 64 bit winetest.exe to be added to the daily build, and for 64 bit test data to start showing up at http://test.winehq.org. That would let us tamp down errors in the test suite on 64 bits. (Yeah, I know, gcc with win64 ABI isn't released yet, and there are problems with exception handling still, but it still seems worth it...) - Dan

2 2

Re: [1/2] mshtml: Rename stucture to avoid name clash
by Alexandre Julliard 30 Dec '08

30 Dec '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > static HRESULT WINAPI HTMLStyle_QueryInterface(IHTMLStyle *iface, REFIID riid, void **ppv) > { > - HTMLStyle *This = HTMLSTYLE_THIS(iface); > + HStyle *This = HTMLSTYLE_THIS(iface); A name like IHTMLStyleImpl would be a better choice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Henri Verbeet : secur32: Handle SECPKG_ATTR_STREAM_SIZES in schan_QueryContextAttributesW().
by Christian Costa 30 Dec '08

30 Dec '08

Hi, Compilation failed here (FC8), I got this error : gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o schannel.o schannel.c schannel.c:61: erreur: ‘gnutls_mac_get_key_size’ undeclared here (not in a function) schannel.c:61: attention : type defaults to ‘int’ in declaration of ‘pgnutls_mac_get_key_size’ schannel.c: In function ‘schan_QueryContextAttributesW’: schannel.c:856: erreur: called object ‘pgnutls_mac_get_key_size’ is not a function make[2]: *** [schannel.o] Erreur 1 Christian Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: 95fd8762665e65fedf7e2ede43e657f123dc4535 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=95fd8762665e65fedf7e2ede4… > > Author: Henri Verbeet <hverbeet(a)gmail.com> > Date: Sun Dec 28 22:21:35 2008 +0100 > > secur32: Handle SECPKG_ATTR_STREAM_SIZES in schan_QueryContextAttributesW(). > > --- > > dlls/secur32/schannel.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 64 insertions(+), 0 deletions(-) > > diff --git a/dlls/secur32/schannel.c b/dlls/secur32/schannel.c > index df5d56a..ed583d4 100644 > --- a/dlls/secur32/schannel.c > +++ b/dlls/secur32/schannel.c > @@ -48,6 +48,7 @@ MAKE_FUNCPTR(gnutls_alert_get); > MAKE_FUNCPTR(gnutls_alert_get_name); > MAKE_FUNCPTR(gnutls_certificate_allocate_credentials); > MAKE_FUNCPTR(gnutls_certificate_free_credentials); > +MAKE_FUNCPTR(gnutls_cipher_get); > MAKE_FUNCPTR(gnutls_credentials_set); > MAKE_FUNCPTR(gnutls_deinit); > MAKE_FUNCPTR(gnutls_global_deinit); > @@ -56,6 +57,8 @@ MAKE_FUNCPTR(gnutls_global_set_log_function); > MAKE_FUNCPTR(gnutls_global_set_log_level); > MAKE_FUNCPTR(gnutls_handshake); > MAKE_FUNCPTR(gnutls_init); > +MAKE_FUNCPTR(gnutls_mac_get); > +MAKE_FUNCPTR(gnutls_mac_get_key_size); > MAKE_FUNCPTR(gnutls_perror); > MAKE_FUNCPTR(gnutls_set_default_priority); > MAKE_FUNCPTR(gnutls_transport_set_errno); > @@ -800,14 +803,69 @@ static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextA( > return ret; > } > > +static unsigned int schannel_get_cipher_block_size(gnutls_cipher_algorithm_t cipher) > +{ > + const struct > + { > + gnutls_cipher_algorithm_t cipher; > + unsigned int block_size; > + } > + algorithms[] = > + { > + {GNUTLS_CIPHER_3DES_CBC, 8}, > + {GNUTLS_CIPHER_AES_128_CBC, 16}, > + {GNUTLS_CIPHER_AES_256_CBC, 16}, > + {GNUTLS_CIPHER_ARCFOUR_128, 1}, > + {GNUTLS_CIPHER_ARCFOUR_40, 1}, > + {GNUTLS_CIPHER_DES_CBC, 8}, > + {GNUTLS_CIPHER_NULL, 1}, > + {GNUTLS_CIPHER_RC2_40_CBC, 8}, > + }; > + unsigned int i; > + > + for (i = 0; i < sizeof(algorithms) / sizeof(*algorithms); ++i) > + { > + if (algorithms[i].cipher == cipher) > + return algorithms[i].block_size; > + } > + > + FIXME("Unknown cipher %#x, returning 1\n", cipher); > + > + return 1; > +} > + > static SECURITY_STATUS SEC_ENTRY schan_QueryContextAttributesW( > PCtxtHandle context_handle, ULONG attribute, PVOID buffer) > { > + struct schan_context *ctx; > + > TRACE("context_handle %p, attribute %#x, buffer %p\n", > context_handle, attribute, buffer); > > + if (!context_handle) return SEC_E_INVALID_HANDLE; > + ctx = schan_get_object(context_handle->dwLower, SCHAN_HANDLE_CTX); > + > switch(attribute) > { > + case SECPKG_ATTR_STREAM_SIZES: > + { > + SecPkgContext_StreamSizes *stream_sizes = (SecPkgContext_StreamSizes *)buffer; > + gnutls_mac_algorithm_t mac = pgnutls_mac_get(ctx->session); > + size_t mac_size = pgnutls_mac_get_key_size(mac); > + gnutls_cipher_algorithm_t cipher = pgnutls_cipher_get(ctx->session); > + unsigned int block_size = schannel_get_cipher_block_size(cipher); > + > + TRACE("Using %zu mac bytes, block size %u\n", mac_size, block_size); > + > + /* These are defined by the TLS RFC */ > + stream_sizes->cbHeader = 5; > + stream_sizes->cbTrailer = mac_size + 256; /* Max 255 bytes padding + 1 for padding size */ > + stream_sizes->cbMaximumMessage = 1 << 14; > + stream_sizes->cbBuffers = 4; > + stream_sizes->cbBlockSize = block_size; > + return SEC_E_OK; > + } > + > default: > FIXME("Unhandled attribute %#x\n", attribute); > return SEC_E_UNSUPPORTED_FUNCTION; > @@ -822,6 +880,9 @@ static SECURITY_STATUS SEC_ENTRY schan_QueryContextAttributesA( > > switch(attribute) > { > + case SECPKG_ATTR_STREAM_SIZES: > + return schan_QueryContextAttributesW(context_handle, attribute, buffer); > + > default: > FIXME("Unhandled attribute %#x\n", attribute); > return SEC_E_UNSUPPORTED_FUNCTION; > @@ -961,6 +1022,7 @@ void SECUR32_initSchannelSP(void) > LOAD_FUNCPTR(gnutls_alert_get_name) > LOAD_FUNCPTR(gnutls_certificate_allocate_credentials) > LOAD_FUNCPTR(gnutls_certificate_free_credentials) > + LOAD_FUNCPTR(gnutls_cipher_get) > LOAD_FUNCPTR(gnutls_credentials_set) > LOAD_FUNCPTR(gnutls_deinit) > LOAD_FUNCPTR(gnutls_global_deinit) > @@ -969,6 +1031,8 @@ void SECUR32_initSchannelSP(void) > LOAD_FUNCPTR(gnutls_global_set_log_level) > LOAD_FUNCPTR(gnutls_handshake) > LOAD_FUNCPTR(gnutls_init) > + LOAD_FUNCPTR(gnutls_mac_get) > + LOAD_FUNCPTR(gnutls_mac_get_key_size) > LOAD_FUNCPTR(gnutls_perror) > LOAD_FUNCPTR(gnutls_set_default_priority) > LOAD_FUNCPTR(gnutls_transport_set_errno) > > > > > >

3 3

Re: configure.ac: fix libpng detection on OpenBSD
by Vitaly Lipatov 30 Dec '08

30 Dec '08

В сообщении от 29 декабря 2008 Austin English написал(a): > then > - WINE_CHECK_SONAME(png,png_create_read_struct,,,-lm,[[libpng[[0-9]]*]]) > + WINE_CHECK_SONAME(png,png_create_read_struct,,,-lm > -lz,[[libpng[[0-9]]*]]) fi If libpng uses libz, package maintainer have to link it with libz, I do not sure we have to make workaround for libpng packaging bug. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

re: [PATCH 2/2] mshtml: Wine Gecko 0.9.0 release.
by Dan Kegel 30 Dec '08

30 Dec '08

Doesn't build here, did you forget mutation.c? make depend fails with: mutation.c: No such file or directory make[2]: *** [depend] Error 1 make[2]: Leaving directory `/home/dank/wine-git/dlls/mshtml'

2 1

Re: oleaut32: Correct the printf placeholder types.
by Austin English 29 Dec '08

29 Dec '08

On Mon, Dec 29, 2008 at 2:49 PM, Danny Rawlins <monster.romster(a)gmail.com> wrote: > Fix between unsigned and signed types this is my first wine patch but > you may already know me in irc as <Romster>. > > Also I don't find any -W compiler option to warn against incorrect > placeholders like using a int for a string. > > Thanks to <arethusa> for help, I am still learning C but have patched > many programs. > > Regards, > Danny Rawlins > > > > I think you want to use: CFLAGS="-Wsign-compare" -- -Austin

1 0

Re: [6/6] secur32: Implement schannel DecryptMessage().
by Rob Shearman 29 Dec '08

29 Dec '08

Sorry, this should have been in reply to patch [6/6]. 2008/12/29 Henri Verbeet <hverbeet(a)gmail.com>: > 2008/12/29 Rob Shearman <robertshearman(a)gmail.com>: >> 2008/12/28 Henri Verbeet <hverbeet(a)gmail.com>: >>> + while (received < data_size) >>> + { >>> + ret = pgnutls_record_recv(ctx->session, data + received, data_size - received); >>> + if (ret < 0) >>> + { >>> + if (ret == GNUTLS_E_AGAIN) >>> + { >>> + if (!received) >> >> Shouldn't this be "if (received == data_size)"? >> >>> + { >>> + pgnutls_perror(ret); >>> + HeapFree(GetProcessHeap(), 0, data); >>> + TRACE("Returning SEC_E_INCOMPLETE_MESSAGE\n"); >>> + return SEC_E_INCOMPLETE_MESSAGE; >>> + } >>> + break; >>> + } >>> + else >>> + { >>> + pgnutls_perror(ret); >>> + HeapFree(GetProcessHeap(), 0, data); >>> + ERR("Returning SEC_E_INTERNAL_ERROR\n"); >>> + return SEC_E_INTERNAL_ERROR; >>> + } >>> + } >>> + received += ret; >>> + } >> > The idea was to only return SEC_E_INCOMPLETE_MESSAGE if there's less > than one complete TLS record in the buffer, it shouldn't be a problem > to have eg. one complete message plus some bytes from the next one, > setting the buffer size further down is supposed to take care of that. Is it really expected for gnutls_record_recv to return GNUTLS_E_AGAIN on the first call and for the code to have to return that to the caller? That is what the code as it is at the moment does. It seems to me as though you should return SEC_E_INCOMPLETE_MESSAGE if you decrypted all of the data in the supplied buffer, but gnutls still returns GNUTLS_E_AGAIN. That then signals to the app to download more data and call DecryptMessage() again with the new data. -- Rob Shearman

2 1

Re: [5/6] secur32: Implement schannel EncryptMessage().
by Rob Shearman 29 Dec '08

29 Dec '08

2008/12/28 Henri Verbeet <hverbeet(a)gmail.com>: > + while (received < data_size) > + { > + ret = pgnutls_record_recv(ctx->session, data + received, data_size - received); > + if (ret < 0) > + { > + if (ret == GNUTLS_E_AGAIN) > + { > + if (!received) Shouldn't this be "if (received == data_size)"? > + { > + pgnutls_perror(ret); > + HeapFree(GetProcessHeap(), 0, data); > + TRACE("Returning SEC_E_INCOMPLETE_MESSAGE\n"); > + return SEC_E_INCOMPLETE_MESSAGE; > + } > + break; > + } > + else > + { > + pgnutls_perror(ret); > + HeapFree(GetProcessHeap(), 0, data); > + ERR("Returning SEC_E_INTERNAL_ERROR\n"); > + return SEC_E_INTERNAL_ERROR; > + } > + } > + received += ret; > + } -- Rob Shearman

2 1

re: New Wine Gecko
by Dan Kegel 29 Dec '08

29 Dec '08

Thanks, Jacek, we're really looking forward to it!

1 0

New Wine Gecko
by Jacek Caban 29 Dec '08

29 Dec '08

Hi, As there will be a new Gecko release soon, I'd like to give you a good background over what's going on as I feel that there is some misunderstanding on it that I'd like to clarify. I'm sorry for the long mail. First, let me give you a short history of the Gecko package. As we started using Gecko in our MSHTML implementation, we had to provide our own package and an easy way for its installation. I've prepared a package that actually was a temporary solution. It was a SeaMonkey build that had some files manually removed and modified to reduce its size. It was, of course, hacky and ugly but, as there was no urgent need for changing it, we used it for over a year. The next version was built by me. The build process was long and ugly - it needed a Windows installation and MSVC6. Except that I had to try many versions before finding one that worked fine for Wine, as it had both to compile with MSVC6 (back then they were switching to a newer compiler that needed actctx) and work with Wine (there were a few APIs that were not implemented in Wine that they started using). Also, there was the XULRunner project that looked promising but proved to not be good enough for us. I ended up with building the SeaMonkey target and, again, modifying and removing some files afterwards. Now, not only because of CS4 but because we really should follow new Gecko versions as well, the time to release a new package has come. The first decision was to try again by building with MinGW on Windows. I've tried it with limited success and then I found that Mozilla developers have recently worked on building Mozilla with MinGW under Linux (for code analyzers). That was something I hoped to do some day, so I gave it a try and it came out that it works better than compiling on Windows! Also XULRunner project has matured so that we may use it, avoiding other pains from previous packages. But not all is so good. Some changes introduced in the recent Gecko have prevented Wine from working correctly. It was unnoticed for long time because we were using the 1.8 branch, while the newest is 1.9. Because of it, I had to add serious patches (previous build had only minor changes in code) to fix it. I'm working with Mozilla developers to get these patches to official Gecko. We definitely want to avoid maintaining such differences. There are other advantages that will come with the new Gecko. I'm going to make a debug build that seems to work really well on Wine. Although it causes an assert in dbghelp that I didn't look at deeper, for one build I was even able to step through Gecko code with winedbg. Hopefully Valgrind will be happy with it. Also, I'm going to put the code to Git and provide a good building instruction. It's not trivial to build the package, but hopefully with some efforts everyone will be able to succeed with it. In this place I'd like to note: if you're not planning to work on Gecko (I mean not even MSHTML, but Gecko itself), there is no reason to do it. Also I know that some package maintainers would be interested in building it. Please, don't do it! You will realize that it is not possible with a fresh Linux installation without manually setting up environment. Also, due to its complexity, I'm worried about broken builds. I don't really see the reason to do it. If it's a matter of trust policy... well, you've trusted my builds for over three years now, so I'd like to ask you to keep trusting me... Also, I didn't really have a clear idea about version numbering. The first, temporary, package was numbered 0.0.1. The next one was 0.1.0 with plans to release 0.1.x if we'd release a new package on the same code base (there was 0.1.1 candidate that was never released). My plan was to release a package compiled under Linux as 1.0.0, and until then release next 0.x.y builds. Now that we compile the new package on Linux, I still don't like to call it 1.0.0, because of patches needed in our build. I'd prefer to wait with 1.0.0 hoping to fix the difference for next major release. I don't feel strongly about it so if anyone has any suggestion, I'm happy to change the plan. I plan to put Wine Gecko code into a public Git so developing it will be easier. Now releasing a new version should be much easier (as long as we won't find a new blocker, but if we'll find it quicker, it will be easier to fix). I'm happy with releasing the build I've written about a few days ago. I got feedback from Mozilla developer about things we could get to Mozilla tree and I'm going to try to get some patches to Mozilla. That shouldn't delay our release IMO, so I'm going to release tomorrow unless there are any objections. I hope to have another release in a few months that well be closer to main stream Gecko. Please let me know if you have any suggestion or question. Thanks, Jacek

1 0

Implementing dxdiag as student project?
by Dan Kegel 29 Dec '08

29 Dec '08

Hi folks, it seems odd to me that Wine doesn't have a tool like dxdiag yet. We often have people complain that graphics aren't working, and we have to ask them to do things like run glxgears as diagnostics. Would it make sense to implement our own dxdiag.exe program? This seems like it might be a fun student project. - Dan

8 19

Re: [PATCH 5/6] dinput: Fix usage of HeapReAlloc.
by Alexandre Julliard 28 Dec '08

28 Dec '08

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > + if (!have_joydevs) > + joydevs = HeapAlloc(GetProcessHeap(), 0, sizeof(struct JoyDev)); > + else > + joydevs = HeapReAlloc(GetProcessHeap(), 0, joydevs, (1 + have_joydevs) * sizeof(struct JoyDev)); > + > + if (!joydevs) > + { > + close(fd); > + continue; > + } While you are fixing it you should fix it properly by preserving the old pointer on failure. -- Alexandre Julliard julliard(a)winehq.org

2 1

wined3d: Do not treat oversized textures as failure
by Vincent Pelletier 28 Dec '08

28 Dec '08

Hi. Attached patch is enough to cure the failure in "Operation Flashpoint" when its menu is displayed on my little i945GM card. As the oversised case is (was) explicitely treated as a failure, I think there is some reasone for it. Does someone remember what it is for ? Regards, -- Vincent Pelletier

3 9

Re: xinput: Add stub XInputEnable
by Henri Verbeet 28 Dec '08

28 Dec '08

2008/12/28 Andrew Fenn <andrewfenn(a)gmail.com>: > +void WINAPI XInputEnable(bool enable) Does this compile? "bool" is a C++ type. Also, don't forget to add the prototype to the header, I noticed they're missing for all the other xinput functions as well.

4 6

Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size
by Vincent Pelletier 28 Dec '08

28 Dec '08

Woops, re-sending to list this time... On Wed, Dec 24, 2008 at 4:01 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > I think henri sent a reply. He recommended to clamp the new pointsize > instead of leaving the old one set. Found it. Wasn't subscribed here at that time (only to -patches). New version of previous patch is attached. > Of course a test would be interesting too, to see how windows behaves here. I'm not sure where to add it. I've added some line in d3d9/tests/visual.c:pointsize_test (attached too). As I wrote that test to succeed on wine and did not run it on any windows version, I would be happy if someone could try it. Note that this patch also contains a change from fix explained below (I'm not used to git enough yet to split patches...). Also, runing that test I had an unrelated failure in autogen_mipmap_test because texture creation failed in IWineD3DDeviceImpl_CreateTexture due to SFLAG_OVERSIZE being set at D3DCB_CreateSurface return. As I guess IWineD3DDeviceImpl_CreateTexture should then return a failure code, I patched it and made the test give up if texture allocation failed. (patch attached) I'm not sure if I chose the right error code. From MSDN, it can return: D3DERR_INVALIDCALL, D3DERR_OUTOFVIDEOMEMORY, E_OUTOFMEMORY If this change is OK, I will submit it separately from pointsize clamping. -- Vincent Pelletier

1 2

Re: wined3d: Make WARN about oversized texture output surface and texture sizes
by Henri Verbeet 28 Dec '08

28 Dec '08

2008/12/28 Vincent Pelletier <plr.vincent(a)gmail.com>: > + WARN("(%p) Creating an oversized surface: %ix%i\n", This, This->pow2Height, This->pow2Width); pow2Height and pow2Width are unsigned, so you'd want to use %u there.

2 1

Re: Assorted spelling fixes.
by Henri Verbeet 28 Dec '08

28 Dec '08

2008/12/28 Francois Gouget <fgouget(a)free.fr>: > - FIXME("No free constant found to load environemnt bump mapping matrix into the shader. texbem instruction will not apply bump mapping\n"); > + FIXME("No free constant found to load environement bump mapping matrix into the shader. texbem instruction will not apply bump mapping\n"); Shouldn't that be "environment"?

1 0

winecfg: Add dll override on return key press in combobox [resend]
by Andre Wisplinghoff 28 Dec '08

28 Dec '08

Thanks a lot for your hints, Reece and Dmitry. I didn't realize the difference between WndProcs and DlgProcs. I send a new try and hope everything is okay now :) http://www.winehq.org/pipermail/wine-patches/2008-December/066762.html -- Andre

1 0

Combining Fuse and Wine - What's the best way?
by Richard Stitz 28 Dec '08

28 Dec '08

I'm writing a program in which I have a Windows DLL that I need to load. The DLL contains a function that returns a pointer to some data, and I want to expose that data as file data in a Fuse file system. My first thought was that I could have the program load the DLL using winelib, but I'm not sure what's involved in this and whether the resulting program could also use the Fuse libraries. I'm a bit of a novice to Wine, and Linux programming in general, so I'd appreciate any expert opinions you guys have about the best way to do this. Thanks in advance, Richard

3 8

wine.budgetdedicated.com down?
by Dustin M. Jackson 28 Dec '08

28 Dec '08

Hi Scott, I'm trying to install Wine, but I cannot connect to the server. Just thought I would let you know. Regards, Dustin

1 0

Minimal patches to try win64?
by Dan Kegel 27 Dec '08

27 Dec '08

Out of curiosity, I finally bit the bullet, installed 64 bit Ubuntu 8.10, updated http://wiki.winehq.org/Wine64 to show how to build gcc, and built wine with win64 support enabled. It built successfully on the first try, but starting any conformance test or win64 app fails with wineserver: request.c:744: open_master_socket: Assertion `sizeof(union generic_request) == sizeof(struct request_max_size)' failed. I tried grabbing the patch that seems to fix that, http://repo.or.cz/w/wine/wine64.git?a=commitdiff_plain;h=6e77a4879d5e62a977… but then I got other errors. What's the minimal set of patches needed to start trying win64? I'd rather not pull Maarten's whole repo, I have no idea how closely that tracks winehq... - Dan

1 0

RE: Simplify dlls/comctl32/nativefont.c
by ricardo filipe 27 Dec '08

27 Dec '08

are you sure windows doesn't call those functions with those parameters? you have to check that before sending patches like these ... ---------------------------------------- > Date: Sat, 27 Dec 2008 08:57:44 +0100 > From: gerald(a)pfeifer.com > To: wine-patches(a)winehq.org > Subject: Simplify dlls/comctl32/nativefont.c > > ChangeLog: > Simplify NATIVEFONT_Create. > > Index: dlls/comctl32/nativefont.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/nativefont.c,v > retrieving revision 1.29 > diff -u -3 -p -r1.29 nativefont.c > --- dlls/comctl32/nativefont.c 24 Oct 2008 13:13:47 -0000 1.29 > +++ dlls/comctl32/nativefont.c 27 Dec 2008 07:57:10 -0000 > @@ -47,7 +47,7 @@ typedef struct > #define NATIVEFONT_GetInfoPtr(hwnd) ((NATIVEFONT_INFO *)GetWindowLongPtrW (hwnd, 0)) > > static LRESULT > -NATIVEFONT_Create (HWND hwnd, WPARAM wParam, LPARAM lParam) > +NATIVEFONT_Create (HWND hwnd) > { > NATIVEFONT_INFO *infoPtr; > > @@ -85,7 +85,7 @@ NATIVEFONT_WindowProc (HWND hwnd, UINT u > switch (uMsg) > { > case WM_CREATE: > - return NATIVEFONT_Create (hwnd, wParam, lParam); > + return NATIVEFONT_Create (hwnd); > > case WM_DESTROY: > return NATIVEFONT_Destroy (infoPtr); > > _________________________________________________________________ Show them the way! Add maps and directions to your party invites. http://www.microsoft.com/windows/windowslive/events.aspx

3 2

Wine build failed
by Stefan Leichter 27 Dec '08

27 Dec '08

Hello, building current git tree fails to me on Debian Etch (x86) with: ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o font.o ../../../wine-git/dlls/gdi32/font.c ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o freetype.o ../../../wine-git/dlls/gdi32/freetype.c ../../../wine-git/dlls/gdi32/freetype.c:187: error: expected declaration specifiers or ‘...’ before ‘FT_LcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c: In function ‘WineEngGetGlyphOutline’: ../../../wine-git/dlls/gdi32/freetype.c:4776: error: ‘FT_LcdFilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: (Each undeclared identifier is reported only once ../../../wine-git/dlls/gdi32/freetype.c:4776: error: for each function it appears in.) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: expected ‘;’ before ‘lcdfilter’ ../../../wine-git/dlls/gdi32/freetype.c:4777: warning: ISO C90 forbids mixed declarations and code ../../../wine-git/dlls/gdi32/freetype.c:4785: error: ‘lcdfilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4785: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_DEFAULT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_LIGHT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c: In function ‘is_subpixel_rendering_enabled’: ../../../wine-git/dlls/gdi32/freetype.c:5923: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ make[2]: *** [freetype.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/gdi32' make[1]: *** [gdi32] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-build/dlls' make: *** [dlls] Fehler 2 ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o font.o ../../../wine-git/dlls/gdi32/font.c ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o freetype.o ../../../wine-git/dlls/gdi32/freetype.c ../../../wine-git/dlls/gdi32/freetype.c:187: error: expected declaration specifiers or ‘...’ before ‘FT_LcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c: In function ‘WineEngGetGlyphOutline’: ../../../wine-git/dlls/gdi32/freetype.c:4776: error: ‘FT_LcdFilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: (Each undeclared identifier is reported only once ../../../wine-git/dlls/gdi32/freetype.c:4776: error: for each function it appears in.) ../../../wine-git/dlls/gdi32/freetype.c:4776: error: expected ‘;’ before ‘lcdfilter’ ../../../wine-git/dlls/gdi32/freetype.c:4777: warning: ISO C90 forbids mixed declarations and code ../../../wine-git/dlls/gdi32/freetype.c:4785: error: ‘lcdfilter’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4785: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_DEFAULT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c:4803: error: ‘FT_LCD_FILTER_LIGHT’ undeclared (first use in this function) ../../../wine-git/dlls/gdi32/freetype.c: In function ‘is_subpixel_rendering_enabled’: ../../../wine-git/dlls/gdi32/freetype.c:5923: error: too many arguments to function ‘pFT_Library_SetLcdFilter’ make[2]: *** [freetype.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/gdi32' make[1]: *** [gdi32] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-build/dlls' make: *** [dlls] Fehler 2

5 4

Re: [2/2] mshtml: Add VT_INT support in IHTMLElementCollection_item
by Jacek Caban 27 Dec '08

27 Dec '08

HI Konstantin, Konstantin Kondratyuk wrote: > VT_INT type isn't documented in MSDN, but it is supported in Windows > > You're duplicating the code that handles VT_I4 case. Please avoid it. Jacek

2 2

Re: winecfg: Add dll override on return key press in combobox [resend]
by Dmitry Timoshkov 27 Dec '08

27 Dec '08

"Andre Wisplinghoff" <andre.wisplinghoff(a)gmail.com> wrote: > +INT_PTR CALLBACK > +comboedit_wndproc (HWND hEdit, UINT uMsg, WPARAM wParam, LPARAM lParam) INT_PTR is wrong return value type for a window proc. > + /* subclass dllcombo's edit to allow return keypress handling */ > + GetComboBoxInfo(GetDlgItem(dialog, IDC_DLLCOMBO), &cbinfo); > + edit = cbinfo.hwndItem; /* retrieve edit box handle */ > + oldWndProc = (LONG_PTR)SetWindowLong(edit, GWL_WNDPROC, > + (DWORD) comboedit_wndproc); > + SetWindowLong(edit, GWL_USERDATA, (DWORD)oldWndProc); The code is above is not 64-bit safe. -- Dmitry.

3 3

Are OpenBSD bugs worth filing?
by David Gerard 27 Dec '08

27 Dec '08

Some of us on wine-users are trying to get Wine to install on OpenBSD. First, of course, we need to get it to compile on OpenBSD ... Are bugs on this platform considered valid reportable bugs? I couldn't find any OpenBSD bugs on a quick search in Bugzilla. State of things: it doesn't compile cleanly yet, and ./configure seems to fail to recognise a lot of libs that are in fact present. (I realise that running Windows on OpenBSD may cause a matter-antimatter explosion as the two security models meet ... But it has *hack value*!) - d.

4 5

Fwd: Wine on OpenBSD
by David Gerard 27 Dec '08

27 Dec '08

2008/12/27 Austin English <austinenglish(a)gmail.com>: > Would you mind starting a wiki page on this? > http://wiki.winehq.org/OpenBSD is empty at the moment. I've done ones > for OpenSolaris/PC-BSD, see: http://wiki.winehq.org/PC-BSD and > http://wiki.winehq.org/OpenSolaris > The wiki page would make it easier to track progress. http://wiki.winehq.org/OpenBSD - this incorporates most of the discussion from the thread on wine-users. Marcel, please add to it and file Wine on OpenBSD bugs as well. I've also done a page for VirtualBox (basically: VirtualBox is quite buggy, so bugs found in Wine running in a VirtualBox are as likely as not to be bugs in VirtualBox), which should probably become a more general page on why VMs aren't good to report bugs from. - d.

1 0

Wine bugs e-mails/spoofing warnings
by Austin English 27 Dec '08

27 Dec '08

Anyone else on gmail seeing this? It doesn't happen on all e-mails, only once every couple days (I've got digest mode enabled): "Due to a filter you created, this message was not sent to Spam. Edit Filters Warning: This message may not be from whom it claims to be. Beware of following any links in it or of providing the sender with any personal information. Learn more" -- -Austin

4 4

Bugzilla - CVS/GIT tag
by Austin English 26 Dec '08

26 Dec '08

In an effort to remove the CVS/GIT tag, I was going to go through and start changing the versions based on when the bug was filed. I.e., look at when 1.1.10 was out, and any bugs filed in those dates with CVS/GIT tag get moved to 1.1.10. I'm thinking of starting with 0.9, as anything before that is _really_ old and not worth the effort... Anyone opposed to this plan? Also, the FIXME, NoAppDBEntry, and BugBuster should probably be removed...they're not that useful anyway... -- -Austin

4 6

Re: feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function
by Henri Verbeet 26 Dec '08

26 Dec '08

2008/12/27 Stefan Dösinger <stefandoesinger(a)gmx.at>: >>anything wrong with the patch >>wined3d: Implement r5g6b5 to x8r8g8b8 function >>David > Probably alexandre wanted an ok from me. Can you resend the patch? > No, the patch was flawed. The author knows about this, and posted an improved patch to bugzilla (bug 18011). The improved patch is mostly ok, but doesn't round correctly, and could be made a bit faster by using a lookup table instead of recalculating everything all the time.

2 1

website: interviews / XML error: Mismatched tag
by Andre Wisplinghoff 26 Dec '08

26 Dec '08

Hi, for example at http://www.winehq.org/interview/14 you get 'XML error: Mismatched tag at line 9'. I'm sending a proposed patch here because last time I sent a website patch to wine-patches it wasn't applied and there was no reaction. wwn/en/interviews/interview_11.xml | 2 +- wwn/en/interviews/interview_12.xml | 2 +- wwn/en/interviews/interview_14.xml | 2 +- wwn/en/interviews/interview_15.xml | 2 +- wwn/en/interviews/interview_6.xml | 2 +- wwn/en/interviews/interview_9.xml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) -- Andre Wisplinghoff

1 0

Marshalling of remotable handles
by Michael Karcher 26 Dec '08

26 Dec '08

Hello Wine developers, while trying to add proxy/stub code for shell32, I stumbled across the definition of remotable handles in IDL. We have - a RemotableHandle union. - the IDL typedefs for the wire representation of handles: | typedef [unique] RemotableHandle *wireHXXX; - the IDL declaration for the handle types itself: | typedef [wire_marshal(wireHXXX)] void*HXXX; This makes widl generate null pointer checks for HWND parameters, as HXXX is a void pointer without the unique attribute. My question is: Should widl really add this check? As the type is marshalled as wireHXXX, the null value is no problem for marshalling, so it could be safely left out. What I did in my repository was adding the [unique] attribute to the IDL typedef of the handle type: | typedef [unique, wire_marshal(wireHXXX)] void*HXXX; Is this the right approach to generally get rid of the NULL pointer checks for handles, or is widl to be fixed instead? Best regards and thanks for advice, Michael Karcher

2 2

AW: feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function
by Stefan D�singer 26 Dec '08

26 Dec '08

>anything wrong with the patch >wined3d: Implement r5g6b5 to x8r8g8b8 function >David Probably alexandre wanted an ok from me. Can you resend the patch?

1 0

AW: [PATCH] Fix ddraw surface version setting (redux) (now withattachment)
by Stefan D�singer 26 Dec '08

26 Dec '08

Looks ok

1 0

feedback? wined3d: Implement r5g6b5 to x8r8g8b8 function
by paulo lesgaz 26 Dec '08

26 Dec '08

Hello, anything wrong with the patch wined3d: Implement r5g6b5 to x8r8g8b8 function David

1 0

Bugzilla's down
by Austin English 25 Dec '08

25 Dec '08

Newman/whomever else, if you're not busy with family etc., mind taking a look? Happy holidays everyone! -- -Austin

2 1

Re: oledlg: Implement OleUIAddVerbMenuA/W functions [resend]
by Vitaly Lipatov 25 Dec '08

25 Dec '08

В сообщении от 24 декабря 2008 Вы написали: > On Wed, Dec 24, 2008 at 5:49 AM, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > > Hello, > > > > Can anyone comment what bad with my > > OleUIAddVerbMenuA/W implementation. > > > > I know no one is interested in this function at your side, but it is > > really used function for more than one year. > > > > В сообщении от 20 декабря 2008 Vitaly Lipatov написал(a): > >> Real implementation of the OleUIAddVerbMenu function. > > > > -- > > Vitaly Lipatov, ALT Linux Team > > Russia, Saint-Petersburg, www.etersoft.ru > > Can you add a testcase for these functions? I know it is common question about testcase, but I think it does not means with this functions. Note, I do not fix some functions, I have implemented from scratch it instead stub. And my better test case is a popular account application used this functions. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

3 5

Re: [PATCH] Fix ddraw surface version setting (redux)
by Austin English 25 Dec '08

25 Dec '08

On Wed, Dec 24, 2008 at 8:48 PM, Nick Burns <adger44(a)hotmail.com> wrote: > > Resubmitting patch with correct email address and against tot wine > > > This fixes the d3d6 rendering problem reported by Ben Slackin against Wine 1.1.3 > http://appdb.winehq.org/objectManager.php?sClass=version&iId=8524 > http://img216.imageshack.us/img216/2764/shogoiz3.png > > > SHOGO got MAD when it was not able to find the mipmaps (due to incorrect version) > > > With this fix the game looks correct (well if you apply my other menu blt patch) > > > Changelog > Fix surface version setting > Mipmaps need to be properly versioned after creation > > > - Nick > > > You forgot the patch. -- -Austin

1 0

Re: [PATCH] Fix ddraw surface version setting (redux)
by Vincent Povirk 25 Dec '08

25 Dec '08

No attachment? Vincent Povirk

1 0

Re: gdi32: Correct order of matrix elements in World transform
by Konstantin Kondratyuk 25 Dec '08

25 Dec '08

Oops, this patch is not full. I think, there is code with bad index also: /* Extra transformation specified by caller */ if (lpmat && !is_identity_MAT2(lpmat)) { FT_Matrix extraMat; extraMat.xx = FT_FixedFromFIXED(lpmat->eM11); extraMat.xy = FT_FixedFromFIXED(lpmat->eM21); // <<<<<<< extraMat.yx = FT_FixedFromFIXED(lpmat->eM12); // <<<<<<< extraMat.yy = FT_FixedFromFIXED(lpmat->eM22); pFT_Matrix_Multiply(&extraMat, &transMat); pFT_Matrix_Multiply(&extraMat, &transMatUnrotated); needsTransform = TRUE; } What can I do? Send second fix? Or send "full" patch for both transformations? -- Best regards, Konstantin Kondratyuk.

2 1

Feedback needed
by Andre Wisplinghoff 25 Dec '08

25 Dec '08

Hi all, i need some feedback for my submitted patch (winecfg: Add a dll override instead of closing the dialog on pressing return in the combobox at 'libraries' tab): http://www.winehq.org/pipermail/wine-patches/2008-December/066619.html Thank you and Happy Holidays!! -- Andre Wisplinghoff

1 0

wine-1.2 release criteria?
by Dan Kegel 25 Dec '08

25 Dec '08

It's been six months since the release of 1.0, maybe now is a good time to review the 1.2 release criteria listed in http://www.winehq.org/wwn/353#WineConf%202008%20Keynote One big item that wasn't listed is "make asian users happy". I think we're starting to see some motion on that, cf. http://bugs.winehq.org/show_bug.cgi?id=16325 This is exciting... getting this fixed might bring in a lot of asian developers / testers / users. I'm nominating this one for 1.2. The criteria listed by Alexandre were: * Fix the remnant bugs from 1.0 (the new 1.2 bug milestone) * Better desktop integration with respect to transparency and desktop mode * Tests that pass Plus some 'nice to have' items. Would like at least one for 1.2: * DIB Engine * Quartz Driver * Direct3D 10 * USB Support (iPod, etc.) * 64-bit support Taking the one by one: - There are 83 open bugs nominated for 1.2: http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bu… We'll probably end up deferring a lot of these, and adding a few more. (If you think a bug not on this list needs adding to the list, add a comment to the bug saying "Nominating for 1.2.") - Better desktop integration with respect to transparency and desktop mode I don't know about this one, can somebody report on the status? - Tests that pass We're making progress here, but it's hard to quantify. http://test.winehq.org shows some runs still failing 20% of the tests, and others failing 0.3%, because we don't have a consistent set of machines running the tests. I would love to see that site add a feature showing the failure history for particular machines. Nice-to-have items: the last status update on these two months ago is at http://www.winehq.org/wwn/353#Updates%20on%20The%20Big%20Tickets:%20Quartz,… Here's what I know has changed since then: - DIB Engine As mentioned in http://www.winehq.org/wwn/354#Another%20shot%20at%20a%20DIB%20Engine Massimo picked up Jesse's DIB engine code and has been trying to use it with Autocad. He says he's starting to get fonts working. (It's surprising that he chose Jesse's 2007 implementation rather than Huw's 2008 implementation, but he said Jesse's seemed more usable at the moment, even though Huw's looked better in some ways). * Quartz Driver Any update? * Direct3D 10 Any update? And does anybody care? * USB Support (iPod, etc.) No motion here, I think. * 64-bit support Thanks to the gcc guy, Maarten, and Alexandre, "hello world" is working. Maarten is working on relay support now. These are exicting times for Wine... it doesn't feel like it's quite time to start a 1.2 release countdown, but maybe in a couple months.

8 12

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)
by Stefan Dösinger 25 Dec '08

25 Dec '08

This patch looks good. There's one last thing we should check: It seems that this is the only code that uses GL_PACK_ROW_LENGTH and friends, so the backup and restore is probably not needed. I think for now it is better to add it because I suspect the code in surface_download_data most likely depends on the default settings without properly controlling them. There's some related driver bug on OSX too(no radar filed yet, unfortunately). Using a PBO for glDrawPixels with a negative pixelzoom(wine uses -1 for y) breaks at least on my radeon X1600 with MacOS 10.5.5. I haven't yet tested it with 10.5.6, but if it is still broken there I have to remember to file a bug. It is sort of a follow-up bug to a bug fixed in 10.5.5; Before that glPixelZoom and PixelPos were completely ignored with PBOs. This bug was on my todo list for a long time by the way. I wanted to fix it, got distracted and forgot again :-/

3 6

Re: wineoss: Remove a superfluous semicolon
by Andrew Talbot 24 Dec '08

24 Dec '08

Or "wineoss.drv:...", to be precise.

1 0

WoW instantly crashes since commits on 23rd
by Jukka Tastula 24 Dec '08

24 Dec '08

Bisect gives me the following 878c2a83325b66cea79c24dc7379e5a6ee976044 is first bad commit commit 878c2a83325b66cea79c24dc7379e5a6ee976044 Author: Vincent Pelletier <plr.vincent(a)gmail.com> Date: Mon Dec 22 21:56:14 2008 +0100 user32: Fix SPI_GETMOUSESPEED and SPI_SETMOUSESPEED.

2 1

d3d9/visual tests timed out
by Rico Schüller 24 Dec '08

24 Dec '08

Hi, on my XP machine the visual d3d9 test produces a timeout message, when it is started from the winetest build. Anyone here could run the tests on windows without a timeout (and off course without skipping half of the tests - have to be more than 4k tests)? Also there is no message about a timeout on the test site ( http://test.winehq.org/data/028617b90ba586bdb30723c700eea888c159ada7/xp_rs-… ). Cheers Rico

4 4

[RFC] wined3d: Avoid triggering OPENGL errors when setting point size
by Vincent Pelletier 24 Dec '08

24 Dec '08

(Resent, originally sent to -patches... Sorry) If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render state is set to an invalid size, glPointSize will fail. This happens in "Black & White 2", causing log/stderr to be flooded with opengl errors. I'm not sure if this should be fixed here, or when setting state value. Also, maybe it should be avoided to double-check against opengl bounds when WINED3DRS_POINTSCALEENABLE is true. I would be happy to get some feedback on that patch. -- Vincent Pelletier

2 1

Re: oledlg: Implement OleUIAddVerbMenuA/W functions [resend]
by Vitaly Lipatov 24 Dec '08

24 Dec '08

Hello, Can anyone comment what bad with my OleUIAddVerbMenuA/W implementation. I know no one is interested in this function at your side, but it is really used function for more than one year. В сообщении от 20 декабря 2008 Vitaly Lipatov написал(a): > Real implementation of the OleUIAddVerbMenu function. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Testing DIB Engine (second part)
by Paul Vriens 24 Dec '08

24 Dec '08

Massimo Del Fedele wrote: > Here the second part, it contains winedib.drv code and changes to > Makefiles. > > Still no way to enable/disable the engine, besides of deleting the .so > inside dlls/winedib.drv. > > I'll wait for some feedback before going fourther. > > Ciao > > Max > > > ------------------------------------------------------------------------ > > Hi Max I don't think this should have gone to wine-patches but to wine-devel instead. After all it's a proof of concept and not a complete solution. Could you also zip these huge things up in the future (mail is now 1217KB)? -- Cheers, Paul.

3 3

Regression: Sound broken in PoP series
by M.Kiesel 24 Dec '08

24 Dec '08

Hi! The following commit breaks sound in (at least) Prince of Persia SoT and PoP TWW. Reece, let me know how I can help with that. commit ce06de420874b9983324508f8257a580fee341ca Author: Reece Dunn <msclrhd(a)googlemail.com> Date: Mon Dec 22 13:33:43 2008 +0000 dsound: Correct the dsound fraglen calculations. Regards

2 1

Re: [Wine] Re: MacOS X cocoa and carbon for Linux?
by James McKenzie 24 Dec '08

24 Dec '08

Richie wrote: > James McKenzie wrote: > >> hahomir4ev wrote: >> You might find a friendly discussion somewhere else on the >> implementation of Cocoa/Carbon on Linux, but this is not a topic of >> discussion here. >> James McKenzie >> > > Of cource it would be a completely unrelated project. Therefore the wine forum is not the right place for such a project. > BUT: Up to now there is no McWine or MINE project. Sad to say, but there IS a project for porting Wine to the PowerPC platform: Darwine. It has stalled and really could use help. It has forked so that there are two paths of development and the Intel fork is being worked back into the main Wine project. That leaves the PowerPC fork to be worked on to incorporate Qemu, an x86 emulator for the PowerPC. As to the Aqua 'look and feel' there is an effort to do this as well that may or may not need assistance. The goal in that project is to remove all Object C code and replace it with 'c' code equivalents. You can ask the status of that project on the Wine Development list. Again, this is not the area for discussing development of Wine. Let's move this to the appropriate venue. Thank you. James McKenzie

1 0

re: Symlink vulnerability in winetricks
by Dan Kegel 24 Dec '08

24 Dec '08

Stefan Nordhaus wrote: > Winetricks has a symlink vulnerability... Fixed in today's winetricks (20081223), thanks! - Dan

1 0

Trouble compiling today's git.
by Susan Cragin 24 Dec '08

24 Dec '08

Is anyone else having trouble compiling today's git? Or is it just my flu-addled brain? make[1]: Entering directory `/home/susan/wine/server' ../tools/makedep -C. -S.. -T.. async.c atom.c change.c class.c clipboard.c completion.c console.c context_alpha.c context_i386.c context_powerpc.c context_sparc.c context_x86_64.c debugger.c device.c directory.c event.c fd.c file.c handle.c hook.c mach.c mailslot.c main.c mapping.c mutex.c named_pipe.c object.c process.c procfs.c ptrace.c queue.c region.c registry.c request.c semaphore.c serial.c signal.c snapshot.c sock.c symlink.c thread.c timer.c token.c trace.c unicode.c user.c window.c winstation.c make[1]: Leaving directory `/home/susan/wine/server' make[1]: Entering directory `/home/susan/wine/server' ../tools/makedep -C. -S.. -T.. async.c atom.c change.c class.c clipboard.c completion.c console.c context_alpha.c context_i386.c context_powerpc.c context_sparc.c context_x86_64.c debugger.c device.c directory.c event.c fd.c file.c handle.c hook.c mach.c mailslot.c main.c mapping.c mutex.c named_pipe.c object.c process.c procfs.c ptrace.c queue.c region.c registry.c request.c semaphore.c serial.c signal.c snapshot.c sock.c symlink.c thread.c timer.c token.c trace.c unicode.c user.c window.c winstation.c make[1]: Leaving directory `/home/susan/wine/server' make[1]: Entering directory `/home/susan/wine/tools' make[2]: Entering directory `/home/susan/wine/tools/widl' ../../tools/makedep -C. -S../.. -T../.. client.c expr.c hash.c header.c proxy.c server.c typegen.c typelib.c utils.c widl.c write_msft.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/widl' make[2]: Entering directory `/home/susan/wine/tools/widl' ../../tools/makedep -C. -S../.. -T../.. client.c expr.c hash.c header.c proxy.c server.c typegen.c typelib.c utils.c widl.c write_msft.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/widl' make[2]: Entering directory `/home/susan/wine/tools/winebuild' ../../tools/makedep -C. -S../.. -T../.. import.c main.c parser.c relay.c res16.c res32.c spec16.c spec32.c utils.c make[2]: Leaving directory `/home/susan/wine/tools/winebuild' make[2]: Entering directory `/home/susan/wine/tools/winebuild' ../../tools/makedep -C. -S../.. -T../.. import.c main.c parser.c relay.c res16.c res32.c spec16.c spec32.c utils.c make[2]: Leaving directory `/home/susan/wine/tools/winebuild' make[2]: Entering directory `/home/susan/wine/tools/winedump' ../../tools/makedep -C. -S../.. -T../.. debug.c dos.c dump.c emf.c le.c lib.c lnk.c main.c minidump.c misc.c msc.c msmangle.c ne.c output.c pdb.c pe.c search.c symbol.c make[2]: Leaving directory `/home/susan/wine/tools/winedump' make[2]: Entering directory `/home/susan/wine/tools/winedump' ../../tools/makedep -C. -S../.. -T../.. debug.c dos.c dump.c emf.c le.c lib.c lnk.c main.c minidump.c misc.c msc.c msmangle.c ne.c output.c pdb.c pe.c search.c symbol.c make[2]: Leaving directory `/home/susan/wine/tools/winedump' make[2]: Entering directory `/home/susan/wine/tools/winegcc' ../../tools/makedep -C. -S../.. -T../.. utils.c winegcc.c make[2]: Leaving directory `/home/susan/wine/tools/winegcc' make[2]: Entering directory `/home/susan/wine/tools/winegcc' ../../tools/makedep -C. -S../.. -T../.. utils.c winegcc.c make[2]: Leaving directory `/home/susan/wine/tools/winegcc' make[2]: Entering directory `/home/susan/wine/tools/wmc' ../../tools/makedep -C. -S../.. -T../.. lang.c mcl.c utils.c wmc.c write.c mcy.y make[2]: Leaving directory `/home/susan/wine/tools/wmc' make[2]: Entering directory `/home/susan/wine/tools/wmc' ../../tools/makedep -C. -S../.. -T../.. lang.c mcl.c utils.c wmc.c write.c mcy.y make[2]: Leaving directory `/home/susan/wine/tools/wmc' make[2]: Entering directory `/home/susan/wine/tools/wrc' ../../tools/makedep -C. -S../.. -T../.. dumpres.c genres.c newstruc.c readres.c translation.c utils.c wrc.c writeres.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/wrc' make[2]: Entering directory `/home/susan/wine/tools/wrc' ../../tools/makedep -C. -S../.. -T../.. dumpres.c genres.c newstruc.c readres.c translation.c utils.c wrc.c writeres.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/wrc' ../tools/makedep -C. -S.. -T.. -I/usr/include/freetype2 fnt2bdf.c fnt2fon.c make_ctests.c makedep.c relpath.c sfnt2fnt.c make[1]: Leaving directory `/home/susan/wine/tools' ./tools/makedep -C. -S. -T. make[1]: Entering directory `/home/susan/wine/tools' make[1]: `makedep' is up to date. make[1]: Leaving directory `/home/susan/wine/tools' make[1]: Entering directory `/home/susan/wine/libs' make[2]: Entering directory `/home/susan/wine/libs/port' ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -h -H ../../include/wtypes.h ../../include/wtypes.idl make[2]: ../../tools/widl/widl: Command not found make[2]: *** [../../include/wtypes.h] Error 127 make[2]: Leaving directory `/home/susan/wine/libs/port' make[1]: *** [port] Error 2 make[1]: Leaving directory `/home/susan/wine/libs' make: *** [libs] Error 2 susan@ubuntu:~/wine$

2 1

Re: [06/10] wintrust: Implement CryptCATOpen and CryptCATClose.
by Maarten Lankhorst 23 Dec '08

23 Dec '08

Hi Juan and Hans, Juan Lang schreef: > Hi Hans, > > >> Maarten, do you remember what the code to store attribute certs was >> needed for? I'd like to address Juan's concern by either adding a test >> or taking the code out. >> > > I wouldn't worry about it. The code looks correct to the eye, it's > just calling part of crypt32 that's stubbed out (and on my list.) > Mainly I was curious if you'd managed to test with native crypt32 > somehow, as that's something I've never managed to make work (on > Linux.) > I was working on some code that needed it, The specific functions were stubbed out (crossover proprietary advantage (TM)) so it's not used, but the correct implementation of CryptCATGetCertAttr/CryptCATEnumCertAttr would need the attributes. Cheers, Maarten.

1 0

how to create a broken .tlb file
by Michael Karcher 23 Dec '08

23 Dec '08

Hello developers, while debugging problems with and old version of Sonic Stage, I found that sonic stage includes broken type libraries, i.e. the TYPEFLAG_FDISPATCHABLE bit is generally missing. As widl (and probably midl too) set this bit automatically, I have some problems in creating a .tlb file for a test case for my one-line patch that also misses this bit. There are some possibilities to get around the problem: a) Include a broken (hand-patched) tlb file as binary file in git b) Include a program that breaks tlb files and call it while building tests c) Include tlb file patching into the testcase (i.e. copy a good tlb, patch it, and perform some tests with the copy, than delete it) Which approach would have the highest chance of getting the fix (including the testcase that tests broken type libraries) included into Wine? Regards, Michael Karcher

2 1

Re: bugfix: resend: fix serial_flush
by Alexandre Julliard 23 Dec '08

23 Dec '08

Wolfgang Walter <wine(a)stwm.de> writes: > @@ -201,7 +202,17 @@ static void serial_flush( struct fd *fd, struct event **event ) > /* MSDN says: If hFile is a handle to a communications device, > * the function only flushes the transmit buffer. > */ > - if (tcflush( get_unix_fd(fd), TCOFLUSH ) == -1) file_set_error(); > + /* FlushFileBuffers does NOT have the semantics of tcflush. > + * Whereas tcflush discards any data not yet transmitted > + * FlushFileBuffers ensures they are written out. > + * The POSIX equivalent is tcdrain > + */ > + while (tcdrain( get_unix_fd(fd)) == -1) { > + if (errno != EINTR) { > + file_set_error(); > + return; > + } This will block, you can't do that in the server. -- Alexandre Julliard julliard(a)winehq.org

2 2

Symlink vulnerability in winetricks
by Stefan Nordhausen 23 Dec '08

23 Dec '08

Hi! Winetricks has a symlink vulnerability, it does (echo "$title"; echo ""; echo "$text") > /tmp/x_showmenu.txt An attacker can exploit this by creating a symlink called /tmp/x_showmenu.txt and have it point to some file that a winetricks user can write (e.g. ~/Documents/important_stuff.odf). Winetricks will then overwrite that file with its data. To solve this, apply the following patch that simply avoids the creation of a temporary file: --- winetricks 2008-12-18 06:34:42.000000000 +0100 +++ winetricks 2008-12-23 18:00:17.000000000 +0100 @@ -207,8 +207,8 @@ args="$args,$1" shift done - (echo "$title"; echo ""; echo "$text") > /tmp/x_showmenu.txt - xmessage -print -file /tmp/x_showmenu.txt -buttons "Cancel,$args" | sed 's/Cancel//' + (echo "$title"; echo ""; echo "$text") | \ + xmessage -print -file - -buttons "Cancel,$args" | sed 's/Cancel//' } showmenu() Merry Christmas Stefan

1 0

DIB Engine
by Massimo Del Fedele 23 Dec '08

23 Dec '08

As my DIB engine is becoming usable (I already use it on Autocad for my job), I'm thinking to publish the patches. As it's still not complete, I'm thinking to add a way to enable it on demand with registry and environment variable : export WINEDIB=ON activates it export WINEDIB=OFF deactivates it if no environment variable, it checks a registry key (I'd like to have some suggestion on where to put it). If no environment variable nor registry entry are present it'll be disabled (by now) as is for testing purposes. How should I publish it ? A big unique patch, 2 patches, one with the (small) changes in gdi32 and another big one with the engine itself, or many small patches ? Is it right to put on wine patches list ? Ciao Max

5 6

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.
by Stefan Dösinger 23 Dec '08

23 Dec '08

I never saw this crashing on any of my systems, so it is probably driver dependent. Which Windows driver are you using? If the test crashes on either ATI, Nvidia or Intel it is a good idea to remove it. I don't think we should remove it if it crashes on something like VMWare or other 'noname' cards.

4 4

MSVCP80 implementation
by louis＠museresearch.com 23 Dec '08

23 Dec '08

Hi all, I'm attempting to get software to run which requires some functions in MSVCP80 to be implemented. Using the original DLLs is not an option for us. In particular, a couple of the allocator functions are being called (msvcp80.dll.??0?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@QAE@XZ to give one such example). I am sure there are more after this is fixed too. Browsing the WINE source, I found references to some similarly mangled functions in MSVCRT (the stream classes), but they did not seem to be actually implemented: in msvcrt/tests/cpp.c there was a demangling test, but I didn't find much else that was directly related. So, my question is how WINE handles calls to any STL or C++ library functions which may be included in these DLLs, and what approach I should use to implement or forward calls to these kinds of functions. Any help would be much appreciated. Thanks in advance, Louis Gorenfeld Muse Research

6 5

RE: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to NULL on error
by Stefan Dösinger 23 Dec '08

23 Dec '08

Hi, Please write a test for this. This behavior differs from function to function unfortunately. Some functions do not set the value to NULL, and some apps depend on this. I think dlls/d3d9/tests/shader.c is a good place to put this test. -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Vincent Pelletier > Sent: Monday, December 22, 2008 11:25 PM > To: wine-patches > Subject: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to > NULL on error > > When IWineD3DDevice_GetVertexShader fails, set *ppShader to NULL. > > This fixes "Black & White 2" here: it used to crash right when first > level intro video ended, before seeing the level. With this patch I can > play a bit (though there are some graphical glitches remaining, mouse > it not so > smooth...) > > -- > Vincent Pelletier

2 2

Valgrind warning in wined3d/swapchain.c in IWineD3DSwapChainImpl_Destroy
by Dan Kegel 23 Dec '08

23 Dec '08

Hi Stefan, you seem to have been in this code recently, could you have a look? This is a somewhat flaky error that happens about 80% of the time under heavy load on my quad core box. (This is valgrind's xml output format, it's pretty fluffy, sorry.) Thanks, Dan <error> <kind>UninitCondition</kind> <what>Conditional jump or move depends on uninitialised value(s)</what> <stack> <frame> <obj>dlls/wined3d/wined3d.dll.so</obj> <fn>IWineD3DSwapChainImpl_Destroy</fn> <dir>dlls/wined3d</dir> <file>swapchain.c</file> <line>75</line> </frame> <frame> <obj>dlls/d3d9/d3d9.dll.so</obj> <fn>IDirect3DSwapChain9Impl_Release</fn> <dir>dlls/d3d9</dir> <file>swapchain.c</file> <line>66</line> </frame> <frame> <obj>dlls/d3d9/d3d9.dll.so</obj> <fn>D3D9CB_DestroySwapChain</fn> <dir>dlls/d3d9</dir> <file>directx.c</file> <line>427</line> </frame> <frame> <obj>dlls/wined3d/wined3d.dll.so</obj> <fn>IWineD3DDeviceImpl_Uninit3D</fn> <dir>dlls/wined3d</dir> <file>device.c</file> <line>2426</line> </frame> <frame> <obj>dlls/d3d9/d3d9.dll.so</obj> <fn>IDirect3DDevice9Impl_Release</fn> <dir>dlls/d3d9</dir> <file>device.c</file> <line>98</line> </frame> <frame> <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj> <fn>func_visual</fn> <dir>dlls/d3d9/tests</dir> <file>visual.c</file> <line>9960</line> </frame> <frame> <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj> <fn>run_test</fn> <dir>dlls/d3d9/tests/../../../include/wine</dir> <file>test.h</file> <line>452</line> </frame> <frame> <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj> <fn>main</fn> <dir>dlls/d3d9/tests/../../../include/wine</dir> <file>test.h</file> <line>502</line> </frame> </stack> </error>

2 1

Re: winecfg: Disable nonfunctional advanced drive settings
by Austin English 23 Dec '08

23 Dec '08

On Tue, Dec 23, 2008 at 2:36 AM, M.Kiesel <wine-devel(a)continuity.cjb.net> wrote: > In the winecfg drive tab, advanced drive settings (setting label and serial) > seem to be broken currently due to other Wine bugs (see drive.c > apply_drive_changes comments). Disable these settings for now since this > only confuses users. > > Changelog: > winecfg: Disable nonfunctional advanced drive settings > > > Rather than disable it and cause more confusion when it does work, focus on fixing the actual bug instead. -- -Austin

2 2

Re: Wine build failed
by Dmitry Timoshkov 23 Dec '08

23 Dec '08

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote: >> building current git tree fails to me on Debian Etch (x86) with: >> >> ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include >> -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ >> -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing >> -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o >> font.o ../../../wine-git/dlls/gdi32/font.c ccache gcc -c >> -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include >> -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ >> -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing >> -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o >> freetype.o ../../../wine-git/dlls/gdi32/freetype.c >> ../../../wine-git/dlls/gdi32/freetype.c:187: error: expected declaration >> specifiers or ‘...’ before ‘FT_LcdFilter’ > > Remove a broken patch from your sources, that's not a "current git tree". I'm sorry, that patch is really in current git. -- Dmitry.

1 0

Re: cryptui(0/24)
by James McKenzie 23 Dec '08

23 Dec '08

Juan Lang wrote: > This patch series implements the remaining portions of > CryptUIWizImport, and calls it from the certificate dialog. > > If all of this is accepted, this is one lengthy and needed functional implementation. Good job, Juan! James McKenzie

2 1

Re: MSVCP80 implementation
by James Mckenzie 23 Dec '08

23 Dec '08

>"James McKenzie" <jjmckenzie51(a)earthlink.net> wrote: > >>>> I'm attempting to get software to run which requires some functions in >>>> MSVCP80 to be implemented. >>>> >>> You need to install msvc2005 redistributable runtime. The simplest way is >>> using winetricks: http://wiki.winehq.org/winetricks >>> >>> Implementing all that is a huge waste of time. >>> >>> >> Legally speaking, we should start implementing all of the functions in >> the Win32/Win64 API. > >MSVCP80 is not a part of win32 API, that's a redistributable run-time >library supposed to be provided by an application. > Dimtry: Thank you for the clarification on its use and where it should come from. I will correct then: Get it through Winetricks or insure that it is packaged with the executable. James McKenzie

1 0

Patchwatcher offline?
by IneedAname 23 Dec '08

23 Dec '08

Looks like Patchwatcher has being offline from 09-Dec-2008. Did I miss something or did someone trip over the mains cable?

5 5

Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size
by Henri Verbeet 23 Dec '08

23 Dec '08

2008/12/23 Vincent Pelletier <plr.vincent(a)gmail.com>: > If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render state is > set to an invalid size, glPointSize will fail. > This happens in "Black & White 2", causing log/stderr to be flooded with > opengl errors. > > I'm not sure if this should be fixed here, or when setting state value. > Also, maybe it should be avoided to double-check against opengl bounds when > WINED3DRS_POINTSCALEENABLE is true. > I think it makes more sense to clamp the value to be within the limits, rather than using whatever was used last.

1 0

Fwd: Linking to a Mac OS X build of Wine from winehq.org/download ?
by Zach Drayer 22 Dec '08

22 Dec '08

Begin forwarded message: > From: "Austin English" <austinenglish(a)gmail.com> > Date: December 22, 2008 6:12:13 PM EST > To: "Zach Drayer" <zach(a)drayer.name> > Subject: Re: Linking to a Mac OS X build of Wine from winehq.org/ > download ? > > On Mon, Dec 22, 2008 at 5:06 PM, Zach Drayer <zach(a)drayer.name> wrote: >> >> On Dec 22, 2008, at 10:25 AM, Austin English wrote: >>> >>> It currently has a few 'OS X-isms'. The patch that causes 100% cpu >>> usage on SSL sites in IE6 is reverted, as well as a few x11 hacks. >>> The >>> other main problem is fonts. >>> >>> I think we need to fix the X11 hacks needed before doing considering >>> it 'official' wine. We don't want a flood of bug reports for that >>> problem. >>> >> The big problem is that OS X's X11 still ships with libGL 1.2 >> while, iirc, >> wine requires libGL 1.3. I *believe* (but dont quote me on this) >> that Mike >> patches wine to remove this check. >> >>> What I would like to see is the changes made by Zach and Mike >>> incorporated >>> back into the main Wine code. >> >> I don't make any changes to wine; I just build bland wine and stick >> it in a >> .bundle application. >> >> On Dec 22, 2008, at 10:39 AM, James Mckenzie wrote: >>> >>> Both Mike and Zach have approached building Wine releases in the two >>> structures supported by Apple: Drag and Drop where you grab a pre- >>> built >>> Application object and move it into the Applications folder and >>> the use of >>> the Apple installer with an installable 'package' much like the >>> use of apt >>> or yum. There is great debate as to which is the best approach >>> and, basing >>> this on the struggle within and outside of the OpenOffice.org/ >>> NeoOffice.org >>> MacOSX porting projects, I would like to avoid this problem as >>> best we can. >>> Firefox and Thunderbird use the first approach, but many projects >>> use the >>> latter. >> >> Mike's builds work with drag and drop because he builds all the >> libraries >> that Darwine requires and sticks them in the bundle. >> >> The builds that I create rely on system libraries whenever >> possible. The >> reason my builds have an installer is because the system doesn't >> come with >> versions of FreeType or FontForge that are reasonably up to date. >> >> One notable difference here is that since Mike puts all his builds >> into the >> bundle, It has more compatibility (his versions support Tiger and >> Leopard, >> mine only works on Leopard). However, it comes at the cost of some >> features >> working (iirc, libcups works with my builds, but not his). >> >> -Zach >> > > I think you meant to send this to wine-devel as well. > Yup, sorry about that. Was about to forward it to the right place when i your email.

1 0

New Gecko package - call for tests
by Jacek Caban 22 Dec '08

22 Dec '08

Hi, I've released first (and hopefully last) RC build of new Gecko package and attached a patch against current Wine Git to bug 16198 http://bugs.winehq.org/show_bug.cgi?id=16198 It's critical to make sure, that there will be no regressions due to the new Gecko, it'd much more work to fix such regression than a usual regressions. I'd appreciate any help with testing it. Instructions how to do it are in the bug report. Any application that uses MSHTML is worth testing, esp ones that extensively use it. I will write more about the new release and future plans later in an other subject. Thanks, Jacek

2 2

Re: ntdll: fix a compiler warning on PC-BSD
by Francois Gouget 22 Dec '08

22 Dec '08

I'm a bit surprised that PC-BSD/FreeBSD's mkdir() does not take a mode argument. Are you sure this is really the case? Maybe we are just mising a #include directive on BSD? (Unfortunately I don't really have access to a FreeBSD box right now) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

2 1

d3d9 patch include a test needs testing in windows
by Pauli Nieminen 22 Dec '08

22 Dec '08

Hi! I have tried to get Civ4 running in my machine and successed with some minor wine modifications but this patch needs testing in windows how d3d9 handles this case in there. Preferable test system should be include graphic card that supports some but not all shader versions. (That means readeon 8500+ and Geforce 3/4+). I think it should be ok to run in any windows version if there is just dx9 installed. Patch set includes 3 patches but you realy only need to apply the test portion of 2nd patch. The latest patch version is available at http://repe.ath.cx/wine/ and bug report is http://bugs.winehq.org/show_bug.cgi?id=16444 . Thanks for help. Pauli

2 1

RFC: Proposed new web site design
by Jeremy White 22 Dec '08

22 Dec '08

At Wineconf, we made the decision to change the entry page to the Wine web site. The hope was to simplify and stream line it, and to put in place the infrastructure to start moving more content to the Wiki. Jeremy Newman and Jon Parshall have put a lot of time and energy into a proposed new design, following what we took away from the meetings at Wineconf. A mock up of that design is up now here: http://wine.codeweavers.com/winehq_new/ ...and the theming intended for all 'child' pages of the web site, starting with the Wiki: http://wine.codeweavers.com/winehq_new/wiki.html Beyond the normal controversy that any new design sparks there is one major potential controversial change. That is, I am asking for prime placement on the download page on behalf of CodeWeavers instead of the (stale and ugly, sorry) banner ads we used in the past. You can see our current concept around that positioning here: http://wine.codeweavers.com/winehq_new/download.html I hope that the general community sees that as a reasonable exchange for all of the work we put into Wine and hosting the Wine server, and a vast improvement over the banner ads. At any rate, comments and feedback are welcome. And in a vain attempt to prevent all the flames from scorching Jon and Jeremy, I'd like to officially state how much I appreciate their efforts. Cheers, Jeremy

19 32

Re: [06/10] wintrust: Implement CryptCATOpen and CryptCATClose.
by Juan Lang 22 Dec '08

22 Dec '08

Hi Hans, this is a really minor comment: +struct cryptcat +{ + DWORD magic; + HANDLE msg; msg's type should be HCRYPTMSG instead. + for (i = 0; i < cc->attr_count; i++) + { + if (!CryptMsgGetParam(hmsg, CMSG_ATTR_CERT_PARAM, i, NULL, &size)) Out of curiosity, how did you test this? --Juan

2 2

Re: Linking to a Mac OS X build of Wine from winehq.org/download ?
by James Mckenzie 22 Dec '08

22 Dec '08

-----Original Message----- >From: Dmitry Timoshkov <dmitry(a)codeweavers.com> >Sent: Dec 21, 2008 10:45 PM >To: Dan Kegel <dank(a)kegel.com>, Roderick Colenbrander <thunderbird2k(a)gmx.net> >Cc: wine-devel(a)winehq.org, zach(a)drayer.name, ies4osx(a)kronenberg.org >Subject: Re: Linking to a Mac OS X build of Wine from winehq.org/download ? > >"Dan Kegel" <dank(a)kegel.com> wrote: > >> On Sun, Dec 21, 2008 at 8:27 AM, Roderick Colenbrander >> <thunderbird2k(a)gmx.net> wrote: >>>> Say, http://www.kronenberg.org/darwine/ seems to be a popular source >>>> of nearly up to date wine builds for the mac. How about we link to it >>>> from http://winehq.org/download/ ? >>>> >>>> Furthermore, are his packages good enough to support? >>>> If so, how 'bout we ask him to add links to bugzilla and >>>> the appdb from his page? >>> >>> Most importantly we need to get rid of the Darwine name. It causes a lot of unneeded confusion. >> >> Yes, I would like to keep Darwine as the name of the old powerpc project >> that combined an x86 emulator and wine. >> >> Can we convince Mike and Zach to switch names to just plain Wine? > >And change the licencing conditions to LGPL, currently that page states >"Darwine and wine are released under the gpl". They also have to remove >any differences between WineHQ sources and their ones, otherwise it can't >be supported via WineHQ. > Dan and Dmitry: What I would like to see is the changes made by Zach and Mike incorporated back into the main Wine code. Both Mike and Zach have approached building Wine releases in the two structures supported by Apple: Drag and Drop where you grab a pre-built Application object and move it into the Applications folder and the use of the Apple installer with an installable 'package' much like the use of apt or yum. There is great debate as to which is the best approach and, basing this on the struggle within and outside of the OpenOffice.org/NeoOffice.org MacOSX porting projects, I would like to avoid this problem as best we can. Firefox and Thunderbird use the first approach, but many projects use the latter. The Wine project should pick one as the formally supported installation method and allow others to support the second. I don't have a favorite, as deinstallation of the program is easy and involves an additional step when using the second installation method. Again, restating my first sentence in the last paragraph is that we need to bring back into the Main Wine codebase those changes needed to successfully complete a build on the Intel MacOSX system. Darwine should remain a project for incorporating the x86 emulator, Qemu and Wine. This should reduce MacOSX user confusion and get all of the pieces together. Further work may be required to fully support all functionality of the Wine project, such as font support, as time progresses. James McKenzie

1 0

question about translating winehq.org
by Maik Schulz 22 Dec '08

22 Dec '08

Hi, how can I translate the top navigation bar ("Forums" would be "Foren" in German) and the word "Search" (would be "Suche" in German) next to the search box? Cheers, -Maik

2 1

Linking to a Mac OS X build of Wine from winehq.org/download ?
by Dan Kegel 22 Dec '08

22 Dec '08

Say, http://www.kronenberg.org/darwine/ seems to be a popular source of nearly up to date wine builds for the mac. How about we link to it from http://winehq.org/download/ ? Furthermore, are his packages good enough to support? If so, how 'bout we ask him to add links to bugzilla and the appdb from his page?

8 11

Re: [07/10] wintrust: Implement CryptCATEnumerateMember.
by Alexandre Julliard 22 Dec '08

22 Dec '08

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -496,12 +496,208 @@ BOOL WINAPI CryptCATClose(HANDLE hCatalog) > return TRUE; > } > > +static BOOL guid_from_string(const WCHAR *str, GUID *guid) > +{ > + unsigned int i = 0; > + unsigned char *b = (unsigned char *)guid; > + const WCHAR *p = str; Please call one of the existing functions for this instead of reinventing the wheel. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [02/10] wintrust: Convert crypt tests to Unicode.
by Alexandre Julliard 22 Dec '08

22 Dec '08

Hans Leidekker <hans(a)codeweavers.com> writes: > diff --git a/dlls/wintrust/tests/crypt.c b/dlls/wintrust/tests/crypt.c > index 6811fd4..41cb39a 100644 > --- a/dlls/wintrust/tests/crypt.c > +++ b/dlls/wintrust/tests/crypt.c > @@ -27,8 +27,8 @@ > > #include "wine/test.h" > > -static char selfname[MAX_PATH]; > -static CHAR CURR_DIR[MAX_PATH]; > +static WCHAR selfname[MAX_PATH]; > +static WCHAR current_dir[MAX_PATH]; Is that really useful? It seems to me it will break the tests on Win9x for no good reason. -- Alexandre Julliard julliard(a)winehq.org

2 2

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (redux)
by Stefan Dösinger 22 Dec '08

22 Dec '08

Hmm... Wouldn't this bug also affect surfaces without a PBO? > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Nick Burns > Sent: Sunday, December 21, 2008 12:36 PM > To: wine-patches(a)winehq.org > Subject: [PATCH] Fix glReadPixels call from read_from_framebuffer > (redux) > > > This is a resubmission of my previous patch I fixed the issues Jeff > found > 1 - email address in the patch file/git > 2 - move declartions to block beginning (no warnings now) > 3 - hotmail spacing (well i think this is as good as I can make it...) > > > This is my last gfx fix for SHOGO (now its quite legible and playable) > The readpixels call was putting data into the wrong place in the pbo > (fixed with pixelstore) And the y-flip code was flipping the wrong data > as well (set the bottom row to the bottom row and not the height'th > row) > > The code handled fullscreen 2d blits (or blts without any colorkey > masking) correctly However sub-blits had issues (in the pbo path) > 1 - readpixels read into the wrong part of the pbo (as a line and > not a rect) > 2 - the y-flip code would move around the uninited data (from the > readpixels) and it read from the wrong place > 3 - After 1 and 2 the pbo is corrupt and the blt code had no > chance... > > This patch fixes 1 and 2 -- letting the blt code shine This can be seen > in the SHOGO menu (now not corrupt!) > > Changelog > Fix glReadPixels call from read_from_framebuffer > Fix the call to readpixels so that 2d blts going thru the pbo path > end up in the right place and get flipped correctly > > - Nick

2 1

Re: wine.inf: Create fake pidgen.dll.
by Alexandre Julliard 22 Dec '08

22 Dec '08

Hans Leidekker <hans(a)codeweavers.com> writes: > The ie7 installer makes this call: > > LoadLibraryExA("C:\\windows\\system32\\pidgen.dll", 0, LOAD_LIBRARY_AS_DATAFILE) > > which fails if the file doesn't exist. No, it should work just fine. You shouldn't need a fake library for that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Windows version autodetection
by Damjan Jovanovic 22 Dec '08

22 Dec '08

Hi There are some older applications out there, which don't install or run correctly unless Wine is emulating the correct Windows version (eg. Windows 9x). At least Windows XP has the ability to use certain heuristics to make an educated guess as to which version of Windows the application expects, and then lie in GetVersion() and behave like that version in relevant APIs. Should we do something like that for Wine? It would allow many applications to work out of the box. Damjan Jovanovic

10 17

winehq.org language selection suggestion
by Maik Schulz 22 Dec '08

22 Dec '08

Hi, instead of having the "change language" link at the bottom of the main page, why not display the country flags directly and shade the ones that are inactive (or find some other way of indicating the active one)? Then non-english users had a better clue that language options are available at all and wouldn't have to figure out what "change language" means ;-) Cheers, -Maik

1 0

Get font file (full) path from HFONT
by Massimo Del Fedele 22 Dec '08

22 Dec '08

In order to use Freetype library I need to get font file full path from an HFONT handle. Is there a simple way to do it or should I scan the registry/font dirs to pair font faces/font paths ? Ciao Max

2 2

Adding Mac joystick support -- build problem
by Nathaniel Gray 22 Dec '08

22 Dec '08

Hi wine-devels, I've got a simple goal. I want to play IL-2 Sturmovik on my Mac without rebooting. This flight sim is gold-rated in the app-db, so this should be a walk in the park, but of course the game does require a joystick. After a bit of poking I realized that there's no support for joysticks under Mac OS. I'm willing to write the code for joystick support, and I've even gotten as far as writing a test app under OS X that enumerates all joysticks and polls their state. I've looked at the linux joystick code in wine and think I can write the equivalent code for OS X. What I *can't* seem to do is build a wine that can run IL-2. I've had no problem installing and playing the demo using the 1.1.9 build at http://www.kronenberg.org/darwine/ and using crossover games, but when I build wine myself the IL-2 demo installer fails to run. I've tried building the 1.1.9 and 1.1.10 tarballs and using macports to install 1.1.10, all with the same result: --- begin log output --- Could not load Mozilla. HTML rendering will be disabled. err:wgl:has_opengl glx_version is 1.2 and GLX_SGIX_fbconfig extension is unsupported. Expect problems. wine: configuration in '/Users/n8gray/.wine' has been updated. err:ntdll:RtlpWaitForCriticalSection section 0x7bc8a384 "loader.c: loader_section" wait timed out in thread 0024, blocked by 0023, retrying (60 sec) wine: Unhandled page fault on read access to 0xffffffff at address 0x1017:0x00000c1d (thread 0025), starting debugger... couldn't load main module (2) Unhandled exception: page fault on read access to 0xffffffff in 32-bit code (1017:00000c1d). In 32 bit mode. Register dump: CS:1017 SS:1217 DS:1217 ES:11ef FS:11ff GS:0037 EIP:00000c1d ESP:000056ee EBP:00000000 EFLAGS:00010202( - 00 - -RI1) EAX:00000001 EBX:00000080 ECX:000019b0 EDX:00000001 ESI:00000000 EDI:00001217 Stack dump: 0x1217:0x56ee: f160 7b88 0000 7597 120f 0000 0000 0468 0x1217:0x56fe: 1027 0000 0000 0000 0000 0000 0000 0000 0x1217:0x570e: 0000 0000 0000 0000 0000 0000 0000 0000 023f: sel=11ff base=7eed0000 limit=0000ffff 32-bit rw- Backtrace: =>1 0x1017:0x00000c1d (0x1217:0x0000) 0x1017:0x00000c1d: call 0x0000fffe Modules: Module Address Debug info Name (7 modules) PE 60180000-60184000 Deferred advapi32 PE 60310000-60325000 Deferred user32 PE 604b0000-604b4000 Deferred gdi32 PE 61cc0000-61d0d000 Deferred winmm PE 622a0000-622a4000 Deferred version PE 7b810000-7b889000 Deferred kernel32 PE 7bc10000-7bc14000 Deferred ntdll Threads: process tid prio (all id:s are in hex) 0000000c 0000001f 0 0000001e 0 00000018 0 00000017 0 0000000e 0 0000000d 0 00000010 00000011 0 0000001b 00000021 0 00000020 0 0000001d 0 0000001c 0 00000022 (D) C:\windows\system32\winevdm.exe 00000025 0 <== 00000024 0 00000023 0 Backtrace: =>1 0x1017:0x00000c1d (0x1217:0x0000) err:ntdll:RtlpWaitForCriticalSection section 0x7b92c250 "syslevel.c: Win16Mutex" wait timed out in thread 0023, blocked by 0025, retrying (60 sec) --- end log output --- If I use Mike's build I only get these messages: wine: created the configuration directory '/Users/n8gray/.wine' Could not load Mozilla. HTML rendering will be disabled. wine: configuration in '/Users/n8gray/.wine' has been updated. Clearly there's some magic build juju that I don't have, perhaps related to opengl. I've read the wiki, but I haven't found anything that I haven't already tried. Can anybody provide a hint as to how to get this working? BTW, I'm using the latest XQuartz 2.3.2_rc3 (xorg-server 1.4.2-apple27). Thanks, -n8 -- Nathan Gray http://www.n8gray.org/

3 6

Help me to find function name from kernel32.dll
by AlannY 21 Dec '08

21 Dec '08

Hi there. I'm debugging some windows app in OllyDbg under Wine ;-) (funny?) Now, I found this call in assembler: call ebx EBX is 7EE6BC23. So, instruction invokes some function in address 7EE6BC23. This address, as Olly shows belongs to kernel32.dll. I can follow this address, and there are some code ;-) Everything right ;-) But now, I want to get name of this function (kernel32.7EE6BC23) and analyze it's C source code (as you know Wine is open source :P) ;) How to? Or maybe it's impossible? Maybe some symbols must be loaded (and how?). Tnx

1 0

re: Help me to find function name from kernel32.dll
by Dan Kegel 21 Dec '08

21 Dec '08

m(a)alanny.ru asked: > [How can I get a log of the Wine functions called by an app?] WINEDEBUG=+relay should help...

1 0

Compiling dbghelp with MinGW
by Francois Gouget 21 Dec '08

21 Dec '08

When I compile Wine with MinGW, the first error I get is in dlls/dbghelp/source.c. Yet it seems to me that there is no fundamental reason that would prevent dbghelp from working on Windows (i.e. it's not in the 'ntdll' category). So the error is that although MinGW does not have regex.h and HAVE_REGEX_H is not set, we still use regex_t in many places and call the corresponding functions: regcomp(), regexec() and regfree(). So how should we handle this? 1) #ifdef-out regexp support if regex.h is missing? Maybe with an autoconf check for regcomp()? 2) Add some reg*() stubs that do nothing if regex.h & co are missing? 3) Use some Windows API that provides regular expression support? Is there one? Is it implemented already? 4) Reimplement regular expression support straight in dbghelp? Maybe by importing some c files from another project with a compatible license? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The last time religion ruled, it was called the dark ages.

2 3

wow, there are more win64 apps than I thought...
by Dan Kegel 21 Dec '08

21 Dec '08

I updated http://wiki.winehq.org/Wine64 with a list of some win64 apps. There are lots more than I expected.

9 10

Re: [PATCH] Fix glReadPixels call from read_from_framebuffer
by Jeff Zaroyko 21 Dec '08

21 Dec '08

On Sun, Dec 21, 2008 at 4:40 PM, Nick Burns <adger44(a)hotmail.com> wrote: > > This is my last gfx fix for SHOGOThe readpixels call was putting data into the wrong place in the pbo (fixed with pixelstore)And the y-flip code was flipping the wrong data as well (set the bottom row to the bottom row and not the height'th row) > The code used to handle fullscreen 2d blits (or blts without any colorkey masking)However sub-blits had issues (in the pbo path) 1 - readpixels read into the wrong part of the pbo 2 - the y-flip code would move around the uninited data (from the readpixels) and it read from the wrong place 3 - After 1 and 2 the pbo is corrupt and the blt code later had no chance... > This patch fixes 1 and 2 -- letting the blt code shineThis can be seen in the SHOGO menu (now not corrupt!) > Changelog Fix glReadPixels call from read_from_framebuffer Fix the call to readpixels so that 2d blts going thru the pbo path end up in the right place and get flipped correctly > > - Nick > Hi + GLint rowLen = 0; + GLint skipPix = 0; + GLint skipRow = 0; You're declaring variables in a place which is not the start of a block, this isn't legal in ANSI C/C90 as gcc points out: surface.c: In function 'read_from_framebuffer': surface.c:786: warning: ISO C90 forbids mixed declarations and code Also it looks like your email address is not correct in this patch? From: Nick Burns <nwburns(a)nwburns2.mshome.net> git repo-config user.email "me(a)example.com" -Jeff

2 1

RE: [PATCH] Fix ddraw surface version setting
by Stefan Dösinger 21 Dec '08

21 Dec '08

The patch looks ok to me

2 2

RE: [PATCH] wined3d_gl.h minor typo fix
by Stefan Dösinger 21 Dec '08

21 Dec '08

> - USE_GL_FUNC(PGLFNGLFOGCOORDDVEXTPROC, glFogCoordvEXT, EXT_FOG_COORD, NULL )\ > + USE_GL_FUNC(PGLFNGLFOGCOORDDVEXTPROC, glFogCoorddvEXT, EXT_FOG_COORD, NULL )\ I think I fixed that one with a patch in my glFogCoord emulation patchset a few days ago. Did you forget to update your git tree, or did I miss something? Other than that, the patch breaks the alignment of the 3rd and 4th column because a 'v' was added to the function name, but no space removed to keep the alignment.

2 1

Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes
by Reece Dunn 21 Dec '08

21 Dec '08

Hi, There is a discussion going on over at https://bugs.launchpad.net/ubuntu/+source/wine/+bug/111061 about improving Wine's look and feel to better match the system that it is running on. The situation is as follows: == Colour Schemes Wine supports these by reading the settings from the registry. Winecfg can load a .theme file containing a colour profile and adapt accordingly (saving those settings to the registry). At the moment, if you need to script this (e.g. when installing Wine) you need to manipulate the registry. It would be helpful if winecfg (or some other helper utility) supported setting the theme file on the command line. In addition to this, if the user changes the theme used on their system it would not be reflected by Wine. == Windows Theme Support Windows theming support is in place to some extent, w.r.t. the XP theming APIs. There are some user32 controls and the window/dialog handlers that don't support theming yet and there are some performance issues that need resolving. This would be set via the command line used to set the colour scheme since they can be set via the same .theme file. This is limited in that you need an XP theme for each native theme available. == Native Theme Support The main thing here is that Wine would monitor the native system for theme changes. The colours of the native theme would be mapped to the Windows system colours, saved to the registry and then a WM_SYSCOLORCHANGED message would be sent to all open top-level windows so they could update to the new look. Any metric data would be mapped in a similar way. As for the theme, an implementation of uxtheme would map the API calls to the native calls. Here, it may be possible to just send a request to redraw everything on each active window. If not, a WM_THEMECHANGED message would need to be sent to all active windows. The challenge with native theme support is two-fold: (1) it should work on any system - some have Gtk, some Qt and some Cocoa/Carbon, while others (like the *BSDs and OpenSolaris) are likely not to have those engines available; (2) it should not break any Windows application. Note that as Vista has a different msstyles theming engine (it is a DLL), we could have the msstyles DLL expose the uxtheme API and have uxtheme call msstyles to do the rendering. That way, we could have a gtk.msstyles, qt3.msstyles, qt4.msstyles and an carbon.msstyles that would bind to the corresponding theming engine. If the msstyles DLL does not expose those methods, the uxtheme engine could then fallback to the current XP theme processing. For Mac theme support that would possibly require Objective-C code to be done properly, that theme could be an external package (possibly in darwine) that would be installed in addition to Wine. The same thing for the Qt engines, allowing them to directly interface with the C++ Qt APIs. Thoughts? Ideas? - Reece

7 19

Re: [PATCH] winedbg: add a crash dialog for --auto mode
by Juan Lang 20 Dec '08

20 Dec '08

Hi Mikolaj, there are a few typos in your patch: + /* we waist some memory for the full path and UNICODE_STRING header, but s/waist/waste/ Sorry, I wouldn't ordinarily comment on something so minor, but there are a few typos in the resources too: + LTEXT "The program %s has met a serious problem and needs to close. We are sorry for the inconvinience.", s/inconvinience/inconvenience/ Also, using "encountered" rather than "met" seems a little more idiomatic. + You may want to check http://appdb.winehq.org if there are some \ + tips about running this applicaiton.\n\n\ s/applicaiton/application/ Also, the following wording seems better: You may want to check http://appdb.winehq.org for tips about running this application. Thanks, --Juan

1 0

Re: ntoskrnl.exe: Add a redirect for IoGetCurrentProcess
by Paul Chitescu 20 Dec '08

20 Dec '08

On Saturday 20 December 2008 07:31:53 Chris Wulff wrote: > Redirect for IoGetCurrentProcess to kernel32.GetCurrentProcess > > -- Chris Wulff This is incorrect. Please provide a separate stub for IoGetCurrentProcess as it returns something else: "The IoGetCurrentProcess routine returns a pointer to the current process." - needs to be a valid pointer to some undocumented structure _EPROCESS "GetCurrentProcess Function Retrieves a pseudo handle for the current process." - essentially (HANDLE)-1 FYI I use a stub that returns (PEPROCESS)"System" since I traced some Sysinternals utility comparing the first 6 bytes to that string: TRACE(": semi-stub\n"); return (PEPROCESS)"System"; /* Sysinternals portmon expects this one */ http://www.winehq.org/pipermail/wine-patches/2008-February/049784.html This patch was not accepted for unknown reason. Paul Chitescu

2 2

qedit: tests/mediadet.c test skips sometimes
by Rico Schüller 20 Dec '08

20 Dec '08

Hi, could anyone try the attached patch for the qedit test on a windows machine? It works around bug 16548. But according to the comment in the source I think this could be a mistake. I'd like to know if it works without renaming the file on windows. On wine it works. Cheers Rico diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c index 2b43124..558ff3a 100644 --- a/dlls/qedit/tests/mediadet.c +++ b/dlls/qedit/tests/mediadet.c @@ -68,8 +68,10 @@ static BOOL unpack_avi_file(int id, WCHAR name[MAX_PATH]) return FALSE; DeleteFileW(name); +/* + Renaming isn't a good way to solve this, see bug 16548. lstrcpyW(name + lstrlenW(name) - 3, avi); - +*/ fh = CreateFileW(name, GENERIC_WRITE, 0, NULL, CREATE_NEW, FILE_ATTRIBUTE_NORMAL, NULL); if (fh == INVALID_HANDLE_VALUE)

3 7

Re: include/wine: Header only implementation of generic redblack binary search tree.
by Marcus Meissner 20 Dec '08

20 Dec '08

On Sat, Dec 20, 2008 at 07:30:53PM +0200, Pauli Nieminen wrote: > This implementation provides easy access to rb-tree which should be used instead of hashmap > if number of entries changes a lot of over time of execution. > It should be simple to write hashtree based on this which uses hash value of the key instead of > key it self. (Which would speed up tree operations a lot if key is long string) > > Note: I have also code to test the tree functionality but I don't know where to put > internal test cases. For what functionality in Wine is this intended? We do not seem to be using hashmap either? Ciao, Marcus

2 1

Re: jscript: Do not call memcpy() with a NULL pointer argument
by Andrew Talbot 20 Dec '08

20 Dec '08

On Thu Dec 18 22:41 , 'James Hawkins' <truiken(a)gmail.com> sent: >I didn't write jscript, so I'm not the expert, but create_string is >internal, so we should probably crash if str is NULL instead of hiding >the error. What is this patch for? > >-- >James Hawkins Hi James, create_string() is called on line 1323 of this file, with str == NULL and len = 0. This function always allocates memory for at least one one WCHAR, so I zero-terminated it. -- Andy.

2 4

Re: Andrei Derevyanko : mshtml: Updated test of QueryInterface.
by Vitaly Lipatov 20 Dec '08

20 Dec '08

В следующий раз - если ты добавляешь тест на интерфейс IMarshal, так и пиши. Просто Updated test - бессмысленно. В сообщении от 20 декабря 2008 Вы написали: > Module: wine > Branch: master > Commit: 2afc8fcd5a788b94c64de654823bf2f8b262338e > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=2afc8fcd5a788b94c64de6548 >23bf2f8b262338e > > Author: Andrei Derevyanko <and(a)etersoft.ru> > Date: Thu Dec 18 14:59:57 2008 +0300 > > mshtml: Updated test of QueryInterface. > > --- > > dlls/mshtml/tests/htmldoc.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c > index 84803fb..ed69725 100644 > --- a/dlls/mshtml/tests/htmldoc.c > +++ b/dlls/mshtml/tests/htmldoc.c > @@ -3766,6 +3766,11 @@ static void test_QueryInterface(IUnknown *unk) > hres = IUnknown_QueryInterface(unk, &IID_UndocumentedScriptIface, > (void**)&qi); ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, > expected E_NOINTERFACE\n", hres); ok(qi == NULL, "qi=%p, expected NULL\n", > qi); > + > + qi = (void*)0xdeadbeef; > + hres = IUnknown_QueryInterface(unk, &IID_IMarshal, (void**)&qi); > + ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); + ok(qi == NULL, "qi=%p, expected NULL\n", qi); > } > > static void init_test(enum load_state_t ls) { -- С уважением, Виталий Липатов Россия, Санкт-Петербург. www.etersoft.ru GNU! ALT Linux Team! WINE! WIKI! LaTeX! LyX!

1 0

Re: ntoskrnl.exe: Add a redirect for IoGetCurrentProcess
by Andrey Turkin 20 Dec '08

20 Dec '08

I believe this is wrong - IoGetCurrentProcess return pointer to kernel EPROCESS structure instance, and GetCurrentProcess return constant (HANDLE)-1 . The structure is declared opaque so drivers must not dereference it, but some drivers surely won't obey. 2008/12/20 Chris Wulff <crwulff(a)rochester.rr.com> > Redirect for IoGetCurrentProcess to kernel32.GetCurrentProcess > > -- Chris Wulff > > > >

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel