- wine-devel - winehq.org

Re: Implementation of ID3DXMatrixStack interface, with tests
by James McKenzie 29 Oct '08

29 Oct '08

Jérôme Gardou wrote: [patch removed] It would be nice to state which project this patch is associated with, however Alexandre usually fixes this when it is approved. Please put in TRACE where you removed FIXME. It makes debugging much easier. Thank you. James McKenzie

1 0

Re: [PATCH 2/3] xinput: Added the function XInputGetState with test cases
by Vitaliy Margolen 29 Oct '08

29 Oct '08

Andrew Fenn wrote: > This patch adds the function XInputGetState which is for checking if > any joysticks are plugged in. This always returns no joysticks. > > > ------------------------------------------------------------------------ > > > +static void test_no_controller(void) { > + > + XINPUT_STATE controllerState; > + DWORD controllerNum; > + DWORD result; > + > + for(controllerNum=0; controllerNum < 4; controllerNum++) { > + ZeroMemory(&controllerState, sizeof(XINPUT_STATE)); > + > + result = XInputGetState(controllerNum, &controllerState); > + ok(result != ERROR_BAD_ARGUMENTS, "XInputGetState failed with (%d)\n", result); > + > + if (ERROR_DEVICE_NOT_CONNECTED == result) { > + skip("Controller %d is not connected\n", controllerNum); > + } else { and > + if (hXinput) > + { > + XInputGetState = (void*)GetProcAddress(hXinput, "XInputGetState"); > + test_no_controller(); > + } else { > + skip("Could not load xinput1_3.dll\n"); > + } Using 2 separate stiles for curly brackets. Please put the opening and closing brackets on separate lines. It makes it so much easer to read. Ex: if (something) { /* Doing something */ } else { /* Doing something else */ } In xinput.h you adding lots of defines you not using. And you just threw all of them together in one big pile. Please add them when you need them. Or at least put them into proper groups. > + if (dwUserIndex < 4) { > + return ERROR_DEVICE_NOT_CONNECTED; > + /* If controller exists then return ERROR_SUCCESS */ > + } Why 4? Why not 40? Have you run your tests on windows? > -static void test_no_controller(void) { > + > + > +static void test_get_state(void) { You should call it the right way from the start. Vitaliy.

1 0

Re: Implementation of ID3DXMatrixStack interface, with tests
by Henri Verbeet 28 Oct '08

28 Oct '08

I don't think we want to implement this as a linked list. You'll also want to replace the FIXMEs you removed with useful TRACEs.

1 0

My xinput implementation please test, plus I am getting segfault with spore
by Andrew Fenn 28 Oct '08

28 Oct '08

Hi all, I am getting a segfault with the release version of Spore (I didn't test 1.1) right after my code implementation of xinput is handled by the game. Is there something I am doing wrong here or is it the game? I also tested Assasin's Creed which uses xinput1_3 and that happens to load my implementation fine and my test cases work on windows xp SP3 too. I have included my patches for the xinput implementation. If you could help me test and find out the spore problem before I submit this to wine patches it would be very helpful. I have included test cases with the patch. When testing please make sure that you don't have any xinput dlls in your program dir or system32. A list of xinput games can be found here, http://en.wikipedia.org/wiki/List_of_XInput_games Thanks and regards, Andrew

2 3

Re: Wine does not compile using Ubuntu real-time kernel
by Susan Cragin 28 Oct '08

28 Oct '08

>On Tue, Oct 28, 2008 at 10:50 AM, Susan Cragin wrote: >> I guess this is a FYI. Because this seems to be a rt-kernel issue, not a wine issue. >> Background -- Ubuntu stopped sponsoring the RT kernel for a while. (It used to compile wine without a problem.) But so many people used it that they started sponsoring it again, after a lag. >> DNS10 doesn't install correctly using the real-time kernel either. >> However, if you compile and install using standard kernel, DNS10 runs quite nicely using the RT kernel. >> >> 2.6.27-7 is the latest standard kernel >> 2.6.27-3-rt is the latest real-time >> >> If there is any interest I'll send terminal output. >> >> Susan >It doesn't compile, or doesn't run well? > >-- >-Austin It doesn't compile. I tried, no luck. Then rebooted into standard kernel and compiled. That worked. Then rebooted into RT. Winecfg ran OK, so tried to install DNS10. No luck. Then rebooted into standard and installed DNS. That worked. Then rebooted into RT. Ran DNS10. That worked. BTW -- I use Intrepid.

1 0

Wine does not compile using Ubuntu real-time kernel
by Susan Cragin 28 Oct '08

28 Oct '08

I guess this is a FYI. Because this seems to be a rt-kernel issue, not a wine issue. Background -- Ubuntu stopped sponsoring the RT kernel for a while. (It used to compile wine without a problem.) But so many people used it that they started sponsoring it again, after a lag. DNS10 doesn't install correctly using the real-time kernel either. However, if you compile and install using standard kernel, DNS10 runs quite nicely using the RT kernel. 2.6.27-7 is the latest standard kernel 2.6.27-3-rt is the latest real-time If there is any interest I'll send terminal output. Susan

3 2

Re: [PATCH] uxtheme: fixed the todo blocks in the SetWindowTheme tests. [try 2]
by James Hawkins 28 Oct '08

28 Oct '08

On Tue, Oct 28, 2008 at 2:29 AM, Reece Dunn <msclrhd(a)googlemail.com> wrote: > Hi, > > This fixes the todo blocks in the SetWindowTheme tests. > > Changes: > v2 -- initialise the hr variable so that it is initialised in the > case where hwnd is a valid window handle. > Please fix your changelog entry to describe the *fix*, not the end result (getting rid of todo_wine's). Also, + HRESULT hr = S_OK; TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName), debugstr_w(pszSubIdList)); - hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName); + if(!IsWindow(hwnd)) + hr = E_HANDLE; + if(SUCCEEDED(hr)) + hr = UXTHEME_SetWindowProperty(hwnd, atSubAppName, pszSubAppName); if(SUCCEEDED(hr)) hr = UXTHEME_SetWindowProperty(hwnd, atSubIdList, pszSubIdList); if(SUCCEEDED(hr)) This code is screaming for a goto. -- James Hawkins

3 3

Re: crypt32: fix a test failure on Free/PC-BSD
by Francois Gouget 28 Oct '08

28 Oct '08

On Mon, 27 Oct 2008, Austin English wrote: > PC-BSD doesn't have root certificates installed by default. They're > available in ports/security/ca_root_nss, but even after installing > them, the test still fails. We need their location added to the list > of locations to search. So this means we don't need to worry about ca_root_nss on the build machine but that it must be installed on the machine where Wine runs, right? I'm asking because of the Recommended_Packages Wiki page. It mostly lists build dependencies so the question is whether it should really be added there. Maybe it means that page should better distinguish build-time dependencies from run-time dependencies. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

2 1

patchwatcher: the winehttp:notification tests are failing for some reason
by Reece Dunn 28 Oct '08

28 Oct '08

Hi, Does anyone have any ideas why these tests are failing (e.g. http://kegel.com/wine/patchwatcher/results/3644.log)? The patches in question don't touch that code at all. Looking at http://test.winehq.org (e.g. http://test.winehq.org/data/07fafa26a318a3da3185fcac71bfa6d3fba82787/xp_fg-…) there seems to be some variance on WinXP and 2003. Does anyone know if this is context dependant (e.g. network timing out)? Thanks, - Reece

3 4

Re: [oleacc/tests] Remove a test with different results on several platforms
by Paul Vriens 28 Oct '08

28 Oct '08

On Mon, Oct 27, 2008 at 4:18 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > This test shows different results on different platforms (and on W2K even on > the same platform). I don't think there is any value in the content of the > buffer as the call failed anyway (ret == 0). > > Changelog > Remove a test with different results on several platforms > > -- > Cheers, > > Paul. > Sorry, attached the wrong patch (thanks Dan and Michael). I'm not able to resend until next week. Cheers, Paul.

1 0

Re: mshtml: Implement HTMLDocument get/put designMode (try 2)
by Jacek Caban 28 Oct '08

28 Oct '08

Alistair Leslie-Hughes wrote: > Hi, > Initialize designmode > > Changelog: > mshtml: Implement HTMLDocument get/put designMode We need its true implementation. What you do is a step in wrong direction and it's obviously not implementation but stub. Jacek

1 0

Re: [PATCH] uxtheme: SetWindowTheme should return E_HANDLE when the HWND it is passed is invalid. [try 3]
by Alexandre Julliard 28 Oct '08

28 Oct '08

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > @@ -691,11 +691,21 @@ HRESULT WINAPI SetWindowTheme(HWND hwnd, LPCWSTR pszSubAppName, > HRESULT hr; > TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName), > debugstr_w(pszSubIdList)); > + > + if(!IsWindow(hwnd)) > + { > + hr = E_HANDLE; > + goto error; > + } You shouldn't add IsWindow() checks. The error must be detected and handled at the place where the window handle is actually used. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml/tests: skip some tests if gecko isn't installed
by Jacek Caban 28 Oct '08

28 Oct '08

Austin English wrote: - ok(hres == S_OK, "get_body failed: %08x\n", hres); + if(hres == E_UNEXPECTED) { + skip("Could not get document body. Assuming no Gecko installed.\n"); + } + else { + ok(hres == S_OK, "get_body failed: %08x\n", hres); + } You should fix existing skip to mach current mshtml changes, not add another one. Jacek

1 0

Re: advapi32/tests: Run a test on more platforms.
by Nicolas Le Cam 27 Oct '08

27 Oct '08

Hi, Should I consider second solution ? Or perhaps adding a comment explaining why we use the second provider type key would be enough ? Original patch is available at [1] for reference. [1] http://www.winehq.org/pipermail/wine-patches/2008-October/063475.html Bye, Nicolas Le Cam 2008/10/20 Nicolas Le Cam <niko.lecam(a)gmail.com>: > Hi, > > Sometimes, the first Provider Type key (Microsoft Base Cryptographic > Provider v1.0) doesn't have a TypeName subkey. It's the case on my Win2k > box and according to test.winehq.org it seems to be the case for some > other Win2k and Win98 boxes. So check for the second Provider Type > instead. > > Checked on Win2k SP4 and WinXP SP3. > > We can also get rid of that skip by enumerating the Provider Type keys > until we find one that fit our needs in FindProvTypesRegVals(). Tell me > if this way is preferred, I will provide a modified patch. > > Regards, > Nicolas Le Cam

1 0

Re: ws2_32: set correct error if lpOverlapped has an event of NULL and lpCompletionRoutine is also NULL
by Aric Stewart 27 Oct '08

27 Oct '08

Ignore this please. -aric Aric Stewart wrote: > --- > dlls/ws2_32/socket.c | 2 ++ > dlls/ws2_32/tests/sock.c | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 0 deletions(-) > > > > ------------------------------------------------------------------------ > >

1 0

Patchwatcher status
by Dan Kegel 27 Oct '08

27 Oct '08

I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716 more and more often. We really need to set up mock servers so test cases don't need to rely on the public internet. I'm slowly bringing up a second patchwatcher using the newly refactored code. I even wrote some documentation on how to set up a patchwatcher instance: http://code.google.com/p/winezeug/source/browse/trunk/patchwatcher/readme.t… I don't really recommend anybody (but Rob) try to do this until we finish working out the bugs, though.

4 5

Where's msrle.avi? (was: winmm: Add the tests for mmioOpen and mmioSetBuffer, make them pass under Wine)
by Dan Kegel 27 Oct '08

27 Oct '08

In http://www.winehq.org/pipermail/wine-patches/2008-June/056002.html Dmitry enabled a test that is skipped unless file msrle.avi is present. Where is that file? Why isn't it in git?

2 3

[PATCH] wordpad: Make the Replace function work and the Find/Replace dialogs behave like expected.
by Elias Benali 27 Oct '08

27 Oct '08

>From 6dc7a289ccf1567a87dfca66a86ace0f509621ff Mon Sep 17 00:00:00 2001 From: Elias Benali <elptr(a)users.sourceforge.net> Date: Sat, 25 Oct 2008 21:09:27 -0400 Subject: wordpad: Make the Replace function work and the Find/Replace dialogs behave like expected. The "Find What" field is filled from the current selection in the document, if any. --- programs/wordpad/wordpad.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/programs/wordpad/wordpad.c b/programs/wordpad/wordpad.c index d06b2d9..434b6fd 100644 --- a/programs/wordpad/wordpad.c +++ b/programs/wordpad/wordpad.c @@ -49,6 +49,10 @@ # define U3(x) (x) #endif +#ifndef MIN +# define MIN(a,b) ((a) < (b) ? (a) : (b)) +#endif + /* use LoadString */ static const WCHAR wszAppTitle[] = {'W','i','n','e',' ','W','o','r','d','p','a','d',0}; @@ -1281,12 +1285,29 @@ static LRESULT handle_findmsg(LPFINDREPLACEW pFr) static void dialog_find(LPFINDREPLACEW fr, BOOL replace) { static WCHAR findBuffer[MAX_STRING_LEN]; + static WCHAR replaceBuffer[MAX_STRING_LEN]; + CHARRANGE cr; + TEXTRANGE tr; + + SendMessage(hEditorWnd, EM_EXGETSEL, 0, (LPARAM)&cr); + if (cr.cpMax > cr.cpMin) { + cr.cpMax = cr.cpMin + MIN(sizeof(findBuffer)/sizeof(WCHAR)-1, cr.cpMax-cr.cpMin); + tr.chrg = cr; + tr.lpstrText = (LPSTR)findBuffer; + SendMessage(hEditorWnd, EM_GETTEXTRANGE, 0, (LPARAM)&tr); + } else + findBuffer[0] = '\0'; + + replaceBuffer[0] = '\0'; ZeroMemory(fr, sizeof(FINDREPLACEW)); fr->lStructSize = sizeof(FINDREPLACEW); fr->hwndOwner = hMainWnd; fr->Flags = FR_HIDEUPDOWN; fr->lpstrFindWhat = findBuffer; + fr->wFindWhatLen = sizeof(findBuffer); + fr->wReplaceWithLen = sizeof(replaceBuffer); /* ignored by FindTextW() */ + fr->lpstrReplaceWith = replaceBuffer; /* ignored by FindTextW() */ fr->lCustData = -1; fr->wFindWhatLen = MAX_STRING_LEN*sizeof(WCHAR); -- 1.6.0.2

3 2

Minimal subset of Wine that can do 'make test'?
by Dan Kegel 26 Oct '08

26 Oct '08

On the theory that having a really small subset of wine would help me bring up the new patchwatcher faster, I tried building just ntdll and its tests. I had to bring in a few dependencies... but the killer was wineboot. It brings in the kitchen sink. So much for that dream! I suppose a dummy wineboot might do the trick, but that's more work than I wanted to do for this experiment.

2 1

Fix showing console window at start of some app
by slawek 26 Oct '08

26 Oct '08

Bloodshed DevC++ will not running console application if I click run program or compile it. I was wondering why and decided to put some test we have terminal access inside Wine code. I was using create_process(inside kernell32.dll). I was put the test at top of the function. This is a test for it: #include <unistd.h> /* Another code there ....... */ static BOOL create_process(...) { /* Declarations */ if (!isatty(STDIN_FILENO)) flags|=CREATE_NEW_CONSOLE; /* END */ All will works(i we have run this program in a terminal, child process will show messages in it. but If we can't have access to terminal child process will be run inside new console Window). But this code makes some other issues. Graphics applications aren't touch by this patch, but app without Window will generate blank console Windows. If I start some application, like wine notepad, there's services.exe and wineboot.exe console Windows appear. Other think is possible some splash Window don't have destroyed property(but i must test it). Possible read subsystem information from file will fix thease problems(if file don't have subsystem record, it's must be gui application). At now there's no way to run wine cmd.exe, because we are using CreateProcess to test we have terminal access. I will to moved my code into lowest level code, but I don't know where and start program call CreateProcess(there's some information about this solution). Can I send patch to Wine?

1 0

re: Winelib and static-build
by Dan Kegel 26 Oct '08

26 Oct '08

Alan Nisota wrote: > I have a project (http://code.google.com/p/coreavc-for-linux) which is a > linux executable which provides access to Windows DirectShow filters > > The problem is that I normally provide a static binary so that users on > x86-64 can install it easily without needing a 32bit build environment... Offhand, I don't think winelib lends itself to use as a static library. We're rather heavily wedded to dynamic linking, more so than in the past. How bad would it be, really, to depend on the wine package? I'd be happy to help you think through the obstacles and see if that would work for you. (The Linux Standard Base people ask occasionally if Wine belongs in the LSB. If it were, you wouldn't have to worry about Wine being installed. Maybe next year Wine will be indispensable to make it to that state...) - Dan

3 8

Re: gdi32: added CreateFontIndirectEx[A/W]
by Paul Vriens 26 Oct '08

26 Oct '08

Nikolay Sivov wrote: > + if(!pCreateFontIndirectExA) > + trace("CreateFontIndirectExA not implemeted on this platform\n"); Could you turn that into a win_skip() ? -- Cheers, Paul.

1 0

Re: [msi/tests] Fix a test for systems with %TEMP% only one level deep
by James McKenzie 26 Oct '08

26 Oct '08

Paul Vriens wrote: > Hi, > > We were basically passing "C:" to SetCurrentDirectoryA and that doesn't > work. Probably needs it's own test in kernel32 or so. > > Changelog > Fix a test for systems with %TEMP% only one level deep > > ------------------------------------------------------------------------ > > Paul: Was this patch rejected or in update? Thank you. James McKenzie

2 1

RFC: Calling thiscall methods to start windowless richedit control tests
by Dylan Smith 26 Oct '08

26 Oct '08

I have created a couple of patches to start the windowless richedit control tests. Since this has been tried by two other people already, I thought I should get some comments before submitting them to wine-patches. Maarten Lankhorst initially tried to start these tests back in 2005: http://www.winehq.org/pipermail/wine-devel/2005-July/038185.html Austin Lund made some more progress on starting these tests. http://www.winehq.org/pipermail/wine-devel/2008-July/067001.html I kept the tests minimal because I want to other issues to be taken care of before adding tests. The main thing is that the tests compile and run properly on Windows and Linux without crashing. The main difficulty was wrapping c++ methods which use the thiscall calling convention. Austin Lund already got this to work, so I just modified what he had to avoid using the ebx register. The first patch has the code to wrap the ITextHost methods so they can be called with the thiscall calling convention, and the second patch has the wrapping code to call ITextServices functions that use the thiscall calling convention. Even though the assembly is fairly short, the conditional macro definitions for all the ITextServices methods does become verbose. Let me know if someone knows a more elegant way of doing this. The macros I created however conflict with the ones in include/textserv.h, however these aren't in the native public headers. Should these be removed from Wine's public headers, or should they be modified to handle the thiscall calling convention like I did in the second patch? In order to investigate what is happening in the tests, it is helpful to trace the calls to ITextHost methods by the richedit controls. I realized it would be too verbose to trace all these calls by default, so I wrapped them all with a check for winedebug > 1, since normally winedebug is 0 or 1. Does this seem like the best way to handle this? Because I can't use the normal TRACE channels from wine/debug.h, since it can't be included in the tests. I would also like someone to look at the conditional macro definitions of __ASM_FUNC and __ASM_NAME. I took these definitions from the generated include/config.h file from my normal linux build, and from my Windows cross compile build that uses mingw. I looked at configure and found there is another possible definition for __ASM_FUNC, so I know I am missing one of the cases, but I can't test for it like the configure script does. Does anyone know how to do this properly? Thanks again for everyone who has helped on this issue. I have tried to look at all the previous comments made, and use evolve some of the code that was already written.

1 0

DWORD help
by Andrew Fenn 26 Oct '08

26 Oct '08

I have written the following but when I have dwUserIndex as 0,1,2,3 or any number, doesn't really matter, it always returns ERROR_BAD_ARGUMENTS. DWORD XInputGetState(DWORD dwUserIndex, XINPUT_STATE* pState) { FIXME("Stub - Controller: %d \n", dwUserIndex); if (dwUserIndex >= 0 && dwUserIndex < 4) { return ERROR_DEVICE_NOT_CONNECTED; /* If controller is connected return ERROR_SUCCESS */ } return ERROR_BAD_ARGUMENTS; }

4 6

Re: [PATCH] [WinHelp]: fix for 15367
by James McKenzie 25 Oct '08

25 Oct '08

Eric Pouech wrote: > > A+ > --- > > Eric: Was this patch rejected or pending approval? James McKenzie

1 0

RFC: wineprefix manager
by Steven Edwards 25 Oct '08

25 Oct '08

Hello, Over the past few months I've been developing a tool that I had hoped to demo at wineconf before my laptop started acting up. It is a Wine Prefix Manager I developed for Bordeaux, At this time its still tied pretty closely to glib and GTK and riddled with my horrid programing errors. Attached you will find a screenshot of the concept we are using in Bordeaux I've spoken with Alexandre a bit about it and he expressed interested in possibly having it be a winelib application. This would pose some interesting design decisions as we would need to create a method of having a wine delay certain operations until after the program exited or be able to run a builtin winelib application outside of any given prefix. My development plan short term is pretty simple: 1. Develop this application in tools/wineprefixmanager and allow third parties to develop graphical interfaces using the toolkit of choice. This would allow a KDE, GTK or even winelib frontend to do prefix management 2. a. Extra wineprefixes would be stored in the ~/.wineprefixes folder. If a user wants to use multiple prefixes one must be set to default which would create a symbolic link to ~/.wine b. This implies the ability to import an existing ~/.wine 3. As Wine's ability to interact with the Desktop Environment of choice improves, so would the options for prefix management (as implied by the associate option in the example below) 4. As Wine develops better multiuser support, support for other locations for storage of Global prefixes will have to be taken in to account. Alexandre also raised the question about if this would even really be all that useful. Below are the possible command line options we could support: Possible command line options include --active set a selected prefix as active or default --associate restore file associations --backup backup a selected prefix to a compressed archive --configure invoke winecfg after creation --copy copy a selected prefix to another name --create create based on a template such as default, win2000, winxp, etc. --delete delete a selected prefix --execute execute a windows application for a given prefix --force force operation without prompting --import import from and existing .wine directory --restart simulate a windows reboot for a given prefix --restore restore prefix from existing archive --list display a list of the current prefixes --menu regenerate Desktop and Menu entries --target TARGET option for --backup --copy and --create If there are no major objections and or no better ideas then over the next few months I will start refactoring the mess that is the Bordeaux Cellar Manager, breaking it out in to a non-glib command line only application, removing Bordeaux only options, submitting it as a series of patches, etc. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

re: [RFC] Fixes to allow developing Windows apps on Wine
by Dan Kegel 25 Oct '08

25 Oct '08

Kai wrote: > [Should we fix bug 11965 so winsock properly requires > WSAStartup() before it agrees to work?] I think so. I would certainly like Wine to be a good Win32 development environment. > we'd have to start tracking WSADATA structures per thread. Please submit a conformance test first demonstrating whether this is tracked per process or per thread. I'm betting it's per-process. Alexandre will probably pipe up then. - Dan

1 0

Re: [2/2] A nicer icon for "folder" in shell32
by Juan Lang 24 Oct '08

24 Oct '08

Hi Herve, sorry that I'm misspelling your name, the proper accent didn't show up on the mailing list archive. I didn't see patch 1/2. Perhaps it just didn't make it through moderation? --- a/dlls/shell32/Makefile.in +++ b/dlls/shell32/Makefile.in @@ -64,6 +64,7 @@ SPEC_SRCS16 = shell.spec EXTRA_OBJS = authors.o SVG_SRCS = folder_open.svg +SVG_SRCS = folder.svg This can't work, the second assignment of SVG_SRCS overwrites the first. You need something like: SVG_SRCS = \ folder_open.svg \ folder.svg instead. > It's a nicer icon for "folder" in shell32. Comments on this work are welcome (even if you dislike it) ! Any reason the icon is slightly right of center? Does Wine support the alpha channel in icons? --Juan

1 0

Re: ole32: implement IEnumFORMATETC_Next_Proxy (1/2) try 2
by Huw Davies 24 Oct '08

24 Oct '08

On Fri, Oct 24, 2008 at 04:45:46AM -0500, Austin English wrote: > diff --git a/dlls/ole32/usrmarshal.c b/dlls/ole32/usrmarshal.c > index b8487c3..dba69ca 100644 > --- a/dlls/ole32/usrmarshal.c > +++ b/dlls/ole32/usrmarshal.c > @@ -2398,8 +2398,11 @@ HRESULT CALLBACK IEnumFORMATETC_Next_Proxy( > FORMATETC *rgelt, > ULONG *pceltFetched) > { > - FIXME(":stub\n"); > - return E_NOTIMPL; > + ULONG fetched; > + if (!pceltFetched) > + pceltFetched = &fetched; > + return IEnumFORMATETC_RemoteNext_Proxy(This, > + celt, rgelt, pceltFetched); That's still not right. It gives the impression that the 'return' is part of the 'if' block. The 'return' line should be indented by four spaces not eight. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: ole32: implement IEnumFORMATETC_Next_Stub (2/2)
by Rob Shearman 24 Oct '08

24 Oct '08

2008/10/23 Austin English <austinenglish(a)gmail.com>: > - FIXME(":stub\n"); > - return E_NOTIMPL; > + > + HRESULT hr; > + *pceltFetched = 0; > + hr = IEnumFORMATETC_Next(This, > + celt, > + rgelt, > + pceltFetched); > + if (hr == S_OK) *pceltFetched = celt; > + return hr; This file uses 4-space indentation. -- Rob Shearman

1 1

Re: ole32: implement IEnumFORMATETC_Next_Proxy (1/2)
by Huw Davies 24 Oct '08

24 Oct '08

On Thu, Oct 23, 2008 at 01:35:55PM -0500, Austin English wrote: > diff --git a/dlls/ole32/usrmarshal.c b/dlls/ole32/usrmarshal.c > index b8487c3..be9ebff 100644 > --- a/dlls/ole32/usrmarshal.c > +++ b/dlls/ole32/usrmarshal.c > @@ -2398,8 +2398,13 @@ HRESULT CALLBACK IEnumFORMATETC_Next_Proxy( > FORMATETC *rgelt, > ULONG *pceltFetched) > { > - FIXME(":stub\n"); > - return E_NOTIMPL; > + ULONG fetched; > + if (!pceltFetched) > + pceltFetched = &fetched; > + return IEnumFORMATETC_RemoteNext_Proxy(This, > + celt, > + rgelt, > + pceltFetched); There's some strange indentation going on here. Could you make it all 4-space based? Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Re: gdi32: Add EMR_GDICOMMENT to the list of records producing output.
by Huw Davies 24 Oct '08

24 Oct '08

On Thu, Oct 23, 2008 at 09:32:43PM +0900, Dmitry Timoshkov wrote: > This completely fixes the print previews generated by MS Access in a Win9x > mode. Access has a custom handler for an EMR_GDICOMMENT record, and GDI APIs > it calls from it don't work properly due to wrong DC mapping. > --- > dlls/gdi32/enhmetafile.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c > index e998c60..22451d2 100644 > --- a/dlls/gdi32/enhmetafile.c > +++ b/dlls/gdi32/enhmetafile.c > @@ -692,6 +692,7 @@ static BOOL emr_produces_output(int type) > case EMR_LINETO: > case EMR_ARCTO: > case EMR_POLYDRAW: > + case EMR_GDICOMMENT: > case EMR_FILLRGN: > case EMR_FRAMERGN: > case EMR_INVERTRGN: Maybe it's time to rename this function to something like emr_updates_transform() since EMR_GDICOMMENT clearly doesn't produce any output. Huw. -- Huw Davies huw(a)codeweavers.com

2 2

Experience with msvcmaker and building wine core and test dlls with VC9
by Reece Dunn 24 Oct '08

24 Oct '08

Hi, I have been using msvcmaker to generate project files to build the various wine test programs with VC9 and have since started to look at getting code dlls to work. I have successfully built cabinet.dll locally on VC9, doing the following: 1. add the following to dlls/cabinet/Makefile.in: EXTRADEFS = -DCOM_NO_WINDOWS_H this is needed to prevent the __WINESRC__ including windows.h error (but not in all cases). 2. run tools/winapi/msvcmaker to generate the dsw/dsp project files. 3. import those files into VC9 and let VC9 convert them. 4. change interlocked_xchg_add to InterlockedExchangeAdd in libs/wine/debug.c. 5. in the include project, set the option not to compile mlang.idl, amvideo.idl and activdbg.idl - these still have problems building with the VC9 midl tool. 6. in the include project, set it to be a Utility project; this is because as a library the dependent projects try to pull in include.lib which does not exist. 7. build the cabinet project and its dependencies. Some projects (e.g. comctl32, shell32 and shlwapi) produce a ^\.lib dependency, which prevents them being loaded by the VC9 IDE when opening the converted solution files. The test projects don't seem to be handling rc (needed by the user32 tests, for example) and idl (needed by the oleaut32 tests, for example) targets correctly, but the projects for the wine dlls generate these correctly. - Reece

1 0

[RFC] Fixes to allow developing Windows apps on Wine
by Kai Blin 24 Oct '08

24 Oct '08

Hi folks, Austin just checked if bug #11965 [1] was still alive. I know it's still an issue, and I wonder if we would want to fix this sort of thing. Ok, actually the question is if Alexandre wants to have it fixed, I'd be happy to provide a patch. In short, the issue is that for people developing and testing Windows software in Wine, Wine will gladly do networking without anybody calling WSAStartup(), so this won't show up in tests. If you forget the WSAStartup call, the app will break on Windows. In order to fix this, we'd have to start tracking WSADATA structures per thread. Comments? Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Winelib and static-build
by Alan Nisota 24 Oct '08

24 Oct '08

I have a project (http://code.google.com/p/coreavc-for-linux) which is a linux executable which provides access to Windows DirectShow filters (despite its name, the program should work with many Directshow Video codecs). Currently, it builds against a forked version of mplayer's 'loader' library, but there are stability problems with this solution (the 'loader' library many hacks to provide just enough infrastructure to the codec, and debugging issues is difficult due to the binary nature of the filter) I found that building against winelib works quite well (once I found that I needed to define __MINGW__) and the stability is much better (in fact the program seems rock-solid now). The problem is that I normally provide a static binary so that users on x86-64 can install it easily without needing a 32bit build environment and without me needing to provide packages for every distribution. The host app (Mythtv, mplayer, xine), can still be 64bit, since I use shared-memory and semaphores to communicate, and this works fine between 32bit and 64bit apps. It seems that wine is available for most 32 and 64bit distros (built in a 32bit chroot in the x86-64 case). My question is, is it possible to do a static-compile of my winelib app that will run properly on multiple distros and interface with wine correctly? I'd be building against a fixed version of wine, (say 1.1.6 or 1.0, or whatever) but would want compatibility with whatever version the user's distro happens to provide (within reason). Is this possible? Sorry if this doesn't exactly belong on the dev list, it didn't seem to fit the user list either, and I couldn't find a better place.

1 0

Re: Wine & MS protocol help?
by Andrew Bartlett 23 Oct '08

23 Oct '08

On Thu, 2008-10-23 at 11:25 -0600, Brian Vincent wrote: > I thought someone might have posted this by now. Andrew Bartlet wrote > this: > > http://people.samba.org/people/abartlet/a-year-since-microsofts-appeal-fail… > > quote: > > "Microsoft has also answered dozens of documentation queries on the > cifs-protocol mailing list and in private email from PFIF members (the > PFIF is the umbrella organization that signed the WSPP agreement on > behalf of the Samba Team)." > > "However, the WSPP program and Microsoft's new protocol documentation > is not just about 'Samba' things - the protocols covered are any that > a windows client uses to talk to a windows server. Many other Free > Software projects can and should take advantage of the new > documentation and clarification process." > > "In might be reasonable to ask why Microsoft is putting such a strong > effort into making the WSPP agreement a success. Obviously the ongoing > EU legal appeal regarding the fines levied against Microsoft by the EU > could be a motivating factor, but regardless of that motivation the > individual engineers we are working with are responding with > enthusiasm." > > Reading on, it seems Samba got access to internal MS conformance tests > among other things. It seems like it's probably worth a few emails > the Andrew for details and a few calls to Microsoft to see if there's > anything that might help out with things besides CIFS. The trick is to find protocols in this list: http://msdn.microsoft.com/en-us/library/cc197979.aspx The other protocols you can access the 'community support' for (as Kai Blin has found out on the forums), but you can't do the e-mail or phone based stuff. Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Red Hat Inc.

1 0

Re: [PATCH] cabinet: support building with midl-generated headers.
by Reece Dunn 23 Oct '08

23 Oct '08

Please ignore this patch. The correct solution is to add EXTRADEFS = -DCOM_NO_WINDOWS_H to Makefile.in (e.g. see dlls/browseui/Makefile.in) - Reece

1 0

Re: ole32: quiet a ridiculously noisy fixme (resend)
by Huw Davies 23 Oct '08

23 Oct '08

On Wed, Oct 22, 2008 at 08:34:49PM -0500, Austin English wrote: > Reduces Open Office 3 application's output from infinity to 7 lines. > Last patch had an unnecessary whitespace change. > > -- > -Austin > From 0dead16d2588bce8330ed862f8e5b6d3c6bb71a7 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 22 Oct 2008 20:28:37 -0500 > Subject: [PATCH] ole32: quiet a ridiculously noisy fixme > > --- > dlls/ole32/usrmarshal.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/dlls/ole32/usrmarshal.c b/dlls/ole32/usrmarshal.c > index b8487c3..6886dfb 100644 > --- a/dlls/ole32/usrmarshal.c > +++ b/dlls/ole32/usrmarshal.c > @@ -2398,7 +2398,11 @@ HRESULT CALLBACK IEnumFORMATETC_Next_Proxy( > FORMATETC *rgelt, > ULONG *pceltFetched) > { > - FIXME(":stub\n"); > + static int quietfixme = 0; > + if (quietfixme == 0) { > + FIXME(":stub\n"); > + quietfixme = 1; > + } > return E_NOTIMPL; > } > The real implementation of this would actually result in fewer lines of code! See IEnumVARIANT_Next_Proxy / Stub (in oleaut32/usrmarshal.c) for an example. Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Re: (try 4) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2twice in rapid seccesion. handle this error.
by Dmitry Timoshkov 23 Oct '08

23 Oct '08

"Aric Stewart" <aric(a)codeweavers.com> wrote: > + /* > + * Windows XP is unable to recreate the ViewWindow2 returning > + * A Catastrophic failure error > + */ > + if (broken(hr == 0x8000ffff || hr == E_FAIL)) > + { > + skip("second attempt is a Catastrophic failure\n"); > + goto cleanup; > + } broken() is supposed to be used exclusively inside of ok() calls. -- Dmitry.

3 3

Re: [PATCH] msvcmaker: added COM_NO_WINDOWS_H to support midl-generated headers for __WINESRC__ components.
by Rob Shearman 23 Oct '08

23 Oct '08

2008/10/18 Reece Dunn <msclrhd(a)googlemail.com>: > When building the wine solution generated by msvcmaker, the components > generate errors that projects that define __WINESRC__ should not > include windows.h. > > I tracked this error down to windows.h being included from unknwn.h > (generated from unknwn.idl). This is from the code generated by VC9's > midl compiler. > > The midl generated code allows you to define COM_NO_WINDOWS_H to > prevent the inclusion of windows.h. That define is thus added to those > provided by msvcmaker. Any reason why this hasn't been applied yet? I've been testing with this applied and I believe it is an improvement and gets more DLLs compiling. -- Rob Shearman

3 4

Re: (try 2) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Michael Karcher 23 Oct '08

23 Oct '08

[resend with subscribed from] Am Donnerstag, den 23.10.2008, 07:41 -0500 schrieb Aric Stewart: > + /* > + * Windows XP is unable to recreate the ViewWindow2 returning > + * A Catastrophic failure error > + */ > + if (broken(hr == 0x8000ffff || hr == E_FAIL)) Any reason you don't use E_UNEXPECTED instead of the numerical constant? Regards, MIchael Karcher

1 0

Re: (try 3) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Paul Vriens 23 Oct '08

23 Oct '08

Aric Stewart wrote: > > Switch the second test to be the first one as it is more important. > So if we get to do only one do that one > --- > dlls/comdlg32/tests/filedlg.c | 19 +++++++++++++++---- > 1 files changed, 15 insertions(+), 4 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Aric, + if (broken(hr == 0x8000ffff || hr == E_FAIL)) + { + win_skip("second attempt is a Catastrophic failure\n"); broken() and win_skip(), wow :) The win_skip is not needed in this case. A normal skip() would do fine. -- Cheers, Paul.

1 0

Re: ole32: Stub implementation for CoGetCallerTID
by Rob Shearman 23 Oct '08

23 Oct '08

2008/10/23 Sylvain Petreolle <spetreolle(a)yahoo.fr>: > Content-Type: application/octet-stream; name="CoGetCallerTID.diff" Please ensure attached patches have a content type of text/<anything> instead of application/octet-stream, as reviewing them is difficult otherwise. -- Rob Shearman

1 0

Re: (try 2) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Michael Karcher 23 Oct '08

23 Oct '08

Am Donnerstag, den 23.10.2008, 07:41 -0500 schrieb Aric Stewart: > + /* > + * Windows XP is unable to recreate the ViewWindow2 returning > + * A Catastrophic failure error > + */ > + if (broken(hr == 0x8000ffff || hr == E_FAIL)) Any reason you don't use E_UNEXPECTED instead of the numerical constant? Regards, MIchael Karcher

1 0

RE: [6/6] d3d10: d3d10 doesn't need wined3d.
by Stefan Dösinger 23 Oct '08

23 Oct '08

Do you have any long-time intentions with this? Or are you just changing it because we don't need wined3d right now because d3d10 is a stub? > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Henri Verbeet > Sent: Wednesday, October 22, 2008 5:47 PM > To: wine-patches(a)winehq.org > Subject: [6/6] d3d10: d3d10 doesn't need wined3d. >

2 2

Re: wine users forum registration issue
by Andreas Mohr 23 Oct '08

23 Oct '08

Hi, On Tue, Oct 21, 2008 at 11:37:22AM -0400, WDDT(a)aol.com wrote: > Hi-- > > I'm a new user of linux and wine and was looking for some help with a > database program that ALMOST runs. I found an entry on the forum with a problem > similar to mine and wanted to comment, so I decided to register. Unfortunately, > I was unable to get the sign-in page to recognize the characters I typed in. > I tried several times, including case-matching and entering numbers on the > number pad. In fact, I attempted it enough times to be ruled out as having > tried too often. Is there an end-run to joining the forum or some magic insider > voodoo in place to keep fogeys like me out? (Because I could USE some voodoo > at this point with my database!) Any help would be appreciated. Thanks for your input! This is now about the 30th time (no, REALLY, this __IS__ the 30th time, or possibly even 50th!) that someone has severe issues with WineHQ forum registration, in the last 12 or so months. Could someone _please_ finally do something practical about it? Doing severe cross-posting to make sure this does get noticed, thanks. (I should be doing entirely different things ATM, but I simply cannot let this huge usability and mailbox clogging issue linger any longer, thus I'm escalating it, sorry) Thanks, Andreas Mohr

7 7

wine users forum registration issue
by Nicolas Le Cam 23 Oct '08

23 Oct '08

2008/10/23 Zachary Goldberg <zgold(a)bluesata.com>: > Captchas in general are not so good, and there are much better > anti-spam techniques out there (Such as asking an actual question. > There are phpbb mods which allow you to input a list of questions > (with perhaps links to wiki pages with answers) from which it'll chose > a random one to present a user at registration. This is very simple > for the user to get passed, just check the wiki for the answer to > hopefully an obvious and perhaps informative question, and nearly > impossible for the bots). > > So perhaps ditching the captcha in favor of something less error prone > is in order? 2008/10/23 Rosanne DiMesio <dimesio(a)earthlink.net>: > It took me about five tries to register for the forum several months > ago. The reason is simple: aging eyesight. I have problems with captchas > in general, but I have to say that some of the ones used for the forum > are especially difficult to see because the background of the image also > contains letters and number, and it is not always obvious which letters > and numbers are supposed to be "right" ones. Some captchas are really difficult to read (especially those with colors for people like me that are color blindless) but some other aren't. For exemple recaptchas [1] are easily readable. And it also helps archive.org digitalizing books. Perhaps switching to such a system will avoid crazy captchas and help people register onto the forum. [1] http://recaptcha.net/learnmore.html (Resending because I have again forgotten wine-devel ...)

1 0

Re: [Try 5] msvcrt: Set permissions of file in sopen
by Dmitry Timoshkov 23 Oct '08

23 Oct '08

"Ivan Peevski" <cyberhorse(a)gmail.com> wrote: > the pmode flag test should be: > if it has the IREAD but not the IWRITE flag (read only) > does that make sense? Is it doing what I think it is? It should be: if ((pmode & MSVCRT__S_IREAD) && !(pmode & MSVCRT__S_IWRITE)) ...; IMO it would be more convenient to use switch, that would cover all the possible cases: switch (pmode & (MSVCRT__S_IREAD | MSVCRT__S_IWRITE)) { case 0: ... case MSVCRT__S_IREAD | MSVCRT__S_IWRITE: ... case MSVCRT__S_IREAD: ... case MSVCRT__S_IWRITE: ... } Of course a test is needed to prove that. -- Dmitry.

1 0

Re: [1/2] richedit: Added test for correct behaviour for callingEditWordBreakProc.
by Dmitry Timoshkov 23 Oct '08

23 Oct '08

"Dylan Smith" <dylan.ah.smith(a)gmail.com> wrote: > EditWordBreakProc documented the third parameter as being the number of > unicode characters in the string for richedit 2.0 and up. It turns out > that it should actually be the number of bytes in the string. Have you tried to set a unicode word break proc? The behaviour you see could be explained by the use of SendMessageA in your test, or even most likely an ANSI richedit window (RICHEDIT_CLASS vs. RICHEDIT_CLASSW). -- Dmitry.

1 0

Re: [Try 5] msvcrt: Set permissions of file in sopen
by Dmitry Timoshkov 23 Oct '08

23 Oct '08

"Ivan Peevski" <cyberhorse(a)gmail.com> wrote: > + if (pmode & (MSVCRT__S_IREAD & !MSVCRT__S_IWRITE)) > + attrib |= FILE_ATTRIBUTE_READONLY; The pmode flags test doesn't look right. Also the 'attrib |= ' line has a trailing space. -- Dmitry.

1 0

Re: [Try 5] msvcrt: Set permissions of file in sopen
by Austin English 23 Oct '08

23 Oct '08

On Wed, Oct 22, 2008 at 10:13 PM, Ivan Peevski <cyberhorse(a)gmail.com> wrote: > Followed the documentation at http://msdn.microsoft.com/en-us/library/w7sa2b22(VS.80).aspx. Ignore pmode if the file already exist and emulate permissions as best we can during file creation. > > --- > dlls/msvcrt/file.c | 13 ++++++++----- > 1 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c > index 7c0f74d..7b2a33e 100644 > --- a/dlls/msvcrt/file.c > +++ b/dlls/msvcrt/file.c > @@ -1422,6 +1422,7 @@ int CDECL MSVCRT__sopen( const char *path, int oflags, int shflags, ... ) > int pmode; > DWORD access = 0, creation = 0, attrib; > DWORD sharing; > + struct MSVCRT__stat buf; > int wxflag = 0, fd; > HANDLE hand; > SECURITY_ATTRIBUTES sa; > @@ -1430,6 +1431,8 @@ int CDECL MSVCRT__sopen( const char *path, int oflags, int shflags, ... ) > TRACE(":file (%s) oflags: 0x%04x shflags: 0x%04x\n", > path, oflags, shflags); > > + attrib = FILE_ATTRIBUTE_NORMAL; > + > wxflag = split_oflags(oflags); > switch (oflags & (MSVCRT__O_RDONLY | MSVCRT__O_WRONLY | MSVCRT__O_RDWR)) > { > @@ -1444,10 +1447,11 @@ int CDECL MSVCRT__sopen( const char *path, int oflags, int shflags, ... ) > pmode = va_arg(ap, int); > va_end(ap); > > - if(pmode & ~(MSVCRT__S_IREAD | MSVCRT__S_IWRITE)) > - FIXME(": pmode 0x%04x ignored\n", pmode); > - else > - WARN(": pmode 0x%04x ignored\n", pmode); > + /* Ignore _S_IREAD and _S_IWRITE if file exists. */ > + if (MSVCRT__stat(path, &buf) != 0) > + if (pmode & (MSVCRT__S_IREAD & !MSVCRT__S_IWRITE)) > + attrib |= FILE_ATTRIBUTE_READONLY; > + /* Ignore any irrelevant flags. */ > > if (oflags & MSVCRT__O_EXCL) > creation = CREATE_NEW; > @@ -1482,7 +1486,6 @@ int CDECL MSVCRT__sopen( const char *path, int oflags, int shflags, ... ) > ERR( "Unhandled shflags 0x%x\n", shflags ); > return -1; > } > - attrib = FILE_ATTRIBUTE_NORMAL; > > if (oflags & MSVCRT__O_TEMPORARY) > { > -- > 1.5.4.3 > > > > Can you add a testcase for this to dlls/msvcrt/tests/file.c? -- -Austin

1 0

Re: [include] - add dde.rh
by Dmitry Timoshkov 23 Oct '08

23 Oct '08

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > Changelog > -------------- > Add dde.rh Why are you plain copying it from PSDK? -- Dmitry.

1 0

make test solution
by chris ahrendt 22 Oct '08

22 Oct '08

NM figured it out... some odd reason the git directory has to be mapped to a windows drive.. once I did that.. it all cleaned up... chris

1 0

make test issue..
by chris ahrendt 22 Oct '08

22 Oct '08

I have a general question on the make files... specifically the make test portion of it.. Since talking to dan about things this would be where I could be of most help. I have an issue with the make test currently.. I am getting : [cahrendt@stinky wine-git]$ make test make[1]: Entering directory `/home/cahrendt/wine-git/tools' make[1]: `makedep' is up to date. make[1]: Leaving directory `/home/cahrendt/wine-git/tools' make[1]: Entering directory `/home/cahrendt/wine-git/dlls' make[2]: Entering directory `/home/cahrendt/wine-git/dlls/advapi32/tests' ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so cred.c && touch cred.ok Warning: could not find DOS drive for current working directory '/home/cahrendt/wine-git/dlls/advapi32/tests', starting in the Windows directory. wine: could not load L"C:\\windows\\system32\\advapi32_test.exe.so": Module not found make[2]: *** [cred.ok] Error 126 make[2]: Leaving directory `/home/cahrendt/wine-git/dlls/advapi32/tests' make[1]: *** [advapi32/tests/__test__] Error 2 make[1]: Leaving directory `/home/cahrendt/wine-git/dlls' make: *** [dlls/__test__] Error 2 which is not a code issue as far as I am able to see but rather a make file issue. As you see the advapi32 test can't be found. However if you look in the directory the .so is there... so I need some assistance to help me understand where and how the make test works so I can figure out why its looking in the system32 directory and not the current directory for the shared object. Any help? Chris

1 0

Re: [PATCH 1/2] jscript: Added Math.floor implementation.
by Vincent Povirk 22 Oct '08

22 Oct '08

+tmp = Math.floor(1.1); +ok(tmp === 1, "Math.round(1.1) = " + tmp); Copy/paste error? Vincent Povirk 2008/10/21 Jacek Caban <jacek(a)codeweavers.com>: > --- > dlls/jscript/math.c | 20 ++++++++++++++++++-- > dlls/jscript/tests/api.js | 18 ++++++++++++++++++ > 2 files changed, 36 insertions(+), 2 deletions(-) > > > >

2 1

re: Dylan Smith : richedit:Added tests for ctrl-key shortcut handling in WM_KEYDOWN.
by Dan Kegel 22 Oct '08

22 Oct '08

Dmitry wrote: >> + BYTE key_state[256]; >> +... >> + result = GetKeyboardState((LPBYTE)&key_state); > the casts in the above code clearly > show that the pointer syntax is wrong there. Nah. It's ugly, but not wrong. key_state == &key_state here. - Dan

1 0

Re: cryptui: Add a partial implementation of CryptUIWizImport.
by Juan Lang 22 Oct '08

22 Oct '08

> Yes, so those users may benefit from the stub as well. And I do print > a FIXME. This is nothing new, we've been ignoring invalid certificates > in wininet for years where we should stop and show a UI. When I tested with native cryptui and imported a cert, it didn't pick the root store. So I'm just not convinced it's doing the correct thing. That the root store is at present read-only makes it even more certain it doesn't do what the user expects at the moment. Perhaps that needs to be fixed as well, but that's a separate discussion. We need to be sure adding to the root store is the correct thing in the first place. I'm not against stubs, I just think this one needs some tests. They shouldn't be that hard to write: test the root store before and after importing a cert with no UI, and see if the cert is added to the root store. Try with a few different kinds of certs (self-signed, not self-signed.) If they're always added to the root store, I'll be more persuaded. Right now I'm not. --Juan

1 0

Re: cryptui: Add a partial implementation of CryptUIWizImport.
by Hans Leidekker 22 Oct '08

22 Oct '08

On Wednesday 22 October 2008 16:37:16 you wrote: > I don't think that's typical usage at all: typical usage presents a > UI. It's called from elsewhere in cryptui, so it's under the control Sure, but the app may present its own UI like Outlook does, and call this function with CRYPTUI_WIZ_NO_UI set. > of the user how frequently this is used. You add a cert to the root > store even when a UI is requested. This is clearly incorrect. Yes, so those users may benefit from the stub as well. And I do print a FIXME. This is nothing new, we've been ignoring invalid certificates in wininet for years where we should stop and show a UI. I'm not saying we shouldn't implement this or not be secure, it's just a matter of priorities. -Hans

1 0

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.
by Rob Shearman 22 Oct '08

22 Oct '08

2008/10/21 Huw Davies <huw(a)codeweavers.com>: > @@ -1728,6 +1767,10 @@ static HRESULT WINAPI DefaultHandler_IPersistStorage_HandsOffStorage( > if(SUCCEEDED(hr) && object_is_running(This)) > hr = IPersistStorage_HandsOffStorage(This->pPSDelegate); > > + old_stg = InterlockedExchangePointer((void**)&This->storage, NULL); IIRC, the default handler is apartment-threaded only, meaning that a default handler object cannot be used on a thread other than the one it was created on. Adding constructs like this introduce confusion to future developers about whether the code is or isn't thread-safe and so it should be avoided and a non-thread-safe construct used instead. > + if(old_stg) IStorage_Release(old_stg); > + This->storage_state = storage_state_uninitialised; > + > return hr; > } -- Rob Shearman

2 3

Re: cryptui: Add a partial implementation of CryptUIWizImport.
by Juan Lang 22 Oct '08

22 Oct '08

Hi Hans, I know this patch already got committed. +BOOL WINAPI CryptUIWizImport(DWORD dwFlags, HWND hwndParent, LPCWSTR pwszWizardTitle, + PCCRYPTUI_WIZ_IMPORT_SRC_INFO pImportSrc, HCERTSTORE hDestCertStore) +{ + static const WCHAR Root[] = {'R','o','o','t',0}; (snip) + if (!(cert = CertCreateCertificateContext(encoding, buffer, size))) + { + WARN("unable to create certificate context\n"); + HeapFree(GetProcessHeap(), 0, buffer); + return FALSE; + } + /* FIXME: verify certificate and determine store name dynamically */ + if (!(store = CertOpenStore(CERT_STORE_PROV_SYSTEM_W, 0, 0, CERT_SYSTEM_STORE_CURRENT_USER, Root))) + { + WARN("unable to open certificate store\n"); + CertFreeCertificateContext(cert); + HeapFree(GetProcessHeap(), 0, buffer); + return FALSE; + } + ret = CertAddCertificateContextToStore(store, cert, CERT_STORE_ADD_REPLACE_EXISTING, NULL); This doesn't look correct. Why are you always using the root store, and ignoring hDestCertStore? Even if you expect hDestCertStore to be NULL (in which case a default store may make sense), using the Root store seems like it won't do what the user wants. The certificate won't be persisted if it's added to the Root store, because the Root store is only read from the local system. When the process (Outlook) exits, the certificate will no longer exist. It should be possible to add a test that shows which store the certificate should be added to, if nothing else to satisfy my doubt. --Juan

4 14

Re: wine users forum registration issue
by James Mckenzie 22 Oct '08

22 Oct '08

Kai Blin <kai.blin(a)gmail.com> at Oct 22, 2008 12:36 AM wrote about wine users forum registration issue > >On Tuesday 21 October 2008 18:25:19 Andreas Mohr wrote: > >Given that most people on this list don't seem to use the forum and thus don't >notice, how about the people who actually use the forum get together and >figure out a way to make it work? Alternatively, as was suggested before, we >could ditch the forums and point people to the google groups interface for >the wine-users list. +1 > >> Doing severe cross-posting to make sure this does get noticed, thanks. > >Have a cookie. Don't know why CCing wine-patches should help, unless you want >patchwatcher to notice. > Or have an adult beverage if you can. In other words: Chill. Life is not worth getting wrapped up in this stuff. > >Right. So the forum software is broken, and all of the Wine devs would rather >fix Wine than the forums? Sounds like a good case for ditching the forums. +1. The forums have been nothing but a problem since their incorporation into the mailing list. Several long time mailing list users have left due to this. Their experiences are invaluable and they will not be back until the forums are long gone. > >Will code for cotton. Will code for food, drink and a place to live. James McKenzie

1 0

Re: configure: Require at least version 1.6 of gnutls.
by James Mckenzie 22 Oct '08

22 Oct '08

Francois Gouget <fgouget(a)free.fr> at Oct 22, 2008 2:15 AM wrote about configure: Require at least version 1.6 of gnutls. > >On Tue, 21 Oct 2008, James Mckenzie wrote: > >> Henri Verbeet <hverbeet(a)gmail.com> at Oct 21, 2008 10:04 AM wrote about configure: Require at least version 1.6 of gnutls. >> >> Why are we looking to use gnutls 1.6? Is there a feature that is >> needed for Wine? If so, I will have to check Fink before building >> Darwine again. > >Yes, we use the following types and functions (and maybe more) which are >not available in the very old Gnutls versions: > Since you stated 'very old' version, so I have a question. When did these functions become available? I am not going to assume that they were introduced with version 1.6. > gnutls_alert_description_t > gnutls_transport_set_errno > > >For the autoconf check it's probably enough to just check for >gnutls_transport_set_errno() and warn if it's missing. This is a good idea. We should check for the newest function and if it is not available, force an error and let the user know that these are available with version 1.6. <HUMOR> > The software said it requires Win95 or better, so I installed Linux. I used "The software said it requires Win95 or better, so I installed OS/2". I miss it. Now I use a Mac and wish I had started with one. </HUMOR> James McKenzie

1 0

re: QueryDosDevice
by Dan Kegel 22 Oct '08

22 Oct '08

Tomasz Salacinski wrote: > I was trying to find a solution for bug 5351... Are you trying to fix it, or just work around it? "winetricks volnum" works around it just fine. > I need to have Visual Studio on Linux (otherwise I will have > to install Windows), and I can try to fix the problem. I can code in C, > but I need Visual Studio and C# for my school Which version? 2005 kind of works, see http://appdb.winehq.org/objectManager.php?sClass=version&iId=14208 http://appdb.winehq.org/objectManager.php?sClass=version&iId=4494 but 2008 doesn't, see http://appdb.winehq.org/objectManager.php?sClass=version&iId=11210 http://appdb.winehq.org/objectManager.php?sClass=version&iId=11022 2008 is likely to be difficult to support, so don't get your hopes up there. - Dan

1 0

Re: Dylan Smith : richedit:Added tests for ctrl-key shortcut handling in WM_KEYDOWN.
by Dmitry Timoshkov 22 Oct '08

22 Oct '08

"Alexandre Julliard" <julliard(a)winehq.org> wrote: > +static BOOL hold_key(int vk) > +{ > + BYTE key_state[256]; > + BOOL result; > + > + result = GetKeyboardState((LPBYTE)&key_state); > + ok(result, "GetKeyboardState failed.\n"); > + if (!result) return FALSE; > + key_state[vk] |= 0x80; > + result = SetKeyboardState((LPBYTE)&key_state); > + ok(result, "SetKeyboardState failed.\n"); > + return result != 0; > +} > + > +static BOOL release_key(int vk) > +{ > + BYTE key_state[256]; > + BOOL result; > + > + result = GetKeyboardState((LPBYTE)&key_state); > + ok(result, "GetKeyboardState failed.\n"); > + if (!result) return FALSE; > + key_state[vk] &= ~0x80; > + result = SetKeyboardState((LPBYTE)&key_state); > + ok(result, "SetKeyboardState failed.\n"); > + return result != 0; > +} This is already committed, but the casts in the above code clearly show that the pointer syntax is wrong there. -- Dmitry.

1 0

Re: [PATCH 1/3] ole32: Create the '\1Ole' stream.
by Rob Shearman 22 Oct '08

22 Oct '08

2008/10/21 Huw Davies <huw(a)codeweavers.com>: > +/*********************************************************************** > + * init_ole_stream > + * > + * Creates the '\1Ole' stream. > + * The format of this stream is as follows: > + * > + * DWORD Version == 0x02000001 > + * DWORD Flags - high bit set indicates the object is a link otherwise it's embedded. > + * DWORD LinkupdateOption - [MS-OLEDS describes this as an implementation specific hint > + * supplied by the app that creates the data structure. May be > + * ignored on processing]. > + * > + * DWORD Revserved == 0 Typo. > + * DWORD MonikerStreamSize - size of the rest of the data (ie CLSID + moniker stream data). > + * CLSID clsid - class id of object capable of processing the moniker > + * BYTE data[] - moniker data for a link > + */ Please add some tests that show the layout as documented here is correct and is what the code does. -- Rob Shearman

1 0

QueryDosDevice
by Tomasz Salacinski 22 Oct '08

22 Oct '08

Hello, I was trying to find a solution for bug 5351 and I've found it. When user is trying to install Visual Studio he gets a message: Unable to find a volume for file extraction. Please verify that you have proper permissions. The problem is, that when vcssetup.exe is running, it is using function QueryDosDeviceW to query dos devices on the system and looks for device with either "harddisk" or "ramdisk" in its name. Because it fails, installation cannot proceed. It checks drives like this: QueryDosDevice for C:\ returns "\\drive_c" <-- no harddisk in the string QueryDosDevice for D:\ returns "\\home\\something" <-- again, the same QueryDosDevice for Z:\ returns "\\" <-- still the same There are few possible solutions on how to fix this: 1) Rename drive_c to harddiskvolume1 - this could force users to install applications again, but new wine version could just move the files to the new directory on startup and change the configuration file for drive C:\ to point to harddiskvolume1 2) Create a symlink to drive_c in wine directory and automatically create drive D:\ which points to that symlink (which is very bad, because user will have two drives that point to the same location). 3) Convert QueryDosDeviceW so that it will return always "harddiskvolume1" when application asks for "c". This can, but doesn't have to break some applications, though. I've applied the second solution to WINE and Visual Studio continues to install, but WINE should apply this automatically so these installers could work out-of-the-box (AFAIK this bug applies to other applications as well, such as MS Office - but I can't confirm that). Please tell me, which solution is the best one (or if you have a different solution, tell me). I need to have Visual Studio on Linux (otherwise I will have to install Windows), and I can try to fix the problem. I can code in C, but I need Visual Studio and C# for my school (yes, I know Monodevelop but I need to have Visual Studio projects). Cheers.

1 0

RFC: Implement XML loading in msxml3 directly from IStream
by Michael Karcher 22 Oct '08

22 Oct '08

Hello developers, the current implementation of IPersistStream::Load for XMLDOMDocument takes a copy of the given stream into a hglobal stream, and uses a helper function to parse that, namely parse_xml that calls xmlReadMemory if available (since 2.6.0) and uses the old xmlParseMemory call otherwise. If libxml2 is new enough, it is possible to parse directly from the stream using xmlReadIO to avoid copying the whole stream contents to memory. The function xmlReadIO was introduced in libxml 2.6.0, five years ago. If I want to use that function, do I have to create an alternative code path for such ancient libxml implemementations, or is it OK to require libxml 2.6.0 as minimum for libxml (even Debian Sarge, i.e. oldstable has it)? Another question arose on looking at the current implementation. If Wine is not going the direct-stream-to-libxml2-way, but wants to take a copy, currently the copying is performed manually, although there is a function CopyTo in IStream that takes care of creating the copy. I attached two diff files, - load-via-readio.diff shows the way that calls stream callbacks from libxml2 - load-use-copyto.diff uses the CopyTo function, but still copies. Thanks in advance for any feedback, Michael Karcher

1 1

Re: advapi32: Fall back to /dev/random if /dev/urandom can't be opened, and add warnings if opening either fails (try 2)
by Alexandre Julliard 22 Oct '08

22 Oct '08

"Juan Lang" <juan.lang(a)gmail.com> writes: > Changed a WARN to a FIXME. Any other suggestions? I don't see the point. Is there really a platform that has /dev/random but not /dev/urandom, and a /dev/random that is guaranteed not to block? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shell32: try to guess the working directory in the run dialog
by Juan Lang 22 Oct '08

22 Oct '08

Hi Vincent, + while (*src) + { + *dest = *src; + if (*src == '\\') + { + DWORD attrs = GetFileAttributesW(result); It sure looks like you're calling GetFileAttributesW with a non-NULL-terminated string. I doubt this will work as you intend. --Juan

3 5

Re: configure: Require at least version 1.6 of gnutls.
by James Mckenzie 22 Oct '08

22 Oct '08

Henri Verbeet <hverbeet(a)gmail.com> at Oct 21, 2008 10:04 AM wrote about configure: Require at least version 1.6 of gnutls. > > Why are we looking to use gnutls 1.6? Is there a feature that is needed for Wine? If so, I will have to check Fink before building Darwine again. Thank you. James McKenzie

2 1

Re: paint: Add new program
by Austin English 21 Oct '08

21 Oct '08

On Mon, Oct 20, 2008 at 8:27 PM, Hirofumi Katayama <katayama.hirofumi.mz(a)gmail.com> wrote: > See attachment. > > > > Howdy, Thanks for the patch, a few comments: >From b5fc5d2fc2c74507aa2dcf2daa4fe404e9b1ba06 Mon Sep 17 00:00:00 2001 From: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> Date: Tue, 21 Oct 2008 03:41:08 +0900 Subject: [PATCH] paint: Add new program --- .gitignore | 1 + configure | 11 + configure.ac | 1 + Don't include changes to configure, it is built automatically from configure.ac. Make any needed changes there. Your patch doesn't apply cleanly: bash-3.2$ git apply ../paint.txt ../paint.txt:425: trailing whitespace. ../paint.txt:428: trailing whitespace. ../paint.txt:438: trailing whitespace. ../paint.txt:449: trailing whitespace. ../paint.txt:765: trailing whitespace. warning: configure has type 100755, expected 100644 warning: tools/make_makefiles has type 100755, expected 100644 warning: squelched 71 whitespace errors warning: 76 lines add whitespace errors. Why are you changing the permissions on those files? -- -Austin

1 0

Re: configure: Require at least version 1.6 of gnutls.
by Alexandre Julliard 21 Oct '08

21 Oct '08

"Henri Verbeet" <hverbeet(a)gmail.com> writes: > @@ -916,17 +916,20 @@ WINE_NOTICE_WITH(hal,[test "x$ac_cv_lib_soname_hal" = "x"], > dnl **** Check for libgnutls **** > if test "x$with_gnutls" != "xno" -a "$PKG_CONFIG" != "false" > then > - ac_save_CPPFLAGS="$CPPFLAGS" > - ac_gnutls_libs="`$PKG_CONFIG --libs gnutls 2>/dev/null`" > - ac_gnutls_cflags="`$PKG_CONFIG --cflags gnutls 2>/dev/null`" > - CPPFLAGS="$CPPFLAGS $ac_gnutls_cflags" > - AC_CHECK_HEADER(gnutls/gnutls.h, > - [WINE_CHECK_SONAME(gnutls,gnutls_global_init, > - [AC_SUBST(GNUTLSINCL,"$ac_gnutls_cflags")],,[$ac_gnutls_libs])]) > - CPPFLAGS="$ac_save_CPPFLAGS" > + if $PKG_CONFIG --atleast-version=1.6 gnutls You should check for the features we depend on, not the version number. -- Alexandre Julliard julliard(a)winehq.org

1 0

Patchwatcher status
by Dan Kegel 21 Oct '08

21 Oct '08

The blacklist has grown a bit, adding d3d8:visual.c winhttp:Timeout...Killing.child wldap32:parse.c wldap32/tests/__test__ Rob has been busy helping get the distributed patchwatcher scripts working. He has a msvc9 build slave coming along nicely(!). I've ordered a second computer to use as a second build slave, and am considering how to get the latency of valgrind runs low enough to be useful. (I think I've going to add a filter to the alarm.c I pass as WINETEST_WRAPPER, and use that to select which part of the test suite each build slave should run. That way I can have five build slaves each doing a fifth of the test suite in parallel.) It's not quite trivial to get this all going, so no idea when it'll be online. - Dan

1 0

Re: winmm: MMIO_ALLOCBUF is ignored if mmioOpen gets a valid buffer.
by Paul Vriens 21 Oct '08

21 Oct '08

Dmitry Timoshkov wrote: > Existing tests show that MMIO_ALLOCBUF flag is dropped if a valid buffer > is being passed to mmioOpen, that means the buffer is valid in that case. > > This patch fixes a regression reported in the bug 15694. > --- > dlls/winmm/mmio.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/winmm/mmio.c b/dlls/winmm/mmio.c > index 60b6d0f..a750bf2 100644 > --- a/dlls/winmm/mmio.c > +++ b/dlls/winmm/mmio.c > @@ -667,10 +667,11 @@ HMMIO MMIO_Open(LPSTR szFileName, MMIOINFO* refmminfo, DWORD dwOpenFlags, > refmminfo->wErrorRet = MMIO_SetBuffer(wm, refmminfo->pchBuffer, refmminfo->cchBuffer, 0); > if (refmminfo->wErrorRet != MMSYSERR_NOERROR) > goto error1; > - if (wm->info.fccIOProc == FOURCC_MEM) > - wm->bBufferLoaded = TRUE; > } > > + if (wm->info.fccIOProc == FOURCC_MEM && !(wm->info.dwFlags & MMIO_ALLOCBUF)) > + wm->bBufferLoaded = TRUE; > + > /* see mmioDosIOProc for that one */ > wm->info.adwInfo[0] = refmminfo->adwInfo[0]; > Hi, Is there a way the existing tests can be improved? Apparently the existing tests show the behaviour but didn't prevent the regression. -- Cheers, Paul.

2 1

Re: wldap32/tests: modify test that was failing on every windows system
by Hans Leidekker 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 14:29:45 Aric Stewart wrote: > - ok( !ret, "ldap_search_ext_sA failed 0x%x\n", ret ); > + ok( ret==0x55 || ret == 0x51, "ldap_search_ext_sA unexpected return 0x%x\n", ret ); This should be fixed by my last patch already. -Hans

2 1

Re: wintrust: Implement CryptCATAdminCalcHashFromFileHandle, try 2
by Alexandre Julliard 21 Oct '08

21 Oct '08

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > + curpos.QuadPart = 0; > + SetFilePointerEx(hFile, curpos, &oldpos, FILE_CURRENT); > + SetFilePointerEx(hFile, curpos, NULL, FILE_BEGIN); That's not thread-safe. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Wine PulseAudio Driver
by Arthur Taylor 21 Oct '08

21 Oct '08

> Where are the patches? Should they have been attached here? Sorry, I guess I should have specified. The patches are in the bugzilla entry http://bugs.winehq.org/show_bug.cgi?id=10495 . The patches are too big for attaching. -- Arthur Taylor <theycallhimart(a)gmail.com>

1 0

Re: setupapi: Implement installing catalog files
by Alexandre Julliard 21 Oct '08

21 Oct '08

Maarten Lankhorst <maarten(a)codeweavers.com> writes: > + wintrust = LoadLibraryW(wintrust_dll); > + pCryptCATAdminAcquireContext = (void *)GetProcAddress(wintrust, "CryptCATAdminAcquireContext"); > + pCryptCATAdminAddCatalog = (void *)GetProcAddress(wintrust, "CryptCATAdminAddCatalog"); > + pCryptCATAdminReleaseCatalogContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseCatalogContext"); > + pCryptCATAdminReleaseContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseContext"); > + FreeLibrary(wintrust); I doubt that calling functions in an unloaded library is going to give good results... -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [TRY 4] msvcrt: updated use of pmode flag in _s_open - set permissions of the file after it's been created.
by Alexandre Julliard 21 Oct '08

21 Oct '08

Ivan Peevski <cyberhorse(a)gmail.com> writes: > ChangeLog: > Followed the documentation at > http://msdn.microsoft.com/en-us/library/w7sa2b22(VS.80).aspx. First, > ignore pmode if the file already exist. Then, apply pmode permissions > to the file, once it has been created. This should be done by passing the right attributes to CreateFile. You shouldn't need a separate chmod call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: No response to updated patch for gdi32/StretchDIBits
by Sergey Novosyolov 21 Oct '08

21 Oct '08

В сообщении от Tuesday 14 October 2008 23:54:54 Mathias Kosch написал(а): > Hallo! > > About two weeks ago I tried to hand in a (corrected version of my) > patch for "StretchDIBits" [1]. > However it isn't accepted until now and I didn't yet notice any > response. > > Would someone please tell me what's wrong or if it was just missed out > accidentally? > > [1] http://www.winehq.org/pipermail/wine-patches/2008-September/062221.html Hi, Mathias. I'm working on DIB Engine for Wine. Some of DIB functions was developed separatly inthe DIB Driver, but it's necessary to develop DIB Engine functions inside GDI 32. What DIB function tests are you working on? Is it only "StretchDIBBits" or something else? I'm developing some DIB tests now and want to avoid any collisions with other developers in this bug.

1 0

Re: latest GIT
by chris ahrendt 21 Oct '08

21 Oct '08

Austin English wrote: > On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt <celticht32(a)yahoo.com> wrote: > >> Anyone else having a problem compiling the latest git? >> >> mine has failed 2 times when I compile... one with a clean tree and one >> with an older tree.. >> >> chris >> >> >> >> __________________________________________________ >> Do You Yahoo!? >> Tired of spam? Yahoo! Mail has the best spam protection around >> http://mail.yahoo.com >> >> >> >> > > What error are you getting? What gcc version? > > so has anyone figured out why its broken yet? chris __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Re: gdi32: fix a potential NULL pointer dereference
by Alexandre Julliard 21 Oct '08

21 Oct '08

"Austin English" <austinenglish(a)gmail.com> writes: > From bd4408eccc01418077727b75f8383fb4d03d2b90 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Mon, 20 Oct 2008 16:43:27 -0500 > Subject: [PATCH] gdi32: fix a potential NULL point dereference Please don't add NULL checks unless there's a demonstrated need. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 08/12] (resend) LookupAccountSidW() - handles first user account
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 08:29:47 Paul Bryan Roberts wrote: > The conformance tests for LookupAccountName() use LookupAccountSid() so > if the former is to support the 'first user account' SID then so must > the latter and the latter needs prior implementation. There's no guarantee that the first user account will have a RID of 1000. This is just what windows currently seems to use. That being said, the test cases work on a test machine of mine where RID 1000 is not assigned to the first user, so I won't complain. Perhaps the comment should mention that the RID pool starts at 1000 or somesuch. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [PATCH 12/12] (resend) LookupAccountNameW() - accept account name of the form domain\user
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 08:30:27 Paul Bryan Roberts wrote: > The implementation is backed up with a new conformance case, which was > verified against W2K SP4. After the complete test series, the advapi32/tests/security.c tests pass fine against a Win2k3 DC. Thanks for pushing this further along. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [PATCH 11/12] LookupAccountNameW() - refactor to eliminate code duplication
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 01:06:45 Paul Bryan Roberts wrote: > - FIXME("%s %s %p %p %p %p %p - stub\n", debugstr_w(lpSystemName), debugstr_w(lpAccountName), > + TRACE("%s %s %p %p %p %p %p - stub\n", debugstr_w(lpSystemName), debugstr_w(lpAccountName), > Sid, cbSid, ReferencedDomainName, cchReferencedDomainName, peUse); If you still consider this function a stub, please keep the FIXME, otherwise, please remove the "- stub" from the TRACE. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [PATCH 07/12] LookupAccountNameW() - NULL account name handled
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 01:05:34 Paul Bryan Roberts wrote: Hi Paul, I'm glad to see someone tackle this. One minor thing I have with this patch.. > + ok(sid_use == SidTypeDomain, "Expected SidTypeDomain, got %d\n", SidTypeDomain); seems like this should be ok(sid_use == SidTypeDomain, "Expected SidTypeDomain(%d), got %d\n", SidTypeDomain, sid_use); This was wrong before already, but perhaps you could fix that while touching that code anyway. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Wine PulseAudio Driver
by Arthur Taylor 21 Oct '08

21 Oct '08

"If someone wants to write a pulseaudio driver, he should feel free to do so, but he should be aware that just writing a simple 20 line linear PCM out driver is not sufficient." http://bugs.winehq.org/show_bug.cgi?id=10495 I have written a waveout/in driver for wine to use pulseaudio which is in bugzilla. I would appreciate feedback on it, as I have received little thus far. I would appreciate it also if people took care to ensure that their instance of pulseaudio is properly setup before trying. Current problems include properly recovering from disconnects of both audio streams and server connections. WaveIn is currently buggy and usually has a larger latency. Multiple instances of one sink/source is also currently a problem. Currently WaveIn / WaveOut wodMessage / widMessage functions use "device IDs" which are basically array indexes of an array of available "devices." Without instance information it is hard to allow an application to open the same device more than once. Thanks - Art

6 14

Re: mshtml: Implement IHTMLStyle get/put posLeft (Try 7)
by Jacek Caban 21 Oct '08

21 Oct '08

Alistair Leslie-Hughes wrote: > Hi, > Clean up the get function. > Make sure we round down the value passed in. > Corrected test to prove above. > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft > + + V_VT(&v) = VT_I4; + V_I4(&v) = floor(f); + + if(VariantChangeType(&v, &v, 0, VT_BSTR) == S_OK) - It won't work for some locales - It's probably better to use sprintfW for this and set units to px for free + hres = get_style_attr(This, STYLEID_LEFT, &ret); + if(SUCCEEDED(hres)) + { + if(ret) + *p = atoiW(ret); + } - Your patch adds support only for px values, so you should check if we really return px value. Something like for(ptr=ret; isdigitW(*ptr); ptr++); if(*ptr || strcmp(ptr, pxW)) { FIXME(...); return E_NOTIMPL; } should be fine. - You leak ret - It's better to use get_nsstyle_attr_nsval to avoid one useless memory allocation. And you really want to move these function to separated functions like [get|set]_style_pos that would take styleid_t as an argument to avoid code duplication. Jacek

1 1

DOS game support - just needs a little VGA love?
by Dan Kegel 21 Oct '08

21 Oct '08

Hey, that CGA video support patch today from Peter Dons Tychsen, http://winehq.org/pipermail/wine-patches/2008-October/063417.html reminded me there's an old downloadable DOS game my wife likes to dig out every now and then. I tried it today and discovered that what's stopping it is support for a VGA feature, so I filed a bug: http://bugs.winehq.org/show_bug.cgi?id=15688 There are three other similar bugs, some with patches: http://bugs.winehq.org/buglist.cgi?product=Wine&component=dos&long_desc_typ… Getting old DOS games working might be pretty easy at this point if, like this game, they just need a little VGA love. Let's encourage newcomers to contribute in this area... it'd be fun to see those classic games running in wine. I added an entry to http://wiki.winehq.org/SummerOfCode for this, in case nobody does it before summer. - Dan

7 8

winedos interrupts getting lost.
by Peter Dons Tychsen 20 Oct '08

20 Oct '08

Hello. It starting with me trying to figure out why i was loosing keyboard events in winedos. 1) I then traced the keyboard events to a call to signal(SIGUSR2) in function DOSVM_QueueEvent(). 2) The signal() triggers code in ntdll, which generates an exception EXCEPTION_VM86_STI for the current vm86 context. 3) The exception is supposed to trigger exception_handler(), which will then handle the keyboard event, by kicking the event queue. This never happens however, as the mechanism stops working very quickly. I found out the code gets to raise_vm86_sti_exception in ntdll, and then stops. ntdll_get_thread_data()->vm86_ptr is NULL, so the STI exception is never signaled. Does anyone know more about the exception subsystem, and what could be causing this kind of strange behavior? I can mention that the system can generate EXCEPTION_VM86_INTx exceptions successfully, but fails to execute the EXCEPTION_VM86_STI. Thanks, /pedro

2 2

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory
by Louis. Lenders 20 Oct '08

20 Oct '08

>Thank you for your answer. >I agree, that before sending a patch I should write a test first. >But the problem is that even a tests are ignored without any explanation. >Maybe my tests aren't good, but why anybody just tell what's wrong. Seems to be common habit on this list. I hope you're not added to the "Julliard ranking s**t list? Yes: REJECT" ( see http://www.winehq.org/?issue=353#WineConf%202008%20Keynote ) like i am. Spent loads of time for more than 3 years trying to help triaging bugs and helping out in appdb, only to find out that all my patches are ignored silently, but everybody seems to be happy with this policy, so i'll stop complaining. Personally this makes me quite sad. Hope you have more luck with your patches. > Have you tried asking on the #winehackers IRC channel? >No, I doesn't use IRC. It's very hard to me to write in english in real-time If people spent quite an amount of time trying to get a patch written, it shouldn't be too much trouble to just drop a note on wine-devel, what the reason is the patch got rejected. But i guess this takes more time then "the few seconds to see that the code is correct? If today is a busy day: IGNORE" Great feedback... >Ok, I try to resend my old tests, and write tests to other patches. >Also there are some functions and stubs implemented, wchich doesn't require >(as I think) a tests. Send instant messages to your online friends http://uk.messenger.yahoo.com Send instant messages to your online friends http://uk.messenger.yahoo.com

4 4

[RFC] jscript: Fix shift/reduce conflict by removing redundant FunctionDeclaration rule.
by Rob Shearman 20 Oct '08

20 Oct '08

The rule is implemented by FunctionExpression which is reduced using the Statement rule. --- dlls/jscript/parser.y | 37 ------------------------------------- 1 files changed, 0 insertions(+), 37 deletions(-) The tests pass with this change, but I haven't looked in detail as to whether it will break anything. Jacek, can you check that your applications that use jscript still work after this patch is applied?

2 4

Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.
by Alexandre Julliard 20 Oct '08

20 Oct '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index 4756d7d..bc1b1d6 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -128,7 +128,7 @@ HKCR,folder\shell\open\ddeexec,,2,"[ViewFolder("%l", %I, %S)]" > HKCR,folder\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,folder\shell\open\ddeexec\application,,2,"Folders" > HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" > -HKCR,htmlfile\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > +HKCR,htmlfile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome" > HKCR,htmlfile\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,htmlfile\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,htmlfile\shell\open\ddeexec\Application,,2,"IExplore" This isn't look right, the entry works just fine without quotes, we shouldn't have to add them just to satisfy a test. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW]
by James Mckenzie 20 Oct '08

20 Oct '08

Andrey Turkin <andrey.turkin(a)gmail.com> on Oct 20, 2008 1:02 AM wrote about Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW] > >2008/10/20 James McKenzie <jjmckenzie51(a)earthlink.net> > >> Was this ever processed through Patchwatcher? >> >> James McKenzie >> >> -------- Original Message -------- >> Subject: mpr: fix NULL pointer dereference in >> WNetGetResourceInformationW >> Date: Tue, 07 Oct 2008 20:18:00 +0400 >> From: Andrey Turkin <andrey.turkin(a)gmail.com> >> Reply-To: wine-devel(a)winehq.org >> To: wine-patches <wine-patches(a)winehq.org> >> >> >> >> The dereference was spotted by Anastasius Focht in bug 13737; this patch >> fixes this bug. >> --- >> dlls/mpr/wnet.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >Yes, the mail is at http://kegel.com/wine/patchwatcher/results/3193.txt and >log is at http://kegel.com/wine/patchwatcher/results/3193.log . >Why, was there any problems with this patch? > >Regards, > Andrey > Thank you. I could not find it last night when I was reviewing PatchWater entries. James McKenize

1 0

today build's broken for me
by Nikolay Sivov 20 Oct '08

20 Oct '08

make[2]: Entering directory `/home/mrlarch/wine/dlls/secur32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o schannel.o schannel.c schannel.c:61: error: ‘gnutls_transport_set_errno’ undeclared here (not in a function) schannel.c:61: warning: type defaults to ‘int’ in declaration of ‘pgnutls_transport_set_errno’ schannel.c: In function ‘schan_pull’: schannel.c:571: error: called object ‘pgnutls_transport_set_errno’ is not a function schannel.c: In function ‘schan_push’: schannel.c:593: error: called object ‘pgnutls_transport_set_errno’ is not a function make[2]: *** [schannel.o] Error 1 make[2]: Leaving directory `/home/mrlarch/wine/dlls/secur32' make[1]: *** [secur32] Error 2 make[1]: Leaving directory `/home/mrlarch/wine/dlls' make: *** [dlls] Error 2 I'm using libgnutls-dev 1.4.4-3 from etch.

3 2

Today's git won't install DNS10 - IE not found
by Susan Cragin 20 Oct '08

20 Oct '08

I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. The popup messages says that IE 5 or greater is needed. wine-1.1.6-379-g07badc7 Susan fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action L"SetODBCFolders" fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies -> 6 ignored L"MsiAssembly" table values fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e07b7c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. fixme:msi:MsiGetMode 1 2 err:msi:ITERATE_Actions Execution halted, action L"LaunchConditions" returned 1603 susan@ubuntu:~/DNS10$

2 1

Today's git won't install DNS10 - IE not found
by Susan Cragin 20 Oct '08

20 Oct '08

I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. wine-1.1.6-379-g07badc7 fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action L"SetODBCFolders" fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies -> 6 ignored L"MsiAssembly" table values fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e07b7c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. fixme:msi:MsiGetMode 1 2 err:msi:ITERATE_Actions Execution halted, action L"LaunchConditions" returned 1603 susan@ubuntu:~/DNS10$

1 0

Re: wintrust: Implement CryptCATAdminCalcHashFromFileHandle
by Juan Lang 20 Oct '08

20 Oct '08

Hi Maarten, + if (pbHash && *pcbHash < 20) + { + SetLastError(ERROR_INSUFFICIENT_BUFFER); + return FALSE; + } That's not correct, *pcbHash must be set to 20 if it's too small. + while (ReadFile(hFile, tempbuffer, TEMP_BLOCK_SIZE, &readbytes, NULL) && readbytes) + CryptHashData(hash, tempbuffer, readbytes, 0); You return TRUE if ReadFile fails, which is unlikely to be correct. Thanks, --Juan

1 0

Re: latest GIT
by chris ahrendt 20 Oct '08

20 Oct '08

Austin English wrote: > On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt <celticht32(a)yahoo.com> wrote: > >> Anyone else having a problem compiling the latest git? >> >> mine has failed 2 times when I compile... one with a clean tree and one >> with an older tree.. >> >> chris >> >> >> >> __________________________________________________ >> Do You Yahoo!? >> Tired of spam? Yahoo! Mail has the best spam protection around >> http://mail.yahoo.com >> >> >> >> > > What error are you getting? What gcc version? > > make[2]: Entering directory `/home/cahrendt/wine-git/tools/widl' gcc -c -I. -I. -I../../include -I../../include -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o parser.yy.o parser.yy.c parser.l: In function ‘xstrtoul’: parser.l:92: error: ‘errno’ undeclared (first use in this function) parser.l:92: error: (Each undeclared identifier is reported only once parser.l:92: error: for each function it appears in.) parser.l:94: error: ‘ERANGE’ undeclared (first use in this function) make[2]: *** [parser.yy.o] Error 1 make[2]: Leaving directory `/home/cahrendt/wine-git/tools/widl' make[1]: *** [widl] Error 2 make[1]: Leaving directory `/home/cahrendt/wine-git/tools' make: *** [tools] Error 2 GCC version 4.1.2-45.el5 chris __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: shlwapi/tests: Make the shlwapi tests load on systems < Vista by provid
by Paul Vriens 20 Oct '08

20 Oct '08

Nicolas Le Cam wrote: > Regards, > Nicolas Le Cam > > > ------------------------------------------------------------------------ > > Hi Nicolas, Detlef already sent a patch for this: http://www.winehq.org/pipermail/wine-patches/2008-October/063319.html I think his approach is better as W-calls are not implemented on win9x and we can get away with 2 normal key deletes. -- Cheers, Paul.

2 1

Re: shlwapi/tests: Make the shlwapi tests load on systems < Vista by provid
by Nicolas Le Cam 20 Oct '08

20 Oct '08

Sorry for the truncated object, certainly a copy/paste error. It should be: "Make the shlwapi tests load on systems < Vista by providing a private implementation of RegDeleteTreeW." Regards, Nicolas Le Cam

1 1

[Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW]
by James McKenzie 20 Oct '08

20 Oct '08

Was this ever processed through Patchwatcher? James McKenzie -------- Original Message -------- Subject: mpr: fix NULL pointer dereference in WNetGetResourceInformationW Date: Tue, 07 Oct 2008 20:18:00 +0400 From: Andrey Turkin <andrey.turkin(a)gmail.com> Reply-To: wine-devel(a)winehq.org To: wine-patches <wine-patches(a)winehq.org> The dereference was spotted by Anastasius Focht in bug 13737; this patch fixes this bug. --- dlls/mpr/wnet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

2 1

CrossCallsWtoA - updated
by Austin English 20 Oct '08

20 Oct '08

Howdy, I ran the winapi_check tool today, seems the wiki hadn't been updated in a while 2 years. For those curious, here are the results (I removed the nonbugs as mentioned on the wiki). dlls/imm32/imm.c: imm32: ImmConfigureIMEW: illegal call to strdupWtoA (Unicode -> ASCII) dlls/imm32/imm.c: imm32: ImmEnumRegisterWordW: illegal call to strdupWtoA (Unicode -> ASCII) dlls/imm32/imm.c: imm32: ImmGetConversionListW: illegal call to strdupWtoA (Unicode -> ASCII) dlls/imm32/imm.c: imm32: ImmRegisterWordW: illegal call to strdupWtoA (Unicode -> ASCII) dlls/imm32/imm.c: imm32: ImmSetCompositionStringW: illegal call to ImmSetCompositionStringA (Unicode -> ASCII) dlls/imm32/imm.c: imm32: ImmUnregisterWordW: illegal call to strdupWtoA (Unicode -> ASCII) dlls/kernel32/lzexpand.c: kernel32: LZOpenFileW: illegal call to LZOpenFileA (Unicode -> ASCII) dlls/rpcrt4/rpc_binding.c: rpcrt4: RpcBindingToStringBindingW: illegal call to RpcBindingToStringBindingA (Unicode -> ASCII) dlls/rpcrt4/rpc_binding.c: rpcrt4: RpcBindingToStringBindingW: illegal call to RpcStringFreeA (Unicode -> ASCII) dlls/rpcrt4/rpc_server.c: rpcrt4: RpcServerUseProtseqEpExW: illegal call to RPCRT4_strdupWtoA (Unicode -> ASCII) dlls/shell32/shlfileop.c: shell32: SheGetDirW: illegal call to SetCurrentDirectoryA (Unicode -> ASCII) dlls/user32/winhelp.c: user32: WinHelpW: illegal call to WinHelpA (Unicode -> ASCII) dlls/version/install.c: version: VerInstallFileW: illegal call to VerInstallFileA (Unicode -> ASCII) dlls/winspool.drv/info.c: winspool.drv: AddPrinterW: illegal call to DEVMODEdupWtoA (Unicode -> ASCII) dlls/winspool.drv/info.c: winspool.drv: DeviceCapabilitiesW: illegal call to DEVMODEdupWtoA (Unicode -> ASCII) dlls/winspool.drv/info.c: winspool.drv: DeviceCapabilitiesW: illegal call to DeviceCapabilitiesA (Unicode -> ASCII) dlls/winspool.drv/info.c: winspool.drv: DeviceCapabilitiesW: illegal call to strdupWtoA (Unicode -> ASCII) dlls/winspool.drv/info.c: winspool.drv: DocumentPropertiesW: illegal call to DEVMODEdupWtoA (Unicode -> ASCII) dlls/winspool.drv/info.c: winspool.drv: DocumentPropertiesW: illegal call to DocumentPropertiesA (Unicode -> ASCII) dlls/winspool.drv/info.c: winspool.drv: DocumentPropertiesW: illegal call to strdupWtoA (Unicode -> ASCII) dlls/ws2_32/socket.c: ws2_32: WSAStringToAddressW: illegal call to WSAStringToAddressA (Unicode -> ASCII) There were a few other warnings as well: dlls/msvcrt20/msvcrt20.c:25: <>: void CDECL __getmainargs(int *,char ***,char ***,int,int *): duplicate declaration (first declaration at dlls/crtdll/crtdll_main.c:36) dlls/rsaenh/implglue.c:41: <>: VOID WINAPI MD5Init(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2919) dlls/rsaenh/implglue.c:42: <>: VOID WINAPI MD5Update(MD5_CTX *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/msi/msi.c:2920) dlls/rsaenh/implglue.c:43: <>: VOID WINAPI MD5Final(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2921) dlls/secur32/util.c:104: <>: VOID WINAPI MD4Init(MD4_CTX *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:37) dlls/secur32/util.c:105: <>: VOID WINAPI MD4Update(MD4_CTX *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:38) dlls/secur32/util.c:106: <>: VOID WINAPI MD4Final(MD4_CTX *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:39) dlls/secur32/util.c:107: <>: VOID WINAPI MD5Init(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2919) dlls/secur32/util.c:108: <>: VOID WINAPI MD5Update(MD5_CTX *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/msi/msi.c:2920) dlls/secur32/util.c:109: <>: VOID WINAPI MD5Final(MD5_CTX *): duplicate declaration (first declaration at dlls/msi/msi.c:2921) dlls/winex11.drv/graphics.c:1512: <>: void WINAPI A_SHAInit(sha_ctx *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:45) dlls/winex11.drv/graphics.c:1513: <>: void WINAPI A_SHAUpdate(sha_ctx *,unsigned char *,unsigned int): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:46) dlls/winex11.drv/graphics.c:1514: <>: void WINAPI A_SHAFinal(sha_ctx *,unsigned char *): duplicate declaration (first declaration at dlls/rsaenh/implglue.c:47) win16.api:822: type (unsigned long *) is not Win64 compatible win32.api:2954: type (long) is not Win64 compatible win32.api:2959: type (unsigned long) is not Win64 compatible win32.api:3008: type (long *) is not Win64 compatible win32.api:3028: type (unsigned long *) is not Win64 compatible win32.api:3073: type (unsigned long) is not Win64 compatible win32.api:6049: type (unsigned long) is not Win64 compatible win32.api:6094: type (unsigned long *) is not Win64 compatible http://wiki.winehq.org/CrossCallsWtoA -- -Austin

2 1

latest GIT
by chris ahrendt 20 Oct '08

20 Oct '08

Anyone else having a problem compiling the latest git? mine has failed 2 times when I compile... one with a clean tree and one with an older tree.. chris __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Windowing bug under KDE4.1
by Evil Jay 20 Oct '08

20 Oct '08

I've replaced my video card and am now having MUCH better results with CounterStrike:Source (I love Wine!). Most of my problems were due to a defective EVGA 9600GT. However, I discovered a new windowing bug today with CS:S and other Source-based games (I verified the same behavior under the Zombie Panic total conversion) running under KDE4.1 (no Compiz, Kubuntu 8.10b1). Do this: 1) Start CS:S on your first desktop. 2) Configure CS:S to run in windowed mode in a window smaller than your desktop. You should see a CS:S window with your standard KDE windows decorations. So far, so good.... 2) Use the pager applet to flip to a second desktop 3) Flip back to the first desktop. 4) At this point you will see not only a window with your standard KDE windows decorations, but inside that window will be a Windows window with Windows decorations. All mouse clicks will be offset by the number of pixels equal to the second, Windows, titlebar. (You have to click below everything) You can recover by using the Windows titlebar to maximize the game window - which will maximize the KDE window and get rid of the Windows window. Then, flip to the second desktop. Flip back to the first desktop and you will again have a Windows window inside your KDE window again. Hit the restore button on the Windows window, and the KDE window will shrink back to normal size and the Windows window will have disappeared. Wow, that's some redundant use of the word "window". I hope some dev can make sense of my rambling and use it to improve Wine. Thanks.

3 2

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable
by Austin English 19 Oct '08

19 Oct '08

On Tue, Oct 14, 2008 at 5:11 PM, Joris Huizer <joris_huizer(a)yahoo.com> wrote: > When pszExtra is unequal to zero, set pszExtraFromReg to zero as it'll get free'd later on; > > (Another way would be to set the variable to NULL explicitly if it's desirable to make this case very explicit) > > > > > > "From: Joris Huizer <jorishuizer(a)debian.(none)>" Minor, but please fix your e-mail in the patch: Also, please set patch extensions to .txt, it makes it easier to read in browser. -- -Austin

3 5

Re: wininet: quiet a noisy fixme (try 2)
by Vincent Povirk 19 Oct '08

19 Oct '08

Uh, you're changing what the function does. *lpdwStatus = INTERNET_CONNECTION_LAN; will only happen the first time. Vincent Povirk 2008/10/18 Austin English <austinenglish(a)gmail.com>: > Didn't receive any feedback on this one last time... > > -- > -Austin > > > >

1 0

milestone: cygwin nearly working properly
by Dan Kegel 19 Oct '08

19 Oct '08

The main thing missing at the moment is cygwin's symlinks aren't working, http://bugs.winehq.org/show_bug.cgi?id=15679 and I couldn't find the file needed to start cygwin's X server. (And of course the thing that drives me nuts, it only works inside wineconsole. That might be harder to fix.) With just a little more work, we could do an awesome nesting demo, I bet.

1 0

Re: winex11.drv: Handle GetDeviceCaps COLORRES capability index (resend)
by Roderick Colenbrander 19 Oct '08

19 Oct '08

Hi, Since you mentioned in your first patch that this fix is inspired by behavior on Windows, please add a test to our test suite to prove it. Roderick > The previous patch returns the incorrect variable, so I've made the > correction in this resend. > --- > dlls/winex11.drv/init.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) -- GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen! Jetzt dabei sein: http://www.shortview.de/wasistshortview.php?mc=sv_ext_mf@gmx

3 2

Re: msi: quiet a noisy err
by James Hawkins 19 Oct '08

19 Oct '08

On Sat, Oct 18, 2008 at 9:37 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- Please don't commit this patch. The err is there for a reason. Each time this is output, it's a different insertion that fails. -- James Hawkins

1 0

Which graphics cards really pass the conformance tests, again?
by Dan Kegel 18 Oct '08

18 Oct '08

When I put together the current patchwatcher box, I made sure to get a graphics card based on a recent nvidia chip. http://www2.pny.com/8500-GT-512MB-PCIe-P2322C269.aspx seemed recent enough, but I still get buttloads of conformance test failures in d3d and ddraw. So, which graphics cards exactly don't get any d3d or ddraw conformance test failures? Are there any? If there are, I want to get one on the patchwatcher box so I can cut back the huge blacklist a bit. Thanks, Dan

3 2

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory
by James Hawkins 18 Oct '08

18 Oct '08

2008/10/17 Vitaly Perov <vitperov(a)etersoft.ru>: > > > From e2eec69ff86960bd6729a3105747310ce9c256fd Mon Sep 17 00:00:00 2001 > From: Vitaly Perov <vitperov(a)etersoft.ru> > Date: Fri, 17 Oct 2008 16:56:46 +0400 > Subject: [PATCH] shell32: FOF_MULTIDESTFILES must be set when copying files into directory > > --- > dlls/shell32/shlfileop.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c > index 49f61d3..e6565ea 100644 > --- a/dlls/shell32/shlfileop.c > +++ b/dlls/shell32/shlfileop.c > @@ -1382,6 +1382,7 @@ static void move_dir_to_dir(LPSHFILEOPSTRUCTW lpFileOp, const FILE_ENTRY *feFrom > fileOp = *lpFileOp; > fileOp.pFrom = szFrom; > fileOp.pTo = szTo; > + fileOp.fFlags |= FOF_MULTIDESTFILES; > > SHFileOperationW(&fileOp); > RemoveDirectoryW(feFrom->szFullPath); > We've been over this before. This needs a test case. Either way, this doesn't look right. What are you trying to fix? -- James Hawkins

3 6

Re: wined3d: Add one more FBO error status code
by Henri Verbeet 18 Oct '08

18 Oct '08

2008/10/18 Vitaliy Margolen <wine-patches(a)kievinfo.com>: > diff --git a/include/wine/wined3d_gl.h b/include/wine/wined3d_gl.h > index 5e55a0d..b26ab78 100644 > --- a/include/wine/wined3d_gl.h > +++ b/include/wine/wined3d_gl.h > @@ -1819,6 +1819,7 @@ typedef void (WINE_GLAPI * PGLFNGLVERTEXBLENDARB) (GLint count); > #define GL_FRAMEBUFFER_INCOMPLETE_FORMATS_EXT 0x8CDA > #define GL_FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER_EXT 0x8CDB > #define GL_FRAMEBUFFER_INCOMPLETE_READ_BUFFER_EXT 0x8CDC > +#define GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT 0x8D56 > #define GL_FRAMEBUFFER_UNSUPPORTED_EXT 0x8CDD > #define GL_FRAMEBUFFER_BINDING_EXT 0x8CA6 > #define GL_RENDERBUFFER_BINDING_EXT 0x8CA7 That constant is part of EXT_framebuffer_multisample, not EXT_framebuffer_object.

2 6

Re: wpp: Check for overflows when parsing integer constants.
by Alexandre Julliard 18 Oct '08

18 Oct '08

"Rob Shearman" <robertshearman(a)gmail.com> writes: > diff --git a/libs/wpp/ppl.l b/libs/wpp/ppl.l > index 3e84a2e..829ac35 100644 > --- a/libs/wpp/ppl.l > +++ b/libs/wpp/ppl.l > @@ -163,6 +163,9 @@ ul [uUlL]|[uUlL][lL]|[lL][uU]|[lL][lL][uU]|[uU][lL][lL]|[lL][uU][lL] > #include <string.h> > #include <ctype.h> > #include <assert.h> > +#define __USE_ISOC99 > +#include <limits.h> > +#undef __USE_ISOC99 If you have to do that sort of thing it means you are using non-portable definitions. The right way is to provide them yourself if they are missing, not to rely on the system headers supporting C99. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Add job name field into CreateSpoolFile (try2)
by Michael Karcher 18 Oct '08

18 Oct '08

Am Samstag, den 18.10.2008, 15:58 +0400 schrieb Konstantin Kondratyuk: > Try 2: add quotes in parameter: -T'%s' That's the right way to go, but are you sure that pszTitle does not contain single quotes itself? If not, you have to escape them (for the shell, it should be "\" -> "'\''") or to replace them (for example by '_'). Regards, Michael Karcher

1 0

Re: [PATCH] include: fixed the tom constant values.
by Rob Shearman 18 Oct '08

18 Oct '08

2008/10/17 Reece Dunn <msclrhd(a)googlemail.com>: > The hexadecimal constants should be 8 characters long, not 9. Found by > building the include project (via msvcmaker) with VC9. Good catch. I'll fix widl and our other parsers to check for these kinds of overflows. -- Rob Shearman

1 0

Re: Splitting the appdb Top 25 list
by chris ahrendt 18 Oct '08

18 Oct '08

MY $.02 cp on the issue agrees with the others... I would say split it up.. but more possibly than applications and games.. Say : games Utils Development Tools Applications Chris __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Splitting the appdb Top 25 list
by Jeff Davis 18 Oct '08

18 Oct '08

I'm not a developer, but I joined to make a humble suggestion in a place where someone might actually have the power to act on it. Does anyone think it would be a good idea to split the Top 25 into two lists, one for games, and one for applications/other? By my count, every item of the top 10 is a game. 22 out of the Top 25 are games or game-related. I don't think it's necessarily true that more people are interested in running The Sims than iTunes, or that The Sims is or should be a higher priority than having iTunes working. I think it gives the wrong impression of wine and its priorities, and makes a person feel a bit hopeless voting for an application no matter how many millions of people are users of that application on Windows. I think people would be more interested in voting for applications if they could get feedback on WineHQ. Thoughts?

3 3

Re: Splitting the appdb Top 25 list
by Susan Cragin 17 Oct '08

17 Oct '08

-----Original Message----- >> I'm not a developer, but I joined to make a humble suggestion in a place >> where someone might actually have the power to act on it. >> >> Does anyone think it would be a good idea to split the Top 25 into two >> lists, one for games, and one for applications/other? >> >> By my count, every item of the top 10 is a game. 22 out of the Top 25 are >> games or game-related. >> >> I don't think it's necessarily true that more people are interested in >> running The Sims than iTunes, or that The Sims is or should be a higher >> priority >> than having iTunes working. >> >> I think it gives the wrong impression of wine and its priorities, and makes >> a person feel a bit hopeless voting for an application no matter how many >> millions of >> people are users of that application on Windows. I think people would be >> more interested in voting for applications if they could get feedback on >> WineHQ. >> >> Thoughts? > > >I wonder if we should perhaps just remove the AppDB voting system alltogether. >As you said, it doesn't seem to be giving a good representation of users' >interests. > > >Alexander N. Sørnes I think that might be a good idea. One reason is that gamers probably play multiple games and cross-vote for each other's applications. Gamers are also likely to be young, and to spend a lot of time on the net, one way and another. They tend to vote. Older people are more disengaged. I'm just sitting here using Dragon NaturallySpeaking to avoid RSI, and to work faster. I know of a few people that use Dragon, and most of them use only that on WINE. But Dragon NaturallySpeaking is one of the most important programs WINE can run. DNS provides an input for handicapped people, provides increased productivity for business, and encourages all forms of writing, and hence learning and creativity. I use it to write, to take notes, to transcribe interviews. Court reporters in many US states use DNS. It's an important productivity tool. Susan Cragin

1 0

Re: gdi32: Add job name field into CreateSpoolFile
by Detlef Riekenberg 17 Oct '08

17 Oct '08

On Mo, 2008-10-13 at 12:29 +0400, Konstantin Kondratyuk wrote: > - sprintf(psCmd,"|lpr -P'%s'",pszOutput+4); > + sprintf(psCmd,"|lpr -T %s -P'%s'",pszTitle,pszOutput+4); This is broken, when there is a space in the Title. -- By by ... Detlef

1 0

Re: mscms: quiet a noisy fixme (1/3)
by Detlef Riekenberg 17 Oct '08

17 Oct '08

On Do, 2008-10-16 at 19:44 -0500, Austin English wrote: > + if (quietfixme == 0) > + { > + FIXME("unhandled bitmap format\n"); Such a FIXME has no useful information. You should also dump the unhandled bitmap format in the FIXME > + quietfixme = 1; > + return TYPE_RGB_8; > + } When you swap both lines above, ... > } > + return 0; ... you should no longer need the "return 0" above. > } > -- By by ... Detlef

2 1

Wine and LSB development kit?
by Dan Kegel 17 Oct '08

17 Oct '08

Two years ago I tried building wine with the LSB development kit, http://www.winehq.org/pipermail/wine-devel/2006-August/050554.html They've released a snazzy new beta of LSB 4.0, see https://www.linuxfoundation.org/en/LSB_4.0_Beta Could somebody try building and running Wine with it to give them feedback? I'll give it a try myself sometime, but I'm pretty busy...

1 0

Re: kernel32: quiet a noisy err (try 2)
by Henri Verbeet 17 Oct '08

17 Oct '08

Actually, what are you doing that you even see this ERR at all?

2 3

Re: comdlg32/tests: Windows XP cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Henri Verbeet 17 Oct '08

17 Oct '08

Any idea why it can't do that? Looking at the test results it looks like 2003 and 2008 fail as well, although 2008 fails on the first call, with a different error. The second CreateViewWindow2 call is more important than the first, so it probably makes sense to swap them if we're going to skip one of them.

2 1

DirectX DLL 36?
by Warren Dumortier 17 Oct '08

17 Oct '08

Hi! A lot of games currently doesn't start 'out-of-the-box' by missing d3dx9_36.dll, wouldn't it a good idea to have this dll in wine, is it possible, difficult? I'm not a programmer, just a wine user proposing this idea (would be nice). Thanks, kind regards dear devs! :)

2 1

Re: kernel32: quiet a noisy err (2/3)
by Vincent Povirk 17 Oct '08

17 Oct '08

You're setting quieterr to 0 initially, and the if condition will only be true if it is 1. The ERR will never be printed. Also, I think you should move the test for quieterr into the for loop, since all the loop does is print the ERR. Vincent Povirk On Thu, Oct 16, 2008 at 7:46 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > > > >

2 1

Re: mscms: quiet a noisy fixme (1/3)
by Henri Verbeet 17 Oct '08

17 Oct '08

I don't think you want to change the return code based on whether the FIXME is shown or not.

2 1

Re: mscvrt: updated use of pmode flag in _s_open - set permissions of thefile after it's been created.
by Dmitry Timoshkov 17 Oct '08

17 Oct '08

"Ivan Peevski" <cyberhorse(a)gmail.com> wrote: > + /* Ignore _S_IREAD and _S_IWRITE if file exists. */ > + if (stat(path, &buf) != 0) > + pmode = pmode & (MSVCRT__S_IREAD | MSVCRT__S_IWRITE); /*relevant flags*/ You need to use MSVCRT__stat(), not the system stat(), and appropriately typed buf. -- Dmitry.

2 1

Re: dsound: Add typedefs for uint8_t, uint16_t and uint32_t for systems that don't have stdint.h.
by Dmitry Timoshkov 17 Oct '08

17 Oct '08

"Rob Shearman" <robertshearman(a)gmail.com> wrote: > --- > dlls/dsound/dsound_convert.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) I'd argue that dsound_convert.c should use win32 types instead. -- Dmitry.

1 0

Re: dsound: Add typedefs for uint8_t, uint16_t and uint32_t for systems that don't have stdint.h.
by Michael Karcher 17 Oct '08

17 Oct '08

Am Freitag, den 17.10.2008, 11:06 +0100 schrieb Rob Shearman: > +typedef unsigned char uint8_t; > +typedef unsigned short uint16_t; > +typedef unsigned int uint32_t; This probably works on all platforms Wine is designed for, but why don't you use the autoconf provision for these types called AC_CREATE_STDINT_H or AX_CREATE_STDINT_H to create "wine/stdint.h" (which will create a one-liner including <stdint.h> on systems where it is available)? Regards, Michael Karcher

1 0

Re: [PATCH 03/10] jscript: Added NaN value implementation.
by Alexandre Julliard 17 Oct '08

17 Oct '08

Jacek Caban <jacek(a)codeweavers.com> writes: > +#include <math.h> > +#include "basetsd.h" > + > +#ifndef NAN > + > +#ifdef __GNUC__ > + > +# define NAN \ > + (__extension__ \ > + ((union { unsigned __l __attribute__ ((__mode__ (__SI__))); float __d; }) \ > + { __l: 0x7fc00000UL }).__d) > + > +#else /* __GNUC__ */ > + > +#ifdef WORDS_BIGENDIAN > +# define __nan_bytes { 0x7f, 0xc0, 0, 0 } > +#else > +# define __nan_bytes { 0, 0, 0xc0, 0x7f } > +#endif > + > +static union { unsigned char __c[4]; float __d; } __nan_union > + __attribute_used__ = { __nan_bytes }; > +# define NAN (__nan_union.__d) > + > +#endif /* __GNUC__ */ > + > +#endif /* NAN */ I'd suggest to take advantage of the variant union instead of copying all these glibc definitions. Something like #ifdef NAN V_R8(&vt) = NAN; #else V_I8(&vt) = nan_magic_pattern; #endif -- Alexandre Julliard julliard(a)winehq.org

4 4

Re: Kernel32: 3GB UserSpace boot option
by Stefan Reimer 17 Oct '08

17 Oct '08

Hi, compiling binaries with the LARGE_ADDRESS_AWARE flag set is not enough to be able to use more than 2GB user space. To behave like WindowsXP booted with the /3GB option, at least the lpMaximumApplicationAddress in GetSystemInfo has to be changed to 0xBFFEFFFF and the virtual user space has to be reserved in mmap_init in mmap.c up to that address. See Windows memory management: http://ymei.freeshell.org/gopher/Book/Programming%20Applications%20for%20MS… http://codeidol.com/other/inside-windows-2000/Memory-Management/Address-Spa… I am quite sure that my proposed hack is not complete to behave like the /3GB option, but as stated in cpu.c 384 /* FIXME: the two entries below should be computed somehow... */ 385 cachedsi.lpMinimumApplicationAddress = (void *)0x00010000; 386 cachedsi.lpMaximumApplicationAddress = (void *)0x7FFEFFFF; we should look at this in order to be able to use more than 2GB user space for apps that need it. Regards Stefan Reimer

2 3

Re: [1/3] netapi32/tests: Add a test for well known account RIDs
by Nicolas Le Cam 17 Oct '08

17 Oct '08

Its obvious but don't apply, third patch is missing comment and unused variables cleaning. I will submit a new patch later. regards, Nicolas Le Cam 2008/10/17 Nicolas Le Cam <niko.lecam(a)gmail.com>: > Hi, > > This path series intend to fix a failing test on localized windows > version. > The first two patches are needed to reveal and fix a different behavior > between windows and wine in NetQueryDisplayInformation Level 1 that I'm > using in the third patch to fix a failing test on my localized windows > without having to rework completely the test logic. > > regards, > Nicolas Le Cam > > > >

1 0

Re: [PATCH] shlwapi: Fix pointer and size in AssocQueryStringA
by Juan Lang 16 Oct '08

16 Oct '08

Hi Detlef, - if (dwLenOut >= MAX_PATH) + if (dwLenOut >= MAX_PATH) { lpszReturnW = HeapAlloc(GetProcessHeap(), 0, (dwLenOut + 1) * sizeof(WCHAR)); + } This first set of parentheses seems like an unnecessary addition.. + else + { + dwLenOut = sizeof(szReturnW) / sizeof(szReturnW[0]); + } and this one's style doesn't match the above. The rest of the file doesn't appear to use braces with only a single-line expression, so would you mind sticking with the existing style? Same with the next hunk, it introduces braces where none are needed. Thanks, --Juan

1 0

Re: [PATCH] wintrust: Implement CryptCATAdminCalcHashFromFileHandle
by Juan Lang 16 Oct '08

16 Oct '08

Hi Maarten, overall this patch looks pretty good. A few minor comments: + tempbuffer = HeapAlloc(GetProcessHeap(), 0, TEMP_BLOCK_SIZE); + if (!tempbuffer) + goto out; You return TRUE in this case. You probably ought to set last error and return FALSE instead. + while (ReadFile(hFile, tempbuffer, TEMP_BLOCK_SIZE, &readbytes, NULL) && readbytes) + CryptHashData(hash, tempbuffer, readbytes, 0); Why not while ((ret = ReadFile...) && readbytes) instead? This way you can at least return failure if reading the file fails for whatever reason. + SetLastError(ERROR_INSUFFICIENT_BUFFER); return TRUE; Why are you setting ERROR_INSUFFICIENT_BUFFER in the success case? If it's just to pass that test, I think you might remove the test instead: in general we don't like to check last error in case of success, unless we know an app does so. --Juan

2 3

Re: setupapi: Implement installing catalog files
by Vincent Povirk 16 Oct '08

16 Oct '08

The patch you sent doesn't match the subject line. Vincent Povirk On Wed, Oct 15, 2008 at 11:05 AM, Maarten Lankhorst <maarten(a)codeweavers.com> wrote: > --- > The functions called here are stubs, but don't cause this code to bomb out. > > From 04917f75269b6f4f51924ba734c20dc05617d882 Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst <maarten(a)codeweavers.com> > Date: Tue, 14 Oct 2008 20:16:14 +0200 > Subject: [PATCH] advapi32: Make CheckTokenMembership return FALSE for asking > whether we are connected through the network > > --- > dlls/advapi32/security.c | 21 +++++++++++++++++---- > 1 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c > index ca26217..5a2b3e4 100644 > --- a/dlls/advapi32/security.c > +++ b/dlls/advapi32/security.c > @@ -615,10 +615,23 @@ BOOL WINAPI > CheckTokenMembership( HANDLE TokenHandle, PSID SidToCheck, > PBOOL IsMember ) > { > - FIXME("(%p %p %p) stub!\n", TokenHandle, SidToCheck, IsMember); > - > - *IsMember = TRUE; > - return(TRUE); > + WCHAR *sid = NULL; > + WCHAR network[] = { 'S','-','1','-','5','-','2',0}; > + BOOL ret = TRUE; > + FIXME("(%p %p %p) stub!\n", TokenHandle, SidToCheck, IsMember); > + > + ConvertSidToStringSidW(SidToCheck, &sid); > + FIXME("Sid: %s\n", debugstr_w(sid)); > + /* We are not connected through the network in any way, but locally > + * Internet Explorer 7 installer checks for it and bombs out if > + * we return TRUE on asking whether we are > + */ > + if (sid && !lstrcmpW(sid, network)) > + ret = FALSE; > + LocalFree(sid); > + > + *IsMember = ret; > + return TRUE; > } > > /****************************************************************************** > -- > 1.5.6.5 > > > > >

2 1

Re: [PATCH 1/3] msxml3: Update orphant list in put_documentElement.
by Michael Karcher 16 Oct '08

16 Oct '08

Am Donnerstag, den 16.10.2008, 13:55 -0500 schrieb Jacek Caban: @@ -932,9 +933,17 @@ static HRESULT WINAPI domdoc_put_documentElement( return hr; xmlNode = impl_from_IXMLDOMNode( elementNode ); - xmlDocSetRootElement( get_doc(This), xmlNode->node); + + if(!xmlNode->node->parent) + if(xmldoc_remove_orphan(xmlNode->node->doc, xmlNode->node) != S_OK) + WARN("%p is not an orphan of %p\n", xmlNode->node->doc, xmlNode->node); + + oldRoot = xmlDocSetRootElement( get_doc(This), xmlNode->node); IXMLDOMNode_Release( elementNode ); + if(oldRoot) + xmldoc_add_orphan(oldRoot->doc, oldRoot); + return S_OK; } This patch is against my intention of the orphan list. The orphan list should contain nodes that are associated to the document, but are not in the tree (i.e. not an descendant of the document root element). The orphan list is used to not forget to free these nodes (that logically reference the document and have to keep the document alive) when the document itself (i.e. the root document element) is freed. Now oldRoot already *is* the root element, that is oldRoot->doc == oldRoot. Placeing the element itself on the orphan list causes it to be freed when freeing the orphans and a second time (some lines later) when the document element is freed. So, I doubt this patch is correct. Regards, Michael Karcher

2 2

Try #3 for IDirectDrawSurface_GetSurfaceDesc error checking in ddraw test
by chris ahrendt 16 Oct '08

16 Oct '08

Michael / All here is the third go at the ddraw test... and the patch for that... note I went ahead and used the goto. Also I found an error in the test where it was allocating the buffer in one place and it did not free it. Now here is the curious thing... When I did the first run of the ddraw test I got the output found in the no_ulimit_run attachment which did not seem right as nothing ran or didnt seem to. So I did the ulimit -s unlimited and then re-ran the test and got the second output... Now shouldn't the test run the same reguardless of the stack limit? Chris

3 2

Re: gdiplus: IPicture_SaveAsFile updates seek pointer, so put it back.
by Nikolay Sivov 16 Oct '08

16 Oct '08

It isn't obvious (your patch fot ret value). Why are you hiding all codes except E_FAIL? Tests are needed, but I think you're hiding something by this change. On 10/16/08, Kirill K. Smirnov <lich(a)math.spbu.ru> wrote: > This patch fixes gdiplus test failures revealed by patch: > [2/3] oleaut32: return correct error code > http://www.winehq.org/pipermail/wine-patches/2008-October/063221.html > > > > >

2 2

Re: gdiplus: IPicture_SaveAsFile updates seek pointer, so put it back.
by Kirill K. Smirnov 16 Oct '08

16 Oct '08

>It isn't obvious (your patch fot ret value). Why are you hiding all >codes except E_FAIL? Tests are needed, but I think you're hiding >something by this change. Please, clarify, what patch are you trying to blame: (1) [2/3] oleaut32: return correct error code. or (2) gdiplus: IPicture_SaveAsFile updates seek pointer, so put it back. Both of them are obvious and are not hiding anything. On the contrary, (1) reveals hidden bug in another module (gdiplus), and (2) fixes that bug. -- Kirill

1 0

Today's git improves Dragon NaturallySpeaking 10
by Susan Cragin 16 Oct '08

16 Oct '08

Today's git ads a significant functionality to Dragon NaturallySpeaking 10. After the program loads, there are a couple of options. One of them is to scan the Documents files for wordprocessing documents, and add them to its grammar model. I have always selected that option, but until today the checking only took about 1 second and didn't really work. It probably couldn't find my documents. Today it scanned for a good three minutes, and accuracy was significantly improved. I just thought I would let you know. Susan

1 0

Patchwatcher: failed regression tests: [2/3] oleaut32: return correct error code
by Kirill K. Smirnov 16 Oct '08

16 Oct '08

Hello >@@ -1802,7 +1802,7 @@ static HRESULT WINAPI >OLEPictureImpl_Load(IPersistStream* iface,IStream*pStm) { > hr=IStream_Read(pStm,header,8,&xread); > if (hr || xread!=8) { > ERR("Failure while reading picture header (hr is %x, nread is %d). \n",hr,xread); >- return hr; >+ return (hr?hr:E_FAIL); > } > headerread += xread; > xread = 0; Hmm... I've just got notification from patchwalker that this patch for oleaut32 breaks some tests for gdiplus. I do not know why it does happen. But since this patch fixes some bugs and it got accepted, please, do not revert it or do anything evil :-)) I hope I will find right solution soon. -- Kirill

1 0

Re: winhttp: tests/server.c[new]: Add basic internal server test (RESEND)
by Alexandre Julliard 16 Oct '08

16 Oct '08

Zac Brown <zac(a)zacbrown.org> writes: > + si.hEvent = CreateEvent(NULL, 0, 0, NULL); > + si.port = rand() + 8000; You need to search for an available port, rand() is not an appropriate mechanism. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Wineg++ and structured exception handling
by Dan Kegel 16 Oct '08

16 Oct '08

See http://wiki.winehq.org/CompilerExceptionSupport

1 0

Re: shdocvw: [Patch 1/2] Implement URLSubRegQueryA [Resend]
by Alexandre Julliard 15 Oct '08

15 Oct '08

Detlef Riekenberg <wine.dev(a)web.de> writes: > + len = sizeof(buffer); > + res = SHRegGetUSValueA(regpath, name, NULL, buffer, &len, FALSE, NULL, 0); > + if (!res) { > + lstrcpynA(out, buffer, outlen); > + if (outlen > 0) { > + out[min(outlen-1,len)] = '\0'; > + } This doesn't look right. Why do you even need a separate buffer? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Michael Stefaniuc : shlwapi: Remove break after return (Smatch).
by Michael Stefaniuc 15 Oct '08

15 Oct '08

Hello Alexandre, I'm pretty sure that my patch contained only the second chunk of the patch commited. The first part seems to have been credited to me by mistake. Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: d6359edd3cbe366c71f22e09e27d3e427520f609 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=d6359edd3cbe366c71f22e09e… > > Author: Michael Stefaniuc <mstefani(a)redhat.de> > Date: Tue Oct 14 16:32:33 2008 +0200 > > shlwapi: Remove break after return (Smatch). > > --- > > dlls/shlwapi/assoc.c | 27 +++++++++++++++++++++++++-- > 1 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/dlls/shlwapi/assoc.c b/dlls/shlwapi/assoc.c > index 7f71708..9e4b036 100644 > --- a/dlls/shlwapi/assoc.c > +++ b/dlls/shlwapi/assoc.c > @@ -627,7 +627,31 @@ static HRESULT ASSOC_GetExecutable(IQueryAssociationsImpl *This, > if (!pszExtra) > { > hr = ASSOC_GetValue(hkeyShell, &pszExtraFromReg); > - if (FAILED(hr)) > + /* if no default action */ > + if (hr == E_FAIL || hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND)) > + { > + DWORD rlen; > + ret = RegQueryInfoKeyW(hkeyShell, 0, 0, 0, 0, &rlen, 0, 0, 0, 0, 0, 0); > + if (ret != ERROR_SUCCESS) > + { > + RegCloseKey(hkeyShell); > + return HRESULT_FROM_WIN32(ret); > + } > + rlen++; > + pszExtraFromReg = HeapAlloc(GetProcessHeap(), 0, rlen * sizeof(WCHAR)); > + if (!pszExtraFromReg) > + { > + RegCloseKey(hkeyShell); > + return E_OUTOFMEMORY; > + } > + ret = RegEnumKeyExW(hkeyShell, 0, pszExtraFromReg, &rlen, 0, NULL, NULL, NULL); > + if (ret != ERROR_SUCCESS) > + { > + RegCloseKey(hkeyShell); > + return HRESULT_FROM_WIN32(ret); > + } > + } > + else if (FAILED(hr)) > { > RegCloseKey(hkeyShell); > return hr; > @@ -743,7 +767,6 @@ static HRESULT WINAPI IQueryAssociations_fnGetString( > return hr; > len++; > return ASSOC_ReturnData(pszOut, pcchOut, path, len); > - break; > } > > case ASSOCSTR_FRIENDLYAPPNAME: > > > bye michael

2 1

Wineg++ and structured exception handling
by Michael Ost 15 Oct '08

15 Oct '08

Hi, Is there a way for wineg++ to catch windows exceptions and handle them as g++ does --- cleaning up stack variables, etc? My C++ winelib app, built with wineg++, is loading Windows DLLs. I want to catch windows exceptions from functions that I call from those DLLs. I need to do some cleanup if there are exceptions, and tried creating some stack variables to manage that. I found __TRY and __CATCH in wine/exception.h. Wrapping the DLL function calls with __TRY and __CATCH does indeed catch exceptions, but there is no stack cleanup. There is some deep code in exception.h that implements __TRY/__CATCH (which I sure could be misreading) but they look more C like than C++ like... just taking care to jump to the right location without trying to do any cleanup. Window's c++ compiler evidently does that now, per this page: http://msdn.microsoft.com/en-us/library/7w0chfbk(VS.80).aspx I'm guessing I am out of luck here, but am hoping I'm just missing something. Thanks... mo

2 1

Re: advapi32: Fall back to /dev/random if /dev/urandom can't be opened, and add warnings if opening either fails
by Austin English 15 Oct '08

15 Oct '08

On Wed, Oct 15, 2008 at 1:13 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > Let me know if you think the fallback is a bad idea, or if a FIXME is > more appropriate than a WARN here. > --Juan > > > > FWIW: http://en.wikipedia.org/wiki/Urandom "/dev/random and /dev/urandom are also available on Solaris, Mac OS X, NetBSD, OpenBSD, Tru64 UNIX 5.1B, AIX 5.2, and HP-UX 11i v2, however as with FreeBSD, AIX implements its own Yarrow-based design which uses considerably less entropy sources than the standard /dev/random implementation and stops refilling the pool when it thinks it contains enough entropy.[2]" "A software program called EGD (entropy gathering daemon) is a common alternative for Unix systems which do not support the /dev/random device. It is a user space daemon which provides high quality cryptographic random data. Some cryptographic software such as OpenSSL, GNU Privacy Guard, and the Apache HTTP Server support using EGD when a /dev/random device is not available." -- -Austin

2 1

Re: wininet: quiet a noisy fixme
by Maarten Lankhorst 15 Oct '08

15 Oct '08

I think this one can be better removed entirely, wine will never get support for dialup programs or other fancy ways to connect to the internet, so this fixme is useless.

1 0

Re: winex11.drv: Prevent XCreateIC from returning NULL when input style isn't "root". (try 3)
by Alexandre Julliard 15 Oct '08

15 Oct '08

"Muneyuki Noguchi" <nogu.dev(a)gmail.com> writes: > diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h > index e5a40aa..f58342b 100644 > --- a/dlls/winex11.drv/x11drv.h > +++ b/dlls/winex11.drv/x11drv.h > @@ -701,6 +701,7 @@ struct x11drv_win_data > RECT whole_rect; /* X window rectangle for the whole window relative to parent */ > RECT client_rect; /* client area relative to parent */ > XIC xic; /* X input context */ > + XFontSet font_set; /* international text drawing font set */ > XWMHints *wm_hints; /* window manager hints */ > BOOL managed : 1; /* is window managed? */ > BOOL mapped : 1; /* is window mapped? (in either normal or iconic state) */ You shouldn't need to create a font set for each window, once per display should be enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: [user32: 2/2] Testcase for font size = 0x7fff
by Dan Kegel 15 Oct '08

15 Oct '08

Koro wrote: > That is an *excellent* explanation. Everything becomes > clear now, and indeed this should be documented somewhere > (except I can't find how to edit the wiki without making an account). That's because you need an account. (Otherwise there's too much spam. Accounts are free.) > Maybe somebody could wikify it for me? Done: http://wiki.winehq.org/Developers-Hints#head-8494fa344a35867c68b6bdd5e6256e… > if somebody wants to take up the project, I guess I > could release parts of the source (namely, the API > emulation and the layout / reflow code) under a very > specific can't-distribute-but-can-be-used-for-WINE > license. ... [That is,} > I'd give the necessary raw code for integration into > WINE (it'd have to be modified a lot), but once it gets > into WINE, it's WINE code and goes by the WINE license. > And therefore, if somebody wants to take that BACK > from WINE, and make their own TDEmu.dll, or anything > else for that matter, I don't care at all. I think we could live with that. It would be more convenient if you could right away place the code you send us under the LGPL, but either way is ok. Just send me the code along with either "I hereby release this code under the LGPL" or "I hereby release this code, as it is when it is finally merged into Wine, under the LGPL." - Dan

1 0

SourceForge community awards ... we won ... ;)
by Marcus Meissner 15 Oct '08

15 Oct '08

Hi, We won in the SourceForge.net2008 Community Choice Awards https://sourceforge.net/community/cca08/ in the Category: "Most Likely to Be Ambiguously and Baselessly Accused of Patent Violation" :) Ciao, Marcus

3 2

Patchwatcher is watching lostwages patches
by Scott Ritchie 15 Oct '08

15 Oct '08

Just a small bug, but patchwatcher is complaining about my lostwages patch not applying. Thanks, Scott Ritchie

2 1

Re: rpcrt4(2/2): Use pseudo-random numbers to generate UUIDs rather than using the (old, deprecated) MAC-address-and-time generation algorithm
by Alexandre Julliard 15 Oct '08

15 Oct '08

"Juan Lang" <juan.lang(a)gmail.com> writes: > This unfortunately causes test failures in quartz. I strongly suspect > the failures are spurious, because I'm pretty confident my tests show > that this change is correct, but I don't know enough about quartz to > know the cause. > --Juan > > From cf9fc613c3cff0cd258e42123cb7eb5dc66c1610 Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Mon, 13 Oct 2008 13:08:17 -0700 > Subject: [PATCH] Use pseudo-random numbers to generate UUIDs rather than using the (old, > deprecated) MAC-address-and-time generation algorithm The change is OK but you'll want to flesh out RtlGenRandom first, currently it will fail pretty badly if /dev/urandom isn't available. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Kernel32: 3GB UserSpace boot option
by Dmitry Timoshkov 15 Oct '08

15 Oct '08

You still need to prove the second part of your claims. Please don't omit wine-devel from the cc: list. [I'm intentionally top posting so that you caould see why it's bad] "Stefan Reimer" <lists(a)startux.de> wrote: > Yeap I did, see: > > quark@quarks ~ $ winedump .wine/drive_c/Program\ Files/Sony/EverQuest\ > II/EverQuest2.exe > Contents of .wine/drive_c/Program Files/Sony/EverQuest II/EverQuest2.exe: > 12918784 bytes > > File Header > Machine: 014C (i386) > Number of Sections: 6 > TimeDateStamp: 48EF93D1 (Fri Oct 10 19:41:37 2008) offset > 336 > PointerToSymbolTable: 00000000 > NumberOfSymbols: 00000000 > SizeOfOptionalHeader: 00E0 > Characteristics: 012E > EXECUTABLE_IMAGE > LINE_NUMS_STRIPPED > LOCAL_SYMS_STRIPPED > LARGE_ADDRESS_AWARE > 32BIT_MACHINE > > .... > > Done dumping .wine/drive_c/Program Files/Sony/EverQuest II/EverQuest2.exe > > > "Stefan Reimer" <lists(a)startux.de> wrote: > > > >> The EQ2 binary is large address aware. > >> > >> Windows changes it upper most user space address from 0x7FFEFFFF to > >> 0xBFFEFFFF booting with /3GB and this is not possible in wine right now > >> as > >> I think. > > > > Did you really check that? -- Dmitry.

1 0

Re: [user32: 2/2] Testcase for font size = 0x7fff
by Dmitry Timoshkov 15 Oct '08

15 Oct '08

"Koro" <webmaster(a)korosoft.net> wrote: > +static INT_PTR CALLBACK messageBoxFontDlgWinProc (HWND hDlg, UINT uiMsg, WPARAM wParam, > + LPARAM lParam) > +{ > + return (uiMsg == WM_INITDIALOG); > +} > + > +static void test_MessageBoxFontTest(void) > +{ > + /* Define a dialog that sets 0x7fff as font, and define one control. If the > + * dialog is created correctly, it means the 0x7fff was skipped correctly. */ > + > + static unsigned char test[] = > + { > + /* Dialog header */ > + 0x01,0x00, /* Version */ > + 0xff,0xff, /* Extended template marker */ > + 0x00,0x00,0x00,0x00, /* Context Help ID */ > + 0x00,0x00,0x00,0x00, /* Extended style */ > + 0xc0,0x00,0xc8,0x80, /* Style (WS_SYSMENU|WS_CAPTION|WS_POPUP|DS_SETFONT|DS_MODALFRAME) */ > + 0x01,0x00, /* Control count */ > + 0x00,0x00, /* X */ > + 0x00,0x00, /* Y */ > + 0x80,0x00, /* Width */ > + 0x80,0x00, /* Height */ > + 0x00,0x00, /* Menu name */ > + 0x00,0x00, /* Class name */ > + 'T',0x00,'e',0x00, /* Caption (unicode) */ > + 's',0x00,'t',0x00, > + 0x00,0x00, > + 0xff,0x7f, /* Font height (0x7fff = message box font) */ > + > + /* Control #1 */ > + 0x00,0x00, /* Align to DWORD (header is 42 bytes) */ > + 0x00,0x00,0x00,0x00, /* Context Help ID */ > + 0x00,0x00,0x00,0x00, /* Extended style */ > + 0x00,0x00,0x00,0x50, /* Style (WS_CHILD|WS_VISIBLE) */ > + 0x00,0x00, /* X */ > + 0x00,0x00, /* Y */ > + 0x80,0x00, /* Width */ > + 0x80,0x00, /* Height */ > + 0xff,0xff,0xff,0xff, /* Control ID */ > + 0xff,0xff,0x82,0x00, /* Class (Static) */ > + 'W',0x00,'I',0x00, /* Caption (unicode) */ > + 'N',0x00,'E',0x00, > + ' ',0x00,'d',0x00, > + 'i',0x00,'a',0x00, > + 'l',0x00,'o',0x00, > + 'g',0x00,' ',0x00, > + 't',0x00,'e',0x00, > + 's',0x00,'t',0x00, > + '.',0x00,0x00,0x00, > + 0x00,0x00, /* Size of extended data */ > + > + 0x00,0x00 /* Align to DWORD */ > + }; > + > + /* Now check if it can be created */ > + HWND hdlg = CreateDialogIndirectParam(g_hinst, (LPCDLGTEMPLATE)test, NULL, messageBoxFontDlgWinProc, 0); > + > + broken(hdlg == NULL); Is there a Windows version where CreateDialogIndirectParam fails? > + if (hdlg) > + ok(IsWindow(hdlg), "dialog with message box font was successfully created"); What exactly this code is supposed to test? So far it doesn't test anything related to the font size. -- Dmitry.

9 18

Kernel32: 3GB UserSpace boot option
by Stefan Reimer 15 Oct '08

15 Oct '08

Hi, I hacked wine to enable 3GB user address space just like the /3GB boot.ini option for windows. ( see patch ) This actually works like a charm playing everquest2 which crashes from time to time without this patch due to running out of memory. To do it right, should this "3GB Option" be enabled by a wine start parameter or a registry key ? Is the registry already setup during the call of libs/wine/mmap.c ? Bye Stefan Reimer diff --git a/dlls/kernel32/cpu.c b/dlls/kernel32/cpu.c index a49df99..61dd2be 100644 --- a/dlls/kernel32/cpu.c +++ b/dlls/kernel32/cpu.c @@ -383,7 +383,7 @@ VOID WINAPI GetSystemInfo( /* FIXME: the two entries below should be computed somehow... */ cachedsi.lpMinimumApplicationAddress = (void *)0x00010000; - cachedsi.lpMaximumApplicationAddress = (void *)0x7FFEFFFF; + cachedsi.lpMaximumApplicationAddress = (void *)0xBFFEFFFF; cachedsi.dwActiveProcessorMask = 0; cachedsi.dwNumberOfProcessors = 1; cachedsi.dwProcessorType = PROCESSOR_INTEL_PENTIUM; diff --git a/dlls/kernel32/heap.c b/dlls/kernel32/heap.c index 9931c09..aec818f 100644 --- a/dlls/kernel32/heap.c +++ b/dlls/kernel32/heap.c @@ -1336,7 +1336,7 @@ BOOL WINAPI GlobalMemoryStatusEx( LPMEMORYSTATUSEX lpmemex ) /* FIXME: should do something for other systems */ GetSystemInfo(&si); - lpmemex->ullTotalVirtual = (char*)si.lpMaximumApplicationAddress-(char*)si.lpMinimumApplicationAddress; + lpmemex->ullTotalVirtual = (unsigned long)si.lpMaximumApplicationAddress-(unsigned long)si.lpMinimumApplicationAddress; /* FIXME: we should track down all the already allocated VM pages and substract them, for now arbitrarily remove 64KB so that it matches NT */ lpmemex->ullAvailVirtual = lpmemex->ullTotalVirtual-64*1024; diff --git a/libs/wine/mmap.c b/libs/wine/mmap.c index ff117cc..6ae6664 100644 --- a/libs/wine/mmap.c +++ b/libs/wine/mmap.c @@ -346,7 +346,7 @@ void mmap_init(void) #if defined(__i386__) && !defined(__FreeBSD__) && !defined(__FreeBSD_kernel__) /* commented out until FreeBSD gets fixed */ char stack; char * const stack_ptr = &stack; - char *user_space_limit = (char *)0x7ffe0000; + char *user_space_limit = (char *)0xbffe0000; reserve_malloc_space( 8 * 1024 * 1024 );

4 5

Re[5] [user32: 2/2] Testcase for font size = 0x7fff
by Koro 15 Oct '08

15 Oct '08

> This is not the intent of an Open Source project like Wine. The object > is to get your name in 'lights' and help fix a problem or implement new > code. Others then my modify it or even correct problems you did not > envision when you produced your code. > This directly violates the spirit and intent of the LGPL. Since Wine > exists under that license model, this would not be very friendly. > Again, the object is to make a project work better or, in this case, > work more like Microsoft Windows through a third party Application > Programming Interface which works with the underlying UNIX/Linux > operating system. I think you missed my point. The thing is, I don't want people to be able to recompile their own version of a project of mine, because I want to be the only place where people get the binaries. There's also the problem of backspaceware but it's another story. Now, when I said "can't-distribute-but-can-be-used-for-WINE license", what I really meant was that, I'd give the necessary raw code for integration into WINE (it'd have to be modified a lot), but once it gets into WINE, it's WINE code and goes by the WINE license. And therefore, if somebody wants to take that BACK from WINE, and make their own TDEmu.dll, or anything else for that matter, I don't care at all.

1 0

setupapi tests question
by Reece Dunn 15 Oct '08

15 Oct '08

When building the setupapi tests with VC9 and the MSVC headers (Vista version) after using msvcmaker, I get the following output: 2>------ Build started: Project: setupapi_test, Configuration: Debug MSVC Headers Win32 ------ 2>Linking... 2>misc.obj : error LNK2019: unresolved external symbol _MyFree referenced in function _test_SetupGetFileCompressionInfo 2>.\Output\Win32_Debug_MSVC_Headers/setupapi_test.exe : fatal error LNK1120: 1 unresolved externals Where does MyFree come from? Why does this work with a Wine/MinGW build and not VC9? Thanks, - Reece

2 2

Re: (try 2) user: edit.c make sure our vlc (vertical line count) isat least 1 even if there is an oversized font in the edit control
by Dmitry Timoshkov 15 Oct '08

15 Oct '08

"Aric Stewart" <aric(a)codeweavers.com> wrote: > +static inline INT calculate_vlc(EDITSTATE *es) > +{ > + INT vlc = (es->format_rect.bottom - es->format_rect.top) / es->line_height; > + return max(1,vlc); > +} The formatting of the above hunk is broken, you will notice that once you set tab size in your editor to native 8. -- Dmitry.

1 0

Re: Try #2 IDirectDraw_CreateSurface Failure on WINE test in dsurface.c code
by chris ahrendt 14 Oct '08

14 Oct '08

Michael Karcher wrote: > I put the list back on CC because someone there might know about the > drmMap problem. > > Am Dienstag, den 14.10.2008, 15:30 -0700 schrieb chris ahrendt: > >>> PS: From the attachments of Chris' mail, one can get the following >>> information: The environment we are currently talking about is Wine on >>> Linux, an ATI FireGL 5200 graphics board driven by the closed source >>> driver, and somehow broken DRM. >>> >> >> Broken DRM? >> > Yes. This shouldn't appear in your log if DRM is working: > | libGL error: drmMap of framebuffer failed (Cannot allocate memory) > | libGL error: reverting to (slow) indirect rendering > > This might be caused by wine blocking the address space used for kernel > addresses in real windows, or it might be a misconfiguration or > installation problem of the ATI driver. Cross-checking with glxgears is > recommended. > > But even if non-functional DRM causes CreateSurface to fail you are > right that the testcase should handle that. > > Regards, > Michael Karcher > > > > > This used to be fixed like I said by doing the ulimit -s unlimited trick but now since drop 15 even that has stopped working. I did a little checking and there seems to be another way to get this error where the focus is lost for the X session. I just added this other fix as well : |Section "DRI" Group "video" Mode 0666 EndSection| | | Ati has a bug reported on this : 737-35215: Creating two successive connections my result in Direct GL context to fail here is a code fix that is supposed to work: The following (psuedocode) sequence, forces fglrx to revert to indirect rendering: dpy = XOpenDisplay() visual = glXChooseVisual(dpy) XCloseDisplay(dpy) ... dpy2 = XOpenDisplay() ctx = glXCreateContext(dpy2, visual) <-- fglrx reverts to indirect rendering ... Changing the code to use the same display connection for glXChooseVisual Chris and glXCreateContext solves this problem.

1 0

Re: Try #2 IDirectDraw_CreateSurface Failure on WINE test in dsurface.c code
by chris ahrendt 14 Oct '08

14 Oct '08

Michael Karcher wrote: > I put the list back on CC because someone there might know about the > drmMap problem. > > Am Dienstag, den 14.10.2008, 15:30 -0700 schrieb chris ahrendt: > >>> PS: From the attachments of Chris' mail, one can get the following >>> information: The environment we are currently talking about is Wine on >>> Linux, an ATI FireGL 5200 graphics board driven by the closed source >>> driver, and somehow broken DRM. >>> >> >> Broken DRM? >> > Yes. This shouldn't appear in your log if DRM is working: > | libGL error: drmMap of framebuffer failed (Cannot allocate memory) > | libGL error: reverting to (slow) indirect rendering > > This might be caused by wine blocking the address space used for kernel > addresses in real windows, or it might be a misconfiguration or > installation problem of the ATI driver. Cross-checking with glxgears is > recommended. > > But even if non-functional DRM causes CreateSurface to fail you are > right that the testcase should handle that. > > Regards, > Michael Karcher > > > > > Actually... I was told is because of the ATI driver issue with wine.... glxgears works just fine... I used to be able to get rid of the libGL errors by doing ulimit -s unlimited but since 15 drop even this has not worked... Chris

1 0

Re: Try #2 IDirectDraw_CreateSurface Failure on WINE test in dsurface.c code
by Michael Karcher 14 Oct '08

14 Oct '08

I put the list back on CC because someone there might know about the drmMap problem. Am Dienstag, den 14.10.2008, 15:30 -0700 schrieb chris ahrendt: > > PS: From the attachments of Chris' mail, one can get the following > > information: The environment we are currently talking about is Wine on > > Linux, an ATI FireGL 5200 graphics board driven by the closed source > > driver, and somehow broken DRM. > > Broken DRM? Yes. This shouldn't appear in your log if DRM is working: | libGL error: drmMap of framebuffer failed (Cannot allocate memory) | libGL error: reverting to (slow) indirect rendering This might be caused by wine blocking the address space used for kernel addresses in real windows, or it might be a misconfiguration or installation problem of the ATI driver. Cross-checking with glxgears is recommended. But even if non-functional DRM causes CreateSurface to fail you are right that the testcase should handle that. Regards, Michael Karcher

1 0

Re: [PATCH 07/10] jscript: Added NaN handling to relational operators.
by Tijl Coosemans 14 Oct '08

14 Oct '08

On Tuesday 14 October 2008 23:07:45 Jacek Caban wrote: > --- > dlls/jscript/engine.c | 28 ++++++++++++++++------------ > dlls/jscript/tests/lang.js | 12 ++++++++++++ > 2 files changed, 28 insertions(+), 12 deletions(-) > I'm not sure if this applies to javascript but if it does, you might want to add a test case for (( NaN == NaN ) === false ).

1 0

Re: Try #2 IDirectDraw_CreateSurface Failure on WINE test in dsurface.c code
by chris ahrendt 14 Oct '08

14 Oct '08

Yes if we need to move this off list please let me know.... Michael Karcher wrote: > That's why I suggested you to introduce the err2 label. The end of the > function should look like this: > Ya, Ich versteh.... here is the first patch to fix exception 1. I did have the patch with the skip but decided to try this: if (surface4)IDirectDrawSurface_Release(surface4); if (surface3) IDirectDrawSurface_Release(surface3); if (surface2) IDirectDrawSurface_Release(surface2); if (surface1) IDirectDrawSurface_Release(surface1); If I do the above I get the same exception on : if (surface3) IDirectDrawSurface_Release(surface3); So to fix that exception I have to do the following: if (FAILED(hr)) { skip("failed to create surface3\n"); if (surface2) IDirectDrawSurface_Release(surface2); if (surface1) IDirectDrawSurface_Release(surface1); return; } This is for IDirectDraw_CreateSurface failure which was not caught before for 3. The following is for the 4th surface : if (FAILED(hr)) { skip("failed to create surface4\n"); if (surface2) IDirectDrawSurface_Release(surface3); if (surface2) IDirectDrawSurface_Release(surface2); if (surface1) IDirectDrawSurface_Release(surface1); return; } Next Exception # 2 is caused by lines at 1138 : hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface1, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); To Fix that exception I have to add the below. if (FAILED(hr)) { skip("failed to create surface1\n"); return; } After that exception I have to close the window and reopen a new one to continue. make test refuses to run or acts strange.. So I figured the env. got hosed by the last exception. Clean up the ok files and .o and shared object and run make test. The run 3 is the final output. The two .ok files contain nothing. Chris

2 1

Re: Try #2
by chris ahrendt 14 Oct '08

14 Oct '08

Michael Karcher wrote: > Am Montag, den 13.10.2008, 21:05 -0400 schrieb Chris Ahrendt: > >> Fixed a trailing space error.. >> > Sorry to chime in so late on this patchset. > > First, some general remarks: The subject of your mail will be the > one-line commit message. "Try #2" is not a good choice for that. Also it > does not have enough context for the casual wine-patches reader, as the > message overview does not show what you patch is about. The usual > convention is to take the subject of the first try, and append (or > prepend) "(try 2)" to that subject. > > >> Subject: [PATCH] Pared Down Test For ddraw test... fixes error with IDirectDraw_CreateSurface >> where the test is not checking the return from the call. CreateSurface is returning a null. >> > Another convention is to *not* use the [PATCH] tag on wine-patches, as > all mails on wine-patches are patches. Use "--keep-subject" with > git-format-patch to prevent it. > Last, but not least, your original subject was way too long. Subjects on > wine-patches usually mention the component to be patched (that is > usually the directory name without dlls or programs in front) followed > by a short synopsis (around 40 to 60 characters, if possible). I suggest > the following subject for your next try: > > Subject: ddraw/tests: Catch failures of CreateSurface to prevent crash > > I don't remember whether you had the crash on Windows or on Wine. You > could put that info also into the subject. As it is more important what > the goal of your patch is than how you achieve that, something like this > might also be OK: > > Subject: ddraw/tests: Don't crash on Windows with GeForce 4399, driver 42.23 > > (this subject using made-up numbers on purpose, please fit in your own, > and only use this line if the crash *is* on native Windows) > > > >> diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c >> index fc7bb88..21e6b15 100644 >> --- a/dlls/ddraw/tests/dsurface.c >> +++ b/dlls/ddraw/tests/dsurface.c >> @@ -1181,7 +1181,10 @@ static void AttachmentTest7(void) >> ddsd.dwHeight = GetSystemMetrics(SM_CYSCREEN); >> hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface3, NULL); >> ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); >> - >> + if (FAILED(hr)) { >> + skip("failed to create surface3\n"); >> + return; >> + } >> /* This one has a different size */ >> memset(&ddsd, 0, sizeof(ddsd)); >> ddsd.dwSize = sizeof(ddsd); >> > return inside a test function is bad style. You may use it for try&crash > debugging, but I don't see any chance to get such a patch committed. In > this case, you leak one IDirectDraw7 interface, forget to restore the > cooperative level and you leak two surfaces. The "goto err:" approach is > preferred if a lot of cleanup is needed (like here). You either want to > make a label "err2:" before the IDirectDrawSurface7_Release(surface2) > and use that label (analogous for "err3:" one line before that) or use > the technique of setting released or uninitialized interface pointers to > NULL and NULL-Check before calling release. > > Same remarks for the next 3 hunks (not quoted). > Thing is the two surfaces have not been allocated yet.. they are off the local stack and just set to null. > >> @@ -2208,6 +2220,12 @@ static void SizeTest(void) >> desc.dwWidth = 128; /* Keep them set to check what happens */ >> ret = IDirectDraw_CreateSurface(lpDD, &desc, &dsurface, NULL); >> ok(ret == DD_OK, "Creating a primary surface without width and height info returned %08x\n", ret); >> + /* This should be handled but CreateSurface is failing */ >> + if (FAILED(ret)) >> + { >> + skip("Can't create cubemap surface\n"); >> + return; >> + } >> if(dsurface) >> { >> ret = IDirectDrawSurface_GetSurfaceDesc(dsurface, &desc); >> > The skip message is wrong. It's not about cubemap at all. Also, this > hunk is unneeded. If CreateSurface fails, dsurface is unmodified or set > to NULL (or CreateSurface really badly needs fixing!). As dsurface is > NULL on the call to CreateSurface, it is null if CreateSurface failed. > So the condition of the if statement following the CreateSurface call is > false, and no crash can happen on that NULL pointer. > > > Yes I just caught this message thanks .... I will fix that... The problem here which makes no sense to me is if I don't have the Failed statement before the dsurface if when it gets the surface description it throws an exception because one of the parms is null. That doesnt make sense thought because the contents of desc has been set earlier. So unless the CreateSurface call nulls out the description parm before returning. Any ideas? >> @@ -2492,7 +2510,7 @@ static void PaletteTest(void) >> ok(hr==DD_OK, "CreateSurface returned: %x\n",hr); >> if (FAILED(hr)) { >> skip("failed to create surface\n"); >> - goto err; >> + return; >> } >> >> hr = IDirectDrawSurface_SetPalette(lpSurf, palette); >> > Why do you need this hunk? You talked about usage of uninitialized > variables at the target of the goto, but that's not the case. The code > at err looks like this (formatting adjusted for clearness): > > | err: > | if (lpSurf) IDirectDrawSurface_Release(lpSurf); > | if (palette) IDirectDrawPalette_Release(palette); > > Again when I leave the goto err in and it does the release it throws an exception on the lpsurf line. > So the only two variables used here are lpSurf and palette. These two > variables are initialized at the point of definition. > > | static void PaletteTest(void) > | { > | HRESULT hr; > | LPDIRECTDRAWSURFACE lpSurf = NULL; > | DDSURFACEDESC ddsd; > | IDirectDrawPalette *palette = NULL; > > As they are initialized to NULL, the condition of the if statement is > false if these variables were not yet initialized. So no crash possible > here. Your return statement leaks palette. > > > Yes I saw that.. which is why it did not make much sense... if you want I can recreate and show you the exception which occurs when I don't have the return or the dsurface error I mentioned above. Its not that I don't know C (I have been writing in C for over 20 years so its not that.. (though I do admit at being rusty due to not doing anything but architecture and design)) . Any ideas? BTW Thank you for your comments... I do appreciate them =) Chris

2 1

Re: user: edit.c make sure our vlc (vertical line count) is at least 1 even if there is an oversized font in the edit control
by Juan Lang 14 Oct '08

14 Oct '08

Hi Aric, Just a suggestion: @@ -1818,6 +1818,7 @@ static void EDIT_ML_InvalidateText(EDITSTATE *es, INT start, INT end) RECT rcUpdate; INT l; + if (vlc == 0) vlc = 1; if ((el < es->y_offset) || (sl > es->y_offset + vlc)) return; @@ -2235,6 +2236,7 @@ static void EDIT_PaintLine(EDITSTATE *es, HDC dc, INT line, BOOL rev) if (es->style & ES_MULTILINE) { INT vlc = (es->format_rect.bottom - es->format_rect.top) / es->line_height; + if (vlc == 0) vlc = 1; rather than having to introduce the correction in every place it's used, replacing the initialization of vlc with a call to an inline function would reduce the new lines of code (and the probability of future error.) --Juan

2 1

Fwd: WWN 353
by Zachary Goldberg 14 Oct '08

14 Oct '08

I'm forwarding (with permission) to Wine-Devel an email I got about the most recent WWN and 'Other Platforms' support. --Zach ---------- Forwarded message ---------- From: Rodney Sparapani <rsparapa(a)mcw.edu> Date: Wed, Oct 8, 2008 at 1:02 PM Subject: WWN 353 To: zgold(a)bluesata.com Hi Zachary: I really like your column. But, I was shocked to read: The biggest issue in this area is demand. There were specific BSD builds of crossover posted sometime back after much demand and Codeweavers saw very very little response. As a result not much effort has been put into the area. In short: if you're a user of Wine on BSD, Solaris or OS X and want more support speak up! I don't know why the BSD experience with CrossOver has to have any bearing on OS X and Solaris support for Wine. Let me say it clearly: WE WANT SUPPORT! I have been trying to get Wine to work on these platforms for years. Some clever hackers created the Darwine package for OS X which has Wine in a nice installer and it has been working since about 0.9.12 (so a couple of years, I guess) and improving (which may have more to do with Wine improvements). For Solaris, Wine just started working for me with 1.1.3 (there were 3 Solaris patches in that release). Now, does this mean that I want to buy CrossOver? Not necessarily. I'm not sure if there is much to be gained. I certainly would consider it, if it was better. However, from my experience with the beta on OS X, I don't really see it as helpful at all. Maybe I'm wrong. But, if I'm wrong, then that doesn't mean that I don't want my platforms supported. -- Rodney Sparapani Center for Patient Care & Outcomes Research (PCOR) Sr. Biostatistician http://www.mcw.edu/pcor 4 wheels good, 2 wheels better! Medical College of Wisconsin (MCW) WWLD?: What Would Lombardi Do? Milwaukee, WI, USA

3 2

Re: [6/6] comdlg32: Add a basic test for IShellView2_CreateViewWindow2.
by Reece Dunn 14 Oct '08

14 Oct '08

2008/10/14 Henri Verbeet <hverbeet(a)codeweavers.com>: > + IShellView2_DestroyViewWindow(shell_view2); > + ok(SUCCEEDED(hr), "DestroyViewWindow returned %#x\n", hr); You are missing a "hr = " here, otherwise the ok check is not checking the return value from DestroyViewWindow. > + IShellView2_GetCurrentInfo(shell_view2, &folder_settings); > + ok(folder_settings.ViewMode == FVM_LIST, "view mode is %d, expected %d\n", folder_settings.ViewMode, FVM_LIST); Shouldn't this also be checking the HRESULT return value from GetCurrentInfo as per the other calls? General observation: other tests in Wine explicitly check for specific hr values, is there a reason you have used the generic SUCCEEDED here instead of that approach? - Reece

3 2

Re: comdlg32: Avoid possible NULL pointer dereference (Coverity)
by Kai Blin 14 Oct '08

14 Oct '08

On Tuesday 14 October 2008 11:10:34 Kai Blin wrote: > As the code checks for ofnW->lpstrFile not being NULL, it seems like > PathFindFileNameW() and PathFindExtensionW() don't make sense on NULL > ofnW->lpstrFile. If offset and extension are not updated, it doesn't make > sense to call UpdateResults. So just abort if ofnW->lpstrFile is NULL. > > This fixes Coverity CID 108 > --- > dlls/comdlg32/filedlg31.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) Of course I forgot to switch the logic. New patch coming up. -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [TRY 2] user32: Add test to check the MDI child switching
by Dmitry Timoshkov 14 Oct '08

14 Oct '08

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > + trace("creating maximized visible MDI child window 3\n"); > + mdi_child3 = CreateWindowExA(WS_EX_MDICHILD, "MDI_child_class", "MDI child", > + WS_CHILD | WS_VISIBLE | WS_MAXIMIZEBOX | WS_MAXIMIZE, > + 0, 0, CW_USEDEFAULT, CW_USEDEFAULT, > + mdi_client, 0, GetModuleHandleA(0), NULL); > + assert(mdi_child3); > + > + active_child = (HWND)SendMessageW(mdi_client, WM_MDIGETACTIVE, 0, 0); > + SendMessageW(mdi_client, WM_MDINEXT, 0, 0); > + SendMessageW(mdi_client, WM_MDINEXT, 0, 0); > + ok(active_child != (HWND)SendMessageW(mdi_client, WM_MDIGETACTIVE, 0, 0), "wrong active MDI child %p\n", > active_child); > + > + trace("destroying maximized visible MDI child window 3\n"); > + DestroyWindow(mdi_child3); What's the purpose of creating the 3rd MDI child if you don't care about values returned by WM_MDIGETACTIVE, nor about intermediate results of WM_MDINEXT? Apparently you have all MDI children handles in your hands and can use them in the tests. -- Dmitry.

1 0

Re: [6/6] comdlg32: Add a basic test for IShellView2_CreateViewWindow2.
by Henri Verbeet 14 Oct '08

14 Oct '08

2008/10/14 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de>: > But there might be Win32 applications that do care about specific return > values. So the implementation in Wine has to match native in returning > S_OK or S_FALSE (the two most common success values). What is the point > in not testing your implementation in this regard? > It is pretty rare for COM interfaces to return anything other than S_OK on success, so I doubt it will make much of a difference in practice. However, if there's really an application that depends on a specific return value on success for this interface I'll be sure to modify the test. I don't particularly care though, so if people feel strongly that the test should be using "hr == S_OK" I don't mind changing that. Note that there are plenty of other tests that use SUCCEEDED/FAILED though.

1 0

Fix to exceptions in ddtest
by Chris Ahrendt 14 Oct '08

14 Oct '08

Ok I have threaded through ddraw_test adding as I had them fail a check and a fix in dsurface.c test. The test now fails when the CreateSurface fails. Before this there were several point in the test where the return status was not checked. As I encountered them and they failed with an exception I added the failure I found at other parts which did the create surface. For some reason a 3rd and 4th surface fails on ATI. Addached you will find the proposed fix. I also found a point where the code did not skip but did a goto to the error point with the variables unitialised. Chris >From 52071bddae683a1964d64be0acbfec8d7b2c2c5e Mon Sep 17 00:00:00 2001 From: Chris Ahrendt <celticht32(a)aol.com> Date: Sun, 12 Oct 2008 21:44:21 -0400 Subject: [PATCH] Fix to ddtest to fail test if IDirectDraw_CreateSurface failed. Create Surface was failing and setting the handle to the surface to null. So when the free / release was called it threw an exception instead of failing the test. --- dlls/ddraw/tests/dsurface.c | 92 ++++++++++++++++++++++++++++++++++--------- 1 files changed, 73 insertions(+), 19 deletions(-) diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c index fc7bb88..4f545d9 100644 --- a/dlls/ddraw/tests/dsurface.c +++ b/dlls/ddraw/tests/dsurface.c @@ -198,7 +198,10 @@ static void MipMapCreationTest(void) ddsd.dwHeight = 32; rc = IDirectDraw_CreateSurface(lpDD, &ddsd, &lpDDSMipMapTest, NULL); ok(rc==DDERR_INVALIDPARAMS,"CreateSurface returned: %x\n",rc); - + if (FAILED(rc)) { + skip("failed to create surface\n"); + return; + } /* Destroy the surface. */ if( rc == DD_OK ) IDirectDrawSurface_Release(lpDDSMipMapTest); @@ -1004,7 +1007,10 @@ static void EnumTest(void) ddsd.dwHeight = 32; rc = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface, NULL); ok(rc==DD_OK,"CreateSurface returned: %x\n",rc); - + if (FAILED(rc)) { + skip("failed to create surface\n"); + return; + } memset(&ctx, 0, sizeof(ctx)); ctx.expected[0] = surface; rc = IDirectDrawSurface_GetAttachedSurface(ctx.expected[0], &ddsd.ddsCaps, &ctx.expected[1]); @@ -1055,7 +1061,10 @@ static void AttachmentTest7(void) ddsd.dwHeight = 128; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface1, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface\n"); + return; + } /* ROOT */ num = 0; IDirectDrawSurface7_EnumAttachedSurfaces(surface1, &num, SurfaceCounter); @@ -1092,7 +1101,10 @@ static void AttachmentTest7(void) ddsd.dwHeight = 16; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface2, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface2\n"); + return; + } hr = IDirectDrawSurface7_AddAttachedSurface(surface1, surface2); ok(hr == DDERR_CANNOTATTACHSURFACE, "Attaching a 16x16 surface to a 128x128 texture root returned %08x\n", hr); hr = IDirectDrawSurface7_AddAttachedSurface(surface2, surface1); @@ -1112,7 +1124,10 @@ static void AttachmentTest7(void) ddsd.dwHeight = 16; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface2, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface\n"); + return; + } hr = IDirectDrawSurface7_AddAttachedSurface(surface1, surface2); ok(hr == DDERR_CANNOTATTACHSURFACE, "Attaching a 16x16 offscreen plain surface to a 128x128 texture root returned %08x\n", hr); hr = IDirectDrawSurface7_AddAttachedSurface(surface2, surface1); @@ -1136,7 +1151,10 @@ static void AttachmentTest7(void) ddsd.dwBackBufferCount = 2; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface1, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface\n"); + return; + } num = 0; IDirectDrawSurface7_EnumAttachedSurfaces(surface1, &num, SurfaceCounter); ok(num == 1, "Primary surface has %d surfaces attached, expected 1\n", num); @@ -1149,13 +1167,20 @@ static void AttachmentTest7(void) ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE | DDSCAPS_FRONTBUFFER; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface1, NULL); ok(hr==DDERR_INVALIDCAPS,"CreateSurface returned: %x\n",hr); + if (FAILED(hr)) { + skip("failed to create surface1\n"); + return; + } memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); ddsd.dwFlags = DDSD_CAPS; ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE | DDSCAPS_BACKBUFFER; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface2, NULL); ok(hr==DDERR_INVALIDCAPS,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface2\n"); + return; + } /* Try a single primary and two offscreen plain surfaces */ memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); @@ -1163,7 +1188,10 @@ static void AttachmentTest7(void) ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface1, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface1\n"); + return; + } memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; @@ -1172,7 +1200,10 @@ static void AttachmentTest7(void) ddsd.dwHeight = GetSystemMetrics(SM_CYSCREEN); hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface2, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface2\n"); + return; + } memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; @@ -1181,7 +1212,10 @@ static void AttachmentTest7(void) ddsd.dwHeight = GetSystemMetrics(SM_CYSCREEN); hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface3, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface3\n"); + return; + } /* This one has a different size */ memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); @@ -1191,6 +1225,10 @@ static void AttachmentTest7(void) ddsd.dwHeight = 128; hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface4, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); + if (FAILED(hr)) { + skip("failed to create surface4\n"); + return; + } hr = IDirectDrawSurface7_AddAttachedSurface(surface1, surface2); ok(hr == DDERR_CANNOTATTACHSURFACE, "Attaching an offscreen plain surface to a front buffer returned %08x\n", hr); @@ -1334,7 +1372,7 @@ static void AttachmentTest(void) ddsd.dwFlags = DDSD_CAPS; ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE | DDSCAPS_FRONTBUFFER; hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface1, NULL); - ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); + ok(hr==DD_OK,"CreateSurface return ed: %x\n",hr); IDirectDrawSurface_Release(surface1); /* Try a single primary and two offscreen plain surfaces */ @@ -1344,7 +1382,10 @@ static void AttachmentTest(void) ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE; hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface1, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface1\n"); + return; + } memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; @@ -1353,7 +1394,10 @@ static void AttachmentTest(void) ddsd.dwHeight = GetSystemMetrics(SM_CYSCREEN); hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface2, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface2\n"); + return; + } memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; @@ -1362,7 +1406,10 @@ static void AttachmentTest(void) ddsd.dwHeight = GetSystemMetrics(SM_CYSCREEN); hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface3, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface3\n"); + return; + } /* This one has a different size */ memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); @@ -1372,7 +1419,10 @@ static void AttachmentTest(void) ddsd.dwHeight = 128; hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface4, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - + if (FAILED(hr)) { + skip("failed to create surface4\n"); + return; + } hr = IDirectDrawSurface_AddAttachedSurface(surface1, surface2); ok(hr == DD_OK, "Attaching an offscreen plain surface to a front buffer returned %08x\n", hr); /* Try the reverse without detaching first */ @@ -2208,6 +2258,10 @@ static void SizeTest(void) desc.dwWidth = 128; /* Keep them set to check what happens */ ret = IDirectDraw_CreateSurface(lpDD, &desc, &dsurface, NULL); ok(ret == DD_OK, "Creating a primary surface without width and height info returned %08x\n", ret); + if (FAILED(ret)) { + skip("failed to create surface\n"); + return; + } if(dsurface) { ret = IDirectDrawSurface_GetSurfaceDesc(dsurface, &desc); @@ -2491,9 +2545,9 @@ static void PaletteTest(void) hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &lpSurf, NULL); ok(hr==DD_OK, "CreateSurface returned: %x\n",hr); if (FAILED(hr)) { - skip("failed to create surface\n"); - goto err; - } + skip("failed to create surface\n"); + return; + } hr = IDirectDrawSurface_SetPalette(lpSurf, palette); ok(hr == DDERR_INVALIDPIXELFORMAT, "CreateSurface returned: %x\n",hr); @@ -2503,7 +2557,7 @@ static void PaletteTest(void) hr = IDirectDrawSurface_GetPalette(lpSurf, &palette); ok(hr == DDERR_NOPALETTEATTACHED, "CreateSurface returned: %x\n",hr); - + err: if (lpSurf) IDirectDrawSurface_Release(lpSurf); -- 1.5.5.1

4 5

Re: Try #2
by Michael Karcher 14 Oct '08

14 Oct '08

Am Montag, den 13.10.2008, 21:05 -0400 schrieb Chris Ahrendt: > Fixed a trailing space error.. Sorry to chime in so late on this patchset. First, some general remarks: The subject of your mail will be the one-line commit message. "Try #2" is not a good choice for that. Also it does not have enough context for the casual wine-patches reader, as the message overview does not show what you patch is about. The usual convention is to take the subject of the first try, and append (or prepend) "(try 2)" to that subject. > Subject: [PATCH] Pared Down Test For ddraw test... fixes error with IDirectDraw_CreateSurface > where the test is not checking the return from the call. CreateSurface is returning a null. Another convention is to *not* use the [PATCH] tag on wine-patches, as all mails on wine-patches are patches. Use "--keep-subject" with git-format-patch to prevent it. Last, but not least, your original subject was way too long. Subjects on wine-patches usually mention the component to be patched (that is usually the directory name without dlls or programs in front) followed by a short synopsis (around 40 to 60 characters, if possible). I suggest the following subject for your next try: Subject: ddraw/tests: Catch failures of CreateSurface to prevent crash I don't remember whether you had the crash on Windows or on Wine. You could put that info also into the subject. As it is more important what the goal of your patch is than how you achieve that, something like this might also be OK: Subject: ddraw/tests: Don't crash on Windows with GeForce 4399, driver 42.23 (this subject using made-up numbers on purpose, please fit in your own, and only use this line if the crash *is* on native Windows) > diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c > index fc7bb88..21e6b15 100644 > --- a/dlls/ddraw/tests/dsurface.c > +++ b/dlls/ddraw/tests/dsurface.c > @@ -1181,7 +1181,10 @@ static void AttachmentTest7(void) > ddsd.dwHeight = GetSystemMetrics(SM_CYSCREEN); > hr = IDirectDraw7_CreateSurface(dd7, &ddsd, &surface3, NULL); > ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); > - > + if (FAILED(hr)) { > + skip("failed to create surface3\n"); > + return; > + } > /* This one has a different size */ > memset(&ddsd, 0, sizeof(ddsd)); > ddsd.dwSize = sizeof(ddsd); return inside a test function is bad style. You may use it for try&crash debugging, but I don't see any chance to get such a patch committed. In this case, you leak one IDirectDraw7 interface, forget to restore the cooperative level and you leak two surfaces. The "goto err:" approach is preferred if a lot of cleanup is needed (like here). You either want to make a label "err2:" before the IDirectDrawSurface7_Release(surface2) and use that label (analogous for "err3:" one line before that) or use the technique of setting released or uninitialized interface pointers to NULL and NULL-Check before calling release. Same remarks for the next 3 hunks (not quoted). > @@ -2208,6 +2220,12 @@ static void SizeTest(void) > desc.dwWidth = 128; /* Keep them set to check what happens */ > ret = IDirectDraw_CreateSurface(lpDD, &desc, &dsurface, NULL); > ok(ret == DD_OK, "Creating a primary surface without width and height info returned %08x\n", ret); > + /* This should be handled but CreateSurface is failing */ > + if (FAILED(ret)) > + { > + skip("Can't create cubemap surface\n"); > + return; > + } > if(dsurface) > { > ret = IDirectDrawSurface_GetSurfaceDesc(dsurface, &desc); The skip message is wrong. It's not about cubemap at all. Also, this hunk is unneeded. If CreateSurface fails, dsurface is unmodified or set to NULL (or CreateSurface really badly needs fixing!). As dsurface is NULL on the call to CreateSurface, it is null if CreateSurface failed. So the condition of the if statement following the CreateSurface call is false, and no crash can happen on that NULL pointer. > @@ -2492,7 +2510,7 @@ static void PaletteTest(void) > ok(hr==DD_OK, "CreateSurface returned: %x\n",hr); > if (FAILED(hr)) { > skip("failed to create surface\n"); > - goto err; > + return; > } > > hr = IDirectDrawSurface_SetPalette(lpSurf, palette); Why do you need this hunk? You talked about usage of uninitialized variables at the target of the goto, but that's not the case. The code at err looks like this (formatting adjusted for clearness): | err: | if (lpSurf) IDirectDrawSurface_Release(lpSurf); | if (palette) IDirectDrawPalette_Release(palette); So the only two variables used here are lpSurf and palette. These two variables are initialized at the point of definition. | static void PaletteTest(void) | { | HRESULT hr; | LPDIRECTDRAWSURFACE lpSurf = NULL; | DDSURFACEDESC ddsd; | IDirectDrawPalette *palette = NULL; As they are initialized to NULL, the condition of the if statement is false if these variables were not yet initialized. So no crash possible here. Your return statement leaks palette. Regards, Michael Karcher

1 0

Re: user32: Add test to check the MDI child switching
by Dmitry Timoshkov 14 Oct '08

14 Oct '08

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > --- a/dlls/user32/tests/win.c > +++ b/dlls/user32/tests/win.c > @@ -1674,9 +1674,78 @@ static BOOL mdi_RegisterWindowClasses(void) > cls.lpszClassName = "MDI_child_Class_2"; > if(!RegisterClassA(&cls)) return FALSE; > > + cls.lpfnWndProc = DefWindowProcW; > + cls.lpszClassName = "MDI_parent_Class_def"; > + if(!RegisterClassA(&cls)) return FALSE; > + > + cls.lpfnWndProc = DefMDIChildProcW; > + cls.lpszClassName = "MDI_child_Class_def"; > + if(!RegisterClassA(&cls)) return FALSE; The above A/W mishmash can't work. > +HWND CreateNewMDIChild(HWND hMDIClient) > +{ > + HWND hChild; > + > + hChild=CreateMDIWindow("MDI_child_Class_def", "MDI child", WS_CHILD | WS_VISIBLE, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + CW_USEDEFAULT, > + hMDIClient, > + GetModuleHandle(NULL), 0); > + > + if(!hChild) > + { > + ok(0,"MDI child creation failed\n"); > + } It's better to not use ok(0) statements, and do the actual check inside of ok(), in this case ok(hChild != 0). > + active = (HWND)SendMessageW(mdi_client, WM_MDIGETACTIVE, 0, 0); > + SendMessageW(mdi_client, WM_MDINEXT, 0, 0); > + SendMessageW(mdi_client, WM_MDINEXT, 0, 0); > + ok(active != (HWND)SendMessageW(mdi_client, WM_MDIGETACTIVE, 0, 0), "MDI child switching error\n"); Wouldn't it be much easier to just add 4 lines above into existing tests? -- Dmitry.

1 0

Window Screensaver in Wine
by slawek 14 Oct '08

14 Oct '08

I'm working on wrapper(app) which enabled to embed Windows window into xscreensaver-demo window and in screensaver window. In last time I have worried about project state. I was starting it three months ago, but I really programme it since two-three weeks. The most weight reason is that, I don't know how prevents mouse messages and keyboard to be received by Windows app. At early state of project I have noticed, that I can give Window app /P <desktop window id received by CreateWindowEx hwnd, nor 0> instead of /S, but I guess some Windows screen saver don't like to show preview. I don't know, what I could do in this state, so I have decided to show somebody my code. Is a good think, to public my wrapper on your site(http://www.winehq.org), but it's not good point to get it inside the Wine. It's not reason to do that if Wine don't use my app in any way. Another think is that, my app depend on xlib and xscreensaver, so it's necesary to run it on Unix like systems(Wine are in the Windows too). Somebody are interested in my app? Maybe some user need them and it can be good place to make some experiments(ex. making Window flash to work under Linux version of Firefox)? What I should to do?

3 2

Re: user32: update DrawText tests to cover behavior differences on win98
by Dmitry Timoshkov 14 Oct '08

14 Oct '08

"Aric Stewart" <aric(a)codeweavers.com> wrote: > diff --git a/dlls/user32/tests/text.c b/dlls/user32/tests/text.c > index 86655d6..3677d2f 100644 > --- a/dlls/user32/tests/text.c > +++ b/dlls/user32/tests/text.c > @@ -674,13 +674,20 @@ static void test_DrawState(void) > SetLastError(0xdeadbeef); > ret = DrawState(hdc, GetStockObject(DKGRAY_BRUSH), NULL, 0, strlen(text), > 0, 0, 10, 10, DST_TEXT); > - ok(!ret, "DrawState succeeded\n"); > + /* succeeds on windows 98 */ > + if (ret) > + win_skip("DrawState succeeds on Windows 98\n"); > + else > + ok(!ret, "DrawState succeeded\n"); > ok(GetLastError() == 0xdeadbeef, "not expected error %u\n", GetLastError()); > > SetLastError(0xdeadbeef); > ret = DrawState(hdc, GetStockObject(DKGRAY_BRUSH), NULL, 0, 0, > 0, 0, 10, 10, DST_TEXT); > - ok(!ret, "DrawState succeeded\n"); > + if (ret) > + win_skip("DrawState succeeds on Windows 98\n"); > + else > + ok(!ret, "DrawState succeeded\n"); > ok(GetLastError() == 0xdeadbeef, "not expected error %u\n", GetLastError()); > > ReleaseDC(hwnd, hdc); skip()/win_skip() are supposed to be used when the test(s) are going to be skipped due to some condition, in this case nothing is skipped, and broken() sounds like a better choice. -- Dmitry.

1 0

re: [user32: 2/2] Testcase for font size = 0x7fff
by Dan Kegel 13 Oct '08

13 Oct '08

Koro wrote: > I wrote one this summer (http://www.korosoft.net/projects/tdemu/). Interesting. Would you be willing to contribute your Task Dialogs implementation to Wine under the terms of the LGPL? If not, well, thanks for the testcase and bug fix! - Dan

3 3

Re: ConvertStringSecurityDescriptorToSecurityDescriptor - more tests (pass)
by James Hawkins 13 Oct '08

13 Oct '08

On Mon, Oct 13, 2008 at 4:23 PM, Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> wrote: > A second attempt that, I hope, takes into account feedback from James > Hawkins. > > Original correction to ParseStringAclToAcl() to set missing error code > stands. > > Gratuitous setting of invalid parameter withdrawn. > > Replaced with check for NULL on StringSecurityDescriptor parameter in both A > and W forms of ConvertStringSecurityDescriptorToSecurityDescriptor. > > New checks backed up by additional test cases. > > Two instances of "highly superfluous" TRACE removed as suggested by JH, > > Issue - unable to add test cases that show > > if (GetVersion() & 0x80000000) > SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > > should precede checks for NULL parameters. What to do ? Drop patch > altogether ? > + if (GetVersion() & 0x80000000) + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); Where are you getting this from? -- James Hawkins

1 0

Re: loadperf: add stub dll
by Austin English 13 Oct '08

13 Oct '08

On Mon, Oct 13, 2008 at 4:20 PM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > as outlined in bug http://bugs.winehq.org/show_bug.cgi?id=12099, fixes a > crash in some apps that try install .net 1.1; also fixes a crash (Unhandled > page fault...) in dotnet20 installer (though that crash is not fatal there, > the dotnet 2.0 continues happily after it) > > > > > You've got changes to configure as well as configure.ac. Please remove the changes to configure. -- -Austin

1 0

Re: [try2] wordpad: do not try to close uninitialized handles
by James Hawkins 13 Oct '08

13 Oct '08

On Mon, Oct 13, 2008 at 2:42 PM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > [another approach with smaller changeset, as James suggested] > > Fix some functions where CloseHandle was called not matter if previous > open succeeded or not. > @@ -96,12 +96,13 @@ void registry_set_options(HWND hMainWnd) registry_set_pagemargins(hKey); } - RegCloseKey(hKey); + if (hKey) + RegCloseKey(hKey); Please get rid of this check for NULL hKey. We've spent a lot of time removing such checks. -- James Hawkins

1 0

RE: d3d9/tests: Fix test for old gfx-card
by Stefan Dösinger 13 Oct '08

13 Oct '08

It is kinda strange, since the NULLREF device should be device independent, but I think the patch is OK. Catching device creation failures sounds ok even in this situation > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Detlef Riekenberg > Sent: Monday, October 13, 2008 1:55 AM > To: wine-patches(a)winehq.org > Subject: d3d9/tests: Fix test for old gfx-card > > > My "Radeon Mobility M7" is to old. > > > -- > > By by ... Detlef

2 1

Re: user32: Add the parameter bStatic in MDI_GetWindow to select theusing child list
by Dmitry Timoshkov 13 Oct '08

13 Oct '08

"Ilya Shpigor" <shpigor(a)etersoft.ru> wrote: > The wine have problem with the Ctrl+Shift+Tab switching between the MDI > windows (switch only neghboring windows). I suppose, that reason of this is > using the WIN_ListChildren in the MDI_GetWindow function. WIN_ListChildren > return the child list with the variable sequence of elements. This sequence > depends on the current active window. > But in some cases we need this variable sequence. For example to determine > the focused window after destroy other window. > This patch add new parameter in MDI_GetWindow to check that child list are > needed. There is the clientInfo->child using instead the WIN_ListChildren. > Also some necessary changes in processing this list are added. A usual aproach to fixing Wine bugs is to create a test case to demonstrate the problem first, have it committed, and only then start making pass it. So far it's not clear (at least to me) what you are trying to fix. -- Dmitry.

1 0

Re: shlwapi: Implement SHSendMessageBroadcastA/W [try #2: Resend]
by Alexandre Julliard 13 Oct '08

13 Oct '08

Detlef Riekenberg <wine.dev(a)web.de> writes: > Patch was not committed and got no additional comments. > > More Hints? It's supposed to handle non-responsive windows. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/4] mshtml: Implement IHTMLStyle get/put posLeft (try 3)
by Jacek Caban 13 Oct '08

13 Oct '08

> {attrLeft, DISPID_IHTMLSTYLE_LEFT}, > + {attrLeft, DISPID_IHTMLSTYLE_POSLEFT}, You can't duplicate attr names in this table. We want to map 'left' to DISPID_IHTMLSTYLE_LEFT, not to random one. Jacek

1 0

Re: comctl32/tests: Fix tests to not depend on 96 dpi
by Dmitry Timoshkov 13 Oct '08

13 Oct '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > #define DEFAULT_MIN_TAB_WIDTH 54 > -#define TAB_DEFAULT_WIDTH 96 > #define TAB_PADDING_X 6 > #define EXTRA_ICON_PADDING 3 > #define MAX_TABLEN 32 > @@ -507,11 +506,13 @@ static void test_tab(INT nMinTabWidth) > HDC hdc; > HFONT hOldFont; > INT i; > + DWORD dpi; > > hwTab = create_tabcontrol(TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE); > SendMessage(hwTab, TCM_SETMINTABWIDTH, 0, nMinTabWidth); > > hdc = GetDC(hwTab); > + dpi = GetDeviceCaps(hdc, LOGPIXELSY); If you are replacing 'width' shouldn't this be LOGPIXELSX? -- Dmitry.

1 0

Re: gdi32/tests: Fix tests to not depend on 96 dpi
by Dmitry Timoshkov 13 Oct '08

13 Oct '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > @@ -101,7 +101,9 @@ static void test_world_transform(void) > > if (is_win9x) > { > - expect_viewport_ext(hdc, 96, 96); > + DWORD dpi; > + dpi = GetDeviceCaps(hdc, LOGPIXELSY); > + expect_viewport_ext(hdc, dpi, dpi); This is still not correct, not all displays have the same resolution in all dimensions. The below one should be slightly better: expect_viewport_ext(hdc, GetDeviceCaps(hdc, LOGPIXELSX), GetDeviceCaps(hdc, LOGPIXELSY)); -- Dmitry.

1 0

patchwatcher status
by Dan Kegel 13 Oct '08

13 Oct '08

The most pressing issue for patchwatcher is to finish the refactoring into libpatchwatcher.sh and wine-slave.sh. I made a tiny bit of progress there today by applying some typo fixes Rob sent me, and adding the missing timeout enforcement that was already in the monolithic patchwatcher. (Checked in to svn if anyone cares, but not yet useful.) I also added winhttp/tests/__test__ to the blacklist, since it's failed now for three unrelated patches. - Dan

1 0

Re: DIB engine status
by Detlef Riekenberg 12 Oct '08

12 Oct '08

On 9/29/08, Sergey Novosyolov <chi(a)etersoft.ru> wrote: >> The first thing, i like to see is a Design in the correct way: >> Inside gdi32 while using Eng* and friends. >> (Needed by Printer drivers, and any Display driver including mirror / >> remote display drivers) >> > why can't we release DIB-Engine as own driver? GDI32 functions are main and > GDI32 calls driver functions in dependence of which type of DC we have > (printer DC, Xwindow HDC or DIB DC) Any Driver can call the Graphic Rendering Engine (GRE) to do parts (or all) of the rendering (and native driver do that): 1: DDB (Driver managed: using any driver specific format) (The Driver should do Everything. When the driver call the GRE, the DDB is converted to a DIB, GDI renders into the DIB and then the DIB is converted back to a DDB) => like our winex11.drv and wineps.drv 2: DDB (GDI managed: using DIB format) (The driver render, what the driver want to render with hw-support and can call the GRE for all the other rendering without converting) => Needed for native printer drivers / mirror drivers or OpenGL accelerated rendering (stefan did some experiments) 3: DIB (GDI renders everything) => The current Code is using a X11-DDB (Driver Managed) with converting issues. With a winedib.drv (the experimental tree is a wrapper around a wine driver), native printer drivers / mirror drivers will never work without another (additional) wrapper. -- By by ... Detlef

1 0

Re: winex11.drv: Improve tracing of wintab WTInfo
by James Hawkins 12 Oct '08

12 Oct '08

On Sun, Oct 12, 2008 at 3:42 PM, John Klehm <xixsimplicityxix(a)gmail.com> wrote: > @@ -1079,6 +1079,7 @@ UINT X11DRV_WTInfoW(UINT wCategory, UINT nIndex, LPVOID lpOutput) switch(wCategory) { case 0: + TRACE("category: NULL. Asking for needed buffer size"); /* return largest necessary buffer */ TRACE("%i cursors\n",gNumCursors); if (gNumCursors>0) @@ -1088,29 +1089,35 @@ UINT X11DRV_WTInfoW(UINT wCategory, UINT nIndex, LPVOID lpOutput) } break; case WTI_INTERFACE: + TRACE("category: WTI_INTERFACE\n"); These are extremely superfluous traces. The value of wCategory is traced a few lines up. Why do you need to see anything more than that? Same goes for the rest of the traces you added throughout the patch. -- James Hawkins

1 0

Re: Added missing values to VGA Mode 19 (256 color) palette registers with comments for related VGA operations. Windows programs that access VGA directly or through BIOS that previously displayed black for many values should now show correct values f
by James Hawkins 12 Oct '08

12 Oct '08

On Sat, Oct 11, 2008 at 4:15 PM, Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com> wrote: > > @@ -476,10 +743,12 @@ static void WINAPI VGA_DoSetMode(ULONG_PTR arg) > return; > } > IDirectDrawSurface_SetPalette(lpddsurf,lpddpal); > + > vga_retrace_vertical = vga_retrace_horizontal = FALSE; > /* poll every 20ms (50fps should provide adequate responsiveness) */ > VGA_InstallTimer(20); > } > + > par->ret=0; > return; > } > There are way too many unnecessary whitespace changes in this patch. Please take them out and resend. -- James Hawkins

1 0

Re: wordpad: do not try to close uninitialized handles
by James Hawkins 12 Oct '08

12 Oct '08

On Sun, Oct 12, 2008 at 6:09 AM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > > Fix some functions where CloseHandle was called not matter if previous > open succeeded or not. > HKEY hKey; DWORD size = sizeof(RECT); + BOOL succeeded = FALSE; - if(registry_get_handle(&hKey, 0, key_options) != ERROR_SUCCESS || - RegQueryValueExW(hKey, var_framerect, 0, NULL, (LPBYTE)rc, &size) != - ERROR_SUCCESS || size != sizeof(RECT)) + if(registry_get_handle(&hKey, 0, key_options) == ERROR_SUCCESS) + { + if (RegQueryValueExW(hKey, var_framerect, 0, NULL, (LPBYTE)rc, &size) == + ERROR_SUCCESS && size == sizeof(RECT)) + { + succeeded = TRUE; + } + + RegCloseKey(hKey); + } + if (!succeeded) { All of these changes would be a lot cleaner if you just initialize hKey to 0. -- James Hawkins

1 0

Re: wordpad: do not pass resource ids to MessageBox
by Dmitry Timoshkov 12 Oct '08

12 Oct '08

"Andrey Turkin" <andrey.turkin(a)gmail.com> wrote: > It seems that automatic loading of string from resources in MessageBox* > is Wine extension. Useful and logical one but still other platform does > not support it. That's not a Wine extension, looks like the author of that code just didn't test it. One need to use MessageBoxEx to make it work. -- Dmitry.

2 2

Proposal: switch Wine source tree to utf-8
by Dan Kegel 12 Oct '08

12 Oct '08

The Chinese resource files are already utf-8, but I suspect lots of other files are in obscure character sets, which complicates patch processing and display. Just how silly would it be for us to bite the bullet and set all source files to utf-8? We'd need to recode a bunch of files once, but after that, there'd be less confusion about how to view and edit various resource files. Not saying we should up and do it, just throwing out an idea for discussion...

3 3

Re: mshtml: Implement IHTMLStyle get/put posLeft
by Jacek Caban 12 Oct '08

12 Oct '08

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft > > Best Regards > Alistair Leslie-Hughes > > {attrMarginRight, DISPID_IHTMLSTYLE_MARGINRIGHT}, > {attrPaddingLeft, DISPID_IHTMLSTYLE_PADDINGLEFT}, > + {attrLeft, DISPID_IHTMLSTYLE_POSLEFT}, > {attrPosition, DISPID_IHTMLSTYLE2_POSITION}, > {attrTextAlign, DISPID_IHTMLSTYLE_TEXTALIGN}, You can't do this. style_tbl must be sorted because we do binary search on it. Jacek

1 0

Re: notoskrnl.exe: Fix the stack overflow bugs in raising exceptions(DLL_PROCESS_DETACH processing for DllMain in ntoskrnl.c)
by Dmitry Timoshkov 12 Oct '08

12 Oct '08

"Anton Rudnev" <mibori(a)etersoft.ru> wrote: > --- a/dlls/ntoskrnl.exe/ntoskrnl.c > +++ b/dlls/ntoskrnl.exe/ntoskrnl.c > @@ -886,14 +886,20 @@ NTSTATUS WINAPI PsSetCreateProcessNotifyRoutine( PCREATE_PROCESS_NOTIFY_ROUTINE > BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) > { > LARGE_INTEGER count; > + static vectored_handler_added = NULL; > > switch(reason) > { > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls( inst ); > - RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); > + vectored_handler_added = RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); > KeQueryTickCount( &count ); /* initialize the global KeTickCount */ > break; > + case DLL_PROCESS_DETACH: > + if(vectored_handler_added){ > + RtlRemoveVectoredExceptionHandler(vectored_handler_added); > + vectored_handler_added = NULL; > + } > } > return TRUE; > } What you want is find out why RtlAddVectoredExceptionHandler fails for you, because it shouldn't fail normally. -- Dmitry.

2 2

Wineconf follow up: Wine Usage Data Collection
by Zachary Goldberg 12 Oct '08

12 Oct '08

Hello All, Just wanted to continue the thread from Wineconf about tracking usage data in Wine. We had discussed adding an opt-in system at first run where all invokations of Wine would send a token to WineHQ to track the number of times users run given applications to help direct development. Thoughts? --Zach

12 48

Sugared Wine
by Vincent Povirk 11 Oct '08

11 Oct '08

For those of you just tuning in, CodeWeavers has had me working on a project called Sugared Wine. The plan was that I would implement a taskbar (complete with start menu, window switcher, and system tray) in explorer for Wine's virtual desktop and fix some virtual desktop bugs. Jeremy White would package it for sugar, and the result would be a usable Wine activity. That didn't happen, but for my continued mental health I have to release something. On http://wiki.winehq.org/SugaredWine there is a link to a Wine activity (.xo file) and a git repository containing the source code I used to build it (which itself happens to contain a set of patches to wine). This is, to the best of my knowledge, a functional Wine activity that you can download and run on any computer that has sugar. It has a taskbar, and the start menu has shortcuts to some Wine programs. If you want to try the taskbar (it is nifty), apply all the patches except the last three or so (those are needed for the sugarizing) to Wine and start a virtual desktop. My plan remains to get this into Wine, perhaps before 1.2. Getting Wine to actually work in that environment was harder than anticipated, and taking a desktop that (in my opinion) is good for Wine generally and dropping it into sugar did not produce something that works well in sugar. I've listed the sugar problems I'm aware of on the wiki page. So if you care about the prospect of getting a taskbar into the Wine virtual desktop or of getting Wine into sugar, do take a look. Vincent Povirk

3 4

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests
by James Hawkins 11 Oct '08

11 Oct '08

On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > > [now with tests, fixed and reformatted as per James' suggestions] > > Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW > stubs and few tests for them. Required for MSN Messenger 7.0 > --- > dlls/advapi32/advapi32.spec | 4 +- > dlls/advapi32/cred.c | 160 +++++++++++++++++++++++++++++++++++++++++++ > dlls/advapi32/tests/cred.c | 45 ++++++++++++ > include/wincred.h | 39 +++++++++++ > 4 files changed, 246 insertions(+), 2 deletions(-) > + *Size = 0; + *Credentials = NULL; + if (!TargetInformation) What if Size or Credentials is NULL? You should add a test for that and handle it appropriately. If the tests crash, you should comment out the tests and note that there is no handling in Windows. -- James Hawkins

3 9

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel