- wine-devel - winehq.org

Re: [Resend] user32: Post the WM_KEY{DOWN|UP} message whenWM_IME_KEY{DOWN|UP} message is generated by IME.
by Dmitry Timoshkov 30 Apr '08

30 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > I have added the test code. Your test doesn't confirm that the message is posted and not sent. You need to use SendMessage and examine the resulting messages, then run the message loop and see what messages got posted. -- Dmitry.

1 0

Re: wined3d: Fix for buggy programs using ortho matrix with no z range
by Jens Albretsen 30 Apr '08

30 Apr '08

On Tuesday 29 April 2008 22:25:48 Stefan Dösinger wrote: > Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > > Changelog: > > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > > other word with no range, which does'nt make any sense but they do it > > anyway. > > I think a test case for this would be good. A quick one is Lego Island, just forget to put in the disc a there is black screen, with this patch is shows a message to put the cdrom in the drive. Is it something like this? create (1,1) rendertarget clear rendertarget with black setup ortho with no range draw something with white check rendertarget for any pixel drawn, if black test fails or what? -------------------------------------------------------

1 0

Re: [PATCH] usp10: Use passed hdc instead of cached one for ScriptTextOut with test to check
by Hans Leidekker 30 Apr '08

30 Apr '08

On Tuesday 29 April 2008 06:15:23 Guy Albertelli wrote: > Application does most of the Script... calls under one hdc then deletes it > prior to calling the ScriptTextOut with the original hdc. Out of curiosity, which app is that? What are the symptoms? I tested your patch on some of the apps I know that use usp10 (TomTom HOME, Firefox, PAF5) and didn't see any obvious regressions. > - if (!ExtTextOutW(get_cache_hdc(psc), x, y, fuOptions, lprc, pwGlyphs, cGlyphs, NULL)) > + if (!ExtTextOutW(hdc, x, y, fuOptions, lprc, pwGlyphs, cGlyphs, NULL)) You should also get rid of the calls to get_script_cache and un/select_cached_font; they are redundant now. -Hans

2 1

Abusing valgrind to find reference leaks
by Maarten Lankhorst 29 Apr '08

29 Apr '08

Hi all, I've managed to abuse valgrind to show backtraces of all places where an AddRef and Release is called when there is a memory, this is superior to wading through an endless pile of logs without even guarantee it will work. I thought I should share it for the following reasons: 1. Valgrind is an awesome tool 2. Reference leaks are usually impossible or very hard to find by using debug logs All I'm doing is leaking memory until the destructor is called, which gives quite useful results, I had to add a exit(1) after the leak occured because the samples get destroyed regardless when the interface controlling those samples is released. The log was created with: valgrind --trace-children=yes --leak-check=full --show-reachable=yes --leak-resolution=high -- wine quartz_test.exe.so filtergraph 2>&1 | tee valgrind.log And then I removed all the memory leaks and warnings not related to AddRef and Release. Ideally I could get it to automatically sort the outputted data based on the order of calling, but I'm not 100% sure how to do that yet. I could do 1,000,000 + GetTickCount(), but the results are usable now regardless. This was useful for me to get the backtraces of all _AddRef's and _Release's *ONLY* for the leaking interfaces, which saves a lot of time determining whether the specific interface is leaking and not, and when it starts leaking, and then determining who calls and where it is called, so I hope it is useful for you too! Cheers, Maarten.

1 0

Re: widl: callback, code, comm_status and in_line are attribute names, not keywords.
by Robert Shearman 29 Apr '08

29 Apr '08

Robert Shearman wrote: > --- > tools/widl/parser.l | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) Just to note, this patch depends on the patch series that I sent yesterday and that I'm about to resend now. -- Rob Shearman

1 0

re: 1.0 idea - ntdll - add a messagebox for missing dlls
by Dan Kegel 29 Apr '08

29 Apr '08

Hmm, maybe make explorer responsible for putting up the messagebox, and set up some IPC method (good lord, not COM, just some mailbox or something) for the loader to notify it...

6 26

Bad recommended package lists
by Francois Gouget 29 Apr '08

29 Apr '08

http://wiki.winehq.org/Recommended_Packages The Wiki's Recommended Packages list contains a lot of incorrect recommendations. I have already cleaned up the Debian section, but there seems to be a lot of copy/paste that spread the bad information to the RPM distros. So we'd need volunteers for pruning and updating these lists for Fedora and RHEL / WBEL. Here's a list of the suspicious or downright bad package recommendations I spotted: * audiofile-devel This is a library for accessing audio files. Wine does not use it. Maybe it was confused with AudioIO (which is not used on Linux anyway). * e2fsprogs-devel Why would Wine need ext2fs tools? * expat-devel We use libxml2, not expat. * glib2-devel That's not the glibc. That's a Gnome library which Wine never used. * isdn4k-utils-devel Maybe this is for libcapi20? * krb5-devel As far as I know we don't use Kerberos in Wine (or it's experimental code that is not enabled in the mainline). * libao-devel Wine does not use libao. Instead it has backends for most of the audio systems out there, although there's always a new kid on the block that's missing. * libmng-devel That's for MNG files, the moving version of PNG files. But what we use is libpng, not libmng. * libusb-devel Wine did use libusb at one point but now it's using libhal. * libogg-devel * libvorbis-devel We don't use those. * libxml, libxml-devel We use libxml2, not the deprecated libxml1. Now, maybe some distributions use 'libxml-devel' as the package name for libxml2 but this should be clarified, especially since libxml2-devel is mentionned too. * qt-devel That's QT, the toolkit used by KDE. Wine has never used it. * libXxf86dga-devel As far as I can tell we don't use libXxf86dga anymore. * opencdk-devel, libgpg-error-devel, libgcrypt-devel These are all related to GPG. We have nothing to do with GPG so we don't need them. * libXft-devel Wine uses FreeType and fontconfig but not libXft as far as I know. * gnutls-devel I believe we used GNU TLS at some point but now we use OpenSSL. * cyrus-sasl-devel Cyrus SASL also has to do with cryptography but as far as I can tell we never used it. * libieee1284-devel For parallel port access. Not used as far as I can tell. * libXmu-devel Contains 'miscellaneous utility convenience functions for X libraries to use'. I don't think Wine uses it. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service

3 3

Re: [resend] [Try 4] [1/2] cabinet.dll -> FDICopy: Test added
by James Hawkins 29 Apr '08

29 Apr '08

2008/4/29 Vitaly Perov <vitperov(a)etersoft.ru>: > jhawkins(a)codeweavers.com : cabinet: Revert "cabinet: Fix for FDICopy with an > empty cabinet file." > > Hi, > > > > The test was incorrect and failed on all platforms. Vitaly, please > > ask someone to test your patches on a real windows system in the > > future if you don't have access to one. > > I have tested this patch on Win98. It didn't failed. > But on WinXP it failed. > > The pach comes with this test fix a problem, so installation of certain > software (it includes one empty cab-file ) doesn't fail anymore. > I don't think, that this patch can cause any problem with a software developed > for WinXP. > > So, please look it trough once more. > Just look at the test results: http://test.winehq.org/data/200804252248/ It fails on every single platform, including win98. -- James Hawkins

1 0

Re: user32: Send WM_IME_SETCONTEXT message when the window is focusedor unfocused.
by Dmitry Timoshkov 29 Apr '08

29 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > --- a/dlls/user32/tests/msg.c > +++ b/dlls/user32/tests/msg.c > @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = > { HCBT_SETFOCUS, hook }, > { WM_KILLFOCUS, sent|parent }, > { WM_IME_SETCONTEXT, sent|wparam|optional|parent, 0 }, > - { WM_IME_SETCONTEXT, sent|wparam|optional, 1 }, > + { WM_IME_SETCONTEXT, sent|wparam|defwinproc|optional, 1 }, Did you test this change under Windows? At the time I've added this test it passed cleanly under up to date XP SP2. -- Dmitry.

2 3

Re: Alternative for isinf (fix for bug 12008) (version 4)
by Stefan Dösinger 29 Apr '08

29 Apr '08

1 0

Re: [PATCH 1/4] widl: Keep const attributes applied to pointers when writing out the type.
by Alexandre Julliard 29 Apr '08

29 Apr '08

Robert Shearman <rob(a)codeweavers.com> writes: > Use an attribute to store the const qualifier for the pointer and type. > > Allow multiple type-qualifiers to be applied to a type by adding a > declaration-specifier rule that encompasses type-qualifiers and types. > --- > tools/widl/header.c | 5 ++- > tools/widl/parser.y | 103 > ++++++++++++++++++++++++++++++++++++++++------- > tools/widl/widltypes.h | 2 +- > 3 files changed, 92 insertions(+), 18 deletions(-) > > This is a resend of a previous patch, with the bug that Alexandre > spotted fixed. The bug was that typedef'd types and arrays would no > longer have any const modifier applied to them. That works now, though there is still something not quite right: --- include/d3d10.h.old 2008-04-29 13:38:38.000000000 +0200 +++ include/d3d10.h 2008-04-29 13:39:08.000000000 +0200 @@ -3455,12 +3455,12 @@ virtual void STDMETHODCALLTYPE VSSetConstantBuffers( UINT StartSlot, UINT NumBuffers, - ID3D10Buffer **ppConstantBuffers) = 0; + ID3D10Buffer **const ppConstantBuffers) = 0; It should be "ID3D10Buffer * const *" instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: Post the WM_KEY{DOWN|UP} message when WM_IME_KEY{DOWN|UP}message is generated by IME.
by Dmitry Timoshkov 29 Apr '08

29 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > The PeekMessage, GetMessage CAN CATCH this WM_KEYDOWN message. > I think this problem don't need the test code. > This problem is very simple case and clearly. This really needs the tests. First to show that this change is really correct, second to prevent regressions in future when someone else will try to change it. -- Dmitry.

1 0

Re: 3/2 WineD3D: add D3DPRASTERCAPS_MULTISAMPLE_TOGGLE support
by Stefan Dösinger 29 Apr '08

29 Apr '08

Am Montag, 28. April 2008 22:08:28 schrieb Roderick Colenbrander: > Hi, > > Add a missing d3d9 capability. For now add it behind a dxVersion check. We > should get rid of those after Wine 1.0 but right now there is no filtering > code in d3d8, so don't risk any regressions now. IMHO adding a caps filter to dx8 is less risky than adding multisampling support, so I don't see a reason not to do that and avoid the dxVersion check

4 3

re: Mixed-mode assembly support in Mono
by Dan Kegel 28 Apr '08

28 Apr '08

Kornel wrote: > I have recently committed required changes to Mono SVN repository as r102052. > Now Mono has mixed-mode assembly support on Windows. Wow, congratulations! When will a windows installer be available for a version of mono with your changes included? It would make testing much easier. > These is no full MSVCRT support because that heavily depends > on the unmanaged API of .NET Framework but programs compiled using > Microsoft Visual C++ and not using MSVCRT should > be supported. Even exporting functions in managed DLLs is supported > that is supported by ildasm.exe and ilasm.exe as well. > > When the process is created using mono.exe there are some > limitations for executable assemblies but with a custom mscoree.dll > Mono has full support to create processes from managed executables. > > The attached mscoree.c is the source code for a custom mscoree.dll > that uses Mono for creating processes from executables. > I think that you should incorporate this into your mscoree.dll. We'll have a look, thanks. Do you happen to know of any real-world apps that would benefit? - Dan

2 1

Mixed-mode assembly support in Mono
by Kornél Pál 28 Apr '08

28 Apr '08

Hi, I have recently committed required changes to Mono SVN repository as r102052. Now Mono has mixed-mode assembly support on Windows. These is no full MSVCRT support because that heavily depends on the unmanaged API of .NET Framework but programs compiled using Microsoft Visual C++ and not using MSVCRT should be supported. Even exporting functions in managed DLLs is supported that is supported by ildasm.exe and ilasm.exe as well. When the process is created using mono.exe there are some limitations for executable assemblies but with a custom mscoree.dll Mono has full support to create processes from managed executables. The attached mscoree.c is the source code for a custom mscoree.dll that uses Mono for creating processes from executables. I think that you should incorporate this into your mscoree.dll. Also note that you should only provide not implemented stubs in your mscoree.dll and implement missing functionality in Mono's coree.c if required. mscoree.c and http://anonsvn.mono-project.com/viewcvs/trunk/mono/mono/metadata/coree.c contains some comments about managed module support in ntdll.dll and msvcrt.dll of XP and later. If someone volunteers this could be implemented in Wine as well. Kornél

1 0

Re: ws2_32: Use WSAWaitForMultipleEvents instead of WaitForSingleObject
by Dmitry Timoshkov 28 Apr '08

28 Apr '08

"Kai Blin" <kai.blin(a)gmail.com> wrote: > - HANDLE hEvent = INVALID_HANDLE_VALUE; > + WSAEVENT event_array[1]; Is that change only to avoid passing &hEvent to WSAWaitForMultipleEvents? -- Dmitry.

2 2

Re: [PATCH 2/7] widl: Keep const attributes applied to pointers when writing out the type.
by Alexandre Julliard 28 Apr '08

28 Apr '08

Robert Shearman <rob(a)codeweavers.com> writes: > Use an attribute to store the const qualifier for the pointer and type. > > Allow multiple type-qualifiers to be applied to a type by adding a > declaration-specifier rule that encompasses type-qualifiers and types. This seems to drop the const in some cases, for instance: --- include/propidl.h.old 2008-04-28 13:52:01.000000000 +0200 +++ include/propidl.h 2008-04-28 13:52:11.000000000 +0200 @@ -332,7 +332,7 @@ virtual HRESULT STDMETHODCALLTYPE WritePropertyNames( ULONG cpropid, const PROPID rgpropid[], - const LPOLESTR rglpwstrName[]) = 0; + LPOLESTR rglpwstrName[]) = 0; virtual HRESULT STDMETHODCALLTYPE DeletePropertyNames( ULONG cpropid, -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] advapi32: attempt to use UuidToStringA if UuidToStringW isnot available.
by Dmitry Timoshkov 28 Apr '08

28 Apr '08

"Lei Zhang" <thestig(a)google.com> wrote: > This adds more checks in CRYPT_CreateMachineGuid(), and attempt to use > UuidToStringA if UuidToStringW is not available. Instead of duplicating and complicating the code, IMO it would be more straightforward to use ansi APIs without trying unicode first. -- Dmitry.

2 1

Re: msvcrt: Remove two tests that fail on all platforms
by Eric Pouech 27 Apr '08

27 Apr '08

James Hawkins a écrit : > Hi, > > Changelog > * Remove two tests that fail on all platforms. > > dlls/msvcrt/tests/cpp.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > > ------------------------------------------------------------------------ > > the first one is actually bogus, I'll send a corrected test however, the second seems ok (except some space difference) can you post the failing test information ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: [PATCH 6/7] widl: Accept integer constant suffixes in the lexer.
by Dan Hipschman 27 Apr '08

27 Apr '08

On Sat, Apr 26, 2008 at 09:51:58AM +0100, Robert Shearman wrote: > +u_suffix (l|L) > +l_suffix (u|U) I'm guessing you meant for these to be the other way around.

2 1

Re: wined3d: Fix dead-loop condition with default setup.
by Vitaliy Margolen 27 Apr '08

27 Apr '08

Vitaliy Margolen wrote: > As discussed in bug 11584 this Preload is wrong and should be removed. > --- > dlls/wined3d/context.c | 7 ------- > 1 files changed, 0 insertions(+), 7 deletions(-) > > BTW this is still not enough to fix all the problems. There are few more preloads that make Psychonauts crash. So I think that whole idea of using preload in the context switch is not right. Or activating context in texture pre-loading is wrong. Can some one familiar with this code take a closer look? This is basic functionality that should be working in 1.0 Vitaliy.

3 2

Wine64?
by Erik de Castro Lopo 27 Apr '08

27 Apr '08

Hi all, I'm interested in the current state of work towards Wine64, ie running Win64 binaries on x86_64 Linux machines. My needs are actually really simple and hence may be a good base functionality to work towards. I just need to run Win64 binaries that read stdin, write stdout/stderr and do file I/O using the standard windows CreateFile/ReadFile/WriteFile/CloseHandle/ SetFilePointer etc functions. I have found and read this: http://wiki.winehq.org/Wine64 but some of that stuff seems rather out-of-date. When I configure with --enable-win64 it configures fine but then errors out in widl generated code because of things like this: #if !defined(__RPC_WIN32__) #error Currently only Wine and WIN32 are supported. #endif So, is anybody working on Wine64 stuff? Is there a Wine64 TODO list? Any way for me to get involved? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "If you have one apple and I have one apple, if we exchange, each will have one apple. If you have one idea and i have one idea, if we exchange them, each will have two ideas!" -- Attributed to George Bernard Shaw

4 3

Re: [dinput] initial support for BSD's usbhid joysticks
by Vitaliy Margolen 27 Apr '08

27 Apr '08

Christoph Frick wrote: > Add dinput support for BSD's usbhid joysticks > > + if (have_joy_devs == 0) { > + joy_devs = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct JoyDev)); > + } else { > + HeapReAlloc(GetProcessHeap(), 0, joy_devs, (1 + have_joy_devs) * sizeof(struct JoyDev)); > + } > + joy_devs[have_joy_devs++] = joydev; > + > + hid_dispose_report_desc(rdesc); > + close(fd); > + } > +} This is ugly! Curly brackets should go on the separate line. And I asked no tabs please! And again you copied all the code - I'm against this. All the duplicate code should go into the new joystick base class. No reason to rewrite code if it can be written right the first time around. Vitaliy.

1 0

Re: wine.inf.in: use lowercase for Microsoft Video 1
by Dmitry Timoshkov 27 Apr '08

27 Apr '08

"Jeff Zaroyko" <jeffzaroyko(a)gmail.com> wrote: > system.ini, drivers32,,"vidc.MRLE=msrle32.dll" > -system.ini, drivers32,,"vidc.MSVC=msvidc32.dll" > +system.ini, drivers32,,"vidc.msvc=msvidc32.dll" > system.ini, drivers32,,"vidc.CVID=iccvid.dll" > system.ini, drivers32,,"; vidc.IV50=ir50_32.dll" > system.ini, drivers32,,"; vidc.IV31=ir32_32.dll" MRLE and CVID are also in lower case in XP, so they should be fixed too (as well as removed trailing spaces in many entries in [SystemIni] section). -- Dmitry.

2 1

Side affects from running wineprefixcreate
by Vitaliy Margolen 27 Apr '08

27 Apr '08

So for one notable problems is some file types being reset by Wine. Looks like it comes from dlls/mshtml/mshtml.inf. At a minimum all the created registry entries should not overwrite already existing ones. Vitaliy.

2 2

Re: [dinput] initial support for BSD's usbhid joysticks
by Vitaliy Margolen 26 Apr '08

26 Apr '08

Christoph Frick wrote: > From 7618ceb6941c0dffac9c48c1fa1aeb7e821673a2 Mon Sep 17 00:00:00 2001 > From: Christoph Frick <frick(a)sc-networks.com> > Date: Sat, 26 Apr 2008 02:50:01 +0200 > Subject: [PATCH] Initial support for BSD's usbhid joysticks > > Please consider this a tracer bullet. I had only time to test it with a > 4-axis/4-button wheel in LFS in FreeBSD 7.0. I will take further tests using a > flight stick and other games soon. But for now i just want to see, what others > have to say about it. > --- Please use 4 spaces indentation, no tabs. > + snprintf(buf, MAX_PATH, FMT_UHIDDEVS, i); > + buf[MAX_PATH - 1] = 0; snprintf always writes terminating '\0' character at the end of the string. You don't need to explicitly do that yourself. > + if ((fd = open(buf, O_RDWR | O_NDELAY, 0)) == -1) { > + TRACE("Unable to open %s read/write: %s\n", buf, strerror(errno)); > + continue; > + } Do you really have to open it read/write? Shouldn't read only be enough for not FF joystick? The only way I can think of to remove code duplication is to create base joystick class. There were no reason for that with only 2 joystick drivers. With third one should really do it. Vitaliy.

3 4

Re: [dinput] move the common joystick_map_.* methods from joystick_linuxinput.c into device.c
by Vitaliy Margolen 26 Apr '08

26 Apr '08

Christoph Frick wrote: > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index 5f927d0..baca0b3 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -1400,3 +1400,54 @@ HRESULT WINAPI IDirectInputDevice8WImpl_GetImageInfo(LPDIRECTINPUTDEVICE8W iface > Please don't. Device is common for everything (keyboard, mouse, joysticks). Joystick specific code should not be there. Vitaliy.

2 1

Re: [Try 3] [1/2] cabinet.dll -> FDICopy: Test added
by James Hawkins 26 Apr '08

26 Apr '08

2008/4/5 Vitaly Perov <vitperov(a)etersoft.ru>: > This test checks if function FDICopy() of cabinet.dll correctly works with an > empty cabinet file (It's correct cab-file, but it has no files and folders > inside). > In this case Windows return TRUE, but WINE return FALSE. So the installation > of certain software finishes with an error in WINE > > Changelog: > - Added a test for cabinet.dll FDICopy function. This test checks if it > works correctly with an empty cab-files > --- dlls/cabinet/tests/fdi.c 6 Feb 2008 13:29:17 -0000 1.3 +++ dlls/cabinet/tests/fdi.c 5 Apr 2008 15:16:55 -0000 @@ -20,6 +20,7 @@ #include <stdio.h> #include <windows.h> +#include <assert.h> #include "fci.h" #include "fdi.h" #include "wine/test.h" You forgot to remove this. -- James Hawkins

2 1

[GSoC][RFC] Case Insensitive Filesystem
by Marc Andre Tanner 26 Apr '08

26 Apr '08

Hi, During the last week i have been playing around with the idea of writing a case insensitive fuse filesystem and i am know at the point were i can demonstrate a proof of concept implementation. And yes i have seen that there is already someone else interested in doing this but i thought it was fun anyways. The filesystem converts every path to lower case before further operations take place. On file creation the original filename is stored in an extended attribute and later returned upon request. This means you will have a directory on a regular POSIX filesystem with all filenames in lower case, this directory can then be mounted in case insensitive fashion. In order to compile the code you will need the fuse and libattr[1] development files. Furthermore you will have to make sure that the underlying filesystem supports extended attributes (for example for ext{2,3} you need a kernel with CONFIG_EXT{2,3}_FS_XATTR enabled). You probably also want to mount the underlying filesystem with the user_xattr option which allows non root users to create extended attributes. So fetch the code from the url below, extract the archive and type make. This should generate a binary named ciopfs (which stands for Case Insenstive On Purpose File System, alternative naming suggestions are welcome ;). http://www.brain-dump.org/projects/ciopfs/ciopfs-25.03.2008.tar.gz Mounting the file system is straight forward, see `ciopfs -h` for further options. But be carefull i haven't yet done any serious testing, so only use it with unimportant data [insert standard warning about possible data loss here]. ciopfs /path/to/my/directory /path/to/my/mountpoint As i said before the current implementation is just a proof of concept. That's why it currently only supports ascii filenames, or whatever tolower(3) can cope with. This brings us to another problem[2,3], in certain languages there isn't a direct mapping between upper and lower case characters and case insensitivity in filesystem is generally a bad thing. Any comments are appreciated. Regards, Marc [1] http://acl.bestbits.at/download.html#Attr [2] http://www.somethinkodd.com/oddthinking/2005/10/25/the-world-of-upper-lower… [3] http://drewthaler.blogspot.com/2007/12/case-against-insensitivity.html -- Marc Andre Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

6 10

Re: ddraw: Remove a test that fails in VMs
by Reece Dunn 26 Apr '08

26 Apr '08

2008/4/26 James Hawkins <jhawkins(a)codeweavers.com>: > Hi, > > The tests aren't run anyway in this case. > > Changelog: > * Remove a test that fails in VMs. ... > hr = IDirect3D7_CreateDevice(Direct3D, &IID_IDirect3DRefDevice, Surface, &Direct3DDevice); > } > } > - ok(hr == D3D_OK, "IDirect3D7_CreateDevice failed with %08x\n", hr); Wouldn't it be better to move the ok line to directly after the IDirect3D7_CreateDevice call? That way, on VM machines the test will not get run and on non-VM machines it will, as it is a valid test in that case. - Reece

2 2

Re: cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."
by Reece Dunn 26 Apr '08

26 Apr '08

2008/4/26 James Hawkins <jhawkins(a)codeweavers.com>: > Hi, > > The test was incorrect and failed on all platforms. Vitaly, please > ask someone to test your patches on a real windows system in the > future if you don't have access to one. Wouldn't it be better to actually fix the test case than revert it all together? Just simply change line 630: - ok(ret, "Expected FDICopy to succeed\n"); + ok(!ret, "Expected FDICopy to fail\n"); and remove the todo_wine. Adding a GetLastError check would be good as well. - Reece

2 2

download.template: Update Mandriva download info (try 2)
by Austin English 26 Apr '08

26 Apr '08

Any reason this patch wasn't applied? http://www.winehq.org/pipermail/wine-patches/2008-April/053911.html

1 0

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.
by Aric Stewart 25 Apr '08

25 Apr '08

Comming in a bit late on this one, (missed the patch submission) I do not think this is correct as far as i know hCompStr should never be NULL. Much of our code depends on that not being NULL. I would recommend using ImeCreateBlankCompStr instead. (something like below) diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c index f50549f..8fa6f6f 100644 --- a/dlls/winex11.drv/ime.c +++ b/dlls/winex11.drv/ime.c @@ -778,7 +778,7 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwInd if (lpIMC->hCompStr) { ImmDestroyIMCC(lpIMC->hCompStr); - lpIMC->hCompStr = NULL; + lpIMC->hCompStr = ImeCreateBlankCompStr(); } myPrivate = (LPIMEPRIVATE)ImmLockIMCC(lpIMC->hPrivate); -aric Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 4f2330ac0c951ec5fb05e2fb152c59723c3af336 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f2330ac0c951ec5fb05e2fb1… > > Author: Kusanagi Kouichi <slash(a)ma.neweb.ne.jp> > Date: Fri Apr 25 12:08:24 2008 +0900 > > winex11: Destroy the handle to the composition string after it is cancelled. > > --- > > dlls/winex11.drv/ime.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c > index 6614213..f50549f 100644 > --- a/dlls/winex11.drv/ime.c > +++ b/dlls/winex11.drv/ime.c > @@ -775,6 +775,12 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwIndex, DWORD dwValue) > > X11DRV_ForceXIMReset(lpIMC->hWnd); > > + if (lpIMC->hCompStr) > + { > + ImmDestroyIMCC(lpIMC->hCompStr); > + lpIMC->hCompStr = NULL; > + } > + > myPrivate = (LPIMEPRIVATE)ImmLockIMCC(lpIMC->hPrivate); > if (myPrivate->bInComposition) > { > > >

2 3

Wine 1.0 release plan update
by Dan Kegel 25 Apr '08

25 Apr '08

Alexandre's taking a vacation in May, and the schedule is bending slightly to fit. We're also not promising a particular release date, though the previously predicted date is still as likely as it was before. http://wiki.winehq.org/WineReleasePlan now says: --- snip --- * 0.9.61 - 2 May 2008 - start of code freeze for 1.0 * 1.0.0-rc1 - 9 May 2008 (early because of Alexandre's vacation) * No release 16 May (Alexandre on vacation) * 1.0.0-rc2 - 23 May (early because of Alexandre's vacation) The exact date of the 1.0.0 release can't be predicted; we'll keep on doing release candidates until we're comfortable with it. We expect it will be in June. --- snip ---

1 0

Re: ddraw: Fix tests that fail with the reference rasterizer
by Stefan Dösinger 25 Apr '08

25 Apr '08

Am Freitag, 25. April 2008 05:38:40 schrieb James Hawkins: > Hi, > > Changelog: > * Fix tests that fail with the reference rasterizer. > if (SUCCEEDED(IDirectDrawSurface7_AddAttachedSurface(surface1, surface4))) > refrast = TRUE; Do you take care of detaching the surface again? Did you try checking the DirectDraw description or GUID? Maybe there's a better way to detet the refrast, if you want the teest to succeeed in a VM

2 1

Re: d3d8: Fix a few test failures in win2k3
by Stefan Dösinger 25 Apr '08

25 Apr '08

Am Freitag, 25. April 2008 03:36:04 schrieb James Hawkins: > Hi, > > Changelog: > * Fix a few test failures in win2k3. > > dlls/d3d8/tests/device.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) Looks ok to me Somewhen we may want to move all this multiple times copypasted device init code into a shared function :-/

1 0

Safedisc for 1.0+ ?
by TheBlunderbuss 25 Apr '08

25 Apr '08

3 3

ddraw: ComputeSphereVisibility
by David Adam 25 Apr '08

25 Apr '08

Hello, I am trying to debug the demo of The Sting. Now, the main is that the screen is almost black. It is surely related to the following FIXME: fixme:d3d7:IDirect3DDeviceImpl_7_ComputeSphereVisibility Unfortunately, I did not find any informations about this function. Does anyone know what this function does, ( and better knows a possible implementation)? Thanks, David Adam

2 1

Re: [PATCH] user32: edit controls should ignore WM_KEYDOWN on control + enter.
by Vitaliy Margolen 25 Apr '08

25 Apr '08

Lei Zhang wrote: > On Thu, Apr 24, 2008 at 10:22 PM, Lei Zhang <thestig(a)google.com> wrote: >> Hi, >> >> This should be the last bit in getting control + enter working in >> multiline edit controls. I attempted to write a test for this using >> SendInput() or SetKeyState() + SendMessage(), but I couldn't get seem >> to simulate holding down the control key. >> > Should work. You can also look at keybd_event() how it does it. It's pretty much a wrapper around SendInput(). All you'll need is keybd_event(VK_CONTROL, 0, 0, 0); to press it. And keybd_event(VK_CONTROL, 0, KEYEVENTF_KEYUP, 0); to release it. Vitaliy.

2 1

Re: [2/2] [try2] user32:mdi.c Fix creating MDI child window according with test. [resend]
by Alexandre Julliard 25 Apr '08

25 Apr '08

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Uses SWP_NOZORDER according with Dmitry's comment. > > Changelog: > Fix creating MDI child window according with test. It doesn't work: msg.c:3065: Test failed: Create visible MDI child window: the msg sequence is not complete: expected 0000 - actual 0046 msg.c:3120: Test failed: ShowWindow(SW_MAXIMIZE):invisible MDI child: the msg 0x0047 was expected, but got msg 0x0046 instead msg.c:3120: Test failed: ShowWindow(SW_MAXIMIZE):invisible MDI child: the msg 0x0005 was expected, but got msg 0x0083 instead msg.c:3120: Test failed: ShowWindow(SW_MAXIMIZE):invisible MDI child: the msg 0x0046 was expected, but got msg 0x0047 instead msg.c:3120: Test failed: ShowWindow(SW_MAXIMIZE):invisible MDI child: the msg 0x0083 was expected, but got msg 0x0047 instead msg.c:3120: Test failed: ShowWindow(SW_MAXIMIZE):invisible MDI child: the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:3120: Test failed: ShowWindow(SW_MAXIMIZE):invisible MDI child: the msg sequence is not complete: expected 0000 - actual 0046 msg.c:3345: Test failed: ShowWindow(SW_MAXIMIZE):invisible maximized MDI child: the msg 0x0047 was expected, but got msg 0x0046 instead msg.c:3345: Test failed: ShowWindow(SW_MAXIMIZE):invisible maximized MDI child: the msg sequence is not complete: expected 0000 - actual 0083 msg.c:3484: Test failed: Create MDI child window with invisible parent: the msg sequence is not complete: expected 0000 - actual 0046 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: John Klehm : winex11: Add support for IsXExtensionPointer tablet devices.
by Michael Stefaniuc 25 Apr '08

25 Apr '08

This patch break compilation on my RHEL5 box with xorg-x11-proto-devel-7.1-9.fc6 which misses the IsXExtensionPointer define. bye michael Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 2c26ea609d6b2b8a25be20984c0014ceb202466a > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2c26ea609d6b2b8a25be20984… > > Author: John Klehm <xixsimplicityxix(a)gmail.com> > Date: Tue Apr 22 20:11:28 2008 -0500 > > winex11: Add support for IsXExtensionPointer tablet devices. > > --- > > dlls/winex11.drv/wintab.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/winex11.drv/wintab.c b/dlls/winex11.drv/wintab.c > index 37596ba..b086e44 100644 > --- a/dlls/winex11.drv/wintab.c > +++ b/dlls/winex11.drv/wintab.c > @@ -530,14 +530,15 @@ void X11DRV_LoadTabletInfo(HWND hwnddefault) > devices[loop].use == IsXKeyboard ? "IsXKeyboard" : > devices[loop].use == IsXPointer ? "IsXPointer" : > devices[loop].use == IsXExtensionDevice ? "IsXExtensionDevice" : > + devices[loop].use == IsXExtensionPointer ? "IsXExtensionPointer" : > "Unknown" > ); > > - if (devices[loop].use == IsXExtensionDevice) > + if ((devices[loop].use == IsXExtensionDevice) || (devices[loop].use == IsXExtensionPointer)) > { > LPWTI_CURSORS_INFO cursor; > > - TRACE("Is Extension Device\n"); > + TRACE("Is XExtension%s\n", (devices[loop].use == IsXExtensionDevice)? "Device":"Pointer"); > cursor_target++; > target = &devices[loop]; > cursor = &gSysCursor[cursor_target]; > > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Otto-Hahn-Strasse 20, 85609 Dornach bei Muenchen Handelsregister: Amtsgericht Muenchen HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

1 0

Re: ntoskrnl.exe: Change calling conventions [try 2]
by Alexandre Julliard 25 Apr '08

25 Apr '08

Alexander Morozov <amorozov(a)etersoft.ru> writes: > Changelog: > ntoskrnl.exe: Change calling conventions for InterlockedExchange, > InterlockedCompareExchange, InterlockedDecrement and InterlockedIncrement > > --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec > +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec > @@ -28,11 +28,11 @@ > @ stub Exfi386InterlockedExchangeUlong > @ stub Exfi386InterlockedIncrementLong > @ stub HalExamineMBR > -@ stdcall InterlockedCompareExchange(ptr long long) kernel32.InterlockedCompareExchange > -@ stdcall InterlockedDecrement(ptr) kernel32.InterlockedDecrement > -@ stdcall InterlockedExchange(ptr long) kernel32.InterlockedExchange > +@ stdcall -norelay InterlockedCompareExchange(ptr long long) NTOSKRNL_InterlockedCompareExchange > +@ stdcall -norelay InterlockedDecrement(ptr) NTOSKRNL_InterlockedDecrement > +@ stdcall -norelay InterlockedExchange(ptr long) NTOSKRNL_InterlockedExchange > @ stdcall InterlockedExchangeAdd(ptr long ) kernel32.InterlockedExchangeAdd > -@ stdcall InterlockedIncrement(ptr) kernel32.InterlockedIncrement > +@ stdcall -norelay InterlockedIncrement(ptr) NTOSKRNL_InterlockedIncrement Why didn't you fix InterlockedExchangeAdd too? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [Resend 2/5] imm32: Add the header for private imm32 function.
by Alexandre Julliard 25 Apr '08

25 Apr '08

ByeongSik Jeon <bsjeon(a)hanmail.net> writes: > Unknown function in the SDK/DDK's header. > --- > include/wine/imm_private.h | 35 +++++++++++++++++++++++++++++++++++ You don't want to add a new header for that, especially not a global one. The function is exported on Windows too, so it's OK to declare it in the DDK header. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32 : Temporarily disable test for _WIN64.
by Dmitry Timoshkov 25 Apr '08

25 Apr '08

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > The file dlls/user32/tests/edit.c currently doesn't compile when > configured with --enable-win64 because GWL_WNDPROC (in include/winuser.h) > is not defined when _WIN64 is defined. Then you need to fix the test instead of disabling it. -- Dmitry.

4 8

Re: [PATCH] advapi32: add more checks in CRYPT_CreateMachineGuid.
by Dmitry Timoshkov 25 Apr '08

25 Apr '08

"Lei Zhang" <thestig(a)google.com> wrote: > I'm getting a crash in CRYPT_CreateMachineGuid() with native > rpcrt4.dll. This adds some checks to work around it. I assume that "native" == "win9x" in this case. > pRpcStringFree = GetProcAddress(lib, "RpcStringFreeW"); > + if (!pUuidCreate || !pUuidToString || !pRpcStringFree) goto CreateMachineGuidCleaup; It would be better to use A versions of APIs then instead of failing, -- Dmitry.

2 1

"make test" - only four tests failing!
by Dan Kegel 25 Apr '08

25 Apr '08

"make test" is pretty darn close to passing; only four tests left to fix. (Oddly, different sets fail depending on display mode.) Details at the end of http://bugs.winehq.org/show_bug.cgi?id=9916 Let's get these fixed before code freeze!

2 1

Re: Add an include/config.h variable WINE_IS_WIN64 which is 1 whenconfigured with --enable-win64 and 0 otherwise.
by Dmitry Timoshkov 25 Apr '08

25 Apr '08

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > Add an include/config.h variable WINE_IS_WIN64 which is 1 whenconfigured with --enable-win64 and 0 otherwise. It would be helpful to at least provide an explanation why yo need this, and why _WIN64 macro is not enough. -- Dmitry.

2 1

Re: ntdll : Do not error out on AMD-64 architecture when compiling win64.
by Dmitry Timoshkov 25 Apr '08

25 Apr '08

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > +#if WINE_IS_WIN64 > + if (nt->FileHeader.Machine == IMAGE_FILE_MACHINE_AMD64) > + MESSAGE("Support for AMD-64 architecture in progress but not yet working\n"); > + else > +#endif What's the point of this? -- Dmitry.

2 1

Re: shel32/tests : Use LOWORD to extract rc from pointer.
by Dmitry Timoshkov 25 Apr '08

25 Apr '08

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > - rc=(int)ShellExecute(NULL, operation, file, parameters, directory, > - SW_SHOWNORMAL); > + rc=LOWORD(ShellExecute(NULL, operation, file, parameters, directory, > + SW_SHOWNORMAL)); > > if (rc > 32) > { > @@ -167,7 +167,7 @@ static int shell_execute_ex(DWORD mask, LPCSTR operation, LPCSTR file, > DeleteFile(child_file); > SetLastError(0xcafebabe); > success=ShellExecuteEx(&sei); > - rc=(int)sei.hInstApp; > + rc=LOWORD(sei.hInstApp); > ok((success && rc > 32) || (!success && rc <= 32), > "%s rc=%d and hInstApp=%d is not allowed\n", shell_call, success, rc); > > @@ -836,24 +836,24 @@ static void test_find_executable(void) > /* Don't test FindExecutable(..., NULL), it always crashes */ > > strcpy(command, "your word"); > - rc=(int)FindExecutableA(NULL, NULL, command); > + rc=LOWORD(FindExecutableA(NULL, NULL, command)); > ok(rc == SE_ERR_FNF || rc > 32 /* nt4 */, "FindExecutable(NULL) returned %d\n", rc); You need to change the type of rc to HINSTANCE and fix the comparisons instead. What happens if the returned HINSTANCE has a value <= 32 in its low word? -- Dmitry.

1 0

Re: dinput: Limit number of supported axis and buttons [try 2]
by Christoph Frick 25 Apr '08

25 Apr '08

On Thu, Apr 24, 2008 at 09:04:11AM -0600, Vitaliy Margolen wrote: ok, don't beat me on this one (i guess i could have asked this also for try one): > + FIXME("Can't support %d axes. Clamping down to 16\n", newDevice->axes); > ... > + WARN("Can't support %d buttons. Clamping down to 128\n", newDevice->buttons); why is axes a FIXME and buttons a WARN? -- cu

2 1

Re: dnghelp : Fix pointer cast.
by Erik de Castro Lopo 25 Apr '08

25 Apr '08

Erik de Castro Lopo wrote: > > Make the pointer cast safe for Wine64. Please disregard this one as there is a better patch on the way. Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "Within C++, there is a much smaller and cleaner language struggling to get out." -- Bjarne Stroustrup

1 0

Re: [PATCH 06/12] widl: Create a statement object for import statements.
by Alexandre Julliard 24 Apr '08

24 Apr '08

Robert Shearman <rob(a)codeweavers.com> writes: > Move the writing of include directives into the generated header into > header.c. This one doesn't work right, it doesn't output the #include statements so the resulting .h files don't compile. -- Alexandre Julliard julliard(a)winehq.org

1 0

Call for testers
by Eric Pouech 24 Apr '08

24 Apr '08

Has you may have seen, a new rendering interface is now available for Winhelp It should be better (with the last row of patches) than the old one, but still not perfect And likely not bug free, hence the call for testers I'm waiting for some real feedback from real users about reading your old .hlp files The new rendering is turned on by setting the env variable WINHELP_RICHEDIT to 1 A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: dinput: Limit number of supported axis and buttons
by Christoph Frick 24 Apr '08

24 Apr '08

On Thu, Apr 24, 2008 at 08:06:07AM -0600, Vitaliy Margolen wrote: > + FIXME("Can't support %d axis. Clamping down to 16\n", newDevice->axes); FIXME("Can't support %d axes. Clamping down to 16\n", newDevice->axes); -- cu

2 1

Re: mshtml #5: Added more IDispatchEx tests.
by Alexandre Julliard 24 Apr '08

24 Apr '08

Jacek Caban <jacek(a)codeweavers.com> writes: > dlls/mshtml/tests/dom.c | 56 > +++++++++++++++++++++++++++++++---------------- > 1 files changed, 37 insertions(+), 19 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so dom.c && touch dom.ok dom.c:1381: Test failed: GetTypeInfo failed: 8002802b dom.c:1394: Test failed: GetTypeInfo failed: 8002802b make[2]: *** [dom.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/7] D3D9: Make the offscreen format test a bit more tolerant
by H. Verbeet 24 Apr '08

24 Apr '08

2008/4/24 Stefan Dösinger <stefan(a)codeweavers.com>: > FWIW, for my texop test I wrote a function to do this in a generic way. I'll probably submit that in the next few days.

1 0

Re: [3/4] user32: Set the vkey value to VK_PROCESSKEY when IME process key.
by Aric Stewart 24 Apr '08

24 Apr '08

Thank you for these investigations This is really nice. I support those patches. I just wanted to also communicate a bit of additional information from my investigations just in case someone asks. I placed hooks on both WH_KEYBOARD_LL and WH_KEYBOARD. Even when the IME is active both of those hooks showed the VKEY of the actual keystroke. This showed me that all of this processing happened after process_keyboard_message. great work and thanks, -aric ByeongSik Jeon wrote: > When the MS Windows set the vkey value(MSG.wParam) to VK_PROCESSKEY? > > I have tested following code: > ---------------------------- > while ( GetMessage(&msg, 0, 0, 0) ) { > if ( msg.message == WM_KEYDOWN ) > printf("OLD: %x %x %x\n", msg.message, msg.wParam, msg.lParam); > TranslateMessage( &msg ); > if ( msg.message == WM_KEYDOWN ) > printf("NEW: %x %x %x\n", msg.message, msg.wParam, msg.lParam); > DispatchMessage( &msg ); > } > ----------------------------- > The result is: > ----------------------------- > OLD: 100 e5 130001 > NEW: 100 e5 130001 > OLD: 100 e5 250001 > NEW: 100 e5 250001 > OLD: 100 e5 130001 > NEW: 100 e5 130001 > ----------------------------- > e5 is VK_PROCESSKEY. > Before GetMessage, PeekMessage return, msg.wPram ahs seted to VK_PROCESSKEY. > > --- > dlls/user32/message.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > > ------------------------------------------------------------------------ > >

1 0

Re: imm32: If ImmNotifyIME fails, ImmSetOpenStatus should also fail.
by ByeongSik Jeon 24 Apr '08

24 Apr '08

Kusanagi Kouichi wrote: > if (!fOpen != !data->IMC.fOpen) > { > + if (!ImmNotifyIME( hIMC, NI_CONTEXTUPDATED, 0, IMC_SETOPENSTATUS)) > + return FALSE; > data->IMC.fOpen = fOpen; > - ImmNotifyIME( hIMC, NI_CONTEXTUPDATED, 0, IMC_SETOPENSTATUS); > ImmInternalSendIMENotify(data, IMN_SETSENTENCEMODE, 0); Hi, MS Windows's native imm32.dll return TRUE although NotifyIME return FALSE. I have tested it with the DDK's Japanese FakeIME.

1 0

xfs getting case-insensitive filesystem support...
by Dan Kegel 24 Apr '08

24 Apr '08

Hrm. This is interesting: http://lwn.net/Articles/278961/ I wonder if Wine could run faster if it could delegate the case-insensitvity to the filesystem...

4 3

1.0 idea - ntdll - add a messagebox for missing dlls
by Steven Edwards 24 Apr '08

24 Apr '08

Hi, My hope that was for Wine 1.0 we could add error handling for missing dlls and functions that made sense to the user rather than just silent failed or spewed messages to the console. If you have an application that depends on a dll such as OUTLOOK.EXE depending on OUTLIB.DLL you will get a message like this: err:module:import_dll Library OUTLLIB.dll (which is needed by L"Z:\\home\\sedwards\\.wine\\drive_c\\Program Files\\Microsoft Office\\OFFICE11\\OUTLOOK.EXE") not found err:module:LdrInitializeThunk Main exe initialization for L"Z:\\home\\sedwards\\.wine\\drive_c\\Program Files\\Microsoft Office\\OFFICE11\\OUTLOOK.EXE" failed, status c0000135 So instead how about throwing a nice message box? I started working on this but don't quite know how to properly pass the information to the MessageBoxW or maybe fill in the MessageBoxIndirect structure to display the error in a human readable format. I just don't really know. Of course once its done this would need to be broken out in to a helper function, its just a proof of concept.... Anyone want to help? -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

re: no test structure in place for wine programs
by Dan Kegel 23 Apr '08

23 Apr '08

Darren wrote: > Should I try to take the dll test structure (mainly just the > dlls/Maketest.rules.in file) and port this into the programs area? > > or is that overboard for that area? It's something we need eventually, but for now it would probably be enough to just attach a standalone test that invoked msiexec.exe and printed out PASS or FAIL to http://bugs.winehq.org/show_bug.cgi?id=9628 It's not worth the effort to create the generic app test framework inside the wine tree at the moment.

2 1

Re: Fix "warning: cast from pointer to integer of different size"
by Dmitry Timoshkov 23 Apr '08

23 Apr '08

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > /* get pointer to object containing list element */ > #define LIST_ENTRY(elem, type, field) \ > - ((type *)((char *)(elem) - (unsigned int)(&((type *)0)->field))) > + ((type *)((char *)(elem) - (unsigned long)(&((type *)0)->field))) It should be replaced with FIELD_OFFSET instead. -- Dmitry.

4 6

Re: Add implemantation of property "Name" (IHTMLWindow2)
by Jacek Caban 23 Apr '08

23 Apr '08

Ivan Sinitsin wrote: > This patch add implementation of HTMLWindow2_put_name, HTMLWindow2_get_name in > module htmlwindow.c (mshtml.dll) > > Changelog: > Add implementation of HTMLWindow2_put_name, HTMLWindow2_get_name > > > > @@ -289,15 +289,43 @@ static HRESULT WINAPI HTMLWindow2_get_na > static HRESULT WINAPI HTMLWindow2_put_name(IHTMLWindow2 *iface, BSTR v) > { > HTMLWindow *This = HTMLWINDOW2_THIS(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(v)); > - return E_NOTIMPL; > + nsAString aName; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + > + nsAString_Init(&aName, v); > + nsres = nsIDOMWindow_SetName(This->nswindow, &aName); > + if (NS_FAILED(nsres)) { > + TRACE("Failed nsIDOMWindow_SetName %08x \n",nsres); > + return nsres; You shouldn't mix nsresult with HRESULT. Also you leak aName here. SetName should never return failure, so printinf ERR and returning S_OK is fine here. > + } > + nsAString_Finish(&aName); > + return S_OK; > } > > static HRESULT WINAPI HTMLWindow2_get_name(IHTMLWindow2 *iface, BSTR *p) > { > HTMLWindow *This = HTMLWINDOW2_THIS(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + nsAString aName; > + nsresult nsres; > + TRACE("(%p)->(%p)\n", This, p); > + > + nsAString_Init(&aName, NULL); > + nsres = nsIDOMWindow_GetName(This->nswindow, &aName); > + if (NS_FAILED(nsres)) { > + TRACE("Failed nsIDOMWindow_GetName %08x \n",nsres); > + return nsres; Same as above. > + } > + > + nsres = nsAString_GetData(&aName, p); You can't do this, p is BSTR and must be allocated with SysAllocString. Look at other functions how to implement it. > + if (NS_FAILED(nsres)) { > + TRACE("Failed nsAString_GetData %08x \n",nsres); > + return nsres; > + } > + nsAString_Finish(&aName); > + > + return S_OK; > } Jacek

1 0

no test structure in place for wine programs
by Darragh Bailey 23 Apr '08

23 Apr '08

I'm been looking at bug 9628 (and duplicate 12222) whenever I get the time to work on wine these days. I've gone through various tests, enough to determine that msiexec on Windows must use some custom command line parsing in order for it to work for the cases listed in those bugs given that the behaviour is replicated by the standard command line API's in windows. So I've got to the stage where I believe the correct fix is to put in some custom handling to make wine's msiexec match the behaviour of windows version. So far so good. At this point I expect that there should be some test cases added since this functionality wouldn't appear frequently enough in most install cases for any future breaks to be picked up if future changes are made. So I expect to try and add some test cases, when I notice there is no test structure to test any of the exe's built by wine. Bit of a problem there... I'm assuming that the original assumption was that the programs just act as entry points to the dll functionality, so there shouldn't be any need to add unit tests for the programs. They will either work correctly once the dll's function, or break really, really noticably. Next step is the question? Should I try to take the dll test structure (mainly just the dlls/Maketest.rules.in file) and port this into the programs area? or is that overboard for that area? -- Darragh "Nothing is foolproof to a sufficiently talented fool."

1 0

Fwd: SOC 2008 Projects Announced
by Gal Topper 23 Apr '08

23 Apr '08

> Could the students come forward and say something about themself? Hello everyone. My name is Gal Topper and my goal this summer will be to implement PrintDlgEx* in Wine, so that we'll have support for the newer and more flexible print dialog that was introduced in Windows NT. I am a third year computer science student in York University in Toronto, Canada, and lucky for me, my exams are over! So for now, I can enjoy both the project and the spring. :) I'm excited about this project and plan to keep you all up-to-date when things start moving. :) Cheers, Gal

1 0

MSIME support causing slow setup until explorer.exe paused?
by Dan Kegel 23 Apr '08

23 Apr '08

I tried installing StarUML (after doing winetricks vcrun6 msxml3, as required), and the setup crept along very slowly... so I got curious and ran top. Most of the cpu time was being used by Explorer and wineserver, and interestingly, if I suspended Explorer by doing strace -p <pid of explorer> and then pressing ^S, the install ran awful darn fast. So, what was explorer doing that was slowing things down so much? writev(3, [{"l\0\0\0\30\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 64}, {"M\0S\0I\0M\0E\0S\0e\0r\0v\0i\0c\0e\0", 24}], 2) = 88 ... writev(3, [{"l\0\0\0*\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 64}, {"M\0S\0I\0M\0E\0R\0e\0c\0o\0n\0v\0e\0r\0t\0O\0p\0"..., 42}], 2) = 106 ... writev(3, [{"l\0\0\0&\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 64}, {"M\0S\0I\0M\0E\0M\0o\0u\0s\0e\0O\0p\0e\0r\0a\0t\0"..., 38}], 2) = 102 ... writev(3, [{"l\0\0\0*\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 64}, {"M\0S\0I\0M\0E\0R\0e\0c\0o\0n\0v\0e\0r\0t\0R\0e\0"..., 42}], 2) = 106 ... This persisted in the app, too, not just in the installer. So it kind of sounds like our msime support is hurting us performance-wise? - Dan

3 4

Text bug in winecfg!
by Warren Dumortier 23 Apr '08

23 Apr '08

Hello everybody! When i use winecfg in english, text in winecfg looks good but in french and some other languages it isn't the case, i made a screenshot to show the (little, little, very little) bug, but i find it annoying! Here is the little window screenshot: http://www.host-img.com/files/fkn8csdlmgvd316z22uq.png Is this a wine bug or not? Thanks, kind regards

2 1

New winetricks 20080423: added mono19, removed mono1[12], updated xvid
by Dan Kegel 23 Apr '08

23 Apr '08

Another day, another Winetricks. Changes: r40 Update to latest mono Remove mono11 and mono12 verbs, replace with mono19 Abort properly on network errors r39 Updated xvid As always, get it at http://kegel.com/wine/winetricks or http://code.google.com/p/winezeug

1 0

winehq.org redesign
by Evgeny Burzak 23 Apr '08

23 Apr '08

Hello all, some times ago I make design for AppDB (http://buzz.ulx.ru/pf/appdb.png). Folks was delighted with this one, but managers rejected my idea due to needs redesign everything then. But now it may be more actual then ever owing to Wine 1.0 release? I think it may gain attention from professionals who wants to use wine in production environment and improve Wine. I can make design for main pages, xml/xslt template and probably base php5 clasess if you decide to change site engine. -- Evgeny

7 8

Re: [3/3] user32:mdi.c Fix processing of SW_SHOWMINNOACTIVE according with test. [resend]
by Alexandre Julliard 23 Apr '08

23 Apr '08

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Changelog: > Fix processing of SW_SHOWMINNOACTIVE according with test. No luck here either: msg.c:4587: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: in msg 0x0046 expecting wParam 0x8170 got 0x8150 msg.c:4587: Test failed: ShowWindow(SW_SHOWMINNOACTIVE) child with invisible parent: in msg 0x0047 expecting wParam 0x8178 got 0x8158 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] user32:msg.c Make two tests clear pass in Win XP SP 2 [resend]
by Alexandre Julliard 23 Apr '08

23 Apr '08

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Changelog: > Make two tests clear pass. This breaks the test on Vista and on Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: return active window if foreground window is set
by Alexandre Julliard 23 Apr '08

23 Apr '08

Jeff Latimer <lats(a)yless4u.com.au> writes: > The comment in the code indicates that the foreground window is active > window of the active thread. Seems logical the active window handle > should be returned at the same time. No, the active window is per-thread, you can't return the active window of some other thread. -- Alexandre Julliard julliard(a)winehq.org

1 0

What to do about filenames legal in Linux but illegal in Windows?
by Dan Kegel 23 Apr '08

23 Apr '08

Linux users create files with names that are legal in Linux but not in Windows, simply because they can. Eventually they'll try to read those files in a Windows app, either by carrying them on a flash drive over to a real windows system, by dual booting, or by running the app in Wine. Now, normally, Wine should do exactly what Windows does. (I believe that in both Windows and Wine, directory listings will show these illegal chars, but attempts to open the files will fail.) But let's say we're in that happy time in the near future when lots of companies are willing to ship their apps with Wine as a halfway house to native support, and lots of their users start running into this issue. Can/should such apps tell Windows or Wine "Oh, go ahead and let me open those funny files?" On Wine, of course, we could open up a hole if we had to, but it'd be nice to know if there were a method that also worked on Windows. I looked around a bit today for a way to open such files in Windows, and failed miserably (though I did find a nice example of how to use NtCreateFile without the DDK). Anyone know of a way on real Windows to do this?

3 3

Re: WGL: WGL_WINE_pixel_format_passthrough [attempt 2]
by Alexandre Julliard 23 Apr '08

23 Apr '08

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > +BOOL X11DRV_wglSetPixelFormatWINE(X11DRV_PDEVICE *physDev, int iPixelFormat, const PIXELFORMATDESCRIPTOR *ppfd) > +{ > + TRACE("(%p,%d,%p)\n", physDev, iPixelFormat, ppfd); > + > + /* When the requested pixel format differs from the physDev its pixel format AND > + * the physDev has a pixel format set, clear current_pf, so that SetPixelFormat > + * will set the pixel format again. */ > + if((physDev->current_pf != 0) && (physDev->current_pf != iPixelFormat)) { > + TRACE("Changing iPixelFormat from %d to %d\n", physDev->current_pf, iPixelFormat); > + physDev->current_pf = 0; > + } You shouldn't set the format to 0 first, this will break if changing to the new format fails for some reason. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-announce and wine-users getting hammered
by Luke Bratch 23 Apr '08

23 Apr '08

Hi I do the moderation for these lists, and wine-accounce and wine-users are getting absolutely hammered with notification error messages today (in the order of around 15 per minute all day long). I've been clearing these out, but perhaps this is an indication of someone targeting these lists? Luke __________________________________________________________ Sent from Yahoo! Mail. A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html

2 2

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2
by Paul Vriens 23 Apr '08

23 Apr '08

Dmitry Timoshkov wrote: > Hello, > > here is another version of the patch. > -- > > According to test.winehq.ord data Windows 2000 behaves weird in some tests, > this looks like a bug to me. This patch addresses these failures. > > Changelog: > gdi32: Make the bitmap test pass under Windows 2000. > --- > dlls/gdi32/tests/bitmap.c | 28 ++++++++++++++++------------ > 1 files changed, 16 insertions(+), 12 deletions(-) > > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index f7bfdfd..ba4f8bd 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -276,7 +276,7 @@ static void test_dib_info(HBITMAP hbm, const void *bits, const BITMAPINFOHEADER > { > BITMAP bm; > DIBSECTION ds; > - INT ret, width_bytes; > + INT ret, bm_width_bytes, dib_width_bytes; > BYTE *buf; > > ret = GetObject(hbm, sizeof(bm), &bm); > @@ -285,23 +285,25 @@ static void test_dib_info(HBITMAP hbm, const void *bits, const BITMAPINFOHEADER > ok(bm.bmType == 0, "wrong bm.bmType %d\n", bm.bmType); > ok(bm.bmWidth == bmih->biWidth, "wrong bm.bmWidth %d\n", bm.bmWidth); > ok(bm.bmHeight == bmih->biHeight, "wrong bm.bmHeight %d\n", bm.bmHeight); > - width_bytes = DIB_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > - ok(bm.bmWidthBytes == width_bytes, "wrong bm.bmWidthBytes %d != %d\n", bm.bmWidthBytes, width_bytes); > + dib_width_bytes = DIB_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > + bm_width_bytes = BITMAP_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > + if (bm.bmWidthBytes != dib_width_bytes) /* Win2k bug */ > + ok(bm.bmWidthBytes == bm_width_bytes, "wrong bm.bmWidthBytes %d != %d\n", bm.bmWidthBytes, bm_width_bytes); > + else > + ok(bm.bmWidthBytes == dib_width_bytes, "wrong bm.bmWidthBytes %d != %d\n", bm.bmWidthBytes, dib_width_bytes); > ok(bm.bmPlanes == bmih->biPlanes, "wrong bm.bmPlanes %d\n", bm.bmPlanes); > ok(bm.bmBitsPixel == bmih->biBitCount, "bm.bmBitsPixel %d != %d\n", bm.bmBitsPixel, bmih->biBitCount); > ok(bm.bmBits == bits, "wrong bm.bmBits %p != %p\n", bm.bmBits, bits); > > buf = HeapAlloc(GetProcessHeap(), 0, bm.bmWidthBytes * bm.bmHeight + 4096); > > - width_bytes = BITMAP_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > - > /* GetBitmapBits returns not 32-bit aligned data */ > ret = GetBitmapBits(hbm, 0, NULL); > - ok(ret == width_bytes * bm.bmHeight, "%d != %d\n", ret, width_bytes * bm.bmHeight); > + ok(ret == bm_width_bytes * bm.bmHeight, "%d != %d\n", ret, bm_width_bytes * bm.bmHeight); > > memset(buf, 0xAA, bm.bmWidthBytes * bm.bmHeight + 4096); > ret = GetBitmapBits(hbm, bm.bmWidthBytes * bm.bmHeight + 4096, buf); > - ok(ret == width_bytes * bm.bmHeight, "%d != %d\n", ret, width_bytes * bm.bmHeight); > + ok(ret == bm_width_bytes * bm.bmHeight, "%d != %d\n", ret, bm_width_bytes * bm.bmHeight); > > HeapFree(GetProcessHeap(), 0, buf); > > @@ -331,8 +333,9 @@ static void test_dib_info(HBITMAP hbm, const void *bits, const BITMAPINFOHEADER > ok(ret == sizeof(ds), "wrong size %d\n", ret); > > ok(ds.dsBm.bmBits == bits, "wrong bm.bmBits %p != %p\n", ds.dsBm.bmBits, bits); > - ok(ds.dsBmih.biSizeImage == ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight, "%u != %u\n", > - ds.dsBmih.biSizeImage, ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight); > + if (ds.dsBm.bmWidthBytes != bm_width_bytes) /* Win2k bug */ > + ok(ds.dsBmih.biSizeImage == ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight, "%u != %u\n", > + ds.dsBmih.biSizeImage, ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight); > ok(bmih->biSizeImage == 0, "%u != 0\n", bmih->biSizeImage); > ds.dsBmih.biSizeImage = 0; > > @@ -968,14 +971,15 @@ static void test_bitmap(void) > assert(hdc != 0); > > SetLastError(0xdeadbeef); > - hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); > - ok(hbmp != 0, "CreateBitmap should not fail\n"); > + hbmp = CreateBitmap(0x7fff, 0x7fff, 1, 1, NULL); > + ok(hbmp != 0, "CreateBitmap error %u\n", GetLastError()); > DeleteObject(hbmp); > Hi Dmitry, This one will fail at least on my VMware box. Shouldn't the test (and it's confirmed by James and me) include something like: ok(hbmp!=0 || (hbmp == 0 && GetLastError() == ERROR_NOT_ENOUGH_MEMORY), ....) -- Cheers, Paul.

4 8

Re: Alex Villacís Lasso : uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an appropriately-sized memory bitmap out of the tile instead of iterating with UXTHEME_Blt () directly.
by Frank Richter 23 Apr '08

23 Apr '08

On 22.04.2008 13:47, Alexandre Julliard wrote: > uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an appropriately-sized memory bitmap out of the tile instead of iterating with UXTHEME_Blt() directly. But does that keep the alpha channel intact? -f.r.

3 3

Wine t-shirts?
by Maarten Lankhorst 23 Apr '08

23 Apr '08

Hi all, Why don't we have wine t-shirts any more? Cheers, Maarten.

1 0

Wine64 : initializer element is not computable at load time?
by Erik de Castro Lopo 22 Apr '08

22 Apr '08

Hi all, I'm compiling wine on x86-64 after configuring with --enable-win64 and I get the error: irotp.c:54: error: initializer element is not computable at load time irotp.c:54: error: (near initialization for 'critsect_debug.Spare[0]') on this this code: 51: static CRITICAL_SECTION_DEBUG critsect_debug = 52: { 53: 0, 0, &csRunningObjectTable, 53: { &critsect_debug.ProcessLocksList, &critsect_debug.ProcessLocksList }, 54: 0, 0, { (DWORD_PTR)(__FILE__ ": csRunningObjectTable") } 55: }; Anybody understand why? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "I'm not even an atheist so much as I am an antitheist; I not only maintain that all religions are versions of the same untruth, but I hold that the influence of churches, and the effect of religious belief, is positively harmful." -- Christopher Hitchens in "Letters to a Young Contrarian" 2001

2 3

Re: [PATCH 01/21] [WinHelp]: get rid of the reuse concept for Windows and refactor the code a bit for window creation / deletion
by Alexandre Julliard 22 Apr '08

22 Apr '08

Eric Pouech <eric.pouech(a)orange.fr> writes: > programs/winhelp/winhelp.c | 257 ++++++++++++++++++++------------------------ > 1 files changed, 116 insertions(+), 141 deletions(-) This breaks window repaints for me, when switching pages the window is not repainted and still shows the old page. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 05/21] [WinHelp]: properly handle the back button (in multiple windows, in empty stack...)
by Juan Lang 22 Apr '08

22 Apr '08

+ * WINHELP_DeleteButtons + * + */ +void WINHELP_DeleteBackSet(WINHELP_WINDOW* win) Nit: the comment should match the function. --Juan

1 0

Re: Spelling fixes
by H. Verbeet 22 Apr '08

22 Apr '08

On 22/04/2008, Austin English <austinenglish(a)gmail.com> wrote: > - /* Declare loop registers aLx */ > + /* Declare loop registers alx */ > for (i = 0; i < reg_maps->loop_depth; i++) { > shader_addline(buffer, "int aL%u;\n", i); > shader_addline(buffer, "int tmpInt%u;\n", i); As can be seen a few lines down, the registers are declared as "aL%u".

1 0

Wine countdown?
by Dan Kegel 22 Apr '08

22 Apr '08

Anybody seen the nifty countdown logo that Ubuntu is using? http://www.ubuntu.com/getubuntu/countdown Maybe we should do something similar for Wine. FWIW, here's a snippet that does something similar, but with text: <h1>Wine Release Countdown</h1> <script type='text/javascript'> function days_between(date1, date2) { // The number of milliseconds in one day var ONE_DAY = 1000 * 60 * 60 * 24; // Convert both dates to milliseconds var date1_ms = date1.getTime(); var date2_ms = date2.getTime(); // Calculate the difference in milliseconds var difference_ms = date2_ms - date1_ms; // Convert back to days and return return Math.round(difference_ms/ONE_DAY); } var d = new Date(); var release = new Date(); // see http://wiki.winehq.org/WineReleasePlan release.setTime(Date.parse("Jun 13, 2008")); document.write('<a href="http://www.winehq.org/">Wine 1.0 countdown: ' +days_between(d, release)+' days to release!</a>'); </script>

3 2

Translating Wine with PO files
by Dwayne Bailey 22 Apr '08

22 Apr '08

Hi, I've just completed a tool for converting resource files (.rc) to Gettext PO. http://translate.sourceforge.net/wiki/toolkit/rc2po This should allow many more FOSS translators to add translations to Wine, hopefully before the 1.0 release. In some ways this is a response to some issues raised in the 'Translations and Wine 1.0' thread: http://thread.gmane.org/gmane.comp.emulators.wine.devel/58000 further into this email I offer some comments on the issues raised in that thread. My suggestion is to deploy a Pootle server: http://translate.sourceforge.net/wiki/pootle/index The new RC tool, rc2po, is part of the Translate Toolkit, a general translation conversion toolkit and localisation library. http://translate.sourceforge.net/wiki/toolkit/index I've cut 1.2-alpha1 for those who want to give it a spin. We've just started work on v1.2 so the toolkit is mature, started in 2002, and the alpha status is simply an indication that we've got quite a while before 1.2 official. Download it from here: http://translate.sourceforge.net/snapshots/ Status of rc2po: ---------------- * Its very new - I've done roundtrip testing and some translating in ummm pig latin :) but will begin more serious Afrikaans translation soon. So I expect to see some bugs. * It can handle: DIALOG*, MENU, LANGUAGE, STRINGTABLE * You can't change the dialog sizes - I have some ideas of how we could do this in PO but its not implemented at all How it works: ------------- Make POT files: rc2po -P some.rc some.pot Recover old translations: rc2po -t some.rc translated.rc translated.po Make rc files: po2rc --lang=LANG_XXX -t some.rc translated.po translated.rc The wiki page provides clearer usage examples: http://translate.sourceforge.net/wiki/toolkit/rc2po Things to be aware of --------------------- * You cannot tweak the translations in .rc and hope to keep things in sync with PO, you'll need to only work in PO files or make sure any tweaks you make in your .rc you copy to the .po. * You cannot change the sizes of the dialogues in your translation for the above reason. This should change in the future to allow you to 'translate' the sizes. * Recovered translations need to be fully reviewed as we can't determine if your translation is based on the same English text. * We cannot create multi-language .rc files, you'll need one languages in each file. * We can read multilingual files but will only take the first language and drop anything after that, since PO files can only contain one language this makes sense. * We don't do any changes to the Makefiles, you'll have to do those by hand. But it would probably be easy to create a simple bash script or change the build system to automagically include all xxx_yy.rc files. * We handle encoding issues but prefer UTF-8 throughout. How you can help ---------------- * By testing rc2po and po2rc * Help implement a solution to allow size changes * Report bugs on http://bugs.locamotion.org Getting help ------------ * On IRC: irc://irc.freenode.net/#pootle * Mailing list: http://lists.sourceforge.net/lists/listinfo/translate-devel * Wiki: http://translate.sourceforge.net/wiki/toolkit/rc2po Suggested localization infrastructure for Wine ---------------------------------------------- In the thread 'Translation and Wine 1.0': http://thread.gmane.org/gmane.comp.emulators.wine.devel/58000 there was some discussion about localization infrastructure for wine. I'd like to suggest that Wine looks at using Pootle: http://translate.sourceforge.net/wiki/pootle/index this is already in use by projects such as OLPC, OpenOffice.org and others. It can manage PO files, commit to various VC systems (including Git), allows suggestions, does various QA checks and allows download and submission of PO files, has translation memory and glossary suggestions, statistics, etc, etc. A hosting option is to put the files on http://pootle.locamotion.org but I would request someone from the Wine community to take charge of keeping the PO files up-to-date and authorising users, etc. I would however encourage the Wine community to run its own server. This would make it easier to commit files directly into Git. I would suggest some work to ensure that POT files, updating of PO files and conversion back to .rc are automatic. Being within the control of the Wine community makes this easier. Launchpad is not an options unless you convert to PO using the above rc2po. Pootle has the advantage that you can run your own server, you don't have that with Launchpad. -- Dwayne Bailey Translate.org.za +27-12-460-1095 (w) +27-83-443-7114 (cell)

1 0

Re: kernel32: Fix a test that fails on all NT platforms
by Paul Vriens 22 Apr '08

22 Apr '08

James Hawkins wrote: > Hi, > > Changelog: > * Fix a test that fails on all NT platforms. > > dlls/kernel32/tests/toolhelp.c | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi James, I've been looking at some of the patches to fix the tests but I'm a bit unsure if some of them are the correct way to go. Things like: + /* win9x does not return a thread, NT does */ te.dwSize = sizeof(te); - ok(!pThread32First( hSnapshot, &te ), "shouldn't return a thread\n"); + ret = pThread32First( hSnapshot, &te ); + ok(ret || !ret, "You'll never see this\n"); renders the whole test useless. It turns out that win9x in this case leaves te.dwSize and XP-and-up set te.dwSize to 0. Shouldn't we make use of that fact? So something like (or another combination): if (te.dwSize == 0) { XP-and-up, expect failure } else if (te.dwSize == sizeof(te)) { win9x, expect success } else { something is wrong/unexpected } On a sidenote (and this has been the case for a long time): I've seen patches where ok(function(a,b),"Failed"); is turned into c = function(a,b); if (c) { ..... } but done without a skip or such. So if Wine has a regression for 'function' we won't notice. We have loads of patches where we expect 3 or more different last errors. This will make sure the tests always succeed of course but makes it difficult to tell if we (Wine) are doing the correct/best thing. -- Cheers, Paul.

2 3

Re: Secure filename copy to fixed size variable wfileName
by Dmitry Timoshkov 22 Apr '08

22 Apr '08

"Tomasz Jezierski - Tefnet" <developers(a)tefnet.pl> wrote: > - strcpyW(wfileName, sei_tmp.lpFile); > + StrCpyNW(wfileName, sei_tmp.lpFile,sizeof(wfileName)); > } > } else > - strcpyW(wfileName, sei_tmp.lpFile); > + StrCpyNW(wfileName, sei_tmp.lpFile,sizeof(wfileName)); Your patch doesn't make the code more secure than it is now. StrCpyNW takes number of characters, not bytes. And since it's just a wrapper around lstrcpynW it's better to use the latter one instead. -- Dmitry.

1 0

Strange struct alignment errors?
by Dan Kegel 22 Apr '08

22 Apr '08

http://test.winehq.org/data/94883af56d7348228963d7e70a5af578310c2228/wine_x… looks kinda funny. Is somebody compiling the tests wrong somehow?

3 3

Re: version: Fix tests that fail in win9x and win2k
by Alistair Leslie-Hughes 22 Apr '08

22 Apr '08

James Hawkins wrote: > Hi, > > Changelog: > * Fix tests that fail in win9x and win2k. > > dlls/version/tests/info.c | 29 +++++++++++++++++++---------- > 1 files changed, 19 insertions(+), 10 deletions(-) > Hi James, No patch attached. Best Regards Alistair Leslie-Hughes

1 0

Re: [1/4] dinput: Return error for unknown property.
by Vitaliy Margolen 22 Apr '08

22 Apr '08

Sergey Khodych wrote: > > > - WARN("Unknown property %s\n", debugstr_guid(rguid)); > - break; > + FIXME("Unknown property %s\n", debugstr_guid(rguid)); > + return DIERR_UNSUPPORTED; I'd like to see tests for this. Also lots of programs will break because they won't get some not significant property. No short - don't do this. Vitaliy

2 2

Re: gdi32: Make the bitmap test pass under Windows 2000
by Alexandre Julliard 21 Apr '08

21 Apr '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -967,15 +970,19 @@ static void test_bitmap(void) > hdc = CreateCompatibleDC(0); > assert(hdc != 0); > > +if (0) > +{ /* this test fails under Win2k */ > SetLastError(0xdeadbeef); > hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); > ok(hbmp != 0, "CreateBitmap should not fail\n"); > DeleteObject(hbmp); > +} It would be better to find values that work on all platforms, instead of disabling the test completely. -- Alexandre Julliard julliard(a)winehq.org

5 8

Re: Alternative for isinf (fix for bug 12008) (version 2)
by Francois Gouget 21 Apr '08

21 Apr '08

+#if !defined(HAVE_ISINF) && defined(HAVE_IEEEFP_H) +#include <ieeefp.h> +#define isinf(x) (!(finite(x) || isnand(x))) +#endif The problem with macros is that something like isinf(*x++) won't do what you intend. That's why even for such a simple case a function would be better imho. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

1 0

d3dx9: Texturing functions
by tony.wasserka＠freenet.de 21 Apr '08

21 Apr '08

Hi all, as it's a larger chunk of functions, I felt like proposing my design idea for the D3DXCreateTexture/Volume/CubeTextureFromFile/Resource/FileInMemory/etc... functions. I'm CC'ing it to any wine d3dx coder I have in my addressbook yet, so sorry if I forgot one :) So, the first thing I want to make sure is that we redirect the function calls correctly in order to reduce double coding. This means on the one hand that we should call the Extended versions of each function from inside of the simpler ones (most default parameters for the Ex functions are on MSDN) and on the other hand that we unify all D3DXCreateTextureFromXXEx functions somehow. I don't know how Resources are stored internally, but I guess the simplest would be to redirect all of them to D3DXCreateTextureFromFileInMemory, i.e. when D3DXCreateTextureFromFile is called we read the file into memory and call the InMemory function. I hope this shouldn't be too hard to be applied to the resource function either. Of course, this should also be done at the corresponding Surface, Volume and cube texture functions. Also, I haven't looked too much into it yet, but I guess we could go even a step further and define the CreateTextuteFromXX calls like this: 1. Redirect to the corresponding D3DXCreateXFromFileInMemoryEx call 2. Call D3DXCheckXRequirements 3. Call IDirect3DDevice9::CreateTexture 4. Lock its surface 5. Call LoadSurfaceFromFileEx with it This would reduce most of our coding work on LoadSurfaceFromFileEx. However, there are still plenty of formats supported by the texturing functions and thus, plenty of work for us to do. IIRC we once came to the decision to use libraries like libpng or so to reduce that work, too, so we'd just need to implement formats like .dds. And the last thing I'd like to ask goes to Louis Lenders: I've just found out that you have been working on a D3DXCreateTextureFromFile implementation. Are you still working on that? I'm really looking forward to do some coding work again, so I could continue your implementation from the 24th March if you've stopped to work on it ;-) However, feel free to comment on my proposals for the texturing functions and tell me if you see any concerns with it :) Best regards, Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

2 1

Some XDC update
by Stefan Dösinger 21 Apr '08

21 Apr '08

Hi, Here's a short summary of the wine-related things that were going on on XDC: -> Mouse input: Daniel Stone will take care of that. He says DGA would give us what we want, but recommends not to use it. He is working on extending XInput(or making a new XI2) which can report relative mouse movements. The X people want to phase out DGA. Some games use it for relative input, so they'll make a DGA emulation layered on the new XInput stuff. He will need debugging / testing help from us since Wine will most likely be the only App making use of that directly. Also we should not hold our breath, he has some other items on his TODO list, but the end of 2008 is a plausible ETA. -> Tablets: Config issue is known and being worked on -> Graphics, general: The Mesa and ATI people are willing to help out with our issues. I talked to Aaron Plattner and Pierre ? from Nvidia, and they know the issues and worked on some extensions for that internally some time ago, but then decided that they're not going to implement that for some reason they didn't tell me(I hope they re-consider that now that someone is asking for it though). The ATI guys warned me that it might take a while until any new extensions are available in production drivers, but that's something we have to put up with I guess. Also both the ATI and Mesa people like the idea of using our conformance tests for their driver testing and debugging. The Nvidia guys offered help with the multithreading crashes and the 32 vs 40 varying issue. (I also talked to Ben Byer from Apple, but he's not in charge of the graphics drivers) -> Graphics: Flat shading: Picking that as a first case for working on an extension. Should be fairly easy to implement in Mesa since all cards have a specific register for exactly that issue. -> Graphics, multithreading: general agreement that what we are doing is correct, and driver bugs need fixing. It looks like the crash in fglrx will be fixed soon(my test app worked in Matthew's development driver). For the Nvidia issues I'll file a bugreport as soon as I know if the glxSwapBuffers crash is a driver or Gentoo bug) -> Graphics, sRGB blending: Everyone believes me that our emulation is slow("pow() - uh oh, don't use that, that's not parallelizeable"[Keith Packard]). The nvidia people are aware of the issue, but a fix is also unlikely. The ATI people aren't sure if their dx9 hardware supports sRGB writing, maybe the windows driver is emulating things as well - have to check -> Graphics, GLSL issues: MOVA and LIT, possibly extensions for that. -> Graphics, Hacks: Both the ATI and Nvidia developers warned me that their Windows drivers have a huge per-application bug workaround database. Aaron was pretty impressed that Wine doesn't have any app-specific hacks. I am afraid we will need them, as some apps seem to expect different behavior that our d3d9 tests get. I think the best way is to fetch some information about the Windows driver hacks and write tests which trigger them to show that "hl2.exe" gets different driver behavior than "d3d9_test.exe"(or in whatever way things work)

2 1

Re: msxml3: Correct transformNode from failing on windows
by Alexandre Julliard 21 Apr '08

21 Apr '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index 6f790fe..b06e57e 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -143,7 +143,11 @@ static const CHAR szTransformSSXML[] = > "</xsl:stylesheet>"; > > static const CHAR szTransformOutput[] = > -"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" > +"<html>\r\n<body>\r\n<h1>\r\n" > +"Hello World\r\n" > +"</h1>\r\n</body>\r\n</html>\r\n"; > + > +static const CHAR szTransformOutputWine[] = > "<html><body><h1>\n" > "Hello World\n" > "</h1></body></html>\n"; > @@ -3193,7 +3197,8 @@ static void test_testTransforms(void) > > hr = IXMLDOMDocument_transformNode(doc, pNode, &bOut); > ok(hr == S_OK, "ret %08x\n", hr ); > - ok( !lstrcmpW( bOut, _bstr_(szTransformOutput) ), "Stylesheet output not correct\n"); > + ok( !lstrcmpW( bOut, _bstr_(szTransformOutput)) || /* Windows */ > + !lstrcmpW( bOut, _bstr_(szTransformOutputWine)) /* Wine */, "Stylesheet output not correct\n"); You shouldn't need a special case for Wine. What you need is a smarter comparison function that ignores EOL characters. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: imm32: Fix a test that fails on all systems
by Aric Stewart 21 Apr '08

21 Apr '08

Are this tests failing on windows? When I did my recent IME work I was working to make sure that these tests succeeded at that time. have they started failing on wine as well? thanks, -aric James Hawkins wrote: > Hi, > > Changelog: > * Fix a test that fails on all systems. > > dlls/imm32/tests/imm32.c | 30 +++++++++++++++++++++--------- > 1 files changed, 21 insertions(+), 9 deletions(-) > > > > ------------------------------------------------------------------------ > >

2 1

Re: [PATCH 09/17] widl: Split the expr rule up into multiple rules to fix operator precedence.
by Alexandre Julliard 21 Apr '08

21 Apr '08

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -263,8 +263,14 @@ static void add_explicit_handle_if_necessary(func_t *func); > %type <attr> attribute > %type <attr_list> m_attributes attributes attrib_list > %type <str_list> str_list > -%type <expr> m_expr expr expr_const > -%type <expr_list> m_exprs /* exprs expr_list */ expr_list_const > +%type <expr> m_expr expr_const expression conditional_expression > +%type <expr> conditional_expression logical_OR_expression logical_AND_expression > +%type <expr> inclusive_OR_expression exclusive_OR_expression AND_expression > +%type <expr> equality_expression relational_expression shift_expression > +%type <expr> additive_expression additive_expression multiplicative_expression > +%type <expr> cast_expression unary_expression postfix_expression > +%type <expr> primary_expression > +%type <expr_list> m_exprs expr_list_const > %type <array_dims> array array_list > %type <ifinfo> interfacehdr > %type <type> inherit interface interfacedef interfacedec You shouldn't need that, the %left/%right declarations should define the correct precedence already. Why doesn't this work for you? -- Alexandre Julliard julliard(a)winehq.org

2 1

Question about openning html document in new window
by Ivan Sinitsin 21 Apr '08

21 Apr '08

Hello, I have a question. I make a patch, that fix problem with open html document in new window. I tested it on "MyIE 2" and it works. But I am not assured, whether it is possible to solve a problem in this way. What do you think about it? -- Sinitsin Ivan

1 0

Re: user32: Use the PostMessage() for WM_IME_KEY{DOWN|UP} message
by Dmitry Timoshkov 21 Apr '08

21 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > * MS Spi++ test result, PostMessage is right. > * Message generation sequence: > WM_IME_KEYDOWN -> WM_KEYDOWN -> WM_CHAR > WM_CHAR is genetated in the TranslateMessage() when we use > PostMessage() function. > * Real case: MS IME 2002, MS IME 2003, Saenaru > In the preedit mode, when we press the "ENTER" key, Korean > Native IME generate the WM_IME_KEYDOWN(wParam==VK_RETURN) message. > This message is translated to the WM_CHAR(wParam==VK_RETURN) > message finally. You should add the tests to dlls/user32/tests/msg.c for the above changes. -- Dmitry.

1 0

Regressions: the enemy of 1.0
by Dan Kegel 21 Apr '08

21 Apr '08

There's been lots of progress in Wine lately; many important applications work better than ever. But the inevitable cost of such progress is that some applications are now broken and/or wine has odd problems. For instance, as of the last two versions of Wine, StarUML can't be unminimized ( http://bugs.winehq.org/show_bug.cgi?id=12697 ), and as of 0.9.60, the IME support seems to be making wine apps run dog slow on at least one of my machines ( http://www.winehq.org/pipermail/wine-devel/2008-April/064999.html ). These seem like regressions that ought to be fixed before 1.0. So... I guess my point is: the code freeze is starting soon, which is good; that will help coax developers into looking for and fixing recently introduced bugs rather than old ones. i.e. fight to hang on to what we've got (or had recently) rather than pushing to conquer new ground. Those who absolutely have to work on risky new stuff in the meantime will increasingly have to keep their work outside the main tree for now. Once 1.0 is out, those patches can land, and the fight for new ground can resume.

3 2

Re: [4/4] Add test for IDirectInputDevice_GetProperty of keyboard device for unicode and ascii case.
by Vitaliy Margolen 21 Apr '08

21 Apr '08

Sergey Khodych wrote: > > > ------------------------------------------------------------------------ > > > + result = wcsncmp( dipsw.wsz, dipsa.wsz, sizeof( dipsw.wsz )/sizeof( dipsw.wsz[0] ) ); UNIX unicode and windows unicode are two separate things. Don't use functions that work with wchar_t - they are not compatible with Wine. Use Wine's own unicode functions instead. For example here you can use lstrcmpW(). Vitaliy.

1 0

Wine 1.0 status: T minus 54 days, 63 bugs to go. Code freeze in 12 days.
by Dan Kegel 20 Apr '08

20 Apr '08

See http://kegel.com/wine/countdown.html for a current (and clickable) status report. Here's what it says now: Wine Release Countdown Wine 1.0 countdown: 54 days to release, 12 days to freeze! See WineReleasePlan for details. wine-0.9.60 was released on Friday, April 20th, 2008. According to http://wiki.winehq.org/WineReleasePlan wine-0.9.61, due out Friday, May 2, 2008, will be the first release candidate for 1.0, and mark the start of the code freeze. During the code freeze, patches that * are simple * come with a conformance test * fix a regression * are low risk are more likely to get in than other patches. (Heck, that's always true, but it's even truer during a freeze.) We will actively discourage patches that might endanger the 1.0 release date (June 13th). Bug Status There are 63 open 1.0 bugs as of 20 April. Most of these will simply be rolled over to be fixed for a later release; we only have time to fix a few, and much as we'd like to fix the rest, most are not showstoppers. Changes since last week (with category and votes): New (!): 12666 -unknown 0 Wine should refuse to run if pointed at a real Windows Fixed: 7477 -unknown 1 Uplink demo crashes 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 12561 -unknown 0 Photoshop CS alt key for clone/healing - possible regression Duplicate: 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 6607 ole 10 Drag and Drop not working Deferred: 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9484 kernel32 19 Program refuses to run because of ProtectCD/ProtectDISC copy-protection Here's the full list of current bugs: 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 12 tray minimize 5948 -unknown 1 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 8 "hello world" dos program hangs 9916 -unknown 6 "make test" usually fails 9959 -unknown 9 Make wine updates work even if the registry changed 10815 -unknown 5 Cannot drag images into Adobe Photoshop 7 from the web / desktop 11281 -unknown 4 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 12666 -unknown 0 Wine should refuse to run if pointed at a real Windows 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 3 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 4372 comctl32 1 listview: cannot drag several items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 17 Planescape:Torment doesn't work 9030 directx- 0 army men hangs on black screen 11681 directx- 17 Add support for video overlay 3270 gdi32 15 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 45 Steam Friends doesn't work (fails to render correctly or refresh) 5024 kernel32 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5351 kernel32 11 Windows Installer 3.1 cannot install because of non-standard drive labeling 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 10147 msi 1 Word Viewer 2003 - Tab behavior differs from Windows 8783 ntdll 13 USB serial ports do not work 9356 ntdll 8 Serial communication not working since wine-0.9.33 8095 ole 0 PQ Teaching toy crashes 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 5163 setupapi 13 Office XP 2002 crashes on installation 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 15 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 1 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 4 Temple of Elemental Evil demo doesn't start - gui irresponsive 8439 shell32 8 Visual Studio .NET (7) install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 3 Ship icons for the wine-tools that can be used in .desktop files 664 user32 7 The help menu functionality inside programs is broken (messaging problem) 3023 user32 6 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3297 winex11. 13 UpdateWindow() doesn't call XFlush() 5623 winex11. 4 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 25 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 10984 winex11. 6 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 4 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5625 wininet 4 Wine does not handle internet proxy settings conveniently 9787 winsock 50 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 1 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

Re: kernel32: Skip the screen buffer tests if codepage 866 is notavailable
by Dmitry Timoshkov 20 Apr '08

20 Apr '08

"James Hawkins" <jhawkins(a)codeweavers.com> wrote: > + res = RegOpenKeyA(HKEY_LOCAL_MACHINE, > + "System\\CurrentControlSet\\Control\\Nls\\CodePage", &hkey); > + if (res == ERROR_SUCCESS) > + { > + len = 20; > + res = RegQueryValueExA(HKEY_LOCAL_MACHINE, "866", NULL, > + NULL, (LPBYTE)str_buf, &len); > + } Could IsValidCodePage() be used instead? -- Dmitry.

2 1

Re: WINED3D: Fix a possible null dereference (try 2)
by H. Verbeet 20 Apr '08

20 Apr '08

On 19/04/2008, David Adam <david.adam.cnrs(a)gmail.com> wrote: > This time, with tests for d3d8 and d3d9. > > David Adam > Looks mostly ok, but you do need a \n at the end of these ok messages: > + ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %s", DXGetErrorString8(hr)); > + ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %s", DXGetErrorString9(hr)); > - * Copyright (C) 2006-2007 Stefan Dösinger(For CodeWeavers) > + * Copyright (C) 2006-2007 Stefan Dï¿½singer(For CodeWeavers) Try not to change the encoding of the file. I'm not sure if we ever considered simply using UTF-8 for source files, but it would probably prevent some issues like this.

2 1

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDIT controls.
by Lei Zhang 19 Apr '08

19 Apr '08

On Fri, Apr 18, 2008 at 3:50 PM, El. <elptr(a)users.sourceforge.net> wrote: > When a ES_MULTILINE-styled EDIT responds to a VK_RETURN Key press, it should > send a WM_COMMAND to the default control of the parent window if and only if > that parent is a Dialog box. At least Microsoft's version of notepad.exe > (WinXP) is fixed. > BTW, bug 12478 [1] appears to be related to this. [1] http://bugs.winehq.org/show_bug.cgi?id=12478

1 0

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDITcontrols.
by El. 19 Apr '08

19 Apr '08

> "El." <elptr(a)users.sourceforge.net> wrote: > > > @@ -4606,6 +4606,10 @@ static LRESULT EDIT_WM_KeyDown(EDITSTATE *es, INT key) > > { > > HWND hwndParent = GetParent(es->hwndSelf); > > DWORD dw = SendMessageW( hwndParent, DM_GETDEFID, 0, 0 ); > > + > > + if (GetClassLongW(hwndParent, GCW_ATOM) != WC_DIALOG) > > + break; > > You need to add a test case first to confirm that the fix is correct, and > use EDIT_IsInsideDialog to detect if the parent is dialog. Well I'm not sure what to test in the first place, I didn't assume that modifying some aspect of the code to be in compliance with official "standards" required writing any test case. I might be missing what you mean by the "correctness" of the fix, since I'm not really familiar with Wine's patching practices. http://msdn2.microsoft.com/en-us/library/bb775464(VS.85).aspx As for using EDIT_IsInsideDialog, that I can manage.

3 3

[lostwages] update LGPL url, specify version
by Dan Kegel 19 Apr '08

19 Apr '08

Somebody on wine-users asked us to clarify this, so:

1 0

Re: [PATCH 2/2] wined3d: Prevent console spamming in drawPrimitive.
by H. Verbeet 19 Apr '08

19 Apr '08

On 18/04/2008, Alexander Dorofeyev <alexd4(a)inbox.lv> wrote: > Fixes massive slowdown in games like Aliens vs Predator 2. > If you care about performance you should always run with WINEDEBUG="-all" anyway.

2 3

Re: WINED3D: Fix a possible null dereference.
by H. Verbeet 19 Apr '08

19 Apr '08

On 19/04/2008, David Adam <david.adam.cnrs(a)gmail.com> wrote: > The Sting Demo calls the function > IDirect3DDeviceImpl_7_SetMaterial (in ddraw/device.c) with > Mat=NULL. > Then, this makes the function IWineD3DDeviceImpl_SetMaterial (in > wined3d/device.c) crashes in the line > This->updateStateBlock->material = *pMaterial; > So, the patch checks is the material is not null before assignating it. > > This fixes a crash in The Sting demo. > > David Adam > I would like to see a few tests that prove this is the correct behaviour (instead of eg. simply returning WINED3DERR_INVALIDCALL), for ddraw, d3d8 and d3d9.

1 0

Trying to get a grip on how to handle bug reports.
by Kai Blin 19 Apr '08

19 Apr '08

Hi folks, I seem to have done something wrong referring a user to a closed bug report that seemed to be related to the problem he was having. (See bug 11639 for more context) So in order to avoid me being the cause a user defiles the holy status of a closed bug, I'd like to have some clear rules on how to handle related bug reports. And you folks wonder why we don't have a healthy user community. Sometimes I feel like talking to a brick wall. Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

4 4

Re: [PATCH] user32: Handle VK_RETURN KeyDown events more properly in EDITcontrols.
by Dmitry Timoshkov 19 Apr '08

19 Apr '08

"El." <elptr(a)users.sourceforge.net> wrote: > @@ -4606,6 +4606,10 @@ static LRESULT EDIT_WM_KeyDown(EDITSTATE *es, INT key) > { > HWND hwndParent = GetParent(es->hwndSelf); > DWORD dw = SendMessageW( hwndParent, DM_GETDEFID, 0, 0 ); > + > + if (GetClassLongW(hwndParent, GCW_ATOM) != WC_DIALOG) > + break; You need to add a test case first to confirm that the fix is correct, and use EDIT_IsInsideDialog to detect if the parent is dialog. -- Dmitry.

1 0

Hack: Debug a specific critical section WINE_DEBUG_SPINLOCK
by Maarten Lankhorst 18 Apr '08

18 Apr '08

Hi all, I created a hack to debug a specific critical section with WINE_DEBUG_SPINLOCK environment. It was useful for me because it found a very weird deadlock, a thread would terminate before releasing its critical section. It will also change the timeout to 1 second so you will get a faster response on potential latency issues. How to use it? First you need the exact spinlock name. for example in parser.c: pParser->csFilter.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": ParserImpl.csFilter"); Of course you still need to know what __FILE__ is, this is usually parser.c but I'm not 100% sure that is the same for out of tree builds. So just to be sure: $ strings parser.o |grep csFilter parser.c: ParserImpl.csFilter export WINE_DEBUG_SPINLOCK="parser.c: ParserImpl.csFilter" It will then print a ++ for every time a lock is entered, and -- for every time lock is left., I would recommend mixing this with WINEDEBUG=+tid so you can also see the threads they are in. Comments? Cheers, Maarten.

1 0

Re: Wine release 0.9.60
by Adrian Bunk 18 Apr '08

18 Apr '08

On Fri, Apr 18, 2008 at 05:59:16PM +0200, Alexandre Julliard wrote: >... > Bugs fixed since 0.9.59: >... > 7174 Master of Orion 2 does not switch screen resolution correctly >... That this bug is listed as "fixed since 0.9.59" is wrong, and it sounds as if you wrongly count all bugs closed since 0.9.59 as having been present in 0.9.59? Looking through some of the other bugs (especially older ones) the information in Bugzilla indicates for several other bugs listed in your announcement that they were not "fixed since 0.9.59". You Wine developers are doing a great job, but especially since you are currently actively triaging older bugs "fixed since 0.9.59" is quite different from "closed since 0.9.59". > Alexandre Julliard cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed

2 3

Re: Trouble in compiling Wine 0.9.57 and 0.9.58 on Solaris 10 08/07
by Petr Sumbera 18 Apr '08

18 Apr '08

>isinf is a function / macro which returns wether or not a float is positive >infinite or negative infinite. I think it is a standard C function. Maybe >solaris declares it in some header that needs to be included, like math.h? I have logged for this bug: http://bugs.winehq.org/show_bug.cgi?id=12008 Not sure where to find it exactly. But isinf seems to be defined by ISO 99 (not by standard C). Regards, Petr

4 6

Re: d3dx9_36: Add stubs and implementations for D3DXCreateTexturexx
by tony.wasserka＠freenet.de 18 Apr '08

18 Apr '08

> I have a hacky implementation of D3DXLoadSurfaceFromMemory and > D3DXLoadSurfaceFromSurface, as well as a pretty good implementation of > D3DXCreateTexture and D3DXCheckTextureRequirements. > > I'll send in the patch for the last two when I have time, and have > looked it over a final time. I pretty much abandoned the first two, > because there's got to be a whole lot of code somewhere in the tree > already. It does work in some cases, however. Attached in case it > might be helpful. Nice, I hope I can do something with the D3DXLoadSurfaceFromMemory/Surface implementations when my D3DXLoadXXFromFile functions are ready, thank you! However, I don't wanna push you, but can you send me your current code for D3DXCreateTexture+D3DXCheckTextureRequirements so that I can work on D3DXLoadXXFromFile and the other functions until it's in the main tree? Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

New winetricks 20080418: add wmp10, windows codecs, accept new flash version
by Dan Kegel 18 Apr '08

18 Apr '08

Another day, another Winetricks. Changes since yesterday's annoucement: Switch to listing simpler synonyms for changing windows version (long ones still valid) Correct description of volnum verb (it's still needed) Fix typo in sha1sum check that caused it to be ignored! Update sha1sum for flash player (see comment for URL about the update) Much better error reporting for gui users. Add wmp10 Installing wmp9 or wmp10 also gets codecs now Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com

1 0

Re: user32:mdi.c Fix creating MDI child window according with test.
by Dmitry Timoshkov 18 Apr '08

18 Apr '08

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- dlls/user32/mdi.c 5 Mar 2008 19:42:23 -0000 1.24 > +++ dlls/user32/mdi.c 18 Apr 2008 12:07:50 -0000 > @@ -649,6 +728,9 @@ static LONG MDI_ChildActivate( HWND clie > } > > SendMessageW( child, WM_MDIACTIVATE, (WPARAM)prevActiveWnd, (LPARAM)child ); > + > + SetWindowPos( frame, HWND_TOP, 0, 0, 0, 0, SWP_NOMOVE|SWP_NOSIZE|SWP_NOACTIVATE|SWP_FRAMECHANGED ); SWP_NOZORDER should be there for sure, and in that case HWND_TOP doesn't make sense, so just use 0 (although HWND_TOP == 0) instead. -- Dmitry.

2 1

Re: shell32: implement SHGetFolderPathAndSubDirA/W [try2][resend]
by Alexandre Julliard 18 Apr '08

18 Apr '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1758,7 +1836,7 @@ > */ > if (!(nFolder & CSIDL_FLAG_CREATE)) > { > - hr = HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND); > + hr = HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND); > goto end; Why is it using a different error code here? Do you have a test case for this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet: correct the case where Content-Length is set as well as Transer-Encoding = chunked
by Hans Leidekker 18 Apr '08

18 Apr '08

On Thursday 17 April 2008 20:05:41 Aric Stewart wrote: > + /* Correct the case where both a Content-Length and Transfer-encoding = chuncked are set */ > + > + dwBufferSize = sizeof(encoding); > + if (HTTP_HttpQueryInfoW(lpwhr, HTTP_QUERY_TRANSFER_ENCODING, encoding, &dwBufferSize, NULL) && > + !strcmpiW(encoding, szChunked)) > + { > + lpwhr->dwContentLength = -1; > + } I think the right thing to do is to strip the Transfer-Encoding header from the request because we don't support chunked transfers in the sending direction. Would that work for you? -Hans

2 3

Strange waveOutGetDevCaps calls in winmm/tests/wave.c
by Peter Åstrand 18 Apr '08

18 Apr '08

winmm/tests/wave.c currently contains: rc=waveOutGetDevCapsA(device,&capsA,4); ok(rc==MMSYSERR_NOERROR, "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR expected, got %s\n", dev_name(device),wave_out_error(rc)); rc=waveOutGetDevCapsW(device,&capsW,4); ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " "expected, got %s\n",dev_name(device),wave_out_error(rc)); This seems wrong to me; the last argument should be the size of the WAVEOUTCAPS structure, and there are no such structures that have size 4. The CapsW test fails with our sound driver (tlsnd) as well as Microsofts Terminal Services driver (rdpsnd). The CapsA test doesn't fail, probably since winmm wraps CapsA calls with CapsW calls and then does memcpy. In either case, calling waveOutGetDevCaps sith size=4 is not valid, as far as I can tell. Theoretically, it might be in the future, though, if some small caps structure is invented. I suggest that these tests are removed altogether: --- wave.c 29 Feb 2008 12:18:36 -0000 1.67 +++ wave.c 16 Apr 2008 12:03:44 -0000 @@ -853,16 +853,6 @@ "expected, got %s\n",dev_name(device),wave_out_error(rc)); } - rc=waveOutGetDevCapsA(device,&capsA,4); - ok(rc==MMSYSERR_NOERROR, - "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR expected, got %s\n", - dev_name(device),wave_out_error(rc)); - - rc=waveOutGetDevCapsW(device,&capsW,4); - ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, - "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " - "expected, got %s\n",dev_name(device),wave_out_error(rc)); - nameA=NULL; rc=waveOutMessage((HWAVEOUT)device, DRV_QUERYDEVICEINTERFACESIZE, (DWORD_PTR)&size, 0); Regards, --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://www.cendio.se Wallenbergs gata 4 583 30 Linköping Phone: +46-13-21 46 00

2 2

Re: wininet: improve stub for FindNextUrlCacheEntryW a tiny bit
by Dmitry Timoshkov 18 Apr '08

18 Apr '08

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > @@ -3113,6 +3113,7 @@ BOOL WINAPI FindNextUrlCacheEntryW( > LPDWORD lpdwNextCacheEntryInfoBufferSize > ) > { > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > FIXME("(%p, %p, %p) stub\n", hEnumHandle, lpNextCacheEntryInfo, lpdwNextCacheEntryInfoBufferSize); > return FALSE; > } You should put SetLastError() immediately before return, any calls after it may potentially change last error value. -- Dmitry.

1 0

Wine Status Page
by Joel Holdsworth 18 Apr '08

18 Apr '08

Hi All, Are there any plans to update the percentages on the Wine status page any time soon? I'm curious to know how much progress has been made in the past 10 months. Regards Joel Holdsworth

2 1

new Valgrind errors in oleaut32
by Dan Kegel 18 Apr '08

18 Apr '08

James just barely touched the oleaut32 tests, and as a side effect, we now have several more warnings of the sort + Conditional jump or move depends on uninitialised value(s) + at VARIANT_DI_tostringW (vartype.c:4852) + by VarBstrFromCy (vartype.c:6519) + by VariantChangeTypeEx (variant.c:433) + by VarCat (variant.c:2555) + by test_VarCat (vartest.c:5246) + by func_vartest (vartest.c:8436) + by run_test (test.h:406) + by main (test.h:455) and + Conditional jump or move depends on uninitialised value(s) + at __printf_fp (in /lib/tls/i686/cmov/libc-2.6.1.so) + by vfprintf (in /lib/tls/i686/cmov/libc-2.6.1.so) + by vsprintf (in /lib/tls/i686/cmov/libc-2.6.1.so) + by sprintf (in /lib/tls/i686/cmov/libc-2.6.1.so) + by vsnprintfW (string.c:408) + by sprintfW (string.c:455) + by VARIANT_BstrFromReal (vartype.c:6406) + by VarBstrFromR4 (vartype.c:6457) + by VariantChangeTypeEx (variant.c:430) + by VarCat (variant.c:2555) + by test_VarCat (vartest.c:5246) + by func_vartest (vartest.c:8454) + by run_test (test.h:406) + by main (test.h:455) See http://kegel.com/wine/valgrind/logs-2008-04-17/vg-oleaut32_vartest-diff.txt

1 0

Towards pure wine: a step by step approach
by Dan Kegel 18 Apr '08

18 Apr '08

Errors reported by valgrind, coverity, and our conformance test suite are all worth fixing... but fixing them *all* is like shovelling out the dung from an infinitely large barn. Various people have tried fixing one kind of error or the other, but maybe a combined attack, where we went module by module and fixed *all* of the valgrind, coverity, and conformance test errors might be more fruitful (or at least more satisfying). Such an attempt should probably start at the bottom, cleaning up modules in the order wineserver, ntdll, kernel32, gdi32, user32, ... To that end, here are the combined known errors for the first few modules. wineserver: coverity: cv219 FORWARD_NULL UNINSPECTED set_console_input_info base/src/wine/server/console.c cv220 FORWARD_NULL UNINSPECTED connect_process_winstation base/src/wine/server/winstation.c ntdll: coverity: cv48 FORWARD_NULL UNINSPECTED RtlAllocateHandle base/src/wine/dlls/ntdll/handletable.c cv55 FORWARD_NULL UNINSPECTED RtlCreateEnvironment base/src/wine/dlls/ntdll/env.c cv227 NEGATIVE_RETURNS UNINSPECTED read_changes_apc base/src/wine/dlls/ntdll/directory.c cv248 NULL_RETURNS UNINSPECTED HEAP_FindFreeBlock base/src/wine/dlls/ntdll/heap.c cv343 REVERSE_INULL UNINSPECTED NtOpenSection base/src/wine/dlls/ntdll/virtual.c cv538 NULL_RETURNS UNINSPECTED HEApNtEnumerateSubKey base/src/wine/dlls/ntdll/reg.c cv644 REVERSE_INULL UNINSPECTED NtQueryInformationProcess base/src/wine/dlls/ntdll/process.c cv658 FORWARD_NULL RNS UNINSPECTED RtlQueryRegistryValues base/src/wine/dlls/ntdll/reg.cdlls/ole32/ole2.c valgrind: http://kegel.com/wine/valgrind/logs-2008-04-10/vg-ntdll_env.txt http://kegel.com/wine/valgrind/logs-2008-04-10/vg-ntdll_exception.txt http://kegel.com/wine/valgrind/logs-2008-04-10/vg-ntdll_file.txt conformance tests: http://test.winehq.org/data/200804161000/#group_Wine:ntdll:change http://test.winehq.org/data/200804161000/#group_XP:ntdll:exception There, that doesn't look too awful, does it? Only a few dozen little problems to solve and we'll have server and ntdll spic and span... and then on to the next module. If we start with a small circle of pure modules, and vigorously defend the modules in that circle against regressions in any of valgrind, coverity, and conformance tests, we might make a noticable improvement in Wine's quality. - Dan

2 2

Re: msxml3: Implement transformNode (try 3)
by Alistair Leslie-Hughes 17 Apr '08

17 Apr '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:ftvcka$qrg$1@ger.gmane.org... > Hi, > Corrected issue with tests > > Changelog: > msxml3: Implement transformNode > > Best Regards > Alistair Leslie-Hughes > Anything wrong with this patch? Best Regards Alistair Leslie-Hughes

3 2

installing wine into linux ubuntu
by stephen cooper 17 Apr '08

17 Apr '08

ref. Linux Format DVD 104 April 2008From: stephen cooper (stephencooper96(a)hotmail.com) I am new to Linux.I have just installed Linux UBUNTU 7.1 (gutsy) onto my computer with no problems. I want to install wine.I have written the source code onto my hard disc. (using tar ) When I run ./configure (.tools/wineinstall) I get an error - C compiler cannot create executables. I am including the output from the config.log for wine installation below. PLEASE ADVISE ME. Stephen Cooper. This file contains any messages produced by compilers whilerunning configure, to aid debugging if configure makes a mistake. It was created by Wine configure 0.9.54, which wasgenerated by GNU Autoconf 2.61. Invocation command line was $ ./configure --verbose ## --------- #### Platform. #### --------- ## hostname = stephen-desktopuname -m = i686uname -r = 2.6.22-14-genericuname -s = Linuxuname -v = #1 SMP Sun Oct 14 23:05:12 GMT 2007 /usr/bin/uname -p = unknown/bin/uname -X = unknown /bin/arch = unknown/usr/bin/arch -k = unknown/usr/convex/getsysinfo = unknown/usr/bin/hostinfo = unknown/bin/machine = unknown/usr/bin/oslevel = unknown/bin/universe = unknown PATH: /usr/local/sbinPATH: /usr/local/binPATH: /usr/sbinPATH: /usr/binPATH: /sbinPATH: /binPATH: /usr/games ## ----------- #### Core tests. #### ----------- ## configure:2100: checking build system typeconfigure:2118: result: i686-pc-linux-gnulibc1configure:2140: checking host system typeconfigure:2155: result: i686-pc-linux-gnulibc1configure:2221: checking whether make sets $(MAKE)configure:2242: result: yesconfigure:2299: checking for gccconfigure:2315: found /usr/bin/gccconfigure:2326: result: gccconfigure:2564: checking for C compiler versionconfigure:2571: gcc --version >&5gcc (GCC) 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)Copyright (C) 2006 Free Software Foundation, Inc.This is free software; see the source for copying conditions. There is NOwarranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. configure:2574: $? = 0configure:2581: gcc -v >&5Using built-in specs.Target: i486-linux-gnuConfigured with: ../src/configure -v --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.1.3 --program-suffix=-4.1 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-checking=release i486-linux-gnuThread model: posixgcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)configure:2584: $? = 0configure:2591: gcc -V >&5gcc: '-V' option must have argumentconfigure:2594: $? = 1configure:2617: checking for C compiler default output file nameconfigure:2644: gcc conftest.c >&5/usr/bin/ld: crt1.o: No such file: No such file or directorycollect2: ld returned 1 exit statusconfigure:2647: $? = 1configure:2685: result: configure: failed program was:| /* confdefs.h. */| #define PACKAGE_NAME "Wine"| #define PACKAGE_TARNAME "wine"| #define PACKAGE_VERSION "0.9.54"| #define PACKAGE_STRING "Wine 0.9.54"| #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org"| /* end confdefs.h. */| | int| main ()| {| | ;| return 0;| }configure:2692: error: C compiler cannot create executablesSee `config.log' for more details. ## ---------------- #### Cache variables. #### ---------------- ## ac_cv_build=i686-pc-linux-gnulibc1ac_cv_env_CCC_set=ac_cv_env_CCC_value=ac_cv_env_CC_set=ac_cv_env_CC_value=ac_cv_env_CFLAGS_set=ac_cv_env_CFLAGS_value=ac_cv_env_CPPFLAGS_set=ac_cv_env_CPPFLAGS_value=ac_cv_env_CPP_set=ac_cv_env_CPP_value=ac_cv_env_CXXFLAGS_set=ac_cv_env_CXXFLAGS_value=ac_cv_env_CXX_set=ac_cv_env_CXX_value=ac_cv_env_LDFLAGS_set=ac_cv_env_LDFLAGS_value=ac_cv_env_LIBS_set=ac_cv_env_LIBS_value=ac_cv_env_XMKMF_set=ac_cv_env_XMKMF_value=ac_cv_env_build_alias_set=ac_cv_env_build_alias_value=ac_cv_env_host_alias_set=ac_cv_env_host_alias_value=ac_cv_env_target_alias_set=ac_cv_env_target_alias_value=ac_cv_host=i686-pc-linux-gnulibc1ac_cv_prog_ac_ct_CC=gccac_cv_prog_make_make_set=yes ## ----------------- #### Output variables. #### ----------------- ## ALSALIBS=''AR=''AS=''AUDIOIOLIBS=''BISON=''BUILTINFLAG=''CARBONLIB=''CC='gcc'CFLAGS=''COREAUDIO=''COREFOUNDATIONLIB=''CPP=''CPPBIN=''CPPFLAGS=''CROSSCC=''CROSSTEST=''CROSSWINDRES=''CRTLIBS=''CXX=''CXXFLAGS=''DEFS=''DEPENDENCIES=''DISKARBITRATIONLIB=''DLLEXT=''DLLFLAGS=''DLLTOOL=''DLLWRAP=''ECHO_C=''ECHO_N='-n'ECHO_T=''EGREP=''ESDCONFIG=''ESDINCL=''ESDLIBS=''EXEEXT=''EXTRACFLAGS=''EXTRA_BINARIES=''FLEX=''FONTCONFIGINCL=''FONTFORGE=''FONTSSUBDIRS=''FREETYPEINCL=''FREETYPELIBS=''GLU32FILES=''GPHOTO2INCL=''GPHOTO2LIBS=''GREP=''HALINCL=''IMPLIBEXT=''INSTALL_DATA=''INSTALL_PROGRAM=''INSTALL_SCRIPT=''IOKITLIB=''LCMSLIBS=''LD=''LDAPLIBS=''LDCONFIG=''LDD=''LDDLLFLAGS=''LDEXECFLAGS=''LDFLAGS=''LDPATH=''LDRPATH_INSTALL=''LDRPATH_LOCAL=''LDSHARED=''LIBDL=''LIBEXT=''LIBOBJS=''LIBPOLL=''LIBPTHREAD=''LIBS=''LINT=''LINTFLAGS=''LN=''LN_S=''LTLIBOBJS=''MAIN_BINARY=''MINGWAR=''NASLIBS=''OBJEXT=''OPENGLFILES=''OPENGL_LIBS=''PACKAGE_BUGREPORT='wine-devel(a)winehq.org'PACKAGE_NAME='Wine'PACKAGE_STRING='Wine 0.9.54'PACKAGE_TARNAME='wine'PACKAGE_VERSION='0.9.54'PATH_SEPARATOR=':'PKG_CONFIG=''PRELINK=''QUARTZFILES=''RANLIB=''RESOLVLIBS=''SANEINCL=''SECURITYLIB=''SET_MAKE=''SHELL='/bin/bash'SOCKETLIBS=''STRIP=''TOOLSDIR=''WIN16_FILES='$(WIN16_FILES)'WIN16_INSTALL='$(WIN16_INSTALL)'WINDRES=''XFILES=''XLIB=''XMKMF=''XML2INCL=''XML2LIBS=''XSLTINCL=''XSLTLIBS=''X_CFLAGS=''X_EXTRA_LIBS=''X_LIBS=''X_PRE_LIBS=''ac_ct_AS=''ac_ct_CC='gcc'ac_ct_CXX=''bindir='${exec_prefix}/bin'build='i686-pc-linux-gnulibc1'build_alias=''build_cpu='i686'build_os='linux-gnulibc1'build_vendor='pc'datadir='${datarootdir}'datarootdir='${prefix}/share'docdir='${datarootdir}/doc/${PACKAGE_TARNAME}'dvidir='${docdir}'exec_prefix='NONE'ft_devel=''gphoto2_devel=''gphoto2port_devel=''host='i686-pc-linux-gnulibc1'host_alias=''host_cpu='i686'host_os='linux-gnulibc1'host_vendor='pc'htmldir='${docdir}'includedir='${prefix}/include'infodir='${datarootdir}/info'libdir='${exec_prefix}/lib'libexecdir='${exec_prefix}/libexec'localedir='${datarootdir}/locale'localstatedir='${prefix}/var'mandir='${datarootdir}/man'oldincludedir='/usr/include'pdfdir='${docdir}'prefix='NONE'program_transform_name='s,x,x,'psdir='${docdir}'sane_devel=''sbindir='${exec_prefix}/sbin'sharedstatedir='${prefix}/com'sysconfdir='${prefix}/etc'target_alias='' ## ------------------- #### File substitutions. #### ------------------- ## MAKE_DLL_RULES=''MAKE_IMPLIB_RULES=''MAKE_PROG_RULES=''MAKE_RULES=''MAKE_TEST_RULES='' ## ----------- #### confdefs.h. #### ----------- ## #define PACKAGE_NAME "Wine"#define PACKAGE_TARNAME "wine"#define PACKAGE_VERSION "0.9.54"#define PACKAGE_STRING "Wine 0.9.54"#define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" configure: exit 77 _________________________________________________________________ Get Hotmail on your mobile. Text MSN to 63463 now! http://mobile.uk.msn.com/pc/mail.aspx

4 3

Re: shell32: Allow ShellExecute to accept file extensions for lpClass.
by Alexandre Julliard 17 Apr '08

17 Apr '08

Michael Moss <mmoss(a)google.com> writes: > [originally a Picasa patch by Aric Stewart] In general if these patches have not been merged there was a good reason. The first step would be to write test cases for them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: installing wine into linux ubuntu
by Susan Cragin 17 Apr '08

17 Apr '08

Another way to do it, is run the following commands in a terminal before beginning: sudo apt-get build-dep wine wine-dev sudo apt-get install msttcorefonts fontforge You need a lot of things, ideally. This gets you all of them. Some places say you can get by with bison and flex and the C compiler. I don't think that's really true. -----Original Message----- >From: Lei Zhang <thestig(a)google.com> >Sent: Apr 17, 2008 1:24 PM >To: stephen cooper <stephencooper96(a)hotmail.com> >Cc: wine-devel(a)winehq.org >Subject: Re: installing wine into linux ubuntu > >On Thu, Apr 17, 2008 at 6:46 AM, stephen cooper ><stephencooper96(a)hotmail.com> wrote: >> >> ref. Linux Format DVD 104 April 2008 >> From: stephen cooper (stephencooper96(a)hotmail.com) >> I am new to Linux. >> I have just installed Linux UBUNTU 7.1 (gutsy) onto my computer with no >> problems. >> >> I want to install wine. >> I have written the source code onto my hard disc. (using tar ) >> When I run ./configure (.tools/wineinstall) I get an error - C compiler >> cannot create executables. >> I am including the output from the config.log for wine installation below. >> >> PLEASE ADVISE ME. > >Take a look at http://wiki.winehq.org/Recommended_Packages for the >list of packages needed to build Wine. If you just want to use Wine, >there's packages available for Ubuntu: >http://www.winehq.org/site/download > >

1 0

New winetricks 20080417: new verb wmp9
by Dan Kegel 17 Apr '08

17 Apr '08

Another day, another Winetricks. Changes: r34 Add Windows Media Player 9 (not really usable yet; this is for the guys implementing Quartz etc.) r33 Fixed typo that disabled curl. As always, get it at http://kegel.com/wine/winetricks or http://code.google.com/p/winezeug - Dan

1 0

Re: [1/3] [try 2] setupapi: Add a test for SetupDiGetDeviceRegistryProperty and SetupDiSetDeviceRegistryProperty
by Alexandre Julliard 17 Apr '08

17 Apr '08

Alexander Morozov <amorozov(a)etersoft.ru> writes: > Changelog: > Add a test for SetupDiGetDeviceRegistryProperty and > SetupDiSetDeviceRegistryProperty This doesn't apply because there have been other changes in that area, when resending a patch you need to first resync to the current tree. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [WinHelp]: fix regression introduced by Dmitry's Win64 warning fixes
by Alexandre Julliard 17 Apr '08

17 Apr '08

Eric Pouech <eric.pouech(a)orange.fr> writes: > index 8181469..bf942a4 100644 > --- a/programs/winhelp/hlpfile.c > +++ b/programs/winhelp/hlpfile.c > @@ -158,8 +158,8 @@ HLPFILE_PAGE *HLPFILE_PageByOffset(HLPFILE* hlpfile, LONG offset) > static int comp_PageByHash(void *p, const void *key, > int leaf, void** next) > { > - ULONG_PTR lKey = (LONG_PTR)key; > - ULONG_PTR lTest = GET_UINT(p, 0); > + LONG_PTR lKey = (LONG_PTR)key; > + LONG_PTR lTest = GET_UINT(p, 0); This won't work on 64-bit. If the hash really needs to be signed (why?) you need some extra casts. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dinput: Implement DIPROP_KEYNAME property for keyboard device
by Vitaliy Margolen 17 Apr '08

17 Apr '08

Sergey Khodych wrote: > > > ------------------------------------------------------------------------ > > > +static HRESULT WINAPI SysKeyboardAImpl_GetProperty( > ... > + if (TRACE_ON(dinput)) > + _dump_DIPROPHEADER(pdiph); Please drop the TRACE_ON check - it's being done in dump function. > ... > + hr = SysKeyboardWImpl_GetObjectInfo( (LPDIRECTINPUTDEVICE8W)iface , &didoi, > + ps->diph.dwObj, ps->diph.dwHow ); You mixing unicode and ascii. Also if you are implementing SysKeyboardAImpl_GetProperty you should also implement it's unicode counterpart SysKeyboardWImpl_GetProperty. And please use 4-space indent. Vitaliy.

2 6

Re: dinput/tests: Add test to show dinput does not use user defined data format for keyboard.
by Vitaliy Margolen 17 Apr '08

17 Apr '08

Sergey Khodych wrote: > > + hr = IDirectInputDevice_GetDeviceState(pKeyboard, sizeof(custom_state), custom_state); > + ok(SUCCEEDED(hr), "IDirectInputDevice_GetDeviceState(4,) failed: %s\n", DXGetErrorString8(hr)); > + hr = IDirectInputDevice_GetDeviceState(pKeyboard, sizeof(kbd_state), kbd_state); > + ok(hr == DIERR_INVALIDPARAM, "IDirectInputDevice_GetDeviceState(256,) should have failed: %s\n", DXGetErrorString8(hr)); When you add tests that fail on Wine, you need to add todo_wine at front of them so "make test" will still succeed. Vitaliy.

1 0

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Tomasz Jezierski - Tefnet 16 Apr '08

16 Apr '08

Dnia 30-05-2007, śro o godzinie 14:41 +0200, Alexandre Julliard pisze: > Robert Shearman <rob(a)codeweavers.com> writes: > Hi, I found this patch from May 2007 which never got into wine. http://www.winehq.org/pipermail/wine-patches/2007-May/039722.html Could you explain me what is still wrong with it? I would like to fix it. > > + p++; > > + if ((*p == 'X') || (*p == 'x')) > > + { > > + /* hexadecimal entity */ > > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > > + (*p >= 'A' && *p <= 'F')) > > + p++; > > + ch = strtolW(start + 2, NULL, 16); > > + } > > This is still broken. You said earlier: "You should exit the loop at the first ';'. Also you have to increment p first." It looks like Robert did what you said? > > > + if (p - start - 1 <= sizeof(char_refs[0].name)) > > + { > > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > > + break; > > + } > > This is still broken too. You said earlier: "The sizeof check doesn't make much sense, especially inside the loop. What you need is to check that you reached the end of the string if the strncmpW succeeded." You mean to check if *p == 0 ? While reading this patch I found another bug: + if (i == sizeof(char_refs)/sizeof(char_refs[0])) + { + FIXME("character entity %s not found\n", debugstr_wn(start + 1, p - start - 1)); + continue; + } I think *start should be changed to another char in that case, because if we will not change it, we will fall into infinite loop like it happens with help file in GPSTRACK from bug #6801. Moreover we need full entity table, one of those mentioned by Hin-Tak Leung: http://bugs.winehq.org/show_bug.cgi?id=6801#c28

2 3

Re: fusion: Explicitly check for -1 for a missing table
by Marcus Meissner 16 Apr '08

16 Apr '08

On Wed, Apr 16, 2008 at 11:48:31AM -0500, James Hawkins wrote: > Hi, > > Changelog: > * Explicitly check for -1 for a missing table. > > dlls/fusion/assembly.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > -- > James Hawkins > diff --git a/dlls/fusion/assembly.c b/dlls/fusion/assembly.c > index 024e611..eee889a 100644 > --- a/dlls/fusion/assembly.c > +++ b/dlls/fusion/assembly.c > @@ -416,7 +416,7 @@ HRESULT assembly_get_name(ASSEMBLY *assembly, LPSTR *name) > ULONG offset; > > offset = assembly->tables[0x20].offset; /* FIXME: add constants */ > - if (offset < 0) > + if (offset == -1) > return E_FAIL; > > asmtbl = (ASSEMBLYTABLE *)assembly_data_offset(assembly, offset); > @@ -527,7 +527,7 @@ HRESULT assembly_get_pubkey_token(ASSEMBLY *assembly, LPSTR *token) > *token = NULL; > > offset = assembly->tables[0x20].offset; /* FIXME: add constants */ > - if (offset < 0) > + if (offset == -1) > return E_FAIL; You should make offset "signed", or pass errors down in another way. This will not work this way. Ciao, Marcus

3 2

Re: dlls/fusion/assembly.c -- no-op error checks
by James Hawkins 16 Apr '08

16 Apr '08

On Wed, Apr 16, 2008 at 12:47 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > On Wed, 16 Apr 2008, James Hawkins wrote: > > The offsets are explicity set to -1 on line 242, so the check needs to > > be for -1. It won't work at all otherwise. > > Thanks, James! I was looking for this, but must have missed it somehow. > I'm glad I Cc:d you. :-) > > Please find the real fix below. > Beat ya to the punch :) http://winehq.org/pipermail/wine-patches/2008-April/053446.html -- James Hawkins

2 1

Re: dlls/fusion/assembly.c -- no-op error checks
by James Hawkins 16 Apr '08

16 Apr '08

On Wed, Apr 16, 2008 at 9:28 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > Both offset and tables[].offset are of unsigned types, so these two > checks for errors will never trigger. > The offsets are explicity set to -1 on line 242, so the check needs to be for -1. It won't work at all otherwise. -- James Hawkins

1 0

.NET 2.0 problematic DLL loading.
by Rhys McGuckin 16 Apr '08

16 Apr '08

In reference to bug #11973, I've the following observation. Using the native .NET 2.0 installed via winetricks, I located what is potentially a problem with the method that .NET is using to locate the DLLs that it wishes to load. The problem seems to be that .NET is attempting to locate the various DLL's it is going to use, by searching various directory paths. Once this does not occur (by placing a native DLL into the windows/system32 path) it causing a crash further down. It doesn't seem to utilize the LoadLibrary initially to locate but another function (from memory I think it NtCreateFile). With the native DLL in place it starts to process properly, at least until it runs into other files not located (as stated above). I believe that .NET 2.0 is assuming that the files are located within the directory path (this may be so that it can independently utilize application supplied DLL files - I read that WinXP supposedly uses this policy to reduce problems with DLL dependencies). This of course, totally by-passes the built-in DLL files (which should be located using this method, except that they do not exist in the paths .NET searches). There are two possible ways currently that I can think of, which would potentially solve this problem: 1. Have symbolic links within the system directory (I find this to be bad method, for multiple reasons) 2. Have some interception of the searching for files located within the system32, to include all of built-in dlls. Unfortunately, since I don't know a huge amount about Wine yet, I have no idea on how to code the second one, and I think having a patch for this, may solve quite a few problems that currently exist with using .NET based programs. --------------------------------- Get the name you always wanted with the new y7mail email address.

2 2

re: Including Mono within a Wine package - should Wine expect this?
by Dan Kegel 16 Apr '08

16 Apr '08

A wine-gecko package would be very useful. Wine-mono on the other hand is probably premature. How many apps are helped at the moment by winetricks mono12 ? I don't think it's a large number. The wine-gecko package should just be a repackaging of the same blob that is normally downloaded, at least until we figure out how to do a proper cross-build.

9 19

Help with configure option
by Alistair Leslie-Hughes 16 Apr '08

16 Apr '08

Hi, I need to add an option, HAS_TEXTCONCAT_BUG to the configure script to check for a bug in libxml. What file(s) do I have to change? The file attached is an example to test for this issue. (returns -1 if the error exists) Best Regards Alistair Leslie-Hughes

2 1

Re: [Fwd: Bug#476232: winebuild fails to build for powerpc]
by Alexandre Julliard 16 Apr '08

16 Apr '08

Ove Kaaven <ovek(a)arcticnet.no> writes: > @@ -368,7 +368,7 @@ void BuildSpec32File( DLLSPEC *spec ) > else > { > output( "\n\t.section \".init\",\"ax\"\n" ); > - output( "\tjmp 1f\n" ); > + output( "\t%s 1f\n", get_asm_branch_mnemonic() ); > output( "__wine_spec_pe_header:\n" ); > output( "\t.skip %u\n", 65536 + page_size ); > output( "1:\n" ); I don't think it makes sense to add functions that return specific asm mnemonics, there's no guarantee that all platforms would use a single jump instruction here. You should add a switch the way it is done for instance in output_asm_constructor(). -- Alexandre Julliard julliard(a)winehq.org

1 0

imm32: Implement the ImmSetConversionStatus.
by ByeongSik Jeon 16 Apr '08

16 Apr '08

Tested with "MS IME 2002(imekr61.ime)", "MS IME 2003(imekr70.ime)", and "Saenaru(saenaru.ime, Korean Free IME)". --- dlls/imm32/imm.c | 29 ++++++++++++++++++++--------- 1 files changed, 20 insertions(+), 9 deletions(-)

1 0

Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498
by Juan Lang 16 Apr '08

16 Apr '08

> Have you tried patch without this "if"? In my case it crashes without it > when I try to open chm from bug #12498... i don't know if strdupW can > dup NULL as well as null? Aaaah... Sorry, my mistake, I missed this declaration: static const WCHAR null[] = {0}; That solves that mystery. In that case, one fix per patch, please. This fix and the other are unrelated: one fixes a crash, the other deals with a missing #STRINGS stream. Thanks, --Juan

3 3

ddiwrapper 0.3rc1
by Hin-Tak Leung 16 Apr '08

16 Apr '08

I have uploaded my mod'ed version of ddiwrapper to http://www.linuxprinting.org/download/ddiwrapper/ and called it 0.3rc1. There are some stub codes which I added to try to get the Konica-Minolta MC2500W XP driver to work without success, so they probably should be taken out, but they are fairly harmless and maybe useful to somebody else. I tried one of the Canon drivers and ddiwrapper worked as advertised. I have updated the change log and also added the following paragraph to the bottom of the README: For Wine releases between Feb/March 2006 up to time of writing (April 2008), it is necessary to comment out one line in the wine loader code to make ddiwrapper work: ==================================================== diff --git a/libs/wine/loader.c b/libs/wine/loader.c index 0f05f0c..743d487 100644 --- a/libs/wine/loader.c +++ b/libs/wine/loader.c @@ -117,7 +117,7 @@ static void build_dll_path(void) if (dlldir) { dll_path_maxlen = strlen(dlldir); - dll_paths[nb_dll_paths++] = dlldir; + /* dll_paths[nb_dll_paths++] = dlldir; */ } else if ((build_dir = wine_get_build_dir())) { ==================================================== ___________________________________________________________ Yahoo! For Good helps you make a difference http://uk.promotions.yahoo.com/forgood/

1 0

Something strange: installers not waiting for subinstallers any more?
by Dan Kegel 16 Apr '08

16 Apr '08

I just installed Photoshop CS2 trial using yesterday morning's cvs, and there seemed to be two odd failure: 1) gecko didn't install properly 2) the outer installer declared victory way before the inner installer was done unpacking Mysterious, very mysterious. Ah, well, I'll close my eyes and hope it goes away :-)

1 0

quartz: FOURCC Error in compiling
by Sònia Xapellí Brú 15 Apr '08

15 Apr '08

When I try to compile the wine tree of today I get an error compiling avisplit.o: There is no rule to build fourcc.h needed for avisplit.o /make[2]: *** No hay ninguna regla para construir el objetivo `fourcc.h', necesario para `avisplit.o'. Alto. make[2]: se sale del directorio `/wine-git/dlls/quartz' make[1]: *** [quartz] Error 2 make[1]: se sale del directorio `/wine-git/dlls' make: *** [dlls] Error 2 /

2 1

Re: dinput: Remove unused variables
by Robert Shearman 15 Apr '08

15 Apr '08

Andrew Talbot wrote: > @@ -142,13 +142,12 @@ static INT find_joystick_devices(void) > { > CHAR device_name[MAX_PATH], *str; > INT len; > - int fd; > > len = sprintf(device_name, "%s%d", JOYDEV_NEW, i) + 1; > - if ((fd = open(device_name, O_RDONLY)) < 0) > + if (open(device_name, O_RDONLY) < 0) > { > len = sprintf(device_name, "%s%d", JOYDEV_OLD, i) + 1; > - if ((fd = open(device_name, O_RDONLY)) < 0) continue; > + if (open(device_name, O_RDONLY) < 0) continue; > } > > if (!(str = HeapAlloc(GetProcessHeap(), 0, len))) break; Again, this needs to be fixed in another way as fd is being leaked. -- Rob Shearman

2 1

Re: browseui: Remove unused variables
by Robert Shearman 15 Apr '08

15 Apr '08

Andrew Talbot wrote: > @@ -299,7 +299,6 @@ static HRESULT WINAPI ProgressDialog_StartProgressDialog(IProgressDialog *iface, > { > ProgressDialog *This = (ProgressDialog *)iface; > struct create_params params; > - HANDLE hThread; > > TRACE("(%p, %p, %x, %p)\n", iface, punkEnableModeless, dwFlags, reserved); > if (punkEnableModeless || reserved) > @@ -321,7 +320,7 @@ static HRESULT WINAPI ProgressDialog_StartProgressDialog(IProgressDialog *iface, > params.hwndParent = hwndParent; > params.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); > > - hThread = CreateThread(NULL, 0, dialog_thread, &params, 0, NULL); > + CreateThread(NULL, 0, dialog_thread, &params, 0, NULL); > WaitForSingleObject(params.hEvent, INFINITE); > > This->hwndDisabledParent = NULL; A correct fix is to call CloseHandle(hThread), otherwise the handle is leaked. -- Rob Shearman

2 1

Re: comctl32: Remove unused variables
by Robert Shearman 15 Apr '08

15 Apr '08

Andrew Talbot wrote: > @@ -967,16 +967,14 @@ static HFONT SYSLINK_SetFont (SYSLINK_INFO *infoPtr, HFONT hFont, BOOL bRedraw) > */ > static LRESULT SYSLINK_SetText (SYSLINK_INFO *infoPtr, LPCWSTR Text) > { > - int textlen; > - > /* clear the document */ > SYSLINK_ClearDoc(infoPtr); > - > - if(Text == NULL || (textlen = lstrlenW(Text)) == 0) > + > + if(Text == NULL || lstrlenW(Text) == 0) > { > A better fix would be to use "*Text == 0" instead of "lstrlenW(Text) == 0". -- Rob Shearman

1 0

RFC: Fix for IWineMsiRemotePackage::FormatRecord
by Robert Shearman 15 Apr '08

15 Apr '08

Hi, Currently, the [out] value parameter for IWineMsiRemotePackage::FormatRecord doesn't have a level of indirection associated with it and so I would be very surprised if the typelib marshaller actually does the right thing in this case. Compiling with MIDL and with a future update to widl causes an error for this parameter. I'm proposing the attached patch to fix things, but I'm not able to test that this works correctly. Thanks, -- Rob Shearman

2 1

Full Screen Desktop Mode
by Jeremy Newman 15 Apr '08

15 Apr '08

Here is a feature request that I'd had in my head for quite some time now. I don't usually pass my crazy ideas on down through the devel pipe, but I feel this one is too good to pass up on. Many of us still use desktop mode to get around issues with various window managers (compiz, metacity, etc). But running a game in desktop mode, you loose out on running full screen. It would be slick if the Wine desktop could be switched into full screen on the fly with a hotkey (say Ctrl + Alt + Enter). So if you are running a 1280x800 Wine desktop on a 1680x1050 screen, and you hit the hotkey, the resolution would be switched to 1280x800 and the Wine desktop is your screen until you hit the hotkey to switch back, or you exit the program. Sound fun?

1 0

Feature Request: Registry / winecfg entry for launching an application in a wineexplorer window
by Scott Ritchie 15 Apr '08

15 Apr '08

I have a few full screen applications that I'd like to run contained in small windows. Currently, in order to run them this way, I have to either open winecfg and set a virtual desktop or launch the application on the terminal with: wine explorer /desktop=name,1024x768 app.exe What I'd like is something that does this for me similar to app defaults. That way I could run the application by double clicking it (or from the shortcut in the start menu) and have it contained in the window I want. Ideally I'd be able to enable this setting from a right click->properties menu, however that work isn't necessarily needed within Wine other than support for modifying this new key using something like reg.exe on the terminal. It seems like it'd be fairly simple to implement, too. Any thoughts? Thanks, Scott Ritchie

6 7

Re: [WineHQ] Assorted spelling fixes.
by Jeremy Newman 15 Apr '08

15 Apr '08

This patch does not apply for me, I get the following errors: jnewman@jnewman:/home/httpd/html/winehq_org$ git am ~/Downloads/patch.eml Applying Assorted spelling fixes. .dotest/patch:38: trailing whitespace. between GDI/USER and the KERNEL, that is not absolutely needed, must be .dotest/patch:47: trailing whitespace. <quote who="Patrick Stridvall">I think your original suggestion making Wine .dotest/patch:60: trailing whitespace. not very optimized so I wouldn't be surprised if it is _much_ slower. .dotest/patch:69: trailing whitespace. Ove's pthread hack is a good way to make more libc functions usable .dotest/patch:82: trailing whitespace. It is of course also possible to override these settings by explicitly using Wine's --dll command-line error: patch failed: wwn/wn19990627_2.xml:474 error: wwn/wn19990627_2.xml: patch does not apply error: patch failed: wwn/wn19990718_4.xml:394 error: wwn/wn19990718_4.xml: patch does not apply error: patch failed: wwn/wn20000605_46.xml:364 error: wwn/wn20000605_46.xml: patch does not apply error: patch failed: wwn/wn20001106_68.xml:566 error: wwn/wn20001106_68.xml: patch does not apply error: patch failed: wwn/wn20010718_100.xml:342 error: wwn/wn20010718_100.xml: patch does not apply error: patch failed: wwn/wn20011021_106.xml:422 error: wwn/wn20011021_106.xml: patch does not apply error: patch failed: wwn/wn20020308_117.xml:720 error: wwn/wn20020308_117.xml: patch does not apply error: patch failed: wwn/wn20030103_151.xml:437 error: wwn/wn20030103_151.xml: patch does not apply error: patch failed: wwn/wn20030228_159.xml:566 error: wwn/wn20030228_159.xml: patch does not apply error: patch failed: wwn/wn20030725_180.xml:165 error: wwn/wn20030725_180.xml: patch does not apply error: patch failed: wwn/wn20030829_185.xml:381 error: wwn/wn20030829_185.xml: patch does not apply error: patch failed: wwn/wn20041022_245.xml:162 error: wwn/wn20041022_245.xml: patch does not apply error: patch failed: wwn/wn20041126_250.xml:337 error: wwn/wn20041126_250.xml: patch does not apply error: patch failed: wwn/wn20050415_270.xml:257 error: wwn/wn20050415_270.xml: patch does not apply error: patch failed: wwn/wn20050506_273.xml:354 error: wwn/wn20050506_273.xml: patch does not apply error: patch failed: wwn/wn20050819_288.xml:286 error: wwn/wn20050819_288.xml: patch does not apply error: patch failed: wwn/wn20051014_294.xml:155 error: wwn/wn20051014_294.xml: patch does not apply error: patch failed: wwn/wn20051125_299.xml:294 error: wwn/wn20051125_299.xml: patch does not apply error: patch failed: wwn/wn20060226_306.xml:208 error: wwn/wn20060226_306.xml: patch does not apply error: patch failed: wwn/wn20060410_311.xml:321 error: wwn/wn20060410_311.xml: patch does not apply error: patch failed: wwn/wn20060428_312.xml:287 error: wwn/wn20060428_312.xml: patch does not apply error: patch failed: wwn/wn20070416_329.xml:304 error: wwn/wn20070416_329.xml: patch does not apply Patch failed at 0001. When you have resolved this problem run "git-am --resolved". If you would prefer to skip this patch, instead run "git-am --skip". Francois Gouget wrote: > --- > > The attachement will probably look a bit strange but it should work > anyway. > > wwn/wn19990627_2.xml | 4 ++-- > wwn/wn19990718_4.xml | 4 ++-- > wwn/wn20000605_46.xml | 2 +- > wwn/wn20001106_68.xml | 2 +- > wwn/wn20010718_100.xml | 2 +- > wwn/wn20011021_106.xml | 2 +- > wwn/wn20020308_117.xml | 2 +- > wwn/wn20030103_151.xml | 6 +++--- > wwn/wn20030228_159.xml | 2 +- > wwn/wn20030725_180.xml | 2 +- > wwn/wn20030829_185.xml | 4 ++-- > wwn/wn20041022_245.xml | 2 +- > wwn/wn20041126_250.xml | 2 +- > wwn/wn20050415_270.xml | 2 +- > wwn/wn20050506_273.xml | 4 ++-- > wwn/wn20050819_288.xml | 2 +- > wwn/wn20051014_294.xml | 2 +- > wwn/wn20051125_299.xml | 2 +- > wwn/wn20060226_306.xml | 2 +- > wwn/wn20060410_311.xml | 2 +- > wwn/wn20060428_312.xml | 4 ++-- > wwn/wn20070416_329.xml | 2 +- > 22 files changed, 29 insertions(+), 29 deletions(-) > > > ------------------------------------------------------------------------ > >

1 0

quartz: FOURCC Error in compiling
by Luis Busquets 15 Apr '08

15 Apr '08

When I try to compile the wine tree of today I get an error compiling avisplit.o: There is no rule to build fourcc.h needed for avisplit.o /make[2]: *** No hay ninguna regla para construir el objetivo `fourcc.h', necesario para `avisplit.o'. Alto. make[2]: se sale del directorio `/wine-git/dlls/quartz' make[1]: *** [quartz] Error 2 make[1]: se sale del directorio `/wine-git/dlls' make: *** [dlls] Error 2 /

2 1

Re: d3dx9_36: Add stubs and implementations for D3DXCreateTexturexx
by tony.wasserka＠freenet.de 15 Apr '08

15 Apr '08

Hi, Are you still working on the texture functions? I'd need them for completing my ID3DXSprite implementation, so if you don't mind I could complete your started patches. Best regards, Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

3 2

Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498
by Juan Lang 15 Apr '08

15 Apr '08

> > In that case, one fix per patch, please. This fix and the other are > > unrelated: one fixes a crash, the other deals with a missing #STRINGS > > stream. Thanks, > > No, I think that crash is only possible with my patch. Right now if > there is no #STRINGS it closes chm and stops processing. Okay, I understand. Your patch looks fine to me then. You may wish to resend, Alexandre may have other ideas ;-) --Juan

1 0

Unimplemented ntoskrnl functions ?
by Pavel Troller 15 Apr '08

15 Apr '08

Hi! I'm solving the following problem: I would like to run the "Tibbo Device Server Toolkit" (TDSK) - see http://www.tibbo.com/get_dst.php During installation of the product on a fresh wine (the last Sunday's git) with a fresh .wine directory, it crashes with the following report: wine: Call from 0x7b841720 to unimplemented function ntoskrnl.exe.KeInitializeEvent, aborting wine: Unimplemented function ntoskrnl.exe.KeInitializeEvent called at address 0x7b841720 (thread 0021), starting debugger... Unhandled exception: unimplemented function ntoskrnl.exe.KeInitializeEvent called in 32-bit code (0x7b841796). Is this function hard to implement ? I'm somewhat experienced with Linux programming, but I know absolutely nothing about windoze. After a lot of time, if wineserver -k isn't applied, it reports another two unimplemented functions - KeInitializeInterrupt and KeInitializeMutant. What about these ? With regards, Pavel Troller

2 2

Re: d3dx9: Add d3dx9tex.h
by H. Verbeet 15 Apr '08

15 Apr '08

On 15/04/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > > +#ifndef __WINE_D3DX9TEX_H > +#define __WINE_D3DX9TEX_H ... > +#endif /* __WINE_D3DX9CORE_H */ I didn't look at the rest of the patch in detail, but the comment there doesn't match the actual #ifndef.

1 0

Re: [WineHQ][WWN] WWN 345
by Dmitry Timoshkov 15 Apr '08

15 Apr '08

"Zachary Goldberg" <zgs(a)seas.upenn.edu> wrote: > +<section > + title="News: new WineTricks, 1.0 status updates and more" > + subject="Wine" > + archive="http://www.xkcd.com" > + posts="0" > +> How is the url above related to the title? -- Dmitry.

2 1

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Alexandre Julliard 15 Apr '08

15 Apr '08

Robert Shearman <rob(a)codeweavers.com> writes: > + p++; > + if ((*p == 'X') || (*p == 'x')) > + { > + /* hexadecimal entity */ > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > + (*p >= 'A' && *p <= 'F')) > + p++; > + ch = strtolW(start + 2, NULL, 16); > + } This is still broken. > + if (p - start - 1 <= sizeof(char_refs[0].name)) > + { > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > + break; > + } This is still broken too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Bug with duplex printing
by Vitaly Perov 15 Apr '08

15 Apr '08

Hi all, I'm sorry. My English is not so good. There is a bug. I have some idia how to solve it. I'm sure it's not good way to solve this problem. The bug is the following: You print one page with duplex printing, and the number of copies is 2. The second page must be printed on the next page, but it is printed on the another side of this page. This bug appears if an application is responsible for printing (almost always) I have tried to print the following documents (duplex printing) into the file: 1) Document consists of 1 page, number of copies is 2; 2) Document consist of 2 pages, number of copies is 1; Then I have compared theese documents with diff. The documens differ only in some strings (date of creation)! I have tried the same test in OpenOffice. The results is the same! I want to try this in Windows, but i can find a printer which can generate PostScript and supports Duplex mode. The is several ways to solve it. Application is responsible for printing. We print 2 copies and the number of pages is 1, 3, 5... etc. So after sending the first copy of document it must "tell" to the Windows/Wine, that new page must start from the new sheet of paper. I think the are 2 ways: 1) The is special WINAPI function, that application call 2) The empty page after each copy of the document. It can be inserted by application or Windows/Wine. I find out that there is no special WINAPI, so this bug can be solved only by inserting of empty page. I have ascertained that the application a'm testing never asks whether printer support duplex. So I have decided, that Windows/Wine must insert empty page. But the Windows/Wine can't get to know the number of pages, that application is going to print. So I think, its only one way to add an empty page: We must catch EndDoc, then scan the PostScript and count number of pages it is going to print. Then we devide number of pages over number of copies, and determine number of pages in one copy of the document. Then, if number of pages is 1, 3, 5 .. etc. we rescan the PostScript document, and insert empty page after last page of each copy. I'm sure it's not good way to solve this problem. So, if anybody have something to say, I would be appreciate. Thank you. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

1 0

Re: ws2_32: Work around the host name resolving to 127.x.x.x when using that for binding.
by Christoph Frick 15 Apr '08

15 Apr '08

On Mon, Apr 14, 2008 at 04:05:23PM +0200, Kai Blin wrote: Hi Kai, et all, > +static const char magic_loopback_addr[] = {127, 12, 34, 56}; in the past wine used to work quite well with the ip-address configured using the places in the windows registry (msdn or something similar kept an howto for setting the ips in win98 and 2k (and look alikes)). now that wine tries to get its ip from the /etc/hosts (or whereever?) i noticed some problems with hosting games. as msdn keeps firing errors at me i go and ask the list about this. i always though windows (at least until xp?) is not capable of listening to requests bound to an ip/interface? with the recent changes the games listen to lo0 and will never ever accept anything. i had to change my /etc/hosts now to make it work again; yet it will fail with more than one nic (i have to change /etc/hosts again). long story short: - does any windows version at all support the idea behind giving an ip to listen for connections like unix/linux/bsd does? - and even if: who runs some windows software in wine that needs this features and is not able to fix the problem with the firewall or other restrictions on the unix end? if no: what would be needed to change the listening to 0.0.0.0 by default? a patch and a test? -- cu

3 4

Re: start.exe: updated French translation
by Alexandre Julliard 15 Apr '08

15 Apr '08

Jonathan Ernst <jonathan(a)ernstfamily.ch> writes: > @@ -24,41 +24,42 @@ LANGUAGE LANG_FRENCH, SUBLANG_NEUTRAL > > STRINGTABLE DISCARDABLE > { > -STRING_USAGE, "Lance un programme, ou ouvre un document dans le programme normalement utilisé avec cette extension. \n\ > +STRING_USAGE, "Lance un programme, ou ouvre un document dans le programme normalement utilisÃ© avec cette extension. \n\ If you are converting the file to utf-8 you also have to add the appropriate pragmas. -- Alexandre Julliard julliard(a)winehq.org

1 0

[Fwd: Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498]
by Tomasz Jezierski - Tefnet 15 Apr '08

15 Apr '08

ups.. forgot to CC: -------- Przekazywana wiadomość ---------- Od: Tomasz Jezierski - Tefnet <developers(a)tefnet.pl> Do: Juan Lang <juan.lang(a)gmail.com> Temat: Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498 Data: Tue, 15 Apr 2008 08:31:23 +0200 Dnia 14-04-2008, pon o godzinie 16:58 -0700, Juan Lang pisze: > Hi Tomasz, > > - info->WinType.pszToc = strdupW(info->pCHMInfo->defToc); > + info->WinType.pszToc = strdupW(info->pCHMInfo->defToc ? > info->pCHMInfo->defToc : null); > Sorry, didn't know that... I saw that "small" null is used one line under: info->WinType.pszIndex = strdupW(null); so I used it too. Have you tried patch without this "if"? In my case it crashes without it when I try to open chm from bug #12498... i don't know if strdupW can dup NULL as well as null?

1 0

error: `XICCallback' undeclared (Solaris build problem)
by Petr Sumbera 15 Apr '08

15 Apr '08

Hi all, It seems that following change from last Friday broke Solaris build: http://source.winehq.org/git/wine.git/?a=commitdiff;h=185157cb6eb25bc5e75e9… This is probably because Solaris /usr/include/X11/Xlib.h doesn't define XICCallback. -bash-3.2$ grep XICCallback /usr/include/X11/Xlib.h -bash-3.2$ Compilation error is following: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -std=gnu99 -o xim.o xim.c xim.c: In function `X11DRV_DestroyIM': xim.c:371: warning: passing arg 5 of `XRegisterIMInstantiateCallback' from incompatible pointer type xim.c: In function `X11DRV_OpenIM': xim.c:398: warning: assignment from incompatible pointer type xim.c:475: warning: passing arg 5 of `XUnregisterIMInstantiateCallback' from incompatible pointer type xim.c: In function `X11DRV_SetupXIM': xim.c:485: warning: passing arg 5 of `XRegisterIMInstantiateCallback' from incompatible pointer type xim.c: In function `X11DRV_CreateIC': xim.c:504: error: `XICCallback' undeclared (first use in this function) xim.c:504: error: (Each undeclared identifier is reported only once xim.c:504: error: for each function it appears in.) xim.c:504: error: syntax error before "destroy" xim.c:500: warning: unused variable `spot' xim.c:501: warning: unused variable `preedit' xim.c:502: warning: unused variable `status' xim.c:503: warning: unused variable `xic' ... Any idea or comment to this? Thanks, Petr

4 7

Re: [1/2] shlwapi: Fixed the todo blocks in the SHCreateStreamOnFile tests. [try 2]
by Alexandre Julliard 15 Apr '08

15 Apr '08

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > @@ -120,12 +119,12 @@ static HRESULT WINAPI IStream_fnRead(IStream *iface, void* pv, ULONG cb, ULONG* > TRACE("(%p,%p,0x%08x,%p)\n", This, pv, cb, pcbRead); > > if (!pv) > - return STG_E_INVALIDPOINTER; > + return S_OK; It's very unlikely that this is the correct behavior in all cases. > @@ -459,7 +458,9 @@ HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR lpszPath, DWORD dwMode, > switch(STGM_CREATE_MODE(dwMode)) > { > case STGM_FAILIFTHERE: > - dwCreate = OPEN_EXISTING; > + if (bCreate && PathFileExistsW(lpszPath)) > + return HRESULT_FROM_WIN32(ERROR_FILE_EXISTS); > + dwCreate = bCreate ? CREATE_ALWAYS : OPEN_EXISTING; That case should be handled by CreateFile, you shouldn't check for the file existence explicitly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498
by Juan Lang 14 Apr '08

14 Apr '08

Hi Tomasz, - info->WinType.pszToc = strdupW(info->pCHMInfo->defToc); + info->WinType.pszToc = strdupW(info->pCHMInfo->defToc ? info->pCHMInfo->defToc : null); Please don't use null, it's not portable. Also, what has this change accomplished? If strdupW succeeds when passed NULL, the existing line would already have done the same thing, so you've added a test for no benefit. --Juan

1 0

Re: winex11: Standardize a stub trace and add a trailing '\n'.
by Stefan Leichter 14 Apr '08

14 Apr '08

Am Monday 14 April 2008 01:01 schrieb Francois Gouget: > --- > + FIXME("(%p, %x): stub\n"); You forgot the parameters hIMC and fFlag Bye Stefan

1 0

Re: [PATCH 1/6] includes: update aviriff header file
by Alexandre Julliard 14 Apr '08

14 Apr '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -161,4 +186,135 @@ typedef struct _avimetaindex > DWORD adwIndex[0]; > } AVIMETAINDEX; > > -/* FIXME: index structures missing */ > +#define ckidAVISUPERINDEX FCC('i','n','d','x') > +typedef struct _avisuperindex { > + FOURCC fcc; > + UINT cb; > + WORD wLongsPerEntry; > + BYTE bIndexSubType; > + BYTE bIndexType; > + DWORD nEntriesInUse; > + DWORD dwChunkId; > + DWORD dwReserved[3]; > + struct _avisuperindex_entry { > + DWORDLONG qwOffset; > + DWORD dwSize; > + DWORD dwDuration; > + } aIndex[0]; > +} AVISUPERINDEX; Zero-size arrays are not portable, and this is not what the MS header does anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: gdiplus: (try2) GdipCloneStringFormat
by Juan Lang 14 Apr '08

14 Apr '08

Hi Nikolay, +GpStatus WINGDIPAPI GdipCloneStrinFormat(GDIPCONST Typo: s/StrinFormat/StringFormat/ --Juan

1 0

Re: IWineD3DBaseTextureImpl_SetAutoGenFilterType missing break inside switch
by Stefan Dösinger 14 Apr '08

14 Apr '08

Am Montag, 14. April 2008 17:16:25 schrieb Hoehle, Joerg-Cyril: > Hi, > > regardless of issue > http://bugs.winehq.org/show_bug.cgi?id=11167 > which suggests that the function is incorrect it its use of GL parameters, > so it needs fixing, you may wish to apply the following (minor) patch. > > dlls/wined3d/basetexture.c:IWineD3DBaseTextureImpl_SetAutoGenFilterType > missing break inside switch The patch looks ok.

1 0

ws2_32: Work around the host name resolving to 127.x.x.x when using that for binding.
by Kirill K. Smirnov 14 Apr '08

14 Apr '08

Hi, nitpick: > + /* Trying to bind to the default hots interface, using Typo in word 'host'? -- Kirill

2 1

Lug Radio Live 2008 wine talk. Slides online, comments welcome.
by Dan Kegel 14 Apr '08

14 Apr '08

I'm going to be giving a Wine talk at LugRadio Live 2008, April 12-13, in San Francisco. My talk is Saturday at 2:30; see http://lugradio.org/live/USA2008/schedule In a mixup at my favorite coffeehouse today (Stir Crazy), I was accidentally overcaffeinated, and wrote my entire presentation in about one sitting. It's online at http://kegel.com/wine/lugradiolive2008/ The slides are pretty basic; I'll talk a lot around them. If anybody feels like reviewing the slides and giving feedback, I'd appreciate it. If anybody's planning on attending the event, let's get together for lunch or coffee or something. - Dan

3 2

Re: wine.info add fake dlls for msacm32.drv and midimap.dll
by Dmitry Timoshkov 14 Apr '08

14 Apr '08

"Steven Edwards" <winehacker(a)gmail.com> wrote: > trace:winmm:DllMain 0x7e250000 0x1 (nil) > trace:winmm:MMDRV_Init () trace:winmm:MMDRV_Install > ('winealsa.drv', 'winealsa.drv', mapper=N); > warn:winmm:MMDRV_Install Couldn't open driver 'winealsa.drv' > trace:winmm:MMDRV_Install ('wineoss.drv', 'wineoss.drv', > mapper=N); warn:winmm:MMDRV_Install Couldn't open driver 'wineoss.drv' > trace:winmm:MMDRV_Install ('winecoreaudio.drv', > 'winecoreaudio.drv', mapper=N); warn:winmm:MMDRV_Install > Couldn't open driver 'winecoreaudio.drv' > trace:winmm:MMDRV_Install ('wavemapper', 'msacm32.drv', > mapper=Y); warn:winmm:MMDRV_Install Couldn't open driver 'msacm32.drv' > trace:winmm:MMDRV_Install ('midimapper', 'midimap.dll', > mapper=Y); warn:winmm:MMDRV_Install Couldn't open driver 'midimap.dll' > > With this patch the firefox thinstall demo bug 10905 now works. I > expect there may be other problems with other thinstall applications > as he thinks there may be some changes that need to be done on their > end to better accommodate Wine. I don't know if this really should be > the case as it works on Windows and we should try to mimic that > behavior. DLLs are being added to wine.inf only if an app does check for a dll existence, which is not the case here. You need to investigate further what is going on. -- Dmitry.

3 3

Re: shell32: implement SHGetFolderPathAndSubDirA/W [2nd resend]
by Alexandre Julliard 14 Apr '08

14 Apr '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + if (pszSubPath && (length = MultiByteToWideChar(CP_ACP, 0, pszSubPath, -1, NULL, 0))) { > + pszSubPathW = HeapAlloc(GetProcessHeap(), 0, length * sizeof(WCHAR)); > + if(!pszSubPathW) > + return HRESULT_FROM_WIN32(ERROR_NOT_ENOUGH_MEMORY); You are leaking memory on error. Also I don't think it makes sense to test the return value of MultiByteToWideChar, it shouldn't fail in this case (or if you test it, then you need to handle the error properly, not use an empty path instead). -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: WineD3D: WineD3D: Use the shader backend to enable / disable atifs and nvts
by Stefan Dösinger 14 Apr '08

14 Apr '08

Am Freitag, 11. April 2008 00:31:13 schrieb Stefan Dösinger: > The drawback of this is that now the workaround for the mesa atifs bug > minimally affects nvidia cards too. It's a bit tricky to design around > driver bugs :-/ Use this patch instead, the last one had a small but pretty bad bug that broken GLSL

4 25

Wine 1.0 status: T minus 61 days, 69 bugs to go
by Dan Kegel 14 Apr '08

14 Apr '08

19 days to code freeze (!) Big news of the week is an apparant regression in one of the release criteria apps. Also, happily, two bugs I had pushed off to 1.2 got fixed anyway (demonstrating the honorary nature of the release manager position :-) Changes since last week: Deferred earlier, but fixed anyway: 3534 user32 14 Systray icons are not transparent... Deferred earlier, but patch that really fixes it submitted, so undeferred: 10905 shell32 0 thinstall firefox demo requires native msvcrt Deferred: 6254 richedit 4 Installer infinite loop from rich text error New: 12561 -unknown 0 Photoshop CS alt key for clone/healing - possible regression Here's the full list of current bugs: 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 3 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 4372 comctl32 1 listview: cannot drag several items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 17 Planescape:Torment doesn't work 9030 directx- 0 army men hangs on black screen 11681 directx- 17 Add support for video overlay 3270 gdi32 15 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 42 Steam Friends doesn't work (fails to render correctly or refresh) 5024 kernel32 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5351 kernel32 11 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 9484 kernel32 19 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 8783 ntdll 13 USB serial ports do not work 9356 ntdll 8 Serial communication not working since wine-0.9.33 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 6607 ole 10 Drag and Drop not working 8095 ole 0 PQ Teaching toy crashes 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 5163 setupapi 13 Office XP 2002 crashes on installation 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 13 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 4 Temple of Elemental Evil demo doesn't start - gui irresponsive 8439 shell32 8 Visual Studio .NET (7) install fails 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 3 Ship icons for the wine-tools that can be used in .desktop files 12561 -unknown 0 Photoshop CS alt key for clone/healing - possible regression 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 12 tray minimize 5948 -unknown 1 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 7477 -unknown 1 Uplink demo crashes 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 8 "hello world" dos program hangs 9916 -unknown 6 "make test" usually fails 9959 -unknown 9 Make wine updates work even if the registry changed 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 11281 -unknown 4 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 664 user32 7 The help menu functionality inside programs is broken (messaging problem) 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 5623 winex11. 4 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 25 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 10984 winex11. 5 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 3 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5625 wininet 4 Wine does not handle internet proxy settings conveniently 9787 winsock 47 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 1 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

2 1

Better sound support
by Kacper Pluta 13 Apr '08

13 Apr '08

Hey, do you plan on enabling handling of 24bit sound and sampling frequencies 96000 or 192000? Lots of musicians using Linux need to use VST and VSTi plugins (through FST and other methods). Unfortunately quality of music you can acquire isn't realy high if you wish to use it professionally. I'd also suggest correcting MIDI handling and integrating wine with wineasio, which would enable using VST and VSTi on a quite high level, as well as use other programmes.

3 2

cachedmetrics - still used?
by Austin English 13 Apr '08

13 Apr '08

Looking at documentation/PACKAGING, it seems there's quite a bit of outdated info (hasn't been updated in 2-3 years...). Anywho, I'm preparing a few updates for it, but wanted to verify that cachedmetrics is no longer used. There's a few references to it on AppDB, but only one reference in the code, and a few on wine-devel (all of which are pretty old). Is it safe to remove this info? -Austin

2 2

Re: [5/6] winspool: Implement DeleteFormA/W
by Detlef Riekenberg 13 Apr '08

13 Apr '08

On So, 2008-04-13 at 02:18 +0200, Marcel Partap wrote: > + formNameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, pFormName, -1, formNameW, len); > + return DeleteFormW(hPrinter, formNameW); Memory-leak: formnameW -- By by ... Detlef

1 0

Re: [3/6] winspool: Implement AddFormA/W for level 1 forms
by Detlef Riekenberg 13 Apr '08

13 Apr '08

On So, 2008-04-13 at 02:18 +0200, Marcel Partap wrote: > + * > + * FIXME: no level 2 support > + * > */ > BOOL WINAPI AddFormW(HANDLE hPrinter, DWORD Level, LPBYTE pForm) "FIXME:" is not a valid section in our API-Documentation Please use "NOTES" or "BUGS" -- By by ... Detlef

1 0

Re: [2/6] winspool/tests: Add tests for AddForm
by Detlef Riekenberg 13 Apr '08

13 Apr '08

On So, 2008-04-13 at 02:18 +0200, Marcel Partap wrote: > Subject: [PATCH] winspool/tests: Add tests for AddForm A test for AddForm / DeleteForm can't work with the stubs in our "winspool.drv". The implementation is needed first. > + SetLastError(MAGIC_DEAD); Plase do not use MAGIG_DEAD, it was a mistake in my first Patchset. Use the real Value instead. > + res = AddFormA(NULL, 0, NULL); > + RETURN_ON_DEACTIVATED_SPOOLER(res); > + ok( !res && (GetLastError() == ERROR_INVALID_LEVEL), > + "returned %d with %d (expected '0' with ERROR_INVALID_LEVEL)\n", res, GetLastError()); > + > + SetLastError(MAGIC_DEAD); > + res = AddFormA((HANDLE)MAGIC_DEAD, 1, NULL); > + RETURN_ON_DEACTIVATED_SPOOLER(res); Use this macro only once. I did not test, which AddFormA return RPC_S_SERVER_UNAVAILABLE. Did you test the code with a non - admin account? Many functions in winspool.drv return ERROR_ACCESS_DENIED -- By by ... Detlef

1 0

re: loader: print a better message about reserving memory
by Dan Kegel 13 Apr '08

13 Apr '08

Vitaliy wrote: >Austin English wrote: >> With ubuntu updating to the 2.6.24 kernel, a lot more people are >> running into errors about reserving memory. This patch adds a >> suggestion to check /etc/sysctl.conf. >> >> You may need to edit /etc/sysctl.conf to give Wine access to this memory.\n", > >Can you be more specific what did Ubuntu do to break Wine? It would have been helpful if Austin had linked to the bug report from his patch. I went and filed a (very well documented :-) bug report http://bugs.winehq.org/show_bug.cgi?id=12548 that turned out to be a dup of the one Austin had been discussing the bug in. Austin's patch is helpful, but I think we can do better. For instance, we could ship a helper app that pops up a gui and asks whether the user wants us to work around the problem (by doing gksudo sysctl -w vm.mmap_min_addr=0, say) and run it in the preloader if we can't map the lowest page.

2 1

re: Trying to get a grip on how to handle bug reports.
by Dan Kegel 13 Apr '08

13 Apr '08

James wrote: > If you'll actually read what I said, I made no threats, nor was I rude. IMHO the cumulative attitude of your comments, especially http://bugs.winehq.org/show_bug.cgi?id=11639#c18 Stop posting in a closed bug report! You've already been told to open a new bug report.. was in fact somewhat rude. - Dan

1 0

Re: loader: print a better message about reserving memory
by Vitaliy Margolen 13 Apr '08

13 Apr '08

Austin English wrote: > With ubuntu updating to the 2.6.24 kernel, a lot more people are > running into errors about reserving memory. This patch adds a > suggestion to check /etc/sysctl.conf. > > You may need to edit /etc/sysctl.conf to give Wine access to this memory.\n", Can you be more specific what did Ubuntu do to break Wine? Vitaliy.

1 0

Desktop, x11drv, and _NET_WM_WINDOW_TYPE_DIALOG
by Benjamin M. Schwartz 13 Apr '08

13 Apr '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 According to xprop, Wine is creating the desktop window with _NET_WM_WINDOW_TYPE = _NET_WM_WINDOW_TYPE_DIALOG. This is problematic for me, because of the way my window manager (Matchbox) handles dialogs. Is there a reason that the desktop is not _NET_WM_WINDOW_TYPE_NORMAL? I have tried to trace this through the code, and I wind up at x11drv/desktop.c, but I don't see any reference to DIALOG there. Alternatively, perhaps it is set with MAKEINTATOM at the top of explorer/desktop.c, but I'm not sure how to interpret that constant. - --Ben -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIAiGiUJT6e6HFtqQRAvgmAJ0XJohI9u7VYzorTgKenG1qJpJzeACdEiqR dUAVRyREOtjfx/bAgrUUeQ8= =PkkE -----END PGP SIGNATURE-----

1 0

Re: urlmon: add stub for CoInternetSetFeatureEnabled
by Dmitry Timoshkov 13 Apr '08

13 Apr '08

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > +HRESULT WINAPI CoInternetSetFeatureEnabled(INTERNETFEATURELIST Feature, DWORD flags, BOOL fEnable) > +{ > + FIXME("%p, 0x%08x, %x, stub\n", &Feature, flags, fEnable); > + return E_NOTIMPL; > +} > diff --git a/dlls/urlmon/urlmon.spec b/dlls/urlmon/urlmon.spec > index 1fa2f94..e89e049 100644 > --- a/dlls/urlmon/urlmon.spec > +++ b/dlls/urlmon/urlmon.spec > @@ -19,6 +19,7 @@ > @ stdcall CoInternetGetSession(long ptr long) > @ stdcall CoInternetParseUrl(wstr long long wstr long ptr long) > @ stdcall CoInternetQueryInfo(ptr long long ptr long ptr long) > +@ stdcall CoInternetSetFeatureEnabled(ptr long long) The first parameter of CoInternetSetFeatureEnabled is not a pointer even if you pretend it is in the FIXME. Also Please use consistent spacing and naming of variables (preferring 1 space and no hungarian/upper cased names). -- Dmitry.

2 1

re: Trying to get a grip on how to handle bug reports.
by Dan Kegel 13 Apr '08

13 Apr '08

James wrote: > [ http://bugs.winehq.org/show_bug.cgi?id=11639#c15 et seq.] > Once the user kept commenting > in the closed bug report (and not filing a new bug report), I told him > to stop posting in a closed bug. Since when is this not standard? The problem is, the user felt he was treated rudely: "I will report a new bug, but don't treat me like i'm an idiot or someone who deliberatly is spamming in closed bug reports." and I tend to agree. In this case, the user didn't need education, he just needed to be gently told that a new bug needs to be filed. - Dan

1 0

Wine on OLPC
by Benjamin M. Schwartz 12 Apr '08

12 Apr '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear Wine developers, I am attempting to package Wine for OLPC. My goal is to enable packaging individual windows programs into OLPC "Activity bundles" with wine. I have encountered a handful of problems along the way. One of them is bug #12507, for which I have sent a patch. A few others are: 1. Decorations on the Desktop window. I am running in Desktop mode, because this provides the best integration with the OLPC operating system. However, the desktop window has decorations on it, which I do not want. I want the desktop to be a fullscreen window. It seems that recent patches to x11drv may make this possible, but I could find no way in 0.9.59. What should I do to run the Desktop as a full-screen window, or as a normal window without decorations? 2. Non-ownership of .wine/ The OLPC security system is designed to run each program under a different unix uid, as a form of lightweight sandboxing. My system is set up to create a .wine/ directory the first time the program is run. The second time the application is run, it doesn't work because the .wine directory is owned b a different user, so I get "path/.wine is not owned by you". I have tried doing "chmod a+rwx" to .wine/ on the first run, but Wine still refuses to run, even though it has full access, because it's not the owner. Would you consider patches to exchange the uid check for a rwx access check? Thank you, Ben -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH/+1RUJT6e6HFtqQRAs0RAJ9o1HzIsoCMLUPCC1GJKnOJikIBtACgiLBH uy8KO8KlGm4/ZD+7jXcQrrg= =mi64 -----END PGP SIGNATURE-----

4 11

Several patches for D3DX
by Luis Busquets 12 Apr '08

12 Apr '08

Is there still any problem with each of the attached patches or are they going to be committed?

2 3

AVI file format documentation
by Dan Kegel 12 Apr '08

12 Apr '08

Maarten stumbled across what he said was very useful documentation about the AVI file format. For future reference, here it is: http://sunsson.iptime.org/projects/juliet/wiki/MediaFileFormat

4 5

Dead-loop in IWineD3DTextureImpl_PreLoad
by Vitaliy Margolen 12 Apr '08

12 Apr '08

Can some one take a look at this (bug 11630)? I'm not sure how it works at all now: IWineD3DTexture_PreLoad:144: http://source.winehq.org/source/dlls/wined3d/texture.c#L144 IWineD3DSurface_LoadTexture:488: http://source.winehq.org/source/dlls/wined3d/surface.c#L488 And of course container is Texture so the loop starts again until Wine runs out of stack. Vitaliy.

1 0

GL_ATI_fragment_shader and GL_INVALID 0x501, 0x502
by Milan Kostić 12 Apr '08

12 Apr '08

Ok i'm tested wine and his new GL_ATI_fragment_shader support with 9250 card nad Mesa/DRI driver. Now env bumpmaping and dot3 tests in 3DMark2001 seems to work good, but in car test high ground texture is black. In DungeonSiege2 i disabled ps in winecfg, because it has same problem (and more) flickering and black textureon the ground (river water not show, but on sea it has...). With Painkiller, nothing helps to start game (disabled ps in winecfg not help), only solution is to change textured units in driconf from 6 to 5 (this disable GL_ATI_fragment_shader in driver). I check also NFS: Hot Pursuit2, in wine-0.58> (this is from some earlier versions, but problem is same) it has these fixmes: fixme:d3d_texture:IWineD3DBaseTextureImpl_ApplyStateChanges >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glTexParameteri GL_TEXTURE_MAX_ANISOTROPY_EXT ... @ basetexture.c / 463 fixme:d3d:get_src_and_opr Unhandled texture argWINED3DTA_SPECULAR and now: fixme:d3d_texture:IWineD3DBaseTextureImpl_ApplyStateChanges >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glTexParameteri GL_TEXTURE_MAX_ANISOTROPY_EXT ... @ basetexture.c / 488 fixme:d3d_shader:shader_arb_generate_vshader HW VertexShader Error at position 499: "1046: '.' expected but ';' found" fixme:d3d_shader:gen_ati_shader >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from GL_EXTCALL(glEndFragmentShaderATI()) @ ati_fragment_shader.c / 774 this fixmes is shifted many times, when i stop/start the some race, leave the menu, etc. This is first game in which i see gen_ati_shader in exchange of unhandle texture (NV_combiner thing). I wish to ask what is that GL_INVALID_VALUE (0x501) and GL_INVALID_OPERATION (0x502)??? This 0x501 i can see in many games.

2 12

Testcases: Call for volunteers
by Austin English 12 Apr '08

12 Apr '08

Over the past few days I've had a bit of time to kill, and spent quite a bit of it triaging bugs in bugzilla (mostly checking up on old/abandoned bugs, but also, tagging quite a few patches/test cases). In the process, I've tagged quite a few bugs (currently, 66 open, 9 closed) that have test cases attached. While not all are in C, or easily portable to the wine test suite, I'd appreciate it if those of you with time to spare could take a look at any test cases in your area of expertise and port those tests to the wine test suite. Here is the current list: http://bugs.winehq.org/buglist.cgi?keywords=testcase The more conformance tests we can add, the fewer regressions post 1.0, so in the end, less work :-). - Austin

1 0

Re: [Wine] Uninstallation of Programs
by Zachary Goldberg 12 Apr '08

12 Apr '08

On Fri, Apr 11, 2008 at 1:09 PM, Austin English <austinenglish(a)gmail.com> wrote: > On Fri, Apr 11, 2008 at 12:01 PM, pdsmith <wineforum-user(a)winehq.org> wrote: <snip> > > $ wine uninstaller > > Will launch the uninstaller, but it doesn't always work too well, and > it's not a high priority to fix. Should we perhaps reconsider that for 1.0? Perhaps something worth fixing during the freeze? > If you want to remove all programs > and settings, you can do > $ rm -rf ~/.wine > > To start fresh. It will be recreated whenever you run any wine program. > > -- Zachary Goldberg Computer Science & Engineering Electrical Captain of Penn Electric Race Team School of Engineering at the University of Pennsylvania

4 7

Please add wine-0.9.59 to bugzilla
by Vitaliy Margolen 12 Apr '08

12 Apr '08

Could someone add the newest Wine version to buzilla? Vitaliy.

2 2

Better sound support
by Kacper Pluta 11 Apr '08

11 Apr '08

Hey, do you plan on enabling handling of 24bit sound and sampling frequencies 96000 or 192000? Lots of musicians using Linux need to use VST and VSTi plugins (through FST and other methods). Unfortunately quality of music you can acquire isn't realy high if you wish to use it professionally. I'd also suggest correcting MIDI handling and integrating wine with wineasio, which would enable using VST and VSTi on a quite high level, as well as use other programmes.

3 2

New Valgrind errors in user32
by Dan Kegel 11 Apr '08

11 Apr '08

Hey Lei, this morning's git brought one new valgrind error, and it happens to be in a file you touched in the last day or so: + Conditional jump or move depends on uninitialised value(s) + at EDIT_BuildLineDefs_ML (edit.c:1280) + by EDIT_EM_ReplaceSel (edit.c:3260) + by EDIT_WM_Char (edit.c:4035) + by EditWndProc_common (edit.c:859) + by EditWndProcA (edit.c:1103) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + by call_window_proc (winproc.c:457) + by WINPROC_call_window (winproc.c:2207) + by call_window_proc (message.c:1616) + by send_message (message.c:2438) + by SendMessageA (message.c:2583) + by test_enter (edit.c:1654) + by func_edit (edit.c:1977) + by run_test (test.h:406) + by main (test.h:455) Could you have a look? See http://kegel.com/wine/valgrind/logs-2008-04-10/vg-user32_edit-diff.txt http://kegel.com/wine/valgrind/logs-2008-04-10/vg-user32_edit.txt Thanks, Dan

2 1

Wine running (not so) random applications (with a few bugs)...
by Reece Dunn 11 Apr '08

11 Apr '08

Several releases back, I tried getting the Cepstral SwiftTalker Text-To-Speech program working, but to no avail. I tried again last night and was surprised that it worked! So I decided to throw several applications at Wine out of the box, with no modifications and see how well it did. These are my findings: == Firefox 3 (Beta 4) I have basically reproduced Dan Kegel's findings (including bugs 12305 and 1237). I also successfully upgraded from beta 4 to 5 and ran in both XP and Vista modes. Other things I noticed: * firefox dialogs (e.g. the "Default Browser" dialog) are cropped at the bottom, cutting off the buttons (bug 12511). Verdict: Very close to perfect. Usable for most things with a few minor annoyances. == Cepstral SwiftTalker (http://downloads.cepstral.com/downloads/) This is a text-to-speech program that I use constantly. It now works under Wine - yay! Using an unregistered voice, voice rendering is smooth and sentence reading highlighting is synchronised perfectly, even at 374 words per minute! Issues: * Ctrl+Home and Ctrl+End don't work as on Windows (go to the start/end of the document). This is the same in notepad (bug 12512). * Changing the voice speed also changes the font to Courier New Italic. It looks like the SwiftTalker application is using Courier New initially (and rendering correctly on startup), but when you edit the Tools->Options, it does not find Courier New in the available fonts (bug 12513). * There is a slight audio glitch when using a registered voice that is noticeable either as a pop or as an overlapped playback with the previous word whenever there is a sentence changeover. This is hardly noticable on the default 170 WPM, but is more pronounced on my default 247 WPM setting. Verdict: Near perfect. The audio glitch can get irritating at times and is the only thing preventing me giving this a Perfect verdict. == Popcap Games There can't be an application test list without mentioning games, so here we are. The games tested were: * Peggle (http://popcap.com/games/peggle) * Bejeweled 2 (http://popcap.com/games/bejeweled2) The games run smoothly, including sound, full screen graphics and custom cursors. Issues: * The installer fails to create Uhttp://mail.google.com/mail/RL links (e.g. http://www.popcap.com) * Selecting hardware acceleration from within Peggle causes the game to render a black screen. Verdict: Perfect. == Yahoo Games (http://games.yahoo.com/downloads) Even more games, e.g. Aveyond. Issues: * Could not get past the initial page as the gecko HTML engine failed to install resulting in the "HTML rendering is currently disabled" text appearing. This is a regression, as it worked in older versions of Wine. NOTE: I haven't done a bisect yet. Verdict: Non-starter. Thanks for all the great work. Wine keeps on improving release on release and continues to amaze me. Special thanks to the CodeWeavers team and the DirectX developers for all the hard work gone into making Wine what it is today. - Reece

1 0

[PATCH] winecfg => control panel applets patch
by pure_evil＠mail.bg 11 Apr '08

11 Apr '08

Frank Richter wrote: >On 10.04.2008 09:47, pure_evil at mail.bg wrote: > > >>However, since control panel does not utilize Unicode yet, the additionalb >>Bulgarian translation matches the English one. >> >> > Even for non-Unicode apps you should have no problems with adding a > Bulgarian translation to a GUI app (when Bulgarian is selected as your > preferred language the active codepage will be chosen accordingly). > Maybe you used a wrong charset? You should use the Windows charset or > use #pragma (see >http://wiki.winehq.org/Developers-Hints?highlight=%28Developers%29#head-ef4… >) >Mikołaj Zalewski Hmmm, I'll have to check up on that. The translations themselves are for the description/title that appears under the applet in the control panel. Once launched,(LANG=bg_BG) the winecfg translations take over and no problem there, just the unicode thing looks like rubbish under the icon. And, has twice as many characters as the text itself, which points to a problem within the control, rather than the codepage (?) - most probably, usage of ASCII rather than Unicode in control itself. -ugh if this message also ends up as a new thread I'm gonna shoot KMail and try to get a decent program that doesn't f* up mail lists... suggestions?-

2 1

Re: [PATCH] winecfg => control panel applets patch
by pure_evil＠mail.bg 11 Apr '08

11 Apr '08

> However, since control panel does not utilize Unicode yet, the additionalb > Bulgarian translation matches the English one. > So what's the point of that "translation" then? Right now it doesn't add > anything worthwhile but increases the patch size - not good. Well, it was intended as a template and as a "forward compatibility" thing. (I know, it's REALLY annoying to have a stub mark the beginning of a 400 lines+ of patch. ugh. don't know why that one came to be the first file... It's place is somewhere in-between the icons IMHO.) > You probably increase the chance of your patch being accepted by leaving > out that not-really-a-translation. I'd recommend you submit that as a > patch at a later point of time. It probably also makes sense to properly > "unicodify" the control panel before supplying a language that needs it. Control panel doesn't support Unicode, so I could've dropped all that language mumbo-jumbo alltogether - it indeed adds a lot of overhead and complexity to the entire thing. However, I wanted to provide a forward-compatible solution (and, Dan Kegel said straight: go for Unicode!), rather than coding for-the-moment. (which also explains the *not-so-optimal* way I handled the winecfg mod itself. Now I understand a new tab is to be added... and with a slight modification, a seventh applet will appear. (and it'll require less time to do than to draw the icon) And really, introducing a new capability (home-grown applets), modifying winecfg -and- unicodifying control panel at the same time would've been a tad overkill. I was thinking of (should the control panel be accepted at all) unicodifying the control and providing the right translation for the applets in the next patch, in which case I'd be modifying only the pre-existing .rc rather than poking in the applet source. /Then again, a few languages might not actually require Unicode for those texts, so, someone seeing that it's capable of being translated speaking the right language.../

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel