- wine-devel - winehq.org

Re: Wine malware story
by Michael Ost 11 Apr '08

11 Apr '08

"Dan Kegel" <dank(a)kegel.com> wrote: > http://www.thaibrother.com/blog/?p=1047 > is a fairly thin article about malware in wine; > it's worth mentioning only because it shows > the issue is getting discussed more. As Wine gains functionality --- supporting Windows services, binary drivers, registry startup programs, etc --- it seems like it will be more vulnerable on this score. From my somewhat naive point of view regarding Windows malware, I would like to see Wine have the option of only running the app that I asked it to and not a bunch of other stuff that gets auto-loaded and run. An option like that could be billed as making Wine "safer" than Windows. I'm also really glad that my Wine-based product is moving away from running Wine as root! Cheers... mo

1 0

Re: [PATCH] winecfg => control panel applets patch
by Frank Richter 11 Apr '08

11 Apr '08

On 10.04.2008 09:47, pure_evil(a)mail.bg wrote: > However, since control panel does not utilize Unicode yet, the additionalb > Bulgarian translation matches the English one. So what's the point of that "translation" then? Right now it doesn't add anything worthwhile but increases the patch size - not good. You probably increase the chance of your patch being accepted by leaving out that not-really-a-translation. I'd recommend you submit that as a patch at a later point of time. It probably also makes sense to properly "unicodify" the control panel before supplying a language that needs it. -f.r.

2 1

Wine malware story
by Dan Kegel 11 Apr '08

11 Apr '08

http://www.thaibrother.com/blog/?p=1047 is a fairly thin article about malware in wine; it's worth mentioning only because it shows the issue is getting discussed more.

1 0

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [1/2] (ATTEMPT 3)
by Alexandre Julliard 11 Apr '08

11 Apr '08

"Erich Hoover" <ehoover(a)mines.edu> writes: > Description: > Fixes incorrect file sharing mode in PROFILE_FlushFile and PROFILE_Open > that result in WritePrivateProfileString failing under certain > circumstances. This problem is specifically evident in the "Thief: Deadly > Shadows" installer (demo and full), which writes an empty config file that > later causes the game to crash (Bug #5024). This version is functionally > equivalent to Attempt 2; however, it uses NtCreateFile so there is no need > to push and pop the error code. This version also sets ERROR_SUCCESS, as > opposed to S_OK, for Get* functions. Conformance test included in part 2. There's no need to use ntdll functions, last error doesn't matter on success, and if it does it should be set at the end of the function anyway (with test cases showing that it's really supposed to). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: Add a test to highlight the CreateCompatibleDC problemdescribed in bug #12493
by Dmitry Timoshkov 11 Apr '08

11 Apr '08

"Colin Finck" <mail(a)colinfinck.de> wrote: > Changelog: > Add a gdi32 test to highlight the CreateCompatibleDC problem described in > bug #12493 If the test fails in current Wine code you need to use todo_wine so that 'make test' still passes. -- Dmitry.

2 1

Re: [PATCH 1/2] winecfg: Add option to let wine decorate windows
by Alexandre Julliard 11 Apr '08

11 Apr '08

Matthew D'Asaro <medasaro(a)comcast.net> writes: > Some applications such as iTunes, Winamp, Windows Media Player, Office > 2007, etc. look best without the Linux windows manager decorations on > them. This patch adds an option to winecfg which > allows an application's windows to be managed by the Linux window > manager, but to be decorated by wine. This can also be useful for > debugging some window management problems. The modification to the > winecfg dialog is only in English as I don't know any of the other > languages. I put the patch in, but this winecfg page really needs to be redesigned, the decorated/managed/desktop options are mutually exclusive, so it should use radio buttons. Also the explanations should be moved out to a tooltip or some sort of help option. Any volunteer? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] setupapi: Add a test for SetupDiGetDeviceRegistryProperty and SetupDiSetDeviceRegistryProperty
by Alexandre Julliard 11 Apr '08

11 Apr '08

Alexander Morozov <amorozov(a)etersoft.ru> writes: > + if (wide) > + { > + pSetupDiGetClassDevs = (void *)pSetupDiGetClassDevsW; > + pSetupDiSetDeviceRegistryProperty = (void *)pSetupDiSetDeviceRegistryPropertyW; > + pSetupDiGetDeviceRegistryProperty = (void *)pSetupDiGetDeviceRegistryPropertyW; > + pSetupDiCreateDeviceInfo = (void *)pSetupDiCreateDeviceInfoW; > + devName = (void *)devNameW; > + friendlyName = (void *)friendlyNameW; > + buflen = 6 * sizeof(WCHAR); > + buf = (void *)bufW; > + } > + else > + { > + pSetupDiGetClassDevs = (void *)pSetupDiGetClassDevsA; > + pSetupDiSetDeviceRegistryProperty = (void *)pSetupDiSetDeviceRegistryPropertyA; > + pSetupDiGetDeviceRegistryProperty = (void *)pSetupDiGetDeviceRegistryPropertyA; > + pSetupDiCreateDeviceInfo = (void *)pSetupDiCreateDeviceInfoA; > + devName = (void *)devNameA; > + friendlyName = (void *)friendlyNameA; > + buflen = 6; > + buf = (void *)bufA; > + } That's ugly, it's bypassing all type checking. There's no reason to test everything twice, in most cases the A function calls the W one, so testing the A one automatically tests both. If there are differences you really need to test, please do that explicitly by duplicating the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tools: Fix font structure layout for 64-bit mode
by Dmitry Timoshkov 11 Apr '08

11 Apr '08

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > I quick question from someone relatively new to wine development. > > Are these 64-bit fixes aimed at compiling wine for 64 bit CPUs > but running win32 apps or for running win64 apps? Both. -- Dmitry.

1 0

Re: ntdll: Fix a test that fails on both win2k and winxp
by Alexandre Julliard 11 Apr '08

11 Apr '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > Changelog: > * Fix a test that fails on both win2k and winxp. This will break the test for win9x. -- Alexandre Julliard julliard(a)winehq.org

1 0

WineConf 2008
by Jeremy White 11 Apr '08

11 Apr '08

Hi Folks, I'd like to start the planning for WineConf 2008. My sense is that 3 years in Europe and 1 year in the US is a reasonable balance, so I feel it makes sense to try to have it over here this year. Further, I would like to host WineConf this year in St. Paul, Minnesota, for a variety of reasons. First, it's a lot easier for me to help plan if it's here. Second, it's nice for CodeWeavers; it means we can have everyone, not just the developers, all together. Having Mandi able to physically intimidate people is very helpful for us, after all <grin>. My thought was to do it in late September, early October, so that the weather would not be so extreme. I realize that veterans of our last Minnesota meeting will be disappointed at the lack of the Ice Palace, but we'll try to find a way to make it up to you. Also, I know the travel costs will be hard for many people, given current travel costs, so I'm hoping to contribute funds (and perhaps do some fund raising) to help cover travel costs for Wine contributors. At any rate, that's my idea. I'm willing to be swayed if people object violently, or if a clear consensus for an alternate emerges. Thoughts? Comments? Cheers, Jeremy

6 5

Reference information on CreateScalableFontResource
by Jeremy White 11 Apr '08

11 Apr '08

I'm doing a brain dump for posterity on this task; you can tune out of this email; it's mostly meant for Google archiving purposes. I've spent far more time than I should on this implementation; I originally did a quick + dirty version that was not binary compatible with Windows .fot files. Worked like a charm; I could run Civ III (yay!). But Alexandre said, gee, it should be easy to make it create a binary compatible .fot file, take an afternoon and do that, why don't you, Jer? Several weeks and a lot of swearing later, I now know far more about the format of .fot files and fontdir resource structures than I care to. I'm attaching a program that was useful to me; it dumped many chunks of info about a .ttf file from FreeType. Comparing that to a .fot file generated on Windows was helpful. I'm also attaching a hex dump of a .fot file with my annotation on the basic structure. The hard parts were that the .fot format seems to be an NE image, but it seems to have subtle bugs in it and that the FONTDIR resource structure is not well documented. I've mostly sussed out how to use Freetype to replicate most of the members; there are still a few I don't have quite right. (And I probably get this all wrong in non US or double byte locales. :-/) The previous patches contain essentially all of my hard won knowledge of the FONTDIR structure. Cheers, Jeremy Annotated hex dump of lucon.fot, a file created on Windows with CreateScalableFontResource against lucon.ttf. Useful for determining the structure of .fot files. DOS 00000000 4d 5a 01 00 02 00 00 00 04 00 0f 00 ff ff 00 00 |MZ..............| 00000010 b8 00 00 00 00 00 00 00 40 00 00 00 00 00 00 00 |........@.......| 00000020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000030 00 00 00 00 00 00 00 00 00 00 00 00 80 00 00 00 |................| 00000040 0e 1f ba 0e 00 b4 09 cd 21 b8 01 4c cd 21 54 68 |........!..L.!Th| 00000050 69 73 20 69 73 20 61 20 54 72 75 65 54 79 70 65 |is is a TrueType| 00000060 20 66 6f 6e 74 2c 20 6e 6f 74 20 61 20 70 72 6f | font, not a pro| 00000070 67 72 61 6d 2e 0d 0d 0a 24 00 4b 69 65 73 61 00 |gram....$.Kiesa.| NE 00000080 4e 45 05 10 8a 00 02 00 00 00 00 00 00 80 00 00 |NE..............| 00000090 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000000a0 1a 00 40 00 40 00 74 00 7f 00 7f 00 0e 01 00 00 |..@.@.t.........| 000000b0 00 00 04 00 02 00 02 00 00 00 00 00 00 00 00 03 |................| START RESOURCE TABLE Shift 000000c0 04 00 Type + Name 0 07 80 01 00 00 00 00 00 48 00 0a 00 50 0c |..........H...P.| 000000d0 2c 00 00 00 00 00 Type + Name 1 cc 80 01 00 00 00 00 00 40 00 |,.............@.| 000000e0 08 00 50 0c 01 80 00 00 00 00 Flag to end all types + names 00 00 07 46 4f 4e |..P..........FON| 000000f0 54 44 49 52 05 4c 55 43 4f 4e 00 |TDIR.LUCON. | END RESOURCE TABLE ^^^ This is odd. That's fairly clearly the last string in the name/type string part of the resource table. Further, just a little further along, we have a clear place where the resident name table should start. But the header says it starts at 0x74 relative, which is right there. And the clear place for it to start is at 0x7f. Mystery bytes: (0xf9, 0x79 relative) 00 00 00 00 Apparent resident name table: (0xff, 0x7f relative) 0a | .| 00000100 4c 55 43 4f 4e 2e 54 54 46 00 |LUCON.TTF. | Apparent module reference table: (0x10a, 0x8a relative) 00 00 00 00 Non resident name table: (0x10e) 1a 46 | .F| 00000110 4f 4e 54 52 45 53 3a 4c 75 63 69 64 61 20 43 6f |ONTRES:Lucida Co| 00000120 6e 73 6f 6c 65 00 00 00 00 00 00 00 00 00 00 00 |nsole...........| 00000130 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000140 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000150 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000160 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000170 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000180 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000190 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000200 c3 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| ^^^ What the hell!?!?! 00000210 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000220 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000230 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000240 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000250 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000260 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000270 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000280 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000290 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000300 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000310 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000320 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000330 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000340 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000350 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000360 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000370 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000380 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000390 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000400 43 3a 5c 57 49 4e 44 4f 57 53 5c 66 6f 6e 74 73 |C:\WINDOWS\fonts| 00000410 5c 4c 55 43 4f 4e 2e 54 54 46 00 00 00 00 00 00 |\LUCON.TTF......| 00000420 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000430 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000440 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000450 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000460 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000470 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000480 01 00 00 00 00 02 95 00 00 00 57 69 6e 64 6f 77 |..........Window| 00000490 73 21 20 57 69 6e 64 6f 77 73 21 20 57 69 6e 64 |s! Windows! Wind| 000004a0 6f 77 73 21 00 10 03 01 01 00 00 00 00 00 00 00 |ows!............| 000004b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000004c0 00 00 00 00 00 00 03 40 00 08 48 00 48 00 50 06 |.......@..H.H.P.| 000004d0 00 00 00 00 00 00 00 90 01 00 00 00 00 08 36 d2 |..............6.| 000004e0 04 d2 04 1e ff 01 02 00 00 00 00 00 00 76 00 00 |.............v..| 000004f0 00 0c 00 00 00 ff 4c 75 63 69 64 61 20 43 6f 6e |......Lucida Con| 00000500 73 6f 6c 65 00 4c 75 63 69 64 61 20 43 6f 6e 73 |sole.Lucida Cons| 00000510 6f 6c 65 00 52 65 67 75 6c 61 72 00 00 00 00 00 |ole.Regular.....| 00000520 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000530 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000540 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000550 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000560 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000570 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000580 00 |.| 00000581

2 3

re: Valgrind false positive or?
by Dan Kegel 11 Apr '08

11 Apr '08

Vitaliy wrote: >==22938== Invalid write of size 1 >==22938== at 0x4024D55: memcpy (mc_replace_strmem.c:402) >==22938== by 0x7BC64405: setup_exception_record (signal_i386.c:795) >==22938== by 0x7BC65793: segv_handler (signal_i386.c:1310) What test was this? Sometimes a little more context helps.

2 2

Valgrind false positive or?
by Vitaliy Margolen 11 Apr '08

11 Apr '08

Trying to understand what is that valgrind doesn't like? ==22938== Invalid write of size 1 ==22938== at 0x4024D55: memcpy (mc_replace_strmem.c:402) ==22938== by 0x7BC64405: setup_exception_record (signal_i386.c:795) ==22938== by 0x7BC65793: segv_handler (signal_i386.c:1310) ==22938== by 0x419160F: (within /lib/libpthread-2.6.1.so) ==22938== Address 0x7f22c7de is not stack'd, malloc'd or (recently) free'd http://source.winehq.org/source/dlls/ntdll/signal_i386.c#L756 http://source.winehq.org/source/dlls/ntdll/signal_i386.c#L1093 http://source.winehq.org/source/dlls/ntdll/signal_i386.c#L1310 Everything seems to be correct. Any ideas? Vitaliy.

1 0

Wine booth/BOF and Linuxworld San Francisco, Aug 2008?
by Dan Kegel 10 Apr '08

10 Apr '08

Wine has come a long way, and will have just had its 1.0 release (knock on wood). So perhaps this is a good year to have a .org booth. What do folks think?

4 3

Microsoft Tax Day Wine Tasting & Networking Event
by Dan Kegel 10 Apr '08

10 Apr '08

It's an April 15th event sponsored by Microsoft, but it sure sounds like something we should be holding on our own terms :-) http://www.microsoft.com/events/EventDetails.aspx?CMTYSvcSource=MSCOMMedia&…

2 1

RE: [PATCH] winecfg => control panel applets patch
by pure_evil＠mail.bg 10 Apr '08

10 Apr '08

> You patch is wrapped. Also please for new files follow standard Wine codding > style - 4 spaces indentation, no tabs. Sorry about that, I'll fix it in the morning. (I should've attached it as a text file :( ) > This is ugly and redundant. yes, but at least it's easily readable - same local variable name within one function serves to store the temporal result, and an *input* variable by the same name is used in the other function (to catch that same result). > However with all this you removing really big functionality from the winecfg - ability to set this on per application basis. + if (display_what_tabs == 1) + { Do_App = TRUE; /*well, application settings do require more tabs.*/ + Do_Lib = TRUE; + NUM_PROPERTY_PAGES = 3; + } ^^This (a few lines below) took care of that.^^ This piece of code explains why I went for bools in the first place - for example, you draw the library tab A.) when you want to draw only them (general library settings), B.) when you want application-specific settings ("winecfg applications") and C.) when you want the entire winecfg. That would've been a lot messier with a triple "or" rather than a simple IF (Do_Lib) { }.

1 0

RE: [PATCH] winecfg => control panel applets patch
by Vijay Kiran Kamuju 10 Apr '08

10 Apr '08

Hi, This is regarding the control panel applet patch you have submitted to wine-patches. I would like to have the applets should be part of wine's control program. They would be better be as files in the /programs/control/ And you should extend the existing control.exe and winecfg in wine to open these applets. Please correct me if I am wrong. Just my 2 cents. ---- VJ

2 1

Re: msdmo: Array parameter is passed to function as pointer so loses size information
by Robert Shearman 10 Apr '08

10 Apr '08

Andrew Talbot wrote: > @@ -291,8 +291,9 @@ lend: > * > * Get DMP Name from the registry > */ > -HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[80]) > +HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[]) > { > +#define NAME_SIZE 80 /* Size of szName[] */ > WCHAR szguid[64]; > HRESULT hres; > HKEY hrkey = 0; > @@ -311,7 +312,7 @@ HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[80]) > if (ERROR_SUCCESS != hres) > goto lend; > > - count = sizeof(szName); > + count = NAME_SIZE; > hres = RegQueryValueExW(hkey, NULL, NULL, NULL, > (LPBYTE) szName, &count); > This is incorrect. count is the size in bytes of the buffer passed in (szName) and so should be sizeof(szName) not sizeof(szName)/sizeof(szName[0]) (i.e. 80). I see this patch has already been committed, so a9200b24014607c4c82fb052b97de88daa804a81 should be reverted. If you want to pick up errors like passing the wrong size into functions then I would suggest using an automatic checker that is able to use semantic information, like Microsoft's PREfast. -- Rob Shearman

3 5

Re: tools: Add Spanish Translation to wine.desktop
by Ivan Gyurdiev 10 Apr '08

10 Apr '08

> Name=Wine Windows Emulator I like the expanded version better: "Wine is not an emulator windows emulator". Should help clear up any questions people might have :)

1 0

Re: [PATCH] winecfg => control panel applets patch
by Vitaliy Margolen 10 Apr '08

10 Apr '08

pure_evil(a)mail.bg wrote: > Allows access to different winecfg tabs via control-panel applets (without > showing all of the cfg's tabs when accessed thusly) > > +LONG APIENTRY EXECUTE_APPLET(HWND hwndCpl, UINT message, LPARAM lParam1, > LPARAM lParam2) > +{ > + > + int NumOfApplet = (int)lParam1; > + > + switch (NumOfApplet) > + { > + > + case 0: You patch is wrapped. Also please for new files follow standard Wine codding style - 4 spaces indentation, no tabs. > + /*It would get messier with an or statement everywhere, so...*/ > + BOOL Do_App = FALSE; > + BOOL Do_Lib = FALSE; > + BOOL Do_Graph = FALSE; > + BOOL Do_Desktop = FALSE; > + BOOL Do_Drives = FALSE; > + BOOL Do_Audio = FALSE; > + if (display_what_tabs == 2) { Do_Lib = TRUE; } > + if (display_what_tabs == 3) { Do_Graph = TRUE; } > + if (display_what_tabs == 4) { Do_Desktop = TRUE; } > + if (display_what_tabs == 5) { Do_Drives = TRUE; } > + if (display_what_tabs == 6) { Do_Audio = TRUE; } > + if ( lstrcmpi(CommandLine,"applications") == 0 ) display_what_tabs = 1; > + if ( lstrcmpi(CommandLine,"libraries") == 0 ) display_what_tabs = 2; > + if ( lstrcmpi(CommandLine,"graphics") == 0 ) display_what_tabs = 3; > + if ( lstrcmpi(CommandLine,"desktop") == 0 ) display_what_tabs = 4; > + if ( lstrcmpi(CommandLine,"drives") == 0 ) display_what_tabs = 5; > + if ( lstrcmpi(CommandLine,"audio") == 0 ) display_what_tabs = 6; This is ugly and redundant. You should make it a bit-mask instead. However with all this you removing really big functionality from the winecfg - ability to set this on per application basis. Vitaliy.

1 0

Re: shell32: Implement ParseDisplayName for EntireNetwork in the Network Places shell folder.
by Juan Lang 10 Apr '08

10 Apr '08

Hi Rob, + strcpy(pData->u.network.szNames, "Entire Network"); Is this not locale-dependent? --Juan

2 2

make install broken
by Stefan Leichter 10 Apr '08

10 Apr '08

Hello, installing wine does not longer work for me. It fails with: make[2]: Entering directory `/usr/src/wine/wine-build/programs/xcopy' /usr/bin/install -c xcopy.exe.so /usr/local/lib/wine/xcopy.exe.so make[2]: Leaving directory `/usr/src/wine/wine-build/programs/xcopy' make[1]: *** Keine Regel vorhanden, um das Target »winelauncher«, benötigt von »install«, zu erstellen. Schluss. make[1]: Leaving directory `/usr/src/wine/wine-build/programs' make: *** [programs/__install__] Fehler 2 The difference from my build system to the most others is, that i do out of tree builds. Bye Stefan

3 2

Re: conflict between Wine and Solaris list.h fixed by AlekZ's workaround (Bug 11463)
by Alexandre Julliard 10 Apr '08

10 Apr '08

Petr Sumbera <Petr.Sumbera(a)Sun.COM> writes: > diff --git a/server/fd.c b/server/fd.c > index 41e404c..0010bab 100644 > --- a/server/fd.c > +++ b/server/fd.c > @@ -71,6 +71,18 @@ > #include <sys/types.h> > #include <unistd.h> > > +/* > + struct list is defined at sys/list_impl.h on solaris > + this patches work around it. > +*/ > +#define list WINELIST > +#define list_remove WINELIST_REMOVE > +#define list_next WINELIST_NEXT > +#define list_prev WINELIST_PREV > +#define list_head WINELIST_HEAD > +#define list_tail WINELIST_TAIL > +#define list_move_tail WINELIST_MOVE_TAIL > + You should do this the other way around, by defining list to solaris_list before including the offending header, and undefining it afterwards. This way the Wine code itself isn't impacted by redefinitions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Including Mono within a Wine package - should Wine expect this?
by Scott Ritchie 10 Apr '08

10 Apr '08

I'm trying to decide if it's a good idea to create wine-mono and wine-gecko packages depended on by the wine package. wine-gecko seems easy enough: we just install a local copy of the gecko engine, and then Wine grabs it as soon as it's needed. I'm even thinking of modifying wineprefixcreate to essentially do winetricks gecko at the end, unless someone can point out how that would have bad consequences. wine-mono would function similarly. Is there any reason not to install it around wineprefixcreate time? I'm assuming Microsoft .net or a later mono can be installed to replace mono afterwards (if not this is probably a bug). Even so, does this seem like a good idea? Have any other packagers thought of something like this? The biggest issue at this point seems to be dealing with the fact that gecko can only be built on Windows. I'm not sure how to build the Windows version of Mono either. Thanks, Scott Ritchie

1 0

Re: msvcrtd: add DllMain
by Louis. Lenders 10 Apr '08

10 Apr '08

----- Original Message ---- From: Alexandre Julliard <julliard(a)winehq.org> To: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> Cc: wine-devel(a)winehq.org Sent: Thursday, 10 April, 2008 5:15:56 AM Subject: Re: msvcrtd: add DllMain "Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > Hi, this is for bug http://bugs.winehq.org/show_bug.cgi?id=5133 > > It looks like several apps (like Rubies, and Resolume and i guess > several others) are shipped with a copy of this dll (along with > msvcr71 and others). So i think it's ok to use this native dll then, > and that is what this patch does. In this way this patch fixes bug > #5133 It doesn't fix anything, it just hides the bug. -- Alexandre Julliard julliard(a)winehq.org Maybe "fix" wasn't the right word; on the other hand, if you call it hiding a bug, then we're hiding tons of bugs, like in gdiplus, that also loads the native gdiplus, if that is shipped with the application. Anyway, if you don't like it that way, just leave it ___________________________________________________________ Yahoo! For Good helps you make a difference http://uk.promotions.yahoo.com/forgood/

1 0

Re: msvcrtd: add DllMain
by Alexandre Julliard 10 Apr '08

10 Apr '08

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> writes: > Hi, this is for bug http://bugs.winehq.org/show_bug.cgi?id=5133 > > It looks like several apps (like Rubies, and Resolume and i guess > several others) are shipped with a copy of this dll (along with > msvcr71 and others). So i think it's ok to use this native dll then, > and that is what this patch does. In this way this patch fixes bug > #5133 It doesn't fix anything, it just hides the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 14/22] gdiplus: add a stub for GdipSetImageAttributesRemapTable.
by Alexandre Julliard 10 Apr '08

10 Apr '08

"Lei Zhang" <thestig(a)google.com> writes: > @@ -62,6 +64,13 @@ typedef ImageAbort GetThumbnailImageAbort; > > #ifdef __cplusplus > > +/* FIXME: missing the methods. */ > +class Color > +{ > +public: > + ARGB color; > +}; > + I think this belong in gdipluscolor.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] winspool.drv: GetDefaultPrinterW reads the value from data in registry
by Detlef Riekenberg 10 Apr '08

10 Apr '08

On Di, 2008-04-08 at 15:39 +0400, Konstantin Kondratyuk wrote: > - if (!GetProfileStringW(windowsW, deviceW, emptyStringW, buffer, > len)) > + if(!RegOpenKeyW(HKEY_CURRENT_USER, user_default_reg_key, &hKey) > + && !RegQueryValueExW(hKey, keyname, NULL, &type, > (LPBYTE)buffer, &bufsize)) > + { > + TRACE("Get value from registry\n"); > + RegCloseKey( hKey ); > + } win3.x and win9.x use only "win.ini". We need to fix bug #4096, before we can switch to the Registry. > + else if (!GetProfileStringW(windowsW, deviceW, emptyStringW, > buffer, len)) There is no need for a Fallback, when bug #4096 is fixed. -- By by ... Detlef

2 1

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [1/2](ATTEMPT 2)
by Dmitry Timoshkov 10 Apr '08

10 Apr '08

"Erich Hoover" <ehoover(a)mines.edu> wrote: > + oldError = GetLastError(); > + /* Read and Write sharing are necessary if a flush is performed on an open file */ > + hFile = CreateFileW(CurProfile->filename, GENERIC_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, CREATE_ALWAYS, > FILE_ATTRIBUTE_NORMAL, NULL); > if (hFile == INVALID_HANDLE_VALUE) > { > WARN("could not save profile file %s (error was %d)\n", debugstr_w(CurProfile->filename), GetLastError()); > return FALSE; > } > + /* The operation has succeed, do not over-write the error code */ > + SetLastError(oldError); It's been said many times that if you need to save/restore last error value you are doing something wrong. > + /* Get* routines set S_OK on success, Write* routines return last error */ > + SetLastError(S_OK); There is no point in setting or checking last error value on success in vast majority of cases, do you have an app that depends on this? Besides, S_OK is an OLE error code and can not be used in kernel. -- Dmitry.

2 1

Re: [PATCH] user32: on VK_RETURN, send WM_COMMAND to ancestor, not parent.
by Dmitry Timoshkov 10 Apr '08

10 Apr '08

"Lei Zhang" <thestig(a)google.com> wrote: > I noticed I can no longer install an application which uses the NSIS > installer by repeatedly hitting enter until it finished. I did some > testing and it looks like for VK_RETURN, we should be sending > WM_COMMAND to the ancestor, and not the parent. Was edit control reparented at some point? Perhaps WM_COMMAND should be sent to an original parent? -- Dmitry.

2 7

%ALLUSERSPROFILE%
by Austin English 10 Apr '08

10 Apr '08

Wanted to get clarification before going through the trouble of writing this patch. Where would you prefer this variable Alexandre? I've seen two responses: http://www.winehq.org/pipermail/wine-devel/2007-May/056555.html http://www.winehq.org/pipermail/wine-devel/2005-March/035004.html Trying to fix 7292 as well as a few others with this, but didn't want to waste time on the wrong approach. - Austin

2 1

New winetricks-20080409: new verb vista, don't get confused by WGETRC, use curl and openssl if needed
by Dan Kegel 10 Apr '08

10 Apr '08

Another day, another winetricks. Version 20080409 has the following changes: Added winver=vista, since I found an app that refuses to install if winnt <= 502. Use curl and openssl instead of wget and sha1sum if needed (e.g. on mac), as suggested by Ryan Schmidt Use -nd option with wget, as suggested by Hin-Tak Leung As always, winetricks is available at http://kegel.com/wine/winetricks

2 1

Re: [1/2] WineD3D: Do not activate CTXUSAGE_BLIT for fb -> texture reading
by Stefan Dösinger 09 Apr '08

09 Apr '08

Am Donnerstag, 10. April 2008 00:42:04 schrieb Stefan Dösinger: > This ActivateContext call slipped in with patch > ba90a740beb9ce9a839cc843db8d87f5a37becdd. Roderick, was there a particular > reason why you activate CTXUSAGE_BLIT here, or was it just a copypaste > mistake from the glReadPixels codepath? I see now why the ActivateContext call is there. If the LoadLocation is not called from the PreLoad readback then a different surface might be active. Also CTXUSAGE_BLIT seems to be necessary in some situations, but I don't know which yet. I guess more investigation is needed here So please do not apply the patches yet

1 0

Re: msdmo: Fix calculation of array size in bytes
by James Hawkins 09 Apr '08

09 Apr '08

On Wed, Apr 9, 2008 at 4:16 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > msdmo: Fix calculation of array size in bytes. > > diff --git a/dlls/msdmo/dmoreg.c b/dlls/msdmo/dmoreg.c > index f6d71bd..c6eb1b6 100644 > --- a/dlls/msdmo/dmoreg.c > +++ b/dlls/msdmo/dmoreg.c > @@ -293,11 +293,11 @@ lend: > */ > HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[]) > { > -#define NAME_SIZE 80 /* Size of szName[] */ > WCHAR szguid[64]; > HRESULT hres; > HKEY hrkey = 0; > HKEY hkey = 0; > + enum {max_name_len = 80}; > DWORD count; > > TRACE("%s\n", debugstr_guid(clsidDMO)); > Don't you think a static const int would be even better? -- James Hawkins

2 1

optimizations for 1.0
by Steven Edwards 09 Apr '08

09 Apr '08

Hi, Given we are coming up close to the freeze, I think this may be a good time to look in to optimizations. I propose we spend some time trying different compilers and profiling Wine under different usage patterns to see what type of speedup we can get. I'm going to see if its possible to compile Wine with LLVM and I think it would be a good idea if someone with an ICC license gave it another shot. Also any gentoo users lurking, now would be a good time to go crazy with your compiler flags, run some benchmarks and file bug reports. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 5

Implement D3DXMatrixStack_Push
by David Adam 09 Apr '08

09 Apr '08

On 08/04/2008, David Adam <david.adam.cnrs at gmail.com <http://www.winehq.org/mailman/listinfo/wine-patches>> wrote: >* + This->current = This->current +1; *>* + HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, This->matrix, (This->current +1) * sizeof(D3DXMATRIX) ); *>* + if ( This->matrix == NULL ) return E_OUTOFMEMORY; * > Aside from being a bit suboptimal (doing a realloc on every push), > this probably doesn't do what you want. Consider what happens to the > size of the array when you do something like push/pop/push/pop/...etc. > > It would be better to keep track of the current stack size, and then > grow it by a factor (eg. 2 or 1.5) if a push would overflow the > current stack. > You could also consider shrinking the array again if a > pop would make it use less than a certain percentage of the current > size (eg. a third). This would increase the size of the stack exponentially. Would it be better to do this: Take a stack_size_reference (for instance 32 items) When This->current =32, then increase the size of the stack of stack_size_reference (that is 64 items now) Then when This->current is =64, again increase the size of the stack of stack_size_reference (that is 98 items now), and so on.... This would increase the size of the stack linearly instead of exponentially. In the opposite, for MatrixStack_Pop, assume that the size of the stack is 98 and This->current is 64. Then one could shrink the size of the stack from 98 to 98-size_stack_reference that is 64. > You should also assign the result of HeapReAlloc() to This->matrix > again. *I thought that HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, This->matrix, ..........);** * do exactly what you say Although it's quite possible for HeapReAlloc to just grow the > current block without changing its location, there's no guarantee it > will. The NULL check is useless this way. Thanks for your very useful feedback. David

3 4

Compile broken on Ubuntu Hardy/gutsy/feisty
by Austin English 09 Apr '08

09 Apr '08

In today's git, I can't compile in either my Kubuntu Hardy or Ubuntu feisty machines. A user also reported this on wine-user (1), using Ubuntu Gutsy (64bit). Compile is failing in make depend on: make[2]: Entering directory `/home/austin/wine-git/dlls/qedit/tests' ../../../tools/makedep -C. -S../../.. -T../../.. mediadet.c qedit.rc sound_test.avi: No such file or directory sound_test.avi was first included from qedit.rc:25 make[2]: *** [depend] Error 1 make[2]: Leaving directory `/home/austin/wine-git/dlls/qedit/tests' make[1]: *** [qedit/tests/__depend__] Error 2 make[1]: Leaving directory `/home/austin/wine-git/dlls' make: *** [dlls/__depend__] Error 2 Regression test points to: austin@austin-desktop:~/wine-git$ git bisect good d3061d48e1c78c331b93be7a880876ebff2730dd is first bad commit commit d3061d48e1c78c331b93be7a880876ebff2730dd Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Apr 8 16:53:52 2008 -0700 qedit: Implement IMediaDet_get_OutputStreams. :040000 040000 a897c878bae291a217075d8a2db3c6d04de1ad2a 6d6e883a2629e004b361ceb844a0ca0680a1fa75 M dlls The patch below fixes it: diff --git a/dlls/qedit/tests/qedit.rc b/dlls/qedit/tests/qedit.rc index a0b8b80..733beac 100644 --- a/dlls/qedit/tests/qedit.rc +++ b/dlls/qedit/tests/qedit.rc @@ -22,5 +22,5 @@ /* @makedep: test.avi */ TEST_AVI_RES AVI_RES_TYPE test.avi -/* @makedep: sound_test.avi */ +/* @makedep: test_sound.avi */ TEST_SOUND_AVI_RES AVI_RES_TYPE test_sound.avi I'll submit it to wine-patches. (1) http://forum.winehq.org/viewtopic.php?t=498

2 1

[PATCH 3/3] user32: fix a typo. (resend)
by Lei Zhang 09 Apr '08

09 Apr '08

Resending...

1 0

Re: qedit: fix compile error in qedit.rc
by Dan Hipschman 09 Apr '08

09 Apr '08

On Wed, Apr 09, 2008 at 12:10:55PM -0500, Austin English wrote: > /* @makedep: test.avi */ > TEST_AVI_RES AVI_RES_TYPE test.avi > -/* @makedep: sound_test.avi */ > +/* @makedep: test_sound.avi */ > TEST_SOUND_AVI_RES AVI_RES_TYPE test_sound.avi Oops, sorry, and thanks for fixing it.

1 0

.net 2 first light on nontrivial apps
by Dan Kegel 09 Apr '08

09 Apr '08

It looks like 'winetricks dotnet20' and current wine is good enough that .net support isn't quite the limiting factor anymore! See http://bugs.winehq.org/show_bug.cgi?id=8499 http://bugs.winehq.org/show_bug.cgi?id=12457 http://bugs.winehq.org/show_bug.cgi?id=12458 for three sizeable apps that actually put up their GUIs, at least briefly. MySQL Workbench actually runs well enough to explore the GUI.

2 2

Re: Updated three Power Profile functions to match MSDN
by Dmitry Timoshkov 09 Apr '08

09 Apr '08

"Black Dragon" <blackdragon1157(a)gmail.com> wrote: First of all Wine doesn't accept patches from an anonymous person, please use your real name. > + if(PowerCaps.SystemS4==TRUE && PowerCaps.HiberFilePresent==TRUE) { return TRUE; } > + else return FALSE; You should never compare against TRUE, and add braces only when necessary: return PowerCaps.SystemS4 && PowerCaps.HiberFilePresent; is much shorter and clearer. > + if(PowerCaps.SystemS5==TRUE) { return TRUE; } > + else return FALSE; Same here: return PowerCaps.SystemS5; or return PowerCaps.SystemS5 != 0; > + if(PowerCaps.SystemS1==TRUE && PowerCaps.SystemS2==TRUE && PowerCaps.SystemS3==TRUE) { return true; } > + else return FALSE; Same here, also don't use 'true', it's not portable. -- Dmitry.

2 1

Re: d3dx8: D3DXGetFVFVertexSize 2/4
by H. Verbeet 09 Apr '08

09 Apr '08

On 08/04/2008, Luis Busquets <luis.busquets(a)ilidium.com> wrote: > Implementation of D3DXGetFVFVertexSize. With this patch WINE responds > correctly to the tests of D3DXGetFVFVertexSize sent in patch 1/4 of today. > You have to either send the implementation first and the test afterwards, or wrap the test in a todo_wine block, and remove it when you send the implementation.

3 2

Re: LoadStringW [1/2]
by Dmitry Timoshkov 09 Apr '08

09 Apr '08

"Christopher" <raccoonone(a)procyongames.com> wrote: > +static void test_LoadStringW(void) > +{ > + HINSTANCE hInst = GetModuleHandle(NULL); > + WCHAR copiedstring[128], returnedstring[128], *resourcepointer = NULL; > + int strlen, strlen2; > + > + /* Check that the string which is returned by LoadStringW matches > + the string at the pointer returned by Load StringW when called with buflen = 0 */ > + strlen = LoadStringW(hInst, 2, (WCHAR *) &resourcepointer, 0); /* get pointer to resource. */ > + ok(strlen > 0, "LoadStringW failed to get pointer to resource 2, ret %d, err %d \n", strlen, GetLastError()); > + > + strlen2 = LoadStringW(hInst, 2, returnedstring, sizeof(returnedstring) /sizeof(WCHAR)); > + ok(strlen == strlen2, "LoadStringW returned different values dependent on buflen. ret1 %d, ret2 %d \n", > + strlen, strlen2); > + ok(strlen2 > 0, "LoadStringW failed to load resource 2, ret %d, err %d \n", strlen2, GetLastError()); > + > + if(resourcepointer != NULL) > + { > + memcpy(copiedstring, resourcepointer, strlen * sizeof(WCHAR)); > + copiedstring[strlen] = '\0'; > + } > + /* check that strings match */ > + ok(!memcmp(copiedstring, returnedstring, (strlen + 1)*sizeof(WCHAR)), > + "LoadStringW returned a string that does not match the string pointed to by the pointer it returned. \ > + returnedstring = %ls, copiedstring = %ls", returnedstring, copiedstring); > +} It's not clear what this test is supposed to show. If the 1st call to LoadStringW is supposed to set resourcepointer to not NULL, why don't you test it? Then 'if(resourcepointer != NULL)' check and copying to copiedstring are not needed. Also, if the test depends on a later patch to not fail, the test should be included in the patch. -- Dmitry.

4 15

Re: d3dx8 [6/7] Implement D3DXMatrixStack_Push
by tony.wasserka＠freenet.de 09 Apr '08

09 Apr '08

> > + This->current = This->current +1; > > + HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, This->matrix, (This->current +1) * sizeof(D3DXMATRIX) ); > > + if ( This->matrix == NULL ) return E_OUTOFMEMORY; > Aside from being a bit suboptimal (doing a realloc on every push), > this probably doesn't do what you want. Consider what happens to the > size of the array when you do something like push/pop/push/pop/...etc. > > It would be better to keep track of the current stack size, and then > grow it by a factor (eg. 2 or 1.5) if a push would overflow the > current stack. You could also consider shrinking the array again if a > pop would make it use less than a certain percentage of the current > size (eg. a third). > > You should also assign the result of HeapReAlloc() to This->matrix > again. Although it's quite possible for HeapReAlloc to just grow the > current block without changing its location, there's no guarantee it > will. The NULL check is useless this way. Just a little addition, I think we should resize the stack differently at different situations, i.e.: - resize it to (This->current+3) if This->currect<5 (something around that is the minimum number of matrices for which anyone would even bother using a MatrixStack) - resize it to (This->current*2) if This->current<12 (when it seems like the application's gonna push many matrices on the stack) - resize it to (This->current+16) if This->current>=12 (when *2 could waste memory) However, I don't know if these numbers are optimal, it's just a suggestion. For the Pop function, I agree that you should free some memory when it's unused, but my suggestion from above fits here, too. However, one third is okay, too, as it isn't that relevant here.

1 0

gdiplus: GdipAddPathArcI, GdipAddPathBezier implementation
by Nikolay Sivov 09 Apr '08

09 Apr '08

Is it something wrong with this patch? Changelog: - GdipAddPathArcI, GdipAddPathBezier implemented using existing calls Index: dlls/gdiplus/gdiplus.spec =================================================================== RCS file: /home/wine/wine/dlls/gdiplus/gdiplus.spec,v retrieving revision 1.170 diff -u -r1.170 gdiplus.spec --- dlls/gdiplus/gdiplus.spec 24 Mar 2008 12:57:16 -0000 1.170 +++ dlls/gdiplus/gdiplus.spec 7 Apr 2008 18:57:29 -0000 @@ -1,6 +1,6 @@ @ stdcall GdipAddPathArc(ptr long long long long long long) -@ stub GdipAddPathArcI -@ stub GdipAddPathBezier +@ stdcall GdipAddPathArcI(ptr long long long long long long) +@ stdcall GdipAddPathBezier(ptr long long long long long long long long) @ stdcall GdipAddPathBezierI(ptr long long long long long long long long) @ stdcall GdipAddPathBeziers(ptr ptr long) @ stub GdipAddPathBeziersI Index: dlls/gdiplus/graphicspath.c =================================================================== RCS file: /home/wine/wine/dlls/gdiplus/graphicspath.c,v retrieving revision 1.33 diff -u -r1.33 graphicspath.c --- dlls/gdiplus/graphicspath.c 4 Apr 2008 11:24:06 -0000 1.33 +++ dlls/gdiplus/graphicspath.c 7 Apr 2008 18:56:45 -0000 @@ -97,6 +97,13 @@ return Ok; } +GpStatus WINGDIPAPI GdipAddPathArcI(GpPath *path, INT x1, INT y1, INT x2, + INT y2, REAL startAngle, REAL sweepAngle) +{ + TRACE("%p %d %d %d %d %f %f\n",path,x1,y1,x2,y2,startAngle,sweepAngle); + return GdipAddPathArc(path, (REAL)x1, (REAL)y1, (REAL)x2, {REAL)y2, startAngle, sweepAngle); +} + GpStatus WINGDIPAPI GdipAddPathBezierI(GpPath *path, INT x1, INT y1, INT x2, INT y2, INT x3, INT y3, INT x4, INT y4) { @@ -158,6 +165,23 @@ return Ok; } +GpStatus WINGDIPAPI GdipAddPathBezier(GpPath *path, REAL x1, REAL y1, REAL x2, REAL y2, REAL x3, REAL y3, REAL x4, REAL y4) +{ + GpPointF points[3]; + + points[0].X = x1; + points[0].Y = y1; + points[1].X = x2; + points[1].Y = y2; + points[2].X = x3; + points[2].Y = y3; + points[3].X = x4; + points[3].Y = y4; + + TRACE("%p %f %f %f %f %f %f\n",path,x1,y1,x2,y2,x3,y3,x4,y4); + return GdipAddPathBeziers(path, points, 4); +} + GpStatus WINGDIPAPI GdipAddPathEllipse(GpPath *path, REAL x, REAL y, REAL width, REAL height) { Index: include/gdiplusflat.h =================================================================== RCS file: /home/wine/wine/include/gdiplusflat.h,v retrieving revision 1.155 diff -u -r1.155 gdiplusflat.h --- include/gdiplusflat.h 24 Mar 2008 12:57:16 -0000 1.155 +++ include/gdiplusflat.h 7 Apr 2008 18:55:25 -0000 @@ -182,6 +182,8 @@ GpStatus WINGDIPAPI GdipSetTextureTransform(GpTexture *,GDIPCONST GpMatrix*); GpStatus WINGDIPAPI GdipAddPathArc(GpPath*,REAL,REAL,REAL,REAL,REAL,REAL); +GpStatus WINGDIPAPI GdipAddPathArcI(GpPath*,INT,INT,INT,INT,REAL,REAL); +GpStatus WINGDIPAPI GdipAddPathBezier(GpPath*,REAL,REAL,REAL,REAL,REAL,REAL,REAL,REAL); GpStatus WINGDIPAPI GdipAddPathBezierI(GpPath*,INT,INT,INT,INT,INT,INT,INT,INT); GpStatus WINGDIPAPI GdipAddPathBeziers(GpPath*,GDIPCONST GpPointF*,INT); GpStatus WINGDIPAPI GdipAddPathEllipse(GpPath*,REAL,REAL,REAL,REAL);

1 0

Re: [PATCH 1/2] user32: add edit control check to see if its in a dialog on WM_CHAR/VK_RETURN.
by Alexandre Julliard 09 Apr '08

09 Apr '08

"Lei Zhang" <thestig(a)google.com> writes: > +static BOOL EDIT_IsInsideDialog(EDITSTATE *es) > +{ > + static WCHAR dialog_class[] = {'#','3','2','7','7','0',0}; > + WCHAR name[8]; > + int r; > + > + r = GetClassNameW(es->hwndParent, name, 8); > + if (r > 0) > + if (!lstrcmpW(name, dialog_class)) > + return TRUE; > + return FALSE; > +} You should test the WIN_ISDIALOG flag instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [10/10] d3d9: Some Windows drivers set undefined attributes to 0.0
by H. Verbeet 09 Apr '08

09 Apr '08

On 08/04/2008, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + Sleep(100000); Is that Sleep() really needed?

1 0

Re: d3dx9: Implement D3DXGetShaderVersion with tests 4/4
by H. Verbeet 09 Apr '08

09 Apr '08

On 08/04/2008, Luis Busquets <luis.busquets(a)ilidium.com> wrote: > This patch implements D3DXGetShaderVersion and adds tests to two simple > shader which have been extrated from d3d9/tests/shader.c > > + compare_shader_versions (simple_vs, 0xFFFE0101); > + compare_shader_versions (simple_ps, 0xFFFF0101); D3DVS_VERSION(1, 1) and D3DPS_VERSION(1, 1) would be more appropriate than 0xFFFE0101 and 0xFFFF0101 here.

1 0

Re: d3dx9: Implement D3DXGetShaderSize with tests 3/4
by H. Verbeet 09 Apr '08

09 Apr '08

On 08/04/2008, Luis Busquets <luis.busquets(a)ilidium.com> wrote: > This patch implements the function D3DXGetShaderSize and adds tests to two > simple shader which have been extrated from d3d9/tests/shader.c > > + /* We have to look for the end token 0x0000ffff which is D3DVS_END or D3DPS_END as both values are the same*/ > + while (*address!=D3DVS_END()) { The comment about D3DSIO_END still stands. > +#define compare_shader_sizes(shader, exp) \ > + shade=(DWORD *)shader; \ > + got=D3DXGetShaderSize(shader); \ > + ok(got==exp, "Expected: %d, Got: %d\n", exp, got); This is pretty ugly, but I guess it works. > + compare_shader_sizes (simple_vs, 84); > + compare_shader_sizes (simple_ps, 88); Please also test passing a NULL shader. (FWIW, sizeof(simple_vs) should also work instead of hardcoding 84 here, same for simple_ps)

1 0

Re: d3dx8: [7/7] Add tests for MatrixStack
by H. Verbeet 09 Apr '08

09 Apr '08

On 08/04/2008, David Adam <david.adam.cnrs(a)gmail.com> wrote: > While it's certainly good to test the normal usage of the API, it's also useful to test the behaviour of error conditions (Pop/LoadMatrix/GetTop on an empty stack, etc).

1 0

Re: d3dx8 {5/7] Implement D3DXMatrixStack_Pop
by H. Verbeet 09 Apr '08

09 Apr '08

On 08/04/2008, David Adam <david.adam.cnrs(a)gmail.com> wrote: > + if ( This->current == 0 ) > + { > + HeapFree(GetProcessHeap(), 0, This->matrix); > + return D3DERR_INVALIDCALL; > + } > + This->current = This->current -1; If This->current was 0 when calling Pop, it now points at a non-existing item. This would probably break things like LoadMatrix, GetTop, etc. Also, calling Pop again would result in a double free of This->matrix.

1 0

Re: d3dx8 [6/7] Implement D3DXMatrixStack_Push
by H. Verbeet 09 Apr '08

09 Apr '08

On 08/04/2008, David Adam <david.adam.cnrs(a)gmail.com> wrote: > + This->current = This->current +1; > + HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, This->matrix, (This->current +1) * sizeof(D3DXMATRIX) ); > + if ( This->matrix == NULL ) return E_OUTOFMEMORY; Aside from being a bit suboptimal (doing a realloc on every push), this probably doesn't do what you want. Consider what happens to the size of the array when you do something like push/pop/push/pop/...etc. It would be better to keep track of the current stack size, and then grow it by a factor (eg. 2 or 1.5) if a push would overflow the current stack. You could also consider shrinking the array again if a pop would make it use less than a certain percentage of the current size (eg. a third). You should also assign the result of HeapReAlloc() to This->matrix again. Although it's quite possible for HeapReAlloc to just grow the current block without changing its location, there's no guarantee it will. The NULL check is useless this way.

1 0

Re: Reece Dunn : comdlg32: Fix building the tests with MSVC headers.
by Francois Gouget 09 Apr '08

09 Apr '08

On Mon, 24 Mar 2008, Alexandre Julliard wrote: [...] > Commit: ae32a7fe0473aebb875b26083c1567ff046c3b80 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=ae32a7fe0473aebb875b26083… > > Author: Reece Dunn <msclrhd(a)googlemail.com> > Date: Sat Mar 22 22:50:43 2008 +0000 > > comdlg32: Fix building the tests with MSVC headers. [...] > +++ b/dlls/comdlg32/tests/printdlg.c > @@ -26,6 +26,7 @@ > #include "winerror.h" > #include "wingdi.h" > #include "winuser.h" > +#include "objbase.h" The question is why didn't this fail in Wine in the first place? The Wine headers must be different in some way which causes the compile to succeed when it should have failed. Thus they should be fixed. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ $live{free} || die "";

2 1

XDC 2008 wishlist
by Stefan Dösinger 09 Apr '08

09 Apr '08

Hi, My travel to XDC 2008 is finalized now, I am collecting the topics I should bring up there. I already have these: *) Mouse input handling. I've CC'ed Vitaliy. All I know so far is that Vitaliy said opening the core pointer as XInput device would be good. Vitaliy, do you have any proof of concept code / test apps? Do you have time to discuss the details? I think this is the most important topic, and I don't know anything about it, so I should be well-prepared. *) Tablet support. Dan mentioned something about it, but I have no details. *) Graphics support: I'll talk to the X11 devs about including the wine d3d tests in their driver QA. Lobby for widespread support of some rare extensions(GL_NV_half_float) and help on adding some others, like for the flat shading issue. Others? *) Discuss the opportunities we have with DRI2 Does anyone have other items?

3 4

Re: Add GdipCreateFontFamilyFromName stub try2
by Lei Zhang 09 Apr '08

09 Apr '08

On Tue, Mar 25, 2008 at 7:58 PM, Adam Petaccia <adam(a)tpetaccia.com> wrote: > This is needed, along with some other patches I'll be sending later to > make Richard Gariott's Tabula Rasa updater not crash at startup. > gcc says: font.c:126: warning: ISO C90 forbids mixed declarations and code font.c:131: warning: assignment discards qualifiers from pointer target type This doesn't work: ffamily->FamilyName = name; What happens is FontFamily is NULL? *FontFamily = ffamily;

1 0

Implementation of D3DXGetFVFVertexSize with tests
by David Adam 08 Apr '08

08 Apr '08

Hello, to keep the code readable, you should put your function in a new file. For instance, d3dx8/mesh.c would be fine (msdn put this functio in the mesh category). Otherwise, the whole code is going to implemented in the file d3dx8/d3dx8_main.c. What is the purpose of the line + ok(TRUE,"prueba"); ? Moreover, I think that this test should be implemented in d3dx8 too. If you want to test the difference between d3d8 and d3dx9, you should duplicate the test in d3dx9 then. David

2 1

Debian repository down
by Kai Blin 08 Apr '08

08 Apr '08

Hi folks, some user just reported on IRC that the wine.budgetdedicated.com repo is down. Seems like it's dead for over a day already. Do we know what's up with that and do we have an ETA for when it'll be back? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 5

Re: quartz: Add missing lock releases on some code paths (Smatch).
by Maarten Lankhorst 08 Apr '08

08 Apr '08

Hello, 2008/4/8, Michael Stefaniuc <mstefani(a)redhat.de>: > not sure if it's supposed to not release the thread_lock in that case > or if that's an omission that got copied around. +1, thanks for catching. Cheers, Maarten.

1 0

New winetricks 20080408: fixed dcom98
by Dan Kegel 08 Apr '08

08 Apr '08

Another day, another winetricks release. James Hawkins noticed that installing native dcom98 breaks everything now because it breaks three of the .exe's that wine starts internally. So I've updated winetricks to avoid overriding rpcrt4, ole32, and oleaut32 for those three exe. Once again, dcom98 is your friend. As always, the latest winetricks is online at http://kegel.com/wine/winetricks and the change history is online at http://winezeug.googlecode.com/ - Dan

1 0

Re: dlls/d3d9/tests/visual.c cleanup
by Stefan Dösinger 08 Apr '08

08 Apr '08

Am Dienstag, 8. April 2008 18:08:15 schrieb Gerald Pfeifer: > On Mon, 14 Jan 2008, Alexandre Julliard wrote: > > These tests don't make much sense, with or without your fix, plus the > > error messages don't match the tests. This needs more work. > > It seems this was added with 2007-11-07 with the following log entry: > > Stefan Dösinger <stefan(a)codeweavers.com> > wined3d: Shader Model 3.0 varying tests. > > I've seen patches in this area cleaning up some stuff. Does this > address the issues you were seeing? Otherwise, I'd hope Stefan can > have a look. > > Here is an updated patch of mine. The patch should be OK as it is a NOP functionally. I wonder why it is needed though, since I think that if all 3 lines look the same they're easier to read, but beauty is arguable. Does the patch fix some compiler warnings with some extra warnings enabled?

1 0

Re: [1/10] WineD3D: Store the number of aux buffers in the context
by Roderick Colenbrander 08 Apr '08

08 Apr '08

Detecting the number of aux buffers is trivial and can be done using the fake GL context as it is a WGL pixel format property. Roderick -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

2 3

appdb needs to list 0.9.47 in the pulldown, please
by Dan Kegel 08 Apr '08

08 Apr '08

Can somebody change the appdb to allow submitting results against 0.9.47? I think that's what Gutsy's bundled version of wine is. Somebody just submitted bogus results (with the wrong wine version) because we lack that option.

7 13

winecfg turned into control-panel-applets. see patch.
by pure_evil＠mail.bg 08 Apr '08

08 Apr '08

Well, this is my first patch. Here goes. It *enhances* winecfg's source and creates a winecfgcpl.cpl, which, when placed into ~/.wine/drive_c/windows/system32 shows the different "tabs" as different applets (six of them), visible via "wine control". 1.) Enhancements to winecfg - now the winecfg accepts new kind of console parameters which determine what tab(s) to show you. For all of you console junkies out there /like me!/ - this means that typing "winecfg audio" shows only the audio tab, "winecfg desktop" - the desktop integration tab and so forth for all six tabs. What "winecfg applications" does I leave to you ;) 2.) Based on the enhancements in winecfg, the .CPL itself. Each *applet* that appears in the control panel, calls winecfg with the appropriate parameter to get the job done. CPL features: -> six icons (drawn by me :D ) -> six control panel applets -> no longer an empty control panel -> translation capability for the Title/Description. Control Panel does not support Unicode atm, so the Bulgarian translation is the same as the English one; but the capability is there. This is what I have produced so far on the winecfg->wine control migration idea. Feedback?

1 0

wineasio 0.7.4
by Peter L Jones 08 Apr '08

08 Apr '08

Hi all, The on-going development of wineasio continues with the release of 0.7.4. This release is primarily aimed at fixing a couple of bugs and addressing some JACK xrun issues. I'm most interested in hearing from people who are having xruns with the 0.7.x series but for whom 0.5 (or 0.6a) works. Regards, -- Peter http://sourceforge.net/projects/wineasio

1 0

Re: [3/10] WineD3D: Make the min mip lookup type a texture property
by H. Verbeet 08 Apr '08

08 Apr '08

Shouldn't this be a property of the format rather than the texture?

2 1

AppDB Error, must enter to the "what didn't work" section?
by Bryan Haskins 08 Apr '08

08 Apr '08

" The following errors were found* Please enter what did not work." I understand the mechanics of why it says that, but realistically, should it for this field, be required to have data? For example, with me running WoW, it's flawless for me. Absolutely no problems, and I'm rating it platinum. If we're rating it platinum should this at least not be required then? Conversely, it should be required as a field, when it is rated anything but platinum, by definition. Just something I noticed.

2 1

Re: [1/2] qedit: Implement IMediaDet_put_Filename.
by Alexandre Julliard 08 Apr '08

08 Apr '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > +#define RELEASE(iface) \ > + do \ > + if (iface) \ > + { \ > + IUnknown_Release((IUnknown *) iface); \ > + iface = NULL; \ > + } \ > + while (0) Please avoid that sort of thing, it's ugly to modify what looks like an input argument inside a macro. Besides, you really don't need a macro for two lines of code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Alexandre Julliard : winex11: Fix handling of property sizes for 64-bit platforms.
by Ken Thomases 08 Apr '08

08 Apr '08

On Apr 7, 2008, at 6:50 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 3bfa90eedafc9bd2faf9bc421caa172547e8ddd6 > URL: http://source.winehq.org/git/wine.git/? > a=commit;h=3bfa90eedafc9bd2faf9bc421caa172547e8ddd6 > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Apr 7 11:41:54 2008 +0200 > > winex11: Fix handling of property sizes for 64-bit platforms. > > diff --git a/dlls/winex11.drv/clipboard.c b/dlls/winex11.drv/ > clipboard.c > index 2996857..2404a71 100644 > --- a/dlls/winex11.drv/clipboard.c > +++ b/dlls/winex11.drv/clipboard.c > @@ -1902,8 +1902,8 @@ static int X11DRV_CLIPBOARD_QueryAvailableData > (LPCLIPBOARDINFO lpcbinfo) > * The TARGETS property should have returned us a list of > atoms > * corresponding to each selection target format supported. > */ > - if (atype == XA_ATOM || atype == x11drv_atom(TARGETS)) > - X11DRV_CLIPBOARD_InsertSelectionProperties(display, > targetList, (cSelectionTargets * aformat / (8 * sizeof(Atom)))); > + if (aformat == 32 && (atype == XA_ATOM || atype == > x11drv_atom(TARGETS))) > + X11DRV_CLIPBOARD_InsertSelectionProperties(display, > targetList, cSelectionTargets); > > /* Free the list of targets */ > wine_tsx11_lock(); This appears to revert a30327afef7b08d1aac1943ded64ee363a61c537. That commit worked around a quartz-wm bug where it responds to the TARGETS query with a format of 8. -Ken

2 1

Re: [PATCH 14/15] wined3d: Add device->isInDraw checks in LoadLocation.
by Allan Tong 08 Apr '08

08 Apr '08

On Sun, Apr 6, 2008 at 5:06 PM, Alexander Dorofeyev <alexd4(a)inbox.lv> wrote: > > Prevents calling ActivateContext while holding gl lock, e.g. when > preloading texture in sampler(). There may be a problem here with drawPrimitive, which calls LoadLocation before ActivateContext while having isInDraw=TRUE. If the primary render target is an offscreen FBO surface, LoadLocation will follow the SFLAG_INTEXTURE path and it may end up making gl calls without a context in place. - Allan

3 5

USB Human Interface Device support
by Christopher 08 Apr '08

08 Apr '08

I have a flight sim, PhoenixRC, which I'd like to get working under Wine. As of a couple months ago most of the DirectX problems have been fixed, but the game uses a USB adapter to connect various controllers to the computer. The USB adapter is an HID and is recognized by Linux; however I can't get it to work through Wine. At least part of the problem seems to be that SetupDiGetClassDevs calls SETUPDI_EnumerateInterfaces which tries to open registry keys that don't exist. There isn't an entry in HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\DeviceClasses for HID interfaces, in fact that whole set of registry keys seems to be missing. Is anyone working on patches to make this work, or can someone point me to the function(s) that need to be implemented for HIDs to be setup in the registry correctly? I'm not sure when/how those keys are suppose to be created. Thanks, Christopher Berner

3 5

Free apps bundled with msvcr70?
by Dan Kegel 08 Apr '08

08 Apr '08

(This may sound like a repeat question, but last time I was asking about msvcr71, and thanks to the answers, that's now in winetricks.) Anybody have a good download link for an app that comes bundled with msvcr70 and msvcp70, i.e. one that was compiled with visual studio 2002?

2 3

appDB: Nice URLs live demo and code review
by John Klehm 07 Apr '08

07 Apr '08

Give nice urls a whirl at: http://appdb.klehm.net/app/"yoursearchtermhere" Search Examples: http://appdb.klehm.net/app/adobe http://appdb.klehm.net/app/visual Direct Link Examples: http://appdb.klehm.net/app/photoshop http://appdb.klehm.net/app/command-conquer-red-alert-2 See the nice urls being used internally: http://appdb.klehm.net/appbrowse.php?iCatId=5 Right now as it is I have it indexing only the app family names; no versions or vendors get any love. There is one piece of functionality missing before this can go in and that is to do an index of a new record upon creation. If anyone wants to test just apply the patch set and then flip APPDB_ENABLE_NICE_URLS_INDEXER to true and then run: runIndexer.php. Be sure to flip enable indexer back to false before doing anything else =P. You also need to set allow_url_fopen = On in your php.ini. If this is deemed to be unacceptable then we have to functionalize the objectManager.php file so matchByVerbAndTerm can generate similar output. Using url fopen allows easiest integration. After that you should be good to go to test. Essentially less terms will work better and the matching "nice" name depends entirely upon whatever the maintainer entered for the app family name. Let me know if any changes need be made otherwise ill send it in later this week. Regards, John Klehm

2 2

Re: ntoskrnl.exe: [2/2] Implement KeQueryInterruptTime
by Dmitry Timoshkov 07 Apr '08

07 Apr '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > +ULONGLONG WINAPI KeQueryInterruptTime( void ) > +{ > + ULONGLONG totaltime; > + > + KeQueryTickCount( (LARGE_INTEGER *) &totaltime); > + return totaltime; > +} Why not have a local variable of type LARGE_INTEGER and return li.QuadPart ? -- Dmitry.

2 1

Re: a proposed fix for bug 11690 concerning hhctrl.ocx
by Hin-Tak Leung 07 Apr '08

07 Apr '08

apologies - there was a typo in that patch - should be looking for "://" rather than "::/" . Otherwise my questions are the same. --- On Mon, 7/4/08, Hin-Tak Leung <htl10(a)users.sourceforge.net> wrote: > From: Hin-Tak Leung <htl10(a)users.sourceforge.net> > Subject: a proposed fix for bug 11690 concerning hhctrl.ocx > To: jacek(a)codeweavers.com, truiken(a)gmail.com > Cc: wine-devel(a)winehq.org > Date: Monday, 7 April, 2008, 7:02 PM > Hi Jacek and James - according to git, you two are the ones > last working on the part > of code which I have a possible fix for bug 11690 (see the > bug report for somebody > tested okay something like this), so I'd like to see > what you think of this patch, specially (and others can > chip in as well...) Here is what I think: > > NavigateToUrl() in hhctrl.ocx/help.c is only used by the > HH_HELP_CONTEXT case in HtmpHelpW() in hhctrl.ocx/hhctrl.c > - I think in some circumstances, it may return a full url, > but in the case of bug 11690, it returns a > "relative" one inside the same CHM, > so the code in NavigateToUrl() should drop through to look > up in chm. The top part of > NavigateToUrl() is really wrong because it assumes a > IWebbrowser_navigate would fail > on a relative url and drop through, but the way I see it, > Iwebbrower_navigate should return the status of whether > talking to IE/gecko is successful, not whether they gets > "404 not found". > > I have a few questions for you two: > 1) is there any known case where HH_HELP_CONTEXT returns a > fully formed URL? (i.e. if > this change is committed, it is going to break something > else?) > > 2) Since NavigateToUrl is only used once (and it needs to > drop through to NavigateToChm() in most cases, pending your > answer question 1), wouldn't it make sense > to just remove it? > > Thanks, > Hin-Tak > > > > ___________________________________________________________ > > Yahoo! For Good helps you make a difference > > http://uk.promotions.yahoo.com/forgood/ ___________________________________________________________ Yahoo! For Good helps you make a difference http://uk.promotions.yahoo.com/forgood/

1 0

Re: a proposed fix for bug 11690 concerning hhctrl.ocx
by Hin-Tak Leung 07 Apr '08

07 Apr '08

apologies - there was a typo in that patch - should be looking for "://" rather than "::/" . Otherwise my questions are the same. --- On Mon, 7/4/08, Hin-Tak Leung <htl10(a)users.sourceforge.net> wrote: > From: Hin-Tak Leung <htl10(a)users.sourceforge.net> > Subject: a proposed fix for bug 11690 concerning hhctrl.ocx > To: jacek(a)codeweavers.com, truiken(a)gmail.com > Cc: wine-devel(a)winehq.org > Date: Monday, 7 April, 2008, 7:02 PM > Hi Jacek and James - according to git, you two are the ones > last working on the part > of code which I have a possible fix for bug 11690 (see the > bug report for somebody > tested okay something like this), so I'd like to see > what you think of this patch, specially (and others can > chip in as well...) Here is what I think: > > NavigateToUrl() in hhctrl.ocx/help.c is only used by the > HH_HELP_CONTEXT case in HtmpHelpW() in hhctrl.ocx/hhctrl.c > - I think in some circumstances, it may return a full url, > but in the case of bug 11690, it returns a > "relative" one inside the same CHM, > so the code in NavigateToUrl() should drop through to look > up in chm. The top part of > NavigateToUrl() is really wrong because it assumes a > IWebbrowser_navigate would fail > on a relative url and drop through, but the way I see it, > Iwebbrower_navigate should return the status of whether > talking to IE/gecko is successful, not whether they gets > "404 not found". > > I have a few questions for you two: > 1) is there any known case where HH_HELP_CONTEXT returns a > fully formed URL? (i.e. if > this change is committed, it is going to break something > else?) > > 2) Since NavigateToUrl is only used once (and it needs to > drop through to NavigateToChm() in most cases, pending your > answer question 1), wouldn't it make sense > to just remove it? > > Thanks, > Hin-Tak > > > > ___________________________________________________________ > > Yahoo! For Good helps you make a difference > > http://uk.promotions.yahoo.com/forgood/ ___________________________________________________________ Yahoo! For Good helps you make a difference http://uk.promotions.yahoo.com/forgood/

1 0

a proposed fix for bug 11690 concerning hhctrl.ocx
by Hin-Tak Leung 07 Apr '08

07 Apr '08

Hi Jacek and James - according to git, you two are the ones last working on the part of code which I have a possible fix for bug 11690 (see the bug report for somebody tested okay something like this), so I'd like to see what you think of this patch, specially (and others can chip in as well...) Here is what I think: NavigateToUrl() in hhctrl.ocx/help.c is only used by the HH_HELP_CONTEXT case in HtmpHelpW() in hhctrl.ocx/hhctrl.c - I think in some circumstances, it may return a full url, but in the case of bug 11690, it returns a "relative" one inside the same CHM, so the code in NavigateToUrl() should drop through to look up in chm. The top part of NavigateToUrl() is really wrong because it assumes a IWebbrowser_navigate would fail on a relative url and drop through, but the way I see it, Iwebbrower_navigate should return the status of whether talking to IE/gecko is successful, not whether they gets "404 not found". I have a few questions for you two: 1) is there any known case where HH_HELP_CONTEXT returns a fully formed URL? (i.e. if this change is committed, it is going to break something else?) 2) Since NavigateToUrl is only used once (and it needs to drop through to NavigateToChm() in most cases, pending your answer question 1), wouldn't it make sense to just remove it? Thanks, Hin-Tak ___________________________________________________________ Yahoo! For Good helps you make a difference http://uk.promotions.yahoo.com/forgood/

1 0

Re: d3dx8: D3DXCreateMatrixStack
by tony.wasserka＠freenet.de 07 Apr '08

07 Apr '08

> Well no, you keep track of the array size and grow it when it's too > small when doing a push. i.e. HeapReAlloc http://msdn2.microsoft.com/en-us/library/aa366704(VS.85).aspx You may optimize that if you allocate space for 2 or so matrices at once, as it decreases the number of HeapReAlloc calls. However, for a basic implementation this isn't relevant, yet.

1 0

d3dx8: D3DXCreateMatrix
by David Adam 07 Apr '08

07 Apr '08

I agree that the good implementation is with array. The bad thing is that we must bound the size of the array ourself. I think that a size of 64 or 128 for the array is enough, right? The advantage of a list is that we do not need to take care about the size. David

2 1

Re: d3dx8 :Fix D3DXCreateMatrixStack
by tony.wasserka＠freenet.de 07 Apr '08

07 Apr '08

> The commit comment for this patch is rather non-descriptive... what is > this supposed to fix? > An array based stack seems more appropriate than a list based one for > ID3DXMATRIXStack, why change that? I think so, too (after taking a closer look at the interface documentation at msdn). Though it ain't really a good argument, but msdn gives a code example where they show that they use arrays internally: http://msdn2.microsoft.com/en-us/library/bb174057(VS.85).aspx m_pstack[m_currentPos] = m_pstack[m_currentPos] * (*pMat); Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

Re: d3dx8 :Fix D3DXCreateMatrixStack
by H. Verbeet 07 Apr '08

07 Apr '08

On 07/04/2008, David Adam <david.adam.cnrs(a)gmail.com> wrote: > The commit comment for this patch is rather non-descriptive... what is this supposed to fix? An array based stack seems more appropriate than a list based one for ID3DXMATRIXStack, why change that?

1 0

Fwd: [ubuntu-x] Future of digitizing tablet support in xorg?
by Dan Kegel 07 Apr '08

07 Apr '08

I ran one of our X issues by Bryce Harrington. Here's his reply: ---------- Forwarded message ---------- From: Bryce Harrington <bryce(a)canonical.com> Date: Sun, Apr 6, 2008 at 9:46 PM Subject: Re: [ubuntu-x] Future of digitizing tablet support in xorg? To: Dan Kegel <dank(a)kegel.com> Cc: ubuntu-x(a)lists.ubuntu.com On Sun, Apr 06, 2008 at 11:05:30AM -0700, Dan Kegel wrote: > At the moment, users of digitizing tablet > often have to compile x drivers themselves (!), e.g. > https://help.ubuntu.com/community/Wacom > https://help.ubuntu.com/community/TabletSetupWizardpen > which seems rather a throwback to the 90's. > And even if they don't have to compile the drivers > themselves, it seems users still have to edit xorg.conf. > > What are the prospects for moving from the current > situation to plug'n'play nirvana? > > I ask because Wine is getting good enough that > tablet issues like this are starting to become limiting > factors for Photoshop use in Ubuntu. For hardy we experimented with the new input hotplugging in xserver 1.4 (Timo in particular did extensive testing of it). Unfortunately, the new HAL approach with fdi files was proving to be even more complicated to configure than editing xorg.conf. Timo's testing also was turning up bugs a bit too readily. So we decided to hold off on it for now, and stick with the devil we know. The main deficiency that needs to be addressed is input configuration. The input hotplugging seems to work fine with default parameters, but as soon as a user wishes to set things to non-default values things get complicated. I think before we can really seriously consider moving to it, we need to have some configuration tools. So, I would like to see as a start, at least some sort of command line tool - the input device equivalent of 'xrandr'. GUI tools would be nice but can come in time. In addition, as I understand it, each of the input devices need to be updated to take advantage of input hotplug - much as each video driver has had to be updated to use Xrandr. So even though some drivers have transitioned, it may behoove us to wait until a larger proportion are updated. Bryce

1 0

Re: WINEDLLPATH, ddiwrapper, msvcrt40 (Re: wine based win32 printer drivers)
by Ulrich Hecht 07 Apr '08

07 Apr '08

Hi! On Saturday 05 April 2008, Hin-Tak Leung wrote: > 2) (to uli and Till) - do you mind if I put a mod/update of ddiwrapper > out publicly, or uli can release a new one that works with current > wine? Hand it over, and I'll put it on the FTP server and update our package. CU Uli -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)

1 0

Re: wined3d: Check for NULL vertex declarations
by H. Verbeet 07 Apr '08

07 Apr '08

On 07/04/2008, Chris Robinson <chris.kcat(a)gmail.com> wrote: > + if(!This->stateBlock->vertexDecl) { > + WARN("(%p) : Called without a valid vertex buffer set\n", This); That WARN is misleading.

2 1

MinGW cross compilation fails for d3dx9_36/tests
by Paul Vriens 07 Apr '08

07 Apr '08

Hi, We didn't have a new winetest executable for the last few days. MinGW doesn't know anything about a d3dx9 dll (yet) that's imported in the d3dx9_36 tests. Especially while in the process of getting ready for 1.0 we should have winetest run as much as possible. My main focus will be adding tests btw until 1.0 is out. These will be both tests to proof the correctness of the current implementation as well as tests to show missing stuff. There are loads of functions for which we have no tests yet and with the 1.0 in sight I think it becomes very important to have tests for virtually every function we (have) implement(ed). -- Cheers, Paul.

11 31

Proposal: versioning .wine directory
by Dan Kegel 07 Apr '08

07 Apr '08

On the wine-users list, we're getting a lot of users who have old or even ancient .wine directories, and whose problems go away with a fresh .wine directory Perhaps we should have wineprefixcreate stamp the version of wine the .wine directory was created with, make wine-1.0 refuse to run with pre-1.0 .wine directories, and require that future versions of wine run properly with .wine directories created by any earlier stable release of wine. It wouldn't be hard, at least at first, and it might save a lot of support inquiries. What say?

9 16

Re: ntoskrnl.exe: [1/2] Implement KeQueryActiveProcessors
by Dmitry Timoshkov 07 Apr '08

07 Apr '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > +KAFFINITY WINAPI KeQueryActiveProcessors( void ) > +{ > + DWORD_PTR AffinityMask; > + > + if (GetProcessAffinityMask( GetCurrentProcess(), &AffinityMask, NULL)) { > + return AffinityMask; > + } > + > + /* No Idea, what to do, when GetProcessAffinityMask fail. > + We use the first Processor */ > + return 1; > +} GetProcessAffinityMask() should never fail for the current process, so there is no need to add bogus code for that case. -- Dmitry.

1 0

Re: [PATCH 03/15] wined3d: In palette9_changed skip check if dxVersion <= 7.
by Stefan Dösinger 06 Apr '08

06 Apr '08

Am Sonntag, 6. April 2008 23:05:52 schrieb Alexander Dorofeyev: > Stops it from producing misleading messages in apps that don't use d3d8/9 > style palettes. Is there no other way to do this? In my opinion dxVersion checks are ugly and dxVersion should go away

2 1

Re: d3dx9: Implementation of D3DXGetShaderSize
by H. Verbeet 06 Apr '08

06 Apr '08

On 06/04/2008, Luis Busquets <luis.busquets(a)ilidium.com> wrote: > This function obtains the size of a shader bytestream. It does so looking > for the End token. > >+UINT D3DXGetShaderSize(DWORD * pFunction) I would expect this to take a const pointer. Also, there's no reason to use Microsoft's (broken) naming conventions for function arguments. > + while (*address!=0x0000ffff) { > + /*Let's check if the next DWORD is a comment*/ > + if ((*address&0x0000ffff)==0x0000fffe) { > + address=address+((*address >> 0x10) & 0x00007fff); > + } > + address=address+0x1; > + } It would help readability quite a bit to use the proper constants here. Also, please try to use an indentation style consistent with the rest of the dll and wine (this goes for the other patches as well). > + size=(address-pFunction+0x1)*sizeof(DWORD); Why the +1 here? Does it return the size without the end token itself? Tests and comments are always helpful there. The following (untested!) implementation looks more reasonable to me: UINT D3DXGetShaderSize(const DWORD *byte_code) { const DWORD *ptr = byte_code; if (!ptr) return 0; /* Look for the END token, skipping the VERSION token */ while (*++ptr != D3DSIO_END) { /* Skip comments */ if ((*ptr & D3DSI_OPCODE_MASK) == D3DSIO_COMMENT) { ptr += ((*ptr & D3DSI_COMMENTSIZE_MASK) >> D3DSI_COMMENTSIZE_SHIFT); } } /* Return the shader size in bytes, excluding the END token. */ return (ptr - (byte_code + 1)) * sizeof(*ptr); }

2 2

Re: d3dx8: Implementation of D3DXGetFVFVertexSize
by H. Verbeet 06 Apr '08

06 Apr '08

On 06/04/2008, Luis Busquets <luis.busquets(a)ilidium.com> wrote: > Implementation of D3DXGetFVFVertexSize. It does so by calculating all the > different publicly available posible vertex configuration types. > Same comments as for the d3dx9 version apply. (Why isn't the d3dx9 version a forward to d3dx8?)

2 1

Pulse Audio -- Wine should have instructions on this web site
by Susan Cragin 06 Apr '08

06 Apr '08

This site purports to give instructions on how to run certain applications, including Skype (which is 32-bit). I think wine should have instructions here too. http://www.pulseaudio.org/wiki/PerfectSetup It doesn't look like pulseaudio is going away from Ubuntu anytime soon. https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453

16 28

Re: [2/6] d3d9: Remove some test trace lines
by Allan Tong 06 Apr '08

06 Apr '08

On Sat, Apr 5, 2008 at 5:18 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > I think they're not needed any more now that the test works For what it's worth, this test fails for me with fbos. - Allan

2 1

Re: 0005-d3d9-add-stream_test-with-instancing
by Stefan Dösinger 06 Apr '08

06 Apr '08

Am Sonntag, 6. April 2008 17:11:10 schrieb Rico Schüller: > Hi, > > this is a patch, which contains a test for instancing. It proves the > behavior from these two patches: Alexandre: Note that this test needs my D3DCREATE_SOFTWARE_VERTEXPROCESSING->D3DCREATE_HARDWARE_VERTEXPROCESSING to work on Windows

1 0

Re: 0004-wined3d-improve-drawStridedInstanced
by Stefan Dösinger 06 Apr '08

06 Apr '08

Am Sonntag, 6. April 2008 17:07:45 schrieb Rico Schüller: > Hi, > > this patch solves a rendering problem with instances. Affected games are > Crysis and Gothic3. The test for this is in > 0005-d3d9-add-stream_test-with-instancing. So apply this first, > otherwise the tests will fail on wine. I think a comment why you're breaking out of the loop here would be helpful, perhaps mentioning the testcase in d3d9/tests. The same applies to the 0 instances -> 1 instance override

1 0

Re: 0003-wined3d-Filter-invalid-stuff-in-SetStreamSourceFreq
by Stefan Dösinger 06 Apr '08

06 Apr '08

Am Sonntag, 6. April 2008 17:03:41 schrieb Rico Schüller: > Hi, > > this patch filters out invalid parameter in SetStreamSourceFreq(). The > test for that is 0005-d3d9-add-stream_test-with-instancing. So apply > this first, otherwise the tests will fail on wine. You should write some message that the function returns an error, e.g. WARN("INSTANCEDATA used on stream 0, returning D3DERR_INVALIDCALL\n"); This eases debugging. I prefer a WARN for such cases. It won't be printed with the default FIXME loglevel, as it could be caused by an app bug, but it is more significant than a TRACE, since an invalid function call could be caused by incorrect behavior of Wine earlier on.

1 0

Re: ntdll:Add a semi-stub for SystemExecutionState in NtPowerInformation
by Jérôme Gardou 06 Apr '08

06 Apr '08

Le Saturday 05 April 2008 23:08:59, vous avez écrit : > This adds a semi-stub for SystemExecutionState in NtPowerInformation, > always considering that the user is acting with the computer. Please ignore this one, I sent the wrong file.

1 0

Re: d3dx9: Implementation of D3DXGetFVFVertexSize
by H. Verbeet 06 Apr '08

06 Apr '08

On 06/04/2008, Luis Busquets <luis.busquets(a)ilidium.com> wrote: > Implementation of D3DXGetFVFVertexSize. It does so by calculating all the > different publicly available posible vertex configuration types. > >+ switch (FVF & D3DFVF_XYZB5) { You should probably use D3DFVF_POSITION_MASK instead here. >+ for (i=0;i<((FVF&0x0f00) >> 16);i++) { This doesn't look right. Right shifting (FVF & 0x0f00) by 16 will always produce 0. Tests should have caught that.

1 0

Time zone info
by Erik de Castro Lopo 06 Apr '08

06 Apr '08

Hi all, My Linux TZ variable is set to Australia/NSW and I'm getting a bunch of fixmes like this: fixme:ntdll:find_reg_tz_info Can't find matching timezone information in the registry for bias -600, std (d/m/y): 6/04/2008, dlt (d/m/y): 5/10/2008 I've seen this post to this mailing list: http://winehq.org/pipermail/wine-patches/2008-March/052474.html so I understand that this timezone info is in the file tools/wine.inf. Whats the policy on adding things to this file and how does one go about it? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "The growing and dangerous intrusion of this new technology, threatens an entire industry's economic vitality and future security." -- Jack Valenti (MPAA president) on the video cassette recorder, 1982.

4 6

re pulse issues
by Susan Cragin 06 Apr '08

06 Apr '08

wine-0.9.58-438-g997bea9 Just downloaded & compiled latest git and did winetricks fakeie6 gdiplus. Noticed the following, so I thought I'd pass it along FWIW. Executing wine /home/susan/.winetrickscache/ppviewer.exe ALSA lib pcm.c:2106:(snd_pcm_open_conf) Cannot open shared library /usr/lib/alsa-lib/libasound_module_pcm_pulse.so ALSA lib pcm.c:2106:(snd_pcm_open_conf) Cannot open shared library /usr/lib/alsa-lib/libasound_module_pcm_pulse.so

2 1

Re: Pulse Audio -- Wine should have instructions on this web site
by Susan Cragin 06 Apr '08

06 Apr '08

Back to the initial question: Given what we have existing, right now, is there any set of instructions or workarounds that makes WINE apps work best? even killall pulseaudio ?? I would like to post them on the pulse web site if appropriate. I would also like to post them on the web site regarding installing Dragon NaturallySpeaking. Thanks.

2 1

Re: d3d9-Make-the-shader-test-more-precision-tolerant
by Stefan Dösinger 06 Apr '08

06 Apr '08

Am Sonntag, 6. April 2008 10:46:55 schrieb Rico Schüller: > Hi, > > this patch makes the cnd_test on windows happy. > > Cheers > Rico The patches look ok to me

1 0

Re: [PATCH 1 of 2] start.exe: add /Unix switch for starting files from unix file managers
by Hans Leidekker 06 Apr '08

06 Apr '08

On Sunday 06 April 2008 05:46:49 Vincent Povirk wrote: > -IMPORTS = shell32 user32 kernel32 > +IMPORTS = shell32 user32 kernel32 shlwapi If it's just StrCpyNW you need from shlwapi you might as well use an alternative like memcpy and avoid importing this dll. > + char multibyte_dospath[MAX_PATH]; That's a misnomer, you're storing a Unix path in the buffer. Dynamic allocation would make the code a bit more robust. > + WideCharToMultiByte(CP_ACP, 0, sei.lpFile, -1, multibyte_dospath, sizeof(multibyte_dospath)/sizeof(char), NULL, NULL); Should be CP_UNIXCP. -Hans

1 0

Crossbuild patch, appropriate for wine?
by John Klehm 05 Apr '08

05 Apr '08

Hey the following patch eases cross compiling of the dlls that use exceptions, its possible to work around this with scripts of course but this makes it much cleaner to do so. I wasnt sure if it was appropriate to include such a modification in wine though. This is based on what mingw does in its windef.h but I thought that excpt.h was more appropriate. See here for reference: http://cygwin.com/cgi-bin/cvsweb.cgi/src/winsup/w32api/include/windef.h?rev… With this patch the dlls that dont cross compile with wines headers are: dbghelp dnsapi gdi32 glu32 icmp iphlpapi kernel32 msvcrt ntdll opengl32 rpcrt4 secur32 shell32 winex11.drv wininet winmm ws2_32 Regards, John Klehm --- include/excpt.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include/excpt.h b/include/excpt.h index 3369f3b..081fb06 100644 --- a/include/excpt.h +++ b/include/excpt.h @@ -46,6 +46,10 @@ typedef enum _EXCEPTION_DISPOSITION unsigned long __cdecl _exception_code(void); void * __cdecl _exception_info(void); int __cdecl _abnormal_termination(void); +#elif defined(__GNUC__) && defined(USE_COMPILER_EXCEPTIONS) +#define __try +#define __except(x) while(0) +#define __finally #endif /* defined(_MSC_VER) && defined(USE_COMPILER_EXCEPTIONS) */ #endif /* __WINE_EXCPT_H */ -- 1.5.4.5

3 6

Wine 1.0 status: 70 days to release, 68 bugs to fix. 28 days to code freeze!
by Dan Kegel 05 Apr '08

05 Apr '08

Here are the 1.0 bug list changes since April 1: Fixed (by Stefan D. and Lei): 5955 directx- 8 DirectDrawCreate crash on non-OpenGL desktop New (by A.F. and Austin): 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) Deferred: 82 document 2 Stabilize Winelib User Guide Table of Contents We really shouldn't be adding any more 1.0 bugs at this point, but the new one is well-analyzed, and is said to affect Visual Studio, 3dsmax, and the copy protection scheme used by Autocad 2000, so what the heck. That's probably the last of its ilk, though. We're going to get a lot more cruel about deferring bugs as we get closer to release. For instance, issue 82. Winelib is kind of a secondary issue... not a whole lot of people should be using it, so it's probably ok to defer. And 'probably ok' is getting to be a good enough reason. Here's the full list of the 68 remaining bugs: 11420 advapi32 0 service control manager API problem: name of named objects might differ 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 3 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 4372 comctl32 1 listview: cannot drag several items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 11681 directx- 15 Add support for video overlay 5535 directx- 16 Planescape:Torment doesn't work 9030 directx- 0 army men hangs on black screen 3270 gdi32 15 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 38 Steam Friends doesn't work (fails to render correctly or refresh) 5024 kernel32 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5351 kernel32 9 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 9484 kernel32 19 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 13 USB serial ports do not work 9356 ntdll 7 Serial communication not working since wine-0.9.33 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 6607 ole 10 Drag and Drop not working 8095 ole 0 PQ Teaching toy crashes 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 12 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 4 Temple of Elemental Evil demo doesn't start - gui irresponsive 8439 shell32 8 Visual Studio .NET (7) install fails 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 12 tray minimize 5948 -unknown 1 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 7477 -unknown 1 Uplink demo crashes 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 7 "hello world" dos program hangs 9916 -unknown 6 "make test" usually fails 9959 -unknown 8 Make wine updates work even if the registry changed 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 11281 -unknown 3 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 664 user32 6 The help menu functionality inside programs is broken (messaging problem) 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 5623 winex11. 4 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps 10984 winex11. 5 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 3 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5625 wininet 4 Wine does not handle internet proxy settings conveniently 9787 winsock 47 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 1 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

3 4

Re: WINEDLLPATH, ddiwrapper, msvcrt40 (Re: wine based win32 printer drivers)
by Till Kamppeter 05 Apr '08

05 Apr '08

Hin-Tak Leung wrote: > 2) (to uli and Till) - do you mind if I put a mod/update of ddiwrapper out > publicly, or uli can release a new one that works with current wine? > > I have a third question - while looking at another XP driver for a paper-weight printer (konica-minolta magic color 2500W), it depends on msvcrt40.dll. > I am not of much help here. I have never really used wine (once for running a self-extracting .exe with a firmware for a didgital camera in it) and I also never packaged it for a distro. Till

1 0

DLL exports... HELP?!
by pure_evil＠mail.bg 05 Apr '08

05 Apr '08

Folks, I've been trying to make a bunch of control panel applets for wine for some time now. a CPL is basically a DLL which (the most importnat part) exports a function called "CPlApplet"; Without it, the cpl isn't worth a thing. It is the presence of that export which basically identifies it as a control panel applet. Indeed, opening a random .cpl with dllexp yields: Function: CPlApplet Address: 0x0041b604 Relative Address: 0x0041b604 Ordinal 1 (0x1) Filename: intl.cpl This one is from the cpl I wrote some time ago in Delphi, and it's the same with all other 'doze cpls. I'm working on porting it to C and wine, but that export is really getting the best of me. However, dllexp doesn't detect _any_ DLL exports in wine's .dlls, so I'm stuck without a template :( Am I missing something? (A simple *hello world* dll source that compiles against wine's source and exports ANY function would be greatly appreciated) Thanks in advance, Stefanov. ------------------------------------- Вземи 2 безплатни месеца БТК ADSL! Поръчай online дo 20 март 2008! Надежден Високоскоростен Интернет! http://www.btc.bg/bg/adsl_order.php?residential&action=order&view_pack=1 Folks, I've been trying to make a bunch of control panel applets for wine for some time now. a CPL is basically a DLL which (the most importnat part) exports a function called "CPlApplet"; Without it, the cpl isn't worth a thing. It is the presence of that export which basically identifies it as a control panel applet. Indeed, opening a random .cpl with dllexp yields: Function: CPlApplet Address: 0x0041b604 Relative Address: 0x0041b604 Ordinal 1 (0x1) Filename: intl.cpl This one is from the cpl I wrote some time ago in Delphi, and it's the same with all other 'doze cpls. I'm working on porting it to C and wine, but that export is really getting the best of me. However, dllexp doesn't detect _any_ DLL exports in wine's .dlls, so I'm stuck without a template :( Am I missing something? (A simple *hello world* dll source that compiles against wine's source and exports ANY function would be greatly appreciated) Thanks in advance, Stefanov.

5 13

re: Bug in MSVCRT_fseek (with patch)
by Dan Kegel 04 Apr '08

04 Apr '08

Does your test also pass on Windows? How did you run into this -- does the bug keep a real Windows app from running on Wine? Which one? To get your change and test accepted, please send a patch, and make the test a real wine conformance test. - Dan

2 2

softpub exported functions prototypes
by andre furtado 04 Apr '08

04 Apr '08

add softpub exported functions prototypes... HRESULT WINAPI GenericChainCertificateTrust(IN OUT PCRYPT_PROVIDER_DATA pProvData)HRESULT WINAPI GenericChainFinalProv(IN OUT PCRYPT_PROVIDER_DATA pProvData)HRESULT WINAPI HTTPSCertificateTrust(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI SoftpubDefCertInit(CRYPT_PROVIDER_DATA *pProvData)BOOL WINAPI SoftpubFreeDefUsageCallData(const char *pszUsageOID, CRYPT_PROVIDER_DEFUSAGE *psDefUsage)BOOL WINAPI SoftpubLoadDefUsageCallData(const char *pszUsageOID, CRYPT_PROVIDER_DEFUSAGE *psDefUsage)BOOL CALLBACK AddPersonalTrustDBPages(LPVOID lpv, LPFNADDPROPSHEETPAGE lpfnAddPage, LPARAM lParam) HRESULT WINAPI DriverCleanupPolicy(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI DriverFinalPolicy(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI DriverInitializePolicy(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI HTTPSFinalProv(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI OfficeCleanupPolicy(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI OfficeInitializePolicy(CRYPT_PROVIDER_DATA *pProvData)BOOL WINAPI OpenPersonalTrustDBDialog(HWND hWnd)HRESULT WINAPI OfficeInitializePolicy(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI SoftpubAuthenticode(CRYPT_PROVIDER_DATA *pProvData)BOOL WINAPI SoftpubCheckCert(CRYPT_PROVIDER_DATA *pProvData, DWORD idxSigner, BOOL fCounterSignerChain, DWORD idxCounterSigner)HRESULT WINAPI SoftpubCleanup(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI SoftpubDumpStructure(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI SoftpubInitialize(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI SoftpubLoadMessage(CRYPT_PROVIDER_DATA *pProvData)HRESULT SoftpubLoadSignature(CRYPT_PROVIDER_DATA *pProvData)HRESULT WINAPI FindCertsByIssuer(OUT PCERT_CHAIN pCertChains, IN OUT DWORD *pcbCertChains, OUT DWORD *pcCertChains, IN BYTE* pbEncodedIssuerName, IN DWORD cbEncodedIssuerName, IN LPCWSTR pwszPurpose, IN DWORD dwKeySpec) André Renato Furtado talk2cod(a)hotmail.com _________________________________________________________________ Conheça o Windows Live Spaces, a rede de relacionamentos do Messenger! http://www.amigosdomessenger.com.br/

2 1

Re: fusion: Test and implement CreateAssemblyNameObject
by James Hawkins 04 Apr '08

04 Apr '08

2008/4/4 James Hawkins <jhawkins(a)codeweavers.com>: > Hi, > > Changelog: > * Test and implement CreateAssemblyNameObject. > Please ignore this patch. -- James Hawkins

1 0

Re: xenroll exported functions
by Vitaliy Margolen 04 Apr '08

04 Apr '08

andre furtado wrote: > add documentation for exported functions of the xenroll library... > IEnroll * WINAPI PIEnrollGetNoCOM(void) > */ returns a pointer to an IEnroll interface. */ > IEnroll2 * WINAPI PIEnroll2GetNoCOM(void) > */ returns a pointer to an IEnroll2 interface. */ > IEnroll4 * WINAPI PIEnroll4GetNoCOM(void) > */ returns a pointer to an IEnroll4 interface. */ > André Renato Furtado > talk2cod(a)hotmail.com > <mailto:talk2cod@hotmail.com> > > ------------------------------------------------------------------------ > Instale a Barra de Ferramentas com Desktop Search e ganhe EMOTICONS para > o Messenger! É GRÁTIS! <http://www.msn.com.br/emoticonpack> > > > ------------------------------------------------------------------------ > > This does not look like a patch to me. Generate something that can be used with program 'patch'. For best results use git and 'git format-patch' as described in the wiki page you were pointed to in another reply. Vitaliy.

1 0

Documentation is still in CVS?
by Lei Zhang 04 Apr '08

04 Apr '08

Hi, Is there a reason why the Wine documentation is still in CVS, and not in GIT? - Lei

3 6

Lots of valgrind errors in gdi32/tests/font.c
by Dan Kegel 04 Apr '08

04 Apr '08

Today's valgrind run shows a bunch more valgrind warnings in gdi32/tests/font.c: http://kegel.com/wine/valgrind/logs-2008-04-04/vg-gdi32_font-diff.txt e.g. + Use of uninitialised value of size 4 + at HEAP_CreateFreeBlock (heap.c:502) + by HEAP_MakeInUseBlockFree (heap.c:538) + by RtlFreeHeap (heap.c:1294) + by GDI_FreeObject (gdiobj.c:731) + by FONT_DeleteObject (font.c:554) + by DeleteObject (gdiobj.c:854) + by enum_truetype_font_proc (font.c:1602) + by FONT_EnumInstance (font.c:589) + by WineEngEnumFonts (freetype.c:3761) + by FONT_EnumFontFamiliesEx (font.c:626) + by EnumFontFamiliesExA (font.c:664) + by func_font (font.c:1744) + by run_test (test.h:406) + by main (test.h:455) ... + Conditional jump or move depends on uninitialised value(s) + at RtlAllocateHeap (heap.c:1204) + by WineEngGetOutlineTextMetrics (freetype.c:4831) + by WineEngGetTextMetrics (freetype.c:4720) + by GetTextMetricsW (font.c:1158) + by X11DRV_XRender_SelectFont (xrender.c:433) + by X11DRV_SelectFont (xfont.c:3216) + by FONT_SelectObject (font.c:497) + by SelectObject (gdiobj.c:1129) + by enum_truetype_font_proc (font.c:1579) + by FONT_EnumInstance (font.c:589) + by WineEngEnumFonts (freetype.c:3761) + by FONT_EnumFontFamiliesEx (font.c:626) + by EnumFontFamiliesExA (font.c:664) + by func_font (font.c:1744) + by run_test (test.h:406) + by main (test.h:455) I don't think these are actually new; errors like them have been around, they just got triggered more with a new test that was added. It always worries me when heap routines start showing up in valgrind dumps, though; it'd be nice if somebody could take a look at this. - Dan

1 0

re: XDC 2008 wishlist
by Dan Kegel 04 Apr '08

04 Apr '08

On tablet support: 1) users should never, ever have to edit xorg.conf, but this is still needed when adding some graphics tablets. 2) users should never, ever have to compile their own drivers, but this is still required when using some graphics tablets. See e.g. https://help.ubuntu.com/community/TabletSetupWizardpen This is something that Photoshop-on-Wine users are actually running into. I don't know how common it is, but if I've already heard about it once, it's probably not rare. - Dan

1 0

Making Yahoo Messenger Work
by Brian Gitonga Marete 04 Apr '08

04 Apr '08

Hello, I am interested in making the latest versions of Yahoo Messenger work under Wine. Currently, an attempt to log in results in some errors about the RAS API, and Log in never succeeds. If someone (after attempting a run of the application under the latest version of Wine) could point me (even generally) to those parts of the Windows API Wine needs to allow Yahoo Messenger to work, I would be willing to do the work of implementing the necessary parts of the Win32 API myself. In this regard, I am especially interested that the Audio/Video chat aspects of Yahoo Messenger should work under Wine. Thanks, -- B. Gitonga Marete Tel: +254-722-151-590

1 0

Windows 7
by tony.wasserka＠freenet.de 04 Apr '08

04 Apr '08

I read an interesting article on slashdot today: http://tech.slashdot.org/tech/08/04/04/1437258.shtml > Windows 7 will be a from-the-ground-up packaging of the Windows codebase; partially source, > but not binary compatible with previous versions of Windows." Sounds like they format, i.e. maybe they use sth. other than PE then. But even if they don't, I guess this could be a problem for the existing wine codebase and require some infrastructural changes to it. However, I don't know much about these things though and it's possible that I'm completely wrong, but I though I'd just post this to wine-devel in case anybody is interested. Feel free to discuss, or not to discuss, do whatever you want with this information ;-) Maybe we're lucky and people turn away from windows completely this time and we don't even need to care about Windows 7 xD (though this is unlikely to happen, but dreams never die...) Best regards, Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

xenroll exported functions
by andre furtado 04 Apr '08

04 Apr '08

add documentation for exported functions of the xenroll library... IEnroll * WINAPI PIEnrollGetNoCOM(void)*/ returns a pointer to an IEnroll interface. */IEnroll2 * WINAPI PIEnroll2GetNoCOM(void)*/ returns a pointer to an IEnroll2 interface. */IEnroll4 * WINAPI PIEnroll4GetNoCOM(void)*/ returns a pointer to an IEnroll4 interface. */ André Renato Furtado talk2cod(a)hotmail.com _________________________________________________________________ Receba GRÁTIS as mensagens do Messenger no seu celular quando você estiver offline. Conheça o MSN Mobile! http://mobile.live.com/signup/signup2.aspx?lc=pt-br

1 0

Bug in MSVCRT_fseek (with patch)
by Kirill K. Smirnov 04 Apr '08

04 Apr '08

Hi, > A successful call to fseek() shall clear the end-of-file indicator > for the stream and undo any effects of ungetc() and ungetwc() on > the same stream. After an fseek() call, the next operation on an > update stream may be either input or output. > } >+ /* Clear end of file */ >+ file->_flag &= ~MSVCRT__IOEOF; > return (_lseek(file->_file,offset,whence) == -1)?-1:0; What if you try to fseek to the end of file (SEEK_END)? Should IOEOF flag be cleared in this case? And may _lseek() function be better place for this? Current _lseeki64() implementation contains FIXME concerning the same issue: MSVCRT_fdesc[fd].wxflag &= ~(WX_ATEOF|WX_READEOF); /* FIXME: What if we seek _to_ EOF - is EOF set? */ -- Kirill

2 1

Re: [PATCH 4/4] configure.ac: Add support for MSVC.
by Alexandre Julliard 04 Apr '08

04 Apr '08

Robert Shearman <rob(a)codeweavers.com> writes: > MSVC needs a lot more in the way of rule changes and/or helper scripts > for it to work properly, but this is a good start. I'm not sure I see the point. You can't really run configure or make on an MSVC setup anyway. It seems to me that something like msvcmaker is a better solution. -- Alexandre Julliard julliard(a)winehq.org

2 1

Bug in MSVCRT_fseek (with patch)
by Erik de Castro Lopo 04 Apr '08

04 Apr '08

Hi all, I think I have found a bug in MSVCRT_fseek. If I fread() to the end of a file, then do fseek (file, 0, SEEK_SET), the feof() function still returns true. According to the ISO standard A successful call to fseek() shall clear the end-of-file indicator for the stream and undo any effects of ungetc() and ungetwc() on the same stream. After an fseek() call, the next operation on an update stream may be either input or output. The following patch to dlls/msvcrt/file.c fixes the issue. I also have a small standalone test program below that fails before the patch and passes after. Cheers, Erik The patch: -------------8<-------------8<-------------8<-------------8<------------- --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -918,6 +918,8 @@ int CDECL MSVCRT_fseek(MSVCRT_FILE* file, long offset, int whence) if(file->_flag & MSVCRT__IORW) { file->_flag &= ~(MSVCRT__IOREAD|MSVCRT__IOWRT); } + /* Clear end of file */ + file->_flag &= ~MSVCRT__IOEOF; return (_lseek(file->_file,offset,whence) == -1)?-1:0; } -------------8<-------------8<-------------8<-------------8<------------- The test program: -------------8<-------------8<-------------8<-------------8<------------- #include <stdio.h> #include <stdlib.h> #include <stdarg.h> static void error_exit (const char * fmt, ...) { va_list ap ; va_start (ap, fmt) ; vprintf (fmt, ap) ; va_end (ap) ; exit (1) ; } /* error_exit */ int main (void) { const char * filename = "test.dat" ; char buffer [12] ; FILE * file ; /* Create a short data file. */ if ((file = fopen (filename, "w")) == NULL) error_exit ("Error on line %d : fopen\n", __LINE__) ; fputs("abcdefghaiklmnopqrstuvwxyz\n", file) ; fclose (file) ; /* Now read the file. */ if ((file = fopen (filename, "r")) == NULL) error_exit ("Line %d : fopen\n", __LINE__) ; while (fread (buffer, sizeof (buffer), 1, file) > 0) (void) 0 ; if (! feof (file)) error_exit ("Error on line %d : feof should return true.\n", __LINE__) ; fseek (file, 0, SEEK_SET) ; if (feof (file)) error_exit ("Error on line %d : feof should return false.\n", __LINE__) ; fclose (file) ; remove (filename) ; return 0 ; } /* main */ -------------8<-------------8<-------------8<-------------8<------------- -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "C++ has its place in the history of programming languages. Just as Caligula has his place in the history of the Roman Empire." -- Robert Firth

1 0

Re: [1/6] qedit: Add test framework and test for IMediaDet_put_Filename.
by Alexandre Julliard 04 Apr '08

04 Apr '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > This sets up some real tests for qedit using an actual AVI file to test > with. The resource is constructed from the AVI file by prepending the > size so we know how big it is in the code. That's ugly, you should use SizeofResource instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Lug Radio Live 2008 wine talk. Slides online, comments welcome.
by pure_evil＠mail.bg 04 Apr '08

04 Apr '08

Woah, that's ubercool. The presentation is excellent! However, you could add five collosal IMHO advantages of wine: 1. NO 1000 DISCONTINUED WIN VERSIONS That's what largely made me dump 'doze and go for Linux - got 6 W98 licenses, and at some point, upgraded the hardware to discover that 98 doesn't support the new Mainboards. So I spent two days trying to get all the MBs replaced, managed to get '98 running... And trust me, last thing you wanna do when you're in an empty new office is to extend a phone wire with a UTP wire to use the only connected atm phone socket to get dial-up working and with the collosal 5KBITS(!) per second to google out the only remaining in the PC store's warehouse mainboard to see if that supports '98, so you can call 'em and tell 'em "I'll take 'em". Oh, and you have to bring in your OWN PERSONAL machine to do that. The rest are basically a pile of mainboards which can't run '98 so they can't use the modem and so forth. And then enter my favorite software provider, sees the new machines, claps his hands and says: "Cool, new machines! Now you get the new windows version of the soft, and, it requires XP! And since you are the only ones to use the DOS version, it's discontinued from now on. Oh, and BTW? Your friendly local Samba server? Guess what, we're going MSSQL from now on, you need 1G of RAM on an XP machine... for 40 megs of databases." So with a thousand pains me gets the damn thing working on 98 and sacrifices TWO NEW MACHINES for the SQL server(s) and purchases TWO UNNECESSARY XP LICENSES - cuz two sets of databases, and, well, the express version doesn't support that. And things get better: "Yeah, you got it running under '98. Guess what, we'll be using cutting-edge stuff from now on; Now it's MSShitQL 2005, when something new comes out, you'll be upgrading; And once my soft becomes fully '98 incompatible, THEN you scrap the 98 licenses and by new, XP ones." "- But no money for licenses?" (1 XP = 1 new machine without monitor basically. Oh, and it has to be Professional) "- Bah, go pirate. Everybody's doing it." (What does he mean by on "cutting-edge stuff" BTW?! VISTA?! For an accounting database?!) And every once in a while when there's a bug in his soft, he attributes it to 98. Program closes but press ctrl-alt-del and you get a bunch of instances remaining? 98's fault. Slow? 98's fault. Crash due to an empty piece of database? "'98s fault". And of course, after 98s fault follows the natural "install XP". Enter wine. Select windows version = XP. Work. 2.) No Premium Basic Home Server Client whatever. Enter wine. Work. 3.) Easy reinstall. Delete "drive_c" and the reg files. "wineprefixcreate". Work. 4.) A 1000 windows on one machine. ~3 Megs per "drive_c". Work. 5.) Forget that "viruses under wine" stuff from days past, no, really. - No startup! Hide all you like in the registry you piece of cr... spyware, I won't even know you got there, nor will you ever get started! - No IE5678910! Yeah! Come and get me. - What, no normally inaccessible (even to NOD32 at some point) "System Volume Information"? Where are you gonna hide (or rather, stay exposed frustrating me)? - And where's the MBR of "drive_c"? in ".wine"? All that combined is what makes me want to develop for wine.

1 0

hypertrm exported functions
by andre furtado 04 Apr '08

04 Apr '08

add documentation for exported functions of the win32 hypertrm library... BOOL InitInstance(const HINSTANCE hInstance, const LPTSTR lpCmdLine, const int nCmdShow)/* creates the hypertrm session window. args: hInstance - apps instance handle. lpCmdLine - command line. nCmdShow - passed from winmain overhead function arglist. */ int MessageLoop(void) /* window message loop. return a wparam int value, that contains the additional information of the processed message. */ SF_HANDLE sessQuerySysFileHdl(const HSESSION hSession) /* returns the sysfile handle based on hypertrm session. args: hSession -> hypertrm session. */ HTRANSLATE sessQueryTranslateHdl(const HSESSION hSession) /* returns the translate handle associated with specific hypertrm session. translate handle is used for manager character translation. args: hSession -> hypertrm session. */ int sfGetSessionItem(const SF_HANDLE hSF, const UINT uID, unsigned long *pIDSize, void *pvData) /* is used to get data and item size from the session file handle. args: hSF -> session file handle. uID -> item id. [out] pIDSize -> size returned. [out] pvData -> a pointer to an buffer that receives the data. */ int sfPutSessionItem(const SF_HANDLE hSF, const unsigned int uID, const unsigned long uIDSize, const void *pvData) /* is used to add or modify an entry in the session file data associated with the current session file handle. args: hSF -> session file handle. uID -> item id. pIDSize -> size. pvData -> a pointer to an buffer of data. */ talk2cod(a)hotmail.com _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

3 3

Question about LoadImageW and gifs (affects all new Autodesk installers)
by Louis. Lenders 04 Apr '08

04 Apr '08

Hi, does anyone know if LoadImageW is supposed to work with *.gif files? I'm asking because Autodesk installers seem to so something like LoadImageW(0,"c:\\foo.gif",IMAGE_BITMAP, 0, 0, LR_LOADFROMFILE) and then wine just crashes later on, as it tries to get the bitmapinfo header , and ends up with wrong info for size of bitmapinfoheader, width, height etc. Anyone an idea why the installer would do such weird thing? See also http://bugs.winehq.org/show_bug.cgi?id=11784 ___________________________________________________________ Yahoo! For Good helps you make a difference http://uk.promotions.yahoo.com/forgood/

1 0

re: [1/6] qedit: Add test framework and test for IMediaDet_put_Filename.
by Dan Kegel 04 Apr '08

04 Apr '08

I think you can't depend on files existing in the source directory; you have to create them yourself (e.g. from a hex array in your source). Otherwise the unified winetest app that we use for semiautomated remote windows testing by users won't work. But if, say, WINETEST_INTERACTIVE is set, you can still use test.avi in the local directory instead of creating one.

2 2

Can we remove the rsabase tests?
by Paul Vriens 03 Apr '08

03 Apr '08

Hi, We have only a few (3) tests in the rsabase tests. The same tests are also available in the rsaenh tests. The reason I think they can be removed: - rsaenh seems to be available most platforms. If not then also rsabase is not available (by checking test.winehq.org) - rsabase is not available on XP and above - we forward all rsabase calls to rsaenh anyway -- Cheers, Paul.

2 1

broken mails from forum
by Tomas Kuliavas 03 Apr '08

03 Apr '08

Hi, Could somebody make sure that broken MIME messages are not send to mailing list. 8bit headers are not allowed. 8bit message body needs RFC2045 headers. By default courier-mta corrupts plain rfc822 messages with 8bit message body. -- Tomas

2 1

iTunes ipod support
by Maarten Lankhorst 03 Apr '08

03 Apr '08

Hi all, I submitted the ipod patches to wine-patches. This won't add support for ipod touch or iphones. I expect that all patches will be merged soon. If anyone feels adventurous they can try it. With the amount of people interested in it I decided to post an update on the mailing list so that everyone who picked up on the earlier threads can find it. Instructions: - Apply attached patch - Get a clean wineprefix - Set wine version to vista - Download the installer from itunes.com, and install. - wine net start ipod\ service - run itunes - Hopefully the ipod is detected now. Dapper might have a bug in hald which case it won't detect any usb hard drive that's plugged in. sudo killall hald; sudo hald; wineserver -k; wine net start ipod\ service seems to work as workaround. So far there seems to be some confusion, so for the sake of clarity: This won't add support for ipod touch or iphones. Cheers, Maarten.

1 0

Make test - opengl regression
by Austin English 03 Apr '08

03 Apr '08

Running on my virtualbox feisty vm, seems make test is making some progress: austin@austin-desktop:~/wine-git$ cat wine-0.9.58-439-g73bd68c.txt | grep 'make.*Error' make[2]: *** [exception.ok] Error 1 make[1]: *** [ntdll/tests/__test__] Error 2 make[2]: *** [opengl.ok] Error 1 make[1]: *** [opengl32/tests/__test__] Error 2 make[2]: *** [msg.ok] Error 24 make[1]: *** [user32/tests/__test__] Error 2 make: *** [dlls/__test__] Error 2 The visual.c's are skipping properly now for me, but there's a regression in opengl/opengl.c. ../../../tools/runtest -q -P wine -M opengl32.dll -T ../../.. -p opengl32_test.exe.so opengl.c && touch opengl.ok err:wgl:X11DRV_wglCreateContext Cannot get FB Config for iPixelFormat 0, expect problems! opengl.c:248: Test failed: Unable to confirm DONTCARE behavior of unset pixelformatdescriptor flags err:wgl:X11DRV_SetPixelFormat Invalid operation on root_window opengl.c:323: Tests skipped: No suitable pixel formats found make: *** [opengl.ok] Error 1 I haven't ran a regression test yet, but if you want more logs or a regression test, let me know.

1 1

Re: [PATCH 04/10] wined3d: Add ENTER_GL/LEAVE_GL in IWineD3DSurfaceImpl_Release.
by Allan Tong 03 Apr '08

03 Apr '08

Perhaps the call to ActivateContext should be moved outside of the if block since there are other gl calls in the function. Then you could move the glDeleteRenderbuffers block before the gdi section and combine the ENTER_GL/LEAVE_GL blocks into one. - Allan

2 1

Deactivate GL_FRAGMENT_SHADER_ATI before deactivating a context
by Milan Kostić 03 Apr '08

03 Apr '08

I'm use Mesa 7.01 because that version not have this problem (I try fragshader.c test from bug #15269). Bug is introduced earler with this commit, i'm warn about it but nobody listen because i'm not offering good solution: http://gitweb.freedesktop.org/?p=mesa/mesa.git;a=commit;h=e279a0a076b7a3c8d… Also with that commit several other regressions was introduced with r200 DRI driver. Maybe they will listen someone (Stefan:)) from here.

1 0

Re: [4/7] WineD3D: Macroize CheckDeviceFormat to reduce code duplication
by Roderick Colenbrander 03 Apr '08

03 Apr '08

In the end I think something like this is nice to do but not right now. CheckDeviceFormat has changed a lot and it is in good shape now but CreateTexture and friends don't do anything with the capabilities we report. In other words the next step should be to move flags (where possible) over to the pixel format table. E.g. in case of render targets and post pixel shader blending this has been done already. It can be done for a few more. Basically the Check*Capability functions somehow be placed in utils.c and the result would be cached in the pixel format table. Both CheckDeviceFormat and CreateTexture (and friends) would be able to use the information then. The Check*Capability calls in CheckDeviceFormat would then become AND-mask checks on the Flags field of a pixel format. This can all be done in small patches. Roderick > The main idea is to avoid that we have screen-sized code sections in this > function that look exactly the same. This should make navigation in the > code > easier > > Roderick: If you do not like that, just drop a note -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

1 0

Improving msxml3.dll as GSoC project
by Piotr Caban 03 Apr '08

03 Apr '08

Hi, I thought about improving msxml3.dll as GSoC project. There are some interfaces not implemented at all, some are not fully implemented. I found that there's quite a lot of bugs related to this dll in bugzilla. I have already sent an application. I thought about implementing SAXReader first (there are some applications that fails to install because of it, bugs 9682 and 6303). Afterwards I thought about implementing functions that are used by Photoshop installer (bug 8945, part related to msxml3.dll). I'm not really sure how long it will take but if there's enough time I'm going to fix more bugs (there are 33 bugs in bugzilla related with the dll). Afterwards I can implement more interfaces that are missing. More details can be found in the GSoC application. What do you think about the project idea? Do you have any suggestions? Regards, Piotr Caban

1 0

cygwin and -luuid build error?
by Jeroen Janssen 03 Apr '08

03 Apr '08

Hi, I don't know if building wine with cygwin is/should be supported. However, I get a linker error in dlls/atl with IID_IOleInPlaceSiteWindowless. It seems this symbol is in the uuid library. The "problem" it seems is that this library is linked with EXTRALIBS in Makefile.in and this doesn't result in the correct -L path to be set (essentially the libuuid.a can not be found by the linker). When I move -luuid from EXTRALIBS to IMPORTS, -L../../dlls/uuid is added to the linker and the library is correctly linked. Since it works ok on Linux, moving the -luuid option around is probably not a good solution, but I was wondering if anyone has looked into this before and if so what a good solution would be. Any thoughts on this? Best regards, Jeroen Janssen

2 1

Re: [4/7] WineD3D: Macroize CheckDeviceFormat to reduce code duplication
by Alexandre Julliard 03 Apr '08

03 Apr '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > The main idea is to avoid that we have screen-sized code sections in this > function that look exactly the same. This should make navigation in the code > easier It would be even better with an array of flag->function mappings and a simple loop over the flags to check. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: Remove tentative definition of static array with no size specifier
by James Hawkins 03 Apr '08

03 Apr '08

On Wed, Apr 2, 2008 at 5:07 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Whereas for a non-static array a tentative definition does not require a > size to be specified, for example: > > char ar[]; /* tentative definition */ > > char ar[] = "hello"; /* actual definition */ > > strictly, when the static storage specifier is applied, the size must be > specified: > > static char ar[5]; /* tentative definition */ > > static char ar[5] = "hello"; /* actual definition */ > > This patch avoids using a magic number by moving the definition of an array > and adding forward declarations for the functions affected, instead. > > -- Andy. > --- > Changelog: > msi: Remove tentative declaration of static array with no size specifier. > > diff --git a/dlls/msi/action.c b/dlls/msi/action.c > index 982c9f0..8cc36a0 100644 > --- a/dlls/msi/action.c > +++ b/dlls/msi/action.c > @@ -47,6 +47,64 @@ WINE_DEFAULT_DEBUG_CHANNEL(msi); > static UINT ACTION_ProcessExecSequence(MSIPACKAGE *package, BOOL UIran); > static UINT ACTION_ProcessUISequence(MSIPACKAGE *package); > static UINT ACTION_PerformActionSequence(MSIPACKAGE *package, UINT seq, BOOL UI); > +static UINT ACTION_AllocateRegistrySpace( MSIPACKAGE *package ); > +static UINT ACTION_BindImage( MSIPACKAGE *package ); > +static UINT ACTION_CostFinalize(MSIPACKAGE *package); > +static UINT ACTION_CostInitialize(MSIPACKAGE *package); > +static UINT ACTION_CreateFolders(MSIPACKAGE *package); > +static UINT ACTION_CreateShortcuts(MSIPACKAGE *package); > +static UINT ACTION_DeleteServices( MSIPACKAGE *package ); > +static UINT ACTION_ExecuteAction(MSIPACKAGE *package); > +static UINT ACTION_FileCost(MSIPACKAGE *package); > +static UINT ACTION_InstallExecute(MSIPACKAGE *package); > +static UINT ACTION_InstallFinalize(MSIPACKAGE *package); > +static UINT ACTION_InstallInitialize(MSIPACKAGE *package); > +static UINT ACTION_InstallSFPCatalogFile( MSIPACKAGE *package ); > +static UINT ACTION_InstallValidate(MSIPACKAGE *package); > +static UINT ACTION_IsolateComponents( MSIPACKAGE *package ); > +static UINT ACTION_LaunchConditions(MSIPACKAGE *package); > +static UINT ACTION_MigrateFeatureStates( MSIPACKAGE *package ); > +static UINT ACTION_MoveFiles( MSIPACKAGE *package ); > +static UINT ACTION_MsiPublishAssemblies( MSIPACKAGE *package ); > +static UINT ACTION_MsiUnpublishAssemblies( MSIPACKAGE *package ); > +static UINT ACTION_InstallODBC( MSIPACKAGE *package ); > +static UINT ACTION_InstallServices( MSIPACKAGE *package ); > +static UINT ACTION_PatchFiles( MSIPACKAGE *package ); > +static UINT ACTION_ProcessComponents(MSIPACKAGE *package); > +static UINT ACTION_PublishComponents(MSIPACKAGE *package); > +static UINT ACTION_PublishFeatures(MSIPACKAGE *package); > +static UINT ACTION_PublishProduct(MSIPACKAGE *package); > +static UINT ACTION_RegisterComPlus( MSIPACKAGE *package ); > +static UINT ACTION_RegisterProduct(MSIPACKAGE *package); > +static UINT ACTION_RegisterTypeLibraries(MSIPACKAGE *package); > +static UINT ACTION_RegisterUser(MSIPACKAGE *package); > +static UINT ACTION_RemoveDuplicateFiles( MSIPACKAGE *package ); > +static UINT ACTION_RemoveEnvironmentStrings( MSIPACKAGE *package ); > +static UINT ACTION_RemoveExistingProducts( MSIPACKAGE *package ); > +static UINT ACTION_RemoveFolders( MSIPACKAGE *package ); > +static UINT ACTION_RemoveIniValues( MSIPACKAGE *package ); > +static UINT ACTION_RemoveODBC( MSIPACKAGE *package ); > +static UINT ACTION_RemoveRegistryValues( MSIPACKAGE *package ); > +static UINT ACTION_RemoveShortcuts( MSIPACKAGE *package ); > +static UINT ACTION_ResolveSource(MSIPACKAGE* package); > +static UINT ACTION_RMCCPSearch( MSIPACKAGE *package ); > +static UINT ACTION_SelfRegModules(MSIPACKAGE *package); > +static UINT ACTION_SelfUnregModules( MSIPACKAGE *package ); > +static UINT ACTION_StartServices( MSIPACKAGE *package ); > +static UINT ACTION_StopServices( MSIPACKAGE *package ); > +static UINT ACTION_UnpublishComponents( MSIPACKAGE *package ); > +static UINT ACTION_UnpublishFeatures(MSIPACKAGE *package); > +static UINT ACTION_UnregisterClassInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterComPlus( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterExtensionInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterFonts( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterMIMEInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterProgIdInfo( MSIPACKAGE *package ); > +static UINT ACTION_UnregisterTypeLibraries( MSIPACKAGE *package ); > +static UINT ACTION_ValidateProductID( MSIPACKAGE *package ); > +static UINT ACTION_WriteEnvironmentStrings( MSIPACKAGE *package ); > +static UINT ACTION_WriteIniValues(MSIPACKAGE *package); > +static UINT ACTION_WriteRegistryValues(MSIPACKAGE *package); > I object. Also, RFCs should be sent to wine-devel, not wine-patches. -- James Hawkins

4 7

batmeter exported functions
by andre furtado 03 Apr '08

03 Apr '08

André Renato Furtado, talk2cod(a)hotmail.com add documentation for exported functions of the win32 batmeter library... BOOL BatMeterCapabilities( PUINT *ppuiBatCount) *\ description: is used to determine if the batmeter lib can run on the host machine. return true on success (battery meter can run). params: out -> ppuiBatCount - points to a pointer which will be filled in with a pointer to the global battery count.*\ HWND CreateBatMeter( HWND hWndParent, HWND hWndFrame, BOOL bShowMulti, PBATTERY_STATE pbsComposite) *\ description: create, fetch data for and draw the batmeter window. returns a handle to the newly created battery meter window on success, null on failure. param: hWndParent - parent of the battery meter dialog. hWndFrame - frame to locate the battery meter dialog. bShowMulti - display mode (true -> multiple battery). opt -> pbsComposite - pointer to composite battery state.*\ HWND DestroyBatMeter(HWND hWnd) *\ description: destroy the batmeter window created with CreateBatMeter function. returns the handle of the batmeter parent window. params: hWnd - handle to the window to be destroyed. *\ BOOL PowerCapabilities() *\ description: is used to determine if the system has any power management capabilities which require ui support. return true if power management ui should be displayed. *\ BOOL UpdateBatMeter( HWND hWnd, BOOL bShowMulti, BOOL bForceUpdate, PBATTERY_STATE pbsComposite) *\ description: this function should be called when the battery meter parent window receives a WM_POWERBROADCAST, PBT_APMPOWERSTATUSCHANGE message, it will update the data in the global battery state list. if needed the display will also be updated. PARAMETERS: hWndBatMeter, hwnd of the battery meter dialog bShowMulti, display mode bForceUpdate, forces a ui update opt -> pbsComposite, pointer to composite battery state. *\ WM_POWERBROADCAST == 0x218 PBT_APMPOWERSTATUSCHANGE == 0xa _________________________________________________________________ Instale a Barra de Ferramentas com Desktop Search e ganhe EMOTICONS para o Messenger! É GRÁTIS! http://www.msn.com.br/emoticonpack

1 0

Re: [PATCH 4/7] widl: Support __fastcall and __pascal calling conventions.
by Dan Hipschman 03 Apr '08

03 Apr '08

On Wed, Apr 02, 2008 at 12:56:21PM +0100, Robert Shearman wrote: > @@ -186,13 +186,19 @@ static const struct keyword keywords[] = { > {"FALSE", tFALSE}, > {"TRUE", tTRUE}, > {"__cdecl", tCDECL}, > + {"__fastcall", tFASTCALL}, > + {"__pascal", tPASCAL}, > {"__int64", tINT64}, > {"__stdcall", tSTDCALL}, __pascal should come after __int64.

1 1

Re: msi: Remove tentative definition of static array with no size specifier
by Andrew Talbot 02 Apr '08

02 Apr '08

Andrew Talbot wrote: > strictly, when the static storage specifier is applied, the size must be > specified: > > static char ar[5]; /* tentative definition */ > > static char ar[5] = "hello"; /* actual definition */ > Of course, the size need not be specified in the case of the actual definition, so the following is what I should have typed. static char a[] = "hello"; /* actual definition */ -- Andy.

1 0

testing 3d graphics with vmware workstation 6.5 beta?
by Lei Zhang 02 Apr '08

02 Apr '08

I just got an email about the next vmware workstation beta: "Improved 3D graphics Support — Workstation 6.5 can now support DirectX9.0 accelerated 3D with shaders so you can run more applications inside your VM." Maybe this will help with running the 3d graphics test suite in virtual machines? http://communities.vmware.com/community/beta/workstation6.5

2 1

Nice feature?
by Warren Dumortier 02 Apr '08

02 Apr '08

Hello! I have a little proposition for Wine 1.0! Why not creating an error dialog when a dll is missing, it would help a lot of users! For example there's a dialog to install geck, why not a dialog that simply says you have to add a dll in the correct directory?

2 1

How can i bypass my bug?
by Warren Dumortier 02 Apr '08

02 Apr '08

Hi! Some time ago i fille din a bug report because a game (The Sims : Pet Stories) couldn't lanch, after some mails the problem was that Wine doesn't gave vertex shaders, is there anything i can do to have this game running on my linux box? The bug has been reported as duplicate, but her's the correct one: http://bugs.winehq.org/show_bug.cgi?id=8051 Is there any way t have the game running (vertex sharders emulation running?), by adding dlls maybe, installing DirectX and disable some dlls? Anything? Thanks, kind regards!

3 4

Re: mshtml: Added registry configuration to allow using Active Script engine for JavaScript scripts.
by Alexandre Julliard 02 Apr '08

02 Apr '08

Jacek Caban <jacek(a)codeweavers.com> writes: > + static const WCHAR key_nameW[] = > + {'S','o','f','t','w','a','r','e', > + '\\','W','i','n','e', > + '\\','M','S','H','T','M','L', > + '\\','S','c','r','i','p','t','O','v','e','r','r','i','d','e','s',0}; > + > + /* @@ Wine registry key: HKCU\Software\Wine\MSHTML\ScriptOverrides */ > + res = RegOpenKeyW(HKEY_CURRENT_USER, key_nameW, &hkey); > + if(res != ERROR_SUCCESS) > + return ret; Why do we need a configuration option for this? When would a user want to change it? -- Alexandre Julliard julliard(a)winehq.org

2 1

Some considerations about the Wine FUSE project for GSoC
by Kai Blin 02 Apr '08

02 Apr '08

Hi folks, after another chat about Wine's goals in respect to FUSE file systems on IRC, I just wanted to point the students who applied for this project already (I've Bcced them) at the goals Wine has for this GSoC project. For Wine, the goal is to create prototype FUSE file systems so we can figure out if this approach is useful to Wine at all. There is no immediate goal to include the file systems into Wine in the near future, we first want to know if they're what we need. I think it's important to be clear and outspoken about this so nobody starts working on this under the wrong assumptions. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 6

Recent imm changes triggered widespread valgrind errors?
by Dan Kegel 02 Apr '08

02 Apr '08

Aric, can you have a look? Any call to CreateWindow now spews lots of Valgrind errors. For instance, http://kegel.com/wine/valgrind/logs-2008-04-01/vg-advpack_install-diff.txt contains: + Conditional jump or move depends on uninitialised value(s) + at RtlInitUnicodeString (unicode.h:212) + by LoadLibraryExW (module.c:924) + by LoadLibraryW (module.c:968) + by ImmCreateContext (imm.c:143) + by X11DRV_SetupXIM (xim.c:510) + by x11drv_init_thread_data (x11drv_main.c:654) + by X11DRV_SetWindowPos (x11drv.h:517) + by set_window_pos (winpos.c:1919) + by WIN_CreateWindowEx (win.c:1121) + by CreateWindowExW (win.c:1351) + by manage_desktop (desktop.c:224) + by WinMain (explorer.c:136) + by main (exe_main.c:48)

2 2

Any particular reason we are using printf in the shlwapi/istream tests?
by Paul Vriens 02 Apr '08

02 Apr '08

Hi, Should these printf's be turned into trace/skip? -- Cheers, Paul.

2 2

Re: [2/5] setupapi: Changing pointers on SP_DEVINFO_DATA
by Alexandre Julliard 02 Apr '08

02 Apr '08

Alexander Morozov <amorozov(a)etersoft.ru> writes: > SETUPDI_AddDeviceToSet: changing pointers on SP_DEVINFO_DATA after > allocating new memory block for their array We shouldn't have to do that sort of thing. The data structure should be fixed to store pointers that don't have to be moved around. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: WINEX11.DRV: workaround for unstable window state while handling MapNotify (fixes bug 12196)
by Alex Villacís Lasso 02 Apr '08

02 Apr '08

Alex Villacís Lasso escribió: > > The attached patch seems to fix this issue for me. It issues > X11DRV_MapNotify > when it detects that the window is still marked as iconic on a > transition from > IconicState to NormalState. Please comment on this. > > See bug #12196 for full discussion. > > Changelog: > * Workaround for unstable window state when handling MapNotify at > window restore after minimize. Issue extra X11DRV_MapNotify call when > PropertyNotify detects still-iconic window on > IconicState->NormalState transition. > Is this patch incorrect? Nobody has commented on it, and it has not been applied either. -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: winex11.drv: Connect to XIM server dynamically. [take 2]
by Alexandre Julliard 02 Apr '08

02 Apr '08

Kusanagi Kouichi <slash(a)ma.neweb.ne.jp> writes: > + > + if (data->xic) > + return data->xic; > + > + xim = x11drv_thread_data()->xim; > + if (!xim) > + return NULL; > + > + return X11DRV_CreateIC(xim, data->whole_window, &data->xic); You shouldn't store a pointer to an internal field of the win_data structure, that makes things hard to follow. You should store win_data or hwnd in the pointer field and dereference it in the callback. > @@ -651,7 +651,10 @@ struct x11drv_thread_data *x11drv_init_thread_data(void) > if (TRACE_ON(synchronous)) XSynchronize( data->display, True ); > wine_tsx11_unlock(); > > - if (use_xim && !(data->xim = X11DRV_SetupXIM( data->display, input_style ))) > + data->xim = NULL; > + if (use_xim && > + !XRegisterIMInstantiateCallback(data->display, NULL, NULL, NULL, > + X11DRV_SetupXIM, (XPointer)&data->xim)) The XRegisterIMInstantiateCallback should go in xim.c, the initialization code in x11drv_main.c shouldn't need to know about such implementation details. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: imm: Keep track of context associations between HWND and HIMC
by Alexandre Julliard 02 Apr '08

02 Apr '08

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -93,12 +93,21 @@ typedef struct _tagTRANSMSG { > LPARAM lParam; > } TRANSMSG, *LPTRANSMSG; > > +typedef struct _tagContextAssociation { > + struct list entry; > + > + HWND *hwnds; > + UINT wndCount; > + HIMC context; > +} ContextAssociation; Wouldn't it be a lot easier to store the HIMC in a window property? -- Alexandre Julliard julliard(a)winehq.org

2 2

Minor regression introduced in user32
by Kolbjørn Fredheim 02 Apr '08

02 Apr '08

There is a regression introduced into the git tree that is causing some minor issues with Anarchy Online atleast(should be other applications affected aswell). On login, if you press enter instead of pushing "Login" a box will come up stating "You must select a charactername before playing! [OK]", this is before checking if the password is correct, or actually logging in to the account. I have never seen this box in the 2.5 years I've been playing Anarchy, so I can only speculate it's trying to select a character without actually having one selected in the drop-down box(ie. Sending the enter twice to the application). I bisected down to the following commit: # ~/tmp/wine-git $ git bisect good 41ea8f0e8a6fab93fa08da16ecc24260dbad327c is first bad commit commit 41ea8f0e8a6fab93fa08da16ecc24260dbad327c Author: Lei Zhang <thestig(a)google.com> Date: Tue Mar 25 19:09:38 2008 -0700 user32: Tweak how the edit control handles WM_GETDLGCODE. :040000 040000 5583dc91d4f658340fcab6169c5be12b18c5d862 114715be44f79ddf45a9c61a01b90ee624504c1a M dlls I didn't want to file a bug-report on it, due to it beeing in the current git, and 0.9.58 is ok, and my knowledge on this part of wine is rather limited. - Kolbjørn Fredheim ____________________________________________________________________________________ You rock. That's why Blockbuster's offering you one month of Blockbuster Total Access, No Cost. http://tc.deals.yahoo.com/tc/blockbuster/text5.com

2 1

Re: shell32: Handle a few cases in FO_COPY that arise from not double-NULL terminating the input
by Paul Vriens 02 Apr '08

02 Apr '08

James Hawkins wrote: > Hi, > > Fix for bug 9809. > > Changelog: > * Handle a few cases in FO_COPY that arise from not double-NULL > terminating the input. > > dlls/shell32/shlfileop.c | 11 +++- > dlls/shell32/tests/shlfileop.c | 122 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 130 insertions(+), 3 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi James, + /* no double-NULL terminator for pTo */ + memset(to, 'a', MAX_PATH); + lstrcpyA(to, "two.txt"); + shfo.pFrom = "one.txt\0"; + shfo.pTo = to; + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI; + retval = SHFileOperation(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(DeleteFileA("one.txt"), "Expected file to exist\n"); + ok(DeleteFileA("two.txt"), "Expected file to exist\n"); + + createTestFile("one.txt"); + + /* no FOF_MULTIDESTFILES, two files in pTo */ + shfo.pFrom = "one.txt\0"; + shfo.pTo = "two.txt\0three.txt\0"; + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI; + retval = SHFileOperation(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(DeleteFileA("one.txt"), "Expected file to exist\n"); + ok(DeleteFileA("two.txt"), "Expected file to exist\n"); + + createTestFile("one.txt"); + + /* no double-NULL terminator for pTo */ + memset(to, 'a', MAX_PATH); + lstrcpyA(to, "two.txt"); + shfo.pFrom = "one.txt\0"; + shfo.pTo = to; + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI; + retval = SHFileOperation(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(DeleteFileA("one.txt"), "Expected file to exist\n"); + ok(DeleteFileA("two.txt"), "Expected file to exist\n"); Isn't the last test the same as the first (in the above piece of code) ? -- Cheers, Paul.

1 0

user32: Implement BroadcastSystemMessage, try 6
by Maarten Lankhorst 02 Apr '08

02 Apr '08

Hello Paul, 2008/4/1, Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi Maarten, > > + if (!recipients) > + recipients = &recips; > + > > Will that work? Yes. recipients is a pointer. Cheers, Maarten.

2 1

Wine 1.0 status: T minus 73 days (!), 69 bugs left
by Dan Kegel 02 Apr '08

02 Apr '08

Grumble. I was off by a week when I wrote http://wiki.winehq.org/WineReleasePlan I've adjusted the release dates to match our two-week cycle correctly this time (I hope). That pushed our release out one week... which means we finally have fewer bugs than days-to-release. Bugs fixed since last summary: 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine Bugs new since last summary (!): 4372 comctl32 0 listview: cannot drag several items 5535 directx- 16 Planescape:Torment doesn't work 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES (The first is arguable, but listview is pretty central, so ok. The second was closed by mistake earlier. The third is in one of our release criterion apps. Even though we only promise to fix *regressions* in those apps, we might as well try to fix newly discovered bugs, too.) Bugs deferred since last summary: 638 document 9 Document Wine debugging channels 4733 kernel32 5 Get optimized/compressed/packed executables (non-upx) working 4770 ole 3 BlackBerry Device Manager fails to install under wine 4971 -unknown 3 Corel Draw 12 demo install fails 9926 gdi32 5 gdi32.dll should not have exported function pointers 10905 shell32 0 thinstall firefox demo requires native msvcrt Current list of open bugs: ID Comp Votes Summary 5948 -unknown 1 Star Trek: Armada does not install 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 12246 -unknown 1 "make test" gives different results with and without warn+heap 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 8125 -unknown 0 Marratech 6.1 crashes on start 5402 -unknown 0 Trying to run PhotoStitch 3.1 11281 -unknown 2 CJK input many issues 9916 -unknown 6 "make test" usually fails 7477 -unknown 1 Uplink demo crashes 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 9178 -unknown 7 "hello world" dos program hangs 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 5844 -unknown 11 tray minimize 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 1 Reconcile the Windows and Wine spec files 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 4372 comctl32 0 listview: cannot drag several items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 11681 directx- 14 Add support for video overlay 5535 directx- 16 Planescape:Torment doesn't work 5955 directx- 8 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 82 document 2 Stabilize Winelib User Guide Table of Contents 6519 gdi32 7 Wine blacks out rotated font bitmap 3270 gdi32 15 Problem with minimized top-level windows 9771 gdi32 38 Steam Friends doesn't work (fails to render correctly or refresh) 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 18 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 5351 kernel32 9 Windows Installer 3.1 cannot install because of non-standard drive labeling 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 12 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 6607 ole 9 Drag and Drop not working 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 8095 ole 0 PQ Teaching toy crashes 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 6095 shdocvw 12 MOTD in counter-strike 1.6 and counter-strike source does not render 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 3546 shdocvw 2 CLSID_InternetShortcut not available... 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 8439 shell32 8 Visual Studio .NET (7) install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 664 user32 6 The help menu functionality inside programs is broken (messaging problem) 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 3023 user32 5 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 5623 winex11. 3 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 10984 winex11. 5 sun jre 5 update 10 installer hangs in 0.9.52 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 11019 winex11. 3 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5625 wininet 4 Wine does not handle internet proxy settings conveniently 9787 winsock 47 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

Bitrotting Translations
by Michael Stefaniuc 01 Apr '08

01 Apr '08

Hello guys, there are a couple resource file translations that are so way out of sync that they are commented out of the main rc file of the relevant module. programs/progman/rsrc.rc: ------------------------- - Da.rc - Danish - Fi.rc - Finnish - Sk.rc - Slovak - Sw.rc - Swedish (correct filename: Sv.rc) - Va.rc - Rumansh (Vallader) (correct filename: Rm.rc) - Wa.rc - Wallon This are so bitrotted that they don't even stink anymore but are nice fertile compost. Means they aren't even .rc files but .c/.h files. I have sent a patch to remove them. If somebody still wants to look at them they can with git show e.g.: git show wine-0.9.58:programs/progman/Va.rc programs/winecfg/winecfg.rc: ---------------------------- - Pt.rc - Portuguese (Brazil/Portugal) - It.rc - Italian - Si.rc - Slovenian This are only a little bit more broken but should be able to be fixed. If a native speaker could take care of them that would be really nice. Else I'll try to fix them myself or remove them if I fail after 1.0.0-rc1 comes out. programs/start/rsrc.rc: ----------------------- - Si.rc - Slovenian Looks like only a few characters (the non-7bit clean ones) are broken. Should be fairly easy to fix for a native speaker. Else I'll try to fix it myself after 1.0.0-rc1 comes out. bye michael

2 1

AppDB:Nice URLs Question on integration / Request for testing
by John Klehm 01 Apr '08

01 Apr '08

Hello, So I have a working "nice urls" implementatino here: http://appdb.klehm.net/app/ Simply enter in anything after app/ (e.g. http://appdb.klehm.net/app/visual-basic). At this point its better to enter in too little of the desired app name rather than too much. (better to have visual-basic or visual than visual-basic-7) So test away and let me know how to improve it or whatnot. Also as you'll see if you try it out, relative urls are broken (lack of css, so its ugly =P) because well the page we return is now relative to the searched term. As I see it we can integrate this with appdb in 2 ways. Make all urls absolute or make functions of the main viewing pages and pass a url base into them. Any ideas or comments on the best way to get around this problem would be great. Regards, John Klehm

1 0

Wine broken in feisty/git
by Austin English 01 Apr '08

01 Apr '08

Building today's git worked fine, until trying to run ~/wine-git/wine notepad, which results in a segmentation fault. Wine 0.9.58 from the reps works fine, as did rebuilding wine 0.9.58 in git. I'm starting the bisect now, but am about to leave this machine and won't be able to complete it until tomorrow. Anyone else seeing this?

4 6

msxml3 bug 10802
by viny 01 Apr '08

01 Apr '08

Hi, When creating an xml file, wine shouldn't create header automatically. Is that difficult to fix this bug (http://bugs.winehq.org/show_bug.cgi?id=10802) ? I've looked at domdoc.c but I'm not an expert...

2 1

Re: wininet: InternetReadFileExA should check INTERNET_FLAG_ASYNC.
by Hans Leidekker 01 Apr '08

01 Apr '08

On Thursday 27 March 2008 21:52:24 Dan Hipschman wrote: > incorrect. Here are a few Windows failures: > > http.c:584: Test failed: expected status 10 (INTERNET_STATUS_RESOLVING_NAME) 0 times, received 1 times > http.c:585: Test failed: expected status 11 (INTERNET_STATUS_NAME_RESOLVED) 0 times, received 1 times > http.c:587: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 2 times, received 1 times > http.c:588: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 2 times, received 1 times > http.c:589: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 2 times, received 1 times > http.c:590: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 2 times, received 1 times > http.c:591: Test failed: expected status 110 (INTERNET_STATUS_REDIRECT) 1 times, received 0 times Some of these are also failing when you run them through a proxy server. I put in some debug printing which confirmed that they only fail when the async flag is set. So the test seems to be racy; the higher latency of the proxy connection and your script with built in delays nicely explain that. -Hans

1 0

crash on exit in hardy on intel graphics?
by Dan Kegel 01 Apr '08

01 Apr '08

Grumble. wineprefixcreate is showing a crash while running rundll32.exe setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf No traceback is shown normally, but running that command under winedbg shows one on exit: Unhandled exception: page fault on read access to 0x00000200 in 32-bit code (0xb7f03bad). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:b7f03bad ESP:0034fa90 EBP:0034fab8 EFLAGS:00010292( - 00 -RISA1) EAX:b7f0bce0 EBX:b7f0bff4 ECX:b7efe5b9 EDX:b7c5e6ac ESI:00000000 EDI:00000000 Stack dump: 0x0034fa90: b7ef0eec b7f0bff4 0034fae0 7c017834 0x0034faa0: 0034fb14 b7efa059 0034fb5c b7c61ff4 0x0034fab0: 00000000 7c003188 0034fac8 b7c5fcb4 0x0034fac0: 00000000 b7f0bff4 0034fba8 b7efe5d6 0x0034fad0: 00000000 00000000 0034fb38 b7cce2d1 0x0034fae0: 7c003190 7c003198 7c003194 b7c5e6ac Backtrace: =>1 0xb7f03bad in ld-linux.so.2 (+0x12bad) (0x0034fab8) 2 0xb7c5fcb4 GLIBC_2+0xcb4() in libdl.so.2 (0x0034fac8) 3 0xb7efe5d6 in ld-linux.so.2 (+0xd5d6) (0x0034fba8) 4 0xb7c602bc in libdl.so.2 (+0x12bc) (0x0034fbc8) 5 0xb7c5fcea GLIBC_2+0xcea() in libdl.so.2 (0x0034fbd8) 6 0x7dda57bd in libgl.so.1 (+0x477bd) (0x0034fbf8) 7 0x7dd8584a in libgl.so.1 (+0x2784a) (0x0034fc18) 8 0x7dd87924 in libgl.so.1 (+0x29924) (0x0034fc48) 9 0x7dd80ba4 in libgl.so.1 (+0x22ba4) (0x0034fc58) 10 0x7ddc39bc glIsRenderbufferEXT+0x16c() in libgl.so.1 (0x0034fc68) 11 0xb7efefdf in ld-linux.so.2 (+0xdfdf) (0x0034fe18) 12 0xb7c90f74 exit+0xd4() in libc.so.6 (0x0034fe38) 13 0x7efacc80 RtlGetCurrentPeb() [/home/dank/wine-git/dlls/ntdll/process.c:70] in ntdll (0x0034fec8) 14 0x7ee7d62f ExitProcess+0x2f(status=0x0) [/home/dank/wine-git/dlls/kernel32/process.c:2046] in kernel32 (0x0034fee8) 15 0x7ecad3ba __wine_spec_exe_entry+0x6a(peb=0x7ffdf000) [/home/dank/wine-git/dlls/winecrt0/exe_entry.c:38] in rundll32 (0x0034ff08) 16 0x7ee7fd4e start_process+0xee(arg=0x0) [/home/dank/wine-git/dlls/kernel32/process.c:883] in kernel32 (0x0034ffe8) 17 0xb7de18f7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0xb7f03bad: testb $0x8,0x200(%edi) libgl.so is involved, so perhaps the is a graphics driver bug? The system is a thinkpad x60 with intel graphics. glxgears gets 960 fps. Anybody else seeing this? It seems kind of benign, and doesn't keep 'wine notepad' from working...

2 5

Re: user32: Implement BroadcastSystemMessage, try 6
by Paul Vriens 01 Apr '08

01 Apr '08

Maarten Lankhorst wrote: > Removed most LastError tests except where they are useful. > > > ------------------------------------------------------------------------ > > Hi Maarten, + if (!recipients) + recipients = &recips; + Will that work? Cheers, Paul

1 0

Re: SOC Direct3D - Implement missing D3D9_xx DLLs?
by tony.wasserka＠freenet.de 01 Apr '08

01 Apr '08

> Can someone confirm this to be already finished (and then remove this item from > the wiki?) If it isn't finished yet, what IS missing then? Nearly everything is missing. It's just the forwarding and some stubs that have been defined, yet, and the D3DXRenderToSurface implementation I submitted recently was coded with d3d9 traces, which was something AJ didn't like for reimplementing d3dx9. That means someone other needs to take care of that interface, but that's OT for this discussion. > D3D10_xx DLLs seem to be currently missing (I know we don't have any d3d 10 > implementation yet in wine) and it probably isn't a SOC project, but would > completely stubbed D3D10_xx DLLs (patches) be accepted if I submit them to the > patch mailinglist or not? I personally don't think it makes very much sense to stub a big library like d3dx10 without being able to really implement it (as we'd need d3d10 for this first). You could ask AJ for this on #winehackers, but I guess he'll be the same opinion. However, you can of course stub the d3dx10 dlls on your local tree and submit them when our d3d10 implementation is ready. > Ok, then the SOC text on the wiki for this item is slightly > "misleading" / outdated. I have updated the GSoC and D3DX wiki sites, so that one gets a very quick overview of how "far" we are with implementing it, yet. Best regards Tony

1 0

re: Wine Release Plan
by Dan Kegel 01 Apr '08

01 Apr '08

Paul V. wrote: >Just noticed that the dates attached to the versions on >http://wiki.winehq.org/WineReleasePlan are not correct. >0.9.58 came out on March 21st. >Does this mean we still stick to May 9th or do we stick to 0.9.61 as >being 1.0.0.rc1? Whoops, sorry 'bout that. Whatever Alexandre wants, as long as the release is in 2008 :-) I've updated the page to show correct dates. I inserted one more rc to keep the release in June, but I'm certainly open to other options if folks object. - Dan

1 0

Re: [2/2] cabinet.dll -> FDICopy: Bug fixed
by James Hawkins 01 Apr '08

01 Apr '08

2008/4/1 Vitaly Perov <vitperov(a)etersoft.ru>: > This is a bug fix for the FDICopy() function of cabinet.dll. > When you pass an empty cabinet file (It's correct cab-file, but it has no > files and folders inside) as a parameter, Wine detects that the file is > invalid. > In this case Windows return TRUE, but WINE return FALSE. So the installation > of certain software finishes with an error in WINE. > > Changelog: > - Added a bug fix for cabinet.dll FDICopy function. Now it works correctly > with an empty cab-files. > + if (!num_folders) + WARN("weird cabinet detect failure: This is an empty cabinet file \n"); + /* if num_folders is 0, it's correct cab, but empty */ If there's a test for this case, and it is a valid case, then why did you leave the WARN? -- James Hawkins

1 0

Re: [1/2] cabinet.dll -> FDICopy: Test added [Try 2]
by James Hawkins 01 Apr '08

01 Apr '08

2008/4/1 Vitaly Perov <vitperov(a)etersoft.ru>: > This test checks if function FDICopy() of cabinet.dll correctly works with an > empty cabinet file (It's correct cab-file, but it has no files and folders > inside). > In this case Windows return TRUE, but WINE return FALSE. So the installation > of certain software finishes with an error in WINE > > Changelog: > - Test added for cabinet.dll FDICopy function. This test checks if it > works correctly with an empty cab-files > @@ -593,9 +594,67 @@ static void test_FDIIsCabinet(void) delete_test_files(); } + +static void CreateEmptyCab(void) +{ + static const unsigned char file_array [] = { 0x4d, 0x53, 0x43, 0x46, + 0x00, 0x00, 0x00, 0x00, 0x24, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x24, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x01, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; + HANDLE hFile; + DWORD written; + BOOL result; + + hFile = CreateFile("test1.cab", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_TEMPORARY, NULL); + assert(hFile != INVALID_HANDLE_VALUE); + result=WriteFile(hFile, file_array, sizeof(file_array), &written, NULL); + CloseHandle( hFile ); + assert(result); /*can't write to file*/ +} + You need to use the FCI api to create this cabinet. +static void delEmptyCab(void) +{ + assert(DeleteFile("test1.cab")); +} + This is a very pointless function, just call DeleteFile("test...") in its place. Also, this isn't something that needs an assert. +INT_PTR __cdecl CopyProgress (FDINOTIFICATIONTYPE fdint, PFDINOTIFICATION pfdin) +{ + return FALSE; +} + Inconsistent style (space before opening parenthesis). +static void test_FDICopy(void) +{ + HFDI hfdi; + ERF erf; + BOOL ret; + char name[] = "test1.cab"; + char path[] = ""; /*native crashes if path=NULL*/ + The pszCabPath parameter of FDICopy should be the current directory. If you want to test using a relative cabinet path, do it in another test. + /* native crashes if hfdi is NULL or invalid*/ These comments don't really apply to the test you've added. You're only testing one thing (thus, unit test): how FDICopy responds to an empty cabinet. + hfdi = FDICreate(fdi_alloc, fdi_free, fdi_open, fdi_read, + fdi_write, fdi_close, fdi_seek, + cpuUNKNOWN, &erf); + ok(hfdi, "Expected non-NULL context\n"); + + /* TESTING FDICopy() */ Pointless comment, please remove it. + CreateEmptyCab(); + ret=FDICopy(hfdi,name,path,0,CopyProgress,NULL,0); + delEmptyCab(); Please move this (actually, a call to DeleteFile, see above) to the end of the function where cleanup happens. It gets in the way of the results of the test. + todo_wine + { + ok(ret, "Expected TRUE, got %d\n", ret); + } + If you're expecting TRUE, check for TRUE like the rest of the tests in this file. + /* successfully destroy hfdi*/ + ret = FDIDestroy(hfdi); + ok(ret, "Expected TRUE, got %d\n", ret); +} -- James Hawkins

1 0

ddiwrapper/Gsoc Re: DLL exports... HELP?! (wine based win32 printer drivers for openprinting)
by Hin-Tak Leung 01 Apr '08

01 Apr '08

So far only one person has signed up with gsoc to do the win32 print driver under linux... I found out why I couldn't build ddiwrapper earlier - it builds against latest wine now; the reason was that I was ripping from opensuse/suse src rpm, and I did not look at any of the bundled patch, and there is a bundled patch which does that. The authoritative site for ddiwrapper seems to be: ftp://ftp.suse.com/people/uli/ddiwrapper/ Although it is quite difficult to find, since most search engine gives various publibc part of suse/novell. I think the src.rpm bundled patch needs to go in properly as a new release, really. (uli(a)suse.de is the author of ddiwrapper). --- On Sun, 30/3/08, Detlef Riekenberg <wine.dev(a)web.de> wrote: > From: Detlef Riekenberg <wine.dev(a)web.de> > Subject: Re: DLL exports... HELP?! (wine based win32 printer drivers for openprinting) > To: "Hin-Tak Leung" <hintak_leung(a)yahoo.co.uk> > Cc: "Till Kamppeter" <till.kamppeter(a)gmail.com> > Date: Sunday, 30 March, 2008, 10:16 PM > On Sa, 2008-03-29 at 15:51 +0000, Hin-Tak Leung wrote: > > A personal question: would be like to be involved if a > student comes > > along, or in general in this area? (I looked it up, > you were the > > mentor for the 2007 wine project for the > printerproxy). > > > In general in this Area, Please. > > A applied as Mentor today to Help with the Applications > (winspool #at# googlemail.com) > > > You can reach me on irc (freenode.net) in #winehackers > My nick is "winspool" > > > -- > > By by ... Detlef __________________________________________________________ Sent from Yahoo! Mail. A Smarter Inbox http://uk.docs.yahoo.com/nowyoucan.html

1 0

Hey all, introducing myself and my GSoC idea...
by a a 01 Apr '08

01 Apr '08

My name is Alex. I'm an 18 year old Freshman at the University of South Florida. I'm an electrical engineer, but I've been coding since I was 13. I love low-level stuff, like assembly and ugly C, machine code, etc. I like to be able to smell the processor I'm so close to the metal. I made a proposal on GSoC to improve support for the Native API, an undocumented API in Windows. I'd really like to code for the Wine Project, since I like Windows, I like Linux, and I especially like low-level scrounging. I'm usually available by MSN, and generally fairly friendly. Send me an IM, or reply here to critique my proposal. It's entitled " Proposal to improve Wine's support of the Native API". I'm registered as cholinesterase(a)gmail.com. Will someone look it over and tell me what they think? Also, suggested reading would be nice, especially if it pertains to the project idea and Wine's code base! Thanks for reading.

5 6

Re: Greek translation patch correction
by James Hawkins 01 Apr '08

01 Apr '08

2008/3/31 Dj Apal [GR] <djapal(a)gmail.com>: > Here are the separate patches as requested by James Hawkins > One patch per email. I see that's not on the sending_patches page...man our documentation is in such bad shape (and scattered all over the place). -- James Hawkins

3 2

SOC suggestion - Vista Game Explorer APIs (needed for d3d10)
by Roderick Colenbrander 01 Apr '08

01 Apr '08

Hi, As the SOC deadline has been extended here another SOC project which I added to the wiki close to the previous deadline namely the Vista Game Explorer dll. Lots of users find Direct3D related projects cool. Part of the post-Wine-1.0 work will likely focus on D3D10. Just adding a full implementation of this dll won't get most games working as they use the Vista Game Explorer API for various purposes like storing game settings and profiles. Since this API is bundled with Windows we can't legally use Microsoft their dlls (if possible at all) and we need to add these APIs to Wine. This project would work on adding this dll. Regards, Roderick Colenbrander -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

1 0

SOC Direct3D - Implement missing D3D9_xx DLLs?
by Jeroen Janssen 01 Apr '08

01 Apr '08

Hi, I was looking at the Wine SOC wiki ( http://wiki.winehq.org/SummerOfCode ) and noticed an entry on "Direct3D - Implement missing D3D9_xx DLLs". As far as I can see there are already lots of D3D9_xx dlls in the tree that seem to forward stuf correctly. Can someone confirm this to be already finished (and then remove this item from the wiki?) If it isn't finished yet, what IS missing then? D3D10_xx DLLs seem to be currently missing (I know we don't have any d3d 10 implementation yet in wine) and it probably isn't a SOC project, but would completely stubbed D3D10_xx DLLs (patches) be accepted if I submit them to the patch mailinglist or not? Best regards, Jeroen Janssen

3 5

Re: d3d9: Add some visual tests for Direct3DDevice9_StretchRect()
by Stefan Dösinger 01 Apr '08

01 Apr '08

Am Dienstag, 1. April 2008 07:20:44 schrieb Jason Green: Did you take a look at the various capability flags? I think the test as you submitted it is correct for dx9 level cards and drivers, but there are a few capability flags like D3DDEVCAPS2_CANSTRETCHRECTFROMTEXTURE or similar. Also some drivers seem to refuse StretchRecting between offscreenplain surfaces, even if no stretching is used. Do you have any ideas what the scheme behind the allowed/forbidden blits is? So far I can see this: -> Blitting to a rendertarget surface/texture is always OK -> blitting between offscreen surfaces is ok as long as no stretching occurs -> blitting to non-RT surfaces/textures faily, except the above Did you test blitting from/to sysmem surfaces? The msdn says both must be D3DPOOL_DEFAULT as far as I remember

2 1

net: Display a more specific error message when a service command fails.
by Kirill K. Smirnov 01 Apr '08

01 Apr '08

Hi, >+ LPSTR pBuffer; >+ if (FormatMessageA(FORMAT_MESSAGE_FROM_SYSTEM | >+ FORMAT_MESSAGE_IGNORE_INSERTS | FORMAT_MESSAGE_ALLOCATE_BUFFER, >+ NULL, error, 0, (LPSTR)&pBuffer, 0, NULL)) >+ { >+ fputs(pBuffer, stdout); >+ LocalFree(pBuffer); >+ return TRUE; This is a glibc version of fputs, it DOES NOT work with wineconsole. -- Kirill P.S. Current implementation of output_string suffers from the same issue too.

1 0

Wine Release Plan
by Paul Vriens 01 Apr '08

01 Apr '08

Hi, Just noticed that the dates attached to the versions on http://wiki.winehq.org/WineReleasePlan are not correct. 0.9.58 came out on March 21st. Does this mean we still stick to May 9th or do we stick to 0.9.61 as being 1.0.0.rc1? -- Cheers, Paul.

2 1

kernel32: add stub for GetConsoleDisplayMode() et al
by Kirill K. Smirnov 01 Apr '08

01 Apr '08

Hi, In the first patch of the series you really implement SetConsoleDisplayMode() instead of GetConsoleDisplayMode(), don't you? And it is dangerous to return success in pure stub functions, especially GetConsoleDisplayMode(). Returning FALSE and setting last error to ERROR_CALL_NOT_IMPLEMENTED will be much better. -- Kirill

1 0

Re: [Bug 3297] UpdateWindow() doesn't call XFlush()
by James Hawkins 01 Apr '08

01 Apr '08

On Tue, Apr 1, 2008 at 3:15 AM, <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=3297 > > > Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Keywords|patch | > > > > > --- Comment #6 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-04-01 03:15:06 --- > The patch is obviously incorrect, so it doesn't count. > There are a lot of bugs with incorrect patches that have the patch keyword. The patch keyword is not to make sure that all bug reports with correct patches attached get those patches submitted and committed. The point of the keyword is to alert developers to a source of information. A user attaches a patch and says, "this makes the app work." Even if the patch is wrong, a developer can see what change makes the app work, and this can potentially help the developer write a correct patch. -- James Hawkins

1 0

Re: user32: Implement GetWindowModuleFileName with tests (try 2)
by Alexandre Julliard 01 Apr '08

01 Apr '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -3121,9 +3133,21 @@ UINT WINAPI GetWindowModuleFileNameA( HWND hwnd, LPSTR lpszFileName, UINT cchFil > */ > UINT WINAPI GetWindowModuleFileNameW( HWND hwnd, LPWSTR lpszFileName, UINT cchFileNameMax) > { > - FIXME("GetWindowModuleFileNameW(hwnd %p, lpszFileName %p, cchFileNameMax %u) stub!\n", > - hwnd, lpszFileName, cchFileNameMax); > - return 0; > + HINSTANCE hInst; > + UINT ret; > + TRACE("hwnd %p, lpszFileName %p, cchFileNameMax %u\n", hwnd, lpszFileName, cchFileNameMax); > + > + hInst = (HINSTANCE)GetWindowLongPtrW(hwnd, GWLP_HINSTANCE); > + if (!hInst) > + { > + if (hwnd == GetDesktopWindow() || !IsWindow(hwnd)) > + return 0; > + hInst = GetModuleHandleW(0); > + } > + > + ret = GetModuleFileNameW(hInst, lpszFileName, cchFileNameMax); > + TRACE("--> %d %s\n", ret, debugstr_wn(lpszFileName, ret)); > + return ret; This won't work across processes. -- Alexandre Julliard julliard(a)winehq.org

2 2

Valgrind errors up the yin-yang in CloseServiceHandle
by Dan Kegel 01 Apr '08

01 Apr '08

I don't have the full results yet, but here's a clue as to today's warn+heap regression referred to in http://bugs.winehq.org/show_bug.cgi?id=12246 that affects every program: ==12026== Invalid read of size 4 ==12026== at 0x4BDAECD: RPCRT4_CloseBinding (rpc_binding.c:301) ==12026== by 0x4BE0DB3: I_RpcFreeBuffer (rpc_message.c:1116) ==12026== by 0x4BC0BB2: NdrFreeBuffer (ndr_clientserver.c:173) ==12026== by 0x49375E6: svcctl_CloseServiceHandle (svcctl_c.c:119) ==12026== by 0x492F024: CloseServiceHandle (service.c:1008) ... ==12026== Address 0x7f000ec0 is not stack'd, malloc'd or (recently) free'd ==12019== Invalid read of size 4 ==12019== at 0x46E7F47: RtlEnterCriticalSection (critsection.c:482) ==12019== by 0x4986763: RpcAssoc_ReleaseIdleConnection (rpc_assoc.c:408) ==12019== by 0x4987F32: RPCRT4_CloseBinding (rpc_binding.c:308) ==12019== by 0x498DDB3: I_RpcFreeBuffer (rpc_message.c:1116) ==12019== by 0x496DBB2: NdrFreeBuffer (ndr_clientserver.c:173) ==12019== by 0x493E5E6: svcctl_CloseServiceHandle (svcctl_c.c:119) ==12019== by 0x4936024: CloseServiceHandle (service.c:1008) ==12019== by 0x48F4206: main (wineboot.c:586) ==12019== Address 0x7f000da4 is not stack'd, malloc'd or (recently) free'd ==12019== Invalid read of size 4 ==12019== at 0x4986764: RpcAssoc_ReleaseIdleConnection (rpc_assoc.c:409) ==12019== by 0x4987F32: RPCRT4_CloseBinding (rpc_binding.c:308) ==12019== by 0x498DDB3: I_RpcFreeBuffer (rpc_message.c:1116) ==12019== by 0x496DBB2: NdrFreeBuffer (ndr_clientserver.c:173) ==12019== by 0x493E5E6: svcctl_CloseServiceHandle (svcctl_c.c:119) ==12019== by 0x4936024: CloseServiceHandle (service.c:1008) ==12019== by 0x48F4206: main (wineboot.c:586) ==12019== Address 0x7f000d8c is not stack'd, malloc'd or (recently) free'd

1 0

Re: Greek translation patch
by James Hawkins 31 Mar '08

31 Mar '08

2008/3/31 Dj Apal [GR] <djapal(a)gmail.com>: > Hello all. > I'm Apostolos Alexiadis and I had created some time ago the greek patch for > comctl32. > I have made some changes to the previous file and also added 2 new > localization files for comdlg and hhctrl.ocx. > If there is something worng with the patch, please let me know > TIA > http://winehq.org/site/sending_patches specifically, "Submit one fix or group of related changes per patch." -- James Hawkins

1 0

re: Control-panel app. Works with mingw, need help with winegcc
by Dan Kegel 31 Mar '08

31 Mar '08

pure_evil wrote: > Here's source for a .cpl that compiles fine with dev-c++. > How can I make it work with winegcc? I had to do this to make winegcc happy: --- skeleton/skeleton.c 2008-03-31 09:00:55.000000000 -0700 +++ skeleton.ok/skeleton.c 2008-03-31 11:34:24.128617000 -0700 @@ -24,12 +24,12 @@ #include "skeleton.h" -LONG APIENTRY Applet1(HWND hwnd, UINT uMsg, LONG wParam, LONG lParam); +LONG APIENTRY Applet1(HWND hwnd, UINT uMsg, LPARAM wParam, LPARAM lParam); HINSTANCE hApplet = 0; APPLET Applets[1] = { {CPLICON, CPLNAME, CPLDESC, Applet1} }; -LONG APIENTRY Applet1(HWND hwnd, UINT uMsg, LONG wParam, LONG lParam) +LONG APIENTRY Applet1(HWND hwnd, UINT uMsg, LPARAM wParam, LPARAM lParam) { return 1; } LONG CALLBACK but then I was able to generate a DLL that worked with control like this: winegcc -mwindows skeleton.c -c -I ../wine-git/include winegcc -shared skeleton.dll.spec skeleton.o -o skeleton.dll.so -lkernel32 -lntdll -lshell32 -L ../wine-git/libs/wine wine control skeleton.dll.so Worked first try. (Good thing, too, since I was just copying what wine already does to build its dlls, and I wouldn't have known what to do if it failed.) Does that work for you? - Dan

2 1

re: translation
by Dan Kegel 31 Mar '08

31 Mar '08

> do u need an italian translator for your wiki/documentation? Maybe, but we could use one even more for our user interfaces; see http://pf128.krakow.sdi.tpnet.pl/wine-transl/lang.php?lang=010%3A00 - Dan

1 0

Re: user32: Implement BroadcastSystemMessage, try 5.1
by Alexandre Julliard 31 Mar '08

31 Mar '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > + TRACE("Flags: %08x, recipients: %p(0x%x), msg: %04x, wparam: %08lx, lparam: %08lx\n", flags, recipients, > + (recipients ? *recipients : recips), msg, wp, lp); > + > + if (flags > BSF_LUID) It doesn't make sense to compare flags with >. What are you trying to check for? > -} > + else > + FIXME("Recipients %08x not supported!\n", *recipients); > + > + if (ret > 0 && !GetLastError()) > + SetLastError(lasterror); In general if you have to save and restore last error you are doing something wrong. -- Alexandre Julliard julliard(a)winehq.org

3 8

re: News about iPod Sync and iTunes?
by Dan Kegel 31 Mar '08

31 Mar '08

wine-0.9.59 might be able to sync old-style iPods, but iPod Touch / iPhone is a horse of a different color because it acts like a usb device rather than a mass storage device. It'll be a long time before we support this.

1 0

News about iPod Sync and iTunes?
by Rainer M Krug 31 Mar '08

31 Mar '08

Hi are there any news / patrches on the iPod sync with iTunes? Thanks Rainer

2 1

translation
by Lorenzo M 31 Mar '08

31 Mar '08

do u need an italian translator for your wiki/documentation? i can do it properly. u doin very nice job. thanks from a satisfied user. bye -- ¤ acM ¤ Lorenzo M

2 1

Control-panel app. Works with mingw, need help with winegcc
by pure_evil＠mail.bg 31 Mar '08

31 Mar '08

Okay, this is as far as apparently I can make it on my own. This is the *basic* control panel applet. I used Dev-c++ (it's C though). It compiles with mingw and works flawlessly - you know, exports what it should export etc. etc. etc. The result, copied onto c:\windows\system32 shows up in the control panel and launches Notepad. However, I can't for the life of me get it to compile with winegcc (skip the usual "throw out "inlude windows.h" and insert "cpl.h"..." THEN it gets hairier). Help?

1 0

Re: setupapi: prevent page faults in SetupDiDeleteDeviceInterfaceRegKey
by Christopher 31 Mar '08

31 Mar '08

wine-devel-request(a)winehq.org wrote: > Message: 4 Date: Sun, 30 Mar 2008 19:13:46 -0600 From: Vitaliy > Margolen <wine-devel(a)kievinfo.com> Subject: Re: setupapi: prevent page > faults in SetupDiDeleteDeviceInterfaceRegKey To: wine-devel(a)winehq.org > Message-ID: <47F03ACA.5010308(a)kievinfo.com> Content-Type: text/plain; > charset=ISO-8859-1; format=flowed Christopher wrote: >> > Changelog: >> > Check that the handle and pointer passed to >> > SetupDiDeleteDeviceInterfaceRegKey are valid to read from. This patch >> > continues to address bug #12242 >> > >> > - if (!DeviceInterfaceData || >> > + if (!DeviceInterfaceData || IsBadReadPtr(DeviceInterfaceData, sizeof(SP_DEVICE_INTERFACE_DATA)) || >> > > Don't ever use IsBadReadPtr and IsBadWritePtr functions. They are bad and > even MS stopped using them. You have to use TRY-EXCEPT block around an > access to the memory. For example see implementation of lstrcpyA > (kernel32/string.c: 359). > > >> > + ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, "Expected SetupDiDeleteDeviceInterfaceRegKey to return FALSE, got %s, \ >> > +with error code: 6, got %d\n", ret ? "TRUE" : "FALSE", GetLastError()); >> > > This is bad way to split strings in c. Do something like this: > > ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, > "Expected SetupDiDeleteDeviceInterfaceRegKey to return FALSE, got %s, " > "with error code: 6, got %d\n", ret ? "TRUE" : "FALSE", GetLastError()); > > Vitaliy. Thanks for the comments! I found that Alexander Morozov's patches fix the same issue my patch was aimed at. After his are committed, I'll fix and resubmit mine if it's needed. Christopher Berner

1 0

Re: winex11.drv: Don't add owned windows to the taskbar
by Alexander Dorofeyev 31 Mar '08

31 Mar '08

Hi. There's a regression in IDA Pro disassembler. Nothing is added to the taskbar at all, furthermore, when you are starting debugger, before there was a window appearing that asks pass control to the application or not. Now it's not appearing, and can't be found because there's nothing on the taskbar, which is pretty bad because the app doesn't respond to any other input at that moment. Minimizing the main window makes the app disappear altogether, so it's pretty unusable. I've KDE 3.5. You can get free version (that has same symptoms) from http://www.datarescue.com/ to help tweaking this. Dmitry Timoshkov wrote: > Hello, > > this patch fixes the bug 12160. According to my tests explorer in XP > doesn't add owned windows to the taskbar. > > Changelog: > winex11.drv: Don't add owned windows to the taskbar. > ---

3 4

Re: GdipGraphicsClear function implementation and tests
by Alexandre Julliard 31 Mar '08

31 Mar '08

"Gynvael Coldwind" <gynvael(a)vexillium.org> writes: > + /* get width and height > + */ > + width = GetDeviceCaps(graphics->hdc, HORZRES); > + height = GetDeviceCaps(graphics->hdc, VERTRES); This won't do what you want. You should probably use something like GetClipBox() here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 5)
by Alexandre Julliard 31 Mar '08

31 Mar '08

Vitaliy <vitaliy(a)kievinfo.com> writes: > Resending. > > Try 5: > Split out change to user32 as a separate patch. > > Try 4: > This time with lots of tests that exposed number of other problems that were fixed. > > I could not separate this patch into separate pieces - they all linked together and > fixing one problem meant fixing or breaking something else. The message tests don't work: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so input.c && touch input.ok input.c:755: Test failed: a2/2: the msg sequence is not complete: expected 0000 - actual 000f make: *** [input.ok] Error 1 You most likely need to ignore all non-key messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

midl question
by Alistair Leslie-Hughes 31 Mar '08

31 Mar '08

Hi, In an IDL file I need to define the following typedef HRESULT (__stdcall *FExecuteInAppDomainCallback) (void* cookie); How do i get midl to understand what __stdcall is defined to? Best Regards Alistair Leslie-Hughes

3 6

Direct3D shader compiler infrastructure
by Stefan Dösinger 31 Mar '08

31 Mar '08

Hello, So, I am getting serious about a shader compiler and related things now, and I've made a design proposal. First of all, let us collect a few things we want regarding shader handling: -> D3DXCompileShader & Friends -> D3DXAssembleShader & Friends -> D3DXDisassembleShader & Friends -> A way to deal with d3d9 and d3d10 shader language differences All these items are related in some way, so I am proposing the following design of a shader library: The core part of the library is a wine internal shader language representing D3D assembler shaders. Shaders in this language can be created from D3D Bytecode("SlDisassembleShader"), D3D ASM("SlAssembleShader") and from HLSL("SlCompileShader"). From the intermediate language, D3D bytecode can be generated in various versions(SlGenBytecode), as well as D3D Text asm(SlGenAsm). Unlike regular D3D asm languages, this language does not have a version token, it is a superset of all asm language versions. It does have a pixel / vertex / geometry shader flag though. The motivation behind an intermediate language is to avoid writing many different code generators, which is a big part of the HLSL compiler. We also need a WineD3D intermediate language to share our shader generator between d3d9 and d3d10, and use it for both kinds of shaders. The requirements for both intermediate asm languages are the same. This motivates making the language the same to reuse code. With those functions, the D3DX functions are pretty streightforward: D3DXAssembleShader: bytecode = SlGenBytecode(SlAssembleShader(char *asm_text)); D3DXCompileShader: bytecode = SlGenBytecode(SlCompileShader(char *hlsl_text)); D3DXDisassembleShader asm_text = SlGenAsm(SlDisassembleShader(DWORD *bytecode)); WineD3D can be changed to use this shader language as shader input. In this case, d3d8, d3d9 and d3d10 run their shader bytecode through SlDisassembleShader, and pass the returned pointer to WineD3D. This in turn calls SlCopyShader to make a copy it owns, and d3d8/9/10 free their copy using SlDestroyShader. With WineD3D working on the same language, we have to share the language definition between the shader library and WineD3D, or put the shader compiler into WineD3D as well. I do not like the 2nd way, as it puts things together that don't have to be in one lib, and wastes runtime memory. A 3rd way I have to consider was a SlReadShader() function with callbacks which takes over the current role of shader_generate_main() in WineD3D. I am not quite convinced by this either. Attached are a few files for reference: shaderlib.gif: A diagram explaining the roles of the languages(No, it is not UML 2.0) uses.gif: Illustrating various uses of the shader library shader-lang: A very early pseudocode definition of the language The intermediate asm language follows the same principles as D3D bytecode. A shader contains any number of instructions, each instruction has one destination register and any number of source registers. The instructions have an opcode, writemask, modifiers. A register has a type, an index, information about relative addressing, source modifiers, and a swizzle. Appart of the instructions, the shader contains a header with informations about the shader. Declarations, input/output semantics, special registers used, etc. This replaces the shader_get_registers_used() pass in WineD3D. It is done by the shader library, and it also generates the declarations for 1.x pixel shaders. (We still have to find out which texture type to read from in wined3d). Thanks, Stefan

2 6

Firefox 3 beta 4 working, only a couple bugs...
by Dan Kegel 31 Mar '08

31 Mar '08

I tried Firefox 3 beta 4 just now, and there were a few bugs that stood out in the first few minutes: 12305 Firefox 3 beta 4 font problem: colon displayed as 0038 unicode glyph-missing glyph 12306 Firefox 3 beta shows one-pixel-high black line when rendering some images 12307 firefox 3 beta 4 crash on some web pages Youtube seemed slow and hangy on the first video I tried, http://www.youtube.com/watch?v=jwMj3PJDxuo although it was fine in native firefox at the same time; perhaps the Windows version of the flash plugin is less resistant to network errors -- or Wine doesn't support some network feature that only matters during bad internet weather. That same video was fine later, as was a different video http://www.youtube.com/watch?v=OGxdgNJ_lZM (both worth watching, btw). It also output quite a few messages like fixme:ntdll:NtLockFile I/O completion on lock not implemented yet fixme:font:ExtTextOutW flags ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY unimplemented Firefox 3 rc1 will be out in May, and release will be in early June, according to http://blog.wired.com/monkeybites/2008/03/mozilla-final-v.html Given that a lot of people have in the past used windows Firefox in wine to run native plugins, maybe we should get firefox 3 working well. Probably only five or six main issues. - Dan

1 0

Re: [1/2] WineD3D: Support clipplanes with GLSL shaders
by Alexandre Julliard 31 Mar '08

31 Mar '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From 1cb24469eb0f53f7e67dea2c7659ad070b86f21d Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 28 Mar 2008 16:11:06 +0100 > Subject: [PATCH] WineD3D: Support clipplanes with GLSL shaders > > This patch removes the shader clipplane disabling code from the > common/fixed function state table and enables GLSL shaders to write to > the clipcoord output attribute. The ARB specific clipplane disabling is > handled in the ARB shader backend. It doesn't work for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:4738: Test failed: vs_3_0 returned color 0x00110000, expected 0x00203366 visual.c:4743: Test failed: vs_1_1 returned color 0x00110000, expected 0x00808080 visual.c:4748: Test failed: vs_2_0 returned color 0x00110000, expected 0x00000000 visual.c:4929: Test failed: ps_3_0 returned color 0x00193300, expected 0x0080ffe5 make[2]: *** [visual.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

iPod sync news?
by Rainer M Krug 31 Mar '08

31 Mar '08

Hi are there any news on the iPod Touch sync front? Any patches available? Thanks Rainer

1 0

ws2_32 janitorial questions
by Andrew Talbot 31 Mar '08

31 Mar '08

Hi, ws2_32/async.c has the following global declarations: /* protoptypes of some functions in socket.c */ UINT16 wsaErrno(void); UINT16 wsaHerrno(int errnr); ws2_32/socket.c has the following global declarations: UINT wsaErrno(void); UINT wsaHerrno(int errnr); Where are these functions defined? And, assuming that the above are conflicting declarations, what type does each of these functions actually return? Thanks, -- Andy.

2 1

Re: setupapi: prevent page faults in SetupDiDeleteDeviceInterfaceRegKey
by Vitaliy Margolen 31 Mar '08

31 Mar '08

Christopher wrote: > Changelog: > Check that the handle and pointer passed to > SetupDiDeleteDeviceInterfaceRegKey are valid to read from. This patch > continues to address bug #12242 > > - if (!DeviceInterfaceData || > + if (!DeviceInterfaceData || IsBadReadPtr(DeviceInterfaceData, sizeof(SP_DEVICE_INTERFACE_DATA)) || Don't ever use IsBadReadPtr and IsBadWritePtr functions. They are bad and even MS stopped using them. You have to use TRY-EXCEPT block around an access to the memory. For example see implementation of lstrcpyA (kernel32/string.c: 359). > + ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, "Expected SetupDiDeleteDeviceInterfaceRegKey to return FALSE, got %s, \ > +with error code: 6, got %d\n", ret ? "TRUE" : "FALSE", GetLastError()); This is bad way to split strings in c. Do something like this: ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, "Expected SetupDiDeleteDeviceInterfaceRegKey to return FALSE, got %s, " "with error code: 6, got %d\n", ret ? "TRUE" : "FALSE", GetLastError()); Vitaliy.

1 0

Wine 1.0 status: T minus 68 days. 73 open bugs.
by Dan Kegel 30 Mar '08

30 Mar '08

40 days to code freeze. One bug fixed in last couple days: 9459 -unknown 8 FIFA 2007 crashes with the recent versions One bug added: 12246 -unknown 0 "make test" gives different results with and without warn+heap One bug deferred: 4971 -unknown 3 Corel Draw 12 demo install fails History: 3/22: 87 bugs, 76 days to go 3/23: 82 bugs, 75 days to go 3/24: 78 bugs, 74 days to go 3/26: 74 bugs, 72 days to go 3/30: 73 bugs, 69 days to go Here's the current list of open bugs: 5948 -unknown 1 Star Trek: Armada does not install 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 7477 -unknown 1 Uplink demo crashes 12097 -unknown 2 Wine 1.0 should not ship out-of-sync resource translations 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5844 -unknown 11 tray minimize 11281 -unknown 2 CJK input many issues 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 5402 -unknown 0 Trying to run PhotoStitch 3.1 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 9916 -unknown 6 "make test" usually fails 9178 -unknown 7 "hello world" dos program hangs 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 12246 -unknown 0 "make test" gives different results with and without warn+heap 8125 -unknown 0 Marratech 6.1 crashes on start 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 11681 directx- 14 Add support for video overlay 5955 directx- 8 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 82 document 2 Stabilize Winelib User Guide Table of Contents 638 document 9 Document Wine debugging channels 9771 gdi32 38 Steam Friends doesn't work (fails to render correctly or refresh) 9926 gdi32 5 gdi32.dll should not have exported function pointers 3270 gdi32 15 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 5351 kernel32 9 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 4733 kernel32 5 Get optimized/compressed/packed executables (non-upx) working 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 12 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 6607 ole 9 Drag and Drop not working 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 8095 ole 0 PQ Teaching toy crashes 4770 ole 3 BlackBerry Device Manager fails to install under wine 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 12 MOTD in counter-strike 1.6 and counter-strike source does not render 8439 shell32 8 Visual Studio .NET (7) install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine 664 user32 6 The help menu functionality inside programs is broken (messaging problem) 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 3023 user32 5 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 11019 winex11. 3 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 1990 winex11. 1 modifier keys not released when switching desktop 10984 winex11. 5 sun jre 5 update 10 installer hangs in 0.9.52 5623 winex11. 3 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 5625 wininet 3 Wine does not handle internet proxy settings conveniently 9787 winsock 47 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

4 4

Re: bugfix #12296
by Stefan Dösinger 30 Mar '08

30 Mar '08

Am Sonntag, 30. März 2008 20:33:22 schrieb Gregor Münch: > As discussed with stefand on irc: > | feel free to send a patch adding that, it is needed > - * Copyright 2006-2007 Stefan Dösinger for CodeWeavers > + * Copyright 2006-2007 Stefan Dï¿½singer for CodeWeavers Watch out with the encoding... I think the general consent is to leave that character as it is until we have decided on a preferred Wine source file encoding. The background story is that we throw away the sysmem copy of the surface, so we have to remove SFLAG_INSYSMEM. This might drop the last remaining location. Since we do not backup any contents of primaries and depth stencil, we can label the DRAWABLE as most up to date, this prevents needless loading attempts on the next draw. So the patch is correct and should be applied, appart of the change to my name...

1 0

find_dll_file ignoring WINEDLLPATH?
by Erik de Castro Lopo 30 Mar '08

30 Mar '08

Hi all, I have a windows executable named floating_point_test.exe which requires a windows DLL that is in another directory. I'm trying to run the exe from the current dir using: WINEDLLPATH="/path/to/dll:$WINEDLLPATH" wine floating_point_test.exe but wine is not able to find the DLL. I've traced through the code and ended up in the file dlls/ntdll/loader.c and the function find_dll_file (). I've added a few printfs and found that when looking for my DLL, the code ends up in a section with the following comment: /* if libname doesn't contain a path at all, we simply return the name as is, * to be loaded as builtin */ It seems that this function makes no use of WINEDLLPATH. Shouldn't this function also search along the paths specified by the environment variable? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "I could never learn to use C++, because of the completely overwhelming desire to redesign the language every time I tried to use it, but this is the normal, healthy reaction to C++." -- Erik Naggum

4 7

Re: Don't bother...
by Hin-Tak Leung 30 Mar '08

30 Mar '08

--- On Sat, 29/3/08, pure_evil(a)mail.bg <pure_evil(a)mail.bg> wrote: > From: pure_evil(a)mail.bg <pure_evil(a)mail.bg> > Subject: Don't bother... > To: "Hin-Tak Leung" <hintak_leung(a)yahoo.co.uk> > Date: Saturday, 29 March, 2008, 5:51 PM > I tried compiling it against wine's source tree, it spat > out a bunch of > warnings. When I wrote to him, that's what he replied: > > >guess what, that's a different compiler. > 'winegcc' != 'mingw32'. Did I say > something about crosscompiling? AFAIK you dont (cant?) use > stuff compiled > with winegcc on windows because it depends on wine. > > >I just thought you might want to look at a sample that > builds and lives > outside so you could test you code on win too. > > So, it's not what you think it is :( It's not > usable as wine driver. I am a bit lost about your comments. I have both winegcc and mingw32. I am quite familar with the latter and new to the former. I am using the appropriate ones (mingw32 for the printproxy, and winegcc for ddiwrapper). The printerproxy needs cross-compiling (and it works alright against current wine), ddiwrapper needs to be built with winegcc (and does not build against current wine). __________________________________________________________ Sent from Yahoo! Mail. A Smarter Inbox http://uk.docs.yahoo.com/nowyoucan.html

1 0

re: Two more janitorial tasks
by Dan Kegel 30 Mar '08

30 Mar '08

> Use WriteConsoleW to output text to the console instead printf & co. Unless output is redirected to a file, in which case you have to jump through a couple hoops. See WCMD_output_asis_len(). If anybody breaks commandline usage again, I'm gonna myrtlize 'em :-) - Dan

1 0

strange menu behaviour
by Marcus Meissner 30 Mar '08

30 Mar '08

Hi, I am observing a strange menu behaviour. How to reproduce: - start notepad - move the mouse over "Search", do not click - press alt-f to get the file menu => the file menu flickers open, but suddenly switches to the search menu. It seems the menu code checks the mouse pointer even though it is not used for the menu activation. http://bugs.winehq.org/show_bug.cgi?id=12289 Ciao, Marcus

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel