- wine-devel - winehq.org

Two more janitorial tasks
by Vitaliy Margolen 30 Mar '08

30 Mar '08

This is a bit more involved then regular janitorial task, but pretty small never the less. It is for some one who wants to get their feet wet in Wine. Convert all console applications (net, regsvr32, eject, msiexec, etc) to unicode (see cmd for example). This is to better support international translations. Use WriteConsoleW to output text to the console instead printf & co. Again for better support of the international translations and to avoid bugs in Wine's msvcrt which prints to the wrong terminal. Vitaliy.

2 1

SoC idea: enhance the Program Manager, winefile and friends
by Steven Edwards 30 Mar '08

30 Mar '08

Hi All, >From time to time the discussion comes up about having some sort of Window manager or explorer replacement for when running in Desktop mode. I don't know if a Win9x style desktop is really what we need for running in Desktop mode and after giving it a bit of thought, perhaps enhancing the program manager would be a better fit for us. Like perhaps if you start in Desktop mode then explorer would auto-magically start the program manager for you. I was also thinking that rather than using Windows 3.1 style group menus, we teach Program manager how to read shortcuts and directories in the start menu to use those as programs and program groups. Winefile could also use some loving as well and maybe we could come up with a better way to tie it in to the Program Manager. It seems to me that enhancing both of these programs should take a few months or work and fill out a SoC project nicely. Thoughts? -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

5 8

Sims: Pet Stories Bug?
by Warren Dumortier 29 Mar '08

29 Mar '08

Hello everybody! I send this mail because I made a bug report some time ago and nobody is looking to help... Here's the bug: http://bugs.winehq.org/show_bug.cgi?id=11946, is there any person who could make this game work? Thanks

4 3

gdi32-related commit between 0.9.57<->0.9.58 broken .NET2/Systems.Windows.Forms
by Hin-Tak Leung 29 Mar '08

29 Mar '08

I found a .NET2/System.Windows.Forms application which was running alright in 0.9.56/0.9.57 with the appdb adaptations broke in 0.9.58. So I did a git bisect and found that it is a commit to gdi32/freetype.c from Huw Davies which broke it. It is known that .NET does some strange things with fonts and font-related part of the registry (See http://bugs.winehq.org/show_bug.cgi?id=10467#c2 for discussion) and the commit apparently breaks that... I believe I see what that specific commit does and how it breaks .NET2, but I am not sure I understand *why* the commit was accepted in the first place and what was its purpose... Can somebody explain, and possibly either back-out the commit or at least modify it to make it not break stuff? commit 0436a5d14abf22af6ec10640496f9e0298a65f69 Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Mar 10 12:31:43 2008 +0000 gdi32: Store the Windows path (if it's available) in the font registry entries. The error message I got was 'attempt to read or write protected memory. This is often an indication that other memory is corrupt'. __________________________________________________________ Sent from Yahoo! Mail. More Ways to Keep in Touch. http://uk.docs.yahoo.com/nowyoucan.html

5 13

Re: winex11.drv: Connect to XIM server dynamically.
by Alexandre Julliard 29 Mar '08

29 Mar '08

Kusanagi Kouichi <slash(a)ma.neweb.ne.jp> writes: > If I want to use XIM, I must start XIM server before wine. > Furthermore, if XIM server stops, wine can't use XIM again > even if XIM server restarts. You are changing too many things at once in your patches, including things that don't necessarily need to be changed. Please try to do your changes in smaller chunks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Implement VBScript for Google Summer of Code
by Jim Chen 29 Mar '08

29 Mar '08

Hi everyone, I have this idea of implementing vbscript.dll for Google SoC. Any comment would be appreciated before I start working on my proposal. The reason for implementing vbscript.dll is because right now there's nothing in the trunk about it. jscript.dll has a stub, but vbscript.dll doesn't, and it's an area that I think I can work on. VBScript is used by the Windows Installer, can be potentially be used for DirectMusic script (from http://wiki.winehq.org/DirectX-ToDo), and some applications use it. Just the core language/runtime (vbscript.dll) is implemented, no extra COM/OLE objects such as FSO (file system object), etc. (unless I have time). The language by itself is designed to be simple and easy, so an interpreter shouldn't be hard. I wrote a C-style script interpreter in Java this past year. For a few years I used to hack VB, and I know the language and VBScript is just a cousin of VB. The runtime library is not big, and writing it shouldn't take too much time either. I think the hardest part would be to implement the COM interfaces that deal with scripting. And that's the area I know least about. Thanks! Jim

4 5

[Fwd: gdi32: PlgBlt implementation (resend)]
by Nikolay Sivov 29 Mar '08

29 Mar '08

What about this patch? > Changelog (since first patch): > - HAVE_FLOAT_H used for #include > - all declarations moved to the beginning Index: dlls/gdi32/bitblt.c =================================================================== RCS file: /home/wine/wine/dlls/gdi32/bitblt.c,v retrieving revision 1.4 diff -u -r1.4 bitblt.c --- dlls/gdi32/bitblt.c 18 Sep 2007 10:32:56 -0000 1.4 +++ dlls/gdi32/bitblt.c 26 Mar 2008 22:48:50 -0000 @@ -20,6 +20,11 @@ #include <stdarg.h> +#include <math.h> +#if defined(HAVE_FLOAT_H) +#include <float.h> +#endif + #include "windef.h" #include "winbase.h" #include "wingdi.h" @@ -522,9 +527,75 @@ * */ BOOL WINAPI PlgBlt( HDC hdcDest, const POINT *lpPoint, - HDC hdcSrc, INT nXDest, INT nYDest, INT nWidth, + HDC hdcSrc, INT nXSrc, INT nYSrc, INT nWidth, INT nHeight, HBITMAP hbmMask, INT xMask, INT yMask) { - FIXME("PlgBlt, stub\n"); - return 1; + int oldgMode; + /* parallelogram coords */ + POINT plg[3]; + /* rect coords */ + POINT rect[3]; + XFORM xf; + XFORM SrcXf; + XFORM oldDestXf; + FLOAT det; + + /* save actual mode, set GM_ADVANCED */ + oldgMode = SetGraphicsMode(hdcDest,GM_ADVANCED); + if (oldgMode == 0) + return FALSE; + + memcpy(plg,lpPoint,sizeof(POINT)*3); + rect[0].x = nXSrc; + rect[0].y = nYSrc; + rect[1].x = nXSrc + nWidth; + rect[1].y = nYSrc; + rect[2].x = nXSrc; + rect[2].y = nYSrc + nHeight; + /* calc XFORM matrix to transform hdcDest -> hdcSrc (parallelogram to rectangle) */ + /* determinant */ + det = (FLOAT)(rect[1].x*(rect[2].y - rect[0].y) - rect[2].x*(rect[1].y - rect[0].y) - rect[0].x*(rect[2].y - rect[1].y)); + + if (fabs(det) < FLT_EPSILON) + { + SetGraphicsMode(hdcDest,oldgMode); + return FALSE; + } + + TRACE("hdcSrc=%p %d,%d,%dx%d -> hdcDest=%p %d,%d,%d,%d,%d,%d\n", + hdcSrc, nXSrc, nYSrc, nWidth, nHeight, hdcDest, plg[0].x, plg[0].y, plg[1].x, plg[1].y, plg[2].x, plg[2].y); + + /* X components */ + xf.eM11 = (plg[1].x*(rect[2].y - rect[0].y) - plg[2].x*(rect[1].y - rect[0].y) - plg[0].x*(rect[2].y - rect[1].y)) / det; + xf.eM21 = (rect[1].x*(plg[2].x - plg[0].x) - rect[2].x*(plg[1].x - plg[0].x) - rect[0].x*(plg[2].x - plg[1].x)) / det; + xf.eDx = (rect[0].x*(rect[1].y*plg[2].x - rect[2].y*plg[1].x) - + rect[1].x*(rect[0].y*plg[2].x - rect[2].y*plg[0].x) + + rect[2].x*(rect[0].y*plg[1].x - rect[1].y*plg[0].x) + ) / det; + + /* Y components */ + xf.eM12 = (plg[1].y*(rect[2].y - rect[0].y) - plg[2].y*(rect[1].y - rect[0].y) - plg[0].y*(rect[2].y - rect[1].y)) / det; + xf.eM22 = (plg[1].x*(rect[2].y - rect[0].y) - plg[2].x*(rect[1].y - rect[0].y) - plg[0].x*(rect[2].y - rect[1].y)) / det; + xf.eDy = (rect[0].x*(rect[1].y*plg[2].y - rect[2].y*plg[1].y) - + rect[1].x*(rect[0].y*plg[2].y - rect[2].y*plg[0].y) + + rect[2].x*(rect[0].y*plg[1].y - rect[1].y*plg[0].y) + ) / det; + + GetWorldTransform(hdcSrc,&SrcXf); + CombineTransform(&xf,&xf,&SrcXf); + + /* save actual dest transform */ + GetWorldTransform(hdcDest,&oldDestXf); + + SetWorldTransform(hdcDest,&xf); + /* now destination and source DCs use same coords */ + MaskBlt(hdcDest,nXSrc,nYSrc,nWidth,nHeight, + hdcSrc, nXSrc,nYSrc, + hbmMask,xMask,yMask, + SRCCOPY); + /* restore dest DC */ + SetWorldTransform(hdcDest,&oldDestXf); + SetGraphicsMode(hdcDest,oldgMode); + + return TRUE; }

1 0

Re: wined3d: Improve detection of device palette change.
by Stefan Dösinger 28 Mar '08

28 Mar '08

Am Freitag, 28. März 2008 20:34:11 schrieb Alexander Dorofeyev: > ENTER_GL(); > + if (This->resource.format == WINED3DFMT_P8 || This->resource.format == > WINED3DFMT_A8P8) { > + for (i = 0; i < This->baseTexture.levels; i++) { > + if(palette9_changed((IWineD3DSurfaceImpl *)This->surfaces[i])){ Why are you doing this inside ENTER_GL? I think LoadLocation locks on its own.

2 2

Re: mscoree: Add missing interfaces
by Alistair Leslie-Hughes 28 Mar '08

28 Mar '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fsg1am$7ip$1@ger.gmane.org... > Hi, > > Changelog: > mscoree: Add missing interfaces > Anything wrong with this patch? Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 3/7] services: Start a local RPC server.
by Alexandre Julliard 28 Mar '08

28 Mar '08

Robert Shearman <rob(a)codeweavers.com> writes: > +handle_t __RPC_USER MACHINE_HANDLEW_bind(MACHINE_HANDLEW MachineName) > +{ > + WCHAR transport[] = SVCCTL_TRANSPORT; > + WCHAR endpoint[] = SVCCTL_ENDPOINT; > + LPWSTR server_copy = NULL; > + RPC_WSTR binding_str; > + RPC_STATUS status; > + handle_t rpc_handle; > + > + /* unlike Windows we start services.exe on demand. We start it always as > + * checking if this is our address can be tricky */ > + if (!check_services_exe()) > + return NULL; I think it would be OK to assume that services.exe is started by wineboot and is always running, since we'll have at least the mountmgr service running all the time. > +/* Not the Windows event name - if needed the true one can be found in Inside Windows */ > +cpp_quote("#define SVCCTL_STARTED_EVENT (const WCHAR[]){'_','_','w','i','n','e','_','S','v','c','c','t','l','S','t','a','r','t','e','d',0}") That's gcc-specific syntax, it would need some #ifdefs. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: amstream: IMediaStream::GetMultiMediaStream
by Robert Shearman 28 Mar '08

28 Mar '08

Nikolay Sivov wrote: > @@ -109,9 +109,14 @@ > { > IMediaStreamImpl *This = (IMediaStreamImpl *)iface; > > - FIXME("(%p/%p)->(%p) stub!\n", This, iface, ppMultiMediaStream); > + TRACE("(%p/%p)->(%p)\n", This, iface, ppMultiMediaStream); > > - return S_FALSE; > + if(!(*ppMultiMediaStream)) > + return E_POINTER; > + > + *ppMultiMediaStream = This->Parent; > + > + return S_OK; > } > Although I haven't looked at the context, you also likely need to add a reference to the returned COM object here. -- Rob Shearman

1 0

Re: [2/2] [try 2] Setupapi patch
by Juan Lang 28 Mar '08

28 Mar '08

Hi Alexander, > Changelog: > 1 - Creating device interface keys in registry as in Windows XP > 2 - Creating DeviceInstance value in registry > 3 - Creating SymbolicLink value in registry as in Windows XP > 4 - SETUPDI_AddDeviceToSet: changing pointers on SP_DEVINFO_DATA after > allocating new memory block for their array One fix per patch, please. --Juan

1 0

Re: [Tools 5/6] winetest: Add statistics for the number of unit tests with errors or todos.
by Paul Vriens 28 Mar '08

28 Mar '08

Francois Gouget wrote: > Also tweak the headers and footers a bit. > --- > > This gives us a better idea of how many unit tests are failing. > > winetest/gather | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 62 insertions(+), 5 deletions(-) > > diff --git a/winetest/gather b/winetest/gather Hi Francois, I think something is 'wrong' with the statistics for the Wine group: http://test.winehq.org/data/200803211000/#group_Wine They are the same for every box with respect to the "X + Y". The title (on mouse over) is correct though. -- Cheers, Paul.

2 2

GSOC proposal: DirectPlay4
by Matthew Canterbury 28 Mar '08

28 Mar '08

Hello everybody, I plan on applying for Google's Summer of Code to work on DirectPlay4 support in wine. (This was mentioned on the ideas page, http://wiki.winehq.org/SummerOfCode). I've looked at the code currently in wine, and it looks like there is some work done, but a number of the functions exported in the corresponding dlls are stubs or partial stubs. Alot of work needs to be done to dplay to make it more compliant (or at least more functional). This would allow several games that depend on DirectPlay to work without copying dll's from a windows partition. So I intend to makes sure the IDirectPlay4 COM interface is sufficiently implemented and that it meets the requirements set forth in in the DirectPlay4 specification. If time permits, I'd like to look into the Reliable Specification for DirectPlay4, but i think implementing just the core specification will keep me busy. I've never worked on an open source project before, but I have wanted to for quite some time. I'm looking forward to contributing to a project that I've used quite a bit in the past few years. ;) I thought I would introduce myself a bit here. I'm currently a computer engineering student at a University in the United States. I've been programming since I was about 13, and I've had all kinds of personal projects from a somewhat functional 3D game engines to a ray tracer. I was also chosen to participate on our school's team for the ACM programming competition. In short, I'm a programmer at heart. I'm putting the final touches on my application and would greatly appreciate any thoughts or comments before I submit it through Google. Thanks, Matthew Canterbury

2 1

Re: [3/5] WineD3D: Support clipplanes with GLSL shaders
by Stefan Dösinger 28 Mar '08

28 Mar '08

Am Freitag, 28. März 2008 02:57:46 schrieb Stefan Dösinger: Please do not apply this patch yet. We are not sure if we should write the Z corrected coord as clip coord or not

1 0

Re: 2/2 WineD3D: initial post pixelshader blending support
by Stefan Dösinger 28 Mar '08

28 Mar '08

Am Freitag, 28. März 2008 10:25:31 schrieb Roderick Colenbrander: > Hi, > > Store a flag whether a format supports blending in the formats table. This > patch uses the flag in the blending code and in a few other places to > verify if we should turn on blending for the given format. A next patch > will also us e this flag for a CheckPixelShaderBlendingCapability call for > CheckDeviceFormat. Later on I plan to move more of the Check*Capability > functions over to the table. Regarding the glDisable(GL_BLEND) in the CTXUSAGE_CLEAR setup: You have to mark the D3D state dirty in the context when doing that, otherwise blending might not be re-enabled properly on the next draw. I also think that disabling blending for clearing is orthogonal to the rest of the patch and should be done in a separate patch. > +#define WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING 1 Maybe use 0x1 instead of 1? That will make adding new flags beyond 8 clearer. Otherwise it looks good!

1 0

Re: amstream: IAMMultiMediaStream::EnumMediaStreams
by Robert Shearman 28 Mar '08

28 Mar '08

Nikolay Sivov wrote: > @@ -144,9 +144,18 @@ > { > IAMMultiMediaStreamImpl *This = (IAMMultiMediaStreamImpl *)iface; > > - FIXME("(%p/%p)->(%ld,%p) stub!\n", This, iface, Index, ppMediaStream); > + TRACE("(%p/%p)->(%d,%p)\n", This, iface, Index, ppMediaStream); > > - return E_NOTIMPL; > + /* check out of range */ > + if(Index < 0 || Index >= This->nbStreams) > + return S_FALSE; > + /* NULL pointer */ > + if(!(*ppMediaStream)) > + return E_POINTER; > + > + *ppMediaStream = This->pStreams[Index]; > + > + return S_OK; > } > You need to call IMediaStream_AddRef on the returned stream. -- Rob Shearman

1 0

Re: [1/2] Added a test: registering device interface and getting devicepath
by Dmitry Timoshkov 28 Mar '08

28 Mar '08

"Alexander Morozov" <amorozov(a)etersoft.ru> wrote: > Changelog: > Added a test for setupapi: registering device interface and getting device > path Please consistently print GetLastError() values as %u (not %08x or %d), otherwise the test looks good to me. -- Dmitry.

4 8

fuse-iso and remote named pipes for GSOC
by Cesar Izurieta 28 Mar '08

28 Mar '08

Besides the FUSE project for GSOC I see two items listed on the http://wiki.winehq.org/SummerOfCode page: # Better ISO FUSE file system integration # A FUSE wrapper for remote named pipes using libsmbclient Can anybody elaborate a little bit more on this?

3 3

Re: GSOC proposal - control panel
by pure_evil＠mail.bg 27 Mar '08

27 Mar '08

<off-topic>Sorry bout that, went a lil' /too/ paranoid. Thing is, I've spent so many days obsessing with the cpls, trying to get anything resembling a somewhat stable dev environment to produce anything resembling a *compilable* code, reverse-engineering Makefiles, and Makefile.ins, and defs and specs and C and gcc and ReactOS cpls and so forth /and being handed a code whose dev jumped on me for trying to cross-compile it, though that was what I asked for in the first place btw/ and when finally, SOMETHING compiled (a sample cpl included in Reactos 3.0. source code), I suddenly discovered that A.) They can't be done the normal way /e.g. compiled against wine's source-tree by winegcc/ B.) If they could, they would've been done long ago (Reactos has 'em; Someone would've ported them by now, if not do 'em from scratch) It was just too much for two weeks, sorry again. </off-topic> On-topic: CPls the normal way -> no-go. Binary CPls compiled on 'doze or with a 'doze compiler under wine -> yes. Sorry again.

2 1

Fw: Re: Google Summer of Code 2008 - joined openprinting+wine project?
by Hin-Tak Leung 27 Mar '08

27 Mar '08

Hi, anybody on wine-devel want to take this on and make this more concrete? --- On Wed, 26/3/08, Till Kamppeter <till.kamppeter(a)gmail.com> wrote: > From: Till Kamppeter <till.kamppeter(a)gmail.com> > Subject: Re: Google Summer of Code 2008 - Some general instructions for reviewing the student's applications > To: "Hin-Tak Leung" <hintak_leung(a)yahoo.co.uk> > Cc: "Casey Schaufler" <casey(a)schaufler-ca.com>, "'Glen Petrie'" <glen.petrie(a)eitc.epson.com>, "Rik van Riel" <riel(a)redhat.com>, "Jeff Licquia" <licquia(a)debian.org>, "Jon Masters" <jonmasters(a)gmail.com>, "Jonathan Riddell" <jriddell(a)ubuntu.com>, "Josef Spillner" <spillner(a)kde.org>, Matt_Domsch(a)dell.com, "Pekka Enberg" <penberg(a)cs.helsinki.fi> > Date: Wednesday, 26 March, 2008, 4:34 PM > Hin-Tak Leung wrote: > > Hi Till and the rest of the gang. > > > > Two people had got in touch with with about the > IJS+PDF workflow, and I replied. > > (sorry I don't check the "other" e-mail > often - I probably should set up re-direction). > > > > Great! > > > I thought I should also mentioned that it has just > came to my attention in some unrelated discussion on > wine-devel - been doing some non-printing wine-related > stuff lately - that there *was* a google summer of code > 2007 project for a > > wine-based native printer driver proxy - this is the > sort of thing I have had in mind > > for a while and I thought it would be interesting to > do but I don't have in-depth > > windows knowledge to make it happen, but the wine > people already did! > > http://google-summer-of-code-2007-wine.googlecode.com/ > > > > I just downloaded the gsoc 2007 printerproxy code. It > seems that it is just for use > > from within wine, but it just might be interesting to > make it more general - via opvp > > or IJS. We should follow up on this. > > If this project still requires coding, it is not too late > to add it as > project idea to the ideas pages of both the Linux > Foundation and WINE > (having it presented at two mentoring organizations raises > the chances > to find a student). > > Our ideas page is a Wiki and you can simply edit it: > > https://www.linux-foundation.org/en/Google_Summer_of_Code > > Till __________________________________________________________ Sent from Yahoo! Mail. More Ways to Keep in Touch. http://uk.docs.yahoo.com/nowyoucan.html

2 2

Re: comdlg32->printdlg: bug fixed
by Michael Stefaniuc 27 Mar '08

27 Mar '08

Vitaly Perov wrote: > Bug is the following: > When a application is responsible for printing multiple copies printer prints > X^2 copies (4 instead of 2, 9 instead of 3 ...) > It happen bacause application already prepared requested copies, and printer > driver prints copies ( number placed in dmCopies) of whole document. > > Changelog: > - When PD_USEDEVMODECOPIESANDCOLLATE flag is not set dmCopies must be 1. You didn't attached the diff but the whole file. bye michael

1 0

Re: prevents WM_DISPLAYCHANGE message being sent when a call to ChangeDisplaySettingsEx fails due to the requested change to the display not occurring.
by Reece Dunn 27 Mar '08

27 Mar '08

On 24/03/2008, chris morgan <cmorgan(a)mail.leather-wallet.co.uk> wrote: > test code run on windows nt4 sp6, messages checked using ms spk++: > > DEVMODE dev_mode; > memset(&dev_mode,0,sizeof(DEVMODE)); > dev_mode.dmSize = sizeof(DEVMODE); > > // Get the current display settings > if (!EnumDisplaySettings(NULL,ENUM_CURRENT_SETTINGS,&dev_mode)) > { > printf("Could not EnumDisplaySettings, giving up.\n"); > return 0; > } > > // Call ChangeDisplaySettings with the current settings, > // No WM_DISPLAYCHANGE message sent > ChangeDisplaySettings(&dev_mode, 0); > > // Change something (that works) > dev_mode.dmBitsPerPel = 32; > > // WM_DISPLAYCHANGE message sent > ChangeDisplaySettings(&dev_mode, 0); > > // Change something to an impossible value > dev_mode.dmBitsPerPel = 999; > > // No WM_DISPLAYCHANGE message sent > ChangeDisplaySettings(&dev_mode, 0); This should be incorporated into a conformance/regression test. That way, this bug will not reappear and can also be verified as the correct behaviour on different versions of Windows. > + if (width == screen_width && height == screen_height) > + { > + return; > + } w.r.t. the implementation: * ChangeDisplaySettings returns a long (http://msdn2.microsoft.com/en-us/library/ms533260(VS.85).aspx), so the correct value must be returned on error; * the fix does not match the test cases (screen size vs colour depth). In addition, your tests should: * check that changing the screen resolution causes a WM_DISPLAYCHANGE message to be sent; * if there are no other tests, ChangeDisplaySettings should be checked to see what happens with invalid arguments (for completeness); * the return value is not checked for expected values (see http://msdn2.microsoft.com/en-us/library/ms533260(VS.85).aspx); * GetLastError() is not checked to see what it is set to (see other tests for examples); * restore the display settings back to what they were before the tests. Thanks for improving Wine, - Reece

2 1

RE: GSOC proposal - control panel
by pure_evil＠mail.bg 27 Mar '08

27 Mar '08

No dice. CPls are DLLs that export a function - CPlApplet(). winegcc coughs on dllexport. - not implemented. I've been hacking at it for days on end now. Result: CPl can be compiled under windows and run under wine. CPls compiled with winegcc don't export that function => not treated as control panel applets. software to aid anyone: dllexp.exe. Download and run on any dll/cpl of windows, you get exports in it; run on wine dlls - nada. (hence, No Template in wine's source. Twain DLL exports some methods though.) MICROSOFT ISSUE: EASY TO DISTINGUISH BETWEEN WINE DLLS AND WINDOWS DLLS. If dllexp.exe can do it, so can they. Solution: M$ implements a code that *checks for a dll version* (based on what the DLL exports). Doesn't find export => coughs and dies with an "Incompatible DLL version". Happened before with OS2 / Windows. Maybe has happened now with all M$ that cough on wine. Not enough intimate knowledge => can a soft cough and die based on a call to a DLL export which isn't there, without being designed to do so?

4 4

GSOC proposal - control panel
by Owen Rudge 27 Mar '08

27 Mar '08

Hi everyone, I'm intending to apply for a Google Summer of Code placement working on the Wine control panel support. My main intention is to work on a proper Control Panel application for Wine that accepts standard .cpl files, and turn winecfg's configuration sections into appropriate control panels. (I notice that pure_evil @ mail.bg has been doing some work on this - if I were to get accepted to work on this, then I would like to continue his line of work, or assist him with it.) However, as I don't believe that project alone would necessarily take up an entire summer, my intention would also be to work on some new control panel applets for Wine. The examples given on the GSOC wiki pages (basic desktop/screen resizing, general network information, and font details) would be good applets for me to implement, but I would also be interested in working on some other applets, such as an Add/Remove Programs applet, or a Multimedia applet. Obviously, there wouldn't necessarily be time to implement all of these, so my intention would be to get the main control panel and basic Wine control panel applets from winecfg working well first, and then look at other applets that could be implemented. I've developed applications and, indeed, Control Panel applets for Windows for many years now (I started programming using the Windows API when I was 12!), so I feel confident that this is a task I would be able to handle. I believe that a good configuration interface for Wine that supports third-party control panels is something that would be very useful for end-users. If anyone has any comments or suggestions regarding my proposal, I'd very much appreciate any feedback. Regards, -- Owen Rudge http://www.owenrudge.net/

4 6

Re: setupapi: Implement pSetupGetField, with tests.
by Paul Vriens 27 Mar '08

27 Mar '08

Hi James, I'm looking into a crash of the setupapi/parser test on Vista. It crashes in this piece: 465 ret = HeapFree( GetProcessHeap(), 0, (LPVOID)field ); 466 ok( !ret, "Expected HeapFree to fail\n" ); 467 ok( GetLastError() == ERROR_INVALID_PARAMETER, 468 "Expected ERROR_INVALID_PARAMETER, got %u\n", GetLastError() ); when trying the second field. It's been added by a patch of yours: http://source.winehq.org/git/wine.git/?a=commit;h=7588b669d8331ff64fc3b75ce… What's the reason for checking the HeapFree here? Or what's the reason for doing it at all? -- Cheers, Paul.

3 3

Contributing
by Travis Athougies 27 Mar '08

27 Mar '08

Hi, I would like to help contribute to WINE because I use it so much yet I've never actually contributed to it. I was wondering if there are any simple bugs or other tasks that someone new to WINE development could undertake. Thanks. -- From: Travis Athougies 2 + 2 = 4

2 1

Re: [Tools 3/6] winetest: Fix merging of the individual test results into one group result, especially when they all report the dll is missing or that the test crashed, etc.
by Paul Vriens 27 Mar '08

27 Mar '08

Francois Gouget wrote: > Merge all the data for a given unit test to a single structure instead of scattering them into multiple hashtables. > The new result data structure makes it possible for the same code to work for both group and individual report results. > --- > > This fixes the many '.' found in the summary table. > > winetest/gather | 333 ++++++++++++++++++++++++++++++++++--------------------- > 1 files changed, 204 insertions(+), 129 deletions(-) > > diff --git a/winetest/gather b/winetest/gather > index d032e23..881134a 100755 > --- a/winetest/gather > +++ b/winetest/gather > @@ -37,32 +37,45 @@ $name0 =~ s+^.*/++; > my $summary_version=4; > > .... > > +sub min_to_max($) > +{ > + my ($minmax)=@_; > + return $minmax->[0] if ($minmax->[0] == $minmax->[1]); > + return "$minmax->[0] to $minmax->[1]"; > +} > + Don't we need quotes around "x to y"? Firebug complains about this. > + my $mm_count=min_to_max($result->{count}); > + my $mm_errors=min_to_max($result->{errors}); > + my $mm_todos=min_to_max($result->{todos}); > + my $mm_skips=min_to_max($result->{skips}); > + my $title="$mm_count tests, $mm_errors errors, $mm_todos todos, $mm_skips skips"; Or put the quotes here of course. The results of your latest patches can be seen at: http://test.winehq.org/data/200803191000/ -- Cheers, Paul.

2 1

Re: [2/2] Setupapi patch
by Dmitry Timoshkov 27 Mar '08

27 Mar '08

"Alexander Morozov" <amorozov(a)etersoft.ru> wrote: > + if (ReferenceString && lstrlenW(ReferenceString)) > { > /* space for a hash between string and reference string: */ > len += lstrlenW(ReferenceString) + 1; > @@ -258,10 +258,10 @@ static LPWSTR SETUPDI_CreateSymbolicLink > /* replace '\\' with '#' after the "\\\\?\\" beginning */ > for (ptr = strchrW(ret + 4, '\\'); ptr; ptr = strchrW(ptr + 1, '\\')) > *ptr = '#'; > - if (ReferenceString) > + if (ReferenceString && lstrlenW(ReferenceString)) Calling lstrlenW on ReferenceString is not needed, checking *ReferenceString is enough. -- Dmitry.

1 0

Re: widl: Use is_string_type for detecting strings in write_typeformatstring_var to make it consistent with write_remoting_arg.
by Alexandre Julliard 27 Mar '08

27 Mar '08

Robert Shearman <rob(a)codeweavers.com> writes: > Fix the is_string_type function used for detecting strings by only > examining aliases instead of both aliases and pointers. This is due to > the requirement that pointers to strings be handled as pointers and so > not detected as strings. This breaks qmgr: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../../.. -p qmgr_test.exe.so file.c && touch file.ok file.c:127: Test failed: Got incorrect remote name file.c:144: Test failed: Got incorrect local name make: *** [file.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] user32: add a DrawText test for bug 12226.
by Alexandre Julliard 27 Mar '08

27 Mar '08

"Lei Zhang" <thestig(a)google.com> writes: > +static void test_Bug12226(void) > +{ Please name functions according to what they do, not their bug number. The code must be understandable without having to look things up in bugzilla. In any case this should most likely go into the existing test_DrawTextCalcRect() function. > + height = DrawTextA(hdc, "", -1, &rect, > + DT_CALCRECT | DT_LEFT | DT_SINGLELINE); > + todo_wine ok(16 == height, "expected %d, got %d\n", 16, height); I don't think you can hardcode 16, that should depend on the font metrics. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] D3D8: Reject broken normal declaration types with fixed function
by Alexandre Julliard 27 Mar '08

27 Mar '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From d9182d3da1416e0bfa06b1fe879c4c74c66b0c3e Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Wed, 12 Mar 2008 01:06:38 +0100 > Subject: [PATCH] D3D8: Reject broken normal declaration types with fixed function This doesn't work for me: ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so visual.c && touch visual.ok visual.c:1184: Test failed: IDirect3DDevice8_CreateVertexShader returned with 0x8876086c make[2]: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine 1.0 status: T minus 72 days. 74 open bugs.
by Dan Kegel 27 Mar '08

27 Mar '08

44 days to code freeze. Four bugs fixed in the last two days: 9104 comdlg32 2 Pdf-xchange viewer crashes 10040 crypt32 2 Steam crashes during the startup 10111 comctl32 2 WINEDEBUG=warn+heap "make test" has heap error in comdlg32/tests/printdlg.c 11884 winex11. 1 Copy and paste garbage on end History: 3/22: 87 bugs, 76 days to go 3/23: 82 bugs, 75 days to go 3/24: 78 bugs, 74 days to go 3/26: 74 bugs, 72 days to go Here's a list of the currently open 1.0 bugs, sorted by component, with votes: 5948 -unknown 1 Star Trek: Armada does not install 4971 -unknown 3 Corel Draw 12 demo install fails 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 10 tray minimize 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 7477 -unknown 1 Uplink demo crashes 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 7 "hello world" dos program hangs 9459 -unknown 8 FIFA 2007 crashes with the recent versions 9916 -unknown 6 "make test" usually fails 9959 -unknown 8 Make wine updates work even if the registry changed 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 11281 -unknown 2 CJK input many issues 12097 -unknown 2 Wine 1.0 should not ship out-of-sync resource translations 556 build-en 2 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 5955 directx- 7 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 11681 directx- 14 Add support for video overlay 82 document 2 Stabilize Winelib User Guide Table of Contents 638 document 8 Document Wine debugging channels 12217 document 0 Documentation should be in XML and not SGML format 3270 gdi32 14 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 38 Steam Friends doesn't work (fails to render correctly or refresh) 9926 gdi32 5 gdi32.dll should not have exported function pointers 4733 kernel32 5 Get optimized/compressed/packed executables (non-upx) working 5351 kernel32 9 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 11 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 4770 ole 3 BlackBerry Device Manager fails to install under wine 6607 ole 8 Drag and Drop not working 8095 ole 0 PQ Teaching toy crashes 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 12 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 8439 shell32 7 Visual Studio .NET (7) install fails 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine 664 user32 6 The help menu functionality inside programs is broken (messaging problem) 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 2368 winex11. 6 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 5623 winex11. 3 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 10984 winex11. 4 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 2 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 5625 wininet 3 Wine does not handle internet proxy settings conveniently 9787 winsock 46 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

Re: [PATCH 1/2] user32: Properly translate keyboard left/right-shift, alt, ctrl keys hardware messages.
by Vitaliy Margolen 27 Mar '08

27 Mar '08

Vitaliy Margolen wrote: > --- > dlls/user32/message.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > > [PATCH 2/2] winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 5) Alexandre, what was wrong with these patches? I moved the remapping of messages as you suggested. Vitaliy.

1 0

[RFC] Improving the summary results on test.winehq.org
by Reece Dunn 26 Mar '08

26 Mar '08

Hi, Looking at the results from a test run (e.g. http://test.winehq.org/data/200803181000/), it would be nice to have: 1. A summary of a dlls overall results (i.e. the summation of all its unit test results), preferably before the individual tests, but could live with them at the bottom. 2. A summary of the entire test results (i.e. the summation of all unit test results for all dlls). This would be best at the top where it is easily visible. 3. Possibly display the number of tests run in a given pass (e.g. 0/12 or 1+3/27). This is to give an idea of how many tests have been run easily (especially for the dll and overall summaries). The idea is to get a quick idea of the health of the test results for each operating system and dll. - Reece

4 3

Tests marked as todo are not displayed on the web results.
by Reece Dunn 26 Mar '08

26 Mar '08

Hi, If you look at the output for a set of test results (e.g. http://test.winehq.org/data/200803181000/), it indicates whether particular tests need work on Wine. This is a great addition and works very well... however, if you navigate to the information about that test (e.g. http://test.winehq.org/data/200803181000/wine_xp_0.9.57-274-g5e463ac/gdiplu…), you don't see what tests are marked as todo. For example, using the above, it results in: gdiplus:graphicspath start dlls/gdiplus/tests/graphicspath.c 1.13 graphicspath: 198 tests executed (5 marked as todo, 0 failures), 0 skipped. gdiplus:graphicspath done (0) ...so does not tell me which of the 5 tests are todo and which are ok. I haven't checked to see if this is also an issue with the `make test` output. - Reece

2 1

Re: gdi32: PlgBlt implementation
by Michael Stefaniuc 26 Mar '08

26 Mar '08

Hello Nikolay, thanks for the patch. Nikolay Sivov wrote: > Changelog: > gdi32: initial implementation using coord transformation and MaskBlt > patch is made in Windows using TortoiseCVS functionality (all that > I can use at this moment, shouldn't be a problem I hope) No that's not a problem as long as you do the cvs diff from the top level wine directory. Please do not use C++ style comments but the traditional /* */. bye michael > > Index: bitblt.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi32/bitblt.c,v > retrieving revision 1.4 > diff -u -r1.4 bitblt.c > --- bitblt.c 18 Sep 2007 10:32:56 -0000 1.4 > +++ bitblt.c 26 Mar 2008 21:19:31 -0000 > @@ -26,6 +26,9 @@ > #include "gdi_private.h" > #include "wine/debug.h" > > +#include <math.h> > +#include <float.h> > + > WINE_DEFAULT_DEBUG_CHANNEL(bitblt); > > > @@ -522,9 +525,72 @@ > * > */ > BOOL WINAPI PlgBlt( HDC hdcDest, const POINT *lpPoint, > - HDC hdcSrc, INT nXDest, INT nYDest, INT nWidth, > + HDC hdcSrc, INT nXSrc, INT nYSrc, INT nWidth, > INT nHeight, HBITMAP hbmMask, INT xMask, INT yMask) > { > - FIXME("PlgBlt, stub\n"); > - return 1; > + //save actual mode, set GM_ADVANCED > + int oldgMode = SetGraphicsMode(hdcDest,GM_ADVANCED); > + if (oldgMode == 0) > + return FALSE; > + > + //parallelogram coords > + POINT plg[3]; > + memcpy(plg,lpPoint,sizeof(POINT)*3); > + //rect coords > + POINT rect[3]; > + rect[0].x = nXSrc; > + rect[0].y = nYSrc; > + rect[1].x = nXSrc + nWidth; > + rect[1].y = nYSrc; > + rect[2].x = nXSrc; > + rect[2].y = nYSrc + nHeight; > + //calc XFORM matrix to transform hdcDest -> hdcSrc (parallelogram > to rectangle) > + XFORM xf; > + //determinant > + FLOAT det = (FLOAT)(rect[1].x*(rect[2].y - rect[0].y) - > rect[2].x*(rect[1].y - rect[0].y) - rect[0].x*(rect[2].y - rect[1].y)); > + > + if (fabs(det) < FLT_EPSILON) > + { > + SetGraphicsMode(hdcDest,oldgMode); > + return FALSE; > + } > + > + TRACE("hdcSrc=%p %d,%d,%dx%d -> hdcDest=%p %d,%d,%d,%d,%d,%d\n", > + hdcSrc, nXSrc, nYSrc, nWidth, nHeight, hdcDest, plg[0].x, > plg[0].y, plg[1].x, plg[1].y, plg[2].x, plg[2].y); > + > + //X components > + xf.eM11 = (plg[1].x*(rect[2].y - rect[0].y) - plg[2].x*(rect[1].y - > rect[0].y) - plg[0].x*(rect[2].y - rect[1].y)) / det; > + xf.eM21 = (rect[1].x*(plg[2].x - plg[0].x) - rect[2].x*(plg[1].x - > plg[0].x) - rect[0].x*(plg[2].x - plg[1].x)) / det; > + xf.eDx = (rect[0].x*(rect[1].y*plg[2].x - rect[2].y*plg[1].x) - > + rect[1].x*(rect[0].y*plg[2].x - rect[2].y*plg[0].x) + > + rect[2].x*(rect[0].y*plg[1].x - rect[1].y*plg[0].x) > + ) / det; > + > + //Y components > + xf.eM12 = (plg[1].y*(rect[2].y - rect[0].y) - plg[2].y*(rect[1].y - > rect[0].y) - plg[0].y*(rect[2].y - rect[1].y)) / det; > + xf.eM22 = (plg[1].x*(rect[2].y - rect[0].y) - plg[2].x*(rect[1].y - > rect[0].y) - plg[0].x*(rect[2].y - rect[1].y)) / det; > + xf.eDy = (rect[0].x*(rect[1].y*plg[2].y - rect[2].y*plg[1].y) - > + rect[1].x*(rect[0].y*plg[2].y - rect[2].y*plg[0].y) + > + rect[2].x*(rect[0].y*plg[1].y - rect[1].y*plg[0].y) > + ) / det; > + > + XFORM SrcXf; > + GetWorldTransform(hdcSrc,&SrcXf); > + CombineTransform(&xf,&xf,&SrcXf); > + > + //save actual dest transform > + XFORM oldDestXf; > + GetWorldTransform(hdcDest,&oldDestXf); > + // > + SetWorldTransform(hdcDest,&xf); > + //now destination and source DCs use same coords > + MaskBlt(hdcDest,nXSrc,nYSrc,nWidth,nHeight, > + hdcSrc, nXSrc,nYSrc, > + hbmMask,xMask,yMask, > + SRCCOPY); > + //restore dest DC > + SetWorldTransform(hdcDest,&oldDestXf); > + SetGraphicsMode(hdcDest,oldgMode); > + > + return TRUE; > } > > >

2 1

dlls/user32/tests/cursoricon.c - test succeeded inside todo block
by Lei Zhang 26 Mar '08

26 Mar '08

Anyone else seeing this? ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so cursoricon.c && touch cursoricon.ok cursoricon.c:656: Test succeeded inside todo block: No hbmColor! make: *** [cursoricon.ok] Error 1

2 1

Trouble in compiling Wine 0.9.57 and 0.9.58 on Solaris 10 08/07
by Новиков Роман Константи нович 26 Mar '08

26 Mar '08

Hi guys! I've got some trouble with compiling Wine 0.9.57 & 0.9.58 on Solaris 10 08/07 After 40 minutes of the compilation the process halted with messages: wined3d_private.h: In function `float_32_to_16': wined3d_private.h:159: warning: implicit declaration of function `isinf' wined3d_main.c: At top level: wined3d_main.c:271: warning: visibility attribute not supported in this configuration; ignored (the last string repeated for many times) I suppose the situation is connected with Solaris 'isinf' but I am too far from programming under UNIX... My version of gcc is 3.4.3 (Solaris native): bash-3.00# gcc -v Reading specs from /usr/sfw/lib/gcc/i386-pc-solaris2.10/3.4.3/specs Configured with: /builds/sfw10-gate/usr/src/cmd/gcc/gcc-3.4.3/configure --prefix=/usr/sfw --with-as=/usr/sfw/bin/gas --with-gnu-as --with-ld=/usr/ccs/bin/ld --without-gnu-ld --enable-languages=c,c++ --enable-shared Thread model: posix gcc version 3.4.3 (csl-sol210-3_4-branch+sol_rpath) My configure string is: ./configure --enable-win64 --with-x --x-includes=/usr --x-libraries=/usr I built successfully Wine 0.9.56 and earlier.. What can I do with this? Thanks in advance. Rome

2 1

Can't determine disk space, install fails
by Pavel Troller 26 Mar '08

26 Mar '08

Hi! We have a long-persisting problem there. It persists for many wine versions and prevents some programs from installing. As an example, today my son complained about impossibility to install WoW. The installer was not able to determine the free space on the disk (there was a dash instead of a number in the box) and the Continue button was greyed out, so it was not possible to proceed. There are other cases, in which the installers say that there is not enough space on the disk and fail. Of course there is enough space, but the installer is not able to find it. Especially WoW has Gold rating and these problems are not mentioned, so I don't think that this is a common wine problem, thus I'm not going to open a bug for it. I'm begging for a hint instead, what to try to find the cause of the problem. Wine is always manually compiled and it runs on a "generic Linux system", not on any particular, publicly known distro. With regards, Pavel Troller

3 3

Re: [PATCH 1 of 2] explorer: add /startfile switch for starting files from file managers
by Alexandre Julliard 26 Mar '08

26 Mar '08

"Vincent Povirk" <madewokherd+d41d(a)gmail.com> writes: > My last attempt created a new winelib program; apparently this > functionality fits in explorer. start.exe is probably more appropriate. Either way you are trying to make it too smart; it should take a straight Unix path, and not try to guess anything. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [2/2] comctl32: tab.c The Item Interior should use HotTracking color not Hilight color (resend).
by Alexandre Julliard 26 Mar '08

26 Mar '08

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > @@ -1633,7 +1633,7 @@ TAB_DrawItemInterior(const TAB_INFO *inf > SetTextColor(hdc, (((lStyle & TCS_HOTTRACK) && (iItem == infoPtr->iHotTracked) > && !(lStyle & TCS_FLATBUTTONS)) > | (TAB_GetItem(infoPtr, iItem)->dwState & TCIS_HIGHLIGHTED)) ? > - comctl32_color.clrHighlight : comctl32_color.clrBtnText); > + comctl32_color.clrHotTrackingColor : comctl32_color.clrBtnText); Shouldn't you distinguish between TCS_HOTTRACK and TCIS_HIGHLIGHTED here? -- Alexandre Julliard julliard(a)winehq.org

2 1

Google Summer of Code - Case Insensitive Filenames
by Cesar Izurieta 26 Mar '08

26 Mar '08

Hello everyone, I would like to participate in this year's google summer of code doing some work on case insensitive filenames ( http://wiki.winehq.org/CaseInsensitiveFilenames ) I have some experience working with FUSE ( see http://code.google.com/p/dejumble/ ). Is there any formal process I must go through to enter google summer of code for wine? Thanks. Cesar Izurieta

6 14

Re: kernel32: WideCharToMultiByte: return error on negative dest len (take 2)
by Alexandre Julliard 26 Mar '08

26 Mar '08

"Dan Kegel" <dank(a)kegel.com> writes: > While investigating a crash in gs-auftrag in bug 9039, noticed > WideCharToMultiByte wasn't quite conformant for negative destlen. > Fixed, with tests. Passes for me in Wine and Win XP. This would require reviewing all uses of WideCharToMultiByte in Wine, many places get this wrong. Unless you have an app that requires this fix I'd suggest to leave the test as todo_wine for now. -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: wininet: Implement chunked reads.
by Robert Shearman 26 Mar '08

26 Mar '08

Hans Leidekker wrote: > static DWORD HTTPREQ_ReadFile(WININETHANDLEHEADER *hdr, void *buffer, DWORD size, DWORD *read) > { > WININETHTTPREQW *req = (WININETHTTPREQW*)hdr; > + static WCHAR encoding[20]; > + DWORD buflen = sizeof(encoding); > + static const WCHAR szChunked[] = {'c','h','u','n','k','e','d',0}; > encoding shouldn't be static. -- Rob Shearman

1 0

Re: [1/2] reg: Implement basic 'reg add'. [try 2]
by Alexandre Julliard 26 Mar '08

26 Mar '08

"Andrew Riedi" <andrewriedi(a)gmail.com> writes: > +{ > + LPCTSTR lpSubKey; Please don't use TCHAR types. > + static const WCHAR hkcrW[] = {'h','k','c','r',0}; > + static const WCHAR hkcuW[] = {'h','k','c','u',0}; > + static const WCHAR hklmW[] = {'h','k','l','m',0}; > + static const WCHAR hkuW[] = {'h','k','u',0}; > + static const WCHAR hkpdW[] = {'h','k','p','d',0}; > + static const WCHAR hkccW[] = {'h','k','c','c',0}; > + static const WCHAR hkddW[] = {'h','k','d','d',0}; > + > + /* Determine key type. */ > + if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkcrW, 4) == CSTR_EQUAL) > + *hKey = HKEY_CLASSES_ROOT; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkcuW, 4) == CSTR_EQUAL) > + *hKey = HKEY_CURRENT_USER; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hklmW, 4) == CSTR_EQUAL) > + *hKey = HKEY_LOCAL_MACHINE; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 3, hkuW, 3) == CSTR_EQUAL) > + *hKey = HKEY_USERS; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkpdW, 4) == CSTR_EQUAL) > + *hKey = HKEY_PERFORMANCE_DATA; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkccW, 4) == CSTR_EQUAL) > + *hKey = HKEY_CURRENT_CONFIG; > + else if (CompareString(LOCALE_NEUTRAL, NORM_IGNORECASE, key_name, 4, hkddW, 4) == CSTR_EQUAL) > + *hKey = HKEY_DYN_DATA; You should use some sort of array instead of duplicating all that code, and you need to check the next character of the string too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine 1.0 status: T minus 74 days. 78 open bugs.
by Dan Kegel 26 Mar '08

26 Mar '08

Today, three bugs were resolved: 4803 programs 5 Steam: not all lnk files are processed into linux shortcuts 10032 winsock 1 Wine must not use unix select() for networking where there might be high fd's 11431 user32 5 Adobe Photoshop CS2: z-overlay of image containers (although 10032's fix went too far, and one hunk is pending reversion). and one bug was deferred: 7915 -unknown 4 15 of the internal tests of wine fail on Mac OS X History: 3/22: 87 bugs, 76 days to go 3/23: 82 bugs, 75 days to go 3/24: 78 bugs, 74 days to go Excellent progress. Too bad past performance is no indication of future results :-) Here's a list of the currently open 1.0 bugs, sorted by component, with votes: 5948 -unknown 1 Star Trek: Armada does not install 11281 -unknown 2 CJK input many issues 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 8125 -unknown 0 Marratech 6.1 crashes on start 9916 -unknown 6 "make test" usually fails 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 9459 -unknown 8 FIFA 2007 crashes with the recent versions 12097 -unknown 2 Wine 1.0 should not ship out-of-sync resource translations 7477 -unknown 1 Uplink demo crashes 4971 -unknown 3 Corel Draw 12 demo install fails 9178 -unknown 7 "hello world" dos program hangs 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5844 -unknown 9 tray minimize 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 5402 -unknown 0 Trying to run PhotoStitch 3.1 10147 -unknown 0 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 2 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 1 Multi-select listview: Shift-arrow up only selects top two items 10111 comctl32 2 WINEDEBUG=warn+heap "make test" has heap error in comdlg32/tests/printdlg.c 9104 comdlg32 2 Pdf-xchange viewer crashes 10040 crypt32 2 Steam crashes during the startup 11681 directx- 13 Add support for video overlay 5955 directx- 6 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 82 document 1 Stabilize Winelib User Guide Table of Contents 638 document 7 Document Wine debugging channels 6519 gdi32 7 Wine blacks out rotated font bitmap 9771 gdi32 37 Steam Friends doesn't work (fails to render correctly or refresh) 3270 gdi32 13 Problem with minimized top-level windows 9926 gdi32 4 gdi32.dll should not have exported function pointers 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 5351 kernel32 8 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 4733 kernel32 4 Get optimized/compressed/packed executables (non-upx) working 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 11 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 6607 ole 8 Drag and Drop not working 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 8095 ole 0 PQ Teaching toy crashes 4770 ole 2 BlackBerry Device Manager fails to install under wine 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 11 MOTD in counter-strike 1.6 and counter-strike source does not render 8439 shell32 5 Visual Studio .NET (7) install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine 664 user32 5 The help menu functionality inside programs is broken (messaging problem) 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 5623 winex11. 2 GetAsyncKeyState wrong if querying process doesn't have focus 3297 winex11. 11 UpdateWindow() doesn't call XFlush() 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 2368 winex11. 5 Wine loses its X-Window when switching to another virt. desktop in Fvwm 11019 winex11. 1 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 11884 winex11. 1 Copy and paste garbage on end 1990 winex11. 1 modifier keys not released when switching desktop 10984 winex11. 2 sun jre 5 update 10 installer hangs in 0.9.52 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 5625 wininet 3 Wine does not handle internet proxy settings conveniently 9787 winsock 45 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

2 1

Re: [1/2] shlwapi: added tests for SHCreateStreamOnFile IStream_Read.
by Reece Dunn 26 Mar '08

26 Mar '08

On 25/03/2008, Reece Dunn <msclrhd(a)googlemail.com> wrote: > This patch adds some basic tests for the Read method of the various > SHCreateStreamOnFile APIs, while making it possible to add other > IStream method tests. > > At the moment, these tests are being skipped on Wine because it is not > returning a valid stream object in the tests. Alexandre: please ignore these patches for now. I am working on a more comprehensive series of tests for the various IStream methods. Thanks, - Reece

1 0

Scriptable configuration (reg.exe) proposals
by Maarten Lankhorst 26 Mar '08

26 Mar '08

Hello potential students, There have been at least 4 people interested in doing the reg.exe project for summer of code, but unfortunately this is not really a good project idea, becuse you can pretty much implement it all in a single day by just calling the right advapi calls. Making winecfg work from the command line is also not hard and you can't fill up 2 or 3 months with this. I'm sorry for not investigating reg.exe further. This should never have been on the ideas list to begin with, and I should be the one to be blamed for not spotting it earlier. I would strongly recommend adding a proposal for another project. It doesn't have to be one from the ideas list, on the contrary: The most succesful applications have been initiatives from people themselves. As long as you work, interact with the community and communicate with your mentor and share your code and ideas you will get paid. I hope that you will have luck in finding other proposals, and that you will be able to participate and complete gsoc succesfully. Regards, Maarten.

1 0

GSoc: Scriptable Configuration
by Matt Shanks 26 Mar '08

26 Mar '08

Hello all, Am quite keen to get involved with Wine for GSoC - specifically the project titled "Scriptable Configuration <http://wiki.winehq.org/SummerOfCode>" Having spoken briefly to Lei, he essentially said that the more features added to the reg.exe in Wine, the better. I looked up what the Windows version does, and it seems like a pretty solid list of features to aim for; - add Adds a new subkey or entry into the registry - delete Deletes a subkey or entries from the registry - query Displays the data in a subkey or a value - compare Compares specified registry subkeys or entries - copy Copy a subkey to another subkey - Save Saves a copy of specified subkeys, entries, and values of the registry in hive (binary) format-- could be changed to save as plaintext/flatfile format - Load Load a key values etc (Source <http://commandwindows.com/reg.htm>) An apparent missing feature seems to be editing an existing key value Also, for the command line tools for wine, beyond uninstallation and windows-version calls, (from Console Configuration<http://wiki.winehq.org/ConsoleConfiguration>) are there any other particularly desirable features? Any input/comments from anyone is much appreciated, Kind regards, Matt Shanks ('napi' on IRC)

2 1

qmgr test needs bits.lib to link using the MSVC headers
by Reece Dunn 26 Mar '08

26 Mar '08

Hi, I have been going through the tests to see if I can make them work using MSVC headers. When building the qmgr tests, I have found that you need to add bits.lib to LIBS (Linker/Input/Additional Dependencies). Doing this gets the test to link properly. Does anyone know how to add this to Wine? Adding EXTRALIBS=-lbits to Makefile.in does not work on Wine itself. Is this the right way to go? - Reece

2 1

Google SoC proposal
by Artur Szymiec 25 Mar '08

25 Mar '08

Greetings, I would like to participate in Wine SoC this year. I propose to implement WINED3DPMISCCAPS_TSSARGTEMP which is needed by some d3d games/apps using GL_ARB_fragment_program pixel shaders. Do you think it's a good proposal for SoC ? Best regards Artur Szymiec -- -------------------------------------------------------------------------- Registered User No 397465 Linux Debian 2.6.24.2 AMD Athlon(tm) 64 X2 Dual Core 5000+ Conquer your Desktop! http://www.kde.org/trykde/ Reclaim Your Inbox! http://www.mozilla.org/products/thunderbird/ --------------------------------------------------------------------------

2 1

Re: Alistair Leslie-Hughes : msxml3: Added support for SAXXMLReader.
by Michael Stefaniuc 25 Mar '08

25 Mar '08

Hello Alistair, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 264be58812fedf9a066bac521f9fff5821759890 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=264be58812fedf9a066bac521… > > Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Tue Mar 25 14:19:10 2008 +1100 > > msxml3: Added support for SAXXMLReader. Smatch is complaining about SAXXMLReader_create() loosing memory. HRESULT SAXXMLReader_create(IUnknown *pUnkOuter, LPVOID *ppObj) { saxreader *reader; TRACE("(%p,%p)\n", pUnkOuter, ppObj); reader = HeapAlloc( GetProcessHeap(), 0, sizeof (*reader) ); if( !reader ) return E_OUTOFMEMORY; reader->lpVtbl = &saxreader_vtbl; reader->ref = 1; TRACE("returning iface %p\n", *ppObj); return S_OK; } reader is a local variable with function scope. Stuff gets assigned to it but there is no usage of it nor is it "exported" aka made visible outside of the function. Is there something missing here? bye michael

3 2

Summer of Coders wanted!
by Maarten Lankhorst 25 Mar '08

25 Mar '08

Hi all, Since yesterday google is accepting applications for all participating projects. See http://code.google.com/soc for how to apply and read the faq linked there! The past few days a lot of good proposals were discussed, but you really need to submit them to the google web application officially to make them count. The deadline for this is 1 april 2008 00:00 UTC, but I would recommend submitting your application a few days before that to be sure. It optional, but recommended to slip a patch past Alexandre Julliard, he's Swiss so bribing with chocolate doesn't work! It doesn't have to be a big patch, just so that we know you can check out the wine git tree, and know how to get a patch in. Of course if you already did this once you don't have to do it again. A good guideline to what should be in an application is at http://www.perlfoundation.org/perl5/index.cgi?gsoc2008_proposal_template You don't have to follow this, but it's a good indication of what an application should contain. It's also a good idea to separate your goals into must-haves and nice-to-haves. The must haves you definitely want to do before the end of the summer, and the nice-to-haves are for the goals that you want to do, but you're not sure if you have all the time for them. Cheers, Maarten. PS: Mentors wanted, too! If you want to be a mentor, but have questions or doubts, contact me privately. To sign up as mentor: http://tinyurl.com/29awt6

1 0

Re: [PATCH 8/9] wined3d: remove ENTER_GL/LEAVE_GL in texture and cube texture PreLoad.
by Roderick Colenbrander 25 Mar '08

25 Mar '08

> > Not really needed for anything and can lead to ActivateContext being > called > while holding lock. > --- > dlls/wined3d/cubetexture.c | 2 -- > dlls/wined3d/texture.c | 3 +-- > 2 files changed, 1 insertions(+), 4 deletions(-) Sure this is a problem but there needs to be a place which calls ENTER_GL/LEAVE_GL. I believe LoadTexture and some of the other functions aren't handling that properly yet, so I wouldn't add this yet. It is very tricky. Roderick -- Psst! Geheimtipp: Online Games kostenlos spielen bei den GMX Free Games! http://games.entertainment.gmx.net/de/entertainment/games/free

2 1

Re: Implementing a new Direct3D function
by Jérôme Gardou 25 Mar '08

25 Mar '08

Le Sunday 09 March 2008 18:35:16 tony.wasserka(a)freenet.de, vous avez écrit : > D3DXGetImageInfoFromFile takes the D3DXIMAGE_INFO structure as parameter, > which has changed between d3dx8 an dd3dx9_36 though. > This means you can't forward the D3DXGetImageInfoFromFile calls from d3dx9 > to d3dx8, (even if it is done like that atm, you should fix that an you > patch) so you'll have to write two versions of each. > Our plan for implementing d3dx was to keep any d3dx code away from wined3d, > so you don't have to change anything about that. > So basically all you have to do is > (1) implement the d3dx8 version of each function > (2) add them to the d3dx8 specfile > (3) implement the d3dx9_36 version of each function > (3) correct the d3dx9_36 specfile (i.e. remove the forwarding to d3dx8) > > The d3dx9_24 to 35 dlls forward their calls to d3dx9_36, so they are okay, > too. > > > Tony > > > > > Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain > inkl. > http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i >ndex.html OK, then I'll do this that way. Also, d3dx9 provides support for multiple file format (PNG, TGA, BMP...). I assume I'll have to add those dependencies in the build process. ___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

4 3

New valgrind errors in GdiRealizationInfo?!
by Dan Kegel 25 Mar '08

25 Mar '08

http://kegel.com/wine/valgrind/logs-2008-03-24/vg-gdi32_font-diff.txt shows a number of new warnings, e.g. -fixme:font:GdiRealizationInfo (0x2e8, 0x7f22fc6c): stub! -font.c:1774: Tests skipped: skipping GdiRealizationInfo with truetype font ... + Use of uninitialised value of size 4 + at WineEngGetGlyphOutline (freetype.c:4152) + by GetGlyphOutlineW (font.c:2352) + by GetGlyphOutlineA (font.c:2330) + by enum_truetype_font_proc (font.c:1568) + by FONT_EnumInstance (font.c:589) + by WineEngEnumFonts (freetype.c:3762) + by FONT_EnumFontFamiliesEx (font.c:626) + by EnumFontFamiliesExA (font.c:664) + by func_font (font.c:1714) + by run_test (test.h:406) + by main (test.h:455)

1 0

Patch : fixme:msvcrt:MSVCRT__sopen : pmode 0x01a0 ignored
by Erik de Castro Lopo 25 Mar '08

25 Mar '08

Hi all, My interest in Wine is mainly because it allows me run the test suite for my projects when I use the Linux -> windows MinGW compiler. Currently, the programs in my test suite spit out a lot of fixme warnings like: fixme:msvcrt:MSVCRT__sopen : pmode 0x01a0 ignored I've tracked this down in the code to the function in dlls/msvcrt/file.c. The patch below removes this fixme warning. I beleive that simply removing the warning is valid in this case because the variable being warned about, pmode, is not used after the warning. In fact, the only use of this variable is the FIXME or WARN messages. Cheers, Erik --- dlls/msvcrt/file.c~ 2008-03-25 23:42:47.000000000 +1100 +++ dlls/msvcrt/file.c 2008-03-25 23:44:14.000000000 +1100 @@ -1442,11 +1442,6 @@ pmode = va_arg(ap, int); va_end(ap); - if(pmode & ~(MSVCRT__S_IREAD | MSVCRT__S_IWRITE)) - FIXME(": pmode 0x%04x ignored\n", pmode); - else - WARN(": pmode 0x%04x ignored\n", pmode); - if (oflags & MSVCRT__O_EXCL) creation = CREATE_NEW; else if (oflags & MSVCRT__O_TRUNC) -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- Only people who suck have a problem with elitism.

2 1

Re: Create stub dosx.exe
by Alexandre Julliard 25 Mar '08

25 Mar '08

Justin Chevrier <jchevrier(a)nexicom.net> writes: > Changelog: > > Create stub dosx.exe Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: Create stub dosx.exe
by Dmitry Timoshkov 25 Mar '08

25 Mar '08

"Justin Chevrier" <jchevrier(a)nexicom.net> wrote: > +#define WIN32_LEAN_AND_MEAN > + > +#include <windows.h> What's the reason to include anything in an empty stub? > +int main(int argc, char *argv[]) > +{ > + return 0; > +} -- Dmitry.

2 1

Re: (resend)imm: implement ImmGetIMEFileNameW and ImmGetIMEFileNameA correct registry lookups
by Alexandre Julliard 25 Mar '08

25 Mar '08

Aric Stewart <aric(a)codeweavers.com> writes: > + if (rc > 0) > + { > + if (uBufLen && lpszFileName) > + rc = WideCharToMultiByte(CP_ACP, 0, bufW, uBufLen, lpszFileName, > + uBufLen, NULL, NULL); > + else /* get the length */ > + rc = WideCharToMultiByte(CP_ACP, 0, bufW, wBufLen, NULL, 0, NULL, > + NULL); The source length should be -1, you don't want to convert the whole buffer. > + static CHAR KeyboardKey[] = "System\\CurrentControlSet\\Control\\Keyboard Layouts"; > + static WCHAR szImeFileW[] = {'I','m','e',' ','F','i','l','e',0}; > + > + HKEY keyboardKey; > + DWORD length; > + DWORD rc; > + CHAR regKey[sizeof(KeyboardKey) + 11]; > + > + wsprintfA( regKey, "%s\\%08x", KeyboardKey, (unsigned)hKL ); > + rc = RegOpenKeyA( HKEY_LOCAL_MACHINE, regKey, &keyboardKey); This should use Unicode like the rest of the function. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WineD3D: Always report D16 (fixes bug 12130) [attempt 2]
by Stefan Dösinger 25 Mar '08

25 Mar '08

> > 3dmark2000 broke recently because we aren't offering D16 anymore if a > > card doesn't expose it using GLX. On a Geforce 8800 it isn't offered by > > GLX (because the hardware is 24bit) but D3D9 on Windows offers it, so > > offer it too. Second D3D <= 7 requires it too as at that time there was > > no 24bit z-buffer. The bug in 3Dmark2000 is a bug in ddraw, we do not report 24/32 bit formats in a way the game likes. I have a patch for that deep down in my sending queue that fixes the depth and stencil masks. This patch is still perfectly valid, just pointing out that in case of 3DMark2k it fixes the wrong bug. Other older apps are likely do demand D16, just 3Dmark2000 doesn't.

1 0

Re: [PATCH 7/9] wined3d: Make device palettes dynamically allocated.
by Alexandre Julliard 25 Mar '08

25 Mar '08

Alexander Dorofeyev <alexd4(a)inbox.lv> writes: > + if (PaletteNumber >= This->NumberOfPalettes) { > + NewSize = This->NumberOfPalettes; > + do { > + NewSize *= 2; > + } while(PaletteNumber >= NewSize); > + palettes = HeapReAlloc(GetProcessHeap(), 0, This->palettes, sizeof(PALETTEENTRY[256]) * NewSize); You should be using an array of pointers, not a single array for all palettes, so that you don't need to move around the whole data on each realloc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 9/9] d3d9/tests: Fix precision problems in shademode_test.
by Stefan Dösinger 25 Mar '08

25 Mar '08

Am Dienstag, 25. März 2008 01:04:10 schrieb Alexander Dorofeyev: > --- > dlls/d3d9/tests/visual.c | 26 +++++++++++++++++++++----- > 1 files changed, 21 insertions(+), 5 deletions(-) The drawback of this is that if a driver behaves differently in D3DSHADEMODE_PHONG this will slip through as imprecision most likely. That is something we have to live with I am afraid

1 0

[Repost] wineasio source now on SourceForge
by Peter L Jones 24 Mar '08

24 Mar '08

Hi all, wineasio, the ASIO to JACK driver for WINE, has been under some development over recent months by various interested parties. Co-ordination has been on a best endeavours basis but really needed something more organised. The project really needed a proper home, too. So I've gathered the various threads of source and committed them into a SourceForge SVN project. Robert Reif's wineasio-0.0.x and the JackLab work on wineasio-0.x have their own branches. The current work on wineasio-0.7.x forms the SVN trunk. wineasio-0.7.x releases (i.e. 0, 1, 2 and 3) are tagged. HEAD currently has two changes pending release (a fix for Nuendo and a possible fix for some xruns being experienced by a 64studio user). wineasio developers and packagers are encouraged to consider using the SourceForge facilities - let me know if you want to be added as a committer and please use the trackers for bugs, feature request, etc. Right now, feedback would be appreciated on the current code in HEAD and around the xrun issued mentioned, more details here: http://forum.jacklab.net/viewtopic.php?f=2&t=726 I spent oh... seconds... considering a name for the SourceForge project. Fortunately "wineasio" was available. You can find the project on the end of this url: http://sf.net/projects/wineasio wineasio would not exist without Robert Reif. Ralf Beck undertook much work for JackLab. William Steidtmann and Nedko Arnaudov had provided bug fixes. I provided the config file handling and tried to combine Ralf and Robert's work (thus kicking off 0.7.x). Many thanks, -- Peter

1 0

bugzilla patches
by Lei Zhang 24 Mar '08

24 Mar '08

Hi, Can someone take a look at my bugzilla patches from over a week ago? http://www.winehq.org/pipermail/wine-patches/2008-March/051551.html http://www.winehq.org/pipermail/wine-patches/2008-March/051552.html http://www.winehq.org/pipermail/wine-patches/2008-March/051553.html http://www.winehq.org/pipermail/wine-patches/2008-March/051768.html - Lei

2 1

Fwd: Questions regarding Summer of Code( and Dplay)
by Anurag Mishra 24 Mar '08

24 Mar '08

---------- Forwarded message ---------- From: Anurag Mishra <mishra.anurag07(a)gmail.com> Date: Tue, Mar 25, 2008 at 12:30 AM Subject: Re: Questions regarding Summer of Code( and Dplay) To: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Hi, I have already compiled git version and am learning the basics of using git now. Someone on irc suggested to first write test cases about the functions in wine(that may be missing) and crosscheck on windows. Right now, I am looking to start in that direction. Thanks, Anurag. On Thu, Mar 20, 2008 at 11:21 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Hello Anurag, > > 2008/3/19, Anurag Mishra <mishra.anurag07(a)gmail.com>: > > > > I am student at IIT Kanpur[1]. I have quite good knowledge about C > > and have been tracking development of Wine over a period of 6 months > > or so. I have good knowledge about C(and using it theoretically to > > implement stacks, efficient structures and so on). However, I have > > little real life experience about programming a project. I have little > > experience about Window's API. > > I was looking to participate in Wine development this summer. On SoC > > page, the idea of Dplay was bought up. I am interested in trying hands > > on that. Can anyone suggest what would be a good starting point? > > There are only a few important things to directplay as far as I know. > The first one is find a game that runs in wine and uses it, and works > reasonably well single player but not at all multiplayer or online > because of the missing things (fixmes on dplay in console). After you > played the game a little bit, think of a plan on how you want to > tackle this problem. > > Have you managed to compile a git version of wine yet? > > Cheers, > Maarten. >

1 0

Re: winex11.drv: Don't add owned windows to the taskbar
by Alexandre Julliard 24 Mar '08

24 Mar '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > this patch fixes the bug 12160. According to my tests explorer in XP > doesn't add owned windows to the taskbar. Do we really want to remove them from the pager too? -- Alexandre Julliard julliard(a)winehq.org

1 0

Appdb request: allow browsing for downloadable platinum apps
by Dan Kegel 24 Mar '08

24 Mar '08

The appdb has a "browse by rating" and a "browse downloadable" option, but there's no way to combine them. Can we add a 'downloadable' checkbox in the 'browse by rating' page, maybe?

3 2

Re: [Bug 9484] Program refuses to run because of ProtectCD/ ProtectDISC copy-protection
by James Hawkins 24 Mar '08

24 Mar '08

On 3/24/08, wine-bugs(a)winehq.org <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=9484 > > > --- Comment #9 from Austin English <austinenglish(a)gmail.com> 2008-03-24 12:43:54 --- > Can anyone test this in wine 0.9.58? Some other copy protections are working > better, and if this isn't working yet, we might want to delay it to wine 1.2... > What's the point of having a blocker list if we keep deferring those bugs? Granted not every bug in the list deserves a spot, but we need to knuckle down and get these bugs fixed. When we get closer to the release date, we can get a better idea of which bugs are not feasible to fix before the release. Until that point, this bug list needs to receive top priority. -- James Hawkins

2 2

Re: Download.template: Update PC-BSD download link and icon [Resend]
by James Hawkins 24 Mar '08

24 Mar '08

On 3/24/08, Austin English <austinenglish(a)gmail.com> wrote: > Not sure why it wasn't applied the first time. Didn't receive any > comments on it. Anywho, in case it was accidently sent to /dev/null, > here it is again. Fixes bug 12095. > http://bugs.winehq.org/show_bug.cgi?id=12095 > No patch attached. -- James Hawkins

1 0

wineasio: source now hosted on SourceForge
by Peter L Jones 24 Mar '08

24 Mar '08

I thought I'd post here to let interested parties know that the various strands of source for wineasio have been brought together in a single SourceForge project. After a great deal of thought, the project name "wineasio" was chosen by unanimous vote (okay, so only I got a say...). Robert Reif and the early JackLab code branches are both preserved with change history. The trunk is wineasio-0.7.x, which is under "active" development. Bug reports, feature requests, offers of help and code via the SF project trackers, please. Let me know your SF.net ID if you want to commit to the project (and show some code...). Thanks, -- Peter http://www.sourceforge.net/projects/wineasio

1 0

Re: kernel32: WideCharToMultiByte: return error on negative dest len
by Alexandre Julliard 24 Mar '08

24 Mar '08

"Dan Kegel" <dank(a)kegel.com> writes: > +static void test_negative_dest_length(void) > +{ > + int len; > + char buf[10]; > + > + /* Test return on negative dest length */ > + SetLastError( 0xdeadbeef ); > + memset(buf,'x',sizeof(buf)); > + len = WideCharToMultiByte(CP_ACP, 0, foobarW, -1, buf, -1, NULL, NULL); > + ok(len == 0 && GetLastError() == ERROR_INVALID_PARAMETER, > + "WideCharToMultiByte(destlen -1): len=%d error=%x\n", len, GetLastError()); If you want to determine the behavior for negative values you have to test more than just -1, it may well be special. -- Alexandre Julliard julliard(a)winehq.org

3 2

Confusing SOCKET and int in netapi32
by Juan Lang 24 Mar '08

24 Mar '08

Hi, commit 63504e9e80acb35666f8689526c67dd99c4fb3ba (janitorial: Use poll() instead of select().) appears to confuse the use of a SOCKET with an int: #include "winsock2.h" #include "windef.h" @@ -302,13 +311,12 @@ static UCHAR NetBTWaitForNameResponse(const NetBTAdapter *adapter, SOCKET fd, while (!found && ret == NRC_GOODRET && (now = GetTickCount()) < waitUntil) { DWORD msToWait = waitUntil - now; - struct fd_set fds; - struct timeval timeout = { msToWait / 1000, msToWait % 1000 }; + struct pollfd pfd; int r; - FD_ZERO(&fds); - FD_SET(fd, &fds); - r = select(fd + 1, &fds, NULL, NULL, &timeout); + pfd.fd = fd; + pfd.events = POLLIN; + r = poll(&pfd, 1, msToWait); I can't imagine how this could work. Notice that netapi32 is linked against ws2_32, includes winsock2.h, and that fd is a SOCKET. Could this part of the commit be reverted, please? --Juan

2 2

Re: [PATCH 01/45] [WinHelp]: now setting the text Window as a richedit one
by Alexandre Julliard 24 Mar '08

24 Mar '08

Eric Pouech <eric.pouech(a)orange.fr> writes: > - all popups are now of MainWindow kind (and embed a richedit control) > > A+ > --- > > programs/winhelp/string.c | 1 > programs/winhelp/winhelp.c | 932 ++------------------------------------------ > programs/winhelp/winhelp.h | 42 -- > 3 files changed, 40 insertions(+), 935 deletions(-) This seems to break the text window pretty badly, the window is now completely blank with just a blinking caret. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine 1.0 status: T minus 75 days. 82 open bugs.
by Dan Kegel 24 Mar '08

24 Mar '08

This weekend, two bugs were resolved: 5535 directx- 16 Planescape:Torment doesn't work 6526 kernel32 1 Typing Instructor for Kids 2 fails to install Four were deferred: 1347 directx- 20 Screen is wiped/blanked on usage of DirectDraw 3534 user32 14 Systray icons are not transparent... 6795 shdocvw 0 Skype 3.0.0.137 Beta dies trying to login in win98, winme mode 10708 user32 21 Wine lacks support for animated cursors And one more bug was nominated for 1.0.0 (!), 10040 crypt32 1 Steam crashes during the startup That takes us down from 87 bugs and 76 days to 82 bugs and 75 days. Here's a list of the currently open 1.0 bugs, sorted by component, with votes: 5948 -unknown 1 Star Trek: Armada does not install 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 8125 -unknown 0 Marratech 6.1 crashes on start 9916 -unknown 6 "make test" usually fails 5844 -unknown 8 tray minimize 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 9459 -unknown 8 FIFA 2007 crashes with the recent versions 5402 -unknown 0 Trying to run PhotoStitch 3.1 5024 -unknown 3 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 10815 -unknown 1 Cannot drag images into Adobe Photoshop 7 from the web / desktop 9178 -unknown 7 "hello world" dos program hangs 5061 -unknown 5 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 12097 -unknown 1 Wine 1.0 should not ship out-of-sync resource translations 11281 -unknown 2 CJK input many issues 7477 -unknown 1 Uplink demo crashes 4971 -unknown 3 Corel Draw 12 demo install fails 7915 -unknown 4 15 of the internal tests of wine fail on Mac OS X 10147 -unknown 0 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 2 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 10111 comctl32 2 WINEDEBUG=warn+heap "make test" has heap error in comdlg32/tests/printdlg.c 2493 comctl32 1 Multi-select listview: Shift-arrow up only selects top two items 9104 comdlg32 1 Pdf-xchange viewer crashes 10040 crypt32 1 Steam crashes during the startup 11681 directx- 11 Add support for video overlay 5955 directx- 6 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 82 document 1 Stabilize Winelib User Guide Table of Contents 638 document 7 Document Wine debugging channels 3270 gdi32 12 Problem with minimized top-level windows 9771 gdi32 37 Steam Friends doesn't work (fails to render correctly or refresh) 6519 gdi32 6 Wine blacks out rotated font bitmap 9926 gdi32 4 gdi32.dll should not have exported function pointers 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 5351 kernel32 8 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 4733 kernel32 4 Get optimized/compressed/packed executables (non-upx) working 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 11 USB serial ports do not work 9356 ntdll 5 Serial communication not working since wine-0.9.33 6607 ole 6 Drag and Drop not working 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 2539 ole 2 XDND (Drag and drop for X Windows) doesn't copy text 8095 ole 0 PQ Teaching toy crashes 4770 ole 2 BlackBerry Device Manager fails to install under wine 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 4803 programs 5 Steam: not all lnk files are processed into linux shortcuts 6254 richedit 3 Installer infinite loop from rich text error 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 6095 shdocvw 11 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 3546 shdocvw 2 CLSID_InternetShortcut not available... 10905 shell32 0 thinstall firefox demo requires native msvcrt 8439 shell32 4 Visual Studio .NET (7) install fails 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine 11431 user32 5 Adobe Photoshop CS2: z-overlay of image containers 664 user32 5 The help menu functionality inside programs is broken (messaging problem) 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 3023 user32 5 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 11884 winex11. 1 Copy and paste garbage on end 2368 winex11. 5 Wine loses its X-Window when switching to another virt. desktop in Fvwm 11019 winex11. 1 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5623 winex11. 2 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 23 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 1990 winex11. 1 modifier keys not released when switching desktop 10984 winex11. 2 sun jre 5 update 10 installer hangs in 0.9.52 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 3297 winex11. 9 UpdateWindow() doesn't call XFlush() 3711 winsock 0 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 10032 winsock 1 Wine must not use unix select() for networking where there might be high fd's 9787 winsock 44 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 5625 winsock 3 Wine does not handle internet proxy settings conveniently 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

2 1

Wine1.0 and LGPLv3?
by Ian Macfarlane 24 Mar '08

24 Mar '08

Just to resurrect this topic, as last time, of the responses to my email, two were positive (and the other just pointed out that I'd mistaken the Samba licensing for LGPL instead of GPL) but nothing else happened after that. Seeing as Wine is officially going to be having a 1.0 in the not too distant future, this would seem like the ideal time to introduce a license change ( e.g. Samba went to GPLv3 along with a version jump). I remember the WineConf 2007 presentation PDF from Alexandre mentioned it as a "post-1.0" possibility - it would seem to me that 1.0 would in fact be the ideal time to make such a change - being able to say "anything pre-1.0 is LGPLv2+ and anything 1.0+ is LGPLv3+" is quite nice and is easy to understand. LGPLv3 has a lot of benefits over the previous version (see my previous email below), some of which are particularly pertinent given Microsoft's attitude towards it (e.g. in the Novell agreement that led to a third draft of the GPL, Wine would seem to be excluded from the patent protection agreement - see http://tinyurl.com/25at6e). It would be great to have a decision made on this - personally, I can't see any reason why LGPLv3 would be detrimental to WINE (for example, I can't see any reason CodeWeavers would dislike any of the new provisions, which mostly target troll companies), and numerous reasons why it would be a good thing. Ian Macfarlane ps: Here's the email I sent about this some time back, but with the bits about Samba and Solaris snipped out: On 7/13/07, Ian Macfarlane <ian(a)ianmacfarlane.com> wrote: > > I've been meaning to ask about this since (L)GPL3 was released. > > The version 3 of the (L)GPL license has numerous benefits: > > - It's much more legally sound in the rest of the world (IMO one of > the most important factors about the new license) - numerous reasons > for this e.g. referencing WIPO rather than US laws. > > - It has an explicit patent agreement (really an extension of the > above - (L)GPLv2 has an implicit patent agreement, but this is only > valid in the US) - this means that people who contribute to and/or > distribute WINE cannot sue WINE (or WINE users) for patent > infringement. > > - It is compatible with the Apache 2.0 license, meaning that there is > an even bigger pool of source code to draw from. > > - It helps ensure that companies cannot prevent people from modifying > the source code by providing them explicit legal rights to change the > code in these circumstances, and requiring information to allow users > to change it. > > - For LGPL only, It makes 100% sure that GPL+linking exception and > LGPL can be combined legally in all jurisdictions by merging them > (which is essentially the only real difference, barring slightly > different wording in the v2.1 of LGPL vs v2. of GPL) > > - It prevents patent agreements where only some people are protected. > > - It provides a mechanism for first-time accidental violations to be > 'cured' more easily > > - ... and lots of other minor changes to improve the validity of the > legal status of the license. <snip> So as you can see, (L)GPL version 3 has a lot of benefits. It also has > broad support (excluding Linus of course, who I must point out objects > only to a single clause in the license that can be resolved by adding > an extra permission, as GPLv3 permits), including strong corporate > backing (e.g. IBM, Red Hat, MySQL, Sun, even Novell). As one of the > projects that Microsoft would most like to destroy, the added > protections in this updated version of the license would seem even > more valuable. > > Kind regards, > > > Ian Macfarlane > > > ps: As a last note to Damjan - all GPL versions have been considered > both radical and political when they were released. In retrospect, the > protections that they provided have been considered invaluable. >

4 4

d3d9_36: partially implement D3DXCreateTextureFromFile
by tony.wasserka＠freenet.de 24 Mar '08

24 Mar '08

> Hello > > 1) use 4 spaces instead of tab in > > d3dx9_36_main.c > font.c > - math.c > + math.c > + texture.c > > > 2) D3DXCreateTextureFromFileW(ptr wstr ptr) should be forwarded to its d3dx8 counterpart and you implement it in d3dx8 dll > > > David No, tabs are okay in Makefile.in (every dll is using tabs there). Also, the first parameter of D3DXCreateTextureFromFile is an LPDIRECT3DDEVICE8 in d3dx8 and an LPDIRECT3DDEVICE9 in d3dx9, i.e. this call can't be forwarded. However, you should probably call D3DXCreateTextureFromFileEx here to prevent duplicated code. If you're going to implement that function, too, you may need to stub D3DXFilterTexture (just from looking at the parameter list of the extended function, not sure if you REALLY need to do so). Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

Regression introduced with one old Dösinger's commit
by Milan Kostić 24 Mar '08

24 Mar '08

http://source.winehq.org/git/wine.git?a=commit;h=fe0f0eb48a12e29af6a9e7407d… OK this is that commit with problem, but don't know what is corect solution... i just remove it back and all my problems with water flowing ine games is gone:). Problem is with changes just in utils.c file and that is not working properly with Mesa drivers that i use (i don't know for other drivers). Primer: water flow, wrong animation in portals, etc in Dungeon Siege 2 and all other games with similar functions. I'm just revert minus lines and remove plus:): - mat[12] = mat[8]; - mat[13] = mat[9]; + switch(coordtype) { + case WINED3DDECLTYPE_FLOAT1: + /* Direct3D passes the default 1.0 in the 2nd coord, while gl passes it in the 4th. + * swap 2nd and 4th coord. No need to store the value of mat[12] in mat[4] because + * the input value to the transformation will be 0, so the matrix value is irrelevant + */ + mat[12] = mat[4]; + mat[13] = mat[5]; + mat[14] = mat[6]; + mat[15] = mat[7]; + break; + case WINED3DDECLTYPE_FLOAT2: + /* See above, just 3rd and 4th coord + */ + mat[12] = mat[8]; + mat[13] = mat[9]; + mat[14] = mat[10]; + mat[15] = mat[11]; + break; + case WINED3DDECLTYPE_FLOAT3: /* Opengl defaults match dx defaults */ + case WINED3DDECLTYPE_FLOAT4: /* No defaults apply, all app defined */ + + /* This is to prevent swaping the matrix lines and put the default 4th coord = 1.0 + * into a bad place. The division elimination below will apply to make sure the + * 1.0 doesn't do anything bad. The caller will set this value if the stride is 0 + */ + case WINED3DDECLTYPE_UNUSED: /* No texture coords, 0/0/0/1 defaults are passed */ + break; + default: + FIXME("Unexpected fixed function texture coord input\n"); + } + switch (flags & ~WINED3DTTFF_PROJECTED) { + /* case WINED3DTTFF_COUNT1: Won't ever get here */ + case WINED3DTTFF_COUNT2: mat[2] = mat[6] = mat[10] = mat[14] = 0; + /* OpenGL divides the first 3 vertex coord by the 4th by default, + * which is essentially the same as D3DTTFF_PROJECTED. Make sure that + * the 4th coord evaluates to 1.0 to eliminate that. + * + * If the fixed function pipeline is used, the 4th value remains unused, + * so there is no danger in doing this. With vertex shaders we have a + * problem. Should an app hit that problem, the code here would have to + * check for pixel shaders, and the shader has to undo the default gl divide. + * + * A more serious problem occurs if the app passes 4 coordinates in, and the + * 4th is != 1.0(opengl default). This would have to be fixed in drawStridedSlow + * or a replacement shader + */ + default: mat[3] = mat[7] = mat[11] = 0; mat[15] = 1; + } and all problems with water animation is gone. Seems to any other games not have problems with that i do, but i don't know is this correct? Maybe someone of the developers knows better solution for this? edit: this is tried in wine-0.9.58, Mesa versions 6.52, 7.0, 7.01, 7.02, 7.03rc2 (no problem with all this Mesas) and ATI 9250(r200) and also ATI 9800(r300) cards.

2 2

Proposal template for SOC2008?
by Maarten Lankhorst 24 Mar '08

24 Mar '08

Hi all, I was thinking of copying the template perl uses for people wanting to submit a proposal. Anyone sees anything wrong with using http://www.perlfoundation.org/perl5/index.cgi?gsoc2008_proposal_template ? Cheers, Maarten.

2 1

re: winemenubuilder: Add support for 24 and 32 bit icons using png format.
by Dan Kegel 24 Mar '08

24 Mar '08

Your patch applies and creates .png icons... But it seems to create the icons with two suffixes, e.g. file shows a680_forum.png.xpm: PNG image data, 32 x 32, 8-bit/color RGB, non-interlaced Shouldn't that just be .png, not .png.xpm? (This is for http://bugs.winehq.org/show_bug.cgi?id=4803 )

2 3

Re: 5/3 WineD3D: Don't use blending on pixel formats which don't support it in combination with shaders
by Roderick Colenbrander 23 Mar '08

23 Mar '08

Skip this one among with 5/3, 6/3 and 7/3. All other patches like 8/3 and 9/3 don't require this one and should apply fine. Roderick > Hi, > > Windows drivers only offer post pixel shader blending support on generic > (A)RGB-like formats and in case of dx10-class cards like the Geforce8 also > on some float formats. Right now we enable blending even when it isn't > needed. In case of R32F (if you would disable the software conversion code) this > gives a 400% performance boost in http://www.angelcode.com/dev/shadow/. > > A next patch will add D3DUSAGE_QUERY_PIXELFORMAT_BLENDING support. > > Regards, > Roderick Colenbrander -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

1 0

winegcc: A spec file is currently needed in shared mode?
by Erik de Castro Lopo 23 Mar '08

23 Mar '08

Hi all, Any idea what the above means and how to fix it? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "You can have quality software, or you can have pointer arithmetic; but you cannot have both at the same time." -- Bertrand Meyer, 1989

2 2

ddraw: Don't clear the returnvalue anymore, we keep the dwSize and fill out the rest anyway
by Kolbjørn Fredheim 23 Mar '08

23 Mar '08

Stefan Wrote: >Am Sonntag, 23. März 2008 03:33:56 schrieb Kolbjørn Fredheim: >> Fixes a crash in Anarchy Online >I think we need a test case for that - see dlls/ddraw/tests/d3d.c Not really a need for it, we fill out the whole struct when passing through the function, so there should be no need to memset it to 0, in the worst case we could take the size of the struct as the memset, but using the dwSize is not a good thing imo, it will only crash wine/the program if the program is passing some bizarre value there. I do however have a testcase for it, but it is really messy and spews out alot of junk, so I _really_ didn't want it included in winecode. I could clean up the test, but I'm unshure on how to pass or fail the test, as all I'm doing now is spewing out the raw data of the struct after it's been through the function. ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping

1 0

Re: [PATCH 3/5] wined3d: Handle zero primitive count.
by Stefan Dösinger 23 Mar '08

23 Mar '08

Am Sonntag, 23. März 2008 00:59:48 schrieb Alexander Dorofeyev: > Native can handle zero primitive count both when using old interfaces > (execute buffers etc) and when using d3d8 interface. Wine can crash in > drawprim.c routines like drawStridedSlow and possibly others too, so filter > it out in IWineD3DDeviceImpl_DrawIndexedPrimitiveUP. Fixes crash in > Forsaken. --- > dlls/wined3d/device.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) How will this work for other drawing functions? Shouldn't you filter it in the common drawPrimive() in drawprim.c?

2 1

Re: ddraw: Don't clear the returnvalue anymore, we keep the dwSize and fill out the rest anyway
by Stefan Dösinger 23 Mar '08

23 Mar '08

Am Sonntag, 23. März 2008 03:33:56 schrieb Kolbjørn Fredheim: > Fixes a crash in Anarchy Online I think we need a test case for that - see dlls/ddraw/tests/d3d.c

1 0

Re: 5/3 WineD3D: Don't use blending on pixel formats which don't support it in combination with shaders
by Stefan Dösinger 23 Mar '08

23 Mar '08

Am Sonntag, 23. März 2008 00:08:00 schrieb Roderick Colenbrander: > Hi, > > Windows drivers only offer post pixel shader blending support on generic > (A)RGB-like formats and in case of dx10-class cards like the Geforce8 also > on some float formats. Right now we enable blending even when it isn't > needed. In case of R32F (if you would disable the software conversion code) > this gives a 400% performance boost in > http://www.angelcode.com/dev/shadow/. Don't disable GL_BLEND() in context.c . This will be overwritten by the state_blend() state handler later if the state is dirty for some reason. Instead mark the state dirty and let the state handler code you added handle this. You're checking for use_ps() in the state_blend handler, in this case you'll have to make sure that a pixel shader change updates this. However, I suspect that the pixel shader does not have any effect on blending and the flag's name is a red herring. Can you write a test testing blending on formats that do not support post pixel shader blending?

1 0

Re: Hello Email
by Gynvael Coldwind 23 Mar '08

23 Mar '08

Hello again: On Sun, Mar 23, 2008 at 3:32 AM, Dan Kegel <dank(a)kegel.com> wrote: > Hi Michael! Any idea what you'll be proposing for SoC yet? Oh, sorry, I've missclicked and sent the ideas to David only. I am currently thinking which idea interests me the most. The following things are currently interesting me the most: GDI+ - implement missing functions Tools - Merge winecfg and control panel DirectPlay - Implement the core protocol Print Dialog (from the most interesting to the least). On Sun, Mar 23, 2008 at 7:52 AM, David Adam <david.adam.cnrs(a)gmail.com> wrote: > You need to choose by yourself. Do not ask to us to decide for you. When you > decided which of part of wine you want to work, please contact a mentor to > have some indications. Before applicating officialy for a GSoC, you should > prove that you can achieve some good jobs by sendind patches for wine in the > area that you decided to work. Please do not get me wrong, I am not asking You to decide for me, I'm just asking for Your personal opinion. Don't worry, I'll choose what to apply for by myself ;> Anyway, thanks for Your reply, I'll contact the mentors of the interesting me things. Best regards, -- gynvael.coldwind//vx

2 1

winegcc: A spec file is currently needed in shared mode?
by Erik de Castro Lopo 23 Mar '08

23 Mar '08

Hi all, Any idea what the above means and how to fix it? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "You can have quality software, or you can have pointer arithmetic; but you cannot have both at the same time." -- Bertrand Meyer, 1989

1 0

Re: Regression fix in directx.c
by Roderick Colenbrander 23 Mar '08

23 Mar '08

> > The flag that was removed with the patch in the link here: > > > http://source.winehq.org/git/wine.git/?a=blobdiff;f=dlls/wined3d/directx.c;… > > caused the game "Sins of a solar empire" to not startup anymore. > > This is not the right way to fix it. The code is quite new but works very > differently from the old code. What videocard are you using? At what color > depth? What offscreen rendering method are you using? Further could you > provide your glxinfo output? > > Thanks, > Roderick Also have you tried the latest GIT version? As there have been a number of CheckDeviceFormat fixes after .58. Roderick -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

1 0

Re: Regression fix in directx.c
by Roderick Colenbrander 23 Mar '08

23 Mar '08

> The flag that was removed with the patch in the link here: > http://source.winehq.org/git/wine.git/?a=blobdiff;f=dlls/wined3d/directx.c;… > caused the game "Sins of a solar empire" to not startup anymore. This is not the right way to fix it. The code is quite new but works very differently from the old code. What videocard are you using? At what color depth? What offscreen rendering method are you using? Further could you provide your glxinfo output? Thanks, Roderick -- Psst! Geheimtipp: Online Games kostenlos spielen bei den GMX Free Games! http://games.entertainment.gmx.net/de/entertainment/games/free

1 0

C&C :D
by Maarten Lankhorst 23 Mar '08

23 Mar '08

Hi all! After an announcement that the original Command and conquer is available free for download, I decided to test it. Command and Conquer works perfectly in wine, I haven't tested network gaming over ipx, but that will probably not work. For the rest it's flawless, apart from the losing focus behavior, but playing it in a wine desktop helps. Remember: KANE IS A TRAITOR! LONG LIVE THE GDI! Cheers, Maarten.

4 5

developing hints appreciated
by pure_evil＠mail.bg 23 Mar '08

23 Mar '08

Folks, I'm working with Dan Kegel on the idea of a winecfg/control panel merger; I did a .cpl or two a few days ago, but it seems I didn't quite understand the rules of the dev on wine/ or on linux for that matter :( I need someone to show me the ropes... Basically, The Toolbox. Question 1: I need to mess about with winecfg. I want to compile only winecfg.exe so I can immediately see when I made a mistake /rather than trying to build the entire source of wine/. What's the console command(s) I need to execute in order to get a winecfg.exe or any other single file, executable or otherwise out of the source /preferably not overwriting the real one in use/? Question 2: The cpls/any additional executables that have to be added to wine have to be in source form (duh!). Any particular quirks I should know about? Say, example.exe has to be created when wine is built; it goes into "c: \windows\system32". Is there anything special (some obscure settings?) that needs to be done in order for "./tools/wineinstall" and then "wineprefixcreate" to create "c:\windows\system32\example.exe" out of the source located in "<winesource>/programs/example"? Sorry if the questions appear newbie-ish :(

5 5

Adding a vendor to AppDB
by Christopher 23 Mar '08

23 Mar '08

I sent an email to appdb(a)winehq.org <mailto:appdb@winehq.org> asking to have the vendor "Mozy, Inc." added. Does anyone check that email address? I sent my request over a week ago. If anyone can add it for me, please add "Mozy, Inc." url=<http://mozy.com/about>. I'm the new MozyHome maintainer and the vendor which is listed is wrong. Thanks, Christopher Berner p.s. I just noticed that I'm not in the AUTHORS file, even though several of my patches have been accepted to Wine. Was I suppose to add myself, or is that automatically generated (in which case, why did it leave me out?)

2 1

re: Hello Email
by Dan Kegel 23 Mar '08

23 Mar '08

Hi Michael! Any idea what you'll be proposing for SoC yet?

1 0

quartz: Parse audio packets in mpeg splitter to obtain the duration
by Maarten Lankhorst 22 Mar '08

22 Mar '08

Hello Alexandre, 2008/3/22, Alexandre Julliard <julliard(a)winehq.org>: > "Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > > > + /* Destination sample should contain no data! But the source sample should */ > > + assert(!dlen); > > + assert(*flen); > > Are all these asserts really internal code invariants? It seems to me > they could be triggered by invalid input data, and in that case an > assert is not the appropriate response. They are invariants as far as I know, even with corrupt data. Source sample has a value because that is the condition of the while loop. The destination sample is empty because the loop makes the length zero before handing it over. If it somehow had a length larger or equal to 4 (less then 4 is possible and handled) there is something seriously wrong in the handling code since this should not happen, even in invalid input. Cheers, Maarten.

1 0

Hello Email
by Gynvael Coldwind 22 Mar '08

22 Mar '08

Hello Wine Developers, My name is Michael "Gynvael Coldwind" Skladnikiewicz, and I am thinking about applying for the Google SoC to work on Wine. Please excuse my English, I am not a native English speaker. The first step written on the Wine Ideas page was -introduction-, so.. a little about myself. I am currently at the Wroclaw Univeristy of Technology (it's Politechnika Wrocławska in Polish) on the faculty of Computer Science and Management (Wydział Informatyki i Zarządzania), and my field of study is Computer Science. I am currently at the first year of the second degree - I already graduated the first degree, and I have the right to the degree "inżynier" (it's equal to BSc). I have graduated the same University, but another faculty - The Fundamental Problems of Technology Faculty, where my field of study was also Computer Science. In addition to being a full-time student, I am also working (remotly) at Hispasec Sistemat, where I am a malware reverse engineer, a security researcher and a coder (mostly Windows stuff, both user and kernel mode). Earlier I have worked at Arcabit, a Polish antivirus company, where I created static unpackers for common PE crypters/packers. I started to code when I was about 7 years old (now I'm 24) on an Atari 800 XL, and as the time passed I've moved to a PC and started to code in other languages, like C, C++, Java, Assembler, PHP, and many others. My personal field of interest is computer security (up to date I have found some vulnerabilities in Mozilla Firefox, Opera, Blizzard Starcraft, and few others), reverse engineering, computer graphics (software rendering algorithms and OpenGL mostly), game developement (and playing ;>), and OS research (mostly I focus on Microsoft Windows, but I am also interested in Linux and QNX). Some of my research papers can be found on http://vexillium.org/ and http://gynvael.vexillium.org/. I guess that is enough for introducing myself ;> If You have any questions, don't hesitate to ask ;> Best regards, -- gynvael.coldwind//vx

1 0

package install script for Ubuntu Hardy
by Reece Dunn 22 Mar '08

22 Mar '08

Hi, I have tried out an alpha of Ubuntu Hardy Heron recently (I am currently using Gutsy), and have updated Dan's gutsy.sh script to get the correct packages to build wine. Hardy does not have the libopencdk8-dev package, and didn't have time to investigate which package to use (probably libopencdk9-dev). They have also removed the cogito package, so I replaced it with gitk. Dan: feel free to add this to your site along with the others and update it as needed. - Reece

1 0

Disable editing/deleting/locking posts in wine-forum
by Vitaliy Margolen 22 Mar '08

22 Mar '08

Jeremy, Could you disable this functionality? It makes no sense with the link to the ML where one can't do that. Or now we are getting some users that think they can edit the post and everyone can see that. Vitaliy.

1 0

Failing user message sequences
by Vitaliy Margolen 22 Mar '08

22 Mar '08

I've looked at the user32/tests/msg.c and there are some number of tests that are set to todo_wine. Conincedentaly number of those tests are a biggest problems (looking at bugzilla). For example WmSHOWNATopInvisible message sequence is failing on Wine because of absent WM_NCPAINT message. Could this be the source of the problem for all those full-screen programs that are being "lost" when switching between displays or minimizing / restoring windows. I've tried to track this problem down but can't pinpoint the exact location where this masage should be sent. Is Wine missing a step somewhere (see attachment)? From what I can tell it should be somewhere between mapping the window and WM_WINDOWPOSCHANGED notification. Also worth noting all the MDI tests that fail on Wine. It seems there are fair amount of bugs filed that are related to this tests. IMHO some if not all of those failing tests should be fixed. This is core functionality and there are no excuses for not having it working. I'd say that is much more important them some bugs listed on 1.0 list. Vitaliy. msg.c:3735:calling ShowWindow( SW_SHOWNA) for invisible top level window trace:win:show_window hwnd=0x20020, cmd=8, wasVisible 0 trace:message:SPY_EnterMessage (0x20020) L"Test overlapped" message [0018] WM_SHOWWINDOW sent from self wp=00000001 lp=00000000 msg.c:6147:0x20020, 0018, 00000001, 00000000 trace:message:SPY_EnterMessage (0x20020) DefWindowProc32: WM_SHOWWINDOW [0018] wp=00000001 lp=00000000 trace:message:SPY_ExitMessage (0x20020) DefWindowProc32: WM_SHOWWINDOW [0018] returned 00000000 trace:message:SPY_ExitMessage (0x20020) L"Test overlapped" message [0018] WM_SHOWWINDOW returned 00000000 trace:win:SetWindowPos hwnd 0x20020, after (nil), 0,0 (0x0), flags 00000053 trace:win:dump_winpos_flags flags: SWP_NOSIZE SWP_NOMOVE SWP_NOACTIVATE SWP_SHOWWINDOW trace:message:SPY_EnterMessage (0x20020) L"Test overlapped" message [0046] WM_WINDOWPOSCHANGING sent from self wp=00000000 lp=0034fc10 trace:message:SPY_DumpStructure WINDOWPOS hwnd=0x20020, after=(nil), at (0,0) w=0 h=0, flags=0x00000053 msg.c:6147:0x20020, 0046, 00000000, 0034fc10 msg.c:6219:WM_WINDOWPOSCHANGING msg.c:6220:0x20020 after (nil), x 0, y 0, cx 0, cy 0 flags 00000053 |SWP_SHOWWINDOW|SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE trace:message:SPY_EnterMessage (0x20020) DefWindowProc32: WM_WINDOWPOSCHANGING [0046] wp=00000053 lp=0034fc10 trace:message:SPY_ExitMessage (0x20020) DefWindowProc32: WM_WINDOWPOSCHANGING [0046] returned 00000000 trace:message:SPY_ExitMessage (0x20020) L"Test overlapped" message [0046] WM_WINDOWPOSCHANGING returned 00000000 trace:message:SPY_DumpStructure WINDOWPOS hwnd=0x20020, after=(nil), at (0,0) w=0 h=0, flags=0x00000053 trace:win:SWP_DoWinPosChanging hwnd 0x20020, after (nil), swp 0,0 0x0 flags 00001853 trace:win:SWP_DoWinPosChanging current (100,100)-(300,300) style 04cf0000 new (100,100)-(300,300) trace:win:SWP_DoOwnedPopups (0x20020) hInsertAfter = (nil) trace:win:GetWindowRect hwnd 0x20020 ((100,100)-(300,300)) trace:x11drv:create_whole_window making win 0x20020/0 managed trace:message:SPY_EnterMessage (0x20020) L"Test overlapped" message [007f] WM_GETICON sent from self wp=00000001 lp=00000000 msg.c:6147:0x20020, 007f, 00000001, 00000000 trace:message:SPY_ExitMessage (0x20020) L"Test overlapped" message [007f] WM_GETICON returned 00000000 trace:x11drv:create_icon_window created 4600007 trace:x11drv:X11DRV_create_win_data win 0x20020/4600005/4600006 window (100,100)-(300,300) whole (100,100)-(300,300) client (104,123)-(296,296) trace:x11drv:X11DRV_SetWindowPos 0x20020: need to update visible rect (100,100)-(300,300) -> (104,123)-(296,296) trace:x11drv:X11DRV_SetWindowPos win 0x20020 window (100,100)-(300,300) client (104,123)-(296,296) style 14cf0000 flags 00001857 trace:x11drv:X11DRV_sync_client_position setting client win 4600006 pos 0,0,192x173 changes=3 trace:x11drv:X11DRV_sync_window_position setting win 4600005 pos 104,123,192x173 after c4 changes=f trace:x11drv:X11DRV_SetWindowPos mapping win 0x20020/4600005 trace:win:GetWindowRect hwnd 0x20020 ((100,100)-(300,300)) trace:win:invalidate_dce 0x20020 scope hwnd = 0x10024 (100,100)-(300,300) ((100,100)-(300,300)) trace:win:USER_SetWindowPos status flags = 1847 trace:message:SPY_EnterMessage (0x20020) L"Test overlapped" message [0047] WM_WINDOWPOSCHANGED sent from self wp=00000000 lp=0034fc10 trace:message:SPY_DumpStructure WINDOWPOS hwnd=0x20020, after=(nil), at (100,100) w=200 h=200, flags=0x00001857 msg.c:6147:0x20020, 0047, 00000000, 0034fc10 msg.c:6219:WM_WINDOWPOSCHANGED msg.c:6220:0x20020 after (nil), x 100, y 100, cx 200, cy 200 flags 00001857 |SWP_SHOWWINDOW|SWP_NOACTIVATE|SWP_NOZORDER|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE trace:message:SPY_EnterMessage (0x20020) DefWindowProc32: WM_WINDOWPOSCHANGED [0047] wp=00001853 lp=0034fc10 trace:message:SPY_ExitMessage (0x20020) DefWindowProc32: WM_WINDOWPOSCHANGED [0047] returned 00000000 trace:message:SPY_ExitMessage (0x20020) L"Test overlapped" message [0047] WM_WINDOWPOSCHANGED returned 00000000 trace:message:SPY_EnterMessage (0x20020) L"Test overlapped" message [0005] WM_SIZE sent from self wp=00000000 lp=00ad00c0 trace:message:SPY_DumpStructure cx=192 cy=173 msg.c:6147:0x20020, 0005, 00000000, 00ad00c0 trace:message:SPY_EnterMessage (0x20020) DefWindowProc32: WM_SIZE [0005] wp=00000000 lp=00ad00c0 trace:message:SPY_ExitMessage (0x20020) DefWindowProc32: WM_SIZE [0005] returned 00000000 trace:message:SPY_ExitMessage (0x20020) L"Test overlapped" message [0005] WM_SIZE returned 00000000 trace:message:SPY_EnterMessage (0x20020) L"Test overlapped" message [0003] WM_MOVE sent from self wp=00000000 lp=007b0068 msg.c:6147:0x20020, 0003, 00000000, 007b0068 trace:message:SPY_EnterMessage (0x20020) DefWindowProc32: WM_MOVE [0003] wp=00000000 lp=007b0068 trace:message:SPY_ExitMessage (0x20020) DefWindowProc32: WM_MOVE [0003] returned 00000000 trace:message:SPY_ExitMessage (0x20020) L"Test overlapped" message [0003] WM_MOVE returned 00000000 msg.c:3737:expected 0018 - actual 0018 msg.c:3737:expected 0046 - actual 0046 msg.c:3737:expected 8002 - actual 0047 msg.c:3737:expected 0085 - actual 0047 msg.c:3737: Test failed: ShowWindow(SW_SHOWNA) on invisible top level window: the msg 0x0085 was expected, but got msg 0x0047 instead msg.c:3737:expected 000d - actual 0005 msg.c:3737:expected 0014 - actual 0005 msg.c:3737:expected 0047 - actual 0005 msg.c:3737: Test failed: ShowWindow(SW_SHOWNA) on invisible top level window: the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:3737:expected 0083 - actual 0003 msg.c:3737:expected 0085 - actual 0003 msg.c:3737:expected 0014 - actual 0003 msg.c:3737:expected 800b - actual 0003 msg.c:3737:expected 0005 - actual 0003 msg.c:3737: Test failed: ShowWindow(SW_SHOWNA) on invisible top level window: the msg 0x0005 was expected, but got msg 0x0003 instead msg.c:3737: Test failed: ShowWindow(SW_SHOWNA) on invisible top level window: the msg sequence is not complete: expected 0003 - actual 0000 msg.c:3738:done

1 0

Re: wined3d: Initialize maxAttribs in case it isn't changed by glGetIntegerv.
by Stefan Dösinger 22 Mar '08

22 Mar '08

Am Samstag, 22. März 2008 18:28:52 schrieb Philip Nilsson: > My OpenGL implementation (NVIDIA's binary driver, version 169.12) > returns GL_NO_ERROR in this function, but doesn't change the passed > value. Uninitialized maxAttribs might be about 1500000 and thus > generate a couple hundred megabytes of GL_CHECK_CALL errors. > > 16 is what is set if glGetIntegerv returns some error, and is also the > minimum value required by an implementation. I've seen this behavior very old drivers(87.xx), but I am kinda puzzled why it happens with the new drivers. The patch is OK, but we should investigate why the call fails for you

2 1

re: Richedit regression
by Dan Kegel 22 Mar '08

22 Mar '08

Andrew Talbot wrote: > An app I use - Blitzin2 - has a richedit control that used to wrap, and since > "richedit: Added support for EM_SETTARGETDEVICE with a NULL DC" > (http://source.winehq.org/git/wine.git/?a=commit;h=33d7cea120bd7d37175cd5c89…) > the text gets truncated, instead. Yep. I filed http://bugs.winehq.org/show_bug.cgi?id=12098 a while ago, it hits several apps. Please append your info there.

2 1

Please add new version 0.9.58 to bugzilla & appdb please
by Vitaliy Margolen 22 Mar '08

22 Mar '08

Please add new version 0.9.58 to bugzilla & appdb please. Vitaliy.

1 0

wine 1.0 status: T minus 76 days. 87 open bugs.
by Dan Kegel 22 Mar '08

22 Mar '08

76 days to go before release. I'm slowly going through the 1.0 bug list and deferring bugs that only affect single non-required apps and don't have good analysis or patches, or that can't be fixed in time. e.g. I deferred bug 6971 (Mouse "escapes" window) even though lots of people voted for it, simply because it probably requires changes in X. As of now we're down to 87 bugs. My guess is we'll eventually fix 30 or so of these (about ten look easy), and the other 57 or so will be deferred. Here's the list, sorted by component: # Comp Votes Summary 5948 -unknown 1 Star Trek: Armada does not install 4971 -unknown 3 Corel Draw 12 demo install fails 12097 -unknown 1 Wine 1.0 should not ship out-of-sync resource translations 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 11281 -unknown 2 CJK input many issues 7477 -unknown 1 Uplink demo crashes 7915 -unknown 4 15 of the internal tests of wine fail on Mac OS X 5402 -unknown 0 Trying to run PhotoStitch 3.1 8125 -unknown 0 Marratech 6.1 crashes on start 9916 -unknown 5 "make test" usually fails 5024 -unknown 3 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 9459 -unknown 8 FIFA 2007 crashes with the recent versions 5061 -unknown 5 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5844 -unknown 8 tray minimize 10815 -unknown 1 Cannot drag images into Adobe Photoshop 7 from the web / desktop 9178 -unknown 8 "hello world" dos program hangs 10147 -unknown 0 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 2 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 10111 comctl32 2 WINEDEBUG=warn+heap "make test" has heap error in comdlg32/tests/printdlg.c 2493 comctl32 1 Multi-select listview: Shift-arrow up only selects top two items 9104 comdlg32 1 Pdf-xchange viewer crashes 11681 directx- 11 Add support for video overlay 9030 directx- 0 army men hangs on black screen 5955 directx- 6 DirectDrawCreate crash on non-OpenGL desktop 1347 directx- 20 Screen is wiped/blanked on usage of DirectDraw 5535 directx- 16 Planescape:Torment doesn't work 82 document 1 Stabilize Winelib User Guide Table of Contents 638 document 7 Document Wine debugging channels 9926 gdi32 4 gdi32.dll should not have exported function pointers 6519 gdi32 6 Wine blacks out rotated font bitmap 9771 gdi32 37 Steam Friends doesn't work (fails to render correctly or refresh) 3270 gdi32 12 Problem with minimized top-level windows 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 6526 kernel32 1 Typing Instructor for Kids 2 fails to install 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 5351 kernel32 8 Windows Installer 3.1 cannot install because of non-standard drive labeling 4733 kernel32 4 Get optimized/compressed/packed executables (non-upx) working 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 11 Office XP 2002 crashes on installation 8783 ntdll 11 USB serial ports do not work 9356 ntdll 5 Serial communication not working since wine-0.9.33 6607 ole 6 Drag and Drop not working 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 2539 ole 2 XDND (Drag and drop for X Windows) doesn't copy text 8095 ole 0 PQ Teaching toy crashes 4770 ole 2 BlackBerry Device Manager fails to install under wine 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 4803 programs 5 Steam: not all lnk files are processed into linux shortcuts 6254 richedit 3 Installer infinite loop from rich text error 6095 shdocvw 11 MOTD in counter-strike 1.6 and counter-strike source does not render 6795 shdocvw 0 Skype 3.0.0.137 Beta dies trying to login in win98, winme mode 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 3546 shdocvw 2 CLSID_InternetShortcut not available... 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 10905 shell32 0 thinstall firefox demo requires native msvcrt 8439 shell32 4 Visual Studio .NET (7) install fails 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 2 invoking htmlhelp:HtmlHelpW crashes wine 10708 user32 21 Wine lacks support for animated cursors 664 user32 5 The help menu functionality inside programs is broken (messaging problem) 11431 user32 5 Adobe Photoshop CS2: z-overlay of image containers 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 3534 user32 14 Systray icons are not transparent... 124 wineserv 2 Review of Wine Server Protocol 10984 winex11. 2 sun jre 5 update 10 installer hangs in 0.9.52 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 5623 winex11. 2 GetAsyncKeyState wrong if querying process doesn't have focus 1990 winex11. 1 modifier keys not released when switching desktop 5828 winex11. 23 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 11884 winex11. 1 Copy and paste garbage on end 3297 winex11. 9 UpdateWindow() doesn't call XFlush() 11019 winex11. 1 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 2368 winex11. 4 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3711 winsock 0 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 9787 winsock 44 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 10032 winsock 1 Wine must not use unix select() for networking where there might be high fd's 5625 winsock 3 Wine does not handle internet proxy settings conveniently 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

2 1

Re: Richedit regression
by Stefan Dösinger 22 Mar '08

22 Mar '08

Am Samstag, 22. März 2008 15:54:05 schrieb Andrew Talbot: > Hi Eric, > > An app I use - Blitzin2 - has a richedit control that used to wrap, and > since your patch "richedit: Added support for EM_SETTARGETDEVICE with a > NULL DC" Wrong mailing list?

2 1

Re: Richedit regression
by Andrew Talbot 22 Mar '08

22 Mar '08

Whoops! Sorry, I meant to send this to Eric [Pouech]. D'oh! -- Andy.

1 0

Re: quartz: Parse audio packets in mpeg splitter to obtain the duration
by Alexandre Julliard 22 Mar '08

22 Mar '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > + /* Destination sample should contain no data! But the source sample should */ > + assert(!dlen); > + assert(*flen); Are all these asserts really internal code invariants? It seems to me they could be triggered by invalid input data, and in that case an assert is not the appropriate response. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: WideCharToMultiByte: return error on negative dest len
by James Hawkins 22 Mar '08

22 Mar '08

On Fri, Mar 21, 2008 at 6:43 PM, Dan Kegel <dank(a)kegel.com> wrote: > While investigating a crash in gs-auftrag in bug 9039, noticed > WideCharToMultiByte > wasn't quite conformant for negative destlen. Fixed, with tests. > > diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c > index 1130349..2decf85 100644 > --- a/dlls/kernel32/locale.c > +++ b/dlls/kernel32/locale.c > @@ -31,6 +31,7 @@ #include <stdarg.h> > #include <stdio.h> > #include <ctype.h> > #include <stdlib.h> > +#include <limits.h> > > #ifdef __APPLE__ > # include <CoreFoundation/CFBundle.h> Leftover from a previous version of the patch? -- James Hawkins

2 1

bug_report.pl
by Austin English 22 Mar '08

22 Mar '08

In cleaning up the documentation, I found that we still reference tools/bug_report.pl. The script is about 8-9 years old! I haven't seen it referenced in a while, and looking in the archives, the last time it was mentioned was in 2002: http://www.winehq.org/pipermail/wine-devel/2002-May/006741.html Which even then, some thought it should be removed, or drastically updated. It currently strips down to 100 lines, which in most cases is pretty useless. As I see it, there are a couple options (which, coincidentally, were the same 6 years ago): 1) remove bug_report.pl, update the documentation for more useful debug info 2) have a perl mongerer update it drastically to where it is of some use. Thoughts?

1 0

Fun Projects page - needs update
by Austin English 22 Mar '08

22 Mar '08

Looking at http://winehq.org/site/fun_projects, A LOT of it is out of date. I've been looking through the documentation and starting to update some of it, but this is one I don't know too much about. Would everyone mind taking a look and updating whatever they know is fixed/what they're working on/etc. Perhaps we should move this to the wiki...If not, send me an e-mail and I'll update it for you. -Austin

1 0

Re: [Bug 12131] New: Need a 1.2.0 milestone
by James Hawkins 21 Mar '08

21 Mar '08

On Thu, Mar 20, 2008 at 9:40 PM, <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=12131 > > Summary: Need a 1.2.0 milestone > Product: WineHQ Bugzilla > Version: unspecified > Platform: Other > OS/Version: other > Status: NEW > Severity: enhancement > Priority: P2 > Component: bugzilla-unknown > AssignedTo: wine-bugs(a)winehq.org > ReportedBy: dank(a)kegel.com > > > Please create a 1.2.0 target in bugzilla. > > I've requested it a few times on the mailing list, > but it hasn't been created, so I'm trying it > on bugzilla now. > This is related to the problem, but there needs to be at least one other bugzilla super-admin. The only active bugzilla admin I know of is Jan Zerebecki, and he is not online enough to keep up with the pace of wine development, especially this close to the 1.0 release. Who is in charge of this and can add another super-admin? -- James Hawkins

5 5

Re: 7/6 WineD3D: CheckDeviceFormat srgb write support
by Stefan Dösinger 21 Mar '08

21 Mar '08

Am Freitag, 21. März 2008 22:49:05 schrieb Roderick Colenbrander: > Hi, > > This patch adds srgb write support to CheckDeviceFormat. Before we > implicitly allowed it. Stefan said that we offer it using ARB/GLSL shaders > when the format is X8R8G8B8 or A8R8G8B8. Ah, looks like you were faster than I was with replying :-) Did you check which formats offer srgb writing on Windows? Our pixel shader code offers it for all formats, although srgb correction is pretty pointless on float buffers

2 1

Re: 5/6 WineD3D: CheckDeviceFormat texture
by Stefan Dösinger 21 Mar '08

21 Mar '08

Am Freitag, 21. März 2008 22:07:17 schrieb Roderick Colenbrander: > Hi, > > Don't continue with CheckDeviceFormat if a texture format isn't around. What happens with volumetextures here?

2 1

re: GSoC: reg.exe
by Dan Kegel 21 Mar '08

21 Mar '08

> [Somebody is already working on reg.exe.] > Does that mean the project is no longer free for grabs? It depends. The SoC staff frown on joint projects, but it's possible. I would suggest looking at other useful commandline utilities (see e.g. the list at http://commandwindows.com ) and check wine's bugzilla to see if any have been requested, and then propose those. - Dan

3 2

wine + mono instead of .net framework?
by Jeroen Janssen 21 Mar '08

21 Mar '08

Hi, I was wondering if it is possible to use mono instead of the (microsoft) .net framework for windows applications running under wine. i.e. I have an application that 'requires' .net 2.0, and wants me to install it. With mono 'installed' it would see that .net 2.0 is "already installed" and just work ;) Any thoughts on if this is possible (or even wanted?) Best regards, Jeroen Janssen

2 1

Re: 6/6 WineD3D: CheckDeviceFormat remove dead code
by Stefan Dösinger 21 Mar '08

21 Mar '08

Am Freitag, 21. März 2008 22:11:48 schrieb Roderick Colenbrander: > I expect a number of other 'fake' regressions like the one regarding srgb > writing but those can only become visible after this patch. Note that we perfectly well support srgb writing on all formats if ARB or GLSL pixel shaders are supported. We emulate the srgb correction in the shader Note that this is not 100% there, if the game is using the fixed function fragment pipeline we currently have no ARB or GLSL pixel shader which could do the gamma correction. However, many games(like HL2) require srgb correction, so we should keep it enabled.

1 0

Re: winex11.drv: Indirection level fix
by Ken Thomases 21 Mar '08

21 Mar '08

On Mar 21, 2008, at 10:30 AM, Andrew Talbot wrote: > It seems that either "packet" should not be a WTPACKET **, or the > first > parameter to the memcpy() should be *packet. Unable to find this > function being > used anywhere, I guessed the former. It's used in dlls/wintab32/wintab32.c via pGetCurrentPacket and you appear to have guessed correctly. Cheers, Ken

2 1

re: GSoC application
by Dan Kegel 21 Mar '08

21 Mar '08

> I would like to submit my GSoC application link: > http://wiki.winehq.org/LouisLadas Hi Louis, you should probably look for a couple backup apps to implement as I suggested to the other applicant here: http://winehq.org/pipermail/wine-devel/2008-March/063828.html Have you already built wine from source? Also, no reason to wait for SoC to start; you should consider submitting patches ahead of time, it'll help you ramp up. - Dan

1 0

AppDB?
by Christopher 21 Mar '08

21 Mar '08

Who's in charge of AppDB? I sent in a couple requests a week ago, and they still haven't been approved (or denied). The first was for a new application, PhoenixRC, which I'll be happy to maintain. And the other was for a new vendor, Mozy, Inc., so that I could update MozyHome to have the correct vendor. Christopher

1 0

GSoC'08 - Tools - Scriptable Configuration
by Xanf 21 Mar '08

21 Mar '08

Hello, everyone. My name is Illya and I'm interested in taking part in GSoC 2008 for implementing scriptable configuration for wine. So I'd liked to discuss it with community. First of all - why I'm interested in that project? Currently I'm working as a kind of "software consultant" in my city. My primary The primary aim of work - helping migrating from MS Windows platform to Linux & Open Source. Unfortunately, a great number of different applications were written and still heavily used in companies of my city for Windows. And this is a place where Wine makes great help. Need of scriptable configuration is quite critical for helping me quickly perform standard configuration for some apps, and even more - make "install packages" which will help users unfamiliar with Wine quickly run their software. Now - Why me? Quite hard question. First of all, I have a personal interest (see above :) ). Second - now I have strong will and real possibility (as I estimate) to implement that project. I've looked for projects of GSoC'07 year ago - and realized that I wasn't ready for them. Although I'm absolutely new to wine-devel, I've been using Wine (and no windows at my computer at all) for about a year. I have experience working on some big projects (it is mangos WoW emulator (http://mangosproject.org/) and especially ScriptDev2 (scripting engine for mangos) (http://scriptdev2.com) ). Currently I have strong skills in reading and understanding code written by others. I have quite strong C/C++ (mostly C++) skills. I've participated in ACM contests and received 1 place in Ukraine and we (My team) were in top-ten in Eastern Europe Region contests. How I see my future work? First of all, in short term after this message (possibly on weekend) if I receive a positive (or at least non-negative response) from community I plan to create a specification of CLI syntax, which I expect to be implemented by me, divided in stages to have a step-by-step working guide. After obtaining community suggestions that'll become a future work plan for summer. Then I'll spend some time in wine code reading (I've already have experience in some "hacking" for my brother's favorite games, but I need some time for deeper understanding). And after that - the work will start. I expect to make a weekly "reports" how the work going on, and create a series of patches for each step defined above. Thanks for reading probably a bit long letter, and sorry for possibly bad English - it is far away from my mother tongue. Best regards, Illya Klimov

2 1

re: GSoC'08 - Tools - Scriptable Configuration
by Dan Kegel 21 Mar '08

21 Mar '08

Illya wrote: >Currently I'm working as a kind of "software consultant" in my city. >My primary The primary aim of work - helping migrating from MS >Windows platform to Linux & Open Source. Unfortunately, a great number >of different applications were written and still heavily used in >companies of my city for Windows. And this is a place where Wine >makes great help. >Need of scriptable configuration is quite critical for helping me >quickly perform standard configuration for some apps, and even more - >make "install packages" which will help users unfamiliar with Wine >quickly run their software. Can you give some examples? This sounds kind of like the wine-robot, wine-doors, and wpkg.org efforts. And there might be a lot of overlap with the automated application test idea from http://wiki.winehq.org/SummerOfCode - Dan

1 0

Re: [4/22] WineD3D: A shader backend descriptor for the ati fragment shader backend
by Ivan Gyurdiev 21 Mar '08

21 Mar '08

I don't quite understand why it's necessary to write ARB, GLSL, and NONE shader descriptors inside the ati_shader file. How will this infrastructure scale to a new shader backend added a year from now ? For such a large patchset maybe there should be a high level design diagram that explains how it works ? I very much like that backend-specific functionality ends up in the appropriate backend - as per patches 10, 11, and 14. However, it seems those patches stand on their own, independent of the rest of the patchset and this feature. Ivan

3 33

Re: loader: more stringent sanity check
by Alexandre Julliard 21 Mar '08

21 Mar '08

"Dan Kegel" <dank(a)kegel.com> writes: > + if (!strcmp( argv[1], "--nosanitycheck" )) > + { > + perform_sanity_check = 0; > + > + /* Delete --nosanitycheck from argv */ > + > + /* Size of argv before is argc +1 for argv[0], +1 for argv[argc]=0 */ > + /* Size of argv afterwards is one less */ > + argv = malloc((argc + 1) * sizeof (char *)); > + argv[0] = (*pargv)[0]; > + memcpy(argv+1, *pargv + 2, argc * sizeof(char *)); /* final 0, too */ > + argc--; > + *pargc = argc; > + *pargv = argv; > + } > + > + if (perform_sanity_check && !geteuid()) > + { > + fprintf( stderr, "%s\n%s\n", > + "Please don't run wine as root! See http://wiki.winehq.org/NoRoot", > + usage ); > + exit(1); > + } I hope you are not seriously suggesting that we do this... I'm not at all convinced that we need even a warning, there doesn't seem to be much concrete evidence that running as root is actually harmful, and it's necessary in many cases. Refusing to run is clearly not an option. If we really need to have something then it should be at most a one-time warning (in a message box so people have a chance to see it) at wineprefixcreate time, with an easy way to disable it. -- Alexandre Julliard julliard(a)winehq.org

9 15

Re: Implement ID3DXRenderToSurface*
by tony.wasserka＠freenet.de 21 Mar '08

21 Mar '08

> It would probably be better to avoid doing that. It isn't quite the > same as disassembling the native implementation, but in general you > want to avoid looking at how the native implementation is implemented > rather than how it behaves. I have to admit that I didn't think of these kind of things, however for D3DXCreateRenderToSurface this isn't a problem as all what I got from the output was that I have to call no d3d functions. > ...and that's pretty much unacceptable. I see, this will probably need a fixed patch. > It might be true that on wine the device never becomes invalid, but > that might not always remain true, and IMO our d3dx9 dlls should work > on native win32 as well. The code should run on native windows, too, though it isn't that well tested. (IMO there isn't much to test about a few release calls anyways). Also, ResetDevice is the same as D3DXCreateRenderToSurface, as it doesn't do anything either. But thank you for the time you spent on reviewing my patches :) Best regards Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

Re: d3dx9: Implement ID3DXRenderToSurface_OnLostDevice/OnResetDevice [PATCH 7/7]
by H. Verbeet 21 Mar '08

21 Mar '08

On 20/03/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > These are not very interesting... > On winehackers I was told that under wine the device won't ever get invalid anyways so these patches are just > for having the implementation complete. > It might be true that on wine the device never becomes invalid, but that might not always remain true, and IMO our d3dx9 dlls should work on native win32 as well.

1 0

Re: d3dx9: Implement ID3DXRenderToSurface_EndScene [PATCH 6/7]
by H. Verbeet 21 Mar '08

21 Mar '08

On 20/03/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > ...and clean up everything again. > I have no idea why it's StretchRect and not UpdateSurface or something, but the native dll is doing it like this. > > + /* The native d3dx9 does a buffer->GetDevice(&bufdev) here. ...and that's pretty much unacceptable.

1 0

Re: d3dx9: Implement D3DXCreateRenderToSurface [PATCH 2/7]
by H. Verbeet 21 Mar '08

21 Mar '08

On 20/03/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > Just a little note: All functions have been coded using the output of WINEDEBUG="d3d9", > i.e. my implementation is doing exactly the same things as the native d3dx9 regarding > d3d stuff. It would probably be better to avoid doing that. It isn't quite the same as disassembling the native implementation, but in general you want to avoid looking at how the native implementation is implemented rather than how it behaves.

1 0

Re: wineprefixcreate: more stringent sanity check (try 2)
by Marcus Meissner 21 Mar '08

21 Mar '08

On Thu, Mar 20, 2008 at 05:25:12PM -0700, Dan Kegel wrote: > (Moved check to wineprefixcreate as Alexandre suggested.) > > Many newbies mistakenly run wine as root. Catch > this in wineprefixcreate and direct them to the wiki. > Power users can bypass the check with --nosanitycheck. > Fixes the remainder of http://bugs.winehq.org/show_bug.cgi?id=10324 > +if [ $do_sanitycheck = 1 ] && [ -w / ]; then > + cat > /tmp/wineprefixcreate.$$.txt <<_EOF Bad from a security point of view at least, its predictable and should perhaps be removed later on. Pass it directly as argument to botyh xmessage and echo I would say. txt=<<EOL ...here the text ... EOL xmessage ... "$txt" Ciao, Marcus

1 0

Make XP emulation the default?
by Dan Kegel 21 Mar '08

21 Mar '08

What would break if we made XP the default windows version in Wine? I've run into several apps that fail to install unless I change that setting lately...

4 5

Re: quartz: Replace second EnterCriticalSection with LeaveCriticalSection (Smatch).
by Maarten Lankhorst 20 Mar '08

20 Mar '08

Hi Michael, 2008/3/20, Michael Stefaniuc <mstefani(a)redhat.de>: > This looks like an cut'n'paste error to me. > > - EnterCriticalSection(This->crst); > + LeaveCriticalSection(This->crst); Many thanks for catching that! Cheers, Maarten.

1 0

GSoC application
by Mad Scientist 20 Mar '08

20 Mar '08

Hello wine-devel, I would like to submit my GSoC application link: http://wiki.winehq.org/LouisLadas?action=show Thanks :)

1 0

Website: Update PC-BSD download link and icon
by Austin English 20 Mar '08

20 Mar '08

Any reason this patch wasn't applied? http://www.winehq.org/pipermail/wine-patches/2008-March/051747.html

1 0

GSoC: reg.exe
by Max99x 20 Mar '08

20 Mar '08

Greetings, I've noticed Wine is participating in GSoC and one of the ideas is an OSS implementation of reg.exe. I'm very interested in working on this project, but looking around the list it seems the stub was posted only a few days ago, and the author is willing to work on it in the future (I believe a patch was added even today). Does that mean the project is no longer free for grabs? -- View this message in context: http://www.nabble.com/GSoC%3A-reg.exe-tp16185690p16185690.html Sent from the Wine - Devel mailing list archive at Nabble.com.

1 0

re: developing hints appreciated
by Dan Kegel 20 Mar '08

20 Mar '08

I think he's a windows developer, comfortable mostly with IDEs like Visual C++. He'd like to build winecfg as a .exe on Wine, test it there, and also try running it on Windows (at least part of it should kinda work there). Here's what I told him: On Ubuntu, 'sudo apt-get install mingw' should install a good compiler. However, it might not be easy to build winecfg with mingw. Ask on wine-devel if you have trouble. See also http://wiki.winehq.org/JohnKlehm http://www.winehq.org/pipermail/wine-devel/2006-December/053069.html If I were you, I'd just use Wine's normal build system on linux and not even try to generate .exe's for now. - Dan

1 0

Game Performance and Grafik Cards
by Groeschel, Volker 20 Mar '08

20 Mar '08

Hi, I have read many valuable information from Detlef, Roderick and Stefan about this topic. Thank you very much for this so far! e.g. http://wiki.winehq.org/DirectDraw http://wiki.winehq.org/UsefulRegistryKeys and some comments in bugzilla. But it is still very hard for me to tell what I need to do to improve performance. All I have is trial and error. What I'm missing ist some kind of feature list for the different grafic drivers. It would be very helpfull to have more infomation which features are supported and how well supported with the most important drivers and for which cards: - RADEON - AMD Catalyst - Nvidia binary Another thing I'm missing is a guid how I can tell which features my game needs. Then I could bring this information together and find the best match. Like "your games uses xxx and the driver supports yyy, in this case use switch zzz for best results". Is there any chance that we can get this in the Wiki? Once this information is available the application maintainers in the AppDB could start to add recommendations for each game and make it more easy for beginners as well.

2 1

Testing service/driver install via setupapi
by Paul Vriens 20 Mar '08

20 Mar '08

Hi, I'm looking into bug 12030 (http://bugs.winehq.org/show_bug.cgi?id=12030). The driver service is not installed by our InstallHinfSection function. I'm first trying to come up with a test before even trying to do the implementation. The question I'm having is whether I should be doing the test with InstallHinfSection and/or SetupInstallServicesFromInfSection[Ex]? The current setupapi tests only test InstallHinfSection. But in the end SetupInstallFromInfSection will be called from within InstallHinfSection. Should I take the same approach for the services piece?. So, 1) Implement in SetupInstallServicesFromInfSection[Ex] 2) Test via InstallHinfSection -- Cheers, Paul.

1 0

The Linux/BSD DF kernel bug
by Francois Gouget 20 Mar '08

20 Mar '08

So I've just read the following article: GCC 4.3.0 exposes a kernel bug http://lwn.net/SubscriberLink/272048/ecf14f359bcdcd15/ And my question is: could this be relevant to Wine? And I don't mean about GCC 4.3.0 but about MSVC. Here's the core of the issue: The problem revolves around the x86 direction flag (DF), which governs whether block memory operations operate forward through memory or backwards. GCC [...] 4.3.0, assumes that the direction flag has been cleared [...] at the entry of each function, as is specified by the ABI [...] Prior to 4.3, GCC would emit a cld (clear direction flag) opcode before doing inline string or memory operations. So any compiler that not clear the direction flag at the start of each function can cause kernel crashes when running on a buggy Linux or BSD kernel. So the questions are: Does anyone know if MSVC does a cld in the right places? What about other popular compilers used to compile Windows applications? Mac OS X being (loosely) based on the BSD kernels, does it have this issue too? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

4 12

re: First steps to make Win32 app running under Wine
by Dan Kegel 20 Mar '08

20 Mar '08

Martin Hinner wrote: > I am solving problem how to get one Win32 app (for which I have > source code) running under Wine. The biggest issue is drivers and > ioctls. Linux has driver support for what we need and provides similar > ioctls for some stuff, but it differs from Windows. What drivers and ioctls, exactly? Which driver framework are you using? http://en.wikipedia.org/wiki/User-Mode_Driver_Framework might be easier for us to directly support... - Dan

1 0

Google Summer of Code Test Suite project
by Corey McClymonds 20 Mar '08

20 Mar '08

I would like to work on the Regression Suite project, but I'm not quite sure of the scope. Would I be choosing a good 30 or 40 applications that run well on wine, using wpkg to install them, and then test for failures? Because that would seem as though I am only doing installer testing, instead of actual application testing. I would also like to do some sort of automated regression testing for actual features you can easily test, if that would be possible. Corey

4 4

Re: wineboot: Add the Romanian translation.
by Dimi Paun 20 Mar '08

20 Mar '08

On Wed, 2008-03-19 at 23:57 +0100, Michael Stefaniuc wrote: > + LTEXT "O îeșire sau oprire simulată este în curs dar > acest proces nu răspunde.", This should be "O ieșire" not "O îeșire", no? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

First steps to make Win32 app running under Wine
by Martin Hinner 20 Mar '08

20 Mar '08

Hi, I am solving problem how to get one Win32 app (for which I have source code) running under Wine. The biggest issue is drivers and ioctls. Linux has driver support for what we need and provides similar ioctls for some stuff, but it differs from Windows. The difference is *so big* that I would prefer to modify our source code to use different pieces of code when it detects Wine. I understand, that this is *against* Wine policy and generally should not be used. But writing built-in replacement for some DLLs (hack Linux-style drivers into Windows-style) would be a nightmare, so having small mods to Win code would be much easier. I am not talking about "generic" functions, but about specific drivers/etc. Imagine this: Under windows you get usb driver with some ioctl-based interface, sometimes with DLL or without it (vendor provides only .lib file that gets statically linked). Under Linux there is libusb used. Difference between these two ways of driver implementation is *huge* and making libusb driver compatible with Win32 driver is almost impossible (in Win you have a real file handle, under libusb only pointer, etc.). It would greatly help for this case to be able to: - detect wine and platform from Win32 app (.exe) - load native Linux library and perform ioctls (ioctl(2), not Windows IOCTL!) on file handles - get somehow access to files in Linux filesystem (i.e. in /dev) This would allow to easily modify our source code in a few places (i.e. hardware routines) and get it quickly running under Linux. I can do all above by writing some built-in dll that would work just for my case, but I think *maybe* it's worth it to provide some generic interface in Wine?? Martin

2 2

Re: [1/2] reg: Implement basic 'reg add'.
by Dmitry Timoshkov 20 Mar '08

20 Mar '08

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > +int reg_lstrncmpiW(const WCHAR *s1, const WCHAR *s2, size_t n) CompareString is better. > + const WCHAR hkcrW[] = {'h','k','c','r',0}; > + const WCHAR hkcuW[] = {'h','k','c','u',0}; > + const WCHAR hklmW[] = {'h','k','l','m',0}; > + const WCHAR hkuW[] = {'h','k','u',0}; > + const WCHAR hkccW[] = {'h','k','c','c',0}; > + const WCHAR hkddW[] = {'h','k','d','d',0}; You should make all const strings static. > + /* TODO: Remote registry editing. */ > + if (key_name[0] == '\\' && key_name[1] == '\\') > + { > + fprintf(stderr, "Remote registry editing not implemented.\n"); > + return 1; > + } Please use normal WINE_TRACE, WINE_ERR, etc instead of fprintf. -- Dmitry.

1 0

Questions regarding Summer of Code( and Dplay)
by Maarten Lankhorst 20 Mar '08

20 Mar '08

Hello Anurag, 2008/3/19, Anurag Mishra <mishra.anurag07(a)gmail.com>: > I am student at IIT Kanpur[1]. I have quite good knowledge about C > and have been tracking development of Wine over a period of 6 months > or so. I have good knowledge about C(and using it theoretically to > implement stacks, efficient structures and so on). However, I have > little real life experience about programming a project. I have little > experience about Window's API. > I was looking to participate in Wine development this summer. On SoC > page, the idea of Dplay was bought up. I am interested in trying hands > on that. Can anyone suggest what would be a good starting point? There are only a few important things to directplay as far as I know. The first one is find a game that runs in wine and uses it, and works reasonably well single player but not at all multiplayer or online because of the missing things (fixmes on dplay in console). After you played the game a little bit, think of a plan on how you want to tackle this problem. Have you managed to compile a git version of wine yet? Cheers, Maarten.

1 0

Questions regarding Summer of Code( and Dplay)
by Anurag Mishra 20 Mar '08

20 Mar '08

Hi, I am student at IIT Kanpur[1]. I have quite good knowledge about C and have been tracking development of Wine over a period of 6 months or so. I have good knowledge about C(and using it theoretically to implement stacks, efficient structures and so on). However, I have little real life experience about programming a project. I have little experience about Window's API. I was looking to participate in Wine development this summer. On SoC page, the idea of Dplay was bought up. I am interested in trying hands on that. Can anyone suggest what would be a good starting point? Thanks, Anurag Mishra. [1] http://www.iitk.ac.in

1 0

Proposed EM_Fontrange Patch
by James McKenzie 20 Mar '08

20 Mar '08

All: I would like to see the problems with EM_Fontrange be fixed. The attached patch is for comment/review and I would like SPECIFIC guidance on how to implement this patch as it relates to a Wine 1.0 bug (bug/issue 6254) and fixes the problem specified there. The conformance tests are already in tests/editor.c and all they involve is removing some todo_wine blocks related to this issue. The entire patch will do this. Sorry that the patch is in UNIX diff format, I could not get git to do what I wanted. The actual patch will be git format and use the daily git. Also, I would like to extend thanks to Tony Rollo, Lei Zhang and Eric Pouech for their guidance and prior fixes. I would like to thank Erich Pouech for moving some of the functionality that the original patch introduced into OLE handling. Please be BRUTAL as I feel we have a limited time period to get this in and other related issues that the patch will expose fixed before Wine 1.0. Thank you. James McKenzie

3 2

Re: wine-devel Digest, Vol 32, Issue 75
by Corey McClymonds 20 Mar '08

20 Mar '08

> From: "Dan Kegel" <dank(a)kegel.com> > To: "Wine Developers List" <wine-devel(a)winehq.org> > Date: Wed, 19 Mar 2008 16:31:03 -0700 > Subject: re: Google Summer of Code Test Suite project > On Wed, Mar 19, 2008 at 3:01 PM, Corey McClymonds <galeru at gmail.com> wrote: > > I would like to work on the Regression Suite project, but I'm not > > quite sure of the scope. Would I be choosing a good 30 or 40 > > applications that run well on wine, using wpkg to install them, and > > then test for failures? Because that would seem as though I am only > > doing installer testing, instead of actual application testing. > > That would be fine for starters. > > > I > > would also like to do some sort of automated regression testing for > > actual features you can easily test, if that would be possible. > > That would be icing on the cake. > > Application testing is insanely difficult. Even installer testing > is difficult to actually deliver. I would prefer that you aim > to get a simple run-this-script-and-it-tests-N-installers > script working and in the wine developers' hot little > hands ASAP before you get fancy and try to make > it test more than just installs. Because essentially > all efforts to do that in the past have failed. > > Make sense? > > FWIW, here's my first try at it from long ago. It's a minimal little > script that just tests one app's installer. I would prefer you > start with something this simple. > http://www.winehq.org/pipermail/wine-devel/2006-July/049913.html > Also, maybe you could make some use of Lei's yawt script, > http://code.google.com/p/yawt/ > It's kind of overkill, but it takes care of comparing registry keys and files > created by the installer. > - Dan > > Yeah, I was unaware of how difficult it would be, although now that I put on my programmers cap, I can see how it would be really difficult to do so. In that case, I would still like to do a regression test for installations to help out the wine project.

1 0

re: Google Summer of Code Test Suite project
by Dan Kegel 19 Mar '08

19 Mar '08

On Wed, Mar 19, 2008 at 3:01 PM, Corey McClymonds <galeru at gmail.com> wrote: > I would like to work on the Regression Suite project, but I'm not > quite sure of the scope. Would I be choosing a good 30 or 40 > applications that run well on wine, using wpkg to install them, and > then test for failures? Because that would seem as though I am only > doing installer testing, instead of actual application testing. That would be fine for starters. > I > would also like to do some sort of automated regression testing for > actual features you can easily test, if that would be possible. That would be icing on the cake. Application testing is insanely difficult. Even installer testing is difficult to actually deliver. I would prefer that you aim to get a simple run-this-script-and-it-tests-N-installers script working and in the wine developers' hot little hands ASAP before you get fancy and try to make it test more than just installs. Because essentially all efforts to do that in the past have failed. Make sense? FWIW, here's my first try at it from long ago. It's a minimal little script that just tests one app's installer. I would prefer you start with something this simple. http://www.winehq.org/pipermail/wine-devel/2006-July/049913.html Also, maybe you could make some use of Lei's yawt script, http://code.google.com/p/yawt/ It's kind of overkill, but it takes care of comparing registry keys and files created by the installer. - Dan

1 0

Re: winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 4)
by Vitaliy Margolen 19 Mar '08

19 Mar '08

Vitaliy Margolen wrote: > This time with lots of tests that exposed number of other problems that > were fixed. > > I could not separate this patch into separate pieces - they all linked > together and > fixing one problem meant fixing or breaking something else. This > especially related > to the tests that test everything together as a one black box. > > There are still few problems remain that could be exposed by tightening > tests. > --- Anything wrong with this patch? Vitaliy

2 2

Summer of code and bidi
by Maarten Lankhorst 19 Mar '08

19 Mar '08

Hi Shachar, I've removed the bi-directional entry from summer of code. I don't think it is a good project because it involves a lot of changes in pretty much all wine user controls. The only way to do this would be by using the pango library to do the laying out of text, but I'm not even sure whether that is a good summer of code idea, since it would need someone already very experienced with the plumbing of wine. Maarten.

2 2

Splitting wine wiki FAQ (was: Wine wiki cleanup)
by Dan Kegel 19 Mar '08

19 Mar '08

On Wed, Mar 19, 2008 at 10:40 AM, Jim <wineforum-user(a)winehq.org> wrote: > Should we do this for the FAQ as well? I mean: > > Make a separate developer DeveloperFaq (WikiName) > > Move developer related topics from FAQ to DeveloperFAQ > > Add question to FAQ "Where is the Developer FAQ?" to FAQ. -OR- Possibly not as a FAQ question but a very visible Note at the top. "Developers see DeveloperFaq" > > A shorter FAQ may look less intimidating to lazy readers thus encouraging more readers and possibly fewer "noob" questions on the list. Sounds good to me! I'm cc'ing wine-devel; if nobody objects by Friday, go ahead and do it. - Dan

2 1

"winefix" - interesting wrapper for wine
by Dan Kegel 19 Mar '08

19 Mar '08

Tom W. found and publicized a script called "winefix" by an ubuntu forums user named "deadlydeathcone": http://digg.com/linux_unix/Winefix_improved_desktop_integration_for_Wine http://wine-review.blogspot.com/2007/10/winefix-improved-desktop-integratio… http://ubuntuforums.org/showthread.php?s=6e904c1df87d3fd1698ab5d7bbdbf664&t… It's got a bunch of interesting stuff. I wonder if we could get him to join wine-devel and start contributing to wine itself... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 2

Appdb nice urls: best way to test indexing of production data
by John Klehm 19 Mar '08

19 Mar '08

On my spring break and had some free time so I thought I'd take a shot at implementing nice urls for the appdb that DanK had suggested a while back. I have decent bit of code in place that will interpret the url http://appdb.winehq.org/app/what-you-want-here and then feed the chunks into a hash table and return the match or matches however it goes. However indexing the large amount of data in the production appdb database could take sometime so I was wanting to test it before I sent my code in. I was wondering if there was a way to download the data from the appdb? --John Klehm

3 8

SoC page insurrection! Idea details needed, please read.
by Dan Kegel 19 Mar '08

19 Mar '08

Looking at our Summer of Code ideas page, I realized it was getting dense and unruly, so I and Maarten moved it off to the side and did a simpler one; see http://wiki.winehq.org/SummerOfCode The DirectX stuff in particular could use some more detail; could the knowledgeable people flesh it out? Also each idea should probably have a sponsor the students could turn to for ideas. I've put a few obvious ones in, but it'd be nice if each one was claimed. Thanks, Dan

4 3

Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio
by Susan Cragin 19 Mar '08

19 Mar '08

But wait! There are more! Alsa people tell me they have one for Ekiga. Gnome has one, too. https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3825 http://bugzilla.gnome.org/show_bug.cgi?id=413552 I think a wiki page is a great idea, and I'll set one up later on http://ossri.harvee.org -----Original Message----- >From: Susan Cragin <susancragin(a)earthlink.net> >Sent: Mar 19, 2008 9:03 AM >To: Wine Developers <wine-devel(a)winehq.org> >Cc: Dan Kegel <dank06(a)kegel.com> >Subject: Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio > >Wine has two bugs filed for this also: >http://bugs.winehq.org/show_bug.cgi?id=10495 >http://bugs.winehq.org/show_bug.cgi?id=10910 >I am worried that everyone (WINE, ALSA, Pulse, Ubuntu) is not on the same page. Will try cross-posting bug information. >Part of the problem seems to be that the most-missed application is Skype, and some are trying to get away with blaming closed-source issues. >Tom -- I should include the link to your patch, yes, so that other developers have access to it? >Susan >Dan -- What do you think? Good idea? > >-----Original Message----- >>From: Tomas Carnecky <tom(a)dbservice.com> >>Sent: Mar 18, 2008 5:14 PM >>To: Susan Cragin <susancragin(a)earthlink.net> >>Cc: wine-devel(a)winehq.org >>Subject: Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio >> >>Susan Cragin wrote: >>> The new default pulseaudio in Hardy screws up every program that isn't gnome, delivering terrible sound. >>> https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453 >> >>Applications that use ALSA should work fine with the alsa pulse plugin - >> should. Unfortunately the plugin has a few bugs, and the developers >>(of both pulseaudio and alsa) have been unresponsive in this matter. See >> - http://www.pulseaudio.org/ticket/198 >> - https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2601 >> >>> Question -- what does WINE do with pulseaudio? >> >>Some suggested to create a native PulseAudio wine driver. That would >>yield the best results as far as the performance and reliability goes. >>Unfortunately we'll be stuck with the alsa driver for some time to come, >>so I tried to do the best to make the alsa pulse plugin to work with >>wine. I had to patch both the wine alsa driver as well as the alsa pulse >>plugin and it worked fine for my taste. >> >>I submitted the patch to wine-patches: >>http://www.winehq.org/pipermail/wine-patches/2008-February/050561.html >> >>I don't know if the relevant alsa pulse plugin patch is publicly >>available, I haven't looked at that matter in a long time. Some of the >>needed patches are probably still in my local repositories. It makes no >>sense for me to work on this anymore until the developers respond to my >>questions. >> >>> http://forum.skype.com/index.php?showtopic=112021 >> >>I heard that the skype developers are very interested in getting skype >>working with pulseaudio, even helped tisting some patches. I have gotten >>skype to work with pulseaudio, I think if you apply the second patch >>attached to alsa bug #2601 skype will work. I haven't looked at the code >>since because apparently nobody from the alsa team is interested in >>fixing the bug. >> >>tom > > > > >

1 0

Re: wine.inf: Add "ShowMenuDelay" value
by Anatoly Lyutin 19 Mar '08

19 Mar '08

Anatoly Lyutin wrote: > Changelog: > Add "ShowMenuDelay" value Ooooops! Right changelog: Changelog: Add "MenuShowDelay" value. -- Best regards Anatoly Lyutin.

1 0

Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio
by Susan Cragin 19 Mar '08

19 Mar '08

Wine has two bugs filed for this also: http://bugs.winehq.org/show_bug.cgi?id=10495 http://bugs.winehq.org/show_bug.cgi?id=10910 I am worried that everyone (WINE, ALSA, Pulse, Ubuntu) is not on the same page. Will try cross-posting bug information. Part of the problem seems to be that the most-missed application is Skype, and some are trying to get away with blaming closed-source issues. Tom -- I should include the link to your patch, yes, so that other developers have access to it? Susan Dan -- What do you think? Good idea? -----Original Message----- >From: Tomas Carnecky <tom(a)dbservice.com> >Sent: Mar 18, 2008 5:14 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio > >Susan Cragin wrote: >> The new default pulseaudio in Hardy screws up every program that isn't gnome, delivering terrible sound. >> https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453 > >Applications that use ALSA should work fine with the alsa pulse plugin - > should. Unfortunately the plugin has a few bugs, and the developers >(of both pulseaudio and alsa) have been unresponsive in this matter. See > - http://www.pulseaudio.org/ticket/198 > - https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2601 > >> Question -- what does WINE do with pulseaudio? > >Some suggested to create a native PulseAudio wine driver. That would >yield the best results as far as the performance and reliability goes. >Unfortunately we'll be stuck with the alsa driver for some time to come, >so I tried to do the best to make the alsa pulse plugin to work with >wine. I had to patch both the wine alsa driver as well as the alsa pulse >plugin and it worked fine for my taste. > >I submitted the patch to wine-patches: >http://www.winehq.org/pipermail/wine-patches/2008-February/050561.html > >I don't know if the relevant alsa pulse plugin patch is publicly >available, I haven't looked at that matter in a long time. Some of the >needed patches are probably still in my local repositories. It makes no >sense for me to work on this anymore until the developers respond to my >questions. > >> http://forum.skype.com/index.php?showtopic=112021 > >I heard that the skype developers are very interested in getting skype >working with pulseaudio, even helped tisting some patches. I have gotten >skype to work with pulseaudio, I think if you apply the second patch >attached to alsa bug #2601 skype will work. I haven't looked at the code >since because apparently nobody from the alsa team is interested in >fixing the bug. > >tom

3 2

Alexandre Julliard : winex11: Fix bug report address
by Groeschel, Volker 19 Mar '08

19 Mar '08

The Patch points to wine-cvs. Shouldn't it point to wine-devel.

5 11

Re: Maarten Lankhorst : winmm: Fix midi deadlock by not holding lock on release .
by Ken Thomases 19 Mar '08

19 Mar '08

This has a whiff of the double-checked locking anti-pattern. I can't see a way where it would really bite us in this case, but that anti- pattern has several subtleties. So, I just wanted to prompt people to double-check it (pun acknowledged). Cheers, Ken On Mar 18, 2008, at 7:44 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 15907b5035ea7f03b369a0463ab1f6ac2b24704e > URL: http://source.winehq.org/git/wine.git/?a=commit;h=15907b5035ea7f03b369a0463… > > Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > Date: Mon Mar 17 13:15:42 2008 -0700 > > winmm: Fix midi deadlock by not holding lock on release. > > --- > > dlls/winmm/mci.c | 22 ++++++++++++++-------- > 1 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/dlls/winmm/mci.c b/dlls/winmm/mci.c > index b7b5ac2..c792d18 100644 > --- a/dlls/winmm/mci.c > +++ b/dlls/winmm/mci.c > @@ -1767,19 +1767,25 @@ static DWORD MCI_Close(UINT16 wDevID, DWORD > dwParam, LPMCI_GENERIC_PARMS lpParms > TRACE("(%04x, %08X, %p)\n", wDevID, dwParam, lpParms); > > if (wDevID == MCI_ALL_DEVICE_ID) { > - LPWINE_MCIDRIVER next; > - > - EnterCriticalSection(&WINMM_cs); > /* FIXME: shall I notify once after all is done, or for > * each of the open drivers ? if the latest, which notif > * to return when only one fails ? > */ > - for (wmd = MciDrivers; wmd; ) { > - next = wmd->lpNext; > - MCI_Close(wmd->wDeviceID, dwParam, lpParms); > - wmd = next; > + while (MciDrivers) { > + /* Retrieve the device ID under lock, but send the > message without, > + * the driver might be calling some winmm functions > from another > + * thread before being fully stopped. > + */ > + EnterCriticalSection(&WINMM_cs); > + if (!MciDrivers) > + { > + LeaveCriticalSection(&WINMM_cs); > + break; > + } > + wDevID = MciDrivers->wDeviceID; > + LeaveCriticalSection(&WINMM_cs); > + MCI_Close(wDevID, dwParam, lpParms); > } > - LeaveCriticalSection(&WINMM_cs); > return 0; > } > > > >

1 0

Alexandre Julliard : winex11: Fix bug report address
by Groeschel, Volker 19 Mar '08

19 Mar '08

The Patch points to wine-cvs. Shouldn't it point to wine-devel.

1 0

Re: [Try 2] A nicer icon for msiexec
by Alexandre Julliard 19 Mar '08

19 Mar '08

Hervÿffffe9 Chanal <chanal_herve(a)yahoo.fr> writes: > It's a nicer icon for msiexec. From the last submit, several size are > now included in the icon file. The icons are generated using a script > i submitted to wine-patch a long time ago. The svg source is not in > this patch. I can submit it too. Yes, we should include the svg source, and make sure we can rebuild the icons from it. Last time I tried to do that using your script I didn't get good results, the image was all mangled, so we need to look into this further. Can you please resubmit the svg? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] qmgr: Add a stub implementation of IBackgroundCopyJob2.
by Alexandre Julliard 19 Mar '08

19 Mar '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -93,6 +93,10 @@ typedef struct > const IClassFactoryVtbl *lpVtbl; > } ClassFactoryImpl; > > +/* This makes it easier to upgrade to IBackgroundCopyJob3, IBackgroundCopyJob4, > + and whatever else MS decides to tack on later. */ > +typedef IBackgroundCopyJob2 BITS_IBackgroundCopyJob; Please don't do that, vtable entries should use the correct types, otherwise it will be very confusing. You'll just have to rename them when switching to a newer version of the interface. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Handle arbitrary length composed input.
by Marcus Meissner 19 Mar '08

19 Mar '08

On Wed, Mar 19, 2008 at 06:16:36PM +0900, Kusanagi Kouichi wrote: > Fix bug #9838. http://bugs.winehq.org/show_bug.cgi?id=9838 > --- > dlls/winex11.drv/keyboard.c | 25 ++++++++++++++++--------- > dlls/winex11.drv/xim.c | 16 ++++++++++------ > 2 files changed, 26 insertions(+), 15 deletions(-) > > diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/keyboard.c > index 33640db..386a471 100644 > --- a/dlls/winex11.drv/keyboard.c > +++ b/dlls/winex11.drv/keyboard.c > @@ -1365,22 +1365,29 @@ void X11DRV_KeyEvent( HWND hwnd, XEvent *xev ) > wine_tsx11_lock(); > /* Clients should pass only KeyPress events to XmbLookupString */ > if (xic && event->type == KeyPress) > + { > ascii_chars = XmbLookupString(xic, event, Str, sizeof(Str), &keysym, &status); > + > + if (status == XBufferOverflow) > + { > + char buf[ascii_chars]; You should not use dynamic sized arrays. Use HeapAlloc() to allocate them. Ciao, Marcus

1 0

Version of Windows
by Chris Teague 19 Mar '08

19 Mar '08

This is probably trivial, but I'm having a tough time figuring out the current version of Windows that Wine is mimicking. I have a situation where I need to behave differently if the version is NT (0x0500) versus when it is XP (0x0600). I see the WINVER #define, but that doesn't seem right to me since this must be a runtime variable. Can someone point me at an example of how to tell what the current version of Windows is? Thanks, Chris

4 4

cygwin runs!
by Dan Kegel 19 Mar '08

19 Mar '08

Hey! Cygwin actually installs and runs inside Wine! There are a few problems (gcc can't compile "hello, world" yet, symlinks like the one for vi don't work yet, the setup utility doesn't resize properly, and mkpasswd -l aborts), but the shell starts up fine and vim runs inside it! Hats off to the Wine team! - Dan

3 2

Wine wiki cleanup
by Dan Kegel 19 Mar '08

19 Mar '08

Over time, the Wine wiki front page grew rather unwieldy, so I split the developer information off into two new pages, leaving only a simplified front page behind, mostly aimed at users. It's radically simpler. Hopefully it'll be more welcoming to new users. Comments?

2 1

Re: ntoskrnl.exe: Implement MmIsAddressValid (bug 11082)
by Dmitry Timoshkov 18 Mar '08

18 Mar '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > + len = VirtualQuery(VirtualAddress, &info, sizeof(MEMORY_BASIC_INFORMATION)); > + > + if ((len == sizeof(MEMORY_BASIC_INFORMATION)) && > + (info.Protect & (PAGE_READWRITE || PAGE_EXECUTE_READWRITE)) && > + ((info.Protect & PAGE_NOACCESS) == 0) && > + (info.Type & MEM_COMMIT)) > + { > + return TRUE; > + } Besides the already pointed out '||' vs. '|' mismatch your code doesn't handle PAGE_READONLY and others implying read-only access. Probably checking for PAGE_NOACCESS and MEM_COMMIT should be enough. -- Dmitry.

2 1

Re: ntoskrnl.exe: Implement MmIsAddressValid (bug 11082)
by Chris Robinson 18 Mar '08

18 Mar '08

On Monday 17 March 2008 04:09:20 pm Detlef Riekenberg wrote: > + (info.Protect & (PAGE_READWRITE || PAGE_EXECUTE_READWRITE)) && Did you mean | instead of || there?

2 1

Bugzilla request: add new milestone 1.2.0
by Dan Kegel 18 Mar '08

18 Mar '08

Ping. I need this so I can start deferring 1.0 bugs to 1.2. (Deferring them to 1.1 doesn't make a whole lot of sense.)

1 0

Hardy Heron -- Pulseaudio interferes with non-gnome audio
by Susan Cragin 18 Mar '08

18 Mar '08

The new default pulseaudio in Hardy screws up every program that isn't gnome, delivering terrible sound. https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453 Question -- what does WINE do with pulseaudio? http://forum.skype.com/index.php?showtopic=112021

3 2

Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio
by Susan Cragin 18 Mar '08

18 Mar '08

http://www.pulseaudio.org/ticket/198 I'm not sure it's possible to use the pulseaudio plugin. Pulse seems to think it's a wine defect. -----Original Message----- >From: Marcus Meissner <marcus(a)jet.franken.de> >Sent: Mar 18, 2008 3:15 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio > >On Tue, Mar 18, 2008 at 12:46:16PM -0400, Susan Cragin wrote: >> The new default pulseaudio in Hardy screws up every program that isn't gnome, delivering terrible sound. >> https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453 >> Question -- what does WINE do with pulseaudio? >> http://forum.skype.com/index.php?showtopic=112021 > >Just tell the pulseaudio guys to take it a notch down. > >Or use the ALSA pulseaudio wrapper plugin. > >Ciao, Marcus

1 0

Fresh valgrind errors in richedit
by Dan Kegel 18 Mar '08

18 Mar '08

Eric, could you have a look at http://kegel.com/wine/valgrind/logs-2008-03-17/vg-riched20_editor-diff.txt There are several new errors of the sort: + Conditional jump or move depends on uninitialised value(s) + at ME_SetParaFormat (para.c:400) + by ME_SetSelectionParaFormat (para.c:436) + by ME_RTFReadHook (editor.c:662) + by RTFGetToken (reader.c:417) + by RTFRead (reader.c:333) + by ME_StreamIn (editor.c:1095) + by RichEditWndProc_common (editor.c:2432) + by RichEditWndProcA (editor.c:3237) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + by call_window_proc (winproc.c:457) + by WINPROC_call_window (winproc.c:2207) + by call_window_proc (message.c:1615) + by send_message (message.c:2430) + by SendMessageA (message.c:2575) + by test_EM_SETTEXTMODE (editor.c:471) + by func_editor (editor.c:2705) + by run_test (test.h:406) + by main (test.h:455)

2 1

Translations and Wine 1.0
by Michael Stefaniuc 18 Mar '08

18 Mar '08

Hello! We should try to update the translations of Wine to other languages for 1.0. The code freeze during the release candidate time frame is perfect for this as the translations don't have to track a moving target. Somebody had scripts/a web page to check for missing translations or broken ones in the .rc files. But I seem to not enter the right search words to find any info regarding that; if somebody has a pointer please let me know. It would be nice if we could run that scripts regularly during the release candidate time. bye michael

5 6

Re: user32: Test destroying the cursor of a parent process.
by Eric Pouech 18 Mar '08

18 Mar '08

Andrew Riedi a écrit : > changelog: user32: Test destroying the cursor of a parent process. > > -- > Andrew Riedi > ------------------------------------------------------------------------ > > From 25a6a6a2eee92c4325d730ff85bd7cdf01bf2ace Mon Sep 17 00:00:00 2001 > From: Andrew Riedi <andrewriedi(a)gmail.com> > Date: Tue, 8 Jan 2008 05:03:55 -0800 > Subject: [PATCH] user32: Test destroying the cursor of a parent process. > > --- > dlls/user32/tests/cursoricon.c | 201 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 201 insertions(+), 0 deletions(-) > > diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c > index 781282c..c2beffa 100644 > --- a/dlls/user32/tests/cursoricon.c > +++ b/dlls/user32/tests/cursoricon.c > @@ -32,6 +32,205 @@ > #include "wingdi.h" > #include "winuser.h" > > +static char **test_argv; > +static int test_argc; > +static HWND child = 0; > +static HWND parent = 0; > +static HANDLE child_process; > + > +#define PROC_INIT (WM_USER+1) > + > +LRESULT CALLBACK callback_child(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + BOOL ret; > + DWORD error; > + > + switch (msg) > + { > + /* Destroy the cursor. */ > + case WM_USER+1: > + SetLastError(0xdeadbeef); > + ret = DestroyCursor((HCURSOR) lParam); > + error = GetLastError(); > + todo_wine { > + ok(!ret, "DestroyCursor on the active cursor succeeded.\n"); > + ok(error == ERROR_DESTROY_OBJECT_OF_OTHER_THREAD, > + "Last error: 0x%08x\n", error); > + } > + return TRUE; > + case WM_DESTROY: > + PostQuitMessage(0); > + return 0; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +LRESULT CALLBACK callback_parent(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + if (msg == PROC_INIT) > + { > + child = (HWND) wParam; > + return TRUE; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +static void do_child(void) > +{ > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_child; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_child"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + child = CreateWindowA("cursor_child", "cursor_child", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(child != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Let the parent know our HWND. */ > + PostMessage(parent, PROC_INIT, (WPARAM) child, 0); > + > + /* Receive messages. */ > + while ((ret = GetMessage(&msg, child, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void do_parent(void) > +{ > + char path_name[MAX_PATH]; > + PROCESS_INFORMATION info; > + STARTUPINFOA startup; > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_parent; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_parent"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + parent = CreateWindowA("cursor_parent", "cursor_parent", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(parent != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Start child process. */ > + memset(&startup, 0, sizeof(startup)); > + startup.cb = sizeof(startup); > + startup.dwFlags = STARTF_USESHOWWINDOW; > + startup.wShowWindow = SW_SHOWNORMAL; > + > + sprintf(path_name, "%s cursoricon %x", test_argv[0], (unsigned int) parent); > + ok(CreateProcessA(NULL, path_name, NULL, NULL, FALSE, 0L, NULL, NULL, &startup, &info), "CreateProcess failed.\n"); > + child_process = info.hProcess; > + > + /* Wait for child window handle. */ > + while ((child == 0) && (ret = GetMessage(&msg, parent, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void init(void) > +{ > + test_argc = winetest_get_mainargs(&test_argv); > + > + /* Child process. */ > + if (test_argc >= 3) > + { > + sscanf (test_argv[2], "%x", (unsigned int *) &parent); > + > + ok(parent != NULL, "Parent not found.\n"); > + if (parent == NULL) > + exit(1); > + > + do_child(); > + exit(0); > + } > + else > + { > + do_parent(); > + } > +} > + > +static void finish_process(void) > +{ > + DWORD exit_code; > + BOOL ret; > + > + SendMessage(child, WM_CLOSE, 0, 0); > + ok(WaitForSingleObject(child_process, 30000) == WAIT_OBJECT_0, "Child process termination failed.\n"); > + > + ret = GetExitCodeProcess(child_process, &exit_code); > + ok(ret, "GetExitCodeProcess() failed. Error: 0x%08x\n", GetLastError()); > + ok(exit_code == 0, "Exit code == %d.\n", exit_code); > +} > + > +static void test_child_process(void) > +{ > + static const BYTE bmp_bits[4096]; > + HCURSOR cursor; > + ICONINFO cursorInfo; > + UINT display_bpp; > + HDC hdc; > + > + /* Create and set a dummy cursor. */ > + hdc = GetDC(0); > + display_bpp = GetDeviceCaps(hdc, BITSPIXEL); > + ReleaseDC(0, hdc); > + > + cursorInfo.fIcon = FALSE; > + cursorInfo.xHotspot = 0; > + cursorInfo.yHotspot = 0; > + cursorInfo.hbmMask = CreateBitmap(32, 32, 1, 1, bmp_bits); > + cursorInfo.hbmColor = CreateBitmap(32, 32, 1, display_bpp, bmp_bits); > + > + cursor = CreateIconIndirect(&cursorInfo); > + ok(cursor != NULL, "CreateIconIndirect returned %p.\n", cursor); > + > + SetCursor(cursor); > + > + /* Destroy the cursor. */ > + SendMessage(child, WM_USER+1, (WPARAM) parent, (LPARAM) cursor); > + > + /* Finish the child process. */ > + finish_process(); > +} > + > static void test_CopyImage_Check(HBITMAP bitmap, UINT flags, INT copyWidth, INT copyHeight, > INT expectedWidth, INT expectedHeight, WORD expectedDepth, BOOL dibExpected) > { > @@ -471,6 +670,7 @@ static void test_DestroyCursor(void) > > START_TEST(cursoricon) > { > + init(); > test_CopyImage_Bitmap(1); > test_CopyImage_Bitmap(4); > test_CopyImage_Bitmap(8); > @@ -480,4 +680,5 @@ START_TEST(cursoricon) > test_initial_cursor(); > test_CreateIcon(); > test_DestroyCursor(); > + test_child_process(); > } > > ------------------------------------------------------------------------ > > > IMO, the ok() tests in the child process are a bad idea (they won't be counted, nor returned as errors, by the parent process) all the tests should be done in parent, see kernel32/tests/process.c for some example on how to do it properly A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

3 2

Please create 1.2.0 milestone in Bugzilla
by Dan Kegel 18 Mar '08

18 Mar '08

The 1.1.x releases will be development releases, so a 1.1.0 milestone doesn't make much sense. Please create a 1.2.0 milestone in Bugzilla. Thanks! - Dan

4 4

Which IRC room to send SoC people to?
by Dan Kegel 18 Mar '08

18 Mar '08

http://wiki.winehq.org/SummerOfCode currently sends people to #WineHQ. Should it send them to #winehackers?

4 3

Redirect http://forums.winehq.org -> http://forum.winehq.org.
by Andrew Riedi 18 Mar '08

18 Mar '08

Because many other sites have forums spelled in the plural, such as http://ubuntuforums.org and http://forums.gentoo.org, many users simply assume we will too. I would like to request a redirect from http://fourms.winehq.org to http://forum.winehq.org. Note, even one of own developers made this mistake, which I sent in a fix for at: http://article.gmane.org/gmane.comp.emulators.wine.patches/48512 . -- Andrew Riedi

2 1

Re: msi/tests: Skip the tests if we are unable to identify the user SID. This fixes crashes on Win9x.
by Paul Vriens 18 Mar '08

18 Mar '08

Francois Gouget wrote: > --- > dlls/msi/tests/source.c | 50 ++++++++++++++++++++++++++++++++++++++-------- > 1 files changed, 41 insertions(+), 9 deletions(-) > > diff --git a/dlls/msi/tests/source.c b/dlls/msi/tests/source.c > index 49e40c7..5f75159 100644 > --- a/dlls/msi/tests/source.c > +++ b/dlls/msi/tests/source.c > @@ -122,18 +122,22 @@ static void create_test_guid(LPSTR prodcode, LPSTR squashed) > WideCharToMultiByte(CP_ACP, 0, squashedW, -1, squashed, MAX_PATH, NULL, NULL); > } > > -static void get_user_sid(LPSTR *usersid) > +static int get_user_sid(LPSTR *usersid) > { > HANDLE token; > BYTE buf[1024]; > DWORD size; > PTOKEN_USER user; > + BOOL rc; > > - OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &token); > + rc=OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY, &token); > + if (!rc && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + return 0; > size = sizeof(buf); > GetTokenInformation(token, TokenUser, (void *)buf, size, &size); > user = (PTOKEN_USER)buf; > pConvertSidToStringSidA(user->User.Sid, usersid); > + return 1; > } > > static void check_reg_str(HKEY prodkey, LPCSTR name, LPCSTR expected, BOOL bcase, DWORD line) > @@ -186,7 +190,11 @@ static void test_MsiSourceListGetInfo(void) > } > > create_test_guid(prodcode, prod_squashed); > - get_user_sid(&usersid); > + if (!get_user_sid(&usersid)) > + { > + skip("User SID not available -> skipping MsiSourceListGetInfoA tests\n"); > + return; > + } > Couldn't we just check for pConvertSidToStringSidA like we do in the msi.c tests (line 6039)? -- Cheers, Paul.

1 0

Re: [1/22] WineD3D: Add GL_ATI_fragment_shader
by Alexandre Julliard 18 Mar '08

18 Mar '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > Note that the extension is disabled for now. This allows a bottom-up > contruction of the GL_ATI_fragment_shader replacement pipeline in the > code with separate patches, and activating it at the end when it is at > the same feature level as the existing ARB_texture_env_combine code it > can be enabled at once, thus avoiding additional troubles when running > regression tests. It may avoid trouble, but it also makes regression testing useless, since all problems with this code will point to the patch that enables it. It's not a good idea to add code without making use of it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: (X11 Series 2/3) Fix handling of non-default visuals
by Alexandre Julliard 18 Mar '08

18 Mar '08

Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> writes: > @@ -144,7 +170,7 @@ BOOL X11DRV_CreateDC( HDC hdc, X11DRV_PDEVICE **pdev, LPCWSTR driver, LPCWSTR de > else > { > physDev->bitmap = NULL; > - physDev->drawable = root_window; > + physDev->drawable = template_window; > physDev->depth = screen_depth; > physDev->drawable_rect = virtual_screen_rect; > SetRect( &physDev->dc_rect, 0, 0, virtual_screen_rect.right - virtual_screen_rect.left, This won't work, a screen DC has to be able to paint on the root window. I'm afraid that supporting different depths properly is pretty complicated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 1/6 WineD3D: CheckDeviceFormat rewrite
by Stefan Dösinger 18 Mar '08

18 Mar '08

Am Montag, 17. März 2008 20:22:58 schrieb Roderick Colenbrander: > Hi, > > This patch puts legacy bump mapping in its own function. Battlefield 1942 is broken for me after these patches, apparently because D3DFMT_R8G8B8 is enabled again. As far as I can see this is due to the early if(!Usage) return in the texture resource check, the code never reaches the if condition that disables R8G8B8. Is this early return needed at all? It seems confusing to me and is only going to cause breakage similarly to the old code. The old code enabled R8G8B8 for d3d7, but I think you can remove that and keep the format disabled altogether. As far as I can see Windows does not support it in ddraw either, and enabling it for d3d7 but not d3d8 wouldn't make sense. By the way, I noticed(a bit late) that the patches from yesterday broke depth stencil selection for me. These patches fix this problem again, but I'm afraid it will cause some issues for regression testing.

2 3

Proposal for debugging improvement
by tony.wasserka＠freenet.de 18 Mar '08

18 Mar '08

Hi, When I was trying to find out how the native d3dx9_36.dll handles ID3DXRenderToSurface->BeginScene() with WINEDEBUG="+d3d9,heap" I had the problem that I had to find out what functions are called within the dll and what functions are called by the d3d9 functions (and thus are irrelevant for d3dx9). For example this is what I got for BeginScene: (fixmes were disabled) > trace:d3d9:IDirect3DSurface9Impl_GetDesc (0xc3b428) Relay > trace:d3d9:IDirect3DDevice9Impl_CreateDepthStencilSurface Relay > trace:d3d9:IDirect3DDevice9Impl_CreateSurface (0x1264c8) Relay > trace:heap:RtlAllocateHeap (0x110000,0000000a,0000001c): returning 0xc3b450 > trace:d3d9:IDirect3DDevice9Impl_CreateSurface (0x1264c8) : w(256) h(256) fmt(0) surf@(nil) > trace:heap:RtlAllocateHeap (0x110000,0000000a,00000114): returning 0x1b81e0 > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 4 > trace:d3d9:IDirect3DDevice9Impl_CreateSurface (0x1264c8) : Created surface 0xc3b450 > trace:d3d9:IDirect3DDevice9Impl_BeginStateBlock (0x1264c8) Relay > trace:heap:RtlAllocateHeap (0x110000,0000000a,0000c994): returning 0xd1df30 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000006a0): returning 0xc3b820 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000001a8): returning 0xa7b7e8 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000006b0): returning 0x1b8300 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000001ac): returning 0xd2a8d0 > trace:heap:RtlAllocateHeap (0x110000,00000002,000001ac): returning 0xc3bec8 > trace:heap:RtlAllocateHeap (0x110000,00000002,000001a8): returning 0xa7b998 > trace:d3d9:IDirect3DDevice9Impl_SetViewport (0x1264c8)0xc3b384 Relay > trace:d3d9:IDirect3DDevice9Impl_EndStateBlock (0x1264c8) Relay > trace:heap:RtlAllocateHeap (0x110000,0000000a,00000010): returning 0xd1dec8 > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 5 > trace:d3d9:IDirect3DDevice9Impl_EndStateBlock (0x1264c8)Returning 0xd1dec8 0xd1df30 > trace:d3d9:IDirect3DStateBlock9Impl_Capture (0xd1dec8) Relay > trace:d3d9:IDirect3DDevice9Impl_GetRenderTarget (0x1264c8) Relay > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d20) > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 6 > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d20) : AddRef from 0 > trace:d3d9:IDirect3DDevice9Impl_GetDepthStencilSurface (0x1264c8) Relay > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d48) > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 7 > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d48) : AddRef from 0 > trace:d3d9:IDirect3DDevice9Impl_SetRenderTarget (0x1264c8) Relay > trace:heap:RtlFreeHeap (0x110000,00000002,0x178110): returning TRUE > trace:d3d9:IDirect3DDevice9Impl_SetDepthStencilSurface (0x1264c8) Relay > trace:d3d9:IDirect3DDevice9Impl_SetViewport (0x1264c8)0xc3b384 Relay > trace:d3d9:IDirect3DDevice9Impl_BeginScene (0x1264c8) Relay > trace:d3d9:IDirect3DSurface9Impl_AddRef (0xc3b428) > trace:d3d9:IDirect3DSurface9Impl_AddRef (0xc3b428) : Forwarding to 0xa7b6e8 > trace:d3d9:IDirect3DTexture9Impl_AddRef (0xa7b6e8) : AddRef from 2 > trace:heap:RtlAllocateHeap (0x110000,00000002,0000001d): returning 0xc3b478 However, after distinguishing the direct and the indirect function calls, I would've found an output like this much better: > trace:d3d9:IDirect3DSurface9Impl_GetDesc (0xc3b428) Relay > trace:d3d9:IDirect3DDevice9Impl_CreateDepthStencilSurface Relay > trace:d3d9:IDirect3DDevice9Impl_CreateSurface (0x1264c8) Relay > trace:heap:RtlAllocateHeap (0x110000,0000000a,0000001c): returning 0xc3b450 > trace:d3d9:IDirect3DDevice9Impl_CreateSurface (0x1264c8) : w(256) h(256) fmt(0) surf@(nil) > trace:heap:RtlAllocateHeap (0x110000,0000000a,00000114): returning 0x1b81e0 > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 4 > trace:d3d9:IDirect3DDevice9Impl_CreateSurface (0x1264c8) : Created surface 0xc3b450 > trace:d3d9:IDirect3DDevice9Impl_BeginStateBlock (0x1264c8) Relay > trace:heap:RtlAllocateHeap (0x110000,0000000a,0000c994): returning 0xd1df30 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000006a0): returning 0xc3b820 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000001a8): returning 0xa7b7e8 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000006b0): returning 0x1b8300 > trace:heap:RtlAllocateHeap (0x110000,0000000a,000001ac): returning 0xd2a8d0 > trace:heap:RtlAllocateHeap (0x110000,00000002,000001ac): returning 0xc3bec8 > trace:heap:RtlAllocateHeap (0x110000,00000002,000001a8): returning 0xa7b998 > trace:d3d9:IDirect3DDevice9Impl_SetViewport (0x1264c8)0xc3b384 Relay > trace:d3d9:IDirect3DDevice9Impl_EndStateBlock (0x1264c8) Relay > trace:heap:RtlAllocateHeap (0x110000,0000000a,00000010): returning 0xd1dec8 > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 5 > trace:d3d9:IDirect3DDevice9Impl_EndStateBlock (0x1264c8)Returning 0xd1dec8 0xd1df30 > trace:d3d9:IDirect3DStateBlock9Impl_Capture (0xd1dec8) Relay > trace:d3d9:IDirect3DDevice9Impl_GetRenderTarget (0x1264c8) Relay > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d20) > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 6 > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d20) : AddRef from 0 > trace:d3d9:IDirect3DDevice9Impl_GetRenderTarget (0x1264c8) Finished > trace:d3d9:IDirect3DDevice9Impl_GetDepthStencilSurface (0x1264c8) Relay > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d48) > trace:d3d9:IDirect3DDevice9Impl_AddRef (0x1264c8) : AddRef from 7 > trace:d3d9:IDirect3DSurface9Impl_AddRef (0x177d48) : AddRef from 0 > trace:d3d9:IDirect3DDevice9Impl_SetRenderTarget (0x1264c8) Relay > trace:heap:RtlFreeHeap (0x110000,00000002,0x178110): returning TRUE > trace:d3d9:IDirect3DDevice9Impl_SetDepthStencilSurface (0x1264c8) Relay > trace:d3d9:IDirect3DDevice9Impl_SetViewport (0x1264c8)0xc3b384 Relay > trace:d3d9:IDirect3DDevice9Impl_BeginScene (0x1264c8) Relay > trace:d3d9:IDirect3DSurface9Impl_AddRef (0xc3b428) > trace:d3d9:IDirect3DSurface9Impl_AddRef (0xc3b428) : Forwarding to 0xa7b6e8 > trace:d3d9:IDirect3DTexture9Impl_AddRef (0xa7b6e8) : AddRef from 2 > trace:heap:RtlAllocateHeap (0x110000,00000002,0000001d): returning 0xc3b478 I have to admit that I have yet no real idea if this distinction is correct, but I hope it makes clear what I want to approach. All traces that have been made inside of a nested function call are written a bit more right, so that one can easily see that it hasn't been called directly by an application. A suggestion for how to realize this system would be to 1) add a variable that counts how much right a debug output should be 2) modify the debug macros TRACE, FIXME, etc... in such a way that they recognize this variable 3) replace all TRACE("(%p): relayn", This) calls, which are usually at the beginning of a function, with a new macro, let's say NEWTRACE, which does exactly the same but also increments our tab (or space) counter by one. 4) make sure that there's also an ENDTRACE macro at the end of each function that decrements the counter again. At least I would find this idea very useful, so feel free to leave a comment about either the thing itself or my implementation idea of it. Best regards, Tony PS: I know that there would be several workarounds that would help me in this case, but I'd like this proposal to get into the official tree if others like it, too. PPS: We could also add a WINEDEBUG option that filters out any indirect function calls from e.g. the 4th level to make things more overviewable, however, it's just another idea, too ;-)

2 1

Re: 6/6 WineD3D: CheckDeviceFormat rewrite
by Alexandre Julliard 18 Mar '08

18 Mar '08

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > This patch removes some code which isn't needed anymore. All of this is now handled inside the resource type checks. It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:2555: Test failed: quad 1 has color 00000000, expected 0x00FFFF00 visual.c:2559: Test failed: quad 3 has color 00000000, expected 0x0000FF00 visual.c:2642: Test failed: quad 1 has color 00000000, expected 0x00FF0000 visual.c:2649: Test failed: quad 4 has color 00000000, expected 0x0033cc00 wine: Unhandled page fault on write access to 0x05594884 at address 0x601cdcb6 (thread 0036), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

wined3d: Check with "&& FALSE"
by Paul Vriens 18 Mar '08

18 Mar '08

Hi, In the past we had some occurrences of comparisons with NULL flags. I had this check run again today and it came back with: ./dlls/wined3d/arb_program_shader.c:316: if(max_constantsF + extra_constants_needed + 1 < GL_LIMITS(pshader_constantsF) && FALSE) { Is this line correct? Doesn't this alway return FALSE? -- Cheers, Paul.

3 5

Re: user32: Add test_CreateIconFromResourceEx().
by Dmitry Timoshkov 18 Mar '08

18 Mar '08

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > changelog: user32: Add test_CreateIconFromResourceEx(). What this patch is supposed to test? Just that CreateIconFromResourceEx returns a valid icon handle? What about the resulting icon contents? What about cases when CreateIconFromResourceEx should fail? -- Dmitry.

2 2

Google Summer of Code 2008 is on!
by Maarten Lankhorst 18 Mar '08

18 Mar '08

Hi all, Wine has been officially accepted as mentoring organisation for 2008!!!!!!!! Just thought I'd share. I hope this will be the best summer of code for wine yet! Cheers, Maarten.

1 1

Re: [19/22] WineD3D: Enable V8U8 for legacy bump mapping with ati extensions
by Stefan Dösinger 18 Mar '08

18 Mar '08

Am Montag, 17. März 2008 19:46:45 schrieb Stefan Dösinger: > Here is an updated patch that takes Roderick's recent changes into account Yet another patch, it takes Rodericks patches from today into account. Feel free to apply whatever patch suits better. If none of them are applied I will resend all the patches when Roderick is done with his CheckDeviceFormat rewite

1 0

appdb request: "Browse Regressions"
by Dan Kegel 18 Mar '08

18 Mar '08

The nice reports in recent wwn's showing changes in appdb ratings make me want to use the appdb itself to see which apps have recently fallen in rating. Following past appdb practice, one would implement that by adding a new "Browse Regressions" menu item on the left, below Browse Apps, Browse Newest Apps, Downloadable Apps, and Browse Apps by Rating. I expect this will become increasingly useful as we approach 1.0. How hard would it be? (Also, it might be nice to have an "advanced browse" that let you filter and sort by date, rating, and rating change. Once that works well, we might not need all those other specific browse commands...) - Dan

5 6

Re: services.exe/advapi32[7/7]: move GetServiceDisplayName to services.exe and implement GetServiceKeyName
by Robert Shearman 17 Mar '08

17 Mar '08

Mikołaj Zalewski wrote: > + /* Windows function 0x14 must be using a different prototype - not compatible */ > + DWORD svcctl_GetServiceDisplayNameW( > + SvcCtlRpcHandle rpc_handle, > + [in] POLICY_HANDLE *hSCManager, > + [in] LPCWSTR lpServiceName, > + [in,out,size_is(cchBufSize)] WCHAR lpBuffer[], > + [in] DWORD cchBufSize, > + [out] DWORD *cchLength); > + > + /* Windows function 0x15 must be using a different prototype - not compatible */ > + DWORD svcctl_GetServiceKeyNameW( > + SvcCtlRpcHandle rpc_handle, > + [in] POLICY_HANDLE *hSCManager, > + [in] LPCWSTR lpServiceDisplayName, > + [in,out,size_is(cchBufSize)] WCHAR lpBuffer[], > + [in] DWORD cchBufSize, > + [out] DWORD *cchLength); > } > The lpBuffer parameter should be out-only instead of in and out. I believe this will make the prototype compatible. -- Rob Shearman

1 0

Re: services.exe/advapi32[5/7]: Move QueryServiceConfig to services.exe
by Robert Shearman 17 Mar '08

17 Mar '08

In the next patch you've found a problem: Mikołaj Zalewski wrote: > +#if 0 /* for some reason (rpcrt4 bug?) QueryServiceConfig for a non-NULL lpLoadOrder crashes Wine */ > The issue is to do with this code: > LPQUERY_SERVICE_CONFIGW lpServiceConfig, > DWORD cbBufSize, LPDWORD pcbBytesNeeded) > { > - WCHAR str_buffer[ MAX_PATH ]; > - LONG r; > - DWORD type, val, sz, total, n; > - LPBYTE p; > - HKEY hKey; > + QUERY_SERVICE_CONFIGW config; > struct sc_service *hsvc; > + DWORD total; > + DWORD err; > + BYTE *bufpos; > > TRACE("%p %p %d %p\n", hService, lpServiceConfig, > cbBufSize, pcbBytesNeeded); > @@ -1886,58 +1908,21 @@ QueryServiceConfigW( SC_HANDLE hService, > SetLastError( ERROR_INVALID_HANDLE ); > return FALSE; > } > - hKey = hsvc->hkey; > - > - /* TODO: Check which members are mandatory and what the registry types > - * should be. This should of course also be tested when a service is > - * created. > - */ > - > - /* calculate the size required first */ > - total = sizeof (QUERY_SERVICE_CONFIGW); > > - sz = sizeof(str_buffer); > - r = RegQueryValueExW( hKey, szImagePath, 0, &type, (LPBYTE) str_buffer, &sz ); > - if( ( r == ERROR_SUCCESS ) && ( type == REG_SZ || type == REG_EXPAND_SZ ) ) > + if ((err = svcctl_QueryServiceConfigW(hsvc->hdr.rpc_handle, &hsvc->hdr.server_handle, &config)) != 0) > The problem is that QUERY_SERVICE_CONFIGW contains pointers and the DCE/RPC programming model ensures that non-NULL pointers that are being unmarshalled into are used (presumably to reduce memory allocations). So the issue here is that you're not initialising config before passing it into svcctl_QueryServiceConfigW and it is blowing up just by chance on the pointer occupying the lpLoadOrderGroup; it could just as well have been lpBinaryName, lpServiceStartName or lpDisplayName. > + > + /* Windows function 0x11 must be using a different prototype - not compatible */ > + /* Robert Shearman thinks there should be a byte_count attribute but (as of Sep 2007) > + * this isn't supported by widl nor by rpcrt4 */ > + DWORD svcctl_QueryServiceConfigW( > + SvcCtlRpcHandle rpc_handle, > + [in] POLICY_HANDLE *handle, > + [out] QUERY_SERVICE_CONFIGW *config); > + > } > The byte_count attribute is officially deprecated by Microsoft and it's not part of the DCE/RPC standard, plus you've already done the work and it's wire compatible (I think) without the attribute, so you can remove the comment about it. -- Rob Shearman

1 0

Re: services.exe/advapi32[3/7]: start a local RPC server
by Robert Shearman 17 Mar '08

17 Mar '08

Mikołaj Zalewski wrote: > @@ -231,6 +247,101 @@ static inline LPWSTR SERV_dupmulti(LPCSTR str) > } > > /****************************************************************************** > + * RPC connection with servies.exe > + */ > + > +static BOOL check_services_exe() > +{ > Put "void" in the brackets here and in many other places. > +static SvcCtlRpcHandle connect_to_server(LPCWSTR server) > +{ > + WCHAR transport[] = SVCCTL_TRANSPORT; > + WCHAR endpoint[] = SVCCTL_ENDPOINT; > + LPWSTR server_copy = NULL; > + RPC_WSTR binding_str; > + RPC_STATUS status; > + SvcCtlRpcHandle rpc_handle; > + > + /* unlike Windows we start services.exe on demand. We start it always as > + * checking if this is our address can be tricky */ > + if (!check_services_exe()) > + return NULL; > + > + if (server) /* parameters of RpcStringBindingComposeW are not const */ > + { > + server_copy = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*(strlenW(server) + 1)); > + strcpyW(server_copy, server); > + } > RpcStringBindingComposeW doesn't change server if you pass it in, so there is no need to make a copy. > + status = RpcStringBindingComposeW(NULL, transport, server_copy, endpoint, NULL, &binding_str); > + HeapFree(GetProcessHeap(), 0, server_copy); > + if (status != RPC_S_OK) > + { > + ERR("RpcStringBindingComposeW failed (%d)\n", (DWORD)status); > + return NULL; > + } > > diff --git a/include/wine/svcctl.idl b/include/wine/svcctl.idl > new file mode 100644 > index 0000000..fefd12f > --- /dev/null > +++ b/include/wine/svcctl.idl > @@ -0,0 +1,68 @@ > +/* > + * svcctl interface definitions - exported by services.exe to access the > + * services database > + * > + * Copyright 2007 Google (Mikolaj Zalewski) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +import "wtypes.idl"; > + > +/* > + * some defined for the C code > + */ > +cpp_quote("#define SVCCTL_TRANSPORT {'n','c','a','c','n','_','n','p',0}"); > +cpp_quote("#define SVCCTL_ENDPOINT {'\\\\','p','i','p','e','\\\\','s','v','c','c','t','l',0}"); > + > +/* Not the Windows event name - if needed the true one can be found in Inside Windows */ > +cpp_quote("#define SVCCTL_STARTED_EVENT (const WCHAR[]){'_','_','w','i','n','e','_','S','v','c','c','t','l','S','t','a','r','t','e','d',0}"); > + > + > +/* Based on the Samba IDL. Some functions are compatible with Windows but some > + * aren't and many are missing (thus function numbers are different) so we > + * don't use the Windows uuid which is 367abb81-9844-35f1-ad32-98f038001003 . > + */ > +[ uuid(78e2d9e8-d2a8-40d8-9bbe-7328cc5a9c32), > + version(2.0), > + pointer_default(unique), > + endpoint("ncacn_np:[\\pipe\\svcctl]"), > + helpstring("Service Control") > +] interface svcctl > +{ > + typedef handle_t SvcCtlRpcHandle; > + > + typedef struct _POLICY_HANDLE > + { > + DWORD dwHandleType; > + GUID uuid; > + } POLICY_HANDLE; > There's no need to use Samba's concept of "POLICY_HANDLE". We fully support the DCE/RPC context_handle type which is what this actually is. You can find out more about how to use context handles here: http://msdn2.microsoft.com/en-us/library/aa373605(VS.85).aspx > + > + /* Compatible with Windows function 0x00 */ > + DWORD svcctl_CloseServiceHandle( > + [in] SvcCtlRpcHandle rpc_handle, > + [in,out] POLICY_HANDLE *handle > + ); > There's no need for the rpc_handle here once you make the second parameter into a context handle. > + > + /* Compatible with Windows function 0x0f */ > + DWORD svcctl_OpenSCManagerW( > + SvcCtlRpcHandle rpc_handle, > + [in,unique] LPCWSTR MachineName, > + [in,unique] LPCWSTR DatabaseName, > + [in] DWORD dwAccessMask, > + [out] POLICY_HANDLE *handle > + ); > + > +} > -- Rob Shearman

1 0

re: improve winetricks dotnet 1.1
by Dan Kegel 17 Mar '08

17 Mar '08

Louis wrote: > Hi, i wonder if it would be possible to improve > winetricks dotnet 1.1, so that it's actually able to run >.net-1.1 applications. Currently it only installs the framework, > but due to bugs the apps don't run. Atm i use pretty worthless > script below to get them running.. I'm kind of hoping James implements the missing bits in msi soon. James, think that will happen soon enough that there's no need to update winetricks? > Note, the dlls gdiplus and mscoree should be set to native only, not (native, builtin), so override_dll should look tiny bit different then in winetricks. Ah, good point. - Dan

4 7

UrlCanonicalize patch I submitted
by John Morris 17 Mar '08

17 Mar '08

Hi, Last week I submitted a patch to correct the behavior of the UrlCanonicalize{W,A} functions. I found that "Stylus Studio 2007" had problems opening files that had a space in the path name. Tracing through the code, I found that the UrlCanonicalizeW function was not removing the "%20" escaped space when the URL_UNESCAPE bit was set in the flags parameter. I wrote a small program that set the flags like stylus studio was doing and ran it on both wine and windows, and found that wine definitely didn't handle it the same as windows. I made a small change to dlls/shlwapi/url.c, as well as added a test case to dlls/shlwapi/tests/url.c. With that change I got the same result with my program on both windows and wine. This is only my second patch to wine, so please feel free to give me any feedback, and let me know if there is anything that would be deemed incorrect about the way I did this. Many Thanks, John Morris

1 0

Re: msi: Skip the endlines test if the table fails on import
by Paul Vriens 17 Mar '08

17 Mar '08

James Hawkins wrote: > Hi, > > Fixes 33 test failures on win9x. > > Changelog: > * Skip the endlines test if the table fails on import. > > dlls/msi/tests/db.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > But shouldn't the ok-call stay and be moved after the if? Or is there not much extra information when add_table_to_db fails? -- Cheers, Paul.

2 1

Running services in WINE?
by Christopher 17 Mar '08

17 Mar '08

I've been trying to get MozyHome working on WINE, and have made a little progress. However, it seems that the service which Mozy uses won't start. Searching a bit I found a thread from a year ago stating that services don't work in WINE, but that it was being worked on. Are services implemented in WINE now, or if they're not is someone working on it who I could help out? Christopher Berner

6 12

services.exe: series of patches - empty attachments.
by Kirill K. Smirnov 17 Mar '08

17 Mar '08

Hi, Empty patches are attached to every e-mail in this series. Size: 0 bytes http://www.winehq.org/pipermail/wine-patches/2008-March/051638.html http://www.winehq.org/pipermail/wine-patches/2008-March/051651.html http://www.winehq.org/pipermail/wine-patches/2008-March/051641.html ... -- Kirill

2 1

Re: [Tools 6/6] winetest: Issue a better description than '.' for the special failure modes. Write them as a note so they stand out better.
by Paul Vriens 17 Mar '08

17 Mar '08

Francois Gouget wrote: > --- > winetest/gather | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/winetest/gather b/winetest/gather > index b502345..ee49f4a 100755 > --- a/winetest/gather > +++ b/winetest/gather > @@ -329,21 +329,21 @@ sub singletest($$$) { > EOF > } elsif ($count eq "winetest crash") { > print OUT <<"EOF"; > - <td class="result fail also-skip"><a > + <td class="note"><a > title="Test did not run as winetest crashed" > - >.</a></td> > + >winetest</a></td> > EOF > } elsif ($count eq "file limit") { > print OUT <<"EOF"; > - <td class="result fail also-skip"><a > + <td class="note"><a > title="Test is missing because of a partial report file" > - >.</a></td> > + >truncated</a></td> > EOF > } elsif ($count eq "test missing") { > print OUT <<"EOF"; > - <td class="result fail also-skip"><a > + <td class="note"><a > title="Test did not run for an unknown reason" > - >.</a></td> > + >not run</a></td> > EOF > } else { > my $class = $error?"fail":$todo?"todo":"pass"; Hi Francois, We currently have these single '.' also when there are multiple failures for an OS that are actually the same failures. For example the missing dll's. There are several dll's missing on win95 and win98 so it would be nice to have this reflected in the group piece of the page. I think green with a blue border looks much nicer than the single '.' we are currently having. Other thoughts? The new page layout is now present and I must say it looks better although Wine looks a bit worse now because all the green is gone :-). -- Cheers, Paul.

2 1

First wine cpl available to test - the regional settings
by pure_evil＠mail.bg 17 Mar '08

17 Mar '08

I made the first cpl (intl.cpl), and, the actual executable that goes with it. http://www.keepandshare.com/doc/view.php?id=460541&da=y that should link to a file called intl_wine.zip. It contains 2 things: intl.cpl which goes into c:\windows\system32 and a folder - winecontrolapplets containing the executable winelocalesetup.exe. The folder goes into c:\windows. when using "wine control", that should've added a "Locale settings" icon in the control panel, and launching it should execute the winelocalesetup.exe. For some reason, though, it only reads the reg values, when trying to write 'em, they revert. (haven't tested it on a winbox yet though; if writing sticks there, a possible bug? Using wine 0.9.57. Tested it on two openSuSe 10.3 boxes though.) Give the concept a test drive, see if the duality matching cpl/real executable is feasable etc, drop me a line on cpls in general - which ones should be emulated etc. If you're more interested in only the regional settings themselves, test 'em out on a few locales; I've already done the US one, also "LANG=bg_BG wine control" and "LANG=ru_RU wine control" appear to show logical stuff, but I have no way of knowing whether the other locales look good. Cheers, Stefanov

1 0

Re: gdi: Add a stub for GdipCreateFontFamilyFromName
by Michael Stefaniuc 17 Mar '08

17 Mar '08

Adam Petaccia wrote: > This patch is needed for me to run Tabula Rasa. > > This is my first patch, so please tell if I've broken conventions. Please add the correct declarations for "struct GpFontCollection" and "struct GpFontFamily". If you cannot find those on MSDN then check Mono; that one seems to have them too. But please do not cut'n'paste. bye michael > ------------------------------------------------------------------------ > > diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c > index be60843..e0a781c 100644 > --- a/dlls/gdiplus/font.c > +++ b/dlls/gdiplus/font.c > @@ -27,6 +27,9 @@ > > #include "gdiplus.h" > #include "gdiplus_private.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(gdiplus); > > GpStatus WINGDIPAPI GdipCreateFontFromLogfontW(HDC hdc, > GDIPCONST LOGFONTW *logfont, GpFont **font) > @@ -99,3 +102,10 @@ GpStatus WINGDIPAPI GdipGetLogFontW(GpFont *font, GpGraphics *graphics, > > return Ok; > } > + > +GpStatus WINGDIPAPI GdipCreateFontFamilyFromName(GDIPCONST WCHAR *name, struct GpFontCollection *fontCollection, struct GpFontFamily **FontFamily) > +{ > + FIXME("GdipCreateFontFamilyFromName: stub!\n"); > + > + return Ok; > +} > diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec > index 4aac0df..1fbc57a 100644 > --- a/dlls/gdiplus/gdiplus.spec > +++ b/dlls/gdiplus/gdiplus.spec > @@ -85,7 +85,7 @@ > @ stdcall GdipCreateCustomLineCap(ptr ptr long long ptr) > @ stub GdipCreateEffect > @ stub GdipCreateFont > -@ stub GdipCreateFontFamilyFromName > +@ stdcall GdipCreateFontFamilyFromName(ptr ptr ptr) > @ stub GdipCreateFontFromDC > @ stdcall GdipCreateFontFromLogfontA(ptr ptr ptr) > @ stdcall GdipCreateFontFromLogfontW(ptr ptr ptr) > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 09ef83f..cd6a7d5 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -184,4 +184,9 @@ struct GpStringFormat{ > StringAlignment vertalign; > }; > > +struct GpFontCollection{ > +}; > + > +struct GpFontFamily{ > +}; > #endif > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

2 1

advapi32 security tests and Vista (PROCESS_ALL_ACCESS)
by Paul Vriens 17 Mar '08

17 Mar '08

Hi, I'm now looking at some of the failures for the security tests on Vista. Apparently PROCESS_ALL_ACCESS which is defined as: #define PROCESS_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED|SYNCHRONIZE|0xfff) is changed on Vista: #define PROCESS_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED|SYNCHRONIZE|0xffff) Should I change the tests (CreateProcess) to check for both possibilities or should our PROCESS_ALL_ACCESS be changed? I'm not sure what implications the latter one has yet. Only that using that mask on other windows versions will/could fail. -- Cheers, Paul.

2 1

Re: shell32: Support getting the shell folder path for users other than the current user and the default user (take 4)
by Alexandre Julliard 17 Mar '08

17 Mar '08

"Ge van Geldorp" <ge(a)thinstall.com> writes: > This is getting embarassing :). Fix memory leak. Now it fails make test: ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so shellpath.c && touch shellpath.ok shellpath.c:305: Test failed: SHGetFolderLocation(NULL, CSIDL_FAVORITES, 2, 0, &pidl) returned 0x80070006, expected E_FAIL make[2]: *** [shellpath.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel