- wine-devel - winehq.org

Re: cabinet.dll -> FDICopy: Test added
by Dmitry Timoshkov 17 Mar '08

17 Mar '08

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > +void CreateEmptyCab(void) > +{ > + static char file_array [] = {77, 83, 67, 70, 0, 0, 0, 0, 36, 0, 0, 0, 0, 0, 0, 0, 36, 0, 0, 0, 0, 0, 0, 0, 3, 1, > 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}; It should be 'static const char' ? > + FILE* fp; > + int i; > + > + fp = fopen("test1.cab", "wb" ); > + if (!fp) trace("Can't create file test1.cab\n"); That should be an assert. > + for (i = 0; i < sizeof(file_array); i++) > + fputc(file_array[i], fp); What about fwrite? > + fclose(fp); > +} Functions you add should be static. Use Win32 APIs to create a temporary file. Set tab size to 8, and avoid using tabs to indent code at all. Avoid trailing spaces. -- Dmitry.

1 0

explorer: add /startfile switch for starting files from file managers
by Vincent Povirk 17 Mar '08

17 Mar '08

This patch adds a switch, /startfile, to explorer.exe, used as "wine explorer /startfile filename". It accepts a windows or unix path. It attempts to mimic what windows explorer does to start files and provide some visible (gui) feedback when it doesn't work. The idea is that wine.desktop can then be modified to use this switch instead of wine, solving the following problems when starting exe files from file managers: * File managers typically do not set the working directory to the directory that contains an exe when they start it. Setting the working directory is the default behavior for windows explorer, and many windows programs rely on it. * File managers naturally use the unix path to start files, and the wine binary passes the unix path along to the exe it starts, rather than translating it to a windows path (this can and probably should also be fixed somewhere else). * Windows explorer always starts exe files with quotes around the path in the command-line, even if the path does not contain spaces. The wine binary does not (and probably should not) add quotes in this situation. A few apps rely on the quotes. See http://bugs.winehq.org/show_bug.cgi?id=5224#c14 My last attempt created a new winelib program; apparently this functionality fits in explorer. -- Vincent Povirk

2 1

re: cabinet.dll -> FDICopy: Test added
by Dan Kegel 17 Mar '08

17 Mar '08

Did you forget the patch?

1 0

Re: user32: test processing of expose events (try 3)
by Paul Vriens 17 Mar '08

17 Mar '08

Clinton Stimpson wrote: > Simplified from first try by removing unecessary thread. > Also fixing style to other code in file (thanks for feedback). > > ChangeLog: > user32: test processing of expose events > > Thanks, > Clinton Stimpson > > > ------------------------------------------------------------------------ > > The patch has been committed but makes sure that the user32 tests currently don't run on win95 anymore. Can the MsgWaitForMultipleObjectsEx be changed to a MsgWaitForMultipleObjects? If so, I'll sent in a patch, if not we have to exclude this test for win95 (and will also sent a patch). -- Cheers, Paul.

2 2

Re: msvcrt: Implement wcscat_s (try 4)
by Alexandre Julliard 17 Mar '08

17 Mar '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Added missing test You should also test that you aren't overflowing the buffer. This should help you find a bug in your implementation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Wine] Re: How to know which env vars a software wants
by Dan Kegel 17 Mar '08

17 Mar '08

vitamin <wineforum-user(a)winehq.org> wrote: > > > A simple touch ~/c:/windows/system32/drivers/etc/{services,host} > > So perhaps this will help other Informix-based apps? > > Should probably add these files to Wine tree. "hosts" shouldn't need > anything more then standard 127.0.0.1 localhost > And services should be empty. Yep. Filed as http://bugs.winehq.org/show_bug.cgi?id=12076

1 0

Updated 1.0.0 release criteria; draft 1.0.0 release plan
by Dan Kegel 17 Mar '08

17 Mar '08

I've updated http://wiki.winehq.org/WineReleaseCriteria to be a bit more final. I've also written a draft release plan; see http://wiki.winehq.org/WineReleasePlan Comments?

5 9

Re: [Tools 7/7] winetest: Add some heuristics to detect missing dlls in version 3 reports.
by Paul Vriens 17 Mar '08

17 Mar '08

Hi, I saw that 'gather' is not creating the index.html file at test.winehq.org anymore. I had a quick look at test.winehq.org and something seem to have go wrong with the patching of 'gather': pvriens@wine:/home/winehq/opt/winetest$ perl gather Use of bare << to mean <<"" is deprecated at gather line 142. Use of bare << to mean <<"" is deprecated at gather line 171. Global symbol "$testref" requires explicit package name at gather line 142. Global symbol "$extrema" requires explicit package name at gather line 142. Global symbol "$extrema" requires explicit package name at gather line 142. Global symbol "$extrema" requires explicit package name at gather line 142. Global symbol "$extrema" requires explicit package name at gather line 142. Global symbol "$extrema" requires explicit package name at gather line 142. syntax error at gather line 176, near "HEAD:" (Might be a runaway multi-line << string starting on line 171) Execution of gather aborted due to compilation errors. -- Cheers, Paul.

3 2

Is the cxtest.org site down?
by Maarten Lankhorst 17 Mar '08

17 Mar '08

Hi, I was trying to look at www.cxtest.org but the site seems not to work. Can this be fixed? Cheers, Maarten.

2 1

Improving the Wine Users Guide
by Lei Zhang 17 Mar '08

17 Mar '08

Hi, For our 1.0 release, we should have a polished users guide to help people to learn to use Wine properly. I did a quick read of the Wine Users Guide [1] and here are my comments: * Near the top - mention virus / security issues, warn against running Wine as root. * Remove references to tools/wineinstall - does anyone use this anymore? * Section 2.3.1 - mention ./configure --verbose * Section 3.1.2.1 - are there dlls besides kernel32, gdi32, user32, and ntdll that we should never use the native one? Add warning about downloading dlls from the web. * Section 3.1.3 - the default virtual window resolution is 800x600 now. Add documentation for the dpi setting. Remove references to "desktop double buffering" - option no longer exists. * Section 3.1.4 - document the advanced options. * Section 3.1.5 - add a blurb about setting directsound emulation to none when wine complains about it. * Section 4.5 - mention the WINEPREFIX environment variable. * Section 5.2.1 - mention including hardware / drivers info in bug reports - Lei [1] http://www.winehq.org/docs/en/wineusr-guide.html

7 6

wine's very own control panel applets?
by pure_evil＠mail.bg 17 Mar '08

17 Mar '08

Hey folks I was thinking of writing some substitutes/stubs for the windows .CPL files. I migrated to using linux as a desktop fairly recently /used it for servers for a while, though/. Adapting to the linux equivalents of the programs I use, using wine for the rest etc. Whilst "reinventing" the software base,I had an annoyingly familiar *close encounter* with a program which /both windows and wine/ gives out a message basically saying in short: "For this program to run, the decimal should be '.' and the negative sign - '-'." That's cuz the locale /Bulgarian/ uses the ',' as the default decimal /both win and wine/. The solutions, of course, are the 3 obvious ones - copy intl.cpl from a working windows, go "regedit" on the subject, open the regs with a text editor. Both 3 are not very appealing (notably the first one; the 2nd and 3rd are rather annoying /if you haven't tampered with the registry too much/, but I consider the first one a real no-go.). So I decided to write something to replace the functions of intl.cpl, and called it "winelocalesetup". However, this got me thinking further - what if that program instead of popping up that message, decided to execute,say, "control.exe intl.cpl", to save me some of the trouble? And didn't issue any warning, but instead crashed in midst of working with it if the decimal wasn't changed (which would normally be the case. It's an accounting program, so, the decimal is indeed important...) Anywho, I was thinking of creating a bunch of CPLs which mimic their windows counterparts in their names. However, the applet itself wouldn't do much - it would basically contain a somewhat appropriate icon/description, and, when started, launch the real executable, wine*something*.exe. That "wine*something*.exe" will for now basically show a message "Winesomething. Not implemented yet. If you see this message because of a running program, it means that the program is trying to...". With time, the .exe will be transformed into a useful substitute for the corresponding windows function. For example: intl.cpl - contains an icon (preferably a picture of the Earth; was thinking of going NASA on the subject), a description "Wine Locale Settings", and will execute winelocalesetup.exe. Winelocalesetup.exe would show a message: "Winelocalesetup. Not implemented yet. If you see this message, it means that a program is trying to call INTL.CPL, probably in order for you to modify the regional settings." That way, at least, it will be indicated to the user what's going on. The idea for having both the cpls and the exes is, well, the cpls have to be called what they're called for compatibility reasons, and, once in place, need not be modified; the actual tool is contained within the .exe, which can be, well, a lot more flexible to develop than the CPL itself, and, can be replaced at any moment. And, well, although compatible with windows, it wouldn't be a pure repetition. (and no longer an empty control panel. Yay!) BTW I have done quite some work on that winelocalesetup.exe, it reads the appropriate values from the registry, doesn't resemble the original intl.cpl's vision, and, well, is somewhat kinda useful (if only I could figure out how to WRITE the damn values, the keys keep turning back to their old values... oh well, guess I'll have to RTFM some more.) So, any suggestions/comments/ideas?

3 4

re: Wine Security Disclosure
by Dan Kegel 17 Mar '08

17 Mar '08

<tehblunderbuss at gmail.com> wrote: > The recent discussion about Windows viruses working through Wine leads > me to questions about its security. > I've heard that using a separate user is alright, and then it isn't > alright. You're probably referring to http://www.winehq.org/pipermail/wine-devel/2008-March/063452.html I was talking about how to make sure your machine is safe when you *on purpose* load malware. However, it is true that we should tell users that Wine is able to run many Windows malware, and that they should be just as careful running Windows software with Wine as they would running it with Windows. We should also show how to install the standard Linux virus checkers. - Dan

6 10

Locked topics considered harmful
by Dan Kegel 16 Mar '08

16 Mar '08

wine-users is not a forum, it's a mailing list. Topics should not be locked except in extreme circumstances; the bounce messages are annoying, and it's wrong for the forum to not properly show what's going on in the mailing list.

2 1

Re: wined3d: Increment reference count before returning palette
by Stefan Dösinger 16 Mar '08

16 Mar '08

Am Sonntag, 16. März 2008 17:49:38 schrieb Cihan Altinay: > Cheers, > Cihan You'll have to check the code that uses this method. As far as I can see DDrawSurface::GetPalette doesn't release the palette it got from WineD3D, so just changing WineD3D will cause a leak

2 1

Re: d3dx9_36: Implements D3DXGetShaderVersion
by Ivan Gyurdiev 16 Mar '08

16 Mar '08

Luis C. Busquets Pérez wrote: > This functions gets the Version Token of a binary shader. This Token > is the first of the binary stream so it is as easy as picling the > pointed DWORD. This is all public information available to the public. What happens when the shader is NULL? Yours will crash - MSDN says otherwise. Does this work on Pixel and Vertex shaders ? Does it always return back the first dword as is - what happens if an invalid shader version is passed in. > To implement a test would be far more complicated as it would mean to > include a binary shader. Anyway, I have tested the results with Civ4 > (by making a derivation on d3dx9_32 with this function and using the > original d3dx9_36.D3DXGetShaderVersion function) and the results where > the same for all the shaders that where present. I would suggest an automated test across [ vs: 1.0, 1.1, 2.0, 2.1, 3.0 ] , [ ps: 1.0, 1.1, 1.2, 1.3, 1.4, 2.0, 2.1, 3.0 ] , NULL, and an invalid token. You can see some binary shaders in the d3d9 tests. Ivan

2 1

wine --show-config option?
by Lei Zhang 16 Mar '08

16 Mar '08

Hi, Would it be helpful for the wine executable to have a --show-config option? It can show information such as: * what options are not compiled in * the version of gcc, fontforge used * whether gecko is installed * what dlls are set to native - Lei

2 1

Re: Eric Pouech : riched20: Start handling OLE objects inside richedit.
by Lei Zhang 16 Mar '08

16 Mar '08

On Fri, Mar 14, 2008 at 3:38 PM, EmpKey Administrator <admin(a)empkey.com> wrote: > > > > > Hi, > > > > I am using CRichEditView class in MFC library to display RTF. The problem is > that ole objects are not displayed in-line with their surround texts. Could > you please let me know how to solve the problem? > > > > Thanks in advances > > > > emp > > > > > Wine-cvs is the wrong list. Please ask questions on wine-devel. Better yet, file a bug on the Wine bugzilla: http://bugs.winehq.org/ - Lei

1 0

[RESEND] ddraw: Fix refcounting of palettes
by Cihan Altinay 16 Mar '08

16 Mar '08

Changed as suggested by Stefan Dösinger. This fixes a crash in a game called "Autobahnverfolgungsjagd Total" (not in AppDB). Cheers, Cihan

2 1

ddraw: Fix refcounting of palettes
by bobbyg＠gmx.net 16 Mar '08

16 Mar '08

This fixes a crash in a game called "Autobahnverfolgungsjagd Total" (not in AppDB). While tracing this bug I noticed that IWineD3DBaseSurfaceImpl_GetPalette() does not call AddRef when returning the palette. Is that intentional? Cheers, Cihan

4 4

Re: New function "SHParseDisplayName"
by Dmitry Timoshkov 16 Mar '08

16 Mar '08

"Paul" <paulvgenderen(a)gmail.com> wrote: > This is my first code contribution to Wine, I have _no_ idea if this > patch is 100% correct Then it's always a good idea to write some tests. > but it /should/ work =) It can't work since you haven't added an entry to the spec file. -- Dmitry.

1 0

DSound Issues
by Artur Szymiec 16 Mar '08

16 Mar '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Greeetings, I would like to trackdown an issue with Direct Sound on TM United (BUG http://bugs.winehq.org/show_bug.cgi?id=12058). How can I provide some usefull data for DSound maintainers ? Best regards Artur - -- - -------------------------------------------------------------------------- Registered User No 397465 Linux Debian 2.6.24.2 AMD Athlon(tm) 64 X2 Dual Core 5000+ Conquer your Desktop! http://www.kde.org/trykde/ Reclaim Your Inbox! http://www.mozilla.org/products/thunderbird/ - -------------------------------------------------------------------------- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH3O0vbB2ld6kq2MsRAoiXAJ94yo6Lyhc6pnjPibpDr0s+aJlbTACg1dJd gCpvefzVOhd0rJBKPOMXLOg= =QhL+ -----END PGP SIGNATURE-----

2 1

Re: d3dx9_36: Implements D3DXGetShaderVersion
by Stefan Dösinger 16 Mar '08

16 Mar '08

Am Samstag, 15. März 2008 01:01:33 schrieb Luis C. Busquets Pérez: > To implement a test would be far more complicated as it would mean to > include a binary shader. Anyway, I have tested the results with Civ4 (by > making a derivation on d3dx9_32 with this function and using the > original d3dx9_36.D3DXGetShaderVersion function) and the results where > the same for all the shaders that where present. You can grab a few binary shaders from dlls/d3d9/tests/visual.c I guess a few DWORDs would be enough. You can use the D3D9 sdk compiler to generate a few shaders: wine vsa.exe shader.txt /Fh shader.h Then shader.h contains a DWORD[] array with the shader bytecode

1 0

Wine code freeze in seven weeks; volunteers needed to fix 1.0 bugs
by Dan Kegel 16 Mar '08

16 Mar '08

Per http://wiki.winehq.org/WineReleasePlan, in early May, Wine's trunk will go into code freeze, and only small, obvious bugfixes will be accepted. Now might be a good time to start winding down development, and switching to cleaning up loose ends. http://bugs.winehq.org/buglist.cgi?query_format=advanced&product=Wine&targe… lists 99 bugs targeted for the 1.0.0 release. When the code freeze starts, we will defer most of the remaining unfixed 1.0 bugs to the 1.1 release. A bunch of them have patches or good analysis attached, and it'd be a shame if those got deferred, so please have a look at these, and if you have time, pick an easy one to fix. - Dan

6 7

Wine SOC - any d3d related projects
by Artur Szymiec 16 Mar '08

16 Mar '08

Hi, are there any d3d related projects for SOC 2008 ? Who is the Mentor ? How can I join ? Best regards Artur -- -------------------------------------------------------------------------- Registered User No 397465 Linux Debian 2.6.24.2 AMD Athlon(tm) 64 X2 Dual Core 5000+ Conquer your Desktop! http://www.kde.org/trykde/ Reclaim Your Inbox! http://www.mozilla.org/products/thunderbird/ --------------------------------------------------------------------------

3 2

Re: Wine Security Disclosure
by TheBlunderbuss 16 Mar '08

16 Mar '08

5 7

Re: Updated 1.0.0 release criteria; draft 1.0.0 release plan
by Remco 16 Mar '08

16 Mar '08

----- Original Message ---- > From: Dan Kegel <dank(a)kegel.com> > I've updated http://wiki.winehq.org/WineReleaseCriteria > to be a bit more final. > > I've also written a draft release plan; see > http://wiki.winehq.org/WineReleasePlan > > Comments? Please note that I'm not complaining, but doesn't that list of criteriaseem a little disappointing? I know what Wine is capable of, but you'retelling the world that, after 15 years, Wine 1.0 is guaranteed to runabout 4 applications. What about growing the list with a few applications that work perfectly at the moment (such as the top 10 platinum rated apps)? There is of course a slight stability problem (mandatory updates) with the Steam apps in that top 10 list, so those would have to be excluded. Remco ___________________________________________________________ Rise to the challenge for Sport Relief with Yahoo! For Good http://uk.promotions.yahoo.com/forgood/

3 3

Re: [Wine] How should I educate myself in order to code for WineHQ?
by James McKenzie 15 Mar '08

15 Mar '08

Dan Kegel wrote: > On Wed, Mar 12, 2008 at 5:11 PM, jingo811 <wineforum-user(a)winehq.org> wrote: > >> So I was wondering can you give me an ordered to-do-list in becoming a Code Monkey for WineHQ? >> >> Like do I have to know both C and C++ to code for Wine. >> > > Nope, just C. Go through "The C Programming Language" by > Kernighan and Ritchie, and do all the exercizes. > > If you can make it through the book, you are very good and will work well for the Wine project. BTW, anyone want a spare copy of this book? James

2 2

Some questions about texture functions of d3dx8/9
by Jérôme Gardou 15 Mar '08

15 Mar '08

I'm trying to implement the D3DXGetImageInfoFrom* functions in d3dx8/9 dlls, and I have a few questions. As there is no related source file from this kind of functions, I created texture.c within dlls/d3dx8. I guess this is the way you want it, but I'd like to hear it from you. Then I need libpng to handle this. I know that gdi32 has some (limited) support for this files, but I wasn't able to know how it was included in its code. A simple #include <png.h> doesn't work, as I expected. So I would like to know how wine build process handle third party libraries. Then, I'd like to know what you think about the code attached here. Please don't forget that this is the very first time I make some code for wine ! Cheers. Jérôme

1 0

GSoC
by MammothTruk 15 Mar '08

15 Mar '08

I read the WineHQ newsletters when they come out to try and keep up on the goings on of Wine and what will run on it. I noticed that the Wsock32.dllwas suggested as a SoC project. I wanted to point out that Vista X64 has issues with this dll and some of the newer programs arent accessing it right. This could be a really good project to take on for someone as it would give people that are having issues with Vista to use Wine. I also thought that possible control panel rewriting so that it looks better would be a good project. Make it more user friendly. Easier to access. My descriptions of what things do on each tab. Just an overall nice,easy,good looking control panel would be really helpful to first time users. the current winecfg looks like crap and isnt at all user friendly to the first time user. I was a first time users a year ago and I still dont understand half of the control panel. Wine Plugin project might be really useful too. It would help companies that cant afford or wont make direct linux ports to have some kind of ability to get their porgrams working without official linux support. The three things listed above all come from me playing NeverWinter Nights 2. OEI wont make a linux port but have been pretty supportive of Wine in their forums on bioware. .NET is also something needed to get the toolset working, but I thought that was a little big for a 2-3 month project. Supporter, Nicholas "MammothTruk" Baldwin -- Lifes to Short. Stop wasting your time.

7 9

Bugzilla Privs
by Alistair Leslie-Hughes 15 Mar '08

15 Mar '08

Hi, Can I please get Privs on Bugzilla to help with the msxml work I am doing? Best Regards Alistair Leslie-Hughes

2 1

inbox
by roy.evison＠ntlworld.com 15 Mar '08

15 Mar '08

Dear Sir/Madam, appologies I have lost my password etc but would be greatful if you could see a way to remove me from current thread as my inbox is constantly filling up with stuff, originally about microsoft dll's, that I really do not understand. Many thanks. Roy. ----------------------------------------- Email sent from www.virginmedia.com/email Virus-checked using McAfee(R) Software and scanned for spam

1 0

Re: fonts: Start of the Symbol font.
by Alexandre Julliard 15 Mar '08

15 Mar '08

Huw Davies <huw(a)codeweavers.com> writes: > fonts/Makefile.in | 1 + > fonts/symbol.sfd | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++ Upgrading fontforge fixed the gdi32 errors, but now I'm getting errors in usp10: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:76: Test failed: ExtTextOutW should return TRUE usp10.c:500: Test failed: ScriptTextOut should return 0 not (00000001) usp10.c:510: Test failed: ScriptTextOut should return 0 not (00000001) usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 0 not 7 for X = 0 usp10.c:789: Test failed: ScriptStringXtoCP should return Ch = 1 not 7 for X = 0 usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 1 not 7 for X = 0 usp10.c:789: Test failed: ScriptStringXtoCP should return Ch = 2 not 7 for X = 0 usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 2 not 7 for X = 0 usp10.c:789: Test failed: ScriptStringXtoCP should return Ch = 3 not 7 for X = 0 usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 3 not 7 for X = 0 usp10.c:789: Test failed: ScriptStringXtoCP should return Ch = 4 not 7 for X = 0 usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 4 not 7 for X = 0 usp10.c:789: Test failed: ScriptStringXtoCP should return Ch = 5 not 7 for X = 0 usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 5 not 7 for X = 0 usp10.c:789: Test failed: ScriptStringXtoCP should return Ch = 6 not 7 for X = 0 usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 6 not 7 for X = 0 usp10.c:789: Test failed: ScriptStringXtoCP should return Ch = 8 not 9 for X = 7 usp10.c:775: Test failed: ScriptStringXtoCP should return Ch = 8 not 9 for X = 7 usp10.c:804: Test failed: ScriptStringXtoCP should return Ch = 3 not -1 for X = -1 usp10.c:820: Test failed: ScriptStringXtoCP should return Ch = 4 not 7 for X = 1 usp10.c:836: Test failed: ScriptStringXtoCP should return Ch = 2 not -1 for X = -1 make: *** [usp10.ok] Error 21 -- Alexandre Julliard julliard(a)winehq.org

1 0

Google Summer of code
by "Luis C. Busquets Pérez" 15 Mar '08

15 Mar '08

Proposing another thing if implementing d3dx9_36.dll is too much I propose to implement: 1 D3DXAssembleShader 2 D3DXAssembleShaderFromFileA 3 D3DXCompileShader 4 D3DXCompileShaderFromFileA 5 D3DXCreateCubeTextureFromFileExA 6 D3DXCreateCubeTextureFromFileInMemory 7 D3DXCreateEffectCompilerFromFileA 8 D3DXCreateEffectFromFileA 9 D3DXCreateTextureFromFileExA 10 D3DXCreateTextureFromFileInMemory 11 D3DXCreateVolumeTextureFromFileExA 12 D3DXCreateVolumeTextureFromFileInMemory 13 D3DXGetImageInfoFromFileInMemory 14 D3DXGetPixelShaderProfile 15 D3DXGetShaderConstantTable 16 D3DXGetShaderInputSemantics 17 D3DXGetShaderVersion 18 D3DXGetVertexShaderProfile 19 D3DXLoadSurfaceFromSurface 20 D3DXSaveSurfaceToFileA 21 D3DXSaveTextureToFileA Which are the functions that Sid Meier's Civilization 4 calls and are not yet implemented from d3dx9_32 (36)

3 3

Re: user32: Fix enumeration for EnumWindowStations and EnumDesktops, try 5
by John Klehm 15 Mar '08

15 Mar '08

On Sat, Mar 15, 2008 at 12:15 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Fixed names to have underscores. > > > > +static void test_enumstations(void) +{ + BOOL ret; + +#if 0 /* Crashes instead */ + SetLastError(0xbabefeed); + ret = EnumWindowStationsA(NULL, 0); + ok(!ret, "EnumWindowStationsA returned succesfully!\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "LastError is set to %08x\n", GetLastError()); +#endif + Dead code?

3 2

Re: user32: test processing of expose events (try 2)
by Dmitry Timoshkov 15 Mar '08

15 Mar '08

"Clinton Stimpson" <cjstimpson(a)utwire.net> wrote: > Simplified from first try by removing unecessary thread. > > ChangeLog: > user32: test processing of expose events Is it possible to use 4 space indents as in the rest of file? -- Dmitry.

1 0

Re: msvcrt: Implement wcscat_s
by Dmitry Timoshkov 15 Mar '08

15 Mar '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > +@ cdecl wcscat_s(ptr long wstr) MSVCRT_wcscat_s The first parameter has type wstr. Also, please check actual buffer contents in the tests not just the return values. -- Dmitry.

2 2

Re: quartz: Set a default sync source on the filtergraph
by Chris Robinson 15 Mar '08

15 Mar '08

On Friday 14 March 2008 04:25:02 pm Maarten Lankhorst wrote: > Use the fallback system IReferenceClock, unless the app comes up with > its own clock. This doesn't look right. According to MSDN, the clock used when Run is called is chosen by the following algorithm: 1- The app called IMediaFilter::SetSyncSource 2- A live filter source is connected to the graph and supports the IReferenceClock interface 3- Any filters support IReferenceClock, starting with renderers and going "upstream" (following pin connections to the source), and falling back to disconnected filters if still nothing. Normally, an audio renderer would be selected here. 4- If still nothing, use the system reference clock. I don't think SetDefaultSyncSource should should just jump right to the system clock. As far as I can tell, you need to hold a reference to a clock, and a bool saying if it's custom set (as even NULL can be a valid custom override). When Run is called, if no custom override is set, it would release the current set clock (if any) and check as steps 2, 3, and 4 describe. So really what the function needs to do is release the current set reference clock (if non-NULL), clear a custom-override flag (while SetSyncSource sets the custom-override flag and holds a reference for non-NULL filters), and check steps 2, 3, and 4. So something like: SetSyncSource(clock) { if(this->ref_clock) this->ref_clock->Release(); this->ref_clock = clock; if(clock) clock->AddRef(); this->custom_clock = TRUE; } SetDefaultSyncSource() { SetSyncSource(NULL); this->custom_clock = FALSE; ...do steps 2, 3, and 4... this->ref_clock = selected_clock; } Run() { if(!this->custom_clock) SetDefaultSyncSource(); ...run... }

2 1

Wine Security Disclosure
by TheBlunderbuss 15 Mar '08

15 Mar '08

3 2

new winetricks 20080314: added vcrun2003, improved dotnet, fixed gui multiple selections
by Dan Kegel 14 Mar '08

14 Mar '08

Another day, another winetricks :-) This version finally adds a way to get Visual C++ 2003 runtime libraries (msvcp71, mfc71). It also finally adds in all the twisty little workarounds needed to run trivial .net 1.1 apps. Also, it looks like enough people are using the gui to send in bug reports for it, which is great; as a result, multiple selections should actually work now. As always, you can grab the latest crosstool from http://kegel.com/wine/winetricks or http://winezeug.googlecode.com Remember, don't use winetricks while operating heavy machinery... - Dan

1 0

Re: quartz: Detect and skip id3v2 header in mpeg splitter
by Chris Robinson 14 Mar '08

14 Mar '08

On Thursday 13 March 2008 09:01:53 pm Maarten Lankhorst wrote: > If read from a file source, ID3 v2 tags might be incorrectly parsed by > the head_check. This patch skips the whole tag altogether. I'm not sure this is completely correct. The main splitter function detects the presense of an MP3 header at the start of a sample it's sending to set the sample's sync point attribute. Since the ID3 tag is not a sync point, this causes the first sample to not be set as a sync point, and it would be unlikely that a following sample would, under normal circumstances, contain an MP3 header at the start either. This could cause sensitive codecs to never find a sync point. ACMWrapper wouldn't be affected as it doesn't handle sync points, but other native codecs (which do work in Wine) could. Additionally, winemp3.acm may be affected by the ID3 tag as it doesn't seem to have code to handle it either.

2 3

wine virus story
by Dan Kegel 14 Mar '08

14 Mar '08

http://wearenixed.blogspot.com/2008/03/you-only-know-good-when-youve-seen-b… "I had set her up with a perfect Wine install. She had a bit of software that needed to run under wine and I had shown her how to install within that environment. Apparently, I wasn't specific enough. It never occurred to Paula that the .exe programs she had used on her XP machine were the vehicles for many of her present viruses. To her, it was perfectly fine to use those same .exe's...after all, she was in Linux, right? I got there within the same hour and checked her machine. Yep...Windows viruses will reside and create the same havoc within a Wine environment. Now, I've seen it with my own eyes. This time I reinstalled for her and made sure I found all the infected .exe's on the Windows side and deleted them."

10 18

Re: [PATCH] gdiplus: Fix test crash in GdipSaveImageToStream.
by Lei Zhang 14 Mar '08

14 Mar '08

On Tue, Mar 11, 2008 at 10:26 PM, Nathan Beckmann <nathan.beckmann(a)gmail.com> wrote: > Correctly initialized parameters to GetDIBits. (Based on > GdipLockBitmapBits.) > > Testing seems to indicate that the error doesn't occur on Debian, but > shows up in Slackware. Valgrind also complains. > --- > dlls/gdiplus/image.c | 28 ++++++++++++++++++++++------ > 1 files changed, 22 insertions(+), 6 deletions(-) > > diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c > index 8307938..ad15148 100644 > --- a/dlls/gdiplus/image.c > +++ b/dlls/gdiplus/image.c > @@ -908,7 +908,9 @@ GpStatus WINGDIPAPI GdipSaveImageToStream(GpImage *image, IStream* stream, > HRESULT hr; > short type; > HBITMAP hbmp; > + HBITMAP old_hbmp; > HDC hdc; > + int bm_is_selected; > BITMAPINFO bmp_info; > LPVOID bmp_bits; > encode_image_func* encode_image; > @@ -917,6 +919,7 @@ GpStatus WINGDIPAPI GdipSaveImageToStream(GpImage *image, IStream* stream, > unsigned int dummy; > int i; > > + old_hbmp = 0; > output = NULL; > output_size = 0; > > @@ -943,18 +946,32 @@ GpStatus WINGDIPAPI GdipSaveImageToStream(GpImage *image, IStream* stream, > hr = IPicture_get_Handle(image->picture, (OLE_HANDLE*)&hbmp); > if (FAILED(hr) || !hbmp) > return GenericError; > + hr = IPicture_get_CurDC(image->picture, &hdc); > + if (FAILED(hr)) > + return GenericError; > + bm_is_selected = (hdc != 0); > + if (!bm_is_selected) { > + hdc = CreateCompatibleDC(0); > + old_hbmp = SelectObject(hdc, hbmp); > + } > > /* get bits from HBITMAP */ > - hdc = GetDC(0); > bmp_info.bmiHeader.biSize = sizeof(bmp_info.bmiHeader); > + bmp_info.bmiHeader.biBitCount = 0; > GetDIBits(hdc, hbmp, 0, 0, NULL, &bmp_info, DIB_RGB_COLORS); > > bmp_bits = GdipAlloc(bmp_info.bmiHeader.biSizeImage); > - if (!bmp_bits) { > - ReleaseDC(0, hdc); > - return OutOfMemory; > + > + if (bmp_bits) > + GetDIBits(hdc, hbmp, 0, abs(bmp_info.bmiHeader.biHeight), bmp_bits, &bmp_info, DIB_RGB_COLORS); > + > + if (!bm_is_selected) { > + SelectObject(hdc, old_hbmp); > + DeleteDC(hdc); > } > - GetDIBits(hdc, hbmp, 0, bmp_info.bmiHeader.biHeight, bmp_bits, &bmp_info, DIB_RGB_COLORS); > + > + if (!bmp_bits) > + return OutOfMemory; > > stat = encode_image(bmp_bits, &bmp_info, &output, &output_size); > if (stat == Ok) > @@ -962,7 +979,6 @@ GpStatus WINGDIPAPI GdipSaveImageToStream(GpImage *image, IStream* stream, > > GdipFree(output); > GdipFree(bmp_bits); > - ReleaseDC(0, hdc); > > return stat; > } > -- > 1.5.4.2 > > > > FYI, here's the valgrind log: http://www.kegel.com/wine/valgrind/logs-2008-03-11/vg-gdiplus_image-diff.txt We're passing an uninitialized bmp_info into GetDIBits(), but somehow it magically works on Debian.

1 0

Clipping regions on windows and Expose Xevents issue
by Ann & Jason Edmeades 14 Mar '08

14 Mar '08

Hello, I've been investigating defect 11562, and would appreciate some thoughts on how to move forward... Basically the application creates a new visible window (eg at 0,0 - 200,50) and then draws in it by: 1. BeginPaint - This sets up the cliprgn to the whole window 2. Works out some sizes... 3. MoveWindow - This moves the window to an appropriate place on the screen 4. FillRect (DrawText, EndPaint) to empty the window... From this call (and all follow on ones) nothing is written to the window because although the visible region is correctly calculated, the clip region was not updated by the MoveWindow call. This highlights 2 problems.. 1. MoveWindow doesn't update the DCEx clip_region region, and hence when the visible region changes, it is merged with the clip region and since there is no overlap the visible region is empty so all subsequent processing ends. Q: Whats the best way to handle that - I was tempted to reset the clip_region to the visible_region (as MSDN sort of implies - you cant really query them so tests don't help much here) in a movewindow call 2. I then hacked MoveWindow to do nothing, so I could progress... What I see then is the popup is drawn, emptied and framed etc, and THEN overwritten with grey. Debugging this shows the application does not respond to WM_PAINT calls for the popup window - ie its drawn once and once only. You can see this on windows if you alt+tab to a covering window, and then back again. HOWEVER, on windows the popup does display correctly the once Investigating the cause, all is ok until the trace:event:process_events Expose for hwnd/window 0xd50026/220002c This drives the trace:win:RedrawWindow 0xd50026 rect (0,0)-(250,50) flags: RDW_INVALIDATE RDW_ERASE RDW_ALLCHILDREN and *bang*, all the drawing which has been done is lost Q: This is getting way outside my understanding of X events, but shouldn't the Expose event for the child (popup) window be processed before returning from CreateWindow with style WS_VISIBLE? All suggestions welcome - I don't mind writing tests etc but would like to try to come up with a solution for the problem as well! Jason

2 3

Re: regedit: stdin is not seekable so do not try to seek the input file if it is not seekable
by Alexandre Julliard 14 Mar '08

14 Mar '08

Aric Stewart <aric(a)codeweavers.com> writes: > --- > programs/regedit/regedit.c | 2 +- > programs/regedit/regproc.c | 19 +++++++++++-------- > programs/regedit/regproc.h | 2 +- > 3 files changed, 13 insertions(+), 10 deletions(-) We shouldn't need to seek at all, instead it should be easy to test the first two bytes of the first line before processing it. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] (RESUBMIT) wininet: restructure for better return checking
by Alexandre Julliard 14 Mar '08

14 Mar '08

Marcus Meissner <marcus(a)jet.franken.de> writes: > Coverity spotted some potential lpwhh NULL usage > after NULL checking. > > I restructured the code a bit to check lpwhh > earlier and return at that time. Also removed a > unnecessary cast. This doesn't work: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so internet.c && touch internet.ok internet.c:118: Test failed: InternetSetOptionA failed 6, expected ERROR_INTERNET_INVALID_OPTION make[2]: *** [internet.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/6] kernel32: Add the MOVEFILE_WRITE_THROUGH flag (stub) for MoveFileEx.
by Dan Hipschman 13 Mar '08

13 Mar '08

Yup, ignore. On Thu, Mar 13, 2008 at 04:00:32PM -0700, Dan Hipschman wrote: > > NOTE: I thought I sent this with the other five patches, but I don't see > it. Sorry if it ends up being a resend. > > This feature of MoveFileEx is technically needed by IBackgroundCopyJob_Complete > to return the correct status if it has to move temp files across volumes, but > since it's a very small point, I'm just adding the flag so we can compile with > it. > > --- > dlls/kernel32/path.c | 3 +++ > include/winbase.h | 1 + > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c > index f0f713f..aad260f 100644 > --- a/dlls/kernel32/path.c > +++ b/dlls/kernel32/path.c > @@ -1010,6 +1010,9 @@ BOOL WINAPI MoveFileWithProgressW( LPCWSTR source, LPCWSTR dest, > if (!dest) > return DeleteFileW( source ); > > + if (flag & MOVEFILE_WRITE_THROUGH) > + FIXME("MOVEFILE_WRITE_THROUGH unimplemented\n"); > + > /* check if we are allowed to rename the source */ > > if (!RtlDosPathNameToNtPathName_U( source, &nt_name, NULL, NULL )) > diff --git a/include/winbase.h b/include/winbase.h > index e2ee515..f3130a0 100644 > --- a/include/winbase.h > +++ b/include/winbase.h > @@ -845,6 +845,7 @@ typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(LARGE_INTEGER, LARGE_INTEGER, LARGE > #define MOVEFILE_REPLACE_EXISTING 0x00000001 > #define MOVEFILE_COPY_ALLOWED 0x00000002 > #define MOVEFILE_DELAY_UNTIL_REBOOT 0x00000004 > +#define MOVEFILE_WRITE_THROUGH 0x00000008 > > #define REPLACEFILE_WRITE_THROUGH 0x00000001 > #define REPLACEFILE_IGNORE_MERGE_ERRORS 0x00000002 > >

1 0

Please vote for your favorite Wine-1.0 bugs...
by Dan Kegel 13 Mar '08

13 Mar '08

The 1.0 release of Wine is tenatively scheduled for the 15th anniversary of the project (roughly 1 June 2008, if you take Dan Dulitz' message as the start of the project, http://groups.google.com/group/comp.os.linux/msg/7f92abdf494ab8b3 ) Over the last six or so months, the wine developers have identified 180 or so bugs as possibly being worth fixing before the 1.0 release. 63 of the Wine 1.0 bugs have already been fixed: http://bugs.winehq.org/buglist.cgi?target_milestone=1.0.0&resolution=FIXED 101 are left to fix: http://bugs.winehq.org/buglist.cgi?target_milestone=1.0.0&resolution=--- We can't fix all of these before the 1.0 release; we'll have to leave some for later. If you want a say in which of these bugs get fixed sooner, please vote for your favorite bugs. To do this, sign into Bugzilla (you need to register, but that's easy), pull up your favorite bug from the above list, and click on the 'Vote for this bug' link on the bug. We can't promise we'll fix the bugs with the most votes, but knowing which ones are most popular can't hurt. Thanks, Dan

2 1

Re: fonts: Start of the Symbol font.
by Alexandre Julliard 13 Mar '08

13 Mar '08

Huw Davies <huw(a)codeweavers.com> writes: > --- > fonts/Makefile.in | 1 + > fonts/symbol.sfd | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+), 0 deletions(-) > create mode 100644 fonts/symbol.sfd It fails make test for me: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:1357: Test failed: no fonts should be enumerated: Symbol ANSI_CHARSET font.c:1405: Test failed: SYMBOL_CHARSET should NOT enumerate ANSI_CHARSET for Symbol font.c:1407: Test failed: SYMBOL_CHARSET should enumerate SYMBOL_CHARSET for Symbol font.c:1447: Test failed: no fonts enumerated: Symbol SYMBOL_CHARSET font.c:1458: Test failed: SYMBOL_CHARSET should enumerate SYMBOL_CHARSET for Symbol font.c:1639: Test failed: A: tmLastChar for Symbol 20 != ff font.c:1671: Test failed: W: tmFirstChar for Symbol 00 != 30 make: *** [font.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Return full patch in res protocol's secure URL.
by Alexandre Julliard 13 Mar '08

13 Mar '08

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/protocol.c | 31 +++++++++++++++++++++---------- > dlls/mshtml/tests/protocol.c | 41 > ++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 61 insertions(+), 11 deletions(-) This breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so misc.c && touch misc.ok misc.c:775: Test failed: [0] size=39, expected 9 misc.c:777: Test failed: [0] wrong secid make: *** [misc.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Configure not throwing error for missing asoundlib.h
by Sebastian Goth 13 Mar '08

13 Mar '08

Hi, even with "--with-alsa" there is no report on a missing asoundlib.h. This is a bit inconvenient since other missing libs are reported. Valid for wine-0.9.57 Sebastian

1 0

1 program is separating me from complete windows independence. please help!
by Eric Appleman 13 Mar '08

13 Mar '08

Can someone please take a look at this bug for me? http://bugs.winehq.org/show_bug.cgi?id=11953

1 0

d3dx8: Implementation of D3DXGetFVFVertexSize
by "Luis C. Busquets Pérez" 13 Mar '08

13 Mar '08

Is ther eany problem with this patch? --- dlls/d3dx8/d3dx8_main.c | 59 +++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 57 insertions(+), 2 deletions(-)

1 0

Re: RESEND D3D add device uuid solves bug 11897
by Stefan Dösinger 13 Mar '08

13 Mar '08

Am Donnerstag, 13. März 2008 14:40:07 schrieb Artur Szymiec: > Stefan Dösinger pisze: > > Am Donnerstag, 13. März 2008 10:19:36 schrieb Artur Szymiec: > >> This is a corrected patch. > >> The uuid is common to dx8 and dx9 since the UUID is generated > >> inside wined3d. > > > > Yes, that looks reasonable. Only two small issues: > >> +/* Fixes BUG 11897 */ > > > > That's not really needed, specifying a GUID is correct even if it > > wouldn't fix a bug report. > > > > Also, please attach the patch as an extra file to the mail, if you inline > > it like you did in your last mails it most likely suffers from line > > wrapping and can't be applied > > That's final version with suggested correction > by Stefan Dösinger Sorry that I didn't think of that earlier, but do you have to use memcpy? Doesn't a simple *pIdentifier->DeviceIdentifier = IID_D3DDEVICE_D3DUID; work as well?

2 1

Re: Prototype patch that solves bug 11897
by Stefan Dösinger 13 Mar '08

13 Mar '08

Hi, Note that we do not accept workaround patches into Wine, because otherwise the whole software would become a huge workaround collection. A potential proper fix for this is to generate an UUID, store it in a constant global variable and memcpy it into the deviceidentifier

3 7

Re: [2/4] qmgr: Add infrastructure for background file transferring. [take 4]
by Alexandre Julliard 13 Mar '08

13 Mar '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -129,6 +131,21 @@ ServiceMain(DWORD dwArgc, LPWSTR *lpszArgv) > return; > } > > + globalMgr.jobEvent = CreateEventW(NULL, TRUE, FALSE, NULL); > + if (!globalMgr.jobEvent) { > + ERR("Couldn't create event: error %d\n", GetLastError()); > + UpdateStatus(SERVICE_STOPPED, NO_ERROR, 0); > + return; > + } > + > + fileTxThread = CreateThread(NULL, 0, fileTransfer, NULL, 0, &threadId); > + if (!fileTxThread) > + { > + ERR("Failed starting file transfer thread\n"); > + UpdateStatus(SERVICE_STOPPED, NO_ERROR, 0); > + return; > + } > + > UpdateStatus(SERVICE_RUNNING, NO_ERROR, 0); You also need to shutdown the thread properly when the service terminates. -- Alexandre Julliard julliard(a)winehq.org

1 0

Question about function "HTMLDocument_write"
by Ivan Sinitsin 13 Mar '08

13 Mar '08

On Monday the patch realizing this function has been accepted. It works perfectly, but hyperlinks do not work. If I makes this function that way: static HRESULT WINAPI HTMLDocument_write(IHTMLDocument2 *iface, SAFEARRAY *psarray) { HRESULT hres; VARIANT *pvar; IHTMLElement *pbody; BSTR vtext; int i; vtext = SysAllocString(L""); HTMLDocument_get_body(iface,&pbody); hres = IHTMLElement_get_innerHTML(pbody, &vtext); if (FAILED(hres)) { vtext = SysAllocString(L""); } hres=SafeArrayAccessData(psarray, (void **)&pvar); if (FAILED(hres)) return hres; for (i=0; i < psarray->rgsabound[0].cElements; i++) { hres = VarBstrCat(vtext, V_BSTR(&(pvar[i])), &vtext); if (FAILED(hres)) { break; } } IHTMLElement_put_innerHTML(pbody,vtext); SysFreeString(vtext); hres = SafeArrayUnaccessData(psarray); return S_OK; } hyperlinks works good. Why so occurs?

2 2

Re: msi: Ignore the custom action type 51 if the source field is empty
by Paul Vriens 13 Mar '08

13 Mar '08

James Hawkins wrote: > Hi, > > Fixes bug 11891. http://bugs.winehq.org/show_bug.cgi?id=11891 > > Changelog: > * Ignore the custom action type 51 if the source field is empty. > > dlls/msi/custom.c | 3 ++ > dlls/msi/tests/install.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 68 insertions(+), 0 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi James, I was looking at the sudden huge amount of failures for the msi/package tests on Windows: http://test.winehq.org/data/200803121000/ The issue turned out to be with the above patch for the install tests. If I run the install tests a 'MSITEST' package will stay around (can been seen in 'Add/Remove Programs"). If I remove MSITEST the package tests will succeed again. (Reverting the above patch makes the package tests pass again as well, when run after the install tests of course). The thing that surprises me is that we don't see the same failures when running the package tests on Wine? Is this because we have 39 TODO's in there? -- Cheers, Paul.

1 0

re: Running services in WINE?
by Dan Kegel 12 Mar '08

12 Mar '08

Yes, services are implemented now. If you run into a problem, please file a bug.

1 0

Vista and SHFileOperation tests for shell32
by Paul Vriens 12 Mar '08

12 Mar '08

Hi, I was trying to fix the issues with the user32/listbox tests when I found that we have a lot of leftover files from the shell32/shlfileop test. This happens because I get about a gazillion dialogs asking me what to do during the shlfileop tests and I usually tend to click Cancel or Skip. The first test that fails for me is where we delete the directory before the file in that directory. This silently succeeds on everything before Vista but fails on Vista and W2K8. Adding any of the silencing flags doesn't make a difference on Vista but make it fail on all the other Windows versions. What road should I take for this: a) Add some delete_all_possible_leftover_files_and_directories function at the end of shlfileop.c ? b) Start making a distinction between Vista/W2K8 and pre-Vista ? c) ???? The first one obviously doesn't fix the test failures. -- Cheers, Paul.

1 0

Re: [1/4] qmgr: Add critical sections for Jobs and Files.
by Alexandre Julliard 12 Mar '08

12 Mar '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -25,6 +25,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(qmgr); > > static void BackgroundCopyFileDestructor(BackgroundCopyFileImpl *This) > { > + This->owner->lpVtbl->Release((IBackgroundCopyJob *) This->owner); Please use the appropriate COM macros instead of accessing lpVtbl directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Free apps bundled with msvcp71?
by Remco 12 Mar '08

12 Mar '08

----- Original Message ---- > From: Dan Kegel <dank(a)kegel.com> > Subject: Re: Free apps bundled with msvcp71? > > I'm still looking for a legal download of some app > that just happens to come with msvcp71.dll. > Ideally it'll be some small app with a trivial installer > that can be run noninteractively, suitable for use inside winetricks. Maybe winetricks could become a w32 application. Make it an applicationthat "installs commonly omitted dlls and frameworks on Windows". That way,you could use some of the dlls directly: those dlls that only allowfree redistribution when bundled with Windows-oriented applications. Nothing in the application, especially the name,should refer to Wine of course; that alone would make it orientedto non-Windows platforms. At least until there is a plausible use for Wine on Windows. Remco __________________________________________________________ Sent from Yahoo! Mail. The World's Favourite Email http://uk.docs.yahoo.com/nowyoucan.html

1 0

Can we have a server component in bugzilla?
by Dan Kegel 12 Mar '08

12 Mar '08

There have been several server-related bugs lately, yet we have no server component. Seems like we need one.

2 4

Re: [2/2] wined3d: Don't translate by a full half pixel
by Stefan Dösinger 12 Mar '08

12 Mar '08

Am Mittwoch, 12. März 2008 09:46:25 schrieb Chris Robinson: I am not yet conviced that those patches are a good idea. Some time ago I found that I need the full half pixel to make DCT happy. Furthermore I see different behavior among drivers, e.g. my r200 driver doesn't need any correction(it rather hurts instead), and the nvidia driver behaves odd on very small render targets. As I said on IRC, I am afraid that we have to do those position fixes per driver. In the extension detection we have to draw a few points onto the back buffer and read back the results, and then configure the offsets accordingly. As I keep saying, we need proper tests for that. Your test to test the corner points is a good start, but we also have to test offscreen targets of different sizes(e.g. 1x1, 4x4, 16x16, ...), and we have to test all 3 codepaths(rhw, fixed function, shader).

1 0

Re: Hans Leidekker : wininet: Make sure not to overwrite any caller supplied authorization header.
by Robert Shearman 12 Mar '08

12 Mar '08

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: b069ef4268e7056856ce6714714d929165f24fc8 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b069ef4268e7056856ce67147… > > Author: Hans Leidekker <hans(a)it.vu.nl> > Date: Fri Feb 1 14:40:15 2008 +0100 > > wininet: Make sure not to overwrite any caller supplied authorization header. > > --- > > dlls/wininet/http.c | 36 ++++++++++-------------------------- > dlls/wininet/tests/http.c | 5 ++++- > 2 files changed, 14 insertions(+), 27 deletions(-) > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 65b86fb..a339c86 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -1187,9 +1187,11 @@ static UINT HTTP_DecodeBase64( LPCWSTR base64, LPSTR bin ) > * > * Insert or delete the authorization field in the request header. > */ > -static BOOL HTTP_InsertAuthorizationForHeader( LPWININETHTTPREQW lpwhr, struct HttpAuthInfo *pAuthInfo, LPCWSTR header ) > +static BOOL HTTP_InsertAuthorization( LPWININETHTTPREQW lpwhr, LPCWSTR header, BOOL first ) > { > WCHAR *authorization = NULL; > + struct HttpAuthInfo *pAuthInfo = lpwhr->pAuthInfo; > + DWORD flags; > > if (pAuthInfo && pAuthInfo->auth_data_len) > { > @@ -1222,35 +1224,17 @@ static BOOL HTTP_InsertAuthorizationForHeader( LPWININETHTTPREQW lpwhr, struct H > > TRACE("Inserting authorization: %s\n", debugstr_w(authorization)); > > - HTTP_ProcessHeader(lpwhr, header, authorization, > - HTTP_ADDHDR_FLAG_REPLACE | HTTP_ADDHDR_FLAG_REQ); > + /* make sure not to overwrite any caller supplied authorization header */ > + flags = HTTP_ADDHDR_FLAG_REQ; > + flags |= first ? HTTP_ADDHDR_FLAG_ADD_IF_NEW : HTTP_ADDHDR_FLAG_REPLACE; > > - HeapFree(GetProcessHeap(), 0, authorization); > + HTTP_ProcessHeader(lpwhr, header, authorization, flags); > > + HeapFree(GetProcessHeap(), 0, authorization); > return TRUE; > } > > /*********************************************************************** > - * HTTP_InsertAuthorization > - * > - * Insert the authorization field in the request header > - */ > -static BOOL HTTP_InsertAuthorization( LPWININETHTTPREQW lpwhr ) > -{ > - return HTTP_InsertAuthorizationForHeader(lpwhr, lpwhr->pAuthInfo, szAuthorization); > -} > - > -/*********************************************************************** > - * HTTP_InsertProxyAuthorization > - * > - * Insert the proxy authorization field in the request header > - */ > -static BOOL HTTP_InsertProxyAuthorization( LPWININETHTTPREQW lpwhr ) > -{ > - return HTTP_InsertAuthorizationForHeader(lpwhr, lpwhr->pProxyAuthInfo, szProxy_Authorization); > -} > - > -/*********************************************************************** > * HTTP_DealWithProxy > */ > static BOOL HTTP_DealWithProxy( LPWININETAPPINFOW hIC, > @@ -2621,8 +2605,8 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWININETHTTPREQW lpwhr, LPCWSTR lpszHeaders, > lpwhr->hdr.dwFlags & INTERNET_FLAG_KEEP_CONNECTION ? szKeepAlive : szClose, > HTTP_ADDHDR_FLAG_REQ | HTTP_ADDHDR_FLAG_REPLACE); > > - HTTP_InsertAuthorization(lpwhr); > - HTTP_InsertProxyAuthorization(lpwhr); > + HTTP_InsertAuthorization(lpwhr, szAuthorization, !loop_next); > + HTTP_InsertAuthorization(lpwhr, szProxy_Authorization, !loop_next); > > /* add the headers the caller supplied */ > if( lpszHeaders && dwHeaderLength ) > diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c > index 8bb7cca..88369cf 100644 > --- a/dlls/wininet/tests/http.c > +++ b/dlls/wininet/tests/http.c > @@ -1502,7 +1502,10 @@ static void test_header_handling_order(int port) > request = HttpOpenRequest(connect, NULL, "/test3", NULL, NULL, types, INTERNET_FLAG_KEEP_CONNECTION, 0); > ok(request != NULL, "HttpOpenRequest failed\n"); > > - ret = HttpSendRequest(request, authorization, ~0UL, NULL, 0); > + ret = HttpAddRequestHeaders(request, authorization, ~0UL, HTTP_ADDREQ_FLAG_ADD); > + ok(ret, "HttpAddRequestHeaders failed\n"); > + > + ret = HttpSendRequest(request, NULL, 0, NULL, 0); > ok(ret, "HttpSendRequest failed\n"); > > status = 0; > This patch simultaneously breaks proxy authentication and NTLM authentication. Proxy authentication is broken because the helper function is removed that passes lpwhr->pProxyAuthInfo into HTTP_InsertAuthentication. NTLM authentication is broken because first is false when we try to send the authenticate message (i.e. the 3rd leg) and so the data for the negotiate message (i.e. the first leg) is sent instead as the field is not overridden. Is this trying to fix a real app? If not, why isn't the code that is using the behaviour using INTERNET_FLAG_NO_AUTH? -- Rob Shearman

1 0

Re: [PATCH 1/4] avifil32: Fix copy/paste error.
by Stefan Dösinger 12 Mar '08

12 Mar '08

I think the patches suffer from mail client line wrapping, I cannot apply them: patch -p1 < /dev/shm/kenpatch/\[PATCH\ 1_4\]\ avifil32\:\ Fix\ copy_paste\ error. patching file dlls/avifil32/acmstream.c patch: **** malformed patch at line 67: LONG start,

2 1

FW: bug 6311 1.0 - wineserver regression
by EA Durbin 12 Mar '08

12 Mar '08

Could someone familiar with wineserver take a look at this please? I've narrowed down the cause of this regression in bugzilla within the commit itself, but I don't know the proper fix. ---------------------------------------- > Date: Tue, 11 Mar 2008 18:13:48 -0700 > From: dank(a)kegel.com > To: ead1234(a)hotmail.com > Subject: Re: bug 6311 1.0 > > On Tue, Mar 11, 2008 at 6:10 PM, EA Durbin wrote: >> Can we add bug 6311 to the 1.0 bugs? >> 5948 was on the list but it is closed now. >>There was a regression recently and it's broken again. > > Make some noise on the list about those bugs. > > Being on the 1.0 list isn't really that helpful. _________________________________________________________________ Need to know the score, the latest news, or you need your Hotmail®-get your "fix". http://www.msnmobilefix.com/Default.aspx

1 1

Re: Revert "mshtml: Use QueryService to get IHttpNegotiate in get_post_data_stream."
by Jacek Caban 11 Mar '08

11 Mar '08

Hi Vitaliy, Vitaliy Margolen wrote: > This reverts commit c32cca8066807d09e3b953aee9242eba8cfa8cdb. > > This patch is obviously wrong since it broke Steam Community page. > This patch is obviously good and fixed a real problem, so the problem must be somewhere else. I would try to fix it, but Community tab works fine for me so I can't test it. Jacek

2 4

compile fail on Linux Mint
by Chad Harris 11 Mar '08

11 Mar '08

Hi guys. Just tried to compile wine.. ( Yes, I know theres a package ) but sometimes I'm sadistic enough to want to compile somethin.. and it just keeps failing.. perhaps you can shed some light on what's goin' wrong? Thanks Chad

5 4

Something that might be useful for the D3D guys
by Daniel 11 Mar '08

11 Mar '08

Hello there, while stumbling through the net today, I came upon this [1] little tool. It will, among other things, allow you to run apps that are overly picky about the level of hardware support your graphic card offers. I found that some things (like disabling textures, forcing wireframe mode) work in wine 0.9.56 as well, whereas things like lying about the shaders seems to fail. Perhaps it can be of some use to those who have to deal with D3D. regards, Daniel [1] http://www.tommti-systems.com/main-Dateien/files.html (3D-Analyze, click on the image) -- 'God is omnipotent, omniscient, and omnibenevolent [...] If you have a mind capable of believing all three of these attributes simultaneously, I have a wonderful bargain for you. No checks, please. Cash and in small bills.' -- Robert Heinlein, "Notebooks of Lazarus Long"

2 1

Re: patch to fix bug 8246
by Alexandre Julliard 11 Mar '08

11 Mar '08

Hin-Tak Leung <htl10(a)users.sourceforge.net> writes: > This is the fix to bug 8246 to get HtmlHelpW to work correctly. > It was first worked on by Andrey Turkin and updated later by me. Please add a proper log entry describing the change. > -static inline LPWSTR strdupAtoW(LPCSTR str) > +static inline LPWSTR strdupnAtoW(LPCSTR str, LONG l) > { > LPWSTR ret; > DWORD len; > + BOOL zero_pad; > > if(!str) > return NULL; > > - len = MultiByteToWideChar(CP_ACP, 0, str, -1, NULL, 0); > + if (l>0) > + { > + LONG i; > + zero_pad = TRUE; > + for (i=0;i<l;i++) > + { > + if (!str[i]) > + { > + zero_pad = FALSE; > + l = i+1; > + break; > + } > + } > + } else { > + zero_pad = FALSE; > + } > + > + len = MultiByteToWideChar(CP_ACP, 0, str, l, NULL, 0); > + if (zero_pad) > + len++; This is ugly and unnecessary, MultiByteToWideChar handles embedded nulls just fine. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 3/5] shell32: use xdg well known directories for shell redirection (try 4)
by Alexandre Julliard 11 Mar '08

11 Mar '08

"Lei Zhang" <thestig(a)google.com> writes: > This patch attempts to set the shell folders using xdg well known > directories via shell redirection. If any part of this fails, the rest > of SHELL_RegisterShellFolders() should fill in the gaps. This will still break if the user changes the drives config. I don't understand why you don't want to simply use the symlinks; why should the dirs be handled differently when they are obtained from the xdg config instead of from the current hard-coded values? -- Alexandre Julliard julliard(a)winehq.org

2 2

improve winetricks dotnet 1.1
by Louis. Lenders 11 Mar '08

11 Mar '08

Hi, i wonder if it would be possible to improve winetricks dotnet 1.1, so that it's actually able to run .net-1.1 applications. Currently it only installs the framework, but due to bugs the apps don't run. Atm moment i use pretty worthless script below to get them running, but i'm sure one of the winetricks hackers could turn this into a nice script Note, the dlls gdiplus and mscoree should be set to native only, not (native, builtin), so override_dll should look tiny bit different then in winetricks. __________________________________________________________ Sent from Yahoo! Mail. The World's Favourite Email http://uk.docs.yahoo.com/nowyoucan.html

1 0

Thunderbird -- Colored Diffs
by TheBlunderbuss 11 Mar '08

11 Mar '08

This may have been out there for a while, but I'd thought I'd mention it anyway. Colored Diffs is an extension for you Thunderbird users out there that makes it easier to read those diffs, even when they're part of the email message itself. I was happily surprised at the functionality :) https://addons.mozilla.org/en-US/thunderbird/addon/4268

1 0

Re: msi: Test the published installer properties
by Alexandre Julliard 11 Mar '08

11 Mar '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > rediffed with git. > > Changelog: > * Test the published installer properties. This is still failing for me: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:4484: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 make[2]: *** [install.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/5] qmgr: Add infrastructure for background file transferring. [take 2]
by Alexandre Julliard 11 Mar '08

11 Mar '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > +DWORD WINAPI fileTransfer(void *param) > +{ > + BackgroundCopyManagerImpl *qmgr = &globalMgr; > + BackgroundCopyJobImpl *job = NULL; > + > + for (;;) > + { > + /* Note that other threads may add files to the job list, but only > + this thread ever deletes them so we don't need to worry about jobs > + magically disappearing from the list. */ > + EnterCriticalSection(&qmgr->cs); > + { > + struct list *next = (job > + ? list_next(&qmgr->jobs, &job->entryFromQmgr) > + : list_head(&qmgr->jobs)); > + job = (next > + ? LIST_ENTRY(next, BackgroundCopyJobImpl, entryFromQmgr) > + : NULL); > + } > + LeaveCriticalSection(&qmgr->cs); > + > + if (job) > + { > + /* It's fine to access the job state outside of the job's critical > + section in these cases because this thread is the only one that > + can change the state once it gets in one of these. */ > + if (job->state == BG_JOB_STATE_ACKNOWLEDGED || job->state == BG_JOB_STATE_CANCELLED) > + { > + EnterCriticalSection(&qmgr->cs); > + list_remove(&job->entryFromQmgr); > + job->lpVtbl->Release((IBackgroundCopyJob *) job); > + LeaveCriticalSection(&qmgr->cs); > + job = NULL; > + } > + else > + { > + /* Process job */ > + } > + } > + else > + Sleep(1000); You should use some sort of synchronization mechanism, not just poll the list every second. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Fix enumeration and add tests for EnumWindowStations and EnumDesktops, try X
by Alexandre Julliard 11 Mar '08

11 Mar '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > +static BOOL CALLBACK windowstationcallbackA(LPSTR winsta, LPARAM lp) > +{ > + trace("windowstationcallbackA called with argument %s\n", winsta); > + return lp; > +} > + > +static BOOL CALLBACK openwindowstationcallbackA(LPSTR winsta, LPARAM lp) > +{ Please use underscores to separate words in function names, theselongstringswithoutspacesarepainfultoread. -- Alexandre Julliard julliard(a)winehq.org

1 0

DestroyWindow behavior differences between Win9x and Win2k/xp
by Justin Chevrier 11 Mar '08

11 Mar '08

Hey guys, I'm looking into a crash of Master Of Orion II on exit (both in Wine and Windows XP). The problem appears to be that the program is attempting to do a DestroyWindow on a different thread. This is not allowed by our code and that behavior is backed up by MSDN documentation. This behavior was allowed on Windows 9x however. I have confirmed that removing the thread check allows the app to exit cleanly, but of course that is not an acceptable fix. As this is a full screen app the game's window stays on top in a partially drawn state and exiting requires doing an alt-tab to the console. Opinions on the correct course of action to resolve this? Thanks Justin Chevrier

4 5

Future Wine Weekly Newsletters
by Zachary Goldberg 11 Mar '08

11 Mar '08

Wine, I normally would like to have WWNs ready by Sunday night to be posted on Monday but as you can tell i'm going to slip by a day or two again this week. A proposal was mentioned to me to make WWNs perhaps bi-weekly, either coordinating with the week of releases or the off week. This would have a couple immediate pros and cons that I can see: pros *More articles and posts for me to sift through, pick out the more important and relevent articles. Slightly higher overall W(B)WN quality. *It'd be much easier for me to be on time with them. cons *Fewer wwns *Perhaps slightly bigger wwns, i don't know what general consensus is on preffered newsletter length Thoughts? Either way i'de like to have 343 ready and submitted sometime tomorrow evening. --Zach

3 2

Re: make LoadStringW pass tests (fixed merge conflict)
by James Hawkins 10 Mar '08

10 Mar '08

On Wed, Mar 5, 2008 at 11:58 AM, Christopher <raccoonone(a)procyongames.com> wrote: > resubmitting my patch to resolve a merge conflict with the latest GIT > > Christopher Berner > > From 47a770102acf010834899489416e92fd4f79ffd1 Mon Sep 17 00:00:00 2001 > From: Christopher Berner <raccoonone(a)procyongames.com> > Date: Wed, 5 Mar 2008 09:28:26 -0800 > Subject: [PATCH] make LoadStringW pass conformance tests > > --- > dlls/crypt32/oid.c | 3 ++- > dlls/hhctrl.ocx/help.c | 4 ++-- > dlls/mpr/wnet.c | 3 ++- > dlls/user32/resource.c | 14 +++++++++++++- > dlls/user32/tests/resource.c | 29 +++++++++++------------------ > 5 files changed, 30 insertions(+), 23 deletions(-) > > diff --git a/dlls/crypt32/oid.c b/dlls/crypt32/oid.c > index 5d17997..edd9732 100644 > --- a/dlls/crypt32/oid.c > +++ b/dlls/crypt32/oid.c > @@ -1402,8 +1402,9 @@ static void init_oid_info(HINSTANCE hinst) > } > else > { > + LPWSTR junkpointer; /* third argument cannot be NULL, to receive length of resource from LoadStringW */ > int len = LoadStringW(hinst, (UINT_PTR)oidInfoConstructors[i].pwszName, > - NULL, 0); > + (LPWSTR)&junkpointer, 0); > Why don't you just name the new parameter the same name as the function parameter ('buffer' or some variation)? junkpointer is a terrible variable name. -- James Hawkins

3 3

re: DestroyWindow behavior differences between Win9x and Win2k/xp
by Dan Kegel 10 Mar '08

10 Mar '08

Maybe writing a test showing that the cross-thread behavior is required on win9x would be a good next step?

1 0

Fwd: Re: RegOverridePredefKey stub - Take 2
by Jens Nestler 10 Mar '08

10 Mar '08

Hello, six weeks ago I've sent this patch for a basic implementation of the RegOverridePredefKey function. Unfortunately the patch was not considered till now. Can everybody help me ? Jens

2 2

re: Processes and ioctl's
by Dan Kegel 10 Mar '08

10 Mar '08

Maarten wrote: > I am hitting a snag with moving ioctl handling into mount manager. It might be good to review for the group why you're moving ioctl handling. Context is always helpful.

1 0

Re: ddraw: Implement ForceRefreshRate registry entry for overriding DirectX refresh rate
by Denver Gingerich 10 Mar '08

10 Mar '08

On Mon, Mar 10, 2008 at 12:44 PM, Denver Gingerich <denver(a)ossguy.com> wrote: > The DirectX refresh rate override feature that this patch implements is described in main.c below. > > In order for the override to take effect only on SetDisplayMode and not on RestoreDisplayMode it was necessary to move the functionality of SetDisplayMode into a helper function (IDirectDrawImpl_SetDisplayModeNoOverride) and let IDirectDrawImpl_SetDisplayMode and IDirectDrawImpl_RestoreDisplayMode call the helper function. > > Denver Gingerich > > > diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c > index 4cac55d..0f7eeaf 100644 > --- a/dlls/ddraw/ddraw.c > +++ b/dlls/ddraw/ddraw.c > @@ -3,6 +3,7 @@ > * Copyright 1998-2000 Lionel Ulmer > * Copyright 2000-2001 TransGaming Technologies Inc. > * Copyright 2006 Stefan Dösinger > + * Copyright 2008 Denver Gingerich > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -60,6 +61,9 @@ static const DDDEVICEIDENTIFIER2 deviceidentifier = > 0 > }; > > +/* in main.c; stores value of ForceRefreshRate */ > +extern DWORD force_refresh_rate; > + > /***************************************************************************** > * IUnknown Methods > *****************************************************************************/ > @@ -534,34 +538,24 @@ IDirectDrawImpl_SetCooperativeLevel(IDirectDraw7 *iface, > } > > /***************************************************************************** > - * IDirectDraw7::SetDisplayMode > * > - * Sets the display screen resolution, color depth and refresh frequency > - * when in fullscreen mode (in theory). > - * Possible return values listed in the SDK suggest that this method fails > - * when not in fullscreen mode, but this is wrong. Windows 2000 happily sets > - * the display mode in DDSCL_NORMAL mode without an hwnd specified. > - * It seems to be valid to pass 0 for With and Height, this has to be tested > - * It could mean that the current video mode should be left as-is. (But why > - * call it then?) > + * Helper function for SetDisplayMode and RestoreDisplayMode > * > - * Params: > - * Height, Width: Screen dimension > - * BPP: Color depth in Bits per pixel > - * Refreshrate: Screen refresh rate > - * Flags: Other stuff > - * > - * Returns > - * DD_OK on success > + * Implements DirectDraw's SetDisplayMode, but ignores the value of > + * ForceRefreshRate, since it is already handled by > + * IDirectDrawImpl_SetDisplayMode. RestoreDisplayMode can use this function > + * without worrying that ForceRefreshRate will override the refresh rate. For > + * argument and return value documentation, see > + * IDirectDrawImpl_SetDisplayMode. > * > *****************************************************************************/ > -static HRESULT WINAPI > -IDirectDrawImpl_SetDisplayMode(IDirectDraw7 *iface, > - DWORD Width, > - DWORD Height, > - DWORD BPP, > - DWORD RefreshRate, > - DWORD Flags) > +static HRESULT > +IDirectDrawImpl_SetDisplayModeNoOverride(IDirectDraw7 *iface, > + DWORD Width, > + DWORD Height, > + DWORD BPP, > + DWORD RefreshRate, > + DWORD Flags) > { > ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw7, iface); > WINED3DDISPLAYMODE Mode; > @@ -616,6 +610,46 @@ IDirectDrawImpl_SetDisplayMode(IDirectDraw7 *iface, > } > > /***************************************************************************** > + * IDirectDraw7::SetDisplayMode > + * > + * Sets the display screen resolution, color depth and refresh frequency > + * when in fullscreen mode (in theory). > + * Possible return values listed in the SDK suggest that this method fails > + * when not in fullscreen mode, but this is wrong. Windows 2000 happily sets > + * the display mode in DDSCL_NORMAL mode without an hwnd specified. > + * It seems to be valid to pass 0 for With and Height, this has to be tested > + * It could mean that the current video mode should be left as-is. (But why > + * call it then?) > + * > + * Params: > + * Height, Width: Screen dimension > + * BPP: Color depth in Bits per pixel > + * Refreshrate: Screen refresh rate > + * Flags: Other stuff > + * > + * Returns > + * DD_OK on success > + * > + *****************************************************************************/ > +static HRESULT WINAPI > +IDirectDrawImpl_SetDisplayMode(IDirectDraw7 *iface, > + DWORD Width, > + DWORD Height, > + DWORD BPP, > + DWORD RefreshRate, > + DWORD Flags) > +{ > + if (force_refresh_rate != 0) > + { > + TRACE("ForceRefreshRate overriding passed-in refresh rate (%d Hz) to %d Hz\n", RefreshRate, force_refresh_rate); > + RefreshRate = force_refresh_rate; > + } > + > + return IDirectDrawImpl_SetDisplayModeNoOverride(iface, Width, Height, BPP, > + RefreshRate, Flags); > +} > + > +/***************************************************************************** > * IDirectDraw7::RestoreDisplayMode > * > * Restores the display mode to what it was at creation time. Basically. > @@ -642,12 +676,12 @@ IDirectDrawImpl_RestoreDisplayMode(IDirectDraw7 *iface) > ICOM_THIS_FROM(IDirectDrawImpl, IDirectDraw7, iface); > TRACE("(%p)\n", This); > > - return IDirectDraw7_SetDisplayMode(ICOM_INTERFACE(This, IDirectDraw7), > - This->orig_width, > - This->orig_height, > - This->orig_bpp, > - 0, > - 0); > + return IDirectDrawImpl_SetDisplayModeNoOverride(ICOM_INTERFACE(This, IDirectDraw7), > + This->orig_width, > + This->orig_height, > + This->orig_bpp, > + 0, > + 0); > } > > /***************************************************************************** > diff --git a/dlls/ddraw/main.c b/dlls/ddraw/main.c > index 4e77d4f..a33cb34 100644 > --- a/dlls/ddraw/main.c > +++ b/dlls/ddraw/main.c > @@ -4,6 +4,7 @@ > * Copyright 1998 Lionel Ulmer > * Copyright 2000-2001 TransGaming Technologies Inc. > * Copyright 2006 Stefan Dösinger > + * Copyright 2008 Denver Gingerich > * > * This file contains the (internal) driver registration functions, > * driver enumeration APIs and DirectDraw creation functions. > @@ -68,6 +69,9 @@ static CRITICAL_SECTION_DEBUG ddraw_cs_debug = > }; > CRITICAL_SECTION ddraw_cs = { &ddraw_cs_debug, -1, 0, 0, 0, 0 }; > > +/* value of ForceRefreshRate */ > +DWORD force_refresh_rate = 0; > + > /*********************************************************************** > * > * Helper function for DirectDrawCreate and friends > @@ -886,6 +890,38 @@ DllMain(HINSTANCE hInstDLL, > } > } > > + /* On Windows one can force the refresh rate that DirectDraw uses by > + * setting an override value in dxdiag. This is documented in KB315614 > + * (main article), KB230002, and KB217348. By comparing registry dumps > + * before and after setting the override, we see that the override value > + * is stored in HKLM\Software\Microsoft\DirectDraw\ForceRefreshRate as a > + * DWORD that represents the refresh rate to force. We use this > + * registry entry to modify the behavior of SetDisplayMode so that Wine > + * users can override the refresh rate in a Windows-compatible way. > + * > + * dxdiag will not accept a refresh rate lower than 40 or higher than > + * 120 so this value should be within that range. It is, of course, > + * possible for a user to set the registry entry value directly so that > + * assumption might not hold. > + * > + * There is no current mechanism for setting this value through the Wine > + * GUI. It would be most appropriate to set this value through a dxdiag > + * clone, but it may be sufficient to use winecfg. > + * > + * TODO: Create a mechanism for setting this value through the Wine GUI. > + */ > + if ( !RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Microsoft\\DirectDraw", &hkey ) ) > + { > + DWORD type, data; > + size = sizeof(data); > + if (!RegQueryValueExA( hkey, "ForceRefreshRate", NULL, &type, (LPBYTE)&data, &size ) && type == REG_DWORD) > + { > + TRACE("ForceRefreshRate set; overriding refresh rate to %d Hz\n", data); > + force_refresh_rate = data; > + } > + RegCloseKey( hkey ); > + } > + > DisableThreadLibraryCalls(hInstDLL); > } > else if (Reason == DLL_PROCESS_DETACH) This patch differs from my previous patch [1] in the following ways: a) DDRAW_SetDisplayMode renamed to IDirectDrawImpl_SetDisplayModeNoOverride b) sentence in main.c description changed from "To ensure compatibility with Windows, we use this registry entry to modify the behavior of SetDisplayMode." to "We use this registry entry to modify the behavior of SetDisplayMode so that Wine users can override the refresh rate in a Windows-compatible way." Hopefully these changes are sufficient for the patch to be accepted. Please let me know if there are further concerns with it. Thanks. Denver 1. http://www.winehq.org/pipermail/wine-patches/2008-March/051213.html

1 0

Fixed function pipeline replacement infrastructure follow up
by Stefan Dösinger 10 Mar '08

10 Mar '08

Hi, As a follow up to the mail from last Sunday I now have a concrete implementation suggestion for an infrastructure for a fixed function pipeline replacement: What it mainly does is that it makes the state table a property of the shader backend, as well as the shader caps to keep GetDeviceCaps simpler. It also adds rudimentary functions for comparing the fixed function fragment processing settings. As an example implementation, the patchset is constructed around a fragment pipeline implementation using GL_ATI_fragment_shader. What is missing is dealing with vertex states, Henri has some code for that already. The data structure and comparison of pipeline states needs optimization. The already existing pipeline replacement using GL_NV_register_combiners and GL_NV_texture_shader should be moved into a separate shader backend. And obviously an implementation of vertex and fragment pipeline using ARB shaders and GLSL(that could be done as a gsoc project maybe) The GL_ATI_fragment_shader code is constructed bottom-up, so if the patches are applied as-is, it will lead to a temporary regression on ATI cards. Inverting this would be a major pain, so when sending it in I'll keep the extension disabled in patch 1, and enable it in a final last patch. The GL_NV_* stuff will work a bit different than atifs, arb and glsl, since we can configure all texture stages individually, so a stored program and state comparison is not needed. Instead we can keep the set_tex_op as it is, but the if(GL_SUPPORTED(...)) checks and related nastiness can be factored out. Maybe we can also get rid of setting up the texunit map every draw in some cases.

1 1

Re: shell32: Support getting the shell folder path for users other than the current user and the default user (take 3)
by Alexandre Julliard 10 Mar '08

10 Mar '08

"Ge van Geldorp" <ge(a)thinstall.com> writes: > Changelog: > Juan Lang <juan.lang(a)gmail.com> > Ge van Geldorp <ge(a)thinstall.com> > Support getting the shell folder path for users other than the current > user and the default user > Fixes bug 10905 You are leaking memory now. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Make the reference count of WININETHANDLEHEADER thread-safe by using InterlockedIncrement/InterlockedDecrement.
by Alexandre Julliard 10 Mar '08

10 Mar '08

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -1296,7 +1296,7 @@ HINTERNET FTP_FtpOpenFileW(LPWININETFTPSESSIONW lpwfs, > lpwh->hdr.vtbl = &FTPFILEVtbl; > lpwh->hdr.dwFlags = dwFlags; > lpwh->hdr.dwContext = dwContext; > - lpwh->hdr.dwRefCount = 1; > + lpwh->hdr.lRefCount = 1; If you are going to rename the variable then please take the opportunity to get rid of the silly Hungarian prefix, so that we don't need to rename it again next time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: a patch to fix the font in bottons and so on.
by Robert Shearman 10 Mar '08

10 Mar '08

彭思 wrote: > Hi everyone, > I have a patch in ubuntu China forum, which fix the font in bottons > and so on to display correctly using the right font. This patch > changes only one source file: dlls/gdi32/freetype.c. The main function > is: Default and ansi charset is translated to > getenv("WINE_DEFAULT_CODEPAGE"). This patch was written by *windowssux > <javascript:pn('windowssux');> in ubunt china forum: > http://forum.ubuntu.org.cn/* > > > The patched freetype.c is attached. It's the first time for me to send > you guys a patch to wine. Please let know if something is wrong. Thanks. You need to send the patch, not the whole file. It's nearly impossible to review the changes if you add an attachment with several thousand lines of code. -- Rob Shearman

1 0

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA
by Mikołaj Zalewski 10 Mar '08

10 Mar '08

I've changed GetModuleHandle to LoadLibrary because when I compiled only tests/rebar.c as standalone, the comctl32 wasn't loaded and GetModuleHandle returned NULL. Are there advantages from using GetModuleHandle? Mikołaj Zalewski

3 4

Re: [PATCH 3/3] shell32: use well known directories from xdg-user-dirs (try 2)
by Lei Zhang 10 Mar '08

10 Mar '08

On Wed, Mar 5, 2008 at 8:41 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This sets the shell folders using values from xdg-user-dirs. The > existing shell folder code checks the shell folder registry keys, and > will not overwrite the values we set here. > > This version converts the Unix paths to Unicode when needed. > It just occurred to me that I need to convert the Unix path to a dos path. Should I just send the updated version of this patch, or resend the first two patches in the series as well?

2 1

Re: [PATCH] qedit: use skip in MediaDet test
by Lei Zhang 10 Mar '08

10 Mar '08

On Thu, Feb 21, 2008 at 5:15 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > Dank pointed out the qedit test crashes with an old .wine directory. > Adding a skip(). > Any reason why this wasn't committed?

2 1

New winetricks 20080309: new verb 'icodecs'
by Dan Kegel 10 Mar '08

10 Mar '08

Intel codecs are needed to run Tonka Search & Rescue 2 (which my son likes), so I added them to winetricks as 'icodecs'. I also renamed allvcodecs to be allcodecs (since it's hard to separate audio from video codecs sometimes) and removed a spurious warning from wsh56. As always, winetricks is at http://kegel.com/wine/winetricks and http://winezeug.googlecode.com

1 0

Please remove/block DARKGuy user from the forum and user mailing list!
by Vitaliy Margolen 10 Mar '08

10 Mar '08

What the subject say.

1 0

Processes and ioctl's
by Maarten Lankhorst 10 Mar '08

10 Mar '08

Hi all, I am hitting a snag with moving ioctl handling into mount manager. I got the ioctl's working and itunes fairly satisfied, but now I'm hitting another problem: The mount manager is not in the same process any more as the application. This is an issue because one of the ioctl's is passing a pointer in the struct itself, which gives a messy situation if it doesn't run in the current application any more. A workaround would be to use ReadProcessMemory and WriteProcessMemory, then fudge the wineserver ioctl request to somehow pass a handle of the calling process around so I can use that. This looks like it is not a clean solution. Does anyone know how to do it cleanly? Cheers, Maarten.

1 0

Re: [PATCH 6/6] wined3d: Dirtify p8 textures when device palettes change.
by Stefan Dösinger 09 Mar '08

09 Mar '08

Am Sonntag, 9. März 2008 15:10:54 schrieb Alexander Dorofeyev: > Fixes problems with properly updating wine's P8 textures, when it is > required because of device palette change. Instead of iterating over all resources and finding P8 textures I think it would be nicer to store the palette the texture/surface was loaded with in each P8 / A8P8 surface and compare this stored palette to the current device palette in IWineD3DSurface::PreLoad(non-texture path) and IWineD3D*Texture::PreLoad. With this, patch 4 could maybe be made nicer as well. If we have to verify the palettes anyway, we can remove the DDraw-Style IWineD3DPalette interface from WineD3D altogether, and just give each ddraw palette in ddraw.dll a WineD3D palette number and use the d3d8/9 palette management exclusively in WineD3D and avoid the confusion of having two palette interfaces.

3 2

Re: oleacc: add GetOleaccVersionInfo
by Reece Dunn 09 Mar '08

09 Mar '08

On 09/03/2008, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > > Hi, this fixes crash in DietPower: > http://bugs.winehq.org/show_bug.cgi?id=10102 > +@ stdcall GetOleaccVersionInfo(long long) Since both these arguments are DWORD*, they need to be ptr, not long. - Reece

1 1

Implementing a new Direct3D function
by Jérôme Gardou 09 Mar '08

09 Mar '08

I'm trying to implement some direct3d functions, more precisely the GetImageInfoFromFile* ones. These are present in directX 8 and in d3dx9_xx.dll I wondered what is the best way to do this : 1)Implementing it in d3dx8.dll and forward everything to this one. 2) Make some useful functions in wined3d and then use them from d3dx8. 3) Implement them directly in wined3d, forwarding everything to it. 4) An other way ? Cheers. Jérôme ___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

2 1

Re: [PATCH 4/6] wined3d: Make code safe if there are no device palettes.
by Roderick Colenbrander 09 Mar '08

09 Mar '08

> There are two types of palettes in wined3d: directx <= 7 style palettes as > separate interface and d3d >= 8 style device palettes. Some code was > defaulting > to device palettes in several places if there's no "old" style palette and > using > device palettes to store ddraw primary surface's palette. This patch > avoids use > of device palettes for anything else than their direct purpose. It is a > necessary preparation for making device palettes dynamically allocated as > needed > (next patch), that prevents ddraw apps from crashing with the latter. > --- > dlls/wined3d/palette.c | 11 ---- > dlls/wined3d/surface.c | 109 > ++++++++++++++++++++++-------------------- > dlls/wined3d/surface_base.c | 20 ++------ > dlls/wined3d/surface_gdi.c | 51 ++++++++------------ > 4 files changed, 82 insertions(+), 109 deletions(-) First of all it appears that this patch contains multiple patches (e.g. the direct3d9 getdc p8 check is one). I'll mention some others below. The p8 code is very sensitive to bugs and those are most of the time very hard to fix, so I'm quite strict. Various things need to be tested using testcases before this patch (cut in pieces) can make it in. In case of read_from_framebuffer when there is no palette set, just return directly instead of adding an if(pal) check. The function won't do anything useful without a palette. Further read_from_framebuffer shouldn't get called from d3d8/9 games anyway as there aren't p8 render targets. I wonder if we need SetDibColorTable at all in case of GetDC as the data the app will receive in the hdc is 8bit. It wants to draw in it by hand, so I would say that the palette won't matter. It might require a testcase. The removal of the device palette code from RealizePalette can be done in a separate patch. I'm not sure if change in SetColorKey is correct in the case a surface doesn't have a palette and uses the primary surface its palette. It doesn't feel right. I think it should fail but this requires a testcase. Second even if the call to SetDibColorTable is needed I wonder what should happen on surfaces which don't have a palette set. It might be correct to use the palette of the primary surface but it might also just be an illegal situation. Roderick -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

2 1

Baldurs Gate 2 script
by Bernhard Posselt 08 Mar '08

08 Mar '08

My username: idefy(a)web.de Including the skript itself

1 0

Article about running Adobe AIR 1.0 on wine
by Dan Kegel 08 Mar '08

08 Mar '08

http://www.downloadsquad.com/2008/03/08/using-wine-to-install-adobe-air-on-… Has a list of apps known not to work. Might be worth following up.

1 0

Re: ddraw: Implement ForceRefreshRate registry entry for overriding DirectX refresh rate
by Stefan Dösinger 08 Mar '08

08 Mar '08

Am Freitag, 7. März 2008 22:29:01 schrieb Denver Gingerich: > The DirectX refresh rate override feature that this patch implements is > described in main.c below. > > In order for the override to take effect only on SetDisplayMode and not on > RestoreDisplayMode it was necessary to move the functionality of > SetDisplayMode into a helper function (DDRAW_SetDisplayMode) and let > IDirectDrawImpl_SetDisplayMode and IDirectDrawImpl_RestoreDisplayMode call > the helper function. I have two concerns: First, do you have an application that needs this, or is this just for making this aspect of ddraw compatible with Windows? There's nothing wrong with that in principle, but I am curious I do not really like the name DDRAW_SetDisplayMode. It somewhat goes away from the convention by starting with DDRAW, but yet it does not tell more about what the function does.

2 3

Tons of shader recompilation in TRLegend and screen set issues
by Artur Szymiec 08 Mar '08

08 Mar '08

Greetings, I would like to point out 3 issues with TR Legend game: 1) wine is outputing a ton of messages like: fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x13fb3028 recompiled more than 50 times fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x13fb3028 recompiled more than 50 times fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x13fb3028 recompiled more than 50 times fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x13fb3028 recompiled more than 50 times fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x13fb3028 recompiled more than 50 times fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x13fb3028 recompiled more than 50 times 2) the game itself contain a gfx config dialog. Then at next startup it should use this settings saved somewhere (I guess registry) but instead it dosen't - always running the game will bring the config in the first place. Why is that ? 3) Still something is wrong with the vertex shaders and buffers - see this screenshoot: http://img171.imageshack.us/my.php?image=screen3ub0.jpg And the tons of shader compilation warnings happens in every water scene like in the screenshoot. Best regards Artur -- -------------------------------------------------------------------------- Registered User No 397465 Linux Debian 2.6.24.2 AMD Athlon(tm) 64 X2 Dual Core 5000+ Conquer your Desktop! http://www.kde.org/trykde/ Reclaim Your Inbox! http://www.mozilla.org/products/thunderbird/ --------------------------------------------------------------------------

4 4

AcceptEx implemetation
by Christopher Harvey 08 Mar '08

08 Mar '08

Hi, I'm going to try to implement AcceptEx this weekend. Just wanted to ask if I should write it using unix sockets, or using the existing ws2_32 implementation. Thanks.

3 2

Re: [PATCH] gdiplus: Fix memory leak in GdipLockBitmapBits.
by Nathan Beckmann 08 Mar '08

08 Mar '08

Further testing indicates that a lot more needs to change than what's in this patch. It might be best to hold off on it until I know everything that needs to be done. - Nathan

1 0

Google Summer of Code
by "Luis C. Busquets Pérez" 07 Mar '08

07 Mar '08

Please find attached some projects that could be in this Summer of Code: 1. Finishing the implementation of d3dx9_36. Since we have already the forwarding d3dx9_xx there is just need for the this dll to be in our system. With this fully dll implemented tehre would be no need. 2. msxml.dll, msxml2.dll, msxml2a.dll, msxml2r.dll, msxml3.dll, msxml3r.dll, msxml4.dll, msxml4a.dll, msxml4r.dll, msxml5.dll, msxml5r.dll, msxml6.dll msxml6r.dll and WinHTTP5.dll are all versions referring to the same API together with resoruces. Since wine is already implementing msxml3.dll I see that a good thing would be to link the rest of the files and implement them allñ together. I assume that the biggest part of the work will be repeated. 3. The same that applies to point 2 applise to all files msvcrxx.dll (msvcr80.dll, msvcr70.dll, 4, As in point 3, implementing msvcpxx.dll could also be a job

3 2

re: Problem open files/folders with ShellExecute
by Dan Kegel 07 Mar '08

07 Mar '08

Bruno Cabral wrote: >how could i use ShellExecute() to open a folder in Kde or >Gnome ? The best that i got is to open the wineefile with this: >ShellExecute(handle, "open", "explorer", "path_to_folder", NULL,SW_SHOWNORMAL); >And i try to open a file too(for example a mp3), but it do nothing too. >ShellExecute(NULL, NULL, "path_to_mp3", NULL, NULL, SW_SHOW); >Both examples work fine with all version of windows. Wine really should make ShellExecute work just as you expect, but I don't know how long it'll be until we get around to it. For now, you can detect that you're running on Wine (e.g. if getenv("LOGNAME") is not NULL), and then use the command xdg-open to open the directory or .mp3 file. To prove to yourself this works, try wine cmd /c z:\\usr\\bin\\xdg-open foo.mp3 or wine cmd /c z:\\usr\\bin\\xdg-open /usr That will open the file or directory in the appropriate native app. The only catch is that the path passed to xdg-open has to be a Unix path. You can use the executable winepath to convert Windows paths to Unix paths. To prove to yourself this works, try this: wine cmd /c winepath c:\ This will output the Unix path, /home/dkegel/.wine/dosdevices/c:/ And then you have to be careful about paths with spaces in them, etc. It's a bit of a pain at the moment. If you go down this route, put it in a helper function so you can rip it out easily later. (And so you can share the helper function with others.) - Dan p.s. Related bug: http://bugs.winehq.org/show_bug.cgi?id=3332

1 0

WineHQ should discourage the use of cracks
by Dan Kegel 07 Mar '08

07 Mar '08

I've been fighting against the notion that the wine project encourages cracks for some time now. Cracked versions of apps are bad because they are a) illegal (at least in the US), b) disrespectful of the author of the app, and c) much more likely to be infected with malware. One place we still do it is in our appdb ratings definitions; http://appdb.winehq.org//help/?sTopic=maintainer_ratings which say "Gold: Application works flawlessly with some DLL overrides or other settings, crack etc. " I propose that we change the appdb ratings definitions so that an app that only works with a crack gets no higher than bronze. Any objections? - Dan

20 39

Re: [rsaenh] Fix AES Provider Handling for Windows XP (resend)
by Vijay Kiran Kamuju 07 Mar '08

07 Mar '08

Hi, Please let me know why this patch has been rejected. http://www.winehq.org/pipermail/wine-patches/2008-February/049817.html It seems this patch has gone completely unnoticed. Please Comment. Somehow, my patches are not getting commited/reviewed. Did I do anything wrong, please do tell me. Thanks, Vijay > 2008/2/8 Vijay Kiran Kamuju <infyquest(a)gmail.com>: > > > > ChangeLog > > ---------------- > > Fix the AES Provider Handling for Windows XP by adding AES Provider > > string for XP in wine registry > > > > Bug#11509 > > >

1 0

Re: [1/2]try3. Add new dll. Wbemprox.dll
by Detlef Riekenberg 07 Mar '08

07 Mar '08

On Fr, 2008-03-07 at 13:19 +0300, Ivan Sinitsin wrote: > +++ configure.ac 21 Feb 2008 13:19:10 -0000 > +++ Makefile.in 21 Feb 2008 13:21:30 -0000 > +++ dlls/Makefile.in 21 Feb 2008 15:04:36 -0000 This does not work. Please follow our guidelines about "Implementing a new DLL": http://wiki.winehq.org/Developers-Hints You can also learn from the commit-messages, especially from the commits, when a new dll was added. > +++ tools/wine.inf 22 Feb 2008 07:10:09 -0000 We create only a fake dll, when and application requires the dll to be present and fail without the fake dll. Thanks for helping wine. -- By by ... Detlef

1 0

Problem open files/folders with ShellExecute.
by Bruno Cabral 07 Mar '08

07 Mar '08

Hi guys i trying make my windows software "wine compatible" . It use ShellExecute(..) , how could i use that to open a folder in Kde or Gnome ? The best that i got is to open the wineefile with this: ShellExecute(handle, "open", "explorer", "path_to_folder", NULL, SW_SHOWNORMAL); And i try to open a file too(for example a mp3), but it do nothing too. ShellExecute(NULL, NULL, "path_to_mp3", NULL, NULL, SW_SHOW); Both examples work fine with all version of windows. So, how can execute a file , and howi could open a folder with kde/gnome ? Thanks !

1 0

Re: [2/2]try3.add new dll. wbemprox.dll
by Detlef Riekenberg 07 Mar '08

07 Mar '08

On Fr, 2008-03-07 at 13:19 +0300, Ivan Sinitsin wrote: > This patch add new library to the project wine. Name of the library > is - "wbemprox.dll". Since you read the Developer-Hints, you are now aware, that "Makefile.in" is wrong here. I have no Idea about COM, but you should studdy commits for new dlls, when COM functionality was added (Patch-Size, Complexity). Since you used some code from Roy as template, i suggest to study the commits for his recent Patches. As Examples: http://source.winehq.org/git/wine.git/?a=history;f=dlls/qmgrprxy or http://source.winehq.org/git/wine.git/?a=history;f=dlls/qmgr A "\n" at the start of a TRACE is wrong. A "\t" in a TRACE is not needed. A FIXME for an unimplemented function is a good idea, but a simple FIXME("\n"); is not informative. Thanks for helping Wine -- By by ... Detlef

1 0

Re: msi: ACTION_RegisterProduct store all InstallProperties
by Adam Strzelecki 07 Mar '08

07 Mar '08

Hello, > I think you need to read through the implementation of > MSI_GetProductInfo more closely and also read the MsiGetProductInfo > tests in tests/msi.c and the test_publish:RegisterProduct tests in > tests/install.c. I think I did, and looking at the tests I see they are testing properties only at Uninstall key, and I think this is wrong, or at least incomplete, as quoted below: > res = RegOpenKeyA(uninstall, prodcode, &prodkey); > ok(res == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", res); > > CHECK_REG_DWORD(prodkey, "Version", 0x1010001); > CHECK_REG_DWORD(prodkey, "VersionMajor", 1); > CHECK_REG_DWORD(prodkey, "VersionMinor", 1); > CHECK_REG_DWORD(prodkey, "WindowsInstaller", 1); While MSI_GetProductInfo is reading VersionMajor, VersionMinor, ... etc from InstallProperties key (from szInstallProperties_fmt or szInstaller_LocalSystemProductCodes_fmt), but NOT from Uninstall key as quotes below: > if (classes) > MSIREG_OpenLocalSystemProductKey(szProduct, &userdata, FALSE); > else > MSIREG_OpenInstallPropertiesKey(szProduct, &userdata, FALSE); > > if (!lstrcmpW(szAttribute, INSTALLPROPERTY_HELPLINKW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_HELPTELEPHONEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLDATEW) || > !lstrcmpW(szAttribute, > INSTALLPROPERTY_INSTALLEDPRODUCTNAMEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLLOCATIONW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_INSTALLSOURCEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_LOCALPACKAGEW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_PUBLISHERW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_URLINFOABOUTW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_URLUPDATEINFOW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONMINORW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONMAJORW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_VERSIONSTRINGW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_PRODUCTIDW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_REGCOMPANYW) || > !lstrcmpW(szAttribute, INSTALLPROPERTY_REGOWNERW)) > { > if (!prodkey) > { > r = ERROR_UNKNOWN_PRODUCT; > goto done; > } > > if (!userdata) > return ERROR_UNKNOWN_PROPERTY; > > if (!lstrcmpW(szAttribute, > INSTALLPROPERTY_INSTALLEDPRODUCTNAMEW)) > szAttribute = display_name; > else if (!lstrcmpW(szAttribute, > INSTALLPROPERTY_VERSIONSTRINGW)) > szAttribute = display_version; > > val = msi_reg_get_value(userdata, szAttribute, &type); > if (!val) > val = empty; > } So it does not find any of those properties in the registry, because they're not written there by ACTION_RegisterProduct. And fixing this is the intention of my patch. Regards, -- Adam Strzelecki |: nanoant.com :|

2 4

Re: add realization of HTMLDocument_write,HTMLDocument_open
by Jacek Caban 07 Mar '08

07 Mar '08

Hi Ivan, Ivan Sinitsin wrote: > This patch adds realization of function HTMLDocument_write, and > HTMLDocument_open (it needed for method HTMLDocument_write). > > Changelog: > This patch adds realization of function HTMLDocument_write, and > HTMLDocument_open. > First of all, these should be two separated patches. > static HRESULT WINAPI HTMLDocument_write(IHTMLDocument2 *iface, SAFEARRAY *psarray) > { > - FIXME("(%p)->(%p)\n", iface, psarray); > - return E_NOTIMPL; > + HRESULT hres; > + VARIANT *pvar; > + IHTMLElement *pbody; > + BSTR vtext; > + int i; > + > + vtext = SysAllocString(L""); > + > + HTMLDocument_get_body(iface,&pbody); You can't assume that write will be called inside body element. > + > + hres = IHTMLElement_get_innerHTML(pbody, &vtext); You leak vtext memory here. Also you shouldn't use get_innerHTML at all. > + if (FAILED(hres)) { > + vtext = SysAllocString(L""); > + } > + > + hres=SafeArrayAccessData(psarray, (void **)&pvar); > + if (FAILED(hres)) return hres; > + for (i=0; i < psarray->rgsabound[0].cElements; i++) { > + hres = VarBstrCat(vtext, V_BSTR(&(pvar[i])), &vtext); You should check if pvar[i] is VT_BSTR before using it. > + if (FAILED(hres)) { > + break; > + } > + } > + > + IHTMLElement_put_innerHTML(pbody,vtext); You can't use put_innerHTML here. It will cause recreating of whole body element content. What you probably want is nsIHTMLDocument::Write. I will send the right write implementation. > + SysFreeString(vtext); > + hres = SafeArrayUnaccessData(psarray); > + > + return S_OK; > } > static HRESULT WINAPI HTMLDocument_writeln(IHTMLDocument2 *iface, SAFEARRAY *psarray) > @@ -688,8 +715,8 @@ static HRESULT WINAPI HTMLDocument_write > static HRESULT WINAPI HTMLDocument_open(IHTMLDocument2 *iface, BSTR url, VARIANT name, > VARIANT features, VARIANT replace, IDispatch **pomWindowResult) > { > - FIXME("(%p)->(%s %p)\n", iface, debugstr_w(url), pomWindowResult); > - return E_NOTIMPL; > + TRACE("(%p)->(%s %p)\n", iface, debugstr_w(url), pomWindowResult); > + return IHTMLDocument2_QueryInterface(iface, &IID_IDispatch, (void**)pomWindowResult); > } This is obviously not IHTMLDocument2::open implementation. Jacek

1 0

Re: [3/6] qmgr: Add a mutex to BackgroundCopyJob.
by Robert Shearman 07 Mar '08

07 Mar '08

Dan Hipschman wrote: > Pretty much the same as yesterday but I changed to using mutexes instead > of critical sections since I need to wait on two at once (one for the > job and the other for the file when updating progress). > I'm not sure this is a correct reason for mutexes instead of critical sections. Either way, you need to have a strict ordering so that you don't deadlock and critical sections use mutexes underneath. Unless you're going to be using a named mutex to synchronise across processes or you're going to have threads quit whilst holding the mutex, then the only difference will be that the code is slower when using mutexes because of the necessary server call, which more often than not can be avoided with critical sections. -- Rob Shearman

1 0

Re: Make winecfg DPI interval to be the same as in Windows
by Robert Shearman 07 Mar '08

07 Mar '08

L. Rahyen wrote: > @@ -37,7 +37,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(winecfg); > > #define RES_MAXLEN 5 /* the maximum number of characters in a screen dimension. 5 digits should be plenty, what kind of crazy person runs their screen >10,000 pixels across? */ > #define MINDPI 96 > -#define MAXDPI 160 > +#define MAXDPI 480 > #define DEFDPI 96 > > static const char logpixels_reg[] = "System\\CurrentControlSet\\Hardware Profiles\\Current\\Software\\Fonts"; > @@ -243,9 +243,12 @@ static void on_d3d_pshader_mode_clicked(HWND dialog) { > } > static INT read_logpixels_reg(void) > { > + static const WCHAR szLogPixels[] = {'L', 'o', 'g', 'P', 'i', 'x', 'e', 'l', 's', 0}; > DWORD dwLogPixels; > - char *buf = get_reg_key(HKEY_LOCAL_MACHINE, logpixels_reg, > - "LogPixels", NULL); > + WCHAR *buf; > + WCHAR szLogPixelsReg[MAXBUFLEN]; > + MultiByteToWideChar(GetACP(), 0, logpixels_reg, -1, szLogPixelsReg, sizeof(szLogPixelsReg)/sizeof(szLogPixelsReg[0]) ); > + buf = get_reg_keyW(HKEY_LOCAL_MACHINE, szLogPixelsReg, szLogPixels, NULL); > dwLogPixels = buf ? *buf : DEFDPI; > HeapFree(GetProcessHeap(), 0, buf); > return dwLogPixels; > Don't convert a constant string using MultiByteToWideChar. -- Rob Shearman

1 0

Re: WGL/WINED3D: add WGL_WINE_pixel_format_passthrough
by Chris Robinson 07 Mar '08

07 Mar '08

On Thursday 06 March 2008 02:36:41 pm Roderick Colenbrander wrote: > WGL only allows you to set the pixel format once for a HDC. This requires a > WINE-specific WGL extension which allows us to set the pixel format again. > The patch does this and it works correctly in DirectX8/9 SDK samples. I'm pretty sure this can cause a resource leak if it's done on a D3D child window (the existing offscreen surfaces won't be destroyed). Though I can't say I like the idea of the patch since it does nothing for non-Wine, or even non-winex11.drv Wine, to fix the issue.

2 1

Re: user32: Fix enumeration and add tests for EnumWindowStations andEnumDesktops, try X
by Dmitry Timoshkov 07 Mar '08

07 Mar '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Fixed, and with tests! Why not use A versions of APIs to simplify the tests? Also, though that's a matter of taste, ok(hdesk != 0) is more readable IMO than ok(!!hdesk). -- Dmitry.

1 0

Re: user32: Add a better stub for broadcastsystemmessage, try 2
by Steven Edwards 07 Mar '08

07 Mar '08

On Thu, Mar 6, 2008 at 6:47 PM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Fixes: BroadcastSystemMessage to not hang other processes any more. +static BOOL CALLBACK broadcastsystemmessagetopwindowcallback(HWND top_window, LPARAM lp) +static BOOL CALLBACK broadcastsystemmessagewindowstationcallback( LPWSTR winsta, LPARAM lp ) Just a matter of style...if ever there was a case for abbrevation this is it. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Forgot a release_obj in my broadcastsystemmessage patch.
by Maarten Lankhorst 06 Mar '08

06 Mar '08

Hi, Please don't apply the broadcastsystemmessage patch, there is a bug in enum_top_windows that I accidentally copied from enum_desktop. I'll send a fix for the enum_desktop call and a fixed version of the patch. Cheers, Maarten.

1 0

Recent valgrind regressions in msxml3
by Dan Kegel 06 Mar '08

06 Mar '08

Hi Alistair, I'm seeing some regressions in msxml3 in yesterday's git; see http://kegel.com/wine/valgrind/logs-2008-03-05/vg-msxml3_domdoc-diff.txt e.g. + Invalid read of size 4 + at HEAP_ValidateInUseArena (heap.c:925) + by RtlFreeHeap (heap.c:1288) + by SysFreeString (oleaut.c:196) + by test_domdoc (domdoc.c:658) + by func_domdoc (domdoc.c:2875) + by run_test (test.h:406) + by main (test.h:455) etc. Could you have a look? Also, have you tried running Valgrind yourself? It's not hard at all these days. - Dan

2 1

Re: slight winsock design change proposal
by James Hawkins 06 Mar '08

06 Mar '08

On Wed, Mar 5, 2008 at 6:28 PM, Christopher Harvey <arbuckle911(a)gmail.com> wrote: > I'm giving the mswsock.c file some development time. I need to know if > the winsock API has been inited. This has already been implemented, but > I need to get access to the num_startup variable from the mswsock.c > file. I hacked a bit and got it, but hesitate to continue because I > don't know if I changed it in the proper way to get access. If this > change is fine please accept it. if not please advise on the proper way > to see if winsock has been inited or not, from the mswsock.c file. > > Thanks. > > diff --git a/dlls/mswsock/mswsock.c b/dlls/mswsock/mswsock.c > index d283405..7f339c0 100644 > --- a/dlls/mswsock/mswsock.c > +++ b/dlls/mswsock/mswsock.c > @@ -62,9 +62,10 @@ BOOL WINAPI AcceptEx( > operation */ > { > FIXME("(listen=%ld, accept=%ld, %p, %d, %d, %d, %p, %p), not implemented\n", > - sListenSocket,sAcceptSocket,lpOutputBuffer,dwReceiveDataLength, > - dwLocalAddressLength,dwRemoteAddressLength,lpdwBytesReceived,lpOverlapped > - ); > + sListenSocket,sAcceptSocket,lpOutputBuffer,dwReceiveDataLength, > + dwLocalAddressLength,dwRemoteAddressLength,lpdwBytesReceived,lpOverlapped > + ); > + //get_num_startup(); Use this to see if Winsock has been inited yet or not > return FALSE; > } > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 502f309..03030a2 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -5021,3 +5021,8 @@ INT WINAPI WSCWriteProviderOrder( LPDWORD entry, DWORD number ) > FIXME("(%p 0x%08x) Stub!\n", entry, number); > return 0; > } > + > +INT get_num_startup() > +{ > + return num_startup; > +} > diff --git a/include/winsock2.h b/include/winsock2.h > index a302331..dcca0e7 100644 > --- a/include/winsock2.h > +++ b/include/winsock2.h > @@ -728,6 +728,7 @@ typedef INT (WINAPI *LPFN_WSASTRINGTOADDRESSW)(LPSTR,INT,LPWSAPROTOCOL_INFOA,LPS > typedef DWORD (WINAPI *LPFN_WSAWAITFORMULTIPLEEVENTS)(DWORD,const WSAEVENT*,BOOL,DWORD,BOOL); > #endif /* WS_API_TYPEDEFS */ > > +typedef INT get_num_startup(); > > /* Condition function return values */ > #define CF_ACCEPT 0x0000 > Are you seriously asking if adding a hack to a public header in order to read a global variable from another dll is acceptable? That pretty much sums up the answer. -- James Hawkins

5 7

Getting apps running under Wine
by Martin Hinner 06 Mar '08

06 Mar '08

Hello, I would like to run some of our (win32-based) applications under Linux using Wine. At this time it is only for my personal use, but maybe someday some of our users will like to have it on Linux like me. I have managed to get all of them running, showing at least first dialog/window. But there are some problems: 1) User interface stuff. We are using dialogs (MFC CDialog) that have non-default font size (i.e. Times New Roman, 12 ). The font is displayed correctly under Wine, but dialog window has wrong size (it's smaller and some parts of dialog, mainly buttons at bottom, are not visible). I can send more info on this. How to solve this problem (other way than detecting Wine and resizing window manually) ? 2) Windows drivers. We use DLL that depends on some Win32 drivers. Linux driver is available with similar API, so it's not a big problem to change our application to use Linux library. I understand that clearest way how to solve this problem is to make .dll.so file, but it's quite complicated for this particular application and I would prefer much more to add few if conditions to our Windows code that would recognize Wine under Linux and load native .so file (not .dll.so!). Is this possible? How to deal with different calling conventions between gcc and Visual C++ 2003 ? 3) Windows service. We use a windows NT service (which can easily be ported to Linux,btw), an application communicates with the service using named pipe. Is it possible to communicate from "wined" application with some Linux program using technique other than TCP or Unix socket ? If no - is it possible to open Unix socket from our win app ? -- Martin Hinner http://martin.hinner.info http://www.auto-diagnostics.info

2 3

Re: msi [2/3]: Fix handling of published installer properties
by Alexandre Julliard 06 Mar '08

06 Mar '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > The tests are in the next patch. Fixes bug 7189. > http://bugs.winehq.org/show_bug.cgi?id=7189 You need to fix the todo_wine tests in the same patch, I can't apply a patch that causes failures: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:2233: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2259: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2341: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2469: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2495: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2610: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2633: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2797: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2823: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:2900: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 install.c:3241: Test succeeded inside todo block: Expected ERROR_FILE_NOT_FOUND, got 2 make: *** [install.ok] Error 11 And if I apply your 3/3 patch I now get: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:4398: Test failed: Expected ERROR_UNKNOWN_PRODUCT, got 0 make: *** [install.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Regression tests - recent regressions
by Austin English 06 Mar '08

06 Mar '08

In today's git, I've had a few regressions in make -k test: austin@zelda:~/wine-git$ grep -i 'Test failed' wine-0.9.56-420-g22f146f.txt visual.c:1741: Test failed: double texbem failed: Got color 0x00ff00ff, expected 0x00ffff00. systray.c:89: Test failed: ret 0x1 which is not a window systray.c:90: Test failed: hWnd overwritten msg.c:9415: Test failed: 30: ShowWindow(SW_RESTORE): in msg 0x0047 expecting wParam 0x8160 got 0x8162 msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg 0x0047 was expected, but got msg 0x0005 instead msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg 0x0003 was expected, but got msg 0x0009 instead msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg 0x0005 was expected, but got msg 0x0047 instead msg.c:9415: Test failed: 50: ShowWindow(SW_SHOWNORMAL): the msg sequence is not complete: expected 0000 - actual 0003 msg.c:9415: Test failed: 56: ShowWindow(SW_SHOWNOACTIVATE): in msg 0x0047 expecting wParam 0x8170 got 0x8172 win.c:3271: Test failed: pixel should be black, color is 00205860 win.c:3275: Test failed: pixel should be black, color is 00205860 win.c:3302: Test failed: pixel should be black, color is 00205860 +heap adds: job.c:250: Test failed: GetState failed: 0x80004001 job.c:266: Test failed: Resume failed to return BG_E_EMPTY error: 0x80004001 input.c:470: Test failed: 01: 12 from 81 -> 01 unexpected input.c:470: Test failed: 01: a4 from 81 -> 01 unexpected input.c:461: Test failed: 03: 12 from 00 -> 00 instead of 80 -> 00 input.c:461: Test failed: 03: a4 from 00 -> 00 instead of 80 -> 00 input.c:538: Test failed: not enough messages found; looking for 0 I don't have time to pin these down any further, as I've got a midterm tomorrow then spring break after that. But thought those of you who made recent commits in this area should take a look. If you need a specific test run or log, then please e-mail me. -Austin

3 3

Re: [PATCH] GDI+: Implement GdipGetImageEncoders.
by Nathan Beckmann 06 Mar '08

06 Mar '08

Don't apply this patch. The test cases crash on Windows. I was using winetricks to test and accidentally did not test under Windows. - Nathan On Wed, Mar 5, 2008 at 11:21 AM, Nathan Beckmann <nathan.beckmann(a)gmail.com> wrote: > Implement helper GdipGetImageEncodersSize. > > Also included tests. > --- > dlls/gdiplus/gdiplus.spec | 4 +- > dlls/gdiplus/image.c | 87 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/gdiplus/tests/image.c | 53 +++++++++++++++++++++++++++ > include/gdiplusenums.h | 13 +++++++ > include/gdiplusflat.h | 2 + > include/gdiplusimaging.h | 35 ++++++++++++++++++ > 6 files changed, 192 insertions(+), 2 deletions(-) > > diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec > index b4f314a..a477086 100644 > --- a/dlls/gdiplus/gdiplus.spec > +++ b/dlls/gdiplus/gdiplus.spec > @@ -284,8 +284,8 @@ > @ stub GdipGetImageDecoders > @ stub GdipGetImageDecodersSize > @ stdcall GdipGetImageDimension(ptr ptr ptr) > -@ stub GdipGetImageEncoders > -@ stub GdipGetImageEncodersSize > +@ stdcall GdipGetImageEncoders(long long ptr) > +@ stdcall GdipGetImageEncodersSize(ptr ptr) > @ stub GdipGetImageFlags > @ stdcall GdipGetImageGraphicsContext(ptr ptr) > @ stdcall GdipGetImageHeight(ptr ptr) > diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c > index 5871209..330d90f 100644 > --- a/dlls/gdiplus/image.c > +++ b/dlls/gdiplus/image.c > @@ -831,3 +831,90 @@ GpStatus WINGDIPAPI GdipSetImagePalette(GpImage *image, > > return NotImplemented; > } > + > +/************************************************************************* > + * Encoders - > + * Implemented as dummy objects that let the user know which files are > + * supported. Actual encoding is done by OLE. > + * > + * This code is based heavily on libgdiplus (Mono): > + */ > + > +typedef enum { > + BMP, > + ICO, > +} ImageFormat; > + > +#define NUM_ENCODERS_SUPPORTED 2 > + > +/* ImageCodecInfo creation routines taken from libgdiplus */ > +static const WCHAR bmp_codecname[] = {'B', 'u', 'i','l', 't', '-','i', 'n', ' ', 'B', 'M', 'P', 0}; /* Built-in BMP */ > +static const WCHAR bmp_extension[] = {'*','.','B', 'M', 'P',';', '*','.', 'D','I', 'B',';', '*','.', 'R', 'L', 'E',0}; /* *.BMP;*.DIB;*.RLE */ > +static const WCHAR bmp_mimetype[] = {'i', 'm', 'a','g', 'e', '/', 'b', 'm', 'p', 0}; /* image/bmp */ > +static const WCHAR bmp_format[] = {'B', 'M', 'P', 0}; /* BMP */ > +static const BYTE bmp_sig_pattern[] = { 0x42, 0x4D }; > +static const BYTE bmp_sig_mask[] = { 0xFF, 0xFF }; > + > +static const WCHAR ico_codecname[] = {'B', 'u', 'i','l', 't', '-','i', 'n', ' ', 'I', 'C', 'O', 0}; /* Built-in ICO */ > +static const WCHAR ico_extension[] = {'*','.','I', 'C', 'O', 0}; /* *.ICO */ > +static const WCHAR ico_mimetype[] = {'i', 'm', 'a','g', 'e', '/', 'x', '-', 'i', 'c', 'o', 'n', 0}; /* image/x-icon */ > +static const WCHAR ico_format[] = {'I', 'C', 'O', 0}; /* ICO */ > +static const BYTE ico_sig_pattern[] = { 0x00, 0x00, 0x01, 0x00 }; > +static const BYTE ico_sig_mask[] = { 0xFF, 0xFF, 0xFF, 0xFF }; > + > +static const ImageCodecInfo codecs[NUM_ENCODERS_SUPPORTED] = > + { > + { /* BMP */ > + /* Clsid */ { 0x557cf400, 0x1a04, 0x11d3, { 0x9a, 0x73, 0x0, 0x0, 0xf8, 0x1e, 0xf3, 0x2e } }, > + /* FormatID */ { 0xb96b3cabU, 0x0728U, 0x11d3U, {0x9d, 0x7b, 0x00, 0x00, 0xf8, 0x1e, 0xf3, 0x2e} }, > + /* CodecName */ (const WCHAR*) bmp_codecname, > + /* DllName */ NULL, > + /* FormatDescription */ (const WCHAR*) bmp_format, > + /* FilenameExtension */ (const WCHAR*) bmp_extension, > + /* MimeType */ (const WCHAR*) bmp_mimetype, > + /* Flags */ ImageCodecFlagsEncoder | ImageCodecFlagsDecoder | ImageCodecFlagsSupportBitmap | ImageCodecFlagsBuiltin, > + /* Version */ 1, > + /* SigCount */ 1, > + /* SigSize */ 2, > + /* SigPattern */ (const BYTE*) bmp_sig_pattern, > + /* SigMask */ (const BYTE*) bmp_sig_mask, > + }, > + { /* ICO */ > + /* Clsid */ { 0x557cf407, 0x1a04, 0x11d3, { 0x9a, 0x73, 0x0, 0x0, 0xf8, 0x1e, 0xf3, 0x2e } }, > + /* FormatID */ { 0xb96b3cb5U, 0x0728U, 0x11d3U, {0x9d, 0x7b, 0x00, 0x00, 0xf8, 0x1e, 0xf3, 0x2e} }, > + /* CodecName */ (const WCHAR*) ico_codecname, > + /* DllName */ NULL, > + /* FormatDescription */ (const WCHAR*) ico_format, > + /* FilenameExtension */ (const WCHAR*) ico_extension, > + /* MimeType */ (const WCHAR*) ico_mimetype, > + /* Flags */ ImageCodecFlagsDecoder | ImageCodecFlagsSupportBitmap | ImageCodecFlagsBuiltin, > + /* Version */ 1, > + /* SigCount */ 1, > + /* SigSize */ 4, > + /* SigPattern */ (const BYTE*) ico_sig_pattern, > + /* SigMask */ (const BYTE*) ico_sig_mask, > + }, > + }; > + > +GpStatus WINGDIPAPI GdipGetImageEncodersSize(UINT *numEncoders, UINT *size) > +{ > + if (!numEncoders || !size) > + return InvalidParameter; > + > + *numEncoders = NUM_ENCODERS_SUPPORTED; > + *size = sizeof (codecs); > + > + return Ok; > +} > + > +GpStatus WINGDIPAPI GdipGetImageEncoders(UINT numEncoders, UINT size, ImageCodecInfo *encoders) > +{ > + if (!encoders || > + (numEncoders != NUM_ENCODERS_SUPPORTED) || > + (size != sizeof (codecs))) > + return InvalidParameter; > + > + memcpy(encoders, codecs, sizeof (codecs)); > + > + return Ok; > +} > diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c > index 5ff164d..5f75c15 100644 > --- a/dlls/gdiplus/tests/image.c > +++ b/dlls/gdiplus/tests/image.c > @@ -122,6 +122,58 @@ static void test_LoadingImages(void) > expect(InvalidParameter, stat); > } > > +static void test_encoders(void) > +{ > + GpStatus stat; > + UINT n; > + UINT s; > + ImageCodecInfo *codecs; > + int i; > + int bmp_found; > + > + static const WCHAR bmp_format[] = {'B', 'M', 'P', 0}; > + > + stat = GdipGetImageEncodersSize(NULL, NULL); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncodersSize(&n, &s); > + expect(stat, Ok); > + > + codecs = GdipAlloc(sizeof(ImageCodecInfo) * n); > + if (!codecs) > + return; > + > + stat = GdipGetImageEncoders(n, s, NULL); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(0, s, codecs); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(n, s-1, codecs); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(n, s+1, codecs); > + expect(stat, InvalidParameter); > + > + stat = GdipGetImageEncoders(n, s, codecs); > + expect(stat, Ok); > + > + bmp_found = FALSE; > + for (i = 0; i < n; i++) > + { > + if (CompareStringW(LOCALE_SYSTEM_DEFAULT, 0, > + codecs[i].FormatDescription, -1, > + bmp_format, -1) == CSTR_EQUAL) { > + bmp_found = TRUE; > + break; > + } > + } > + if (!bmp_found) > + ok(FALSE, "No BMP codec found.\n"); > + > + GdipFree(codecs); > +} > + > START_TEST(image) > { > struct GdiplusStartupInput gdiplusStartupInput; > @@ -137,6 +189,7 @@ START_TEST(image) > test_Scan0(); > test_GetImageDimension(); > test_LoadingImages(); > + test_encoders(); > > GdiplusShutdown(gdiplusToken); > } > diff --git a/include/gdiplusenums.h b/include/gdiplusenums.h > index 7c97005..c579ebe 100644 > --- a/include/gdiplusenums.h > +++ b/include/gdiplusenums.h > @@ -257,6 +257,18 @@ enum HotkeyPrefix > HotkeyPrefixHide = 2 > }; > > +enum ImageCodecFlags > +{ > + ImageCodecFlagsEncoder = 1, > + ImageCodecFlagsDecoder = 2, > + ImageCodecFlagsSupportBitmap = 4, > + ImageCodecFlagsSupportVector = 8, > + ImageCodecFlagsSeekableEncode = 16, > + ImageCodecFlagsBlockingDecode = 32, > + ImageCodecFlagsBuiltin = 65536, > + ImageCodecFlagsSystem = 131072, > + ImageCodecFlagsUser = 262144 > +}; > > #ifndef __cplusplus > > @@ -286,6 +298,7 @@ typedef enum StringTrimming StringTrimming; > typedef enum StringFormatFlags StringFormatFlags; > typedef enum HotkeyPrefix HotkeyPrefix; > typedef enum PenAlignment GpPenAlignment; > +typedef enum ImageCodecFlags ImageCodecFlags; > > #endif /* end of c typedefs */ > > diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h > index 1f635ba..b15a4ea 100644 > --- a/include/gdiplusflat.h > +++ b/include/gdiplusflat.h > @@ -257,6 +257,8 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromStreamICM(IStream*,GpBitmap**); > GpStatus WINGDIPAPI GdipDisposeImage(GpImage*); > GpStatus WINGDIPAPI GdipFindFirstImageItem(GpImage*,ImageItemData*); > GpStatus WINGDIPAPI GdipFindNextImageItem(GpImage*,ImageItemData*); > +GpStatus WINGDIPAPI GdipGetImageEncodersSize(UINT *numEncoders, UINT *size); > +GpStatus WINGDIPAPI GdipGetImageEncoders(UINT numEncoders, UINT size, ImageCodecInfo *encoders); > GpStatus WINGDIPAPI GdipGetImageItemData(GpImage*,ImageItemData*); > GpStatus WINGDIPAPI GdipGetImageBounds(GpImage*,GpRectF*,GpUnit*); > GpStatus WINGDIPAPI GdipGetImageGraphicsContext(GpImage*,GpGraphics**); > diff --git a/include/gdiplusimaging.h b/include/gdiplusimaging.h > index c78e1b1..a843da1 100644 > --- a/include/gdiplusimaging.h > +++ b/include/gdiplusimaging.h > @@ -43,6 +43,24 @@ public: > EncoderParameter Parameter[1]; > }; > > +class ImageCodecInfo > +{ > +public: > + CLSID Clsid; > + GUID FormatID; > + const WCHAR* CodecName; > + const WCHAR* DllName; > + const WCHAR* FormatDescription; > + const WCHAR* FilenameExtension; > + const WCHAR* MimeType; > + DWORD Flags; > + DWORD Version; > + DWORD SigCount; > + DWORD SigSize; > + const BYTE* SigPattern; > + const BYTE* SigMask; > +}; > + > class BitmapData > { > public: > @@ -84,6 +102,23 @@ typedef struct EncoderParameters > EncoderParameter Parameter[1]; > } EncoderParameters; > > +typedef struct ImageCodecInfo > +{ > + CLSID Clsid; > + GUID FormatID; > + const WCHAR* CodecName; > + const WCHAR* DllName; > + const WCHAR* FormatDescription; > + const WCHAR* FilenameExtension; > + const WCHAR* MimeType; > + DWORD Flags; > + DWORD Version; > + DWORD SigCount; > + DWORD SigSize; > + const BYTE* SigPattern; > + const BYTE* SigMask; > +} ImageCodecInfo; > + > typedef struct BitmapData > { > UINT Width; > -- > 1.5.4.2 > >

1 1

Re: WineD3D: Implement depth copy from onscreen to offscreen surface when depth fixup is used
by H. Verbeet 06 Mar '08

06 Mar '08

On 06/03/2008, Frank Richter <frank.richter(a)gmail.com> wrote: > This doesn't work. The problem with doing depth copy with fixed up depth stencil is that the size of the render buffer is different from the depth stencil size. Basically what needs to happen is that the render buffer contents need to be blitted to the depth stencil before copying the depth stencil from offscreen to onscreen. Aside from that, depth stencil copying is broken (in that it doesn't always copy when it should, and sometimes copies when it shouldn't). I've got a patch that fixes this, but it causes regressions. Changing anything in the depth copying code would cause some nasty conflicts in my patch. Of course if you're interested in tracking down regressions I'd be happy to send you the patch.

1 0

Re: [PATCH] gdiplus: Fix errors in image dimensions.
by Dmitry Timoshkov 06 Mar '08

06 Mar '08

"Nathan Beckmann" <nathan.beckmann(a)gmail.com> wrote: > - y = (UINT)(((REAL)y) * ((REAL)GetDeviceCaps(hdcref, LOGPIXELSY)) / > - ((REAL)INCH_HIMETRIC)); > + /* this calculation can lead to truncation error */ > + y = (UINT)((((REAL)y) * ((REAL)GetDeviceCaps(hdcref, LOGPIXELSY)) / > + ((REAL)INCH_HIMETRIC)) + 0.5); Using MulDiv instead should be a more appropriate fix here. -- Dmitry.

1 0

Re: (resend) msi: Fix bug in handling of multivolume CAB files.
by James Hawkins 06 Mar '08

06 Mar '08

On Tue, Mar 4, 2008 at 11:51 AM, Ove Kaaven <ovek(a)transgaming.com> wrote: > The email address in the patch was wrong, sending it again. > > > >From b88a43dbc2234c8b35ee4fa7bb4f275475b8d821 Mon Sep 17 00:00:00 2001 > From: Ove Kaaven <ovek(a)transgaming.com> > Date: Tue, 4 Mar 2008 18:16:27 +0100 > Subject: [PATCH] Fix bug in handling of multivolume CAB files. > After extracting a single file from a multivolume CAB file, sometimes > information about the next CAB file to extract from would not be loaded, > because the is_continuous state was previously only properly reset if a > file happened to be partially extracted from the last volume of a > multivolume series. > A lot of time has been spent fixing cab/media related bugs in installers, as the behavior is very fickle (and easily breakable), so can you please add a test case first? See the multicab tests that are already in install.c. They will fail in wine because our cabinet.dll cannot create compressed cabinets, but assuming you test in Windows or use native cabinet.dll, it'll still verify that the patch is correct. -- James Hawkins

2 5

Re: user32: Fix enumeration for EnumWindowStations and EnumDesktops, try2
by Dmitry Timoshkov 06 Mar '08

06 Mar '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Oops, the other call has to be null terminated as well. Do you have test cases for those changes? They look like a noop to me. -- Dmitry.

2 1

Re: Winecfg: Raise max screen resolution to 160 DPI
by L. Rahyen 05 Mar '08

05 Mar '08

Your patch isn't correct. Just try this: rm -rf ~/.wine wineprefixcreate winecfg Go to Graphics tab and set any resolution more than 127 DPI (for example, 150). Close winecfg. Run it again. Now you have 63 DPI (instead of 150; in fact anything bigger than 127 DPI will not be displayed correctly in winecfg). This problem was already solved in this patch [1] by Nigel Liang. Unfortunately, it wasn't accepted and Nigel didn't tried to ask why it was rejected or to resend it. I think I will go ahead and resend his patch. [1] http://www.winehq.org/pipermail/wine-patches/2007-October/044977.html

3 3

[feature requist] Glide API support
by Vincent Weber 05 Mar '08

05 Mar '08

Dear Wine devs, There are some games out there that were built with the Glide API. The Glide API is the graphics API of the 3dfx Voodoo cards and is basically a stripped down version of OpenGL. Could please consider adding support for the Glide API because I, and other have games that requires this API to be able to run under Wine. Now I know that there are Glide wrappers but they don't seem to work for a lot of people, including me, and Glide has been a very popular game API in the mid- to late 90's. Thanks in advance, Vincent Weber, weber dot vincent at gmail dot com

7 6

Re: Maarten Lankhorst : oleaut32: Handle TKIND_ALIAS properly when passed as pointer.
by Marcus Meissner 05 Mar '08

05 Mar '08

On Wed, Mar 05, 2008 at 06:24:14AM -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: c978bbee87dd6e09e4ad836df5ad7d63506face2 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=c978bbee87dd6e09e4ad836df… > > Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > Date: Mon Mar 3 14:27:03 2008 -0800 > > oleaut32: Handle TKIND_ALIAS properly when passed as pointer. > > --- > > + break; > case TKIND_ENUM: /* confirmed */ > case TKIND_RECORD: /* FIXME: mostly untested */ > - derefhere=TRUE; > break; ... Why the removal of this line? Any indication that it helps? Ciao, Marcus

2 1

Re: hal: Add a stub for HalGetBusData() to make 3DMark2001SE happy in WinNT mode.
by Alexandre Julliard 05 Mar '08

05 Mar '08

Francois Gouget <fgouget(a)codeweavers.com> writes: > +typedef enum _BUS_DATA_TYPE > +{ > + ConfigurationSpaceUndefined = -1, > + Cmos, > + EisaConfiguration, > + Pos, > + CbusConfiguration, > + PCIConfiguration, > + VMEConfiguration, > + NuBusConfiguration, > + PCMCIAConfiguration, > + MPIConfiguration, > + MPSAConfiguration, > + PNPISAConfiguration, > + MaximumBusDataType > +} BUS_DATA_TYPE, *PBUS_DATA_TYPE; Shouldn't that stuff go into a public header? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll/tests: Don't use 0x55/0xaa to avoid any confusion when running with +heap.
by Paul Vriens 05 Mar '08

05 Mar '08

Francois Gouget wrote: > --- > dlls/ntdll/tests/atom.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/ntdll/tests/atom.c b/dlls/ntdll/tests/atom.c > index 2de94a0..68f5aba 100644 > --- a/dlls/ntdll/tests/atom.c > +++ b/dlls/ntdll/tests/atom.c > @@ -198,13 +198,13 @@ static void test_NtAtom(void) > ok((lstrlenW(testAtom2) * sizeof(WCHAR)) == Len, "Returned wrong length %d\n", Len); > > Len = 8; > c- Name[0] = Name[1] = Name[2] = Name[3] = Name[4] = 0x55AA; > + Name[0] = Name[1] = Name[2] = Name[3] = Name[4] = 0x1337; What happened there? -- Cheers, Paul.

2 1

Re: WineHQ should discourage the use of cracks
by Remco 05 Mar '08

05 Mar '08

Or how about this: ::Wine Compatibility:: ( ) Doesn't work at all [Garbage] ( ) Starts, but not very usable [Bronze] ( ) Basically works, a few bugs [Silver] (*) Works flawlessly [Gold] ::Extra Info:: [x] Needs Wine configuration (Windows version, sound options, regedit entries, etc.) [x] Needs a Windows DLL (has legal issues) [x] Needs a third party hack (has legal issues) If Gold and no tick boxes are selected: Works out of the box! [Platinum] The Extra Info tick boxes could be represented as icons accompanying the color-based Status wherever it goes. The icons should probably give a negative impression. A red color for example, although that might not get across very well, considering the color palette of WineHQ... ;) The "has legal issues" should link to a Wine Wiki page which explains exactly what those issues are and that specific discussion on how to get those things working is not allowed at winehq.org, the mailing lists, the newsgroup or the IRC channel. Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

3 2

Re: #1 gdi32: Move GetICMProfile to the driver.
by Alexandre Julliard 05 Mar '08

05 Mar '08

Hans Leidekker <hans(a)it.vu.nl> writes: > Changelog > Move GetICMProfile to the driver. Looks good, but the code doesn't belong in x11drv_main.c. Something like graphics.c would be more appropriate. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] shell32: add xdg-user-dirs lookup code
by Alexandre Julliard 05 Mar '08

05 Mar '08

"Lei Zhang" <thestig(a)google.com> writes: > + /* Convert $HOME to wide chars */ > + len = MultiByteToWideChar(CP_ACP, 0, home_dir, -1, NULL, 0); > + home_dirW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + if (!home_dirW) > + { > + hr = E_OUTOFMEMORY; > + goto xdg_user_dir_lookup_error; > + } > + MultiByteToWideChar(CP_ACP, 0, home_dir, -1, home_dirW, len); > + hr = get_xdg_config_file(home_dir, &config_file); > + if (FAILED(hr)) > + goto xdg_user_dir_lookup_error; > + > + file = fopen(config_file, "r"); > + HeapFree(GetProcessHeap(), 0, config_file); > + if (!file) > + { > + hr = E_HANDLE; > + goto xdg_user_dir_lookup_error; > + } > + > + while (fgets(buffer, sizeof(buffer), file)) > + { > + int idx; > + WCHAR *p, bufferW[512]; > + > + /* Convert buffer to wide chars */ > + len = MultiByteToWideChar(CP_UTF8, 0, buffer, -1, NULL, 0); > + MultiByteToWideChar(CP_UTF8, 0, buffer, -1, bufferW, len); It doesn't make sense to convert $HOME or config strings to Unicode, these are Unix paths, they should be kept as such until you call symlink() or whatever on them. -- Alexandre Julliard julliard(a)winehq.org

1 0

X Error of failed request
by bill lam 05 Mar '08

05 Mar '08

Sometimes (about 3 or 4 times in one day) that it just crashed with this message, X Error of failed request: BadWindow (invalid Window parameter) Major opcode of failed request: 18 (X_ChangeProperty) Resource id in failed request: 0x4400003 Serial number of failed request: 1113 Current serial number in output stream: 1117 no stack trace was available. Is this a known issue and how to get more information that may help debugging. I use nvidia card on ubuntu 7.10 amd64. regards,

2 1

Regession tests
by Alistair Leslie-Hughes 05 Mar '08

05 Mar '08

Hi, Some of the regessions test are failing with errors in output file like msxml3:domdoc start dlls/msxml3/tests/domdoc.c 1.80 msxml3:domdoc done (-1073741819) Is this due to a Seg Fault? Best Regards Alistair Leslie-Hughes

2 3

re: Don't know if this is the right place to ask this but...
by Dan Kegel 05 Mar '08

05 Mar '08

Will Howard willz06jw at gmail.com wrote: >#1 How do you know if Valgrind is working properly (AKA everything is >patched and working). > >#2 How do you decifer the output to start looking for bugs. Here's some example output (cleaned up a bit by my perl script, http://kegel.com/wine/valgrind/valgrind-split-pl.txt) is at: http://kegel.com/wine/valgrind/logs-2008-03-03/vg-ws2_32_sock.txt That particular output file says Syscall param socketcall.sendmsg(msg.msg_iov[i]) points to uninitialised byte(s) at (within /lib/ld-2.6.1.so) by WSASendTo (socket.c:2674) by WS_sendto (socket.c:2827) by test_UDP (sock.c:1055) by func_sock (sock.c:1985) by run_test (test.h:406) by main (test.h:455) This means there may be a bug somewhere near some of the lines mentioned. Sadly, only filename are given, not directories, so you kind of have to guess whether the files in question are in the directory ws2_32 or ws2_32/tests (or somewhere else). The thing to do is to read and understand the test with the issue. The course of action will then be obvious :-) Did I mention you have to really understand the test? - Dan

1 0

Don't know if this is the right place to ask this but...
by Will Howard 05 Mar '08

05 Mar '08

Howdy, I'm trying to help find memory leaks for wine http://wiki.winehq.org/MemoryLeaks and I'm having some issues figuring out Valgrind. #1 How do you know if Valgrind is working properly (AKA everything is patched and working). #2 How do you decifer the output to start looking for bugs. Thanks for the help, Will

1 0

Screen mode retrieval/trace tool for Windows
by Denver Gingerich 04 Mar '08

04 Mar '08

I am trying to trace the sequence of screen mode (resolution/bpp/refresh rate) changes that occur when StarCraft is run in Windows so that I can make Wine emulate Windows' behavior. Right now I'm trying to see exactly what resolution, bits per pixel, and refresh rate StarCraft is using. Unfortunately, I can't just go into Display Properties while StarCraft is running because it switches the resolution back when you Alt-Tab out of the game. My current plan is to install an SSH or telnet server on the Windows machine and run a command line tool to check the current screen mode while StarCraft is running. I have used a couple of command-line tools for changing the screen mode [1] [2], but neither of them have an option to list the current mode. Does anyone know of a tool or can anyone quickly create a tool that will list the resolution currently in use from the command line? I have tried using StraceNT [3] to see the parameters passed to ChangeDisplaySettingsEx (which is the function StarCraft uses to change the resolution), but it does not let me look at the DEVMODE structure that is passed in. Does anyone know of a trace tool that would let me do that? Based on my testing so far, there appears to be a discrepancy in how Windows and Wine set the refresh rate if none is specified on a resolution change. Wine always picks the first mode with a matching resolution, while Windows does not. My tests in Windows have shown that even though StarCraft asks for 640x480 and the first mode with that resolution has a 60 Hz refresh rate, Windows chooses a higher refresh rate. Unfortunately, I don't know exactly which refresh rate, but I can verify by sight that 60 Hz is not being used (the screen doesn't flicker as it would at 60 Hz). This discrepancy is why I wish to run further tests and acquire more precise information about the refresh rate being used. I am performing this testing according to a request in a previous thread [4]. If you have any questions about my testing, please let me know. Denver 1. http://www.vrdevelopers.de/content/view/15/44/ 2. http://www.nirsoft.net/utils/nircmd.html 3. http://www.intellectualheaven.com/default.asp?BH=projects&H=strace.htm 4. http://www.winehq.org/pipermail/wine-devel/2008-March/063150.html

5 6

Summer of code 2008 - cmd.exe compatibility?
by Ann & Jason Edmeades 04 Mar '08

04 Mar '08

Hiya, Out of interest, what is meant by improving cmd.exe compatibility? Jason

3 3

Only three DLLs still failing tests!
by Dan Kegel 04 Mar '08

04 Mar '08

For me, only user32, gdi32, and urlmon are failing tests on linux these days. And there's only one failure in urlmon: stream.c. Jacek, can you have a look at that urlmon failure? It'd be cool to be down to just two dlls with test failures! - Dan

2 2

Wine preloader redux
by Dan Kegel 04 Mar '08

04 Mar '08

Say, it looks like at some point in the past, an alternate approach was looked at for reserving special addresses: http://bugzilla.kernel.org/show_bug.cgi?id=2255 If that kernel issue were resolved, would that let us get rid of the preloader?

3 9

Summer of code 2008, looking for volunteers
by Maarten Lankhorst 04 Mar '08

04 Mar '08

Hi all, I'm planning on being administrator for wine project with the summer of code 2008. I'm looking for mentor volunteers. If you don't know what that is read take some time to read through http://code.google.com/soc/2008/faqs.html If anyone is interested, please contact me privately. I'm also looking for project ideas, if anyone has an idea for a project for the summer of code, please update http://wiki.winehq.org/SummerOfCode . I would prefer projects that can be done by small changes at a time, like implementing changes to get an application to work, instead of something dractic like a dib engine. It should preferably be doable in 2 to 3 months by someone who doesn't have a lot of wine experience yet. I'm also looking for people who want to help out in other ways, like updating the wiki page and creating some additional information that would be useful to students. Cheers, Maarten.

2 1

Request for comments on listview patch which was rejected.
by Peter Dons Tychsen 04 Mar '08

04 Mar '08

Hello Devs. I sent in this listview patch some while ago, but it was silently rejected (like most of my patches :-)). Before i re-send it, could someone take a peak at it and tell me what is wrong? It looks quite sober to me... /p

2 1

Bugzilla's down again
by Austin English 03 Mar '08

03 Mar '08

Someone with access care to reset mysql? -Austin

3 3

Building dlls/oleaut32/tests/olepicture.c under Cygwin?
by Dan Kegel 03 Mar '08

03 Mar '08

I tried building dlls/oleaut32/tests/olepicture.c on Windows using cygwin, but ran into a couple small problems. The main problem is: /cygdrive/c/DOCUME~1/Liz/LOCALS~1/Temp/ccXL7SF3.o:olepicture.c:(.text+0x18e5): undefined reference to `_IPictureDisp_Invoke' That sounds fishy - is that test using a wine-specific shortcut? If so, what's the kosher windows way to do what it's doing? Here's the procedure I followed: 1. Download and run the installer from http://cygwin.com Use it to install gcc and git 2. Open a cygwin window 3. Grab a copy of the Wine sources using git as normal 4. cd wine/dlls/oleaut32/tests 5. to avoid conflicts between the win32 headers from wine and from cygwin, just use the cygwin ones. But we do have to copy one header from wine: mkdir -p include/wine cp ../../../include/wine/test.h include/wine 6. Try compiling and linking with $ gcc -DSTANDALONE -Iinclude olepicture.c -mwindows -loleaut32 -lole32 -luuid This fails with all sorts of errors about LOGFONTA. That's because the include lines in olepicture.c are in the wrong order! Edit olepicture.c and change the lines #include <winuser.h> #include <wingdi.h> to read #include <wingdi.h> #include <winuser.h> 7. Try compiling again. Now you fail with a handful of errors like /cygdrive/c/DOCUME~1/Liz/LOCALS~1/Temp/ccXL7SF3.o:olepicture.c:(.text+0x18e5): u ndefined reference to `_IPictureDisp_Invoke' Seems like a portability problem in tests/olepicture.c.

3 5

Next big app(s) to try?
by Dan Kegel 03 Mar '08

03 Mar '08

Now that Adobe Photoshop CS2 is running kind of well (there are bugs that need fixing, but I'm trying to look ahead a bit), what big app(s) are worth focusing on next? Using http://wiki.winehq.org/LinuxApplicatonRequestSurvey, skipping Photoshop (which we should continue to fix up) and the ones that are either too hard, have native versions, or are probably something Codeweavers might already be doing, and adding in good old Framemaker (so close to working we might want to go for it just for the goodwill from all those tech writers), I think that leaves about seven big ticket apps, in rough order of popularity: http://wiki.winehq.org/AdobeDreamweaver iTunes http://wiki.winehq.org/AdobeIllustrator http://wiki.winehq.org/AdobeFlash http://wiki.winehq.org/AdobePremiere http://wiki.winehq.org/AdobeAcrobatPro http://wiki.winehq.org/AdobeFramemaker I've created wiki pages with trial download URLs for all but iTunes, and done a bunch of triage on them. Most of these could all use more triage and bugs filed. At some point the dust might settle, and it might become clearer which one(s) deserve to be focused on. I think Maarten is going to try iTunes, which would be great. - Dan

9 10

Re: winex11.drv: Add DefaultRefreshRates option to specify refresh ratewhen application does not
by Dmitry Timoshkov 03 Mar '08

03 Mar '08

"Denver Gingerich" <denver(a)ossguy.com> wrote: > This patch allows the user to specify a list of default refresh > rates to use at particular resolutions to override the default > behavior that chooses the refresh rate based on whichever mode > is first in the list for a given resolution. The list is specified > by populating the X11 Driver/DefaultRefreshRates registry key with > a semicolon-delimited list of resolution, refresh rate pairs. What's really needs to be done is writing the tests to investigate what Windows does in that case, and make the tests pass in Wine. -- Dmitry.

2 3

Re: [PATCH 1/4] rpcss: Implement endpoint-mapper server using DCE/RPC.
by Alexandre Julliard 03 Mar '08

03 Mar '08

Robert Shearman <rob(a)codeweavers.com> writes: > --- > include/Makefile.in | 2 + > include/sharedidl/dcetypes.idl | 88 ++++++++++++ > include/sharedidl/epm.idl | 113 ++++++++++++++++ > programs/rpcss/Makefile.in | 3 + > programs/rpcss/epm.idl | 19 +++ > programs/rpcss/epmp.c | 291 > ++++++++++++++++++++++++++++++++++++++++ > programs/rpcss/rpcss_main.c | 54 +++++--- > 7 files changed, 550 insertions(+), 20 deletions(-) > create mode 100644 include/sharedidl/dcetypes.idl > create mode 100644 include/sharedidl/epm.idl > create mode 100644 programs/rpcss/epm.idl > create mode 100644 programs/rpcss/epmp.c That sharedidl stuff is ugly, we really have to find a way to make this work with the idl files in include/wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] shlwapi/tests: Move the function pointers to the string test functions where they are initialized and used.
by Alexandre Julliard 03 Mar '08

03 Mar '08

Francois Gouget <fgouget(a)free.fr> writes: > It makes no sense to declare the function pointers globally, but then > only initialiaze them in one function or another. This is a recipe for > adding code that calls the function pointer elsewhere... and before it > has been initialized of course. Actually the reason for declaring them globally is that 2.x gcc versions sometimes crash on local WINAPI function pointers. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/6] OLE: Remove tabs from olepicture.c test file.
by Alexandre Julliard 03 Mar '08

03 Mar '08

Please don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/1] GDI+: Implement GdipGetImageEncoders.
by Alexandre Julliard 03 Mar '08

03 Mar '08

Nathan Beckmann <nathan.beckmann(a)gmail.com> writes: > + > +/************************************************************************* > + * Encoders - > + * Implemented as dummy objects that let the user know which files are > + * supported. Actual encoding is done by OLE. > + * > + * This code is based heavily on libgdiplus (Mono): > + * > [...] What's the point of including such a large copyright notice if you are not actually copying any code? You are just defining a couple of constants, you don't need to copy that from Mono. -- Alexandre Julliard julliard(a)winehq.org

1 0

mountmgr.sys and ioctl's
by Maarten Lankhorst 03 Mar '08

03 Mar '08

Hi Alexandre, In irc we discussed ioctl's with devices, and how ioctl's go to ntdll/cdrom.c if the drive is fd backed, and to mountmgr.sys if it isn't. For itunes it needs raw disk access, but also an ioctl from mountmgr. What if we always map access to \\.\X: is always mapped to mountmgr, and let mountmanager open \\.\X:: that would be mapped to /dosdevices/x::, any ioctl, and read/write stuff that mountmgr can't handle can then be forwarded to the raw device, if available. Do you think that would be an appropiate solution? Cheers, Maarten.

2 1

Re: ntdll: Added support for Windows 2008
by Robert Shearman 03 Mar '08

03 Mar '08

Alistair Leslie-Hughes wrote: > sizeof(RTL_OSVERSIONINFOEXW), 6, 0, 0x1770, VER_PLATFORM_WIN32_NT, > {' ',0}, > 0, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 0 > + }, > + /* WIN2K8 */ > + { > + sizeof(RTL_OSVERSIONINFOEXW), 6, 0, 0x1771, VER_PLATFORM_WIN32_NT, > + {'S','e','r','v','i','c','e',' ','P','a','c','k',' ','1',0}, > + 0, 0, VER_SUITE_SINGLEUSERTS, VER_NT_SERVER, 0 > } > }; > I see Microsoft are using even more sneaky tactics these days to increase sales. They are releasing new versions of Windows with the first service pack already applied to satisfy the customers who always wait for the first service pack of a version of Windows to come out before upgrading to it. Or could this just be a copy and paste mistake? -- Rob Shearman

3 2

Re: msi: Fix cast-qual warnings
by Robert Shearman 03 Mar '08

03 Mar '08

James Hawkins wrote: > module = LoadLibraryExW( file->TargetPath, NULL, LOAD_LIBRARY_AS_DATAFILE ); > if (module) > { > - LPCWSTR guid; > - guid = MSI_RecordGetString(row,1); > - CLSIDFromString((LPWSTR)guid, &tl_struct.clsid); > + LPWSTR guid; > + guid = strdupW(MSI_RecordGetString(row, 1)); > + CLSIDFromString(guid, &tl_struct.clsid); > + msi_free(guid); > tl_struct.source = strdupW( file->TargetPath ); > tl_struct.path = NULL; I can guarantee you that CLSIDFromString does not change the input string. We should not be adding extra performance costs in the form of extra memory allocations for the sake of getting rid of a fairly harmless warning. We should fix the ones that don't require an extra allocations or other performance penalty and leave the warning off. -- Rob Shearman

1 0

re: winmm/tests: Don't use 0x55 to avoid any confusion when running with +heap.
by Dan Kegel 02 Mar '08

02 Mar '08

Hey, on that topic, there are also a bunch of other possible suspects: ./dlls/ntdll/tests/atom.c: memset(abi->Name, 0x55, 255 * sizeof(WCHAR)); ./dlls/ntdll/tests/atom.c: memset(abi->Name, 0x55, lstrlenW(testAtom1) * sizeof(WCHAR)); ./dlls/user32/tests/menu.c: memset( bmfill, 0x55, sizeof( bmfill)); ./dlls/ntoskrnl.exe/ntoskrnl.c: memset( &irp, 0x55, sizeof(irp) ); ./tools/wrc/utils.c: memset(res, 0x55, size); ./tools/widl/utils.c: memset(res, 0x55, size); ./tools/wmc/utils.c: memset(res, 0x55, size); ./server/object.c: if (ptr) memset( ptr, 0x55, size ); ./server/window.c: memset( win, 0x55, sizeof(*win) + win->nb_extra_bytes - 1 ); And 0xaa can also interfere: ./dlls/kernel32/tests/process.c: memset(&info, 0xaa, sizeof(info)); ./dlls/ddraw/tests/d3d.c: memset(outH, 0xaa, sizeof(outH)); ./dlls/comctl32/tests/listview.c: memset(&column, 0xaa, sizeof(column)); ./dlls/comctl32/tests/listview.c: memset(&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset (&item, 0xaa, sizeof (item)); ./dlls/comctl32/tests/listview.c: memset(&column, 0xaa, sizeof(column)); ./server/object.c: memset( obj, 0xaa, obj->ops->size );

3 3

re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings
by Dan Kegel 02 Mar '08

02 Mar '08

Adam Strzelecki wrote: > Visual Studio is shipping with complete sources of C CRT so you may have a look. > ;*** > ;strlen.asm - contains strlen() routine > ; > ; Copyright (c) Microsoft Corporation. All rights reserved. No, we may not have a look! And we sure as hell can't post copyrighted Microsoft source code on this mailing list! - Dan

5 7

Heading towards a fixed function pipeline replacement
by Stefan Dösinger 02 Mar '08

02 Mar '08

Hi, Due to the bad weather I had some spare hacking time this weekend, and I've done some work and investigation on a fixed function pipeline replacement. The product of that is a hacky fixed function pipeline replacement via GL_ATI_fragment_shader(*). Functionality wise the code is doing pretty good, it should support everything the current GL_ARB_texture_env_combine supports on ATI cards, although I didn't test it much yet and it is most likely buggy. However, integration-wise it is a disaster at this point, as I've focused on the GL functionality for now. However, I have some roadmap for integrating this in Wine now. Essentially I'm going to modify the state table and shader backends a bit: -> Make the state table a property of the shader model: Each pipeline implementation has its own state dependencies and ways to load states, so it is pointless to use one static table. The table will remain static, but there will be multiple tables, selected at device creation time -> As a consequence, make the current "none" shader backend a backend for the current fixed function state table -> Different state implementations will be able to borrow code from each other. E.g, the ATI_fragment_shader backend can borrow vertex processing from the fixed function implementation or GL_ARB_*_program -> The current "fixed function" state table will still be able to handle d3d shaders of all kinds, at least for now. Somewhen later we might want to split fixed function and shaders up, so that whenever we have shaders we use them for fixed function processing too. But for now we still have the problem that e.g. GLSL has horribly slow shader compilation performance. On top of this work the mentioned SoC project to write a vertex shader replacement pipeline might be doable because the general infrastructure is there, and only the shader generator is needed. Feel free to comment, Stefan (*) Why this odd extension and not GLSL? We'll want it at some point anyway for better support of r200 cards(radeon 8500-9250), and as a counterpart to the GL_NV_register_combiner code on nvidia cards. GLSL has a few other tricky aspects, like per shader uniforms, so this extension is easier for the start.

1 0

Re: winmm/tests: Don't use 0x55 to avoid any confusion when running with+heap.
by Dmitry Timoshkov 02 Mar '08

02 Mar '08

"Francois Gouget" <fgouget(a)free.fr> wrote: > mmioSeek(hmmio, 0, SEEK_SET); > - memset(&ck, 0x55, sizeof(ck)); > + memset(&ck, 0x66, sizeof(ck)); > ret = mmioDescend(hmmio, &ck, NULL, MMIO_FINDCHUNK); > ok(ret == MMIOERR_CHUNKNOTFOUND || > ret == MMIOERR_INVALIDFILE, "mmioDescend returned %u\n", ret); > @@ -162,7 +162,7 @@ static void test_mmioDescend(void) > ok(ck.dwDataOffset != 0x55555555, "wrong dwDataOffset: %04x\n", ck.dwDataOffset); The 'ok' above (and 2 tests before it) will fail with your changes. -- Dmitry.

1 0

Any graphics card y'all like to see tests run on?
by Austin English 02 Mar '08

02 Mar '08

Howdy, I'm about to get a new graphics card, because my current crappy Nvidia FX 5200 doesn't support widescreen, and I just got a shiny nice new 22". So, I'm going to upgrade my graphics card. I don't have a preference, since I don't game at all, just need something that will run 1920x1040 and $200<=. So any of you d3d/ddraw guys, is there some graphics card y'all need tests run on, and don't see around often, because now's your chance... -Austin

4 5

iPod synced with iTunes v7.6!
by Maarten Lankhorst 02 Mar '08

02 Mar '08

Hi all, I got an ipod I borrowed to sync: http://www.astro.rug.nl/~lankhorst/ipod.png There are, however, 3 separate issues to work out for this to work with an unpatched version of wine, minus the patches I sent to wine-patches, and one I still need to confirm with rob. 1. I need to add detection in explorer (through hal detection) so that ipods are automatically mounted and appropiate registry keys are created (not that much work). 2. The ioctl's from dlls/ntdll/cdrom.c should really be moved to dlls/mountmgr.sys, so that IOCTL_STORAGE_GET_DEVICE_NUMBER will always be called with a proper implementation. 3. I need to add raw device access (access to /dev/sdb, if the ipod is mounted on /dev/sdb2), through CreateFile(\\USBSTOR#..........) 1&3 won't be too hard to solve within a few days, but I'm not 100% sure how to do 2. Cheers, Maarten.

2 1

Re: kernel32 & winelib: Don't test string size in CompareStringW for null terminated strings
by Robert Shearman 01 Mar '08

01 Mar '08

Adam Strzelecki wrote: > During playing with installing Visual Studio 2005 with WINE I found > out that WINE's MSI is spending lot of time inside lstrcmpW. With Mac > OS X process sampler I checked that actually 60-70% of CompareStringW > is wine_compare_string, rest is rest of function body, which is in > case 2 strlenW calls (inline). > I believe this isn't necessary, moreover most of compares in MSI are > non-matching on first few characters, however with current > implementation we go trough all strings with strlenW regardless of > anything, which is waste in CPU cucles. > I modified both CompareStringW and wine_compare_string so they work > with -1 strings without strlenW checking before. > This saves in my testing about 20-30% of CPU cycles. You introduce a lot of complexity into the low-level helper routines. We don't want to put Win32 quirks, like -1 meaning "until the null terminator" being put into the low-level functions unless we have to. In this case, if this is the sole cause of the slowdown then you would be better off caching the length at the MSI level since the strings are bound to be accessed more than once. However, I think you'll find that this is an algorithm problem in MSI rather than a performance issue in the functions you mention. By that, I mean it is likely that one MSI query is being performed again and again and that the results should be cached. > Note also that WINE's strlenW and lstrcmpW functions are far from > perfect. Normal msvcrt or glibc string functions are far more > optimized at machine code level. This makes strong impact on WINE > parts strongly relaying on string manipulation which is in this case MSI. How do you know that the compiler isn't generating the same assembly for the functions as that used by msvcrt / glibc? Theories like these need numbers to back them up. -- Rob Shearman

3 2

Re: kernel32 & winex11: WaitForMultipleObjectsEx should ignore NULL handles
by Robert Shearman 01 Mar '08

01 Mar '08

Adam Strzelecki wrote: > Hi, > > In MSI dialog.c: msi_dialog_check_messages function it often happens > that is sends: > MsgWaitForMultipleObjects( 1, &handle, 0, INFINITE, QS_ALLINPUT ); > Where handle = NULL. I'm not sure if it is correct behavior. But > tracing it down I found out that kernel32 and winex11 sync functions > are not checking at all if the passes handles are not NULLs. > > So I'm not sure whether this patch is right or not, but I believe we > shouldn't bother wineserver with NULL handles!? > Yet maybe I don't understand clearly the way interserver communication > works, and sending "WaitFor" with NULL handle makes sense. Does it? No, but this is the wrong fix. You're assuming that because MSI code does action A and that causes bad effect when it does action B that the correct action is to fix B so that it doesn't have a bad effect. However, the bug could also be that action A shouldn't be done. In this case, MSI should not be calling MsgWaitForMultipleObjects with an invalid handle and in fact that barring memory corruption, this can't happen: > while (1) > { > msi_process_pending_messages( NULL ); > > if( !handle ) > break; > > /* > * block here until somebody creates a new dialog or > * the handle we're waiting on becomes ready > */ > r = MsgWaitForMultipleObjects( 1, &handle, 0, INFINITE, > QS_ALLINPUT ); > if( r == WAIT_OBJECT_0 ) > break; > } -- Rob Shearman

2 1

Wine still busted?
by Dan Kegel 01 Mar '08

01 Mar '08

Even with Alexandre's most recent fix, I'm seeing hangs on Photoshop CS2 installer, iTunes installer, and Word Perfect Office X3 installer, and Susan is seeing hangs on Dragon, all with the suspicious line $ err:ntdll:RtlpWaitForCriticalSection section 0x7bc8cf80 "rtl.c: peb_lock" wait timed out in thread 0014, blocked by 0016, retrying (60 sec)

2 1

Re: wine.inf: Create fake dll entry for dosx.exe
by Justin Chevrier 29 Feb '08

29 Feb '08

> Changelog: > > Create a fake dll entry for dosx.exe Anything wrong with this one liner? Justin Chevrier

2 1

Re: Conformance tests for LoadStringW and LoadStringA
by Christopher 29 Feb '08

29 Feb '08

wine-devel-request(a)winehq.org wrote: > Message: 3 > Date: Fri, 29 Feb 2008 12:50:53 +0100 > From: Alexandre Julliard <julliard(a)winehq.org> > Subject: Re: Conformance tests for LoadStringW and LoadStringA > To: Christopher <raccoonone(a)procyongames.com> > Cc: wine-devel(a)winehq.org > Message-ID: <87y794yo9u.fsf(a)wine.dyndns.org> > Content-Type: text/plain; charset=us-ascii > > Christopher <raccoonone(a)procyongames.com> writes: > > >> > + ok(!memcmp(copiedstring, returnedstring, (length2 + 1)*sizeof(WCHAR)), >> > + "LoadStringW returned a string that does not match the string pointed to by the pointer it returned. \ >> > + returnedstring = %ls, copiedstring = %ls", (wchar_t *)returnedstring, (wchar_t *)copiedstring); >> > > You cannot cast a WCHAR* to a wchar_t*. > > -- Alexandre Julliard julliard(a)winehq.org Thanks, I assumed they were the same since under Windows WCHAR is typedef'ed as wchar_t. Is the proper way to handle this to use WideCharToMultiByte() on returnedstring and copiedstring, and then pass the converted (multibyte) strings to ok()? Christopher Berner

1 0

Re: kernel32: Forward fiber local storage APIs to thread local storage equivalents.
by Paul Chitescu 29 Feb '08

29 Feb '08

Actually a lot of programs fail to start since the addition of these stubs. In particular anything that uses MSVCRT80. This is a major regression. Most applications seem to live a happy life without fiber local storage - is there one that would benefit from it? On Fri, 29 Feb 2008, Hans Leidekker wrote: > > Photoshop CS2 fails to start after the Fls* stubs were added. This patch > makes it start again but I'm not enough of an expert on this matter to say > if this is the right thing to do. > > -Hans > > Changelog > Forward fiber local storage APIs to thread local storage equivalents.

1 0

Re: msi: ACTION_RegisterProduct store all InstallProperties
by James Hawkins 29 Feb '08

29 Feb '08

On Fri, Feb 29, 2008 at 9:13 AM, Adam Strzelecki <ono(a)java.pl> wrote: > Hi, > > WINE is writing properties such as Language or VersionMajor only to > Uninstall key in ACTION_RegisterProduct, while MSI_GetProductInfo is > trying to read those from InstallProperties key. > > So this patch duplicates all properties written into MSI product > Uninstall key, also to InstallProperies. > This is normal behavior I can see in Windows XP's MSI, as properties > are duplicated in both Uninstall and InstallProperties. > Please do not accept this patch. I'm trying to clean up the publishing code, and without tests to prove this case, it should not go in. The tests that do exist show that the properties are written into the Uninstall key on RegisterProduct, but not the product key. -- James Hawkins

1 0

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [2/2]
by James Hawkins 29 Feb '08

29 Feb '08

On Fri, Feb 29, 2008 at 12:29 AM, Erich Hoover <ehoover(a)mines.edu> wrote: > Patch Originally From: > Louis Lenders > Description: > This patch adds conformance tests for WritePrivateProfileString sharing > problems. The patch was created by Louis Lenders and extensively tested, > but never submitted (see Bug #5024). Please note that a couple of the tests > now fail because cached profile information is returned, resolving that > problem is outside the scope of these patches. > Changelog: > kernel32: Test for WritePrivateProfileString Sharing Permissions > If a test fails, it has to be wrapped in todo_wine, else make test will fail. -- James Hawkins

2 3

Visual Studio 2005 installation finally works with WINE
by Adam Strzelecki 29 Feb '08

29 Feb '08

Hi, Hmm.. I think my last mail didn't manage to get into the list because of too big image attachements, sorry. If it does, I'm sorry for dupes. I just want to mention that I've managed to install Visual Studio 2005 completely with WINE. 1) installed "vcrun6" (with winetricks) 2) applied 1 patch from http://bugs.winehq.org/show_bug.cgi?id=8439#c3 (Required for overall installation) 3) applied patched from http://appdb.winehq.org/appview.php?iVersionId=3754 (Required for .NET 2.0 installation) 4) applied "msi: ACTION_RegisterProduct store all InstallProperties" patch from wine-patches I've sent recently (Without this patch Visual Studio 2005 will think that MS XML 6.0 and some others is still uninstalled!) Installation goes without problem, however running "devenv.exe" causes several problems with .NET 2.0 packages and crashes a lot :( too bad. Most crashes and errors are because of few missing WINE API functions, and incomplete .NET 2.0 support. Still I think WINE's close to run Visual Studio! which will be great news for multi-platform developers. See attached screenshots from my MacBook Pro running OSX 10.5.2 at: http://bugs.winehq.org/show_bug.cgi?id=8439 Cheers, -- Adam Strzelecki |: nanoant.com :|

1 0

Visual Studio 2005 installation finally works with WINE
by Adam Strzelecki 29 Feb '08

29 Feb '08

Hi, I just want to mention that I've managed to install Visual Studio 2005 completely with WINE. 1) installed "vcrun6" (with winetricks) 2) applied 1 patch from http://bugs.winehq.org/show_bug.cgi?id=8439#c3 (Required for overall installation) 3) applied patched from http://appdb.winehq.org/appview.php?iVersionId=3754 (Required for .NET 2.0 installation) 4) applied "msi: ACTION_RegisterProduct store all InstallProperties" match from patches list I just sent (Without this patch Visual Studio 2005 will think that MS XML 6.0 and some others is still uninstalled!) Installation goes without problem, however running "devenv.exe" causes several problems with .NET 2.0 packages and crashes a lot :( too bad. Most crashes and errors are because of few missing WINE API functions, and incomplete .NET 2.0 support. Still I think WINE's close to run Visual Studio! which will be great news for multi-platform developers. See attached screenshots from my MacBook Pro running OSX 10.5.2. Cheers, -- Adam Strzelecki |: nanoant.com :|

1 0

New winetricks 20080226: adds dotnet11 verb
by Dan Kegel 29 Feb '08

29 Feb '08

In honor of .net 1.1 installing on today's git, here's a version of winetricks that knows how to grab and run the installer. Amusingly, I noticed that there are dozens of scripts out there that do this... it seems to be not uncommon in the windows world. As always, winetricks is at http://kegel.com/wine/winetricks and its source repository is at http://winezeug.googlecode.com BTW if anybody has any other small whiny things that almost but not quite fit in winehq, I'd be happy to consider hosting them in the winezeug repository. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 15

Re: Conformance tests for LoadStringW and LoadStringA
by Alexandre Julliard 29 Feb '08

29 Feb '08

Christopher <raccoonone(a)procyongames.com> writes: > + ok(!memcmp(copiedstring, returnedstring, (length2 + 1)*sizeof(WCHAR)), > + "LoadStringW returned a string that does not match the string pointed to by the pointer it returned. \ > + returnedstring = %ls, copiedstring = %ls", (wchar_t *)returnedstring, (wchar_t *)copiedstring); You cannot cast a WCHAR* to a wchar_t*. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Move 16-bit printing functions to printdrv16.c.
by Alexandre Julliard 29 Feb '08

29 Feb '08

Robert Shearman <rob(a)codeweavers.com> writes: > --- > dlls/gdi32/Makefile.in | 1 + > dlls/gdi32/printdrv.c | 752 > +--------------------------------------------- > dlls/gdi32/printdrv16.c | 779 > +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 783 insertions(+), 749 deletions(-) That won't work, some of these functions are exported from gdi32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dxdiagn: Fix the variable that the result of GetFileVersionInfoW is assigned to in DXDiag_AddFileDescContainer.
by Paul Vriens 29 Feb '08

29 Feb '08

Robert Shearman wrote: > --- > dlls/dxdiagn/provider.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Rob, Is there a need to have it assigned, as the next line overwrites boolret again? -- Cheers, Paul.

2 1

Re: [PATCH] shlwapi: Handle PathCanonicalize with too long paths
by Robert Shearman 29 Feb '08

29 Feb '08

Marcus Meissner wrote: > lpszPath) > { > WCHAR szPath[MAX_PATH]; > WCHAR szBuff[MAX_PATH]; > - MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); > + DWORD le = GetLastError(); > + int ret = MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); > + > + if (!ret) { > + FIXME("Failed to convert string to widechar (too long?), LE %d.\n", GetLastError()); > + SetLastError (le); /* failure does not change Lasterror, see testcase. */ > + return FALSE; > + } > Hi Marcus, FIXME should be used for unimplemented functionality, not for highlighting application bugs that will happen on Windows too. WARN would be more appropriate here. -- Rob Shearman

1 0

GSoC project ideas
by Kai Blin 29 Feb '08

29 Feb '08

Hi, as promised, I'll start off this thread with the ideas we have on the wiki page [1] right now: * Implementing a WinePluginApi so other programs can use Windows DLLs inside of Linux apps * Improving our HTML/Win32 Help viewers. * Implementing the ASIO audio infrastructure for Cubase * Implement the MS Wsock dll (dlls/mswsock), an enhanced winsocket implementation * Valgrind and Wine integration (see: Wine_and_Valgrind) * Complete the Wine Web browser (aka. Internet Explorer) ie. frame controls, toolbar, status bar * Full URLMoniker implementation. (IE working with builtin urlmon.dll) * Implement transacted mode for OLE32 Storage (STGM_TRANSACTED) * Improve cmd.exe compatibility * Get Mozilla compiling as a Winelib application (http://www.winehq.org/site/winelib#mozilla) * Run the Mauve Java test suite against Sun's Windows JRE, and file bugs / write test cases in C / fix anything it finds * Run the MDAC conformance test suite against Microsoft's MDAC, and file bugs / write test cases in C / fix anything it finds * pick some real-world app or game that doesn't work well, and improve Wine so it installs and runs the app better. (Some good examples might be Photoshop, Visual Basic, a game etc) * pick a Windows feature that is incomplete in Wine, and improve the feature and its conformance tests. (Some good examples might be riched20, DirectPlay, etc) Feel free to add your own project ideas, maybe elaborate a bit on the deliverables of the idea. Cheers, Kai [1] http://wiki.winehq.org/SummerOfCode -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

8 14

Anybody has a patch for implementing WriteFileGather Kernel32.dll
by Michel Jacques 28 Feb '08

28 Feb '08

Hello, I'm looking for an implementation of WriteFileGather in Kernel32.dll. Anybody has a candidate? Thanks in advance, Michel Jacques

3 2

Re: Spelling fixes (replace iff with if)
by Stefan Dösinger 28 Feb '08

28 Feb '08

Am Donnerstag, 28. Februar 2008 18:19:28 schrieb Vitaly Lipatov: > Changelog: > - replace 'iff' with 'if' (just a spelling fixes) The usual meaning of iff is "if and only if", so its not necessarily a typo

1 0

Re: [2/10] WineD3D: Subclass queries
by Alexandre Julliard 28 Feb '08

28 Feb '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index d1ab9a3..9dff960 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -1143,6 +1143,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > IWineD3DQueryImpl *object; /*NOTE: impl ref allowed since this is a create function */ > HRESULT hr = WINED3DERR_NOTAVAILABLE; > + const IWineD3DQueryVtbl *vtable; > > /* Just a check to see if we support this type of query */ > switch(Type) { > @@ -1161,6 +1162,7 @@ static HRESULT WINAPI IWineD3DDeviceImpl_CreateQuery(IWineD3DDevice *iface, WINE > */ > FIXME("(%p) Event query: Unimplemented, but pretending to be supported\n", This); > } > + vtable = &IWineD3DEventQuery_Vtbl; > hr = WINED3D_OK; > break; So what is vtable set to in the other cases? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [4/10] D3D9: Don't use C casts to get the d3d9impl from IDirect3D9
by Alexandre Julliard 28 Feb '08

28 Feb '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This patch adds an inline conversion function similar to the ones used > in dinput. This is needed to implement IDirect3D9Ex, which uses a 2nd > vtable on the same object IDirect3D9Ex inherits from IDirect3D9, so you shouldn't need a 2nd vtable. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Spelling fixes (replace iff with if)
by Dan Kegel 28 Feb '08

28 Feb '08

lav at etersoft.ru wrote: > - replace 'iff' with 'if' (just a spelling fixes) 'iff' is shorthand for 'if and only if'. http://en.wikipedia.org/wiki/If_and_only_if So many of those 'typos' might actually be correct. Careful! - Dan

2 1

Re: [Wine] How about this replacement of WINE.
by Dan Kegel 28 Feb '08

28 Feb '08

On Thu, Feb 28, 2008 at 8:26 AM, bussuser <wineforum-user(a)winehq.org> wrote: > http://www.reactos.org/forum/viewtopic.php?t=5240 > > It is based on WINE and ReactOS . It's not a wine replacement; it uses wine. Better description at http://www.reactos.org/forum/viewtopic.php?t=5240 It looks like they added hooks to the linux kernel to accept windows nt syscalls. Maybe they even allow using the system's normal shared library loader instead of Wine's special one. This is something I've often wanted to do, but it was way lower priority than getting wine working. I haven't looked at their project at all, no idea if it was done well. - Dan

4 5

Heap corruption in crypt32?
by Dan Kegel 28 Feb '08

28 Feb '08

I strolled down memory lane a bit, and revisited the Sandra benchmark today, see http://www.winehq.org/pipermail/wine-devel/2006-December/052821.html Now the win2k version gets a lot farther. To install, first do sh winetricks vcrun2005sp1 gdiplus (Without native gdiplus, the installer complains you don't have it; without vcrun2005sp1, you get a few errors like fixme:actctx:parse_assembly_elem wrong version for assembly manifest.) The installer claims to be happy, but one sees err:module:import_dll Library CRYPTUI.dll (which is needed by L"C:\\windows\\temp\\is-KH13O.tmp\\certmgr.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\temp\\is-KH13O.tmp\\certmgr.exe" failed, status c0000135 Could not get handle to service. on the console. Worse, when the app starts up, you get a heap error: err:heap:HEAP_ValidateInUseArena Heap 0x7f000000: in-use arena 0x7f02e2e0 next block has PREV_FREE flag err:heap:HEAP_ValidateInUseArena Heap 0x7f000000: bad back ptr 0x1c9ba51e for arena 0x7f02e798 I suppose that could be a result of cryptui being missing, but I ran it under valgrind anyway. This turned up interesting items like ==20325== Invalid read of size 1 ==20325== at 0x46F5E49: HEAP_CreateFreeBlock (heap.c:486) ==20325== by 0x46F621D: HEAP_ShrinkBlock (heap.c:575) ==20325== by 0x46F7979: RtlAllocateHeap (heap.c:1228) ==20325== by 0x5C60B74: new_object (handle.c:441) ==20325== by 0x5C6B1CD: new_key (rsaenh.c:830) ==20325== by 0x5C6C9DB: RSAENH_CPImportKey (rsaenh.c:2464) ==20325== by 0x4B4324A: CryptImportKey (crypt.c:1767) ==20325== by 0x4F2DCDC: CRYPT_ImportRsaPublicKeyInfoEx (encode.c:3923) ==20325== by 0x4F2DA3B: CryptImportPublicKeyInfoEx (encode.c:3955) ==20325== by 0x4F183FA: CRYPT_VerifyCertSignatureFromPublicKeyInfo (cert.c:1641) ==20325== by 0x4F1B069: CryptVerifyCertificateSignatureEx (cert.c:1723) ==20325== by 0x4F1EDCD: CRYPT_CheckSimpleChain (chain.c:744) ==20325== Address 0x7f02ecf8 is not stack'd, malloc'd or (recently) free'd quite early in the run (well before the heap errs). Juan, what do you make of it? Might this be a real bug in crypt32 or our heap? - Dan

2 1

Re: winejoystick.drv: Add axis remapping support
by Vitaliy Margolen 28 Feb '08

28 Feb '08

Adolfo R. Brandes wrote: > Greetings! > > The purpose of this patch is to add registry axis remapping and POV > hat support to winejoystick.drv, much like what's already in place for > dinput/joystick_linux.c. I needed this for X-Wing Alliance > (http://appdb.winehq.org/objectManager.php?sClass=application&iId=2110), > which recognizes my Thrustmaster Top Gun Fox 2 Pro USB joystick, but > not the POV hat and with the Rudder and Throttle axes switched around. > > It uses the following conventions: > > HKCU\Software\Wine\Joystick\<joyname> = <axeslist> > > or > > HKCU\Software\Wine\AppDefaults\app.exe\Joystick\<joyname> = <axeslist> > > Where <joyname> is the device name (as shown in jstest), and > <axeslist> is a comma-separated list of axis names. However, in > contrast to joystick_linux.c, the axis names are the same as in > jstest. For example, in my case jstest reports: Don't do that. Keep it uniform. As-is it's a pain to configure. You want to introduce even more? First few general notes about your patch - do not mix tabs and spaces! Set tab width to be _always_ 8 spaces! For best results just don't use tabs. Do not change formating, of the function unless you changing big part of it and you changing it to default Wine formating (4 spaces, curly brackets on their own line). > +static char *axis_name(char *str, unsigned char type, int len) { > + switch(type) { > + case ABS_X: > + memcpy(str,"X",len - 1); > + break; > + case ABS_Y: The way you using this function it makes much more sense to return static text ex: static const char *axis_name(unsigned char type) { switch (type) { case ABS_X: return "X"; case ABS_Y: return "Y"; case ABS_Z: return "Z"; default: return "?"; } } BTW what will that "?" do? I don't see you comparing it against anything. > + else > + ERR("Not all joystick axes mapped: %d axes, %d arguments\n", nrOfAxes, j); Disabling axis might not be a bad thing, especially for testing. I don't think you need to worry about extra axis on the device that are not mapped to anything. > + for (i = 0; i < nrOfAxes; i++) > + switch(axis_map[i]) { > + case ABS_HAT0X: > + case ABS_HAT0Y: > + lpCaps->wCaps |= JOYCAPS_HASPOV; > + break; > + } You need both X and Y axis for it to work. You have to check that both are present. Also what about multiple POVs? Here you checking for only one. > switch(nrOfAxes) { > - case 6: lpCaps->wCaps |= JOYCAPS_HASV; > - case 5: lpCaps->wCaps |= JOYCAPS_HASU; > - case 4: lpCaps->wCaps |= JOYCAPS_HASR; > - case 3: lpCaps->wCaps |= JOYCAPS_HASZ; > - /* FIXME: don't know how to detect for > - JOYCAPS_HASPOV, JOYCAPS_POV4DIR, JOYCAPS_POVCTS */ > + case 6: > + lpCaps->wCaps |= JOYCAPS_HASV; > + lpCaps->wVmax = 0xFFFF; > + case 5: > + lpCaps->wCaps |= JOYCAPS_HASU; > + lpCaps->wUmax = 0xFFFF; > + case 4: > + lpCaps->wCaps |= JOYCAPS_HASR; > + lpCaps->wRmax = 0xFFFF; > + case 3: > + lpCaps->wCaps |= JOYCAPS_HASZ; > + lpCaps->wZmax = 0xFFFF; Now that you can remap axis it's not guaranteed that 6th axes is the speed and so on. Vitaliy.

2 2

Valgrind can't *quite* handle Adobe InDesign yet
by Dan Kegel 28 Feb '08

28 Feb '08

http://bugs.kde.org/show_bug.cgi?id=126389 means that valgrind can't yet handle apps that throw exceptions during regular operation. Like, say, Adobe InDesign's installer. I would like to valgrind that to track down http://bugs.winehq.org/show_bug.cgi?id=11757 but I can't because valgrind doesn't handle fxrestor. I think, anyway... - Dan

2 3

schroedinger 1.0 (fast implementation of Dirac video codec) released
by Dan Kegel 28 Feb '08

28 Feb '08

http://lwn.net/Articles/271058/ "Decodes HD720/25p in real-time on a Core Duo laptop" Yum. I'd like to see free codecs like this bundled with wine sometime.

1 0

Re: Alistair Leslie-Hughes : msvcrt: Implement wcscpy_s.
by James McKenzie 28 Feb '08

28 Feb '08

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 00609d5e7824a117084f3f4b75e1aec03b60102a > URL: http://source.winehq.org/git/wine.git/?a=commit;h=00609d5e7824a117084f3f4b7… > > Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed Feb 27 19:58:04 2008 +1100 > > msvcrt: Implement wcscpy_s. > > + > + if(size > numElement) > Is this correct? I think it should be different, maybe if (size<numElement)? > + { > + wcDest[0] = 0; > + return MSVCRT_EINVAL; > + } > + > + if(size > numElement) > This and the one above are the same. > + size = numElement; > + > + memcpy( wcDest, wcSrc, size*sizeof(WCHAR) ); > + > + return 0; > +} > > > >

3 3

Re: [AppDB] Add accessible link to front page
by Detlef Riekenberg 28 Feb '08

28 Feb '08

On Mi, 2008-02-27 at 14:18 +0100, Alexander Nicolaysen Sørnes wrote: > Add a 'home' link to the top of the AppDB menu to make the front page > more accessible. > $g = new htmlmenu("AppDB"); > + $g->add('Home', BASE.'index.php'); What is more accessible in "AppDB" -> "Home" compared to "WineHQ Menu" -> "AppDB"? I see no difference. -- By by ... Detlef

3 2

Wineserver crash in inotify code
by Dan Kegel 27 Feb '08

27 Feb '08

http://bugs.winehq.org/show_bug.cgi?id=11746 may explain a few mysterious wineserver crashes I saw a few weeks ago. Anyone feel like diving in to this one? It's probably a rat's nest of twisty linked lists, and a node isn't getting removed properly from all the lists it's in when it's freed, or something.

3 2

Re: [Wine] Re: Windows Kernel & Executive implementation
by Volodymyr Shcherbyna 27 Feb '08

27 Feb '08

I am not sure that ReacOS is a good example. Quite a big amount of code in ReactOS contains leaked code of Windows (from Windows 2k). Recently I did a research, since I have access to Windows code(code premium subscription), I am able to compare things. 2008/2/23, Fireball <wineforum-user(a)winehq.org>: > > You could have a look at ReactOS about this (www.reactos.org). But anyway, > Wine's way of supporting this will [most probably] be different from > reactos' way. > > > > > > -- with best regards, Volodymyr

4 5

New winetricks 20080227: new verbs vbrun3, vbrun4, vbrun5, vbrun6
by Dan Kegel 27 Feb '08

27 Feb '08

Detlef contributed verbs vbrun3 and vbrun4, thanks! And I added vbrun5 and vbrun6 as the preferred synonym for the existing verbs vbvm5 and vbrun60. That should be easier. As always, winetricks is at http://kegel.com/wine/winetricks and its source repository is at http://winezeug.googlecode.com

2 2

Bug for icons in toolbar (and how to deal with this in bugzilla)
by Paul Vriens 27 Feb '08

27 Feb '08

Hi, This is about 'autoruns' from SysInternals (Microsoft) The icons on the first row of buttons look fine. All other rows however show the icons below the position they should actually be. I've looked at our bugzilla and found two bugs that look the same: http://bugs.winehq.org/show_bug.cgi?id=6948 http://bugs.winehq.org/show_bug.cgi?id=8813 Both are for different applications. Should I open a new one for 'autoruns' or use one of the existing ones? -- Cheers, Paul.

2 1

Re: msxml3:Implement wcscpy_s (try 4)
by Huw Davies 27 Feb '08

27 Feb '08

On Wed, Feb 27, 2008 at 09:11:17PM +1100, Alistair Leslie-Hughes wrote: > Hi, > Corrected the spec file. > > Changelog: > msxml3: Implement wcscpy_s > > Best Regards > Alistair Leslie-Hughes > > From 5438165a1a5b3a2683948b93e34e9017f4958e61 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 27 Feb 2008 19:58:04 +1100 > Subject: [PATCH] Implement wcscpy_s > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msvcrt/msvcrt.spec | 1 + > dlls/msvcrt/tests/string.c | 45 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/wcs.c | 41 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 87 insertions(+), 0 deletions(-) Note that the subject line should be 'msvcrt:...'. I guess Alexandre will fix this. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Wine hostmask for Freenode IRC
by Kai Blin 27 Feb '08

27 Feb '08

Hi folks. so what was the process of getting a wine/developer hostmask on freenode? I'll be hanging out on the #gsoc IRC channel, I'd like to make it a bit more obvious for students what project I mentor for. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

4 6

Re: X developer's conference, April 16-18
by Stefan Dösinger 27 Feb '08

27 Feb '08

Hi, I'm picking up that topic again. I lost the original mail, so I apologize for the lost in-reply-to references. I think we have a few topics to talk to the X people about. If nobody else volunteers I could go to the conference personally, however, I'd need some support financing the travel costs. However, I'm European, so it might work better for someone local in the US. A few proposed topics: * Relative mouse movements * A few new GL extensions. Only partially concerns Xorg, but I think it is reasonable to present them there in the hope that ATI, Nvidia and Mesa people are there. -> Flat shading vertex colors -> sRGB writing without blending -> Texture rectangles with normalized coords -> GLSL support for some D3D shader instructions(mova, lit) -> More widespread support for a few existing extensions * Other things?

6 6

Re: msxml3: Implemented wcscpy_s (try 3)
by Dmitry Timoshkov 27 Feb '08

27 Feb '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > Corrected comparisons, and error message in test. > diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec > index d6cffcb..ebd718c 100644 > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s What's happened to the spec entry fix? -- Dmitry.

2 1

.net 1.1 installs now!
by Dan Kegel 27 Feb '08

27 Feb '08

Hey, http://bugs.winehq.org/show_bug.cgi?id=11678 is fixed, and VCToolkitSetup.exe now installs for me! Still more to do before .net 1.1 apps run, see http://bugs.winehq.org/show_bug.cgi?id=11742 And there are a few ugly looking nonfatal problems running the .net 1.1 installer, but they can wait...

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel