- wine-devel - winehq.org

Help me(Ajudem-me)C compiler cannot create executables
by flavio melo 26 Feb '08

26 Feb '08

Hello I'm Flavio Melo(brazilian)! Well, i use the ubuntu 7.04, and there is any time that i try use the wine,but i no get install it, i can't for net because i haven't internet (repository), but i download the file wine-0.9.54 of your site in the other computer(in my job), and, i follow the instruccions(i think there are corrects, get it read manuals) and my terminal said: ---------------------------------------------------------------------------- flavio@Discipulo:~$ cd wine flavio@Discipulo:~/wine$ cd tools flavio@Discipulo:~/wine/tools$ ./wineinstall WINE Installer v0.75 ~/wine ~/wine/tools Running configure... configure: creating cache config.cache checking build system type... i686-pc-linux-gnulibc1 checking host system type... i686-pc-linux-gnulibc1 checking whether make sets $(MAKE)... yes checking for gcc... gcc checking for C compiler default output file name... configure: error: C compiler cannot create executables See `config.log' for more details. Configure failed, aborting install. flavio@Discipulo:~/wine/tools$ ----------------------------------------------------------------------------- I wrote to you for know if you can help me(Please), what i must make for my gcc compile? Thank for attencion! Meu testemunho... http://www.semearcristo.net/art/art_00007.aspx?idPag=1&idReg=1&idCat=6&strB… --------------------------------- Abra sua conta no Yahoo! Mail, o único sem limite de espaço para armazenamento!

3 2

Re: comctl32: rebar[1/4]: an implementation of RB_SIZETORECT (fixes bug #7774)
by John Klehm 26 Feb '08

26 Feb '08

Missing patch On Tue, Feb 26, 2008 at 3:36 PM, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > I couldn't work out the algorithm to make it pixel-for-pixel identical > as on Windows but this function implements the general idea that I hope > will work for applications. > > >

1 0

re: gdi32: Protect against short sized LOGPALETTE in CreatePalette.
by Dan Kegel 26 Feb '08

26 Feb '08

Hi, your patch uses IsBadReadPtr(), but that function is deprecated in favor of using an exception handler. See http://www.winehq.org/pipermail/wine-devel/2006-April/046560.html Here's an example (sorry it's a messy one, it's just the first one google found): http://www.winehq.org/pipermail/wine-patches/2004-November/013791.html Please try recoding using that approach. If you have trouble getting this patch in, you might want to file a bug at http://bugs.winehq.org for your problem and link to your patch; that will record the problem so somebody else can pick it up later. - Dan

3 2

re: gdi32: Patch review request
by Dan Kegel 26 Feb '08

26 Feb '08

Daniel Mario Vega wrote: >A few days ago I sent 2 patches for gdi32 to wine-patches >that passed unnoticed. I would like if someone could give > me some feedback on them. OK. I replied to each of them just now with my guess. Don't worry, patches being ignored is normal, it just means you have to improve them if possible and resend. If you do resend them, be sure to give the same subject as last time, with '(resend)' appended if no changes made, or '(try 2)' appended if there were changes, and append a note about the changes to the description.

1 0

re: gdi32: StartDocA support for legacy apps with incomplete DOCINFOA parameter.
by Dan Kegel 26 Feb '08

26 Feb '08

This patch looks nice, but it could use a conformance test. Please add one and resend. And consider filing a bug and referring to the bug in the patch description, that never hurts. - Dan

1 0

Re: [try4] user32: cursoricon.c. Fix 16b BMP handling with BT_BITFIELD.
by Dmitry Timoshkov 26 Feb '08

26 Feb '08

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch fixes image header handling with BT_BITFIELD value in biCompression > field. 3 DWORDs of mask were included into image bits, it caused some color > troubles and image horizontal shift. Size of bitmap info structure includes > now this bytes. > Changelog: > user32.dll Fix 16b BMP handling with BT_BITFIELD. I wonder whether gcc complained loudly that 'result' may be used uninitialized. -- Dmitry.

1 1

marshalled ITypeComp
by Guillermo Winkler 26 Feb '08

26 Feb '08

Hi, I'm having some problems regarding ITypeInfo/ITypeComp implementation. IDispatch* pdisp; ITypeInfo* ptinfo; HRESULT hr = pdisp->GetTypeInfo(0, LOCALE_SYSTEM_DEFAULT, &typeinfo); hr = ptinfo->GetTypeComp(&ptcomp); pdisp is created from hr = CoCreateInstance(clsid, NULL, CLSCTX_SERVER, IID_IDispatch, (void**)&pdisp); That is, the server is an outprocess exe. In this case marshalling of ITypeComp fails in first instance because ITypeComp_fnQueryInterface (oleaut32\typelib.c) resolves on -> ITypeInfo_QueryInterface (oleaut32\typelib.c) That is not considering IID_ITypeComp as a valid alternative(but it is) if(IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid,&IID_ITypeInfo)|| IsEqualIID(riid,&IID_ITypeInfo2)) *ppvObject = This; When I fixed this, I have a different problem now: fixme:ole:DllGetClassObject CLSID: {00020425-0000-0000-C000-000000000046} IID: {D5F569D0-593B-101A-B569-08002B2DBF7A} That is PSTypeComp to be marshalled asking for factory buffer IID_IPSFactoryBuffer. I would like to follow up with someone (if available) just to be sure I'm not wasting time on the wrong track. Thanks, Guillermo

2 2

gdi32: Patch review request
by Daniel Mario Vega 26 Feb '08

26 Feb '08

Hi! A few days ago I sent 2 patches for gdi32 to wine-patches that passed unnoticed. I would like if someone could give me some feedback on them. Let me first give you some background about these patches. There is an application called "Compumap" that is a street map of some Argentine cities. It is rather popular here because some years ago it was distributed with a newspaper. The program works quite well under Wine (although the installer still has some problems), but when you try to print a map it crashes. A few weeks ago I had some free time and I decided to try to find out why it crashes. I run it through the Wine Debugger and also under a debugger in Windows XP. The problem happened to be two API calls with incomplete/invalid parameters. Windows XP returned NULL or ignore the wrong data, while Wine crashes. 1) gdi32: Protect against short sized LOGPALETTE in CreatePalette. http://www.winehq.org/pipermail/wine-patches/2008-February/050354.html This crash was caused by "CreatePalette(HDC, LOGPALETTE)" being called with a short allocated palette. Windows XP returned NULL in that case. I tried to reproduce that behavior by first checking the parameter with "IsBadReadPtr()" function. 2) gdi32: StartDocA support for legacy apps with incomplete DOCINFOA parameter. http://www.winehq.org/pipermail/wine-patches/2008-February/050357.html This issue was a call to "StartDocA(HDC, DOCINFOA)" with structure DOCINFOA not completely initialized (there is garbage in the last 2 fields). I debugged this API and found that Windows XP ignored those fields when the data "seems to be invalid". I think that the last 2 fields were introduced in Win32 and some applications ported from Win16 "forget" to clear them. I simulated Windows XP behaviour by putting some safe checks on those fields. With those 2 fixes, the application is able to print under Wine. Both patches are short and rather easy to review. I will appreciate if someone could give me some feedback on them. Thanks ... -- Daniel Mario Vega

1 0

Re: opengl32/tests: Add the trailing '\n' to an ok() call and make a spelling fix.
by Paul Vriens 26 Feb '08

26 Feb '08

Francois Gouget wrote: > --- > dlls/opengl32/tests/opengl.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/opengl32/tests/opengl.c b/dlls/opengl32/tests/opengl.c > index 3836ba7..344e2c6 100644 > --- a/dlls/opengl32/tests/opengl.c > +++ b/dlls/opengl32/tests/opengl.c > @@ -384,9 +384,9 @@ START_TEST(opengl) > > /* We shouldn't be able to create a context from a hdc which doesn't have a pixel format set */ > hglrc = wglCreateContext(hdc); > - ok(hglrc == NULL, "wglCreateContext should fail when no pixel format has been set, but it passed"); > + ok(hglrc == NULL, "wglCreateContext should fail when no pixel format has been set, but it passed\n"); > error = GetLastError(); > - ok(error == ERROR_INVALID_PIXEL_FORMAT, "expected ERROR_INVALID_PIXEL_FORMAT for wglCreateContext without a pixelformat set, but recevied %#x", error); > + ok(error == ERROR_INVALID_PIXEL_FORMAT, "expected ERROR_INVALID_PIXEL_FORMAT for wglCreateContext without a pixelformat set, but recieved %#x\n", error); So where is the spelling fix ;-) Shouldn't that be "received"? -- Cheers, Paul.

1 0

Re: d3dx9: Add IMPORTLIB to every Makefile.in [PATCH 4/9]
by Alexandre Julliard 26 Feb '08

26 Feb '08

tony.wasserka(a)freenet.de writes: >>From 881b8de1e044ff90bcb543501208a9cd879cbc16 Mon Sep 17 00:00:00 2001 > From: Tony Wasserka <tony.wasserka(a)freenet.de> > Date: Sat, 23 Feb 2008 13:55:40 +0100 > Subject: [PATCH] d3dx9: Add IMPORTLIB to every Makefile.in That shouldn't be needed, there are no such import libs on Windows. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx9: Implement D3DXCheckVersion [PATCH 1/9]
by Alexandre Julliard 26 Feb '08

26 Feb '08

tony.wasserka(a)freenet.de writes: > D3DXCheckVersion doesn't check for one specific D3DX version, but > for all that are compatible with our Wine code (i.e. d3dx9_24 to d3dx9_36) > The reasons for that were explained in these mails by me: > http://www.winehq.org/pipermail/wine-devel/2008-February/062290.html > and http://www.winehq.org/pipermail/wine-devel/2008-February/062292.html This is wrong, you should have a separate version check for each dll that checks the exact version of that dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: Implemented wcscpy_s (try 2)
by Alistair Leslie-Hughes 26 Feb '08

26 Feb '08

Hi, Is there any thing wrong with this patch? Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fpljui$nsa$1@ger.gmane.org... > Hi, > Correct msvcrt.spec file > > Changelog: > msvcrt: Implemented wcscpy_s > -------------------------------------------------------------------------------- > From 6860771cc3fc06b3da63f7c674daf71861593ef3 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 22 Feb 2008 13:48:01 +1100 > Subject: [PATCH] Implemented wcscpy_s > > --- > dlls/msvcrt/msvcrt.spec | 1 + > dlls/msvcrt/tests/string.c | 45 > ++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/wcs.c | 45 > ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 91 insertions(+), 0 deletions(-) > > diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec > index d6cffcb..7b821e6 100644 > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(ptr long wstr) MSVCRT_wcscpy_s > @ cdecl wcscspn(wstr wstr) ntdll.wcscspn > @ cdecl wcsftime(ptr long wstr ptr) MSVCRT_wcsftime > @ cdecl wcslen(wstr) ntdll.wcslen > diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c > index c6dcd34..b09d204 100644 > --- a/dlls/msvcrt/tests/string.c > +++ b/dlls/msvcrt/tests/string.c > @@ -50,6 +50,7 @@ static int* (*pmemcmp)(void *, const void *, size_t n); > static int (*pstrcpy_s)(char *dst, size_t len, const char *src); > static int (*pstrcat_s)(char *dst, size_t len, const char *src); > static int (*p_mbsnbcpy_s)(unsigned char * dst, size_t size, const > unsigned char * src, size_t count); > +static int (*p_wcscpy_s)(wchar_t *wcDest, size_t size, const wchar_t > *wcSrc); > > #define SETNOFAIL(x,y) x = (void*)GetProcAddress(hMsvcrt,y) > #define SET(x,y) SETNOFAIL(x,y); ok(x != NULL, "Export '%s' not found\n", > y) > @@ -562,6 +563,47 @@ static void test__mbsnbcpy_s(void) > dest[0], dest[1], dest[2], dest[3], dest[4], dest[5], dest[6], > dest[7]); > } > > +static void test_wcscpy_s(void) > +{ > + static const WCHAR szLongText[] = { > 'T','h','i','s','A','L','o','n','g','s','t','r','i','n','g',0 }; > + static WCHAR szDest[18]; > + static WCHAR szDestShort[8]; > + int ret; > + > + if(!p_wcscpy_s) > + { > + skip("wcscpy_s not found\n"); > + return; > + } > + > + /* Test NULL Dest */ > + ret = p_wcscpy_s(NULL, 16, szLongText); > + ok(ret == EINVAL, "p_wcscpy_s expect EINVAL got %d\n", ret); > + > + /* Test NULL Source */ > + szDest[0] = 'A'; > + ret = p_wcscpy_s(szDest, 16, NULL); > + ok(ret == EINVAL, "expected EINVAL got %d\n", ret); > + ok(szDest[0] == 0, "szDest[0] not 0\n"); > + > + /* Test invalid size */ > + szDest[0] = 'A'; > + ret = p_wcscpy_s(szDest, 0, szLongText); > + ok(ret == EINVAL, "expected ERANGE got %d\n", ret); > + ok(szDest[0] == 0, "szDest[0] not 0\n"); > + > + /* Copy same buffer size */ > + ret = p_wcscpy_s(szDest, 18, szLongText); > + ok(ret == 0, "expected 0 got %d\n", ret); > + ok(lstrcmpW(szDest, szLongText) == 0, "szDest != szLongText\n"); > + > + /* Copy smaller buffer size */ > + szDest[0] = 'A'; > + ret = p_wcscpy_s(szDestShort, 8, szLongText); > + ok(ret == ERANGE, "expected EINVAL got %d\n", ret); > + ok(szDestShort[0] == 0, "szDest[0] not 0\n"); > +} > + > START_TEST(string) > { > char mem[100]; > @@ -577,6 +619,7 @@ START_TEST(string) > SET(pstrcpy_s,"strcpy_s"); > SET(pstrcat_s,"strcat_s"); > SET(p_mbsnbcpy_s,"_mbsnbcpy_s"); > + SET(p_wcscpy_s,"wcscpy_s"); > > /* MSVCRT memcpy behaves like memmove for overlapping moves, > MFC42 CString::Insert seems to rely on that behaviour */ > @@ -599,4 +642,6 @@ START_TEST(string) > test_strcpy_s(); > test_strcat_s(); > test__mbsnbcpy_s(); > + > + test_wcscpy_s(); > } > diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c > index 92dd644..66b8907 100644 > --- a/dlls/msvcrt/wcs.c > +++ b/dlls/msvcrt/wcs.c > @@ -27,6 +27,8 @@ > #include "wine/unicode.h" > #include "wine/debug.h" > > +#include <msvcrt/errno.h> > + > WINE_DEFAULT_DEBUG_CHANNEL(msvcrt); > > > @@ -971,3 +973,46 @@ INT CDECL MSVCRT_iswxdigit( MSVCRT_wchar_t wc ) > { > return isxdigitW( wc ); > } > + > +/********************************************************************* > + * wcscpy_s (MSVCRT.@) > + */ > +INT CDECL MSVCRT_wcscpy_s( MSVCRT_wchar_t* wcDest, size_t numElement, > const MSVCRT_wchar_t *wcSrc) > +{ > + int size = 0; > + > + if(!wcDest) > + return EINVAL; > + > + if(!wcSrc) > + { > + wcDest[0] = 0; > + return EINVAL; > + } > + > + if(numElement <= 0) > + { > + wcDest[0] = 0; > + > + if(numElement < 0) > + return ERANGE; > + else > + return EINVAL; > + } > + > + size = strlenW(wcSrc) + 1; > + > + if(size > numElement) > + { > + wcDest[0] = 0; > + return ERANGE; > + } > + > + if(size > numElement) > + size = numElement; > + > + memcpy( wcDest, wcSrc, size*sizeof(WCHAR) ); > + > + return 0; > +} > + > -- > 1.5.4.1 > > -------------------------------------------------------------------------------- > >

2 1

Re: [6/6] msxml3: Tests for put_data
by Alistair Leslie-Hughes 26 Feb '08

26 Feb '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fpu31c$upv$4@ger.gmane.org... > +#if 0 > +/* For some Reason, IXMLDOMComment_put_data cannot be found even though > it can > + be exists in msxml2.h. > + */ > + /* put data Tests */ > + hr = IXMLDOMComment_put_data(pComment, _bstr_("This &is a > ; test <>\\")); > + ok(hr == S_OK, "ret %08x\n", hr ); > + > +#endif Hi, Im a little confused, IXMLDOMComment_put_data wasnt compiling on my machine, and yet Alexandre changed to include this code and now it compiles correctly? I event tried a >make clean; ./configure; make depend;make which didnt work either. Can anybody explain what was fixed? Best Regards Alistair Leslie-Hughes

2 1

Re: wininet: Fix retrieving the raw headers
by Alexandre Julliard 26 Feb '08

26 Feb '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -3059,12 +3060,14 @@ static INT HTTP_GetResponseHeaders(LPWININETHTTPREQW lpwhr) > * We should first receive 'HTTP/1.x nnn OK' where nnn is the status code. > */ > memset(buffer, 0, MAX_REPLY_LEN); > + memset(buffertoken, 0, MAX_REPLY_LEN); > if (!NETCON_getNextLine(&lpwhr->netConnection, bufferA, &buflen)) > goto lend; > MultiByteToWideChar( CP_ACP, 0, bufferA, buflen, buffer, MAX_REPLY_LEN ); > + MultiByteToWideChar( CP_ACP, 0, bufferA, buflen, buffertoken, MAX_REPLY_LEN ); That's ugly, it shouldn't be necessary to have two copies of the whole data just to parse some status codes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Valgrind results. Update for glibc-2.6.
by Dan Kegel 26 Feb '08

26 Feb '08

Today's valgrind results online at http://kegel.com/wine/valgrind/logs-2008-02-25-summary.txt http://kegel.com/wine/valgrind/logs-2008-02-25/ Nothing too special (thanks for the cleanup, James), but this is the first set of results after updating my test machine from feisty to gutsy, and I had to apply http://kegel.com/wine/valgrind/futimesat.patch to my copy of valgrind svn to handle the new glibc properly. Already reported to Valgrind; see http://sourceforge.net/mailarchive/forum.php?thread_name=a71bd89a0802240546…

3 3

Re: Add a slight delay before testing the ddraw and d3d9 visual tests
by Dmitry Timoshkov 26 Feb '08

26 Feb '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > This makes the tests pass on my pc. Perhaps there is something less hacky way like GdiFlush() which is more appropriate for this. -- Dmitry.

2 3

d3dx9_xx
by "Luis C. Busquets Pérez" 25 Feb '08

25 Feb '08

The number of functions reported in http://www.winehq.org/site/winapi_stats for the following dlls is d3dx9_24 308 d3dx9_25 311 d3dx9_26 315 d3dx9_27 315 d3dx9_28 320 d3dx9_29 320 d3dx9_30 320 d3dx9_31 317 d3dx9_32 322 d3dx9_33 322 d3dx9_34 322 d3dx9_35 322 d3dx9_36 325 Nevertheless, the correct number is d3dx9_24 320 d3dx9_25 323 d3dx9_26 327 d3dx9_27 327 d3dx9_28 332 d3dx9_29 332 d3dx9_30 332 d3dx9_31 329 d3dx9_32 334 d3dx9_33 334 d3dx9_34 334 d3dx9_35 334 d3dx9_36 336

2 1

How should we treat users on bugzilla?
by Dan Kegel 25 Feb '08

25 Feb '08

I've been seeing a lot of bugs closed as INVALID when a poor user didn't file the bug perfectly. IMHO this leads to Wine having a user-hostile reputation. Case in point: http://bugs.winehq.org/show_bug.cgi?id=11625 What can we do to reduce this kind of behavior? Maybe we should have a "three warnings" sort of policy. If somebody continues to be rude to users after being asked twice not to, we should consider taking away their Bugzilla privileges for a while. Sure, that would hurt our productivity, but it might be better to do that than to alienate our users. What do other people think? - Dan

13 28

Re: WGL: wglDeleteContext should fail on garbage handles [attempt2]
by Alexandre Julliard 25 Feb '08

25 Feb '08

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > Subject: [PATCH] wglDeleteContext should fail on a garbage hglrc. When > we receive garbage ctx->hdc is invalid which leads to a > crash. Retrieve a default DC and use it to pass hglrc to the display > driver. Luckily the opengl code maintains a list of valid opengl > contexts, so it can detect whether the hglrc is valid or not. :) If we are going to go in this direction, then the context should be made opaque in gdi32, and all calls should use the default DC. The alternative is to make the context a proper GDI handle, and have GDI check it for validity first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11drv: Distinguish left and right keys for shift, ctrl and alt.
by Alexandre Julliard 25 Feb '08

25 Feb '08

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > --- a/dlls/winex11.drv/keyboard.c > +++ b/dlls/winex11.drv/keyboard.c > @@ -1022,9 +1022,9 @@ static const WORD nonchar_key_vkey[256] = > 0, 0, 0, 0, 0, 0, 0, 0, /* FFD0 */ > 0, 0, 0, 0, 0, 0, 0, 0, /* FFD8 */ > /* modifier keys */ > - 0, VK_SHIFT, VK_SHIFT, VK_CONTROL, /* FFE0 */ > - VK_CONTROL, VK_CAPITAL, 0, VK_MENU, > - VK_MENU, VK_MENU, VK_MENU, 0, 0, 0, 0, 0, /* FFE8 */ > + 0, VK_LSHIFT, VK_RSHIFT, VK_LCONTROL, /* FFE0 */ > + VK_RCONTROL, VK_CAPITAL, 0, VK_MENU, > + VK_MENU, VK_LMENU, VK_RMENU, 0, 0, 0, 0, 0, /* FFE8 */ > 0, 0, 0, 0, 0, 0, 0, 0, /* FFF0 */ > 0, 0, 0, 0, 0, 0, 0, VK_DELETE /* FFF8 */ This is going to change the vkeys everywhere, I don't think that's correct. Things like WM_KEYDOWN have to report VK_SHIFT, not VK_LSHIFT etc. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: winex11drv: Remove special treatment for caps-lock and num-lock keys. [try-2]
by Alexandre Julliard 25 Feb '08

25 Feb '08

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > - if (vkey) > - { > - switch (vkey & 0xff) > + if (!vkey) return; > + > + /* Adjust the NUMLOCK state if it has been changed outside wine */ > + if (!(key_state_table[VK_NUMLOCK] & 0x01) != !(event->state & NumLockMask)) > { > - case VK_NUMLOCK: > - KEYBOARD_GenerateMsg( VK_NUMLOCK, 0x45, event->type, event_time ); > - break; > - case VK_CAPITAL: > - TRACE("Caps Lock event. (type %d). State before : %#.2x\n",event->type,key_state_table[vkey]); > - KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, event->type, event_time ); > - TRACE("State after : %#.2x\n",key_state_table[vkey]); > - break; > - default: > - /* Adjust the NUMLOCK state if it has been changed outside wine */ > - if (!(key_state_table[VK_NUMLOCK] & 0x01) != !(event->state & NumLockMask)) > - { > - TRACE("Adjusting NumLock state.\n"); > - KEYBOARD_GenerateMsg( VK_NUMLOCK, 0x45, KeyPress, event_time ); > - KEYBOARD_GenerateMsg( VK_NUMLOCK, 0x45, KeyRelease, event_time ); > - } > - /* Adjust the CAPSLOCK state if it has been changed outside wine */ > - if (!(key_state_table[VK_CAPITAL] & 0x01) != !(event->state & LockMask)) > - { > - TRACE("Adjusting Caps Lock state.\n"); > - KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, KeyPress, event_time ); > - KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, KeyRelease, event_time ); > - } > - /* Not Num nor Caps : end of intermediary states for both. */ > - NumState = FALSE; > - CapsState = FALSE; > + TRACE("Adjusting NumLock state (%#.2x).\n", key_state_table[VK_NUMLOCK]); > + X11DRV_send_keyboard_input( VK_NUMLOCK, 0x45, KEYEVENTF_EXTENDEDKEY, event_time, 0, 0 ); > + X11DRV_send_keyboard_input( VK_NUMLOCK, 0x45, KEYEVENTF_EXTENDEDKEY | KEYEVENTF_KEYUP, event_time, 0, 0 ); > + } > + /* Adjust the CAPSLOCK state if it has been changed outside wine */ > + if (!(key_state_table[VK_CAPITAL] & 0x01) != !(event->state & LockMask)) > + { > + TRACE("Adjusting Caps Lock state (%#.2x).\n", key_state_table[VK_CAPITAL]); > + X11DRV_send_keyboard_input( VK_CAPITAL, 0x3A, 0, event_time, 0, 0 ); > + X11DRV_send_keyboard_input( VK_CAPITAL, 0x3A, KEYEVENTF_KEYUP, event_time, 0, 0 ); > + } You still need to handle the case of caps lock or num lock keys differently, otherwise you'll generate duplicate messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

SetPixelFormat broken in 0.9.54
by bill lam 25 Feb '08

25 Feb '08

I run a opengl script that worked in 0.9.53 but crashed in 0.9.54 (and 0.9.55) I traced it failed at this line SetPixelFormat hdc;pixfmt;pfd with the following message in console: X Error of failed request: BadAccess (attempt to access private resource denied) Major opcode of failed request: 160 (Composite) Minor opcode of failed request: 1 () Serial number of failed request: 164 Current serial number in output stream: 182 Is this a known issue? ubuntu 7.10 amd64 regards,

2 1

GSOC (proposal)
by David Adam 25 Feb '08

25 Feb '08

Here are my wishes for GSOC: D3DX dlls begin to be implemented. It seems that this could be a good GSOC to implement more feature of this dll, in particular the shader compiler. In the view of wined3d, I think about vertex blending, since there are tons of game using this feature. Stefan, is this doable in the scope of GSOC? Sound should be improved also, since there are games that still crash, in despite of M. Lankhorst's great job ( dmime, quartz,.... dlls problem). And the last but not the least :D: fix the infamous warping mouse bug. I know that it is mainly a problem with X server, but maybe a wine develooper could propose a GSOC to Xorg guys to fix this. David A.

3 2

AppDB stats
by Tony Lambregts 25 Feb '08

25 Feb '08

Just a little note to all about the appdb stats. We now have 9000 application versions in the database. http://appdb.winehq.org/appdbStats.php Users: 23474 Comments: 21305 Application families: 5814 Versions: 9000 Application maintainers: 1462 Test reports: 18572 Screenshots: 6234 The Application maintainer stats is the most interesting in that we have 1462 individuals who now maintain applications. Most of these are regular users of wine and I for one really appreciate their effort in helping others. I would also like to recognize the individuals who have helped improve the AppDB code lately. Alexander Nicolaysen Sørnes Chris Morgan Jeff Zaroyko -- Tony Lambregts

1 0

re: GSoC project ideas
by Dan Kegel 25 Feb '08

25 Feb '08

Kai wrote: > * Implementing a WinePluginApi so other programs can use > Windows DLLs inside of Linux apps That one's very tricky and systemy, a successful student would have to be a kernel and/or glibc maven, too. > * Valgrind and Wine integration (see: Wine_and_Valgrind) That one's sorted, or will be, so let's strike it. > * Run the Mauve Java test suite against Sun's Windows JRE, and file bugs / > write test cases in C / fix anything it finds Done. Mauve's a mess. We pass the part of it that makes sense. > * pick a Windows feature that is incomplete in Wine, and improve the feature > and its conformance tests. (Some good examples might be riched20 Believe it or not, there's still stuff to do there, I think. (Mostly COM-related?) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

[1/7] D3D9: Add a non-shader reversed fog test
by Luke Bratch 25 Feb '08

25 Feb '08

Something in this patch set breaks Peggle (Steam game, comes with The Orange Box) when it's running in software rendering mode. There is just a whole lot of: fixme:d3d_surface:surface_convert_format Cannot find a conversion function from format WINED3DFMT_X8R8G8B8 to WINED3DFMT_X8R8G8B8 Printed in the console. ___________________________________________________________ Rise to the challenge for Sport Relief with Yahoo! For Good http://uk.promotions.yahoo.com/forgood/

2 3

Sending updates to wine developers guide
by Austin English 25 Feb '08

25 Feb '08

I was looking at the website.git online, I can't find the documentation so I can edit it. http://source.winehq.org/git/website.git/?a=blob;f=templates/en/documentati… references /docs/, but that doesn't exist on git. I'm sure a lot of the info is outdated, but I was mostly looking to fix the regression testing guides, which still reference CVS, and are horribly outdated. Any possibility of adding /docs/ to website.git? -Austin

2 1

Re: [3/4].Wbemprox.dll. Main modules for then library.
by Robert Shearman 25 Feb '08

25 Feb '08

Ivan Sinitsin wrote: > --- /dev/null 2007-03-10 18:36:24 +0300 > +++ Makefile.in 2008-02-21 15:57:24 +0300 > @@ -0,0 +1,23 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = wbemprox.dll > +IMPORTLIB = libwbemprox.$(IMPLIBEXT) > +IMPORTS = ole32 oleaut32 user32 advapi32 kernel32 shell32 > +EXTRALIBS = -luuid > + > +C_SRCS = \ > + main.c \ > + regsvr.c \ > + i_numwbemclassobject.c \ > + i_wbemservices.c \ > + mainclass.c \ > + factory.c > The files i_numwbemclassobject.c and i_wbemservices.c aren't included with this patch, so Wine would not compile if this patch was applied. Please also reconsider the naming of these files - I presume i_ standards for interface, but you aren't declaring an interface in these files but implementing an object. > + > + > +IDL_I_SRCS = wbemprox.idl > + > +@MAKE_DLL_RULES@ > + > +@DEPENDENCIES@ # everything below this line is overwritten by make depend > -- Rob Shearman

1 0

Re: [2/4]try2.Wbemprox.dll. Idl file.
by Robert Shearman 25 Feb '08

25 Feb '08

Ivan Sinitsin wrote: > --- /dev/null 2007-03-10 18:36:24 +0300 > +++ wbemprox.idl 2008-02-21 16:09:20 +0300 > @@ -0,0 +1,260 @@ > Then doesn't appear to be a wbemprox.idl file in any version of the Platform SDK that I have access to. The interfaces in your file are in wbemcli.idl instead. Also, please diff from the toplevel wine directory. -- Rob Shearman

1 0

GSoC 2008 kickoff.
by Kai Blin 25 Feb '08

25 Feb '08

Hi folks, Google announced the 2008 programme today and I wanted to use the opportunity to talk about the next steps we should take to get ready. I will start a separate thread to start collecting project ideas, presenting the ones mentioned on the wiki page [1]. New project ideas are very much welcome. If any of you feels like mentoring one of the projects, please mention that. If you're a student with your own project idea, please mention that as well. We will then have to discuss if we believe the projects are doable in a Summer of Code timeframe. When we talked about last year's projects on WineConf, it was the common opinion that we didn't do a very good job on that for 2007. I don't have a surefire solution for this, we should try being a bit more conservative though. I will add some more documentation to the SoC wiki page, does anybody have a good idea what we could call the post-mortem analysis? I know this is a correct technical term, but in my opinion it sounds a bit negative. Lacking a better alternative, I'd call it review. Can the native speakers come up with something else? Maarten, you wrote a wiki page about your 2007 experience. Could you add it to the "Helpful Links" section? [1] http://wiki.winehq.org/SummerOfCode Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [msi/tests] Make tests run on win9x/NT4 again
by James Hawkins 25 Feb '08

25 Feb '08

On Sun, Feb 24, 2008 at 10:30 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > MsiSourceListEnumSourcesA and MsiSourceListSetInfoA are only available as of W2K. > > Some tests will still fail on those platforms as the missing functions are not > skipped yet (part of a next patch when time permits). > > Changelog > Make tests run on win9x/NT4 again > This is nitpicky, but it took a long time to write those tests so I feel it's deserved. - r = MsiSourceListEnumSourcesA(prodcode, NULL, MSIINSTALLCONTEXT_USERUNMANAGED, + r = pMsiSourceListEnumSourcesA(prodcode, NULL, MSIINSTALLCONTEXT_USERUNMANAGED, MSICODE_PRODUCT | MSISOURCETYPE_URL, 0, NULL, &size); You can't see it in this email because it's wrapped, but the style of the file is that the continued function parameters on the next lines match up with the first character on the first line. So you need to add the missing space to any continuing lines. Please fix that. -- James Hawkins

2 1

Re: add rule for the .m suffix
by Emmanuel Maillard 25 Feb '08

25 Feb '08

Hi, Did you convince Alexandre Julliard to include Objective-C on wine tree ?? Because you need to if you want to submit my patches to winehq, or rewrite it in plain C with Carbon. Emmanuel Le 20 févr. 08 à 13:31, Steven Edwards a écrit : > This is needed for quartzdrv patch. Trying to reduce the size of the > diff, I expect a real winequartzdrv will need it later on anyway > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > <support-m-suffix.patch>

3 2

USB with libusb
by Eliot Blennerhassett 25 Feb '08

25 Feb '08

Greetings, I have been reading about general USB support. E.g. http://www.winehq.org/?issue=331#USB%20Support%20in%20Wine which mentions 4 scenarios for giving apps access to USB. But here's a 5th that I am wondering about: The Windows app has been linked to (win32) libusb. How do I get it to use the linux version of libusb? Will it "just work", or do I need to make a libusb.dll for Wine that passes calls through to linux libusb? (I am talking to a hardware manufacturer that currently uses their own custom .sys driver to access usb on windows, suggesting libusb might make their app easier to port or just run with Wine) thanks and regards -- Eliot

2 1

USB with libusb
by Eliot Blennerhassett 24 Feb '08

24 Feb '08

Greetings, I have been reading about general USB support. E.g. http://www.winehq.org/?issue=331#USB%20Support%20in%20Wine This mentions 4 scenarios. But here's a 5th that I am wondering about: The Windows app has been linked to libusb. How do I get it to use the linux version of libusb? Will it "just work", or do I need to make a libusb.dll for Wine that passes calls through to linux libusb? (I am talking to a hardware manufacturer that currently uses their own custom .sys driver to access usb on windows, suggesting libusb might make their app easier to port or just run with Wine) thanks and regards -- -- Eliot

1 0

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9, try 2]
by tony.wasserka＠freenet.de 24 Feb '08

24 Feb '08

> You have fixed object to *object, what about other places with > a similar problem? Also, the stubs have to use FIXME not TRACE, > and if you do nothing with a passed in parameter, don't assign > it to an internal variable. There is no need to cast NULL either. > If you allocate memory on object creation, you must free it on > object destruction. There is no need to initialize 'object' to > NULL if on the next line you are doing an attempt to allocate it. > What's the point of adding all those includes to d3dx9_36_private.h > if you are not using them? Thanks for that detailed response :) I have fixed what you said and have attached the fixed patch to this mail. The added includes prevented the compilation from failing, but some of them were really not needed as you pointed out. If there won't be any criticisms until tomorrow afternoon I'll resend it to wine-patches.

1 0

Wine and PulseAudio
by Tomas Carnecky 24 Feb '08

24 Feb '08

This subject was discussed a few months ago (around 10/2007). But it was rather a discussion about whether to make a PA sound driver or not. I personally would love to see that happen, if not only because PA has some very nifty features, like per-app volume, transparent sink switching etc, some of which are impossible to emulate through the alsa pulse plugin. Also, then next Ubuntu and Fedora releases will have PA enabled by default so if Wine doesn't work with that well there will be complaints. I switched my desktop to PA yesterday, got most apps working, and to my surprise even flash (netscape 32bit plugin in a 64bit browser). All apps that I need use PA natively, only Wine doesn't have a PA sound driver. Since winealsa.drv will stay the default driver for Linux for the foreseeable future, I started digging and hacking to see why it doesn't work with the alsa pulse plugin and what can be fixed. There are a few bug reports that track the winealsa.drv/PA issue, such as [1]. There is very little required to make it work. Only two tiny changes to the alsa pulse plugin (one can be described as a quirk, until I figure out how exactly the alsa API can be emulated using PA, seems to be a very specific issue in how Wine uses the alsa API since other apps work fine) and sound works perfectly (tested with foobar2000 and WoW, both playback and recording). alsa-1.0.16 was just released, so I hope the needed changes make it into the next version. In the PA volume control, all wine apps show up under the same name: ALSA plug-in [wine-preloader] and thus share the same volume and sink preferences. The alsa plugin could try to do some /proc/self voodoo to extract the true exe name. But given the simplicity of the PA API (no hwparams negotiation, just request a format and you'll get it) and the current problems with the alsa pulse plugin, I think a true wine sound driver would be a viable alternative. I'm still waiting to hear from those people who have said that they have a wine PA driver working :) tom [1] http://bugs.winehq.org/show_bug.cgi?id=10910.

3 6

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9, try 2]
by Dmitry Timoshkov 24 Feb '08

24 Feb '08

<tony.wasserka(a)freenet.de> wrote: > Replaced the S_OKs with D3D_OKs, moved the QueryInterface TRACE out of the if condition > and replaced object by *object. You have fixed object to *object, what about other places with a similar problem? Also, the stubs have to use FIXME not TRACE, and if you do nothing with a passed in parameter, don't assign it to an internal variable. There is no need to cast NULL either. If you allocate memory on object creation, you must free it on object destruction. There is no need to initialize 'object' to NULL if on the next line you are doing an attempt to allocate it. What's the point of adding all those includes to d3dx9_36_private.h if you are not using them? -- Dmitry.

1 0

Re: d3dx9: Add stubs for the ID3DXRenderToSurface functions [PATCH 8/9]
by tony.wasserka＠freenet.de 24 Feb '08

24 Feb '08

> Shouldn't that be a n (here and in the other patches)? > Setting object to NULL here doesn't do a whole lot, you should set > *object to NULL (also goes for the other QueryInterface > implementations). Also, you'll probably want to put the TRACE before > the if block. Thank you very much for pointing that out :) Is there anything else wrong with it or can I resend the patches? Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

3 2

Re: d3dx9: Add stubs for the ID3DXRenderToSurface functions [PATCH 8/9]
by H. Verbeet 24 Feb '08

24 Feb '08

On 23/02/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(LPD3DXRENDERTOSURFACE iface, REFIID riid, LPVOID *object) > +{ > + ID3DXRenderToSurfaceImpl *This=(ID3DXRenderToSurfaceImpl*)iface; > + > + if(IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_ID3DXRenderToSurface)) { > + TRACE("(%p): QueryInterface from %sn", This, debugstr_guid(riid)); > + IUnknown_AddRef(iface); > + *object=This; > + return S_OK; > + } > + WARN("(%p)->(%s, %p): not foundn", iface, debugstr_guid(riid), object); > + object=NULL; > + return E_NOINTERFACE; > +} > + Setting object to NULL here doesn't do a whole lot, you should set *object to NULL (also goes for the other QueryInterface implementations). Also, you'll probably want to put the TRACE before the if block.

1 0

Re: d3dx9: Add stubs for the ID3DXFont functions [PATCH 5/9]
by H. Verbeet 24 Feb '08

24 Feb '08

On 23/02/2008, tony.wasserka(a)freenet.de <tony.wasserka(a)freenet.de> wrote: > + TRACE("stubn"); Shouldn't that be a \n (here and in the other patches)?

1 0

Re: gdiplus: Implement GdipLoadImageFromFile
by Dmitry Timoshkov 24 Feb '08

24 Feb '08

"Nathan Beckmann" <nathan.beckmann(a)gmail.com> wrote: > stat = GdipCreateBitmapFromStream(stream, bitmap); > > - if(!stat) > + if(stream) > IStream_Release(stream); The 'if' check above is not needed, GdipCreateStreamOnFile returns a status which is already checked. > + stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > + > + if (stat != Ok) > + return stat; > + > + stat = GdipLoadImageFromStream(stream, image); > + > + if (stream) > + IStream_Release(stream); Same thing here. -- Dmitry.

1 0

Re: gdiplus: Implement GdipLoadImageFromFile
by James Hawkins 24 Feb '08

24 Feb '08

On Sat, Feb 23, 2008 at 11:00 PM, Nathan Beckmann <nathan.beckmann(a)gmail.com> wrote: > Hi. My name is Nathan Beckmann. I'm working on GDI+ for a class > project at UCLA (sponsored by Google). > > This patch implements GdipLoadImageFromFile. > > It includes basic tests for invalid parameters, all of which pass on > Windows. I'm working on this in order to get ConvertImage.exe > (http://bugs.winehq.org/show_bug.cgi?id=10980) to work. Now I'm > working on image encoders/decoders. > > Implemented GdipLoadImageFromFile using > GdipLoadImageFromStream. Implementation based on > GdipCreateBitmapFromFile. > > Changed GdipCreateBitmapFromFile to properly release the Stream COM > object. > > Added tests for CreateBitmapFromFile and LoadImageFromFile when passed > with invalid parameters. One fix per patch. http://winehq.org/site/sending_patches -- James Hawkins

1 0

re: Sending updates to wine developers guide
by Dan Kegel 24 Feb '08

24 Feb '08

> I can't find the documentation so I can edit it. Look at the bottom of http://winehq.org/site/git The command to load it into a local git repository is git cvsimport -v -k -d :pserver:anonymous@wine.cvs.sourceforge.net:/cvsroot/wine docs You can then send in patches.

1 0

Bugs fixed in 0.9.56
by Dan Kegel 24 Feb '08

24 Feb '08

Here are the bugs marked fixed during the 0.9.56 cycle. (A few of them were fixed earlier, but not marked as such before.) 1737 Metafiles embedded in Rich Text don't render 3768 Blood 2 The Chosen - keyboard and mouse do not work 5114 suggesting more descriptive desktop window titles 5503 Opening help in Office97 triggers unhandled page fault 6383 Dual-core not being correctly supported 6914 C&C Red Alert pauses on shaking game view 7544 ReplaceFileW not implemented 7660 Mouse Movement not recognized at slower speeds in World of Warcraft 8236 Dungeon Siege 2 has some animation issues 8687 Online Poker program: unimplemented classes in shdocvw 8722 Unhandled Exception in InstallShield Wizard for 'Star Wars: The Best of PC' Games 9741 URLDownloadToFile only supports HTTP URL's 9917 Add X11 child window for client area 10010 Call of Duty 4 Demo: Fails to start: "Video card or driver doesn't support separate alpha blend." 10083 Inverted colours in C&C RA demo exit screen 10736 iTunes 7.5 hangs 10787 Can't install 3ds max 9 10808 Saitek P990 crashes MVP Baseball 2005 10973 Regression: Commandos 3 - menu not properly rendered 11008 Problem through the registration of an assembly 11009 Battlefield 1942: no longer starts after patching to Version 1.6 11037 Painkiller game crashes on startup 11136 Trados: TagEditor loosing contact with Workbench. 11187 Scanf bug 11204 mail inspector doubles messages in 0.9.53 11257 Can't install Slingplayer 11340 Warcraft 3 displays the start splashscreen forever and doesn't continue with the game start. 11348 EVE Online: character portrait parts are rendered with glitches 11362 ChemDraw9 messed up struture fonts 11398 Some PhotoShop controls are not working properly. 11426 Cryptographic exception in .NET Framework application 11480 msi2xml fails to convert an msi file to xml 11488 corefont installers hanging 11514 Adobe Acrobat Professional 6 fails to install 11545 call of duty 4 stopped working around the time of 0.9.54(not fixed with 55) 11550 Speed Commander 12 hangs on install while copying files 11553 Paintbrush movement becomes erratic with large brush in photoshop 11573 GTA San Andreas: Mouse skips with recent change to Wine 11645 OSDRT Client fails with "Protocol error: process 0015: sendmsg: Bad file descriptor" (wineserver crash) 11646 resident evil 4 crash just after wine start - Dan

2 2

wined3d: ActivateContext: try to fix wrong parameter?
by Rico Schüller 23 Feb '08

23 Feb '08

Hi, as suggested I send this patch for a discussion. This is a workaround for this bug http://bugs.winehq.org/show_bug.cgi?id=11584 . I don't know if this patch is the right way to fix the problem. Could someone with more knowledge have a look at this? Cheers Rico

4 5

Re: website: add links to most popular active Wine forums
by Tom Wickline 23 Feb '08

23 Feb '08

If you know of another active Wine forum - especially a non-english one - please let us know so we can add it to the list. (Email to dank(a)kegel.com would do.) Русский http://www.wine-forum.org/forumdisplay.php?f=44 Tom P.S Sorry, the forums at http://www.wine-forum.org/index.php were not popular enough to make this cut, may I ask how many users = popular? The forum has 750+ registered users in just over three months... 1, 2, 5 thousand?? On Tue, Feb 19, 2008 at 12:45 AM, Dan Kegel <dank(a)kegel.com> wrote: > Perhaps this will help slake the thirst of those who periodically ask > if Wine needs a forum. > > > >

12 20

Re: [Wine] Windows Kernel & Executive implementation
by Volodymyr Shcherbyna 23 Feb '08

23 Feb '08

Read comments inline, 2008/2/23, Alan McKinnon <alan.mckinnon(a)gmail.com>: > > On Friday 22 February 2008, Volodymyr Shcherbyna wrote: > > Hello Tres, > > > > Yes, agree, there might be Linux equivalents to accomplish the same > > tasks. But let me pickup the description of winehq from official > > web-site : "[...] a compatibility layer for running Windows programs > > [...]". Doesn't that mean, that *all* software should work? > > > NO. > > It means that applications that users can reasonably expect to run > should be able to run. Note that it is applications that Wine targets. The description is quite non-precise. Who defines the policy of what should be run and what shouldn't? What I am trying to explain, is that, once something is designed to be compatible with Windows API, it should be compatible with at any case at any layers. For example, there is no sane reason in the world that VC++ should > always work under Wine, considering the deep knowledge of Windows that > is built into VC++. If you are developing a Windows app, then you > should compile it on ... Windows. And Wine runs atop a *nix system, so > it has no need to implement any NTFS-specific code as it does not need > to use NTFS as a storage layer. Should you need to manipulate NTFS for > some reason, we have ntfs-ng for that job. I don't care about file systems. What I would like to see in wine, is a little more abstractionist things, for example, file system filters support. NDIS IM filters, TDI providers, WFP, Kernel sockets and other things. There has to be a point where Wine stops and the correct answer to > anything more is "You should use Windows for that". I believe that line > lies just beyond user-space apps. Any other ideas on this issue? -- > Alan McKinnon > alan dot mckinnon at gmail dot com > > > -- with best regards, Volodymyr

1 0

Re: [Wine] Windows Kernel & Executive implementation
by Volodymyr Shcherbyna 23 Feb '08

23 Feb '08

RegMon was just one of the examples. But basically, RegMon uses vxd driver for Windows 9x. For XP it uses NT driver which hooks SDT. On Server 2003 it uses legacy registry notification API. UMDF support started from XP. It does not cover 2k. Also, UMDF is just a part of WDF. However, I think it will be good to implement basic things, like NT drivers support. 2008/2/23, Dan Kegel <dank06(a)kegel.com>: > > Volodymyr Shcherbyna <v_scherbina(a)mvps.org> wrote: > > >>>[many apps use helper device drivers, e.g. RegMon, FileMon, TDIMom] > > > > http://source.winehq.org/source/dlls/ntoskrnl.exe/ntoskrnl.c > > > Unfortunately, that code just do stubs, and it is not actually executed > in > > kernel mode. > > > The current ntoskrnl.c is enough to run a few apps. > It's not intended to run arbitrary NT drivers. > > Now, RegMon uses a VxD, and I don't think we're ever planning on > really supporting those. Wine does ship with nine 'fake' VxD's; > these were added because they were needed by popular apps. > So if you have a particular VxD that's important enough, > we can reimplement it as part of Wine. > > I just noticed Microsoft's UMDF (User Mode Driver Framework). > I bet we could support UMDF drivers pretty well if we wanted to. > Have you ever played with that? > > - Dan > -- with best regards, Volodymyr

1 0

New winetricks 20080222: new verb 'colorprofile' by Hans
by Dan Kegel 22 Feb '08

22 Feb '08

Hans Leidekker is working on http://bugs.winehq.org/show_bug.cgi?id=11532 (Photoshop doesn't support custom monitor profiles), and contributed a new verb for winetricks, 'colorprofile'. As usual, you can pick it up at http://kegel.com/wine/winetricks

1 0

wineprefixcreate failing?
by Maarten Lankhorst 22 Feb '08

22 Feb '08

Hi all, Is it just me or is wineprefixcreate crashing horribly for others as well? Cheers, Maarten.

2 2

Re: WineD3D: request alpha in backbuffer mode, to work correctly with multiple opengl pixel formats
by Stefan Dösinger 22 Feb '08

22 Feb '08

Am Freitag, 22. Februar 2008 23:31:43 schrieb Roderick Colenbrander: > Hi, > > In the default backbuffer based renderer in WineD3D the front and > backbuffer share the same pixel format while D3D itself decouples them. A > lot of applications use alpha on the backbuffer, so make sure we have > alpha. This change is needed because the single pixel format which we had > before always had alpha. > + /* In case of ORM_BACKBUFFER, make sure to request an alpha component for X4R4G4B4/X8R8G8B8 as we might need it for the backbuffer. */ It would be for offscreen buffers, not the back buffer. I'm sorry for the confusion in the earlier mail

1 0

Re: 1/2 WGL: remove the pixel format limitation (!)
by Stefan Dösinger 22 Feb '08

22 Feb '08

Am Freitag, 22. Februar 2008 21:16:23 schrieb Roderick Colenbrander: > WineD3D has some small issues due to this change but those should be > investigated by Stefan, Chris, me and others. The code should get a lot of > testing as soon as possible. We discussed this on IRC. The problem is that we're still defaulting to back buffer / aux buffer offscreen rendering, and thus offscreen targets are bound to use the same format as the back buffer. In the D3D9 test this means that the backbuffer is X8R8G8B8, and the onscreen target is A8R8G8B8. The alpha is missing with this patch(used to be always there), so the test fails. The proper fix is to switch to FBOs for onscreen rendering whereever possible(FBO support still has problems that prevent that though), and on cards without FBOs try to use A8R8G8B8 instead of X8R8G8B8 for the backbuffer, and similarly for X1R5G5B5 and X4R4G4B4.

1 1

Re: [Wine] Windows Kernel & Executive implementation
by Volodymyr Shcherbyna 22 Feb '08

22 Feb '08

Unfortunately, that code just do stubs, and it is not actually executed in kernel mode. -- with best regards, Volodymyr 2008/2/22, Dan Kegel <dank(a)kegel.com>: > > On Fri, Feb 22, 2008 at 3:02 AM, Volodymyr Shcherbyna > <v_scherbina(a)mvps.org> wrote: > > > I discovered that WineHQ project does not have support for drivers (am > I > > wrong?). In other words, quite a big amount of applications will fail > to > > function properly, because many of them are using helper device drivers > to > > get some extended functionality. I can just mention RegMon, FileMon, > TDIMom, > > and others. > > > I know very little about this, but my impression is that > Wine supports a limited set of NT os kernel APIs already. > The initial support was added by this patch: > http://www.winehq.org/pipermail/wine-cvs/2007-May/032546.html > The current set of supported calls can be seen here: > http://source.winehq.org/source/dlls/ntoskrnl.exe/ntoskrnl.c > > Feel free to implement more, or file enhancement requests > describing what nt os apis a popular app needs. > > - Dan >

1 0

Re: msi: MsiMergeDatabaseA/W stub
by James Hawkins 22 Feb '08

22 Feb '08

On Thu, Feb 21, 2008 at 2:26 PM, Johan Dahlin <jdahlin(a)async.com.br> wrote: > Add stubs for MsiMergeDatabaseA/W, used by WiX's msi validation. > > diff --git a/dlls/msi/database.c b/dlls/msi/database.c > index 425486e..e74db8f 100644 > --- a/dlls/msi/database.c > +++ b/dlls/msi/database.c > @@ -1119,3 +1119,22 @@ HRESULT create_msi_remote_database( IUnknown *pOuter, LPVOID *ppObj ) > > return S_OK; > } > + > +UINT WINAPI MsiDatabaseMergeW( MSIHANDLE hDatabase, > + MSIHANDLE hDatabaseMerge, > + LPCWSTR szTableName ) > +{ > + FIXME("(%ld %ld %s): stub!\n", hDatabase, hDatabaseMerge, > + debugstr_w(szTableName)); > + return ERROR_SUCCESS; > +} > + > +UINT WINAPI MsiDatabaseMergeA( MSIHANDLE hDatabase, > + MSIHANDLE hDatabaseMerge, > + LPCSTR szTableName ) > +{ > + FIXME("(%ld %ld %s): stub!\n", hDatabase, hDatabaseMerge, > + szTableName); > + > + return ERROR_SUCCESS; > +} > Please use the same style as the rest of the file (4 space indentation). The A version should be before the W version. -- James Hawkins

2 2

Re: [1/2] user32:scroll: Added some tests for scrollbar [try2]
by Anatoly Lyutin 22 Feb '08

22 Feb '08

Alexandre Julliard wrote: > The tests fail: > > ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p > user32_test.exe.so scroll.c && touch scroll.ok > scroll.c:56: Test failed: The scrollbar window should be disabled. > scroll.c:122: Test failed: The ShowScrollBar() should failed. > Yes! These tests must be failed in WINE, but it passes clear in Win XP. I just want to show you some incorrect behavior of scrollbar in WINE. Should I mark these tests as "todo_wine"? -- Best regards Anatoly Lyutin.

2 2

Re: [2/3] qmgr: Implement IUnkown interface for IBackgroundCopyJob.
by Alexandre Julliard 22 Feb '08

22 Feb '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > +static ULONG WINAPI BITS_IBackgroundCopyJob_AddRef(IBackgroundCopyJob* iface) > +{ > + ICOM_THIS_MULTI(BackgroundCopyJobImpl, lpVtbl, iface); > + return InterlockedIncrement(&This->ref); > +} There's no reason to use something like ICOM_THIS_MULTI with a single interface. And if you really do have multiple interfaces, please use an inline function instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Printing images
by Alexander Demakin 22 Feb '08

22 Feb '08

Hi all, I have some troubles with printing. BitBlt returns error when calling it for printer context due to implementation of PSDRV_SelectBitmap(). Does anybody know how to implement this function? Where can i find any documentation about it? Implementation of SelectBitmap() in EMFDRV and MFDRV just returns 0. Is it correct? Please, share your ideas. Thanks in advance, Demakin Alexander.

1 0

gdiplus: negative stride from dipCreateBitmapFromFile
by bill lam 22 Feb '08

22 Feb '08

WHen I read a jpeg file of size about 600x400 pixels using gdiplus like this, GdipCreateBitmapFromFile fn BMP GdipGetImageWidth BMP w GdipGetImageHeight BMP h rt=. 0 0, w, h GdipBitmapLockBits BMP rt ImageLockModeRead PixelFormat32bppARGB DATA 'w h s f p r'=. DATA the member stride inside bitmapdata is negative, and its data buffer cannot be read successfully. when using native gdiplus that stride is positive, and it work ok. wine said itself cannot handle negitive stride yet so why itself create a bitmap wih negative stride in GdipCreateBitmapFromFile?

1 0

Re: New dll. Wbemprox.dll
by Alistair Leslie-Hughes 22 Feb '08

22 Feb '08

Ivan Sinitsin wrote: > This patch add new library to the project wine. Name of the library > is - "wbemprox.dll".This library is a part of WMI technology. Now there four > interfaces are described - "IWbemLocator, IWbemServices, > IEnumWbemClassObject, IWbemClassObject". Almost all methods are stubs. > This library is used with some programs like "1C", to get some information > about system. > > static struct regsvr_interface const interface_list[] = { >+ { &IID_IWbemLocator, >+ "IWbemLocator", >+ NULL, >+ 1, /*ÞÉÓÌÏ ÍÅÔÏÄÏ×*/ Comment should be in English. >#define _WIN32_WINNT 0x0600 > >#ifndef __wbemprox_PRIVATE_H__ Defining _WIN32_WINNT doesn't seem right. This patches is large, try breaking it up. Best Regards Alistair Leslie-Hughes

1 0

Fun Project: Add dialogs to builtin IE
by Steven Edwards 22 Feb '08

22 Feb '08

Hi, I submitted a proof of concept patch for this a week or so back that added a simple file->exit menu to the builtin Internet Explorer. I've spoken with Jacek a bit about it and it seems shdocvw.dll is the correct place to implement the UI layout if we are targeting IE versions less the 7. There seems to be a plugin interface the GUI uses for browser extensions but if a first pass I don't think we really need to support it. Unfortuntly due to time constraints I am not going to be able to work on this project so if there is anyone out there that wants to contribute with a simple fun project, please feel free to add menus, dialogs and the address bar. I'll try to help as best I can but I expect to be tied up for some time to come. Thanks Steven -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: msvcrt: Implemented wcscpy_s
by Dmitry Timoshkov 22 Feb '08

22 Feb '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s Type of the first parameter should be ptr, not wstr. -- Dmitry.

1 0

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes
by Francois Gouget 22 Feb '08

22 Feb '08

On Wed, 20 Feb 2008, Jeff Zaroyko wrote: > The default colours for warnings and notes on the appdb pages feel > rather strong, this patch changes the red and blue to be a bit softer. > > I think this makes it more readable. A comparison can be seen here: > http://jeffz.name/tmp/ In new.png the green looks darker than the others. Maybe it should be lightened up a bit too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

4 7

Re: dmband: Indirection levels fix
by Robert Shearman 21 Feb '08

21 Feb '08

Andrew Talbot wrote: > diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c > index 891fb5a..8b89573 100644 > --- a/dlls/dmband/band.c > +++ b/dlls/dmband/band.c > @@ -173,7 +173,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD > This->pDesc->ftDate = pDesc->ftDate; > if (pDesc->dwValidData & DMUS_OBJ_MEMORY) { > This->pDesc->llMemLength = pDesc->llMemLength; > - memcpy (This->pDesc->pbMemData, pDesc->pbMemData, sizeof (pDesc->pbMemData)); > + memcpy (&This->pDesc->pbMemData, &pDesc->pbMemData, sizeof (pDesc->pbMemData)); > } > if (pDesc->dwValidData & DMUS_OBJ_STREAM) { > /* according to MSDN, we copy the stream */ This isn't correct. Judging by the surrounding code, this should be allocating a block of memory of This->pDesc->pbMemData and then passing pDesc->llMemLength into memcpy, possibly validating that pDesc->llMemLength isn't greater than UINT_MAX to avoid an overflow. -- Rob Shearman

2 1

Re: [1/2] ddraw: release interfaces when exiting with error
by Stefan Dösinger 21 Feb '08

21 Feb '08

Am Mittwoch, 20. Februar 2008 22:03:51 schrieben Sie: > --- > dlls/ddraw/texture.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Just a general comment(not specific to comments): For such cleanup work it works quite nice to use goto(!), as shown below. Your patch is OK as it is, but I think its a good idea to use this scheme in all places because it helps to prevent new problems from coming in when the code is changed. void *a = NULL, *b = NULL, *c = NULL; a = malloc(10); if(!a) goto error; b = malloc(10); if(!b) goto error; c = malloc(10); if(!c) goto error; if(dosomethingelse() == FAIL) goto error; return SUCCESS; error: f(c) free(c); f(b) free(b); f(a) free(a); return FAIL;

1 0

Re: dplayx: Fix incorrect check in DirectPlayLobbyAImpl_EnumLocalApplications and IDirectPlayLobbyAImpl_EnumAddressTypes.
by Marcus Meissner 21 Feb '08

21 Feb '08

On Thu, Feb 21, 2008 at 04:44:34PM +0000, Robert Shearman wrote: > > Dereferencing a function pointer and checking it against NULL doesn't make > any sense, so remove the checks. > - if( !lpEnumAddressTypeCallback || !*lpEnumAddressTypeCallback ) > + if( !lpEnumAddressTypeCallback ) It looks as if they were meant as &&, but that does not make much sense either. Ciao, Marcus

1 0

Re: James Hawkins : itircl: Add a stub implementation of itircl.dll.
by Detlef Riekenberg 21 Feb '08

21 Feb '08

On Sa, 2008-02-16 at 09:57 -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 58b0686e951364686c3b5b55c18566df0960fd96 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=58b0686e951364686c3b5b55c… > > Author: James Hawkins <jhawkins(a)codeweavers.com> > Date: Fri Feb 15 17:39:46 2008 -0600 > > itircl: Add a stub implementation of itircl.dll. Hi James. While adding your Patch to http://wiki.winehq.org/Developers-Hints , I found this Page: http://www.helpware.net/aphelp/info.htm itircl.dll: HTML Help 1 (found on w2k and xp) itircl52.dll: MS Help 2 apircl.dll: Assistance Platform 1.0 (Vista) -- By by ... Detlef

1 0

Re: slc: Added stub for SLGetWindowsInformationDWORD
by Paul Vriens 21 Feb '08

21 Feb '08

On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added stub for SLGetWindowsInformationDWORD > > Best Regards > Alistair Leslie-Hughes > Hi Alistair, I know that function descriptions should always be your own words but I guess this is also true for header files. The comments in slerror.h are exactly like the comments on MSDN: http://msdn2.microsoft.com/en-us/library/aa965835(VS.85).aspx Cheers, Paul.

3 2

Re: Adding devices in setupapi
by Erich Hoover 21 Feb '08

21 Feb '08

> > I think it probably does something similar to: > http://www.codeproject.com/KB/system/RemoveDriveByLetter.aspx > > Except instead of mapping a drive to usb device, it does it the other > way around. > > After looking more into it it really looks like this is the thing it > does. (I need a bunch of hacks for it to work, but alas.) However it > doesn't get me much further since our IOCTL_STORAGE_GET_DEVICE_NUMBER > ioctl is a stub. I would need something that can at least guarantee > uniqueness per volume for it, perhaps a conversion of drive letter to > integer. Now I just need to figure that one out. > > Cheers, > Maarten. > > I do not believe the device number matching is the problem, I have been exploring this problem a little with RemoveDriveByLetter and I believe that it is not working because the SymbolicLink entry is not added as a "real" thing in Wine. Performing an experiment with accessing the same drive letter in three different ways (results below, last parameter is "hDrive") I see that only the call with the registry-returned value for the drive fails (even if it is added to "HKLM/System/MountedDevices"). I believe that a call to IoCreateSymbolicLink must be made in order for the name returned by the registry to be recognized as an alias for the drive. I think iTunes is probably going through the device tree looking for its vendor and product code. It should get this back from CM_Get_Device_ID, but I do not have Windows so I cannot fake iTunes out to confirm this. SetupDiGetDeviceInterfaceDetail '\\?\USBSTOR#Disk&Ven_Apple&Prod_iPod&Rev_1.62#000A27001420C124&0#{53f56307-b6bf-11d0-94f2-00a0c91efb8b}': -1 SetupDiGetDeviceInterfaceDetail '\\?\Volume{00000000-0000-0000-0000-000000000048}': 60 SetupDiGetDeviceInterfaceDetail '\\.\H:': 64 Device number comparison: 1 1

1 0

No new Wine Weekly News?
by Austin English 21 Feb '08

21 Feb '08

Hasn't been a new Wine Weekly News in about a month...quite a bit has been going on, with CS2 working out of the box, test suite fixes, etc. Anyone know what's going on? -Austin

2 1

Re: appdb: database issues
by Chris Morgan 21 Feb '08

21 Feb '08

In include/query.php in query_appdb() we only call mysql_connect() if the global $hAppdbLink isn't a valid resource. So, when a user connects to display a page the first query should open the connection and upon completion of the script $hAppdbLink will be freed and the connection should be closed. So I'm not sure that this is the cause of the out-of-connections issue although I don't see a reason why we shouldn't just let php take care of this internally and apply a variation of your change where we always attempt to connect and select the appropriate database and remove the global handle and the resource check etc. Chris On Wed, Feb 20, 2008 at 6:01 PM, Jeff Zaroyko <jeffzaroyko(a)gmail.com> wrote: > The mysql database for the appdb/bugzilla appears to have gone down again, > I decided to look at the connection code in the appdb, as the appdb is thought > to be the culprit. > > I came across the call to mysql_connect which is using the new_link parameter > set to true, which is supposedly to force a new connection to be established. > > So, I searched through the git commit history using gitk and saw that Paul van > Schayck made a change introducing this, apparently because mysql was having > stability issues, back in 2005. > > http://www.winehq.org/pipermail/wine-patches/2005-January/014985.html > > my understanding is that php will automagically reuse connections if this is not > set, would there by any objection to trialling a removal of this > option to see if > stability increases? > > > >

1 0

Kudos for Photoshop work
by Dan Kegel 20 Feb '08

20 Feb '08

In http://linux.slashdot.org/comments.pl?sid=460616&cid=22493322, an anonymous coward said: --- snip --- Preamble: I'm a photographer needing to process tens of thousands of photos relatively swiftly. The functionality I need isn't all that advanced (curves, levels, an occasional straighten horizon (measure + arbitrary rotate), crop, unsharp mask, and sometimes an action to find edges, feather and apply unsharp mask on that), but being able to access and apply this functionality swiftly is an absolute must because of the volume of photos I deal with. Photoshop is optimized to perfection to allow a swift workflow, while the gimp seems optimized to perfection to hinder it. Focus is never where I need it, shortcuts to access tools don't work depending on which sub-window has focus, etc. So yes, I really need Photoshop. I last tried Photoshop 7 under wine about a year ago. It was functional to an amazing degree (for someone who'd never seen or used wine before), but the rough edges were slightly too rough for me to be able to switch to Linux fulltime. I could trigger a dozen crashes in Photoshop at will just by resizing panels and doing other simple things like that, the program didn't feel native (alt-tabbing would keep the panels in the foreground, obscuring other programs), and focus sometimes strayed, amongst other lesser (but still annoyingly noticeable) issues. I just tried the latest wine with these Google sponsored improvements, and wow. This is an amazing difference. Every single issue I saw a year ago is gone. Photoshop feels as responsive as it does under Windows (perhaps even more so), and I went through an hour long editing session without being slowed down or annoyed even once. As far as I'm concerned, Linux is now ready to become my main OS. Google: I don't like your lack of respect for my privacy, but for this work on Wine, I can say from the bottom of my heart: Thank you! --- snip --- Ah. Music to my ears :-) - Dan

1 0

Re: Adding devices in setupapi
by Juan Lang 20 Feb '08

20 Feb '08

> How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Not sure what you mean exactly. cfgmgr32 should forward to setupapi already, and I sent a patch that does that for the few stub functions that it had. setupapi's CM_* stubs could be improved, but I don't think you'll be able to forward them to any native code to try out: I expect the Windows configuration manager is rather too low level to run under Wine. You'll probably want to create a hacky version of setupapi that creates a fake device tree, with a root, USB hub, and iPod device, just to see if that makes iTunes happy. Does that answer your question? --Juan

2 1

Re: James Hawkins : msi: Forward MsiSourceListEnumSourcesA to a stub implementation of MsiSourceListEnumSourcesW .
by Detlef Riekenberg 20 Feb '08

20 Feb '08

On Mi, 2008-02-20 at 06:46 -0600, > +/****************************************************************** > + * MsiSourceListEnumSourcesA (MSI.@) > + */ > +UINT WINAPI MsiSourceListEnumSourcesW( Greetings from Copy & Paste :-) BTW: Congratulations James for you new Address -- By by ... Detlef

1 0

bugzilla on the fritz again
by Dan Kegel 20 Feb '08

20 Feb '08

Just started getting this: Software error: Can't connect to the database. Error: Too many connections Is your database installed and up and running? Do you have the correct username and password selected in localconfig?

2 1

Adding devices to registry with the help of hal
by Christian Gmeiner 20 Feb '08

20 Feb '08

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

2 1

Re: user32dll: cursoricon.c. Fix 16b BMP handling with BT_BITFIELD.
by Dmitry Timoshkov 20 Feb '08

20 Feb '08

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch fixes image header handling with BT_BITFIELD flag. 12 bytes of mask > were included into image bits, it caused some color troubles and image > horizontal shift. Size of bitmap info structure includes now this bytes. You are mixing tabs and spaces again, and please use 4 spaces for indentation. > static int bitmap_info_size( const BITMAPINFO * info, WORD coloruse ) > { > int colors; > - > + int result; > if (info->bmiHeader.biSize == sizeof(BITMAPCOREHEADER)) Any reason you have removed a space after a variable declaration? > Changelog: > user32.dll Fix 16b BMP handling with BT_BITFIELD. Please have a look how others name the patches. A usual convenience is to write dll name without extension, ': ' and short description. -- Dmitry.

1 0

Re: gdi32dll: bitblt.c. Fix copying from uninitialized memory
by Dmitry Timoshkov 20 Feb '08

20 Feb '08

"Alexander Demakin" <avd(a)etersoft.ru> wrote: > This patch adds check of return value of GetDIBits in BitBlt.c. If a error > occurs, GetDIBits returns 0 and bits variable points to uninitialized data. > It always occurs when calling BitBlt for printer context due to > implementation of PSDRV_SelectBitmap(). > Changelog: > gdi32.dll Fix copying from uninitialized memory. You are mixing tabs and spaces in the patch, otherwise tha patch looks good to me. -- Dmitry.

1 0

Re: dlls/msi/streams.c type fixes
by James Hawkins 20 Feb '08

20 Feb '08

On Feb 17, 2008 6:23 AM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > This patch contains one or two items from my November patch the core > of which was independently recreated by Marcus and accepted and one > or two additional changes. It addresses the following warnings: > > streams.c: In function 'streams_set_table_size': > streams.c:59: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_delete': > streams.c:379: warning: comparison between signed and unsigned > streams.c: In function 'STREAMS_find_matching_rows': > streams.c:404: warning: comparison between signed and unsigned > > Gerald > > ChangeLog: > Adjust the signedness of three variables and add a comment for > add_streams_to_table(). > > Index: streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.11 > diff -u -3 -p -r1.11 streams.c > --- streams.c 16 Feb 2008 15:59:26 -0000 1.11 > +++ streams.c 17 Feb 2008 12:17:50 -0000 > @@ -39,7 +39,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(msidb); > > typedef struct tabSTREAM > { > - int str_index; > + UINT str_index; > LPWSTR name; > IStream *stream; > } STREAM; > @@ -54,7 +54,7 @@ typedef struct tagMSISTREAMSVIEW > UINT row_size; > } MSISTREAMSVIEW; > > -static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, int size) > +static BOOL streams_set_table_size(MSISTREAMSVIEW *sv, UINT size) > { > if (size >= sv->max_streams) > { > @@ -372,7 +372,7 @@ static UINT STREAMS_modify(struct tagMSI > static UINT STREAMS_delete(struct tagMSIVIEW *view) > { > MSISTREAMSVIEW *sv = (MSISTREAMSVIEW *)view; > - int i; > + UINT i; > > TRACE("(%p)\n", view); > > @@ -440,6 +440,7 @@ static const MSIVIEWOPS streams_ops = > }; > > static INT add_streams_to_table(MSISTREAMSVIEW *sv) > + /* Return -1 in case of error. */ > { > IEnumSTATSTG *stgenum = NULL; > STATSTG stat; > Don't add random comments like this. -- James Hawkins

2 1

Re: shell32: Support getting the shell folder path for users other than the current user and the default user (take 2)
by Alexandre Julliard 20 Feb '08

20 Feb '08

"Ge van Geldorp" <ge(a)thinstall.com> writes: > else > { > + LPWSTR sidStr = NULL; > LPCWSTR userPrefix = NULL; > HKEY hRootKey; This is not used anywhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [advapi32] QueryServiceConfig2 (3rd try) [resend]
by Alexandre Julliard 20 Feb '08

20 Feb '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + switch(dwLevel) { > + case SERVICE_CONFIG_DESCRIPTION: { > + static const WCHAR szDescription[] = {'D','e','s','c','r','i','p','t','i','o','n',0}; > + LPSERVICE_DESCRIPTIONW config = (LPSERVICE_DESCRIPTIONW) buffer; > + *needed = sizeof (SERVICE_DESCRIPTIONW); > + sz = size - *needed; > + r = RegQueryValueExW( hKey, szDescription, 0, &type, (LPBYTE) (config ? config + 1: NULL), &sz ); > + if((r == ERROR_SUCCESS) && ( type != REG_SZ)) { > + FIXME("SERVICE_CONFIG_DESCRIPTION: don't know how to handle type %d\n", type); > + return FALSE; > + } > + *needed += sz; > + if(config) { > + if(r == ERROR_SUCCESS) > + config->lpDescription = (LPWSTR) (config + 1); > + else > + config->lpDescription = NULL; You are still not handling overflows correctly. What happens if size is less than sizeof(SERVICE_DESCRIPTIONW)? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] user32:scroll: Added some tests for scrollbar [try2]
by Alexandre Julliard 20 Feb '08

20 Feb '08

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Changelog: > Added some tests for scrollbar The tests fail: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so scroll.c && touch scroll.ok scroll.c:56: Test failed: The scrollbar window should be disabled. scroll.c:122: Test failed: The ShowScrollBar() should failed. make: *** [scroll.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Adding devices to registry with the help of hal
by Christian Gmeiner 20 Feb '08

20 Feb '08

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

1 0

re: Do we need a forum?
by Dan Kegel 20 Feb '08

20 Feb '08

Steven Edwards wrote: > My thoughts, as well as > Tom's was that by creating a "blessed" location, all third parties as > well as vendors that develop Wine related products could say "if you > want to discuss using a vendor provided Wine product in a > non-supported manner all are advised to go here and share information" Yes, of course, it would be nice if there were One True Place to go, but the closest we're ever going to get is essentially the status quo, where the wine-users mailing list is the place of record for user support, the appdb is the place of record for looking for tips for a particular app, and all the other areas are secondary. We can improve slightly on this by linking to other popular wine forums as they pop up, emphasizing all the while that they are secondary. - Dan

5 8

Fwd: Adding devices in setupapi
by Maarten Lankhorst 20 Feb '08

20 Feb '08

Hi Juan, 2008/2/19, Juan Lang <juan.lang(a)gmail.com>: > > I stubbed CM_get_parent by returning itself, however that makes it go > > in an infinite loop. > > Hm. > > > My guess is that I need to have some hub and usb ehci device as well. > > I don't know why it would want to call CreateFile on the device though > > but my expertise on that part is very limited, perhaps it allows > > communication to the ipod by accessing the device in a raw way? > > Perhaps, or perhaps it's just making sure you don't have a fake device :-/ > --Juan The only way to be sure would be to create my own test program that would do the same, and see what happens. How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Cheers, Maarten.

1 0

Saulius sent you a friend request on Yaari...
by Saulius 20 Feb '08

20 Feb '08

1 0

Adding devices in setupapi
by Maarten Lankhorst 20 Feb '08

20 Feb '08

Hi all, I'm trying to add the ipod detection from crossover wine to winehq. However it seems to be not compatibel due to changes to setupapi in the last 3 years. Basically what I want to do is add an usb mass storage device with the correct device path and register it with setupapi. Composing the string is easy but I'm not 100% sure what the locations are. The code seems a bit vague in that aspect. The snippet iTunes uses for detection is shown below: SetupDiGetClassDevsExW {53f56307-b6bf-11d0-94f2-00a0c91efb8b} (null) (nil) 0x00000012 (nil) (null) (nil) SetupDiEnumDeviceInterfaces 0x136638, (nil), {53f56307-b6bf-11d0-94f2-00a0c91efb8b}, 0, 0x7aa2140c How do I get my device listed in SetupDiEnumDeviceInterfaces there so iTunes can pick it up? Cheers, Maarten.

3 2

Making use of setupapi
by Maarten Lankhorst 19 Feb '08

19 Feb '08

Hi folks, Any one around who understands setupapi? For iTunes I would need to add appropriate registry keys so that my usb device is detected. My idea is to use libusb to find the things like guid, revision etc and then adding the keys. However I am not 100% what the layout of the keys is. Cheers, Maarten.

3 3

Re: ddraw: Assign to structs instead of using memcpy
by Stefan Dösinger 19 Feb '08

19 Feb '08

Am Samstag, 16. Februar 2008 23:33:37 schrieb Andrew Talbot: > Here, I am assuming that the "dwSize" elements in all these cases should be > set to the size of the struct each is in, respectively. Please advise if > this assumption is wrong. It's not necessarily true. Sometimes there are multiple versions of the same structure. You can check ddraw.h and d3dtypes.h. If there is only one version your assumption should be true. If there isn't, then your assumption may still be true. In that case there are some tests how the Setter methods deal with newer or older structures(in some cases we may need more tests) > Thanks, > > -- Andy. > --- > Changelog: > ddraw: Assign to structs instead of using memcpy. > > diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c > index b60b6f3..03ccea8 100644 > --- a/dlls/ddraw/device.c > +++ b/dlls/ddraw/device.c > @@ -704,7 +704,7 @@ > IDirect3DDeviceImpl_1_CreateExecuteBuffer(IDirect3DDevice *iface, > object->d3ddev = This; > > /* Initializes memory */ > - memcpy(&object->desc, Desc, Desc->dwSize); > + object->desc = *Desc; > > /* No buffer given */ > if ((object->desc.dwFlags & D3DDEB_LPDATA) == 0) > diff --git a/dlls/ddraw/material.c b/dlls/ddraw/material.c > index d6b9a7c..8e17174 100644 > --- a/dlls/ddraw/material.c > +++ b/dlls/ddraw/material.c > @@ -250,7 +250,7 @@ IDirect3DMaterialImpl_SetMaterial(IDirect3DMaterial3 > *iface, /* Stores the material */ > EnterCriticalSection(&ddraw_cs); > memset(&This->mat, 0, sizeof(This->mat)); > - memcpy(&This->mat, lpMat, lpMat->dwSize); > + This->mat = *lpMat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > @@ -285,7 +285,7 @@ IDirect3DMaterialImpl_GetMaterial(IDirect3DMaterial3 > *iface, EnterCriticalSection(&ddraw_cs); > dwSize = lpMat->dwSize; > memset(lpMat, 0, dwSize); > - memcpy(lpMat, &This->mat, dwSize); > + *lpMat = This->mat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > diff --git a/dlls/ddraw/viewport.c b/dlls/ddraw/viewport.c > index deb4146..8dfc015 100644 > --- a/dlls/ddraw/viewport.c > +++ b/dlls/ddraw/viewport.c > @@ -261,7 +261,7 @@ IDirect3DViewportImpl_GetViewport(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp1), dwSize); > + *lpData = This->viewports.vp1; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT :\n"); > @@ -301,7 +301,7 @@ IDirect3DViewportImpl_SetViewport(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 0; > memset(&(This->viewports.vp1), 0, sizeof(This->viewports.vp1)); > - memcpy(&(This->viewports.vp1), lpData, lpData->dwSize); > + This->viewports.vp1 = *lpData; > > /* Tests on two games show that these values are never used properly > so override them with proper ones :-) > @@ -856,7 +856,7 @@ IDirect3DViewportImpl_GetViewport2(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp2), dwSize); > + *lpData = This->viewports.vp2; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT2 :\n"); > @@ -895,7 +895,7 @@ IDirect3DViewportImpl_SetViewport2(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 1; > memset(&(This->viewports.vp2), 0, sizeof(This->viewports.vp2)); > - memcpy(&(This->viewports.vp2), lpData, lpData->dwSize); > + This->viewports.vp2 = *lpData; > > if (This->active_device) { > > IDirect3DDevice3_GetCurrentViewport(ICOM_INTERFACE(This->active_device, > IDirect3DDevice3), &current_viewport);

2 3

Re: WineD3D: let flush_to_framebuffer_drawpixels use a valid rect
by Stefan Dösinger 19 Feb '08

19 Feb '08

Am Dienstag, 19. Februar 2008 21:26:24 schrieben Sie: > Hi, > > Originally flush_to_framebuffer_drawpixels was called from UnlockRect, so > in that case LockedRect was always set. These days it can also be called > (through LoadLocation) from other places. This patch makes it use the > LockedRect when the surface is locked else the whole surface is uploaded. > This fixes rendering issues in Red Alert and other apps. Wouldn't it be better to make sure that the caller passes the correct rectangle to flush_to_framebuffer_* ? > - if(dxVersion >= 8) { > + if(0 && dxVersion >= 8) { Is this intentional?

1 0

Re: slc: Initial stub DLL (try 2)
by Robert Shearman 19 Feb '08

19 Feb '08

Alistair Leslie-Hughes wrote: > slc: Initial stub dll I'm not sure we want to go down the path of implementing the functions in this DLL. Furthermore, this file isn't present on an XP SP2 installation. Can you give some information as to why this is needed and how the application depends on this DLL? -- Rob Shearman

3 3

Re: Make.rules.in: Pass the --nounistd flag to flex since unistd.h is a header that might not be present on all systems.
by Alexandre Julliard 19 Feb '08

19 Feb '08

Robert Shearman <rob(a)codeweavers.com> writes: > If we do need it, we can include it in the .l file after config.h and > with an appropriate include guard. You should instead put a %option in the files that need it. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: Pass parms through to PdhLookupPerfIndexByNameW for checking
by Dmitry Timoshkov 19 Feb '08

19 Feb '08

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > + if (machine && !(machineW = pdh_strdup_aw( machine ))) return PDH_MEMORY_ALLOCATION_FAILURE; > > - if (machine) > - { > - FIXME("remote machine not supported\n"); > - return PDH_CSTATUS_NO_MACHINE; > - } > if (!(nameW = pdh_strdup_aw( name ))) > return PDH_MEMORY_ALLOCATION_FAILURE; > > ret = PdhLookupPerfIndexByNameW( NULL, nameW, index ); You forgot to actually pass machineW to PdhLookupPerfIndexByNameW. -- Dmitry.

1 0

re: Do we need a forum?
by Dan Kegel 19 Feb '08

19 Feb '08

Anybody who thinks we need another forum needs his head examined. There is no shortage of Wine forums. We just need to use the ones that already exist. Adding a new one will just fragment the community further. In particular, there are two forums right now that people already use to discuss wine problems: a generic one at http://www.linuxforums.org/forum/wine/ and an Ubuntu-specific one at http://ubuntuforums.org/forumdisplay.php?f=313 Let's just link to them. I'll submit a patch to do that in a minute. And I like Griswold's idea (on IRC) of improving the current appdb in small ways, e.g. changing the reply behavior to not open up a new page. For goodness' sake, don't create yet another new forum! - Dan

3 2

Re: slc: Add Initial DLL
by John Klehm 19 Feb '08

19 Feb '08

On Feb 18, 2008 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added Initial DLL > > Best Regards > Alistair Leslie-Hughes > > > > No Patch?

1 0

Re: iTunes
by Maarten Lankhorst 19 Feb '08

19 Feb '08

Hi Christopher, Christopher Harvey wrote: > What needs to get done for iTunes to work? v7.6 basically works if you set windows version to windows vista, and find out why the installer fails to create the 'Bonjour service' registry stuff properly. I submitted 8 or so stub dll's to wine-patches that make iTunes v7.6 actually start after installation. It checks for the dll's and silently fails if they don't exist. I haven't done any further testing yet though, but it looks like it is probably a small installer bug that prevents itunes v7.6 from installing without first manually creating those registry keys. Cheers, Maarten.

6 17

Re: Usable Wine interface
by Remco 19 Feb '08

19 Feb '08

----- Original Message ---- > From: Vitaliy Margolen <wine-devel(a)kievinfo.com> > To: wine-devel(a)winehq.org > Sent: Monday, February 18, 2008 4:16:17 AM > Subject: Re: Usable Wine interface > > Remco wrote: > > I'd like to add a feature-request (should this go somewhereelse?) > Yes, bugzilla -> enhancement. > > Vitaliy. Ok, thanks for the info. I added an entry: http://bugs.winehq.org/show_bug.cgi?id=11629 Remco ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping

5 5

Re: dlls/user32/edit.c -- remove superflous check (RESEND)
by Alexandre Julliard 19 Feb '08

19 Feb '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > dwBufLen already indictes that this variable is of type DWORD and > thus always positive. I also looked at the implementation of > ImmGetCompositionStringW() and we do not seem to return a negative > value (such as -1). Maybe the implementation doesn't, but the function returns a LONG, and can (and probably should) return negative values on error. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] Environment variable to specify X11 window for desktop
by Robert Shearman 19 Feb '08

19 Feb '08

Timothy Lee wrote: > The attached patch allows the WINE desktop to be embedded within an > existing X11 window, and is similar to the windowed mode in WINE. > > I've tested this feature using MS PowerPoint Viewer 2007, so that a > fullscreen slideshow can be fitted inside any X11 window. I'm struggling to imagine a case where the behaviour you've implemented is useful. -- Rob Shearman

6 13

Re: [PATCH 2/3] gdi32: Move EnumFontFamiliesEx16() and helper functions to gdi16.c.
by Michael Stefaniuc 18 Feb '08

18 Feb '08

Michael Stefaniuc wrote: > --- > This duplicates for now the FONT_LogFont16ToW() function but Alexandre It duplicates FONT_LogFontWTo16() and not FONT_LogFont16ToW() (that one was already duplicated). > told me on irc that he removed the other user of it in an yet unpublished > patch. Thus FONT_LogFont16ToW() can be removed from font.c in a later FONT_LogFontWTo16() can be removed later on. > patch. > bye michael

1 0

Re: [1/16] msxml3: Support functions for typelib
by Alexandre Julliard 18 Feb '08

18 Feb '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + ITypeLib *tl; > + > + hres = LoadRegTypeLib(&LIBID_MSXML2, 3, 0, LOCALE_SYSTEM_DEFAULT, &tl); > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)&typelib, tl, NULL)) > + ITypeLib_Release(tl); > + } > + > + if(!typeinfos[tid]) { > + ITypeInfo *typeinfo; > + > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], &typeinfo); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)(typeinfos+tid), typeinfo, NULL)) > + ITypeInfo_Release(typeinfo); > + } > + > + *typeinfo = typeinfos[tid]; > + return S_OK; You should increment the ref count when you are returning a pointer, even if it's also stored in a global variable. -- Alexandre Julliard julliard(a)winehq.org

2 3

Autoplay considered harmful
by Dan Kegel 18 Feb '08

18 Feb '08

http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… says that USB devices are being sold with infected autorun apps. "If you plug in, you're already infected," I'd say that's a pretty good argument for not supporting autoplay...

7 7

Re: [advapi32/tests #2] Don't set last error to 0 so we can check if it has changed
by Alexandre Julliard 18 Feb '08

18 Feb '08

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > We test for a last error of 0, so we shouldn't set it to 0 before the > function is called. This however introduces a todo_wine. Is there any reason to believe that last error should be 0 on success? This looks more like a broken test to me. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: include: Add support for executing finally code for exceptions without using a separate function.
by Alexandre Julliard 18 Feb '08

18 Feb '08

Robert Shearman <rob(a)codeweavers.com> writes: > The first goal is accomplished by changing the previous two-state > variable of __first into a three-state variable where the third state > is the state in which the finally code is executed in the normal > case. The second goal is accomplished by calling sigsetjmp in > __wine_finally_handler to give the finally code a place to jump back > to after it has finished executing. That can't work, once you longjmp into the finally block you can't longjmp back, since you are no longer inside the function that did the setjmp. -- Alexandre Julliard julliard(a)winehq.org

2 1

iTunes
by Christopher Harvey 18 Feb '08

18 Feb '08

What needs to get done for iTunes to work?

3 3

[PATCH] msvcrt/tests: Add more scanf floating-point tests.
by Jānis Rūcis 18 Feb '08

18 Feb '08

The included patch adds a couple of scanf floating-point tests to expose a problem with the algorithm. It seems that it doesn't handle negative exponents very well, resulting in single-precision values being off-by-one in the last bit of significant compared to those obtained with the GNU C library or natively on Windows XP. All five tests pass on my Windows XP SP2 system (using a self-compiled msvcrt_crosstest.exe tool). Test 3 and 4 fail with the current source in Git. I will send another patch to this list with a potential fix. (I am not sending these to wine-patches because I'm not sure I should. "wine-devel" sounds about right.) --- dlls/msvcrt/tests/scanf.c | 40 ++++++++++++++++++++++++++++++++++++---- 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/tests/scanf.c b/dlls/msvcrt/tests/scanf.c index 65bea46..d5da3f6 100644 --- a/dlls/msvcrt/tests/scanf.c +++ b/dlls/msvcrt/tests/scanf.c @@ -28,7 +28,7 @@ static void test_sscanf( void ) char format[20]; int result, ret; char c; - float res1= -82.6267f, res2= 27.76f, res11, res12; + float orig, res; static const char pname[]=" St. Petersburg, Florida\n"; int hour=21,min=59,sec=20; int number,number_so_far; @@ -64,9 +64,41 @@ static void test_sscanf( void ) ok( result == 12, "sscanf reads %x instead of %x\n", result, 12 ); /* Check float */ - ret = sprintf(buffer,"%f %f",res1, res2); - ret = sscanf(buffer,"%f%f",&res11, &res12); - ok( (res11 == res1) && (res12 == res2), "Error reading floats\n"); + + orig = -82.6267f; + ret = sprintf(buffer, "%f", orig); + ret = sscanf(buffer, "%f", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 27.76f; + ret = sprintf(buffer, "%f", orig); + ret = sscanf(buffer, "%f", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = -6.61589e-2f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 1.72567e-7f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); + + orig = 15.483e+3f; + ret = sprintf(buffer, "%e", orig); + ret = sscanf(buffer, "%e", &res); + ok(ret == 1, "Expected 1 float, got %d\n", ret); + ok(res == orig, "Wrote %e (0x%x), but read %e (0x%x)\n", + orig, *(unsigned int *) &orig, res, *(unsigned int *) &res); /* check strings */ ret = sprintf(buffer," %s", pname); -- 1.5.3.8

2 1

programs: add winestartfile for starting files from the unix path (for file managers)
by Vincent Povirk 18 Feb '08

18 Feb '08

This is now attempt 4, not that anyone's counting. Adding winelib programs is a bit involved, and I imagine I've screwed something up along the way. If you know how to add them properly, please say something, even if it's to tell me I did it right. This patch adds a winelib program called winestartfile for starting files given the unix path. It attempts to mimic what windows explorer does to start files and provide some visible (gui) feedback when it doesn't work. The idea is that wine.desktop can then be modified to use winestartfile instead of wine, solving the following problems when starting exe files from file managers: * File managers typically do not set the working directory to the directory that contains an exe when they start it. Setting the working directory is the default behavior for windows explorer, and many windows programs rely on it. * File managers naturally use the unix path to start files, and the wine binary passes the unix path along to the exe it starts, rather than translating it to a windows path (this can and probably should also be fixed somewhere else). * Windows explorer always starts exe files with quotes around the path in the command-line, even if the path does not contain spaces. The wine binary does not (and probably should not) add quotes in this situation. A few apps rely on the quotes. See http://bugs.winehq.org/show_bug.cgi?id=5224#c14 -- Vincent Povirk

2 3

Re: inetcomm: Fix compilation on systems that don't support nameless unions.
by Marcus Meissner 18 Feb '08

18 Feb '08

On Mon, Feb 18, 2008 at 11:54:22AM +0100, Francois Gouget wrote: > --- > dlls/inetcomm/mimeole.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > diff --git a/dlls/inetcomm/mimeole.c b/dlls/inetcomm/mimeole.c > index a0da6b9..e986e7f 100644 > --- a/dlls/inetcomm/mimeole.c > +++ b/dlls/inetcomm/mimeole.c > @@ -1257,7 +1257,7 @@ static HRESULT WINAPI sub_stream_CopyTo( > ULARGE_INTEGER totalBytesRead; > ULARGE_INTEGER totalBytesWritten; > > - TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.LowPart, pcbRead, pcbWritten); > + TRACE("(%p)->(%p, %d, %p, %p)\n", iface, pstm, cb.u.LowPart, pcbRead, pcbWritten); > > totalBytesRead.QuadPart = 0; > totalBytesWritten.QuadPart = 0; > @@ -1525,7 +1525,7 @@ static HRESULT create_body_offset_list(IStream *stm, const char *boundary, struc > > zero.QuadPart = 0; > hr = IStream_Seek(stm, zero, STREAM_SEEK_CUR, &cur); > - start = cur.LowPart; > + start = cur.u.LowPart; > > do { > hr = IStream_Read(stm, overlap, PARSER_BUF_SIZE, &read); > @@ -1599,7 +1599,7 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IMimeBody_Load(mime_body, pStm); > zero.QuadPart = 0; > hr = IStream_Seek(pStm, zero, STREAM_SEEK_CUR, &cur); > - offset->cbBodyStart = cur.LowPart + offset->cbHeaderStart; > + offset->cbBodyStart = cur.u.LowPart + offset->cbHeaderStart; > if(parent) MimeBody_set_offsets(impl_from_IMimeBody(mime_body), offset); > IMimeBody_SetData(mime_body, IET_BINARY, NULL, NULL, &IID_IStream, pStm); > body = new_body_entry(mime_body, msg->next_hbody, parent); > @@ -1629,8 +1629,8 @@ static body_t *create_sub_body(MimeMessage *msg, IStream *pStm, BODYOFFSETS *off > IStream *sub_stream; > ULARGE_INTEGER start, length; > > - start.LowPart = cur->offsets.cbHeaderStart; > - length.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > + start.u.LowPart = cur->offsets.cbHeaderStart; > + length.u.LowPart = cur->offsets.cbBodyEnd - cur->offsets.cbHeaderStart; > create_sub_stream(pStm, start, length, &sub_stream); > sub_body = create_sub_body(msg, sub_stream, &cur->offsets, body); > IStream_Release(sub_stream); > @@ -1674,7 +1674,7 @@ static HRESULT WINAPI MimeMessage_Load( > > zero.QuadPart = 0; > IStream_Seek(pStm, zero, STREAM_SEEK_END, &cur); > - offsets.cbBodyEnd = cur.LowPart; > + offsets.cbBodyEnd = cur.u.LowPart; > MimeBody_set_offsets(impl_from_IMimeBody(root_body->mime_body), &offsets); > > list_add_head(&This->body_tree, &root_body->entry); > There seems to be damage in here, both ^M and lose 0s. Ciao, Marcus

1 0

Re: user32: Check for .ico and .cur magic.
by Dmitry Timoshkov 18 Feb '08

18 Feb '08

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > +#define ICON_DIB_SIZE 4264 It would be helpful to actually calculate the size instead of hardcoding the magic value. > + handle = LoadImageA(NULL, "icon.ico", IMAGE_CURSOR, 0, 0, LR_LOADFROMFILE); > + ok(handle != NULL, "LoadImage() failed.\n"); > + error = GetLastError(); > + ok(error == 0, "Last error: %u\n", error); > + > + /* Clean up. */ > + ret = DestroyIcon(handle); The fact that LoadImage has returned a not zero handle actually confirms nothing, you need to verify the contents of the loaded image with GetIconInfo. -- Dmitry.

1 0

re: iTunes
by Dan Kegel 18 Feb '08

18 Feb '08

E. Savage wrote: > Maarten why not focus on supporting applications that > don't have viable open source solutions first? iTunes doesn't have any alternatives for these functions: - purchasing songs from iTunes Store - activating iPhone - new ipod/iPhone syncing Anybody who buys an iPhone and can't activate it on their Linux PC will blame Linux and think it's crap. Even developers like jwz, I bet; see http://jwz.livejournal.com/494040.html So yeah, iTunes is important. - Dan

2 1

Winnowing the 1.0 bug list
by Dan Kegel 18 Feb '08

18 Feb '08

We now have about 100 bugs nominated for fixing in 1.0. Thanks to everybody who nominated bugs. Now it's time to winnow the list a bit. 1.0 bugs should be 'important' somehow, easy to reproduce, and have some chance of actually being fixed by, say, summer. The better understood a bug is, the more likely it is it can be fixed for 1.0, so even less important bugs can be 1.0 bugs if they're well enough understood and a patch is available. Here are a few bugs I'm thinking of deferring, and why: Not important enough http://bugs.winehq.org/show_bug.cgi?id=5807 Mercora IMRadio crashes http://bugs.winehq.org/show_bug.cgi?id=6048 Stokes crashes http://bugs.winehq.org/show_bug.cgi?id=8687 everestpoker and Programmer's Editor don't work http://bugs.winehq.org/show_bug.cgi?id=9288 Armed Assault doesn't load web page http://bugs.winehq.org/show_bug.cgi?id=9895 Alzip crashes Probably not doable by summer http://bugs.winehq.org/show_bug.cgi?id=609 Add BiDi support Not well enough understood: http://bugs.winehq.org/show_bug.cgi?id=6383 Dual-core not being correctly supported Do people agree with those assessments, and are there other bugs nominated for 1.0 that don't quite deserve it? - Dan

1 0

Re: [6/6] wined3d: take alpha from device palette entry for d3d 8 and later
by Stefan Dösinger 18 Feb '08

18 Feb '08

Am Montag, 18. Februar 2008 02:37:00 schrieb Alexander Dorofeyev: >/*can ddraw and d3d < 8 surfaces use device's palette (d3d >= 8 feature)?*/ No, they can't, there is no API to access them

2 1

Re: appdb feature request: hide the ugly urls
by Remco 18 Feb '08

18 Feb '08

> http://appdb.winehq.org/app/command-conquer-3-tiberium-wars/ > doesn't sound too bad, actually. And if somebody types in > an ambiguous URL, like > http://appdb.winehq.org/app/command-conquer > they should get a list of matching apps. So this is kind of > like a search function rather than a unique ID. > The difference being that apps would normally be > displayed at their shortest unique human-readable URL > rather than by ID #. > This may have an obscure but important benefit: I > read on the web somewhere that it boosts search engine rankings. > (Not that I'd know; I'm way away from that part of google.) > - Dan I'm pretty sure that's just because of the related words in the URL. An additional number doesn't hurt ranking. I know a lot of sites use an ID number and a title. The title makes it easy to see what the link points to. That's a usability benefit of itself. I don't think people should start using the URL bar as a search engine. The AppDB has a nice search engine already. And I think searching for literally all URLs is going to put a lot of strain on the server. Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

2 1

Usable Wine interface
by Remco 18 Feb '08

18 Feb '08

I'd like to add a feature-request (should this go somewhereelse?). What about making a Wine GUI to behave more like emulators likeVirtualBox. It's extremely hard right now to get Wine in desktop mode.It would be nice if you could start Wine as an application, which opensup a window like this: http://xs224.xs.to/xs224/08081/mockup918.png (ignore the virtualbox-stuff) And if you start one of those prefixes, it by default opens a WineDesktop with a simple Taskbar & Start-menu. Somewhere in theStart-menu could be the option to switch to desktop integration mode.There could also be an option to run the Wine Desktop full-screen. Likethis: http://xs224.xs.to/xs224/08081/winedesktop771.png (forgive my GIMP skills) I believe this would be very good for usability. Desktop mode is morestable than seamless mode, yet it's hidden in winecfg. This kind of UIalso exposes the prefix-functionality in a transparent way. Wouldn'tthat be a nice 1.0 polishing idea? Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

3 2

Re: Next big app(s) to try?
by Remco 18 Feb '08

18 Feb '08

I'd say, of the work-related apps, definitely MS Office 2007 (especially Outlook) and Internet Explorer 6 and 7. IE7 needs a lot of work still. IE6 doesn't break on any Wine bugs AFAIK, but needs a special environment to install correctly. A little Wine magic might help here. IE is one of the few native Windows parts that cannot reasonably be replaced. Web developers need to test their sites in the real thing. Of the fun-related apps, a few press-generating apps would be Crysis DX10-mode and iTunes (iPod sync). Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

2 1

Re: appdb feature request: hide the ugly urls
by Remco 18 Feb '08

18 Feb '08

----- Original Message ---- > From: Dan Kegel <dank(a)kegel.com> > To: wine-devel <wine-devel(a)winehq.org> > Sent: Sunday, February 17, 2008 6:55:06 PM > Subject: appdb feature request: hide the ugly urls > > How hard would it be for the appdb to support > more readable URLs for vendors and applications? e.g. > Adobe Premiere is currently at > http://appdb.winehq.org/objectManager.php?sClass=application&iId=128 > but it'd be so slick to see instead > http://appdb.winehq.org/adobe/premiere > > Believe it or not, that little change would make the appdb > less scary for newcomers. > - Dan That's relatively easy to do with mod_rewrite. But it would have to be something like: http://appdb.winehq.org/app/128/adobe-premiere.html All the info is still in the URL (which mod_rewrite can extract), but it does look less scary. Remco ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ

4 5

Re: dlls/shell32/pidl.c -- adjust to unsignedness of a type
by Alexandre Julliard 17 Feb '08

17 Feb '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -109,7 +109,7 @@ BOOL WINAPI ILGetDisplayNameExW(LPSHELLF > return FALSE; > } > > - if (type >= 0 && type <= 2) > + if (type <= 2) > { > switch (type) > { The test should probably be removed completely since there's already a default for it in the switch() that follows. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/6] ddraw: fix executebuffer branching with non-zero offset
by Stefan Dösinger 17 Feb '08

17 Feb '08

Am Montag, 18. Februar 2008 02:36:35 schrieb Alexander Dorofeyev: > Fixes a crash in Moto Racer 2. > --- > dlls/ddraw/executebuffer.c | 10 ++++++++-- > 1 files changed, 8 insertions(+), 2 deletions(-) The patches look good to me

1 0

appdb feature request: hide the ugly urls
by Dan Kegel 17 Feb '08

17 Feb '08

How hard would it be for the appdb to support more readable URLs for vendors and applications? e.g. Adobe Premiere is currently at http://appdb.winehq.org/objectManager.php?sClass=application&iId=128 but it'd be so slick to see instead http://appdb.winehq.org/adobe/premiere Believe it or not, that little change would make the appdb less scary for newcomers. - Dan

1 0

Re: dlls/msi/streams.c -- simplify and constify
by James Hawkins 17 Feb '08

17 Feb '08

On Nov 3, 2007 1:10 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > While removing the dead code I noticed that we can actually also > strengthen the const-ness of this function. > > Gerald > > ChangeLog: > Remove a check which never could trigger (due to the domain of the > variable in question) and increase const-ness of STREAMS_CreateView(). > > Index: dlls/msi/streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.7 > diff -u -3 -p -r1.7 streams.c > --- dlls/msi/streams.c 18 Oct 2007 13:00:57 -0000 1.7 > +++ dlls/msi/streams.c 3 Nov 2007 18:06:27 -0000 > @@ -430,7 +430,7 @@ static UINT add_streams_to_table(MSISTRE > return count; > } > > -UINT STREAMS_CreateView(MSIDATABASE *db, MSIVIEW **view) > +UINT STREAMS_CreateView(const MSIDATABASE *db, MSIVIEW **view) > { > MSISTREAMSVIEW *sv; > > @@ -444,9 +444,6 @@ UINT STREAMS_CreateView(MSIDATABASE *db, > sv->db = db; > sv->num_rows = add_streams_to_table(sv); > > - if (sv->num_rows < 0) > - return ERROR_FUNCTION_FAILED; > - > *view = (MSIVIEW *)sv; > > return ERROR_SUCCESS; > This change is wrong. If you'd actually read what the code intended to do instead of just fixing warnings, you'd see that add_streams_to_table returns -1 on error. While the check for < 0 is not correct, removing the check entirely is wrong. The check should be if (sv->num_rows == -1) return ERROR_FUNCTION_FAILED. -- James Hawkins

2 2

Re: Autoplay considered harmful
by Remco 17 Feb '08

17 Feb '08

Vista (and I think XP too) ask whether you want to start the Autorun program, or do a few other actions (open explorer, copy disk, etc). Remco ----- Original Message ---- > From: Evil Jay <wine(a)eternaldusk.com> > To: Steven Edwards <winehacker(a)gmail.com> > Cc: wine-devel <wine-devel(a)winehq.org>; Dan Kegel <dank(a)kegel.com> > Sent: Saturday, February 16, 2008 5:44:15 PM > Subject: Re: Autoplay considered harmful > > The purist in me says that WINE should not improve on Windows - it > should behave the same way, warts and all. If I had a vote, I'd vote to > enable it by default, but give the user an easy way to disable it in > winecfg. (And I'd immediately disable it the first time I ran Winecfg!) > > But, whatever you guys decide to do is cool - as long as you keep > cranking out this great package! :) > > -Jesse > > > > Steven Edwards wrote: > > On Feb 16, 2008 8:58 AM, Dan Kegel wrote: > > > >> > http://www.sfgate.com/cgi-bin/article.cgi?f=/c/a/2008/02/15/BU47V0VOH.DTL&t… > >> says that USB devices are being sold with infected > >> autorun apps. "If you plug in, you're already infected," > >> > >> I'd say that's a pretty good argument for not supporting autoplay... > >> > > > > I was actually thinking about this today. The right method would be to > > use HAL notification events to prompt the user if they want to autorun > > when sticking a new cdrom in. There could even be warning text in the > > dialog so that if it pops up with other device insertion, the user > > would know that it could be a virus. > > > > > > > > ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

5 4

Re: tools: add a wrapper script for starting files from file managers and make wine.desktop use it
by Vincent Povirk 17 Feb '08

17 Feb '08

Please do not commit this patch as explained in comment 18 of bug 5224: http://bugs.winehq.org/show_bug.cgi?id=5224#c18 Windows explorer's default behavior is to always start programs with double quotes around their filenames, even if the filename does not contain a space. Apparently, this is impossible (or more difficult than it's worth) to do in a shell script so I will need to rewrite this as a winelib program. On Feb 13, 2008 7:44 PM, Vincent Povirk <madewokherd+d41d(a)gmail.com> wrote: > This is an attempt to solve the problems with double-clicking .exe > files from file managers. > > The patch adds a script named winestartfile that mimics what happens > on windows when a file is double-clicked in explorer. It starts the > file using start.exe with the full path to the file and in the > directory that contains it. > > It also modifies the wine.desktop shortcut to use that script when > opening .exe files. > > My previous attempt at this incorrectly ran start without giving a > full path (so that if a file named start.exe exists in the current > path, it will take precedence) and probably tried to change too many > things at once. > > -- > Vincent Povirk > -- Vincent Povirk

1 0

New winetricks 20080216: fixed comctl32 override, hide winetrickscache, add --version option
by Dan Kegel 17 Feb '08

17 Feb '08

Austin nudged me into fixing comctl32 override, which has been broken since wine added support for sxs assemblies. He also was the third person to suggest hiding winetrickscache, so I guess it's what people want. And I added a --version option for a guy who said it would make packaging easier. As always, it's available at http://kegel.com/wine/winetricks and the svn repository is http://code.google.com/p/winezeug/ -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: WineD3D: add separate alpha blend support 3/3
by Stefan Dösinger 16 Feb '08

16 Feb '08

Am Samstag, 16. Februar 2008 17:29:31 schrieb Roderick Colenbrander: > Hi, > > This patch adds support for separate alpha blend one of the last > unimplemented D3D9 features. Here are a few suggestions: *) Setting WINED3DPMISCCAPS_SEPARATEALPHABLEND in directx.c should only be done if the extension is supported *) after the "GL_LINE_SMOOTH needs GL_BLEND to work, according to the", WINED3DRS_SEPARATEALPHABLENDENABLE should probably be removed from the if block. I don't think that blending should be enabled if the WINED3DRS_ALPHABLENDENABLE is off. A test would be helpful for certainty. *) The code translating the separate blending settings could be moved into the if(stateblock->renderState[WINED3DRS_SEPARATEALPHABLENDENABLE]) block. That way they are only executed if they're needed(The compiler may take care of that though) *) The separate blend states should be grouped with the alpha states, ie, set the representative to STATE_RENDER(WINED3DRS_ALPHABLENDENABLE) instead of STATE_RENDER(WINED3DRS_SEPARATEALPHABLENDENABLE). Not doing that should not cause any rendering problems because the whole alpha blend states are set every time, but grouping them will improve performance. (e.g., if alphablendenable and separatealphaenable are changed state_blend is only executed once, not twice) *) The blendop is currently not reapplied if WINED3DRS_SEPARATEALPHABLENDENABLE is changed. One solution is to group the blendops with alphablend and move the code from state_blendop to state_blend. A better way is to make this a one-way dependency from state_alpha to state_blend. Compare STATE_RENDER(WINED3DRS_LIGHTING) and STATE_VDECL for a reference.

1 0

X developer's conference, April 16-18
by Dan Kegel 16 Feb '08

16 Feb '08

http://www.x.org/wiki/Events/XDC2008 Seems like Wine might want a representative. What issues would we want to bring up there? - relative mouse motion events ...? - Dan

3 3

MSG_PEEK race in urlmon_test?
by Francois Gouget 16 Feb '08

16 Feb '08

When I run the urlmon_test test the kernel (2.6.22.9) has this to say: Feb 16 05:53:54 amboise kernel: TCP(urlmon_test.exe:9836): Application bug, race in MSG_PEEK. Does anyone know what's up with that? Maybe someone who knows more than me about urlmon? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0

Re: wined3d: Fix bug in swapchain release which causes incorrect display mode changes.
by Chris Robinson 16 Feb '08

16 Feb '08

On Saturday 16 February 2008 06:01:48 am Peter Dons Tychsen wrote: > Fixed bug in wined3d swapchain, which caused the release of the > swap-chain to mess around with the display-modes set by ddraw. Also > added test-case for this scenario. Reworked test code minimally, to > re-use existing test code. You may want to test D3D8 and D3D9 too, to see what they do when presented by the situation (since the code is shared). Also I don't think you should make those 2-space indents just to avoid changing those few lines.

1 0

Re: winedos: Allocate a console when loading dos applications
by Maarten Lankhorst 16 Feb '08

16 Feb '08

Hi all, 2008/2/14, Dmitry Timoshkov <dmitry(a)codeweavers.com>: > "Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > > > > It worked before ba896e75d7fce68e5183007b65eae7e35490ccd4. (Around > > wine 0.9.33 or so) After that it was broken. I have a wine 0.9.9 that > > when run does create a seperate console for dos apps. My guess is that > > somewhere in the initialisation allocconsole would have to be called. > > > You need to talk to Alexandre since that's his patch. Still, there is > no AllocConsole() call removed by that commit, so it has nothing to do > with the regression. I've done a bunch of tests with a simple mingw app linked with -mconsole and found the following results (in xp sp2 vmware): - Asynchronous calls are not available for console handles (ReadFile only works in synchronous mode, ReadFileEx doesn't work) - I can do WaitForSingleObject(GetStdHandle(STD_INPUT_HANDLE), INFINITE); and it will only return when there is data to be read, like a key being pressed. in wine it will return immediately, this causes the breakage of dos apps after wine 0.9.33. These things make me think that the old behavior of wine is more correct then the current one, with relation to console handles. -Maarten.

2 1

Re: d3dx9 patches
by tony.wasserka＠freenet.de 16 Feb '08

16 Feb '08

Okay, thanks. Then I'll just resend them and see if they get in this time. Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

re: gecko download not robust?
by marco 15 Feb '08

15 Feb '08

> > Hmm. gecko download hung for me once. I saw > fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 > in the log, which makes me wonder if our download code > doesn't handle transient network errors well. > > Time to get rid of the download, and just bundle gecko outright, I say... I make the mandriva rpms for wine. This would make the rpms 30% bigger. And you would download the same gecko binary over and over again with every new version. But if that is not a problem than it can be easily done.

7 12

[PATCH] msvcrt: Fix scanf floating-point exponent handling.
by Jānis Rūcis 15 Feb '08

15 Feb '08

This patch modifies the scanf floating-point algorithm to pass the tests I sent in my previous message. --- dlls/msvcrt/scanf.h | 40 +++++++++++++++++++++++++--------------- 1 files changed, 25 insertions(+), 15 deletions(-) diff --git a/dlls/msvcrt/scanf.h b/dlls/msvcrt/scanf.h index 7fe3cc4..66df15e 100644 --- a/dlls/msvcrt/scanf.h +++ b/dlls/msvcrt/scanf.h @@ -241,6 +241,12 @@ _FUNCTION_ { case 'G': { /* read a float */ long double cur = 0; int negative = 0; + + int decimal_places = 0; + unsigned int exponent = 0; + int negexp = 0; + long double be; + /* skip initial whitespace */ while ((nch!=_EOF_) && _ISSPACE_(nch)) nch = _GETC_(file); @@ -268,20 +274,17 @@ _FUNCTION_ { } /* handle decimals */ if (width!=0 && nch == '.') { - float dec = 1; nch = _GETC_(file); if (width>0) width--; while (width!=0 && (nch!=_EOF_) && _ISDIGIT_(nch)) { - dec /= 10; - cur += dec * (nch - '0'); + cur = cur * 10 + (nch - '0'); + decimal_places += 1; nch = _GETC_(file); if (width>0) width--; } } /* handle exponent */ if (width!=0 && (nch == 'e' || nch == 'E')) { - int exponent = 0, negexp = 0; - float expcnt; nch = _GETC_(file); if (width>0) width--; /* possible sign on the exponent */ @@ -292,20 +295,27 @@ _FUNCTION_ { } /* exponent digits */ while (width!=0 && (nch!=_EOF_) && _ISDIGIT_(nch)) { - exponent *= 10; - exponent += (nch - '0'); + exponent = exponent * 10 + (nch - '0'); nch = _GETC_(file); if (width>0) width--; } - /* update 'cur' with this exponent. */ - expcnt = negexp ? .1 : 10; - while (exponent!=0) { - if (exponent&1) - cur*=expcnt; - exponent/=2; - expcnt=expcnt*expcnt; - } } + + /* Combine exponent with decimal point. */ + for (; decimal_places > 0; decimal_places--) + { + if (exponent == 0) + negexp = 1; + + exponent += negexp ? +1 : -1; + } + + /* Perform exponentiation. */ + for (be = 1.0; exponent > 0; exponent--) + be *= 10.0; + + cur = negexp ? cur / be : cur * be; + st = 1; if (!suppress) { if (L_prefix) _SET_NUMBER_(long double); -- 1.5.3.8

1 0

d3dx9 patches
by tony.wasserka＠freenet.de 15 Feb '08

15 Feb '08

Hi, It's nearly two weeks ago that I sent those patches, so I was curious if there are any problems with it? http://www.winehq.org/pipermail/wine-patches/2008-February/049554.html http://www.winehq.org/pipermail/wine-patches/2008-February/049667.html http://www.winehq.org/pipermail/wine-patches/2008-February/049677.html http://www.winehq.org/pipermail/wine-patches/2008-February/049679.html http://www.winehq.org/pipermail/wine-patches/2008-February/049705.html

2 1

Windows Mobile API
by Arthur Maciel 15 Feb '08

15 Feb '08

Hi there. I´m not part of the mailing list, but I really want to know if there is any port of WINE to support Windows Mobile API (that is Windows for pocket pc, handhelds and pocket phones). This would come as a great solution for me, as I need specific WM programs on my pda. I really appreciate any help and information. Regards, Arthur

2 3

Google's support for Wine in 2007
by Dan Kegel 15 Feb '08

15 Feb '08

As you might know, I work for Google, and part of my day job is to help improve Wine. Here's a little report about what we've been up to. Google uses Wine primarily as the basis for the Linux port of our photo management software, Picasa. In fact, the Linux version is exactly the Windows build of Picasa, bundled with a lightly patched version of Wine. Most of the work in that port was to improve Wine so it could handle Picasa, and that work is still going on. Codeweavers did the initial port, and Googlers Lei Zhang, Nigel Liang, and Michael Moss are improving Wine further for Picasa 2.7. Beyond Picasa, a few of us (Lei Zhang, Alex Balut, and I) have been fixing random Wine bugs in our 20% time. I've also been doing regular Valgrind runs over the Wine test suite, pestering developers who accidentally check in code that Valgrind doesn't like. Hats off to the Valgrind team for a great tool, and to the (non-Google) folks who work on Valgrind/Wine compatibility (Eric Pouech, Tom Hughes, and John Reiser, among others). Google also sponsored some work by Codeweavers to improve support for Photoshop ('cause so many people want it) and for Dragon Naturally Speaking ('cause even Linux users get RSI). While not yet perfect, those apps are a lot more usable now as a result. In particular, Photoshop CS and CS2 are quite usable indeed. (See http://wiki.winehq.org/AdobePhotoshop for details.) I also had the pleasure of hosting eight students as Google interns working on Wine throughout the year. Here are their names, and roughly what they worked on: Dan Hipschman: widl Evan Stade: gdiplus, Powerpoint Viewer James Hawkins: msi Jennifer Lai: win16 conformance tests Juan Lang: crypt32, iTunes Matt Jones: mono testing Mikolaj Zalewski: Photoshop, Limux Roy Shea: svchost, BITS So, you're wondering, what exactly does that all boil down to? I tallied all our accepted patches recently; the list is now up (along with the exact Wine source we use for Picasa) at http://code.google.com/opensource/wine.html I was pleasantly surprised at the size of the list. Separately, Google also sponsored nine Summer of Code students this year. Just to name two who remain active even after the end of summer: Alex Sørnes, who improved Wine's Wordpad, and Maarten Lankhorst, who solved tons of sound problems. (And oh, how nice it is to not have to change sound settings anymore!) All that may sound like a lot, and perhaps it is, but it pales compared to the work put in on Wine by the rest of the Wine developers. Thanks, everybody! I'm really looking forward to Wine 1.0 (which, according to Alexandre, is planned for sometime in 2008). Dan Kegel Software Engineer Google

5 6

Re: [PATCH] winex11.drv: get hwnd for injected mouse events
by Alexandre Julliard 15 Feb '08

15 Feb '08

"Lei Zhang" <thestig(a)google.com> writes: > --- a/dlls/winex11.drv/mouse.c > +++ b/dlls/winex11.drv/mouse.c > @@ -278,6 +278,7 @@ void X11DRV_send_mouse_input( HWND hwnd, DWORD flags, DWORD x, DWORD y, > { > pt.x = (x * screen_width) >> 16; > pt.y = (y * screen_height) >> 16; > + hwnd = GetAncestor(WindowFromPoint(pt), GA_PARENT); This should not be needed, for injected events the window is determined on the server side. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: systray [4/4]: implement systray transparency
by Kirill K. Smirnov 15 Feb '08

15 Feb '08

> We don't want to export such a specific function. Besides, it should > really be setting the window shape. I've just understood why we cannot rely upon setting window shape to get transparency. Let's consider almost empty icon or even empty - this may happen when application "flashes" icon, e.g. on incoming ICQ message. 1) Can be there active windows with empty visible area? 2) This windows do not correctly relay mouse events. -- Kirill

1 0

Re: systray [4/4]: implement systray transparency
by Kirill K. Smirnov 15 Feb '08

15 Feb '08

> "Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > > diff --git a/dlls/winex11.drv/winex11.drv.spec > > b/dlls/winex11.drv/winex11.drv.spec index 36b83d7..126cbc5 100644 > > --- a/dlls/winex11.drv/winex11.drv.spec > > +++ b/dlls/winex11.drv/winex11.drv.spec > > @@ -130,6 +130,7 @@ # Desktop > > > > # System tray > > @ cdecl wine_make_systray_window(long) X11DRV_make_systray_window > > +@ cdecl wine_systray_window_clear(long) X11DRV_systray_window_clear > > We don't want to export such a specific function. Besides, it should > really be setting the window shape. Do I understand you correct that we should cut off transparent parts of icon, thus making window shape to match solid part of icon? Taking into account that almost every xembed-systray-aware application uses ParentRelative attribute (and KDE developers assumes this as I noticed at bug #3534), the idea of changing window shape sounds really strange. 1) Is there any strong reason why we really must change windows shape to achieve visual transparency? 2) Will it be better to stop embedding wine windows in favor of embedding pure X windows (like other apps do)? This way assumes implementing all xembed-specific stuff at winex11.drv side and exporting ONLY ONE function like wine_xembed_systray_handler(int cmd, void *data), which converts windows icon to X11 icon, creates X11 window with ParentRelative bkgrnd and embeds it. Explorer will use this function when it adds/removes icon to/from system tray. Also, this function will detect the case of wine virtual desktop and notify explorer to stop using xembed. I'm just not sure that this way will not break relaying mouse events. -- Kirill

2 1

Re: shell32: Fix character count passed into lstrcpnA in SHGetDataFromIDListA.
by Francois Gouget 15 Feb '08

15 Feb '08

if (shortname) - lstrcpynA(pfd->cAlternateFileName, shortname, MAX_PATH); + lstrcpynA(pfd->cAlternateFileName, shortname, 14); sizeof(*pfd->cAlternateFileName) would be better than the magic 14 here. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

1 1

Re: Don't use GetExceptionCode and GetExceptionInformation in exception filter functions.
by Alexandre Julliard 15 Feb '08

15 Feb '08

Robert Shearman <rob(a)codeweavers.com> writes: > Alternatively, we could get rid of the WINE_EXCEPTION_FILTER and > WINE_FINALLY_FUNC functions and make users of __EXCEPT and __FINALLY > declare the functions themselves and access the exception data > directly without use of macros. That would be better, the macros only make sense if we can use the standard ones. If we have to use a Wine-specific approach anyway then the macros are just making it harder to see what's going on. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ddraw / wined3d fighting over the resolution!
by Peter Dons Tychsen 15 Feb '08

15 Feb '08

On Thu, 2008-02-14 at 09:18 +0100, Stefan Dösinger wrote: > Am Donnerstag, 14. Februar 2008 04:22:16 schrieb Peter Dons Tychsen: > > Why does the SwapChain-destroy function play around with the resolution > > at all. Is that really necessary? I think it should not do it if the > > caller is ddraw at least. > I thought I'm filtering this out in the case of ddraw, but maybe that got > lost. The reason why the swapchain restores the resolution is the different > way ddraw/d3d8 and d3d8/d3d9 set up the screen. > > In ddraw the app calls IDirectDraw7::SetDisplayMode. This sets the mode. Then > it creates a DDSCAPS_PRIMARYSURFACE surface, which creates the swapchain. > > In d3d8/d3d9 the swapchain controls the video mode > > I think the problem is that RestoreDisplayMode is called before the primary > surface is destroyed. The question is why this happens. I can think of the > following reasons: > > -> Refcounting problem, or the app just doesn't release the surfaces. Then > ddraw.dll destroys the objects on DLL_PROCESS_DETACH > > -> The app calls it that way. This needs a test, but I think it is not allowed > to call SetDisplayMode / RestoreDisplayMode while a primary surface is around OK, i have now eaten enough wine-gums to comprehend this.... I think there is a general problem in swapchain->release. The swapchain should only change the resolution back to the original *if* the current resolution is still the same as the swapchain enforced. If someone else has intervened, it should let it be. This fixes the problem at hand, but would also fix other silly problems. Some could for example have called Release() while the "window" is not even visible (tabbed to desktop for example). Please review my patch and let med know if it is submittable. If you hate it, i will eat more wine-gums. :-) /pedro

2 1

What's up with GetPrivateProfileString?
by Johan Gill 15 Feb '08

15 Feb '08

http://bugs.winehq.org/show_bug.cgi?id=5424 The bug above is causing me some confusion regarding how GetPrivateProfileString should behave. Wine looks for maxis.ini in C:\Windows, and does not find it there. Therefore, Setup.exe exits. MSDN claims that if an absolute path is not provided, the windows directory is searched for the file. There are also some registry things to take into account, but maxis.ini should not be referenced in the registry since it is located on a CD-ROM and read before the autorun screen is shown. It seems very likely that GetPrivateProfileString on real Windows with just a filename as path argument looks in the current directory, but it would be nice if someone with a real Windows installation would check that. I can have a try at writing the test source if necessary.

1 0

Re: include: Fix the C_ASSERT macro to not generate an unused variable warning when compiling with gcc.
by Alexandre Julliard 15 Feb '08

15 Feb '08

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -279,10 +279,10 @@ extern "C" { > > /* Compile time assertion */ > > -#if defined(_MSC_VER) > +#if defined(_MSC_VER) || defined(__GNUC__) > # define C_ASSERT(e) typedef char __C_ASSERT__[(e)?1:-1] > -#elif defined(__GNUC__) > -# define C_ASSERT(e) extern char __C_ASSERT__[(e)?1:-1] > +#else > +# define C_ASSERT(e) This will break if you do two C_ASSERTs in the same scope. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] Add IRunnableTask interface (resend)
by Alexandre Julliard 15 Feb '08

15 Feb '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > I have no idea why it wasn't applied, so this is a resend with no modifications. It should go in shobjidl.idl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: systray [4/4]: implement systray transparency
by Alexandre Julliard 15 Feb '08

15 Feb '08

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > diff --git a/dlls/winex11.drv/winex11.drv.spec b/dlls/winex11.drv/winex11.drv.spec > index 36b83d7..126cbc5 100644 > --- a/dlls/winex11.drv/winex11.drv.spec > +++ b/dlls/winex11.drv/winex11.drv.spec > @@ -130,6 +130,7 @@ # Desktop > > # System tray > @ cdecl wine_make_systray_window(long) X11DRV_make_systray_window > +@ cdecl wine_systray_window_clear(long) X11DRV_systray_window_clear We don't want to export such a specific function. Besides, it should really be setting the window shape. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winedos: Allocate a console when loading dos applications
by Dmitry Timoshkov 15 Feb '08

15 Feb '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Fixes bug 9178. > > I was looking hard at it, then I had to laugh, hard, when I found this > simple fix. This patch is not correct, think for instance of all win16 applications. -- Dmitry.

1 0

re: Fixing the last failing tests
by Dan Kegel 15 Feb '08

15 Feb '08

Maarten wrote: > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); Maybe you can do something like if (CreateWindowExW doesn't work) { /* win95 without MSLU */ ok(!IsWindowUnicode()); } else { /* win95 with MSLU, or something with native unicode support */ ok(IsWindowUnicode()); }

2 3

[RFC] winecfg enhancements
by Reece Dunn 15 Feb '08

15 Feb '08

Hi, I am looking at how we can make winecfg more useful. I have already supplied patches to allow importing a ubuntu human theme to work :). So I am now looking at how to build on that. On the Desktop Integration tab, I am planning on adding the following improvements: * Split the Appearance section into Theme and Appearance. The rationale behind this is while the two are linked, they are also distinct. It will make it possible to simplify "Install theme..." to just "Install...", and support enhancements below. * Pre-populate the Theme list with themes in WINDOWS/Resources/Themes and with other *.theme files added by the user. The rationale behind this is that it simplifies the workflow for the average usage (e.g. install a theme, then select it). * Rename "Install theme..." to "Add...". The rationale is that we are not installing a theme, but setting it as the theme being used. Having the theme appear in the Themes list in the future further supports this name change and workflow. * Rename "(No Theme)" to "Wine Default". The rationale behind this is that it isn't true that there is no theme installed (in the sense that a theme can be a set of colours and metrics). * Provide an "Export..." button to the Themes section. The rationale behind this is that it makes it easier to create, modify and preview themes being created. Therefore, you could create a Ubuntu Human or Oxygen theme from winecfg. * Make the theme importer read the themes [Theme]/DisplayName property. The rationale behind this is to make the display name user friendly. * Add --import-theme command line support to winecfg. The rationale behind this is to support loading a theme via a script (e.g. post-install configuration), without resorting to the winecfg GUI. * Make the shell folders a drop down list. The rationale behind this is that it is unclear what "link to" applies to. An alternative is to make the listview have the showselalways flag, so it is clearer what folder "link to" is relating to. Q: Should we provide a --simple mode for winecfg that has the work flow that Ubuntu is planning? Not specifying --simple would bring up the standard winecfg dialog. - Reece

8 10

Re: mscms: [GS]etColorSpace() are not supposed to be defined in icm.h.
by Detlef Riekenberg 14 Feb '08

14 Feb '08

On Mi, 2008-02-13 at 21:52 +0100, Francois Gouget wrote: > diff --git a/include/icm.h b/include/icm.h The end of the attached Patchfile is broken: > &#;& -- By by ... Detlef

2 1

gecko valgrind errors show up better now
by Dan Kegel 14 Feb '08

14 Feb '08

The new version of valgrind shows better stack dumps for gecko valgrind errors. For instance, Invalid read of size 4 at (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/components/xppref32.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by load_gecko (nsembed.c:396) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) Address 0x7f22e1e0 is not stack'd, malloc'd or (recently) free'd Invalid read of size 4 at (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) by notif_wnd_proc (binding.c:184) Address 0x7f22e108 is not stack'd, malloc'd or (recently) free'd Conditional jump or move depends on uninitialised value(s) at (within 0.1.0/wine_gecko/components/necko.dll) by nsURI_QueryInterface (nsio.c:1181) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by (within 0.1.0/wine_gecko/components/necko.dll) by nsIOService_NewChannelFromURI (nsio.c:2111) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/rdf.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/components/chrome.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) Invalid read of size 4 at (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/components/xpc3250.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/xpcom_core.dll) by (within 0.1.0/wine_gecko/components/profile.dll) by load_gecko (nsembed.c:338) by NSContainer_Create (nsembed.c:1574) by HTMLDocument_Create (htmldoc.c:1232) by ClassFactory_CreateInstance (main.c:206) by CoCreateInstance (compobj.c:2411) by report_data (binding.c:444) by report_data_proc (binding.c:1262) by notif_wnd_proc (binding.c:184) by (within /home/dank/wine-git/dlls/user32/user32.dll.so) Address 0x7f22d1a8 is not stack'd, malloc'd or (recently) free'd etc., etc. Jacek, if you can give me a debug build of gecko, I can probably give you even better info. Interested? - Dan

2 1

Re: ddraw / wined3d fighting over the resolution!
by Peter Dons Tychsen 14 Feb '08

14 Feb '08

Hello S. I have studied this a bit more. The app seems to do this purposely. In any case wined3d should not change the mode in this case. Either wined3d must detect this, or the code should be moved into d3d8/d3d9. On a similar note, i found i found a funny "RestoreDisplayMode()" call in "SetCooperateLevel()", when switching from full-screen. I tested with win-xp, and here this does not happen. This causes additional mode-switch flicker. I think i will chew on some nice German wine-gums (Haribo), and then send some patches :-). mmmmmm.... wine-gums.... they should sell them on wine.org... would be appropriate... :-) /p On Thu, 2008-02-14 at 09:18 +0100, Stefan Dösinger wrote: > Am Donnerstag, 14. Februar 2008 04:22:16 schrieb Peter Dons Tychsen: > > Why does the SwapChain-destroy function play around with the resolution > > at all. Is that really necessary? I think it should not do it if the > > caller is ddraw at least. > I thought I'm filtering this out in the case of ddraw, but maybe that got > lost. The reason why the swapchain restores the resolution is the different > way ddraw/d3d8 and d3d8/d3d9 set up the screen. > > In ddraw the app calls IDirectDraw7::SetDisplayMode. This sets the mode. Then > it creates a DDSCAPS_PRIMARYSURFACE surface, which creates the swapchain. > > In d3d8/d3d9 the swapchain controls the video mode > > I think the problem is that RestoreDisplayMode is called before the primary > surface is destroyed. The question is why this happens. I can think of the > following reasons: > > -> Refcounting problem, or the app just doesn't release the surfaces. Then > ddraw.dll destroys the objects on DLL_PROCESS_DETACH > > -> The app calls it that way. This needs a test, but I think it is not allowed > to call SetDisplayMode / RestoreDisplayMode while a primary surface is around

1 0

Re: Weird failure in kernel32 volume test
by Maarten Lankhorst 14 Feb '08

14 Feb '08

Hi Jeremy, 2008/2/14, Jeremy White <jwhite(a)winehq.org>: > Anyone else has some tests that consistently fail on make test? > > > As of last nights git tip, I still had four failures: > > http://test.winehq.org/data/20080213/#Wine I submitted a patch for the comm test. I'm not 100% sure about the shelllink test. On that site there is also a failure for 'volume' which I experienced as well. I have really no idea what causes it though, but it looks like aj has done some work on it. Maybe you have any idea alexandre? Cheers, Maarten.

1 0

Re: wined3d: fix memcpy with wrong size parameter to simple assignment in GetScissorRect
by Stefan Dösinger 14 Feb '08

14 Feb '08

Am Mittwoch, 13. Februar 2008 21:58:39 schrieb Rico Schüller: > Hi, > > this fixes the GetScissorRect function in wined3d. This is required for > the game Gothic3 where the misbehavior is seen. The patch looks ok to me

1 0

Weird failure in kernel32 volume test
by Maarten Lankhorst 14 Feb '08

14 Feb '08

Hi all, The latest update of trying to be the second person for which all tests succeed. I sent a bunch of patches that make some tests pass. At the moment I have 3 failures on a clean wineprefix, with no icons on my desktop, and with wine in native window mode on kde 3.5.x: user32: 'msg' test fails. The famous 'win' test passes. kernel32: I get a very weird bug on the 'volume' test. It only occurs when I run my mini script for running the tests. I have absolutely no idea why I get ERROR_FILE_NOT_FOUND on FindFirstVolumeA on the first time I run the whole testsuite, and not successive runs. Anyone has experienced the same, or have an idea what is going on? msi: multi-sz failure in msi install, I did a todo_wine on it so it doesn't stop the build. It seems to be a recent failure though because I know that it didn't bomb out on install a few days ago. Anyone else has some tests that consistently fail on make test? Cheers, Maarten.

4 3

OUTB() and friends on Win32 and .sys files(Resent)
by Uwe Bonnes 14 Feb '08

14 Feb '08

Hallo, some programm with source uses giveio.sys to access the parallel port. You can find the source for giveio.sys e.g. in the avrdude package. We have code in dlls/winedos/ppdev.c to emulate the directed access on the parallel port to accesses to /dev/ppdev. However this code is not called for WIN32 code. So after starting giveio with loaddrv.exe supplied with giveio > wine loaddrv.exe start giveio starting giveio... ok. > wine javr.exe crashes when the outb access happens: javr [<filename>] [-p<port>] [-f<fusefilename>] [-e<eepromfilename>] [-L] [-V] Allocated flash buffer of 128K Using giveio.sys to gain port access to 0x378 trace:seh:raise_exception code=c0000096 flags=0 addr=0x4014b6 trace:seh:raise_exception eax=00000000 ebx=00000000 ecx=00000378 edx=00000378 esi=00000378 edi=00110388 trace:seh:raise_exception ebp=0072fe50 esp=0072fe50 cs=0073 ds=007b es=007b fs=0033 gs=003b flags=00010246 trace:seh:call_stack_handlers calling handler at 0x7eddc5bc code=c0000096 flags=0 trace:seh:MSVCRT_signal (4, (nil)) wine: Unhandled privileged instruction at address 0x4014b6 (thread 0011), starting debugger... trace:seh:start_debugger Starting debugger "winedbg --auto 16 56" trace:seh:call_stack_handlers handler at 0x7eddc5bc returned 1 Unhandled exception: privileged instruction in 32-bit code (0x004014b6). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:004014b6 ESP:0072fe50 EBP:0072fe50 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:00000000 ECX:00000378 EDX:00000378 ESI:00000378 EDI:00110388 Stack dump: 0x0072fe50: 0072fe58 0040151a 0072fe88 00406ccf 0x0072fe60: 00000378 00000000 00000000 00403411 0x0072fe70: 00000001 00110388 0072fe88 0040a3ef 0x0072fe80: 0040a3ef 00000001 0072fec8 004025e4 0x0072fe90: 00000378 00000378 00110048 0040255c 0x0072fea0: 7ed5ff48 7ffdf000 0072fec8 7ed30f5c Backtrace: =>1 0x004014b6 outb+0x6(value=0x0, port=0x378) [/spare/bon/jtagprog/win/javr-2.8/ppiwin.c:311] in javr (0x0072fe50) MS msvcrt.dll also supplies outb(). What is the policy to handle outb() and friends? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: Resend pdh[3:3]: remove unnecessary test done in PdhLookupPerfNameByIndexW
by Hans Leidekker 14 Feb '08

14 Feb '08

On Thursday 14 February 2008 09:57:32 am Jeff Latimer wrote: > + machineW = pdh_strdup_aw( machine ); > + > + if (!(ret = PdhLookupPerfNameByIndexW( machineW, index, bufferW, &sizeW ))) In the unlikely event that pdh_strdup_aw fails the query will be run on the local machine instead of the remote machine. Please check for allocation failures like most other functions in there do. -Hans

3 2

[advapi32/tests] Don't crash tests for NT4
by Paul Vriens 14 Feb '08

14 Feb '08

Hi, (Deliberately sent here and not to wine-patches). Hopefully someone can shed some light on this. I need this patch to have the security tests not crash on NT4. The part about the missing function is obvious. What is not so obvious though is that when I leave the LocalFree(NewAcl) in, the test crash. If I only do the LocalFree on success (as stated btw on MSDN for this function) this test doesn't crash. AFAIK LocalFree deals with passed NULL pointers so there must be something else going on. Changelog Don't crash tests for NT4 -- Cheers, Paul.

1 0

ddraw / wined3d fighting over the resolution!
by Peter Dons Tychsen 14 Feb '08

14 Feb '08

Hi Stefan/Devs. The funny old game "Insane" has a resolution bug when it exits. I am not sure exactly how to fix this. 1) It call SetDisplayMode() - switches from 1280 x 1024 -> 640 x 480. OK. 2) It creates a 3D surface which starts the SwapChain - swapchain saves current resolution. 3) Exit. It calls RestoreDisplayMode() - switches back to 1280 x 1024. OK. 4) SwapChain is destroyed. Switches "back" to 640 x 480 ! BAD! I presume the code guesses that the caller does this in another sequence (and it does work fine in other sequences). Why does the SwapChain-destroy function play around with the resolution at all. Is that really necessary? I think it should not do it if the caller is ddraw at least. How do i fix this? Thanks, /pedro

2 1

Almost done...
by Maarten Lankhorst 14 Feb '08

14 Feb '08

Hi all, Right now I got down to only the user32 msg test failing (minus the todo's). I solved the user32 win test with a very high-tech solution: Remove all icons from my desktop, which prevents the stupid file description popup from failing the user32 win test. The other way would be to run it in a wine desktop which would also prevent this (I got no failures on runtest, except the todo's). The msg tests are more difficult. For some reason I accidentally passed them once, when I had the debug scrolling on. But after that there were always failures on my pc. Is there any way to sync those so that it is less prone to timing issues? Cheers, Maarten.

1 0

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

OK. I still think he should put a FIXME remark in the test-case, and document why Sleep() is needed. Someone might fix the driver someday. The only reason i yelled "alert!", is that i have seen so much bad code which has come to a state where the are Sleep(143) here and Sleep(1332) there, where nobody can remember why they are there and what the Sleep count represents (most of the time no-one ever knew! :-)). In the mean time, the real bugs just getter harder to find, as they are covered by all the messy Sleeps(). I see allot of this kind of yap in telecom embedded software (mobile phones etc.). In this case Maarten probably knows what he is doing (he usually does). But thanks for the follow up! And now i will go to Sleep(). Thanks, /p On Wed, 2008-02-13 at 11:28 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 03:11:24 schrieb Peter Dons Tychsen: > > Eh, this does not seem like a proper way to get a unit test to pass. > > > > Sleep()... that leads to the dark side! :-) > I talked to Maarten on IRC about this. The problem seems to be that his > monitor takes ages to mode switch, but ChangeDisplaySettings returns before > this modeswitch is done. Also the opengl driver attempts to draw before the > setup is ready, which fails and causes the test failures. > > So it sounds like a driver bug which will only affect the tests(since games > draw repeatedly and do not care if the first few frames do not render > properly)

1 0

Re: [PATCH] include: add ISampleGrabber interface
by Lei Zhang 13 Feb '08

13 Feb '08

On Feb 13, 2008 3:03 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This patch adds the ISampleGrabber interface, also needed by IMediaDet. > Bah, let me try again. Just realized I forgot to pass -n to git format-patch as well.

1 0

Re: msxml3: Implement IXMLDOMDocument IDispatch interface
by Alistair Leslie-Hughes 13 Feb '08

13 Feb '08

Hi, Was there anything wrong with this patch? Dont commit this patch if nothing is wrong. I will submit a series of patches, that will include these changes. Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fnchqv$a5r$1@ger.gmane.org... > Hi, > > Fixes bug http://bugs.winehq.org/show_bug.cgi?id=11257 > > Changelog: > msxml3: Implement IXMLDOMDocument IDispatch interface > > Best Regards > Alistair Leslie-Hughes > -------------------------------------------------------------------------------- > From 7cc5228684ed6d9aaace829cc1b8ebb43e5f4325 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 25 Jan 2008 22:34:36 +1100 > Subject: [PATCH] Implement IXMLDOMDocument IDispatch interface > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msxml3/domdoc.c | 53 +++++++++++++++++++++++++++++++++------ > dlls/msxml3/main.c | 58 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/msxml3/msxml_private.h | 8 ++++++ > 3 files changed, 111 insertions(+), 8 deletions(-) > > diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c > index 06388c8..9d6b94b 100644 > --- a/dlls/msxml3/domdoc.c > +++ b/dlls/msxml3/domdoc.c > @@ -416,16 +416,29 @@ static ULONG WINAPI domdoc_Release( > > static HRESULT WINAPI domdoc_GetTypeInfoCount( IXMLDOMDocument2 *iface, > UINT* pctinfo ) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + > + TRACE("(%p)->(%p)\n", This, pctinfo); > + > + *pctinfo = 1; > + > + return S_OK; > } > > static HRESULT WINAPI domdoc_GetTypeInfo( > IXMLDOMDocument2 *iface, > UINT iTInfo, LCID lcid, ITypeInfo** ppTInfo ) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + HRESULT hr; > + > + TRACE("(%p)->(%u %u %p)\n", This, iTInfo, lcid, ppTInfo); > + > + hr = get_typeinfo(IXMLDOMDocument2_tid, ppTInfo); > + if(SUCCEEDED(hr)) > + ITypeInfo_AddRef(*ppTInfo); > + > + return hr; > } > > static HRESULT WINAPI domdoc_GetIDsOfNames( > @@ -436,8 +449,21 @@ static HRESULT WINAPI domdoc_GetIDsOfNames( > LCID lcid, > DISPID* rgDispId) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + ITypeInfo *typeinfo; > + HRESULT hr; > + > + TRACE("(%p)->(%s %p %u %u %p)\n", This, debugstr_guid(riid), > rgszNames, cNames, > + lcid, rgDispId); > + > + if(!rgszNames || cNames == 0 || !rgDispId) > + return E_INVALIDARG; > + > + hr = get_typeinfo(IXMLDOMDocument2_tid, &typeinfo); > + if(SUCCEEDED(hr)) > + hr = ITypeInfo_GetIDsOfNames(typeinfo, rgszNames, cNames, > rgDispId); > + > + return hr; > } > > > @@ -452,8 +478,19 @@ static HRESULT WINAPI domdoc_Invoke( > EXCEPINFO* pExcepInfo, > UINT* puArgErr) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domdoc *This = impl_from_IXMLDOMDocument2( iface ); > + ITypeInfo *typeinfo; > + HRESULT hr; > + > + TRACE("(%p)->(%d %s %d %d %p %p %p %p)\n", This, dispIdMember, > debugstr_guid(riid), > + lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); > + > + hr = get_typeinfo(IXMLDOMDocument2_tid, &typeinfo); > + if(SUCCEEDED(hr)) > + hr = ITypeInfo_Invoke(typeinfo, &(This->lpVtbl), dispIdMember, > wFlags, pDispParams, > + pVarResult, pExcepInfo, puArgErr); > + > + return hr; > } > > > diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c > index 62bf2b5..41afbe6 100644 > --- a/dlls/msxml3/main.c > +++ b/dlls/msxml3/main.c > @@ -21,6 +21,8 @@ > > #include "config.h" > > +#define COBJMACROS > + > #include <stdarg.h> > #include "windef.h" > #include "winbase.h" > @@ -34,6 +36,61 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(msxml); > > + > +static ITypeLib *typelib; > +static ITypeInfo *typeinfos[LAST_tid]; > + > +static REFIID tid_ids[] = { > + &IID_IXMLDOMDocument2 > +}; > + > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + ITypeLib *tl; > + > + hres = LoadRegTypeLib(&LIBID_MSXML2, 3, 0, LOCALE_SYSTEM_DEFAULT, > &tl); > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)&typelib, tl, NULL)) > + ITypeLib_Release(tl); > + } > + > + if(!typeinfos[tid]) { > + ITypeInfo *typeinfo; > + > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], > &typeinfo); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)(typeinfos+tid), > typeinfo, NULL)) > + ITypeInfo_Release(typeinfo); > + } > + > + *typeinfo = typeinfos[tid]; > + return S_OK; > +} > + > +static void process_detach(void) > +{ > + if(typelib) { > + unsigned i; > + > + for(i=0; i < sizeof(typeinfos)/sizeof(*typeinfos); i++) > + if(typeinfos[i]) > + ITypeInfo_Release(typeinfos[i]); > + > + ITypeLib_Release(typelib); > + } > +} > + > HRESULT WINAPI DllCanUnloadNow(void) > { > FIXME("\n"); > @@ -53,6 +110,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD > fdwReason, LPVOID lpv) > case DLL_PROCESS_DETACH: > #ifdef HAVE_LIBXML2 > xmlCleanupParser(); > + process_detach(); > #endif > break; > } > diff --git a/dlls/msxml3/msxml_private.h b/dlls/msxml3/msxml_private.h > index 8d79d2e..c7d97a1 100644 > --- a/dlls/msxml3/msxml_private.h > +++ b/dlls/msxml3/msxml_private.h > @@ -91,4 +91,12 @@ extern HRESULT DOMDocument_create( IUnknown *pUnkOuter, > LPVOID *ppObj ); > extern HRESULT SchemaCache_create( IUnknown *pUnkOuter, LPVOID *ppObj ); > extern HRESULT XMLDocument_create( IUnknown *pUnkOuter, LPVOID *ppObj ); > > +/* typelibs */ > +enum tid_t { > + IXMLDOMDocument2_tid, > + LAST_tid > +}; > + > +extern HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo); > + > #endif /* __MSXML_PRIVATE__ */ > -- > 1.5.3.7 > > -------------------------------------------------------------------------------- > >

1 0

[PATCH] Environment variable to specify X11 window for desktop
by Timothy Lee 13 Feb '08

13 Feb '08

Dear all, The attached patch allows the WINE desktop to be embedded within an existing X11 window, and is similar to the windowed mode in WINE. I've tested this feature using MS PowerPoint Viewer 2007, so that a fullscreen slideshow can be fitted inside any X11 window. Regards, Timothy Lee

2 1

Re: user32: correct the caption bar and it's buttons' sizes
by Peter Oberndorfer 13 Feb '08

13 Feb '08

On Mittwoch 13 Februar 2008, Divan Burger wrote: > What is the problem without the patch? is the caption bar drawn too high 1 pixel? I ask because i have a patch that restores the 1 pixel high line between the caption bar and the client area (and at the same time decreases the height of the caption bar) see it attached for the NC_DrawXXXButton functions: you also need to update hittest calculation else the wrong buttons are activated. For example when you press the mouse down on the left side of the close button, but maximize gets activated > case SM_CYCAPTION: > if (!spi_loaded[SPI_NONCLIENTMETRICS_IDX]) load_nonclient_metrics(); >- return nonclient_metrics.iCaptionHeight + 1; >+ return nonclient_metrics.iCaptionHeight; this breaks a test in sysparams.c:2416 ok_gsm( SM_CYCAPTION, ncm.iCaptionHeight+1); and 5 other tests Greetings Peter

1 0

missed systray patches
by Kirill K. Smirnov 13 Feb '08

13 Feb '08

Hello, Is there anything wrong with the serie of patches? systray[0/4]: systray improvements [try 2] http://www.winehq.org/pipermail/wine-patches/2008-February/049772.html -- Kirill

1 0

Re: Fixing the last failing tests
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

Hello M. What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry). How about fixing the functions as well (like IsWindowUnicode), so it returns the correct data according to the version in winecfg (registry). However, i do like the irony in your example :-) /pedro On Tue, 2008-02-12 at 18:09 -0800, Maarten Lankhorst wrote: > Hi all, > > I'm very close to passing the whole wine conformance suite on my pc. > The only tests failing are in user32. These tests are failing in any > version of windows though. How do I make them pass on at least 1 > version of windows and wine? Would patches to make it run on xp and > wine be accepted? > > And if I can succeed with that, how do I make it work with other > versions of windows as well. > > Cheers, > Maarten. > > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); > >

3 2

How is the testsuite built for windows
by Maarten Lankhorst 13 Feb '08

13 Feb '08

Hi all, I'm trying to get the tests to run in windows, but I'm not sure how to build them. Any attempt to do mingw cross compiling fails badly. Who managed to compile all wine tests for windows, and how is it done? Cheers, Maarten.

3 2

Re: [PATCH #1] wininet: Added beginning support for HTTP cache files.
by Robert Shearman 13 Feb '08

13 Feb '08

Jacek Caban wrote: > + /* FIXME: Better check, when we have to create the cache file */ > + if(bSuccess && (lpwhr->hdr.dwFlags & INTERNET_FLAG_NEED_FILE)) { > + WCHAR url[INTERNET_MAX_URL_LENGTH]; > + WCHAR cacheFileName[MAX_PATH+1]; > + BOOL b; > + > + b = HTTP_GetRequestURL(lpwhr, url); > + if(!b) { > + WARN("Could not get URL\n"); > + goto lend; > + } > + > + b = CreateUrlCacheEntryW(url, lpwhr->dwContentLength > 0 ? lpwhr->dwContentLength : 0, NULL, cacheFileName, 0); > + if(b) { > + lpwhr->lpszCacheFile = WININET_strdupW(cacheFileName); > + lpwhr->hCacheFile = CreateFileW(lpwhr->lpszCacheFile, GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_WRITE, > + NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + if(lpwhr->hCacheFile == INVALID_HANDLE_VALUE) { > + WARN("Could not create file: %u\n", GetLastError()); > + lpwhr->hCacheFile = NULL; > + } > + }else { > + WARN("Could not create cache entry: %08x\n", GetLastError()); > + } > + } > > It may be beyond the scope of your patch, but you're creating the cache file without committing the entry elsewhere so that it can be found at a later time. According to MSDN, this should be done in HTTP_FinishedReading. -- Rob Shearman

1 0

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

Eh, this does not seem like a proper way to get a unit test to pass. Sleep()... that leads to the dark side! :-) Why does it need a Sleep()? If its failing on Wine, then shouldn't it be fixed in the libs? And if its on orig-winxp-vista then there must be a better way to wait? Or no? The string "This makes the tests pass on my pc" isn't very good either. What system? In general, introducing magic Sleep() values in code is not a good idea. If the test system is stressed, you will start getting failures again = bad idea. /p On Wed, 2008-02-13 at 02:26 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > > This makes the tests pass on my pc. > > d3d8 might need it as well > >

3 2

Re: Patch: create a WinHttpDetectAutoProxyConfigUrl function
by Dmitry Timoshkov 13 Feb '08

13 Feb '08

"Joshua Hudson" <joshudson(a)gmail.com> wrote: > --- wine-0.9.54/dlls/winhttp/winhttp.spec 2008-02-11 20:54:39.000000000 > -0800 > +++ wine-0.9.54/dlls/winhttp/winhttp.spec.bak 2008-02-11 20:52:39.000000000 > -0800 The patch is wrapped. > @@ -8,7 +8,7 @@ > @ stub WinHttpConnect > @ stub WinHttpCrackUrl > @ stub WinHttpCreateUrl > -@ stdcall WinHttpDetectAutoProxyConfigUrl(long ptr) > +@ stub WinHttpDetectAutoProxyConfigUrl And this part seems to be reverted. -- Dmitry.

1 0

Alsa spitting out warnings every time Wine runs.
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

Hi Maarten & Devs. Great to see that audio is so much better in Wine now. But.... On fedora core 6 and 8 i get this every time i start Wine: ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 I think its harmless, but what do you it means? How do i stop it? Should i fix it in Wine or Alsa? /p

2 1

Fwd: Congratulation!!!
by Maarten Lankhorst 13 Feb '08

13 Feb '08

Hooray! I won the Microsoft e-mail award! And I thought my wine efforts would go unnoticed, but here I am winning the grand prize! ---------- Forwarded message ---------- From: marinamg(a)esplugues.org <marinamg(a)esplugues.org> Date: 12 feb. 2008 18:33 Subject: Congratulation!!! To: undisclosed-recipients Microsoft Award Team 22 Garden Close,PE9 2YP, London Date: 13th Feb 2008. Finally, Today we announce this year winners of the MICROSOFT E-MAIL AWARD held on the 13/02/2008, Your Email has won (£1,000,000.00) (CSC) Claims Security Code: CSC-74162007-04-LV-UK,Your Ref: MSC990/678. Contact your Fudiciary agent Mr. Steve Wallace along with your information via email. Sir. John Smith Email: johnsmithm(a)live.com

2 1

Fixing the last failing tests
by Maarten Lankhorst 13 Feb '08

13 Feb '08

Hi all, I'm very close to passing the whole wine conformance suite on my pc. The only tests failing are in user32. These tests are failing in any version of windows though. How do I make them pass on at least 1 version of windows and wine? Would patches to make it run on xp and wine be accepted? And if I can succeed with that, how do I make it work with other versions of windows as well. Cheers, Maarten. An example is IsWindowUnicode. It always returns TRUE on XP, but it won't do that on 9x. That would mean something like: ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?");

2 1

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Stefan Dösinger 13 Feb '08

13 Feb '08

Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > This makes the tests pass on my pc. d3d8 might need it as well

1 0

Re: ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

Hi Stefan. OK thanks for the fast, precise and well-cut review (and probably correct). I will fix the 3 issues and re-submit. /p On Wed, 2008-02-13 at 00:50 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 00:39:52 schrieb Peter Dons Tychsen: > > Hi Devs. > > > > I had this patch silently rejected. > > Can anybody spot what is wrong with this patch? > My first thought was that filtering the modes like this is kinda ugly, but > given that ddraw uses wined3d and wined3d uses the d3d9 interface this is the > only way. (I don't think adding an extra flag to wined3d is cleaner, > considering that ddraw can sort this out on its own). > > However, I think you shouldn't clone the application's bug you're trying to > work around and deal with the "out of mode buffer" case. you can e.g. use > HeapReAlloc to increase the buffer without loosing the content. > > Another minor thing is the if(buffer) HeapFree(buffer) code. HeapFree checks > against NULL, so the extra check isn't needed, and it is sorta a policy not > to have redundant checks before HeapFree >

1 0

ddraw - Implement correct behavior for the DDEDM_REFRESHRATES flag in EnumDisplayModes() - REJECTED.
by Peter Dons Tychsen 12 Feb '08

12 Feb '08

Hi Devs. I had this patch silently rejected. Can anybody spot what is wrong with this patch? It is really needed for some older games like Grand Theft Auto, and other oldies (but goodies!). /pedro

2 1

dbghelp/dwarf.c: new valgrind warnings?
by Dan Kegel 12 Feb '08

12 Feb '08

I'm now seeing some new valgrind warnings when wine is doing stack dumps after crashes: + Conditional jump or move depends on uninitialised value(s) + at dwarf2_load_one_entry (dwarf.c:983) + by dwarf2_lookup_type (dwarf.c:858) + by dwarf2_load_one_entry (dwarf.c:1020) + by dwarf2_parse (dwarf.c:2060) + by elf_load_debug_info (elf_module.c:1085) + by module_get_debug (module.c:303) + by SymFromAddr (symbol.c:1071) + by stack_get_current_symbol (stack.c:143) + by display_print (display.c:174) + by wait_exception (tgt_active.c:178) + by dbg_active_auto (tgt_active.c:951) + by main (winedbg.c:544) I don't know when this started, but maybe it's related to recent changes by Eric Pouech? - Dan

2 1

[winetest] Would it be worthwhile to send zipped version of the reports?
by Paul Vriens 12 Feb '08

12 Feb '08

Hi, As more and more tests are developed I think it could make sense to zip the report files before sending. It will of course put a small extra burden on the winehq server but as the reports are text only we gain a 90% or so per report. Thoughts? -- Cheers, Paul.

2 2

Re: [advapi32/tests] Only use functions if they are implemented
by James Hawkins 12 Feb '08

12 Feb '08

On Feb 12, 2008 10:34 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Added some verbosity to the GetProcAddress stuff. The skips prevent the > crash(es) I'm seeing on win95. > What is the point of this 'verbosity'? You already add the skips, so if a function isn't available for a test, you're going to see it twice now. Also, it adds to the code size. -- James Hawkins

2 1

Re: browseui: Add undocumented Component Category Cache Daemon class
by Dmitry Timoshkov 12 Feb '08

12 Feb '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > --- /dev/null > +++ b/dlls/browseui/compcatcachedaemon.c > @@ -0,0 +1,159 @@ > +/* > + * Progress dialog > + * > + * Copyright 2007 Mikolaj Zalewski Is the above information correct? -- Dmitry.

1 0

Re: Oleview: Added Dutch translations
by Dmitry Timoshkov 12 Feb '08

12 Feb '08

"Frans Kool" <frans.kool(a)gmail.com> wrote: > From 2e5bda68273038f924f8f0d1b325a2a4c71f17ae Mon Sep 17 00:00:00 2001 > From: Frans Kool <Frans.Kool(a)gmail.com> > Date: Tue, 12 Feb 2008 12:04:56 +0100 > Subject: Oleview: Added Dutch translations This your patch as well as a previous one are wrapped. -- Dmitry.

1 0

Regesstion Tests
by Alistair Leslie-Hughes 12 Feb '08

12 Feb '08

Hi, If I have Msxml3 with SP7 installed all the msxml tests pass without issue, but if I have Msxml3 SP3 installed, some fail. Should I improve the tests so that they can handle both cases? Best Regards Alistair Leslie-Hughes

2 1

Regular bugzilla hygeine
by Dan Kegel 12 Feb '08

12 Feb '08

When we do a release, all the bugs in RESOLVED FIXED state can be closed (since they were only waiting on a release to be closed). We haven't been doing that, and as a result, lots and lots of bugs stacked up in RESOLVED FIXED state. But I don't see any reason we shouldn't start doing it, so I'm about to do it in honor of the 0.9.55 release. (I think I've figured out how to avoid changing any bugs flipped into that state since the 0.9.55 release, let's see if I get it right. Next time I'll do it right when Alexandre releases.) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: comctl32: Fixed listview bug, when client sends bogus SETITEMSTATE request
by Dimi Paun 12 Feb '08

12 Feb '08

On Tue, 2008-02-12 at 03:28 +0100, Peter Dons Tychsen wrote: > Fixed listview bug, when client sends bogus SETITEMSTATE request, > requesting all items to be focused. Looks good, tnx! -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: Resend patch from Norbert
by Vitaliy Margolen 11 Feb '08

11 Feb '08

Rico Schüller wrote: > Hi, > > I only resend a patch because it isn't in the todays git and the author > didn't answer for a while. > > Cheers > Rico > > > ------------------------------------------------------------------------ > > > - memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(pRect)); > + memcpy(pRect, &This->updateStateBlock->scissorRect, sizeof(RECT)); To avoid such problems in the future one should use something like: *pRect = This->updateStateBlock->scissorRect; Doing a quick search through wined3d I've found number of places with memcpy instead of simple assignment of one struct to another struct. This is a good janitorial task to get rid of memcpy where simple assignment will work. Vitaliy.

3 2

Re: IStream interface for domdoc and terminate call
by Kornél Pál 11 Feb '08

11 Feb '08

Also note you should test the behavior when call QueryInterface for IStream multiple times whether a new wrapper or the same wrapper is returned and whether the tree is cleared on QueryInterface. And I forgot to mention that calling Release on the IStream interface is the correct way of disposing the interface so that call may have effect on the object as well. Kornél ----- Original Message ----- From: "Kornél Pál" <kornelpal(a)gmail.com> To: "Josef Reidinger" <josef.reidinger(a)gmail.com>; <wine-devel(a)winehq.org> Sent: Monday, February 11, 2008 1:15 PM Subject: Re: IStream interface for domdoc and terminate call > OK, sorry I didn't realized that you try to modify the Wine > implementation. > > I think that delaying pasing for the fist time you call a method of the > DOMDocument object would be a good solution. This way you will not perform > any unnecessary parings. > > I don't know the exact details of MS implementations so you should check > when and how are parsing errors reported and when is the parsed document > available when you write the DOMDocument throug it's IStream interface and > you should dealy parsing to the latest possible time. > > Kornél > > ----- Original Message ----- > From: "Josef Reidinger" <josef.reidinger(a)gmail.com> > To: "Kornél Pál" <kornelpal(a)gmail.com> > Sent: Monday, February 11, 2008 12:58 PM > Subject: Re: IStream interface for domdoc and terminate call > > >> Hi >> I mean using call IStream_write like it is describe in bug #4811. >> >> Kornél Pál napsal(a): >>> Hi, >>> >>> If you mean passing an IStream interface to DOMDocument.save method: >>> As far as I know save method is synchronous (if I'm wrong you still can >>> set the async property to FALSE). So when the save method returns you >>> know that the entire document has been passed to the IStream. >>> >>> If you want to do something else please be more specific. >>> >>> Kornél >>> >>> ----- Original Message ----- From: "Josef Reidinger" >>> <josef.reidinger(a)gmail.com> >>> To: <wine-devel(a)winehq.org> >>> Sent: Monday, February 11, 2008 11:55 AM >>> Subject: IStream interface for domdoc and terminate call >>> >>> >>>> Hi, I try make IStream write interface for domdoc (msxml3). Problem is >>>> that microsoft doesn't have terminate string for write call and libxml >>>> have proble with it (more at >>>> http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does >>>> anyone has any idea how solve it? (test in each dom call if is some >>>> nonparsed characters and force parsing looks very ugly). >>>> JR >>>> >>>> >>> >> >

1 0

Re: IStream interface for domdoc and terminate call
by Kornél Pál 11 Feb '08

11 Feb '08

OK, sorry I didn't realized that you try to modify the Wine implementation. I think that delaying pasing for the fist time you call a method of the DOMDocument object would be a good solution. This way you will not perform any unnecessary parings. I don't know the exact details of MS implementations so you should check when and how are parsing errors reported and when is the parsed document available when you write the DOMDocument throug it's IStream interface and you should dealy parsing to the latest possible time. Kornél ----- Original Message ----- From: "Josef Reidinger" <josef.reidinger(a)gmail.com> To: "Kornél Pál" <kornelpal(a)gmail.com> Sent: Monday, February 11, 2008 12:58 PM Subject: Re: IStream interface for domdoc and terminate call > Hi > I mean using call IStream_write like it is describe in bug #4811. > > Kornél Pál napsal(a): >> Hi, >> >> If you mean passing an IStream interface to DOMDocument.save method: >> As far as I know save method is synchronous (if I'm wrong you still can >> set the async property to FALSE). So when the save method returns you >> know that the entire document has been passed to the IStream. >> >> If you want to do something else please be more specific. >> >> Kornél >> >> ----- Original Message ----- From: "Josef Reidinger" >> <josef.reidinger(a)gmail.com> >> To: <wine-devel(a)winehq.org> >> Sent: Monday, February 11, 2008 11:55 AM >> Subject: IStream interface for domdoc and terminate call >> >> >>> Hi, I try make IStream write interface for domdoc (msxml3). Problem is >>> that microsoft doesn't have terminate string for write call and libxml >>> have proble with it (more at >>> http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does >>> anyone has any idea how solve it? (test in each dom call if is some >>> nonparsed characters and force parsing looks very ugly). >>> JR >>> >>> >> >

1 0

IStream interface for domdoc and terminate call
by Josef Reidinger 11 Feb '08

11 Feb '08

Hi, I try make IStream write interface for domdoc (msxml3). Problem is that microsoft doesn't have terminate string for write call and libxml have proble with it (more at http://mail.gnome.org/archives/xml/2008-February/msg00052.html ). Does anyone has any idea how solve it? (test in each dom call if is some nonparsed characters and force parsing looks very ugly). JR

2 1

Re: pdh[3:3]: remove unnecessary tests done in PdhLookupPerfNameByIndexW
by Dmitry Timoshkov 11 Feb '08

11 Feb '08

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > --- a/dlls/pdh/pdh_main.c > +++ b/dlls/pdh/pdh_main.c > @@ -837,14 +837,7 @@ PDH_STATUS WINAPI PdhLookupPerfNameByIndexA( LPCSTR machine, DWORD index, LPSTR > > TRACE("%s %d %p %p\n", debugstr_a(machine), index, buffer, size); > > - if (machine) > - { > - FIXME("remote machine not supported\n"); > - return PDH_CSTATUS_NO_MACHINE; > - } > - > if (!buffer || !size) return PDH_INVALID_ARGUMENT; > - if (!index) return ERROR_SUCCESS; Changelog mentions PdhLookupPerfNameByIndexW by the change is in PdhLookupPerfNameByIndexA. Why are you removing the checks in one place by leave the same in other one? Why the tests are unnecessary? -- Dmitry.

2 6

Re: [1/9] WineD3D: Add a test for the vFace register
by H. Verbeet 11 Feb '08

11 Feb '08

On 11/02/2008, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* TODO: vFace (ps_3_0) */ You should probably remove that one :-)

1 0

re: Is there a Git Repositories for Unaccept Patches or (work in Progress)?
by Dan Kegel 11 Feb '08

11 Feb '08

Joeseph wrote: > Is there a Git Repositories for Unaccept Patches or (work in Progress)? Not really, but people often attach patches to bugzilla entries if they're not quite good enough to submit. And if anybody wants to start such a git repository, more power to them. >An ntoskrnl.exe was written a couple of years ago to load drivers, >specifically the Safedisc Windows kernel driver, > but it still hasn't been accepted. The article you read is out of date; ntoskrnl.exe is now part of wine. > Basically threat unaccepted patch as bugs(while keeping the patch out of wine), instead of chucking it out the window. As I said above, developers are free to attach patches to bug reports. What you're really trying to get at is: sometimes developers get discouraged at how hard it is to get patches into Wine. But no mechanical aid will really help there. The only cure is persistance on the part of the developer, and assistance (chiefly good feedback) from other Wine developers. After a developer gets a few patches committed, the wine process starts to feel a lot smoother. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

6 11

Wine patches integrated into Valgrind svn
by Dan Kegel 11 Feb '08

11 Feb '08

Hey, the Valgrind developers finally merged the Wine support patches! I just built Valgrind from svn as described here: http://valgrind.org/downloads/repository.html and on a fresh install of Gutsy, it just worked, no patches. To run Valgrind's tests under Wine, I configure valgrind with --prefix=/usr/local/valgrind-svn, then do something like cd wine-git/tools wget http://kegel.com/wine/valgrind/runtests.patch wget http://kegel.com/wine/valgrind/valgrind-daily.sh wget http://kegel.com/wine/valgrind/valgrind-suppressions wget http://kegel.com/wine/valgrind/valgrind-split-pl.txt -O valgrind-split.pl patch -p2 < runtests.patch Then to run all the tests, I do cd ~/wine-git sh tools/valgrind-daily.sh or to run just one test, I do export RUNTEST_USE_VALGRIND=1 cd ~/wine-git/dlls/riched20/tests make test I've only verified that this works well on one machine so far, but I have high hopes. Anyone else feel like giving it a whirl? - Dan

3 4

Re: Gdiplus: Implement GdipDrawArcI based on GdipDrawArc
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 4:04 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -Added GdipDrawArcI as GdipDrawArc that takes INT arguments > -Added a very similar conformance test to the one I did for GdipDrawArc > -Corresponding change to gdiplus.spec > No patch. -- James Hawkins

1 0

? on Repositories for Unaccept Patches and (work in Progress).
by Joseph Stein 10 Feb '08

10 Feb '08

Is there a Git Repositories for Unaccept Patches or (work in Progress)? If not (which i think is the case and why I posting here instead of the user mailing list.), could you create one(along with a text file explain what need to be done to be accepted)? Here are some reason I think It is Needed. 1.) It would allow developer and users to see what the source done. I have read a very good article about usb support in wine an winehq.org here http://www.winehq.org/?issue=331 wich said that >An ntoskrnl.exe was written a couple of years ago to load drivers, >specifically the Safedisc Windows kernel driver, but it still hasn't been >accepted. Apparently there's some low-level internal Wine issues >and Alexandre wants those fixed before accepting the patch. 2.) Allow people two git possibly some things work that would other wise not work. using the patch for ntoskrnl.exe that was not accept as an example, (please correct me if i wrong), could possible git some drivers working (usb driver may be?) program to work. which is currently not possible with wine from what i read. Yes It dose cause other wine problem which is not big deal, if you compile and run wine form the source directory from which it is compiled instead of installing it (the multiple wine install way). In other words you code use the patch version of wine just for the program that need the patch to work .(Is it not better to have a broken wine (with partal diver) support, then a stable wine with-out (partal diver) support when The program you are running requires a driver.) 3.)If done right in my humble opinion would help prevent developer from getting discurage becuase all there work has be chuck out the window. Giving more Light to what i said above, What I mean buy "if done right",Is that if a developer(who is looking for something to do) would go look at what patches Have not be accepted (but have almost all basic done) and help the developer git it accepted ,Would in my humble opinion encourage more developer to join which is need for a complicated project such as wine. Basically threat unaccepted patch as bugs(while keeping the patch out of wine), instead of chucking it out the window. This type of thing is done in boost project i be-leave, but I taking it one step further and asking for a text file on "what need to be done to be include which each unaccepted patches". Thank you for any reply, Please forgive me if I got any of what i said above wrong, I'm not a real good developer and only have a real basic idea of wine and have not work on wine because it to confusing to me(but have download and looked at from git Repositories) --------------------------------- Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now.

4 3

Re: Gdiplus: conformance test for GdipDrawLineI in graphics.c
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 3:46 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added conformance test mainly checking for input parameters > You forgot the patch again. -- James Hawkins

1 0

Re: Gdiplus: GdipDrawArc in graphics.c does not return InvalidParameter for bad values of height and width
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 3:19 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added two checks for non-positive values of width and height > -added a conformance test for invalid parameters > You forgot the patch. -- James Hawkins

1 0

winecfg improvements
by Reece Dunn 10 Feb '08

10 Feb '08

Hi, I have just submitted 4 patches that make it possible to import a colour theme from winecfg and have it correctly apply the colours. One example is the Ubuntu Human theme (see attachment), adapted from http://tombuntu.com/wp-content/uploads/2008/01/winehumancolours.txt. Enjoy, - Reece

1 0

Re: dlls/gdi32/font.c warning removal (RESEND)
by Alexandre Julliard 10 Feb '08

10 Feb '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > The reason is that we have > > #define HDPTOLP(y) ((y<0)? \ > (-abs(INTERNAL_YDSTOWS(dc, (y)))): \ > (abs(INTERNAL_YDSTOWS(dc, (y))))) > > which is overly complicated for unsigned types. We can avoid these > warnings by using plain INTERNAL_YDSTOWS instead of HDPTOLP here. No, you still need the abs(). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WineD3D: split framebuffer -> texture path from LoadLocation
by Stefan Dösinger 10 Feb '08

10 Feb '08

Am Sonntag, 10. Februar 2008 17:37:25 schrieb Roderick Colenbrander: > Hi, > > This patch puts the framebuffer -> texture from LoadLocation in a separate > function in a similar way to read_from_framebuffer. It borrows some code > from LoadLocation and read_from_framebuffer. > > Regards, > Roderick Colenbrander You're mixing tabs and spaces in this patch

2 2

Re: Implemented a stub for MsiSetExternalUIRecord in msi.dll
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 1:11 PM, Luke Benstead <kazade(a)gmail.com> wrote: > This unimplemented function causes the .NET framework 3.0 installer to fail > (and also Visual C++ express 8.0) with this patch the installer continues > further before crashing. This is my first ever patch on Wine (and working > with GIT) so I'm sure I've done something wrong, if so I apologize in > advance :) > > diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c > index 643f9cc..9fb6906 100644 > --- a/dlls/msi/msi.c > +++ b/dlls/msi/msi.c > @@ -992,6 +992,7 @@ end: > return state; > } > > + > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > { > INSTALLUILEVEL old = gUILevel; Random whitespace change -> bad. > @@ -1008,6 +1009,18 @@ INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > return old; > } > > +/*********************************************************************** > + * MsiSetExternalUIRecord [MSI.@] > + */ > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER puiHandler, > + DWORD dwMessageFilter, LPVOID pvContext, > + PINSTALLUI_RECORD_HANDLER ppuiPrevHandler ) > +{ > + FIXME("%p %08x %p %p", > + puiHandler, dwMessageFilter, pvContext, ppuiPrevHandler); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > INSTALLUI_HANDLERA WINAPI MsiSetExternalUIA(INSTALLUI_HANDLERA puiHandler, > DWORD dwMessageFilter, LPVOID pvContext) > { Used tabs -> bad. > @@ -2452,3 +2465,5 @@ UINT WINAPI MsiAdvertiseScriptA( LPCSTR szScriptFile, DWORD dwFlags, > debugstr_a( szScriptFile ), dwFlags, phRegData, fRemoveItems ); > return ERROR_CALL_NOT_IMPLEMENTED; > } > + > + More random whitespace changes. > @@ -573,6 +576,7 @@ UINT WINAPI MsiAdvertiseScriptW(LPCWSTR, DWORD, PHKEY, BOOL); > UINT WINAPI MsiCloseHandle(MSIHANDLE); > UINT WINAPI MsiCloseAllHandles(void); > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL, HWND*); > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER, DWORD, LPVOID, PINSTALLUI_RECORD_HANDLER); Inconsistent whitespace. The rest of the file does not have spaces after parentheses. -- James Hawkins

1 0

gecko download not robust?
by Dan Kegel 10 Feb '08

10 Feb '08

Hmm. gecko download hung for me once. I saw fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 in the log, which makes me wonder if our download code doesn't handle transient network errors well. Time to get rid of the download, and just bundle gecko outright, I say...

2 1

Re: Is wine reporting the right value for MaxVertexBlendMatrices ?
by Alex Jackson 10 Feb '08

10 Feb '08

> That said, GL_ARB_vertex_blend is not very common. Only MacOS supports it, and > it is software emulated there. The Linux ATI driver used to support it until > ATI switched to a different codebase. So this constant ends up beeing 0 > almost everywhere. The extension was dropped in favor of vertex programs, > since vertex programs appeared shortly after vertex blending and no gl app > was using it at this time. On Windows drivers emulate vertex blending using > vertex shaders. > > I am not sure if 0 is the correct value to return in case of no vertex > blending support. What happens if you set it to 1? 1 would be a reasonable > default as well, because we're still able to transform vertices with one > matrix(ie, unblened transformation). It could also be that this game silently > expects vertex blending to be supported: For one part, all dx8+ cards support > this feature on Windows, and on older cards Windows has software vertex > processing which can perform blending in a slow, but working fashion. > > I have a patch for software emulated vertex blending somewhere, but I dropped > it because I didn't come across an app which uses this function. Maybe its > time to revive it, and continue the work on a fixed function replacement > shader. Even on Windows, no OpenGL implementation that I know of supports GL_ARB_vertex_blend other than ATI's (and as you've pointed out, the new OpenGL stack that the Radeon HD's use on Windows and that all Radeons now use on Linux has dropped it). History lesson: Both GL_ARB_vertex_blend and D3D vertex blending are historically tied to a specific piece of hardware: the original ATI Radeon (GL_ARB_vertex_blend started out as GL_ATI_vertex_blend). Presumably, due to ATI's historically spotty OpenGL driver performance (okay, "historically" is being kind to ATI), any game developer who wanted to use the Radeon's capabilities targeted their game for D3D rather than OpenGL. Consequently, when nVidia released the GeForce 3 (the first video card with vertex shaders) they did implement D3D vertex blending via shaders in their D3D driver (since games were using it, and it wouldn't do if the "new" GF3 couldn't handle effects that the "old" Radeon could), but they didn't bother to implement it in their OpenGL driver, even though ATI had gotten it ARB-approved some months before the GF3 came out, since no games/apps were using it. The other video hardware makers (the few that were left by the DX8 era) followed NV's example: implement D3D vertex blending via shaders or in software (for entry-level and onboard hardware without vertex shaders), but don't bother with GL_ARB_vertex_blend since no one uses it. The upshot is that GL_ARB_vertex_blend is an ARB extension In Name Only; it's effectively ATI-only--and even ATI has abandoned it now. On the other hand, D3D vertex blending is universally available on modern and semi-modern hardware regardless of maker, and it looks like even some D3D9 games still use it instead of using vertex shaders. So it's better for WINE to implement vertex blending via vertex programs rather than depending on GL_ARB_vertex_blend. --AWJ-- _________________________________________________________________

3 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel