- wine-devel - winehq.org

Re: WineD3D: p8 improvements 2/2
by H. Verbeet 12 Oct '07

12 Oct '07

On 11/10/2007, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > + "MUL index.x, index.x, constants.x;\n" /* Scale the index by 255/256 */ > + "ADD index.x, index.x, constants.y;\n" /* Add a bias of '0.5' in order to sample in the middle */ Why not use a MAD there?

1 0

Re: kernel32/locale.c: partially implement GetUserGeoID() (try2)
by Alexandre Julliard 12 Oct '07

12 Oct '07

EA Durbin <ead1234(a)hotmail.com> writes: > GEOID WINAPI GetUserGeoID( GEOCLASS GeoClass ) > { > - FIXME("%d\n",GeoClass); > - return GEOID_NOT_AVAILABLE; > + GEOID ret = GEOID_NOT_AVAILABLE; > + static const WCHAR geoW[] = {'G','e','o',0}; > + static const WCHAR nationW[] = {'N','a','t','i','o','n',0}; > + WCHAR bufferW[10], *end; The buffer is too small since it has to contain the key information too. > + switch(GeoClass){ > + case GEOCLASS_NATION: > + if((NtQueryValueKey(hSubkey, &keyW, KeyValuePartialInformation, (LPBYTE)bufferW, count, &count) == STATUS_SUCCESS) && (info->DataLength)) > + ret = strtolW((LPCWSTR)info->Data, &end, 10); You have to make sure the buffer is null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] WineD3D: Add support for other ps 3.0 varyings
by Alexandre Julliard 12 Oct '07

12 Oct '07

Stefan Dösinger <stefan(a)codeweavers.com> writes: > + usage = (usage_token & WINED3DSP_DCL_USAGE_MASK) >> WINED3DSP_DCL_USAGE_SHIFT; > + usage_idx = (usage_token & WINED3DSP_DCL_USAGEINDEX_MASK) >> WINED3DSP_DCL_USAGEINDEX_SHIFT; > + //shader_glsl_get_write_mask(register_token, reg_mask); Please clean up this sort of thing before submitting. > + switch(usage) { > + case WINED3DDECLUSAGE_BLENDWEIGHT: > + shader_addline(buffer, "varying vec4 var_blendweight;\n", i, reg_mask, reg_mask); > + break; > + > + case WINED3DDECLUSAGE_BLENDINDICES: > + shader_addline(buffer, "varying vec4 var_blendindices;\n", i, reg_mask, reg_mask); > + break; Why are you passing parameters that won't be used? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: fix memory leak (found by Smatch).
by Lionel Debroux 12 Oct '07

12 Oct '07

Is there anything wrong with this patch ? I think this one is a real memory leak. "WaitNamedPipeW" in dlls/kernel32/sync.c gets flagged by Michael Stefaniuc's unfree-wine.pl script for leaking "pipe_wait". pipe_wait isn't used anywhere between its allocation and the memory leak in the error path. nt_name.Length, which is used for computing sz_pipe_wait isn't modified either in those lines. Therefore, I fixed the leak in the error path by moving the allocation later in the program. 2007-10-06 Lionel Debroux <lionel_debroux(a)yahoo.fr> * dlls/kernel32/sync.c: kernel32: fix memory leak (found by Smatch). _____________________________________________________________________________ Ne gardez plus qu'une seule adresse mail ! Copiez vos mails vers Yahoo! Mail

2 1

Re: user32 [1/7]: Increase the message timeout
by Alexandre Julliard 12 Oct '07

12 Oct '07

"James Hawkins" <truiken(a)gmail.com> writes: > Changelog: > * Increase the message timeout. This is making the test very slow, it needs to be done differently. Why are all these Sleeps necessary? -- Alexandre Julliard julliard(a)winehq.org

1 0

What happened to the Wine Newsletters?
by King InuYasha 12 Oct '07

12 Oct '07

What happened to the wine weekly newsletters? the latest issue on the website is dated May 26, 2007. I am hoping this does not mean nothing interesting has happened since then, since I am certain something must have happened since then...

8 10

Re: setupapi(1/19): Test SetupDiInstallClass (take 2)
by Alexandre Julliard 11 Oct '07

11 Oct '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > The last version was missing the inf file. You can't use source tree files in tests, that won't work when running on Windows. The test itself should create the external files it needs. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wiki: removed edit rights for unknown users
by Dimi Paun 11 Oct '07

11 Oct '07

Folks, We've got a lot of vandals lately on the wiki, and people are doing quite a bit of cleanup for no good reason. So I have removed the ability of people that are not logged in to edit pages. In fact this has been in force for a long time, but since we've upgraded to the new 1.5.x release of Moin, we reverted to allow anybody to edit pages. Please let me know if you encounter any problems or have any concerns regarding this policy. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

3 2

Window decorations missing on Compiz/Debian Etch
by Michael Jung 11 Oct '07

11 Oct '07

Hi all, since a couple of weeks all wine GUI applications are missing the window manager decorations on my Debian Etch box with the Compiz window manager. I did'nt get to doing a bisect until today. The problematic patch seems to be: --- commit ac98e0c07535af4a373c0af343498903e2ff42a6 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Aug 20 22:06:33 2007 +0200 winex11: Switch windows to managed mode in SetWindowPos instead of at creation time. --- Anybody else seeing this problem? I'll attach a +x11drv log from starting up notepad with a current version of wine as of today (wine-0.9.44-g282696b). Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de libGL warning: 3D driver claims to not support visual 0x4b trace:x11drv:xinerama_init monitor 0x1: (0,0)-(1024,768) (primary) trace:x11drv:xinerama_init virtual size: (0,0)-(1024,768) primary size: 1024x768 trace:x11drv:X11DRV_SetupXIM X display of IM = 0x7c1a3f38 trace:x11drv:X11DRV_SetupXIM Using en_US.UTF-8 locale of Input Method trace:x11drv:X11DRV_SetupXIM ximStyles->count_styles = 2 trace:x11drv:X11DRV_SetupXIM ximStyles[0] = XIMPreeditNone trace:x11drv:X11DRV_SetupXIM ximStyles[1] = XIMPreeditNothing trace:x11drv:X11DRV_SetupXIM Setting Style: ximStyleRoot = STYLE_ROOT trace:x11drv:X11DRV_SetupXIM No callback style avalable trace:x11drv:X11DRV_CreateBitmap (0x1a4) 32x32 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x1a8) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1a8, buffer=0x38065c, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1a4, buffer=0x3806dc, count=0x80) trace:x11drv:X11DRV_CreateBitmap (0x1ac) 32x32 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x1b0) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1b0, buffer=0x380784, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1ac, buffer=0x380804, count=0x80) trace:x11drv:X11DRV_CreateBitmap (0x1c0) 16x16 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x1c4) 16x16 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1c4, buffer=0x3808ac, count=0x20) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1c0, buffer=0x3808cc, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x1c8) 16x16 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x1cc) 16x16 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1cc, buffer=0x380bf4, count=0x20) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1c8, buffer=0x380c14, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x1d0) 16x16 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x1d4) 16x16 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1d4, buffer=0x380f3c, count=0x20) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1d0, buffer=0x380f5c, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x210) 64x16 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x248) 128x32 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x264) 16x16 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x268) 16x16 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x268, buffer=0x381284, count=0x20) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x264, buffer=0x3812a4, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x26c) 32x32 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x270) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x270, buffer=0x3815cc, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x26c, buffer=0x38164c, count=0xc00) trace:x11drv:X11DRV_CreateBitmap (0x274) 16x16 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x278) 16x16 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x278, buffer=0x382274, count=0x20) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x274, buffer=0x382294, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x27c) 16x16 24 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x27c, bits=0x121308, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x280) 16x16 1 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x280, bits=0x120ff0, count=0x20) trace:x11drv:X11DRV_CreateBitmap (0x290) 32x32 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x294) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x294, buffer=0x382274, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x290, buffer=0x3822f4, count=0xc00) trace:x11drv:X11DRV_CreateBitmap (0x298) 32x32 24 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x298, bits=0x121308, count=0xc00) trace:x11drv:X11DRV_CreateBitmap (0x29c) 32x32 1 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x29c, bits=0x121f10, count=0x80) trace:x11drv:X11DRV_CreateBitmap (0x2ac) 16x16 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x2b0) 16x16 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x2b0, buffer=0x382274, count=0x20) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x2ac, buffer=0x382294, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x2cc) 64x144 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x2b4) 16x16 24 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2b4, bits=0x121308, count=0x300) trace:x11drv:X11DRV_CreateBitmap (0x2b8) 16x16 1 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2b8, bits=0x121660, count=0x20) trace:x11drv:X11DRV_CreateBitmap (0x2dc) 32x32 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x2e0) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x2e0, buffer=0x382274, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x2dc, buffer=0x3822f4, count=0xc00) trace:x11drv:X11DRV_CreateBitmap (0x2fc) 128x288 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x2e4) 32x32 24 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2e4, bits=0x121ad0, count=0xc00) trace:x11drv:X11DRV_CreateBitmap (0x2e8) 32x32 1 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2e8, bits=0x120378, count=0x80) trace:x11drv:X11DRV_CreateBitmap (0x30c) 32x32 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x310) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x310, buffer=0x382274, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x30c, buffer=0x3822f4, count=0xc00) libGL warning: 3D driver claims to not support visual 0x4b trace:x11drv:xinerama_init monitor 0x1: (0,0)-(1024,768) (primary) trace:x11drv:xinerama_init virtual size: (0,0)-(1024,768) primary size: 1024x768 trace:x11drv:X11DRV_SetupXIM X display of IM = 0x7c06e720 trace:x11drv:X11DRV_SetupXIM Using en_US.UTF-8 locale of Input Method trace:x11drv:X11DRV_SetupXIM ximStyles->count_styles = 2 trace:x11drv:X11DRV_SetupXIM ximStyles[0] = XIMPreeditNone trace:x11drv:X11DRV_SetupXIM ximStyles[1] = XIMPreeditNothing trace:x11drv:X11DRV_SetupXIM Setting Style: ximStyleRoot = STYLE_ROOT trace:x11drv:X11DRV_SetupXIM No callback style avalable trace:x11drv:X11DRV_CreateBitmap (0x1a4) 32x32 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x1a8) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1a8, buffer=0x39065c, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1a4, buffer=0x3906dc, count=0x80) trace:x11drv:X11DRV_CreateBitmap (0x1ac) 32x32 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x1b0) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1b0, buffer=0x390784, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1ac, buffer=0x390804, count=0x80) trace:x11drv:X11DRV_SetWindowPos win 0x10020 window (0,0)-(1024,768) client (0,0)-(1024,768) style 86000000 trace:x11drv:X11DRV_CreateWindow hwnd 0x10020 cs 0,0 1024x768 trace:x11drv:X11DRV_CreateWindow win 0x10020 window 0,0,1024,768 client 0,0,1024,768 whole 0,0,1024,768 X client 0,0,1024,768 xwin 4d trace:x11drv:X11DRV_ShowWindow hwnd=0x10020, cmd=5, wasVisible 0 trace:x11drv:X11DRV_CreateBitmap (0x1d4) 32x32 24 bpp trace:x11drv:X11DRV_CreateBitmap (0x1d8) 32x32 1 bpp trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1d8, buffer=0x3908ac, count=0x80) trace:x11drv:X11DRV_GetBitmapBits (bmp=0x1d4, buffer=0x39092c, count=0xc00) trace:x11drv:X11DRV_SetWindowPos win 0x10022 window (0,0)-(0,0) client (0,0)-(0,0) style 04c00000 trace:x11drv:X11DRV_SetWindowPos making win 0x10022/4000001 managed trace:x11drv:X11DRV_SetWindowPos win 0x10022 window (0,0)-(0,0) client (0,0)-(0,0) style 04c00000 trace:x11drv:X11DRV_CreateWindow hwnd 0x10022 cs 0,0 0x0 trace:x11drv:X11DRV_SetWindowPos win 0x10022 window (0,0)-(0,0) client (3,22)-(3,22) style 04c00000 trace:x11drv:X11DRV_sync_window_position setting win 4000001 pos 0,0,0x0 after 7ecb8ec0 changes=40 trace:x11drv:X11DRV_CreateWindow win 0x10022 window 0,0,0,0 client 3,22,3,22 whole 0,0,0,0 X client 3,22,3,22 xwin 4000001 trace:x11drv:X11DRV_SetWindowPos win 0x10024 window (153,75)-(861,599) client (153,75)-(861,599) style 04cf0000 trace:x11drv:X11DRV_SetWindowPos making win 0x10024/3c00001 managed trace:x11drv:X11DRV_SetWindowPos win 0x10024 window (153,75)-(861,599) client (153,75)-(861,599) style 04cf0000 trace:x11drv:X11DRV_sync_window_position setting win 3c00001 pos 157,98,700x497 after 4 changes=f trace:x11drv:X11DRV_CreateWindow hwnd 0x10024 cs 153,75 708x524 trace:x11drv:X11DRV_CreateBitmap (0x33c) 7x11 1 bpp trace:x11drv:X11DRV_CreateBitmap (0x34c) 7x11 1 bpp trace:x11drv:X11DRV_SetWindowPos win 0x10024 window (153,75)-(861,599) client (157,117)-(857,595) style 04cf0000 trace:x11drv:X11DRV_sync_window_position setting win 3c00001 pos 157,98,700x497 after 4 changes=40 trace:x11drv:X11DRV_CreateWindow win 0x10024 window 153,75,861,599 client 157,117,857,595 whole 157,98,857,595 X client 0,19,700,497 xwin 3c00001 trace:x11drv:X11DRV_SetWindowPos win 0x10026 window (0,0)-(700,478) client (0,0)-(700,478) style 40a00144 trace:x11drv:X11DRV_CreateWindow hwnd 0x10026 cs 0,0 700x478 trace:x11drv:X11DRV_SetWindowPos win 0x10026 window (0,0)-(700,478) client (3,3)-(681,475) style 40a00144 trace:x11drv:X11DRV_CreateWindow win 0x10026 window 0,0,700,478 client 3,3,681,475 whole 0,0,700,478 X client 3,3,681,475 xwin 0 trace:x11drv:X11DRV_ShowWindow hwnd=0x10026, cmd=5, wasVisible 0 trace:x11drv:X11DRV_CreateBitmap (0x404) 2x13 1 bpp trace:x11drv:X11DRV_ShowWindow hwnd=0x10024, cmd=1, wasVisible 0 trace:x11drv:X11DRV_SetWindowPos win 0x10024 window (153,75)-(861,599) client (157,117)-(857,595) style 14cf0000 trace:x11drv:X11DRV_sync_window_position setting win 3c00001 pos 157,98,700x497 after 359 changes=40 trace:x11drv:X11DRV_SetWindowPos mapping win 0x10024 trace:x11drv:X11DRV_CreateBitmap (0x420) 32x32 1 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x420, bits=0x1266f0, count=0x80) trace:x11drv:X11DRV_CreateBitmap (0x41c) 32x32 24 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x41c, bits=0x1269e8, count=0xc00) trace:x11drv:update_fullscreen_state setting fullscreen state for window 3c00001 to false trace:x11drv:X11DRV_SetWindowPos win 0x10026 window (0,0)-(700,478) client (3,3)-(681,475) style 50a00144 trace:x11drv:X11DRV_Expose win 0x10024 (3c00001) 0,0 700x497 trace:x11drv:X11DRV_CreateBitmap (0x194) 8x8 1 bpp trace:x11drv:X11DRV_SetBitmapBits (bmp=0x194, bits=0x1189a0, count=0x10) trace:x11drv:X11DRV_SetWindowPos win 0x10024 window (153,75)-(861,599) client (157,117)-(857,595) style 04cf0000 trace:x11drv:X11DRV_SetWindowPos unmapping win 0x10024 trace:x11drv:destroy_whole_window win 0x10024 xwin 3c00001

5 7

Re: [AppDB] Get additional comments to display properly
by Chris Morgan 11 Oct '07

11 Oct '07

Can you attach the patch instead of including it inline? Also, can you provide an example of what is broken and why wrapping things with <pre> is going to fix it. Chris On 10/10/07, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: > Change log: Get additional comments in test results to display properly > > Files changed: apidb.css include/testData.php > > > From nobody Mon Sep 17 00:00:00 2001 > From: Tony Lambregts <tony.lambregts(a)gmail.com> > Date: Wed Oct 10 20:12:08 2007 -0600 > Subject: Get additional comments to display properly > > --- > > apidb.css | 9 ++++++++- > include/testData.php | 4 ++-- > 2 files changed, 10 insertions(+), 3 deletions(-) > > 747b763dda190e245b8658db146839939f753134 > diff --git a/apidb.css b/apidb.css > index 67ca444..214a5c9 100644 > --- a/apidb.css > +++ b/apidb.css > @@ -23,7 +23,14 @@ A.hidden { text-decoration: n > OL,UL,P { font-size: 12px; } > TD,TR,TH { font-size: 12px; } > INPUT { font-size: 12px; } > -PRE { font-family: monospace; font-size: 12px; } > +PRE { font-size: 12px; > + color: #000000; > + white-space: pre-wrap; /* css-3 */ > + white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ > + white-space: -pre-wrap; /* Opera 4-6 */ > + white-space: -o-pre-wrap; /* Opera 7 */ > + word-wrap: break-word; /* Internet Explorer 5.5+ */ > + font-family: "bitstream vera sans", "verdana", "arial", "helvetica", sans-serif;} > > /* Hn Sizes */ > H1 { font-size: 180%; } > diff --git a/include/testData.php b/include/testData.php > index 3dd833e..a4a7414 100644 > --- a/include/testData.php > +++ b/include/testData.php > @@ -467,8 +467,8 @@ class testData{ > echo $this->shWhatDoesnt,"\n"; > echo ' What was not tested ',"\n"; > echo $this->shWhatNotTested,"\n"; > - echo ' Additional Comments ',"\n"; > - echo $this->sComments,"\n"; > + echo ' Additional Comments <pre>',"\n"; > + echo $this->sComments.'</pre>',"\n"; > } > > function CreateTestTable() > -- > 1.2.4 > > > > >

1 0

Wine at Systems in Munich
by David M. Gümbel 10 Oct '07

10 Oct '07

Hi everybody, it seems there ist still some space left for a Wine booth at the "Systems" exhibition in Munich[1], from october 23 to 26. They asked me, but I won't be able to make it this year. Nor will Kai. Would anybody be interested to represent the Wine project down there? Thanks && Cheers, David

1 0

Re: gdi32: Try to load Wine's TrueType fonts from the build directory.
by Alexandre Julliard 10 Oct '07

10 Oct '07

Huw Davies <huw(a)codeweavers.com> writes: > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -2109,6 +2109,7 @@ BOOL WineEngInit(void) > > /* load the system truetype fonts */ > data_dir = wine_get_data_dir(); > + if(!data_dir) data_dir = wine_get_build_dir(); This causes a bunch of test failures here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:174: Test succeeded inside todo block: 32 != 32 font.c:175: Test succeeded inside todo block: 26 != 26 font.c:176: Test succeeded inside todo block: 6 != 6 font.c:177: Test succeeded inside todo block: 21 != 21 font.c:182: Test succeeded inside todo block: 32 != 32 font.c:174: Test succeeded inside todo block: 48 != 48 font.c:175: Test succeeded inside todo block: 39 != 39 font.c:176: Test succeeded inside todo block: 9 != 9 font.c:182: Test succeeded inside todo block: 48 != 48 font.c:385: Test failed: MS Sans Serif(13): tm.tmInternalLeading 0 != 2 font.c:392: Test failed: MS Sans Serif(13): tm.tmMaxCharWidth 4 != 11 font.c:383: Test failed: MS Sans Serif(16): tm.tmAscent 14 != 13 font.c:384: Test failed: MS Sans Serif(16): tm.tmDescent 2 != 3 font.c:385: Test failed: MS Sans Serif(16): tm.tmInternalLeading 0 != 3 font.c:392: Test failed: MS Sans Serif(16): tm.tmMaxCharWidth 5 != 14 font.c:383: Test failed: MS Sans Serif(20): tm.tmAscent 17 != 16 font.c:384: Test failed: MS Sans Serif(20): tm.tmDescent 3 != 4 font.c:385: Test failed: MS Sans Serif(20): tm.tmInternalLeading 0 != 4 font.c:392: Test failed: MS Sans Serif(20): tm.tmMaxCharWidth 6 != 16 font.c:386: Test failed: Courier(13): tm.tmExternalLeading 1 != 0 font.c:392: Test failed: Courier(13): tm.tmMaxCharWidth 4 != 8 font.c:385: Test failed: System(16): tm.tmInternalLeading 0 != 3 font.c:386: Test failed: System(16): tm.tmExternalLeading 90 != 0 font.c:385: Test failed: Small Fonts(11): tm.tmInternalLeading 0 != 2 font.c:386: Test failed: Small Fonts(11): tm.tmExternalLeading 90 != 0 font.c:392: Test failed: Small Fonts(11): tm.tmMaxCharWidth 3 != 9 make: *** [font.ok] Error 26 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32: function kind for dispatch interfaces should be FUNC_DISPATCH (with test, fixes bug #9057)
by Alexandre Julliard 10 Oct '07

10 Oct '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > +[uuid(8b05fe77-4a6c-4133-b9cd-8f81747af784)] > +library Test > +{ > + importlib("../../stdole2.tlb/std_ole_v2.tlb"); You shouldn't use an explicit path here. > +#define expect_eq(expr, value, type, format) { type _ret = (expr); ok((value) == _ret, #expr " expected " format " got " format "\n", value, _ret); } > +#define expect_int(expr, value) expect_eq(expr, (LONGLONG)value, LONGLONG, "%lld") > +#define expect_hex(expr, value) expect_eq(expr, (LONGLONG)value, LONGLONG, "0x%llx") Please don't use %ll formats, they aren't portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

revamp categories
by Jan Zerebecki 10 Oct '07

10 Oct '07

1 0

Re: mshtml: Added support for installing Gecko from the local file. [fixed]
by Detlef Riekenberg 10 Oct '07

10 Oct '07

On Mi, 2007-10-10 at 14:44 +0200, Jacek Caban wrote: > + > + file_name = mshtml_alloc(size+sizeof(GECKO_FILE_NAME)); > + res = RegQueryValueExA(hkey, "GeckoCabDir", NULL, &type, > + res = RegQueryValueExA(hkey, "GetckoCabDir", NULL, &type, > (PBYTE)file_name, &size); An advantage with a string defined as const: No Typo -- By by ... Detlef

1 0

wine-sspi category for bugzilla.
by Kai Blin 10 Oct '07

10 Oct '07

Hi folks, I'd like to have a wine-sspi or wine-secur32 category for bugzilla. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 3

Re: [Bug 9962] wine ntfs-3g segfaults
by Kai Blin 10 Oct '07

10 Oct '07

On Wednesday 10 October 2007 11:34:55 wine-bugs(a)winehq.org wrote: Taking this to the mailing list, as it shouldn't be discussed on the bug. > Vitaliy: what functionality specifically do you need from ntfs-3g? Shared > writable mmap support indeed needs an extra kernel patch which is not in > mainline yet but we are not aware of any other widely needed feature. We're > developing ntfs-3g, so people can run application directly from NTFS using > wine. Szabolcs, the biggest reason why we don't tell people to run applications from an NTFS partition is not strictly a technical one but just the fact that people then try to run applications they installed under windows. This will fail for almost every application that depends on certain registry entries being created by the install process. I don't know what other features Vitaly was talking about. Perhaps you can elaborate on that here, Vitaly? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 3

Re: setupapi(1/16): Test SetupDiInstallClass
by Alexandre Julliard 10 Oct '07

10 Oct '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > From e3c4fd59e419c74431a7062228d023a9513a5af1 Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Mon, 8 Oct 2007 17:06:41 -0700 > Subject: [PATCH] Test SetupDiInstallClass > > --- > dlls/setupapi/tests/devinst.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 files changed, 36 insertions(+), 0 deletions(-) This fails here: ../../../tools/runtest -q -P wine -M setupapi.dll -T ../../.. -p setupapi_test.exe.so devinst.c && touch devinst.ok devinst.c:173: Test failed: SetupDiInstallClassA failed: 00000002 make[2]: *** [devinst.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32/locale.c: partially implement GetUserGeoID()
by Alexandre Julliard 10 Oct '07

10 Oct '07

EA Durbin <ead1234(a)hotmail.com> writes: > + if(!(hkey = create_registry_key())) return ret; > + hSubkey = NLS_RegOpenSubKey( hkey, geoW ); > + count = sizeof(bufferW); > + > + switch( GeoClass ){ > + case GEOCLASS_NATION: > + NtQueryValueKey(hSubkey, &keyW, KeyValuePartialInformation, (LPBYTE)bufferW, count, &count); > + retID = strtolW( (LPCWSTR)info->Data, &end, 10 ); You need some error checking in there, the key and/or value may not exist. > + case GEOCLASS_REGION: > + /* GetUserGeoID returns a GEOID from the table listed here > + http://msdn2.microsoft.com/en-us/library/ms776390.aspx > + Default windows behavior is to post this code to the Geo/Nation Key during SetUserGeoID(), not sure how the region request is handled */ Please don't put URLs in the code, particularly not from MSDN since they change all the time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx8: patch 2; Implement D3DXVec2LengthSq
by Alexandre Julliard 10 Oct '07

10 Oct '07

David.Adam(a)math.cnrs.fr writes: > diff --git a/dlls/d3dx8/d3dx8.spec b/dlls/d3dx8/d3dx8.spec > index 3293614..325d0a5 100644 > --- a/dlls/d3dx8/d3dx8.spec > +++ b/dlls/d3dx8/d3dx8.spec > @@ -1,4 +1,5 @@ > @ stub D3DXVec2Normalize > +@ stdcall D3DXVec2LengthSq(ptr) The function is not stdcall, and AFAICS it's supposed to be inline, not exported by the dll. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml #3: Added support for installing Gecko from the local file.
by Alexandre Julliard 10 Oct '07

10 Oct '07

Jacek Caban <jacek(a)codeweavers.com> writes: > WINE_DEFAULT_DEBUG_CHANNEL(mshtml); > > +#define GECKO_FILE_NAME "wine_gecko-" GECKO_VERSION ".cab" > +#define DEFAULT_CAB_FILE_NAME "/usr/share/wine/gecko/" GECKO_FILE_NAME You need to use wine_get_data_dir() instead of hardcoding the path. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ftp.c: skip tests if we can't connect to ftp.winehq.org
by Alexandre Julliard 10 Oct '07

10 Oct '07

Dimi Paun <dimi(a)lattica.com> writes: > diff --git a/dlls/wininet/tests/ftp.c b/dlls/wininet/tests/ftp.c This doesn't work for me: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so ftp.c && touch ftp.ok ftp.c:790: Test failed: InternetConnect failed : 12015 wine: Unhandled page fault on read access to 0x0067006e at address 0x60568d4e (thread 0009), starting debugger... WineDbg starting on pid 0008 Unhandled exception: page fault on read access to 0x0067006e in 32-bit code (0x60568d4e). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:60568d4e ESP:0033fd30 EBP:0033fd68 EFLAGS:00010206( - 00 - RIP1) EAX:0067006e EBX:60580718 ECX:60586ca0 EDX:60586ca4 ESI:00670046 EDI:00126320 Stack dump: 0x0033fd30: 001100b8 60580718 0033fd68 60568190 0x0033fd40: 60586ca0 00000000 0033fd58 60586ca0 0x0033fd50: 00125558 00000000 00125528 60580718 0x0033fd60: 00000001 6052d1d2 0033fd98 6056a8df 0x0033fd70: 00000001 00000000 00000000 00000000 0x0033fd80: 6052d201 6052d1d2 00000000 6053815c Backtrace: =>1 0x60568d4e WININET_FreeHandle+0xbe(hinternet=0x1) [/home/julliard/wine/wine/dlls/wininet/internet.c:222] in wininet (0x0033fd68) 2 0x6056a8df InternetCloseHandle+0x3f(hInternet=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/internet.c:1021] in wininet (0x0033fd98) 3 0x60514dea func_ftp+0x19fa() [/home/julliard/wine/wine/dlls/wininet/tests/ftp.c:860] in wininet_test (0x0033fe58) 4 0x6052c938 run_test+0x128(name=0x1103e8) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:389] in wininet_test (0x0033fea8) 5 0x6052cfcd main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/wininet/tests/../../../include/wine/test.h:437] in wininet_test (0x0033fed8) 6 0x6052d09b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in wininet_test (0x0033ff08) 7 0x7b8746ce start_process+0xee(arg=0x0) [/home/julliard/wine/wine/dlls/kernel32/process.c:839] in kernel32 (0x0033ffe8) 8 0x600289a7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x60568d4e WININET_FreeHandle+0xbe [/home/julliard/wine/wine/dlls/wininet/internet.c:222] in wininet: movl 0x28(%esi),%edx 222 LIST_FOR_EACH_ENTRY_SAFE( child, next, &info->children, WININETHANDLEHEADER, entry ) Wine-dbg> -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: x11drv: don't consume Expose events when filter contains QS_PAINT
by Clinton Stimpson 10 Oct '07

10 Oct '07

Clinton Stimpson wrote: > Fix for bug 9875 (There are more details in that bug report if you want). > Existance of update regions in the wine server correspond with WM_PAINT > existing in queue. Existance of Expose events in the X event queue don't > correspond with update regions in the wine server, which can result in a loss > of painting some regions. > > Don't consume Expose events when filtering with QS_PAINT. > Anything wrong with this patch? Thanks, Clinton Stimpson

2 1

Re: wined3d: Make sure GL context is created before binding FBO.
by Stefan Dösinger 10 Oct '07

10 Oct '07

Am Dienstag, 9. Oktober 2007 04:18:29 schrieb Allan Tong: > This patch moves the call to ActivateContext ahead of the opengl > calls. This fixes a crash I was getting in the Bioshock demo where a > newly created thread was calling glBindFramebufferEXT before a > rendering context was established for the thread. The patch is correct in spirit, ActivateContext has to be called before other gl stuff is done, but I have found that it causes some problems for an unknown reason. So perhaps other bugfixes are needed before this works properly. One of the problems was a major rendering problem in half life 2 lost coast.

2 1

Request for "wine packages" bugzilla component
by Scott Ritchie 09 Oct '07

09 Oct '07

Sometimes we have bugs directly related to our packaging. It would be nice to have a bugzilla component for them, and perhaps automatically subscribe the package maintainers. Thanks, Scott Ritchie

2 1

Fwd: Open source organizations particpating in Kerberos consortium?
by Dan Kegel 09 Oct '07

09 Oct '07

Should Wine (represented by Kai?) participate in the Kerberos consortium? If we want to, the door's open... Stephen C. Buckley <sbuckley(a)mit.edu> wrote: >Dan Kegel wrote: >>Is the consortium open to participation by open >>source orgs like Wine and Samba? It might be useful... > >Absolutely! > >Stephen C. Buckley >Executive Director >MIT Kerberos Consortium >Massachusetts Institute of Technology >77 Massachusetts Ave W92-159 >Cambridge, MA 02139 > >email: sbuckley(a)mit.edu >web: http://www.kerberos.org

2 1

Re: comctl32: fixed drawing the trackbar background when themes are installed
by Frank Richter 09 Oct '07

09 Oct '07

On 07.10.2007 17:41, Reece Dunn wrote: > The DPI trackbar has a black background that does not match the > property sheet background. > > This patch fixes this so that the trackbar is drawn correctly. Wouldn't, or so says my intuition, the parent background usually be drawn before the control background? -f.r.

2 1

OpenGL child windows (bug 2398, fixed!)
by Roderick Colenbrander 09 Oct '07

09 Oct '07

Hi, Thanks to Chris his recent child window work, there is now support for OpenGL child windows in Wine. For the exact details read bug 2398 or Chris his patches. In short the patches use XComposite were possible and else X pixmaps. Not all drivers support both properly yet but for compiz/aiglx purposes most drivers are adding the needed support. I would say test the stuff and report problems. Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

5 7

Wine Desktop Integration Code
by EA Durbin 09 Oct '07

09 Oct '07

Out of curiousity, where can I find the code in the wine source that handles creation of the Menu entries in Gnome and KDE. _________________________________________________________________ Peek-a-boo FREE Tricks & Treats for You! http://www.reallivemoms.com?ocid=TXT_TAGHM&loc=us

3 2

Re: [bugzilla] Upgrade from 3.0 to 3.0.2 .
by Alexandre Julliard 09 Oct '07

09 Oct '07

Jan Zerebecki <jan.wine(a)zerebecki.de> writes: > --- > See http://www.bugzilla.org/releases/3.0.2/release-notes.html and > http://www.bugzilla.org/status/changes.html for information about > the changes. > --- > If this patch is rejected from inclusion, please tell me why, as > I would have to ask anyway. Now that we are using a git repository, upgrades should be done by importing the new version to the upstream branch and doing a git merge, instead of applying a patch directly to the master branch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PulseAudio as a sound output?
by King InuYasha 08 Oct '07

08 Oct '07

On 10/8/07, King InuYasha <ngompa13(a)gmail.com> wrote: > > Wine must not let go of the OSS support since OSS was recently made GPL'd > and CDDL'd for use in FOSS kernels by its maker (4Front) and OSS is the > POSIX audio system of choice for nearly every time except Linux. Linux does > not use OSS anymore and uses ALSA. Since Linux is the primary target of > Wine, obviously ALSA needs to be well supported. Since under normal > conditions ALSA and OSS do horrible mixing and handling of audio (kernel or > audio module bug, whatever, its still a problem), I'm betting that was why > the ESD and JACK drivers were made. I am not disputing the JACK driver > because I recognize that JACK may be necessary for certain tasks. > > However, the ESD driver should be replaced with something more up to date. > I hope that PulseAudio would be that replacement. I don't think I suggested > removing the baseline stuff (ALSA and OSS). PulseAudio is what I would > consider to be the middle man between JACK and ALSA/OSS. Mainly because it > does have some of the upscale features (low-latency, network sound, etc.) > and some of the commodity features (superior mixing, multiple audio backend > support like ALSA, OSS, and Win32MM, etc.) I believe this balance would help > with Wine sound very much. > > Certainly the new scheduler in Linux kernel 2.6.23 would improve how the > kernel/kernel modules handle threading and processing the audio streams, but > that wouldn't necessarily help with the baser problems (mixing, stream > locks, etc.) though it does help with stuff like stuttering. I also > recognize that Alexandre may not want to support so many audio backends. I > find only three absolutely necessary, and the fourth one is widely clamored > for. The necessary ones are: JACK, OSS, and PulseAudio. The widely clamored > one is ALSA. Why? Because ALSA is ENTIRELY Linux specific. Wine is to be a > Win32 to UNIX translation layer for compiled applications. If too much focus > on being Linux-specific is given, I believe it will mess up general FOSS > adoption as a whole. > > Just my two cents.... :) > > On 10/8/07, Tijl Coosemans <tijl(a)ulyssis.org> wrote: > > > > On Monday 08 October 2007 14:43:30 Dave Phillips wrote: > > > Well, first I'd suggest simply supporting ALSA as thoroughly as > > > necessary or possible. It is the default kernel sound system, Wine > > > may as well incorporate it as well as it can. Supporting the > > > deprecated OSS API might be a good idea too, through ALSA's > > > OSS-compatibility layer. As one devel noted, it may be a good idea to > > > forego further development of things like the NAS and ESD servers > > > until a more solid basis exists for ALSA/OSS. > > > > I just wanted to add that OSS isn't deprecated. ALSA is Linux-only. > > OSS is a multiplatform solution. > > > > > > >

1 0

Wine's wikipedia article sucks
by Scott Ritchie 08 Oct '07

08 Oct '07

The current article for Wine is here: http://en.wikipedia.org/wiki/Wine_%28software%29 It needs a lot of work. There's a large (and growing) todo list on the talk page: http://en.wikipedia.org/wiki/Talk:Wine_%28software%29 Some of the information needed (eg, statistics for Wine usage) are likely unavailable to the average wikipedian, so we Wine experts might need to help directly. I'm pretty sure a good wikipedia article, with proper links and explanations, would cut down significantly on the amount of user misinformation about Wine. Fixing the wikipedia article might do more for usability than actually improving the software. Thanks, Scott Ritchie

1 0

Moving the wine status pages to the wiki
by Kai Blin 08 Oct '07

08 Oct '07

Hi folks, I'm currently looking into getting an up-to-date list of maintainers for certain subsystems. I would like to keep that in the context of the dll status pages, but in order to keep them maintainable, I'm considering to move those pages to the wiki. Any thoughts about that? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 2

WineConf - Slides online
by Marcus Meissner 08 Oct '07

08 Oct '07

Hi, I have uploaded the slides of Alexandres Status report to http://wiki.winehq.org/WineConf2007 (direct link: http://wiki.winehq.org/WineConf2007?action=AttachFile&do=get&target=winecon… ) Feel free to upload more slides, and if you are lazy, send them to me and I will ;) Ciao, Marcus

5 4

Bugzilla and spam harvesting
by Dan Kegel 08 Oct '07

08 Oct '07

Should we modify our Bugzilla to hide email addresses at least a little? I'd like that myself, and users request it occasionally. Just now, somebody asked that he be removed from bugzilla because it doesn't do this. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: Request to be unbanned from #winehq (Jan Zerebecki)
by luis.busquets＠ilidium.com 08 Oct '07

08 Oct '07

Dear all, Which program do I have to use to get connected in the #winehq channel? I have truly been out of chatting for a long time.

2 1

AW: 1.0 Bugs - Microsoft Office 2003
by Roland Kaeser 08 Oct '07

08 Oct '07

Hello Sorry for my cheek, but don't a 1.0-Version mean that every Windows app works on Wine? Regards Roland ----- Ursprüngliche Mail ---- Von: Dan Kegel <dank(a)kegel.com> An: EA Durbin <ead1234(a)hotmail.com> CC: Wine Developers List <wine-devel(a)winehq.org> Gesendet: Sonntag, den 7. Oktober 2007, 22:36:41 Uhr Betreff: Re: 1.0 Bugs - Microsoft Office 2003 On 10/7/07, EA Durbin <ead1234(a)hotmail.com> wrote: > I was able to get around bug 9023 with a patch applied to the appdb I see you attached the patch to bug 9023, thanks. > and I > did some further testing in Office 2003 today. Initially I'm prompted to > activate my copy of microsoft office 2003, and both means of activating the > application are broken in wine due to bugs 9943 and 9944. Then I tried to > open VBA inside of Office and was prompted with a dialog stating unable to > open macro storage(bug 8795). The only real reason I use Microsoft Office > over Open Office is the need for VBA integration. > > I think we should add these bugs to the 1.0 target http://bugs.winehq.org/show_bug.cgi?id=8795 http://bugs.winehq.org/show_bug.cgi?id=9023 http://bugs.winehq.org/show_bug.cgi?id=9943 http://bugs.winehq.org/show_bug.cgi?id=9944 I'm not opposed, but perhaps we should be clear. Do we want to add Microsoft Word 2003 to the "must have" apps list for 1.0? It might delay the release. - Dan ________ Yahoo! Clever: Stellen Sie Fragen und finden Sie Antworten. Teilen Sie Ihr Wissen. www.yahoo.de/clever

2 1

RE: Wine 1.0 bugs, release criteria
by Karl Relton 07 Oct '07

07 Oct '07

I would like consideration given to http://bugs.winehq.org/show_bug.cgi?id=3739 http://bugs.winehq.org/show_bug.cgi?id=4362 I would imagine Adobe PhotoDeluxe might be quite common among home users (who may get a copy with their digital camera, and not fork out for full Photoshop). The other bug has a proposed fix - and something of a testcase to prove it. Its just a matter of getting it squared up and applied. Regards Karl

2 1

Request to be unbanned from #winehq
by Tsukasa 07 Oct '07

07 Oct '07

Vitamin banned me today - you can see the full log here. Also I was about to say at the end there, if redhat automounts usb sticks. http://pastebin.com/mb489dc I think what really pissed him off was that I asked for help identifying a bug in Loki in #winehackers originally. I asked in the user channel after i was informed it was the wrong channel. Anyways, can I get unbanned from #winehq? You can do a whois on tsukasa to find my info.

5 4

Re: problem compiling dlls/ntdll/actctx.c
by sol11x86＠comcast.net 07 Oct '07

07 Oct '07

-------------- Original message ---------------------- From: Jacek Caban <jacek(a)codeweavers.com> > Hi Ben, > > Ben Taylor wrote: > > haven't built wine in a while, and ran into this on Solaris 10: > > > > actctx.c:76: error: `version' defined as wrong kind of tag > > gmake[2]: *** [actctx.o] Error 1 > > gmake[2]: Leaving directory `/export/src/wine/100607/wine/dlls/ntdll' > > gmake[1]: *** [ntdll] Error 2 > > gmake[1]: Leaving directory `/export/src/wine/100607/wine/dlls' > > gmake: *** [dlls] Error 2 > > > > > > Does the attached patch help? Yes. That works. Ben > > Jacek >

1 0

No joy with XComposite extension on Gutsy on Thinkbook X60
by Dan Kegel 07 Oct '07

07 Oct '07

Sorry, here's a little brain dump before I go to bed. I'm running updated Gutsy beta on a Thinkbook X60, and am testing out wine from git on Google Earth. Initially it aborted on startup with X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 145 (XFree86-DRI) The log also showed it couldn't find the XComposite extension, and sure enough, config.log showed configure hadn't found it. I think I fixed this with sudo apt-get install libxcomposite-dev and reconfiguring and rebuilding Wine. But now when I start Google Earth, it aborts with DRM_I830_CMDBUFFER: -22 According to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=394311 this is "libgl1-mesa-dri: i965_dri.so miscompiled with current gcc". A patch was attached there: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=30;bug=394311 The bug's been reported to Ubuntu: https://bugs.launchpad.net/ubuntu/+source/mesa/+bug/66645 Any clues? - Dan

2 3

problem compiling dlls/ntdll/actctx.c
by sol11x86＠comcast.net 07 Oct '07

07 Oct '07

haven't built wine in a while, and ran into this on Solaris 10: actctx.c:76: error: `version' defined as wrong kind of tag gmake[2]: *** [actctx.o] Error 1 gmake[2]: Leaving directory `/export/src/wine/100607/wine/dlls/ntdll' gmake[1]: *** [ntdll] Error 2 gmake[1]: Leaving directory `/export/src/wine/100607/wine/dlls' gmake: *** [dlls] Error 2 starting line 74 of actctx.c, I see struct version { USHORT major; USHORT minor; USHORT build; USHORT revision; }; struct assembly_identity { WCHAR *name; WCHAR *arch; WCHAR *public_key; WCHAR *language; WCHAR *type; struct version version; BOOL optional; }; struct entity { DWORD kind; union { struct { WCHAR *tlbid; WCHAR *version; WCHAR *helpdir; } typelib; struct { WCHAR *clsid; } comclass; struct { WCHAR *iid; WCHAR *name; } proxy; struct { WCHAR *name; } class; struct { WCHAR *name; WCHAR *clsid; } clrclass; struct { WCHAR *name; WCHAR *clsid; } clrsurrogate; } u; }; But after some google searches and such, I can't come to a conclusion if it's a clash with a predefined version in a Solaris include file, or a clash with the version in the union which is a WCHAR. Ideas.?

2 1

Re: [PATCH] comctl32: add greek resources (resend)
by Dj Apal [GR] 07 Oct '07

07 Oct '07

There has been 1 1/2 month since Lei sent this patch for Greek resource file for common control and I don't see it in cvs. Why is that??? 2007/8/23, Lei Zhang <thestig(a)google.com>: > > Hi, > > Apostolos Alexiadis (djapal(a)gmail.com) sent several copies of this > patch, but none of them were in the right format. I sent him the > proper patch (attached) and asked him to send it to wine-patches, but > he never did. So here it is. > > > >

1 0

List of 2007 SoC projects
by Dan Kegel 07 Oct '07

07 Oct '07

For reference, the projects from this past year are listed at http://code.google.com/soc/2007/wine/about.html -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: [PATCH] handle gecko not installed
by Jacek Caban 07 Oct '07

07 Oct '07

Marcus Meissner wrote: > This handles failures on "wine" testplatform > with Gecko not installed. > > The testplatform checks might be more generic. > > Ciao, Marcus > This patch should fix it: http://www.winehq.org/pipermail/wine-patches/2007-October/044833.html Thanks, Jacek

1 0

Re: PATCH: fix out of range array access in dlls/kernel32/relay16.c
by Alexandre Julliard 06 Oct '07

06 Oct '07

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Looking at this code it becomes clear we perform out of range array > accesses in those cases we execute the full loops. This can't happen. If there's no ret instruction in the entry point we'll have much bigger problems than an out of range access... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [Bug 2680] Wine should report 32bit color depth instead of 24bit
by James Hawkins 06 Oct '07

06 Oct '07

On 10/6/07, wine-bugs(a)winehq.org <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=2680 > > > Roderick Colenbrander <thunderbird2k(a)gmx.net> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Depends on| |9918 > > > > > --- Comment #14 from Roderick Colenbrander <thunderbird2k(a)gmx.net> 2007-10-06 15:56:29 --- > This appears to be the 'original' bug 9918. I wasn't aware of it but various > bugs have already been attached to 9918. So I'll attach this one to 9918 too. > > bug 9918: GetDeviceCaps BPP should use XVisualInfo which is synonymous with bug 2680: Wine should report 32bit color depth instead of 24bit blocks: * bug 2680: Wine should report 32bit color depth instead of 24bit (DAZ studio) * bug 3319: GetDeviceCaps: BITSPIXEL returning 15 on 15bit graphics (no app) * bug 4278: Splinter Cell: Pandora Tomorrow fails with need 32bit color * bug 4935: IHP Kitchen: Unhandled page fault on read access * bug 5671: qtracker crashes before first screen This is exactly why metabugs are a bad idea. With very few exceptions, Wine's bugzilla bug reports should be about apps only. If any apps fail because of the exact same cause (bug), then the appropriate bugs need to be marked as duplicates of the original bug report. Topics like "Wine should report 32bit color depth instead of 24bit" and "GetDeviceCaps: BITSPIXEL returning 15 on 15bit graphics" are development planning information, and as such this information belongs in the wiki. Unless I'm mistaken, the formerly quoted bugs are all about the fact that Wine returns 24bit color depth instead of 32bit. Why are there at least 6 bug reports about one bug? bug 3319 should be closed as invalid, moving the information to the wiki. bugs 9918, 4278, 4935 and 5671 need to be marked as duplicates of bug 2680. > This appears to be the 'original' bug 9918. I wasn't aware of it but various > bugs have already been attached to 9918. So I'll attach this one to 9918 too. I'm sorry, but that's just really lazy. As of this writing, there are 3218 open bugs in our bugzilla. Countless many of those bugs are invalid or duplicates, so we don't need to knowingly add to the clutter. Make sure you understand the difference between blocker and duplicate. Thanks, James Hawkins

1 0

Re: [PATCH] HTMLDocument adjust error handling
by Jacek Caban 06 Oct '07

06 Oct '07

Hi Marcus, Marcus Meissner wrote: > Hi, > > sometime we have failure cases where we > still return S_OK. > > I am not sure this is a good idea. > NULL is a valid return value of these function, so it's fine to return S_OK here (also you've changed non-error code paths). Thanks, Jacek

1 0

Counting failed unit tests...
by Dan Kegel 06 Oct '07

06 Oct '07

Here's a grep that's handy when looking at the output of 'make test': egrep '__test|make.*ok|Backtrace' This shows which .ok file failures and crashes occur, and also makes it easy to see which dll's they're in. -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Please create 1.1 milestone in bugzilla
by Dan Kegel 06 Oct '07

06 Oct '07

We're sorting through bugzilla fixing the target milestones for important bugs, and it would be useful to have a 1.1 milestone (to go along with the existing 0.9 and 1.0 milestones). Can the bugzilla admins create this, please? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: fonts: Add a Tahoma replacement. Almost entirely based on a patch by Larry Snyder.
by Chris Robinson 06 Oct '07

06 Oct '07

On Wednesday 03 October 2007 04:15:17 am Huw Davies wrote: > --- > fonts/.gitignore | 1 + > fonts/Makefile.in | 3 +- > fonts/tahoma.sfd |10850 > +++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, > 10853 insertions(+), 1 deletions(-) > create mode 100644 fonts/tahoma.sfd This makes Wine's text unreadable for me: http://kcat.strangesoft.net/badfont.png If I remove the new tahoma.tff file, it looks fine: http://kcat.strangesoft.net/goodfont.png

2 2

d3d10 beginning - review
by Kovács András 05 Oct '07

05 Oct '07

Hi, Here is my work, that is produced under Summer Of Code. I decided to send this to wine-devel, before I'm splitting to patches. It doesn't contain a few of debug functions, but on it. If something is wrong with this, please tell me. Best regards, Andras kovacs

2 1

Re: [PATCH] wininet: NULL-terminate url string passed to InternetCrackUrlW from InternetCrackUrlA
by Juan Lang 05 Oct '07

05 Oct '07

Hi Nigel, + lpwszUrl=HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(WCHAR)*(nLength+1)); + MultiByteToWideChar(CP_ACP,0,lpszUrl,dwUrlLength,lpwszUrl,(nLength+1)); + lpwszUrl[nLength] = 0; The last line is redundant: the HeapAlloc already zeroes the buffer. Though since MultiByteToWideChar is already overwriting the buffer, you might remove the HEAP_ZERO_MEMORY and leave this assignment. --Juan

1 0

Re: Maximum window size, help needed
by Kirill K. Smirnov 05 Oct '07

05 Oct '07

> I think that will help you GetSystemMetrics() with SM_CXFULLSCREEN and > SM_CYFULLSCREEN but I did not verify it. Sorry if I shall be not right. It is not what needed, but gives a clue: while reading GetSystemMetrics on MSDN, I was referred to GetMonitorInfo again, but I was told to use rcWork area. I re-test it under windows and voila: wine is buggy (rcWork == rcMonitor), but under windows rcWord < rcMonitor. >Or SystemParametersInfo() with SPI_GETWORKAREA will help you >(http://msdn2.microsoft.com/en-us/library/ms724947.aspx) This almost exactly what I needed, but it does not take into account different monitors. Anyway, problem is half-solved. Thanks, Anatoly! -- Kirill

2 1

Maximum window size, help needed
by Kirill K. Smirnov 05 Oct '07

05 Oct '07

Hi, I want to improve wineconsole a little, max hor and vert console window dimensions. To achieve this, I need to know maximum available size of window on the desktop. The simpliest way I found is to use GetMonitorInfo, but it does not take into account desktop panels. As the result, maximized window fills entire desktop, overlapping with KDE panel. So the question: is there such function, smth like GetMaxWindowSizeWithoutDesktopPanels, which clips panels? Thanks in advance -- Kirill P.S. Application which uses this - Far Manager

2 2

winex11.drv: Window must always recieve system messages.
by darkside83＠yandex.ru 05 Oct '07

05 Oct '07

Good day time. I had problems with window redrawing. This patch helps me. Please see the bug 9579.

1 0

Re: .NET going open source(sort of)
by Chris Spencer 05 Oct '07

05 Oct '07

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This article [ http://www.eweek.com/article2/0,1895,2191754,00.asp ] sums up pretty well why this is a bad thing. As you can imagine if MS ever releases Windows source code under their stupid non-open open source licence, the consequences could potentially be disastrous for Wine and similar projects (ReactOS). - -- Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHBMfH6iqRtkAADZgRAs62AKDS9lIQU4mAyiZlTNWwo+8WHYGr5QCdHQIp 943/rNrx6OeLL9S5UDAa/ig= =KkLl -----END PGP SIGNATURE-----

4 4

D3DX
by "Luis C. Busquets Pérez" 04 Oct '07

04 Oct '07

Dear all and in particular Alexander and Louis, I have seen that the work d3dx8 has began and that a number of functions have been added to the spec. I know this is a recurring subject but I think something should be done now. As you know, the fowllowing files d3dx8.dll d3dx9_24.dll d3dx9_25.dll d3dx9_26.dll d3dx9_27.dll d3dx9_28.dll d3dx9_29.dll d3dx9_30.dll d3dx9_31.dll d3dx9_32.dll d3dx9_33.dll d3dx9_34.dll d3dx9_35.dll Share a large number of functions. Actually, 142 of the 153 the functions you have added to d3dx8.spec are repeated in all those dlls. I think that a merge development should be done. That is to develop just one dlls/d3dx/d3dx.spec together with the different dlls/d3dx/xx.c files implementing those functions with the 349 functions that are used in all those d3d extensions. Then, the spec files of each specific file referring to d3dx. Are you opposed to such alternative? Luis

2 1

practical book on Wine/crossover
by Moncorge, Patricia 04 Oct '07

04 Oct '07

Hi, We (CampusPress, Pearson education france) would like to publish a practical book in French about Wine/Codeweaver. Do you know somebody, who would be interested in writing it? To whom should I turn here to find the french Wine/codeweaver community? Thank you in advance for your help, Patricia ************************************************************************** Patricia Moncorgé Computer Book Editor CampusPress / Pearson Education France http://www.pearsoneducation.fr <http://www.pearsoneducation.fr/> 01 72 74 90 40 47bis, rue des Vinaigriers 75010 Paris This email may contain confidential material. If you were not an intended recipient, please notify the sender and delete all copies. We may monitor email to and from our network. This email was sent by a company within the corporate group owned by Pearson plc, registered office at 80 Strand, London WC2R 0RL, registered in England and Wales with company number 53723 and VAT number GB 278 5371 21.

2 1

D3DX
by "Luis C. Busquets Pérez" 04 Oct '07

04 Oct '07

Dear all and in particular Alexander and Louis, I have seen that the work d3dx8 has began and that a number of functions have been added to the spec. I know this is a recurring subject but I think something should be done now. As you know, the fowllowing files d3dx8.dll d3dx9_24.dll d3dx9_24.dll d3dx9_24.dll d3dx9_24.dll d3dx9_24.dll

1 0

Re: [ws2_32] silently ignore WS_IP_DONTFRAGMENT
by Juan Lang 04 Oct '07

04 Oct '07

Hi Damjan, > I haven't been able to find an equivalent flag in Linux, so just ignore it for now. What about setting IP_MTU_DISCOVER to IP_PMTUDISC_DO (IP_PMTUDISC_DONT)? That shouldn't turn the don't fragment bit on (off) on a socket. --Juan

1 0

Re: [3/5] WineD3D: Add a (nested) loop test
by Alexandre Julliard 04 Oct '07

04 Oct '07

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From d2ae8c684ce5dc91a9c47b47758426d15fa1bd5f Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 14 Sep 2007 13:23:22 +0200 > Subject: [PATCH] WineD3D: Add a (nested) loop test This fails here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:3610: Test failed: Nested loop test returned color 0x007f0000, expected 0x00800000 make[2]: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

.NET going open source(sort of)
by EA Durbin 04 Oct '07

04 Oct '07

Looks like Microsoft is making their source code available for the .NET libraries. under their reference license. http://www.whurley.com/blog/2007/10/opennet-microso.html _________________________________________________________________ Climb to the top of the charts! Play Star Shuffle: the word scramble challenge with star power. http://club.live.com/star_shuffle.aspx?icid=starshuffle_wlmailtextlink_oct

4 4

Bits: DLL name and svchost questions
by Roy Shea 03 Oct '07

03 Oct '07

Howdy All, Thanks for helping me these past weeks as I get started with Wine development! I'm gaining a better understanding of the bits (Background Intelligent Transfer Service) COM service. Bits is run as a service via the svchost group netsvcs. Within netsvcs is the BITS service that is tied to qmgr.dll. The qmgr name is used for backwards compatibility and is where the bits implementation lives. Two questions for the wine gods: (1) Shall I add bits to wine in dlls/bits or dlls/qmgr? I recommend the former, since current Windows documentation refers to "bits". But this may confuse folks who don't understand the tie between qmgr and bits, as demonstrated by my patch attempt last week :-\ (2) Need I treat svchost as a prerequisite to my bits work? I recommend developing bits first (starting bits as a service on demand) and then worrying about svchost. Off the top of my head I think this will look the same to applications wanting to use bits. However, I'm new to the COM world and may be overlooking something... Thanks for the advice, -Roy

1 1

Re: [PATCH 3/3] server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions. [Try 2]
by Juan Lang 03 Oct '07

03 Oct '07

Hi Rob, + file->mode |= st.st_mode & (S_IRWXU|S_IRWXO); Why "|=" rather than simply "="? --Juan

2 1

Re: ntdll: loader.c prevent accidental calls of entry point during dll events(resend)
by James Hawkins 03 Oct '07

03 Oct '07

On 9/30/07, EA Durbin <ead1234(a)hotmail.com> wrote: > > Patch by Anastacious Focht > > The last one I submitted had a typo. > - if (nt->FileHeader.Characteristics & IMAGE_FILE_DLL) + /* do not setup entry point if kernel driver */ + if( !( Don't change the style (space after opening parenthesis). -- James Hawkins

3 3

Re: [PATCH 4/4] server: Add primitive support for setting and getting the security descriptor of files based on their Unix permissions.
by Alexandre Julliard 03 Oct '07

03 Oct '07

Robert Shearman <rob(a)codeweavers.com> writes: > + /* assume we are the owner */ > + if (st.st_mode & S_IRWXU) > + { Why are you assuming that? There doesn't seem to be much sense in checking permissions without checking the owner. -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: [PATCH] check return value of get_dc_ptr
by Alexandre Julliard 03 Oct '07

03 Oct '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > Coverity also spotted this one, and I agree. I don't, the DC is always valid since we are inside a driver call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine.inf[1/2]: remove non-existing modules from the fake dlls list
by Alexandre Julliard 03 Oct '07

03 Oct '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > ddhelp.exe is on the list of fake dlls even if I couldn't find any > reference to building such a file in Wine sources. The created fake > DLL couldn't be loaded with LoadLibrary (however what's interesting it > could be loaded with LoadLibraryEx(..., LOAD_AS_DATAFILE)) what upset > the GeoInfo installer. I've found that dsound.vxd also isn't > (anymore?) built in Wine. These two files are on the list by mistake? No, they are here because an app needs them. It's not always necessary to have a corresponding builtin, if the app doesn't try to actually load the dll a fake is enough. -- Alexandre Julliard julliard(a)winehq.org

1 0

secur32: Fix some memory leaks
by Andrew Talbot 02 Oct '07

02 Oct '07

Please ignore this patch: I overlooked the original scope of the allocations. -- Andy.

1 0

Font issues when building Wine from sources
by Reece Dunn 02 Oct '07

02 Oct '07

Hi, When I run an application using Wine from an X terminal, e.g. $ /opt/wine-0.9.43/bin/wine winecfg I get all the text (with the exception of the window title) displayed in the characters from the Marlett font. I have a Linux From Scratch 6.2 box with the following additional packages: * libpng 1.2.12 (needed by Xorg) * freetype 2.1.10 (needed by fontconfig) * expat 2.0.0 (needed by fontconfig) * fontconfig 2.3.2 (needed by Xorg) * Xorg 6.9.0 * fontforge 20070917 (Wine's ./configure says it needs this to build the fonts) * wine 0.9.42 (taken from git using the wine-0.9.43 tag) I am building wine as follows: ./configure --prefix=/opt/wine-0.9.43 make depend make make install all from a bash terminal (i.e. not X). Is there anything that I am missing, or am doing wrong? Thanks, - Reece

1 0

Re: Alexandre Julliard : ntdll: Remove assumptions that the subheap is at the beginning of the memory block .
by Allan Tong 02 Oct '07

02 Oct '07

> ntdll: Remove assumptions that the subheap is at the beginning of the memory block. In HEAP_CreateSubHeap, shouldn't the return value also be changed, e.g. return "&((HEAP*)address)->subheap" if a main heap was created? - Allan

2 1

WineConf this weekend
by Mike Hearn 02 Oct '07

02 Oct '07

Hello, If you're on the wineconf mailing list, you already received all the details for this weekend. If you weren't planning on coming, but are near Zurich and want to tag along anyway, feel free! We'll be on the 5th floor of Freigutstrasse 12: http://maps.google.com/maps?q=freigutstrasse+12,zurich Hope you see you all there! thanks -mike

7 7

Re: programs/net: Add russian resources (resend)
by Kirill K. Smirnov 02 Oct '07

02 Oct '07

My note is a nitpicking, but... >--- /dev/null 2007-06-28 07:33:44 +0400 >+++ programs/net/Ru.rc 2007-07-13 10:05:45 +0400 >@@ -0,0 +1,40 @@ >+/* >+ * NET.EXE - Wine-compatible net program >+ * English language support This file supports Russian language, not English >+ * >+ * Copyright (C) 2007 Konstantin Kondratyuk (Etersoft) >+ * Patching against git-current tree: $ cat net_russian.patch | patch -p0 patching file programs/net/rsrc.rc Hunk #1 succeeded at 24 (offset 1 line). patching file programs/net/Ru.rc It seems that something is definitely missed... -- Kirill

2 1

Are *any* games as popular as World of Warcraft?
by Dan Kegel 01 Oct '07

01 Oct '07

I spent some time noodling around looking at what games are really popular (I wouldn't know firsthand, I don't play much). There's some data at http://www.amazon.com/gp/bestsellers/videogames (click on PC Games). I tried to cross-check titles with Google Trends to see which ones seem enduringly popular, but I haven't found any that beat World of Warcraft yet: http://www.google.com/trends?q=world+of+warcraft%2C+guild+wars%2C+tomb+raid… Is Google search popularity a bad measure, or does it reflect the public's mood well? - Dan

9 10

Re: Janitorial : Rename 16-Bit files
by Alexandre Julliard 01 Oct '07

01 Oct '07

Rémi Assailly <remi.assailly(a)free.fr> writes: > I started 16 Bit separation. > This first patch renames : > - files containing 16 Bit functions only > - some 16 Bit functions. Please don't do that, there's no reason to rename things that are already separated properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Prefer a Microsoft cmap table over other platform ones
by Alexandre Julliard 01 Oct '07

01 Oct '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > the bug 9840 has the ttf font attached that has incomplete default unicode > charmap which Freetype selects. Assuming that Microsoft and Macintosh cmaps > are more widely used/tested, let's use a priority to choose from available > character maps. Freetype developers think that it's a better choice to fix > this kind of problem. > > Changelog: > gdi32: Prefer a Microsoft cmap table over other platform ones. This fails make test here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok fixme:font:WineEngGetKerningPairs encoding 1634889070 not supported font.c:761: Test failed: got matches 0, expected 26 fixme:font:WineEngGetKerningPairs encoding 1634889070 not supported font.c:761: Test failed: got matches 0, expected 26 fixme:font:WineEngGetKerningPairs encoding 1634889070 not supported font.c:761: Test failed: got matches 0, expected 26 fixme:font:get_font_unicode_ranges encoding 1634889070 not supported fixme:font:get_font_unicode_ranges encoding 1634889070 not supported make[2]: *** [font.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] Fix Ugly borders around undecorated windows in Gnome
by Kirill K. Smirnov 01 Oct '07

01 Oct '07

>This is my first attempt at submitting a patch to WINE, so please excuse >me if I have broken any conventions or am going through the wrong >channel. As it currently stands, wine is setting the 'MWM_DECOR_BORDER' >hint on managed but undecorated windows, such as iTunes, or Winamp. >This does not cause problems in KDE, but in Gnome it puts a gray border >around such windows. For me this causes problem in KDE too. Not just border but an ugly caption too :-( See http://www.winehq.org/pipermail/wine-devel/2007-September/059366.html >Not setting this hint does not seem to cause >problems in KDE and fixes the problem in Gnome. A patch to do just that >is attached. Comments? >--- dlls/winex11.drv/window_orig.c 2007-09-30 18:14:56.281259713 -0400 >+++ dlls/winex11.drv/window.c 2007-09-30 18:18:44.724576520 -0400 >@@ -591,11 +591,6 @@ > if (style & WS_MINIMIZEBOX) mwm_hints.decorations |= MWM_DECOR_MINIMIZE; > if (style & WS_MAXIMIZEBOX) mwm_hints.decorations |= MWM_DECOR_MAXIMIZE; > } >- if (ex_style & WS_EX_DLGMODALFRAME) mwm_hints.decorations |= >MWM_DECOR_BORDER; >- else if (style & WS_THICKFRAME) mwm_hints.decorations |= >MWM_DECOR_BORDER | MWM_DECOR_RESIZEH; >- else if ((style & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER; >- else if (style & WS_BORDER) mwm_hints.decorations |= MWM_DECOR_BORDER; >- else if (!(style & (WS_CHILD|WS_POPUP))) mwm_hints.decorations |= MWM_DECOR_BORDER; > } > XChangeProperty( display, data->whole_window, x11drv_atom(_MOTIF_WM_HINTS), You overdid here a little: WS_THICKFRAME must have thick border. As I think, we should not mix WS_BORDER and MWM_DECOR_BORDER. They have DIFFERENT semantics. WS_BORDER is 1px border, but MWM_DECOR_BORDER is a thick border. What for me, I'd deleted just these lines: >- else if (style & WS_BORDER) mwm_hints.decorations |= MWM_DECOR_BORDER; >- else if (!(style & (WS_CHILD|WS_POPUP))) mwm_hints.decorations |= MWM_DECOR_BORDER; and draw thin 1px border 'manually' (I mean, in user32, do not left it to Window Manager) -- Kirill

1 0

Re: msinkaut.idl: Add stub IInkCollector interface (resend)
by Alexandre Julliard 01 Oct '07

01 Oct '07

"John Klehm" <xixsimplicityxix(a)gmail.com> writes: > typedef float single; > + > + [ > + odl, > + uuid(F0F060B5-8B1F-4A7C-89EC-880692588A4F), > + dual, > + oleautomation > + ] > + interface IInkCollector : IDispatch { > + }; You have to list all the functions, a partial interface definition can't work right. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ole32: Fix some memory leaks
by Alexandre Julliard 01 Oct '07

01 Oct '07

Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > diff --git a/dlls/ole32/compositemoniker.c b/dlls/ole32/compositemoniker.c > index c49e9b8..88f141e 100644 > --- a/dlls/ole32/compositemoniker.c > +++ b/dlls/ole32/compositemoniker.c > @@ -1817,8 +1817,10 @@ CompositeMonikerImpl_Construct(IMoniker* > This->tabSize+=BLOCK_TAB_SIZE; > This->tabMoniker=HeapReAlloc(GetProcessHeap(),0,This->tabMoniker,This->tabSize*sizeof(IMoniker)); > > - if (This->tabMoniker==NULL) > + if (This->tabMoniker==NULL) { > + HeapFree(GetProcessHeap(), 0, This); > return E_OUTOFMEMORY; This->tabMoniker is leaked too in that case, it would be good to fix it while you are at it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] winex11.drv: Use ClipCursor to grab/ungrab the pointer.
by Alexandre Julliard 01 Oct '07

01 Oct '07

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > +/*********************************************************************** > + * do_grab_pointer > + * > + * Helper to call grab_pointer from any thread. > + * > + * x11_lock have to be held when calling this function. It will be > + * released upon return. Don't do that, lock/unlock should be done at the same level, it makes it really hard to verify otherwise. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Add tests for DefWindowProc processing the undocumented 0x3Bmessage.
by Dmitry Timoshkov 01 Oct '07

01 Oct '07

"Robert Shearman" <rob(a)codeweavers.com> wrote: > --- > dlls/user32/tests/msg.c | 71 > +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 71 insertions(+), 0 deletions(-) > > Found from observations with Spy++ whilst testing log-off behaviour in > XP. I don't see any point in using this message type over the documented > messages though. http://wiki.winprog.org/wiki/Windows_messages names 0x003b as WM_CLIENTSHUTDOWN. That page also lists some other not documented messages. -- Dmitry.

1 0

Weekly Newsletter
by EA Durbin 01 Oct '07

01 Oct '07

Who maintains the weekly newsletter? I noticed it hasn't been updated since May. _________________________________________________________________ Invite your mail contacts to join your friends list with Windows Live Spaces. It's easy! http://spaces.live.com/spacesapi.aspx?wx_action=create&wx_url=/friends.aspx…

2 1

Wine application compatibility
by Roderick Colenbrander 30 Sep '07

30 Sep '07

Hi, Every Wine release more and more programs start to work on Wine. A serious problem is that not all programs can work out of the box. Some games for instance need the windows version to be set to Windows 95 or it will crash. Other games like Medal of Honour need their OpenGL extension string trimmed to get it to work on cards which support a lot of OpenGL extensions. There are dozens of more examples like that. Microsoft is having similar troubles and since Windows 2000 they provide appcompat stuff for windows (in WinXP/Vista it is a default feature). It basically works on a database which is used somehow at program startup and which then applies 'fixes' like 'setting the windows version', patching function calls and more. See for instance http://technet.microsoft.com/en-us/library/bb457032.aspx for more info and pay attention to http://technet.microsoft.com/en-us/library/bb457032.apcpxp06_big(en-us,tech… which shows a part of the list and the scope of it. I think we have reached a point in Wine where we might need something similar :( Our compatibility seems to be bigger than XP/Vista so we might not need much. Perhaps we need to maintain some file which applies really needed fixups. It should be merged into the registry using wineprefixcreate and the database can be checked using winecfg. It would use normal AppDefaults. What do you guys think about such a thing? I don't like it at all but I fear it is really needed. If we would add such I'm not sure if we are allowed to dump microsoft their database, looking at it might be something differently. It might be a good topic for WineConf. Regards, Roderick Colenbrander -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser

4 6

[PATCH] Fix Ugly borders around undecorated windows in Gnome
by Matthew D'Asaro 30 Sep '07

30 Sep '07

This is my first attempt at submitting a patch to WINE, so please excuse me if I have broken any conventions or am going through the wrong channel. As it currently stands, wine is setting the 'MWM_DECOR_BORDER' hint on managed but undecorated windows, such as iTunes, or Winamp. This does not cause problems in KDE, but in Gnome it puts a gray border around such windows. Not setting this hint does not seem to cause problems in KDE and fixes the problem in Gnome. A patch to do just that is attached. Comments? -Matthew D'Asaro

1 0

New winetricks: 'volnum' command to work around bug 5351, new gecko
by Dan Kegel 30 Sep '07

30 Sep '07

Another month, another winetricks. This updates the gecko installed by winetricks to 0.1.0, and adds a 'volnum' verb to let you run installers that complain "Unable to find a volume for file extraction." And it has a few other cleanups. As usual, it's at http://kegel.com/wine/winetricks - Dan revision 1.33 date: 2007/09/30 02:47:13; author: dank; state: Exp; lines: +18 -0 Added volnum verb to work around bug 5351 ---------------------------- revision 1.32 date: 2007/09/30 02:30:33; author: dank; state: Exp; lines: +15 -12 Minor janitorial cleanup ---------------------------- revision 1.31 date: 2007/09/30 02:26:40; author: dank; state: Exp; lines: +11 -9 Detlef Riekenberg reported that gecko was using old version. This fixes it. ---------------------------- revision 1.30 date: 2007/09/30 00:03:03; author: dank; state: Exp; lines: +14 -0 Sanity checking by Lei ---------------------------- revision 1.29 date: 2007/09/30 00:00:55; author: dank; state: Exp; lines: +1 -1 Fix typo introduced by last change ---------------------------- revision 1.28 date: 2007/09/29 23:21:33; author: dank; state: Exp; lines: +19 -38 Localized paths cleanup from Detlef Riekenberg -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 4

Re: winex11.drv: possible fix for thick border around utility window in DatePicker
by Dmitry Timoshkov 30 Sep '07

30 Sep '07

<a_villacis(a)palosanto.com> wrote: > It seems that, when presented with a combination of WS_POPUP and WS_BORDER > without any extended style, the window is supposed to be shown with a thin > border (a 1px border in Windows). I still have not found a window style that > makes a X window show a thin border, and the nearest thing in looks is no > border at all. Please comment on this patch, as I don't think it is exactly > sane. > > Changelog: > * Deactivate WS_BORDER when present with WS_POPUP > - else if (style & WS_BORDER) mwm_hints.decorations |= MWM_DECOR_BORDER; > + else if ((style & WS_BORDER) && !(style & WS_POPUP)) mwm_hints.decorations |= MWM_DECOR_BORDER; This looks like a bug in Metacity, I don't see why it adds "(disabled) decorations" when only asked for MWM_DECOR_BORDER. On the other hand we already check for WS_CHILD|WS_POPUP and don't add MWM_DECOR_BORDER if any of that styles present, so perhaps your change is in that direction, and should be made to also check for both WS_CHILD|WS_POPUP. Probably it's also worth to file a bug to metacity bugzilla. -- Dmitry.

1 0

The Spouse Test
by Dan Kegel 30 Sep '07

30 Sep '07

When will Wine be good enough for the average person to use? One test is, "Is it good enough to let your spouse migrate to Linux from Windows?". My wife's must-have app list is roughly Microsoft Office '97 Adobe Photoshop Elements 1 Ulead PhotoImpact Macromedia Dreamweaver 8 Musicmatch Jukebox 8 FamilyTreeMaker 2006 And you know what? All of those basically work except for Photoshop Elements. They need some cosmetic work, and a native DLL or two, and probably a few obscure bugfixes, but I think that's it. (I didn't test Office '97, since I expect she'll be using Crossover for that, as Codeweavers tests that app pretty well.) It's possible that by this time next year Wine will pass this test for me. - Dan

4 3

Broken patches since 0.9.45 (problem with missing binary files)
by Victor 30 Sep '07

30 Sep '07

Hello! It looks like last two patches - wine-0.9.45.diff.bz2 and wine-0.9.46-diff.bz2 are broken. It is not possible to compile wine-0.9.45 (if sources were created by patching 0.9.44 with wine-0.9.45.diff.bz2) due to missing notepad.ico :) : --- make[2]: Leaving directory `/home/erv/distr/wine/wine-0.9.45/programs/net' make[2]: Entering directory `/home/erv/distr/wine/wine-0.9.45/programs/notepad' ../../tools/makedep -C. -S../.. -T../.. -I../../include/msvcrt dialog.c main.c rsrc.rc notepad.ico: No such file or directory notepad.ico was first included from rsrc.rc:47 make[2]: [Makefile] Error 1 (ignored) ../../tools/makedep -C. -S../.. -T../.. -I../../include/msvcrt dialog.c main.c rsrc.rc notepad.ico: No such file or directory notepad.ico was first included from rsrc.rc:47 make[2]: *** [depend] Error 1 make[2]: Leaving directory `/home/erv/distr/wine/wine-0.9.45/programs/notepad' make[1]: *** [notepad/__depend__] Error 2 make[1]: Leaving directory `/home/erv/distr/wine/wine-0.9.45/programs' make: *** [programs/__depend__] Error 2 Compilation failed, aborting install. --- and it isn't possible to compile wine-0.9.46 (created by patching complete 0.9.45 sources with wine-0.9.46.diff.bz2) due to missing c1.bmp in cards.dll: --- make[2]: Leaving directory `/home/erv/distr/wine/wine-0.9.46/dlls/capi2032' make[2]: Entering directory `/home/erv/distr/wine/wine-0.9.46/dlls/cards' ../../tools/makedep -C. -S../.. -T../.. cards.c cards.rc c1.bmp: No such file or directory c1.bmp was first included from cards.rc:23 make[2]: [Makefile] Error 1 (ignored) ../../tools/makedep -C. -S../.. -T../.. cards.c cards.rc c1.bmp: No such file or directory c1.bmp was first included from cards.rc:23 make[2]: *** [depend] Error 1 make[2]: Leaving directory `/home/erv/distr/wine/wine-0.9.46/dlls/cards' make[1]: *** [cards/__depend__] Error 2 make[1]: Leaving directory `/home/erv/distr/wine/wine-0.9.46/dlls' make: *** [dlls/__depend__] Error 2 Compilation failed, aborting install. --- And here is a script I've been using to unpack patches (it should be placed in dir containing wine-0.9.30.tar.bz2 and patches (0.9.31, 0.9.32, etc) in *.diff.bz2 format : --- #!/bin/sh echo unpacking wine BUILD=30 BASE=$BUILD WINE='wine-0.9' tar -xvvjf $WINE.$BUILD.tar.bz2 && cd $WINE BUILD=$(($BUILD+1)) cd "$WINE.$BASE" while [ -f ../$WINE.$BUILD.diff.bz2 ]; do echo $WINE.$BUILD bzcat ../$WINE.$BUILD.diff.bz2|patch -p1 && BUILD=$(($BUILD+1)) done cd .. mv $WINE.$BASE $WINE.$(($BUILD-1)) --- Can someone fix this problem? (It looks like problem is related to binary files) It would be great if both patches were fixed and re-uploaded. Thanks. -- Victor Eremin (ErV2005(a)rambler.ru)

2 2

Re: version resource for ole2nls.dll
by Dmitry Timoshkov 29 Sep '07

29 Sep '07

"Stefan Leichter" <Stefan.Leichter(a)camline.com> wrote: > Ok, looks like i picked a bad example from the wine tree. > +#define WINE_FILEVERSION 2,1,3050,1 > #define WINE_FILEVERSION_STR "2.10.3050.1" Shouldn't it be 2,10,3050,1 ? Also, could you please also fix the place(s) which you took as an example? -- Dmitry.

1 0

Solidworks Update
by Stephan Rose 29 Sep '07

29 Sep '07

I tested Solidworks with 0.9.46 today and fonts seem to be ok now. No more screwed up texts like in the previous versions. So that's a definite improvement. =) Everything else seems to have remained unchanged though. Stephan

1 0

Re: Revert "mshtml: Return wine: URI for protocols handled by MSHTML."
by Jacek Caban 29 Sep '07

29 Sep '07

Vitaliy Margolen wrote: > I do not know what author wanted to archive here. But what he did > archive is broken Wine and all other programs that use their own > "protocol:". > > This reverts commit 718b771f2a57d0c762d24c6ef62f070eb3647e8a. > > mshtml: Revert commit that broke steam and most other apps. This patch fixed some apps that use pluggable protocols and reverting it is a step backward. I've sent a correct fix. Thanks, Jacek

2 1

DInput mouse - where to go from here?
by Vitaliy Margolen 28 Sep '07

28 Sep '07

As many of you know, Wine have number of serious problems when it comes down to games when using mouse. In fact big number of games suffer one or more of the following problems: 1. Mouse pointer escapes game window (for windowed programs) or confined to arbitrary rectangle (for full-screen) - bug 6971. 2. Mouse is being constantly re-centered (number of bugs). 3. Mouse lags, moves wrong direction or doesn't move at all (number of bugs). 4. Mouse is not smooth with high graphics/system load. There are lots of reasons for these bugs: a) Wine does not grab pointer (doesn't lock it to one particular window). b) Wine's dinput still doing mouse warping while it should not c) Wine relies on an application to process messages so new input events could be received. d) Wine's x11drv is not fine grained - it has only one lock that everything uses, d3d and wgl included. e) The path from x11drv to dinput for input events is long with big overhead. f) X events come from Wine windows for the current process only not whole screen. g) Motion events Wine receives are absolute not relative. Here is what me and others tried but failed: i) XEvIE - buggy, disabled by default, requires server round trip. ii) XInput - does not allow opening of keyboard or mouse devices. iii) Event Device (EvDev) - works perfectly, solves (a,b,c,d,e,f,g) but it's a client only solution (will not work on remote X, because it will try to open remote mouse, not local). iv) Virtualizing mouse pointer in x11drv - depends on (a) moves (b) from dinput into x11drv while same issues remain. v) Writing new X extension - last I've heard about this, it didn't get anywhere past initial proposals. Anything else I missed? Are there are any better ways to solve these problems? Any other ways at all? As you see there are not much options available to solve mouse problems. However I personally do not want to turn this into another "child opengl saga". We ether solving it now, or putting a big red X on any game that's using dinput mouse, that's not already working. The point I'm trying to make is: can we once put our "right ways of doing things" aside and fix something that never worked before? And fix it _for good_! Yes it's a limited fix it will work only for 99% of users who play games on their PC, and not remotely. Vitaliy Margolen.

8 10

AntiAliasing for Source Based games
by christine.youngson＠clear.net.nz 28 Sep '07

28 Sep '07

Hi everyone, I'm exceptionally new to posting messages on mailing lists (ie its my first time) so please forgive me in advance if I've done something wrong! My question for the wine developers is, why is Anti Aliasing not supported for Source based games? I play Day of Defeat Source everyday, and many wine gamers play steam based source engine games such as DoDs and Counterstrike Source, and its nearly at windows xp level fps wise, but the main nuisance for us is that there is no AA! AA greatly improves the look of games, and it seems that there is an emphasis on making the games look nice by adding functionality such as shaders and glsl, so in this respect, a basic feature of games such as AA should be considered to be made. Also Team Fortress Two is coming out fairly shortly and AA would be a nice feature to implement for when it comes out :) I would consider learning C etc myself to try and get this functionality (I learned Java as part of my degree) up and running, but sadly I probably don't have the skills to contribute. Anyways, keep up the excellent work wine developers, you guys do a tremendous job, but please consider adding this one feature, as it would mean a lot to myself and many many others who play steam based source games etc using wine on Linux! Take care!

4 3

Re: iTunes 7.4.2 doesn't even install for me
by Juan Lang 28 Sep '07

28 Sep '07

Hi Paul, > I saw your bug 9765 but I don't even get that far. The install crashes for me > with something that appears to be connected to a driver: Actually, I see that crash too. I meant to log a bug for it, but never did. Would you mind? (snip) > L"C:\\windows\\System32\\Drivers\\GEARAspiWDM.sys" (native) at 0x460000 > trace:module:process_attach (L"GEARAspiWDM.sys",(nil)) - START > trace:module:MODULE_InitDLL (0x460000 L"GEARAspiWDM.sys",PROCESS_ATTACH,(nil)) - > CALL > trace:seh:raise_exception code=c0000005 flags=0 addr=0x464010 > trace:seh:raise_exception info[0]=00000001 > trace:seh:raise_exception info[1]=00460038 > trace:seh:raise_exception eax=0046137e ebx=7bc90dc8 ecx=0000001c edx=00460000 > esi=7bc87f5b edi=00460038 That address (0x00460038) is suspect. It looks like part of a Unicode string. Something about how this driver is loaded is buggy, I'm guessing ntoskrnl.exe is a bit too stubby for it yet. Nevertheless, iTunes starts for me after this crash, it just warns about the registry entries needed for CD/DVD drives being missing, and I suspect that's due to this driver not being registered correctly. I just ignore that warning. > As your so busy with iTunes these days, I thought I contact you directly. I don't mind, but I'm actually off it now. I've tried to stay up to date this week, but no guarantees now that I'm back in school. --Juan

2 1

re: I need help, please
by Dan Kegel 28 Sep '07

28 Sep '07

David, sorry, Wine's not likely to be able to run Corel Draw X3 without several months worth of work, and nobody's focusing on it at the moment. - Dan

5 4

address space layout
by Tijl Coosemans 28 Sep '07

28 Sep '07

Hi all! I had a user running FreeBSD 6.2, Xorg 7.3, ATI r200 DRI driver report a problem where running Warcraft3 crashed because it ran out of malloc heap space. The error was: Assertion failed: (texObj->DriverData != NULL), function r200BindTexture, file r200_tex.c, line 1098. fixme:ntdll:FILE_GetNtStatus Converting errno 12 to STATUS_UNSUCCESSFUL This error happens inside the r200 driver, errno 12 means ENOMEM. There was a bug report with a patch over at http://bugs.freedesktop.org/show_bug.cgi?id=12184 The patch gets rid of the assertion failure by doing proper error checking, but it doesn't solve the underlying problem of course, causing a NULL pointer dereference in Wine somewhat later: wine: Unhandled page fault on read access to 0x00000058 at address 0x7e99cc84 (thread 0009), starting debugger... This isn't the first time such a problem appears, especially with games, so ultimately a solution has to be found. The problem is that the way Wine wants to setup the address space is really somewhat incompatible with the way FreeBSD mmap and malloc work. FreeBSD mmap allocates from the end of a process data segment upwards towards the stack. Linux mmap allocates from the stack downwards. FreeBSD (<7.x) malloc doesn't fall back to mmap when it runs out of space in the data segment. Linux malloc does (I've been told). Because the wine process loads itself at 0x7bf00000, this means on FreeBSD with mmap going up, both the data segment and all shared objects (like builtin dlls) sit squeezed between that address and 0x80000000 since addresses above 0x80000000 can't be used for builtin dlls. It's about 64Mb which is currently split 50/50 between heap space and shared objects. This works in a lot of cases, but sometimes a 32Mb heap isn't enough like in the example above, where I assume it's been taken up by textures and other graphics data. Linux doesn't have this problem because mmap allocates shared objects from 0x80000000 downwards and can go beyond the address where wine is loaded if necessary. It can allocate extra heap space this way too when needed. Alexandre and I discussed this a couple weeks ago, but didn't really come up with anything. The problem back then (WoW) has since gone away (turned out to be a memory leak somewhere) so everything was left the way it was. Now it has turned up again however with a different program on a different setup, so it's something that really needs to be looked at. It could again be a memory leak in some other project's code, but then that just means the current situation isn't robust enough to deal with that, since it all does work on Linux. It appears that the only solution is to locate wine somewhere after 0x80000000 instead of at 0x7bf00000 and to allow mmap to allocate memory there. Then the data segment size limit can be set to 256Mb or something instead of 32Mb. The problem is then that builtin dlls are mmapped (by the runtime linker) well beyond 0x80000000. Now I'm thinking, would it be possible to load dummy dlls somewhere in the first 2Gb of address space? Through which API calls can a program determine a dll is above 0x80000000 by the way?

2 1

Re: msvcrt: move error condition before memory allocation (found by Smatch) [1/3, resend]
by Alexandre Julliard 28 Sep '07

28 Sep '07

Lionel_Debroux <lionel_debroux(a)yahoo.fr> writes: > _wfullpath leaks some heap memory in an error paths. Found in Michael > Stefaniuc's list of Wine potential bugs detected by Smatch. > Fixed by moving the error treatment before the allocation, since the > error treatment doesn't fire up if there was a memory allocation (due to > size = MAX_PATH; assignment). > > Is there anything wrong with this patch ? Yes, you are using the size before checking if the buffer is NULL (in which case the size is meaningless), and as you said yourself the error treatment isn't used if there was an allocation, so there's no leak to fix here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine gets exposed in Norway :)
by Tomas Zijdemans 28 Sep '07

28 Sep '07

The most visited and respected technology related site in Norway (210 000 unique norwegian hits a week), is now launching a series of articles where they will test 3 games thoroughly in wine each month! Today the first article tested Fahrenheit, Guild Wars: Nightfall and Civilization IV: Warlords. The results where good and focused on what users should do to make them work smoothly. Hope this is an encouragement for Stefan and all the others of you working to get games working :)

2 2

Re: version resource for ole2nls.dll
by Dmitry Timoshkov 28 Sep '07

28 Sep '07

"Stefan Leichter" <Stefan.Leichter(a)camline.com> wrote: > This patch fixes Bug 9747 > > ChangeLog > --------- > added version resource for ole2nls.dll > +#define WINE_FILEVERSION_STR "2.10.3050.1" > +#define WINE_FILEDESCRIPTION_STR "Wine OLE dll" > +#define WINE_FILENAME_STR "OLE2NLS.DLL" > + > +#include "wine/wine_common_ver.rc" Why do you define WINE_FILEVERSION_STR but not WINE_FILEVERSION? That not creates a confusion but could lead to hard debuggable problems with application which test only one of them. -- Dmitry.

1 1

Re: bits[1/3]: Minimal Background Intelligent Transfer Service (bits) implementation
by Alexandre Julliard 27 Sep '07

27 Sep '07

Roy Shea <roy(a)cs.hmc.edu> writes: > Resubmission of a bare bones bits implementation. There is no bits.dll on any Windows version I've checked. Where does this dll come from? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: mpr: Changes comparison of dwScope in WNetOpenEnum function
by Juan Lang 27 Sep '07

27 Sep '07

Hi Konstantin, - providerTable->table[index].dwEnumScopes & dwScope) + providerTable->table[index].dwEnumScopes & WNNC_ENUM_GLOBAL) This change looks correct, but it should be changed in the next block as well: ret = providerTable->table[index].openEnum( dwScope, dwType, dwUsage, lpNet, &handle); It also looks incorrect in _enumerateGlobalPassthroughW: ret = providerTable->table[enumerator->providerIndex]. openEnum(enumerator->dwScope, enumerator->dwType, enumerator->dwUsage, enumerator->lpNet, &enumerator->handle); In fact, all of these usages of dwScope look to confuse the two meanings. (D'oh.) --Juan

2 4

WineD3D surface management cleanup
by Stefan Dösinger 27 Sep '07

27 Sep '07

Hi, This mail is mainly addressed at Henri and Roderick, but I'll send it here to allow others to read it too. These patches contain some cleanups of the d3d surface loading code. It's main aim is to put the code that copies the surface between system memory, texture and drawable into a centralized place, make LockRect simpler and pbo creation and surface memory allocation in one place(surface allocation is not completely there yet). It also makes other parts of the code simpler, avoids playing with the surface flags in other places, and it will allow us to centralize the logic that in the case of fbo offscreen rendering the drawable is the same as the texture(This is also not implemented yet). The patches don't aim at fixing any bugs themselves, and I hardly tested them, so there may be a truckload of regressions. I'm mainly showing them to show the general direction I'm heading into.

4 6

Re: Alexandre Julliard : gdi32: Don' t pass a DC handle to WineEngGetFontUnicodeRanges.
by Robert Shearman 27 Sep '07

27 Sep '07

Alexandre Julliard wrote: > -DWORD WineEngGetFontUnicodeRanges(HDC hdc, LPGLYPHSET glyphset) > +DWORD WineEngGetFontUnicodeRanges(GdiFont *font, LPGLYPHSET glyphset) > { > FIXME("(%p, %p): stub\n", hdc, glyphset); > You forgot to change hdc to font in the FIXME call. -- Rob Shearman

1 0

Re: [PATCH 1/2] [try2] Allow completion object to be attached to an fd object
by Alexandre Julliard 27 Sep '07

27 Sep '07

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > +DECL_HANDLER(set_completion_info) > +{ > + struct fd *fd = get_handle_fd_obj( current->process, req->handle, 0 ); > + > + if (fd) > + { > + if (fd->completion) > + release_object( fd->completion ); > + fd->completion = get_completion_obj( current->process, req->chandle, IO_COMPLETION_MODIFY_STATE ); > + fd->comp_key = req->ckey; > + release_object( fd ); You need to check that the completion object is valid before you start modifying the fd. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi: Fix meaning and use of bidirectionality flags
by Shachar Shemesh 27 Sep '07

27 Sep '07

Maarten Lankhorst wrote: > According to shachar shamesh they have a slightly different meaning. > This should fix it. > First of all, things seem much much better with this patch. I would direct your attention to the fact that, when I run it, I get: > $ programs/notepad/notepad > fixme:bidi:mirror stub: mirroring of characters not yet implemented > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveWeak assert failed: pcls[ich] <= BN > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveNeutrals assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 > fixme:bidi:resolveImplicit assert failed: pcls[ich] < 5 As far as I can tell, an assert should not be a "fixme", but that's something else. Shachar

1 0

Re: [5/5] WineD3D: Add sincos support to arb shaders
by Ivan Gyurdiev 27 Sep '07

27 Sep '07

Aren't most of these 2.0 and 3.0 instructions ? What's the goal of adding them to ARB - you won't be able to implement full 2.0/3.0 support in ARB. I think most of these were left unimplemented on purpose. Ivan

2 3

Total bidi regression
by Shachar Shemesh 27 Sep '07

27 Sep '07

Hi Maarten, It seems that since your last changes to the Bidi implementation, BiDi suffered total regression. At least on my system, no BiDi related text (neither Hebrew nor Arabic) gets reordered, at all. Placing breakpoints suggest that BIDI_Reorder is still getting called, so I can only assume that the problem is somewhere inside it (or in the classification) I haven't traced inside to see where things went wrong, nor do I know whether your work on that matter is done. I just wanted to point out that Wine, at the moment, performs no BiDi at all as far as the user is concerned. Shachar

2 6

I need help, please
by David Outteridge 26 Sep '07

26 Sep '07

Hello All, I am new to Wine. I need to use corelDRAW for non-central reasons that I will explain if asked. I prefer to host on *nix (currently Mandriva 2007.0), but I can host on MS XP as a backup. I bought the latest and greatest corelDRAW X3 (version 13) and now have spent about a week learning Wine and trying to get corelDRAW working. There are some problems with installation, not completely solved yet; but I am hopeful that execution will be successful since earlier versions are reported in the Wine application database as running well. I have reached a point where I am beginning to understand what is going on with the hosting, and, also, I am getting a glimmer of *how* Wine works. But, as everyone knows, Wine needs a lot of study to get any siginificant grasp of *what* is happening, and I am very aware of how little I know. I need help and guidance to go further, otherwise I shall have to revert to MS XP. I should like very much to use Wine, but I am concerned that to get it going, without help, I shall have to resort to hacks that will be of no use to anyone in the long term, or become engulfed in a never-ending sea of detail. So, here I describe what has happened, and I invite anyone to point me in the right direction, etc., for further work. I am a programmer of many years, but I have not used C for a long time, my preference is for another language. I have no knowledge of Windows internals, and not much about using it except at a fairly remote C++ application programming level when I used Visual Dev Studio (name?) in the past. I have downloaded the Wine source, and have learnt how to manipulate trace messages to see what is happening. The first problem, with corelDRAW out of the box, with Wine 0.9.45 from rpm, or with my downloaded/compiled code, is summarized like this: fixme:msi:ACTION_PerformAction unhandled msi action L"InstallIEFullUI" err:msi:ITERATE_Actions Execution halted, action L"_InstallIE" returned 1602 Notice that there is a leading "_" on one of these actions, and that part of the other is FullUI, which seems to relate very well with one of the MS User Interface Levels. Can anyone tell me the significance of the leading "_", in particular, where does it come from? Also any help on how InstallIEFullUI is split up (my assumption) into _InstallIE and FullUI would be helpful. After much stirring around, hacking at everything in sight, what I have done to deal with this error is cut-and-paste ACTION_InstallInitialize code in msi/actions.c, and modify it suitably, to satisfy InstallIEFullUI and _InstallIE. And this gets me past the err:msg above; which may or may not enable me, ultimately, to install corelDRAW. This do-nothing-really is something of a cop-out, of course. I would make the effort to do something useful, rather than simply returning a deceptive value, but there are two reasons for not doing so. One is that I do not know enough about Wine code/structure/policy, etc., and I could see simply producing garbage, albeit working, code through ignorance. The second reason is that, I read on the Wine website, one should not try to install IE. What is more, Wine (from the rpm) puts a copy of iexplore.exe in my .wine directory anyway. So the question here is: what should I do wrt IE and InstallIEFullUI to follow Wine policy? The second problem seems to me to be rather far-reaching; I think I have run into the problem in three different ways, the last occurrence turns out to be the next fatal step for corelDRAW installation. The first run-in: I have run the distribution iexplore, also I have installed three other IEs, using ies4linux. All of these behave in the same way: they come up properly, and the right-click/wineicon menu that closes the application, moves it to different desktops, etc., also works, so exiting the application is done properly, too. My guess is that this is all done by the window manager, however. The problem is that IE displays no toolbar, so it is quite useless as a browser; it is, indeed, a software boat-anchor. The second run-in: When I ran winecfg, irfanview, regedit, etc.. under the rpm distribution they worked well enough, although the font used was, well, horrible, and almost unreadable. When I moved to the source version of Wine, the apps worked somewhat like iexplore above, except that the menus were available, but contained MangleFont - totally unreadable, with lots of Xs in the text. I posted to comp.emulators.ms-windows.wine and some kind sole suggested loading the MS core fonts, which I had never heard of; but, bingo!, not only did this - utterly magically - solve the problem, but the font(s) used is nice and readable. The third run-in: The corelDRAW installation popups (dialogs?) do not display well, in particular they appear not to refresh when appropriate. The fatal part comes with the license agreement box, where, in addition to most of the popup content not displaying (mouse intervention brings up *some* things), the "Next" button used to continue the installation does not show, nor is it present in the popup. Curiously, the "Cancel" button, right next to it, does show - after its, blank, location is clicked on. I know where the Next button is because I cheated and ran the corelDRAW CD on the XP box, where it works, of course. Not being able to transmit Next to the popup is a stalemate position. But here is some trace output from the same time, you will need to imagine the trace positions in the code. Necessarily, as above, I clicked the "Cancel" button toward the end of this trace fragment. trace:dajo:ITERATE_Actions POS 61 L"LicenseAgreement" trace:dajo:ACTION_PerformUIAction POS 21 0 0 trace:dajo:ACTION_HandleStandardAction POS 31 0 1 trace:dajo:ACTION_HandleStandardAction UNHANDLED STD ACTION L"LicenseAgreement" trace:dajo:ACTION_PerformUIAction POS 22 0 trace:dajo:ACTION_HandleCustomAction UNHANDLED CTM ACTION L"LicenseAgreement" trace:dajo:ACTION_PerformUIAction POS 23 0 trace:dajo:ACTION_DialogBox POS 81 L"LicenseAgreement" trace:dajo:event_do_dialog POS 91 L"LicenseAgreement" trace:dajo:event_do_dialog POS 92 L"LicenseAgreement" trace:dajo:WineEngCreateFontInstance POS 51 L"System" trace:dajo:WineEngCreateFontInstance POS 52 L"System" trace:dajo:WineEngCreateFontInstance POS 51 L"Tahoma" trace:dajo:WineEngCreateFontInstance POS 52 L"Tahoma" trace:dajo:WineEngCreateFontInstance POS 51 L"ArialMT" fixme:font:WineEngCreateFontInstance Untranslated charset 77 trace:dajo:WineEngCreateFontInstance POS 53 L"ArialMT" trace:dajo:WineEngCreateFontInstance POS 52 L"ArialMT" trace:dajo:WineEngCreateFontInstance POS 51 L"Tahoma" trace:dajo:WineEngCreateFontInstance POS 52 L"Tahoma" trace:dajo:event_do_dialog POS 91 L"CancelSetup" trace:dajo:event_do_dialog POS 92 L"CancelSetup" trace:dajo:ACTION_DialogBox POS 82 L"LicenseAgreement" trace:dajo:ACTION_PerformUIAction POS 24 1 trace:dajo:ACTION_PerformUIAction HANDLED MSI ACTION L"LicenseAgreement" trace:dajo:ACTION_PerformUIAction POS 25 1 err:msi:ITERATE_Actions Execution halted, action L"LicenseAgreement" returned 1602 So, it appears that the untranslated character set 77 (ArialMT) is preventing the corelDRAW popup from displaying properly - that, of course, is a wild guess at the moment. But, in a curious way, it ties in with the other problems with fonts that I have experienced. OK, so I should fix the FIXME. But now I am back to the code/structure/policy problem. Is the solution as simple as hacking up ArialMT to work, or does this need some proper action to solve a more general problem? So this marks the point where I decided to write what you are reading. I need guidance on policy mainly, I think. I should like help on how this error, and its solution, fits in to the larger Wine picture. I hope that I have presented, what is becoming, my dilemma. I *really* want to handled these problems, and, now that I started to find my way around in Wine, maybe do some other things, all with one objective of helping the Wine project. But I have other pressures on me, and I have this uncomfortable feeling of opening ever-widening boxes of worms. I cannot continue to spend days of time without some feeling that the scope of the task is going to contract rather than expand further. In conclusion, I can report that corelDRAW X3 does not install (also see the appDB for confirmation), which is regressive wrt version 11, which is rated as Gold. Some of the reasons are given above. The required OS is either XP or 2000, an attempt to use soemthing else brings up a message stating that. Thanks for reading this. David

1 0

Re: [PATCH] [2/2] winhttp: stub impl of WinHttpGetIEProxyConfigForCurrentUse
by Peter Oberndorfer 26 Sep '07

26 Sep '07

On Wednesday 26 September 2007, Peter Oberndorfer wrote: > --- > dlls/winhttp/main.c | 25 +++++++++++++++++++++++++ > dlls/winhttp/winhttp.spec | 2 +- > 2 files changed, 26 insertions(+), 1 deletions(-) > There is a 'r' missing in the patch title. it should be: winhttp: stub impl of WinHttpGetIEProxyConfigForCurrentUser Greetings Peter

1 0

Re: [PATCH 2/2] configure: Build wine-kthread on FreeBSD.
by Tijl Coosemans 26 Sep '07

26 Sep '07

On Wednesday 26 September 2007 19:24:24 Charlie wrote: This is me. I guess I called git-format-patch from a terminal where I was root.

1 0

Re: [PATCH 1/2] loader: Reduce data segment size in wine-pthread/kthread on FreeBSD.
by Tijl Coosemans 26 Sep '07

26 Sep '07

On Wednesday 26 September 2007 19:17:44 Charlie wrote: This is me. I guess I called git-format-patch from a terminal where I was root.

1 0

Re: [5/5] WineD3D: Add sincos support to arb shaders
by H. Verbeet 26 Sep '07

26 Sep '07

On 26/09/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* dst.w = src[0].w * 1 / (src.x^2 + src.y^2 + src.z^2)^(1/2) according to msdn*/ That comment looks a bit out of place for sincos. Copy-paste from nrm?

1 0

Re: RICHED20: EM_SETCHARFORMAT must return 0, not assert, on invalid struct size (try 2)
by Alexandre Julliard 26 Sep '07

26 Sep '07

a_villacis(a)palosanto.com writes: > I considered doing this at first, but ME_ToCF2W is used in three other > places beside handling EM_SETCHARFORMAT (all in style.c), and those places > might get a null-pointer exception instead of an assert if something went > wrong. A null-pointer exception serves the same purpose as an assert, and they both result in a debugger backtrace, so there's no reason to add more asserts here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Cannot compile wine due to recent changes
by Kirill K. Smirnov 26 Sep '07

26 Sep '07

Hi, I got the following error message during compile fresh git-current wine: gcc -c -I../../../dlls/winex11.drv -I. -I../../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o x11drv_main.o ../../../dlls/winex11.drv/x11drv_main.c In file included from ../../../dlls/winex11.drv/x11drv_main.c:52: ../../../dlls/winex11.drv/xcomposite.h:40: error: `XCompositeGetOverlayWindow' undeclared here (not in a function) ../../../dlls/winex11.drv/xcomposite.h:40: warning: type defaults to `int' in declaration of `pXCompositeGetOverlayWindow' ../../../dlls/winex11.drv/xcomposite.h:41: error: `XCompositeReleaseOverlayWindow' undeclared here (not in a function) ../../../dlls/winex11.drv/xcomposite.h:41: warning: type defaults to `int' in declaration of `pXCompositeReleaseOverlayWindow' ../../../dlls/winex11.drv/x11drv_main.c:389: warning: type defaults to `int' in declaration of `pXCompositeGetOverlayWindow' ../../../dlls/winex11.drv/x11drv_main.c:390: warning: type defaults to `int' in declaration of `pXCompositeReleaseOverlayWindow' make[2]: *** [x11drv_main.o] Ошибка 1 make[2]: Leaving directory `/home/lich/wine/wine/build/dlls/winex11.drv' make[1]: *** [winex11.drv] Ошибка 2 make[1]: Leaving directory `/home/lich/wine/wine/build/dlls' make: *** [dlls] Ошибка 2 X is Xorg 6.9.0 -- Kirill

2 1

Re: services.exe[2/8]: load services list from registry
by Alexandre Julliard 26 Sep '07

26 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > + buf = HeapAlloc(GetProcessHeap(), 0, size + 4); > + if ((err = RegQueryValueExW(hKey, szValue, 0, &type, (LPBYTE)buf, &size)) != 0) > + goto failed; > + buf[size/2] = 0; > + buf[size/2 + 1] = 0; Please use sizeof(WCHAR) instead of hardcoding values like 2 and 4. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/6] Make ntdll I/O function to generate completion events
by Alexandre Julliard 26 Sep '07

26 Sep '07

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > This has to be done in client because server does not > know about actual operation details (e.g. io.Information), > and moreover some operations does not use server at all. The needed information can be sent to the server along with the normal async status. We shouldn't add yet another server call for this, async I/O already requires too many server roundtrips. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/6] Allow completion object to be attached to a fd object
by Alexandre Julliard 26 Sep '07

26 Sep '07

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > +struct compl_map *create_completion_map( obj_handle_t handle, unsigned long completion_key ) > +{ > + struct completion *completion; > + struct compl_map *map; > + > + if ((completion = get_completion_obj( current->process, handle, IO_COMPLETION_MODIFY_STATE )) == NULL) > + return NULL; > + if ((map = mem_alloc( sizeof(*map) )) == NULL) > + { > + release_object( completion ); > + return NULL; > + } > + map->completion = completion; > + map->completion_key = completion_key; > + return map; > +} There doesn't seem to be a need for a separate compl_map type here, you could just as well store the completion object in the fd structure directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: services.exe/advapi32[5/8]: move QueryServiceConfig to services.exe
by Robert Shearman 26 Sep '07

26 Sep '07

Mikolaj Zalewski wrote: > My QueryServiceConfig is not compatible with Windows one - I haven't > tried hard but I couldn't tune the parameters to connect with Windows > services.exe. So I'm not trying to store the structure in the on the > server side buffer but pass it all through the RPC and put in into the > buffer in advapi32. As I understand in near future Wine will not be a > member of Windows domains so on-the-wire compatibility is not very > important. > You don't need to be a member of a domain to use remote interfaces like the one for services or the one for the registry. On-the-wire compatibility will be important once we get remote named pipe support, but getting the right architecture is the goal at the moment, and your patches are a step towards that. I believe that the QUERY_SERVICE_CONFIGW parameter should be a byte_count one, but this is not implemented yet, both in the RPC runtime and in widl. -- Rob Shearman

1 0

Re: RICHED20: EM_SETCHARFORMAT must return 0, not assert, on invalid struct size
by Alexandre Julliard 26 Sep '07

26 Sep '07

a_villacis(a)palosanto.com writes: > Changelog: > * EM_SETCHARFORMAT must not assert on invalid structure size. Instead, it > should just fail and return 0. It would be better to do that in ME_ToCF2W since it already has to check the size, simply make it return NULL on error or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: pdh: add tests for XP variant of api call
by Hans Leidekker 26 Sep '07

26 Sep '07

On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > This patch adds the variations to the api that XP implements. My > assumption is that these changes will, mostly, be reflected in 2003 and > Vista. I can't check them so if someone could give them a run and let > know, that would be fine. I will get on with adding the variations to pdh.c All tests succeed here on 2003 without your patch. Even if APIs return different values on different versions of Windows we should not add version checks. Instead we should accept all possible return values or remove the test altogether when it's clear that you cannot depend on specific return values. -Hans

2 5

Recent BiDi changes
by Shachar Shemesh 26 Sep '07

26 Sep '07

Hi Maarten, Can you, please, explain the advantage of creating our own implementation of the BiDi algorithm over using existing implementations? I know ICU sucks (especially as far as linkage is concerned), but there are other implementations, major among which is fribidi, which are free, are C based, and have a compatible license. Is there any need to Wine to be aware of the inside working of the algorithm? Also, so long as you are picking up the BiDi glove I dropped oh so many years ago, it seems to me that the proper place to implement BiDi would be in unscribe, where it is for Windows. The GDI implementation Wine has is a hack that reached it's useful end the moment you realize that DrawText needs its own implementation, independent of ExtTextOut (mostly due to line breaking code). Thanks, Shachar

3 6

Re: shell32[1/2]: shlview: make the shell view control Unicode (fixesbuf #9767)
by Dmitry Timoshkov 26 Sep '07

26 Sep '07

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote: > When the control class is Unicode the listview will be sending > LVN_GETDISPINFOW instead of LVN_GETDISPINFOA and filenames with > charactes outside of the ACP will display properly. > I'm changing the type of a define from the include/ directory but > that's a define not present in the Windows SDK. If that define doesn't present in SDK it shouldn't be in Wine either. > --- a/include/shlobj.h > +++ b/include/shlobj.h > @@ -149,7 +149,7 @@ typedef struct > */ > > typedef GUID SHELLVIEWID; > -#define SV_CLASS_NAME ("SHELLDLL_DefView") > +#define SV_CLASS_NAME ((const WCHAR[]){'S','H','E','L','L','D','L','L','_','D','e','f','V','i','e','w',0}) This construct is not portable. Please move this to appropriate source file, and use 'static const WCHAR ...' syntax. -- Dmitry.

1 0

Re: comctl32: remove unneeded todo_wine, because test pass
by James Hawkins 26 Sep '07

26 Sep '07

On 9/25/07, Christian Gmeiner <christian.gmeiner(a)gmail.com> wrote: > I am running make test an a fresh git fetch; git rebase origin and am > getting this: > > ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p > comctl32_test.exe.so monthcal.c && touch monthcal.ok > err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp=00000000 lp=00000000 > err:monthcal:MONTHCAL_WindowProc unknown msg 2005 wp=00000001 lp=00000000 > err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp=00000000 lp=00000000 > err:monthcal:MONTHCAL_WindowProc unknown msg 2005 wp=00000000 lp=00000000 > err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp=00000000 lp=00000000 > err:monthcal:MONTHCAL_WindowProc unknown msg 2005 wp=00000001 lp=00000000 > monthcal.c:818: Test succeeded inside todo block: Expected 131073, got 131073 > make[2]: *** [monthcal.ok] Fehler 1 > > This patch removes the todo_wine.. as it seems to work now. If this > patch gets not accepted, please tell me why. > Becuase it doesn't pass for other people, particularly Julliard; otherwise, it would have been fixed by now. -- James Hawkins

5 4

Wine GSoC 2007 project membership
by Alexander Nicolaysen Sørnes 25 Sep '07

25 Sep '07

Hello all, I received a passing evaluation in this year's GSoC, but I was not added to the Wine project hosting for 2007, does anyone here have the power to add me? Alexander N. Sørnes

2 3

Re: user32: Make message test pass cleanly under XP SP2
by Alexandre Julliard 25 Sep '07

25 Sep '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > /* posted message */ > PostMessageA( hwnd, WM_CHAR, dbch[0], 0 ); > + msg.message = 0xdeadbeef; > ok( !PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "got message %x\n", msg.message ); > PostMessageA( hwnd, WM_CHAR, dbch[1], 0 ); > ok( PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "no message\n" ); > ok( msg.message == WM_CHAR, "unexpected message %x\n", msg.message ); > ok( msg.wParam == wch, "bad wparam %lx/%x\n", msg.wParam, wch ); > + msg.message = 0xdeadbeef; > ok( !PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "got message %x\n", msg.message ); > > /* posted thread message */ > PostThreadMessageA( GetCurrentThreadId(), WM_CHAR, dbch[0], 0 ); > + msg.message = 0xdeadbeef; > ok( !PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "got message %x\n", msg.message ); > PostMessageA( hwnd, WM_CHAR, dbch[1], 0 ); > ok( PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "no message\n" ); > ok( msg.message == WM_CHAR, "unexpected message %x\n", msg.message ); > ok( msg.wParam == wch, "bad wparam %lx/%x\n", msg.wParam, wch ); > + msg.message = 0xdeadbeef; > ok( !PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "got message %x\n", msg.message ); I'm not sure I see the point of that change, since the message is not tested when PeekMessage fails. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [5/5] winex11: Use an offscreen redirected window for child OpenGL rendering
by Alexandre Julliard 25 Sep '07

25 Sep '07

Chris Robinson <chris.kcat(a)gmail.com> writes: > + if(w > 0 && h > 0) { > + XFlush(gdi_display); > + XCopyArea(gdi_display, physDev->gl_drawable, physDev->drawable, > + physDev->gc, 0, 0, w, h, physDev->dc_rect.left, > + physDev->dc_rect.top); Why do you need an XFlush here? > + if(data->whole_window && vis->visualid == XVisualIDFromVisual(visual)) > + { > + TRACE("Whole window available and visual match, rendering onscreen\n"); > + goto done; > + } > + > + if(!composite_gl) > + goto done; There's no sense in having a config option for this since the alternative doesn't work anyway, particularly since you removed the scissor support. > + data->gl_drawable = XCreateWindow(gdi_display, root_window, -w, 0, w, h, > + 0, vis->depth, InputOutput, > + vis->visual, > + CWColormap | CWOverrideRedirect, > + &attrib); The window needs to be created on the thread display, and as a child of the main window. > +static void update_gl_drawable(struct x11drv_win_data *data) > +{ > + unsigned int border, depth; > + int x, y, w, h; > + Window root_win; > + > + if(!data->gl_drawable) > + return; > + > + wine_tsx11_lock(); > + XGetGeometry(gdi_display, data->gl_drawable, &root_win, &x, &y, > + (unsigned int*)&w, (unsigned int*)&h, &border, &depth); You must not use XGetGeometry, this incurs a server round-trip. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: user32: Make message test pass cleanly under XP SP2
by Anatoly Lyutin 25 Sep '07

25 Sep '07

Dmitry Timoshkov wrote: > Hello, > > Changelog: > user32: Make message test pass cleanly under XP SP2. > > --- > dlls/user32/tests/msg.c | 142 +++++++++++++++++++++++++++++++++------------- > 1 files changed, 102 insertions(+), 40 deletions(-) > > > > @@ -224,51 +226,53 @@ static const struct message WmSwitchChild[] = { > /* Switch MDI child */ > { WM_MDIACTIVATE, sent },/* in the MDI client */ > { WM_WINDOWPOSCHANGING, sent|wparam,SWP_NOSIZE|SWP_NOMOVE },/* in the 1st MDI child */ > + { EVENT_OBJECT_REORDER, winevent_hook|wparam|lparam, OBJID_CLIENT, 0 }, > { WM_CHILDACTIVATE, sent },/* in the 1st MDI child */ > /* Deactivate 2nd MDI child */ > - { WM_NCACTIVATE, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_MDIACTIVATE, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_CREATE, hook }, > + { WM_NCACTIVATE, sent|wparam|defwinproc, 0 }, /* in the 2nd MDI child */ > + { WM_MDIACTIVATE, sent|defwinproc }, /* in the 2nd MDI child */ > + { HCBT_MINMAX, hook|lparam, 0, SW_MAXIMIZE }, > /* Preparing for maximize and maximaze the 1st MDI child */ > - { WM_GETMINMAXINFO, sent|defwinproc|optional },/* in the 1st MDI child */ > - { WM_WINDOWPOSCHANGING, sent|wparam|defwinproc|optional, SWP_FRAMECHANGED|SWP_STATECHANGED },/* in the 1st MDI child */ > - { WM_GETMINMAXINFO, sent|defwinproc|optional },/* in the 1st MDI child */ > - { WM_NCCALCSIZE, sent|wparam|defwinproc|optional, 1 },/* in the 1st MDI child */ > - { WM_CHILDACTIVATE, sent|defwinproc|optional },/* in the 1st MDI child */ > - { WM_WINDOWPOSCHANGED, sent|defwinproc|optional },/* in the 1st MDI child */ > - { WM_MOVE, sent|defwinproc|optional },/* in the 1st MDI child */ > - { WM_SIZE, sent|defwinproc|optional },/* in the 1st MDI child */ > + { WM_GETMINMAXINFO, sent|defwinproc }, /* in the 1st MDI child */ > + { WM_WINDOWPOSCHANGING, sent|wparam|defwinproc, SWP_FRAMECHANGED|SWP_STATECHANGED }, /* in the 1st MDI child */ > + { WM_NCCALCSIZE, sent|wparam|defwinproc, 1 }, /* in the 1st MDI child */ > + { WM_CHILDACTIVATE, sent|defwinproc }, /* in the 1st MDI child */ > + { WM_WINDOWPOSCHANGED, sent|wparam|defwinproc, SWP_FRAMECHANGED|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE|0x8000 }, /* in the 1st MDI child */ > + { WM_SIZE, sent|defwinproc|wparam, SIZE_MAXIMIZED }, /* in the 1st MDI child */ > /* Lock redraw 2nd MDI child */ > - { WM_SETREDRAW, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_WINDOWPOSCHANGING, sent|wparam|defwinproc|optional, SWP_FRAMECHANGED|SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE },/* in the 2nd MDI child */ > - { WM_NCCALCSIZE, sent|wparam|defwinproc|optional, 1 },/* in the 2nd MDI child */ > - { WM_WINDOWPOSCHANGED, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_CREATE, hook }, > + { WM_SETREDRAW, sent|wparam|defwinproc, 0 }, /* in the 2nd MDI child */ > + { HCBT_MINMAX, hook|lparam, 0, SW_NORMALNA }, > /* Restore 2nd MDI child */ > - { WM_WINDOWPOSCHANGING, sent|wparam|defwinproc|optional, SWP_NOACTIVATE|SWP_FRAMECHANGED|SWP_SHOWWINDOW|SWP_STATECHANGED },/* in the 2nd MDI child */ > - { WM_GETMINMAXINFO, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_NCCALCSIZE, sent|wparam|defwinproc|optional, 1 },/* in the 2nd MDI child */ > - { WM_WINDOWPOSCHANGED, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_MOVE, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_SIZE, sent|defwinproc|optional },/* in the 2nd MDI child */ > + { WM_WINDOWPOSCHANGING, sent|wparam|defwinproc, SWP_SHOWWINDOW|SWP_NOACTIVATE|SWP_FRAMECHANGED|0x8000 },/* in the 2nd MDI child */ > + { WM_NCCALCSIZE, sent|wparam|defwinproc, 1 },/* in the 2nd MDI child */ > + { EVENT_OBJECT_SHOW, winevent_hook|wparam|lparam, 0, 0 }, /* in the 2nd MDI child */ > + { WM_WINDOWPOSCHANGED, sent|wparam|defwinproc, SWP_SHOWWINDOW|SWP_NOACTIVATE|SWP_FRAMECHANGED|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE|0x8000 }, /* in the 2nd MDI child */ > + { WM_SIZE, sent|defwinproc|wparam, SIZE_RESTORED }, /* in the 2nd MDI child */ > + { EVENT_OBJECT_LOCATIONCHANGE, winevent_hook|wparam|lparam, 0, 0 }, /* in the 2nd MDI child */ > /* Redraw 2nd MDI child */ > - { WM_SETREDRAW, sent|defwinproc|optional },/* in the 2nd MDI child */ > - { WM_WINDOWPOSCHANGING, sent|wparam, SWP_NOACTIVATE|SWP_NOSIZE|SWP_FRAMECHANGED|SWP_NOMOVE },/* in the MDI frame */ > - { WM_NCCALCSIZE, sent|wparam, 1 },/* in the MDI frame */ > - { WM_WINDOWPOSCHANGED, sent},/* in the MDI frame */ > - { WM_WINDOWPOSCHANGING, sent|wparam|defwinproc|optional, SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE },/* in the 1st MDI child */ > - { WM_NCACTIVATE, sent|wparam|defwinproc|optional, 1 },/* in the 1st MDI child */ > - { WM_SETVISIBLE, hook }, > - { WM_KILLFOCUS, sent|defwinproc|optional }, /* in the 2nd MDI child */ > - { WM_IME_SETCONTEXT, sent|wparam|optional, 0 }, /* in MDI client */ > - { WM_IME_SETCONTEXT, sent|wparam|optional, 1 }, > + { WM_SETREDRAW, sent|wparam|defwinproc, 1 },/* in the 2nd MDI child */ > + /* Redraw MDI frame */ > + { WM_WINDOWPOSCHANGING, sent|wparam, SWP_NOACTIVATE|SWP_FRAMECHANGED|SWP_NOSIZE|SWP_NOMOVE },/* in MDI frame */ > + { WM_NCCALCSIZE, sent|wparam, 1 },/* in MDI frame */ > + { WM_WINDOWPOSCHANGED, sent|wparam, SWP_NOACTIVATE|SWP_FRAMECHANGED|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE}, /* in MDI frame */ > + { EVENT_OBJECT_LOCATIONCHANGE, winevent_hook|wparam|lparam, 0, 0 }, /* in MDI frame */ > + { EVENT_OBJECT_LOCATIONCHANGE, winevent_hook|wparam|lparam, 0, 0 }, /* in the 1st MDI child */ > + { WM_WINDOWPOSCHANGING, sent|wparam|defwinproc, SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE }, /* in the 1st MDI child */ > + { WM_NCACTIVATE, sent|wparam|defwinproc, 1 }, /* in the 1st MDI child */ > + { HCBT_SETFOCUS, hook }, > + { WM_KILLFOCUS, sent|defwinproc }, /* in the 2nd MDI child */ > + { WM_IME_SETCONTEXT, sent|wparam|defwinproc, 0 },/* in the 1st MDI child */ > + { WM_IME_SETCONTEXT, sent|wparam, 1 }, /* in MDI client */ > { EVENT_OBJECT_FOCUS, winevent_hook|wparam|lparam, OBJID_CLIENT, 0 }, > { WM_SETFOCUS, sent },/* in the MDI client */ > - { WM_SETVISIBLE, hook }, > + { HCBT_SETFOCUS, hook }, > { WM_KILLFOCUS, sent },/* in the MDI client */ > - { WM_SETFOCUS, sent|defwinproc|optional },/* in the 1st MDI child */ > - { WM_MDIACTIVATE, sent|defwinproc|optional },/* in the 1st MDI child */ > - { WM_WINDOWPOSCHANGED, sent },/* in the 1st MDI child */ > + { WM_IME_SETCONTEXT, sent|wparam, 0 }, /* in MDI client */ > + { WM_IME_SETCONTEXT, sent|wparam|defwinproc, 1 }, /* in the 1st MDI child */ > + { EVENT_OBJECT_FOCUS, winevent_hook|wparam|lparam, OBJID_CLIENT, 0 }, > + { WM_SETFOCUS, sent|defwinproc }, /* in the 1st MDI child */ > + { WM_MDIACTIVATE, sent|defwinproc },/* in the 1st MDI child */ > + { WM_WINDOWPOSCHANGED, sent|wparam, SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, /* in the 1st MDI child */ > { 0 } > }; > Sorry! It falls in my Windows XP SP2 with: msg.c:3267:expected 0009 - actual 0009 msg.c:3267:expected 0008 - actual 0008 msg.c:3267:expected 0281 - actual 0007 msg.c:3267: Test failed: Child did not switch correctly: the msg 0x0281 was expected, but got msg 0x0007 instead msg.c:3268:end of test for switch maximized MDI children -- Best regards Anatoly Lyutin.

2 2

Re: widl [2/6]: Fix conformant array test failures
by Alexandre Julliard 25 Sep '07

25 Sep '07

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > This patch gets conformant arrays working in the tests. Currently, only > the address of some conformant arrays are being marshalled, and this wasn't > showing up in the tests because some storage was static. This patch fixes > the problem by writing pointers to conformant array types in the format > string. This also requires handling field pointer conformances, and > expression evaluation routines that expect the containing structure of a > conformant array at the top of the stack, rather than the conformant array > itself. With this patch, the tests still pass, but correctly this time. It breaks the ole32 tests: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so moniker.c && touch moniker.ok moniker.c:897: Test failed: IRunningObjectTable_EnumRunning hr=800703e6 wine: Unhandled page fault on read access to 0x00000000 at address 0x60527ff6 (thread 0010), starting debugger... WineDbg starting on pid 000f Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x60527ff6). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:60527ff6 ESP:0033fa90 EBP:0033fe58 EFLAGS:00010206( - 00 - RIP1) EAX:0033fe30 EBX:6054601c ECX:00000000 EDX:00000000 ESI:800703e6 EDI:6053e4ec Stack dump: 0x0033fa90: 00000000 6053e498 800703e6 60542308 0x0033faa0: 0033fe34 00000100 00000000 00000000 0x0033fab0: 60547478 60547474 6053cdc8 0033fe48 0x0033fac0: 0033fe44 0033fe40 0033fe38 0033fe20 0x0033fad0: 6053d190 60542308 0033fe14 6053e720 0x0033fae0: 6053e2dc 60539d74 6053e154 60539de8 Backtrace: =>1 0x60527ff6 func_moniker+0x15f6() [/home/julliard/wine/wine/dlls/ole32/tests/moniker.c:898] in ole32_test (0x0033fe58) 2 0x60538df8 run_test+0x128(name=0x1103ce) [/home/julliard/wine/wine/dlls/ole32/tests/../../../include/wine/test.h:389] in ole32_test (0x0033fea8) 3 0x6053948d main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/ole32/tests/../../../include/wine/test.h:437] in ole32_test (0x0033fed8) 4 0x6053955b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in ole32_test (0x0033ff08) 5 0x7b87446e start_process+0xee(arg=0x0) [/home/julliard/wine/wine/dlls/kernel32/process.c:839] in kernel32 (0x0033ffe8) 6 0x600289a7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x60527ff6 func_moniker+0x15f6 [/home/julliard/wine/wine/dlls/ole32/tests/moniker.c:898] in ole32_test: movl 0x0(%edx),%ecx 898 hr = IEnumMoniker_QueryInterface(spEM1, &IID_IUnknown, (void*) &lpEM1); Wine-dbg> -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wtsapi32: add stub for WTSRegisterSessionNotification
by Louis. Lenders 24 Sep '07

24 Sep '07

Anything wrong with these simple stubs? http://www.winehq.org/pipermail/wine-patches/2007-September/043944.html and http://www.winehq.org/pipermail/wine-patches/2007-September/043945.html ? --------------------------------- Yahoo! Answers - Get better answers from someone who knows. Tryit now.

1 0

Re: mlang: fix memory leaks in error path (found by Smatch).
by Tijl Coosemans 24 Sep '07

24 Sep '07

On Monday 24 September 2007 14:20:51 Lionel_Debroux wrote: > ConvertINetString leaks some heap memory in an error path. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > 2007-09-24 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/mlang/mlang.c: > mlang: fix memory leaks in error path (found by Smatch). > > diff --git a/dlls/mlang/mlang.c b/dlls/mlang/mlang.c > index eb14ad0..c6274c5 100644 > --- a/dlls/mlang/mlang.c > +++ b/dlls/mlang/mlang.c > @@ -635,9 +635,10 @@ HRESULT WINAPI ConvertINetString( > pDstStrW = HeapAlloc(GetProcessHeap(), 0, cDstSizeW * sizeof(WCHAR)); > hr = ConvertINetMultiByteToUnicode(pdwMode, dwSrcEncoding, pSrcStr, pcSrcSize, pDstStrW, &cDstSizeW); > if (hr != S_OK) > - return hr; > + goto cleanup; > > hr = ConvertINetUnicodeToMultiByte(pdwMode, dwDstEncoding, pDstStrW, &cDstSizeW, pDstStr, pcDstSize); > +cleanup: > HeapFree(GetProcessHeap(), 0, pDstStrW); > return hr; > } This is a bikeshed issue really, but I wonder what Wine's policy on gotos like this is. Imo, it's better to add the HeapFree call to the if block and let the compiler work it out.

3 2

Would like to contribute to wine
by Maciej Kowalczyk 24 Sep '07

24 Sep '07

Hi all, I'm looking for subject for my Master's thesis. It might be interesting to do something useful for Wine. On this year's Google SoC I found an interesting application called "Windows Printing subsystem bridge (i.e. use WIN32 drivers to print from wine)". It was accepted but I can't find any information about any progress. I think it is doable because Windows 2000 and later printer drivers are work in user-space. In suse repository I found ddiwrapper package. It does something similar but only for some Canon drivers and wraps to use by CUPS. Or maybe you have other ideas? Best regards, Maciej Kowalczyk

6 8

Re: Does MWM_DECOR_BORDER really cause window to have caption?
by Kirill K. Smirnov 24 Sep '07

24 Sep '07

> > Anyway, what is the purpose of setting MWM_DECOR_BORDER to borderless > > window (style is WS_CLIPSIBLINGS only)? KDE, XFCE, fluxbox work OK > > without it. > > If you mean the following line in > dlls/winex11.drv/window.c,X11DRV_set_wm_hints() > > else if (!(style & (WS_CHILD|WS_POPUP))) mwm_hints.decorations |= > MWM_DECOR_BORDER; > > then you can always send a patch with an explanation why it's needed. Of course, I can send a patch, which just removes this line with some explanations (referring to winamp), but I'm afraid it may break something. Since original patch introduced this code, there is an application which depends on this. But that original patch does not contain any hint, so I ask the list in hope somebody might know the reason. -- Kirill

1 0

Re: mlang: fix memory leaks in error paths (found by Smatch).
by Lionel_Debroux 24 Sep '07

24 Sep '07

Lionel_Debroux wrote: > EnumRfc1766_create leaks some heap memory in two error paths. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > 2007-09-24 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/mlang/mlang.c: > mlang: fix memory leaks in error paths (found by Smatch). > > > > ------------------------------------------------------------------------ > >>From 394f63633148d76fa322b726218e8a824e5a3930 Mon Sep 17 00:00:00 2001 > From: Lionel Debroux <lionel_debroux(a)yahoo.fr> > Date: Mon, 24 Sep 2007 14:12:10 +0200 > Subject: mlang: fix memory leaks in error paths (found by Smatch). > > --- > dlls/mlang/mlang.c | 13 +++++++++++-- > 1 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/dlls/mlang/mlang.c b/dlls/mlang/mlang.c > index b5b8e0d..eb14ad0 100644 > --- a/dlls/mlang/mlang.c > +++ b/dlls/mlang/mlang.c > @@ -1885,7 +1885,11 @@ static HRESULT EnumRfc1766_create(MLang_impl* mlang, LANGID LangId, > data.total = 0; > data.allocated = 32; > data.info = HeapAlloc(GetProcessHeap(), 0, data.allocated * sizeof(RFC1766INFO)); > - if (!data.info) return S_FALSE; > + if (!data.info) > + { > + HeapFree(rfc); > + return S_FALSE; > + } > > TlsSetValue(MLANG_tls_index, &data); > EnumSystemLocalesW(enum_locales_proc, 0/*LOCALE_SUPPORTED*/); > @@ -1893,7 +1897,12 @@ static HRESULT EnumRfc1766_create(MLang_impl* mlang, LANGID LangId, > > TRACE("enumerated %d rfc1766 structures\n", data.total); > > - if (!data.total) return FALSE; > + if (!data.total) > + { > + HeapFree(data.info); > + HeapFree(rfc); > + return FALSE; > + } > > rfc->info = data.info; > rfc->total = data.total; Err, screw that. The two first parameters "GetProcessHeap(), 0, " of the three HeapFree calls are missing... I did not forget to launch a make process to check my modifications were correct, though. What happened was that everything was recompiled, and by the time the compiler complained, I had already sent the mails by mistake... Sorry. Lionel Debroux.

1 0

Re: Does MWM_DECOR_BORDER really cause window to have caption?
by Kirill K. Smirnov 24 Sep '07

24 Sep '07

> "Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > > I'm trying to get winamp playlist window to be painted correctly (bug > > #8300). The problem is: > > 0) wine version is git-current. > > 1) winamp playlist window style is WS_CLIPSIBLINGS > > 2) winex11 driver converts it to MWM_DECOR_BORDER hint. (window.c:599) > > 3) This hint behaviour is WM-dependent: > > a) KDE - caption is painted; > > b) XFCE - ditto; > > c) fluxbox - correct (no caption). > > > > This situation confuses a little. I believe DECOR_BORDER does not add a > > caption to window, but it does under great WM such as KDE. Is this > > behaviour correct? If KDE/XFCE is a culprit, should we add a workaround > > into wine? > > There is a distinct MWM hint to add a caption to a window: MWM_DECOR_TITLE. > If this is proved to be a KDE/XFCE bug it should be reported to an > appropriate bug tracking system. It's better to write pure X11 app to demonstate it, but I am not familiar with it :-( Anyway, what is the purpose of setting MWM_DECOR_BORDER to borderless window (style is WS_CLIPSIBLINGS only)? KDE, XFCE, fluxbox work OK without it. -- Kirill

2 1

Re: pdh: add tests for XP variant of api call
by Hans Leidekker 24 Sep '07

24 Sep '07

On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > This patch adds the variations to the api that XP implements. My > assumption is that these changes will, mostly, be reflected in 2003 and > Vista. I can't check them so if someone could give them a run and let > know, that would be fine. I will get on with adding the variations to pdh.c To prevent you doing any duplicate work, I have implementations of PdhCalculateCounterFromRawValue, PdhCollectQueryDataEx and PdhValidatePath{,Ex} in my tree, along with a range of tests. -Hans

2 1

Does MWM_DECOR_BORDER really cause window to have caption?
by Kirill K. Smirnov 24 Sep '07

24 Sep '07

Hi, I'm trying to get winamp playlist window to be painted correctly (bug #8300). The problem is: 0) wine version is git-current. 1) winamp playlist window style is WS_CLIPSIBLINGS 2) winex11 driver converts it to MWM_DECOR_BORDER hint. (window.c:599) 3) This hint behaviour is WM-dependent: a) KDE - caption is painted; b) XFCE - ditto; c) fluxbox - correct (no caption). This situation confuses a little. I believe DECOR_BORDER does not add a caption to window, but it does under great WM such as KDE. Is this behaviour correct? If KDE/XFCE is a culprit, should we add a workaround into wine? Thanks for attention -- Kirill

2 1

Is ICU no longer a dependency of Wine?
by Scott Ritchie 24 Sep '07

24 Sep '07

I stumbled across this patch while browsing recent commits: http://www.winehq.org/pipermail/wine-cvs/2007-September/036309.html Am I correct to say that we no longer need libicu when compiling Wine? By the way, it would be nice if someone shot off an email to wine-devel whenever the build dependencies change (either removing or adding a lib) -- it makes it a lot easier on we package maintainers. Thanks, Scott Ritchie

2 1

Re: [2/5] WineD3D: Recompile glsl pixelshaders if the sampler format changes
by Vitaliy Margolen 24 Sep '07

24 Sep '07

Stefan Dösinger wrote: > > ------------------------------------------------------------------------ > > This patch causes noticeable slowdown in Counter Strike Source stress test in the first part of it (rotating panels). Testing in dxlevel 80, 1024x768 fbo, cl_monitors 0. I'm getting ~33 fps in that area before patch and around 7 fps with this patch. Vitaliy.

2 1

strange pixel format
by Jose Osvaldo 24 Sep '07

24 Sep '07

The No-CD crack for "The Sims" calls to "IDirectDrawImpl_CreateSurface" (ddls/ddraw.c) which calls to "IDirectDrawImpl_CreateNewSurface". One of these calls passes a abnormal value for DDPixelFormat causing "PixelFormat_DD2WineD3D" (dlls/utils.c) to return "WINED3DFMT_UNKNOWN" (0). "IDirectDrawImpl_CreateNewSurface" returns immediately causing the program to fail by raising an exception. In this case, forcing the "IDirectDrawImpl_CreateNewSurface" function to continue with other pixel format, even a not defined one, avoids the exception and "The Sims" starts. The abnormal value is this: dwFlags = 0x00000000 dwSize = 32 dwFourCC = 0x00000000 u1 = 0x00000000 u2 = 0x00000000 u3 = 0x00000000 u4 = 0x00000000 u5 = 0x00000000 I do not know what is the expected behaviour in real Windows. The original executable file crashes with other error, but I think that is caused by the anticopy protection.

2 1

Re: [4/5] WGL: Remove GL scissors/viewport override
by Vitaliy Margolen 23 Sep '07

23 Sep '07

Chris Robinson wrote: > > ------------------------------------------------------------------------ > This patch causes crash with virtual desktop. Crash attached. Vitaliy.

2 2

Re: [5/5] winex11: Use an offscreen redirected window for child OpenGL rendering
by Vitaliy Margolen 23 Sep '07

23 Sep '07

Chris Robinson wrote: > This uses XComposite, when available, to render GL to an offscreen window, and > updates the win32 window when glFlush/glFinish/SwapBuffers is called. When > rendering to a top-level window with a matching visual, it renders > directly "onscreen", and setting the registry key > HKCU\Software\Wine\X11 Driver\CompositeGL > to false will disable GL compositing behavior even when XComposite is > available (default is enabled). > > Same here, default should be disabled. Do not introduce more regressions in something already broken by default. And don't punish something that works perfectly without anything extra. Vitaliy.

2 1

Re: [1/5] winex11: Load the XComposite extension when available
by Vitaliy Margolen 23 Sep '07

23 Sep '07

Chris Robinson wrote: > A set of patches to replace the scissors hack with offscreen rendering and > compositing. Step one, look for and load the XComposite extension libs. > > ------------------------------------------------------------------------ > > +int usexcomposite = 1; It should be off by default until users will have enough time to test if it's working properly. Vitaliy.

2 1

Re: shdocvw: Added WebBrowser::FullScreen property implementation.
by Reece Dunn 23 Sep '07

23 Sep '07

On 23/09/2007, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/shdocvw/shdocvw.h | 1 + > dlls/shdocvw/tests/webbrowser.c | 23 +++++++++++++++++++++++ > dlls/shdocvw/webbrowser.c | 15 +++++++++++---- > 3 files changed, 35 insertions(+), 4 deletions(-) > + hres = IWebBrowser2_get_FullScreen(wb, &b); > + ok(hres == S_OK, "get_FullScreen failed: %08x\n", hres); > + ok(b == VARIANT_TRUE, "b=%x\n", b); > + > + hres = IWebBrowser2_put_FullScreen(wb, VARIANT_FALSE); > + ok(hres == S_OK, "put_FullScreen failed: %08x\n", hres); > + > IWebBrowser2_Release(wb); This last call to put_FullScreen is missing a get_FullScreen check. Everything else looks ok. - Reece

1 0

Re: [OT] Freemail Terms Of Use [was: Wine autorunner]
by Reece Dunn 23 Sep '07

23 Sep '07

On 23/09/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am Sonntag, 23. September 2007 01:42:46 schrieb Computer Dude: > _________________________________________________________________ > > Connect to the next generation of MSN Messenger > > http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source= > >wlmailtagline > This is OT regarding this patch, but most people use freemailers, including > hotmail / msn. Some service providers tried to establish some > all-your-copyright-belong-to-us terms of service. Should we take care about > that in any way? Either by making sure that patches aren't sent from such > services, or to make sure that such conditions do not hold up in court? > > I am using gmx myself, and I haven't checked the TOS for changes since years, > and I only gave them a 5 secound look when signing up, so I should start with > checking that myself(I send most patches from my CW address though) Reading the current GoogleMail terms of usage, there is this: "Your Intellectual Property Rights. Google does not claim any ownership in any of the content, including any text, data, information, images, photographs, music, sound, video, or other material, that you upload, transmit or store in your Google Mail account. We will not use any of your content for any purpose except to provide you with the Service." so there is no problem there. Also, the hotmail legal statement has this: "8. Your Materials. You may be able to submit materials for use in connection with the service. Except for material that we license to you, we do not claim ownership of the materials you post or otherwise provide to us related to the service (called a "submission"). However, by posting or otherwise providing your submission, you are granting to the public free permission to: * use, copy, distribute, display, publish and modify your submission, each in connection with the service; * publish your name in connection with your submission; and * grant these permissions to other persons. This section only applies to legally permissible content and only to the extent that use and publishing of the legally permissible content does not breach the law. We will not pay you for your submission. We may refuse to publish, and may remove your submission from the service at any time. For every submission you make, you must have all rights necessary for you to grant the permissions in this section." So you should also be fine there as well, although I do find it interesting that according to this (if I have read it correctly), anything that you send via hotmail is freely usable by the public! - Reece

1 0

Re: Wine autorunner
by Stefan Dösinger 23 Sep '07

23 Sep '07

Am Sonntag, 23. September 2007 01:42:46 schrieb Computer Dude: > Attached is the git patch for a utility to perform simple parsing of > Windows autorun.inf files, and to run the associated programs under WINE. > It will auto-detect the CD drive if not specified on the command line, > auto-detect the mount point, and attempt to mount it if it i not already > mounted. Shouldn't this be implemented in the gnome / kde autorun support? Perhaps in the form of registering a new autorun "mimetype" which tells gnome/kde about autorun.inf files, and how to use them? _________________________________________________________________ > Connect to the next generation of MSN Messenger > http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source= >wlmailtagline This is OT regarding this patch, but most people use freemailers, including hotmail / msn. Some service providers tried to establish some all-your-copyright-belong-to-us terms of service. Should we take care about that in any way? Either by making sure that patches aren't sent from such services, or to make sure that such conditions do not hold up in court? I am using gmx myself, and I haven't checked the TOS for changes since years, and I only gave them a 5 secound look when signing up, so I should start with checking that myself(I send most patches from my CW address though)

2 1

Re: Wine autorunner
by Kai Blin 23 Sep '07

23 Sep '07

On Sunday 23 September 2007 01:42:46 Computer Dude wrote: > Attached is the git patch for a utility to perform simple parsing of > Windows autorun.inf files, and to run the associated programs under WINE. You need to provide your real name for your patch to be considered at all. Wine will not accept anonymous patches. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

WM_CHAR of Ctrl-C, Ctrl-V appear to have no effect in WinXP-SP2 riched20 control
by a_villacis＠palosanto.com 23 Sep '07

23 Sep '07

I am trying to fix a few tests for riched20 that attempt to recover the text from the control with WM_GETTEXT and assume the text will be recovered unchanged. As demostrated in a patch I sent a few minutes ago, this assumption is not true when the text to recover contains unbalanced \r, which are converted to \r\n. However I have a strange problem. On my setup (WinXP-SP2 with cygwin), sending Ctrl-C and Ctrl-V with WM_CHAR appears to have no effect on the riched20 control used for the tests. Therefore the text buffer is not modified and the end text remains unchanged. I want to check whether this tests fails in the same way for anybody else, and if not, to receive suggestions on what might be wrong with my setup.

1 0

Re: wine.inf: add some four keys in Active Setup\Installed Components [resend]
by Robert Shearman 23 Sep '07

23 Sep '07

Mikolaj Zalewski wrote: > +; Some apps wants at least four keys in Installed Components to run correctly > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{a2f95861-06e5-4e58-ab61-94cbdde2ff55},Version,2,"1,0,0,0" > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{c30a0529-fcef-4b19-8e68-9527b54474ac},Version,2,"1,0,0,0" > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{d0b883e4-af5a-45c9-bd44-deb9867c1d94},Version,2,"1,0,0,0" > +HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{e84bb5b4-7fe1-469c-9f24-5a2af3402108},Version,2,"1,0,0,0" You might want to find four real components always present on Windows to add to this key. -- Rob Shearman

2 1

WineD3D patch submission
by Mitchell Wheeler 22 Sep '07

22 Sep '07

Hi all, A week or so ago I tried to get a game working in WINE (Titan Quest), however it seems it really needs a proper DIB engine before it'll be playable. Anyways, in my attempt to get it working I fixed up some issues w/ "IWineD3DDeviceImpl_UpdateSurface.c" in dlls/wined3d, not entirely sure how you guys do things around here so I thought i'd just post my changes to the function in this mailing list and you can do with it what you want. (Note: it actually has a few different methods of doing one thing, enclosed in macro blocks to toggle between them. Technically the first one should work (i think :\) once you guys properly implement surface locking/unlocking, and it's 'simplest', but the last one is the only one that actually works properly (using standard OpenGL calls). You'll probably have to clean up the code to meet your coding standards / etc, maybe remove the custom byte size calculation of compressed images, and some other things - but the functionality is there... i also fixed the existing code that didn't actually do what it was supposed to, heh. Regards, Mitchell Wheeler static HRESULT WINAPI IWineD3DDeviceImpl_UpdateSurface(IWineD3DDevice *iface, IWineD3DSurface *pSourceSurface, CONST RECT* pSourceRect, IWineD3DSurface *pDestinationSurface, CONST POINT* pDestPoint) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *) iface; /** TODO: remove casts to IWineD3DSurfaceImpl * NOTE: move code to surface to accomplish this ****************************************/ IWineD3DSurfaceImpl *pSrcSurface = (IWineD3DSurfaceImpl *)pSourceSurface; IWineD3DSurfaceImpl *pDestSurface = (IWineD3DSurfaceImpl*)pDestinationSurface; int srcWidth, srcHeight; unsigned int srcSurfaceWidth, srcSurfaceHeight, destSurfaceWidth, destSurfaceHeight; WINED3DFORMAT destFormat, srcFormat; int srcLeft, srcTop, destLeft, destTop; WINED3DPOOL srcPool, destPool; int offset = 0; int rowoffset = 0; /* how many bytes to add onto the end of a row to wraparound to the beginning of the next */ glDescriptor *glDescription = NULL, *glSrcDescription = NULL; GLenum dummy; int bpp; UINT destByteSize = 0, srcByteSize = 0; int destPixelByteSize = 0, srcPixelByteSize = 0; CONVERT_TYPES convert = NO_CONVERSION; WINED3DSURFACE_DESC winedesc; TRACE("(%p) : Source (%p) Rect (%p) Destination (%p) Point(%p)\n", This, pSourceSurface, pSourceRect, pDestinationSurface, pDestPoint); memset(&winedesc, 0, sizeof(winedesc)); winedesc.Width = &srcSurfaceWidth; winedesc.Height = &srcSurfaceHeight; winedesc.Pool = &srcPool; winedesc.Format = &srcFormat; winedesc.Size = &srcByteSize; IWineD3DSurface_GetDesc(pSourceSurface, &winedesc); winedesc.Width = &destSurfaceWidth; winedesc.Height = &destSurfaceHeight; winedesc.Pool = &destPool; winedesc.Format = &destFormat; winedesc.Size = &destByteSize; IWineD3DSurface_GetDesc(pDestinationSurface, &winedesc); if(srcPool != WINED3DPOOL_SYSTEMMEM || destPool != WINED3DPOOL_DEFAULT){ WARN("source %p must be SYSTEMMEM and dest %p must be DEFAULT, returning WINED3DERR_INVALIDCALL\n", pSourceSurface, pDestinationSurface); return WINED3DERR_INVALIDCALL; } /* This call loads the opengl surface directly, instead of copying the surface to the * destination's sysmem copy. If surface conversion is needed, use BltFast instead to * copy in sysmem and use regular surface loading. */ d3dfmt_get_conv((IWineD3DSurfaceImpl *) pDestinationSurface, FALSE, TRUE, &dummy, &dummy, &dummy, &convert, &bpp, FALSE); if(convert != NO_CONVERSION) { return IWineD3DSurface_BltFast(pDestinationSurface, pDestPoint ? pDestPoint->x : 0, pDestPoint ? pDestPoint->y : 0, pSourceSurface, (RECT *) pSourceRect, 0); } if (destFormat == WINED3DFMT_UNKNOWN) { TRACE("(%p) : Converting destination surface from WINED3DFMT_UNKNOWN to the source format\n", This); IWineD3DSurface_SetFormat(pDestinationSurface, srcFormat); /* Get the update surface description */ IWineD3DSurface_GetDesc(pDestinationSurface, &winedesc); } ActivateContext(This, This->lastActiveRenderTarget, CTXUSAGE_RESOURCELOAD); ENTER_GL(); if (GL_SUPPORT(ARB_MULTITEXTURE)) { GL_EXTCALL(glActiveTextureARB(GL_TEXTURE0_ARB)); checkGLcall("glActiveTextureARB"); } /* Make sure the surface is loaded and up to date */ IWineD3DSurface_PreLoad(pDestinationSurface); IWineD3DSurface_GetGlDesc(pDestinationSurface, &glDescription); IWineD3DSurface_GetGlDesc(pDestinationSurface, &glSrcDescription); /* this needs to be done in lines if the sourceRect != the sourceWidth */ srcWidth = pSourceRect ? pSourceRect->right - pSourceRect->left : srcSurfaceWidth; srcHeight = pSourceRect ? pSourceRect->bottom - pSourceRect->top : srcSurfaceHeight; srcLeft = pSourceRect ? pSourceRect->left : 0; srcTop = pSourceRect ? pSourceRect->top : 0; destLeft = pDestPoint ? pDestPoint->x : 0; destTop = pDestPoint ? pDestPoint->y : 0; // Calculate the rowOffset / offset values, for copying #define ISDXTFORMAT(format) \ (format == WINED3DFMT_DXT1 || format == WINED3DFMT_DXT2 || format == WINED3DFMT_DXT3 || format == WINED3DFMT_DXT4 || format == WINED3DFMT_DXT5) // Calculating this for our selves because I don't have faith in how surface->bytesPerPixel is calculated... destPixelByteSize = destByteSize / (int)(destSurfaceWidth * destSurfaceHeight); srcPixelByteSize = srcByteSize / (int)(srcSurfaceWidth * srcSurfaceHeight); if(pSourceRect != NULL) { // Irregular surface formats if (destFormat != srcFormat) { FIXME("Can not convert between surface pixel formats..."); // Would require some relatively big code restructuring for rare occurances (that shouldn't even be supported?) return WINED3DERR_INVALIDCALL; } // Uniform surface formats else { if(srcWidth != srcSurfaceWidth || srcLeft > 0) { rowoffset = srcSurfaceWidth * srcPixelByteSize; offset += (srcLeft * srcPixelByteSize); } if(srcTop > 0) offset += srcTop * srcSurfaceWidth * srcPixelByteSize; } } /* Sanity check */ if (IWineD3DSurface_GetData(pSourceSurface) == NULL) { /* need to lock the surface to get the data */ FIXME("Surfaces has no allocated memory, but should be an in memory only surface\n"); } /* TODO: Cube and volume support */ if(rowoffset != 0) { // Compressed texture if (ISDXTFORMAT(destFormat)) { if (GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { #if 0 RECT rect; rect.left = destLeft; rect.top = destTop; rect.right = destLeft + srcWidth; rect.bottom = destTop + srcHeight; // Lock source/destination regions WINED3DLOCKED_RECT destRect, srcRect; printf("Locking surfaces...\n"); if( FAILED(IWineD3DSurface_LockRect(pDestinationSurface, &destRect, &rect, 0)) || FAILED(IWineD3DSurface_LockRect(pSourceSurface, &srcRect, pSourceRect, WINED3DLOCK_READONLY))) { // How should we handle this case? Just returning an invalid call for now... return WINED3DERR_INVALIDCALL; } printf("Surfaces locked, copying contents now... "); if(destFormat == WINED3DFMT_DXT1) { printf("DXT1\n"); //memcpy(destRect.pBits, srcRect.pBits, srcRect.Pitch * (srcHeight / 2)); //memcpy(destRect.pBits, srcRect.pBits, srcRect.Pitch * (srcHeight / 2)); memcpy(destRect.pBits, srcRect.pBits, ceil(srcWidth/4) * ceil(srcHeight/4) * 8); } else { printf("DXT2-5\n"); //memcpy(destRect.pBits, srcRect.pBits, srcRect.Pitch * (srcHeight / 4)); memcpy(destRect.pBits, srcRect.pBits, ceil(srcWidth/4) * ceil(srcHeight/4) * 16); } // Unlock source/destination regions IWineD3DSurface_UnlockRect(pSourceSurface); IWineD3DSurface_UnlockRect(pDestinationSurface); printf("Unlocking surfaces...\n"); #elif 0 // Get pointers to the source/destination buffers unsigned char *dest_data = (unsigned char*)IWineD3DSurface_GetData(pDestinationSurface); const unsigned char *src_data = (unsigned char*)IWineD3DSurface_GetData(pSourceSurface); // Copy subsection of source buffer, in to destination buffer. unsigned char *dest_ptr = dest_data + offset; const unsigned char *src_ptr = src_data + offset; size_t i; for(i = 0; i < srcHeight; ++i) { memcpy(dest_ptr, src_ptr, srcWidth * srcPixelByteSize); dest_ptr += rowoffset; src_ptr += rowoffset; } // Upload destination buffer to server GL_EXTCALL(glCompressedTexImage2DARB(glDescription->target, glDescription->level, glDescription->glFormatInternal, srcWidth, srcHeight, 0, destByteSize, dest_data)); checkGLcall("glCompressedTexImage2DARB"); #elif 1 int blocksize = 16; if(destFormat == WINED3DFMT_DXT1) blocksize = 8; #define max(a, b) (a > b? a : b) srcHeight = max(srcHeight, 4); srcWidth = max(srcWidth, 4); #undef max int data_size = (srcWidth / 4) * (srcHeight / 4) * blocksize; int row_size = data_size / srcHeight; int pixel_size = row_size / srcWidth; int stride = srcSurfaceWidth * pixel_size; unsigned char *temp_buffer = HeapAlloc(GetProcessHeap(), 0, data_size); unsigned char *temp_ptr = temp_buffer; // Debug info //printf(" > BytesTotal: %i | BytesPerPixel: %i | RowSize: %i\n", data_size, pixel_size, row_size); //printf(" > Source: %i -> %i, %i -> %i | Dest: %i, %i\n", srcLeft, srcWidth, srcTop, srcHeight, destLeft, destTop); //printf(" > Offset: %i\n", (int)((row_size * srcTop) + srcLeft * pixel_size)); // Get pointers to the source buffer const unsigned char *src_data = (unsigned char*)IWineD3DSurface_GetData(pSourceSurface); src_data += (stride * srcTop) + srcLeft * pixel_size; size_t i; for(i = 0; i < srcHeight; ++i) { memcpy(temp_ptr, src_data, row_size); temp_ptr += row_size; src_data += stride; } GL_EXTCALL(glCompressedTexSubImage2DARB( glDescription->target, glDescription->level, destLeft, destTop, srcWidth, srcHeight, glDescription->glFormatInternal, data_size, temp_buffer )); //checkGLcall("glCompressedTexSubImage2DARB"); HeapFree(GetProcessHeap(), 0, temp_buffer); #endif } else { FIXME("TODO: Need to update a DXT compressed texture without hardware support\n"); } } // Uncompressed texture else { /* not a whole row so we have to do it a line at a time */ int j; /* hopefully using pointer addtion will be quicker than using a point + j * rowoffset */ const unsigned char* data =((const unsigned char *)IWineD3DSurface_GetData(pSourceSurface)) + offset; for(j = destTop; j < (srcHeight + destTop); ++j) { glTexSubImage2D(glDescription->target ,glDescription->level ,destLeft ,j ,srcWidth ,1 ,glDescription->glFormat ,glDescription->glType ,data /* could be quicker using */ ); data += rowoffset; } } } else { // Compressed texture if (ISDXTFORMAT(destFormat)) { if (GL_SUPPORT(EXT_TEXTURE_COMPRESSION_S3TC)) { int blocksize = 16; if(destFormat == WINED3DFMT_DXT1) blocksize = 8; #define max(a, b) (a > b? a : b) int data_size = (max(srcWidth, 4) / 4) * (max(srcHeight, 4) / 4) * blocksize; #undef max //printf(" -> S = %i | CompressedTexImage2D(?, %i, %i, %i, %i, 0, %i, ?)\n", destByteSize, glDescription->level, glDescription->glFormatInternal, srcWidth, srcHeight, data_size); GL_EXTCALL(glCompressedTexSubImage2DARB(glDescription->target, glDescription->level, destLeft, destTop, srcWidth, srcHeight, glDescription->glFormatInternal, data_size, IWineD3DSurface_GetData(pSourceSurface))); checkGLcall("glCompressedTexImage2DARB"); } else { FIXME("TODO: Need to update a DXT compressed texture without hardware support\n"); } } // Uncompressed Texture else { glTexSubImage2D( glDescription->target, glDescription->level, destLeft, destTop, srcWidth, srcHeight, glDescription->glFormat, glDescription->glType, IWineD3DSurface_GetData(pSourceSurface) ); checkGLcall("glTexSubImage2D"); } } LEAVE_GL(); ((IWineD3DSurfaceImpl *)pDestinationSurface)->Flags &= ~SFLAG_INSYSMEM; ((IWineD3DSurfaceImpl *)pDestinationSurface)->Flags |= SFLAG_INTEXTURE; IWineD3DDeviceImpl_MarkStateDirty(This, STATE_SAMPLER(0)); return WINED3D_OK; }

5 7

Re: Minimal Background Intelligent Transfer Service (bits) implementation
by Michael Stefaniuc 22 Sep '07

22 Sep '07

Hello Roy, Roy wrote: > This patch provides a first skeleton version of bits.dll. thanks for the patch but could you please add also a DLL_WINE_PREATTACH case in DllMain()? That way Wine can prefer to load a native bits DLL (if one is available) until the Wine one gets usable. See for example the mscoree DLL for an example (dlls/mscoree/mscoree_main.c). thanks bye michael > From 95f4728e706861f201fb2b399e7ca5db128e71b3 Mon Sep 17 00:00:00 2001 > From: Roy Shea <roy(a)cs.ucla.edu> > Date: Tue, 18 Sep 2007 14:29:14 -0700 > Subject: Minimal Background Intelligent Transfer Service (bits) implementation > > --- > dlls/bits/Makefile.in | 16 ++++++++++++++++ > dlls/bits/bits.spec | 4 ++++ > dlls/bits/bits_main.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 63 insertions(+), 0 deletions(-) > create mode 100644 dlls/bits/Makefile.in > create mode 100644 dlls/bits/bits.spec > create mode 100644 dlls/bits/bits_main.c > > diff --git a/dlls/bits/Makefile.in b/dlls/bits/Makefile.in > new file mode 100644 > index 0000000..2c9e293 > --- /dev/null > +++ b/dlls/bits/Makefile.in > @@ -0,0 +1,16 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = bits.dll > +IMPORTS = kernel32 > +EXTRALIBS = > + > +C_SRCS = \ > + bits_main.c > + > +#RC_SRCS = version.rc > + > +@MAKE_DLL_RULES@ > + > +@DEPENDENCIES@ # everything below this line is overwritten by make depend > diff --git a/dlls/bits/bits.spec b/dlls/bits/bits.spec > new file mode 100644 > index 0000000..c5fc87a > --- /dev/null > +++ b/dlls/bits/bits.spec > @@ -0,0 +1,4 @@ > +@ stub DllCanUnloadNow > +@ stub DllGetClassObject > +@ stub DllRegisterServer > +@ stub DllUnregisterServer > diff --git a/dlls/bits/bits_main.c b/dlls/bits/bits_main.c > new file mode 100644 > index 0000000..37be887 > --- /dev/null > +++ b/dlls/bits/bits_main.c > @@ -0,0 +1,43 @@ > +/* > + * Implementation of bits.dll > + * Background Intelligent Transfer Service (bits) interface > + * > + * Copyright 2007 Google (Roy Shea) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL( bits ); > + > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("(%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) > + { > + case DLL_PROCESS_ATTACH: > + DisableThreadLibraryCalls(hinstDLL); > + break; > + case DLL_PROCESS_DETACH: > + break; > + } > + > + return TRUE; > +} > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

3 2

Re: services.exe[3/3]: start a local RPC server [fixed]
by Robert Shearman 22 Sep '07

22 Sep '07

Mikolaj Zalewski wrote: > diff --git a/dlls/advapi32/Makefile.in b/dlls/advapi32/Makefile.in > index 8f6fe33..85e9680 100644 > --- a/dlls/advapi32/Makefile.in > +++ b/dlls/advapi32/Makefile.in > @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = advapi32.dll > IMPORTLIB = libadvapi32.$(IMPLIBEXT) > -IMPORTS = kernel32 ntdll > +IMPORTS = rpcrt4 kernel32 ntdll I think you should make rpcrt4 a DELAYIMPORT since it should only be needed for program that use services. Also, you have added one or two header files that don't have a copyright and LGPL statement at the top, which should probably be fixed before the final version (the exception is the one-line files to make the generated files appear in the right place). -- Rob Shearman

1 0

Re: advapi32: add some more rights constants for ConvertStringSecurityDescriptorToSecurityDescriptor
by Hans Leidekker 22 Sep '07

22 Sep '07

On Saturday 22 September 2007 04:19:09 Mikolaj Zalewski wrote: > + > + ADS_RIGHT_DELTE = 0x00010000, You're missing an E there. -Hans

1 0

re: Will ROS and WINE still be steady be synchronized ?
by Dan Kegel 21 Sep '07

21 Sep '07

Shachar Shemesh wrote: > As far as I understand this, if I disassemble Microsoft binaries (it is > legal in Israel), then the resulting knowledge is legal to use - > anywhere (in other words - the only one who can be sued is me, and the > jurisdiction is Israel, where the action is legal). I am not a lawyer, but I bet you're wrong there. The disassembled code is probably considered a copy, using it could be a copyright violation, and if any such code snuck into Wine, we'd have to go rip it out at great cost. - Dan

5 11

Re: services.exe[3/3]: start a local RPC server and make advapi32 connect/disconnect to it on service manager handle creation/destruction
by Robert Shearman 21 Sep '07

21 Sep '07

Mikolaj Zalewski wrote: > + /* Compatible with Windows function 0x0f */ > + DWORD svcctl_OpenSCManagerW( > + SvcCtlRpcHandle rpc_handle, > + [in,unique,string] LPCWSTR MachineName, > + [in,unique,string] LPCWSTR DatabaseName, > The string attribute should be redundant as LPCWSTR should already be declared as a string type. I also noticed this redundancy in your fourth services patch. > + if ((err = RpcServerInqBindings(&pbindingVector)) != ERROR_SUCCESS) > + { > + WINE_ERR("RpcServerInqBindings failed with error %u\n", err); > + return err; > + } What's the purpose of this? You don't actually use the binding vector anywhere. -- Rob Shearman

1 0

Re: Patch: ntoskrnl.exe - Added PsCreateSystemThread
by Dmitry Timoshkov 21 Sep '07

21 Sep '07

"Carroll Vance" <ovencleaner(a)gmail.com> wrote: > I have implemented PsCreateSystemThread in ntoskrnl.exe. This API i have > found used by programs like nProtect gameguard, and is a pretty commonly > used kernel api. This either ends up calling CreateThread or > CreateRemoteThread depending on if a process handle was provided. You can call CreateRemoteThread without any checks for the process handle. > This is my > first patch, I read over the dev docs and patch format, I hope I did not > miss anything. I have tested this with a driver I made and it seemed to work > fine. Your patch mixes tabs and spaces on the same line, that makes formatting messy. Also if you could add spaces around '!=' and '==' in if statements that would make the code slightly more readable. -- Dmitry.

1 0

Re: Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for joystick buttons
by John Klehm 21 Sep '07

21 Sep '07

On 9/20/07, Antonio Cuni <anto.cuni(a)gmail.com> wrote: > At least one game (Pro Evolution Soccer 6) rely on the pguid field of > the DIOBJECTDATAFORMAT struct to respond to joystick button's events. > Setting pguid to GUID_Button solves the problem. > > 2007-09-20 Antonio Cuni <anto.cuni(a)gmail.com> > > * dlls/dinput/joystick_linux.c, > dlls/dinput/joystick_linuxinput.c > Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for > joystick buttons > > > + df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be > + > df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be GUID_Button > You need to use C style comments /* */ Regards =), --John Klehm

1 0

Re: Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for joystick buttons
by Vitaliy Margolen 21 Sep '07

21 Sep '07

Antonio Cuni wrote: > At least one game (Pro Evolution Soccer 6) rely on the pguid field of > the DIOBJECTDATAFORMAT struct to respond to joystick button's events. > Setting pguid to GUID_Button solves the problem. > > 2007-09-20 Antonio Cuni <anto.cuni(a)gmail.com> > > * dlls/dinput/joystick_linux.c, > dlls/dinput/joystick_linuxinput.c > Always set DIOBJECTDATAFORMAT.pguid to GUID_Button for > joystick buttons > Thank you for the patch. I have few comments about it: > -- /tmp/wine-0.9.45/dlls/dinput/joystick_linux.c 2007-09-14 19:30:55.000000000 +0200 > +++ ./joystick_linux.c 2007-09-20 17:02:15.000000000 +0200 You should diff from the top of the tree (above line should say dlls/dinput/joystick_linux.c). > + df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be GUID_Button C++ comments are not allowed in Wine. Please put comments above the code. > newDevice->buttons[i] = 0x80 | newDevice->numButtons; > + df->rgodf[idx].pguid = &GUID_Button; // some games require the GUID to be GUID_Button > df->rgodf[idx++].dwType = DIDFT_MAKEINSTANCE(newDevice->numButtons++) | DIDFT_PSHBUTTON; Please don't use tabs. Use spaces to keep formating. Vitaliy.

1 0

Re: Implemented PsCreateSystemThread in ntoskrnl.exe
by Juan Lang 20 Sep '07

20 Sep '07

Hi Carroll, + if (ProcessHandle!=0) + localThreadHandle = CreateRemoteThread(ProcessHandle,0,0,StartRoutine,StartContext,0,&ThreadId); + else localThreadHandle = CreateThread(0,0,StartRoutine,StartContext,0,&ThreadId); + + if (localThreadHandle==0) return STATUS_SEVERITY_ERROR; You should use NtCreateThread rather than CreateThread. It also returns a proper status, so you don't have to guess like you do here. --Juan

2 2

[PATCH] fix small spelling mistakes
by Juan Lang 20 Sep '07

20 Sep '07

Hi Peter, > correct spelling of iff -> if Just so you know, iff is a common abbreviation meaning "if and only if." I don't think that's any clearer in the cases you modified, so I think your patch is fine, I just thought you (and others) might be interested. --Juan

2 1

Will ROS and WINE still be steady be synchronized ?
by theUser BL 20 Sep '07

20 Sep '07

Hi! I have also ask the question in a mail in the ROS-Mailinglist -- until now there comes now answer. http://www.reactos.org/archives/public/ros-dev/2007-August/009718.html Will ReactOS and WINE still be steady synchronized? ROS have for example an other Notepad.exe and an other Wordpad.exe The WineMINE have on ROS the colors of the original Windows WinMine. And the cards.dll have other cards. AT first it used the cards of http://nifty.stanford.edu/2004/EstellCardGame/ But after the comment of http://www.reactos.org/archives/public/ros-dev/2007-July/009625.html it used the cards at http://sourceforge.net/projects/macsolitairex WINE on the other side used since the beginning of its cards.dll the Microsoft copyrighted cards, which are also part of MS-Windows. So, for me it seems, that ROS and WINE goes two different ways since some time without syncronizing the source-codes, which can be used for both projects. Is that true? And if yes: Why? Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

4 4

Re: WineD3D: better video memory reporting
by Juan Lang 20 Sep '07

20 Sep '07

Your patch appears empty: > Type: text/x-diff > Size: 0 bytes --Juan

2 1

Re: setupapi(8/22): Implement SetupDiCreateDeviceInfoW
by Alexandre Julliard 20 Sep '07

20 Sep '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > +static DWORD SETUPDI_DevNameToDevID(LPCWSTR devName) > +{ > + LPCWSTR ptr; > + DWORD devNameLen = lstrlenW(devName), devInst = 0; > + BOOL valid = TRUE; > + > + TRACE("%s\n", debugstr_w(devName)); > + for (ptr = devName; valid && *ptr && ptr - devName < devNameLen; ) > + { > + if (isdigitW(*ptr)) > + { > + devInst <<= 8; This won't do what you want. You'd need *= 10 if the id is really stored in decimal, though 0000 looks more like it should be in hex. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winex11.drv/wintab32[3/5]: make wintab strings in winex11.drv Unicode, implement WTInfoW
by Alexandre Julliard 20 Sep '07

20 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -305,8 +312,8 @@ void X11DRV_LoadTabletInfo(HWND hwnddefault) > hwndTabletDefault = hwnddefault; > > /* Do base initializaion */ > - strcpy(gSysContext.lcName, "Wine Tablet Context"); > - strcpy(gSysDevice.NAME,"Wine Tablet Device"); > + MultiByteToWideChar(CP_UTF8, 0, "Wine Tablet Context", -1, gSysContext.lcName, WT_MAX_NAME_LEN); > + MultiByteToWideChar(CP_UTF8, 0, "Wine Tablet Device", -1, gSysDevice.NAME, WT_MAX_NAME_LEN); You should define Unicode constants directly, there's no need to convert at run-time. > @@ -695,10 +716,12 @@ int X11DRV_AttachEventQueueToTablet(HWND hOwner) > X11DRV_expect_error(data->display,Tablet_ErrorHandler,NULL); > for (cur_loop=0; cur_loop < gNumCursors; cur_loop++) > { > + char cursorNameA[WT_MAX_NAME_LEN]; > int event_number=0; > > + WideCharToMultiByte(CP_UNIXCP, 0, gSysCursor[cur_loop].NAME, -1, cursorNameA, WT_MAX_NAME_LEN, NULL, NULL); > for (loop=0; loop < num_devices; loop ++) > - if (strcmp(devices[loop].name,gSysCursor[cur_loop].NAME)==0) > + if (strncmp(devices[loop].name, cursorNameA, WT_MAX_NAME_LEN)==0) This doesn't look right; if the name overflows the buffer we shouldn't simply match against a truncated string. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Alexandre Julliard : wordpad.exe: We can now store binary files in the repository.
by Markus Amsler 20 Sep '07

20 Sep '07

So we can also add ttf fonts and get rid of the fontforge dependency? Markus

2 1

Re: kernel32: Don't crash accessing an invalid handle in GlobalSize [try3]
by Dmitry Timoshkov 20 Sep '07

20 Sep '07

"James Hawkins" <truiken(a)gmail.com> wrote: > This version compares the pointer value to 64000 instead of using a > try/catch block, as suggested by Alexandre. > - if(pintern->Magic==MAGIC_GLOBAL_USED) > + if(pintern > (PGLOBAL32_INTERN)64000 && pintern->Magic==MAGIC_GLOBAL_USED) > { > if (!pintern->Pointer) /* handle case of GlobalAlloc( ??,0) */ It should be either 65535 (0xffff), or a test for HIWORD(pintern) being 0. Also the cast should be to (char *) on both sides rather than (PGLOBAL32_INTERN). -- Dmitry.

2 1

Handling New IDLs with widl
by Roy 19 Sep '07

19 Sep '07

Howdy, I'm looking for advice on how to integrate a new idl into wine. I'm implementing bits and using the widl compiler on the IDL I wrote. My current setup places the IDL in include/ with the build system generating a header file that it posits there. So far, so good. I now need to generate bits_i.c and link that into my dll located in dlls/bits. Adding: ---- IDL_I_SRCS = $(TOPSRCDIR)/include/bits.idl ---- to dlls/bits/Makefile.in solves this problem but drops the bits_i.c into include/. This is rather messy. Any advice on if I should (1) moving my IDL into dlls/bits/ and do everything locally or (2) dig into Make.rules.in and update the rule for *_i.c generation to allow the generated file to exist locally with the .idl sitting in include. The second idea is a little tricky since the current rule is careful to rename the generated .i file with the -U option: ---- .idl_i.c: $(WIDL) $(IDLFLAGS) -u -U $@ $< ---- which is a great idea, but uses the full path to the original idl when renaming the file. Probably good for the general case, but not for me. Thanks for the advice! -Roy

2 1

Re: wineboot: Pass non-zero timeouts to SendMessageTimeout, otherwise the call won't timeout.
by Alexandre Julliard 19 Sep '07

19 Sep '07

Robert Shearman <rob(a)codeweavers.com> writes: > Set the default for WM_QUERYENDSESSION to be 5s which should be enough > time for users to respond to any message boxes and WM_ENDSESSION to a > lower 1s. If you are going to timeout on the user interaction you need to popup a confirmation dialog of some kind to allow users to force killing the app; you can't kill it just because the user didn't click on a "do you want to save your file?" message box fast enough. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: widl [2/2]: Implement pointer descriptions for complex structures
by Robert Shearman 19 Sep '07

19 Sep '07

Dan Hipschman wrote: > var_t *field, > } > else if (is_ptr(type)) > { > - print_file(file, 2, "0x8,\t/* FC_LONG */\n"); > + unsigned char fc = (cont->type == RPC_FC_BOGUS_STRUCT > + ? RPC_FC_POINTER > + : RPC_FC_LONG); > + print_file(file, 2, "0x%x,\t/* %s */\n", fc, string_of_type(fc)); > *tfsoff += 1; > } > else if (!write_base_type(file, type, tfsoff)) > I sent a patch yesterday which does a similar thing to this chunk. I think we need to agree on which approach we're going to take so we can let Alexandre know which patch to commit. -- Rob Shearman

2 4

Re: winsock: Increase amount of iovec's to 32
by Alexandre Julliard 19 Sep '07

19 Sep '07

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > I don't know why WS_MSG_MAXIOVLEN is used here, that seems to be a > message identifier rather then the actual size of MAXIOVLEN, so I added > a define for MAXIOVLEN and made it 32. MSG_MAXIOVLEN is not a message identifier, it's really supposed to be an iovec size. Do you have a test case showing that Windows uses 32 instead? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: add a macro to declare critical sections as we declare them in Wine - initialized and with a debug
by Alexandre Julliard 19 Sep '07

19 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Would such a patch be accepted? No, debug.h is about the libwine debugging API, critical sections have nothing to do with that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: When minimizing a top level window move it outside of the visible desktop area
by Alexandre Julliard 19 Sep '07

19 Sep '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Changelog: > winex11.drv: When minimizing a top level window move it outside of > the visible desktop area. This will break apps that expect to paint their icon window, and probably also break the positioning of the icon title. It also doesn't work even for standard icons in desktop mode. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv[1/4]: fix two bugs in WTInfoA
by Alexandre Julliard 19 Sep '07

19 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Two bugs I've found working on previous implentations > From b233532f7adc140c4e36fb2288581fe0ff181935 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 17 Sep 2007 11:54:41 -0700 > Subject: [PATCH] winex11.drv: fix two bugs in WTInfoA Please write a better description of the changes, "fix bug" can apply to just about any commit (and in general, if you have two bugs to fix there should be two patches...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: A first implentation of services.exe
by Robert Shearman 18 Sep '07

18 Sep '07

Mikolaj Zalewski wrote: > I don't want this patch to get committed but to maybe get some > comments. If the patch will be considered to be ok I can send it as > three smaller patches. It implements the basic infrastructure for > services.exe - a process that maintains the services database and > states. I think this can be useful in the long run. Absolutely. > This patch > currently doesn't implement anything useful - it connects to > services.exe in OpenSCManager and disconnect in CloseServiceHandle and > validating the database name is now done in services.exe but if this > approach is good I will add more functionality. > It looks good to me, but I'm a bit worried that you'll come across bugs/unimplemented features in widl when you start adding more calls. > Is there a way to check if a RPC connection over a named pipe was > closed by the client (probably we should close all it's handles in > such a case)? Yes, you can do this using context handles, but unfortunately we're lacking support for these on the RPC server side and in widl. > Also this program show a bug in our rpcrt4 - if we pass > NULL as a [in,unique,string] parameter rpcrt4 will crash because of a > strlen on it in NdrConformantStringBufferSize. To see it one can > remove the workaround in OpenSCManager and do a `make test`. That sounds like a bug in widl to me, and I'll take a look. > Macros > like RET_IF_ERROR should be removed from the final version or can they > stay? Definitely should be removed. > diff --git a/include/wine/svcctl_shared.h b/include/wine/svcctl_shared.h > new file mode 100644 > index 0000000..5687ddc > --- /dev/null > +++ b/include/wine/svcctl_shared.h > @@ -0,0 +1,35 @@ > +/* > + * SVCCTL (services.exe RPC interface) shared constants > + * > + * Copyright (C) 2007 Google (Mikolaj Zalewski) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_SVCCTL_SHARED_H > +#define __WINE_SVCCTL_SHARED_H > + > +#include <stdarg.h> > +#include <windef.h> > +#include <winbase.h> > + > +#define SVCCTL_TRANSPORT {'n','c','a','c','n','_','n','p',0} > +#define SVCCTL_ENDPOINT {'\\','p','i','p','e','\\','s','v','c','c','t','l',0} > + > +/* Not the Windows event name - if needed the true one can be found in Inside Windows */ > +#define SVCCTL_STARTED_EVENT (const WCHAR[]){'S','v','c','c','t','l','S','t','a','r','t','e','d',0} > + > + > +#endif /* __WINE_RPCSS_SHARED_H */ > We shouldn't need another file for this. You can put this same stuff in svcctl.idl using cpp_quote. > +DWORD RPC_MainLoop() Make sure to fully specify the parameters for functions with no parameters by declaring them as "(void)". -- Rob Shearman

1 0

Want to contact Mike McCormack
by Stefan Ensslen 18 Sep '07

18 Sep '07

Dear Sirs, I wanted to contact Mike McCormack from the WinE developer team, but my email to mike(a)codeweavers.com bounced. If you could send me his new email address, I'd be very happy. The question I wanted to ask Mr. McCormack is the following: Dear Mike, I have found your code for generating proxy/stub-code at www.winehq.org. I wanted to ask where you have found a documentation of the functions used in this code (for example NdrProxyInitialize, NdrProxySendReceive, and so on). The MSDN doesn't provide any _valuable_ documentation for this function, so you surely have another source of documentation. Thanks in advance, Stefan Ensslen -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

2 1

AppDB down - too many SQL connections?
by Alexander Nicolaysen Sørnes 18 Sep '07

18 Sep '07

Hello, I am unable to access the database now because of too many MySQL connections. Does anyone have a log file to indicate whether this is some sort of attack, or whether we just have too many legitimate users? Alexander N. Sørnes

2 1

make crosstest is missing -lcabinet
by Pedro Araújo 18 Sep '07

18 Sep '07

Hi all, I've been trying to cross-compile the Wine tests, but I keep getting this error: $ ./configure && make crosstest [SNIP] i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o testlist.cross.o -o advpack_crosstest.exe -lcabinet -luser32 -ladvapi32 -lkernel32 /usr/lib/gcc/i586-mingw32msvc/3.4.5/../../../../i586-mingw32msvc/bin/ld: cannot find -lcabinet collect2: ld returned 1 exit status make[2]: *** [advpack_crosstest.exe] Error 1 make[2]: Leaving directory `/.../dlls/advpack/tests' make[1]: *** [advpack/tests/__crosstest__] Error 2 make[1]: Leaving directory `/.../dlls' make: *** [dlls/__crosstest__] Error 2 Am I missing anything? Thanks in advance. -- - Pedro.

2 2

Problem with TCP Option 0x00000008
by Christian Mahnke 18 Sep '07

18 Sep '07

Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x00000008" after the loading of native rpcltccm.dll. To work around this i've compiled a modified wine 0.9.44 with an empty case statement for 0x00000008 in socket.c. It doesn't help much, the program just fails a bit later. The TCP Option 0x00000008 is defined as TCP_ATMARK in ws2_ipdef.h in the Windows SDK. Does anyone know how this should be mapped ? Cheers, Christian

4 6

compile wine from sources - strange messages
by Andrey Gavrilin 18 Sep '07

18 Sep '07

Hello. I wish to compile wine from sources. Has received such message. The distribution: Ubuntu 7.04. What headers files does not suffice? PS I used the program the translator from Russian to English. configure: WARNING: jack/jack.h: present but cannot be compiled configure: WARNING: jack/jack.h: check for missing prerequisite headers? configure: WARNING: jack/jack.h: see the Autoconf documentation configure: WARNING: jack/jack.h: section "Present But Cannot Be Compiled" configure: WARNING: jack/jack.h: proceeding with the preprocessor's result configure: WARNING: jack/jack.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## configure: WARNING: pthread.h: present but cannot be compiled configure: WARNING: pthread.h: check for missing prerequisite headers? configure: WARNING: pthread.h: see the Autoconf documentation configure: WARNING: pthread.h: section "Present But Cannot Be Compiled" configure: WARNING: pthread.h: proceeding with the preprocessor's result configure: WARNING: pthread.h: in the future, the compiler will take precedence

2 1

Re: kernel32: Don't crash accessing an invalid handle in GlobalSize
by Robert Shearman 18 Sep '07

18 Sep '07

James Hawkins wrote: > + if (IsBadReadPtr(pintern, 1)) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + > if(pintern->Magic==MAGIC_GLOBAL_USED) > { > if (!pintern->Pointer) /* handle case of GlobalAlloc( ??,0) */ It would be better to wrap the Magic access with an exception handler rather than use IsBadReadPtr. -- Rob Shearman

1 0

Re: fix for bug 9665
by James Hawkins 17 Sep '07

17 Sep '07

On 9/17/07, Martin <martin.marsan(a)gmail.com> wrote: > > > 2007-09-17 Martin Sand <deadlock(a)start.no> > > * dlls/ddraw/direct3d.c: > ddraw: fixes a bug which prevents Kings Quest 8 from starting(bug 9665) > A good changelog entry details what you changed, not what apps are fixed by a change. -- James Hawkins

2 1

Re: fix for bug 9665
by Stefan Dösinger 17 Sep '07

17 Sep '07

Am Montag, 17. September 2007 20:45:04 schrieb Martin: I doubt this fix is correct, as explained in bug 9665 a few minutes ago. It should fail the d3d test too

1 0

[AppDB] Bug: Let objectManager delete bug links
by Alexander Nicolaysen Sørnes 17 Sep '07

17 Sep '07

Bug: Let objectManager delete bug links Regards, Alexander N. Sørnes

1 0

Re: user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs [resend]
by Alexandre Julliard 17 Sep '07

17 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Is there something wrong with this patch? > From 50eacd2465df53e5cfc15458ff5ab80f0cc07e7e Mon Sep 17 00:00:00 2001 > From: Mikolaj Zalewski <mikolaj(a)zalewski.pl> > Date: Mon, 10 Sep 2007 14:03:49 -0700 > Subject: [PATCH] user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs There are several other places where winprocs are returned, like SetWindowLong or GetClassLong. You probably have to handle them too, or at least write test cases for them. -- Alexandre Julliard julliard(a)winehq.org

1 0

An enumeration of network resources
by Konstantin Kondratyuk 17 Sep '07

17 Sep '07

Hello! I try to organize an enumeration of network resources by means of functions WNetOpenEnum and WNetEnumResource. Function WNetOpenEnumW contains a line: " ret = providerTable->table[index].openEnum( dwScope, dwType, dwUsage, lpNet, &handle); " which addresses to function in dll. The information about loaded dll is absent in the wine registry. Whether it means, what there are no preparations of DLL's for work with a network (similar ntlanman.dll in Windows)? -- Best regards, Konstantin Kondratyuk.

2 1

Re: msi(1/3): Don't crash if rec is NULL
by James Hawkins 17 Sep '07

17 Sep '07

On 9/14/07, Juan Lang <juan.lang(a)gmail.com> wrote: > This series of patches is in response to Jeremy's troubles with > iTunes. They may or may not fix the installer for him, but they > prevent potential crashes. > --Juan > MSI_FormatRecordW is an internal function and we should be crashing if rec is NULL. -- James Hawkins

3 5

old dos/windows program crashing
by Joris Huizer 17 Sep '07

17 Sep '07

Hello, I have a program, that I got like ages ago. It effectively is an atari emulator for dos, by the name "pacifist", but I originally got it installed under windows ME. It has an old atari-basic program "installed" in it, (a simple game) written by a friend in it, which I wanted to play. I decided to try to get it to run again under Linux. The website it came from originally doesn't seem to have the program available for download anymore - so I just copied the files from the windows ME disc. I obviously tried WINE then, but it didn't work, however, dosbox works with it (though slow, obviously) so I know I'm not missing required files (though, perhaps, registry settings - not sure how likely that is, though) Anyway. This isn't such a big deal, though I'd like to look at what's going on in WINE, and possibly fix it - though I need help here. This program is, among things, a "PMODE W/DOS Extender" - so that means it probably does some obscure real-mode/protected-mode stuff. Console output is as follows, Warning: unprotecting memory to allow real-mode calls. NULL pointer accesses will no longer be caught. err:int:__wine_emulate_instruction mov cr0,eax at 0x00000544 err:int:DOSVM_Int33Handler int33: unknown/not implemented parameters: int33: AX 0015, BX 0003, CX 11f7, DX 1165, SI 0055, DI 03ac, DS 11df, ES 11e7 fixme:int:DOSVM_Int10Handler Select vertical resolution - not supported fixme:int:DOSVM_Int10Handler Load ROM 8x8 Double Dot Patterns - Not Supported fixme:int31:DOSVM_Int31Handler physical address mapping (0x00000000) - unimplemented wine: Unhandled page fault on read access to 0xffffffff at address 0x101f:0x0003ed71 (thread 002d), starting debugger... fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000002 (mode 0) fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000000 (mode 0) Also I attached the visual display the "winevdm" shows as the program crashes. (It seems it crashes somewhere in generated code in kernel32.dll - in DPMI_PendingEventCheck() - written by the winebuild tool) I know some things about real-mode code, but not too much. Could you give me pointers on what to look at next? BTW, please CC me, I'm not on the mailing list currently. Thanks, Joris ____________________________________________________________________________________ Check out the hottest 2008 models today at Yahoo! Autos. http://autos.yahoo.com/new_cars.html

3 4

AppDB: cannot submit a screenshot even when logged in
by Vit Hrachovy 16 Sep '07

16 Sep '07

Hello everybody, I may missed something, but I cannot submit a screenshot to the application I maintain in AppDB and I'm logged in. There's always a nasty 'Log in to submit screenshots' instead of Submit button. Is it planned downtime? Regards Vit P.S. It's http://appdb.winehq.org/screenshots.php?iAppId=4025

2 2

DirectDraw opengl renderer
by Alexander Nicolaysen Sørnes 16 Sep '07

16 Sep '07

Hello everyone, I know this has been discussed before (and not that long ago), but I think I have some wonderful new information to add to the debate of whether or not to add an option for this in winecfg. As I understand it, there is still a long time before the opengl renderer will become the default one. With Wine 0.9.45, some bugs were fixed allowing the opengl renderer to be used for C&C Tiberian Sun, and I must say the speed improvements are dramatic! Without any FPS tools I would definitely say performance has increased by several hundred per cent. Now the game is so fast I may have to turn down the game speed setting. :) If you move the mouse it still slows down, though, as it does with the gdi renderer. Anyway, I think this should apply to several other games as well (and I will test more). But I was wondering is this is enough to add an option in winecfg? Alexander N. Sørnes

3 3

Re: RICHED20: additional tests plus RFC
by Alexander Nicolaysen Sørnes 16 Sep '07

16 Sep '07

On Sunday 16. September 2007 04:34:17 a_villacis(a)palosanto.com wrote: > I am tracking down a richedit bug in FACETS (bug #1713). > > Apparently, the OCX control used by this app expects a particular > SendMessage() > with the message EM_SETCHARFORMAT to return 1. Currently builtin returns 0 > unconditionally, making this app bail out with "Invalid property value". By > changing the return value to 1 unconditionally, the app gets "fixed", but > this > is not a proper solution, since other apps might break with this change. > > This patch adds additional testing of EM_SETCHARFORMAT. All todo_wine's > succeed > in an installation of WinXP SP2. Please confirm this is so for all of you. > > There are two code blocks commented out. The first one makes the app crash > on WinXP, and is listed for completeness. The other one was supposed to > test what > happens when the riched20 control receives a blanked-out CHARFORMAT2 > structure. > However this triggers an assertion in Wine at style.c line 63. WinXP > doesn't bat an eye, and possibly ignores these structure values. Unless > somebody objects, I will shortly send a patch that replaces the assertion > with a NULL return in style.c, plus a NULL check in editor.c . > > There are more riched20 tests that fail in WinXP SP2, unrelated to > EM_SETCHARFORMAT, but I would like confirmation that (1) somebody else sees > failing tests in native Windows, not just me, and (2) this patch does not > introduce any new failing tests in native Windows. > > Changelog: > * Add additional tests for EM_SETCHARFORMAT message of riched20 control Hey, great to see some work on EM_SETCHARFORMAT. If you're interested, Wine has a builtin WordPad (just type 'wine wordpad') which exposes some problems. Try to select a font in the font list when no text is selected, for instance. Alexander N. Sørnes

1 0

Re: [PATCH 2/7] gdi: Implement BiDi classification of characters
by Steven Edwards 16 Sep '07

16 Sep '07

Hi Maarten, Could you configure your git scripts to output different filenames when generating patches? Somehow they get managed for me in my gmail inbox. It makes it quite a pain for me to review. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

6 10

Re: patches to make wine compile on osx
by Roderick Colenbrander 16 Sep '07

16 Sep '07

Hi Daniel, A few comments regarding the patches. First of all you should use a single patch file for each patch (this makes tracking patches easier). Now over to the patches. Regarding wineosxtypeerrors.patch: - 'GLenum' should be 'unsigned int' instead of int. I don't understand why the casts are needed as it should just get the type info from gl.h. I think that using '%u' for unsigned data could fix most of your problems. Regarding wineosxglexterrors.patch: - Same comment regarding unsigned int data. (make this a separate patch) - GL_TEXTURE_RECTANGLE_NV should be handled in include/wine/wgl.h, strange that I didn't receive compile failures for linux about it .. perhaps it is already in the mesa headers. (make this a separate patch) Anyway I would define GL_TEXTURE_RECTANGLE_NV like this: #ifndef GL_NV_texture_rectangle #define GL_TEXTURE_RECTANGLE_NV 0x84F5 #define GL_TEXTURE_BINDING_RECTANGLE_NV 0x84F6 #define GL_PROXY_TEXTURE_RECTANGLE_NV 0x84F7 #define GL_MAX_RECTANGLE_TEXTURE_SIZE_NV 0x84F8 #endif The extension is fully compatible with GL_ARB_texture_rectangle which osx should have and GL_EXT_texture_rectangle is likely the same. (the constants between the ARB and NV one are also the same, I expect the same for EXT and ARB) Regards, Roderick Colenbrander

1 0

Dfw5 draws graphs black (regression)
by Willi Mann 15 Sep '07

15 Sep '07

Hi! Derive 5 no longer draws graphs in color. It should look like that: http://wserver.wm1.at/~willi/wine/dfw.png With current versions, it draw the blue graph in black. I could track it down to this commit (between 0.9.25 and 0.9.26): http://wserver.wm1.at/~willi/wine/wine_dfw.diff.txt (In fact, these are two commits, but the intermediate version does not compile) Please let me know if I can do anything to help fixing this bug. Willi Please CC: me on replies.

2 2

Re: add shell32.755
by Maarten Lankhorst 15 Sep '07

15 Sep '07

Louis. Lenders schreef: > Hi, i'm sending in 2 patches from Anastasius Focht for review, and > hopefully for inclusion in git. Otherwise they might get "lost" and > forgotten. > > They're helpful for testing apps with native comdlg32.dll. So although > they do not really fix any real life app (not that i know of I'm missing a few tests to see if this behavior is actually what it should be like in windows. You should always add them to implementations of new functions. Cheers, Maarten

1 0

Re: fnt2fon: janitorial IgnoredReturnValues (1/5)
by Alexandre Julliard 14 Sep '07

14 Sep '07

Lionel_Debroux <lionel_debroux(a)yahoo.fr> writes: > tools/fnt2fon is flagged in the janitorial page "IgnoredReturnValues". > This page is outdated, but its content is still valid for fnt2fon, which > ignores a number of return values. I don't think that's worth fixing, the warnings are essentially useless, it just makes the code uglier. There may be a few legitimate errors in there, like checking the fopen() result, and those could be fixed; but please don't add checking to every call that gcc complains about. -- Alexandre Julliard julliard(a)winehq.org

2 2

Problem with TCP Option 0x00000008
by Christian Mahnke 14 Sep '07

14 Sep '07

Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x00000008" after the loading of native rpcltccm.dll. To work around this i've compiled a modified wine 0.9.44 with an empty case statement for 0x00000008 in socket.c. It doesn't help much, the program just fails a bit later. The TCP Option 0x00000008 is defined as TCP_ATMARK in ws2_ipdef.h in the Windows SDK. Does anyone know how this should be mapped ? Cheers, Christian

1 0

Re: winex11.drv/wintab32[1/5]: store categories field-by-field (resend)
by Alexandre Julliard 14 Sep '07

14 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > /*********************************************************************** > * X11DRV_WTInfoA (X11DRV.@) > + * > + * NOTES > + * If cchOnlyCountString is not NULL and the data is a string then no > + * data is stored in the output buffer but only the string length is > + * returned in *cchOnlyCountString (and is >= 1 as contains at least a NUL > + * character). It have no effect on non-string data. > + * > + * Apart from the cchOnlyCountString parameter this function differs from the > + * WTInfo[AW] as for nIndex == 0 it returns the number of items in the > + * category. It's wintab32.dll that concatenates the data > + * > + * It is valid to call WTInfoA with lpOutput == NULL, as per standard. > + * lpOutput == NULL signifies the user only wishes to find the size of > + * the data. > */ > -UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput) > +UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput, DWORD *cchOnlyCountString) You shouldn't change the prototype. Driver functions should follow the signature of the corresponding APIs as far as possible. -- Alexandre Julliard julliard(a)winehq.org

2 2

carbon poker under wine
by Trent Waddington 14 Sep '07

14 Sep '07

On 9/13/07, Eric Andersen <xxxx(a)xxx.com> wrote: > I was wondering if you could possibly throw me some pointers for > getting Carbon Poker working under wine. > > For the record I'm using ubuntu feisty and wine 0.9.44. I'll forward this to wine-devel, as someone else might want it. Well, first thing you should try is building wine from the git tree. This is painful and annoying because Linus is stupid and ugly but there's been a lot of fixes to the crypt32 stuff recently, and you'll need that: git clone git://source.winehq.org/git/wine.git wine cd wine ; ./configure ; make etc. You can try what I'm doing with your current version first, as it has some of this crypt32 stuff.. so it might work. I downloaded CarbonPoker.exe from the website, ran it with wine and it complains that I don't have flash8 and then just sits there and does nothing. I don't know what it is doing, so I just went downloaded Flash: wget http://fpdownload.macromedia.com/get/flashplayer/current/install_flash_play… ./wine install_flash_player.exe That installs happily. So, running CarbonPoker.exe again.. ./wine CarbonPoker.exe err:ole:COMPOBJ_DllList_Add couldn't load in-process dll L"C:\\windows\\system32\\Macromed\\Flash\\Flash9b.ocx" Uhhh, ok. Having a look in that dir I see a Flash9.ocx but no Flash9b.ocx, what the hell? cd ~/.wine/drive_c/windows/system32/Macromed/Flash/ ln -s Flash9.ocx Flash9b.ocx cd - ./wine CarbonPoker.exe and now it is happy and starts "Installing software..." which actually means it is updating the stub.. which it then runs, and starts "Installing software..." again.. You can ignore the "HTML rendering is currently disabled" where the installer would usually be telling you about the great benefits you get from playing Carbon Poker. Eventually this finishes. The installer goes away.. and after waiting and waiting, I get bored and hit CTRL-C. Fine, let's just run it then: ./wine ~/.wine/drive_c/Program\ Files/CarbonPoker/Poker.exe I get a "It appears the software has generated a bug. You can optionally submit it with comments about what you were doing at..." and as much as I'd like to do that with something like "doesn't work under wine" I'm going to press Cancel. Now we're in the login screen and it's asking me how I'd like to login, etc. So it looks like it is running! Just to check, I'm closing it and running it again.. yep, I'm in the login screen again. It's running. Hmm, I have a login for this game around here somewhere.. putting in my email address and pressing "Forgot Password" gives me this error: wine: Call from 0x7ee53f40 to unimplemented function urlmon.dll.HlinkSimpleNavigateToMoniker, aborting That isn't much help. And that crashed it, so running it again.. Sidenote: http://www.carbonpoker.com/pass.html is not secure.. ever heard of "denial of service" guys? Anyway, got some login details. Logged in, I see spam. Click on "Poker Tables". Up some come. Click on the first non-full one and "Join Table". And yes, I can join the table and sit down. I'm playing Poker. Yah. Trent

1 1

First song purchased on iTunes 7 with Wine...
by Dan Kegel 13 Sep '07

13 Sep '07

For the record, I just bought "Autobahn" by Kraftwerk for $0.99 from the iTunes store using iTunes 7 on today's wine from git. It's playing now while I type this message. (OK, the music skips sometimes when I type or adjust the volume or move the mouse or scratch my nose... but hey, at least it's a start!) Thanks, Juan! - Dan

3 4

Re: [2/2] WGL: Sync pixmap after glFlush/glFinish, not before every GL call
by Alexandre Julliard 13 Sep '07

13 Sep '07

Chris Robinson <chris.kcat(a)gmail.com> writes: > From 95214f29672566796564db30ab7f61a2462e4e50 Mon Sep 17 00:00:00 2001 > From: Chris Robinson <chris.kcat(a)gmail.com> > Date: Wed, 12 Sep 2007 06:42:05 -0700 > Subject: [PATCH] WGL: Sync pixmap after glFlush/glFinish, not before every GL call The goal is to sync the pixmap before we start drawing to it, so doing it at glFlush time is too late. -- Alexandre Julliard julliard(a)winehq.org

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel