- wine-devel - winehq.org

Re: avifil32: Fix some memory leaks
by Paul Vriens 13 Sep '07

13 Sep '07

Andrew Talbot wrote: > Changelog: > avifil32: Fix some memory leaks. > > > - if (mmioSeek(This->paf->hmmio, This->paf->dwNextFramePos, SEEK_SET) == -1) > - return AVIERR_FILEWRITE; > - if (mmioCreateChunk(This->paf->hmmio, &ck, 0) != S_OK) > - return AVIERR_FILEWRITE; > - if (mmioWrite(This->paf->hmmio, (HPSTR)lppc, ck.cksize) != ck.cksize) > - return AVIERR_FILEWRITE; > - if (mmioAscend(This->paf->hmmio, &ck, 0) != S_OK) > + if (mmioSeek(This->paf->hmmio, This->paf->dwNextFramePos, SEEK_SET) == -1 || > + mmioCreateChunk(This->paf->hmmio, &ck, 0) != S_OK || > + mmioWrite(This->paf->hmmio, (HPSTR)lppc, ck.cksize) != ck.cksize || > + mmioAscend(This->paf->hmmio, &ck, 0) != S_OK) > + { Doesn't this mean that every one of those 4 mmio-calls are executed? In the previous logic we would bail out after one failure. -- Cheers, Paul.

3 3

Re: wineprefixcreate: Make sure the path returned by GetTempPath() during the $WINEPREFIX creation will be writable.
by Alexandre Julliard 13 Sep '07

13 Sep '07

Francois Gouget <fgouget(a)codeweavers.com> writes: > mshtml.dll (and probably many others) use GetTempPath() during the > self-registration process. But at that point the Windows environment > variables, and in particular $TMP and $TEMP, have not been set yet, > especially not in the currently running process. So when mshtml.dll > calls GetTempPath(), that function returns the current directory, which > obviously is no good if that directory is not writable (like '/' for > instance). So this patch makes 'c:\windows\temp' the current directory, > which we know will be writable (and the chdir() should have no other > side effect in this script). Actually GetTempPath is not supposed to use the current directory, I committed a fix. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32[2/4]: implement AddFontMemResourceEx (based on a patch of Byeong-Sik Jeon, helps with bug #5865) (resend)
by Alexandre Julliard 13 Sep '07

13 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index c516736..efc044b 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -3214,8 +3214,18 @@ BOOL WINAPI RemoveFontResourceW( LPCWSTR > */ > HANDLE WINAPI AddFontMemResourceEx( PVOID pbFont, DWORD cbFont, PVOID pdv, DWORD *pcFonts) > { > - FIXME("(%p,%08x,%p,%p): stub\n", pbFont, cbFont, pdv, pcFonts); > - return NULL; > + PVOID pFontCopy = HeapAlloc(GetProcessHeap(), 0, cbFont); > + HANDLE ret; > + > + TRACE("Copying %d bytes of data from %p to %p\n", cbFont, pbFont, pFontCopy); > + memcpy(pFontCopy, pbFont, cbFont); > + ret = WineEngAddFontMemResourceEx(pFontCopy, cbFont, pdv, pcFonts); > + if (ret == NULL) > + { > + TRACE("Font create failed - freeing %p\n", pFontCopy); > + HeapFree(GetProcessHeap(), 0, pFontCopy); > + } > + return ret; > } The memory copy should be done in WineEngAddFontMemResourceEx since that's where the data is managed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] WineD3D: Pixel shader 1.x constants are clamped to [-1;1]
by Alexandre Julliard 13 Sep '07

13 Sep '07

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > It is hard to judge if this patch will fix anything. A problem is that > clamping the constants on loading makes constants loading more expensive. > Luckilly though there aren't many ps 1.x constants(8 max). It is hard to say > if there are any games that use constants > 1.0, but incorrect constant > loading can have many bad effects. This one fails make test for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:3068: Test failed: quad 1 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3070: Test failed: quad 2 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3073: Test failed: quad 3 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3077: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3207: Test failed: quad 1 has color 007f7f00, expected 0x00808000 visual.c:3209: Test failed: quad 2 has color 007f7f00, expected 0x00808000 visual.c:3211: Test failed: quad 3 has color 007f7f00, expected 0x00808000 visual.c:3214: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 make[2]: *** [visual.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WGL: Fix a major ATI regression
by Joerg Mayer 13 Sep '07

13 Sep '07

On Thu, Sep 13, 2007 at 01:09:14AM +0200, Roderick Colenbrander wrote: > The change isn't a hack but more a workaround. I have submitted the bugreport to ATI but they likely won't fix it anytime soon. Well, if I understood the ATI development cycle correctly, even if they fixed it right away it will take another two releases (months) until it is released. ciao Joerg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

1 0

Cvs update error.
by Anatoly Lyutin 13 Sep '07

13 Sep '07

Hi all!! Today I tried to make cvs update and cvs extradites a error: [vostok@windsor wine]$ cvs update cvs [update aborted]: unrecognized auth response from cvs.winehq.org: cvs pserver: /home/wine/CVSROOT/config [8]: warning: this CVS does not support PreservePermissions What happens? -- Best regards Anatoly Lyutin.

1 0

WineHQ Downtime
by Jeremy Newman 13 Sep '07

13 Sep '07

This is a reminder. WineHQ will be going offline for upgrades today at 14:00 CDT (19:00 GMT). I expect downtime to be no longer than one hour. Some services will appear to have sporadic outages even after the upgrade is complete. This will be due to changes in configs and upgraded versions of server software. I will post back to wine-devel when the upgrade is complete.

3 3

Re: WGL: Fix a major ATI regression
by Chris Robinson 12 Sep '07

12 Sep '07

On Wednesday 12 September 2007 04:09:14 pm Roderick Colenbrander wrote: > + visinfo = pglXGetVisualFromFBConfig(display, cfgs[i]); > + /* We have found an offscreen rendering format when there is no > visualinfo :) */ > + if(visinfo->visualid == visualid) { > pglXGetFBConfigAttrib(display, cfgs[i], GLX_FBCONFIG_ID, > &fmt_id); > fbconfig = cfgs[i]; > } You're using visinfo before making sure it's valid. And I think that comment is a little misleading talking about offscreen formats when checking for the default visual. > + if(!visinfo) { > nOffscreenFormats++; > } > + XFree(visinfo); I don't think we can rely on being able to safely XFree a NULL pointer. None of the other code in opengl.c relies in that behavior.

1 0

Re: [3/5] WineD3D: Fix the reflection calculation in texm3x3(v)spec
by H. Verbeet 12 Sep '07

12 Sep '07

On 12/09/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > ...so what the patch *actually* does in a completely obfuscated way, is getting rid of the assumption that the normal is normalized. IOW, - shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, tmp0.xyz);\n"); + shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, normalize(tmp0.xyz));\n"); would be just as effective. That also means that the change in the ARB implementation - /* Calculate reflection vector (Assume normal is normalized): RF = 2*(N.E)*N -E */ + /* Calculate reflection vector (Assume normal is normalized): + * See comment in the glsl implementation. is misleading at best.

1 0

Re: problem with silly CreateBitmap call
by Francois Gouget 12 Sep '07

12 Sep '07

On Thu, 6 Sep 2007, Deun wrote: [...] > The size of the bitmap seems crazy... So I've made a patch to > fix this in bitmap.c by setting 1x1 size in case of stupid > input instead of failing with BadAlloc. However, since it works > fine on real windows, so I'm not sure about the behaviour that > the function should have. Seems like a good candidate for a conformance test. Call the API with the crazy values and see what comes out... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

4 3

iTunes 7
by Juan Lang 12 Sep '07

12 Sep '07

Folks, I just sent a series of wintrust patches that gets iTunes 7 to start, at least for me. I expect some will get rejected due to collision with Francois's patch - I'll resynch and resend. But if you want to play around with iTunes, grab those patches and give them a whirl. Known issues: 1. Your screen will go black when it starts. This is something QuickTime is doing. You can drag windows around to force some repainting to work around it. 2. You'll see lots of fixmes on the console, especially: "fixme:setupapi:CMP_WaitNoPendingInstallEvents 0", "fixme:setupapi:SetupDiGetClassDevsW returning empty list", and "fixme:htmlhelp:HtmlHelpW HH case HH_PRETRANSLATEMESSAGE not handled." 3. The main window will be transparent (and basically unusable) if you don't have GL support compiled in. Have fun, --Juan

4 5

Re: [PATCH] user32: edit control should respond to ctrl + z (try 3)
by Dmitry Timoshkov 12 Sep '07

12 Sep '07

"Lei Zhang" <thestig(a)google.com> wrote: > This patch lets users hit ctrl + Z in edit controls to trigger an > undo. The test case has been improved to check for both the return > values and the content of the edit control. In the tests still there is no actual edit contents/selection changes tracking after every message. -- Dmitry.

2 6

Re: WineD3D: PBO support 2/2 (attempt 2)
by Alexandre Julliard 12 Sep '07

12 Sep '07

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > This is an updated version of the patch. In the previous one I was > making a glBindBuffer call in a place without checking if PBOs were > around. Further the place didn't need the call anymore. This breaks the tests for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:2043: Test failed: quad 1 has color 0000ffff, expected 0x00FFFF00 visual.c:2045: Test failed: quad 2 has color 0000ffff, expected 0x0000000 visual.c:2047: Test failed: quad 3 has color 0000ffff, expected 0x0000FF00 make[2]: *** [visual.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by Jeremy Newman 11 Sep '07

11 Sep '07

Is this the final version of this patch? Or shall I wait for an updated one from you? On Tue, 2007-09-11 at 11:31 -0700, Lei Zhang wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal.

1 0

Re: wordpad: #1 Store bar states in the registry
by Alexandre Julliard 11 Sep '07

11 Sep '07

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > wordpad: #1 Store bar states in the registry This doesn't work well when resizing the window, the toolbars get overwritten by the edit area. -- Alexandre Julliard julliard(a)winehq.org

2 7

Re: A fix for a problem with older games
by Stefan Dösinger 11 Sep '07

11 Sep '07

Am Sonntag, 9. September 2007 17:10:39 schrieb Martin: That patch is not correct Are you sure that this patch really causes a problem? If you are running the game in winedbg and get an exception there it is a symptom of the DIB management in winex11.drv. You can just use "pass" to pass the exception up to the next handler(winex11.drv). The exception never reaches the app. If you really get a crash there then This->resource.allocatedMemory is pointing to a bad location, most likely NULL. This is a problem at some other place and should be fixed elsewhere. This read is a hack to work around a bug in the open source ati driver which caused a hard system crash if an exception occured during glDrawPixels. You can remove hack as a whole if it really causes problems, but this will cause hard crashes for a wide range of radeon drivers(xorg 6.8 and 7.0 at least). I think it is fixed in the latest version, but I am not sure, I'd have to test that. Since the hack is confined in one single function and doesn't have any side effects I decided to keep it.

1 0

Re: a ddraw patch
by Stefan Dösinger 11 Sep '07

11 Sep '07

Am Sonntag, 9. September 2007 17:11:06 schrieb Martin: That patch will obviously break the game the dwTextureCaps modification was added originally... Can you check which cap that game needs that is removed in those lines?

1 0

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by James Hawkins 11 Sep '07

11 Sep '07

On 9/11/07, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal. > <th>Blocker</th> - <td>Blocks development and/or testing work</td> + <td>When Wine won't start at all for any application, and there's no work + around</td> I think you've made this too specific, especially for Blocker. For example, in the new description you've left out compile errors, which is a big part of what blocker represents. The original description is fine for blocker. <th>Major</th> - <td>major loss of function</td> + <td>For a problem that is affecting most applications you run in Wine</td> + </tr> Why not something like, major loss of functionality for a wide range of applications instead of totally rewriting the definition. -- James Hawkins

3 3

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by Jesse Allen 11 Sep '07

11 Sep '07

On 9/11/07, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal. > > > > > How about for minor you still keep "where an easy workaround is present". That differentiates it from normal. Jesse

1 0

Fifa 07 - wined3d regression
by Jan de Mooij 11 Sep '07

11 Sep '07

Hi, Fifa 07 used to work fine with Wine, but around version 0.9.40-0.9.41 the game hangs when I start a new match. The text "Loading..." is displayed, but there is no progressbar because one thread terminates. I attached the results of winedbg (backtrace and some messages before the crash). This is the result of git bisect: 9ba3f389f665aae45b6a8a6861f9621b020e5c25 is first bad commit commit 9ba3f389f665aae45b6a8a6861f9621b020e5c25 Author: Stefan Dösinger <stefandoesinger(a)gmx.at> Date: Sun Jul 8 23:33:48 2007 +0200 wined3d: Initialize surfaces at creation. This patch removes a check of "GL_SUPPORT(APPLE_CLIENT_STORAGE)". If I put that check in again, the game works like before. The if-condition evaluates to True now, so it allocates the memory. But it segfaults there I think. Please let me know if you need more information. Thanks in advance! Jan de Mooij

2 2

AppDB entries
by speedator＠gmx.de 11 Sep '07

11 Sep '07

Hi, sometimes app-entries (like Acrobat Reader) are for series of applications and versions for the single applications. Sometimes there are app-entries(like Age of Empires) for single applications in a series and version-entries for patches, betas, demos etc.. And sometimes it is a mixture. What about making this more clear? Do we need entries for the whole series? I think it is important for overview. So what about a new structure like "application / version / derived from version(subversion)"? Julian

3 2

lostwages CVS moved into GIT
by Jeremy Newman 11 Sep '07

11 Sep '07

We have switched our website sources (previously known as lostwages), over to git. >From this point on I would prefer if all patches came from the git tree. Refer to the git documentation on the website and wiki on how to prepare patches with git. The git module is called simply "website".

1 0

Re: make_makefiles: ignore .DS_Store files
by Alexandre Julliard 11 Sep '07

11 Sep '07

Emmanuel Maillard <mahanuu(a)free.fr> writes: > From b298a599f2b0eb5b8d7f2092573aba28755001d7 Mon Sep 17 00:00:00 2001 > From: Emmanuel Maillard <mahanuu(a)free.fr> > Date: Sun, 2 Sep 2007 12:42:16 +0200 > Subject: [PATCH] - ignore .DS_Store files You should put that in your global ignore file, the .DS_Store files are not created by the build process so they don't belong in .gitignore. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: WineD3D: PBO support 2/2
by Stefan Dösinger 11 Sep '07

11 Sep '07

Am Dienstag, 11. September 2007 10:25:28 schrieb Roderick Colenbrander: > Hi, > > This patch adds PBO support for dynamicly locked textures. It greatly > improves performance of games that use render target locking a lot. It looks good to me, here are some suggestions for further improvements in further patches(this patch is good for the start). The locking flag passed to LockRect could be forwarded to GL. D3DLOCK_DISCARD and D3DLOCK_WRITEONLY(ddraw only) would be GL_WRITE_ONLY, D3DLOCK_READONLY GL_READ_ONLY. However, we have to take care about the upside down swap for render target locking. D3DLOCK_DISCARD can be implemented(appart of the surface beeing writeonly) by calling glBufferData with a NULL pointer. This tells gl that the old data can be thrown away. This allows the driver to further optimize the map. e.g. if it is a texture that is still used for rendering in some pending calls, it can duplicate the buffer and doesn't have to wait for the rendering to finish. It will have to be tested if that really helps performance. I tried it for vbos, and it made things noticeably worse. Binding the pbo to 0 after each operation is a good idea for a start, but shouldn't be done in the long term in my opinion.

1 0

settlers 3 and dib engine
by Skrzynka 10 Sep '07

10 Sep '07

Hi, I'm trying to get Settlers 3 to run on Wine. After fixing some race condition (seems like the thread calling WaitForXXXObject was giving up time-slice too early after the call) it seems that the only problem left is very slow text output. What I could understand from the forum archives is that with no DIB engine, the rendering into a DC causes copying of the bitmap to/from server (is that correct?). I'd like to contribute to the DIB engine if it's possible/needed, so I'd like to ask about a few things. There were some discussion recently about an implementation of DIB engine by Jesse Allen - what is the status of DIB engine? I compiled winedib.drv but ExtTextOut function is missing there and overall there are regressions visible when running Settlers 3 (wrong colors, no text at all). Which docs/urls/sources would you recommend to read to get some quick introduction to the DIB engine? Which particular functions are making current impl slow? Or, in general: where to start? Sorry for any silly questions... Thanks & regards Piotr -- ----- AlphaNet - najtaniej w sieci! -------- Odnowienia domen w rewelacyjnych cenach! .pl - 65 zl, .com.pl - 50 zl, reg - 20 zl http://www.domeny.alpha.pl --------------------------------------------

4 8

Re: ntdll: Do not segfault with snoop for files with a broken exporttable
by Dmitry Timoshkov 10 Sep '07

10 Sep '07

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > ntdll: Do not segfault with snoop for files with a broken export table > + /* Check for files with broken exports */ > + if (exports->Characteristics || > + exports->MajorVersion || > + HIWORD(exports->NumberOfFunctions) || > + HIWORD(exports->NumberOfNames)) { > + WARN_(snoop)("snoop disabled for bad module %p: 0x%x, %u, 0x%x, 0x%x\n", hmod, > + exports->Characteristics, exports->MajorVersion, > + exports->NumberOfFunctions, exports->NumberOfNames); > + return; > + } > + > TRACE_(snoop)("hmod=%p, name=%s\n", hmod, name); It's still helpful to see the line "hmod=%p, name=%s\n" in the log before an error message. -- Dmitry.

2 1

Re: gdi32: return the correct font type, ntmFlags and PitchAndFamily for Type1 fonts (improved, fixes bug #5877)
by Dmitry Timoshkov 09 Sep '07

09 Sep '07

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote: > As suggested by Dmitry the table id is now a symbolic constant. However > I didn't included the tttags.h but defined the constant myself as I see > that every freetype header is checked by configure and included only if > it is available. Thus in case it is not available we would either need > an #ifdef in AddFileToList (what IMHO wouldn't be nice) or in such a > case define the symbol ourselfs. But if we will need to define the > symbol then why to include the header? > +#define WINEENG_SFNTTAG_CFF 0x43464620 /* stores the outline for Type1 OTF fonts */ This is not what I suggested. Using a macro like FT_MAKE_TAG makes this much more readable. WINEENG_SFNTTAG_CFF doesn't follow any macro naming conventions in freetype.c, I'd suggest to use the same name as FreeType has (TTAG_CFF) instead, perhaps inside of #ifdef guard if including tttags.h is much hassle. Although including tttags.h and using #ifdef before defining TTAG_CFF is much more clean IMO. -- Dmitry.

1 0

[PATCH 2/3] wininet: Use parent/child handle framework to track parent/child handle relationships.
by Misha Koshelev 08 Sep '07

08 Sep '07

Jacek Caban wrote: > Hi Misha, > > Misha Koshelev wrote: > > We have a lot of parent/child relationships in wininet that are addressed on an individual basis. > > Now we can just address them within the framework since we need that framework for closing handles > > too. The only thing I don't like is that we have to make lots of casts now, but it doesn't really make > > much sense to me to store the "parent" object handle in two different places. > > Sorry for late response. > > This patch reverses what I've done some time ago. There is no reason to > have parent object in header - you need only a child list to handle > closing handles. Also casts make the code much less readable. > > Thanks, > Jacek Ok, that sounds fair. I didn't really like the casts either, that was my biggest problem with this patchset. I am leaving the country tomorrow for 9 days but will change the patches/resubmit as you suggested after I come back. Thanks for your comments. Misha

1 0

Re: [PATCH 2/3] wininet: Use parent/child handle framework to track parent/child handle relationships.
by Jacek Caban 08 Sep '07

08 Sep '07

Hi Misha, Misha Koshelev wrote: > We have a lot of parent/child relationships in wininet that are addressed on an individual basis. > Now we can just address them within the framework since we need that framework for closing handles > too. The only thing I don't like is that we have to make lots of casts now, but it doesn't really make > much sense to me to store the "parent" object handle in two different places. Sorry for late response. This patch reverses what I've done some time ago. There is no reason to have parent object in header - you need only a child list to handle closing handles. Also casts make the code much less readable. Thanks, Jacek

1 0

Re: gdi32: return the correct font type, ntmFlags and PitchAndFamily for Type1 fonts (fixes bug #5877)
by Dmitry Timoshkov 08 Sep '07

08 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> wrote: > As I wrote in Bugzilla for Photoshop to work with Type1 fonts after > applying this patch one needs to reinstall Photoshop in a clean > wineprefix - it seems that Photoshop caches some font data. > + /* check for the presence of the 'CFF ' table to check if the font is Type1 */ > + tmp_size = 0; > + if (pFT_Load_Sfnt_Table && !pFT_Load_Sfnt_Table(ft_face, 0x43464620, 0, NULL, &tmp_size)) > + { > + TRACE("Font %s/%p is OTF Type1\n", wine_dbgstr_a(file), font_data_ptr); > + face->ntmFlags = NTM_PS_OPENTYPE; > + } Please use a symbolic name instead of 0x43464620. FreeType provides TTAG_CFF, or you can define it on your own using FT_MAKE_TAG. -- Dmitry.

1 0

Kudos - Fireworks 8 working better...
by Dan Kegel 07 Sep '07

07 Sep '07

http://www.5thpercentile.com/devBlog/archives/2007/09/wine_just_got_t.html and http://appdb.winehq.org/appview.php?iVersionId=4149&iTestingId=15163 both say that wine-0.9.44 really improves Adobe Fireworks. Yay! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: wined3d: add WINED3DPRESENT_INTERVAL_ONE flag (fix bug 9584)
by Stefan Dösinger 07 Sep '07

07 Sep '07

Am Freitag, 7. September 2007 18:29:02 schrieb Louis. Lenders: > I added this initially as a hack to get mame running, but what i understood > from discussion on IRC, there's no way we can check the graphics card's for > this capability now, and adding it as default (so without checking) would > be rather harmless. Short answer: Patch is ok with me Long answer: We can check if opengl supports vsync(which is what this flag does). WineD3D implements vsync using GLX_SGI_video_sync. So if this extension is supported, we should set the flag. If it is not supported, do not set it. Our WGL implementation does not forward the GLX extension yet, so we do not support vsync at the moment, so setting this flag means essentially lying to the app. However, I think it is safe to pretend vsync support. The worst that may happen is that the game renders with a higher framerate, and the hardware consumes more power instead of beeing idle. I think both cases are better then not running the game at all. There's one game which runs into internal race conditions if vsync does not work(need for speed 3), but that game doesn't even care to check that flag.

1 0

build problem on amd64
by Dave Phillips 07 Sep '07

07 Sep '07

Greetings, I hope I have the right list. I'm trying to build Wine 0.9.44 under 64Studio, a Debian-based distribution. CPU is an AMD64, GCC is 4.1.2. Configure and make depend report no errors (btw, I ran a simple ./configure, no options), but when I run make I receive these errors : gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -D__i386__ -o interlocked.o interlocked.c {standard input}: Assembler messages: {standard input}:38: Error: suffix or operands invalid for `push' {standard input}:39: Error: suffix or operands invalid for `push' {standard input}:46: Error: suffix or operands invalid for `pop' {standard input}:47: Error: suffix or operands invalid for `pop' make[2]: *** [interlocked.o] Error 1 make[2]: Leaving directory `/home/dlphilp/src/wine-0.9.44/libs/port' make[1]: *** [port] Error 2 make[1]: Leaving directory `/home/dlphilp/src/wine-0.9.44/libs' make: *** [libs] Error 2 Is there a fix for this problem ? Please advise, thanks. Best regards, Dave Phillips

1 0

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite
by Dmitry Timoshkov 07 Sep '07

07 Sep '07

"Vincent Povirk" <madewokherd(a)gmail.com> wrote: > fixes bug 9523, Knytt Stories installer fails > +/*********************************************************************** > + * SHPathPrepareForWriteA (SHELL32.@) > + */ > +HRESULT WINAPI SHPathPrepareForWriteA(HWND hwnd, IUnknown *modless, LPCSTR path, DWORD flags) > +{ > + WCHAR wpath[MAX_PATH]; > + MultiByteToWideChar( CP_ACP, 0, path, -1, wpath, MAX_PATH); > + return SHPathPrepareForWriteW(hwnd, modless, wpath, flags); You are still using a buffer of a fixed size. > + /* cut off filename if necessary */ > + if (flags & SHPPFW_IGNOREFILENAME) > + { > + last_slash = StrRChrW(path, NULL, '\\'); StrRChrW is a shlwapi export. Since shlwapi.dll is just mostly a wrapper/helper, and it imports shell32, that would create a circular dependency. I already suggested to use strrchrW here. > + temppath = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + if (!temppath) > + return E_OUTOFMEMORY; > + StrCpyNW(temppath, path, len); Again StrCpyNW is a shlwapi export, and since you just allocated the buffer of correct length memcpy + adding an explicit '\0' terminator look more naturally here (if not kernel32.lstrcpynW). > + /* try to create the directory if asked to */ > + if (flags & (SHPPFW_DIRCREATE|SHPPFW_ASKDIRCREATE)) > + { > + if (flags & SHPPFW_ASKDIRCREATE) > + FIXME("treating SHPPFW_ASKDIRCREATE as SHPPFW_DIRCREATE\n"); > + > + SHCreateDirectoryExW(0, realpath, NULL); > + } You are still not checking SHCreateDirectoryExW return value. > + if (temppath) > + HeapFree(GetProcessHeap(), 0, temppath); There is no need to check temppath for NULL before HeapFree call. -- Dmitry.

3 3

re: nhelp, Vector NTI, molecular biologists
by Dan Kegel 07 Sep '07

07 Sep '07

Misha wrote: > and even my version of Windows 98 is bundled with mfc42.dll, so wine really should > provide it too... [our own version, not Microsoft's.] Well, sure. Same goes for a lot of things. But since mfc42.dll is a Visual C++ runtime file that has very liberal redistribution terms and is in fact bundled with many apps, we can get away without it for a long time. And it's not currently a showstopper as far as I can tell; I'm more interested in the bugs that keep e.g. Photoshop from running flawlessly. So one of these days it might become a priority. Until then, it's merely important but not urgent. - Dan

6 5

Re: ddraw/tests: Check deviceGUID of enumerated devices.
by Stefan Dösinger 07 Sep '07

07 Sep '07

Am Donnerstag, 6. September 2007 16:02:59 schrieb David Hedberg: > This patch adds tests to check the devices enumerated by > IDirect3D7_EnumDevices . At least two games rely on the behavior > tested by one of the test in this patch. If wine behaves incorrectly and your test fails on wine, you have to send a fix before or in the same patch as the test. Alexandre has some scripts that run the conformance tests after each patch and refuses all patches that cause in test failures. If you do not know how to fix the bug, or want to keep it unfixed for some other reason(e.g. the incorrect behavior is hard to fix and considered harmless), then you can mark the test as todo_wine. Then the tests script will ignore failures in the test. However, Alexandre will drop a note and ask for further explanation if a test marked todo_wine succeeds(e.g. we had a test that succeeded or failed for some time based on the features graphics driver). todo_wine test(2 + 2 == 3.99998, "This is my test marked as TODO\n"); /* Microsoft does something insane here */ Other things: + if(!memcmp(&lpdd7->deviceGUID, &IID_IDirect3DRGBDevice, sizeof(IID_IDirect3DRGBDevice))) You can use IsEqualGUID here. Sorry for not spotting this earlier. + IDirect3D7_EnumDevices(lpD3D, (LPD3DENUMDEVICESCALLBACK7) enumDevicesCallbackTest7, &d3d7et); To get more compiler checks, you shouldn't cast the function to the right type, but use void *d3d7et, and cast it to the right pointer in your function. Debugging a wrong function pointer is a nasty thing ;-)

2 2

Re: gdi32[3/3]: if freetype fails try to load manually fonts wrapped asPE resources
by Dmitry Timoshkov 07 Sep '07

07 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> wrote: > This is some overlap with freetype as freetype 2.3.5 can load fonts > from PE resources. But the code is so small (we have all the tools > needed) and helps many programs (including working around the > Photoshop Z-order problem during startup as now the dialogs doesn't > show) that I thought it is useful. Then there is no point in using FreeType for loading font files at all, (or adding support for new font file formats to FreeType) since FreeType can load fonts from memory. > + TRACE("WineEndAddFontResourceEx failed on PE file %s - trying to load resources manualy\n", > + wine_dbgstr_w(str)); > + if (EnumResourceNamesW(hModule, rt_font, load_enumed_resource, (LONG_PTR)&num_resources)) This code snippet causes a stack corruption since load_enumed_resource has wrong calling convention. I wonder whether gcc issued a warning here. -- Dmitry.

2 4

RE: problem with silly CreateBitmap call
by Rolf Kalbermatter 06 Sep '07

06 Sep '07

Deun wrote on Thursday, September 06, 2007 10:40 AM >trace:x11drv:X11DRV_CreateBitmap (0xed4) 2147483646x2147483646 >1 bpp >X Error of failed request: BadAlloc (insufficient resources for operation) > Major opcode of failed request: 53 (X_CreatePixmap) > Serial number of failed request: 3155 > Current serial number in output stream: 3163 > >This occured after an attempt to load a bmp file that can't be found anywhere. > >The size of the bitmap seems crazy... So I've made a patch to fix this in >bitmap.c by setting 1x1 size in case of stupid input instead of failing with >BadAlloc. However, since it works fine on real windows, so I'm not sure about >the behaviour that the function should have. However this patch let me run >the game now : First your patch is not very useful as the diff was run from inside the directory where the two files where, instead of from the main wine directory. So the patch does not contain the necessary full project path for the patch maintainer to apply It without guessing, which he won't do without some very compelling reasons. But the more serious problem is that it is really just a hack and as such won't get into wine. Trapping on some arbitrary size is not an acceptable patch for Wine. Instead the root cause should be found. Since you say that this comes from trying to load a bitmap that can be nowhere found I wonder if this is the result of some unitialized structures that result in garbage but somehow the loading is not aborted with an error for whatever reasons but just passed further to X11DRV_CreateBitmap with whatever garbage happened to be in memory and here probably on the stack. I see two possibilities and they both are likely to be fixed in the actual caller of X11DRV_CreateBitmap instead of in this function itself: 1) Wine code has a bug and should not ever attempt to call X11DRV to create the bitmap after it couldn't find the according file on disk to initialize the bitmap members. Instead that function should just return to the caller with an error. 2) Windows allows to load a nonexisting bitmap file and returns in that case a default bitmap, brush or whatever without causing an error. In that case the structure should be either initialized to some meaningful values like a 0 * 0 or 1 * 1 bitmap before attempting to load the file from disk and when the load fails just fall through to create that default bitmap or on failure of the loading some special code needs to be executed to create whatever Windows returns here. So in any case I think you need to figure out from which function exactly X11DRV_CreateBitmap is called with these silly parameters and concentrate on fixing that one instead. Your patch is still very likely to crash on a 0x7e000000 * 0x7e000000 bitmap and therefore didn't adress the root cause of this problem. Not knowing anything about the stack trace it is completely impossible for anyone not running that application to look for the likely cause of this problem as there are quite a few functions in Wine that call X11DRV_CreateBitmap somewhere and somehow. Rolf Kalbermatter

3 2

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite
by Dmitry Timoshkov 06 Sep '07

06 Sep '07

"Vincent Povirk" <madewokherd(a)gmail.com> wrote: > HRESULT WINAPI SHPathPrepareForWriteA(HWND hwnd, IUnknown *modless, LPCSTR path, DWORD flags) > { > - FIXME("%p %p %s 0x%08x\n", hwnd, modless, debugstr_a(path), flags); > - return S_OK; > + WCHAR wpath[MAX_PATH]; > + MultiByteToWideChar( CP_ACP, 0, path, -1, wpath, MAX_PATH); > + return SHPathPrepareForWriteW(hwnd, modless, wpath, flags); It's better to not use fixed buffer sizes but allocate the buffer dynamically. > + /* make a copy of the path so we can cut off the filename */ > + for (i=0; i<MAX_PATH; i++) > + { > + realpath[i] = path[i]; > + if (path[i] == '\\') > + last_slash = i; > + else if (path[i] == 0) > + break; > + } > + realpath[MAX_PATH-1] = 0; > + > + if (flags & SHPPFW_IGNOREFILENAME) > + realpath[last_slash] = 0; If the job must be done only when SHPPFW_IGNOREFILENAME is specified then don't do it in all cases. And using strrchrW would simplify the code a bit. > + /* try to create the directory if asked to */ > + if (flags & (SHPPFW_DIRCREATE|SHPPFW_ASKDIRCREATE)) > + { > + if (flags & SHPPFW_ASKDIRCREATE) > + FIXME("treating SHPPFW_ASKDIRCREATE as SHPPFW_DIRCREATE\n"); > + > + SHCreateDirectoryExW(0, realpath, NULL); > + } Why there is no check for SHCreateDirectoryExW return value? > + > + /* check if we can access the directory */ > + res = GetFileAttributesW(realpath); > + > + if (res == INVALID_FILE_ATTRIBUTES) > + { > + err = GetLastError(); > + if (err == ERROR_FILE_NOT_FOUND) > + err = ERROR_PATH_NOT_FOUND; > + return HRESULT_FROM_WIN32(err); > + } > + else if (res & FILE_ATTRIBUTE_DIRECTORY) > + return S_OK; > + else > + return 0x8007010b; 0x10b == 267, therefore 0x8007010b is HRESULT_FROM_WIN32(ERROR_DIRECTORY) > --- a/dlls/shell32/tests/shpathprep.c > +++ b/dlls/shell32/tests/shpathprep.c > @@ -82,27 +82,27 @@ START_TEST(shpathprep) > ok(res == S_OK, "res == 0x%08x\n", res); > > res = SHPathPrepareForWriteA(0, 0, "c:\\testdir\\nonexistent", SHPPFW_NONE); > - todo_wine ok(res == 0x80070003, "res == 0x%08x\n", res); > + ok(res == 0x80070003, "res == 0x%08x\n", res); Please use above and in other places symbolic error names instead of hex, and print expected and received codes to make life easier for those who looks at the (failing) test results without looking at the source. For some reason your mailer attaches the patch in text and html formats, it would save some time/traffic by avoiding html in wine-patches. -- Dmitry.

2 6

WineHQ Upgrade Downtime
by Jeremy Newman 06 Sep '07

06 Sep '07

On Wednesday Sept 12 at 14:00 US Central Time, we will be taking all of WineHQ offline for maintenance and upgrades. The server itself will offline for about an hour. Some services will be offline longer than that as we adjust/fix them to the upgraded server.

1 0

Wine on 64bit system crashes (critical)
by Roderick Colenbrander 06 Sep '07

06 Sep '07

Hi, One of my development machines is a dualcore Athlon64 using a 64bit version of Debian. I have been using this system for months and it always worked fine. Since I hadn't used the system during the summer it contained an older Wine version. I have upgraded it to the latest GIT version and Wine doesn't work anymore. It doesn't just crash, but it locks up the whole system. I have no idea what causes it. I for instance ran Wine some time before as root (I really had to be root at that time) and for the root user it didn't lock up until I wanted to run a fresh .wine directory. I can't really test what caused it as testing this takes a lot of time and I can't use a bad filesystem or so on this system. On irc a ubuntu64 user said he had similar problems using Wine 0.9.44 but for him it 'only' segfaulted. Perhaps there is a connection between the problems. Has anyone recently seen problems like this? It prevents me from playing with Wine code at the moment. Roderick -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

2 3

Re: problem with silly CreateBitmap call
by Jesse Allen 06 Sep '07

06 Sep '07

On 9/6/07, Deun <deun76(a)yahoo.com> wrote: > Hi, > > I've tried the free-to-play MMORPG game called Perfect World ( > http://perfect-w.jp ) with wine 0.9.44 and it installs fine. > However, when running it often crashed with the following error > in the x11drv traces : > > trace:x11drv:X11DRV_CreateBitmap (0xed4) 2147483646x2147483646 > 1 bpp > X Error of failed request: BadAlloc (insufficient resources > for operation) > Major opcode of failed request: 53 (X_CreatePixmap) > Serial number of failed request: 3155 > Current serial number in output stream: 3163 > > This occured after an attempt to load a bmp file that can't be > found anywhere. > > The size of the bitmap seems crazy... So I've made a patch to > fix this in bitmap.c by setting 1x1 size in case of stupid > input instead of failing with BadAlloc. However, since it works > fine on real windows, so I'm not sure about the behaviour that > the function should have. Look at the +bitmap debug channel, or others and trace to the original call's parameters. Figure out how the app is wanting to create the bitmap and write a test case for it and test on windows and wine. Jesse

1 0

Re: olethk32.dll
by Juan Lang 06 Sep '07

06 Sep '07

Hi Stefan, + if (fdwReason == DLL_PROCESS_ATTACH) + DisableThreadLibraryCalls(hinstDLL); + + return TRUE; You should probably add a DLL_WINE_PREATTACH case that returns FALSE. --Juan

1 0

IDirect3DImpl_EnumDevices only enumerating IID_IDirect3DTnLHalDevice
by David Hedberg 06 Sep '07

06 Sep '07

Hi, I've been tracking down the reason for bug 7993 ( http://bugs.winehq.org/show_bug.cgi?id=7993 , "Delta Force Land Warrior 1.31 -> Can't find 3D Video Card" ), and I think I've found it. It appears as if the EnumDevices callback in Delta Force for some reason discards all devices with a GUID of IID_IDirect3DTnLHalDevice, thus discarding the only device enumerated by wine. This is "easily" checked (and bypassed) by searching for and altering the IID_IDirect3DTnLHalDevice value used in the check (78 9E 04 F5 (..) ) in the delta force executable. While this works as a "fix", it's obviously not a good one. In my (somewhat limited and at the moment not doublechecked) understanding, windows "always" returns (at least) two devices, one reporting T&L capable and one not. So I am wondering how one would implement a proper fix for this in wine. Fixing this together with applying (or otherwise fixing the issue highlighted in) the patch at http://flodaby.ath.cx/~david/0001-ddraw-fix-cases-where-desc2.u2.dwMipMapCo… (also sent to wine-patches), would enable both Delta Force Land Warrior and Delta Force Task Force Dagger to run great with wine. David

2 4

Re: winhelp, Vector NTI, molecular biologists
by Misha Koshelev 06 Sep '07

06 Sep '07

On 9/4/07, Alexander Sornes wrote: > Tirsdag 04 september 2007 03:17, skrev Misha Koshelev: > > On 9/3/07, Stefan Dosinger wrote: > > > Am Montag, 3. September 2007 13:30:57 schrieb Damjan Jovanovic: > > > > Somebody needs to make a do-nothing-useful app, intended for Windows, > > > > that also installs on wine and supplies each and every DLL that > > > > Windows applications need but we don't have in wine (like MFC42.DLL, > > > > the D3DX9_xx.DLL's, new MSVCRT's, etc.). That way we can legally use > > > > those DLLs without a Windows licence. > > > > > > This is not necessarily true. I don't know about MFC42.dll or the > > > msvcrts, but the directx eula does not allow that; It requires the > > > application to run only on the Microsoft Windows operating system, > > > targetting both Windows and Linux+Wine violates the contract. These are > > > the conditions for distributing the directx dlls. I've not found anything > > > against installing them on Wine, you just must not distribute the DLLs > > > with an app that targets both Windows and Wine. Thus I think it's legal > > > to write a script that downloads them from the original location > > > @microsoft.com and installs them, as long as that script isn't bundled > > > with the dlls. However, IANAL. > > > > > > What remains unanswered though is how this affects game vendors whose > > > games run on Wine without intention from the game vendor and ship the > > > dlls, e.g. Eve Online. > > > > Actually you all bring up rather interesting points with regards to Vector > > NTI as: > > > > (a) It pretty much ships with almost every Microsoft redistributable needed > > (e.g., MDAC, Windows Script, MFC71, etc.) and installs them on its > > installation _except_ MFC42 (not sure why this oversight and if this would > > break it on some native system, although I _believe_ it installed correctly > > on my plain vanilla Win98 VMWare installation, but I would have to double > > check for sure). > > > > I believe mfc42 is bundled with Windows XP. Actually, I just reinstalled Windows 98 in VMWare _without_ installing VMWare tools and even my version of Windows 98 is bundled with mfc42.dll, so wine really should provide it too... > > > (b) If the licenses for those DLLs/redistributables are the same as you > > suggest for DirectX, this would mean they couldn't ever say they support > > Wine (but I'm not sure whether or not the licenses are). Anyway, seeing it > > work "gold" on Wine still wouldn't be a bad thing in either case and > > certainly Vector NTI is not the only program that needs good winhelp > > support. > > > > Misha > Misha

1 1

Would also like to contribute to Wine
by Reece Dunn 05 Sep '07

05 Sep '07

I am interested in the Wine project, and my manager at work has accepted my request to work on it. I work for a company that develops Windows software, so as I have access to Visual Studio, and thus the sources for ATL, MFC and the msvc runtime (provided with the full version of Visual Studio), I state that I will not participate in the development of these components. I have not seen, and do not intend on seeing, any of the Windows source code. I am interested in the following. 1. Writing tests for various parts of Wine, initially the RECT API. I know that this is a simple API, but even the simplest API needs tests. I will expand on this set as time permits. Is it possible for me to write tests for ATL and/or the msvc runtime, as this is not implementing those API? 2. Investigating the failing tests (e.g. the new, unknown message in the monthcal tests on Vista) and how to fix them properly. 3. Improve the user32/comctl32 controls. I would like to address the outstanding issues with these if I can. 4. Microsoft Active Accessibility (MSAA)/User Interface Automation (UIA). I would like to get this working with the various Linux accessibility API, so that more people will have access to Windows applications running on Linux+Wine. 5. Microsoft Text-To-Speech API (part of the sapi DLL). This is on my wishlist and is likely beyond my capabilities to get working. It is used by applications like Dragon Naturally Speaking and Cepstral SwiftTalker. Here, there is supporting voices installed on Windows that use the SAPI interface directly, and voices installed on Linux that implement different APIs. 6. Get theming working with the user32 controls and Window frames. Get the theming support working with GNOME themes as well. 7. Anything else I can think of. I would be interested in improving Wine to help get more applications running on Wine. Does anyone know if there are some common things that are holding Wine up, or is it more a per-application problem as each application is hitting different problems in Wine? - Reece

5 6

The Sims - some hacks
by Trent Waddington 05 Sep '07

05 Sep '07

Attached is a patch for some hacks that will get The Sims to run and not crash (for a while). First, there's the easy problem of the cursors not working. This is because Sims.exe calls LoadCursorFromFile on a bunch of files that contain icons, not cursors. As the only difference between the two is that the cursor has a hotspot in front of it, I added some code to treat the icon as a cursor with no hotspot. Other programs may benefit from this patch, as it seems it is something you can get away with on Windows. Then there's the problem of the actual crash. This is caused by CreateSurface in ddraw returning an error and Sims.exe doesn't check for the error. It is returning an error because Sims.exe is trying to create a depth buffer without specifying a valid pixelformat. Note that it actually does pass a pixelformat, it's just all zeros, except for the dwSize member. Again, this appears to be something you can get away with on Windows.. the pixelformat defaults to the current screen format. Once these patches are applied there are significant problems with the game. Minor: the company logo flashes and won't go away without a mouse click. Minor: the scrolling text of pointless terms sometimes overlaps itself Annoyance: there seems to be some blitting error on the "neighborhood" screen that results in parts of the splash screen not being overwritten. Major: the characters in the game are not redrawn correctly, and eventually, it will crash. Overall result: not playable. If someone with a better understanding of wined3d code could have a look, I'd love to receive some hints on what could be causing these issues. Thanks, Trent

3 2

Fwd: Phoronix Forums: AMD Linux Announcement
by Dan Kegel 05 Sep '07

05 Sep '07

Say, maybe these new drivers won't crash with Wine a la http://wiki.winehq.org/fglrx Wouldn't that be sweet? ---------- Forwarded message ---------- From: phoronix-forums(a)phoronix.com <phoronix-forums(a)phoronix.com> Date: Sep 4, 2007 9:15 PM Subject: Phoronix Forums: AMD Linux Announcement ... We also wanted to let you know that Advanced Micro Devices has officially announced their new Linux driver this morning, which is a overhaul of their existing Linux graphics driver. The AMD fglrx 8.41 (Catalyst 7.9) driver introduces Radeon HD 2000 "R600" support as well as massive performance improvements for all supported generations of ATI graphics processors. This new driver is not available today, but it will be made available within the next week. Though at Phoronix we have been using and testing this new driver now for a number of weeks. Below are the articles we have just published today about this new ATI/AMD Linux driver. AMD 8.41 Display Driver Preview -- Our first article on this new driver are simply the technical details such as noting this driver has been actually in development for over a year, the AIGLX support that is coming next month, and other relevant information. Read More: http://www.phoronix.com/vr.php?view=10955 ATI R300/400 Linux Performance -- We re-tested the Radeon X300 and X800XL with this new driver and it offers some HUGE performance improvements! The Mobility Radeon X300 was as much as 54 times faster compared to the previous ATI Linux driver. The improvements in these older ATI GPUs are simply astonishing. Read More: http://www.phoronix.com/vr.php?view=10964 ATI R500 Linux Performance -- With an X1300PRO, X1800XL, X1800XT, and X1950PRO in hand we compared the ATI 8.40 and 8.41 display drivers. The performance improvements for the Radeon X1000 series range from 50% to 90% faster. Read More: http://www.phoronix.com/vr.php?view=10970 ATI Radeon HD 2900XT Linux Performance -- Four months after the Radeon HD 2900XT was introduced there is finally proper Linux support! Not only is there support, but it offers a pretty darn good level of performance. In fact, the ATI Radeon HD 2900XT offers the best bang for the buck when it comes to high-end graphics cards. There is also more on the R600 support in general inside this article. Read More: http://www.phoronix.com/vr.php?view=10973 AMD: Accelerating Open-Source Drivers? -- Not today, but in the near future AMD will be making an announcement about accelerating efforts within the open-source community. What does this mean? Open-Source ATI Drivers? We will tell you in due time. Read More: http://www.phoronix.com/vr.php?view=10977 At Phoronix we also have a number of other articles we will be publishing in the near future pertaining to this new driver and the Radeon HD 2000 series support. Be sure to check out the latest articles and join in on the discussions in the Phoronix Forums! Best, The Phoronix Staff

2 1

osalt.com top-requested commercial app stats
by Dan Kegel 05 Sep '07

05 Sep '07

http://www.osalt.com/ has a list of most-requested commercial windows apps, currently: 1. Visio 2. Norton Ghost 3. Photoshop 4. Nero Burning Rom 5. Dreamweaver 6. AutoCAD 7. Illustrator 8. Access 9. Premiere Pro 10. ACDSee No idea how they generated that list, but it seems somewhat reasonable. cc'ing them in case they feel like commenting on where that list comes from and what it means. (And no, I don't think Ghost will ever run on Wine :-) - Dan

7 7

Re: comctl32: TCM_SETCURSEL also updates the focus item
by Reece Dunn 05 Sep '07

05 Sep '07

On 04/09/07, Aric Stewart <aric(a)codeweavers.com> wrote: > --- > dlls/comctl32/tab.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Do you have a test for this? - Reece

2 1

Re: RFC: winealsa.drv: fix memory leak (found by Smatch)
by Michael Stefaniuc 04 Sep '07

04 Sep '07

Hello Lionel, the patch has different problems: - lpNewData is used only in "case MOD_MIDIPORT" so moving the HeapAlloc call there makes more sense. - Please keep the indentation level of the surrounding code; here it is 4. - Tabs are 8 spaces. Lionel_Debroux wrote: > modLongData leaks some heap memory in three error paths. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > While looking at the function, I noticed > if (lpNewData) > HeapFree(GetProcessHeap(), 0, lpData); > at lines 1015-1016. > I think "lpData" should be "lpNewData", because this function allocates > "lpNewData", not "lpData" which is passed to the function through a > LPMIDIHDR structure. > So I added a FIXME, and I am asking for comments/corrections :-) lpNewData is allocated only if lpData has a wrong start/end byte in the header. It is passed on in that case instead of lpData. If the functions to which it is passed on process the data asynchronous then the current code is correct: the caller cannot free the data (lpNewData) as the callee might still need to process it whereas lpData is unused and can be freed. The "event" name suggests an asynchronous processing of the data but that's only a guess as i don't know the code. bye michael > > 2007-08-31 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/winealsa.drv/midi.c: > winealsa.drv: fix memory leak (found by Smatch) > > > ------------------------------------------------------------------------ > >>From e148279419c180bd3db1b8b1a61f737bd92c73be Mon Sep 17 00:00:00 2001 > From: Lionel Debroux <lionel_debroux(a)yahoo.fr> > Date: Fri, 31 Aug 2007 14:33:40 +0200 > Subject: winealsa.drv: fix memory leak (found by Smatch). > > --- > dlls/winealsa.drv/midi.c | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c > index f5e98ed..2cf9287 100644 > --- a/dlls/winealsa.drv/midi.c > +++ b/dlls/winealsa.drv/midi.c > @@ -1013,20 +1013,26 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > snd_seq_ev_set_sysex(&event, lpMidiHdr->dwBufferLength + len_add, lpNewData ? lpNewData : lpData); > snd_seq_event_output_direct(midiSeq, &event); > if (lpNewData) > - HeapFree(GetProcessHeap(), 0, lpData); > + HeapFree(GetProcessHeap(), 0, lpData); /* FIXME: lpNewData instead of lpData ? */ > break; > default: > WARN("Technology not supported (yet) %d !\n", > MidiOutDev[wDevID].caps.wTechnology); > - return MMSYSERR_NOTENABLED; > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > + return MMSYSERR_NOTENABLED; > } > > lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; > lpMidiHdr->dwFlags |= MHDR_DONE; > if (MIDI_NotifyClient(wDevID, MOM_DONE, (DWORD)lpMidiHdr, 0L) != MMSYSERR_NOERROR) { > WARN("can't notify client !\n"); > - return MMSYSERR_INVALPARAM; > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > + return MMSYSERR_INVALPARAM; > } > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > return MMSYSERR_NOERROR; > } > > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

1 0

Re: dinput: Add evdev mouse driver.
by Stefan Dösinger 04 Sep '07

04 Sep '07

Hi, > This is the first fully working implementation of dinput mouse using evdev > generic input driver. I have enabled this driver by default. If people do > not have functioning HAL or that for some reasons it can't find the mouse > device, it will fall-back to current mouse driver. > > Use explorer to enumerate all mice devices. Unfortunately msdn says there > can only be one system pointer device. I was curious if that patch fixes Empire Earth, so I tried it, but it fails to create a new evdev mouse and falls back to the x11 based mouse. It seems that HKEY_LOCAL_MACHINE\HARDWARE\DeviceMap\PointerClass does not exist. I've run wineprefixcreate and made sure I have full access to /dev/input/*, do I need anything else?

2 2

Re: winhelp, Vector NTI, molecular biologists
by Misha Koshelev 04 Sep '07

04 Sep '07

On 9/3/07, Stefan Dosinger wrote: > Am Montag, 3. September 2007 13:30:57 schrieb Damjan Jovanovic: > > Somebody needs to make a do-nothing-useful app, intended for Windows, > > that also installs on wine and supplies each and every DLL that > > Windows applications need but we don't have in wine (like MFC42.DLL, > > the D3DX9_xx.DLL's, new MSVCRT's, etc.). That way we can legally use > > those DLLs without a Windows licence. > This is not necessarily true. I don't know about MFC42.dll or the msvcrts, but > the directx eula does not allow that; It requires the application to run only > on the Microsoft Windows operating system, targetting both Windows and > Linux+Wine violates the contract. These are the conditions for distributing > the directx dlls. I've not found anything against installing them on Wine, > you just must not distribute the DLLs with an app that targets both Windows > and Wine. Thus I think it's legal to write a script that downloads them from > the original location @microsoft.com and installs them, as long as that > script isn't bundled with the dlls. However, IANAL. > > What remains unanswered though is how this affects game vendors whose games > run on Wine without intention from the game vendor and ship the dlls, e.g. > Eve Online. Actually you all bring up rather interesting points with regards to Vector NTI as: (a) It pretty much ships with almost every Microsoft redistributable needed (e.g., MDAC, Windows Script, MFC71, etc.) and installs them on its installation _except_ MFC42 (not sure why this oversight and if this would break it on some native system, although I _believe_ it installed correctly on my plain vanilla Win98 VMWare installation, but I would have to double check for sure). (b) If the licenses for those DLLs/redistributables are the same as you suggest for DirectX, this would mean they couldn't ever say they support Wine (but I'm not sure whether or not the licenses are). Anyway, seeing it work "gold" on Wine still wouldn't be a bad thing in either case and certainly Vector NTI is not the only program that needs good winhelp support. Misha

3 3

Monster and Me in wine
by Nguyễn Thành Trung 04 Sep '07

04 Sep '07

Hi ! I'm playing Monster and Me (www.monsterandme.com) in wine. In wine 0.9.7, there's a small bug when login, but every else work fine. In other newer versions of wine, login screen works fine, the game's performance is better - nearly like in windows. But there's a bug when talking with NPC make me can't play this game. Can any 1 find and fix this plz? Thanks !

2 1

re: Would like to contribute to wine
by Dan Kegel 04 Sep '07

04 Sep '07

Maciej wrote: > I'm looking for subject for my Master's thesis. It might be interesting to > do something useful for Wine. A few things you could help finish: 1) widl, Wine's IDL compiler. Dan Hipschman has been improving widl for some time, but his internship is up in a couple months, and I'm sure he'd love some help. 2) crypt32 / wintrust. Lots of apps need these. Juan Lang has been working on these this summer, but his internship is up at the end of the month, and I'll bet he has a big todo list. 3) gdiplus. Evan Stade did a great job getting this going, and several apps that need it now run, but there's lots left to do. 4) msvcrt. Believe it or not, our bugzilla lists 21 or so bugs against the C runtime library. You'd think we'd have that finished by now, but no. 5) wintab, i.e. the library and service that lets Tablet PC apps run. John Klehm got started on that this summer, but wasn't able to get the event sink demo app running. All of the above would probably be fun, and all have the property that you could make useful progress in a month or two. I'm sure there are lots of other ideas... - Dan

2 1

Re: shlwapi: Duplicate shell32.ShellMessageBoxW implementation in shlwapi.ShellMessageBoxWrapW
by Reece Dunn 04 Sep '07

04 Sep '07

On 04/09/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Hello, > > as Alexandre pointed out we can't really forward shlwapi.ShellMessageBoxWrapW > to shell32.ShellMessageBoxW, we need to duplicate its implementation. Is it possible to add a function to libwine that contains this code and then forward both these API to that one? Then you don't have the code duplication. - Reece

2 1

re: winhelp, Vector NTI, molecular biologists
by Dan Kegel 04 Sep '07

04 Sep '07

Damjan wrote: > Somebody needs to make a do-nothing-useful app, intended for Windows, > that also installs on wine and supplies each and every DLL that > Windows applications need but we don't have in wine (like MFC42.DLL, > the D3DX9_xx.DLL's, new MSVCRT's, etc.). That way we can legally use > those DLLs without a Windows licence. Ah, but look at the EULA. For instance, the Visual C++ 6 EULA http://kegel.com/wine/isv/visual-studio-6-EULA.html says in section 4.1 that any app that redistributes its redistributables has to add "significant and primary functionality". Thus a do-nothing app would probably not satisfy the EULA, but a fun game might. So, rather than creating such an app yourself, it might be better to go look for existing freely distributed apps (preferably from Microsoft!) which already do this. For instance, Word Viewer 97 from MS has a very liberal EULA that allows free redistribution, and providesl DOCOBJ.DLL (required for Dragon Naturally Speaking) and tahoma font. There are probably several similar apps from Microsoft with unlimited redistribution that happen to bundle mfc40 and mfc42. No reason we couldn't put those apps up on winehq.org, and add an easy way in Wine to download the Popular Application Pack or something like that. - Dan

1 0

winhelp, Vector NTI, molecular biologists
by Misha Koshelev 03 Sep '07

03 Sep '07

Hi everybody, So as you all know I've been working on various bug fixes throughout wine, with my most significant contributions to date being MSI OLE automation support and implementation of http protocol support in urlmon. This involvement was driven by my initial experiences of getting a key program used by molecular biologists, Invitrogen's Vector NTI, to install on wine with a fairly convoluted shell script and submitting my first patch to fix a crash with this program; Dan Kegel helped me iron out this first patch a lot and furthermore his comments about how it'd be nice if such a complicated shell script was not necessary with wine got me started with my other patches and the rest, as they say, is history. So why, you may ask, am I sending all this in an email to wine-devel? The short answer is that this is a shameless email to see if I might motivate someone to work on our winhelp implementation a bit, as it is currently completely useless with Vector NTI. This seems like a fairly significant task, and my obligations at school/work have recently kicked up quite a bit, making it unlikely I will be able to take it on anytime soon. However, I hope to motivate someone with these reasons: (i) I feel like I've certainly been doing (and will continue to do) my part in helping out wine, and if this in any case motivates someone looking for a development direction I would certainly not object; and (ii) My ultimate vision/goal has been to have Vector NTI run so well that I could approach Invitrogen and see if they might at the very least say something to that effect on their Web site ("add wine + linux as a supported platform"), if not package Vector NTI a la Google Picassa, which would be great publicity for wine. Also, as you can see from the comments on my ubuntuforums howto http://ubuntuforums.org/showthread.php?t=347095 for a lot of molecular biologists, Vector NTI is the only reason they have to dual-boot/use VMWare at all (full-disclaimer: this is not 100% true for myself). So you could help perhaps a fairly small but non-insignificant group of people by doing some work on winhelp. Although Vector NTI is a rather large set of programs, currently I believe the only things keeping it from installing/working to a "gold" level according to winehq definitions are (i) winhelp and (ii) either MFC42 implementation (required for WSH to install properly; I suppose only a few functions prob are really required, but I'm not sure how good an idea having a very small stub MFC42 would be) or JScript support in wine. Either item in (ii) seems like a very significant undertaking, but (i) seems doable and prob. necessary for a lot of apps. So anyhow just my attempt to influence someone to start working on winhelp. Sorry for cluttering your inboxes. Misha

4 4

Re: dsound: Runtime link to advapi32 RegDeleteTree
by Reece Dunn 03 Sep '07

03 Sep '07

Correct me if I am wrong on this, but I have a few questions. And I apologise if I ask some stupid questions, as I don't understand how the Wine loader works. On 01/09/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Makes the dsound dll work in windows xp and older versions of windows > again. By this, do you mean running the Wine dsound.dll on _native_ Windows? > It is the least of all evils as far as I could see. It's either > this or adding RegDeleteTree to libwine, unless someone has a third option. If the intent is to get this working on native, adding RegDeleteTree to libwine will not help. Unless you mean running Wine in Windows XP or earlier compatibility mode? If so, I was under the assumption that all the API were available to Wine, it was just the reported OS version that differed. I say this, because none of the Windows headers vary on OS version like the Windows SDK does. Even so, since the RegDeleteTree API are queried for by GetProcAddress, this means that they will not be found on WinXP and earlier, so DllUnregisterServer will fail on those platforms, leaving behind the dsound GUIDs on those platforms. This is bad practice, but I don't see how else this will work (assuming that these are run on native). > +static typeof(RegDeleteTreeW) * pRegDeleteTreeW; Is it common practice in Wine to use typeof? I was under the assumption that this was limited to the gcc C++ compiler. Even if it is available in the C compiler, it is not portable to compilers that don't support that, such as pre-typeof gcc compilers. - Reece

2 2

Hmm. Cider and the LGPL
by Dan Kegel 03 Sep '07

03 Sep '07

http://www.linux-community.de/story?storyid=23294 and http://www.macnews.de/news/102145.html mention that some users are using Cider from one game to run a second game on the Mac. The game vendors are upset, and are saying they'll do something to make that harder. There is some question about whether Cider includes LGPL components of Wine, and whether there are any violations lurking there. I imagine our friends at Cedega would instinctively avoid such infringement, but accidents might happen. It'll be interesting to see if anybody finds a real problem. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

6 7

UbiSoft giving away games
by Michael Lothian 03 Sep '07

03 Sep '07

Hi Just thought I'd share this with you all. http://www.theinquirer.net/default.aspx?article=42069 For those of you that haven't heard I know FarCry works with wine I'm not sure about the other 2 but it could be worth making them work if they don't as a PR exercise especally if they work under Ceider Any hoo I should be off to bed now Mike

3 2

Re: regedit: fixed a memory leak in listview.c (found by Smatch).
by Dmitry Timoshkov 03 Sep '07

03 Sep '07

"Lionel_Debroux" <lionel_debroux(a)yahoo.fr> wrote: > diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c > index 0e4b52b..8b58eec 100644 > --- a/programs/regedit/listview.c > +++ b/programs/regedit/listview.c > @@ -61,7 +61,10 @@ static LPTSTR get_item_text(HWND hwndLV, int item) > > curStr = HeapAlloc(GetProcessHeap(), 0, maxLen); > if (!curStr) return NULL; > - if (item == 0) return NULL; /* first item is ALWAYS a default */ > + if (item == 0) { /* first item is ALWAYS a default */ > + HeapFree(GetProcessHeap(), 0, curStr); > + return NULL; > + } A more logical fix would be to move if (item == 0) return NULL; /* first item is ALWAYS a default */ before HeapAlloc() call. -- Dmitry.

1 0

Re: winhelp, Vector NTI, molecular biologists
by Misha Koshelev 03 Sep '07

03 Sep '07

> 2007/9/3, Misha Koshelev <mk144210(a)bcm.edu>: > Hi everybody, > > So as you all know I've been working on various bug fixes > throughout > wine, with my most significant contributions to date being MSI > OLE > automation support and implementation of http protocol support > in > urlmon. This involvement was driven by my initial experiences > of getting > a key program used by molecular biologists, Invitrogen's > Vector NTI, to > install on wine with a fairly convoluted shell script and > submitting my > first patch to fix a crash with this program; Dan Kegel helped > me iron > out this first patch a lot and furthermore his comments about > how it'd > be nice if such a complicated shell script was not necessary > with wine > got me started with my other patches and the rest, as they > say, is > history. > > So why, you may ask, am I sending all this in an email to > wine-devel? > The short answer is that this is a shameless email to see if I > might > motivate someone to work on our winhelp implementation a bit, > as it is > currently completely useless with Vector NTI. This seems like > a fairly > significant task, and my obligations at school/work have > recently kicked > up quite a bit, making it unlikely I will be able to take it > on anytime > soon. However, I hope to motivate someone with these reasons: > > (i) I feel like I've certainly been doing (and will continue > to do) my > part in helping out wine, and if this in any case motivates > someone > looking for a development direction I would certainly not > object; and > > (ii) My ultimate vision/goal has been to have Vector NTI run > so well > that I could approach Invitrogen and see if they might at the > very least > say something to that effect on their Web site ("add wine + > linux as a > supported platform"), if not package Vector NTI a la Google > Picassa, > which would be great publicity for wine. Also, as you can see > from the > comments on my ubuntuforums howto > http://ubuntuforums.org/showthread.php?t=347095 for a lot of > molecular > biologists, Vector NTI is the only reason they have to > dual-boot/use > VMWare at all (full-disclaimer: this is not 100% true for > myself). So > you could help perhaps a fairly small but non-insignificant > group of > people by doing some work on winhelp. > > Although Vector NTI is a rather large set of programs, > currently I > believe the only things keeping it from installing/working to > a "gold" > level according to winehq definitions are (i) winhelp and (ii) > either > MFC42 implementation (required for WSH to install properly; I > suppose > only a few functions prob are really required, but I'm not > sure how good > an idea having a very small stub MFC42 would be) or JScript > support in > wine. Either item in (ii) seems like a very significant > undertaking, but > (i) seems doable and prob. necessary for a lot of apps. > > So anyhow just my attempt to influence someone to start > working on > winhelp. Sorry for cluttering your inboxes. > > Misha > Btw I should have posted the URL to the demo version: http://download.invitrogen.com/evergreen/Vector%20NTI%20Advance%2010.exe To me the main problem with winhelp here is just that none of the winhelp navigation (Contents, Search, etc.) is implemented, making it difficult to, for example, answer the question "how do I do X?" which I'm sure Invitrogen would care about. From what I understand looking over some of the winhelp bug reports, the way .hlp files are currently processed this would be difficult/slow to implement, so probably a different way of processing them is necessary (don't know more than I read from searching for winhelp in the bugzilla for this tho, haven't investigated it myself). Currently there is also a "bug" where WinHelp returns the incorrect value (WM_SENDDATA in winhelp program returns 0L and thus so does WinHelp which just returns the result of SendMessage, whereas according to MSDN WinHelp() shoudl return non-zero on success). In any case this latter thing would be pretty easy to fix, but I think really the rest of winhelp would need to be fixed for this second part to have any real use (other than removing an annoying "Failed to open help file" dialog). Thanks everybody Misha

1 0

Re: ddraw: fix cases where desc2.u2.dwMipMapCount is 0.
by Stefan Dösinger 03 Sep '07

03 Sep '07

Am Sonntag, 2. September 2007 14:16 schrieb David Hedberg: > (Resending mail after subscribing to list) > > Hi, > > This patch fixes a problem visible in Delta Force Land Warrior and > Delta Force Task Force Dagger, where extra_surfaces would sometimes > get a value of -1 and later cause a "near infinite" loop in > CreateAdditionalSurfaces. I think you should test that in the desc2.dwFlags & DDSD_MIPMAPCOUNT case above, where currently the "Mipmap count is given, nothing to do" comment is. It would be good if you extended the test case in dlls/ddraw/tests/dsurface.c to test the case where the mipmapcount flag is set, but the mipmap count is 0. It could either create a one-level surface (like your patch currently does), or ignore the mipmapcount flag, and create mipmaps until either width and height are 0.

2 2

Re: Window decorations missing on Compiz/Debian Etch
by Maarten Lankhorst 02 Sep '07

02 Sep '07

Michael Jung schreef: > Hi Maarten, > > Thanks for pointing me to the FAQ. The FAQ entry seems to address > primarily OpenGL related issues, however, which I'm currently not > concerned about that much. Given the fact that the window decorations > used to work just fine before the mentioned patch, I would consider > this a regression. > > Bye, > -- > Michael Jung > mjung(a)iss.tu-darmstadt.de > Hi Michael, First of all, please do 'reply all' so a copy gets sent to wine-devel too. Second, if the bug only occurs with compiz/beryl it is really likely that it is a compiz/beryl bug., since it's not really a mature window manager, and has a lot of bugs, even not considering opengl. Cheers, Maarten

2 1

[RFC] [PATCH] GNU make based build system for Winelib applications
by Kirill Smelkov 02 Sep '07

02 Sep '07

Hello Wine developers, Francois! I am going to port some Win32 applications to GNU/Linux and though it would be useful to improve the build system for Winelib applications. Current status and Motivation ============================= 1. Wine in-tree Makefiles for programs & dlls are pretty much good and maintainable, but they lack C++ support. 2. Initial approach taken by winemaker (I used it in 2003-2004) was to adapt Wine's make rules to support C++ . 3. At present winemaker dropped supplying above mentioned rules and generates very simple makefiles. To me this approach have several problems: - lack of dependency tracking - hard to maintain Makefiles. The rules generated are substituted in each Makefile instead of being in one place. - good as a starting point, but not a complete solution. Winemaker already relies on GNU toolchain (in form of gcc and g++), and I though:: Why not use GNU make with all available extensions when necessary, and deploy a simple full-featured build system for Winelib based applications The result is presented here for public review. Comments, suggestions? Features ======== * support C, C++ and resource files. * automatic dependency tracking for C and C++. * beautified build output (to increase SNR and concentrate on errors and warnings). * winemaker patches provided (although I don't know Perl -- help needed, Francois?). * Tested with GNU make 3.81. This version of GNU make was released in 2006 and is present in all recent Linux distributions. Usage example ============= I attach winelib-gnu-make.tar.gz where an interested reader can see Winemake build system usage. For usage example see directory clock+wow32/ . There I provide example of how to build 1 program and 2 dlls. Original clock.exe & wow32.dll processed by winemaker are located in misc/ for comparison.

1 0

Re: [5/5] WineD3D: texkill ignores the .w only in ps 1.x
by Tomas Carnecky 01 Sep '07

01 Sep '07

+ + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff00ff00, 0.0, 0); + ok(hr == D3D_OK, "IDirect3DDevice9_CreatePixelShader returned %s\n", DXGetErrorString9(hr)); Is that worth changing? tom

2 1

Re: secur32: Add some missing prototypes to ntsecapi.h.
by Kai Blin 01 Sep '07

01 Sep '07

On Saturday 01 September 2007 02:45:33 Francois Gouget wrote: > --- > include/ntsecapi.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) Thanks, that was on my list, but I didn't get around to it yet. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [1/3] whhc - add chm compiler
by Vitaliy Margolen 01 Sep '07

01 Sep '07

Miikka Viljanen wrote: > adds the whhc chm compiler under tools/whhc > > And what told you that you can just change the license from GPL to Wine's LGPL by just editing the header? Have you even asked authors of the program? Vitaliy.

1 0

Re: [PATCH] user32: edit control should respond to ctrl + z (try 2)
by Dmitry Timoshkov 01 Sep '07

01 Sep '07

"Lei Zhang" <thestig(a)google.com> wrote: > This patch lets users hit ctrl + Z in edit controls to trigger an > undo. The test case has been improved to check for return values when > appropriate. > + /* select all, cut (ctrl-x), undo (ctrl-z) */ > + SendMessage(hwEdit, EM_SETSEL, 0, -1); > + r = SendMessage(hwEdit, WM_CHAR, 24, 0); > + todo_wine { ok(r == 1, "Expected: %d, got: %d\n", 1, r); } > + r = SendMessage(hwEdit, WM_CHAR, 26, 0); > + todo_wine { ok(r == 1, "Expected: %d, got: %d\n", 1, r); } By "I'd suggest to add checks to make sure that every message you send above really worked." I meant not simply check the SendMessage return values, but actual Edit contents/selection changes tracking. -- Dmitry.

1 0

Re: [4/5] WineD3D: Implement texldb
by H. Verbeet 31 Aug '07

31 Aug '07

On 31/08/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Not as much a comment on this patch, but rather something I just thought of and I'll otherwise probably forget: our d3d9types.h doesn't contain definitions for D3DSI_TEXLD_PROJECT and D3DSI_TEXLD_BIAS, so we should add those.

1 0

Re: [2/5] WineD3D: Fix the z range
by Stefan Dösinger 31 Aug '07

31 Aug '07

Am Freitag, 31. August 2007 17:20 schrieb Stefan Dösinger: Do not apply this patch yet, it breaks half life 2. There's something about the minZ and maxZ values in the viewport that we have to take into account.

1 1

Re: [3/5] WineD3D: Fix texdepth instruction
by Alexandre Julliard 31 Aug '07

31 Aug '07

Stefan Dösinger <stefan(a)codeweavers.com> writes: > The DCT pixel shader test spotted a problem with texdepth. The test > included in this patch demonstrates texdepth's undocumented clamping > behavior, and > verifies the documented r5.r == 0.0 special case. This doesn't work for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:2281: Test failed: Pixel 158(25% - 2 pixel) has color 00ffffff, expected 0x000000ff visual.c:2303: Test failed: Pixel 318(50% - 2 pixel) has color 00ffff00, expected 0x000000ff visual.c:2344: Test failed: Pixel 318(50% - 2 pixel) has color 0000ff00, expected 0x000000ff make: *** [visual.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv[1/4]: wintab: restructure WTInfoA to dump a category by dumping field by field (resend)
by Alexandre Julliard 31 Aug '07

31 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > I see that my patch to skip non-pressure-sensitive devices didn't > get it. I will try to look into it next week while now I'll resend the > Unicode patches that are easier. Here the first patch could be > controversial as I use a lot of macros. But that allows me not to use > long parameter lists. It's ugly. I don't see why you'd need long parameter lists at all, simply adding a current offset in CopyTabletData should be enough. Also, always going through all the cases even when a specific index is specified is not nice. And the winex11 function should always return Unicode, the A translation can be done in the generic code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Vacation
by Alexandre Julliard 31 Aug '07

31 Aug '07

Hi folks, I'll be on vacation all of next week, so there won't be any commits. If you need to synchronize development with others in the meantime, I encourage you to create a tree on repo.or.cz. The 0.9.45 release will also be delayed by a week, so it will be on Sept 14th. Have fun while I'm gone... -- Alexandre Julliard julliard(a)winehq.org

1 0

RegDeleteTree and older versions of windows?
by Maarten Lankhorst 31 Aug '07

31 Aug '07

Now that most functions get replaced with RegDeleteTree, I'm wondering if it is possible to link against that function statically for mingw/msvc dlls, so wine dlls can be still be used on win9x and windows nt and win2k. The problem is I don't know what the best solution would be to make sure the function makes it in, in case of mingw. I think it would be best to add it to include/wine/regdeltree.h and then include it from all dlls that need it, and probably from dlls/advapi32/registry.c as well, so code duplication is avoided. Something along the lines of: #if defined(__MINGW32__) || defined(__MSVC__) || defined(EXPORTREGDELTREE) (insert regdeltree functions here) #endif I'm open for suggestions though, since I really can't come up with any good ways to make sure wine dlls will keep working for older versions of windows. Cheers, Maarten

2 1

Re: winex11.drv: fix memory leak in create_cursor (found by Smatch)
by James Hawkins 31 Aug '07

31 Aug '07

On 8/31/07, Lionel_Debroux <lionel_debroux(a)yahoo.fr> wrote: > create_cursor leaks some heap memory in an error path. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > I'm almost sure that the other potential memory leak detected by Smatch, > in the same function, is NOTABUG. Indeed, bitMask32 is conditionally > freed at line 850, if the number of bits per pixel (ptr->bBitsPerPixel) > is 32 - which is the condition which led to bitMask32 being allocated, > at line 639. > > 2007-08-31 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/winex11.drv/mouse.c: > winex11.drv: Fix memory leak in create_cursor (found by Smatch) > > >From d62a874a6d399546940a97fc3d800a692c08b362 Mon Sep 17 00:00:00 2001 > From: Lionel Debroux <lionel_debroux(a)yahoo.fr> > Date: Fri, 31 Aug 2007 08:16:36 +0200 > Subject: winex11.drv: fix memory leak in create_cursor (found by Smatch). > > --- > dlls/winex11.drv/mouse.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/winex11.drv/mouse.c b/dlls/winex11.drv/mouse.c > index 86dad89..d8bf30a 100644 > --- a/dlls/winex11.drv/mouse.c > +++ b/dlls/winex11.drv/mouse.c > @@ -763,6 +763,8 @@ static Cursor create_cursor( Display *display, CURSORICONINFO *ptr ) > pixmapBits = XCreateBitmapFromData( display, root_window, (char *)pXorBits, xmax, ymax ); > if (!pixmapBits) > { > + if (bitMask32) > + HeapFree( GetProcessHeap(), 0, bitMask32 ); > XFreePixmap( display, pixmapAll ); > You shouldn't be checking bitMask32 for NULL before freeing it. -- James Hawkins

1 0

Re: crypt32(1/17): Greatly expand certificate chain tests
by Alexandre Julliard 31 Aug '07

31 Aug '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > In case the big version doesn't get through in time, here's a gzipped version. It fails for me: ../../../tools/runtest -q -P wine -M crypt32.dll -T ../../.. -p crypt32_test.exe.so chain.c && touch chain.ok chain.c:1187: Test failed: Chain 12: CertGetCertificateChain failed: 80092004 make[2]: *** [chain.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] WineD3D: Fix texdp3tex in glsl
by H. Verbeet 31 Aug '07

31 Aug '07

On 30/08/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > The preferred way to do that is to use shader_glsl_get_sample_function(). Also note that previously the docs just said "The result is used to sample the texture at texture stage m by performing a 1D lookup." The addition of using 0.0 to extend the vector is apparently recent.

2 2

Re: [PATCH] user32: edit control should respond to ctrl + z
by Dmitry Timoshkov 31 Aug '07

31 Aug '07

"Lei Zhang" <thestig(a)google.com> wrote: > This lets users hit ctrl + z in edit dialogs. A test case is included. > This should fixed bug 9525. > + /* select all, cut (ctrl-x), undo (ctrl-z) */ > + SendMessage(hwEdit, EM_SETSEL, 0, -1); > + SendMessage(hwEdit, WM_CHAR, 24, 0); > + SendMessage(hwEdit, WM_CHAR, 26, 0); I'd suggest to add checks to make sure that every message you send above really worked. -- Dmitry.

2 1

Re: winex11.drv/wintab32[5/6]: implement WTInfoW
by John Klehm 31 Aug '07

31 Aug '07

You forgot the patch. On 8/30/07, Mikolaj Zalewski <mikolajz(a)google.com> wrote: > Now we allow to query the Unicode data > > >

1 0

Re: winex11.drv[2/6]: wintab: skip non-pressure-sensitive devices for wintab32
by John Klehm 31 Aug '07

31 Aug '07

You forgot the patch. On 8/30/07, Mikolaj Zalewski <mikolajz(a)google.com> wrote: > Another problem I had was that the laptop touchpad was detected as a > tablet. This may confuse Windows applications, as on Windows it isn't. > Also it confuses Wine because we support only one tablet - we assume > that each cursors have the same resolution. > > Is there a good way to select the correct devices as do we have to add > heuristics like the one in this patch? This patch ignored devices that > don't have the pressure axis. I assume that the WM_MOUSEDOWN gives > enough information so there is little loss that it can't be accessed > with wintab32. > > >

1 0

.NET support
by Jakob Eriksson 30 Aug '07

30 Aug '07

Now that GDIplus is shaping up, is there a chance of implementing .forms support in mono with it? regards, Jakob

3 9

Fwd: Re: winmm: Change default driver order to be alsa, coreaudio, oss - try2
by Kuba Ober 30 Aug '07

30 Aug '07

---------- Forwarded Message ---------- Subject: Re: winmm: Change default driver order to be alsa,coreaudio,oss - try2 Date: Tuesday 21 August 2007 From: Kuba Ober <kuba(a)mareimbrium.org> To: wine-devel(a)winehq.org On Sunday 19 August 2007, Vitaliy Margolen wrote: > Maarten Lankhorst wrote: > > Forgot to remove the strlen check. > > Isn't this a bit premature? ALSA still does not support proper sound > capture, working mixer, and not stable enough on some configurations. In fact, for whatever it's worth, on some machines running either CentOS5 or FC6, for me alsa is completely broken (choppy sound output from linux alsa applications, etc). :( Cheers, Kuba -------------------------------------------------------

1 0

Re: try2:patch for sysparams.c
by L. Rahyen 30 Aug '07

30 Aug '07

On Thursday August 30 2007 07:03, you wrote: > Hello, > > I have corrected a patch. Now font in the menu and a font in winecfg > coincides. Your patch still doesn't work correctly. With 120 DPI setting font size in winecfg and notepad menu is different (menu' font is bigger; no so big as before but still bigger). As I have said, in Windows font size is the same in whole system if I change DPI setting and this is (correct) behavior of current WINE too. Please note that your patch behaves even worse at higher DPI resolutions. For example if I set: "LogPixels"=dword:00000096 ...In system.reg then menu font is of ridiculosly big size. In winecfg I have normal font size suitable for my display resolution. In fact, dword:00000096 setting this is what I use in both WINE and Windows (in Windows I can just use "Custom..." menu; in WINE winecfg isn't yet sophisticated enough). In short: if DPI setting changes then font size should change in linear fashion at the same rate for all fonts. Also please explain what exactly you are trying to fix with your patch (what application)? Are you sure that Windows behaves in the same way as you proposing? Test case probably would be nice thing. Sorry, but purpose of your patch is unclear to me. In your changelog field you tell that "This patch does a font for the menu, statusbar and messages dependent from logpixels" but as far as I know WINE already have correct behavior and respects the LogPixels value (it already sets correct size in menu, status bar and other GUI elements). This is why I'm asking you for an real-world example (with real-world application) of what you are trying to fix. P.S. Don't forget to reply to wine-devel so others can see the discussion.

3 4

Re: dsound: Disable thread calls and increase refcount in dllmain
by Dmitry Timoshkov 30 Aug '07

30 Aug '07

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Seems native directsound keeps itself loaded by calling LoadLibrary when > attaching. A simple testcase I wrote confirms that at least for xp, by > not crashing. After seeing this, I decided to write my own test, and can confirm now that this patch looks correct: after a successful LoadLibrary("dsound.dll") FreeLibrary needs to be called 2 times before it starts to return FALSE. Just for fun I tested other dlls as well (GetModuleHandle returns 0 for all of them before the LoadLibrary call): user32 requires 4 FreeLibrary calls after LoadLibrary, dinput - 1, mfc42 - 1, advapi32 - 1, comctl32 - 1. I'm attaching the program I used for testing. > + GetModuleFileNameW(hInstDLL, modname, sizeof(modname)/sizeof(*modname)); > + LoadLibraryW(modname); Probably simple LoadLibrary("dsound.dll") should be enough. -- Dmitry.

3 2

Re: winex11.drv: Support GdiAlphaBlend with blendfn.AlphaFormat == 0 (2nd try, fixes bug #9262)
by Alexandre Julliard 30 Aug '07

30 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > I'm not sure if I understood how it's supposed to look like. Is > something like this good? It adds an 'if' in the inner loop, but it's > an 'if' that is easy to predict and this version makes less memory > reads so maybe it will be better. You should put the if outside the loops, and keep the existing fast case with the memcpys and add a separate slower way for when alpha needs patching. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/5] WineD3D: Clear unused channels on R32F and R16F textures on readback
by H. Verbeet 29 Aug '07

29 Aug '07

On 29/08/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Can you even use those formats as render target on any cards?

2 1

Re: notepad: Add program icon
by Pedro Araújo 29 Aug '07

29 Aug '07

On 8/27/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > notepad: Add program icon > > And now for the usual Wine oath: :) > I swear under pain of treason that the icon is my own work. > > .png attached if anyone wants to look at it. It's really not all that pretty. > > Alexander N. Sørnes I had this quick and dirty (okay, *very* dirty) mockup lying around for a while (not at all a very long while) and thought somebody might find some use for it... just in case. Ah, yeah, I too "swear under pain of treason" that I did it myself. :-) (I still have the original svg here if anyone wants it) - Pedro.

2 1

Re: try2:patch for sysparams.c
by L. Rahyen 29 Aug '07

29 Aug '07

On Wednesday August 29 2007 09:15, Ivan Sinitsin wrote: > Has corrected "logpixels=72" to " logpixels = 96 " and has changed the > indentation > > This patch adds an opportunity for fonts of the menu, statusbar and > messages to increase depending on logpixels. > > > Changelog: > This patch does a font for the menu,statusbar and messages dependent from > logpixels. With your patch applied to current GIT head I have too large fonts in all menus even in notepad if for example I have set logpixels to 120 dpi using winecfg. "Too large" means MUCH larger than in, for example, winecfg itself (you need to restart the program to see the effect). See atached snapshot to see how notepad looks like with your patch if I set 120 dpi in winecfg. Font size is ridiculously big! For testing I have used clean WINE with your patch only and clean WINEPREFIX. In Windows and current WINE without your patch in clean WINEPREFIX all fonts are of same size no matter what DPI I set in LogPixels or winecfg and this is correct behavior. What application you are trying to fix?

1 0

re: getting started...
by Dan Kegel 29 Aug '07

29 Aug '07

Ed wrote: >I'm brand new to the list and would like to get a Windows application that >I wrote (uCon) to work with wine/winelib. I've submitted it to the application >database. I've tried it on Wine and it *almost* works, so I'd like to pursue >this further by building uCon with Winelib (as is recommended somewhere >in the documentation). Egads. Where does it recommend that? Using winelib is a terrible idea unless you really need it (e.g. on non-x86 platforms, it's your only option). The downside is that your app suddenly becomes very fragile with respect to user updates of wine; they need a synchronized version of your app that matches their version of Wine. I've seen this happen, and it's not pretty. Also, this means double the QA and release trouble. The Right Thing To Do IMHO is just make your app and wine work better together, not use winelib. So your next move is to file bugs in http://bugs.winehq.org describing how your app doesn't work with wine, and work with us to solve them. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 7

Re: winex11.drv[2/2]: Support GdiAlphaBlend with blendfn.AlphaFormat == 0 (fixes bug #9262)
by Alexandre Julliard 29 Aug '07

29 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -1600,6 +1603,16 @@ #endif > for(; y >= y2; y--) { > memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > widthSrc * 4); > + if (!(blendfn.AlphaFormat & AC_SRC_ALPHA)) > + { > + int i; > + RGBQUAD *quad = (RGBQUAD *)dstbits; > + for (i = 0; i < widthSrc; i++) > + { > + quad->rgbReserved = blendfn.SourceConstantAlpha; > + quad++; > + } > + } It would be nicer to have a separate loop for that case, and do everything in one go instead of patching up the values after the copy. Also RGBQUAD is meant for color tables, it's not an appropriate type for the bitmap data itself. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (3rd try, with testcase, fixes bug #9195)
by Alexandre Julliard 29 Aug '07

29 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Is there something wrong with this patch? You should use IntersectClipRect or ExtSelectClipRgn to avoid intermediate copies. Also GetClipRgn doesn't return a region code so checking it against NULLREGION is wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: patch for sysparam.c
by Paul Vriens 29 Aug '07

29 Aug '07

Ivan Sinitsin wrote: > This patch adds an opportunity for fonts of the menu, statusbar and messages > to increase depending on logpixels. > > > Changelog: > This patch does a font for the menu,statusbar and messages dependent from > logpixels. > > > ------------------------------------------------------------------------ > > With the latest release winecfg can set this value. The default there is 96 and the range is 96..120. How does that relate to the 72 in your code? : +if (!RegQueryValueExW( myhKey, log_pixels, NULL, &type, + (LPBYTE) &logpixels, &size )==ERROR_SUCCESS) + logpixels=72; Cheers, Paul.

1 0

Re: patch for sysparam.c
by Robert Shearman 29 Aug '07

29 Aug '07

Ivan Sinitsin wrote: > This patch adds an opportunity for fonts of the menu, statusbar and messages > to increase depending on logpixels. > > > +size=sizeof(DWORD); > +RegOpenKeyExW( HKEY_LOCAL_MACHINE, registry_key, > + 0, KEY_QUERY_VALUE, &myhKey ); > +if (!RegQueryValueExW( myhKey, log_pixels, NULL, &type, > + (LPBYTE) &logpixels, &size )==ERROR_SUCCESS) > + logpixels=72; > +ncm.lfMenuFont.lfHeight=-MulDiv(ncm.lfMenuFont.lfHeight,logpixels,72); > +RegCloseKey( myhKey ); You're missing some indentation here. -- Rob Shearman

1 0

Re: [PATCH] Support for animated cursors
by H. Verbeet 28 Aug '07

28 Aug '07

On 28/08/07, Trent Waddington <trent.waddington(a)gmail.com> wrote: > On 8/28/07, H. Verbeet <hverbeet(a)gmail.com> wrote: > > You should use the timing and frame sequence info from the .ani. > > Also, Xcursor actually supports proper animated cursors, so it would > > be better to handle the animation in winex11.drv > > Can you please direct me to some example code of defining and using an > animated cursor with Xcursor? > http://repo.or.cz/w/wine/hacks.git?a=blob;f=dlls/winex11.drv/mouse.c;h=b344… should be a decent start. > > As explained in the comment at the top of cursoricon.c, you can't do > > that, because it will break win16 applications. > > Umm.. what comment would that be? This one: > * Cursors and icons are stored in a global heap block, with the > * following layout: > * > * CURSORICONINFO info; > * BYTE[] ANDbits; > * BYTE[] XORbits; > * > * The bits structures are in the format of a device-dependent bitmap. > * > * This layout is very sub-optimal, as the bitmap bits are stored in > * the X client instead of in the server like other bitmaps; however, > * some programs (notably Paint Brush) expect to be able to manipulate > * the bits directly :-( > Should I replace hNext with a CURSORICONINFO *? This is what I had > initially.. or should I be using something else? Or should I just > make it an BYTE bFrames and append multiple data blocks to the end of > the CURSORICONINFO struct? > Well, what it comes down to is that you can't change the cursor memory layout for win16 applications at all, which complicates things a bit.

3 12

[PATCH] the function called is cdecl, not WINAPI
by Juan Lang 28 Aug '07

28 Aug '07

Hi Marcus, > the function called is cdecl, not WINAPI No it isn't. It's declared that way, but it's wrong. Calling it that way in Windows crashes. That's why I sent this patch: http://www.winehq.org/pipermail/wine-cvs/2007-August/035682.html --Juan

2 2

Re: winex11.drv: test for out-of-bound src coordinates in GdiAlphaBlend (fixed, with testcase, fixes bug #7428)
by Alexandre Julliard 28 Aug '07

28 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > The previous version didn't take into account that dib.dsBmih.biHeight > can be negative. You should check for negative widthSrc/heightSrc too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: tests: some values of _mbctype are dependent on the version of Windows
by Alexandre Julliard 28 Aug '07

28 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -144,10 +144,18 @@ static int result_cp_949_mbctype[] = { 0 > static int result_cp_950_mbctype[] = { 0x0,65, 0x8,1, 0x18,26, 0x8,6, 0x28,26, 0x8,4, > 0x0,2, 0x4,32, 0xc,94, 0,1 }; > > +/* these characters may differ on different Windows versions */ > +static int fuzzy_cp_1252_mbctype[] = {142, 158, 170, 181, 186, -2}; > +static int fuzzy_cp_1250_mbctype[] = {131, 141, 142, 143, 157, 158, 159, 163, 165, 170, 175, 179, 181, 185, 186, 188, 190, 191, -2}; > +static int fuzzy_cp_932_mbctype[] = { -2 }; > +static int fuzzy_cp_936_mbctype[] = { -2 }; > +static int fuzzy_cp_949_mbctype[] = { -2 }; > +static int fuzzy_cp_950_mbctype[] = { -2 }; What this shows is that the exact values don't matter, and that apps are very unlikely to depend on them. This also means that having slightly different tables in Wine is not a problem, so I'd suggest to not try to test every single char, but just pick a few that are the same on all platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

Old versions of Photoshop Elements tryout?
by Dan Kegel 28 Aug '07

28 Aug '07

Hi all, I have a copy of Photoshop Elements 1.0, and can easily download a tryout of Photoshop Elements 5, but I don't know where to get trial versions of 2 through 4. Anyone know? Thanks, Dan

2 3

Re: 0001-Basic-starting-point-for-implementing-d3dx9_yz.dll.patch
by Detlef Riekenberg 27 Aug '07

27 Aug '07

On Mo, 2007-08-27 at 14:13 +0200, Martijn Berger wrote: > > --- > .gitignore | 1 + > Makefile.in | 1 + > configure.ac | 1 + > dlls/Makefile.in | 1 + > dlls/d3dx9/Makefile.in | 15 +++++++++++++++ > 5 files changed, 19 insertions(+), 0 deletions(-) > --- /dev/null > +++ b/dlls/d3dx9/Makefile.in > @@ -0,0 +1,15 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = d3dx9.dll > +IMPORTS = wined3d kernel32 > + > +C_SRCS = \ > + d3dx9_main.c > + > +RC_SRCS = version.rc This will not work: Your Makefile.in referenced "version.rc" and "d3dx9_main.c", but this files are missing in this Patch. You should never autogenerated modifications in any Patch: http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832ba… -- By by ... Detlef

1 0

DIB Driver code available
by Jesse Allen 27 Aug '07

27 Aug '07

Hi, I have my DIB driver code available on a public git host now: http://repo.or.cz/w/wine/dibdrv.git I'm going to briefly describe it. The dib driver (or engine) is a gdi driver. It is loaded into a dc when an application selects a dib, and overrides the existing driver. The magic takes place in SelectBitmap. Safe interaction is provided in gdi32 in four patches. If the winedib.drv.so library is available, then gdi will use the dib driver for drawing into the selected dib. If winedib.drv.so is not available, then gdi will continue using winex11 for example just as before. So these four patches can be safely integrated with the main tree if that is decided to be done. The rest of the code is the driver itself. It can handle all the standard uncompressed dib formats. It can convert between formats, and it can Get/SetDIBits/Blt. Get/SetPixel is implemented too. No other drawing code is done yet, so only simple GDI apps work. I've tested several apps and I'll list my results. notepad -- no regressions found winefile -- visual artifacts, but usable bmp loading -- works fine for what has been tested pixel setting -- works fine for every supported format opengl app -- Tribes 1 -- no regressions found d3d app -- Star Wars Battlefront -- no regressions found ddraw app -- Diablo shareware -- no regressions found ddraw app -- Diablo prerelease -- discovered one visual artifact These are the deficiencies in current code (non-stubs): No RLE support Missing raster operations in *Blt Get/SetDIBits does not conform exactly yet Bottom-up DIB's not tested for (and probably broken) DIB_PAL_COLORS not tested for No stretching No forwarding calls back to original driver* *For forwarding back the calls, what I think can be done is use the hbitmap handle originally given, convert it to a DDB, select it, and make the same gdi call again which will then go to the actual device. I do probably need to make sure the dibdrv's physdev persists and doesn't get deleted during this ;) (probably something in Create/Delete DC) Performance Originally I was going to state not to expect there really to be any performance improvements. I feel that there are optimizations possible that I have not done, but I left room for. My first concern was correct pixel by pixel operation. So I thought not to expect anything but last night I discovered this, so I might as well share. I have written a program that performs Get/SetPixel to test the various formats. There are 13 total tests, and the program produces 52 MB of output. Just for fun I ran my program without the dib driver and found it took a very long time (I was thinking it hung up at first since it took so long!): timed with winex11.drv real 0m53.903s user 0m19.807s sys 0m5.869s So I tried it with my driver: timed with winedib.drv real 0m3.924s user 0m3.537s sys 0m0.191s Indeed, my tests show that there is a 50 second difference with GDI Get/SetPixel. If anyone wants to try my app, I'll send it to them :) Still, I wouldn't expect *your* app to seem much different (or work at all :P) So will all the interested parties take a look at the driver and I'd sure appreciate feedback on the direction this is going, so we move towards finishing this project beyond the summer of code. :) Jesse

3 7

Re: 0002-Basic-d3dx9-stub.patch
by H. Verbeet 27 Aug '07

27 Aug '07

On 27/08/07, Martijn Berger <martijn.berger(a)gmail.com> wrote: > +WINE_DEFAULT_DEBUG_CHANNEL(d3d10); That's not a good idea. Also, since the dll isn't actually called d3dx9.dll, how do you intend to handle the different versions? (Arguably these dlls are outside Wine's scope, since they're not installed as part of the OS, and should be installed by the application that is using them.)

2 1

getting started...
by Ed Sutter 27 Aug '07

27 Aug '07

Hi, I'm brand new to the list and would like to get a Windows application that I wrote (uCon) to work with wine/winelib. I've submitted it to the application database. I've tried it on Wine and it *almost* works, so I'd like to pursue this further by building uCon with Winelib (as is recommended somewhere in the documentation). That being said, I'm a bit confused... The winelib users guide mentions "winemaker", but doesn't point to where I get it. It doesn't appear to come with the Wine package (as expected); however, aside from the entire Wine source tree, I don't see anything else to download. Do I need/want the entire Wine source tree if my next step is to attempt to build my application using Winelib? Thanks in advance Ed BTW... I'm going to be doing this on a RH9 linux box.

2 3

[PATCH] Support for animated cursors
by Trent Waddington 27 Aug '07

27 Aug '07

Test program at: http://rtfm.insomnia.org/~qg/animatedcursor.exe Probably doesn't support all the possible animated cursors supported under windows, and correct timing of animation hasn't been attempted. Trent

3 2

Re: wintrust(4/5): Test and implement SoftpubLoadMessage (with patch)
by Alexandre Julliard 27 Aug '07

27 Aug '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > + ret = data->pPDSip->pSip->pfGet(data->pPDSip->psSipSubjectInfo, > + &data->dwEncoding, 0, &size, buf); > + if (ret) > + { > + data->hMsg = CryptMsgOpenToDecode(data->dwEncoding, 0, 0, data->hProv, > + NULL, NULL); > + if (data->hMsg) > + ret = CryptMsgUpdate(data->hMsg, buf, size, TRUE); > + } > + > + if (!ret || !data->hMsg) > + err = GetLastError(); > + data->psPfns->pfnFree(buf); > + return err; That style of coding is dangerous, it assumes that all the error paths of the called functions will set last error properly. It's better to return a success/failure boolean and fetch the last error only when the actual error is needed, not as an error indication. -- Alexandre Julliard julliard(a)winehq.org

1 0

[git] Playing with gitstat (can we change date for the tags?)
by Paul Vriens 27 Aug '07

27 Aug '07

Hi, I was just playing with gitstat (http://tree.celinuxforum.org/gitstat/) to see if it give some nice graphs for Wine as well (on my local box). I can see all the tags but for some reason a lot of tags (from wine-0.0.2 to wine-0.7 and after that wine-940201 to wine-980927, so basically every tag before Alexandre's "Initial revision") have nearly the same tagger/author date (around November 30th 2005). This messes up the ordering of the tags. Is there something I can do about this? (man git-tag tells me one shouldn't change tags afterwards). (I've changed the necessary perl-script to only include the tags that are correct so I do have some output). -- Cheers, Paul.

2 1

Re: Imm32: Update position of default IME window
by Alexandre Julliard 27 Aug '07

27 Aug '07

Aric Stewart <aric(a)codeweavers.com> writes: > + > + /* make sure we are on the desktop */ > + GetClientRect(GetDesktopWindow(),&desk_rect); You have to use GetMonitorInfo to support multi-monitor setups correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [patch] Garbage code in text string display
by Guan Xin 27 Aug '07

27 Aug '07

On 8/23/07, Juan Lang <juan.lang(a)gmail.com> wrote: > You may generally post source to wine-devel if it's short and to the > point. Please don't post a binary. Acturally, this bug is obvious as I have pointed it out. No source is needed for demonstration. Also I always programmed with Borland's AFX when I used Windows. So my source is unlikely to compile under WINE or MSVC. Recently I have no Windows machine and cannot learn Windows API programming to write those tests. > Right to the first point, which is why we write tests that pass on > Windows, and fix Wine to match the tests. This obviates the need to > look at Windows source. You must be mistaken. Tests that fail when WINE is not patched and pass when patched do not prove correctness of the midification. They only increase the possibility of its correctness. I am sorry I never learnt computer science and misunderstood your requisition. Here is an analogy to show what you are doing: in order to find out how to turn off the light, a computer scientist tried to place a piece of wire into the outlet and made a short-circuit. He succeeded. His `test case' never failed as far as he lived. The computer scientist electrocuted himself.

2 2

[wiki] Useful Registry Keys
by Paul Vriens 27 Aug '07

27 Aug '07

Hi, Is "Useful Registry Keys" to show what's in current GIT or should it also help with older versions of Wine? I'm asking because "LogPixels" is currently handled by winecfg and thus could be removed if the page only shows the latest and greatest. Cheers, Paul.

1 0

Re: cabinet: Add initial tests for FDI
by Paul Vriens 27 Aug '07

27 Aug '07

James Hawkins wrote: > Hi, > > Changelog: > * Add initial tests for FDI. > > dlls/cabinet/tests/Makefile.in | 3 +- > dlls/cabinet/tests/fdi.c | 578 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 580 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi James, Am I correct that you're not deleting the "dest" directory? + CreateDirectoryA("dest", NULL); +} + +static void delete_test_files(void) +{ + DeleteFileA("a.txt"); + DeleteFileA("b.txt"); + DeleteFileA("testdir\\c.txt"); + DeleteFileA("testdir\\d.txt"); + RemoveDirectoryA("testdir"); + + DeleteFileA("extract.cab"); +} (Is "dest" used at all?) -- Cheers, Paul.

1 0

Re: wine.inf: add Internet Explorer AppPath registry key
by James Hawkins 27 Aug '07

27 Aug '07

On 8/24/07, Mikolaj Zalewski <mikolajz(a)google.com> wrote: > If I remember correctly some MSIE registry keys are not put into > Wine registry because that would prevent users from installing the > original MSIE. Does the AppPath key falls into the same category or > can it be included in Wine? > Why don't you try it yourself and see if it works? -- James Hawkins

2 1

[PATCH] Implement ImmReleaseContext.
by Trent Waddington 26 Aug '07

26 Aug '07

Ugly stub warning replaced with intuitive implementation. Trent

1 0

Call for Testers: Dreamweaver on Wine
by Dan Kegel 26 Aug '07

26 Aug '07

Last I checked, Dreamweaver 8 starts and seems to run reasonably well under Wine. But I'm no Dreamweaver user, and I don't have time to do much QA on it myself, so I'm sure I'm missing a lot of problems. Could somebody test it and/or comb through the appdb comments, usenet posts, blog entries, and whatnot about Dreamweaver, and start filing bugs? Can't fix 'em if we don't know about 'em! Thanks, Dan

3 3

Re: dinput: Count should not be 0-based.
by Vitaliy Margolen 25 Aug '07

25 Aug '07

Paul Vriens wrote: > Vitaliy Margolen wrote: >> Fixes bug 9439. >> --- >> dlls/dinput/joystick_linux.c | 7 ++++--- >> 1 files changed, 4 insertions(+), 3 deletions(-) >> >> >> ------------------------------------------------------------------------ >> >> > Hi Vitaliy, > > doesn't this patch leave it 0-based? > > if (joystick_devices_count != -1) return joystick_devices_count; > > + joystick_devices_count = 0; > for (i = 0; i < MAX_JOYSTICKS; i++) > { > CHAR device_name[MAX_PATH], *str; > @@ -154,7 +155,7 @@ static INT find_joystick_devices(void) > if (!(str = HeapAlloc(GetProcessHeap(), 0, len))) break; > memcpy(str, device_name, len); > > - joystick_devices[++joystick_devices_count] = str; > + joystick_devices[joystick_devices_count++] = str; > } > > AFAIK this doesn't change anything. Before it was: > > joystick_devices_count = -1 > ++joystick_devices_count -> 0 (for the first entry) > > now: > > joystick_devices_count = 0 > joystick_devices_count++ -> 0 (for the first entry) > I didn't say "index", I said "count" <g>. Count should never be "0-based" as in "0" means "count of one". Index should be 0-based, as in "0" means first. If the count is -1 then it haven't been initialized yet. If it's 0, then there are no devices found. 1+ one or more devices have been found. Where it does mater is in joydev_create_device[A|W], where I assumed that count was 1 based. Vitaliy.

1 0

Regression caused by EM_LIMITTEXT
by Kopfgeldjaeger 25 Aug '07

25 Aug '07

Hi, I am daily using wine with Miranda. The AppDB rates it as garbage, which is true for all versions (including .44) since 0.9.29 because of this patch: http://source.winehq.org/git/wine.git/?a=commit;h=dbcf2e391c684e8e364e29993… It let's Miranda crash the first time when you press enter to send a message. Attached is a log with wine 0.9.44 and Miranda 0.7 alpha #35 Miranda works fine with the newest wine if you revert the patch. Greetings, KGJ PS: Thanks a lot for the cursor position patch, it really helps to see where you are typing ;) Warning: could not find DOS drive for current working directory '/home/florian', starting in the Windows directory. fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.Windows.Common-Controls" err:module:import_dll Library MSVCP60.dll (which is needed by L"C:\\Programme\\Miranda IM\\Plugins\\advaimg.dll") not found fixme:thread:NtQueryInformationThread info class 9 not supported yet err:module:import_dll Library MSVCP60.dll (which is needed by L"C:\\Programme\\Miranda IM\\Plugins\\irc.dll") not found fixme:thread:NtQueryInformationThread info class 9 not supported yet fixme:thread:NtQueryInformationThread info class 9 not supported yet fixme:thread:NtQueryInformationThread info class 9 not supported yet fixme:thread:NtQueryInformationThread info class 9 not supported yet fixme:richedit:RichEditWndProc_common EM_GETLANGOPTIONS: stub fixme:richedit:RichEditWndProc_common EM_SETLANGOPTIONS: stub fixme:thread:NtQueryInformationThread info class 9 not supported yet wine: Unhandled page fault on write access to 0x008cfffc at address 0xb7d5859d (thread 0009), starting debugger... Unhandled exception: page fault on write access to 0x008cfffc in 32-bit code (0xb7d5859d). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:b7d5859d ESP:003362f8 EBP:00336318 EFLAGS:00210602( - 00 - RDI1) EAX:0059eb24 EBX:7dcb791c ECX:3fffeb68 EDX:008d5248 ESI:003314d8 EDI:008cfffc Stack dump: 0x003362f8: ffffffff 7dca50c9 008d5260 0033673c 0x00336308: fffffffc 7dcb791c 008d51e8 008d3158 0x00336318: 00336348 7dca4051 0033673c fffffffe 0x00336328: 00000000 7dca2cf4 008d2fe0 00000000 0x00336338: 00336358 7dcb791c 008d2860 00000000 0x00336348: 00336378 7dc903ae 008d2860 008d3158 Backtrace: =>1 0xb7d5859d memmove+0x4d() in libc.so.6 (0x00336318) 2 0x7dca4051 ME_InsertRunAtCursor+0x71(editor=0x8d2860, cursor=<register EDI not in topmost frame>, style=0x8d4fc0, str=0x33673c, len=0xfffffffe, flags=0x0) [/home/florian/wine-0.9.44/dlls/riched20/run.c:418] in riched20 (0x00336348) 3 0x7dc903ae ME_InternalInsertTextFromCursor+0x4e(editor=<register ESI not in topmost frame>, nCursor=<is not available>, str=<is not available>, len=0xfffffffe, style=0x8d4fc0, flags=0x0) [/home/florian/wine-0.9.44/dlls/riched20/caret.c:394] in riched20 (0x00336378) 4 0x7dc920b8 ME_InsertTextFromCursor+0x178(editor=0x8d2860, nCursor=0x0, str=0x33673c, len=0x1, style=0x8d4fc0) [/home/florian/wine-0.9.44/dlls/riched20/caret.c:515] in riched20 (0x003363c8) 5 0x7dc9df79 RTFFlushUnicodeOutputBuffer+0x49(info=<register ESI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/riched20/reader.c:2659] in riched20 (0x003363f8) 6 0x7dc9519d ME_RTFReadHook+0x27d(info=<register EDI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/riched20/editor.c:420] in riched20 (0x003364e8) 7 0x7dc9eb08 RTFGetToken+0x38(info=<register ESI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/riched20/reader.c:432] in riched20 (0x00336508) 8 0x7dc9ec88 RTFRead+0x28(info=<register ESI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/riched20/reader.c:345] in riched20 (0x00336528) 9 0x7dc94ec2 ME_StreamIn+0x5e2(editor=0x8d2860, format=<is not available>, stream=<is not available>) [/home/florian/wine-0.9.44/dlls/riched20/editor.c:678] in riched20 (0x0033c6f8) 10 0x7dc973e6 RichEditWndProc_common+0x1416(hWnd=0x10044, msg=<register EDI not in topmost frame>, wParam=0x8002, lParam=0x33da50, unicode=0x0) [/home/florian/wine-0.9.44/dlls/riched20/editor.c:1465] in riched20 (0x0033d048) 11 0x7dc9a1b0 RichEditWndProcA+0x20(hWnd=0x10044, msg=0x449, wParam=0x8002, lParam=0x33da50) [/home/florian/wine-0.9.44/dlls/riched20/editor.c:2657] in riched20 (0x0033d058) 12 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033d088) 13 0x7e9bbb8b call_window_proc+0x6b(hwnd=<register EDI not in topmost frame>, msg=0x449, wp=0x8002, lp=0x33da50, result=0x33d7a8, arg=0x7dc9a190) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:468] in user32 (0x0033d0c8) 14 0x7e9bfd51 WINPROC_CallProcWtoA+0x181(callback=0x7e9bbb20, hwnd=0x10044, msg=0x449, wParam=0x8002, lParam=0x33da50, result=0x33d7a8, arg=0x7dc9a190) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:1285] in user32 (0x0033d778) 15 0x7e9c0e2f CallWindowProcW+0x13f(func=<register ESI not in topmost frame>, hwnd=0x10044, msg=0x449, wParam=0x8002, lParam=0x33da50) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2331] in user32 (0x0033d7b8) 16 0x129ca83b in srmm (+0xa83b) (0x0033d820) 17 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033d850) 18 0x7e9bbb8b call_window_proc+0x6b(hwnd=<register EDI not in topmost frame>, msg=0x449, wp=0x8002, lp=0x33da50, result=0x33d930, arg=0x129ca52f) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:468] in user32 (0x0033d890) 19 0x7e9c0f51 WINPROC_call_window+0xe1(hwnd=<register ESI not in topmost frame>, msg=0x449, wParam=0x8002, lParam=0x33da50, result=0x33d930, unicode=0x1, mapping=0x3e9) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2220] in user32 (0x0033d8d0) 20 0x7e987c55 call_window_proc+0xd5(hwnd=<register ESI not in topmost frame>, msg=0x449, wparam=0x8002, lparam=0x33da50, unicode=0x1, same_thread=0x1, mapping=0x3e9) [/home/florian/wine-0.9.44/dlls/user32/message.c:1615] in user32 (0x0033d940) 21 0x7e98ba43 send_message+0x223(info=<register EDI not in topmost frame>, res_ptr=0x33d9dc, unicode=<register ESI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/user32/message.c:2444] in user32 (0x0033d9a0) 22 0x7e98beca SendMessageW+0x4a(hwnd=0x10044, msg=0x449, wparam=0x8002, lparam=0x33da50) [/home/florian/wine-0.9.44/dlls/user32/message.c:2567] in user32 (0x0033d9e0) 23 0x7e95369c SendDlgItemMessageW+0x4c(hwnd=0x50030, id=0x3e9, msg=0x449, wParam=0x8002, lParam=0x33da50) [/home/florian/wine-0.9.44/dlls/user32/dialog.c:1269] in user32 (0x0033da00) 24 0x129c6105 in srmm (+0x6105) (0x0033da6c) 25 0x129c47ec in srmm (+0x47ec) (0x0033e1a0) 26 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033e1d0) 27 0x7e9bd1f5 call_dialog_proc+0x65(hwnd=<register EDI not in topmost frame>, msg=0x40b, wp=0x0, lp=0x0, result=0x33e240, arg=0x129c1739) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:490] in user32 (0x0033e210) 28 0x7e9c0be1 WINPROC_CallDlgProcW+0xa1(func=<register ESI not in topmost frame>, hwnd=0x50030, msg=0x40b, wParam=0x0, lParam=0x0) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2424] in user32 (0x0033e250) 29 0x7e94f9a2 DefDlgProcW+0x82(hwnd=<register ESI not in topmost frame>, msg=0x40b, wParam=0x0, lParam=0x0) [/home/florian/wine-0.9.44/dlls/user32/defdlg.c:488] in user32 (0x0033e280) 30 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033e2b0) 31 0x7e9bbb8b call_window_proc+0x6b(hwnd=<register EDI not in topmost frame>, msg=0x40b, wp=0x0, lp=0x0, result=0x33e390, arg=0x7e94f920) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:468] in user32 (0x0033e2f0) 32 0x7e9c0f51 WINPROC_call_window+0xe1(hwnd=<register ESI not in topmost frame>, msg=0x40b, wParam=0x0, lParam=0x0, result=0x33e390, unicode=0x1, mapping=0x33eb1c) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2220] in user32 (0x0033e330) 33 0x7e987c55 call_window_proc+0xd5(hwnd=<register ESI not in topmost frame>, msg=0x40b, wparam=0x0, lparam=0x0, unicode=0x1, same_thread=0x1, mapping=0x33eb1c) [/home/florian/wine-0.9.44/dlls/user32/message.c:1615] in user32 (0x0033e3a0) 34 0x7e98ba43 send_message+0x223(info=<register EDI not in topmost frame>, res_ptr=0x33e43c, unicode=<register ESI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/user32/message.c:2444] in user32 (0x0033e400) 35 0x7e98beca SendMessageW+0x4a(hwnd=0x50030, msg=0x40b, wparam=0x0, lparam=0x0) [/home/florian/wine-0.9.44/dlls/user32/message.c:2567] in user32 (0x0033e440) 36 0x129c3671 in srmm (+0x3671) (0x0033eb74) 37 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033eba4) 38 0x7e9bd1f5 call_dialog_proc+0x65(hwnd=<register EDI not in topmost frame>, msg=0x40c, wp=0xab4a74, lp=0x12fc4d9, result=0x33ec14, arg=0x129c1739) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:490] in user32 (0x0033ebe4) 39 0x7e9c0be1 WINPROC_CallDlgProcW+0xa1(func=<register ESI not in topmost frame>, hwnd=0x50030, msg=0x40c, wParam=0xab4a74, lParam=0x12fc4d9) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2424] in user32 (0x0033ec24) 40 0x7e94f9a2 DefDlgProcW+0x82(hwnd=<register ESI not in topmost frame>, msg=0x40c, wParam=0xab4a74, lParam=0x12fc4d9) [/home/florian/wine-0.9.44/dlls/user32/defdlg.c:488] in user32 (0x0033ec54) 41 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033ec84) 42 0x7e9bbb8b call_window_proc+0x6b(hwnd=<register EDI not in topmost frame>, msg=0x40c, wp=0xab4a74, lp=0x12fc4d9, result=0x33ed64, arg=0x7e94f920) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:468] in user32 (0x0033ecc4) 43 0x7e9c0f51 WINPROC_call_window+0xe1(hwnd=<register ESI not in topmost frame>, msg=0x40c, wParam=0xab4a74, lParam=0x12fc4d9, result=0x33ed64, unicode=0x1, mapping=0xab4a74) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2220] in user32 (0x0033ed04) 44 0x7e987c55 call_window_proc+0xd5(hwnd=<register ESI not in topmost frame>, msg=0x40c, wparam=0xab4a74, lparam=0x12fc4d9, unicode=0x1, same_thread=0x1, mapping=0xab4a74) [/home/florian/wine-0.9.44/dlls/user32/message.c:1615] in user32 (0x0033ed74) 45 0x7e98ba43 send_message+0x223(info=<register EDI not in topmost frame>, res_ptr=0x33ee10, unicode=<register ESI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/user32/message.c:2444] in user32 (0x0033edd4) 46 0x7e98beca SendMessageW+0x4a(hwnd=0x50030, msg=0x40c, wparam=0xab4a74, lparam=0x12fc4d9) [/home/florian/wine-0.9.44/dlls/user32/message.c:2567] in user32 (0x0033ee14) 47 0x129c1560 in srmm (+0x1560) (0x0033ee44) 48 0x0040275d in miranda32 (+0x275d) (0x0033ee6c) 49 0x12581ff1 in dbx_3x (+0x1ff1) (0x0033eed0) 50 0x00402d6f in miranda32 (+0x2d6f) (0x0033eee8) 51 0x129c37ae in srmm (+0x37ae) (0x0033f618) 52 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033f648) 53 0x7e9bd1f5 call_dialog_proc+0x65(hwnd=<register EDI not in topmost frame>, msg=0x40a, wp=0x0, lp=0x7d647a18, result=0x33f6b8, arg=0x129c1739) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:490] in user32 (0x0033f688) 54 0x7e9c0be1 WINPROC_CallDlgProcW+0xa1(func=<register ESI not in topmost frame>, hwnd=0x50030, msg=0x40a, wParam=0x0, lParam=0x7d647a18) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2424] in user32 (0x0033f6c8) 55 0x7e94f9a2 DefDlgProcW+0x82(hwnd=<register ESI not in topmost frame>, msg=0x40a, wParam=0x0, lParam=0x7d647a18) [/home/florian/wine-0.9.44/dlls/user32/defdlg.c:488] in user32 (0x0033f6f8) 56 0x7e9bb4aa WINPROC_wrapper+0x1a() in user32 (0x0033f728) 57 0x7e9bbb8b call_window_proc+0x6b(hwnd=<register EDI not in topmost frame>, msg=0x40a, wp=0x0, lp=0x7d647a18, result=0x33f808, arg=0x7e94f920) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:468] in user32 (0x0033f768) 58 0x7e9c0f51 WINPROC_call_window+0xe1(hwnd=<register ESI not in topmost frame>, msg=0x40a, wParam=0x0, lParam=0x7d647a18, result=0x33f808, unicode=0x1, mapping=0xab4a74) [/home/florian/wine-0.9.44/dlls/user32/winproc.c:2220] in user32 (0x0033f7a8) 59 0x7e987c55 call_window_proc+0xd5(hwnd=<register ESI not in topmost frame>, msg=0x40a, wparam=0x0, lparam=0x7d647a18, unicode=0x1, same_thread=0x1, mapping=0xab4a74) [/home/florian/wine-0.9.44/dlls/user32/message.c:1615] in user32 (0x0033f818) 60 0x7e98ba43 send_message+0x223(info=<register EDI not in topmost frame>, res_ptr=0x33f8b4, unicode=<register ESI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/user32/message.c:2444] in user32 (0x0033f878) 61 0x7e98beca SendMessageW+0x4a(hwnd=0x50030, msg=0x40a, wparam=0x0, lparam=0x7d647a18) [/home/florian/wine-0.9.44/dlls/user32/message.c:2567] in user32 (0x0033f8b8) 62 0x129c15d9 in srmm (+0x15d9) (0x0033f8ec) 63 0x00402817 in miranda32 (+0x2817) (0x0033f910) 64 0x7efc5747 invoke_apc+0x87(call=0x33fa68, result=<register EDI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/ntdll/sync.c:664] in ntdll (0x0033f990) 65 0x7efc5db1 NTDLL_wait_for_multiple_objects+0x1c1(count=0x2, handles=0x33fb08, flags=0x6, timeout=0x0, signal_object=0x0) [/home/florian/wine-0.9.44/dlls/ntdll/sync.c:875] in ntdll (0x0033faa0) 66 0x7efc60a0 NtWaitForMultipleObjects+0x60(count=<register ESI not in topmost frame>, handles=0x33fb08, wait_all=0x0, alertable=0x2, timeout=0x0) [/home/florian/wine-0.9.44/dlls/ntdll/sync.c:911] in ntdll (0x0033fad0) 67 0x7ee537c7 WaitForMultipleObjectsEx+0x137(count=0x2, handles=0x33fc80, wait_all=0x0, timeout=0xffffffff, alertable=0x2) [/home/florian/wine-0.9.44/dlls/kernel32/sync.c:192] in kernel32 (0x0033fc20) 68 0x7e194f5b X11DRV_MsgWaitForMultipleObjectsEx+0xeb(count=0x2, handles=0x33fc80, timeout=0xffffffff, mask=0x4ff, flags=<register EDI not in topmost frame>) [/home/florian/wine-0.9.44/dlls/winex11.drv/event.c:297] in winex11 (0x0033fc50) 69 0x7e9878f5 MsgWaitForMultipleObjectsEx+0xf5(count=<register ESI not in topmost frame>, pHandles=0x45d1f4, timeout=0xffffffff, mask=<is not available>, flags=<is not available>) [/home/florian/wine-0.9.44/dlls/user32/message.c:3260] in user32 (0x0033fe00) 70 0x0040191f in miranda32 (+0x191f) (0x0033fe1c) 71 0x00401a21 in miranda32 (+0x1a21) (0x7e98a670) 72 0x04ffbe56 (0x57e58955) 73 0x00000000 (0x00000000) 0xb7d5859d memmove+0x4d in libc.so.6: repe movsl (%esi),%es:(%edi) Modules: Module Address Debug info Name (107 modules) PE 400000- 48c000 Export miranda32 PE 12000000-12011000 Deferred zlib PE 12240000-1227c000 Deferred chat PE 122c0000-122d2000 Deferred clist_classic PE 12580000-12589000 Export dbx_3x PE 12640000-12689000 Deferred icq PE 126e0000-126ee000 Deferred import PE 127c0000-1282e000 Deferred jabber PE 128a0000-128ce000 Deferred msn PE 129c0000-129d5000 Export srmm ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7da18000-7da23000 Deferred libgcc_s.so.1 ELF 7da41000-7da56000 Deferred wtsapi32<elf> \-PE 7da50000-7da56000 \ wtsapi32 ELF 7dc78000-7dcbe000 Dwarf riched20<elf> \-PE 7dc80000-7dcbe000 \ riched20 ELF 7dcbe000-7dd0f000 Deferred libgcrypt.so.11 ELF 7dd0f000-7dd22000 Deferred libtasn1.so.3 ELF 7dd22000-7dd50000 Deferred libcrypt.so.1 ELF 7dd50000-7ddbe000 Deferred libgnutls.so.13 ELF 7ddbe000-7dded000 Deferred libcups.so.2 ELF 7ddf0000-7ddf6000 Deferred libnss_dns.so.2 ELF 7ddf6000-7ddf9000 Deferred libnss_mdns4_minimal.so.2 ELF 7deb0000-7dec5000 Deferred midimap<elf> \-PE 7dec0000-7dec5000 \ midimap ELF 7dec5000-7deeb000 Deferred msacm32<elf> \-PE 7ded0000-7deeb000 \ msacm32 ELF 7deeb000-7df03000 Deferred msacm32<elf> \-PE 7def0000-7df03000 \ msacm32 ELF 7df03000-7df3e000 Deferred wineoss<elf> \-PE 7df10000-7df3e000 \ wineoss ELF 7df3e000-7df70000 Deferred uxtheme<elf> \-PE 7df50000-7df70000 \ uxtheme ELF 7df70000-7df75000 Deferred libxfixes.so.3 ELF 7df75000-7df7e000 Deferred libxcursor.so.1 ELF 7df7e000-7df9b000 Deferred imm32<elf> \-PE 7df90000-7df9b000 \ imm32 ELF 7df9b000-7df9e000 Deferred libxrandr.so.2 ELF 7df9e000-7dfa6000 Deferred libxrender.so.1 ELF 7dfa6000-7dfa9000 Deferred libxinerama.so.1 ELF 7dfa9000-7dfb0000 Deferred libdrm.so.2 ELF 7dfb0000-7e01a000 Deferred libgl.so.1 ELF 7e01a000-7e01f000 Deferred libxdmcp.so.6 ELF 7e01f000-7e022000 Deferred libxau.so.6 ELF 7e022000-7e10e000 Deferred libx11.so.6 ELF 7e10e000-7e11c000 Deferred libxext.so.6 ELF 7e11c000-7e121000 Deferred libxxf86vm.so.1 ELF 7e121000-7e139000 Deferred libice.so.6 ELF 7e139000-7e142000 Deferred libsm.so.6 ELF 7e151000-7e155000 Deferred libgpg-error.so.0 ELF 7e157000-7e1e8000 Dwarf winex11<elf> \-PE 7e170000-7e1e8000 \ winex11 ELF 7e2bc000-7e2dc000 Deferred libexpat.so.1 ELF 7e2dc000-7e307000 Deferred libfontconfig.so.1 ELF 7e307000-7e31b000 Deferred libz.so.1 ELF 7e31b000-7e385000 Deferred libfreetype.so.6 ELF 7e39a000-7e3ff000 Deferred msvcrt<elf> \-PE 7e3b0000-7e3ff000 \ msvcrt ELF 7e3ff000-7e49b000 Deferred oleaut32<elf> \-PE 7e410000-7e49b000 \ oleaut32 ELF 7e49b000-7e4f4000 Deferred rpcrt4<elf> \-PE 7e4b0000-7e4f4000 \ rpcrt4 ELF 7e4f4000-7e590000 Deferred ole32<elf> \-PE 7e500000-7e590000 \ ole32 ELF 7e590000-7e5c5000 Deferred winspool<elf> \-PE 7e5a0000-7e5c5000 \ winspool ELF 7e5c5000-7e61d000 Deferred shlwapi<elf> \-PE 7e5d0000-7e61d000 \ shlwapi ELF 7e61d000-7e71e000 Deferred shell32<elf> \-PE 7e630000-7e71e000 \ shell32 ELF 7e71e000-7e7be000 Deferred comdlg32<elf> \-PE 7e730000-7e7be000 \ comdlg32 ELF 7e7be000-7e7d7000 Deferred version<elf> \-PE 7e7c0000-7e7d7000 \ version ELF 7e7d7000-7e864000 Deferred winmm<elf> \-PE 7e7e0000-7e864000 \ winmm ELF 7e864000-7e8fa000 Deferred gdi32<elf> \-PE 7e880000-7e8fa000 \ gdi32 ELF 7e8fa000-7ea35000 Dwarf user32<elf> \-PE 7e910000-7ea35000 \ user32 ELF 7ea35000-7eaf3000 Deferred comctl32<elf> \-PE 7ea40000-7eaf3000 \ comctl32 ELF 7eaf3000-7eb3a000 Deferred advapi32<elf> \-PE 7eb00000-7eb3a000 \ advapi32 ELF 7eb3a000-7eb4d000 Deferred libresolv.so.2 ELF 7eb4d000-7eb6b000 Deferred iphlpapi<elf> \-PE 7eb50000-7eb6b000 \ iphlpapi ELF 7eb6b000-7eb96000 Deferred ws2_32<elf> \-PE 7eb70000-7eb96000 \ ws2_32 ELF 7eb96000-7ebb0000 Deferred wsock32<elf> \-PE 7eba0000-7ebb0000 \ wsock32 ELF 7edcf000-7eef3000 Dwarf kernel32<elf> \-PE 7edf0000-7eef3000 \ kernel32 ELF 7eef3000-7eefe000 Deferred libnss_files.so.2 ELF 7eefe000-7ef08000 Deferred libnss_nis.so.2 ELF 7ef08000-7ef1e000 Deferred libnsl.so.1 ELF 7ef1e000-7ef27000 Deferred libnss_compat.so.2 ELF 7ef27000-7ef4c000 Deferred libm.so.6 ELF 7ef4d000-7ef61000 Deferred lz32<elf> \-PE 7ef50000-7ef61000 \ lz32 ELF 7ef61000-7f000000 Dwarf ntdll<elf> \-PE 7ef70000-7f000000 \ ntdll ELF b7ce8000-b7cec000 Deferred libdl.so.2 ELF b7cec000-b7e1d000 Export libc.so.6 ELF b7e1d000-b7e2f000 Deferred libpthread.so.0 ELF b7e45000-b7f59000 Deferred libwine.so.1 ELF b7f5b000-b7f72000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000a 0000000c 0 0000000b 0 00000008 (D) C:\Programme\Miranda IM\miranda32.exe 00000013 0 00000012 15 00000010 0 0000000f 0 0000000e 0 0000000d 0 00000009 0 <==

2 1

Regression at #9443 - caused by "winex11: Force a window to managed mode when it is activated"
by Alex Villacís Lasso 25 Aug '07

25 Aug '07

Alexandre Julliard escribió: > Module: wine > Branch: master > Commit: f48eb1581dfe176043cbca5c46400c0f86eb5552 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=f48eb1581dfe176043cbca5c4… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Aug 20 22:06:50 2007 +0200 > > winex11: Force a window to managed mode when it is activated. > > --- This patch causes a regression in Visual Basic apps that display a drop-down combo - the drop-down is displayed behind the dialog instead of over it. Details and URL of demostration at http://bugs.winehq.org/show_bug.cgi?id=9443 . Just discovered it minutes ago. Reversing this patch fixes the regression. This is one of a series of patches on winex11 committed on August 20. Since they did not pass through wine-patches, I don't really know what are they supposed to fix. This is keeping me from simply submitting a reversal of this patch to wine-patches. Could somebody be so kind as to explain? Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 2

How do I build with ssl support on Ubuntu AMD 64?
by Scott Ritchie 25 Aug '07

25 Aug '07

Somehow, my amd64 packages keep ending up without ssl support being built at runtime. This is despite libssl-dev packages being installed - there doesn't appear to be a 32 bit version of them. Interestingly, the 32 bit wine package works with SSL when installed into the amd64 version. Is this because Wine doesn't dynamically link with libssl? See: http://bugs.winehq.org/show_bug.cgi?id=9292 Thanks, Scott Ritchie

1 0

Win API Stats page broken
by "Luis C. Busquets Pérez" 24 Aug '07

24 Aug '07

The web page indicating the status of the wine API: http://www.winehq.org/site/winapi_stats is corrupted and indicates an SQL error. I assume that there is some information in the database corrupted: Warning: mysql_num_fields(): supplied argument is not a valid MySQL result resource in /home/winehq/opt/tools/winapi_stats.php on line 118 Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/winehq/opt/tools/winapi_stats.php on line 129 last modified: Fri Aug 24 9:53:14 CDT 2007 Who deals with it?

1 0

AMD release developer tools with DX10 support
by Ian Macfarlane 24 Aug '07

24 Aug '07

I hope this is useful for testing DX10 stuff: Snippet: "[AMD] has updated its range of game programming tools, adding in DirectX 10 support to its popular suite" http://www.theinquirer.net/default.aspx?article=41904 Ian

1 0

[test.winehq.org] Addition of todo on the results page
by Paul Vriens 24 Aug '07

24 Aug '07

Hi, While I'm also busy with getting dll information on the page, I'm still adding stuff. This next iteration will add todo information on the pages. Current situation: http://test.winehq.org/data/200708221000/ There are several todo's for the Wine test but this is not shown on the page. New situation: http://www.xs4all.nl/~pvriens/200708221000_new/ The main difference is the yellow border on the left for some of the Wine tests (for the group shown in the Main Summary and individually at the Group 'Wine differences'). I deliberately didn't add all the todo tests on the Group level (as is done for the skips) as todo have more to do with tests/implementations than the actual system running the test. If there are no objections, I'll sent the necessary patches in a few days. Bit off topic: One thing that struck me was the difference in test results for the Wine runs. This has most likely to do with old Wine installations running new tests. I will add the Wine version to the infrastructure soon so that these outcomes make more sense. -- Cheers, Paul.

3 5

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (patch)
by Alexandre Julliard 24 Aug '07

24 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > +static void setup_clipping(HWND hwnd, HDC hdc) > +{ > + RECT rc; > + HRGN hrgn; > + > + /* Native control has always a clipping region set when sending > + * the WM_CTLCOLORSTATIC and an application depends on it > + */ > + GetClientRect(hwnd, &rc); > + hrgn = CreateRectRgn(rc.left, rc.top, rc.right, rc.bottom); > + if (GetClipRgn(hdc, hrgn) == 0) > + SelectClipRgn(hdc, hrgn); > + DeleteObject(hrgn); > +} You need to set the region in all cases, intersecting with the existing one if any. Also you need to restore the previous region after painting. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cabinet 4: Don't extract a file if DoExtract is FALSE
by Alexandre Julliard 24 Aug '07

24 Aug '07

"James Hawkins" <truiken(a)gmail.com> writes: > Changelog: > * Don't extract a file if DoExtract is FALSE. This one fails make test: ../../../tools/runtest -q -P wine -M advpack.dll -T ../../.. -p advpack_test.exe.so files.c && touch files.ok files.c:465: Test failed: Expected dest\testdir to exist files.c:466: Test failed: Expected dest\b.txt to not exist files.c:467: Test failed: Expected dest\testdir\d.txt to not exist files.c:474: Test failed: Expected dest\testdir to exist files.c:475: Test failed: Expected dest\b.txt to not exist files.c:476: Test failed: Expected dest\testdir\d.txt to not exist files.c:483: Test failed: Expected dest\testdir to not exist make[2]: *** [files.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

1 0

What the web test reports need.
by Jakob Eriksson 24 Aug '07

24 Aug '07

We need a http://test.winehq.org/data/latest/ Which always points to the latest results. Instead of: http://test.winehq.org/data/200708221000/ etc... Who can fix this? regards, Jakob

2 1

Photoshop CS2 surprise
by Dan Kegel 23 Aug '07

23 Aug '07

I fired up Photoshop CS2 today on a hunch, and sure enough, it starts and runs just barely well enough to test! When it starts, you have to dismiss a dialog box, press ^C in the console, and then dismiss another dialog box, but after that you can open an image, edit it, and save it successfully. Quite a few menu items misbehave, so there's lots left to do, but this is a lovely improvement. It seems likely that Mikolaj's recent changes had something to do with this. He's been doing quite a bit on Photoshop lately. Go Mikolaj! - Dan

1 0

re: mscoree: Return S_OK if mono runtime is found
by Dan Kegel 23 Aug '07

23 Aug '07

Hi Bryan, I believe your patch lets me install WinBITS successfully. Thanks! - Dan p.s. To be precise, it let winetricks mono12 wine msiexec /i WinBITS.msi work. I then had to do winetricks gdiplus corefonts else the startup would complain about a missing font. Now mono's only complaining about GetThreadContext failed in gc, but that's another kettle of fish.

1 0

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (2nd version, with testcase, fixes bug #9195)
by James Hawkins 23 Aug '07

23 Aug '07

On 8/23/07, Mikolaj Zalewski <mikolajz(a)google.com> wrote: > Tests have shown that every control style should set the clipping > region so I've changed the patch. > You forgot the patch. -- James Hawkins

1 0

Application minimizing resizes it to icon size.
by Meelis Mägi 23 Aug '07

23 Aug '07

Hello, i have a silly question. Why does application resized to icon size when it gets minimized ? (also when switching desktops, but thats acts as minimizing i think) Reason i ask is that, there is MMO Ryzom (ryzom.com), that gets a bit confused when minimized and ingame UI gets messed up (only game i know that has this problem) If i comment out SetWindowPos() line in X11DRV_UnmapNotify() function (file dlls/winex11.drv/winpos.c), then ingame ui stays ok. thanks

2 3

Re: shlwapi: Fix UrlCombineW for absolute URLs without slashes.
by Dmitry Timoshkov 23 Aug '07

23 Aug '07

"Robert Shearman" <rob(a)codeweavers.com> wrote: > + process_case = (*base.pszSuffix == L'/') ? 5 : 1; Although using the L prefix is harmless in this case, it's better to avoid it in Wine code IMO. -- Dmitry.

1 0

[winetest] Use of HeapAlloc and friends
by Paul Vriens 23 Aug '07

23 Aug '07

Hi, Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. Cheers, Paul.

3 4

Re: wordpad: Add initial printing support
by Stefan Dösinger 23 Aug '07

23 Aug '07

Am Donnerstag, 23. August 2007 01:52 schrieb Alexander Nicolaysen Sørnes: > wordpad: Add initial printing support I usually don't read non-d3d patches, but when I saw the wordpad patches I decided to see what wordpad looks like today, and I am really impressed :-) Good work! This makes me wonder if Wine does or should register mime types for wordpad, notepad, regedit, msiexec or .bat files? We really don't have to be ashamed of our wordpad implementation, it is a nice lightweight editor for .rtf files.

2 1

Re: [PATCH try3 5/5] wininet: When sending INTERNET_STATUS_HANDLE_CLOSING make sure the freed handle is not yet available.
by Alexandre Julliard 23 Aug '07

23 Aug '07

Misha Koshelev <mk144210(a)bcm.edu> writes: > + /* As on native when the equivalent of WININET_Release is called, the handle > + * is already invalid, but if a new handle is created at this time it does > + * not yet get assigned the freed handle number */ > if( info ) > WININET_Release( info ); > > + EnterCriticalSection( &WININET_cs ); > + > + if( WININET_dwNextHandle > handle ) > + WININET_dwNextHandle = handle; > + > + LeaveCriticalSection( &WININET_cs ); This is wrong, the handle could have been reused by then, you can't assume it is still free. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] WineD3D: Fall back to drawStridedSlow if fog coords are used
by Ivan Gyurdiev 23 Aug '07

23 Aug '07

Stefan Dösinger wrote: > Up to now we've been lucky that all the games requireing manual fog coords > haven't used vertex buffers, thus we always went through drawStridedSlow. > Make sure that the fog also works with vertexbuffers > > As for the rejected patches from yesterday, I've moved them back to the bottom > of the queue when I fixed them, so I will resend them later. > > ------------------------------------------------------------------------ > > This patch is probably fine, but it makes me look into the surrounding code [ software blending, changing the strided data ], which is still incredibly misleading. That should go into its own function, with the FIXVBO macro removed (since all such macros are evil, without exception), and a big comment should be added that named access to the strided data is only valid in the fixed function pipeline and will not work in the shader pipeline. Maybe it makes sense to use two different structures to make this clearer - not sure.

2 1

Re: user32: static controls should have a clipping region set whilesending the WM_CTLCOLORSTATIC (with testcase, fixes bug #9195)
by Dmitry Timoshkov 23 Aug '07

23 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> wrote: > Photoshop ImageReady depends on it. You have added an explicit clipping to STATIC_PaintTextfn, but since you are working on it, please test other static styles as well. Btw, if you are keen on writing a test (or making your test generic) for button control, that would help in investigating and fixing the bug 7569 which suffers from the same problem. -- Dmitry.

1 0

New winetricks: updated fakeie6, added sha1 checksums
by Dan Kegel 23 Aug '07

23 Aug '07

Winetricks 1.27 is available for download at 1. Add sha1sums for most downloads 2. Note a few downloads are no longer available (replacements, anyone?) 3. Note mono11 is deprecated 4. Add Mikołaj's nifty fakeie changes (see http://bugs.winehq.org/show_bug.cgi?id=9036) As always, it's up at http://kegel.com/wine/winetricks Share and enjoy (TM)! - Dan (Share and Enjoy is a registered trademark of the Sirius Cybernetics Corp. See http://en.wikipedia.org/wiki/Sirius_Cybernetics_Corporation http://www.zootle.net/afda/share-and-enjoy.shtml )

1 0

re: Using pthread_create within Wine
by Dan Kegel 22 Aug '07

22 Aug '07

Phil wrote: >The Wine socket implementation has problems when it comes to select. >A fix for this problem is not currently on anybody's radar. > http://www.winehq.org/pipermail/wine-devel/2006-February/044588.html Hmm. You never filed a bug at http://bugs.winehq.org for this, it seems. Could you, please? Incidentally, I ported your test app to Unix, and on Linux, it prints out THIS IS WINE. I'm not sure why you can't adapt your code to deal with the difference in select behavior -- is the problem third party code you have no source for? - Dan

1 0

re: gphoto2.ds: remove camera import UI
by Dan Kegel 22 Aug '07

22 Aug '07

Lei wrote: > ... > The alternative is to keep the GUI. It is useful in the case where > there's many pictures on the camera, and the user just want to import > a few of them. We would need to: > > - modify the GUI to fix the crash > - do not automatically generate download thumbnails, but rather, > present the user with the options to download thumbnails, or just go > ahead and import all pictures > - perhaps add a winecfg option to turn off the GUI Rather than remove all that nearly-working code, how about keeping it, adding the winecfg option, and making it default to off for now? (i.e. leave fixing the bug for later.) That should be a smaller, less violent patch... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 3

Using pthread_create within Wine
by Phil Lodwick 22 Aug '07

22 Aug '07

Greetings, I have a proprietary library that has both Windows and Linux ports. The Windows DLL has problems running on Wine, so I have created a builtin version of this DLL in Wine. This has worked fine, except for one function that basically creates a new thread and fires back events to the calling Window application. I believe I have traced this down to the Linux version of the library creating the new thread with pthread_create. Windows.exe Call_dll_to_spawn_thread_and_register_callback(MyCallbackfunc); Windows DLL implemented in wine: void * NewThread(void *p) { MyParams *params = (MyParams *)p; for (i = 0; i < 500000; i++) p->Callback(); } void Call_dll_to_spawn_thread_and_register_callback(void (*callback)()) { MyParams *params = (MyParams *)malloc(sizeof(MyParams)); params->Callback = callback; pthread_create(&MyThread, NULL, NewThread, (void *)params); } If instead of using pthread_create I use CreateThread, I never have a problem. I notice no other wine DLLs are using pthread_create and I have seen hints that this might not work. If so, how do I use the Linux library. (Call_dll_to_spawn_thread_and_register_callback is just simulating what the Linux library would do) Do I create a separate thread using CreateThread to communicate back to the Window application, so that Call_dll_to_spawn_thread_and_register_callback effectively creates two threads, one using CreateThread (Wine DLL), one using pthread_create (Linux Library) and then do synchronization between the two? Any help, suggestion, ideas, questions would be greatly appreciated. Phil

4 5

Compositing GL
by Chris Robinson 22 Aug '07

22 Aug '07

Over the past several days, I've been working with some people in #winehackers on a way to help solve the problems Wine faces with OpenGL.. namely the lack of useable onscreen pixel formats and broken child windown rendering. Here's a patch for your perusal in hopes to generate feedback. What this does is, it renders GL to an offscreen buffer the size of the window it's rendering to, first trying a redirected window (if you have the Xcomposite extension), then falling back to GLXPixmaps (which may be slower, especially if you don't have AIGLX). The offscreen buffer is then copied to the window it should be displaying on using X, acting in a manner nearly identical to how Vista composites OpenGL (as described here: http://www.opengl.org/pipeline/article/vol003_7/ ). Given that it uses X to do the final composite, it obeys all clipping regions, which means it works even on obscured child windows. And since it's offscreen, it won't interfere with, or be bothered by, Wine's window. It also allows it to use other visuals/pixel formats than Wine's window (not done in this patch yet). There is a speed hit, however. The DX9 swap chains demo, which gets about 280 FPS for me normally, gets about 80 to 90 FPS with the compositing method. It seems to be a ceiling though, as other more GPU intense apps have no extra noticeable slow down. Still, as an optimization, it can render directly to the window when it's being used on the whole window and the selected pixel format matches the current visual (this bit is disabled in the patch since it's for testing offscreen rendering, but it's simple to re-enable). Further, a registry setting (HKCU\Software\Wine\X11 Driver\CompositeGL) can be used to force GL compositing off to give you the current behavior (single onscreen pixel format, broken child window rendering). This obviously isn't the final patch, however it's likely what the final result will be like, forgoing unforeseen issues. Questions and comments are welcome.

4 7

Re: include: add some definitions to winioctl.h (patch)
by Robert Shearman 22 Aug '07

22 Aug '07

Mikolaj Zalewski wrote: > -#define IOCTL_STORAGE_GET_MEDIA_TYPES CTL_CODE(IOCTL_STORAGE_BASE, 0x0300, METHOD_BUFFERED, FILE_ANY_ACCESS) > -#define IOCTL_STORAGE_GET_MEDIA_TYPES_EX CTL_CODE(IOCTL_STORAGE_BASE, 0x0301, METHOD_BUFFERED, FILE_ANY_ACCESS) > +#define IOCTL_STORAGE_GET_MEDIA_TYPES CTL_CODE(IOCTL_STORAGE_BASE, 0x0300, METHOD_BUFFERED, FILE_ANY_ACCESS) > +#define IOCTL_STORAGE_GET_MEDIA_TYPES_EX CTL_CODE(IOCTL_STORAGE_BASE, 0x0301, METHOD_BUFFERED, FILE_ANY_ACCESS) > +#define IOCTL_STORAGE_GET_MEDIA_SERIAL_NUMBER CTL_CODE(IOCTL_STORAGE_BASE, 0x0305, METHOD_BUFFERED, FILE_ANY_ACCESS) > The above should be 0x0304 instead of 0x0305. > +#define IOCTL_STORAGE_GET_HOTPLUG_INFO CTL_CODE(IOCTL_STORAGE_BASE, 0x0305, METHOD_BUFFERED, FILE_ANY_ACCESS) > +#define IOCTL_STORAGE_SET_HOTPLUG_INFO CTL_CODE(IOCTL_STORAGE_BASE, 0x0306, METHOD_BUFFERED, FILE_READ_ACCESS) > -- Rob Shearman

2 1

gphoto2.ds: remove camera import UI
by Luke Bratch 22 Aug '07

22 Aug '07

--- Alexandre Julliard <julliard at winehq.org> wrote: > > Rather than remove all that nearly-working code, > > how about keeping it, adding the winecfg option, > > and making it default to off for now? > > That option is much too specific to go in winecfg, it's > something most > users don't care about. What you could do though is have a "don't show > this dialog again" option in the dialog itself. How about a registry key? ___________________________________________________________ Want ideas for reducing your carbon footprint? Visit Yahoo! For Good http://uk.promotions.yahoo.com/forgood/environment.html

1 0

Re: [2/5] WineD3D: Refuse to lock locked surfaces
by H. Verbeet 22 Aug '07

22 Aug '07

On 22/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Spotted by DCT > I don't know what the DCT actually tests, but should it refuse to lock any locked surface, or only when the rectangles overlap? Of course a test would be nice, considering surface locking behaves somewhat different between ddraw, d3d8 and d3d9.

2 2

Re: [5/5] WineD3D: Fake occlusion queries if the wrong context is active
by H. Verbeet 22 Aug '07

22 Aug '07

On 22/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Can't we wait for the other thread & context to become active? Afaik occlusion queries are allowed to block on Windows.

2 1

Changing Bugzilla settings so a single person can't confirm bugs by "popular vote"
by Kai Blin 22 Aug '07

22 Aug '07

Hi folks, While working on bug 9405, I realized that all 20 votes on that bug were made by the reporter. I think that's pretty lame, so I've asked the bugzilla folks if there's a way to fix that. They said that the settings should be obvious when editing the product. Can we please fix that? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

4 4

Re: advapi32: Add more tests for CryptVerifySignatureW, and correct its parameter checking
by Alexandre Julliard 22 Aug '07

22 Aug '07

"Juan Lang" <juan.lang(a)gmail.com> writes: > From 53a45e7e2adf3b8591f2c07501e7b37538d95657 Mon Sep 17 00:00:00 2001 > From: Juan Lang <juan.lang(a)gmail.com> > Date: Tue, 21 Aug 2007 15:10:35 -0700 > Subject: [PATCH] Add more tests for CryptVerifySignatureW, and correct its parameter checking This breaks the tests: ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok rsaenh.c:1081: Test failed: Expected ERROR_INVALID_PARAMETER error, got 80090006 make: *** [rsaenh.ok] Error 1 Also the indentation is messed up, please fix your tab size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: How to Calling PE Dlls on linux??
by trulyliu 22 Aug '07

22 Aug '07

Hi, Damjan Jovanovic Thank you tired of the answer to my questions. I carefully read the wine part of the code and development document, searched in mail lists, these days. And I got some inspiration from wine plugin API wiki page and wine loader's code. I am considering of an approach. Link preloader and related resource(libwine) with my Linux native App. Do some modify with wine_init function, and call it before main(). This can be implemented by a global C++ objects's constructor. Upper two steps can deal with TEP and FS register. But I there may be another problem. If there was aready an static global C++ object in my App, How can I makde it initiatited after wine_init from in object. Do you have some other expostulate of this idea? BTW, I skim over mplayer and xine's parts of code. They don't dealwith TEB and FS register. They only do sth on LDT and allocat PE header before LoadeLibaray. Why they can run correctly??? 2007/8/22, Damjan Jovanovic <damjan.jov(a)gmail.com>: > > On 8/21/07, trulyliu <trulyliu(a)gmail.com> wrote: > > > > > > > > 2007/8/21, Damjan Jovanovic <damjan.jov(a)gmail.com>: > > > On 8/21/07, trulyliu <trulyliu(a)gmail.com> wrote: > > > > > > > > > > > > 2007/8/21, Damjan Jovanovic <damjan.jov(a)gmail.com>: > > > > > On 8/21/07, trulyliu <trulyliu(a)gmail.com> wrote: > > > > > > Can I made Arithmetic.dll.so ? And link it against my linux App? > > > > > > > > > > A library function runs in the context of the process that invokes > it. > > > > > A library doesn't have its own TEB/memory layout/exception > handling > > > > > that works independently of the process that calls it, no matter > how > > > > > it is compiled. If the wine plugin API is ever made, it will > modify > > > > > the process so it has what the library expects when the library > > > > > functions are called. > > > > > > > > > > Does your Arithmetic.dll.so call any Windows functions? If so, you > > > > > need wine and you will always need wine, plugin API or no plugin > API, > > > > > whether you compile it into a DLL or .dll.so. But if you only use > ANCI > > > > > C stuff you can compile it into a .so and use it without wine. > > > > > > > > > > If you want something that runs seamlessly on every operating > system > > > > > today, IMHO you should consider Java. > > > > > > > > > > > > > > > > > > > > > > Yes, Java may be a good choice for crossing platform. > > > > > > > > As you said, my Arithmetic.dll does not call any windows function. > > > > It's pure ANSI C library. What's the step of make .dll.so ?? > > > > > > > > Use winegcc or gcc ?? > > > > > > Use gcc and make a .so like this: > > > gcc -c arithmetic.c -fPIC > > > gcc arithmetic.o -shared -o arithmetic.so > > > > > > Then put it in /usr/lib and link to it like so: > > > gcc -c application.c > > > gcc application.o -o application -larithmetic > > > > > > > > > -- > > > > > > trulyliu(a)gmail.com > > > > > Damjan > > > > -- > > > > trulyliu(a)gmail.com > > > > > > > > > > Damjan > > > > gcc -c arithmetic.c -fPIC ??? > > I am sorry. I don't have Arithmetic.dll's source code. > > Can I use LoadLibaray() and GetProcAddress > > to get the function which Arithmetic.dll exports. > > No, for the reasons I talked about before. Eg. GetProcAddress() does > look up the current directory, which resides in the TEB, which AFAIK > resides in the FS CPU register on Windows. On Linux the FS register > contains something else, leading to a crash. > > At the moment, you can only use Windows DLLs from Windows applications > or from winelibs, which are Windows applications compiled to be able > to use Linux libraries as well. > > > -- > > trulyliu(a)gmail.com > > > > Damjan > -- trulyliu(a)gmail.com

1 1

Re: [kernel32/tests] Skip some not implemented functions and add a few skip's
by Francois Gouget 22 Aug '07

22 Aug '07

On Tue, 21 Aug 2007, Paul Vriens wrote: > Hi, > > GetTempPathW is not implemented on win9x. I did not actually read the test but it sounds like GetTempPathW() is not actually essential to the test. Could we replace it with another way to get the path for a temporary directory? Maybe even hard-code one, maybe adding the process id to make it somewhat unique? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

2 1

Re: [1/2] wined3d: Restore a line that got lost
by Stefan Dösinger 21 Aug '07

21 Aug '07

Am Dienstag, 21. August 2007 23:22 schrieb H. Verbeet: > This got lost by commit 92ce028a0b3aba513f8fb62d7021533896cd99f6. > > Changelog: > - Restore a line that got lost Actually I think we can remove that whole codeblock now. stateblock::apply and stateblock::capture have the needed states hardcoded now for _ALL, _VERTEX and _PIXEL stateblocks.

1 0

OS X and OpenGL
by Mike Kronenberg 21 Aug '07

21 Aug '07

Hello list, I'm a frequent user of wine and normally build my own copy, as no official distribution for Mac OS X exists. Lately I had to deal with a Program, that needs OpenGL. I found different hints on the list and around the net, that the current Apple X11 libGL is broken, so I tried different flavors of xdarwin and x11: X11R6.8.2 and X11R7.2. With X11R6.8 (compiled from fink) wine builds without error. (OpenGL Headers and libs where found) When I run the app, I get: err:wgl:X11DRV_wglGetProcAddress No libGL on this box - disabling OpenGL support ! err:wgl:X11DRV_wglGetProcAddress No libGL on this box - disabling OpenGL support ! err:wgl:X11DRV_wglGetProcAddress No libGL on this box - disabling OpenGL support ! err:wgl:X11DRV_wglGetProcAddress No libGL on this box - disabling OpenGL support ! err:wgl:X11DRV_wglGetProcAddress No libGL on this box - disabling OpenGL support ! err:wgl:X11DRV_wglGetProcAddress No libGL on this box - disabling OpenGL support ! err:wgl:X11DRV_ChoosePixelFormat No libGL on this box - disabling OpenGL support ! err:wgl:X11DRV_wglMakeCurrent No libGL on this box - disabling OpenGL support ! I modified opengl.c to see whether SONAME_LIBGL was set in as_opengl () and it was. With X11R7.2 (pkg form x.org) wine builds without error. (OpenGL Headers and libs where found) but it seams that libGL has a link to a nonexistent library (/usr/X11/ lib/GL), which crashes openGL32.dll when I run the app. Before I start some more debugging on my system: Do you have any hints? (Is this a linking problem / Anybody knows a working revision of X11 / recent bugs, etc) Txs Mike Intel Wine 0.9.43 OS X 10.4.10

1 0

Re: WineD3D: fix a null pointer dereference
by Stefan Dösinger 21 Aug '07

21 Aug '07

Am Dienstag, 21. August 2007 16:55 schrieb Roderick Colenbrander: > Hi, > > This patch gets Tiberian Sun working in ddraw OpenGL mode. Before it > suffered > > >from a null pointer dereference bug. This patch is ok with me, but there's a bad flaw with opengl'ed ddraw I want to point out Ddraw apps can just create offscreen surfaces and perform blits between them without creating a render target. To do anything in opengl, a context is needed, and a context needs a drawable. So no gl context without a render target in gl. Now the current code checks if the locked surface is a render target, and crashes because the render target array doesn't exist. This patch simply fixes this NULL pointer dereference. The essential problem remains though, that ddraw operations in gl won't work unless the app creates a render target. Currently it works because only operations on render targets use opengl, but there is code to have opengl do offscreen<->offscreen blits. That code(stretch_rect_fbo) is only used for d3d9, but when activated for ddraw apps too, we have to be careful.

1 0

Re: dinput: Fix compile with old input.h that missing input_absinfo
by Dmitry Timoshkov 21 Aug '07

21 Aug '07

"Vitaliy Margolen" <wine-patches(a)kievinfo.com> wrote: > +struct wine_input_absinfo { > + LONG value; > + LONG minimum; > + LONG maximum; > + LONG fuzz; > + LONG flat; > +}; If it's a kernel structure, it's better IMO to use the types that are actually used in the native structure instead of LONG. -- Dmitry.

1 0

Re: How to Calling PE Dlls on linux??
by Damjan Jovanovic 21 Aug '07

21 Aug '07

On 8/21/07, trulyliu <trulyliu(a)gmail.com> wrote: > Can I made Arithmetic.dll.so ? And link it against my linux App? A library function runs in the context of the process that invokes it. A library doesn't have its own TEB/memory layout/exception handling that works independently of the process that calls it, no matter how it is compiled. If the wine plugin API is ever made, it will modify the process so it has what the library expects when the library functions are called. Does your Arithmetic.dll.so call any Windows functions? If so, you need wine and you will always need wine, plugin API or no plugin API, whether you compile it into a DLL or .dll.so. But if you only use ANCI C stuff you can compile it into a .so and use it without wine. If you want something that runs seamlessly on every operating system today, IMHO you should consider Java. > 2007/8/21, Damjan Jovanovic <damjan.jov(a)gmail.com >: > > On 8/21/07, trulyliu <trulyliu(a)gmail.com > wrote: > > > > > I have tried these code, It works well. Thanks a lot. > > > Could I use gcc/g++ instead of winegcc/wineg++ ??? > > > mplayer use gcc as it's complier？ What's the mystery in it? > > > > > > > gcc/g++ would give you the wrong ABI (eg. 4 bytes per wide char > > instead of 2 bytes), and the special code needed to set up the Windows > > memory layout and the thread extension block and structured exception > > handling wouldn't get executed, leading to segfaults when you call any > > code that tries to access them. That's assuming you can even compile > > and link. > > > > That's why you need winegcc/wineg++. > > > > > trulyliu(a)gmail.com > > > > Damjan > > > > > > > > > > -- > trulyliu(a)gmail.com > Damjan

2 2

Re: [2/5] WineD3D: Use 0/0/0 as normal if no normal is supplied
by H. Verbeet 21 Aug '07

21 Aug '07

I'm not sure about this one. Unless explicitly checked for, (0, 0, 0) will cause a division by zero when trying to normalize it, and I don't know for sure if GL has well defined behaviour for it.

2 1

Re: [5/5] WineD3D: Fix fogstart == fogend with table fog
by H. Verbeet 21 Aug '07

21 Aug '07

On 21/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Feel free to suggest a better way to increase the fogend. My way works, but it > is not the nicest way. > Does this really matter? To me, this looks like a rather ugly hack to get the DCT to shut up.

2 1

Re: gdi: AddFontResource needs to support a second default directory
by Alexandre Julliard 21 Aug '07

21 Aug '07

"Dan Kegel" <dank(a)kegel.com> writes: > @@ -1727,6 +1736,22 @@ INT WineEngAddFontResourceEx(LPCWSTR file, DWORD flags, PVOID pdv) > { > INT ret = AddFontFileToList(unixname, NULL, NULL, ADDFONT_FORCE_BITMAP); > HeapFree(GetProcessHeap(), 0, unixname); > + if (!ret && !strchrW(file, '\\')) { > + /* http://support.installshield.com/kb/view.asp?pcode=ALL&articleid=Q100057 > + * suggests that in older versions of Windows, AddFontResource > + * paths were relative to %WINDIR%/Fonts instead of %WINDIR%/System > + * Retry assuming that's what went wrong. > + */ This comment is misleading, fonts are in WINDIR/fonts in all Windows versions, and we never look in WINDIR/system anyway. -- Alexandre Julliard julliard(a)winehq.org

2 1

How to Calling PE Dlls on linux??
by trulyliu 21 Aug '07

21 Aug '07

hi: I am sorry to disturb you with a question about calling PE Dll on linux. This is really an old question. I found the sameness issues in mail list. http://www.winehq.org/pipermail/wine-devel/2003-December/thread.html http://www.winehq.org/pipermail/wine-devel/2005-November/thread.html#41917 http://www.winehq.org/pipermail/wine-users/2004-August/014685.html http://www.winehq.org/pipermail/wine-devel/2006-August/050619.html I have tried the ways discussed in these threads。 But it's not clear enough how to do this. So I send this mail to you for some help. I have a PE Dll named Arithmetic.dll which exports a function, it's prototype is: void sort(unsigned int*, int num) I want to call the function in my Linux App. I used winedump to generate a spec file winedump spec Arithmetic.dll This comand generated three files: Arithmetic_dll.h Arithmetic_main.c and Arithmeticspec. What's the next exactly step I should do? What's the usage of the three files? And wow could I use them? I made reference to mplayer's implementation, It's code is a little clutter， and I don't have experience on MS D-Show. Could you give me some simple sample codes ?? Best Regards. -- trulyliu(a)gmail.com

4 5

Re: [patch] Garbage code in text string display
by Guan Xin 21 Aug '07

21 Aug '07

Q: Can you give a simple example of such a program (preferably downloadable)? A: Yes. If you have Simplified Chinese environment, you can try: http://update.cz88.net/soft/qqwry.rar which is a freeware for IP address-to-geographical address translation. Before patching WINE, most (though not all) labels and all buttons show garbage code. None after. Q:Can you add a conformance test showing that your patch is correct? A: I have tried editplus, acdsee, and gvim in en_US and zh_CN.GBK locale/encodings. They all ran well. I also tried the German version of winrar in de locale, no problem either. I don't think we need to prove this patch is correct because it is certainly wrong and introduced a bug. However, `any sufficiently advanced bug becomes a feature'. In the source code of Microsoft Windows NT/2k/XP, or to be excact, in the file "private/windows/shell/accesory/spechars/charmap.c" they confessed there is a bug in GDI that `assumes the font's default charset is always the system default locale'. I know peeking into The source code is illegal, but I've only done this some 24 hrs after I submitted this patch. So this patch has nothing to do with my undesirable deed. Xin On 8/19/07, Dan Kegel <dank(a)kegel.com> wrote: > Xin Guan wrote: > > This patch solves the problem that many MBCS programs display garbage code > > for text strings. Because most windows programmers do not handle charsets > > properly, we have to force DEFAULT_CHARSET in here. > > Can you give a simple example of such a program (preferably downloadable)? > > Can you add a conformance test showing that your patch is correct? > - Dan >

2 4

[Winetest RFI] What do you want out of the test suite?
by Paul Vriens 21 Aug '07

21 Aug '07

Hi, I just want to get people's opinion(s) about the needs/requirements/whishes for both the conformance tests themselves (including winetest) as well as the webpages. I'll collect the information and will put it on the wiki. Cheers, Paul.

5 16

Re: [PATCH try2 2/5] wininet: Free handle structs in WININET_Release.
by Robert Shearman 21 Aug '07

21 Aug '07

Misha Koshelev wrote: > This is necessary so that we send the INTERNET_STATUS_HANDLE_CLOSING before, for example > INTERNET_STATUS_CLOSE_CONNECTION gets sent from HTTP_CloseConnection in HTTP_CloseHTTPRequestHandle. > This can be tested on native/with native wininet on wine because although we do not send > INTERNET_STATUS_CLOSE_CONNECTION correctly when the data is finished reading on wine as native > does, if we simply don't read all the data (or any data, changing the while TRUE's to while FALSE's > in the InternetReadFiel_test for example in wininet/tests/http.c) then these do in fact get sent > as a response to InternetCloseHandle like they do on wine, and INTERNET_STATUS_HANDLE_CLOSING > always gets sent afterwards (last). > It seems like it would be better to add a close_connection method to go along with destroy, instead of leaving the handle in a half-destroyed state. Either that, or to not use INTERNET_SendCallback to send the callback in this case so that you don't have to have a WININETHANDLEHEADER object still around. -- Rob Shearman

2 1

Re: winefile: Save font settings for registry
by Dmitry Timoshkov 21 Aug '07

21 Aug '07

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > Changelog: > this patch add opportunity to save font option to the regestry, and load font > option from regestry in the winefile program Nothing prevents you from writing and reading the whole LOGFONT structure in one go. -- Dmitry.

1 0

dinput compile error
by Robert Reif 21 Aug '07

21 Aug '07

make[2]: Entering directory `/home/wine/wine/dlls/dinput' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings -Wpointer-arith -g -O2 -o joystick_linuxinput.o joystick_linuxinput.c joystick_linuxinput.c:153: field `axes' has incomplete type joystick_linuxinput.c:154: confused by earlier errors, bailing out make[2]: *** [joystick_linuxinput.o] Error 1 make[2]: Leaving directory `/home/wine/wine/dlls/dinput' It seems struct input_absinfo is not defined.

3 3

Re: [4/5] D3D9: Some caps fixes
by H. Verbeet 20 Aug '07

20 Aug '07

On 20/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Some functionality is implemented in d3d9.dll, not wined3d.dll. Add the needed caps */ > pCaps->DevCaps2 |= D3DDEVCAPS2_CAN_STRETCHRECT_FROM_TEXTURES; You should move that to filter_caps() as well, or at the very least add it to IDirect3DDevice9Impl_GetDeviceCaps().

2 1

Re: winefile: Save font settings for registry
by Michael Stefaniuc 20 Aug '07

20 Aug '07

Ivan Sinitsin wrote: > this is corrected patch for winefile. You want to use the explicit RegQueryValueExW and RegSetValueExW functions. bye michael > > This patch adds an opportunity to keep adjustments of a font between sessions, > if menu "Save settings on exit" is checked. > > > Changelog: > this patch add opportunity to save font option to the regestry, and load font > option from regestry in the winefile program > > > > ------------------------------------------------------------------------ > > Index: programs/winefile/winefile.c > =================================================================== > RCS file: /home/wine/wine/programs/winefile/winefile.c,v > retrieving revision 1.75 > diff -u -p -u -r1.75 winefile.c > --- programs/winefile/winefile.c 25 Oct 2006 18:31:13 -0000 1.75 > +++ programs/winefile/winefile.c 14 Jun 2007 07:22:19 -0000 > @@ -66,6 +66,20 @@ static const WCHAR reg_start_x[] = { 's' > static const WCHAR reg_start_y[] = { 's','t','a','r','t','Y','\0'}; > static const WCHAR reg_width[] = { 'w','i','d','t','h','\0'}; > static const WCHAR reg_height[] = { 'h','e','i','g','h','t','\0'}; > +static const WCHAR reg_font_height[] = { 'f','o','n','t','_','h','e','i','g','h','t','\0'}; > +static const WCHAR reg_font_width[] = { 'f','o','n','t','_','w','i','d','t','h','\0'}; > +static const WCHAR reg_font_escapement[] = { 'f','o','n','t','_','E','s','c','a','p','e','m','e','n','t','\0'}; > +static const WCHAR reg_font_orientation[] = { 'f','o','n','t','_','O','r','i','e','n','t','a','t','i','o','n','\0'}; > +static const WCHAR reg_font_weight[] = { 'f','o','n','t','_','W','e','i','g','h','t','\0'}; > +static const WCHAR reg_font_italic[] = { 'f','o','n','t','_','I','t','a','l','i','c','\0'}; > +static const WCHAR reg_font_underline[] = { 'f','o','n','t','_','U','n','d','e','r','l','i','n','e','\0'}; > +static const WCHAR reg_font_strikeout[] = { 'f','o','n','t','_','S','t','r','i','k','e','O','u','t','\0'}; > +static const WCHAR reg_font_charset[] = { 'f','o','n','t','_','C','h','a','r','S','e','t','\0'}; > +static const WCHAR reg_font_outprecision[] = { 'f','o','n','t','_','O','u','t','P','r','e','c','i','s','i','o','n','\0'}; > +static const WCHAR reg_font_clipprecision[] = { 'f','o','n','t','_','C','l','i','p','P','r','e','c','i','s','i','o','n','\0'}; > +static const WCHAR reg_font_quality[] = { 'f','o','n','t','_','Q','u','a','l','i','t','y','\0'}; > +static const WCHAR reg_font_pitchandfamily[] = { 'f','o','n','t','_','P','i','t','c','h','A','n','d','F','a','m','i','l','y','\0'}; > +static const WCHAR reg_font_facename[] = { 'f','o','n','t','_','F','a','c','e','N','a','m','e','\0'}; > > enum ENTRY_TYPE { > ET_WINDOWS, > @@ -1588,15 +1602,20 @@ static void get_path(Entry* dir, PTSTR p > > static windowOptions load_registry_settings(void) > { > - DWORD size; > + DWORD size, sizeW; > DWORD type; > HKEY hKey; > windowOptions opts; > + LOGFONT logfont; > + HFONT hFont; > > RegOpenKeyEx( HKEY_CURRENT_USER, registry_key, > 0, KEY_QUERY_VALUE, &hKey ); > > + hFont=GetStockObject(DEFAULT_GUI_FONT); > + GetObject(hFont,sizeof(logfont),&logfont); > size = sizeof(DWORD); > + sizeW = sizeof(logfont.lfFaceName); > > if( RegQueryValueEx( hKey, reg_start_x, NULL, &type, > (LPBYTE) &opts.start_x, &size ) != ERROR_SUCCESS ) > @@ -1614,8 +1633,51 @@ static windowOptions load_registry_setti > (LPBYTE) &opts.height, &size ) != ERROR_SUCCESS ) > opts.height = CW_USEDEFAULT; > > + RegQueryValueEx( hKey, reg_font_height, NULL, &type, > + (LPBYTE) &logfont.lfHeight, &size ); > + > + RegQueryValueEx( hKey, reg_font_width, NULL, &type, > + (LPBYTE) &logfont.lfWidth, &size ); > + > + RegQueryValueEx( hKey, reg_font_escapement, NULL, &type, > + (LPBYTE) &logfont.lfEscapement, &size ); > + > + RegQueryValueEx( hKey, reg_font_orientation, NULL, &type, > + (LPBYTE) &logfont.lfOrientation, &size ); > + > + RegQueryValueEx( hKey, reg_font_weight, NULL, &type, > + (LPBYTE) &logfont.lfWeight, &size ); > + > + RegQueryValueEx( hKey, reg_font_italic, NULL, &type, > + (LPBYTE) &logfont.lfItalic, &size ); > + > + RegQueryValueEx( hKey, reg_font_underline, NULL, &type, > + (LPBYTE) &logfont.lfUnderline, &size ); > + > + RegQueryValueEx( hKey, reg_font_strikeout, NULL, &type, > + (LPBYTE) &logfont.lfStrikeOut, &size ); > + > + RegQueryValueEx( hKey, reg_font_charset, NULL, &type, > + (LPBYTE) &logfont.lfCharSet, &size ); > + > + RegQueryValueEx( hKey, reg_font_outprecision, NULL, &type, > + (LPBYTE) &logfont.lfOutPrecision, &size ); > + > + RegQueryValueEx( hKey, reg_font_clipprecision, NULL, &type, > + (LPBYTE) &logfont.lfClipPrecision, &size ); > + > + RegQueryValueEx( hKey, reg_font_quality, NULL, &type, > + (LPBYTE) &logfont.lfQuality, &size ); > + > + RegQueryValueEx( hKey, reg_font_pitchandfamily, NULL, &type, > + (LPBYTE) &logfont.lfPitchAndFamily, &size ); > + > + RegQueryValueEx( hKey, reg_font_facename, NULL, &type, > + (LPBYTE) &logfont.lfFaceName, &sizeW); > + > RegCloseKey( hKey ); > > + Globals.hfont = CreateFontIndirect(&logfont); > return opts; > } > > @@ -1624,11 +1686,13 @@ static void save_registry_settings(void) > WINDOWINFO wi; > HKEY hKey; > INT width, height; > + LOGFONT logfont; > > wi.cbSize = sizeof( WINDOWINFO ); > GetWindowInfo(Globals.hMainWnd, &wi); > width = wi.rcWindow.right - wi.rcWindow.left; > height = wi.rcWindow.bottom - wi.rcWindow.top; > + GetObject(Globals.hfont, sizeof(logfont), &logfont); > > if ( RegOpenKeyEx( HKEY_CURRENT_USER, registry_key, > 0, KEY_SET_VALUE, &hKey ) != ERROR_SUCCESS ) > @@ -1651,6 +1715,34 @@ static void save_registry_settings(void) > (LPBYTE) &width, sizeof(DWORD) ); > RegSetValueEx( hKey, reg_height, 0, REG_DWORD, > (LPBYTE) &height, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_height, 0, REG_DWORD, > + (LPBYTE) &logfont.lfHeight, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_width, 0, REG_DWORD, > + (LPBYTE) &logfont.lfWidth, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_escapement, 0, REG_DWORD, > + (LPBYTE) &logfont.lfEscapement, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_orientation, 0, REG_DWORD, > + (LPBYTE) &logfont.lfOrientation, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_weight, 0, REG_DWORD, > + (LPBYTE) &logfont.lfWeight, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_italic, 0, REG_DWORD, > + (LPBYTE) &logfont.lfItalic, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_underline, 0, REG_DWORD, > + (LPBYTE) &logfont.lfUnderline, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_strikeout, 0, REG_DWORD, > + (LPBYTE) &logfont.lfStrikeOut, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_charset, 0, REG_DWORD, > + (LPBYTE) &logfont.lfCharSet, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_outprecision, 0, REG_DWORD, > + (LPBYTE) &logfont.lfOutPrecision, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_clipprecision, 0, REG_DWORD, > + (LPBYTE) &logfont.lfClipPrecision, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_quality, 0, REG_DWORD, > + (LPBYTE) &logfont.lfQuality, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_pitchandfamily, 0, REG_DWORD, > + (LPBYTE) &logfont.lfPitchAndFamily, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_facename, 0, REG_SZ, > + (LPBYTE) &logfont.lfFaceName,(strlenW(&logfont.lfFaceName) + 1)*sizeof(WCHAR)); > > /* TODO: Save more settings here (List vs. Detailed View, etc.) */ > RegCloseKey( hKey ); > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111

1 0

Re: comctl resource diff
by Maarten Lankhorst 20 Aug '07

20 Aug '07

Dj Apal [GR] schreef: > Hope this is the one you want. PLease commit it! > > TIA! > ------------------------------------------------------------------------ > > --- ./dlls/comctl32/rsrc.rc 2007-08-20 19:52:26.000000000 +0300 > +++ ./dlls/comctl32/rsrc1.rc 2007-08-20 19:50:03.000000000 +0300 > @@ -1196,6 +1196,7 @@ IDI_TT_ERROR_SM ICON LOADONCALL DISCARDA > #include "comctl_Cn.rc" > #include "comctl_Cs.rc" > #include "comctl_De.rc" > +#include "comctl_El.rc" > #include "comctl_En.rc" > #include "comctl_Eo.rc" > #include "comctl_Es.rc" > I'm missing a comctl_El.rc here?

1 0

Fixing wrong prototypes in a header
by Juan Lang 20 Aug '07

20 Aug '07

Some of the function prototypes in wintrust.h have the wrong calling convention. The trouble is, PSDK gets them wrong too. So calling the functions, as declared in the PSDK header, results in a crash in Windows. Casting them to function pointers with the correct calling convention succeeds. Should I leave the prototypes incorrect in wintrust.h to match the PSDK, or should I fix them to make them more convenient for me to use? Thanks, --Juan

2 2

Re: winmm: Change default driver order to be alsa,coreaudio,oss - try2
by Vitaliy Margolen 20 Aug '07

20 Aug '07

Maarten Lankhorst wrote: > Forgot to remove the strlen check. > Isn't this a bit premature? ALSA still does not support proper sound capture, working mixer, and not stable enough on some configurations. Vitaliy

2 8

Re: setupapi: if needed create directories for fake dlls
by Alexandre Julliard 20 Aug '07

20 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -302,9 +302,28 @@ BOOL create_fake_dll( const WCHAR *name, > else > { > h = CreateFileW( name, GENERIC_WRITE, 0, NULL, CREATE_NEW, 0, NULL ); > + > + if (h == INVALID_HANDLE_VALUE && GetLastError() == ERROR_PATH_NOT_FOUND) > + { > + WCHAR *pathel; > + > + /* create the directory/directories */ > + pathel = strchrW(name, '\\'); > + while (pathel != NULL) > + { > + *pathel = 0; You shouldn't write to the name, it's a const pointer, even if strchrW hides the warning. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] handle builtin regedit.exe.so
by Alexandre Julliard 20 Aug '07

20 Aug '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > On my system it tries to load /usr/lib/wine/regedit.exe.so > (via symlink) and this fails. We stopped using symlinks a long time ago, it sounds like your .wine dir is out of date. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comdlg32: printdlg: Fix number display in PrintDlgW()
by Alexandre Julliard 20 Aug '07

20 Aug '07

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > vsprintfW and friends do not support float numbers, so we have to format an > initial string with printf() and then print it to a wide string with > vsprintfW()'s %hs format. For a simply conversion to Unicode MultiByteToWideChar is a better choice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Dyne:bolic binary module
by Robert Shoemaker 20 Aug '07

20 Aug '07

I was wondering what the steps would be to put my binary build for the i686 Dyne:bolic distro on the releases page, it was no small task getting it to compile.

2 1

Direct3D 10 design considerations
by Stefan Dösinger 20 Aug '07

20 Aug '07

Hi, In the past days there was a bit of discussion about the implementation design of our future d3d10 implementation. The major question was wether we should make a clean start over with opengl 3.0, or extend wined3d for d3d10. A few facts: *) D3D10 is a clean restart without any backwards compatiblity, so is gl3. The fixed function pipeline was removed in both. *) The D3D10 interface is a present. Many of the nasty things in d3d9 have gone. SRGB textures are a pixel format property now. Sampler states are a texture property, not a device setting. Offscreen-rendering is more fbo like. *) WineD3D contains a huge set of functionality of d3d10 already. D3D10 is an evolutionary step, not a revolution. I estimate that 80% of the functionality that is of our interest already existed in d3d9. Code reuse, especially of the shader code and texture management, is desireable. *) GL3 isn't out yet. When will we have a gl3 implementation on all platforms and drivers? *) If we split, we do not have to take care for old opengl implementations and missing extensions. For d3d10 we could just require gl3, period. Of course that will only work satisfiably for the user if there are gl3 implementations everywhere. So we have two ways: 1) Do the same Microsoft did, and do a fresh start. Some code, like the shader code, could be copied over and forked. This is propably the fastest way, but it leaves us with 2 different d3d implementation. The d3d10 implementation on the other hand would be free of old junk. It would make it hard to run d3d10 on gl2+extensions, and even more harder to implement d3d9- on gl3. 2) Extend wined3d. We could use the inheritance scheme like in old ddraw, where the non-rendering functionality was implemented in a base object, and the renderer specific things(DGA / User / 3D) was implemented in objects derived from the base objects. This was a nice thing, but it made the code next to unreadable IMHO because of a huge number of objects and unintuitive interactions(DGA code calling User stuff, common code calling callbacks that are set in 5 places in the code, 5 different surface types). WineD3D already has the attachment points for such an abstraction. We have COM vtables and state management callbacks. Implementing d3d10 properly in wined3d is most likely more work than a restart is, but it would allow us to reuse some code. What we would have to do is this: *) Make sampler states work like in opengl. D3D7-9 takes care for updating the per texture states based on the device states. This will require some code to be moved from wined3d to d3d7-9 and duplicated in the 3 libs, most notable sampler state tracking in stateblocks. *) Move the srgb flag -> format matching from wined3d to d3d9. Before this can be done, wined3d has to be changed from D3DFORMAT to DXGI_FORMAT style. *) Clearly separate gl-specific code from non-gl-specific code in surface, texture, cubetexture, volumetexture, indexbuffer and vertexbuffer. Then split them in a base object and a derived gl2 object. Add a gl3 object implementing the gl-specific stuff in gl3. Make sure there is no gl specific buffer/texture stuff in the device(like CreateVBO & *) Add a 2nd state table and callback functions for gl3. GL3 will have different state linkings. Most of the states can stay unimplemented unless we want to run d3d9 with gl3. D3D10 is much simpler here because the fixed function pipeline was removed. *) Do something about the context manager. Multithreading has changed in d3d10, and it may change in gl3. Offscreen rendering in d3d10 can require fbos(no point in d3d10 offscreen rendering without them), this has much less hassles than the back buffer or pbuffer orm. Context management will most likely be much simpler in d3d10+gl3. Andras tells me that he has the d3d10 stubs(no rendering yet) done now, and he is writing some tests currently, then he will send stubs and tests in. Which way do you think should we go?

5 9

Re: dsound: Handle failing of IDsDriver_CreateSoundBuffer better
by Vitaliy Margolen 20 Aug '07

20 Aug '07

Maarten Lankhorst wrote: > There, now hush. :p > > Does 'Hardware Acceleration to Emulation' silently, without requiring of > the user to do something. > > > - ERR("Could not map sound device for direct access (%s)\n", strerror(errno)); > - ERR("Please run winecfg, open \"Audio\" page and set\n" > - "\"Hardware Acceleration\" to \"Emulation\".\n"); > + WARN("Could not map sound device for direct access (%s)\n", strerror(errno)); > return DSERR_GENERIC; And this really fixes the bug, doesn't just hide the error message? If it fixed, then there should be no messages at all. I really do not want to have people opening bugs because something crashes/sound doesn't work, etc. Vitaliy

2 1

Re: Greek resource file for comctl final
by Paul Vriens 19 Aug '07

19 Aug '07

Dj Apal [GR] wrote: > OK changed the copyright and added the diff file for the rsrc.rc file so as > to be included. > > Thnx for noticing that! > > I think that we are OK now. Sorry for all this mess but it was my first time > posting a patch! > > > > ------------------------------------------------------------------------ > > Your 'greek_comctl' patch is in 'diff -up' format. The 'rsrc.diff' patch should also be in that format (and done from the root of your Wine source directory). Cheers, Paul.

1 0

choppy anim
by Skrzynka 18 Aug '07

18 Aug '07

Hi, I'm trying to get some game (Settlers 3) to work on Wine (updated sources recently from git). If possible, I'd like to ask for some clues for a start: 1) the issue is choppy animation - the frame rate is abt 1/sec while the cpu load is low. However there are random periods when there seem to be about few frames per second (and cpu is laoded 100%). I tried measuring the time between call and return of DLL functions in relay.c. The only thing that looked suspiciously was WaitForSingle|MultipleObjects having times like 200-500ms. I also tried adding some delay to WaitForVerticalBlank in ddraw.c but also to no effect. Where should I start looking for the problem - some events or callbacks code? which? 2) when I run it from within winedbg i get lots of exceptions (no matter if app was started from winedbg or it was attached later) and no matter what combination of pass/continue I do, the app crashed with some msg box about exception or structured exception. Any pointers to docs on this? Any suggestions will help greatly. Thanks & regards Piotr -- ----- AlphaNet - najtaniej w sieci! -------- Odnowienia domen w rewelacyjnych cenach! .pl - 65 zl, .com.pl - 50 zl, reg - 20 zl http://www.domeny.alpha.pl --------------------------------------------

1 0

Re: #winehq admin abuse
by Abel Chiaro 18 Aug '07

18 Aug '07

Tom Wickline <twickline(a)gmail.com> wrote: > I gladly take the side of vitamin on this issue. I believe he is a > valuable member of the FOSS community, he has contributed many patches > to this and other OSS projects. And in HIS free time he volunteers on > the #winehq IRC channel to help people who want to accept his help... > He tried to help YOU and YOU refused to try what he ask YOU to do!! > YOU kept asking the same stupid *shit* over and over and over until > you got on his last nerve. He cant help someone who doesn't want to > help them self. > > Also, it doesn't look to me like he cussed anyone out! but I guess I > just cussed YOU as I used the poo word in this reply. :D I beg your pardon if I got this wrong, but I seems to me that Jonathan is *Pie-rate* rather than carretto. While carretto did ask the same thing over and over until vitamin gave him the download link, Pie-rate only asked once (timestamp: 09:43:50 PM), to which vitamin replied with his "oh well". I don't want to take any sides here — especially because I refrain from going to support channels exactly to avoid such situations —, but I have to say that vitamin's behavior in that discussion is definitely less than polite. However, I do think that Jonathan made the issue a bit bigger than it actually is. Ah, yes, regarding cussing around, I recall reading vitamin saying "F***" to Pie-rate twice, all the while not cussing *carretto* out. Anyway, being civil does no harm. My 2¢. - Pedro.

5 5

Re: Greek resource file for comctl final
by Maarten Lankhorst 18 Aug '07

18 Aug '07

Dj Apal [GR] schreef: > > OK changed the copyright and added the diff file for the rsrc.rc file > so as to be included. > > Thnx for noticing that! > > I think that we are OK now. Sorry for all this mess but it was my > first time posting a patch! Just curious, are files supposed to have dos line terminators? It seems to me like your file has it. Cheers, Maarten

1 0

re: [patch] Garbage code in text string display
by Dan Kegel 18 Aug '07

18 Aug '07

Xin Guan wrote: > This patch solves the problem that many MBCS programs display garbage code > for text strings. Because most windows programmers do not handle charsets > properly, we have to force DEFAULT_CHARSET in here. Can you give a simple example of such a program (preferably downloadable)? Can you add a conformance test showing that your patch is correct? - Dan

1 0

Re: Greek resource patch for comctl [third attempt, last I hope!!]
by Paul Vriens 18 Aug '07

18 Aug '07

Dj Apal [GR] wrote: > Hope this is what u want us to send! ;) used --> diff -up /dev/null ... etc etc > > > > ------------------------------------------------------------------------ > > Hi, Just a few remarks. The copyright says 'Eric Kohl' is that correct? You also need to add this resource file to 'rsrc.rc' in that same directory otherwise it will never be picked up. Cheers, Paul.

1 0

Re: bugs 9062,9325
by Stefan Dösinger 17 Aug '07

17 Aug '07

Am Freitag, 17. August 2007 15:39 schrieb Martin Vanek: > I have posted some minor bugs in combobox a week ago (ID=9062, with a > source text example and pictures documenting what's wrong). I am not an expert on user32 stuff, but generally you should send one patch per mail. If you have 2 patches, just send 2 mails. If you have written a test application, you may want to include it in dlls/user32/tests/ to proove the correctness of your patches and prevent the issue from coming back.

1 0

Re: [PATCH 3/6] winealsa: Implement IDsCaptureDriverImpl_Open
by Tomas Carnecky 17 Aug '07

17 Aug '07

Maarten Lankhorst wrote: > Sanity check to see if device can be opened or not Is alloca() not allowed in wine? (asking because you allocate hw_params on the stack, but it's freed if the function exits, so it's only used inside this one function). tom

2 2

Re: check_sharing disregards requested access
by Alexandre Julliard 17 Aug '07

17 Aug '07

"James Keane" <james.keane(a)gmail.com> writes: > check_access will now fail because the second caller is not honoring > FILE_SHARE_WRITE. but that shouldn't be neccesary as they are not > planning on writing anyways. The second caller won't, but the first one will, so you need FILE_SHARE_WRITE access. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: A script for automatic regression testing
by Dan Kegel 17 Aug '07

17 Aug '07

Martin wrote: > Regarding your script interface, I think it should accept these parameters: > * GIT_ID_1 - bisection start > * GIT_ID_2 - bisection end Sure, and/or dates and/or releases. * PNGs - list of PNG files which describe "bug hit" cases; No. The script should not invoke autohotkey, either. IMHO, it should instead factor out any knowledge about how to test for the bug into a user-supplied shell script. The script would be run once Wine is built, would check for the specific bug being searched for, and its exit status would be zero for success (no bug) and nonzero for failure (the bug was found). So using Mikolaj's script would require you to write a tiny shell script that invoked autohotkey on a script, or maybe just ran an installer and checked for the existance of a file, or something to do with PNG's, whatever you want. http://delta.tigris.org works this way; it calls the shell script "the oracle". - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Legal issues for contribution code into Wine
by Dmitry Morovkov 17 Aug '07

17 Aug '07

Hello, I'm a (mostly windows, but with some linux skills) programmer from russia who is interested in helping developing Wine, but due to all the mess I read about the legal issues I want to ask first. What is Wine's position regarding people who had seen the windows source code? I tried to search for this topic, and, found this: http://www.gnu.org/prep/standards/html_node/Reading-Non_002dFree-Code.html After reading this, it looks like it's ok if someone have seen the windows source code, and provided he is not going to directly copy unmodified source code (what a stupid idea!), nor refer to it, he would be considered as a good/trusted person? Please clarify this to me. Regards, Dmitry Morovkov.

3 2

Re: Issue(s) when running winetest on Windows
by Kirill K. Smirnov 17 Aug '07

17 Aug '07

>file: 2 tests executed (0 marked as todo, 0 failures), 0 skipped. >file: 373 tests executed (0 marked as todo, 0 failures), 0 skipped. These lines are displayed via printf (include/wine/test.h: 391). > msvcrt:file done (0) And this via xprintf (programs/winetest/main.c: 420), which is wrapper over write syscall. If you need these line be output in appropriate way, try to add fflush(stdout) in proper place (into run_test function in include/wine/test.h, I suppose). -- Kirill

4 6

About WritePrivateProfileString and file operations
by Zhongli Xu 16 Aug '07

16 Aug '07

Hi all, I run some tests about mixed using WritePrivateProfileString and stand file operations Codes look like this: GetPrivateProfileString(keyname, value); fopen(); fprintf("# comments"); fclose(); WritePrivateProfileString(keyname, newvalue); What I found in the file is that either WritePrivateProfileString operation succeeded(newvalue has been written) or fprintf succeeded("#comments" shows up in the file). On windows hosts, there is no such problem. Any suggestion or idea is welcomed. Thanks. Milo

3 2

RFC: root cert tool
by Juan Lang 16 Aug '07

16 Aug '07

Since there wasn't a clear consensus about how to get CA certificates into the registry, I decided to do what Mono does: punt. So I've written a tool that can load certificates from a file or from a URL and stick them in the registry. By default it assumes you want to download them from Mozilla's CVS front-end, and does so. A patch that adds it is attached. Comments? Thanks, --Juan

6 10

Re: secur32: add stub for LsaLookupAuthenticationPackage
by Kai Blin 16 Aug '07

16 Aug '07

On Thursday 16 August 2007 21:52:01 Louis. Lenders wrote: > Hi, this fixes a crash in TrueImage installer (bug > http://bugs.winehq.org/show_bug.cgi?id=3572) Personally I'd prefer if the LSA functions could go into a seperate source file. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

#winehq admin abuse
by Jonathan Challinger 16 Aug '07

16 Aug '07

Below is a log of #winehq, from 9:44 to 10:09 on Wednesday August 15th: (09:43:50 PM) Pie-rate: my brother's girlfriend's WoW install is crashing (locking up, stops responding) randomly. she will install windows tomorrow if it doesn't get fixed. i don't like windows and i don't want to deal with it. the message it crashes with is: (09:43:50 PM) Pie-rate: err:ntdll:RtlpWaitForCriticalSection section 0x509da8c "?" wait timed out in thread 0047, blocked by 003e, retrying (60 sec) (09:43:50 PM) Pie-rate: this is with an install copied over from my computer, which i KNOW works flawlessly, and wine 0.9.41 (09:43:54 PM) carretto: vitamin: what? (09:44:10 PM) carretto: vitamin: _period? (09:44:15 PM) vitamin: <vitamin> carretto, you have to install the game on Wine (09:44:34 PM) vitamin: Pie-rate, oh well (09:44:43 PM) Pie-rate: vitamin: "oh well?" (09:44:46 PM) Pie-rate: vitamin: no magic fix? (09:44:55 PM) carretto: vitamin: wine <game install>? (09:45:11 PM) vitamin: carretto, something like that (09:45:33 PM) otaku [n=otaku(a)c-24-15-187-230.hsd1.il.comcast.net] entered the room. (09:46:53 PM) carretto: vitamin: wine: Call from 0x40136e to unimplemented function MFC42.DLL.6929, aborting (09:47:10 PM) vitamin: carretto, get the newer version of that dll (09:49:56 PM) carretto: vitamin: i donwload MFC42.dll on dll.files and past to wine system folder (09:50:04 PM) vitamin: carretto, get the newer version of that dll (09:50:14 PM) carretto: here i get the newer version? (09:50:21 PM) vitamin: from windows (09:50:50 PM) carretto: vitamin: i download version v. 4.21.71 (09:51:32 PM) shingo2 [n=shingo(a)p5487EFF1.dip.t-dialin.net] entered the room. (09:52:27 PM) carretto: vitamin: where i get the new version? (09:54:48 PM) prgrmr [n=prgrmr(a)bzq-88-154-138-152.red.bezeqint.net] entered the room. (09:55:37 PM) _3 [n=lol(a)89-178-108-192.broadband.corbina.ru] entered the room. (09:57:20 PM) carretto: vitamin: can help me? (09:57:38 PM) vitamin: carretto, I already answered all your questions (09:57:50 PM) Pie-rate: vitamin: Read the topic. "End user/tech support channel for Wine." A derogatory-sounding "oh well" is nothing more than flamebait. Either say nothing, or help. That's what I try to do, and that's what's in the best interest of the project. I believe you are a channel admin, correct? Saying "oh well," without even trying to help is rude, but saying "oh well" without even trying to help, as a channel admin? That's like inviting people to an installfest, and then when they ask for help installing something saying "OH WELL" and spitting in their faces. (09:57:59 PM) vitamin: carretto, if you do not undestand answers, then RTFM, Google, etc (09:58:56 PM) carretto: vitamin: where i downlaod a newer version? (09:59:01 PM) vitamin: Pie-rate, Did I offered help? DId you came here looking for help? Or state that fact that you don't F** care and will switch to windows? (09:59:14 PM) vitamin: carretto, Last time: <vitamin> from windows (09:59:35 PM) Pie-rate: vitamin: i'm not the one switching to windows. (09:59:39 PM) vitamin: carretto, I do not f*** care where you download the file. You using _OLD_ version. you need _NEWER_ version of that file! (09:59:55 PM) Pie-rate: vitamin: bit testy, today? (09:59:59 PM) vitamin: carretto, here is the LATEST http://support.microsoft.com/dllhelp/default.aspx?l=55&fid=198511 (10:00:19 PM) vitamin: Pie-rate, STFU if you have nothing to say (10:00:46 PM) Pie-rate: vitamin: same to you. you are unnecessarily cussing out people in a help channel that you administrate. (10:01:33 PM) mode (+o vitamin ) by ChanServ (10:01:33 PM) mode (+b %*!*(a)cust-69-19-214-183.static.o1.com ) by vitamin (10:01:36 PM) mode (-o vitamin ) by ChanServ (10:05:08 PM) Triskelios: vitamin, you really should try to be civil (10:07:08 PM) wckdkl0wn: how would i run 2 copies of diablo 2 in wine? (2 copies in windows) (10:08:15 PM) vitamin: wckdkl0wn, use separate WINEPREFIX for both (10:08:25 PM) mardum [n=mardum(a)71-81-73-42.dhcp.stls.mo.charter.com] entered the room. (10:09:17 PM) vitamin: Triskelios, thanks for useless comment (10:09:35 PM) Triskelios: you're welcome ---------------------------end----------------------------- Vitamin is a disgrace to the OSS community. It is "RTFM and google it" elitists like him who scare people away from switching to open source applications. The fact that he was made an admin is inexcusable. Cussing out everyone asking for help is not behavior an admin should exhibit. I reported this incident in #winehackers, only to be told that there are no standards for wine admins. I suggest you get some standards, this is pathetic. I think my analogy is the best way to describe exactly WHY this is pathetic: "Saying "oh well," without even trying to help is rude, but saying "oh well" without even trying to help, as a channel admin? That's like inviting people to an installfest, and then when they ask for help installing something saying "OH WELL" and spitting in their faces." No, the people in the channel aren't being paid anything to help me or anyone else. They can choose not to help me. But then, what is the point of having the channel at all? This kind of abuse is completely against the spirit of open source and it is despicable that an admin is exhibiting this behavior. You may ask why I'm posting this to the development list. I believe it concerns everyone involved in the project when you have an admin cussing out anyone and everyone in the help channel, compromising its purpose. I suggest you develop some standards for your admins.

4 4

Re: dsound: Use wine dxguid rather then mingw dxguid
by Roderick Colenbrander 16 Aug '07

16 Aug '07

On Thursday 16 August 2007 12:06, Maarten Lankhorst wrote: > Makes it cross-compilable to produce a windows binary. I don't think this is the right way. It appears that native dxguid doesn't define some of the uuids needed for directdraw / directsound. You need to check where the missing guids are defined on windows. In case of ddraw IDirectDraw3 stuff is in ddrawex.h whereas we define it in ddraw.h. Something similar could be the case for directsound. Roderick

3 2

Fwd: #winehq admin abuse
by James Keane 16 Aug '07

16 Aug '07

> (09:44:15 PM) vitamin: <vitamin> carretto, you have to install the game > on Wine > (09:44:34 PM) vitamin: Pie-rate, oh well I think that vitamin provided a valid answer to your question that would have solved your problem. Why are you getting so worked up that he was a little rude? He is not our employee we can not reprimand him for his actions and neither can you. I think that he did try to help you given the information you provided, and maybe that is the problem with OSS, but if you don't like it go buy cedega. I am sure they have great technical support.

1 0

Poll: where do you have certs installed?
by Juan Lang 16 Aug '07

16 Aug '07

Could some of you check where you have, say, OpenSSL's CA certificates installed, and email me what distro you're running, and the path? E.g., I'm running Goobuntu, and I have them installed in /etc/ssl/certs/ca-certificates.crt. Thanks, --Juan

12 13

Re: kernel32:set username (try 4)
by Paul Vriens 16 Aug '07

16 Aug '07

Louis. Lenders wrote: > fix bug http://bugs.winehq.org/show_bug.cgi?id=3794 > > > --------------------------------- > Yahoo! Answers - Get better answers from someone who knows. Tryit now. > > > ------------------------------------------------------------------------ > > Aren't the curly brackets strangely placed? The rest of the file don't indent the curly brackets. Cheers, Paul.

1 0

Re: A script for automatic regression testing
by martin pilka 16 Aug '07

16 Aug '07

Mikolaj Zalewski wrote: > I now start to understand the structure of the tests. Do you know if > there is a known regression in current Wine that I could use to try to > do some scripting? If not I could use wine-0.9.43 as a reference with > it's Win16 regression that affects the pptviewer and excelviewer > installers. Unfortunately, I am not aware of any regression in current Wine. > PS: are you doing some testing of Photoshop? Yes, we are testing it on 4 distros each night, see i.e. http://www.cxtest.org/raw-data?id_result=635012 search for photoshop word Regarding your script interface, I think it should accept these parameters: * GIT_ID_1 - bisection start * GIT_ID_2 - bisection end * PNGs - list of PNG files which describe "bug hit" cases; usually just 1 screenshot with the meaning "if CxTest script ended with this screenshot, it means it hit the bug we are finding regression patch for" How does it sound to you? Martin

1 0

Re: #winehq admin abuse
by Patrick Leamon 16 Aug '07

16 Aug '07

I think the poster was 'Pie-rate' in the chat logs. Pie-rate - you over-reacted to 'oh well' and you're next message was flame bait. Vitamin - you took the bait. I wouldn't have expected that from an admin in a help channel. Take a break if you feel the need to shout/swear at people. Or tell them you can't help them. Tom - I'd feel cussed if I got told to 'STFU'. Which I probably will now as I've never patched wine so my opinion counts for nothing. cheers, pat. ____________________________________________________________________________________ Feel safe with award winning spam protection on Yahoo!7 Mail. http://mail.yahoo.com.au

1 0

re: Fixing wrong prototypes in a header
by Dan Kegel 16 Aug '07

16 Aug '07

I'd say leave them wrong in our headers, but report the problem to Microsoft, and fix our headers when they fix theirs... - Dan

1 0

A script for automatic regression testing
by Mikolaj Zalewski 15 Aug '07

15 Aug '07

I wrote a small script that automates regression testing. It requires an Autohotkey script that tests the program and creates a file C:\Test-failed.txt if the test failed. The bash script will then do the regression testing. It starts with copying the source tree and wineprefix so it should be possible to do some normal work during compilations. At the beginning of the script there are some variables that needs to be configured before running it. The wineprefix has to have Autohotkey installed and associated with *.ahk. The attached script's settings will find the regression for bug #9249. If anyone is interested in it I'd be interested in some feedback. Mikołaj Zalewski

4 4

Re: [PATCH] Fix Bug in DeadZone calculation
by Vitaliy Margolen 15 Aug '07

15 Aug '07

Artur Szymiec wrote: > Here is attached patch > for joystick_linuxinput.c where bug in dead zone > calculation make joystick unusable. After correction > tested in two games and works properly. > > Best Regards > Artur Szymiec > Thanks for spotting the problem. Unfortunately your patch has few problems too. I'll sending a better patch. Vitaliy.

4 5

[wininet/tests] Replace import of ws2_32 by wsock32 to please win95
by Paul Vriens 15 Aug '07

15 Aug '07

Hi, Currently we import ws2_32 for our wininet tests. ws2_32 is however not available on win95 and thus presents users of winetest with a pop-up. A crash of the tests I could live with but a pop-up gets in the way of automatic testing (if ever implemented again). I could do LoadLibrary/GetProcAddress to overcome that but a much easier solution seems to be to import wsock32 instead of ws2_32. Comments? Cheers, Paul.

1 0

Problems with focus losing on virtual desktops
by Patrick Leamon 15 Aug '07

15 Aug '07

There seems to be a bug for this now: http://bugs.winehq.org/show_bug.cgi?id=9320 ____________________________________________________________________________________ Sick of deleting your inbox? Yahoo!7 Mail has free unlimited storage. http://au.docs.yahoo.com/mail/unlimitedstorage.html

1 0

AMD64 package broken on Ubuntu Gutsy
by Scott Ritchie 15 Aug '07

15 Aug '07

The Wine package in Ubuntu Gutsy is currently failing to build on the AMD 64 arch, and I'm not sure why. I don't have a gutsy 64 system to play around with at the moment, but you can see the package error log here: http://launchpadlibrarian.net/8598218/buildlog_ubuntu-gutsy-amd64.wine_0.9.… I suspect one of the 32 bit libraries that we have to link by hand got renamed or upgraded, but I can't figure out which one from the log there. Thanks, Scott Ritchie

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel