- wine-devel - winehq.org

WINEDEBUG output issues
by Paul Vriens 15 Aug '07

15 Aug '07

Hi, I was trying to read a '+all,+relay,-syslevel,-gdi,-font' trace but several lines show something like: 000d:Cget_window_property000d:Call0x000d:, atom=000d:Call usePropertySheetInfo000d000000d:Call user32.CharNextA(0 {000d:Call user32.CharNextA(0040a04d "les\\Nmap") ret=0040551c The above is output from the same thread. I also have: 0009:trace:heap:RtlAllocateHeap (0x110000,00000002,0000014000d:Call user32.CharNe0009:trace:dc:GetDCState (0x474): retu000d:Ret user32.CharNextA() retval=004093c6 ret=0040551c Which mixes threads. Debug traces can already be hard to read but this is even more confusing. Any idea what the cause is (or better, the solution)? Cheers, Paul.

1 0

Re: [2/5] WineD3D: Optimize float constants in stateblocks
by Alexandre Julliard 14 Aug '07

14 Aug '07

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From f49fd192ed2747663bdb0445dff9d602519fbc95 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 3 Aug 2007 20:26:29 +0200 > Subject: [PATCH] WineD3D: Optimize float constants in stateblocks > > --- > dlls/wined3d/device.c | 24 +++++++++++++- > dlls/wined3d/stateblock.c | 68 +++++++++++++++++++++------------------- > dlls/wined3d/wined3d_private.h | 4 ++ > 3 files changed, 62 insertions(+), 34 deletions(-) This one is broken: ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so device.c && touch device.ok wine: Unhandled page fault on write access to 0x000000f6 at address 0x61aad11c (thread 0039), starting debugger... WineDbg starting on pid 003a Unhandled exception: page fault on write access to 0x000000f6 in 32-bit code (0x61aad11c). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:61aad11c ESP:0033fa90 EBP:0033fac8 EFLAGS:00010202( - 00 - -RI1) EAX:000000f6 EBX:61b3ae04 ECX:00000001 EDX:00000000 ESI:001bd4d0 EDI:001c6f78 Stack dump: 0x0033fa90: 001bd4d0 001bd4e4 00000001 00000000 0x0033faa0: 00000000 00000000 00000000 602d53b1 0x0033fab0: 00000000 00000000 0000002b 617da640 0x0033fac0: 617dad24 001bd4b8 0033faf8 617caebf 0x0033fad0: 00123d30 00000001 001bd4c0 001bd4b8 0x0033fae0: 606e97df 0000005c 617cae3b 60715808 Backtrace: =>1 0x61aad11c IWineD3DDeviceImpl_CreateStateBlock+0x3dc(iface=0x123d30, Type=0x1, ppStateBlock=0x1bd4c0, parent=0x1bd4b8) [/home/julliard/wine/wine/dlls/wined3d/device.c:478] in wined3d (0x0033fac8) 2 0x617caebf IDirect3DDevice8Impl_CreateStateBlock+0x8f(iface=0x121780, Type=0x1, pToken=0x33fe08) [/home/julliard/wine/wine/dlls/d3d8/device.c:1177] in d3d8 (0x0033faf8) 3 0x606e1260 func_device+0x2190() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:528] in d3d8_test (0x0033fe58) 4 0x606e8818 run_test+0x128(name=0x1103c5) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:389] in d3d8_test (0x0033fea8) 5 0x606e8ead main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:437] in d3d8_test (0x0033fed8) 6 0x606e958b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0033ff08) 7 0x6041352e start_process+0xee(arg=0x0) [/home/julliard/wine/wine/dlls/kernel32/process.c:820] in kernel32 (0x0033ffe8) 8 0x60027997 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x61aad11c IWineD3DDeviceImpl_CreateStateBlock+0x3dc [/home/julliard/wine/wine/dlls/wined3d/device.c:478] in wined3d: movl %edx,0x0(%eax,%edx,4) 478 object->contained_vs_consts_f[j] = j; -- Alexandre Julliard julliard(a)winehq.org

2 1

Partial phase out of *winehq.com addresses
by Duane Clark 14 Aug '07

14 Aug '07

As mentioned about a month ago, we were planning to phase out the winehq.com email addresses, and use winehq.org exclusively. It looks like the few holdouts have converted over for awhile now, so I added a filter to the mailman program to silently drop anything mailed to winehq.com. If Jeremy wants to set the MTA (or whatever) to reject those addresses, that might be better. Then anyone accidently mailing to the wrong address would (presumably) get a delivery error message. And it would take a small portion of the load off mailman.

2 1

Re: Font problem + patch solution
by Abel Chiaro 14 Aug '07

14 Aug '07

Alexandre Julliard wrote: > penna(a)bb.com.br writes: > > > There is a patch proposed at the bug #7571 (http://bugs.winehq.org/show_bug.cgi?id=7571). > > It works very well and I did not experiment any regression. Maybe > > it is not the ideal patch and if it is not, maybe we can provide a fix for > > that. However, at least it fixes the font problem and did not introduce > > any undesirable efects. > > Is that possible to apply that patch at the main tree? Comments > > are also welcome! > > You should provide test cases that show that your patch is correct. I used Dmitry's tests [1] for this patch. [1] http://www.winehq.org/pipermail/wine-patches/2007-March/036706.html Shouldn't that be enough, I'll look into it again. - Pedro. -- "Caritas omnia vincit."

2 3

Re: WGL: GDI support is not advertised with double buffering
by Roderick Colenbrander 14 Aug '07

14 Aug '07

Wouldn't it be cleaner to cache the double buffering property in the WineGLPIxelFormat and set the gdi cap in there? That would skip another unneeded function. Roderick

1 1

Re: user32: LB_SETITEMDATA should return 1 on success, not 0
by Alexandre Julliard 14 Aug '07

14 Aug '07

Peter Verthez <peter.verthez(a)advalvas.be> writes: > diff --git a/include/winuser.h b/include/winuser.h > index 4297a8d..97363e0 100644 > --- a/include/winuser.h > +++ b/include/winuser.h > @@ -2428,6 +2428,7 @@ typedef struct tagSCROLLBARINFO > > /* Listbox message return values */ > #define LB_OKAY 0 > +#define LB_SETITEMDATA_OKAY 1 /* undoc. OK return for LB_SETITEMDATA */ Please don't invent constants that don't exist on Windows. In this case TRUE would work just as well. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [d3d8/tests] Make tests run again on win95
by James Hawkins 14 Aug '07

14 Aug '07

On 8/14/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Again only to avoid a pop-up. Didn't fix/test the actual tests. > > Changelog > Make tests run again on win95 > Please change the subject of your emails to match the dll that you're patching. As it stands, it looks like you're patching advapi32 5 times, and we have to dig into the patch to see what dll you're actually changing. -- James Hawkins

2 2

Font problem + patch solution
by penna＠bb.com.br 14 Aug '07

14 Aug '07

Hi all, Since wine 0.9.31 there is a font problem (at least latin charset). There is a patch proposed at the bug #7571 (http://bugs.winehq.org/show_bug.cgi?id=7571). It works very well and I did not experiment any regression. Maybe it is not the ideal patch and if it is not, maybe we can provide a fix for that. However, at least it fixes the font problem and did not introduce any undesirable efects. Is that possible to apply that patch at the main tree? Comments are also welcome! Thank you in advance.

2 1

Problems with focus losing on virtual desktops
by Christian Authmann 14 Aug '07

14 Aug '07

Hi, after installing 0.9.42 I noticed some odd behavior when playing Diablo 2. I did a git bisect and nailed it down to this patch: http://source.winehq.org/git/wine.git/?a=commit;h=d836a5062141dd42293ed044d… winex11drv: Correctly react to focus loss away from Wine. I noticed the following changes: a) Using diablo 2's windowed mode: d2 will realize when it's losing focus again (as it did somewhere around 0.9.2x). As far as I can tell, this works reliable. (That's not a good thing for diablo 2, since d2 will minimize on losing focus and cannot be brought back to life afterwards. But that's a different bug.) >From now on, please read "Diablo 2 minimizes" as "Diablo 2 thinks it lost focus". b) Using d2 in fullscreen mode inside wine's virtual desktop: d2 will sometimes think it lost focus, even if it didn't. Moving the wine window around with hotkey+drag: d2 minimizes. Moving the window by the title bar: nothing happens. (using kde/kwin btw) Sometimes just clicking inside the window while playing will cause d2 to minimize, although I haven't found a reproducible pattern (i.e. do I have to press certain keys, do I have to double-click, etc). Activating a different window outside the virtual desktop? d2 stays open. Or opening another application via hotkey, or pulling down yakuake via hotkey. It stays open. But, if I reactivate the virtual desktop window afterwards: d2 minimizes. Ouch. c) virtual desktop again: when holding ALT to show the dropped items, then left clicking somewhere, d2 thinks that ALT has been released. This makes it quite hard to pick up items. This problem does not occur when using regular windowed mode or when changing the hotkey to something different - as far as I can tell only ALT in virtual desktop mode is affected. Note that I don't have any hotkeys on Alt (or Alt+click), I bound window dragging to the otherwised unused windows key. While the patch does as intended on regular windows, it's effects on virtual desktop windows can only be described as weird. I don't know how virtual desktops are supposed to work. At least for d2, it'd be useful if one application inside the virtual desktop always keeps focused (or rather, is told it'd still be focused). IMHO that's the purpose of virtual desktops: banning the apps inside a container where they shouldn't be influenced by outside stuff, including activating a different window. Not losing focus is also more sensible when virtual desktops are used as a way to ban fullscreen-apps into windows: most fullscreen applications don't expect to lose focus and behave weird. However, even if you think of virtual desktops simply as a means to group windows, it's currently broken: losing focus on reactivation is a little late. I have compiled the latest git version without this patch, and virtual desktop mode works fine again, so it's really down to this single line of code. I'm not far enough into the code to know any possible solution, but for immediate results a simple if (inside a virtual desktop) do old behaviour else do new behaviour should do the trick until a better solution is found. greetings, Christian

3 5

Re: kernel: add execution permission to DOS memory area
by Alexandre Julliard 14 Aug '07

14 Aug '07

Mikolaj Zalewski <mikolaj(a)zalewski.pl> writes: > Execution permission is needed because we store some (mostly > DPMI-related) code in UMB (in winedos/himem.c) that is executed for > each Win16 app. The user may put even more code there. Ntvdm.exe also > makes the DOS memory executable (except for some parts of the UMB) winedos is supposed to make that memory executable when needed. The executable protection was removed from kernel32 as it causes failures on platforms that don't allow write+exec. -- Alexandre Julliard julliard(a)winehq.org

1 0

Problem with dlls/winex11.drv/opengl.c, revision 1.104
by Chris Rankin 14 Aug '07

14 Aug '07

Hi, With the update of dlls/winex11.drv/opengl.c from revision 1.103 to 1.104, World of Warcraft no longer starts in OpenGL mode. WoW complains that my graphics card does not have "dual-TMU support". (I have a Radeon R200 with Mesa 7.1) Cheers, Chris ____________________________________________________ Which email service gives you unlimited storage? http://uk.mail.yahoo.com

2 1

[oleaut32/tests] Error when running tests on Wine, anyone?
by Paul Vriens 14 Aug '07

14 Aug '07

Hi, Can somebody confirm if all oleaut32 tests run correctly on Wine. I'm trying to change LoadLibrary to GetModuleHandle and though it was my failure, but current GIT fails for me: ../../../tools/runtest -v -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so vartest.c && touch vartest.ok fixme:variant:VarMod Could not convert left type 4096 to 20? rc == 0x80020008 fixme:variant:VarMod Could not convert left type 8192 to 20? rc == 0x80020008 fixme:variant:VarMod Could not convert left type 16384 to 20? rc == 0x80020008 vartest.c:3128: Test failed: got VT_DATE(-1.5) expected VT_DATE(-1.4) vartest.c:3129: Test failed: got VT_R8(-1.5) expected VT_R8(-1.4) vartest: 1031879 tests executed (0 marked as todo, 2 failures), 0 skipped. make: *** [vartest.ok] Error 2 Cheers, Paul.

6 11

Our wiki software is ugly
by Scott Ritchie 14 Aug '07

14 Aug '07

Our wiki software needs a major update, especially as we start to expect users to actually read it. For instance, look at the FAQ page: Then, click on edit and see how it should look. From what I can tell, there are a few obvious errors: 1) The wiki software is completely ignoring line breaks. I could hit return 4 times and the HTML rendered would be on subsequent lines, without a break or paragraph tag between them. 2) For some completely strange reason, if you make a list item that includes a link then the entire list item will be in a smaller font. This makes for extremely weird and inconsistent lists when a link to another wiki page is included in some, but not all, of the items. 3) Header text is almost impossible to figure out right, and there is absolutely no standard of what we should do. Is there a reason we chose the software we did? Would it be too hard to migrate to something else, or at least fix the display bugs? Thanks, Scott Ritchie

3 4

Fonts (+liberation again...)
by Louis. Lenders 13 Aug '07

13 Aug '07

Hi , a few weeks ago posted something about if liberation fonts could be included in wine. There didn't seem to be one view of how to do that. Of course 'winetricks liberation' is great, but i'd like to see something that works out of the box on a fresh .wine. Attached is a patch, that generates Arial.ttf from liberation font (just like winetricks) but this is an attempt to get it included in wine's source. To summarize, i added a file arial.ttf2sfd that changes a liberation font into "arial.sfd", change appropriate family/font name, and then generate the arial.ttf. All is done by fonforge. Of course this patch lacks checking for presence of liberation, and has ugly hard-coded path for the liberation-font, but that could be worked on later on. Simple question: Could something like this be included in the source, otherwise i'm not gonna spend any time improving it. Any hints welcomed. Regards, louis --------------------------------- Yahoo! Answers - Get better answers from someone who knows. Tryit now. diff --git a/Make.rules.in b/Make.rules.in index a32b276..257598e 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -126,7 +126,7 @@ LINTS = $(C_SRCS:.c=.ln) # Implicit rules -.SUFFIXES: .mc .rc .mc.rc .res .res.o .spec .spec.o .idl .tlb .h .y .l .tab.c .tab.h .yy.c .ok .sfd .ttf .man.in .man _c.c _i.c _p.c _s.c +.SUFFIXES: .mc .rc .mc.rc .res .res.o .spec .spec.o .idl .tlb .h .y .l .tab.c .tab.h .yy.c .ok .sfd .ttf .ttf2sfd .man.in .man _c.c _i.c _p.c _s.c .c.o: $(CC) -c $(ALLCFLAGS) -o $@ $< @@ -179,6 +179,9 @@ LINTS = $(C_SRCS:.c=.ln) .c.ok: $(RUNTEST) $(RUNTESTFLAGS) $< && touch $@ +.ttf2sfd.sfd: + $(FONTFORGE) -script $(TOPSRCDIR)/fonts/$< $< $@ + .sfd.ttf: $(FONTFORGE) -script $(TOPSRCDIR)/fonts/genttf.ff $< $@ diff --git a/configure b/configure diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c diff --git a/dlls/shell32/shell32_En.rc b/dlls/shell32/shell32_En.rc diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h diff --git a/dlls/user32/sysparams.c b/dlls/user32/sysparams.c diff --git a/fonts/Makefile.in b/fonts/Makefile.in index 2a69d6a..35d1e71 100644 --- a/fonts/Makefile.in +++ b/fonts/Makefile.in @@ -47,11 +47,16 @@ BITMAP_FONTS = \ vgas1257.fon \ vgas874.fon +TTF2SFD = \ + arial.sfd + TRUETYPE_FONTS = \ - marlett.ttf + marlett.ttf \ + arial.ttf FONTS = \ $(BITMAP_FONTS) \ + $(TTF2SFD) \ $(TRUETYPE_FONTS) all: $(FONTS) diff --git a/fonts/arial.ttf2sfd b/fonts/arial.ttf2sfd new file mode 100644 index 0000000..2ce704e --- /dev/null +++ b/fonts/arial.ttf2sfd @@ -0,0 +1,3 @@ +Open("/usr/share/fonts/liberation/LiberationSans-Regular.ttf"); +SetFontNames("ArialMT", "Arial", "Arial"); +Generate($2); diff --git a/include/setupapi.h b/include/setupapi.h diff --git a/tools/wine.inf b/tools/wine.inf

3 2

Re: WineD3D: add opengl 1.2/1.3 constanst to wined3d_gl.h
by Roderick Colenbrander 13 Aug '07

13 Aug '07

Skip this patch for now as it barely reduces the patch size. The real patch adds much, much more constants and that has to be merged in one go (or it can be done earlier if you want to have it behind the ifdef). Tell me what you prefer :) Roderick On Monday 13 August 2007 20:06, Roderick Colenbrander wrote: > Hi, > > Add opengl 1.2 / 1.3 constants to wined3d_gl.h because gl.h on windows is > still 1.1. Further the defines are behind an ifdef for now because most > linux headers do define them and haven't placed them behind some version > check. > > Once all changes are done the ifdef will be removed. I add it now to > prevent large patches. > > Regards, > Roderick Colenbrander

1 0

[winetest] Show missing tests in single/group results
by Paul Vriens 13 Aug '07

13 Aug '07

Hi, (I've just remembered that there is a limit on the email size, so I'm doing it a bit differently now. The other email, including the screenshots, will probably come through as well) Before sending this to wine-patches I would like people to have a look first. This patch makes sure that missing tests are shown in the test results, both when there is only one system in a group (f.e. Win98) or multiple systems in a group. On 'http://www.xs4all.nl/~pvriens/200708031000.old.single/' you can see the current state of the test results. When a test is missing a '.' is shown (this is of course different from a missing test where we don't have results at all but that's shown as a '.' as well). On 'http://www.xs4all.nl/~pvriens/200708031000.old.group/' you can see the current state when a group of systems is involved. When tests are missing for a group, a '.' is shown with a link to the group overview. There is however no missing test output in the group overview (for example gdiplus and pdh) 'http://www.xs4all.nl/~pvriens/200708031000.new.single/' shows the new results page for single tests. Instead of a single '.' there is a failure shown (red box) and a skip border (as these tests have not run). There is still a '.' which could maybe better be a '?'. There is also a 'onMouseOver' hint when you go over the '.'. 'http://www.xs4all.nl/~pvriens/200708031000.new.group/' shows the new results when a group is involved. The main summary is still the same as in the old one, but the group results now also show the missing tests (see gdiplus and pdh again). Again there is a 'onMouseOver' hint in the group results. Remember that this is still without winetest producing output about missing dll's. Next patches will: - add a missing dll as one of the reasons for missing tests - add some better clue's on the main summary for multiple systems in a group (not a single '.' but maybe the same 'failed and skipped'). As said, one of the thoughts I had was to replace the '.' with a '?' in case of missing tests for an unknown reason but I'm not sure about that yet. Comments/remarks etc.. are welcome. I'd also like to hear about other idea's for this page to make it useful for everybody. Apart from the fact that we probably should have more exposure to the fact that we have such a page/tool. We saw an immediate rise (slowed down again) in test results as soon as winetest was mentioned on 'http://tweakers.net/meuktracker/15817/Wine-0.9.42.html' (in Dutch). There it was also mentioned that some machines crashed because of the tests etc.. (maybe a wine-winetest component on bugzilla could help with that which we could reference on the main test.winehq.org/data/*/index.html pages). Cheers, Paul.

4 5

Re: wined3d: Activate context before applying fbo state.
by H. Verbeet 13 Aug '07

13 Aug '07

On 13/08/07, Vitaliy Margolen <wine-patches(a)kievinfo.com> wrote: > Fixes bugs 9293 and 9269. > --- > dlls/wined3d/device.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > Looks ok to me, fwiw.

1 0

win16 tests
by Jennifer Lai 13 Aug '07

13 Aug '07

Hi, I've collected and fixed some win16 tests. Since they are not going to be included in the wine tree, I've placed them under http://www.cs.ucla.edu/~jlai/win16test/ In order to build these tests, Open Watcom was used. The tar ball also includes the scripts of installing Open Watcom, building the tests, and running them. Details are described in the README. More tests will be added in the future, and comments are greatly appreciated. Thank you, Jennifer Lai

2 1

Allow building of ddraw.dll / ddrawex.dll on MingW
by Roderick Colenbrander 13 Aug '07

13 Aug '07

Allow building of ddraw/ddrawex on mingw. By default the dxguid from mingw is used which doesn't work for us as it is outdated. Regards, Roderick Colenbrander

4 4

Re: WGL: proper stereo / double buffering support for ChoosePixelFormat
by Chris Robinson 12 Aug '07

12 Aug '07

On Sunday 12 August 2007 05:44:31 am Roderick Colenbrander wrote: > pglXGetFBConfigAttrib(gdi_display, fmt->fbconfig, > GLX_DOUBLEBUFFER, &value); > - if (value) dwFlags |= PFD_DOUBLEBUFFER; > - if (!(ppfd->dwFlags & PFD_DOUBLEBUFFER_DONTCARE) && > ((ppfd->dwFlags^dwFlags) & PFD_DOUBLEBUFFER)) > - { > - TRACE("dbl buffer mismatch for iPixelFormat=%d\n", i+1); > + if( (value & PFD_DOUBLEBUFFER) && (ppfd->dwFlags && > PFD_DOUBLEBUFFER) ) { This change doesn't look quite right. 'value' will be set to true or false, it won't have the PFD_DOUBLEBUFFER flag set coming from a GLX function. And checking the ppfd->dwFlags should use a single &, not a double &&. Also, even with those fixes, it'll only attempt to match when the doublebuffer flag is set on both the fbconfig and the wanted pixel format, not if it's unset on both, or if it's supposed to be ignored. As well, the check will preempt the other fields if a doublebuffer match was already found. Same with the stereo flag.

1 0

Re: schannel status and crypt32 blockage
by Juan Lang 12 Aug '07

12 Aug '07

Hi Yuval, > [Should I repost on-list?] Yeah, let's talk about this in the open. > I've created a test that connects to https://wiki.winehq.org, and > found the following: Excellent! Glad it's getting some attention. > - It fails in rsaenh due to OPAQUEKEYBLOB not supported in CPExportKey > and CPImportKey, with CALG_RC4 and CALG_SCHANNEL_MAC_KEY. I've > implemented some hack (can't pass through AJ), and it continues. Interesting. I haven't tried this case, but it doesn't look (from looking at rsaenh) like this should be too tough. Send the hack, and I'll try to take a look when I get a chance. > - I can't get a testcase for EncryptMessage/DecryptMessage that works > on Windows, so I can't tell how far have I got. I don't know what I do > wrong. Okay. You might ask again on-list with some code, there are a couple people here (e.g. Kai) that are more knowledgeable about secur32. > I've also tried googletalk. > - It fails immediately after CertGetCertificateChain reports it is a > stub. Right. I have a partially done implementation of that lying around somewhere that I can send you if you like. It may not work right away, I'm not positive CertGetIssuerCertificateFromStore is right just yet. I'm planning to work on that very soon, most likely next week, so if you can wait that long I should have something. > I'd like to note that native crypt32 is not an option (not even > temporary, such as schannel), as it tries to use keysvc. So basically > I'm blocked. Okay. > Are you planning on implementing Cert*CertificateChain soon? Yes :) > What about rsaenh, is it in the scope of your work? Not exactly. I'm just trying to get iTunes to start. But I'd probably take a look anyway ;) Cheers, --Juan ____________________________________________________________________________________ Pinpoint customers who are looking for what you sell. http://searchmarketing.yahoo.com/

1 0

wininet: Don't peek data in InternetQueryDataAvailable if there is no more to be expected.
by Misha Koshelev 12 Aug '07

12 Aug '07

I am going to send a more complete try2 patchset tomorrow (the patch as given is correct but there are some more problems with InternetQueryDataAvailable that need to be fixed, like the fact that it actually doesn't return ERROR_NO_MORE_FILES when all HTTP data has been retrieved). Misha

1 0

landfill.bugzilla.org?
by Dan Kegel 11 Aug '07

11 Aug '07

Why are all our new bugs cc'd to bugbot(a)landfill.bugzilla.org? I suspect that's a default that needs to be removed...

3 2

re: Our wiki software is ugly
by Dan Kegel 11 Aug '07

11 Aug '07

Scott wrote: > ... > 3) Header text is almost impossible to figure out right, and there is > absolutely no standard of what we should do. [The amazing diversity in wiki syntaxes in the world makes me want to puke. Why not just use HTML syntax directly? It's at least well-defined.] Yeah, it's frustrating and looks bad. But at least the server is well-run :-) - Dan

1 0

Re: WineD3D: Use the proper depth stencil format
by Chris Robinson 11 Aug '07

11 Aug '07

On Friday 10 August 2007 10:33:31 am Roderick Colenbrander wrote: > Hi, > > This patch lets WineD3D use the proper depth stencil format. The format is > retrieved from the WINED3DPRESENT_PARAMS. The proper format can improves > performance on platforms like Windows which offer more onscreen > pixelformats. > > Regards, > Roderick Colenbrander Isn't it normal to pass structs as a pointer, properly const-ified?

1 0

Thank you to Max Kanat -Alexander and Everything Solved
by Jeremy White 11 Aug '07

11 Aug '07

Say, I wanted to note that the Bugzilla upgrade is being done, by and large, due to the very professional and helpful efforts of Max Kanat of Everything Solved (www.everythingsolved.com). I don't know that I've ever seen Jeremy Newman *happy* about Bugzilla, it's rather freaky <grin>. So, thanks! Cheers, Jeremy p.s. Yes, there are still kinks and issues with bugzilla; folks are working furiously on #winehackers to iron out the worst of them right now.

2 1

win16 tests
by Jennifer Lai 10 Aug '07

10 Aug '07

Hi, I've collected and fixed some win16 tests. Since they are not going to be included in the wine tree, I've placed them under http://www.cs.ucla.edu/~jlai/win16test/ <http://www.cs.ucla.edu/%7Ejlai/win16test/> In order to build these tests, Open Watcom was used. The tar ball also includes the scripts of installing Open Watcom, building the tests, and running them. Details are described in the README. More tests will be added in the future, and comments are greatly appreciated. Thank you, Jennifer Lai

1 0

Bugzilla Downtime
by Jeremy Newman 10 Aug '07

10 Aug '07

Bugzilla will be going offline starting at 10:00 CST. We are performing upgrades to the site. The rest of WineHQ.org should be un-effected by this upgrade.

1 1

[MSI/tests] ConvertSidToStringSid not available on win98/NT4
by Paul Vriens 10 Aug '07

10 Aug '07

Hi, ConvertSidToStringSid (advapi32) is not available on win98/NT4 so the msi tests (all of them) do not run on those platforms currently. I could use skip but that basically would mean no MsiQueryProductState, MsiQueryFeatureState and MsiQueryComponentState tests. Another thing is to copy over the ConvertSidToStringSid implementation from advapi32 to the relevant tests. Any other ideas (or better yet, solutions)? Cheers, Paul.

4 5

Re: [2/2] winex11: Don't use context-specific info when initializing
by Roderick Colenbrander 10 Aug '07

10 Aug '07

I would like to keep this GL_RENDERER/GL_VENDOR stuff around although it might not be 100% correct in all cases (on some cards there's indeed a difference between direct and indirect rendering). To be correct also add similar code to the glx context creation code. Roderick On Friday 10 August 2007 11:29, Chris Robinson wrote: > Doesn't make much sense to use info from a temporary context when the > context the app eventually sets may be different (such is the case for > direct vs. indirect rendering on certain drivers, or multiple > screens/output devices).

1 0

[programs] add winerun for starting programs from wine.desktop
by Kirill K. Smirnov 10 Aug '07

10 Aug '07

>+/* >+ * Wordpad implementation >+ * >+ * Copyright 2007 by Damjan Jovanovic >+ * It is not wordpad, is it? >+ ok = CreateProcessW(exePath, NULL, NULL, NULL, FALSE, 0, NULL, currentDirectory, >+ &startupInfo, &processInfo); This code does not run console apps correctly (use CREATE_NEW_CONSOLE flag). -- Kirill

1 0

Re: [2/2] winex11: Don't use context-specific info when initializing
by Christoph Frick 10 Aug '07

10 Aug '07

On Fri, Aug 10, 2007 at 02:29:49AM -0700, Chris Robinson wrote: @@ -137,7 +132,7 @@ typedef struct wine_glpbuffer { } Wine_GLPBuffer; static Wine_GLContext *context_list; -static struct WineGLInfo WineGLInfo = { 0 }; +static struct WineGLInfo WineGLInfo; static int use_render_texture_emulation = 1; static int use_render_texture_ati = 0; static int swap_interval = 1; why is this changed? its a Good Thing to have global structs initialized so they fail earlier under abuse. -- cu

2 1

Re: [1/2] winex11: NV_texture_rectangle and NV_vertex_array_range do not have WGL extension names
by Roderick Colenbrander 10 Aug '07

10 Aug '07

Both are 'fake' WGL extensions. I agree that no string should be displayed in either case and that we don't need a check for NV_texture_rectangle. The loading of the NV vertex array range stuff depending on the presence of the GL extension of which it is part is fine. Yes, GL extensions are context dependend but relying on glXGetProcAddress is even more evil (as it doesn't have to return NULL). Upto now I haven't seen problems with this. On Friday 10 August 2007 11:15, Chris Robinson wrote: > This patch and the next are designed to remove the need for > context-specific information taken from a temporary context. For this one, > the aforementioned extensions don't have WGL extension names. Their > respective specs and a recent nvidia card/driver's WGL extension output > confirms this.

1 0

Re: winex11: added missing sync_current_drawable calls
by Kai Blin 09 Aug '07

09 Aug '07

On Thursday 09 August 2007 15:59:59 plams wrote: > Here's a patch to fix a regression since 0.9.28 (in response to bug > 9029). OpenGL scissoring had apparently been wrapped in commit > 715d0e84097cb2dc07369c4e1cec8cf8a41e9035 but it seems that it made it > possible to make a glDisable(GL_SCISSOR_TEST) call that would leave GL > in some pseudo-state where the scissor test was STILL active (and vice > versa for glEnable) until e.g. a wglMakeCurrent or wglViewport call > was made. This patch should fix that (and thus resolve bug 9029). You need to provide your real name for the change log, otherwise your patch can't be accepted. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

re: ANNOUNCE: Wine/Mono Regression Test Suite
by Dan Kegel 09 Aug '07

09 Aug '07

Matt wrote: > ...I've found that running the mono regression test suite has > given me a better idea of how to approach debugging mono/wine. > ... > http://mhjones.org/wine/wine-tests/wine-test-reader.tar.gz I downloaded this and had a look just now. The instructions still refer to the deprecated 1.1 branch of mono, and I hear to run on wine, one needs something newer than the latest released version of mono. So I tried building mono from the trunk. My dapper system was missing some things mono seems to need, so I expanded on the script in the readme a bit, and came up with #!/bin/sh set -xe MONOBUILDDIR=/data/dkegel/mono-cvs mcs --version || sudo apt-get install mono-devel libtool --version || sudo apt-get install libtool automake-1.9 --version || sudo apt-get install automake1.9 automake --version | grep 1.9 || sudo update-alternatives --set automake /usr/bin/automake-1.9 mkdir -p $MONOBUILDDIR cd $MONOBUILDDIR svn co svn://anonsvn.mono-project.com/source/trunk/mono cd mono ./autogen.sh --build i486-linux-gnu make This goes well for a while, but fails with /bin/sh: line 1: cd: ../../mcs: No such file or directory if test -w ../../mcs; then :; else chmod -R +w ../../mcs; fi chmod: cannot access `../../mcs': No such file or directory make[2]: *** [all-local] Error 1 make[2]: Leaving directory `/usr/local/google/bigdata/dkegel/mono-cvs/mono/runtime' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/local/google/bigdata/dkegel/mono-cvs/mono' make: *** [all] Error 2 Can you update your README to show how to build some flavor of mono-1.2 that runs under Wine? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: Wine Kernel Handle Support Module
by Michael Ost 09 Aug '07

09 Aug '07

>>> I know there is some discussion of what should be put in the kernel >>> module, so I am asking for advice on what to implement... ie. just >>> handles, everything wineserver does, etc. >> The first question is: >> Why do you want to do that and what specifically do >> you want to achieve? > > A small step towards less overhead in client <-> server calls? One _big_ vote for putting thread sync primitives --- events, semaphores, mutexes and critical sections --- in. We had to build a custom Wine to get acceptable realtime performance (thanks, Ulrich!). The client <-> server were causing high priority threads to block on low priority ones. I guess a test case would be something that shows how a high priority thread blocking on a sync primitive, while some low priority thread is doing some unrelated server heavy stuff, like lots of graphics updates. Cheers... mo

1 0

[SNMPAPI] How to fix the tests for win98 and NT4?
by Paul Vriens 09 Aug '07

09 Aug '07

Hi, There are several functions in the util.c test that are not available on win98 and NT4. That can be dealt with easily. Almost all tests with a NULL parameter crash on win98/NT4. I know that a few weeks back we talked about ignoring win98 if it would mean skipping a lot of tests, but now NT4 is involved as well. I could introduce a variable of course that's set when we are on NT4 or lower (because of the missing functions) and don't run the 'NULL' tests. Any ideas, comments? Cheers, Paul.

2 1

Re: exporting file associations for linux desktops
by Misha Koshelev 09 Aug '07

09 Aug '07

> To register those verbs for Linux desktops, some sort of command-line > wrapper around ShellExecute would be needed. I think this is a good > idea anyway. Does Windows have anything like that? Is it worth it for > me to try writing something like that based on winelib? Well this is exactly the start program which is already implemented. In fact I thought about this problem myself a bit, the problems with start right now for this purpose (starting wine associated files from linux) are: 1. start currently doesn't understand a simple UNIX path, easily fixed by prepending a Z: (assuming this is the drive the user has mapped to the UNIX root dir) 2. there is no standalone winestart program, and at least from my experimentation with Right Click->Open File With... on GNOME (or whatever the menu item is called), it won't let you put in "wine start" or wine start or the sort. What I actually do right now is use this shell script (I almost started working on this problem but then since the shell script was so easy I decided to focus on other things, but am still very interested in seeing it solved): #!/bin/sh wine start Z:$* And just associating it with my file type (well the problem with doing what I am doing is I am just associating it with a file .gb which I guess GNOME puts into some kind of text/plain type, so anything that is a text file ends up being opened with notepad on wine instead of gedit... I am too lazy to make it any more complex on my computer for now). Anyway, just though this info might help if you were not already aware, as the start program is definitely this wrapper around ShellExecute that already exists. One possibility would be to extend it to handle UNIX paths and then have it compiled and installed as a standalone winestart - like the other wine standalone programs we install, another is just to have the shell script somewhat like above installed (dangerous as Z: may not be mapped to the root so this would have to figured out) - I believe wineshelllink which is installed is a shell script, or maybe even go the route of letting the wine binary itself ShellExecute things (haven't really looked at it/thought this out in detail). Anyway, just my two cents. Thanks for thinking about/hopefully working on this. Misha > > > -- > Vincent Povirk

4 6

[Winetest] Possible removal of LoadLibrary and friends in the conformance tests
by Paul Vriens 09 Aug '07

09 Aug '07

Hi, With the current version of winetest, conformance tests for which the main dll is not available will not run anymore. This will be reported on test.winehq.org. We will be seeing the new approach as of 12:00 GMT when the new winetest.exe is available and the first tests come in. Several tests currently check for the existence of the dll via LoadLibrary and do a lot of GetProcAddress calls to retrieve function pointers. This should not be needed anymore in most cases. The tests that come to mind: d3d8 d3d9 d3drm gdiplus localspl localui pdh uxtheme and there are (and will be in the future) others. My plan, and this is open for discussion of course, is to: 1. Add the main dll back as part of the IMPORTS in the Makefile.in files 2. Change LoadLibrary to GetModuleHandle and still use GetProcAddress to catch unexported functions (for a short period). We do need to reporting missing functions. 3. Remove GetModuleHandle and/or GetProcAddress's if possible and make more use of 'skip' if needed. This will be a lengthy process so if there are volunteers, please step up. Eventhough this is some considerable amount of work to be done, in the end the code will be cleaner (and several lines shorter). Comments/remarks ? Cheers, Paul.

5 8

Re: WineD3D: better pixelformat selection code
by H. Verbeet 09 Aug '07

09 Aug '07

On 09/08/07, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > This code lets WineD3D use the pixelformat of the D3D device. The code helps > on Windows where OpenGL offers multiple pixelformats. > The stencil column is probably useful for determining if we need an stencil attachment for FBOs as well. >+int count_bits(int mask) >+{ >+ int i, count=0; >+ for(i=0; i<32; i++) >+ { >+ if(mask & (1<<i)) >+ count++; >+ } >+ return count; >+} The "classical" way to do that would be something like this: unsigned int count_bits(unsigned int mask) { unsigned int count; for (count = 0; mask; ++count) { mask &= mask - 1; } return count; } Ie, simply mask out the set bits one by one until none are set, rather than looping over all of them.

1 0

Re: user32: CallWindowProc[AW] for mismatched built-in winprocs should take into account if the window is Unicode (with testcase, fixes bug #9198)
by Dmitry Timoshkov 09 Aug '07

09 Aug '07

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote: > --- a/dlls/user32/tests/class.c > +++ b/dlls/user32/tests/class.c > @@ -32,6 +32,7 @@ > #include "winreg.h" > #include "wingdi.h" > #include "winuser.h" > +#include <commctrl.h> /* for WC_EDITW */ Besides using braces instead of quotes to match existing style it's not really nice to include commctrl.h in a user32 (more lower level) test. It shouldn't be too hard to add "Edit" in WCHAR notation. > /*********************************************************************** > */ > static void ClassTest(HINSTANCE hInstance, BOOL global) > @@ -560,7 +566,12 @@ static void test_defwndproc() > { > static const char classA[] = "deftest"; > static const WCHAR classW[] = {'d','e','f','t','e','s','t',0}; > + WCHAR unistring[] = {0x142, 0x40e, 0x3b4, 0}; /* a string that would be destoryed by a W->A->W conversion */ Any other string should work just fine. In the current form the test will fail for some locales. > diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c > index 27b31a1..4feb3d5 100644 > --- a/dlls/user32/winproc.c > +++ b/dlls/user32/winproc.c > @@ -2257,7 +2257,17 @@ LRESULT WINAPI CallWindowProcA( > > if (!func) return 0; > > - if (!(proc = handle_to_proc( func )) && !(proc = find_builtin_proc( func ))) > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procA || !IsWindowUnicode( hwnd )) > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + else > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + return result; > + } > + > + if (!(proc = handle_to_proc( func ))) > call_window_proc( hwnd, msg, wParam, lParam, &result, func ); > else if (proc->procA) > call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > @@ -2281,8 +2291,18 @@ LRESULT WINAPI CallWindowProcW( WNDPROC func, HWND hwnd, UINT msg, > LRESULT result; > > if (!func) return 0; > + > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procW || IsWindowUnicode( hwnd )) > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + else > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + return result; > + } > > - if (!(proc = handle_to_proc( func )) && !(proc = find_builtin_proc( func ))) > + if (!(proc = handle_to_proc( func ))) > call_window_proc( hwnd, msg, wParam, lParam, &result, func ); > else if (proc->procW) > call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > @@ -2340,7 +2360,17 @@ INT_PTR WINPROC_CallDlgProcA( DLGPROC func, HWND hwnd, UINT msg, WPARAM wParam, > > if (!func) return 0; > > - if (!(proc = handle_to_proc( func )) && !(proc = find_builtin_proc( func ))) > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procA || !IsWindowUnicode( hwnd )) > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + else > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + return result; > + } > + > + if (!(proc = handle_to_proc( func ))) > ret = call_dialog_proc( hwnd, msg, wParam, lParam, &result, func ); > else if (proc->procA) > ret = call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > @@ -2368,8 +2398,18 @@ INT_PTR WINPROC_CallDlgProcW( DLGPROC func, HWND hwnd, UINT msg, WPARAM wParam, > INT_PTR ret; > > if (!func) return 0; > + > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procW || IsWindowUnicode( hwnd )) > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + else > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + return result; > + } Please use spaces instead of tabs to match current formatting. -- Dmitry.

2 1

Wine Kernel Handle Support Module
by James Keane 08 Aug '07

08 Aug '07

I have been working on something that might be useful for kernel integration. It is a way for wine to create its own interrupt, so that a wine server/kernel/handle/whatever function could be called from userspace with a simple INT 0xwhatever. Just as linux uses int 0x80. The only problem I could see with this technique is that it directly modifies the IDT, which only exists on i386/amd64 architectures, so that means we would have to find something else. I am not sure if this is the direction that some people want to take, because I am sure this modification of the IDT would be considered improper by kernel types but come on, I mean i386 has something like 200 software interrupts and linux uses only one. As it stands now, I have code that works perfectly with amd64 processors and just need to implement the actual wine system calls for handles or whatever it is. i386 support is a stones throw away, I just need to setup a virtual machine. I know there is some discussion of what should be put in the kernel module, so I am asking for advice on what to implement... ie. just handles, everything wineserver does, etc.

4 3

exporting file associations for linux desktops
by Vincent Povirk 08 Aug '07

08 Aug '07

This was something I thought we wanted for wine for a long time, but I can't find any literature suggesting that's the case. So I'll just explain it here. As it is right now, we have a filetype/association system in Wine's registry, and we have a completely separate one in most Linux desktops. They do not talk to each other. Wine's system relies primarily on extensions because that's what Windows does, but the Linux system works based on MIME Types. I would like to see this gap bridged in one direction by exporting the information in Wine's registry in a simplified format and converting it to something useful for Linux desktops. From what I've seen so far, this looks surprisingly simple. On the Linux end, MIME Types can be registered as described at http://www.freedesktop.org/wiki/Specifications/AddingMIMETutor (only using ~/.local/share instead of /usr/local/share). fd.org doesn't seem to have a standard for registering actions so that would need to be desktop-specific, but I don't expect any major problems from that. The Windows registry does appear to contain some MIME Types, but they're spotty and unreliable. I'm told, though, that most desktops can cope with things like application/x-extension-html even when text/html exists. Generating types like that is probably the way to go. From there, it's a simple matter to get a list of verbs that apply to files with each extension. To register those verbs for Linux desktops, some sort of command-line wrapper around ShellExecute would be needed. I think this is a good idea anyway. Does Windows have anything like that? Is it worth it for me to try writing something like that based on winelib? Also, what's the best way to design this if I want to see it added to Wine? I know how I'd do it as a set of external programs, but I'd rather avoid that. Attached is a simple python script I wrote that prints all of the information I think is necessary to be exported from Wine's registry. I know python is the worst thing I could use if I want something in Wine, but it should be good enough that I can try to import the information on the Linux end before spending too much time on something that may or may not ultimately be useful. -- Vincent Povirk

2 1

Wine components: gdiplus
by Evan Stade 08 Aug '07

08 Aug '07

Hi, Could we add gdiplus to the bugzilla components list? thanks. -- Evan Stade

1 0

Re: Rob Shearman : secur32: Split the NTLM credential and context handles into separate objects.
by Kai Blin 08 Aug '07

08 Aug '07

On Wednesday 08 August 2007 15:59:23 Alexandre Julliard wrote: > > secur32: Split the NTLM credential and context handles into separate > objects. > > This prevents races with two threads using the helper object at the same > time on two different context handles, eliminates the need to free the > credential handle after freeing the context handles and also prevents a Rob, thanks for cleaning up the mess. This looks more sane now. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: user32: CallWindowProc[AW] for mismatched built-in winprocs should take into account if the window is Unicode (with testcase, fixes bug #9198)
by Alexandre Julliard 08 Aug '07

08 Aug '07

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > + hwnd = CreateWindowExW(0, classW, NULL, WS_OVERLAPPEDWINDOW, > + CW_USEDEFAULT, CW_USEDEFAULT, 680, 260, NULL, NULL, GetModuleHandleA(NULL), 0); > + ok(IsWindowUnicode(hwnd), "\n"); > + SetWindowLongPtrW(hwnd, GWLP_WNDPROC, (LONG_PTR)pDefWindowProcA); > + ok(IsWindowUnicode(hwnd), "\n"); > + ok(GetWindowLongPtrW(hwnd, GWLP_WNDPROC) == (LONG_PTR)pDefWindowProcW, "\n"); > + ok(GetWindowLongPtrA(hwnd, GWLP_WNDPROC) == (LONG_PTR)pDefWindowProcA, "\n"); > + SetWindowLongPtrA(hwnd, GWL_WNDPROC, (LONG_PTR)ClassTest_WndProc); > + ok(IsWindowUnicode(hwnd) == FALSE, "\n"); Please use meaningful error messages in the ok() calls. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Wine Kernel Handle Support Module
by Dan Kegel 08 Aug '07

08 Aug '07

keane wrote: > I am not sure if this is the direction that some people want to take, > because I am sure this modification of the IDT would be considered > improper by kernel types but come on, I mean i386 has something like > 200 software interrupts and linux uses only one. Do not anger the kernel gods, for they will not take your patch. You are putting the cart before the horse, If you want to use a kernel module, please figure out why first, and work on solving that problem using standard kernel idioms. Linus has said that he would take a patch to add support for win32 system calls if it solved a real problem. Albert Calahan mentioned a few possible benefits in a thread seven years ago: http://marc.info/?l=linux-kernel&m=96954760832002&w=2 You might dig around in that thread for ideas. - Dan

1 0

Re: programs/wineconsole: Correctly display chars 00..1F and 7F [try 2]
by Kirill K. Smirnov 08 Aug '07

08 Aug '07

Hi, Alexandre, > > > > Is there something wrong with my patch? Did I miss something important? > > I'm not at all convinced that the conversion has to happen at that > point. Do you have a test app that demonstrates this? I've written test application, which writes control chars and performs readback for comparision. It's behaviour heavily depends on console font: 1) True Type (lucida). Control chars are displayed as square boxes, ReadConsoleOutputCharacters[A|W] return codes [0..31]. 2) Raster (fixedsys). Control chars are correctly displayed as glyphs, ReadConsoleOutputCharacterA returns codes [0..31], ReadConsoleOutputCharacterW returns unicode glyphes. It seems I stumbled upon the same strange insane console behaviour I observed while working upon console codepages. (http://www.winehq.org/pipermail/wine-devel/2007-May/056511.html) Since wine renders fonts in his specific way (freetype, AFAIK), I propose the following: 1) Display control characters as glyphes. (like fixedsys). 2) ReadConsoleOutputCharacter[A|W] both should return characters without any corrupting - if I wrote [0..31] I expect [0..31], if I wrote unicode glyphes, I expect unicode glyphes to be returned. (like TrueType) My patch assumes this behaviour. Of course, I wanted to write proper wine test case, but it is impossible due to different default console fonts under Windows - test will fail. -- Kirill

1 0

Re: [kernel32/tests 2/2] Skip all tests if one W-function can't be found
by Paul Vriens 08 Aug '07

08 Aug '07

On 8/7/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > (Should be applied after "[kernel32/tests] Changed skip message"). > > There are to many W-functions called so skip everything if the first function is > not implemented. This makes the test not crash on win95/win98. > > Changelog > Skip all tests if one W-function can't be found > > Cheers, > > Paul > > > Don't use this one. I'll sent an easier fix. The "[kernel32/tests] Changed skip message" can still be applied though. Cheers, Paul.

1 0

Re: WineD3D: move fake context code over to WGL
by Alexandre Julliard 08 Aug '07

08 Aug '07

Roderick Colenbrander <thunderbird2k(a)gmx.net> writes: > Subject: [PATCH] Move WineD3D_CreateFakeGLContext and friends over > to WGL. For this we need a HDC and one received from lets say > GetDC(0) won't do. Further this HDC needs CS_OWNDC set. For this > reason we need our own window class. Why does it need CS_OWNDC? That sounds like a bug. -- Alexandre Julliard julliard(a)winehq.org

3 2

[Winetest] Status update (rsabase and secur32)
by Paul Vriens 08 Aug '07

08 Aug '07

Hi, The new winetest is running fine and new reports are produced (http://test.winehq.org/data/200708071000/). I have seen at least 2 things so far that I need some info on. rsabase.dll is not available on for example w2k3 and vista but the tests ran in the past. secur32.dll is not available on for example NT4 but the current tests check if security.dll is available instead. What should we do to cater for the above: - we could move for example rsabase tests to rsaenh (we forward everything to rsaenh as well) and something similar for secur32. - we could implement an exception list in winetest for these particular cases. Remarks/Comments? Cheers, Paul.

3 3

Missing library - faultrep.
by Peter Dons Tychsen 07 Aug '07

07 Aug '07

Hello. Wine is missing the library "faultrep". The library comes with Windows, and is used by apps for error reporting. Most apps don't really need it (unless something goes wrong), but simply require the DLL to be present. To start with i just wanted to add the DLL to Wine. I tried to submit a patch for this missing lib, but got zero response. Probably because there was something wrong with my commit. Any guess on what was wrong? /Pedro

2 4

Patch: VarWeekdayName
by Jiří Paleček 07 Aug '07

07 Aug '07

Hello, I want to ask, is anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2007-July/041434.html I'm asking because I have other patches, but don't know if it is worthwhile to send them. Regards Jiri Palecek

8 21

Re: [winecfg] Show version again in About box
by Dmitry Timoshkov 07 Aug '07

07 Aug '07

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > 'Wine 0.9.42' looks so much nicer than 'PACKAGE_STRING'. Thanks for catching this. Although a comment explaining why config.h is needed while there is no visible usage of #ifdef HAVE_xxx macros would be nice. -- Dmitry.

1 0

Re: [2/6] gdiplus: added GdipCreateBitmapFromFile
by Alexandre Julliard 07 Aug '07

07 Aug '07

"Evan Stade" <estade(a)gmail.com> writes: > + CloseHandle(file); > + > + if(CreateStreamOnHGlobal(buff, TRUE, &stream) != S_OK){ > + ERR("could not make stream\n"); > + GdipFree(buff); > + return GenericError; > + } You should create a stream on the file directly instead of reading it in first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/6] gdiplus: added GdipBitmapLockBits/GdipBitmapUnlockBits
by Alexandre Julliard 07 Aug '07

07 Aug '07

"Evan Stade" <estade(a)gmail.com> writes: > + bm_is_selected = (BOOL) hdc; That's ugly, you should use something like (hdc != 0) instead. > + stride = bmi.bmiHeader.biWidth * bitspp / 8; > + stride += stride % 4; This doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.
by Robert Shearman 07 Aug '07

07 Aug '07

Hans Leidekker wrote: > Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet. > We shouldn't be implementing winhttp on top of wininet as there are functions such as WinHttpSetCredentials (http://msdn2.microsoft.com/en-us/library/Aa384112.aspx) that can't be implemented on top of wininet functions. There are also issues with different error codes being returned as well as different callbacks (http://msdn2.microsoft.com/en-us/library/aa383917.aspx). -- Rob Shearman

5 7

FW: [Bug 2520] menu bar problem
by Ann & Jason Edmeades 06 Aug '07

06 Aug '07

>Vitaliy >Jason, please don't forget to cc wine-bugs when you reassign the bug. Yeah, sorry... Its late here :-) Out of interest, why don't we fix bugzilla to always enforce that userid (ie if it gets removed, it automatically gets inserted back). I'm sure I'm not the only one who forgets to do it sometimes? Jason

1 0

Re: [WINE] WIDL regression between 0.9.38 and 0.9.39
by Dan Hipschman 06 Aug '07

06 Aug '07

On Mon, Aug 06, 2007 at 04:24:39PM +0200, Herv? Poussineau wrote: > Hi Dan, > > I'm using Wine IDL compiler to compile some .idl files, and I found a > regression in WIDL between 0.9.38 and 0.9.39. > As you are the one who mostly changed WIDL between these releases, I'm > sending you this email ;) > > My .idl file looks like this one: > > [ > uuid (00112233-4455-6677-8899-AABBCCDDEEFF), > version(1.0), > pointer_default(unique) > #ifndef __midl > ,explicit_handle > #endif > ] > interface MyInterface > { > unsigned long GetRoot(handle_t BindingHandle, > [out, string, size_is(Length)] wchar_t > *RootString, > [in] unsigned long Length); > } > > Of course, Microsoft MIDL accepts to compile this file, so WIDL should too. > WIDL 0.9.38 was working, but WIDL 0.9.39 gives the following error: > error: write_string_tfs: Unimplemented for type 0x1b of name: RootString > > Type 0x1b is RPC_FC_CARRAY, but write_string_tfs function only supports > RPC_FC_BYTE, RPC_FC_CHAR and RPC_FC_WCHAR. > > Any idea how to fix it, or am I forced to keep WIDL 0.9.38? > > Thanks in advance, > > Hervé Hi Hervé. Thanks for the bug report. The code related to this problem was being worked on quite a bit recently, so I don't doubt there may be a regression. I may be a bit slow to look at this since I'm in the middle of working on something else at the moment, hence I'm CC-ing the list so other people can see that the problem exists. Dan

1 0

Re: [PATCH] msi: correct buffer overrun in msi_get_deferred_action().
by James Hawkins 06 Aug '07

06 Aug '07

On 8/5/07, William Waghorn <willw(a)litany.me.uk> wrote: > --- > dlls/msi/custom.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c > index 390113e..17f581c 100644 > --- a/dlls/msi/custom.c > +++ b/dlls/msi/custom.c > @@ -153,7 +153,7 @@ static LPWSTR msi_get_deferred_action(LPCWSTR > action, LPCWSTR actiondata, > return strdupW(action); > > len = lstrlenW(action) + lstrlenW(actiondata) + > - lstrlenW(usersid) + lstrlenW(prodcode) + 5; > + lstrlenW(usersid) + lstrlenW(prodcode) + 9; > deferred = msi_alloc(len * sizeof(WCHAR)); > > sprintfW(deferred, format, actiondata, usersid, prodcode, action); > This has been properly fixed in git. -- James Hawkins

1 0

Can we please have at least a minimal coding style ?
by Tomas Carnecky 06 Aug '07

06 Aug '07

This type of construct seems popular in the wine source: while (isspace(*GL_Extensions)) GL_Extensions++; Start = GL_Extensions; Or even worse (I've seen this in winex11.drv, and it took me quite a long time until I understood it - it was part of a larger block with a lot these constructs): if (cond) do_sth(); do_sth_else(); This indentation is so utterly stupid, it makes my brain hurt (I'm sure I'm not the only one)!! I don't know what AJs stance is on code readability and I know that there are no official coding style guidelines, but can we please avoid this? Can we agree on a set of fundamental style rules? To make peer-reviewing patches easier? And for people not familiar with the code easier to understand it? Please? tom

5 4

Some details about SHDoDragDrop
by Timo Kunze 06 Aug '07

06 Aug '07

Hi, currently Wine's SHDoDragDrop is a stub and the comment states that it probably is equivalent to DoDragDrop. That's not quite true. In one of my programs I passed a NULL drop source accidentally and to my surprise it worked. So SHDoDragDrop creates an IDropSource object for you if you don't pass one. I've also found out, that on Vista SHDoDragDrop does the drag-image generation for you if you pass a NULL hWnd to SHDoDragDrop. While the hWnd thing works only if the dragged data object describes shell items, the IDropSource thing works for any dragged data. HTH Timo -- www.TimoSoft-Software.de - Unicode controls for VB6 "Those who sacrifice freedom for safety deserve neither."

1 0

Re: winecfg: values list should be NULL-terminated.
by Paul Chitescu 06 Aug '07

06 Aug '07

Great, thanks! Paul On Mon, 6 Aug 2007, Kirill K. Smirnov wrote: > This fixes winecfg crash caused by recent winecfg changes.

1 0

Re: wine.inf: Remove RelayFromExclude. It hides the real call traces which makes nearly useless relay logs. [resend]
by Alexandre Julliard 06 Aug '07

06 Aug '07

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > Resend. Anything wrong with this patch? > > After this change went in, it became impossible to see what functions was > being called where and how inside Wine to understand what is happening. If > any one looks at the bugzilla and all of the reported +relay logs they are > 100% useless in determining the real cause of the problem. It wasn't the > case before without RelayFromExclude. In most cases it makes the trace much more readable and manageable. If you want to know what's going on inside Wine code there are better debug channels to use than relay. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32 - set_active_window uses SendMessage instead of PostMessage for WM_ACTIVATEAPP messages.
by Vitaliy Margolen 06 Aug '07

06 Aug '07

Peter Dons Tychsen wrote: > Hello Wine. > > On original Windows, the messages WM_ACTIVATEAPP are sent using > PostMessage() and not SendMessage() like in the current Wine > implementation. > > I have thoroughly verified that this is the case on Windows-XP (that it > uses PostMessage()). > > This error can lead to fatal focusing problems, as some programs call > more focus related functions when they receive this message. This leads > to recursive calls into set_active_calls. It does not crash, but leads > to unexpected results such as lost focus for mouse and keyboard. > > This fixes the focus for the game "Wild Metal" if you switch focus from > the game to the desktop, and then back again. > > http://www.rockstargames.com/classics/ > > Cheers, > > /Pedro > > This patch makes 45 msg.c tests in user32 fail for me. Could you double check your findings? Also when you say "thoroughly verified" have you used Wine tests or your own program? Vitaliy

4 9

Re: wined3d: Use a safer, more compliant method to parse extension strings
by Vitaliy Margolen 06 Aug '07

06 Aug '07

Chris Robinson wrote: > > + > + /* End */ > + {NULL, 0} > }; [..] > - for (i = 0; i < (sizeof(EXTENSION_MAP) / sizeof(*EXTENSION_MAP)); ++i) { > + for (i = 0; EXTENSION_MAP[i].extension_string; ++i) { What was the reason for this change? It's a static const array why do you want to treat it as a dynamically sized one? Vitaliy.

2 1

Re: [1/5] D3D9: Deal with failing surface creation
by H. Verbeet 05 Aug '07

05 Aug '07

On 03/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + ok(SUCCEEDED(hr) || hr == D3DERR_INVALIDCALL, "IDirect3DDevice9_CreateTexture: %s\n", DXGetErrorString9(hr)); Same comment as for yesterday's test (even though that one apparently made it in), I don't think that's a useful test. As the patch comment says, the point of the test isn't to test CreateTexture behaviour.

2 1

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice
by Vitaliy Margolen 05 Aug '07

05 Aug '07

Peter Dons Tychsen wrote: > OK. Please review this diff: > > I will re-submit it if you like it. > > /Pedro Alright looks good now (you might want to remove the extra white space your patch adds - git complains about those). Just left to make the same change to the other joystick interface :) BTW don't forget to cc: the wine-devel list when you replying. Vitaliy.

3 11

[winetest] Show missing tests in single/group results
by Paul Vriens 05 Aug '07

05 Aug '07

Hi, Before sending this to wine-patches I would like people to have a look first. I've added as many screenshots as I thought where needed to show the changes (so sorry in advance for the flood of pictures). This patch makes sure that missing tests are shown in the test results, both when there is only one system in a group (f.e. Win98) or multiple systems in a group. 'single_test_before' shows that currently we have a single '.' where a test is missing (without a link obviously or explanation). 'main_summary_before' shows the same '.' but now we have 2 systems in the group. This means there is a link to the group overview. 'group_overview_before' shows nothing for these particular tests (gdiplus). Now with the new output: 'single_test_after' still show the '.' but now it's marked todo (and a skip border as these tests are skipped). 'failing_test_single_onmouseover' shows at least some explanation. 'main_summary_after' is still the same with this new version (there is a link to the group overview). 'group_overview_after' shows that now the group overview correctly shows the missing tests and 'failing_test_onmouseover' shows some explanation. Remember that this is still without winetest producing output about missing dll's. Next patches will: - add a missing dll as one of the reasons for missing tests - add some better clue's on the main summary for multiple systems in a group (not a single '.' but maybe the same 'failed and skipped'). One of the thoughts I had was to replace the '.' with a '?' in case of missing tests for an unknown reason but I'm not sure about that yet. Comments/remarks etc.. are welcome. I'd also like to hear about other idea's for this page to make it useful for everybody. Apart from the fact that we probably should have more exposure to the fact that we have such a page/tool. We saw an immediate rise (slowed down again) in test results as soon as winetest was mentioned on 'http://tweakers.net/meuktracker/15817/Wine-0.9.42.html' (in Dutch). There it was also mentioned that some machines crashed because of the tests etc.. (maybe a wine-winetest component on bugzilla could help with that which we could reference on the main test.winehq.org/data/*/index.html page). Cheers, Paul.

1 0

Re: [PATCH] winecfg: Fix crash caused by calling set_reg_key with NULL value
by Evan Stade 04 Aug '07

04 Aug '07

On 8/3/07, Nigel Liang <ncliang(a)gmail.com> wrote: > diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c > index 84dd4c8..05f322c 100644 > --- a/programs/winecfg/winecfg.c > +++ b/programs/winecfg/winecfg.c > @@ -468,11 +468,15 @@ void set_reg_key(HKEY root, const char * > > wpath = HeapAlloc(GetProcessHeap(), 0, (strlen(path)+1)*sizeof(WCHAR)); > wname = HeapAlloc(GetProcessHeap(), 0, (strlen(name)+1)*sizeof(WCHAR)); > - wvalue = HeapAlloc(GetProcessHeap(), 0, (strlen(value)+1)*sizeof(WCHAR)); > > MultiByteToWideChar(CP_ACP, 0, path, -1, wpath, strlen(path)+1); > MultiByteToWideChar(CP_ACP, 0, name, -1, wname, strlen(name)+1); > - MultiByteToWideChar(CP_ACP, 0, value, -1, wvalue, strlen(value)+1); > + > + if (value) > + { > + wvalue = HeapAlloc(GetProcessHeap(), 0, (strlen(value)+1)*sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, value, -1, wvalue, strlen(value)+1); > + } > > set_reg_key_ex(root, wpath, wname, wvalue, REG_SZ); > > -- > 1.4.1 > > > > You need to initialize wvalue to NULL -- Evan Stade

2 2

Sent a patch twice
by Rene Kok 04 Aug '07

04 Aug '07

I never submitted a patch before. It wasn't a patch I created just resubmitting it. However I accidentally sent it to the wine-patches mailing list twice. The first time I wasn't subscribed, which I prefer not to because the huge amount of mail I'll get when I do :-) I subscribed and sent it again and now it's in there twice, oops! Anyway hope it's ok.

2 1

Re: mshtml: Remove const in front of REFIID as that is a macro that already starts with const.
by Andrew Talbot 04 Aug '07

04 Aug '07

Michael Stefaniuc wrote: > Jacek, > > I'm not sure about this patch. gcc 3.1.1 produced a warning about a > double const. The rules of what is const depending on where in the > declaration it is placed are mind bongling (especially at 1am) and I > don't know what the intention was here so please review. > > -static const REFIID tid_ids[] = { > +static REFIID tid_ids[] = { > &IID_IHTMLWindow2 > }; > It would be easier if one were obliged to always put const (and volatile) qualifiers to the right of what they qualify, then the whole declaration would read from right to left. Thus, here, char const * const *p; p is a pointer to a constant pointer to a constant char. The almost-universally adopted convention of putting the left-most qualifer on the left of the type it qualifies, as in const char *ch; rather than the equivalent char const *ch; rather spoils this flow. Here, static const REFIID tid_ids[]; could be rewritten static REFIID const tid_ids[]; And REFIID in a C setting is defined as: const GUID * __MIDL_CONST (where __MIDL_CONST is "const", if rpcproxy.h has not been included). So, in case anyone is still awake and interested: static const REFIID tid_ids[]; is equivalent to static const GUID *const const tid_ids[]; (Note the erroneous double const.) or static GUID const *const const tid_ids[]; as I would prefer to put it. So, to conclude, you don't want the extra const, and it may not have been the const you thought it was, either. :) -- Andy.

1 1

Bug introduced in 0.9.42 in printer dialog
by Christian Pradelli 04 Aug '07

04 Aug '07

A bug was introduced in version 0.9.42, that makes printer dialogs to not work. When you press Accept button in the printer dialog the I receive the followin error: fixme:commdlg:PRINTDLG_UpdatePrintDlgA No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandA Update printdlg was not successful! Should I post to bugzilla? Regards Christian c_pradelli(a)yahoo.com

2 1

Re: [PATCH] wined3d: Pass correct coord parameter to texture*DProj functions
by H. Verbeet 04 Aug '07

04 Aug '07

On 04/08/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > --- > dlls/wined3d/glsl_shader.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > This patch is plain wrong. The caller of shader_glsl_get_sample_function() is responsible for correctly adding the correct component for projected lookups, since that isn't always the "next" component, but in fact depends on the instruction that does the sampling. Of course if the author of this patch had actually read the source for the callers of shader_glsl_get_sample_function() (pshader_glsl_tex() in particular...) or alternatively had been familiar with D3D shader assembly, he would have known that. It does make me wonder though, particularly given the lack of any explanation for the patch, if this is actually supposed to fix anything?

1 0

Re: netapi32: Add lmuseflg.h and include it from lmuse.h.
by Kai Blin 04 Aug '07

04 Aug '07

On Saturday 04 August 2007 03:20:00 Francois Gouget wrote: > +/* > + * Copyright (C) the Wine project I think you need a year in the copyright statement. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: Nigel Liang : winecfg: Read/write registry in unicode.
by James Hawkins 04 Aug '07

04 Aug '07

On 8/3/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 2d5a89bab087d09f3e3876e29ae32a2e863273fe > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d5a89bab087d09f3e3876e29… > > Author: Nigel Liang <ncliang(a)gmail.com> > Date: Thu Aug 2 16:33:24 2007 -0700 > > winecfg: Read/write registry in unicode. > This patch breaks setting the windows version in winecfg (and I assume everything else that uses the registry): jhawkins@sphere2:~$ winecfg wine: Unhandled page fault on read access to 0x00000000 at address 0x7e5859d7 (thread 0010), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e5859d7). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7e5859d7 ESP:0033e2f0 EBP:0033e328 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:7e58d9e4 ECX:ffffffff EDX:00000000 ESI:7e587b60 EDI:00000000 Stack dump: 0x0033e2f0: 00110000 00000000 0000001c 0000000b 0x0033e300: 0016cdf8 0000000b 00000054 001727f8 0x0033e310: 0000001c 00172858 0016cdf8 7e58d9e4 0x0033e320: 7e587b60 7e587ac2 0033efd8 7e578877 0x0033e330: 80000002 7e587b60 7e587ab4 00000000 0x0033e340: 00000001 00000073 0033e398 7e1d19a7 Backtrace: =>1 0x7e5859d7 set_reg_key+0x8f(root=0x80000002, path=0x7e587b60, name=0x7e587ab4, value=0x0) [/home/jhawkins/wine/programs/winecfg/winecfg.c:471] in winecfg (0x0033e328) -- James Hawkins

2 1

Re: gdi32: don't print fixme more than once
by Robert Shearman 03 Aug '07

03 Aug '07

Evan Stade wrote: > diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c > index 9e7684b..2b4d03f 100644 > --- a/dlls/gdi32/enhmetafile.c > +++ b/dlls/gdi32/enhmetafile.c > @@ -1172,6 +1172,7 @@ BOOL WINAPI PlayEnhMetaFileRecord( > > case EMR_EXTSELECTCLIPRGN: > { > + static int extselectcliprgn_cases; > #if 0 > const EMREXTSELECTCLIPRGN lpRgn = (const EMREXTSELECTCLIPRGN *)mr; > HRGN hRgn = ExtCreateRegion(NULL, lpRgn->cbRgnData, (RGNDATA *)lpRgn->RgnData); > @@ -1180,7 +1181,8 @@ #if 0 > /* ExtSelectClipRgn created a copy of the region */ > DeleteObject(hRgn); > #endif > - FIXME("ExtSelectClipRgn\n"); > + if(!(extselectcliprgn_cases++)) > + FIXME("ExtSelectClipRgn\n"); > break; > } > It would be better to re-enable this code, remove the fixme and fix whatever bug caused it to be disabled in the first place than to not show the fixme as often. -- Rob Shearman

1 0

Re: [4/5] WineD3D: WINED3DSAMP_MAXMIPLEVEL fixes
by H. Verbeet 03 Aug '07

03 Aug '07

You are now executing that code multiple times.

2 1

Re: Lostwages : contributing.diff
by Jeremy White 03 Aug '07

03 Aug '07

Hi Tom, Thanks for thinking of this; I think James would appreciate it if he wasn't listed by name, though. Otherwise, though, it looks great. Cheers, Jeremy Tom Wickline wrote: > Hello, > > I'm CC: Jeremy White in on this patch, if possible I would like to ask > for his approval on the patch before its committed. > > About the patch: > I Changed the mailing address of the WPF to point to the Software > Freedom Conservancy, and added some info about it being a 501(c)(3) > organization. > > Cheers, > > Tom > > Changelog: update WPF information and mailing address > > > ------------------------------------------------------------------------ > > Index: en/contributing.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/contributing.template,v > retrieving revision 1.33 > diff -u -r1.33 contributing.template > --- en/contributing.template 21 Jun 2007 20:21:46 -0000 1.33 > +++ en/contributing.template 31 Jul 2007 02:55:13 -0000 > @@ -363,8 +363,17 @@ > <h3 id="wpf">Wine Party Fund</h3> > > <p>The purpose of the Wine Party Fund is to show appreciation to Wine > - developers by collecting funds for developer meetings, such as future Wine > - Conferences, or in some cases to purchase documentation.</p> > +developers by collecting funds for developer meetings, such as future > +Wine Conferences, or in some cases to purchase documentation.</p> > + > +<p>The organization that currently manages our donations is the > +<a href="http://conservancy.softwarefreedom.org/">Software Freedom > +Conservancy</a>. If you have any questions or are otherwise in need > +of further assistance please visit the SFC site.</p> > + > +<p>The Software Freedom Conservancy is a 501(c)(3) organization, and > +donations made through it are fully tax-deductible to the extent > +permitted by law.</p> > <p><strong>Ways to contribute:</strong></p> > <form action="https://www.paypal.com/cgi-bin/webscr" method="post"> > <div> > @@ -379,13 +388,12 @@ > <p>We also have a SourceForge PayPal account > <a href="http://sourceforge.net/donate/index.php?group_id=6241">sourceforge.net</a></p> > > -<p>You can also send cash, checks or international money order in US funds to:</p> > -<address>The Wine Party Fund > -c/o Jeremy White > -CodeWeavers > -2356 University Ave. West > -Suite 420 > -St. Paul, MN 55114</address> > +<p>You can also send cash, cheque or international money order in US funds to:</p> > +<address>Wine Project > +c/o James Vasille > +Software Freedom Conservancy > +1995 Broadway FL 17 > +New York, NY 10023-5882</address> > <p>Purchase books or music from <a href="http://www.amazon.com/exec/obidos/redirect-home/winehq"> > Amazon.com</a> or <a href="http://www.cdnow.com/from=sr-1093221">CDnow</a> (Use > these specific links only, so that the Wine Party Fund gets the credit.)</p>

1 0

[Fwd: [winetest] New gather script]
by Paul Vriens 03 Aug '07

03 Aug '07

Hi, Forgot to include wine-devel. -------- Original Message -------- Subject: [winetest] New gather script Hi Ferenc, Could you have a look at the new 'gather' script? (you're the original author after all). The new winetest (when committed of course) executable will report when a test is missing because of a failing dll. I've severely changed/mutilated 'gather' so: - it finds these missing dll tests and marks them - doesn't add these to the overall list of tests - goes through the whole list of tests to find out if (and why) tests are missing - it now shows also complete failing tests (for the group) in the group overview - add some extra onMouseOver on both group and single tests. - make sure we always show missing tests in the group overview. The new variables: $test->{dllmissing}->{$dll} (shows if a system/test is missing a dll) $group->{dllmissing}->{$unit} (tells if at least one system in the group is missing this dll, used for having a nice onMouseOver in the Main Summary) $group->{testmissing}->{$testname} (tells if at least one system in the group has a missing test for an unknown reason, needed to cope with the same onMouseOver as mentioned above). I'll split it up in smaller chunks when sent to wine-patches. Cheers, Paul. Index: gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.20 diff -u -r1.20 gather --- gather 13 Mar 2007 16:10:46 -0000 1.20 +++ gather 3 Aug 2007 07:28:36 -0000 @@ -96,9 +96,19 @@ my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; + if ($test =~ /_dll_missing/) { + # Mark this dll as being missing on one or more systems + + # For this run on this system + $testref->{dllmissing}->{$unit} = "This dll is missing on this system"; + # For the whole group + $group->{dllmissing}->{$unit} = "This dll is missing for some tests"; + } + else { + $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") + unless exists $alltests{$testname}; + } $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; - $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") - unless exists $alltests{$testname}; if ($count ne "failed") { if (defined $group->{extrema}->{$testname}) { my $extrema = $group->{extrema}->{$testname}; @@ -117,6 +127,28 @@ push @{$group->{tests}}, $testref; } +# Find missing tests and/or missing dlls and mark them +foreach my $group (@groups) { + next unless exists $group->{tests}; + foreach my $testname (sort keys %alltests) { + foreach my $test (@{$group->{tests}}) { + if (!exists $test->{results}->{$testname}) { + # The test is missing, try to find the reason + my ($dll,$subtest) = split(/:/, $testname); + if (exists $test->{dllmissing}->{$dll}) { + $test->{results}->{$testname} = [-1, -1, -1, -1]; + $group->{digest}->{$testname} = "differ"; + } + else { + $test->{results}->{$testname} = [-2, -2, -2, -2]; + $group->{digests}->{$testname} = "differ"; + $group->{testmissing}->{$testname} = $testname; + } + } + } + } +} + # Write out the tables my ($header); # same in thead and tfoot @@ -197,28 +229,42 @@ # Output a single cell of a test sub singletest { my ($test, $testname, $groupname) = @_; - - if (!exists $test->{results}->{$testname}) { - print OUT " <td class=\"note\">.</td>\n"; + my $file = "$test->{dir}/$testname.txt"; + my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; + if ($count eq "failed") { + # test run failed + my $msg = $todo eq "-"?"crash": + $todo == 258?"timeout":"failed"; + my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; + print OUT " <td class=\"note\">$fail</td>\n"; + } elsif ($count == -1) { + # dll missing + my ($dll, $subtest) = split(/:/, $testname); + print OUT <<"EOF"; + <td class="skip_pass"><a + title="No tests run as $dll.dll is not present on this system" + onMouseOver="No tests run as $dll.dll is not present on this system" + >0</a></td> +EOF + } elsif ($count == -2) { + # test missing + print OUT <<"EOF"; + <td class="skip_fail"><a + title="No tests run for an unknown reason" + onMouseOver="No tests run for an unknown reason" + >0</a></td> +EOF } else { - my $file = "$test->{dir}/$testname.txt"; - my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; - if ($count eq "failed") { - my $msg = $todo eq "-"?"crash": - $todo == 258?"timeout":"failed"; - my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; - print OUT " <td class=\"note\">$fail</td>\n"; - } else { - my $class = $error?"fail":"pass"; - my $skip = $skipped?"skip_":""; - print OUT <<"EOF"; + # test has run + my $class = $error?"fail":"pass"; + my $skip = $skipped?"skip_":""; + print OUT <<"EOF"; <td class="$skip$class"><a href="$file" title="$count tests, $todo TODO, $error errors, $skipped skipped" onMouseOver="refresh('$testname','$groupname $test->{tag}',$count,$todo,$error,$skipped);" >$error</a></td> EOF - } } } @@ -236,6 +282,7 @@ } else { my $href = "href=\"#$group->{name}\""; if (exists $group->{extrema}->{$testname}) { + # At least one system in this group has run this test. my ($min,$max) = @{$group->{extrema}->{$testname}}; my $class = $min==0?($max==0?"pass":"mixed"):"fail"; my $title = $min==0?"":" title=\"Best: $min\""; @@ -246,7 +293,23 @@ >$max</a></td> EOF } else { - print OUT " <td class=\"note\"><a $href>.</a></td>\n"; + my ($dll, $subtest) = split(/:/, $testname); + if ($group->{testmissing}->{$testname}) { + # At least one system in the group has a missing test (but + # not because of a missing dll). + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } elsif (exists $group->{dllmissing}->{$dll}) { + # All systems in the group have a missing dll related to this test. + print OUT <<"EOF"; + <td class="pass"><a $href + title="No tests run as $dll.dll is not present on all $group->{name} systems" + onMouseOver="No tests run as $dll.dll is not present on all $group->{name} systems" + >0</a></td> +EOF + } else { + # All systems in this group failed to correctly run the test. + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } } } }

1 0

msvcrt40.dll
by luis.busquets＠ilidium.com 03 Aug '07

03 Aug '07

Dear all, In relation to the file msvcrt40.dll File Version 5.1.2600.2180 Product Version 5.1.2600.2180 This file has been transformed and forwards all of its calls to either msvcrt.dll or msvcirt.dll The forwards to msvcrt.dll are set in the current wine msvcr40.spec but the rest of the functions, which should be forwarded to msvcirt, are stub. Nevertheless, msvcirt.dll is not currently one of the files to be ported, i.e., dlls/msvcirt does not exist. My questions are: 1. Can we add the forward to all the rest of the functions in the msvcrt40.dll spec file to msvcirt.dll? 2. Should we first add a wine port of msvcirt.dll? Luis

2 1

[PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.
by Misha Koshelev 03 Aug '07

03 Aug '07

> Hi Misha, > > Misha Koshelev wrote: > > This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding > > implementation, as we can successfully use the bscf values that are passed to report_data to get all > > the information. > > > > Additionally, the original implementation was somewhat incorrect at least for the case of the Http protocol > > as far as sending OnStopBinding > > This patch is already accepted, but unfortunately it's wrong. Tests > changed in the attached patch succeed on native urlmon.dll and fail on > current Wine. Probably only BSCF_LASTDATANOTIFICATION flag should be > used. Other OnProgress callbacks should be called depending on the real > binding state, not the one reported by protocol handler. > > Jacek >

1 0

Re: wine3d3: Check the destination recangle when for FastBlt().
by Stefan Dösinger 02 Aug '07

02 Aug '07

Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen: > Hello Wine! > > I have fixed a small bug in FastBlt(), which caused Wine to crash if the > application tried to do FastBlt() to a surface using a bad destination > setup. The problem is already fixed in normal Blt(), but was broken for > FastBlt(). > > This fixes a crash for the little game "Treasure Mole Winter Vacations": This check should be in ddraw, not wined3d. ddraw, d3d8 and d3d9 have different ideas about such checks, that's why the check was moved from WineD3D to the client libs. Originally it was in LockRect, and when it was moved the check was lost in Blt and BltFast. There should be a check in ddraw already, maybe it is not sufficient. Also please write a test case to verify that the fix is correct(look at dlls/ddraw/tests/dsurface.c). This will also prevent the problem from coming back. Treasure Mole broke after the ddraw rewrite because exactly this check was missing. I implemented it in LockRect, like in old ddraw, but I forgot to write a test for BltFast. Then a d3d9 game was broken because d3d9 LockRect behaved differently, a test was written for Lock(Rect) in ddraw, d3d8 and d3d9, and the range check moved to ddraw, d3d8 and d3d9 to be able to implement different checking in each version. Since I forgot to write a test when I originally fixed Treasure Mole the bug could creep back in again :-(

2 4

Re: [PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.
by Jacek Caban 02 Aug '07

02 Aug '07

Hi Misha, Misha Koshelev wrote: > This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding > implementation, as we can successfully use the bscf values that are passed to report_data to get all > the information. > > Additionally, the original implementation was somewhat incorrect at least for the case of the Http protocol > as far as sending OnStopBinding This patch is already accepted, but unfortunately it's wrong. Tests changed in the attached patch succeed on native urlmon.dll and fail on current Wine. Probably only BSCF_LASTDATANOTIFICATION flag should be used. Other OnProgress callbacks should be called depending on the real binding state, not the one reported by protocol handler. Jacek diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c index 187fb03..dcae846 100644 --- a/dlls/urlmon/tests/url.c +++ b/dlls/urlmon/tests/url.c @@ -255,6 +255,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, SET_EXPECT(OnDataAvailable); SET_EXPECT(OnStopBinding); + bscf = BSCF_LASTDATANOTIFICATION; hres = IInternetProtocolSink_ReportData(pOIProtSink, bscf, 13, 13); ok(hres == S_OK, "ReportData failed: %08x\n", hres);

1 0

Re: WGL: GetPixelFormat fix for offscreen formats
by Tomas Carnecky 02 Aug '07

02 Aug '07

from the patch: return physDev->current_pf; + TRACE("(%p): returns %d\n", physDev, physDev->current_pf); } What's the purpose of that TRACE() ? tom

2 1

Is there a process for reviewing a bugzilla staffer?
by Whit Blauvelt 02 Aug '07

02 Aug '07

Hi, Is there a formal process for reviewing an arguably incompetent bugzilla staffer? Obviously it wouldn't be to submit their name as a bug. But is there any defined administrative layer that concerns itself with people on that level who are dragging on the project? I looked around a bit for information on this. Sorry if it's posted somewhere and I missed it. Thanks, Whit

6 10

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported
by H. Verbeet 02 Aug '07

02 Aug '07

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ ok(hr == DD_OK || hr == DDERR_NOTEXTUREHW || DDERR_INVALIDPARAMS, That doesn't do what you want it to do. If the return value is irrelevant though, what's the point of the test?

2 3

RE: Is there a process for reviewing a bugzilla staffer?
by EA Durbin 02 Aug '07

02 Aug '07

I don't think we need to be rude and poke fun at new wine users by pointing out their mistakes to everyone. He may someday prove to be a valuable asset to the project, or may be driven off from contributing altogether because a dev/admin had to point out his errors for "entertainment" purposes. I don't see being rude to new users "entertainment", it comes across as being kind of a bully and deters people from contributing. We're all linux/wine newbs at some point, and telling them their posts are useless information instead of trying to help them in a friendly fashion is going to end up driving them away from the project.> Date: Wed, 1 Aug 2007 21:09:13 -0600> From: wine-devel(a)kievinfo.com> To: wine-devel(a)winehq.org> Subject: Re: Is there a process for reviewing a bugzilla staffer?> > Whit Blauvelt wrote:> > Hi,> > > > Is there a formal process for reviewing an arguably incompetent bugzilla> > staffer? Obviously it wouldn't be to submit their name as a bug. But is> > there any defined administrative layer that concerns itself with people on> > that level who are dragging on the project?> > > > I looked around a bit for information on this. Sorry if it's posted> > somewhere and I missed it.> > > > Thanks,> > Whit> > > > To spare everyone time and to skip directly to an entertainment see bug > 9147: http://bugs.winehq.org/show_bug.cgi?id=9147> > Vitaliy.> > > _________________________________________________________________ See what you’re getting into…before you go there. http://newlivehotmail.com

1 0

Re: [5/5] D3D9: Check for volume texture support before running the volume test
by H. Verbeet 02 Aug '07

02 Aug '07

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(!(caps.TextureCaps & D3DPTEXTURECAPS_CUBEMAP)) { That doesn't check for volume textures.

2 1

dwarf2_parse_udt_type Unhandled Tag type 0x16
by Robert Reif 02 Aug '07

02 Aug '07

I get tons of these sometimes when a program crashes: fixme:dbghelp_dwarf:dwarf2_parse_udt_type Unhandled Tag type 0x16 at ctx(0x34ec70,L"kernel32<elf>"), for debug_info(abbrev:0x17ab04,symt:0xe24ee4) which makes debugging difficult.

1 0

re: OT: Everyone at minnesota ok?
by Dan Kegel 02 Aug '07

02 Aug '07

I checked with Jeremy six hours ago and he said he hadn't heard of any of his folks being involved, whew. I've driven over that bridge a lot myself, and my father in law drove over it an hour before the collapse. There's a video of the collapse at http://edition.cnn.com/2007/US/08/02/bridge.collapse/

1 0

Re: mshtml #2: Make get_typeinfo thread safe.
by Alexandre Julliard 02 Aug '07

02 Aug '07

Jacek Caban <jacek(a)codeweavers.com> writes: > } > + > + tl = InterlockedExchangePointer((void**)&typelib, tl); > + > + if(tl) > + ITypeLib_Release(tl); That's not thread-safe. You need to use InterlockedCompareExchangePointer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (no subject)
by Maarten Lankhorst 02 Aug '07

02 Aug '07

Hello Vitaly, Vitaly Lipatov schreef: > If disk directory in dosdevices is not a link, QueryDosDevice fails on the > drive. > > Changelog: > Check QueryDosDevice return code Please add a shortlog in the message subject next time, so that I know what the patch does and what component it changes without reading the message. Cheers, Maarten

1 0

OT: Everyone at minnesota ok?
by Shachar Shemesh 02 Aug '07

02 Aug '07

For those who have not head, there was a lethal bridge collapse and there are several casualties. Codeweavers is located near there. Just wanted to make sure everyone is ok. Shachar

1 0

Re: dinput: fix joystick axis remapping
by Vitaliy Margolen 02 Aug '07

02 Aug '07

Erik Inge Bolsø wrote: > Without this, joystick axis remapping from the Wine registry, > as documented on http://wiki.winehq.org/UsefulRegistryKeys, > does not work in Star Wars Galaxies. > --- > - inst_id = DIDFT_MAKEINSTANCE(jse.number) | (number < 8 ? DIDFT_ABSAXIS : DIDFT_POV); > + inst_id = DIDFT_MAKEINSTANCE(number) | (number < 8 ? DIDFT_ABSAXIS : DIDFT_POV); Nice catch! Indeed it does fix the problem. Vitaliy.

1 0

(win16) simple CreateBitmapIndirect() fails on Windows? 2nd try
by Jennifer Lai 02 Aug '07

02 Aug '07

Hi, As I was writing tests for win16, I encountered the problem that even the simplest case of CreateBitmapIndirect fails on Windows? However, it succeeds with desired properties set on Wine. I used Open Watcom as well as MS Visual C++ Version 1.52 to compile these win16 tests. OpenWatcom can be downloaded for free here: http://www.openwatcom.org/index.php/Download The following commands are used to compile the test using Open Watcom. wcc -D_X86_ -DSTANDALONE bitmapIndirect.c -i=C:\WATCOM\h\win;C:\WATCOM\h -w4 -e25 -zq -od -d2 -bt=windows wlink file bitmapIndirect.obj This seems very mysterious to me. I'd really appreciate for any comments. Jennifer

2 1

(win16) simple CreateBitmapIndirect() fails on Windows?
by Jennifer Lai 01 Aug '07

01 Aug '07

Hi, As I was writing tests for win16, I encountered the problem that even the simplest case of CreateBitmapIndirect fails on Windows? However, it succeeds with desired properties set on Wine. I used Open Watcom as well as MS Visual C++ Version 1.52 to compile these win16 tests. OpenWatcom can be downloaded for free here: http://www.openwatcom.org/index.php/Download The following commands are used to compile the test using Open Watcom. wcc -D_X86_ -DSTANDALONE bitmapIndirect.c -i=C:\WATCOM\h\win;C:\WATCOM\h -w4 -e25 -zq -od -d2 -bt=windows wlink file bitmapIndirect.obj This seems very mysterious to me. I'd really appreciate for any comments. Jennifer

1 0

Re: WGL: fix wglChoosePixelFormatARB behavior [attempt 2]
by Roderick Colenbrander 01 Aug '07

01 Aug '07

Don't apply this one yet as noted by Chris Robinson it isn't fully correct yet. Roderick On Wednesday 01 August 2007 22:22, Roderick Colenbrander wrote: > Hi, > > According to the specs wglChoosePixelFormatARB returns the number of > matching pixelformats. This number can be different than the size of the > return buffer which is given by nFormats. > > Unfortunately glXChooseFBConfig doesn't return all formats when NULL is > passed for the attributes. This is due to some default settings not being 0 > or 'Don't care'. This required changes to ConvertAttribWGLtoGLX. > > Regards, > Roderick Colenbrander

1 0

EVE Regression?
by Stephan Rose 01 Aug '07

01 Aug '07

Starting with wine 0.9.42 I continuously get the following error trying to start EVE: fixme:d3d_draw:drawPrimitive Using software emulation because not all material properties could be tracked And I just get a black screen for the login screen and it'll just sit there forever like that. The error keeps being reported over and over until I close the window. Everything worked very well with 0.9.41 Any thoughts? Anything I can do? Thanks, Stephan

2 1

Re: WGL: fix wglChoosePixelFormatARB behavior
by Roderick Colenbrander 01 Aug '07

01 Aug '07

Ignore this patch. I'll write a better version. Roderick On Wednesday 01 August 2007 19:54, Roderick Colenbrander wrote: > Hi, > > According to the specs wglChoosePixelFormatARB returns the number of > matching pixelformats. This number can be different than the size of the > return buffer which is given by nFormats. > > This bug wasn't bad before but that was because we only offered 1 > pixelformat for onscreen and offscreen rendering. > > Regards, > Roderick Colenbrander

1 0

Re: mshtml #2: Added HTMLWindow's IDispatch methods implementation.
by Robert Shearman 01 Aug '07

01 Aug '07

Jacek Caban wrote: > static HRESULT WINAPI HTMLWindow2_item(IHTMLWindow2 *iface, VARIANT *pvarIndex, VARIANT *pvarResult) > diff --git a/dlls/mshtml/main.c b/dlls/mshtml/main.c > index 3f8131c..41f32eb 100644 > --- a/dlls/mshtml/main.c > +++ b/dlls/mshtml/main.c > @@ -51,10 +51,52 @@ DWORD mshtml_tls = 0; > > static HINSTANCE shdoclc = NULL; > > +static ITypeLib *typelib; > +static ITypeInfo *typeinfos[LAST_tid]; > + > +static const REFIID tid_ids[] = { > + &IID_IHTMLWindow2 > +}; > + > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + hres = LoadRegTypeLib(&LIBID_MSHTML, 4, 0, LOCALE_SYSTEM_DEFAULT, &typelib); > This isn't thread-safe. > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + } > + > + if(!typeinfos[tid]) { > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], typeinfos+tid); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + } > Why not just use the IID instead of an enumeration here? I know you're trying to cache the typeinfo here, but the current implementation of typelibs makes ITypeLib_GetTypeInfoOfGuid very cheap. > + > + *typeinfo = typeinfos[tid]; > + return S_OK; > +} > + > static void thread_detach(void) > { > - thread_data_t *thread_data = get_thread_data(FALSE); > + thread_data_t *thread_data; > + > + if(typelib) { > + unsigned i; > + > + for(i=0; i < sizeof(typeinfos)/sizeof(*typeinfos); i++) > + if(typeinfos[i]) > + ITypeInfo_Release(typeinfos[i]); > + > + ITypeLib_Release(typelib); > + } > Why are you doing this from DLL_THREAD_DETACH and not DLL_PROCESS_DETACH? -- Rob Shearman

2 1

New winetest skipping test for nonexistent dll's
by Paul Vriens 01 Aug '07

01 Aug '07

Hi, I've been busy trying to come up with a solution and attached you will find 2 patches. One for 'winetest that will make sure we have specific output for dll's that are not on the system. I have made the output as close to normal test output as possible, so we don't have to patch dissect (the tool that dissects the reports). One for 'gather', the tool that translates the reports into a nice html page. There will be (in contrast with the other skip's) no visibility in the group reports yet. I'll have to figure out how to do that nicely. For now I'm assuming that if one system doesn't have a dll, all the others (same platform) don't have it at well (I know bad assumption and it will be dealt with in next revisions). (I do have another version of 'gather' which deals with the group reports but shows the whole test for all systems (same platform of course) if one or more systems have a missing dll). If we pursue this then we probably also need to change old tests as that will mean we can strip a lot of code from the tests. Comments/remarks etc.. are welcome. Cheers, Paul. diff --git a/programs/winetest/main.c b/programs/winetest/main.c index f743ffc..3c4846d 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -433,6 +433,24 @@ extract_test_proc (HMODULE hModule, LPCTSTR lpszType, LPTSTR lpszName, LONG_PTR lParam) { const char *tempdir = (const char *)lParam; + char dllname[MAX_PATH]; + HMODULE dll; + + /* Check if the main dll is present on this system */ + strcpy(dllname, lpszName); + *strstr(dllname, "_TEST.EXE") = 0; + + dll = LoadLibrary(dllname); + if (!dll) { + /* Here we add some information to the results file + * that indicates that the dll is not present + * on this platform. + */ + report (R_WARNING, "dll : %s is not present", dllname); + return TRUE; + } + FreeLibrary(dll); + get_subtests( tempdir, &wine_tests[nr_of_files], lpszName ); nr_of_tests += wine_tests[nr_of_files].subtest_count; nr_of_files++; Index: gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.20 diff -u -r1.20 gather --- gather 13 Mar 2007 16:10:46 -0000 1.20 +++ gather 1 Aug 2007 16:27:19 -0000 @@ -96,6 +96,9 @@ my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; + if ($test =~ /_dll_missing/) { + $testref->{dll}->{$unit} = "missing"; + } $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") unless exists $alltests{$testname}; @@ -199,7 +202,18 @@ my ($test, $testname, $groupname) = @_; if (!exists $test->{results}->{$testname}) { - print OUT " <td class=\"note\">.</td>\n"; + my ($unit1, $test1) = split(/:/, $testname); + my $dll = $test->{dll}->{$unit1}; + if ((defined $dll) && ($dll eq "missing")) { + print OUT <<"EOF"; + <td class="skip_pass"><a + title="No tests run as $unit1.dll is not present on this system" + onMouseOver="No tests run as $unit1.dll is not present on this system" + >0</a></td> +EOF + } else { + print OUT " <td class=\"note\">.</td>\n"; + } } else { my $file = "$test->{dir}/$testname.txt"; my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; @@ -223,6 +237,8 @@ } foreach my $testname (sort keys %alltests) { + next unless $testname !~ /_dll_missing/; + print OUT <<"EOF"; <tr> <td class="test"> @@ -290,6 +306,7 @@ <tbody onDblClick="clone();"> EOF foreach my $testname (sort keys %alltests) { # skip identical + next unless $testname !~ /_dll_missing/; my $digest = $group->{digests}->{$testname}; next unless defined $digest && $digest eq "differ"; print OUT <<"EOF";

2 1

Re: Add winhttp.dll.
by Vijay Kiran Kamuju 01 Aug '07

01 Aug '07

Hi Jacek, I think you can use the header I sent a while back to wine-patches for this. http://www.winehq.org/pipermail/wine-patches/2005-September/020901.html The original patch: http://www.winehq.org/pipermail/wine-patches/attachments/20050923/790dfab2/… This might require some re-work. It was rejected at that time, when I wanted to add winhttp.dll It might be of some help to you. Thanks, VJ

2 1

RPC questions
by Kai Blin 01 Aug '07

01 Aug '07

Hi folks, I will be getting into working on RPC soonish, and some of that I'd like to use for Wine. However, I don't know my way around that code so far, what would be a good starting point to tackle this? My goal is to set up a daemon that will take care of remote named pipes over smb and all of that stuff, while all that Wine needs to do is to access this daemon talking DCE-RPC. As we probably don't need to link anything, we will be able to use that daemon for other jobs, like doing netapi32 calls, etc. Where would I get started for this? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.
by Paul Vriens 01 Aug '07

01 Aug '07

Hans Leidekker wrote: > These APIs were introduced with Vista. > > -Hans > > Changelog > Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime. > > > ------------------------------------------------------------------------ > > Hi Hans, I was going through some test failures (already sent a patch for missing defines). It appears that a lot of the used strings, like "System Up Time" is depending on the locale. Some Dutch tests show "Systeem ingeschakeld" instead. Any idea how to fix that? Another thing is that "pdh.dll" is not by default present on NT4 and below so the tests have to be changed to cope with that as well. Should I have a go at that? Cheers, Paul.

3 10

32bit winelib builds in x86_64
by Michael Ost 01 Aug '07

01 Aug '07

What's the command for building a 32bit winelib .dll.so and .exe.so with wineg++ in an x86_64 environment? I am used to doing dlls with: $ wineg++ -shared DLL.spec -o DLL.dll.so ... and exes with: $ wineg++ -o APP.exe.so ... Seems I need to use "-m32" for g++, "--32" for as, and "-m elf_i386" for ld. But with all the nested calls of wineg++ and winebuild I can't figure out how to get those options passed in everywhere they are needed. Any hints? Cheers... Michael Ost

2 1

Re: Implement LockWorkstation using xdg-screensaver from explorer
by Alexandre Julliard 01 Aug '07

01 Aug '07

"Steven Edwards" <winehacker(a)gmail.com> writes: > This time in explorer.... > > With this patch, Process Explorer no longer crashes when locking the > workstation from within the application. If xdg-screensaver is not > present on the system, explorer simply returns in which case > LockWorkstion thinks it still succeeded. I still like the idea of > having our own screensaver for Desktop mode and running that when > LockWorkstation is called. If this is accepted then I will either add > a check for desktop mode to avoid the call to xdg-screensaver or write > a wine scr that only runs in Desktop mode. To be able to do that you need to send the request to the existing explorer process, not start a new one. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [4/4] winex11.drv: draw custom dashes [try2]
by Evan Stade 01 Aug '07

01 Aug '07

On 7/30/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > [try2] > * matched braces style of rest of file > * spread code out to make it more readable > * simplified use of gdi_to_x11_dashes > > dlls/winex11.drv/graphics.c | 3 + > dlls/winex11.drv/pen.c | 123 +++++++++++++++++++++++++++++++++++++++++-- > dlls/winex11.drv/x11drv.h | 1 > 3 files changed, 120 insertions(+), 7 deletions(-) > > -- > Evan Stade > > I am not sure how to make this patch more amenable. The gdi_to_x11_dashes function is indeed a bit unwieldy but it doesn't have all that simple a task. Does anyone have some suggestions on how to make it more acceptable? -- Evan Stade

1 0

Re: user32: Add a stub for GetAppCompatFlags2
by Michael Stefaniuc 31 Jul '07

31 Jul '07

Hello Detlef, Detlef Riekenberg wrote: > Fix a Crash in PDFCreator with native ps5ui.dll > > Changelog: > user32: Add a stub for GetAppCompatFlags2 > > ------------------------------------------------------------------------ > >>From c2e87ce86f59f8b4346e682fd16d0d7364ba1848 Mon Sep 17 00:00:00 2001 > From: Detlef Riekenberg <wine.dev(a)web.de> > Date: Tue, 31 Jul 2007 05:27:55 +0200 > Subject: [PATCH] user32: Addd a stub for GetAppCompatFlags2 > --- > dlls/user32/misc.c | 11 ++++++++++- > dlls/user32/user32.spec | 2 +- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/misc.c b/dlls/user32/misc.c > index bd1c9f7..3b20d6d 100644 > --- a/dlls/user32/misc.c > +++ b/dlls/user32/misc.c > @@ -575,7 +575,16 @@ BOOL WINAPI UnregisterDeviceNotificatio > */ > DWORD WINAPI GetAppCompatFlags( HTASK hTask ) > { > - FIXME("stub\n"); > + FIXME("(%p) stub\n", hTask); > + return 0; > +} > + > +/*********************************************************************** > + * GetAppCompatFlags (USER32.@) The comment doesn't match the function name. > + */ > +DWORD WINAPI GetAppCompatFlags2( HTASK hTask ) > +{ > + FIXME("(%p) stub\n", hTask); > return 0; > } > > diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec > index 8bf9ad1..d626053 100644 > --- a/dlls/user32/user32.spec > +++ b/dlls/user32/user32.spec > @@ -244,8 +244,8 @@ # @ stub EnterReaderModeHelper > @ stdcall GetAltTabInfoA(long long ptr ptr long) > @ stdcall GetAltTabInfoW(long long ptr ptr long) > @ stdcall GetAncestor(long long) > -# @ stub GetAppCompatFlags2 > @ stdcall GetAppCompatFlags(long) > +@ stdcall GetAppCompatFlags2(long) > @ stdcall GetAsyncKeyState(long) > @ stdcall GetCapture() > @ stdcall GetCaretBlinkTime() > > > ------------------------------------------------------------------------ > > bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111

2 1

msvcr80 support!
by Dan Kegel 31 Jul '07

31 Jul '07

It may be time to start revisiting bugs related to our lack of msvcr80 support ( cf. http://bugs.winehq.org/show_bug.cgi?id=6591 ), as it seems to have started working in the last week. I don't know if it's complete yet, but this is way cool... - Dan

6 7

Re: dlls/comctl32: According to the PSDK, DrawShadowText() takes a non-const RECT pointer.
by Andrew Talbot 31 Jul '07

31 Jul '07

Yes. It seems that the corresponding MSDN web page is out of step. -- Andy.

1 0

Outstanding regression in unicode since 0.9.41
by Scott Ritchie 31 Jul '07

31 Jul '07

Regressions are easiest to fix when caught quickly. Here's one that didn't get fixed in the latest version: http://bugs.winehq.org/show_bug.cgi?id=8948 If anyone needs help reproducing it, you can ask me for help. It should be as simple as the (scrolled down) part of the bug report though - install both installers, then launch the lobby with your desktop link. Thanks, Scott Ritchie

1 0

Interesting bit on schedulers and Wine
by Juan Lang 31 Jul '07

31 Jul '07

Sorry for the spam. There's been a flame^H^H^H^H^Hthread over on lkml about CFS and SD schedulers, and Ingo's tested Quake3 on Wine using both: http://kerneltrap.org/node/14023 Someone else tested UT2004 with both as well, and there are pretty pictures: http://people.redhat.com/mingo/misc/cfs-vs-sd-wine-quake.jpg http://people.redhat.com/mingo/misc/cfs-sd-ut2004-perf.jpg Happy hacking, --Juan

1 0

About new environment variable
by Zhongli Xu 31 Jul '07

31 Jul '07

After I add an environment avriable in the system.reg file, e.g. [System\\CurrentControlSet\\Control\\Session Manager\\Environment] 1185851455 "MY_VARIABLE"="VALUE" I tried to read this variable thru the API GetEnvironmentVariable(), but it failed. Other variables, such as PATH, OS, are OK. Any idea is welcomed.

4 3

Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by a Windows resource compiler
by Steven Edwards 31 Jul '07

31 Jul '07

On 7/30/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Subject: [PATCH 3/5] winecfg: Make winecfg resources compilable by a Windows resource compiler In this case do you mean windres or rc? I ask because if its rc then shouldn't we fix wrc to not accept these sources also? If its windres thats broken I think there is a workaround for the problem. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

4 13

Re: dpnlobby.dll implementation
by Maarten Lankhorst 31 Jul '07

31 Jul '07

Luis C. Busquets Pérez schreef: > File that just forwards one function included for compatibility issues Hi, I think you're missing a few files here, are you sure you've added the files from dlls/dpnlobby? Cheers, Maarten

1 0

Re: update of msvcrt.spec
by Dmitry Timoshkov 31 Jul '07

31 Jul '07

"Luis C. Busquets PÃ©rez" <luis.busquets(a)ilidium.com> wrote: > This patch updates the msvcrt.spec and adds the version number of the > product. Note that with the same file version number there are various > product version number files. msvcrt in Windows doesn't export APIs you have added by ordinal. Also there is no need to shuffle existing entries around. -- Dmitry.

1 0

Re: WineD3D: compile against standard GL headers [attempt3]
by H. Verbeet 31 Jul '07

31 Jul '07

On 31/07/07, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > In this version I have also added the prototype for the ARB multisample > extension. > Did you attach the wrong patch?

1 0

Re: user32: erase parent when hiding child
by Dmitry Timoshkov 31 Jul '07

31 Jul '07

"Clinton Stimpson" <cjstimpson(a)utwire.net> wrote: > ChangeLog: > user32: erase parent when hiding child As I already pointed out erasing a parent is supposed to be done in the server. You need to look there why it doesn't happen and add a fix there. -- Dmitry.

2 1

Re: WineD3D: compile against standard GL headers [attempt2]
by H. Verbeet 31 Jul '07

31 Jul '07

On 31/07/07, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > This is the second version of this patch. As Henri suggested extensions are > now defined to 1 and GL_EXT_LEGACY has been set too. > That's better, but you're still missing the functions for GL_ARB_multisample and GL_EXT_vertex_weighting. Since GL_EXT_vertex_weighting can be removed completely that would effectively only be a single function, glSampleCoverageARB.

1 0

Re: WineD3D: compile against standard GL headers
by H. Verbeet 31 Jul '07

31 Jul '07

On 31/07/07, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > This patch allows WineD3D to build against a standard GL.h and removes the > dependency on glext.h. This is useful for building WineD3D against > opengl32.dll. > > Regards, > Roderick Colenbrander > - You should #define the extensions to 1, like it's done for the other extensions. eg. #ifndef GL_NV_texture_env_combine4 #define GL_NV_texture_env_combine4 1 ... #endif - GL_ARB_multisample & GL_EXT_vertex_weighting also define new functions, you should add those as well. - If you're going to remove the glext.h include, you should also #define GL_GLEXT_LEGACY, or gl.h will potentially pull it in by itself. - You should also remove the GL_GLEXT_PROTOTYPES define, it should only be used by glext.h

2 1

[setupapi/tests] Any reason why we do a GetProcAddress for the functions?
by Paul Vriens 31 Jul '07

31 Jul '07

Hi, Is there any reason we do a GetProcAddress for the setupapi functions used in the setupapi tests? It look like they are exported properly on win95 until Vista. Or is it just because the first patch for these tests did LoadLibrary/GetProcAddress so the rest followed? Although most of the tests do a GetProcAddress, the result is actually never checked (neither in the init phase nor before calling a function). (We also do a LoadLibrary where the library is already imported, so GetModuleHandle seems more appropriate anyway). Anyone? Cheers, Paul.

1 0

Re: [PATCH] winecfg: Add menu font settings to desktop integration tab
by Vitaliy Margolen 30 Jul '07

30 Jul '07

Nigel Liang wrote: > diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc > index 5972c3b..e61bf29 100644 > --- a/programs/winecfg/En.rc > +++ b/programs/winecfg/En.rc > @@ -200,6 +200,11 @@ BEGIN > CONTROL "Link to:",IDC_LINK_SFPATH,"Button",BS_AUTOCHECKBOX|WS_TABSTOP|WS_DISABLED,15,195,50,13 > EDITTEXT IDC_EDIT_SFPATH,65,195,145,13,ES_AUTOHSCROLL|WS_TABSTOP|WS_DISABLED > PUSHBUTTON "Browse",IDC_BROWSE_SFPATH,215,195,30,13,WS_DISABLED > + GROUPBOX " Menu Font ",IDC_STATIC,8,216,244,50 > + LTEXT "Font: ",IDC_STATIC,20,230,40,10 > + COMBOBOX IDC_MENUFONT_COMBO,55,228,186,30,CBS_DROPDOWNLIST|CBS_SORT|WS_VSCROLL|WS_TABSTOP > + LTEXT "Size: ",IDC_STATIC,20,249,40,10 > + COMBOBOX IDC_MENUFONT_SIZECOMBO,55,247,50,30,CBS_DROPDOWNLIST|WS_VSCROLL|WS_TABSTOP > END There is already a drop down list where you can select menu and the "Font" button. You should use those instead. Of course you will need to make it work for all other items that might have font as an option (like a caption, window, etc). Vitaliy.

2 3

build regression, GLX_RGBA_FLOAT_BIT_ARB undeclared?
by Dan Kegel 30 Jul '07

30 Jul '07

I just did a git pull, and compilation is failing with opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) I think that symbol reference was added just today: http://winehq.org/pipermail/wine-cvs/2007-July/034660.html and is supposed to come from glext.h. Do we need some #ifdef action here? I'm developing on dapper. $ cat /etc/issue Ubuntu 6.06.1 LTS \n \l $ dpkg-query -S glext.h mesa-common-dev: /usr/include/GL/glext.h $ dpkg-query -W mesa-common-dev mesa-common-dev 6.4.1-0ubuntu8

2 2

Re: oleaut32: Constify some variables
by Marcus Meissner 30 Jul '07

30 Jul '07

On Mon, Jul 30, 2007 at 09:27:45PM +0100, Andrew Talbot wrote: > Changelog: > oleaut32: Constify some variables. > > diff -urN a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > --- a/dlls/oleaut32/typelib.c 2007-07-30 17:23:19.000000000 +0100 > +++ b/dlls/oleaut32/typelib.c 2007-07-30 21:23:13.000000000 +0100 > @@ -147,7 +147,7 @@ > /* > * Find a typelib key which matches a requested maj.min version. > */ > -static BOOL find_typelib_key( REFGUID guid, WORD wMaj, WORD *wMin ) > +static BOOL find_typelib_key( REFGUID guid, const WORD *wMaj, WORD *wMin ) > { > static const WCHAR typelibW[] = {'T','y','p','e','l','i','b','\\',0}; > WCHAR buffer[60]; > @@ -172,7 +172,7 @@ > { > TRACE("found %s: %x.%x\n", debugstr_w(buffer), v_maj, v_min); > > - if (wMaj == v_maj) > + if (*wMaj == v_maj) > { > if (*wMin == v_min) > { > @@ -274,7 +274,7 @@ > > TRACE_(typelib)("(%s, %x.%x, 0x%x, %p)\n", debugstr_guid(guid), wMaj, wMin, lcid, path); > > - if (!find_typelib_key( guid, wMaj, &wMin )) return TYPE_E_LIBNOTREGISTERED; > + if (!find_typelib_key( guid, &wMaj, &wMin )) return TYPE_E_LIBNOTREGISTERED; > get_typelib_key( guid, wMaj, wMin, buffer ); Alexandre committed a fixed version of this part of the patch already. See: http://source.winehq.org/git/wine.git/?a=commitdiff;h=36720b4945f90896379e7… The const fixup is no longer necessary, since the value now gets passed as argument and not as pointer. The rest might be necessary. Ciao, Marcus

1 0

winex11.drv compile failure
by James Hawkins 30 Jul '07

30 Jul '07

Compile fails for me with today's git: opengl.c: In function 'ConvertAttribWGLtoGLX': opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) opengl.c:676: error: (Each undeclared identifier is reported only once opengl.c:676: error: for each function it appears in.) opengl.c: In function 'get_render_type_from_fbconfig': opengl.c:845: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) opengl.c:846: error: 'GLX_RGBA_FLOAT_TYPE_ARB' undeclared (first use in this function) -- James Hawkins

3 2

tests/msi.c fails when run twice on Wine?
by Paul Vriens 30 Jul '07

30 Jul '07

Hi, The msi test currently fails for me on Wine when run the second time after getting a clean environment: rm -rf ~/.wine make msi.ok msi: 101 tests executed (0 marked as todo, 0 failures), 0 skipped. rm msi.ok make msi.ok msi.c:366: Test failed: Expected INSTALLSTATE_UNKNOWN, got 1 msi: 101 tests executed (0 marked as todo, 1 failure), 0 skipped. Anyone? Cheers, Paul.

3 10

Re: [inkobj 2/2] Add stub test for inkobj.dll Try #2 with attachment
by Paul Vriens 30 Jul '07

30 Jul '07

John Klehm wrote: > Adds directory, makefile.in, and c file for simple test. This test tries > to do LoadLibrary("inkobj.dll"). > > I apologize for forgetting the attachment. > > Regards, > John > > > > ------------------------------------------------------------------------ > > Hi, Are you planning on having more tests? It seems a lot of overkill if you just want to see if the library can be loaded/unloaded. The loadlibrary also doesn't make much sense as inkobj is already imported (Makefile.in). If it can't be loaded the test will not even run. Are you also sure that this dll exists on every platform we run tests on (win98....Vista)? Cheers, Paul.

2 1

Linuxworld BOF?
by Dan Kegel 30 Jul '07

30 Jul '07

Anyone going to Linuxworld in San Francisco next week? It's free to go to the exhibits and BOFs if you register in advance; go here to register (and scroll to the bottom for the exhibit-only free choice): http://linuxworldexpo.com/live/12/TB296182 I'm probably going to hang out in the exhibit hall on Wed Aug 8th. Maybe we could organize a lunch BOF of Wine developers... - Dan

1 0

Re: [PATCH] winecfg: Add trackbar to set screen resolution in graphics tab (try 2)
by Alexandre Julliard 30 Jul '07

30 Jul '07

Nigel Liang <ncliang(a)gmail.com> writes: > +/* Utility functions to convert between WCHAR and long */ > +long wcstolong(WCHAR * wcs) > +{ > + int i; > + long lRet = 0; > + BOOL bNeg = FALSE; > + > + for (i = 0; wcs[i] != '\0'; i++) { > + if (i == 0 && wcs[i] == '-') { > + bNeg = TRUE; > + continue; > + } > + > + lRet = lRet * 10 + (wcs[i] - '0'); > + } > + return (bNeg ? -lRet : lRet); > +} > + > +WCHAR *longtow(long num, WCHAR *wcs) > +{ > + static const WCHAR str[] = { '%', 'l', 'd', 0 }; > + wsprintfW(wcs, str, num); > + return wcs; > +} That's ugly. You should avoid using long if not really necessary, since it doesn't have the same size in MSVC. You shouldn't name a function wcs something since that's what wchar_t functions use. In any case we already have atoiW for that purpose. Also I don't think wrapping wsprintf is needed. -- Alexandre Julliard julliard(a)winehq.org

2 1

msvcr80 support!
by Luke Bratch 30 Jul '07

30 Jul '07

--- Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Windows Live messenger still refuses to start. Do I have to do anything > special(other than updating wine), or should I report a bug for this: > > /usr/src/wine/linux/wine msnmsgr.exe > fixme:actctx:parse_depend_manifests Could not find dependent assembly > L"Microsoft.Windows.Common-Controls" > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\msnmsgr.exe") not found > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\MSNCore.dll") not found > err:module:import_dll Library MSNCore.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\msnmsgr.exe") not found > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\ContactsUX.dll") not found > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\MSNCore.dll") not found > err:module:import_dll Library MSNCore.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\ContactsUX.dll") not found > err:module:import_dll Library ContactsUX.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\msnmsgr.exe") not found > err:module:LdrInitializeThunk Main exe initialization for L"C:\\Programme\\MSN > Messenger\\msnmsgr.exe" failed, status c0000135 > > I ran it from its installation directory, not from C:\windows\winsxs\...\. > When running it from msvcr80's directory it pops up a message box saying that > the app tried to load the C runtime incorrectly. This used to work before. > (Live messenger failed to connect later, for some other reasons) Did you find a fix for this? As per Alexandre's suggestion I tried installing native common controls, and also copying all the manifest files from a Windows machine (even the whole winsxs directory), but I still get the same error as you when I try to run my application. ___________________________________________________________ Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your free account today http://uk.rd.yahoo.com/evt=44106/*http://uk.docs.yahoo.com/mail/winter07.ht…

2 1

Re: [advapi32/tests] Use skip when we don't have enough rights
by Edwin Smulders 30 Jul '07

30 Jul '07

This is a little offtopic, but the extra testresults might be because the test link was posted in the comments of a well-known dutch computer site (in dutch) http://tweakers.net/meuktracker/15817/Wine-0.9.42.html I thought you might want to know, and I'll try to link the test more often there :) (it wasnt me who posted it this time though) On 7/30/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > We suddenly have loads of new winetest results. Catched this one for Vista. > > Changelog > Use skip when we don't have enough rights > > Cheers, > > Paul. > > > > >

1 0

ntdll: add bolivian time zone info
by Lei Zhang 30 Jul '07

30 Jul '07

Hi, A user requested this in bug 9083.

1 1

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice
by Vitaliy Margolen 29 Jul '07

29 Jul '07

Peter Dons Tychsen wrote: > On Sun, 2007-07-29 at 13:40 -0600, Vitaliy Margolen wrote: >> Peter Dons Tychsen wrote: >>> On Sun, 2007-07-29 at 11:15 -0600, Vitaliy Margolen wrote: >>> I have re-sent the patch with all your remarks fixed, except for the one >>> regarding joystick_linuxinput.c, which cannot be done with the current >>> code as alloc_device() is too different in the two versions for the >>> patch to work. I have however made sure that the version in >>> joystick_linuxinput.c does not have this problem. >>> >> Why do you think they are so different? Looks almost the same to me. >> Few more things to fix: > They are almost the same... but different for exactly the thing i am > changing. Notice the difference in the way the device is found. > One implementation uses Data3 to look it up, the other loops through all > devices and compares with the GUID. Well yeah, but the way they identifying which device is which is about the same. If you look at the find_joydevs() you'll see what it's doing with that giud.Data3 field. So you need to pick which way you want to do it (the way it's done in joystick_linux.c or joystick_linuxinput.c). And modify the other one accordingly. I don't like iterating over the whole array, and doing whole GIUD comparison, when you can get the index (the way you have it). Just make sure it doesn't overflow >>> -#undef MAX_JOYSTICKS >> You removed this, but you haven't added it back. > Why? I removed it so the rest of the file could use it. > I don't understand why it was undef'ed to begin with. > Probably a copy/paste remnant. There is no reason to keep it. It usually a good idea to undef anything that you no longer need. Otherwise it stays around for some time and might cause some problems in the future. > What things should i change for the re-submit? Don't send the same patch more the 3 times. Alexandre doesn't like it ;-) You should work out all the problems then resubmit. You can send patches to wine-devel for review in the main time. Vitaliy.

1 0

[msi] Is there a potential problem with squash_guid in msi/registry.c ?
by Paul Vriens 29 Jul '07

29 Jul '07

Hi, I'm still looking into the fact why the msi.c tests fails for me (and succeeds when running with WINEDEBUG=+msi). A trace (+msi,+reg,+ole) revealed: trace:msi:MsiQueryProductStateW L"A938G02JF-2NF3N93-VN3-2NNF-3KGKALDNF93" trace:msi:MSIREG_OpenUserProductsKey L"A938G02JF-2NF3N93-VN3-2NNF-3KGKALDNF93" trace:reg:NtOpenKey (0x48,L"A938G02JF-2NF3N93-VN3-2NNF-3KGKALDNF93\\CLSID",f003f,0x34f37c) trace:reg:NtOpenKey <- (nil) warn:ole:CLSIDFromProgID couldn't open key for ProgID L"A938G02JF-2NF3N93-VN3-2NNF-3KGKALDNF93" trace:msi:squash_guid Returning FALSE trace:msi:MSIREG_OpenUserProductsKey squished (L"\7bc9\0480\0011\f8c84\2f47\7bc3\c7ea\7ecd\f9204\7139\7ecf\c89a\7ecd\00ff") (the 'Returning FALSE' is my doing). The squished_pc variable in MSIREG_OpenUserProductsKey is filled with garbage. I think that we should patch msi/registry.c: diff --git a/dlls/msi/registry.c b/dlls/msi/registry.c index b9c0af4..24a3def 100644 --- a/dlls/msi/registry.c +++ b/dlls/msi/registry.c @@ -233,6 +233,8 @@ BOOL squash_guid(LPCWSTR in, LPWSTR out) DWORD i,n=1; GUID guid; + out[0] = 0; + if (FAILED(CLSIDFromString((LPOLESTR)in, &guid))) return FALSE; So 'out' is always clean at the start. Adding this patch makes the test fail consistently :-). So it's not the fix. Any comments/remarks/suggestions ? Cheers, Paul.

1 1

Re: wine3d3: Check the destination recangle when for FastBlt().
by Vitaliy Margolen 29 Jul '07

29 Jul '07

Peter Dons Tychsen wrote: > Hello Wine! > > I have fixed a small bug in FastBlt(), which caused Wine to crash if the > application tried to do FastBlt() to a surface using a bad destination > setup. The problem is already fixed in normal Blt(), but was broken for > FastBlt(). > > This fixes a crash for the little game "Treasure Mole Winter Vacations": > > http://www.alawar.com/games/treasuremolewv/ > > The game is now fully playable. > > /Pedro > > > + if (((lock_dst.bottom > This->currentDesc.Height) || (lock_dst.bottom < 0) || > + (lock_dst.top > This->currentDesc.Height) || (lock_dst.top < 0) || > + (lock_dst.left > This->currentDesc.Width) || (lock_dst.left < 0) || > + (lock_dst.right > This->currentDesc.Width) || (lock_dst.right < 0) || > + (lock_dst.right < lock_dst.left) || (lock_dst.bottom < lock_dst.top))) This check doesn't look right to me. Something like this should be much closer and much easier to read and understand. Also it doesn't have any redundant checks: + if (IsRectEmpty(&lock_dst) || + lock_dst.left >= This->currentDesc.Width || lock_dst.right < 0 || + lock_dst.bottom >= This->currentDesc.Height || lock_dst.top < 0) ">=" because you comparing coordinates against width/height. Vitaliy.

1 0

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice
by Vitaliy Margolen 29 Jul '07

29 Jul '07

Peter Dons Tychsen wrote: > On Sun, 2007-07-29 at 11:15 -0600, Vitaliy Margolen wrote: >> Peter Dons Tychsen wrote: >>> Hello again Wine! >>> >>> Here is a small fix for dinput which fixes application which call >>> CreateDevice with the standard Joystick GUID instead of the GUID >>> supplied in the enumeration callback. >> The patch looks good, and I see what you trying to fix. It would be >> nice if you add some tests for this. MSDN is pretty explicit about >> what GUIDs could be used there. >> >> Few nitpicks about your patch: >> >>> -static BOOL IsJoystickGUID(REFGUID guid) >>> +/****************************************************************************** >>> + * Acquire : gets exclusive control of the joystick >>> + */ >>> +static CHAR IsJoystickGUID(REFGUID guid) >>> { >>> >> Comment are good, but only when they are correct. Also you probably should >> rename this function to something like get_joystick_index. >> >>> + return -1; >>> } >>> >>> static HRESULT joydev_create_deviceA(IDirectInputImpl *dinput, REFGUID rguid, REFIID riid, LPDIRECTINPUTDEVICEA* pdev) >>> { >>> - if ((IsEqualGUID(&GUID_Joystick,rguid)) || >>> - (IsJoystickGUID(rguid))) { >>> + CHAR index; >> Why CHAR? the Data3 defined as "unsigned short Data3;". That is what >> you really should use. BTW be careful with that "return -1;" it won't >> be < 0 for unsigned anymore. >> >>> - GUID wine_joystick = DInput_Wine_Joystick_GUID; >>> - GUID dev_guid = *guid; >>> + GUID wine_joystick = DInput_Wine_Joystick_GUID; >>> + GUID dev_guid = *guid; >> Please do not reformat the code. It should be 4-spaces indentation, not 2. >> >> And while you changing this, don't forget to change joystick_linuxinput.c as well. >> They should be kept in sync. >> >> >> Vitaliy. > > Hi Vitaliy. > > OK, thanks for the input: First of all, please bottom post on this list. We are not business. > > I have re-sent the patch with all your remarks fixed, except for the one > regarding joystick_linuxinput.c, which cannot be done with the current > code as alloc_device() is too different in the two versions for the > patch to work. I have however made sure that the version in > joystick_linuxinput.c does not have this problem. > Why do you think they are so different? Looks almost the same to me. Few more things to fix: > -#undef MAX_JOYSTICKS You removed this, but you haven't added it back. > GetJoystickIndex All the functions around that place named properly. Don't use up-casing names. I suggested using "get_joystick_index" - all lover case, with underscores. > -static HRESULT alloc_device(REFGUID rguid, const void *jvt, IDirectInputImpl *dinput, LPDIRECTINPUTDEVICEA* pdev) > +static HRESULT alloc_device(REFGUID rguid, const void *jvt, IDirectInputImpl *dinput, LPDIRECTINPUTDEVICEA* pdev, unsigned short index) This is a really long line, please make it shorter.

1 0

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice
by Vitaliy Margolen 29 Jul '07

29 Jul '07

Peter Dons Tychsen wrote: > Hello again Wine! > > Here is a small fix for dinput which fixes application which call > CreateDevice with the standard Joystick GUID instead of the GUID > supplied in the enumeration callback. The patch looks good, and I see what you trying to fix. It would be nice if you add some tests for this. MSDN is pretty explicit about what GUIDs could be used there. Few nitpicks about your patch: > -static BOOL IsJoystickGUID(REFGUID guid) > +/****************************************************************************** > + * Acquire : gets exclusive control of the joystick > + */ > +static CHAR IsJoystickGUID(REFGUID guid) > { > Comment are good, but only when they are correct. Also you probably should rename this function to something like get_joystick_index. > + return -1; > } > > static HRESULT joydev_create_deviceA(IDirectInputImpl *dinput, REFGUID rguid, REFIID riid, LPDIRECTINPUTDEVICEA* pdev) > { > - if ((IsEqualGUID(&GUID_Joystick,rguid)) || > - (IsJoystickGUID(rguid))) { > + CHAR index; Why CHAR? the Data3 defined as "unsigned short Data3;". That is what you really should use. BTW be careful with that "return -1;" it won't be < 0 for unsigned anymore. > - GUID wine_joystick = DInput_Wine_Joystick_GUID; > - GUID dev_guid = *guid; > + GUID wine_joystick = DInput_Wine_Joystick_GUID; > + GUID dev_guid = *guid; Please do not reformat the code. It should be 4-spaces indentation, not 2. And while you changing this, don't forget to change joystick_linuxinput.c as well. They should be kept in sync. Vitaliy.

1 0

Usual non microsoft dlls
by "Luis C. Busquets PÃ©rez" 29 Jul '07

29 Jul '07

Hello, There are a number of dlls which are of common us, e.g. mss32.dll or binkw32.dll in the gaming industry. These are usually distributed with the game. Nevertheless, they relay in other dlls of the system, e.g. zlib1.dll goes through msvcrt.dll to perform its activities. Nevertheless, zlib1.dll is part of an open source project and it would not be difficult to adapt the code for fitting in wine as a library asking directly for the operating own system libraries, thus increasing performance. Therefore, I propose to include in the source tree a directory for "commonly used dlls not included in Windows" It could include at least the open source usual dlls e.g. python24.dll hapdbg.dll zlib1.dll or even comon closed dlls (although this would be a harder work and we can work without an implementation for the time being.) such as mss32.dll binkw32.dll Which would boost games such as Civ4 and furthermore it would make it more reliable as these open source libraries do not need to go through the wine implementations of the windows dlls in which they relay. What do you think?

2 1

dinput: Regression since commit 233cd46a22d9c53e8a7a7306a88756cb78ada47a
by Maxime Bellengé 29 Jul '07

29 Jul '07

Hi, For a couple of days now, I have two mouse cursors in the game Ankh, the one from the game and the one from X. I have done a git bisect and found that the following patch is responsible for that. I hope it will help dinput developers and especially Vitaliy. Maxime 233cd46a22d9c53e8a7a7306a88756cb78ada47a is first bad commit commit 233cd46a22d9c53e8a7a7306a88756cb78ada47a Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sun Jul 15 10:38:05 2007 -0600 dinput: Use PostMessage instead of SendMessage. Remove message window. :040000 040000 84294e3b119b459f4f415ebaa9e79a693a106804 73d6ab55abf513c0fa96b685e032e6a02c6ce409 M dlls

2 1

Re: [PATCH] thread safety FIXMEs
by Stefan Dösinger 28 Jul '07

28 Jul '07

Am Samstag, 28. Juli 2007 21:17 schrieb Robert Millan: > Hi, > > After the recent fixes that implement thread safety in D3D (thanks > Stefan!), I think these FIXMEs aren't necessary. Yes, this is correct, the FIXMEs are obsolete.

1 0

Re: [PATCH] x11drv: Allow to disable focus to desktop window after last wine window looses focus.
by Vitaliy Margolen 28 Jul '07

28 Jul '07

Tomas Carnecky wrote: > This patch introduces a new registry key, "FocusDesktopWindow", that can > be used to specify whether wine should set the foreground window to the > desktop window after the last wine app looses focus. The default is > enabled (the same behavior as now). This is a bad hack. The reason I *fixed* the focus lose so Wine can grab pointer inside it's window and release it when the focus is lost. With what you proposing, it will be impossible. Then I'd like to see what would you say when Wine will not be releasing the mouse when you switch away from app? Also I don't know how many apps did you really test, but lots and lots of apps can't get the focus because they think they never lost it. Which IMHO is the reason for most bugs where input goes into terminal not Wine. > For example World of Warcraft stops sound if it finds out it lost focus and > there's currently a bug in wine that makes WoW unaware that it regained focus, > which effectively disables sound. Then you should fix this bug and not create hacks. Vitaliy

2 1

Re: inkobj: Add stub header, implementation, and test for inkobj.dll
by Stefan Dösinger 28 Jul '07

28 Jul '07

Am Freitag, 27. Juli 2007 23:09 schrieb John Klehm: > Hello, > > This patch adds stub files for inkobj.dll. Is this a standard Windows DLL? I cannot find it on my Vista installation.

2 2

Getting CA certificates into the registry
by Juan Lang 28 Jul '07

28 Jul '07

(Apologies if you get this twice - I wasn't subscribed to wine-devel on this account, and apparently it didn't get moderated through.) Folks, I'm hoping for feedback on how to get CA certificates into Wine's registry. We'll need them in order to verify signatures on things. A number of apps depend on this [1]. We have a few choices: 1. Include them in a .inf file and install them with wine. There are two problems with this that I see: Signatures are opaque (asn.1 encoded) and thus hard to verify, and there's a potential maintenance hassle. It's by far the simplest though. 2. We search for certificates installed locally and import them into the registry. The trouble with this is that different distros, and even different versions of the same distro, install them in different locations. There are also usually several potential sources on the same machine, installed by different apps, and it's not clear which certs are meant to be trusted and which are not. (For example, there are several "example" certs installed on my system, and I can identify them as such, but a tool would not be able to tell the difference.) We could write a script that checks in several likely locations, but that seems dangerous: one of those locations might inadvertently be world-writable, so an attacker could possibly put untrustworthy certificates there. 2.a. We write a tool to import local certs, but make you specify the path. Ugly, but punts the problem to the user. 3. We do what the distros do: get the certificates from Mozilla's CVS, and munge them into the right format. (Google for mkcabundle.pl) This is similar to what we do for the unicode tables, but it does introduce a dependency on CVS (or perhaps wget from a web CVS front end.) I suppose I should mention there's another option: 4. We don't load certs in Wine at all, and don't implement certificate chain verification, but dynamically load openssl or gnutls and ask them to do it for us. I don't think this is simpler than the alternatives, as I've already put a fair amount of work into crypt32, but if none of the other options is acceptable I can look into it. I'd very much appreciate feedback on which option seems the best, or, most likely to get committed ;) Thanks, --Juan [1] Here's a partial list - there are more: Bug 5423, AOL AIM won't install, http://bugs.winehq.org/show_bug.cgi?id=5423 Bug 7892, iTunes startup, http://bugs.winehq.org/show_bug.cgi?id=7892 Bug 8870, Outlook can't open signed messages, http://bugs.winehq.org/show_bug.cgi?id=8870

5 7

Re: [PATCH] winecfg: Add trackbar to set screen resolution in graphicstab
by Dmitry Timoshkov 28 Jul '07

28 Jul '07

"Nigel Liang" <ncliang(a)gmail.com> wrote: > diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc > index 5972c3b..9243e3c 100644 > --- a/programs/winecfg/En.rc > +++ b/programs/winecfg/En.rc Please add appropriate changes to other languages .rc files to keep them in sync. I don't think you will like if say I while adding a feature just modify a russian language resource file. -- Dmitry.

2 2

InputHint and WM_TAKE_FOCUS
by Tomas Carnecky 27 Jul '07

27 Jul '07

Commit d836a5062141dd42293ed044debbaf25f914f383 broke sound in World of Warcraft. Yes, it sound strange but after I analyzed the issue it makes perfectly sense: a commit to dlls/winex11.drv/event.c broke sound. According to the wine source and the ICCCM spec, wine uses either the 'Passive' or 'Locally active' input model. InputHint is always set and WM_TAKE_FOCUS only if "UseTakeFocus" is set in the registry. InputHint indicates that the window will have focus set by the WM, and WM_TAKE_FOCUS indicates that the app may set focus to it's own subwindows. Both metacity an compiz _don't_ send WM_TAKE_FOCUS to windows that have InputHint set! The problem that arises from [1] is the following: If the WM calls XSetInputFocus() then the xserver sends a FocusIn event to the wine window, but wine ignores that event and waits for an WM_TAKE_FOCUS message. But that message never arrives because the WM never sends it. The above mentioned commit sets the foreground window to desktop if the WoW window looses focus. This makes WoW stop sound output. But the WoW window never regains focus and WoW won't resume sound output. I assume this bug has been in wine for a long time and even though it's a bug I enjoyed being able to switch away from WoW and still hear the sound (fishing/grinding while reading slashdot, hacking on wine etc). The solution? Remove [1] (to process the FocusIn event) or remove InputHint from WM_HINTS. That would fix around the missing sound. Anyhow, 'sound while WoW lost focus' will be lost forever and I imagine there's no way to make that possible again but using a custom patch. tom [1]: http://source.winehq.org/source/dlls/winex11.drv/event.c#L509

1 1

Re: [1/4] gdi32: limit PS_USERSTYLE style count to 16
by Evan Stade 27 Jul '07

27 Jul '07

On 7/26/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > this patch is needed to prevent wine from crashing on the test that > comprises my next patch > > dlls/gdi32/pen.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > -- > Evan Stade > > Any insight into what is wrong with these patches? -- Evan Stade

1 0

re: winex11: manage one more case
by Dan Kegel 27 Jul '07

27 Jul '07

The discussion in http://bugs.winehq.org/show_bug.cgi?id=3997 and offline makes it seem as if the z-order problem is very hard to get right. Yet there is some urgency to solving this problem for at least the most popular apps that suffer from it. So, perhaps it's time to consider solving it wrong. I wrote: > + /* photoshop cs installer wizard should not hide "please close" dialog */ > + if (style == (WS_CLIPSIBLINGS|WS_POPUP)) return TRUE; Now, I realize this is probably wrong, but it gets both Photoshop CS's installer and Bricscad 8's installer past their z-order problems. What would it break? (If it's not obvious, I'm not very well informed about window styles, window management, and all that.) If the patch I proposed would break too many things, perhaps we should make it conditional on particular executables, with the list of executables configurable via the registry and winecfg, as we do with library overrides. That way the damage would be limited. Thoughts? - Dan

2 1

WGL: pbuffer improvements 3 [take 2]
by Roderick Colenbrander 26 Jul '07

26 Jul '07

The previous version contained a bug in the GLX context creation code of wglShareLists. The error led to a BadMatch in demos which work using upcoming patches. Roderick On Thursday 26 July 2007 20:52, Roderick Colenbrander wrote: > This patch enables the newly added offscreen formats for use with pbuffers. > Note that this function uses a GLX 1.3 function (glXCreateNewContext). This > function is needed to handle fbconfigs without a visual. Such fbconfigs > only exist on GLX 1.3 or higher (without glXCreateNewContext you can't even > use them). > > Roderick Colenbrander

1 0

Re: ntdll: Cast-qual warning fix (Resend)
by Alexandre Julliard 26 Jul '07

26 Jul '07

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > What is wrong with this patch, please? You broke the function completely. Look closer... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: faultrep
by Detlef Riekenberg 26 Jul '07

26 Jul '07

On Do, 2007-07-26 at 02:44 +0200, Peter Dons Tychsen wrote: > I have added a missing DLL to wine. Nice. > I do have a question though: When adding new files, who runs > autoconf and automake, to reflect on the changes in Makefile.in and > configure.ac? You? Do we need to update the Wiki (#8 and the last note)? http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832ba… > dlls/dxguid/Makefile \ > - dlls/gdi32/Makefile \ > + dlls/faultrep/Makefile \ > + dlls/gdi32/Makefile \ Did you mixed space and tab here? This code is autogenerated by tools/make_makefiles, when your Patch is commited by Alexandre. > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > 02110-1301, USA > + */ Please fix the line-wrap (you can attach the Patch) > +#include <wine/debug.h> > + > +WINE_DEFAULT_DEBUG_CHANNEL(faultrep); You should add a "DllMain" here. (with DisableThreedLibraryCalls(), when possible) Thanks for improving wine -- By by ... Detlef

1 0

Re: Ukrainian translation of MSI
by Stefan Dösinger 26 Jul '07

26 Jul '07

Am Donnerstag, 26. Juli 2007 08:13 schrieb Reznikov Artyom: > Hello! I'm translating ReactOS into Ukrainian. I was told in in ROS > bugzilla (http://www.reactos.org/bugzilla/show_bug.cgi?id=2420) that my MSI > translation should be sent to wine. So I'm sending it in this letter. Am I > doing this correctly and in right place? The place is correct, but the format is not. You should send a diff with your modifications against the winehq git HEAD instead of just an .rc file

1 0

Re: [advapi32/service #2] Fix buffersize calculations for GetServiceDisplayNameA
by Alexandre Julliard 26 Jul '07

26 Jul '07

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c > index 1ecaf70..7e4ac8e 100644 > --- a/dlls/advapi32/service.c > +++ b/dlls/advapi32/service.c > @@ -2298,7 +2298,7 @@ BOOL WINAPI GetServiceDisplayNameA( SC_HANDLE hSCManager, LPCSTR lpServiceName, > if (ret == ERROR_MORE_DATA) > { > SetLastError(ERROR_INSUFFICIENT_BUFFER); > - *lpcchBuffer = size - 1; > + *lpcchBuffer = (size - 1) * sizeof(WCHAR); That's not correct, the A function is not supposed to return WCHARs. What probably happens on Windows is that it calls the W function and doubles the size as an upper bound on the buffer size. -- Alexandre Julliard julliard(a)winehq.org

2 7

Re: winex11.drv: WM_SYSCOMMAND/SC_CLOSE should be posted not sent
by Alexandre Julliard 26 Jul '07

26 Jul '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > this patch fixes crash on exit reported in the bug #2918. > > In DefWindowProc we already use PostMessage for WM_SYSCOMMAND/SC_CLOSE > in response to Alt+F4. > > Changelog: > winex11.drv: WM_SYSCOMMAND/SC_CLOSE should be posted not sent. This is what we used to do, but it was changed to a SendMessage in commit 43b5576998aea7accd9f4fb791043d89e9b83cad because some apps depend on that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Ukrainian translation of MSI
by Vitaliy Margolen 26 Jul '07

26 Jul '07

Reznikov Artyom wrote: > Hello! I'm translating ReactOS into Ukrainian. I was told in in ROS bugzilla > (http://www.reactos.org/bugzilla/show_bug.cgi?id=2420) that my MSI translation > should be sent to wine. So I'm sending it in this letter. Am I doing this correctly > and in right place? You are in the right place but you doing it wrong - the patch have to be in the unified diff format. In this case you should do: diff -u /dev/null dlls/msi/msi_Uk.rc > patch.diff Oh and make sure it is in UNIX format not dos. (line brakes are \n not \n\r). Vitaliy

1 0

Re: Michael Stefaniuc : winefile: Replace malloc with HeapAlloc.
by Martin Fuchs 26 Jul '07

26 Jul '07

Hello, may I ask why you are replacing the simple malloc/free calls by the more complicated HeapAlloc API? This just makes the source longer and less readable. There is no point in avoiding C library usage in Winefile. It is just a unix application using Wine libraries - not a Wine system library. Regards, Martin On 24.07.2007 07:06:08 Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 11bb71d3d6a34d301291b2d15c849a1381bd7789 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=11bb71d3d6a34d301291b2d15… > 49a1381bd7789 > Author: Michael Stefaniuc <mstefani(a)redhat.de> > Date: Mon Jul 23 22:25:20 2007 +0200 > winefile: Replace malloc with HeapAlloc. > - Entry* entry = (Entry*) malloc(sizeof(Entry)); > + Entry* entry = HeapAlloc(GetProcessHeap(), 0, sizeof(Entry)); > - free(entry); > + HeapFree(GetProcessHeap(), 0, entry); > } -- Martin Fuchs fuchs.martin(a)gmail.com

2 1

Re: Italian translation for ui_En.rc (more)
by Detlef Riekenberg 25 Jul '07

25 Jul '07

On Mi, 2007-07-25 at 16:55 +0200, Paolo Devoti wrote: > Attached is dlls/localui/ui_It.rc Oh, and it would be nice, when you create a Patch from your changes and please include the missing change in "localui.rc" in the Patchfile. git is prefered, but cvs should also work. Thanks for improving wine. We can help, when needed. -- By by ... Detlef

1 0

Re: Italian translation for ui_En.rc
by Detlef Riekenberg 25 Jul '07

25 Jul '07

On Mi, 2007-07-25 at 16:55 +0200, Paolo Devoti wrote: > /* > * English resources for localui Did you forgot to replace English with Italian? > * > * Copyright 2007 Detlef Riekenberg Your can add your Name here > ADDPORT_DIALOG DIALOG LOADONCALL MOVEABLE DISCARDABLE 6, 18, 245, 47 > DEFPUSHBUTTON "OK", IDOK, 199, 10, 40, 14, WS_VISIBLE > PUSHBUTTON "Annulla", IDCANCEL, 199, 27, 40, 14, WS_VISIBLE > END > > > LPTCONFIG_DIALOG DIALOG LOADONCALL MOVEABLE DISCARDABLE 6, 18, 220, 47 > DEFPUSHBUTTON "OK", IDOK, 164, 10, 50, 14, WS_VISIBLE > PUSHBUTTON "Annulla", IDCANCEL, 164, 27, 50, 14, WS_VISIBLE The buttons have the same Text, but a different Layout. I suggest to adjust a Dialog. I did this already for the German resource, but not for English. Thanks -- By by ... Detlef

1 0

[Fwd: Getting good debugging stack traces from wine apport crash reports]
by Scott Ritchie 25 Jul '07

25 Jul '07

1 0

Should Wine move to LGPL 3?
by Damjan Novak 25 Jul '07

25 Jul '07

Hi! I just stumbled on this list and discussion, and though to just mention a highly speculative, but potentially very rewarding advantage of using LGPLv3 for wine. According to this opinion at groklaw: http://www.groklaw.net/article.php?story=20070709101318827 Microsoft MIGHT end up being effectively forced to distribute GPLv3 code under the deal with Novell, and hence loose any chance to sue about patents any so licenced projects included in SuSE, and I suppose wine is included in that distro. Given the nature of the wine project, Im thinking it could benefit greatly from such potential shelding from Microsofts patent portfolio, if things happen to unfold in this very optimistic scenario.. just a thought...

4 6

Re: Greek resource files for Comctrl, user32 and oleaut32
by Alexander Nicolaysen Sørnes 25 Jul '07

25 Jul '07

Onsdag 25 juli 2007 09:49, skrev Dj Apal [GR]: > Hello. I work on Greek localization for ReactOS and the guys there told me > that I should send you the greek resource files for the modules that they > share with you. SO here there are some first resource files. > If I send something wrong, please let me know. > > TIA You need to send one patch per dll, and only send in patch format. For a new file you can do diff -urp /dev/null {path_to_file} > {patch.diff} Where patch.diff already holds the change to add the Greek .rc file. Alexander N. Sørnes

1 0

Re: Getting CA certificates into the registry
by Juan Lang 25 Jul '07

25 Jul '07

> Isn't that what the distro's add-on value should be? Sorry, I don't understand. You think the distros should put CA certs into Wine's registry? --Juan

1 0

Re: [3/7] WineD3D: Allocate render target management members in Init3D
by Alexandre Julliard 25 Jul '07

25 Jul '07

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > From 05154939b9123ff44c9e3ec0417c31ccba2a8716 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Mon, 16 Jul 2007 19:49:34 +0200 > Subject: [PATCH] WineD3D: Allocate render target management members in Init3D > > GL_LIMITS() is not always available in CreateDevice, thus the alloc code > has to be in Init3D. To avoid memory leaks and keep things consistent > the free calls are moved from Release to Uninit3D. ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so d3d.c && touch d3d.ok wine: Unhandled page fault on read access to 0x00000000 at address 0x61bf2a2c (thread 0019), starting debugger... WineDbg starting on pid 0017 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x61bf2a2c). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:61bf2a2c ESP:0033fa10 EBP:0033fa58 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:61c8c8d8 ECX:001e8678 EDX:61c8d600 ESI:00000000 EDI:001e8678 Stack dump: 0x0033fa10: 001e8678 00000000 00000000 60917764 0x0033fa20: 00000000 00110000 00000002 61c696e1 0x0033fa30: 00001302 00340020 00000000 00000000 0x0033fa40: 00000000 00000000 61bf281b 61c8c8d8 0x0033fa50: 001e86a0 001e8678 0033fa88 61c1cbb0 0x0033fa60: 0015f1a0 001e8678 00340020 61c37ff8 Backtrace: =>1 0x61bf2a2c IWineD3DDeviceImpl_ResourceReleased+0x21c(iface=0x15f1a0, resource=0x1e8678) [/home/julliard/wine/wine/dlls/wined3d/device.c:6456] in wined3d (0x0033fa58) 2 0x61c1cbb0 IWineD3DResourceImpl_CleanUp+0x100(iface=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/wined3d/resource.c:89] in wined3d (0x0033fa88) 3 0x61c4109f IWineD3DSurfaceImpl_Release+0xbf(iface=0x1e8678) [/home/julliard/wine/wine/dlls/wined3d/surface.c:414] in wined3d (0x0033fac8) 4 0x6072e685 IDirectDrawSurfaceImpl_Destroy+0xe5(This=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/ddraw/surface.c:229] in ddraw (0x0033faf8) 5 0x6072e953 IDirectDrawSurfaceImpl_Release+0x133(iface=0x1e8580) [/home/julliard/wine/wine/dlls/ddraw/surface.c:425] in ddraw (0x0033fb48) 6 0x6072e37d IDirectDrawSurfaceImpl_DeleteAttachedSurface+0xfd(iface=0x19f6f0, Flags=0x0, Attach=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/ddraw/surface.c:991] in ddraw (0x0033fb78) 7 0x6072e664 IDirectDrawSurfaceImpl_Destroy+0xc4(This=<register ESI not in topmost frame>) [/home/julliard/wine/wine/dlls/ddraw/surface.c:220] in ddraw (0x0033fba8) 8 0x6072e953 IDirectDrawSurfaceImpl_Release+0x133(iface=0x19f6f0) [/home/julliard/wine/wine/dlls/ddraw/surface.c:425] in ddraw (0x0033fbf8) 9 0x606db585 func_d3d+0x1ab5() [/home/julliard/wine/wine/dlls/ddraw/tests/d3d.c:151] in ddraw_test (0x0033fe58) 10 0x606ed9c8 run_test+0x128(name=0x1103b6) [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:389] in ddraw_test (0x0033fea8) 11 0x606ee05d main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/ddraw/tests/../../../include/wine/test.h:437] in ddraw_test (0x0033fed8) 12 0x606ee12b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in ddraw_test (0x0033ff08) 13 0x6041059e start_process+0xee(arg=0x0) [/home/julliard/wine/wine/dlls/kernel32/process.c:820] in kernel32 (0x0033ffe8) 14 0x60027af7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x61bf2a2c IWineD3DDeviceImpl_ResourceReleased+0x21c [/home/julliard/wine/wine/dlls/wined3d/device.c:6456] in wined3d: cmpl 0x0(%eax,%esi,4),%ecx 6456 if (This->fbo_color_attachments[i] == (IWineD3DSurface *)resource) { -- Alexandre Julliard julliard(a)winehq.org

1 0

Comments on winefontcfg tool?
by Nigel Liang 25 Jul '07

25 Jul '07

Hi, I submitted a font configure tool a few days ago that lets the user configure system and menu fonts more easily. The tool is especially helpful to asian and middle-eastern users where the fonts installed may differ greatly from user to user and where the default font size is way too small for some users. I know that ideally we should let wine figure out all this based on fonts used in X or something, but for now, something like this is useful to prevent users from digging into the registry looking for entries to modify (and potentially breaking something.....). Any comments on this would be greatly appreciated. -Nigel

2 1

Re: [PATCH] monthcal todo_wine now passes
by Alexandre Julliard 25 Jul '07

25 Jul '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > this test succeeds for me. Not for me... -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: cmd:batch: Check for a context is added
by Ann & Jason Edmeades 25 Jul '07

25 Jul '07

>I did a simple test here and it works, although I would like to test 2 >scnarios: >a calls b which runs c >a runs b runs c I test that and found the previous email was very slightly wrong. I've coded and sent my new patch into wine-patches as it corrects an identical trap to what you were seeing plus fixes the a runs b runs c case. Can you please try that and confirm it resolves the problem for you as well. Hope this helps Jason

2 1

gdiplus progress and pptview
by Evan Stade 25 Jul '07

25 Jul '07

Hi, As an update for those who don't use pptview daily (as I do), built-in gdiplus is able to render most presentations that native can render. (By native I mean native gdiplus in wine, not pptview.exe in windows.) In fact, I cannot at the moment find a presentation that native can render but built-in cannot (whereas I can find cases to the contrary, pending today's patches). So it would be helpful if people could start using built-in gdiplus for their favorite gdiplus-dependent programs and reporting bugs. Native gdiplus looks better (and probably always will, since it can do its own rendering, whereas the built-in implementation relies on gdi and the underlying drivers), but built-in should be faster. Also if you are going to try to use pptview in wine with either native or built-in gdiplus, I would start with simple presentations and work up, rather than starting with a 50-page real-world presentation. -- Evan Stade

1 0

Wine and virus security
by Alessandro Pignotti 24 Jul '07

24 Jul '07

Hi everyone, I've seen recently a discussion about securing a host running wine denying write access out of wine home using SElinux. I think that this feature would be easily enough implemented by wine itself, maybe by letting the user set access permission on wine drives "c: d: etc" and enforcing then in CreateFile calls. Are there any other APIs that should be considered apart CreateFile? Greetings, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

2 1

Re: cmd:batch: Check for a context is added
by Ann & Jason Edmeades 24 Jul '07

24 Jul '07

> We need to check context before than refer to context -> skip_rest . But we have just referred to it higher up, and I didn't think it was valid to get into this routine without a context. Whats the problem you are trying to fix? Jason

2 2

Re: kernel32: Additional SetThreadPriorityTest (try 6)
by James Hawkins 24 Jul '07

24 Jul '07

On 7/24/07, Matt Jones <mattj(a)google.com> wrote: > Reformatted tests to address James' email > + SetThreadPriority(curthread,min_priority); + SetLastError(0xdeadbeef); + result = SetThreadPriority(curthread,min_priority-1); Is there a reason you don't check the result from the first call to SetThreadPriority? If the call hypothetically fails (something you have to assume can happen), then the rest of the test is not valid. -- James Hawkins

2 2

Re: kernel32: Additional SetThreadPriorityTest (try 5)
by James Hawkins 24 Jul '07

24 Jul '07

On 7/24/07, Matt Jones <mattj(a)google.com> wrote: > On 7/24/07, Matt Jones <mattj(a)google.com> wrote: > > Correctly checks return code of SetThreadPriority before checking > > error (address comment by Alexandre) > > > + SetThreadPriority(curthread,min_priority); + result = SetThreadPriority(curthread,min_priority-1); + + if (!result) exitCode = GetLastError(); + else exitCode = ERROR_SUCCESS; + + todo_wine { + ok(exitCode == ERROR_INVALID_PARAMETER, You're going about this a weird way, and you're still not testing the value returned. The standard way to test return results and GetLastError value is like so: SetLastError(0xdeadbeef); r = ApiCall(...); ok(r == FALSE/ERROR/blah, "Expected blah, got %d\n", r); ok(GetLastError() == error, "Expected error, got %d\n", GetLastError()); -- James Hawkins

1 0

Re: [PATCH] fixed wrong allocation size
by Marcus Meissner 24 Jul '07

24 Jul '07

On Tue, Jul 24, 2007 at 12:38:10PM -0700, Juan Lang wrote: > Whoops. Thanks Markus. Now why on earth did the tests pass without this? It overwrote unused heap memory until now I guess. Ciao, Marcus

1 0

Fwd: kernel32: Additional SetThreadPriorityTest (Try 4)
by Matt Jones 24 Jul '07

24 Jul '07

Any chance anyone could look over this? ---------- Forwarded message ---------- From: Matt Jones <mattj(a)google.com> Date: Jul 20, 2007 11:32 AM Subject: kernel32: Additional SetThreadPriorityTest (Try 4) To: wine-patches(a)winehq.org Add test for correct error value as per suggestion from Alexandre

2 1

re: Direct3D Game test framework
by Dan Kegel 24 Jul '07

24 Jul '07

Vit Hrachovy wrote: > Stefan Dösinger wrote: > > [Any suggestions for a good app test framework?] > > I'm personally using AutoHotkey(http://www.autohotkey.com) as an > automatic testing framework backend. It's a Windows application, so it > can be run through Wine itself and it's sandboxed from X11. I second Vit's recommendation. We're using Autohotkey scripts in our test framework http://code.google.com/p/yawt/ and I've been meaning to work with Vit to get his scripts incorporated into our framework. (We've been distracted getting the next release of Picasa out, sorry.) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

9 13

Fwd: server: Only commit SetThreadPriority if new priority is correct (try 4)
by Matt Jones 24 Jul '07

24 Jul '07

Any chance anyone could look over this? ---------- Forwarded message ---------- From: Matt Jones <mattj(a)google.com> Date: Jul 20, 2007 11:33 AM Subject: server: Only commit SetThreadPriority if new priority is correct (try 4) To: wine-patches(a)winehq.org Correctly set error value as per comment by Alexandre, also integrate comments from Rob Shearman

1 0

Bug introduced in ws2_32.dll.so in version 0.9.39
by Christian Pradelli 24 Jul '07

24 Jul '07

Hello, I have an application done in delphi that send and receive streams to a TCP server using indy. This applications is working fine since older versions of wine (0.9.5). After version 0.9.39 (up to last 0.9.41) the checksum of the stream is wrong when received in server side. The problem only happens with streams above 64KB (approximately). I debug the application but it's very dificult to detect the problem, the streams are very big to analyze them. If I replace "ws2_32.dll.so" with the one from 0.9.38 the problem is solved. Can I help in any way to solve it? I would like to posit in bugzilla but I think that I don't have sufficient information. Regards Christian c_pradelli(a)yahoo.com

6 7

Something wrong with my patches? [wineconsole & net utility]
by Kirill K. Smirnov 24 Jul '07

24 Jul '07

Please, comment, is there something wrong with these two patches? Did I miss something? http://www.winehq.org/pipermail/wine-patches/2007-July/041317.html [Convert net.exe to unicode Explicitly link against msvcrt] and http://www.winehq.org/pipermail/wine-patches/2007-July/041659.html [programs/wineconsole: Correctly display chars 00..1F and 7F] Thanks in advance, -- Kirill

1 0

Another report of infection. Time to integrate antivirus support?
by Dan Kegel 24 Jul '07

24 Jul '07

Say, whatever happened to that SoC project to integrate antivirus support? Looks like he made quite a bit of progress: http://www.christoph-probst.com/soc2006/wine/ Stories like this http://blahblahblahblag.blogspot.com/2007/07/good-reason-to-have-antivirus-… make me think we really need to get that integrated. - Dan

5 4

Re: Direct3D Game test framework
by martin pilka 23 Jul '07

23 Jul '07

Hello Stefan! > If the pages are important I can go to Vienna and boot the server, but it would be a > 6 hour travel just to press a power button. Not really important, I just wanted to have closer look what values you put into your graphs, however I come with something and then we tweak it together. Martin

2 1

Re: [advapi32/service #2] Forward GetServiceDisplayNameA to GetServiceDisplayNameW
by Paul Vriens 23 Jul '07

23 Jul '07

On 7/22/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > No need to fix 2 functions anymore. > > Changelog > Forward GetServiceDisplayNameA to GetServiceDisplayNameW > > Cheers, > > Paul. > > > Hi, Anything I can do to improve this one? Or should I leave them as separate functions? Cheers, Paul.

2 1

Re: [PATCH] winex11.drv: Initialize OpenGL and the pixelformat list only when the driver is loaded.
by Tomas Carnecky 23 Jul '07

23 Jul '07

Please don't apply, it's wrong. In the case when Wine was compiled with OpenGL support but OpenGL isn't available at runtime these checks are still needed in every function. tom

1 0

re: programs/winefontcfg: Add winefontcfg
by Dan Kegel 22 Jul '07

22 Jul '07

I think those static function prototypes in winefontcfg.h should not be there. .h files are for things shared between files; your prototypes were probably put there to avoid compiler errors. Better to put them in the .c file if they're not used by multiple files.

7 8

wine's argv[0] and current directory
by Damjan Jovanovic 22 Jul '07

22 Jul '07

Hi We have 2 problems in wine: 1. When you run "wine /path/to/app.exe", argv[0] is "/path/to/app.exe" which is definitely wrong. The most serious consequence of this is that apps run through file browser double-clicking can break. 2. Whether you run "wine D:\setup.exe" or "wine /media/cdrom/setup.exe", the current directory is never "D:\" and when you double-click an .exe the current directory is $HOME so it's always wrong. You can't "cd /media/cdrom && wine setup.exe" either because that stops ejecting the CD for multi-CD installs. Can we kill 2 birds with 1 stone here and do something like if (argv[0] is a unix path) { make argv[0] a windows path SetCurrentDirectory(directory of argv[0]); } before starting the app? Since Windows never uses UNIX paths this can't break any Windows app, and it will fix double-click startups and multiple CD installs. Any thoughts? Damjan Jovanovic

4 5

Wine configure 0.9.35
by Павел 22 Jul '07

22 Jul '07

This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by Wine configure 0.9.35, which was generated by GNU Autoconf 2.61. Invocation command line was $ ./configure ## --------- ## ## Platform. ## ## --------- ## hostname = localhost uname -m = i686 uname -r = 2.6.17-5mdvlegacy uname -s = Linux uname -v = #1 SMP Wed Sep 13 14:40:00 EDT 2006 /usr/bin/uname -p = unknown /bin/uname -X = unknown /bin/arch = i686 /usr/bin/arch -k = unknown /usr/convex/getsysinfo = unknown /usr/bin/hostinfo = unknown /bin/machine = unknown /usr/bin/oslevel = unknown /bin/universe = unknown PATH: /sbin PATH: /usr/sbin PATH: /bin PATH: /usr/bin PATH: /usr/X11R6/bin PATH: /usr/local/bin PATH: /usr/local/sbin PATH: /usr/lib/qt3//bin ## ----------- ## ## Core tests. ## ## ----------- ## configure:1888: checking build system type configure:1906: result: i686-pc-linux-gnuoldld configure:1928: checking host system type configure:1943: result: i686-pc-linux-gnuoldld configure:2008: checking whether make sets $(MAKE) configure:2033: result: no configure:2086: checking for gcc configure:2116: result: no configure:2183: checking for cc configure:2230: result: no configure:2286: checking for cl.exe configure:2316: result: no configure:2345: error: no acceptable C compiler found in $PATH See `config.log' for more details. ## ---------------- ## ## Cache variables. ## ## ---------------- ## ac_cv_build=i686-pc-linux-gnuoldld ac_cv_env_CCC_set= ac_cv_env_CCC_value= ac_cv_env_CC_set= ac_cv_env_CC_value= ac_cv_env_CFLAGS_set= ac_cv_env_CFLAGS_value= ac_cv_env_CPPFLAGS_set= ac_cv_env_CPPFLAGS_value= ac_cv_env_CPP_set= ac_cv_env_CPP_value= ac_cv_env_CXXFLAGS_set= ac_cv_env_CXXFLAGS_value= ac_cv_env_CXX_set= ac_cv_env_CXX_value= ac_cv_env_LDFLAGS_set= ac_cv_env_LDFLAGS_value= ac_cv_env_LIBS_set= ac_cv_env_LIBS_value= ac_cv_env_XMKMF_set= ac_cv_env_XMKMF_value= ac_cv_env_build_alias_set= ac_cv_env_build_alias_value= ac_cv_env_host_alias_set= ac_cv_env_host_alias_value= ac_cv_env_target_alias_set= ac_cv_env_target_alias_value= ac_cv_host=i686-pc-linux-gnuoldld ac_cv_prog_make_make_set=no ## ----------------- ## ## Output variables. ## ## ----------------- ## ALSALIBS='' AR='' AS='' AUDIOIOLIBS='' BISON='' BUILTINFLAG='' CARBONLIB='' CC='' CFLAGS='' COREAUDIO='' COREFOUNDATIONLIB='' CPP='' CPPBIN='' CPPFLAGS='' CROSSCC='' CROSSTEST='' CROSSWINDRES='' CRTLIBS='' CXX='' CXXFLAGS='' DEFS='' DEPENDENCIES='' DISKARBITRATIONLIB='' DLLEXT='' DLLFLAGS='' DLLTOOL='' DLLWRAP='' ECHO_C='' ECHO_N='-n' ECHO_T='' EGREP='' ESDCONFIG='' ESDINCL='' ESDLIBS='' EXEEXT='' EXTRACFLAGS='' EXTRA_BINARIES='' FLEX='' FONTFORGE='' FONTSSUBDIRS='' FREETYPEINCL='' FREETYPELIBS='' GLU32FILES='' GPHOTO2INCL='' GPHOTO2LIBS='' GREP='' HALINCL='' ICULIBS='' IMPLIBEXT='' INSTALL_DATA='' INSTALL_PROGRAM='' INSTALL_SCRIPT='' IOKITLIB='' LCMSLIBS='' LD='' LDAPLIBS='' LDCONFIG='' LDD='' LDDLLFLAGS='' LDEXECFLAGS='' LDFLAGS='' LDPATH='' LDSHARED='' LIBDL='' LIBEXT='' LIBOBJS='' LIBPOLL='' LIBPTHREAD='' LIBS='' LIBWINE_LDFLAGS='' LINT='' LINTFLAGS='' LN='' LN_S='' LTLIBOBJS='' MAIN_BINARY='' MINGWAR='' NASLIBS='' OBJEXT='' OPENGLFILES='' OPENGL_LIBS='' PACKAGE_BUGREPORT='wine-devel(a)winehq.org' PACKAGE_NAME='Wine' PACKAGE_STRING='Wine 0.9.35' PACKAGE_TARNAME='wine' PACKAGE_VERSION='0.9.35' PATH_SEPARATOR=':' PKG_CONFIG='' PRELINK='' QUARTZFILES='' RANLIB='' RESOLVLIBS='' SANEINCL='' SET_MAKE='MAKE=make' SHELL='/bin/sh' SOCKETLIBS='' STRIP='' TOOLSDIR='' WIN16_FILES='$(WIN16_FILES)' WIN16_INSTALL='$(WIN16_INSTALL)' WINDRES='' XFILES='' XLIB='' XMKMF='' XML2INCL='' XML2LIBS='' XSLTINCL='' XSLTLIBS='' X_CFLAGS='' X_EXTRA_LIBS='' X_LIBS='' X_PRE_LIBS='' ac_ct_AS='' ac_ct_CC='' ac_ct_CXX='' bindir='${exec_prefix}/bin' build='i686-pc-linux-gnuoldld' build_alias='' build_cpu='i686' build_os='linux-gnuoldld' build_vendor='pc' datadir='${datarootdir}' datarootdir='${prefix}/share' docdir='${datarootdir}/doc/${PACKAGE_TARNAME}' dvidir='${docdir}' exec_prefix='NONE' ft_devel2='' ft_devel='' gphoto2_devel='' gphoto2port_devel='' host='i686-pc-linux-gnuoldld' host_alias='' host_cpu='i686' host_os='linux-gnuoldld' host_vendor='pc' htmldir='${docdir}' includedir='${prefix}/include' infodir='${datarootdir}/info' libdir='${exec_prefix}/lib' libexecdir='${exec_prefix}/libexec' localedir='${datarootdir}/locale' localstatedir='${prefix}/var' mandir='${datarootdir}/man' oldincludedir='/usr/include' pdfdir='${docdir}' prefix='NONE' program_transform_name='s,x,x,' psdir='${docdir}' sane_devel='' sbindir='${exec_prefix}/sbin' sharedstatedir='${prefix}/com' sysconfdir='${prefix}/etc' target_alias='' ## ------------------- ## ## File substitutions. ## ## ------------------- ## MAKE_DLL_RULES='' MAKE_IMPLIB_RULES='' MAKE_PROG_RULES='' MAKE_RULES='' MAKE_TEST_RULES='' ## ----------- ## ## confdefs.h. ## ## ----------- ## #define PACKAGE_NAME "Wine" #define PACKAGE_TARNAME "wine" #define PACKAGE_VERSION "0.9.35" #define PACKAGE_STRING "Wine 0.9.35" #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" configure: exit 1

1 0

Re: [Resubmit]: Added wrapper dll for ct-api(CardTerminal API)
by Alexandre Julliard 22 Jul '07

22 Jul '07

"Christian Eggers" <ceggers(a)gmx.de> writes: > +#ifndef SONAMES_LIBCTAPI > +#define SONAMES_LIBCTAPI "libctapi.so","libctapi-cyberjack.so.1","libct.so","libctdeuti.so.5" > +#endif There should be a registry key to specify the library to load instead of a hardcoded list. If the key is not set you probably want to fallback to just libctapi.so. Also the dll should fail to load if the library cannot be loaded. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: fix SetWindowPos to erase parent when child is hidden
by Clinton Stimpson 22 Jul '07

22 Jul '07

Can someone help me with why this patch isn't correct enough? Thanks, Clinton Clinton Stimpson wrote: > When hiding windows, WM_ERASEBKGND is supposed to be sent to the parent. > The message will now be sent with this patch. An existing test was > modified to also check for all parent messages. > Partial fix for bug #6006 > > Thanks, > Clinton Stimpson > > ChangeLog: > user32: send erase to parent when hiding children > > > > ------------------------------------------------------------------------ > > Index: dlls/user32/winpos.c > =================================================================== > RCS file: /home/wine/wine/dlls/user32/winpos.c,v > retrieving revision 1.5 > diff -u -r1.5 winpos.c > --- dlls/user32/winpos.c 26 Apr 2007 15:25:46 -0000 1.5 > +++ dlls/user32/winpos.c 23 Jun 2007 22:24:43 -0000 > @@ -1566,6 +1566,7 @@ > { > RECT newWindowRect, newClientRect, valid_rects[2]; > UINT orig_flags; > + HWND parent = GetAncestor( winpos->hwnd, GA_PARENT ); > > orig_flags = winpos->flags; > > @@ -1592,7 +1593,7 @@ > > if((winpos->flags & (SWP_NOZORDER | SWP_HIDEWINDOW | SWP_SHOWWINDOW)) != SWP_NOZORDER) > { > - if (GetAncestor( winpos->hwnd, GA_PARENT ) == GetDesktopWindow()) > + if (parent == GetDesktopWindow()) > winpos->hwndInsertAfter = SWP_DoOwnedPopups( winpos->hwnd, winpos->hwndInsertAfter ); > } > > @@ -1613,6 +1614,14 @@ > RedrawWindow( winpos->hwnd, NULL, NULL, rdw_flags ); > } > > + /* erase the parent for child windows that are being hidden */ > + if(parent && (orig_flags & SWP_HIDEWINDOW)) > + { > + UINT rdw_flags = RDW_ERASE | RDW_INVALIDATE; > + if ( !(orig_flags & SWP_DEFERERASE) ) rdw_flags |= RDW_ERASENOW; > + RedrawWindow( parent, &newClientRect, NULL, rdw_flags ); > + } > + > if( winpos->flags & SWP_HIDEWINDOW ) > HideCaret(winpos->hwnd); > else if (winpos->flags & SWP_SHOWWINDOW) > Index: dlls/user32/tests/msg.c > =================================================================== > RCS file: /home/wine/wine/dlls/user32/tests/msg.c,v > retrieving revision 1.33 > diff -u -r1.33 msg.c > --- dlls/user32/tests/msg.c 21 Jun 2007 14:49:29 -0000 1.33 > +++ dlls/user32/tests/msg.c 23 Jun 2007 22:24:43 -0000 > @@ -727,6 +727,15 @@ > { WM_WINDOWPOSCHANGED, sent|wparam, SWP_HIDEWINDOW|SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, > { 0 } > }; > +/* ShowWindow(SW_HIDE) for a visible child window checking all parent events*/ > +static const struct message WmHideChildSeq2[] = { > + { WM_SHOWWINDOW, sent|wparam, 0 }, > + { WM_WINDOWPOSCHANGING, sent|wparam, SWP_HIDEWINDOW|SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE }, > + { EVENT_OBJECT_HIDE, winevent_hook|wparam|lparam, 0, 0 }, > + { WM_ERASEBKGND, sent|parent }, > + { WM_WINDOWPOSCHANGED, sent|wparam, SWP_HIDEWINDOW|SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE|SWP_NOCLIENTSIZE|SWP_NOCLIENTMOVE }, > + { 0 } > +}; > /* SetWindowPos(SWP_SHOWWINDOW|SWP_NOSIZE|SWP_NOMOVE) > * for a not visible child window > */ > @@ -3982,8 +3991,10 @@ > ShowWindow(hchild, SW_SHOW); > ok_sequence(WmShowChildSeq, "ShowWindow(SW_SHOW):child", FALSE); > > + log_all_parent_messages++; > ShowWindow(hchild, SW_HIDE); > - ok_sequence(WmHideChildSeq, "ShowWindow(SW_HIDE):child", FALSE); > + ok_sequence(WmHideChildSeq2, "ShowWindow(SW_HIDE):child", FALSE); > + log_all_parent_messages--; > > ShowWindow(hchild, SW_SHOW); > ok_sequence(WmShowChildSeq, "ShowWindow(SW_SHOW):child", FALSE); > > > ------------------------------------------------------------------------ > >

2 2

Compile issue with current git under Fedora7
by Arthur Coombes 21 Jul '07

21 Jul '07

When building from git on a fully patched Fedora 7 install my compile stops building opengl32.dll.so complaining of lots of undefined reference's to glu strings. Adding -lglu32 to the compile command manually allows the file to compile and I can complete the install. It then seems to work fine (I only really run Steam/CS:S regularly). I'm not too good with code but I'd guess a configure issue. I've included files you might find relevant Arthur Coombes "Theology is never any help; it is searching in a dark cellar at midnight for a black cat that isn't there." Robert A. Heinlein.

1 0

gdiplus not available on w2k and below?
by Paul Vriens 20 Jul '07

20 Jul '07

Hi, While going through the test results there are failures for gdiplus for win98, NT and W2K as gdiplus is not available (by default) on these platforms. Should the test be re-written (LoadLibrary and friends)? Cheers, Paul.

1 0

Re: gdi32: set wide non-extended pens to solid if bad type [try3]
by Alexandre Julliard 20 Jul '07

20 Jul '07

"Evan Stade" <estade(a)gmail.com> writes: > [try3] >1 instead of >=1 > > dlls/gdi32/pen.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) You need to add test cases for that one (and it also needs to pass the existing tests...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server: Only commit SetThreadPriority if new priority is correct (try 3)
by Alexandre Julliard 20 Jul '07

20 Jul '07

"Matt Jones" <mattj(a)google.com> writes: > Change SetThreadPriority to correctly handle invalid priority values > From 40bcdbe07d2f5cc0e5de33512858625f940b9c8c Mon Sep 17 00:00:00 2001 > From: Matt Jones <mattj(a)google.com> > Date: Tue, 17 Jul 2007 14:58:01 -0700 > Subject: [PATCH] server: Conform to SetThreadPriority check (only set priority if the new priority is valid), try 2 You most likely need to return an error for invalid values, and in any case you have to check that in your test case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comcat: Cast-qual warning fix (Resend)
by Alexandre Julliard 20 Jul '07

20 Jul '07

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > What is wrong with this patch, please? The proper fix is the make the categories field non const. -- Alexandre Julliard julliard(a)winehq.org

1 0

X11 Xrender and GL extensions on Mac OS
by Ryan Walklin 19 Jul '07

19 Jul '07

Hi, I'm trying to build Wine 0.9.41 (although I'm having the same problem with earlier versions) on Mac OS 10.4.10 Intel, and striking a strange problem. Whenever I try to run Steam using wine, I get the console error "Unable to Alpha Blend without Xrender". Trying to run a GL game crashes with an Apple-DRI 129 error. I've looked back on my configure runs and the build system is able to pickup my X11 install, the Xrender extension, and the GL extensions. I've also tried using the XDarwin X11R7.2 builds, and the same thing happens. I wasn't sure whether to post this to -devel or -users, as it might be my own problem rather than with Wine not finding these libraries. Google hasn't been helpful either. I have all the relevant dependencies (X11, fontforge, freetype, pkg-config etc) installed via MacPorts. Hopefully someone can shed some light on this or post a fix. Regards, Ryan

1 0

Re: server: Only commit SetThreadPriority if new priority is correct (try 2)
by Robert Shearman 19 Jul '07

19 Jul '07

Matt Jones wrote: > + if ((req->priority >= min || > + req->priority == THREAD_PRIORITY_IDLE) || > + (req->priority <= max || > + req->priority == THREAD_PRIORITY_TIME_CRITICAL)) > + thread->priority = req->priority; > + } > This doesn't look correct. There should be an && in there instead of one of the || operators. -- Rob Shearman

2 1

Re: server: Only commit SetThreadPriority if new priority is correct (try 2)
by Matt Jones 19 Jul '07

19 Jul '07

Could someone please review this? Thank you, Matt On 7/17/07, Matt Jones <mattj(a)google.com> wrote: > Fixes compliance with the test I just sent in. > > Try 2 adds constants for realtime min/max priorities & deletes > todo_wine from the fixed tests > >

1 0

Re: kernel32: Additional SetThreadPriorityTest
by Matt Jones 19 Jul '07

19 Jul '07

Could someone please review this? Thank you, Matt On 7/17/07, Matt Jones <mattj(a)google.com> wrote: > SetThreadPriority should maintain the current thread priority if an > invalid thread priority number is passed in. > > Now uses todo_wine flag > >

1 0

Re: [1/6] WineD3D: Create the stateblock in Init3D
by Alexandre Julliard 19 Jul '07

19 Jul '07

Stefan Dösinger <stefan(a)codeweavers.com> writes: > These patches get ddraw without opengl working again. In the last versions > this has failed because wined3d tries to find the gl caps when the first > wined3d object is created and refuses to work if this fails. This patchset > makes ddraw working again on a VNC X server. ../../../tools/runtest -q -P wine -M d3d8.dll -T ../../.. -p d3d8_test.exe.so device.c && touch device.ok wine: Unhandled page fault on execute access to 0x00000000 at address (nil) (thread 000b), starting debugger... WineDbg starting on pid 000a Unhandled exception: page fault on execute access to 0x00000000 in 32-bit code (0x00000000). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:00000000 ESP:0033fa8c EBP:0033fac8 EFLAGS:00010246( - 00 -RIZP1) EAX:001a1ac0 EBX:61a5c8f8 ECX:00161460 EDX:001cbae8 ESI:00000001 EDI:61a5d398 Stack dump: 0x0033fa8c: 619cf859 001a1ac0 00000000 001df6d8 0x0033fa9c: 616f59a8 00001302 0021d498 00000000 0x0033faac: 602cbc71 001a1998 61a43621 0000002b 0x0033fabc: 61706640 00000000 001611e8 0033faf8 0x0033facc: 616f5a4e 00161460 616f7e30 616f7f80 0x0033fadc: 606164bc 606171ff 0000005c 00000000 Backtrace: =>1 0x00000000 (0x0033fac8) 2 0x616f5a4e IDirect3DDevice8Impl_Release+0xbe(iface=<register EDI not in topmost frame>) [/home/julliard/wine/wine/dlls/d3d8/device.c:111] in d3d8 (0x0033faf8) 3 0x6060b3b1 test_swapchain+0xa31() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:267] in d3d8_test (0x0033fbc8) 4 0x6060d518 func_device+0x3a8() [/home/julliard/wine/wine/dlls/d3d8/tests/device.c:310] in d3d8_test (0x0033fe58) 5 0x60616238 run_test+0x128(name=0x110395) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:389] in d3d8_test (0x0033fea8) 6 0x606168cd main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/d3d8/tests/../../../include/wine/test.h:437] in d3d8_test (0x0033fed8) 7 0x60616fab __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0033ff08) 8 0x604087de start_process+0xee(arg=0x0) [/home/julliard/wine/wine/dlls/kernel32/process.c:820] in kernel32 (0x0033ffe8) 9 0x60027af7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x00000000: addb %al,0x0(%eax) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: tooltips: avoid buffer overrun (spotted by hto@mail.cnt.ru, bug #8361), make sure some strings are NUL-terminated
by Alexandre Julliard 19 Jul '07

19 Jul '07

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > @@ -389,10 +390,10 @@ static void TOOLTIPS_GetDispInfoW(HWND hwnd, TOOLTIPS_INFO *infoPtr, TTTOOL_INFO > sizeof(ttnmdi.szText)/sizeof(ttnmdi.szText[0]) : INFOTIPSIZE-1; > lstrcpynW(infoPtr->szTipText, ttnmdi.lpszText, max_len); > if (ttnmdi.uFlags & TTF_DI_SETITEM) { > - INT len = max(strlenW(ttnmdi.lpszText), max_len); > + INT len = min(strlenW(ttnmdi.lpszText), max_len); It the text is really allowed to not be null-terminated then calling strlenW on it is wrong in any case. It does seem surprising though, are you sure we really need to support this? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/10] gdiplus: added GdipScaleMatrix [try2]
by Alexandre Julliard 19 Jul '07

19 Jul '07

"Evan Stade" <estade(a)gmail.com> writes: > +GpStatus WINGDIPAPI GdipScaleMatrix(GpMatrix *matrix, REAL scaleX, REAL scaleY, > + GpMatrixOrder order) > +{ > + REAL scale[6]; > + > + if(!matrix) > + return InvalidParameter; > + > + memset(scale, 0, 6 * sizeof(REAL)); Using memset for floats is not a good idea, you should use explicit initialization. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [4/6] WineD3D: Attempt to clean up fbos only if a gl surface is destroyed
by H. Verbeet 19 Jul '07

19 Jul '07

On 18/07/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This code does not really have a home. For one part the device is in > charge of managing the gl fbos, on the other hand this is gl surface > specific code and should go into IWineD3DSurface::Release. No, the surface release code shouldn't know about render targets, FBOs, etc. (It's not really surface specific either, other than that the pointers we're cleaning up happen to be surfaces.) The device gets notified when resources of a certain type are destroyed here, so it can do extra cleanup on it's internal structures, so this is the correct place to do this kind of stuff.

2 3

peek_message reading bogus data from wineserver
by Phil Lodwick 18 Jul '07

18 Jul '07

Greetings! I have been chasing down a bug and was hoping to get a few suggestions as to what to look at next. In an application's main message loop it calls GetMessage. Occasionally this call would hit an assert within Wine code. Tracking this down I have found a problem in the call to the wineserver in the peek_message routine in user/message.c. This routine will make a "get_message" wine server request, successfully read 64 bytes of data, but the data in the buffer is bogus. I can put debug in server/request.c/send_reply and see that the data being written by the server is correct. Similar debug in dlls/ntdll/server.c/read_reply_data shows that the data being read is wrong. I am pretty sure this is a timing related problem. Has anybody seen something similar or have any suggestions on what more to look at? Thanks, Phil

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel