- wine-devel - winehq.org

Re: winealsa.drv: Fix missing unlock on the error path. Found by Smatch.
by Maarten Lankhorst 22 Jun '07

22 Jun '07

That fix is correct, This->pcm is only ever changed inside the critical section Thanks, Maarten 2007/6/22, Michael Stefaniuc <mstefani(a)redhat.de>: > Maarten, > > is this the right fix or can the lock be moved below the > if (!This->pcm) > check? > > bye > michael > --- > dlls/winealsa.drv/dsoutput.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/winealsa.drv/dsoutput.c b/dlls/winealsa.drv/dsoutput.c > index 57b8968..9fc5020 100644 > --- a/dlls/winealsa.drv/dsoutput.c > +++ b/dlls/winealsa.drv/dsoutput.c > @@ -459,6 +459,7 @@ static HRESULT WINAPI IDsDriverBufferImpl_GetPosition(PIDSDRIVERBUFFER iface, > if (!This->pcm) > { > FIXME("Bad pointer for pcm: %p\n", This->pcm); > + LeaveCriticalSection(&This->pcm_crst); > return DSERR_GENERIC; > } > > -- > 1.5.0.6 >

1 0

Failing assertion in dsound test, please confirm
by Alex Villacís Lasso 22 Jun '07

22 Jun '07

I am experiencing a failing assertion in a dsound test. Could you please confirm if it is just me (and then it would be a configuration issue), or if anybody else is experiencing failing assertions: [alex@srv64 tests]$ WINETEST_INTERACTIVE=1 wine dsound_test.exe.so dsound ALSA lib conf.c:3939:(snd_config_expand) Unknown parameters 0 ALSA lib control.c:910:(snd_ctl_open_noupdate) Invalid CTL default:0 fixme:wave:ALSA_AddCaptureDevice Add support for DSCapture dsound.c:973:DLL Version: 5.3.1.904 dsound.c:180:Testing IDirectSound fixme:dsalsa:SetFormat Your alsa dmix period size is excessively high, unfortunately this is alsa default, try decreasing it to 512 or 256 (but double the amount of periods) if possible fixme:ole:CoCreateInstance no instance created for interface {11ab3ec0-25ec-11d1-a4d8-00c04fc28aca} of class {47d4d946-62e8-11cf-93bc-444553540000}, hres is 0x80004002 err:ole:CoGetClassObject class {11ab3ec0-25ec-11d1-a4d8-00c04fc28aca} not registered err:ole:CoGetClassObject no class object {11ab3ec0-25ec-11d1-a4d8-00c04fc28aca} could be created for context 0x1 dsound.c:938:*** Testing Primary Sound Driver - winealsa.drv *** dsound.c:475:Playing a 5 seconds reference tone at the current volume. dsound.c:478:(the current volume is -4651 according to DirectSound) dsound.c:480:All subsequent tones should be identical to this one. dsound.c:481:Listen for stutter, changes in pitch, volume, etc. ds3d.c:400:Requested format tag=0x0001 11025x16x2 avg.B/s=44100 align=4 ds3d.c:403:Got tag=0x0001 48000x16x2 avg.B/s=192000 align=4 ds3d.c:453: Playing 5 second 440Hz tone at 48000x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x8x1 avg.B/s=8000 align=1 dsound.c:586:Got tag=0x0001 48000x8x1 avg.B/s=48000 align=1 dsound.c:607: Testing a primary buffer at 48000x8x1 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x8x2 avg.B/s=16000 align=2 dsound.c:586:Got tag=0x0001 48000x8x2 avg.B/s=96000 align=2 dsound.c:607: Testing a primary buffer at 48000x8x2 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x16x1 avg.B/s=16000 align=2 dsound.c:586:Got tag=0x0001 48000x16x1 avg.B/s=96000 align=2 dsound.c:607: Testing a primary buffer at 48000x16x1 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x16x2 avg.B/s=32000 align=4 dsound.c:586:Got tag=0x0001 48000x16x2 avg.B/s=192000 align=4 dsound.c:607: Testing a primary buffer at 48000x16x2 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 mixer.c:823: DSOUND_PerformMix: La declaración `device->playpos < device->buflen' no se cumple. wine: Assertion failed at address 0x600007f2 (thread 000f), starting debugger... dsound.c:582:Requested primary format tag=0x0001 11025x8x1 avg.B/s=11025 align=1 dsound.c:586:Got tag=0x0001 48000x8x1 avg.B/s=48000 align=1 dsound.c:607: Testing a primary buffer at 48000x8x1 with a secondary buffer at 11025x16x2 Unhandled exception: assertion failed in 32-bit code (0x600007f2). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:600007f2 ESP:7ed516cc EBP:7ed516d8 EFLAGS:00000202( - 00 - - I1) EAX:00000000 EBX:00002cd3 ECX:00002cd5 EDX:00000006 ESI:7ed51778 EDI:60298ff4 Stack dump: 0x7ed516cc: 60171fa0 60298ff4 7ed52b90 7ed51804 0x7ed516dc: 601738b1 00000006 7ed51778 00000000 0x7ed516ec: 00000068 7cae1278 00000000 00000000 0x7ed516fc: 601ae37d 7ed5173c 7cae1278 7cae12dc 0x7ed5170c: 7ed51814 60298ff4 00000062 7cae1278 0x7ed5171c: 7ed517e8 601a7d3b 7cae1278 00000062 Backtrace: =>1 0x600007f2 (0x7ed516d8) 2 0x601738b1 (0x7ed51804) 3 0x6016b3ce (0x7ed51848) 4 0x608bdfe8 DSOUND_timer+0x2108(timerID=0x1, msg=0x0, dwUser=0x167688, dw1=0x0, dw2=0x0) [/home/alex/install/wine-0.9.39-build/dlls/dsound/mixer.c:554] in dsound (0x7ed519b8) 5 0x60910b96 TIME_MMSysTimeThread+0x2e6(arg=0x0) [/home/alex/install/wine-0.9.39-build/dlls/winmm/time.c:181] in winmm (0x7ed51a18) 6 0x7bc5d19e call_thread_entry_point+0xe() in ntdll (0x7ed51a28) 7 0x7bc5de72 call_thread_func+0x42(rtl_func=<register EDI not in topmost frame>, arg=<register ESI not in topmost frame>) [/home/alex/install/wine-0.9.39-build/dlls/ntdll/thread.c:404] in ntdll (0x7ed51ac8) 8 0x7bc5e10f in ntdll (+0x4e10f) (0x7ed523c8) 9 0x601362fb (0x7ed524b8) 10 0x6021993e (0x00000000) 0x600007f2: ret Modules: Module Address Debug info Name (66 modules) ELF 24d000- 2bd000 Deferred libgl.so.1 ELF 24d000- 2bd000 Deferred libgl.so.1 ELF 43e000- 45b000 Deferred ld-linux.so.2 ELF 45d000- 5b1000 Deferred libc.so.6 ELF 5b3000- 5dc000 Deferred libm.so.6 ELF 5de000- 5e3000 Deferred libdl.so.2 ELF 5fa000- 612000 Deferred libpthread.so.0 ELF 614000- 619000 Deferred libxxf86vm.so.1 ELF 640000- 645000 Deferred libxfixes.so.3 ELF 6b5000- 6bb000 Deferred libxdmcp.so.6 ELF 6bd000- 7bf000 Deferred libx11.so.6 ELF 802000- 805000 Deferred libxau.so.6 ELF 80c000- 81c000 Deferred libxext.so.6 ELF 8aa000- 8cb000 Deferred libexpat.so.0 ELF 926000- 92f000 Deferred libxrender.so.1 ELF a84000- a8e000 Deferred libxcursor.so.1 ELF a98000- b22000 Deferred libfreetype.so.6 ELF b24000- b53000 Deferred libfontconfig.so.1 ELF bbb000- bc6000 Deferred libdrm.so.2 ELF cef000- cf6000 Deferred libxrandr.so.2 ELF dfa000- dfd000 Deferred libxinerama.so.1 ELF 5cf0000- 5dce000 Deferred libasound.so.2 ELF 65f6000- 65ff000 Deferred libsm.so.6 ELF 6601000- 661b000 Deferred libice.so.6 ELF 6001d000-60131000 Deferred libwine.so.1 ELF 602cb000-6032b000 Deferred dsound_test<elf> \-PE 602e0000-6032b000 \ dsound_test ELF 6032b000-60371000 Deferred advapi32<elf> \-PE 60340000-60371000 \ advapi32 ELF 60371000-604ab000 Deferred user32<elf> \-PE 60390000-604ab000 \ user32 ELF 604ab000-60541000 Deferred gdi32<elf> \-PE 604c0000-60541000 \ gdi32 ELF 60541000-60597000 Deferred rpcrt4<elf> \-PE 60550000-60597000 \ rpcrt4 ELF 60597000-605b5000 Deferred iphlpapi<elf> \-PE 605a0000-605b5000 \ iphlpapi ELF 605c9000-605e2000 Deferred version<elf> \-PE 605d0000-605e2000 \ version ELF 60892000-608db000 Dwarf dsound<elf> \-PE 608a0000-608db000 \ dsound ELF 608db000-60968000 Dwarf winmm<elf> \-PE 608f0000-60968000 \ winmm ELF 60a46000-60a5e000 Deferred msacm32<elf> \-PE 60a50000-60a5e000 \ msacm32 ELF 60a5e000-60a84000 Deferred msacm32<elf> \-PE 60a70000-60a84000 \ msacm32 ELF 61d5f000-61d74000 Deferred midimap<elf> \-PE 61d70000-61d74000 \ midimap ELF 6a741000-6a74d000 Deferred libnss_files.so.2 ELF 6d8a4000-6d8d6000 Deferred winealsa<elf> \-PE 6d8b0000-6d8d6000 \ winealsa ELF 7525e000-752ec000 Deferred winex11<elf> \-PE 75270000-752ec000 \ winex11 ELF 757d6000-757ea000 Deferred lz32<elf> \-PE 757e0000-757ea000 \ lz32 ELF 77861000-7787e000 Deferred imm32<elf> \-PE 77870000-7787e000 \ imm32 ELF 79cd4000-79cd7000 Deferred iso8859-1.so ELF 79d6e000-79e0b000 Deferred ole32<elf> \-PE 79d80000-79e0b000 \ ole32 ELF 7b800000-7b924000 Deferred kernel32<elf> \-PE 7b820000-7b924000 \ kernel32 ELF 7bc00000-7bc96000 Dwarf ntdll<elf> \-PE 7bc10000-7bc96000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000010 00000012 0 00000011 0 0000000d (D) Z:\home\alex\install\wine-0.9.39-build\dlls\dsound\tests\dsound_test.exe 0000000f 15 <== 0000000e 0 -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: How to make your machine crash when running Wine
by gslink 22 Jun '07

22 Jun '07

Most of the people here are probably smarter than to fall into this trap but I recently had several customers who did. Most of the time openGL just refuses to run but a couple of months ago RH did put out an update to some of the X code that did cause the machine to crash with Wine if you didn't replace the Nvidia driver. The customers were running some things under Wine that used hardware acceleration. If they had used hardware acceleration outside of Wine the machine would have crashed too. This is not a Wine problem but it is likely to be a source of regular complaints.

1 0

Re: dpnhpast: Add stub for DirectPlayNATHelpCreate
by Detlef Riekenberg 22 Jun '07

22 Jun '07

On Fr, 2007-06-22 at 04:39 +0200, Alexander Nicolaysen Sørnes wrote: > +HRESULT WINAPI DirectPlayNATHelpCreate(const LPGUID pIId, void ** > ppvInterface) > { > - /* @stub in .spec */ > + FIXME("stub"); > + return E_FAIL; > } > -#endif The FIXME is missing the newline and it would be useful to dump the Parameters in the FIXME. -- By by ... Detlef

1 0

Re: [3/7] gdiplus: GdipReAlloc
by Alexandre Julliard 22 Jun '07

22 Jun '07

"Evan Stade" <estade(a)gmail.com> writes: > This is only declared privately because it is not a function provided > by the dll. It follows the exported-function naming scheme however, > because it's a counterpart to GdipFree and GdipAlloc. Please don't do that, it's confusing. If there's no GdipReAlloc just use HeapReAlloc directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: [1/2] oleaut32: add PNG loading [try2]
by Dan Kegel 22 Jun '07

22 Jun '07

Alexandre wrote: >> How can I improve this patch such that it will be accepted? > >The biggest problem is that the libpng versioning scheme is broken, so >we can't find the proper soname. This will need some more configure >magic. Looking at http://www.libpng.org/pub/png/libpng.html and http://www.linux-foundation.org/en/LibPng and /usr/include/png.h I get the impression that the libpng versioning scheme was cleaned up for the 1.2 series over four years ago. So perhaps we could just change configure.ac to check PNG_LIBPNG_VER_MAJOR and make sure it's exactly 1, and check PNG_LIBPNG_VER_MINOR and make sure it's 2 or greater. That would let us avoid the old broken libpng's, wouldn't it? - Dan

2 1

Re: [PATCH try2 4/4] gdi32: Call pMoveTo if available when emulating ArcTo/PolylineTo/PolyBezierTo.
by Alexandre Julliard 22 Jun '07

22 Jun '07

Misha Koshelev <mk144210(a)bcm.edu> writes: > This sends proper position information to the GDI driver when we are emulating these functions. I don't think I agree with this one. If the driver needs to update the position then it should implement ArcTo etc. since it may need to distinguish that from an explicit MoveTo. Or if the generic implementation is really good enough in all cases then we shouldn't export a driver entry point at all. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: PATCH - implement LockWorkStation using xdg-screensaver on Linux
by Hans Leidekker 21 Jun '07

21 Jun '07

On Tuesday 19 June 2007 20:08:50 Steven Edwards wrote: > Patch by Hans Leidekker It's your idea so you should get the credit. I was just helping out with the implementation. > This could be expanded for other platforms that use xdg stuff by > changing the #ifdef. I added the #ifdef to also deal with the MacOS > case. There will allways be Linux distributions that don't install the xdg tools by default, and it's not inconceivable that they will be supported on MacOS one day. So I think it's better to just try to run xdg-screensaver, warn when it fails, but ignore the error. From reading MSDN this is consistent with the semantics of LockWorkStation. I also think it's better to not lock the entire desktop when Wine runs in a virtual desktop. I remember looking for a way to know whether we are running in desktop mode and found this snippet from PaintDesktop(): HWND hwnd = GetDesktopWindow(); /* check for an owning thread; otherwise don't paint anything (non-desktop mode) */ if (GetWindowThreadProcessId( hwnd, NULL )) ... I copied it but somehow it didn't work for me. -Hans

5 5

re: NULL ptr dereferences found with Calysto static checker
by Dan Kegel 21 Jun '07

21 Jun '07

Domagoj wrote: > I've ran my static checker Calysto on Wine v0.9.35 and got > 78 bug reports:... > If you are interested in the reports, please: > 1) read > http://www.cs.ubc.ca/~babic/index_calysto_community.htm > 2) if the conditions are acceptable, let me know where to > send the reports. The conditions look very minimal, we should be fine with them. A check once a month should be fine. Just send the results to wine-devel(a)winehq.org. (There's some chance we'll ask you to switch to sending them somewhere else, but that will do initially.) For the moment just put the calysto.org link in the mail. Once it's clear the results are useful, somebody will link to calysto at least from our wiki. Say, whatever happened to Coverity's scans of Wine? I just logged in to the Wine results at http://scan.coverity.com, and the last scan seems to have been last July. Did they set up a new, private site for us? Paul V., do you know? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

9 11

Coverity status
by Paul Vriens 21 Jun '07

21 Jun '07

Hi, I've been in contact with Coverity. People currently listed as Wine contacts are: - Jan Zerebecki - Paul Vriens The main page is changed so it reflects the new scan site http://scan2.coverity.com:7479 and there has just been a new run! Coverity is very busy setting up some proper communication channels and some means for the contacts to do some kind of user administration (limited of course). Apart from that a lot of the current manual tasks will be automated (like the counters on the page where Wine is listed http://scan.coverity.com/rung1.html). Cheers, Paul.

1 0

Re: winmm: Specify the arguments of the function in the function pointer
by Alexandre Julliard 21 Jun '07

21 Jun '07

Michael Stefaniuc <mstefani(a)redhat.de> writes: > @@ -114,10 +114,10 @@ static BOOL MMDRV_GetDescription32(const char* fname, char* buf, int buflen) > DWORD dw; > BOOL ret = FALSE; > UINT u; > - FARPROC pGetFileVersionInfoSizeA; > - FARPROC pGetFileVersionInfoA; > - FARPROC pVerQueryValueA; > - HMODULE hmodule = 0; > + DWORD (WINAPI *pGetFileVersionInfoSizeA)(LPCSTR,LPDWORD); > + BOOL (WINAPI *pGetFileVersionInfoA)(LPCSTR,DWORD,DWORD,LPVOID); > + BOOL (WINAPI *pVerQueryValueA)(LPCVOID,LPCSTR,LPVOID*,UINT*); > + HMODULE hmodule = 0; It may have been done that way because local WINAPI pointers crash on old versions of gcc. But that whole function should probably be removed, dumping version info doesn't belong in winmm. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] oleaut32: add PNG loading [try2]
by Evan Stade 21 Jun '07

21 Jun '07

On 6/19/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > Try2: This time the rowsize is correctly aligned (on 4-byte > boundaries) and palette-mode PNGs are allowed as well as RGB-mode > PNGs. > > Changelog: > *added support to decode some PNG files > *added check for png.h / dynamic loading of libpng.so > > configure.ac | 2 > dlls/oleaut32/olepicture.c | 205 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 207 insertions(+), 0 deletions(-) > > -- > Evan Stade > > Hi, How can I improve this patch such that it will be accepted? -- Evan Stade

2 1

Re: shell32: Make SHGetDesktopFolder use a cached instance of IShellFolder
by Alexandre Julliard 21 Jun '07

21 Jun '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + sf = LocalAlloc( LMEM_ZEROINIT, sizeof (IGenericSFImpl) ); > + if (!sf) > + return E_OUTOFMEMORY; > + > + if (InterlockedCompareExchangePointer((void *)&cached_sf, sf, NULL) != NULL) > + LocalFree( sf ); /* some other thread already been here */ > + else > + { > + sf->ref = 0; > + sf->lpVtbl = &vt_MCFldr_ShellFolder2; > + sf->pidlRoot = _ILCreateDesktop(); /* my qualified pidl */ > + sf->sPathTarget = SHAlloc( (lstrlenW(szMyPath) + 1)*sizeof(WCHAR) ); > + lstrcpyW( sf->sPathTarget, szMyPath ); > + } > + } You need to initialize the object completely before storing it as cached entry. -- Alexandre Julliard julliard(a)winehq.org

1 0

ntdll: Constify some variables (1 of 2)
by Andrew Talbot 21 Jun '07

21 Jun '07

Please ignore this patch. Thanks, -- Andy.

1 0

Re: [kernel32][tests] Add test for GetShortPathNameW
by Dmitry Timoshkov 21 Jun '07

21 Jun '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > + WCHAR PROG_FILES_DIR[MAX_PATH]; Looks like that this variable is not used anywhere. > static DWORD (WINAPI *pGetLongPathNameA)(LPCSTR,LPSTR,DWORD); > static DWORD (WINAPI *pGetLongPathNameW)(LPWSTR,LPWSTR,DWORD); > +static DWORD (WINAPI *pGetShortPathNameW)(LPWSTR,LPWSTR,DWORD); I don't see where pGetShortPathNameW is initialized. > + file = CreateFileW(short_path, GENERIC_READ|GENERIC_WRITE, 0, > + NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + ok(file != INVALID_HANDLE_VALUE, "File was not created.\n"); > + ret = WriteFile(file, "test", strlen("test"), NULL, NULL); > + ok(ret, "Can not open file!!\n"); The error message in ok() is not correct. > + CloseHandle(file); > + ret = DeleteFileW(short_path); > + ok(ret, "Can not delete file.\n"); > + GetTempPathW(MAX_PATH, path); > + lstrcatW(path, src); > + lstrcatW(path, backSlash); > + ret = RemoveDirectoryW(path); 'path' at this point already contains what you need, calling GetTempPathW and friends is not needed, and that would simplify the code a bit. > +static void test_GetShortPathNameW(void) > +{ > + WCHAR empty[MAX_PATH]; > + WCHAR pathE[] = {'p','a','t','h','t','e','s','t',0}; > + WCHAR pathRL[] = {0x0414,0x043B,0x0438,0x043D,0x043D,0x043E,0x0435,0x0418,0x043C,0x044F,0}; /* Long Russian name > */ > + WCHAR pathRS[] = {0x0418,0x043C,0x044F,0}; /* Short Russian name */ Do you really need the test to use cyrillic characters? That won't work if underlying unix locale is not russian regardless what you set the thread locale to. > + /* Not present in all windows versions */ > + if(pGetShortPathNameW) > + { > + SetLastError(0xdeadbeef); > + length = pGetShortPathNameW(NULL,NULL,0); > + if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + { > + skip("GetShortPathNameW is not implemented\n"); > + return; > + } Indentation inside of 'if(pGetShortPathNameW)' is completely messed up. -- Dmitry.

2 2

Re: [kernel32][tests] Add test for GetShortPathNameW
by Detlef Riekenberg 20 Jun '07

20 Jun '07

On Di, 2007-06-19 at 13:18 +0400, Anatoly Lyutin wrote: > + { > + SetLastError(0xdeadbeef); > + length = pGetShortPathNameW(NULL,NULL,0); > + if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + { > + skip("GetShortPathNameW is not implemented\n"); > + return; Your indention looks wired -- By by ... Detlef

1 0

NULL ptr dereferences found with Calysto static checker
by Domagoj Babic 20 Jun '07

20 Jun '07

Hi, I've ran my static checker Calysto on Wine v0.9.35 and got 78 bug reports: makedep: 1 sfnt2fnt: 4 winebuild: 6 winedump: 2 winegcc: 5 libwine: 60 If you are interested in the reports, please: 1) read http://www.cs.ubc.ca/~babic/index_calysto_community.htm 2) if the conditions are acceptable, let me know where to send the reports. Kind regards, -- Domagoj Babic http://www.domagoj.info/ http://www.calysto.org/

1 0

On stuttering audio in quartz/DirectShow
by Alex Villacís Lasso 20 Jun '07

20 Jun '07

Upon checking the source code of dlls/quartz I found out about the method SetSyncSource defined in the IBaseFilter interface: dsoundrender.c:static HRESULT WINAPI DSoundRender_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) filesource.c:static HRESULT WINAPI AsyncReader_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) filtergraph.c:static HRESULT WINAPI MediaFilter_SetSyncSource(IMediaFilter *iface, IReferenceClock *pClock) parser.c:static HRESULT WINAPI Parser_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) transform.c:static HRESULT WINAPI TransformFilter_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) videorenderer.c:static HRESULT WINAPI VideoRenderer_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) In particular, I see the following two things about sync sources: 1) I see no effort on part of filtergraph.c to add a sync source when simply asked to render a file 2) Even if it did, current implementation of videorenderer.c does nothing with its sync source So I have a couple of questions: 1) Am I right to assume that a sync source might be used to synchronize and (if necessary) drop frames at the videorenderer in order to maintain synchronization and avoid stuttering? 2) Could the sttutering really be solved by implementing the using and passing of a synchronization source (systemclock.c) in file rendering? If so, then the migration to DirectDraw would become just an optimization to increase the frame rate. Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: [PATCH 1/3] gdi32: Set current position properly after ArcTo.
by Alexandre Julliard 20 Jun '07

20 Jun '07

Misha Koshelev <mk144210(a)bcm.edu> writes: > + if (!PATH_IsPathOpen(dc->path)) > { > - angle = atan2( > - ((yend-ycenter)/height), > - ((xend-xcenter)/width)); > - MoveToEx(hdc, GDI_ROUND(xcenter+(cos(angle)*xradius)), > - GDI_ROUND(ycenter+(sin(angle)*yradius)), NULL); > + if (result && dc->funcs->pMoveTo) result = dc->funcs->pMoveTo(dc->physDev,end.x,end.y); It would be cleaner to add a PATH_ArcTo function instead of having multiple PATH_IsPathOpen checks in the generic function. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: OpenFile16 and similar functions
by Dan Kegel 20 Jun '07

20 Jun '07

On 6/20/07, Jakob Eriksson <jakob(a)vmlinux.org> wrote: > Are not the tests still EXE-s called by winetest? Then the current > winetest will work OK. Except that winetest.h might not compile in 16 bit mode, and our build system doesn't handle 16 bit binaries, and gcc/ld can't build 16 bit NE executables, and you can't mix 16 and 32 bit easily so we'd need a winetest16, yes. :-) > Though we would benefit from having a crosscompiler to 8086 Windows EXEs. Yeah, I haven't checked yet whether openwatcom's linux version can build 16 bit NE executables. Sure would be cool! - Dan

2 1

re: OpenFile16 and similar functions
by Dan Kegel 20 Jun '07

20 Jun '07

Anatoly asked: > How can I write a test for this function or build program use it? I think writing good win16 tests requires a 16 bit linker. Fortunately, OpenWatcom has one, and works on Wine. It's amazingly easy to install it and build one of its demo apps: $ wget http://ftp.openwatcom.org/ftp/open-watcom-c-win32-1.6.exe $ wine open-watcom-c-win32-1.6.exe $ wineboot $ cd .wine/drive_c/WATCOM/samples/win/alarm/win16 $ wine wmake $ wine alarm This builds an honest-to-goodness win16 binary that works on XP (possibly with one warning dialog you have to ignore). Unfortuately, Wine doesn't currently run these win16 apps properly; they hang with err:ntdll:RtlpWaitForCriticalSection section 0x7b91f300 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000c, retrying (60 sec) This is embarassing. These are the "hello, world" of 16 bit windows apps, and current wine (well, wine-0.9.37-g3739b5f) can't run them... I haven't looked to see if older wine runs these 16 bit demo apps properly.

2 3

OpenFile16 and similar functions
by Anatoly Lyutin 19 Jun '07

19 Jun '07

Hi all! How can I write a test for this function or build program use it? I do not understand how I can do this uses Wine? Thank you for attention! =) -- Best regards Anatoly Lyutin.

1 0

Re: [4/5] D3D8: Convert FVFs to vertex declarations
by H. Verbeet 19 Jun '07

19 Jun '07

On 19/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + if (hr != S_OK) return NULL; Any reason for not simply using FAILED(hr) there? > + object->decls = HeapAlloc(GetProcessHeap(), 0, 0); Is that useful?

3 4

Compiling Wine on Fedora 7 64-bit (opengl fails)
by Paul Vriens 19 Jun '07

19 Jun '07

Hi, I'm a total newbie to the 64-bit world (just built a system this weekend) and now I'm trying to get Wine compiled. It fails with (the first failure that is): LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -foversion.res version.rc ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./opengl32.spec opengl_ext.o opengl_norm.o wgl.o version.res -o opengl32.dll.so -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -L/usr/lib64 -lSM -lICE -lXxf86vm -lXext -lX11 -lGL ../../libs/port/libwine_port.a /usr/bin/ld: skipping incompatible /usr/lib64/libSM.so when searching for -lSM /usr/bin/ld: skipping incompatible /usr/lib64/libICE.so when searching for -lICE /usr/bin/ld: skipping incompatible /usr/lib64/libXxf86vm.so when searching for -lXxf86vm /usr/bin/ld: skipping incompatible /usr/lib64/libXext.so when searching for -lXext /usr/bin/ld: skipping incompatible /usr/lib64/libX11.so when searching for -lX11 /usr/bin/ld: skipping incompatible /usr/lib64/libGL.so when searching for -lGL /usr/bin/ld: skipping incompatible /usr/lib64/libm.so when searching for -lm /usr/bin/ld: skipping incompatible /usr/lib64/libm.a when searching for -lm /usr/bin/ld: skipping incompatible /usr/lib64/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.a when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.a when searching for -lc wgl.o: In function `wglUseFontOutlines_common': wgl.c:(.text+0xec6): undefined reference to `gluNewTess' wgl.c:(.text+0xeec): undefined reference to `gluTessCallback' wgl.c:(.text+0xf09): undefined reference to `gluTessCallback' wgl.c:(.text+0xf26): undefined reference to `gluTessCallback' wgl.c:(.text+0x13b9): undefined reference to `gluTessBeginPolygon' wgl.c:(.text+0x1432): undefined reference to `gluTessBeginContour' wgl.c:(.text+0x146e): undefined reference to `gluTessVertex' wgl.c:(.text+0x1563): undefined reference to `gluTessVertex' wgl.c:(.text+0x167f): undefined reference to `gluTessVertex' wgl.c:(.text+0x16ca): undefined reference to `gluTessVertex' wgl.c:(.text+0x174b): undefined reference to `gluTessEndContour' wgl.c:(.text+0x178b): undefined reference to `gluTessEndContour' wgl.c:(.text+0x17b9): undefined reference to `gluTessEndPolygon' wgl.c:(.text+0x18a0): undefined reference to `gluDeleteTess' collect2: ld returned 1 exit status winegcc: gcc failed. make: *** [opengl32.dll.so] Error 2 Any suggestions where to start looking or how to approach this. I had a look at the Wiki to no avail. I've tested with and without the NVIDIA drivers. I also have another F7 box, 32-bit, that works fine. Cheers, Paul.

3 3

Re: [2/5] WineD3D: Remove the FVF codepath from drawprim
by H. Verbeet 19 Jun '07

19 Jun '07

Not specific to this patch, but will you remove the fvf field from the stateblock as well?

2 3

Re: QUARTZ: Patch 1 - Fix video rendering sizing/positioning bugs
by Alexandre Julliard 19 Jun '07

19 Jun '07

a_villacis(a)palosanto.com writes: > + case WM_SIZE: > + TRACE("WM_SIZE %d %d\n", LOWORD(lParam), HIWORD(lParam)); > + SetWindowPos(hwnd, NULL, pVideoRenderer->WindowPos.left, pVideoRenderer->WindowPos.top, LOWORD(lParam), HIWORD(lParam), SWP_NOZORDER); Why do you want to resize a window that has just been resized? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [AppDB] Increase menu text size
by Alex Waite 19 Jun '07

19 Jun '07

Alexander Nicolaysen Sørnes wrote: > This should make it easier for people to notice the menu options. From 10px > to 11px. > > > Regards, > > Alexander N. Sørnes > > > ------------------------------------------------------------------------ > > I agree with increasing text size here, but we should keep in mind a few things. Setting text size in pixels is no longer the cool thing to do. W3C feels that it is best to use the "x-small, small, medium, etc" values since they respect user settings and accessibility the most. An alternative which gives more control but isn't quite as proper is to use em instead of px. Either is better than using pixels. Also, this text size should be changed on all pages because the menu text size in the AppDB is now larger than the text in the menu on the front page. I am part of a large project at my work where I have had to learn quite a bit about web accessibility and best practices. Contrary to popular (and lazy) belief, most of it actually makes it easier in the end to write and maintain a large website. Plus the site is accessible to more users. ---Alex

2 1

Re: [4/5] WineD3D: Emulate tracking of multiple material properties
by H. Verbeet 19 Jun '07

19 Jun '07

On 19/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + if(!This->stateBlock->vertexShader) { > Testing for a vertex shader like that doesn't take into account the selected vs mode (ie, could be disabled) or transformed vertices. You should probably be using use_vs() instead.

1 0

Re: [3/5] WineD3D: Do not attempt to load texture coords for unsupported stages
by H. Verbeet 19 Jun '07

19 Jun '07

I remember discussing this patch, but in retrospect I'm not sure this fix is completely correct. When a pixel shader is used with fixed function vertex processing, more than GL_LIMITS(textures) texture coordinates can be used.

1 0

Re: winex11 - Fix X11DRV_DIB_GetImageBits() when target bitmaps are larger than fetched area
by Alexandre Julliard 19 Jun '07

19 Jun '07

Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > #ifdef HAVE_LIBXXSHM > - if (descr->image && descr->useShm) > + > + if(descr->image && descr->useShm) > + { > + XGetGeometry(gdi_display, descr->drawable, &root, &x, &y, &width, > &height, &border_width, &depth); > + TRACE("XGetGeometry(), width=%i, heigth=%i\n", width, height); > + } > + > + /* We must not call XShmGetImage() with a bitmap which is bigger > than the avilable area. > + If we do, XShmGetImage() will fail (X exception), as it checks > for this internally. */ > + if((descr->image && descr->useShm) && (bmpImage->width <= (width - > descr->xSrc)) > + && (bmpImage->height <= (height - descr->ySrc))) > { > int saveRed, saveGreen, saveBlue; The patch is wrapped, and you don't want to use XGetGeometry, this incurs a server round-trip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Adds NET STOP to net.exe
by Kirill K. Smirnov 19 Jun '07

19 Jun '07

Hi, Tim. Please, proceed bug #8554. Thanks, -- Kirill

1 0

Re: winex11.drv: send WM_MOUSEACTIVATE before closing a window (try 3)
by Dmitry Timoshkov 19 Jun '07

19 Jun '07

"Lei Zhang" <thestig(a)google.com> wrote: > On Windows, clicking the close button of a nonactive window generates > a WM_MOUSEACTIVATE notification. Applications with custom window > procedures can then choose to ignore the close button if they wished > to by returning MA_ACTIVATEANDEAT / MA_NOACTIVATEANDEAT. I'm not sure what you mean by "applications with custom window procedures" because all (even simple ones) window procs in applications are custom, and they are free to handle/ignore any message they like, for instance WM_CLOSE or WM_SYSCOMMAND/SC_CLOSE. We already send WM_MOUSEACTIVATE message on a take focus X11 event, so I don't see a point in duplicating it. On the other hand if a WM doesn't activate a window when a user clicks on window's caption (where the close button usually placed) then it's a WM bug and we can do nothing to fix it. -- Dmitry.

2 4

Remove font set when calling XCreateIC?
by Nigel Liang 19 Jun '07

19 Jun '07

Hi, This patch removes a call to XCreateFontSet which was causing wine to be very slow in some Chinese locale settings. The server side font calls are supposed to be deprecated anyway as Dan pointed out in his comment here: http://bugs.winehq.org/show_bug.cgi?id=5309 According to the Xlib programming manual, if a font set is not specified when calling XCreateIC, the default is determined by the input method. But it seems that this used to be a required field, so I am not sure if this will break any old input methods out there. Any ideas on how I could better test this before submitting? Thanks! -Nigel

1 0

Re: msi: Fix the conditions to determine which files to remove
by James Hawkins 18 Jun '07

18 Jun '07

On 6/18/07, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > This fixes an error with a test Windows Installer Patch that I'm > trying to get working. > > Changelog: > * Fix the conditions to determine which files to remove. > Ignore this for right now. There's something else that needs to be fixed first. -- James Hawkins

1 0

Re: ntoskrnl.exe: Add a stub implementation of KeInitializeTimer
by James Hawkins 18 Jun '07

18 Jun '07

On 6/18/07, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > The Fahrenheit installer calls this function. KTIMER is defined in > ketypes.h in the ddk, but that file doesn't exist for us yet, and I > followed the example of others and defined it in wdm.h (where most of > the types in ketypes.h were defined instead). > Nevermind my comments about the headers. osronline says it's defined in wdm.h, so this patch is still good to go. -- James Hawkins

1 0

Sorry, Opera is not yet supported by Xinha.
by RusH 18 Jun '07

18 Jun '07

Bugzilla uses this new toy, but the script loads it even after it detects Opera = it eats the text in edit fields sometimes and I cant process Test Results. Could it load itselfe only when not detecting Opera? -- Who logs in to gdm? Not I, said the duck.

1 0

Winelib should have dir.h and some consts
by Jérôme Gardou 18 Jun '07

18 Jun '07

I try to compile a small program which use msvcrt headers, and it appeared that, in winelib there is no dir.h (which may be redirected to dirent.h ?) and that consts like MAXPATH, MAXDRIVE and others are not defined. Should it be done ? Is it planned to be ? ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

2 1

Re: [Wine] Sending changes to winelib ?
by Scott Ritchie 18 Jun '07

18 Jun '07

The wine-devel mailing list is best for this type of development question. Thanks, Scott Ritchie On Sun, 2007-06-17 at 12:49 +0200, Jérôme Gardou wrote: > I have a little program coded for windows, and I want to compile it using > winegcc. > > Unfortunately, some functions are not implemented in winelib, and I have to > tweak some files. So, How do I submit those changes ? I found nothing on the > WineHQ site. > > SO, if someone knows where to redirect me, I can do it alone! > > > > > > ___________________________________________________________________________ > Yahoo! Mail rinvente le mail ! Dcouvrez le nouveau Yahoo! Mail et son interface rvolutionnaire. > http://fr.mail.yahoo.com > > > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users

1 0

Re: cmd.exe: Fix FOR so it works as 'well' as before.
by Detlef Riekenberg 18 Jun '07

18 Jun '07

Hi Jason. The Patch is already in the tree, but I have a question: + * + * Execute a command, and any && or bracketed follow on to the command. The + * first command to be executed may not be at the front of the + * commands->thiscommand string (eg. it may point after a DO or ELSE + * Returns TRUE if something like exit or goto has aborted all processing + */ +void WCMD_part_execute(CMD_LIST **cmdList, WCHAR *firstcmd, WCHAR *variable, + WCHAR *value, BOOL isIF, BOOL conditionTRUE) { + The comment missed a closing bracked somewhere. How does the "Returns TRUE" match the declaration ("void")? Thanks -- By by ... Detlef

1 0

Building Wine with the lsb sdk, take 2
by Dan Kegel 18 Jun '07

18 Jun '07

At the Linux Summit, a bunch of us decided it'd be a good idea to try out lsbcc on more real-world packages, so I tried wine again tonight. My previous try was described here: http://www.winehq.org/pipermail/wine-devel/2006-August/050554.html This time I used Feisty Fawn's lsb build env packages: sudo apt-get install lsb-build-cc3 This installed lsbcc (well, lsbcc3, anyway; looks like that's a debianism that isn't mentioned in the official lsb doc). And instead of making configure aware of lsbcc3, I created the file ~/bin/gcc containing #!/bin/sh exec lsbcc3 "$@" (Yes, the first line is needed, make fails without it.) and did chmod +x ~/bin/gcc and added ~/bin early in my PATH. Then I did configure etc. Finally, I still had to use a few of the same magic incantations explained in my last message on the subject when building: LSBCC_SHAREDLIBS=wine export LSBCC_SHAREDLIBS make LDFLAGS=-ldl CFLAGS="-g -O2 \"-DRTLD_DEFAULT=((void *)0)\" -DMAP_FILE=0" The first real problem I ran into was that freetype wasn't found. This turned out to be http://bugs.linuxbase.org/show_bug.cgi?id=1577 and I just ignored it for now. The second real problem I ran into was /home/dank/wine-git/server/ptrace.c:103: undefined reference to `ptrace' Last mention I've seen of ptrace in lsb was http://lists.debian.org/lsb-spec/2001/02/msg00038.html and I guess it never made it in. I've filed this as http://bugs.linuxbase.org/show_bug.cgi?id=1664 - Dan

3 2

Re: hnetcfg: Resend Stub implementation of the dll
by Alexandre Julliard 18 Jun '07

18 Jun '07

Jeff Latimer <lats(a)yless4u.com.au> writes: > --- /dev/null > +++ b/dlls/hnetcfg/Makefile.in > @@ -0,0 +1,14 @@ > +TOPSRCDIR = ../.. > +TOPOBJDIR = ../.. > +SRCDIR = . > + > +MODULE = hnetcfg.dll > +IMPORTS = kernel32 > +IMPORTLIB = libhnetcfg.$(IMPLIBEXT) > + > +C_SRCS = \ > + hnetcfg.c > + > +@MAKE_DLL_RULES@ > + > +@DEPENDENCIES@ # everything below this line is overwritten by make depend That's not a valid Makefile.in. -- Alexandre Julliard julliard(a)winehq.org

1 0

debugging help
by Damjan Jovanovic 18 Jun '07

18 Jun '07

Hi I've been looking at bug 4437, where a game demo works perfectly with the native MSVCRT.DLL but dies on startup with the builtin due to a division by zero. The builtin doesn't have any fixmes, warnings or errors. Comparing builtin +relay and native +snoop traces shows the divide by zero doesn't happen with the native, everything else looks the same. A +msvcrt log is 200000 lines long but there is nothing obviously wrong either, a +all,+relay log shows nothing useful before the crash - the last function called before the crash is a simple printf without any %'s, which produces the same results on native and builtin. Disassembling around the crash shows a long chain of calculations that dies on the fated idivl. So it looks like a nasty delayed-effect bug. I'd welcome any new ideas, and I also have a few questions. Does +relay catch all function calls? Because some functions like sscanf only appear in +snoop, not in +relay. And is there a way for a builtin DLL to LoadLibrary() the native DLL of the same name and call functions in it? It would be very useful in narrowing down the bug. Thank you Damjan

2 1

Re: QUARTZ: Patch 1 - Fix video rendering sizing/positioning bugs
by Stefan Dösinger 18 Jun '07

18 Jun '07

> --- wine-0.9.39-cvs/dlls/quartz/videorenderer.c 2007-05-17 10:25:02.000000000 -0500 > +++ wine-0.9.39-cvs-patch/dlls/quartz/videorenderer.c 2007-06-17 00:47:15.000000000 -0500 You should really use git. It may be some effort to learn, but it makes your life, and Alexandre's much easier in the long run.

1 0

Re: QUARTZ: Patch 2 - Move blitting operation to message thread and handle WM_PAINT
by Chris Robinson 17 Jun '07

17 Jun '07

I have no direct comment on the patch (it's not really my area), but there's something I'd like to bring up. On Sunday 17 June 2007 01:51:56 pm a_villacis(a)palosanto.com wrote: > This patch moves the blitting code into the message thread. This is a setup > patch for the DirectDraw rewrite, but can be applied on its own after the > first patch. I'm all for changing the video renderer away from GDI, however I think it'd be better to move it to Direct3D or WGL instead of DDraw. I'm quite sure native quartz uses Direct3D when available, given that DDraw has been deprecated ever since DX7. Also, using native quartz's video renderer causes wined3d debug output for me, and as Stefan says, DDraw currently defaults to GDI so it wouldn't have come from that.

1 0

Re: dinput: Handle multiple keyboard and mouse devices. Get rid of the message window. [resend]
by Vitaliy Margolen 17 Jun '07

17 Jun '07

Please don't apply this patch. I will need to change few more things that will affect parts of this patch. Vitaliy. Vitaliy Margolen wrote: > Please use this one instead. The other patch had accidentally escaped debug > statements. > > Fixes bug 7129. > > The whole idea here is to set/release hook only once for keyboard/mouse. > Then if we have more then one device, just call their hook handlers from > the single > top level handler. > > Also, since we don't really check the return status from setting the > hook itself > get rid of the message window. Just notify the thread it needs to > recheck device > lists and set/remove hooks. > > --- > dlls/dinput/dinput_main.c | 234 > +++++++++++++++++++++++++----------------- > dlls/dinput/dinput_private.h | 3 +- > dlls/dinput/keyboard.c | 54 ++-------- > dlls/dinput/mouse.c | 28 +----- > 4 files changed, 156 insertions(+), 163 deletions(-) > > > ------------------------------------------------------------------------ > >

1 0

re: vxd loading is broken last months
by Dan Kegel 17 Jun '07

17 Jun '07

Vitaly Lipatov wrote: > INT21_CreateMagicDeviceHandle in winedos/int21.c uses the same dummy file > magic with open file with unix path from wine_get_server_dir(). > I guess we could use NtCreateFile on unix path before. > Now we need select correct place for such dummy files inside wine disk tree... Yeah. Evan has been sitting on a patch to fix this for a week now. Evan, I'd say it's time to post your minimal test and the fix, even if things are broken. - Dan

4 3

GDI+ programs
by Evan Stade 16 Jun '07

16 Jun '07

Hi, I want to make some real applications work with the built-in wine GDI+. Does anyone know of some programs that use GDI+ that would be good for guiding my development? thanks, Evan Stade

5 4

vxd loading is broken last months
by Vitaly Lipatov 16 Jun '07

16 Jun '07

CreateFile is not success with somename.vxd (somename.vxd.so exists in /usr/lib/wine) As known open_vxd_handle( LPCWSTR name ) in kernel32/vxd.c have to open dummy file in the wineserver directory. It try use NtCreateFile for open Unix path /tmp/.wine/... and get failure. What part have to be fixed? NtCreateFile or open_vxd_handle? -- Lav Vitaly Lipatov Saint-Petersburg, Etersoft www.etersoft.ru GNU! ALT Linux Team! WINE! LaTeX! LyX!

2 2

cmd.exe console question
by Ann & Jason Edmeades 15 Jun '07

15 Jun '07

Out of interest, is there any way to get (read here 'write code for') the wine's cmd.exe better integrated in the window you launch it from when it is not in wineconsole mode. For example, I would love to see cls clear the screen (I suppose I could just launch 'clear'!), or command retrieval work (and, but by far the lowest priority, colo(u)rs). I *know* you can do it with wineconsole with user and curses backend, but in a 'normal' shell window the shell itself manages it, and is there any programming interface to that? One problem I can perceive is I cant tell between output being redirected to a file, or output being redirected to the shell window (neither query the console attributes) Jason

1 0

Re: [PATCH 2/2] dinput: Handle multiple keyboard and mouse devices.
by Detlef Riekenberg 15 Jun '07

15 Jun '07

On So, 2007-06-10 at 19:20 -0600, Vitaliy Margolen wrote: > Should fix bug 7129. > > The whole idea here is to set/release hook only once for keyboard/mouse. > Then if we have more then one device, just call their hook handlers from the single > top level handler. > --- > dlls/dinput/dinput_main.c | 82 ++++++++++++++++++++++++++++++++++++++--- > dlls/dinput/dinput_private.h | 4 ++- > dlls/dinput/keyboard.c | 54 ++++++--------------------- > dlls/dinput/mouse.c | 28 ++------------ > 4 files changed, 95 insertions(+), 73 deletions(-) Works the same as native dinput. Thanks a lot. The sensitive high-speed Mouse-Accellerator for the RMB is also present with native dinput. I will add a new bug for that regression. Any Ideas, where to search? ("dlls/" or "dlls/winex11.drv/") As additional hint, the moving direction is most times fixed: When i start moving up/right (45*) while the RMB id pressed, then the app still see 45* when I move the mouse in a different direction (down or left as examples). Looks like a value is not reset. -- By by ... Detlef

1 0

Re: gdiplus: graphics tests [try2]
by Alexandre Julliard 15 Jun '07

15 Jun '07

"Evan Stade" <estade(a)gmail.com> writes: > +static const INT drawline_bmp1[192] = > +{0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, I don't think we want to do that sort of thing. We can't guarantee that the results will be exact pixel for pixel, and we don't really care. And even if we did, hardcoding the image in the source this way is unmaintainable. If you want to check the results, you should write an app that draws various things and check it visually against Windows, but I don't think that's something that can be part of the regression test suite. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [3/5] widl: Add tests for encapsulated unions
by Dan Hipschman 15 Jun '07

15 Jun '07

On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote: > + if (strcmp(winetest_platform, "wine") != 0) /* crashes wine */ > + { > + eu.t = ENCU_I; > + eu.tagged_union.i = 7; > + ok(square_encu(&eu) == 49.0, "RPC square_encu\n"); > + > + eu.t = ENCU_F; > + eu.tagged_union.f = 3.0; > + ok(square_encu(&eu) == 9.0, "RPC square_encu\n"); > + } Hi. So, I realize the usual way to handle tests that crash wine (besides fixing the bug that causes the crash), is to "if (0)" or comment the test out, as in ntdll/tests/reg.c, or rpcrt4/tests/ndr_marshall.c, but this patch tests more than wine, it also tests widl, and it's therefore not just documentation. If I "if (0)" the test out (or worse, it doesn't get accepted), I'm going to have to edit the test each time I run it on windows to re-add the encapsulated union test so I can verify that the widl output stubs still work on windows. One solution is to do something like this: #ifndef TESTS_THAT_CRASH_WINE # define TESTS_THAT_CRASH_WINE 0 #endif ... if (TESTS_THAT_CRASH_WINE) { eu.t = ENCU_I; eu.tagged_union.i = 7; ok(square_encu(&eu) == 49.0, "RPC square_encu\n"); eu.t = ENCU_F; eu.tagged_union.f = 3.0; ok(square_encu(&eu) == 9.0, "RPC square_encu\n"); } So at least I can just compile with -DTESTS_THAT_CRASH_WINE=1 on windows, which is easy to stick in a batch file or something. Otherwise, I'm stuck maintaining a patch that has to be applied before each compile. Plus, it means I'm the only one who's probably testing encapsulated unions on windows, so it's only getting tested on one platform. Any chance something like the original patch can get into wine?

2 1

Liberation
by Louis. Lenders 15 Jun '07

15 Jun '07

Hi, this is mainly a follow up to the thread here http://www.winehq.org/pipermail/wine-devel/2007-May/057092.html , to give it a new boost.... Question is, are there any plans to include Liberation fonts in wine? I gave it a good testing last two weeks, that is, i converted the fonts with Hans' Leidekkers script , from link above, and tested the "Arial-compatible" font quite a bit, with several applications. It all seems to work great, no issues / problems found. Several applications would be very happy , if this were to be included in wine. Any comments? Some of the tested apps: xchat --> just aborts silently without arial font Book worms adventures --> pops up a crash window without arial font d3d9-samples from DirectX 9.0 SDK --> Don't show any text without arial font + a lot more that just look prettier with arial font. --------------------------------- Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your freeaccount today.

7 10

gdiplus no longer available in Vista?
by Paul Vriens 15 Jun '07

15 Jun '07

Hi, I had a look but wasn't able to find gdiplus.dll on my Vista box. This most likely means our test has to be re-written. I'll wait with that till the cross-compiling of the gdiplus tests is fixed. Cheers, Paul.

2 1

Problem with the Ubuntu 7.04 (Feisty) package (again)
by Ben Hodgetts (Enverex) 15 Jun '07

15 Jun '07

We've had a few people report issues with the Ubuntu Feisty .38 package in the WineHQ repo lately (http://wine.budgetdedicated.com/archive/ubuntu/feisty/wine_0.9.38~winehq0~u…) the specific issue being that the fonts are all missing on most things, in other places only the first few letters may be shown. Originally I thought this was something to do with them lacking fonts but in each case telling them to install the .37 package instead fixed the issue meaning it's more likely to be a problem with the .38 package. Any ideas Scott? Ben H.

1 0

Re: [3/5] widl: Add tests for encapsulated unions
by Dan Hipschman 15 Jun '07

15 Jun '07

On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote: > > This adds a test for encapsulated unions, but it crashes wine. The exact Hmm, now that I reread this, I think I said this wrong. The test does crash wine, but I wrote my patch so that it doesn't run on wine. So, doing "make check" in dlls/rpcrt4/tests will *not* crash wine, it just won't run the encapsulated union tests. The encapsulated union tests *will* run, and succeed, on windows, however. I felt this was best because that way all of widl's output can still continue to be tested on windows, and everything that can be tested in wine without crashing still will be.

1 0

Re: Uninstaller
by Misha Koshelev 14 Jun '07

14 Jun '07

First of all, of course I am not Alexandre. But I have to say I think I agree with James on this, with regards to submitting just one patch with the correct spacing. I can see how seeing one patch without any spacing changes keeps the diff very simple (I am assuming this is why you submitted your patches in this way), but at the same time I would assume that if Alexandre really wants to see what changed in this way after applying the one patch you will send with correct spacing, he can just type: git-diff -b and see something very similar to your patch #1 (ignores whitespace, same effect). Other than that, I did not see anything obviously wrong with the patch upon a quick look. If you don't hear from anyone else on wine-devel, I would suggest resubmitting as one patch with correct indentation as James suggested. If you don't see it committed after a while (maybe a week or so, maybe longer) I would either get in touch with the list again or try to get in touch with Alexandre to see if he has any specific comments. Hope that helps. Misha

3 4

Re: include/uxtheme.h : enum THEMESIZE
by Michael Stefaniuc 14 Jun '07

14 Jun '07

Nicolas (dyalog.com) wrote: > according to MSDN, include/uxtheme.h should define an "enum THEMESIZE", > which is typedefed to "THEME_SIZE", > rather than typedef the enum {} to "THEMESIZE" as it is currently. > http://msdn2.microsoft.com/en-us/library/ms649970.aspx > > note that dlls/uxtheme/draw.c uses this definition so must also be patched. Please merge those 2 changes into one patch as one without the other make the Wine source to not compile anymore. And please use unified diff format; the draw.c.patch isn't a unified diff. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: user32: improve cut/copy/paste behavior of password edit boxes
by Vitaly Lipatov 14 Jun '07

14 Jun '07

В сообщении от 14 июня 2007 Lei Zhang написал(a): > Hi, > > This patch prevents cutting/copying text from edit boxes with the > ES_PASSWORD style. It also corrects the paste behavior of password Why we need prevent it? > edit boxes when the clipboard is empty. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Juan Lang : comdlg32: Initialize file dialog controls before creating dialog.
by Lei Zhang 14 Jun '07

14 Jun '07

Hi Juan, With this patch, the bottom of file dialogs are cut off such that the file type dropdown and the cancel button can barely be seen. - Lei On 6/7/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 13f18ee7593364a2a685fed2bdfa814431906f0c > URL: http://source.winehq.org/git/wine.git/?a=commit;h=13f18ee7593364a2a685fed2b… > > Author: Juan Lang <juan_lang(a)yahoo.com> > Date: Thu Jun 7 12:27:11 2007 -0700 > > comdlg32: Initialize file dialog controls before creating dialog. > > --- > > dlls/comdlg32/filedlg.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c > index f63e64f..5409b91 100644 > --- a/dlls/comdlg32/filedlg.c > +++ b/dlls/comdlg32/filedlg.c > @@ -1037,11 +1037,11 @@ INT_PTR CALLBACK FileOpenDlgProc95(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM l > so it will be easily accessible through a GetPropA(...) */ > SetPropA(hwnd, FileOpenDlgInfosStr, (HANDLE) fodInfos); > > + FILEDLG95_InitControls(hwnd); > + > fodInfos->DlgInfos.hwndCustomDlg = > CreateTemplateDialog((FileOpenDlgInfos *)lParam, hwnd); > > - FILEDLG95_InitControls(hwnd); > - > if (fodInfos->DlgInfos.hwndCustomDlg) > { > RECT rc; > > > >

2 2

Re: [3/5] WineD3D: Present does not clear the depth stencil
by H. Verbeet 14 Jun '07

14 Jun '07

On 14/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > The patch removes the clearing from Present, except for the DISCARD swap effect if the d3d trace channel is on. It sounds a bit questionable to have different behaviour depending on the debug channel.

2 2

Re: [crypt32/tests 2/2] Vista uses a different error code (RESEND)
by Dmitry Timoshkov 14 Jun '07

14 Jun '07

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > ret = CryptSIPRetrieveSubjectGuid(tempfileW, NULL, &subject); > ok ( !ret, "Expected CryptSIPRetrieveSubjectGuid to fail\n"); > ok ( GetLastError() == ERROR_FILE_INVALID || > + GetLastError() == ERROR_INVALID_PARAMETER /* Vista */ || > GetLastError() == S_OK /* Win98 */, > - "Expected ERROR_FILE_INVALID or S_OK, got 0x%08x\n", GetLastError()); > + "Expected ERROR_FILE_INVALID, ERROR_INVALID_PARAMETER or S_OK, got 0x%08x\n", GetLastError()); S_OK is an OLE error, ERROR_SUCCESS is correct name in this case. It's not your fault at all, but since you are fixing this code it would be nice to fix it as well. -- Dmitry.

2 1

Re: Fixed the WriteEnvironmentStrings action [try2]
by Dmitry Timoshkov 14 Jun '07

14 Jun '07

"James Hawkins" <truiken(a)gmail.com> wrote: > + while (*cptr && (*cptr == '=' || *cptr == '+' || > + *cptr == '-' || *cptr == '!' || *cptr == '*')) > + { > + switch (*cptr) > + { > + case '=': > + *flags |= ENV_ACT_SETALWAYS; > + break; > + case '+': > + *flags |= ENV_ACT_SETABSENT; > + break; > + case '-': > + *flags |= ENV_ACT_REMOVE; > + break; > + case '!': > + *flags |= ENV_ACT_REMOVEMATCH; > + break; > + case '*': > + *flags |= ENV_MOD_MACHINE; > + break; > + default: > + ERR("Unknown Environment flag: %c\n", *cptr); > + return ERROR_FUNCTION_FAILED; > + } > + > + cptr++; > + (*name)++; > + } A simple 'goto' in the 'default:' case, or using while (*cptr) { if (*cptr == '=') else if (*cptr == '+') { } else if (...) { } else break; } would help to avoid double comparisons and simplify the code. -- Dmitry.

1 0

Re: patch for winefile.
by Dmitry Timoshkov 14 Jun '07

14 Jun '07

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > + static const WCHAR sFont[] = {'M','i','c','r','o','s','o','f','t',' ','S','a','n','s',' ','S','e','r','i','f','\0'}; > + HDC hdc = GetDC(0); ... > + if( RegQueryValueEx( hKey, reg_font_facename, NULL, &type, > + (LPBYTE) &logfont.lfFaceName, &sizeW) != ERROR_SUCCESS ) > + strcpyW(logfont.lfFaceName,sFont); It's not very useful to use by default the font that is not available on any Linux installation by default. I'd suggest to use GetStockObject(DEFAULT_GUI_FONT) instead. And you are leaking an hdc. > + LOGFONT logfont; > > wi.cbSize = sizeof( WINDOWINFO ); > GetWindowInfo(Globals.hMainWnd, &wi); > width = wi.rcWindow.right - wi.rcWindow.left; > height = wi.rcWindow.bottom - wi.rcWindow.top; > + GetObject((HGDIOBJ)Globals.hfont, sizeof(logfont), (LPVOID)&logfont); This cast is not needed. -- Dmitry.

1 0

Uninstaller
by Tom Spear 14 Jun '07

14 Jun '07

It's been a while since I brought anything up on this, so I figured I'd ask what was wrong with the last set of patches I sent.. The patches are at [1] and [2], the discussion generated by them are at [3], [4], [5], and [6]... Summary, I did everything I was told in private by a developer (who isn't alexandre, i know), and I got told by another developer, who also isn't alexandre, to fix some things that the first developer said didn't need fixing.. So should I fix those things, or is there some other reason it wasn't committed? [1] http://www.winehq.org/pipermail/wine-patches/2007-June/039911.html [2] http://www.winehq.org/pipermail/wine-patches/2007-June/039912.html [3] http://www.winehq.org/pipermail/wine-devel/2007-June/057253.html [4] http://www.winehq.org/pipermail/wine-devel/2007-June/057254.html [5] http://www.winehq.org/pipermail/wine-devel/2007-June/057255.html [6] http://www.winehq.org/pipermail/wine-devel/2007-June/057258.html Someone please let me know what is wrong (I'd love to hear from The Man, if he has time to take a look), but anyone's responses are welcome (hopefully I get more than 2 reponses this time lol).... -- Thanks Tom

1 0

Re: [GDI+: 7/7] implemented GdipDrawImage
by Evan Stade 14 Jun '07

14 Jun '07

On 6/13/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > changelog: > *implemented GdipDrawImage > > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/graphics.c | 28 ++++++++++++++++++++++++++++ > include/gdiplusflat.h | 1 + > 3 files changed, 30 insertions(+), 1 deletions(-) > > -Evan Stade > > ignore this patch

1 0

msi: Fixed the WriteEnvironmentStrings action
by Misha Koshelev 14 Jun '07

14 Jun '07

> + res = RegQueryValueExW(env, name, NULL, &type, NULL, &size); > + if (res != ERROR_FILE_NOT_FOUND || (res == ERROR_SUCCESS && type != REG_SZ)) > + goto done; Hate to point this out but isn't this the exact same error I made in my first (and second) patch from last night? I think it should be: if ((res != ERROR_FILE_NOT_FOUND && res != ERROR_SUCCESS) || (res == ERROR_SUCCESS && type != REG_SZ)) goto done; In your statement, if res is ERROR_SUCCESS it will always goto done no matter what the value of type, because ERROR_SUCCESS != ERROR_FILE_NOT_FOUND. Guess logic errors in if statements are contagious :) Misha

1 0

Re: msi: Do not use type value if call to RegQueryValueEx failed.
by James Hawkins 13 Jun '07

13 Jun '07

On 6/12/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > This is necessary (bug not sufficient, see my comment in the bug report that I am about > to post) to fix bug 8678. > > It is also clearly correct, as checking the type "returned" by RegQueryValueEx when it fails > makes no sense. > size = 0; res = RegQueryValueExW(env, var, NULL, &type, NULL, &size); - if ((res != ERROR_MORE_DATA && res != ERROR_FILE_NOT_FOUND) || type != REG_SZ) + if ((res != ERROR_MORE_DATA && res != ERROR_FILE_NOT_FOUND) || + (res == ERROR_SUCCESS && type != REG_SZ)) { RegCloseKey(env); return res; This is wrong. If res == ERROR_SUCCESS, then the first condition evaluates to TRUE and we fall through to exit, but then again, res will never be ERROR_SUCCESS after that particular call. Either way, I have a patch ready to send in that fixes the entire action. -- James Hawkins

3 2

Re: [crypt32/tests 2/2] Vista uses a different error code
by Kai Blin 13 Jun '07

13 Jun '07

On Wednesday 13 June 2007 16:13:21 Paul Vriens wrote: > ok ( GetLastError() == ERROR_FILE_INVALID || > + GetLastError() == ERROR_INVALID_PARAMETER /* Vista */ || > GetLastError() == S_OK /* Win98 */, > "Expected ERROR_FILE_INVALID or S_OK, got 0x%08x\n", > GetLastError()); ok ( !memcmp(&subject, &nullSubject, sizeof(GUID)), In that case I think it would make sense to also fix the message. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: gdi32: Add some tests for BITMAPINFOHEADER biSize checks.
by Dmitry Timoshkov 13 Jun '07

13 Jun '07

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > These tests pass on XP and on Wine with Dimitry's patch applied. > I can also confirm that the patch fixes bug 8674. > > -Hans > > Changelog > Add some tests for BITMAPINFOHEADER biSize checks. Please add DeleteObject calls to delete a DIB section after each succeeding test. -- Dmitry.

1 0

CJK XCreateFontSet performance problem (bug 5309)
by dank＠kegel.com 13 Jun '07

13 Jun '07

It turns out bug 5309 affects Picasa; a Chinese user complained that menus were terribly slow. The patch Aric committed here: http://www.winehq.org/pipermail/wine-cvs/2006-October/027272.html seems to have helped. I'm wondering, though, whether this points up a problem in how linux distros configure their asian fonts. I'm sending this via direct telnet to winehq's tsmtp server, since there's no other way to avoid setnding passwords in the clear from where I am at the momment (dang unencrypted wireless in hotel forooms.). Sorry for all the ^H's :-)

1 0

Seeking advice for rewrite of dlls/quartz/videorenderer.c using DirectDraw
by Alex Villacís Lasso 13 Jun '07

13 Jun '07

From a time till now, I am using a test application in Visual Basic in order to test progress in quartz. The code for the application (along with a precompiled EXE) can be found at the following address: http://www.palosanto.com/~a_villacis/WMediaTest.tar.bz2 One of the things I dislike about the current quartz implementation is that when a large AVI video file (say, 640x480) is played with the test application, the sound stutters (in both ALSA and OSS) while the frames are being updated. This occurs with the builtin quartz.dll, but not with native (WinXP) quartz. From what I can deduce from WINEDEBUG=+tid,+quartz , it seems that builtin feeds video and audio in the same thread. In addition, dlls/quartz/videorenderer.c uses StretchDIBits() in order to write one frame of video into the output window. Apparently StretchDIBits() is slow enough in my machine that it cannot complete by the next sound sample. Therefore the stuttering. I made a little patch to move the video rendering in videorender.c into a separate thread, in order to allow it to drop frames. However this does not completely eliminate the stuttering audio. I am now thinking about rewriting the video rendering with DirectDraw. It seems that native quartz.dll uses DirectDraw, not GDI, to display video frames into the output window. One thing I am worried about is the pixel format of the surfaces. The video data is 32bpp, but the output window uses my X config at 16bpp. However, nowhere in the ddraw trace of native quartz I can find any reference to a CreateSurface with 32bpp. It seems that native quartz does the depth conversion itself. The question is this: if I create a 32 bpp surface (in order to lock it and write the 32 bpp frame data into it), can I then blit it into a 16 bpp output window and somehow let DirectDraw take care of the depth conversion? If so, can this be any faster than writing the depth conversion myself? Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

4 5

Re: [GDI+ implementation: 1/8] GdipDrawLineI
by Evan Stade 13 Jun '07

13 Jun '07

On 6/12/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > Changelog: > *implemented GdipDrawLineI > > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/graphics.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+), 1 deletions(-) > > -Evan Stade > > Sorry, to clarify: this series of patches is a resend of the last without the tests, and with some new patches.

2 1

Re: [GDI+: 2/10] first pen test
by Detlef Riekenberg 13 Jun '07

13 Jun '07

On Mo, 2007-06-11 at 11:52 -0700, Evan Stade wrote: > + > + status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel, > &pen); > + > + todo_wine > + expect(GdiplusNotInitialized, status); > + > + GdipDeletePen(pen); > +} Is pen set to NULL, when GdipCreatePen1 failed? This ist not checked in your test and not done in your implementation, but you pass uninitialized garbage (pen) to GdipDeletePen. You might want to use: - GpPen *pen; + GpPen *pen = NULL; and - GdipDeletePen(pen); + if (status == Ok) then GdipDeletePen(pen); Thanks -- By by ... Detlef

3 2

Re: advapi32: Allow setting CRYPT_VERIFYCONTEXT and CRYPT_NEWKEYSET in CryptAcquireContext
by Mounir IDRASSI 13 Jun '07

13 Jun '07

Hi Maarten, You should not modify advapi32 to accommodate this behavior but rsaenh instead. The acceptance of this flags combination is specific to the Microsoft RSA CSP implementation and other vendors don't support it (I tested it with four third party CSPs). Moreover, your patch will clearly introduce unexpected CSP behavior when this combination of flags is specified as you start by acquiring a context using CRYPT_NEWKEYSET only: the returned context will not behave as intended by the CRYPT_VERIFYCONTEXT flag which normally limits many things. The modification to rsaenh is straightforward: in the code of RSAENH_CPAcquireContext, juste add the line "case CRYPT_VERIFYCONTEXT | CRYPT_NEWKEYSET:" above the existing line "case CRYPT_VERIFYCONTEXT:". Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Maarten Lankhorst wrote: > With tests. I think this is the correct way to do this: First try to > Acquire with CRYPT_NEWKEYSET, then CRYPT_VERIFYCONTEXT if it already exists. >

1 0

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods
by H. Verbeet 12 Jun '07

12 Jun '07

On 13/06/07, Kovács András <andras(a)csevego.net> wrote: > + TRACE("Adapter %p, Driver Type %d, Software Module handle %p, Flags %08x, SDKVersion %d, Device %p\n", > + Adapter, DriverType, Software, Flags, SDKVersion, Device); I think the DriverType should be traces as string there (ie, using something like the debug_d3d*() functions in dlls/wined3d/utils.c). Also, please prefix hexadecimal numbers with 0x. d3d8 and d3d9 are pretty bad wrt producing readable traces, but we might as well do it right when writing a new dll. > + FIXME("ID3D10Device interface is not binary compatible to windows yet\n"); Actually, a void * is binary compatible with IDGXIAdapter * I suppose it's a matter of taste, but personally I think more C like naming (ie, lower case, _ separated) for the parameter names would be easier on the eyes :-) (and you do use those for the ID3D10DeviceImpl functions). Chris already mentioned the initial refcount on IRC.

2 2

Re: Allow GL_ONE on WINED3DRS_EDGEANTIALIAS dstBlend value (try 2)
by H. Verbeet 12 Jun '07

12 Jun '07

On 13/06/07, Kovács András <andras(a)csevego.net> wrote: > Hi, > > Allow GL_ONE on WINED3DRS_EDGEANTIALIAS' dstBlend value. This fixes Pirates Of > Caribbean At The Worlds End blending problem. ( black square behind linght > sources) > > -- I think I wasn't very clear wrt what I said on IRC / wrote in my earlier mail. The original patch was fine with me for what it did. What I meant to say was that an additional patch should probably follow that one to remove the code that modifies srcBlend and dstBlend. Personally I think the changes are small enough to go in a single patch, but that would be up to Alexandre. You should remove the line modifying srcBlend a few lines above as well though.

1 0

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods
by Stefan Dösinger 12 Jun '07

12 Jun '07

Am Mittwoch, 13. Juni 2007 00:17 schrieb Kovács András: > [7/7] Add ID3D10Device interface and implement it's IUnknown methods >+ object->lpVtbl = &D3D10Device_Vtbl; >+ object->ref = 0; Spotted by KittyCat on irc. The ref should be 1. Either set it to 1, or call ID3D10Device_AddRef(*Device) after setting *Device(ms seems to do it the Addref way).

1 0

Re: [PATCH try2 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.
by Detlef Riekenberg 12 Jun '07

12 Jun '07

On Mo, 2007-06-11 at 23:29 -0500, Misha Koshelev wrote: > + * - On installation problems, a MessageBox is displayed and there > does not seem to be a way to turn this off. A CBT-Hook (HCBT_CREATEWND) might help -- By by ... Detlef

2 1

Re: [GDI+: 3/10] graphics implementation
by Detlef Riekenberg 12 Jun '07

12 Jun '07

On Mo, 2007-06-11 at 11:54 -0700, Evan Stade wrote: > + > + *graphics = (GpGraphics*) HeapAlloc(GetProcessHeap(), > HEAP_ZERO_MEMORY, > + sizeof(GpGraphics)); Have you checked, that the native dll does the same? (WINEDEBUG="+snoop,+relay") Your implementation of GdipCreatePen1 is using GdipAlloc. Thanks -- By by ... Detlef

2 1

Re: [GDI+: 3/10] graphics implementation
by Detlef Riekenberg 12 Jun '07

12 Jun '07

On Mo, 2007-06-11 at 11:54 -0700, Evan Stade wrote: > +GpStatus WINGDIPAPI GdipCreateFromHDC(HDC hdc, GpGraphics **graphics) > +{ > + if(hdc == NULL) > + return OutOfMemory; > + > + if(graphics == NULL) > + return InvalidParameter; > + > + *graphics = (GpGraphics*) HeapAlloc(GetProcessHeap(), > HEAP_ZERO_MEMORY, > + sizeof(GpGraphics)); > + (*graphics)->hdc = hdc; > + (*graphics)->hwnd = NULL; There is no need to set a member to NULL, when you use HEAP_ZERO_MEMORY. -- By by ... Detlef

2 1

Re: [GDI+: 6/10] GdipDrawLineI test
by Detlef Riekenberg 12 Jun '07

12 Jun '07

On Mo, 2007-06-11 at 12:00 -0700, Evan Stade wrote: > > Changelog: > *Added framework for pixel-by-pixel comparison in tests > *added GdipDrawLineI test > > dlls/gdiplus/tests/graphics.c | 164 > +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 164 insertions(+), 0 deletions(-) > > -Evan Stade The Patch is missing -- By by ... Detlef

1 0

Add new dll mscat32
by Vijay Kiran Kamuju 12 Jun '07

12 Jun '07

Hi, I would like to add a stub dll for mscat32.dll in wine. It mostly is a forwarder dll ie, it has forwards for most of the functions to wintrust.dll And it also provides functions for reading catalog files. It is mostly used by microsoft for it installers. I mean for its own products like Winodows Media Player 9, IE, etc. I wanted to inform to get the approval from wine team, for inclusion of this dll. Thanks, VJ

2 4

Re: widl: Add a missing assignment to current_structure before calling write_embedded_types.
by Dan Hipschman 12 Jun '07

12 Jun '07

On Tue, Jun 12, 2007 at 10:29:24AM +0100, Robert Shearman wrote: > error("structure size for %s exceeds %d bytes by %d bytes\n", > name, USHRT_MAX, total_size - USHRT_MAX); > > + current_structure = type; > has_pointers = write_embedded_types(file, NULL, type, name, 0, tfsoff); > + current_structure = NULL; > > array = find_array_or_string_in_struct(type); > if (array && !processed(array->type)) That was taken care of by the patch I sent in a little before you. It's like we're reading each other's minds. ;-)

1 0

Re: [GDI+: 3/5] added graphics implementation and tests
by Evan Stade 12 Jun '07

12 Jun '07

> On 6/10/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > > "Evan Stade" <estade(a)gmail.com> wrote: > > > > >> Any reason why are you creating a new pen in GdipDrawRectangleI, and while using > > >> an existing one in GdipDrawLineI? > > >> > > >> -- > > >> Dmitry. > > >> > > > > > > Yes, the reason for that is the passed pen can have any endcap style, > > > but to draw the rectangle the pen needs square endcaps. The same does > > > not apply to DrawLine. > > > > Do you have a confirmation that native gdiplus does that as well? +relay,+snoop > > trace, some other test? > > > > -- > > Dmitry. > > Native GDI+ does its own rendering. For example, GDI+ drawline uses repeated stretchblts rather than GDI drawline. However, GDI drawline can be pretty close, if not pixel-for-pixel the same.

1 0

Re: [GDI+: 1/10] first pen implementation
by Detlef Riekenberg 12 Jun '07

12 Jun '07

On Mo, 2007-06-11 at 11:51 -0700, Evan Stade wrote: > +GpStatus WINGDIPAPI GdipCreatePen1(ARGB color, FLOAT width, GpUnit > unit, > + GpPen **pen) > +{ > + LOGBRUSH lb; > + GpPen *gp_pen; > + > + gp_pen = (GpPen*) GdipAlloc(sizeof(GpPen)); > + if(!pen) return OutOfMemory; > + > + gp_pen->style = GP_DEFAULT_PENSTYLE; This looks not correct. You returned "OutOfMemory", but you check "pen". I think, you really mean "gp_pen" in that "if". A test with pen==NULL would be nice. > + if((gp_pen->unit == UnitWorld) || (gp_pen->unit == UnitPixel)) { > + > + } else { > + FIXME("UnitWorld, UnitPixel only supported units"); > + return NotImplemented; You leak the allocated memory from gp_pen here. The FIXME does not help very much. You should dump the value for the unsupported unit. > + if(!gp_pen) > + return GenericError; This is dead code in this location. When the allocation for gp_pen failed, you will never reach this line, because gp_pen was accesed before and produced a crash. -- By by ... Detlef

1 0

Re: Allow GL_ONE on WINED3DRS_EDGEANTIALIAS dstBlend value
by H. Verbeet 12 Jun '07

12 Jun '07

On 12/06/07, Kovács András <andras(a)csevego.net> wrote: > Hi, > > Allow GL_ONE on WINED3DRS_EDGEANTIALIAS' dstBlend value. This fixes Pirates Of > Caribbean At The Worlds End blending problem. ( black square behind linght > sources) > -- I'm not sure we should be changing srcBlend/dstBlend in the first place over there. The comment at the top of the function claims the red book says GL_LINE_SMOOTH need "special blending parameters", but the copy I've got says no such thing. The closest I could find was "The blending factors you most likely want to use are GL_SRC_ALPHA (source) and GL_ONE_MINUS_SRC_ALPHA (destination)." It also explicitly mentions GL_ONE as a possible alternative for the destination. MSDN also doesn't specify a specific way of antialiasing. Either way, I think we'd rather have correct blending parameters than correctly aliased lines, if we'd have to make a choice between the two.

1 0

Re: [PATCH try2 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.
by James Hawkins 12 Jun '07

12 Jun '07

On 6/11/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > Changes from previous version in patch 1: > * Comments to explain why this conformance test cannot be quite standard - see Notes comment @ beginning > * Try A function first - I decided that since the A function works on Win98 but not WinXP it is the one > "broken" (reminder: W works on XP but not 98) > * Added asserts in helper _InstallHinfSection function to verify A/W function pointers to make sure that > in the future useW is not misassigned (currently it is assigned properly in START_TEST(install) section as > it was in previous version). > * Changed test_install to ok_install to make its purpose more clear. Specifically, the idea is that > ok_install does the actual install and checks that everything is installed properly, whereas > test_InstallHinfSection allows us to try using the _InstallHinfSection functions (through ok_install) in > various ways to test effects of parameters on the installation (e.g., see patch 2) > * Use property of the "stub" functions of not changing last error to determine which function is stub instead > of using registry checks > > Hopefully this patchset is clearer. > This would still be clearer and more efficient if you set up a function pointer at the beginning of the tests, and just use that function for the rest of the tests. You make a helper function that tests which version (A or W) works, and assign the working version to the function pointer. This way, you don't have to deal with a useW variable, or any of that mess, and other people can write direct tests without having to use ok_install (which really shouldn't be needed if you use a function pointer). Keep in mind you'll have to use void pointers for the string parameters when declaring the function pointer type. -- James Hawkins

2 3

Can we start/stop services in conformance tests?
by Misha Koshelev 12 Jun '07

12 Jun '07

Just wondering. It seems like I can avoid message boxes easily by using a CHT hook, but the Beep() that this particular message box uses can only be disabled with the ControlService/StartService combo. Can I use this in a non-service conformance test, or is it too much to assume that the person running the tests has administrator access (or am I allowed to check for this and simply skip the relevant tests if they don't)? I would assume as long as I am turning the service (beep) back on afterwards if it is on before and check for administrator rights this would be okay? Thanks Misha

1 0

Re: Alexandre Julliard : winecfg: Fix potential null pointer access ( spotted by Yaroslav Skorokhodov).
by Vitaly Lipatov 12 Jun '07

12 Jun '07

В сообщении от 12 июня 2007 Alexandre Julliard написал(a): ... > @@ -107,7 +107,7 @@ static void update_comboboxes(HWND dialog) > winver = get_reg_key(config_key, keypath(""), "Version", ""); What wrong with call get_reg_key (,,,NULL) ? Why we need winver as NULL pointer and as empty string? > ver = get_registry_version(); > > - if (*winver == '\0') > + if (!winver || !winver[0]) > { > HeapFree(GetProcessHeap(), 0, winver); -- Lav Виталий Липатов Россия, Санкт-Петербург. www.etersoft.ru GNU! ALT Linux Team! WINE! WIKI! LaTeX! LyX!

2 1

Re: [GDI+: 4/10] graphics test
by Alexandre Julliard 12 Jun '07

12 Jun '07

"Evan Stade" <estade(a)gmail.com> writes: > + wndClass.lpszClassName = TEXT(ClassName); > + > + if(!RegisterClassA(&wndClass)) return FALSE; This is broken, TEXT() doesn't work on a variable name, and it's useless since you call the A function anyway. Please don't use any of the ugly TCHAR macros in tests, there's no need for them. Either A/W doesn't matter and you can simply use plain Ascii strings, or it does matter and then you have to explicitly test both cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

opengl conversation on irc
by Dan Kegel 11 Jun '07

11 Jun '07

A bunch of folks just had an interesting discussion about the OpenGL problem on irc. I and Roderick saved a log of the conversation, one per room: http://kegel.com/wine/opengl-wine-chat1.html (the original #winehackers discussion) http://roderick.student.utwente.nl/xorg-devel.log (after it moved to #xorg-devel) Roderick gets back from vacation July 22nd or so, and said he expects not only a nice writeup on WWN but also a full implementation by then :-) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: rsaenh: AcquireContext can have multiple flags defined at the same time
by Mounir IDRASSI 11 Jun '07

11 Jun '07

Hi, Your patch is wrong: the flags CRYPT_NEWKEYSET and CRYPT_VERIFYCONTEXT can't be mixed and if they are set together like in your patch AcquireContext should return NTE_BAD_FLAGS. You can check that using the MS implementation under windows. It's also clearly stated in MSDN that CRYPT_VERIFYCONTEXT is reserved for non persistent operations which is not the case when you create a new container. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Maarten Lankhorst wrote: > According to msdn a combination of flags are set, since I'm not sure > which combo's are valid I put up a FIXME. > > ------------------------------------------------------------------------ > >

2 3

Bugzilla is still annoying
by Scott Ritchie 11 Jun '07

11 Jun '07

What was the status on the offer to upgrade bugzilla? Lately I've been annoyed by how it sends out emails whenever someone subscribes/unsubscribes from a bug. Is this a simple configuration setting, or do we need to upgrade? Thanks, Scott Ritchie

2 1

Re: [GDI+: 2/5] added Pens implementation, test
by Alexandre Julliard 11 Jun '07

11 Jun '07

"Evan Stade" <estade(a)gmail.com> writes: > Hi, > > Changelog: > *added pen implementation > *added just enough memory and startup implementation to support pens > *defined some types > *added pen test You need to send that stuff in smaller chunks, for instance there's no reason to put startup implementation and pens in the same patch. Also things like the GpBrush definition should be part of the brush patch not the pen one. The tests can also be a separate patch. I'll commit the startup code part of the patch, have a look at this to see what a minimal patch should look like. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.
by James Hawkins 11 Jun '07

11 Jun '07

On 6/10/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > Tested on WinXP and Win98 (and of course wine). > --- > dlls/setupapi/tests/Makefile.in | 1 + > dlls/setupapi/tests/install.c | 152 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 153 insertions(+), 0 deletions(-) > +static void test_install(LPCSTR filename) +{ + char cmdline[MAX_PATH * 2]; + LONG ret; + + sprintf(cmdline, "DefaultInstall 128 %s\\%s", CURR_DIR, filename); + + if (useW == -1) + { + HKEY hkey; + useW = 1; + _InstallHinfSection(NULL, NULL, cmdline, 0); + if (RegOpenKey(HKEY_CURRENT_USER, "Software\\Wine\\setupapitest", &hkey) == ERROR_SUCCESS) + RegCloseKey(hkey); + else + { + skip("InstallHinfSectionW is broken, using InstallHinfSectionA\n"); + useW = 0; + _InstallHinfSection(NULL, NULL, cmdline, 0); + } + } + else _InstallHinfSection(NULL, NULL, cmdline, 0); + + ret = RegDeleteKey(HKEY_CURRENT_USER, "Software\\Wine\\setupapitest"); + ok(ret == ERROR_SUCCESS, "Expected registry key Software\\Wine\\setupapitest to exist, RegDeleteKeyA returned %d\n", ret); +} + +static void test_InstallHinfSection(void) +{ + create_inf_file(inffile); + test_install(inffile); + ok(DeleteFile(inffile), "Expected source inf to exist, last error was %d\n", GetLastError()); +} This would be much simpler if you didn't use the extra test_install function. What is the point of that? Unit test functions should be atomic. Each test function should create the files it needs, and make sure the files it created are cleaned up by the end of the function (replace files with registry keys, etc). You can also look at it like this: you should be able to remove test function x without affecting any other tests, which is not the case here. The check for DeleteFile would obviously fail. Unit tests should be clear and easy to understand what's being tested, and honestly, this code confused me on my first reading. + _InstallHinfSection(NULL, NULL, cmdline, 0); Why aren't you checking the return value, or GetLastError? + skip("InstallHinfSectionW is broken, using InstallHinfSectionA\n"); How is it broken? This needs to be clarified with a comment. You really should just test only the A function in the first place though. + if (pInstallHinfSectionW && !pInstallHinfSectionA) useW = 1; Is there ever a time when InstallHinfSectionA doesn't exist? If it doesn't exist, you're going to crash if InstallHinfSectionW is 'broken': + skip("InstallHinfSectionW is broken, using InstallHinfSectionA\n"); + useW = 0; + _InstallHinfSection(NULL, NULL, cmdline, 0); -- James Hawkins

2 2

Re: [GDI+: 3/5] added graphics implementation and tests
by Dmitry Timoshkov 11 Jun '07

11 Jun '07

"Evan Stade" <estade(a)gmail.com> wrote: > +GpStatus WINGDIPAPI GdipDrawLineI(GpGraphics *graphics, GpPen *pen, INT x1, > + INT y1, INT x2, INT y2) > +{ > + HGDIOBJ old_obj; > + > + if(!pen || !graphics) > + return InvalidParameter; > + > + old_obj = SelectObject(graphics->hdc, pen->gdipen); > + MoveToEx(graphics->hdc, x1, y1, NULL); > + LineTo(graphics->hdc, x2, y2); > + SelectObject(graphics->hdc, old_obj); > + > + return Ok; > +} > + > +GpStatus WINGDIPAPI GdipDrawRectangleI(GpGraphics *graphics, GpPen *pen, INT x, > + INT y, INT width, INT height) > +{ > + LOGBRUSH lb; > + HPEN hpen; > + HGDIOBJ old_obj; > + > + if(!pen || !graphics) > + return InvalidParameter; > + > + lb.lbStyle = BS_SOLID; > + lb.lbColor = pen->color; > + lb.lbHatch = 0; > + > + hpen = ExtCreatePen(PS_GEOMETRIC | PS_ENDCAP_SQUARE, (INT) pen->width, > + &lb, 0, NULL); Any reason why are you creating a new pen in GdipDrawRectangleI, and while using an existing one in GdipDrawLineI? -- Dmitry.

2 2

Re: [GDI+: 5/5] Added GdipFillPie
by Dmitry Timoshkov 11 Jun '07

11 Jun '07

"Evan Stade" <estade(a)gmail.com> wrote: > +GpStatus WINGDIPAPI GdipFillPie(GpGraphics *graphics, GpBrush *brush, REAL x, > + REAL y, REAL width, REAL height, REAL startAngle, REAL sweepAngle) > +{ > + LOGBRUSH lb; > + HPEN hpen; > + HGDIOBJ old_pen, old_brush; > + REAL x_0, y_0, radStartAngle, radFinishAngle, hypotenuse, > + x_1, y_1, x_2, y_2; > + > + if(!brush || !graphics) > + return InvalidParameter; > + > + lb.lbStyle = BS_SOLID; > + lb.lbColor = brush->color; > + lb.lbHatch = 0; > + > + hpen = ExtCreatePen(PS_GEOMETRIC | PS_ENDCAP_SQUARE, 1, &lb, 0, NULL); > + > + old_pen = SelectObject(graphics->hdc, hpen); > + old_brush = SelectObject(graphics->hdc, brush->gdibrush); GdipFillPie takes only a brush in its parameters, not a pen. Shouldn't you simply select GetStockObject(NULL_PEN) instead of creating a 1 pixel pen with a color of brush? -- Dmitry.

2 1

RE: [PATCH] dinput: Use window subclassing to monitor focus looses away from monitored windows. [try 3]
by Vitaliy Margolen 10 Jun '07

10 Jun '07

Please don't apply this and other dinput patches. It doesn't work for multiply acquired windows. This approach does not handle "nesting" - when same window is being acquired several times by different devices. I guess I will have to go back to WINDPROC hook after all. Vitaliy.

1 0

Re: [PATCH 3/3] winex11.drv: Use new mouse grabbing code for ddraw.
by Stefan Dösinger 10 Jun '07

10 Jun '07

Am Sonntag, 10. Juni 2007 02:15 schrieb Vitaliy Margolen: > Remove old code that is not thread safe. > --- > dlls/winex11.drv/x11ddraw.c | 50 > +------------------------------------------ 1 files changed, 1 > insertions(+), 49 deletions(-) The ddraw code in winex11.drv isn't called from anywhere afaik, and alexandre doesn't really like it to I planned to remove it somewhen.

1 0

makedep problem on mingw
by Steven Edwards 09 Jun '07

09 Jun '07

Hi, I won't have a chance to follow up on this until Wednesday but maybe someone can spot the problem before then. Doing a normal checkout and configure on mingw works fine but the generated makefile in wine/tools/ seems to have a problem with the dependency tracking. Maybe the recent makedep changes and windows don't agree. $ make ../tools/makedep -C. -S.. -T.. bin2res.c fnt2bdf.c fnt2fon.c make_ctests.c make dep.c relpath.c sfnt2fnt.c Makefile:423: *** unterminated variable reference. Stop. Attached is the buggy Makefile Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re:user32:tests:msg Add test for switch mdi children.[try2] What is wrong with it?
by Anatoly Lyutin 09 Jun '07

09 Jun '07

Subject. Thanks for attention. -- Best regards Anatoly Lyutin.

2 1

Re: [5/5] WineD3D: Some render target->texture blit context handling
by H. Verbeet 09 Jun '07

09 Jun '07

On 08/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > + ActivateContext(This, src_surface, CTXUSAGE_RESOURCELOAD); > + if (GL_SUPPORT(ARB_MULTITEXTURE)) { > + GL_EXTCALL(glActiveTextureARB(GL_TEXTURE0_ARB)); > + checkGLcall("glActiveTextureARB"); > + } > + IWineD3DDeviceImpl_MarkStateDirty(This, STATE_SAMPLER(0)); > + IWineD3DSurface_PreLoad(dst_surface); Why do you need this? The surface should be preloaded in attach_surface_fbo as soon as it's attached. Also, although stretch_rect_fbo() is currently only used for onscreen -> texture blits, it should not be limited to that, so I think the ActivateContext should be further down inside both the "if (src_swapchain)" and "if (dst_swapchain)" blocks.

2 4

Using [GS]etWindowLong{Ptr} in tests
by Saulius Krasuckas 08 Jun '07

08 Jun '07

Hello. I see some tests call [GS]etWindowLongPtr(..., GWLP_WNDPROC, ...). I think this is somewhat confusing. API offers both A- an W- versions of this function, while at my first glance I cannot firmly decide, what used name does refer to. Shouldn't occurences be renamed to ...WindowLongPtrA() here (or even all occurrences {by not requiring second parameter == GWLP_WNDPROC}) ? Same question stands for [GS]etWindowLong().

4 16

zip folders support
by Alexander Shabanov 08 Jun '07

08 Jun '07

Good day, First of all: big thank you for your great wine! Several days ago I made a post on the wine groups: > Does anyone tried to use zip folders support on wine? Is is possible? > I tried to copy zipfldr.dll and register it, but it does not work. > Since I am a developer I would try to do it. Could you please suggest > a point to start? As far as I know the interfaces of zipfldr.dll are > not documented, so it will not be simple task. I would like to ask you about an interfaces of zip folder dynamic library - if they're known I would implement zip folders support. It was suggested to ask someone from wine development team to get more information about that. Please, take a look to the discussion in the wine group about that: http://groups.google.com/group/comp.emulators.ms-windows.wine/browse_thread… If you have an information about zip folders please let me know. btw: maybe an implementation of the such support is prohibited on Linux due to some restrictions with LZW algorithm? Or maybe Microsoft did not care about documenting this library? Unfortunately I am not found any information about this library in MSDN in the topics for developers. Thanks in advance and kind regards, Alexander Shabanov

2 1

Re: zip folders support
by Juan Lang 08 Jun '07

08 Jun '07

Hi Alexander, as you say in the quoted thread, > zip filder support is encapsulated within zipfldr.dll which is > standard COM-component (i.e. exposes DllRegisterServer/ > DllCanUnloadNow). > For example in WinXP zip folders support may be switched off by > unregistering zipfldr.dll via regsvr32. > Therefore I may suspect that this support is given on the user (shell > only) level, because CreateFile can't be applied to the files within > zip folder You're correct, zipfldr.dll only register shell extension. As such, it's probably of limited use in Wine, as we really only use the shell for file dialogs - we don't implement an "explorer" that browses the shell namespace. So, may I ask: what app requires such a thing? And you say: > I tried to copy zipfldr.dll and register it, but it does not work. What exactly doesn't work? This probably best captured as a bug, by the way. Enter a bug describing what you expect to happen, what doesn't happen, etc. --Juan ____________________________________________________________________________________ Pinpoint customers who are looking for what you sell. http://searchmarketing.yahoo.com/

1 0

Re: shell32: conformance tests for unicode filenames and fix a bug forfile deletion (try 2)
by Dmitry Timoshkov 08 Jun '07

08 Jun '07

"Nigel Liang" <ncliang(a)gmail.com> wrote: > +static const WCHAR UNICODE_PATH[] = {'c',':','\\','w',0x00ef,0x00f1,0x00eb, > + 't',0x00e8,'s','t','\0','\0'}; /* "c:\winetest" */ The name above is definitely not "c:\winetest", also if you need a double termination '\0' state it specifically. > +static int IsWin9x(void) > +{ > + OSVERSIONINFO winver; > + GetVersionEx(&winver); > + return winver.dwPlatformId==VER_PLATFORM_WIN32_WINDOWS; > +} (GetVersion() & 0x80000000) is much shorter way to detect win9x, but if you need to test whether the platform supports unicode that's wrong, have a look at other tests how it's done there. -- Dmitry.

3 5

Re: [NTDLL] Simple test suite for IO completion APIs
by Alexandre Julliard 08 Jun '07

08 Jun '07

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > Depends on previous NTDLL patch ('cause it uses previously stubbed out api) > > --- > dlls/ntdll/tests/Makefile.in | 1 + > dlls/ntdll/tests/completion.c | 212 > +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 213 insertions(+), 0 deletions(-) Please merge that code with the other async I/O tests in file.c. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] wined3d: For ps_2_0 and higher, call shader_get_registers_used() in IWineD3DPixelShaderImpl_SetFunction
by Stefan Dösinger 08 Jun '07

08 Jun '07

Am Donnerstag, 7. Juni 2007 23:52 schrieb H. Verbeet: > For pre-2.0 pixel shaders the stateblock is used to determine the > sampler types, so we need to wait until CompileShader to do this. For > ps_2_0 and higher there is no such requirement. > > Changelog: > - For ps_2_0 and higher, call shader_get_registers_used() in > IWineD3DPixelShaderImpl_SetFunction Are you going to compile >= 2.0 shaders in SetFunction? How would that work with other things that may need delayed compilation, like fog or (future) srgb write correction?

2 2

Re: gdiplus: added stub implementation of gdiplus.dll
by Mounir IDRASSI 08 Jun '07

08 Jun '07

Hi, You also have to modify other files in order to integrate your stub implementation to the wine build chain: Makefile.in, configure and configure.ac in the wine root directory, Makefile.in in the "dlls" directory. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Evan Stade wrote: > Changelog: > * added stub implementation of gdiplus.dll (3 files) > > dlls/gdiplus/Makefile.in | 16 + > dlls/gdiplus/gdiplus.c | 45 +++ > dlls/gdiplus/gdiplus.spec | 609 > +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 670 insertions(+), 0 deletions(-)

6 7

FYI: SHELL_ArgifyW and unquoted %1, non-native behavior
by Misha Koshelev 08 Jun '07

08 Jun '07

Sorry if I am just filling your inboxes, but I thought I'd at least throw this out there before I forget about it. When I was making my ShellExecute DDE conformance tests to get Vector NTI associated files to open correctly (using DDE and without the fake "%1" that wine was adding to all shell/?/command strings that don't have one at the time), I noticed another non-native behavior in wine. Specifically, when %1 is in a command or a ddeexec string on Windows (XP), the filename is passed as is. However, under wine quotes are added to this argument in SHELL_ArgifyW. Since this did not affect anything Vector NTI related, I decided to just not worry about this behavior at the time and just to change my conformance test so it wouldn't tickle this. However, I am just wondering what the general policy is about something like this? Should it just be left alone until an app is found that somehow depends on this (I am thinking this is the case)? Or do we want to try to correct this when we discover this, that way perhaps preventing this bug in this application from ever even occuring? Thanks Misha

1 0

Re: ole32: Remove stack-based string buffer inFileMonikerImpl_DecomposePath
by Dmitry Timoshkov 07 Jun '07

07 Jun '07

"Ulrich Czekalla" <ulrich.czekalla(a)utoronto.ca> wrote: > - WCHAR word[MAX_PATH]; > - int i=0,j,tabIndex=0; > + LPOLESTR word; > + int i=0,j,tabIndex=0, ret=0; > LPOLESTR *strgtable ; > > int len=lstrlenW(str); > > TRACE("%s, %p\n", debugstr_w(str), *stringTable); > > - strgtable =CoTaskMemAlloc(len*sizeof(LPOLESTR)); > + strgtable = CoTaskMemAlloc(len*sizeof(LPOLESTR)); > > if (strgtable==NULL) > return E_OUTOFMEMORY; > > + word = CoTaskMemAlloc((len + 1)*sizeof(LPOLESTR)); Shouldn't it be *sizeof(WCHAR) or *sizeof(OLECHAR)? -- Dmitry.

2 1

Could somebody run the wininet/ftp tests on Wine?
by Paul Vriens 07 Jun '07

07 Jun '07

Hi, Some time ago I added some ftp-tests. After I've seen a lot of wininet patches I just tried (current GIT) to run the ftp tests again on Wine. This time I get some failure (or actually successes): [paul@LatitudeC600 tests]$ make ftp.ok ../../../tools/runtest -v -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so ftp.c && touch ftp.ok ftp.c:303: Test succeeded inside todo block: Expected ERROR_SUCCESS, got 0 ftp.c:363: Test succeeded inside todo block: Expected ERROR_SUCCESS, got 0 ftp.c:375: Test succeeded inside todo block: Expected ERROR_SUCCESS, got 0 ftp.c:485: Test failed: Expected FtpOpenFileA to succeed ftp.c:858: Test succeeded inside todo block: Expected ERROR_SUCCESS or ERROR_FILE_NOT_FOUND (win98), got 0 ftp: 128 tests executed (14 marked as todo, 5 failures), 0 skipped. make: *** [ftp.ok] Error 5 The strange thing is that the calls fail yet the last error is set to ERROR_SUCCESS. Can somebody confirm? Cheers, Paul.

2 2

Re: cmd:Ru:Update Russian translation.[try2][fixed]
by Kirill K. Smirnov 07 Jun '07

07 Jun '07

> >> + WCMD_YES, "Д" > >> + WCMD_NO, "Н" > > > > Answers to "Yes/No" question should not be translated, should they? "All" > > too. > > I think that should translate this answers because in some languages > such as Norwegian,German and Korean it was translated. > I really doesn`t understand why in Russian language this answers should > not to be translated. In windows they are not translated. Moreover, it is inconvenient to switch to Russian, press 'Д' ('Н'), then switch to English. It may be better if we allow to use translated and untranslated answers simultaneously. AFAIK it is allowed to use translated only. -- Kirill

1 0

Re: cmd:Ru:Update Russian translation.[try2][fixed]
by Kirill K. Smirnov 07 Jun '07

07 Jun '07

Hi, Anatoly! The translation is still very raw. Please, verify it. >+ WCMD_YES, "Д" >+ WCMD_NO, "Н" Answers to "Yes/No" question should not be translated, should they? "All" too. >+ WCMD_NOASSOC, "Файл, ассоциированный с расширением %s,отсутствует\n" This phrase does not sound Russian. "Отсутствует сопоставление для расширения %s" will be better. and so on... -- Kirill

3 2

Re: wininet: Make the passive mode response check case insensitive.
by Francois Gouget 07 Jun '07

07 Jun '07

On Wed, 6 Jun 2007, Hans Leidekker wrote: [...] > Changelog > Make the passive mode response check case insensitive. --- a/dlls/wininet/ftp.c +++ b/dlls/wininet/ftp.c [...] - if (strncmp(p, "Entering Passive Mode", 21)) + if (strncasecmp(p, "Entering Passive Mode", 21)) You should not be using str*casecmp() in Wine (because it's a Unix function, and because it uses the wrong locale). Try CompareString() instead. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: the choice of a GNU generation

3 2

Re: avifil32: remove 'recursive registry key delete' function
by Detlef Riekenberg 07 Jun '07

07 Jun '07

On Do, 2007-06-07 at 00:00 +0200, Stefan Leichter wrote: Replacing recursive_delete_key with RegDeleteTree is not the same. As Example: > - res = recursive_delete_keyA(HKEY_CLASSES_ROOT, > list->progid); > + res = RegDeleteTreeA(HKEY_CLASSES_ROOT, list->progid); > if (res != ERROR_SUCCESS) goto error_close_coclass_key; When the Initial RegOpenKey failed, RegDeleteTree is returning ERROR_FILE_NOT_FOUND and the codepath went to the error-label, but the old recursive_delete_keyA returned ERROR_SUCCESS. See this removed Line from recursive_delete_keyA/W: - if (res == ERROR_FILE_NOT_FOUND) return ERROR_SUCCESS; This additional change should work: if ((res != ERROR_SUCCESS) && (res != ERROR_FILE_NOT_FOUND)) { goto error_close_coclass_key; } Thanks -- By by ... Detlef

1 0

Re: wined3d [1/5]: Add GL_EXT_texture_sRGB constants and corresponding CheckDeviceFormat query
by Phil Costin 07 Jun '07

07 Jun '07

Stefan Dösinger wrote: > Am Donnerstag, 7. Juni 2007 01:03 schrieb Phil Costin: >> Adds necessary GL constants and allows the application to query whether a >> particular texture format is compatible with sample-time texture >> linearization. > Ideally you shouldn't enable the srgb formats in this patch already, but > rather in 4/5, but since the current code returns WINED3D_OK this is an > unimportant detail. Well, originally I did but you advised me to move it to patch 1 so I did :) Regards, Phil

2 1

Re: cmd:Ru:Update Russian translation.[try2][fixed]
by Kirill K. Smirnov 07 Jun '07

07 Jun '07

> I think original phrase "Файл, ассоциированный с > расширением %s,отсутствует\n" is better (but there is a typo in it - > missing space after second ","). And word "ассоциированный" do sounds like > Russian (and has frequent use in books and speech), and I like it more than > less familiar (to me) word "сопоставление". So I think word "сопоставление" > maybe only good choice if Wine already using it instead of word > "ассоциированный" (I'm not sure about this because I'm using English > interface with Wine). (Just a note: Russian is my native language). > Anyway, in my opinion such discussion "what synonym is better" is > pointless because it is just a matter of personal taste. I do not mean "ассоциированный" и "сопоставление" synonyms. Prase "Файл, ассоциированный с расширением %s, отсутствует" is invalid. File never is associated with extension. Program is associated. And not "File" is absent, but "File association" - "Сопоставление файлов" ("сопоставление расширений файлов соответствующим программам"). I do not have anything against synonym "ассоциированный". -- Kirill

2 1

Adding support for both wine_gecko and Mozilla ActiveX.
by Andrew Riedi 07 Jun '07

07 Jun '07

A lot of users would enjoy an option between installing wine_gecko and Mozilla ActiveX. Would it be very difficult to add a little dialogue box or registry key to toggle between the two? Is there a better way? If it is too difficult or will slow down work on eg. MSHTML and the like, don't worry about it. Anyhow, regardless of response, thanks for your work. :) -- Andrew Riedi

1 0

Re: wined3d [2/5]: Extend the D3DFMT table to include gamma corrected formats
by Stefan Dösinger 06 Jun '07

06 Jun '07

Am Donnerstag, 7. Juni 2007 01:05 schrieb Phil Costin: > Extend the D3DFMT table to include gamma corrected formats. This patch(and 3 and 4) look good to me on a quick check.

1 0

Re: wined3d [1/5]: Add GL_EXT_texture_sRGB constants and corresponding CheckDeviceFormat query
by Stefan Dösinger 06 Jun '07

06 Jun '07

Am Donnerstag, 7. Juni 2007 01:03 schrieb Phil Costin: > Adds necessary GL constants and allows the application to query whether a > particular texture format is compatible with sample-time texture > linearization. Ideally you shouldn't enable the srgb formats in this patch already, but rather in 4/5, but since the current code returns WINED3D_OK this is an unimportant detail.

1 0

Re: d3d9/tests [5/5]: Test CheckDeviceFormat returns correctly for D3DUSAGE_QUERY_SRGBREAD queries
by Stefan Dösinger 06 Jun '07

06 Jun '07

Am Donnerstag, 7. Juni 2007 01:16 schrieb Phil Costin: > Test CheckDeviceFormat returns correctly for D3DUSAGE_QUERY_SRGBREAD > queries. This test will fail on any card that doesn't support sRGB at all. What would be more useful is to find out what assertion hl2 makes, ie if D3DFMT_X8R8G8B8 is supported, then D3DFMT_L8 and D3DFMT_A8L8 are supported too. No idea how this really looks like. Another idea would be to set up a table of formats that are found supported on some cards, and complain if a format that is known NOT to be supported(like Q8W8V8U8) is found supported - see the query test for an example.

1 0

wined3d: Void functions should not return a value
by Andrew Talbot 06 Jun '07

06 Jun '07

Please note: I set the indentation of some amended lines to match that in the majority of the surrounding functions. -- Andy.

1 0

Re: cmd:builtints.c Fix convert from lower case to upper case
by Juan Lang 06 Jun '07

06 Jun '07

This appears to be missing the patch. --Juan ____________________________________________________________________________________ Need a vacation? Get great deals to amazing places on Yahoo! Travel. http://travel.yahoo.com/

1 0

Re: [patch 2] mshtml: Added support for coexisting different Gecko versions installation.
by Alexandre Julliard 06 Jun '07

06 Jun '07

Jacek Caban <jacek(a)codeweavers.com> writes: > - /* @@ Wine registry key: HKCU\Software\Wine\MSHTML */ > - res = RegOpenKeyW(HKEY_CURRENT_USER, wszMshtmlKey, &hkey); > + memcpy(mshtml_key, wszMshtmlKey, sizeof(wszMshtmlKey)); > + MultiByteToWideChar(CP_ACP, 0, GECKO_VERSION, -1, > + mshtml_key+sizeof(wszMshtmlKey)/sizeof(WCHAR), -1); Please pass the correct dest buffer size, not -1. > + GetEnvironmentVariableA("windir", install_dir, sizeof(install_dir)); GetWindowsDirectory is preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING
by James Hawkins 05 Jun '07

05 Jun '07

On 6/5/07, Jens Nestler <jn(a)nessi-online.de> wrote: > http://bugs.winehq.org/show_bug.cgi?id=8551 > > Hello, > > please find attached the patch for the bug mentioned above. > > Jens Nestler > The bug also has a test case that needs to be integrated into the Wine test suite and submitted to wine-patches. -- James Hawkins

1 0

Re: OpenGL 2.3 to 3.0
by Matthew Clark 05 Jun '07

05 Jun '07

Ah this makes perfect sense and is exactly what I was looking for, thank you for your response! My limited understanding from the article was that 2.3 was simply cleanup and putting some extensions in the official API that have been in drivers for a while just not in the official API and then 3.0 is where the real change will be, BUT that it will only activate the 3.0 functionality if it's on supporting hardware(i.e. DX10 cards). Please correct me if my understanding is incorrect and again I think we all realize this is all in the future and is just fun to talk about^_^ Thanks for all THE fish, -Matt PS Yes I am an idiot some times =P > > Stefan Dösinger wrote: >> We are waiting for the final API before deciding if we like it or not. But >> from what I've read so far the changes make sense. >> >> My concern is backwards compatiblity. For dx 1 to dx9 we will still need the >> old apis. For one part because the new api may not offer fixed function >> functionality, but more importantly because old cards will most likely not >> see any driver updates. >> >> If the interface is vastly different we'll need 2 d3d implementations, one >> wrapping to old gl and one for the new version. An idea would be to just >> leave dx1 to 9 with gl 2.0 and write dx10 only for opengl 3.0. >> >> If the new API allows it however, we want to keep the wine code unified. This >> could happen by simply duplicating very specific functions which are >> different, and then select them at creation time by choosing a different >> virtual function table. If we need an if condition for every opengl call we >> do it would be pointless to keep everything in one lib. >> >> But we need to know the final opengl 3.0 API to decide what to do. >> > >

2 1

OpenGL 2.3 to 3.0
by Matthew Clark 05 Jun '07

05 Jun '07

I was reading the other day about the 2.3 and 3.0 versions of the OpenGL API coming out this year( http://www.theinquirer.net/default.aspx?article=39846 ) and the first thought I had was wine and DX10. I was wondering what you guys thought about this, are you excited(as I am)? are you hesitant? Knowing OpenGL it shouldn't be hard at all to port the code over, but are there plans already or are the plans to wait till it's in our faces to worry about it? Sorry for the tangent but I was just curious to hear what you guys had to say about this.^_^ Thanks for all fish, -Matt

2 1

Re: OpenGL 2.3 to 3.0
by Stefan Dösinger 05 Jun '07

05 Jun '07

Am Dienstag, 5. Juni 2007 22:17 schrieb Matthew Clark: > Ah this makes perfect sense and is exactly what I was looking for, thank > you for your response! My limited understanding from the article was > that 2.3 was simply cleanup and putting some extensions in the official > API that have been in drivers for a while just not in the official API > and then 3.0 is where the real change will be, BUT that it will only > activate the 3.0 functionality if it's on supporting hardware(i.e. DX10 > cards). Please correct me if my understanding is incorrect and again I > think we all realize this is all in the future and is just fun to talk > about^_^ They're takling more about codenames rather than 2.3 and 3.0, but I don't know the names currently. 2.3 will have all the functionality of 3.0 and be fully backwards compatible. This means you can use very old things together with the very new stuff. The drawback will be that you don't get the performance improvements of 3.0. This is somehow like d3d9. with d3d9.dll you can use the new d3d9 features, those will work on d3d9 cards only. But you can also use d3d9.dll to write an app that uses only dx7(or even earlier) level features, and those apps will run on dx7 cards - an example for that is the Source engine in hl2. 3.0 will be the complete rewrite. You'll have 3.0 only on cards that support it, and afaik you can't use the 3.0 API to program older cards(like a geforce 2 that doesn't even support shaders). This is what happened in d3d10 too. The advantage of the api cleanup is that you get rid of all the legacy stuff. The API is cleaner, drivers are simpler. The code is smaller and runs faster. If you look at wined3d you'll see that it is full of stuff to support even oldest cards(theoretically, in theory unsuccessful). Even though the state management keeps the most of the code sleeping until the app actually uses this features it makes everything more complex. A performance penalty is maybe the GL_EXTCALL stuff, which we use to be able to link against old opengl libs. Calling an address inserted by the dynamic linker at load time would be cheaper than finding a function pointer in a table and calling it.

2 1

Re: widl: Fix the is_array_type function.
by Dan Hipschman 05 Jun '07

05 Jun '07

On Tue, Jun 05, 2007 at 07:50:42PM +0100, Robert Shearman wrote: > > Previously, an array of pointers wouldn't be detected by this function. > --- > tools/widl/header.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/widl/header.h b/tools/widl/header.h > index 57ae6b4..2165db7 100644 > --- a/tools/widl/header.h > +++ b/tools/widl/header.h > @@ -69,7 +69,7 @@ static inline int is_string_type(const a > static inline int is_array_type(const attr_list_t *attrs, const type_t *type, const array_dims_t *array) > { > return ((last_ptr(type) && !array && is_attr(attrs, ATTR_SIZEIS)) || > - (!is_ptr(type) && array)); > + array); > } > > #endif This and your next patch are in the same area as the one I just sent in yesterday. Actually, my patch completely removes this function. Can you try doing whatever you're working on with my last patch applied and see if that fixes your problems? Generating the format string for arrays of pointers is going to required a little more work because FIXED_REPEAT, etc. isn't implemented yet. My last patch set: http://winehq.org/pipermail/wine-patches/2007-June/040007.html http://winehq.org/pipermail/wine-patches/2007-June/040008.html Thanks, Dan

2 2

Re: ADVAPI32: Start test for service tests
by James Hawkins 05 Jun '07

05 Jun '07

On 5/20/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > Changelog > dlls/advapi32/tests/Makefile.in > dlls/advapi32/tests/service.c > Start test for service tests > License: X11/LGPL > > This test will crash without the previous patch > "Return error on NULL service name to GetServiceDisplayNameA/W" > > Rolf Kalbermatter > + ok(size <= 1, "size should be <= 1 was %d!", size); This is a bad test. According to msdn, GetServiceDisplayName does not modify lpcchBuffer on error, so size should be exactly 0. +static BOOL test_service_info(SC_HANDLE hscm) test functions are void, not BOOL. You're never going to do anything but return, and there's no value to check by the caller. + ok(size, "size should be returned!"); And what is the size? Tests are supposed to be exact. If our implementation is incorrect, and we return size as 39491, that's certainly not correct, but this test won't fail when it should. +static BOOL test_service_enum(SC_HANDLE hscm) +{ + return 0; +} Please don't add dead code. -- James Hawkins

3 4

Re: wintrust: implement WintrustGetRegPolicyFlags and WintrustSetRegPolicyFlags
by Saulius Krasuckas 05 Jun '07

05 Jun '07

* On Mon, 14 May 2007, Juan Lang wrote: > > +static const WCHAR Software_Publishing[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'W','i','n','d','o','w','s','\\', > + 'C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\', > + 'W','i','n','t','r','u','s','t','\\', > + 'T','r','u','s','t',' ','P','r','o','v','i','d','e','r','s','\\', > + 'S','o','f','t','w','a','r','e',' ', > + 'P','u','b','l','i','s','h','i','n','g',0 }; > +static const WCHAR State[] = { 'S','t','a','t','e',0 }; > + > /*********************************************************************** > * WintrustGetRegPolicyFlags (WINTRUST.@) > */ > void WINAPI WintrustGetRegPolicyFlags( DWORD* pdwPolicyFlags ) > { > - FIXME("%p\n", pdwPolicyFlags); > + HKEY key; > + LONG r; > + > + TRACE("%p\n", pdwPolicyFlags); > + > *pdwPolicyFlags = 0; > + r = RegCreateKeyExW(HKEY_CURRENT_USER, Software_Publishing, 0, NULL, 0, > + KEY_READ, NULL, &key, NULL); > + if (!r) > + { > + DWORD size = sizeof(DWORD); > + > + r = RegQueryValueExW(key, State, NULL, NULL, (LPBYTE)pdwPolicyFlags, > + &size); > + RegCloseKey(key); This function tries to open Software_Publishing key. And creates it, if the key didn't exist, I suppose. It is absent in a clean $WINEPREFIX. Hence 4 test failures: $ wine dlls/wintrust/tests/wintrust_test.exe.so register register.c:327: Test failed: RegOpenKeyEx failed: 2 register.c:331: Test failed: RegQueryValueEx failed: 6 register.c:334: Test failed: Didn't get expected flags register.c:341: Test failed: Didn't get expected flags register: 43 tests executed (0 marked as todo, 4 failures), 0 skipped. During next run failures are gone, and I get this difference between two registry dumps: +[HKEY_USERS\S-1-5-4\Software\Microsoft\Windows\CurrentVersion\Wintrust] + +[HKEY_USERS\S-1-5-4\Software\Microsoft\Windows\CurrentVersion\Wintrust\Trust Providers] + +[HKEY_USERS\S-1-5-4\Software\Microsoft\Windows\CurrentVersion\Wintrust\Trust Providers\Software Publishing] +"State"=dword:00023c00 So this key should be registered during wineprefix run at some point, right?

2 3

re: Question about tracing a direct pointer call (CryptSIPLoad related)
by Dan Kegel 05 Jun '07

05 Jun '07

Hook the function that returns those pointers, and have your hooked function return hooked function pointers. It's not easy, but I think it would work.

1 0

Question about tracing a direct pointer call (CryptSIPLoad related)
by Paul Vriens 05 Jun '07

05 Jun '07

Hi, I'm currently (still) busy with trying to find out how certain crypt32/wintrust functions behave. One of the functions CryptSIPLoad returns a set of function pointers that maybe are called directly by an application/dll. These direct calls however don't show up in a 'normal' trace. Is there a way to see this direct pointer call with a trace or do I need to start using the debugger? The problem with tracing/debugging this is that there's a lot of calls from wintrust to crypt32 and back again. This means it's hard to put in any traces as a lot of stuff is still stubbed. It would be nice btw (and I don't know if there's more demand for this) to have a function override instead of the whole dll. I know that could be tricky but in some circumstances would help a lot in tracing/debugging. Cheers, Paul.

1 0

Re: Support for iFilter API
by Juan Lang 04 Jun '07

04 Jun '07

Hi Stefan, I finally had a look at this. It looks like filter.h (where the iFilter API is defined) is generated from some IDL source. So you'd want to create your own definition of the .idl file, and generate filter.h using widl. That said, the iFilter interface is only used (in Windows) by the indexing service, which wine currently doesn't implement. So I'm not sure* it really belongs in the wine source. *Caveat: this assumes that wine is mostly about running Windows programs these days, and less about building Windows programs. --Juan ____________________________________________________________________________________ Need Mail bonding? Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users. http://answers.yahoo.com/dir/?link=list&sid=396546091

1 0

mandriva rpm wine 0.9.38
by marco 04 Jun '07

04 Jun '07

As I have still no way to upload the mandriva wine rpm to the official winehq download server. So mandriva users you can download the latest wine binaries here: http://www.xs4all.nl/~meijer2/wine/ kind regard, Marco

2 1

3DMark2001 crashes with wine-0.9.38
by Juergen Wiezorek 04 Jun '07

04 Jun '07

I have just compiled & installed the new wine version on my Fedora Core 5 system (kernel-2.6.20-1.2316-1.fc5) and found that the 3DMark2001 test suite now crashes upon startup, see below enclosure. This has so far never happened with any wine-0.9.x version I've had installed. -- Juergen Wieczorek Hamburg / Germany

2 1

Re: winebrowser: Add DDE support and use DDE by default for shell/open.
by Dmitry Timoshkov 04 Jun '07

04 Jun '07

"Misha Koshelev" <mk144210(a)bcm.edu> wrote: > --- a/tools/wine.inf > +++ b/tools/wine.inf > @@ -134,8 +134,14 @@ HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" > HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" > HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > -HKCR,http\shell\open\command,,2,"winebrowser" > -HKCR,https\shell\open\command,,2,"winebrowser" > +HKCR,http\shell\open\command,,2,"winebrowser /dde" > +HKCR,http\shell\open\ddeexec,,2,"""%1""" > +HKCR,http\shell\open\ddeexec\Application,,2,"WineBrowser" > +HKCR,http\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,https\shell\open\command,,2,"winebrowser /dde" > +HKCR,https\shell\open\ddeexec,,2,"""%1""" > +HKCR,https\shell\open\ddeexec\Application,,2,"WineBrowser" > +HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" Why are you making DDE the default way for the ShellExecute command? That's not the case in the default Windows install. Also please make sure that the items of the Help menu in Picasa still work after your changes, as it was broken several times after attempts to change default registry setup or ShellExecute behaviour. -- Dmitry.

2 4

git is to overwhelming
by RusH 04 Jun '07

04 Jun '07

Maybe im just to stupid for it :( I want to use git to download most current source, try my patches, then to again download most current source. I cant do it. wiki.winehq.org/GitWine doesnt help at all. For example I had wine-0.9.37 fetched, added few patches, compiled it, installed locally, all was fun and games, Now I want to bring my local tree to current level, but cant. I did : rasz@capek:/media/hdc6/home/rasz/source/wine$ git fetch remote: Generating pack... [.....cut.....] 100% (1/1) done * refs/tags/wine-0.9.38: storing tag 'wine-0.9.38' of git://source.winehq.org/git/wine tag: d3ce69c rasz@capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/winecoreaudio.drv/mixer.c: needs update dlls/ws2_32/tests/sock.c: needs update rasz@capek:/media/hdc6/home/rasz/source/wine$ git fetch rasz@capek:/media/hdc6/home/rasz/source/wine$ git rebase origin dlls/winecoreaudio.drv/mixer.c: needs update dlls/ws2_32/tests/sock.c: needs update rasz@capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/winecoreaudio.drv/mixer.c: needs update dlls/ws2_32/tests/sock.c: needs update rasz@capek:/media/hdc6/home/rasz/source/wine$ git checkout -f rasz@capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/winecoreaudio.drv/mixer.c: needs update rasz@capek:/media/hdc6/home/rasz/source/wine$ git reset --hard origin rasz@capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ ANNOUNCE: needs update ChangeLog: needs update VERSION: needs update configure: needs update rasz@capek:/media/hdc6/home/rasz/source/wine$ git fetch rasz@capek:/media/hdc6/home/rasz/source/wine$ git checkout -f rasz@capek:/media/hdc6/home/rasz/source/wine$ git diff rasz@capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/user32/tests/menu.c: needs update rasz@capek:/media/hdc6/home/rasz/source/wine$ git fetch ; git rebase origin dlls/user32/tests/menu.c: needs update and so on and so forth .... my head hurts and i dont understand, why cant it be done with one command? -- Who logs in to gdm? Not I, said the duck.

5 7

Re: Wine fails to start browser
by Misha Koshelev 03 Jun '07

03 Jun '07

> Koshelev, Misha Vladislavo <mk144210 <at> bcm.tmc.edu> writes: > > > If I have time, I may look into how hard it would be to add DDE for > winebrowser (I don't think it should be too bad, but I'll have to check). > > Misha > > > > > Cool! looking forward to that than ;) > > > Actually, I already got something that works, just need to clean it up, add fixes to automatically generate the necessary registry subkeys, and I'll send it in at some point. I had to change winebrowser to not be a console app (although it still writes to stderr so for all intents it kinda is) for the DDE stuff to work properly from ShellExecuteW, but it still seems to work fine on the command line both when passing arguments and when using DDE with wine start (except now if you just call winebrowser you have to wait 5 secs for it to print out a usage as it tries to wait for a DDE, but I don't think there is any way to avoid a delay in seeing the usage statement and both do DDE... unless we add some kind of extra command line parameter for the DDE stuff I guess which I will look into). Misha

1 0

Re: Wine fails to start browser
by Koshelev, Misha Vladislavo 03 Jun '07

03 Jun '07

> Hi, i noticed some kind of regression in current git, for example when i try to start > http://fe.trymedia.com/dm/infogrames/30m_default/t_20em/FreddiKelp.exe , a download manager for the game. With current git i get this: > > Usage: winebrowser URL > > > > That's it, whereas in wine-0.9.34, it opens my firefox fine, at the correct page , and starts to download the game. > > The only solution i found now is again add "%1" to the key HKEY_CLASSES_ROOT\http\shell\open\command\winebrowser, but that "fix' was not acceptable in wine, me was told a few weeks ago. I saw some patches from Misha Koshelev that might be related to this, maybe changing the key is acceptable now, or anyone know another fix? Thx > Never mind, I found more info here: http://bugs.winehq.org/show_bug.cgi?id=7953 I checked on an XP installation with IE and the key there does _not_ have %1 but it has ddeexec subkeys which means it is using DDE to communicate. If I have time, I may look into how hard it would be to add DDE for winebrowser (I don't think it should be too bad, but I'll have to check). Misha

2 1

Re: Wine fails to start browser
by Misha Koshelev 03 Jun '07

03 Jun '07

> Hi, i noticed some kind of regression in current git, for example when i try to start > http://fe.trymedia.com/dm/infogrames/30m_default/t_20em/FreddiKelp.exe , a download manager for the game. With current git i get this: > > Usage: winebrowser URL > > > > That's it, whereas in wine-0.9.34, it opens my firefox fine, at the correct page , and starts to download the game. > > The only solution i found now is again add "%1" to the key HKEY_CLASSES_ROOT\http\shell\open\command\winebrowser, but that "fix' was not acceptable in wine, me was told a few weeks ago. I saw some patches from Misha Koshelev that might be related to this, maybe changing the key is acceptable now, or anyone know another fix? Thx > Well, according to my conformance tests, Windows does not add "%1" by default (see dlls/shell32/tests/shlexec.c, line 1057), so I think this would need to be there in the registry if you want it to start the command line key. Do you remember exactly why people were saying this is bad? Perhaps this had to do with the specific way you were proposing to add this? Thanks Misha

1 0

Wine fails to start browser
by Louis. Lenders 03 Jun '07

03 Jun '07

Hi, i noticed some kind of regression in current git, for example when i try to start http://fe.trymedia.com/dm/infogrames/30m_default/t_20em/FreddiKelp.exe , a download manager for the game. With current git i get this: Usage: winebrowser URL That's it, whereas in wine-0.9.34, it opens my firefox fine, at the correct page , and starts to download the game. The only solution i found now is again add "%1" to the key HKEY_CLASSES_ROOT\http\shell\open\command\winebrowser, but that "fix' was not acceptable in wine, me was told a few weeks ago. I saw some patches from Misha Koshelev that might be related to this, maybe changing the key is acceptable now, or anyone know another fix? Thx --------------------------------- Yahoo! Answers - Got a question? Someone out there knows the answer. Tryit now.

1 0

Support for iFilter API
by Stefan Brüns 03 Jun '07

03 Jun '07

Hi, recently i had a look at the iFilter API. iFilter is an interface to extract text, formatting and various attributes from text like documents (pdf, rtf, html, ...). The actual extraction is done by a format specific plugin which gets registered to the Registry. I started my tests by taking the headers from Visual Studio, and most tests went quite fine, so I have a winelib application which is able to extract text from some proprietary documents. Next, I would like to get rid of the requirement for the headers taken from VS, so my actual question is: How to implement these headers so they can be incorporated into the wine source? As it is just an interface, there are no dlls which have to be implemented. Bye, Stefan -- Stefan Brüns / Kastanienweg 6 - Zimmer 1206 / 52074 Aachen mailto:lurch@gmx.li http://www.kawo1.rwth-aachen.de/~lurchi/ phone: +49 241 169-4206 mobile: +49 160 3797725

1 0

Re: webpage: Update Fedora download information
by Saulius Krasuckas 03 Jun '07

03 Jun '07

* On Sat, 2 Jun 2007, Andreas Bierfert wrote: > here is an upgrade for the fedora download information as I requested on > w-d-l. Hi, your patch isn't in unified fromat. Probably add "-u" option.

1 1

How to determine if something is "debuggable" ... ?
by Marc G. Fournier 03 Jun '07

03 Jun '07

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I realize that that may be an odd question, but I also don't want spend an huge amount of time trying to get something to work that just won't work "at this time" ... I've been asked to get a Windows application running under FreeBSD ... optimally, I'd prefer to do it under Wine, since the last thing I want is a) to buy a Windows License and b) to run Windows when all I need is this one application ... First and foremost, I'm most impressed with how far Wine has come ... I remember back when you needed the Windows OS to do anything ... with current Wine, I was able to run the Setup / Installer for this application, it built my .wine directory, installed everything beautifully ... .. the problem arises when I try and run the app after install ... and the odd thing is that it doesn't appear to actually do anything, it just hangs there, no errors to the screen. I pop'd into IRC and asked about debugging there, and was pointed to the WINEDEBUG=+all setting, which I've since and re-tried to run, without output redirected to a log file ... it very quickly gets to 65M in size and 900k lines ... most of which looks to be looping around the same dozen lines: 0009:trace:seh:call_stack_handlers calling handler at 0x55779e code=c0000005 flags=0 0009:Call msvcrt._except_handler3(0035f8e4,0035fab0,0035f618,0035f54c) ret=9c1a70fd 0009:trace:seh:_except_handler3 exception c0000005 flags=0 at 0x0 handler=0x55779e 0x35f618 0x35f54c semi-stub 0009:trace:seh:_except_handler3 filter = 0x557756 0009:Call msvcrt._XcptFilter(c0000005,0035f400) ret=00557767 0009:trace:seh:_XcptFilter (c0000005,0x35f400) 0009:Ret msvcrt._XcptFilter() retval=00000000 ret=00557767 0009:trace:seh:_except_handler3 filter returned CONTINUE_SEARCH 0009:trace:seh:_except_handler3 reached TRYLEVEL_END, returning ExceptionContinueSearch 0009:Ret msvcrt._except_handler3() retval=00000001 ret=9c1a70fd 0009:trace:seh:call_stack_handlers handler at 0x55779e returned 1 Using grep -n, it looks like starting around like 43k in the log is where this happens, and continues ad finitum: 43048:0009:trace:seh:_except_handler3 exception c0000005 flags=0 at 0x0 handler=0x55779e 0x35f618 0x35f54c semi-stub 43059:0009:trace:seh:_except_handler3 exception c0000005 flags=0 at 0x0 handler=0x55779e 0x35f618 0x35f54c semi-stub 43070:0009:trace:seh:_except_handler3 exception c0000005 flags=0 at 0x0 handler=0x55779e 0x35f618 0x35f54c semi-stub 43081:0009:trace:seh:_except_handler3 exception c0000005 flags=0 at 0x0 handler=0x55779e 0x35f618 0x35f54c semi-stub 43092:0009:trace:seh:_except_handler3 exception c0000005 flags=0 at 0x0 handler=0x55779e 0x35f618 0x35f54c semi-stub 43103:0009:trace:seh:_except_handler3 exception c0000005 flags=0 at 0x0 handler=0x55779e 0x35f618 0x35f54c semi-stub <alot of lines deleted> 917026:0009:trace:seh:_except_handler3 exception c000013a flags=0 at 0x9c0605d7 handler=0x55779e 0x35f128 0x35f06c semi-stub 917037:0009:trace:seh:_except_handler3 exception c000013a flags=0 at 0x9c0605d7 handler=0x55779e 0x35f128 0x35f06c semi-stub 917048:0009:trace:seh:_except_handler3 exception c000013a flags=0 at 0x9c0605d7 handler=0x55779e 0x35f128 0x35f06c semi-stub 917059:0009:trace:seh:_except_handler3 exception c000013a flags=0 at 0x9c0605d7 handler=0x55779e 0x35f128 0x35f06c semi-stub 917070:0009:trace:seh:_except_handler3 exception c000013a flags=0 at 0x9c0605d7 handler=0x55779e 0x35f128 0x35f06c semi-stub Looking at the log just before that loop started (not sure how many lines before is significant), there is: 0009:Call msvcrt._initterm(00575000,0057508c) ret=005576e2 0009:trace:msvcrt:_initterm (0x575000,0x57508c) 0009:trace:msvcrt:_initterm Call init function 0x5578f4 0009:trace:seh:raise_exception code=c0000005 flags=0 addr=0x0 0009:trace:seh:raise_exception info[0]=00000000 0009:trace:seh:raise_exception info[1]=00000000 0009:trace:seh:raise_exception eax=005578f4 ebx=9ca6b678 ecx=00000000 edx=00000038 esi=00575004 edi=0057508c 0009:trace:seh:raise_exception ebp=0035f968 esp=0035f93c cs=0033 ds=003b es=003b fs=1007 gs=001b flags=00010206 The fun part is that I don't know what is important, and what isn't ... if someone would like to see the complete log before the semi-stub errors start to loop, please feel free to ask ... the software I'm trying to run is available as a free download, if someone wishes to actually try the software ... Compared to the graphical games that ppl show listed on AppDB, I would have thought this one would have been simple ... :) How best to proceed? Thank you ... - ---- Marc G. Fournier Hub.Org Networking Services (http://www.hub.org) Email . scrappy(a)hub.org MSN . scrappy(a)hub.org Yahoo . yscrappy Skype: hub.org ICQ . 7615664 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFGYMaY4QvfyHIvDvMRAjYAAKDm/YJ8ExAv/NphfJomp9igJ1CH/gCg0zTK pyudGfNTQ9o8bgorDhcF9MA= =DEaH -----END PGP SIGNATURE-----

5 12

Re: crypt32: remove 'recursive registry key delete' function
by Paul Vriens 03 Jun '07

03 Jun '07

On 6/1/07, Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > ChangeLog > --------- > replace CRYPT_RecurseDeleteKey with RegDeleteTreeW > > > > > Hi Stefan, I don't think that's enough. There's a difference between SHDeleteKeyW and RegDeleteTreeW (see also http://wiki.winehq.org/RecursiveRegistryKeyDelete, but I guess that's a known page to you). Basically you have to remove the key itself as well. Cheers, Paul.

2 2

Re: user32:tests:msg Add test for switch mdi childs
by Dmitry Timoshkov 03 Jun '07

03 Jun '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > +/* Switch visible mdi childs */ Please use the word 'children' to avoid confusion. > + trace("Switch child window.\n"); > + > + ret = SendMessageA(mdi_client, WM_MDIACTIVATE, (WPARAM)mdi_child2, 0); > + ok(!ret, "Child not been deactivate(Switch test)\n"); active_child == mdi_child2, so it's not clear what you try to do in the test above. Besides, you don't check any subsequences of the call. Since below starts another test 'flush_sequence();' should be added before. > + ret = SendMessageA(mdi_client, WM_MDIACTIVATE, (WPARAM)mdi_child, 0); > + > + ok(!ret, "Child not activate(Switch test)\n"); > + > + ok_sequence(WmSwitchChild,"Child not switch correctly\n",TRUE); Again, you don't check any subsequences of the call. Also if you could add comments in the added message sequence what is going on, it will help a lot later figuring out how to make the test pass under Wine. Something along the following lines present in the existing sequences: /* maximize the 1st MDI child */ ... /* restore the 2nd MDI child */ ... { WM_CHILDACTIVATE, sent|defwinproc|wparam|lparam, 0, 0 }, /* in the 1st MDI child */ { WM_NCACTIVATE, sent|wparam|defwinproc, 0 }, /* in the 1st MDI child */ { WM_MDIACTIVATE, sent|defwinproc }, /* in the 1st MDI child */ ... { WM_KILLFOCUS, sent }, /* in MDI client */ { WM_IME_SETCONTEXT, sent|wparam|optional, 0 }, /* in MDI client */ etc. I understand that this is a tedious work, but it should be done. -- Dmitry.

1 0

Re: crypt32: implement CryptSIPLoad (try 5)
by Juan Lang 02 Jun '07

02 Jun '07

> I think it's worth figuring out why native does it like this. Believe me, I've been trying to. I'm only inferring that it should be loaded because using native wintrust calls CryptSIPLoad, and my implementation makes it continue on to call other functions that seem reasonable in that context. I don't know what tests I can write to show that I should not pass the DLL's function pointers directly back to the caller. That might make sense if crypt32 were to try to unload unused function pointers periodically, since the API doesn't provide an unload function - but that seems overly complicated, and I unload them at DLL unload time instead. If you have suggestions on tests I can write, I'm all ears. > Also the dll loading part of the patch is quite confusing, hopefully > doing it closer to the native way would help make it clearer. The complication comes from the fact that the registry allows one to have a separate DLL for each function in a SIP, but CryptAddSIPProvider does not. I therefore fail if the DLL names are different. This allows me to use an HMODULE as the hSIP member of a SIP_DISPATCH_INFO, rather than invent some more complicated scheme. I can add more comments to try to explain that if you like. --Juan ____________________________________________________________________________________ Bored stiff? Loosen up... Download and play hundreds of games for free on Yahoo! Games. http://games.yahoo.com/games/front

3 2

Re: wordpad: (1/6) Split code into set_caption function
by Andrey Turkin 02 Jun '07

02 Jun '07

Alexander Nicolaysen Sørnes wrote: > This will be useful for the file saving code. > > > Regards, > > Alexander N. Sørnes > + WCHAR wszCaption[MAX_PATH]; + + if(wszNewFileName) + { + lstrcpyW(wszCaption, wszNewFileName); + lstrcatW(wszCaption, wszSeparator); + lstrcatW(wszCaption, wszAppTitle); Looks like there are possible buffer overflow

1 0

Re: How to determine if something is "debuggable" ... ?
by Tom Spear 02 Jun '07

02 Jun '07

On 6/1/07, Marc G. Fournier <scrappy(a)hub.org> wrote: Another thing you can _try_, since it looks like it messing up in msvcrt or possibly even dbghelp, is to get msvcrt.dll and dbghelp.dll from a windows install, place them in your wine's c:\windows\system32 folder (usually ~/.wine/drive_c/windows/system32), and then use winecfg to set both dll's to run (native, builtin) for that application.. See if that helps, no guarantees tho, especially since it is FreeBSD. -- Thanks Tom

1 0

GDI+: headers and one test
by Evan Stade 01 Jun '07

01 Jun '07

Changelog: *Added public GDI+ headers in include/ *Added private GDI+ headers in dlls/gdiplus *Added small implementation of GDI+ pens in dlls/gdiplus/pen.c *Added (first) GDI+ test dlls/gdiplus/Makefile.in | 3 + dlls/gdiplus/gdip_defines.h | 43 +++++++++++++++++++ dlls/gdiplus/gdip_enumerations.h | 57 ++++++++++++++++++++++++++ dlls/gdiplus/gdiplus.c | 27 ++++++++++++ dlls/gdiplus/gdiplus.spec | 8 ++-- dlls/gdiplus/gdiplus_private.h | 43 +++++++++++++++++++ dlls/gdiplus/pen.c | 84 ++++++++++++++++++++++++++++++++++++++ dlls/gdiplus/pen.h | 30 ++++++++++++++ dlls/gdiplus/tests/Makefile.in | 13 ++++++ dlls/gdiplus/tests/pen.c | 44 ++++++++++++++++++++ include/Gdiplus.h | 10 +++++ include/GdiplusEnums.h | 39 ++++++++++++++++++ include/GdiplusFlat.h | 23 ++++++++++ include/GdiplusGpStubs.h | 10 +++++ include/GdiplusInit.h | 26 ++++++++++++ include/GdiplusTypes.h | 7 +++ 16 files changed, 462 insertions(+), 5 deletions(-) -Evan Stade

6 5

Re: Added GDI+ public headers, small implementation of pen, memory and initialization, and two tests (2nd try)
by Detlef Riekenberg 01 Jun '07

01 Jun '07

On Do, 2007-05-31 at 18:02 -0700, Evan Stade wrote: > Changelog: > *Added GDI+ public headers > *Added some implementation (pen.c, gdiplus.c, memory.c) > *Added two tests (pen.c, init.c) I good indicator, that the Patch should be split in smaller Parts, is a Changelog (Subject) that is larger than a simple Line or includes an enumeration. You already use 3 Lines in the Changelog which describe the code for a minimum of 3 Patches. The usual way is one Patch for every new header to reduce the complexity of the Patch, but your headers are really small, so 2 Patches or maybe 1 single header-Patch might be ok (this depend also on the size). Thanks -- By by ... Detlef

3 2

Re: [1/2] uninstaller: add ability to scan HKCU for uninstall entries (Try 2)
by James Hawkins 01 Jun '07

01 Jun '07

On 6/1/07, Tom Spear <speeddymon(a)gmail.com> wrote: > Here is a 2nd attempt at the last one I sent. This time the root > field is initialized, and this part of the patch is written against > current git, not against changes to my own tree. Oh and its onl;y a > 2-parter > > This will make wine's programs/uninstaller look thru not only > HKEY_LOCAL_MACHINE for uninstall entries, but also HKEY_CURRENT_USER. > + /* Loop thru HKCU first, then thru HKLM */ + for (iRootKey=0; iRootKey<sizeof(rootKeys) / sizeof(rootKeys[0]); ++iRootKey) + { + /* If there is no uninstall info in a specific root key, + * finish this run and go to the next */ + if (RegOpenKeyExW(rootKeys[iRootKey], PathUninstallW, 0, + KEY_READ, &hkeyUninst) != ERROR_SUCCESS) + continue; This whole patch would be a lot simpler if you just used one root variable: if (RegOpenKeyExW(HKCU....) == ERROR_SUCCESS) root = HKCU; else if (RegOpenKeyExW(HKLM....) == ERROR_SUCCESS) root = HKLM; else bail out Now just use root everywhere instead of having an array of just two constants, and you get rid of the index. -- James Hawkins

3 3

Re: [2/2] uninstaller: indentation cleanups (try 2)
by Tom Spear 01 Jun '07

01 Jun '07

On 6/1/07, James Hawkins <truiken(a)gmail.com> wrote: > On 6/1/07, Tom Spear <speeddymon(a)gmail.com> wrote: > > Here is part 2 of try 2. Just cleans up the indentation of my changes > > in the previous patch in this series. > > > > I think you misunderstood what Dan meant about indentation changes. > You shouldn't have a patch that doesn't properly indent if you add a > new block, and then come in with another patch to fix the indentation. That is exactly what he told me to do, and I even submitted it to him like this and he said to send it in. -- Thanks Tom

1 0

Re: [1/2] uninstaller: add ability to scan HKCU for uninstall entries (Try 2)
by James Hawkins 01 Jun '07

01 Jun '07

On 6/1/07, Tom Spear <speeddymon(a)gmail.com> wrote: > Here is a 2nd attempt at the last one I sent. This time the root > field is initialized, and this part of the patch is written against > current git, not against changes to my own tree. Oh and its onl;y a > 2-parter > > This will make wine's programs/uninstaller look thru not only > HKEY_LOCAL_MACHINE for uninstall entries, but also HKEY_CURRENT_USER. > + /* Loop thru HKCU first, then thru HKLM */ + for (iRootKey=0; iRootKey<sizeof(rootKeys) / sizeof(rootKeys[0]); ++iRootKey) + { + /* If there is no uninstall info in a specific root key, + * finish this run and go to the next */ + if (RegOpenKeyExW(rootKeys[iRootKey], PathUninstallW, 0, + KEY_READ, &hkeyUninst) != ERROR_SUCCESS) + continue; Indentation? -- James Hawkins

2 1

Re: [2/2] uninstaller: indentation cleanups (try 2)
by James Hawkins 01 Jun '07

01 Jun '07

On 6/1/07, Tom Spear <speeddymon(a)gmail.com> wrote: > Here is part 2 of try 2. Just cleans up the indentation of my changes > in the previous patch in this series. > I think you misunderstood what Dan meant about indentation changes. You shouldn't have a patch that doesn't properly indent if you add a new block, and then come in with another patch to fix the indentation. -- James Hawkins

1 0

Re: [PATCH 3/4] msi: msiserver.idl: Maintain spacing as spaces, not tabs.
by James Hawkins 01 Jun '07

01 Jun '07

On 6/1/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > --- > dlls/msi/msiserver.idl | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > Stupid eclipse...only applies my tab preferences to c files. -- James Hawkins

1 0

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.
by Alexandre Julliard 01 Jun '07

01 Jun '07

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -212,8 +213,10 @@ static BOOL load_wine_gecko(PRUnichar *gre_path) > if(res != ERROR_SUCCESS || type != REG_SZ) > return FALSE; > > - if(TRACE_ON(mshtml)) > - check_version(gre_path); > + /* We may consider message box here */ > + if(ERR_ON(mshtml) && !check_version(gre_path)) > + MESSAGE("Found a version of Wine Gecko package that is not dedicated " > + "to your Wine version. Reinstalation is recommended.\n"); If you want to check versions, there needs to be a way to specify in the URL which version you want to download, and old versions need to be kept available. The target CPU should also be part of the URL so we can support multiple platforms. -- Alexandre Julliard julliard(a)winehq.org

2 5

Bug triage, or spam?
by Tom Spear 01 Jun '07

01 Jun '07

Hi all, I just have a quick question.. I got a message from someone last night asking me to stop closing bugs because I'm spamming the list, however I also received a message from someone a couple of nights ago thanking me for doing bug triage.. Which is it, and if it is both, then what draws the line between triage and spam, and how do I close stale bugs without it being considered spam? -- Thanks Tom

6 17

The ddraw tests don't compile with Visual C++ 2005.
by Francois Gouget 01 Jun '07

01 Jun '07

Visual C++ 2005 does not like the way we compute the infinity and NaN values. I've tried replacing the current divisions by zero with arithmetic on FLT_MAX (at least for the infinity calculations), but it did not like that either. Does anyone know how to make these calculations portable? How does one get at these values on Windows? diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c [...] light.dvAttenuation0 = -1.0 / 0.0; /* -INFINITY */ [...] light.dvAttenuation0 = 1.0 / 0.0; /* +INFINITY */ [...] light.dvAttenuation0 = 0.0 / 0.0; /* NaN */ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

4 4

Re: msvfw32: Fix enumeration of VFW video codecs that are registered in the registry.
by Detlef Riekenberg 01 Jun '07

01 Jun '07

On Fr, 2007-06-01 at 00:25 +0200, Julien Muchembled wrote: > There are 2 ways to register a VFW video codec: > (1) the [drivers32] section of system.ini : "vidc.<FOURCC>=<dll_name>" > (2) the "HKLM\Software\Microsoft\Windows NT\CurrentVersion\Drivers32" key: > - value name: "vidc.<FOURCC>" > - value data: "<dll_name>" There ia a magic with the Name "IniFileMapping": On NT, (1) is redirected to (2). Wine is still affected by bug 4096 -- By by ... Detlef

1 0

FPS tool for wine
by Tomas.Zijdemans＠student.uib.no 01 Jun '07

01 Jun '07

The largest gaming site in Norway recently did an extensive review of gaming on Linux, but Wine was left out of the benchmark because "no FPS tool exists for Wine". Surely this can't be true?

10 11

Re: crypt32: implement CryptSIPLoad (try 5)
by Paul Vriens 01 Jun '07

01 Jun '07

On 6/1/07, Juan Lang <juan_lang(a)yahoo.com> wrote: > Answering my own question, I see that the previous try introduced compiler > warnings. Fixed. > > ChangeLog: implement CryptSIPLoad > > --Juan > Hi Juan, This patch still uses the non-native behavior. Is there a consensus on this? I guess we are the only ones talking about this but I hope there are more opinions. I said before that I also don't know why native does it like that and I don't see any benefit (yet). If this patch does get accepted we should have a proper comment in the source (or are the comments in the tests enough?). Cheers, Paul.

2 1

Re: Added GDI+ public headers, small implementation of pen, memory and initialization, and two tests (2nd try)
by Alexandre Julliard 01 Jun '07

01 Jun '07

"Evan Stade" <estade(a)gmail.com> writes: > I made the fixes that Dmitry suggested. Additionally I changed the > public header files to all lower-case (to match the wine headers > rather than platform sdk headers). I also consolidated a couple of > source files so there wouldn't be files with only 2 functions in them. That's good, please do the same with the init test, there's no reason to have a separate file for that. > I believe there was a question earlier on the list about why there is > "#ifndef __cplusplus ... #endif" around portions of the headers. This > is because this implementation of gdi+ only supports c and not c++. That's not OK, the implementation clearly has to support C++ too, even if it is written in C. You should also send that stuff in smaller chunks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re:wine.inf: Create fake dll for iexplore.exe.
by Louis. Lenders 01 Jun '07

01 Jun '07

>wine.inf: Create fake dll for >iexplore.exe. >Vitaliy Margolen wine-patches at kievinfo.com >Thu May 24 08:50:10 CDT 2007 >Some older programs check if IE is installed looking for c:\Program >Files\Internet Explorer\iexplore.exe --- tools/wine.inf | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

2 1

Re: [d3drm/tests] d3drm is removed from Windows Vista
by H. Verbeet 31 May '07

31 May '07

On 11/05/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > d3drm is removed from Windows Vista and thus we have to check if it can be loaded. > I suppose that implies that any application using d3drm won't work on Vista?

3 2

re: Whitespace changes in an indentation patch, is it acceptable?
by Dan Kegel 31 May '07

31 May '07

Tom wrote: >Hi all, just curious, in my work on uninstaller, I am writing my >patches to where when indentation is changed, due to adding a for >loop, it is done in a separate patch file. I was wondering if it is >acceptable to make whitespace changes to other parts of the file in >that same patch. In general, mixing large whitespace changes with small functional changes make it hard to code review the functional change. But either way can be fine, it just depends on the situation. Now that you've fixed a couple bugs in your uninstall patch, I think you should post the very simplest form of it possible, without any other change mixed in. In this case, I think that means you should do the whitespace changes in a second patch. - Dan

3 2

Whitespace changes in an indentation patch, is it acceptable?
by Tom Spear 31 May '07

31 May '07

Hi all, just curious, in my work on uninstaller, I am writing my patches to where when indentation is changed, due to adding a for loop, it is done in a separate patch file. I was wondering if it is acceptable to make whitespace changes to other parts of the file in that same patch.. For example, there is: int somevariable; do something; (there are 2 spaces in the blank line). Would it be acceptable to remove those spaces in a patch that changes the following code (which is introduced by the first patch in the series): for blah { do something; for something else { do another thing; } } to: for blah { do something; for something else { do another thing; } } or should I just leave those extra whitespaces in the blank line alone? -- Thanks Tom

1 0

winefile/explorer hardcoded? HKEY_CLASSES_ROOT\Folder\shell\open\command ignored
by RusH 31 May '07

31 May '07

Repost from wine-users(no answer there). Winefile seems to be hardcoded when it comes to opening folders. No matter what I do it always pops up. I tried deleting HKEY_CLASSES_ROOT\Folder and nothing changed. What can I do to convince wine to open folders with /usr/bin/nautilus ? I allready made it open ordinary files with gnome-open. Should I made a bug report? Are DDE registry keys for folder opening only a prop? -- Who logs in to gdm? Not I, said the duck.

2 1

Re: (try 2) ws2_32: getsockname should fail for unbound sockets
by Dmitry Timoshkov 31 May '07

31 May '07

"Damjan Jovanovic" <damjan.jov(a)gmail.com> wrote: > + case AF_INET6: > + { > + static const struct sockaddr_in6 emptyAddr; > + const struct sockaddr_in6 *in6 = (struct sockaddr_in6*) uaddr; > + return in6->sin6_port || memcmp(&in6->sin6_addr, &emptyAddr.sin6_addr, sizeof(struct in6_addr)); > + } > + case AF_INET: > + { > + static const struct sockaddr_in emptyAddr; > + const struct sockaddr_in *in = (struct sockaddr_in*) uaddr; > + return in->sin_port || memcmp(&in->sin_addr, &emptyAddr.sin_addr, sizeof(struct in_addr)); > + } You should add 'const' to the casting if the target you create is 'const'. -- Dmitry.

1 0

Re: headers, two tests
by Dmitry Timoshkov 31 May '07

31 May '07

This time it's just the nit picks, I see no serious problems. "Evan Stade" <estade(a)gmail.com> wrote: > +void WINGDIPAPI GdipFree(void* ptr) > +{ > + if(ptr) > + HeapFree(GetProcessHeap(), 0, ptr); > +} There is no need to check a pointer for NULL before HeapFree call, there is even a janitorial project in Wine to remove such checks. > +static void test_constructor_destructor(void) > +{ > + GpStatus status; > + GpGraphics *pen; > + > + status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel, &pen); GdipCreatePen1 takes a pointer to GpPen in the last parameter, not GpGraphics. > + expect(Ok, status); > + ok(pen, "Expected pen to be initialized"); If you are testing returned pen pointer for NULL, you need to initialize it to NULL before the call. -- Dmitry.

1 0

Re: crypt32: implement CryptSIPLoad (resend)
by Juan Lang 30 May '07

30 May '07

Hi Paul, > Please correct me if I'm wrong but aren't you filling pSipDispatch > with the function pointers of the given dll (as indicated by the GUID) > instead of the function pointers of crypt32 (as the tests show it > should)? I am. I couldn't find any reason that the behavior needs to be that way, so I do this until such time as a reason can be found. The tests don't fail, as you check the function pointers from msisip.dll, which isn't present on wine. If you know a good reason native does it that way (or an app that depends on it,) by all means enlighten me. The implementation I sent allows native wintrust to get a bit further. --Juan ____________________________________________________________________________________ Get your own web address. Have a HUGE year through Yahoo! Small Business. http://smallbusiness.yahoo.com/domains/?p=BESTDEAL

2 1

Pretty Build System (Take 3)
by Robert Shearman 30 May '07

30 May '07

Hi, Attached is a patch that reduces the verbosity of the build system by printing the build commands in one of two formats: COMMAND output_file or COMMAND input_file -> output_file I hope it meets Alexandre's requirements of not reducing portability of Wine to other platforms (including Windows). -- Rob Shearman

3 5

Looking for Dev to help with BSD Port
by Kris Moore 30 May '07

30 May '07

Hey all! We're looking for a Wine dev to assist us with some porting issues over to PC-BSD / FreeBSD. We've recently begun to embrace making packages with wine embedded, making the process of loading windows programs a snap. The end user only needs to double-click, insert their CD, and click next a few times. This allowed us to make some packages for programs such as PhotoShop & Dreamweaver which even a non-linux/BSD user could install. We really want to expand these packages, to include things such as games, and others, but there are a few problems with running Wine on BSD at the moment. If anybody is willing to help us out with this, please let me know! Here's a list of some of the porting issues were aware of: http://wiki.freebsd.org/Wine Thanks! -- Kris Moore PC-BSD Software http://www.pcbsd.com

1 0

Ownerdraw listview font patch...
by Markus Gömmel 30 May '07

30 May '07

Hi, one of our windows application is using an OWNERDRAW_FIXED listview. With the current version of Wine I mentioned that when the listview is loosing its focus, the selected item will be repainted in a wrong front (System 12 instead of my MS Shell Dlg 11)... after the focus comes back, the item is redrawn again, now with correct font settings again. After searching for a while my idea is that the LISTVIEW_ShowFocusRect function is missing a SelectObject call to the font stored in the item-structure for this particular listview item. So the hdc transfered over WM_DRAWITEM to the application contains the wrong font. I created the attached patch, which looks like this: --- snipp --- diff -u -u -r1.485 listview.c --- dlls/comctl32/listview.c 25 May 2007 19:46:02 -0000 1.485 +++ dlls/comctl32/listview.c 30 May 2007 12:28:44 -0000 @@ -1770,6 +1770,9 @@ { DRAWITEMSTRUCT dis; LVITEMW item; + + HFONT hFont = infoPtr->hFont ? infoPtr->hFont : infoPtr->hDefaultFont; + HFONT hOldFont = SelectObject(hdc, hFont); item.iItem = infoPtr->nFocusedItem; item.iSubItem = 0; @@ -1788,6 +1791,8 @@ dis.itemData = item.lParam; SendMessageW(infoPtr->hwndNotify, WM_DRAWITEM, dis.CtlID, (LPARAM)&dis); + + SelectObject(hdc, hOldFont); } else { --- snipp --- Before sending this to wine.patches, I wanted to ask if anyone here can tell me if the above is ok or total bullshit. Thanks and regards Markus

2 1

Re: Implement the WriteEnvironmentStrings standard action
by Dmitry Timoshkov 30 May '07

30 May '07

"James Hawkins" <truiken(a)gmail.com> wrote: > + HKEY env, root = HKEY_CURRENT_USER; ... > + if (flags & ENV_MOD_MACHINE) > + root = HKEY_LOCAL_MACHINE; It looks like root is not used. -- Dmitry.

2 1

Re: crypt32: implement CryptSIPLoad (resend)
by Paul Vriens 30 May '07

30 May '07

On 5/30/07, Juan Lang <juan_lang(a)yahoo.com> wrote: > Hi, I fixed the test failures - anything wrong with it this time? > > ChangeLog: implement CryptSIPLoad > > Thanks, > --Juan > Hi Juan, Please correct me if I'm wrong but aren't you filling pSipDispatch with the function pointers of the given dll (as indicated by the GUID) instead of the function pointers of crypt32 (as the tests show it should)? Cheers, Paul.

1 0

Call for Ubuntu-wine admin
by Tomas.Zijdemans＠student.uib.no 30 May '07

30 May '07

If someone is interested in leading the Ubuntu-wine team, please contact me.

4 3

Re: [ws2_32] getsockname should fail on unbound socket
by Kai Blin 30 May '07

30 May '07

On Wednesday 30 May 2007 07:56:31 Damjan Jovanovic wrote: > + case AF_INET: { > + const struct sockaddr_in *in = (struct sockaddr_in*) uaddr; > + return in->sin_port != 0; > + } Talking to Alexandre about this in IRC, he wanted me to check for all-null returns, so you probably should check if the IP address is 0.0.0.0 (or :: for IPv6), too. Also, I had the impression that the Wine convention was that case block braces go onto a new line, too. You might want to consider that for the switch you addded. Thanks for doing the work for me otherwise :) Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 0

Fedora Packages
by Andreas Bierfert 30 May '07

30 May '07

Hi, here is some news/status update on the fedora packages: As people have been complaining about the link on the winehq webpage I have taken the time to make a summary page[1] on the fedora wiki which is easier for me to maintain and keep up-to-date and is probably more helpful. I would request that the link in the download section is changed to that page. I have good news for users of RHEL/Centos: After collaborating with some other maintainers from the fedora project I finally got all dependencies for wine into the EPEL[2] repository (which is something like Fedora Extras but for RHEL/Centos). This means that there now is a wine version for users of RHEL/Centos 5 (it may take a couple of hours or a day till it is published to the repository and all mirrors have synced it). It will probably take a couple of days but I finished testing these changes for RHEL/Centos 4 as well so there should also be a version out soon. Comments and suggestions are (like always) very much welcome. Regards, Andreas [1] - http://fedoraproject.org/wiki/AndreasBierfert/Wine [2] - http://fedoraproject.org/wiki/EPEL -- Andreas Bierfert | http://awbsworld.de | GPG: C58CF1CB andreas.bierfert(a)lowlatency.de | http://lowlatency.de | signed/encrypted phone: +49 2402 102373 | cell: +49 173 5803043 | mail preferred

1 1

c++ code
by Evan Stade 30 May '07

30 May '07

Hi I want to write conformance tests for gdiplus and that requires the use of c++. Even if I were to focus on the gdi+ flat api, the windows SDK headers for that have c++ code in them, also eventually when the gdi+ c++ wrappers are written on top of the flat api then we will need to be able to compile c++ in the wine environment. What do I have to do to be able to write these tests? -Evan Stade

4 8

Re: Pretty Build System (Take 3)
by Kirill K. Smirnov 29 May '07

29 May '07

You probably forget to run 'autoconf'. I can see nice messages like: $ autoconf ... $ ./configure ... $ make depend ... $ make ... CC extrachunk.o CC factory.o CC getframe.o CC icmstream.o CC regsvr.o CC tmpfile.o >I get the following (on Slackware 11) while running the make depend >portion of ./configure && make depend && make && sudo make install: >make[1]: Entering directory `/home/speeddy/wine-git/tools' >../tools/makedep -C. -S.. -T.. -I/usr/include/freetype2 bin2res.c >fnt2bdf.c fnt2fon.c make_ctests.c makedep.c relpath.c sfnt2fnt.c >make[1]: Leaving directory `/home/speeddy/wine-git/tools' >make[1]: Entering directory `/home/speeddy/wine-git/tools' >make[1]: `makedep' is up to date. >make[1]: Leaving directory `/home/speeddy/wine-git/tools' >make[1]: Entering directory `/home/speeddy/wine-git/dlls' >make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' >../../tools/makedep -C. -S../.. -T../.. main.c >make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' >make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' >make[2]: MAKERULE_MAKEDEP@: Command not found >make[2]: *** [depend] Error 127 >make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' >make[1]: *** [acledit/__depend__] Error 2 >make[1]: Leaving directory `/home/speeddy/wine-git/dlls' >make: *** [dlls/__depend__] Error 2

1 0

Re: wininet: Add a new NETCON_query_data_available function.
by Stefan Leichter 29 May '07

29 May '07

Am Monday 28 May 2007 12:16 schrieb Robert Shearman: > Use it to implement the behaviour where InternetReadFileExA does a > synchronous request if the data is available and asynchronous otherwise. > --- > configure.ac | 1 + > dlls/wininet/internet.c | 49 > +++++++++++++++++++++++++++-------------- > dlls/wininet/internet.h | 1 + > dlls/wininet/netconnection.c | 35 ++++++++++++++++++++++++++++++ > 4 files changed, 69 insertions(+), 17 deletions(-) Hello, your patch broke the compilation for me. Bye Stefan make[2]: Entering directory `/usr/src/wine/wine-build/dlls/wininet' gcc -c -I../../../wine-git/dlls/wininet -I. -I../../../wine-git/include -I../../include -D__WINESRC__ -D_WINX32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o netconnection.o ../../../wine-git/dlls/wininet/netconnection.c ../../../wine-git/dlls/wininet/netconnection.c: In function ‘NETCON_query_data_available’: ../../../wine-git/dlls/wininet/netconnection.c:585: error: ‘WININET_NETCONNECTION’ has no member named ‘peek_msg’ ../../../wine-git/dlls/wininet/netconnection.c:586: error: ‘WININET_NETCONNECTION’ has no member named ‘peek_len’ make[2]: *** [netconnection.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/wininet'

1 0

Happy SOC'ing all.
by Maarten Lankhorst 29 May '07

29 May '07

For all other students joining SummerOfCode, I think it's a good idea if we have a public place where we can see each other's changes. I set up my own fork, sound.git at http://repo.or.cz/w/wine.git - if others want to do the same I encourage them to do so, it's easy when you figure out how to git push. Since soc now officially started (according to date, in holland anyway), I just want to say: - Happy coding - Good luck all Cheers, Maarten

4 4

Crosscompile (mingw) failure with msxml3 tests
by Paul Vriens 29 May '07

29 May '07

Hi, I just wanted to report the current failures when crosscompiling the msxml3 tests with mingw (and thus no new winetest executable): xmldoc.cross.o:xmldoc.c:(.text+0x1a9): undefined reference to `_IID_IXMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x1c0): undefined reference to `_CLSID_XMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x149d): undefined reference to `_IID_IXMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x14b4): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x22): undefined reference to `_IID_IXMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x39): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x1425): undefined reference to `_IID_IXMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x143c): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x1c46): undefined reference to `_IID_IXMLElement' xmlelem.cross.o:xmlelem.c:(.text+0x1f0f): undefined reference to `_IID_IXMLElement' collect2: ld returned 1 exit status make: *** [msxml3_crosstest.exe] Error 1 These started to happen after the addition of some patches made by James Hawkins (Add tests for [IXMLElement|IXMLDocument]) on May 26th. Cheers, Paul.

1 0

uninstaller: Shorten variable name length.. Whats wrong?
by Tom Spear 29 May '07

29 May '07

Just curious to know if there was something wrong with this patch, or if maybe it wasnt committed due to being a cosmetic change? If it's the latter, I'll just resend the other 2 parts of the patch (2and 3 of 3) against the code the way it is instead of changing the lines.. On 5/23/07, Tom Spear <speeddymon(a)gmail.com> wrote: > This patch shortens the length of some lines in > FetchUninstallInformation, as suggested by Peter Beutner > > -- > Thanks > > Tom > > -- Thanks Tom

1 0

[wiki] Child pages mess up the logo-location
by Paul Vriens 29 May '07

29 May '07

Hi, Every now and then I check for the 'Recent Changes' on the wiki. The following page caught my attention: http://wiki.winehq.org/MaartenLankhorst/SOC2007 This page is actually named "MaartenLankhorst/SOC2007" and is a child of the 'MaartenLankhorst' page. This page messes up the logo in the top-left corner. When looking at the properties of the logo it shows 'http://wiki.winehq.org/MaartenLankhorst/logo.png' instead of the correct 'http://wiki.winehq.org/logo.png'. The same logic is true for http://wiki.winehq.org/MacOSX/FAQs (and probably others). Just thought I mention it. Cheers, Paul.

1 0

Start of an opengl-based gdi driver
by Stefan Dösinger 29 May '07

29 May '07

Hi, One of our remaining fundamental d3d problems is the slowness of IDirectDrawSurface7::GetDC(and d3d9). This call allows performing gdi operations on surfaces. Currently this is handled through downloading the opengl surface, performing the gdi operation, and uploading it again. This is slow, especially on render targets. On textures this is rarely used, and wined3d can better cache the texture. Most applications use it to render text text on the back buffer. Applications I have are the d3d7 sdk demos, Empire Earth, Prince of Persia 3D, Age of Empires 2. Sometimes it is also used to load textures with a BitBlt. I have discussed two ways of solving this issue with alexandre. One was to tell the X server to perform the calls in opengl(EXT_texture_from_pixmap looked promissing), the other one was writing an opengl gdi driver in wined3d. The X server approach failed because there is just no API to get that handled, and EXT_texture_from_pixmap explicitly doesn't do that job, and even if there is a hacky way driver support will be bad. So I spent the last days to check how an implementation in wined3d would work - and here it is. So far this driver handles only ExtTextOutW, and I only successfully used it with the directx sdk samples. ExtTextOut uses a Helper device context(normal gdi) to get the glyphs with GetGlyphOutline, loads it into an opengl texture(GL_ALPHA) and records 256 display lists to draw textured quads. So far no unicode support, no custom pens, but custom fonts work. I have 2 screenshots of a dx7 sdk demo with classic getdc and the opengl driver(radeon M9, 1.6 ghz pentium M, 512 mb ram). There seems to be some parameter missing, the text is slightly displaced. Tex.gif(attached) is the created font texture(warning, white text on transparent background). http://stud4.tuwien.ac.at/~e0526822/gl.png http://stud4.tuwien.ac.at/~e0526822/gdi.png One problem of this approach is that the driver has to handle everything. However, I keep a DIB section of the size of the surface, and if I encounter some unsupported call I can print a FIXME, download from gl and call the dib section to do the job. After ReleaseDC the surface code has to upload it again. Its the slow old behavior, so we don't gain anything for unsupported calls, but its no loss either. So far most forward functions are missing, so the DIB driver refuses to initialize itself - Edit CreateDC in dlls/wined3d/gdi.c to activate it. ExtTextOut has an example how the forwarding looks like. A big problem I still have are operations that involve 2 device contexts. Prince of Persia 3D(good test case for custom fonts) calls StretchBlit from/to my gl dc. So in X11drv one of the physdevs is a WineD3DSurfaceImpl * instead of a WINEX11DRV_PHSYDEV * - not good. So far I haven't found a way to let x11drv access my surface data, or enforce that my function is called, fetch the hdc from the x11 phsydev and call my fallback dc, or request the device's content from x11drv and handle the blit myself.

2 3

Start of an opengl-based gdi driver
by Stefan Dösinger 28 May '07

28 May '07

Hi, One of our remaining fundamental d3d problems is the slowness of IDirectDrawSurface7::GetDC(and d3d9). This call allows performing gdi operations on surfaces. Currently this is handled through downloading the opengl surface, performing the gdi operation, and uploading it again. This is slow, especially on render targets. On textures this is rarely used, and wined3d can better cache the texture. Most applications use it to render text text on the back buffer. Applications I have are the d3d7 sdk demos, Empire Earth, Prince of Persia 3D, Age of Empires 2. Sometimes it is also used to load textures with a BitBlt. I have discussed two ways of solving this issue with alexandre. One was to tell the X server to perform the calls in opengl(EXT_texture_from_pixmap looked promissing), the other one was writing an opengl gdi driver in wined3d. The X server approach failed because there is just no API to get that handled, and EXT_texture_from_pixmap explicitly doesn't do that job, and even if there is a hacky way driver support will be bad. So I spent the last days to check how an implementation in wined3d would work - and here it is. So far this driver handles only ExtTextOutW, and I only successfully used it with the directx sdk samples. ExtTextOut uses a Helper device context(normal gdi) to get the glyphs with GetGlyphOutline, loads it into an opengl texture(GL_ALPHA) and records 256 display lists to draw textured quads. So far no unicode support, no custom pens, but custom fonts work. Attached are 2 screenshots of a dx7 sdk demo with classic getdc and the opengl driver(radeon M9, 1.6 ghz pentium M, 512 mb ram). There seems to be some parameter missing, the text is slightly displaced. Tex.gif is the created font texture(warning, white text on transparent background) One problem of this approach is that the driver has to handle everything. However, I keep a DIB section of the size of the surface, and if I encounter some unsupported call I can print a FIXME, download from gl and call the dib section to do the job. After ReleaseDC the surface code has to upload it again. Its the slow old behavior, so we don't gain anything for unsupported calls, but its no loss either. So far most forward functions are missing, so the DIB driver refuses to initialize itself - Edit CreateDC in dlls/wined3d/gdi.c to activate it. ExtTextOut has an example how the forwarding looks like. A big problem I still have are operations that involve 2 device contexts. Prince of Persia 3D(good test case for custom fonts) calls StretchBlit from/to my gl dc. So in X11drv one of the physdevs is a WineD3DSurfaceImpl * instead of a WINEX11DRV_PHSYDEV * - not good. So far I haven't found a way to let x11drv access my surface data, or enforce that my function is called, fetch the hdc from the x11 phsydev and call my fallback dc, or request the device's content from x11drv and handle the blit myself.

1 0

New Gecko package
by Luke Bratch 28 May '07

28 May '07

> I'm interested in > regressions, so just a simple test if app that worked before still works > will be fine. I've given it a test, and found the following: - When setting that URL in HKCU\Software\Wine\MSHTML, it will download but fail to install. - Extracting it to install it manually works, as do the scroll bars (which work fine) - It crashes after submitting more than one form on websites. For instance searching for something on Google, then searching again will cause a crash. This is with the latest git - wine-0.9.37-118-g2970076 ___________________________________________________________ Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your free account today http://uk.rd.yahoo.com/evt=44106/*http://uk.docs.yahoo.com/mail/winter07.ht…

2 6

New Gecko package
by Jacek Caban 28 May '07

28 May '07

Hi all, It's time to update our Gecko package. I've prepared a new one. I'd like to avoid any regression, esp. ones that would require changing the package again. That's why I'd like to do a good test. I'm interested in regressions, so just a simple test if app that worked before still works will be fine. To do so download: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko.tar.bz2 1) if you already have installed Gecko, simply extract the package and replace c:\windows\wine_gecko with it. 2) otherwise extract the package and set GeckoPath variable of HKCU\Software\Winde\MSHTML registry key to its location. Then run an app and check if it still works. Note that you have to use current Git, older Wine is not compatible with the new Gecko. Expected visible difference should be: - Working scrollbars (still not perfect, they will be visible even if app sets it to not be, but it's better than before - I will work on it later) - Pages that require plugins will render like there was no plugin instead of offering downloading one (that doesn't work anyway) >From technical point of view this version differs much from previous one. Previous version was just a SeaMonkey with manually removed and changed some files. This one is my built from source (I will create a page on wiki about how to do so). It's based on XUL Runner 1.8.1.3, which has the same source as Firefox 2.0.0.3. After testing it, I will change Gecko installer a bit to be able to deal with different Gecko versions for different Wine version and upload it to SourceForge. Thanks, Jacek

4 8

winmm: PlaySound SND_ASYNC fix
by Vedran Rodic 28 May '07

28 May '07

Hi, this patch is still not applied though I've submitted it last Wednesday. I guess it's not obviously clear that it is correct, so I'm asking for a review here. I've peronally tested it with alsa and oss sound backends. It specifically fixes one series of Croatian child educational games named "Suncica". Detailed info: Applications expect PlaySound() not to block when called with SND_ASYNC flag. However, if a sound is currently playing, there is a real chance of PlaySound() blocking for up to 1/3 of a second (size of the playsound buffer), because of a sound buffer waiting to be played. This patch adds a hWave field in the WINE_PLAYSOUND internal struct in winemm.h so that MULTIMEDIA_PlaySound() function can call waveOutReset when a sound is already playing to quickly remove it from the sound system. Another scenario is when application wants to quickly stop a currently playing sound at a specific time. Blocking behaviour isn't necessarily a problem for such applications, but playing the sound for additional 300 miliseconds could be. ChangeLog entry: Vedran Rodic <vrodic(a)gmail.com> - fix PlaySound so it doesn't block when another sound is already playing. Thanks

1 0

Re: ddraw/tests: Fix compilation with Visual C++ 2005.
by Stefan Dösinger 27 May '07

27 May '07

> - light.dvAttenuation0 = 0.0 / 0.0; /* NaN */ > + light.dvAttenuation0 = zero / zero; /* NaN */ Are you sure the compiler doesn't optimize that away to 1.0 ?

2 1

Re: setupapi/tests: There is no strncascmp() on Windows. So we must use msvcrt's _strnicmp() function instead.
by Dmitry Timoshkov 27 May '07

27 May '07

"Francois Gouget" <fgouget(a)free.fr> wrote: > There are other alternatives: > * we could have an #ifdef _MSC_VER to switch between strncasecmp() and > _strnicmp(). > * we could reimplement _strnicmp(). > * or maybe the test could be modified to not need this function at all? 4. use a kernel32 export lstrcmpiA P.S. Even in Wine code strncasecmp/strcasecmp should be deprecated since it uses wrong locale. -- Dmitry.

1 1

how to compile test cases?
by RusH 27 May '07

27 May '07

rasz@capek:/media/hdc6/home/rasz/source/wine/dlls/ws2_32$ make test make: Nothing to be done for `test'. rasz@capek:/media/hdc6/home/rasz/source/wine/dlls/ws2_32$ make crosstest make: Nothing to be done for `crosstest'. I want to build only ws2_32 tests, preferably using mingw. -- Who logs in to gdm? Not I, said the duck.

2 1

Re: wined3d: Implement support for gamma corrected (sRGB) texture loading
by H. Verbeet 27 May '07

27 May '07

On 27/05/07, Phil Costin <philcostin(a)hotmail.com> wrote: > Hi, > > This patch has been a long time in the making. The following test was used > during the creation of the patch: > > http://ati.amd.com/developer/samples/dx9/sRGBTest.html > If it's not too much trouble, a proper wine test would be nice. The changes to surface_upload_data and surface_download_data look like they should be separate changes. In cubetexture.c, and similar code in texture.c and volume.c: > + } else if (GL_SUPPORT(EXT_TEXTURE_SRGB) && This->baseTexture.bindCount > 0) { > + currentSrgbMode = This->resource.wineD3DDevice->stateBlock->samplerState[This->baseTexture.sampler][WINED3DSAMP_SRGBTEXTURE]; > + srgbModeChanged = (This->baseTexture.srgbWhenLoaded != currentSrgbMode); > + This->baseTexture.srgbWhenLoaded = currentSrgbMode; You've got "device" here, no need to use "This->resource.wineD3DDevice" sRGBmode looks a bit awkward as a variable name, I'd rather see something like srgb_mode, but I guess that's more a personal preference. It would also probably be better to submit/commit this right after a release instead of right before one.

2 1

[PATCH 4/4] dpnhupnp: Implement IDirectPlayNatHelper stub
by Vijay Kiran Kamuju 27 May '07

27 May '07

Hi, It seems there is a problem with the fake dll entry for dpnhupnp.dll in wine.inf @@ -2129,6 +2129,7 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,"SameAreaRule",,"G" 11,,dmusic.dll,1 11,,dplayx.dll,1 11,,dpnet.dll,1 +11,,dpnhupnp,1 11,,dsound.dll,1 11,,dswave.dll,1 11,,dxdiagn.dll,1 The ebtry should have been 11,,dpnhupnp.dll,1 Correct and resend Thanks, VJ

1 0

Wine does not compile
by martin pilka 27 May '07

27 May '07

Hello, I just tried to compile Wine on Ubuntu 6.06 and Ubuntu 7.04 (both updated). On both machines, I got following error: make[2]: Entering directory `/home/mpilka/cxtest/wine/dlls/msxml3' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o attribute.o attribute.c In file included from attribute.c:32: msxml_private.h:67: error: expected declaration specifiers or ‘...’ before ‘xmlNodePtr’ msxml_private.h:68: error: expected declaration specifiers or ‘...’ before ‘xmlNodePtr’ make[2]: *** [attribute.o] Error 1 make[2]: Leaving directory `/home/mpilka/cxtest/wine/dlls/msxml3' make[1]: *** [msxml3] Error 2 make[1]: Leaving directory `/home/mpilka/cxtest/wine/dlls' make: *** [dlls] Error 2 Just wanted to let you know that, Martin

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel