- wine-devel - winehq.org

Re: Console output with different codepages - the result.
by Kirill K. Smirnov 06 May '07

06 May '07

> just a dummy question... does the different fonts your tests refer to > have all the glyphs required ? (or said differently, isn't this a font > issue about the required glyphs for russian ?) > A+ By default (in 866 OEM codepage) wine console renderer behaves just like windows does, the difference appears iff I change codepage to 1251 ANSI. So it is not missing glyphs problem - I do not change font while changing codepage. -- Kirill

1 0

dbghelp performance
by Markus Amsler 06 May '07

06 May '07

I've played around with dbghelp performance. My test case was breaking at an unknown symbol (break gaga) while WoW was loaded in the debugger (wine winedbg WoW.exe). The time was hand stopped, memory usage measured with ps -AF and looked at the RSS column. Test Time(s) Memory Usage(MB) current git 4.5 54 pool_heap.patch 4.5 63 process_heap.patch 4.5 126 insert_first.patch 4.5 54 current git, r300 115 146 pool_heap.patch, r300 17 119 process_heap.patch, r300 17 260 insert_first.patch, r300 27 167 insert_first is the patch from Eric Pouech. r300 means with the debug version of Mesas r300_dri.so, which has a total compilation unit size of around 9.2M (compared to the second biggest Wines user32 with 1.1M). Conclusions: - current git wins with small debug files (<2M or so), pool_heap wins with bigger files. insert_first, process_heap are out. - small pools have less memory overhead than small heaps - big pools have more memory overhead than big heaps. - big pools are a lot slower than big heaps. IMO the best results would give removing the pools (like in process_heap) and freeing unused memory manually, the other way round it was allocated. But at a first glance it looks like quite a bit of work, which I'm not sure is worth the result. I think the best approach would be to code some destroy functions in storage.c which would free the allocated vector, sparse_array and hash_table memory. And then gradually replace pool_alloc calls with HeapAlloc/HeapFree pairs. Markus

2 6

Re: Initial Mixer support on Mac OS X (1/7)
by Maarten Lankhorst 06 May '07

06 May '07

"Emmanuel Maillard" <mahanuu(a)free.fr> wrote: > Changelog : > - inital Mixer support on Mac OS X > - find all lines and initialize controls Looking through it you seemed to have used OSS as base, which means some of the comments on my earlier code also apply to your code: - 64 bits safety (use DWORD_PTR's) - the code that normalizes to 65535 should be changed by a MulDiv if possible. Also if coreaudio has a way to notify the sound driver that a mixer control has changed you might want to notify the program, see elem_callback in alsa's mixer, and alsa's mix_open. Cheers, Maarten

1 0

Re: [PATCH 3/3] winex11: Use TINN algorithm to speed up colour lookups. (try 2)
by Dmitry Timoshkov 06 May '07

06 May '07

"Vitaly Budovski" <vbudovski(a)gmail.com> wrote: > Make use of the Triangle Inequality Nearest Neighbour algorithm to find the > nearest colour more efficiently than a simple linear search. The improvements > are most noticeable with a palette of 256 colours. Testing shows approximately > 3-4x performance increase for 256 colours. Now that you got rid of sqrt calls usage of float numbers internally doesn't look justified (to me) anymore. -- Dmitry.

1 0

InternetCanonicalizeURLA / W - Missing some flags?
by Chris Howe 06 May '07

06 May '07

I noticed a FIXME cropping up in the logs when working on EQ2, related to InternetCanonicalizeURL not fully parsing the flags that it is called with. Looking a bit closer, it offloads the grunt work to UrlCanonicalize anyway, and the missing flags seem to have analogs defined for UrlCanonicalize to use, and adding support for them makes the message go away: no problems that I can see, either. However, I seem to be having trouble running the test for wininet, as it just hangs for me (before I made the alterations, that is)... would somebody care to check that the attatched patch is correct?

1 0

RE: Initial Mixer support on Mac OS X (2/7)
by Amy Fox 06 May '07

06 May '07

oi >From: Emmanuel Maillard <mahanuu(a)free.fr> >Reply-To: wine-devel(a)winehq.org >To: wine-patches(a)winehq.org >Subject: Initial Mixer support on Mac OS X (2/7) >Date: Sun, 6 May 2007 11:53:48 +0200 > >Changelog : > - implement MIX_Open and MIX_GetNumDevs > ><< 0002-implement-MIX_Open-and-MIX_GetNumDevs.patch >> > _________________________________________________________________ Reserve your place in history - Email Britain! http://www.emailbritain.co.uk/

1 0

Re: winmm: Use a pipe for timer
by Steven Edwards 06 May '07

06 May '07

Hi, On 5/5/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > This avoids expensive server calls in a time critical timer. > > Without priority patch it drops stddev in winmm timer tests to < 2 ms as > compared to ~7 ms before. With priority patch it drops to < .20 ms. > > Backwards compatibility code is kept just in case. Even though backward compatibility is kept I worry about a couple of things. A lot of work was done on WinMM to make it portable to windows for testing and I don't like seeing new code to tie it back to unix even with the old code left in place. Also shouldn't there be a way to speed up the server performance instead? If this is accepted here then what about other areas of wine such as directx where timers similar may be used? Should we make this sort of patch global? I don't think so but then I don't know enough to no what the proper fix would be. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 2

Writing an interactive test
by Andrew Riedi 06 May '07

06 May '07

I would like to know if there is a way to write an interactive test for my cursor code (will add it to dlls/d3d9/tests). The biggest problem I am having is trying to keep a window drawn. Of course I could use sleep(), but then that soft-freezes my computer. I would like to make it part of our test-suite if possible. Perhaps I should use some sort of loop? Anyhow, thanks for any response. -- Andrew Riedi

1 0

Newbie question: WineLib DLLs
by Christian Eggers 05 May '07

05 May '07

Hello, I've created a (very) simple wine dll as described in "Building WineLib DLLs". This dll is a wrapper for the "ct-api" interface used for chipcard readers [1]. With this dll it's possible to use HBCI chipcards (for german online banking, [2]) together with Windows homebanking applications (for example "StarMoney", [3]). Usage: card reader - ct-api driver (hw specific) - symlink (libctapi.so) - wine dll - Windows application Problem: The dll is linked against an external (non-wine) shared lib. How can my dll be integrated in wine without forcing other users to get the external library in order to compile wine? Regards Christian [1] https://www.secure.trusted-site.de/Download/CTAPI/CTAPI11EN.PDF [2] http://www.hbci-zka.de/english/index.htm [3] http://www.starmoney.de

2 1

RE: [PATCH 3/3] winex11: Use TINN algorithm to speed up colour lookups.
by Vitaliy Margolen 05 May '07

05 May '07

Vitaly Budovski wrote: > Make use of the Triangle Inequality Nearest Neighbour algorithm to find the > nearest colour more efficiently than a simple linear search. The improvements > are most noticeable with a palette of 256 colours. Testing shows approximately > 3-4x performance increase for 256 colours. > --- Overall idea looks good, however the big problem with it is use of float point numbers. Fortunately you can get rid of them and use integers instead. Because you never use the distance in the calculations, but only to compare against other distances, you can skip "sqrt" and just compare squares, as the original code does. That will give you even more speed improvements. Few more nitpicks about this and other patches in the series: > +static int compare_distance(const void *left, const void *right) > +{ > + const struct tinn *l = left; > + const struct tinn *r = right; Please don't use void pointers. Use typed pointers, especially that you cast them to a hard-coded type. > +const void *init_tinn(struct tinn *dest, const void *buf, size_t num, > + size_t size, float (*distance)(const void *, const void *)) > +{ > + size_t i; > + size_t ref = rand() % num; I'm not so sure using random reference point really necessary. > +static struct tinn tinnPalette[256]; > + This won't work well with multi-threaded apps. You probably should make it on the stack for each X11DRV_DIB_SetImageBits_* function. Especially that some need only 2 elements. Btw, how big of the gain/loss whill there be for 1-bit and 4-bit DIBs? > + q.rgbRed = srcval.peRed; > + q.rgbGreen = srcval.peGreen; > + q.rgbBlue = srcval.peBlue; Looks much better, if written as: q = srcval; > - ((srcval >> 7) & 0xf8) | /* r */ > - ((srcval >> 12) & 0x07), > - ((srcval >> 2) & 0xf8) | /* g */ > - ((srcval >> 7) & 0x07), > - ((srcval << 3) & 0xf8) | /* b */ > - ((srcval >> 2) & 0x07) ) << (7-(x&7)) ); > + > + q.rgbRed = ((srcval >> 7) & 0xf8) | > + ((srcval >> 12) & 0x07); > + q.rgbGreen = ((srcval >> 2) & 0xf8) | > + ((srcval >> 7) & 0x07); > + q.rgbBlue = ((srcval << 3) & 0xf8) | > + ((srcval >> 2) & 0x07); What happened to the comments and alignment? Vitaliy Margolen.

3 4

Re: Fix xcopy so output is either unicode (console) or oem (file)
by Kirill K. Smirnov 05 May '07

05 May '07

В сообщении от 23 апреля 2007 16:11 вы написали: > "Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > >> >> The written strings in 866 and 1251 code pages are only readable > >> >> when output console code page matches the string encoding. > >> > > >> > This is in wine. > >> > In windows only cp866 is readable regardless of ConsoleOutputCP. > >> > >> As I said I tested under Windows (XP) only, and SetConsoleOutputCP > >> does change the behaviour of WriteConsoleA for me. If it wouldn't > >> I'd call it a bug. > > > > I tested under Windows 2003 and SetConsoleOutputCP does NOT change the > > behaviour of WriteConsoleA for me. > > Does Windows play us a trick? > > No the difference in observed behaviour was caused by the fact that I ran > the test under FAR, once I run it under cmd.exe I see what you do. Ahhh, I understood!!! You test does not return codepage back to 866. My version of your test does it. Far Manager somehow checks codepage and converts characters accordingly. I've removed the last convertion back to cp866 and observed the same behaviur as you. Thus, I can proclaim WriteConsoleA buggy. -- Kirill

2 2

RE: wine.inf: Add AllUsersProfile and associated entries to the registry [try 2].
by Vitaliy Margolen 05 May '07

05 May '07

Anything wrong with this 3 liner? Vitaliy Margolen wrote: > --- > tools/wine.inf | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) >

2 3

USB device support in wine
by Jon Burgess 05 May '07

05 May '07

Hi, I have found some talk of implementing USB device support in wine in this list some time ago (2005), but as far as I know, nothing ever came of it. I would perhaps be interested in getting this going again, as I have an application (Serato Scratch Live: http://www.rane.com/scratch.html) for which the software appears to run ok under wine (not that I am able to test much of its functionality on the other hand), but is utterly useless without support for its associated USB hardware device. Any ideas, or anyone else who would be interested in helping me? Regards, Jono

6 12

RE: Linuxworld San Francisco?
by Scott Ritchie 04 May '07

04 May '07

Oooh, I'll do it! Now I just need to come up with a specific topic other than "Wine" Thanks, Scott Ritchie On Fri, 2007-05-04 at 10:30 -0500, Jeremy White wrote: > Well, we'll be there with a booth. > > I think I've given enough Wine talks through the years at LinuxWorld > that they're tired of me :-/. But, to be honest, I don't think I submitted > a proposal this year. I think if someone else wanted to give the talk, > they'd probably appreciate a fresh face. > > Cheers, > > Jeremy > > > -----Original Message----- > > From: wine-devel-bounces(a)winehq.org > > [mailto:wine-devel-bounces@winehq.org] On Behalf Of Dan Kegel > > Sent: Friday, May 04, 2007 10:13 AM > > To: wine-devel(a)winehq.org > > Subject: Linuxworld San Francisco? > > > > Is anyone going to Linuxworld, August 6-9 in San Francisco? > > A guy working on a possible large migration > > said he'd be there, and was wondering if there's > > going to be a Wine BOF. > > I might go just to chat with him. > > > > Also, I see no Wine-related talks on the program. > > http://www.linuxworldexpo.com/live/12/events/12SFO07A/conferen > > ce/tracks > > If all the great stuff I expect actually happens > > this summer, there's going to be a lot to talk about, > > seems like a good year for a Wine talk there...? > > > > > > > > >

3 2

Re: [1/5] WineD3D: Software vertex blending
by H. Verbeet 04 May '07

04 May '07

On 04/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch makes a copy of the strided data from the device if needed, and it > explicitly fixes the fixed function data. > I still think messing with the strided data like that is rather hacky :-/

2 1

Re: [PATCH 2/3] Implement TINN algorithm.
by Michael Stefaniuc 04 May '07

04 May '07

Vitaly Budovski wrote: > > Implement the Triangle Inequality Nearest Neighbour algorithm as > described in > http://post.queensu.ca/~greensm/papers/tinn.pdf > --- > include/wine/tinn.h | 154 Do you need that somewhere else then in the X driver? If not putting that directly into dlls/winex11.drv/ makes more sense. > +++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 154 insertions(+), 0 deletions(-) bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 2

Linuxworld San Francisco?
by Dan Kegel 04 May '07

04 May '07

Is anyone going to Linuxworld, August 6-9 in San Francisco? A guy working on a possible large migration said he'd be there, and was wondering if there's going to be a Wine BOF. I might go just to chat with him. Also, I see no Wine-related talks on the program. http://www.linuxworldexpo.com/live/12/events/12SFO07A/conference/tracks If all the great stuff I expect actually happens this summer, there's going to be a lot to talk about, seems like a good year for a Wine talk there...?

2 2

re: Implement MsiBreak Feature - Bug 8243
by Dan Kegel 04 May '07

04 May '07

> Do we really need to write out unix pid? > AFAIK Winedbg can attach to windows process IDs just fine. Hrmph. The author did say in http://bugs.winehq.org/show_bug.cgi?id=8243 that he needed Windows PIDs, didn't say he needed Unix pids. so maybe you're right. Let's ask him. Hey, Anastasius, do you really need the unix pid? - Dan

1 1

OLE2A
by Bill Medland 04 May '07

04 May '07

Does anyone know where a call to OLE2A is going to enter wine? Presumably OLE2A returning null means that the thread ran out of stack space? Bill Medland

3 5

kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS & incorrect GetLastError() codes fix
by Kirill K. Smirnov 04 May '07

04 May '07

+/* 0x00..0x1f chars glyph map */ +static const WCHAR glyph_xlat[32] = { + 0x0000, 0x263A, 0x263B, 0x2665, 0x2666, 0x2663, 0x2662, 0x2219, + 0x25D8, 0x25CB, 0x25D9, 0x2642, 0x2640, 0x266A, 0x266B, 0x263C, + 0x25BA, 0x25C4, 0x2195, 0x203C, 0x00B6, 0x00A7, 0x25AC, 0x21A8, + 0x2191, 0x2193, 0x2192, 0x2190, 0x221F, 0x2194, 0x25B2, 0x25BC +}; + +/* adds glyphs to the string */ +static inline void add_glyphs( WCHAR *str, unsigned int length ) +{ + unsigned int i; + for (i=0; i!=length; i++) { + if (str[i]<0x20) str[i]=glyph_xlat[str[i]]; + } +} I propose to make this routine extern, because it is the simpliest way to make console renderer (I mean user backend of wineconsole) display the characters below 0x20 correct. The test: #include <windows.h> int main(void) { DWORD d; char str[32]; int i; GetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), &d); d &= ~ENABLE_PROCESSED_OUTPUT; SetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), d); for (i = 0; i < 32; i++) str[i] = i; WriteConsoleA(GetStdHandle(STD_OUTPUT_HANDLE), str, 32, &d, 0); d |= ENABLE_PROCESSED_OUTPUT; SetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), d); return 0; } Under wine we get strange symbols, under windows we get correct glyphs. If we perform the same character conversion in wineconsole/user.c just before actual text output, we get almost the same result that Windows does. The only difference is handling \0 symbol. -- Kirill

1 1

Re: [05/10] d3d: Fix the surface locking rectangle validation
by Stefan Dösinger 04 May '07

04 May '07

Am Donnerstag 03 Mai 2007 20:58 schrieb H. Verbeet: > Validation on the rectangle passed to LockRect/Lock is inconsistent > across ddraw/d3d8/d3d9. D3d9 doesn't do any validation at all, d3d8 > doesn't allow empty, flipped, mirrored, or out of bounds rectangles, > while ddraw does allow empty rectangles, but not flipped, mirrored or > out of bounds ones. Tests for this are in the next few patches in this > set. You have to take care for IDirectDrawSurface::Blt and BltFast too, because parts of the Blt rectangle checks were done by Lock()

1 0

Re: [4/5] WineD3D: Implement vertex blending using GL_ARB_vertex_blend
by H. Verbeet 04 May '07

04 May '07

Actually, I only thought about this just now, but you should also call glDisableClientState(GL_WEIGHT_ARRAY); in unloadVertexData().

2 1

Re: Unsecured API functions
by Tom Spear 04 May '07

04 May '07

On 5/3/07, Robert Shearman <rob(a)codeweavers.com> wrote: > Tom Spear wrote: > > I was writing up a Hello World with input program for a demonstration > > for a non-developer coworker last week, and used the unsecured getch() > > and got the standard warning about how it was unsecured and dangerous > > to use that. That prompted me to look up the basic secured functions > > on the MS website, and compare to wine code. According to MSDN, > > things like gets have been replaced with gets_s. However, as far as I > > can tell, wine still only implements gets for Windows programs to > > use.. Do we implement secured versions of other functions, and if > > not, how come? > > Q: Why doesn't Wine implement X? > A: Because not many programs use it and no-one has felt interested in > implementing it for fun. So in other words, most programs use insecure functions (like gets) instead of using secure functions (like gets_s), leaving themselves vulnerable to all sorts of buffer overflows? I wonder if microsoft doesn't silently convert gets calls to gets_s calls, then, and maybe didn't document that? Otherwise I assume there would be thousands of buffer overflows that (malicious) people would exploit. I understand that most programs dont use either of those functions, but there are others that are used by nearly every program that ms deprecated in favor of secure versions. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

5 6

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS & incorrectGetLastError() codes fix
by Dmitry Timoshkov 04 May '07

04 May '07

"Andrew O. Shadoura" <bugzilla(a)tut.by> wrote: > This patch implements MB_USEGLYPHCHARS flag in MultiByteToWideChar function > and fixes incorrect error codes (in case of CP_SYMBOL charset non-zero dwFlags > should give ERROR_INVALID_FLAGS, not ERROR_INVALID_PARAMETER, almost the same > with CP_UTF8, but "dwFlags must be set to either 0 or MB_ERR_INVALID_CHARS" > according to MSDN: http://msdn2.microsoft.com/en-us/library/ms776413.aspx > Also, test case is added. Please follow the existing code style of the files you're changing (indentation, braces, spaces), don't mix tabs and spaces. > + for (i=0; i!=length; i++) { > + if (str[i]<0x20) str[i]=glyph_xlat[str[i]]; > + } This is rather an unusual style of breaking out of the loop, 'i < length' is less confusing IMO. -- Dmitry.

1 0

dinput : crash of Pro Evolution Soccer 3 with a joystick
by Sébastien GRIPON 04 May '07

04 May '07

Hi, I try to play to Pro Evolution Soccer 3 on my Ubuntu Fesity Fawn and it's not far to be possible. Every wine release brings a lots of wined3d improvements and pes3 is almost playable. Many textures are missing, but it's on a good way. Congratulations ! However, I have a problem with my joystick. I have a Microsoft Sidewinder and a Thrustmaster and when any of them is plugged on an USB port, the exe pes3.exe or the PES configuration tool setting.exe crash. This crash doesn't occur when joysticks are not pluggued. I tried to debug this crash, but it is a very hard work. I think dinput is involved but I can't be sure. If you're interesting in this game, this is the crash dump. Thank you, Seb. $ wine setting.exe fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE wine: Unhandled page fault on read access to 0x00000000 at address (nil) (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00000000). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:00000000 ESP:0033f518 EBP:0058b2a8 EFLAGS:00210246( - 00 -RIZP1) EAX:00182c18 EBX:00000000 ECX:7da5bc00 EDX:00181bfc ESI:0058ad38 EDI:00000000 Stack dump: 0x0033f518: 00407eab 00182c18 004363fc 00000000 0x0033f528: 0043e4c0 0043fac4 00000000 0040814e 0x0033f538: 00181bf8 00000003 7da58b08 0033fa20 0x0033f548: 7da5af6c 0058ad38 00007734 90234a8d 0x0033f558: f7bdb63f 00003020 0033f658 7da4bc9f 0x0033f568: 7e4fa15f 7e4c2cd0 0033fa78 0042f0bb Backtrace: =>1 0x00000000 (0x0058b2a8) 2 0x00000000 (0x00182c18) 3 0x00000001 (0x7da5bc00) 4 0x00000000 (0x00000000) 0x00000000: addb %al,0x0(%eax) Modules: Module Address Debug info Name (96 modules) PE 400000- 464000 Deferred setting ELF 7b800000-7b927000 Deferred kernel32<elf> \-PE 7b820000-7b927000 \ kernel32 ELF 7bc00000-7bc96000 Deferred ntdll<elf> \-PE 7bc10000-7bc96000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7ccdb000-7ccf0000 Deferred midimap<elf> \-PE 7cce0000-7ccf0000 \ midimap ELF 7ccf0000-7cd16000 Deferred msacm32<elf> \-PE 7cd00000-7cd16000 \ msacm32 ELF 7cd16000-7cd2e000 Deferred msacm32<elf> \-PE 7cd20000-7cd2e000 \ msacm32 ELF 7cd2e000-7cd6a000 Deferred wineoss<elf> \-PE 7cd40000-7cd6a000 \ wineoss ELF 7cd6a000-7cdbb000 Deferred libgcrypt.so.11 ELF 7cdbb000-7cdd0000 Deferred libtasn1.so.3 ELF 7cdd0000-7cdfe000 Deferred libcrypt.so.1 ELF 7ce11000-7ce81000 Deferred libgnutls.so.13 ELF 7ce81000-7ceb2000 Deferred libcups.so.2 ELF 7d1e7000-7d1eb000 Deferred libgpg-error.so.0 ELF 7d1eb000-7d21d000 Deferred uxtheme<elf> \-PE 7d1f0000-7d21d000 \ uxtheme ELF 7d21f000-7d224000 Deferred libxfixes.so.3 ELF 7d224000-7d22d000 Deferred libxcursor.so.1 ELF 7d22d000-7d233000 Deferred libxrandr.so.2 ELF 7d233000-7d23b000 Deferred libxrender.so.1 ELF 7d23b000-7d23e000 Deferred libxinerama.so ELF 7d764000-7d7f3000 Deferred winex11<elf> \-PE 7d770000-7d7f3000 \ winex11 ELF 7d89c000-7d8bc000 Deferred libexpat.so.1 ELF 7d8bc000-7d8e7000 Deferred libfontconfig.so.1 ELF 7d8e7000-7d8fb000 Deferred libz.so.1 ELF 7d8fb000-7d966000 Deferred libfreetype.so.6 ELF 7d966000-7d97a000 Deferred oleacc<elf> \-PE 7d970000-7d97a000 \ oleacc ELF 7d97a000-7d997000 Deferred imm32<elf> \-PE 7d980000-7d997000 \ imm32 ELF 7d997000-7da26000 Deferred winmm<elf> \-PE 7d9a0000-7da26000 \ winmm ELF 7da26000-7da5c000 Deferred dinput<elf> \-PE 7da30000-7da5c000 \ dinput ELF 7da5c000-7da75000 Deferred dinput8<elf> \-PE 7da60000-7da75000 \ dinput8 ELF 7dad8000-7e35e000 Deferred libglcore.so.1 ELF 7e35e000-7e3de000 Deferred libglu.so.1 ELF 7e3de000-7e46a000 Deferred libgl.so.1 ELF 7e46a000-7e55b000 Deferred libx11.so.6 ELF 7e55b000-7e569000 Deferred libxext.so.6 ELF 7e569000-7e581000 Deferred libice.so.6 ELF 7e581000-7e642000 Deferred wined3d<elf> \-PE 7e590000-7e642000 \ wined3d ELF 7e642000-7e66a000 Deferred d3d8<elf> \-PE 7e650000-7e66a000 \ d3d8 ELF 7e66a000-7e705000 Deferred oleaut32<elf> \-PE 7e680000-7e705000 \ oleaut32 ELF 7e705000-7e718000 Deferred libresolv.so.2 ELF 7e718000-7e736000 Deferred iphlpapi<elf> \-PE 7e720000-7e736000 \ iphlpapi ELF 7e736000-7e78b000 Deferred rpcrt4<elf> \-PE 7e740000-7e78b000 \ rpcrt4 ELF 7e78b000-7e828000 Deferred ole32<elf> \-PE 7e7a0000-7e828000 \ ole32 ELF 7e828000-7e84a000 Deferred oledlg<elf> \-PE 7e830000-7e84a000 \ oledlg ELF 7e84a000-7e87d000 Deferred winspool<elf> \-PE 7e850000-7e87d000 \ winspool ELF 7e87d000-7e939000 Deferred comctl32<elf> \-PE 7e890000-7e939000 \ comctl32 ELF 7e939000-7e991000 Deferred shlwapi<elf> \-PE 7e950000-7e991000 \ shlwapi ELF 7e991000-7ea8c000 Deferred shell32<elf> \-PE 7e9a0000-7ea8c000 \ shell32 ELF 7ea8c000-7eb2c000 Deferred comdlg32<elf> \-PE 7ea90000-7eb2c000 \ comdlg32 ELF 7eb2c000-7eb73000 Deferred advapi32<elf> \-PE 7eb40000-7eb73000 \ advapi32 ELF 7eb73000-7eb7f000 Deferred libgcc_s.so.1 ELF 7eb81000-7eb86000 Deferred libxdmcp.so.6 ELF 7eb86000-7eb89000 Deferred libxau.so.6 ELF 7eb89000-7eb92000 Deferred libsm.so.6 ELF 7ec7c000-7ed3a000 Deferred gdi32<elf> \-PE 7ec90000-7ed3a000 \ gdi32 ELF 7ed3a000-7ee76000 Deferred user32<elf> \-PE 7ed60000-7ee76000 \ user32 ELF 7efa4000-7efaf000 Deferred libnss_files.so.2 ELF 7efaf000-7efc6000 Deferred libnsl.so.1 ELF 7efc6000-7efed000 Deferred libm.so.6 ELF 7efed000-7eff7000 Deferred libnss_nis.so.2 ELF 7eff7000-7f000000 Deferred libnss_compat.so.2 ELF b7d51000-b7d56000 Deferred libxxf86vm.so.1 ELF b7d57000-b7d5b000 Deferred libdl.so.2 ELF b7d5b000-b7e9c000 Deferred libc.so.6 ELF b7e9d000-b7eb4000 Deferred libpthread.so.0 ELF b7eb4000-b7eb6000 Deferred libnvidia-tls.so.1 ELF b7ec7000-b7fd8000 Deferred libwine.so.1 ELF b7fda000-b7ff5000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000a 0000000c 0 0000000b 0 00000008 (D) C:\Program Files\KONAMI\Pro Evolution Soccer 3\setting.exe 0000000d 0 00000009 0 <==

2 1

Unsecured API functions
by Tom Spear 04 May '07

04 May '07

I was writing up a Hello World with input program for a demonstration for a non-developer coworker last week, and used the unsecured getch() and got the standard warning about how it was unsecured and dangerous to use that. That prompted me to look up the basic secured functions on the MS website, and compare to wine code. According to MSDN, things like gets have been replaced with gets_s. However, as far as I can tell, wine still only implements gets for Windows programs to use.. Do we implement secured versions of other functions, and if not, how come? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 2

Re: Boundary test cases for SystemTimeToFileTime and GetDateFormat
by James Hawkins 03 May '07

03 May '07

On 5/3/07, Bill Medland <billmedland(a)shaw.ca> wrote: > Bill Medland (billmedland(a)shaw.ca) > Lower boundary test cases for SystemTimeToFileTime and GetDateFormat > > Index: wine/dlls/kernel32/tests/locale.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel32/tests/locale.c,v > retrieving revision 1.11 > diff -u -r1.11 locale.c > --- wine/dlls/kernel32/tests/locale.c 2 Apr 2007 11:24:36 -0000 1.11 > +++ wine/dlls/kernel32/tests/locale.c 3 May 2007 22:21:55 -0000 > @@ -424,6 +424,34 @@ > STRINGSW("dddd d MMMM yyyy","Wednesday 23 October 2002"); /* Incorrect DOW and time */ > ret = GetDateFormatW (lcid, 0, &curtime, input, buffer, COUNTOF(buffer)); > EXPECT_VALID; EXPECT_LENW; EXPECT_EQW; > + > + /* Limit tests */ > + > + curtime.wYear = 1601; > + curtime.wMonth = 1; > + curtime.wDay = 1; > + curtime.wDayOfWeek = 0; /* Irrelevant */ > + curtime.wHour = 0; > + curtime.wMinute = 0; > + curtime.wSecond = 0; > + curtime.wMilliseconds = 0; > + STRINGSW("dddd d MMMM yyyy","Monday 1 January 1601"); > + SetLastError(0xdeadbeef); > + ret = GetDateFormatW (lcid, 0, &curtime, input, buffer, COUNTOF(buffer)); > + EXPECT_VALID; EXPECT_LENW; EXPECT_EQW; > + > + curtime.wYear = 1600; > + curtime.wMonth = 12; > + curtime.wDay = 31; > + curtime.wDayOfWeek = 0; /* Irrelevant */ > + curtime.wHour = 23; > + curtime.wMinute = 59; > + curtime.wSecond = 59; > + curtime.wMilliseconds = 999; > + STRINGSW("dddd d MMMM yyyy","Friday 31 December 1600"); > + SetLastError(0xdeadbeef); > + ret = GetDateFormatW (lcid, 0, &curtime, input, buffer, COUNTOF(buffer)); > + EXPECT_INVALID; > } > > > Index: wine/dlls/kernel32/tests/time.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel32/tests/time.c,v > retrieving revision 1.3 > diff -u -r1.3 time.c > --- wine/dlls/kernel32/tests/time.c 4 Jan 2007 10:46:26 -0000 1.3 > +++ wine/dlls/kernel32/tests/time.c 3 May 2007 22:22:04 -0000 > @@ -73,6 +73,23 @@ > (st).wSecond = 32; \ > (st).wMilliseconds = 123; > > +#define SETUP_ZEROTIME(st) \ > + (st).wYear = 1601; \ > + (st).wMonth = 1; \ > + (st).wDay = 1; \ > + (st).wHour = 0; \ > + (st).wMinute = 0; \ > + (st).wSecond = 0; \ > + (st).wMilliseconds = 0; > + > +#define SETUP_EARLY(st) \ > + (st).wYear = 1600; \ > + (st).wMonth = 12; \ > + (st).wDay = 31; \ > + (st).wHour = 23; \ > + (st).wMinute = 59; \ > + (st).wSecond = 59; \ > + (st).wMilliseconds = 999; > > > static void test_conversions(void) > @@ -82,6 +99,12 @@ > > memset(&ft,0,sizeof ft); > > + SETUP_EARLY(st) > + ok ((!SystemTimeToFileTime(&st, &ft) && GetLastError() == ERROR_INVALID_PARAMETER), "Conversion failed EARLY\n"); > + > + SETUP_ZEROTIME(st) > + ok (SystemTimeToFileTime(&st, &ft) && ft.dwHighDateTime == 0 && ft.dwLowDateTime == 0, "Conversion failed ZERO_TIME\n"); > + You need to check each part of those conditions separately in their own ok()'s. -- James Hawkins

1 0

tools/winegcc solaris link options patch
by sol11x86＠comcast.net 03 May '07

03 May '07

Please comment on this patch: This patch adds two options to toool/winegcc to allow Solaris linker flags to be passed through and recognized. Prior to this patch, libraries compiled with winegcc (despite overloading every link related env variable I could think of), had a single RPATH when evaulated with elfdump (which was the primary library from the compiler). The effect was that I was required to set an LD_LIBRARY_PATH prior to running any of the wine applications, since the RPATH was not fully populated. With this patch, and proper configuration of LDFLAGS, I am now able to build wine on Solaris without having to resort to an LD_LIBRARY_PATH when I run wine. The two flags that are added to winegcc.c are: -R <libdir> -z <linker flags> (-z allows me to control the link phase a little better for performance reasons). Thanks to Steleman who quickly recognized the problem, despite the facts were staring me in the face. Ben

1 0

Re: Implement MsiBreak Feature - Bug 8243
by James Hawkins 03 May '07

03 May '07

On 5/2/07, EA Durbin <ead1234(a)hotmail.com> wrote: > patch created by Anastasius Focht for Bug 8243. > + /* check "MsiBreak" environment variable */ + if( GetEnvironmentVariableW( envMsiBreakW, envMsiBreakValueW, MAX_PATH)) + { I think we need more investigation into this before accepting this patch. One of the things that needs to be checked is whether the windows installer checks the environment variable every single time a custom action is called, or if the environment variable is stored at the beginning of the installation and just the custom action name is checked every time a custom action is called. This can be tested on windows by setting MsiBreak to a certain custom action, and then change the environment variable to a different custom action while the message box is still asking to break. If the installer breaks on the next custom action, we'll know that it checks the environment variable each time. -- James Hawkins

1 0

Re: Implement MsiBreak Feature - Bug 8243
by Peter Oberndorfer 03 May '07

03 May '07

On Thursday 03 May 2007 05:45, EA Durbin wrote: Hi, > patch created by Anastasius Focht for Bug 8243. > >+#include <sys/types.h> /* for getpid() */ >+#include <unistd.h> /* for getpid() */ Do we really need to write out unix pid? AFAIK Winedbg can attach to windows process IDs just fine. >+ if( MessageBoxW( NULL, dbgMsgW, CustomActionName, MB_OKCANCEL) == IDOK) >+ { >+ return TRUE; >+ } nitpick: maybe remove {} to be consistent with rest of file? >+ if( IsMsiBreak( info->target)) >+ DebugBreak(); extra nitpick: maybe remove space before argument or place additional space before closing ) like foo( baz ); / foo(baz); It also seems like the patch is line wrapped. Greetings Peter

1 0

Re: Some Spanish translation updates
by Alexandre Julliard 03 May '07

03 May '07

José Manuel Ferrer Ortiz <jmfo1982(a)yahoo.es> writes: > By the way, I've changed the license of the files > 'oledlg/oledlg_Es.rc' and 'shdoclc/Es.rc' (I was the creator of > these two files) to LPGL version 2.1 (and not any later). Please don't do that. All of Wine should be under the same license, otherwise it will create major confusion. -- Alexandre Julliard julliard(a)winehq.org

1 0

What's the long term plan for 64 bit support?
by Scott Ritchie 03 May '07

03 May '07

In the (distant) future, will we support building Wine with both 64 bit and 32 bit libraries, and then the same Wine installation will run both 64 bit and 32 bit apps? As I understand it, this is the way Windows does in its 64 bit versions. I ask because there's a question of how to name the Wine packages for the 64 bit distribution - there's a standard of naming 32 bit packages something like "wine32", but if we're eventually going to have a unified multiarch package then we can still go with just keeping it as "wine" Thanks, Scott Ritchie

3 3

Re: [5/5] WineD3D: Software vertex blending
by H. Verbeet 03 May '07

03 May '07

>+ for(i = 0; i < 16 /* Max vertex attribs */; i++) { I think you should be using MAX_ATTRIBS there. Changing the strided data like that in drawPrimitive looks rather hacky to me.

2 2

Bug in Advapi32: CryptEnumProviderTypesA and CryptEnumProvidersA
by Mounir IDRASSI 02 May '07

02 May '07

Hi, During our tests of wine with our cryptographic suite, we have found a bug in the functions CryptEnumProviderTypesA and CryptEnumProvidersA in advapi32 dll: In case of failure, they both report a wrong last error through GetLastError. We have found and corrected the source of the bug: They both call their wide-char counterpart but they don't test the success of this call. The correction is simple: add an if statement and return immediately in case of error. I have attached a small patch with our correction. Should we fill a bugzilla report before submitting the patch? Thanks. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr >From ab7323952138e725700ded1bad4afd17e42717e7 Mon Sep 17 00:00:00 2001 From: Mounir IDRASSI <mounir.idrassi(a)idrix.fr> Date: Wed, 2 May 2007 20:20:59 +0200 Subject: Correct bug in CryptEnumProviderTypesA and CryptEnumProvidersA: They report wrong last error in case of failure --- dlls/advapi32/crypt.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/advapi32/crypt.c b/dlls/advapi32/crypt.c index 1fd16c3..a7273b9 100644 --- a/dlls/advapi32/crypt.c +++ b/dlls/advapi32/crypt.c @@ -1139,7 +1139,8 @@ BOOL WINAPI CryptEnumProvidersA (DWORD dwIndex, DWORD *pdwReserved, TRACE("(%d, %p, %08x, %p, %p, %p)\n", dwIndex, pdwReserved, dwFlags, pdwProvType, pszProvName, pcbProvName); - CryptEnumProvidersW(dwIndex, pdwReserved, dwFlags, pdwProvType, NULL, &strlen); + if(!CryptEnumProvidersW(dwIndex, pdwReserved, dwFlags, pdwProvType, NULL, &strlen)) + return FALSE; if ( pszProvName && !(str = CRYPT_Alloc(strlen)) ) { SetLastError(ERROR_NOT_ENOUGH_MEMORY); @@ -1267,7 +1268,8 @@ BOOL WINAPI CryptEnumProviderTypesA (DWORD dwIndex, DWORD *pdwReserved, TRACE("(%d, %p, %08x, %p, %p, %p)\n", dwIndex, pdwReserved, dwFlags, pdwProvType, pszTypeName, pcbTypeName); - CryptEnumProviderTypesW(dwIndex, pdwReserved, dwFlags, pdwProvType, NULL, &strlen); + if(!CryptEnumProviderTypesW(dwIndex, pdwReserved, dwFlags, pdwProvType, NULL, &strlen)) + return FALSE; if ( pszTypeName && !(str = CRYPT_Alloc(strlen)) ) { SetLastError(ERROR_NOT_ENOUGH_MEMORY); -- 1.4.4.2

2 1

Any way to get the current code besides git?
by Tom Spear 02 May '07

02 May '07

I'm having an issue using git at work, where it will start downloading the packs, and then just stalls out at the same pack every time.. This has occurred since I first started working here Maybe someone knows the problem, and a solution? If not, is there a way to get git to show file names instead of md5 sums, like cvs did, back when we used it, so I can at least know what file is causing the problem? If there is no solution, then maybe someone does know where I can get current code aside from git? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 7

Patch question
by Tom Spear 02 May '07

02 May '07

Just curious if there was something wrong with the regedit patch I sent on Friday, or if maybe there is a particular reason that the /C was left out of the code in the first place, that I am missing, and would help me to understand. http://www.winehq.org/pipermail/wine-patches/2007-April/038652.html -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: Adding header files for the implementation of Winscard dll (Smart Cards support)
by Dmitry Timoshkov 02 May '07

02 May '07

"Mounir IDRASSI" <mounir.idrassi(a)idrix.fr> wrote: > diff --git a/include/scarderr.h b/include/scarderr.h > new file mode 100755 > index 0000000..c07833e > --- /dev/null > +++ b/include/scarderr.h ... > diff --git a/include/winscard.h b/include/winscard.h > new file mode 100755 > index 0000000..f302a9f > --- /dev/null > +++ b/include/winscard.h ... > diff --git a/include/winsmcrd.h b/include/winsmcrd.h > new file mode 100755 > index 0000000..cc03a35 > --- /dev/null > +++ b/include/winsmcrd.h This is a notice more for Alexandre this time, but next time please make sure to send the files with exec bits turned off (755 -> 644). -- Dmitry.

2 1

Re: Any way to get the current code besides git?
by EA Durbin 01 May '07

01 May '07

If you use the cvs web browser interface and view for example the dll msi and sort by age you will see the recent patches that have been applied show up here with the time they were applied. It is currently showing ones applied 8 hours ago. >From: sol11x86(a)comcast.net (Ben Taylor) >To: "EA Durbin" <ead1234(a)hotmail.com> >Subject: Re: Any way to get the current code besides git? >Date: Tue, 01 May 2007 20:39:04 +0000 > > -------------- Original message ---------------------- >From: "EA Durbin" <ead1234(a)hotmail.com> > > I had issues with older versions of git. > > > > I think cvs still works. > > > > http://winehq.org/site/cvs > >Yeah, but I'm not sure it's really current. It seemed to me >that the CVS code was just what was in the current release, >not what is current in git. I know because some patches I >had submitted and accepted to git weren't in the CVS download. > >Ben _________________________________________________________________ Interest Rates NEAR 39yr LOWS! $430,000 Mortgage for $1,299/mo - Calculate new payment http://www.lowermybills.com/lre/index.jsp?sourceid=lmb-9632-19132&moid=14888

1 0

Re: [try2] gdi32 : Completes WidenPath Implementation
by Laurent Vromman 01 May '07

01 May '07

I have sent this patch last week with the correction Alexandre asked me to do. It is still not on the repository. Is there anything wrong again ? Any comments are welcomed and will be applied if necessary. Laurent Laurent Vromman a écrit : > This second try includes Alexandre comments and removes some obsolete > FIXME > Changelog : > Completes WidenPath implementation. > WidenPath recognizes PS_JOINs and PS_ENDCAPs > > --- > dlls/gdi32/path.c | 298 > +++++++++++++++++++++++++++++++++++++++++------------ > 1 files changed, 230 insertions(+), 68 deletions(-)

2 1

Fw: [PATCH] CMD.exe: Remove code duplication for _splitpath
by Ann & Jason Edmeades 01 May '07

01 May '07

"Alexandre Julliard" <julliard(a)winehq.org> wrote in message news:<87d51qw39a.fsf(a)wine.dyndns.org>... > Jason Edmeades <us(a)edmeades.me.uk> writes: > > > Note: This makes cmd.exe pull in msvcrt, but so does native > > Native doesn't have a choice, but we do. Unless there are good reasons > to import msvcrt it's better to stick to standard libc. > Well, I am trying to convert cmd.exe to unicode, and was hoping to use the wide crt functions to replace e.g. strstr, strdup etc. This way it's a relatively simple transition from char to WCHAR without having to rewrite other functions. LstrcatW and lstrcpyW help, but there's other functions with no non-CRT equivalents. Does this change your mind? :-) Jason

2 1

Re: http access ot GIT?
by sol11x86＠comcast.net 01 May '07

01 May '07

-------------- Original message ---------------------- From: "H. Verbeet" <hverbeet(a)gmail.com> > On 01/05/07, Tom Spear <speeddymon(a)gmail.com> wrote: > > Did you try changing the git:// to http:// ? That is supposed to > > work thru port 80 with or without squid. YMMV > > > IIRC you need to set the http_proxy env. var correctly as well. > Yep. needed to update the remote.origin.url and then setup the http_proxy env variable, and it all worked. Ben

1 0

Re: http access ot GIT?
by Tom Spear 01 May '07

01 May '07

On 5/1/07, Ben Taylor <sol11x86(a)comcast.net> wrote: > > -------------- Original message ---------------------- > From: "Tom Spear" <speeddymon(a)gmail.com> > > On 5/1/07, Ben Taylor <sol11x86(a)comcast.net> wrote: > > > > > > Found myself behind an http-proxy and can't seem to find the magic > > > to use the http proxy to update my git archive. Is there a way to use > > > an http proxy (squid) with wine's git? > > > > What error are you getting? If no error, then if you to try to clone > > the whole repository, does it get to a point and then just sit there? > > > fatal: Unable to look up source.winehq.org (port 9418) (Name or service not konwn) > Cannot get the repository state from git://source.winehq.org/git/wine.git > > I've setup an http_proxy according to the documentation I've found on the > web. There's just not a lot out there that is specific to this conifguration. Did you try changing the git:// to http:// ? That is supposed to work thru port 80 with or without squid. YMMV -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 1

Direct3D viewport problems
by Robert Fairlie 01 May '07

01 May '07

Hello, I'm having problems with DirectX viewports under Wine. I'm rendering to an offscreen surface and then copying the contents of the offscreen surface to a window. I first set the viewport to coincide with the window, i.e. vp.X = 0; vp.Y = 0; vp.Width = windowRect.Width(); vp.Height = windowRect.Height(); I render most of the the scene using the above viewport. I then need to draw an arrow in the bottom left hand corner of the of the window inside a square of side iSize, so I set: vp.X = 0; vp.Y = windowRect.Height() - iSize; vp.Width = iSize; vp.Height = iSize; Since iSize is only about a fifth of the window height, I would expect the arrow to be displayed at the bottom left of the window. but it's actually being displayed at the top left. The main part of the scene rendered with the first viewport settings is fine. The code does as expected in Windows, so I was wondering if anyone knows of any problems in this area. I'm also having problems with CD3DFont which I think might be related to this. Thanks for any advice, Robert Fairlie

3 2

Compiling 32bit winelib apps on x86_64
by Stefan Brüns 01 May '07

01 May '07

Hi, I had some problems compiling 32bit winelib apps on x86_64 - the tools tried to build for 64bit all the time. I had to change a few things in the winemaker created Makefile to make it work: <>_exe_LDFLAGS: added "-Wb,--as-cmd='as --32',--ld-cmd='ld -melf_i386'" CC: added "-m32" CXX: added "-m32" After applying the changes, everything worked as expected. Greetings, Stefan -- Stefan Brüns / Kastanienweg 6 - Zimmer 1206 / 52074 Aachen mailto:lurch@gmx.li http://www.kawo1.rwth-aachen.de/~lurchi/ phone: +49 241 169-4206 mobile: +49 160 3797725

1 0

http access ot GIT?
by sol11x86＠comcast.net 01 May '07

01 May '07

Found myself behind an http-proxy and can't seem to find the magic to use the http proxy to update my git archive. Is there a way to use an http proxy (squid) with wine's git? Ben

2 1

Offer to upgrade the winehq Bugzilla
by Jan Zerebecki 01 May '07

01 May '07

The guy (nick mkanat) who admins buggbot on freenode (see ##bugzilla-world ) said he would upgrade our bugzilla for us, paid by his company "in exchange for a link in the footer or front page, just mentioning that we did the upgrade". I'm not sure how much a link on the bugzilla page footer/menu is worth in advertising revenue. There is already one on the wiki. So maybe something like that link for a year in exchange for the full upgrade work (producing and testing the diff for cvs and the upgrade sql-script and fixing anything that breaks) sounds like a fair deal. What should I respond? Jan

2 1

How do I put a table of contents on one of our wiki pages?
by Scott Ritchie 01 May '07

01 May '07

The new FAQ is coming along fairly well, however it obviously needs a table of contents at this point. I combed through the documentation, but can't find anything. Does someone know? Thanks, Scott Ritchie

2 1

Re: [PATCH 9/11] msi: automation: Expose Installer object.
by Alexandre Julliard 01 May '07

01 May '07

Misha Koshelev <mk144210(a)bcm.edu> writes: > --- > dlls/msi/automation.c | 6 ++++++ > dlls/msi/msi_main.c | 6 ------ > dlls/msi/msipriv.h | 3 +++ > dlls/msi/tests/automation.c | 38 +++++++++++++++++++++++++------------- The tests fail here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so automation.c && touch automation.ok automation.c:353: Test failed: dispid wrong automation.c:475: Tests skipped: failed to create record automation.c:516: Test failed: IDispatch::GetIDsOfNames returned 0x80020006 automation.c:545: Test failed: IDispatch::Invoke returned 0x80020003 automation.c:558: Test failed: IDispatch::GetIDsOfNames returned 0x80020006 automation.c:1046: Test failed: Installer_OpenPackage failed, hresult 0x80020006 make: *** [automation.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: provide a workaround for apps that need 32-bit screen depth
by Chris Robinson 30 Apr '07

30 Apr '07

On Monday 30 April 2007 01:25:02 pm Louis. Lenders wrote: > AFAICS there's no real fix for this now, > as X11 visual reports back screendepth 24. Even by setting the registrykey > "ScreenDepth" to 32, the applications fail. I actually had a semi-working fix for this. What I did was create a small, temporary pixmap at initialization using the same visual as the screen, then getting the pixmap's bpp value, which would correctly give 32bpp that winex11.drv could then use to report for BITSPIXEL. It would also still work for 16 and true 24bpp modes. However, the problem is that there's places that assume BITSPIXEL is the same as the color depth (which for the case of 32bpp, is not true).

1 0

Re: dsound: PrimarySetFormat patch, dsound does not properly support audio > 2 channel - try 2
by Chris Robinson 30 Apr '07

30 Apr '07

On Monday 30 April 2007 04:15:41 am Dylan Taft wrote: > + if (wfex->nChannels > 2) { > + FIXME("Currently only supports 2 channels, returning > DSERR_BADFORMAT. (requested channels=%d)\n",wfex->nChannels); > + return DSERR_BADFORMAT; > + } The function is not supposed to fail if it's trying to set an unsupported format with a priority level of DSSCL_PRIORITY. It should instead just set the closest possible. The function *should*, however, fail like that if using the DSSCL_WRITEPRIMARY priority level.

1 0

wine killing X?
by Juan Lang 30 Apr '07

30 Apr '07

I just upgraded to the latest wine version and tried wineprefixcreate (no .wine directory), and it kills X. Nvidia drivers 1.0.9755. Anyone else see this? --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

6 6

Re: [localui} New Korean Resource
by Detlef Riekenberg 30 Apr '07

30 Apr '07

On Mo, 2007-04-30 at 08:21 +0900, Hwang YunSong(황윤성) wrote: > --- /dev/null 2007-04-30 07:48:17.228075573 +0900 > +++ ui_Ko.rc 2007-04-30 08:22:30.000000000 +0900 I asked another Translator to pause a week, until the Patches with the dialogs are in the tree. (Patch for AddPortUI was send today, so only one Dialog left). A Patch with Resources for many Languages grow really fast. Thanks for your Help. -- By by ... Detlef

1 0

Re: Extensive ScrollDC investigation
by Dmitry Timoshkov 30 Apr '07

30 Apr '07

"Aric Stewart" <aric(a)codeweavers.com> wrote: > Reworking some parts of ScrollDC to properly mask and scroll the right > areas of the DC as well as generate the correct update regions. > Extensive testing used to verify the behavior. This test hangs forever for me under XP displaying a listbox with "ENTRY xx" entries if winetest_debug != 0. Once I forcibly set winetest_debug = 0 the test never produces test statistics (failed, skipped). The whole idea of playing with winetest_debug and DRAW_CHECK inside of the drawing test looks broken to me. -- Dmitry.

4 4

RE: Extensive ScrollDC investigation
by Jeremy White 30 Apr '07

30 Apr '07

Woot! This fixes a long standing bug in Quickbooks for me (I can now scroll my report windows without nasty repainting artifacts). Cheers, Jeremy > -----Original Message----- > From: wine-patches-bounces(a)winehq.org > [mailto:wine-patches-bounces@winehq.org] On Behalf Of Aric Stewart > Sent: Sunday, April 29, 2007 4:53 PM > To: wine-patches > Subject: Extensive ScrollDC investigation > > Reworking some parts of ScrollDC to properly mask and scroll > the right > areas of the DC as well as generate the correct update regions. > Extensive testing used to verify the behavior. > --- > dlls/user32/tests/win.c | 316 > +++++++++++++++++++++++++++++++++++++++++++++ > dlls/winex11.drv/scroll.c | 64 +++++++++- > 2 files changed, 377 insertions(+), 3 deletions(-) >

1 0

Re: dbghelp: Directly use Heap functions.
by Dmitry Timoshkov 30 Apr '07

30 Apr '07

"Markus Amsler" <markus.amsler(a)oribi.org> wrote: > void pool_destroy(struct pool* pool) > { > - struct pool_arena* arena; > - struct pool_arena* next; > - > -#ifdef USE_STATS > - unsigned alloc, used, num; > - > - for (alloc = used = num = 0, arena = pool->first; arena; arena = arena->next) > - { > - alloc += pool->arena_size; > - used += arena->current - (char*)arena; > - num++; > - } > - FIXME("STATS: pool %p has allocated %u kbytes, used %u kbytes in %u arenas,\n" > - "\t\t\t\tnon-allocation ratio: %.2f%%\n", > - pool, alloc >> 10, used >> 10, num, 100.0 - (float)used / (float)alloc * 100.0); > -#endif > - > - for (arena = pool->first; arena; arena = next) > - { > - next = arena->next; > - HeapFree(GetProcessHeap(), 0, arena); > - } > - pool_init(pool, 0); > + return; > } The old code at least bothered to actually free some memory. -- Dmitry.

3 4

Re: [PATCH 2/11] msi: Add base class for OLE automation objects.
by Alexandre Julliard 30 Apr '07

30 Apr '07

Misha Koshelev <mk144210(a)bcm.edu> writes: > +interface AutomationObject { > + /* > + * VTables - We provide IDispatch, IProvideClassInfo, IProvideClassInfo2, IProvideMultipleClassInfo > + */ > + const IDispatchVtbl *lpVtbl; > + const IProvideClassInfoVtbl *lpvtblIProvideClassInfo; > + const IProvideClassInfo2Vtbl *lpvtblIProvideClassInfo2; > + const IProvideMultipleClassInfoVtbl *lpvtblIProvideMultipleClassInfo; IProvideClassInfo and IProvideClassInfo2 are base classes of IProvideMultipleClassInfo, so you don't need 3 different vtbls. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: Add AllUsersPfogile env variable to each process during init.
by Alexandre Julliard 30 Apr '07

30 Apr '07

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > Native initializes this variable somewhere during the log-on. And since > Wine doesn't really have such a thing, it's more logical to do it during > the process initialization. The only side affect is that if registry values > change, new process will get new value. If it's set during logon on Windows, it's very unlikely that an app would depend on modifying this, so you could set it in the registry once and for all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dbghelp: Directly use Heap functions.
by Eric Pouech 30 Apr '07

30 Apr '07

Markus Amsler a écrit : > This reduces WoW debug symbol load time from about 100s to 18! this also removes two key design features: - memory is free:d (as Dimitry already pointed out) - a memory pool is associated to every module, so that all allocations for a specific module are free:d when the module is unloaded A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

AW: wine killing X?
by Roland Kaeser 30 Apr '07

30 Apr '07

Hello I saw the same problem starting SimCity 4 and Railroad Tycoon on Nvidia drivers and 0.9.36. But only sometimes. Roland ----- Ursprüngliche Mail ---- Von: Juan Lang <juan_lang(a)yahoo.com> An: wine-devel(a)winehq.org Gesendet: Freitag, den 27. April 2007, 21:58:37 Uhr Betreff: wine killing X? I just upgraded to the latest wine version and tried wineprefixcreate (no .wine directory), and it kills X. Nvidia drivers 1.0.9755. Anyone else see this? --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com __________________________________ Yahoo! Clever - Der einfachste Weg, Fragen zu stellen und Wissenswertes mit Anderen zu teilen. www.yahoo.de/clever

1 0

Compiling quartzdrv
by Jaka Jančar 29 Apr '07

29 Apr '07

Hi, I'm trying to compile quartzdrv, just to check it out and test it a bit. I have tried following the instructions at: http://wiki.winehq.org/MacOSX/QuartzDriver There's a bit of ambiguity at the next line: $ cp -r ~/drivers/dlls/quartzdrv ~/wine/dlls/winequartz.drv I assume this was written before any quartzdrv stuff was added to Wine, and I have to replace the winequartz.drv with quartzdrv from darwine, and not just put it within it (winequartz.drv/quartzdrv/), right? Also, the patch doesn't apply OK, but looking at the contents of the files, I'm not sure it's needed anymore. When doing "make depend" I get this error: ../../tools/makedep -C. -S../.. -T../.. bitblt.c bitmap.c brush.c clipping.c dce.c desktop.c dib.c dib_convert.c dib_dst_swap.c dib_src_swap.c displays.c event.c font.c graphics.c init.c keyboard.c mouse.c palette.c pen.c quartzdrv_coregraphics.c quartzdrv_main.c settings.c text.c window.c winpos.c gdi.h: No such file or directory gdi.h was first included from font.c:24 make[2]: *** [depend] Error 1 make[1]: *** [winequartz.drv/__depend__] Error 2 make: *** [dlls/__depend__] Error 2 I'd very much appreciate it if anyone who knows how to do this right updated the wiki, or helped me out a bit, so I can update it. Also, can anyone explain what the fake Menu and Info.plist files are for? -- Jaka Jančar http://jaka.kubje.org/

3 3

quicken 2007 ungodly slow
by Dan Kegel 29 Apr '07

29 Apr '07

I can run quicken 2007 (after a fresh wget kegel.com/wine/winetricks sh winetricks fakeie6 vcrun2005 and telling winecfg not to let the window manager manage windows), but GUI updates are incredibly slow (as in, twenty seconds to draw the main screen). oprofile shows profiles like samples % image name app name symbol name 367948 60.6432 no-vmlinux no-vmlinux (no symbols) 57404 9.4610 libc-2.5.so libc-2.5.so (no symbols) 21210 3.4957 ntdll.dll.so ntdll.dll.so wine_nt_to_unix_file_name 14774 2.4350 libwine.so.1.0 libwine.so.1.0 wine_utf8_mbstowcs 11751 1.9367 ntdll.dll.so ntdll.dll.so hash_short_file_name 10359 1.7073 ntdll.dll.so ntdll.dll.so RtlUpcaseUnicodeString 10203 1.6816 libwine.so.1.0 libwine.so.1.0 wine_utf8_wcstombs 7259 1.1964 ntdll.dll.so ntdll.dll.so RtlIsNameLegalDOS8Dot3 6746 1.1118 ntdll.dll.so ntdll.dll.so get_full_path_helper so perhaps it's going crazy on file i/o. I haven't really looked into this yet. (I confess I was hoping to see gdiplus as the smoking gun, but it never got above about a percent.) - Dan p.s. I don't have kernel symbols because I haven't figured out how to find vmlinux on ubuntu yet, nor does ubuntu make it easy to compile one. (vmlinuz won't do, nor do I know how to uncompress it.)

4 5

Mandriva rpms
by marco 29 Apr '07

29 Apr '07

Ivan Leo Puoti has not much time lately to make the rpms for mandriva. So I volunteered to make them. So I made a rpm from the latest rpm. How do I get this rpm on the winehq download server ? Kind regards, Marco Meijer

2 3

Bug 7682: NtQueryDirectoryFile fails when querying certain symbolic links
by Vitaliy Margolen 29 Apr '07

29 Apr '07

Cudos to Lei and everyone else who found the real problem. It appears that Wine's implementation of the NtQueryDirectoryFile and all other functions that ending up calling it have a major problem. They will fail if called on symlinks into directories outside $WINEPREFIX which contain $WINEPREFIX itself (aka loop scenarios). Ex: c:\windows\profiles\vitaliy\Desktop -> $HOME/Desktop - works c:\windows\profiles\vitaliy\My Documents -> $HOME - does not The reason of this is clear - we have to stop any "loops" that are not common on windows (but possible with reparse points). There are lots of "smart" programs that will scan all of available drives and of course they will lock up in the never ending cycle if loops are allowed. However, as I recall this configuration was a result of the long discussion about desktop integration. And use of symlinks was the best solution. It appears it is not a solution. Quite an opposite - it just plain doesn't work. So should we go back to the drawing board and and rethink our approach to the desktop integration? Also what can we do, if user configures such a loops him/her self? Vitaliy Margolen

2 1

Yet more broken Ubuntu packages
by Vitaliy Margolen 29 Apr '07

29 Apr '07

I'm getting reports that even wine-0.9.36 packages still compiled without xrandr support. Can we get that fixed ASAP? Thanks. Vitaliy

2 1

Closing bugs in bugzilla
by Vitaliy Margolen 29 Apr '07

29 Apr '07

Can anyone explain why do we need to change severity when closing bugs? This makes severity totally useless. We might as well reset all severity to normal and remove it from the bugzilla. > tony.lambregts at gmail.com changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Severity|major |normal > Status|RESOLVED |CLOSED

4 4

Re: msi: Add full JScript/VBScript support. [11/11,try8]
by Detlef Riekenberg 29 Apr '07

29 Apr '07

On Fr, 2007-04-27 at 15:46 -0500, Misha Koshelev wrote: > --- a/dlls/msi/Makefile.in > +++ b/dlls/msi/Makefile.in > @@ -38,6 +38,7 @@ C_SRCS = \ > record.c \ > registry.c \ > regsvr.c \ > + script.c \ The File is not in the Patch -- By by ... Detlef

2 1

Re: msi: Add base class for OLE automation objects. [2/11,try8]
by James Hawkins 29 Apr '07

29 Apr '07

On 4/27/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > Implements basic OLE automation class (i.e., Dispatch plus) > functionality that is then used for all separate class implementations. > > Changelog: > > * msi: Add base class for OLE automation objects. > +/* FIXME: I don't know how big this should be */ +#define MAX_MSI_STRING 1000 msi strings don't have size a limit. -- James Hawkins

2 1

re: Wine killing X
by Dan Kegel 28 Apr '07

28 Apr '07

Chris wrote: > I get this fairly regularly. After a few runs of any Wine program, the > next time I try and run something it will crash X. I had a spate of that over the last month or two. I think I tracked it down to known X driver problems. Upgrading from Dapper to Feisty may have helped. Juan, what distribution, version, and graphics card are you using? If you're using Ubuntu, and aren't on Feisty yet, try updating. I'm using X.org driver atimisc, on an ancient ATI Rage Pro. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

msvcp60 and bug 7679
by Tom Spear 28 Apr '07

28 Apr '07

http://bugs.winehq.org/show_bug.cgi?id=7679 - IMVU 3D Avatar Chat client crashes Just curious, since we don't have a builtin msvcp60.dll and I seriously doubt that we will implement it any time soon (if ever), should we try to support native, like we do with mfc, or would this bug be a wontfix? If we should try to at least get native working, I would like to _try_ to at least figure out what is wrong that causes the app to crash in msvcp60.dll and could use some pointers if someone doesn't mind. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

6 10

SambaXP 2007 Report, Day 3
by Kai Blin 28 Apr '07

28 Apr '07

Hi folks, sorry for the lag in sending in the report for day three of the SambaXP conference, I've been busy traveling back and catching up with things at home. The last day of SambaXP was split into two tracks again, one being "case study and vendor report", the other a developer track. I spent most of my time in the developer track, but you might want to check out http://www.sambaxp.org/ in a week or two to see the slides (and listen to the oggs) of some of the case study talks. A notable talk in the morning was Stefan Metzmacher's talk on active directory replication. Most of the audience seemed to miss the significance of the talk, but personally I think this is one of the important milestones in Samba's history. It's much easier now to move from a Windows PDC to a Samba PDC, as Samba can just grab the active directory via the normal replication routines. Later that day Lars Müller from the Samba team was talking about uniform Samba binaries as a way to get feedback about fixed bugs without the user having to know about compiling the sources. That might be an interesting idea to keep an eye on, Wine might want something similar once we go 1.0, and I figure that Samba will have something like that set up in 6-18 months. The most interesting talk on Wednesday was given by Julien Kerihuel from OpenChange. The OpenChange people are building an open source replacement for Exchange. In order to properly support this, they are working on decoding the MAPI protocl, and they also provide a libmapi library for client applications. As a proof of concept, they have an evolution plugin that'll allow evolution to talk to exchange using MAPI. The talk had a couple of demonstrations of the functionality that were greeted with applause from the audience. While OpenChange still has a bumpy road ahead, I'm pretty sure they will manage. OpenChange is the Samba of groupware, definetely a project to watch. The most exiting talk of the day, at least in my personal biased opinion, was in the case study track. But my perspective on that might be a little off, as that was the talk I was giving. I think it was recieved well by the audience. It probably won't be too interesting for you folks as you already know what Wine is all about. ;) The last talk I attended on that day was given by David Holder, who works for Erion, a company that does IPv6 consulting. He had analyzed the Samba source code to check how much work it would be to make Samba IPv6-ready. cifs and Samba4 are almost there, Samba3 needs some work. This is mostly due to the fact that NBT doesn't do IPv6 by design and some of the Samba3 code still is coupled to this. This is the last installment of this year's SambaXP report. More about Samba from a Wine perspective will certainly follow. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Problems with Ubuntu packages
by Mirek 27 Apr '07

27 Apr '07

Hi, I am using Ubuntu FF, and I have some fullsreen issues. In Ubuntu universe is wine 0.9.33 compiled with xrandr support, but on winehq site is repository with wine 0.9.35 compiled without xrandr support. Can someone fix this? I have several fullscreen issues with packages from winehq, but not with original packages from Ubuntu. Mirek Slugen

3 3

Re: [programs/regedit] Fix command line processing for /? patch
by Alexandre Julliard 27 Apr '07

27 Apr '07

"Tom Spear" <speeddymon(a)gmail.com> writes: > --- programs/regedit/regedit.c.old 2007-04-25 11:53:24.000000000 -0500 > +++ programs/regedit/regedit.c 2007-04-25 11:57:30.000000000 -0500 > @@ -104,13 +104,10 @@ > case 'E': > action = ACTION_EXPORT; > break; > - case '?': > + default: > fprintf(stderr,usage); > exit(0); > break; > - default: > - error_unknown_switch(chu, s); > - break; You don't want to do that, even if you print usage, an invalid switch needs to cause an error. -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: [Bug 6788] midi sysex buffer errors
by Christian Costa 27 Apr '07

27 Apr '07

Micha's patch has been applied. Just use version 0.9.36 or latest GIT. To enable midi debug channel just type : WINEDEBUG=+midi wine ... instead of wine ... Bye, Christian Jos Plompen a écrit : > Where can I find that patch? How do I apply it? > And how exactly can I enable midi debug channel? > thnx, > gosh > > On 4/24/07, *Wine Bugs* < wine-bugs(a)winehq.org > <mailto:wine-bugs@winehq.org>> wrote: > > http://bugs.winehq.org/show_bug.cgi?id=6788 > > > > > > ------- Additional Comments From titan.costa(a)wanadoo.fr > <mailto:titan.costa@wanadoo.fr> 2007-24-04 16:18 ------- > Could you enable midi debug channel with "WINEDEBUG=+midi wine > ..." after > applying Micha's patch. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are a voter for the bug, or are watching someone who is. > > > > > -- > MSN: jos.plompen(a)gmail.com <mailto:jos.plompen@gmail.com> > Skype: jos.plompen > ------------------------------------------------------------------------ > > >

1 0

Advertize software emulated Direct3D features?
by Stefan Dösinger 27 Apr '07

27 Apr '07

I am working on vertex blending support for WineD3D. First I implemented it using GL_ARB_vertex_blend in hardware, an extension that is unfortunately only supported by ati cards, and not nvidia. So I took Frank Richter's started software emulation for vertex blending, with that it works everywhere. The question is wether we should report support for this feature in our d3d caps. Because it is software emulated it forces wined3d into the drawStridedSlow path which is, well, slow. Enabling this may cause a game to choose this slower render path over something else, like vertex shaders. On the other hand it can get applications run that wouldn't work without this feature. For vertex blending it doesn't matter much. Its hardly used, and all games using it provide a vertex shader path too and prefer it(exception are the dx sdk demos). The other alternative the apps have is to either disable the feature entirely, thus have lower graphics quality, or calculate it themselves, which won't be slower than wined3d doing it. So I think we should advertize vertex blending, but the general question remains. What do you think? PS: Ideally we'd have a vertex pipeline replacement in form of a vertex shader, but that wouldn't invalidate the point of this since not all cards support vertex shaders. (And I personally dislike the idea of a pipeline replacement for this reason).

2 3

[Fwd: [Desktop_architects] DTL: Making Sound Just Work]
by Jeremy White 27 Apr '07

27 Apr '07

I am relaying a request from the DTL work group on sound. This is a great opportunity for us to let them know what we need from Linux sound. I encourage anyone involved in sound issues to get involved. Cheers, Jeremy

1 0

Re: Linuxtag 2007 in Berlin
by Stefan Munz 27 Apr '07

27 Apr '07

Hi Michael, thanks, this saves me some work :-) Will you be at linuxtag? cu, Stefan Am Donnerstag, 26. April 2007 21:27 schrieb Michael Jung: > Hi Stefan, > > On Wed, Apr 25, 2007 at 05:44:57PM +0200, Stefan Munz wrote: > > And maybe if anyone has a draft for Wine-posters, this would help too. > > I've attached the Inkscape file of the poster we've used at last year's > LinuxTag. > > Bye, -- Dipl.-Inform. Stefan Munz. . . . . . . . . . stefan.munz(a)itomig.de ITOMIG GbR . . . . . . . . . . . . . . . . . www.itomig.de Sand 14 . . . . . . . . . . . . . . . . . . mobil: +49 178 729 72 72 D-72076 Tübingen . . . . . . . . . . . . . .

1 0

review: add Video Memory text input to winecfg Graphics/Direct3D tab
by Vit Hrachovy 27 Apr '07

27 Apr '07

Hi, the attached patch adds new textbox input 'Video Memory size' for Graphics/Direct3D tab of winecfg. Updated every live locale resource to include this. Adding this option was discussed on thread 'More Direct3D settings in winecfg (was: Enabling GLSL in winecfg)' at wine-devel. changelog entry: Add Video Memory textbox to Graphics/direct3D part of winecfg May I kindly ask someone for the patch review? Regards Vit Hrachovy

3 3

Wiki down
by Alexander Nicolaysen Sørnes 27 Apr '07

27 Apr '07

Does anyone know when the wiki will be up again? Currently it alternates between displaying a 500 internal server error and a python exception + traceback. Regards, Alexander N. Sørnes

1 0

Re: [PATCH] CMD.exe: Remove code duplication for _splitpath
by Alexandre Julliard 27 Apr '07

27 Apr '07

Jason Edmeades <us(a)edmeades.me.uk> writes: > Note: This makes cmd.exe pull in msvcrt, but so does native Native doesn't have a choice, but we do. Unless there are good reasons to import msvcrt it's better to stick to standard libc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Enforcing charset/codepage (was: Commit 37591409b28c2000e70bd0d3c654a3a7559a4a26 breaks accentuation)
by Pedro Araujo Chaves Jr. 27 Apr '07

27 Apr '07

Follow-up... I recall that forcing the charset to be ANSI_CHARSET instead of DEFAULT_CHARSET [1] "fixed" bug 7571 [2] here, and from that rose an idea: would it be possible to add an option to winecfg to enforce a particular charset/codepage, much like it is already done in web browsers? That way, we here wouldn't have to face 7571 while the fix isn't ready. Is such a thing acceptable? TIA, - Pedro. [1] http://www.winehq.org/pipermail/wine-patches/2007-March/036538.html [2] http://bugs.winehq.org/show_bug.cgi?id=7571 P.S.: TMTC, I'm still working on 7571; 7703's been taking a lot of my time...

2 1

Suse wine and wind/u issues
by Vijay Kiran Kamuju 27 Apr '07

27 Apr '07

Hi, We are trying to port a windows app to linux. Previous we are using Wind/U. Now we want to test the feasibilty of wine, instead of Wind/U. We have installed Wind/U and Wine on the SLES 9 machine. We have installed the rpm. When we are configuring the wine, using winecfg/wineprefixcreate, its hanging. Its unable to create the fake dlls. Can you please help us. Is this problem occuring due to Wind/U? Thanks, VJ

3 5

re: Trace fix
by Dan Kegel 26 Apr '07

26 Apr '07

Alexandre wrote: >No, resend just one, making absolutely sure that you got everything >right, and wait for it to be committed before sending the next >one. You have to make sure you can walk before you try to run. I would also suggest finding somebody to pre-review your patch before you send it to the list. - Dan

1 0

Trace fix
by Tom Spear 26 Apr '07

26 Apr '07

Just curious if Alexandre missed my patches for regedit and my trace fix for uninstaller, or if there is a backlog of commits to be done, or if he even plans to commit them, and if not, why.. http://www.winehq.org/pipermail/wine-patches/2007-April/038566.html - Spelling fixes for regedit http://www.winehq.org/pipermail/wine-patches/2007-April/038568.html - Correct parsing of /? and unknown parameters on command line for regedit http://www.winehq.org/pipermail/wine-patches/2007-April/038569.html - Fix for a trace in uninstaller (Make sure it shows the current selection, not the old one) I am aware that my attempt 6 to scan hkcu was not attached to the original email for it, so I resent that, but expect a day or 2 delay for it to be committed, but the others, I figured would have been by now. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 4

Patch: please review fixes to wineshelllink
by sol11x86＠comcast.net 26 Apr '07

26 Apr '07

wineshelllink uses a bash/ksh construct like "$(get_menu_entries)", but since Solaris' /bin/sh is truly /bin/sh and not bash/ksh, it fails on this call. I have modified it to use a more "compatible" method suggested by Dan Kegel. In addition, the awk command uses the "match" function, but again this is native to gawk and nawk, and this fails with Solaris' native awk command. I have tested this in Solaris with this code, and the original wineshelllink with a "#!/bin/bash" and replacing awk with gawk, and I got menu items on my desktop. Could a few folks sanity check this on a linux system to make sure it's kosher. I'm still fighting getting wine compiled in my ubuntu system. Thanks, Ben

1 0

Re: shell failure on tools/wineinstall
by sol11x86＠comcast.net 26 Apr '07

26 Apr '07

-------------- Original message ---------------------- From: Alexandre Julliard <julliard(a)winehq.org> > Detlef Riekenberg <wine.dev(a)web.de> writes: > > > On Do, 2007-04-26 at 13:42 +0000, Ben Taylor wrote: > > > > > >> if [ ! `which wine` ] > >> > > > > data=`which wine` > > if [ -n "$data" -a -x "$data" ] > > then > > # found wine > > WINEINSTALLED=yes > > else > > echo "Could not find wine on your system. Run wineinstall as root to > > install wine" > > echo "before re-running wineinstall as a user." > > echo > > echo "Exiting wineinstall" > > exit 1; > > fi > > Trying to run 'wine --version' would probably be a better installation > check. I found two places where "which wine" was used in wineinstall and replaced them using a construct using "wine --verstion" Please review and see if the patch makes sense. It's defintely working better now. Ben

1 0

re: removing bash/gawk'isms from wineshelllink
by Dan Kegel 26 Apr '07

26 Apr '07

Ben Taylor wrote: > I'm still working on the script to make it more "sh" compatible, > but I think I have a potential fix for the line that reads: > > for i in $(get_menu_entries "$1"); do > > and replace it with > > for i in `get_menu_entries "$1"`; do If you want to be really portable to Solaris, don't put the ; do on the same line: the extra-portable syntax is for i in `get_menu_entries "$1"` do You're facing an uphill battle, though, if you really want to support classic sh. Not many people understand or care. You'll probably need to set up a nightly build-and-test on Solaris to keep the code from rotting. BTW, here's a great book about classic sh programming: "Portable Shell Programming" by Bruce Blinn It's like the "K&R" of shell programming. - Dan

1 0

Re: mshtml: fix crash when opening help (bug 8077)
by Jacek Caban 26 Apr '07

26 Apr '07

Hi Clinton, This patch is wrong, I've added a comment to bug. Thanks, Jacek

2 1

{Resend} [programs/uninstaller (Try 6)] Scan HKCU
by Tom Spear 26 Apr '07

26 Apr '07

Scan HKCU for uninstall entries. Separated out the trace fix, moved the HeapAlloc for entries outside the for loop, realigned the 2nd line of code for a trace. This patch obsoletes all previous ones. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

re: winetricks: Add Package "gecko"
by Dan Kegel 26 Apr '07

26 Apr '07

Detlef wrote: > gecko is required before we can add the flashplayer I'm a bit confused. Wine will load gecko itself on demand, why do you need it in winetricks? Presumably to get rid of the mouse click required when Wine autodownloads gecko? Your patch seems ok but I wonder if exposing details about how gecko is installed is a good idea. It'd be nice for wine to offer a quiet mode for gecko installation itself. Winetricks really is for third party stuff wine doesn't have control over. Also, are you planning to also add the flashplayer to winetricks? I didn't quite understand your comment. Finally, James is right, winetricks patches may as well go straight to me... - Dan

2 3

DirectX under Wine
by Robert Fairlie 26 Apr '07

26 Apr '07

Hello, I am a contractor for a company in the UK. I have developed a 3D module for an oil reservoir visualisation program on Windows that is now required to run on Linux. The Wine port has been very successful (it started a month or so ago), but I'm having a couple of DirectX-related problems. We're using DirectX 9, the LinuxOS is Fedora Core 6, the Wine version is 0.9.32, and we're only using the binary loader, i.e. we're simply running our Windows executable under Wine. The problems I'm having relate to calling IDirect3DSurface9::GetDC() on an offscreen surface, which doesn't appear to work, and to calling IDirect3DDevice9::CreateStateBlock() with D3DSBBT_ALL, which appears to hang the program. I've had a look in the bug lists, but I didn't see anything relating to these issues. I'd greatly appreciate any information anyone has on these two issues. I'd also appreciate any information on how the DirectX to OpenGL translation is implemented. For example, does Wine use hardware-accelerated OpenGL? Our program was initially affected by Wine bug 2398, i.e. the bug that causes the OpenGL window to occupy the whole application window. We got round this by first rendering to an offscreen surface, copying the offscreen surface to a bitmap, and then blitting the bitmap to the window. It is of course slower but its acceptable for us and gives us nice MDI behaviour under Wine. However, since we mix DirectX and GDI, we would like to use GetDC() on the offscreen surface. This isn't crucial, but among other things it would allow us to blit the offscreen surface into the bitmap, rather than using IDirect3DSurface9::LockRect() and copying it pixel by pixel as we're doing at the moment. Thanks, Robert Fairlie

2 2

shell failure on tools/wineinstall
by sol11x86＠comcast.net 26 Apr '07

26 Apr '07

Ran into this error after building wine again. Not sure why I haven't seen this before, but: tools/wineinstall: line 272: [: too many arguments which translates to this line: if [ ! `which wine` ] On Solaris, if I do "which wine", I get a no wine in (long list of path entries)., so I assume another version of "which" returns a blank string if wine doesn't exist? Thoughts? Ben

3 2

Re: removing bash/gawk'isms from wineshelllink
by Vitaliy Margolen 26 Apr '07

26 Apr '07

Ben Taylor wrote: > I'm still working on the script to make it more "sh" compatible, > but I think I have a potential fix for the line that reads: > > for i in $(get_menu_entries "$1"); do > > and replace it with > > for i in `get_menu_entries "$1"`; do What is the problem with this particular part? What shell are you using that doesn't understand $() command expansion? Even the basic BSD "sh" does support this. However this doesn't really affect anything, and should work in all shells too. > The problem with the get_menu_entries function is that the awk > uses the match function, which is only available in gawk and nawk, > and julliard didn't like my idea of making the script just use gawk or > nawk, so I have to rewrite the function to look like this: > > get_menu_entries() > { > tmp="$xdg_config_dir/$1.menu" > > if [ -r "$tmp" ] ; then > awk ' > BEGIN { RS="<" } > /^Filename/ { > RSTART=index($0,">"); > if (RSTART > 0) { > print substr($0,RSTART+1) > } > }' $tmp > This looks reasonable to me. Wine uses match() to find a matching ">" so index() would do just fine. Vitaliy.

1 0

non-profit question
by Wright, Ann 26 Apr '07

26 Apr '07

Hi, In looking at your site and having the ability for people to donate to your organization I was wondering whether or not you are a non-profit or a not-for profit organization? (501 ( c ) 3 or 501 ( c ) 4) Thanks for your time and attention to my question. Ann Wright

3 3

Regression in AccessCheck?
by Dan Kegel 26 Apr '07

26 Apr '07

http://bugs.winehq.org/show_bug.cgi?id=6845 describes two apps whose installs fail because of what looks like a problem in AccessCheck. I attached my attempt at a fix, and it does get those two apps to install, but the advapi security conformance tests fail after applying it. Can someone familiar with AccessCheck / NtAccessCheck have a look? Thanks!

1 0

Re: winetricks: Add Package "gecko"
by James Hawkins 25 Apr '07

25 Apr '07

On 4/25/07, Detlef Riekenberg <wine.dev(a)web.de> wrote: > > gecko is required before we can add the flashplayer > winetricks is not a part of the wine tree, so patches like this need to be sent to wine-devel or to Dan Kegel. -- James Hawkins

1 0

Re: RegDeleteTree [3rd]
by Robert Shearman 25 Apr '07

25 Apr '07

Stefan Leichter wrote: > Am Thursday 19 April 2007 12:14 schrieb Alexandre Julliard: > >> Stefan Leichter <Stefan.Leichter(a)camline.com> writes: >> >> >>> + } else { >>> + if (!ret) >>> + ret = RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0); >>> >> The function is supposed to delete the key values, that's not what >> this does. >> >> You probably need to write some test cases... >> > Hello Alexandre, > > i 'm not sure what you mean with this point. I have now added a loop to delete > all value/data pairs, but this loop is only executed for the default entry > (value NULL). > > If the implementation is not fine for you, can you please suggest detailed > test cases to be proved. > Perhaps: s/RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0)/RegDeleteValueW(hSubKey, NULL)/ -- Rob Shearman

2 1

Uninstaller: 2 questions
by Tom Spear 25 Apr '07

25 Apr '07

Why do we show a dialog if there are no uninstall entries found in the registry? Windows does not do that, and I think we shouldn't either. However, on that same note, I think we should, since this uninstaller is not designed to mimic Windows' Add/Remove Programs, catch when a program's uninstaller does not remove it's uninstall entry from the registry, after the process exits, and go ahead and remove the entry. I already have a patch for the 2nd question ready to be committed once my patch to check HKCU is committed, however I am waiting for comment before I actually send it. The first question I will wait to write a patch for, however it is only like a 4 line patch.. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

4 7

Re: [Generic] Add --disable-tests
by Saulius Krasuckas 25 Apr '07

25 Apr '07

* On Tue, 9 Jan 2007, Maarten Lankhorst wrote: > > This patch adds --disable-tests, but keeps --enable-tests by default, > this is very useful for regression testing with a specific app because > it saves a lot of building time. Can this patch go into the GIT, any objections?

1 1

Winscard support (for smart cards)
by mounir.idrassi＠idrix.Fr 25 Apr '07

25 Apr '07

Hi, We have noticed that wine doesn't have the winscard dll responsible for the support of smart cards under windows. For the need of one of our projects, we are currently developing this dll for wine under Linux based on the pcsc-lite library. Once done, we'll share it with the community. However, we would like to known the reason behind the lack of winscard support. Is it simply because no one needed it before or maybe there is an issue with the pcsc-lite license? Thanks in advance for your information. Cheers, Mounir IDRASSI IDRIX http://www.idrix.fr

4 4

re: Winscard support (for smart cards)
by Dan Kegel 25 Apr '07

25 Apr '07

I'm thrilled you're working on this! I must urge you to submit code early and often to Wine. The first patch you should send should just implement a stub dll. We can help you with that if you need it. Here's a good example of a new stuff DLL: http://winehq.org/pipermail/wine-patches/2007-April/038141.html By submitting a patch like this, you will pave the way for later submission of more code. - Dan

1 0

[programs/uninstaller (Try 6)] Scan HKCU
by Tom Spear 25 Apr '07

25 Apr '07

Scan HKCU for uninstall entries. Separated out the trace fix, moved the HeapAlloc for entries outside the for loop, realigned the 2nd line of code for a trace. This patch obsoletes all previous ones. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

[Try 5] Check HKCU for uninstall entries
by Tom Spear 25 Apr '07

25 Apr '07

Hopefully this will be the last try. Instead of just checking HKLM for uninstall entries, check HKCU as well. Converted all instances of entries[numentries-1].xxx to entry->xxx Fixed a bug with a trace. Ran the file thru kwrite to make SURE there are NO tabs! Double checked the diff to make sure no whitespaces were removed by adding new lines. Any comments? This is sent to wine-patches, so if there are no problems with this patch, it is ready for commit. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 1

Server Failure
by Robert Lunnon 25 Apr '07

25 Apr '07

I'm having the wineserver sparodically return a failure STATUS_NO_SUCH_FILE I think this is possibly because wineserver didn't get compiled with a threadsafe errno but I'd welcome other ideas Heres the context (WINEDEBUG=+server) 0014: new_thread() = 0 { tid=003a, handle=12c } 003b: terminate_thread( handle=fffffffe, exit_code=207 ) 003b: terminate_thread() = 0 { self=1, last=0 } 003b: get_window_children( parent=0, atom=0000, tid=0000 ) 003b: get_window_children() = ERROR_INVALID_WINDOW_HANDLE { count=0, children={} } 003b: close_handle( handle=0 ) 003b: close_handle() = INVALID_HANDLE 003b: *killed* exit_code=207 003a: *fd* 53 <- 66 003a: *fd* 55 <- 67 003a: init_thread( unix_pid=21133, unix_tid=-1, debug_level=1, teb=7e090000, peb=7ffd0000, entry=40edf7, ldt_copy=d1f90cc0, reply_fd=53, wait_fd=55 ) 003a: init_thread() = NO_SUCH_FILE { pid=0008, tid=003a, info_size=0, server_start=1c786d460b0ba38 (-11.5351480), version=298 } wine client error:3a: init_thread failed with status c000000f

2 1

Re: [Try 3] [programs/uninstaller] Check HKCU for uninstall entries
by James Hawkins 25 Apr '07

25 Apr '07

On 4/24/07, Tom Spear <speeddymon(a)gmail.com> wrote: > This patch makes the wine uninstaller check HKCU for uninstall entries > in addition to HKLM. > +const int numrootkeys = 2; +static const DWORD maxSubkeyNameLen = 255; const variables should be all uppercase to differentiate them from non-const variables. One of the const variables is static and the other not, what gives? @@ -148,7 +149,6 @@ WINE_ERR( "The remove option requires a parameter.\n"); return 1; } - RemoveSpecificProgram( argv[i++] ); Don't make random whitespace changes. + for (x=0; x<sizeof(hkeyroot[0]); ++x) + { sizeof(hkeyroot[0]) = 4, which means you're going to index hkeyroot two indexes out of bounds. I think you're looking for sizeof(hkeyroot) / sizeof(hkeyroot[0]). + WINE_TRACE("allocated entry #%d: %s (%s), %s\n", + numentries, wine_dbgstr_w(entries[numentries-1].key), wine_dbgstr_w(entries[numentries-1].descr), wine_dbgstr_w(entries[numentries-1].command)); You mixed tabs and spaces, and that line is too long. -- James Hawkins

3 3

Re: [4/20] DDraw: Get rid of FVFs
by H. Verbeet 25 Apr '07

25 Apr '07

On 24/04/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + hr = IWineD3DDevice_CreateVertexDeclarationFromFVF(This->wineD3DDevice, > + &pDecl, > + (IUnknown *) ICOM_INTERFACE(This, IDirectDraw7), > + fvf); Is this right? Passing the IDirectDrawImpl as parent looks a bit questionable.

2 3

Re: [3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF
by H. Verbeet 25 Apr '07

25 Apr '07

On 24/04/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > How do you intend for this to be used? In particular, how should this work with eg. IDirect3DVertexDeclaration9::GetDeclaration or IDirect3DDevice8::GetVertexShaderDeclaration?

2 3

Using A- instead of W-calls in tests
by Paul Vriens 25 Apr '07

25 Apr '07

Hi, There are several tests where we use W-calls where we could use A-calls to accomplish the same test goal. Most of the time this means some of these will fail on Win9x or WinME as they are not by default Unicode enabled. Do we need write our tests with A-calls ? For Wine this doesn't matter if we're forwarding the call to a W-call. I do think it could matter on Windows or does Windows also do the forwarding? As an example: there are several CryptAcquireContextW calls in the cert tests for crypt32. These fail with an ERROR_CALL_NOT_IMPLEMENTED on win98 and following tests that rely on the return valuse also fail. Should these tests be re-written to use CryptAcquireContextA or should we skip to avoid the hassle. I just want some opinions. I know Alexandre already mentioned not being to worried about failing win98 tests but I like to see an all green (with some blue borders) tests.winehq.org page :-). Cheers, Paul.

2 1

D3DRM: Thanks a lot, Wine people
by David.Adam＠math.cnrs.fr 25 Apr '07

25 Apr '07

Hello, my first "real" patches for wine were accepted. I would to thank all wine people for their kindness, and their help to make these patche accepted. Now I can play Motocross Madness 2 out the box :D :D :D Specially, I would like to thanks Vijay for his help to start the implementation, and Dmitry who gave a lot of advice without becoming nervous in view of my unabilty in wine. I thanks too Alexandre to accept these patch and modify them silently :) In the modifications, I saw that the defintion of vectors, quaternions... in d3drmdef.h was replaced by a call to d3dtypes.h In fact I copied the beginning of d3drmdef.f from the dsound.h file. Can we not modify this file too? David

2 1

Re: schannel: Implement SpLsaModeInitialize (update)
by Alexandre Julliard 25 Apr '07

25 Apr '07

Yuval Fledel <yuvalfl(a)gmail.com> writes: > +static const SECPKG_FUNCTION_TABLE secPkgFunctionTable[2] = > + { { > + .InitializePackage = NULL, > + .LsaLogonUser = NULL, > + .CallPackage = NULL, Please don't use C99 syntax, it won't work on older compilers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF
by Ivan Gyurdiev 25 Apr '07

25 Apr '07

> Stefan Dösinger wrote: You're returning a size_t here, which does not match the WINED3DERR_OUTOFVIDEOMEMORY returned on the HeapAlloc (granted, that's probably incorrect behavior by d3d9, but at least the return types should be consistent). Does that mean we'll be removing the other two versions of this code in existence (d3d9, and drawprim conv)? By the way, who wrote the very first version - I was looking through git history to figure out the proper copyright attribution, and it predates the git tree. I guess we should update the copyright in d3d9/vertexdeclaration.c to list that person if it isn't done already. I was just curious... Ivan

2 1

SambaXP 2007 Report, Day 2
by Kai Blin 25 Apr '07

25 Apr '07

Hi folks, time for the second part of the SambaXP status report. On tuesday, I had the chance to talk to Sam Ranji from Microsoft at lunch. He is leading the open source compatibility lab at Microsoft, a lab running only open source software. He told us that he was at SambaXP to figure out how Microsoft could help the Samba community and Samba customers. The conversation was very polite, but not very much to a point. Sam seems to be pretty reasonable about talking to the open source community, but there is only so much he can do on the Microsoft side. Microsoft seems to acknowledge that there is need for a product like Samba out there and it looks like they have decided to play along. Sam mentioned that there were some bugs in Vista that severely hurt Samba interoperability and that Microsoft fixed them prior to the Vista release. Simo Sorce then pointed out some cases where Microsoft used to cooperate with Samba and now stopped talking. Dan Shearer told an amusing anecdote about one project manager at Microsoft who wanted to use ports > 1024 for privileged services, and how Tridge wrote a perl script exploiting this potential vulnerability, before it even existed. Sam seems to be really interested in cooperating with Samba in the area of bug reports, and see where the cooperation can go from there. While this doesn't mean much for Wine, it seems like Microsoft finally is accepting that they can't just will open source software away. We will see how this develops. ---- Centeris is producing Centeris Likewise, a product that supports managing Linux/Unix products using standard Windows administration tools. Centeris' Krishna Ganugapati had a fast-paced talk about Likewise and named a couple of requirements for porting their .NET/Mono based management applications to Linux. Among the things they need are a library similar to netapi32, a library doing DCE/RPC and remote named pipes. Now, if you remember part 1 of my report, remote named pipes is something I already got started on. Talking to Krishna after his talk, we both realized that cooperating in this area will give Centeris a way to port their product and Wine a way to just thunk to a native library instead of reinventing the wheel. Centeris is happy to fund development in that area and then release this under a free license. I will get into that some more after SoC. ---- Most conversations I had in the breaks and at the social event are not really interesting from a Wine point of view, but we will see how that develops after my talk this afternoon. Signing off to listen to another interesting talk, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 25 Apr '07

25 Apr '07

Now, I am writing tests for this. Windows crashes if I pass NULL pointer to these function. Crash can be easily avoided in wine. Should we crash too? And how the windows crash can be caught? Or just I should not write such test-case? Thanks, -- Kirill

2 1

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 25 Apr '07

25 Apr '07

> > > > For containing backshash. Yes, comment must be better. > > A comment that states you're looking for a backslash is superfluous; > the code makes that obvious. A better comment would be 'check for > filename only' or something along those lines. Maybe, 'MSDN claims that if filename contains backshash then return value is always TRUE'? > How do you know that's > what this function does if you haven't tested it? I've mentioned an MSDN article in the patch. There are some glimpses what this function does. Easy, isn't it? ;-) That MSDN article is rather strange: it claims, that filename is the name of executable file, but in wine traces of cmd.exe I can see '.' (dot) as an argument. -- Kirill

2 1

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 25 Apr '07

25 Apr '07

> On 4/24/07, Kirill K. Smirnov <lich(a)math.spbu.ru> wrote: > > Hi, > > I've sent the patch: > > http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html > > about a week ago and it has not been applied. Please, explain, what is > > wrong with it? > > You haven't sent in any tests for this function. Is there some app > that needs it? I've mentioned it in the first try: windows 2003 cmd.exe. > + static const WCHAR env_name[] = > {'N','o','D','e','f','a','u','l','t','C','u','r','r','e','n','t','D','i','r >','e','c','t','o','r','y','I','n','E','x','e','P','a','t','h',0}; > > That's a really long line. We try to keep the lines to a length of 80. Hm... I've improve it. > + /* Check name first */ > + if (strchrW(name, '\\')) > + return TRUE; > > You should probably check name for NULL, but you'll have to test how > Windows handles this. That's a pretty bad comment too; check name for > what? For containing backshash. Yes, comment must be better. Thanks, -- Kirill

2 1

FillGLCaps foreign context question
by Jesse Allen 25 Apr '07

25 Apr '07

Jan, In a patch from Nov 23, you changed FillGLCaps to return false when we get a foreign context. This causes SW Battlefront to crash while loading sometime after calling IWineD3DImpl_GetAdapterIdentifier, at least on my system. IWineD3DImpl_GetAdapterIdentifier calls FillGLCaps, and when it gets the false, it uses dummy values. Why can't we use the caps from a foreign context? Attached patch fixes loading the game. See http://source.winehq.org/git/wine.git/?a=commit;h=ee44a19966fec922ab2273449… Any ideas on what might be the problem? Jesse

1 0

Re: [Try 4] Check HKCU for uninstall entries
by James Hawkins 25 Apr '07

25 Apr '07

On 4/24/07, Tom Spear <speeddymon(a)gmail.com> wrote: > All previous patches are obsoleted by this one. > > Instead of just checking HKLM for uninstall entries, check HKCU as well. > + if (!entries) + entries = HeapAlloc(GetProcessHeap(), 0, sizeof(uninst_entry)); You're still mixing tabs and spaces. -- James Hawkins

1 0

Re: schannel: Implement SpUserModeInitialize
by James Hawkins 24 Apr '07

24 Apr '07

On 4/24/07, Yuval Fledel <yuvalfl(a)gmail.com> wrote: > > + if (LsaVersion != 0x10000) What is 0x10000? If it's not defined in the SDK, then please use a #define to clarify what it means. -- James Hawkins

2 4

Re: winealsa: Improved handling of SysEx MIDI messages
by Christian Costa 24 Apr '07

24 Apr '07

Seems fine. Michał Wiernowolski a écrit : > This patch puts together pieces of SysEx messages until > End-of-Exclusive (F7) arrives or the buffer gets filled. > This improves current behavior (giving up on all multi-buffer sysex > msgs), fixing partially bug #6788. > > ------------------------------------------------------------------------ > > >From 0102a6ed573916067f0c2fd84b5218bd4200fede Mon Sep 17 00:00:00 2001 > From: =?ISO-8859-2?q?Micha=B3_Wiernowolski?= <mihalw(a)gmail.com> > Date: Tue, 24 Apr 2007 19:17:34 +0200 > Subject: [PATCH] winealsa: Improved handling of SysEx MIDI messages (Bug #6788) > > --- > dlls/winealsa.drv/midi.c | 20 +++++++++++--------- > 1 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c > index 09018aa..90d52e6 100644 > --- a/dlls/winealsa.drv/midi.c > +++ b/dlls/winealsa.drv/midi.c > @@ -351,17 +351,19 @@ static DWORD WINAPI midRecThread(LPVOID arg) > LPBYTE ptr = (BYTE*) ev->data.ext.ptr; > LPMIDIHDR lpMidiHdr; > > - /* FIXME: Should handle sysex greater that a single buffer */ > + /* FIXME: Should handle sysex greater than lpMidiHdr->dwBufferLength */ > EnterCriticalSection(&crit_sect); > if ((lpMidiHdr = MidiInDev[wDevID].lpQueueHdr) != NULL) { > - if (len <= lpMidiHdr->dwBufferLength) { > - lpMidiHdr->dwBytesRecorded = len; > - memcpy(lpMidiHdr->lpData, ptr, len); > - lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; > - lpMidiHdr->dwFlags |= MHDR_DONE; > - MidiInDev[wDevID].lpQueueHdr = (LPMIDIHDR)lpMidiHdr->lpNext; > - if (MIDI_NotifyClient(wDevID, MIM_LONGDATA, (DWORD)lpMidiHdr, dwTime) != MMSYSERR_NOERROR) > - WARN("Couldn't notify client\n"); > + if (lpMidiHdr->dwBytesRecorded + len <= lpMidiHdr->dwBufferLength) { > + memcpy(lpMidiHdr->lpData + lpMidiHdr->dwBytesRecorded, ptr, len); > + lpMidiHdr->dwBytesRecorded += len; > + if (*(ptr + (len-1)) == 0xF7) { > + lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; > + lpMidiHdr->dwFlags |= MHDR_DONE; > + MidiInDev[wDevID].lpQueueHdr = (LPMIDIHDR)lpMidiHdr->lpNext; > + if (MIDI_NotifyClient(wDevID, MIM_LONGDATA, (DWORD)lpMidiHdr, dwTime) != MMSYSERR_NOERROR) > + WARN("Couldn't notify client\n"); > + } > } else > FIXME("No enough space in the buffer to store sysex!\n"); > } else > > ------------------------------------------------------------------------ > > >

1 0

Disabled Wine PostScript Driver?
by Alisson Gomes 24 Apr '07

24 Apr '07

Hello, In first time, I like congratulations by great job, the wine. Fantastic. In second time, i have the problem with Wine. How do disable Wine PostScript Driver? Is possible? by configuration, by compilation, etc. ps: I send e-mail in many discursion list: WineConf, Wine Users and others, nobody positively answers. Thanks, Alisson Gomes

3 3

Re: schannel: Tests for Sp[Lsa,User]ModeInitialize and GetInfo
by James Hawkins 24 Apr '07

24 Apr '07

On 4/24/07, Yuval Fledel <yuvalfl(a)gmail.com> wrote: > > +#if 0 + /* NULL parameters: All 3 crash as of Windows XP */ + status = pSpLsaModeInitialize(0x10000, NULL, &pTables, &cTables); + status = pSpLsaModeInitialize(0x10000, &Version, NULL, &cTables); + status = pSpLsaModeInitialize(0x10000, &Version, &pTables, NULL); +#endif We try to avoid #if 0/#endif constructs. Just add a comment that states that the function crashes in XP if any of those three params are NULL. -- James Hawkins

2 1

NONE folder ???
by Tom Spear 24 Apr '07

24 Apr '07

While looking thru my ~/.wine/drive_c and my home directory today, I noticed that there is a folder called NONE that was created after I redid my wine install from the ground up last night. Looking thru it, there is a subfolder called var/cache/fontconfig and in that folder is a bunch of files that have filenames that look like md5 checksums with -x86.cache-2 at the end. The files are binary files, so I can't tell what they are used for, but since the name has fontconfig in them, I know they were created by fontforge. Question is, why does this folder and these files exist in my home directory, as well as every directory on my drive_c, and what are they for? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Should we handle this?
by Tom Spear 24 Apr '07

24 Apr '07

While testing my uninstaller patch, I ran into the issue that was a problem in Win95, where the uninstaller did not handle deletion of it's uninstall registry key. What I did was install a program that I new put it's registry key under HKLM. Then I copied that key to HKCU. Then I installed a program that I knew put its key under HKCU and copied that key to HKLM. Then I uninstalled each one with the copied key. The program's uninstaller removed the key that it was instructed to take out, but left the other one behind. My question is this. If an uninstaller (outside of my test environment) does not remove it's registry key before the process exits, should our uninstaller check for that after the process exits, and go ahead and remove the key, or should we make the user press the uninstall button again and ask them if they want to remove the key (like we already do, in the event they manually removed the program, by deleting the folder)? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 3

Re: ADVAPI32: Make service_start_process return the pid to the caller
by James Hawkins 24 Apr '07

24 Apr '07

On 4/24/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > Changelog > dlls/advapi32/service.c > - Make service_start_process return the pid to the caller > - /* FIXME: Put the pid into the service struct */ + if (ppid) *ppid = pi.dwProcessId; The fixme says to put the pid in the service struct, not return it in another parameter. -- James Hawkins

2 1

[try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 24 Apr '07

24 Apr '07

Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong with it? Thanks -- Kirill

2 1

Typo fix
by Tom Spear 24 Apr '07

24 Apr '07

Just curious. I sent a patch to wine-patches last week to fix a typo in a trace for regedit, but it was not committed. Should I go ahead and resend it? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 1

Re: patch for msi.dll (action.c and custom.c)
by James Hawkins 24 Apr '07

24 Apr '07

On 4/24/07, Ivan Sinitsin <ivan(a)etersoft.ru> wrote: > The patch fix the problem with wrong source path when you install *.msi (for > example FineReader 8.0). > > Changelog: > This patch fix problem with wrong source path. > This is wrong. Please read msdn about custom action type 17. The source dll for the custom action is the installed file, so file->TargetPath is right. -- James Hawkins

1 0

Fwd: Status of Wine in (K)Ubuntu
by Vijay Kiran Kamuju 24 Apr '07

24 Apr '07

Hi Jonathan Riddell has sent me a reply regarding the wine status in Ubuntu. I am also putting that message below. I have nominated Scott Ritchie as maintainer for wine in Ubuntu. I think we need to put up a proposal for wine for Ubuntu. Any Ideas, guys. Thanks, VJ ---------- Forwarded message ---------- From: Jonathan Riddell <jriddell(a)ubuntu.com> Date: Apr 23, 2007 8:49 AM Subject: Re: Status of Wine in (K)Ubuntu To: Vijay Kiran Kamuju <infyquest(a)gmail.com> On Sun, Apr 08, 2007 at 05:10:59PM -0400, Vijay Kiran Kamuju wrote: > What is the current release/packaing stratergy wrt Wine. > Is it possible toomchange the release/packaging statergy of Wine. > As the current release of wine is fortnightly and mostly its bug fix > release. > And the ubuntu universe version is not upto date with the current wine > release. > I would like to create a blueprint for wine like as > Till the release of 1.0 we will be releasing fortnightly updates in > sync with Wine releases. > After that we will give patches based on fixes given on main branch > like all other s/w till next version. > I think this is a good statergy. > And I t will be benificial to wine and ubuntu. > Can i make such a blue print and make it available for fiesty, please. > I dont mind if you do it. I don't know of anyone who actively works on wine in the Ubuntu archives. I'd recommend posting a proposal to ubuntu-motu for more regular updates. But updates must follow the ubuntu release schedule. https://lists.ubuntu.com/mailman/listinfo/ubuntu-motu Jonathan

1 0

Re: localui: add Polish translation
by Detlef Riekenberg 24 Apr '07

24 Apr '07

On Mo, 2007-04-23 at 19:55 +0200, Mikołaj Zalewski wrote: > (0009-localui-add-Polish-translation.txt) > From 4045f052bd5814a2dbf35527af4f6f7fee259c8e Mon Sep 17 00:00:00 2001 > +#include "ui_Pl.rc" You missed the translated File, but it would be nice, when you wait a week please: I have a Patch for AddPortUI, that add more strings and a Dialog and the Patchs grow whith more translations. Thanks -- By by ... Detlef

2 1

SambaXP 2007 Report, Day 1
by Kai Blin 24 Apr '07

24 Apr '07

Hi folks, this will be the first installment of my SambaXP 2007 report. SambaXP started on monday with a tutorial from Jerry Carter, which was interesting but not really related to Wine. However, in the evening I finally managed to grab hold of Steve French to talk about implementing a remote named pipes interface in cifs. This afternoon, the actual conference is about to start, featuring a couple of talks about winbind, cifs and couple of other things that might be interesting for Wine. For remote named pipes, Steve suggested to use mount to set up the pipes, switching from byte mode to message mode and back using chattr. I'll look into writing some example code for Steve to test and then we'll look into kicking that off. That's it for the monday writeup, I expect that today will give more intersting things to write about. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

RE: dinput: Constify some variables
by Vitaliy Margolen 24 Apr '07

24 Apr '07

Andrew Talbot wrote: > Changelog: > dinput: Constify some variables. > -static LONG map_axis(JoystickImpl * This, short val, short index) > +static LONG map_axis(const JoystickImpl *This, short val, short index) > { > double fval = val; > double fmin = This->props[index].lMin; > diff -urN a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c > --- a/dlls/dinput/joystick_linuxinput.c 2007-03-08 21:37:02.000000000 +0000 > +++ b/dlls/dinput/joystick_linuxinput.c 2007-04-23 20:28:26.000000000 +0100 > @@ -586,7 +586,7 @@ > * adapts values accordingly. > */ > static int > -map_axis(JoystickImpl* This, int axis, int val) { > +map_axis(const JoystickImpl *This, int axis, int val) { > int hmax = This->props[axis].havemax; > int hmin = This->props[axis].havemin; > int wmin = This->props[axis].wantmin; Please don't make a pointer to This a const. Same objections as with any COM object. Vitaliy.

1 0

Re: [UPDATE] [programs/uninstaller] Check HKCU for uninstall entries too
by James Hawkins 23 Apr '07

23 Apr '07

On 4/19/07, Tom Spear <speeddymon(a)gmail.com> wrote: > Apparently the last patch had multiple patches in the file because I > didnt delete it before creating the new one.. > > So here we go again. > > Check HKCU as well as HKLM for uninstall entries, using a for loop > @@ -69,7 +69,7 @@ /** * Used to output program list when used with --list */ -static void ListUninstallPrograms(void) +static void ListUninstallPrograms() The parameter list was correct as is. If a function takes no parameters, the correct list is 'void'. Don't change parts of the code that don't have to do with your patch, especially when you don't know what you're changing. if (i < numentries) - UninstallProgram(); + for (x=0; x<2; x++) + UninstallProgram(rootkey); Why are you calling UninstallProgram twice with the same key? Besides that, using magic numbers (2) is bad coding. + HKEY keys[2]; + keys[0] = HKEY_CURRENT_USER; + keys[1] = HKEY_LOCAL_MACHINE; HKEY keys[] = { HKEY_CURRENT_USER, HKEY_LOCAL_MACHINE }; + for (x=0; x<2; x++) You're hardcoding this value to 2, which is another bad magic number. What if, hypothetically, more root keys are added to the list? for (x = 0; x < sizeof(keys); x++) + rootkey[0] = HKEY_CURRENT_USER; + rootkey[1] = HKEY_LOCAL_MACHINE; Same thing as above. + sizeOfSubKeyName = 255; What is 255? + HKEY rootkey[2]; + rootkey[0] = HKEY_CURRENT_USER; + rootkey[1] = HKEY_LOCAL_MACHINE; Same. + /* FIXME: UninstallProgram should figure out which root key to uninstall + * from, as opposed to just going with the first value in rootkey. The + * entry gets removed this way as well, but it is not apparent by this code. + */ + UninstallProgram(*rootkey); What is the point of adding rootkey if you're not going to use it? UninstallProgram(HKEY_X) is a lot shorter. The point is, don't add something until you're going to use it. On top of that, this new code is basically UninstallProgram(HKEY_CURRENT_USER) when the original code was (parameter added for convenience) UninstallProgram(HKEY_LOCAL_MACHINE). That's not right. -- James Hawkins

2 4

Re: [PATCH] Make wine build with the Intel CC
by Jonathan Schleifer 23 Apr '07

23 Apr '07

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Wine could build fine without c++, not sure why everything has to > link against the c++ library as it will probably only be needed in > winegcc. Also these compiling flags seem kind of agressive. As I said, just quoted from my .profile, nothing special for wine. I just have -lstdc++ added there as some apps need it to compile with icc. > They are defined in include/winbase.h That's the point. They are defined INCLUDING the asm code. That's why the asm code is already defined and not needed in the file itself. > just make sure icc is recognised there. You mean: Make sure that icc doesn't get recognized as gcc. Well, I tried that. It doesn't work. This will still end in stuff like: /tmp/iccCwib4Das_.s:1499: Error: symbol `wine_get_fs' is already defined /tmp/iccCwib4Das_.s:1523: Error: symbol `wine_set_fs' is already defined > you can't just comment out those Interlocked functions, some > applications might need them. I only commented them out because they are defined TWICE. They are still there and thus the programs run. I tested running a few apps with this patch. > Plus the way you do it makes the code unreadable. I cannot test this > as I don't have icc. I'm sure someone on the list has icc. -- Jonathan

5 11

Re: ADVAPI32: Implement GetServiceDisplayNameW
by Alexandre Julliard 23 Apr '07

23 Apr '07

"Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> writes: > + size = *lpcchBuffer * sizeof(WCHAR); > + ret = RegGetValueW(hscm->hkey, lpServiceName, szDisplayName, RRF_RT_REG_SZ, &type, NULL, &size); > + switch (ret) > + { > + case ERROR_SUCCESS: > + ret = RegGetValueW(hscm->hkey, lpServiceName, szDisplayName, RRF_RT_REG_SZ, &type, lpDisplayName, &size); > + *lpcchBuffer = (size / sizeof(WCHAR)) - 1; > + break; It would be better to put the data into the buffer right away, so that you don't need two registry queries in the common case of the buffer being large enough. -- Alexandre Julliard julliard(a)winehq.org

2 1

D3DRM (to be continued....)
by David.Adam＠math.cnrs.fr 23 Apr '07

23 Apr '07

Hi all, my patches for D3DRM have not been applied yet. I thought to have made all the requested changes. But it seems no. So, am I in the good way? What changes must I make now? These patches fix Bug 7442 also. Thanks you in advance for any advice and suggestion. David Adam PS: I follow closely the following advice of wine-wiki for developpers: "Just do not give up!" of the page http://winehq.org/site/sending_patches :))

3 2

The Alky Project
by Ian Macfarlane 23 Apr '07

23 Apr '07

The Inquirer has an interesting article about something called the Alky Project which claims to have initial support for DirectX 10 on Windows XP (and possibly other operating systems). The Inquirer article is here (it links to a number of bits of info about the project): http://www.theinquirer.net/default.aspx?article=39095 They've released some sample DirectX 10 DLL files here: http://fallingleafsystems.com/site_media/preview.zip which they claim support at least one of the DirectX 10 demos fairly well (there's a readme in the zip, which is small, only 824k). I see that some person with an interest in WINE has already asked about this, to make sure they're not ripping off WINE, and they've responded with some details (including a bit of code) here: http://www.fallingleafsystems.com/forum/index.php?showtopic=12 Just posting this in case any developers haven't seen this yet and would like to know about it - sorry if it's just repeating stuff you already know, but I couldn't find anything in wine.devel about it. Best wishes Ian Macfarlane (I'm not affiliated with any of the stuff mentioned in this email)

3 2

Re: winealsa: Implement Get/SetControlDetails
by Alexandre Julliard 23 Apr '07

23 Apr '07

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -748,6 +749,22 @@ static DWORD MIX_GetDevCaps(UINT wDevID, LPMIXERCAPS2W caps, DWORD_PTR parm2) > return MMSYSERR_NOERROR; > } > > +/* convert win32 volume to alsa volume, and vice versa */ > +static DWORD normalized(long value, long prevmax, long nextmax) > +{ > + double ret = (double)value; > + ret *= (double)nextmax; > + ret /= (double)prevmax; > + ret += .5; > + TRACE("%ld/%ld -> %ld/%ld\n", value, prevmax, (long)ret, nextmax); > + > + if (ret > nextmax) > + ret = nextmax; > + else if (ret < 0) > + ret = 0; > + > + return (DWORD)ret; > +} You should probably use MulDiv() instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Removal of unused audio drivers
by Maarten Lankhorst 23 Apr '07

23 Apr '07

There are 5 different audio drivers for linux, I think this is a bit overkill, so I propose to remove the esd and nas drivers, I don't think anyone uses esd, especially that since for that task alsa can be used now since dmix addon. I'm not sure what nas is for, but it seems to be 'network audio system', I haven't seen any use for it, except that it causes a 30 seconds slowdown at showing 'audio' tab in winecfg. I don't think anyone uses it. For esd I think it's best to remove, for nas I'm also for remove, but I'll settle for removing it from winecfg list same way as winearts was disabled for a while. What are your thoughts about this? Maarten

11 13

Sorry for spamming the list :(
by Jonathan Schleifer 23 Apr '07

23 Apr '07

I had some trobule sending the messages, it seemed like they were filtered out since I wasn't subscribed to the list, therefore I resent them, but it seems like they got through after 24h. :( My apologies for this. -- Jonathan

1 0

Re: implements D3DRMVectorAdd
by Stefan Dösinger 23 Apr '07

23 Apr '07

Am Montag 16 April 2007 01:29 schrieb David.Adam(a)math.cnrs.fr: +/* Add Two Vectors */ +LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR d, LPD3DVECTOR s1, LPD3DVECTOR s2) I personally prefer D3DVECTOR * over LPD3DVECTOR, but I don't know if there's any rule for that. If in doubt follow your personal preferences. + ok( ((fabs(expectedvec.x-gotvec.x)<0.000001)&&(fabs(expectedvec.y-gotvec.y)<0.000001)&&(fabs(expectedvec.z-gotvec.z)<0.000001)), \ Perhaps its better to make 0.000001 a constant? + todo_wine { + expect_vec(e,r); + } Why did you make this a TODO_WINE if you just imlemented the function?

2 1

Re: Fix xcopy so output is either unicode (console) or oem (file)
by Kirill K. Smirnov 23 Apr '07

23 Apr '07

> "Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > >> The written strings in 866 and 1251 code pages are only readable > >> when output console code page matches the string encoding. > > > > This is in wine. > > In windows only cp866 is readable regardless of ConsoleOutputCP. > > As I said I tested under Windows (XP) only, and SetConsoleOutputCP > does change the behaviour of WriteConsoleA for me. If it wouldn't > I'd call it a bug. I tested under Windows 2003 and SetConsoleOutputCP does NOT change the behaviour of WriteConsoleA for me. Does Windows play us a trick?

2 2

Re: Fix xcopy so output is either unicode (console) or oem (file)
by Kirill K. Smirnov 23 Apr '07

23 Apr '07

> "Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > > A question: what make you think that WriteConsole uses current console > > output code page to translate strings? > > The written strings in 866 and 1251 code pages are only readable > when output console code page matches the string encoding. This is in wine. In windows only cp866 is readable regardless of ConsoleOutputCP.

2 1

Re: Fix xcopy so output is either unicode (console) or oem (file)
by Kirill K. Smirnov 23 Apr '07

23 Apr '07

> "Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > >> WriteConsole uses current console output code page to translate strings. > > > > wine - yes. > > windows - no. > > See attach. > > What makes you think so? Since I tested under Windows only I described > the results I've got under it not under Wine. Wine behaviour is not > interesting at this point. I tested under both windows and wine. The results I attached in previous mail make me think so. Please, have a look at them. A question: what make you think that WriteConsole uses current console output code page to translate strings? -- Kirill

2 1

Re: Fix xcopy so output is either unicode (console) or oem (file)
by Kirill K. Smirnov 23 Apr '07

23 Apr '07

> wprintf does write unicode strings to a console, the problem in your test > is that it doesn't change the locale from the default "C" to russian, and > the conversion from unicode to code page simply fails. > I'm attaching a modified version of your test, with some > results/conclusions: I failed to compile it under mingw32 nor winegcc as-is: con_test_dmitry.c:33:21: converting to execution character set: Invalid or incomplete multibyte or wide character con_test_dmitry.c:50:21: converting to execution character set: Invalid or incomplete multibyte or wide character > WriteConsole uses current console output code page to translate strings. wine - yes. windows - no. See attach. > WriteConsole does produce an output when not redirecting output to a file. Yes. > WriteConsole does not produce an output when redirecting output to a file, > returns FALSE and sets last error to 6 (ERROR_INVALID_HANDLE). Yes. > wprintf translates unicode strings to current CRT multibyte locale before > printing them either to a console or to a file. > > printf doesn't care about locale at all, it simply prints what it has. I do not know much about msvcrt, but I can say, they suffer from the same bug as WriteConsole. > So, the patch sent by Jason is OK, except using wchar_t instead of WCHAR. Yes, it is OK. I understood that a bit later... I've slightly modified your test to make it compile under mingw32. The results under windows and wine are attached. -- Kirill P.S. I've appiled Jason's patch during tests.

2 1

Re: Fix xcopy so output is either unicode (console) or oem (file)
by Kirill K. Smirnov 23 Apr '07

23 Apr '07

No, from this point of view the patch is correct. >> +/* >========================================================================= >> + * Output a formatted unicode string. Ideally this will go to the console >> + * and hence required WriteConsoleW to output it, however if file i/o is >> + * redirected, it needs to be WriteFile'd using OEM (not ANSI) format >> + * >>========================================================================= */ >The described above behaviour should be implemented either inside of wprintf >implementation in msvcrt, Just little test: #include <windows.h> #include <stdio.h> int main(void) { WCHAR str_uni[]={0x044d, 0x0442, 0x043e, 0x0020, 0x0442, 0x0435, 0x0441, 0x0442, 0x0000}; char str_oem[]="~]Б╝ ЮЦАА╙╗╘ Б╔╙АБ in OEM"; wprintf(str_uni); printf(str_oem); return 0; } It will write both strings in wine and only second in windows. wprintf should not write unicode strings to console. >or inside of the console driver of WriteConsoleW >depending on the test results IMO. And not here too. Application must check this itself. http://msdn2.microsoft.com/en-us/library/ms687401.aspx contains tips: [quote] Both WriteConsole and WriteFile can be used for console I/O. While WriteConsole supports writing Unicode characters to a console screen buffer, WriteFile does not. However, WriteConsole fails if it is used with a standard handle that is redirected to a file. If an application handles multilingual output that can be redirected, determine whether the output handle is a console handle (one method is to call the GetConsoleMode function and check whether it succeeds). If the handle is a console handle, call WriteConsole; otherwise, the output is redirected and you should call WideCharToMultiByte to convert the text to the current code page and WriteFile to perform the I/O. [/quote] There are some my tests at: http://www.winehq.com/pipermail/wine-devel/2007-April/056102.html I could miss something, it would be great if you check it! I've just found another bug in the patch: >+ /* Convert to OEM, then output */ >+ convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0, >output_bufW, >+ len, output_bufA, MAX_WRITECONSOLE_SIZE, >+ "?", &usedDefaultChar); The comment is correct, but code is wrong. Here should be CP_OEMCP instead of GetConsoleOutputCP(). I did not noticed it before, because there two bugs: one is here, and another is in WriteConsoleA (the same bug - should be CP_OEMCP not GetConsoleOutputCP()). And they are mutually annihilated ;-) Test demostrating that WriteConsoleA is wrong: #include <windows.h> #include <stdio.h> int main(void) { DWORD tmp; WCHAR str_uni[]={0x044d, 0x0442, 0x043e, 0x0020, 0x0442, 0x0435, 0x0441, 0x0442, 0x0000}; char str_oem[]="~]Б╝ ЮЦАА╙╗╘ Б╔╙АБ in OEM\n"; WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), str_uni, wcslen(str_uni), &tmp, NULL); WriteConsoleA(GetStdHandle(STD_OUTPUT_HANDLE), str_oem, strlen(str_oem), &tmp, NULL); SetConsoleCP(1251); SetConsoleOutputCP(1251); WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), str_uni, wcslen(str_uni), &tmp, NULL); WriteConsoleA(GetStdHandle(STD_OUTPUT_HANDLE), str_oem, strlen(str_oem), &tmp, NULL); SetConsoleCP(866); SetConsoleOutputCP(866); return 0; } =^_^= -- Kirill

2 2

WineD3D patch test needed
by Stefan Dösinger 23 Apr '07

23 Apr '07

Hi, I have a patch which fixes the performance problems introduced with c0782603d09807c6ca506948bb4a814a73430184 . I am sure that the patch is correct, but I have the bad feeling that it brings up a few other bugs, so I send it to wine-devel for testing first. It only reallocates surfaces when they are either new or the description was changed. Thanks, Stefan

3 3

Re: devenum: Constify a variable
by Robert Shearman 23 Apr '07

23 Apr '07

Andrew Talbot wrote: > */ > static HRESULT WINAPI DEVENUM_IClassFactory_CreateInstance( > LPCLASSFACTORY iface, > - LPUNKNOWN pUnkOuter, > + const IUnknown *pUnkOuter, > REFIID riid, > LPVOID *ppvObj) > I'm not sure what the point of this is. -- Rob Shearman

2 2

comments for a fix for wine/dlls/wineoss.drv/mixer.c for Solaris
by sol11x86＠comcast.net 23 Apr '07

23 Apr '07

On a current git tree, I noticed some variables falling out as undefined for Solaris Express/Build 61 and OpenSound System 4.0 v1002. I patched it the following way, but because I haven't played with sound before, wanted to get some comments on whether or not there is a better fix (or a better #ifdef to use). With this patch, I was able to hear audio from Grand Theft Auto 2. Thanks, Ben --- wine.ORIG/dlls/wineoss.drv/mixer.c 2007-04-21 16:43:39.000000000 -0400 +++ wine-git/dlls/wineoss.drv/mixer.c 2007-04-21 17:45:33.655890000 -0400 @@ -159,11 +159,15 @@ IOCTL_TO_STR(SOUND_MIXER_DIGITAL1); IOCTL_TO_STR(SOUND_MIXER_DIGITAL2); IOCTL_TO_STR(SOUND_MIXER_DIGITAL3); +#ifndef __sun__ IOCTL_TO_STR(SOUND_MIXER_PHONEIN); IOCTL_TO_STR(SOUND_MIXER_PHONEOUT); +#endif IOCTL_TO_STR(SOUND_MIXER_VIDEO); IOCTL_TO_STR(SOUND_MIXER_RADIO); +#ifndef __sun__ IOCTL_TO_STR(SOUND_MIXER_MONITOR); +#endif } #undef IOCTL_TO_STR sprintf(str, "UNKNOWN(%08x)", command);

2 1

Re: [1/2] Extend the testing framework to include IDL files and RPC clients (take 2)
by Alexandre Julliard 23 Apr '07

23 Apr '07

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > This extends the testing framework to allow for tests that need IDL > files and RPC clients. It's the same as the last attempt, but I've > removed two little development artifacts that slipped in last time, > I fixed an indentation glitch, fixed one more thing in the Makefile > so "make depend" works for ClientMakefile as well, and I separated > the first test case from the infrastructure change (see next patch). That's very ugly; you shouldn't need any of that stuff, especially not a separate makefile. You should put everything in the same exe, and differentiate server and client through command line arguments, the way the process test does it. -- Alexandre Julliard julliard(a)winehq.org

3 3

Ubuntu packages for wine-0.9.35 are broken
by Vitaliy Margolen 22 Apr '07

22 Apr '07

I'm getting number of reports on #winehq as well as in bugzilla about new Ubuntu packages for 0.9.35 having problems with displaying text and mouse cursor. It appears there were some problems with xrandr during compiling them. Scott could you take a look at this and fix them as soon as you can? Or at least remove broken packages from the repository? Vitaliy.

8 19

Re: schannel: Move schannel tests from secur32 to the recent schannel
by Robert Shearman 22 Apr '07

22 Apr '07

Yuval Fledel wrote: > Move schannel tests from secur32 to the recent schannel. Adding a > tests directory on the way. I don't see the point in this. The actual functionality is implemented in secur32, so it makes sense for the tests to also be there. -- Rob Shearman

2 1

Re: msi [3/3]: Enumerate the structured storage streams from the package into the _Streams table
by Robert Shearman 22 Apr '07

22 Apr '07

James Hawkins wrote: > + static const WCHAR Create[] = { > + 'C','R','E','A','T','E',' ','T','A','B','L','E',' ', > + '`','_','S','t','r','e','a','m','s','`',' ','(',' ', > + '`','N','a','m','e','`',' ','C','H','A','R','(','5','6',')',' ', > + 'N','O','T',' ','N','U','L','L',',',' ','`','D','a','t','a','`',' ', > + 'O','B','J','E','C','T',' ','P','R','I','M','A','R','Y',' ', > + 'K','E','Y',' ','`','N','a','m','e','`',')',0}; > This is wrong as the _Streams table shouldn't appear in the _Tables table. Also, changes added to this table won't be reflected in the actual streams in the .msi file. I think that the best way to implement this is to return a custom view from TABLE_CreateView that is implemented on top of OLE structured storage functions. -- Rob Shearman

2 1

Re: RegDeleteTree [3rd]
by Alexandre Julliard 22 Apr '07

22 Apr '07

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + /* Recursively delete all the subkeys */ > + for (i = 0; i < dwKeyCount && !ret; i++) { > + dwSize = dwMaxSubkeyLen; > + ret = RegEnumKeyExW(hSubKey, i, lpszName, &dwSize, NULL, > + NULL, NULL, NULL); This won't work, the index will change as you delete keys. > + } else { > + if (!ret) > + ret = RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0); The function is supposed to delete the key values, that's not what this does. You probably need to write some test cases... -- Alexandre Julliard julliard(a)winehq.org

4 7

Re: [PATCH] Make wine build with the Intel CC [Resent]
by Jonathan Schleifer 22 Apr '07

22 Apr '07

It seems my replies never got though because I wasn't subscribed to the list, but instead using gmane. I subscribed now and resent all my replies. Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Wine could build fine without c++, not sure why everything has to > link against the c++ library as it will probably only be needed in > winegcc. Also these compiling flags seem kind of agressive. As I said, just quoted from my .profile, nothing special for wine. I just have -lstdc++ added there as some apps need it to compile with icc. > They are defined in include/winbase.h That's the point. They are defined INCLUDING the asm code. That's why the asm code is already defined and not needed in the file itself. > just make sure icc is recognised there. You mean: Make sure that icc doesn't get recognized as gcc. Well, I tried that. It doesn't work. This will still end in stuff like: /tmp/iccCwib4Das_.s:1499: Error: symbol `wine_get_fs' is already defined /tmp/iccCwib4Das_.s:1523: Error: symbol `wine_set_fs' is already defined > you can't just comment out those Interlocked functions, some > applications might need them. I only commented them out because they are defined TWICE. They are still there and thus the programs run. I tested running a few apps with this patch. > Plus the way you do it makes the code unreadable. I cannot test this > as I don't have icc. I'm sure someone on the list has icc. -- Jonathan

1 0

Re: [PATCH] Make wine build with the Intel CC
by Maarten Lankhorst 22 Apr '07

22 Apr '07

Jonathan Schleifer schreef: > Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > >> Wine could build fine without c++, not sure why everything has to >> link against the c++ library as it will probably only be needed in >> winegcc. Also these compiling flags seem kind of agressive. >> > > As I said, just quoted from my .profile, nothing special for wine. I > just have -lstdc++ added there as some apps need it to compile with icc. > Ok, Please when responding add wine-devel to CC so others can follow discussion. >> They are defined in include/winbase.h >> > > That's the point. They are defined INCLUDING the asm code. That's why > the asm code is already defined and not needed in the file itself. > It's working well for gcc, so I would try to find out how gcc works around it and then work around the same way.. not adding ifdefs everywhere. >> just make sure icc is recognised there. >> > > You mean: Make sure that icc doesn't get recognized as gcc. Well, > I tried that. It doesn't work. This will still end in stuff like: > /tmp/iccCwib4Das_.s:1499: Error: symbol `wine_get_fs' is already defined > /tmp/iccCwib4Das_.s:1523: Error: symbol `wine_set_fs' is already defined > Some part of headers do checks specifically on GCC, you might want to do the same for icc. >> you can't just comment out those Interlocked functions, some >> applications might need them. >> > > I only commented them out because they are defined TWICE. They are still > there and thus the programs run. I tested running a few apps with this > patch. > It's still not how it's done for gcc, see above. >> Plus the way you do it makes the code unreadable. I cannot test this >> as I don't have icc. > I'm sure someone on the list has icc > Probably, but if you want to get code past julliard it is recommended to follow certain guidelines, one of them is not making an unnecesary #ifdef hell. Maarten

3 7

Re: [PATCH] Make wine build with the Intel CC [Resent]
by Jonathan Schleifer 22 Apr '07

22 Apr '07

For some strange reason, this mail didn't appear on the list. Therefore I resent it. (Maybe it's missing because it included an attached GPG signature?) Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Wine could build fine without c++, not sure why everything has to > link against the c++ library as it will probably only be needed in > winegcc. Also these compiling flags seem kind of agressive. As I said, just quoted from my .profile, nothing special for wine. I just have -lstdc++ added there as some apps need it to compile with icc. > They are defined in include/winbase.h That's the point. They are defined INCLUDING the asm code. That's why the asm code is already defined and not needed in the file itself. > just make sure icc is recognised there. You mean: Make sure that icc doesn't get recognized as gcc. Well, I tried that. It doesn't work. This will still end in stuff like: /tmp/iccCwib4Das_.s:1499: Error: symbol `wine_get_fs' is already defined /tmp/iccCwib4Das_.s:1523: Error: symbol `wine_set_fs' is already defined > you can't just comment out those Interlocked functions, some > applications might need them. I only commented them out because they are defined TWICE. They are still there and thus the programs run. I tested running a few apps with this patch. > Plus the way you do it makes the code unreadable. I cannot test this > as I don't have icc. I'm sure someone on the list has icc. -- Jonathan

1 0

WINECFG: use directory harddiskvolume1 for mapping drive C
by EA Durbin 22 Apr '07

22 Apr '07

What's the status of this patch? http://article.gmane.org/gmane.comp.emulators.wine.devel/40343/match=harddi… _________________________________________________________________ Mortgage refinance is Hot. *Terms. Get a 5.375%* fix rate. Check savings https://www2.nextag.com/goto.jsp?product=100000035&url=%2fst.jsp&tm=y&searc…

2 2

Re: Improving SysEx handling in winealsa.drv
by Stefan Dösinger 22 Apr '07

22 Apr '07

Am Samstag 21 April 2007 18:44 schrieb Michał W.: > Please consider incorporating the patch I submit, which improves > handling of MIDI System Exclusive messages > in alsa driver. It should be applied to dlls/winealsa.drv/midi.c file. > > The patch resolves the following bug: > http://bugs.winehq.org/show_bug.cgi?id=6788 > > Regards, > Michał Wiernowolski < /* FIXME: Should handle sysex greater that a single buffer */ --- > /* FIXME: Should handle sysex greater than lpMidiHdr->dwBufferLength */ ... It is highly recommendet to use git to generate patches. If you're using cvs or diff, please make unified diffs.

2 1

re: WINECFG: use directory harddiskvolume1 for mapping drive C
by Dan Kegel 22 Apr '07

22 Apr '07

To state the obvious, another workaround is: cd ~/.wine mv drive_c harddiskvolume1 cd dosdevices ln -sf ../harddiskvolume1 c: BTW this is http://bugs.winehq.org/show_bug.cgi?id=5351 - Dan

1 0

re: Make wine build with the Intel CC
by Dan Kegel 21 Apr '07

21 Apr '07

Maarten wrote: > I cannot test this as I don't have icc It's a free download for noncommercial use; see http://www.intel.com/cd/software/products/asmo-na/eng/compilers/277618.htm - Dan

1 0

[PATCH] Make wine build with the Intel CC
by Jonathan Schleifer 21 Apr '07

21 Apr '07

Hi! This patch makes it possible to build an run wine with the Intel compiler. Here are the environment variables I used to build: export CC="icc" export CFLAGS="-O3 -xP -msse3 -parallel" export CXX="icc" export CXXFLAGS="-O3 -xP -msse3 -parallel" export LDFLAGS="-lguide -lsvml -lstdc++ -parallel" export MAKEFLAGS="-j 2" (Not all are needed, just quoting from my .profile) And here's the patch: diff -Nru wine-0.9.35/dlls/kernel32/sync.c wine-0.9.35-icc/dlls/kernel32/sync.c --- wine-0.9.35/dlls/kernel32/sync.c 2007-04-13 17:47:52.000000000 +0200 +++ wine-0.9.35-icc/dlls/kernel32/sync.c 2007-04-21 17:20:13.000000000 +0200 @@ -1885,12 +1885,14 @@ * InterlockedCompareExchange (KERNEL32.@) */ /* LONG WINAPI InterlockedCompareExchange( PLONG dest, LONG xchg, LONG compare ); */ +#ifndef __INTEL_COMPILER __ASM_GLOBAL_FUNC(InterlockedCompareExchange, "movl 12(%esp),%eax\n\t" "movl 8(%esp),%ecx\n\t" "movl 4(%esp),%edx\n\t" "lock; cmpxchgl %ecx,(%edx)\n\t" "ret $12") +#endif /*********************************************************************** * InterlockedExchange (KERNEL32.@) diff -Nru wine-0.9.35/dlls/kernel32/thread.c wine-0.9.35-icc/dlls/kernel32/thread.c --- wine-0.9.35/dlls/kernel32/thread.c 2007-04-13 17:47:52.000000000 +0200 +++ wine-0.9.35-icc/dlls/kernel32/thread.c 2007-04-21 17:21:25.000000000 +0200 @@ -554,11 +554,13 @@ * SetLastError (KERNEL32.@) */ /* void WINAPI SetLastError( DWORD error ); */ +#ifndef __INTEL_COMPILER __ASM_GLOBAL_FUNC( SetLastError, "movl 4(%esp),%eax\n\t" ".byte 0x64\n\t" "movl %eax,0x34\n\t" "ret $4" ) +#endif /*********************************************************************** * GetLastError (KERNEL.148) diff -Nru wine-0.9.35/dlls/ntdll/thread.c wine-0.9.35-icc/dlls/ntdll/thread.c --- wine-0.9.35/dlls/ntdll/thread.c 2007-04-13 17:47:52.000000000 +0200 +++ wine-0.9.35-icc/dlls/ntdll/thread.c 2007-04-21 17:19:41.000000000 +0200 @@ -1429,7 +1429,9 @@ */ #if defined(__i386__) && defined(__GNUC__) +#ifndef __INTEL_COMPILER __ASM_GLOBAL_FUNC( NtCurrentTeb, ".byte 0x64\n\tmovl 0x18,%eax\n\tret" ) +#endif #elif defined(__i386__) && defined(_MSC_VER) diff -Nru wine-0.9.35/libs/wine/ldt.c wine-0.9.35-icc/libs/wine/ldt.c --- wine-0.9.35/libs/wine/ldt.c 2007-04-13 17:47:52.000000000 +0200 +++ wine-0.9.35-icc/libs/wine/ldt.c 2007-04-21 17:19:41.000000000 +0200 @@ -480,10 +480,14 @@ __ASM_GLOBAL_FUNC( wine_get_cs, "movw %cs,%ax\n\tret" ) __ASM_GLOBAL_FUNC( wine_get_ds, "movw %ds,%ax\n\tret" ) __ASM_GLOBAL_FUNC( wine_get_es, "movw %es,%ax\n\tret" ) +#ifndef __INTEL_COMPILER __ASM_GLOBAL_FUNC( wine_get_fs, "movw %fs,%ax\n\tret" ) +#endif __ASM_GLOBAL_FUNC( wine_get_gs, "movw %gs,%ax\n\tret" ) __ASM_GLOBAL_FUNC( wine_get_ss, "movw %ss,%ax\n\tret" ) +#ifndef __INTEL_COMPILER __ASM_GLOBAL_FUNC( wine_set_fs, "movl 4(%esp),%eax\n\tmovw %ax,%fs\n\tret" ) +#endif __ASM_GLOBAL_FUNC( wine_set_gs, "movl 4(%esp),%eax\n\tmovw %ax,%gs\n\tret" ) # endif /* defined(_MSC_VER) */ diff -Nru wine-0.9.35/programs/winefile/winefile.c wine-0.9.35-icc/programs/winefile/winefile.c --- wine-0.9.35/programs/winefile/winefile.c 2007-04-13 17:47:52.000000000 +0200 +++ wine-0.9.35-icc/programs/winefile/winefile.c 2007-04-21 17:19:41.000000000 +0200 @@ -283,7 +283,11 @@ if (!pvswprintf) { HMODULE hModMsvcrt = LoadLibraryA("msvcrt"); +#ifdef __INTEL_COMPILER + pvswprintf = GetProcAddress(hModMsvcrt, "vswprintf"); +#else pvswprintf = (int(__cdecl*)(WCHAR*,const WCHAR*,va_list)) GetProcAddress(hModMsvcrt, "vswprintf"); +#endif } va_start(ap, fmt); I #ifdef'd the asm code out since for some strange reason, it was already defined when using ICC. Could you please test it and commit it if it works? -- Jonathan

2 1

winmm: Allow a FORCE_SHUTDOWN on driver close?
by Maarten Lankhorst 21 Apr '07

21 Apr '07

After trying to implement the alsa mixer I came across a problem: If winmm is unloading, a deadlock could occur if during unloading it's waiting for another thread. In winmm itself this isn't much of a problem: there aren't any threads. However, the drivers used by winmm may have threads, and if the application doesn't shut down their drivers properly, it could be possible that a deadlock occurs when the drivers unload because winmm unloads. For that reason I propose to add a flag that's passed to the sound drivers that signals a shutdown in DLL_DETACH context, so that drivers can choose to call TerminateThread instead of waiting tidily for the thread to finish running. It's not pretty, but I don't see another way how to make sure that deadlocks won't occur when unloading winmm. I'm open for other suggestions though. Maarten

2 3

Re: dsound: Make sure we're holding the lock on Drop And Stop , try 2
by Peter Beutner 21 Apr '07

21 Apr '07

Maarten Lankhorst schrieb: > This fixes an interesting deadlock with the alsa driver: > > DSOUND_Stop is called, message is added to thread queue. > DSOUND_Release is called, message is added to thread queue. > > Both are fast messages, so second is added before first. But this only works if DSOUND_Stop and DSOUND_Release are called from different threads, right? > > thread reads: We're going down! And terminates. > > DSOUND_Stop's message is never read and it waits till eternity, so > starting/stopping never occurs any more. Isn't the real problem that when ALSA_DestroyRingMessage(*) is called from IDsDriverBuffer_Release it doesn't check if there are still any "fast messages" in the queue which wait for their message to be handled? Just from a quick look it seems you could theoretically trigger the same deadlock with the WODM_RESET & WODM_CLOSE messages when using the waveout system. (*) probably affects all other sound drivers as well which use this (horrible complex) message ring buffer system.

2 4

PATCH: fix configure.ac to find functions on Solaris
by sol11x86＠comcast.net 21 Apr '07

21 Apr '07

This patch allows configure.ac to generate a configure script which will properly find some network functions that require Solaris to include -lsocket on. The first AC_CHECK_FUNCS tests connect, and if it's not found in "libc", then the existing code just adds -lsocket to the list of libraries. Once that occurs, the rest of the get X by Y functions are found for a solaris host. Prior to this patch, mozilla.exe would start, but would fail when looking up a host. When applied, this patch allows mozilla.exe to actually resolve a host on Solaris and render the page. Ben --- configure.ac | 24 ++++++++++++++++-------- 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 5f718c7..7895ec5 100644 --- a/configure.ac +++ b/configure.ac @@ -1141,6 +1141,9 @@ fi dnl **** Check for functions **** +dnl **** connect, gethostbyname and inet_aton are not actually +dnl **** used, but are included to help identify the right +dnl **** libraries to use. AC_CHECK_FUNCS(\ _pclose \ @@ -1165,22 +1168,15 @@ AC_CHECK_FUNCS(\ ftruncate \ futimes \ futimesat \ - getaddrinfo \ getdirentries \ gethostbyname \ - getnameinfo \ - getnetbyname \ getopt_long \ getpagesize \ - getprotobyname \ - getprotobynumber \ getpwuid \ - getservbyport \ gettid \ gettimeofday \ getuid \ inet_aton \ - inet_network \ kqueue \ lstat \ memmove \ @@ -1195,7 +1191,6 @@ AC_CHECK_FUNCS(\ rfork \ sched_yield \ select \ - sendmsg \ setrlimit \ settimeofday \ sigaltstack \ @@ -1247,6 +1242,19 @@ then AC_CHECK_LIB(resolv,inet_aton) fi +dnl **** Check for functions which may rely on -lsocket on Solaris. +dnl **** If connect is found in libc, then it's all good anyway. +AC_CHECK_FUNCS( + getaddrinfo \ + getnameinfo \ + getnetbyname \ + getprotobyname \ + getprotobynumber \ + getservbyport \ + inet_network \ + sendmsg \ +) + dnl **** Check for types **** AC_C_CONST -- 1.5.1.1

1 0

Re: include: introduce ntsecpkg.h
by Kai Blin 21 Apr '07

21 Apr '07

On Saturday 21 April 2007 00:20, Yuval Fledel wrote: > ntsecpkg.h specifies the interface with Authentication Security > Support Providers. This is a quick glance over your file, comparing with the implementation I had lying around on my box. > The first 50 lines were imported from w32api. The rest was submitted > to w32api too. The ISC_* and ASC_* #defines are useless. You include security.h, which in turn includes sspi.h which contains all of those. SECURITY_NATIVE_DREP and SECURITY_NETWORK_DREP are defined in rpc.h, no need to have them in ntsecpkg.h Looking at other include files, I don't think +#if __GNUC__ >=3 +#pragma GCC system_header +#endif + +#include "windef.h" +#include "ntsecapi.h" +#include "security.h" + should be in there. > I wish I could make the patch smaller, however the last two lines > depend on all the rest, and the rest is useless without the last two. You could make the patch mor readable by adding the occasional new line between the typedefs of all those structs. Looking good otherwise. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

re: gethostbyname(my_name) and IL2-Sturmovik CONTINUED
by Dan Kegel 21 Apr '07

21 Apr '07

Briareos wrote: > The Problem: gethostbyname(own_name) always returns 127.0.0.1. ... > To me it's logical that you get 127.0.0.1 when pinging your local hostname, > but if windows does give the IP of your NIC then wine should do as well - as > we want to reach compatibility. > >If, on the other hand, you say it's simply bad programming done by the >app-developer if he tries to fetch the IP of the NIC that way, I'd say let's >still comply to it, because its more likely than having a programmer >expecting to get 127.0.0.1 when asking for "localhostname". My understanding is that hostnames are not really hostnames, but interface names. On Unix, 127.0.0.1 is never normally returned unless you ask for literally "localhost". I suspect Windows behaves like Unix here. So this probably is a valid bug in wine. (I suspect that the app developer is misguided, because binding to just one interface doesn't work well if you have multiple interfaces, but that's neither here nor there.) - Dan

4 4

Re: wineshelllink: fall back to $HOME if $HOME/Desktop does not exist
by Jeff L 21 Apr '07

21 Apr '07

Lei Zhang wrote: > Hi, > > As reported in bug 7373, some people do not have a Desktop directory > in their home directory. Wineshelllink should fall back to putting > .desktop files in the home directory if the Desktop directory does not > exist. Is there a reason why we should not just create a Desktop directory? Seems neater than cluttering up the home. Jeff

4 6

Re: Fix xcopy so output is either unicode (console) or oem (file)
by Dmitry Timoshkov 21 Apr '07

21 Apr '07

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> wrote: > +/* ========================================================================= > + * Output a formatted unicode string. Ideally this will go to the console > + * and hence required WriteConsoleW to output it, however if file i/o is > + * redirected, it needs to be WriteFile'd using OEM (not ANSI) format > + * ========================================================================= */ > +int XCOPY_wprintf(const wchar_t *format, ...) { The described above behaviour should be implemented either inside of wprintf implementation in msvcrt, or inside of the console driver of WriteConsoleW depending on the test results IMO. That's why I asked you to solve msvcrt and console output problems separately. Also please do not introduce wchar_t, use WCHAR instead. -- Dmitry.

1 0

Whats the approved technique to restier a dll in registry
by Jeff L 21 Apr '07

21 Apr '07

There seems to be two ways to do this, add the entries to wine.inf or set the dll up as self registering. There are examples of both in wine and the discussion seems to favour self registering but people still seem to be adding registry entries to wine.inf. A bit of guidance would be appreciated. Jeff Latimer

1 0

[programs/uninstaller] fixed patch, but there is a problem somewhere else...
by Tom Spear 20 Apr '07

20 Apr '07

With James' help, I managed to get the uninstaller patch done up right, however, I am running into a small problem. The way I had originally done the array at the top of FetchUninstallInformation was not correct, however it allowed for proper functionality. HKEY hkeyroot[numrootkeys]; hkeyroot[0] = HKEY_CURRENT_USER; hkeyroot[1] = HKEY_LOCAL_MACHINE; With that code, I can open the uninstaller, and see all of the uninstall entries. With the following, correct code: HKEY hkeyroot[] = { HKEY_CURRENT_USER, HKEY_LOCAL_MACHINE }; When I open the uninstaller, the first uninstall entry is not shown (and from what I can tell in the additional traces that I put in, looks like it is not even being found). However, when I type something into the filter editbox, like the first letter of that entry that is missing, it appears. The same function is being called with the dialog first opens as is being called when the dialog refreshes. If I type into the filter field, and then select something and hit uninsall, and then cancel the uninstall, the window updates again, and the first entry disappears again. Like I said, the UNINSTALL calls UpdateList, the INITDIALOG calls UpdateList, and the FILTER calls UpdateList as well, however in UNINSTALL and INITDIALOG cases the first entry does not appear. I think the problem is somewhere else in wine, but I cannot confirm this right now without doing a trace+all, and I am leaving work for the weekend.. The patch and registry file I am using are attached if anyone wants to look into this while I am gone. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: [resend]gdi32 : Completes WidenPath implementation
by Alexandre Julliard 20 Apr '07

20 Apr '07

Laurent Vromman <laurent(a)vromman.org> writes: > elp = HeapAlloc( GetProcessHeap(), 0, size ); > - > + lp = HeapAlloc( GetProcessHeap(), 0, sizeof(LOGPEN)); > GetObjectW( dc->hPen, size, elp ); > + > + obj_type = GetObjectType(dc->hPen); > + if(obj_type == OBJ_PEN) { > + memcpy(lp, elp, sizeof(LOGPEN)); > + penStyle = lp->lopnStyle; > + } > + else if(obj_type == OBJ_EXTPEN) { > + penStyle = elp->elpPenStyle; > + } > + else { > + SetLastError(ERROR_CAN_NOT_COMPLETE); > + return FALSE; > + } There's no reason to make a copy of the structure, a typecast would work just as well. Also you are leaking memory here. -- Alexandre Julliard julliard(a)winehq.org

1 0

gethostbyname(my_name) and IL2-Sturmovik CONTINUED
by Briareos 20 Apr '07

20 Apr '07

Hello list, I want to continue a discussion about a problem already reported by David Nolden in December 2005. It is about what gethostbyname should return if given the machines name and does not only affect IL-2 Sturmovik. Placing a quick cite of him here: [...] The Problem: gethostbyname(own_name) always returns 127.0.0.1. [...] The socket is then bound to the ip-adress 127.0.0.1, and to it's corresponding loopback-interface, so it's unusable. Any connection-request times out. [...] All the discussion back then happened (in wine-devel) between the 12.12.2005 and 14.12.2005. Subject: "gethostbyname(my_name) and IL2-Sturmovik" And a Patch: wine-patches: 17.01.2006 02:00:21 Subject: gethostbyname-patch Check also Bug #7929 (duplicated by #8075). My opinion is simple: To me it's logical that you get 127.0.0.1 when pinging your local hostname, but if windows does give the IP of your NIC then wine should do as well - as we want to reach compatibility. If, on the other hand, you say it's simply bad programming done by the app-developer if he tries to fetch the IP of the NIC that way, I'd say let's still comply to it, because its more likely than having a programmer expecting to get 127.0.0.1 when asking for "localhostname". Any comments welcome!

3 2

secur32: invert error handling conditions in order to decrease indentation in secur32/wrapper.c.
by Yuval Fledel 20 Apr '07

20 Apr '07

> On Saturday 14 April 2007 00:56, Yuval Fledel wrote: > > - the patch is a no-op. > > While I like to do the same to functions I work on, is there any reason you > need to change this for wrapper.c? It hasn't been changed for quite a while > and seems feature complete. > > Kai Hi Kai, Please reply-to-all next time. I've found your reply on the archive. I'm working on schannel at the moment. schannel is not a regular SSP, and the functions in wrapper.c can't load native. I've implemented the proper loading code in my local tree and I'm sending it in obvious pieces. no-op cleanups is the first step. I could implement schannel as a normal SSP and use the current code. However, if I can do something closer to what native does, I'd better do it. Not that loading native schannel is a piece of cake. It does require faking lsass (done), and implementing lots of functions everywhere (userenv, crypt32, ntdll, rsaenh: I'll send after a cleanup and writing tests). The current stage is that native schannel loads and initializes, but builtin rsaenh does not supply everything it needs, so it can't complete the ssl handshake. Native rsaenh requires unimplemented stuff in ntdll. On Saturday 14 April 2007 00:56, Detlef wrote: > I suggest to modify only one Function per Patch > (max. two Functions, when they work together and the total Patch-size > is small). Will do. -- Yuval Fledel

3 3

Re: wine.inf: update registry key
by Dmitry Timoshkov 20 Apr '07

20 Apr '07

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, this fixes bug #7953 -> http://bugs.winehq.org/show_bug.cgi?id=7953 > Vitaly said this one won't go as it might break another app, but i don't > get that , as the key in windows looks quite the same, No it doesn't in the default Windows setup, and the key was changed for a reason to make Picasa work some time ago: http://source.winehq.org/git/wine.git/?a=commitdiff;h=f03c86a27387cd1dc27c3… -- Dmitry.

2 2

Re: Move console input/output codepages to server
by Kirill K. Smirnov 20 Apr '07

20 Apr '07

> "Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > > @@ -141,12 +138,19 @@ HWND WINAPI GetConsoleWindow(VOID) > > */ > > UINT WINAPI GetConsoleCP(VOID) > > { > > - if (!console_input_codepage) > > + BOOL ret; > > + UINT codepage = GetOEMCP(); /* default value */ > > + > > + SERVER_START_REQ(get_console_input_info) > > { > > - console_input_codepage = GetOEMCP(); > > - TRACE("%u\n", console_input_codepage); > > + req->handle = 0; > > + ret = !wine_server_call_err( req ); > > + if (ret && reply->codepage) > > + codepage = reply->codepage; > > Did you test what happens when an app sets console code page to a pseudo > cp like CP_ACP (0)? Your code will force code page to be always equal to > what GetOEMCP returns in that case. IsValidCodePage will fail. App is not allowed to pass CP_ACP, CP_OEMCP and other pseudo codepages to these function. #include <windows.h> int main(void) { printf("%d\n", IsValidCodePage(CP_ACP)); printf("%d\n", IsValidCodePage(CP_OEMCP)); SetConsoleCP(CP_ACP); printf("%d\n", GetConsoleCP()); SetConsoleOutputCP(CP_ACP); printf("%d\n", GetConsoleOutputCP()); SetConsoleCP(CP_OEMCP); printf("%d\n", GetConsoleCP()); SetConsoleOutputCP(CP_OEMCP); printf("%d\n", GetConsoleOutputCP()); return 0; } Small test: This will write under both wine and windows: 0 0 866 866 866 866 If change codepage to cp1251 via chcp, output will be: 0 0 1251 1251 1251 1251 So my code is OK. -- Kirill

1 0

Re: iphlpapi: Only call res_init() once per process
by Kai Blin 20 Apr '07

20 Apr '07

On Wednesday 18 April 2007 20:39, Hans Leidekker wrote: > +static int resolver_initialised; Shouldn't that be static int resolver_initilised = 0; here? I thought that in C, ints aren't initialized to 0 automatically. > +/* call res_init() just once because of a bug in Mac OSX 10.4 */ > +static void initialise_resolver( void ) > +{ > + if (!resolver_initialised) > + { > + res_init(); > + resolver_initialised = 1; > + } > +} Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

4 4

Re: Move console input/output codepages to server
by Dmitry Timoshkov 20 Apr '07

20 Apr '07

"Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > @@ -141,12 +138,19 @@ HWND WINAPI GetConsoleWindow(VOID) > */ > UINT WINAPI GetConsoleCP(VOID) > { > - if (!console_input_codepage) > + BOOL ret; > + UINT codepage = GetOEMCP(); /* default value */ > + > + SERVER_START_REQ(get_console_input_info) > { > - console_input_codepage = GetOEMCP(); > - TRACE("%u\n", console_input_codepage); > + req->handle = 0; > + ret = !wine_server_call_err( req ); > + if (ret && reply->codepage) > + codepage = reply->codepage; Did you test what happens when an app sets console code page to a pseudo cp like CP_ACP (0)? Your code will force code page to be always equal to what GetOEMCP returns in that case. -- Dmitry.

1 0

re: clusapi.h - add states for GetNodeClusterState()
by Dan Kegel 19 Apr '07

19 Apr '07

You might have more luck getting these three patches in if you also checked in a conformance test that depended on them. And were you careful to write winsxs.h yourself as opposed to copying and pasting from a Microsoft header or web page? - Dan

2 3

Re: Add new dll - sxs.dll
by Michael Stefaniuc 19 Apr '07

19 Apr '07

EA Durbin wrote: > > > _________________________________________________________________ > Mortgage refinance is Hot. *Terms. Get a 5.375%* fix rate. Check savings > https://www2.nextag.com/goto.jsp?product=100000035&url=%2fst.jsp&tm=y&searc… > > > > ------------------------------------------------------------------------ > >>From 8df8958bb809e856de99bdbbdfbba828b0a16359 Mon Sep 17 00:00:00 2001 > From: EA Durbin <ead1234(a)hotmail.com> > Date: Thu, 19 Apr 2007 01:03:55 -0500 > Subject: Add new dll sxs.dll > > --- > dlls/sxs/Makefile.in | 14 ++++++++++++++ > dlls/sxs/sxs.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ > dlls/sxs/sxs.spec | 2 ++ > 3 files changed, 62 insertions(+), 0 deletions(-) > create mode 100644 dlls/sxs/Makefile.in > create mode 100644 dlls/sxs/sxs.c > create mode 100644 dlls/sxs/sxs.spec > > diff --git a/dlls/sxs/Makefile.in b/dlls/sxs/Makefile.in > new file mode 100644 > index 0000000..507442a > --- /dev/null > +++ b/dlls/sxs/Makefile.in > @@ -0,0 +1,14 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = sxs.dll > +IMPORTLIB = libsxs.$(IMPLIBEXT) > +IMPORTS = kernel32 > + > +C_SRCS = \ > + sxs.c > + > +@MAKE_DLL_RULES@ > + > +@DEPENDENCIES@ # everything below this line is overwritten by make depend > diff --git a/dlls/sxs/sxs.c b/dlls/sxs/sxs.c > new file mode 100644 > index 0000000..3e033fe > --- /dev/null > +++ b/dlls/sxs/sxs.c > @@ -0,0 +1,46 @@ > +/* > + * sxs main > + * > + * Copyright 2007 EA Durbin > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "winsxs.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(sxs); > + > + > +/*********************************************************************** > + * DllMain (SXS.@) > + * > + */ > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + switch(fdwReason) > + { > + case DLL_WINE_PREATTACH: > + return FALSE; /* prefer native version */ > + case DLL_PROCESS_ATTACH: > + DisableThreadLibraryCalls( hinstDLL ); > + break; > + } > + return TRUE; > +} > diff --git a/dlls/sxs/sxs.spec b/dlls/sxs/sxs.spec > new file mode 100644 > index 0000000..47056cd > --- /dev/null > +++ b/dlls/sxs/sxs.spec > @@ -0,0 +1,2 @@ > +@ stub CreateAssemblyNameObject > +@ stub CreateAsseblyCache ^^^ Typo? bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Comments for a patch?
by sol11x86＠comcast.net 19 Apr '07

19 Apr '07

On a Solaris system, getaddrinfo is not found during the AC_CHECK_FUNC test, because the libs required for getaddrinfo have not been found on Solaris yet. By moving the AC_CHECK_FUNC for getaddrinfo, below where libsocket and libnsl are checked, getaddrinfo is now found on Solaris, and I'm able to resolve a host and render a page with wine running mozilla.exe. Comments? --- wine.ORIG/configure.ac 2007-04-16 08:10:24.000000000 -0400 +++ wine/configure.ac 2007-04-19 09:14:59.156193000 -0400 @@ -1165,7 +1165,6 @@ ftruncate \ futimes \ futimesat \ - getaddrinfo \ getdirentries \ gethostbyname \ getnameinfo \ @@ -1247,6 +1246,8 @@ AC_CHECK_LIB(resolv,inet_aton) fi +AC_CHECK_FUNCS(getaddrinfo) + dnl **** Check for types **** AC_C_CONST

1 0

Re: xcopy: add Russian resource
by Dmitry Timoshkov 19 Apr '07

19 Apr '07

"Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > ChangeLog: > add Russian resource Please pass it through a spell checker first, there are spelling errors along with wrong punctuation in your translation. -- Dmitry.

1 0

Re: Implements D3DRMVectorScale
by Dmitry Timoshkov 19 Apr '07

19 Apr '07

<David.Adam(a)math.cnrs.fr> wrote: > --- /dev/null > +++ b/include/d3drmdef.h ... > +#ifdef WIN32 > +#define D3DRMAPI __stdcall > +#else > +#define D3DRMAPI > +#endif What's the point of the WIN32 macro test (does this mean that win64 doesn't have stdcall decorations)? Also (I already pointed out to it) is it necessary to introduce D3DRMAPI like microsoft header does instead of using simple WINAPI? > --- /dev/null > +++ b/dlls/d3drm/tests/vector.c > + pD3DRMVectorAdd = (void*)GetProcAddress(hmod, "D3DRMVectorAdd"); ... > + pD3DRMVectorAdd(&r,&u,&v); You do this in all your tests: proc = GetProcAdress("procname"); then call the proc without any check for it being NULL. Why not link to d3drm.dll using import library instead? -- Dmitry.

1 0

re: Comments for a patch?
by Dan Kegel 19 Apr '07

19 Apr '07

I'm not an autoconf guru, but I play one on TV. You wrote: +AC_CHECK_FUNC(getaddrinfo, [AC_DEFINE([HAVE_GETADDRINFO], [1], + [Defined to 1 if you have the getadrinfo function,])], + [AC_CHECK_LIB(socket, getaddrinfo, + [AC_DEFINE([HAVE_GETADDRINFO]) LIBS="-lsocket -lnsl $LIBS"], , , -lnsl)]) I'm not sure it's healthy to assume that -lsocket and -lnsl go together like that. Have you looked at how Samba does it? See http://samba.org/ftp/unpacked/distcc/configure.ac - Dan

1 0

Request for small bit of mentoring
by Tom Spear 18 Apr '07

18 Apr '07

I found a small bug in the uninstaller program, and would like to write the fix myself. I have a working copy in my local tree, but it duplicates code. Basically I found that uninstaller does not scan the uninstall registry entry of HKEY_CURRENT_USER. I took lines 196-197 and duplicated that, changing HKEY_LOCAL_MACHINE to HKEY_CURRENT_USER, and then did the same for lines 210-228. I would like to get down to a smaller linecount, but I would like to do the patch myself, so I would appreciate some assistance in figuring out how. Could someone email me privately to help? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 5

Re: locales, unicode and ansi with msvcrt (bug 8022)
by Kirill K. Smirnov 18 Apr '07

18 Apr '07

Hi Jason, While preparing tests I found the 'user' backend of wineconsole works with WriteConsole/WriteFile correct (see test1 and test2), so I used it as etal. I figured out the main issue with cmd: It passes strings to WriteFile in ANSI, but should in OEM. I think the main locale issue is found. CMD and XCOPY violate this. So it is not MSVCRT bug. Moreover, [w]fprintf MUST NOT perform any AnsiToOem convertions (as test3 and test4 show). I made and attached a quick hack to demostrate that cmd was buggy. Attached screenshots show the difference. The patch heals almost everything, even localized filenames. So I'm CC'ing mail to wine-devel, console/cmd gurus must know much more ;-) I found some issues with wprintf, see README for test3 and test4. The attached tests are made with your patch applied. What about running cmd without console, I think it is not a good idea - we must check locale and enconding, thus we must perform various convertions: to utf8, to cp1251, to koi8-r... Or just we must set correct value of console_[input|output]_codepage variables? Does windows console supports UTF8 as output codepage? > Given I don't know russian, is there any chance of writing me a short > program which uses _wfopen, fwprintf, fclose to create me a file with a > name and contents which are russian text, so I can test some of the cmd.exe > issues reported with NLS chars. > Could I also have: > 1. Output from 'chcp' in a windows command prompt c:\>chcp "Текущая кодовая страница: 866" ["Current codepage: 866"] > 2. screen shot of 'dir' in a windows command prompt after running the > program so I know what characters I am expecting > 3. Details of the LANG env var, and details of the xterm (I run Mandrake, > and have Settings->Font and Settings->Encoding options which seem like the > way to tailor what appears LANG=ru_RU.KOI8-R xterm -fn koi10x20 > Hopefully I can take the program and run it under wine, and see what > filename it creates, then work out why DIR doesn't display it correctly. I > am almost certain its because the wine cmd.exe program is converting in the > wrong codepage somehow. I want to do an exercise of unicoding wine's cmd > once I finish work on the commands I have left to do (mostly copy, for and > attrib) > I suspect your winegcc issues are use of the L"unicode string" from my > example at a guess, but to be honest I don't know I've already figured out it: I should pass option "-mno-cygwin" to winegcc. It makes winegcc link against msvcrt.dll instead of glibc. Thanks a lot for working upon this bug! -- Kirill

2 1

Comments for a patch?
by sol11x86＠comcast.net 18 Apr '07

18 Apr '07

I am compiling the stock current CVS 0.9.35 code on Solaris 10/X86. I was successful in starting notedpad and winemine, so the base looks good. I installed mozilla-win32-1.7.13-installer.exe, and am able to start mozilla.exe, but it will not lookup host name, and therefore won't render any pages. I saw a message about getaddrinfo not being found, and I figured out that configure was not correctly finding the function due to missing libraries (-lsocket, -lnsl) during the test for getaddrinfo. Once I crafted the patch below, and running autoheader/autoconf and the configure /gmake depend && gmake, the installed wine was able to run mozilla.exe and correctly lookup a hostname and render the page. I'd like comments from the devel-list as this is my first patch. Apologies for not being in GIT format, as I don't have that working quite yet. Patch was crafted from a clean CVS tree against the changes using gdiff -ruN. Notes on the patch: I tried several autoconf configurations, but this was the only one that correctly enabled HAVE_GETADDRINFO in config.h. If someone has improvements on the patch, I'd appreciate it. I'm just not an autoconf guru. Thanks, Ben --------------------------------------------- --- wine.ORIG/configure.ac 2007-04-16 08:10:24.000000000 -0400 +++ wine/configure.ac 2007-04-18 15:48:24.111885000 -0400 @@ -1165,7 +1165,6 @@ ftruncate \ futimes \ futimesat \ - getaddrinfo \ getdirentries \ gethostbyname \ getnameinfo \ @@ -1247,6 +1246,13 @@ AC_CHECK_LIB(resolv,inet_aton) fi +dnl **** Check for getaddrinfo **** + +AC_CHECK_FUNC(getaddrinfo, [AC_DEFINE([HAVE_GETADDRINFO], [1], + [Defined to 1 if you have the getadrinfo function,])], + [AC_CHECK_LIB(socket, getaddrinfo, + [AC_DEFINE([HAVE_GETADDRINFO]) LIBS="-lsocket -lnsl $LIBS"], , , -lnsl)]) + dnl **** Check for types **** AC_C_CONST

1 0

Better Debugging Possibilities for Wine on Ubuntu
by Stephan Hermann 18 Apr '07

18 Apr '07

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear Colleagues, As Scott Ritchie knows, I'm at the moment the reponsible person for Wine on Ubuntu. I hope that you all know, Ubuntu has a new system for filing crash reports and stacktraces. (named apport aka automatic crash reports, some documentation is found at https://wiki.ubuntu.com/Apport) Those reports are working quite well for all apps in Ubuntu, but not as expected for Wine, especially when windows apps are involved. We discussed yesterday about this problem, and now we want your help, to make things better. What we need from you: - What do you need from us (Ubuntu) to get better backtraces when wine crashes (especially wine-preloader) - How can we work together in a better way? (e.g. crashreport will be filed in launchpad (http://www.launchpad.net) automatically, can we file a bugreport automatically in your bugzilla?) - If yes, what information do you really need, what can we tell the users, who are reporting those crashes, what they have to do to fullfill your needs for the bugreport and debugging (e.g. try to reproduce the crash while running wine in gbd, doing a backtrace with bt full, or what so ever) Finally, we would like to have more involvement of you, Wine Developers, to make Wine a vital piece of software for Ubuntu. And now a little call for help to Scott Ritchie :) Scott, we talked some time ago about having you in our MOTU team, for maintaining not only debian/ubuntu packages at winehq, but also for Ubuntu. We, the Ubuntu MOTU team, and I personally think, this would be quite good having you on board. I know, that you are working hard on your packages, and we need your help. If you want, please get in touch with me (email: sh@sourcecode,de or jabber JID:sh@linux-server.org) and let's discuss how we can get you easily in our MOTU team. Thanks for your attention, Stephan aka \sh @ freenode.net - -- Stephan Hermann Ubuntu Developer http://launchpad.net/~shermann shermann(a)ubuntu.com -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGJcYqwYnnM8CY76gRApcrAJ4xIsAUY7pLQTGzfTXIf47jIrnmywCfSTiG yX7HXj4ZzR1WiKzy+IUlXwE= =BssM -----END PGP SIGNATURE-----

5 7

current CVS behavior - uninstall not uninstalling man pages
by sol11x86＠comcast.net 18 Apr '07

18 Apr '07

While testing another "feature", I did a gmake uninstall and noticed that my man pages were still in /opt/wine/share/man/man1. Has anyone noticed this regression? Ben

1 0

IRC Nick Table
by Detlef Riekenberg 18 Apr '07

18 Apr '07

I added the "Local Time" info for the IRC Nick Table in the wiki. It's easier to find a usable Time, when you want to meet someone on IRC. Please update ... Thanks -- By by ... Detlef

1 0

Why are some fonts being displayed incorrectly
by Bill Medland 18 Apr '07

18 Apr '07

Can anyone point me in the correct direction for this? On one machine the text displays correctly. On the other the characters are totally wrong If I install the arial32.exe then the characters are displayed correctly and attractively If I remove the sserife.fon (and the arial fonts) then the characters are displayed correctly but unattractively, something like a courier font or similar. Both machines are using freetype-2.1.9-5 The first also includes freetype-devel but presumably that doesn't matter. How do I figure out why the characters are being drawn incorrectly? (Installing the arial32 is not a long-term solution) Bill

1 2

Re: iphlpapi: Only call res_init() once per process
by H. Verbeet 18 Apr '07

18 Apr '07

On 18/04/07, Jason Green <jave27(a)gmail.com> wrote: > Original author: Mark Adams, TransGaming Technologies. > Why are you the one submitting this then, using a private mail address? (Are you even allowed to, for that matter?)

2 2

Re: programs/uninstaller: check HKCU for uninstall entries [Try #2]
by Tom Spear 18 Apr '07

18 Apr '07

Oops, here it is lol. Tom On 4/18/07, Steven Edwards <winehacker(a)gmail.com> wrote: > On 4/18/07, Tom Spear <speeddymon(a)gmail.com> wrote: > > Comments, questions, feel free. > > Please resend with the attachment. > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: Header file for D3DRM
by Stefan Dösinger 18 Apr '07

18 Apr '07

Am Montag 16 April 2007 01:28 schrieb David.Adam(a)math.cnrs.fr: > One patch for one email as requested. > > David Adam If you send a series of patches it recommended to mark the numbers in the mail headers too, like "[1/12] Header file for D3DRM". This makes it easier to find the next patch

1 0

programs/uninstaller: check HKCU for uninstall entries [Try #2]
by Tom Spear 18 Apr '07

18 Apr '07

Submitting for approval to here before I send to wine-patches This pretty much changes most of the functions in the uninstaller to handle arrays so that we can actually handle scanning HKCU as well as HKLM. In my tests, this did not break anything, and allows entries listed in uninstall for both HKLM and HKCU to be seen, as well as allowing them to be uninstalled. This version of the patch does not duplicate code, like the old one did, and causes no additional warnings when compiling. Comments, questions, feel free. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: [Bug 8085] DVD Shrink: Goes into infinite loop when Creating Class Enumerator
by Tom Spear 18 Apr '07

18 Apr '07

Please post messages in the relevant bug, not to the list or to a list archive. Thanks Tom On 4/17/07, Bob Good <bobbyjean58(a)yahoo.com> wrote: > > > > Wine - Bugs mailing list wrote: > > > > http://bugs.winehq.org/show_bug.cgi?id=8085 > > > > I can confirm this bug. DVD Shrink, under Wine 0.9.35, goes into a loop > > which you can see if you open it from Terminal. Obviously, DVD Shrink will > > not even open. > > > > > > > > ------- Additional Comments From austinenglish(a)gmail.com 2007-17-04 19:47 > > ------- > > Created an attachment (id=5836) > > --> (http://bugs.winehq.org/attachment.cgi?id=5836&action=view) > > Log of error loop. > > > > > > -- > > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > > ------- You are receiving this mail because: ------- > > You are the assignee for the bug, or are watching the assignee. > > > > > > > > > > -- > View this message in context: http://www.nabble.com/-Bug-8085--DVD-Shrink%3A-Goes-into-infinite-loop-when… > Sent from the Wine - Bugs mailing list archive at Nabble.com. > > > > -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

re: Better Debugging Possibilities for Wine on Ubuntu
by Dan Kegel 18 Apr '07

18 Apr '07

sh wrote: > [apport doesn't handle wine well. > And where should the bugs be filed - wine's bugzilla, or launchpad?] The bugs should definitely go to launchpad, because each distribution has a different set of packages and bugs, each distribution's crash logger should go to its own bug tracker. winehq's bugzilla should be treated as an upstream bug tracker, and only manually triaged and distilled versions of the automated bug reports should go upstream. BTW the apport doc is at https://wiki.ubuntu.com/Apport and it would be great if some systemy sort of guy had a look. I'll see if I can find somebody to... I would myself, but I can't type enough to get any real work done these days. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

[try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath
by Kirill K. Smirnov 18 Apr '07

18 Apr '07

>If FILE_name_AtoW fails, the function fails, so the return value should be FALSE, shouldn't it ? TRUE means that current directory '.' should be added to PATH. FALSE is returned if a special environment variable NoDefaultCurrentDirectoryInExePath is set. Of course, default sane value should be TRUE. Details at http://msdn2.microsoft.com/en-us/library/ms684269.aspx. -- Kirill

1 0

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath
by Laurent Vromman 18 Apr '07

18 Apr '07

+/*********************************************************************** + * NeedCurrentDirectoryForExePathA (KERNEL32.@) + */ +BOOL WINAPI NeedCurrentDirectoryForExePathA( LPCSTR name ) +{ + WCHAR *nameW; + + if (!(nameW = FILE_name_AtoW( name, FALSE ))) return TRUE; If FILE_name_AtoW fails, the function fails, so the return value should be FALSE, shouldn't it ? Laurent On Wed, 18 Apr 2007 15:54:42 +0400, "Kirill K. Smirnov" <lich(a)math.spbu.ru> wrote: > Please, ignore my previous attempt. > >

1 0

kernel32: Add partial stub for NeedCurrentDirectoryForExePath
by Kirill K. Smirnov 18 Apr '07

18 Apr '07

>+ if (strchrW(name, '\\')) >+ return TRUE; >What is the point of this? You're returning TRUE no matter what anyway. >+ FIXME("(%s): stub!\n", debugstr_w(name)); >+ return TRUE; ancient patch in attach, sorry.

1 0

Re: kernel32: Add partial stub for NeedCurrentDirectoryForExePath
by James Hawkins 18 Apr '07

18 Apr '07

On 4/18/07, Kirill K. Smirnov <lich(a)math.spbu.ru> wrote: > Add partial stub for NeedCurrentDirectoryForExePath. It is needed by win2003 > cmd.exe > + if (strchrW(name, '\\')) + return TRUE; What is the point of this? You're returning TRUE no matter what anyway. + FIXME("(%s): stub!\n", debugstr_w(name)); + return TRUE; -- James Hawkins

1 0

Re: Bug 5163
by EA Durbin 18 Apr '07

18 Apr '07

It appears to me according to this log section that the bug is actually in kernel32.CompareStringA, though I could be wrong. It starts out comparing the strings of files it is looking for in the cabinet file with kernel32.CompareString and unsuccesfully matching, then it appears to be matching the first couple of letters in the string and then continuing on before it actually finds the file it is looking for. SC2R.SAM is matching scanost.exe EXCHCSP.DLL_0001 is matching exchng.hlp after it finds these false matches the installer continues on without actually matching the string it is looking for >From: "James Hawkins" <truiken(a)gmail.com> >To: "EA Durbin" <ead1234(a)hotmail.com> >Subject: Re: Bug 5163 >This is a pretty crazy bug, and I don't think it's a problem in >msi. The custom action searches through the entire contents of the >cdrom (including all the files in the cabinet) looking >for...something. I don't know what it's looking for though. -- >James Hawkins _________________________________________________________________ Get a FREE Web site, company branded e-mail and more from Microsoft Office Live! http://clk.atdmt.com/MRT/go/mcrssaub0050001411mrt/direct/01/

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel