- wine-devel - winehq.org

Question using appdb
by Laurent Vromman 18 Apr '07

18 Apr '07

Hi, When a distribution is absent from the list, we are supposed to add it, as the following message explain : Distribution If yours is not on the list, please add it using the form below The fact is, there is no form below. Is the message wrong or is the form missing ? Note : The distribution I want to add is the new Debian Lenny Laurent Vromman

3 4

Re: Implementation of mathematical functions for D3DRM
by Tom Wickline 18 Apr '07

18 Apr '07

On 4/15/07, David.Adam(a)math.cnrs.fr <David.Adam(a)math.cnrs.fr> wrote: > Here is the complete implementation of the mathematical functions of > D3DRM with tests. > Tests work under Windows XP and wine. > > This work was done in colloboration with Vijay Kamuju. > > Comments are welcome . Can you please resubmit these patches? with only one patch per email Tom > > David ADAM > > > > > -- Tom Wickline Respectable computing - Linux/FOSS

1 0

Re: D3D9: Rework the converted vertex declaration management (try 3)
by Vitaly Budovski 18 Apr '07

18 Apr '07

Stefan � wrote: >> Another patch which grows by 0.5 * existing size >> You could as well just grow it to twice the existing size. It would be easier.

1 0

Old versions of Acrobat Pro tryout?
by Dan Kegel 18 Apr '07

18 Apr '07

Hey Tom, thanks for the help finding old Photoshops. I'm now looking for old Acrobat Pro trials. Best source I've found so far is for the foreign language versions, http://www.winsoft.eu/support/adobe-download.php but I don't speak any of those languages. FIleplanet doesn't seem to have any, and Tucows only points to adobe.com. Can you have a look for Acrobat Pro 7 or earlier trial versions (in english, french, german, or spanish)? Thanks! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 3

FW: locales, unicode and ansi with msvcrt (bug 8022)
by Ann & Jason Edmeades 17 Apr '07

17 Apr '07

(Meant to copy wine-devel as well, in case anyone else had any comments) Subject: RE: locales, unicode and ansi with msvcrt (bug 8022) >> My current plan, unless you have strong objections, is to make the wprintf >> msvcrt routines use WideCharToMultiByte on the string into the GetACP >> codepage before being written out, and add file tests for this into the >> msvcrt testsuite >You shouldn't really guess, you need to investigate how the things are supposed >to work in Windows. IMO you are going wrong route by looking how msvcrt works >instead of looking how cmd.exe does. Did you try to run native cmd.exe in WIne >and see how it handles cp conversions, or under logger.exe in Windows? Firstly, leave cmd.exe out of the equation. This has nothing to do with it at all. Just to emphasize, I am looking at the part of the bug where xcopy was writing out characters padded with gaps (nulls) which is caused by it simply calling msvcrt's wprintf. I can recreate the problem with a simple, one line console application run through wine (not cmd.exe nor wineconsole): void main() { wprintf(L"test with wprintf"); } [program was compiled VC6 : cl /MD test.c ] wine test >a.a od -x a.a 0000000 0074 0065 0073 0074 0020 0077 0069 0074 0000020 0068 0020 0077 0070 0072 0069 006e 0074 0000040 0066 export WINEDLLOVERRIDES=msvcrt=n wine test >a.a od -x a.a 0000000 6574 7473 7720 7469 2068 7077 6972 746e 0000020 0066 Shows wine internal msvcrt differs from windows msvcrt and incorrectly outputs Unicode >> I'm also guessing relay and snoop cant see internal dll calls, so that might >> explain the lack of calls. Perhaps something like wcstombs would be the key >> to this >Even if internal dll calls are not logged, wcstombs does an external call to do >its job. What makes you say that? It potentially doesn't need to, given the internal caching it does in process_attach, it could do it all in memory. However... WINEDEBUG=+all,+relay,+snoop wine test 2>a.a a.a (removing Set/GetLastError and Tls call) shows: 0009:CALL msvcrt.wprintf(00403010) ret=0040100d 0009:Call ntdll.RtlAllocateHeap(00410000,00000000,00001000) ret=77c2c3c9 0009:trace:heap:RtlAllocateHeap (0x410000,00000002,00001000): returning 0x412168 0009:Ret ntdll.RtlAllocateHeap() retval=00412168 ret=77c2c3c9 0009:Call kernel32.WriteFile(00000008,0033f9c8,00000011,0033f9ac,00000000) ret=77c30218 0009:trace:file:WriteFile 0x8 0x33f9c8 17 0x33f9ac (nil) 0009:trace:ntdll:NtWriteFile (0x8,(nil),(nil),(nil),0x33f8b8,0x33f9c8,0x00000011,(nil),(nil))! 0009: get_handle_fd( handle=0x8, access=00000002, cached=1 ) 0009: get_handle_fd() = 0 { type=1, flags=0 } 0009:Ret kernel32.WriteFile() retval=00000001 ret=77c30218 0009:RET msvcrt.wprintf() retval=00000011 ret=0040100d Note the writefile call - it passed 0x11 bytes (number of bytes in the narrow string) Logger shows no calls from msvcrt during that time, but I don't trust it. Running test program under windbg and trying to follow it through it does appear wctomb is called (it does NOT result in WideCharToMultiByte, possibly due to the characters or locale I am using?) but it does it on a character by character basis (I believe during the formatting). This would be the equivalent on wine to calling pf_vsnprintf with out.unicode set to false. (I don't know why it doesn't come up on snoop - maybe it's a near call (no fixups?). So its back to a necessity to ensure for text streams we only output multibyte (not wide). I can see 2 ways of doing it: 1. Change MSVCRT_vfwprintf and add a conversion widechartomultibyte for a text stream (if (MSVCRT_fdesc[fd].wxflag & WX_TEXT) ...) Advantages: Changes self contained, easy Disadvantages: Formatting into Unicode buffer, then need to allocate space for answer, convert, print, free 2. Change MSVCRT_vfwprintf to use a new internal function which is identical to MSVCRT_vsnwprintf but sets out->Unicode = FALSE and out.buf.A as destination string. Advantages: Fastest way (conversion is WC->MB as the formatting is processed) Disadvantage: Needs new internal function My preference is (2), and I have coded and tested it to confirm it does solve both the file i/o tests (included in patch) and the console output tests (performed by hand) Comments? Jason

3 3

Should we trim the changelog?
by Scott Ritchie 17 Apr '07

17 Apr '07

As of the latest release, the changelog has gotten to over 2.1 megabytes. Perhaps it is time we archive it somewhere and distribute a smaller, trimmed changelog with new releases? Thanks, Scott Ritchie

3 2

RICHEDIT_CLASS10A debugging and testing
by Alban Browaeys 17 Apr '07

17 Apr '07

Hi I am trying to build a test case for a bug I have with RichEdit10ANSIWndProc called with EM_GETTEXTRANGE on an editor with two newlines at the end of the range. In such case ME_GetTextW is called with editor->bEmulateVersion10 which does nChars--;. In the case of a newline nChars is 1 thus become 0 and -1 a little while later when the code is : nChars-=nLen (where nLen is 1 as we reach the end of the range on newlines). My workaround is to add : if (nChars == 1) nLen = 0; after the editor->bEmulateVersion10 but I do not understand why it works (well except that having nChars being -1 is bad) and if nLen-- without the if nChars == 1 would be better. So I am trying to add a test case to riched20 by defining: static HWND new_richedit10A(HWND parent) { return new_window(RICHEDIT_CLASS10A, ES_MULTILINE, parent); } but this fails with an invalid handler error. Could someone help me ? Thank you Alban ___________________________________________________________________________ Découvrez une nouvelle façon d'obtenir des réponses à toutes vos questions ! Profitez des connaissances, des opinions et des expériences des internautes sur Yahoo! Questions/Réponses http://fr.answers.yahoo.com

1 0

Re: D3D9: Rework the converted vertex declaration management (try 3)
by H. Verbeet 17 Apr '07

17 Apr '07

On 17/04/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This time uses HeapReAlloc, grows the array by 4(defined as a constant). The > information from the initial search is used for putting the element into the > array. > Typically you would grow by a percentage. I think MoveMemory would be preferred over memove, but I'm not sure.

1 0

Services, net start, and control panel
by Dan Kegel 17 Apr '07

17 Apr '07

While pondering native msiexec's navel, I looked around for ways to start, stop, and list services on Wine. Didn't see any; there probably ought to be a net.exe command that implements start and stop verbs, and a little control panel, too. I bet it wouldn't be too hard to implement them. For the curious, here are a couple service-related demo apps that might be of interest: http://www.codeproject.com/system/xyntservice.asp is a handy little demo service, and http://www.codeproject.com/system/AMFSServiceManager.asp is a handy little control-panel-like service manager gui (doesn't work because EnumServiceStatus isn't implemented). - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 1

locales, unicode and ansi with msvcrt (bug 8022) - and -mno-cygwin option
by Kirill K. Smirnov 17 Apr '07

17 Apr '07

>I've tried the test with winelib and got: >$ winegcc test.c >$ ./a.out > nya >$ od -x nya >0000000 3f3f 3f3f 3f3f 3f3f 0066 >0000011 >This output differs from previous. I tried this under several locales, the >results are the same. test.c: void main() { wprintf(L"test with wprintf"); } I continued my investigation of this problem and what I figured out: 1) no options for winegcc: $ winegcc test.c $ ./a.out > out $ od -x out 0000000 3f3f 3f3f 3f3f 3f3f 0066 0000011 2) -mno-cygwin $ winegcc -mno-cygwin test.c $ ./a.out > out $ od -x out 0000000 6574 7473 7720 7469 2068 7077 6972 746e 0000020 0066 This is OK. I tried -mconsole option too, but it did not make any difference. So -mno-cygwin option heals the program. What magic does -mno-cygwin option? I cannot understand, why it is necessary. Moreover, tests for msvcrt are OK without -mno-cygwin. -- Kirill

1 0

Re: RegDeleteTree
by Paul Vriens 17 Apr '07

17 Apr '07

Stefan Leichter wrote: > ChangeLog > -------------- > added implementation of RegDeleteTreeA/W > > > ------------------------------------------------------------------------ > > --- ../wine-git/dlls/advapi32/advapi32.spec 2006-10-03 10:52:50.000000000 +0200 > +++ dlls/advapi32/advapi32.spec 2007-04-13 22:14:25.000000000 +0200 > @@ -473,6 +473,8 @@ > @ stdcall RegCreateKeyW(long wstr ptr) > @ stdcall RegDeleteKeyA(long str) > @ stdcall RegDeleteKeyW(long wstr) > +@ stdcall RegDeleteTreeA(long str) > +@ stdcall RegDeleteTreeW(long wstr) > @ stdcall RegDeleteValueA(long str) > @ stdcall RegDeleteValueW(long wstr) > @ stdcall RegDisablePredefinedCache() > --- ../wine-git/dlls/advapi32/registry.c 2007-04-09 18:15:02.000000000 +0200 Hi Stefan, Isn't there supposed to be a corresponding entry to winreg.h ? Cheers, Paul.

2 1

Patch for AddFontMemResourceEx implemetation in wine
by Byeong-Sik Jeon 17 Apr '07

17 Apr '07

2007-04-17, 12:53 +0930, Patrick Eiffe wrote: > Beong-Jik, > Hi, > I have updated your patch from http://bugs.winehq.org/show_bug.cgi?id=5865 > to work with the latest git, and I was going to send it in but I was informed > that it would be much easier for the patch to be added if it was sent by the > original author. > By the way, thanks a bunch for implementing this, > now I can play AOE 3 with the correct font :P > > Regards, > Patrick Eiffe > Hi, I'm glad your mail. :) My RemoveFontMemResourceEx function implementation is bad. This function implementation has the critical problem. This patch need to rewrite. For playing AOE 3, we need the AddFontMemResourceEx function only. Implementation of AddFontMemResourceEx function is not difficult. I hope any codeweavers people's good work. Not Me. My patch was always bad... and, I can't spend my time. I'm sorry my poor english. Thank you.

1 0

Better support for IL-2 Sturmovik
by Briareos 17 Apr '07

17 Apr '07

Hello, I subscribed to this list, because I want to help in developing wine so that (my current favorite) simulation works better. Egoistic hah :) ? - a good motivation though ... The first thing I want to go for is the networking support, which does not work at all. So I started off with the Developers Guide, but I noticed while debugging, that I could use some "instant" guidance - some person available via ICQ, any other IM or even TeamSpeak who can give quick hints. Maybe here somebody might also be interested in providing better support for this game and even wants to cooperate with me in the development. I am trying to track down the problem which causes the game Sturmovik not to be able to connect to a server. As I didn't find any other link to a person So if any of you are often online in any IM and want to provide help, I would appreciate it. Thanks in advence Briareos

5 5

FAQ moved to Wiki
by Scott Ritchie 17 Apr '07

17 Apr '07

I've pasted the content from the FAQ onto the wiki here: http://wiki.winehq.org/FAQ I'll spend some time updating it, formatting, and removing cruft this weekend. What I couldn't figure out how to do, however, was create a patch for wine docs that deletes the actual en/wine-faq.sgml file from the source code, which still lives in a CVS repository. Could someone tell me how to do this with cvs? Thanks, Scott Ritchie

5 6

locales, unicode and ansi with msvcrt (bug 8022)
by Kirill K. Smirnov 17 Apr '07

17 Apr '07

I've tried the test with winelib and got: $ winegcc test.c $ ./a.out > nya $ od -x nya 0000000 3f3f 3f3f 3f3f 3f3f 0066 0000011 This output differs from previous. I tried this under several locales, the results are the same. When I applied the patch, EXE version (I used mingw32 instead of VC 6), works OK, but no changes with winelib. Buggy winegcc??? Next test. Here I use localized strings. #include <windows.h> void main() { /* "Это тест" ("this is a test" in Russian) */ WCHAR russtr[]={0x044d, 0x0442, 0x043e, 0x0020, 0x0442, 0x0435, 0x0441, 0x0442, 0x0000}; wprintf(L"test with wprintf"); wprintf(russtr); } Result of mingw32-gcc version: 0000000 6574 7473 7720 7469 2068 7077 6972 746e 0000020 fd66 eef2 f220 f1e5 00f2 0000031 The localized string has been written in cp1251. The results are the same "wine cmd a.exe" and "wine /k a.exe". winconsole --backend=user does not work. The same test under windows (mingw32 version): Only "test with wprintf" has been printed. No localized string. Mystic? Wine works, but windows does not??? Under simple "wine cmd /k ..." windows programs and wine produce the same output (now). Under wineconsole embedded cmd commands like 'help' still does not work. Windows The Native Ones - works OK. I suspect we output them in the wrong way. Thus, the bug where xcopy was writing out characters padded with gaps is fixed, but invalid codepage bug is still present. pf_vsnprintf is buggy??? (yes, it sounds blasphemic, but it is the one thing I can imagine). Thanks a lot! -- Kirill

1 0

Re: [04/10] wined3d: Ignore SetTextureStageState on unsupported texture stages
by Stefan Dösinger 16 Apr '07

16 Apr '07

Am Montag 16 April 2007 21:19 schrieb H. Verbeet: > Tests indicate that Windows doesn't actually check the bounds on this > call. However, since our memory layout is almost certainly different > > >from Windows' an application might very well get away with a little > > bit of memory corruption on Windows and not on Wine. It seems to me > that the best way to deal with this is to simply print a WARN and > return WINED3D_OK. > > Changelog: > - Ignore SetTextureStageState on unsupported texture stages Wouldn't it be better to check against MAX_TEXTURES instead of the gl limit? Or do changes get lost on windows too? GetTextureStageState may tell the difference

2 1

re: Which component should I use to create this bug ?
by Dan Kegel 16 Apr '07

16 Apr '07

lauren wrote: >When Navigation is installed, the file DAO350.dll is copied to the >Common Files directory and is regsrved. When running Navigation >after that, it displays an error message about not finding DAO350.dll. > >Copying the file to windows/system32 allows Navigation to find >the file and use it, but it should be able to find it in Common Files too. > >Which component should I choose ? If installing native dcom fixes it, use wine-ole. (e.g. winetricks dcom98) If in doubt, use wine-misc. (Native MSI doesn't seem to work right now, so don't try that... see http://bugs.winehq.org/show_bug.cgi?id=5809 ) > Navigation is a Visual Basic program, using VB methods to load dlls. Be sure to give the app's home page. If you had mentioned it in this message, I would have tried it out myself... - Dan

3 3

Re: advapi32: Added test and fix for GetFileSecurity
by James Hawkins 16 Apr '07

16 Apr '07

On 4/16/07, Nigel Nia-Chiang Liang <ncliang(a)gmail.com> wrote: > Hi, > > Added a simple test case and fix for GetFileSecurity with NULL > pSecurityDescriptor parameter as suggested by James Hawkins. > SetLastError(NO_ERROR); + result = pGetFileSecurityA( directory,OWNER_SECURITY_INFORMATION,buffer,0x40,&outSize); Please don't change the whitespace. The SetLastError call is a part of that test block, so there's no need for an empty line. + result = pGetFileSecurityA( directory,OWNER_SECURITY_INFORMATION,NULL,0x40,&outSize); + ok(result, "GetFileSecurityA should not fail for NULL pSecurityDescriptor parameter\n"); What is the value of outSize in this case? You need to set it to some value before the call and check if it's changed after the call. -- James Hawkins

1 0

Re: crypt32: Constify some variables (4 of 5) (Resend)
by Robert Shearman 16 Apr '07

16 Apr '07

Andrew Talbot wrote: > typedef BOOL (WINAPI *CryptDecodeObjectFunc)(DWORD, LPCSTR, const BYTE *, > DWORD, DWORD, void *, DWORD *); > typedef BOOL (WINAPI *CryptDecodeObjectExFunc)(DWORD, LPCSTR, const BYTE *, > - DWORD, DWORD, PCRYPT_DECODE_PARA, void *, DWORD *); > + DWORD, DWORD, const CRYPT_DECODE_PARA *, void *, DWORD *); > > This declaration needs to match that of CryptDecodeObjectEx in wincrypt.h. -- Rob Shearman

2 1

Random X errors caused by recent cursor patch?
by Dan Kegel 16 Apr '07

16 Apr '07

Looks like there's been a regression lately. I'm getting errors like this X Error of failed request: BadPixmap (invalid Pixmap parameter) Major opcode of failed request: 54 (X_FreePixmap) Resource id in failed request: 0x2a0006a randomly, about every fourth time I run things that used to work. A user on c.e.m.w. http://groups.google.com/group/comp.emulators.ms-windows.wine/msg/1f41dbd21… speculates that the recent cursors patch introduced the regression. The error doesn't happen often enough to make a regression test easy, and I haven't tried myself yet.

7 8

gdi32 : Questions about SetDIBColorTable and GetDIBColorTable
by Laurent Vromman 16 Apr '07

16 Apr '07

Hi, I am looking deeper inside gdi32 in order to continue helping wine after my first try on WidenPath. Something looks strange to me in SetDIBColorTable and GetDIBColorTable. GetDIBColorTable is structured like this : if (dc->funcs->pGetDIBColorTable) result = dc->funcs->pGetDIBColorTable; else { result = local implementation; } return result; This looks normal. If dc->funcs->pGetDIBColorTable is available, wine uses it, else it uses a local implementation. In both cases, the return value is the result of the chosen operation. But I have more difficulties with SetDIBColorTable : result = local implementation; if (dc->funcs->pGetDIBColorTable) dc->funcs->pGetDIBColorTable; return result; Whatever happen next, the local implementation is used. Then if pGetDIBColorTable is available, it is used too. I see here a second call for the same thing, even if the local implementation succeed. Moreover, the result of dc->funcs->pGetDIBColorTable is not used as a return value. Is there a mistake here, or is there something I do not understand ? GetDIBColorTable uses the local implementation only if dc->funcs is not available. That is not the case for SetDIBColorTable, which runs first the local implementation. What is the right policy to apply here ? I believe the call order of pSetDIBColorTable and the fact its return value is not used are errors. Am i wrong? If someone can confirm I am not, I will provide a patch in the next days. Thank you for your help and time, Laurent Vromman

2 1

Re: winealsa: implement opening and closing of device, and return caps.
by Alexandre Julliard 16 Apr '07

16 Apr '07

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > +/* Note: this thread can be TerminateThread'd, when not in critical section > + * Hence I use alloca here, and a critical section to protect when it is not > + * desired to be TerminateThread'd, assume when the critical section is taken > + * we won't ever get it back and we're signalled to terminate > + */ > +static DWORD WINAPI callback_thread(LPVOID lParam) You can't use TerminateThread for normal termination, it should only be used for fatal erros when cleaning up properly is not possible. Also please don't use alloca. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: D3D9: Rework the converted vertex declaration management
by H. Verbeet 16 Apr '07

16 Apr '07

On 16/04/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > I have hope that this fixes the converted decl issues finally(appart of > sorting the array, which will be another patch) > > + convertedDecls = HeapAlloc(GetProcessHeap(), 0, sizeof(IDirect3DVertexDeclaration9 *) * (This->numConvertedDecls + 1)); > + if(!convertedDecls) { > + /* This will destroy it */ > + IDirect3DVertexDeclaration9_Release(pDecl); > + return NULL; > + } > + > + memcpy(convertedDecls, This->convertedDecls, sizeof(IDirect3DVertexDeclaration9 *) * (This->numConvertedDecls)); > + HeapFree(GetProcessHeap(), 0, This->convertedDecls); Growing the array by a single element each time looks a bit expensive. Also note that you could use HeapReAlloc there.

2 1

Re: user32: Fix to succeed reliably in test where it works by accident.
by Robert Shearman 16 Apr '07

16 Apr '07

Jan Zerebecki wrote: > + if (!iconinfo->hbmMask) { > + return 0; > + } > if (iconinfo->hbmColor) > { > Please match the coding style of the rest of the function. -- Rob Shearman

1 0

KDevelop configure error or winebug
by marcel busse 16 Apr '07

16 Apr '07

hi i can't debug with winedbg. it steps until end cause of no line debug info. at the start of the debugging process there is a fixme - it says something about dwarf-2 information. My config: i started a hello world with kdevelop and took as c++ compiler wineg++. that's all. __________________________________ Yahoo! Clever - Der einfachste Weg, Fragen zu stellen und Wissenswertes mit Anderen zu teilen. www.yahoo.de/clever

2 1

Which component should I use to create this bug ?
by Laurent Vromman 16 Apr '07

16 Apr '07

Hi, I am trying to create a bug in Bugzilla concerning Navigation. When Navigation is installed, the file DAO350.dll is copied to the Common Files directory and is regsrved. When running Navigation after that, it displays an error message about not finding DAO350.dll. Copying the file to windows/system32 allows Navigation to find the file and use it, but it should be able to find it in Common Files too. Which component should I choose ? I am not sure where the problem is. Navigation is a Visual Basic program, using VB methods to load dlls. Thank you for your help. Laurent Vromman

1 0

Re: quartz: Partially implement the MPEG 1 Stream Splitter filter
by Dmitry Timoshkov 16 Apr '07

16 Apr '07

Chris Robinson <chris.kcat(a)gmail.com> wrote: > +static inline void flip_dword(DWORD *pVal) > +{ > + DWORD val = *pVal; > + val = (val>>24) | ((val>>8)&0xFF00) | > + ((val&0xFF00)<<8) | (val<<24); > + *pVal = val; > +} > + > +static inline void flip_word(WORD *pVal) > +{ > + WORD val = *pVal; > + val = (val>>8) | (val<<8); > + *pVal = val; > +} You need to take WORDS_BIGENDIAN macro into account, not blindly assume that we are running on a LE machine. Something like (as done in other DLLs): #ifdef WORDS_BIGENDIAN #define GET_BE_WORD(x) (x) #define GET_BE_DWORD(x) (x) #else #define GET_BE_WORD(x) RtlUshortByteSwap(x) #define GET_BE_DWORD(x) RtlUlongByteSwap(x) #endif Besides it looks like flip_word() is not used. > +static int head_check(DWORD head) > +{ > + /* If this is a possible start code, check for a system or video header */ > + if ((head & 0xFFFFFF00) == 0x100) { > + /* Check if we got a system or elementary stream start code */ > + if (head == PACK_START_CODE || head == VIDEO_ELEMENTARY_STREAM || > + head == AUDIO_ELEMENTARY_STREAM) > + return MPEG_SYSTEM_HEADER; > + > + /* Check for a MPEG video sequence start code */ > + if (head == SEQUENCE_HEADER_CODE) > + return MPEG_VIDEO_HEADER; > + } > + > + /* This should give a good guess if we have an MPEG audio header */ > + if((head & 0xffe00000) == 0xffe00000 && ((head>>17)&3) != 0x0 && > + ((head>>12)&0xf) != 0xf && ((head>>10)&0x3) != 0x3) > + return MPEG_AUDIO_HEADER; Why not use a struct with bit fields to simplify the above check? > + if (headercode & (1<<20)) > + { > + lsf = ((headercode & (1<<19)) ? 0x0 : 0x1); > + mpg25 = 0; > + } > + else > + { > + lsf = 1; > + mpg25 = 1; > + } > + > + layer = 4-((headercode>>17)&0x3); > + bitrate_index = ((headercode>>12)&0xf); > + freq_index = ((headercode>>10)&0x3) + (mpg25?6:(lsf*3)); > + padding = ((headercode>> 9)&0x1); > + mode = ((headercode>> 6)&0x3); > + mode_ext = ((headercode>> 4)&0x3); > + emphasis = ((headercode )&0x3); Same here. -- Dmitry.

2 1

Re: locales, unicode and ansi with msvcrt (bug 8022)
by Ann & Jason Edmeades 16 Apr '07

16 Apr '07

> > >What your test app is doing? It probably needs a test under Windows > > >to see in which encoding (ANSI/OEM) a not unicode app should > > >receive input via a pipe. > > > I meant things like 'dir >lst.txt', 'dir | sort > lst.txt'. 'dir' and > 'sort' could be replaced by some external .exes that get input and > produce outpup. > Hiya, I wrote an app which did ReadConsoleW and then traced out the hex of the first character read in, and used ALT+157 as a mechanism to supply a character which differs between the codepages I was playing with: (All the following was under windows XP) Code: ReadConsoleW(GetStdHandle(STD_INPUT_HANDLE), buf, sizeof(buf)/sizeof(WCHAR), &nChars, NULL); printf("Character at position 0 is %x\n", buf[0]); Results: Active code page: 437 - Character at position 0 is a5 Active code page: 850 - Character at position 0 is d8 Active code page: 1252 - Character at position 0 is 9d So I think its converting between the console codepage and Unicode, if I interpret that correctly. I then modified it to write out (**) unicode character 0xa5 to see if the conversion is back to oem or ansi, and although its hard to prove beyond doubt(*), it appears to me I am getting the reverse of that, it its converted to the console codepage before being output.. (*) in cmd.exe if its not full screen, the font does not change when chcp is executed, so for 437 and 850 I get an 0 type char and a yen. If I do it full screen, both give me a yen, so I would concur from that the character codepoint is changing and comes out depending on the font (**) Because I want to test this with WriteConsoleW, this does not get redirected to a file so I cant see the raw codepoints... Anything else I can test, or am I ok to put file tests into msvcrt test buckets and allow the msvcrt unicode printf and friends to convert to non-unicode using the console codepage before being output to the file handle? Suggested tests welcome, but I was planning on using the unicode wide file i/o functions, the opening in and confirming the bytes were as expected (If I stick to a-z, 0-9 we will know if its come out with extra 0's) Regards and thanks for your time, Jason

2 4

Re: secur32: invert error handling conditions in order to decrease indentation in secur32/wrapper.c.
by Kai Blin 15 Apr '07

15 Apr '07

On Saturday 14 April 2007 00:56, Yuval Fledel wrote: > - the patch is a no-op. While I like to do the same to functions I work on, is there any reason you need to change this for wrapper.c? It hasn't been changed for quite a while and seems feature complete. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: secur32: invert error handling conditions in order to decrease indentation in secur32/wrapper.c.
by Detlef Riekenberg 15 Apr '07

15 Apr '07

On Sa, 2007-04-14 at 01:56 +0300, Yuval Fledel wrote: > wrapper.c | 1252 > ++++++++++++++++++++++++++------------------------------------ > 1 file changed, 545 insertions(+), 707 deletions(-) I have no Idea about the code in secur32.dll, but your Patch is much to large. I suggest to modify only one Function per Patch (max. two Functions, when they work together and the total Patch-size is small). As an Example: secur32: Reorder code (SECUR32_makeSecHandle) -- By by ... Detlef

1 0

Re: Implementation of mathematical functions for D3DRM
by James Hawkins 15 Apr '07

15 Apr '07

On 4/15/07, David.Adam(a)math.cnrs.fr <David.Adam(a)math.cnrs.fr> wrote: > Here is the complete implementation of the mathematical functions of > D3DRM with tests. > Tests work under Windows XP and wine. > One patch per email please. -- James Hawkins

1 0

Recommendation for configure.ac fix
by sol11x86＠comcast.net 15 Apr '07

15 Apr '07

I've just started hacking on wine. I've found a case of Solaris supporting the getaddrinfo function call that is tested in configure (via configure.ac) but I need to add specific libraries to the test. However, I don't think it's a good idea to overload the LIBS variable for all the functions that are being tested in that sequence. (though that fixed the issue for me) Can someone recommend the right way I should modify configure.ac? Thanks, Ben

2 1

Towards getting the top ten requested apps running...
by Dan Kegel 15 Apr '07

15 Apr '07

Novell did a survey last year to find out what ten apps people most wanted ported to Linux. I've put a copy of the results into our wiki here: http://wiki.winehq.org/LinuxApplicatonRequestSurvey Wine seems far enough along that it's not unreasonable to consider getting all ten of these apps working over the next year. (One of them already works great: Lotus Notes. So that's one down, nine to go...)

4 3

Re: GetDIBits(): Handle Bitfields properly
by Dmitry Timoshkov 15 Apr '07

15 Apr '07

"Michael Kaufmann" <hallo(a)michael-kaufmann.ch> wrote: > + if (bpp > 0 && compr == BI_BITFIELDS) > + { > + /* Windows ignores the input bitfields and overwrites them */ > + > + if (bpp == 16) > + { > + /* With these bitfields, the color data is the same as for BI_RGB */ > + ((PDWORD)info->bmiColors)[0] = 0x7c00; > + ((PDWORD)info->bmiColors)[1] = 0x03e0; > + ((PDWORD)info->bmiColors)[2] = 0x001f; > + } > + else if (bpp == 32) > + { > + /* With these bitfields, the color data is the same as for BI_RGB */ > + ((PDWORD)info->bmiColors)[0] = 0xff0000; > + ((PDWORD)info->bmiColors)[1] = 0x00ff00; > + ((PDWORD)info->bmiColors)[2] = 0x0000ff; > + } What happens in 15 and 24 bpp cases? -- Dmitry.

2 2

Re: RegDeleteTree
by Detlef Riekenberg 15 Apr '07

15 Apr '07

On So, 2007-04-15 at 10:02 +0200, Stefan Leichter wrote: I did not test the code, but ... > +LONG WINAPI RegDeleteTreeW(HKEY hKey, LPCWSTR lpszSubKey) > +{ > + if (!ret) > + ret = RegSetValueA(hSubKey, NULL, REG_SZ, "", 0); Please do not call an ANSI-Function in an UNICODE-Implementation. http://wiki.winehq.org/CrossCallsWtoA static const WCHAR emptyW[] = {0}; ret = RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0); Thanks -- By by ... Detlef

1 0

Re: Fwd: fonts borked (in utorrent) between 0.9.34 and 0.9.35
by Scott Ritchie 15 Apr '07

15 Apr '07

On Sat, 2007-04-14 at 16:46 +0200, RusH wrote: > Hi > > ---------- Forwarded message ---------- > From: RusH <citizenr(a)gmail.com> > Date: Apr 14, 2007 1:35 PM > Subject: fonts borked (in utorrent) between 0.9.34 and 0.9.35 > To: wine-devel(a)winehq.org > > > 0.9.34 > http://www.tachypic.com/view/10345 > > 0.9.35 > http://www.tachypic.com/view/10346 > > as you can see vertical text is fixed in 35, but fonts are ugly and > cropped (Done tab), this is with the same wine config, so something > has changed in wine itself, I started a bisect, but it will take >10 > hours on my machine unless someone will point me where to look > specifically. > ----------------------- > > so I did the bisect down to 0.9.34 and blah, whatever I compile has > this font bug, even clean 0.9.34, but 0.9.34 installed from your deb > (im on Feisty, installed from 6.10 repo) does not have the font bug, > so what is going on? are you using magic patches? :P and what have you > changed between 34 and 35? > I honestly don't know what's going on. I build in a clean environment using pbuilder. You might have compiled Wine in a slightly different way than the debs were built. Alternatively, this might be a problem with using the Edgy packages in Feisty. I'll try making proper Feisty packages by tomorrow. Thanks, Scott Ritchie

1 0

Re: Add a stub for CancelDC()
by Dmitry Timoshkov 15 Apr '07

15 Apr '07

"Michael Kaufmann" <hallo(a)michael-kaufmann.ch> wrote: > +BOOL WINAPI CancelDC( HDC hdc ) > +{ > + FIXME( "stub\n" ); > + > + return TRUE; > +} Please use 4-spaces indentation like in the surrounding code. -- Dmitry.

1 0

Re: Ubuntu packages for wine-0.9.35 are broken
by Vitaliy Margolen 15 Apr '07

15 Apr '07

RusH wrote: > On 4/14/07, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: >> I'm getting number of reports on #winehq as well as in bugzilla about >> new Ubuntu packages for 0.9.35 having problems with displaying text and >> mouse cursor. It appears there were some problems with xrandr during >> compiling them. >> >> Scott could you take a look at this and fix them as soon as you can? Or >> at least remove broken packages from the repository? > > broken like this > Message-ID: <3df49b7b0704140435t69dfa6eh5cc43a648ca855f6(a)mail.gmail.com> > ? > Subject: fonts borked (in utorrent) between 0.9.34 and 0.9.35 > Probably. I do not have Ubuntu can't tell exactly. Vitaliy

5 16

Towards getting the top ten requested apps running...
by Maarten Lankhorst 14 Apr '07

14 Apr '07

2007/4/14, Martin Owens <doctormo(a)gmail.com>: > but we have a flash 9 player... > At the time of the survey there wasn't a sign of it. I remember that, flash player has been only added recently. Flash 7.0 was horrible Maarten

3 2

Re: Prepare d3d10's place, set it's version information (try 2)
by Stefan Dösinger 14 Apr '07

14 Apr '07

Am Samstag 14 April 2007 14:21 schrieb Kovács András: > Prepare d3d10's place, set it's version information Note that this patch will fail to compile because wined3d_interfaces.h still needs a structure defined in ddraw.h. This is mainly my fault / laziness from the ddraw merge a year ago. I'll send a patch that removes this dependency on ddraw.h

1 0

dinput: fix mouse jitter in Halo (bug 7640)
by Martin Traverse 14 Apr '07

14 Apr '07

Hello, I have done a bisection on bug #7640, mouse jitter in Halo which rendered the game unplayable. I have a patch which fixes the problem on my Gentoo system against wine-0.9.35. Bug is introduced by commit b22ff8018aca7c365e505f1db7732f7050ae259b dinput: Remove MsgWaitForMultipleObjects call (Note: commit --59b also severely slows dinput response, fixed soon after by commit 685a3e6a6ed623718f640e8906bd44fbca3d8b2c dinput: Release critical section before warping mouse) Bug can be alleviated by reverting the original commit until commit af71538d3343a1cec73e75391a7ebfd5b3ed94ee dinput: Remove duplicate Keyboard->Poll it is the same as base class I put back the specialised version of Poll with MsgWaitForMultipleObjects, which fixed the problem, and have sent a patch. It was only necessary to alter Poll, not GetDeviceState. This is the first time I've sent in a patch, obviously I'm not familiar with the code so I'd be grateful for any comments. Martin.

4 3

Re: D3D: Enumerate Palettized formats for ddraw
by Vitaly Budovski 14 Apr '07

14 Apr '07

Stefan � wrote: > apps. D3D8 is unaffected because it passes WINED3DFMT_UNKNOWN to wined3d. > > Wouldn't it be better to not pass WINED3DFMT_UNKNOWN and then treat it in a special way? I think it would make more sense to just check for the supported formats in D3D8 much like you do for DDRAW now.

2 1

fonts borked (in utorrent) between 0.9.34 and 0.9.35
by RusH 14 Apr '07

14 Apr '07

0.9.34 http://www.tachypic.com/view/10345 0.9.35 http://www.tachypic.com/view/10346 as you can see vertical text is fixed in 35, but fonts are ugly and cropped (Done tab), this is with the same wine config, so something has changed in wine itself, I started a bisect, but it will take >10 hours on my machine unless someone will point me where to look specifically. -- Who logs in to gdm? Not I, said the duck.

1 0

Re: Prepare d3d10's place, set it's version information
by H. Verbeet 14 Apr '07

14 Apr '07

>+#include "ddraw.h" I don't think that's a good idea.

2 1

dinput: fix mouse jitter in Halo (bug 7640)
by Martin Traverse 14 Apr '07

14 Apr '07

Hello, I have done a bisection on bug #7640, mouse jitter in Halo which rendered the game unplayable. I have a patch which fixes the problem on my Gentoo system against wine-0.9.35. Bug is introduced by commit b22ff8018aca7c365e505f1db7732f7050ae259b dinput: Remove MsgWaitForMultipleObjects call (Note: commit --59b also severely slows dinput response, fixed soon after by commit 685a3e6a6ed623718f640e8906bd44fbca3d8b2c dinput: Release critical section before warping mouse) Bug can be alleviated by reverting the original commit until commit af71538d3343a1cec73e75391a7ebfd5b3ed94ee dinput: Remove duplicate Keyboard->Poll it is the same as base class I put back the specialised version of Poll with MsgWaitForMultipleObjects, which fixed the problem, and have sent a patch. It was only necessary to alter Poll, not GetDeviceState. This is the first time I've sent in a patch, obviously I'm not familiar with the code so I'd be grateful for any comments. Martin.

1 0

OpenGL child windows [RFC]
by Roderick Colenbrander 13 Apr '07

13 Apr '07

Hi, This is an updated version of the child window patch from Chris Robinson. I have added some fixes to it which were found by testing it with lots of programs. Windowed OpenGL Several options have been discussed over the years for solving the windowed opengl issues. The lazy option was to use pixmaps but you would lose hardware acceleration. A better way but similar was the use of pbuffers but still they are poorly supported by most drivers (only Nvidia has decent support). One of the most attractive solutions is the use of glScissors/glViewport changes. This path works now if you apply ulrich his latest patch which is in bugzilla (2398). Though for optimal performance you need specific opengl extensions. Second a number of standard opengl calls requires changes and some aren't done yet (glReadPixels and friends) but right now it is one of the best solutions. Another way of solving the windowed opengl problem is by using X child windows for the opengl window. In the end this results in the same as ulrich his glScissor work but with the advantage that it should work fast on all opengl implementations as it doesn't require special extensions. Further it doesn't require the patching of opengl calls. OpenGL pixelformats Next to the windowed opengl issues, there's the pixelformat limitation in Wine. Right now only one pixelformat can be used. Most programs use ChoosePixelFormat using which you can request a pixelformat but the call isn't guaranteed to give you back what you want. For this reason most programs aren't very critical. These days more and more programs are more critical. They use wglChoosePixelFormatARB which does give you what you want or programs enumerate all pixelformats using DescribePixelFormat and choose what they want. Anyway the issue is that the single pixelformat isn't enough anymore. A recent report from WoW on intel drivers is a proof of this http://bugs.winehq.org/show_bug.cgi?id=7866. The game didn't like the single format exported by Wine. Another example is the IKEA kitchen planner tool which uses DescribePixelFormat to enumerate all formats. It expects to find a match in a format. Right now it doesn't find any match and calls SetPixelFormat with iPixelFormat=0 (which is invalid). Like the above two programs there are many other programs with issues due to pixelformats. I believe that perhaps a few of them are fixable (by adding more hacks or by lieing to programs). If we had more pixelformats, I think the issues could be fixed. OpenGL child windows would fix this issue as the child doesn't have to use the same pixelformat as its parent (!). Summary If we would use OpenGL child windows in Wine that would fix most windowed opengl issues and second it would allow us to use more pixelformats as a child window doesn't have to use the same pixelformat as its parent. Patch As mentioned before the patch was mainly made by Chris Robinson and I have added a few fixes to it to make it more compatible. Bascially a child window is allocated for a hdc during SetPixelFormat which needs to be called on every hdc before it can be used with opengl. That's basically the biggest change to the opengl code. For the rest some x11drv calls like SetWindowPos had to be patched in order to move the child window when needed. Below you can find a list of tested programs and the results. As you can see it works correctly for most of the tested programs. Three of the tested programs don't work correctly of which two are not related to the use of child windows, so overall the result is good. I'd like to know of more programs that work / don't work and I like feedback on the patch. Properly working programs: - Blender - Google Earth - Google SketchUp - Lightwave 6 + 9 - MilkShape3D - Terragen + Terragen2 - VLC opengl plugin - Valve Hammer tool - Weatherscope - Q3Radiant Unfixed programs: - Truespace 6.5; The program uses OpenGL for its main window and uses some floating win32 toolbars. The child window obscures them, perhaps the SHAPE extension for X can be of any help here to cut parts away. Other broken apps not child window related: - NWN Model viewer; The program seems to do be using WGL in an illegal way but seems to get away with this without any failures on Windows. I don't know what's going on. It also never worked correctly before when there were X windows. It now behaves the same as before. Using ulrich his patch it works but that's basically an 'accident'. It isn't because the code is fixed. - IKEA kitchen planner; The program uses multiple child windows one for a 3D preview which works fine and it uses one for drawing on a grid. When drawing things on the grid, the objects quickly disappear. There's some buffer swapping issue I guess. The same happens without the child window patch and using ulrich his patch. So the issue is not related to child windows. Regards, Roderick Colenbrander -- "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail

2 2

Re: wined3d: Consolidate all existing enablings of SFLAG_INSYSMEM in surface.c into one easy line
by Stefan Dösinger 13 Apr '07

13 Apr '07

Am Freitag 13 April 2007 00:28 schrieb Phil Costin: > This patch removes the need to manually set SFLAG_INSYSMEM after a call to > surface_download_data. It should be set by the function. - /* Mark the local copy up to date if a full download was done */ - if(This->lockedRect.left == 0 && - This->lockedRect.top == 0 && - This->lockedRect.right == This->currentDesc.Width && - This->lockedRect.bottom == This->currentDesc.Height) { - This->Flags |= SFLAG_INSYSMEM; - } This is not correct. This path is for render target locking, and it does not call surface_download_data, so you can't remove that.

2 1

Re: [2/2] wined3d: Remove usesFog flag from IWineD3DVertexShaderImpl
by Stefan Dösinger 13 Apr '07

13 Apr '07

Am Donnerstag 12 April 2007 19:49 schrieb Fabian Bieler: > Remove the usesFog flag and replace it with a 'method' as suggested by Ivan > Gyurdiev. So I'm ready to start yet another design flamewar here :-) Honestly I do not really agree with getter methods like this inside WineD3D. Yes, they do hide the implementation details, namely how the flag is stored. Yes, they do encapsulate data, like the Object Oriented Programming model says. But honestly, how much use is it to do a function call just to read a value inside wined3d? I don't argue that we should make wined3d internals visible to outside wined3d. But inside wined3d, my personal preference is to just access the implementation structure directly. How much abstraction does such a function give us at the cost of performance? In both cases the state management code has to know an internal of the shader code, wether the shader writes to the fog coordinate. This is something only the shader should need to know, no matter how it is accessed. Why do we need it? Because the way fog works with shaders requires that either the shader sets fog params or the code setting fog params has to know about the shader. We can't change that. There are many more examples like surface sizes in the viewport and SetRenderTarget code, ... ------------- In case of the foggy shader thing, I think we can get rid of that by just setting up the fog start and fog end when a shader is used and fog is on, no matter if the shader actually uses the fog. May even be faster in the end. Other than that, I think that the shader fog code is not quite right either, since if we need the foggy shader setup depends on the fogtablemode setting. But other simmilar cases still remain.

2 2

Re: ole32: Void functions should not return a value
by Robert Shearman 13 Apr '07

13 Apr '07

Andrew Talbot wrote: > diff -urN a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c > --- a/dlls/ole32/rpc.c 2007-03-28 12:43:32.000000000 +0100 > +++ b/dlls/ole32/rpc.c 2007-04-12 20:20:48.000000000 +0100 > @@ -1352,7 +1352,7 @@ > TRACE("ipid = %s, iMethod = %d\n", debugstr_guid(&ipid), msg->ProcNum); > > params = HeapAlloc(GetProcessHeap(), 0, sizeof(*params)); > - if (!params) return RpcRaiseException(E_OUTOFMEMORY); > + if (!params) RpcRaiseException(E_OUTOFMEMORY); > > hr = ipid_get_dispatch_params(&ipid, &apt, &params->stub, &params->chan, > &params->iid, &params->iface); > @@ -1360,7 +1360,7 @@ > { > ERR("no apartment found for ipid %s\n", debugstr_guid(&ipid)); > HeapFree(GetProcessHeap(), 0, params); > - return RpcRaiseException(hr); > + RpcRaiseException(hr); > } > > params->msg = (RPCOLEMESSAGE *)msg; > You've changed the code paths here. -- Rob Shearman

4 4

RE: locales, unicode and ansi with msvcrt (bug 8022)
by Ann & Jason Edmeades 13 Apr '07

13 Apr '07

>What your test app is doing? It probably needs a test under Windows to >see in which encoding (ANSI/OEM) a not unicode app should receive input >via a pipe. Sorry, just realized I had not addressed your last comment - Can you expand on this sample test please and I'll do some experimenting. How do you mean a pipe (just stdin?) and what would this be showing beyond the straight file i/o case (My original test does straight writes to the console, and to a file). Also, for example, any suggestions on how to tell OEM from ANSI, and on telling the codepage used for the conversions. Thanks Jason

2 1

locales, unicode and ansi with msvcrt (bug 8022)
by Kirill K. Smirnov 12 Apr '07

12 Apr '07

Just some thoughts in hope they would help: There is special utility called 'mode' in Windows. I can select output locale: mode con cp prepare ... mode con cp select ... I think it would solve many problems if similiar tool will be implemented in wine. [bug #8022 comment #7] -- Kirill

1 0

Re: [5/5] D3D9: Add a test for the converted vertex decl
by Ivan Gyurdiev 12 Apr '07

12 Apr '07

Looks good, but this comment is misleading - s/"second"/"first". + /* The contents should correspond to the second conversion */ + VDECL_CHECK(compare_elements(result_decl1, test_elements1)); Also, I thought when Henri was testing this that the object kept changing between sequential Get() calls ? Did you mention something about a driver bug causing this ? Ivan

2 1

Re: mshtml #1: Change TRACE to FIXME in stubs.
by Michael Stefaniuc 12 Apr '07

12 Apr '07

Jacek Caban wrote: > <S-Insert> > --- > dlls/mshtml/htmlbody.c | 70 > ++++++++++++++++++++++++------------------------ > 1 files changed, 35 insertions(+), 35 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c > index f8be550..542c989 100644 > --- a/dlls/mshtml/htmlbody.c > +++ b/dlls/mshtml/htmlbody.c > @@ -138,245 +138,245 @@ static HRESULT WINAPI HTMLBodyElement_Invoke(IHTMLBodyElement *iface, DISPID dis > static HRESULT WINAPI HTMLBodyElement_put_background(IHTMLBodyElement *iface, BSTR v) > { > HTMLBodyElement *This = HTMLBODY_THIS(iface); > - TRACE("(%p)->(%s)\n", This, debugstr_w(v)); > + FIXME("(%p)->(%s)\n", This, debugstr_w(v)); It should then include "Stub" in the FIXME message so people know why they get those. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

locales, unicode and ansi with msvcrt (bug 8022)
by Ann & Jason Edmeades 12 Apr '07

12 Apr '07

Hello, Bug 8022 (http://bugs.winehq.org/show_bug.cgi?id=8022) has highlighted something interesting which has me puzzled... Basically lets take xcopy as an example command line application. It issues messages to the screen using MSVCRT's wprintf(L"Unicode string") type function Wprintf -> vsnwprintf and builds a Unicode string to output. This ends up calling fwrite -> _write -> WriteFile -> WriteConsoleA Since an ANSI function gets called, the string gets converted into Unicode again (it was Unicode, so now ifs char with 3 0x00's!) and it comes out garbled. This garbage is only visible with e.g. "wineconsole --backend=user wine cmd /K xcopy", and non-wineconsole modes the extra 0x00's seem to do no harm, but they are there (try sending wine xcopy >a.a 2>&2 then vi a.a). So it looks like the problem is we shouldn't call fwrite from a Unicode msvcrt function. However, references like: http://groups.google.co.uk/group/comp.os.ms-windows.programmer.win32/browse_ thread/thread/6c0ecec3ad89d5b9/aa7a8c2085a12aa1?lnk=st&q=fwide+fwrite&rnum=1 0#aa7a8c2085a12aa1 seem to imply MSVCRT only outputs narrow characters. Now I am out of my depth... Should msvcrt be changed so all unicode functions convert to narrow before outputting anything - feels wrong. Ideally I could change the fwrites to WriteConsoleW's, but if the output should be to a file this is wrong. Is the solution to see if it's a console handle and call WriteConsoleW, and if not convert to narrow and then call fwrite, all within the msvcrt layer? Now I know there's much better people here than me who might be able to answer this, so all info welcome! The last of these will easily fit into msvcrt's tests, which I will do, but I'd also like to know how to approach a fix which I can do at the same time.... Jason PS Sample test program for compilation under windows (use /MD) - I can send an exe if anyone wants it... #include <windows.h> #include <stdio.h> void main() { WCHAR buffer[] = L"Hello Jason\n"; DWORD x; FILE *f; // Proves WriteFile outputs as-is WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), buffer, sizeof(buffer), &x, NULL); // Proves msvcrt converts to narrow (send output to file) - fails on wine wprintf(buffer); // File i/o has same problem? (Windows - narrow, Wine - includes nulls) f = _wfopen(L"test", L"w+t"); fwprintf(f, buffer); fclose(f); }

3 4

Wine vs. Cedega in Benchmarks
by Tom Wickline 12 Apr '07

12 Apr '07

Hello All, I have been pondering the thoughts of running every benchmark that I have on Wine, Cedega, XP, and CX to see where we stack up in the performance game. And while doing my daily reading of news sites I came across this posted on /. http://www.phoronix.com/scan.php?page=article&item=681&num=1 Those guys ran 5 game test and Wine's performance is clearly superior to that of Cedega on benchmarks where Wine was run, they give no details of the Wine configuration, So I can only presume it's a default setup. And since there *trying* to paint the best picture possible for Cedega they don't point out that Wine is superior! "It is also important to note that there were minimal performance differences between WINE 0.9.32 and Cedega 6.0. Granted there are only five benchmarks in this Cedega 6.0 performance preview, but the level of performance for Cedega does look extremely promising and we will continue to look at Cedega 6.0 and report back in future articles." Should read : Cedega's performance is currently lagging that of Wine 0.9.32 and with each Wine release Wine's performance and feature set is continuously improving! I'm open for thoughts and suggestions.... -- Tom Wickline Respectable computing - Linux/FOSS

5 11

Re: rpcrt4: Implement RpcMgmtWaitServerListen
by Robert Shearman 12 Apr '07

12 Apr '07

Dan Hipschman wrote: > @@ -94,7 +95,8 @@ struct connection_ops { > RpcConnection *(*alloc)(void); > RPC_STATUS (*open_connection_client)(RpcConnection *conn); > RPC_STATUS (*handoff)(RpcConnection *old_conn, RpcConnection *new_conn); > - int (*read)(RpcConnection *conn, void *buffer, unsigned int len); > + int (*read)(RpcConnection *conn, void *buffer, unsigned int len, BOOL check_stop_event); > + int (*signal_to_stop)(RpcConnection *conn); > int (*write)(RpcConnection *conn, const void *buffer, unsigned int len); > int (*close)(RpcConnection *conn); > size_t (*get_top_of_tower)(unsigned char *tower_data, const char *networkaddr, const char *endpoint); > Hmm, I'm not sure it needs to be this complicated. > HeapFree(GetProcessHeap(), 0, msg); > } > > -static DWORD CALLBACK RPCRT4_worker_thread(LPVOID the_arg) > -{ > - RpcPacket *pkt = the_arg; > - RPCRT4_process_packet(pkt->conn, pkt->hdr, pkt->msg); > - HeapFree(GetProcessHeap(), 0, pkt); > - return 0; > -} > - > static DWORD CALLBACK RPCRT4_io_thread(LPVOID the_arg) > { > RpcConnection* conn = (RpcConnection*)the_arg; > @@ -319,10 +322,14 @@ static DWORD CALLBACK RPCRT4_io_thread(LPVOID the_arg) > RpcBinding *pbind; > RPC_MESSAGE *msg; > RPC_STATUS status; > - RpcPacket *packet; > > TRACE("(%p)\n", conn); > > + EnterCriticalSection(&client_connections_cs); > + list_add_head(&client_connections, &conn->client_entry); > + ResetEvent(clients_completed_event); > + LeaveCriticalSection(&client_connections_cs); > + > for (;;) { > msg = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(RPC_MESSAGE)); > > @@ -338,17 +345,17 @@ static DWORD CALLBACK RPCRT4_io_thread(LPVOID the_arg) > break; > } > > -#if 0 > RPCRT4_process_packet(conn, hdr, msg); > -#else > - packet = HeapAlloc(GetProcessHeap(), 0, sizeof(RpcPacket)); > - packet->conn = conn; > - packet->hdr = hdr; > - packet->msg = msg; > - QueueUserWorkItem(RPCRT4_worker_thread, packet, WT_EXECUTELONGFUNCTION); > -#endif > - msg = NULL; > } > + > + EnterCriticalSection(&client_connections_cs); > + list_remove(&conn->client_entry); > + if (list_empty(&client_connections)) { > + TRACE("last in the list to complete (%p)\n", conn); > + SetEvent(clients_completed_event); > + } > + LeaveCriticalSection(&client_connections_cs); > + > RPCRT4_DestroyConnection(conn); > return 0; > } > I'm not sure your reasoning for doing this. If I'm not mistaken, this change makes it so that only one RPC call at a time is processed. -- Rob Shearman

2 1

Re: wined3d: Mark vertex shader 3.0 as foggy shaders if they write out the fog coord
by Ivan Gyurdiev 12 Apr '07

12 Apr '07

Fabian Bieler wrote: > Vertex shaders are marked as 'foggy shaders' in wined3d if they write out the > fog coord. Previously this was not done for vertex shaders 3.0. This patch > corrects this problem. > Please don't do that - the design is flawed enough as it is (GLSL being invoked from vertexshader and such..). The reg_maps was meant to be: - computed in shader pass 1 [ register tracking ] - used in shader pass 2 [ code generation ]. Here you're doing this: - computing reg_maps at the very end of shader pass 2 [ unpack stage ] - using this right afterwards in the calling function to set yet another flag (This->usesFog). I'm not sure what needs to be done instead, since it all looks so broken... - I would say this type of analysis about shader usage needs to go into pass 1 (baseshader), since it is backend independent. It's kind of vertex-shader specific, but we're trying to merge vertex and pixel shaders, and remove code from these two files, not add more of it. - The usesFog looks like it's trying to persist information about register usage after the shader has been compiled for optimization purposes...except that this information is already persisted - if you look in baseshader, you will see the entire reg_maps structure is kept in there, exactly for that purpose [ was done for software shaders actually, but that never happened ]. - Also, other code outside the shaders should not be accessing these flags directly - there should be a function which looks inside the reg_maps, and code from other file should call that function (we are emulating OOP programming in C, so we should try to use encapsulation). Ivan

2 2

Re: Add Windows Vista option to winecfg
by H. Verbeet 12 Apr '07

12 Apr '07

On 12/04/07, Kovács András <andras(a)csevego.net> wrote: > This patch is needed, because DirectX 10 is Vindows Vista only feature. > You'll need to change more than that, eg. see my attachment to bug 7558. Note that I only guessed the values used in that patch, to make the dx sdk installer happy. They would still have to be verified to be correct on an actual Vista install.

1 1

Patches / a proposal for the mystic DIB engine
by Felix Nawothnig 12 Apr '07

12 Apr '07

Okay, I've spent the last days looking into this matter and I'd like to suggest a way to get it started. So. This is the plan: 1. In winex11.drv: -INT X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL lossy) +HBITMAP X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL force) Lossy isn't used anywhere for LockDIBSection anyway. Force means that the function will only lock if the DIB is already in AppMod. The returned bitmap is ofcourse physDev->bitmap->hbitmap. Rationale: If you lock the DIB to write on it it makes sense that the function actually provides you with that DIB. 2. Export LockDIBSection/Unlock to gdi32. Adding more exports is not nice but there really is no way around that, right? 3. Move dc->funcs to dc->physDev->funcs. Many changes but mostly mechanical work. Rationale: This really belongs there. And I need it. :) 4. Now we write dibdrv.c for now just containing DIBDRV_Install and DIBDRV_Remove. That function will go through the physDev->funcs list and overwrite each function pointer which is actually implemented with DIBDRV_PutPixel(), whatever. DIBDRV_Install/DIBDRV_Remove will be called from BITMAP_SelectObject() when we switch from non-DIB to DIB vice versa. Note that we can't use DRIVER_load_driver here because of the wanted "forward to original driver when not implemented". For this we will need to extend the "for DIB objects" part in BITMAPOBJ by const DC_FUNCTIONS *orig_funcs; DC_FUNCTIONS local_funcs; where orig_funcs to the old physDev->funcs and the new physDev->funcs points to &bmp->local_funcs. 5. In dibdrv.c we get us: enum { DIBDRV_MIXED, /* Choose driver depending on current AppMod */ DIBDRV_ALWAYS, /* Always use DIBDRV (unless function not implemented) */ DIBDRV_NEVER /* Always use DC driver */ } DIB_Mode = DIBDRV_MIXED; and DIB_Lock(PHYSDEV physDev) / DIB_Unlock(PHYSDEV). Now, here comes the reason we need the HBITMAP from LockDIBSection() and funcs inside PHYSDEV: Since we don't have the DC here we have no way of calling LockDIBSection(), forwarding to the original driver if NEVER/MIXED or writing to the actual DIB in case of MIXED/ALWAYS. 6. From this point we can start implementing one function at a time, touching nothing but dibdrv.c. So far so good. I did all those steps (except 3., I hacked around that in my local tree) in a clean way and it works nice (for 6. I implemented SetPixel() and tried that with a test-app). I attached patches for the steps 1 2 and 4 so you can see where this is going. Comments? Felix

7 9

Questions about using native vs implementing our own
by Tom Spear 12 Apr '07

12 Apr '07

Hi again all, before I go and file another needless bug, I thought I would ask for opinions. I decided to try to run Process Explorer today with wine. When I first ran it, I got a dialog about missing a function. So I looked back thru the traces and it was because we were missing acledit.dll.. So I imported that from my windows xp install, and got the dialog again. Turned out I was also missing netui0.dll, netui1.dll, and netui2.dll and those in turn needed netrap.dll and samlib.dll. Once I got all of those imported from XP, Process Explorer now runs beautifully. I looked at the version information, and here is the description of each dll acledit is an access control list editor netui0 is NT LM UI Common Code - GUI Classes netui1 is NT LM UI Common Code - Networking classes netui2 is NT LM UI Common Code - GUI Classes netrap is Net Remote Admin Protocol DLL and samlib is SAM Library DLL I assume SAM is the Security Accounts Manager service, so that last dll would go for that and most likely would never be implemented with wine. But, how about the others? Is doing one of these something possibly feasible for a SoC project? I'm sure that there are other projects that use these dll's as well, but I dont know of them.. My biggest question is when is it appropriate for us to build our own DLL's vs just saying to use native? I would personally like to at least see the NTLM stuff get built since I know one of the developers is working on NTLM right now Also, should I file a bug for Process Explorer needing native dll's, or should I maybe file a bug to build our own versions of these dll's, OR should I just leave it alone altogether? I am creating an AppDB page for the program now. Does anyone object to me putting notes about which native dll's are needed on that page? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

6 10

Windows dll as Linux Shared Object
by Phil Lodwick 12 Apr '07

12 Apr '07

Greetings, My googling skills are letting me down today. I believe I have seen several people requesting to do the same and answers indicating it is possible. However, after several hours of reading email archives from 2000-2007 are am officially confused :-( I have successfully ported an application using winelib. However, what I really want to do is port a DLL to an SO which I can use natively from a Linux application. I believe this is something that can be done with winemaker/winebuild etc if I just get the recipe right -- correct? ie: WindowsDLL.cpp int AndTheAnswerIs() { Return 42; } WindowsDLL.def EXPORTS: AndTheAnswerIs Use winemaker/winebuild to create WindowsDLL.dll.so Linux.cpp: main() { printf("AndTheAnswerIs: %d\n", AndTheAnswerIs()); } g++ linux.cpp -lWindowsDLL Is this possible, or am I missing something? Thanks much! Phil

3 5

Re: Add Windows Vista option to winecfg
by Felix Nawothnig 12 Apr '07

12 Apr '07

Kovács András wrote: > This patch is needed, because DirectX 10 is Vindows Vista only feature. Nothing wrong with adding Vista to the list but how is this needed? You don't want to disallow usage of dx10 unless Vista is selected, do you? Felix

2 1

How come individual applications can't be put on a virtual desktop in winecfg?
by Scott Ritchie 12 Apr '07

12 Apr '07

I have a single, very old application that needs to run in Windows 98 mode with a 640x480 virtual desktop. But, I'd like to run other applications at the same time. How come I can't set winecfg to make a virtual desktop for just this application, and handle everything else in the window manager? Thanks, Scott Ritchie

5 7

Re: [winealsa] add support for mixer devices
by Dmitry Timoshkov 12 Apr '07

12 Apr '07

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > +/************************************************************************** > + * mxdMessage (WINEALSA.3) > + */ > +DWORD WINAPI ALSA_mxdMessage(UINT wDevID, UINT wMsg, DWORD dwUser, > + DWORD dwParam1, DWORD dwParam2) It would be nice when adding new code make it 64-bit safe from the start, in this case using a proper DRVCALLBACK prototype for the driver callback, and using proper data types for passing in/out parameters around. -- Dmitry.

2 1

Cast-Qual warnings
by Mike Schaadt 12 Apr '07

12 Apr '07

I've been seeing a lot of work done on fixing these warnings, so I thought I would rerun the check and see how many warnings appear(ignoring the ones caused by unicode.h of course). The results are in. Total number of warnings in make depend: 0 Total number of warnings in make from .h files: 0 Total number of warnings in make from .c files: 664 I've included the file with all of the warnings in this post. Any thoughts? Should I bother to keep creating updates like this? What ones can we mark as required? What ones can we mark as should be fixed?

1 0

re: Questions about using native vs implementing our own
by Dan Kegel 11 Apr '07

11 Apr '07

Alexander Sørnes wrote: >> > No, if native dlls are required then it's very helpful for users to know >> > which ones, and it's even better if you provide download links to these >> > dlls, by using sites such as www.dll-files.com or www.dll-downloads.com, >> > or uploading your own somewhere. >> >> Helpful and better yes, but legal? > >I think so, because you are only linking to another webpage, and it is that >webpage's responsibility to make sure the contents are legal. I disagree. The Wine project has to avoid even the appearance of impropriety. I would discourage linking to any questionable download sites for Microsoft files. dll-files.com and dll-downloads.com seem like bad places to link, as they are clearly not obeying Microsoft's EULA. Examples of ok sites include microsoft.com, tucows.com, and fileplanet.com. It's probably best to only link to download sites in the US/UK/EU area, too, as an extra precaution. - Dan

1 0

Re: Questions about using native vs implementing our own
by Tom Spear 11 Apr '07

11 Apr '07

On 4/11/07, Robert Shearman <rob(a)codeweavers.com> wrote: > They are only required because they are > imported by acledit.dll, as is also samlib.dll. You might want to do a > little debugging next time to see what modules are importing the DLLs. > > The only DLL that is required directly and that needs to be stubbed is > acledit.dll. Thats basically what I said, just in a few more words in my last email.. I did not, however realize that acledit was the only one that needed to be stubbed in order to get the program to pickup the dll. Additional question for sending to the list: Is there a fully stubbed dll in the current tree that I could use as a reference to start a stub for acledit? I'd like to at least see how far I can get with a stubbed dll, and I dont want to take any developers' already small amount of time to ask to make a stub. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 3

www.winehq.org resolves to smth strange.
by Kirill K. Smirnov 11 Apr '07

11 Apr '07

Hi, I've noticed very strange thing today: www.winehq.org resolves to http://searchportal.information.com/index.mas?epl=00630086VFAXVE0DWlgVVRBeV… This site claims to be winehq.org. "Winehq.org - What you need, when you need it" I cannot perform "git fetch"!! Quick workaround I found is to use winehq.com, but how can I explain this to git? Does anybody except me suffer the same mystery thing? Some info (I do not understand everything, but it may be useful): lich@clst:~/wine$ dig www.winehq.org ; <<>> DiG 9.3.1 <<>> www.winehq.org ;; global options: printcmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 54611 ;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 2, ADDITIONAL: 2 ;; QUESTION SECTION: ;www.winehq.org. IN A ;; ANSWER SECTION: www.winehq.org. 94739 IN A 66.151.179.147 ;; AUTHORITY SECTION: winehq.org. 82437 IN NS wine.codeweavers.com. winehq.org. 82437 IN NS foghorn.codeweavers.com. ;; ADDITIONAL SECTION: wine.codeweavers.com. 94780 IN A 209.46.25.134 foghorn.codeweavers.com. 94780 IN A 216.251.189.130 ;; Query time: 18 msec ;; SERVER: 195.19.225.253#53(195.19.225.253) ;; WHEN: Tue Apr 10 22:55:48 2007 ;; MSG SIZE rcvd: 136 lich@clst:~$ nslookup 66.151.179.147 Server: 195.19.225.253 Address: 195.19.225.253#53 ** server can't find 147.179.151.66.in-addr.arpa: NXDOMAIN Thanks in advance, -- Kirill P.S. This message may be posted to wrong list, but it is...

5 4

Old trial versions of Photoshop?
by Dan Kegel 11 Apr '07

11 Apr '07

Adobe only offers trial copies of Photoshop CS2 currently. If you downloaded an older trial copy of Photoshop 7 or CS1, and still have the download around, could you send me the md5sum? Thanks... - Dan

2 6

Contributing money to WINE?
by Frank Russo 11 Apr '07

11 Apr '07

As a WINE user, I find myself in a (seemingly) unique situation. I'll do my best to explain my motivations, and what resources are at my disposal. Basically, I would like to give money to the WINE project. I'm a home linux user, and a techops RHEL admin at work. I have no need for windows, MS Office, or other high priority applications. I do play Guild Wars and Eve Online and have been fairly active on AppDB and bugzilla. I have no desire to write and contribute code to the project, as I would like to spend my home time playing Games and avoiding development work. Untill just recently, I was a Transgaming subscriber. I canceled my account the day that the 32-bit cursor patch went into WINE git. I would like to take the money that I had reserved for transgaming and donate it to the WINE project. Herein lies the dilemma. Looking at the contributions page, I am confronted by the following: Wine Party Fund: The purpose of the Wine Party Fund is to show appreciation to Wine developers by collecting funds for developer meetings, such as future Wine Conferences, or in some cases to purchase documentation. That's fine and all, but I am looking for a way to contribute to the actual development (and only development). If I wanted to buy someone beer, it would be an attractive woman (If Alexandre is a unisex/woman's name, I sincerely appologize). Having been to a number of conferences, they don't stirke me as being of much value. I want to pay for a developer, or rather his/her development time. This brings me to Codeweavers and Transgaming. As far as I can tell, TG deosn't really give a whole heck of a lot back to the WINE project. Purchasing a TG subscription really is not in anyone's best interests. However, Codeweavers appears to do a whole lot. The only problem is that I have no interest in their product, and purchasing it only funds WINE development indirectly/partially. I also don't like their pricing model, since they require up-front payment for a product I won't ever use. I would love to see WINE adopt a payment system like TG. This way I can donate $5 per month, have it go "directly" to WINE development efforts (not beer, parties, conferences, etc), and have it pulled directly from an account that I hold (since I do not use Paypal for numerous reasons). Is this an unreasonable request? Should I just "eat-it" and purchase a personal copy of CXO? I guess I could give it as a gift to a friend or something... I'd love to hear your opinions on the matter. Thank you for your time, Frank Russo

6 6

wine latest packages for feisty
by Philip A. Marshall 11 Apr '07

11 Apr '07

For what it's worth, I added the Edgy wine repository and used the Edgy packages for wine 0.9.34 under Feisty. It seems to work, so I'll probably use the Edgy repository until the Feisty repository starts up.

3 2

Re: www.winehq.org resolves to smth strange.
by Kirill K. Smirnov 11 Apr '07

11 Apr '07

Thanks all, culript is found! My /etc/hosts, /etc/resolv.conf are OK. At last I changed nameserver to the public one (195.242.2.126) and everything began to work! I think someone hijacked DNS in the LAN. What is strange, all other sites except winehq.org I tried worked OK. So I put the issue to winehq. Sorry. > Yikes! That looks quite strange. > > In my paranoia, here is what I did: > > [jwhite] whois winehq.org | grep 'Name Server:' > Name Server:FOGHORN.CODEWEAVERS.COM > Name Server:WINE.CODEWEAVERS.COM > [jwhite] host www.winehq.org wine.codeweavers.com > www.winehq.org A 209.46.25.134 > [jwhite] host www.winehq.org foghorn.codeweavers.com > www.winehq.org A 209.46.25.134 > > That suggests everything is good here. > > But that is still rather freaky; do you suppose someone > is hijacking your DNS records somehow? > > Cheers, > > Jeremy > > Kirill K. Smirnov wrote: > > Hi, > > > > I've noticed very strange thing today: www.winehq.org resolves to > > http://searchportal.information.com/index.mas?epl=00630086VFAXVE0DWlgVVRB > >eVwtAVw5ZB14NW1YMBAhCUVZRWRQbWxBfHwRsXQUNU1oBVFc > > > > This site claims to be winehq.org. > > > > "Winehq.org - What you need, when you need it" > > > > I cannot perform "git fetch"!! > > > > Quick workaround I found is to use winehq.com, but how can I explain this > > to git? > > > > Does anybody except me suffer the same mystery thing? > > Some info (I do not understand everything, but it may be useful): > > lich@clst:~/wine$ dig www.winehq.org > > > > ; <<>> DiG 9.3.1 <<>> www.winehq.org > > ;; global options: printcmd > > ;; Got answer: > > ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 54611 > > ;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 2, ADDITIONAL: 2 > > > > ;; QUESTION SECTION: > > ;www.winehq.org. IN A > > > > ;; ANSWER SECTION: > > www.winehq.org. 94739 IN A 66.151.179.147 > > > > ;; AUTHORITY SECTION: > > winehq.org. 82437 IN NS wine.codeweavers.com. > > winehq.org. 82437 IN NS foghorn.codeweavers.com. > > > > ;; ADDITIONAL SECTION: > > wine.codeweavers.com. 94780 IN A 209.46.25.134 > > foghorn.codeweavers.com. 94780 IN A 216.251.189.130 > > > > ;; Query time: 18 msec > > ;; SERVER: 195.19.225.253#53(195.19.225.253) > > ;; WHEN: Tue Apr 10 22:55:48 2007 > > ;; MSG SIZE rcvd: 136 > > > > lich@clst:~$ nslookup 66.151.179.147 > > Server: 195.19.225.253 > > Address: 195.19.225.253#53 > > > > ** server can't find 147.179.151.66.in-addr.arpa: NXDOMAIN > > > > > > Thanks in advance, > > -- > > Kirill > > > > P.S. This message may be posted to wrong list, but it is...

1 0

re: OpenGL child windows [RFC]
by Dan Kegel 11 Apr '07

11 Apr '07

Say, that post is hard to read at the main archive: http://winehq.org/pipermail/wine-devel/2007-April/055817.html but it's more readable at another archive, http://marc.info/?l=wine-devel&m=117624165731188&w=2

1 0

Is Wine a platform for Codeweaver to make money?! Please help me understand.
by Philip A. Marshall 10 Apr '07

10 Apr '07

While we're on the subject, I've got a question about the situation. I know I can go to Codeweavers and download the source for crossover wine. But, if someone is trying to review codeweavers patches to "fix them up" for wine, that isn't very convenient (I can't imagine a diff of the entire source, or even one file, being useful). I know that a lot of codeweavers patches get submitted to wine, but do ALL of them? Is there a way to access the codeweavers wine development tree? I ask because I've seen people post here "There's a hack in crossover that makes that work, if you want you can clean it up for wine." I'm just curious as to how easy it would actually be to do that.

2 2

SmartBarXP
by Tom Spear 10 Apr '07

10 Apr '07

Hi guys, I'm trying to find the source of a problem in SmartBarXP before I make another bug about that app. Basically, with the default setup has a pane with an advanced system monitor. In that pane is bar graphs for CPU usage, RAM usage, Pagefile usage, HDD usage, and Internet Speed. >From what I can tell, the RAM, RF, HDD, and Internet speed are all correct. However, the CPU usage always sits at 100% (red bars at the top). I want to have a log before I file a bug for the issue, but I'm not sure where to start looking for the issue I am bringing up here.. Any ideas? The app is downloadable from majorgeeks.com, and the direct link to the apps page on there is in bug 8011. Note that the more widespread version is an old beta, and the homepage is down. The current version (the one I am having problems with) is 1.0.2 or so.. I have not used or tested the 0.9 beta version. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

re: www.winehq.org resolves to smth strange.
by Dan Kegel 10 Apr '07

10 Apr '07

Kirill wrote: > I've noticed very strange thing today: www.winehq.org resolves to > http://searchportal.information.com/index.mas?epl=00630086VFAXVE0DWlgVVRBeV… > >This site claims to be winehq.org. > >"Winehq.org - What you need, when you need it" Two ideas. 1. Your ISP or browser has been programmed by your vendor to go to that portal whenever any DNS site can't be resolved, and you had a temporary name lookup problem. 2. Somebody poisoned a DNS cache somewhere. What happens if you go to http://www.nowaythisisvalid.com ?

2 1

Re: err:ddraw:IDirectDrawImpl_QueryInterface (0x1bdd28)
by Klaus Layer 10 Apr '07

10 Apr '07

Am Sonntag, 8. April 2007 12:55 schrieben Sie: > Hi, > Interestingly this application does nothing that would make ddraw return a > failure. Can you send a ddraw,d3d7 trace WITH the registry key set as a > reference? > > As far as I can see, this application is on its way to set up a Direct3D > Device for a surface which does NOT have DDSCAPS_3DDEVICE set - which is not > allowed, as far as I know, but I'd have to test that. But it stops right > before really creating the device by just exiting. Maybe it does not like our > 3DDevice's GUID. > Hi Stefan, attached you find the trace. I am wondering why it so much smaller. I was also able to get a proper callstack of the crash. thanks, Klaus

2 2

Re: [xcopy]New Korean Resource
by Duane Clark 10 Apr '07

10 Apr '07

Hwang YunSong(È²À±¼º) wrote: > Firest release > This might get accepted a little faster if you create them like this: diff -u /dev/null wine/programs/xcopy/Ko.rc > xcopy-ko.diff Of course, you should be in the directory where you have your Wine tree, for that to work. Patches should not be created from within the subdirectory that contains the file being patched.

1 0

wine-patches
by EA Durbin 10 Apr '07

10 Apr '07

Why do the patches I send to wine-patches never show up in the list? Are they being received? _________________________________________________________________ Mortgage rates near historic lows. Refinance $200,000 loan for as low as $771/month* https://www2.nextag.com/goto.jsp?product=100000035&url=%2fst.jsp&tm=y&searc…

3 3

Is Wine a platform for Codeweaver to make money?! Please help me understand.
by Sasan Iman 10 Apr '07

10 Apr '07

First of all, let me say that I am not a developer. But I have been interested in Wine since early 2003. The thing that has always made me scratch my head is that the Windows software that motivates me to install Wine on my linux system (i.e. MS OFfice, etc.) has never worked with wine in a reliable manner. Meanwhile, Codeweaver has always had MS Office working on Wine. Now shouldn't getting the most common windows software working on Wine in an idiot-proof (meaning I can get it to work) manner be the highest priority for Wine developers? Instead, this is left to CodeWeavers and others. I know that if you fiddle around with the stock release long enough you can get MS Office working on Wine as I have on a number of occasions, but shouldn't making this work for everyone be the highest priority for getting Wine to be adopted more widely?! Or is Wine more targeted to gamers which is mostly what I read about on WineHQ? I just can't understand why the more common application are left to a commercial company. My conspiratorial side makes me want to think this is a conspiracy but I am sure there is valid technical and logistical reasons for it so I am asking you guys. Thanks. Sasan

12 20

Re: quartz: Implement IAMFilterData for IFilterMapper
by Robert Shearman 10 Apr '07

10 Apr '07

Chris Robinson wrote: > +static HRESULT WINAPI AMFilterData_CreateFilterData(IAMFilterData* iface, > + REGFILTER2 *prf2, BYTE **pRegFilterData, ULONG *pcb) > +{ > + FilterMapper2Impl *This = impl_from_IAMFilterData(iface); > + int size = sizeof(struct REG_RF); > + unsigned int i; > + struct Vector mainStore = {NULL, 0, 0}; > + struct Vector clsidStore = {NULL, 0, 0}; > + struct REG_RF rrf; > + > + TRACE("(%p/%p)->(%p, %p, %p)\n", This, iface, prf2, pRegFilterData, pcb); > + > + if (prf2->dwVersion != 2) > + { > + FIXME("Filter registry version %d not supported\n", prf2->dwVersion); > + ZeroMemory(prf2, sizeof(*prf2)); > + return E_FAIL; > + } > + > + rrf.dwVersion = prf2->dwVersion; > + rrf.dwMerit = prf2->dwMerit; > + rrf.dwPins = prf2->u.s1.cPins2; > + rrf.dwUnused = 0; > + > You change FM2_WriteFilterData to be more suitable and then you should re-implement AMFilterData_CreateFilterData on top of this, not duplicate all of this code. -- Rob Shearman

1 0

Re: shell32: Since shlwapi imports ole32, there's no point in shell32 delay-importing ole32.
by Dmitry Timoshkov 10 Apr '07

10 Apr '07

"Robert Shearman" <rob(a)codeweavers.com> wrote: > shell32: Since shlwapi imports ole32, there's no point in shell32 delay-importing ole32. shlwapi has ole32 as a delay load, just like a native one does. Native shell32 also has ole32 as a delay loaded dependency. So, we might at least have ole32 as a delay loaded import just for compatibility with native dlls. -- Dmitry.

1 0

Re: [PATCH] handle some failed open conditions.
by Alexandre Julliard 10 Apr '07

10 Apr '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > spotted by Coverity. > > Not all might really happen, but check for it > anyway. I don't think there's much point in the check, but if you do check then you have to report a failure, you can't let the test silently succeed without doing anything. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: SoC Deadline: 07:00 UTC on April 10th
by Dan Kegel 10 Apr '07

10 Apr '07

Detlef wrote: >### >2. Make sure that all the applications that you *really* want have >mentors assigned to them as quickly as possible, certainly no later >than 12 midnight Pacific / 07:00 UTC on April 10th. >### > >Do we have assigned a mentor for all possible slots? I've assigned you one, but Rob and Jacek are still volunteering to mentor proposals that aren't going to be approved, they should pick different proposals asap. And I do think there are two alternate proposals worth funding; they'll see them straight off if they visit the list of proposals in the web app. - Dan

1 1

Re: respect unicode _ILCreateFromFindData
by Dmitry Timoshkov 10 Apr '07

10 Apr '07

"Aric Stewart" <aric(a)codeweavers.com> wrote: > + if (fs) > + { > + FileTimeToDosDateTime( &(stffile->ftLastWriteTime), > + &fs->uFileDate, &fs->uFileTime); > + fs->dwFileSize = stffile->nFileSizeLow; > + fs->uFileAttribs = (WORD)stffile->dwFileAttributes; > + > + memcpy(fs->szNames, name_buff, name_len); > + TRACE("-- Set Value: %s\n",debugstr_a(fs->szNames)); > + } Indentation above is not consistent. > LPITEMIDLIST _ILCreateFromFindDataW( WIN32_FIND_DATAW *wfd ) > { > - /* FIXME: should make unicode PIDLs */ > - WIN32_FIND_DATAA fda; > + char buff[MAX_PATH + 14 +1]; /* see WIN32_FIND_DATA */ > + char * pbuff = buff; > + size_t len, len1, wlen, alen; > + LPITEMIDLIST pidl; > + PIDLTYPE type; > + > + if (!wfd) > + return NULL; > + > + TRACE("(%s, %s)\n",debugstr_w(wfd->cAlternateFileName), debugstr_w(wfd->cFileName)); > + > + /* prepare buffer with both names */ > + len = WideCharToMultiByte(CP_ACP,0,wfd->cFileName,-1,NULL,0,NULL,NULL) + 1; > + WideCharToMultiByte(CP_ACP,0,wfd->cFileName,-1, pbuff, len, NULL, NULL); > + pbuff += len; Looks like 2 WideCharToMultiByte calls can be replaced by 1. > + > + len1 = WideCharToMultiByte(CP_ACP,0,wfd->cAlternateFileName,-1, NULL, 0, NULL, NULL) +1; > + WideCharToMultiByte(CP_ACP,0,wfd->cAlternateFileName,-1, pbuff, len1, NULL, NULL); > + alen = len + len1; Same here. > + > + type = (wfd->dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) ? PT_FOLDER : PT_VALUE; > + > + /* > + * FileStruct already has one byte for the first name, so use len - 1 in > + * size calculation > + */ > + wlen = lstrlenW(wfd->cFileName); > + pidl = _ILAlloc(type, sizeof(FileStruct) + (alen - 1) + (alen & 0x1) + > + sizeof(FileStructW) + wlen * sizeof(WCHAR) + sizeof(WORD)) ; What (alen & 0x1) is for? -- Dmitry.

2 1

configure using deprecated alsa header.. ?
by Tom Spear 10 Apr '07

10 Apr '07

I just downloaded and configured wine 0.9.34 and looking thru the config.log (didnt do this on prior versions, so I'm pretty sure it's not a regression), there is a warning about needing to use alsa/asoundlib.h instead of sys/asoundlib.h .. I made bug 7997 about it: http://bugs.winehq.org/show_bug.cgi?id=7997 Could someone look into this and make a patch? I honestly dont know if it is causing any problems the way it is currently, but the warning is a little unsettling. In case it's needed: Slackware x86 11.0 with the alsa that is included with the distro. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 3

Winehq's wiki table problem
by Vitaliy Margolen 09 Apr '07

09 Apr '07

Please whomever it is responsible for the WineHQ's wiki. Can you provide more information so I can refile the bug: - !MoinMoin Version - OS and Version - Python Version - Server Setup - Server Details Of course you are welcome to file the bug yourself since you will have all the information available to do so. I can not figure out how to fix all this nasty alignment problem on _all_ the pages with the tables. Am I doing something wrong? Is that my browser broke? Does anyone else see the problem with the tables not aligned properly? Vitaliy

3 2

err:ddraw:IDirectDrawImpl_QueryInterface (0x1bdd28)
by Klaus Layer 09 Apr '07

09 Apr '07

Hi all, when running an educational game, wine crashed and asked me to contact wine-devel. Below is the post mortem trace. Can anyone give me a hint what can be done? Thanks for your help. Best regards, Klaus xxx@yyy:~/make/wine/loader$ ./wine "C:\CSoft\Matheland2\Mathe2.exe" ALSA lib seq_hw.c:456:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory fixme:d3d:IWineD3DImpl_FillGLCaps >>>>>>>>>>>>>>>>> 0x501 from extension detection @ directx.c / 825 fixme:d3d:IWineD3DDeviceImpl_GetAvailableTextureMem (0x1be928) : stub, simulating 64MB for now, returning 64MB fixme:ddraw:IDirectDrawImpl_SetCooperativeLevel (0x1bdd28)->(0x10026,00000011) fixme:xrandr:X11DRV_XRandR_SetCurrentMode Cannot change screen BPP from 32 to 8 err:ddraw:IDirectDrawImpl_QueryInterface (0x1bdd28) The App is requesting a D3D device, but a non-OpenGL surface type was choosen. Prepare for trouble! err:ddraw:IDirectDrawImpl_QueryInterface (0x1bdd28) You may want to contact wine-devel for help fixme:d3d:IWineD3DImpl_FillGLCaps >>>>>>>>>>>>>>>>> 0x501 from extension detection @ directx.c / 825 fixme:ddraw:IDirectDrawImpl_SetCooperativeLevel (0x1bdd28)->((nil),00000008) fixme:d3d:IWineD3DStateBlockImpl_Release Releasing primary stateblock xxx@yyy:~/make/wine/loader$

3 8

SoC Deadline: 07:00 UTC on April 10th
by Detlef Riekenberg 09 Apr '07

09 Apr '07

### 2. Make sure that all the applications that you *really* want have mentors assigned to them as quickly as possible, certainly no later than 12 midnight Pacific / 07:00 UTC on April 10th. ### Do we have assigned a mentor for all possible slots? -- By by ... Detlef

1 0

Changing debug channels on the fly
by Dan Kegel 09 Apr '07

09 Apr '07

It looks like programs/taskmgr/taskmgr used to let you edit debug channels for any process, but now that function seems broken; when I right-click on a process and select 'edit debug channels', I get column headers Debug Channel Fixme Err Warn Trace but nothing under them. Is this supposed to work? In the meantime, I'll make do with http://wiki.winehq.org/Debug_trace_toggle_key which is kind of what I was looking for anyway.

5 7

RFC - winecfg audio test
by Steven Edwards 09 Apr '07

09 Apr '07

Hi, Well it more of a request for adoption than an RFC..... If someone else wants to pick this up feel free. I am kind of blocked on time. Over the course of the past year the discussion about need for an audio test has come up from time to time. Using a WAV file with PlaySound is too massive due to using embedded resources so next we looked at using an embedded mp3 and the wineacm codec. This would be interesting because then we could have something like the sound of a wine bottle being popped or wine being poured but Alexandre said he would rather have a simple test so I elected to rip Francois winmm audio test as a base. As for where to take it from here I am kind of at a loss. The more and more I think about it there could be even better ways to test audio by using DirectSound to generate a set of tones if thats even possible. It would be cool if it was because then we could do a series of tests like a short tone testing WinMM then another short tone testing DirectSound. This might help users that have choppy sound or missing sound in games but not in other apps. Also how to handle the case where it does not work is rather interesting as right now my little messagebox does nothing, but if we implement the help system Jacek suggested we could provide information on how to debug sound problems linked from the dialog. Last but not least this sound is kind of boring so someone else that understands this code better can add some sort of modulation to the tone to make it more appeling. If it was writting in Qbasic I could have pulled it off but as it stands this is the best your going to get from me. I learned a good bit over the 8 or 10 hours it took me to strip it down so its not a total loss even if its rejected. If no one else wants to work on this and Alexandre does not hate it then I will submit to wine-patches on Monday sans DEBUGING enabled in a proper git diff. Peace -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

2 1

Richedit URL hyperlink bug
by Andrew Talbot 09 Apr '07

09 Apr '07

Hi, I run an app (Blitzin2) that displays scrolling text with various highlightings in a rich edit control. When displaying hyperlinks comprising normal words, they are rendered in blue and underlined, and whatever follows is rendered appropriately. However, if the displayed link text happens to constitute a URL, the blue-underlining doesn't get switched off at the end of the link, so all subsequent text is rendered in blue and underlined. Examples: This is a _link_ to somewhere. (This renders fine.) Visit _www.winehq.org_ to learn about a great piece of software. (This stays blue-underlined after the link.) I thought I would post this here first, in case anyone "knows exactly where that is". Thanks, -- Andy.

2 1

A Study on Free/Open Source Software Defect Management
by Anu Gupta DCSA 09 Apr '07

09 Apr '07

Dear Wine Contributots, I am really thankful to Free/Open Source Software development community for their overwhelming response to the survey on practices and problems of defect management in Free/Open Source Software projects. The Online Questionnaire is available at: http://anu.puchd.ac.in/phpESP/public/survey.php?name=FOSS_Defect_Survey I hope you have found all the questions interesting and thought-provoking. Your answers will be kept anonymous.The data thus collected will only be used for research purpose. The insights gained from the study can further help us to extract publicly accessible defect data and determine impact of defect management practices on software quality. The results of study will soon be communicated to you.If you have not participated ealier, you may spend a few minutes now too. Thank You With regards, Anu Gupta Senior Lecturer Department of Computer Science and Applications, Panjab University, Chandigarh. INDIA In case of any problem in accessing/using the above mentioned link please contact: E-mail: anugupta(a)pu.ac.in anugupta98(a)gmail.com

1 0

Re: [06/10] wined3d: Use the framebuffer blit extension to implement StretchRect
by Mirek 09 Apr '07

09 Apr '07

Hi, I can't compile wine with this patch. Here is error log: device.c: In function ‘stretch_rect_fbo’: device.c:5311: error: ‘WineD3D_GL_Info’ has no member named ‘glBlitFramebufferEXT’ device.c:5314: error: ‘WineD3D_GL_Info’ has no member named ‘glBlitFramebufferEXT’ make[2]: *** [device.o] Error 1 make[2]: Leaving directory `/root/.WineCVS/sources/cvswine/wine/dlls/wined3d' make[1]: *** [wined3d] Error 2 make[1]: *** Waiting for unfinished jobs.... Mirek H. Verbeet napsal(a): > Although this patch is somewhat similar to Fabian's, it's not actually > based on it. > > Changelog: > - Use the framebuffer blit extension to implement StretchRect > > > ------------------------------------------------------------------------ > > --- > > dlls/wined3d/device.c | 77 ++++++++++++++++++++++++++++++++++++++++ > dlls/wined3d/surface.c | 12 ++++-- > dlls/wined3d/wined3d_private.h | 5 +++ > 3 files changed, 90 insertions(+), 4 deletions(-) > > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index 506b61c..580fcd0 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -181,6 +181,12 @@ static ULONG WINAPI IWineD3DDeviceImpl_Release(IWineD3DDevice *iface) { > if (This->fbo) { > GL_EXTCALL(glDeleteFramebuffersEXT(1, &This->fbo)); > } > + if (This->src_fbo) { > + GL_EXTCALL(glDeleteFramebuffersEXT(1, &This->src_fbo)); > + } > + if (This->dst_fbo) { > + GL_EXTCALL(glDeleteFramebuffersEXT(1, &This->dst_fbo)); > + } > > HeapFree(GetProcessHeap(), 0, This->render_targets); > HeapFree(GetProcessHeap(), 0, This->fbo_color_attachments); > @@ -5242,6 +5248,77 @@ void apply_fbo_state(IWineD3DDevice *iface) { > check_fbo_status(iface); > } > > +static BOOL is_onscreen(IWineD3DSurface *target) { > + HRESULT hr; > + void *tmp; > + > + hr = IWineD3DSurface_GetContainer(target, &IID_IWineD3DSwapChain, &tmp); > + if (SUCCEEDED(hr)) { > + IWineD3DSwapChain_Release((IUnknown *)tmp); > + return TRUE; > + } > + > + return FALSE; > +} > + > +void stretch_rect_fbo(IWineD3DDevice *iface, IWineD3DSurface *src_surface, const WINED3DRECT *src_rect, > + IWineD3DSurface *dst_surface, const WINED3DRECT *dst_rect, const WINED3DTEXTUREFILTERTYPE filter, BOOL flip) { > + IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > + GLbitfield mask = GL_COLOR_BUFFER_BIT; /* TODO: Support blitting depth/stencil surfaces */ > + GLenum gl_filter; > + > + TRACE("(%p) : src_surface %p, src_rect %p, dst_surface %p, dst_rect %p, filter %s (0x%08x)\n", > + This, src_surface, src_rect, dst_surface, dst_rect, debug_d3dtexturefiltertype(filter), filter); > + > + switch (filter) { > + case WINED3DTEXF_LINEAR: > + gl_filter = GL_LINEAR; > + break; > + > + default: > + FIXME("Unsupported filter mode %s (0x%08x)\n", debug_d3dtexturefiltertype(filter), filter); > + case WINED3DTEXF_NONE: > + case WINED3DTEXF_POINT: > + gl_filter = GL_NEAREST; > + break; > + } > + > + /* Attach src surface to src fbo */ > + if (is_onscreen(src_surface)) { > + GL_EXTCALL(glBindFramebufferEXT(GL_READ_FRAMEBUFFER_EXT, 0)); > + flip = !flip; > + } else { > + IWineD3DSurface_PreLoad(src_surface); > + bind_fbo(iface, GL_READ_FRAMEBUFFER_EXT, &This->src_fbo); > + attach_surface_fbo(This, GL_READ_FRAMEBUFFER_EXT, 0, src_surface); > + } > + > + /* Attach dst surface to dst fbo */ > + if (is_onscreen(dst_surface)) { > + GL_EXTCALL(glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, 0)); > + flip = !flip; > + } else { > + IWineD3DSurface_PreLoad(dst_surface); > + bind_fbo(iface, GL_DRAW_FRAMEBUFFER_EXT, &This->dst_fbo); > + attach_surface_fbo(This, GL_DRAW_FRAMEBUFFER_EXT, 0, dst_surface); > + } > + > + if (flip) { > + GL_EXTCALL(glBlitFramebufferEXT(src_rect->x1, src_rect->y1, src_rect->x2, src_rect->y2, > + dst_rect->x1, dst_rect->y2, dst_rect->x2, dst_rect->y1, mask, gl_filter)); > + } else { > + GL_EXTCALL(glBlitFramebufferEXT(src_rect->x1, src_rect->y1, src_rect->x2, src_rect->y2, > + dst_rect->x1, dst_rect->y1, dst_rect->x2, dst_rect->y2, mask, gl_filter)); > + } > + > + if (This->render_offscreen) { > + bind_fbo(iface, GL_FRAMEBUFFER_EXT, &This->fbo); > + } else { > + GL_EXTCALL(glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, 0)); > + checkGLcall("glBindFramebuffer()"); > + } > +} > + > static HRESULT WINAPI IWineD3DDeviceImpl_SetRenderTarget(IWineD3DDevice *iface, DWORD RenderTargetIndex, IWineD3DSurface *pRenderTarget) { > IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; > WINED3DVIEWPORT viewport; > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 8b7b47d..5db1aa0 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -2752,8 +2752,7 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, RECT * > } > > /* Blt is a pretty powerful call, while glCopyTexSubImage2D is not. glCopyTexSubImage cannot > - * flip the image nor scale it. If GL_EXT_framebuffer_blit is available it can be used(hopefully, > - * not implemented by now). Otherwise: > + * flip the image nor scale it. > * > * -> If the app asks for a unscaled, upside down copy, just perform one glCopyTexSubImage2D call > * -> If the app wants a image width an unscaled width, copy it line per line > @@ -2762,9 +2761,14 @@ static HRESULT IWineD3DSurfaceImpl_BltOverride(IWineD3DSurfaceImpl *This, RECT * > * back buffer. This is slower than reading line per line, thus not used for flipping > * -> If the app wants a scaled image with a dest rect that is bigger than the fb, it has to be copied > * pixel by pixel > + * > + * If EXT_framebuffer_blit is supported that can be used instead. Note that EXT_framebuffer_blit implies > + * FBO support, so it doesn't really make sense to try and make it work with different offscreen rendering > + * backends. > */ > - if(FALSE /* GL_SUPPORT(EXT_FRAMEBUFFER_BLIT) */) { > - TRACE("Using GL_EXT_framebuffer_blit for copying\n"); > + if (wined3d_settings.offscreen_rendering_mode == ORM_FBO && GL_SUPPORT(EXT_FRAMEBUFFER_BLIT)) { > + stretch_rect_fbo((IWineD3DDevice *)myDevice, SrcSurface, &srect, > + (IWineD3DSurface *)This, &rect, Filter, upsideDown); > } else if((!stretchx) || rect.x2 - rect.x1 > Src->currentDesc.Width || > rect.y2 - rect.y1 > Src->currentDesc.Height) { > TRACE("No stretching in x direction, using direct framebuffer -> texture copy\n"); > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index 65cd345..d0da532 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -674,6 +674,8 @@ struct IWineD3DDeviceImpl > BOOL render_offscreen; > WINED3D_DEPTHCOPYSTATE depth_copy_state; > GLuint fbo; > + GLuint src_fbo; > + GLuint dst_fbo; > GLenum *draw_buffers; > > /* Cursor management */ > @@ -1969,4 +1971,7 @@ static inline BOOL use_ps(IWineD3DDeviceImpl *device) { > && ((IWineD3DPixelShaderImpl *)device->stateBlock->pixelShader)->baseShader.function); > } > > +void stretch_rect_fbo(IWineD3DDevice *iface, IWineD3DSurface *src_surface, const WINED3DRECT *src_rect, > + IWineD3DSurface *dst_surface, const WINED3DRECT *dst_rect, WINED3DTEXTUREFILTERTYPE filter, BOOL flip); > + > #endif > > > ------------------------------------------------------------------------ > >

2 1

Re: [01/10] wined3d: Handle FBO attachments slightly more efficiently
by Stefan Dösinger 09 Apr '07

09 Apr '07

Am Montag 09 April 2007 01:53 schrieb H. Verbeet: > The idea here is to only update FBO attachments when the FBO is being > used to draw to, since apparently binding an incomplete FBO is rather > slow. > > Changelog: > - Handle FBO attachments slightly more efficiently Is there a reason why you do not do that in ActivateContext? Without that, you will have to take care of things like Clearing, Locking, Blits, etc.

2 2

Advice on how to proceed - XKB keyboard handling
by Shachar Shemesh 09 Apr '07

09 Apr '07

Hi all, I put up an intermediate version of my XKB patch. It is the last attachment for bug #735 (http://bugs.winehq.org/show_bug.cgi?id=735). The patch, as is, solves bug 735, as can be tested by compiling the test program. However, it does not play well with other areas of the keyboard handling. I'm posting this here partly to draw attention for those who need bug #735 fixed and can live with the regression, and partly to get feedback on how best to proceed. Thanks, Shachar

1 0

wine latest packages for feisty
by Vijay Kiran Kamuju 08 Apr '07

08 Apr '07

Hi, Wherr can I get the 0.9.34 wine built for ubuntu feisty. I am currently using ubuntu's 0.9.33, they havent updated it (Idont they will update it as they are in rc1 freeze). Thanks, VJ

2 4

Any news on hiweedlayer?
by Stefan Dösinger 08 Apr '07

08 Apr '07

Hi, I was wondering if there was any news on this hiweedlayer program which was discussed earlier and turned out to be just a packed up wine archive? Dan said he was in contact with them. Has there been any outcome yet? Cheers, Stefan

2 1

Re: Is Wine a platform for Codeweaver to make money?! Please help me understand.
by Remco 08 Apr '07

08 Apr '07

Just an idea here from a non-developer... Maybe bug reports could be automated in such a way that all fixme's and err's are stored in a file, and that file gets sent to Wine's bugzilla in intervals. Then it is automatically analysed and split up by DLL. That would make it the task of the developers to force Wine to spit out errors with every little thing that could go wrong. But if that would be done right, every error would be reported. Of course there would have to be a popup asking if the bug report may be sent. ____________________________________________________________________________________ Sucker-punch spam with award-winning protection. Try the free Yahoo! Mail Beta. http://advision.webevents.yahoo.com/mailbeta/features_spam.html

3 2

Why double translation on keydown?
by Shachar Shemesh 08 Apr '07

08 Apr '07

Hi all, The current code for keyboard translation goes something like this, if I understood it correctly: * An X11 event arrives with the physical keycode for the key pressed. * Said code is translated into a VKey based on the current keyboard (fair enough) * Keycode is translated into a, well, keycode for Windows. 99% of the cases this is the same one, as it's the same PC keyboard as ever. * The vkey and translated keycode are sent as WM_KEYDOWN or WM_SYSKEYDOWN events. * In all probability, the process calls TranslateMessage * TranslateMessage calls (indirectly) X11DRV_ToUnicodeEx * X11DRV_ToUnicodeEx takes the virtual key, looks it up (using a for loop!!!!) in the same table consulted before to find out what the original X11 keycode was. * That vkey is passed, after some manipulation, to XKeysymToKeycode to produce a keycode * Said keycode is passed to XLookupString to get an actual key for it This process seems, to me, overly long and inefficient. It requires building fairly complex lookup tables for both vkey and Windows keycode. I fail to see what is gained. Why not use the following process instead: * An X11 event arrives * Use the native keycode as the keycode. * Translate the vkey as before. * Send WM_(SYS)KEYDOWN as before * In X11DRV_ToUnicodeEx: * Use the keycode to lookup with key using XLookupString I fail to see why the forward and backwards translation is good for. Explanation? Shachar

2 3

Re: wined3d: Preload target in ActivateContext() for ORM_BACKBUFFER
by Stefan Dösinger 08 Apr '07

08 Apr '07

Am Sonntag 08 April 2007 00:14 schrieb Felix Nawothnig: > --- > dlls/wined3d/context.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) You also have to do that for backbuffer

3 2

Re: wined3d: Allow np2 textures to be loaded for SFLAG_INDRAWABLE
by H. Verbeet 07 Apr '07

07 Apr '07

On 07/04/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > --- > dlls/wined3d/surface.c | 22 +++++++++++----------- > 1 files changed, 11 insertions(+), 11 deletions(-) > Why did you move d3dfmt_get_conv? I'm not too sure about always respecifying the texture.

1 1

Re: [1/8] regedit: Remove the _stscanf function dependency.
by Alexandre Julliard 07 Apr '07

07 Apr '07

Byeong-Sik Jeon <wjsqudtlr(a)gmail.com> writes: > _stscanf depends tchar.h > > Changelog: > Remove the _stscanf function dependency. You are going about this the wrong way. What you should do is convert the code to use explicit Unicode functions. Removing TCHAR and the like will then be an automatic consequence of that conversion. If you try to remove tchar.h first you only add more complexity that would have to be undone later. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3d8: Void functions should not return a value
by Eric Pouech 07 Apr '07

07 Apr '07

Andrew Talbot a écrit : > These functions are correctly declared to return nothing, so that's what they > should do. > > -- Andy. > --- > Changelog: > d3d8: Void functions should not return a value. > > diff -urN a/dlls/d3d8/cubetexture.c b/dlls/d3d8/cubetexture.c > --- a/dlls/d3d8/cubetexture.c 2006-12-06 11:51:13.000000000 +0000 > +++ b/dlls/d3d8/cubetexture.c 2007-04-07 20:35:00.000000000 +0100 > @@ -104,7 +104,8 @@ > static void WINAPI IDirect3DCubeTexture8Impl_PreLoad(LPDIRECT3DCUBETEXTURE8 iface) { > IDirect3DCubeTexture8Impl *This = (IDirect3DCubeTexture8Impl *)iface; > TRACE("(%p) Relay\n", This); > - return IWineD3DCubeTexture_PreLoad(This->wineD3DCubeTexture); > + IWineD3DCubeTexture_PreLoad(This->wineD3DCubeTexture); > + return; > } > I don't see the point of still having "return;" as last statement of function. It can be safely removed A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 1

Re: d3d8: Void functions should not return a value
by H. Verbeet 07 Apr '07

07 Apr '07

On 07/04/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > These functions are correctly declared to return nothing, so that's what they > should do. > > -- Andy. They don't technically return a value... the wined3d functions are void as well. I'm not sure what the idea there was :-)

1 0

string comparison functions
by Tomas Kuliavas 07 Apr '07

07 Apr '07

Hi, Sorry for cross posting. I've already asked same question on wine-users list and only reply redirected me to devel list. What rules are used when Wine libraries compare Unicode strings? I need to know when ascii characters can match their approximate Unicode equivalents. For example: 'U+1D49 MODIFIER LETTER SMALL E' matches 'U+0065 LATIN SMALL LETTER E' on Wine. I am debugging IE javascript security issues. IE6 on Wine (Linux Debian) matches more Unicode equivalents than IE6 on Win98 and WinXP. If you need more information, I can provide sample html that works on Wine and does not work on Win98/XP. I am not C/C++ programmer. I only need to know which library provides mapping of unicode equivalents in string comparison functions. Is it standard C library? glibc 2.3.6 on Debian Etch. -- Tomas

2 1

ntdll/kernel32: LoadLibrary fails to load some dependent libs
by Clinton Stimpson 07 Apr '07

07 Apr '07

So I have this case: An application that can load libraries at runtime (plugins). Plugins reside in a different directory than the application directory. Some plugins have dependent dlls found only in the plugin directory. Wine fails to load the dependent dlls. I can copy the dependent dlls into the application directory and the plugins load successfully. I traced the execution into ntdll/loader.c : load_native_dll load_path included the the application directory and some system paths. name is the full path of the library to load. The call to fixup_imports fails. Should the path to the library be added to load_path in load_native_dll? Or is there another appropriate way to fix this? Thanks, Clint

2 2

re: Contributing money to WINE?
by Dan Kegel 06 Apr '07

06 Apr '07

Tim wrote: >I find myself in a similar dilemma... What if a few of us banded >together and put a bounty on a feature / app, or contracted >codeweavers to implement it? I think that would be great. Assuming >we can agree on something we'd like to fund, it would be a little more >targeted than just voting in CW's appdb. Problem is, most of the things you might want to have fixed are pretty expensive. Let's say a bug takes ten days to fix. Assuming $100/hr (which is not far off for contract development), that's $8K right there. Lots of folks have thought about how to solve the problem, but dealing with money is complicated. It'd be better for you to donate time triaging bugs, IMHO. ( http://kegel.com/wine/qa/ ) Just reproduce one bugzilla entry a day for a week, and document what you find, and we'd be very happy!

2 1

Re: [resend] notepad: Improve printing considerably
by Alexandre Julliard 06 Apr '07

06 Apr '07

"Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> writes: > Changelog > programs/notepad/dialog.c > programs/notepad/main.c > programs/notepad/main.h > Improve printing considerably That's not a very useful log message... Could you please describe a bit how it is improved? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: notepad: Improve printing considerably
by Dmitry Timoshkov 06 Apr '07

06 Apr '07

"Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> wrote: > +#include <tchar.h> What is this for? According to the Alexandre's comments we should convert all the Wine builtin apps to unicode intead of promoting usage of TCHAR that leads to a lot of trouble in multibyte locales, besides it looks like tchar.h is not used at all. -- Dmitry.

2 1

Using signals to turn logging on and off
by Dan Kegel 06 Apr '07

06 Apr '07

I tried the patch in the wiki to control logging with f12, but it wasn't quite satisfying, because only one process has the keyboard, so you can only turn one process' logging on and off. This isn't so great if the process you're interested in never has the keyboard. (Like com servers started up during installers.) So I played around with using unix signals instead. And rather than having a signal toggle the enable status, I used one signal for enable and another for disable. The feature is only turned on if you set the WINEDEBUGSIG environment var. Problem is, all I can do is turn logging off; turning it on doesn't work for some reason. Feh. Can somebody spot what I did wrong? It's at http://kegel.com/wine/debugsig.patch It was monkey-see-monkey-do code, to some extent, so I wouldn't be surprised if there's an obvious problem. Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: notepad: Use the more explicitly UNICODE character type.
by Dmitry Timoshkov 06 Apr '07

06 Apr '07

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > Changelog: > Use the more explicitly UNICODE character type. Then you have to simultaneously explicitly start using unicode Win32 APIs. I'd suggest you to start with the application that presumably doesn't work properly in multibyte locales and which you already started to look at - regedit, and leave notepad alone until there are real problems discovered. -- Dmitry.

2 1

re: kernel32: Implement ReplaceFileA/ReplaceFileW (revised, resubmit)
by Dan Kegel 06 Apr '07

06 Apr '07

Kudos for your persistance. I hope this makes it in soon. I see two remaining problems: + /* + * This case should never occur, we've already checked permissions earlier + * and we are holding the file handle open. + */ + ERR("Replacement file may not be deleted!\n"); You need to handle this case better; it happens in real life sometimes that the filesystem lies when it tells you you can write. It should be a WARN, and you need to return the proper error code. Are you quite sure you need to do any file copying? Wouldn't a series of renames be more efficient? - Dan

2 1

Re: [2/2] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride
by H. Verbeet 05 Apr '07

05 Apr '07

On 05/04/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > > > From b369a9384beb831dfae6460418d861f30a9cef3e Mon Sep 17 00:00:00 2001 > From: Fabian Bieler <der.fabe(a)gmx.net> > Date: Thu, 5 Apr 2007 21:52:44 +0200 > Subject: [PATCH] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride > This doesn't work for the general case, ie blitting any surface to another surface. I've got a more complete patch for this in my tree.

1 1

Re: notepad: Fix the wrong '&' operator use.
by Felix Nawothnig 05 Apr '07

05 Apr '07

Byeong-Sik Jeon wrote: > FormatMessage( > FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, > NULL, error, 0, > - (LPTSTR) &lpMsgBuf, 0, NULL); > + lpMsgBuf, 0, NULL); This patch is wrong. When FORMAT_MESSAGE_ALLOCATE_BUFFER is used FormatMessage() takes a pointer to a pointer.

2 1

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.
by Detlef Riekenberg 05 Apr '07

05 Apr '07

On Mi, 2007-04-04 at 10:36 +0900, Byeong-Sik Jeon wrote: > > + /* convert from WCHAR size to maximum required TCHAR size */ > + max_val_name_len *= sizeof(WCHAR) / sizeof(TCHAR); > + > valName = HeapAlloc(GetProcessHeap(), 0, max_val_name_len * > sizeof(TCHAR)); > valBuf = HeapAlloc(GetProcessHeap(), 0, max_val_size); > if (RegQueryValueEx(hKey, NULL, NULL, &valType, valBuf, &valSize) > == ERROR_FILE_NOT_FOUND) { This looks wrong to me: TCHAR is WCHAR, when compiled with UNICODE, otherwise TCHAR is CHAR The code does already handle the different character-size in HeapAlloc for varName. When the app must handle the case, that sizeof(string) can be > "strlen(string) + sizeof(0)", then we should convert the app to use UNICODE everywhere. For the last quoted line, valSize is not initialized! (RegQueryInfoKey wrote the result to max_val_size) Just checked Coverity: not detected -- By by ... Detlef

5 15

Fedora packages, where are they?
by Louis Lenders 05 Apr '07

05 Apr '07

Hi, the link on the wine-page to get the Fedora- wine packages points to "nowhere". Could this be fixed? Furthermore, anyone know where i can get the wine-rpm for Fedora?

3 2

Re: comctl32: toolbar[1/4]: avoid using CopyImage as it doesn't work well when the DDBs are RGB565 (fixes bug #7905)
by Dmitry Timoshkov 05 Apr '07

05 Apr '07

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote: > If the DDB format is RGB565, CopyImage uses an RGB555 intermediate DIB > that leads to data loses. This may change the COLOR_BTNFACE pixels > slightly and they won't be recognized as transparent anymore. As this > bug is also present under Windows, I haven't changed CopyImage but wrote > a new function that I hope works correctly. Since it clearly sounds like a CopyImage bug it would be more appropriate to fix CopyImage instead, Microsoft may do that at some point as well. -- Dmitry.

2 1

Re: [PATCH] kernel32: return copy of environment block inGetEnvironmentStringsW
by Dmitry Timoshkov 05 Apr '07

05 Apr '07

"Peter Beutner" <p.beutner(a)gmx.net> wrote: > Make behaviour consistent with GetEnvironmentStringsA. > Prevents crash for confused applications which first call > GetEnvironmentStringsW and then want to free it with FreeEnvironmentStringsA. This patch is wrong: http://blogs.msdn.com/matt_pietrek/archive/2004/08/25/220330.aspx Probably an exception handler should be added inside of RtlFreeHeap instead. -- Dmitry.

3 4

Re: wined3d: Fix GLSL cnd instruction
by H. Verbeet 05 Apr '07

05 Apr '07

On 05/04/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > According to MSDN the cnd instruction should translate: > dst = src0 > 0.5 ? src1 : src2; > > This matches the ARB implementation in wined3d and fixes the borders in civ4. > > Note: On nvidia hardware this patch breaks the outro of Half-Life 2 with > dxlevel 80 and GLSL due to a driver bug. > You should update the comment above the instruction as well then.

1 0

Re: [AppDB] Use objectMakeLink()/Url() in more places
by Marty Schmidt 05 Apr '07

05 Apr '07

I can not open the attachment on this message ----- Original Message ----- From: "Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> To: <wine-patches(a)winehq.org>; "Chris Morgan" <cmorgan(a)alum.wpi.edu> Sent: Sunday, April 01, 2007 4:38 PM Subject: [AppDB] Use objectMakeLink()/Url() in more places Use objectMakeLink()/Url() in more places. Regards, Alexander N. Sørnes -------------------------------------------------------------------------------- > >

2 1

Re: winspool: Add a test for DeviceCapabilities, fix some bugs found
by Detlef Riekenberg 04 Apr '07

04 Apr '07

On Di, 2007-04-03 at 23:40 +0900, Dmitry Timoshkov wrote: > Changelog: > winspool: Add a test for DeviceCapabilities, fix some bugs found. > + hComdlg32 = LoadLibrary("comdlg32.dll"); > + assert(hComdlg32); > + pPrintDlg = GetProcAddress(hComdlg32, "PrintDlgA"); > + assert(pPrintDlg); Why are you using assert() and kill the test? Is skip not enough? > + ok(dm != NULL, "GlobalLock(prn_dlg.hDevMode) failed\n"); > + trace("dmDeviceName \"%s\"\n", dm->dmDeviceName); You added a ok() for "dm =! NULL", but "dm" is accessed always and will crash the test. > + ok(dn != NULL, "GlobalLock(prn_dlg.hDevNames) failed\n"); > + ok(dn->wDriverOffset, "expected not 0 wDriverOffset\n"); Same here for "dn". > + ok(lstrcmp((const char *)dm->dmDeviceName, (const char *)dn + dn->wDeviceOffset) == 0, "device names not match\n"); You introduced the same bug, as you did in in your previous Patch! (test_DocumentProperties) dm->dmDeviceName is limited to CCHDEVICENAME > + trace("fields %x\n", fields); > +todo_wine > + ok(fields == dm->dmFields, "fields %x != dmFields %x\n", fields, dm->dmFields); info.c:2093:fields 7b13 info.c:2095: Test succeeded inside todo block: fields 7b13 != dmFields 7b13 I get the same "succeeded inside todo" for all printers > test_SetDefaultPrinter(); > test_XcvDataW_MonitorUI(); > test_XcvDataW_PortIsValid(); > + test_DeviceCapabilities(); > Why is it so difficult to add the tests in alphabetic order? This Patch dump a lot of unneeded data. Please remove the traces (or dump the data only in interactive mode). Thanks -- By by ... Detlef

2 2

Re: [winmm/winearts] Kill off winearts
by Chris Morgan 04 Apr '07

04 Apr '07

On 4/4/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > As far as I can tell, it has been disabled for at least 4 months, and I didn't hear anyone about it, so it seems like a good idea to remove winearts, if anybody feels like reviving it, it would be easy to do so by reversing this commit, but KDE itself is moving away from arts, so I dont see a point in keeping this broken, disabled audio backend. As the original author I'll second that opinion. Btw, it would be nice if someone with low level knowledge of threading/glibc could take a look at winejack. Jack is a much better audio interface than arts and its a shame that it hasn't worked better and I haven't been able to debug the issues that winejack has had. Chris

1 0

Re: RegDeleteTreeA [2nd]
by Paul Vriens 04 Apr '07

04 Apr '07

On 4/2/07, Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > ChangeLog > -------------- > add some tests for RegDeleteTreeA > > > > > Hi Stefan, You're patch wasn't against latest GIT (or actually you reverted the last two registry test patches applied to GIT). Maybe my last mail wasn't clear but the last test now fails: Test failed: "Expected data got" (btw you forgot a newline for this ok call). The test should be that 'data' is not present anymore (the data for default should be empty). Cheers, Paul.

2 2

Re: [1/2] wined3d: Downgrade some ERRs to FIXMEs
by Stefan Dösinger 04 Apr '07

04 Apr '07

Am Dienstag 03 April 2007 23:38 schrieb Felix Nawothnig: > --- > dlls/wined3d/state.c | 24 ++++++++++++------------ > 1 files changed, 12 insertions(+), 12 deletions(-) Some of them should technically be ERRs because we tell the application that we do not support those features, so they should never be used. However, since we want to implement them somewhen I think its fine to downgrade them to FIXMEs

2 1

Re: [2/2] wined3d: Only issue state_patchsegments FIXME once.
by H. Verbeet 04 Apr '07

04 Apr '07

On 03/04/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > This really kills performance in upcoming Soldat 1.4 (looks like they > set this to bogus values even more often now). > --- Nothing against this change, but in general when playing games you should be running with WINEDEBUG="-all".

1 0

Start Menu handle?
by Indira Muthuswamy 04 Apr '07

04 Apr '07

Hai, How do I get handle to start menu in a handheld device? Thanks and Regards, M.Indu

1 0

Re: pathc for printdlg.c
by Dmitry Timoshkov 04 Apr '07

04 Apr '07

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > This patch corrects background color of a dialogue window "Print Dialog ". For > background color of dialog windows it used the background color of class > DIALOG or the COLOR_BTNFACE. > + case WM_CTLCOLORDLG: > + hbr=(HBRUSH)GetClassLongPtrW( hDlg, GCLP_HBRBACKGROUND); > + if (!hbr) hbr=(HBRUSH)GetSysColorBrush(COLOR_BTNFACE); > + return hbr; Why do you need this? Def[Wnd|Dlg]Proc is supposed to handle that. -- Dmitry.

1 0

Re: Propsheet exception fix
by Joris Huizer 03 Apr '07

03 Apr '07

--- Aric Stewart <aric(a)codeweavers.com> wrote: > Do not attempt to draw a page during WM_PAINT if > there is no active page. > Test which shows this working, causes exception > without this patch > Exception pointed out by EA Durbin. I in no way am in a position to criticise, but if it turns out not to be applied, you might want to add ok() checks, or at least comments, indicating what you are testing, as it currently doesn't really seem obvious regards, Joris ____________________________________________________________________________________ Don't pick lemons. See all the new 2007 cars at Yahoo! Autos. http://autos.yahoo.com/new_cars.html

1 0

wineprefixcreate - create symlink to cdrom drives(Try 2)
by EA Durbin 03 Apr '07

03 Apr '07

Is there anything wrong with this?

8 11

Re: winspool: Add a test for DeviceCapabilities, fix some bugs found
by Detlef Riekenberg 03 Apr '07

03 Apr '07

On Di, 2007-04-03 at 23:40 +0900, Dmitry Timoshkov wrote: > Changelog: > winspool: Add a test for DeviceCapabilities, fix some bugs found. > + ok(prn_dlg.hDevMode != 0, "PrintDlg returned hDevMode == NULL\n"); > + ok(prn_dlg.hDevNames != 0, "PrintDlg returned hDevNames == NULL\n"); > + > + dm = GlobalLock(prn_dlg.hDevMode); > + ok(dm != NULL, "GlobalLock(prn_dlg.hDevMode) failed\n"); > + trace("dmDeviceName \"%s\"\n", dm->dmDeviceName); > + > + dn = GlobalLock(prn_dlg.hDevNames); > + ok(dn != NULL, "GlobalLock(prn_dlg.hDevNames) failed\n"); > + ok(dn->wDriverOffset, "expected not 0 wDriverOffset\n"); > + ok(dn->wDeviceOffset, "expected not 0 wDeviceOffset\n"); > + ok(dn->wOutputOffset, "expected not 0 wOutputOffset\n"); > + ok(dn->wDefault == DN_DEFAULTPRN, "expected DN_DEFAULTPRN got %x\n", dn->wDefault); > + driver = (const char *)dn + dn->wDriverOffset; > + device = (const char *)dn + dn->wDeviceOffset; > + port = (const char *)dn + dn->wOutputOffset; > + trace("driver \"%s\" device \"%s\" port \"%s\"\n", driver, device, port); > + > + ok(lstrcmp((const char *)dm->dmDeviceName, (const char *)dn + dn->wDeviceOffset) == 0, "device names not match\n"); You are testing "PrintDlgA" in the testsuite for "winspool.drv". The correct location is: dlls/comdlg32/tests/printdlg.c -- By by ... Detlef

1 0

re: Road to 1.0
by Dan Kegel 03 Apr '07

03 Apr '07

Alexandre wrote: > That's still the plan, yes. I'm mostly waiting for the games > support to stabilize; the other main areas, office apps and > installers, both seem in good enough shape at this point. I suppose it depends on your definition of "office apps". Adobe Acrobat Pro and Quicken don't work yet, and they get used in a lot of offices. > I'm also hoping we can make some progress on the x11drv > factorisation before the freeze, so that we don't need to > change the interface too much to add the quartz driver later > on, we'll see how that goes. And if we delay it a bit more > maybe we can slip in Safedisc support too... Oh, yes, please. Here's a try at a 1.0 wish list: - Safedisc support - OpenGL child window problem solved for most common cards at least - Adobe CS2/8 era apps installing and working - Dragon Naturally Speaking 9 working (I'm selfish, I need that one :-) - Quicken 2006 installing/working (including online banking that requires 128 bits) - Mono integration working for non-toy apps - At least some of Munich's VB6 and/or databasey apps working (Hans just submitted a bunch of patches to fix most of the install issues in one) - Better application regression test suite (cxtest, yawt) October is looking about right for the start of the freeze, given that huge list. And my 1.1 wish list (i.e. hard things we can let slip past 1.0): - Activation context support - Quicken 2007 (which requires activation context support?) ... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

10 11

More Direct3D settings in winecfg (was: Enabling GLSL in winecfg)
by Vit Hrachovy 03 Apr '07

03 Apr '07

Hi, according to Stefan, Direct X options regarding * Available Video Memory * Enable GLSL will be useful in winecfg / Graphics section. However there is still missing consensus to how and whether to implement user accessible way to enable/disable GLSL in winecfg. Ray Jones, Stefan and me would like this in winecfg. Please share Your opinion. According to the discussion results, I'm going to add either only Available Video Memory text input box, or both Memory and GLSL toggle checkbox to winecfg. Summary of previous discussion follows: Available Video Memory (text input box) ---------------------- User will input here the RAM size of his graphic card. According to Stefan: "There are vendor dependent ways to read it, but implementing them is pretty nasty(requires some private to winex11.drv). Altough we had that discussion a number of times already and we only agreed on a registry key so far." Enable GLSL (checkbox) ----------- GLSL should be made default in 1.0. However, according to Stefan: "some drivers(*cough* macos *cough*) have serious problems with glsl". Until there is a specification in 1.0 requirements that these issues have to be resolved prior 1.0, this checkbox would be useful even past 1.0. Stefan Dosinger with H. Verbeet pointed out that this option should be in Vertex Shader dropdown box, but after inspecting code, I've found wouldn't blend well with the rest of Vertex Shader idea. This is due to GLSL registry key differs from Vertex Shader registry key. Should they be merged into one? Ivan Gyurdiev pointed out that GLSL can be both enabled for hardware vertex shader and software vertex shader, so the idea of merging GLSL with Vertex Shader dropdown box would result in two menu options - 'GLSL with HW support' and 'GLSL with SW support'. Another stance is to make GLSL enabled by default in next Wine versions. Offscreen Rendering (dropdown box) ------------------- Default option will be 'fbo', optional is backbuffer. Stefan doesn't consider it worthy adding to winecfg. Regards Vit

3 3

Anyone working on XKB support for Wine (or any other Keyboard language detection enhancements)?
by Shachar Shemesh 03 Apr '07

03 Apr '07

Hi all, The current keyboard detection and setting code is based on the traditional method of setting a keyboard in X11. It misdetects most any language that carries a US keyboard as the first group. While major work on other areas of Wine means that most programs today don't really care about that, it still confuses the $*(!@#&$ out of Word. It also has some pretty serious BiDi editing implications. I'm looking into replacing that with code based on the XKB X11 extension, today supported with any quasi reasonable X server. This should totally eliminate the guesswork done through keyboard change detection in wine today. The main question is this - is anyone today already working on this? Thanks, Shachar

3 2

FWD: Art Assets
by Tony Lambregts 03 Apr '07

03 Apr '07

Mike Matis wrote: > Hello, > > I'm not sure if this is the right venue to go through, but It was the > only contact I could find on WineHQ. My name is Mike Matis, and I'd > like to volunteer my skills as an amateur > artist for the Wine project. Specifically, I'd like to make icons, > logos, or other visual assets. I won't waste space in your inbox with > sample images if you have no need of an artist, but if you, do, I > would be willing to provide some samples, or even create a couple > assets on demand to demonstrate if my abilities are desired. I also > have a bit of skill in web design and general aesthetics (graphic and > print). Just give me some guidelines and I'll put myself at your > disposal. > > Hope I can help! > Mike Matis > > > I am forwarding this on to wine-devel since I do not know how we can use your talents but I am sure that there is a way we can use you. ;^) -- Tony Lambregts

1 0

Setting debug channels in 20040914 version
by Bill Medland 02 Apr '07

02 Apr '07

Can someone remind me how we used to set the debug channels back in late 2004?

4 3

[PATCH] winmm_test.exe fix for CALLBACK_THREAD
by Stéphan Kochen 02 Apr '07

02 Apr '07

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello again, "wine winmm_test.exe wave" reliably locks up for me after calling waveOutOpen() with the CALLBACK_THREAD flag, waiting for a WOM_OPEN message to arrive. Which never happens because I believe the thread doesn't have a message queue. This patch implements the solution mentioned in the "remarks" section of the MSDN page on PostThreadMessage: http://msdn2.microsoft.com/en-us/library/ms644946.aspx Fixed it for me. - -- Stéphan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGERkUcFUq0gzqDwQRAlwCAKD1rVdMXjawPzJOddfU5Oh9hK8cagCgzB2g 6b6JbG23fjGqk+Mj9xvHnF8= =rXu0 -----END PGP SIGNATURE-----

3 2

So long, and thanks for all the Wine!
by Dan Kegel 02 Apr '07

02 Apr '07

Wine was a fine dream, but come on, there's no way a bunch of volunteers could put together an emulator for a real operating system like Windows. Heck, after 14 years, Wine can't even run the average Visual Basic program! So I'm bowing to the inevitable, and have accepted a job with a popular operating system vendor working on fixing something called a "start menu"; I haven't heard the details yet, but it sounds very complex. They say I'll be leading a team of 50. If anyone's interested, please let me know; (I think the new start menu will be implemented in a mix of C# and VBScript for efficiency, so no C programmers need apply.) Cheers, Dan

7 7

Re: [3/3] ddraw: Enumerate explicitly using valid formats
by Stefan Dösinger 02 Apr '07

02 Apr '07

Am Montag 02 April 2007 10:20 schrieb Chris Robinson: > Instead of relying on WINED3DFMT_UNKNOWN to do the "right thing". Fixes a > reported regression in AOE. You can run the modes test in the ddraw testsuite on windows to find the formats windows supports.

1 0

Re: [PATCH 1/8] CMD.exe: Attempt launch even if fails to locate program
by Alexandre Julliard 02 Apr '07

02 Apr '07

Jason Edmeades <us(a)edmeades.me.uk> writes: > + /* Internal programs wont be picked up by this, so try one final > + createprocess and wait for it to complete. > + Note: Ideally we could tell between a console app (wait) and a > + windows app, but the API's for it fail in this case */ > + ZeroMemory (&st, sizeof(STARTUPINFO)); > + st.cb = sizeof(STARTUPINFO); > + init_msvcrt_io_block(&st); > + > + /* Launch the process and assume CUI so wait on it to complete */ > + status = CreateProcess (NULL, command, NULL, NULL, TRUE, > + 0, NULL, NULL, &st, &pe); > + > + if ((opt_c || opt_k) && !opt_s && !status && > + GetLastError()==ERROR_FILE_NOT_FOUND && command[0]=='\"') { > + /* strip first and last quote characters and try again */ > + WCMD_opt_s_strip_quotes(command); > + opt_s=1; > + WCMD_run_program(command, called); > + return; > + } > + > + /* If it still fails, give up */ > + if (!status) { > + SetLastError(ERROR_FILE_NOT_FOUND); > + WCMD_print_error (); > + /* If a command fails to launch, it sets errorlevel 9009 - which > + does not seem to have any associated constant definition */ > + errorlevel = 9009; > + return; > + } > + > + /* Wait for it to end */ > + WaitForSingleObject (pe.hProcess, INFINITE); > + GetExitCodeProcess (pe.hProcess, &errorlevel); > + if (errorlevel == STILL_ACTIVE) errorlevel = 0; > + CloseHandle(pe.hProcess); > + CloseHandle(pe.hThread); You should use the existing CreateProcess code instead of duplicating it all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Named pipes to remote machines?
by Dan Kegel 02 Apr '07

02 Apr '07

A user asked in http://groups.google.com/group/comp.emulators.ms-windows.wine/msg/06fbfdfb5… whether Wine could communicate with remote machines via named pipes yet (he needs it to talk with an SQLServer box). I know Alexandre's been poking around in that area, but I think he's working on local networking, not remote. I also know Kai Blin had looked at this, but I don't know where he left it. Can someone summarize the current state and plan, if any? Here are some past discussions on the topic: http://www.kerneltraffic.org/wine/wn20060428_312_print.html#3 http://www.winehq.org/pipermail/wine-devel/2005-September/039680.html http://kerneltraffic.org/wine/wn20040109_204.html#3 Thanks, Dan

2 1

Re: RegDeleteTreeA
by Paul Vriens 02 Apr '07

02 Apr '07

Stefan Leichter wrote: > ChangeLog > -------------- > add some tests for RegDeleteTreeA > Hi Stefan good to see someone picked up this thing. I ran your new tests on Vista Ultimate and comments are below. (I ran the tests while bypassing UAC, as administrator). > > ------------------------------------------------------------------------ > > --- ../wine-git/dlls/advapi32/tests/registry.c 2007-03-17 08:36:33.000000000 +0100 > +++ dlls/advapi32/tests/registry.c 2007-04-01 14:00:12.000000000 +0200 > @@ -35,6 +35,7 @@ > > static HMODULE hadvapi32; > static DWORD (WINAPI *pRegGetValueA)(HKEY,LPCSTR,LPCSTR,DWORD,LPDWORD,PVOID,LPDWORD); > +static DWORD (WINAPI *pRegDeleteTreeA)(HKEY,LPCSTR); > > #define ADVAPI32_GET_PROC(func) \ > p ## func = (void*)GetProcAddress(hadvapi32, #func); \ > @@ -47,6 +48,7 @@ > > /* This function was introduced with Windows 2003 SP1 */ > ADVAPI32_GET_PROC(RegGetValueA) > + ADVAPI32_GET_PROC(RegDeleteTreeA) > } > > /* delete key and all its subkeys */ > @@ -872,6 +874,53 @@ > RegDeleteKeyA(subkey, ""); > } > > +static void test_reg_delete_tree(void) > +{ > + CHAR buffer[MAX_PATH]; > + HKEY subkey, subkey2; > + LONG size, ret; > + > + if(!pRegDeleteTreeA) return; Can you add a skip here? > + > + ret = RegCreateKeyA(hkey_main, "subkey", &subkey); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegCreateKeyA(subkey, "subkey2", &subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegSetValueA(subkey, NULL, REG_SZ, "data", 4); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegSetValueA(subkey2, NULL, REG_SZ, "data2", 5); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegCloseKey(subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + > + ret = pRegDeleteTreeA(subkey, "subkey2"); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ok(RegOpenKeyA(subkey, "subkey2", &subkey2), > + "subkey2 was not deleted\n"); > + size = MAX_PATH; > + ok(!RegQueryValueA(subkey, "subkey", buffer, &size), > + "Default value of subkey not longer present\n"); This test fails so it must mean the default value should have been deleted. > + > + ret = RegCreateKeyA(subkey, "subkey2", &subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegCloseKey(subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = pRegDeleteTreeA(hkey_main, "subkey\\subkey2"); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ok(RegOpenKeyA(subkey, "subkey2", &subkey2), > + "subkey2 was not deleted\n"); > + ok(!RegQueryValueA(subkey, "subkey", buffer, &size), > + "Default value of subkey not longer present\n"); This test fails so it must mean the default value should have been deleted. > + > + ret = pRegDeleteTreeA(subkey, NULL); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ok(RegOpenKeyA(hkey_main, "subkey", &subkey), > + "subkey was not deleted\n"); The subkey will not be deleted by RegDeleteTree (see MSDN). This is the main difference between RegDeleteTree and SHDeleteKey (where the main key is deleted). > + > + ret = pRegDeleteTreeA(hkey_main, "not-here"); > + trace("deleting an not existing key returned %d\n", ret); The answer to this one is 2 : ERROR_FILE_NOT_FOUND > +} > + > START_TEST(registry) > { > /* Load pointers for functions that are not available in all Windows versions */ > @@ -901,6 +950,8 @@ > set_privileges(SE_RESTORE_NAME, FALSE); > } > > + test_reg_delete_tree(); > + > /* cleanup */ > delete_key( hkey_main ); > > > > ------------------------------------------------------------------------ > > Cheers, Paul.

2 2

Re: [PATCH 1/1] wined3d: Make 8bpp a valid depth in EnumAdapterModes
by Chris Robinson 02 Apr '07

02 Apr '07

On Friday 30 March 2007 08:11:54 pm Vitaly Budovski wrote: > Make 8bpp a valid depth in EnumAdapterModes. This allows Age of Empires to > start. > --- > dlls/wined3d/directx.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) This causes the d3d8 device test to fail for me: device.c:755: Test failed: Unexpected display mode returned for mode 42: 0x29 ...all the way through to... device.c:755: Test failed: Unexpected display mode returned for mode 83: 0x29 D3D8 only supports 32-bit X8R8G8B8 and 16-bit R5G6B5 modes as far as Windows testing has shown, and passing WINED3DFMT_UNKNOWN to WineD3D for mode enumeration makes it work on D3D8 modes only. You'll probably need to wait for Stefan or Henri to respond to figure out what to do. Though, it appears DDraw can be patched to do a second enumeration loop with WINED3DFORMAT_P8 if the first was with WINED3DFMT_UNKNOWN.. whether or not this is acceptable, I'm not sure, but it's an idea I just had.

3 4

Re: gdi32: simple test for bad pointer
by James Hawkins 01 Apr '07

01 Apr '07

On 4/1/07, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, this test shows similar problem as in bug 7380. On windows SetDIBits > returns 0, when a bogus pointer is passed in by the application. Wine > crashes on this test. I'll send in anoter try to fix this bug hereafter. > You can't send in a test that crashes without fixing it first or in the same patch. -- James Hawkins

1 0

Re: winecfg and cdrom drives
by EA Durbin 01 Apr '07

01 Apr '07

Does anyone who is Mac saavy have ideas on the best way to accomplish cdrom detection in wineprefixcreate across Mac OSX and *nix platforms? >From: "Dan Kegel" <dank06(a)kegel.com> >To: "EA Durbin" <ead1234(a)hotmail.com> >Subject: Re: winecfg and cdrom drives >Date: Sun, 1 Apr 2007 08:33:37 -0700 > >I haven't looked at it myself... >You want this to work on macosx, too, so be careful. > >On 4/1/07, EA Durbin <ead1234(a)hotmail.com> wrote: >> >>Nice, I didn't know that was performed by a bash script. What's the best >>way >>to go about detecting cdrom/dvd drives, just grep fstab? >> >> >From: "Dan Kegel" <dank06(a)kegel.com> >> >To: "EA Durbin" <ead1234(a)hotmail.com> >> >Subject: Re: winecfg and cdrom drives >> >Date: Sun, 1 Apr 2007 08:10:51 -0700 >> > >> >On 4/1/07, EA Durbin <ead1234(a)hotmail.com> wrote: >> >>Is there a reason we don't detect cdrom drives in winecfg and have to >> >>enter >> >>them manually? >> > >> >cd rom drives should be detected without user intervention, imho >> > >> >users shouldn't have to run a special gui config tool to get their >> >drives recognized >> > >> >so if it needs fixing, let's fix it in e.g. wineprefixcreate >> >> >> > > >-- >Wine for Windows ISVs: http://kegel.com/wine/isv

4 5

Re: [PATCH] ntdll: remove one exception test
by Dmitry Timoshkov 01 Apr '07

01 Apr '07

"Peter Beutner" <p.beutner(a)gmx.net> wrote: > - ok( (context->Dr6 & 0xf) == 0, "B0...3 flags in Dr6 shouldn't be set\n"); > + /* depending on the win version the B0 bit is already set here as well */ > + Please leave an original line of code in place, just enclose it in the comment. -- Dmitry.

1 0

extracting info from a minidump via winedbg
by Dennis Schridde 01 Apr '07

01 Apr '07

Hello Wine users! I've got a minidump from a ("real") Windows user of our game and would like to extract information from it using winedbg. The information winedbg gives me by default, is this: WineDbg starting on minidump on pid 068c warzone2100.exe was running on #1 Intel ???-0.521 CPU on Windows XP (2600) Register dump: CS:001b SS:0023 DS:0023 ES:0023 FS:003b GS:0000 EIP:0051008b ESP:0022f844 EBP:0022f858 EFLAGS:00010a87( - 00 ROISP1C) EAX:c7b054d8 EBX:19ff502e ECX:00000040 EDX:0000000f ESI:02010101 EDI:00000000 Stack dump: 0x0022f844: 00000000 00000000 00000000 3f800000 0x0022f854: 00000000 0022f8c8 0050e796 19ff502e 0x0022f864: 3f800000 00000000 00000000 00000000 0x0022f874: 00000000 00000000 00000000 ff4a4a4a 0x0022f884: 00000005 02010101 00000000 00000000 0x0022f894: 00000000 0022f8c8 00000000 00000000 Backtrace: =>1 0x0051008b (0x0022f858) 2 0x0050e796 (0x0022f8c8) 3 0x00410c3b (0x0022f948) 4 0x0041172d (0x0022f9c8) 5 0x004b2272 (0x0022f9d8) 6 0x004aa97b (0x0022f9f8) 7 0x004b615a (0x0022fab8) 8 0x004b663f (0x0022fad8) 9 0x004b67e1 (0x0022faf8) 10 0x0041e39e (0x0022fb28) 11 0x00459d3e (0x0022fb58) 12 0x0045b2ee (0x0022fca8) 13 0x0055e77b (0x0022fcf8) 14 0x0055e932 (0x0022fef8) 15 0x0055e483 (0x0022fff0) 16 0x00000000 (0x00000000) WineDbg starting on pid 068c Which is pretty rare. Via addr2line I can translate the backtrace to possibly valid locations in our sourcefiles. My questions are: - Why doesn't winedbg extract the sourcecode locations itself? - Why doesn't winedbg show me the other information included in the minidump, like the loaded modules, commandline options or version information? - How can I get the parameters to the last called function(s)? If winedbg is missing the commands/functions to achive the above, I may be able to provide it. The minidump functions seem to be documented rather good on msdn and it would just require printing it to the console. Thanks in advance, Dennis

4 7

Anyone else want to be a SoC mentor?
by Dan Kegel 31 Mar '07

31 Mar '07

Hey folks, it looks like we might need a few more mentors; anyone else interested? - Dan

1 0

Submitting AppDB test results broken?
by Markus 31 Mar '07

31 Mar '07

Hi, I just noticed that submitting test data to AppDB does not work. After submitting, the result page shows several e-mails sent but also an error "No test id defined!". The test data does not show up in the result list either. In addition, the .34 release is not available for selection yet. Regards, -- Markus

2 1

request to look into this bug
by Louis. Lenders 31 Mar '07

31 Mar '07

Hi, while working through the test reports in the appdb, i saw users submitting crashes with applications , all similar to bug 7380, so i decided to take it here. The applications that crash are *WinMerge (newest version) *BookWorms Adventures + several other PopCap games ( i tested them) *5 other applications listed under bug 7380. So i know of at least 10 applications that crash this way. They all start fine using the "buggy pointer" patch from Rein Klazes below. However, i think it's becoming rahter strange that all these (just released!) applications pass buggy pointers, so i'm beginning to think the problem must be somewhere else. I've sent in a patch to work around this bug by an exception handler a few weeks ago, but that's likely not the way to go either then. Anyone an idea how to tackle this problem? Thanks. diff --git a/dlls/winex11.drv/dib.c b/dlls/winex11.drv/dib.c index cec2058..4e61da4 100644 --- a/dlls/winex11.drv/dib.c +++ b/dlls/winex11.drv/dib.c @@ -3861,6 +3861,7 @@ INT X11DRV_SetDIBits( X11DRV_PDEVICE *ph X11DRV_DIB_IMAGEBITS_DESCR descr; BITMAP bitmap; LONG width, height, tmpheight; + int nrsrcbytes, dibpitch; INT result; descr.physDev = physDev; @@ -3880,6 +3881,17 @@ INT X11DRV_SetDIBits( X11DRV_PDEVICE *ph if (startscan + lines > height) lines = height - startscan; + + /* pointer check */ + dibpitch = ((width * descr.infoBpp + 23) &~23) / 8; + if( descr.compression) + nrsrcbytes = 1; + else { + nrsrcbytes = lines * dibpitch; + if( nrsrcbytes < 0) nrsrcbytes = - nrsrcbytes; + } + if( IsBadReadPtr( bits, nrsrcbytes)) return 0; + switch (descr.infoBpp) { case 1: @@ -3926,7 +3938,7 @@ INT X11DRV_SetDIBits( X11DRV_PDEVICE *ph descr.width = bitmap.bmWidth; descr.height = lines; descr.useShm = FALSE; - descr.dibpitch = ((descr.infoWidth * descr.infoBpp + 31) &~31) / 8; + descr.dibpitch = dibpitch; X11DRV_DIB_Lock( physBitmap, DIB_Status_GdiMod, FALSE ); result = X11DRV_DIB_SetImageBits( &descr ); X11DRV_DIB_Unlock( physBitmap, TRUE ); --------------------------------- New Yahoo! Mail is the ultimate force in competitive emailing. Find out more at the Yahoo! Mail Championships. Plus: play games and win prizes.

2 1

DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams 31 Mar '07

31 Mar '07

Sorry about the last patch, I slipped up on my bitwise operators. This should be correct to my intentions at least! (I forgot to hit reply all, agh, i should probably power off my computer now :P ) On 3/31/07, Chris Bandy <cbandy(a)jbandy.com> wrote: > > > Stefan Dösinger wrote: > >> @@ -3194,6 +3193,7 @@ static HRESULT WINAPI > >> > > IWineD3DSurfaceImpl_PrivateSetup(IWineD3DSurface *iface) { > > > >> } else { > >> /* No oversize, gl rect is the full texture size */ > >> This->Flags &= ~SFLAG_OVERSIZE; > >> + This->Flags &= SFLAG_NONPOW2; > >> > > > > > > This is not correct. This removes every flag except SFLAG_NONPOW2. If you want > > to remove the SFLAG_NONPOW2 flag you have to invert the flag: > > > > This->Flags &= ~SFLAG_NONPOW2 > > > If you want to set the SFLAG_NONPOW2 flag... > > This->Flags |= SFLAG_NONPOW2 > -- Nathan -- Nathan

2 3

Re: DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams 31 Mar '07

31 Mar '07

My first patch! Sorry this took so long for such a simple patch, I have just been run off my feet until now. Before I submit this to wine-patches, is anyone able to do some further testing for me, to make sure it doesn't break any currently working games? This patch fixes a bug that causes a crash for direct draw games when using opengl as the DirectDrawRenderer. I wanted to make sure this works and is safe, before I venture into making it optimized as Stefan suggested. On 3/25/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > case WINED3DFMT_P8: > { > int height = This->glRect.bottom - This->glRect.top; <--!!! > type = GL_UNSIGNED_BYTE; > fmt = GL_RGBA; > > mem = HeapAlloc(GetProcessHeap(), 0, This->resource.size * sizeof(DWORD)); > if(!mem) { > ERR("Out of memory\n"); > return; > } > memory_allocated = TRUE; > d3dfmt_convert_surface(This->resource.allocatedMemory, > ... > > > I think the int height = This->glRect.bottom - This->glRect.top is the > problem. It should use This->currentDesc.Height instead. The opengl rectangle > is a helper for surfaces which are bigger than the max size supported by > opengl If they are used for 2D blits. For example swat3 creates a 3000x32 > surface to blit text in 32x32 rectangles. In this case only the needed area > is uploaded to gl and used for blits. > > Here the gl rectangle does not apply. For the sake of optimization you may > change the code to only convert the dirty rectangle instead of the whole > surface. > > -- Nathan

3 3

Excluding a Windows version from the tests
by Paul Vriens 31 Mar '07

31 Mar '07

Hi, yesterday a patch of mine was committed to test more profile stuff from kernel32. When I have a look now at test.winehq.org I see that some test(s) crash on win98 but not on others. Although I could use a if(0) construction (as is done in several other tests), I'm wondering if we should just not run specific tests on specific Windows versions. It's a shame that one OS version blocks the running of several other tests. I have no idea yet how to achieve this without building in GetVersion style things, as logic and return values don't always make a good distinction. Any ideas, thoughts? Cheers, Paul.

5 11

Release notes
by John Voltz 30 Mar '07

30 Mar '07

I have a question about the Wine release notes. Do the Wine developers work from bugzilla or do they usually just work on a specific application feature? Would it require too much extra effort on the release notes to associate a specific change with a bugzilla bug-fix or specific application/feature fix? I believe IMHO that this would make the release notes more relevant and useful to the end user. I never can tell what was actually fixed in a particular release because of the obscure developer notes. I've been lurking on the wine-devel list watching how development progresses, because at some point I would like to attempt joining in on the development effort. -- John Voltz

2 1

RE: [PATCH 13/18] XCOPY: Add support for /EXCLUDELIST:file1+file2 etc
by Ann & Jason Edmeades 30 Mar '07

30 Mar '07

Further investigations shows the strstr bit is right, but the string I am comparing with differs from windows. I have fixed up xcopy's output display to mirror windows, and added that as a patch on the end of the resubmitted patchset, as it is not directly related to the strstr bit Regards, Jason

1 0

Jason Edmeades : xcopy: Add support for COPYCMD override and
by Ann & Jason Edmeades 30 Mar '07

30 Mar '07

>wouldn't it be nicer to use sizeof(copyCmd) here? >if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { >There are many spots like this in wcmdmain.c Yes... I'm blaming cut and paste as I didn't do all the wcmd ones :-) Once I get all my xcopy patches in I want to continue my rework of the cmd commands, finishing off some more inbuilt ones which I know are broken. I also want to extend your last patch to ensure all parts which process a command line are using the MAXSTRING length, and I'll do a patch for this while I am at it. Thanks, Jason

1 0

[PATCH 18/18] XCOPY: Add help
by Ann & Jason Edmeades 30 Mar '07

30 Mar '07

Er... I have just managed to get git send-email set up and working, and it would appear to be a feature of it. I do get one question which I answered n to, perhaps I should anser yes to it and see what happens :-) Anyone else using git send-email want to comment on how to avoid this? Thanks! Jason

1 0

Re: [PATCH 13/18] XCOPY: Add support for /EXCLUDELIST:file1+file2 etc
by Alexandre Julliard 30 Mar '07

30 Mar '07

Jason Edmeades <us(a)edmeades.me.uk> writes: > + /* Loop through testing each exclude line */ > + while (pos) { > + if (wcsstr(copyFromUpper, pos->name) != NULL) { > + WINE_TRACE("Skipping file as matches exclude '%s'\n", > + wine_dbgstr_w(pos->name)); wcsstr() doesn't seem the right way to compare file names. You probably want to do a wcsicmp() of the end of the name or something like that. -- Alexandre Julliard julliard(a)winehq.org

2 1

ExtTextOut with rotation and MM_ANISOTROPIC inverted coordinates
by Carl-Daniel Hailfinger 30 Mar '07

30 Mar '07

Hi, I have a problem with rotated Text displayed by ExtTextOut after SetMapMode(hdc, MM_ANISOTROPIC); SetWindowExtEx(hdc, 1000, -1000, NULL); Basically, giving one negative parameter to SetWindowExtEx should reverse the direction (clockwise/counterclockwise) in which rotation is done. It works in Windows, but has no effect in wine. The patch I created uses a side effect of the WMF file I had as test case, basically it sets lfClipPrecision = CLIP_LH_ANGLES and triggers direction inversion based on that instead of checking the WindowExtEx settings. That is of course wrong, but it is available almost everywhere in the text output paths and served me nicely as "inverse rotation" flag. Instead of abusing lfClipPrecision, what should we use? The SetWindowExtEx call sets some_matrix.eM11 to a negative value if its first argument is negative and eM22 to a negative value if its second argument is negative. So checking (eM11 * eM22 < 0) && (mapmode == MM_ANISOTROPIC) should be the correct solution. Problem: You can't always check these things because the dc is not available everywhere. In case you have a GdiFont, you can check (font->font_desc.matrix.eM11 * font->font_desc.matrix.eM22 < 0) or in case you have a LOGFONT (dc->xformWorld2Vport.eM11 * dc->xformWorld2Vport.eM22 < 0) I have not tested whether the parameters of the current dc, the parameters at the time CreateFontIndirect was run or the parameters at the time SelectObject(hdc, hfont) was run are responsible for the rotation inversion. What works? With the patch, lfClipPrecision = CLIP_LH_ANGLES has the effect SetWindowExtEx(hdc, positivevalue, negativevalue, NULL) should have. Exception: The text is clipped at the border, while Windows auto-extends the borders to avoid clipping. What doesn't work? SetWindowExtEx(hdc, positivevalue, negativevalue, NULL) still has no effect on the rotation angle. Attached are: create_mf.c: Testcase in C (thanks to Dmitry Timoshkov, who created the C code from a reduced WMF testcase I sent him) create_mf_generated.wmf: WMF file output by ./create_mf file.wmf wine-fontdirection-24.diff: Preliminary patch described above If somebody can take a look at the patch and mangle it so that it does the right thing, I'd be very grateful. Regards, Carl-Daniel -- http://www.hailfinger.org/ diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index ea2e66c..40d76c4 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -1944,6 +1944,10 @@ BOOL WINAPI ExtTextOutW( HDC hdc, INT x, { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index f7b1220..730725a 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -2675,10 +2675,10 @@ GdiFont *WineEngCreateFontInstance(DC *d if (!GetObjectW( hfont, sizeof(lf), &lf )) return NULL; can_use_bitmap = GetDeviceCaps(dc->hSelf, TEXTCAPS) & TC_RA_ABLE; - TRACE("%s, h=%d, it=%d, weight=%d, PandF=%02x, charset=%d orient %d escapement %d\n", + TRACE("%s, h=%d, it=%d, weight=%d, PandF=%02x, charset=%d orient %d escapement %d clipprecision %d\n", debugstr_w(lf.lfFaceName), lf.lfHeight, lf.lfItalic, lf.lfWeight, lf.lfPitchAndFamily, lf.lfCharSet, lf.lfOrientation, - lf.lfEscapement); + lf.lfEscapement, lf.lfClipPrecision); /* check the cache first */ if((ret = find_in_cache(hfont, &lf, &dc->xformWorld2Vport, can_use_bitmap)) != NULL) { @@ -2946,6 +2946,10 @@ found: } ret->orientation = FT_IS_SCALABLE(ret->ft_face) ? lf.lfOrientation : 0; + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + ret->orientation = FT_IS_SCALABLE(ret->ft_face) ? 3600 - (lf.lfOrientation % 3600) : 0; + } ret->name = strdupW(family->FamilyName); ret->underline = lf.lfUnderline ? 0xff : 0; ret->strikeout = lf.lfStrikeOut ? 0xff : 0; diff --git a/dlls/gdi32/path.c b/dlls/gdi32/path.c index af756b3..bc326ab 100644 --- a/dlls/gdi32/path.c +++ b/dlls/gdi32/path.c @@ -1363,6 +1363,10 @@ BOOL PATH_ExtTextOut(DC *dc, INT x, INT { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { cosEsc = 1; diff --git a/dlls/wineps.drv/font.c b/dlls/wineps.drv/font.c index 9e0ae39..7bfc53c 100644 --- a/dlls/wineps.drv/font.c +++ b/dlls/wineps.drv/font.c @@ -108,6 +108,10 @@ HFONT PSDRV_SelectFont( PSDRV_PDEVICE *p } physDev->font.escapement = lf.lfEscapement; + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + physDev->font.escapement = lf.lfEscapement ? 3600 - (lf.lfEscapement % 3600) : 0; + } physDev->font.set = FALSE; if(gdiFont && !subst) { diff --git a/dlls/wineps.drv/text.c b/dlls/wineps.drv/text.c index 59ac7c7..f6bd58c 100644 --- a/dlls/wineps.drv/text.c +++ b/dlls/wineps.drv/text.c @@ -105,6 +105,10 @@ static BOOL PSDRV_Text(PSDRV_PDEVICE *ph if(lf.lfEscapement != 0) { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { cosEsc = 1; sinEsc = 0; diff --git a/dlls/winex11.drv/xfont.c b/dlls/winex11.drv/xfont.c index 60bd70d..3ecd3dc 100644 --- a/dlls/winex11.drv/xfont.c +++ b/dlls/winex11.drv/xfont.c @@ -944,6 +944,10 @@ static BOOL LFD_ComposeLFD( const fontOb if (fo->lf.lfEscapement) { /* escapement is in tenths of degrees, theta is in radians */ double theta = M_PI*fo->lf.lfEscapement/1800.; + if (fo->lf.lfClipPrecision & CLIP_LH_ANGLES) + { + theta = - theta; + } LFD_AngleMatrix(h_string, h, theta); } else diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index e03540e..76d4e04 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -1136,6 +1136,10 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_P if(lf.lfEscapement != 0) { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + sinEsc = - sinEsc; + } } else { cosEsc = 1; sinEsc = 0;

1 0

Cross-Library tests, tests using multiple processes
by Stefan Dösinger 30 Mar '07

30 Mar '07

Hi, Screen resolution setting in DirectX games is still a huge mess. I want to fix it properly finally. Write tests to find out what really happens in windows, then implement it. Unfortunately that fails at the tests already. Our test framework is mainly limited to test single DLLs, and all tests I have been used to so far were in one single process. I would have to test what happens if there is one process requesting exclusive ddraw access and once process requesting explusive d3d9 access at once, and maybe a third process doing a screen resolution change, etc. Is there a way to write a test accross multiple libraries? I guess it is not hard to do, but it would look a bit bad if a ddraw test started using d3d9 directly. And is there a prefered way to spawn new processes and do communication between them? (Windows IPC I guess).

1 0

Re: Hardware cursor patch that does not break 'make test'.
by Stefan Dösinger 30 Mar '07

30 Mar '07

Am Freitag 30 März 2007 16:36 schrieb Andrew Riedi: > Here is the patch, opps, forgot to attach. > > On 3/30/07, Andrew Riedi <andrewriedi(a)gmail.com> wrote: > > Here is an updated patch that does not break make test. Sorry about > > sending in a bad patch, I always saw that regular make would create stuff > > in /tests dir's and thought that tested stuff. :\ Anyhow, this one > > should be fine. > > > > changelog: wined3d: Add hardware cursor support. Wouldn't you have to restore the original cursor in device::release? In general this shouldn't matter because 99% of all applications will terminate after destroying the device, but I think we should take care of that. What happens to cursorInfo.hbmMask and cursorinfo.hbmcolor after CreateIconIndirect? Is it destroyed with the cursor, or does it leak after cursorInfo, which sits on the stack, is destroyed?

1 0

re: Corrupted system.reg in clustered environment - where to look?
by Dan Kegel 30 Mar '07

30 Mar '07

Alexander.Farber at nokia.com wrote: > [I use wine on multiple machines with ~/.wine shared via NFS, > and after a while, the registry is corrupt.] Well, if it hurts, don't do it :-) Seriously. NFS is not a good place to put WINEPREFIX. In my testing, it causes serious performance problems. And NFS file locking has been broken from day 1. They keep trying to make it work, but it's never going to make you happy. So why not take the easy way out, and put WINEPREFIX on local disk? Surely you can do this. If you really need the Wine applications to share data, you can do it by creating D: or some directory in C: as a shared folder. Just don't share everything. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: Stub for all raw input functions
by Dmitry Timoshkov 30 Mar '07

30 Mar '07

"Kovács András" <andras(a)csevego.net> wrote: > +LRESULT WINAPI DefRawInputProc( PRAWINPUT *paRawInput, INT nInput, UINT cbSizeHeader ) > +{ > + FIXME("(paRawInput=%p, nInput=%d, cbSizeHeader=%d) stub!\n", *paRawInput, nInput, cbSizeHeader); > + > + return S_OK; > +} Although MSDN documents that on success DefRawInputProc returns S_OK, that's most likely a misguided documenters error: S_OK is an HRESULT and an OLE error value, while it's user32 and return type is LRESULT. So IMO simply returning 0 should be OK here. > +BOOL WINAPI RegisterRawInputDevices( PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize ) > +{ > + FIXME("(pRawInputDevices=%p, uiNumDevices=%d, cbSize=%d) stub!\n", pRawInputDevices, uiNumDevices, cbSize); > + > + return TRUE; > +} Probably this stub should return FALSE. > +UINT WINAPI GetRawInputBuffer( PRAWINPUT pData, PUINT pcbSize, UINT cbSizeHeader ) > +{ > + FIXME("(pData=%p, pcbSize=%p, cbSizeHeader=%d) stub!\n", pData, pcbSize, cbSizeHeader); > + > + return 0; > +} MSDN says that an error indicator is -1, not 0, same as for others raw input APIs. -- Dmitry.

2 1

Corrupted system.reg in clustered environment - where to look?
by Alexander.Farber＠nokia.com 30 Mar '07

30 Mar '07

Hello Wine developers, we try to use Wine in clustered environment with multiple Wine processes being started simultaneously on 8 to 80 Linux machines by a modified GNU make. The source code being built is located on an NFS mount visible by all cluster machines. Unfortunately Wine fails after some time because of corrupted ~/.wine/system.reg. I guess multiple Wine processes try to update some keys in that file, like (differing) processor steppings etc. and this goes wrong at some point. Also I've noticed, that the registry is being re-saved every 30 seconds (why?) - here in wine-0.9.32/server/registry.c: static const int save_period = 30000; /* delay between periodic saves (in ms) */ I've tried adding file locking using fcntl() (which should work over NFS too) by modifiyng load_registry() and save_registry() as in the attached diff, but unfortunately it doesn't help. Does anybody have a hint where to look? Why updating registry is needed at all and can I disable it maybe? (And where would be the good spot to do that?) Thank you Alex

2 2

Re: [1/2] regedit: Support the REG_MULTI_SZ.
by Juan Lang 30 Mar '07

30 Mar '07

Hi Byeong-Sik, + lRet = RegSetValueEx(hKey, valueName, 0, type, (LPBYTE)stringValueData, j); I think that should be j * sizeof(TCHAR), yes? --Juan ____________________________________________________________________________________ Food fight? Enjoy some healthy debate in the Yahoo! Answers Food & Drink Q&A. http://answers.yahoo.com/dir/?link=list&sid=396545367

2 1

RE: Jason Edmeades : xcopy: Add support for COPYCMD override and fix /-y.
by Alexander.Farber＠nokia.com 30 Mar '07

30 Mar '07

Hello, wouldn't it be nicer to use sizeof(copyCmd) here? if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { There are many spots like this in wcmdmain.c Regards Alex > -----Original Message----- > From: wine-cvs-bounces(a)winehq.org > [mailto:wine-cvs-bounces@winehq.org] On Behalf Of ext Alexandre Julliard .... > > + /* Preinitialize flags based on COPYCMD */ > + if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { > + if (wcsstr(copyCmd, PROMPTSTR1) != NULL || > + wcsstr(copyCmd, PROMPTSTR2) != NULL) { > + flags |= OPT_NOPROMPT; > + } > + } > + >

1 0

Re: [1/2 RESEND] gdi32: Add failing metrics test for negative font widths
by Alexandre Julliard 30 Mar '07

30 Mar '07

Felix Nawothnig <flexo(a)holycrap.org> writes: > Please tell me if this still fails on your box (both versions pass on mine). Now it succeeds where it shouldn't... ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:541: Tests skipped: Symbol is not installed so skipping this test font.c:784: Tests skipped: Arial is not installed font.c:1094: Tests skipped: Arial is not installed font.c:1228: Tests skipped: Arial Black is not installed font.c:1228: Tests skipped: Symbol is not installed font.c:1688: Tests skipped: Arial Black or Symbol/Wingdings is not installed font.c:1514: Test succeeded inside todo block: gm1=62,57,0,60,61,0 gm2=62,57,0,60,61,0 make: *** [font.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Remove an unnecessary XFlush().
by Alexandre Julliard 30 Mar '07

30 Mar '07

Huw Davies <huw(a)codeweavers.com> writes: > --- a/dlls/winex11.drv/xrender.c > +++ b/dlls/winex11.drv/xrender.c > @@ -596,7 +596,6 @@ void X11DRV_XRender_UpdateDrawable(X11DRV_PDEVICE *physDev) > if(physDev->xrender->pict) > { > TRACE("freeing pict = %lx dc = %p\n", physDev->xrender->pict, physDev->hdc); > - XFlush(gdi_display); > pXRenderFreePicture(gdi_display, physDev->xrender->pict); > physDev->xrender->pict = 0; > } This causes a test failure here: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so header.c && touch header.ok X Error of failed request: BadPixmap (invalid Pixmap parameter) Major opcode of failed request: 54 (X_FreePixmap) Resource id in failed request: 0x2400023 Serial number of failed request: 461 Current serial number in output stream: 472 make: *** [header.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 18/18] XCOPY: Add help
by Joerg Mayer 30 Mar '07

30 Mar '07

Umm, is there a specific reason why you created the mails by replying to the previous patch? This doesn't look that good with mailers that keep track of replies and e.g. indents them. ciao Joerg

1 0

Re: Declare another bunch of raw input structures and constants
by Dmitry Timoshkov 30 Mar '07

30 Mar '07

"Kovács András" <andras(a)csevego.net> wrote: > +typedef struct tagRAWMOUSE { > + USHORT usFlags; > + union { > + ULONG ulButtons; > + struct { > + USHORT usButtonFlags; > + USHORT usButtonData; > + } s; > + } u; You have to use DUMMYSTRUCTNAME and DUMMYUNIONNAME instead of s and u. Also please use 4 spaces indents instead of strange mix of 2 + 7 + 2. -- Dmitry.

1 0

Re: Allow enabling/disabling Direct3D usage of GLSL in Winecfg + update Czech locales for Winecfg
by Ivan Gyurdiev 29 Mar '07

29 Mar '07

Vit Hrachovy wrote: > Hi, > according to thread 'WineCfg and DirectX options' at wine-devel, That thread was heading in the wrong direction... > I'm > proposing a patch for winecfg to allow enabling/disabling usage of GLSL > for Direct3D applications rendering. Do you want to make it easy to configure GLSL, or make it easy to enable GLSL? In other words, can you enumerate the cases where one would disable GLSL? Should those be in a document somewhere on the wiki as blockers to 1.0 (since GLSL default was pointed out as a 1.0 requirement)? Do we expect this option to be around for a long time? I don't see consensus to add these options in the referenced thread - if more testing exposure is needed, why not just enable this by default?

3 2

Re: gdi32: Add failing metrics test for negative font widths
by Felix Nawothnig 29 Mar '07

29 Mar '07

Felix Nawothnig wrote: > --- > dlls/gdi32/tests/font.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) Anything wrong with this patch?

2 1

Wine Benchmarks and CAPS
by Tom Wickline 29 Mar '07

29 Mar '07

Hello, I have the 0.9.33 page done, and you may notice that Wine regressed in a couple of the test. When looking at these scores you will need to take into account the actual visual quality . The scores were somewhat high in past test because everything wasn't being rendered, while that makes for a nice score the visual wasn't on par with that of Windows. As of 0.9.33 the visual quality is very close to that of Windows, so in test like 3DMark2001SE we not only got drastically improved visual quality, we also have a 50% improvement in performance! And 3DMark 03 has a nice showing out of the gate as well. Why no OpenGL test? I plan to wait for a resolution to a couple outstanding OpenGL bugs, and then run the test again. I also plan to dramatically increase the screen resolution in the next update, GL-Excess in the past was run at only 640x480x16 in the future all test will be run at a resolution of 1024x768x32 or greater. If all goes well In a couple months there should be another update with OpenGL test and 3DMark 05/06 results. If 3DMark 2000, 2001SE or 2003 should drastically change ill also update them as well at that time. I also updated the CAPS page with 0.9.33 and 1.0.9755. 0.9.33 results: http://wiki.winehq.org/BenchMark-0.9.33 Past results: http://wiki.winehq.org/BenchMarks CAPS results: http://wiki.winehq.org/DirectX-Caps Some screen shots of past test results.... You may want to look at them ASAP if your interested in them, I plan to ask Dimi to rm -rf the page in a couple weeks to save the HD space on the wiki server, this way I can start a new "In Progress" page and not feel guilty about uploading all the shots :D http://wiki.winehq.org/BenchMark-0.9.6 Cheers! -- Tom Wickline Respectable computing - Linux/FOSS

4 5

Re: [PATCH 2/3] wined3d: Add NV/ARB_texture_rectangle extension (try 2)
by Stefan Dösinger 29 Mar '07

29 Mar '07

Am Donnerstag 29 März 2007 17:13 schrieb Vitaly Budovski: > Add support for NV_texture_rectangle and ARB_texture_rectangle extensions. > --- > dlls/wined3d/directx.c | 6 ++++++ > include/wine/wined3d_gl.h | 19 +++++++++++++++++++ > 2 files changed, 25 insertions(+), 0 deletions(-) Nothing really wrong with this patch, though I am concerned about patch 3. This patch is a dependency of patch 3, but there is nothing really wrong with adding the extensions.

2 3

Question about OpenAL
by Mike Schaadt 29 Mar '07

29 Mar '07

Is there any interest in adding OpenAL to Wine? I would imagine it's relatively simple to implement the OpenAL dll that would be a simple wrap around the Linux OpenAL library assuming they have the same functionality(from what I know of OpenAL, they should). It's not a very common library, but if we could implement it on top of the local implementation, that would mean that programs that use it would be using local devices without having to go through the DirectSound library. I'm not talking about using OpenAL as an audio driver, but an implementation of the OpenAL library for Wine that would use the local version of OpenAL. I tried looking around, and the only thing I found was talk about the OpenAL driver, and also brief requests for an OpenAL dll, but I didn't see anything official. Any thoughts on if this is something that would be beneficial to add?

5 4

Re: [PATCH 2/3] wined3d: Add ARB_texture_rectangle extension
by Frank Richter 29 Mar '07

29 Mar '07

On 29.03.2007 16:02, Stefan Dösinger wrote: > Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: >> Add support for ARB_texture_rectangle extension. >> --- >> dlls/wined3d/directx.c | 3 +++ >> include/wine/wined3d_gl.h | 9 +++++++++ >> 2 files changed, 12 insertions(+), 0 deletions(-) > There is also GL_NV_texture_rectangle. Is that one related? I think they're the same. -f.r.

2 1

Re: [PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit
by Stefan Dösinger 29 Mar '07

29 Mar '07

Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: > This patch sets the conditional NPOT bit only when required. If an > implementation has full support for NPOT textures through the > ARB_texture_non_power_of_two extension, then support for the subset of > capabilities provided by the ARB_texture_rectangle extension is implied. > --- > dlls/wined3d/directx.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) I am not sure if we shouldn't set NONPOWER2CONDITIONAL unconditionally if POW2 is set. WineD3D emulates np2 textures by using a texture of the next pow2size and adjusting the texture matrix accordingly. This doesn't work for shaders though, but mipmapping and other things are supported.

2 1

Re: [PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit (try 2)
by H. Verbeet 29 Mar '07

29 Mar '07

On 29/03/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > This patch sets the conditional NPOT bit only when required. If an > implementation has full support for NPOT textures through the > ARB_texture_non_power_of_two extension, then support for the subset of > capabilities provided by the ARB_texture_rectangle extension is implied. > > Add additional check for the equivalent NV extension. > --- Do you know what ARB_texture_rectangle is? It's not a subset of ARB_texture_non_power_of_two, and it doesn't correspond to WINED3DPTEXTURECAPS_NONPOW2CONDITIONAL in any way. Please read http://www.opengl.org/registry/specs/ARB/texture_rectangle.txt

1 0

Nine good SoC propsals!
by Dan Kegel 29 Mar '07

29 Mar '07

Wow. We have 29 or so total proposals, of which nine or ten seem like contenders. It's an embarrassment of riches! I wish we could pick them all. Time for the mentors to start arm-wrestling...

4 3

Re: [PATCH 2/3] wined3d: Add ARB_texture_rectangle extension
by Stefan Dösinger 29 Mar '07

29 Mar '07

Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: > Add support for ARB_texture_rectangle extension. > --- > dlls/wined3d/directx.c | 3 +++ > include/wine/wined3d_gl.h | 9 +++++++++ > 2 files changed, 12 insertions(+), 0 deletions(-) There is also GL_NV_texture_rectangle. Is that one related?

1 0

Re: gdi32: Implement the fake_bold for one faced fonts.
by Huw Davies 29 Mar '07

29 Mar '07

On Thu, Mar 29, 2007 at 10:00:12PM +0900, Byeong-Sik Jeon wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index f7b1220..427def4 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > + memcpy(&gmetrix, &ft_face->glyph->metrics, sizeof(FT_Glyph_Metrics)); > + if ( font->fake_bold ) > + { > + /* fitting values to MS-Windows */ > + strength = pFT_MulFix( ft_face->units_per_EM, ft_face->size->metrics.y_scale ) / 42; > + if ( strength < 64) > + { > + gmetrix.width += strength; > + gmetrix.height += strength; > + gmetrix.horiBearingY += strength; > + gmetrix.horiAdvance += strength; > + } > + else if ( strength < 77) > + { > + gmetrix.width += 63; > + gmetrix.height += 63; > + gmetrix.horiBearingY += 63; > + gmetrix.horiAdvance += 63; > + } > + else > + { > + gmetrix.width += strength; > + gmetrix.height += strength; > + gmetrix.horiBearingY += strength; > + } This needs more investigation. I can't believe Windows uses this algorithm... Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: imm32: Change the default IME window to better reflect applications request
by Byeong-Sik Jeon 29 Mar '07

29 Mar '07

It looks good to me. Thanks to Aric :) Aric Stewart wrote: > First part of this change was proposed by Byeong-Sik Jeon > <wjsqudtlr(a)gmail.com> > Use a tooltip window instead to avoid stealing focus from the application. > Additionally respect parameters give to us by ImmSetCompositionWindow > for placement of the composition window.

1 0

re: Improvement of WSAIoctl
by Dan Kegel 29 Mar '07

29 Mar '07

Hi Axel, > some days ago, I tried to run the retail management software, we are developing in our > company now for over 15 years, with Wine on Linux. Unfortunatly it didn't work. > > The reason was not our product itself, but the ODBC driver form MS for MS-SQL-Server. > It uses a command for WSAIoctl in ws2_32.dll, wich isn't implemented in Wine yet. > Because of the lack of this command, the driver fails and our software does not work. > > With other databases it works great, but unfortunatly most of our customers prefer using > MS-SQL-Server, so this piece of MS-Software is a must for us. I'm thrilled you're doing this. What's your software called? > + case WS_SIO_KEEPALIVE_VALS: > + { > + /* FIXME: not fully implemented */ > + BOOL value; > + > + if (cbInBuffer < sizeof(struct tcp_keepalive) || !lpvInBuffer) > + { > + WSASetLastError(WSAEFAULT); > + return SOCKET_ERROR; > + } > + > + value = ((struct tcp_keepalive *)lpvInBuffer)->onoff; > + return WS_setsockopt(s, WS_SOL_SOCKET, WS_SO_KEEPALIVE, (char *)&value, sizeof(BOOL)); > + } I think that looks great. If your patch isn't accepted in the next couple of days, consider adding a simple conformance test and resubmitting. But you can't do this: > + * Copyright (C) the Wine project as there's no legal entity called "the Wine project". You have to use your company's name, I think. (And be sure they've granted permission.) Or if you have the rights to what you do in your spare time, your own name is fine. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: ntdll: "add" ZwAreMappedFilesTheSame to ntdll.spec
by Dmitry Timoshkov 29 Mar '07

29 Mar '07

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index e315057..3377db3 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -948,7 +948,7 @@ > # @ stub ZwAllocateUserPhysicalPages > @ stdcall ZwAllocateUuids(ptr ptr ptr) NtAllocateUuids > @ stdcall ZwAllocateVirtualMemory(long ptr ptr ptr long long) NtAllocateVirtualMemory > -# @ stub ZwAreMappedFilesTheSame > +@ stub ZwAreMappedFilesTheSame > # @ stub ZwAssignProcessToJobObject > @ stub ZwCallbackReturn > # @ stub ZwCancelDeviceWakeupRequest It seems you haven't read an introducing comment in the first lines of ntdll.spec before changing it. -- Dmitry.

1 0

What is the X11 lock?
by Shachar Shemesh 29 Mar '07

29 Mar '07

Hi list, Can anyone please explain to me what the x11 lock is used for? I can see that SOME X11 functions (e.g. - read description on X11DRV_KEYBOARD_DetectLayout) require a lock, while others seem to call X11 functions with no lock. I can see that sometimes the x11 lock is obtained around a single X11 call. Is there any guideline I can follow that will tell me whether I need a lock for code I'm writing? What is the race this lock was designed to fix? Thanks, Shachar

1 0

Undocumented function syssetup.dll.SetupQueryRegisteredOsComponent
by Dan Kegel 28 Mar '07

28 Mar '07

Any suggestions as to how to discover the prototype of the apparently undocumented function syssetup.dll.SetupQueryRegisteredOsComponent ? It seems to be needed to install mdac-2.8. ( http://bugs.winehq.org/show_bug.cgi?id=5824 ) - Dan

5 5

Re: [PATCH 6/6] ole32: Implement MkParseDisplayName.
by Juan Lang 28 Mar '07

28 Mar '07

Hi Rob, +/* find a character from a set in reverse without the string having to be null-terminated */ +static inline WCHAR *memrpbrkW(const WCHAR *ptr, size_t n, const WCHAR *accept) +{ + const WCHAR *end, *ret = NULL; + for (end = ptr + n; ptr < end; ptr++) if (strchrW(accept, *ptr)) ret = ptr; + return (WCHAR *)ret; +} Maybe it's because I'm dense and I don't particularly like three levels of indent on a single line, but this doesn't seem to do what I'd expect. The for loop doesn't quit when ret is assigned, thus, this will always find the last character, from left to right, from accept in ptr, rather than the first. Don't you mean "ptr < end && !ret"? And in what sense is this "in reverse"? --Juan ____________________________________________________________________________________ Bored stiff? Loosen up... Download and play hundreds of games for free on Yahoo! Games. http://games.yahoo.com/games/front

2 2

WineD3D: Make CreateCubeTexture fail when not supported
by Felix Nawothnig 28 Mar '07

28 Mar '07

Not tested under Windows (does _anyone_ besides me have a Matrox? :) - would be nice if someone with either an MGA or an really ancient GPU could run the test on windows (if the pool=0 trace has an hr!=0 you got one of those ancient cards :). CCing to wine-devel for that reason. --- dlls/d3d8/tests/texture.c | 27 +++++++++++++++++++++++++++ dlls/wined3d/device.c | 5 +++++ 2 files changed, 32 insertions(+), 0 deletions(-)

2 1

Re: WineD3D: Make CreateCubeTexture fail when not supported
by Duane Clark 28 Mar '07

28 Mar '07

Felix Nawothnig wrote: > Not tested under Windows (does _anyone_ besides me have a Matrox? :) - > would be nice if someone with either an MGA or an really ancient GPU > could run the test on windows (if the pool=0 trace has an hr!=0 you got > one of those ancient cards :). CCing to wine-devel for that reason. On a Matrox G550, Win2k, crosscompiled on Linux with MingW: I:\dlls\d3d8\tests>d3d8_crosstest texture texture.c:122:texture caps: 0x000041c7 texture.c:110:pool=0 hr=0x8876086c texture.c:110:pool=1 hr=0x8876086c texture.c:110:pool=2 hr=0x8876086c texture.c:110:pool=3 hr=0x00000000 texture: 57 tests executed (0 marked as todo, 0 failures), 0 skipped.

2 1

Re: Allow enabling/disabling Direct3D usage of GLSL in Winecfg + update Czech locales for Winecfg
by Stefan Dösinger 28 Mar '07

28 Mar '07

> changelog entry: Allow enabling/disabling Direct3D usage of GLSL in winecfg > changelog entry: Update Czech localization for winecfg The changelog suggests that you have 2 different changesets in one path. If they do not depend on each other, please send them in seperate patches(and mails)

3 3

Re: [2/2] wined3d: Fix GLSL cnd instruction for INF and NAN arguments
by Marty Schmidt 28 Mar '07

28 Mar '07

Can you send me a patch?? ----- Original Message ----- From: "Fabian Bieler" <der.fabe(a)gmx.net> To: <wine-patches(a)winehq.org> Sent: Thursday, March 29, 2007 1:00 PM Subject: [2/2] wined3d: Fix GLSL cnd instruction for INF and NAN arguments > > -------------------------------------------------------------------------------- >From 1bca82ab76f27dd0e636305da74ec428caf9a919 Mon Sep 17 00:00:00 2001 From: Fabian Bieler <der.fabe(a)gmx.net> Date: Thu, 29 Mar 2007 19:59:11 +0200 Subject: [PATCH] wined3d: Fix GLSL cnd instruction for INF and NAN arguments --- dlls/wined3d/glsl_shader.c | 37 +++++++++++++++++++++++-------------- 1 files changed, 23 insertions(+), 14 deletions(-) diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 3d04f45..3ceb935 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -1156,26 +1156,35 @@ void shader_glsl_cnd(SHADER_OPCODE_ARG* arg) { glsl_src_param_t src0_param; glsl_src_param_t src1_param; glsl_src_param_t src2_param; - DWORD write_mask; - size_t mask_size; - - write_mask = shader_glsl_append_dst(arg->buffer, arg); + DWORD write_mask, cmp_channel = 0; + unsigned int i, j; if (shader->baseShader.hex_version < WINED3DPS_VERSION(1, 4)) { - mask_size = 1; + write_mask = shader_glsl_append_dst(arg->buffer, arg); shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], WINED3DSP_WRITEMASK_0, &src0_param); - } else { - mask_size = shader_glsl_get_write_mask_size(write_mask); - shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], write_mask, &src0_param); + shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], write_mask, &src1_param); + shader_glsl_add_src_param(arg, arg->src[2], arg->src_addr[2], write_mask, &src2_param); + shader_addline(arg->buffer, "%s < 0.5 ? %s : %s);\n", + src0_param.param_str, src1_param.param_str, src2_param.param_str); + return; } + /* Cycle through all source0 channels */ + for (i=0; i<4; i++) { + write_mask = 0; + /* Find the destination channels which use the current source0 channel */ + for (j=0; j<4; j++) { + if ( ((arg->src[0] >> (WINED3DSP_SWIZZLE_SHIFT + 2*j)) & 0x3) == i ) { + write_mask |= WINED3DSP_WRITEMASK_0 << j; + cmp_channel = WINED3DSP_WRITEMASK_0 << j; + } + } + write_mask = shader_glsl_append_dst_ext(arg->buffer, arg, arg->dst & (~WINED3DSP_SWIZZLE_MASK | write_mask)); + if (!write_mask) continue; - shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], write_mask, &src1_param); - shader_glsl_add_src_param(arg, arg->src[2], arg->src_addr[2], write_mask, &src2_param); + shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], cmp_channel, &src0_param); + shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], write_mask, &src1_param); + shader_glsl_add_src_param(arg, arg->src[2], arg->src_addr[2], write_mask, &src2_param); - if (mask_size > 1) { - shader_addline(arg->buffer, "mix(%s, %s, vec%d(lessThan(%s, vec%d(0.5)))));\n", - src2_param.param_str, src1_param.param_str, mask_size, src0_param.param_str, mask_size); - } else { shader_addline(arg->buffer, "%s < 0.5 ? %s : %s);\n", src0_param.param_str, src1_param.param_str, src2_param.param_str); } -- 1.4.4.1 -------------------------------------------------------------------------------- > >

1 0

WineD3D: Make CreateCubeTexture fail when not supported
by Luke Bratch 28 Mar '07

28 Mar '07

> Not tested under Windows (does _anyone_ besides me have a Matrox? :) - > would be nice if someone with either an MGA or an really ancient GPU > could run the test on windows (if the pool=0 trace has an hr!=0 you got > one of those ancient cards :). CCing to wine-devel for that reason. Somewhere I have an ancient Matrix MGA G200 AGP card... If this would be of any use, I'll dig it out and run any tests in Wine/Windows that you'd like? ___________________________________________________________ New Yahoo! Mail is the ultimate force in competitive emailing. Find out more at the Yahoo! Mail Championships. Plus: play games and win prizes. http://uk.rd.yahoo.com/evt=44106/*http://mail.yahoo.net/uk

2 1

Re: Alexandre Julliard : server: Add support for queuing a user APC upon async I/O completion.
by Eric Pouech 28 Mar '07

28 Mar '07

Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: c16eb8efd942bfbb0bb7f3da4c740a2e483cce28 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=c16eb8efd942bfbb0bb7f3da4… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Tue Mar 27 16:42:27 2007 +0200 > > server: Add support for queuing a user APC upon async I/O completion. > > do you have a plan, when the apc routine is used, to free the allocated async_fileio (in dlls/ntdll/file.c) ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Regression?
by Bill Medland 28 Mar '07

28 Mar '07

I just tripped over this; I think it crept in over the past couple of weeks. Anyone know what's going on? I'm not going to waste days searching for it if it is obvious to someone. wine: Call from 0x126ce72 to unimplemented function nspr4.dll.PR_GetPhysicalMemorySize, aborting wine: Unimplemented function nspr4.dll.PR_GetPhysicalMemorySize called at address 0x126ce72 (thread 0009), starting debugger... Unhandled exception: unimplemented function nspr4.dll.PR_GetPhysicalMemorySize called in 32-bit code (0x601773a9). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:601773a9 ESP:0033d6e4 EBP:0033d748 EFLAGS:00200216( - 00 - IAP1) EAX:01274c16 EBX:601b3868 ECX:00ca8898 EDX:00110024 ESI:0033d6f0 EDI:00000000 Stack dump: 0x0033d6e4: 00000000 00000000 60177374 80000100 0x0033d6f4: 00000001 00000000 0126ce72 00000002 0x0033d704: 01274c30 01274c16 00ca8898 00ca88ac 0x0033d714: 0033d734 6032ff42 00110000 00000000 0x0033d724: 00ca8898 00000000 611418ba 611418ba 0x0033d734: 0033d788 00bf6ddb 00ca8898 611418ba Backtrace: =>1 0x601773a9 stub_entry_point+0x51(dll=0x1274c30, name=0x1274c16) [/nobackup/wine/dlls/ntdll/loader.c:184] in ntdll (0x0033d748) 2 0x0126ce72 in docshell (+0x1ce72) (0x0033d760) 3 0x0126d023 in docshell (+0x1d023) (0x0033d788) 4 0x61143e50 in xpcom_core (+0x3e50) (0x0033d7b0) 5 0x61143f8d in xpcom_core (+0x3f8d) (0x0033d7c8) 6 0x6116b0f8 in xpcom_core (+0x2b0f8) (0x0033d7ec) 7 0x6116a3c3 in xpcom_core (+0x2a3c3) (0x0033dc0c) 8 0x61166792 in xpcom_core (+0x26792) (0x0033dc38) 9 0x61166a5e in xpcom_core (+0x26a5e) (0x0033dc4c) 10 0x611671c2 in xpcom_core (+0x271c2) (0x0033dc80) 11 0x61142350 in xpcom_core (+0x2350) (0x0033dcc0) 12 0x00ba6ea9 _IO_vfwprintf+0x35a9() in necko (0x0033dcec) 13 0x60dc524a nsChannel_GetContentType+0x62(iface=<register ESI not in topmost frame>, aContentType=<register EDI not in topmost frame>) [/nobackup/wine/dlls/mshtml/nsio.c:492] in mshtml (0x0033dd1c) 14 0x012224f1 in gkparser (+0x124f1) (0x0033dd90) 15 0x010a89a0 in rdf (+0x89a0) (0x0033eddc) 16 0x010a86a6 in rdf (+0x86a6) (0x0033ee0c) 17 0x01144259 in chrome (+0x4259) (0x0033ef44) 18 0x01148806 in chrome (+0x8806) (0x0033f004) 19 0x01148ac7 in chrome (+0x8ac7) (0x0033f01c) 20 0x01148e62 in chrome (+0x8e62) (0x0033f074) 21 0x01142616 in chrome (+0x2616) (0x0033f0b4) 22 0x0114104c in chrome (+0x104c) (0x0033f0f0) 23 0x611671c2 in xpcom_core (+0x271c2) (0x0033f124) 24 0x61142350 in xpcom_core (+0x2350) (0x0033f164) 25 0x011148b9 in profile (+0x48b9) (0x0033f1fc) 26 0x0111322e in profile (+0x322e) (0x0033f270) 27 0x60dc3d45 NSContainer_Create+0x9a9(doc=0x18d9a0, parent=0x0) [/nobackup/wine/dlls/mshtml/nsembed.c:317] in mshtml (0x0033f600) 28 0x60da84d6 HTMLDocument_Create+0x13a(pUnkOuter=0x0, riid=0x44db00, ppvObject=0x33f6b4) [/nobackup/wine/dlls/mshtml/htmldoc.c:1135] in mshtml (0x0033f630) 29 0x60dbe185 ClassFactory_CreateInstance+0x15(iface=<register EAX not in topmost frame>, pUnkOuter=0x0, riid=0x44db00, ppvObject=0x33f6b4) [/nobackup/wine/dlls/mshtml/main.c:149] in mshtml (0x0033f650) 30 0x605da568 CoCreateInstance+0x19c(rclsid=0x44db50, pUnkOuter=0x0, dwClsContext=0x5, iid=0x44db00, ppv=0x33f6b4) [/nobackup/wine/dlls/ole32/compobj.c:2170] in ole32 (0x0033f690) 31 0x00425375 in accpac (+0x25375) (0x0033f6bc) 32 0x00426ca0 in accpac (+0x26ca0) (0x0033f6d0) 33 0x0041a61b in accpac (+0x1a61b) (0x0033f6fc) 34 0x0041a82e in accpac (+0x1a82e) (0x0033f754) 35 0x0041950a in accpac (+0x1950a) (0x0033f77c) 36 0x6c371fb5 in mfc42 (+0x1fb5) (0x0033f7f4) 37 0x6c371cea in mfc42 (+0x1cea) (0x0033f814) 38 0x6c371c73 in mfc42 (+0x1c73) (0x0033f874) 39 0x6c372511 in mfc42 (+0x2511) (0x0033f898) 40 0x6c372528 in mfc42 (+0x2528) (0x0033f8c0) 41 0x6c37e93d in mfc42 (+0xe93d) (0x0033f928) 42 0x00411de7 in accpac (+0x11de7) (0x0033fa5c) 43 0x00402b0b in accpac (+0x2b0b) (0x0033fe48) 44 0x6c37b4f3 in mfc42 (+0xb4f3) (0x0033ff08) 45 0x602562ef start_process+0xcf(arg=0x0) [/nobackup/wine/dlls/kernel32/process.c:821] in kernel32 (0x0033ffe8) 46 0x757ccd73 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x601773a9 stub_entry_point+0x51 [/nobackup/wine/dlls/ntdll/loader.c:184] in ntdll: addl $12,%esp 184 for (;;) RtlRaiseException( &rec ); Modules: Module Address Debug info Name (146 modules) ELF 101000-16c000 Deferred libfreetype.so.6 ELF 16e000-171000 Deferred libxinerama.so.1 ELF 182000-1a8000 Deferred libfontconfig.so.1 ELF 1aa000-1c9000 Deferred libexpat.so.0 ELF 1f3000-254000 Deferred libodbc.so.1.0.0 ELF 25d000-270000 Deferred libresolv.so.2 PE 340000-349000 Deferred a4wsem PE 350000-362000 Deferred a4wmac PE 370000-3c1000 Deferred a4wrv PE 3d0000-3f0000 Deferred a4wdylib PE 400000-467000 Export accpac ELF 474000-55d000 Deferred libcrypto.so.4 PE 4a0000-6d4000 Deferred dsktpeng PE 4a0000-6d4000 Deferred dsktpeng PE 4a0000-6d4000 Deferred dsktpeng PE 4a0000-6d4000 Deferred dsktpeng PE 7f0000-819000 Deferred a4wicon ELF 879000-87c000 Deferred libcom_err.so.2 ELF 87e000-8e3000 Deferred libkrb5.so.3 ELF 8eb000-90c000 Deferred libk5crypto.so.3 PE 9e0000-9ef000 Deferred jsd3250 PE 9f0000-a59000 Deferred js3250 PE 9f0000-a59000 Deferred js3250 PE 9f0000-a59000 Deferred js3250 PE 9f0000-a59000 Deferred js3250 PE a60000-a92000 Deferred xpc3250 PE aa0000-ab6000 Deferred gkgfx ELF b42000-b45000 Deferred libxrandr.so.2 ELF b48000-b5f000 Deferred ld-linux.so.2 PE b50000-b63000 Deferred jsj3250 PE b50000-b63000 Deferred jsj3250 PE b70000-beb000 Deferred necko PE bf0000-bfc000 Deferred xppref32 PE c00000-c2e000 Deferred i18n PE c30000-c4e000 Deferred embedcomponents PE c50000-c5f000 Deferred caps ELF c8e000-cb1000 Deferred libm.so.6 ELF cb3000-cb7000 Deferred libdl.so.2 ELF cb9000-d98000 Deferred libx11.so.6 PE d70000-d88000 Deferred palmsync PE d90000-d9c000 Deferred typeaheadfind PE d90000-d9c000 Deferred typeaheadfind PE da0000-106d000 Deferred gklayout PE da0000-106d000 Deferred gklayout PE da0000-106d000 Deferred gklayout PE da0000-106d000 Deferred gklayout PE da0000-106d000 Deferred gklayout PE da0000-106d000 Deferred gklayout PE 1070000-1095000 Deferred imglib2 PE 10a0000-10ba000 Export rdf PE 10c0000-10f9000 Deferred appcomps PE 1100000-1110000 Deferred appshell PE 1110000-111e000 Export profile PE 1120000-1127000 Deferred xpcom_compat_c PE 1130000-1137000 Deferred sroaming PE 1140000-1150000 Export chrome PE 1150000-120b000 Deferred uconv PE 1210000-1248000 Export gkparser PE 1250000-127c000 Export docshell PE 10000000-1000b000 Deferred a4wcompat PE 1c000000-1c011000 Deferred a4wroto PE 1d000000-1d20e000 Deferred a4wmem32 PE 1d300000-1d5e1000 Deferred a4wapi PE 30180000-3018f000 Deferred cato3msk ELF 60141000-601cf000 Dwarf ntdll<elf> \-PE 60150000-601cf000 \ ntdll ELF 601f2000-60304000 Dwarf kernel32<elf> \-PE 60210000-60304000 \ kernel32 ELF 60304000-60363000 Deferred msvcrt<elf> \-PE 60310000-60363000 \ msvcrt ELF 60363000-603a1000 Deferred advapi32<elf> \-PE 60370000-603a1000 \ advapi32 ELF 603a1000-604bf000 Deferred user32<elf> \-PE 603c0000-604bf000 \ user32 ELF 604bf000-605aa000 Deferred shell32<elf> \-PE 604d0000-605aa000 \ shell32 ELF 605aa000-60634000 Dwarf ole32<elf> \-PE 605c0000-60634000 \ ole32 ELF 60634000-60683000 Deferred rpcrt4<elf> \-PE 60640000-60683000 \ rpcrt4 ELF 60696000-606c4000 Deferred winspool<elf> \-PE 606a0000-606c4000 \ winspool ELF 606c4000-606dc000 Deferred version<elf> \-PE 606d0000-606dc000 \ version ELF 606dc000-606f0000 Deferred lz32<elf> \-PE 606e0000-606f0000 \ lz32 ELF 606f0000-6077c000 Deferred oleaut32<elf> \-PE 60700000-6077c000 \ oleaut32 ELF 6077c000-607a0000 Deferred odbc32<elf> \-PE 60780000-607a0000 \ odbc32 ELF 607a0000-607be000 Deferred mpr<elf> \-PE 607b0000-607be000 \ mpr ELF 607be000-607e7000 Deferred ws2_32<elf> \-PE 607d0000-607e7000 \ ws2_32 ELF 607e7000-60800000 Deferred wsock32<elf> \-PE 607f0000-60800000 \ wsock32 ELF 6089a000-6091c000 Deferred winex11<elf> \-PE 608b0000-6091c000 \ winex11 ELF 60aab000-60ac7000 Deferred imm32<elf> \-PE 60ab0000-60ac7000 \ imm32 ELF 60ad0000-60b00000 Deferred uxtheme<elf> \-PE 60ae0000-60b00000 \ uxtheme ELF 60d37000-60d4b000 Deferred riched32<elf> \-PE 60d40000-60d4b000 \ riched32 ELF 60d4b000-60d8b000 Deferred riched20<elf> \-PE 60d60000-60d8b000 \ riched20 ELF 60d8b000-60df3000 Dwarf mshtml<elf> \-PE 60da0000-60df3000 \ mshtml ELF 60df3000-60e25000 Deferred urlmon<elf> \-PE 60e00000-60e25000 \ urlmon ELF 60e25000-60e66000 Deferred wininet<elf> \-PE 60e30000-60e66000 \ wininet PE 60ec0000-60ed1000 Deferred mozz PE 60ee0000-60f14000 Deferred msgbsutl PE 60f60000-60f87000 Deferred nspr4 PE 60f90000-60fe9000 Deferred nss3 PE 60ff0000-6102a000 Deferred nssckbi PE 61030000-61037000 Deferred palmsyncproxy PE 61040000-61047000 Deferred plc4 PE 61050000-61056000 Deferred plds4 PE 61060000-61068000 Deferred npnul32 PE 61070000-6108a000 Deferred smime3 PE 61090000-610ea000 Deferred softokn3 PE 610f0000-6110b000 Deferred ssl3 PE 61110000-61116000 Deferred xpcom PE 61120000-61134000 Deferred xpcom_compat PE 61140000-611a5000 Export xpcom_core PE 611b0000-611b6000 Deferred xpistub ELF 6156f000-6158b000 Deferred ximcp.so.2 ELF 62d4e000-62d50000 Deferred xlcutf8load.so.2 ELF 66148000-66198000 Deferred shlwapi<elf> \-PE 66160000-66198000 \ shlwapi ELF 68357000-68374000 Deferred iphlpapi<elf> \-PE 68360000-68374000 \ iphlpapi ELF 6a8f6000-6a901000 Deferred libnss_files.so.2 PE 6c370000-6c462000 Export mfc42 ELF 6e64c000-6e6d3000 Deferred gdi32<elf> \-PE 6e660000-6e6d3000 \ gdi32 ELF 74569000-74610000 Deferred comctl32<elf> \-PE 74570000-74610000 \ comctl32 ELF 757c6000-758d6000 Dwarf libwine.so.1 PE 780c0000-78121000 Deferred msvcp60 ELF 78671000-78709000 Deferred comdlg32<elf> \-PE 78680000-78709000 \ comdlg32 ELF 7bf00000-7bf03000 Deferred <wine-loader> PE 7c340000-7c396000 Deferred msvcr71 Threads: process tid prio (all id:s are in hex) 0000000a 0000000b 0 00000008 (D) G:\runtime\accpac.exe 0000000f 0 0000000e 0 0000000d 0 0000000c 0 00000009 0 <==

3 4

Localization resources
by Kirill K. Smirnov 28 Mar '07

28 Mar '07

Hi, Similar question has been discussed before: http://www.winehq.org/pipermail/wine-devel/2006-November/052140.html http://www.winehq.org/pipermail/wine-devel/2006-November/052142.html http://www.winehq.org/pipermail/wine-devel/2006-November/052143.html >You only need to add an English resource; the other language files are made by >whoever translates the English strings into their language. The better way is to add string untranslated into every resource, otherwise it will not be loaded. More info at http://www.winehq.org/pipermail/wine-devel/2006-November/052135.html -- Kirill

3 2

Re: [2/2] shlwapi: Match shlwapi wrappers to MSDN descriptions
by Alexandre Julliard 28 Mar '07

28 Mar '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > 341 stdcall @(long ptr) kernel32.FindNextFileW > -342 stdcall -noname SHInterlockedCompareExchange(ptr long long) > +# FIXME: 342 should be forwarded to InterlockedCompareExchangePointer > +342 stdcall -noname @(ptr long long) kernel32.InterlockedCompareExchange Then you can't forward it, you should keep the current implementation and make it use InterlockedCompareExchangePointer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: netapi32/tests: Add a missing '\n' to a trace().
by Kai Blin 28 Mar '07

28 Mar '07

On Wednesday 28 March 2007 10:00, Francois Gouget wrote: > - trace("Deleting the test user failed. You might have to manually > delete it."); > + trace("Deleting the test user failed. You might have > to manually delete it.\n"); } Whoops, thanks for the catch. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: setupapi [5/7]: The Inf file should be copied regardless of the destination buffer
by Alexandre Julliard 27 Mar '07

27 Mar '07

"James Hawkins" <truiken(a)gmail.com> writes: > Changelog: > * The Inf file should be copied regardless of the destination buffer. It doesn't seem right to copy the file and then return an error when the buffer is too small. -- Alexandre Julliard julliard(a)winehq.org

3 2

Localization resources
by Ann & Jason Edmeades 27 Mar '07

27 Mar '07

Hiya, If adding files for translation to a new directory (xcopy), can anyone confirm of deny whether the following is all I need to do: 1. Add rsrc.rc containing (* - see below) #include <windows.h> #include "resources.h" LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL #include "En.rc" 2. Add En.rc containing LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US STRINGTABLE DISCARDABLE LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT { id1, "string" id2, "string2" etc } 3. Modify Makefile.in to contain RC_SRCS = rsrc.rc (*) Do I need add other languages or do I let translators add their own? If I look at programs\start vs programs\winecfg, one has 18 languages and one has 14, so I am not quite sure what to do here Thanks! jason

2 1

Re: [PATCH 4/6] ole32: Display the testname for the test for display name in test_moniker.
by Juan Lang 27 Mar '07

27 Mar '07

Hi Rob, + ok(!lstrcmpW(display_name, expected_display_name), "%s: display name wasn't what was expected\n", testname); Can you pass a WCHAR * when the string format is %s? --Juan ____________________________________________________________________________________ The fish are biting. Get more visitors on your site using Yahoo! Search Marketing. http://searchmarketing.yahoo.com/arp/sponsoredsearch_v2.php

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel