- wine-devel - winehq.org

Re: Summer of code
by Dan Kegel 27 Mar '07

27 Mar '07

On 3/27/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Hi Dan! > I was curious how the SoC thing proceedes from now. The application deadline > is now over, but who got the applications? Did you get them, or are they > reviewed internally by Google? Who will be in charge for accepting them? Google received about 23 applications for Wine SoC projects. It's now up to the Wine GSoC mentors to rank the projects. See http://code.google.com/support/bin/answer.py?answer=60325&topic=10729 for the timeline. The mentors have something like two weeks to do the ranking. After that, Google will decide how many of the applications will be funded. I'll be in touch with the mentors shortly... - Dan

2 1

Re: setupapi [4/7]: Don't allow relative paths in SetupCopyOEMInf
by Alexandre Julliard 27 Mar '07

27 Mar '07

"James Hawkins" <truiken(a)gmail.com> writes: > @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = setupapi.dll > IMPORTLIB = libsetupapi.$(IMPLIBEXT) > -IMPORTS = user32 version advapi32 rpcrt4 kernel32 ntdll > +IMPORTS = user32 version advapi32 rpcrt4 kernel32 ntdll shlwapi It's a bit wasteful to import a whole bunch of shell stuff for a one-line function... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Create one notif window per thread.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Jacek Caban <jacek(a)codeweavers.com> writes: > I forgot to remove DestroyWindow form Release, sorry. This patch also > takes care of unloading DLL. It's really worth doing as it prevents > creating a lot of useless windows. It still won't work, because you cannot destroy a window belonging to another thread. And switching threads inside the dll detach would probably be a bit dangerous. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: comctl32 fix for message loops with LVS_OWNERDATA (virtual listviews)
by Dimi Paun 26 Mar '07

26 Mar '07

On Mon, March 26, 2007 18:18, Tom Kistner wrote: > This fixes FlashFXP 3.x, a "most wanted" application. > > Patch attached. See Bugzilla #5131 for details. Can you please resubmit using 4-space indent as it is used in the rest of that function? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Icon for wine
by Marcelo Boveto Shima 26 Mar '07

26 Mar '07

I created an svg version of wine's logo and then I created some icons for the wine applications based on wine's logo and tango's icons. wine-regedit.svg is based on a clipart found at openclipart.org: http://openclipart.org/media/files/nicubunu/2842 (license:public domain) They are temporarily hosted at http://200.181.205.134/wine/ Debdiff against the ubuntu's package to update the .desktop files is in this url too. Hope you enjoy. Marcelo Shima

2 1

Re: comctl32: Constify some variables (1 of 4)
by Alexandre Julliard 26 Mar '07

26 Mar '07

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > +++ b/dlls/comctl32/draglist.c 2007-03-24 10:29:36.000000000 +0000 > @@ -91,7 +91,7 @@ > } > > /* cleans up after dragging */ > -static void DragList_EndDrag(HWND hwnd, DRAGLISTDATA * data) > +static void DragList_EndDrag(HWND hwnd, DRAGLISTDATA const *data) Please use 'const DRAGLISTDATA *' instead, it's more standard and will avoid some confusion. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Patch to fix bug 892
by Juan Lang 26 Mar '07

26 Mar '07

Hi Patrick, thanks for the patch. Unfortunately it's rather large, and doesn't just do what it says, so it's unlikely to get accepted as-is. For example: + For use in GetSystemInfo(), these are the offsets into the register array. Original version + isn't very clear what is meant by regs[0]. That may be, but this change isn't strictly necessary to fix bug 892. You may send that change as a separate patch if you like. As another example: + #if defined(_SC_PAGESIZE) + cachedsi.dwPageSize = (DWORD)sysconf(_SC_PAGESIZE); Using sysconf is another change you may wish to make, but doesn't address bug 892. Please send this change separately as well. Another: - cachedsi.lpMinimumApplicationAddress = (void *)0x00010000; - cachedsi.lpMaximumApplicationAddress = (void *)0x7FFEFFFF; - cachedsi.dwActiveProcessorMask = 1; - cachedsi.dwNumberOfProcessors = 1; + cachedsi.lpMinimumApplicationAddress = (void *)0x00010000; /* Lower 64kb of memory... */ + cachedsi.lpMaximumApplicationAddress = (void *)0x7FFFFFFF; /* Lower 2GB */ cachedsi.dwProcessorType = PROCESSOR_INTEL_PENTIUM; - cachedsi.dwAllocationGranularity = 0x10000; + cachedsi.dwAllocationGranularity = 0x10000; /* */ Besides some of these changes being unnecessary (what's the meaning of an empty comment?) one is incorrect. The value 0x7ffeffff is not the same as 0x7fffffff. The former value was chosen for some braindead app, and changing it back would break it. As a general rule, patches should be: 1) independent - they should be able to be applied in one go, without depending on others. 2) correct - they shouldn't cause compile- or run-time breakages or regression test failures. 3) minimal - they should contain the least change necessary to accomplish what they set out to do, and they should set out to do just one thing. So, please have a go at separating your patch into multiple smaller ones and see where they go. Good luck! --Juan ____________________________________________________________________________________ Get your own web address. Have a HUGE year through Yahoo! Small Business. http://smallbusiness.yahoo.com/domains/?p=BESTDEAL

1 0

Re: WineD3D: Use GL_TEXTURE_2D for dummy textures
by H. Verbeet 26 Mar '07

26 Mar '07

On 26/03/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > As discussed in IRC. Probably won't apply without the last patch but > doesn't depend on it. > I think I missed that discussion.

2 2

Re: WineD3D: Use GL_TEXTURE_2D for dummy textures
by Stefan Dösinger 26 Mar '07

26 Mar '07

> Stefan, you mentioned something about "colliding with the normal 2d > handling" - from the code I don't see any problems and since you got no > test app... tell me if there's anything wrong with this. > static void activate_dimensions(DWORD stage, IWineD3DStateBlockImpl *stateblock) { > + glDisable(GL_TEXTURE_1D); > + checkGLcall("glDisable(GL_TEXTURE_1D)"); With the dummy texture beeing 2D we should not need to ever disable GL_TEXTURE_1D. According to the red book GL_TEXTURE_2D is preferred over _1D, _3D over _2D and _CUBE over _3D. Thus we would not even need the glDisable(GL_TEXTURE_2D) and can just leave it enabled, except if the stage(or any before) has a colorop of D3DTOP_DISABLE. Pixel shaders ignore GL_ENABLE(GL_TEXTURE_xD)

1 0

Wine's official Coverity contact(s)
by Paul Vriens 26 Mar '07

26 Mar '07

Hi, a few days ago I've received an email from Mikołaj Zalewski requesting an account for Coverity !? I know that in the past some of us dealt with Coverity already. I had a look at the new website and apparently things changed with respect to creating (and approving) new accounts. (Before the new website came alive I think just sending an email got you an account). I must say it's not clear to me how the process currently work but sending an email to scan-admin(a)coverity.com should do the trick. The approval then has to be done by the main contact(s). The next step will be that the main contact(s) will have some kind of administration rights to add/change/delete(?) accounts (at least that's how I understood it). I'm currently in contact with one of the Coverity guys and volunteered to be one of the main contacts. I had a look through the list of current users and all of them look valid to me. I think it will be good to have one or two more main contacts. So anyone volunteering? There will hardly be any work involved (I hope). Mainly dealing with approving new accounts and communicating things back to the Wine community. Cheers, Paul.

2 2

Re: [2/3] WineD3D: Implement bem shader instruction
by H. Verbeet 26 Mar '07

26 Mar '07

On 26/03/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Another patch, hopefully I got the glsl part right this time. > dst_mask is redundant, but otherwise it looks fine to me.

1 0

Re: Patch to fix bug 892
by Steven Edwards 26 Mar '07

26 Mar '07

On 3/25/07, Patrick Baggett <baggett.patrick(a)gmail.com> wrote: > There also was a problem with getting the number of processors. The old code > assumed always 1 processor. The new code uses POSIX interfaces, if > available, at compile time and correctly builds a bitmask of the active > processors. It seems to me this should really be detected at runtime. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: Safedisc support (was: Road to 1.0)
by Timo Jyrinki 25 Mar '07

25 Mar '07

Alexandre Julliard wrote: > And if we delay it a bit more maybe we can slip in Safedisc > support too... Regarding which, does anyone have more up-to-date code and/or information regarding Safedisc support, than what is currently on the brand new Wine wiki page: http://wiki.winehq.org/SafeDisc ? Safedisc support seems to be a topic that is hacked upon by various people every now and then, but it does not seem very coordinated. It'd be great if the wiki page would help to report on who's working on what etc., and maybe even provide usable patches for users to try. -Timo

4 4

re: Winebot
by Dan Kegel 25 Mar '07

25 Mar '07

Vit wrote: > I'll write the manifest (a),(c) and post it onto Winebot Wiki. Cool... where is that? > I gladly accept any input to create a regression test repository, > would you be so kind and point me to some list of programs / test > miniprograms to make a reference implementation? I'd be glad to. I, Lei, and Nigel are just getting that going, and will be in touch via email. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS fix
by Robert Shearman 25 Mar '07

25 Mar '07

Andrew O. Shadoura wrote: > break; > } > > + if (flags & MB_USEGLYPHCHARS) { > + for (i=0; i!=dstlen; i++) > + if (dst[i]<0x20) dst[i]=glyph_xlat[dst[i]]; > + } > + > I think you need to take into account the codepage when doing this translation. -- Rob Shearman

4 6

Game road to 1.0
by Stefan Dösinger 25 Mar '07

25 Mar '07

Hi, In another thread Alexandre has mentioned to wait for game stuff to stabilize before the 1.0 freeze. I think its time for another brainstorm of what features are still missing which we want in 1.0. The DirectX Todo has a long list but it tends to be useless to me. And I see that it can use some more cleanup( /me blames Tom-W for not nagging me enough :-) ) It also sounds like AJ takes games as an excuse to delay the freeze for the display driver cleanup, and I was tempted to take the display driver cleanup as an excuse to get more dx stuff in. So which of the following things do we want for 1.0? Direct3D: * Some SM 3.0 features are still missing. Instancing is now in, vertex textures and some other stuff still missing. Not widely used among games yet. * Multithreading. OpenGL part done(except of 3 patches which I'll NOT send for now (*) ), but needs synchronisation. Will take a lot of time. * OpenGL ddraw. Render target locking improvements, multithreading. * Many games to not run yet, problems on MacOS drivers and fglrx. For the D3D part I see that as bugfixes which can happen after the freeze as far as I understand things. * Direct3D10. Will see if someone applies for my SoC proposal. (*) The patches that do the context selection. I won't send them because with my testing patches people started hunting phantom bugs which were the result of missing synchronisation. DirectSound: Maarten plans to work on that for SoC I think. Freezing now would make that difficult. Would mean to delay the freeze until September / October most at least. I'd personally really apprechiate dsound and alsa working better in 1.0. OpenGL: I don't really know of the windowed opengl state, and the wined3d -> wgl move. Still planned? DirectPlay: Kai works on the protocol, but I think he doesn't plan to implement it anytime soon. It seems the current idea is to improve our networking libs to get native dplay working.

6 11

Driver/os bug test app
by Stefan Dösinger 25 Mar '07

25 Mar '07

Hi, Some other thread got into a sub-discussion of how to deal with driver issues. I think it is a slightly bigger issue, so I start a seperate thread about it. First of all, we will never get rid of driver bugs. Even if all bugs are fixed in drivers there will be old driver versions around, and there will be misconfiguration. My experince with supporting CrossOver users, and (older) memories of #winehq shows that many people run into problem which are caused by missing 3D drivers. The usual procedure is to isolate the issue, then write a seperate test app and report the issue to the driver developer. Thats perfectly fine I'd say. My suggestion is to collect those test cases in a Wine driver test suit somewhere, a seperate application(in the wine tree or not) which users can run to test their systems for known issues. This would make dealing with bugs easier, when a user complains why wow is terribly slow tell him to check his system with that test app, or if a user reports a bug with simmilar issues tell him to test the driver too. The test app reports detected issues to the user and can store links to bug reports(if publically available) and the driver version which has the bug fixed(if any). That test app should be a native Linux / MacOS app, not an application running in wine to exclude wine bugs. If that idea is not accepted, I can set up a git repositority for collecting individual driver tests so we have them archived somewhere at least. Bugs are not limited to 3D drivers of course, some kernel versions are known to have issues too, so the whole proposal is not limited to 3D stuff.

1 0

Road to 1.0 (graphics driver architecture)
by Rolf Kalbermatter 25 Mar '07

25 Mar '07

Alexandre Julliard wrote: >I'm also hoping we can make some progress on the x11drv factorisation >before the freeze, so that we don't need to change the interface too >much to add the quartz driver later on, we'll see how that goes. Have you some specific ideas about what you want to do in that area? While the current apporach certainly works fine as far as invoking the DC specific functions without a lot of checking about the type of DC that is involved and therefore has a straightforward interface in GDI32 I think the matching of the actual driver interface with the actual GDI functions adds a lot of overhead into the driver itself that could much more easily be done once in GDI and left out of the driver completely. However changing the driver interface to match the let's say W2K driver would be quite a bit of work although it would seem to me at least an idea. Coming up with yet a different Wine specific interface would first require some architectural design work too but maybe you have done something in that direction already. Rolf Kalbermatter

2 1

Another win32 implementation: hiweedlayer?
by Dan Kegel 25 Mar '07

25 Mar '07

http://hiweed.com/node/798 offers "hiweedlayer" for download. It is supposedly a Windows layer like Wine. Running strings on their single executable, I see messages like %s is being traced! location has changed! abnormal behavior! shell has changed! %s has expired! Please contact your provider which look like they're from this little bit of malware: http://forums.fedoraforum.org/archive/index.php/t-25441.html but perhaps they're just trying to keep people from reverse-engineering their code (or finding out that they have Wine code inside?). Using google language tools to translate the page, http://translate.google.com/translate?u=http%3A%2F%2Fhiweed.com%2Fnode%2F79… it looks like somebody already asked them if they were related to wine, but they didn't really answer. Can somebody fluent in Chinese make contact with them and see what their story is with regard to wine? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

4 4

Re: Game road to 1.0
by Alessandro Pignotti 25 Mar '07

25 Mar '07

Hi, I'm actually working on DirectPlay implmentation, i'm first fixing a bit of thing around dplayx, so that we can use native dpwsockx (the dplay service provider) with builtin dplayx. After that i'm going to reimplement dpwsockx from scratch using the info from Kai Blins work on the protocol. Regards, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

Re: WineD3D: Handle WINED3DSPSM_DZ and WINED3DSPSM_DW in texcrd in arb shaders
by Ivan Gyurdiev 25 Mar '07

25 Mar '07

> From b1df18be85d1ca6a9904be05420f975f6933b030 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 23 Mar 2007 19:03:58 +0100 > Subject: [PATCH] WineD3D: Handle WINED3DSPSM_DZ and WINED3DSPSM_DW in texcrd in arb shaders > Isn't there a function to handle modifiers? "get_modifier_line"...

4 6

Re: [2/3] WineD3D: Implement bem shader instruction
by H. Verbeet 25 Mar '07

25 Mar '07

On 25/03/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > With the glsl suggestions from Henri :-) > >+ shader_addline(arg->buffer, "(%s.xy + bumpenvmat * %s.xy)%s);\n", >+ src0_param.reg_name, src1_param.reg_name, dst_mask); MSDN states that the source parameters can have swizzles and modifiers. Unless, you can prove that's not true, the code should become: void pshader_glsl_bem(SHADER_OPCODE_ARG* arg) { glsl_src_param_t src0_param, src1_param; shader_glsl_append)dst(arg->buffer, arg); shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], WINED3DSP_WRITEMASK_0|WINED3DSP_WRITEMASK_1, &src0_param); shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], WINED3DSP_WRITEMASK_0|WINED3DSP_WRITEMASK_1, &src1_param); shader_addline(arg->buffer, "%s + bumpenvmat * %s);\n", src0_param.param_str, src1_param.param_str); } Normally you would have to take the destination write mask into account as well, but for this instruction it's always .xy.

1 0

Fwd: DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams 24 Mar '07

24 Mar '07

Oh sorry, my misunderstanding! It is called from: flush_to_framebuffer_drawpixels http://source.winehq.org/git/wine.git/?a=blob;f=dlls/wined3d/surface.c;hb=H… On 3/25/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am Samstag 24 März 2007 23:59 schrieb Nathan Williams: > > It crashes at: > > dlls/wined3d/surface.c > > d3dfmt_convert_surface: > > 1593 *dest++ = table[color][0]; > Yes, but from where is this called? d3dfmt_convert_surface: gets a height > parameter, and this parameter is incorrect. > -- Nathan

1 0

DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams 24 Mar '07

24 Mar '07

I'm working on fixing the menus in carmageddon and I have a question. I have set the DirectDrawRenderer to opengl and it all crashes (where it works under gdi, just displays incorrectly). Now I traced the problem down to: dlls/wined3d/surface.c d3dfmt_convert_surface The loop at: http://source.winehq.org/git/wine.git/?a=blob;f=dlls/wined3d/surface.c;h=1f… loops over the surface height and width, the only problem is that the surface height appears to be scaled up to the next power of 2. As carmageddon runs in 320x200 the loop tries to iterate over 320x256 and subsequently crashes with a page fault in winedbg. Is there anyway to get the original window's dimensions and perhaps feed that to the function & hence loop, instead? Or should I just accept that carmageddon will forever be restricted to the gdi renderer? :P -- Nathan

2 5

re: SoC Idea: Improve bultin WordPad
by Dan Kegel 24 Mar '07

24 Mar '07

Alex wrote: >> > closest I have gotten is some patches for Wine's WordPad implementation. >> >> Granted, it's less sexy than games, but you could learn more about C and >> Wine by building on that experience. There are lots of small and easy >> improvements that can be done get Wordpad up to par with native. Then come >> back next year to fix the games! > >That i s a good idea. :) > >I think I will go for it, unless anyone has objections to it. Sounds good to me. Suggestion: spend a day or two filing bugs or enhancement requests now for a bunch of things you'd like to fix / improve in wordpad. (I might even suggest broadening your proposal to include notepad; maybe there are a couple low-hanging fruit there.) - Dan

3 2

re; [Resend][Corrected] gdi32:widenpath partial implementation
by Dan Kegel 24 Mar '07

24 Mar '07

I think it might help to a) create a bug in bugzilla with a link to Navigation, and a screenshot of the problem, and a recipe to reproduce b) think about how to implement a conformance test. Even a simple one might help. These suggestions were already made back in http://www.winehq.org/pipermail/wine-devel/2007-January/053457.html - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

SoC idea: Get Mono working well enough to run simple apps
by Dan Kegel 24 Mar '07

24 Mar '07

There are lots of little bits, some pretty basic, which Wine is missing before it can support mixed assemblies in Mono. For instance, http://bugs.winehq.org/show_bug.cgi?id=7098 says that we're missing an implementation of mscoree.dll.CorBindToRuntimeEx. This would probably be a fine area for an SoC project.

2 1

Wine SoC idea: get your favorite IDE working
by Dan Kegel 24 Mar '07

24 Mar '07

As the CEO of a famous operating system company once said, "I have four words for you: developers, Developers, DEVELOPERS, DEVELOPERS!" ( http://www.youtube.com/watch?v=KMU0tzLwhbE ) Attracting more developers (not of wine, but of their own apps) to Linux by getting their IDEs running on Wine would be great for wine, as developers are more likely than the average user to file bug reports or (dare we hope) fix bugs. So it would be good to get popular IDEs working on Wine. Newer Microsoft IDEs like Visual Studio 2005 are a challenge, Visual Studio 2005 express requires BITS (which is a SoC project in itself, http://bugs.winehq.org/show_bug.cgi?id=5054) Some IDEs run fairly well if you install DCOM98, in which case you would write conformance tests exposing the problems in our COM implementation so Rob can fix them :-) Older IDEs like Visual C++ 6 and Visual Basic 6 are in this category. cf. http://bugs.winehq.org/show_bug.cgi?id=4931 http://bugs.winehq.org/show_bug.cgi?id=5321 And then there's Eclipse, Delphi, Turbo C++, IntelliJ, Powerbuilder, Access, Visual Fox Pro, and many others. There are also specialized IDEs like AVRStudio (an IDE for embedded developers) which people want to run in Wine (see http://bugs.winehq.org/show_bug.cgi?id=5312). Picking one or two of these and focusing on getting its problems solved might be very useful. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Fwd: "Out of Tree" DLLs
by Kai Blin 24 Mar '07

24 Mar '07

Hi folks, Tim asked me about this on IRC today, and I didn't have any good idea about it, so I'll just forward it to you people. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 1

Re: WineD3D: Implement bem shader instruction
by H. Verbeet 24 Mar '07

24 Mar '07

On 24/03/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ shader_glsl_get_write_mask(arg->dst, dst_mask); >+ shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], WINED3DSP_WRITEMASK_ALL, &src0_param); >+ shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], WINED3DSP_WRITEMASK_0|WINED3DSP_WRITEMASK_1, &src1_param); >+ >+ shader_glsl_append_dst(arg->buffer, arg); >+ shader_addline(arg->buffer, "(%s + vec4(bumpenvmat * %s.rg, 0.0, 0.0))%s);\n", >+ src0_param.reg_name, src1_param.reg_name, dst_mask); >+} Please use xyzw consistently for components. Mixing xyzw with rgba and stuv only obfuscates things. Also, the vec4 contructor is unecessary, you should use proper swizzles instead.

1 0

RE: xcopy / cmd question (lack of real exe in system32)
by Alexander.Farber＠nokia.com 24 Mar '07

24 Mar '07

Hello Jason, I'm just curious: xcopy.exe is an external program in Windows, but you want to make it a builtin command in Wine? Regards Alex > -----Original Message----- > [mailto:wine-patches-bounces@winehq.org] On Behalf Of ext Ann > & Jason Edmeades > > If I now run "wine xcopy", then it works (and gives a basic > error for now), > but it I run "wine cmd", then "xcopy" I get file not found. > As far as I can > tell, cmd will only search the path for such a program and > fails to find it. > > Should I add it to the fake dlls, which I think would cause a > file to be > created in system32, or how should cmd handle this situation > as xcopy.exe.so > isn't available on the path.

4 4

SoC Idea: Improve video support
by Alexander Nicolaysen Sørnes 24 Mar '07

24 Mar '07

I really want to participate in Google's Summer of Code, but I realize I don't have much time left to find a suitable project. What I am thinking of is to improve Wine's capability of playing videos in games, first by fixing mciavi so it can play the Worms 2 intro films (bug 4256), and then hopefully progessing to fixing bugs in quartz/devenum, like crashes in Worms Armageddon or playback in WMP9. Is this too ambitious considering that I don't really have much experience with C and Wine? The closest I have gotten is some patches for Wine's WordPad implementation. Regards, Alexander N. Sørnes

3 3

Re: Winebot
by Remco 24 Mar '07

24 Mar '07

Will winebot be a win32 app or a linux app? Making it a win32 app and developing it on Windows would probably reveal more Wine bugs. ____________________________________________________________________________________ Looking for earth-friendly autos? Browse Top Cars by "Green Rating" at Yahoo! Autos' Green Center. http://autos.yahoo.com/green_center/

2 1

Re: netapi32: [2/5] Implement NetUserAdd with a dummy user database.
by Dmitry Timoshkov 24 Mar '07

24 Mar '07

"Kai Blin" <kai.blin(a)gmail.com> wrote: > + if(!su) > + { > + status = NERR_InternalError; > + goto user_add_error; > + } > + > + if(lstrlenW(ui->usri1_name) > LM20_UNLEN) > + { > + status = NERR_BadUsername; > + goto user_add_error; > + } > + > + /*FIXME: do other checks for a valid username */ > + lstrcpyW(su->user_name, ui->usri1_name); > + > + if(lstrlenW(ui->usri1_password) > PWLEN) > + { > + /* Always return PasswordTooShort on invalid passwords. */ > + status = NERR_PasswordTooShort; > + goto user_add_error; > + } 'break' would work just fine instead of 'goto' in all these places. -- Dmitry.

1 0

Re: netapi32/test: [1/5] Test the username and password length limits.
by Dmitry Timoshkov 24 Mar '07

24 Mar '07

"Kai Blin" <kai.blin(a)gmail.com> wrote: > + usri.usri1_name = (LPWSTR) sTooLongName; > + usri.usri1_password = (LPWSTR) sTestUserOldPass; Just drop the 'const' modifier for the declared strings, don't use casts. There was a lot of efforts lately put into fixing Wine to compile cleanly with -Wcast-qual turned on, please fix the code while you are at it. -- Dmitry.

1 0

SoC idea: Tablet PC support (was: pressure sensitive tablet support)
by Dan Kegel 24 Mar '07

24 Mar '07

On 3/21/07, Dan Kegel <dank(a)kegel.com> wrote: > While looking around for a project idea, I noticed that people > are starting to ask for pressure sensitive tablet support in > Photoshop on Wine. Seems like it could be a fun project > for some Summer of Code student. Update: wintab32 is already implemented in Wine, but there's a new API being pushed by Microsoft for Tablet PC applications. So the idea is instead "Get Tablet PC applications working on Wine", focusing on Tablet PC apps that offer pressure sensitivity, say. (I thought that FIrefox's GeckoTip extension used the new tablet PC APIs, but after looking at the source, I'm not so sure... I'm sure there are lots of good demo apps somewhere.) This assumes that Tablet PC apps don't yet work on Wine. I haven't tried... the place to start is probably to get the Tablet PC SDK (a free download if you have Windows) and start playing with it. - Dan

2 1

Winebot
by Vit Hrachovy 23 Mar '07

23 Mar '07

Hi all, first thanks for a lot of comments. I interpret this as a creative discussion helping to shape WINE project attitude to Winebot and Winebot project itself. I'll let Karl Lattimer to state his attitude with his Wine-Doors project. In the following words, I'm going to discuss my personal point of view, as I'm representing Winebot project. I'll first summarize some points extracted from the previous discussion: -------------------------------------------------- 1. My goal in writing Winebot is to help Wine succeed 2. I pledge to use only the bare minimum of native DLLs in any Winebot recipe 3. I pledge to remove native DLLs from Winebot recipes as soon as Wine fixes the bugs that keep Wine's DLLs from being sufficient for that app 4. I will report bugs to the Wine project in the course of working on Winebot 5. Installation of "basic compatibility programs" sounds like it would clash with "only use the bare minimum of native DLLs / hacks in any Winebot recipe". Winebot shouldn't install anything that the application does not need. 6. I will help Wine by writing not just Winebot recipes, but also basic application regression test scripts 7. If developers working on projects such as Wine-Doors contributed to Wine, then the bugs would be fixed even faster. 8. If you are making it extremely easy for users to run with native dlls and hacky workarounds, then you are hurting Wine. Wine is still beta, and we need as much testing and bug reporting as possible. In short, you leech off the hard work of all the Wine developers and give nothing back in return (quite the opposite in fact). -------------------------------------------------- Analyzing the objections written in discussion, I've found that you are missing the following: a) Clear statement, which will specify Winebot project's goals and attitude to its parent project - WINE. Sort of manifest. b) Results - working and actively supported regression testing scripts suite. c) Forwarding bugs and list of 'unclean' fixes to bugs.winehq.org. As I'm Debian and Ubuntu user I actively borrow knowledge from the Debian project. Each Winebot package shall have a maintainer responsible for package quality and for interfacing with WINE project(AppDb, Bugzilla, Testing, Fixing). Every official Winebot maintainer will be bound by sort of Winebot manifest stating the Winebot project's attitude to WINE project. I'll write the manifest (a),(c) and post it onto Winebot Wiki. To create (b) I gladly accept any input to create a regression test repository, would You be so kind and point me to some list of programs / test miniprograms to make a reference implementation? -------------------------------------------------- 1. My goal _is_ to help Wine succeed. Hours I'm investing in Winebot are hours I'm spending on learning Wine. Recent discussion about missing reg.exe implementation originated from work on Winebot. I'm application maintainer on AppDb. I'm testing application compatibility on WINE versions back to 0.9.9. I've written Winebot especially to make the testing easier. I often install and uninstall Windows programs from WINE bottles, I'm used to bottles (WINEPREFIX) system, too. Having the installation of programs (and their dependencies) scripted is the first step for making automated testing. 2., 3., 4. All Winebot packages should install only minimum neccessary dependencies and their install scripts should be ideally only using normal application Windows installer. Any hacks above will be reported (in case they weren't reported already) to WINE bugzilla. 5. That's a relict from winetools project. 'bottle initialization' will be removed soon as unnecessary. Working package dependencies allow to reconstruct every step of setup and every 'hack' in used packages. 6. Yes, I'm planning to set up a regression tests repository for WINE (and for Winebot too). As Winebot is using AutoHotKey system for installer automation, it can also run programs, check window properties and contents, click on specified button or areas, etc. For more information, see http://www.autohotkey.com 7. Actually I consider my Winebot work is a work for WINE project and WINE users. If I find some error in WINE, I report. Same when I need new functionality. If I'm capable, I'm trying to discuss, implement and send a patch for WINE. Actually Winebot could help more WINE developers with testing, with testing environment setup and with duplicating bug cases, IMHO. 8. User simply wants his application to work. Package maintainer, who prepares the package, should interface with WINE developers whenever he spots a glitch. Package maintainer goes with new WINE versions and prepares a package for each WINE version. Package maintainer is therefore dedicated regular WINE tester and bug reporter. Package maintainer also filters user feedback to create a useful bug report, probably with a patch proposal in ideal situation. Best regards Vit Hrachovy

2 1

re: Road to 1.0
by Dan Kegel 23 Mar '07

23 Mar '07

Rob wrote: > I think the only viable way to drive for 1.0 is feature or applications > targets, with applications compatibility driving test cases and bug fixing. Yes indeedy. And the only reason I haven't jumped up and posted a proposed list of applications to support for 1.0 is that real app testing is gobs of work, more than we have resources for. The tests at http://cxtest.org could be an important part of the equation. FWIW, a couple of us have been puttering away on a scheme to make writing application regression testers easier. No promises, though. - Dan

10 23

Is anyone using "wrc --verify-translation"?
by Mikołaj Zalewski 23 Mar '07

23 Mar '07

For my translations statistics (http://pf128.krakow.sdi.tpnet.pl/wine-transl/) I use a patched wrc that has a different output for "wrc --verify-translation". Could I send this patch to wine-patches or is there someone other using "wrc --verify-translation" and would be upset if the format changes (in such a case I could try to keep both formats lauched by different options)? I'm asking because I've contacted Jeremy Newman about integrating the statistics with WineHQ and having the patch in the official tree would probably simplify the maintenance. Mikolaj Zalewski

1 0

Re: Add d3drmdef.h header file - try 4
by Dmitry Timoshkov 23 Mar '07

23 Mar '07

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > Fix the D3DRMAPI definitions (Dimitry's Comments) > Fix the inclusion of d3dtypes.h (Francois' Comments) Where other comments has gone, into a black hole? > Changelog > ---------------- > Add d3drmdef.h header file, required for d3drm implementation This version is absolutely broken and unusable. -- Dmitry.

1 0

WinRAR installer icon creation, and the Start Menu folder
by Tom Spear 23 Mar '07

23 Mar '07

Yet another topic about the start menu, I know. This one is just a curiosity really. Why, if we create folders like Desktop and My Documents, under the fake windows directory, do we not create a Start Menu folder? I ask because WinRAR's installer looks for the Start Menu folder in various locations, but does not create it. If it doesn't find it, then it falls back to placing the WinRAR folder that should go under Start Menu\Programs into the Program Files\WinRAR folder, same for the WinRAR icon that should go under the main Start Menu folder. This causes the icons to not get created under the xorg menu, even during wineboot. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 4

Re: wined3d: Implement support for projective textures in ps 2.0 and later
by H. Verbeet 23 Mar '07

23 Mar '07

On 23/03/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > +#define D3DSI_TEXLD_PROJECTED 0x00010000 This should be called WINED3DSI_TEXLD_PROJECTED, and should be added to wined3d_private_types.h, together with the other WINED3DSI defines. Also, please add a comment that texldp always divides by the fourth component.

1 0

Re: [netapi32/tests] Use LoadLibrary where needed and skip
by Kai Blin 23 Mar '07

23 Mar '07

On Friday 23 March 2007 11:38, Paul Vriens wrote: > access.c currently has fixed tests for 'Administrator'. This will > obviously fail on systems with a different locale or system where > Administrator has been renamed. (Added a FIXME). I'll be looking into that shortly. Thanks for the other fixes. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Review of wine/crossover
by Dan Kegel 23 Mar '07

23 Mar '07

Another "jouralist tries linux" article. This one's pretty good. http://www.computerworld.com/action/article.do?command=viewArticleBasic&art… Her first complaint is that NoteTab Pro doesn't start when installed with Crossover. The app is $30 at http://www.notetab.com/ and sadly the free demo doesn't show the problem. The exact page where she complains about NoteTab Pro is page 3, http://www.computerworld.com/action/article.do?command=viewArticleBasic&art… - Dan

2 1

Re: [1/7] - [6/7] wined3d: Implement linear fog with pixel shader and some other patches
by Mirek 23 Mar '07

23 Mar '07

Perfect work!! nVidia VertexMorph demo is fixed and some other games too. Mirek

2 1

Re: Allow enabling/disabling Direct3D usage of GLSL in Winecfg
by H. Verbeet 23 Mar '07

23 Mar '07

On 22/03/07, Vit Hrachovy <vit.hrachovy(a)sandbox.cz> wrote: > Hi, > according to thread 'WineCfg and DirectX options' at wine-devel, I'm > proposing a patch for winecfg to allow enabling/disabling usage of GLSL > for Direct3D applications rendering. Patch will add a checkbox into > Graphics -> Direct 3D section of Winecfg. > IMO this doesn't belong in winecfg. Nevertheless, if you want to do this, you should change the resources for languages other than English as well.

2 1

Supreme Commander Up and running!
by Stephan Rose 22 Mar '07

22 Mar '07

I've got SC up and running, had to apply that font patch (that moving into the source anytime soon btw? It does work nicely). So looking at my debug output at stuff that's got errors or fixme's, I came across this little line: fixme:file:ReplaceFileW Figure, that'd be as good as a start as any as something for me to implement. Easy to test too....just before I dive into it, anyone potentially already working on it (or is there a good way to check)? Figured I'd ask first before 2 people work on the same thing. Stephan

7 20

Improving DirectDraw OpenGL renderer for SoC?
by Alexander Nicolaysen Sørnes 22 Mar '07

22 Mar '07

Greetings, i am thinking about participating in the Summer of Code, and thought it would be interesting to improve DirectDraw such that Command & Conquer Tiberian Sun & Red Alert 2 run faster. Currently, they crash once the mouse is moved in-game when OpenGL rendering is enabled. Thus the project would involve fixing that bug, and then other performance issues/crashes that occur. However, I don't really have much experience with C and Wine. The closest I have gotten is some patches for Wine's WordPad implementation. Would it be feasible to acquire the necessary knowledge and fix the bugs before the end of summer? Regards, Alexander N. Sørnes

3 4

SoC idea: add BITS support
by Dan Kegel 22 Mar '07

22 Mar '07

Several applications require BITS (Background Intelligent Transfer Service). Adding an implementation of BITS would be quite useful. http://www.darvin.de/english/ is an interactive front end for BITS. The other apps I know of that require it are Visual C# Express 2005 and Google Pack, but there are probably more. - Dan

5 7

SoC idea: Get Java working well enough to run Tomcat, installers, etc.
by Dan Kegel 22 Mar '07

22 Mar '07

There are a lot of little bits in Wine that are missing before Java can run smoothly. (Yes, Virginia, we need win32 JVMs to run in Wine, for many reasons: some installers require them, some apps bundle them, and some people just plain want to run the win32 version of some apps because that's what they're used to.) For instance, this bug says that we need to implement a little bit of IPv6 support to get Tomcat running: http://bugs.winehq.org/show_bug.cgi?id=7069 And http://bugs.winehq.org/show_bug.cgi?id=6380 says we have some bug in msvcrt that keeps some versions of Java from running. This would be very useful indeed, because of the installers that require Java. - Dan

1 0

DIB engine and cairo
by Alessandro Pignotti 22 Mar '07

22 Mar '07

Hi everyone, i'm not a dib engine nor a cairo expert, so i don't know if this is totally crazy. Anyway, could it be possible to use cairo as a backend for our dib engine? cairo support drawing on image buffers, that should be device indipendent and rendered client side. Regards, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

SoC: improving Star Wars Empire at War support
by Bryan DeGrendel 22 Mar '07

22 Mar '07

I have been thinking about a few different ideas for WINE/SoC. One of the official possible ideas is to improve a non-working application. My proposal would be to improve WINE's support for Star Wars: Empire at War (which currently has a garbage rating on both WINE [ http://appdb.winehq.org/appview.php?iVersionId=4616 ] and Cedega [ http://transgaming.org/gamesdb/games/view.mhtml?game_id=3795 ]). The proposal's goal would be to provide a Windows-native level of support for Empire at War, or at least improve Empire at War support to a playable level. I would like a some feedback, if possible, before submitting. 1. Is this a weaker, or less useful to WINE, proposal because it would lead to likely result in more bug hunting than feature writing? This is quite a bit more open ended than working on a specific WINE feature (such as Rich Text Editing). 2. I do not know how much work will be needed to get the game working well. Currently, it crashes while loading due to an audio bug, but it is possible that I might only need to fix a few bugs to get the game to a playable state (though I think this is unlikely, the game is seems very picky on Windows). Would this be a problem? Bryan DeGrendel

2 1

Re: [5/7] wined3d: Fix glsl texbem instruction for projective textures
by H. Verbeet 22 Mar '07

22 Mar '07

On 22/03/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > + shader_addline(arg->buffer, "T%u%s /= T%u%s;\n", sampler_idx, coord_mask, sampler_idx, coord_div_mask); > Are you sure that's correct? This will modify the coordinates for later instructions as well.

2 2

Build script for older RPM distros
by Lei Zhang 22 Mar '07

22 Mar '07

Hi, It looks like we have not been doing a good job of maintaining Wine RPMs for older RH (derived) systems. On the Wine download page (http://www.winehq.org/site/download) the text link for RH/Fedora is a 404, and the icon links to an out of date page: http://www.winehq.org/site/download-rh. Does anyone want to do the builds for these systems? I wrote a script to automate building RPMs for RH 9 / RHEL 3 / CentOS 4. The script checks against the git web interface for the latest version of Wine, and it will download and build Wine if it finds a new release. One just need to have a working copy of the target OS and put the script in a cron job. http://linux.ucla.edu/~leiz/software/wine/wine_rpmbuild.sh.txt - Lei

2 1

netapi32 tests not linked with netapi32.dll
by Paul Vriens 22 Mar '07

22 Mar '07

Hi, Could anyone think of a reason that the netapi32 tests are not linked with netapi32.dll although this is specified in the Makefile? I just had a look with PE Explorer at the crosstest executable and it didn't contain the netapi32.dll. The ds-test now skips all these tests on both Wine and Windows as I've changed that test to use GetModuleHandle instead of LoadLibrary (and this obviously failed). This also means it's not only the crosscompiling that fails to link. Cheers, Paul.

2 2

automatically running wineprefixcreate
by Tom Spear 22 Mar '07

22 Mar '07

I was looking into my issues with menubuilder and trying to figure out ways to make the setup automatic so that everything would go where it should (since I know how to manually make wine put things in the proper place), and I noticed that no matter how wine is invoked (wine, winecfg, wineboot, winemine, notepad etc), if there is no ~/.wine it runs wineprefixcreate _first_ in order to create it. Currently in order to fix my issues, I have to re-run wineprefixcreate after running winecfg to make sure the directories and files are put in the place I have my fake c located. Would it be possible to make winecfg run wineprefixcreate one more time after the ok and apply buttons are pressed so that users dont have to manually run it when they use winecfg? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

6 13

Problem with program
by Guillén Cambil, Enrique 22 Mar '07

22 Mar '07

Using wine "memoriesontv" it does not show the images and the generation of video interrupts

2 1

Re: SoC idea: add BITS support
by Juan Lang 22 Mar '07

22 Mar '07

> Anyway, I don't know what shape our iphlpapi is in, but I think it > should be possible to at least get the basic features working in the > context of a SoC project. Okay, I'll bite. I looked at the BITS docs too, and it uses GetBestInterface to pick an interface, and some interface stats to determine how busy an interface is. Our iphlpapi should be up to the task (but maybe that's just a parent's pride ;) ) --Juan ____________________________________________________________________________________ No need to miss a message. Get email on-the-go with Yahoo! Mail for Mobile. Get started. http://mobile.yahoo.com/mail

2 1

Sugestion: A few changes to the
by Giles Cameron 22 Mar '07

22 Mar '07

After learning about the wine debuging output's level system, and seeing it be used for a while, I think its time we make a couple of new channels. They would be like the 'trace' channel, only for more spefic purposes, these could by default be compiled out, but when needed put in. Their primary purpos would be for tracking down bugs in the API, ones that may not be as easy to find in a test case. Any thoughts? Also, if more channels is not the way to go, maybe per-function filtering? Thanks for the time, Giles Cameron

4 5

Re: dplayx: corrected the way nameserver initializes the sessiondesc structure on broadcast request reply
by Kai Blin 22 Mar '07

22 Mar '07

On Thursday 22 March 2007 17:20, Alessandro Pignotti wrote: > Whitout this patch the directplay nameserver does not fully copy the > Session Description structure when replying to session request broadcast Good catch. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: [netapi32/tests] Use GetModuleHandle and skip
by Paul Vriens 22 Mar '07

22 Mar '07

Paul Vriens wrote: > Hi, > > netapi32 is already linked to. > > Changelog > Use GetModuleHandle and skip > > Cheers, > > Paul. > > > ------------------------------------------------------------------------ > >>From 6595fe64b93f2a81b4f6cbf77df58b2ef67c29ae Mon Sep 17 00:00:00 2001 > From: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> > Date: Fri, 16 Mar 2007 12:00:08 +0100 > Subject: [PATCH] Use GetModuleHandle and skip > > --- > dlls/netapi32/tests/ds.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/dlls/netapi32/tests/ds.c b/dlls/netapi32/tests/ds.c > index 7d0413d..7ee8a73 100644 > --- a/dlls/netapi32/tests/ds.c > +++ b/dlls/netapi32/tests/ds.c > @@ -78,15 +78,12 @@ START_TEST(ds) > { > HMODULE hnetapi32; > > - hnetapi32 = LoadLibraryA("netapi32.dll"); > - if (!hnetapi32) > - return; > + hnetapi32 = GetModuleHandleA("netapi32.dll"); > > - SetLastError(0xdeadbeef); > pDsRoleGetPrimaryDomainInformation=(void*)GetProcAddress(hnetapi32,"DsRoleGetPrimaryDomainInformation"); > if (!pDsRoleGetPrimaryDomainInformation) > { > - trace("DsRoleGetPrimaryDomainInformation not implemented : (%d), stop testing\n", GetLastError()); > + skip("DsRoleGetPrimaryDomainInformation is not available\n"); > return; > } > pDsRoleFreeMemory=(void*)GetProcAddress(hnetapi32,"DsRoleFreeMemory"); Hi, this patch is already committed but something is wrong. For some reason GetModuleHandleA doesn't return a handle. Does anyone know why? The Makefile.in contains: IMPORTS = netapi32 advapi32 kernel32 Cheers, Paul.

1 0

x11drv: XDND: Fix file drop to properly support file:/// URIs (debugging problem)
by Maciej Katafiasz 22 Mar '07

22 Mar '07

Hi, (please ignore the other copy I sent from the wrong address by accident) I'm working on a bug in winex11drv/xdnd.c, where file:/// URIs are not correctly interpreted, resulting in DnD broken most of the time. There are two parts of that bug: 1) X11DRV_XDND_BuildDropFiles() fails to properly handle absolute unix paths, which is exactly what you get from file:///, so it won't find the file unless $PWD and the constructed Windows drive-absolute path happen to have the same root. For example, file:///home/mathrick/foo.txt will yield "\\home\\mathrick\\foo.txt" and work only if the current directory is on a drive letter on which that path is valid. 2) X11DRV_XDND_DeconstructTextPlain() fails to accommodate for the fact file:/// URIs are, in fact, URIs and not paths, and doesn't check for validity nor does it unescape % sequences. The result is that paths with spaces, etc. in them won't work. The attached patch is my first take at 1), it works, but there is a problem. My test application is μTorrent, and it'll randomly lock up with the following errors printed: err:ntdll:RtlpWaitForCriticalSection section 0x110020 "heap.c: main process heap section" wait timed out in thread 001f, blocked by 0019, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110020 "heap.c: main process heap section" wait timed out in thread 001e, blocked by 0019, retrying (60 sec) I can reproduce them by attempting to drop a file on µT's window right after startup. If I wait a while, it works. It also happens if I switch to another virtual desktop, then back to the one µT is on and then try to drop. I tried to check the code as well as I could (win32 API is not exactly my everyday environment), and I believe it's correct. At least all the allocations appear to be correct, nothing is overwritten. I've tried debugging in several ways using winedbg, but it fails pretty hard with various exceptions that aren't there when running outside the debugger, or fails to attach to the process, etc. From the circumstances, I believe there's some kind of race condition in allocation from process heap. However, I'm unable to find it as I have no idea about wine internals and how exactly DnD happens, and what threads do what and when. I'd be therefore very grateful if someone knowledgeable would take a look at it and see what's wrong, or at least help me with debugging the issue, as my ideas how to attack it have run out. Cheers, -- Being really good at C++ is like being really good at using rocks to sharpen sticks. (Thant Tessman) -------- Maciej Katafiasz <ml(a)mathrick.org> http://mathrick.org

5 5

Fwd: kernel32: Implement ReplaceFileA/ReplaceFileW (revised)
by Erich Hoover 22 Mar '07

22 Mar '07

Request for comments, as per http://www.winehq.com/site/sending_patches. Thanks! Erich Hoover ehoover(a)mines.edu ---------- Forwarded message ---------- From: Erich Hoover <ehoover(a)mines.edu> Date: Mar 3, 2007 2:37 PM Subject: kernel32: Implement ReplaceFileA/ReplaceFileW (revised) To: wine-patches(a)winehq.org Real Name: Erich Hoover Description: Implements the functions ReplaceFileA and ReplaceFileW in kernel32 (Bug #7544). This revision includes a lot of changes as a result of feedback from Felix, see wine-devel for details. Also provides conformance test code to ensure proper functionality. Changelog: kernel32: Implement ReplaceFileA/ReplaceFileW

2 2

Regedit output to STDOUT / force registry files sync
by Vit Hrachovy 22 Mar '07

22 Mar '07

Hi, I'm trying to find some elegant method to access registry keys added during one WINE session, i.e. without restarting WINE. Test case description: 1. Open WINE session wineconsole --backend=user cmd 2. During session, insert some new registry key regedit new-entry.reg 3. Try to access the new registry entry from bash cat ~/.wine/system.reg |grep AutoHotkey (fails) 4. Close WINE session I've found there was at times an option to save registry periodically, but this can't help me here. This problem can be solved in two ways, both of them can be helpful: a) Create small program to force sync of registry in memory with registry files - 'wineflushregistry'. b) Enhance regedit to be able to output to STDOUT. By default registry search output is done to a specified file. It can be redirected to STDERR, though. (tested on 0.9.29, 0.9.33) Enhancing regedit ----------------- regedit /es "HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\App Paths\AutoHotkey.exe" which will be similar to (non-functional) regedit /e /dev/stdout "HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\App Paths\AutoHotkey.exe" Regards Vit Hrachovy

4 11

Deadline for Summer of Code is March 26th!
by Dan Kegel 22 Mar '07

22 Mar '07

Watch out, those deadlines can creep up on you! If you're a student interested in working on Wine as part of Google's Summer of Code, you have only five or so more days to apply. See http://code.google.com/soc or http://groups.google.com/group/google-summer-of-code-announce/web/guide-to-… for more details. And see http://wiki.winehq.org/SummerOfCode for a few ideas. Feel free to post your ideas to wine-devel first for quick feedback. So far, there are only two applications, both of which look pretty good. We will probably have more than two slots, so it's wide open right now! Sharpen your pencils, and good luck! - Dan

2 2

SoC idea: pressure sensitive tablet support
by Dan Kegel 22 Mar '07

22 Mar '07

While looking around for a project idea, I noticed that people are starting to ask for pressure sensitive tablet support in Photoshop on Wine. Seems like it could be a fun project for some Summer of Code student. - Dan

1 0

x11drv: XDND: Fix file drop to properly support file:/// URIs (debugging problem)
by Maciej Katafiasz 22 Mar '07

22 Mar '07

Hi, I'm working on a bug in winex11drv/xdnd.c, where file:/// URIs are not correctly interpreted, resulting in DnD broken most of the time. There are two parts of that bug: 1) X11DRV_XDND_BuildDropFiles() fails to properly handle absolute unix paths, which is exactly what you get from file:///, so it won't find the file unless $PWD and the constructed Windows drive-absolute path happen to have the same root. For example, file:///home/mathrick/foo.txt will yield "\\home\\mathrick\\foo.txt" and work only if the current directory is on a drive letter on which that path is valid. 2) X11DRV_XDND_DeconstructTextPlain() fails to accommodate for the fact file:/// URIs are, in fact, URIs and not paths, and doesn't check for validity nor does it unescape % sequences. The result is that paths with spaces, etc. in them won't work. The attached patch is my first take at 1), it works, but there is a problem. My test application is μTorrent, and it'll randomly lock up with the following errors printed: err:ntdll:RtlpWaitForCriticalSection section 0x110020 "heap.c: main process heap section" wait timed out in thread 001f, blocked by 0019, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x110020 "heap.c: main process heap section" wait timed out in thread 001e, blocked by 0019, retrying (60 sec) I can reproduce them by attempting to drop a file on µT's window right after startup. If I wait a while, it works. It also happens if I switch to another virtual desktop, then back to the one µT is on and then try to drop. I tried to check the code as well as I could (win32 API is not exactly my everyday environment), and I believe it's correct. At least all the allocations appear to be correct, nothing is overwritten. I've tried debugging in several ways using winedbg, but it fails pretty hard with various exceptions that aren't there when running outside the debugger, or fails to attach to the process, etc. From the circumstances, I believe there's some kind of race condition in allocation from process heap. However, I'm unable to find it as I have no idea about wine internals and how exactly DnD happens, and what threads do what and when. I'd be therefore very grateful if someone knowledgeable would take a look at it and see what's wrong, or at least help me with debugging the issue, as my ideas how to attack it have run out. Cheers, -- Maciej Katafiasz <email(a)mathrick.org>

1 0

Re: [3/4] WineD3D: Store the pixel format in the texture
by H. Verbeet 21 Mar '07

21 Mar '07

Shouldn't this be done for volume textures as well?

2 1

Accessing File > 4gb problem (was: Debugging Supreme Commander)
by Stephan Rose 21 Mar '07

21 Mar '07

I apologize in advance if this ends up on the mailing list twice but..it's been over 12 hours now and my e-mail, as my previous (but now unimportant one) still didn't make it so I am going to try to resend this. =) Allright, I've got the bug nailed to the wall with all of its 6 legs. What I don't know though is what to do about it. Still trying to find the right sledgehammer to squash it with.... Problem boils down to this: Supreme Commander has a .cab file that is just under 6 gigs in size. 0x178d42fce bytes to be exact Now here are the last 5 file seek positions in order from first to last: 0x0ff697fb4 0x0ff69800b 0x0ffebc19a 0x0ffebc1f0 All those succeed fine. But #5 ... 0x1007bc160 results in NTSTATUS c000000d, Invalid Parameter. That address is well within the range of the file though. The status occurs when lseek is called in this part of NtSetInformation, don't mind my added debug fixme's =) case FilePositionInformation: if (len >= sizeof(FILE_POSITION_INFORMATION)) { const FILE_POSITION_INFORMATION *info = ptr; unsigned int* iptr = (unsigned int*)&info->CurrentByteOffset.QuadPart; FIXME( "%i, 0x%08x%08x\n", fd, *(iptr+1), *iptr); if (lseek( fd, info->CurrentByteOffset.QuadPart, SEEK_SET ) == (off_t)-1) { FIXME("Bad result from lseek"); // Above fixme triggered past 4gb io->u.Status = FILE_GetNtStatus(); } } else io->u.Status = STATUS_INVALID_PARAMETER_3; break; I checked sizeof(off_t) and it correctly reports as 8-bytes, so I am not sure what the problem is and why this is happening. I know my system can handle files > 4 gigs....wine dumped 9 gigs of relay output onto my hard drive the first time I played with that debug channel =P Any ideas? On a bright note...I almost have my Supreme Commander CD Key memorized now...how many people can say that!!! ;) Thanks, Stephan

3 4

Debugging Supreme Commander Installer
by Stephan Rose 21 Mar '07

21 Mar '07

I've been playing around with the supreme commander install most of today trying to figure out why it does not want to install. Running with +file,+msgbox and noticed the following error for virtually all files: warn:file:wine_nt_to_unix_file_name L"TUB500.xsb" not found in /home/stephan/.wine/dosdevices/c:/Program Files/THQ/Gas Powered Games/Supreme Commander/sounds/Voice/fr/Tutorials This is the file being copied when I get the "Error 87" message from Install shield. Also, pretty much every file, if not every file, gives the same trace in the debug log. It's weird that install shield will copy hundreds of files with that warning in their trace and not complain until it is 80% through. So then I wondered, is that really the cause or not? I think yes. Install shield appears to be kind enough to not re-copy the files if they already exist, so I killed the process to keep all files already copied and added the one missing file above from my windows install and then ran install shield again. This time around, the file was processed correctly and no error. Instead it gives the error now on the next file, which is TUB500.xwb. Some more trace below: trace:file:GetFileAttributesW L"c:\\Program Files\\THQ\\Gas Powered Games\\Supreme Commander\\sounds\\Voice\\fr\\Tutorials\\TUB500.xwb" trace:file:RtlDosPathNameToNtPathName_U (L"c:\\Program Files\\THQ\\Gas Powered Games\\Supreme Commander\\sounds\\Voice\\fr\\Tutorials\ \TUB500.xwb",0x334b84,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"c:\\Program Files\\THQ\\Gas Powered Games\\Supreme Commander\\sounds\\Voice\\fr\\Tutorials\\TUB500.xwb" 520 0x3348f8 (nil)) warn:file:wine_nt_to_unix_file_name L"TUB500.xwb" not found in /home/stephan/.wine/dosdevices/c:/Program Files/THQ/Gas Powered Games/Supreme Commander/sounds/Voice/fr/Tutorials trace:file:MoveFileWithProgressW (L"",(null),(nil),(nil),0004) trace:file:RtlDosPathNameToNtPathName_U (L"",0x3348b8,(nil),(nil)) trace:file:GetFileAttributesW L"c:\\Program Files\\THQ\\Gas Powered Games\\Supreme Commander\\sounds\\Voice\\fr\\Tutorials\\TUB500.xwb" trace:file:RtlDosPathNameToNtPathName_U (L"c:\\Program Files\\THQ\\Gas Powered Games\\Supreme Commander\\sounds\\Voice\\fr\\Tutorials\ \TUB500.xwb",0x334800,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"c:\\Program Files\\THQ\\Gas Powered Games\\Supreme Commander\\sounds\\Voice\\fr\\Tutorials\\TUB500.xwb" 520 0x334574 (nil)) warn:file:wine_nt_to_unix_file_name L"TUB500.xwb" not found in /home/stephan/.wine/dosdevices/c:/Program Files/THQ/Gas Powered Games/Supreme Commander/sounds/Voice/fr/Tutorials Followed by this resulting in the error message box: trace:file:RtlDosPathNameToNtPathName_U (L"C:\\windows\\temp\ \{62CDECF0-D5B2-11DB-C687-0018F32E4A94}\ \ISSetup.dll",0x341404,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"C:\\windows\\temp\ \{62CDECF0-D5B2-11DB-C687-0018F32E4A94}\\ISSetup.dll" 520 0x3411c4 (nil)) trace:file:wine_nt_to_unix_file_name L"\\??\\C:\\windows\\temp\ \{62CDECF0-D5B2-11DB-C687-0018F32E4A94}\\ISSetup.dll" -> "/home/stephan/.wine/dosdevices/c:/windows/temp/{62CDECF0-D5B2-11DB-C687-0018F32E4A94}/ISSetup.dll" trace:file:RtlGetFullPathName_U (L"C:\\windows\\temp\ \{62CDECF0-D5B2-11DB-C687-0018F32E4A94}\\ISSetup.dll" 522 0x34149e (nil)) trace:msgbox:MSGBOX_OnInit L"Error:\t87" So it seems that it freaks out because somehow the file appears in the directory tree late. I'm still trying to think of a way of reproducing this with a test case...but that won't be all that easy without knowing precisely what Install Shield is actually doing in their code! Any thoughts? Stephan Rose

4 4

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Alexandre Julliard 21 Mar '07

21 Mar '07

Robert Shearman <rob(a)codeweavers.com> writes: > I've also modified tools/makerule to respect the "-s" flag passed into make. > > Alexandre suggested on IRC that I always print the destination file, > but I want to make sure that the technical details of this patch are > acceptable before making tweaks to the printed commands. I've been thinking about this some more, and I don't think I'll put it in. It's going to cause a lot of trouble and portability headaches, for only a minor cosmetic gain. This thing really belongs in make itself; it shouldn't be hard to patch GNU make to have a mode where it only displays the command name and target instead of the whole command line. Then it would work for all projects, and wouldn't require adding complexity to the makefiles. -- Alexandre Julliard julliard(a)winehq.org

2 4

Link creation not working _properly_ under 2.6 kernel?
by Tom Spear 21 Mar '07

21 Mar '07

Hi all, I just got Slackware 11, and have a couple issues with link creation. I cant say that this worked with 10.2 either though, as I havent had a Linux machine in about a year, since the motherboard died on my last one.. The first issue is that regardless of which kernel I use, the Desktop link doesn't have the WinRAR icon, just the default blank paper KDE icon, and the menu entries have no icons at all. Second, with 2.4 the icon is created and put on my desktop, but with 2.6 it is created and put where I have Drive C pointed to in winecfg. Third, with 2.4 the menu entries are put in the menu under the wine folder, but with 2.6 they are put under the installdir of the app. I am using 0.9.32, as I cannot download the git version due to the corporate firewall, and transparent web proxy.. If needed I can create a bug for this issue, and as soon as I get a free minute I will reinstall and get the debug messages. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

4 18

Re: Enlarge max. length of PATH variable in programs/cmd/wcmdmain.c
by Ann & Jason Edmeades 21 Mar '07

21 Mar '07

>However according to http://support.microsoft.com/kb/830473 : "the total length .... >cannot contain more than either 2047 or 8191 characters (as appropriate to your >operating system)" I'd suggest changing it to MAXSTRING which is used throughout cmd to refer to a 'big' string (of 8192 chars). At least this way you can grow the max line length simply! >PS: I think char string[1024]; in the main() should be extended > to char string[2048]; as well! (please see the MS note above) Yes, I'd agree (to MAXSTRING, but change the 1024 in at least one of the calls appropriately as well) Jason

2 1

Re: wined3d: Check for float texture formats correctly.
by H. Verbeet 21 Mar '07

21 Mar '07

On 21/03/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > Move the checks for float texture formats into the correct location. > This allows some Direct3D sample applications to start up which check > for any of the float formats together with D3DUSAGE_RENDERTARGET. > --- That's better, but now those formats can only be used with render targets. I don't think that's correct, since they were probably added in the other place to make some application work.

2 2

wine opinion of a user
by Vijay Kiran Kamuju 21 Mar '07

21 Mar '07

Hi, http://www.selfadhesivelabels.com/blog/2007/03/20/windos-software-that-we-d… This is a response from a user. Can any one order and test sage 50 line business s/w. And other s/w. Dan, you can redirect them to appdb. Thanks, VJ

4 5

Re: wine opinion of a user
by Nicholas van Rheede van Oudtshoorn 21 Mar '07

21 Mar '07

I imagine the Australian version would do just as well. Here's a page where you can request a download demo: http://www.sagepastel.com.au/au/form_demodownload_request.html I'd do it myself here, but this account that I'm using today is only dialup. Nicholas

1 0

last year's email
by Bill Medland 21 Mar '07

21 Mar '07

Is there something wrong with the list server? I am being bombarded with last year's emails. Bill Medland

5 6

Re: wined3d: Check for float texture formats correctly.
by Dmitry Timoshkov 21 Mar '07

21 Mar '07

"Vitaly Budovski" <vbudovski(a)gmail.com> wrote: > @@ -1662,6 +1662,20 @@ static HRESULT WINAPI IWineD3DImpl_Check > case WINED3DFMT_P8: > TRACE_(d3d_caps)("[OK]\n"); > return WINED3D_OK; > + case WINED3DFMT_R16F: > + case WINED3DFMT_A16B16G16R16F: > + if (!GL_SUPPORT(ARB_HALF_FLOAT_PIXEL)) { > + TRACE_(d3d_caps)("[FAILED]\n"); > + return WINED3DERR_NOTAVAILABLE; > + } I realize that in the original chunk of code there is no a comment /* fall through */ either, but if it's really an intent please add it. > + case WINED3DFMT_R32F: > + case WINED3DFMT_A32B32G32R32F: > + if (!GL_SUPPORT(ARB_TEXTURE_FLOAT)) { > + TRACE_(d3d_caps)("[FAILED]\n"); > + return WINED3DERR_NOTAVAILABLE; > + } > + TRACE_(d3d_caps)("[OK]\n"); > + return WINED3D_OK; -- Dmitry.

1 0

On bugs and docs
by Tom Spear 21 Mar '07

21 Mar '07

Hi all, just some quick questions. Is it just me or has anyone else noticed that the documentation for wine is kind of scattered all over the place? I mean personally I can name about 8 different places (that are affiliated with winehq) that people can go to get information, not including the mailing lists. IMHO if it were even possible to consolidate all of the information, it would still take months to do, especially with people not knowing to post to the central location. Also, is it against the rules in bugzilla to try to organize the bugs some way? IOW The very old games metabug that I created (bug 1434).. I originally opened it not realizing that if every bug related to a game was attached the page would become overloaded. So I decided a year or two ago to close it. Then I recently realized how I could reorganize it and decided to reopen it, only to have it closed again by someone else who in not so many words told me that I was spamming the bug list and that I was annoying everyone. Basically my idea was to make several tasklists to link to 1434 (bugs like dinput9, d3d8, etc), and then link individual games to each of those, so that someone working on games, and in specific on dinput9 for example could easily find bugs related to dinput 9 without having to do a query. But now I am worried that I am overstepping my bounds by trying to do so. Does anyone _else_ object to this idea? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

5 12

Re: comctl32: CreateToolbarEx should send TB_SETBITMAPSIZE twice (fixes bug #6392)
by James Hawkins 20 Mar '07

20 Mar '07

On 3/19/07, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > As can be seen in Spy++ and by the attached tests, CreateToolbarEx sends > TB_SETBITMAPSIZE twice instead of TB_SETBITMAPSIZE and TB_SETBUTTONSIZE. > ShellExViewer depends on this bug. The patch contains also some tests > and fixes for d[xy]Button <= 0. > > From c8a84900ae5d9ca7d77d443990e935b8c268bf4c Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 19 Mar 2007 10:40:53 +0100 > Subject: [PATCH] comctl32: CreateToolbarEx should send TB_SETBITMAPSIZE twice (fixes bug #6392) > > --- > dlls/comctl32/commctrl.c | 13 +++++++------ > dlls/comctl32/tests/toolbar.c | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/commctrl.c b/dlls/comctl32/commctrl.c > index c21cae3..7e44e03 100644 > --- a/dlls/comctl32/commctrl.c > +++ b/dlls/comctl32/commctrl.c > @@ -693,12 +693,13 @@ CreateToolbarEx (HWND hwnd, DWORD style, UINT wID, INT nBitmaps, > SendMessageW (hwndTB, TB_SETBITMAPSIZE, 0, > MAKELPARAM((WORD)dxBitmap, (WORD)dyBitmap)); > > - if (dxButton <= 0) > - dxButton = 24; > - if (dyButton <= 0) > - dyButton = 22; > - SendMessageW (hwndTB, TB_SETBUTTONSIZE, 0, > - MAKELPARAM((WORD)dxButton, (WORD)dyButton)); > + if (dxButton < 0) > + dxButton = dxBitmap; > + if (dyButton < 0) > + dyButton = dyBitmap; > + /* TB_SETBUTTONSIZE -> TB_SETBITMAPSIZE bug introduced for Windows compatibility */ > + if (dxButton != 0 && dyButton != 0) > + SendMessageW(hwndTB, TB_SETBITMAPSIZE, 0, MAKELPARAM(dxButton, dyButton)); > > > /* add bitmaps */ > diff --git a/dlls/comctl32/tests/toolbar.c b/dlls/comctl32/tests/toolbar.c > index 164644e..b583295 100644 > --- a/dlls/comctl32/tests/toolbar.c > +++ b/dlls/comctl32/tests/toolbar.c > @@ -869,6 +869,45 @@ static void test_sizes(void) > DestroyWindow(hToolbar); > } > > + > +static void test_createtoolbarex() > +{ > + HWND hToolbar; > + TBBUTTON btns[3]; > + ZeroMemory(&btns, sizeof(btns)); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 20, 20, 16, 16, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 20, 20); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0x1a001b, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 4, 4, 16, 16, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(32, 4, 4); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xa000b, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, 0, 8, 12, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 12, 12); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0x120013, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, -1, 8, 12, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 12, 8); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xe0013, "%x"); > + DestroyWindow(hToolbar); > + > + hToolbar = CreateToolbarEx(hMainWnd, WS_VISIBLE, 1, 16, GetModuleHandle(NULL), IDB_BITMAP_128x15, btns, > + 3, -1, 8, -1, 12, sizeof(TBBUTTON)); > + CHECK_IMAGELIST(16, 16, 8); > + compare((int)SendMessage(hToolbar, TB_GETBUTTONSIZE, 0, 0), 0xe0017, "%x"); > + DestroyWindow(hToolbar); > +} > + > + > START_TEST(toolbar) > { > WNDCLASSA wc; > @@ -899,6 +938,7 @@ START_TEST(toolbar) > test_add_string(); > test_hotitem(); > test_sizes(); > + test_createtoolbarex(); > > PostQuitMessage(0); > while(GetMessageA(&msg,0,0,0)) { > -- > 1.4.4.2 > If you're testing what message is sent, why not use the message sequence testing code? -- James Hawkins

2 1

Re: wine opinion of a user
by Ann & Jason Edmeades 20 Mar '07

20 Mar '07

> Sage Line 50 already has a bug filed: > http://bugs.winehq.org/show_bug.cgi?id=2956 > but we're hampered because there's no free demo for us to test. > You could register for a free trial cd? http://www.sage.co.uk/considering/TryNow.aspx?tid=213114

1 0

Road to 1.0
by Dave Bialac 20 Mar '07

20 Mar '07

Hi All I've been following the list for about a year now, just reading and learning. Through this process, I've come to wonder about the following question -- what should be the goal for Wine 1.0? I know a lot of development is focused around getting one particular application or another to work, especially from the folks over at Code Weavers, but with version numbers approaching 1.0, should there not be a set goal of functionality? My personal thought is that Wine should head in the direction of 100% compatibility with a particular version of Windows. Anything that ran on that version should run on Wine 1.0 with no problems. Any thoughts? Dave

3 2

re: Resend: Add d3drmdef.h header file - try 3
by Dan Kegel 20 Mar '07

20 Mar '07

Vijay wrote: >Resend. Please let me why this one has been dropped. I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan

5 8

Re: winex11.drv: GetDeviceCaps(hdc, NUMCOLORS) must return 1 (not -1) if more than 256 colors. Bug 7757
by James Hawkins 20 Mar '07

20 Mar '07

On 3/18/07, Daniel Mario Vega <dv5a(a)dc.uba.ar> wrote: > --- > dlls/winex11.drv/init.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winex11.drv/init.c b/dlls/winex11.drv/init.c > index cf23866..a60174d 100644 > --- a/dlls/winex11.drv/init.c > +++ b/dlls/winex11.drv/init.c > @@ -213,8 +213,8 @@ INT X11DRV_GetDeviceCaps( X11DRV_PDEVICE *physDev, INT cap ) > case NUMCOLORS: > /* MSDN: Number of entries in the device's color table, if the device has > * a color depth of no more than 8 bits per pixel.For devices with greater > - * color depths, -1 is returned. */ > - return (screen_depth > 8) ? -1 : (1 << screen_depth); > + * color depths, 1 is returned. */ > + return (screen_depth > 8) ? 1 : (1 << screen_depth); > case PDEVICESIZE: > return sizeof(X11DRV_PDEVICE); > case CURVECAPS: > -- > 1.4.4.4 > Please add a test case. -- James Hawkins

1 0

Being rude to users considered harmful
by Dan Kegel 20 Mar '07

20 Mar '07

Now, I'm as much of a BOFH as anybody else. Maybe more. But when I see a Wine developer telling users things like "For me all VB apps have to go to /dev/null without exceptions!" or "It's a minor problem - leave with it or fix it yourself!" I feel quite sad. Can we agree to be a bit more civil with the people who file bugs in bugzilla? Thanks... - Dan

4 3

Menu builder fix found
by Tom Spear 20 Mar '07

20 Mar '07

http://bugs.winehq.org/show_bug.cgi?id=7802 Basically all that should be done (and I dont know why this isnt done anyways) is to have wine (or more likely wineprefixcreate) make ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu and ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu/Programs .... Then also make winecfg _not_ default to creating ~/.wine/dosdevices/c:/windows/profiles/(user)/Desktop as a symlink to ~/Desktop.. This can be verified by starting with a clean .wine dir and clean ~/.wine/dosdevices/c: and running wineprefixcreate .. Then run winecfg and make sure to uncheck the Link to box for the Desktop shell folder in the Desktop Integration tab and apply the change. Then manually make ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu and ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu/Programs Then get the winrar installer and run it. Check all of the shortcut creation boxes after the install is finished. Then check the above mentioned folders. While I'm at it though I should mention that I have seen several installers fail if they can't find ~/.wine/dosdevices/c:/windows/system32 because for some reason wine doesn't create it either, not even as a symlink. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

RSTs from winehq.org
by Juan Lang 20 Mar '07

20 Mar '07

Anyone else getting lots of TCP resets from winehq.org since the maintenance? I don't see this at work - or, my connection there is too fast connection for them to appear - but at home, I have to have a great deal of patience to browse the site, as it takes repeated reloads to get a successful page load. Just curious if anyone else is similarly bedeviled. --Juan ____________________________________________________________________________________ Now that's room service! Choose from over 150,000 hotels in 45,000 destinations on Yahoo! Travel to find your fit. http://farechase.yahoo.com/promo-generic-14795097

4 7

Re: Moved detection of float texture formats higher up so they are checked before
by H. Verbeet 20 Mar '07

20 Mar '07

On 20/03/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > > the base formats. This is required to get the Blobs Direct3D demo to start. > --- > dlls/wined3d/directx.c | 33 +++++++++++++++------------------ > 1 files changed, 15 insertions(+), 18 deletions(-) > This looks questionable. By lack of a description in the patch, I'll assume it fails because it's checking with render target usage. If that's the case, you should fix that block, not move the float formats check up.

1 0

re: On bugs and docs
by Dan Kegel 19 Mar '07

19 Mar '07

Tom wrote: > Basically my idea was to make several tasklists to link to 1434 (bugs >like dinput9, d3d8, etc), and then link individual games to each of >those, so that someone working on games, and in specific on dinput9 >for example could easily find bugs related to dinput 9 without having >to do a query. But now I am worried that I am overstepping my bounds >by trying to do so. Does anyone _else_ object to this idea? I do worry that that'll be a bit too spammy, given how bugzilla works. I'd say "Ask the directX maintainers what they suggest." Maybe they're happy with the way things are, or maybe they'll describe a different problem you can help with. - Dan

1 0

Re: Resend: Add d3drmdef.h header file - try 3
by Francois Gouget 19 Mar '07

19 Mar '07

On Mon, 19 Mar 2007, Vijay Kiran Kamuju wrote: [...] > Add minimalistic d3drmdef.h [...] Something I just noticed: +#include "d3dtypes.h" This should be: #include <d3dtypes.h> If I remember correctly it's important in the public headers for compiling Winelib in some circumstances. (I'm not saying this is why it's been dropped before) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

1 0

Accessing File > 4gb problem (was: Debugging Supreme Commander)
by Stephan Rose 19 Mar '07

19 Mar '07

Allright, I've got the bug nailed to the wall with all of its 6 legs. What I don't know though is what to do about it. Still trying to find the right sledgehammer to squash it with.... Problem boils down to this: Supreme Commander has a .cab file that is just under 6 gigs in size. 0x178d42fce bytes to be exact Now here are the last 5 file seek positions in order from first to last: 0x0ff697fb4 0x0ff69800b 0x0ffebc19a 0x0ffebc1f0 All those succeed fine. But #5 ... 0x1007bc160 results in NTSTATUS c000000d, Invalid Parameter. That address is well within the range of the file though. The status occurs when lseek is called in this part of NtSetInformation, don't mind my added debug fixme's =) case FilePositionInformation: if (len >= sizeof(FILE_POSITION_INFORMATION)) { const FILE_POSITION_INFORMATION *info = ptr; unsigned int* iptr = (unsigned int*)&info->CurrentByteOffset.QuadPart; FIXME( "%i, 0x%08x%08x\n", fd, *(iptr+1), *iptr); if (lseek( fd, info->CurrentByteOffset.QuadPart, SEEK_SET ) == (off_t)-1) { FIXME("Bad result from lseek"); // Above fixme triggered past 4gb io->u.Status = FILE_GetNtStatus(); } } else io->u.Status = STATUS_INVALID_PARAMETER_3; break; I checked sizeof(off_t) and it correctly reports as 8-bytes, so I am not sure what the problem is and why this is happening. Any ideas? On a bright note...I almost have my Supreme Commander CD Key memorized now...how many people can say that!!! ;) Thanks, Stephan

1 0

Test framework for authentication testing
by Kai Blin 19 Mar '07

19 Mar '07

Hi folks, while planning my work on Kerberos and Negotiate, I realized that we need a better way to test things like network authentication, the way we're doing it right now depends on the person running the tests to have a certain setup in the test environment, and e.g. the NTLM SSP tests use an undocumented windows feature to get some of the testing done. Now, a better way to do this would be to actually get some stubbed out user database set up, add a user for testing purposes, run the tests and then delete the test user. Sort of what the Samba project is doing for their smbtorture tests, if I understood those right. Of course this has to be done in a way that will also work on windows, or the tests will be useless. Now the question that's really bugging me is, is this possible at all? Does it make sense? What I'd want to do would be the following: * add a user * set the user password [... run the tests...] * delete the user Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 3

WineCfg and DirectX options
by Michael Lothian 19 Mar '07

19 Mar '07

Hi Has anyone thought about adding the directx options to the Graphics tab in WineCfg Just now I've been testing all the work been done on the graphics layer on different games so I've been switching on and off GLSL and changing backbuffer to fbo etc using regedit Would it not be better to change these things easily instead to allow for wider testing. PS With GLSL and FBO Tomb Raider Legent Opening Level Sequence the cliffs are black With all other options the watter effect is applied the the whole screen when any water is in the screen at all. Has anyone else noticed this. Also none of the menu writing shows up in FarCry but the game works a treat I'm now just waiting for mmstream to be implemented to I can see my video's on X3 Keep up all the good work your beating Transgaming hands down Mike PS the above reports were testing with 0.9.31, 0.9.32 and the latest git

8 9

WineHQ maintainance
by Jeremy Newman 19 Mar '07

19 Mar '07

WineHQ will be offline starting at 13:00 CST. It could be offline for up to an hour, hopefully not longer. I will be replacing the system board at this time. All email will be queued at the backup MX during the downtime. -newman

1 0

appdb trouble?
by Dan Kegel 19 Mar '07

19 Mar '07

I tried submitting a few real apps, with real test data, to the appdb recently, but they haven't shown up. For instance, haoi. (See http://bugs.winehq.org/show_bug.cgi?id=7690) Does the appdb not like me? I'm flying blind because my email filters are a bit screwy, and automatic email from appdb to dank(a)kegel.com is dropped. (I've *got* to fix that sometime...) Thanks, Dan

3 2

Re: MikoÅ,aj Zalewski : user32: tests:Using DefWindowProcA with RegisterClassW works under Windows.
by Dmitry Timoshkov 19 Mar '07

19 Mar '07

"Alexandre Julliard" <julliard(a)wine.codeweavers.com> wrote: > Author: Mikolaj Zalewski <mikolaj(a)zalewski.pl> > Date: Sun Mar 18 13:02:04 2007 +0100 > > user32: tests: Using DefWindowProcA with RegisterClassW works under Windows. The test doesn't pass here under XP: class.c:602: Test failed: Wrong ANSI wndproc: FFFF0367 vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: FFFF036B vs 00403B14 class.c:602: Test failed: Wrong ANSI wndproc: FFFF0367 vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: FFFF036B vs 00403B14 class.c:617: Test failed: Wrong Unicode wndproc: 00403B14 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: 00403B14 vs 00403ACC class.c:602: Test failed: Wrong ANSI wndproc: 00403ACC vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: 00403ACC vs 00403B14 class.c:617: Test failed: Wrong Unicode wndproc: FFFF0367 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: FFFF036B vs 00403ACC class.c:617: Test failed: Wrong Unicode wndproc: FFFF0367 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: FFFF036B vs 00403ACC class: 590 tests executed (0 marked as todo, 12 failures), 0 skipped. -- Dmitry.

2 1

Ok... Someone tell me WTF is going on here.
by Giles Cameron 19 Mar '07

19 Mar '07

Ok. I have been tring to track down what appears to be a bug in wine while trying to get The Sims 2 (Seasons) to work. And so I have been tring to add to the debug a bunch of useless bunk. and I am getting VERY strange results, attached are the cdrom.c file I edited in dlls/ntdll/ and the output. Did I manage to break the wine debugger? or uncover the monster of all bugs? I am sitting here wondering "WTF" right now.... Wtf did I do, Giles Cameron

3 3

Prompts on what to do next after an install
by Tom Spear 19 Mar '07

19 Mar '07

I just came across another idea that might be nice, and would be trivial to accomplish After running ./configure the configure script tells you to run make depends && make After that, there is nothing telling you what to do.. Obviously most users can figure out to run make install, but it would be nice to have a prompt to say "Now it is time to install wine by running 'make install' as root" Then after that is complete, and this is where I always forget, a prompt to run wineprefixcreate and winecfg would be nice, because that seems to cause several duplicate and unnecessary bugs to be filed. Obviously the user should read documentation, but once you have read it you generally dont tend to read it again, and might forget something. I forget to run both wineprefixcreate and winecfg nearly every time I do a clean reinstall of wine because it isnt part of a normal build routine for most linux apps to have to do this.. I could write up patches for this but I'm taking off for the weekend and wont have access to my linux machine till monday morning, and also I dont know enough about automake and autoconf to be able to write that stuff in. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 3

Re: [ws2_32] in some cases send should block until the entire buffer is sent
by Alexandre Julliard 19 Mar '07

19 Mar '07

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > + } > + else > + skip("CreateThread failed, error %d\n", GetLastError()); > + closesocket(dst); > + } > + else > + skip("accept failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("connect failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("listen failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("getsockname failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("bind failed, error %d\n", WSAGetLastError()); > + closesocket(server); > + } > + else > + skip("creating socket failed, error %d\n", WSAGetLastError()); > + closesocket(src); > + } > + else > + skip("creating socket failed, error %d\n", WSAGetLastError()); This isn't an appropriate use of skip(), these things are not supposed to fail, and if they do something is broken. You should use ok() here. And please avoid the ugly nested ifs, use return or goto end. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: netapi32: Add test for adding/deleting users.
by Robert Shearman 19 Mar '07

19 Mar '07

Kai Blin wrote: > + ret = pNetUserAdd(NULL, 1, (LPBYTE)&usri, NULL); > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Insufficient permissions to add users. Skipping test.\n"); > + return; > + } > + if(ret == NERR_UserExists) > + { > + skip("User already exists, skipping test to not mess up the system\n"); > + return; > + } > + > + ok(ret == NERR_Success, "Adding user failed with error 0x%08x\n", ret); > + if(ret != NERR_Success) > + { > + skip("As adding the user failed, skip the change password and userdel " > + "tests\n"); > + return; > + } > The skip here is pointless. The test failure will already signal that something unexpected happened. > + > + ret = pNetUserChangePassword(NULL, sTestUserName, sTestUserOldPass, > + sTestUserNewPass); > + > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Insufficient permissions to change password, skipping test.\n"); > + } > + else > + { > + todo_wine ok(ret == NERR_Success, "Changing the password failed.\n"); > + } > + > + ret = pNetUserDel(NULL, sTestUserName); > + > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Failed to delete user. You need to manually delete the user.\n"); > + } > + else > + { > + todo_wine ok(ret == NERR_Success, "Deleting the user failed.\n"); > + } > +} > I think it is reasonable to assume that if the user add the rights to add a user then they will have the rights to change the password and to delete it, so the skip statements seem unnecessary. -- Rob Shearman

1 0

GSoC Idea
by Cye Stoner 19 Mar '07

19 Mar '07

Hello, My name is Cye Stoner. I was considering submitting the development of a WinePluginApi (as described at http://wiki.winehq.org/WinePluginApi) to Google's Summer of Code this year. I was also hoping that anybody able to mentor me on this project would contact me regarding the proposal, so that I can have a bit of an idea what I'd be getting myself into. mike at plan99.net submitted the idea in april of 2005, but I don't know if he would still be the one most useful in the area. Thank you for your time, Cye

2 1

Re: wined3d: Fix struct size calculation in EnumTextureFormats
by Stefan Dösinger 19 Mar '07

19 Mar '07

Am Samstag 17 März 2007 23:22 schrieb A C Hurst: > Fixes the calculation of a struct size in > IDirect3DDeviceImpl_2_EnumTextureFormats, and fixes bug 7061. > > >>From 3f08264567229ff6a23b2cf311a18ee013c86152 Mon Sep 17 00:00:00 2001 > > From: ahurst <ahurst(a)hurstmachine.(none)> > Date: Sat, 17 Mar 2007 22:17:18 +0000 > Subject: Fis struct size calculation in EnumTextureFormats Looks OK to me :-)

3 2

more winetricks
by Dan Kegel 19 Mar '07

19 Mar '07

For the record, I consider the need for winetricks a bug in wine. Someday we'll figure out how to make apps install properly without it. In the meantime, I've uploaded a new version to http://kegel.com/wine/winetricks And, as befits such an advanced tool, I'm keeping a revision history in the highly advanced "rcs" revision control system (that's a joke, btw). Here's the history so far: revision 1.4 date: 2007/03/19 00:54:01; author: dank; state: Exp; lines: +30 -3 Add mdac2.8. Echo a message when finished. Obey WINEPREFIXCREATE. ---------------------------- revision 1.3 date: 2007/03/19 00:44:03; author: dank; state: Exp; lines: +40 -20 Bring back and shorten wsh56 variants Make -q quieter Make default a bit chattier Override odbc32 and odbccp32 when installing mdac Make error checking advisory for now Avoid bash-specific "if foo; then" ---------------------------- revision 1.2 date: 2007/03/19 00:40:38; author: dank; state: Exp; lines: +33 -9 Added error checking, gdiplus -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Failure of Wine to quit when a program ends.
by gslink 18 Mar '07

18 Mar '07

Recently my customer replaced her version of Wine with the current version. One of the programs running there, DeScribe, appears to quit normally but doesn't terminate. It continues to be in the background using no cpu time. To get rid of it requires killing the program with System Monitor as there is no evidence on the screen that the program is running. This appears to be a regression in Wine which has happened in the last nine months. Has anyone else had this happen with any other program? I am trying to track the exact problem and knowing that other programs behave this way would help.

1 0

Hey all!!
by Stephan Rose 18 Mar '07

18 Mar '07

Ok guys, something's gotta change. I gotta stop logging into MS Sloth to play Supreme Commander ;) So that said, what can I do, where can I help? =) To give a little info on my background, I've been programming for roughly 10 years now...everything ranging from embedded & microcontroller stuff (PIC / ARM) to high end MS Sloth Applications. Familiar with DirectX, OpenGL, C/C++, C#, x86/ARM/PIC Assembly... I am of course unfamiliar with the whole wine source code. I did look over the rather daunting to-do list and wouldn't even know where to start. =) So I figured I'd send an e-mail out and see if anyone has any good suggestions. =) I'd really love to help with this. I for one think it's a great project and XP has really got to stop taking up one of my precious hard drives... Thanks =) Stephan Rose

3 2

Thanks everyone!
by Stephan Rose 18 Mar '07

18 Mar '07

Thank you very much for your e-mails and suggestions everyone, I highly appreciate it. =) I am actually playing with debugging Supreme Commander right now a little bit and one thing popped into my eyes instantly. The problem that is occurring at the moment is that the installer won't even fully go through. So I am not even at the point of trying to install it yet. It'll go very far but near the end it will die with an error 87 from Install Shield. The very first thing that popped into my eyes though when running the installer was this: fixme:process:IsWow64Process (0xffffffff 0x34d90c) stub! That gets called literally hundreds of times. That makes seeing other error messages difficult for one as it just drowns them out and also slows the installer to a crawl. What I am wondering though is this, is running under Wow64 something that is ever actually going to happen within wine? Because if it's not, then the function actually already does everything it will ever need to do as far as I can tell by reading the documentation for it on MSDN.com For the time being, I commented the fixme line out in the code so that I can actually see other messages more easily and get to the failure point of the installer much quicker. Stephan

2 1

Re: wined3d: Replace inline static with static inline
by Ivan Gyurdiev 17 Mar '07

17 Mar '07

Why should "inline static" be replaced with "static inline". Does it improve compatibility with certain compilers? Also, does wine aim to be compliant with ANSI, C99, or somewhere in between (-gnu89)?

2 1

Bug [219] questions
by Vitaliy Margolen 17 Mar '07

17 Mar '07

I think people still having lots and lots of questions about why safedisc support is still not in Wine: > ------- Additional Comments From Speeddymon 2007-16-03 14:37 ------- > I think the problem (as is with most times a safedisc patch has been written) is > that the patch is either way too hacky, or is made by reverse engineering the > safedisc dll's from windows.. Most likely Ivan did not reverse the dll's as I > know he would not want to poison the tree, so my bet is that it is just too big > of a hack for Alexandre to commit, combined with the fact that it is nearly > impossible to break something like this up into smaller patches without > completely breaking everything. Can we get the "official" view on this? I'm tired of answering this sort of questions myself not knowing the exact reasoning behind. I know that there were plenty of "hacks" but there were number of reasonable pieces that could have been committed. Allowing other people continue work and improving upon. Also can we close that bug as LATER since Alexandre commented it will not be fixed until after 1.0? Vitaliy.

2 2

re: Hey all!!!!
by Dan Kegel 17 Mar '07

17 Mar '07

Stepha wrote: >To give a little info on my background, I've been programming for >roughly 10 years now...everything ranging from embedded & >microcontroller stuff (PIC / ARM) to high end MS Sloth Applications. > >Familiar with DirectX, OpenGL, C/C++, C#, x86/ARM/PIC Assembly... > >I am of course unfamiliar with the whole wine source code. >I did look over the rather daunting to-do list and wouldn't >even know where to start. =) I would suggest starting by doing a couple weeks of bug triage. See http://kegel.com/wine/qa/ Then, while still doing bug triage, start writing conformance tests to expose some of the bugs you're seeing. Getting conformance tests committed to the WineHQ tree is a good rite of passage :-) Then, once you have the hang of that, pick one of the bugs you've written a good conformance test for, and try to fix it. Have fun & stay in touch! - Dan

1 0

Re: [2/3] comctl32: Never draw item text with OPAQUE.
by Felix Nawothnig 17 Mar '07

17 Mar '07

(CCing wine-devel again) Dimi Paun wrote: >>Problem is that DrawText() for the subitems will also use the >>background color - which is wrong. > Why is it wrong? Because the "background color" isn't the background color of the list. And it's definitly not the text bkclr in gdi-context either - I hacked together an app to prove that: http://flexo.popuserv.org/test.c Now it seems getting rid of the OPAQUE completly is wrong, but for different reasons. > It seems to me that this is a bit of a problem: > > 3783 if (nSubItem == 0 || (cdmode & CDRF_NOTIFYITEMDRAW)) > 3784 prepaint_setup(infoPtr, hdc, &nmlvcd); > 3785 > 3786 /* in full row select, subitems, will just use main item's colors */ > 3787 if (nSubItem && uView == LVS_REPORT && (infoPtr->dwLvExStyle & LVS_EX_FULLROWSELECT)) > 3788 nmlvcd.clrTextBk = CLR_NONE; > > I guess the call to prepaint_setup should come _after_ the if > with FULLROWSELECT, no? Depends. Right now this code does nothing (and I was going to remove it anyway) - the only place where clrTextBk is read from is in prepaint_setup() - but prepaint_setup() is not called for subitems (and the CLR_NONE override is only done for subitems). > Also, I can't remember, but there was a reason why prepain_setup > was called just for the main item, why did you changed that? Because subitems can use different colors (see test app) and prepaint_setup() is where the colors are set up... Note that I don't change the notifications being passed or anything of their context (with the exception of the GDI context in the postpaint notification - but the GDI context should be saved & restored in between anyway, see the failing test I commited a few days ago) so I can't imagine how this could break anything. Felix

2 2

Re: This patch fixes bugzilla bug number 1001
by Dmitry Timoshkov 17 Mar '07

17 Mar '07

"Giles Cameron" <giles(a)gilesfreeserv.com> wrote: > +#define STATUS_DISCONNECTED ((NTSTATUS) 0x00000037) > +#define STATUS_NONEXISTENT_NET_NAME ((NTSTATUS) 0x00000037) > +#define STATUS_ENDPOINT_CLOSED ((NTSTATUS) 0x00000037) These defines don't look like proper status values, where did you find them from? -- Dmitry.

2 1

comctl32/tests: test failures
by Joris Huizer 17 Mar '07

17 Mar '07

I was looking at comctl32 files for signedness fixes (there's a lot of signedness warnings, though many can't be fixed easily) Just to be sure, I now and then check with `make test` just to catch mistakes I might have made -- though on this dll 'header' tests fail: header.c:1310: Test failed: Tests will fail as header size is 1x0 instead of 670x18 header.c:1199: Test failed: Invalid rect (0,0) (670,18) vs (0,0) (670,17) header.c:1217: Test failed: Invalid rect (0,0) (670,18) vs (0,0) (670,17) header.c:1220: Test failed: Invalid rect (0,0) (50,18) vs (0,0) (50,17) header.c:1223: Test failed: Invalid rect (50,0) (150,18) vs (50,0) (150,17) header.c:1226: Test failed: Invalid rect (150,0) (300,18) vs (150,0) (300,17) header.c:1244: Test failed: Invalid rect (0,0) (670,18) vs (0,0) (670,17) header.c:1247: Test failed: Invalid rect (0,0) (50,18) vs (0,0) (50,17) header.c:1250: Test failed: Invalid rect (50,0) (150,18) vs (50,0) (150,17) header.c:1253: Test failed: Invalid rect (150,0) (300,18) vs (150,0) (300,17) header.c:1256: Test failed: Invalid rect (0,0) (670,18) vs (0,0) (670,17) header.c:1275: Test failed: Invalid rect (0,0) (670,18) vs (0,0) (670,17) header.c:1278: Test failed: Invalid rect (0,0) (50,18) vs (0,0) (50,17) header.c:1281: Test failed: Invalid rect (150,0) (300,18) vs (150,0) (300,17) header.c:1284: Test failed: Invalid rect (0,0) (670,18) vs (0,0) (670,17) header.c:921: Test succeeded inside todo block: expected 1, got 1 err:header:HEADER_WindowProc unknown msg 1216 wp=0001 lp=00000064 err:header:HEADER_WindowProc unknown msg 1218 wp=0000 lp=00000001 err:header:HEADER_WindowProc unknown msg 1217 wp=0001 lp=00000000 Is something wrong on my computer? Should I add todo_wine to those lines? (That macro TEST_NMCUSTOMDRAW used in many of the lines makes adding that harder -- the macro itself needs tweaking for that) ____________________________________________________________________________________ It's here! Your new message! Get new email alerts with the free Yahoo! Toolbar. http://tools.search.yahoo.com/toolbar/features/mail/

1 0

fixme:d3d_surface:IWineD3DSurfaceImpl_LoadTexture Surface in texture is only supported for level 0
by Kapila De Silva 17 Mar '07

17 Mar '07

Hi All, Im getting a lot of these errors when trying to run Everquest 2, and I was wondering if its something I could fix. Does anyone know why only level 0 is supported for this? I put some additional debug, and find EQ2 is calling this with levels up 1 - 9. Thanks in advance Kapila.

1 0

re: Benchmark quandary
by Dan Kegel 17 Mar '07

17 Mar '07

Tom wrote: >I have some benchmarks posted here: >http://wiki.winehq.org/BenchMark-0.9.5 >as well as here: http://wiki.winehq.org/BenchMark-0.9.6 > >And I have all the Graphics test in PCMark 04 running, >but the app is crashing between test, but if I run them >one at a time they will complete. I'm interested in the crashes. I don't see any bugzilla entries for PCMark; can you file one? Thanks! >The quandary is would posting the test results >from each test while not run as a whole but separately >be of use? and would this be unfair when comparing >the results against XP??? I think it would be of use, as long as you run the tests the same way on XP (or show that running them all at once gives the same results). You just have to add a disclaimer ("Tests run separately on Linux to avoid bug <insert link to bugzilla bug here>"). - Dan

2 1

IDirectInputAImpl_GetDeviceStatus
by Tom Spear 17 Mar '07

17 Mar '07

Hi all, I was looking at bug 3747, about the game Motorhead. This game crashes because IDirectInputAImpl_GetDeviceStatus always returns DI_OK due to being a stub.. The reporter came up with a <10 line hack to fix it, but a proper implementation would be better. There may be other games that suffer problems due to this not being implemented.. Perhaps someone could look into the feasibility of this as a GSoC project, or possibly could come up with a minimal non-stub implementation to keep games like that from crashing just because of a joystick? I made a bug for the stub function.. Bug 7770.. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 1

Tomb Raider Legends wine segfault with /dev/input/event*
by Tom Spear 16 Mar '07

16 Mar '07

Looking at bug 5721, the final comment has found the problem that causes this. The original issue in the bug is fixed, but a new one cropped up. Basically if the user doesn't have r/w access to /dev/input/event* then wine segfaults. What should happen is that wine should print an error on the console about it so that users that read the console output can fix this problem.. I dont know of the risks of allowing global r/w access to /dev/input/event* so maybe the error shouldnt necessarily say that, but if there are no problems with giving global r/w then it could say that.. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: Question about adding a small change to bugzilla
by James Hawkins 16 Mar '07

16 Mar '07

On 3/16/07, Tom Spear <speeddymon(a)gmail.com> wrote: > Just wondering if it would be trivial (not require a complete > recompile) to add a link to the page that shows after you change > anything on a bug to take you back to the bug list that you were last > viewing.. > > Example: On the left there is a link to list just bugs with status: > new, so I click that. Then I see a bug I would like to check out so I > click on that bug. I add comments and hit submit. The next page that > comes up gives me the option to return to the bug, but I would rather > go back to the list. As it stands now I have to hit the back button 2 > times to get back to the list (unrefreshed mind you, which is how I > want it as I dont want to have to re-download the entire list every > time I view it). At the bottom there are links for Query page and > Enter a new bug. To the right of that it would be nice to have a link > that does the equivalent of javascript:back(); a couple of times to > get me back to the bug list without re-downloading it.. > The problem is that the list you are browsing is too long. Bugzilla gives the message, "This list is too long for Bugzilla's little mind; the Next/Prev/First/Last buttons won't appear on individual bugs." If the list is not too long, you would just hit the "Show list" link to get back to the list. -- James Hawkins

2 1

Another GSoC idea
by Remco 16 Mar '07

16 Mar '07

I was thinking of a combined project between Ogre (graphics engine) and Wine. Ogre works on Windows and Linux. It has an OpenGL and DirectX backend. Maybe a student could try to get the DirectX-backend working in Linux with Wine. This would result in a lot of patches for Wine, and the first native Linux DirectX app of this size that I know of. Wouldn't that be cool? Remco ____________________________________________________________________________________ Need Mail bonding? Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users. http://answers.yahoo.com/dir/?link=list&sid=396546091

5 4

Re: comctl32: status bar test - Reorganization and Message Sequencing[2/2]
by Dmitry Timoshkov 16 Mar '07

16 Mar '07

"Alex Arazi" <alexarazi(a)gmail.com> wrote: > This is a two part patch. The first part is status_reorganization.patch > which divides the test routine into function calls. The second part is > status_messages.patch which adds message sequencing. Are you guys planning to monitor test.winehq.org and fix all the failures caused by new message tests? -- Dmitry.

3 3

Re: [2/3] comctl32: Never draw item text with OPAQUE.
by Dimi Paun 16 Mar '07

16 Mar '07

On Fri, March 16, 2007 11:39, Felix Nawothnig wrote: > This fixes a glitch (blue text background inside a red selected cell)) > in SuperGrid (http://flexo.popuserv.org/SuperGrid.exe) and appears to be > what native does. > > There is no need to use OPAQUE anyway since we always draw the selection > background seperatly. But this ends up creating and deleting the brush for each of the cells we draw... I'm not sure I understand why using OPAQUE here doesn't work. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 2

Re: MFDRV_ExtEscape
by Detlef Riekenberg 16 Mar '07

16 Mar '07

On Fr, 2007-03-16 at 11:47 +0000, Nicolas wrote: > INT ret; > > + if (cbOutput) return 0; > len = sizeof(*mr) + sizeof(WORD) + ((cbInput + 1) & ~1); You mixed TAB and SPACE. (default idention in wine is 4 SPACE) Thanks. -- By by ... Detlef

1 0

Re: Another GSoC idea
by Remco 16 Mar '07

16 Mar '07

> I don't actually see the difference between running Ogre apps and other > DirectX apps. > > Or am I getting you wrong and you're suggesting to make the DirectX backend > work as a winelib app on native Linux without Wine? > > Cheers, > Kai Yeah, that's what I meant. I just thought it would be a nice showcase of Wine(lib) if the best-known open source graphics engine would have DirectX-support not only on Windows, but also on Linux. I've had this idea for a while now, but it might be a nice SoC-project. Remco ____________________________________________________________________________________ Never miss an email again! Yahoo! Toolbar alerts you the instant new Mail arrives. http://tools.search.yahoo.com/toolbar/features/mail/

2 1

Re: wined3d: Implement vertex fog with pixel shaders
by H. Verbeet 16 Mar '07

16 Mar '07

Did you check if the clamping is required?

2 2

Re: wined3d: Implement vertex fog with pixel shaders
by Stefan Dösinger 16 Mar '07

16 Mar '07

Am Freitag 16 März 2007 00:09 schrieb Fabian Bieler: This patch breaks the Dolphin DirectX8 sdk demo. It shows up completely blue(the fog color).

1 0

Re: urlmon: Create one notif window per thread.
by Alexandre Julliard 16 Mar '07

16 Mar '07

Jacek Caban <jacek(a)codeweavers.com> writes: > static HWND get_notif_hwnd(void) > { > + thread_data_t *thread_data = get_thread_data(TRUE); > + > static ATOM wnd_class = 0; > - HWND hwnd; > > static const WCHAR wszURLMonikerNotificationWindow[] = > {'U','R','L',' ','M','o','n','i','k','e','r',' ', > 'N','o','t','i','f','i','c','a','t','i','o','n',' ','W','i','n','d','o','w',0}; > > + if(thread_data->notif_hwnd) > + return thread_data->notif_hwnd; This won't work, since the window is stored in the binding and destroyed when the binding is freed. And if you don't have the binding destroy it, then the window is never destroyed and this causes problems if the dll is unloaded. -- Alexandre Julliard julliard(a)winehq.org

1 0

Status of Wine & Mac OS X
by Methril 16 Mar '07

16 Mar '07

Dear Wine deevlopers. I was looking thorugh the mailing list archives about the status of wine working in Intel-Macs. I'd like to start helping the wine project making some effort in Macintel computer, and i like to reach some 3D approach that works in Mac. Waiting your comments Best Regards Rafa Campos (aka methril).

4 3

Re: FDI: Constify some variables
by James Hawkins 16 Mar '07

16 Mar '07

On 3/15/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > Changelog: > FDI: Constify some variables. > > diff -urN a/dlls/cabinet/cabinet_main.c b/dlls/cabinet/cabinet_main.c > --- a/dlls/cabinet/cabinet_main.c 2007-03-15 17:31:18.000000000 +0000 > +++ b/dlls/cabinet/cabinet_main.c 2007-03-15 20:16:45.000000000 +0000 > @@ -86,7 +86,7 @@ > HeapFree(GetProcessHeap(), 0, memory); > } > > -static INT_PTR fdi_open(char *pszFile, int oflag, int pmode) > +static INT_PTR fdi_open(const char *pszFile, int oflag, int pmode) > { > HANDLE handle; > DWORD dwAccess = 0; > @@ -131,7 +131,7 @@ > return 0; > } > > -static UINT fdi_write(INT_PTR hf, void *pv, UINT cb) > +static UINT fdi_write(INT_PTR hf, const void *pv, UINT cb) > { > HANDLE handle = (HANDLE) hf; > DWORD dwWritten; > diff -urN a/dlls/msi/files.c b/dlls/msi/files.c > --- a/dlls/msi/files.c 2007-02-26 17:43:07.000000000 +0000 > +++ b/dlls/msi/files.c 2007-03-15 20:56:44.000000000 +0000 > @@ -161,7 +161,7 @@ > msi_free(pv); > } > > -static INT_PTR cabinet_open(char *pszFile, int oflag, int pmode) > +static INT_PTR cabinet_open(const char *pszFile, int oflag, int pmode) > { > HANDLE handle; > DWORD dwAccess = 0; > @@ -202,7 +202,7 @@ > return 0; > } > > -static UINT cabinet_write(INT_PTR hf, void *pv, UINT cb) > +static UINT cabinet_write(INT_PTR hf, const void *pv, UINT cb) > { > HANDLE handle = (HANDLE) hf; > DWORD dwWritten; > diff -urN a/dlls/setupapi/setupcab.c b/dlls/setupapi/setupcab.c > --- a/dlls/setupapi/setupcab.c 2006-11-10 17:26:30.000000000 +0000 > +++ b/dlls/setupapi/setupcab.c 2007-03-15 20:45:39.000000000 +0000 > @@ -113,7 +113,7 @@ > HeapFree(GetProcessHeap(), 0, pv); > } > > -static INT_PTR sc_cb_open(char *pszFile, int oflag, int pmode) > +static INT_PTR sc_cb_open(const char *pszFile, int oflag, int pmode) > { > DWORD creation = 0, sharing = 0; > int ioflag = 0; > @@ -204,7 +204,7 @@ > return num_read; > } > > -static UINT sc_cb_write(INT_PTR hf, void *pv, UINT cb) > +static UINT sc_cb_write(INT_PTR hf, const void *pv, UINT cb) > { > DWORD num_written; > /* BOOL rv; */ > diff -urN a/include/fdi.h b/include/fdi.h > --- a/include/fdi.h 2006-05-23 13:49:04.000000000 +0100 > +++ b/include/fdi.h 2007-03-15 19:53:38.000000000 +0000 > @@ -205,14 +205,14 @@ > typedef void (__cdecl *PFNFREE)(void *pv); > #define FNFREE(fn) void __cdecl fn(void *pv) > > -typedef INT_PTR (__cdecl *PFNOPEN) (char *pszFile, int oflag, int pmode); > -#define FNOPEN(fn) INT_PTR __cdecl fn(char *pszFile, int oflag, int pmode) > +typedef INT_PTR (__cdecl *PFNOPEN) (const char *pszFile, int oflag, int pmode); > +#define FNOPEN(fn) INT_PTR __cdecl fn(const char *pszFile, int oflag, int pmode) > > typedef UINT (__cdecl *PFNREAD) (INT_PTR hf, void *pv, UINT cb); > #define FNREAD(fn) UINT __cdecl fn(INT_PTR hf, void *pv, UINT cb) > > -typedef UINT (__cdecl *PFNWRITE)(INT_PTR hf, void *pv, UINT cb); > -#define FNWRITE(fn) UINT __cdecl fn(INT_PTR hf, void *pv, UINT cb) > +typedef UINT (__cdecl *PFNWRITE)(INT_PTR hf, const void *pv, UINT cb); > +#define FNWRITE(fn) UINT __cdecl fn(INT_PTR hf, const void *pv, UINT cb) > > typedef int (__cdecl *PFNCLOSE)(INT_PTR hf); > #define FNCLOSE(fn) int __cdecl fn(INT_PTR hf) > Are you checking with the SDK to make sure these changes are legit? This isn't how the Windows SDK fdi.h has these defined. -- James Hawkins

2 3

Benchmark quandary
by Tom Wickline 16 Mar '07

16 Mar '07

Hello All, I have some benchmarks posted here: http://wiki.winehq.org/BenchMark-0.9.5 as well as here: http://wiki.winehq.org/BenchMark-0.9.6 And I have all the Graphics test in PCMark 04 running, but the app is crashing between test, but if I run them one at a time they will complete.. The quandary is would posting the test results from each test while not run as a whole but separately be of use? and would this be unfair when comparing the results against XP??? -- Tom Wickline Respectable computing - Linux/FOSS

1 0

Want to be a Wine mentor for Google Summer of Code 2007?
by Dan Kegel 16 Mar '07

16 Mar '07

I'm looking for active Wine developers to act as mentors for Google Summer of Code 2007. If you're interested, please let me know quickly; the list has to be finalized in the next half-day or so. (Sorry for the late notice; I wasn't paying attention, and the deadline snuck up on me...) - Dan

8 8

Need help with SymInitializeW
by Kapila De Silva 15 Mar '07

15 Mar '07

Hi All, Im trying to debug a crash in Everquest 2, (bug 7705) and am hoping someone here can help. The crash seems to be linked to the process calling SymInitializeW a second time (its called once at the start of the process, and works ok) On the second call to the function we see an error fixme:dbghelp:SymInitializeW what to do ?? By putting some tracing in here, I noticed that when the function is called the first time, the call to process_find_by_handle(hProcess) returns null, and once the SymInitializeW function calls EnumerateLoadedModules, process_find_by_handle returns a process id. In the second call, the process_find_by_handle(hProcess) returns the same process id as before, however, when the SymInitializeW function calls EnumerateLoadedModules, process_find_by_handle returns a different process id. Should SymInitializeW be called multiple times by a process? Is it possible that a problem has already occured, and this is called as a result? Or is it possible that SymInitializeW itself is the cause of the crash? Any ideas? Thanks Below is some trace I got when I put in some extra debug. First call: fixme:dbghelp:SymInitialize Calling SymInitializeW 0xffffffff(0xffffffff L"C:\\Program Files\\Sony\\EverQuest II" 1) fixme:dbghelp:process_find_by_handle Returning process handle (nil) fixme:dbghelp:process_find_by_handle Returning process handle 0x16c5d0 Second Call: fixme:dbghelp:SymInitialize Calling SymInitializeW 0xffffffff(0xffffffff (null) 1) fixme:dbghelp:process_find_by_handle Returning process handle 0x16c5d0 fixme:dbghelp:SymInitializeW what to do ?? fixme:dbghelp:process_find_by_handle Returning process handle 0x3a8f9a0

3 5

Bug with creating an attachment
by Tom Spear 15 Mar '07

15 Mar '07

I am getting an error trying to create an attachment in bugzilla. If I paste it my email will come thru as html, but if I attach, it will be a picture attachment, neither of which are allowed.. Ill just type the error: Internal Error Bugzilla has suffered an internal error. Please save this page and send it to wine-bugs(a)winehq.org with the details of what you were doing at the time this message appeared. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 3

Defining COM interfaces without IDL
by Felix Nawothnig 15 Mar '07

15 Mar '07

Hi. The PSDK headers sometimes use IDL to define an interface, sometimes it's done by hand (or rather using macros). I don't know if there is any reason for that (someone in the channel said it's just sloppiness by MS) - so, are there any resulting differences regarding source compatibility or can we just use IDL even if MS didn't? Felix

1 0

Bug with creating an attachment (take 2)
by Tom Spear 15 Mar '07

15 Mar '07

I am getting an error trying to create an attachment in bugzilla. If I paste it my email will come thru as html, but if I attach, it will be a picture attachment, neither of which are allowed.. Ill just type the error: Internal Error Bugzilla has suffered an internal error. Please save this page and send it to wine-bugs(a)winehq.org with the details of what you were doing at the time this message appeared. URL: http://bugs.winehq.org/attachment.cgi undef error - Can't find param named product at Bugzilla/Config.pm line 124. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: user32: Restore erroneously removed chunk of code
by Alexandre Julliard 15 Mar '07

15 Mar '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > one of my recent MDI patches has caused a regression in one of applications > I'm working on. This patch should fix it by restoring apparently erroneously > removed chunk of code. > > Changelog: > user32: Restore erroneously removed chunk of code. This breaks the tests: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:2836: Test failed: ShowWindow(SW_RESTORE):invisible MDI child: the msg sequence is not complete: expected 0046 - actual 0000 msg.c:2866: Test failed: ShowWindow(SW_RESTORE):maximized MDI child: the msg sequence is not complete: expected 0046 - actual 0000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Delayed debug patch
by Kapila De Silva 15 Mar '07

15 Mar '07

Can someone tell me how to apply this to my git copy of wine please? This would help a lot with my debugging... Thanks Kapila

2 1

Re: Romanian Wine translation
by Michael Stefaniuc 15 Mar '07

15 Mar '07

Hi, Mikołaj Zalewski wrote: > I've seen you have started the Romanian translation of wine. Could you > look on the page http://wiki.winehq.org/SublangNeutral and mark if > Romanian should use SUBLANG_NEUTRAL or sublang codes? I would have done that myself long ago but I do not know that. I'll use LANG_NEUTRAL as long as somebody more knowledgeable dosn't change it. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Re: comctl32: register all the controls in DllMain (fixes bug #7641)
by Felix Nawothnig 15 Mar '07

15 Mar '07

Mikołaj Zalewski wrote: > comctl32 version 5.82 (at least the one that comes with a fully patched > Windows XP) and 6.0 register all the controls in DllMain. > InitCommonControlsEx is just a dummy function. Could it be that 6.0 only registers those controls listed using window class dependencies in the manifest file? If what you say about 5.82 is true your patch is correct though ofcourse. Felix

2 1

Help with debug
by Phil Lodwick 15 Mar '07

15 Mar '07

Hi, I have been debugging a problem today and am running low on batteries. I am hoping somebody can look at the attached snippet of log and point me in the right direction. >From what I can tell, there is a DLL called snoopy.dll that does a whole bunch of allocs and reallocs and then tries to reference a NULL pointer which causes an unhandled exception. The code goes through a loop and does not always crash on the same iteration, but it always seems to crash at the same address. This code does not crash on Windows. Just getting lucky? Unfortunately I do not have the sources to this code, so it makes life a little more difficult. Any good ideas for my next step in debugging? Thanks, Phil

2 1

Re: Submitting winetricks to winehq tree?
by Dan Kegel 15 Mar '07

15 Mar '07

Carl-Daniel wrote: > Sorry if this has been answered before, but is winetricks a newer > version of winetools? No. Winetricks (http://www.kegel.com/wine/winetricks ) is a single 11KB shell script. It's a tiny command line tool that only knows how to install Microsoft redistributable libraries (and fonts), and set a registry key or two. For instance, if you're trying to install or run an application, but it fails with "import_dll Library MSVBVM60.DLL not found", you can fix it with $ winetricks vbrun60 Or if you're trying to install an app, but it fails with "Sorry, this application requires IE6", you can fix it without really installing IE6 by setting the right registry key. Winetricks makes this easy; just do $ winetricks fakeie6 etc. etc. Essentially, Winetricks just automates things one would normally have to look up in the Wine wiki, and it does it in the simplest possible way. Winetools ( http://www.von-thadden.de/Joachim/WineTools/ ) can do some of that, but it's really a different beast. It's a set of 150 or so files with a fancy GUI. Each of the files is a recipe for installing a particular Windows application. It is aimed at people who just want to run apps and not understand things. It is bad because, instead of working to improve Wine to make apps easy to install, it papers over the problems. And then there's Wine-Doors ( http://www.wine-doors.org ), which is like Winetools with delusions of grandeur. They seem to want to reinvent apt-get for no particular reason, and as far as I can tell, they intend to have a central server from which you can download copies of e.g. Photoshop with it. This doesn't seem legal, offhand, but I can't find their mailing list archive to see if anyone has asked them about this fine point. IMHO both Winetools and Wine Doors are mostly harmful, but they do have a real benefit for users. Winetricks is a bit like the non-harmful 1% of Winetools. If we don't provide something like Winetricks, more people might be driven to Winetools, and it'd be nice to prevent that. - Dan

2 1

Re: [2/3] kernel32: GlobalMemoryStatusEx: return the size of physicalmemory + swapsize in ullTotalPageFile/ullAvailPageFile
by Dmitry Timoshkov 15 Mar '07

15 Mar '07

"Fabian Bieler" <der.fabe(a)gmx.net> wrote: > - /* Project2k refuses to start if it sees less than 1Mb of free swap */ > - if (lpmemex->ullTotalPageFile < lpmemex->ullTotalPhys) > - lpmemex->ullTotalPageFile = lpmemex->ullTotalPhys; > - if (lpmemex->ullAvailPageFile < lpmemex->ullAvailPhys) > - lpmemex->ullAvailPageFile = lpmemex->ullAvailPhys; > + /* Win98 returns only the swapsize in ullTotalPageFile/ullAvailPageFile, > + WinXP returns the size of physical memory + swapsize; > + mimic the behavior of XP: > + */ > + lpmemex->ullTotalPageFile += lpmemex->ullTotalPhys; > + lpmemex->ullAvailPageFile += lpmemex->ullAvailPhys; Why did you remove a comment about Project2k? It helps to understand what are the constrains of the API, and helps to avoid chasing the same bug once again. -- Dmitry.

1 0

Submitting winetricks to winehq tree?
by Dan Kegel 14 Mar '07

14 Mar '07

I haven't been villified yet, so let me try harder. Should winetricks be committed to the winehq tree? It would be handy for people triaging Wine bugs to see if e.g. native dcom, odbc, or corefonts hide a bug. I've uploaded a new version to http://kegel.com/wine/winetricks Mainly it adds a -q option to make all the installers quiet, but it also includes lots of little improvements sent in by Detlef and Saulius. Here's the new usage message: Usage: winetricks [options] package [package] ... This script can help you prepare your system for Windows applications that mistakenly assume all users' systems have all the needed redistributable runtime libraries or fonts. Options: -q quiet. You must have already agreed to the EULAs. -v Verbose Packages: art2kmin Access 2000 runtime. License required! corefonts Install MS Times, Arial fonts dcom98 Install native DCOM, override the Wine implementation fakeie6 Set registry to claim IE6sp1 is installed mdac27 Microsoft ODBC drivers, etc. mfc40 mono1.1 mono 1.1.13-gtksharp-2.8.2 mono1.2 mono 1.2.3.1-gtksharp-2.8.3 vbvm50 Visual Basic 5 runtime vbrun60 Visual Basic 6 runtime vcrun6 vc6redist from VS6sp4, including mfc42 wsh51 Windows Scripting Host 5.1

5 4

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Eric Pouech 14 Mar '07

14 Mar '07

Robert Shearman a écrit : > > The old behaviour can be turned back on by setting the V environment > variable to "1" (e.g. make V=1). a couple of more comments (mostly not yet converted rules): - the MAKEDEP rule in Make.rules.in isn't handled yet (suggestion [DEPEND] $SRC(DIR)) - most of exec rule in tools/*/Makefile.in miss the MAKERULE stuff - ditto in loader (and the version-stamp could be handled too) - in dlls/Makedlls.rules.in, all lib/def/.a stuff isn't handled is there any reason why the Linking... rule has a different format than the others ? now I wish we could also get rid of the message for recursive calls to make A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [advapi32/tests 1/2] Use GetModuleHandle and skip
by Francois Gouget 14 Mar '07

14 Mar '07

On Tue, 13 Mar 2007, Paul Vriens wrote: [...] > as advapi32 is already linked to, we can use GetModuleHandle. - if (!(module = LoadLibrary( "advapi32.dll" ))) return; + if (!(module = GetModuleHandleA( "advapi32.dll" ))) return; Well, since we're already linked to advapi32.dll, there's no need to check that GetModuleHandleA() does not return NULL. Plus if we were to check we should use skip(). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

2 1

A SoC proposal for discussion: PE Packers
by Julien 14 Mar '07

14 Mar '07

Hello all, I didn't find a webpage on the wiki about SoC'07. However, I would like to suggest a SoC proposal for your comments. It seems to me that there are many bugs floating in bugzilla that are related to PE packers. Because applications just crash due to being packed, this seems a requirement for Wine 1.0. For a SoC, it would be very interesting if one student takes the mission of fixing bugs related to PE packers such as: - Shrinker (#2608, #2619) - Neolite (seems ok see #4709) - Aspack (#6129) - Armadillo (#219) This would require to define the list of PE packers to support and which versions (as anti debugging tricks may differ depending of the version). Best, Julien

2 1

Re: Add very basic initial tests for d3drm
by Dmitry Timoshkov 14 Mar '07

14 Mar '07

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > +START_TEST(vector) > +{ > + init_function_pointers(); > + > + VectorTest(); > + QuaternionTest(); What happens if init_function_pointers() failed? -- Dmitry.

2 1

Re: Alexandre Julliard : ntdll: Add a wrapper to call the thread entry point for broken apps.
by Ken Thomases 14 Mar '07

14 Mar '07

On Mar 14, 2007, at 7:25 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 7744443febb04213cf014b007a83744a66544d6c > URL: http://source.winehq.org/git/wine.git/? > a=commit;h=7744443febb04213cf014b007a83744a66544d6c > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Wed Mar 14 12:28:38 2007 +0100 > > ntdll: Add a wrapper to call the thread entry point for broken apps. > > --- > > dlls/ntdll/thread.c | 25 ++++++++++++++++++++++--- > 1 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 9656331..d0871a1 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -349,6 +349,26 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > return unhandled_exception_filter; > } > > +#ifdef __i386__ > +/* wrapper for apps that don't declare the thread function > correctly */ > +extern DWORD call_thread_entry_point( PRTL_THREAD_START_ROUTINE > entry, void *arg ); > +__ASM_GLOBAL_FUNC(call_thread_entry_point, > + "pushl %ebp\n\t" > + "movl %esp,%ebp\n\t" > + "subl $4,%esp\n\t" > + "pushl 12(%ebp)\n\t" > + "movl 8(%ebp),%eax\n\t" > + "call *%eax\n\t" > + "leave\n\t" > + "ret" ); > +#else > +static inline DWORD call_thread_entry_point > ( PRTL_THREAD_START_ROUTINE entry, void *arg ) > +{ > + LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; Should the above have "entry" instead of "rtl_func"? > + return func( arg ); > +} > +#endif > + > / > ********************************************************************** > * > * call_thread_func > * > @@ -356,16 +376,15 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > */ > static void DECLSPEC_NORETURN call_thread_func > ( PRTL_THREAD_START_ROUTINE rtl_func, void *arg ) > { > - LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; > DWORD exit_code; > BOOL last; > > MODULE_DllThreadAttach( NULL ); > > if (TRACE_ON(relay)) > - DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), func, arg ); > + DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), rtl_func, arg ); > > - exit_code = func( arg ); > + exit_code = call_thread_entry_point( rtl_func, arg ); > > /* send the exit code to the server */ > SERVER_START_REQ( terminate_thread ) > > >

2 1

DirectX 10 start as a SoC project?
by Kovács András 14 Mar '07

14 Mar '07

Hi, I think, that start working on Dx10 is a great opportunity to learn about wined3d, and Microsoft's new platform. I would like to apply, because i want to contribute to open source projects, and i'm really interested in wine, especially in wined3d. I have some patches in the tree, and I really would like to work on together. Best Regards, Andras kovacs -- ------------------ andras NetClub Lamarr csevego.net andras(a)csevego.net ------------------

4 3

HtmlHelp status, winecfg and SoC proposal
by Jacek Caban 14 Mar '07

14 Mar '07

Hello. As you may have noticed, I've been working on HtmlHelp lately. Currently it should generally work, but still there is a lot to do. HTML should be correctly displayed and content tab should work. I was thinking about making more use of it in Wine. I think winecfg could benefit from it. We could easily add context help to winecfg using HtmlHelp API. Even just integrating a part of Wine User's Guide would be a good start. The main problem is building chm file (that is the file format of HtmlHelp). Microsoft has a HtmlHelp compiler (hhc) for it. We'd need something similar in Wine. AFAIK there is no good open source replacement. HtmlHelp maker (hhc, see [1]) doesn't create internal files (parts of chm that describes stuff like index or default topic) and it's GPLed so it's useless for Wine (unless author would relicense it for us). I think it would be a good project for Google Summer of Code. The task would be to write a hhc replacement and add a help option to winecfg. hhc replacement (say whhc) would have to be a plain UNIX tool (it means a bit of code duplication with itss.dll, just like we do in widl) so we could use it during compilation. I think its difficulty is good for SoC. Compressing code may be integrated from some other project. The remaining parts are code of parser of files describing chm and a little winecfg hacking. What do you think? Jacek [1] http://savannah.nongnu.org/projects/hhm

4 5

Re: wined3d: Allow SetCursorProperties on existing cursor
by Stefan Dösinger 13 Mar '07

13 Mar '07

Am Dienstag 13 März 2007 03:44 schrieb Erich Hoover: > Real Name: > Erich Hoover > Changelog: > wined3d: Allow SetCursorProperties on existing cursor Looks good to me, except one cosmetic issue: if(pCursorBitmap) { + WINED3DLOCKED_RECT rect; +......... /* MSDN: Cursor must be A8R8G8B8 */ You are adding trailing whitespaces here. I think git or AJs filters filter them out, but they tend causing merging problems for me if my patches contain some of them.

1 0

My plans for SOC
by Maarten Lankhorst 13 Mar '07

13 Mar '07

For the summer of code I'm planning to improve the dsound code and alsa code, to make alsa finally better then OSS, in a way that has a will get accepted into the wine tree, for that I'm thinking of improving on the following fronts: Winealsa: - Add mixer device and aux controls - Implement dsound capture - Seperate the initialisation of the directsound code from the waveout code, to allow creation of multiple dmix devices. - Try to configure alsa to allow arbitrarily big buffers, working around the alsa problem that only up to a certain amount can be allocated for buffers, certain programs (for example winamp) may require more. - Remove the queuing thread and use Lock() and Unlock() instead. - Make it run so well, people wouldn't want to use OSS any more. Both dsound/winealsa: - Allow proper usage of Lock() and Unlock() for sound drivers, it's not used properly or even tested in current dsound code. - Rework some of the dsound code, to allow mixing to be done in winealsa, and fix possible errors that can be caused by it. - Improve the dsound software mixer code to allow mixing and (if possible) be less prone to buffer underruns. The challenge is to get this working right, without too much of an impact hit. I also will have to work around alsa limitations: I cannot make buffers arbitrarily big, while in windows they can be. It seems no 2 programs use dsound in the same way, so I will have to test with various different programs to get everything working. I'll try to get in contact with alsa-devel first, if there is a way to change buffer size to something arbitrary, it is worth it in the long run to use that method. A manual fix seems to be close everything using alsa, then echo 256 > /proc/asound/card0/pcm0p/sub0/prealloc, but I am hoping there is an easier way to fix it, in either case I am afraid I will have to put some memory buffer code in winealsa as fallback. If there's still some time left, I'll also try to get some 3d sound code in, using some openal code, the license seems to be lgpl compatible, or I will try to get support for multiple (4, 5.1 ?) speakers working, it depends a little on how fast I can get this to work in a nice shape. Looking for feedback. Cheers, Maarten

4 3

re: Want to be a Wine mentor for Google Summer of Code 2007?
by Dan Kegel 13 Mar '07

13 Mar '07

Jeremy wrote: > Say, we (the Wine project) seem to be increasingly leaning on you > to run Wine's SoC program. In the early days, we had a committee, > and people helping, and stuff. These days, I know that I am guilty > of thinking that you're on it, so I can safely ignore it; I fear > that a bunch of others of us may be doing the same. > > Are we letting you down? Do you need help? I'm fine this year, but considering how I missed the deadline (we were saved by LH's kindness), it would probably be a good idea to pick somebody else to be admin next year. The committee should probably just be the mentors plus you and Alexandre (if you/he are interested). - Dan

2 1

RE: some emails not arriving to wine-patches (was CMD.EXE resubmits)
by Ann & Jason Edmeades 13 Mar '07

13 Mar '07

As an FYI I sent the same patchset to another email account (not on my ISP, just one of the free ones) and they all got through 4 times. It would start to point to the wine-patches side of things, but I have never seen anyone else have problems Note I am not seeing any rejection emails either Jason

3 2

Re: [0/9] CMD.EXE resubmits
by Alexander Nicolaysen Sørnes 13 Mar '07

13 Mar '07

Tirsdag 13 mars 2007 22:03, skrev Ann & Jason Edmeades: > Resubmitting the patchset from yesterday having fixed up the > mallocs/reallocs/frees to HeapAllocs/HeapReAllocs/HeapFrees, and resolved > conflicts with those already committed. > > Note: I have been experimenting from sending the emails directly from "git > send-email", and this will be the first ones sent that way, so if there are > any problems please let me know > > Jason There does not seem to be a patch attached. Alexander N. Sørnes

2 2

Issue with GetTokenInformation?
by Paul Vriens 13 Mar '07

13 Mar '07

Hi, As I'm still trying to get Process Explorer running perfectly, I've noticed that the usernames for the processes are not correct. The attached patch shows the issue. I'm not sure if this test-patch should go to wine-patches as I'm not sure my test is correct (or in the correct place). It succeeds on W2K3. Maybe someone more knowledgeable about the Token stuff could have a look? Cheers, Paul

1 0

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Eric Pouech 13 Mar '07

13 Mar '07

Robert Shearman a écrit : > > The old behaviour can be turned back on by setting the VERBOSE > environment variable to "yes". > .s.o: > $(AS) -o $@ $< > > $(MODULE): $(OBJS) Makefile.in > - $(RM) $@ > - $(AR) $@ $(OBJS) > - $(RANLIB) $@ > + @$(RM) $@ > + @$(MAKERULE) '[AR] $@' $(AR) $@ $(OBJS) > + @$(MAKERULE) '[RANLIB] $@' $(RANLIB) $@ > we'll miss the echo for the $(RM) command in verbose mode IMO, we should use here something like @$(MAKERULE) '' $(RM)... and handle the empty $1 in makerule A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: localspl: add Polish translation
by Jacek Caban 13 Mar '07

13 Mar '07

Hi Mikołaj, Mikołaj Zalewski wrote: > + IDS_NOTHINGTOCONFIG "Ten port nie ma opcji, kt�re mo�na by skonfigurowa�" > +} > It doesn't sound good to me. How about "Ten port nie ma opcji do skonfigurowania" or just remove "by" from your version? Jacek

1 0

Re: shell32: update Polish translation
by Jacek Caban 13 Mar '07

13 Mar '07

Hi Mikołaj, Mikołaj Zalewski wrote: > - IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > - "If the files in the destination folder have the same names as files in the\n"\ > - "selected folder they will be replaced. Do you still want to move or copy\n"\ > - "the folder?" > + IDS_OVERWRITEFOLDER_TEXT "Ten folder ju� zawiera folder o nazwie '%1'.\n\n"\ > + "Je�eli w docelowym folderze wyst�pi� pliki o takich zamych nazwach jak\n"\ > This is a typo, it should be "samych nazwach". Jacek

1 0

Re: wordpad: update Polish translation
by Jacek Caban 13 Mar '07

13 Mar '07

Hi Mikołaj, Mikołaj Zalewski wrote: > + > +STRINGTABLE DISCARDABLE > +BEGIN > + STRING_RICHTEXT_FILES_RTF, "Tekst sformatowany - RTF (*.rtf)" > + STRING_TEXT_FILES_TXT, "Document tekstowy (*.txt)" This is a typo, it should be "Dokument". Jacek

1 0

Re: const cleanup round 1
by Eric Pouech 13 Mar '07

13 Mar '07

Mike Schaadt a écrit : > string.c: > strtolW and strtoulW - constify the endptr value. This is just an > output value to indicate where in the array we stoped processing. > Change causes this to be the same type as the first value. Reduces > number of cast-qual warnings by 6. > > lnk.c: > dump_pidl > [line 176] - switched to const. Value is never modified in > the function. Removes a cast-qual warning. > > symbol.c: > symbol_clean_string - this function is modifying the string. This > should most definitly *not* be a const parameter. It's not even > logically const as the the intent of the function is to make the type > string Wine-friendly. That requires modifications to that string. > > ------------------------------------------------------------------------ > > diff --git a/include/wine/unicode.h b/include/wine/unicode.h > index 83a7d52..4e2caa5 100644 > --- a/include/wine/unicode.h > +++ b/include/wine/unicode.h > @@ -96,8 +96,8 @@ extern int strcmpiW( const WCHAR *str1, > extern int strncmpiW( const WCHAR *str1, const WCHAR *str2, int n ); > extern int memicmpW( const WCHAR *str1, const WCHAR *str2, int n ); > extern WCHAR *strstrW( const WCHAR *str, const WCHAR *sub ); > -extern long int strtolW( const WCHAR *nptr, WCHAR **endptr, int base ); > -extern unsigned long int strtoulW( const WCHAR *nptr, WCHAR **endptr, int base ); > +extern long int strtolW( const WCHAR *nptr, const WCHAR **endptr, int base ); > +extern unsigned long int strtoulW( const WCHAR *nptr, const WCHAR **endptr, int base ); > this is wrong as you want to be able to write code as: WCHAR* str; WCHAR* p; int val = strtolW(str, &p, 10); *p = '\0'; which your modification forbids (ANSI strtol doesn't have the const modifier for endptr) the rest of the patch looks ok -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Re: Add casts to tools/makedep.c
by Dmitry Timoshkov 13 Mar '07

13 Mar '07

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > I accidently ended up building Wine using a C++ compiler the other day, > and came across the following. > - char *p = xmalloc (size); > + char *p = (char*) xmalloc (size); That's a problem of C++ not Wine if it can't cope with casting void * to another pointer type. Polluting the whole source with useless casts buys us nothing. -- Dmitry.

2 1

Re: winedbg: Support longer thread names
by Eric Pouech 13 Mar '07

13 Mar '07

Erich Hoover a écrit : > Real Name: > Erich Hoover > Description: > The thread name length in winedbg is currently restricted to 9 > characters, this is not nearly long enough for debugging threads in > the Supreme Commander demo and results in character corruption on the > terminal. Since this particular application names one of the threads > with the map path (Map loader /maps/scmp_019/scmp_019.scmap), a > significant increase in the number of characters is necessary. This > patch ups the allowed thread name length to 100 characters and > null-terminates the string in case an application exceeds that > threshold value. > Changelog: > winedbg: Support longer thread names in that case, it would be better to dynamically allocate the string (and to create it by default at 5 bytes for the %04x value) furthermore, you need to change the comment in debugger.h in THREADNAME_INFO structure about the name's length, as it seems VC7 removed the restriction to 8 characters that existed in VC6 A+

2 2

Re: [11/19] cmd.exe: Add dir /Q support
by Alexandre Julliard 13 Mar '07

13 Mar '07

"Ann & Jason Edmeades" <us(a)edmeades.me.uk> writes: > + secBuffer = (LPBYTE) malloc(sizeNeeded * sizeof(BYTE)); > + if(!secBuffer) return; Please don't use malloc in Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

d3drm test implementation need comments and review
by Vijay Kiran Kamuju 13 Mar '07

13 Mar '07

Hi, I have implemented some d3drm functions and made some changes. Original implementation is by David Adam. Currently I dont have a wine repository to test the patch. Before applying the patch please create the dlls/d3drm/tests directory Please send me you comments, regarding this. If there are any compilation/execution errors, please notify me. I will correct them (I dont have access to linux m/c currently) Thanks, VJ

2 1

Re: Add d3drmdef.h header - try 2
by Francois Gouget 13 Mar '07

13 Mar '07

On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote: > Changelog > --------------- > Add minimalistic d3drmdef.h > > extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, LPD3DVECTOR); Two nitpicks: Wine's headers usually don't specify extern (it's implicit). If there's a large list of functions it can also be nice to sort them in alphabetical order as other forms of grouping tend to break down after a time. But this is not a hard and fast rules and it is not always followed. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

2 1

Re: Set D3DCAPS2_DYNAMICTEXTURES flag
by Mirek 13 Mar '07

13 Mar '07

Shouldn't we use WINED3DCAPS2_DYNAMICTEXTURES rather than D3DCAPS2_DYNAMICTEXTURES ? Mirek Slugen Kovács András napsal(a): > Hi, > Set D3DCAPS2_DYNAMICTEXTURES flag. > This makes Call of Duty 2 to run. Stefan told me, this function is supported, > but we don't advertise it currently. > > > > ------------------------------------------------------------------------ > > From e9398c4ee873ef8b8257fcb3db4945c858655732 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Andr=C3=A1s_Kov=C3=A1cs?= <andras(a)debian.sth.sze.hu> > Date: Tue, 13 Mar 2007 03:07:30 +0100 > Subject: [PATCH] Set D3DCAPS2_DYNAMICTEXTURES flag > > --- > dlls/wined3d/directx.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 209e745..c5898c6 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1879,7 +1879,8 @@ static HRESULT WINAPI IWineD3DImpl_GetDeviceCaps(IWineD3D *iface, UINT Adapter, > > *pCaps->Caps = 0; > *pCaps->Caps2 = WINED3DCAPS2_CANRENDERWINDOWED | > - WINED3DCAPS2_FULLSCREENGAMMA; > + WINED3DCAPS2_FULLSCREENGAMMA | > + D3DCAPS2_DYNAMICTEXTURES; > *pCaps->Caps3 = 0; > *pCaps->PresentationIntervals = WINED3DPRESENT_INTERVAL_IMMEDIATE; > > > > ------------------------------------------------------------------------ > >

2 1

const cleanup round 1(commentary on what I found)
by Mike Schaadt 13 Mar '07

13 Mar '07

Some of this was included in the patch submission. Some of it I had questions about. spawn.c : warnings may or may not be harmless depending on if esecvp attempts to modify the results. Specs indicate it doesn't, but the function typing doesn't indicate so(the difference is 'const char * const argv[]' and 'char *const argv[]') libs/wine/string.c: strstrW - returns the location where sub was found in str. I believe returning a non-const value is what is expected. Should this be changed to a non-const parameter, or just leave the warning as is? tools/winedump/pdb.c: pdb_exit [line 149,153,155] - freeing of const variable. Is this ok? I could imagine it *could* cause problems if what we are freeing isn't in readable/writeable memory. pdb_dump_symbols [line 293,403,409] - same as pdb_exit. pdb_dump_types [line 462] - ditto pdb_jg_dump line[514] - ditto pdb_ds_dump line[643] - ditto tools/winedump/search.c: get_type [line 305, 329] - freeing of const variable again. [line 314, 335] - both cases, set return_text to type_str. Either parsed_symbol's return_text needs to be constified, proto should be unconstified, or leave it in place as a necessary cast. Any comments on the above spots? what of these are necessary casts? what of these can/should be corrected, and what needs to be done to correct them? **patches submitted to wine-patches** the following were straight forward patches that shouldn't modify the flow of the program beyond fixing the warnings. libs/wine/string.c: strtolW and strtoulW - constify the endptr value. This is just an output value to indicate where in the array we stoped processing. Change causes this to be the same type as the first value. Reduces number of cast-qual warnings by 6. tools/winedump/lnk.c: dump_pidl [line 176] - switched to const. Value is never modified in the function. Removes a cast-qual warning. tools/winedump/symbol.c: symbol_clean_string - this function is modifying the string. This should most definitely *not* be a const parameter. It's not even logically const(as a comment tried to claim) as the the intent of the function is to make the type string Wine-friendly. That requires modifications to that string, and to the variable. Removes a cast-qual warning. Comments? questions? Current number of cast-qual warnings fixed: 8. Number deemed necessary: 0(you guys need to help me decide what of these need to remain) Number looked at: 24. Estimated number remaining: 521.

1 0

re: Add d3drmdef.h header - try 2
by Dan Kegel 13 Mar '07

13 Mar '07

Vijay wrote: > Add minimalistic d3drmdef.h But why? None of the code in wine currently needs it. Maybe you should submit it together with the first bit of code that needs it. -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

re: Add d3drmdef.h header
by Dan Kegel 13 Mar '07

13 Mar '07

vijay wrote: > [complete d3drmdef.h] It seems premature to check that in without any code that uses it. Also, did you really write all that yourself? - Dan

3 5

Wiki changes lost? (was: Re: Known desktop migration projects and their "must have" Windows apps)
by Dan Kegel 13 Mar '07

13 Mar '07

On 3/11/07, Dan Kegel <dank(a)kegel.com> wrote: > I'm putting a list together at > http://wiki.winehq.org/DesktopMigrationProjects This, and all my other recent wiki changes, seem to have vanished in a puff of greasy black smoke. What's up? This isn't doing much for my trust in wikis... - Dan

4 10

CreateScalableFontResource - a few questions
by Chris Howe 13 Mar '07

13 Mar '07

Hi all, For my first foray into contributing to Wine (a blast, so far :) ) I am implementing CreateScalableFontResource which is currently present in stub form, but when fully implemented should create .FOT files from .TTF files for (amongst other things) temporarily installing fonts by a successive call to AddFontResource (which exists in Wine). It was trivial to code the functionality for the flow of CreateScalableFontResource as per the documentation but my research into the .FOT file format threw up a couple of questions. Even though .FOT files, as far as they're used by AddFontResource are little more than storage for a couple of pathnames, they are in fact Win3.1-style NE-binary files. With that in mind, 1) AFAICT, there is no code in Wine currently to save NE-binaries to disk, although obviously they are loadable and data structures relating to the format are defined. Rather than write a standalone, .FOT saving function, based off the kind of code you see in the fnt2fon program - .FON files are a similar, though not identical format - would it be better to write something like a NE_SaveModule that takes an in-memory NE module and saves it to disk, and call that from my .FOT saving code? This would live in ne_module.c I guess, and be limited, certainly initially, to the context in which I'd be using it. IE, just saving the resources. Indeed, I don't know in what other context that code WOULD be used, but who knows, down the line someone might want to expand it to do something more useful. 2) NE binaries, including FOT files, contain as part of the header a DOS stub-executable that typically spits out a message of some sort. I reasoned that being in itself a compiled binary we can't legally use the blob of binary that would appear in a real-world FOT file as-is, and I certainly wasn't about to go decompiling it, so I lifted the DOS stub executable from fnt2fon which I'm assuming as it's distributed with WINE is fair game. This will mean .FOT files generated by my code will be slightly different to a real, "in-the-wild" .FOT file, but I'm not sure in the circumstances that matters as the file is typically temporary, and only used as a container, never to be run - it's just different from a user perspective. Is this OK? Also, are there any open-source requirements on that small binary blob? Fnt2fon certainly includes it with no added info. 3) Related to item 2, so far, the actual spec of the .FOT file format has eluded me, though knowing that it's a NE binary has enabled me to reverse a lot of it, which I'm yet to test but I believe will be enough to fool AddFontResource into doing what it's supposed to do. Again, is it enough to go that far for now as the FOT format seems to be unsupported in WINE? Advice on these points would help me help you :) -- Chris Howe

2 1

DirectX 10 start as a SoC project?
by Stefan Dösinger 13 Mar '07

13 Mar '07

Hi, Thinking about SoC I though that starting a DirectX 10 implementation may be a good summer of code project. I do not mean implementing the full d3d10 lib, that would be way to much, more starting the infrastructure. Henri disagreed with the idea, so I thought I'll write a mail for public discussion :-) . Looking at the timeline for SoC I hope it isn't too late. My idea is to start a d3d10 implementation up to the following point: -> Add a winver Windows Vista to make version checkers happy :-) -> Create the d3d10 lib and start the .idl file for header generation -> Write stubs for the functions to allow the app to create all the interfaces -> Write test cases for reference counting. ddraw and d3d9 show that Microsoft does not stick to its own COM rules -> Make methods that have already 1:1 equivalents in wined3d call wined3d. Add other methods as required to wined3d. -> Implement them as far as you feel like :-) I think the good thing about this is that there are is not much knowledge about wined3d and d3d10 necessary at the start. The one who works on it can learn the d3d10 interface while writing the stubs and learn about wined3d when starting to call it. Opinions? Suggestions? Cheers, Stefan

11 21

Re: CreateScalableFontResource - a few questions
by Juan Lang 13 Mar '07

13 Mar '07

Hi Chris, > For my first foray into contributing to Wine Welcome! > would it be better to write something like a NE_SaveModule that takes > an in-memory NE module and saves it to disk, and call that from my > .FOT saving code? Only if it makes your code more readable. In general Wine doesn't share code between modules, unless Windows does. So this would almost certainly be kept in gdi32, unless you know of a public Windows API that does what you suggest. > 2) NE binaries, including FOT files, contain as part of the header > a DOS stub-executable that typically spits out a message of > some sort. I reasoned that being in itself a compiled binary we > can't legally use the blob of binary that would appear in a > real-world FOT file as-is, and I certainly wasn't about to go > decompiling it, so I lifted the DOS stub executable from fnt2fon > which I'm assuming as it's distributed with WINE is fair game. That seems reasonable to me. > Also, are there any open-source requirements on that small binary > blob? Fnt2fon certainly includes it with no added info. Taking it from fnt2fon seems safe enough to me too. > 3) Related to item 2, so far, the actual spec of the .FOT file > format has eluded me, though knowing that it's a NE binary has > enabled me to reverse a lot of it, which I'm yet to test but I > believe will be enough to fool AddFontResource into doing what > it's supposed to do. Again, is it enough to go that far for now > as the FOT format seems to be unsupported in WINE? Yes, that's probably enough for now. --Juan ____________________________________________________________________________________ 8:00? 8:25? 8:40? Find a flick in no time with the Yahoo! Search movie showtime shortcut. http://tools.search.yahoo.com/shortcuts/#news

1 0

Re: wined3d: Set wrapmode for cubemags to clamp regardeless of the sampler state
by Stefan Dösinger 12 Mar '07

12 Mar '07

Am Samstag 10 März 2007 15:02 schrieb Fabian Bieler: > This Patch forces GL_CLAMP_TO_EDGE on all cubemaps. > > I tested this on XP with some Radeon X1???. > > Also, this fixes some renderissues Half-Life 2. Say, does that fix the strange quad boarders like in this screenshot? http://bugs.winehq.org/attachment.cgi?id=5297&action=view (Eve Online). It sounds like it would do that, I'm very impressed :-) How did you test that? It sounds like a test case using the visual test framework is worth an investigation. I can try to write a test for that.

3 4

WineHQ maintenance
by Jeremy Newman 12 Mar '07

12 Mar '07

I will be performing some maintenance to WineHQ today at 14:30 CST. The recent outages on WineHQ were attributed to a faulty drive in the RAID. I will be taking the server offline to replace that drive. The server should only be offline for about 20 minutes. -newman

1 0

LockRect Problem
by Erich Hoover 12 Mar '07

12 Mar '07

I'm looking into a problem that causes Supreme Commander to segfault (Bug #7643 <http://bugs.winehq.org/show_bug.cgi?id=7643>) and I believe I may have run into a problem with IWineD3DSurfaceImpl_LockRect. I believe the problem is a typo in the line: > This->resource.allocatedMemory = HeapAlloc(GetProcessHeap() ,0 , This-> > resource.size + 4); I think that the allocated memory should be the size of the resource multiplied by 4 (instead of adding 4). With the current allocation, for some textures, the operation to calculate the pBits location returns a memory address that is past the end of the allocated memory. So, after this operation: > pLockedRect->pBits = This->resource.allocatedMemory + (pLockedRect->Pitch > * pRect->top) + (pRect->left * This->bytesPerPixel) > the value of pLockedRect->pBits is greater than "This-> resource.allocatedMemory + This->resource.size + 4". I've dug around a bit to see if This->resource.size was just allocated incorrectly but that does not appear the case. So, if someone could confirm or deny that this is a typo problem then I'd really appreciate it. Erich Hoover ehoover(a)mines.edu

3 4

fog with pixel shaders < 3.0
by Fabian Bieler 12 Mar '07

12 Mar '07

Hello! I'd like to get fog working in conjunction with pixel shaders 2.0 or earlier. The problem is that said shaders don't replace the fog stage in Direct3D. Adding the necessary fog calculations to a GLSL fragment shader is trivial, however, this results in a dependency of the shader on the current fog state. Now, I have thought up three solutions for this problem: 1) Compile two versions of every fragment shader (one with fog and one without) and choose the appropriate one according to the state. Pro: Probably performance wise the cheapest solution Con: Generates more shaders, however, as shader are only compiled on demand, this shouldn't be too bad. 2) Rebuild the shader whenever it is bound in conjunction with a changed fog state. Pro: ? Con: This would be a performance killer as it would potentially cause multiple calls of IWineD3DPixelShaderImpl_CompileShader per frame, as some Programs use the same fragment shader for rendering with and without fog. (ok, I only know this of source based games, but imo that's bad enough) 3) Add Fog calculation to every shader, enabling or disabling it at runtime via a constant factor of 1.0 or 0.0 depending on the fog state which is supplied as a shader constant. Pro: cpu-load wise cheap Con: Adds some more instructions to fragment shader code. Now, I don't particularly like any of these solutions, so I'd welcome other ideas, comments or suggestions. Fabian P.S: I noticed that fog-state management is not yet included in the state table. Should a patch that fixes fog with pixel shaders wait until this is done, or is this of no importance?

3 8

Re: [2/2] imm32: Fix the unwanted root_context string buffer cleanup code.
by Byeong-Sik Jeon 12 Mar '07

12 Mar '07

I'm sorry. This patch don't fix kinput2 case. kinput2 case may be wanted situation. but this patch fix the 'nabi' and 'scim' case. Hmm, I'll stop the my poor patch series. Thank you. Byeong-Sik Jeon worte: > kinput2: Japanese xim. when we press japanese/english toggle key > at the composition state before commit, we lost composition > string. > nabi : Korean xim. same 'kinput2' case. > scim : General IM platform. when we input Japanese string, if > we press the "commit key(ENTER)", then we lost the all > composition string. > > This patch fix all above. > --- > dlls/imm32/imm.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-)

1 0

mswsock.dll, Soc & legal questions
by Benoit Pradelle 12 Mar '07

12 Mar '07

Hi, I'm pretty interested in implementing mswsock.dll as a SoC this summer : this dll seems to be used by many apps and it's, I think, the sort of job I can do. As I'm not a Wine dev, I was wondering about how should I work for implementing this lib : should I juste use the MSDN description of the functions and make some tests with some apps to validate the behavior ? Or can I take the original dll, execute some apps with it and try to see how the dll is interacting with other libs, what sort of network traffic is generated, etc ? Is this solution possible with the microsoft license ? Thanks, Ben

2 2

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.
by Aric Stewart 12 Mar '07

12 Mar '07

I am pretty sure that these are done via SendMessage when I checked with Spy++. Additional a number of the applications I am working with hang when the WM_IME_NOTIFY is sent out of order. -aric Byeong-Sik Jeon wrote: > We have to call PostMessage to send WM_IME_NOTIFY message. > To send WM_IME_CONTROL, we use SendMessage, but WM_IME_NOTIFY is not... > > changelog: > Use the PostMessageW for WM_IME_NOTIFY message. > --- > dlls/imm32/imm.c | 25 ++++++++----------------- > 1 files changed, 8 insertions(+), 17 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c > index 02a362e..034d4ea 100644 > --- a/dlls/imm32/imm.c > +++ b/dlls/imm32/imm.c > @@ -77,8 +77,8 @@ static UINT WM_MSIME_DOCUMENTFEED; > */ > static LRESULT WINAPI IME_WindowProc(HWND hwnd, UINT uMsg, WPARAM wParam, > LPARAM lParam); > +static LRESULT ImmInternalPostIMEMessage(UINT, WPARAM, LPARAM); > static void UpdateDataInDefaultIMEWindow(HWND hwnd); > -static void ImmInternalPostIMEMessage(UINT, WPARAM, LPARAM); > static void ImmInternalSetOpenStatus(BOOL fOpen); > > static VOID IMM_PostResult(InputContextData *data) > @@ -160,16 +160,7 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpReserved) > } > > /* for posting messages as the IME */ > -static void ImmInternalPostIMEMessage(UINT msg, WPARAM wParam, LPARAM lParam) > -{ > - HWND target = GetFocus(); > - if (!target) > - PostMessageW(root_context->hwnd,msg,wParam,lParam); > - else > - PostMessageW(target, msg, wParam, lParam); > -} > - > -static LRESULT ImmInternalSendIMENotify(WPARAM notify, LPARAM lParam) > +static LRESULT ImmInternalPostIMEMessage(UINT msg, WPARAM wParam, LPARAM lParam) > { > HWND target; > > @@ -177,7 +168,7 @@ static LRESULT ImmInternalSendIMENotify(WPARAM notify, LPARAM lParam) > if (!target) target = GetFocus(); > > if (target) > - return SendMessageW(target, WM_IME_NOTIFY, notify, lParam); > + return PostMessageW(target, msg, wParam, lParam); > > return 0; > } > @@ -214,7 +205,7 @@ static void ImmInternalSetOpenStatus(BOOL fOpen) > else > ShowWindow(hwndDefault, SW_SHOWNOACTIVATE); > > - ImmInternalSendIMENotify(IMN_SETOPENSTATUS, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETOPENSTATUS, 0); > } > > > @@ -1243,7 +1234,7 @@ BOOL WINAPI ImmSetCompositionFontA(HIMC hIMC, LPLOGFONTA lplf) > MultiByteToWideChar(CP_ACP, 0, lplf->lfFaceName, -1, data->font.lfFaceName, > LF_FACESIZE); > > - ImmInternalSendIMENotify(IMN_SETCOMPOSITIONFONT, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETCOMPOSITIONFONT, 0); > > if (data->textfont) > { > @@ -1267,7 +1258,7 @@ BOOL WINAPI ImmSetCompositionFontW(HIMC hIMC, LPLOGFONTW lplf) > return FALSE; > > memcpy(&data->font,lplf,sizeof(LOGFONTW)); > - ImmInternalSendIMENotify(IMN_SETCOMPOSITIONFONT, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETCOMPOSITIONFONT, 0); > > if (data->textfont) > { > @@ -1418,7 +1409,7 @@ BOOL WINAPI ImmSetCompositionWindow( > if (reshow) > ShowWindow(hwndDefault,SW_SHOWNOACTIVATE); > > - ImmInternalSendIMENotify(IMN_SETCOMPOSITIONWINDOW, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETCOMPOSITIONWINDOW, 0); > return TRUE; > } > > @@ -1447,7 +1438,7 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) > if (hIMC == (HIMC)FROM_IME) > { > ImmInternalSetOpenStatus(fOpen); > - ImmInternalSendIMENotify(IMN_SETOPENSTATUS, 0); > + ImmInternalPostIMEMessage(WM_IME_NOTIFY, IMN_SETOPENSTATUS, 0); > return TRUE; > } >

2 3

Re: imm32: Use the PostMessageW for WM_IME_NOTIFY message.
by Dmitry Timoshkov 12 Mar '07

12 Mar '07

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > We have to call PostMessage to send WM_IME_NOTIFY message. > To send WM_IME_CONTROL, we use SendMessage, but WM_IME_NOTIFY is not... > > changelog: > Use the PostMessageW for WM_IME_NOTIFY message. Aric just changed the code to use SendMessage for WM_IME_NOTIFY message. Sounds like it's time to write some message tests or look at the existing ones (which confirm that WM_IME_SETCONTEXT and WM_IME_NOTIFY are sent, not posted). -- Dmitry.

2 3

Re: Add implementation of D3DRMVector* functions
by Dmitry Timoshkov 12 Mar '07

12 Mar '07

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll > I am sending the patch to this mailing list as this was posted on > bugzilla and awaiting review. 1. it's not really nice to send something with name attachment.cgi as a patch. 2. the patch has inconsistent formatting and very hard to read due to that 3. the patch is extremely buggy in memory allocations: instead of allocating the space for an object it allocates the space only for a pointer. I'd suggest to allocate all the objects on the stack instead. -- Dmitry.

3 2

Re: Add implementation of D3DRMVector* functions
by H. Verbeet 12 Mar '07

12 Mar '07

On 12/03/07, Vijay Kiran Kamuju <infyquest(a)gmail.com> wrote: > Hi, > > This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll > I am sending the patch to this mailing list as this was posted on > bugzilla and awaiting review. > A few comments: >- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA >+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 0;2110;-130;1, USA I don't think that change should be there. >+ LPD3DVECTOR result=(LPD3DVECTOR)(malloc(sizeof(LPD3DVECTOR))); That and other places in that patch should be using HeapAlloc/HeapFree >+LPD3DVECTOR D3DRMAPI D3DRMVectorRandom(LPD3DVECTOR d) >+{ >+ >+ srand(time(NULL)); >+ d->x=(float)(rand()); >+ d->y=(float)(rand()); >+ d->z=(float)(rand()); >+ TRACE("Random vector=(%f,%f,%f)\n",d->x,d->y,d->z); >+ return d; >+} I'm not sure about this, but I'm thinking it might be better to generate a normalized vector there. - The indentation in D3DRMVectorRotate is a bit of a mess - Writing test cases doesn't hurt, and in this case should be pretty easy

2 1

Re: [try 3] wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Stefan Dösinger 12 Mar '07

12 Mar '07

Am Montag 12 März 2007 11:54 schrieb Fabian Bieler: > On Monday 12 March 2007 10:39, Stefan Dösinger wrote: > > You seem to add a 2nd table for GL_NV_texture_shader3 formats and try > > this table first. It is another solution for the static table problem I > > haven't thought of yet. For now, can you just hardcode the formats in the > > normal table? It should not cause any issues otherwise, because the > > function looking for a surface conversion will filter them out anyway. > > This patch includes the requested changes. I did not implement the > conversions for the new pixel formats, as that would not help anything > without also alterting the fragment shaders. Almost perfect :-) + {WINED3DFMT_X8L8V8U8 ,0x0 ,0x0 ,0x0 ,0x0 ,4 ,FALSE ,GL_DSDT8_MAG8_INTENSITY8_NV,GL_DSDT_MAG_INTENSITY_NV,GL_BYTE}, Can you align the } with the other lines? (I'm picky because it is very tricky to fix the formating afterwards)

1 0

Re: wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Stefan Dösinger 12 Mar '07

12 Mar '07

Am Montag 12 März 2007 00:30 schrieb Fabian Bieler: > The same patch as before, but with GL_DSDT_NV instead of GL_HILO8_NV as > suggested by Frank Richter. You seem to add a 2nd table for GL_NV_texture_shader3 formats and try this table first. It is another solution for the static table problem I haven't thought of yet. For now, can you just hardcode the formats in the normal table? It should not cause any issues otherwise, because the function looking for a surface conversion will filter them out anyway. It is mostly my own fault; When I created that pixel format table almost a year ago, we only had static formats which were supported by the gl core, or by a max of one extension. Nowadays the table hits the limit with bump map formats, and sRGB textures. I think it is time to think about changing the design. A few ideas by me: * Stop making the table static and keep one table per adapter. Then we can insert the proper formats depending on the supported extensions at initialization time +: One table to search for a format -: No solution for sRGB * Duplicate the tables, create extra tables for sRGB formats and per-extension tables +: Tables stay static -: Multiple tables look nasty. Can get out of control * Put one format into the table, select other per-extension formats in d3dfmt_get_conv. +: One table +: Simmilar to the color keying and palette handling -: No solution for sRGB -: Complicated, final format hard to read from pixel format table * Add extra columns to the table to allow multiple table entries per format: like a flag sRGB, and a supported extension. +: One table, stays static +: Deals with sRGB formats -: Searching for a format gets more complex, will be more expensive than with the many tables approach. * Replace the table with a function with a huge switch statement. +: Can deal with all sorts of parameters dynamically +: Not really more expensive than a lookup table with a linear search +: If done right should be easy to read -: We have had that before, it didn't look nice(ok, it used 3 different functions)

1 0

Re: wined3d: Allow SetCursorProperties on existing cursor
by Erich Hoover 12 Mar '07

12 Mar '07

> > Am Samstag 10 März 2007 06:10 schrieb Erich Hoover: > >* Real Name: > *>* Erich Hoover > *>* Description: > *>* The SetCursorProperties call needs to be capable of being performed on > *>* existing cursors. The current behavior removes the cursor handle at the > *>* beginning of any SetCursorProperties call (and on Uninit3D). The removal > *>* of the cursor on SetCursorProperties is counter to the documentation and > *>* causes some applications to lose the cursor when SetCursorProperties is > *>* re-issued (See Bug #7619 <http://bugs.winehq.org/show_bug.cgi?id=7619>). > *>* This patch corrects this issue and permits SetCursorProperties to retrieve > *>* the gl texture of an old cursor. > *>* Changelog: > *>* wined3d: Allow SetCursorProperties on existing cursor > *This is not completely correct: > > The application can Release the d3d surface after setting the cursor. This > would also delete the gl texture used to draw the cursor. Also, the apps can > potentially change the surface and call PreLoad. This would change the cursor > without SetCursorProperties(The cursor texture does not have to be in > D3DPOOL_SCRATCH, so the app can preload it manually). > > But you are right, a non-dirty surface causes issues with the current code. I > think you can fix that by modifying LoadTexture not to release the surface > memory is SFLAG_FORCELOAD is passed. (Or better, fix the SFLAG_DONOTFREE > macro in wined3d_private.h). Then, when SetCursorProperties sets the surface > texture to 0 remove SFLAG_INTEXTURE from the surface flags. > > The API documentation doesn't say anything about an application releasing the d3d surface, but the documentation in the code seems to indicate that the gl texture needs to remain when the surface is deleted - I did nothing to change this. What I did see as requiring a change is the call to "glDeleteTextures(1, &This->cursorTexture);" at the beginning of SetCursorProperties. Maybe I'm not understanding you correctly, but in my mind it is necessary to remove this call so that applications that re-use the same cursor can do so. This change (in combination with the change for non-dirty surfaces) was also experimentally verified to fix the problem I was experiencing (See Bug #7619<http://bugs.winehq.org/show_bug.cgi?id=7619>). I will look into changing/implementing the flags to eliminate the "non-dirty surface" problem. Erich Hoover ehoover(a)mines.edu

4 12

Re: quartz: Check allocation failure and clear memory in DSound Renderer
by Detlef Riekenberg 12 Mar '07

12 Mar '07

On Fr, 2007-03-09 at 03:02 -0800, Chris Robinson wrote: > + ZeroMemory(pDSoundRender, sizeof(DSoundRenderImpl)); Since you clear the whole struct, ... > pDSoundRender->lpVtbl = &DSoundRender_Vtbl; > pDSoundRender->IBasicAudio_vtbl = &IBasicAudio_Vtbl; > @@ -325,9 +328,15 @@ HRESULT DSoundRender_create(IUnknown * pUnkOuter, > LPVOID * ppv) > pDSoundRender->pClock = NULL; > pDSoundRender->init = FALSE; > pDSoundRender->started = FALSE; ... there is no need to clear it again. -- By by ... Detlef

5 8

A Reminder : A Study on Free/Open Source Software
by Anu Gupta DCSA 12 Mar '07

12 Mar '07

Dear Wine Contributors, I seek help from designers, developers, testers,defect fixers,project managers or playing any other key role in Free/Open Source software development or maintenence in carrying out a study on practices and problems of defect management in various Free/Open Source Software projects. The insights gained from the study can further help us to extract publicly accessible defect data and determine impact of defect management practices on software quality. Please spend a few minutes of your precious time to fill up the Questionnaire. The most of the questions follow multiple choice formats and are quite easy to answer. To have the Online Questionnaire, please visit: http://anu.puchd.ac.in/phpESP/public/survey.php?name=FOSS_Defect_Survey (You can also copy and paste this link into your browser, and hit the 'Return' key.) I hope you will find all the questions interesting and thought-provoking. Your answers will be kept anonymous.The data thus collected will only be used for research purpose.It would be nice if you may further refer this mail to others actively engaged with Free/Open Source Software development. If you have any query or suggestions then feel free to contact. Thank You With regards, Anu Gupta Senior Lecturer Department of Computer Science and Applications, Panjab University, Chandigarh. INDIA In case of any problem in accessing/using the above mentioned link please contact: E-mail: anugupta(a)pu.ac.in anugupta98(a)gmail.com

1 0

Time for an advapi category in bugzilla?
by Dan Kegel 12 Mar '07

12 Mar '07

I just filed a bug related to wine's advapi implementation ( http://bugs.winehq.org/show_bug.cgi?id=7690 ) and noticed there wasn't an advapi category in Bugzilla. Should there be? - Dan

1 0

Re: mapi32: Add DebugInfo to critical sections.
by Uwe Bonnes 12 Mar '07

12 Mar '07

>>>>> "Jan" == Jan Zerebecki <jan.wine(a)zerebecki.de> writes: Jan> --- If this patch is rejected from inclusion, please tell me why, Jan> as I would have to ask anyway. Nice disclaimer ;-) I wonder if it works? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Frank Richter 11 Mar '07

11 Mar '07

On 10.03.2007 15:02, Fabian Bieler wrote: > +static const PixelFormatDesc NV_texture_shader_formats[] = { > + {WINED3DFMT_V8U8 ,0x0 ,0x0 ,0x0 ,0x0 ,2 ,FALSE ,GL_SIGNED_HILO8_NV ,GL_HILO_NV ,GL_BYTE }, Are you sure this is right? From the NV_texture_shader spec it looks to me like HILO is for high-precision data, and that DSDT (described as offset data) would be more appropriate for V8U8. -f.r.

2 1

Re: Alexandre Julliard : ntdll: Fixed a compiler warning for size_t/ unsigned int mismatch.
by Francois Gouget 11 Mar '07

11 Mar '07

On Fri, 9 Mar 2007, Alexandre Julliard wrote: [...] > void * __cdecl _lfind( const void *key, const void *base, unsigned int *nmemb, > - unsigned int size, int(*compar)(const void *, const void *) ) > + size_t size, int(*compar)(const void *, const void *) ) > { > - return lfind( key, base, nmemb, size, compar ); > + size_t n = *nmemb; > + return lfind( key, base, &n, size, compar ); > } The problem is that Microsoft's _lfind() takes an 'unsigned int' and not a size_t. Or, more precisely, the msvcrt one declared in search.h does. There's no official prototype for the ntdll implementation that I know of, but I'd expect it to have the same prototype. So my understanding is that replacing this parameter type with a size_t could be a problem on 64bit systems. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Stolen from an Internet user: "f u cn rd ths, u cn gt a gd jb n cmptr prgrmmng !"

2 3

DIB Engine & GSoC
by Benoit Pradelle 11 Mar '07

11 Mar '07

Hi, I would like participate to the Google Summer Of Code with Wine by implementing a DIB Engine. I've searched a lot of informations about the DIB Engine but i still got one question : for you, how important is a DIB Engine in Wine ? Ben. ___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com

10 14

Tackling gdiplus?
by Dan Kegel 11 Mar '07

11 Mar '07

An increasing number of apps need gdiplus.dll. Seems like it's time for Wine to include it. Since Mono has implemented much of gdiplus already ( http://www.mono-project.com/Libgdiplus ), we ought to be able to just slurp that into Wine and get quite a ways. Any objections? I'm thinking of asking a summer intern to try this. - Dan

5 8

Memory checking?
by Giles Cameron 11 Mar '07

11 Mar '07

Ok. I am just entering the WINE development crowd, and have very very little experiance with the Windows API (The first time I saw it, I was terrifyed!) Anywho. It would appear that some programs decide there isn't enough free memory available for their tasks (EG, Train Simulator's CAB extaction process, I have yet to look further into this to see if I even have the slightest clue what I am talking about, however) so I was wondering if we could hack in an option to allow the API to tell a little fib on the free memory, since (From what I understand) Linux is so much better with memory. Sorry if I am randomly babbling, my brain is off around 02:30. ;) (Thats my current local time.)

2 1

0.9.32 hangs UltraVNC Viewer after a while
by Dieter Rogiest 11 Mar '07

11 Mar '07

Mandriva Linux 2007.0 here. With wine 0.9.30 ultravnc_viewer.exe (remote access) works perfect. I installed wine 0.9.32 (wine-0.9.32-1.SoS.2007.0.i586.rpm). Using ultravnc_viewer.exe I saw immediately that the fullscreen title bar that should appear when you move your mouse to the top of the screen was now allways visible also in windowed mode. After a while (4 minutes) ultravnc_viewer stopped working, I could still see the remote desktop but my mouse clicks didn't happen. I went back to 0.9.30. Dieter

3 2

Known desktop migration projects and their "must have" Windows apps
by Dan Kegel 11 Mar '07

11 Mar '07

I'm putting a list together at http://wiki.winehq.org/DesktopMigrationProjects listing organizations who are migrating their users from Windows to Linux. I only list projects that have come out and said which Windows applications they really want to run on Linux. Since these migration projects, if they end up using Wine, will be very good publicity for the project, it might behoove us to look carefully at whether we can get the apps they need running. I know Banco do Brasil's folks are quite happy at the effort put into Lotus Notes 5.x recently, so it is possible for us to make a difference. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

appdb needs to allow untested applications sometimes
by Dan Kegel 11 Mar '07

11 Mar '07

I tried to add an appdb entry for FINView because it's one of the applications required by the LiMux project, and I'm trying to add links into the appdb for all apps listed on http://wiki.winehq.org/LiMuxWineKeller . It's an addon for a commercial product I don't have, so I couldn't test it. That means I had to lie to the appdb to get it to accept the entry. Appdb maintainers, please remove the "only submit tested applications" restriction from the appdb, or at least allow people who know what they're doing to get around it.

4 4

Re: WineD3D: Blit the offscreen texture into the drawable if needed
by Ivan Gyurdiev 11 Mar '07

11 Mar '07

> This time cube texture support is added. Hopefully the coords are right, I had > no test app for them. If not it should be easy to spot the very > characteristic flipping of the image. > I'm confused - you replaced a patch which had no support for cube maps, with one that has untested support for cube maps?

2 1

Re: wined3d: Implented signed texture formats via NV_TEXTURE_SHADER
by Stefan Dösinger 11 Mar '07

11 Mar '07

Am Samstag 10 März 2007 15:02 schrieb Fabian Bieler: > This patch implements D3DFMT_V8U8 and D3DFMT_Q8W8V8U8 via > NV_TEXTURE_SHADER. This fixes some renderissues in Half-Life 2 with the > DirectX9 path and the DirectX8 path via GLSL. What do those formats provide that other formats do not provide? Signedness, or something else I missed? Using GL_NV_texture shader and GL_ATI_envmap bumpmap is definitly the way to go, but I am concerned about macos, where neither of those extensions exist. But working around that issue will be tricky because the shaders depend more on the stateblock then, and things get increasingly ugly. Oh, and it seems that you have proven me wrong with my suspicion that sRGB correction is the cause of that :-)

3 2

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS fix
by Felix Nawothnig 10 Mar '07

10 Mar '07

Andrew O.Shadoura wrote: > +#if 0 > static int once; > +#endif > > if (!src || (!dst && dstlen)) > { > @@ -1774,11 +1783,13 @@ INT WINAPI MultiByteToWideChar( UINT pag > > if (srclen < 0) srclen = strlen(src) + 1; > > +#if 0 > if (!once && (flags & MB_USEGLYPHCHARS)) > { > once = 1; > FIXME("MB_USEGLYPHCHARS not supported\n"); > } > +#endif If you implemented MB_USEGLYPHCHARS just remove the FIXME. Don't submit dead code - git will remember all revisions... Felix

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel