- wine-devel - winehq.org

XCOPY support
by Ann & Jason Edmeades 20 Feb '07

20 Feb '07

Hi, Looking at the cmd.exe bugs in the database, one is caused by a lack of XCOPY support. Does anyone have anything like this in their tree, or should I try to knock something up? I also assume it needs to be a separate program, not part of cmd.exe, to mimic how windows does it? Jason

1 0

Re: [2/2] quartz: Return proper error codes from GraphBuilder_RenderFile
by Mirek 20 Feb '07

20 Feb '07

Hi, this patch caused regression in TES IV: Oblivion, now it can't run, here is output: fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found wine: Unhandled page fault on read access to 0xffffffea at address 0x7bfd278f (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0xffffffea in 32-bit code (0x7bfd278f). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7bfd278f ESP:0034f098 EBP:0034f1d0 EFLAGS:00010282( - 00 - RIS1) EAX:00000001 EBX:7bffec00 ECX:0034f198 EDX:ffffffea ESI:80004005 EDI:00000001 Stack dump: 0x0034f098: 115cc680 00000001 0034f198 0034f19c 0x0034f0a8: 00000000 00000001 00000001 0034f150 0x0034f0b8: 00000000 00000000 00000000 00000000 0x0034f0c8: 00000000 00000000 00000000 00000000 0x0034f0d8: 0034f108 7efa09be 7bff527c 0034f19c 0x0034f0e8: 0034f198 0034f1ac 0034f1a8 00000010 Backtrace: =>1 0x7bfd278f GraphBuilder_RenderFile+0x66f(iface=0x115cb968, lpcwstrFile=0x34f3f0, lpcwstrPlayList=0x0) [/usr/src/wine/dlls/q uartz/filtergraph.c:1094] in quartz (0x0034f1d0) 2 0x0069302b in oblivion (+0x29302b) (0x00000008) 3 0x00000000 (0x00000000) 0x7bfd278f GraphBuilder_RenderFile+0x66f [/usr/src/wine/dlls/quartz/filtergraph.c:1094] in quartz: movl 0x0(%edx),%eax 1094 IBaseFilter_Release(psplitter); Modules: Module Address Debug info Name (109 modules) PE 400000-b59000 Export oblivion PE b60000-daf000 Deferred d3dx9_27 PE 18000000-18068000 Deferred binkw32 PE 70000000-700b2000 Deferred dinput8 ELF 7b2de000-7b2f2000 Deferred avicap32<elf> \-PE 7b2e0000-7b2f2000 \ avicap32 ELF 7b2f2000-7b38b000 Deferred oleaut32<elf> \-PE 7b300000-7b38b000 \ oleaut32 ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7bf81000-7bfa8000 Deferred msvfw32<elf> \-PE 7bf90000-7bfa8000 \ msvfw32 ELF 7bfa8000-7c000000 Dwarf quartz<elf> \-PE 7bfb0000-7c000000 \ quartz ELF 7c4b4000-7c4bf000 Deferred libgcc_s.so.1 ELF 7c5a4000-7c634000 Deferred libglu.so.1 ELF 7c634000-7c653000 Deferred devenum<elf> \-PE 7c640000-7c653000 \ devenum ELF 7c653000-7c70d000 Deferred wined3d<elf> \-PE 7c660000-7c70d000 \ wined3d ELF 7c70d000-7c737000 Deferred d3d9<elf> \-PE 7c710000-7c737000 \ d3d9 ELF 7c857000-7c86b000 Deferred winejoystick<elf> \-PE 7c860000-7c86b000 \ winejoystick ELF 7c86b000-7c882000 Deferred cfgmgr32<elf> \-PE 7c870000-7c882000 \ cfgmgr32 ELF 7c882000-7c8de000 Deferred setupapi<elf> \-PE 7c890000-7c8de000 \ setupapi ELF 7c8de000-7c8f2000 Deferred hid<elf> \-PE 7c8e0000-7c8f2000 \ hid ELF 7c9ed000-7caae000 Deferred libasound.so.2 ELF 7caae000-7cad9000 Deferred winealsa<elf> \-PE 7cac0000-7cad9000 \ winealsa ELF 7cad9000-7cb0b000 Deferred uxtheme<elf> \-PE 7cae0000-7cb0b000 \ uxtheme ELF 7cd9e000-7cdb3000 Deferred midimap<elf> \-PE 7cda0000-7cdb3000 \ midimap ELF 7cdb3000-7cdb8000 Deferred libxfixes.so.3 ELF 7cdbd000-7cdd5000 Deferred msacm32<elf> \-PE 7cdc0000-7cdd5000 \ msacm32 ELF 7cdd7000-7cdda000 Deferred libxinerama.so.1 ELF 7cddd000-7cdf9000 Deferred imm32<elf> \-PE 7cde0000-7cdf9000 \ imm32 ELF 7d7a3000-7d7a5000 Deferred libnvidia-tls.so.1 ELF 7d7a5000-7e116000 Deferred libglcore.so.1 ELF 7e116000-7e1aa000 Deferred libgl.so.1 ELF 7e1aa000-7e1af000 Deferred libxdmcp.so.6 ELF 7e1af000-7e1b2000 Deferred libxau.so.6 ELF 7e1b2000-7e29e000 Deferred libx11.so.6 ELF 7e29e000-7e2ac000 Deferred libxext.so.6 ELF 7e2ac000-7e2b1000 Deferred libxxf86vm.so.1 ELF 7e2b1000-7e2c9000 Deferred libice.so.6 ELF 7e2c9000-7e2d2000 Deferred libsm.so.6 ELF 7e2d3000-7e2dc000 Deferred libxcursor.so.1 ELF 7e2dc000-7e2df000 Deferred libxrandr.so.2 ELF 7e2df000-7e2e7000 Deferred libxrender.so.1 ELF 7e2f1000-7e37f000 Deferred winex11<elf> \-PE 7e300000-7e37f000 \ winex11 ELF 7e3fb000-7e41b000 Deferred libexpat.so.1 ELF 7e41b000-7e446000 Deferred libfontconfig.so.1 ELF 7e446000-7e45a000 Deferred libz.so.1 ELF 7e45a000-7e4c4000 Deferred libfreetype.so.6 ELF 7e4e3000-7e50f000 Deferred ws2_32<elf> \-PE 7e4f0000-7e50f000 \ ws2_32 ELF 7e50f000-7e529000 Deferred wsock32<elf> \-PE 7e520000-7e529000 \ wsock32 ELF 7e529000-7e58d000 Deferred msvcrt<elf> \-PE 7e540000-7e58d000 \ msvcrt ELF 7e58d000-7e5a1000 Deferred lz32<elf> \-PE 7e590000-7e5a1000 \ lz32 ELF 7e5a1000-7e5f9000 Deferred shlwapi<elf> \-PE 7e5b0000-7e5f9000 \ shlwapi ELF 7e5f9000-7e6ee000 Deferred shell32<elf> \-PE 7e610000-7e6ee000 \ shell32 ELF 7e6ee000-7e701000 Deferred libresolv.so.2 ELF 7e707000-7e720000 Deferred version<elf> \-PE 7e710000-7e720000 \ version ELF 7e720000-7e73e000 Deferred iphlpapi<elf> \-PE 7e730000-7e73e000 \ iphlpapi ELF 7e73e000-7e793000 Deferred rpcrt4<elf> \-PE 7e750000-7e793000 \ rpcrt4 ELF 7e793000-7e82c000 Deferred ole32<elf> \-PE 7e7a0000-7e82c000 \ ole32 ELF 7e82c000-7e875000 Deferred dsound<elf> \-PE 7e830000-7e875000 \ dsound ELF 7e875000-7e903000 Deferred winmm<elf> \-PE 7e880000-7e903000 \ winmm ELF 7e903000-7e949000 Deferred advapi32<elf> \-PE 7e910000-7e949000 \ advapi32 ELF 7e949000-7e9dc000 Deferred gdi32<elf> \-PE 7e960000-7e9dc000 \ gdi32 ELF 7e9dc000-7eb16000 Deferred user32<elf> \-PE 7ea00000-7eb16000 \ user32 ELF 7eb16000-7ebd6000 Deferred comctl32<elf> \-PE 7eb20000-7ebd6000 \ comctl32 ELF 7edd6000-7eefc000 Deferred kernel32<elf> \-PE 7edf0000-7eefc000 \ kernel32 ELF 7eefc000-7ef07000 Deferred libnss_files.so.2 ELF 7ef07000-7ef11000 Deferred libnss_nis.so.2 ELF 7ef11000-7ef27000 Deferred libnsl.so.1 ELF 7ef27000-7ef4c000 Deferred libm.so.6 ELF 7ef6b000-7f000000 Deferred ntdll<elf> \-PE 7ef80000-7f000000 \ ntdll ELF b7cb6000-b7cba000 Deferred libdl.so.2 ELF b7cba000-b7dec000 Deferred libc.so.6 ELF b7dec000-b7dfe000 Deferred libpthread.so.0 ELF b7e11000-b7e15000 Deferred iso8859-2.so ELF b7e15000-b7e1e000 Deferred libnss_compat.so.2 ELF b7e1e000-b7f2f000 Deferred libwine.so.1 ELF b7f31000-b7f48000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000a 0000000c 0 0000000b 0 00000008 (D) G:\usr\games\oblivion\Oblivion.exe 00000010 2 0000000f -1 0000000e -1 0000000d 15 00000009 0 <== Mirek Chris Robinson napsal(a): > > ------------------------------------------------------------------------ > > From 427782e216badd48afc917c85682bc5a1954b24b Mon Sep 17 00:00:00 2001 > From: Chris Robinson <chris.kcat(a)gmail.com> > Date: Wed, 14 Feb 2007 11:27:26 -0800 > Subject: [PATCH] quartz: Return proper error codes from GraphBuilder_RenderFile > > --- > dlls/quartz/filtergraph.c | 82 +++++++++++++++++++++++---------------------- > 1 files changed, 42 insertions(+), 40 deletions(-) > > diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c > index 8b38a3b..a3db8dd 100644 > --- a/dlls/quartz/filtergraph.c > +++ b/dlls/quartz/filtergraph.c > @@ -961,9 +961,9 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > IEnumPins* penumpins; > ULONG pin; > HRESULT hr; > - IEnumMoniker* pEnumMoniker; > + IEnumMoniker* pEnumMoniker = NULL; > GUID tab[2]; > - IPin** ppins; > + IPin** ppins = NULL; > ULONG nb; > IMoniker* pMoniker; > IFileSourceFilter* pfile = NULL; > @@ -972,6 +972,9 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > > TRACE("(%p/%p)->(%s, %s)\n", This, iface, debugstr_w(lpcwstrFile), debugstr_w(lpcwstrPlayList)); > > + if (lpcwstrPlayList != NULL) > + return E_INVALIDARG; > + > hr = IGraphBuilder_AddSourceFilter(iface, lpcwstrFile, string, &preader); > > /* Retrieve file media type */ > @@ -982,6 +985,13 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > IFileSourceFilter_Release(pfile); > } > > + if (SUCCEEDED(hr)) > + hr = IBaseFilter_EnumPins(preader, &penumpins); > + if (SUCCEEDED(hr)) { > + hr = IEnumPins_Next(penumpins, 1, &ppinreader, &pin); > + IEnumPins_Release(penumpins); > + } > + > if (SUCCEEDED(hr)) { > tab[0] = mt.majortype; > tab[1] = mt.subtype; > @@ -990,6 +1000,8 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > > if (FAILED(hr)) > { > + if (pEnumMoniker) > + IEnumMoniker_Release(pEnumMoniker); > if (preader) { > IGraphBuilder_RemoveFilter(iface, preader); > IBaseFilter_Release(preader); > @@ -1019,65 +1031,49 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > hr = IGraphBuilder_AddFilter(iface, psplitter, NULL); > if (FAILED(hr)) { > ERR("Unable add filter (%x)\n", hr); > - return hr; > + IBaseFilter_Release(psplitter); > + continue; > } > > /* Connect file source and splitter filters together */ > /* Make the splitter analyze incoming data */ > - hr = IBaseFilter_EnumPins(preader, &penumpins); > - if (FAILED(hr)) { > - ERR("Enumpins (%x)\n", hr); > - return hr; > - } > - hr = IEnumPins_Next(penumpins, 1, &ppinreader, &pin); > - if (FAILED(hr)) { > - ERR("Next (%x)\n", hr); > - return hr; > - } > - if (pin == 0) { > - ERR("No Pin\n"); > - return E_FAIL; > - } > - IEnumPins_Release(penumpins); > > hr = IBaseFilter_EnumPins(psplitter, &penumpins); > - if (FAILED(hr)) { > - ERR("Splitter Enumpins (%x)\n", hr); > - return hr; > - } > - hr = IEnumPins_Next(penumpins, 1, &ppinsplitter, &pin); > - if (FAILED(hr)) { > - ERR("Next (%x)\n", hr); > - return hr; > - } > - if (pin == 0) { > - ERR("No Pin\n"); > - return E_FAIL; > + if (SUCCEEDED(hr)) { > + hr = IEnumPins_Next(penumpins, 1, &ppinsplitter, &pin); > + IEnumPins_Release(penumpins); > } > - IEnumPins_Release(penumpins); > > - hr = IPin_Connect(ppinreader, ppinsplitter, NULL); > + if (SUCCEEDED(hr)) > + hr = IPin_Connect(ppinreader, ppinsplitter, NULL); > if (SUCCEEDED(hr)) { > /* Make sure there's some output pins in the filter */ > hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb); > - if(SUCCEEDED(hr)) { > + if (SUCCEEDED(hr)) { > if(nb > 0) { > TRACE("Successfully connected to filter\n"); > break; > } > CoTaskMemFree(ppins); > ppins = NULL; > - TRACE("No output pins found in filter\n"); > } > - IBaseFilter_Release(ppinsplitter); > - ppinsplitter = NULL; > + > + TRACE("No output pins found in filter\n"); > + hr = VFW_E_CANNOT_RENDER; > } > + > + IPin_Release(ppinsplitter); > + ppinsplitter = NULL; > + IGraphBuilder_RemoveFilter(iface, psplitter); > + IBaseFilter_Release(psplitter); > + ppinsplitter = NULL; > + > TRACE("Cannot connect to filter (%x), trying next one\n", hr); > - hr = E_FAIL; > } > > /* Render all output pin of the splitter by calling IGraphBuilder_Render on each of them */ > if (SUCCEEDED(hr)) { > + int partial = 0; > int i; > TRACE("pins to consider: %d\n", nb); > for(i = 0; i < nb; i++) { > @@ -1085,13 +1081,19 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > hr = IGraphBuilder_Render(iface, ppins[i]); > if (FAILED(hr)) { > ERR("Cannot render pin %p (%x)\n", ppins[i], hr); > - /* FIXME: We should clean created things properly */ > - break; > + partial = 1; > } > + IPin_Release(ppins[i]); > } > CoTaskMemFree(ppins); > + > + hr = (partial ? VFW_S_PARTIAL_RENDER : S_OK); > } > - > + > + if (psplitter) > + IBaseFilter_Release(psplitter); > + IBaseFilter_Release(preader); > + > return hr; > } > > > > ------------------------------------------------------------------------ > >

1 0

Re: [start][start][try2] Output with console encoding
by Robert Shearman 19 Feb '07

19 Feb '07

Anatoly Lyutin wrote: > + len = MultiByteToWideChar( CP_ACP, 0, message, -1, NULL, 0 ); > + bufW = HeapAlloc( GetProcessHeap(), 0, len ); > + len is in WCHARs, not bytes so this will cause heap corruption. It really would be a lot easier to make "output" take a Unicode string instead. -- Rob Shearman

1 0

Re: [PATCH] return when not finding the name
by Eric Pouech 19 Feb '07

19 Feb '07

Marcus Meissner a écrit : > --- > dlls/dbghelp/dwarf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c > index 4f74b6a..f51a948 100644 > --- a/dlls/dbghelp/dwarf.c > +++ b/dlls/dbghelp/dwarf.c > @@ -1203,7 +1203,7 @@ static void dwarf2_parse_enumerator(dwar > > TRACE("%s, for %s\n", dwarf2_debug_ctx(ctx), dwarf2_debug_di(di)); > > - if (!dwarf2_find_attribute(ctx, di, DW_AT_name, &name)) name.u.string = NULL; > + if (!dwarf2_find_attribute(ctx, di, DW_AT_name, &name)) return; > if (!dwarf2_find_attribute(ctx, di, DW_AT_const_value, &value)) value.u.svalue = 0; > symt_add_enum_element(ctx->module, parent, name.u.string, value.u.svalue); > > Hi Marcus, can you send me the ELF file(s) which is/are causing this? A+

2 2

Re: Resend 1/4 NtCreateMailslotFile tests
by Eric Pouech 19 Feb '07

19 Feb '07

Jeff Latimer a écrit : > Establish the framework for testing NtCreateMailslotFile. Have fixed > issues with NTSTATUS return codes etc. those tests belong to dlls/ntdll, not dlls/kernel32 also, if the test is for ntdll functions, it shouldn't use kernel32 ones... hence, NtClose should be used instead of CloseHandle A+

3 4

Re: [9/10] WineD3D: Use VBOs for index buffers
by H. Verbeet 19 Feb '07

19 Feb '07

On 19/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ GLint vbo; vbo should be a GLuint.

1 0

Re: winecfg: Add check for device access to Drives tab.
by Vitaliy Margolen 19 Feb '07

19 Feb '07

Any reasons why this patch is not applied? http://www.winehq.org/pipermail/wine-patches/2007-January/035264.html This is one of the major headaches for users trying to get programs requiring direct CD-ROM drive access to work. And it's nearly impossible to get required information from users to find if the direct access actually works or not. If there are some other ways to check this, please let me know. I'm sure everyone who tried to get something like Diablo II working will appreciate it! Vitaliy.

2 3

Re: comctl32: rebar[1/4]: rewrite the layouting code
by Alexandre Julliard 19 Feb '07

19 Feb '07

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > From 2b42e9b97b443ced2531a445b531fddc5db2dcad Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Sat, 17 Feb 2007 19:24:25 +0100 > Subject: [PATCH] comctl32: rebar: rewrite the layouting code This crashes in make test: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so rebar.c && touch rebar.ok wine: Unhandled page fault on read access to 0xffff001a at address 0x601bb75b (thread 0024), starting debugger... WineDbg starting on pid 0023 Unhandled exception: page fault on read access to 0xffff001a in 32-bit code (0x601bb75b). err:dbghelp:elf_load_debug_info_from_map Bad CRC for module (got 1ef14dcf while expecting 31f52e76) Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:601bb75b ESP:0033e50c EBP:0033e548 EFLAGS:00010202( - 00 - -RI1) EAX:ffff001a EBX:7b8aa9a0 ECX:00000002 EDX:00000000 ESI:00000000 EDI:ffffffff Stack dump: 0x0033e50c: 7b85b545 ffff001a 00000000 606a0081 0x0033e51c: 605b4fbc 0015df30 00000006 0033e548 0x0033e52c: 6055ddc0 00000040 0000000c 00000006 0x0033e53c: 605e9244 0015e0fc 0033f560 0033e578 0x0033e54c: 6055de30 00000000 00000000 ffff001a 0x0033e55c: ffffffff 00000000 00000000 0033e578 Backtrace: =>1 0x601bb75b strlen+0xb() in libc.so.6 (0x0033e548) 2 0x6055de30 Str_SetPtrAtoW+0x60(lppDest=0x15e10c, lpSrc=0xffff001a) [/home/julliard/wine/wine/dlls/comctl32/comctl32undoc.c:949] in comctl32 (0x0033e578) 3 0x605c06ef TOOLBAR_AddButtonsT+0x14f(hwnd=0x4002c, wParam=0x6, lParam=0x33f53c, fUnicode=0x0) [/home/julliard/wine/wine/dlls/comctl32/toolbar.c:2880] in comctl32 (0x0033e5c8) 4 0x605c2842 ToolbarWindowProc+0x1b52(hwnd=0x4002c, uMsg=<register EDI not in topmost frame>, wParam=0x6, lParam=0x33f53c) [/home/julliard/wine/wine/dlls/comctl32/toolbar.c:6622] in comctl32 (0x0033ee58) 5 0x606bb40a WINPROC_wrapper+0x1a() in user32 (0x0033ee88) 6 0x606bbb6b call_window_proc+0x6b(hwnd=<register EDI not in topmost frame>, msg=0x414, wp=0x6, lp=0x33f53c, result=0x33f3b8, arg=0x605c0cf0) [/home/julliard/wine/wine/dlls/user32/winproc.c:452] in user32 (0x0033eec8) 7 0x606beae7 WINPROC_CallProcAtoW+0x2c7(callback=0x606bbb00, hwnd=0x4002c, msg=0x414, wParam=0x6, lParam=0x33f53c, result=0x33f3b8, arg=0x605c0cf0) [/home/julliard/wine/wine/dlls/user32/winproc.c:903] in user32 (0x0033f388) 8 0x606bf923 CallWindowProcA+0xc3(func=0xffff0014, hwnd=0x4002c, msg=<register EDI not in topmost frame>, wParam=<register ESI not in topmost frame>, lParam=0x33f53c) [/home/julliard/wine/wine/dlls/user32/winproc.c:2229] in user32 (0x0033f3c8) 9 0x60688023 call_window_proc+0xe3(hwnd=<register ESI not in topmost frame>, msg=0x414, wparam=0x6, lparam=0x33f53c, unicode=0x0, same_thread=0x1) [/home/julliard/wine/wine/dlls/user32/message.c:1547] in user32 (0x0033f438) 10 0x6068bba1 SendMessageTimeoutA+0x201(hwnd=<register ESI not in topmost frame>, msg=0x414, wparam=0x6, lparam=0x33f53c, flags=0x0, timeout=0x0, res_ptr=0x33f4e0) [/home/julliard/wine/wine/dlls/user32/message.c:2457] in user32 (0x0033f4a8) 11 0x6068bc5c SendMessageA+0x4c(hwnd=0x4002c, msg=0x414, wparam=0x6, lparam=0x33f53c) [/home/julliard/wine/wine/dlls/user32/message.c:2496] in user32 (0x0033f4e8) 12 0x60507938 build_toolbar+0x2c8(nr=0x1, hParent=<is not available>) [/home/julliard/wine/wine/dlls/comctl32/tests/rebar.c:79] in comctl32_test (0x0033f5e8) 13 0x60508011 add_band_w+0x71(hRebar=<register EDI not in topmost frame>, lpszText=<is not available>, cxMinChild=<register ESI not in topmost frame>, cx=0x28, cxIdeal=0x64) [/home/julliard/wine/wine/dlls/comctl32/tests/rebar.c:288] in comctl32_test (0x0033f778) 14 0x6050c205 func_rebar+0x4175() [/home/julliard/wine/wine/dlls/comctl32/tests/rebar.c:358] in comctl32_test (0x0033fe58) 15 0x60525f20 run_test+0x120(name=0x1103a1) [/home/julliard/wine/wine/dlls/comctl32/tests/../../../include/wine/test.h:389] in comctl32_test (0x0033fea8) 16 0x605265a1 main+0x141(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/comctl32/tests/../../../include/wine/test.h:437] in comctl32_test (0x0033fed8) 17 0x6052666b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in comctl32_test (0x0033ff08) 18 0x7b86fbeb start_process+0xeb() in kernel32 (0x0033ffe8) 19 0x6001f7a7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x601bb75b strlen+0xb in libc.so.6: cmpb %ch,0x0(%eax) Wine-dbg> -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 1/4 NtCreateMailslotFile tests
by Dmitry Timoshkov 19 Feb '07

19 Feb '07

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > + rc = pNtCreateMailslotFile(&hslot, DesiredAccess, > + &attr, &IoStatusBlock, CreateOptions, MailslotQuota, MaxMessageSize, > + &TimeOut); > + ok( rc == S_OK, "Create MailslotFile failed rc = %x %u\n", rc, GetLastError()); NT APIs return STATUS_xxx error codes, S_OK is an OLE error value. > + ok( hslot != INVALID_HANDLE_VALUE, "Handle is invalid\n"); INVALID_HANDLE_VALUE is a kernel32 thing, NT APIs don't use it. Most likely you need to test returned value against 0. > + ok( CloseHandle(hslot), "CloseHandle failed\n"); To close the handle returned by an NT API you have you use an NT API as well. -- Dmitry.

3 6

Updated version of Wine-0.9.18 RPMs with ntoskrnl for SuSE 10.1
by Vitaliy Margolen 19 Feb '07

19 Feb '07

Same as before. Just recompiled with new version. http://www.kievinfo.com/wine-0.9.18-1.2.i586.rpm http://www.kievinfo.com/wine-0.9.18-1.2.src.rpm -- Best regards, Vitaliy

3 3

Let's get rid of the FAQ and move it into the wiki
by Scott Ritchie 19 Feb '07

19 Feb '07

Updating the FAQ is a bit of a pain, as is maintaining it. There is, after all, still a lot of ancient stuff in it. Why not just move it into the wiki and point the link on the web page there? I promise I'll watch it a bit closer. Thanks, Scott Ritchie

2 1

What does it mean if doing WINEDEBUG=+relay fixes a bug?
by Misha Koshelev 19 Feb '07

19 Feb '07

Hi, I am trying to debug bug #7484 but am having some problems as simply doing a WINEDEBUG=+relay causes this bug to be fixed, thus making it difficult for me to track it down (WINEDEBUG=+listview or WINEDEBUG= +snoop do not have this effect of fixing it). If there is something that the fact that this bug is fixed by +relay suggests, I would love to know. Thanks a lot Misha

2 1

Re: [wineconsole][dialog] Fix inversion in work Up-down control (Option Dialog)
by Dmitry Timoshkov 19 Feb '07

19 Feb '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > struct dialog_info* di; > unsigned idc; > + unsigned nMaxHistUD = 500; > > switch (msg) > { > @@ -66,6 +67,8 @@ static INT_PTR WINAPI WCUSER_OptionDlgPr > di = (struct dialog_info*)((PROPSHEETPAGEA*)lParam)->lParam; > di->hDlg = hDlg; > SetWindowLongPtr(hDlg, DWLP_USER, (LONG_PTR)di); > + > + SendMessage(GetDlgItem(hDlg,IDC_OPT_HIST_SIZE_UD), UDM_SETRANGE, (WPARAM) 0, MAKELONG (nMaxHistUD, 0)); There is no need for (WPARAM) cast. Better use MAKELPARAM to construct an lParam instead of MAKELONG. Simple MAKELPARAM(500, 0) works just fine without introducing a new variable. -- Dmitry.

1 0

Re: [start][start] Output with console encoding
by Dmitry Timoshkov 19 Feb '07

19 Feb '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > @@ -33,7 +33,20 @@ > static void output(const char *message) > { > DWORD count; > - WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); > + WCHAR *bufW; > + char *bufC; > + int len = strlen(message); > + bufW = calloc(len+1,sizeof(WCHAR)); > + bufC = calloc(len+1,sizeof(CHAR)); Please do not use calloc/malloc calls in the Wine code, use win32 API HeapAlloc instead. > + MultiByteToWideChar( CP_ACP, 0, message, len, bufW, len ); > + WideCharToMultiByte( GetConsoleOutputCP(), 0, bufW, len, bufC, len, NULL, NULL ); > + bufC[len] = '\0'; Please refer to other parts of Wine code how to properly allocate space for this kind of a conversion. -- Dmitry.

1 0

Re: Make wineprefixcreate put wordpad.exe where XP does; fixes bug 5627
by Dan Kegel 19 Feb '07

19 Feb '07

[reposting to right list. Maybe I should break down and subscribe to wine-devel so I can just hit 'reply'...] Detlef wrote: >The Idea sounds good, but your Patch is wrong for every >system in the World, that does not use English as locale: Oh, right. Well, at least I'm enthusiastic, if not wise :-) I guess the way to fix this right would be to create IDS_PROGRAM_FILES_ACCESSORIES analogous to IDS_PROGRAM_FILES; that would let us localize the path in shell32.dll, and setupapi.dll could handle it just like it does IDS_PROGRAM_FILES already (it translates the %16422% into the localized Program Files directory name). Then maybe get rid of the need to create the directores in wineprefixcreate by modifying create_fake_dll in setupapi/fakedll.c to create the directories if they don't exist. Lotta trouble to go through just to support broken-ish apps that need to know where wordpad is, but maybe I'll see about doing it if nobody else fixes this.

1 0

-ansi, -pedantic warnings and errors on
by Joris Huizer 19 Feb '07

19 Feb '07

Hello, I was looking at the result of configuring with -ansi, -pedantic flags. It gives loads of warnings (not all relevant - also complaining about 'long long' not being ansi) and indicates unnamed unions, among other things. Could someone confirm my idea that unnamed unions must all be dealt with? Am hoping to fix those if I get it to compile thus far; At this point, it complains about include/wine/unicode.h which has the combination 'extern' and 'inline', which it doesn't like. Getting rid of that, with -Dinline=__inline__, helps it get a bit further Next it complains about is libs/wine/string.c, which implements several functions that are also implemented in include/wine/unicode.h. These are again the 'extern inline' functions. As most headers have 'static inline' instead of 'extern inline', with the advantage of not having to duplicate the functions. I'm hoping this is an allowed fix, it gets compiling further anyway ____________________________________________________________________________________ Finding fabulous fares is fun. Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains. http://farechase.yahoo.com/promo-generic-14795097

3 4

Mouse not warping properly in full screen mode
by Raf Geens 18 Feb '07

18 Feb '07

Hi, I'm new to Wine and DirectX development, but I've dug around a bit in the Wine source code to get Determinance, a sword-fighting game to work. I've submitted an entry for it to the application database. The main problem I had was with strange mouse behaviour in full screen mode. The player can rotate his character by holding down the right mouse button and moving the mouse. In Windows, this allows you to turn as much as you want. In Wine, the rotation stops at a certain point. You can't see the cursor, but I'm fairly certain the point at which movement stops is when the cursor hits the edge of the screen. When this has happened and you return to the main menu, it can occur that for example the cursor can't reach the top part of the screen anymore. It's as if an invisible rectangle that keeps the cursor inside the screen has moved. In such a case, moving the cursor all the way to the bottom and back up again restores normal behaviour. I've isolated the problem to the following line in dlls/dinput/mouse.c : This->need_warp = (pt.x || pt.y) && dwCoop & DISCL_EXCLUSIVE; Changing it to This->need_warp = TRUE; as a quick test makes the mouse behave correctly. I've read about the mouse warping hack over here: http://www.kernel-traffic.com/wine/wn20040618_227.html#2 . Inserting a TRACE statement displaying the variables in that line of code revealed that: - it is only executed in full screen mode, and not in windowed mode - dwCoop is DISCL_NOWINKEY , causing the expression to evaluate to false. So it seems the DISCL_EXCLUSIVE constraint is too restrictive. Reading about the meanings of the dwCoop values at msdn ( http://tinyurl.com/2lmgbw ), I'm guessing the Determinance developers might not have entirely been following the rules. However, it works properly on Windows. Would it be acceptable to drop the DISCL_EXCLUSIVE constraint? Raf Geens

3 2

Lost KOI8-U.
by Anatoly Lyutin 18 Feb '07

18 Feb '07

2 1

Re: resend : gdi32:WidenPath partial implementation
by James Hawkins 18 Feb '07

18 Feb '07

On 2/18/07, Laurent Vromman <laurent(a)vromman.org> wrote: > Changelog : > - Add a partial implementation for the function gd32:WidenPath > > It is the second time I send this patch. It seems it was forgotten the > previous time. I am sorry for that. > > > If this patch needs to be improved, please let me know, I'll try to do it. > > Laurent Vromman > > > > > diff --git a/dlls/gdi32/path.c b/dlls/gdi32/path.c > index 306ed37..d9ccbb3 100644 > --- a/dlls/gdi32/path.c > +++ b/dlls/gdi32/path.c > @@ -1823,6 +1823,14 @@ BOOL WINAPI StrokePath(HDC hdc) > /******************************************************************* > * WidenPath [GDI32.@] > * > + * Redefines the current path as the area that would be painted if the path were stroked using the pen currently selected into the given device context. > + * > + * PARAMS > + * hdc [I] Handle to a device context that contains a closed path. > + * > + * RETURNS > + * Success: TRUE. The path is updated with the new computed path. > + * Failure: FALSE. > * You copied this documentation word-for-word from msdn, which is not allowed. -- James Hawkins

1 0

generic.ppd does not appear in the build dir - cannot print
by Michael [Plouj] Ploujnikov 18 Feb '07

18 Feb '07

With a recent update to Wine 0.9.31, my printing issue [1] has changed in some way that actually generated some meaningful error messages being printed. I don't know if this is indeed the same issue or not. However, here are the messages that I started getting: $ wine notepad Couldn't find PPD file '/home/plouj/apps/build_dir/dlls/wineps.drv/generic.ppd', expect a crash now! err:commdlg:PRINTDLG_ChangePrinterW DocumentProperties fails on L"our old printer" Couldn't find PPD file '/home/plouj/apps/build_dir/dlls/wineps.drv/generic.ppd', expect a crash now! err:commdlg:PRINTDLG_ChangePrinterW DocumentProperties fails on L"our old printer" fixme:commdlg:PRINTDLG_UpdatePrintDlgW No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandW Update printdlg was not successful! fixme:commdlg:PRINTDLG_UpdatePrintDlgW No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandW Update printdlg was not successful! fixme:commdlg:PRINTDLG_UpdatePrintDlgW No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandW Update printdlg was not successful! fixme:commdlg:PRINTDLG_UpdatePrintDlgW No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandW Update printdlg was not successful! Couldn't find PPD file '/home/plouj/apps/build_dir/dlls/wineps.drv/generic.ppd', expect a crash now! err:commdlg:PRINTDLG_ChangePrinterW DocumentProperties fails on L"our old printer" fixme:commdlg:PRINTDLG_UpdatePrintDlgW No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandW Update printdlg was not successful! Note: my Wine source is checked out from git into ~/apps/wine-git . However, I execute ./configure && make inside ~/apps/build_dir to separate the source from the build files. I also run Wine by executing ~/apps/build_dir/wine . After some playing around I realized that generic.pdd resides in my Wine source checkout directory: $ file ~/apps/wine-git/dlls/wineps.drv/generic.ppd /home/plouj/apps/wine-git/dlls/wineps.drv/generic.ppd: PPD file, ve but not inside the build directory: ls ~/apps/build_dir/dlls/wineps.drv/*.ppd ls: cannot access /home/plouj/apps/build_dir/dlls/wineps.drv/*.ppd: No such file or directory After simply copying generic.pdd to my build directory I was able to print without (absolutely any) errors or warning messages. After finding a quick solution I'm wondering what, a person like me, who builds (and runs) wine in a directory parallel to the source, should do in this case? Should I just live with this hack-ish copying of the .ppd file? Is my usage case not 'popular' enough to warrant a fix? Is this how Autotools is supposed to be used to install generic.ppd? Why didn't the older versions of Wine [2] have this issue? The Makefile doesn't look promising to me: install install-lib:: $(DESTDIR)$(datadir)/wine $(INSTALL_DATA) $(SRCDIR)/generic.ppd $(DESTDIR)$(datadir)/wine/generic.ppd The way I understand this is that generic.ppd is meant to reside in the source directory and the install directory only. This probably means that Autotools won't put it in the build directory. References [1] - http://www.winehq.org/pipermail/wine-devel/2007-January/053606.html [2] - As you can see I've been successfully printing with a non-free application running under Wine since around 0.9.9: http://appdb.winehq.org/appview.php?iVersionId=4498 -- Libre Software: http://www.gnu.org/philosophy/free-sw.html

2 1

RE: [start][start] Output with console encoding
by Vitaliy Margolen 18 Feb '07

18 Feb '07

> Changelog: > Fix output console to output with console encoding. > static void output(const char *message) > Index: programs/start/start.c > =================================================================== > RCS file: /home/wine/wine/programs/start/start.c,v > retrieving revision 1.5 > diff -u -p -u -r1.5 start.c > --- programs/start/start.c 23 May 2006 12:49:22 -0000 1.5 > +++ programs/start/start.c 30 Jan 2007 09:47:52 -0000 > @@ -33,7 +33,20 @@ > { > DWORD count; > - WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); > + WCHAR *bufW; > + char *bufC; > + int len = strlen(message); > + bufW = calloc(len+1,sizeof(WCHAR)); > + bufC = calloc(len+1,sizeof(CHAR)); > + > + MultiByteToWideChar( CP_ACP, 0, message, len, bufW, len ); > + WideCharToMultiByte( GetConsoleOutputCP(), 0, bufW, len, bufC, len, NULL, NULL ); > + bufC[len] = '\0'; > + > + WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), bufC, len, &count, NULL); > + > + free(bufW); > + free(bufC); > } This is not correct. This function and everything else, using it should be rewritten as unicode, not ansi. Also you should use HeapAlloc/HeapFree. Vitaliy.

1 0

kernel32 (profile.c): allow profile section and key names of zero length patch
by Claudio Fontana 18 Feb '07

18 Feb '07

Hello all, I was wondering if there's anything wrong with my patch to kernel32/profile.c and its tests: http://www.winehq.org/pipermail/wine-patches/2007-February/035468.html It fixes a problem that causes applications built with Multimedia Fusion to fail under wine, since the "INI object" of MF relies on zero length section and key names to store and retrieve values. The changes in tests/profile.c contain new testcases, and a generally useful fix to the tests, where some values are currently passed directly to the functions instead of using the values in the testcases table. If there's anything unclear or wrong about this patch, please tell me so that I will be able to fix it. Thanks, Claudio

1 0

Re: lostwages/ news/2006081001.xml news/2007021602 ...
by Francois Gouget 18 Feb '07

18 Feb '07

On Fri, 16 Feb 2007, WineHQ wrote: > ChangeSet ID: 30931 > CVSROOT: /opt/cvs-commit > Module name: lostwages > Changes by: wineowner(a)winehq.org 2007/02/16 18:13:29 Could we get rid of wineowner account? It makes it impossible to know who's doing the changes. Each user having access to the WineHQ box should have his own login. Welcome back Brian (if I read the wwn right). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

2 1

Re: Make wineprefixcreate put wordpad.exe where XP does; fixes bug 5627
by Detlef Riekenberg 18 Feb '07

18 Feb '07

On Sa, 2007-02-17 at 13:32 -0800, Dan Kegel wrote: > +++ b/tools/wine.inf > @@ -2149,6 +2149,7 @@ HKLM,%CurrentVersion%\Telephony\Country > > [FakeDllsSection] > +10,..\Program Files\Windows NT\Accessories,wordpad.exe > +++ b/tools/wineprefixcreate.in > + "$CROOT/Program Files" \ > + "$CROOT/Program Files/Windows NT" \ > + "$CROOT/Program Files/Windows NT/Accessories" The Idea sounds good, but your Patch is wrong for every system in the World, that does not use English as locale: My XP has wordpad.exe here: "C:\Programme\Windows NT\Zubehör\wordpad.exe" -- By by ... Detlef

1 0

Re: Error in ntdll/module.c?
by Rolf Kalbermatter 18 Feb '07

18 Feb '07

Christian Iversen [mailto:chrivers@iversen-net.dk] wrote: >According to: > >http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/ >Executable%20Images/LdrGetProcedureAddress.html > >The parameter order for LdrGetProcedureAddress is (Handle, Function, >Ordinal, Address) > >The file dlls/ntdll/module.c has the order as (Handle, Ordinal, >Function, Address) Ok. I took a look at the call sequence of this function in a native kernel32.dll and the second parameter is initialized with RtlInitString. So I guess the parameter order as on that web site would be correct. Having looked at the particular assembly code obviously excludes me from doing any work on this part anymore. As to the current implemenation I'm not sure that makes any difference since most undocumented APIs are unlikely to be used by applications. And since ntdll and kernel32 are both also Wine specific and therefore can't be replaced by Windows ones this won't matter either it would seem. You can try to post a proper patch to both kernel32 and ntdll to wine-patches and then let Alexandre decide if he wants to apply it. Rolf Kalbermatter

2 1

Error in ntdll/module.c?
by Christian Iversen 18 Feb '07

18 Feb '07

(Please CC me, I'm not on the list) According to: http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/Execu… The parameter order for LdrGetProcedureAddress is (Handle, Function, Ordinal, Address) The file dlls/ntdll/module.c has the order as (Handle, Ordinal, Function, Address) This of course works well because kernel32.dll is the only caller (and it indeed uses, if not the correct, then at least the same order). I haven't attached a patch, because I'm not actually sure which version is right. Anyone? -- Mvh Christian Iversen

2 1

Re: patches and more
by Robert Shearman 18 Feb '07

18 Feb '07

David Saez Padros wrote: > This line should be added to commctrl.h: > > #define ListView_GetOrigin(hwndLV, ppt) \ > (BOOL)SNDMSG((hwndLV), LVM_GETORIGIN, (WPARAM)0, (LPARAM)ppt) I've submitted a patch for this. > this one should be added to windows.h (maybe it's not the best > place for it, but it works): > > #define stricmp strcasecmp This define is not present in the Platform SDK. It is a by-product of using glibc instead of msvcrt as your C library. If you used the headers in include/msvcrt and added -lmsvcrt to the linker command line then it should have worked out of the box. If you want to link against glibc, then think of changing stricmp to strcasecmp as part of porting the program. -- Rob Shearman

2 1

Font issue - workaround found
by Timm 18 Feb '07

18 Feb '07

My one win app that makes me a devotee of WINE is TablEdit (demo at www.tabledit.com/download/tabled32.exe) has a custom font , tef260.ttf, that has failed to display since somewhere after ver 9.6. The program installs the font into c:\windows\font, but can not display it within the program, instead displaying for the most part, empty squares. I tried putting/removing tef260.ttf into /usr/local/share/wine/fonts, /usr/local/share/fonts, and the wine windows/fonts directories in all permutations. The only way I got it to display was to remove ALL fonts from these three directories and install tef260.ttf into an X11 font directory along with other win ttf fonts. This forces WINE to build a cachedmetrics file like it used to, and the font is displayed properly in the program. Hope this is a clue for some developer, as I merely lurk here, looking for clues about wine behavior. I can't do a regression back to ver 9.6 (the version I was using that last worked) because my upgrades to freetype cause it to complain of missing functions. current (pertinent ? ) specs libfreetype.so.6.3.7 ] built from source libfontconfig.so.1.0.4 ] built from source fontforge 20060715 ] built from source WINE 0.9.20 ] built from source kernel 2.6.17.11 Slack current (10.2, with upgrades from "current" tree) -- Timm

3 2

re: generic.ppd does not appear in the build dir - cannot print
by Dan Kegel 18 Feb '07

18 Feb '07

> [I keep my source and object in different directories, and generic.ppd isn't found during build] That method of building is great, and is supported, but not too many people build that way, so bugs do creep in. You can either keep living with the workaround you found, or submit a patch to fix the build. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

32 bpp cursors?
by Dan Kegel 17 Feb '07

17 Feb '07

http://bugs.winehq.org/show_bug.cgi?id=4273 points to a patch set that implements 32 bit per pixel cursors and a bunch of other cursor stuff. Looks like the patch got dropped by the author, though, and since it makes server changes, it's going to be hard to get past Alexandre. Is anyone interested in picking this up? - Dan

4 5

Re: comctl32: rebar: New conformance test for CCS_NORESIZE style.[PATCH 1/2]
by Dmitry Timoshkov 17 Feb '07

17 Feb '07

"Misha Koshelev" <mk144210(a)bcm.tmc.edu> wrote: > +/* MSDN 672579: "CCS_NORESIZE: Prevents the control from using the default width and height when setting its > + * initial size or a new size. Instead, the control uses the width and height specified in the request for > + * creation or sizing." This test checks both creation and sizing dimensions. */ You can't quote MSDN in the Wine code, but you can explain the problem using your own wording. -- Dmitry.

1 0

Re: VB, Access based program on Linux
by Dan Kegel 17 Feb '07

17 Feb '07

[-wine-users, +wine-devel] On 2/6/07, Dan Kegel <dank(a)kegel.com> wrote: > Neelesh wrote: > >I work in one public charitable trust. Here we are using one > >Accounting+Inventory+Report management Program. Two developers have > >developed in VB, Access and Crystal Reports. > > > >Now I am trying to use it through wine on linux.... > ... > If you want to help us get Wine ready for > VB/Access applications, you could send a Wine > developer a copy of your application so he could > look at the problems locally. Thanks for sending the app to me. Of the many problems it seems to present, I'm starting with the first one: an error dialog during install. When it tries to run a couple subinstallers, it fails, and puts up a dialog box saying the directory is invalid. After a bit of looking, I am starting to suspect that ShellExecuteEx is being called by the installer with a quoted directory name, and Wine isn't handling that right. Here's a bit of log: dank@krunch:/C:/foo/bar_Installation$ grep -i Shell.*Execute log7.c 000e:Call shell32.ShellExecuteExA(0035f40c) ret=0041e5a4 000e:trace:exec:SHELL_execute mask=0x00000640 hwnd=0x1002c verb=L"open" file=L"C:\\foo\\bar_Installation\\InstMsiA.EXE" parm=L"" dir=L"\"C:\\foo\\bar_Installation" show=0x00000001 class=not used 000e:fixme:exec:SHELL_execute flags ignored: 0x00000400 000e:trace:exec:ShellExecute_FromContextMenu L"C:\\foo\\bar_Installation\\InstMsiA.EXE" 000e:trace:exec:ShellExecute_GetClassKey ext = L".EXE" 000e:trace:exec:ShellExecute_GetClassKey class = L"exefile" 000e:trace:exec:SHELL_execute execute:L"C:\\foo\\bar_Installation\\InstMsiA.EXE",L"",L"\"C:\\foo\\bar_Installation" 000e:trace:exec:SHELL_ExecuteW Execute L"C:\\foo\\bar_Installation\\InstMsiA.EXE" from directory L"\"C:\\foo\\bar_Installation" 000e:err:exec:SHELL_ExecuteW cannot set directory L"\"C:\\foo\\bar_Installation" 000e:trace:exec:SHELL_ExecuteW CreateProcess returned error 267 000e:trace:exec:SHELL_ExecuteW returning 11 The directory only has a quote mark at the beginning; this may be a bug in your installer, but if Windows' ShellExecute can handle that, Wine should be able to, too. My computer time is limited, or I'd add a testcase in shell32/tests/shlexec.c to check this. Maybe someone else can have a look. - Dan

1 0

Re: comctl32: move up-down msg seq tests into new 'msg' test
by James Hawkins 17 Feb '07

17 Feb '07

On 2/13/07, Felix Nawothnig <flexo(a)holycrap.org> wrote: > Figured you might want a test for my listview patch - so first this. > > Didn't really change anything, still passed on XP SP2. > --- > dlls/comctl32/tests/Makefile.in | 1 + > dlls/comctl32/tests/msg.c | 523 > +++++++++++++++++++++++++++++++++++++++ > dlls/comctl32/tests/updown.c | 435 +-------------------------------- > 3 files changed, 532 insertions(+), 427 deletions(-) > This is not what needs to happen. The generic message sequence testing code needs to be factored into msg.c, but the specific tests need to stay in each control's test file. -- James Hawkins

3 3

calling _splitpath from cmd.exe, and 64 bit decimal formatting
by Ann & Jason Edmeades 17 Feb '07

17 Feb '07

Hello, Its been a while since I did any wine work so thought I'd fix some bugs in the cmd shell. I have come across a call which fails at compile time which I was interested in knowing the 'right' way to solve _splitpath appears to exist in ntdll, but none of the #includes I have tried pick it up. Stblib, for example, is just using the standard compiler one. Additionally looking at winefile it has just copied the implementation in, so why did it do that? Also, I wanted to sprintf using %I64d but again I believe we are ending up using the standard sprintf gcc library function which does not support it. Is there any easy way around this (its trivial functionality which can be left as a fixme if not). Jason

1 0

Google Summer of Code 2007
by Tom Wickline 16 Feb '07

16 Feb '07

Hello, I see Google is going to do there summer of code again this year :-) They plan to start accepting applications in March, so now would be the time for us to propose new projects and review the ones we have already listed on the Wiki for interested applicants? As well as line up mentors for the accepted applicants? http://wiki.winehq.org/SummerOfCode http://google-code-updates.blogspot.com/2007/02/speaking-of-summer.html Tom

2 1

Re: [5/10] DDraw: Fix a leak in a test
by H. Verbeet 16 Feb '07

16 Feb '07

Does this really matter?

2 1

[1/10] - [10/10] WineD3D
by Luke Bratch 16 Feb '07

16 Feb '07

> Wow, great work!!!!! 3DMark 2006 with fbo looks realy coool!! And some > Nvidia SDK demos are completly fixed! How did you test 3DMark2006? When I try and run it, it tells me I need Pixel Shader 2.0 support. I have UseGLSL set to enabled and OffscreenRenderMode set to fbo, and the Pixel Shader 2 test in 3DMark03 works fine. ___________________________________________________________ New Yahoo! Mail is the ultimate force in competitive emailing. Find out more at the Yahoo! Mail Championships. Plus: play games and win prizes. http://uk.rd.yahoo.com/evt=44106/*http://mail.yahoo.net/uk

4 4

We need a new version numbering scheme
by Scot Hetzel 16 Feb '07

16 Feb '07

I read about users confusion with wine version numbering scheme. Personally, I would redirect these confused users to the wiki page at wikipedia where it discusses what the numbers mean in a software version numbering scheme. http://en.wikipedia.org/wiki/Software_version The MAME project had the same user confusion when it went from 0.99 to 0.100. Several of the users of MAME had expected the next version to be 1.00. Scot -- DISCLAIMER: No electrons were mamed while sending this message. Only slightly bruised.

1 0

Re: Wine and menu integration
by Mike Hearn 16 Feb '07

16 Feb '07

Hi David, Sounds great! To submit those files, you need to make a patch ... git can do this but I don't remember the exact command to use (depends on your setup also). Or you can do it the old fashioned way using diff directly. Feel free to ask if you'd like more guidance with this. Once you have a patch, email it to wine-patches(a)winehq.org so Alexandre and the others can review it, suggest improvements etc. Good luck! On 2/15/07, David Saez Padros <david(a)ols.es> wrote: > Hi !! > > I saw your post at http://wiki.winehq.org/GnomeMenusIntegration > and i made some freedesktop compliant files which: > > - add a global Wine menu item in the Aplications menu (seen > by all users) with WineFile and WineMine, which also merge > all user specific wine installed programs. > > - add a global menu item for winecfg in System -> Preferences > (seen by all users) > > I also have what should be add to installation so .exe files > are executed with wine when double-clicked (tested in ubuntu) > > How could i submit those files ?? I cannot din anything > related to this in the bugzilla :( > > -- > Best regards ... > > I am Homer of Borg. Prepare to be assim... mmmm, donuts. > > ---------------------------------------------------------------- > David Saez Padros http://www.ols.es > On-Line Services 2000 S.L. e-mail david(a)ols.es > Pintor Vayreda 1 telf +34 902 50 29 75 > 08184 Palau-Solita i Plegamans movil +34 670 35 27 53 > ---------------------------------------------------------------- > > >

3 2

We need a new version numbering scheme
by Scott Ritchie 16 Feb '07

16 Feb '07

On several occasions I have received emails referring to Wine version 0.9.3. One person even told me about a regression from 0.9.28 to 0.9.3. Presumably, this version is being confused with Wine 0.9.30 in these letters, however I have been unable to tell whether people were ACTUALLY using 0.9.3 or were instead simply referring to 0.9.30 in the intuitive way of chopping off the last 0. Either way, version numbers should be completely clear, and they're not currently. I'm not quite sure what to do at this point. Thanks, Scott Ritchie

8 11

git question
by Joris Huizer 16 Feb '07

16 Feb '07

Hello, As a new wine is released I'm trying to get updated. Before I had used git for generating patches, I could do: git fetch; git rebase origin however, now this doesn't seem to pickup anything. How should I tell git to actually update to the files on the server? Thanks, Joris ____________________________________________________________________________________ Do you Yahoo!? Everyone is raving about the all-new Yahoo! Mail beta. http://new.mail.yahoo.com

3 2

Re: wininet: Improve FtpOpenFile()'s parameter checking and remove the corresponding todo_wines.
by Paul Vriens 16 Feb '07

16 Feb '07

Francois Gouget wrote: > Also make test_getfile_no_open() succeed on Windows 98. > --- > > I have had some strange results with these tests. One of them was > actually succeeding in a todo_wine for a good while. > > dlls/wininet/ftp.c | 12 +++++++++++- > dlls/wininet/tests/ftp.c | 12 +++--------- > 2 files changed, 14 insertions(+), 10 deletions(-) > This was the last one for now on my list, you beat me to it. We do have some conflicting patches now in wine-patches. > diff --git a/dlls/wininet/ftp.c b/dlls/wininet/ftp.c > index 5b073cf..2bd29fd 100644 > --- a/dlls/wininet/ftp.c > +++ b/dlls/wininet/ftp.c > @@ -1011,11 +1011,21 @@ HINTERNET WINAPI FtpOpenFileW(HINTERNET hFtpSession, > debugstr_w(lpszFileName), fdwAccess, dwFlags, dwContext); > > lpwfs = (LPWININETFTPSESSIONW) WININET_GetObject( hFtpSession ); > - if (NULL == lpwfs || WH_HFTPSESSION != lpwfs->hdr.htype) > + if (NULL == lpwfs) > + { > + INTERNET_SetLastError(ERROR_INTERNET_NOT_INITIALIZED); > + goto lend; Why do a 'goto lend' you could just 'return FALSE' like I did in the other ftp functions. No need do another check for lpwfs being NULL. If you do a 'return FALSE' you could also get rid of the check for lpwfs being NULL right after lend:. > + } > + if (WH_HFTPSESSION != lpwfs->hdr.htype) > { > INTERNET_SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE); > goto lend; > } > + if (dwFlags & ~(INTERNET_FLAGS_MASK|FTP_TRANSFER_TYPE_MASK)) > + { > + INTERNET_SetLastError(ERROR_INVALID_PARAMETER); > + goto lend; > + } I think this covers the 5 in the test but not all possible combinations. I did some (loop) testing with dwFlags (also used in FtpGetFile and FtpPutFile) and it appears all boils down to the last 3 bits (see FtpGetFile). Cheers, Paul.

1 0

Re: [7/10] WineD3D: Test for supported queries
by Juan Lang 16 Feb '07

16 Feb '07

Hi Stefan, + hr = IDirect3D9_CreateDevice( pD3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, hwnd, + D3DCREATE_SOFTWARE_VERTEXPROCESSING, &d3dpp, &pDevice ); + ok(SUCCEEDED(hr), "Failed to create IDirect3D9Device (%s)\n", DXGetErrorString9(hr)); + if (FAILED(hr)) goto cleanup; (snip) + cleanup: + if(pDevice) IDirect3DDevice9_Release(pDevice); The label cleanup isn't used anywhere except in the failure to create the device. In this case, wouldn't: if (FAILED(hr)) return; be clearer, and omit the unneeded label? There's no reason to release pDevice in creating it failed. --Juan ____________________________________________________________________________________ Do you Yahoo!? Everyone is raving about the all-new Yahoo! Mail beta. http://new.mail.yahoo.com

2 1

DIB Engine, some summarization
by Rolf Kalbermatter 16 Feb '07

16 Feb '07

This is getting a bit long so if you do not have time, then skip this. I've looked a little more at the issue of a DIB Engine and tried to use the feedback so far to get an idea what the possible architecture could be. First I took a look at how Windows seems to do it currently (excluding Vista). There GDI32 is mostly a wrapper around win32k.sys and the different GDI APIs call mostly into corresponding NtGdi... functions in win32k.sys. Those functions do the actual handling and call the according driver that is attached to the DC. The interface to the driver is similar to what is done now in Wine although not identical. The modern Windows display driver interface uses sometimes more or less different functions than the old one as used in Wine. A driver can either not implement certain functions, only implement them for its device specific surfaces, or hook certain calls by returning flags inside the driver initialization structure on initialization. Those hook flags tell the GDI engine that the driver wants to be called for DIB surfaces too for particular functions and bit depths. The driver will then be called for according DIB surfaces too and it can decide to do whatever it can do best and for those cases it doesn't know well how to do it, call back into the GDI engine using an according Eng... function. This calling back into the GDI engine for hooked functions is called punting by MS. If the driver didn't provide the actual function it will possibly be simulated by the GDI engine by calling other driver functions and if the driver didn't hook the function or didn't succeed and it is for a DIB surface then the GDI engine itself will call the according Eng... function. GDI32 exports most of those Eng... functions too but that are simply user space wrappers around the win32k.sys entry points for those functions. >From a design view it might be interesting to separate the actual GDI engine into a subpart that corresponds with the NtGdi... functions in win32k.sys eventhough they might stay inside GDI32 for the time being. The actual Eng... functions would be also placed inside that GDI engine and are in fact mostly the long awaited DIB engine. Such an architecture would make reuse of such a GDI32/win32k combo in other projects fairly easy. However this NtGdi API is not documented although it is presumably mostly a mirror of the GDI API. There are lists of what APIs win32k.sys does export and how many parameters each of these functions takes, extracted from the actual win32k.sys file. Eventhough Windows keeps them in the win32k.sys kernel I think it would be a good idea to keep them all in GDI32 for the time being. If that API is at some time mostly complete and separation into its own DLL or something would be desired, this could be done quite easily. But it is certainly quite a bit tedious to do and would require at least partly some sort of clean room reverse engineering and it's not really necessary for a DIB engine at all at this point. There is a little problem with those Eng.. functions however. They are modeled after the new NT display driver interface that is in so far different that it does use partly different functions and parameters to the old (I assume Win 3.1 display driver) interface used in Wine and this is even more or less all documented in the DDK, although the basic principle between the Windows driver interface and what Wine does is of course mostly the same. I can't really see however how it would be possible to change that interface to match the modern NT display driver interface in a seemless manner as it would mean a significant change in winex11.drv, winequartz.drv and the GDI32 (aka win32k.sys) that would need to be done mostly in a few big chunks to not completly break everything. So what would remain is adding the actual Eng... and object access API to GDI. These APIs are (all?) documented in the DDK and could be implemented based on MSDN information alone together with maybe some test cases. The actual driver interface might remain mostly the same as it is now with some extra addition to return to the GDI engine extra flags to indicate hooks for DIB surfaces. Then implementation of the Eng... functions would have to start and as they are fleshed out and work they get integrated into the calling logic one for one. Until this is completely done the current separations for DIBs into appstate and serverstate would have to remain, so that the X11 driver can still pass them to the X11 server for rendering of not implemented DIB engine operations. Once the DIB engine is finished (if ever :-) this could be removed as the X11 driver would not anymore hook any of the DIB operations. If winequartz.drv wants to continue hooking DIB operations it can do so of course. To start with, the actual header winddi.h defining most of the Eng.. calls could be added as ddk header to Wine. There seems to be a copyright free version of this header file from Casper S. Hornstrup that is part of the w32api package. I have thought about modifying the driver function call array instead as Alexandre has pointed out in the past as possible solution instead of adding the actual Eng... calls explicitedly into the GDI engine as fall back. But this seems not a good solution to me. The driver wants to be informed of graphic operations for device specific surfaces most often I would assume and only might want to not get called for device contexts containing a dib section. And as some have pointed out winequartz may even want to get called for DIBs too. In order to allow for such a dynamic overriding of function pointers in the driver function array, that array would have to be allocated dynamically on a device context base and I think this would make everything slower, more memory consuming and it wouldn't really be easier although I admit that adding Eng.. calls everywhere and correctly is quite some work to do. The issue about network transparency for the display driver would not be an issue IMO. Once complete the DIB engine would handle all DIB operations locally and so no need for translating direct memory access into remote calls to some display server would be necessary. And the blitting of DIBs to the display when necessary would still be done through the driver of course so everything would be transparent as far as the capabilities of the used display device itself allow for that. Rolf Kalbermatter

5 6

regression in 613998d4f6ff953a22a4455a28f77d2126642c7d
by Marcus Meissner 16 Feb '07

16 Feb '07

Hi Shanren, your commit 613998d4f6ff953a22a4455a28f77d2126642c7d Author: Shanren Zhou <shanren(a)ucla.edu> Date: Mon Feb 12 19:53:51 2007 -0800 comctl32: Add header tests. generates a Coverity Warning in this code: ... HIMAGELIST hImageList; HIMAGELIST hImageListRetVal; hImageListRetVal = (HIMAGELIST) SendMessage(hWndHeader, HDM_SETIMAGELIST, 0, (LPARAM) &hImageList); HDM_SETIMAGELISTs parameter is used and stored, so hImageList should be: - initialized to something (likely 0 is ok, didnt check) - and not a pointer (did you add the & just to kill the warning?) Ciao, Marcus

1 0

Re: [1/4] wined3d: Fix WINED3DPRESENT_PARAMETERS and use it instead of D3DPRESENT_PARAMETERS
by Duane Clark 15 Feb '07

15 Feb '07

H. Verbeet wrote: > It looks like the patch might be a bit large for the list, here's a > compressed version instead. > Anything over 80K just gets caught in the mail queue. It should get through eventually.

1 0

Office 2007 help wine
by Keith H. Pratt 15 Feb '07

15 Feb '07

Hi, I went to a Microsoft Launch for their enterprise and business products this past tuesday, and they gave me a full version of Office 2007 Professional. Nice of them huh. Well, I am a linux user, and an avid evangelist for open source, and for anything that lets thw linux and windows world work together. I also have spent a considerable amount of time testing and bug reporting beta software. With all that said, here's my point. What can I do with this software to help you in the testing and development of wine? I run a dual-boot system with winxp and ubuntu linux. linux is where i work, and windows is there to make it easier to support my clients in their windows machines. If theres nothing now that applies to wine and office 2007, maybe keep this message for when the need does arise. Thanks Keith

2 1

Re: [PATCH 6/6] kernel32: Fix the GetComputerName* functions to not write to the buffer at all if there is not enough space.
by Alexandre Julliard 15 Feb '07

15 Feb '07

Robert Shearman <rob(a)codeweavers.com> writes: > Remove the exception handlers, since testing on XP SP2 shows that > access violations are not caught. Yes, but they are caught on Win9x, and the handler was added because an app needed it. I'd suggest to keep it at least in the A function. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Symbol encoding should be always selectable
by Dmitry Timoshkov 15 Feb '07

15 Feb '07

"Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote: > this patch fixes a failure in the font charset test in the case when > only Arial is installed. As the test shows the symbol encoding should be > always selectable. Please do not commit this patch, it's wrong. According to GetTextFace XP selects Wingdings if SYMBOL_CHARSET was requested. I'm not sure how to make the test pass: probably SYMBOL_CHARSET should be skipped if Symbol or Wingdings are not installed. -- Dmitry.

1 0

WINSPOOL: search for a printer driver
by Vitaly Lipatov 15 Feb '07

15 Feb '07

When wine is loading, CUPS_LoadPrinters function get printer list from CUPS and add printer and their printer drivers to registry. If printer is already exist, we do not override nor printer driver, nor printer entry. It all works fine. Note, we place printer driver in "Windows 4.0" registry entry if Wine version is win9x and use "Windows NT x86" registry entry if Wine version is win2000 and above. If we will change wine version after printer loaded, Wine printing is got failed. Wine search in empty registry entry. For example, I get such configuration after run wine in win98 mode: [System\\CurrentControlSet\\Control\\Print\\Environments\\Windows 4.0\\Drivers\\hp] 1171461136 "Configuration File"="wineps16" "Data File"="<datafile?>" "Datatype"="RAW" "Dependent Files"=str(7):"<dependent files?>\0" "Driver"="wineps16" "Help File"="<helpfile?>" "Monitor"="<monitor name?>" "Version"=dword:00000000 [System\\CurrentControlSet\\Control\\Print\\Environments\\Windows NT x86\\Drivers\\Version-3] 1171461821 [System\\CurrentControlSet\\Control\\Print\\Printers\\hp] 1171461818 "Attributes"=dword:00000000 "Datatype"="RAW" "Default DevMode"=hex:68,70,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,\ ... "Description"="WINEPS Printer using CUPS" "Location"="<physical location of printer>" "Name"="hp" "Parameters"="<parameters?>" "Port"="LPR:hp" "Print Processor"="WinPrint" "Printer Driver"="hp" ... I try to find a better way to resolve this problem. Some ideas: 1. Check if Wine version is changed and reset printer drivers. 2. Search in both registry entry in any way. 3. ... -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Direct Draw "palette_convert"
by Nathan Williams 15 Feb '07

15 Feb '07

I'm working on some direct draw code to get Carmageddon working. I think I have found my issue in IWineD3DPaletteImpl_SetEntries Carmageddon runs in 8 bit mode, my x windows is set at 24bit. If I drop xorg to 8bit, wine refuses to load. If i set it to 16bit, the Carmageddon menus are still bad, but noticeably better then running in 24bit. In SetEntries there is a bit of code idef'd out: #if 0 /* Now, if we are in 'depth conversion mode', update the screen palette */ /* FIXME: we need to update the image or we won't get palette fading. */ if (This->ddraw->d->palette_convert != NULL) This->ddraw->d->palette_convert(palent,This->screen_palents,start,count); #endif Uncommenting the above only leads to compile errors. Dredging through the wine archives, I see that the palette convert functions haven't been there since 2000. Can anyone give me an idea on why they were removed & what might be the best way to reimplement some form of palette conversion? (Even just in a hacky way right now, so i can test my assumptions) -- Nathan

4 4

avifil32: sign-compare fixes
by Joris Huizer 15 Feb '07

15 Feb '07

Hello As the previous time I was inserting too many casts, I want to ask whether this approach is better (introducing an ULONG version if it fixes compare warnings, and casting away remaining problems) If this is not alright, could you tell what's the best way to fix? regards, Joris ____________________________________________________________________________________ Never miss an email again! Yahoo! Toolbar alerts you the instant new Mail arrives. http://tools.search.yahoo.com/toolbar/features/mail/

1 0

Re: [05/10] wined3d: Add WINED3DTEXOPCAPS flags and use them
by Alexandre Julliard 15 Feb '07

15 Feb '07

"H. Verbeet" <hverbeet(a)gmail.com> writes: > diff --git a/include/wine/wined3d_caps.h b/include/wine/wined3d_caps.h > new file mode 100644 > index 0000000..4bf474b > --- /dev/null > +++ b/include/wine/wined3d_caps.h > @@ -0,0 +1,49 @@ > +/* > + * Copyright 2007 Henri Verbeet > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_WINED3D_CAPS_H > +#define __WINE_WINED3D_CAPS_H > + > +#define WINED3DTEXOPCAPS_DISABLE 0x00000001 > +#define WINED3DTEXOPCAPS_SELECTARG1 0x00000002 > +#define WINED3DTEXOPCAPS_SELECTARG2 0x00000004 > +#define WINED3DTEXOPCAPS_MODULATE 0x00000008 > +#define WINED3DTEXOPCAPS_MODULATE2X 0x00000010 > +#define WINED3DTEXOPCAPS_MODULATE4X 0x00000020 > +#define WINED3DTEXOPCAPS_ADD 0x00000040 > +#define WINED3DTEXOPCAPS_ADDSIGNED 0x00000080 > +#define WINED3DTEXOPCAPS_ADDSIGNED2X 0x00000100 > +#define WINED3DTEXOPCAPS_SUBTRACT 0x00000200 > +#define WINED3DTEXOPCAPS_ADDSMOOTH 0x00000400 > +#define WINED3DTEXOPCAPS_BLENDDIFFUSEALPHA 0x00000800 > +#define WINED3DTEXOPCAPS_BLENDTEXTUREALPHA 0x00001000 > +#define WINED3DTEXOPCAPS_BLENDFACTORALPHA 0x00002000 > +#define WINED3DTEXOPCAPS_BLENDTEXTUREALPHAPM 0x00004000 > +#define WINED3DTEXOPCAPS_BLENDCURRENTALPHA 0x00008000 > +#define WINED3DTEXOPCAPS_PREMODULATE 0x00010000 > +#define WINED3DTEXOPCAPS_MODULATEALPHA_ADDCOLOR 0x00020000 > +#define WINED3DTEXOPCAPS_MODULATECOLOR_ADDALPHA 0x00040000 > +#define WINED3DTEXOPCAPS_MODULATEINVALPHA_ADDCOLOR 0x00080000 > +#define WINED3DTEXOPCAPS_MODULATEINVCOLOR_ADDALPHA 0x00100000 > +#define WINED3DTEXOPCAPS_BUMPENVMAP 0x00200000 > +#define WINED3DTEXOPCAPS_BUMPENVMAPLUMINANCE 0x00400000 > +#define WINED3DTEXOPCAPS_DOTPRODUCT3 0x00800000 > +#define WINED3DTEXOPCAPS_MULTIPLYADD 0x01000000 > +#define WINED3DTEXOPCAPS_LERP 0x02000000 > + > +#endif /* __WINE_WINED3D_CAPS_H */ I think this could just as well go into an existing file like wined3d_types.h. We should try to keep the number of Wine-specific global includes to a minimum. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [4/10] WineD3D: Convert and load U8V8 surfaces as rgb
by Stefan Dösinger 15 Feb '07

15 Feb '07

Am Donnerstag 15 Februar 2007 09:50 schrieb H. Verbeet: > On 15/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > GL_INDEX is definitly not the way to load U8V8 surfaces > > I think you should be using something like GL_DU8DV8_ATI or GL_DSDT_NV > instead. Thats my plan, but I think we should handle it in some way if none of the extensions is available. We can later use the extension-specific formats if they are available.

1 0

Re: [10/10] DDraw: Forward D3DRS_TEXTUREADDRESS* and D3DTSS_ADDRESS* to sampler states
by Stefan Dösinger 15 Feb '07

15 Feb '07

Am Donnerstag 15 Februar 2007 09:51 schrieb H. Verbeet: > On 15/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > >+ case D3DTSS_ADDRESS: > >+ return IWineD3DDevice_GetSamplerState(This->wineD3DDevice, > >+ Stage, > >+ WINED3DSAMP_ADDRESSW, > >+ State); > > Is that correct? Hm. No, it isn't. I thought I fixed that sort of things. Maybe an old version of the patch got sent NULL

1 0

Re: [07/10] wined3d: Add WINED3DPBLENDCAPS flags and use them
by Mirek 15 Feb '07

15 Feb '07

Hi, this patch has bad attachment, it has same attachment as "[08/10] wined3d: Add WINED3DPMISCCAPS flags and use them". Mirek Slugen H. Verbeet napsal(a): > Changelog: > - Add WINED3DPBLENDCAPS flags and use them > > > ------------------------------------------------------------------------ > > --- > > dlls/wined3d/directx.c | 34 +++++++++++++++++----------------- > include/wine/wined3d_caps.h | 19 +++++++++++++++++++ > 2 files changed, 36 insertions(+), 17 deletions(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 1753ef9..cc1e0f6 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -1872,29 +1872,29 @@ static HRESULT WINAPI IWineD3DImpl_GetDeviceCaps(IWineD3D *iface, UINT Adapter, > WINED3DDEVCAPS_DRAWPRIMITIVES2 | > WINED3DDEVCAPS_DRAWPRIMITIVES2EX; > > - *pCaps->PrimitiveMiscCaps = D3DPMISCCAPS_CULLNONE | > - D3DPMISCCAPS_CULLCCW | > - D3DPMISCCAPS_CULLCW | > - D3DPMISCCAPS_COLORWRITEENABLE | > - D3DPMISCCAPS_CLIPTLVERTS | > - D3DPMISCCAPS_CLIPPLANESCALEDPOINTS | > - D3DPMISCCAPS_MASKZ | > - D3DPMISCCAPS_BLENDOP; > + *pCaps->PrimitiveMiscCaps = WINED3DPMISCCAPS_CULLNONE | > + WINED3DPMISCCAPS_CULLCCW | > + WINED3DPMISCCAPS_CULLCW | > + WINED3DPMISCCAPS_COLORWRITEENABLE | > + WINED3DPMISCCAPS_CLIPTLVERTS | > + WINED3DPMISCCAPS_CLIPPLANESCALEDPOINTS | > + WINED3DPMISCCAPS_MASKZ | > + WINED3DPMISCCAPS_BLENDOP; > /* TODO: > - D3DPMISCCAPS_NULLREFERENCE > - D3DPMISCCAPS_INDEPENDENTWRITEMASKS > - D3DPMISCCAPS_FOGANDSPECULARALPHA > - D3DPMISCCAPS_SEPARATEALPHABLEND > - D3DPMISCCAPS_MRTINDEPENDENTBITDEPTHS > - D3DPMISCCAPS_MRTPOSTPIXELSHADERBLENDING > - D3DPMISCCAPS_FOGVERTEXCLAMPED */ > + WINED3DPMISCCAPS_NULLREFERENCE > + WINED3DPMISCCAPS_INDEPENDENTWRITEMASKS > + WINED3DPMISCCAPS_FOGANDSPECULARALPHA > + WINED3DPMISCCAPS_SEPARATEALPHABLEND > + WINED3DPMISCCAPS_MRTINDEPENDENTBITDEPTHS > + WINED3DPMISCCAPS_MRTPOSTPIXELSHADERBLENDING > + WINED3DPMISCCAPS_FOGVERTEXCLAMPED */ > > /* The caps below can be supported but aren't handled yet in utils.c 'd3dta_to_combiner_input', disable them until support is fixed */ > #if 0 > if (GL_SUPPORT(NV_REGISTER_COMBINERS)) > - *pCaps->PrimitiveMiscCaps |= D3DPMISCCAPS_TSSARGTEMP; > + *pCaps->PrimitiveMiscCaps |= WINED3DPMISCCAPS_TSSARGTEMP; > if (GL_SUPPORT(NV_REGISTER_COMBINERS2)) > - *pCaps->PrimitiveMiscCaps |= D3DPMISCCAPS_PERSTAGECONSTANT; > + *pCaps->PrimitiveMiscCaps |= WINED3DPMISCCAPS_PERSTAGECONSTANT; > #endif > > *pCaps->RasterCaps = WINED3DPRASTERCAPS_DITHER | > diff --git a/include/wine/wined3d_caps.h b/include/wine/wined3d_caps.h > index 1cedae7..98a655d 100644 > --- a/include/wine/wined3d_caps.h > +++ b/include/wine/wined3d_caps.h > @@ -34,6 +34,25 @@ > #define WINED3DPBLENDCAPS_BOTHINVSRCALPHA 0x00001000 > #define WINED3DPBLENDCAPS_BLENDFACTOR 0x00002000 > > +#define WINED3DPMISCCAPS_MASKZ 0x00000002 > +#define WINED3DPMISCCAPS_LINEPATTERNREP 0x00000004 > +#define WINED3DPMISCCAPS_CULLNONE 0x00000010 > +#define WINED3DPMISCCAPS_CULLCW 0x00000020 > +#define WINED3DPMISCCAPS_CULLCCW 0x00000040 > +#define WINED3DPMISCCAPS_COLORWRITEENABLE 0x00000080 > +#define WINED3DPMISCCAPS_CLIPPLANESCALEDPOINTS 0x00000100 > +#define WINED3DPMISCCAPS_CLIPTLVERTS 0x00000200 > +#define WINED3DPMISCCAPS_TSSARGTEMP 0x00000400 > +#define WINED3DPMISCCAPS_BLENDOP 0x00000800 > +#define WINED3DPMISCCAPS_NULLREFERENCE 0x00001000 > +#define WINED3DPMISCCAPS_INDEPENDENTWRITEMASKS 0x00004000 > +#define WINED3DPMISCCAPS_PERSTAGECONSTANT 0x00008000 > +#define WINED3DPMISCCAPS_FOGANDSPECULARALPHA 0x00010000 > +#define WINED3DPMISCCAPS_SEPARATEALPHABLEND 0x00020000 > +#define WINED3DPMISCCAPS_MRTINDEPENDENTBITDEPTHS 0x00040000 > +#define WINED3DPMISCCAPS_MRTPOSTPIXELSHADERBLENDING 0x00080000 > +#define WINED3DPMISCCAPS_FOGVERTEXCLAMPED 0x00100000 > + > #define WINED3DSTENCILCAPS_KEEP 0x00000001 > #define WINED3DSTENCILCAPS_ZERO 0x00000002 > #define WINED3DSTENCILCAPS_REPLACE 0x00000004 > > > ------------------------------------------------------------------------ > >

1 0

Regression in comctl32
by Pavel Troller 15 Feb '07

15 Feb '07

Hi! I just found a regression in comctl32 and bisected it successfully. The following commit 369749dcb2ba12ce8481503543afd18ad99805d1 is first bad commit commit 369749dcb2ba12ce8481503543afd18ad99805d1 Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Mon Feb 12 16:47:56 2007 +0800 comctl32: Make ImageList_Read and ImageList_Write compatible with each other, simplify the code. :040000 040000 7a8b282d58c6a6111ad0995eb8d47cbfbc8cadb0 afca21972669e3d013eef8de59556675a0bc798b M dlls causes that IDA Pro shows black squares instead of its toolbar icons. With regards, Pavel Troller

3 2

wineboot: Start items in StartUp folder on boot, includes security measures.
by Misha Koshelev 15 Feb '07

15 Feb '07

Hi everybody, Thanks for your suggestions. I just posted a new patch on wine-patches where I tried to incorporate these and now it does the following (in addition to my previous patch which just started items in the StartUp folder): - When wineboot finds a file that it wants to start in the StartUp folder, it asks the user whether he wants to run the program. His options are: Always, Yes, No (default), and Never. - If he selects Yes the program is run, if he select No it is not. - If he selects Always or Never, I create a registry key in: HKEY_CURRENT_USER\Software\Wine\StartupItems with the full pathname of the program and the value "always" or "never." When wineboot sees this program in the StartUp folder it checks this key, and if it is set it performs the appropriate action. What do you guys think? If you like the system, it would be pretty easy to incorporate this into the run key running as well (which are currently just run without any user confirmation)? Thanks Misha p.s. please please please anyone who is familiar with IShellFolder if you could look over those parts and just say yes it looks good that would make me feel better. I think it is correct but really an expert's opinion would be great.

8 15

Re: [cmd][try3] Update Russian translate (edited) [Really sorry!!]
by Detlef Riekenberg 15 Feb '07

15 Feb '07

On Mi, 2007-02-14 at 15:16 +0300, Anatoly Lyutin wrote: > - HELP <> .\n" > + HELP <> .\n\ > + DOS http://www.citforum.ru/operating_systems/msdos/\n" > } That link is wrong in wine. Please remove from your Patch -- By by ... Detlef

2 1

Re: [Janitorial] snmpapi: Remove the last-but-one %ll printf format
by Detlef Riekenberg 14 Feb '07

14 Feb '07

On Mi, 2007-02-14 at 15:27 -0200, Pedro Araujo Chaves Jr. wrote: > - TRACE("Counter64 %llu\n", any->asnValue.counter64.QuadPart); > + TRACE("Counter64 %su\n", > wine_dbgstr_longlong(any->asnValue.counter64.QuadPart)); > return; Did you mean "%s" ? (used "%su") -- By by ... Detlef

1 0

Re: [1/10] - [10/10] WineD3D
by Mirek 14 Feb '07

14 Feb '07

Wow, great work!!!!! 3DMark 2006 with fbo looks realy coool!! And some Nvidia SDK demos are completly fixed! Mirek Stefan Dösinger napsal(a): > > ------------------------------------------------------------------------ > > From c59f7c4eea148cfb9a1321bbbbc587ef52194bc9 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 2 Feb 2007 15:30:34 +0100 > Subject: [PATCH] WineD3D: Properly release the converted vertex declaration > > --- > dlls/d3d9/d3d9_private.h | 5 +++++ > dlls/d3d9/device.c | 3 +++ > dlls/d3d9/vertexdeclaration.c | 5 +++++ > 3 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/dlls/d3d9/d3d9_private.h b/dlls/d3d9/d3d9_private.h > index 435a37e..972945d 100644 > --- a/dlls/d3d9/d3d9_private.h > +++ b/dlls/d3d9/d3d9_private.h > @@ -179,6 +179,11 @@ typedef struct IDirect3DDevice9Impl > /* Avoids recursion with nested ReleaseRef to 0 */ > BOOL inDestruction; > > + /* A vertex declaration was converted from setFVF. > + * Keep track of it, so it can be properly freed > + */ > + IDirect3DVertexDeclaration9 *convertedDecl; > + > } IDirect3DDevice9Impl; > > > diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c > index 4eff550..e6ecd96 100644 > --- a/dlls/d3d9/device.c > +++ b/dlls/d3d9/device.c > @@ -62,6 +62,8 @@ static ULONG WINAPI IDirect3DDevice9Impl_Release(LPDIRECT3DDEVICE9 iface) { > > if (ref == 0) { > This->inDestruction = TRUE; > + if (This->convertedDecl != NULL) > + IUnknown_Release(This->convertedDecl); > IWineD3DDevice_Uninit3D(This->WineD3DDevice, D3D9CB_DestroyDepthStencilSurface, D3D9CB_DestroySwapChain); > IWineD3DDevice_Release(This->WineD3DDevice); > HeapFree(GetProcessHeap(), 0, This); > @@ -766,6 +768,7 @@ HRESULT WINAPI IDirect3DDevice9Impl_SetFVF(LPDIRECT3DDEVICE9 iface, DWORD FVF) > > hr = IDirect3DDevice9Impl_SetVertexDeclaration(iface, pDecl); > if (hr != S_OK) goto exit; > + This->convertedDecl = pDecl; > pDecl = NULL; > > exit: > diff --git a/dlls/d3d9/vertexdeclaration.c b/dlls/d3d9/vertexdeclaration.c > index a7f5486..c3f462e 100644 > --- a/dlls/d3d9/vertexdeclaration.c > +++ b/dlls/d3d9/vertexdeclaration.c > @@ -360,6 +360,11 @@ HRESULT WINAPI IDirect3DDevice9Impl_SetVertexDeclaration(LPDIRECT3DDEVICE9 ifa > > TRACE("(%p) : Relay\n", iface); > > + if (This->convertedDecl && This->convertedDecl != pDecl) { > + IUnknown_Release(This->convertedDecl); > + This->convertedDecl = NULL; > + } > + > hr = IWineD3DDevice_SetVertexDeclaration(This->WineD3DDevice, pDeclImpl == NULL ? NULL : pDeclImpl->wineD3DVertexDeclaration); > > return hr; > > > ------------------------------------------------------------------------ > >

2 1

Re: [Janitorial] snmpapi: Remove the last-but-one %ll printf format
by Eric Pouech 14 Feb '07

14 Feb '07

Pedro Araujo Chaves Jr. a écrit : > case ASN_COUNTER64: > { > - TRACE("Counter64 %llu\n", any->asnValue.counter64.QuadPart); > + TRACE("Counter64 %su\n", wine_dbgstr_longlong(any->asnValue.counter64.QuadPart)); > it should read %s\n"... A+

1 0

GPU performance counters, agp usage
by Stefan Dösinger 14 Feb '07

14 Feb '07

Hi, I've had a look at various performance counters of my nvidia card with nvperfkit and nvperfgraph while running half-life 2. The first thing I noticed was that the gpu was approximately 75% to 90% idle, while one cpu core was 100% busy and the other completely idle. More to that later. The other interesting thing was that "OGL driver waiting" was at 100% and agp usage was beyond what nvperfgraph could show. This seems to happen with any application that uses opengl in wine, including very simple d3d apps(Moto racer 2, Direct3D1) and opengl apps(Jedi academy). when the application quits the counters fall back to 0 immediately. On the other hand, a native Linux application(ut2004, 64 bit) does not cause any change in the driver waiting and the agp usage stays at zero. (makes me wonder a bit how useful those counters are). For wine it is enough to successfully create a d3d device or opengl context. Just a IDirect3D9::CreateDevice does it. Regarding the 75% idle, I think that is comparably ok. Native ut2004 shows the same behavior. So either the games are broken, or I have a way to overpowered gpu(geforce 7600) for my cpu(athlon 64 X2 dual core 3800+). Any ideas regarding the agp usage? Could a badly chosen pixel format cause the trouble? Cheers, Stefan

3 2

wined3d: The sims regression
by Alessandro Pignotti 14 Feb '07

14 Feb '07

Hi, I've noticed that commit 12252d058914a66f40e976484cc7d8aa52ffca47 on the git tree causes a regression in the sims, making characters flipped upside down. It's seems to me that the y axis is flipped. I hope this helps Bye Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

2 1

Re: Declare some WinXP related structures
by Dmitry Timoshkov 14 Feb '07

14 Feb '07

"Kovács András" <andras(a)csevego.net> wrote: > --- a/include/winuser.h > +++ b/include/winuser.h > @@ -1055,6 +1055,51 @@ BOOL WINAPI SetSysColors(INT,const INT*,const COLORREF*); > #define WM_GETICON 0x007f > #define WM_SETICON 0x0080 > > + /* Windows XP messages */ > +#define WM_INPUT 0x00FF Please don't add this kind of a comment, even if it's true for this particular message, it may not belong to all messages below this one. > + /* Windows XP related raw input structures */ > +typedef struct tagRAWINPUTDEVICE { You have added a bunch of structures in the middle of the message definitions, please find a better place. -- Dmitry.

1 0

Re: opengl
by Tom Wickline 14 Feb '07

14 Feb '07

On 2/13/07, gaosheng <gs(a)crosslight.com.cn> wrote: > Hi: > I want to use opengl with wine. > > //----Here is my glxinfo. > > server glx vendor string:SGI > server glx version string:1.2 > > client glx vendor string:SGI > client glx version string:1.2 > > OpengGL vendor string:Mesa project:www.mesa3d.org > OpengGL renderer string:Mesa GLX Indirect > OpengGL version string:1.3 Mesa 4.0.4 > //------ > > I can't init opengl. when ChoosePixel(), it failed. > Can you tell me the reason. You will need to have direct rendering, and to see if its currently activated (status) you can grep glxinfo : $ glxinfo | grep direct You will want to make sure it says Yes tom@prostar ~ $ glxinfo | grep direct direct rendering: Yes tom@prostar ~ $ You may also need to update your module section in your X.org conf file You will want to turn off dri and turn glx on. # Load "dri" Load "glx" You may also want to grep the vendor tom@prostar ~ $ glxinfo | grep vendor server glx vendor string: NVIDIA Corporation client glx vendor string: NVIDIA Corporation OpenGL vendor string: NVIDIA Corporation tom@prostar ~ $ You can run 'glxgears' before and after also, here it makes a huge difference. tom@prostar ~ $ glxgears 54378 frames in 5.0 seconds = 10875.471 FPS 54802 frames in 5.0 seconds = 10960.384 FPS 54775 frames in 5.0 seconds = 10954.939 FPS tom@prostar ~ $ Cheers, Tom > > Best regards > gao sheng >

1 0

Re: [4/9] d3d8: Add an IDirect3DVertexDeclaration8 class to hold the wined3d vertex declaration
by Ivan Gyurdiev 14 Feb '07

14 Feb '07

> > The idea of this patch and the next few is to create an internal d3d8 > object to hold the wined3d declaration and give the d3d8 vertex shader > a field to hold the d3d8 vertex declaration object. Setting the d3d8 > vertex shader will then set both the wined3d shader and the wined3d > vertex declaration. Excellent. I don't know if the implementation works, but the idea is certainly on the right track. This was done incorrectly to begin with, and also made it difficult to remove the dependency on d3d8/d3d9 includes (which I see you're on track to complete). Ivan

1 0

compiling out debugging messages?
by Lei Zhang 13 Feb '07

13 Feb '07

Hi, Is it still possible to compile out debugging messages? According to http://winehq.org/site/docs/winedev-guide/dbg-compiling, I can pass --disable-debug, but the Changelog says that option was removed about 10 month ago. - Lei

2 4

Re: Add RegisterRawInputDevices stub implementation
by Felix Nawothnig 13 Feb '07

13 Feb '07

Kovács András wrote: > +BOOL WINAPI RegisterRawInputDevices(PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize) > +{ > +int i; Please keep the indentation style of the original file.

1 0

Starting work on wine (Direct X Help)
by Nathan Williams 13 Feb '07

13 Feb '07

I want to get my hands dirty in the wine source code but I need a little guidance, hopefully from someone working on the DirectX sections of wine. I've decided I want to get Carmageddon working properly. I have already added it to the appdb (http://appdb.winehq.org/appview.php?iVersionId=6993) for the windows version. My main question is, how can I go about linking the visual bugs that I see with the area of code that needs work? I have worked with DirectX before and I am capable of coding tests and hooking directx on windows if needed. -- Nathan

2 4

Re: opengl
by Stefan Dösinger 13 Feb '07

13 Feb '07

Am Dienstag 13 Februar 2007 10:13 schrieb gaosheng: > OpengGL renderer string:Mesa GLX Indirect is your reason. You do not have a 3D driver installed or properly set up

2 2

Re: version: Constify a formal parameter of VerQueryValue{A|W}()
by Felix Nawothnig 13 Feb '07

13 Feb '07

Andrew Talbot wrote: > -BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPSTR lpSubBlock, > +BOOL WINAPI VerQueryValueA( LPVOID pBlock, LPCSTR lpSubBlock, This is wrong - in the PSDK headers it's LPSTR (the first parameter should be const though). Felix

2 2

Re: Bug 50
by Pedro Araújo Chaves Jr. 13 Feb '07

13 Feb '07

I've been trying to get the lpDx array to be properly calculated, but unfortunately to no avail. I did find, though, that GetTextExtentExPointW is never called with a maxExt value other than zero, and thus nfit is not calculated. Regarding that, would any of you know where I should look for the proper method of calculating the maximum width (maxExt) of a formatted string? I'm somewhat puzzled... neither lprect nor dc->BoundsRect seem to hold the proper values for getting that value [1], or (more likely, I guess) I'm just looking at it the wrong way. Btw, I'd add that I've been testing this in Lotus Notes R5, just in case it helps, and no, I haven't found a link to download a trial. [2] [3] Cheers, Pedro. [1] I'm investigating the SetTextJustification, ExtTextOutW, GetTextExtentPointW, GetTextExtentPoint32W, GetTextExtentExPointW, and WineEngGetTextExtentExPoint functions from gdi32 (the latter in freetype.c, the rest in font.c). I am yet to look into their *I counterparts, where applicable. [2] http://appdb.winehq.org/viewbugs.php?bug_id=50 [3] http://bugs.winehq.org/show_bug.cgi?id=7016

2 3

Re: opengl
by Bryan Haskins 13 Feb '07

13 Feb '07

Well you don't have Direct rendering... if you dont have support from the ATI OSS drivers ( if you use ATi) then you should download the ATI or nvidia proprietary drivers. Should be in your Distros Repos, or you can set them up yourself from their sties. On 2/13/07, gaosheng <gs(a)crosslight.com.cn> wrote: > > Hi: > I want to use opengl with wine. > > //----Here is my glxinfo. > > server glx vendor string:SGI > server glx version string:1.2 > > client glx vendor string:SGI > client glx version string:1.2 > > OpengGL vendor string:Mesa project:www.mesa3d.org > OpengGL renderer string:Mesa GLX Indirect > OpengGL version string:1.3 Mesa 4.0.4 > //------ > > I can't init opengl. when ChoosePixel(), it failed. > Can you tell me the reason. > > Best regards > gao sheng > > > > > -- Cheers, Bryan

1 0

Linuxtag 2007
by Stefan Munz 13 Feb '07

13 Feb '07

Hi, mentioned a few days ago I try to register "Wine" for participating at the Linuxtag 2007. They want some information that I can only guess. Maybe someone can provide me a better estimation for: Developers in 1. Germany 2. Europe (incl. Germany) 3. Worldwide (incl. Europe) How many developers work for Codeweavers (as they are for sure the biggest contributor)? -- Dipl.-Inform. Stefan Munz. . . . . . . . . . stefan.munz(a)itomig.de ITOMIG GbR . . . . . . . . . . . . . . . . . www.itomig.de Sand 14 . . . . . . . . . . . . . . . . . . mobil: +49 178 729 72 72 D-72076 Tübingen . . . . . . . . . . . . . .

6 8

Re: [PATCH] switch stat and fopen
by Mike McCormack 13 Feb '07

13 Feb '07

Marcus Meissner wrote: > - if (!(fin = fopen(input_file_name, "r"))) return 0; > if (stat(input_file_name, &st) < 0) return 0; > + if (!(fin = fopen(input_file_name, "r"))) return 0; Wouldn't it be better to use fstat here to avoid a race condition? Mike

2 1

Re: mshtml #10: Added SchemeIs implementation.
by Alexandre Julliard 13 Feb '07

13 Feb '07

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/nsio.c | 12 +++++++++++- > 1 files changed, 11 insertions(+), 1 deletions(-) This one causes make test to hang in the htmldoc.c test, somewhere in test_download(). -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: avifil32: sign-compare fixes
by Alexandre Julliard 13 Feb '07

13 Feb '07

Joris Huizer <joris_huizer(a)yahoo.com> writes: > diff --git a/dlls/avifil32/avifile.c b/dlls/avifil32/avifile.c > index f989c79..e7b22b1 100644 > --- a/dlls/avifil32/avifile.c > +++ b/dlls/avifil32/avifile.c > @@ -835,7 +835,7 @@ static LONG WINAPI IAVIStream_fnFindSamp > ULONG n; > > for (n = 0; n < This->sInfo.dwFormatChangeCount; n++) > - if (This->idxFmtChanges[n].ckid >= pos) { > + if (This->idxFmtChanges[n].ckid >= (ULONG)pos) { Please don't add typecasts all over the place. If things can be fixed by changing variable types then that's fine, but otherwise we can just as well live with the warnings. -- Alexandre Julliard julliard(a)winehq.org

1 0

opengl
by gaosheng 13 Feb '07

13 Feb '07

Hi: I want to use opengl with wine. //----Here is my glxinfo. server glx vendor string:SGI server glx version string:1.2 client glx vendor string:SGI client glx version string:1.2 OpengGL vendor string:Mesa project:www.mesa3d.org OpengGL renderer string:Mesa GLX Indirect OpengGL version string:1.3 Mesa 4.0.4 //------ I can't init opengl. when ChoosePixel(), it failed. Can you tell me the reason. Best regards gao sheng

1 0

Re: DIB Engine, some summarization
by Rolf Kalbermatter 13 Feb '07

13 Feb '07

Damjan Jovanovic [mailto:damjan.jov@gmail.com] well: >What about the case where you draw with GDI, then render with OpenGL on >top of that, then draw on top of that with GDI, then swap buffers? >If you draw only client-side, you have to copy to the server, then copy >back, then copy to the server *again*. You have to upload or download >the image *every time* you go between OpenGL and GDI drawing, whereas >when you draw with X11, there is no uploads/downloads unless you use >DIB sections and draw directly. Well, I have to admit I don't understand the whole complexity with DirectX, OpenGL and GDI. But the DIB engine is mostly for DIB sections I would think. It could be used for most device dependant bitmap surfaces too as long as the driver puts them in the surface structure of course, since that are just bitmaps too, but if that would be wise is another question. I would think that to start with the handling of DIBs would be most important. Or is it the idea to use the DIB engine for device dependant bitmaps attached to the device context too? Because that would make at least this case probably indeed more complicated. As far as X11 is concerend device dependant bitmaps should not pose a problem other than possibly performance if an application also wants to draw directly in the bitmap. But this works now and could be left in. And the bit depth will be alright since the ddb should be in the same bit depth as what the X11 server uses. DIBs however have the additional problem of using any possible bit depth with X11 only really supporting the currently used bit depth. So here you want to get X11 out of the loop if possible. >X11 drawing has some more advantages, like being able to use forms of >hardware acceleration (XAA/EXA) that client-side drawing can't. That might be but arbitrary bit depth support for hardware related acceleration is probably not very common among chip sets. >A pure client-side drawing strategy is IMO inferior to a strategy where >you can draw client-side or server-side, as the need arises. I think DIB drawing should be if possible kept on the client side. That solves the problems with X11 not supporting arbitrary bit depths and also synchronisation of the bitmaps if the application uses direct bitmap access too. And it wouldn't be pure client side at all. A driver can hook functions even for DIBs if he wants. If he does he would of course have to make sure all bit depths are supported and synchronisation is taken care off. Support of all bit depts would be quite easy as it could decide to do whatever modes it can do and otherwise pass it on to the GDI engine anyhow. If the driver doesn't hook or fails that function somehow then the GDI engine is used to do the operation for the DIB. And at least for drivers having their device bitmap in the device context too (under Windows a driver doesn't need to do that, for instance always drawing directly to the shared video memory), it might be possible to use the DIB engine too, but that would be the drivers decision and as said I'm not yet sure that is how it's done under Windows nor if it should be done this way. Rolf Kalbermatter

1 0

ntdll: test that shows RtlRaiseException with EXCEPTION_BREAKPOINT mangles Eip of context
by Peter Oberndorfer 12 Feb '07

12 Feb '07

This test is supposed to show that the Eip field in the context is fixed up somewhere inside RtlRaiseException or NtRaiseException (test for NtRaiseException not included) for (only) EXCEPTION_BREAKPOINT exception For others context.Eip is not changed. Since real exceptions on wine also take that path i guess it is best to implement context modifing in there. The next patches will show what is the value of context.Eip in a Vectored exception handler (I still have some problems with this patch) After that i plan to wrap a debugger around the test to show that the debugger gets a unmodified context The ultimate goal is to fix the "Handling of EXCEPTION_BREAKPOINT" problem Vitaliy Margolen reported ( http://bugs.winehq.org/show_bug.cgi?id=7063 ) Patch tested on XP/2k Comments, suggestions? Greetings Peter --- dlls/ntdll/tests/exception.c | 85 ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 85 insertions(+), 0 deletions(-)

1 0

Re: extract DLL calls from exe file (i.e. from portable executable)
by Stefan Dösinger 12 Feb '07

12 Feb '07

Am Montag 12 Februar 2007 18:56 schrieb Luis C. Busquets Pérez: > Dear all, > > I send this e-mail to you as I have not found a particular section to > put it. I have developped a little program that enables to know the > functions an exe or dll calls. I understand that it may be really > helpful to know if a program will run perfectly on wine or if there is > still a function missing. I think wine-devel is the better list for that. For inclusion in wine please send diffs against the wine code rather than some zipped sources. And I am not sure if pascal is allowed in wine. C or bash scripts are better. > The idea behind this program is the following: > A program compiled to run on MS Windows calls a number of system/program > libraries. > This tool enables to know which functions a program compiled for MS > Windows needs. I think winedump does that, but I could be mistaken > A tool such as WINE provides an implementation of the Windows API. This > implementation has to provide at least the calls that the program calls > in order to run correctly under WINE. Well, not really. That a function is implemented in wine does not necessarily mean that it is free of bugs. In most cases applications do not run because of bugs in the implementation rather than missing functions. > TODO: At this point, you are able to know the calls. In a future time, > extrdll or a script will be able to read the functions that WINE has > implemented and tell a user which dlls or functions on dlls the program > is missing to run correctly. There are some other issues too: I don't speak pascall, but can your program deal with lazy linking, i.e. functions loaded after startup with LoadDLL? And I think you will not be able to read COM interfaces. For example for Direct3D9 you will see only one call, CreateDirect3D9, although d3d9 has numerous interfaces with a few hundred methods.

1 0

Re: extract DLL calls from exe file (i.e. from portable executable)
by Paul Vriens 12 Feb '07

12 Feb '07

Luis C. Busquets Pérez wrote: > Dear all, > > I send this e-mail to you as I have not found a particular section to > put it. I have developped a little program that enables to know the > functions an exe or dll calls. I understand that it may be really > helpful to know if a program will run perfectly on wine or if there is > still a function missing. > > The idea behind this program is the following: > A program compiled to run on MS Windows calls a number of system/program > libraries. > This tool enables to know which functions a program compiled for MS > Windows needs. > > A tool such as WINE provides an implementation of the Windows API. This > implementation has to provide at least the calls that the program calls > in order to run correctly under WINE. > > TODO: At this point, you are able to know the calls. In a future time, > extrdll or a script will be able to read the functions that WINE has > implemented and tell a user which dlls or functions on dlls the program > is missing to run correctly. > > Please let me know if you put it in the winehq. I look forward to have > the opportunity to contribute to the wine project. > > Luis C. Busquets Pérez > T. +32 473 353 128 > > > > ------------------------------------------------------------------------ > > Hi, excuse me if got it wrong, but what's the difference with winedump? Cheers, Paul.

1 0

[7/10] WineD3D: Make the context array dynamic
by Stefan Dösinger 12 Feb '07

12 Feb '07

1 0

DirectX related question
by Tim Schmidt 12 Feb '07

12 Feb '07

Already looking at buying a new computer to play Supreme Commander (http://en.wikipedia.org/wiki/Supreme_commander), is there anything I can do (including, but not limited to purchasing hardware) to help get this game running under Wine? I can't promise miracles, but if I can break down a few obstacles, consider it done. --tim

3 3

Re: user32: WM_NCACTIVATE sent by set_active_window() should never deactivate
by Alexandre Julliard 12 Feb '07

12 Feb '07

Felix Nawothnig <flexo(a)holycrap.org> writes: > This fixes #7198. Problem is that GetForegroundWindow() sometimes > returns NULL (MSDN says: "in certain circumstances, such as when a > window is losing activation"). I didn't bother to check why this > happens for some apps (winemine works fine for me, winecfg doesn't - I > suspect timing issues) here as I saw no point in this check anyway: The point is that the window should not be painted active if it's not the foreground window too. There is one active window per queue, but only one foreground window. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/9] WineD3D: Add a per context structure for context management
by Alexandre Julliard 12 Feb '07

12 Feb '07

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This patch adds a new context management structure which will keep a dirty > state list, state optimization members, a glx context and drawable, ... [2. application/x-zip; 0003-WineD3D-Add-a-per-context-structure-for-context-management.txt.zip]... Please don't send patches in zip format, that's a pain to extract. If you really have to compress please use gzip or bzip2. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: Fix compilation on systems that don't support nameless structs.
by Alexandre Julliard 12 Feb '07

12 Feb '07

Francois Gouget <fgouget(a)free.fr> writes: > diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c > index 34a05b7..4d5c41d 100644 > --- a/dlls/ntdll/rtl.c > +++ b/dlls/ntdll/rtl.c > @@ -40,6 +40,12 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(ntdll); > > +#ifdef NONAMELESSSTRUCT > +# define S(x) (x).s > +#else > +# define S(x) (x) > +#endif > + You shouldn't need that sort of macro in the Wine code. Simply define NONAMELESSSTRUCT unconditionally. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comtctl32 : updown : Getter and Setter Tests for Updown control
by James Hawkins 12 Feb '07

12 Feb '07

On 2/10/07, Leslie Choong <septikus(a)gmail.com> wrote: > Hi there, My name is Leslie Choong and I am currently finishing up my > under graduate work at UCLA. This patch is being sent as part of the > coursework for CS 130 : Software Engineering. Please take a look and > let me know if you have any suggestions or comments for change. > Thanks! > -Leslie Choong > + /* Set Range from 0 to 100 */ + r = SendMessage(updown, UDM_SETRANGE, 0 , MAKELONG(100,0) ); + r= SendMessage(updown, UDM_GETRANGE, 0,0); If you're not going to check the first return value, then take out the 'r =', else it seems like you're missing a test. On the other hand, why don't you test the return value? -- James Hawkins

3 4

Re: user32: add test cases for update rects affected by ShowWindow
by Dmitry Timoshkov 12 Feb '07

12 Feb '07

"Clinton Stimpson" <cjstimpson(a)utwire.net> wrote: > This patch adds a test to check the results of GetUpdateRect when a > child window is hidden. > See bug #7360. Wine incorrectly makes an update rect for the > grandparent window which has a todo_wine around it. > > Thanks, > Clinton Stimpson > > ChangeLog: > Add test for GetUpdateRect and ShowWindow interaction. After looking at this test once more, I think we need another test with windows without CS_PARENTDC style set in order to understand better what the proper behaviour is. -- Dmitry.

1 0

Re: wineboot: Start items in StartUp folder on boot, includes security measures.
by James Hawkins 12 Feb '07

12 Feb '07

On 2/11/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > Ok, thanks to everybody's responses on the wine-devel list. Here is my > new version of this patch. It starts the items in the StartUp folder > like Windows does (again, if anybody who knows about IShellFolder will > look over my code that would be great :) I tested it and it works for > the Vector NTI installer, but I would really like to have an expert's > opinion on whether it is missing osmething). There were a lot of > comments on wine-devel about malware using this system to start itself > so here is what I added: > > - When wineboot finds a file that it wants to start in the StartUp > folder, it asks the user whether he wants to run the program. His > options are: Always, Yes, No (default), and Never. > - If he selects Yes the program is run, if he select No it is not. > - If he selects Always or Never, I create a registry key in: > HKEY_CURRENT_USER\Software\Wine\StartupItems with the full pathname > of the program and the value "always" or "never." When wineboot sees > this program in the StartUp folder it checks this key, and if it is > set it performs the appropriate action. > > To me it seems like this would be enough to prevent malware from using > this system because the user could just click no or never. Also, someone > pointed out that wineboot already runs quite a lot of other RUN registry > keys that can be used for malware, and currently there is no system for > these keys like the one I made for startup. Any comments will be > appreciated. Thanks. > These anti-malware changes are unnecessary. We implement Wine to be bug-for-bug compatible with Windows. Windows doesn't ask this question, and Wine shouldn't either. It's not our policy to not implement portions of Windows that make it easier for malware to run. -- James Hawkins

3 2

wineboot: Start items in StartUp folder on boot, includes security measures. [with the patch]
by Misha Koshelev 11 Feb '07

11 Feb '07

I forgot to include the patch, so here it is. Misha --- Hi everybody, Thanks for your suggestions. I just posted a new patch on wine-patches where I tried to incorporate these and now it does the following (in addition to my previous patch which just started items in the StartUp folder): - When wineboot finds a file that it wants to start in the StartUp folder, it asks the user whether he wants to run the program. His options are: Always, Yes, No (default), and Never. - If he selects Yes the program is run, if he select No it is not. - If he selects Always or Never, I create a registry key in: HKEY_CURRENT_USER\Software\Wine\StartupItems with the full pathname of the program and the value "always" or "never." When wineboot sees this program in the StartUp folder it checks this key, and if it is set it performs the appropriate action. What do you guys think? If you like the system, it would be pretty easy to incorporate this into the run key running as well (which are currently just run without any user confirmation)? Thanks Misha

1 0

Re: wineboot: Start items in StartUp folder on boot, includes security measures.
by Joris Huizer 11 Feb '07

11 Feb '07

It seems the patch itself got lost ____________________________________________________________________________________ Food fight? Enjoy some healthy debate in the Yahoo! Answers Food & Drink Q&A. http://answers.yahoo.com/dir/?link=list&sid=396545367

1 0

Re: First implementation of a directplay service provider
by Kai Blin 11 Feb '07

11 Feb '07

On Saturday 10 February 2007 19:39, Alessandro Pignotti wrote: > I'm working to implement a service provider compatible with the protocol > used by directplay over TCP/IP. > Currently i've implemented the lobby code and tested it against > simpleconnect.exe and chatconnect.exe from the DirectX 7 SDK. At the very end of the patch, you missed a C++ style comment. (+ data->dwReserved1=0x1f4; //Values taken from registry (are they useful at all?)) Btw, I think you should set that data to NULL for now, rather than any random magic value. You shouldn't need the +#define LOBBYINFORMATIONFLAG_CLIENTSERVER 0x00000001 +#define LOBBYINFORMATIONFLAG_MIGRATEHOST 0x00000004 +#define LOBBYINFORMATIONFLAG_NODPSRV 0x00000040 +#define LOBBYINFORMATIONFLAG_PASSWORD 0x00000080 +#define LOBBYINFORMATIONFLAG_NOENUMS 0x00000100 +#define LOBBYINFORMATIONFLAG_FASTSIGN 0x00000200 +#define LOBBYINFORMATIONFLAG_FULLSIGN 0x00000400 +#define LOBBYINFORMATIONFLAG_ENCAPSULATE 0x00002000 stuff, as dplay.h defines that already, iirc. + inf->lobbyID=0x01020304;//Just a fixed Id now, will randomize someday There is some pattern to the DPIDs after the first. They're not random. I just didn't quite figure out how it works yet. Btw, you missed a C++ style comment there.. A few lines over that line, too. You're not sending a dplay version in your header so far. Is that intentional? Why are you declaring dummy functions and then comment out setting them in SPInit()? Good work, anyhow. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: Some thoughts about the ominous DIB Engine
by Rolf Kalbermatter 11 Feb '07

11 Feb '07

Felix Nawothnig wrote: >I suggested to do all the work server-side a while back: > >http://www.winehq.org/pipermail/wine-devel/2005-July/038695.html > >Especially see: > >http://www.winehq.org/pipermail/wine-devel/2005-July/038703.html Well, this would mostly mirror the Windows architecture nowadays where almost all of this is in win32k.sys and GDI32 is mostly a user space wrapper around that. A bit like ntdll does for kernel operations. But I would be a bit concerned about performance if most calls have to be passed to the server side to be handled but maybe that is not really an issue? Didn't MS put part of the GDI somehow back in user space when going from NT4 to 2K just because of performance concerns? Would still remain the question where and how to hook this into dib handling but I think GDI would be better. Basically call the dc driver and if that fails branch into the local dibeng API for apropriate functions. Rolf Kalbermatter

4 4

signedness/WINAPI changing question
by Joris Huizer 11 Feb '07

11 Feb '07

I have a small question: I find some function LONG WINAPI AVIStreamSampleToTime(PAVISTREAM pstream, LONG lSample) (in the avifil32 dll), the second parameter should really be an ULONG instead of a LONG. It'd fix the signedness problems. My question is, is such a change allowed? And what should I do to update for such a change (except for the header gcc warns about) In case such change must not be performed, I'll just add a local variable which is a casted version. I thought this needs asking; adding in unnecessary variables doesn't seem the best fix to me. regards, Joris ____________________________________________________________________________________ Don't pick lemons. See all the new 2007 cars at Yahoo! Autos. http://autos.yahoo.com/new_cars.html

3 2

doc: Add a Quick start to the Wine User Guide
by Jeff L 11 Feb '07

11 Feb '07

This change came about when a friend described his problems in getting wine going to see if it would help him with making a Windows app run under Linux. He did not want to get into the details of wine as his was a opportunistic need and his comment that hit home was "that many a newbie expects software to just install but wine seems too complicated and there is not a cheat sheet". It seems that there is nowhere where the basics are described step by step for the first time casual user. Jeff Latimer Index: en/wineusr-introduction.sgml =================================================================== RCS file: /cvsroot/wine/docs/en/wineusr-introduction.sgml,v retrieving revision 1.4 diff -u -u -r1.4 wineusr-introduction.sgml --- en/wineusr-introduction.sgml 12 Dec 2006 04:11:06 -0000 1.4 +++ en/wineusr-introduction.sgml 11 Feb 2007 08:04:31 -0000 @@ -52,6 +52,50 @@ </para> </sect2> + <sect2> + <title>Quick start</title> + <para> + The process of installing and running wine can be summarised as + follows: + <itemizedlist> + <listitem> + <para> + Get a distribution as indicated in <link + linkend="getting-wine">Getting Wine</link> and see + the <ulink url="http://www.winehq.org/site/download">Wine + Downloads</> page. For the casual or new user the simplest + is to get an rpm distribution. + </para> + </listitem> + <listitem> + <para> + Configure wine using the <link + linkend="config-wine-main"><emphasis><filename>winecfg</></> + </link> command. For most people wine should now be usable. + </para> + </listitem> + <listitem> + <para> + To test your installation run wine's Windows 3.1 like file + manager using the <filename>wine winefile</> command. + </para> + </listitem> + <listitem> + <para> + Run wine using the <link + linkend="running"><emphasis><filename>wine</> + <filename>filespec/appname.exe</></></link> command. + </para> + <para> + The first command you will run will be to install a package. + Typically something like <filename>wine + /media/cdrom/setup.exe</> or the equivalent. + </para> + </listitem> + </itemizedlist> + </para> + </sect2> + </sect1> <sect1 id="what-is-wine">

2 1

wineboot: Start items in StartUp folder on boot.
by Misha Koshelev 11 Feb '07

11 Feb '07

Hi, As you all may have noticed, I have been making quite a few patches within the last two weeks (or at least quite a few when compared to zero before then) because I had figured out that the Vector NTI program that is quite important in molecular biologThis patch makes sure that wine will start items in the StartUp folder (Programs) just like Windows. The reason this is necessary, well #1 this is something Windows does that Wine doesn't do, but #2 this is required by the Vector NTI installer (bug #7384), which installs necessary dependencies (MDAC and about 6 other things) by installing one, then placing a link to itself in StartUp, then rebooting. With this patch, it will actually restart correctly, and in fact just running wine installer.exe will actually successfully do the install from start to finish (for the alternative to install this prior to this and a few other patches, see my shell script http://misha680.googlepages.com/InstallVectorNTI10.sh). There is still the lack of JScript support which fails to install some things, but that's about it.y (and freely available to academic researchers) can be installed on Wine and run with quite little problem with a quite complicated install script I made http://misha680.googlepages.com/InstallVectorNTI10.sh). There was one pretty significant bug, but after that I wanted to try to track down and patch other bugs that forced the above script to be required. With the exception of a pretty significant lack of JScript support in wine/MSI which causes installation of quite a few files to fail (and thus still require native jscript.dll and native MSI), this final patch I just sent out makes the install work from start to finish, which is quite a change from before. I posted two patches earlier (a conformance test and a fix) that adds path searching to shell link creation (which the conformance test shows exists in Windows for a file like rundll32.exe that is not found in the current directory), and if anyone has comments about those patches please send them to me. My last patch ensures that this shelllink that the Vector NTI installer creates every time it tries to restart (about six or so times after every Microsoft component it installs that it needs and comes with) will be executed, and in fact is meant to reproduce the Windows behavior of starting items in the StartUp program group on login that occurs in Windows. I am new to the whole IShellFolder thing, though, and I tried to make it as proper as I could. But I certainly feel that I would like to have someone more experience to look at it. Oh, and I just wanted to say a big thanks to Dan Kegel, James Hawkings, Mike McCormack, and others who have helped me so far (not to mention Alexandre Julliard for committing some of my patches). Misha

7 8

Re: wineshelllink: disable startup notification
by Alexander Nicolaysen Sørnes 10 Feb '07

10 Feb '07

Fredag 09 februar 2007 18:25, skrev Tijl Coosemans: > Wine doesn't support startup notification afaict and endlessly bouncing > cursors are annoying. Wine does support startup notifications, but not if the 'enable window manager to control windows applications' is disabled in winecfg. Regards, Alexander N. Sørnes > > --- tools/wineshelllink.orig Fri Feb 9 17:46:58 2007 > +++ tools/wineshelllink Fri Feb 9 17:59:14 2007 > @@ -88,6 +88,7 @@ > [Desktop Entry] > Name=$linkname > Exec=wine "$path" $args > +StartupNotify=false > Type=Application > EOF > [ -z "$descr" ] || echo "Comment=$descr"

1 0

Handling of EXCEPTION_BREAKPOINT
by Vitaliy Margolen 10 Feb '07

10 Feb '07

It seems Wine has problems with correct return address for the int3 brakepoint exception. It's covered in bug http://bugs.winehq.org/show_bug.cgi?id=7063 There is even a test case with a proposed fixes. Can anyone with knowledge of the debugger events take a look at it? If the patch can be committed Wine will get that much closer to the supporting more unti-debugger protection schemes. Vitaliy Margolen.

1 0

Fullscreen broken in XVidMode
by Vitaliy Margolen 10 Feb '07

10 Feb '07

For about a month now Wine is completely unusable for fullscreen games when using XVidMode instead of XRandr extension. Worse, this is a regression, caused by this patch: f6702ec4afb4098cbb67d6bd670a9f0527191f80 is first bad commit commit f6702ec4afb4098cbb67d6bd670a9f0527191f80 Author: Dmitry Timoshkov Date: Tue Jan 9 23:57:33 2007 +0800 winex11.drv: Force the fullscreen state update once the window is mapped. :040000 040000 f83b3a76eeecd52a04ed04201c49ac15244b0a25 d57c3162633300eabdb9fea65d530eb91cd929f5 M dlls Can we get some ideas going about why this is happening and how to fix it? Vitaliy Margolen.

1 0

Wine beta ASIO-driver.
by Tor Einar Tønnessen 10 Feb '07

10 Feb '07

Hello, First let me introduce myself. I am Tor Einar Toennessen ( actually Tønnessen ). I am from Norway. I have followed the development of Wine a little bit on and off over some years ( maybe about 10 ). My main interrest with Wine is in the audio and midi area. I would like to comment on the asio-driver. I think its marvellous that wine has got an ASIO-capable audio-driver. The patch do however no longer apply cleanly to todays git-version. Secondly I had some trouble getting it to work, until I found out that I had to run "autoheader" not just "autoconf" in order to to get the symbol HAVE_ASIO_SDK_ASIO_H into config.h (via config.h.in). Also I would like very much that you (Robert Reif isn't it ?) develop the driver a little further. The first thing beeing a control-panel. But what is most import I think , is to make a new patch that works on todays wine, and get it into the ReadMe that one must run autoheader to. In that way more people can make it work and test it out... Tor Einar

2 1

name conflicts - Wine and OpenWatcom
by Wesley Parish 10 Feb '07

10 Feb '07

I'm running Mandriva 2k7 and started installing Wine. The installation stalled on discovering I have OpenWatcom installed. Wine didn't like /usr/bin/wrc, the OpenWatcom Windows Resource Compiler. I could rename wrc to wwrc - what would people suggest? Wesley Parish -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

1 0

Helping a user migrate an odbc app to Wine
by Dan Kegel 10 Feb '07

10 Feb '07

Can somebody help this (german-speaking) fellow: http://www.unixboard.de/vb3/showthread.php?t=26943 He says his company's internal application requires you to input a DSN when installing it, and he doesn't know how to come up with a DSN under Wine. Presumably he doesn't want to mess with Unixodbc, he just wants to keep using the Microsoft drivers...? - Dan

5 5

Re: shell32[3/3]: allow overwriting files in SHFileOperation(FO_COPY) (with confirmation dialogs, fixes bug #7046)
by James Hawkins 09 Feb '07

09 Feb '07

On 2/9/07, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > The return codes when the user cancelled the operation as in Vista, as > they are more logical and easier to implement than the XP ones. If > Microsoft changed them there are probably not many apps that would > depend on it. With this change the program in bug #7046 works fine. > > From 799ff7b7cc6092fbd3e2030c7b4eb84d829b9842 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Fri, 9 Feb 2007 16:43:06 +0100 > Subject: [PATCH] shell32: allow overwriting files in SHFileOperation(FO_COPY) (with confirmation dialogs) > > --- > dlls/shell32/shell32_Bg.rc | 6 ++- > dlls/shell32/shell32_Cs.rc | 8 ++- > dlls/shell32/shell32_De.rc | 6 ++- > dlls/shell32/shell32_En.rc | 8 ++- > dlls/shell32/shell32_Eo.rc | 6 ++- > dlls/shell32/shell32_Es.rc | 6 ++- > dlls/shell32/shell32_Fi.rc | 6 ++- > dlls/shell32/shell32_Fr.rc | 6 ++- > dlls/shell32/shell32_It.rc | 6 ++- > dlls/shell32/shell32_Ko.rc | 6 ++- > dlls/shell32/shell32_No.rc | 6 ++- > dlls/shell32/shell32_Pl.rc | 6 ++- > dlls/shell32/shell32_Pt.rc | 6 ++- > dlls/shell32/shell32_Ru.rc | 6 ++- > dlls/shell32/shell32_Tr.rc | 6 ++- > dlls/shell32/shell32_Uk.rc | 6 ++- > dlls/shell32/shell32_main.h | 3 +- > dlls/shell32/shfldr_unixfs.c | 2 +- > dlls/shell32/shlfileop.c | 128 +++++++++++++++++++++++++++++++--------- > dlls/shell32/shresdef.h | 1 + > dlls/shell32/tests/shlfileop.c | 55 +++++++++++++++++ > 21 files changed, 241 insertions(+), 48 deletions(-) > > diff --git a/dlls/shell32/shell32_Bg.rc b/dlls/shell32/shell32_Bg.rc > index 100b9b6..4c4d16b 100644 > --- a/dlls/shell32/shell32_Bg.rc > +++ b/dlls/shell32/shell32_Bg.rc > @@ -165,8 +165,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEITEM_TEXT "Наистина ли искате да изтриете '%1'?" > IDS_DELETEMULTIPLE_TEXT "Наистина ли искате да изтриете тези %1 елемента?" > IDS_DELETESELECTED_TEXT "Наистина ли искате да изтриете избраните елементи?" > - IDS_OVERWRITEFILE_TEXT "Наистина ли искате да презапишете %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Потвърдете презаписа на файла" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Рестартиране" > diff --git a/dlls/shell32/shell32_Cs.rc b/dlls/shell32/shell32_Cs.rc > index 6451dbb..8790db4 100644 > --- a/dlls/shell32/shell32_Cs.rc > +++ b/dlls/shell32/shell32_Cs.rc > @@ -163,10 +163,14 @@ STRINGTABLE DISCARDABLE > IDS_CREATEFOLDER_CAPTION "Chyba pшi pokusu vytvoшit novэ adresбш" > IDS_DELETEITEM_CAPTION "Potvrdit odstranмnн souboru" > IDS_DELETEFOLDER_CAPTION "Potvrdit odstranмnн adresбшe" > - IDS_OVERWRITEFILE_CAPTION "Potvrdit pшepsбnн souboru" > IDS_DELETEITEM_TEXT "Opravdu chcete odstranit '%1'?" > IDS_DELETEMULTIPLE_TEXT "Opravdu chcete odstranit tмchto %1 poloћek?" > - IDS_OVERWRITEFILE_TEXT "Pшejete si pшepsat soubor '%1'?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > + IDS_OVERWRITEFILE_CAPTION "Potvrdit pшepsбnн souboru" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > } > > /* columns in the shellview */ > diff --git a/dlls/shell32/shell32_De.rc b/dlls/shell32/shell32_De.rc > index bde62bf..d6cb815 100644 > --- a/dlls/shell32/shell32_De.rc > +++ b/dlls/shell32/shell32_De.rc > @@ -173,8 +173,12 @@ STRINGTABLE DISCARDABLE > IDS_TRASHFOLDER_TEXT "Sind Sie sich sicher, dass Sie '%1' und seinen Inhalt in den Mьll verschieben mцchten?" > IDS_TRASHMULTIPLE_TEXT "Sind Sie sich sicher, dass Sie diese %1 Dateien in den Mьll verschieben mцchten?" > IDS_CANTTRASH_TEXT "Das Objekt '%1' kann nicht in den Mьll verschoben werden. Mцchten Sie es stattdessen lцschen?" > - IDS_OVERWRITEFILE_TEXT "Mцchten Sie, dass die Datei '%1' ьberschrieben wird ?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Bestдtigung: Datei ьberschreiben" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Neustarten" > diff --git a/dlls/shell32/shell32_En.rc b/dlls/shell32/shell32_En.rc > index 09530c6..a67cc8a 100644 > --- a/dlls/shell32/shell32_En.rc > +++ b/dlls/shell32/shell32_En.rc > @@ -185,8 +185,12 @@ STRINGTABLE DISCARDABLE > IDS_TRASHFOLDER_TEXT "Are you sure that you want to send '%1' and all it's content to the Trash?" > IDS_TRASHMULTIPLE_TEXT "Are you sure that you want to send these %1 items to the Trash?" > IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?" > - IDS_OVERWRITEFILE_TEXT "OverWrite File %1?" > - IDS_OVERWRITEFILE_CAPTION "Confirm File OverWrite" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > + IDS_OVERWRITEFILE_CAPTION "Confirm file overwrite" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Restart" > diff --git a/dlls/shell32/shell32_Eo.rc b/dlls/shell32/shell32_Eo.rc > index e8fa407..3bfca07 100644 > --- a/dlls/shell32/shell32_Eo.rc > +++ b/dlls/shell32/shell32_Eo.rc > @@ -163,8 +163,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEFOLDER_CAPTION "Konfirmu forigon de dosierujo" > IDS_DELETEITEM_TEXT "Жu vi estas certa pri forigo de '%1'?" > IDS_DELETEMULTIPLE_TEXT "Жu vi estas certa pri forigo de жi tiuj %1 komponantoj?" > - IDS_OVERWRITEFILE_TEXT "Жu vi supreskribas la dosieron %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Konfirmu supreskribiton de dosieron" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > } > > /* columns in the shellview */ > diff --git a/dlls/shell32/shell32_Es.rc b/dlls/shell32/shell32_Es.rc > index dd83a6e..c3d2f4c 100644 > --- a/dlls/shell32/shell32_Es.rc > +++ b/dlls/shell32/shell32_Es.rc > @@ -162,8 +162,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEFOLDER_CAPTION "Confirmar eliminaciуn de carpeta" > IDS_DELETEITEM_TEXT "їSeguro que desea eliminar '%1'?" > IDS_DELETEMULTIPLE_TEXT "їSeguro que desea eliminar estos %1 elementos?" > - IDS_OVERWRITEFILE_TEXT "їSobreescribir el archivo '%1'?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirmar sobreescritura de archivo" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > } > > /* columns in the shellview */ > diff --git a/dlls/shell32/shell32_Fi.rc b/dlls/shell32/shell32_Fi.rc > index e842bbd..e43a94e 100644 > --- a/dlls/shell32/shell32_Fi.rc > +++ b/dlls/shell32/shell32_Fi.rc > @@ -164,8 +164,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEFOLDER_CAPTION "Vahvista kansion tuhoaminen" > IDS_DELETEITEM_TEXT "Haluatko varmasti tuhota '%1':n?" > IDS_DELETEMULTIPLE_TEXT "Haluatko varmasti tuhota nдmд %1?" > - IDS_OVERWRITEFILE_TEXT "Ylikirjoita tiedosto %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Vahvista tiedoston ylikirjoitus" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Kдynnistд uudelleen" > diff --git a/dlls/shell32/shell32_Fr.rc b/dlls/shell32/shell32_Fr.rc > index 043c66c..246045c 100644 > --- a/dlls/shell32/shell32_Fr.rc > +++ b/dlls/shell32/shell32_Fr.rc > @@ -176,8 +176,12 @@ STRINGTABLE DISCARDABLE > IDS_TRASHFOLDER_TEXT "Кtes-vous sыr de vouloir mettre «%1» et tout ce qu'il contient dans la corbeille?" > IDS_TRASHMULTIPLE_TEXT "Кtes-vous sыr de vouloir mettre ces %1 йlйments dans la corbeille?" > IDS_CANTTRASH_TEXT "L'йlйment «%1» ne peut pas кtre mis dans la corbeille. Souhaitez-vous le supprimer а la place?" > - IDS_OVERWRITEFILE_TEXT "Йcraser le fichier %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirmer l'йcrasement du fichier" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Redйmarrer" > diff --git a/dlls/shell32/shell32_It.rc b/dlls/shell32/shell32_It.rc > index 809f44a..19f7339 100644 > --- a/dlls/shell32/shell32_It.rc > +++ b/dlls/shell32/shell32_It.rc > @@ -164,8 +164,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEFOLDER_CAPTION "Confermare la cancellazione della cartella" > IDS_DELETEITEM_TEXT "Sei sicuro di voler cancellare '%1'?" > IDS_DELETEMULTIPLE_TEXT "Sei sicuro di voler cancellare questi %1 elementi?" > - IDS_OVERWRITEFILE_TEXT "Sovrascrivere il File %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confermare la sovrascrizione del File" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Riavvia" > diff --git a/dlls/shell32/shell32_Ko.rc b/dlls/shell32/shell32_Ko.rc > index 413ad7b..bb00f83 100644 > --- a/dlls/shell32/shell32_Ko.rc > +++ b/dlls/shell32/shell32_Ko.rc > @@ -173,8 +173,12 @@ IDS_TRASHITEM_TEXT "ґзЅЕАє '%1' А»(ё¦) ИЮБцЕлАё·О єёі»±вё¦ №Щ¶шґП±о?" > IDS_TRASHFOLDER_TEXT "ґзЅЕАє '%1' °ъ ±Ч ѕИАЗ і»їлА» ИЮБцЕлАё·О єёі»±вё¦ №Щ¶шґП±о?" > IDS_TRASHMULTIPLE_TEXT "ґзЅЕАє '%1' µйА»(ё¦) ИЮБцЕлАё·О єёі»±вё¦ №Щ¶шґП±о?" > IDS_CANTTRASH_TEXT "The item '%1' can't be sent to Trash. Do you want to delete it instead?" > -IDS_OVERWRITEFILE_TEXT "ЖДАП %1А» µ¤ѕоѕІ°ЪЅАґП±о?" > +IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "ЖДАП µ¤ѕоѕІ±в И(r)АО" > +IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "ґЩЅГ ЅГАЫ" > diff --git a/dlls/shell32/shell32_No.rc b/dlls/shell32/shell32_No.rc > index a7ad4f4..c7ec269 100644 > --- a/dlls/shell32/shell32_No.rc > +++ b/dlls/shell32/shell32_No.rc > @@ -172,8 +172,12 @@ STRINGTABLE DISCARDABLE > IDS_TRASHFOLDER_TEXT "Virkelig legge «%1» og alt innholdet i papirkurven?" > IDS_TRASHMULTIPLE_TEXT "Virkelig legge disse %1 valgte elementene i papirkurven?" > IDS_CANTTRASH_TEXT "Elementet «%1» kan ikke legges i papirkurven. Vil du slette det i stedet?" > - IDS_OVERWRITEFILE_TEXT "Overskrive filen «%1»?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Bekreft overskriving av fil" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Starte pе nytt" > diff --git a/dlls/shell32/shell32_Pl.rc b/dlls/shell32/shell32_Pl.rc > index 60b6a75..d6139e7 100644 > --- a/dlls/shell32/shell32_Pl.rc > +++ b/dlls/shell32/shell32_Pl.rc > @@ -173,8 +173,12 @@ STRINGTABLE DISCARDABLE > IDS_TRASHFOLDER_TEXT "Czy jesteњ pewien, їe chcesz umieњciж folder '%1' i caі№ jego zawartoњж w koszu" > IDS_TRASHMULTIPLE_TEXT "Elementуw: %1 - czy na pewno chcesz je umieњciж w Koszu?" > IDS_CANTTRASH_TEXT "Nie mogк przenieњж elementu '%1' do Kosza. Czy chcesz go zamiast tego usun№ж?" > - IDS_OVERWRITEFILE_TEXT "Zast№piж plik %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Potwierdџ zast№pienie pliku" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Uruchom ponownie" > diff --git a/dlls/shell32/shell32_Pt.rc b/dlls/shell32/shell32_Pt.rc > index 1826162..0a6a274 100644 > --- a/dlls/shell32/shell32_Pt.rc > +++ b/dlls/shell32/shell32_Pt.rc > @@ -256,8 +256,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEFOLDER_CAPTION "Confirmar exclusгo de pasta" > IDS_DELETEITEM_TEXT "Vocк tem certeza que deseja excluir '%1'?" > IDS_DELETEMULTIPLE_TEXT "Vocк tem certeza que deseja excluir estes %1 itens?" > - IDS_OVERWRITEFILE_TEXT "Sobreescrever arquivo %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Confirmar sobreescrever arquivo" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Reiniciar" > diff --git a/dlls/shell32/shell32_Ru.rc b/dlls/shell32/shell32_Ru.rc > index a3c5da8..65fa824 100644 > --- a/dlls/shell32/shell32_Ru.rc > +++ b/dlls/shell32/shell32_Ru.rc > @@ -165,8 +165,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEFOLDER_CAPTION "Подтверждение удаления папки" > IDS_DELETEITEM_TEXT "Удалить '%1'?" > IDS_DELETEMULTIPLE_TEXT "Удалить эти обьекты (%1?" > - IDS_OVERWRITEFILE_TEXT "Заменить файл(ы) %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Подтверждение замены файла" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Перезагрузить" > diff --git a/dlls/shell32/shell32_Tr.rc b/dlls/shell32/shell32_Tr.rc > index b41be53..197562c 100644 > --- a/dlls/shell32/shell32_Tr.rc > +++ b/dlls/shell32/shell32_Tr.rc > @@ -172,8 +172,12 @@ STRINGTABLE DISCARDABLE > IDS_TRASHFOLDER_TEXT "'%1' adlэ црeyi ve tьm iзeriрini зцpe gцndermek istediрinizden emin misiniz?" > IDS_TRASHMULTIPLE_TEXT "Bu %1 црeyi зцpe gцndermek istediрinizden emin misiniz?" > IDS_CANTTRASH_TEXT "'%1' adlэ црe зцpe gцnderilemiyor. Tamamen silmek ister misiniz?" > - IDS_OVERWRITEFILE_TEXT "%1 dosyasэnэn ьzerine yazmak istiyor musunuz?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Dosya Ьzerine Yazmayэ Onayla" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > > /* message box strings */ > IDS_RESTART_TITLE "Yeniden Baюlat" > diff --git a/dlls/shell32/shell32_Uk.rc b/dlls/shell32/shell32_Uk.rc > index c535ba9..a4cf564 100644 > --- a/dlls/shell32/shell32_Uk.rc > +++ b/dlls/shell32/shell32_Uk.rc > @@ -161,8 +161,12 @@ STRINGTABLE DISCARDABLE > IDS_DELETEFOLDER_CAPTION "Підтвердження вилучення теки" > IDS_DELETEITEM_TEXT "Ви впевнені, що хочете вилучити '%1'?" > IDS_DELETEMULTIPLE_TEXT "Ви впевнені, що хочете вилучити ці %1 елементи(ів)?" > - IDS_OVERWRITEFILE_TEXT "Переписати Файл %1?" > + IDS_OVERWRITEFILE_TEXT "This folder already contains a file called '%1'.\n\nDo you want to replace it?" > IDS_OVERWRITEFILE_CAPTION "Підтвердження Перезапису Файлу" > + IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > + "If the files in the destination folder have the same names as files in the\n"\ > + "selected folder they will be replaced. Do you still want to move or copy\n"\ > + "the folder?" > } > > /* columns in the shellview */ > diff --git a/dlls/shell32/shell32_main.h b/dlls/shell32/shell32_main.h > index a17eec4..2937065 100644 > --- a/dlls/shell32/shell32_main.h > +++ b/dlls/shell32/shell32_main.h > @@ -153,9 +153,10 @@ void FreeChangeNotifications(void); > #define ASK_TRASH_FOLDER 8 > #define ASK_TRASH_MULTIPLE_ITEM 9 > #define ASK_CANT_TRASH_ITEM 10 > +#define ASK_OVERWRITE_FOLDER 11 > > BOOL SHELL_DeleteDirectoryW(HWND hwnd, LPCWSTR pwszDir, BOOL bShowUI); > -BOOL SHELL_ConfirmDialogW(HWND hWnd, int nKindOfDialog, LPCWSTR szDir); > +BOOL SHELL_ConfirmYesNoW(HWND hWnd, int nKindOfDialog, LPCWSTR szDir); > > /* 16-bit functions */ > void WINAPI DragAcceptFiles16(HWND16 hWnd, BOOL16 b); > diff --git a/dlls/shell32/shfldr_unixfs.c b/dlls/shell32/shfldr_unixfs.c > index 4668afe..a4f4ade 100644 > --- a/dlls/shell32/shfldr_unixfs.c > +++ b/dlls/shell32/shfldr_unixfs.c > @@ -1829,7 +1829,7 @@ static HRESULT UNIXFS_delete_with_syscalls(UnixFolder *This, UINT cidl, LPCITEMI > static const WCHAR empty[] = {0}; > int i; > > - if (!SHELL_ConfirmDialogW(GetActiveWindow(), ASK_DELETE_SELECTED, empty)) > + if (!SHELL_ConfirmYesNoW(GetActiveWindow(), ASK_DELETE_SELECTED, empty)) > return S_OK; > > lstrcpyA(szAbsolute, This->m_pszPath); > diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c > index d1ea475..b245e00 100644 > --- a/dlls/shell32/shlfileop.c > +++ b/dlls/shell32/shlfileop.c > @@ -27,6 +27,7 @@ > #include <stdarg.h> > #include <string.h> > #include <ctype.h> > +#include <assert.h> > > #include "windef.h" > #include "winbase.h" > @@ -65,6 +66,14 @@ static DWORD SHNotifyMoveFileW(LPCWSTR src, LPCWSTR dest); > static DWORD SHNotifyCopyFileW(LPCWSTR src, LPCWSTR dest, BOOL bFailIfExists); > static DWORD SHFindAttrW(LPCWSTR pName, BOOL fileOnly); > > +typedef struct > +{ > + SHFILEOPSTRUCTW *req; > + DWORD dwYesToAllMask; > + BOOL bManyItems; > + BOOL bCancelled; > +} FILE_OPERATION; > + > /* Confirm dialogs with an optional "Yes To All" as used in file operations confirmations > */ > static const WCHAR CONFIRM_MSG_PROP[] = {'W','I','N','E','_','C','O','N','F','I','R','M','E',0}; > @@ -250,22 +259,32 @@ static BOOL SHELL_ConfirmIDs(int nKindOfDialog, SHELL_ConfirmIDstruc *ids) > ids->icon_resource_id = IDI_WARNING; > ids->caption_resource_id = IDS_OVERWRITEFILE_CAPTION; > ids->text_resource_id = IDS_OVERWRITEFILE_TEXT; > - return TRUE; > + return TRUE; > + case ASK_OVERWRITE_FOLDER: > + ids->hIconInstance = NULL; > + ids->icon_resource_id = IDI_WARNING; > + ids->caption_resource_id = IDS_OVERWRITEFILE_CAPTION; > + ids->text_resource_id = IDS_OVERWRITEFOLDER_TEXT; > + return TRUE; > default: > FIXME(" Unhandled nKindOfDialog %d stub\n", nKindOfDialog); > } > return FALSE; > } > > -BOOL SHELL_ConfirmDialogW(HWND hWnd, int nKindOfDialog, LPCWSTR szDir) > +static BOOL SHELL_ConfirmDialogW(HWND hWnd, int nKindOfDialog, LPCWSTR szDir, FILE_OPERATION *op) > { > WCHAR szCaption[255], szText[255], szBuffer[MAX_PATH + 256]; > SHELL_ConfirmIDstruc ids; > DWORD_PTR args[1]; > HICON hIcon; > + int ret; > > - if (!SHELL_ConfirmIDs(nKindOfDialog, &ids)) > - return FALSE; > + assert(nKindOfDialog >= 0 && nKindOfDialog < 32); > + if (op && (op->dwYesToAllMask & (1 << nKindOfDialog))) > + return IDYES; > + > + assert(SHELL_ConfirmIDs(nKindOfDialog, &ids)); > > LoadStringW(shell32_hInstance, ids.caption_resource_id, szCaption, sizeof(szCaption)/sizeof(WCHAR)); > LoadStringW(shell32_hInstance, ids.text_resource_id, szText, sizeof(szText)/sizeof(WCHAR)); > @@ -275,7 +294,23 @@ BOOL SHELL_ConfirmDialogW(HWND hWnd, int nKindOfDialog, LPCWSTR szDir) > szText, 0, 0, szBuffer, sizeof(szBuffer), (va_list*)args); > hIcon = LoadIconW(ids.hIconInstance, (LPWSTR)MAKEINTRESOURCE(ids.icon_resource_id)); > > - return (IDYES == SHELL_ConfirmMsgBox(hWnd, szBuffer, szCaption, hIcon, FALSE)); > + ret = SHELL_ConfirmMsgBox(hWnd, szBuffer, szCaption, hIcon, op && op->bManyItems); > + if (op) { > + if (ret == IDD_YESTOALL) { > + op->dwYesToAllMask |= (1 << nKindOfDialog); > + ret = IDYES; > + } > + if (ret == IDCANCEL) > + op->bCancelled = TRUE; > + if (ret != IDYES) > + op->req->fAnyOperationsAborted = TRUE; > + } > + return ret == IDYES; > +} > You need to conform to the style of the rest of the file, e.g., if (IsAttribDir(entryToCopy->attributes) && bCancelIfAnyDirectories) return ERROR_CANCELLED; create_dest_dirs(fileDest->szDirectory); if (!lstrcmpiW(entryToCopy->szFullPath, fileDest->szFullPath)) { if (IsAttribFile(entryToCopy->attributes)) return ERROR_NO_MORE_SEARCH_HANDLES; else return ERROR_SUCCESS; } 4 space indentation, empty lines between logical pieces of code, brackets underneath. -- James Hawkins

1 0

Bugzilla: Adding a 'patch' keyword
by Francois Gouget 09 Feb '07

09 Feb '07

During a query I've stumbled on bug 5012 which happens to have a patch attached to it. Nine months ago it was suggested to the author to send this patch to wine-patches but either he didn't do it or it was not accepted. Now, I don't consider myself qualified to judge the patch and I have no particular interest in it. So I may not send it to wine-patches myself. But it would be nice if there was an easy way to find bugs that have a patch, even, and maybe especially, if it is incorrect. This would make it easier for interested parties to survey what potential fixes are languishing in Bugzilla and push them to wine-devel or wine-patches. And it would also give a starting point for someone interested in taking an existing patch that did not get committed to then update it, clean it up, and fix it to make it acceptable. Does that make sense? And for reference: * Missing NOVST timezone http://bugs.winehq.org/show_bug.cgi?id=5012 (in fact the timezone data seems wrong) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Indifference will certainly be the downfall of mankind, but who cares?

4 5

re: comctl32: rebar: rewrite the layouting code
by Dan Kegel 09 Feb '07

09 Feb '07

Mikołaj wrote: >I've tested it also with WinRAR, WinSCP3 3.30, 7-Zip and Pirch98 (the >last two have Bugzilla entries and are fixed by the new code). The only >thing I've found not to work are the sidebars of IE. Did they work with the old code? > For the next week I won't work on wine but what should I do later - > would such a big patch be accepted? As long as it doesn't cause regressions in IE, probably, though adding more conformance tests would make acceptance more likely. I think everyone would be thrilled to see progress in rebar, especially if the code ends up simpler. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: shell32[2/3]: add a confirmation dialog with a "Yes to All" option
by Robert Shearman 09 Feb '07

09 Feb '07

Mikołaj Zalewski wrote: > +SHELL_YESTOALL_MSGBOX DIALOG 200, 100, 280, 90 > +STYLE DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU > +CAPTION "Message" > +FONT 8, "MS Shell Dlg" > +{ > + DEFPUSHBUTTON "&Yes", IDYES, 34, 69, 53, 14, WS_GROUP | WS_TABSTOP > + PUSHBUTTON "Yes to &all", IDD_YESTOALL, 92, 69, 65, 14, WS_GROUP | WS_TABSTOP > + PUSHBUTTON "&No", IDNO, 162, 69, 53, 14, WS_GROUP | WS_TABSTOP > + PUSHBUTTON "&Cancel", IDCANCEL, 220, 69, 53, 14, WS_GROUP | WS_TABSTOP > + ICON "", IDD_ICON, 10, 10, 16, 16 > + LTEXT "", IDD_MESSAGE, 40, 10, 238, 52, 0 > +} > + > The usual convention is that IDD_* are used for IDs of dialogs and IDC_* are used for IDs of controls. -- Rob Shearman

2 1

RasError.h? Where is this or does it not exist?
by John Smith 09 Feb '07

09 Feb '07

Hey all, I cannot find the raserror.h file. I have tried looking around the wine directories to no avail. A find ./wine -name raserror.h -type f -print turns up nothing. Am I looking in the wrong spot or in the wrong way? I really want to think that the file isn't there but I can't rule out that I'm not somewhat stupid =P. So I appeal to you such wise guys as you are. Sorry for the dumb question, I just would hate to make the file if it already exists somewhere. Regards, John Klehm

2 2

Some thoughts about the ominous DIB Engine
by Rolf Kalbermatter 09 Feb '07

09 Feb '07

I have been following this discussion for quite some time and finally decided to look into it a little bit. While the Wiki mentions that a difficult part of this would be to get any design accepted by Alexandre it does absolutely not say in any way what kind of approach would be likely to be accepted, other than it needs to be in small incremental steps. I must admit that I haven't entirely looked through the whole Wine tree yet so I might be missing something but from the old Transgaming patch and some investigation into GDI32 I would see two principal aproaches to add such an interface to Wine. 1) Like in the Transgaming patch hook into winex11.drv where apropriate. 2) Add the dib engine as a dibdrv into GDI32 directly similar to what has been done for enhmfdrv and mfdrv already. Obviously 1) has been tried and seemed to work in some ways eventhough there would still need to be quite some more work to be done. What I don't like about this aproach is that conceptually it seems to add this functionality at the wrong end. If there is ever going to be another display driver than winex11.drv all the hooking would have to be done again and also adding new GDI methods to the driver as development goes always requires also some significant changes to winex11.drv. Not sure if someone ever attempted 2) but IMHO it would place DIB handling where it conceptually should be. The dibdrv function array could be added as extra field to the private DIB data structure and initialized on DIB creation. On non existing DIB methods (NULL pointer) the operation would be simply sent to the display driver as is done now. I believe this could be generalized enough to make it a single time change, with new dibdrv methods getting then available whenever implemented in small incremental patches. Possible problems I could see are however synchronizing with X (not sure if that is really a possible problem as I do not understand X so far) and maybe other drivers such as wine3d3.drv that seem to hook into winex11.drv too (not sure if for DIB related operations). This last one could however be gotten around by implementing the dibdrv as loadable driver too, so that other drivers needing to use operations from it could load it too. I would like to hear comments of anyone that could add something to this and maybe we can then add the result to the wiki page for further reference. As it is now Wiki mostly says it is rather desirable, sort of hard to do and the hardest part would be getting it into Wine at all. Maybe if there is a more clear picture as to how it could be done and what is likely to have a chance to pass Alexandre's critical eyes, there would be a bigger chance of someone trying to get it finally started the right way. Rolf Kalbermatter

6 6

Re: comctl32: rebar: rewrite the layouting code
by Robert Shearman 09 Feb '07

09 Feb '07

Mikołaj Zalewski wrote: > I've been trying to fix the rebar layouting code. But fixes in one > place caused regressions because of bugs in other places and I ended > up rewriting the whole layouting code. It does roughly the same as the > current code however the details are quite different and I hope more > correct. It's also much shorter so it should be earier to > understand/debug. My code work for me for all apps I tested (except > for the sidebars of IE but I'm trying to find out why). It also passes > some tests I've written and produces identical results that the > native. Two things could be potentially better in the old code: > - it contains some support for RBBS_FIXEDSIZE (however different from > what Windows does) > - it can break rows to fill the given space (but that should be only > done for RBS_AUTOSIZE rebars) > > I have yet to test the REBAR_Maximize and REBAR_Minimize but I have > two questions. Does this code cause regressions in apps that works > with the current code and would such big patch be accepted? I haven't got any apps to test with (other than IE and it looks like you've already tried that), but nice work! -- Rob Shearman

2 1

Re: shell32: make sure BrowseForFolder doesn't return NULL for the Desktop folder as this means a cancel (should fix bug #5533)
by Robert Shearman 09 Feb '07

09 Feb '07

Mikołaj Zalewski wrote: > +/************************************************************************* > + * _ILMakePidlNotNull > + * > + * A null pidl is a valid pidl that represents the Desktop. However if we don't > + * want a NULL pidl (e.g. because NULL indicates an error) this function will > + * make an explicit empty pidl if the parameter is NULL. > + */ > +HRESULT _ILMakePidlNotNull(LPITEMIDLIST *pidl) > +{ > + if (*pidl == NULL) > + *pidl = _ILCreateDesktop(); > + if (*pidl == NULL) > + return E_OUTOFMEMORY; > + return S_OK; > +} > This function is a bit ugly. It seems this policy should be made in the BrsFolder_OnCommand function, rather than in pidl.c as a file. -- Rob Shearman

2 1

Re: ntdll: Add prototypes to winnt.h for the SList functions.
by Alexandre Julliard 09 Feb '07

09 Feb '07

Francois Gouget <fgouget(a)free.fr> writes: > Fix the implementation to match the official prototypes. > --- > > I've had trouble with the placement of 'volatile' in 'const > SLIST_HEADER* volatile'. I think putting 'volatile' last is correct > because it applies to the pointer, not to the pointed-to data like > 'const'. No, it applies to the data, it doesn't make sense to have the pointer itself be volatile. Though it's probably useless either way, and since the SDK prototypes apparently don't have it we shouldn't either. -- Alexandre Julliard julliard(a)winehq.org

1 0

Questions about gdi32:WidenPath patch sent on jan. 27
by Laurent Vromman 09 Feb '07

09 Feb '07

Hi, I've tried to send my first patch on jan. 27. This patch is supposed to add a partial implementation of WidenPath to gdi32.dll. After two weeks, I don't have any news about the patch. Is it still pending ? Is there something wrong with it ? I am ready to improve it if necessary, but I need some advice to now what needs to be improved in it. Thank you for your help. Laurent

1 0

Re: [1/9] WineD3D: BeginScene and EndScene tests and fixes
by Alexandre Julliard 09 Feb '07

09 Feb '07

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From 4dc1b3cd7faf9c61bc6f862f416b6af07e1e85e8 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 19 Jan 2007 19:30:09 +0100 > Subject: [PATCH] WineD3D: BeginScene and EndScene tests and fixes This causes 'make test' to fail to restore the correct display resolution, it's stuck at 800x600 on exit. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winegcc: sign-compare fixes
by Joris Huizer 09 Feb '07

09 Feb '07

I believe this one causes problems -- please do not commit yet Joris Huizer <joris_huizer(a)yahoo.com> wrote: --------------------------------- Need Mail bonding? Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users.>From 8686a200bd1f1cbd934d761013c487a9ddc195c9 Mon Sep 17 00:00:00 2001 From: Joris Huizer Date: Wed, 7 Feb 2007 15:19:25 +0100 Subject: [PATCH] winegcc sign-compare fixes To: wine-patches --- tools/winegcc/utils.c | 13 +++++++------ tools/winegcc/winegcc.c | 11 ++++++----- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/tools/winegcc/utils.c b/tools/winegcc/utils.c index 1af91e9..c144077 100644 --- a/tools/winegcc/utils.c +++ b/tools/winegcc/utils.c @@ -120,14 +120,14 @@ void strarray_add(strarray* arr, const c void strarray_del(strarray* arr, int i) { - if (i < 0 || i >= arr->size) error("Invalid index i=%d", i); + if (i < 0 || (unsigned int)i >= arr->size) error("Invalid index i=%d", i); memmove(&arr->base[i], &arr->base[i + 1], (arr->size - i - 1) * sizeof(arr->base[0])); arr->size--; } void strarray_addall(strarray* arr, const strarray* from) { - int i; + unsigned int i; for (i = 0; i < from->size; i++) strarray_add(arr, from->base[i]); @@ -136,7 +136,7 @@ void strarray_addall(strarray* arr, cons strarray* strarray_dup(const strarray* arr) { strarray* dup = strarray_alloc(); - int i; + unsigned int i; for (i = 0; i < arr->size; i++) strarray_add(dup, arr->base[i]); @@ -160,7 +160,7 @@ strarray* strarray_fromstring(const char char* strarray_tostring(const strarray* arr, const char* sep) { char *str, *newstr; - int i; + unsigned int i; str = strmake("%s", arr->base[0]); for (i = 1; i < arr->size; i++) @@ -277,7 +277,7 @@ static file_type guess_lib_type(const ch file_type get_lib_type(strarray* path, const char* library, char** file) { - int i; + unsigned int i; for (i = 0; i < path->size; i++) { @@ -289,7 +289,8 @@ file_type get_lib_type(strarray* path, c void spawn(const strarray* prefix, const strarray* args, int ignore_errors) { - int i, status; + unsigned int i; + int status; strarray* arr = strarray_dup(args); const char** argv; char* prog = 0; diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index f1aa87e..f1a7bb0 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -170,7 +170,7 @@ struct options static void clean_temp_files(void) { - int i; + unsigned int i; if (keep_generated) return; @@ -239,7 +239,8 @@ static const strarray* get_translator(en static void compile(struct options* opts, const char* lang) { strarray* comp_args = strarray_alloc(); - int j, gcc_defs = 0; + unsigned int j; + int gcc_defs = 0; switch(opts->processor) { @@ -434,7 +435,7 @@ static void build(struct options* opts) const char *output_name, *spec_file, *lang; const char* winebuild = getenv("WINEBUILD"); int generate_app_loader = 1; - int j; + unsigned int j; /* NOTE: for the files array we'll use the following convention: * -axxx: xxx is an archive (.a) @@ -719,7 +720,7 @@ static int is_linker_arg(const char* arg "-static", "-static-libgcc", "-shared", "-shared-libgcc", "-symbolic", "-framework" }; - int j; + unsigned int j; switch (arg[1]) { @@ -769,7 +770,7 @@ static int is_mingw_arg(const char* arg) { "-mno-cygwin", "-mwindows", "-mconsole", "-mthreads", "-municode" }; - int j; + unsigned int j; for (j = 0; j < sizeof(mingw_switches)/sizeof(mingw_switches[0]); j++) if (strcmp(mingw_switches[j], arg) == 0) return 1; -- 1.4.4 --------------------------------- Need a quick answer? Get one in minutes from people who know. Ask your question on Yahoo! Answers.

2 4

Re: comctl32: datetime: initial tests for date and time picker
by Mike McCormack 09 Feb '07

09 Feb '07

Kanit Therdsteerasukdi wrote: > I'm a student at UCLA taking CS130: Software Engineering. For CS130, we > are writing conformance tests for Common Controls (comctl32). I will be > working on the Date and Time Picker. Attached is an initial test, > testing the getters and setters. Looks like good work. > +#include <stdio.h> This is possibly not needed. > +static HINSTANCE g_hinst; You should be able to use NULL instead of the hinst when creating the window, which would eliminate the need for g_hinst. > + assert(hWndDateTime!=NULL); > + return hWndDateTime; Maybe it would be nicer to check hWndDateTime with an ok() macro in test_datetime_control() then use skip() if it's NULL. This way the test will fail without crashing in the case that Window creation fails, for example, when there's no X display available. When tests crash, make doesn't detect that they failed. > + return; > +} The return is redundant, and probably better off removed. > + r = SendMessage(hWndDateTime, DTM_SETRANGE, GDTR_MIN | GDTR_MAX, (LPARAM)st); > + ok(r != 0, "Expected nonzero, got %ld\n", r); MSDN does say "returns nonzero if successful", but it's probably better to check the exact value that it does return, in case there's a program out there that does the same. ie. ok(r == 1, "Expected nonzero, got %ld\n", r); Mike

1 0

DirectDrawRenderer=opengl - screen size changeable for final rendering?
by Christoph Frick 08 Feb '07

08 Feb '07

hiho what i ever wondered but never dared to ask: i tried recently the said key with jagged alliance 2. as the game has quite a low resolution 640 or 800 it would be nice to allow higher resolutions when rendering ddraw with opengl (e.g. game wants 800 but for the final rendering use 1600). is this doable via registry or somewhere else? for the files: i run the apps in desktop-mode. -- cu

2 3

Re: [2] wineshelllink: Keep using the slash as path separator.
by Vitaliy Margolen 08 Feb '07

08 Feb '07

Hans Leidekker wrote: > Fixes incorrect handling of paths with dashes. > And creates invalid menu entries. Did you test this patch with multi-level menu structure? When I tried your patch it created all menu entries in the top level menu, with the name like: wine-Programs-Ubi Soft-IL-2 Sturmovik Demo Instead of being a menu: wine Programs Ubi Soft IL-2 Sturmovik Demo Last one is the way it should be but now it's 2 menus: IL 2 Sturmovik Demo Vitaliy.

2 2

winealsa commit d2f29311caa8041bd992a3867d71d6311c7ff8fa
by Marcus Meissner 08 Feb '07

08 Feb '07

Hi Marten, Your commit: http://source.winehq.org/git/wine.git/?a=commit;h=d2f29311caa8041bd992a3867… Has some regressions on Coverity. Namely Coverity complains that "areas" is used uninitializied. And yes it is: static DWORD CALLBACK DBSB_MMAPLoop(LPVOID data) { IDsDriverBufferImpl* pdbi = (IDsDriverBufferImpl*)data; WINE_WAVEDEV *wwo = &(WOutDev[pdbi->drv->wDevID]); snd_pcm_uframes_t frames, wanted, ofs; const snd_pcm_channel_area_t *areas; int state = WINE_WS_STOPPED; snd_pcm_state_t alsastate; TRACE_(waveloop)("0x%8p\n", data); TRACE("0x%8p, framelength: %lu, area: %8p\n", data, pdbi->mmap_buflen_frames, pdbi->mmap_areas); if (areas != pdbi->mmap_areas || areas->addr != pdbi->mmap_areas->addr) FIXME("Can't access sound driver's buffer directly.\n"); Please fix :) Ciao, Marcus

1 0

How to find rendering code
by Markus 08 Feb '07

08 Feb '07

Hi, I am new to Wine development and wanted to ask on the list, whether someone could point me to the correct place where the code for issues 3 and 4 in http://bugs.winehq.org/show_bug.cgi?id=7273 might be located. It looks like the solution could be rather straightforward to implement but I have no idea how to find the respective rendering method. Any help would be greatly appreciated. Thanks. -- Markus

2 1

RedHat rpms
by Bill Medland 08 Feb '07

08 Feb '07

Just checking I'm looking to see if there are rpms being built for Red Hate Enterprise Linux 3 these days. I see that the Red Hat rpms nowadays are for fc. but they aren't suitable for RHEL3 The download page says that the RedHat/Fedora area is for RedAht 8,9 and fedora, but I don't see any RedHat 8 or 9 there. Are they not there or am I looking in the wrong place? -- Bill Medland

2 1

Re: [GDI32] Fix for GetTextExtentExPointW() and ExtTextOutW() - Fixes Bug 50
by John Smith 08 Feb '07

08 Feb '07

Hey Pedro, Was there supposed to be an attachment on your last message? I didn't see one. Regards, John Klehm On 2/8/07, Pedro Araujo Chaves Jr. <inckie(a)gmail.com> wrote: > > Attached is my proposed patch for Bug #50; the test case was attached > in my previous message. > -- > Patch description: > > This patch fixes Wine's Bug #50: "PrgWin95: Text justification needs > beefing up". > > What it does: first, it takes in consideration that not always the > number of extra pixels will be a multiple of the number of break > characters in a given extent of a given string that should be > justified, and so the integer division of extra by breaks in > SetTextJustification() is likely to leave a remainder (which the > latter function addresses, of course, but ExtTextOutW() seems to > overlook — that's the reason for the changes at lines 1788 (breakRem), > and 1901 and 1922 (dc->breakExtra || breakRem), which prevent some > lines from being ignored in the justification). > > That fixed, if there remained any pixels indeed, their number > shouldn't be greater than dc->breakCount; then the first breakRem > break characters in that given extent are widened by one pixel (lines > 1925-1929 added). > > GetTextExtentExPointW() is also fixed so that it now returns the > expected width of the text when it is to be justified. This has the > good side effect that TabbedTextOut() now also returns the proper > width when called after SetTextJustification(). What the patch does > here is that GetTextExtentExPointW() now calculates the extra width > only when (breakExtra || breakRem) resolves TRUE , and corrects the > extra space additions by applying them only to break characters. What > was broken before is that it always added extra space, regardless of > whether it was measuring a single character or a full string, or > whether it was a break character or not. (Lines added: 1191, 1199, > 1227, 1229, 1236-1245, 1254-1268). > > This patch is copyrighted by Banco do Brasil under the LGPL. > > -- > Regards, > Pedro Araújo. > > >

1 0

Re: advapi32: sign-compare fixes
by Vitaliy Margolen 08 Feb '07

08 Feb '07

Joris Huizer wrote: > - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, > + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, This isn't right. WideCharToMultiByte returns INT, which is signed. > @@ -1995,11 +1995,11 @@ LookupAccountSidW( > > if (dm) { > BOOL status = TRUE; > - if (*accountSize > lstrlenW(ac)) { > + if (*accountSize > (unsigned)lstrlenW(ac)) { > if (account) > lstrcpyW(account, ac); > } > - if (*domainSize > lstrlenW(dm)) { > + if (*domainSize > (unsigned)lstrlenW(dm)) { > if (domain) > lstrcpyW(domain, dm); > } This isn't correct either. lstrlenW() also returns INT and you can't just cast it to (unsigned). Unsigned what? int/long/dword? Vitaliy.

3 2

Re: [PATCH] coverity: CID35: fixed wrong condition
by Felix Nawothnig 08 Feb '07

08 Feb '07

Marcus Meissner wrote: > - if(nRelPos>=0) { /* if this or preceding row */ > + if(nRelPos<=0) { /* if this or preceding row */ > while(nRelPos<=0) { Shouldn't that become a "do { ... } while()" then?

2 3

IE Dev Toolbar now compatible!
by Darryl Dixon 08 Feb '07

08 Feb '07

Hi All, Just a brief to let you know that it looks like Microsoft is finally taking compatability seriously ;) - the new Beta 3 version of the IE Developers Toolbar (http://www.microsoft.com/downloads/details.aspx?FamilyID=e59c3964-672d-4511…) improves on the previous Beta release by installing and working correctly with wine 0.9.30 with an IE6 'ies4linux' install. In the previous Beta, the 'View DOM' button did not work in wine 0.9.30 - this new version fixes that and adds lots of enhancements. I don't know if this is useful to many here, but it sure is for me, so I thought I'd share. Nice to see Microsoft improving their software to work better with Wine for once (even though I'm sure it's unintentional ;). Keep up the good work, guys. regards, Darryl Dixon Winterhouse Consulting Ltd http://www.winterhouseconsulting.com

1 0

Re: ole32: Remove casts
by Robert Shearman 08 Feb '07

08 Feb '07

Mike McCormack wrote: > --- > This is the way ref counting is done everywhere else in Wine. > > Ref counts can be assumed to be between 0 and MAXLONG, so the fact > that LONG is signed isn't important. NO. The DCOM spec says that STDOBJREF::cPublicRefs is unsigned, therefore the ref counts can be assumed to be up to MAXULONG. Therefore, this change is incorrect and it would lead to subtle signedness errors. > > Casting ULONG* to LONG* to solve the above problem is unnecessary. > -- Rob Shearman

2 1

Re: msi: Make MsiInstallProduct conformance test depend on proper UI level processing.
by James Hawkins 08 Feb '07

08 Feb '07

On 2/7/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > Hi, here is my proposed patch to the current msi MsiInstallProduct > consistency test that will make it's success depend on proper process of > UI flags (as well as everything else it depends on to make a successful > install). It seems to me like this is the simplest way to add this test > (it is only 5-6 lines added total), and it seems fair to me to add it to > this existing test for two reasons: > 1. The test is already testing a full product install (installs files, > services, registry values, etc) and my modification will simply result > in either no modification to these actions if UI level processing is > good or complete failure if it is bad, which will make the problem very > easy to diagnose. > 2. Looking through instructions on msdn it seems that there isn't a > kosher way to make a very simple MSI file that just, say, writes a > registry value (without doing costing, install validation, having a full > features table, installing some features, etc.) which would make a > separate function easy to implement and it does not really seem > necessary to copy and paste the whole test_MsiInstallProduct (or > similar) function just to check UI level processing. > > Changelog: > > * msi: Make MsiInstallProduct conformance test depend on proper UI > level processing. > You need to put whatever you're trying to test into a new test function. As-is, it's not clear what you're testing and we need to keep the tests logically separate. Test both a success and a failure case, plus all the in between cases. > If the full UI is started (incorrectly) > + * the InstallUISequence table will be used, and the install will fail. If the full UI is > + * not started (correctly) the InstallExecuteSequence table will be used. Why does the install fail if we run the InstallUISequence action?. Also, InstallExecuteSequence runs no matter what so this comment would need to be fixed. -- James Hawkins

2 10

Re: winedump: sign-compare fixes
by Dmitry Timoshkov 08 Feb '07

08 Feb '07

"Joris Huizer" <joris_huizer(a)yahoo.com> wrote: > -static const MINIDUMP_DIRECTORY* get_mdmp_dir(const MINIDUMP_HEADER* hdr, int str_idx) > +static const MINIDUMP_DIRECTORY* get_mdmp_dir(const MINIDUMP_HEADER* hdr,unsigned long int str_idx) Please keep white space unchanged. > - while (ptr - (const unsigned char*)table < len) > + while ((unsigned long)(ptr - (const unsigned char*)table) < len) > - int i, length; > + unsigned long int i, length; > - while (file - (const char*)symbols < sizeof(PDB_SYMBOLS) + symbols->module_size) > + while ((unsigned long int)(file - (const char*)symbols) < sizeof(PDB_SYMBOLS) + symbols->module_size) Your changes are inconsistent: sometimes you change 'int' to 'unsigned long int', sometimes to 'unsigned long'. Why not change 'int' simply to 'unsigned'? -- Dmitry.

2 1

Undoc. comctl32 mem management functions
by Felix Nawothnig 07 Feb '07

07 Feb '07

Hi. comctl32 exports (undocumented) Alloc() and friends which call LocalAlloc => GlobalAlloc => HeapAlloc since it's doesn't use any fancy LMEM / GMEM flags... so shouldn't Alloc() call HeapAlloc() directly? If Global/Local* behave different than Heap* on Windows - wouldn't it then be desirable to replace the Alloc()/etc. calls in our comctl32 (we use it all over the place) by Heap*? Reason I'm asking: Since it's not documented the Free(NULL) semantics are not clear (although it's safe in our implementation) - and I'm wondering if we really want to internally use undocumented functions with unclear semantics when there is an easy (documented) way. And besides - the comctl32 code is full of "if(p) Free(p);"... Felix

3 2

Re: [PATCH 3/6] oleaut32: Comment out "dual" attribute of IKindaEnumWidget in tmarshal test to cause the interface to be marshaled correctly.
by Alexandre Julliard 07 Feb '07

07 Feb '07

Robert Shearman <rob(a)codeweavers.com> writes: > This fixes a bunch of tmarshal tests. It doesn't seem to make any difference for me: ../../../tools/runtest -q -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so tmarshal.c && touch tmarshal.ok tmarshal.c:139: Test failed: CoMarshalInterface failed with error 0x80040155 tmarshal.c:765: Test failed: CoUnmarshalInterface failed with error 0x80040155 tmarshal.c:784: Test failed: EXCEPINFO differs from expected: wCode = 0x2, scode = 0x7bc7a2c8 tmarshal.c:803: Test failed: EXCEPINFO differs from expected: wCode = 0x2, scode = 0x7bc7a2c8 tmarshal.c:915: Test failed: EXCEPINFO differs from expected: wCode = 0x2, scode = 0x7bc7a2c8 tmarshal.c:942: Test failed: EXCEPINFO differs from expected: wCode = 0x2, scode = 0x7bc7a2c8 tmarshal.c:977: Test failed: EXCEPINFO differs from expected: wCode = 0x2, scode = 0x80004001 make: *** [tmarshal.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

2 2

Getting Fallout 2 to work well
by Joonas Koivunen 07 Feb '07

07 Feb '07

Hello everyone! Recently I tried fallout2 again, and for some reason it has again started working with wine. I searched the archives and it seems there have been lots of times when it has worked and then again hasn't.. Glad to see I'm not the only one interested in it :) >From what I gathered from old postings, there had mainly been issues with mouse input, from which I at least don't suffer. Nor are there any more reports (appdb at least) of it not working with the latest 0.9.30. The problem I have is that fallout2.exe takes all the available CPU power, optimizing that might make other old games work better too. I'm interested in the task, though I haven't got much of an idea how GDI or DirectDraw api's work and I'd need some pointers where to start solving this problem. Game taking all of available CPU doesn't make it unplayable. It just makes mouse movement jerky and overall feeling is that my computer (amd athlon xp 1800+) is too slow :) AFAIK minimum requirements for this game were something like P90 with 16MB ram :) Some "features" like fading to black and white (going to menu for example) are simply missing (these were in use a while ago, with older wine). The rendering of animations slows down (in the combat mode) if the animation happens to be under the animated cursor. I have tried Thunderbirds (from #winehq @ freenode.net) patch, which when rendering with opengl uses pixel shaders to do 8bit->32bit conversion. It resulted in a bit more sluggish (compared to GDI) game play experience. Profiling with oprofile (GDI session) shows that most of the time is used in the game (I suppose it's the "anon" from wine-preload), next most time consuming is winex11 drivers X11DRV_DIB_SetImageBits which seems to be doing the conversion. I have included a bit cleaned version of opreport -l, only the first 40 lines. Any help would be appreciated. -- -- Joonas Koivunen

5 9

Re: msi: Register the typelib
by Alexandre Julliard 07 Feb '07

07 Feb '07

Mike McCormack <mike(a)codeweavers.com> writes: > +ITypeLib *get_msi_typelib( LPWSTR *path ) > +{ > + static CRITICAL_SECTION cs = { NULL, -1, 0, 0, 0, 0 }; Please use the standard pattern for static critical sections. Setting the debug info to NULL is reserved for global sections. -- Alexandre Julliard julliard(a)winehq.org

1 0

msi: Make MsiInstallProduct conformance test depend on proper UI level processing.
by Misha Koshelev 07 Feb '07

07 Feb '07

Hi, just wanted to double-check with msi ppl and other wine developers if it's okay to add my conformance test to the test_MsiInstallProduct function. My reasons for doing this versus a completely separate test function are as follows: 1. The test is already testing a full product install (installs files, services, registry values, etc) and my modification will simply result in either no modification to these actions if UI level processing is good or complete failure if it is bad, which will make the problem very easy to diagnose. 2. Looking through instructions on msdn it seems that there isn't a kosher way to make a very simple MSI file that just, say, writes a registry value (without doing costing, install validation, having a full features table, installing some features, etc.) which would make a separate function easy to implement and it does not really seem necessary to copy and paste the whole test_MsiInstallProduct (or similar) function just to check UI level processing. I could do a separate function, it just seems unnecessary. Misha p.s. For some reason, I can't compile the msi crosstests (it gives an error on linking with -lcabinet, whereas, say, kernel32 crosstests compile file), so if anyone can crosstest it for me that would be great :)

1 1

Re: [urlmon 1/2] Cast-qual warning fix
by Joris Huizer 07 Feb '07

07 Feb '07

--- Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Fix a warning and remove the now not needed cast. > > Changelog > Cast-qual warning fix > > Cheers, > > Paul. > > > > diff --git a/dlls/urlmon/umon.c b/dlls/urlmon/umon.c > index 49260ab..d593c81 100644 > --- a/dlls/urlmon/umon.c > +++ b/dlls/urlmon/umon.c > @@ -1605,7 +1605,7 @@ HRESULT WINAPI > URLDownloadToCacheFileW(LPUNKNOWN lpUnkCaller, > LPCWSTR szURL, LPW > HRESULT hr; > LPWSTR ext; > > - static const WCHAR header[] = { > + static WCHAR header[] = { > 'H','T','T','P','/','1','.','0',' > ','2','0','0',' ', > > 'O','K','\\','r','\\','n','\\','r','\\','n',0 > }; > @@ -1631,7 +1631,7 @@ HRESULT WINAPI > URLDownloadToCacheFileW(LPUNKNOWN lpUnkCaller, > LPCWSTR szURL, LPW > modified.dwLowDateTime = 0; > > if (!CommitUrlCacheEntryW(szURL, cache_path, > expire, modified, NORMAL_CACHE_ENTRY, > - (LPWSTR)header, > sizeof(header), NULL, NULL)) > + header, > sizeof(header), NULL, NULL)) > return E_FAIL; > > if (lstrlenW(cache_path) > dwBufLength) > -- If CommitUrlCacheEntryW does not take a constant pointer, this might be dangerous - if it changes the string, the next time this code executes the wrong (modified) string gets used If this is indeed possible, the static keyword needs to be dropped too (ensuring the string is reinitialised with the next call) If it is only not possible in this particular case, sorry for complaining; (though it may be possible to factor out that part of the code that is used, thus ensuring constness) If this is not possible in general, the function CommitUrlCacheEntryW should take a constant pointer instead (same for the other patch) regards, Joris ____________________________________________________________________________________ Do you Yahoo!? Everyone is raving about the all-new Yahoo! Mail beta. http://new.mail.yahoo.com

1 0

Re: comctl32: tab: update the item mask after a TB_SETITEM (fixes bug #7345)
by Felix Nawothnig 06 Feb '07

06 Feb '07

Mikołaj Zalewski wrote: > Tab uses a mask to mark which fields are set but it new fields were set > by SetItem the mask wasn't updated. Actually all members are always valid (for the internal structure at least). I already sent a patch which removes the mask. Felix

2 1

qemu-0.9.0 and kqemu-1.3.0pre10 (now GPL) released
by Detlef Riekenberg 06 Feb '07

06 Feb '07

http://www.qemu.org/ QEMU 0.9.0 was released. The QEMU Accelerator Module kqemu-1.3.0pre10 was released and is now available under the GPL license. Thanks Fabrice, the qemu-team and every contributor. -- By by ... Detlef

1 0

Re: msi: InstallPackage check for UI level must not disregard flags (updated)
by James Hawkins 06 Feb '07

06 Feb '07

On 2/5/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > This is an update, a little less hacky thanks to advice from Dmitry > Timoshkov. This fixes bug #6992. The installer for Vector NTI 10 was > getting to the > point where it was trying to launch the .msi files that do the actual > install, but was quitting with the message "This module is not designed > for direct execution." Install worked fine with native MSI. After a > while of playing with it and disassembling the MSI file with dark.exe > tool, I noticed that the .msi files ran in execute mode but not UI mode. > Finally, I checked the UI level that wine msi was reading, and it was > 102 which is INSTALLUILEVEL_NONE | INSTALLUILEVEL_SOURCESONLY. However, > MSI_InstallPackage was only checking if the uilevel >= > INSTALLUILEVEL_REDUCED, which would have been true in this case as > INSTALLUILEVEL_SOURCESONLY > INSTALLUILEVEL_REDUCED but the actual ui > level is INSTALLUILEVEL_NONE which is < INSTALLUILEVEL_REDUCED. This > patch fixes this check, and now the installer finished successfully > (although it seems upon a quick check that there are more install bugs > for this program in wine, as not all files that should be there seem to > be there after this install). > > Changelog: > > * msi: InstallPackage check for UI level must not disregard > INSTALLUILEVEL flags. > > + if ( (msi_get_property_int(package, szUILevel, 0) & 0xf) >= INSTALLUILEVEL_REDUCED ) > Magic numbers are bad. What is 0xF? -- James Hawkins

4 7

Window focus testing
by Duane Clark 06 Feb '07

06 Feb '07

Is it possible to do window focus testing in Wine conformance tests? Or does the windows not being mapped mean that this testing cannot be done? Or maybe I am doing something completely wrong; which is likely ;) I am specifically trying to test window focus in this bug: http://bugs.winehq.org/show_bug.cgi?id=7280 As mentioned in the bug, I turned the treeview conformance test into a standalone test with a mapped window, and added testing that does show focus behavior. But so far I have not been able to get it to give good results in a Wine conformance test.

3 2

Re: [PATCH] make CarbonPoker (previously Poker.com) client work.
by Juan Lang 06 Feb '07

06 Feb '07

Hi Trent, thanks for the patches. Please send the split up patches to wine-patches instead of wine-devel. The crypt32 patches won't make it in as-is, but I think you can get a better quality hack accepted. As MSDN states, CryptGetMessageCertificates is just a wrapper around CertOpenStore. So you could write something like the following: HCERTSTORE WINAPI CryptGetMessageCertificates( DWORD dwMsgAndCertEncodingType, HCRYPTPROV hCryptProv, DWORD dwFlags, const BYTE* pbSignedBlob, DWORD cbSignedBlob) { CRYPT_DATA_BLOB blob = { cbSignedBlob, (LPBYTE)pbSignedBlob }; TRACE("%d, %p, %d, %p, %d\n", dwMsgAndCertEncodingType, hCryptProv, dwFlags, pbSignedBlob, cbSignedBlob); return CertOpenStore(CERT_STORE_PROV_PKCS7, dwMsgAndCertEncodingType, hCryptProv, dwFlags, &blob); } Then in store.c, add a stub function for opening and closing PKCS7 stores - look at CRYPT_PhysOpenStore for an example. Cheers, --Juan ____________________________________________________________________________________ Get your own web address. Have a HUGE year through Yahoo! Small Business. http://smallbusiness.yahoo.com/domains/?p=BESTDEAL

1 0

Linuxtag 2007 in Berlin
by Stefan Munz 06 Feb '07

06 Feb '07

Hi, there is a "CALL FOR PROJECTS" for Linuxtag 2007 in Germany/Berlin from May 30 to June 2. Is anybody interested in participating in a Wine booth? More information (in german) is here: http://www.linuxtag.org/2007/de/community/projects/cfpro/call-for-projects.… Projects should be registered until February 23. cu, Stefan

3 2

Bug 4791 - Civ4 crashes because of recent explorer/systray changes
by Fabian Bieler 06 Feb '07

06 Feb '07

Hello! I tried to look into Bug 4791 (Civ4 crashes because of recent explorer/systray changes http://bugs.winehq.org/show_bug.cgi?id=4791 ). Pretty early during initialization (before the application creates any windows itsself) a WM_FONTCHANGE message is broadcasted. The only window to which the message gets actually send is the Wine Systray Listener window. The message is immediately pulled by peek_message as a MSG_NOTIFY message. A few seconds later the WM_FONTCHANGE message is pulled from the queue of the Wine Systray Listener window again, this time of the type MSG_CALLBACK. the callback function pointer is a nullpointer resulting in a pagefault. If the Wine Desktop window is set as its own parent (like described in the bugzilla thread), the WM_FONTCHANGE message does not get send to the window and the program starts up fine. Now, I do not really understand the wine messaging system (particularly the difference between notify and callback messages) so I thought maybe somebody here could help me with that or point me to some introduction other than http://winehq.org/site/docs/winedev-guide/c3762#AEN3825 and message.c. Should the fontchange-message really be send to the Wine Systray Listener window? All test were run using wine-0.9.30, civ4 v1.61 with nocd-patch and native msxml3. Fabian

1 1

Presenting at LinuxTag?
by Dan Kegel 06 Feb '07

06 Feb '07

David asked if anyone's interested in manning a Wine booth at Linuxtag. A related question: is anybody proposing a Wine talk or tutorial at Linuxtag? The deadline for submitting proposals is Feb 16th. (Here's the CFP: http://www.linuxtag.org/2007/en/conf/cfp/cfp-target.html )

1 0

Daylight saving changes
by Francois Gouget 06 Feb '07

06 Feb '07

Quite a few countries seem to be changing their daylight saving rules this year. Also Wine stores timezone information in the registry so won't we need to update the data we store in the registry? While looking at wine's timezone data I also found quite a few differences with Windows' data. Hence the question: Where does wine.inf's current data come from? Where can one find authoritative data for this? Does any one have an opinion on what to do about those? * wine.inf's TZI field does not match Windows for these time zones: Won't this impact email tools? Arabic Standard Time Azores Standard Time Caucasus Standard Time Dateline Standard Time E. South America Standard Time GTB Standard Time Iran Standard Time Israel Standard Time New Zealand Standard Time Newfoundland Standard Time Pacific SA Standard Time * wine.inf is missing some time zones: Ekaterinburg Standard Time Greenland Standard Time Mid-Atlantic Standard Time Nepal Standard Time Sri Lanka Standard Time W. Central Africa Standard Time * wine.inf has an extra time zone: Mexico Standard Time 2 * Wine's display name is not in the same format as the Windows one: For instance for Tonga Standard Time: Windows has: "Display"="(GMT+13:00) Nuku'alofa" Wine has : "Display"="Pacific/Tongatapu" -- Francois Gouget fgouget(a)codeweavers.com

2 1

[PATCH] make CarbonPoker (previously Poker.com) client work.
by Trent Waddington 06 Feb '07

06 Feb '07

These changes make the Carbon Poker (www.carbonpoker.com) client work. Run the Carbon Poker installer; then Run c:/windows/system32/Macromed/Flash/GetFlash.exe; then Run c:/windows/CarbonPoker/Poker.exe Screenshot: http://rtfm.insomnia.org/~qg/CarbonPoker-Ubuntu-wine.png If someone would like to implement PKCS7 support in crypt32, this patch could be much cleaner. --- ChangeLog | 15 +++++++++++++++ dlls/crypt32/cert.c | 16 ++++++++++++++++ dlls/crypt32/crypt32.spec | 2 +- dlls/crypt32/main.c | 12 +++++++++++- dlls/crypt32/store.c | 4 ++++ dlls/usp10/usp10.c | 33 +++++++++++++++++++++++++++++++++ dlls/usp10/usp10.spec | 2 +- dlls/wininet/http.c | 4 ++-- 8 files changed, 83 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 658036c..297fb08 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,18 @@ +2007-02-06 Trent Waddington <trent.waddington(a)gmail.com> + + * dlls/crypt32/cert.c: + dlls/crypt32/main.c: + dlls/crypt32/store.c: + dlls/crypt32/crypt32.spec: + crypt32: Hacks to make Macromedia's GetFlash.exe not complain about the lack of PKCS7 support. + + * dlls/usp10/usp10.c: + dlls/usp10/usp10.spec: + usp10: Implemented ScriptGetLogicalWidths. + + * dlls/wininet/http.c: + wininet: Implement a feature of HttpOpenRequestA where lpszAcceptTypes can be terminated with an empty string instead of a NULL. + 2007-01-24 Vitaliy Margolen <wine-patches(a)kievinfo.com> * server/token.c: diff --git a/dlls/crypt32/cert.c b/dlls/crypt32/cert.c index b39c3ca..e3ed7e0 100644 --- a/dlls/crypt32/cert.c +++ b/dlls/crypt32/cert.c @@ -130,6 +130,10 @@ BOOL WINAPI CertFreeCertificateContext(PCCERT_CONTEXT pCertContext) { TRACE("(%p)\n", pCertContext); + // HACK for GetFlash.exe + if (pCertContext == 0xdeadbeef) + return TRUE; + if (pCertContext) Context_Release((void *)pCertContext, sizeof(CERT_CONTEXT), CertDataContext_Free); @@ -921,6 +925,12 @@ PCCERT_CONTEXT WINAPI CertFindCertificateInStore(HCERTSTORE hCertStore, TRACE("(%p, %d, %d, %d, %p, %p)\n", hCertStore, dwCertEncodingType, dwFlags, dwType, pvPara, pPrevCertContext); + // HACK for GetFlash.exe + if (hCertStore == 0xdeadbeef) { + ret = 0xdeadbeef; + return ret; + } + switch (dwType >> CERT_COMPARE_SHIFT) { case CERT_COMPARE_ANY: @@ -987,6 +997,12 @@ BOOL WINAPI CertVerifySubjectCertificateContext(PCCERT_CONTEXT pSubject, static const DWORD supportedFlags = CERT_STORE_REVOCATION_FLAG | CERT_STORE_SIGNATURE_FLAG | CERT_STORE_TIME_VALIDITY_FLAG; + // HACK for GetFlash.exe + if (pSubject == 0xdeadbeef || pIssuer == 0xdeadbeef) { + *pdwFlags = 0; + return TRUE; + } + if (*pdwFlags & ~supportedFlags) { SetLastError(E_INVALIDARG); diff --git a/dlls/crypt32/crypt32.spec b/dlls/crypt32/crypt32.spec index 7ee23f4..705fb8f 100644 --- a/dlls/crypt32/crypt32.spec +++ b/dlls/crypt32/crypt32.spec @@ -118,7 +118,7 @@ @ stub CryptGetAsyncParam @ stdcall CryptGetDefaultOIDDllList(long long ptr ptr) @ stdcall CryptGetDefaultOIDFunctionAddress(long long wstr long ptr ptr) -@ stub CryptGetMessageCertificates +@ stdcall CryptGetMessageCertificates(long long long ptr long) @ stub CryptGetMessageSignerCount @ stdcall CryptGetOIDFunctionAddress(long long str long ptr ptr) @ stdcall CryptGetOIDFunctionValue(long str str wstr ptr ptr ptr) diff --git a/dlls/crypt32/main.c b/dlls/crypt32/main.c index dd9e1fb..80567ab 100644 --- a/dlls/crypt32/main.c +++ b/dlls/crypt32/main.c @@ -238,5 +238,15 @@ BOOL WINAPI CryptVerifyMessageSignature(PCRYPT_VERIFY_MESSAGE_PARA pVerifyPara, FIXME("stub: %p, %d, %p, %d, %p, %p, %p\n", pVerifyPara, dwSignerIndex, pbSignedBlob, cbSignedBlob, pbDecoded, pcbDecoded, ppSignerCert); - return FALSE; + return TRUE; +} + +HCERTSTORE WINAPI CryptGetMessageCertificates(DWORD dwMsgAndCertEncodingType, + HCRYPTPROV hCryptProv, DWORD dwFlags, const BYTE* pbSignedBlob, + DWORD cbSignedBlob) +{ + FIXME("stub: %d, %p, %d, %p, %d\n", + dwMsgAndCertEncodingType, hCryptProv, dwFlags, pbSignedBlob, + cbSignedBlob); + return 0xdeadbeef; // HACK for GetFlash.exe } diff --git a/dlls/crypt32/store.c b/dlls/crypt32/store.c index 8c8cda5..c82fcbc 100644 --- a/dlls/crypt32/store.c +++ b/dlls/crypt32/store.c @@ -2431,6 +2431,10 @@ BOOL WINAPI CertCloseStore(HCERTSTORE hCertStore, DWORD dwFlags) TRACE("(%p, %08x)\n", hCertStore, dwFlags); + // HACK for GetFlash.exe + if (hCertStore == 0xdeadbeef) + return TRUE; + if( ! hCertStore ) return TRUE; diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index c3b0a17..6f860e0 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -1553,6 +1553,39 @@ HRESULT WINAPI ScriptStringGetLogicalWidths(SCRIPT_STRING_ANALYSIS ssa, int *piD } /*********************************************************************** + * ScriptGetLogicalWidths (USP10.@) + * + * Returns logical widths from an analysis. + * + * PARAMS + * psa [I] analysis. + * cChars [I] count of logical code points in the run. + * cGlyphs [I] count of glyphs in the run. + * piGlyphWidth [I] array of glyph advance widths. + * pwLogClust [I] array of logical clusters. + * psva [I] visual attributes. + * piDx [O] logical widths returned. + * + * RETURNS + * Success: S_OK + * Failure: a non-zero HRESULT. + */ +HRESULT WINAPI ScriptGetLogicalWidths(const SCRIPT_ANALYSIS *psa, int cChars, + int cGlyphs, const int *piGlyphWidth, const WORD *pwLogClust, + const SCRIPT_VISATTR *psva, int *piDx) +{ + int i; + + TRACE("%p, %d, %d, %p %p, %p, %p\n", psa, cChars, cGlyphs, piGlyphWidth, pwLogClust, psva, piDx); + + for (i = 0; i < cGlyphs; i++) + { + piDx[i] = piGlyphWidth[i]; + } + return S_OK; +} + +/*********************************************************************** * ScriptStringValidate (USP10.@) * * Validate a string analysis. diff --git a/dlls/usp10/usp10.spec b/dlls/usp10/usp10.spec index df07f43..ac1506e 100644 --- a/dlls/usp10/usp10.spec +++ b/dlls/usp10/usp10.spec @@ -8,7 +8,7 @@ @ stdcall ScriptGetCMap(ptr ptr ptr long long ptr) @ stdcall ScriptGetFontProperties(long ptr ptr) @ stdcall ScriptGetGlyphABCWidth(ptr ptr long ptr) -@ stub ScriptGetLogicalWidths +@ stdcall ScriptGetLogicalWidths(ptr long long ptr ptr ptr ptr) @ stdcall ScriptGetProperties(ptr long) @ stdcall ScriptIsComplex(wstr long long) @ stdcall ScriptItemize(wstr long long ptr ptr ptr ptr) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index 8a34749..379b03e 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -803,11 +803,11 @@ HINTERNET WINAPI HttpOpenRequestA(HINTERNET hHttpSession, if (lpszAcceptTypes) { /* find out how many there are */ - while (lpszAcceptTypes[acceptTypesCount]) + while (lpszAcceptTypes[acceptTypesCount] && *lpszAcceptTypes[acceptTypesCount]) acceptTypesCount++; szAcceptTypes = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR *) * (acceptTypesCount+1)); acceptTypesCount = 0; - while (lpszAcceptTypes[acceptTypesCount]) + while (lpszAcceptTypes[acceptTypesCount] && *lpszAcceptTypes[acceptTypesCount]) { len = MultiByteToWideChar(CP_ACP, 0, lpszAcceptTypes[acceptTypesCount], -1, NULL, 0 ); -- 1.4.4.3

4 5

Re: user32: WM_SETFONT on button doesn't repaint directly
by Dmitry Timoshkov 06 Feb '07

06 Feb '07

"Clinton Stimpson" <cjstimpson(a)utwire.net> wrote: > This patch fixes WM_SETFONT on a button to not paint directly. Instead, > it calls InvalidateRect. > A test is included that demonstrates that no paint events come out of > sending a WM_SETFONT. > > > Thanks, > Clinton Stimpson > > ChangeLog: > Setting font on button doesn't repaint directly. I think that your previous version of the test that called UpdateWindow and demonstrated that WM_SETFONT triggers full painting sequence was more correct. I have no idea though why it has not been accepted. Also, as a way to simplify the test there is no need to create a font, I'd suggest to use GetStockObject to retrieve a handle to one of the stock fonts. -- Dmitry.

1 0

It's that time again - time to start thinking about WineConf 2007!
by Jeremy White 06 Feb '07

06 Feb '07

So we can ask, once again: when will 1.0 ship!?!?! I'd invite anyone with an interest in attending to subscribe to the Wineconf mailing list: http://www.winehq.org/mailman/listinfo/wineconf I think an approach that makes sense is for us to discuss options as to where to hold it this year on that list, and then present either a consensus or choices back to the wine-devel list once we're done. So please come join us, particularly if you have a suggestion or preference for where it should be held! Cheers, Jeremy p.s. I think Wine will go 1.0 in the same year that is the year of Linux on the Desktop <evil grin>.

5 6

msi patch: Is this too hacky?
by Misha Koshelev 06 Feb '07

06 Feb '07

Hi, I submitted the following patch to wine-patches but was thinking about it some more. The problem is that you have the following UI levels and flags: INSTALLUILEVEL_NOCHANGE = 0, INSTALLUILEVEL_DEFAULT = 1, INSTALLUILEVEL_NONE = 2, INSTALLUILEVEL_BASIC = 3, INSTALLUILEVEL_REDUCED = 4, INSTALLUILEVEL_FULL = 5, INSTALLUILEVEL_HIDECANCEL = 0x20, INSTALLUILEVEL_PROGRESSONLY = 0x40, INSTALLUILEVEL_ENDDIALOG = 0x80, INSTALLUILEVEL_SOURCERESONLY = 0x100 and the code to check for the level was: if ( msi_get_property_int(package, szUILevel, 0) >= INSTALLUILEVEL_REDUCED) but the problem is that if any of the flags are set, then immediately this would assume full UI install even though this is not the case for some installers (see bug #6992). I proposed this change: if ( (msi_get_property_int(package, szUILevel, 0) & INSTALLUILEVEL_FULL) >= INSTALLUILEVEL_REDUCED ) It will work because INSTALLUILEVEL_FULL is 4+1 and so doing an AND operation with INSTALLUI_LEVEL FULL will be 4+1 and with INSTALLUILEVEL_REDUCED will be 4, both of which are greater than or equal to four. However, if for some reason these UI levels were to change in the future, or if someone decided to further modify this code and say, try to check for INSTALLUILEVEL_BASIC (3) they would actually be getting a 1 instead by doing INSTALLUILEVEL_BASIC & INSTALLUILEVEL_FULL. So is this too hacky? Is there a simple, better way to do this? Thanks Misha

2 2

Re: msvcrt: implement _mbbtype according to MSDN
by Dmitry Timoshkov 06 Feb '07

06 Feb '07

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > /********************************************************************* > + * _mbbtype(MSVCRT.@) > + */ > +int CDECL _mbbtype(unsigned char c, int type) > +{ > + if (type == 1) > + { > + if ((c >= 0x20 && c <= 0x7e) || (c >= 0xa1 && c <= 0xdf)) > + return _MBC_SINGLE; > + else if ((c >= 0x40 && c <= 0x7e) || (c >= 0x80 && c <= 0xfc)) > + return _MBC_TRAIL; > + else > + return _MBC_ILLEGAL; > + } > + else > + { > + if ((c >= 0x20 && c <= 0x7e) || (c >= 0xa1 && c <= 0xdf)) > + return _MBC_SINGLE; > + else if ((c >= 0x81 && c <= 0x9f) || (c >= 0xe0 && c <= 0xfc)) > + return _MBC_LEAD; > + else > + return _MBC_ILLEGAL; > + } Since MSVCRT_mbctype array is not currently being initialized, probably using MSVCRT_current_ctype would be good enough for now. -- Dmitry.

1 0

Dead links
by Francois Gouget 06 Feb '07

06 Feb '07

I found some dead links on WineHQ. hat should we do about them? Does anyone want to hunt them down to see if they have simply moved elsewhere? There are also a bunch of dead links related to the Wine mailing lists. We cannot simply remove those :-( On the Wine Press page: http://www.winehq.org/site/press * Luhit July 1, 2006 - CrossOver Wine to join the party with BootCamp & Parallels http://luhit.wordpress.com/2006/07/01/mac-crossover-wine-to-join-the-party-… * OSViews September 13, 2004 - ReactOS - The Open Source Windows NT http://www.osviews.com/modules.php?op=modload&name=News&file=article&sid=14… * OSViews May 30, 2004 - SpecOpS Labs response to Wine Project http://www.osviews.com/modules.php?op=modload&name=News&file=article&sid=14… * OrangeCrate May 20, 2004 - An Interview with Jeremy White, CodeWeavers http://www.orangecrate.com/article.php?sid=710 * OSViews October 28, 2003 - Macromedia and Adobe Graphics Suites to Run on Linux http://www.osviews.com/modules.php?op=modload&name=News&file=article&sid=35… * ConsultingTimes October 17, 2002 - CodeWeavers/Xandros Deal: "Let the Revolution Begin!" http://www.consultingtimes.com/articles/codeweavers/codeweaversxandros.html And another one on the Fun Projects page: http://www.winehq.org/site/fun_projects * http://www.trolltech.com/products/qt/windows.html * http://www.winehq.org/hypermail/wine-devel/2003/01/0153.html * http://www.winehq.org/hypermail/wine-devel/2003/04/0324.html * http://www.winehq.org/hypermail/wine-patches/2002/09/0250.html * http://www.winehq.org/hypermail/wine-cvs/2003/12/0051.html And on the Winelib page there are a bunch of dead hypermail mailing list URLs. Unfortunately there appears to be no easy way to map them to the pipermail archives :-( http://www.winehq.org/site/winelib * http://www.winehq.org/hypermail/wine-devel/2004/04/0192.html * http://www.winehq.org/hypermail/wine-patches/2003/04/0237.html + 6 more * Erwin Wolff http://www.winehq.org/site/erwinwolffnl@microformatica.com And on the Resources page: http://www.winehq.org/site/resources * WinDoc http://leb.net/wine/WinDoc/ * X2 http://sunsite.lanet.lv/ftp/mirror/x2ftp/msdos/programming/00Main.html * comp.fonts http://rcum.uni-mb.si/local/fontfaq/cf_1.htm * Internet Font Archive http://rcum.uni-mb.si/local/fontfaq/cf_18.htm#GLOSS6 * Curvesoft http://www.curvesoft.com/tools.html -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

4 5

Donation for your work on Direct 3D
by Mirek 06 Feb '07

06 Feb '07

Hi Stefan and Henry, i would like to send you 35 EUR or 45 USD for your work on Direct 3D in wine, how can i do that? Can you send me your account number and prefered currency? Mirek Slugeň Czech Republic

4 3

Re: [Bug 6689] Created links do not reflect WINEPREFIX used
by Lei Zhang 05 Feb '07

05 Feb '07

Setting the Exec= line in a .desktop file to: WINEPREFIX=foo wine bar worked in KDE. In Gnome, it works if "run from the terminal" is set. Unfortunately the Freedesktop spec for desktop entries does not specify a way to add environment variables. So yes, it looks like we'll need a wrapper script, or perhaps add a --prefix option to Wine? On 1/27/07, Wine Bugs <wine-bugs(a)winehq.org> wrote: > http://bugs.winehq.org/show_bug.cgi?id=6689 > > > > > > ------- Additional Comments From vitaliy(a)kievinfo.com 2007-28-01 01:49 ------- > This is not going to work - it's not standard compliant. And I think it won't > work on Gnome either. The only way this can be fixed atm is using some wrapper > script. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are the assignee for the bug, or are watching the assignee. > > >

4 4

Re: [msvcrt] properly align struct _stati64's st_size
by Dmitry Timoshkov 05 Feb '07

05 Feb '07

"Damjan Jovanovic" <damjan.jov(a)gmail.com> wrote: > In wine's struct _stati64, st_size has an offset of 20 bytes from the > beginning of the struct, unlike mingw's and Window's 24. This breaks > Java 1.4.x pretty badly, it dies on startup complaining about a > truncated class file (#2953). Using #include <pshpack8.h> and #include > <pshpop8.h> around the struct didn't help, so a padding field was used > instead. Does the approach used in winbase.h in declaration of WIN32_STREAM_ID to align the Size field help? #include <pshpack8.h> typedef struct _WIN32_STREAM_ID { DWORD dwStreamId; DWORD dwStreamAttributes; LARGE_INTEGER DECLSPEC_ALIGN(8) Size; DWORD dwStreamNameSize; WCHAR cStreamName[ANYSIZE_ARRAY]; } WIN32_STREAM_ID, *LPWIN32_STREAM_ID; #include <poppack.h> > +static void test_stat( void ) > +{ > + int offset = offsetof(struct _stati64, st_size); > + ok(offset == 24, "struct _stati64's st_size is misaligned, got %d, expected 24\n", offset); > +} This should be a part of auto generated header tests. Have a look at dlls/*/tests/generated.c files. -- Dmitry.

3 6

Re: Synchronize code page 20127 table with Windows one
by Robert Shearman 05 Feb '07

05 Feb '07

Dmitry Timoshkov wrote: > The problem is that our translation table for code page 20127 is different from > what Windows has, and the ansi_buf get mangled. Attached patch synchronizes our > code page 20127 table with Windows one and fixes the bug. If you change a codepage from a unicode.org mapping then you need to add the changed .TXT file you generated it from to the build tree and update cpmap.pl to use it. -- Rob Shearman

3 2

Re: [try3]: user32/tests: add tests for WM_SETICON - what's wrong?
by Kirill K. Smirnov 05 Feb '07

05 Feb '07

Hi, I've asked before: What's wrong with them? Maybe, unnecessary PeekMessage in tests??? http://www.winehq.org/pipermail/wine-patches/2007-January/035044.html http://www.winehq.org/pipermail/wine-patches/2007-January/035043.html Please, answer! Do not ignore! -- Kirill

1 0

help in debugging
by Ioannis Nousias 05 Feb '07

05 Feb '07

Hello Wine developers, I've decided to see what causes floAt's Mobile Agent[1] to fail with wine I checked the wine developers' cheatsheet to help me debug the application, but I'm lost. The application installs but with some error: "C:\Program Files\Fma\sframeword\helper\BramusICQ.dll Unable to register the DLL/OCX: LoadLibrary failed; code 126 Module not found." I click "ignore" and the installation continues. When I try to execute the installed binary "MobileAgent.exe" it fails. I invoke it like this: WINEDEBUG=+seh,+relay WINEPREFIX=/tmp/winetemp wine MobileAgent.exe no error messages are produce by the app itself. on wine's debug log I see the following, just before winedbg starts: 0009:Ret kernel32.SetEvent() retval=00000001 ret=00410759 trace:seh:call_stack_handlers handler at 0x4045c7 returned 1 trace:seh:call_stack_handlers calling handler at 0x477d9a code=eedfade flags=1 0009:Call ntdll.RtlUnwind(0034feb8,0040427c,0034f140,00000000) ret=0040427c 0009: eax=0034f140 ebx=0034eca0 ecx=005acb61 edx=0034feb8 esi=0034feb8 edi=00000001 ebp=0034ecb8 esp=0034ec6c ds=007b es=007b fs=0033 gs=003b flags= 00200246 trace:seh:__regs_RtlUnwind code=eedfade flags=3 trace:seh:__regs_RtlUnwind calling handler at 0x60178400 code=eedfade flags=3 trace:seh:__regs_RtlUnwind handler at 0x60178400 returned 1 0009:Ret ntdll.RtlUnwind() retval=00000000 ret=0040427c 0009: eax=00000000 ebx=0034eca0 ecx=005acb61 edx=0034feb8 esi=0034feb8 edi=00000001 ebp=0034ecb8 esp=0034ec6c ds=007b es=007b fs=0033 gs=003b flags= 00200246 trace:seh:call_stack_handlers handler at 0x4045c7 returned 1 trace:seh:call_stack_handlers calling handler at 0x69ff49 code=eedfade flags=1 trace:seh:call_stack_handlers handler at 0x69ff49 returned 1 trace:seh:call_stack_handlers calling handler at 0x4046b8 code=eedfade flags=1 0009:Call kernel32.UnhandledExceptionFilter(0034ec90) ret=004046dc wine: Unhandled exception 0x0eedfade at address 0x0000:0x6024daa0 (thread 0009), starting debugger... trace:seh:start_debugger Starting debugger "winedbg --auto 8 228" this is not the first "trace:seh". Relatively early in the call stack there is this: 000b:Call user32.SetDeskWallPaper(code=c0000005 flags=0 addr=0x601b044b trace:seh:raise_exception info[0]=00000000 trace:seh:raise_exception info[1]=ffffffff trace:seh:raise_exception eax=ffffffff ebx=6011999c ecx=00000003 edx=0000ffff esi=00000000 edi=ffffffff trace:seh:raise_exception ebp=00117b98 esp=0034f61c cs=0073 ds=007b es=007b fs=0033 gs=003b flags=00010206 trace:seh:call_stack_handlers calling handler at 0x602b5540 code=c0000005 flags=0 trace:seh:__regs_RtlUnwind code=c0000005 flags=2 trace:seh:__regs_RtlUnwind calling handler at 0x602b5400 code=c0000005 flags=2 trace:seh:__regs_RtlUnwind handler at 0x602b5400 returned 1 ffffffff (invalid)) ret=6033e95f which looks suspicious to me. Am I on the right track? Unfortunately I'm not familiar with windows API or wine's underlying architecture. I need some guidance please :) I'm an experienced C/C++ programmer. thanks -Ioannis [1] http://fma.sourceforge.net/index2.htm

3 5

comctl32 kibitzers wanted
by Dan Kegel 05 Feb '07

05 Feb '07

I and Lei Zhang, with some help from James Hawkins, are leading a group of 13 UCLA students who are writing conformance tests for comctl32. Each student picked one control, and is now busily writing getter/setter tests. In the coming few weeks we'll also try more interesting tests, like verifying that the right messages are sent in the right order. If you're interested in helping the students in any way (reviewing code before it hits wine-patches, offering suggestions on how to test tricky bits, or whatever), please let me know and I can add you to the project's mailing list. Thanks, Dan

2 1

Re: shell32: shlfileop tests: avoid buffer overflows for paths
by James Hawkins 05 Feb '07

05 Feb '07

On 2/4/07, Mikołaj Zalewski <mikolaj(a)zalewski.pl> wrote: > These buffers can contain multiple paths and set_curr_dir_path can make > the paths long resulting in a buffer overflow. > > From 36e05f3140e57bad2af790c56073799d23f7ef60 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Thu, 25 Jan 2007 12:17:11 +0100 > Subject: [PATCH] shell32: shlfileop tests: avoid buffer overflows for paths > > --- > dlls/shell32/tests/shlfileop.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/shell32/tests/shlfileop.c b/dlls/shell32/tests/shlfileop.c > index b363c5e..23aaeba 100644 > --- a/dlls/shell32/tests/shlfileop.c > +++ b/dlls/shell32/tests/shlfileop.c > @@ -329,8 +329,8 @@ static void test_delete(void) > static void test_rename(void) > { > SHFILEOPSTRUCTA shfo, shfo2; > - CHAR from[MAX_PATH]; > - CHAR to[MAX_PATH]; > + CHAR from[5*MAX_PATH]; > + CHAR to[5*MAX_PATH]; > DWORD retval; > > shfo.hwnd = NULL; > This is really hacky. If this is fixed, it needs to be fixed properly. -- James Hawkins

2 1

Detect screen resolution change errors
by Francois Gouget 05 Feb '07

05 Feb '07

When I run the dlls/d3d9/device conformance test on Windows in VMware, I get a trace telling me that IDirect3D9_CreateDevice() failed and returned 0x8876086c. This seems to be because Windows has trouble changing the screen resolution when running in VMware (though it's perfectly capable of doing it when I go through the control panel). But when I run the test in Wine I'm getting a test failure because: * IDirect3D9_CreateDevice() did not change the screen resolution * but it returned success so that the screen size checks fail That's because XRandR fails to change the resolution (for whatever reason, it's irrelevant here). Wine detects that but does not report the information to the upper layers. So I have made a couple of patches: * the first one detects when XRandR, XVidMode or some low level routine fails to change the screen resolution, and propagates this so ChangeDisplaySettingsEx() returns an error * the second one modifies IWineD3DDeviceImpl_CreateAdditionalSwapChain() so it detects when ChangeDisplaySettingsEx() propagates that error upstream too Now the dlls/d3d9/device test succeeds on my machine (all while loudly complaining something is wrong): [...] err:xrandr:X11DRV_XRandR_SetCurrentMode Resolution change not successful -- perhaps display has changed? fixme:d3d9:IDirect3DDevice9Impl_CreateAdditionalSwapChain (0x1c4358) call to IWineD3DDevice_CreateAdditionalSwapChain failed fixme:d3d9:IDirect3D9Impl_CreateDevice (0x171448) D3D Initialization failed for WineD3DDevice 0x174ee8 device.c:741:could not create device, IDirect3D9_CreateDevice returned 0x8876086c device.c: 245 tests executed (0 marked as todo, 0 failures), 0 skipped. I have attached the relevant patches. Does this look ok to the DirectX gurus? -- Francois Gouget fgouget(a)codeweavers.com

3 5

Re: [lostwages] Update download-deb page with better information, error fixes
by Detlef Riekenberg 04 Feb '07

04 Feb '07

On Di, 2007-01-30 at 01:09 -0800, Scott Ritchie wrote: > + > +<p>While there is currently no Wine package explicitly designed for > the 64-bit version > +of Ubuntu, there are several hacks that can be used to install the > 32-bit package > +into the 64-bit distribution and have it function normally. See > +<a href="https://wiki.ubuntu.com/I386WineInAmd64">this page on the > Ubuntu wiki</a> > +for more details.</p> IMHO, a link to our own Wiki should be placed on the download-deb page http://wiki.winehq.org/WineOn64bit#head-56206e8bc74083807ffe06ccb471d3f964c… And as a Note on https://wiki.ubuntu.com/I386WineInAmd64 and https://help.ubuntu.com/community/WineForAMD64 The provided automatic installation script includes the sidenet-script. Please include a BIG WARNING, that this is never supported by winehq and the users need a clean wine, before they ask for help on #winehq or wine-users(a)winehq.org You mention sidenet on that page: "If you followed the manual instructions you need to install the Sidenet script" This is wrong. Please remove that line! Even, when the sidenet-script might help some users to run an app, "you need to install the Sidenet script" is wrong! -- By by ... Detlef

3 7

Re: [msvcrt] properly align struct _stati64's st_size
by Francois Gouget 03 Feb '07

03 Feb '07

On Sat, 3 Feb 2007, Damjan Jovanovic wrote: [...] > * Added padding so that struct _stati64's st_size has an offset of 24 > bytes from the beginning of the struct like it should. Does the st_size field get the right offset when using Wine's header with the Windows compiler? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

1 0

Re: winetest: add support for http_proxy environment variable
by Detlef Riekenberg 02 Feb '07

02 Feb '07

On So, 2007-01-14 at 15:13 +0100, Németh Márton wrote: Welcome to wine. I have some comments about your Patch: > diff -u -r wine-0.9.29.orig/ChangeLog wine-0.9.29/ChangeLog > --- wine-0.9.29.orig/ChangeLog 2007-01-09 16:42:47.000000000 +0100 > +++ wine-0.9.29/ChangeLog 2007-01-14 15:02:31.000000000 +0100 The changelog will be updated during a release with the Informations from the subject. > + > + http_proxy = getenv("http_proxy"); > + if (http_proxy) { > + /* Proxy configuration found */ > + memset(&regex, 0, sizeof(regex)); > + retval = regcomp(&regex, The Idea to support a http-proxy is good, but the Programm must run on Windows. 1. I never saw an environment-variable "http_proxy" on Windows. Most Windows-Applications use the Proxy-Data from IE (Get the settings from there) 2. "regcomp" and friends are posix, but not available on windows Thanks for helping wine. -- By by ... Detlef

1 0

Re: [PATCH] ole32: Add CoWaitForMultipleHandles to spec file do it will be visible to windows apps.
by Paul Vriens 02 Feb '07

02 Feb '07

John Morris wrote: > I'm resubmitting the patch without the changelog entry. > > > ------------------------------------------------------------------------ > > From 4c51e49d432eb8342cadb71a3d539b2e8574849b Mon Sep 17 00:00:00 2001 > From: John Morris <mailjohnmorris(a)gmail.com> > Date: Fri, 2 Feb 2007 13:20:34 -0600 > Subject: ole32: Add CoWaitForMultipleHandles to spec file do it will be visible to windows apps. > > --- > dlls/ole32/ole32.spec | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec > index d775556..3ae0240 100644 > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -76,6 +76,7 @@ > @ stub CoUnloadingWOW > @ stdcall CoUnmarshalHresult(ptr ptr) > @ stdcall CoUnmarshalInterface(ptr ptr ptr) > +@ stdcall CoWaitForMultipleHandles(long long long ptr ptr) > @ stdcall CreateAntiMoniker(ptr) > @ stdcall CreateBindCtx(long ptr) > @ stdcall CreateClassMoniker(ptr ptr) > > > ------------------------------------------------------------------------ > > Hi, I thought we use: @ stub CoWaitForMultipleHandles for functions that should be exported and are not implemented at all, and use @ stdcall CoWaitForMultipleHandles(long long long ptr ptr) where we at least have something in a *.c file (although that could be a simple return): HRESULT WINAPI CoWaitForMultipleHandles(<stuff>) { FIXME("unimplemented stub!\n"); return E_FAIL; <or something alike> } Isn't the first one a stub and the second one a semi-stub, or have I mixed up things? Cheers, Paul.

2 1

Re: Added CoWaitForMultipleHandles to ole32.spec so it will be visible to W indows apps.
by Michael Stefaniuc 02 Feb '07

02 Feb '07

Hello John, thanks for the patch. You do not need to add the entry to the ChangeLog file. That is done automaticly using the git changelog entries during the release of a new Wine version. Would you mind resubmitting the patch without that? bye michael John Morris wrote: > From 79b3a4ba86ec3ddbd4b8be7c04bb350d78c78bfa Mon Sep 17 00:00:00 2001 > From: John Morris <mailjohnmorris(a)gmail.com> > Date: Wed, 31 Jan 2007 17:38:04 -0600 > Subject: Added CoWaitForMultipleHandles to ole32.spec so it will be visible to Windows apps. > > --- > ChangeLog | 5 +++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 658036c..ce545d0 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2007-01-31 John Morris <mailjohnmorris(a)gmail.com> > + > + * dlls/ole32/ole32.spec: > + ole32: Add CoWaitForMultipleHandles to spec file so it will be visible to windows apps. > + > 2007-01-24 Vitaliy Margolen <wine-patches(a)kievinfo.com> > > * server/token.c: > diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec > index d775556..3ae0240 100644 > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -76,6 +76,7 @@ > @ stub CoUnloadingWOW > @ stdcall CoUnmarshalHresult(ptr ptr) > @ stdcall CoUnmarshalInterface(ptr ptr ptr) > +@ stdcall CoWaitForMultipleHandles(long long long ptr ptr) > @ stdcall CreateAntiMoniker(ptr) > @ stdcall CreateBindCtx(long ptr) > @ stdcall CreateClassMoniker(ptr ptr) > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Re: comdlg32-colordlg fix bgcolor
by Dmitry Timoshkov 02 Feb '07

02 Feb '07

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > The patch corrects background color of a dialogue window " Choose color " at > copying a triangular marker, the user colors and the predetermined colors. > Earlier the background about these elements was more dark than the basic > background of a window. > + SetClassLongPtrW( hwnd, GCLP_HBRBACKGROUND, (LONG_PTR) GetSysColorBrush(COLOR_BTNFACE)); This fix is not correct, think for instance about different color themes. Probably CC_PaintTriangle needs to specify the background color of a triangle explicitly. -- Dmitry.

2 2

Re: Conformance test for bug #7286
by Dmitry Timoshkov 02 Feb '07

02 Feb '07

"Misha Koshelev" <mk144210(a)bcm.tmc.edu> wrote: > + /* Now create the notification thread */ > + events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0], > + 0, &threadId); > + ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError()); CreateThread returns NULL on error, not INVALID_HANDLE_VALUE. -- Dmitry.

3 3

Re: [PATCH 3/7] server: Implement object's security descriptor check against token.
by Robert Shearman 01 Feb '07

01 Feb '07

Vitaliy Margolen wrote: > + res = token_access_check( token, obj->sd, *access, &priv, &priv_count, > + &mapping, access, &status ) == STATUS_SUCCESS && > + status == STATUS_SUCCESS; > + if (!res) > + { > + fprintf( stderr, "access check failed\n" ); > + set_error( STATUS_ACCESS_DENIED ); > + } We don't want anything in the wineserver that can possibly spam the console, so this should be made conditional on debug_level being non-zero. Also, is there any reason you return STATUS_ACCESS_DENIED instead of the statuses returned by token_access_check? Could you try writing a test that creates or opens an object with ACCESS_SYSTEM_SECURITY access and see if it returns STATUS_PRIVILEGE_NOT_HELD or STATUS_ACCESS_DENIED? -- Rob Shearman

2 1

Re: [PATCH 1/7] server: Get the primary group from the token.
by Robert Shearman 01 Feb '07

01 Feb '07

Vitaliy Margolen wrote: > list_add_tail( &token->groups, &group->entry ); > + /* Use first owner capable group as an owner */ > + if (!token->primary_group && group->owner) > + token->primary_group = &group->sid; > + } > + /* we really need a primary group */ > + if (!token->primary_group && group_count) > + { > + release_object( token ); > + return NULL; > } > According to documentation from Microsoft, "the primary group only needs to be set if POSIX compatibility is required." Also, the default security descriptor does not require a group - a NULL group is fine. -- Rob Shearman

2 1

Re: [PATCH] rasapi32: RasEnumConnections now returns correct buffer size (zero) when there are zero connections available
by James Hawkins 01 Feb '07

01 Feb '07

On 2/1/07, John Smith <xixsimplicityxix(a)gmail.com> wrote: > When RasEnumConnections completes the expected behaviour is to have the > needed buffer size stored in *lpcb. Right now wine just leaves it at > whatever size was passed. The windows 2000 behaviour (tested) for when > they're are zero connections, *lpcb is 0. > > Changelog: > RasEnumConnections the buffersize needed reported is now 0 when the number > of connections is 0 > You need to add a test to the test suite for this. -- James Hawkins

1 0

Office 2003 Installation
by Jan de Mooij 01 Feb '07

01 Feb '07

Hi, I have tried to run the office 2003 installation, and in doing that I came across the following issues: - I think we need to undo a patch for msiexec [1]. CommandLineToArgvW does not what we want with slashes in paths followed by an " (this also happens on Windows). Therefore we need to parse the commandline arguments ourselves, what's done by reverting the patch. I can give an example of when it goes wrong if you want. - Office 2003 installation fails with this (from the log): ------------------------ Successfully launched MsiExec.... 2/1/2007 8:30:55 PM Chained install return code: 1603 Exit code was an error. Shutting down chained setup processing. Set Verbose logging for subsequent setup. ------------------------ BUT, when I add WINEDEBUG=+relay,+seh,+tid,+msi,+msiexec, it runs well and installs alright, so I think it's a timing issue. Anyone has experienced this before? What would be the best way to debug this? (I only choose to install Word, I don't know what happens when I select the other Office-applications) Thanks in advance, Jan de Mooij [1] http://source.winehq.org/git/wine.git/?a=blobdiff;f=programs/msiexec/msiexe…

1 0

skipping incompatible libwine build problem.
by Matthew Watchinski 31 Jan '07

31 Jan '07

Hopefully this is the right mailing list to ask this. If not please point me to the correct list. I have a simple application that use to build just fine using libwine/wine-0.9.30 on ubuntu edgy 32-bit. I just upgraded to a 64 bit system and got wine-0.9.30 installed and working, however, now my application doesn't build. uname -a: Linux ebx 2.6.17-10-generic #2 SMP Tue Dec 5 21:16:35 UTC 2006 x86_64 GNU/Linux When i run make everything builds correctly but it won't link and it exits as follows: wineg++ -c -Wall -Wextra -Wwrite-strings -Wcast-align -Wsign-compare -pedantic -m32 -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w -DCOMMAND_LINE -DWINDOWSNATIVE -DBUILD_CLI -o simpleapp.o simpleapp.cpp wineg++ -c -Wall -Wextra -Wwrite-strings -Wcast-align -Wsign-compare -pedantic -m32 -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w -DCOMMAND_LINE -DWINDOWSNATIVE -DBUILD_CLI -o simpleappList.o simpleappList.cpp wineg++ -mwindows -mno-cygwin -municode -mconsole -o simpleapp.exe.so simpleapp.o simpleappList.o -lodbc32 -lole32 -loleaut32 -lwinspool -luuid /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when searching for -lwine /usr/bin/ld: skipping incompatible /usr/local/lib/libwine.so when searching for -lwine /usr/bin/ld: cannot find -lwine collect2: ld returned 1 exit status winegcc: g++ failed. make: *** [simpleapp.exe.so] Error 2 Everything in /usr/local/lib looks right to me. ebx:~/Downloads/cvs/sfeng/research/tools/doccheck$ file /usr/local/lib/libwine.so* /usr/local/lib/libwine.so: symbolic link to `libwine.so.1.0' /usr/local/lib/libwine.so.1: symbolic link to `libwine.so.1.0' /usr/local/lib/libwine.so.1.0: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), not stripped And the makefile is pretty simple The only lines I've modified from the original winemaker Makefile are these: CXXFLAGS = -Wall -Wextra -Wwrite-strings -Wcast-align -Wsign-compare -pedantic -m32 #CXXFLAGS = CEXTRA = -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w CXXEXTRA = -mno-cygwin -municode -mconsole -Wb,--exe -Wb,-w RCEXTRA = INCLUDE_PATH = simpleapp_exe_LDFLAGS = -mwindows \ -mno-cygwin \ -municode \ -mconsole I assume I'm missing some magic ld switch, but I'm not sure what. Can anyone point me in the right direction? Thanks -matt

2 4

re: Please help me debug wineserver
by Dan Kegel 31 Jan '07

31 Jan '07

Misha wrote: > I am new to wine programming but have a fair amount of > experience with C/C++ programming in general. I have > recently decided to make the Vector NTI application work > on Wine, and after overcoming quite a few installation > difficulties by making an install shell script, Cool. Can you file a bug about those problems, and attach the shell script as a workaround? > I have run in to a problem that I have traced down to > wineserver. This problem occurs after repeatedly changing > folders in the Vector NTI "Open Molecule File" dialog, > which does not use the standard open file Windows dialog > (e.g., the "Open Shortcut" dialog in the same program works > fine). Wineserver crashes with the following error message: > > wineserver: object.c:274: release_object: Assertion `obj->refcount' failed. You also have a bug opened for this, http://bugs.winehq.org/show_bug.cgi?id=7286 I see you also have a possible workaround there. > On looking at the output of WINEDEBUG=+server, it seems > that the "Vector NTI" thread is woken up, and then receives > a USER_APC, at which time this crash occurs. What version of Wine? There were recent changes in APC handling in wine-0.9.30 (and perhaps 0.9.29) that may have broken this. If you can verify that this worked ok in earlier versions like 0.9.27, that would help. Alexandre is the expert on this. He's on vacation but he'll want to take a look when he gets back. - Dan

2 1

Re: wine + visual basic
by Alex Villacís Lasso 31 Jan '07

31 Jan '07

Joshua Masiko escribió: > hello, > I got your email addresses off the wine bug database at > http://bugs.winehq.org/show_bug.cgi?id=6638. > I'm looking at moving a custom Visual Basic 6 windows application to > linux + > wine. > > However I cannot find any good step by step documentation on how to do > this. > I have SUSE 10, wine 0.9.29. > I tried a simple test case which throws an error "ActiveX can't create > object" > > dim cn as adodb.connection > set cn=new adodb.connection 'error on this statement > > > Can u give me any pointers on what i need in order to run a visual basic > application which > uses an ODBC DSN (postresql) and ADO>=2.5 successfully. > I intend to publish a detailed step by step howto on this topic for other > potential wine users if successfull > The very first step is to ensure ADO is actually installed in the Wine directory. Usually the MSVB6 installer for the application (created with the Package and Deployment Wizard) takes care of this, but installing MDAC 2.x works too (I have installed MDAC 2.8). Wine currently provides no replacements for ADO libraries or objects, so doing either of these options is mandatory. It seems that you are trying to connect via ADO and ODBC. You should first have an Unix ODBC driver installed, since the ODBC support in Wine is simply a pass-through layer to the Unix ODBC support in the system. If you are compiling Wine from sources, you should (for example) have *both* unixODBC and unixODBC-devel RPM packages installed (or the equivalent bundles in SUSE). Otherwise, Wine will be compiled without ODBC support. You should then create (in unixODBC, not Wine) an ODBC data source for your database of choice, and verify (/usr/bin/isql) that you can actually connect and read data from it before trying to do anything from within Wine. Also, please note that Wine (currently) only supports as much ODBC as the underlying ODBC support does. In particular, the following syntax: > Set oConexion = New ADODB.Connection ... > oConexion.Open ConnectionString:="Driver={Microsoft Access Driver > (*.mdb)};DBQ=..." in which the driver is specified within curly braces, is *NOT* supported under Wine, nor is any variation of this method. You must specify a data source that appears in your ODBC configuration file in /etc/odbc.ini . Of course, you might just bypass the ODBC layer and do something like this: > Set oConexion = New ADODB.Connection ... > oConexion.Provider = "Microsoft.Jet.OLEDB.4.0" > oConexion.Properties("Jet OLEDB:Database Password") = > "somepassword" > > oConexion.Open ConnectionString:=App.Path & "\" & DATABASE_FILE This method works as long as all the corresponding providers (which are also ActiveX objects) are correctly registered. In this way, no ODBC code is involved and the Windows code directly manages the database connection. However, all the necessary providers and drivers must be installed by your application installer (again, the Packaging and Deployment Wizard should take care of these dependencies). Hope this helps. Alex Villacís Lasso -- perl -e '$x = 2.4; print sprintf("%.0f + %.0f = %.0f\n", $x, $x, $x + $x);'

1 0

Re: ras.h added szDeviceType pound defines
by Michael Stefaniuc 31 Jan '07

31 Jan '07

John Smith wrote: > This is my first patch uhh ever so I guess don't just throw it into the > source without wariness. =P Welcome to Wine. > That said it just updates the list of #define strings that are acceptable > device types for RASDEVINFO and RASENTRY. This will fix some compilation > issues against ras.h. > > There is more I could fix in ras.h but yeah my first time doing this, want > to see how the patch process works,blah blah. The Wine maintainer is this week on vacation so your patch would be probably commited earliest in 1 week. Do you know this page? http://www.winehq.org/site/sending_patches > Anyway if anything about how I did this is wrong please let me know I hope > to be a regular wino too =) Not really wrong but some nitpick. > ------------------------------------------------------------------------ > > From d294ed7e538a130ac10fad4bb2ac6a0f93120060 Mon Sep 17 00:00:00 2001 > From: John Klehm <xixsimplicityxix(a)gmail.com> > Date: Tue, 30 Jan 2007 15:24:56 -0600 > Subject: [PATCH] Added additional szDeviceType pound defines. These additions reflect > http://msdn2.microsoft.com/en-us/library/aa377274.aspx > and have been verified by a test program on Windows2000 and XP. > --- > include/ras.h | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/include/ras.h b/include/ras.h > index c1f6d5c..ef289f4 100644 > --- a/include/ras.h > +++ b/include/ras.h > @@ -43,6 +43,25 @@ extern "C" { > #define RASDT_Modem "modem" > #define RASDT_Isdn "isdn" > #define RASDT_X25 "x25" > +/* more szDeviceType strings for RASDEVINFO > + * from MSDN > + * http://msdn2.microsoft.com/en-us/library/aa377274.aspx > + * values taken from a test program on windows 2000 and XP > + * Following are Windows 2000 and Windows XP values > + * and above? > + */ You do not need this comment. MSDN is so often updated that the link will soon point to the void. Just document here the differences to MSDN or other outstanding info. Please use the same identing style like for the existing RASDT_* defines. > +#define RASDT_Vpn "vpn" > +#define RASDT_Pad "pad" > +#define RASDT_Generic "GENERIC" > +#define RASDT_Serial "SERIAL" > +#define RASDT_FrameRelay "FRAMERELAY" > +#define RASDT_Atm "ATM" > +#define RASDT_Sonet "SONET" > +#define RASDT_SW56 "SW56" > +#define RASDT_Irda "IRDA" > +#define RASDT_Parallel "PARALLEL" > +/* Windows XP values. And above? */ > +#define RASDT_PPPoE "PPPoE" > > #define RASBASE 600 > #define ERROR_BUFFER_TOO_SMALL (RASBASE+3) bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: advapi32: Fix prototypes for StartServiceCtrlDispatcher[AW]
by Francois Gouget 31 Jan '07

31 Jan '07

On Wed, 31 Jan 2007, Bang Jun-Young wrote: > Please ignore this patch. There are subtle differences between GCC and MSC I didn't > notice at the moment of producing this patch. It would be better to keep it local > in my own repos. ;-) [...] > > -BOOL WINAPI StartServiceCtrlDispatcherA( LPSERVICE_TABLE_ENTRYA servent ) > > +BOOL WINAPI StartServiceCtrlDispatcherA(CONST LPSERVICE_TABLE_ENTRYA servent) Maybe your troubles come from the fact that this should be: BOOL WINAPI StartServiceCtrlDispatcherA(CONST SERVICE_TABLE_ENTRYA* servent) The former means that you are not allowed to modify the servent pointer, while the latter means you are not allowed to modify the structure pointed to by servent. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ f u kn rd ts, ur wy 2 gky 4 ur wn gd.

1 0

Re: Patch for Bugzilla Bug 6323
by Dmitry Timoshkov 31 Jan '07

31 Jan '07

"Dean Kusler" <deankus(a)gmail.com> wrote: > In dlls/winex11.drv/keyboard.c, XmbLookupString was being called with > KeyRelease events, which has undefined behavior (in this case, it fails to > return a valid keysym for numpad key releases). By instead calling > XLookupString in the case of a KeyRelease, we can obtain a valid keysym. While reviewing your patch in bugzilla I overlooked that you have added a check for (e.type == KeyPress) X11DRV_ToUnicodeEx as well. There is no need for that, we explicitly set e.type = KeyPress there. -- Dmitry.

2 1

Re: Test for LoadString
by Dmitry Timoshkov 31 Jan '07

31 Jan '07

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Add tests for LoadString, completed on Windows. > > As I see, > 1. LoadStringA with buf = NULL segfaults in Windows, we have to produce ERR > message instead > 2. LoadStringA with buf = NULL, buflen = 0 returns -1 > 3. LoadStringW with some buf, buflen = 0 returns length of the resource string > and puts some strange chars (F%O f.i.) in the buffer. > 4. LoadStringW with buf = NULL, buflen!=0 returns 0 > 5. LoadStringA/W segfaults on negative buflen Unfortunately the tests don't show whether last error value should be set in the case of a failure or not, please add that as well. -- Dmitry.

1 0

Re: Do not use LoadStringW for get strlen of resource string
by James Hawkins 30 Jan '07

30 Jan '07

On 1/30/07, Vitaly Lipatov <lav(a)etersoft.ru> wrote: > As LoadStringW(...NULL,0) returns length of resource string only in Wine, > rewrote this part in independent manner. > > Changelog: > - do not use LoadStringW for get strlen of resource string > This is wrong: > @@ -75,15 +75,16 @@ static LPWSTR HH_ANSIToUnicode(LPCSTR an > /* Loads a string from the resource file */ > static LPWSTR HH_LoadString(DWORD dwID) > { > - LPWSTR string = NULL; > + WCHAR buf[1024]; > + LPWSTR string; > int iSize; > > - iSize = LoadStringW(hhctrl_hinstance, dwID, NULL, 0); > + iSize = LoadStringW(hhctrl_hinstance, dwID, buf, sizeof(buf)/sizeof(buf[0])); > iSize += 2; /* some strings (tab text) needs double-null termination */ > > string = HeapAlloc(GetProcessHeap(), 0, iSize * sizeof(WCHAR)); > LoadStringW(hhctrl_hinstance, dwID, string, iSize); > - > + string[iSize] = 0; /* add second null termination */ > return string; > } Why are you adding string[iSize] = 0...? This is an internal wrapper around LoadString that makes no promises about double-null termination, etc. Don't make assumptions. Also, you need to keep the style of the original code when making changes. There was an empty line where you added the aforementioned pieced of code, and that empty line separates logically different pieces of the function. 1024 is a magic number and it needs to go. You're putting a limitation of 1024 length on HH_LoadString that didn't exist before. -- James Hawkins

1 0

Re: [PATCH 7/7] server/kernel32: Marshal security descriptor to server for a new process.
by Mirek 30 Jan '07

30 Jan '07

Hi, i cant compile wine with this patch, do you know why? gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o regsvr.o regsvr.c make[2]: Leaving directory `/root/.WineCVS/sources/cvswine/wine/dlls/mmdevldr.vxd' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_KERNEL32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o profile.o profile.c process.c: In function ‘create_process’: process.c:1314: error: ‘struct new_process_request’ has no member named ‘sd_len’ process.c:1318: error: ‘struct new_process_request’ has no member named ‘sd_len’ process.c:1320: error: ‘struct new_process_request’ has no member named ‘sd_len’ process.c:1322: error: ‘struct new_process_request’ has no member named ‘sd_len’ process.c:1323: error: ‘struct new_process_request’ has no member named ‘sd_len’ process.c:1325: error: ‘struct new_process_request’ has no member named ‘sd_len’ process.c:1327: error: ‘struct new_process_request’ has no member named ‘sd_len’ make[2]: *** [process.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Entering directory `/root/.WineCVS/sources/cvswine/wine/dlls/monodebg.vxd' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o monodebg.o monodebg.c ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./monodebg.vxd.spec monodebg.o -o monodebg.vxd.so -lkernel32 ../../libs/port/libwine_port.a ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./mlang.spec mlang.o regsvr.o -o mlang.dll.so -loleaut32 -lole32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -Wb,-doleaut32 -luuid ../../libs/port/libwine_port.a make[2]: Leaving directory `/root/.WineCVS/sources/cvswine/wine/dlls/kernel32' make[1]: *** [kernel32] Error 2 make[1]: *** Waiting for unfinished jobs.... make[2]: Leaving directory `/root/.WineCVS/sources/cvswine/wine/dlls/mlang' make[2]: Leaving directory `/root/.WineCVS/sources/cvswine/wine/dlls/monodebg.vxd' make[1]: Leaving directory `/root/.WineCVS/sources/cvswine/wine/dlls' make: *** [dlls] Error 2 Mirek Vitaliy Margolen napsal(a): > We are limited to only 5 server data calls. Here it would have been 7. > And possibly 12 in the future. Hence decision to send self-relative > SECURITY_DESCRIPTOR. > --- > dlls/kernel32/process.c | 25 +++++++++++++++++++++++++ > server/process.c | 8 ++++++-- > server/protocol.def | 2 ++ > 3 files changed, 33 insertions(+), 2 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 8cdcd72..463071d 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -1277,6 +1277,8 @@ static BOOL create_process( HANDLE hFile > > SERVER_START_REQ( new_process ) > { > + PSECURITY_DESCRIPTOR p_sd = NULL; > + > req->inherit_all = inherit; > req->create_flags = flags; > req->socket_fd = socketfd[1]; > @@ -1303,6 +1305,27 @@ static BOOL create_process( HANDLE hFile > if (is_console_handle(req->hstderr)) req->hstderr = console_handle_unmap(req->hstderr); > } > > + /* marshal security descriptor */ > + if (psa && psa->lpSecurityDescriptor) > + { > + SECURITY_DESCRIPTOR_CONTROL control; > + DWORD revision; > + > + req->sd_len = RtlLengthSecurityDescriptor( psa->lpSecurityDescriptor ); > + RtlGetControlSecurityDescriptor( psa->lpSecurityDescriptor, &control, &revision ); > + > + if (control & SE_SELF_RELATIVE) > + wine_server_add_data( req, psa->lpSecurityDescriptor, req->sd_len ); > + else > + if ((p_sd = HeapAlloc( GetProcessHeap(), 0, req->sd_len ))) > + { > + RtlMakeSelfRelativeSD( psa->lpSecurityDescriptor, p_sd, &req->sd_len ); > + wine_server_add_data( req, p_sd, req->sd_len ); > + } > + else req->sd_len = 0; > + } > + else req->sd_len = 0; > + > wine_server_add_data( req, params, params->Size ); > wine_server_add_data( req, params->Environment, (env_end-params->Environment)*sizeof(WCHAR) ); > if ((ret = !wine_server_call_err( req ))) > @@ -1313,6 +1336,8 @@ static BOOL create_process( HANDLE hFile > info->hThread = reply->thandle; > } > process_info = reply->info; > + > + HeapFree( GetProcessHeap(), 0, p_sd ); > } > SERVER_END_REQ; > > diff --git a/server/process.c b/server/process.c > index 1c53f49..21dd8cb 100644 > --- a/server/process.c > +++ b/server/process.c > @@ -820,6 +820,7 @@ DECL_HANDLER(new_process) > struct thread *thread; > struct process *process; > struct process *parent = current->process; > + const SECURITY_DESCRIPTOR *p_sd = get_req_data(); > int socket_fd = thread_get_inflight_fd( current, req->socket_fd ); > > if (socket_fd == -1) > @@ -841,14 +842,14 @@ DECL_HANDLER(new_process) > info->hstderr = req->hstderr; > info->exe_file = NULL; > info->process = NULL; > - info->data_size = get_req_data_size(); > + info->data_size = get_req_data_size() - req->sd_len; > info->data = NULL; > > if (req->exe_file && > !(info->exe_file = get_file_obj( current->process, req->exe_file, FILE_READ_DATA ))) > goto done; > > - if (!(info->data = memdup( get_req_data(), info->data_size ))) goto done; > + if (!(info->data = memdup( (char*)get_req_data() + req->sd_len, info->data_size ))) goto done; > > if (!(thread = create_process( socket_fd, current, req->inherit_all ))) goto done; > process = thread->process; > @@ -900,6 +901,9 @@ DECL_HANDLER(new_process) > reply->phandle = alloc_handle( parent, process, req->process_access, req->process_attr ); > reply->thandle = alloc_handle( parent, thread, req->thread_access, req->thread_attr ); > > + if (req->sd_len) > + set_object_sd( &process->obj, p_sd, OWNER_SECURITY_INFORMATION | GROUP_SECURITY_INFORMATION | > + SACL_SECURITY_INFORMATION | DACL_SECURITY_INFORMATION ); > done: > release_object( info ); > } > diff --git a/server/protocol.def b/server/protocol.def > index f49f331..9ebbcbc 100644 > --- a/server/protocol.def > +++ b/server/protocol.def > @@ -436,6 +436,8 @@ typedef union > unsigned int process_attr; /* attributes for process object */ > unsigned int thread_access; /* access rights for thread object */ > unsigned int thread_attr; /* attributes for thread object */ > + data_size_t sd_len; /* length of process' security descriptor */ > + VARARG(sd,bytes,sd_len); /* process' security descriptor to set */ > VARARG(info,startup_info); /* startup information */ > VARARG(env,unicode_str); /* environment for new process */ > @REPLY > > > > ------------------------------------------------------------------------ > >

2 1

Re: Test case for Bug 50 [Was: Bug 50]
by Pedro Araujo Chaves Jr. 30 Jan '07

30 Jan '07

On 2007-01-29, Duane Clark wrote: > GetTextExtentPoint32 > > For some examples in Wine, look at almost any control in comctl32. I was afraid somebody would answer that... Thanks for the quick reply, but that isn't exactly what I need. Here's the picture: when an application calls TextOut() for printing text, the usual (at least in my case) call sequence in Wine is TextOut() TextOutA() ExtTextOutA() ExtTextOutW() (the one I patched) GetTextExtentPointW() GetTextExtentPoint32W() (the wide-char version of the one you mentioned) GetTextExtentExPointW() WineEngGetTextExtentExPoint() (the one that actually gets the individual character widths) That is, at some point, TextOut() indirectly uses GetTextExtentPoint32() to get the dimensions, okay. But what I need is to check the text width *after* it was output by TextOut() -- in other words, after the function has returned, to see if it output the text properly. In Wine, I tried the trick of making ExtTextOutW() return the said value, and the tests passed without a hitch, which means the text is being properly justified. The problem is that such is not an acceptable way of doing things, and, to use Dan Kegel's words, that is not going to fly on Windows. To be a bit clearer, in my tests I do call GetTextExtent32() in order to compute the remaining white space for the justification part, and what I want to check is whether TextOut() understood it right or not. - Pedro.

2 2

Re: [msvcrt] stat64 (1/3) add declarations for stat64, fstat64 and wstat64
by Francois Gouget 30 Jan '07

30 Jan '07

On Tue, 30 Jan 2007, Damjan Jovanovic wrote: > Changelog: > * Added declarations for stat64, fstat64 and wstat64 --- a/include/msvcrt/sys/stat.h 2006-11-24 18:18:04.000000000 +0200 +++ b/include/msvcrt/sys/stat.h 2007-01-28 15:48:28.000000000 +0200 @@ -104,6 +104,20 @@ +struct __stat64 { + _dev_t st_dev; + _ino_t st_ino; + unsigned short st_mode; + short st_nlink; + short st_uid; + short st_gid; + _dev_t st_rdev; + __int64 st_size; + __time64_t st_atime; + __time64_t st_mtime; + __time64_t st_ctime; +}; This structure is called _stat64 in Visual Studio 2005. Has it changed in more recent versions? If not I would stick to it otherwise Windows code that uses 'struct _stat64' would fail to compile with Winelib. [...] +int _fstat64(const char*,struct __stat64*); +int _stat64(int,struct __stat64*); You have reversed the _fstat64() and _stat64() prototypes. --- a/include/msvcrt/sys/types.h 2006-11-24 18:18:04.000000000 +0200 +++ b/include/msvcrt/sys/types.h 2007-01-28 14:23:09.000000000 +0200 @@ -56,6 +56,11 @@ +#ifndef _TIME64_T_DEFINED +typedef __int64 __time64_t; +#define _TIME64_T_DEFINED +#endif I'd write it as below but that's purely an aesthetic thing (I like how the #ifndef and the #define line up): +#ifndef _TIME64_T_DEFINED +#define _TIME64_T_DEFINED +typedef __int64 __time64_t; +#endif -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

1 0

Re: [ws2_32] INET_ADDRSTRLEN (1/2) add INET_ADDRSTRLEN and INET_ADDRSTRLEN6
by Francois Gouget 30 Jan '07

30 Jan '07

On Tue, 30 Jan 2007, Damjan Jovanovic wrote: > Changelog: > * Added INET_ADDRSTRLEN and INET_ADDRSTRLEN6 defines. > > --- a/include/ws2tcpip.h 2006-11-24 18:18:04.000000000 +0200 > +++ b/include/ws2tcpip.h 2007-01-26 21:14:25.000000000 +0200 > @@ -204,6 +204,9 @@ > # define WS_EAI_SOCKTYPE WSAESOCKTNOSUPPORT > #endif > > +#define INET_ADDRSTRLEN 16 > +#define INET6_ADDRSTRLEN 46 The PSDK says that the values for these are respectively 22 and 65. Also the latest PSDK defines these in ws2ipdef.h which is a new header which is included from ws2tcpip.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

1 0

Re: Make.rules.in: Generate better output
by Francois Gouget 30 Jan '07

30 Jan '07

On Tue, 30 Jan 2007, Bang Jun-Young wrote: > It's quite annoying to see tons of ugly "gcc -I. -I. -I../../include > -I../../include" > on the screen during build and in the log file thereafter, so... [...] > +ifeq ($(TOPSRCDIR),$(TOPOBJDIR)) > +ifeq ($(SRCDIR),.) > +INCLUDES = -I. -I$(TOPSRCDIR)/include $(EXTRAINCL) 'ifeq' is a GNU Make extension and thus the policy is to avoid it, especially for purely cosmetic issues. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

1 0

Another report of malware running on Wine
by Dan Kegel 30 Jan '07

30 Jan '07

A user reports that a trojan horse runs ok on wine, and indeed it had him fooled (right up to the point where it popped up a window offering to optimize his registry, anyway): http://www.postproductie.nl/?p=9

2 1

Please help me debug wineserver
by Misha Koshelev 29 Jan '07

29 Jan '07

Hi, I am new to wine programming but have a fair amount of experience with C/C++ programming in general. I have recently decided to make the Vector NTI application work on Wine, and after overcoming quite a few installation difficulties by making an install shell script, I have run in to a problem that I have traced down to wineserver. This problem occurs after repeatedly changing folders in the Vector NTI "Open Molecule File" dialog, which does not use the standard open file Windows dialog (e.g., the "Open Shortcut" dialog in the same program works fine). Wineserver crashes with the following error message: wineserver: object.c:274: release_object: Assertion `obj->refcount' failed. On looking at the output of WINEDEBUG=+server, it seems that the "Vector NTI" thread is woken up, and then receives a USER_APC, at which time this crash occurs. I am including at the end of this message a wineserver gdb backtrace and the last few lines of the WINEDEBUG=+server output. If anyone sees anything that jumps out, I would appreciate your help. Thank you very much. Misha --- Backtrace: #0 0xffffe410 in __kernel_vsyscall () #1 0xb7d56770 in raise () from /lib/tls/i686/cmov/libc.so.6 #2 0xb7d57ef3 in abort () from /lib/tls/i686/cmov/libc.so.6 #3 0xb7d4fdbb in __assert_fail () from /lib/tls/i686/cmov/libc.so.6 #4 0x0805ad0a in release_object (ptr=0x83ad0a0) at object.c:274 #5 0x0806c196 in end_wait (thread=0x83ad100) at thread.c:451 #6 0x0806c9b7 in wake_thread (thread=0x83ad100) at thread.c:578 #7 0x0806cddd in queue_apc (process=<value optimized out>, thread=0x83ad100, apc=0x83ad888) at thread.c:751 #8 0x0806cebb in thread_queue_apc (thread=0x83ad100, owner=0x0, call_data=0xbffe77b8) at thread.c:764 #9 0x08052dc2 in async_terminate (async=0x82e7780, status=6) at fd.c:1294 #10 0x0804bf70 in dir_destroy (obj=0x83ad0a0) at file.h:131 #11 0x0805ac9a in release_object (ptr=0x83ad0a0) at object.c:279 #12 0x0806c196 in end_wait (thread=0x83ad100) at thread.c:451 #13 0x0806cf30 in thread_timeout (ptr=0x83aa1c0) at thread.c:598 #14 0x08051e3a in get_next_timeout () at fd.c:688 #15 0x08052ea0 in main_loop () at fd.c:456 #16 0x08057c4a in main (argc=2, argv=0xbffe8034) at main.c:136 Last few lines of WINEDEBUG=+server output: 0009: create_key() = 0 { hkey=0x168, created=0 } 0009: get_key_value( hkey=0x168, name=L"Desktop" ) 0009: get_key_value() = 0 { type=2, total=44, data={25,00,55,00,53,00,45,00,52,00,50,00,52,00,4f,00,46,00,49,00,4c,00,45,00,25,00,5c,00,44,00,65,00,73,00,6b,00,74,00,6f,00,70,00,00,00} } 0009: create_key( parent=0x6c, access=000f003f, attributes=00000000, options=00000000, modif=0, namelen=112, name=L"Software\\Microsoft\\Windows NT\\CurrentVersion\\ProfileList", class=L"" ) 0009: create_key() = 0 { hkey=0x16c, created=0 } 0009: get_key_value( hkey=0x16c, name=L"ProfilesDirectory" ) 0009: get_key_value() = 0 { type=2, total=40, data={63,00,3a,00,5c,00,77,00,69,00,6e,00,64,00,6f,00,77,00,73,00,5c,00,70,00,72,00,6f,00,66,00,69,00,6c,00,65,00,73,00,00,00} } 0011: *wakeup* signaled=258 STATUS_TIMEOUT cookie=0x7bbfe880 0011: *wakeup* signaled=192 STATUS_USER_APC cookie=0x7bbfe880 wineserver: object.c:274: release_object: Assertion `obj->refcount' failed.

1 0

Re: Test case for Bug 50 [Was: Bug 50]
by Pedro Araujo Chaves Jr. 29 Jan '07

29 Jan '07

I think I've managed to patch [1] bug 50 [2], but I'm having a little trouble coming up with a proper test case... I'm already at it, studying and investigating, but could someone test that, too? [1] http://bugs.winehq.org/attachment.cgi?id=4543&action=view [2] http://bugs.winehq.org/show_bug.cgi?id=50 TIA, - Pedro.

2 3

Re: DirectPlay should initialize The session guid when creating a session
by Tomas Carnecky 29 Jan '07

29 Jan '07

Alessandro Pignotti wrote: > Hi, > this is my first patch i hope it's well formatted formating is good. > From Microsoft DirectX SDK Documentation it seems that directplay should > initialize the instance guid on session creation, this trivial patch does > that. Two questions: 1. Does windows do this, too? You can't rely on the MS SDK Documentation, always look what windows does and do it likewise. In many cases, a wine test should be written to verify the behavior. 2. Does it solve anything? A bug, a problem with an application? tom

3 2

Wine study
by TRENY Simon 29 Jan '07

29 Jan '07

Hello guys :) We are a team of French students (at ENSEIRB, an engineering school in Bordeaux), and we are studying the Wine project as an example of open source project. We'd like to find out more about how things work from the inside, from any developer's point of view. So we have compiled here our main questions for those who are willing to help us.. Feel free to answer further than the actual question, we are looking for a real insight! :) Sorry in advance for those who are not interested, you can just skip this mail ;) -First, what is the nick under which u commit ? -What is your role in the Wine project? -Which country do u code from? -Who are the programmers you consider to be the "core" of the project? -Who are those you actually ask for help when you need some (e.g. about compatibility issues)? -Do you use means of communicating with the rest of the devs other than irc and the mailing lists? Do you find it (irc and MLs) entirely suited to your needs? -When there is a decision concerning the whole team you wish to see taken, how do u see to that? -Have you developed links with some devs that go beyond working on the same project? -How much time do you spend doing Wine developing (per week and per day, depending on the day)? -What do you do aside from Wine? -When, why and how did you join the Wine project? -Is there any recurrent problem you find to be responsible of unnecessary extra work/loss of time for you or the team? Well, thanks for reading, and greater thanks for answering us if you do.. :) Best regards

1 0

kernel32: allow profile section and key names of zero length
by Claudio Fontana 29 Jan '07

29 Jan '07

Hello, following up on the profile changes started on this thread: http://www.winehq.org/pipermail/wine-devel/2006-December/053009.html I tried a patch in git format made against latest. First attempt at using git, that is. dlls/kernel32/profile.c: allow section and key names of zero length dlls/kernel32/tests/profile.c: add testcases where KEY or SECTION are "". Note: still requires testing on a real Windows 95, to determine if that version behaves differently. If you have access to a Windows 95 installation, please help by applying this patch and: [optional] * run the updated tests in wine (all should pass) * revert changes in dlls/kernel32/profile.c, and run the updated tests in wine (the two new tests should fail) [important] * run the updated test program under a real Windows 95. If tests pass, then Windows 95 behaves exactly the same as later versions. If tests do not pass, then Windows 95 is indeed different, and this patch should be modified accordingly. --- dlls/kernel32/profile.c | 10 ++-------- dlls/kernel32/tests/profile.c | 8 ++++++-- 2 files changed, 8 insertions(+), 10 deletions(-)

1 0

Vacations
by Alexandre Julliard 28 Jan '07

28 Jan '07

Folks, I'm going skiing for a week, so don't be surprised if there aren't any new commits for a while. Now all I need is some snow... -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: USER32: resource.c: add LoadStringW description
by Dmitry Timoshkov 27 Jan '07

27 Jan '07

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Changelog: > Add description for LoadStringW > + * Can be called with buffer = NULL for get size of the requested string That LoadString behaviour in Wine has been questioned already, MSDN keeps silence about that, it needs at least a test case. -- Dmitry.

1 0

Re: [cmd][buildins] Change output resource strings for correctlydisplayed
by Dmitry Timoshkov 27 Jan '07

27 Jan '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- programs/cmd/builtins.c 23 Jan 2007 12:20:55 -0000 1.5 > +++ programs/cmd/builtins.c 26 Jan 2007 09:23:05 -0000 > @@ -44,6 +44,13 @@ struct env_stack > WCHAR *strings; > }; > > +static inline unsigned int strlenW( const WCHAR *str ) > +{ > + const WCHAR *s = str; > + while (*s) s++; > + return s - str; > +} Please use normal lstrlenW instead of introducing a handmade version. -- Dmitry.

1 0

Re: scroll window fix
by Peter Oberndorfer 26 Jan '07

26 Jan '07

On Thursday 25 January 2007 18:56, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still falls > within the clipping rect. This generates an additional update region > that needs > to be invalidated. > includes a test Hi, I can't argue about the correctness of the patch itself but it adds tabs and a few trailing spaces. Greetings Peter > --- > dlls/user32/painting.c | 21 +++++++++++++++++++++ > dlls/user32/tests/win.c | 9 +++++++++ > 2 files changed, 30 insertions(+), 0 deletions(-) >

2 1

Re: [PATCH 1/4] widl: Handle TKIND_DISPATCH when generating MSFT typelibs.
by Huw Davies 26 Jan '07

26 Jan '07

On Fri, Jan 26, 2007 at 09:13:52PM +0900, Mike McCormack wrote: > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index 6248c80..576601b 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -126,6 +126,8 @@ typedef struct _msft_typeinfo_t > } msft_typeinfo_t; > > > +static void add_dispinterface_typeinfo(msft_typelib_t *typelib, type_t *dispinterface); Could you move that so it's with all the other forward declarations of add_*_typeinfo funcs (or move all the others to be with this one)? Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Initial MIDI Out support on Mac OS X
by Emmanuel Maillard 26 Jan '07

26 Jan '07

Hi, anything wrong with this patch : http://www.winehq.org/pipermail/wine- patches/2007-January/035027.html thanks Emmanuel

1 0

Is anyone monitoring Transgaming's changes to the LGPL files?
by Scott Ritchie 26 Jan '07

26 Jan '07

I don't know when it started, but Transgaming has been using LGPL chunks of Wine for quite some time. As they're required to, they've released the source for these files, along with whatever changes they've made. However, they're not required to tell us what they did, to send us patches, or to even let us know they've made a change. What this means is that it's possible, even likely, that Transgaming has improved the LGPL parts of Cedega in some important way that would be useful to Wine as well, without us having even known about it. The simplest thing to do is for someone to just track the code they release and diff it against our own stuff, and note if anything new and interesting (eg an implementation of a function) comes up. Then send in a patch if it seems like it could help us too. But, is anyone doing this? Thanks, Scott Ritchie

3 4

make crosstest broken (tmarshal)
by Stefan Leichter 25 Jan '07

25 Jan '07

Hello, the tmarshal tests broke cross compiling. Compiling fails for me with i586-mingw32msvc-gcc -c -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o tmarshal.cross.o ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:28:22: tmarshal.h: Datei oder Verzeichnis nicht gefunden ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: type defaults to `int' in declaration of `IWidgetVtbl' ../../../../wine-git/dlls/oleaut32/tests/tmarshal.c:218: warning: no semicolon at end of struct or union ... make[2]: *** [tmarshal.cross.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-mingw/dlls/oleaut32/tests' make[1]: *** [oleaut32/tests/__crosstest__] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-mingw/dlls' make: *** [dlls/__crosstest__] Fehler 2 The problem is related to the fact that i'm doing out of tree builds. Therefore i have three directories: 1. wine-git : the source tree 2. wine-build : the normal build (unix) 3. wine-mingw : the cross compile build The missing tmarshal.h file is in wine-build/dlls/oleauth32/tests Bye Stefan

4 8

Patch to make X11DRV_GetAsyncKeyState work for TacOps
by Martin Cracauer 25 Jan '07

25 Jan '07

The appended patch against the CVS version fixes one issue for me. The game "TacOps" (a standalone 2D wargame, not to be mixed up with the Unreal mod "Tac Ops") uses home-grown scrollbars. They have autorepeat, that means holding the mouse button on the "down" or "up" icons will continue to scroll until you release the button. Without the appended patch Wine will never notice when you release the mouse button. That effectively means an application hang since you can never do anything else anymore, as the game continue to execute "down" autorepeat. To reproduce, download the demo at http://www.battlefront.com/products/tacops4/demo.html . Set up your units as per the instructions (place from floating window into the grey box). The scrollbars in question are under artillery support and under air support. Clicking on the up/down icons in the scrollbars will hang the application without the patch and will work with the patch. Please mail me if you want a better walkthrough. In case the patch attachment gets stripped by the list I put a copy of the patch here: http://www.cons.org/cracauer/wine-tacops-2.diff Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer <cracauer(a)cons.org> http://www.cons.org/cracauer/ FreeBSD - where you want to go, today. http://www.freebsd.org/

2 2

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols
by Dmitry Timoshkov 25 Jan '07

25 Jan '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- dlls/kernel32/tests/locale.c 5 Jan 2007 19:37:02 -0000 1.8 > +++ dlls/kernel32/tests/locale.c 24 Jan 2007 14:15:14 -0000 > @@ -35,6 +35,9 @@ > #include "winerror.h" > #include "winnls.h" > > +#include "locale.h" > +#include "tables_CP1251.h" I'd suggest to test specific strings instead of auto-generated tables. Since microsoft apparently uses their own unicode tables that differ from unicode.org ones that's almost impossible to get the exactly same behaviour among Wine and Windows. > +static int compare_string2_non_latin(const void *e1, const void *e2) > +{ > + const char *s1 = (char *)e1; > + const char *s2 = (char *)e2; > + > + return CompareStringA(LOCALE_USER_DEFAULT,0,s1,1, s2,1) - 2; > +} You need to directly specify the locale id, otherwise the test won't pass on a system with different user default locale (like the Alexandre's one). -- Dmitry.

2 2

Debian Etch package
by Paavo Pokkinen 25 Jan '07

25 Jan '07

Hi, I would like to maintain latest Debian Etch(to-be-stable in about month) packages for wine. The download page says "If you can help provide up-to-date Debian packages, please contact Scott Ritchie", but I already contacted, maybe month ago. Didn't get any answer. The debs are located http://blitzkrieg.homelinux.org/~paveq/wine/ I got enough bandwith(10Mb) to host them myself. Comments? -- Paavo Pokkinen paveq2(a)gmail.com

3 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel