- wine-devel - winehq.org

Re: [PATCH] PATCH: kernel 2.6 in README.de
by n0dalus 15 Sep '06

15 Sep '06

On Wed Sep 13 10:57:33 2006 +0200, Marcus Meissner <marcus(a)beiboot.franken.de> wrote: > Mention kernel 2.6. > > --- > > documentation/README.de | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > 10857c3dbb8429ea599288ac93f4cecd8ffeff59 > diff --git a/documentation/README.de b/documentation/README.de > index c4a1324..680e077 100644 > --- a/documentation/README.de > +++ b/documentation/README.de > @@ -45,7 +45,7 @@ Linux-Info: > Obwohl Linux 2.2.x immer noch funktionieren sollte und Linux 2.0.x > vielleicht auch noch funktioniert (ältere 2.0.x-Versionen verzeichneten > Abstürze im Zusammenhang mit Threads), sollte man am besten einen > - aktuellen Kernel wie 2.4.x verwenden. > + aktuellen Kernel wie 2.4.x oder 2.6.x verwenden. > > FreeBSD-Info: > Stellen Sie sicher, dass Sie die Optionen USER_LDT, SYSVSHM, SYSVSEM und > -- > 1.2.4 > > > Hi, A few of the emails you've sent to the wine-patches mailing list lately have not had 'To:' headers. Many people have their mail clients configured to filter emails into folders based on 'To:' fields, so it would be great if you could sort that out (your last few ones, such as this one, ended up in my inbox instead of my wine folder). It probably means that whatever program you are using to send these emails is broken slightly. I hope you are able to work it out, n0dalus.

5 5

Troubles using current wine (wine-0.9.21)
by Louis. Lenders 15 Sep '06

15 Sep '06

Hi, i'm having lots of troubles running games with current git. First of all i get these messages running every application i try: "err:wgl:has_opengl glx_version as 1.3 and GLX_SGIX_fbconfig extension is unsupported. Expect problems." Is it really that bad to not have glx_version 1.3? I have Ati radeon 9600 and i do not know if this is supported on my card anyway. Further, games that used to work now crash, for example Serious Sam I. The problem seems to be: 000f:Call gdi32.ChoosePixelFormat(000004f0,0033fc38) ret=004c70b9 000f:Call winex11.drv.ChoosePixelFormat(001aab78,0033fc38) ret=605c1358 trace:seh:raise_exception code=c0000005 flags=0 addr=(nil) --> crash Any hints on this? --------------------------------- Try the all-new Yahoo! Mail . "The New Version is radically easier to use" The Wall Street Journal

4 3

Re: advapi32, msi, rsaenh: MD4_CTX and MD5_CTX have the same elements, declare them in the same order.
by Hans Leidekker 15 Sep '06

15 Sep '06

On Thursday 14 September 2006 11:13, Kai Blin wrote: > MD4_CTX and MD5_CTX have the same elements, declare them in the same order. Tell Microsoft about it ;-) Your patch breaks the md5 test on Windows because it depends on the struct layout: crypt_md5.c:90: Test failed: invalid initialization crypt_md5.c:93: Test failed: update doesn't work correctly crypt_md5.c:96: Test failed: update doesn't work correctly crypt_md5: 5 tests executed, 0 marked as todo, 3 failures. -Hans

3 5

OpenGL multiplexing and Wine
by Molle Bestefich 15 Sep '06

15 Sep '06

A couple of OpenGL multiplexers for Xen (and VMWare, theoretically) exists: http://www.cs.toronto.edu/~andreslc/xen-gl/ http://www.diku.dk/hjemmesider/ansatte/jacobg/gfx/ They allow guest virtual machines to render 3D graphics using the host machine's graphics accelerator. I think they are very interesting in combination with Wine, because Wine can let Direct3D games run on top of OpenGL, making the multiplexers work for all modern games, whereas running a real Microsoft Windows guest would only allow acceleration for some games. There's a list of supported XGL versions and GL calls on this page under "Capabilities": http://www.cs.toronto.edu/~andreslc/xen-gl/ And a couple of whitepapers here: http://www.diku.dk/~jacobg/blink-techreport.pdf http://www.diku.dk/~jacobg/blink2.pdf Will WineGL run on top of a multiplexer, or does it lack support of some calls?

3 2

rpcrt4 questions
by Damjan Jovanovic 15 Sep '06

15 Sep '06

1. I was surprised to discover DCE RPCs (as opposed to DCOM) from wine to Windows do work. Is this documented anywhere? 2. Is there any reason why rpc_transport.c uses native sockets instead of winsock? 3. Would a patch to fix (2) be welcome? With a few more changes, it would also allow an RPC server to run on wine, as opposed to the current case where only clients work. Thank you Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: wine 0.9.21 - World of warcraft appears to be broken on ATI hardware ? crashes with Blizzard critical error
by Nick Law 15 Sep '06

15 Sep '06

Vitaliy Margolen wrote: > Nick Law wrote: > >> I'm having the same problems with 0.9.21 here, World of Warcraft is >> broken, no longer runs at all on ATI hardware, (confirmed on two >> separate systems running with ATO 9550. (maybe ok on Nvidia hardware >> although not tried it myself). >> >> > Nick please open a bug in bugzilla, and do proper regression testing. > > Vitaliy. > > ok, I'll see what I can do over the next few days. Nick

1 0

Re: TRY 2: Socket resets randomly
by Vitaliy Margolen 15 Sep '06

15 Sep '06

Ryan Miller wrote: > ws2_32: Fixed bug with sockets randomly resetting due to GetLastError being > reset by setsockopt in Windows, but not in Wine. Also included is the > associated test. > > + SetLastError(1); Please use more accepted value of 0xdeadbeef Vitaliy

1 0

wine 0.9.21 - World of warcraft appears to be broken on ATI hardware ? crashes with Blizzard critical error
by Nick Law 14 Sep '06

14 Sep '06

I'm having the same problems with 0.9.21 here, World of Warcraft is broken, no longer runs at all on ATI hardware, (confirmed on two separate systems running with ATO 9550. (maybe ok on Nvidia hardware although not tried it myself). Upon trying to start WoW, a Blizzard dialog box appears which contains the following ( see my post http://appdb.winehq.org/appview.php?iVersionId=5606) Here's a summary World of WarCraft (build 5595) Exe: C:\Program Files\World of Warcraft\WoW.exe Time: Sep 14, 2006 10:58:59.684 PM User: guest Computer: linux ------------------------------------------------------------------------------ This application has encountered a critical error: ERROR #132 (0x85100084) Fatal Exception Program: C:\Program Files\World of Warcraft\WoW.exe Exception: 0xC0000005 (ACCESS_VIOLATION) at 0073:00000000 The instruction at "0x00000000" referenced memory at "0x00000000". The memory could not be "read". WoWBuild: 5595 ------------------------------------------------------------------------------ ---------------------------------------- x86 Registers ---------------------------------------- EAX=7C093970 EBX=6103A374 ECX=00000003 EDX=610323CE ESI=00000000 EDI=7C340D00 EBP=0034FAF8 ESP=0034FA9C EIP=00000000 FLG=00210297 CS =0073 DS =007B ES =007B SS =007B FS =003B GS =0033 ---------------------------------------- Stack Trace (Manual) ---------------------------------------- Address Frame Logical addr Module 00000000 0034FAF8 0000:00000000 C:\Program Files\World of Warcraft\WoW.exe 61009DC0 0034FB58 0001:00038DC0 c:\windows\system\winex11.drv 6070C1FF 0034FB88 0001:0003B1FF c:\windows\system\gdi32.dll 0058C0DB 0034FC14 0001:0018B0DB C:\Program Files\World of Warcraft\WoW.exe 0058BF2C 0034FC24 0001:0018AF2C C:\Program Files\World of Warcraft\WoW.exe 0058CAA6 0034FC74 0001:0018BAA6 C:\Program Files\World of Warcraft\WoW.exe 00591B75 0034FC80 0001:00190B75 C:\Program Files\World of Warcraft\WoW.exe 0058C801 0034FCA0 0001:0018B801 C:\Program Files\World of Warcraft\WoW.exe 005896D7 0034FCB4 0001:001886D7 C:\Program Files\World of Warcraft\WoW.exe 00639E73 0034FD20 0001:00238E73 C:\Program Files\World of Warcraft\WoW.exe 004027EC 0034FE68 0001:000017EC C:\Program Files\World of Warcraft\WoW.exe 004021E0 0034FE78 0001:000011E0 C:\Program Files\World of Warcraft\WoW.exe 0040410E 0034FF08 0001:0000310E C:\Program Files\World of Warcraft\WoW.exe 603A6B81 0034FFE8 0001:00055B81 c:\windows\system\kernel32.dll ---------------------------------------- Stack Trace (Using DBGHELP.DLL) ---------------------------------------- 61009DC0 winex11.drv X11DRV_DescribePixelFormat+448 (0x001A9110,0x00000001,0x00000028,0x0034FBDC) (opengl.c,1004) 6070C1FF gdi32.dll DescribePixelFormat+175 (0x0000032C,0x00000001,0x00000028,0x0034FBDC) (painting.c,424) 0058C0DB WoW.exe +0 (0x0034FC74,0x00000000,0x0034FC74,0x0058CAA6) 0058BF2C WoW.exe +0 (0x0034FC3C,0x000002E4,0x011D0F30,0x011D0008) 0058CAA6 WoW.exe +0 (0x0034FCCC,0x0034FCA0,0x0058C801,0x0042CFD0) 00591B75 WoW.exe +0 (0x0042CFD0,0x0034FCCC,0x0034FD04,0x0042CFD0) 0058C801 WoW.exe +0 (0x0042CFD0,0x0034FCCC,0x00000000,0x0034FD20) 005896D7 WoW.exe +0 (0x0034FCCC,0x00401000,0x00000000,0x603D9968) 00639E73 WoW.exe +0 (0x00000001,0x6C726F57,0x666F2064,0x72615720) 004027EC WoW.exe +0 (0x00000001,0x00000001,0x0034FF08,0x0040410E) 004021E0 WoW.exe +0 (0x00409990,0x00400000,0x00000000,0x0011646C) 0040410E WoW.exe +0 (0x7FFDF000,0x00000000,0x00000000,0x00000000) 603A6B81 kernel32.dll start_process+209 (0x00000000,0x00000000,0x00000000,0x00000000) (process.c,822) 60020247 wine_switch_to_stack+23 (0x00000000,0x00000000,0x00000000,0x00000000) ---------------------------------------- Loaded Modules ---------------------------------------- 0x00350000 - 0x003E6000 C:\Program Files\World of Warcraft\fmod.dll 0x00400000 - 0x00D05000 C:\Program Files\World of Warcraft\WoW.exe 0x10000000 - 0x10069000 C:\Program Files\World of Warcraft\DivxDecoder.dll 0x60290000 - 0x602F7000 c:\windows\system\ntdll.dll 0x60350000 - 0x60435000 c:\windows\system\kernel32.dll 0x604B0000 - 0x604E3000 c:\windows\system\advapi32.dll 0x604F0000 - 0x60592000 c:\windows\system\comctl32.dll 0x605B0000 - 0x606B4000 c:\windows\system\user32.dll 0x606D0000 - 0x6073C000 c:\windows\system\gdi32.dll 0x60750000 - 0x60819000 c:\windows\system\shell32.dll 0x60830000 - 0x6086B000 c:\windows\system\shlwapi.dll 0x60880000 - 0x608F2000 c:\windows\system\ole32.dll 0x60900000 - 0x6093E000 c:\windows\system\rpcrt4.dll 0x60950000 - 0x6095B000 c:\windows\system\iphlpapi.dll 0x60960000 - 0x60974000 c:\windows\system\wsock32.dll 0x609A0000 - 0x609B7000 c:\windows\system\ws2_32.dll 0x609D0000 - 0x60A29000 c:\windows\system\opengl32.dll 0x60C00000 - 0x60C14000 c:\windows\system\imm32.dll 0x60D70000 - 0x60DDE000 c:\windows\system\winmm.dll 0x60DF0000 - 0x60E02000 c:\windows\system\msacm32.drv 0x60E10000 - 0x60E63000 c:\windows\system\msvcrt.dll 0x60E70000 - 0x60EA4000 c:\windows\system\wininet.dll 0x60EB0000 - 0x60EC3000 c:\windows\system\mpr.dll 0x60FD0000 - 0x61043000 c:\windows\system\winex11.drv 0x6A250000 - 0x6A27A000 c:\windows\system\wineoss.drv 0x6AEC0000 - 0x6AEE4000 c:\windows\system\uxtheme.dll 0x6AFB0000 - 0x6AFBD000 c:\windows\system\midimap.dll 0x6B1F0000 - 0x6B221000 c:\windows\system\dbghelp.dll 0x6B230000 - 0x6B236000 c:\windows\system\psapi.dll ---------------------------------------- Memory Dump ---------------------------------------- Code: 16 bytes starting at (EIP = 00000000) 00000000: Stack: 1024 bytes starting at (ESP = 0034FA9C) * = addr ** * 0034FA90: 60 86 09 7C DC FB 34 00 F8 FA 34 00 54 5F 00 61 `..|..4...4.T_.a 0034FAA0: 70 39 09 7C 00 00 18 00 0B 80 00 00 E4 FA 34 00 p9.|..........4. 0034FAB0: B4 05 1C 60 00 28 27 60 E4 FA 34 00 E0 FA 34 00 ...`.('`..4...4. 0034FAC0: 34 CC 03 61 CE 23 03 61 27 00 00 00 01 00 00 00 4..a.#.a'....... 0034FAD0: 00 00 00 00 40 FB 34 00 01 00 00 00 70 39 09 7C ....@.4.....p9.| <mailto:....@.4.....p9.%7C> 0034FAE0: 00 00 00 00 00 00 00 00 43 00 00 00 74 A3 03 61 ........C...t..a 0034FAF0: D4 28 04 61 DC FB 34 00 58 FB 34 00 C0 9D 00 61 .(.a..4.X.4....a 0034FB00: 44 FB 34 00 00 00 00 00 48 FB 34 00 4D 4F 00 00 D.4.....H.4.MO.. 0034FB10: 00 B8 72 60 54 FB 34 00 00 B8 72 60 44 FB 34 00 ..r`T.4...r`D.4. 0034FB20: 00 00 00 00 2C 03 00 00 58 FB 34 00 F0 0B 34 7C ....,...X.4...4| 0034FB30: 2C 03 00 00 FF FF 00 00 58 FB 34 00 C9 29 70 60 ,.......X.4..)p` 0034FB40: 00 00 00 00 B8 8F 1A 00 01 00 00 00 28 3C 72 60 ............(

1 0

WM_*UISTATE message implementation in wine
by Vijay Kiran Kamuju 14 Sep '06

14 Sep '06

Hi, Has wine an implementation for WM_*UISTATE messages? Can anybody tell me where should it be implemented and how it should be implemented. Does it involve complex coding? Thanks, VJ

1 1

Re: LOSTWAGES: Update the bus information for WineConf
by Eric Pouech 14 Sep '06

14 Sep '06

Hi Rob, any news about how to get the keys for the room at Reading U ? haven't seen nothing about it ? TIA 2006/9/14, Robert Shearman <rob(a)codeweavers.com>: > > ChangeLog: > Update the bus information for WineConf. > > -- > Rob Shearman > > > > Index: templates/en/wineconf/travel.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/wineconf/travel.template,v > retrieving revision 1.18 > diff -u -p -r1.18 travel.template > --- templates/en/wineconf/travel.template 2 Aug 2006 19:03:42 > -0000 1.18 > +++ templates/en/wineconf/travel.template 14 Sep 2006 13:43:45 -0000 > @@ -48,10 +48,11 @@ depending on your quality and travelling > <li><a href="http://www.nationalexpress.com/">National > Express</a></li> > <li><a href="http://www.reading-buses.co.uk/">Reading Buses</a>: > <ul> > - <li>You will want to take the number 12 bus to get to the > + <li>You will want to take the number 18 or 19 bus to get to > the > university from Reading station. Click here for the > - <a href=" > http://www.reading-buses.co.uk/tt_reading_july2005/012MF20.HTML > ">timetable</a>. > - You can ask the bus driver to let you know where to get > off.</li> > + <a href=" > http://www.reading-buses.co.uk/tt_reading_march2006/018MF31.HTML > ">timetable</a>. > + You should get off at the St Joseph's Convent bus stop, as > this > + is the nearest to Windsor Hall.</li> > </ul> > </ul> > <li>Taxi — around £5 - £10 from Reading Station to > the > > > > > > -- Eric Pouech

1 0

Re: *RESEND* wininet: Make CheckInternetConnection behave like Windows does
by Hans Leidekker 14 Sep '06

14 Sep '06

On Thursday 14 September 2006 14:07, Daniel Skorka wrote: > The function CheckInternetConnection in dlls/wininet/internet.c is too > naive ATM; it just sends a ping to the specified host. Like Mike McCormack suggested in the bug report, UNIX connect() does not deal with a proxy. It would be nice if you could confirm that CheckInternetConnection on Windows ignores a configured proxy, especially since you seem to have access to such a configuration. -Hans

2 1

Re: usp10: Match output of WinXP for ScriptGetProperties.
by Jeff Latimer 14 Sep '06

14 Sep '06

Hans Leidekker wrote: > -Hans > >Changelog > Match output of WinXP for ScriptGetProperties. > Add a test for ScriptGetProperties. > > >------------------------------------------------------------------------ > >+static const SCRIPT_PROPERTIES script_0 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; >+static const SCRIPT_PROPERTIES script_1 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; >+static const SCRIPT_PROPERTIES script_2 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; > > >------------------------------------------------------------------------ > > > > Hans, what is the status of this patch? Looks pretty comprehensive but is unapplied. Are you going pursue it? Jeff

2 1

Re: configure.ac: Do not pass "-fPIC" to mingw for "make crosstest"
by Detlef Riekenberg 14 Sep '06

14 Sep '06

On Mi, 2006-09-13 at 15:23 +0200, Detlef Riekenberg wrote: > When we do a "make crosstest" with mingw32msvc-gcc, > the compiler give a warning about "-fPIC" > > > Changelog: > - configure.ac: Do not pass "-fPIC" to mingw for "make crosstest" > > > Changes for configure are not included. > I crosscompiled the tests, dlls and programs and it still works. > Please ignoge this patch. There are more gcc-only flags, that we use without checking -- By by ... Detlef

1 0

MSI : GetInstallDriver, Can not find InstallDriver in ROT table, Return Code = 0x800401e3
by wino＠piments.com 14 Sep '06

14 Sep '06

Hi, I have a refractory (faulty ?) MSI to deal with . I ran an msi based installer for autosketch today and it all went very well. Thanks for the current progress on MSI. Greatly cheered by this news I returned to one that I have never got to work since trying with 0.9.8 . I always thought it was wine that was not up to speed but it seems there some less than sorted versions of installsheild which give problems on some machines. In fact it may well be ALL Installsheild from v6 to v9. Only the lastest is fixed. I get the following the log file from msi: The InstallScript engine version currently installed on this machine is adequate. Event 'E2716761' is created GetInstallDriver, Can not find InstallDriver in ROT table, Return Code = 0x800401e3 {DDDD0C4B-57F7-4A85-ACF0-DB3FC8F1DBB4} Extract supporting files Failed to extract _IsUser.dll, Ignore it. Failed to extract IGdi.dll, Ignore it. ISMsiServerStartup Failure, Failed to RegisterMsiServer, Error = 0x8000ffff MsiServerStartup failed. Abort installation. Shutting down the PRC server... RPC runtime reported exception 0x6ba Googling parts of that soon shows a known issue , even on windows: http://forums1.itrc.hp.com/service/forums/questionanswer.do?threadId=993353… http://support.installshield.com/kb/view.asp?articleid=Q107249 http://support.installshield.com/kb/view.asp?articleid=Q107182 and specifically : http://www.voicerecognition.com/forums/ubb/Forum1/HTML/002282-2.html symtomatically , when it gets to the stage of copying the files to $TEMP , it seems to create a few zero length files only before failing. So the bug is in InstallSheild but it does not affect all machines. This version _usually_ installs correctly , what remains to be found out is why Wine falls into the broken category and how to work around it. Since I see this is was one area marked in 0.9.21 changelog I thought this may be a good time to bring it to your attention. best regards.

1 0

Re: cabinet: Add breaks to switch statements
by Dan Kegel 13 Sep '06

13 Sep '06

On 9/13/06, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > On Wednesday 13 September 2006 04:22, you wrote: > > Does adding the breaks fix conformance tests? > > No, I haven't fixed anything with this patch: it was a neutral one, in that > respect. I just put it in because I perceived that those switch statements > were not relying on any fallthrough, so I thought it good practice to isolate > the cases. Let's see: your change was --- a/dlls/cabinet/fci.c 2006-09-12 11:55:48.000000000 +0100 +++ b/dlls/cabinet/fci.c 2006-09-12 23:29:02.000000000 +0100 @@ -454,11 +454,12 @@ switch (cb % 4) { case 3: ul |= (((ULONG)(*pb++)) << 16); + break; case 2: ul |= (((ULONG)(*pb++)) << 8); + break; case 1: ul |= *pb++; - default: break; } Offhand that looks like a more serious change than you thought. You'd better either really understand the code, or add a conformance test that shows this fixes a bug, IMHO. - Dan

3 2

Low-level coding
by Aaron Slunt 13 Sep '06

13 Sep '06

Hi, I was interested in starting to play with wine and maybe even build a few functions for it...but then I realized that it's low-level coding, something I'm not familiar with (higher level is more of my expertise). Correct me if I'm wrong, I could be looking at the wrong files :S. Does anyone have any good places to go to to learn about low-level coding, and afterwards coding for wine specifically? Thanks. -- Tired of being hammered by spyware, or want to browse the internet in a whole new way? Download Firefox and enjoy a much better internet experience. http://getfirefox.com/

7 8

Re: cabinet: Add breaks to switch statements
by H. Verbeet 13 Sep '06

13 Sep '06

On 13/09/06, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > Changelog: > cabinet: Add breaks to switch statements. > > diff -urN a/dlls/cabinet/fci.c b/dlls/cabinet/fci.c > --- a/dlls/cabinet/fci.c 2006-09-12 11:55:48.000000000 +0100 > +++ b/dlls/cabinet/fci.c 2006-09-12 23:29:02.000000000 +0100 > @@ -454,11 +454,12 @@ > switch (cb % 4) { > case 3: > ul |= (((ULONG)(*pb++)) << 16); > + break; > case 2: > ul |= (((ULONG)(*pb++)) << 8); > + break; > case 1: > ul |= *pb++; > - default: > break; > } > csum ^= ul; > diff -urN a/dlls/cabinet/fdi.c b/dlls/cabinet/fdi.c > --- a/dlls/cabinet/fdi.c 2006-05-23 13:47:35.000000000 +0100 > +++ b/dlls/cabinet/fdi.c 2006-09-12 23:29:13.000000000 +0100 > @@ -302,9 +302,15 @@ > } > > switch (bytes & 3) { > - case 3: ul |= *data++ << 16; > - case 2: ul |= *data++ << 8; > - case 1: ul |= *data; > + case 3: > + ul |= *data++ << 16; > + break; > + case 2: > + ul |= *data++ << 8; > + break; > + case 1: > + ul |= *data; > + break; > } > csum ^= ul; > I think that's supposed to fall through.

1 0

RTL language support in usp.dll
by Vijay Kiran Kamuju 13 Sep '06

13 Sep '06

Hi, Your patch for RTL support in usp10.dll. http://www.winehq.org/pipermail/wine-patches/2006-September/030571.html Only includes support for Arabic. If you could include for other RTL languages esp Hebrew (other RTL languages are Farsi and Urdu). I think that would be an easy task for you as you know the usp internals. ;) bye, VJ

2 1

Find out which handle corresponds to which window
by David Gümbel 13 Sep '06

13 Sep '06

Hi, - I'm almost sure that question has been asked here before, but I can't seem to find the corresponding post: I am trying to debug an application (Net Support Manager) that has trouble displaying a window in fullscreen mode. NSM enables you (among other things) to remotely look onto somebody else's Desktop, a bit like VNC or NX. It's quite annoying not to be able to look onto that remote desktop in fullscreen mode. Anyway, my guess is that it tries to put itself on top of everything in a wierd way that does not work properly under wine. In order to verify or falsify my guess, it would be extremely helpful to find out which handle corresponds to the window showing the symtoms. I've tried my luck with Process Explorer, but that tool doesn't show me the information I need. Any help is greatly appreciated. Cheers, David

2 4

Re: resend: tools[1/2]: wineprefixcreate: create a freedesktop-enabled menu directory
by Alexandre Julliard 13 Sep '06

13 Sep '06

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > When creating the wineprefix, create a directory for the menu and a > configuration file that enables this menu in the freedesktop.org menu > structure. As suggested on wine-devel the menu directory is a > subdirectory of ~/.wine, so if the user deletes it, all menu items > created there will be automatically removed. > > Is there something wrong with this patch? That sort of desktop-specific code does not belong in wineprefixcreate. I'm not really convinced that this approach to menus is correct, but even if it is, it should be handled by wineshelllink and friends. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20: move some selection code from message handler to ME_SetSelection
by Alexandre Julliard 13 Sep '06

13 Sep '06

"Matt Finnicum" <mattfinn(a)gmail.com> writes: > The special cases handled by EM_EXSETSEL should also be handled by > EM_SETSEL, so this patch moves that code into the common > ME_SetSelection function. Before this patch, sending EM_SETSEL with > any value less than -1 would crash richedit. > > Changelog: move some selection code from message handlers to ME_SetSelection This fails make test: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so editor.c && touch editor.ok editor.c:1335: Test failed: EM_EXSETSEL: expected: 18 actual: 17 make: *** [editor.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

[PATCH] Also show 24bit modes as supported, but still handle them like 32bit later
by Christoph Frick 13 Sep '06

13 Sep '06

hi would someone please comment on that patch? this is a nearly unchanged version of my previous attempt - but this time against current git. --- dlls/winex11.drv/settings.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/dlls/winex11.drv/settings.c b/dlls/winex11.drv/settings.c index 5de07eb..c9bced2 100644 --- a/dlls/winex11.drv/settings.c +++ b/dlls/winex11.drv/settings.c @@ -39,7 +39,8 @@ static LPDDHALMODEINFO dd_modes = NULL; static unsigned int dd_mode_count = 0; static unsigned int dd_max_modes = 0; static int dd_mode_default = 0; -static const unsigned int depths[] = {8, 16, 32}; +static const unsigned int depths[] = {8, 16, 32, 24}; +static const unsigned int nr_depths = sizeof(depths) / sizeof(depths[0]); /* pointers to functions that actually do the hard stuff */ static int (*pGetCurrentMode)(void); @@ -62,7 +63,7 @@ LPDDHALMODEINFO X11DRV_Settings_SetHandl TRACE("Resolution settings now handled by: %s\n", name); if (reserve_depths) /* leave room for other depths */ - dd_max_modes = (3+1)*(nmodes); + dd_max_modes = nr_depths*nmodes; else dd_max_modes = nmodes; @@ -111,7 +112,7 @@ void X11DRV_Settings_AddDepthModes(void) int existing_modes = dd_mode_count; DWORD dwBpp = screen_depth; if (dwBpp == 24) dwBpp = 32; - for (j=0; j<3; j++) + for (j=0; j<nr_depths; j++) { if (depths[j] != dwBpp) { @@ -164,8 +165,6 @@ void X11DRV_Settings_Init(void) */ BOOL X11DRV_EnumDisplaySettingsEx( LPCWSTR name, DWORD n, LPDEVMODEW devmode, DWORD flags) { - DWORD dwBpp = screen_depth; - if (dwBpp == 24) dwBpp = 32; devmode->dmDisplayFlags = 0; devmode->dmDisplayFrequency = 0; devmode->dmSize = sizeof(DEVMODEW); -- 1.4.2

1 0

question about storage32.c code and while loop
by EA Durbin 13 Sep '06

13 Sep '06

I've mentioned this before but I'm no expert C programmer. Can someone explain why we do the following in storage32.c? if (cbRead > 0) { cbTotalRead += cbRead; resWrite = BlockChainStream_WriteAt(bbTempChain, offset, cbRead, buffer, &cbWritten); if (FAILED(resWrite)) break; cbTotalWritten += cbWritten; offset.u.LowPart += This->smallBlockSize; } } while (cbRead > 0); HeapFree(GetProcessHeap(),0,buffer); if (FAILED(resRead) || FAILED(resWrite)) { ERR("conversion failed: resRead = 0x%08lx, resWrite = 0x%08lx\n", resRead, resWrite); BlockChainStream_Destroy(bbTempChain); return NULL; } in the while loop above while (cbRead > 0); it appears it terminates without doing anything due to the semicolon, is this intentional or is this semicolon not supposed to be there and its supposed to execute the line below it? If it is intentional why is the empty while loop here?

1 1

wine complation fails with latest git
by EA Durbin 13 Sep '06

13 Sep '06

I'm not able to compile wine with the latest source from git. gcc-3.4 -c -I. -I. -I../../include -I../../include -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o parser.yy.o parser.yy.c parser.l: In function `parser_lex': parser.l:129: error: `parser_lval' undeclared (first use in this function) parser.l:129: error: (Each undeclared identifier is reported only once parser.l:129: error: for each function it appears in.) parser.l: In function `kw_token': parser.l:342: error: `parser_lval' undeclared (first use in this function) make[2]: *** [parser.yy.o] Error 1 make[2]: Leaving directory `/home/eric/wine/tools/widl' make[1]: *** [widl] Error 2 make[1]: Leaving directory `/home/eric/wine/tools' make: *** [tools] Error 2

2 2

Help with git
by Kapila De Silva 13 Sep '06

13 Sep '06

Hi all, Hope this is the right place to post this, if not, my apologies. Im trying to track down an issue that occurred between 0.9.19 and 0.9.20, and am using git bisect to track the issue. In the process of trying to identify the cause of the issue, I would like to be able to get the code up till a certain patch, and then apply patches one by one as well. I have not been able to find out how to do this, despite several web searches and man pages. Can anyone give me any pointers to this please? Thanks in advance Kapila

3 2

State management in D3D
by Ivan Gyurdiev 12 Sep '06

12 Sep '06

State management in D3D... is currently kind of a mess. Stefan D. posted a message about this some time ago, but I can't find it right now... - some states are applied immediately (via Set* calls) - some are applied at draw time (like shaders, textures, transforms, ...) - some are recorded into a stateblock structure, and applied when the app says apply(). - the GL code is all over the place, tightly coupled to the d3d code. =============================== There's a number of projects going on at the moment, from what I understand: - Roderick is working on making wined3d -> wgl - Stefan D. has expressed concern about multithreaded d3d (where the D3D device state is shared, but not necessarily the GL one - or can GL contexts be shared between multiple threads?) - I'm trying to get FBOs to work, where the FBO needs to be bound once both the render and stencil target have been assigned (that's 2 calls from the app in any order) - i.e I need those states to be applied in a delayed fashion, before draw - Henri Verbeet wants multiple render target support added to that (meaning the FBO needs to be bound once *all* render targets are assigned in addition to the depth/stencil one). ================================ All of the above have a common theme - better state management is needed, with more encapsulation, and better separation between D3D and GL. So, let's come up with a plan, and try to implement it. How about we redesign the stateblock object like this: - remove deltas. I.E. if a SetLightEnable() command is sent, fetch the light, enable it, then save the light back - store only state, and no deltas. This should make the recording stateblock (updateStateBlock) the same as the initial device stateblock, which stores states - provide a uniform internal interface for accessing states inside the stateblock - like: SetState(stateblock, ID_XYZ, (void*) state_data); GetState(stateblock, ID_XYZ, (void**) state_data); CaptureState(stateblock, ID_XYZ); ApplyState(stateblock, ID_XYZ); ID_XYZ could be an individual state, or a "trigger" keyword, which will refer to a whole group of states. Those would be private functions in addition to the standard interface. - provide a fn pointer table inside the stateblock [ which can be directed to OGL or WGL or AGL ], which, for each ID_XYZ, maps a get and set function using the same interface - move all device.c GL code into those functions - now all device.c Get* and Set* requests will do is: - error checking - recording into updateStateBlock - or writing to stateBlock (which may be applied later, at our discretion). - apply() would just loop through all the IDs and call the corresponding function pointer if the states are marked dirty (we'll keep the 'dirty' field) - capture() would do the same in the get* direction. - new object can be instantiated per device, or per device per thread to address multithreading. It could have an associated glContext, and can be locked as necessary. - it would use ideas from the d3d9 test framework for stateblock, except of course more competently written, and cleaner :)

3 12

Help with shader code
by Kapila De Silva 12 Sep '06

12 Sep '06

Hi All, can someone help me understand some code from dlls/wined3d/vertexshader.c please? Im new to shader code, but to me the following looks a bit strange: shader_addline(&buffer, "ADD result.position.x, TMP_OUT.x, PROJECTIONX.w;\n"); shader_addline(&buffer, "ADD result.position.y, TMP_OUT.y, PROJECTIONY.w;\n"); /* Account for any inverted textures (render to texture case) by reversing the y coordinate * (this is handled in drawPrim() when it sets the MODELVIEW and PROJECTION matrices) */ shader_addline(&buffer, "MUL result.position.y, TMP_OUT.y, PROJECTIONY.y;\n"); Am I correct that the last line makes the second line redundant? Wont result.position.y be equal to TMP_OUT.y * PROJECTIONY.y no matter what? Thanks in advance. Kapila.

2 2

Re: comctl32: Remove dead code in tooltips.c (coverity)
by Alexandre Julliard 12 Sep '06

12 Sep '06

Detlef Riekenberg <wine.dev(a)web.de> writes: > We return with FALSE at the top of the Function, > when lpToolInfo is NULL. I think that's where the real bug is, we shouldn't always return FALSE in that case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: X11Drv: move WGL extension code
by Lionel Ulmer 12 Sep '06

12 Sep '06

On Fri, Sep 01, 2006 at 01:57:24PM +0200, Roderick Colenbrander wrote: > The way WGL extensions are loaded is different. The old code correctly > advertised the names of available WGL extensions but the wglGetProcAddress > code didn't work correctly. Even if an extension wasn't advertised you could > get a function pointer to the functions. On Windows wglGetProcAddress would > return NULL. Note that (as far as I know), 'wglGetProcAddress' returns NULL on non-existant extensions for all extensions, whether they are GL or WGL ones. This means that our implementation of it is broken (at least on DRI / Mesa) as 'glXGetProcAddress' may return a non-NULL value when querying a non-supported extension. So if we really want to be windows-like, we would need to add a 'function name / extension name' database and check if the extension corresponding to the function is present before actually calling 'glXGetProcAddress'. But as I ever only once got a bug report linked to that, I never took the pain to fix it :-) Lionel (catching up his old mails) PS: I guess that this 'database' may be automatically build by the 'make_opengl' script though so it should not be that hard to do :-) -- Lionel Ulmer - http://www.bbrox.org/

1 0

Storage32 error
by EA Durbin 12 Sep '06

12 Sep '06

I've been experiencing an error in several installers and it just appeared lately in installers that used to succeed, such as the battlefield 2 demo installer, this error is causing them to fail. Was this caused by a recent patch? err:storage:Storage32Impl_SmallBlocksToBigBlocks conversion failed: resRead = 0x8003001e, resWrite = 0x00000000 err:storage:Storage32Impl_SmallBlocksToBigBlocks conversion failed: resRead = 0x8003001e, resWrite = 0x00000000 err:storage:Storage32Impl_SmallBlocksToBigBlocks conversion failed: resRead = 0x8003001e, resWrite = 0x00000000

1 0

Re: include: Add new Vista SDK constants, fields and, structures documented at http://ian.joeuser.com/index.asp?AID=738
by Timo Kunze 11 Sep '06

11 Sep '06

Alexandre Julliard <julliard(a)winehq.org> writes: > Francois Gouget <fgouget(a)free.fr> writes: >> > @@ -1707,6 +1732,7 @@ typedef struct tagTOOLINFOA { >> > LPSTR lpszText; >> > LPARAM lParam; >> > void *lpReserved; >> > + HBITMAP hbmp; >> > } TTTOOLINFOA, *LPTOOLINFOA, *PTOOLINFOA, *LPTTTOOLINFOA; > > I don't think our code is going to handle this properly. Before > extending the structures we need to fix places that depend on the size > of the old type. This website is absolutely outdated. Take a look at the current (build 5536) Windows SDK headers and you'll see, that e. g. the hbmp member of the TTTOOLINFO struct has been removed again. Regards Timo

1 0

Wineconf this weekend!
by Jeremy White 11 Sep '06

11 Sep '06

Hi Folks, So this weekend is Wineconf, which is the mostly annual gathering of Wine developers and afficianodos. Everyone is welcome, although we do intend to run a very technical and developer focused agenda. It will be held in Reading, a bit west of London, in the UK. The formal program starts on Saturday. We have a tentative agenda posted on the Wiki here: http://wiki.winehq.org/WineConf2006 The one don't miss talk will be Alexandre's keynote, which will be at 9:00 am on Saturday. We're still working out the schedule for the other events. There is no charge, although you do have to take care of your own loding and travel. If you are planning to come, though, it would be handy if you could hit the RSVP page (if you haven't already): http://www.winehq.org/site/wineconf/rsvp That way we can make sure our catering counts aren't out of wack. If you are coming, particularly if you reserved a room on campus with me, you *must* sign up for this mailing list: http://www.winehq.org/mailman/listinfo/wineconf or you will miss out on important details, and you'll end up wandering around Reading desperately looking for your key. (And yes, that does mean I'll stop spamming this list, and start spamming that one :-/). Cheers, Jeremy

1 0

Re: dinput: [2/2] Create/destroy hook thread from DirectInput [try 3].
by Alexandre Julliard 11 Sep '06

11 Sep '06

Vitaliy Margolen <wine-patch(a)kievinfo.com> writes: > +static void release_hook_thread(void) > +{ > + LONG ref; > + > + EnterCriticalSection(&dinput_hook_crit); > + ref = --hook_thread_refcount; > + TRACE("Releasing to %ld\n", ref); > + if (ref == 0) SendMessageW(hook_thread_hwnd, WM_DESTROY, 0, 0); WM_DESTROY is supposed to be sent by DestroyWindow, sending it manually is not very nice, you should use a WM_USER message instead. Also you need to clear hook_thread_hwnd first, otherwise there's a race since you don't wait for the thread to finish. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Bug #4510: allowing -ansi for arpa/nameser.h in configure.ac
by Alexandre Julliard 11 Sep '06

11 Sep '06

Joel Parker <jjk3(a)msstate.edu> writes: > This patch fixes bug #4510. It allows the use of -ansi when > running ./configure. I'm not sure I see the point, you'd need to fix all the places that use the file too, otherwise it won't compile, and it's not clear that defining BSD_SOURCE all over the place is a good idea. I'd suggest to fix the header instead. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: WINEDOCS: Update regression testing procedure to use Git
by Saulius Krasuckas 11 Sep '06

11 Sep '06

* On Mon, 28 Aug 2006, Mike McCormack wrote: > Update regression testing procedure to use Git Any chances this patch gets into the webserver? :) http://marc.theaimsgroup.com/?l=wine-patches&m=115673906004873&w=2

2 1

Re: X11Drv: move WGL extension code
by Alexandre Julliard 11 Sep '06

11 Sep '06

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > The patch adds new WGL extension loading code based on code written > by an old opengl32 -> x11drv patch written by Tomas Carnacky. The > code properly advertises WGL extensions and only returns function > pointers when the extension is really available. It would be nicer to declare the extensions as constant variables instead of building everything at run time. Something like: static const struct wglextension swap_control = { "WGL_EXT_swap_control", { { "wglSwapIntervalEXT", X11DRV_wglSwapIntervalEXT }, { "wglGetSwapIntervalEXT", X11DRV_wglGetSwapIntervalEXT }, } }; static void load_extensions(void) { if (glxRequireExtension("GLX_SGI_swap_control")) register_extension( &swap_control ); ... etc. } Then the extension list can simply store a pointer instead of copying the whole thing once more, and you avoid a lot of nasty macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Add new Vista SDK constants, fields and structures documented at http://ian.joeuser.com/index.asp?AID=738
by Alexandre Julliard 11 Sep '06

11 Sep '06

Francois Gouget <fgouget(a)free.fr> writes: > @@ -1707,6 +1732,7 @@ typedef struct tagTOOLINFOA { > LPSTR lpszText; > LPARAM lParam; > void *lpReserved; > + HBITMAP hbmp; > } TTTOOLINFOA, *LPTOOLINFOA, *PTOOLINFOA, *LPTTTOOLINFOA; I don't think our code is going to handle this properly. Before extending the structures we need to fix places that depend on the size of the old type. -- Alexandre Julliard julliard(a)winehq.org

1 0

Making people aware about appdb and outdated Wine versions.
by killertux killertux 10 Sep '06

10 Sep '06

Hello, I have problem... It's know as dublication of effort. Basicly there are sites that "compeate" with appdb it means HOWTOS, test result and everyting else are distributed in few thousands forums, wikis etc... Solution is that Wine should advertice Wine AppDB so people would actully use it rather than unoffical sites. So I would like to see some AppDB "adverticement" in winecfg. Winecfg about section is one good place to inform wonders of appdb but even better would be popup window when starting winecfg(at lest in first run) that informs about appdb. Normal users obtain copy of Wine trought their package manager and that means they do not know about appdb unless they they read it somewhere. This change must be done in order to kill useless stuff like this: http://forums.gentoo.org/viewtopic-t-496836.html Second: Old version of Wine are still quite used because of package managers just offers "stable" Wine versions over the "unstable" ones so I would like to see another popup or warning in winecfg that informs user that their Wine is getting old... so after specific number of days(from release of Wine version X) counter gives some warnings about old Wine version.

3 2

Re: Jonathan Ernst : winecfg: French translation update.
by Frank Richter 10 Sep '06

10 Sep '06

On 10.09.2006 10:28, Alexandre Julliard wrote: > - LTEXT "This library is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version.", > + LTEXT "Cette biblioth�que est un logiciel libre�; vous pouvez la redistribuer et/ou la modifier conform�ment aux dispositions de la Licence Publique G�n�rale GNU, telle que publi�e par la Free Software Foundation�; version 2.1 de la licence, ou encore (� votre choix) toute version ult�rieure." > IDC_STATIC,119,44,124,72 It seems that all (L)GPL translations are marked "unofficial" by the FSF. That's why I though it wouldn't be bad to put in a translated "This library is ..." but keep the original English notice as well for the German translation. -f.r.

2 1

Re: Re: Making people aware about appdb and outdated Wine versions.
by killertux killertux 10 Sep '06

10 Sep '06

OK, if not popup then fixme or someting like if there is problems they can go to Wine AppDB to get some compatibility help. >> --SNIP-- >> Second: Old version of Wine are still quite used because of package >> managers just offers "stable" Wine versions over the "unstable" ones so I would like >> to see another popup or warning in winecfg that informs user that their Wine is >> getting old... so after specific number of days(from release of Wine version X) >> counter gives some warnings about old Wine version. > >Having a popup (or anything that requires user interaction) could get >really irritating - there are situations where people would use an >older version of wine on purpose. Like if a large organization uses it >to run one specific app, and has a specific version that works >perfectly, they might not have any reason to update. > >How about a fixme when wine is run, informing them that the version >they are running was released X long ago, and that if they have any >issues they should try a newer version? > >It'd be nice, too, if people then reported bugs with that on the top >of the output - it could save a lot of work chasing down already- fixed >issues. > >--Matt >

3 2

Page Fault when try to start Railroad Tycoon
by Roland Kaeser 10 Sep '06

10 Sep '06

Hello I'm currently on testing my apps for 0.9.20 and getting the following error when try to run a cleanly installed RailRoad Tycoon 3 (on new wine dir). Can somebody help me to figure out the problem? I use a Matrox Parhelia with Tripple-Monitor Configuration. Thanks Roland Kaeser err:x11drv:X11DRV_CreateWindow invalid window width 1919249263 err:x11drv:X11DRV_CreateWindow invalid window height 1952540704 err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded fixme:d3d:IWineD3DDeviceImpl_CreateAdditionalSwapChain The app requests more than one back buffer, this can't be supported properly. Please configure the application to use double buffering(=1 back buffer) if possible err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found! (desktop) fixme:d3d:IWineD3DDeviceImpl_GetAvailableTextureMem (0x18b400) : stub, simulating 64MB for now, returning 64MB left fixme:d3d:IWineD3DDeviceImpl_ValidateDevice (0x18b400) : stub fixme:d3d:IWineD3DDeviceImpl_ValidateDevice (0x18b400) : stub wine: Unhandled page fault on read access to 0x00001874 at address 0x7e03d9c1 (thread 000e), starting debugger... WineDbg starting on pid 0xd Unhandled exception: page fault on read access to 0x00001874 in 32-bit code (0x7e03d9c1). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7e03d9c1 ESP:003100a8 EBP:00000001 EFLAGS:00210206( - 00 - RIP1) EAX:00001860 EBX:7e3b6efc ECX:7c29daf0 EDX:00000000 ESI:00000000 EDI:7c2957e0 Stack dump: 0x003100a8: 7df65d78 7c29da6c 7c29ee94 00000000 0x003100b8: 3f800000 7e04ac27 00310340 ffffffff 0x003100c8: 7e3b6efc 7c2bf3d0 7e40b7ac 00310224 0x003100d8: 7dfb58ba 7c2957e0 7c2c11ec 7e1f5fb5 0x003100e8: 00000001 00000000 ffffffff 7e3b6efc 0x003100f8: 00000000 7e3b6efc 00000000 00000000 fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000119 Backtrace: =>1 0x7e03d9c1 in libgl.so.1 (+0x1199c1) (0x7e03d9c1) 2 0x00000000 (0x00000000) 0x7e03d9c1: movl 0x14(%eax),%edx Modules: Module Address Debug info Name (91 modules) PE 400000-da2000 Deferred rt3c PE 21100000-21164000 Deferred mss32 PE 30000000-30072000 Deferred binkw32 ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7d543000-7d559000 Deferred midimap<elf> \-PE 7d550000-7d559000 \ midimap ELF 7d57f000-7d597000 Deferred msacm32<elf> \-PE 7d590000-7d597000 \ msacm32 ELF 7d597000-7d5d7000 Deferred wineoss<elf> \-PE 7d5a0000-7d5d7000 \ wineoss ELF 7d6ed000-7d6f7000 Deferred libnss_files.so.2 ELF 7d6f7000-7d81d000 Deferred libcrypto.so.0.9.8 ELF 7d81d000-7d85a000 Deferred libssl.so.0.9.8 ELF 7d85a000-7d878000 Deferred libcups.so.2 ELF 7d90d000-7d93f000 Deferred uxtheme<elf> \-PE 7d910000-7d93f000 \ uxtheme ELF 7d941000-7d95d000 Deferred imm32<elf> \-PE 7d950000-7d95d000 \ imm32 ELF 7d9a3000-7d9a6000 Deferred libxrandr.so.2 ELF 7d9a6000-7d9ae000 Deferred libxrender.so.1 ELF 7d9ae000-7d9b3000 Deferred libxfixes.so.3 ELF 7d9b3000-7d9bc000 Deferred libxcursor.so.1 ELF 7d9bc000-7d9d9000 Deferred ximcp.so.2 ELF 7d9d9000-7d9db000 Deferred xlcutf8load.so.2 ELF 7d9db000-7da6a000 Deferred winex11<elf> \-PE 7d9f0000-7da6a000 \ winex11 ELF 7dc36000-7dc55000 Deferred libexpat.so.1 ELF 7dc55000-7dc8e000 Deferred libfontconfig.so.1 ELF 7dc8e000-7dca0000 Deferred libz.so.1 ELF 7dca0000-7dd0d000 Deferred libfreetype.so.6 ELF 7dd0d000-7dd27000 Deferred wsock32<elf> \-PE 7dd10000-7dd27000 \ wsock32 ELF 7dd27000-7dd40000 Deferred version<elf> \-PE 7dd30000-7dd40000 \ version ELF 7dd40000-7dd6d000 Deferred ws2_32<elf> \-PE 7dd50000-7dd6d000 \ ws2_32 ELF 7dd6d000-7ddb9000 Deferred dsound<elf> \-PE 7dd80000-7ddb9000 \ dsound ELF 7ddb9000-7ddf0000 Deferred dinput<elf> \-PE 7ddc0000-7ddf0000 \ dinput ELF 7deae000-7df24000 Deferred libglu.so.1 ELF 7df24000-7e40c000 Export libgl.so.1 ELF 7e40c000-7e503000 Deferred libx11.so.6 ELF 7e503000-7e511000 Deferred libxext.so.6 ELF 7e511000-7e529000 Deferred libice.so.6 ELF 7e529000-7e532000 Deferred libsm.so.6 ELF 7e533000-7e547000 Deferred lz32<elf> \-PE 7e540000-7e547000 \ lz32 ELF 7e547000-7e55f000 Deferred dinput8<elf> \-PE 7e550000-7e55f000 \ dinput8 ELF 7e55f000-7e613000 Deferred wined3d<elf> \-PE 7e570000-7e613000 \ wined3d ELF 7e613000-7e638000 Deferred d3d8<elf> \-PE 7e620000-7e638000 \ d3d8 ELF 7e638000-7e6c0000 Deferred winmm<elf> \-PE 7e640000-7e6c0000 \ winmm ELF 7e6c0000-7e6f0000 Deferred winspool<elf> \-PE 7e6d0000-7e6f0000 \ winspool ELF 7e6f0000-7e7c0000 Deferred comctl32<elf> \-PE 7e700000-7e7c0000 \ comctl32 ELF 7e7c0000-7e7d3000 Deferred libresolv.so.2 ELF 7e7d3000-7e7f1000 Deferred iphlpapi<elf> \-PE 7e7e0000-7e7f1000 \ iphlpapi ELF 7e7f1000-7e841000 Deferred rpcrt4<elf> \-PE 7e800000-7e841000 \ rpcrt4 ELF 7e841000-7e8d6000 Deferred ole32<elf> \-PE 7e850000-7e8d6000 \ ole32 ELF 7e8d6000-7e92d000 Deferred shlwapi<elf> \-PE 7e8e0000-7e92d000 \ shlwapi ELF 7e92d000-7ea15000 Deferred shell32<elf> \-PE 7e940000-7ea15000 \ shell32 ELF 7ea15000-7eab2000 Deferred comdlg32<elf> \-PE 7ea20000-7eab2000 \ comdlg32 ELF 7eab2000-7eaf8000 Deferred advapi32<elf> \-PE 7eac0000-7eaf8000 \ advapi32 ELF 7eaf8000-7eb03000 Deferred libgcc_s.so.1 ELF 7ebe3000-7ec99000 Deferred gdi32<elf> \-PE 7ec00000-7ec99000 \ gdi32 ELF 7ec99000-7edda000 Deferred user32<elf> \-PE 7ecb0000-7edda000 \ user32 ELF 7ee1c000-7ef23000 Deferred kernel32<elf> \-PE 7ee40000-7ef23000 \ kernel32 ELF 7ef58000-7ef7d000 Deferred libm.so.6 ELF 7ef7d000-7f000000 Deferred ntdll<elf> \-PE 7ef90000-7f000000 \ ntdll ELF b7d71000-b7d76000 Deferred libxxf86vm.so.1 ELF b7d78000-b7d7c000 Deferred libdl.so.2 ELF b7d7c000-b7e9c000 Deferred libc.so.6 ELF b7e9c000-b7eb0000 Deferred libpthread.so.0 ELF b7eb0000-b7fc1000 Deferred libwine.so.1 ELF b7fc2000-b7fde000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000f 00000011 0 00000010 0 0000000d (D) C:\Programme\Railroad Tycoon 3\RT3c.exe 00000013 15 0000000e 0 <==

1 0

Can't compile wine at Linux-ppc
by Peter Lemenkov 10 Sep '06

10 Sep '06

Hello, All! The last wine version which at least compiles fine is 0.9.17. Since then I can't even compile Wine. It fails with the next message ==================================== ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -D_SHDOCVW_ -t -T shdocvw_v1.tlb shdocvw_v1.idl warning: create_msft_typeinfo: ignoring attr 46 warning: create_msft_typeinfo: ignoring attr 46 warning: add_func_desc: ignoring attr 5 error: encode_type: VT_USERDEFINED - unhandled type 17 make[2]: *** [shdocvw_v1.tlb] Error 2 make[2]: Leaving directory `/home/petro/work/projects/wine/dlls/shdocvw' make[1]: *** [shdocvw] Error 2 make[1]: Leaving directory `/home/petro/work/projects/wine/dlls' make: *** [dlls] Error 2 ==================================== I have no clue how to debug this situation, so I wold ask you: how to fix this strange situation? -- With best regards!

1 0

RE: Setupapi [0/6] : ReactOS setupapi patches
by Hervé Poussineau 09 Sep '06

09 Sep '06

Hi, > As setupapi merge from ReactOS has been a recurrent demand > [1], I'm doing this set of patches. > > [...] > > The goal of this set of patches is to set a solid ground to > implement lots of missing functions in setupapi. > I've tried to cut them in smallest possible parts. > Additionnaly, this patchset implements SetupDiEnumDeviceInfo > and (mostly) SetupDiGetClassDevsExW > > [...] Still one week, and I got absolutly no reaction about my patches. Is something wrong with them? Hervé

3 2

Re: shell32[1/2]: document the shell32 "mini-COM" functions
by Frank Richter 09 Sep '06

09 Sep '06

On 08.09.2006 21:11, Mikołaj Zalewski wrote: > This patch adds the explanation why many shell32 functions are similar > to ole32 ones - something I've been wondering for some time. It is not > copied from MSDN. Maybe you've seen it already, but this blog post talks about the various allocators: http://blogs.msdn.com/oldnewthing/archive/2004/07/05/173226.aspx -f.r.

2 1

Re: Socket resets randomly
by James Hawkins 09 Sep '06

09 Sep '06

On 9/8/06, Ryan Miller <rmiller(a)auctionpay.com> wrote: > Index: ChangeLog > =================================================================== > RCS file: /home/wine/wine/ChangeLog,v > retrieving revision 1.120 > diff -u -r1.120 ChangeLog > --- ChangeLog 24 Aug 2006 14:43:25 -0000 1.120 > +++ ChangeLog 8 Sep 2006 22:49:55 -0000 > @@ -1,3 +1,8 @@ > +2006-09-08 Ryan Miller <rmiller(a)auctionpay.com> & Zach Gorman <gormanjz(a)hotmail.com> > + > + * dlls/ws2_32/socket.c, dlls/ws2_32/sock.c > + ws2_32: Fixed bug with sockets randomly reseting and tests. > + > 2006-08-24 Alexandre Julliard <julliard(a)winehq.org> > > * configure, configure.ac: > > Index: dlls/ws2_32/socket.c > As someone already said, no changes to Changelog. =================================================================== > RCS file: /home/wine/wine/dlls/ws2_32/socket.c,v > retrieving revision 1.4 > diff -u -r1.4 socket.c > --- dlls/ws2_32/socket.c 8 Sep 2006 10:16:19 -0000 1.4 > +++ dlls/ws2_32/socket.c 8 Sep 2006 22:48:11 -0000 > @@ -2660,6 +2660,11 @@ > TRACE("socket: %04x, level %d, name %d, ptr %p, len %d\n", > s, level, optname, optval, optlen); > > + /* In Windows, if setsockopt succeeds, GetLastError() always returns zero. > + The native wininet.dll expects this behavior, and does not always > + check the return value of setsockopt() first.*/ > + SetLastError(0); > + 0 is ERROR_SUCCESS, and you need to use that define. > /* SO_OPENTYPE does not require a valid socket handle. */ > if (level == WS_SOL_SOCKET && optname == WS_SO_OPENTYPE) > { > > > Index: dlls/ws2_32/tests/sock.c > =================================================================== > RCS file: /home/wine/wine/dlls/ws2_32/tests/sock.c,v > retrieving revision 1.2 > diff -u -r1.2 sock.c > --- dlls/ws2_32/tests/sock.c 23 May 2006 12:49:01 -0000 1.2 > +++ dlls/ws2_32/tests/sock.c 8 Sep 2006 22:48:12 -0000 > @@ -1410,6 +1410,27 @@ > > } > > +static void test_setsockopt_last_error() { > + SOCKET s; > + BOOL bKeepAlive=0; > + struct sockaddr_in addr; > + struct timeval select_timeout; > + > + select_timeout.tv_sec=5; > + select_timeout.tv_usec=0; > + addr.sin_family = AF_INET; > + addr.sin_addr.s_addr = inet_addr(SERVERIP); > + addr.sin_port = htons(SERVERPORT); > + > + s = socket(AF_INET, SOCK_STREAM, 0); > + do_bind(s, (struct sockaddr *)&addr, sizeof(addr)); > + > + SetLastError(1); > + setsockopt(s,SOL_SOCKET, SO_KEEPALIVE, (char *)&bKeepAlive, sizeof(bKeepAlive)); > + ok( GetLastError()==0, "GetLastError() was not cleared by setsockopt\n"); > + closesocket(s); > +} > + You need to SetLastError to some value that you know will never be set by windows, something like 0xdeadbeef. The reasoning is that theoretically it could alter the results of the test. > /**************** Main program ***************/ > > START_TEST( sock ) > @@ -1438,6 +1459,8 @@ > test_WSAStringToAddressW(); > > test_select(); > - > + > + test_setsockopt_last_error(); > + > Exit(); > } > > > > > -- James Hawkins

3 2

Re: GetTextMetrics returns wrong First/Last char index for Symbol fonts
by Dmitry Timoshkov 09 Sep '06

09 Sep '06

"Jie Zhu" <jonathan(a)corvu.com.au> wrote: > + ptmA->tmFirstChar = ptmA->tmBreakChar - 2; > + if (ptmW->tmCharSet == SYMBOL_CHARSET) > + { > + ptmA->tmLastChar = ptmW->tmLastChar > 0x0F0FF ? 0x0FF : ptmW->tmLastChar & 0x0FF; > + } > + else > + { > + ptmA->tmLastChar = ptmW->tmLastChar > 255 ? 255 : ptmW->tmLastChar; > + } Probably simple WideCharToMultiByte with CP_SYMBOL and CP_ACP would do a proper thing for tmFirstChar, tmLastChar, tmBreakChar. You have too many fixes for different problems in your patch, that makes it not acceptable. Please send fixes one by one for the problems you have encountered. Also, if you could make your tests use FreeType APIs (like Wine GDI does) instead of home-made ones that would simplify them a lot. It would be nice to see a real Wine test suite for the above conversions. -- Dmitry.

1 0

Symbol demangling and the games crashing
by Vijay Kiran Kamuju 09 Sep '06

09 Sep '06

Hi, In the bug reports I have seen that we are facing problems with symbol demangling of '_R' operators and 'Y' datatypes. err:msvcrt:symbol_demangle Unknown operator: _R and err:msvcrt:demangle_datatype Unknown type Y Escpecially for games StarTrek Armada and Gothic. If anyone is intersted in symbol demangling stuff(msvcrt), here is an excellent guide for definition of symbols, etc : http://sparcs.kaist.ac.kr/~tokigun/article/vcmangle.html I will try to come up with a basic patch for that. I dont mind, If someone beats me to it. Thanks, VJ

3 2

Re: *RESEND* Fix bug #5800
by Mike McCormack 09 Sep '06

09 Sep '06

Daniel Skorka wrote: > + res = connect(s, ptr->ai_addr, (int)ptr->ai_addrlen); > + if(res) Why not use InternetConnect? If the connection needs to be made through a http:// proxy, connect() may not work, but InternetConnect should handle that case. Mike

1 0

Re: Socket resets randomly
by Tom Wickline 08 Sep '06

08 Sep '06

On 9/8/06, Ryan Miller <rmiller(a)auctionpay.com> wrote: > Index: ChangeLog > You don't want to change the changelog, only AJ does the changelog once the patch is accepted and makes its way into main line Wine. You should just add a note of what changed Tom

1 0

Re: svrapi: realizes library svrapi.dll (3 of 20 functions).
by Detlef Riekenberg 08 Sep '06

08 Sep '06

Konstantin Petrov wrote: Your Patch is much to large. > dlls/svrapi/Makefile, > dlls/svrapi/libsvrapi.def, This files are created automatic by the build-system. > +16 stdcall NetShareAdd (str long str long) WIN98_NetShareAdd > +17 stdcall NetShareDel(str str long) WIN98_NetShareDel > +18 stdcall NetShareEnum(str long ptr long ptr ptr) WIN98_NetShareEnum > +19 stub NetShareGetInfo > +20 stub NetShareSetInfo Are the ordinals needed / Which app import this Functions by Ordinal? > --- /dev/null 2006-07-03 10:36:18 +0400 > +++ dlls/svrapi/svrapi_main.c 2006-07-24 15:08:49 +0400 I suggest to send a Patch, that has only "DllMain" in this File to reduce the size. Add a stub with description in a separate Patch. > +//SHPWLEN is not known !!!!!! C++ - Comments are not allowed in wine (it's not portable) > +#define SHPWLEN LM20_PWLEN > +typedef struct _share_info_1 { > + char shi1_netname[LM20_NNLEN+1]; > + char shi1_pad1; > + unsigned short shi1_type; > + char* shi1_remark; > +} share_info_1; > +typedef struct _share_info_50 { > + char shi50_netname[LM20_NNLEN+1]; > + unsigned char shi50_type; > + unsigned short shi50_flags; > + char* shi50_remark; > + char* shi50_path; > + char shi50_rw_password[SHPWLEN+1]; > + char shi50_ro_password[SHPWLEN+1]; > +} share_info_50; This seems to be the wrong location here. (svrapi.h) Should be the first patch (only this include-file) > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID > fImpLoad) > +{ > + TRACE("%p 0x%lx %p\n", hinstDLL, fdwReason, fImpLoad); > + > + switch(fdwReason) { Do not forget "DLL_WINE_PREATTACH" > + > + FIXME("Stub (%s %d %p %d %p %p)\n", (pszServer ? > pszServer:"NULL"), sLevel, pbBuffer, > + cbBuffer, pcEntriesRead, pcTotalAvail); you need debugstr_a() > + if (pbBuffer != NULL) > + HeapFree(GetProcessHeap(), 0, pbBuffer); HeapFree() handles NULL; we removed similar unneeded "if" recently. > + if(pszServer != NULL) return NERR_NetNameNotFound; Many Functions in other dll's handle an empty Servername as an alias for the local Computer (the same way as an NULL-Parameter). Did you test this? > + // if ((sLevel == 50) && (cbBuffer == > sizeof(share_info_50))) //in real Why do you not use this code, when it reflects the windows-behavior? -- By By ... ... Detlef

5 8

Anything wrong with this patch? Comments....
by Vijay Kiran Kamuju 08 Sep '06

08 Sep '06

Hi, Anything wrong with this patch, http://www.winehq.org/pipermail/wine-patches/2006-August/030201.html Please do send me comments, this fixes installation of icqlite. Thanks, VJ

1 0

Re: ntdll/file.c: arttr is never... ("attr"-typo in the Changelog)
by Detlef Riekenberg 08 Sep '06

08 Sep '06

> Changelog: > - ntdll/file.c: arttr is never NULL inside NtCreateFile This "arttr" was a typo and should be "attr" The Patch is correct. Thanks -- By by ... Detlef

1 0

Re: include: Add new Vista SDK constants, fields and structures documented at http://ian.joeuser.com/index.asp?AID=738
by Dmitry Timoshkov 08 Sep '06

08 Sep '06

"Francois Gouget" <fgouget(a)free.fr> wrote: > --- a/include/commctrl.h > +++ b/include/commctrl.h > @@ -119,7 +119,9 @@ #define NM_TOOLTIPSCREATED (NM_FIRS > #define NM_LDOWN (NM_FIRST-20) > #define NM_RDOWN (NM_FIRST-21) > #define NM_THEMECHANGED (NM_FIRST-22) > - > +#define NM_FONTCHANGED (NM_FIRST-23) > +#define NM_CUSTOMTEXT (NM_FIRST-24) > +#define NM_TVSTATEIMAGECHANGING (NM_FIRST-24) Do the two above really have the same values? -- Dmitry.

2 1

Framebuffer objects
by Ivan Gyurdiev 08 Sep '06

08 Sep '06

Hi... I've been trying to get FBOs working, but I have extremely limited time to work on such things, so I thought I'd just post my current patch here, and see if people can help me figure out what's wrong with it :) FBOs (framebuffer objects) are a newer extension, intended to replace pbuffers to accomplish offscreen rendering - so instead of drawing to the screen, you get to draw to other objects, more importantly textures. We currently support pbuffers, but the code is sketchy, and disabled for that reason. SPEC: http://msi.unilim.fr/~porquet/glexts/GL_EXT_framebuffer_object.txt.htm Known problems with this patch include: (1) The D3D allows the user to setDepthStencilBuffer. I do no such thing - only a default depth buffer is supported. Neither is sharing this depth buffer between offscreen and onscreen [ requires copying of pixels via lock/unlock ]. Resolution: next revision - we don't support that onscreen in the first place :) (2) Attempting to bind a framebuffer using GL_RGB32F_ARB, and GL_RGBA32F_ARB formats will fail on my hardware (Nvidia GeForce 6800GS) with error GL_FRAMEBUFFER_UNSUPPORTED_EXT, which means the format combination was invalid for implementation-dependent reasons. However, this doesn't make sense, based on information online, which indicates this should work. See: http://www.mathematik.uni-dortmund.de/~goeddeke/gpgpu/tutorial.htm : "Using textures as render targets".... or google. This is a problem, since certain demos which make use of the R32F format won't work with FBOs - but oddly work with pbuffers. See SoftShadowsII: http://www.humus.ca/index.php?page=3D&&start=8 On the other hand I know R16F -> GL_RGB16F works fine, based on 3Dc demo. (3) Attempting to use GL_STENCIL_INDEX8_EXT in glRenderbufferStorageEXT will fail on my hardware with GL_INVALID_OPERATION. Why - this should work according to the GL spec. On the other hand this support list says otherwise: http://developer.nvidia.com/object/nv_ogl_texture_formats.html ========= Note that bugs or no bugs, the patch fixes the following (demos from humus.ca): 3Dc demo runs correctly TransparentShadowMapping demo runs correctly Sketch demo runs correctly Half-Life 2 startup screen runs correctly ---- Water demo offscreen content is moved offscreen SoftShadows2 - offscreen content moved offscreen, shows something a lot more correct PhongLighting - offscreen content moved offscreen ---- ...but doesn't quite match pbuffers, because: SoftShadows2 - works completely in pbuffers (even if slow), has errors in FBOs PhongLighting - has errors in FBOs SelfShadowBump - no shadow artifacts on the wall, but now most of the demo's in shadow. >From 98efb529e850dafb66c331afbc5168f90180650a Mon Sep 17 00:00:00 2001 From: Ivan Gyurdiev <ivg2(a)cornell.edu> Date: Thu, 7 Sep 2006 07:17:00 -0400 Subject: [PATCH] Add support for offscreen rendering via FBOs. This uses: GL_EXT_framebuffer_objects A select_offscreen_mode() function was added, where FBOs are given precedence over pbuffers - another way to do offscreen rendering, which is older, not as nice, and currently disabled at compile time. A shared depth buffer between offscreen and onscreen is not currently supported. A custom depth buffer (SetDepthStencil) is not supported (but onscreen doesn't support it either). --- dlls/wined3d/device.c | 201 +++++++++++++++++++++++++++++++++++----- dlls/wined3d/directx.c | 17 +++ dlls/wined3d/utils.c | 38 +++++++- dlls/wined3d/wined3d_private.h | 70 +++++++++----- include/wine/wined3d_gl.h | 1 5 files changed, 275 insertions(+), 52 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 463607f..aeed6b0 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -8,6 +8,7 @@ * Copyright 2005 Oliver Stieber * Copyright 2006 Stefan Dösinger for CodeWeavers * Copyright 2006 Henri Verbeet + * Copyright 2006 Ivan Gyurdiev * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -82,6 +83,8 @@ static void WINAPI IWineD3DDeviceImpl_Ad static void WINAPI IWineD3DDeviceImpl_ApplyTextureUnitState(IWineD3DDevice *iface, DWORD Stage, WINED3DTEXTURESTAGESTATETYPE Type); +static void device_render_to_texture(IWineD3DDeviceImpl* This, BOOL isTexture); + /* helper macros */ #define D3DMEMCHECK(object, ppResult) if(NULL == object) { *ppResult = NULL; WARN("Out of memory\n"); return WINED3DERR_OUTOFVIDEOMEMORY;} @@ -239,6 +242,128 @@ static void setup_light(IWineD3DDevice * } /********************************************************** + * FBO helper functions follow + **********************************************************/ + +static void device_fbo_attach_depthstencil( + IWineD3DDeviceImpl *This) { + + TRACE("Attaching depth stencil to offscreen FBO.\n"); + + /* Attach a default Depth renderbuffer */ + GL_EXTCALL(glFramebufferRenderbufferEXT(GL_FRAMEBUFFER_EXT, GL_DEPTH_ATTACHMENT_EXT, + GL_RENDERBUFFER_EXT, This->offscreenRBO[OFFSCREEN_RBO_DEPTH])); + checkGLcall("glFramebufferRenderbufferEXT(OFFSCREEN_RBO_DEPTH)"); + + /* Attach a default Stencil renderbuffer */ +// GL_EXTCALL(glFramebufferRenderbufferEXT(GL_FRAMEBUFFER_EXT, GL_STENCIL_ATTACHMENT_EXT, +// GL_RENDERBUFFER_EXT, This->offscreenRBO[OFFSCREEN_RBO_STENCIL])); +// checkGLcall("glFramebufferRenderbufferEXT(OFFSCREEN_RBO_STENCIL)"); +} + +static void device_fbo_attach_rendertarget( + IWineD3DDeviceImpl *This, + IWineD3DSurface* surface) { + + glDescriptor* surface_desc; + + TRACE("Attaching render surface %p to offscreen FBO.\n", surface); + + /* Pre-load does some neessary prep., such as filling out the gl descriptor properly */ + IWineD3DSurface_PreLoad(surface); + IWineD3DSurface_GetGlDesc(surface, &surface_desc); + + /* Now attach surface to the FBO */ + GL_EXTCALL(glFramebufferTexture2DEXT(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT, + surface_desc->target, surface_desc->textureName, surface_desc->level)); + checkGLcall("glFramebufferTexture2DEXT(0)"); + + checkGLfbstatus(); + + /* TODO: MRTs */ +} + +static void device_fbo_render_offscreen( + IWineD3DDeviceImpl *This, + IWineD3DSurface* initialRendertarget, + IWineD3DSurface* initialDepthStencil) { + + UINT render_width, render_height; + WINED3DSURFACE_DESC render_desc; + memset(&render_desc, 0, sizeof(WINED3DSURFACE_DESC)); + render_desc.Width = &render_width; + render_desc.Height = &render_height; + + /* Grab the current rendertarget's width and height */ + IWineD3DSurfaceImpl_GetDesc(initialRendertarget, &render_desc); + + /* The first time offscreen rendering is requested, + * reserve one FBO, and two RBOs, and initialize storage for depth and stencil */ + + if (!This->offscreenFBO) { + GL_EXTCALL(glGenFramebuffersEXT(1, &This->offscreenFBO)); + checkGLcall("glGenFramebuffersEXT"); + + GL_EXTCALL(glGenRenderbuffersEXT(2, This->offscreenRBO)); + checkGLcall("glGenRenderbuffersEXT"); + + GL_EXTCALL(glBindRenderbufferEXT(GL_RENDERBUFFER_EXT, This->offscreenRBO[OFFSCREEN_RBO_DEPTH])); + checkGLcall("glBindRenderbufferEXT(OFFSCREEN_RBO_DEPTH)"); + GL_EXTCALL(glRenderbufferStorageEXT(GL_RENDERBUFFER_EXT, GL_DEPTH_COMPONENT24, + render_width, render_height)); + checkGLcall("glRenderbufferStorageEXT(OFFSCREEN_RBO_DEPTH)"); + +// GL_EXTCALL(glBindRenderbufferEXT(GL_RENDERBUFFER_EXT, This->offscreenRBO[OFFSCREEN_RBO_STENCIL])); +// checkGLcall("glBindRenderbufferEXT(OFFSCREEN_RBO_STENCIL)"); +// GL_EXTCALL(glRenderbufferStorageEXT(GL_RENDERBUFFER_EXT, GL_STENCIL_INDEX4_EXT, +// render_width, render_height)); +// checkGLcall("glRenderbufferStorageEXT(OFFSCREEN_RBO_STENCIL)"); + } + + /* TODO: lock depthstencil */ + + /* Switch to offscreen FBO */ + GL_EXTCALL(glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, This->offscreenFBO)); + checkGLcall("glBindFramebufferEXT"); + + device_fbo_attach_rendertarget(This, initialRendertarget); + device_fbo_attach_depthstencil(This); + + /* TODO: unlock depthstencil */ +} + +static void device_fbo_render_onscreen( + IWineD3DDeviceImpl *This) { + + TRACE("Reverting to onscreen FBO.\n"); + + /* TODO: lock depthstencil */ + + /* Detach color */ + GL_EXTCALL(glFramebufferTexture2DEXT(GL_FRAMEBUFFER_EXT, + GL_COLOR_ATTACHMENT0_EXT, GL_TEXTURE_2D, 0, 0)); + checkGLcall("glFramebufferTexture2DEXT(0)"); + + /* Detach depth */ + GL_EXTCALL(glFramebufferRenderbufferEXT(GL_FRAMEBUFFER_EXT, + GL_DEPTH_ATTACHMENT_EXT, GL_RENDERBUFFER_EXT, 0)); + checkGLcall("glFramebufferRenderbufferEXT(OFFSCREEN_DEPTH_RBO)"); + + /* Detach stencil */ + GL_EXTCALL(glFramebufferRenderbufferEXT(GL_FRAMEBUFFER_EXT, + GL_STENCIL_ATTACHMENT_EXT, GL_RENDERBUFFER_EXT, 0)); + checkGLcall("glFramebufferRenderbufferEXT(OFFSCREEN_STENCIL_RBO)"); + + /* Switch to onscreen FBO */ + GL_EXTCALL(glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, 0)); + checkGLcall("glBindFramebufferEXT"); + + /* TODO: unlock depthstencil */ + + checkGLfbstatus(); +} + +/********************************************************** * GLSL helper functions follow **********************************************************/ @@ -2141,6 +2266,19 @@ static HRESULT WINAPI IWineD3DDeviceImpl This->cursorTexture = 0; } + /* Delete the offscreen FBO (if present), and switch back on-screen */ + if (wined3d_settings.offscreen_selected_mode == OFFSCREEN_FBO && This->offscreenFBO) { + ENTER_GL(); + device_fbo_render_onscreen(This); + device_render_to_texture(This, FALSE); + GL_EXTCALL(glDeleteFramebuffersEXT(1, &This->offscreenFBO)); + checkGLcall("glDeleteFramebuffersEXT"); + GL_EXTCALL(glDeleteRenderbuffersEXT(2, This->offscreenRBO)); + checkGLcall("glDeleteRenderbuffersEXT"); + LEAVE_GL(); + This->offscreenFBO = 0; + } + for(sampler = 0; sampler < GL_LIMITS(sampler_stages); ++sampler) { IWineD3DDevice_SetTexture(iface, sampler, NULL); } @@ -5984,8 +6122,10 @@ static HRESULT WINAPI IWineD3DDeviceImpl /* If the container of the rendertarget is a texture then we need to save the data from the pbuffer */ IUnknown *targetContainer = NULL; - if (WINED3D_OK == IWineD3DSurface_GetContainer(This->renderTarget, &IID_IWineD3DBaseTexture, (void **)&targetContainer) - || WINED3D_OK == IWineD3DSurface_GetContainer(This->renderTarget, &IID_IWineD3DDevice, (void **)&targetContainer)) { + if (wined3d_settings.offscreen_selected_mode == OFFSCREEN_PBUFFER && + (WINED3D_OK == IWineD3DSurface_GetContainer(This->renderTarget, &IID_IWineD3DBaseTexture, (void **)&targetContainer) + || WINED3D_OK == IWineD3DSurface_GetContainer(This->renderTarget, &IID_IWineD3DDevice, (void **)&targetContainer))) { + TRACE("(%p) : Texture rendertarget %p\n", This ,This->renderTarget); /** always dirtify for now. we must find a better way to see that surface have been modified (Modifications should will only occur via draw-primitive, but we do need better locking @@ -7199,34 +7339,34 @@ static HRESULT WINAPI IWineD3DDeviceImpl static HRESULT WINAPI IWineD3DDeviceImpl_SetDepthStencilSurface(IWineD3DDevice *iface, IWineD3DSurface *pNewZStencil) { IWineD3DDeviceImpl *This = (IWineD3DDeviceImpl *)iface; - HRESULT hr = WINED3D_OK; IWineD3DSurface *tmp; TRACE("(%p) Swapping z-buffer\n",This); if (pNewZStencil == This->stencilBufferTarget) { TRACE("Trying to do a NOP SetRenderTarget operation\n"); - } else { - /** OpenGL doesn't support 'sharing' of the stencilBuffer so we may incure an extra memory overhead - * depending on the renter target implementation being used. - * A shared context implementation will share all buffers between all rendertargets (including swapchains), - * implementations that use separate pbuffers for different swapchains or rendertargets will have to duplicate the - * stencil buffer and incure an extra memory overhead - ******************************************************/ - - - tmp = This->stencilBufferTarget; - This->stencilBufferTarget = pNewZStencil; - /* should we be calling the parent or the wined3d surface? */ - if (NULL != This->stencilBufferTarget) IWineD3DSurface_AddRef(This->stencilBufferTarget); - if (NULL != tmp) IWineD3DSurface_Release(tmp); - hr = WINED3D_OK; - /** TODO: glEnable/glDisable on depth/stencil depending on - * pNewZStencil is NULL and the depth/stencil is enabled in d3d - **********************************************************/ + return WINED3D_OK; } - return hr; + /** OpenGL doesn't support 'sharing' of the stencilBuffer so we may incure an extra memory overhead + * depending on the renter target implementation being used. + * A shared context implementation will share all buffers between all rendertargets (including swapchains), + * implementations that use separate pbuffers for different swapchains or rendertargets will have to duplicate the + * stencil buffer and incure an extra memory overhead + ******************************************************/ + + tmp = This->stencilBufferTarget; + This->stencilBufferTarget = pNewZStencil; + /* should we be calling the parent or the wined3d surface? */ + if (NULL != This->stencilBufferTarget) IWineD3DSurface_AddRef(This->stencilBufferTarget); + if (NULL != tmp) IWineD3DSurface_Release(tmp); + /** TODO: glEnable/glDisable on depth/stencil depending on + * pNewZStencil is NULL and the depth/stencil is enabled in d3d + **********************************************************/ + + /* TODO: Unlock texture */ + + return WINED3D_OK; } @@ -7334,9 +7474,7 @@ static void device_reapply_stateblock(IW This->updateStateBlock = oldUpdateStateBlock; } -/* Set the device to render to a texture, or not. - * This involves changing renderUpsideDown */ - +/* Set the device to render to a texture */ static void device_render_to_texture(IWineD3DDeviceImpl* This, BOOL isTexture) { DWORD cullMode; @@ -7352,6 +7490,7 @@ static void device_render_to_texture(IWi /* Set upside-down rendering, and update the cull mode */ /* The surface must be rendered upside down to cancel the flip produced by glCopyTexImage */ This->renderUpsideDown = isTexture; + This->offscreenRendering = isTexture; This->last_was_rhw = FALSE; This->proj_valid = FALSE; IWineD3DDevice_GetRenderState((IWineD3DDevice*) This, WINED3DRS_CULLMODE, &cullMode); @@ -7540,12 +7679,22 @@ #if defined(GL_VERSION_1_3) /* Reapply the stateblock, and set the device not to render to texture */ device_reapply_stateblock(This); + + /* If the offscreen FBO is being used, switch to the onscreen FBO */ + if (wined3d_settings.offscreen_selected_mode == OFFSCREEN_FBO && This->offscreenRendering) + device_fbo_render_onscreen(This); device_render_to_texture(This, FALSE); } + /* Offscreen rendering: FBOs */ + } else if (wined3d_settings.offscreen_selected_mode == OFFSCREEN_FBO) { + + device_fbo_render_offscreen(This, RenderSurface, This->depthStencilBuffer); + device_render_to_texture(This, TRUE); + /* Offscreen rendering: PBuffers (currently disabled). * Also note that this path is never reached if FBOs are supported */ - } else if (pbuffer_support && + } else if (wined3d_settings.offscreen_selected_mode == OFFSCREEN_PBUFFER && (cfgs = device_find_fbconfigs(This, implicitSwapchainImpl, RenderSurface)) != NULL) { /** ******************************************************************** diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index d4a0e97..ef9cdfb 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -26,7 +26,6 @@ /* Uncomment this to force only a single display mode to be exposed: */ /*#define DEBUG_SINGLE_MODE*/ - #include "config.h" #include "wined3d_private.h" @@ -237,6 +236,20 @@ static void select_shader_mode( } } +/* Select the offscreen mode, based on the given capabilities, and flags */ + +static void select_offscreen_mode( + WineD3D_GL_Info *gl_info, + int* offscreen_selected) { + + if (gl_info->supported[EXT_FRAMEBUFFER_OBJECT]) + *offscreen_selected = OFFSCREEN_FBO; + else if (pbuffer_support) + *offscreen_selected = OFFSCREEN_PBUFFER; + else + *offscreen_selected = OFFSCREEN_NONE; +} + /** Select the number of report maximum shader constants based on the selected shader modes */ void select_shader_max_constants(WineD3D_GL_Info *gl_info) { @@ -1808,6 +1821,7 @@ static HRESULT WINAPI IWineD3DImpl_GetDe } select_shader_mode(&This->gl_info, DeviceType, &wined3d_settings.ps_selected_mode, &wined3d_settings.vs_selected_mode); + select_offscreen_mode(&This->gl_info, &wined3d_settings.offscreen_selected_mode); select_shader_max_constants(&This->gl_info); /* ------------------------------------------------ @@ -2398,6 +2412,7 @@ static HRESULT WINAPI IWineD3DImpl_Crea LEAVE_GL(); select_shader_mode(&This->gl_info, DeviceType, &wined3d_settings.ps_selected_mode, &wined3d_settings.vs_selected_mode); + select_offscreen_mode(&This->gl_info, &wined3d_settings.offscreen_selected_mode); select_shader_max_constants(&This->gl_info); temp_result = allocate_shader_constants(object->updateStateBlock); diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index e0778c0..40ae793 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -6,6 +6,7 @@ * Copyright 2004 Christian Costa * Copyright 2005 Oliver Stieber * Copyright 2006 Henri Verbeet + * Copyright 2006 Ivan Gyurdiev * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -47,7 +48,7 @@ static const PixelFormatDesc formats[] = {WINED3DFMT_G8R8_G8B8 ,0x0 ,0x0 ,0x0 ,0x0 ,1/*?*/ ,TRUE ,0 ,0 ,0 }, {WINED3DFMT_R8G8_B8G8 ,0x0 ,0x0 ,0x0 ,0x0 ,1/*?*/ ,TRUE ,0 ,0 ,0 }, /* IEEE formats */ - {WINED3DFMT_R32F ,0x0 ,0x0 ,0x0 ,0x0 ,4 ,FALSE ,GL_RGB32F_ARB ,GL_RED ,GL_FLOAT }, + {WINED3DFMT_R32F ,0x0 ,0x0 ,0x0 ,0x0 ,4 ,FALSE ,GL_RGB32F_ARB ,GL_RED ,GL_FLOAT }, {WINED3DFMT_G32R32F ,0x0 ,0x0 ,0x0 ,0x0 ,8 ,FALSE ,0 ,0 ,0 }, {WINED3DFMT_A32B32G32R32F,0x0 ,0x0 ,0x0 ,0x0 ,16 ,FALSE ,GL_RGBA32F_ARB ,GL_RGBA ,GL_FLOAT }, /* Hmm? */ @@ -646,6 +647,41 @@ #undef POOL_TO_STR } } +const char* debug_glerror(GLint err) { + switch (err) { +#define GLERR_TO_STR(p) case p: return #p; + GLERR_TO_STR(GL_NO_ERROR); + GLERR_TO_STR(GL_INVALID_ENUM); + GLERR_TO_STR(GL_INVALID_VALUE); + GLERR_TO_STR(GL_INVALID_OPERATION); + GLERR_TO_STR(GL_STACK_OVERFLOW); + GLERR_TO_STR(GL_STACK_UNDERFLOW); + GLERR_TO_STR(GL_OUT_OF_MEMORY); + GLERR_TO_STR(GL_INVALID_FRAMEBUFFER_OPERATION_EXT); +#undef GLERR_TO_STR + default: + FIXME("Unrecognized %u GL error!\n", err); + return "unrecognized"; + } +} + +const char* debug_fbstatus(GLenum status) { + switch (status) { +#define FBSTATUS_TO_STR(p) case p: return #p; + FBSTATUS_TO_STR(GL_FRAMEBUFFER_COMPLETE_EXT); + FBSTATUS_TO_STR(GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT_EXT); + FBSTATUS_TO_STR(GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS_EXT); + FBSTATUS_TO_STR(GL_FRAMEBUFFER_INCOMPLETE_FORMATS_EXT); + FBSTATUS_TO_STR(GL_FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER_EXT); + FBSTATUS_TO_STR(GL_FRAMEBUFFER_INCOMPLETE_READ_BUFFER_EXT); + FBSTATUS_TO_STR(GL_FRAMEBUFFER_UNSUPPORTED_EXT); +#undef FBSTATUS_TO_STR + default: + FIXME("Unrecognized %#x FB status!\n", status); + return "unrecognized"; + } +} + /***************************************************************************** * Useful functions mapping GL <-> D3D values */ diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index f103705..7d22c0f 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -5,6 +5,7 @@ * Copyright 2002-2003 Raphael Junqueira * Copyright 2004 Jason Edmeades * Copyright 2005 Oliver Stieber + * Copyright 2006 Ivan Gyurdiev * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -127,6 +128,10 @@ #define VS_SW 2 #define PS_NONE 0 #define PS_HW 1 +#define OFFSCREEN_NONE 0 +#define OFFSCREEN_PBUFFER 1 +#define OFFSCREEN_FBO 2 + #define VBO_NONE 0 #define VBO_HW 1 @@ -156,6 +161,7 @@ typedef struct wined3d_settings_s { BOOL glslRequested; int vs_selected_mode; int ps_selected_mode; + int offscreen_selected_mode; /* nonpower 2 function */ int nonpower2_mode; int rendertargetlock_mode; @@ -225,18 +231,28 @@ #define MAX_PALETTES 256 /* Checking of API calls */ /* --------------------- */ -#define checkGLcall(A) \ -{ \ - GLint err = glGetError(); \ - if (err == GL_NO_ERROR) { \ - TRACE("%s call ok %s / %d\n", A, __FILE__, __LINE__); \ - \ - } else do { \ - FIXME(">>>>>>>>>>>>>>>>> %x from %s @ %s / %d\n", \ - err, A, __FILE__, __LINE__); \ - err = glGetError(); \ - } while (err != GL_NO_ERROR); \ -} +const char* debug_glerror(GLint err); +#define checkGLcall(A) \ +{ \ + GLint err = glGetError(); \ + if (err == GL_NO_ERROR) { \ + TRACE("%s call ok %s / %d\n", A, __FILE__, __LINE__); \ + \ + } else do { \ + FIXME(">>>>>>>>>>>>>>>>> %s returned from %s @ %s / %d\n", \ + debug_glerror(err), A, __FILE__, __LINE__); \ + err = glGetError(); \ + } while (err != GL_NO_ERROR); \ +} + +const char* debug_fbstatus(GLenum status); +#define checkGLfbstatus() \ +{ \ + GLenum status = GL_EXTCALL(glCheckFramebufferStatusEXT(GL_FRAMEBUFFER_EXT)); \ + if (status != GL_FRAMEBUFFER_COMPLETE_EXT) \ + FIXME(">>>>>>>>>>>>>>>> %s: incomplete framebuffer status\n", \ + debug_fbstatus(status)); \ +} /* Trace routines / diagnostics */ /* ---------------------------- */ @@ -309,17 +325,17 @@ #endif /* Checking of per-vertex related GL calls */ /* --------------------- */ -#define vcheckGLcall(A) \ -{ \ - GLint err = glGetError(); \ - if (err == GL_NO_ERROR) { \ - VTRACE(("%s call ok %s / %d\n", A, __FILE__, __LINE__)); \ - \ - } else do { \ - FIXME(">>>>>>>>>>>>>>>>> %x from %s @ %s / %d\n", \ - err, A, __FILE__, __LINE__); \ - err = glGetError(); \ - } while (err != GL_NO_ERROR); \ +#define vcheckGLcall(A) \ +{ \ + GLint err = glGetError(); \ + if (err == GL_NO_ERROR) { \ + VTRACE(("%s call ok %s / %d\n", A, __FILE__, __LINE__)); \ + \ + } else do { \ + FIXME(">>>>>>>>>>>>>>>>> %s returned from %s @ %s / %d\n", \ + debug_glerror(err), A, __FILE__, __LINE__); \ + err = glGetError(); \ + } while (err != GL_NO_ERROR); \ } /* TODO: Confirm each of these works when wined3d move completed */ @@ -483,6 +499,7 @@ void dumpResources(ResourceList *resourc /***************************************************************************** * IWineD3DDevice implementation structure */ + typedef struct IWineD3DDeviceImpl { /* IUnknown fields */ @@ -562,8 +579,13 @@ #define NEEDS_DI HRESULT state; BOOL d3d_initialized; - /* Screen buffer resources */ + /* Screen buffer resources. */ glContext contextCache[CONTEXT_CACHE]; + GLuint offscreenFBO; + GLuint offscreenRBO[2]; +#define OFFSCREEN_RBO_DEPTH 0 +#define OFFSCREEN_RBO_STENCIL 1 + BOOL offscreenRendering; /* A flag to check if endscene has been called before changing the render tartet */ BOOL sceneEnded; diff --git a/include/wine/wined3d_gl.h b/include/wine/wined3d_gl.h index 1a589a5..d570d8c 100644 --- a/include/wine/wined3d_gl.h +++ b/include/wine/wined3d_gl.h @@ -1023,6 +1023,7 @@ #define GL_HILO8_NV #define GL_SIGNED_HILO8_NV 0x885F #define GL_FORCE_BLUE_TO_ONE_NV 0x8860 #endif + /* GL_ATI_texture_env_combine3 */ #ifndef GL_ATI_texture_env_combine3 #define GL_ATI_texture_env_combine3 1 -- 1.4.1

3 6

x11dvr: return support for 24bit - but handle them like 32bit
by Christoph Frick 08 Sep '06

08 Sep '06

hiho the game ``NASCAR Racing Season 2003`` from Papyrus actually asks when using the OpenGL driver in the game for 24 bit modes. Otherwise it complains, that it can not find any display modes (it works with 16bit - but the game seem only to accept the modes the current desktop runs in). so what i did is adding the 24bit depth back into the list (last one) and replaced some magic ints and some unused code on my way through this. still this game now does no longer work with wine (it worked a year ago). no it stumbles when calling wglShareLists. License: LGPL ChangeLog: - also list 24bit modes; but still handle them later as 32bit -- cu diff --git a/dlls/winex11.drv/settings.c b/dlls/winex11.drv/settings.c index 5de07eb..f6e2807 100644 --- a/dlls/winex11.drv/settings.c +++ b/dlls/winex11.drv/settings.c @@ -39,7 +39,8 @@ static LPDDHALMODEINFO dd_modes = NULL; static unsigned int dd_mode_count = 0; static unsigned int dd_max_modes = 0; static int dd_mode_default = 0; -static const unsigned int depths[] = {8, 16, 32}; +static const unsigned int depths[] = {8, 16, 32, 24}; +static const unsigned int nr_depths = sizeof(depths) / sizeof(unsigned int); /* pointers to functions that actually do the hard stuff */ static int (*pGetCurrentMode)(void); @@ -62,7 +63,7 @@ LPDDHALMODEINFO X11DRV_Settings_SetHandl TRACE("Resolution settings now handled by: %s\n", name); if (reserve_depths) /* leave room for other depths */ - dd_max_modes = (3+1)*(nmodes); + dd_max_modes = nr_depths*nmodes; else dd_max_modes = nmodes; @@ -111,7 +112,7 @@ void X11DRV_Settings_AddDepthModes(void) int existing_modes = dd_mode_count; DWORD dwBpp = screen_depth; if (dwBpp == 24) dwBpp = 32; - for (j=0; j<3; j++) + for (j=0; j<nr_depths; j++) { if (depths[j] != dwBpp) { @@ -164,8 +165,6 @@ void X11DRV_Settings_Init(void) */ BOOL X11DRV_EnumDisplaySettingsEx( LPCWSTR name, DWORD n, LPDEVMODEW devmode, DWORD flags) { - DWORD dwBpp = screen_depth; - if (dwBpp == 24) dwBpp = 32; devmode->dmDisplayFlags = 0; devmode->dmDisplayFrequency = 0; devmode->dmSize = sizeof(DEVMODEW);

1 0

WGL patches cause problems with RBR and LFS
by Christoph Frick 08 Sep '06

08 Sep '06

hiho i am currently running Mike's (?) mmbranch git version of wine and beside some games are working without problems (or at least no new problems) Richard Burns Rally and Live For Speed quit instantly with the more or less same message, that there are no valid display modes available. using git-bisect i can at least tell, that before Rodericks WGL patches everything was ok - then came at least one patch that broke compilation for me and at some pointer later it does compile but no longer work (so its hard to pinpoint the exact patch, that cause the regression). would someone - preferably Roderick - point me in a direction, what traces are needed to look into this? beside that for both games there are demos out there. i am running the games in desktop mode (non desktop does helps nothing); LFS with UseGLSL and RBR not. -- cu

2 4

Re: Add comments so we know why we are not self-registering some dlls, which most of the time is because it is not doing anything anyway.
by Paul Vriens 08 Sep '06

08 Sep '06

On Thu, 2006-09-07 at 19:54 +0200, Francois Gouget wrote: > +;11,,wintrust.dll,1 FIXME: Just a stub Hi Francois, I'm pretty busy with the registering of wintrust currently, so why is this marked as a stub? Cheers, Paul.

1 0

Re: msi 2: Allow non-key columns to be used with the join query
by James Hawkins 07 Sep '06

07 Sep '06

On 9/7/06, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > This fixes bug 4632. http://bugs.winehq.org/show_bug.cgi?id=4632 > > Changelog: > * Allow non-key columns to be used with the join query. > Ignore this for now. I forgot to remove the second column key check, and I'm going to add a test case for that explicitly. -- James Hawkins

1 0

Re : [DDRAW] Only detach surfaces when releasing a non-texture surface attached to a complex root.
by Elie Morisse 07 Sep '06

07 Sep '06

Le 28.08.2006 18:10:37, Stefan Dösinger a écrit : > Do you mean the game releases the texture manually until it is destroyed??? > Urgh. Can you verify that this doesn't come from DllMain() in > dlls/ddraw/main.c? Nop I checked, and anyway can't be because this occurs also when switching resolutions. > The msdn suggests that destroying the root destroys all sublevels, and it > would be sane, because you create all surfaces with one call, so you should > destroy them with one call. > > If you are right, then every single ddraw application that works on wine now > would leak memory on windows. Well I don't understand, what leaks ? Complex attached surfaces are still destroyed when we fire the root. The new patch takes Moto Racer 2 memleak issues in hand, and Nomad Soul leaks may not be related to this — not a regression because exiting led to crash before ( and remaining surfaces are simple surfaces ). In fact i was a bit unfresh when i posted the patch :P .. > I suspect that something else, like a bad > capatiblity flag, causes weird behavior by the app, so it behaves differently > in wine then on windows, or that the real refcouning issue is that the front > buffer shouldn't be destroyed when the app messes with the back buffer. The > other thing could be that this application has an registry hack on windows: > Windows XP has ddraw compatiblity regitry entries in > HKEY_LOCAL_MACHINE\Software\Microsoft\DirectDraw\Compatiblitity. Can you > check if you find Nomad Soul there? I have no idea what these entries mean, > can you try to remove the whole compatiblity key and try nomad soul again? > (well, backup first :-) ) Hmm I'll try as soon as I procure it. But first tell me if i misunderstood something ;-) > It is hard to prove that a surface is really destroyed or not, but you can > write a regression test which accesses a back buffer which belongs to a > complex back buffer / front buffer compound after the front buffer has been > destroyed?

2 1

Help required to change function prototype
by Andrew Talbot 07 Sep '06

07 Sep '06

Hi, I want to change UnmapViewOfFile() (in kernel) to take a LPCVOID, as per the SDK. To do that, I first need to constify one of the parameters of NtUnmapViewOfSection() (in ntdll), but changing it from PVOID to PCVOID in winternl.h breaks compilation (in the "make depend" stage), thus: In file included from ../../include/thread.h:29, from relay.c:30: ../../include/winternl.h:1933: error: expected declaration specifiers or ... before PCVOID make[2]: *** [relay.o] Error 1 make[1]: *** [winebuild] Error 2 make: *** [tools] Error 2 What am I doing wrong, please? The patch I want to submit is as follows: Changelog: ntdll: Constify a formal parameter. diff -urN a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c --- a/dlls/ntdll/virtual.c 2006-07-31 17:30:58.000000000 +0100 +++ b/dlls/ntdll/virtual.c 2006-09-06 15:04:25.000000000 +0100 @@ -1925,7 +1925,7 @@ * NtUnmapViewOfSection (NTDLL.@) * ZwUnmapViewOfSection (NTDLL.@) */ -NTSTATUS WINAPI NtUnmapViewOfSection( HANDLE process, PVOID addr ) +NTSTATUS WINAPI NtUnmapViewOfSection( HANDLE process, PCVOID addr ) { FILE_VIEW *view; NTSTATUS status = STATUS_INVALID_PARAMETER; diff -urN a/include/winternl.h b/include/winternl.h --- a/include/winternl.h 2006-08-04 17:17:26.000000000 +0100 +++ b/include/winternl.h 2006-09-06 14:57:29.000000000 +0100 @@ -1930,7 +1930,7 @@ NTSTATUS WINAPI NtUnloadKeyEx(POBJECT_ATTRIBUTES,HANDLE); NTSTATUS WINAPI NtUnlockFile(HANDLE,PIO_STATUS_BLOCK,PLARGE_INTEGER,PLARGE_INTEGER,PULONG); NTSTATUS WINAPI NtUnlockVirtualMemory(HANDLE,PVOID*,SIZE_T*,ULONG); -NTSTATUS WINAPI NtUnmapViewOfSection(HANDLE,PVOID); +NTSTATUS WINAPI NtUnmapViewOfSection(HANDLE,PCVOID); NTSTATUS WINAPI NtVdmControl(ULONG,PVOID); NTSTATUS WINAPI NtWaitForSingleObject(HANDLE,BOOLEAN,const LARGE_INTEGER*); NTSTATUS WINAPI NtWaitForMultipleObjects(ULONG,const HANDLE*,BOOLEAN,BOOLEAN,const LARGE_INTEGER*); Thanks, -- Andy.

4 7

wine and dos support
by Vijay Kiran Kamuju 07 Sep '06

07 Sep '06

Hi, A friend of mine is asking me to get dos based games to work using wine. Well, I generally tell to use dosbox for that. Is it possible make them work in wine. If yes, what effort should we put into that. I mean what should we need to implement. Is it possible to lift some parts of other LGPL dos projects. Thanks, VJ

1 0

Re: tools: Remove redundant NULL checks before free() (found by Smatch).
by Robert Shearman 07 Sep '06

07 Sep '06

I think the checks are necessary to be compatible with libc's on other platforms. -- Rob Shearman

2 1

Should I give up?
by Damjan Jovanovic 07 Sep '06

07 Sep '06

Hi My work on the still image system for wine has highlighted a bug in setupapi's SetupDiOpenClassRegKeyExW(). In short, the registry keys for device classes have the form HKEY_LOCAL_MACHINE\System\CurrentControlSet\ Class\{xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx} while wine incorrectly tries to open HKEY_LOCAL_MACHINE\System\CurrentControlSet\ Class\xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx ie. no curly braced around the guid. And in addition it incorrectly returns FALSE for a return type of HKEY (instead of INVALID_HANDLE_VALUE). I've submitted a test and patch to wine-patches 7 times now, and received very little feedback, which I've always followed. If this is how difficult it is to submit a patch, no wonder I hear people complaining about how wine doesn't have enough developers. How are you ever going to accept my still image code, which is 4000+ lines long and growing, when you can't accept a simple 182 line long patch? Normally I'm very patient - but this is ridiculous. I'm attaching my latest patch and would appreciate any comments. Thank you Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --- a/dlls/setupapi/tests/Makefile.in 2006-07-10 18:01:08.000000000 +0200 +++ b/dlls/setupapi/tests/Makefile.in 2006-08-31 21:29:12.000000000 +0200 @@ -3,7 +3,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = setupapi.dll -IMPORTS = setupapi kernel32 +IMPORTS = setupapi kernel32 advapi32 rpcrt4 CTESTS = \ devinst.c \ --- a/dlls/setupapi/devinst.c 2006-08-28 20:35:44.000000000 +0200 +++ b/dlls/setupapi/devinst.c 2006-08-31 22:27:19.000000000 +0200 @@ -1413,6 +1413,7 @@ PVOID Reserved) { LPWSTR lpGuidString; + LPWSTR lpBracedGuidString; HKEY hClassesKey; HKEY hClassKey; LPCWSTR lpKeyName; @@ -1453,21 +1454,30 @@ if (UuidToStringW((UUID*)ClassGuid, &lpGuidString) != RPC_S_OK) { RegCloseKey(hClassesKey); - return FALSE; + return INVALID_HANDLE_VALUE; } + lpBracedGuidString = (LPWSTR) HeapAlloc(GetProcessHeap(), 0, + (1 + strlenW(lpGuidString) + 1 + 1) * sizeof(WCHAR)); + lpBracedGuidString[0] = (WCHAR) '{'; + memcpy(&lpBracedGuidString[1], lpGuidString, + strlenW(lpGuidString) * sizeof(WCHAR)); + lpBracedGuidString[1 + strlenW(lpGuidString)] = (WCHAR) '}'; + lpBracedGuidString[1 + strlenW(lpGuidString) + 1] = (WCHAR) 0; + RpcStringFreeW(&lpGuidString); + if (RegOpenKeyExW(hClassesKey, - lpGuidString, + lpBracedGuidString, 0, KEY_ALL_ACCESS, &hClassKey)) { - RpcStringFreeW(&lpGuidString); + RpcStringFreeW(&lpBracedGuidString); RegCloseKey(hClassesKey); - return FALSE; + return INVALID_HANDLE_VALUE; } - RpcStringFreeW(&lpGuidString); + RpcStringFreeW(&lpBracedGuidString); RegCloseKey(hClassesKey); return hClassKey; --- a/dlls/setupapi/tests/devinst.c 2006-08-28 20:35:53.000000000 +0200 +++ b/dlls/setupapi/tests/devinst.c 2006-08-31 22:14:36.000000000 +0200 @@ -26,6 +26,7 @@ #include "wingdi.h" #include "winuser.h" #include "winreg.h" +#include "rpc.h" #include "setupapi.h" #include "wine/test.h" @@ -34,6 +35,7 @@ static HMODULE hSetupAPI; static HDEVINFO (WINAPI *pSetupDiCreateDeviceInfoListExW)(GUID*,HWND,PCWSTR,PVOID); static BOOL (WINAPI *pSetupDiDestroyDeviceInfoList)(HDEVINFO); +static HKEY (WINAPI *pSetupDiOpenClassRegKeyExW)(GUID*,REGSAM,DWORD,PCWSTR,PVOID); static void init_function_pointers(void) { @@ -43,6 +45,7 @@ { pSetupDiCreateDeviceInfoListExW = (void *)GetProcAddress(hSetupAPI, "SetupDiCreateDeviceInfoListExW"); pSetupDiDestroyDeviceInfoList = (void *)GetProcAddress(hSetupAPI, "SetupDiDestroyDeviceInfoList"); + pSetupDiOpenClassRegKeyExW = (void *)GetProcAddress(hSetupAPI, "SetupDiOpenClassRegKeyExW"); } } @@ -79,6 +82,86 @@ ok(ret, "SetupDiDestroyDeviceInfoList failed : %ld\n", error); } +static void test_SetupDiOpenClassRegKeyExW() +{ + GUID guid; + RPC_STATUS rpcStatus; + HKEY hkey; + WCHAR *unbracedGuid; + WCHAR *bracedGuid; + + rpcStatus = UuidCreate(&guid); + if (rpcStatus != RPC_S_OK) + { + ok(FALSE, "failed to generate test guid, error %ld", rpcStatus); + return; + } + + /* Check return value for non-existant key */ + hkey = pSetupDiOpenClassRegKeyExW(&guid, KEY_ALL_ACCESS, + DIOCR_INSTALLER, NULL, NULL); + ok(hkey == INVALID_HANDLE_VALUE, + "invalid return value %p from SetupDiOpenClassRegKeyExW " + "for non-existant key, expected %p\n", hkey, INVALID_HANDLE_VALUE); + + rpcStatus = UuidToStringW(&guid, &unbracedGuid); + if (rpcStatus != RPC_S_OK) + { + ok(FALSE, "failed to get string form of guid, error %ld", rpcStatus); + return; + } + + bracedGuid = HeapAlloc(GetProcessHeap(), 0, + (lstrlenW(unbracedGuid) + 3) * sizeof(WCHAR)); + if (bracedGuid != NULL) + { + HKEY classesKey; + + bracedGuid[0] = (WCHAR) '{'; + memcpy(&bracedGuid[1], unbracedGuid, + lstrlenW(unbracedGuid) * sizeof(WCHAR)); + bracedGuid[1 + lstrlenW(unbracedGuid)] = (WCHAR) '}'; + bracedGuid[1 + lstrlenW(unbracedGuid) + 1] = (WCHAR) 0; + + SetLastError(0xdeadbeef); + classesKey = pSetupDiOpenClassRegKeyExW(NULL, KEY_ALL_ACCESS, + DIOCR_INSTALLER, NULL, NULL); + ok(classesKey != INVALID_HANDLE_VALUE, + "failed to open the device classes registry key: error %ld\n", + GetLastError()); + if (classesKey != INVALID_HANDLE_VALUE) + { + DWORD ret; + HKEY classKey; + ret = RegCreateKeyW(classesKey, bracedGuid, &classKey); + if (ret == ERROR_SUCCESS) + { + RegCloseKey(classKey); + SetLastError(0xdeadbeef); + classKey = pSetupDiOpenClassRegKeyExW(&guid, KEY_ALL_ACCESS, + DIOCR_INSTALLER, NULL, NULL); + ok(classKey != INVALID_HANDLE_VALUE, + "failed opening class key, error %ld\n", GetLastError()); + ret = RegCloseKey(classKey); + ok(ret == ERROR_SUCCESS, + "failed closing class key, error %ld\n", ret); + + RegDeleteKeyW(classesKey, bracedGuid); + } + else + ok(FALSE, "failed creating device key: error %ld\n", ret); + + RegCloseKey(classesKey); + } + + HeapFree(GetProcessHeap(), 0, bracedGuid); + } + else + ok(FALSE, "failed to allocate memory for braced guid\n"); + + RpcStringFreeW(&unbracedGuid); +} + START_TEST(devinst) { init_function_pointers(); @@ -88,5 +171,10 @@ if (pSetupDiCreateDeviceInfoListExW && pSetupDiDestroyDeviceInfoList) test_SetupDiCreateDeviceInfoListEx(); else - trace("Needed calls not all available, skipping tests.\n"); + trace("Needed calls for SetupDiCreateDeviceInfoListEx not all available, skipping test.\n"); + + if (pSetupDiOpenClassRegKeyExW) + test_SetupDiOpenClassRegKeyExW(); + else + trace("Needed call for SetupDiOpenClassRegKeyExW not available, skipping test.\n"); }

6 5

Re: user: test and fix SwitchToThisWindow [2nd try]
by James Hawkins 07 Sep '06

07 Sep '06

On 9/7/06, Jan Zerebecki <jan.wine(a)zerebecki.de> wrote: > Bugreport about this patch: http://bugs.winehq.org/show_bug.cgi?id=5725 > I compiled-tested this and successfully ran the test on wine and > (thx kblin) on native, because the author said that he is not > able to compile wine. > > If this patch is rejected from inclusion, please tell me why, as > I would have to ask anyway. > > From: Neil Rashbrook <neil(a)parkwaycc.co.uk> > Changelog: > user: test and fix SwitchToThisWindow > > --- > > dlls/user/tests/Makefile.in | 1 > dlls/user/tests/win_sttw.c | 127 +++++++++++++++++++++++++++++++++++++++++++ > dlls/user/winpos.c | 15 +++++ > 3 files changed, 142 insertions(+), 1 deletions(-) > > diff --git a/dlls/user/tests/Makefile.in b/dlls/user/tests/Makefile.in > index 7a78a5b..4e10563 100644 > --- a/dlls/user/tests/Makefile.in > +++ b/dlls/user/tests/Makefile.in > @@ -23,6 +23,7 @@ CTESTS = \ > sysparams.c \ > text.c \ > win.c \ > + win_sttw.c \ > winstation.c \ > wsprintf.c > Why is this in a new file? It should be in win.c. -- James Hawkins

1 0

Google SOC projects Success/Failure
by Vijay Kiran Kamuju 06 Sep '06

06 Sep '06

Hi, As the Google SOC concluded. We need to evaluate whether our SOC projects were successfull or not. Some of them got through like Oleview, Trash implementation, riched20 improvisation. I really dont know about the clamav integration, shell integration (there were some patches regarding this I think), improve mswscock.dll and ntlm using gensec. Wineconf is about to start, I think we need to re-think what might be good additions and how should we proceed for 1.0 release. I see about 50-60% success in the SOC - 2006. There were a lotta widl improvements, this thing should have been a SOC project ;) Please feel to comment on this. Thanks, VJ

2 1

Wineconf 06 Keysigning
by David Gümbel 06 Sep '06

06 Sep '06

Hi, at Wineconf 2005, we've had a quite successful GPG key signing party. Thus, I'd like to volunteer for organizing a GPG keysigning party at Wineconf 2006 as well. Quoting last year's party organizer (Shachar Shemesh), anyone who wishes to participate, please: 1. Have a PGP key. You can generate one for yourself using gpg. 2. Send the PGP (public) key and its finger print to me AT THE VERY LATEST ON TUESDAY 12. Any later then that, and it is not certain that we'll manage to get your key on the printed piece of paper that is necessary for carrying out the party. 3. Bring a copy you can trust to wineconf, to make sure other people are really signing your key (i.e. - that I'm not pulling anybody's leg). 4. Bring an identifying ID to wineconf. Two is preferable. Passport or a driver license in a language people can read. If you can only bring one, a passport is definitely preferable. The full details of what a key signing party is, why are the procedures as they are, and what's so important about *not* signing the keys with your laptop at the party can be found at http://www.cryptnet.net/fdp/crypto/gpg-party.html Note: No aliases on PGP keys. If your PGP key says "lord master of compiler optimization", then your passport had better say the same or no one will be able to sign your key. Also, if you DON'T want the key published to a key server, please let me know well in advance. Obviously, your key will be published to all the people present at the key party. If your name's not there on your email headers, include it in the body. The name must be the same as appears on your formal IDs. The purpose of a pgp signing party is to establish a link between your virtual identity (your key) and your real one (as verified by an ID). For that reason it is impossible to participate by proxy, or under an alias. Cheers David

1 0

Re: regedit: also refresh the listview
by Vitaliy Margolen 06 Sep '06

06 Sep '06

Jan Zerebecki wrote: > case ID_VIEW_REFRESH: > RefreshTreeView(g_pChildWnd->hTreeWnd); > - /*RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath, NULL); */ > + RefreshListView(g_pChildWnd->hListWnd, hKeyRoot, keyPath, NULL); > break; There was a reason why it was commented in the first place. Please indicate what has changed that you can enable it now. Vitaliy.

2 1

Re: LOSTWAGES: press update
by Paul Vriens 06 Sep '06

06 Sep '06

On Wed, 2006-09-06 at 12:58 -0400, Tom Wickline wrote: > Hello, > > If I overlooked something send me the link. > > Tom > > Changelog: update the press page Hi Tom, the latest edition of Tux Magazine (http://www.tuxmagazine.com/) has some stuff about CrossOver Office, Cedega and Wine. Cheers, Paul.

2 1

winehq.org Announcements
by EA Durbin 06 Sep '06

06 Sep '06

Why is there no release announcement for the 0.9.20 release of wine on the homepage?

4 4

Re: LOSTWAGES: who's who
by Christoph Frick 06 Sep '06

06 Sep '06

On Wed, Sep 06, 2006 at 10:21:42AM -0400, Tom Wickline wrote: > -<h3>Jason Edmeades</h3><blockquote> > -<h3>Jukka Heinonen</h3><blockquote> > -<h3>Ove Kåven</h3><blockquote> > -<h3>Shachar Shemesh</h3><blockquote> > -<h3>Oliver Stieber</h3><blockquote> > -<h3>Greg Turner</h3><blockquote> would it not be more kind to move the "veterans" into their own section instead of removing them at all? at least they managed to get in this list by their previous contributions to the project. please ignore this, if i intercepted with this mail further patches in that direction ;) -- cu

2 1

Re: [crypt32] Fix TRACE when using a numeric identifier
by Detlef Riekenberg 06 Sep '06

06 Sep '06

Hi Paul: > When tracing is on for crypt we crashed. > + if (!HIWORD(pszOID)) > + TRACE("(%lx, %s, #%d, %s, %s)\n", dwEncodingType, pszFuncName, LOWORD(pszOID), > + debugstr_w(pwszDll), pszOverrideFuncName); debugstr_a() does this for you. + TRACE("(%lx, %s, %s, %s, %s)\n", dwEncodingType, pszFuncName, + debugstr_w(pszOID), debugstr_w(pwszDll), pszOverrideFuncName); You might want to use debugstr_a() also for the other strings (*FuncName) -- By by ... Detlef

1 0

Re: [wintrust] Add a bunch of CryptRegisterOIDFunction calls
by Paul Vriens 06 Sep '06

06 Sep '06

On Wed, 2006-09-06 at 13:16 +0200, Paul Vriens wrote: > Hi, > > 2/3 of the registration of wintrust is done with this patch. The only thing > left is some CryptSIPAddProvider calls. > > Changelog > Add a bunch of CryptRegisterOIDFunction calls > > Cheers, > > Paul. > --- Wait with this one, I'll sent a new one soon, that also takes care of possible errors returned by CryptRegisterOIDFunction. That however means changing CryptRegisterOIDFunction as well. Cheers, Paul.

1 0

Re: LPGL functions in Reactos that are stub in Wine
by jimtabor 06 Sep '06

06 Sep '06

Julien wrote: >/ I was very interested in comparing the implementation status of reactos />/ and wine. So I coded a little python script to list all the api that are />/ implemented in reactos AND are only stub in wine. Attached to this mail />/ is the list of identified functions. />/ />/ One may note that most of these functions are in the setupapi dll. This />/ is particularly interesting as the setupapi code is LGPL-licenced in />/ Reactos (and was already part of the audit). / Code that originates in ReactOS will generally not be accepted into Wine due to that project's acceptance of developers that participate in "dirty" reverse engineering (ie. translating assembly code to C). Please don't submit code from ReactOS to wine-patches. Mike Hi Mike, Please do not post things like this. Thanks, James

2 1

Re: [wintrust 1/8] Register WIN_SPUB_ACTION_PUBLISHED_SOFTWARE
by James Hawkins 06 Sep '06

06 Sep '06

On 9/5/06, Paul Vriens <Paul.Vriens(a)xs4all.nl> wrote: > Hi, > > first patch of 8 to add several Trust Provider to the registry. I've decided > to have a function for every Trust Provider instead of grouping common stuff > together as this can change. The MSDN pages for wintrust seem to be changing > a lot lately. > > Once the last registration patch is done (and that will take another week or > so) I'll cleanup up the unnecessary comments and TRACE's. > If they're unnecessary and you're going to take them out at some point, why not just leave them out of the patches from the beginning? -- James Hawkins

2 1

Temporary Git tree available
by Mike McCormack 05 Sep '06

05 Sep '06

Hi All, As Alexandre has gone on holidays for a week, I've made available a temporary Git tree containing most patches sent to wine-patches. You can pull my branch into your existing Git checkout as follows: git fetch http://mandoo.dyndns.org/wine.git master:mmbranch git rebase mmbranch If you have an existing mmbranch, you probably want to delete it using: git branch -d mmbranch Mike $ git log origin.. commit 5d6e51717f24a594d793e8fde930a4a28df37ef0 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 17:19:21 2006 -0700 widl: Remove obsolete handling of typedefs commit f5fc2d59c121d13fe86d13d21c02ec6c6ba29eef Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:29:06 2006 -0700 widl: Generate an error for "int f(void a)" commit c0299c2b3e6c1fa4e14feeab1723ca7c545e9699 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:28:05 2006 -0700 widl: Print pointers using better style commit 41f540217f9bd03819be3f6154c03c06d98ec031 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:27:27 2006 -0700 widl: Add an is_ptr function commit e20f80716e8b352d72a1d86381d1f405e58ee19e Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:26:43 2006 -0700 widl: Factor the entry_t structure commit cd0ee17b195070962f97c5ac16b73dfd37e63620 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:26:03 2006 -0700 widl: Represent typedefs with easier to use structures commit 52ad5914edf8169610cb20ed20de6c2ec21869b4 Author: Dan Hipschman <dsh(a)linux.ucla.edu> Date: Tue Aug 29 14:25:19 2006 -0700 widl: Generate names for tagless structs, unions and enums commit e6bde7d70b930e37079faa46a340b206e1276933 Author: Paul Vriens <Paul.Vriens(a)xs4all.nl> Date: Tue Aug 29 17:57:35 2006 +0200 wintrust: Add some extra tests for WintrustRemoveActionID commit 13651132d7337f90d6d0b403261e5e30bc35a04d Author: James Hawkins <truiken(a)gmail.com> Date: Tue Aug 29 15:12:39 2006 -0700 advpack: Add the regsvr action to the SetupInstallFromInfSection call commit 6d26805474edc8bbdd201fdeb070e766e3102485 Author: James Hawkins <truiken(a)gmail.com> Date: Tue Aug 29 15:12:22 2006 -0700 advpack: Get the proper working directory in install_init commit e090dee9838d5dcfcc73464e7427f075e7d19bdc Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Tue Aug 29 16:58:49 2006 +0200 opengl32: import glx makecurrent/wglsharelists commit 8d410088146faa56701c440daa4ae350985feff9 Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Tue Aug 29 16:56:57 2006 +0200 opengl32: import glx context code commit e012ffe349a279b939a7b49f7439dd1cd1cd901e Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:51:27 2006 -0700 oleaut32: Test for correct error codes and return type for VarAnd commit 4dec3ee04b237a615bf0eb228c3b343ea537a6ca Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:50:05 2006 -0700 oleaut32: Updates variant:VarAnd to pass all failures exposed from conformance test commit 9e1fa3f6afb808eb0750404180ec7ff30c0a4db0 Author: Benjamin Arai <me(a)benjaminarai.com> Date: Tue Aug 29 17:49:29 2006 -0700 oleaut32: Conformance test for vartest:VarAnd checks for correct result values commit 75d7a735bc4447d099968b78b08de8cc7db8ebe2 Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Aug 29 21:46:49 2006 +0200 wined3d: Avoid wasting a uniform commit 4056ee5dae9ce52b94f518a850c13dfee478e56d Author: Robert Reif <reif(a)earthlink.net> Date: Tue Aug 29 19:34:31 2006 -0400 advapi32: fix lsa tests on windows98 commit b09802de14406bf2a358c256f2b186e15efde08d Author: mike <mike(a)codeweavers.com> Date: Wed Aug 30 12:55:27 2006 +0900 ddraw: Make tests pass when OpenGL libraries aren't present. commit 835596de7066b84a88f6182d4fab4dda1832456a Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Aug 29 23:12:16 2006 +0100 comctl32: Cast-qual warnings fix commit b40c568d9215e906ca1521197fd3060c75fb6e5a Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:16:44 2006 +0100 rpcrt4: Make the reference counting in the standard proxy thread-safe. commit 5bf357288caf3b5eb5766d6bcade4f49fbd80084 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:14:42 2006 +0100 rpcrt4: Fix NdrStubGetBuffer to use the IRpcChannelBuffer object since IRpcChannelBuffer_GetBuffer may put extra data onto the wire for ORPC calls. commit d63bda52650573e7ec62ca3fae707a231cfbbc6c Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:14:05 2006 +0100 rpcrt4: Remove some unused code. commit e888c667006107145f719537f3a169b797720cfd Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:12:42 2006 +0100 rpcrt4: Move NdrStub* functions to cstub.c and move NdrProxy* functions to cproxy.c since both sets of functions depend on the implementations of the standard stubs and proxies. commit 0879b1e305e4ad329f35c22d97a4765ea54be3c9 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:12:16 2006 +0100 oleaut32: Delay the creation of the stub object for IDispatch until it is actually used. commit 337f886bab59f5fd7ab22d74ae3c712b593bd1e6 Author: Robert Shearman <rob(a)codeweavers.com> Date: Tue Aug 29 21:11:12 2006 +0100 oleaut32: Fix a leak of the module reference count. commit d77bea6f8c896304a809e0b9834b1b52072a1901 Author: Andrew Talbot <Andrew.Talbot(a)talbotville.com> Date: Tue Aug 29 20:12:39 2006 +0100 advpack: Cast-qual warnings fix commit 206411e8032c25f82f738cf065cb2497aa63d96f Author: Paul Vriens <Paul.Vriens(a)xs4all.nl> Date: Tue Aug 29 19:33:00 2006 +0200 wintrust: Add some documentation commit 91a8502d1dcb65509128c602211b87d05aec8e6d Author: Renu Rajput <renu.rajput(a)gmail.com> Date: Tue Aug 29 13:50:16 2006 +0530 comdlg32: Send missing CDN_FOLDERCHANGE

2 4

Re: [wintrust] Register WINTRUST_ACTION_GENERIC_VERIFY_V2 (TRY 2)
by Juan Lang 04 Sep '06

04 Sep '06

Hi Paul, + * Write a singe value and it's data to: s/singe/single/, s/it's/its/ + /* Turn OID into a wide-character string */ + Len = MultiByteToWideChar( CP_ACP, 0, OID, -1, NULL, 0 ); + OIDW = HeapAlloc( GetProcessHeap(), 0, Len * sizeof(WCHAR) ); + MultiByteToWideChar( CP_ACP, 0, OID, -1, OIDW, Len ); + + /* Allocate the needed space for UsageKey */ + UsageKey = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(Trust) + lstrlenW(Usages) + Len) * sizeof(WCHAR)); You can avoid one HeapAlloc by calculating Len as you do, but not converting OID to a wide-char string until you've allocated UsageKey. Something like: len = MultiByteToWideChar( CP_ACP, 0, OID, -1, NULL, 0 ); UsageKey = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(Trust) + lstrlenW(Usages) + len) * sizeof(WCHAR)); lstrcpyW(UsageKey, Trust); lstrcatW(UsageKey, Usages); MultiByteToWideChar( CP_ACP, 0, OID, -1, UsageKey + lstrlenW(Trust) + lstrlenW(Usages), len ); Note also that OID can't contain multibyte characters, so you may use a loop to copy it character by character to UsageKey instead of calling MultiByteToWideChar, if you prefer. + HeapFree(GetProcessHeap(), 0, OIDW); You leak UsageKey here. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

LPGL functions in Reactos that are stub in Wine
by Julien 04 Sep '06

04 Sep '06

Hello all, I was very interested in comparing the implementation status of reactos and wine. So I coded a little python script to list all the api that are implemented in reactos AND are only stub in wine. Attached to this mail is the list of identified functions. One may note that most of these functions are in the setupapi dll. This is particularly interesting as the setupapi code is LGPL-licenced in Reactos (and was already part of the audit). I tried to port some of these to Wine, but this requires more knowledge than I have. So, is someone interested to port these functions? Best, Julien AssertFail CMP_Init_Detection CMP_Report_LogOn CM_Add_IDA CM_Add_IDA CM_Add_IDW CM_Add_IDW CM_Add_ID_ExA CM_Add_ID_ExA CM_Add_ID_ExW CM_Add_ID_ExW CM_Connect_MachineA CM_Connect_MachineA CM_Create_DevNodeA CM_Create_DevNodeA CM_Create_DevNodeW CM_Create_DevNodeW CM_Create_DevNode_ExA CM_Create_DevNode_ExA CM_Create_DevNode_ExW CM_Create_DevNode_ExW CM_Delete_Class_Key CM_Delete_Class_Key CM_Delete_Class_Key_Ex CM_Delete_Class_Key_Ex CM_Disable_DevNode CM_Disable_DevNode CM_Disable_DevNode_Ex CM_Disable_DevNode_Ex CM_Enable_DevNode CM_Enable_DevNode CM_Enable_DevNode_Ex CM_Enable_DevNode_Ex CM_Enumerate_Classes CM_Enumerate_Classes CM_Enumerate_Classes_Ex CM_Enumerate_Classes_Ex CM_Enumerate_EnumeratorsA CM_Enumerate_EnumeratorsA CM_Enumerate_EnumeratorsW CM_Enumerate_EnumeratorsW CM_Enumerate_Enumerators_ExA CM_Enumerate_Enumerators_ExA CM_Enumerate_Enumerators_ExW CM_Enumerate_Enumerators_ExW CM_Get_Child CM_Get_Child CM_Get_Child_Ex CM_Get_Child_Ex CM_Get_Class_Key_NameA CM_Get_Class_Key_NameA CM_Get_Class_Key_NameW CM_Get_Class_Key_NameW CM_Get_Class_Key_Name_ExA CM_Get_Class_Key_Name_ExA CM_Get_Class_Key_Name_ExW CM_Get_Class_Key_Name_ExW CM_Get_Class_NameA CM_Get_Class_NameA CM_Get_Class_NameW CM_Get_Class_NameW CM_Get_Class_Name_ExA CM_Get_Class_Name_ExA CM_Get_Class_Name_ExW CM_Get_Class_Name_ExW CM_Get_Depth CM_Get_Depth CM_Get_Depth_Ex CM_Get_Depth_Ex CM_Get_DevNode_Registry_PropertyA CM_Get_DevNode_Registry_PropertyA CM_Get_DevNode_Registry_PropertyW CM_Get_DevNode_Registry_PropertyW CM_Get_DevNode_Registry_Property_ExA CM_Get_DevNode_Registry_Property_ExA CM_Get_DevNode_Registry_Property_ExW CM_Get_DevNode_Registry_Property_ExW CM_Get_DevNode_Status CM_Get_DevNode_Status CM_Get_DevNode_Status_Ex CM_Get_DevNode_Status_Ex CM_Get_Device_IDW CM_Get_Device_IDW CM_Get_Device_ID_ExA CM_Get_Device_ID_ExA CM_Get_Device_ID_ExW CM_Get_Device_ID_ExW CM_Get_Device_ID_ListW CM_Get_Device_ID_ListW CM_Get_Device_ID_List_ExA CM_Get_Device_ID_List_ExA CM_Get_Device_ID_List_ExW CM_Get_Device_ID_List_ExW CM_Get_Device_ID_List_SizeA CM_Get_Device_ID_List_SizeA CM_Get_Device_ID_List_SizeW CM_Get_Device_ID_List_SizeW CM_Get_Device_ID_List_Size_ExA CM_Get_Device_ID_List_Size_ExA CM_Get_Device_ID_List_Size_ExW CM_Get_Device_ID_List_Size_ExW CM_Get_Device_ID_Size_Ex CM_Get_Device_ID_Size_Ex CM_Get_Global_State CM_Get_Global_State CM_Get_Global_State_Ex CM_Get_Global_State_Ex CM_Get_Parent CM_Get_Parent CM_Get_Parent_Ex CM_Get_Parent_Ex CM_Get_Sibling CM_Get_Sibling CM_Get_Sibling_Ex CM_Get_Sibling_Ex CM_Get_Version CM_Get_Version CM_Get_Version_Ex CM_Get_Version_Ex CM_Is_Dock_Station_Present CM_Is_Dock_Station_Present CM_Locate_DevNodeA CM_Locate_DevNodeA CM_Locate_DevNodeW CM_Locate_DevNodeW CM_Locate_DevNode_ExA CM_Locate_DevNode_ExA CM_Locate_DevNode_ExW CM_Locate_DevNode_ExW CM_Move_DevNode CM_Move_DevNode CM_Move_DevNode_Ex CM_Move_DevNode_Ex CM_Open_Class_KeyA CM_Open_Class_KeyA CM_Open_Class_KeyW CM_Open_Class_KeyW CM_Open_Class_Key_ExA CM_Open_Class_Key_ExA CM_Open_Class_Key_ExW CM_Open_Class_Key_ExW CM_Reenumerate_DevNode CM_Reenumerate_DevNode CM_Reenumerate_DevNode_Ex CM_Reenumerate_DevNode_Ex CM_Request_Eject_PC CM_Request_Eject_PC CM_Run_Detection CM_Run_Detection CM_Run_Detection_Ex CM_Run_Detection_Ex CM_Set_DevNode_Problem CM_Set_DevNode_Problem CM_Set_DevNode_Problem_Ex CM_Set_DevNode_Problem_Ex CM_Set_DevNode_Registry_PropertyA CM_Set_DevNode_Registry_PropertyA CM_Set_DevNode_Registry_PropertyW CM_Set_DevNode_Registry_PropertyW CM_Set_DevNode_Registry_Property_ExA CM_Set_DevNode_Registry_Property_ExA CM_Set_DevNode_Registry_Property_ExW CM_Set_DevNode_Registry_Property_ExW CM_Setup_DevNode CM_Setup_DevNode CM_Setup_DevNode_Ex CM_Setup_DevNode_Ex CM_Uninstall_DevNode CM_Uninstall_DevNode CM_Uninstall_DevNode_Ex CM_Uninstall_DevNode_Ex CenterWindowRelativeToParent ConcatenatePaths GetSetFileTimestamp GetVersionInfoFromImage MyGetFileTitle RpcBindingCopy RpcSmDestroyClientContext RpcSsDestroyClientContext SetupDiBuildDriverInfoList SetupDiChangeState SetupDiCreateDevRegKeyA SetupDiCreateDevRegKeyW SetupDiDeleteDeviceInfo SetupDiDestroyDriverInfoList SetupDiEnumDriverInfoA SetupDiEnumDriverInfoW SetupDiGetClassDevPropertySheetsA SetupDiGetClassDevPropertySheetsW SetupDiGetDeviceInfoListClass SetupDiGetDeviceInstallParamsW SetupDiGetDeviceInstanceIdA SetupDiGetDeviceInstanceIdW SetupDiGetDeviceRegistryPropertyW SetupDiGetDriverInfoDetailA SetupDiGetDriverInfoDetailW SetupDiGetINFClassA SetupDiGetINFClassW SetupDiGetSelectedDevice SetupDiGetSelectedDriverA SetupDiGetSelectedDriverW SetupDiInstallClassExA SetupDiInstallClassExW SetupDiInstallDevice SetupDiInstallDriverFiles SetupDiLoadClassIcon SetupDiOpenDeviceInfoA SetupDiOpenDeviceInfoW SetupDiRegisterDeviceInfo SetupDiRemoveDevice SetupDiSelectDevice SetupDiSetClassInstallParamsW SetupDiSetDeviceInstallParamsW SetupDiSetDeviceRegistryPropertyA SetupDiSetDeviceRegistryPropertyW SetupDiSetSelectedDevice SetupDiSetSelectedDriverA SetupDiSetSelectedDriverW SetupDiUnremoveDevice SetupGetInfFileListA SetupGetInfFileListW SetupInstallServicesFromInfSectionA SetupInstallServicesFromInfSectionExA SetupInstallServicesFromInfSectionExW SetupInstallServicesFromInfSectionW SetupPromptReboot

8 12

Re: wined3d: Avoid crashing when ProcessVertices is called with NULL vertex declaration
by H. Verbeet 04 Sep '06

04 Sep '06

On 04/09/06, Paul Chitescu <pchitescu(a)voip.null.ro> wrote: > Changelog: Avoid a segfault in IWineD3DDeviceImpl_ProcessVertices by checking > if SrcImpl (parameter pVertexDecl) is NULL. > > The function is called from dlls/d3d8/device.c > IDirect3DDevice8Impl_ProcessVertices with an explicit NULL as vertex > declaration parameter. > > Crash was observed in Age of Mythology Trial. > This doesn't look correct to me, the call does effectively nothing for d3d8 now.

3 3

Re: [WINED3D 3/3] Add support for R32F and R16F texture formats
by Frank Richter 04 Sep '06

04 Sep '06

On 04.09.2006 07:33, Ivan Gyurdiev wrote: > ... using: > GL_ARB_texture_float > GL_ARB_half_float_pixel > > The internal format is RGB16/32F, which is wasteful (2 unused colors), > but there's no way around that. What about INTENSITY or LUMINANCE textures? -f.r.

2 1

Re: How to use a windows dll in linux
by mesmith.18885136＠bloglines.com 04 Sep '06

04 Sep '06

Thanks for the helpful replies. I have been working on the Winelib approach suggested by Jeremy. As my first step I wanted to get a windows console application to compile and run anyway. I now have an executable that runs and calls functions in the windows dll, but it does not work correctly. If I run it with winedbg it gives me a backtrace with errors coming from deep inside the dll. I assume there is some problem with the arguments going to the function that serves as the entry to the dll. Is there a way to find out what is getting passed to the dll and/or debugging inside the dll (without source code)? Thanks, Mark

2 1

How to deal with both git trees
by Paul Vriens 04 Sep '06

04 Sep '06

Hi, I've sent in a patch that got some remarks by Juan Lang. The patch is already applied to mmbranch. Most patches sent to wine-patches that have (valid) comments will not be applied by AJ. Should I now resend to make sure it gets applied when AJ is back AND sent a patch to fixup mmbranch. Or will the previous one be reverted and the next applied to mmbranch? Cheers, Paul.

2 1

Build problems with latest mmbranch
by Paul Vriens 04 Sep '06

04 Sep '06

Hi, 'make depend && make' gives: make[2]: Entering directory `/wine/wine-git/dlls/opengl32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o wgl.o wgl.c wgl.c:104: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘p_glXGetProcAddressARB’ wgl.c: In function ‘wglGetProcAddress’: wgl.c:325: error: ‘p_glXGetProcAddressARB’ undeclared (first use in this function) wgl.c:325: error: (Each undeclared identifier is reported only once wgl.c:325: error: for each function it appears in.) wgl.c:341: warning: implicit declaration of function ‘p_glXGetProcAddressARB’ wgl.c:341: warning: assignment makes pointer from integer without a cast wgl.c: At top level: wgl.c:912: error: expected declaration specifiers or ‘...’ before ‘glXGetProcAddressARB_t’ wgl.c: In function ‘wgl_initialize_glx’: wgl.c:964: warning: implicit declaration of function ‘proc’ wgl.c:964: warning: assignment makes pointer from integer without a cast wgl.c:965: warning: assignment makes pointer from integer without a cast wgl.c:966: warning: assignment makes pointer from integer without a cast wgl.c:971: warning: assignment makes pointer from integer without a cast wgl.c:972: warning: assignment makes pointer from integer without a cast wgl.c:973: warning: assignment makes pointer from integer without a cast wgl.c:985: warning: assignment makes pointer from integer without a cast wgl.c:988: warning: assignment makes pointer from integer without a cast wgl.c:989: warning: assignment makes pointer from integer without a cast wgl.c: In function ‘process_attach’: wgl.c:1066: error: ‘p_glXGetProcAddressARB’ undeclared (first use in this function) wgl.c:1086: error: too many arguments to function ‘wgl_initialize_glx’ make[2]: *** [wgl.o] Error 1 make[2]: Leaving directory `/wine/wine-git/dlls/opengl32' make[1]: *** [opengl32] Error 2 make[1]: Leaving directory `/wine/wine-git/dlls' make: *** [dlls] Error 2 Any idea? Cheers, Paul.

2 1

Setupapi [0/6] : ReactOS setupapi patches
by Hervé Poussineau 03 Sep '06

03 Sep '06

Hello, As setupapi merge from ReactOS has been a recurrent demand [1], I'm doing this set of patches. Note that I'm not especially interested by this merge, but I do it only to please people. I've already spent one day to do them, I don't want to loose more of my time [2]. Note also that I'm not the only one who can provide better patches if those ones don't fullfill requirements. You're welcome (yes, you! the reader of Wine-patches/Wine-devel ML) to improve them if needed. The goal of this set of patches is to set a solid ground to implement lots of missing functions in setupapi. I've tried to cut them in smallest possible parts. Additionnaly, this patchset implements SetupDiEnumDeviceInfo and (mostly) SetupDiGetClassDevsExW Patch 1/6 Move Class related fonctions to their own file devclass.c No code change. Patch 2/6 Forward SetupDiGetClassDevsA/W and SetupDiGetClassDevsExA to SetupDiGetClassDevsExW This patch depends of patch 1 Patch 3/6 Add in-memory structures needed to implement SetupDiGetClassDevsExW in a following patch. Basically, we have one list container (structure DeviceInfoSet) which will contain multiple devices (structure DeviceInfoElement) in a chained list Patch 4/6 Update SetupDiCreateDeviceInfoList and SetupDiCreateDeviceInfoListA/W to initialize all fields of in-memory structure This patch depends of patch 3 Patch 5/6 Check parameters in SetupDiGetClassDevsExW stub, and create device set if needed. Now, only the real work needs to be done. This patch depends of patches 1, 3 and 4 Patch 6/6 Implement SetupDiEnumDeviceInfo This patch depends of patches 3 and 4 Regards, Hervé, ReactOS developper [1] http://marc.theaimsgroup.com/?l=wine-devel&m=115721353431733&w=2 http://marc.theaimsgroup.com/?l=wine-devel&m=113584611128655&w=2 [2] Because I'm not a Wine user, nor have Linux on my computer

1 0

Re: [wintrust] Register WINTRUST_ACTION_GENERIC_VERIFY_V2
by Juan Lang 03 Sep '06

03 Sep '06

Hi Paul, +static LONG WINTRUST_WriteSingleUsageEntry(CHAR* OID, Any reason that can't be LPCSTR OID instead? That will remove some cast-qual warnings I think. + WCHAR UsageKey[MAX_PATH]; (snip) + /* Turn OID into a wide-character string */ + Len = MultiByteToWideChar( CP_ACP, 0, OID, -1, NULL, 0 ); + OIDW = HeapAlloc( GetProcessHeap(), 0, Len * sizeof(WCHAR) ); + MultiByteToWideChar( CP_ACP, 0, OID, -1, OIDW, Len ); + lstrcatW(UsageKey, OIDW); This could overflow UsageKey. It would be better to allocate UsageKey as sizeof(Trust) + sizeof(Usages) + Len * sizeof(WCHAR), then concatenate the strings into it. I'm not sure whether there's a maximum length for a registry key, but it's certainly longer than MAX_PATH if it exists. + if (Res != ERROR_SUCCESS) goto error_close_key; + +error_close_key: + RegCloseKey(Key); This goto is unnecessary, the target of the branch is the next instruction anyway. Thanks, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Could I get some permissions for Bugzilla?
by Matt Finnicum 03 Sep '06

03 Sep '06

Hello, I'm not really sure what levels of permissions Bugzilla has, but could I get the ability to modify bugs? (things like assign them to myself, mark them as fixed, etc). If it's possibile, I suppose only having such access to the "wine-richedit" component would be fine, too. --Matt Finnicum

2 1

How do I automate the registering of a DLL
by Paul Vriens 03 Sep '06

03 Sep '06

Hi, while I'm working on DllRegisterServer for wintrust, I wanted to make it 'autorun' when running on a clean system (through wineprefixcreate). My thought was to add an entry to the RegisterDllsSection part in tools/wine.inf but that doesn't seem to work. (regsvr32 wintrust.dll does work). What am I missing? Cheers, Paul.

1 1

Re: Wine release 0.9.20
by Roland Schama 03 Sep '06

03 Sep '06

Hello Alexandre, Is your group affiliated with "CodeWeavers"? They claim to have a "wine" product called Crossover Mac that will have a final release soon. If you are not the same group, what are the differences? Thanks, Roland Schama On Aug 24, 2006, at 11:05 AM, Alexandre Julliard wrote: > This is release 0.9.20 of Wine, a free implementation of Windows on > Unix. > > What's new in this release: > - XEmbed system tray support. > - Many improvements to NTLM support. > - Many messages made localizable instead of hardcoded to English. > - Improved support for various OpenGL platforms. > - More improvements to the IDL compiler. > - Lots of bug fixes. > > Because of lags created by using mirrors, this message may reach you > before the release is available at the public sites. The sources will > be available from the following locations: > > http://ibiblio.org/pub/linux/system/emulators/wine/ > wine-0.9.20.tar.bz2 > http://prdownloads.sourceforge.net/wine/wine-0.9.20.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/site/download > > You will find documentation on > > http://www.winehq.org/site/documentation > > You can also get the current source directly from the git or CVS > repositories. Check respectively http://www.winehq.org/site/git or > http://www.winehq.org/site/cvs for details. > > Patches should be submitted to "wine-patches(a)winehq.org". Please > don't forget to include a ChangeLog entry. If you submitted a patch, > please check to make sure it has been included in the new release. > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > -- > Alexandre Julliard > julliard(a)winehq.org >

5 4

FC4 issue with 0.9.20
by David Anderson 03 Sep '06

03 Sep '06

It's not anything the list would concern itself with, and I've not had a chance to look at it yet... I'm just sending this as an FYI. Any suggestions would of course be welcome. the Fedora Core 4 install of the (new to FC4 rpms) wine-core-0.9.20-1.fc4 gets [various messages deleted] fixme:ole:OleLoadPictureEx (0x94fbac,167,1,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x33fab8), partially implemented. fixme:ole:OLEPictureImpl_LoadGif Trying to load GIF, but no support for libgif/libungif compiled in. fixme:ole:OLEPictureImpl_get_Attributes Unknown pictype -1 fixme:ole:OleLoadPictureEx (0x94fbac,153,1,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x33fab8), partially implemented. fixme:ole:OLEPictureImpl_LoadGif Trying to load GIF, but no support for libgif/libungif compiled in. fixme:ole:OLEPictureImpl_get_Attributes Unknown pictype -1 fixme:ole:OleLoadPictureEx (0x94fbac,153,1,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x33fab8), partially implemented. fixme:ole:OLEPictureImpl_LoadGif Trying to load GIF, but no support for libgif/libungif compiled in. fixme:ole:OleLoadPictureEx (0x94fbac,128,1,{7bf80980-bf32-101a-8bbb-00aa00300cab},x=0,y=0,f=0,0x33fab8), partially implemented. fixme:ole:OLEPictureImpl_LoadGif Trying to load GIF, but no support for libgif/libungif compiled in. fixme:ole:OLEPictureImpl_SaveAsFile (0x15f4b0)->(0x1783c0, 0, (nil)), hacked stub. err:shdocvw:get_typeinfo LoadRegTypeLib failed: 8002801d fixme:ole:OLEPictureImpl_FindConnectionPoint no connection point for {33ad4ed2-6699-11cf-b70c-00aa0060d393} [and the fixmes like this repeat several times] This on a windows app that worked (barely) before. The other two windows apps I have installed seem to still work. I get a little window with Run-time error '-2147319779 (8002801d)': Automation error Application-defined or object-defined error and the app is dead . I'm supposing this is a problem with the rpm somehow (rather than wine itself), but that is a wild guess. The previous FC4 wine install (also from a normal FC4 binary rpm) did not have this problem. The app was only barely usable, some little buttons showed no text labels, so all was not totally well before either. David Anderson (I'll also try this app building wine with latest wine source on an AMD athlon 64bit with wine built -m32 to see what happens).

2 1

Re: riched20: ME_SetSelection -1 to -1 behavior fix
by Matt Finnicum 02 Sep '06

02 Sep '06

Mark, This patch, like the first one you submitted, is linewrapped (meaning it won't apply cleanly). I'd suggest just attaching the patch to your e-mail, so you don't have to worry about these things. Also, it's always nice to have a conformance test for things like this. Perhaps show that it's the correct behaviour for both EM_EXSETSEL and EM_SETSEL? If you've got any questions on writing one (or just want me to do it for you), just send me an e-mail. Thanks for contributing, --Matt On 9/2/06, Mark Lu <excelblue(a)gmail.com> wrote: > ChangeLog: > * Corrects the behavior of ME_SetSelection when selecting from -1 to -1 > --- > dlls/riched20/caret.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/dlls/riched20/caret.c b/dlls/riched20/caret.c > index bdab179..06f021c 100644 > --- a/dlls/riched20/caret.c > +++ b/dlls/riched20/caret.c > @@ -90,6 +90,14 @@ void ME_SetSelection(ME_TextEditor *edit > ME_ClearTempStyle(editor); > return; > } > + if (from == -1 && to == -1) /*-1,-1 means put the selection at the > end of the text */ > + { > + editor->pCursors[1].pRun = editor->pCursors[0].pRun = > ME_FindItemBack(editor->pBuffer->pLast, diRun); > + editor->pCursors[1].nOffset = editor->pCursors[0].nOffset = 0; > + ME_InvalidateSelection(editor); > + ME_ClearTempStyle(editor); > + return; > + } > if (from == -1) > { > editor->pCursors[1] = editor->pCursors[0]; > -- > 1.4.1.1 > > > >

1 0

Re: usp10: Resend - usp10: Implement and test Script{Apply, Record}DigitSubstitution.
by Mike McCormack 02 Sep '06

02 Sep '06

Albert Lee wrote: > + TRACE("%p, %p, %p\n", sds, sc, ss); > + > + SCRIPT_DIGITSUBSTITUTE psds; > + This causes a warning: gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o usp10.o usp10.c usp10.c: In function ‘ScriptApplyDigitSubstitution’: usp10.c:256: warning: ISO C90 forbids mixed declarations and code Mike

2 1

winebrowser and multi-word commands
by Yuriy 02 Sep '06

02 Sep '06

Hi, I noticed that winebrowser doesn't work with browsers/commands that are more than one word. For example, the command to run konqueror with the webbrowsing profile on kubuntu is: kfmclient openProfile webbrowsing [url] Setting that to be the first attempted webbrowser in the registry: [HKEY_USERS\S-1-5-4\Software\Wine\WineBrowser] "Browsers"="kfmclient openProfile webbrowsing,konqueror,firefox,mozilla,netscape,galeon,opera,dillo" and running: winebrowser http://www.winehq.org yields this: Considering: kfmclient openProfile webbrowsing argv[1]: http://www.winehq.org Considering: firefox argv[1]: http://www.winehq.org then it opens up with firefox. Is this a bug? Would it just be a matter of modifying the winebrowser script to fix? ~Yuriy

1 3

winspool: manage loaded monitors in a list
by Detlef Riekenberg 02 Sep '06

02 Sep '06

This is part 2 on top of: winspool: minimal load/unload printmonitors... - manage loaded monitors in a list - protect the list with a critical Section Changelog: - winspool: manage loaded monitors in a list -- By by ... Detlef

1 0

Re: Clarification
by Juan Lang 01 Sep '06

01 Sep '06

Thanks Tom! I was indeed confused. I was wondering if it were some literary reference I was missing, like Tom Riddle in the Harry Potter books or something. /me stops scratching his head. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Thank you
by Jeremy White 01 Sep '06

01 Sep '06

We just shipped a public beta of CrossOver for the Mac. We're very excited about the Mac opportunities as we hope it will give us a much needed boost and allow us to accelerate our own contributions to Wine. I'm proud of our work on Wine - and I am very privileged to work with the folks at CodeWeavers. However, it's also clear that the Wine community is a growing one, and that a large portion of the work in CrossOver comes from people who contribute here. This past year, in particular, I've noticed a great jump in contributions, notably in the area of games (yay for World of Warcraft support!). By doing so, I think you make the world a better place, and indirectly you help all of us at CodeWeavers to make a living - you literally help to put food on my table (although my wife is getting tired of beans and rice :-/). So, thanks. I personally appreciate it, and think it's Good (TM) that you do. I also believe that countless other folks who use Wine in various forms also appreciate it, although they're polite enough not to write long winded emails expressing that. But for any of you that come to Reading, the least we can do is buy you dinner and a drink or two. And if any contributor ever needs something from CodeWeavers (like a free CrossOver account), just holler. Cheers, Jeremy White CEO CodeWeavers, Inc. p.s. Okay, being brutally honest, the jury is out on whether or not all the work making World of WarCrack^H^Hft is going to be a net gain for us or not. Now even my wife is addicted, and I have to go level up my Paladin to keep the work group happy... :-/

2 1

Clarification
by Tom Booker 01 Sep '06

01 Sep '06

Hi everyone, I feel like I owe some of you some clarification with all of the names I have slung around here in the past as my own.. I started contributing as Dustin Navea, then it switched to Dustin Booker, then to Tom Spear (aka Dustin Booker Dustin Navea), and finally to Tom Booker. It's about to change for the last time, to Tom Spear. My legal name was Dustin Thomas Booker until recently, Navea came from my stepfather, Spear was my mother's maiden name. Long story short, I prefer Tom to Dustin, so I flip flopped my first and middle name, and to honor my mother's father, and carry his family name on (he didn't have any sons), I decided to take his last name, so my legal name is Thomas Dustin Spear now, and it will (hopefully ;-) ) stay that way. Sorry for any confusion I may have caused in the past, including any this email may have caused. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://www.imvu.com/catalog/web_registration.php?userId=1547373

1 0

Adding L"" defines to include files ?
by Paul Vriens 01 Sep '06

01 Sep '06

Hi, I'm currently dealing with the DllRegister part of wintrust. One of it's include files (softpub.h) on Windows has: #define SP_POLICY_PROVIDER_DLL_NAME L"WINTRUST.DLL" #define SP_INIT_FUNCTION L"SoftpubInitialize" #define SP_OBJTRUST_FUNCTION L"SoftpubLoadMessage" #define SP_SIGTRUST_FUNCTION L"SoftpubLoadSignature" #define SP_CHKCERT_FUNCTION L"SoftpubCheckCert" #define SP_FINALPOLICY_FUNCTION L"SoftpubAuthenticode" #define SP_CLEANUPPOLICY_FUNCTION L"SoftpubCleanup" should we do the same? I've seen several occurrences of these in our own include files, so one should think there is no harm. Cheers, Paul.

3 3

F.E.A.R. - free multiplayer
by EA Durbin 01 Sep '06

01 Sep '06

Since there was a discussion about getting F.E.A.R to work with wine on wine-devel the other day I thought I'd mention this link. http://www.fileshack.com/file.x/9272/F.E.A.R.+Combat+1.07 F.E.A.R. released the multiplayer portion of their game for free, you have to register on their site for a free cd key.

1 0

How to use a windows dll in linux
by Mark Smith 31 Aug '06

31 Aug '06

I know this question has been asked many times, but I cannot find enough information to solve the problem. I have a windows dll and header files. I want to make a library that I can link to and use on linux. What are the steps required to do this? I have used winedump to generate a .spec file and winebuild to generate an assembly file. What comes next? Thanks

4 3

"Bus Error" at thread.c:228 on OS X with Xcode 2.4 and -O2
by dackz 31 Aug '06

31 Aug '06

>From what I've heard, there was a bug in the gcc bundled with Xcode 2.3 that caused stack alignment issues when -O2 was used (and maybe -O1?). This is supposed to be fixed in Xcode 2.4, which is what I'm using, yet I'm still getting a "Bus Error" with all default CFLAGS. Adding -O0 into the mix fixes the problem. Here's all I could gleam with gdb: Breakpoint 1, NtAllocateVirtualMemory (process=0x7bc5b6f1, ret=0xbffff949, zero_bits=3221222220, size_ptr=0x10000, type=3221222216, protect=2147352576) at virtual.c:1306 1306 in virtual.c (gdb) bt #0 NtAllocateVirtualMemory (process=0x7bc5b6f1, ret=0xbffff949, zero_bits=3221222220, size_ptr=0x10000, type=3221222216, protect=2147352576) at virtual.c:1306 #1 0x7bc4f428 in thread_init () at thread.c:224 #2 0x7bc2beea in __wine_process_init () at loader.c:2354 #3 0x60a088c1 in wine_init (argc=2, argv=0xbffff8b8, error=0xbffff450 "", error_size=1024) at loader.c:664 #4 0x7bf00f2d in main (argc=2, argv=0xbffff8b8) at main.c:58 [stepping...] (gdb) step NtAllocateVirtualMemory (process=0x2001, ret=0xbffff22c, zero_bits=1048576, size_ptr=0x1000, type=4294967295, protect=10514258) at virtual.c:1379 1379 in virtual.c (gdb) print status $22 = 0 [stepping...] (gdb) step thread_init () at thread.c:226 226 thread.c: No such file or directory. in thread.c (gdb) print addr $23 = (void *) 0x7ffde000 (gdb) print size $24 = 4096 (gdb) step 228 in thread.c (gdb) step Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_PROTECTION_FAILURE at address: 0x7ffde064 thread_init () at thread.c:228 228 in thread.c (gdb) bt #0 thread_init () at thread.c:228 #1 0x7bc2beea in __wine_process_init () at loader.c:2354 #2 0x60a088c1 in wine_init (argc=2, argv=0xbffff8b8, error=0xbffff450 "", error_size=1024) at loader.c:664 #3 0x7bf00f2d in main (argc=2, argv=0xbffff8b8) at main.c:58 (gdb) thread.c:228 being "peb->NumberOfProcessors = 1;", and peb being 0x7ffde000. Here's some environment information: OS: Mac OS X 10.4.7 Xcode: Xcode 2.4 X11: XFree86 Version 4.4.0 / X Window System (protocol Version 11, revision 0, vendor release 6600) gcc -v: Using built-in specs. Target: i686-apple-darwin8 Configured with: /private/var/tmp/gcc/gcc-5363.obj~28/src/configure --disable-checking -enable-werror --prefix=/usr --mandir=/share/man --enable-languages=c,objc,c++,obj-c++ --program-transform-name=/^[cg][^.-]*$/s/$/-4.0/ --with-gxx-include-dir=/include/c++/4.0.0 --with-slibdir=/usr/lib --build=powerpc-apple-darwin8 --with-arch=nocona --with-tune=generic --program-prefix= --host=i686-apple-darwin8 --target=i686-apple-darwin8 Thread model: posix gcc version 4.0.1 (Apple Computer, Inc. build 5363) uname -a: Darwin my-computer 8.7.1 Darwin Kernel Version 8.7.1: Wed Jun 7 16:19:56 PDT 2006; root:xnu-792.9.72.obj~2/RELEASE_I386 i386 i386 I've built Wine with the following DarwinPorts portfile: # $Id: $ PortSystem 1.0 name wine version 0.9.20 description Windows compatibility layer long_description Microsoft Windows compatibility layer for Unix-like systems categories emulators maintainers dackze+darwinports(a)gmail.com platforms darwin freebsd homepage http://www.winehq.org/ master_sites sourceforge:wine use_bzip2 yes depends_lib bin:bison:bison bin:fontforge:fontforge bin:gmake:gmake \ bin:m4:m4 bin:pkg-config:pkgconfig \ lib:libfontconfig:fontconfig lib:libfreetype:freetype \ lib:libintl:gettext lib:libjpeg:jpeg lib:libncurses:ncurses \ lib:libX11:XFree86 lib:liblcms:lcms lib:libglut:glut \ lib:libgphoto2:libgphoto2 lib:libsane:sane-backends \ lib:libssl:openssl lib:libungif:libungif \ lib:libxml2:libxml2 lib:libxslt:libxslt build.type gnu checksums ${distname}${extract.suffix} md5 3e80a07819e4df084becdbbcd4d6cdd3 \ sha1 71b918dcdc54bc32e0b37a63f66891bb7c96b938 \ rmd160 80f1a055674b56ec7cb9231d08b837d1a1a4e883 platform darwin powerpc { ui_msg "Wine is not supported on PowerPC" exit 1 } Which installs the following: fontforge @20060125_0 (active) freetype @2.1.10_1 (active) gettext @0.14.6_0 (active) glut @3.7_0 (active) gmake @3.81_0 (active) jpeg @6b_1 (active) lcms @1.15_0 (active) libgphoto2 @2.1.5_0 (active) libiconv @1.10_1+darwin_8 (active) libpng @1.2.10_2+darwin_8 (active) libungif @4.1.4_0 (active) libuninameslist @20050712_0 (active) libusb @0.1.12_0 (active) pkgconfig @0.21_0 (active) sane-backends @1.0.17_0+local-backends (active) tiff @3.8.2_0+darwin_8 (active) wine @0.9.20_0 (active) zlib @1.2.3_0 (active)

1 0

Re: [TRY 3] Add support for tooltips for system tray icons
by Mike McCormack 31 Aug '06

31 Aug '06

James Liggett wrote: > + if (!list_head(&tray.icons)) > + { > + INITCOMMONCONTROLSEX init_tooltip; > + > + init_tooltip.dwSize = sizeof(INITCOMMONCONTROLSEX); > + init_tooltip.dwICC = ICC_TAB_CLASSES; > + > + InitCommonControlsEx(&init_tooltip); Shouldn't you only initialize comctl32 once, rather than every time there's no icons and we add one? Mike

3 3

Re: ole32: Do a QueryInterface for IOleLink in OleLoad, like native does.
by Huw Davies 31 Aug '06

31 Aug '06

On Thu, Aug 31, 2006 at 05:18:36PM +0100, Robert Shearman wrote: > --- > dlls/ole32/ole2.c | 25 +++++++++++++++++++------ > 1 files changed, 19 insertions(+), 6 deletions(-) > diff --git a/dlls/ole32/ole2.c b/dlls/ole32/ole2.c > index 8f0629c..c6df7ed 100644 > --- a/dlls/ole32/ole2.c > +++ b/dlls/ole32/ole2.c > @@ -1007,12 +1007,13 @@ HRESULT WINAPI OleLoad( > + if (SUCCEEDED(hres)) > + /* > + * Initialize the object with it's IPersistStorage interface. > + */ > + hres = IOleObject_QueryInterface(pUnk, > + &IID_IPersistStorage, > + (void**)&persistStorage); s/it's/its/ ;-) Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: LOSTWAGES: News : 9.20 release
by Robert Shearman 31 Aug '06

31 Aug '06

Tom Wickline wrote: > Hello, > > News Wine 9.20 released > > Tom > >------------------------------------------------------------------------ > >0a1,28 > > Please use "diff -u" for website patches. -- Rob Shearman

1 0

Can you provide me a help.
by karthikeyan Sivasubramanian 31 Aug '06

31 Aug '06

Hi, Please help me while I compiling the sample notepad sources through WINE. Here I send the following error lines shows by the Linux machine. [root@mbu-test notepad]# winemaker --lower-uppercase . Winemaker 0.6.0 Copyright 2000 Francois Gouget <fgouget(a)codeweavers.com> for CodeWeavers warning: in ".", renaming "makefile" to "makefile.win" Scanning the source directories... Fixing the source files... dialog.c main.c Bg.rc Cs.rc Da.rc De.rc En.rc Eo.rc Es.rc Fi.rc Fr.rc Hu.rc It.rc Ja.rc Ko.rc Nl.rc No.rc Pl.rc Pt.rc Ru.rc Si.rc Sk.rc Sw.rc Th.rc Tr.rc Wa.rc Zh.rc rsrc.rc dialog.h main.h notepad_res.h Generating project files... . [root@mbu-test notepad]# make winegcc -c -mno-cygwin -I. -o dialog.o dialog.c winegcc -c -mno-cygwin -I. -o main.o main.c wrc -I. -foBg.res Bg.rc wrc: error while loading shared libraries: libwine.so.1: cannot open shared object file: No such file or directory make: *** [Bg.res] Error 127 Regards, S.Karthikeyan ______________________________________________________________ DISCLAIMER: This electronic message, and any attachments to this electronic message are intended for the exclusive use of the addressee(s)named herein and may contain legally privileged and confidential information. It is the property of Celstream Technologies Pvt. Ltd. If you are not the intended recipient, you are hereby strictly notified not to copy, forward, distribute or use this message or any attachments thereto. If you have received this message in error, please delete it and all copies thereof from your system and notify the sender at Celstream Technologies or administrator(a)celstream.com immediately _______________________________________________________________

2 1

ddraw depthfill
by EA Durbin 31 Aug '06

31 Aug '06

What's the status of re-implementing depthfill per bug 4306? http://bugs.winehq.org/show_bug.cgi?id=4306

2 1

Re: WineD3D: Avoid wasting a shader constant
by Stefan Dösinger 30 Aug '06

30 Aug '06

Am Dienstag 29 August 2006 22:16 schrieb Stefan Dösinger: > My previous half pixel correction patch loaded an extra row from the > transform matrix into a new constant to access one float value, altough the > already loaded 2nd row had 2 unused floats. This patch puts the x offset > into the z value of the 2nd row and loads only that row. This doesn't look > nice, but it doesn't require an additional shader parameter, so the > constant is available for use by the game. Of course comments are added to > document this :-) Please do not apply this patch, I will send another patch which uses a real uniform instead of abusing the projection matrix

1 0

question about selecting of locale and font
by Sergei Butakov 30 Aug '06

30 Aug '06

Hi My native language is Russian but I prefer English for menu, messages, date ... So my locale defined as # export LANG="POSIX", LC_CTYPE="ru_RU.CP1251", LC_COLLATE="ru_RU.CP1251" (LC_ALL is not setted). With wine-0.9.8 and before this works OK. With wine-0.9.9 appear disadvantages: built-in font become serif (before was sans), smaller in height and ugly (it's look like hinting is bad); widgets (windows, buttons, ...) also become smaller in height about 20%. With wine-0.9.10 (and till now - 0.9.20) appear one more disadvantage: when application use System (built-in) font, then wine select Western type (not Cyrillic). So Russian output is corrupted. All became correct if I run as $ LC_ALL=ru_RU.CP1251 wine some_program but I want menu on English. In that time input work correctly - which Russian key is pressed that corresponding code is getted by Wine. -------------- So, is it ability of using for menu (, pop-up windows, ...) not native language is removed by developers specially and now the only right way to run Wine is "LC_ALL=my_locale wine some_program"? Or there are bugs in Wine? If the first answer is "yes" then it's very regrettably. (BTW if I run $ LC_ALL=ru_RU.CP1251 wine wordpad then in editor place all output is corrupted - no Russian,no English, no numerals, rightly work only "Enter". Is it trouble with richedit? If I run $ wine wordpad then don't work output for Russian letters only.) If the second is "yes" then I can write more detailed. -- Sergei Butakov

1 0

wine's fullscreen code has no effect on metacity
by Vincent Povirk 30 Aug '06

30 Aug '06

Some patches were committed to wine recently to make it use _NET_WM_STATE_FULLSCREEN for fullscreen apps. These patches appear to work in kwin but not metacity (I was using firefox as a test). In metacity, it appears wine recognizes that it needs to make a window fullscreen and send the appropriate message, but nothing happens (panels are still on top of firefox in fullscreen mode). I've mentioned this on wine's bug (http://bugs.winehq.org/show_bug.cgi?id=3312), but I suspect it's probably caused by some quirk in metacity that wine triggers by doing some rather odd things itself. That's why I've CC'd the metacity-devel list (to which I and probably anyone on any wine mailing lists are not subscribed). So, uh, metacity people, under what circumstances would metacity be likely to put a window that had sent the proper _NET_WM_STATE_ADD message for _NET_WM_STATE_FULLSCREEN behind panels? -- Vincent Povirk

6 37

Re: [wintrust] Add framework and initial tests (resend)
by Mike McCormack 30 Aug '06

30 Aug '06

Paul Vriens wrote: > configure | 3 - > configure.ac | 1 > dlls/Makefile.in | 1 > dlls/wintrust/tests/Makefile.in | 13 +++ > dlls/wintrust/tests/register.c | 176 +++++++++++++++++++++++++++++++++++++++ > programs/winetest/Makefile.in | 3 + You only need to send changes for dlls/wintrust/tests. Other files are updated automatically by scripts (eg. autoconf, dlls/make_dlls, programs/make_tests). Mike

1 0

Does WIDL support include <xxx.idl>
by Vijay Kiran Kamuju 30 Aug '06

30 Aug '06

Hi, I am cleaning up msxml*.idl files. It seems that msxml.idl and msxml2.idl are incompatible. msxml.idl includes xmldso.idl and xmldom.idl (eg: include "xmldso.idl") where as msxml2.idl explicitly declares the interface defined by xmldso.idl and xmldom.idl. This is done so that we there would be no clashes beteen msxml2.0 and msxml3.0 implementation. As in msxml2.0 and msxml3.0 there were some GUID changes. Does MIDL put the expansion of the included idl file. ie, in a.idl we have a line include "b.idl" what i want ask is does a.h will contain all the contents of b.h(b.h is output when we run midl on b.idl) when we run midl on a.idl. I want to generalize the msxml implementation. Thanks, VJ

2 4

Re: widl [2/6]: Handle more pointer types in write_type
by Robert Shearman 29 Aug '06

29 Aug '06

Dan Hipschman wrote: >So write_type can handle more than just full pointers. > Hi Dan, I see from a couple of patches back that you intend to move the representation of pointers out of the var_t type. How do you intend to represent "char **" for example? type: FC_RP, ref: { type: FC_RP, ref: { type: FC_CHAR } } or: type: FC_CHAR, ptr_level: 2 It seems to me you're going down the first route (and there's nothing wrong with that as far as I can see). I'm just interested to know which approach you are taking. -- Rob Shearman

2 1

Re: widl [3/6]: Represent typedefs with easier to use structures
by Robert Shearman 29 Aug '06

29 Aug '06

Dan Hipschman wrote: >diff --git a/tools/widl/header.c b/tools/widl/header.c >index 3a4cea9..5de43c0 100644 >--- a/tools/widl/header.c >+++ b/tools/widl/header.c >@@ -203,13 +203,14 @@ void write_type(FILE *h, type_t *t, cons > { > int c; > >+ if (t->is_const) fprintf(h, "const "); >+ > if (n) fprintf(h, "%s", n); >+ else if (t->kind == TKIND_ALIAS) fprintf(h, "%s", t->name); > > I'm not really sure we should be depending on a typelib thing for a fundamental concept such as this. In fact, I think the kind field of the type_t structure could probably be removed and generated as needed in the typelib generation code. >@@ -902,6 +885,7 @@ static type_t *make_int(int sign) > > void init_types(void) > { >+ decl_builtin("void", 0); > decl_builtin("byte", RPC_FC_BYTE); > decl_builtin("wchar_t", RPC_FC_WCHAR); > decl_builtin("int", RPC_FC_LONG); /* win32 */ > > This would seem as though it would make widl incorrectly accept "int func(void a);" as a valid statement. I think you need to try to fix this case. >@@ -1147,6 +1131,7 @@ static type_t *make_type(unsigned char t > t->type = type; > t->ref = ref; > t->attrs = NULL; >+ t->orig = NULL; > t->funcs = NULL; > t->fields = NULL; > t->ifaces = NULL; >@@ -1175,8 +1160,15 @@ static typeref_t *uniq_tref(typeref_t *r > typeref_t *t = ref; > type_t *tp; > if (t->uniq) return t; >- tp = make_type(0, t->ref); >- tp->name = t->name; >+ >+ if (t->name) >+ { >+ tp = duptype(t->ref, 0); >+ tp->name = t->name; >+ } >+ else >+ tp = duptype(t->ref, 1); >+ > t->name = NULL; > t->ref = tp; > t->uniq = 1; >@@ -1311,11 +1303,27 @@ static unsigned char get_pointer_type( t > return RPC_FC_FP; > } > >-static type_t *reg_types(type_t *type, var_t *names, int t) >+static type_t *reg_typedefs(type_t *type, var_t *names, attr_t *attrs) > { > type_t *ptr = type; > int ptrc = 0; > >+ /* We must generate names for tagless enum, struct or union. >+ Typedef-ing a tagless enum, struct or union means we want the typedef >+ to be included in a library whether it has other attributes or not, >+ hence the public attribute. */ >+ if ((type->kind == TKIND_ENUM || type->kind == TKIND_RECORD >+ || type->kind == TKIND_UNION) && ! type->name && ! parse_only) >+ { >+ if (! is_attr(attrs, ATTR_PUBLIC)) >+ { >+ attr_t *new_attrs = make_attr(ATTR_PUBLIC); >+ LINK(new_attrs, attrs); >+ attrs = new_attrs; >+ } > > I'm not sure it is necessary to include this change with the rest of the patch. I'm also not sure what you are trying to accomplish here (as we always add the type to a typelib, no matter whether the type has the public attribute). >+ type->name = gen_name(); >+ } >+ > while (names) { > var_t *next = NEXT_LINK(names); > if (names->name) { >@@ -1323,8 +1331,7 @@ static type_t *reg_types(type_t *type, v > int cptr = names->ptr_level; > if (cptr > ptrc) { > while (cptr > ptrc) { >- int t = get_pointer_type( cur ); >- cur = ptr = make_type(t, cur); >+ cur = ptr = make_type(RPC_FC_RP, cur); > ptrc++; > } > } else { > > Thanks and keep up the good work! -- Rob Shearman

3 2

Re: widl: Remove use of type_t "ref" field for base types
by Robert Shearman 29 Aug '06

29 Aug '06

Dan Hipschman wrote: >diff --git a/tools/widl/widltypes.h b/tools/widl/widltypes.h >index d39def3..cf0f246 100644 >--- a/tools/widl/widltypes.h >+++ b/tools/widl/widltypes.h >@@ -207,6 +207,7 @@ struct _type_t { > func_t *funcs; /* interfaces and modules */ > var_t *fields; /* interfaces, structures and enumerations */ > ifref_t *ifaces; /* coclasses */ >+ type_t *orig; /* dup'd types */ > int ignore, is_const, sign; > int defined, written, user_types_registered; > int typelib_idx; > You add a new field to type_t, yet no code uses it. Will it have some future purpose? -- Rob Shearman

2 1

Re: [wintrust] Add some documentation
by James Hawkins 29 Aug '06

29 Aug '06

On 8/29/06, Paul Vriens <Paul.Vriens(a)xs4all.nl> wrote: > Hi, > > I thought I'd start with some documentation. The tests are already > there so what's missing is the implementation :-). > > > /*********************************************************************** > * WintrustAddActionID (WINTRUST.@) > + * > + * Add a Trust provider. Or actually the functions it performs. > + * Can you rewrite this sentence? It's not grammatically correct, and I don't understand what you're saying. -- James Hawkins

2 2

Keyboard freeze - Max Payne
by Jeremy Newman 29 Aug '06

29 Aug '06

Just going through my list of issues I'd like resolved, and discovered this bug/regression. In Max Payne 1 / Max Payne 2 it seems the game freezes up for a few seconds when you hold down any key in the game. For example using 'W' to move forward, hold it down you take like 1 step and it freezes up. Letting go and waiting a few seconds gets the game back to normal. As you can imagine, this makes it unplayable. Before I go and enter this as a bug, I was wondering if anyone knows about this and/or has a fix.

2 4

Re: X11Drv: import glx context code
by Alexandre Julliard 29 Aug '06

29 Aug '06

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > +@ cdecl WGL_CreateContext(long) X11DRV_WGL_CreateContext > +@ cdecl WGL_DeleteContext(long) X11DRV_WGL_DeleteContext > +@ cdecl WGL_GetCurrentContext() X11DRV_WGL_GetCurrentContext > +@ cdecl WGL_GetCurrentDC() X11DRV_WGL_GetCurrentDC > +@ cdecl WGL_GetCurrentReadDCARB() X11DRV_WGL_GetCurrentReadDCARB > +@ cdecl WGL_glGetIntegerv(long ptr) X11DRV_WGL_glGetIntegerv You should export the functions under their official name, like we do for the GDI functions, so something like: @ cdecl wglCreateContext(long) X11DRV_wglCreateContext etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [TRY 2] Add support for tooltips for system tray icons
by Alexandre Julliard 29 Aug '06

29 Aug '06

James Liggett <jrliggett(a)cox.net> writes: > TRY 2: Integrate suggestions from Oleg Krylov and fix a tooltip rectangle bug. > > ChangeLog: > Add support for tooltips for system tray icons. It would be nicer to only initialize comctl32 once the first icon is added to avoid doing too much work at explorer startup, since the parent process is blocked in the meantime. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: widl [1/6]: Generate names for tagless structs, unions and enums
by Alexandre Julliard 29 Aug '06

29 Aug '06

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > +static char *gen_name(void) > +{ > + static const char format[] = "__WIDL_%s_generated_name_%08lX"; > + static unsigned long n = 0; > + > + size_t size = sizeof format - 7 + strlen(input_base) + 8; > + char *name = xmalloc(size); > + > + sprintf(name, format, input_base, n++); > + return name; > +} You can't simply copy the file name, there's no guarantee it's a valid C identifier. You should use something like make_c_identifier in winebuild. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: Enable per-app override for HKLM\Software\Wine\OpenGL: HKLM\Software\Wine\AppDefaults\app.exe\OpenGL.
by Paul Vriens 29 Aug '06

29 Aug '06

On Mon, 2006-08-28 at 22:26 -0500, Ken Thomases wrote: > + > + /* @@ Wine registry key: HKLM\Software\Wine\OpenGL */ > + if ( RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Wine\\OpenGL", > &hkey) ) hkey = 0; > + > + len = GetModuleFileNameA( 0, buffer, MAX_PATH ); > + if (len && len < MAX_PATH) > + { > + HKEY tmpkey; > + /* @@ Wine registry key: HKLM\Software\Wine\AppDefaults\app.exe > \OpenGL */ > + if (!RegOpenKeyA( HKEY_LOCAL_MACHINE, "Software\\Wine\ > \AppDefaults", &tmpkey )) Hi, I thought this stuff was supposed to be moved to HKCU instead of HKLM? Cheers, Paul.

2 1

Re: X11Drv: import glx context code
by fenix＠club-internet.fr 29 Aug '06

29 Aug '06

----Message d'origine---- >Date: Tue, 29 Aug 2006 01:39:49 +0200 >De: "Roderick Colenbrander" <thunderbird2k(a)gmx.net> >A: wine-patches(a)winehq.org >Sujet: X11Drv: import glx context code > >Hi, > seems you forget to change winex11dvr.spec file no ? :) Good Job anyway Regards, Raphael

2 1

Re: oleaut32 2/3: Updates variant:VarAnd to pass all failures exposed from conformance test
by Dan Kegel 29 Aug '06

29 Aug '06

Did you attach the right patch? Seems like this is the same as #1. On 8/28/06, Benjamin Arai <me(a)benjaminarai.com> wrote: > Hi, > > ChangeLog: > - Removes all todo_wine's in VarAnd conformance test > - Fixes VarAnd to pass all tests in Windows XP SP2 and Wine > > --- > dlls/oleaut32/tests/vartest.c | 78 ---------- > dlls/oleaut32/variant.c | 327 +++++++++++++++++++++++++++++++++-------- > 2 files changed, 269 insertions(+), 136 deletions(-) > > Copyright: Google > License: LGPL > -- > Benjamin Arai > http://www.benjaminarai.com > > > > > > > -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

What purpose does wineinstall still serve?
by Scott Ritchie 28 Aug '06

28 Aug '06

A while back, we talked about deleting Wine install. What exactly does it do these days, and why do we still have it? Thanks, Scott Ritchie

4 5

Re: missing link??
by Andreas Mohr 28 Aug '06

28 Aug '06

Hi, On Sun, Aug 27, 2006 at 05:00:45PM +0200, Sabine Rode wrote: > Hallo, my tough guys, > it seems to be an miising link?? > I am newbie at ubuntu 6.06 instaöllled with the amd64 kernel > whenn i add my /etc/apt/sources.list with the both links > > deb http://wine.budgetdedicated.com/apt dapper main > and > > deb-src http://wine.budgetdedicated.com/apt dapper main > > i gwet both 404 errors. > > what is wrong? > your link or my issue? > > best regards > > sabine > germany 64bit support by Wine has been troublesome at least relatively recently (Wine, being used to run 32bit apps, additionally needs 32bit system libraries installed on the system and needs to be run in a chroot). Due to this possibly WineHQ simply doesn't offer Wine packages for a 64bit system - yet fails to do this properly :-P Please see also http://wiki.winehq.org/WineOn64bit or Google searches to find more info about current 64bit support status. (sorry, I'm not up-to-date any more on all matters of current Wine development due to working on other projects now). What's the exact status of 64bit support, anyone? [CC'd wd] Andreas Mohr

2 1

Yukon and Wine
by Tom Wickline 28 Aug '06

28 Aug '06

Hello, Has anyone here taken a look at Yukon? It's a tool to capture games to a video. Yukon Home: http://www.neopsis.com/projects/yukon/ Example of AoE : http://dbservice.com/ftpdir/tom/Naxxramas-AoE.mp4 -Tom

1 0

Re: advpack:reg.c: Cast-qual warning fix
by Alexandre Julliard 28 Aug '06

28 Aug '06

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > --- a/dlls/advpack/reg.c 2006-06-14 12:55:31.000000000 +0100 > +++ b/dlls/advpack/reg.c 2006-08-28 17:00:18.000000000 +0100 > @@ -255,11 +255,14 @@ > /* FIXME: read AdvOptions val for dwFlags */ > ZeroMemory(&cabinfo, sizeof(CABINFOW)); > cabinfo.pszInf = tmp_ini_path; > - cabinfo.pszSection = (LPWSTR)pszSection; > + cabinfo.pszSection = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(pszSection) + 1) * sizeof(WCHAR)); > + lstrcpyW(cabinfo.pszSection, pszSection); > cabinfo.dwFlags = 0; I don't think we want to duplicate strings just because of the warning. If the string really needs to be writable sure, but if it's just because of MS broken prototypes it's not worth the extra cost. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Patch to riched20 (resubmission)
by Huw Davies 28 Aug '06

28 Aug '06

On Sun, Aug 27, 2006 at 05:35:54PM -0700, Mark Lu wrote: > If the rtf control is a child window AND it doesn't display its own context > menu, > then the WM_CONTEXTMENU message should be passed to the parent window in > the rtf > control's DefWindowProc. Here is what MSDN says on the subject: > > "If a window does not display a shortcut menu it should pass this message > to the DefWindowProc function. If a window is a child window, > DefWindowProc > sends the message to the parent. Otherwise, DefWindowProc displays a > default > shortcut menu if the specified position is in the window's caption." You mention the DefWindowProc behaviour here... > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -2318,7 +2319,11 @@ LRESULT WINAPI RichEditANSIWndProc(HWND > ME_SelectWord(editor); > break; > case WM_CONTEXTMENU: > - ME_ShowContextMenu(editor, (short)LOWORD(lParam), > (short)HIWORD(lParam)); > + if (!ME_ShowContextMenu(editor, (short)LOWORD(lParam), > (short)HIWORD(lParam))) > + { > + if (GetWindowLongW( hWnd, GWL_STYLE ) & WS_CHILD) > + SendMessageW( GetParent(hWnd), msg, wParam, lParam ); > + } > break; > case WM_PAINT: > if (editor->bRedraw) ...yet here you send the message to the parent yourself. Why can't you replace this with a 'goto do_default;' and let DefWindowProc do this for you? Huw.

2 1

Re: shlwapi: Fix writing an empty DataBlock list in SHWriteDataBlockList() (2nd resend)
by Alexandre Julliard 28 Aug '06

28 Aug '06

Thomas Weidenmueller <wine-patches(a)reactsoft.com> writes: > --- dlls/shlwapi/clist.c 23 May 2006 12:48:43 -0000 1.12 > +++ dlls/shlwapi/clist.c 24 May 2006 17:23:15 -0000 > @@ -29,6 +29,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(shell); > > +#include "pshpack1.h" > + > /* DataBlock list element (ordinals 17-22) */ > typedef struct tagSHLWAPI_CLIST That doesn't look right. Why do you need to change the packing? -- Alexandre Julliard julliard(a)winehq.org

1 0

Patch not applied.
by Renu Rajput 28 Aug '06

28 Aug '06

Hi I've tried submitting a patch to wine-patches 3 times(as per feedback from Wine group), but it has not been applied yet. Please tell me what I am doing wrong. Thanks Renu Here's the patch: diff -urN OldDir/dlls/comdlg32/filedlg.c NewDir/dlls/comdlg32/filedlg.c --- OldDir/dlls/comdlg32/filedlg.c 2006-08-10 18:45:12.000000000 +0530 +++ NewDir/dlls/comdlg32/filedlg.c 2006-08-11 16:09:32.000000000 +0530 @@ -2011,7 +2011,10 @@ IPersistFolder2_Release(ppf2); if( ! COMDLG32_PIDL_ILIsEqual(pidlCurrent, fodInfos-> ShellInfos.pidlAbsCurrent)) { - IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidlCurrent, SBSP_ABSOLUTE); + if (SUCCEEDED(IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidlCurrent, SBSP_ABSOLUTE))) + { + SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); + } } else if( nOpenAction == ONOPEN_SEARCH ) {

2 1

Re : [DDRAW] Only detach surfaces when releasing a non-texture surface attached to a complex root.
by Elie Morisse 28 Aug '06

28 Aug '06

Le 27.08.2006 19:23:53, Elie Morisse a écrit : > Refcounting fix, Wine devs tell me if I'm wrong as from now on I get something like this w/ The Nomad Soul : > > fixme:d3d:IWineD3DDeviceImpl_Release (0x1248028) Device released with resources still bound, acceptable but unexpected > fixme:d3d:dumpResources Leftover resource 0x217f988 with type 1,WINED3DRTYPE_SURFACE > fixme:d3d:dumpResources Leftover resource 0x1abca8 with type 1,WINED3DRTYPE_SURFACE > > Other games I tried aren't affected though, so this one may just be buggy.. > Good part is this prevents memory faults in The Nomad Soul at exit and when switching resolution. > > Please use this one instead, it fixes a regression in Moto Racer 2 ( detach surfaces of complex attached surfaces when releasing the root ).

1 0

Re: [DDRAW] Only detach surfaces when releasing a non-texture surface attached to a complex root.
by Stefan Dösinger 28 Aug '06

28 Aug '06

Am Sonntag 27 August 2006 17:23 schrieb Elie Morisse: > Refcounting fix, Wine devs tell me if I'm wrong as from now on I get > something like this w/ The Nomad Soul : > > fixme:d3d:IWineD3DDeviceImpl_Release (0x1248028) Device released with > resources still bound, acceptable but unexpected fixme:d3d:dumpResources > Leftover resource 0x217f988 with type 1,WINED3DRTYPE_SURFACE > fixme:d3d:dumpResources Leftover resource 0x1abca8 with type > 1,WINED3DRTYPE_SURFACE > > Other games I tried aren't affected though, so this one may just be buggy.. > Good part is this prevents memory faults in The Nomad Soul at exit and when > switching resolution. Just asking, does this game hit the This->first_attached != This case? This shouldn't happen, I suspect that the refcounting issue is somewhere else. Also the This->first_complex == This check should always return true in theory. Can you send me a +ddraw,+d3d7 trace of the game, with and without your patch?

2 1

Building Wine with the lsb sdk
by Dan Kegel 28 Aug '06

28 Aug '06

I've been a longtime fan of the idea behind the LSB, i.e. build once, run everywhere. (If you're an anti-fan of the LSB, please kindly skip this message.) So tonight I downloaded the current LSB SDK from http://www.freestandards.org/en/Download and gave it a shot. Here's the script I came up with: #!/bin/sh set -ex PATH=/opt/lsb/bin:$PATH CC=lsbcc CXX=lsbc++ export CC export CXX # Must define RTLD_DEFAULT because of http://bugs.linuxbase.org/show_bug.cgi?id=375 # Must define MAP_FILE because it's not in Unix's SUS3 # Must disable linux/videodev.h as it's not supported by the LSB, # and won't compile with lsbcc LSBCC_SHAREDLIBS=wine export LSBCC_SHAREDLIBS ac_cv_header_linux_videodev_h=no \ ./configure --prefix=/usr/local/wine-lsb make depend LDFLAGS=-ldl make LDFLAGS=-ldl CFLAGS="-g -O2 \"-DRTLD_DEFAULT=((void *)0)\" -DMAP_FILE=0" This worked past a number of problems, but the build breaks with the error /opt/lsb/include/unistd.h:342: error: syntax error before 'Include_winsock_h_before_stdlib_h_or_use_the_MSVCRT_library' while building dlls/comctl32/tests/imagelist.c The fix is not obvious. I'll try giving it another look sometime this week. - Dan

1 1

DIB Engine
by satyr_22901＠yahoo.com 27 Aug '06

27 Aug '06

Hi, I've recently tried to play Heroes of Might and Magic IV under Wine, which has very poor performance and this message it printed out many, many times after the game is started: fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy After doing some digging it appears the problem is the current DIB engine or lack thereof (the DIBEngine page on the Wine wiki and the bugzilla bug it links to are very useful). From what I can tell this has been a known shortcoming in Wine for at least 4.5 - 5 years, with a few partial patches created three or four years ago. Is (or has) there any recent (less than a year old) work being done on creating a more efficient DIB engine for Wine? If not, has anyone looked into using a library like EVAS or Cairo as a foundation for implementing it? Before anyone asks, yes I'm a newbie in terms of hacking on Wine or working with device independent bitmaps under Windows, and yes I am volunteering to help work on an improved DIB engine. :) Thanks, Brian P.S. I've run other games such as Diablo II and Total Annihilation (including more recently being able to use TA: Mutation) under Wine and they work beautifully. Keep up the good work! Jen: Wings? I don't have wings! Kira: Of course not. You're a boy. - from "The Dark Crystal" __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

9 10

Re: [DDRAW] Only detach surfaces when releasing a non-texture surface attached to a complex root.
by Stefan Dösinger 27 Aug '06

27 Aug '06

Am Sonntag 27 August 2006 17:23 schrieb Elie Morisse: > Refcounting fix, Wine devs tell me if I'm wrong as from now on I get > something like this w/ The Nomad Soul : > > fixme:d3d:IWineD3DDeviceImpl_Release (0x1248028) Device released with > resources still bound, acceptable but unexpected fixme:d3d:dumpResources > Leftover resource 0x217f988 with type 1,WINED3DRTYPE_SURFACE > fixme:d3d:dumpResources Leftover resource 0x1abca8 with type > 1,WINED3DRTYPE_SURFACE > > Other games I tried aren't affected though, so this one may just be buggy.. > Good part is this prevents memory faults in The Nomad Soul at exit and when > switching resolution. Not so sure about this yet, the patch seems to contain a lot of indention changes, it is a bit hard to read. Can you check this with the moto racer 2 demo? It is a bit nasty in terms of refcounting

1 0

Test showing GetShortPathNameW problem preventing msi from installing .NET 1.1
by Robert Reif 27 Aug '06

27 Aug '06

This test shows the problem that msi is having installing .Net 1.1. Could someone familiar with this code have a look at it please? diff -p -u -r1.36 path.c --- dlls/kernel/tests/path.c 14 Jun 2006 11:54:23 -0000 1.36 +++ dlls/kernel/tests/path.c 26 Aug 2006 15:53:13 -0000 @@ -929,6 +929,16 @@ static void test_GetTempPath(void) SetEnvironmentVariableA("TMP", save_TMP); } +static void test_GetShortPathNameW(void) +{ + WCHAR nameW[] = { 'c',':','\\','w','i','n','d','o','w','s','\\','M','i','c','r','o','s','o','f','t','.','N','E','T','\\','F','r','a','m','e','w','o','r','k','\\','v','1','.','1','.','4','3','2','2','\\','1','0','3','3','\\','v','b','c','7','u','i','.','d','l','l',0 }; + DWORD size; + + size = GetShortPathNameW( nameW, NULL, 0 ); + + ok(size > 0, "GetShortPathNameW() failed\n"); +} + START_TEST(path) { CHAR origdir[MAX_PATH],curdir[MAX_PATH], curDrive, otherDrive; @@ -939,4 +949,5 @@ START_TEST(path) test_PathNameA(curdir, curDrive, otherDrive); test_CleanupPathA(origdir,curdir); test_GetTempPath(); + test_GetShortPathNameW(); }

3 3

Re: WineD3D: Sample from the correct source when using older pixel shaders
by Ivan Gyurdiev 27 Aug '06

27 Aug '06

Stefan Dösinger wrote: > Pre 2.0 pixel shaders do not contain a tag for the texture type to sample > from. Wine had 2D textures hardcoded, this patch checks the bound texture > type to decide from which texture to sample from. For >= 2.0 shaders the > shader tag is still used. > Why can't this be done in a much cleaner way where the sampler is initialized (2nd pass, baseshader, get_registers_used)? Then you don't have to copy and paste the same thing in many places - there's 10 texture instructions or something like that for pixel shaders alone. Also, maybe the stateblock should be passed as an argument to all functions that use its states. I don't like walking up the tree to find what you need (this->wineD3Ddevice) - it's a hidden dependency on device state, which isn't even all the time - that's why you had to move the point where the shader is compiled [ this needs better documentation ]. Similarly, I think the code would be cleaner if projected sampling vs regular was retrieved from the stateblock, and stored somewhere else, at the point when the sampler is initialized.

3 5

Re: WineD3D: Properly initialize a variable
by H. Verbeet 27 Aug '06

27 Aug '06

On 26/08/06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > In IWineD3DSurfaceImpl_SaveSnapshot tmpTexture might be uninitialized, which > might lead to accidentally binding the 0 texture. How does initialising it with 0 help then?

2 1

Wine CVS crashing in Direct3D code with XF86-DRI error
by Chris Rankin 26 Aug '06

26 Aug '06

Hi, I am trying to run the World of Warcraft 1.11.0 (trial) client using Wine 0.9.20 and XOrg 7.1 with a Radeon 9200 video card. I don't have a guest access code yet, and so I have only reached Warcraft's login screen. However, this screen seems to be working fine... until I press the "Quit" button. When I do that, the client crashes. Here is the default console output: $ /opt/wine/World\ of\ Warcraft/WoW.exe libGL warning: 3D driver claims to not support visual 0x4b libGL warning: 3D driver claims to not support visual 0x4b Mesa: CPU vendor: GenuineIntel Mesa: CPU name: Intel(R) Xeon(TM) CPU 2.66GHz Mesa: MMX cpu detected. Mesa: SSE cpu detected. Mesa: Not testing OS support for SSE, leaving enabled. fixme:advapi:SetSecurityInfo stub fixme:powrprof:DllMain (0x7cad0000, 1, (nil)) not fully implemented fixme:ntdll:NtPowerInformation Unimplemented NtPowerInformation action: 11 fixme:powrprof:DllMain (0x7cad0000, 0, (nil)) not fully implemented fixme:win:EnumDisplayDevicesW ((null),0,0x34eeec,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f458,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f6f8,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f6f8,0x00000000), stub! fixme:d3d:IWineD3DImpl_GetDeviceCaps Caps support for directx9 is nonexistent at the moment! fixme:system:SystemParametersInfoW Unimplemented action: 113 (SPI_SETMOUSESPEED)fixme:d3d:IWineD3DDeviceImpl_GetAvailableTextureMem (0x18ac48) : stub, simulating 253MB for now, returning 253MB left fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MIN not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MAX not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_CreateQuery (0x18ac48) Unhandled query type 9 fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MAX not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_SetRenderState WINED3DRS_POINTSIZE_MIN not supported on this opengl fixme:d3d:IWineD3DDeviceImpl_CreateQuery (0x18ac48) Unhandled query type 8 fixme:win:EnumDisplayDevicesW ((null),0,0x34f168,0x00000000), stub! fixme:system:SystemParametersInfoW Unimplemented action: 112 (SPI_GETMOUSESPEED)fixme:system:SystemParametersInfoW Unimplemented action: 113 (SPI_SETMOUSESPEED)fixme:sync:CreateIoCompletionPort (0xffffffff, (nil), 00000000, 00000000): stub.fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONNECT_TIMEOUT (5000): STUB fixme:wininet:InternetSetOptionW INTERNET_OPTION_SEND/RECEIVE_TIMEOUT not supported on protocol 4 fixme:wininet:InternetSetOptionW Option INTERNET_OPTION_CONTEXT_VALUE; STUB fixme:imm:ImmAssociateContextEx (0x10024, (nil), 16): stub X Error of failed request: BadValue (integer parameter out of range for operation) Major opcode of failed request: 145 (XFree86-DRI) Minor opcode of failed request: 9 () Value in failed request: 0x2c00058 Serial number of failed request: 485 Current serial number in output stream: 485 This crash is more serious than it looks because WoW only updates its configuration file when it exits, and (of course) this crash happens before it can do that. I have some WINEDEBUG=d3d output, but it's 300K compressed with bzip2 and so I cannot post it here. Can anyone suggest any way I might debug this, please? I *think* that the operation is XF86GetDrawableInfo(), but am not sure. And since this crash only happens on exit, could Wine be requesting "drawable info" for a resource that it has deleted? Thanks for any help, Cheers, Chris ___________________________________________________________ Now you can scan emails quickly with a reading pane. Get the new Yahoo! Mail. http://uk.docs.yahoo.com/nowyoucan.html

2 1

Re: Add support for tooltips for system tray icons
by Oleg Krylov 26 Aug '06

26 Aug '06

Hello, On 8/25/06, James Liggett <jrliggett(a)cox.net> wrote: > Add support for tooltips for system tray icons. > > This patch partially based on the original systray implementation by Kai Morich <kai.morich(a)bigfoot.de>. I've been working on the simmilar patch and I want make several comments on the patch > + > + /* create icon tooltip */ > + icon->tooltip = CreateWindowEx(WS_EX_TOPMOST, TOOLTIPS_CLASS, NULL, > + WS_POPUP | TTS_NOPREFIX | TTS_ALWAYSTIP, > + CW_USEDEFAULT, CW_USEDEFAULT, > + CW_USEDEFAULT, CW_USEDEFAULT, > + icon->window, NULL, NULL, NULL); > Why the TTS_NOPREFIX flag is needed? It doesn't seem to be used on windows. Next, we need to set tooltip max width, primarily to enable multiline tooltips, as several applications relay on this. The code can be, just after tooltip creation: SendMessageW (icon->tooltip, TTM_SETMAXTIPWIDTH, 0, 400); On windows width value seem to be dependend on system DPI, but I haven't found the exact formula yet. 400 is value at the default 96 dpi, so it may be a good starting point. Then my idea is to create tool just after tooltip creation, and then in modify icon just change tooltip text if requested. Not sure if it is a better idea, but it fits better into the existing code. Something like this: after tooltip creation creation: TTTOOLINFOW ti; ZeroMemory (&ti, sizeof(TTTOOLINFOW)); ti.cbSize = sizeof(TTTOOLINFOW); ti.uFlags = TTF_SUBCLASS; ti.hwnd = icon->window; ti.hinst = 0; ti.uId = 0; ti.lpszText = NULL; GetClientRect (icon->window, &ti.rect); SendMessageW (icon->tooltip, TTM_ADDTOOLW, 0, (LPARAM)&ti); and in modify icon: if (nid->uFlags & NIF_TIP) { TTTOOLINFOW ti; ZeroMemory (&ti, sizeof(TTTOOLINFOW)); ti.cbSize = sizeof(TTTOOLINFOW); ti.hwnd = icon->window; ti.hinst = 0; ti.uId = 0; ti.lpszText = nid->szTip; SendMessageW (icon->tooltip, TTM_UPDATETIPTEXTW, 0, (LPARAM)&ti); }

2 3

Re: WineD3D: Unbind unused textures
by Stefan Dösinger 26 Aug '06

26 Aug '06

Am Samstag 26 August 2006 21:56 schrieb Stefan Dösinger: > Apparently disabling texturing alone doesn't work, so bind texture 0 to all > unused texture units. This fixes the bad texture / reflections on many > objects in half-life 2, dxlevel 80, and makes the flashlight work more > reliably. The flashlight still doesn't work on bump mapped objects. Do not apply this patch, it doesn't fix the real issue.

1 0

Re: ole32: Add support for main-threaded apartments
by Alexandre Julliard 26 Aug '06

26 Aug '06

Robert Shearman <rob(a)codeweavers.com> writes: > A main-threaded apartment is the first single-threaded apartment in > the process. It was designed to be used for legacy applications that > don't want to think about threading at all, even if they are always > called from the same context, as is the case for regular STAs. That one crashes the tests: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so compobj.c && touch compobj.ok wine: Unhandled page fault on read access to 0x00000017 at address 0x7bc27699 (thread 000e), starting debugger... WineDbg starting on pid 0xd Unhandled exception: page fault on read access to 0x00000017 in 32-bit code (0x7bc27699). fixme:dbghelp:elf_load_debug_info_from_map Alpha-support for Dwarf2 information for ntdll<elf> Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7bc27699 ESP:0033f970 EBP:0033fa28 EFLAGS:00010286( - 00 -RISP1) EAX:ffffffff EBX:7bc76420 ECX:00000000 EDX:0015e284 ESI:0033f9f8 EDI:0015e294 Stack dump: 0x0033f970: 00000040 0033fa5c 0000002e 0033f9cc 0x0033f980: 00000040 0033fa6c 0000002c 000004b8 0x0033f990: 00000002 7b8a9280 7bc53b4b 00000000 0x0033f9a0: 7bc7dca0 0033f9fc 7bc53b4b 6056b6dc 0x0033f9b0: 0033f9cc 0033fa0c 0033fa48 60526ff8 0x0033f9c0: 0033f9cc 03c00001 00000000 00000000 fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000119 Backtrace: =>1 0x7bc27699 RtlpWaitForCriticalSection+0xb9(crit=0x15e284) [/home/julliard/wine/wine/dlls/ntdll/critsection.c:398] in ntdll (0x7bc27699) 2 0x7bc27c37 RtlEnterCriticalSection+0x67(crit=0x15e284) [/home/julliard/wine/wine/dlls/ntdll/critsection.c:508] in ntdll (0x7bc27c37) 3 0x60420ee5 start_apartment_remote_unknown+0x45 [/home/julliard/wine/wine/dlls/ole32/stubmanager.c:749] in ole32 (0x60420ee5) 4 0x6040d6a1 RPC_StartRemoting+0x31(apt=0x15e260) [/home/julliard/wine/wine/dlls/ole32/rpc.c:706] in ole32 (0x6040d6a1) 5 0x603fd2cb StdMarshalImpl_MarshalInterface+0xab(iface=0x15e388, pStm=0x15e360, riid=0x603124f0, pv=0x6031a48c, dwDestContext=0x3, pvDestContext=0x0, mshlflags=0x0) [/home/julliard/wine/wine/dlls/ole32/marshal.c:1081] in ole32 (0x603fd2cb) 6 0x603fef58 CoMarshalInterface+0x528(pStream=0x15e360, riid=0x603124f0, pUnk=0x6031a48c, dwDestContext=0x3, pvDestContext=0x0, mshlFlags=0x0) [/home/julliard/wine/wine/dlls/ole32/marshal.c:1623] in ole32 (0x603fef58) 7 0x602ff177 func_compobj+0xcb7 [/home/julliard/wine/wine/dlls/ole32/tests/compobj.c:411] in ole32_test (0x602ff177) 8 0x603111d0 run_test+0x120(name=0x11039e) [/home/julliard/wine/wine/dlls/ole32/tests/../../../include/wine/test.h:365] in ole32_test (0x603111d0) 9 0x603117d1 main+0x141(argv=0x6031189b) [/home/julliard/wine/wine/dlls/ole32/tests/../../../include/wine/test.h:412] in ole32_test (0x603117d1) 10 0x6031189b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in ole32_test (0x6031189b) 11 0x7b86f84b start_process+0xeb(arg=0x0) [/home/julliard/wine/wine/dlls/kernel/process.c:822] in kernel32 (0x7b86f84b) 12 0x6001f777 wine_switch_to_stack+0x17 in libwine.so.1 (0x6001f777) 0x7bc27699 RtlpWaitForCriticalSection+0xb9 [/home/julliard/wine/wine/dlls/ntdll/critsection.c:398] in ntdll: movl 0x18(%eax),%eax 398 if (crit->DebugInfo) name = (char *)crit->DebugInfo->Spare[0]; -- Alexandre Julliard julliard(a)winehq.org

1 1

WineDBG / dbghelp symbol problem
by Roderick Colenbrander 26 Aug '06

26 Aug '06

Hi Eric, One of my wine development machines is running a 64bit version of Debian. In case of debian all 32bit libraries and programs are installed in a 32bit 'chroot' /emul/ia32-linux. Wine is installed there aswell and further the 32bit libs from the chroot environment are in the library path. Wine itself works fine but when some program crashes winedbg doesn't produce very usefull information. For instance a 'bt' using 'winedbg notepad' should give something like: 0x603984f7 start_process+0xe7 [/usr/src/wine/dlls/kernel/process.c:822] in kernel32: movl %edi,0x0(%esp) 822 ExitProcess( entry( peb ) ); On this system I get something like: Wine-dbg>bt Backtrace: =>1 0x603984f7 (0x603984f7) 2 0x60022657 (0x60022657) Further I notice lots of lines like this: fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\kernel32.dll fixme:dbghelp:SymLoadModule Should have successfully loaded debug information for image c:\windows\system32\ntdll.dll I think that the cause of the problem lies in here as I don't see these lines on a standard 32bit system. Further if I install wine into a standard /usr/local prefix, winedbg works ok aswell. It shows the correct information and the SymLoadModule lines don't fail either.Most likely there's some path issue in dbghelp. I have tried to look at the code but it is a big maze to me. Perhaps you have an idea where the problem can be. Regards, Roderick Colenbrander -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

3 4

Re: Alexandre Julliard : crypt32/tests: Avoid sizeof in traces.
by Dimi Paun 26 Aug '06

26 Aug '06

On Fri, August 25, 2006 2:34 pm, Alexandre Julliard wrote: > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Aug 25 18:37:38 2006 +0200 > > crypt32/tests: Avoid sizeof in traces. This is non-obvious -- why is that? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

4 5

Bugzilla statistics: whole lotta fixing going on!
by Dan Kegel 26 Aug '06

26 Aug '06

3 3

Re: Add support for tooltips for system tray icons
by Frank Richter 26 Aug '06

26 Aug '06

On 25.08.2006 07:44, James Liggett wrote: > + icon->tooltip = CreateWindowEx(WS_EX_TOPMOST, TOOLTIPS_CLASS, NULL, > + WS_POPUP | TTS_NOPREFIX | TTS_ALWAYSTIP, > + CW_USEDEFAULT, CW_USEDEFAULT, > + CW_USEDEFAULT, CW_USEDEFAULT, > + icon->window, NULL, NULL, NULL); Hm, wouldn't it be more economic to try to use one tooltip for all icons? -f.r.

2 3

Wine CVS - r1.88 of dlls/opengl32/wgl.c
by Chris Rankin 25 Aug '06

25 Aug '06

Hi, I have just updated my wine installation from CVS, and my OpenGL game is now crashing: X Error of failed request: GLXBadPixmap Major opcode of failed request: 129 (GLX) Minor opcode of failed request: 17 (X_GLXVendorPrivateWithReply) Serial number of failed request: 441 Current serial number in output stream: 441 Reverting wgl.c to r1.87 fixes the problem. I have a Radeon 9250 card with XOrg 7.1 and DRI enabled, but am not using the proprietary ATI driver. Cheers, Chris ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

2 4

FEAR Combat
by Jeremy Newman 25 Aug '06

25 Aug '06

Tried FEAR Combat on Wine. Looks like it needs a d3dx9_27.dll which we don't provide. Anyone else have any luck with this one? I'm not sure what the status is of all the required dx 9.0c dlls are.

9 15

Write-strings warning: the endgame
by Andrew Talbot 25 Aug '06

25 Aug '06

Currently, there are just eight write-strings violations remaining in the codebase: six in mshtml/nsembed.c (lines 271, 353, 356, 367, 432 and 1237), one in mshtml/nsservice.c (line 454) and one in widl/parser.c (line 848). So I would advocate that the -Wwrite-strings switch could now be turned on. I have just submitted two speculative patches to attempt to fix these remaining warnings, but, if they are wrong, I would be grateful if those of you with mshtml expertise or yacc expertise should kindly step in and finish the respective job properly. Thanks, -- Andy.

3 3

Re: Write-strings warning fix
by Dan Hipschman 25 Aug '06

25 Aug '06

On Fri, Aug 25, 2006 at 11:08:03AM +0100, Andrew Talbot wrote: > What confused me - especially with my ignorance of yacc - is that I couldn't > find a corresponding xmalloc() that assigns the char * variables that the > above free() frees. make_var() gains storage for a var_t type, but the > free() in get_type() releases the storage of a char *. I couldn't quite > follow what was going on, there. Is it because the string is the first > element in the structure, so the pointer to the string also points to the > start of the var_t type? The strings are allocated in the lexer (parser.l): yylval.str = xstrdup(kw); The patch that was actually committed (using xstrdup) is most consistent.

2 1

Re: getwinegit.sh v0.4 released!
by Michael [Plouj] Ploujnikov 25 Aug '06

25 Aug '06

In light of the recent discussion about moving to GIT I would like to let send this email to everyone on wine lists. Since Christian's last update to his getwinegit script I have tried to improve it to be more general and work in my special setup. I sent him this same email but I haven't heard a reply yet. ---------- Forwarded message ---------- From: Michael [Plouj] Ploujnikov <ploujj(a)gmail.com> Date: Jul 26, 2006 10:34 AM Subject: Re: getwinegit.sh v0.4 released! To: Christian Lachner <gladiac.lists(a)gmail.com> I have made some fixes to the script and an example config file: - Removed the check for root user. The script shouldn't require root access, not to compile wine, not even to install it. I think the best way is to just check that the user running the script has write permissions to install, log, and git checkout folders. - changed the CONFIGURE variable to be an array to allow for quoted words passed to ./configure. From my configuration that would be something like this: ./configure --x-libraries=/emul/linux/x86/usr/lib/ LDFLAGS="-L/emul/linux/x86/usr/lib -L/emul/linux/x86/lib" (because I need to compile 32bit wine on a 64bit machine with emulation libraries) - fixed one typo that I noticed - added a definition of MAKE to my config file. Without it DEPEND=$MAKE" depend"; and others don't execute make. The same should also be added to the nocolors.config file: MAKE="make"; Of course, you can ignore the path changes in the config file, unless you want an example of what a non-root user would do. The changes are attached as unified diffs. For some reason google made me reply to you rather than wine-devel and I guess it's up to you to post the changes there anyways ... after a thorough review! Enjoy.

1 0

Re: LOSTWAGES: Replace references to CVS with Git
by Robert Shearman 25 Aug '06

25 Aug '06

Mike McCormack wrote: >Index: templates/en/development.template >=================================================================== >RCS file: /home/wine/lostwages/templates/en/development.template,v >retrieving revision 1.6 >diff -u -p -r1.6 development.template >--- templates/en/development.template 28 Oct 2005 16:05:10 -0000 1.6 >+++ templates/en/development.template 18 Aug 2006 01:02:06 -0000 >@@ -6,7 +6,7 @@ > WineHQ hosts a number of services aiding the Wine development process. > > <ul> >- <li><a href="{$root}/site/cvs">Wine CVS tree</a></li> >+ <li><a href="{$root}/site/git">Wine Git tree</a></li> > <li><a href="{$root}/site/contributing">Contributing to Wine</a></li> > <li><a href="http://bugs.winehq.org/">Bug tracking</a></li> > <li><a href="http://appdb.winehq.org/">Application Database</a></li> > I think we should leave the reference to the CVS tree page (but still add a link to the Git tree). Some people find it easier to work with CVS than Git. -- Rob Shearman

12 22

Re: LOSTWAGES: Fix the UI status page html and links
by Dimi Paun 25 Aug '06

25 Aug '06

On Fri, 2006-08-25 at 19:30 +0900, Mike McCormack wrote: > > Maybe we should move this to the Wiki too? Maybe. But it changes seldom enough, and I think it will be ugly to get all the formatting right in the Wiki format. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: msi: Store properties in a hash table, not the database.
by Dan Kegel 25 Aug '06

25 Aug '06

On 8/24/06, Mike McCormack <mike(a)codeweavers.com> wrote: > Use string insensitive comparisons for property names. > --- > dlls/msi/package.c | 253 package.c: In function 'MSI_CreatePackage': package.c:426: error: 'PROPERTY_HASH_SIZE' undeclared (first use in this function) package.c:427: error: 'struct tagMSIPACKAGE' has no member named 'props' Did you forget to include your change to msipriv.h?

1 0

Finding a regression
by Doug Laidlaw 25 Aug '06

25 Aug '06

I may be on the wrong list. A program I use has shown a backward step in graphics between Wine 0.9.15 and 0.9.16, and I am trying to find the change responsible. I currently have Wine set as at 2006-06-21 16:21:20 CDT, it is identifying as 0.9.16, and the fault is present. The Web site says to get the CVS history from the mailing list archives, but the archive is only up to mid-2005. What is the best way to step backwards? Doug. -- When we want to read of the deeds that are done for love, whither do we turn? To the murder column. - G.B. Shaw.

4 9

Re: msi 5: Add initial implementation of the DirectoryListUp event
by Mike McCormack 25 Aug '06

25 Aug '06

James Hawkins wrote: > +UINT msi_dialog_directorylist_up( msi_dialog *dialog ) > +{ > + msi_control *control; > + BOOL indirect; > + LPWSTR prop, path, ptr; > + > + control = msi_dialog_find_control_by_class( dialog, WC_LISTVIEWW ); > + indirect = control->attributes & msidbControlAttributesIndirect; > + prop = msi_dialog_dup_property( dialog, control->property, indirect ); I don't think we should be looking up controls by their Window class. Either look up "DirectoryList" by it's MSI control type, or have the DirectoryList code subscribe to the event somehow. > +UINT msi_dialog_directorylist_up( msi_dialog *dialog ); Please put declarations for functions in a different file in msipriv.h Mike

1 0

Re: msi 4: Add initial implementation of the DirectoryCombo control
by Mike McCormack 25 Aug '06

25 Aug '06

James Hawkins wrote: > + indirect = msi_dup_property( dialog->package, control->property ); > + prop = indirect; > + } > + > + val = msi_dup_property( dialog->package, prop ); > + lstrcpynW( path, val, MAX_PATH ); > + > + PathStripPathW( path ); > + PathRemoveBackslashW( path ); Calling msi_dup_property allocates new strings, so you need to remember to free those strings too. Since it's allocated, why not use PathStripPathW and PathRemoveBackslashW on the allocated string, rather than trying to copy it first? Mike

1 0

Re: msi: Inform the user with an error message when the MSI file path is invalid
by Alexandre Julliard 24 Aug '06

24 Aug '06

"James Hawkins" <truiken(a)gmail.com> writes: > This fixes bug 4404 and matches native behavior. As an aside, is it a > legal problem if our message matches native exactly? I personally > can't see why it would be a problem (interface vs. implementation, > this is User Interface), but I can always change it if it's a problem. It's better not to use the exact same messages, since it's not required for compatibility. Particularly in this case, since you know that the error is that the file does not exist, there's no reason to tell people to "contact the application vendor"... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: Fix strings with lengths that are exact multiples of 2^16.
by Alexandre Julliard 24 Aug '06

24 Aug '06

Mike McCormack <mike(a)codeweavers.com> writes: > if ( datasize != offset ) > - ERR("string table load failed! (%08x != %08lx)\n", datasize, offset ); > + { > + ERR("string table load failed! (%08x != %08lx), please report\n", datasize, offset ); > + ExitProcess(1); > + } Surely it could fail more nicely than by killing the whole process... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: remove limit on number of handles (take 3)
by Alexandre Julliard 24 Aug '06

24 Aug '06

"Dan Kegel" <dank(a)kegel.com> writes: > @@ -66,18 +67,29 @@ MSIHANDLE alloc_msihandle( MSIOBJECTHDR > > EnterCriticalSection( &MSI_handle_cs ); > > + if (msihandletable == NULL) > + { > + msihandletable_size = 256; > + msihandletable = msi_alloc_zero( > + msihandletable_size*sizeof(msi_handle_info)); > + } > + > /* find a slot */ > - for(i=0; i<MSIMAXHANDLES; i++) > + for(i=0; i<msihandletable_size; i++) > if( !msihandletable[i].obj ) > break; > - if( (i>=MSIMAXHANDLES) || msihandletable[i].obj ) > - goto out; > + if( i==msihandletable_size ) > + { > + msihandletable_size *= 2; > + msihandletable = msi_realloc_zero(msihandletable, > + msihandletable_size*sizeof(msi_handle_info)); > + } You should check for allocation failures and fail gracefully instead of crashing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: replace fchmod() with chmod()
by Alexandre Julliard 24 Aug '06

24 Aug '06

"Steven Edwards" <winehacker(a)gmail.com> writes: > Detlef sent this in a while back and I think it slipped through the que. > > Changelog: > Detlef Riekenberg wine.dev at web.de > - tools/winedump: replace fchmod() with chmod() The right way to make that code portable is to get rid of the shell script. -- Alexandre Julliard julliard(a)winehq.org

1 0

Regression with 'explorer' starting automatically by 'Process Explorer'
by Paul Vriens 24 Aug '06

24 Aug '06

Hi, normally when I start Process Explorer it automatically launches the 'explorer' process. With the latest git 'explorer' crashes. Regression testing showed that this is most likely due to the XEmbed patch: http://source.winehq.org/git/?p=wine.git;a=commit;h=60a97505a63e5102f239d0d… Debug output: 000b:trace:x11drv:X11DRV_CreateBitmap (0x28c) 16x16 24 bpp 000b:trace:x11drv:X11DRV_GetBitmapBits (bmp=0x28c, buffer=0x16c1a4, count=0x300) 0009:trace:x11drv:X11DRV_SetWindowPos hwnd 0x1003a, after (nil), swp 0,0 391x17 flags 00000014 0009:trace:x11drv:SWP_DoWinPosChanging hwnd 0x1003a, after (nil), swp 0,0 391x17 flags 00001814 0009:trace:x11drv:SWP_DoWinPosChanging current (0,0)-(391,17) style 500000c2 new (0,0)-(391,17) 0009:trace:x11drv:X11DRV_set_window_pos win 0x1003a window (0,0)-(391,17) client (0,0)-(391,17) style 500000c2 0009:trace:x11drv:X11DRV_SetWindowPos status flags = 1807 000b:trace:x11drv:X11DRV_CreateBitmap (0x298) 15x15 24 bpp 000b:trace:x11drv:X11DRV_GetBitmapBits (bmp=0x298, buffer=0x16c122, count=0x2b2) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (0,0)-(26,45) style 04c00000 000b:trace:x11drv:systray_dock_window Docking tray icon 0x10052 000b:trace:x11drv:X11DRV_SetWindowPos hwnd 0x10052, after (nil), swp 1025,769 0x0 flags 00000005 000b:trace:x11drv:SWP_DoWinPosChanging hwnd 0x10052, after (nil), swp 1025,769 0x0 flags 00001805 000b:trace:x11drv:SWP_DoWinPosChanging current (0,0)-(26,45) style 04c00000 new (1025,769)-(1051,814) 000b:trace:x11drv:SWP_DoOwnedPopups (0x10052) hInsertAfter = (nil) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (1025,769)-(1051,814) client (1025,769)-(1051,814) style 04c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 1028,791,20x20 after 3 changes=f 000b:trace:x11drv:X11DRV_SetWindowPos status flags = 0801 000b:trace:x11drv:X11DRV_CreateBitmap (0x2a8) 32x32 1 bpp 000b:trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2a8, bits=0x15b760, count=0x80) 000b:trace:x11drv:X11DRV_CreateBitmap (0x2a4) 32x32 24 bpp 000b:trace:x11drv:X11DRV_SetBitmapBits (bmp=0x2a4, bits=0x16c3e0, count=0xc00) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (0,0)-(26,45) style 04c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 3,22,20x20 after 3 changes=3 000b:trace:x11drv:X11DRV_CreateWindow hwnd 0x10052 cs 0,0 26x45 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (3,22)-(23,42) style 04c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 3,22,20x20 after 3 changes=40 000b:trace:x11drv:X11DRV_CreateWindow win 0x10052 window 0,0,26,45 client 3,22,23,42 whole 3,22,23,42 X client 0,0,20,20 xwin 3e00002 000b:trace:x11drv:X11DRV_ShowWindow hwnd=0x10052, cmd=8, wasVisible 0 000b:trace:x11drv:X11DRV_SetWindowPos hwnd 0x10052, after (nil), swp 0,0 0x0 flags 00000053 000b:trace:x11drv:SWP_DoWinPosChanging hwnd 0x10052, after (nil), swp 0,0 0x0 flags 00001853 000b:trace:x11drv:SWP_DoWinPosChanging current (0,0)-(26,45) style 04c00000 new (0,0)-(26,45) 000b:trace:x11drv:SWP_DoOwnedPopups (0x10052) hInsertAfter = (nil) 000b:trace:x11drv:X11DRV_set_window_pos win 0x10052 window (0,0)-(26,45) client (3,22)-(23,42) style 14c00000 000b:trace:x11drv:X11DRV_sync_window_position setting win 3e00002 pos 3,22,20x20 after 3 changes=40 000b:trace:x11drv:X11DRV_set_window_pos mapping win 0x10052 000b:trace:x11drv:systray_dock_window Docking tray icon 0x10052 000b:trace:x11drv:X11DRV_SetWindowPos hwnd 0x10052, after (nil), swp 1025,769 0x0 flags 00000005 000b:err:syslevel:_CheckNotSysLevel Holding lock 0x603ef040 level 2 000b:trace:seh:raise_exception code=80000003 flags=0 addr=0x77a5fc40 000b:trace:seh:raise_exception eax=00000044 ebx=77a83f64 ecx=602daa80 edx=00000044 esi=7ffdc044 edi=00000000 000b:trace:seh:raise_exception ebp=0034e2b8 esp=0034e290 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00000206 000b:trace:seh:call_stack_handlers calling handler at 0x77a05ec8 code=80000003 flags=0 wine: Unhandled exception 0x80000003 at address 0x77a5fc40 (thread 000b), starting debugger... 000b:trace:seh:start_debugger Starting debugger "winedbg --auto 10 64" WineDbg starting on pid 0xa 000b:trace:seh:call_stack_handlers handler at 0x77a05ec8 returned 1 000d:fixme:ntdll:NtDeviceIoControlFile Unsupported ioctl 8335000c (device=8335 access=0 func=3 method=0) 0009:trace:seh:raise_exception code=c000013a flags=0 addr=0x7bfff400 0009:trace:seh:raise_exception eax=00000003 ebx=00000007 ecx=0033e2ec edx=00000008 esi=0033e2ec edi=7ffdc000 0009:trace:seh:raise_exception ebp=0033e300 esp=0033e2b8 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00000293 0009:trace:seh:call_stack_handlers calling handler at 0x441d00 code=c000013a flags=0 [paul@penguin latest]$ _CheckNotSysLevel () at /wine/wine-git/dlls/kernel/syslevel.c:178 0x77a5fc41 _CheckNotSysLevel+0x41 [/wine/wine-git/dlls/kernel/syslevel.c:178] in kernel32: addl $36,%esp 178 } Modules: Module Address Debug info Name (46 modules) ELF 101000-16f000 Deferred libfreetype.so.6 ELF 175000-190000 Deferred ld-linux.so.2 ELF 192000-1b7000 Deferred libm.so.6 ELF 1b9000-1bd000 Deferred libdl.so.2 ELF 1bf000-1d2000 Deferred libz.so.1 ELF 1d4000-1da000 Deferred libxdmcp.so.6 ELF 1dc000-1df000 Deferred libxau.so.6 ELF 222000-232000 Deferred libxext.so.6 ELF 23a000-25b000 Deferred libexpat.so.0 ELF 25d000-266000 Deferred libxrender.so.1 ELF 2c2000-2c4000 Deferred libnvidia-tls.so.1 ELF 2cb000-2e1000 Deferred libnsl.so.1 ELF 4e8000-4ec000 Deferred libcap.so.1 ELF 4ee000-561000 Deferred libdbus-1.so.2 ELF 74e000-752000 Deferred libxrandr.so.2 ELF 7bd000-7c2000 Deferred libxxf86vm.so.1 ELF 7da000-7df000 Deferred libxfixes.so.3 ELF 927000-931000 Deferred libxcursor.so.1 ELF adf000-c12000 Deferred libc.so.6 ELF c9b000-ca5000 Deferred libhal.so.1 ELF ca8000-da5000 Deferred libx11.so.6 ELF da7000-dbb000 Deferred libpthread.so.0 ELF dbd000-dfa000 Deferred libfontconfig.so.1 ELF 41b4000-49cb000 Deferred libglcore.so.1 ELF 49cd000-4a5c000 Deferred libgl.so.1 ELF 78d5000-78ef000 Deferred libice.so.6 ELF 7915000-791e000 Deferred libsm.so.6 ELF 60000000-60111000 Deferred libwine.so.1 ELF 6025c000-602dc000 Deferred ntdll<elf> \-PE 60270000-602dc000 \ ntdll ELF 602dc000-602f3000 Deferred explorer<elf> \-PE 602e0000-602f3000 \ explorer ELF 602f3000-60429000 Deferred user32<elf> \-PE 60310000-60429000 \ user32 ELF 60429000-604b9000 Deferred gdi32<elf> \-PE 60440000-604b9000 \ gdi32 ELF 604b9000-604ff000 Deferred advapi32<elf> \-PE 604c0000-604ff000 \ advapi32 ELF 6055d000-605e0000 Deferred winex11<elf> \-PE 60570000-605e0000 \ winex11 ELF 60fcc000-60fe8000 Deferred imm32<elf> \-PE 60fd0000-60fe8000 \ imm32 ELF 778e0000-778eb000 Deferred libnss_files.so.2 ELF 779da000-77adf000 Stabs kernel32<elf> \-PE 779f0000-77adf000 \ kernel32 ELF 7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 0000000a (D) c:\windows\system32\explorer.exe 0000000c 0 0000000b 0 <== Any idea where to start looking? Cheers, Paul. P.S. I write 'most likely due' as I've seen several cases of different results when bisecting.

2 5

Default background erase code does not respect WM_CLIPSIBLINGS
by Troy Rollo 24 Aug '06

24 Aug '06

The attached program demonstrates a bug in the default background-erase code in send_erase (dlls/user/painting.c). The code includes a top level window with WS_CLIPCHILDREN | WS_CLIPSIBLINGS, and two overlapping child windows - one that draws nothing and has a white background (first child), and the other being a standard drop-down list (second child). When the window is first created the second child is completely visible, having drawn over the first child. Click anywhere in the grey area of the window and the second child disappears. Click again and only half of it reappears (you may see the other half reappear briefly but be overwritten by the first child). The second child is correctly redrawn if you cover the window and expose it again. Under Windows, the same code results in the second window (being at the top of the Z order) appearing intact on the second click. This looks like one of those cases where there are probably a lot of wrong ways to fix it and only one right way, and so needs to be fixed by somebody familiar with the code involved. -- Troy Rollo - wine(a)troy.rollo.name

1 0

Re: msi: Add an initial implementation of the PathEdit control
by Mike McCormack 24 Aug '06

24 Aug '06

James Hawkins wrote: > @@ -65,6 +65,7 @@ struct msi_control_tag > float progress_current; > float progress_max; > WCHAR name[1]; > + DWORD attributes; You shouldn't add members after name[1], as the string in name[] will overwrite them. > + sz = 0x20; > + buf = msi_alloc( sz*sizeof(WCHAR) ); > + while( buf ) > + { > + r = GetWindowTextW( control->hwnd, buf, sz ); > + if( r < (sz-1) ) > + break; > + sz *= 2; > + buf = msi_realloc( buf, sz*sizeof(WCHAR) ); > + } There's already code to get the window text in msi_dialog_edit_handler(), so please factor it out into a new function rather than copying it. (maybe LPWSTR msi_get_window_text(HWND)?) > + LPCWSTR prop; > + prop = (LPWSTR)MSI_RecordGetString( rec, 9 ); You shouldn't need a cast here... Mike

2 1

Re: msi: Add Set/GetLastError to the property tests
by Alexandre Julliard 23 Aug '06

23 Aug '06

"James Hawkins" <truiken(a)gmail.com> writes: > @@ -2087,33 +2087,44 @@ static void test_getproperty(void) > ok( hPackage != 0, " Failed to create package\n"); > > /* set the property */ > + SetLastError(0xdeadbeef); > r = MsiSetProperty(hPackage, "Name", "Value"); > ok( r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); > + ok( GetLastError() == 0xdeadbeef, "Expected 0xdeadbeef, got %ld\n", GetLastError()); In general, testing that last error isn't set on success is not useful, unless you really have an app that depends on it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: comdlg: Send missing CDN_FOLDERCHANGE (resend 2)
by Alexandre Julliard 23 Aug '06

23 Aug '06

"Renu Rajput" <renu.rajput(a)gmail.com> writes: > diff -urN OldDir/dlls/comdlg32/filedlg.c NewDir/dlls/comdlg32/filedlg.c > --- OldDir/dlls/comdlg32/filedlg.c 2006-08-10 18:45:12.000000000 +0530 > +++ NewDir/dlls/comdlg32/filedlg.c 2006-08-11 16:09:32.000000000 +0530 > @@ -2011,7 +2011,10 @@ > IPersistFolder2_Release(ppf2); > if( ! COMDLG32_PIDL_ILIsEqual(pidlCurrent, fodInfos->ShellInfos.pidlAbsCurrent)) > { > - IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, > pidlCurrent, SBSP_ABSOLUTE); > + if (SUCCEEDED(IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, > pidlCurrent, SBSP_ABSOLUTE))) > + { > + SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); > + } > } > else if( nOpenAction == ONOPEN_SEARCH ) There's no point in sending a (corrupted) inline version of the patch plus another one as attachment, all it does is prevent the patch from being applied. Please send only one instance of the patch, in a non-corrupted format. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: remove limit on number of handles
by Michael Stefaniuc 23 Aug '06

23 Aug '06

Dan Kegel wrote: > Changelog: > msi: remove limit on number of handles > > handle.c | 30 +++++++++++++++++++++++------- > msipriv.h | 1 - > 2 files changed, 23 insertions(+), 8 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/dlls/msi/handle.c b/dlls/msi/handle.c > index 1cd82b3..79664f5 100644 > @@ -66,18 +67,29 @@ MSIHANDLE alloc_msihandle( MSIOBJECTHDR > > EnterCriticalSection( &MSI_handle_cs ); > > + if (msihandletable == NULL) > + { > + /* start table off small to avoid hiding resize bugs */ > + msihandletable_size = 1; Isn't this very small start value something to be used only for debugging while one writes the resizing code? For "production" I would use a value that is big enough to handle the common case (handles at least 50% of the real life cases). As the old MSIMAXHANDLES was good enough for a whole lot of programs i would define that as common case to save me work of finding what the common case is. > + msihandletable = msi_alloc_zero(1*sizeof(msi_handle_info)); > + } > + bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 2

Re: msi: increase MSIMAXHANDLES to 2048
by Alexandre Julliard 23 Aug '06

23 Aug '06

"Dan Kegel" <dank(a)kegel.com> writes: > This lets http://bugs.winehq.org/show_bug.cgi?id=4227 > get to the next problem. (1024 handles wasn't enough, I checked. > 2048 might not be enough for a truly huge app, but this should > hold us for a while.) Dynamic allocation would be better, it's really not hard to do in this case. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: developers-hints 2 -- second try
by Alexandre Julliard 23 Aug '06

23 Aug '06

"Tom Wickline" <twickline(a)gmail.com> writes: > Changelog: add newly implemented dlls and update http links I think the DEVELOPERS-HINTS contents should really be moved to the Wiki, it would be a lot easier to keep up to date there. Does anybody feel like doing that? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: resend add missing glyph code to GetGlyphIndices
by Dmitry Timoshkov 23 Aug '06

23 Aug '06

"Jeff L" <lats(a)yless4u.com.au> wrote: > if(dc->gdiFont) > - ret = WineEngGetGlyphIndices(dc->gdiFont, lpstr, count, pgi, flags); > + ret = WineEngGetGlyphIndices(hdc, dc->gdiFont, lpstr, count, pgi, flags); ... > + GetTextMetricsW(hdc, &textm); As an additional optimization, probably it would be better to call WineEngGetTextMetrics instead of GetTextMetricsW to avoid introducing hdc as another parameter of WineEngGetGlyphIndices. -- Dmitry.

2 1

Re: opengl pixel format regression
by Roderick Colenbrander 23 Aug '06

23 Aug '06

> Hello > > > Both of you try to remove the following code from > src/winex11.drv/opengl.c: > > /* Aux buffers */ > > pglXGetFBConfigAttrib(gdi_display, cfgs[fmt_index], > GLX_AUX_BUFFERS, > > &value); if (ppfd->cAuxBuffers && !value) { > > goto choose_exit; > > } > > Is this code in current CVS/GIT? I'm currently using 0.9.19 and could not > find > the code in wine sources (gentoo). I have fixed a bug related to the pixel format which should be in cvs now. So your bug might be fixed in cvs. Could you try it and could you also attach a log of glxinfo? I need that log to fix some other opengl issues and I don't have have data from cards like yours. Thanks, Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

1 0

Re: regedit[1/2]: remove custom filter from open/save dialogs
by Alexandre Julliard 23 Aug '06

23 Aug '06

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > --- framewnd_orig.c 2006-08-10 15:15:12.000000000 +0200 > +++ framewnd.c 2006-08-22 22:10:05.000000000 +0200 Please generate diffs from the top-level directory. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi: resend add missing glyph code to GetGlyphIndices
by Alexandre Julliard 23 Aug '06

23 Aug '06

Jeff L <lats(a)yless4u.com.au> writes: > for(i = 0; i < count; i++) > + { > pgi[i] = get_glyph_index(font, lpstr[i]); > - > + if (pgi[i] == 0) > + { > + if (flags & GGI_MARK_NONEXISTING_GLYPHS) > + pgi[i] = 0x001f; /* Indicate non existance */ > + else > + { > + /* Note that the call to GetTextMetricsW is made in the loop * > + * because it is less likely to have non existant glyphs * > + * and hence we should have few calls to GetTextMetricsW as * > + * a result */ > + GetTextMetricsW(hdc, &textm); > + pgi[i] = textm.tmDefaultChar; It's a good idea to not call GetTextMetrics unless you need it, but there's no reason to call it multiple times. It isn't hard to call it only the first time you need the default char. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user: [2/2] Pass hook handle to the destination thread. Call server to get hook information
by Vitaliy Margolen 23 Aug '06

23 Aug '06

Thursday, August 17, 2006, 8:46:12 AM, Vitaliy Margolen wrote: > ChangeLog: > user: Pass hook handle to the destination thread. Call server to get hook > information for inter-thread hooks. > Currently Wine has a major problem with LL hooks (low level hooks) when > second hook is installed in a separate thread - the second hook callback is > never called. And while attempting to call it Wine almost locks up in never > ending loop. This happening because instead of calling current thread's > hook callback Wine restarts the whole hook chain from the start. > This patch deals with both sides of this problem. > Fixes Bug [5803], [5712] and possibly others. > dlls/user/hook.c | 41 +++++++++++++++++++++++++++++++++++++---- > dlls/user/message.c | 13 +++++++++---- > dlls/user/user_private.h | 7 +++++++ > server/hook.c | 29 +++++++++++++++++++++++++++++ > server/protocol.def | 13 +++++++++++++ > 5 files changed, 95 insertions(+), 8 deletions(-) Why wasn't this patch accepted? Alexandre on IRC said that there are some race conditions here. I don't see how and where. The only possible place that I can think of is passing handle from one thread to the other thread using internal message. But that is covered. If the hook gets removed, we don't remove it in the server: http://source.winehq.org/source/server/hook.c#L291 When new hook is added, it's being placed ahead of all others, so it's not a problem either - we can't call it anyway after hook-chain has been started. Am I missing something here? Vitaliy Margolen

1 0

Re: msiexec: Add handling for msiexec's regserver option
by Vitaliy Margolen 23 Aug '06

23 Aug '06

Tuesday, August 22, 2006, 7:56:00 PM, James Hawkins wrote: > Hi, > More and more installers are expecting the MSI service to exist, or at > least be installable using msiexec /regserver. This patch is the > first step in fixing bug 5540. > + if (!scm) > + { > + fprintf(stderr, "Failed to open the service control manager.\n"); > + return 1; > + } Please use proper WINE_[ERR|WARN|FIXME|TRACE] macros. Vitaliy Margolen

2 1

regression with gothic1/2
by Sebastian Schlingmann 22 Aug '06

22 Aug '06

Hi everybody, I noticed yesterday that the gothic 1/2 demos don't work anymore. Console output is the following: ... err:ntdll:RtlpWaitForCriticalSection section 0x7fe90020 "heap.c: main process heap section" wait timed out in thread 000f, blocked by 0009, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7bc7ef44 "loader.c: loader_section" wait timed out in thread 0009, blocked by 000f, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x7fe90020 "heap.c: main process heap section" wait timed out in thread 000d, blocked by 0009, retrying (60 sec) ... A regression test came up with the following result: $ git bisect bad 13163349521e50e7039e188a22b6a814dcfcfc37 is first bad commit commit 13163349521e50e7039e188a22b6a814dcfcfc37 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 21 11:53:24 2006 +0200 ntdll: Add a few more free list entries to the heap. :040000 040000 dba2d276a01c6d148826a913f4163e0db0ed4689 eb1abe2301ff4698ac939b7e1b1fa225ceca4338 M dlls I can provide traces and additional info if needed. Bye Sebastian

3 4

Re: riched20: add EM_EXSETSEL conformance tests and fixes bug 4462
by Matt Finnicum 22 Aug '06

22 Aug '06

Hi, Is there something wrong with this patch / a reason it's not being accepted? Sorry if this might have been answered this on IRC last night - X died while I was away, so I'd have missed it. Thanks, --Matt Finnicum On 8/19/06, Matt Finnicum <mattfinn(a)gmail.com> wrote: > Hi, > I've cleaned up / re-diffed this patch from Brian Chang. It fixes bug > 4462 by handling several odd ways in which EM_EXSETSEL can be called. > It also make the message return a proper value, not just zero. > > --Matt Finnicum (Please commit as Brian Chang) > > The last version of this patch can be found here: > http://www.winehq.com/pipermail/wine-patches/2006-March/024976.html > > --- > dlls/riched20/editor.c | 25 +++++++++++++++++--- > dlls/riched20/tests/editor.c | 52 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 73 insertions(+), 4 deletions(-) > > >

2 1

Read to 0x7ffe02c0
by Juan Lang 22 Aug '06

22 Aug '06

Hi folks, I'm trying to debug an access (by native userenv.dll in my case, but also by MS Money 2006) to address 0x7ffe02c0. This is my understanding so far: The TEB is at 0x7ffe0000, so, according to winternl.h, offset 0x02c0 within it is in the middle of GDI_TEB_BATCH. That doesn't make any sense to me. Anyone have any idea what's going on? Thanks, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

4 7

Re: Fwd: RFC: OpenGL x11drv rewrite (WoW fix)
by Raphael 22 Aug '06

22 Aug '06

On Monday 14 August 2006 19:57, you wrote: > Hi Raphael, Hi Roderick, sorry for late response i was in holidays (and before that a long moving to my new apartment) > I'm not sure how well you are monitoring the wine-devel lists these days, > so I'm also directing this mail directly to you. I have been trying to fix > various problems in the Wine OpenGL code. See the attached email and the > patch for more info. > > Basicly I changed the opengl code to only advertise the format of wine's > main visual. I think the changes I made are more or less correct to > Alexandre changes like this sounded correct aswell. But as he isn't an > OpenGL expert he wanted to know the opinion of others and especially from > people who know the code well. > > I already asked Lionel but he said that he isn't that familiar with the > current code which you rewrote a while ago. To Lionel the format > advertising change sounded correctly aswell although he hasn't checked the > code. > > Could you comment on the patch? (reply to the wine-devel list) > > Regards, > Roderick Colenbrander > > -------- Original-Message -------- > Datum: Mon, 14 Aug 2006 17:04:52 +0200 > From: "Roderick Colenbrander" <thunderbird2k(a)gmx.net> > To: wine-devel(a)winehq.org > Subject: RFC: OpenGL x11drv rewrite (WoW fix) > > Hi, > <snip> For me your patch seems correct Anyway the problem is you can add regression in cases: - application want a very specific needs that isn't compatible with current selected visual (use of SetPixelFormat before first CreateContext, now you don't care about user wanted PixelFormat) - application wants to create many context with not compatible pixel format (supported on windows) So you may restore many of the original problems but fixed the more problematic problem of BadMatch :) What it'll be interesting to do next is to move all low-level GLW/GLX utilities calls to x11drv to permit better access to x11drv internals (and to permit better portability on non GLX os, and better share with wined3d). This will help a lot for the famous bug of openGL chils windows. And after that, when user use the SetPixelFormat API, find a way to change the default created wine visual (use of SetPixelFormat is only permited once on windows). The problem is that visual is created by default before the application specify it's needs (ie. when the windows is created). We have the same problem for WineD3D, many games create a window and after want to choose a specific frame buffer (and if not compatible with current visual -> problem) I wanted to delay this visual creation (or better dynamically change this on X, if permited) but no chance (same problem for glwShareLists) :( Keep your good job :) Best Regards, Raphael

5 10

Re: [TRY 2] XEmbed System Tray Support
by Alexandre Julliard 22 Aug '06

22 Aug '06

James Liggett <jrliggett(a)cox.net> writes: > + /* fall back to he KDE hints if the WM doesn't support XEMBED'ed > + * systrays */ > + > + /* Put the window back within the screen so it will be mapped */ > + SetWindowPos( data->hwnd, NULL, 0, 0, 0, 0, SWP_NOZORDER | SWP_NOSIZE ); It would be nicer to create the window with normal coordinates, and only move it off-screen when needed, instead of having off-screen be the default behavior. It would also avoid having explorer know about internals of the systray implementation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/9] DDraw: Make IDirectDrawImpl thread safe
by Alexandre Julliard 22 Aug '06

22 Aug '06

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > @@ -245,11 +252,12 @@ void > IDirectDrawImpl_Destroy(IDirectDrawImpl *This) > { > IDirectDrawImpl *prev; > + DDOBJ_LOCK(This); You shouldn't need locking in Destroy, if the refcount is zero no one else can be using the object. > for(prev = ddraw_list; prev; prev = prev->next) > + { > if(prev->next == This) break; > + } > > if(prev) > + { > + DDOBJ_LOCK(prev); > prev->next = This->next; > + DDOBJ_UNLOCK(prev); > + } You can't lock just one object, you have the protect the whole list. -- Alexandre Julliard julliard(a)winehq.org

1 0

opengl pixel format regression
by Stefan Dösinger 22 Aug '06

22 Aug '06

Hi Roderick, Your pixel format patches caused a regression in half-life 1 for me with the fglrx drivers. It refuses to start in opengl mode and reports "ChoosePixelFormat failed", and then comes up in software(ddraw) mode. The d3d mode still works fine. This problem also does not occur with the open source radeon driver. I tested with fglrx 8.28.8 and fglrx 8.27.10. Other games seem to work fine(appart of a few fglrx bugs) What infos do you need to debug this? This is the format table glxinfo reports: visual x bf lv rg d st colorbuffer ax dp st accumbuffer ms cav id dep cl sp sz l ci b ro r g b a bf th cl r g b a ns b eat ---------------------------------------------------------------------- 0x23 24 tc 0 32 0 r y . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x24 24 tc 0 32 0 r . . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x25 24 tc 0 32 0 r y . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x26 24 tc 0 32 0 r . . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x27 24 tc 0 32 0 r y . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x28 24 tc 0 32 0 r . . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x29 24 tc 0 32 0 r y . 8 8 8 8 0 24 0 0 0 0 0 1 0 None 0x2a 24 tc 0 32 0 r . . 8 8 8 8 0 24 0 0 0 0 0 1 0 None 0x2b 24 dc 0 32 0 r y . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x2c 24 dc 0 32 0 r . . 8 8 8 8 0 24 8 16 16 16 16 1 0 Slow 0x2d 24 dc 0 32 0 r y . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x2e 24 dc 0 32 0 r . . 8 8 8 8 0 24 0 16 16 16 16 1 0 Slow 0x2f 24 dc 0 32 0 r y . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x30 24 dc 0 32 0 r . . 8 8 8 8 0 24 8 0 0 0 0 1 0 None 0x31 24 dc 0 32 0 r y . 8 8 8 8 0 24 0 0 0 0 0 1 0 None 0x32 24 dc 0 32 0 r . . 8 8 8 8 0 24 0 0 0 0 0 1 0 None

3 2

wine and other xservers
by Vijay Kiran Kamuju 22 Aug '06

22 Aug '06

Hi, How does wine work/perform with other opensource X servers, like nano Xserver. Thanks, VJ

1 0

Re: Using winehq to store patches that have not yet got into the wine code
by Tony Lambregts 22 Aug '06

22 Aug '06

Nick Law wrote: > Hi Tony / Chris > > Is there someway of storing a patch on the winehq/appdb domain so that > I can put a link on the APPDB page to it, rather than use links to > other places like thehandofagony (which doesn't look like the sort of > place we should be using). I've been using rapid.de (I think it's > called which I can carry on doing, which gives you download stats). > However I thought as we store screenshots it would be nice to store > patches approved by the maintainers (prior to be incorporated into the > code, or the code fixed). > > Regards > Nick Law > There are a number of places that patches can be stored within winehq. The first place that you could store them is in the wiki like http://wiki.winehq.org/InterestingPatches, or if they fix/hack around a bug in the application then you can start a bug report and attach the patch there and link back to it. Finally you can submit a patch to wine-patches(a)winehq.org and link to the archive. http://www.winehq.org/pipermail/wine-patches/ ie: http://www.winehq.org/pipermail/wine-patches/2006-August/029455.html I do not know what the best way is but I tend to favor the wiki.

1 0

Re: crypt32: work around an apparent compiler bug
by Robert Shearman 22 Aug '06

22 Aug '06

Juan Lang wrote: >This seems like voodoo to me too, but the combined condition if statement >would always fail for me, while two distinct if statements succeed. > >ChangeLog: >- add a couple traces to make following execution easier >- expand an if condition to work around an apparent gcc bug > > >- if (HIWORD(function->entry.pszOID && >- !strcasecmp(function->entry.pszOID, pszOID))) > > Looks like HIWORD(function->entry.pszOID is just missing a closing bracket to me. -- Rob Shearman

2 1

Re: wined3d: print real unhandled D3DCMPFUNC value
by Jan Zerebecki 21 Aug '06

21 Aug '06

On Sun, Aug 20, 2006 at 01:37:04PM -0700, Chris Robinson wrote: > --- dlls/wined3d/device.c 10 Aug 2006 09:43:54 -0000 1.275 > +++ dlls/wined3d/device.c 20 Aug 2006 20:31:10 -0000 > @@ -3666,7 +3666,7 @@ > case D3DCMP_GREATEREQUAL: glParm = GL_GEQUAL; break; > case D3DCMP_ALWAYS: glParm = GL_ALWAYS; break; > default: > - FIXME("Unrecognized/Unhandled D3DCMPFUNC value %ld\n", Value); > + FIXME("Unrecognized/Unhandled D3DCMPFUNC value %ld\n", This->stateBlock->renderState[WINED3DRS_ALPHAFUNC]); (I forgot if I verified this, but) I think that when a state is beeing set This->stateBlock->renderState[State] has the previous value and only Value has the one to be set. From a quick glance it seems the code for this renderstate (and maybe more renderstates) wrongly assumes the contrary. Jan

3 2

KDE wineconfig module & audio
by Yuriy 21 Aug '06

21 Aug '06

Hi, I'm creating a KDE guidance module for wine. I'm stuck on something. winecfg tries to open each audio driver to get a list of available drivers. So far, I've just put in the list of all possible drivers, but I want to get a list consistent with winecfg. I don't know how to go about testing which drivers are available. I'm using regedit for settings, so I'm not linking to wine so I can't just use the function(s) provided in wine. Also, I'd like to put in a button to test if sound is working. Is there any software included in wine to play a wav? It needs to be something that would be installed by default when wine is installed, rather than something that's just in the source like the tests in winmm. Thanks for any help ~Yuriy

3 3

configure.ac: Show Messages about additional Packages with "--verbose"
by Detlef Riekenberg 20 Aug '06

20 Aug '06

We should inform the User, when Wine is build without some Features. This Patch add Hints for additional Packages, which Wine can use. + X11-Extensions: Xext (Shm and shape), XRandr, XRender, Xxf86vmode added + libxslt1 added (libxslt1 depends on libxml2) + libhal added (libhal depends on libdbus-1) + libncurses / libcurses added + libsane added + libgphoto2 added + libicu added + liblcms added + libungif added - libdbus-1 not needed: libhal depends on libdbus-1 - libxml2 not needed: libxslt1 depends on libxml2 As requested by Alexandre, the Messages are displayed only, when requested by the User. I use the Option "--verbose" to enable the Messages. ("--verbose" is a standard Option for configure, but was unused) Changelog: - configure.ac: Show Messages about additional Packages with "--verbose" -- By by ... Detlef

1 0

compiling monolithic winetest executable with MSVC
by Saulius Krasuckas 20 Aug '06

20 Aug '06

I've run "tools/api/msvcmaker --no-wine" and got winetest.dsp and wineruntests.dsp project files. If I exclude MSVC-non-compilable separate tests from the last project, some exe file is made. But is does nothing usefull. The first project produces winetest.lib, but its size is only 1272 bytes. I guess something is wrong with msvcmaker. Has anyone tried this? Did I miss something?

1 0

Re: [AppDB] Assorted language fixes for the front page
by Kai Blin 20 Aug '06

20 Aug '06

On Sunday 20 August 2006 12:48, Alexander Nicolaysen Sørnes wrote: > Assorted language fixes for the AppDB front page. Shouldn't the first hunk be "howtos" instead of "howto's", anyway? Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: Allow older game to start up directx
by Stefan Dösinger 20 Aug '06

20 Aug '06

Am Sonntag 20 August 2006 04:42 schrieb Tony Lambregts: > I have a game that uses Direct X[1] and complains that it is not > installed without this device. Credit for this patch goes to / > <mailto:lionel.ulmer@free.fr>/Lionel Ulmer <lionel.ulmer(a)free.fr> > > [1] See bug 2229 for more details. > http://bugs.winehq.org/show_bug.cgi?id=2229 > > Change log: Allow IID_IDirect3DRampDevice as valid Direct X interface. > > Files Changed: dlls/ddraw/direct3d_opengl.c This patch looks outdated, this file does not exist anymore since the ddraw write in 0.9.16. In the new code I couldn't find any check for the device ID(it always succeeds), so this patch shouldn't be needed.

1 0

Re: WineD3D: gpu detection
by Tom Wickline 19 Aug '06

19 Aug '06

On 8/18/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > Hello, > > This patch tackles the problem in a different way. The idea is not to return the exact videocard but a close match (a card supporting more or less the same opengl features or with similar performance). Based on test using the closed source drivers from nvidia and ati and also using the opensource radeon dri drivers, I made a list of what extensions are available on the cards. Further I checked which of the extensions indicate correspond to certain directx versions. > You may already be aware of this "Graphics Card Comparison Guide" but in case you don't here is the links, it may help in the match making process....... ATI : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=0 NVIDIA : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=1 XGI : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=2 S3 : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=3 SiS : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=4 Matrox : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=5 PowerVR : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=6 3dfx : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=7 Trident : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=8 Intel : http://www.rojakpot.com/showarticle.aspx?artno=88&pgno=9 Tom

4 3

Re: WineD3D: gpu detection
by Frank Richter 19 Aug '06

19 Aug '06

On 19.08.2006 00:09, Roderick Colenbrander wrote: > + } else if(WINE_D3D8_CAPABLE(gl_info)) { > + if (strstr(gl_info->gl_renderer, "GeForce4 Ti") || strstr(gl_info->gl_renderer, "Quadro4")) > + gl_info->gl_card = CARD_NVIDIA_GEFORCE4_TI4200; /* Geforce4 Ti4200/Ti4400/Ti4600/Ti4800, Quadro4 */ > + else if (strstr(gl_info->gl_renderer, "GeForce4 MX")) > + gl_info->gl_card = CARD_NVIDIA_GEFORCE4_MX; /* MX420/MX440/MX460/MX4000 */ Small note: GeForce4 MX is not a DX8 capable card. It's a souped-up GeForce2 MX and labelled "4" for marketing reasons. So perhaps move that check into the DX7 branch. -f.r.

1 0

Re: WineD3D: gpu detection
by Jesse Allen 18 Aug '06

18 Aug '06

On 8/18/06, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > In case of Direct3D each device exports the pci device/vendor ids of the videocard. Lots of programs use these ids to get an idea about the capabilities of the card, enable/disable features based on the detected card or sometimes they are used for evil purposes aswell (working around bugs). .... > > Compared to the first method which I described which solely relied on the parsing of renderer strings this method is better because it takes into account the opengl capabilities of the videocard. So when a new card is out which isn't in our list, we won't fallback to a very basic card but can still return a 'close match' because of the opengl extension checks. > This patch is a nice idea. Some games query pci ids and do stupid things with it if it gets one it doesn't recognize. Using fake ids of a common card will help some. This potentially means that Wine will have better compatability with older games on newer hardware. For me this fixes a problem with battlefront under wine where battlefront sees CARD_WINE and turns everything to low and disables use of programmable shaders completely. It was very annoying because there was no way to force shaders back on in the game. I wrote a hack to fix it, but now I'm glad there is a patch that does this lots better! Thanks Roderick, Jesse

1 0

re-reading from registry
by Christoph Probst 18 Aug '06

18 Aug '06

Hi, I'm still working on the clamav integration in wine. One question that came up recently is how to handle configuration changes. I'd like to allow to configure the virusscanner 'online' without restarting the wineserver or applications currently running. As the configuration is stored in the registry I could read all affected values every time I need them (that means several RegQueryValueExA() calls for every virusscan). But I found that this costs quite some time and even seems to cause IE5 to crash (does anyone know or want to know the reason?). When I save a local copy of my registry values and only update them every x seconds everything is fine. But is that a recommended way or is there a better solution to get notified if a registry key has been changed? If found RegNotifyChangeKeyValue() but I'm not sure if it is the right approach ... Cheers Chris -- Kontakt-Details: http://www.christoph-probst.com/kontakt/ PGP-FP: B171 7EA4 988C DD90 1601 D21C 5279 2FAF 9978 AF86

1 0

Re: tools[1/2]: wineprefixcreate: create a freedesktop-enabled menu directory
by Vitaliy Margolen 18 Aug '06

18 Aug '06

Thursday, August 17, 2006, 2:08:25 PM, Mikolaj Zalewski wrote: > When creating the wineprefix, create a directory for the menu and a > configuration file that enables this menu in the freedesktop.org menu > structure. As suggested on wine-devel the menu directory is a > subdirectory of ~/.wine, so if the user deletes it, all menu items > created there will be automatically removed. > +<Name>Applications</Name> > + <Menu> > + <Name>Wine</Name> > + <LegacyDir>__HOME__/.wine/menu</LegacyDir> > + </Menu> > +</Menu> Why are you hard-coding this path to being .wine? You correctly used $WINEPREFIX before. Also that means that you should add files that are WINEPREFIX related. Or you will keep overwriting the other ones. Vitaliy Margolen

2 1

riched20: Send EN_LINK notifications. Properly underline / color links.
by renu.rajput＠tcs.com 17 Aug '06

17 Aug '06

The patch at http://www.winehq.org/pipermail/wine-patches/2006-August/029855.html needs to be corrected a bit: In file editor.c, there is a change as follows > case WM_MOUSEMOVE: > if (GetCapture() == hWnd) > ME_MouseMove(editor, (short)LOWORD(lParam), (short)HIWORD(lParam)); > break; > + ME_LinkNotify(editor,msg,wParam,lParam); > Here, the function ME_LinkNotify is called after the break. So it would not get executed. Thanks! =====-----=====-----===== Notice: The information contained in this e-mail message and/or attachments to it may contain confidential or privileged information. If you are not the intended recipient, any dissemination, use, review, distribution, printing or copying of the information contained in this e-mail message and/or attachments to it are strictly prohibited. If you have received this communication in error, please notify us by reply e-mail or telephone and immediately and permanently delete the message and any attachments. Thank you

1 0

Re: X11Drv/OpenGL pixelformat rewrite
by Tomas Carnecky 17 Aug '06

17 Aug '06

Testing with World of Warcraft, the game runs fine, but I see this in the console: err:wgl:wglGetPixelFormatAttribivARB Unable to convert iPixelFormat 0 to a GLX one, expect problems! tom

2 1

[UPDATE 4] RFC: XEmbed System Tray Patch
by James Liggett 17 Aug '06

17 Aug '06

Attached is the fourth update to my XEmbed system tray patches. For this version I made some fairly major changes: 1. Did away with the low-level checks for systrays, and instead had the systray icon windows created off-screen so they aren't mapped, as per Alexandre's suggestion. 2. systray_dock_window will put the icon windows back on the screen if there isn't an XEmbed tray to dock with. 3. Eliminated the WS_EX_TRAYWINDOW style hack, and moved the call to systray_dock_window to X11DRV_CreateWindow. I used the window class name to see if it was a tray window being created or not. 4. Consolidated all patches into one, as the individual patches weren't really individual changes. (Thanks to Mike McCormack for this advice.) As usual, comments/suggestions appreciated. Thanks again, James Liggett

2 1

[Fwd: Wine 0.9.19 upgrade problem]
by Scott Ritchie 17 Aug '06

17 Aug '06

1 0

Last call for hotel and mailing list sign up
by Jeremy White 16 Aug '06

16 Aug '06

Hi Folks, I got a brief repreive from the U of Reading, so I'm sending them the final counts tomorrow morning, so this is your last chance to request a room. Also, I'd like to start a thread on proposed meeting topics, so I'd like to ask everyone that's coming to make sure that they're subscribed to the wineconf mailing list so they can follow along. (And give those that don't want to be on it any longer to unsubscribe). Cheers, Jeremy

1 0

wined3d: direct3d.c variable-names request
by Andrew Talbot 16 Aug '06

16 Aug '06

This request is aimed at the wined3d specialists. Hi, I'm looking to fix a couple of write-strings warnings in direct3d.c: lines 323 and 334, the second parameter to Callback(), but I don't know enough to give suitable names to the intended substitute variables. So I would be glad of suggestions, please. Thanks, -- Andy.

2 4

Re: widl [1/4]: Fix NdrConformantArrayUnmarshall calls in generated code
by Robert Shearman 16 Aug '06

16 Aug '06

Dan Hipschman wrote: >This series of four patches allow gcc to compile the proxy file that widl >generates for oaidl.idl. This first patch fixes the number and types of >arguments widl generates for NdrConformantArrayUnmarshall calls. > >ChangeLog: >* Generate the correct args for NdrConformantArrayUnmarshall in proxy code > > Hi Dan, It might be better to reuse the code in typegen.c rather than maintaining two different pieces of code that essentially do the same job. -- Rob Shearman

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel