- wine-devel - winehq.org

Re: riched20 patch
by James Hawkins 13 Jun '06

13 Jun '06

On 6/12/06, Clinton Stimpson <clinton(a)elemtech.com> wrote: > > Second attempt (seems my last one email with this patch dropped through > the cracks ??): > > Attached is a patch to fix a crash when EM_SETTEXTEX is called with a > NULL lParam. > Return values and behavior has been verified and found equivalent to an > app on Windows. > This will have a much better chance getting accepted if you provide a test case for this behavior. -- James Hawkins

1 0

Wine's Mozilla Control - Very old
by Boaz Harrosh 13 Jun '06

13 Jun '06

For any it might concern! The Mozilla ActiveX Control recommended for download by Wine is based on a pre FireFox 1.0 gecko engine and is missing support for many web standards! I was doing development in Windows and needed an Embedded browser. I wanted to also support Mozilla engine and was Quickly downloading the ActiveX from wine download page. (My installed FireFox does not supply one). My work involved embedding the FCKEditor (http://FCKEditor.sourceforge.net). So I installed and change the source code to use the Mozilla GUID and oops FCKEditor does not work. After some investigation I found that even though the Control's package is from Q4/2005 the engine included is much older and belongs to Mozilla 1.6 or something. Since then the Mozilla package did not include a new Control and Has eventually stopped been released. (Do to FireFox replacing it). The New (Mozilla 1.8) Control can only be found in the new SeaMonkey 1.0.x package, which is what I got. And with this control every thing works grate. (Even better than IE). Now SeaMonkey (http://www.mozilla.org/projects/seamonkey) is a very large package and is not something a user would be Happy to be forced with. I did Package a one time Installation of the new Control, stripping down from SeaMonkey anything I could guess does not belong. But this is a one time Job and I'm not sure is the right solution. Maybe we should contact the Sea-Monkey maintainers and ask them to Also produce an "on the side" extra package for our sake. I have not done that yet ... Any body in contact with Mozilla.org? Free Life Boaz

1 0

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW
by Juan Lang 13 Jun '06

13 Jun '06

Hi Christian, thanks for working on setupapi, it could use some help. Huw already commnented on your patch, I have a couple more: + if (!list) { + goto cleanup; + } The style in this file has opening braces on lines of their own, e.g.: if (hInf == INVALID_HANDLE_VALUE) { return FALSE; } Please stick with that. + if (MachineName != NULL) { You should probably just fail if the machine name isn't NULL, since you don't use it and you don't connect to a remote machine anyway. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Crash in XOpenIM in wine 0.9.15
by Daniel Skorka 13 Jun '06

13 Jun '06

Hello, I want to bring an issue that has appeared on wine-users to your attention. The issue is basically this: Any time a process in wine tries to execute another process, wine will crash following a call to XOpenIM. For details please look here [1]. I'm sure Leigh is willing to provide any additional info required. regards, Daniel [1] http://www.winehq.org/pipermail/wine-users/2006-June/021973.html

2 1

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW
by Huw Davies 13 Jun '06

13 Jun '06

On Tue, Jun 13, 2006 at 03:42:22PM +0200, Christian Gmeiner wrote: > diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c > index f402f00..c24ae1e 100644 > --- a/dlls/setupapi/devinst.c > +++ b/dlls/setupapi/devinst.c > HDEVINFO WINAPI > -SetupDiCreateDeviceInfoListExW(const GUID *ClassGuid, > - HWND hwndParent, > - PCWSTR MachineName, > - PVOID Reserved) > +SetupDiCreateDeviceInfoListExW( > + const GUID *ClassGuid, > + HWND hwndParent, > + PCWSTR MachineName, > + PVOID Reserved) Please avoid these unnecessary whitespace changes, they just make the patch bigger. > diff --git a/dlls/setupapi/setupapi_private.h b/dlls/setupapi/setupapi_private.h > index bce05cb..77e4fb0 100644 > --- a/dlls/setupapi/setupapi_private.h > +++ b/dlls/setupapi/setupapi_private.h > +struct DeviceInfoSet > +{ > + DWORD magic; /* if is equal to SETUP_DEVICE_INFO_SET_MAGIC struct is okay */ > + GUID ClassGuid; > + PWSTR MachineName; > + HWND hwndParent; > +}; > + Is this struct going to be used by functions outside devinst.c? If not then this should be moved into that file. Also please include a test with your patch and, in this case, I think it makes sense to include the appropiate Destroy function too, that way it's easy to check that you haven't introduced a memory leak. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: What is needed to get more sites with a winetest executable
by Paul Vriens 13 Jun '06

13 Jun '06

> Am Montag, 12. Juni 2006 20:22 schrieb Paul Vriens: >> Hi, >> >> in the last months we've experienced several times that there was no winetest.exe available at the usual location >> (http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/) for several days/weeks. The reasons are sometimes known but in any case it's a Single Point Of Failure. >> >> What will it take to have multiple sites generating and hosting the winetest executable? Or do we already have this? >> >> Cheers, >> >> Paul. > Hi, > > not the answer to your question, but some thoughts about the topic. > > As long as the automatic build of Paul Millar works, there is not reason to > have a second winetest binary for nearly the same git/cvs source of the tests. One binary a day is enough. If you check > http://test.winehq.org/data/ > you will see that we miss often tests results for some windows platforms. > > If building the winetest binary fails. Someone needs to look into the reason > anyway. In almost all cases its a missing import in a library the test ist linked against. So first "our mingw environment" needs to be fixed. Just running another automatic build will fail with the same error as the build of > Paul. > > Its not hard for me to do the manual build. I just need some webspace to put > the stuff on. And i need to know what needs to be modified in the source before the build (somehow the build date need to be patched into the source). > Also the question is how the new build is announce to the public (hope that > it si not the case that it appears on astro.gla.ac.uk). > > Bye Stefan > Hi, exactly my point. I know Paul Millar fixes stuff all the time by patches of you I think and Hans Leidekker (and others). But he is only one person, with of course a limited amount of time. Maybe we should have a few sites generating the winebuild and using a different path to publish stuff at test.winehq.org/data/[site]. We don't want to mix the output of different executables in one view (apples and pears). Another thing what we could is just use a well-known-url for the winetest.exe like we did with the Mozilla ActiveX component. This url should of course point to the latest available on all site (don't know if that's feasible). Cheers, Paul.

2 2

Re: msvcrt[1/2]: add initial tests for dlls/msvcrt/data.c
by Alexandre Julliard 13 Jun '06

13 Jun '06

Andrew Ziem <ahziem1(a)mailbolt.com> writes: > +typedef void (*_INITTERMFUN)(void); > +unsigned int (WINAPI *p_initterm)(_INITTERMFUN *,_INITTERMFUN *); Msvcrt functions are not WINAPI. And why don't you simply call the function directly instead of loading it dynamically? -- Alexandre Julliard julliard(a)winehq.org

2 2

Vertex Buffer Objects for WineD3D
by Stefan Dösinger 13 Jun '06

13 Jun '06

Hi, In the last days I've been working on using the OpenGL vertex buffer objects extension for IWineD3DVertexBuffer. The aims of this were: * Store geometry data in the hardware for more efficient rendering * Convert the colors and rhw values on upload and get rid of drawStridedSlow The result is in this diff, and it basically works, although not as good as I've hoped. It gives a nice performance boost to Battlefield 1942, and is an improvement for Half-Life 2, but it is not perfect yet. The main shortcomings are: * Shader support: I'm afraid that the conversion code at this points breaks shaders. I've tested with battlefield 1942. The vertex shaders in this game don't work correctly yet, the hands of soldiers are missing and there are some incorrect planes with odd colors. However, with this patch the hands are drawn as apparently random vertices all over the screen. I think I'll need a little help from the shader people for that. * The vertex conversion is slow, and it turned out that if the app Locks the Buffer every frame then drawStridedSlow is faster Converting + drawStridedSlow. Because of that VBOs and the conversion aren't used for vertex buffers in system memory and vbs with WINED3DUSAGE_DYNAMIC are not loaded into a vbo. * In Direct3D7 there is no way for the app to specify a range of vertices to be locked. Because of that DX7 apps are generally slower if they update the vertices regularily. To avoid that drawback there is no VBO created for DX7 apps if they have vertex data that needs conversion. The geometry in DX7 apps is usually quite simple, so DrawStridedSlow isn't a big performance hit in those apps. Stefan

3 4

What is needed to get more sites with a winetest executable
by Paul Vriens 13 Jun '06

13 Jun '06

Hi, in the last months we've experienced several times that there was no winetest.exe available at the usual location (http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/) for several days/weeks. The reasons are sometimes known but in any case it's a Single Point Of Failure. What will it take to have multiple sites generating and hosting the winetest executable? Or do we already have this? Cheers, Paul.

2 1

wined3d: Another GLSL shader status update
by Jason Green 13 Jun '06

13 Jun '06

Well, I've fixed the speed issues with using GLSL (it's now just as fast as ARB shaders for the ones that actually work correctly) and gotten a few other things to work correctly. However, I'm still having issues with certain pixel/vertex shader combinations. Ohsix caught on that it may have to do with sampler limits on graphics cards and how sampling/textures are handled different in GLSL that with ARB. I'm not sure at the moment and could use some help. http://cmhousing.net/wine/glsl_hack6.diff is the diff against the most recent git tree. There are still some ugly hacks lying around in there. Note that I've separated out most of the GLSL functions into a new file "glsl_shader.c". Once again, to use GLSL instead of ARB shaders, you'll have to apply this patch, have a graphics card that's capable of GLSL, and add the following case senstive registry key: HKCU\Software\Wine\Direct3D\UseGLSL = "enabled" (String value)

6 13

comctl32.dll: Running siap and modules under wine, first steps
by Maximiliano Curia 12 Jun '06

12 Jun '06

Hi, I'm trying to use a program called "siap"[1] under wine. It's the required program to pay taxes that the Argentinian government uses. So, it's quite important for the free software community in Argentina to be able to use it in a free software environment. However, I haven't heard of any real success on it, so far. I've been trying to make it run using winetools[2], and differents versions of wine. The furthest I've gone, has been with version 20050310 and all the "plugins" that winetools provides, installed. Only then, could I install the application, run it, switch between the different modules (although it worked only sometimes), but I can't really use it. There are a couple of important widgets that seem to be incompatible with wine. But as I'm not an expert neither in Windows nor in wine, the one I could really track down is a TreeView widget (from comctl32.dll) (from the main window of the program), that is not fully implemented in wine, and by using a native comctl32.dll (I tried using the win98, winme, win2k libraries) the widget would work but some of the other stuff, like switching to one of the modules wouldn't. I made a screenshot to make this clearer, the wine version[3] and the w2k version[4]. So, what should I do next? Is there some documentation of how to implement a certain Windows widget in wine? Is anybody working in this dll, or has worked on this widget? I'd appreciate any comments. Thanks, [1] http://www.afip.gov.ar/programas/siap_main.asp (spanish only) [2] http://www.von-thadden.de/Joachim/WineTools/ [3] http://gnuservers.com.ar/~maxy/wine/siap-wine.png [4] http://gnuservers.com.ar/~maxy/wine/siap-w2k.png -- Saludos, /\/\ /\ >< `/

4 8

Re: Gnome and KDE wine configuration tools
by Yuriy 12 Jun '06

12 Jun '06

> > > Guidance : > --------------- > Its not completely wine configuration utility, but a general > purpose system configuration utility for KDE. It now has got some > module for configuring WINE also. I got this news from > http://dot.kde.org/1150047999/. I havent tested it, but it can be got > from here http://www.simonzone.com/software/guidance/ > > Conclusion, its for you all to decide which is the best tool. And not > to forget give some valuable inputs to the developers to improve. > > Thanks, > Vijay > Hi, I'm the one making that. There's nothing much to test yet (need to get busier!), and it's not on the site, it's in SVN. Input is good of course. ~Yuriy

1 0

Re: Alexandre Julliard : riched20: Fix an uninitialized variable bug.
by Marcus Meissner 12 Jun '06

12 Jun '06

On Mon, Jun 12, 2006 at 10:02:35AM -0500, Alexandre Julliard wrote: > Module: wine > Branch: refs/heads/master > Commit: fe4c4780eb0a047f09a2e536eeaa1f51434b4b61 > URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=fe4c4780eb0a047f09a2e53… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Mon Jun 12 16:09:50 2006 +0200 > > riched20: Fix an uninitialized variable bug. > > Mark todo a test that depended on the bug to succeed. And I wondered if only I was seeing this bug ;) Ciao, Marcus

1 0

re: WM_GETICON patch
by Dan Kegel 12 Jun '06

12 Jun '06

Mike Hearn wrote: > ... obviously WM_GETICON > requires inter-process bitmaps to be supported in some fashion, which is a > fair bit of work. Maybe for efficiency reasons even requiring the dreaded > remote thread creation/service thread :) Adding support for remote thread creation is on Tommy Kho's to-do list. (Probably just for linux and nptl initially.) - Dan

1 0

WM_GETICON patch
by Chris 12 Jun '06

12 Jun '06

Here's a patch I'm trying to make to implement the WM_GETICON message, which programs like GeoShell (a Win32 taskbar replacement) would use to get a taskbar icon for the running processes. I'm not quite sure if it's proper or not, though. Originally GeoShell would show no icon on the taskbar and print a lot of fixme messages about it being unsupported. With this patch it now (always) shows the Wine glass icon for programs, with no such fixme messages. Since I'm unable to try it on a real Windows machine, I don't know if it's the right behavior for it to always show the generic icon like that. Feedback and help would be appreciated.

2 5

Gnome and KDE wine configuration tools
by Vijay Kiran Kamuju 12 Jun '06

12 Jun '06

Hi, I was just looking at browsing net for some linux stuff. I just happend to see some news related to wine Wine-doors : ------------------ Its just a wine installation utility for GNOME with preliminary(very basic and primitive) wine configuration.It has support for multiple installations, from screenshots i think so. I got this news from here http://gnomedesktop.org/node/2689, and more information can be got from its web site http://www.wine-doors.org/ Guidance : --------------- Its not completely wine configuration utility, but a general purpose system configuration utility for KDE. It now has got some module for configuring WINE also. I got this news from http://dot.kde.org/1150047999/. I havent tested it, but it can be got from here http://www.simonzone.com/software/guidance/ Conclusion, its for you all to decide which is the best tool. And not to forget give some valuable inputs to the developers to improve. Thanks, Vijay

2 1

x11drv: set window manager icon hints correctly
by Juris Smotrovs 12 Jun '06

12 Jun '06

Currently, for many applications the generic Wine icon or a class default icon is used in window manager caption or taskbar instead of the application icon set with WM_SETICON. See, for instance, Bug 3370. What actually happens is this: the application icon is correctly set when processing WM_SETICON, but a bit later, when window is mapped, X11DRV_set_wm_hints resets it back to class default (or to none, leading to Wine icon). It seems that X11DRV_set_wm_hints has been designed to be called only when creating a window: it alocates WM hints -- XAllocWMHints() -- instead of checking for existing ones with XGetWMHints(...), and sets class default icon, instead of checking whether another icon has been set in the meantime. However, calls to X11DRV_set_wm_hints have been added at mapping a window and changing window style (see x11drv/winpos.c). Thus, Wine currently allocates WM hints anew and resets icon at every mapping and style change of a window. I attach a patch to X11DRV_set_wm_hints correcting this issue: 1) it checks for existing WM hints before allocating new ones, 2) it resets icon to class default only if no icon hint has been set earlier. Please, let me know if you see anything wrong with this patch. Cheers, Juris

1 0

Re: winmm: Add support for "open new" commands.
by Eric Pouech 12 Jun '06

12 Jun '06

Peter Åstrand wrote: > > ChangeLog: > winmm: Add support for "open new" commands. looks globally good, except that you don't enforce that you got a correct device name ie I'm not sure that 'open new type waveaudio' works (without the alias) A+

3 3

Re: WineD3D: Fog fixes, try 2
by Stefan Dösinger 12 Jun '06

12 Jun '06

Hi, Apply this patch instead, the old patch had some sloppiness error(setting FOGSTART as FOGEND when restoring z-based fog). The problem is corrected in this patch. It also doesn't add a senseless space at the begin of the file and sets the fog to GL_FASTEST for vertex fog and GL_NICEST for table / pixel fog. ChangeLog: Stefan Dösinger(for CodeWeavers): Correct vertex fog for transformed vertices and correctly handle non-vertex, non-table fog

3 3

uxtheme efforts (wanted/needed ?)
by Paul Vriens 12 Jun '06

12 Jun '06

Hi, I've sent 2 emails that are (for now) silently ignored: http://www.winehq.org/pipermail/wine-patches/2006-June/027253.html http://www.winehq.org/pipermail/wine-patches/2006-June/027350.html They both have to do with uxtheme and were meant as a starter for conformance tests and of course the fixes to it. I first wanted to start with input/return paramater and value testing before I touch any functional part (maybe not mutually exclusive). Was there anything wrong with the patches? How can I improve or what do I have to change? Cheers, Paul

2 1

Re: Broken FC5 packages - stay clear.
by Hans Leidekker 12 Jun '06

12 Jun '06

On Monday 12 June 2006 12:04, Andreas Bierfert wrote: > > Good, but shouldn't zlib-devel be pulled in like that too then? > > Oh... don't even mention discussions on what should be in the minimal build > root and what shouldn't ;) I'm not, this isn't about the minimal build system. zlib-devel should be pulled in through whatever package depends on it. > It is :) gphoto2 is pulled in by sane? I believe... anyway last time I > checked (0.9.14) it was pulled in :) Right, but gphoto2 is a direct Wine dependency, so it would be better IMO to support it as such. It's also more flexible, i.e this way a user could choose to install gphoto2 but not sane support. -Hans

1 0

Re: Broken FC5 packages - stay clear.
by Hans Leidekker 12 Jun '06

12 Jun '06

On Monday 12 June 2006 11:37, Andreas Bierfert wrote: > Why is there no BuildRequires for freetype? gphoto2? We also have > >These two are pulled in by other dependencies and thus don't need an explicit >listing (e.g. freetype by fontconfig-devel). Good, but shouldn't zlib-devel be pulled in like that too then? > zlib-devel on the other hand is not in the minimal buildroot :) Like Marcus said, freetype-devel is probably missing a dependency on zlib-devel. Wine doesn't directly depend on zlib-devel AFAICT. And it would be nice if you could add gphoto2 support. -Hans

1 0

Re: iphlpapi: forward Icmp* functions to icmp.dll
by Steven Edwards 12 Jun '06

12 Jun '06

On 6/11/06, Simon Kissane <skissane(a)gmail.com> wrote: > In WinXP, these functions are implemented in iphlpapi.dll as well as > icmp.dll (Win2000). > They are already in Wine's icmp.dll, so forward the iphlpapi to icmp.dll Being its a small amount of code in icmp.dll I think we should just duplicate it. Our dependancies should really match windows and the last time I looked iphlpapi did not depend on icmp.dll in win2k. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 2

Re: DDraw: New ddraw lib
by Jesse Allen 11 Jun '06

11 Jun '06

On 6/9/06, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > This is a resend of my ddraw rewrite, with some modifications Alexandre asked > for. I removed the whitespace fixes from the files which are taken from the > old ddraw code(light.c, material.c, clipper.c, viewport.c, executebuffer.c, > ddcomimpl.h, ddraw_thunks, surface_thunks). There are no functional changes > compared to the old patch, except a small change to forward the SYSTEMMEM and > WRITEONLY flags for vertexbuffers to WineD3D. > > The other files which have the same name as in the old code(main.c, > vertexbuffer.c): Those are rewrites(file deleted and re-created), so I won't > get a useful diff for them, no matter what I do. > > ChangeLog: > Stefan Dösinger: Use WineD3D for DDraw > I just want to state, the patch is very helpful when you can't use DGA. I just ran a test with Starcraft in multiplayer last night. Using OpenGL is noticibly faster than non-DGA. So I hope that it will get applied for 0.9.16. Jesse

2 6

Icmp* functions in iphlpapi.dll
by Simon Kissane 11 Jun '06

11 Jun '06

Hi In Win2000, the ICMP functions exist in icmp.dll In WinXP, they are still there, but they have also been duplicated into iphlpapi.dll How would one go about adding them to iphlpapi? Does one just duplicate all the code in the second DLL, or is there a way to have some function implemented once & then exported by multiple DLLs? (I'm a Wine newbie...) Suppose one was to add code to iphlpapi's LibMain which did LoadLibrary & GetProcAddress to get the addresses of the functions in icmp.dll, and then the iphlpapi implementations just called the icmp.dll implementations? (I'm assuming doing a static import would result in some kind of name collission?) Cheers Simon

4 3

My new hero...
by Dan Kegel 11 Jun '06

11 Jun '06

Qingdao is my new hero. He's really on a roll: http://www.winehq.org/pipermail/wine-cvs/2006-June/023427.html fixes a Visual Basic safearray redim bug, http://bugs.winehq.org/show_bug.cgi?id=5217 and he has two other fixes in unrelated areas this month. Mike, what was that you were saying about there not being any wine hackers who fixed problems all around the wine tree anymore? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER (FIXED)
by Andrey Turkin 11 Jun '06

11 Jun '06

Andrew Ziem wrote: > Please use this patch instead of previous "user3.patch". Thanks to > Andrey Turkin for catching the uninitialized variable. > > changelog: > user: handle special cases for SPI_SETDESKWALLPAPER > > The special cases remove the wallpaper or set it to default. > Previously, these cases were ignored, so Wine would crash. > > > > ------------------------------------------------------------------------ > > > > - if (filename == (LPSTR)-1) > + if ((LPCSTR)SETWALLPAPER_DEFAULT == filename || (LPCSTR)NULL == filename || '\0' == filename[0]) > { > - GetProfileStringA( "desktop", "WallPaper", "(None)", buffer, 256 ); > - filename = buffer; > + /* set default wallpaper or remove wallpaper*/ > + if (hbitmapWallPaper) > + DeleteObject( hbitmapWallPaper ); > + return TRUE; > } > hdc = GetDC( 0 ); According to MSDN, if - pvParam==SETWALLPAPER_DEFAUL || pvParam==NULL, then wallpaper will be set to default one - pvParam[0]=='\0', then wallpaper will be removed. I cannot see any signs of such distinction in your code :)

2 1

Re: getuname: add stub implementation [try 4]
by Dmitry Timoshkov 11 Jun '06

11 Jun '06

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > Add WINE_PREATTACH and correct numer of params for GetUName > Try4: Export functions by name (@), fix warning in FIXME > > Changelog > add minimal implementation for getuname dll and GetUName function Just curious, what application besides charmap.exe uses getuname.dll? -- Dmitry.

2 2

msi: sql parsing
by Joris Huizer 10 Jun '06

10 Jun '06

Hello, As somebody asked me whether I could try to use MSN Beta 8, I decided to give it a try; The installer quits at some point, caused by an unhandled SQL command "ALTER TABLE `Registry` HOLD" I decided to have a look at this, but I'm not familiar with msi, and my SQL knowledge isn't very big either; anyway, I added a few lines to the parser; now -- how could I find how to implement something for this? Regards, Joris diff --git a/dlls/msi/sql.y b/dlls/msi/sql.y index 86ebe30..f8c9f40 100644 --- a/dlls/msi/sql.y +++ b/dlls/msi/sql.y @@ -79,7 +79,7 @@ static struct expr * EXPR_wildcard( void int integer; } -%token TK_ABORT TK_AFTER TK_AGG_FUNCTION TK_ALL TK_AND TK_AS TK_ASC +%token TK_ABORT TK_AFTER TK_ALTER TK_AGG_FUNCTION TK_ALL TK_AND TK_AS TK_ASC %token TK_BEFORE TK_BEGIN TK_BETWEEN TK_BITAND TK_BITNOT TK_BITOR TK_BY %token TK_CASCADE TK_CASE TK_CHAR TK_CHECK TK_CLUSTER TK_COLLATE TK_COLUMN %token TK_COMMA TK_COMMENT TK_COMMIT TK_CONCAT TK_CONFLICT @@ -127,7 +127,7 @@ static struct expr * EXPR_wildcard( void %type <column_list> selcollist column column_and_type column_def table_def %type <column_list> column_assignment update_assign_list constlist %type <query> query from fromtable selectfrom unorderedsel -%type <query> oneupdate onedelete oneselect onequery onecreate oneinsert +%type <query> oneupdate onedelete oneselect onequery onecreate oneinsert onealter %type <expr> expr val column_val const_val %type <column_type> column_type data_type data_type_l data_count %type <integer> number @@ -156,6 +156,7 @@ onequery: | oneinsert | oneupdate | onedelete + | onealter ; oneinsert: @@ -235,6 +236,14 @@ onedelete: } ; +onealter: + TK_ALTER TK_TABLE table TK_HOLD + { + FIXME("Unimplemented: ALTER TABLE, HOLD\n"); + $$ = NULL; + } + ; + table_def: column_def TK_PRIMARY TK_KEY selcollist { @@ -807,7 +816,7 @@ UINT MSI_ParseSQL( MSIDATABASE *db, LPCW sql.len = 0; sql.view = phview; sql.mem = mem; - + r = SQL_parse(&sql); TRACE("Parse returned %d\n", r); diff --git a/dlls/msi/tokenize.c b/dlls/msi/tokenize.c index 05c3cda..9b628c0 100644 --- a/dlls/msi/tokenize.c +++ b/dlls/msi/tokenize.c @@ -45,6 +45,7 @@ struct Keyword { static const Keyword aKeywordTable[] = { { "ABORT", TK_ABORT }, { "AFTER", TK_AFTER }, + { "ALTER", TK_ALTER }, { "ALL", TK_ALL }, { "AND", TK_AND }, { "AS", TK_AS },

1 0

awwww
by Dan Kegel 10 Jun '06

10 Jun '06

Hey, I wanted to see if my computer could run Vista, but: $ ~/wine/programs/msiexec/msiexec /i VistaUpgradeAdvisor.msi fixme:msi:MsiInstallProductW L"VistaUpgradeAdvisor.msi" (null) err:msidb:load_string_table string table corrupt? err:msidb:load_string_table string table load failed! (000218f3 != 000047ef) Filed as http://bugs.winehq.org/show_bug.cgi?id=5395

5 6

Re: user[3/5]: handle special cases for SPI_SETDESKWALLPAPER
by Andrey Turkin 10 Jun '06

10 Jun '06

I cannot see where emptyW initialized. Andrew Ziem wrote: > The special cases remove the wallpaper or set it to default. > Previously, these cases were ignored, so Wine would crash. > <snip> > + if (NULL == pvParam || SETWALLPAPER_DEFAULT == pvParam) > + { > + static const WCHAR emptyW[1]; > + if (!SetDeskWallPaper( (LPSTR)pvParam )) > + return FALSE; > + SYSPARAMS_Save(SPI_SETDESKWALLPAPER_REGKEY, SPI_SETDESKWALLPAPER_VALNAME, emptyW, fWinIni); > + } > + else > + { > + if (!SetDeskWallPaper( (LPSTR) pvParam )) > + return FALSE; > + } > + break; >

2 1

Re: user[2/5]: implement A version of SPI_GETDESKWALLPAPER
by Andrey Turkin 10 Jun '06

10 Jun '06

Andrew Ziem wrote: > Previously, SPI_GETDESKWALLPAPER was handled by default: in the > switch, so the function (an A- function) would return a W string. > > ------------------------------------------------------------------------ > > > 5e4b86d689c899fc896d2870efaca9c335f01da0 > diff --git a/dlls/user/sysparams.c b/dlls/user/sysparams.c > index 5fed316..fb54b3b 100644 > --- a/dlls/user/sysparams.c > +++ b/dlls/user/sysparams.c > @@ -2496,6 +2496,16 @@ BOOL WINAPI SystemParametersInfoA( UINT > break; > } > > + case SPI_GETDESKWALLPAPER: /* 115 */ > + { > + WCHAR buffer[MAX_PATH]; > + ret = SystemParametersInfoW( SPI_GETDESKWALLPAPER, uiParam, buffer, fuWinIni ); > + if (!WideCharToMultiByte(CP_ACP, 0, buffer, -1, pvParam, uiParam, NULL, NULL)) > + ret = FALSE; > + else > + pvParam = buffer; > + } > + > default: > ret = SystemParametersInfoW( uiAction, uiParam, pvParam, fuWinIni ); > break; > > > ------------------------------------------------------------------------ > > > I think break is needed after case. Also, for what else pvParam = buffer; need for?

1 0

Recording with "Lexia" (mci "open new")
by Peter Åstrand 10 Jun '06

10 Jun '06

Hi, I've patched Wine to make recordings work in "Lexia" (http://www.lexia.just.nu/, currently down). When I started out, recordings didn't work, and I was getting traces like: trace:mci:mciSendStringW (L"open new type waveaudio alias capture", 0x7db2ebc8, 128, (nil)) fixme:mci:mciSendStringW 'new': NIY as device name trace:mci:mciSendStringW (L"set capture time format milliseconds bitspersample 16 samplespersec 22050 channels 1 bytespersec 44100 alignment 4", 0x7db92fa8, 128, (nil)) trace:mci:mciSendStringW (L"open capture wait", (nil), 0, (nil)) trace:mci:MCI_LoadMciDriver wDevID=0001 fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini trace:mci:mciSendStringW (L"record capture", 0x7db2ebc8, 128, (nil)) trace:mci:mciSendStringW (L"open capture wait", (nil), 0, (nil)) trace:mci:MCI_LoadMciDriver wDevID=0001 fixme:mci:MCI_LoadMciDriver Couldn't load driver for type L"CAPTURE". If you don't have a windows installation accessible from Wine, you perhaps forgot to create a [mci] section in system.ini I created the patch below, but eventually, it turned out that it's sufficient to add this to system.ini: [mci] CAPTURE=mciwave.dll In other words: With this change, recordings works despite mciSendStringW returning MCIERR_MISSING_DEVICE_NAME. Strange but true. To summarize: 1) I believe the mciwave.c patch below makes sense in any case, right? Without it freed memory is used. 2) Any ideas why "open new" works, even though MCIERR_MISSING_DEVICE_NAME is returned? 3) Most importantly: Why is it necessary to add CAPTURE to system.ini? Perhaps the "alias" argument isn't correctly handled? The patch: Index: dlls/winmm/mci.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/mci.c,v retrieving revision 1.69 diff -u -r1.69 mci.c --- dlls/winmm/mci.c 23 May 2006 12:48:57 -0000 1.69 +++ dlls/winmm/mci.c 8 Jun 2006 12:53:43 -0000 @@ -1283,10 +1283,9 @@ /* case dev == 'new' has to be handled */ if (!strcmpW(dev, wszNew)) { - FIXME("'new': NIY as device name\n"); - dwRet = MCIERR_MISSING_DEVICE_NAME; - goto errCleanUp; - } + /* FIXME: Use temp file name. Remove after use. */ + dev = MCI_strdupAtoW("mcitemp.wav"); + } /* otherwise, try to grab devType from open */ if (!strcmpW(verb, wszOpen)) { Index: dlls/mciwave/mciwave.c =================================================================== RCS file: /home/wine/wine/dlls/mciwave/mciwave.c,v retrieving revision 1.2 diff -u -r1.2 mciwave.c --- dlls/mciwave/mciwave.c 23 May 2006 12:48:10 -0000 1.2 +++ dlls/mciwave/mciwave.c 8 Jun 2006 12:53:43 -0000 @@ -409,18 +409,19 @@ fn = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(filename) + 1) * sizeof(WCHAR)); if (!fn) return MCIERR_OUT_OF_MEMORY; strcpyW(fn, filename); + /* Note: Frees filename as well */ HeapFree(GetProcessHeap(), 0, (void*)wmw->openParms.lpstrElementName); wmw->openParms.lpstrElementName = fn; - if (strlenW(filename) > 0) { + if (strlenW(fn) > 0) { /* FIXME : what should be done if wmw->hFile is already != 0, or the driver is playin' */ - TRACE("MCI_OPEN_ELEMENT %s!\n", debugstr_w(filename)); + TRACE("MCI_OPEN_ELEMENT %s!\n", debugstr_w(fn)); - wmw->hFile = mmioOpenW((LPWSTR)filename, NULL, + wmw->hFile = mmioOpenW((LPWSTR)fn, NULL, MMIO_ALLOCBUF | MMIO_DENYWRITE | MMIO_READ); if (wmw->hFile == 0) { - WARN("can't find file=%s!\n", debugstr_w(filename)); + WARN("can't find file=%s!\n", debugstr_w(fn)); dwRet = MCIERR_FILE_NOT_FOUND; } else Regards, -- Peter Åstrand ThinLinc Chief Developer Cendio http://www.cendio.se Teknikringen 3 583 30 Linköping Phone: +46-13-21 46 00

2 4

riched20 bug 4452 fix still not merged?
by Dan Kegel 10 Jun '06

10 Jun '06

Hi Matt, can you add http://bugs.winehq.org/show_bug.cgi?id=4452 to your list of riched20 bugs to look at? This one even has a fix, but for some reason the fix hasn't been merged yet. Thanks, Dan

1 0

Re: notepad patches (search/replace, etc)
by Vitaliy Margolen 10 Jun '06

10 Jun '06

Thursday, June 8, 2006, 6:40:33 PM, Anoni Moose wrote: > This is my first patch to an open source project... if anyone has any comments/suggestions, please tell me. :) > These patches add full search, search next, replace, and goto line functionality to notepad. Too bad I missed the 0.9.15 release! > Changelog: > * programs/notepad/main.c, programs/notepad/dialog.c, > programs/notepad/main.h, programs/notepad/notepad_res.h, > programs/notepad/dialog.h: > notepad: Add/call functions to load/save globals settings (including font info) to registry. > -Added full Search/Search Next functionality. > -Added full Replace functionality. > -Added full Goto Line functionality. > -Load/Save to registry whether we want to wrap long lines or not. Please one patch per email. You should combine all of your changes into one patch if that's one logical change and can be applied by itself. Of course resultant code should compile and work. > @@ -638,6 +641,8 @@ > Globals.hFont=CreateFontIndirect( &lf ); > Globals.lfFont=lf; > SendMessage( Globals.hEdit, WM_SETFONT, (WPARAM)Globals.hFont, (LPARAM)TRUE ); > + SETTINGS_SaveSettings(); > + Please respect indentation. Don't just copy&paste stuff all over the file. > VOID DIALOG_Search(VOID) > { > + > + if (Globals.find.hwndOwner == NULL) { > ZeroMemory(&Globals.find, sizeof(Globals.find)); > + } > Globals.find.lStructSize = sizeof(Globals.find); > Globals.find.hwndOwner = Globals.hMainWnd; Pretty much the same here: don't just insert stuff, indent it properly. And please no extra blank lines nor needles curly brackets. > + if (Globals.replace.hwndOwner == NULL) { > + ZeroMemory(&Globals.replace, sizeof(Globals.replace)); > + } Respect indentation and style of the file you changing. In this case 4-spaces not 2. > + Globals.hFindReplaceDlg = ReplaceText(&Globals.replace); > + assert(Globals.hFindReplaceDlg != 0); > +} Please don't use assert. Do a proper error checking instead. > + if (result == -1) { /* text not found. */ > + MessageBoxA(Globals.hEdit, "Cannot find text.", NULL, MB_OK | MB_ICONINFORMATION); > + } else { You should put all the text into resource files. > +WCHAR *GrabWindowTextW(HWND hWnd, DWORD *nbytes) { > + > + static WCHAR *data = NULL; > + DWORD _nbytes = 0; > + > + if (nbytes == NULL) nbytes = &_nbytes; > + > + *nbytes = (*nbytes == 0 ? GetWindowTextLengthW(hWnd) + 1 : *nbytes); > + data = HeapAlloc(GetProcessHeap(), 0, (*nbytes) * sizeof(WCHAR)); > + GetWindowTextW(hWnd, data, (*nbytes)+1); > + return data; > +} Why do you need static if you return allocated buffer? nbytes is misleading - it should be nchars. (*nbytes)+1 is incorrect. You allocated enough memory for *nbytes only. > +int SearchText(HWND hWnd, LPFINDREPLACE find, int pos); Please use windows types so they would work right on 64-bit platforms. > + "^R", CMD_REPLACE Native notepad has it as ctrl+H. Vitaliy Margolen

3 4

Re: netapi32: Improve NetUserGetInfo function
by Joris Huizer 10 Jun '06

10 Jun '06

Simon Kissane wrote: > netapi32: Improve NetUserGetInfo function > * Implemented support for all levels documented by MSDN > * Corrected error codes for nonexistent levels > * Now works with empty string as server name > > I have also attached a C program (which can be compiled with MINGW), > which tests the NetUserGetInfo functionality. > Perhaps you could write unit tests based on the test program, to show correctness of the current code - this helps avoiding regressions HTH, Joris

1 0

kernel32.VerSetConditionMask present
by Vitaly Lipatov 10 Jun '06

10 Jun '06

VerSetConditionMask function is introduced in kernel32 science Windows 2000. Some broken applications check VerSetConditionMask present via GetProcAddress for check version of running Windows. What is the preferable method to disable export VerSetConditionMask from kernel32 when we have win98 version? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: svrapi: add stub implementation [try 2]
by Robert Shearman 10 Jun '06

10 Jun '06

Vitaly Lipatov wrote: >+1 stub NetAccessAdd >+2 stub NetAccessCheck >+3 stub NetAccessDel >+4 stub NetAccessEnum >+5 stub NetAccessGetInfo >+6 stub NetAccessGetUserPerms >+7 stub NetAccessSetInfo >+8 stub NetConnectionEnum >+9 stub NetFileClose2 >+10 stub NetFileEnum >+11 stub NetSecurityGetInfo >+12 stub NetServerGetInfo >+13 stub NetSessionDel >+14 stub NetSessionEnum >+15 stub NetSessionGetInfo >+16 stub NetShareAdd >+17 stub NetShareDel >+18 stdcall NetShareEnum(str long ptr long ptr ptr) >+19 stub NetShareGetInfo >+20 stub NetShareSetInfo > > These should all be just exported by name (@) not also by ordinal judging by the fact that they are in alphabetical order. -- Rob Shearman

1 0

Re: WineD3D: Fog fixes
by Jesse Allen 10 Jun '06

10 Jun '06

On 6/9/06, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > This patch corrects a few issues with fog on transformed vertices, and > non-pixel-non-vertex fog. > > If WINED3DRS_FOGENABLE is TRUE, but WINED3RS_FOGVERTEXMODE and > WINED3DRS_FOGTABLEMODE are D3DFOG_NONE, then, according to the msdn, the > alpha channel specular color vertex color contains a pre-calculated fog > value. The same applied to transformed vertices if Vertexfog is enabled. This > patch uses glFogCoord to pass it to GL if GL_EXT_fog_coord is supported, and > disables GL fog if it isn't to minimize rendering issues. > > This patch makes Swat3 and Battlezone 2 happy, and the fog in Prince of Persia > 3D looks more correct now. I hoped that patch might solve the disappearing > objects problem in Half-Life 2, but unfortunately it doesn't, this seems not > to be fog-related :-( > > ChangeLog: > Stefan Dösinger(for CodeWeavers): Fog fixes > > This patch doesn't work with the latest fglrx saying missing symbol for glFogCoordf. Mesa is ok though. Jesse

2 1

winspool/tests: Tests for GetPrintProcessorDirectory (resend for current HEAD)
by Detlef Riekenberg 09 Jun '06

09 Jun '06

Am Freitag, den 02.06.2006, 00:11 +0200 schrieb Detlef Riekenberg: > Changelog: > - winspool/tests: Tests for GetPrintProcessorDirectory > Resend for current HEAD -- By By ... ... Detlef

1 0

Re: Yet another round of redundand NULL checks before HeapFree (found by Smatch).
by Michael Stefaniuc 09 Jun '06

09 Jun '06

Please disregard this patch as a false positive crept in. Michael Stefaniuc wrote: > hopefully this should be the last round of redundand NULL checks before > HeapFree removals. I know, famous last words. But this time i have > extended the redundant_null_check.pl Smatch script to find all non-null > variables from arbitrary complex if-expressions and check that any of > them dosn't get HeapFree'd on the truth path. > diff --git a/dlls/msacm32/driver.c b/dlls/msacm32/driver.c > index e537bc4..bec3526 100644 > --- a/dlls/msacm32/driver.c > +++ b/dlls/msacm32/driver.c > @@ -587,7 +587,7 @@ MMRESULT WINAPI acmDriverOpen(PHACMDRIVE > return MMSYSERR_NOERROR; > gotError: > WARN("failed: ret = %08x\n", ret); > - if (pad && !pad->hDrvr) > + if (!pad->hDrvr) nice NULL pointer dereference. > HeapFree(MSACM_hHeap, 0, pad); > return ret; > } bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

3 2

Re: user: Added specific winproc functions for calling dialog procedures.
by James Hawkins 09 Jun '06

09 Jun '06

Hey Alexandre, As of the following commit: Commit: 397bf3c2b133fe36529efcc4c1906bac1aac2da8 URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=397bf3c2b133fe36529efcc… Author: Alexandre Julliard <julliard at winehq.org> Date: Tue May 9 20:33:11 2006 +0200 user: Added specific winproc functions for calling dialog procedures. The VB/VC++ 6 installers crash pretty early in the setup sequence. Two things to keep in mind are that the installer works correctly if I set the win version to win98, or I revert the following part of the patch: @@ -447,14 +441,8 @@ LRESULT WINAPI DefDlgProcA( HWND hwnd, U SetWindowLongPtrW( hwnd, DWLP_MSGRESULT, 0 ); - if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) - { - /* Call dialog procedure */ - result = CallWindowProcA( dlgproc, hwnd, msg, wParam, lParam ); - /* 16 bit dlg procs only return BOOL16 */ - if( WINPROC_GetProcType( dlgproc ) == WIN_PROC_16 ) - result = LOWORD(result); - } + if ((dlgproc = DEFDLG_GetDlgProc( hwnd ))) /* Call dialog procedure */ + result = WINPROC_CallDlgProcA( dlgproc, hwnd, msg, wParam, lParam ); if (!result && IsWindow(hwnd)) { I've done a fair bit of digging around on this bug, and I've noticed some things that are probably obvious to you, but might help put light on the situation for others. The order of the calls before the patch is applied is: DefDlgProcA -> CallWindowProcA -> WINPROC_CallWndProc and after the patch is applied: DefDlgProcA -> WINPROC_CallDlgProcA -> WINPROC_CallWndProc I've added debug printf's in these functions to see when they're called and what certain pointers contain. With the patch applied and and win version set to win98, the debug output is the same: DefDlgProcA CallWindowProcA func: 0xffff0027 CallWindowProcA proc: 0x40a5e1ac WINPROC_CallWndProc proc: 0x403020 CallWindowProcA func: 0x41ea2020 CallWindowProcA handle_to_proc returned NULL WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 CallWindowProcA func: 0x41ea2020 CallWindowProcA handle_to_proc returned NULL WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 WINPROC_CallWndProc proc: 0x41ea2020 and the installer goes on as usual (we know this because of a richedit trace from the richedit control on the next install screen). Here is the debug output with the patch applied and version set to win2000: DefDlgProcA DefDlgProcA dlgproc: 0xffff0026 WINPROC_CallDlgProcA func: 0xffff0026 WINPROC_CallDlgProcA proc: 0x40a5e1f8 WINPROC_CallDlgProcA proc->thunk.proc: 0x412020 WINPROC_CallWndProc proc: 0x412020 wine: Unhandled page fault on read access to 0x00000000 at address 0x411799 (thread 0009), starting debugger... Any insight you can provide about this bug would be greatly appreciated. -- James Hawkins

1 0

Re: [WINED3D 2/9] Add the bulk of the GLSL string generation functions
by H. Verbeet 09 Jun '06

09 Jun '06

Is making the distinction between rgba and xyzw really needed? xyzw / rgba / stpq should be equivalent and the distinction is mostly for readability if you know the variable type. However, since you can't decided that purely based on whether something is a vertex shader or a pixel shader, the way it's currently done might be misleading in some cases.

2 1

Re: [WINED3D 9/9] Allow drawPrim to create and use the GLSL program
by H. Verbeet 09 Jun '06

09 Jun '06

Does this reset the currently used program to 0 when fixed function is supposed to be used again? I think we should just do glUseProgramObjectARB(programId), since when fixed function is supposed to be used the program id will be 0. That also mean you don't have to do an explicit glUseProgramObjectARB(0) at a later stage, which saves an extra shader switch, in particular if the same shader is used in the next DrawPrimitive call.

1 0

Re: Update the progress control while installing.
by Dmitry Timoshkov 09 Jun '06

09 Jun '06

"Mike McCormack" <mike(a)codeweavers.com> wrote: > --- a/dlls/msi/dialog.c > +++ b/dlls/msi/dialog.c > @@ -62,6 +62,8 @@ struct msi_control_tag > HICON hIcon; > LPWSTR tabnext; > HMODULE hDll; > + float progress_current; > + float progress_max; Is it really necessary to use float instead of long? -- Dmitry.

1 0

Re: notepad patches (search/replace, etc)
by Andreas Mohr 09 Jun '06

09 Jun '06

Hi, On Thu, Jun 08, 2006 at 08:40:33PM -0400, Anoni Moose wrote: > This is my first patch to an open source project... if anyone has any > comments/suggestions, please tell me. :) I can't help but say that your parents must have been giving you a rather "funny" name... Or, IOW, do we have any guidelines about "Anoni Moose" submissions to our project? Are they ok, not ok, ok? Loves me, loves me not, ... Anyway, thanks for a very nice collection of patches! Andreas Mohr

3 3

Re: notepad: settings saving code
by Robert Shearman 09 Jun '06

09 Jun '06

Anoni Moose wrote: >/* This table is used to save all of the needed font settings in Notepad. > * It looks quite messy, when in fact it _hugely_ eases loading/setting of settings. Really. ;) > * It is layed out as follows: > * > * [n][0] == pointer to registry subkey name (WCHAR) > * [n][1] == type of registry entry > * [n][2] == pointer to buffer to store setting > * [n][3] == size of data returned > * [n][4] == default value to use if subkey was not found > * [n][5] == registry path to open (ANSI, not including root (HKEY_CURRENT_USER, etc)) > */ >DWORD settings_data[15][6] = { > { (DWORD)&heightW, REG_DWORD, (DWORD)&Globals.lfFont.lfHeight, > sizeof(REG_DWORD), -10, (DWORD)&FONT_SETTINGS_REG_PATH }, > > You should define a proper structure to put this data in rather than casting the values to DWORD (which won't work in 64-bit mode). -- Rob Shearman

1 0

Re: regedit: bug fixes/feature
by Robert Shearman 09 Jun '06

09 Jun '06

Anoni Moose wrote: > These patches save current node on click, and remove items before > opening keys, so if a node has no keys/is invalid, no keys show, which > can lead to problems. Changelog: > > * programs/regedit/main.c, programs/regedit/childwnd.c: > regedit: Save current node to registry on change; load again after > regedit is reopened. > -Don't UpdateWindow() in InitInstance() (unneeded, adds > flicker). > -Delete all items from listview before opening key, so if > key open fails, no items display. > This patch looks good, but I'm not sure about removing the UpdateWindow call. I think it is still necessary, although it might be better to move it to after the getting of the default path, which should remove the flicker. -- Rob Shearman

1 0

Re: regedit: Refresh also refresh registry keys in listview
by James Hawkins 09 Jun '06

09 Jun '06

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > These patches allow for refreshing of registry keys in listview, when > Refresh menu item is selected. > > Changelog: > > * programs/regedit/framewnd.c, programs/regedit/treeview.c: > regedit: Uncomment RefreshListView() call, comment TVM_SELECTITEM call, > to > let "Refresh" menu item/key also refresh registry values being > shown > in treeview. > One patch per email please. Same goes for all your other submissions. -- James Hawkins

1 0

Re: edit: Fix crashing, bugs
by James Hawkins 09 Jun '06

09 Jun '06

On 6/8/06, Anoni Moose <moose.anoni(a)gmail.com> wrote: > This patch fix an unhandled page fault with MS notepad and Wine Notepad when > loading/editing large files, and some other bugs shown in the Changelog: > > * dlls/user/edit.c: > user: Fixed unhandled page-fault when text length exceeded buffer size. > -Don't gradually continue to highlight text if mouse button is > held in and > it's position moves out of the edit window, and doesn't move while > outside. > -Scroll up/down if mouse is outside of window and moving up/down. > -If a button was clicked in a dialog, therefore setting the focus > to it, and then > an application sent a SETFOCUS message to an editbox, it would > keep the focus on > the button. > You need to submit one fix per patch, one patch per email. -- James Hawkins

1 0

Re: str*casecmpW functions
by Vitaliy Margolen 09 Jun '06

09 Jun '06

Thursday, June 8, 2006, 6:57:36 PM, Anoni Moose wrote: > This patch adds some functions for comparison of WCHAR strings, while ignoring case. Changelog: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. BTW what's wrong with strncmpiW? Vitaliy Margolen

1 0

Re: server: use getopt
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > This patch let's the server code use getopt to parse arguments. + while ((optchr = getopt(argc, argv, "d:fhk:p:vw")) != -1 && + optind < argc) { /* 'Tis possible we might have a variable declaration... */ + + switch (optchr) { + case 'd': - if (isdigit(argv[i][2])) debug_level = atoi( argv[i] + 2 ); + if (isdigit(optarg[0])) debug_level = atoi( optarg ); else debug_level++; break; Using getopt() doesn't really gain us anything here. Also, changing the indent and brace style to suit yourself (especially in wineserver) isn't appreciated. Mike

1 0

Re: wcmd: some features/bug fixes
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > * programs/wcmd/builtins.c, programs/wcmd/wcmdmain.c, > programs/wcmd/wcmd.h: > wcmd: Clear terminal screen using escape code. > -Fix infinite file-read loop with TYPE command. > -TITLE command use terminal escape code. > -Added FREEDISK command. Please send one patch per email. The patch should be standalone. + /* Clear the _terminal_ screen by giving the correct terminal escape code. */ + printf("%cc", 0x1B); You can't assume that you'll be using any sort of terminal here. If the backend is wineconsole or a non-xterm/vt100 terminal, then this won't work. You have to use the Win32 API. Mike

1 0

Re: str*casecmpW functions
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > * libs/unicode/string.c: > unicode: Added strcasecmpW, strncasecmpW functions. You've added a dependency on user32.tolowerW, which cannot be linked from all the places that unicode.h is used. Mike

1 0

Re: notepad: settings saving code
by Mike McCormack 09 Jun '06

09 Jun '06

Anoni Moose wrote: > The following files allow saving and loading of notepad's settings to > the registry. No patch needed... new files. Changelog: Always send a patch, and make sure to create it from your wine/ directory so that the full path of the file that you're modifying is specified. These files won't be compiled unless you add something to the Makefile.in, and can't be used without some kind of change to the existing code. Mike

1 0

xlldrv/keyboard.c: Report of typos
by Andrew Talbot 09 Jun '06

09 Jun '06

I believe there are numerous typos in this file. Starting at line 310, there seem to be several missing double quotes; they break compilation if -Wwrite-strings is specified. I was going to assume the missing quotes to be the only factor and fix things myself. But as there are some non-printing characters in there that I don't understand, I thought I would mention it here, instead, so that someone who knows about keyboard layouts might fix these arrays properly. -- Andy.

3 3

Prospects of an OpenAL audio driver...
by Nick Burns 08 Jun '06

08 Jun '06

I have started work on an openal driver for wine... So far I have playback and recording working (with minor issues) (for some reason the DSound HEL is unhappy with my driver) OpenAL seems to have enough functionality to do the job. Are there any problems with using OpenAL for such a purpose? - Nick

3 7

Feedback requested for Mac OSX x86 stack patch
by Nick Burns 08 Jun '06

08 Jun '06

(notes are at the top of the patch) I would like some feedback on my stack fix patch I do not know how it interacts with linux -- no access to a linux box This has been confirmed to fix numerous app issues (due to stack alignment) I am starting to think it would be better to have these options configured at config time -- e.g. If Mac OSX x86 -- then use mstackrealign + force_align_arg_pointer Any ideas/thoughts? - Nick

3 12

Feedback requested for Mac OSX x86 stack patch -- #2
by Nick Burns 08 Jun '06

08 Jun '06

Ok I have fixed up my Mac OSX stack patch a bit as per the feedback -- thanks much This only patches windef.h There still needs to be some solution for msvcrt AND any other api entry points that are not denoted with __stdcall or __cdecl or WINAPI or WINAPIV.... This means that Morrowwind (uses msvcrt:pow just cause) will crash on OSX atm (bad alignment) - Nick

2 2

Feedback requested on an OpenAL audio driver patch -- #2
by Nick Burns 08 Jun '06

08 Jun '06

Ok I fixed up my OpenAL driver as per the suggestions (thanks much) I am not sure how to use or test pkg-config (does that exist on Mac OSX?) The differences with the OpenAL driver patch... 1. It has a perty ChangeLog diff 2. configure.ac now checks for AL/al.h (which is where OpenAL should be) 3. dlls/Makefile.in should patch correctly now (I did not hand edit it this time -- still crossing fingers) 4. FIXME's -> ERR's for the legit OpenAL errs 5. alcCloseDevice in OpenAL 1.0 (no return value) in 1.1 it returns a boolean -- .: I dont check the boolean anymore -- meaning this error is now slient - Nick

2 2

Re: Linux noob
by Molle Bestefich 08 Jun '06

08 Jun '06

Peter Beutner wrote: > Because it is the defacto standard to store settings > under ~/.<appname>. Only for stuff that's thought to be generally uninteresting. Your KDE desktop, for example, resides under ~/Desktop. > And with enough applications installed that use this "standard" > you probably will be glad that these directories are hidden so that > you don't have to scroll through them every time you open > your filemanager ;). I'm annoyed that .wine is inaccessible through KDE and Gnome apps. Not through the file manager, but often in various applications. It's not wine's fault per se that those apps lack a "show hidden folders" option, but it would be nice to make wine visible, as it contains useful stuff that you'll often mangle with. (I personally have a symlink from "wine" to ".wine"...) I do agree that there's too many applications dumping various .xxxxxx folders in my home directory. The least they could do is to put those files somewhere where they don't interfere with my user data, someplace sane like ~/Application Data/xxxxxx, or a more unixy ~/appdata/xxxxx... (Never cared much for hidden folders - they're a symptom that you're being too careless with your directory structure.)

6 13

Re: [MAPI32 2/3] interface IProfAdmin & its 12 methods, function MAPIAdminProfiles implemented
by Alexandre Julliard 08 Jun '06

08 Jun '06

argentum(a)office.etersoft.ru writes: > +/************************************************************************** > + * IProfAdmin_GetLastError > + * > + * PARAMS > + * hResult [I] HRESULT data type containing the error value > + * generated in the previous method call. > + * lppMAPIError [O] Pointer to a pointer to the MAPIERROR structure > + * containing version, component, and context information > + * for the error. The lppMAPIError parameter can be set > + * to NULL if there is no MAPIERROR structure to return. > + * ulFlags [I] Bitmask of flags that controls the type of the string > + * pointed to by lpszProfileName. The following flag can be set: > + * 0 The strings in the structure returned in the pointer parameter > + * are in ANSI format > + * MAPI_UNICODE The structure's strings are in Unicode format. > + * RETURNS > + * S_OK The call succeeded and has returned the expected value or values. > + * MAPI_E_BAD_CHARWIDTH Either the MAPI_UNICODE flag was set and the implementation > + * does not support Unicode, or MAPI_UNICODE was not set and the > + * implementation only supports Unicode. > + */ Copying text from MSDN is not acceptable. If you are going to write documentation you have to do it in your own words, without looking at MSDN. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Feedback requested on an OpenAL audio driver patch -- #2
by Nick Burns 08 Jun '06

08 Jun '06

(the elusive attachment) It helps when I hit the attach button (sorry) - Nick

1 0

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag 08 Jun '06

08 Jun '06

P.S. Isn't it better to use pkg-config to check where the libs are located anyway? Leon

3 2

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag 08 Jun '06

08 Jun '06

> AC_CHECK_HEADERS(\ >+ OpenAL/al.h \ >+ al/al.h \ > AudioUnit/AudioUnit.h \ > CoreAudio/CoreAudio.h \ > IOKit/IOKitLib.h \ Your patch checks for OpenAL headers only in these places. However my distro (Suse 10.1) puts openal headers to AL/ instead of al/ and so configure with the patch as-is doesn't find files on my system. Also patching dlls/makefile.in fails. Had to patch it manually. Leon

2 1

Re: Feedback requested on an OpenAL audio driver patch
by Leon Freitag 08 Jun '06

08 Jun '06

My first impressions: 1) Doesn't compile here: audio.c: In function ‘OpenAL_WaveClose’: audio.c:636: error: void value not ignored as it ought to be because alcCloseDevice() is declared here as void (my openal version is 1.0.20051129) 2) It'd be better to convert ALC errors from FIXMEs to ERRs. 3) You don't link the driver to openal somewhy (there's no -lopenal switch passed to gcc). Perhaps it's related to the configure.in hack I made, but I had to modify dlls/winmm/wineopenal/Makefile.in and add openal there too. 4) You check for al/al.h and OpenAL/al.h within the configure script but you include AL/al.h and OpenAL/al.h. This doesn't work on Linux, since Linux filesystems are case sensitive. Leon

2 1

Feedback requested on an OpenAL audio driver patch
by Nick Burns 08 Jun '06

08 Jun '06

I finally figured out my dsound HEL problem (was making too many buffers) -- now I wait and only use a few buffers. It seemed to work well for GTA3, Tribes2 and FlatOut(requires a binary patch to run) (dsound) -- and for SndRec32 (win/wout) (Games and ...App... tested under Mac OSX x86 -- Mac Book Pro) Remove the disable 'OPENAL_DISABLE_IN' to test wavein. (Forced off due to some issues of my OpenAL framework (I could only record at 44k -- could not figure out how to force 44k only for wavein) -- others may have better luck) So here is my patch -- It adds it to winecfg, the makefile.in, configure.ac And it adds the new files (the actual driver why not) I would like any feedback ppl out there may have. (It is missing a ChangeLog thingy -- that would look like the below) ---- 2006-06-04 Nick Burns <adger44(a)hotmail.com> * configure.ac: Added checks for OpenAL (Mac OSX and linux). * dlls/Makefile.in: Added OpenAL to build thingy. * include/config.h.in: Added OpenAL to config -- using autoheader (may not be needed). * programs/winecfg/audio.c: Added OpenAL to winecfg for choosing. * dlls/winmm/wineopenal/openal.c, dlls/winmm/wineopenal/openal.h, dlls/winmm/wineopenal/audio.c, dlls/winmm/wineopenal/wineopenal.drv.spec, dlls/winmm/wineopenal/Makefile.in: Initial checkin of OpenAL driver. ---- - Nick

2 2

Re: [KERNEL 1/2] changed test for function FindFirstFileA to find dosdevices
by Vitaliy Margolen 08 Jun '06

08 Jun '06

Wednesday, June 7, 2006, 9:03:43 AM, Konstantin Petrov wrote: > changed test for function FindFirstFileA to find dosdevices. > As function FindFirstFile must accept such paths as > "c:\\windows\\win.ini" > "c:\\NUL", > "c:\\COM1", > "c:\\LPT1", > "c:\\LPT9", > "c:\\COM9", > "c:\\CON", > "c:\\AUX", > "c:\\PRN" > and mustn't accept paths: > "\\\\.\\CON", > "c:\\COM0", > "", > "c:\\LPT0", That's because you have only one serial and one parallel port. The special name is the special name. It's different how win9x and winNT handles them. Which system have you ran these tests on? Vitaliy Margolen

1 0

Re: shell32: Write-strings warning fix
by Robert Shearman 07 Jun '06

07 Jun '06

Andrew Talbot wrote: >Changelog: > shell32: Write-strings warning fix. > >diff -urN a/dlls/shell32/shlview.c b/dlls/shell32/shlview.c >--- a/dlls/shell32/shlview.c 2006-05-23 17:24:50.000000000 +0100 >+++ b/dlls/shell32/shlview.c 2006-06-07 19:37:41.000000000 +0100 >@@ -779,7 +779,9 @@ > */ > > static void ShellView_MergeViewMenu(IShellViewImpl * This, HMENU hSubMenu) >-{ MENUITEMINFOA mii; >+{ >+ MENUITEMINFOA mii; >+ static CHAR mii_type_data[] = "View"; > > TRACE("(%p)->(submenu=%p)\n",This,hSubMenu); > >@@ -791,7 +793,7 @@ > mii.cbSize = sizeof(mii); > mii.fMask = MIIM_SUBMENU | MIIM_TYPE | MIIM_DATA; > mii.fType = MFT_STRING; >- mii.dwTypeData = "View"; >+ mii.dwTypeData = mii_type_data; > mii.hSubMenu = LoadMenuA(shell32_hInstance, "MENU_001"); > InsertMenuItemA(hSubMenu, FCIDM_MENU_VIEW_SEP_OPTIONS, FALSE, &mii); > } > Sorry, this is wrong. If InsertMenuItemA writes to the string then it will be corrupted and will display the wrong thing for further uses in the process. It is therefore better to cast it from a "const char *" into a "char *" or to make it a non-static array at the top of the function. I think the first choice of keeping it a "const char *" is the best choice in this case. -- Rob Shearman

2 2

re: lstrlen(A/W) patch
by Dan Kegel 07 Jun '06

07 Jun '06

Clinton wrote: >> Does the Richedit control return an error, or clear itself when passed >> EM_SETTEXTEX with lParam = NULL? >On Windows, it returns 1 and clears itself. Unless the ST_SELECTION >flag is set, in which case it returns 0, and actually replaces the text >with nothing. >My patch to wine results in the same behavior. I'll send it to >wine-patches. Great! Any chance you could include a conformance test in your patch? Thanks, Dan

1 0

Re: [uxtheme/tests] Add initial tests (Second try)
by Paul Vriens 07 Jun '06

07 Jun '06

On Wed, 2006-06-07 at 08:44 +0200, Paul Vriens wrote: > Hi, > > I've added the framework and some initial (simple) tests. No > functionality tests (yet), only parameter and return-value checking. > > This one also 'fixes' the tests for Wine when theming is enabled. > > Changelog > Added framework and initial tests > > Cheers, > > Paul. Anything I can do to improve? This patch will of course be followed up by fixes. Cheers, Paul.

1 0

Hal and functions in setupapi
by Christian Gmeiner 07 Jun '06

07 Jun '06

Hi all... at the momemt i am reading into functions to get some informations about e.g. cdrom drives. At the moment i am loking into SetupDiGetClassDevsW to support GUID_DEVINTERFACE_CDROM and later USB devices. My overall goal is it to get Line 6 software for my guitart effect board (USB) working with wine. Now i thought about a way to get all informations about a singe cdrom device. And i thought that I could use HAL perfectly for this. I thought about this way of doing it: Add hal.c file to setupapi dll, which contains function to get infromations about all needed hardware. This should work very nicly for this case. But as I want to programm RegisterDeviceNotification also we need a central way to handle hal stuff. So how should I go on? Use some own hal.c in setupapi or add an global wine way to interact with hal? Thanks, Christian

3 2

Re: libunicode: Add some more code page tables that are available for download from ftp.unicode.org, most notably the table for the us-ascii encoding, which is quite common.
by Alexandre Julliard 07 Jun '06

07 Jun '06

Robert Shearman <rob(a)codeweavers.com> writes: > libs/unicode/Makefile.in | 3 > libs/unicode/c_1361.c | 5138 > ++++++++++++++++++++++++++++++++++++++++++++++ > libs/unicode/c_20000.c | 3587 ++++++++++++++++++++++++++++++++ > libs/unicode/c_20127.c | 683 ++++++ > libs/unicode/cpmap.pl | 3 > libs/unicode/cptable.c | 8 This won't work, the source files are not in the expected format, so the resulting tables contain garbage. You'll need to teach cpmap.pl to parse these files correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Avoid unnecessary casts
by Detlef Riekenberg 07 Jun '06

07 Jun '06

Am Mittwoch, den 07.06.2006, 16:45 +0900 schrieb Dmitry Timoshkov: > - psh.u3.ppsp = (LPCPROPSHEETPAGEW) & psp; > + psh.u3.ppsp = psp; Where is the "&" ? -- By By ... ... Detlef

1 0

Re: [WINED3D 2/3] Fix missing light recording
by Michael Stefaniuc 07 Jun '06

07 Jun '06

Ivan Gyurdiev wrote: > >> >From nobody Mon Sep 17 00:00:00 2001 >> > > Please delete this line in case the patch is corrupt.. missed it The patch is not corrupted as it starts only with the '---' line. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: lstrlen(A/W) patch
by Mike McCormack 07 Jun '06

07 Jun '06

Clinton Stimpson wrote: > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" The inline lstrlenW is used only internally by Wine code, and we want it to crash when passed a NULL pointer. In this case, you should fix the Wine code calling lstrlenW to not use a NULL pointer. Mike

2 3

Re: D3D9: Add a test for setting / getting vertex shader constants
by Raphael 06 Jun '06

06 Jun '06

On Tuesday 06 June 2006 23:17, H. Verbeet wrote: > This is a test for Ivan's patch for shader constants > (http://source.winehq.org/git/?p=wine.git;a=commit;h=5f5969b3c5bd237277b8f2 >f1eaa4ddacce5fb63b) > > Changelog: > - Add a test for setting / getting vertex shader constants Simple testing :) can you add border tests in future: hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 4, bool_in, 4); hret = IDirect3DDevice9_SetVertexShaderConstantB(device_ptr, MAX_VSHADER_CONSTANTS - 2, bool_in, 4); I'm interested to see how windows handle that :) Regards, Raphael

3 3

winedbg - setting breakpoint
by Stephen Clark 06 Jun '06

06 Jun '06

Hello List, I am trying to get classic Myst to run again under wine. How do I set a breakpoint in it when it run by winevdm. Thanks, Steve -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas Jefferson)

2 1

re: Hal and functions in setupapi
by Dan Kegel 06 Jun '06

06 Jun '06

Christian wrote: > as I want to programm RegisterDeviceNotification also we > need a central way to handle hal stuff. > > So how should I go on? Use some own hal.c in setupapi or > add an global wine way to interact with hal? I think programs/explorer already registers for device notification with hal. You should look at that before you go on. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: APPDB patch
by Tony Lambregts 06 Jun '06

06 Jun '06

EA Durbin wrote: > fixed typographical errors. > > > ------------------------------------------------------------------------ > > ? patch.diff > Index: TODO > =================================================================== > RCS file: /home/wine/appdb/TODO,v > retrieving revision 1.22 > diff -u -p -r1.22 TODO > --- TODO 12 Jun 2005 02:50:18 -0000 1.22 > +++ TODO 6 Jun 2006 02:19:34 -0000 > @@ -7,7 +7,7 @@ WineHQ Application Database TODO List > AppDB Todo: > > * Improve application/version submission process > - Currently a user submits an application/version and a admin reviews it and > + Currently a user submits an application/version and an admin reviews it and > either makes changes to it and accepts it or writes a comment and rejects it. Upon > rejection the submission is deleted > > There is no sense in keeping our todos in two places. We should probabably just point to the wiki in this file. http://wiki.winehq.org/AppdbInfo Tony Lambregts

1 0

Re: lstrlen(A/W) patch
by Andreas Mohr 06 Jun '06

06 Jun '06

Hi, On Mon, Jun 05, 2006 at 09:24:24PM -0600, Clinton Stimpson wrote: > > I encountered a crash when using PAF 5.2. > > The following patch will fix the crash. > MSDN documentation says "*lstrlen* assumes that /lpString/ is a > null-terminated string, or NULL" MSDN documentation says many things... most of them wrong. ;-) (only slightly exaggerated, given Wine's experience with MSDN "correctness" over the years) IOW, I severely doubt that this is indeed the way Windows behaves, otherwise it'd have been fixed in Wine a long time ago already since apps would rely on and fully expect this behaviour of such a central and important function. Most likely you encountered application misbehaviour (feeding a NULL parameter to a function expecting non-NULL) due to a different Wine bug which thus caused the app to mis-step. Would be interesting to figure out why this happened (e.g. via +relay trace). Andreas Mohr

1 0

Wine updated in Fedora Extras!
by Neal Gompa 06 Jun '06

06 Jun '06

Wine has been updated to 0.9.14 on May 30, 2006! So, this release took 6 days... Still, generally 3-5 days is pretty good estimation...

1 0

Re: winedbg: remove unneeded states from grammar (take 2)
by Alexandre Julliard 06 Jun '06

06 Jun '06

Juan Lang <juan_lang(a)yahoo.com> writes: > Oops, last one had a missing brace. Sorry about that. > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them Won't that make it impossible to use command keywords as identifiers in commands that accept them, like disass? Come to think of it, your previous NOCMD patch probably has the same issue. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Re: wined3d: Another GLSL shader status update
by fenix＠club-internet.fr 06 Jun '06

06 Jun '06

----Message d'origine---- >A: wine-devel(a)winehq.com >De: Mike Hearn <mike(a)plan99.net> >Date: Tue, 06 Jun 2006 12:31:06 +0100 >Sujet: Re: wined3d: Another GLSL shader status update > >On Sun, 04 Jun 2006 12:04:21 -0400, Jason Green wrote: >> > This is an elaborate scheme with linked lists in each shader - is that >> > really necessary? >> > I'm very confused after reading the code (but maybe that's just me :) >> >> If we link the programs together every time the Set__Shader() is called, >> it brings performance to a halt (that what my glsl_hack4.diff did). > >Re: the recent discussion on code commenting and documentation, it'd be >nice if the patch explained this somewhere. It'd be even nicer still if at >some point one of you guys could take a break from the codeface and write >a chapter for the Wine Developer Guide on shaders and how all this works >... it seems incredibly opaque and the last thing we want is a re-run of >the DCOM situation where the only people who understood it left or hacked >on other things for a while and we lost the knowledge of how it worked. I Aggree that adding more comments about current architecture (at least on http://wiki.winehq.com/DirectX-Shaders and http://wiki.winehq.com/WineD3D) can help to better understand for non-d3d introduced wine hackers :) I was the first who delivered that code and it's my fault for the initial poor comments about architecture (who was understandable for opengl/directx hackers). We'll try to improve it (maybe beginning with "WineD3D for dummies" :) ) Anyway we are many who understand this code (and reviewing the flood of wined3d patches) so "DCOM situation" cannot happen :) >thanks -mike Regards, Raphael

1 0

Re: Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr 06 Jun '06

06 Jun '06

----Message d'origine---- >Date: Tue, 06 Jun 2006 04:54:17 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: fenix(a)club-internet.fr >Copie à: wine-devel(a)winehq.org >Sujet: Re: [WINED3D 5/5] Remove constant type field in stateblock. > >Hi Raphael, > >Strange, your email shows up as an attachment. Yes it's my webmail who have strange behaviors :( > > + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start > > + 1)); > > should be: > > if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; > > UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); > > > as count and start are UINT (better to avoid ugliy > > unsigned/signed bugs). > >The current code checks if cnt < 0 later on. Yes but it was buggy :) MAX_VSHADER_CONSTANTS - (start + 1) can result on an unsigned overflow > > Anyway what windows do if (start + count > > > MAX_VSHADER_CONSTANTS) ? > > The code seems handle this case truncating the input > >It's possible that this is buggy [ I always thought it was off by one ], >or not handling this case properly. However, I've just copied the code >that was already there - unrolled the existing SetConstant function into >its callers, and made the change I was interested in. Fixing other bugs >would go into a separate patch. Ok, fine for me Waiting for more patches to review :) I'm really waiting to get my new GC to test last impressive work on shaders. Regards, Raphael

1 0

To K&R or not
by Molle Bestefich 06 Jun '06

06 Jun '06

EA Durbin wrote: > >K&R style brack placements > > They are an eyesore and make things difficult to read. Highly subjective. I think K&R has distinct advantages, namely it unites the scope begin token with the relevant control statement. For me, this makes code easier and faster to read, since I can follow the indentation and arrive immediately at the relevant control statement. Also I think that K&R is nice in that it saves screen real estate, which again for me makes code easier to read because I can see more of it at once. I personally consider non-K&R style an eyesore because of this. CMIIW, but the only thing that non-K&R has going for it is that you can visually make out whether you've made the correct number of opening versus closing braces. I don't think that's much of an advantage, especially considering that any modern source code editor will highlight the starting brace or relevant control statement for you. That said, I don't care what people do, I can read both... In my perfect world though, my SCM client would convert source code to my preferred format on checkout, and to whatever universal format the repository uses on checkin. Ho hum...

7 11

Re: Re: Linux noob
by Mike Hearn 06 Jun '06

06 Jun '06

On Tue, 06 Jun 2006 03:27:52 +0000, NikNot wrote: > Indeed! This is something that I found infuriating since I first > used wine. What possible reason would there be to make this > a "hidden" directory? From whom exactly should it be hidden > and why? Historical reasons. I'm switching this thread to wine-devel as TransGaming do in fact make the virtual C drive visible by default and it's maybe something we should do too. On the other hand, it might just be wallpapering over other usability problems (lack of menu integration, most obviously). How often does average jack need to go poking around C:\Program Files in real Windows? thanks -mike

1 0

re: acad 2004 license file bug
by Dan Kegel 06 Jun '06

06 Jun '06

Jaap wrote: >The autocad installer indicated that I needed internet explorer 6.0, >so I installed that using winetools. Don't use winetools, please. As you noticed, it does bad things to your ~/.wine. Or, if you do use it, please report problems to the winetools developer, not here. > (can wine fake internet explorer, >so i don't need to install the real thing?) Yes. Here's what I do: # Fake IE per workaround in http://bugs.winehq.org/show_bug.cgi?id=3453 wineserver -k cat >> $HOME/.wine/system.reg <<"_EOF_" [Software\\Microsoft\\Internet Explorer] "Version"="6.0.2900.2180" _EOF_ - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

DirectX blitter bug
by Mike Hearn 06 Jun '06

06 Jun '06

Lords of Magic works perfectly EXCEPT that rendering is corrupted when it is using DirectX "fast blitting"; they provide a software emulated workaround for some truly ancient cards (Matrox Mystique anyone?) and the game works well in this mode. But it should work properly in DirectX accelerated mode too. The kind of corruption varies but it appears as, for instance, mouse trails which to me suggests some kind of co-ordinate system problem. The demo is here: ftp://ftp.sierra.com/pub/sierra/lordsofmagic/demos/si_lordsofmagic_demo.exe and it installs cleanly on the master branch. If any DirectDraw gurus want to take a look, please do! I bet this problem affects other games too.... thanks -mike

2 2

Re: [WINED3D 5/5] Remove constant type field in stateblock.
by fenix＠club-internet.fr 06 Jun '06

06 Jun '06

----Message d'origine---- >Date: Tue, 06 Jun 2006 02:46:59 -0400 >De: Ivan Gyurdiev <ivg2(a)cornell.edu> >A: wine patch <wine-patches(a)winehq.org> >Sujet: [WINED3D 5/5] Remove constant type field in stateblock. > >It is wrong to maintain a mapping from a constant index to a type field, >because different constant types do not share an index - boolean >constant 0 is supposed to co-exist with floating point constant 0, not >replace it. Drawprim and other code using the type array to decide >whether to look up a constant in bools, floats, or ints is wrong - you >can't make that decision based on the index. > >To do this: >========== >- split .set and .changed stateblock arrays for constants into >individual arrays for F, B, and I constants >- don't use shared SetConstant/GetConstant function in device.c, unroll >that into its callers, and make them use separate .set and .changed >arrays. Remove old SetConstant/GetConstant functions, not enough is >shared to justify them. Remove SetConstantN, it's not used anymore. >- change stateblock to not use the type array >- change drawprim to use the .set array, instead of a type array to >check if constants need to be loaded > Hi Ivan, just one comment: + int i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); should be: if (start > MAX_VSHADER_CONSTANTS - 1) return WINED3DERR_INVALIDCALL; UINT i, cnt = min(count, MAX_VSHADER_CONSTANTS - (start + 1)); as count and start are UINT (better to avoid ugliy unsigned/signed bugs). Anyway what windows do if (start + count > MAX_VSHADER_CONSTANTS) ? The code seems handle this case truncating the input Best Regards, Raphael

2 1

Re: winedbg: remove unneeded states from grammar
by Eric Pouech 06 Jun '06

06 Jun '06

I'm not sure they are unneeded. for example, with your changes, b down would be seen by the grammar as tBREAKPOINT tDOWN which is not what we want. A+ 2006/6/6, Juan Lang <juan_lang(a)yahoo.com>: > > ChangeLog: many states in the command-line parser were unnecessary, so > remove them > > --Juan > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com > > > > > > -- Eric Pouech

1 0

GetDIBits() with a bitmap that is selected in a device context
by Michael Kaufmann 06 Jun '06

06 Jun '06

The application "Fritz 5.32" calls GetDIBits() with a bitmap that is still selected in a device context (see bug 3893). The bitmap has a color table. GetDIBits() creates a memory DC, selects the bitmap into this DC, and calls GetDIBColorTable(). But this fails, because Wine can't select this bitmap in a memory device context again. According to MSDN, calling GetDIBits with a bitmap that is selected in a device context is not allowed. But surprisingly it works on Windows. Does anybody have an idea how to solve this problem? Regards, Michael

2 3

re: oleaut32 [1/2]: Copy BYREF args directly if they have the same variant type [RESEND]
by Dan Kegel 06 Jun '06

06 Jun '06

James wrote: > Is there anything wrong with this patch? Well, it doesn't have a conformance test... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 4

[Fwd: Re: msi patch submission - cond.y]
by Dominic Wise 05 Jun '06

05 Jun '06

I may be wrong, but I feel it might be useful for a naive outsider to enter this discussion, even if it does mean I get burnt to a crisp. I'm neither a Wine nor a parser developer (though I do have a few years C/++ experience) and fully accept that I may be flamed to a tiny cinder for my comments, but from what I can ascertain, cond.y is a composite file, containing C and bison code. As far as I can tell (not quite brave enough to say AFAICT) the file is first read by the bison processor, which reads the bison parser rules and C code and generates compilable files for the C compiler. Having read what bison is (I think) supposed to do, the tokens declared DO look is if they might be wrong [having looked up 'tilde' and MSI on Google, it looks as though COND_I* actually relates to strings, as it seems that the tilde means 'case insensitive', but I wonder if it has been inadvertently used on integer comparisons by some installers]. It also looks as if the tests in compare_int() for COND_LE and COND_ILE may be wrong, unless there is some kind of (uncommented) logic inversion somewhere. However, uppermost in my mind is Mike McCormack's statement that 'Unfortunately cond.y has nothing to do with SQL.'. If this is indeed the case then everything I have said amounts to nought because I have assumed (very likely incorrectly) that the parser code in cond.y, being part of the MSI dll, relates to the parsing of SQL statements in MSI. If this is the case I fully expect to burn in newbie-land, and apologise for my presumption. Torch me if you want. Just trying to help, and open the discussion :)

1 0

Re: msi patch submission - cond.y
by Mike McCormack 05 Jun '06

05 Jun '06

EA Durbin wrote: > fixed various SQL errors in COND_GetOperator() and compare_int() Unfortunately cond.y has nothing to do with SQL. Mike

3 3

re: Wine VM86 exception handling bug?
by Dan Kegel 05 Jun '06

05 Jun '06

Andrey wrote: > My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86 > would restore vm86 registers correctly. I think i know what is the > problem; however, I lack experience to fix it myself :) > I need help; any hints would be appreciated. How about writing a conformance test that demonstrates the problem? That will help focus discussion and energy on it, and keep it from coming back. Thanks! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

7 11

Re: msi patch submission - cond.y
by Mike McCormack 05 Jun '06

05 Jun '06

EA Durbin wrote: > fixed various SQL errors in COND_GetOperator() and compare_int() IMO, both of your patches are incorrect. I'm waiting for your test case. Mike

3 2

To <space> or <tab> or not :-)
by Molle Bestefich 05 Jun '06

05 Jun '06

> isn't it rather insane to require specific editor settings > just to be able to *view* the code? It's a necessity for some editors. The TAB setting can be embedded in ASCII files, there are various magic comments that will cause vim and emacs to switch to a readable tabs setting. What is insane is 8 characters per tab. IMHXP 2 characters is too little to quickly make out the indentation. 3 and 4 are both fine choices. 4 wastes slightly more horizontal space, so I prefer 3. 8 is just nuts, it was probably written by someone who hates tabs and wants to use it as an argument to convince everybody to convert to spaces. Using spaces in place of tabs is bad, because you have to press <backspace> and <space> so much the more, wasting your time and tearing your fingers. And there's a higher risk of misaligning something - you have to pay more attention, which again is a waste of your time. You loose fine-grained control when you use tabs instead of spaces, but fine-grained control also means a jungle of bizarre rules about when-and-where-to-do-fine-grained-indenting, so it never pays off, rather it always ends up ruining the indentation anyway. By far the easiest solution is to just use tabs, and just indent codelines that span more than a screenful (7x chars or what not) with an extra tab.

3 3

Re: rpcrt4: Introduce a new function, safe_multiply, which will raise an exception if a multiply overflows a 4-byte integer.
by Alexandre Julliard 05 Jun '06

05 Jun '06

Robert Shearman <rob(a)codeweavers.com> writes: > + unsigned char overflow; > +#if defined(__i386__) && defined (__GNUC__) > + __asm__( > + "mull %3\n\t" > + "seto %%cl" > + : "=a" (ret), "=c" (overflow) /* outputs: eax, cl */ > + : "%a" (a), "rm" (b) /* inputs: eax, any register or memory > + * address (params are interchangable) */ > + : "edx" /* edx clobbered */); > +#else > + ret = a * b; > + overflow = (b && (ret / b != a)); > +#endif That asm seems really overkill. Something like: ULONGLONG ret = (ULONGLONG)a * b; if (ret > 0xffffffff) will generate pretty much the same code with a recent gcc, and it's a lot more readable. BTW could you please add a sequence number in the subject line for your patches? It makes things a lot easier for me when the mails arrive out of order. Thanks. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: userenv: Add a stub implementation of userenv.dll
by Detlef Riekenberg 05 Jun '06

05 Jun '06

Am Montag, den 05.06.2006, 14:01 +0900 schrieb Mike McCormack: > +++ b/dlls/userenv/userenv_main.c > +typedef struct _PROFILEINFOA { ... > +} PROFILEINFOA, *LPPROFILEINFOA; For mingw, this is in "include/userenv.h" -- By By ... ... Detlef

2 2

Light reading about .net framework 1.1 installer
by Dan Kegel 05 Jun '06

05 Jun '06

I just ran across an nice description of what the .net framework 1.1 installer uses during its execution: http://blogs.msdn.com/astebner/archive/2004/08/02/205936.aspx That's going to be a bit of a challenge. - Dan

1 0

re: Added initial version of Wine OleView
by Dan Kegel 05 Jun '06

05 Jun '06

Hi Piotr! Say, does it *do* anything useful yet? Might be worth waiting until it does before submitting it. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 2

Ecco Pro hangs when accessing "2nd level" dialogs
by Don Dwiggins 04 Jun '06

04 Jun '06

I'm a heavy user of Ecco Pro on Windows, and am trying to port myself as completely as possible to Linux (Ubuntu currently). Wine does a good job of supporting most of Ecco's features, but there are a couple of places (unfortunately important ones) where it hangs up tight. I've just submitted Bug #5335 about this problem. I'm a long-time programmer with good (if rusty) knowledge of C/C++ and Unix, just getting up to speed on Linux. I'm at the point where I might be willing to tackle this myself, if the learning curve isn't too steep. I'm posting this to ask for guidance on the best way to proceed. At least, if there's a good way to get more information on the hangup, I'm definitely willing to add to the bug report. Thanks for any good words, -- Don Dwiggins don(a)dondwiggins.net "The truth will make you free, but first it will make you miserable" -- Tom DeMarco

2 1

Re: FW: RE: My 1.0 wish list
by EA Durbin 04 Jun '06

04 Jun '06

>From: Hans Leidekker <hans(a)it.vu.nl> >To: wine-devel(a)winehq.org >CC: "EA Durbin" <ead1234(a)hotmail.com> >Subject: Re: FW: RE: My 1.0 wish list >Date: Sun, 4 Jun 2006 09:49:47 +0200 > >On Sunday 04 June 2006 09:08, EA Durbin wrote: > > > I wrote a quick test in wine/dlls/msi/tests/db.c to add a 2nd row to the > >Could you share it? > > > database that was being created, then I inserted the `id` of 8 into it >and > > then I ran the query SELECT * FROM phone where `id` > 6, and it returned > > the correct results with `id` of 8. But in the actual wine installer >code a > >Is the table in db.c comparable? Does it have the same fields and types? >Also, you're using > in your select but the failing select statement has >= >which may make a difference. > > -Hans It shouldnt matter whether its >= or >, they both return the wrong results in the actual msi installer and the right results in db.c. I have enclosed my tests, I tested these against the America's Army database installer and I have double checked the actual contents of the msi file in ORCA. I've packaged up some tests and included them with this email. Here are some queries that have returned the wrong results SELECT * FROM `Media` WHERE `LastSequence` > 15 SELECT * FROM `File` WHERE `Sequence` > 10 SELECT * FROM `Media` WHERE `LastSequence` >= 15 SELECT * FROM `File` WHERE `Sequence` >= 10

3 7

DAZ Studio
by Andrew Neil Ramage 04 Jun '06

04 Jun '06

After running winecfg and setting winver for DAZStudio.exe to XP, I get the following. andrew@apollo:~/Download/Windows> wine /home/andrew/.wine/drive_c/Program\ Files/DAZ/Studio/DAZStudio.exe fixme:imm:ImmReleaseContext (0x10020, 0x403cde30): stub fixme:imm:ImmReleaseContext (0xa00a2, 0x403cde30): stub fixme:imm:ImmReleaseContext (0x200aa, 0x403cde30): stub fixme:uniscribe:ScriptItemize L"DAZ|Studio can search for directories that\2028may contain content from other programs\2028that DAZ|Studio can read. Please indicate\2028which drives you want DAZ|Studio to search.\2028NOTE: On large drives or network drives\2028this operation can take several minutes.\4291",249,255,(nil),(nil),0x415ae8a4,0x415af0b0: semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291db70, 10, 10, 0x4232d1ac): semi-stub fixme:uniscribe:ScriptShape (0xac0, 0x4232a600, 0x4291db70, 10, 10, 0x4232d1ac): semi-stub fixme:uniscribe:ScriptPlace (0xac0, 0x4232a600, 0x4232ba40, L"'$=_6WXGLR", 10, 0x4232cea8, 0x4232d1ac, 0x4232bd2c): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291db84, 1, 1, 0x4232d1d4): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba54, L"\0003", 1, 0x4232cebc, 0x4232d1d4, 0x4232bd54): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291db86, 3, 3, 0x4232d1fc): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba56, L"FDQ", 3, 0x4232cebe, 0x4232d1fc, 0x4232bd58): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291db8c, 1, 1, 0x4232d224): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba5c, L"\0003", 1, 0x4232cec4, 0x4232d224, 0x4232bd64): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291db8e, 6, 6, 0x4232d24c): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba5e, L"VHDUFK", 6, 0x4232cec6, 0x4232d24c, 0x4232bd68): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291db9a, 1, 1, 0x4232d274): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba6a, L"\0003", 1, 0x4232ced2, 0x4232d274, 0x4232bd80): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291db9c, 3, 3, 0x4232d29c): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba6c, L"IRU", 3, 0x4232ced4, 0x4232d29c, 0x4232bd84): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291dba2, 1, 1, 0x4232d2c4): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba72, L"\0003", 1, 0x4232ceda, 0x4232d2c4, 0x4232bd90): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291dba4, 11, 11, 0x4232d2ec): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba74, L"GLUHFWRULHV", 11, 0x4232cedc, 0x4232d2ec, 0x4232bd94): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291dbba, 1, 1, 0x4232d314): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba8a, L"\0003", 1, 0x4232cef2, 0x4232d314, 0x4232bdc0): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291dbbc, 4, 4, 0x4232d33c): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba8c, L"WKDW", 4, 0x4232cef4, 0x4232d33c, 0x4232bdc4): semi-stub fixme:uniscribe:ScriptShape ((nil), 0x4232a600, 0x4291dbc4, 1, 1, 0x4232d364): semi-stub fixme:uniscribe:ScriptPlace ((nil), 0x4232a600, 0x4232ba94, L"", 1, 0x4232cefc, 0x4232d364, 0x4232bdd4): semi-stub fixme:win:SetWindowTextA setting text "EAX=00006078 EBX=42A6810C ECX=415AF1D8 EDX=403DFDE0 ESI=4232BA94\nEDI=403DF9D8 EBP=415AF15C ESP=415AF144 EIP=42A66FF5 FLG=00210246\nCS=0073 DS=007B SS=007B ES=007B FS=1007 GS=0033" of other process window (nil) should not use SendMessage -- Andrew When the dragons grow too mighty To slay with pen or sword I grow weary of the battle And the storm I walk toward Madrigal by Rush (A Farewell to Kings, 1974) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

4 4

Shell integration idea
by Mikołaj Zalewski 04 Jun '06

04 Jun '06

As a SoC project I'll try to improve the integration of wine with the Unix shells. My first step will be to implement the freedesktop.org Trash. I've written some code that doesn't add any new features but shows how I want to add it. I'd like to know if this is a good design? The main idea is not to hard-code one implementation of things like the Trash into shell32 - not everything is standardized by the freedesktop and even if it would this might not work on other systems like MacOS X. We should allow for many implementations. The correct one is loaded depending on a registry settings (so that a winecfg entry can be added). My implementation uses COM objects as it's standard dlls provides support for such tasks. Currently there is one interface (IWineShellIntegration) that acts as a factory for specialized objects. That could also be implemented using COM Aggregation - when we do that we could use QueryInterface instead of GetIntegrationObejct. Some COM objects can run in the address space of the calling process - e.g. the trash can be implemented like that. For others it would be a waist of resources (e.g. there is no need for every process to watch is the file associations have changed) - it's enough to load them only once. The explorer seems to be a good candidate to create such objects. In the attached patch there is one specialized interface - the IWineTrash. The SHELL_DeleteFile[AW] is patched to use it - it shows a different icon if the file can be trashed (these are not the correct icons as wine's shell32 uses a message box instead of a special dialog) and calls the trash method then. Currently there is only one built-in trash that can't trash anything. (note that SHELL_DeleteFile is called in the folders that are decendents of My Computer. If choose delete on a file that is a decendent of the '/', it will be deleted without a warning). Mikolaj Zalewski

5 8

Re: mapi32: Write-strings warnings fix
by Peter Oberndorfer 04 Jun '06

04 Jun '06

On Saturday 03 June 2006 16:33, Andrew Talbot wrote: > Changelog: > mapi32: Write-strings warnings fix. > > diff -urN a/dlls/mapi32/sendmail.c b/dlls/mapi32/sendmail.c > --- a/dlls/mapi32/sendmail.c 2006-05-23 17:24:40.000000000 +0100 > +++ b/dlls/mapi32/sendmail.c 2006-06-03 14:44:21.000000000 +0100 > @@ -113,8 +113,8 @@ > } > if (message->nFileCount) FIXME("Ignoring attachments\n"); > > - subject = message->lpszSubject ? message->lpszSubject : ""; > - body = message->lpszNoteText ? message->lpszNoteText : ""; > + subject = message->lpszSubject ? message->lpszSubject : NULL; > + body = message->lpszNoteText ? message->lpszNoteText : NULL; I think this is wrong, as it makes the whole "? :" construct unnecessary. (for non NULL it evaluates to "message->lpszNoteText" and for NULL it becomes NULL; > > TRACE( "Subject: %s\n", debugstr_a(subject) ); > TRACE( "Body: %s\n", debugstr_a(body) ); > > > Greetings Peter

3 12

Re: FW: RE: My 1.0 wish list
by EA Durbin 04 Jun '06

04 Jun '06

That can't be used for a test case, for a test case I, or most likely someone elsewho has the ability and the time has to write code under dlls/msi/tests/db.c and make a program in windows to re-illustrate this bug. >From: "Jason Green" <jave27(a)gmail.com> >To: "EA Durbin" <ead1234(a)hotmail.com> >CC: mike(a)codeweavers.com, dank(a)kegel.com, wine-devel(a)winehq.org >Subject: Re: FW: RE: My 1.0 wish list >Date: Sat, 3 Jun 2006 12:02:15 -0400 > >On 6/3/06, EA Durbin <ead1234(a)hotmail.com> wrote: >> >>This problem in MSI spans a multitude of bugs. >> >>ATI demo(Rendering With Natural Light ) - bug # 4712? >> > >I noticed yesterday that just about every ATI Demo had similar >installer problems. Just try a few from here if you need some quick >test cases: > >http://www.ati.com/developer/demos.html > >Thanks, and good luck!

2 3

Re: FW: RE: My 1.0 wish list
by EA Durbin 04 Jun '06

04 Jun '06

I have compiled a list of applications that are affected by the bug in which the query in ready_media_for_file() in MSI returns the wrong results, it returns LastSequence less than the file->Sequence being passed. Here is a detailed analysis of the multiple types of errors this bugs causes. Common debug outputs of this bug are: Error #1: err:msi:ACTION_InstallFiles compressed file wasn't extracted This error is usually caused by the results of the query returning a LastSequence number of Less than that of the working install media and the installer is trying to extract the file from the wrong install medium. Error #2: err:msi:extract_cabinet_file FDICopy failed err:msi:ACTION_InstallFiles Unable to ready media There is a zero in LastSequence Value of the Media table and the query in ready_media_for_file() returns it. For some reason the msi file has a zero in the LastSequence but its really a dummy cabinet file and doesn't exist. The file sequence being passed for the first file is most likely 1, and the query of >= 1 is returning 0 falsely causing this error. This problem in MSI spans a multitude of bugs. America's Army - bug #5139 J2SE - bug # 4280 Half Life 2 - bug # 5004, 4533 Dawn of War Demo - bug # 3749 E-Sword 6.5 - bug # 4251 Rush for Berlin demo - bug #5187 ATI demo(Rendering With Natural Light ) - bug # 4712? There are probably other bugs resulting from this, but the log doesn't detail it well enough, alot of them just have the debug dump at the end and not the pertainent msi err lines. I only included applications where it was obvious from the log, or I tested personally. >From: Mike McCormack <mike(a)codeweavers.com> >To: EA Durbin <ead1234(a)hotmail.com> >Subject: Re: FW: RE: My 1.0 wish list >Date: Sun, 04 Jun 2006 00:30:41 +0900 > > >You can send me as many mails as you like, but I'm not doing anything until >there's a test case showing the problem. > >Mike I wrote a test showing the results of the query in the wine installer and included the source code and resulting logs which clearly displays the problem. That's the best I can do. I'm not up to snuff on my C programming, nor am I familiary with how the official test case for wine is supposed to be layed out. If someone else wants to work on it then thats fine, but I layed out the problem, and debugged it, and I've proven this with code and resulting logs. This problem affects a multitude of applications in wine. If your not willing to work on it then either someone else can, or it can remain broken.

5 4

My 1.0 wish list
by Dan Kegel 04 Jun '06

04 Jun '06

... is now at http://wiki.winehq.org/DanKegel I'm willing to focus some effort on these tasks, too, so it's not just pie-in-the-sky wishing.

3 6

Alsa sound vs OSS with wine and riven
by Stephen Clark 03 Jun '06

03 Jun '06

Hello, I have been working to get "Riven" the sequel to Myst to work with the latest wine from cvs on the latest FC5. It works and the sound is almost perfect with OSS, but is totally screwed up when I use ALSA, I don't know whether this is a WINE or Linux issue, so I am cross posting to both lists. Regards, Steve -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas Jefferson)

1 0

Re: Added initial version of Wine OleView
by Vitaliy Margolen 03 Jun '06

03 Jun '06

Saturday, June 3, 2006, 11:36:45 AM, Piotr Caban wrote: Please change FSF's address to the new one. Vitaliy Margolen

1 0

ntdll: a simple implementation of cross-process NtAllocateVirtualMemory
by tkho＠ucla.edu 03 Jun '06

03 Jun '06

Hello, I ran across the need to do memory allocations across processes and came upon Alexander Yaworsky's patch at http://www.winehq.org/pipermail/wine-devel/2004-September/029953.html and took a different approach. Instead of waiting for the target process to check a fd, I changed the implementation to use ptrace to interrupt the target process and execute code in kernel32 that does an mmap/munmap. This is a simple implementation that does not do a full-on call to Nt(Allocate|Free)VirtualMemory inside the target process, mainly because the locks taken in the allocation management code would cause deadlocks. I've done informal testing to make sure the code doesn't crash Wine by running applications alongside this memory-churner: http://www.seas.ucla.edu/~kho/wine/alloc_test/alloc_test.exe http://www.seas.ucla.edu/~kho/wine/alloc_test/alloc_test.cpp One thought that has recently crossed my mind: Building off his framework and putting much of the code in the server may not have been a great idea, since the only real need for the server is to get the unix pid of the thread. Is this a step in the right direction? Comments appreciated! Thomas Kho --- Index: dlls/kernel/kernel32.spec =================================================================== RCS file: /home/wine/wine/dlls/kernel/kernel32.spec,v retrieving revision 1.174 diff -u -r1.174 kernel32.spec --- dlls/kernel/kernel32.spec 27 May 2006 11:36:56 -0000 1.174 +++ dlls/kernel/kernel32.spec 2 Jun 2006 05:43:15 -0000 @@ -1239,3 +1239,8 @@ # Init code @ cdecl __wine_kernel_init() + +# Remote memory allocation +# kernel32 is mapped to the same place in every process +@ cdecl wine_remote_NtAllocateVirtualMemory(ptr long long) +@ cdecl wine_remote_NtFreeVirtualMemory(ptr long) Index: dlls/kernel/virtual.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/virtual.c,v retrieving revision 1.18 diff -u -r1.18 virtual.c --- dlls/kernel/virtual.c 23 May 2006 12:48:03 -0000 1.18 +++ dlls/kernel/virtual.c 2 Jun 2006 05:43:15 -0000 @@ -42,6 +42,7 @@ #include "wine/exception.h" #include "excpt.h" #include "wine/debug.h" +#include "wine/library.h" #include "kernel_private.h" @@ -778,3 +779,77 @@ __ENDTRY return FALSE; } + +/*********************************************************************** + * wine_remote_NtAllocateVirtualMemory (KERNEL32.@) + * + * Reentrant function that allocates memory + * + * PARAMS + * base [I] Desired base address + * size [I] Number of bytes to allocate + * prot [I] Memory protection flags + * + * RETURNS + * Success: %eax contains base address of allocated region of pages. + * Failure: %eax is NULL. + */ +void wine_remote_NtAllocateVirtualMemory( LPVOID base, DWORD size, DWORD prot ) +{ + char *mem; + size += sizeof(int *); + mem = wine_anon_mmap(base, size, prot, 0); + /*printf("mmap base=0x%08x size=%d prot=%d, allocated at 0x%x\n", + base, size, prot, mem);*/ + *(int *) mem = size; + + mem += sizeof(int); + /* return base address of allocated memory in eax */ + asm("movl %0, %%eax" + : + :"r"(mem) + :"%eax"); + asm("int3"); /* execution doesn't continue past here */ + return; +} + +/*********************************************************************** + * wine_remote_NtFreeVirtualMemory (KERNEL32.@) + * + * Reentrant function that frees mmap'd memory + * + * PARAMS + * base [I] Desired base address + * size [I] Number of bytes to free + * + * RETURNS + * Success: %eax contains size of unmapped region + * Failure: %eax is 0. + */ +void wine_remote_NtFreeVirtualMemory( LPVOID base, DWORD size ) +{ + int result; + if (size == 0) + { + base = (char *) base - sizeof(int *); + size = *(int *) base; + result = munmap(base, size); + } + else /* FIXME unsafe for invalid base */ + result = 1; + + /*printf("munmap base=0x%08x size=%d, result: %d (%s)\n", + base, size, result, result == 0 ? "success" : "failure");*/ + + if (result == 0) /* munmap success */ + result = size; + else + result = 0; + /* return munmap return value in eax */ + asm("movl %0, %%eax" + : + :"r"(result) + :"%eax"); + asm("int3"); /* execution doesn't continue past here */ + return; +} Index: dlls/ntdll/virtual.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/virtual.c,v retrieving revision 1.90 diff -u -r1.90 virtual.c --- dlls/ntdll/virtual.c 23 May 2006 12:48:22 -0000 1.90 +++ dlls/ntdll/virtual.c 2 Jun 2006 05:43:16 -0000 @@ -144,6 +144,36 @@ /*********************************************************************** + * remote_op + * + */ +NTSTATUS remote_op( HANDLE process, int opcode, + void* params, int params_size, + void* result, int* result_size ) +{ + NTSTATUS status, remote_status = 0; + + SERVER_START_REQ( remote_operation ) + { + req->handle = process; + req->code = opcode; + if (params) wine_server_add_data( req, params, params_size ); + wine_server_set_reply( req, result, *result_size ); + if (!(status = wine_server_call( req ))) + { + remote_status = reply->status; + if (result) + *result_size = wine_server_reply_size( reply ); + TRACE("result_size=%d\n", *result_size); + } + } + SERVER_END_REQ; + + return status ? status : remote_status; +} + + +/*********************************************************************** * VIRTUAL_GetProtStr */ static const char *VIRTUAL_GetProtStr( BYTE prot ) @@ -1250,8 +1280,8 @@ * NtAllocateVirtualMemory (NTDLL.@) * ZwAllocateVirtualMemory (NTDLL.@) */ -NTSTATUS WINAPI NtAllocateVirtualMemory( HANDLE process, PVOID *ret, ULONG zero_bits, - SIZE_T *size_ptr, ULONG type, ULONG protect ) +NTSTATUS WINAPI NtAllocateVirtualMemory( HANDLE process, PVOID *ret, + ULONG zero_bits, SIZE_T *size_ptr, ULONG type, ULONG protect ) { void *base; BYTE vprot; @@ -1265,8 +1295,48 @@ if (!is_current_process( process )) { - ERR("Unsupported on other process\n"); - return STATUS_ACCESS_DENIED; + struct remote_op_params_vm_alloc alloc_params; + struct remote_op_result_vm_alloc alloc_result; + int result_size = sizeof(alloc_result); + typedef void (*allocator_type)(LPVOID base, DWORD size, DWORD prot); + static allocator_type allocator = NULL; + + if (!allocator) + { + HMODULE hkernel32; + UNICODE_STRING module; + ANSI_STRING function; + WCHAR kernel32W[] = {'k','e','r','n','e','l','3','2', + '.','d','l','l',0}; + RtlInitUnicodeString(&module, kernel32W); + RtlInitAnsiString(&function, "wine_remote_NtAllocateVirtualMemory"); + if (LdrGetDllHandle(0, 0, &module, &hkernel32) == STATUS_SUCCESS) + LdrGetProcedureAddress(hkernel32, &function, 0, + (void**)&allocator); + else + return STATUS_DLL_NOT_FOUND; + printf("using allocator in kernel32 at 0x%08x\n", + (unsigned) allocator); + } + + alloc_params.addr = *ret; + alloc_params.zerobits = zero_bits; + alloc_params.size = size; + alloc_params.type = type; + alloc_params.protect = VIRTUAL_GetProt( protect ); + alloc_params.allocator = allocator; + status = remote_op( process, REMOTE_OP_VM_ALLOC, + &alloc_params, sizeof(alloc_params), + &alloc_result, &result_size ); + if (!status) + { + *ret = alloc_result.addr; + *size_ptr = alloc_result.size; + } + printf("NtAllocateVirtualMemory status=0x%08x ptr=0x%08x size=%d\n", + (unsigned) status, (unsigned) alloc_result.addr, + alloc_result.size); + return status; } /* Round parameters to a page boundary */ @@ -1372,8 +1442,42 @@ if (!is_current_process( process )) { - ERR("Unsupported on other process\n"); - return STATUS_ACCESS_DENIED; + struct remote_op_params_vm_free free_params; + struct remote_op_result_vm_free free_result; + int result_size = sizeof(free_result); + typedef void (*deallocator_type)(LPVOID base, DWORD size); + static deallocator_type deallocator = NULL; + + if (!deallocator) { + HMODULE hkernel32; + UNICODE_STRING module; + ANSI_STRING function; + WCHAR kernel32W[] = {'k','e','r','n','e','l','3','2', + '.','d','l','l',0}; + RtlInitUnicodeString(&module, kernel32W); + RtlInitAnsiString(&function, "wine_remote_NtFreeVirtualMemory"); + + if (LdrGetDllHandle(0, 0, &module, &hkernel32) == STATUS_SUCCESS) + LdrGetProcedureAddress(hkernel32, &function, 0, + (void**)&deallocator); + else + return STATUS_DLL_NOT_FOUND; + printf("using deallocator in kernel32 at 0x%08x\n", + (unsigned) deallocator); + } + + free_params.addr = *addr_ptr; + free_params.size = size; + free_params.type = type; + free_params.deallocator = deallocator; + status = remote_op( process, REMOTE_OP_VM_FREE, + &free_params, sizeof(free_params), + &free_result, &result_size ); + if (!status) + *size_ptr = free_result.size; + printf("NtFreeVirtualMemory status=0x%08x size=%d\n", + (unsigned) status, (unsigned) free_result.size); + return status; } /* Fix the parameters */ Index: include/winternl.h =================================================================== RCS file: /home/wine/wine/include/winternl.h,v retrieving revision 1.181 diff -u -r1.181 winternl.h --- include/winternl.h 27 May 2006 11:37:02 -0000 1.181 +++ include/winternl.h 2 Jun 2006 05:43:17 -0000 @@ -2242,7 +2242,8 @@ extern NTSTATUS wine_nt_to_unix_file_name( const UNICODE_STRING *nameW, ANSI_STRING *unix_name_ret, UINT disposition, BOOLEAN check_case ); extern NTSTATUS wine_unix_to_nt_file_name( const ANSI_STRING *name, UNICODE_STRING *nt ); - +extern void wine_remote_NtAllocateVirtualMemory( LPVOID base, DWORD size, DWORD prot ); +extern void wine_remote_NtFreeVirtualMemory( LPVOID base, DWORD size ); /*********************************************************************** * Inline functions Index: include/wine/server_protocol.h =================================================================== RCS file: /home/wine/wine/include/wine/server_protocol.h,v retrieving revision 1.198 diff -u -r1.198 server_protocol.h --- include/wine/server_protocol.h 27 May 2006 11:37:01 -0000 1.198 +++ include/wine/server_protocol.h 2 Jun 2006 05:43:18 -0000 @@ -3727,6 +3727,132 @@ }; + +struct remote_operation_request +{ + struct request_header __header; + obj_handle_t handle; + int code; + /* VARARG(data,bytes); */ +}; +struct remote_operation_reply +{ + struct reply_header __header; + unsigned int status; + /* VARARG(data,bytes); */ +}; +enum remote_op_code +{ + REMOTE_OP_NEW_THREAD, + REMOTE_OP_VM_ALLOC, + REMOTE_OP_VM_FREE, + REMOTE_OP_VM_PROTECT, + REMOTE_OP_VM_QUERY, + REMOTE_OP_VM_MAP, + REMOTE_OP_VM_UNMAP, + REMOTE_OP_VM_FLUSH +}; + +struct remote_op_params_new_thread +{ + int suspend; + void *stack_addr; + unsigned int stack_reserve; + unsigned int stack_commit; + void *start; + void *param; +}; +struct remote_op_result_new_thread +{ + obj_handle_t handle; + thread_id_t tid; +}; + +struct remote_op_params_vm_alloc +{ + void *addr; + unsigned long zerobits; + unsigned long size; + unsigned long type; + unsigned long protect; + void *allocator; +}; +struct remote_op_result_vm_alloc +{ + void *addr; + unsigned long size; +}; + +struct remote_op_params_vm_free +{ + void *addr; + unsigned long size; + unsigned long type; + void *deallocator; +}; +struct remote_op_result_vm_free +{ + unsigned long size; +}; + +struct remote_op_params_vm_protect +{ + void *addr; + unsigned long size; + unsigned long new_prot; +}; +struct remote_op_result_vm_protect +{ + void *base; + unsigned long size; + unsigned long old_prot; +}; + +struct remote_op_params_vm_query +{ + void *addr; + int info_class; +}; + +struct remote_op_params_vm_map +{ + void *addr; + unsigned long zero_bits; + unsigned long commit_size; + unsigned long offset_low; + long offset_high; + unsigned long size; + int inherit; + unsigned long alloc_type; + unsigned long protect; +}; +struct remote_op_result_vm_map +{ + void *base; + unsigned long size; +}; + +struct remote_op_params_vm_flush +{ + void *addr; + unsigned long size; + unsigned long unknown; +}; +struct remote_op_result_vm_flush +{ + void *base; + unsigned long size; +}; + + +struct remote_op_request +{ + enum remote_op_code op_code; + thread_id_t originator; + int params_size; +}; + + enum request { REQ_new_process, @@ -3942,6 +4068,7 @@ REQ_create_symlink, REQ_open_symlink, REQ_query_symlink, + REQ_remote_operation, REQ_NB_REQUESTS }; @@ -4162,6 +4289,7 @@ struct create_symlink_request create_symlink_request; struct open_symlink_request open_symlink_request; struct query_symlink_request query_symlink_request; + struct remote_operation_request remote_operation_request; }; union generic_reply { @@ -4380,8 +4508,9 @@ struct create_symlink_reply create_symlink_reply; struct open_symlink_reply open_symlink_reply; struct query_symlink_reply query_symlink_reply; + struct remote_operation_reply remote_operation_reply; }; -#define SERVER_PROTOCOL_VERSION 234 +#define SERVER_PROTOCOL_VERSION 238 #endif /* __WINE_WINE_SERVER_PROTOCOL_H */ Index: server/process.c =================================================================== RCS file: /home/wine/wine/server/process.c,v retrieving revision 1.167 diff -u -r1.167 process.c --- server/process.c 23 May 2006 12:49:34 -0000 1.167 +++ server/process.c 2 Jun 2006 05:43:18 -0000 @@ -22,12 +22,15 @@ #include "wine/port.h" #include <assert.h> +#include <errno.h> #include <limits.h> +#include <linux/user.h> #include <signal.h> #include <string.h> #include <stdarg.h> #include <stdio.h> #include <stdlib.h> +#include <sys/ptrace.h> #include <sys/time.h> #ifdef HAVE_SYS_SOCKET_H # include <sys/socket.h> @@ -36,6 +39,7 @@ #ifdef HAVE_POLL_H #include <poll.h> #endif +#include <sys/wait.h> #include "ntstatus.h" #define WIN32_NO_STATUS @@ -1081,3 +1085,209 @@ release_object( process ); } } + +/* Accept parameters for remote operation and start it */ +DECL_HANDLER(remote_operation) +{ + int access; + struct process *process; + struct thread *thread; + + /* define required access rights */ + switch( req->code ) + { + case REMOTE_OP_NEW_THREAD: + access = PROCESS_CREATE_THREAD | PROCESS_QUERY_INFORMATION + | PROCESS_VM_OPERATION | PROCESS_VM_READ | PROCESS_VM_WRITE; + break; + case REMOTE_OP_VM_ALLOC: access = PROCESS_VM_OPERATION; break; + case REMOTE_OP_VM_FREE: access = PROCESS_VM_OPERATION; break; + case REMOTE_OP_VM_PROTECT: access = PROCESS_VM_OPERATION; break; + case REMOTE_OP_VM_QUERY: access = PROCESS_QUERY_INFORMATION; break; + case REMOTE_OP_VM_MAP: access = PROCESS_VM_OPERATION; break; + case REMOTE_OP_VM_UNMAP: access = PROCESS_VM_OPERATION; break; + case REMOTE_OP_VM_FLUSH: access = PROCESS_VM_OPERATION; break; /* FIXME: is access right? */ + default: + set_error( STATUS_INVALID_PARAMETER ); + return; + } + + switch( req->code ) + { + case REMOTE_OP_NEW_THREAD: + break; + case REMOTE_OP_VM_ALLOC: + { +#if defined(linux) && defined(__i386__) + int pid; + struct user_regs_struct oldregs, regs; + struct remote_op_params_vm_alloc *params; + struct remote_op_result_vm_alloc result; + + params = (struct remote_op_params_vm_alloc *) get_req_data(); + + /* get process object */ + if (!(process = get_process_from_handle( req->handle, access ))) + return; + + thread = get_process_first_thread(process); + pid = thread->unix_pid; + release_object(process); + + /*printf("attaching to process with pid %d\n", pid);*/ + if (ptrace(PTRACE_ATTACH, pid, NULL, NULL) == -1) + goto errorbeforeattach; + + wait(NULL); + if (ptrace(PTRACE_GETREGS, pid, NULL, &regs) == -1) + goto error; + + memcpy(&oldregs, &regs, sizeof(struct user_regs_struct)); + + regs.eip = (int) params->allocator; + + /* cdecl */ + if (ptrace(PTRACE_POKEDATA, pid, regs.esp-4, params->protect) == -1) + goto error; + if (ptrace(PTRACE_POKEDATA, pid, regs.esp-8, params->size) == -1) + goto error; + if (ptrace(PTRACE_POKEDATA, pid, regs.esp-12, params->addr) == -1) + goto error; + regs.esp -= 16; + + /* prevent the kernel from restarting the system call. + * see i386_linux_write_pc() in gdb/i386-linux-tdep.c of gdb */ + regs.orig_eax = -1; + + if (ptrace(PTRACE_SETREGS, pid, NULL, &regs) == -1) + goto error; + if (ptrace(PTRACE_CONT, pid, NULL, NULL) == -1) + goto error; + + wait(NULL); + if (ptrace(PTRACE_GETREGS, pid, NULL, &regs) == -1) + goto error; + + /* eax has pointer to allocated memory */ + /*printf("mem allocated in target process at 0x%08x\n", + (unsigned) regs.eax);*/ + if (ptrace(PTRACE_SETREGS, pid, NULL, &oldregs) == -1) + goto error; + if (ptrace(PTRACE_DETACH, pid, NULL, NULL) == -1) + goto error; + + reply->status = regs.eax ? STATUS_SUCCESS + : STATUS_INVALID_PARAMETER; + result.addr = (void *) regs.eax; + result.size = params->size; + + assert(sizeof(result) <= get_reply_max_size()); + set_reply_data(&result, sizeof(result)); + + break; + +error: + printf("error!\n"); + ptrace(PTRACE_DETACH, pid, NULL, NULL); + set_error( STATUS_INVALID_PARAMETER ); + break; + +errorbeforeattach: + printf("error before attach!\n"); + set_error( STATUS_INVALID_PARAMETER ); + break; +#else + set_error( STATUS_NOT_IMPLEMENTED ); +#endif + } + case REMOTE_OP_VM_FREE: + { +#if defined(linux) && defined(__i386__) + int pid; + struct user_regs_struct oldregs, regs; + struct remote_op_params_vm_free *params; + struct remote_op_result_vm_free result; + + params = (struct remote_op_params_vm_free *) get_req_data(); + + /* get process object */ + if (!(process = get_process_from_handle( req->handle, access ))) + return; + + thread = get_process_first_thread(process); + pid = thread->unix_pid; + release_object(process); + + /*printf("attaching to process with pid %d\n", pid);*/ + if (ptrace(PTRACE_ATTACH, pid, NULL, NULL) == -1) + goto freeerrorbeforeattach; + + wait(NULL); + if (ptrace(PTRACE_GETREGS, pid, NULL, &regs) == -1) + goto freeerror; + memcpy(&oldregs, &regs, sizeof(struct user_regs_struct)); + + regs.eip = (int) params->deallocator; + + /* cdecl */ + if (ptrace(PTRACE_POKEDATA, pid, regs.esp-4, params->size) == -1) + goto freeerror; + if (ptrace(PTRACE_POKEDATA, pid, regs.esp-8, params->addr) == -1) + goto freeerror; + regs.esp -= 12; + + /* prevent the kernel from restarting the system call. + * see i386_linux_write_pc() in gdb/i386-linux-tdep.c of gdb */ + regs.orig_eax = -1; + + if (ptrace(PTRACE_SETREGS, pid, NULL, &regs) == -1) + goto freeerror; + if (ptrace(PTRACE_CONT, pid, NULL, NULL) == -1) + goto freeerror; + + wait(NULL); + if (ptrace(PTRACE_GETREGS, pid, NULL, &regs) == -1) + goto freeerror; + + /* eax has return value */ + /*printf("munmap'd in target process, result=0x%08x\n", + (unsigned) regs.eax);*/ + if (ptrace(PTRACE_SETREGS, pid, NULL, &oldregs) == -1) + goto freeerror; + if (ptrace(PTRACE_DETACH, pid, NULL, NULL) == -1) + goto freeerror; + + reply->status = regs.eax ? STATUS_SUCCESS + : STATUS_INVALID_PARAMETER; + result.size = regs.eax; + + assert(sizeof(result) <= get_reply_max_size()); + set_reply_data(&result, sizeof(result)); + + break; + +freeerror: + printf("error!\n"); + ptrace(PTRACE_DETACH, pid, NULL, NULL); + set_error( STATUS_INVALID_PARAMETER ); + break; + +freeerrorbeforeattach: + printf("error before attach!\n"); + set_error( STATUS_INVALID_PARAMETER ); + break; +#else + set_error( STATUS_NOT_IMPLEMENTED ); +#endif + } + case REMOTE_OP_VM_PROTECT: + case REMOTE_OP_VM_QUERY: + case REMOTE_OP_VM_MAP: + case REMOTE_OP_VM_UNMAP: + case REMOTE_OP_VM_FLUSH: + break; + default: + set_error( STATUS_INVALID_PARAMETER ); + return; + } +} Index: server/protocol.def =================================================================== RCS file: /home/wine/wine/server/protocol.def,v retrieving revision 1.198 diff -u -r1.198 protocol.def --- server/protocol.def 27 May 2006 11:37:01 -0000 1.198 +++ server/protocol.def 2 Jun 2006 05:43:18 -0000 @@ -2615,3 +2615,124 @@ @REPLY VARARG(target_name,unicode_str); /* target name */ @END + + +/* Accept parameters for remote operation and start it */ +@REQ(remote_operation) + obj_handle_t handle; /* process handle */ + int code; /* operation code (see below) */ + VARARG(data,bytes); /* operation parameters (see below) */ +@REPLY + unsigned int status; /* operation status */ + VARARG(data,bytes); /* operation result data (see below) */ +@END +enum remote_op_code +{ + REMOTE_OP_NEW_THREAD, + REMOTE_OP_VM_ALLOC, + REMOTE_OP_VM_FREE, + REMOTE_OP_VM_PROTECT, + REMOTE_OP_VM_QUERY, + REMOTE_OP_VM_MAP, + REMOTE_OP_VM_UNMAP, + REMOTE_OP_VM_FLUSH +}; + +struct remote_op_params_new_thread +{ + int suspend; + void *stack_addr; + unsigned int stack_reserve; + unsigned int stack_commit; + void *start; + void *param; +}; +struct remote_op_result_new_thread +{ + obj_handle_t handle; + thread_id_t tid; +}; + +struct remote_op_params_vm_alloc +{ + void *addr; + unsigned long zerobits; + unsigned long size; + unsigned long type; + unsigned long protect; + void *allocator; +}; +struct remote_op_result_vm_alloc +{ + void *addr; + unsigned long size; +}; + +struct remote_op_params_vm_free +{ + void *addr; + unsigned long size; + unsigned long type; + void *deallocator; +}; +struct remote_op_result_vm_free +{ + unsigned long size; +}; + +struct remote_op_params_vm_protect +{ + void *addr; + unsigned long size; + unsigned long new_prot; +}; +struct remote_op_result_vm_protect +{ + void *base; + unsigned long size; + unsigned long old_prot; +}; + +struct remote_op_params_vm_query +{ + void *addr; + int info_class; +}; + +struct remote_op_params_vm_map +{ + void *addr; + unsigned long zero_bits; + unsigned long commit_size; + unsigned long offset_low; + long offset_high; + unsigned long size; + int inherit; + unsigned long alloc_type; + unsigned long protect; +}; +struct remote_op_result_vm_map +{ + void *base; + unsigned long size; +}; + +struct remote_op_params_vm_flush +{ + void *addr; + unsigned long size; + unsigned long unknown; +}; +struct remote_op_result_vm_flush +{ + void *base; + unsigned long size; +}; + +/* structure for marshalling remote operation requests */ +struct remote_op_request +{ + enum remote_op_code op_code; + thread_id_t originator; + int params_size; +}; Index: server/request.h =================================================================== RCS file: /home/wine/wine/server/request.h,v retrieving revision 1.132 diff -u -r1.132 request.h --- server/request.h 23 May 2006 12:49:34 -0000 1.132 +++ server/request.h 2 Jun 2006 05:43:18 -0000 @@ -323,6 +323,7 @@ DECL_HANDLER(create_symlink); DECL_HANDLER(open_symlink); DECL_HANDLER(query_symlink); +DECL_HANDLER(remote_operation); #ifdef WANT_REQUEST_HANDLERS @@ -542,6 +543,7 @@ (req_handler)req_create_symlink, (req_handler)req_open_symlink, (req_handler)req_query_symlink, + (req_handler)req_remote_operation, }; #endif /* WANT_REQUEST_HANDLERS */ Index: server/trace.c =================================================================== RCS file: /home/wine/wine/server/trace.c,v retrieving revision 1.310 diff -u -r1.310 trace.c --- server/trace.c 27 May 2006 11:37:01 -0000 1.310 +++ server/trace.c 2 Jun 2006 05:43:19 -0000 @@ -3263,6 +3263,21 @@ dump_varargs_unicode_str( cur_size ); } +static void dump_remote_operation_request( const struct remote_operation_request *req ) +{ + fprintf( stderr, " handle=%p,", req->handle ); + fprintf( stderr, " code=%d,", req->code ); + fprintf( stderr, " data=" ); + dump_varargs_bytes( cur_size ); +} + +static void dump_remote_operation_reply( const struct remote_operation_reply *req ) +{ + fprintf( stderr, " status=%08x,", req->status ); + fprintf( stderr, " data=" ); + dump_varargs_bytes( cur_size ); +} + static const dump_func req_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_new_process_request, (dump_func)dump_get_new_process_info_request, @@ -3477,6 +3492,7 @@ (dump_func)dump_create_symlink_request, (dump_func)dump_open_symlink_request, (dump_func)dump_query_symlink_request, + (dump_func)dump_remote_operation_request, }; static const dump_func reply_dumpers[REQ_NB_REQUESTS] = { @@ -3693,6 +3709,7 @@ (dump_func)dump_create_symlink_reply, (dump_func)dump_open_symlink_reply, (dump_func)dump_query_symlink_reply, + (dump_func)dump_remote_operation_reply, }; static const char * const req_names[REQ_NB_REQUESTS] = { @@ -3909,6 +3926,7 @@ "create_symlink", "open_symlink", "query_symlink", + "remote_operation", }; static const struct

6 15

re: MSI query tests
by Dan Kegel 03 Jun '06

03 Jun '06

EA Durbin wrote: > I've written some tests to debug the MSI Installer in wine, in which I have > tested various SQL statements against the America's Army installer database > and iterated through the queries. Great. Can you package up the tests as Wine conformance tests? That would be very useful; it might even provide the nudge needed for an MSI expert to fix the problem. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 5

Re: Added initial version of Wine OleView
by James Hawkins 03 Jun '06

03 Jun '06

On 6/3/06, Piotr Caban <piotr.caban(a)gmail.com> wrote: > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA The address has changed, and we recently did a sweep of the code base changing to the new address, so we'd like to keep the old address out. * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA +/* BINRES toolbar.bmp */ +IDB_TOOLBAR BITMAP DISCARDABLE toolbar.bmp +/* { +'42 4d 36 12 00 00 00 00 00 00 36 00 00 00 28 00' +'00 00 60 00 00 00 10 00 00 00 01 00 18 00 00 00' +'00 00 00 12 00 00 12 0b 00 00 12 0b 00 00 00 00' The patch is quite large by Wine's standards. You could reduce the size by taking out the bitmap for now and sending that separately; otherwise, it looks good and keep up the good work! -- James Hawkins

1 0

Re: Built-in iexplore
by Jonathan Ernst 03 Jun '06

03 Jun '06

Le vendredi 02 juin 2006 à 13:42 -0700, Brandon a écrit : > Daniel Skorka wrote: > > Oleksii Krykun <krikun(a)academy.kiev.ua.nospam> wrote: > > > $ wine iexplore > > > fixme:shdocvw:IEWinMain "" 1 > > > fixme:ole:CoResumeClassObjects stub > > > Could not load Mozilla. HTML rendering will be disabled. > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > Where is aq problem? > > > > Guess. > > I get the same thing even though I have mozilla installed. I'm using > wine in 64-bit linux, though, so that probably has something to do with > it. You don't need mozilla, but the Mozilla activex control : http://source.winehq.org/mozactivex I don't know why shdocvw doesn't prompt the user to install it in this case though (so I'm CCing wine-devel and Jacek to see if something has to be changed in nsembed.c). Best regards. Jonathan Ernst

1 0

Re: Re: Re: Wine 1.0 Tasks
by fenix＠club-internet.fr 03 Jun '06

03 Jun '06

----Message d'origine---- >Date: Fri, 2 Jun 2006 21:27:53 +0200 >De: Lionel Ulmer <lionel.ulmer(a)free.fr> >A: Dan Kegel <dank(a)kegel.com> >Copie à: wine-devel(a)winehq.org, >Sujet: Re: Re: Wine 1.0 Tasks > >On Tue, May 30, 2006 at 05:32:26PM -0700, Dan Kegel wrote: >> On 5/30/06, Scott Ritchie <scott(a)open-vote.org> wrote: >> > > It might be, but the heavy hitters I know of who have taken a look at >> > > it in detail have concluded that an X change really is needed.] >> > >> > Is this really a problem? Another version of X is due out in about 4 >> > months (probably the earliest we could possibly see Wine 1.0), so why >> > can't we just help write an X extension to tackle the bug? >> >> Not really a problem. It'll just take some time to trickle out to the world. >> We may also have to get Nvidia and ATI on board so they can implement >> the extension in their drivers. > >And for it to be taken, I guess we would need to not only write the >extension, but a 'reference implementation' (I would guess in DRI / Mesa) >and get it approved by the FD.o people. > >But ohsix's idea to use 'real' X windows 'overlaid' over the single Wine X >window would be the easiest idea to investigate (because it would not only >fixes this issue but also the mutiple windows with multiple pixel formats >problem that the former 'extension' solution does not). > i thought the same idea. But investigation modifications in x11drv to permit wine x pixmaps access for wined3d/opengl will fix many problems (but not hthe multiple pixel formats) Anyway we must move some code of wined3d and opengl32 (GLX code, etc...) to x11drv as it permit : - to handle this problems without hacks (ie many ExtEscape) - to help macos-X to port wined3d and opengl (all specific cost must be on x11drv/qwartwdrv) > Lionel (in 'not even time to read wine-devel' mode :-) ) > Well, at least i take time for it :) (and reviewing the flood of d3d patches) Waiting for you for coding :p Regards, Raphael

1 0

Re: How are we doing?
by Juan Lang 03 Jun '06

03 Jun '06

> Especially the code that is responded to as , I know it's a mess to > look at, but I didn't write it. Can you give us examples? Mostly Wine attempts to follow how Windows works, so MSDN provides a lot of the documentation. This is becoming increasingly true, with kernel32 being implemented on top of ntdll. There are bits that are hard to understand, certainly, and some areas could use some comments. Unfortunately sometimes the lack of comments demonstrates a lack of understanding, but the code works for someone, somewhere, so we're mostly afraid to touch it until some brave soul comes along. For example, SHFileOperation was a complete mess until James fixed it up. Another example is user32. It's impossible to document (in English) what it's supposed to be doing. For this, and many other cases, a good regression test suite is the best documentation: it tells you what's expected, so if you go mucking around you have checks against introducing regressions. I know you've been working with msi lately. The fact that you've figured out where the problem is indicates to me that it's adequately commented, even if the learning curve is still a bit steep. Patches to add API comments for the Wine API guide (http://source.winehq.org/WineAPI/ ) are always welcome. Patches to document dodgy bits of code may or may not be accepted, but regression tests to justify dodgy bits of code are happily accepted too. http://source.winehq.org/WineAPI/ --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 3

Quartz driver
by Emmanuel Maillard 03 Jun '06

03 Jun '06

Hi all, Quartz driver is up to date on Darwine CVS. Winemine is playable on both PPC and x86 but it look fine only on PPC, x86 driver suffer strange rendering bugs. See wiki for building the driver : http://wiki.opendarwin.org/ index.php/Darwine:quartzdrv I will update wiki soon with issues and todo for Quartz driver. Cheers Emmanuel

3 2

Re: Re: Wine 1.0 Tasks
by fenix＠club-internet.fr 02 Jun '06

02 Jun '06

Hi, >> (Note the #3902 should be renamed as 'DIB Engine rewrite' > >Agreed; done. http://bugs.winehq.org/show_bug.cgi?id=3902 :) >> and i don't think is mandatory for 1.0) > >Probably right. Let's create the next milestone after 1.0, say 1.1, and start >retargeting bugs we don't plan to fix for 1.0. (That's what GCC does; >some bugs they retarget early, some just before the release.) > >> But i think we must fix users most hated bugs as: >> - dsound deadlocks/craps >> - openGL problems (multi contexts, fb/visual configs) >> - lotus problems > >The OpenGL child window bug, >http://bugs.winehq.org/show_bug.cgi?id=2398 >probably won't be fixed for 1.0 because it requires >an X server change. No it must be doable without X changes (But X additions as GLX_EXT_texture_from_pixmap will help a lot). Only problem is to find time to fix it (as lionel, i have no time for now). Anyway i having a simple and downloadable application to reproduce this problem (not lightwave) must help. The only parts who really needs X change are for: - glShareList: sharing fb/visual config between exitings GLX contexts - dinput mouse management >I'm not sure lotus notes problems should block 1.0, as IBM has a native >Linux client now, but if someone wants to fix them (especially the ones >in usp10.dll netapi32.dll, that would be great. agree :) >> Note: it will be interesting to add user votes to wine-bugs (ala kde) to >> better see user needs. > >There are already user votes in bugzilla, that should suffice. >- Dan Oups i never seen it :) Regards, Raphael

9 11

Re: Missing LeaveCriticalSection on error paths (found by Smatch).
by Michael Stefaniuc 02 Jun '06

02 Jun '06

Michael Stefaniuc wrote: > can somebody more familiar with this code confirm that on the error > paths the CriticalSection should be released? I'm not sure about it as > the function is supposed to keep the lock held when exiting without > error; there is a d3ddevice_unlock_update() function that releases the > lock. Asked Lionel Ulmer on irc and the patch is correct. But according to Stefan Dösinger that code will be replaced by his code "in the next couple of days". bye michael > --- > > dlls/ddraw/device_opengl.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > dd0b9b20d26984ae408c1a7727323a08d44e0d95 > diff --git a/dlls/ddraw/device_opengl.c b/dlls/ddraw/device_opengl.c > index d19996e..4c663a6 100644 > --- a/dlls/ddraw/device_opengl.c > +++ b/dlls/ddraw/device_opengl.c > @@ -3775,10 +3775,12 @@ static void d3ddevice_lock_update(IDirec > buffer_color = GL_BGRA; > } else { > ERR(" unsupported pixel format at device locking.\n"); > + LeaveCriticalSection(&(d3d_dev->crit)); > return; > } > } else { > ERR(" unsupported pixel format at device locking - alpha on frame buffer.\n"); > + LeaveCriticalSection(&(d3d_dev->crit)); > return; > } > > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: test case for MSI problem in America's Army installer
by Dan Kegel 02 Jun '06

02 Jun '06

I think you can just compile and run it with visual C++ as a standalone app, with the right commandline options to the compiler. Let's see: try the instructions here: http://www.winehq.com/hypermail/wine-devel/2005/05/0865.html You can also build with the wine build system and then run the executable with a single commandline option giving the name of the test to run. Better ask on wine-devel, I have to run. On 6/2/06, EA Durbin <ead1234(a)hotmail.com> wrote: > How does one use the test application in the msi/tests folder? > > I know you run it with wine, but without looking through all of the code in > the application to determine this could you maybe advise me what it expects > for arguments, or how to work with it? > > Do you pass it an misdatabase, and a DB argument, or how does this utility > work? > > I don't usually hack in C, but im somewhat capable. I could write a mean > Hello World Application back in college. My day usually consists of parsing > data with PERL, but that doesn't mean I can't pick up C again. > > I'd appreciate it if you focused some energy on it, but I would also like to > know how it works so I can contribute in the future. > > > >From: "Dan Kegel" <dank(a)kegel.com> > >To: wine-devel <wine-devel(a)winehq.org> > >Subject: re: test case for MSI problem in America's Army installer > >Date: Fri, 2 Jun 2006 07:06:30 -0700 > > > >Mike M. wrote: > >>>>[America's Army install crashes, see > >>>>http://bugs.winehq.org/show_bug.cgi?id=5139 ] > >>> > >>>This is as close as I will be able to come to including a test case, as > >>>this is how I obtained my results. > >> > >>If you want me to fix the problem, please submit a regression test to > >>wine-patches with a todo_wine{} around the code that doesn't work. > > > >If that's too hard for EA (he admits he's not a C hacker), maybe > >I can focus some energy on it... > >- Dan > > > > > > > -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

winedbg: newbie question (sorry...)
by Molle Bestefich 02 Jun '06

02 Jun '06

Hello Carsten Niehaus (cniehaus(a)gmx.de) over on wine-users gets a page fault when he tries to print with this app: http://www.learn-line.nrw.de/angebote/gefahrstoffdb/Gefahrstoffe.zip He's posted a backtrace: > fixme:commdlg:PRINTDLG_SetUpPrinterListComboA Can't find '(null)' in printer list so trying to find default > wine: Unhandled page fault on write access to 0x0000002e at address 0x7f6a2540 (thread 0009), starting debugger... > Backtrace: > =>1 0x7f6a2540 PRINTDLG_WMCommandA+0x619 in comdlg32 (0x7f6a2540) > 2 0x7f6a2fb6 in comdlg32 (+0x32fb6) (0x7f6a2fb6) [snip!] > 0x7f6a2540 PRINTDLG_WMCommandA+0x619 in comdlg32: movw %ax,0x2e(%edx) I'm slightly cli-debugger-clueless, so could one of you guys please tell me how to convert this: PRINTDLG_WMCommandA+0x619 into a proper line number reference to the source file?

2 1

RFC - wine-macos mailing list
by Jeremy White 02 Jun '06

02 Jun '06

Hi Folks, I'd like to pull one thread out of a previous discussion and ask for comments on it specifically; I think other issues in the thread detracted from what I think is a useful discussion. Specifically, should we create a 'wine-macos' mailing list? I think the idea would be that it would be a mailing list for Mac users and developers to worry about Mac specific issues. The benefit is that it would be more inviting to Mac users and it would allow Mac folks to hone in on Mac specific topics. The goal is still that Mac Wine developers would come join us on wine-devel and #winehackers, so it would likely end up primarily as a user forum. I guess the downside is that it could be confusing, and you can argue that we haven't created any platform specific lists prior to this. My driving concern is that I think we need to welcome the Mac community to the Wine Project and do all that we can to enable the Mac developers and users to use mainstream Wine resources. I don't think anyone wants www.winehq.org to be perceived as a 'Linux only' environment. (Although I do see that www.winehq.org doesn't list Mac OS X...hmmm). Some Mac folks have told me privately that having a Mac specific mailing list on www.winehq.org would make it more inviting to them. Perhaps that is reason alone to make the change. What do others think? Cheers, Jeremy

11 11

Re: comctl32: Fix loading string from resources (take 2)
by Dmitry Timoshkov 02 Jun '06

02 Jun '06

"Thomas Weidenmueller" <wine-patches(a)reactsoft.com> wrote: > LoadString() cannot be used to measure the length of a string resource. > It will not return the length of the string if no buffer is provided, > instead it will return 0! This patch fixes the broken property sheet code. It would be appropriate to provide a test case showing correct LoadString behaviour and fix LoadString in Wine if it confirms the statement above since Wine clearly returns the size of the string resource if the passed buffer is NULL. -- Dmitry.

1 0

Wine 1.0 tasks: installers
by Dan Kegel 02 Jun '06

02 Jun '06

James Hawkins and I think we should come up with a list of installers that need to run before we release Wine 1.0. Looking at http://www.winehq.org/pipermail/wine-devel/2006-March/045634.html and http://bugs.winehq.org/buglist.cgi?short_desc_type=allwordssubstr&short_des… I made a list biased towards freely downloadable apps, programming tools, things Munich wants, stuff that has been passionately discussed of late (e.g. America's Army), educational apps, and anything that smacks of long-unfinished business. Here's what I ended up with: http://bugs.winehq.org/show_bug.cgi?id=3590 ActiveState python msi (see 5237?) http://bugs.winehq.org/show_bug.cgi?id=3972 .NET framework 2.0 http://bugs.winehq.org/show_bug.cgi?id=4227 QuickTest Pro http://bugs.winehq.org/show_bug.cgi?id=4280 J2SE 1.5 http://bugs.winehq.org/show_bug.cgi?id=4492 MinGW installer stalls http://bugs.winehq.org/show_bug.cgi?id=4569 Oregon Trail 5 wants DX8 http://bugs.winehq.org/show_bug.cgi?id=4802 Oracle client library (munich) http://bugs.winehq.org/show_bug.cgi?id=4700 spss demo (munich) http://bugs.winehq.org/show_bug.cgi?id=4860 java plugin http://bugs.winehq.org/show_bug.cgi?id=5296 Kidspiration install window hidden? http://bugs.winehq.org/show_bug.cgi?id=5237 wsh (and ActiveState perl msi) http://bugs.winehq.org/show_bug.cgi?id=5275 google earth http://bugs.winehq.org/show_bug.cgi?id=5325 art2kmin.exe (munich, UK EPBD-NCM) http://bugs.winehq.org/show_bug.cgi?id=5322 VB6 / VC++6 installers fail early Some of those might already be fixed, hopefull we can just close out a couple. And a couple might be too hard for 1.0 (.net, say), it's ok to defer them to 1.1 later if we have to. Ideally we'd also have cxtest scripts for all of these installers, so Codeweavers can use them to validate new releases. How's that sound? - Dan

2 2

RFC - device notifications idea
by Damjan Jovanovic 02 Jun '06

02 Jun '06

I was disappointed to see that "dynamic drive configuration" (http://www.winehq.org/?issue=313#Dynamic%20Drive%20Configuration) amounts to a few HAL functions in wine's explorer. Windows has been using device notifications for at least 11 years now (since Windows 95), and neither wine nor ReactOS have even begun this feature. I would be interested in implementing it by using dbus/HAL in wineserver, and translating HAL device notifications into equivalent WM_DEVICECHANGE messages which then get broadcast to all windows. Is any work being done in this area? If not, would this work? Are long-running functions requiring I/O (hal_device_get_property_...()) allowed in wineserver (which seems to be event-driven)? Any other comments? Thank you Damjan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Wine VM86 exception handling bug?
by Andrey Turkin 02 Jun '06

02 Jun '06

Hi all! I think i found a bug in VM86 exception handling (must be regression, i guess). Short Wine function flow: On privileged instruction __wine_enter_vm86 saves vm86 registers in CONTEXT and starts raise_segv_exception. raise_segv_exception routes exception to the INSTR_EmulateInstruction and then to winedos I/O emulator, then tries to use NtSetContextThread(GetCurrentThread(), CONTEXT). NtSetContextThread obviously fails because of VM86 segment values in CONTEXT. My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86 would restore vm86 registers correctly. I think i know what is the problem; however, I lack experience to fix it myself :) I need help; any hints would be appreciated.

1 0

re: test case for MSI problem in America's Army installer
by Dan Kegel 02 Jun '06

02 Jun '06

Mike M. wrote: >>> [America's Army install crashes, see >>> http://bugs.winehq.org/show_bug.cgi?id=5139 ] >> >> This is as close as I will be able to come to including a test case, as >> this is how I obtained my results. > > If you want me to fix the problem, please submit a regression test to > wine-patches with a todo_wine{} around the code that doesn't work. If that's too hard for EA (he admits he's not a C hacker), maybe I can focus some energy on it... - Dan

1 0

Re: winspool: [3/3] Add GetPrintProcessorDirectoryA
by Alexandre Julliard 02 Jun '06

02 Jun '06

Detlef Riekenberg <wine.dev(a)web.de> writes: > + if (ret) { > + needed = WideCharToMultiByte( CP_ACP, 0, InfoW, -1, (LPSTR)Info, cbBuf, NULL, NULL); > + if (pcbNeeded) *pcbNeeded = needed; > + ret = (needed > cbBuf) ? FALSE : TRUE; This check is wrong, WideCharToMultiByte will return 0 if the buffer is too small. -- Alexandre Julliard julliard(a)winehq.org

2 1

intermediate fontconfig 2.3.94 problems
by Marcus Meissner 02 Jun '06

02 Jun '06

Hi, SUSE Linux 10.1 contains fontconfig 2.3.94, which changed the FcPatternGetString() function from return path names to return only the filenames. We received this bugreport: https://bugzilla.novell.com/show_bug.cgi?id=179457 However, Bernd Rosenkraenzer reported this problem already and the change was reverted for fontconfig 2.3.95. Its just that it might be broken only in SL 10.1 (perhaps fixed with online update, still in discussion). So this is just a heads-up, if more bugreports should appear. Ciao, Marcus

1 0

Re: user32, x11drv: patch to send WM_SIZE at window state change (bug 4964)
by Alexandre Julliard 02 Jun '06

02 Jun '06

Juris Smotrovs <juris.smotrovs(a)sets.lv> writes: > @@ -1435,9 +1435,19 @@ > "%s: in msg 0x%04x expecting lParam 0x%lx got 0x%lx\n", > context, expected->message, expected->lParam, actual->lParam); > } > - ok_( file, line) ((expected->flags & defwinproc) == (actual->flags & defwinproc), > - "%s: the msg 0x%04x should %shave been sent by DefWindowProc\n", > - context, expected->message, (expected->flags & defwinproc) ? "" : "NOT "); > + if ((expected->flags & defwinproc) != (actual->flags & defwinproc) && todo) > + { > + todo_wine { > + failcount ++; > + ok_( file, line) (FALSE, > + "%s: in msg 0x%04x expecting lParam 0x%lx got 0x%lx\n", > + context, expected->message, expected->lParam, actual->lParam); > + } > + } > + else > + ok_( file, line) ((expected->flags & defwinproc) == (actual->flags & defwinproc), > + "%s: the msg 0x%04x should %shave been sent by DefWindowProc\n", > + context, expected->message, (expected->flags & defwinproc) ? "" : "NOT "); The problem is that this will cause tests that currently succeed to be turned back into todos. It would be better to do the changes in a way that doesn't break existing tests. -- Alexandre Julliard julliard(a)winehq.org

2 2

Test Case
by EA Durbin 02 Jun '06

02 Jun '06

This is as close as I will be able to come to including a test case, as this is how I obtained my results. Here is my code, and the resulting logs. Here are some patches I used, just a quick hack of the existing wine code, to run a query and iterate through the results. As you'll see in the enclosed results, this query is returning the results of Sequence < 8 even though the query called for Sequence >= 8. trace:msi:msiobj_release 0x7efcad60 trace:msi:msiobj_release object 0x7efcad60 destroyed trace:msi:MSI_ViewFetch 0x7efda640 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 2 trace:msi:msiobj_release 0x7efcad60 trace:msi:msiobj_release object 0x7efcad60 destroyed trace:msi:MSI_ViewFetch 0x7efda640 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 1 trace:msi:msiobj_release 0x7efcad60 trace:msi:msiobj_release object 0x7efcad60 destroyed trace:msi:MSI_ViewFetch 0x7efda640 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 3 trace:msi:msiobj_release 0x7efcad60 trace:msi:msiobj_release object 0x7efcad60 destroyed trace:msi:MSI_ViewFetch 0x7efda640 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 5 trace:msi:msiobj_release 0x7efcad60 trace:msi:msiobj_release object 0x7efcad60 destroyed trace:msi:MSI_ViewFetch 0x7efda640 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 4 f8 And when I queried the Media Table WHERE LastSequence >= 20, it returns LastSequence < 20, trace:msi:ACTION_InstallFiles DEBUGGING SELECT * FROM Media WHERE LastSequence >= 20 trace:msi:MSI_ViewExecute 0x7efde0f0 (nil) trace:msi:MSI_ViewFetch 0x7efde0f0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest Last Sequence: 6 trace:msi:ITERATE_QueryTest Disk Id: 1 trace:msi:ITERATE_QueryTest CAB: L"Disk1.cab" trace:msi:msiobj_release 0x7efe0900 trace:msi:msiobj_release object 0x7efe0900 destroyed trace:msi:MSI_ViewFetch 0x7efde0f0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest Last Sequence: 14 trace:msi:ITERATE_QueryTest Disk Id: 2 hence its broken. And this query is the same, regardless of the platform WHERE VALUE >= test condition, is WHERE value is Greater than or equal test condition, on any SQL implementation, MSI, mysql, postgre, ORACLE, etc. etc., wine's implementation is broken.

2 1

MSI
by EA Durbin 02 Jun '06

02 Jun '06

My first analysis was incorrect, its not the compound statement that is broken, but the existing implementation of the WHERE statement in MSI SQL is broken. I've ran several tests to confirm this. I don't know how this can be replicated in windows, as the problem lies within the existing implementation of wine MSI SQL, the WHERE clause is returning the wrong values. SELECT * FROM TABLE WHERE Tablevalue >= testvalue should return greater than or equal to, regardless of what platform you run that query on, and it returns the wrong value in wines msi implementation. Further down in where.txt, which is the result of the WHERE query I saw the QUERY WHERE LastSequence > 1, was returning a 0 at disk 22, which is wrong. The ORDER BY QUERY works fine. The WHERE STATEMENT in the existing wine code is broken. I've ran several other tests, on multiple tables to verify this. My code I used for testing is included below if you would like to have a look at it. I queried the File table WHERE Sequence >= 8, and in the retuned values the SQL statement returned Sequences 1 to 7, which are less than 8, so the SQL statement isn't functioning properly. Example 1. I changed the sql statement in my installer to read the following at ready_media_for_file. SELECT * FROM Media WHERE LastSequence > %i , and it returns the 1st DiskId, with a LastSequence of 6, even after the LastSequence exceeds 6. The WHERE STATEMENT is broken in msi SQL. The installation of the first 6 .dlls works nicely, they are in my C: folder. trace:msi:ACTION_InstallFiles file paths L"C:\\windows\\temp\\FL_mfc71_dll_1_____X86.3643236F_FC70_11D3_A536_0090278A1BB8" to L"C:\\mfc71.dll" trace:msi:ACTION_InstallFiles Pass 2: L"_a8c1851f3c994e35b6e28a65f4793745" trace:msi:MSI_DatabaseOpenViewW L"SELECT * FROM `Media` WHERE `LastSequence` >=7" 0x7fb8f794 trace:msi:msiobj_addref 0x7fd53fd8 trace:msi:msiobj_addref 0x7fd53fd8 trace:msi:MSI_ParseSQL Parse returned 0 trace:msi:ready_media_for_file LastSequence 6 trace:msi:ready_media_for_file Source is CAB L"Disk1.cab" Example 2: - query from the File table, also returns the wrong values I also tried querying another table to ensure it is the WHERE statement and not a table specific problem. here is the result of the SELECT * FROM File WHERE Sequence >= 8 Though this query doesn't return in sequential order like from the Media table, I did find numbers lower than 8 in the results trace:msi:MSI_DatabaseOpenViewW L"SELECT * FROM `File` WHERE `Sequence` >= 8" 0x7fb8fa38 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 7 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 2 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 1 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 3 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 5 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 4 From: "EA Durbin" <ead1234(a)hotmail.com> To: dank(a)kegel.com CC: wine-devel(a)winehq.org Subject: Re: MSI query tests Date: Thu, 01 Jun 2006 21:51:20 -0500 1. The conformance test suite must run on Windows. This is necessary to provide a reasonable way to verify its accuracy. Furthermore the tests must pass successfully on all Windows platforms (tests not relevant to a given platform should be skipped). I don't know how I would run this on windows. I edited the wine code itself and queried tables in the MSI database to troubleshoot the behavior of the installer code. Then i retrieved the pertainent values from the results, as in the case of the file table i retrieved the sequence value being returned by the query http://msdn.microsoft.com/library/default.asp?url=/library/en-us/msi/setup/… Here is the code i used to iterate queries MSIQUERY * view; static const WCHAR ExecSeqQuery[] = {'S','E','L','E','C','T',' ','*',' ','F','R','O','M',' ', '`','F','i','l','e','`',' ','W','H','E','R','E',' ','`','S','e','q','u','e','n','c','e','`',' ','>','=',' ','8',0}; rc = MSI_DatabaseOpenViewW( package->db, ExecSeqQuery, &view ); if ( rc != ERROR_SUCCESS ) return ERROR_SUCCESS; TRACE( "DEBUGGING SELECT * FROM File WHERE Sequence >= 8 \n" ); rc = MSI_IterateRecords( view, NULL, ITERATE_QueryTest, package ); return rc; static UINT ITERATE_QueryTest( MSIRECORD *row, LPVOID param ) { MSIPACKAGE *package = (MSIPACKAGE*)param; int fileSequence; fileSequence = MSI_RecordGetInteger( row, 8 ); TRACE( "File Sequence: %i \n", fileSequence ); return ERROR_SUCCESS; } and the Media table i returned the DiskId, cabinet, and LastSequence values from the results http://msdn.microsoft.com/library/en-us/msi/setup/media_table.asp?frame=true static UINT ITERATE_QueryTest( MSIRECORD *row, LPVOID param ) { MSIPACKAGE *package = (MSIPACKAGE*)param; int lastSequence, DiskId; LPWSTR cab; lastSequence = MSI_RecordGetInteger( row, 2 ); DiskId = MSI_RecordGetInteger( row, 1); cab = MSI_RecordGetString( row, 4) TRACE( " Last Sequence: %u \n", lastSequence ); TRACE( " CAB %s \n", debugstr_w( cab ) ); TRACE( " Disk ID %u \n", DiskId ); return ERROR_SUCCESS; } From: "Dan Kegel" <dank(a)kegel.com> To: "EA Durbin" <ead1234(a)hotmail.com> CC: wine-devel(a)winehq.org Subject: Re: MSI query tests Date: Thu, 1 Jun 2006 19:34:12 -0700 On 6/1/06, EA Durbin <ead1234(a)hotmail.com> wrote: >Great. Can you package up the tests as Wine conformance tests? I'm new to wine, how do I accomplish this? http://winehq.org/site/docs/winedev-guide/testing has an introduction to the subject. - Dan # From: Mike McCormack <mike(a)codeweavers.com> To: EA Durbin <ead1234(a)hotmail.com> CC: wine-devel(a)winehq.org Subject: Re: MSI Query tests Date: Fri, 02 Jun 2006 12:19:59 +0900 EA Durbin wrote: SELECT * FROM `Media` WHERE `LastSequence` > 1 that it returns the SQL statement correctly. Then in orderby.txt i query SELECT * FROM `Media` ORDER BY `LastSequence` and it returns the results as expected. Then in compoundsql.txt I query SELECT * FROM `Media` WHERE `LastSequence` > 1 ORDER BY `LastSequence`, which is just as the statement appears in InstallFiles(). In this query it ignores the WHERE CLAUSE and uses what is to the far right , the ORDER BY LastSequence statement, which first grabs the LastSequence of 0. Thanks for the analysis. Do you think you could add a test case to dlls/msi/tests/db.c that shows the correct behaviour of the above query on Windows for me? If you can do that, I'll have a go at fixing it... Mike

1 0

MSI Query tests
by EA Durbin 02 Jun '06

02 Jun '06

I've written some tests to debug the MSI Installer in wine, in which I have tested various SQL statements against the America's Army installer database and iterated through the queries. Here are the results. It appears that in my attachment, where.txt, which is a standard where sql statement, SELECT * FROM `Media` WHERE `LastSequence` > 1 that it returns the SQL statement correctly. Then in orderby.txt i query SELECT * FROM `Media` ORDER BY `LastSequence` and it returns the results as expected. Then in compoundsql.txt I query SELECT * FROM `Media` WHERE `LastSequence` > 1 ORDER BY `LastSequence`, which is just as the statement appears in InstallFiles(). In this query it ignores the WHERE CLAUSE and uses what is to the far right , the ORDER BY LastSequence statement, which first grabs the LastSequence of 0. In conclusion, the actual problem in InstallFiles() is the inability to handle the compound SQL statement with a WHERE and an ORDER BY together. Unfortunately I don't understand wine's SQL underpinnings enough to where I can implement a solution. I've looked it over and it appears somewhat cryptic, so I will need some help.

2 3

Lineage 2 crash
by Andres de Barbara 02 Jun '06

02 Jun '06

Hi. I triying to run this game in my linux box but it crash. runing : WINEDEBUG=+d3d,+ddraw,warn+all,+seh,+d3d_draw,trace+d3d_shader,trace+d3d_draw,trace+opengl winedbg l2.exe this is the backtrace First chance exception: page fault on read access to 0x6814d0c8 in 32-bit code (0x7e6f6dab). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7e6f6dab ESP:7fb956cc EBP:7fb95784 EFLAGS:00210202( - 00 - -RI1) EAX:6814d0c8 EBX:7e74cdcc ECX:7fdfdf38 EDX:681e002c ESI:7fdfdf38 EDI:681e002c Stack dump: 0x7fb956cc: 00000000 00000000 00000000 000000ff 0x7fb956dc: 7fb95714 b7f034f4 00000036 7ff8aa06 0x7fb956ec: 00000002 7ffdf0e8 00000036 7fb9579c 0x7fb956fc: 7ffdf0e8 7ffdece0 0000000e 7ffd5524 0x7fb9570c: 00000028 7e73fed7 7fb95744 7ff8aa9b 0x7fb9571c: 7e73fed7 7fb9579c 7e74d6c1 7e73ec3b Backtrace: =>1 0x7e6f6dab drawStridedSlow+0xdb(glPrimType=0x4, idxData=0x70d63b50, idxSize=0x2, minIndex=0x908, startIdx=0x0) [/home/adebarbara/wine/wine- 0.9.14~winehq1~ubuntu~6.06/dlls/wined3d/drawprim.c:1344] in wined3d (0x7e6f6dab) 2 0x7e6f79d5 drawPrimitiveDrawStrided+0x471(iface=0x70d00020, useVertexShaderFunction=0x0, usePixelShaderFunction=0x0, useHW=0x0, dataLocations=0x7fdfdf38, numberOfvertices=0x50f3, numberOfIndicies=0x8820, glPrimType=0x4, idxData=0x70d63b50, idxSize=0x2, minIndex=0x908, StartIdx=0x0) [/home/adebarbara/wine/wine- 0.9.14~winehq1~ubuntu~6.06/dlls/wined3d/drawprim.c:1914] in wined3d (0x7e6f79d5) 3 0x7e6fa8bb drawPrimitive+0x587(iface=0x70d00020, PrimitiveType=0x4, NumPrimitives=0x2d60, StartVertexIndex=0x0, numberOfVertices=0x50f3, StartIdx=0x0, idxSize=0x2, idxData=0x70d63b50, minIndex=0x908, DrawPrimStrideData=0x0) [/home/adebarbara/wine/wine- 0.9.14~winehq1~ubuntu~6.06/dlls/wined3d/drawprim.c:2164] in wined3d (0x7e6fa8bb) 4 0x7e6e1c0b IWineD3DDeviceImpl_DrawIndexedPrimitive+0x98(iface=0x70d00020, PrimitiveType=0x4, baseVIndex=0x0, minIndex=0x908, NumVertices=0x50f3, startIndex=0x0, primCount=0x2d60) [/home/adebarbara/wine/wine- 0.9.14~winehq1~ubuntu~6.06/dlls/wined3d/device.c:5609] in wined3d (0x7e6e1c0b) 5 0x7f185490 IDirect3DDevice8Impl_DrawIndexedPrimitive+0x88 in d3d8 (0x7f185490) 6 0x7ca79075 in d3ddrv (+0x19075) (0x7ca79075) 7 0x783210f5 in engine (+0x3410f5) (0x783210f5) 8 0x7828dc59 in engine (+0x2adc59) (0x7828dc59) 9 0x78260b92 in engine (+0x280b92) (0x78260b92) 10 0x7826345a in engine (+0x28345a) (0x7826345a) 11 0x781aebe6 in engine (+0x1cebe6) (0x781aebe6) 12 0x111049d4 in windrv (+0x49d4) (0x111049d4) 13 0x1110238e in windrv (+0x238e) (0x1110238e) 14 0x781b5fee in engine (+0x1d5fee) (0x781b5fee) 15 0x1090cb24 in l2 (+0xcb24) (0x1090cb24) 16 0x1090d9c2 in l2 (+0xd9c2) (0x1090d9c2) 17 0x10912611 in l2 (+0x12611) (0x10912611) 18 0x10919507 in l2 (+0x19507) (0x10919507) 19 0x7fc4b7cf in kernel32 (+0x4b7cf) (0x7fc4b7cf) 20 0xb7f222e3 wine_switch_to_stack+0x17 in libwine.so.1 (0xb7f222e3) 0x7e6f6dab drawStridedSlow+0xdb [/home/adebarbara/wine/wine- 0.9.14~winehq1~ubuntu~6.06/dlls/wined3d/drawprim.c:1344] in wined3d: flds 0x0(%eax) 1344 nx = ptrToCoords[0]; I attach the log. Could someone help me with this? Thack you in advance.

1 0

MSI SQL
by EA Durbin 02 Jun '06

02 Jun '06

I changed the sql statement in my installer to read the following. SELECT * FROM Media WHERE LastSequence > %i , and it returns the 1st DiskId, with a LastSequence of 6, even after the LastSequence exceeds 6. The WHERE STATEMENT is broken in msi SQL. The installation of the first 6 .dlls works nicely, they are in my C: folder. trace:msi:ACTION_InstallFiles file paths L"C:\\windows\\temp\\FL_mfc71_dll_1_____X86.3643236F_FC70_11D3_A536_0090278A1BB8" to L"C:\\mfc71.dll" trace:msi:ACTION_InstallFiles Pass 2: L"_a8c1851f3c994e35b6e28a65f4793745" trace:msi:MSI_DatabaseOpenViewW L"SELECT * FROM `Media` WHERE `LastSequence` >=7" 0x7fb8f794 trace:msi:msiobj_addref 0x7fd53fd8 trace:msi:msiobj_addref 0x7fd53fd8 trace:msi:MSI_ParseSQL Parse returned 0 trace:msi:ready_media_for_file LastSequence 6 trace:msi:ready_media_for_file Source is CAB L"Disk1.cab" I also tried querying another table to ensure it is the WHERE statement and not a table specific problem. here is the result of the SELECT * FROM File WHERE Sequence >= 8 Though this query doesn't return in sequential order like from the Media table, I did find numbers lower than 8 in the results trace:msi:MSI_DatabaseOpenViewW L"SELECT * FROM `File` WHERE `Sequence` >= 8" 0x7fb8fa38 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 7 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 2 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 1 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 3 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 5 trace:msi:msiobj_release 0x7efded70 trace:msi:msiobj_release object 0x7efded70 destroyed trace:msi:MSI_ViewFetch 0x7efdbca0 0x7fb8f9f8 trace:msi:ITERATE_QueryTest File Sequence: 4 Looks like the WHERE statement is broken in SQL.

1 0

Re: winspool/tests: Use 0xdeadbeef as magic Value
by Jeff Latimer 01 Jun '06

01 Jun '06

A minor spelling mistake, deaddeef instread of deadbeef. Jeff Detlef Riekenberg wrote: >I was using 0x00dead00 before, but Dmitry suggested 0xdeadbeef, as this > > > >-#define MAGIC_DEAD 0x00dead00 >+#define MAGIC_DEAD 0xdeaddeef > >

2 1

Re: wineprefix: Create a cdrom drive if it exists at /media/cdrom
by Mike Hearn 01 Jun '06

01 Jun '06

The location CD drives are mounted changes between systems, this patch is essentially specific to yours. Wine already supports HAL, which should solve this in a more correct manner (though we have reports it doesn't work for some games!), so how comes that's not enough? thanks -mike

4 4

wine problems on a 64bit system
by Pavel Troller 01 Jun '06

01 Jun '06

Hi! As some of you know, I'm experimenting with my new 64bit systems. I've found that there are problems running a lot of applications, which normally run on a 32bit system. A typical example is IL2 Sturmovik Forgotten Battles game. On a 32bit system, with the latest wine CVS (even compiled on a 64bit system) it runs flawlessly. On a 64bit system, it just prints fixme:seh:check_no_exec No exec fault triggered at 0x6d4d08b0, enabling work-around but the workaround seems to be unefficient, because nothing more happens. With a +relay, it shows that the program is looping, executing 0009:Call msvcrt._except_handler3(7fb2faa0,7fb2fba0,7fb2f7d4,7fb2f714) ret=7bc54d65 0009:Ret msvcrt._except_handler3() retval=00000000 ret=7bc54d65 and nothing more, ad infinitum. The machines are running very similar kernels. Both are hardened with exec-shield, but even disabling it on a 64bit by 'echo 0 >/proc/sys/kernel/exec-shield' doesn't help. The 32bit works even with exec-shield enabled (and doesn't print the no-exec message). Are there chances to fix this issue ? Or is it a system problem ? With regards, Pavel Troller

6 14

Text input box with scrollbar
by Augusto Arcoverde da Rocha 01 Jun '06

01 Jun '06

Hi all, Where I can find the inputbox drawing code? Some of these box appear with scrollbar when testing Action Request System application under Wine, but not under MS Windows. Thanks, Augusto Arcoverde da Rocha

3 2

Re: winspool/tests: [1/3] Tests for GetPrintProcessorDirectory
by Alexandre Julliard 01 Jun '06

01 Jun '06

Detlef Riekenberg <wine.dev(a)web.de> writes: > + SetLastError(0xdeadbeef); > + res = GetPrintProcessorDirectoryA(NULL, NULL, 1, NULL, 0, &cbBuf); > + if(!res && ( (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) || > + (GetLastError() == 0xdeadbeef) )) { > + trace("Not implemented yet\n"); > + return; > + } Unless there really is a Windows version that fails here, this test is wrong. Things that are not implemented yet in Wine should be marked with todo_wine, not ignored. -- Alexandre Julliard julliard(a)winehq.org

2 2

Winecfg add CoreAudio to audio drivers list
by Emmanuel Maillard 01 Jun '06

01 Jun '06

Changelog : Winecfg add CoreAudio to audio drivers list thanks Emmanuel

1 0

Re: Re: How are we doing?
by fenix＠club-internet.fr 01 Jun '06

01 Jun '06

----Message d'origine---- >De: Alexandre Julliard <julliard(a)winehq.org> >A: Detlef Riekenberg <wine.dev(a)web.de> >Date: Thu, 01 Jun 2006 11:45:10 +0200 >Copie à: wine-devel(a)winehq.com, Mike Hearn <mike(a)plan99.net> >Sujet: Re: How are we doing? > >Detlef Riekenberg <wine.dev(a)web.de> writes: > >> During the Time, things changed and I get confused more and more times >> about "special Developers" and "other Developers", as well as "special >> Patches" and "other Patches". >> (It's also Possible, that i did not see the big differences before). > >There's no such thing as special developer vs. other developer, it's >more like a linear scale based on trust: the more I trust a developer >the easiest it is for him to get his patches committed. The only way >to earn trust points is by submitting consistently good patches. > >That doesn't mean you can't get stuff in if you aren't trusted, but it >means it will require extra scrutiny, which is why it's very important >at the beginning to send small patches that are easy to review. Once >you have earned enough trust you can get away with being a bit more >sloppy (but not too much, or you'll lose trust points again ;-) It's possible to see on wiki the "trust points" positions ? :) And on each WWN, see the variations (seems the famous kde buzz) :) Anyway, adding an explaining page on wiki for "how to begin as wine developper" may help a lot Regards, Raphael

4 3

Wine 1.0 Tasks
by Dan Kegel 01 Jun '06

01 Jun '06

If you look at http://bugs.winehq.org/ you'll see a link on the left hand side called "1.0 Tasks", which lists the 1.0 bugs being tracked in bugzilla. Here's the URL it links to http://bugs.winehq.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_s… I suspect a few of these are stale, and a bunch others are missing, but I like the idea of using bugzilla to track our progress to 1.0. What other bugs should be fixed before 1.0? Let's nominate a few bugs to add to the 1.0 task list, discuss them a bit, and see what Alexandre thinks. For instance: I'd like one goal of 1.0 to be "make Windows developers take Wine seriously." To achieve that, I think 1.0 has to support at least some Microsoft development tools well, including their IDEs and debuggers. It's probably unreasonable to require 1.0 to support .NET, so maybe supporting the last pre-.NET versions of Visual C++ (6.2?) and Visual Basic (6.0?) would be a good goal. And I don't think it's that unreasonable anymore; Wine is pretty close to being able to do that. What do y'all think? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

8 14

Re: comctl32: Fix loading string from resources
by Alexandre Julliard 01 Jun '06

01 Jun '06

Thomas Weidenmueller <wine-patches(a)reactsoft.com> writes: > LoadString() cannot be used to measure the length of a string resource. > It will not return the length of the string if no buffer is provided, > instead it will return 0! This patch fixes the broken property sheet code. Since you are going to the trouble of loading it all by hand, you should allocate and fill the buffer right away, instead of returning only the length and letting LoadString do the whole thing once again. Also a test case for LoadString demonstrating that the current behavior is wrong would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wineprefix: Create a cdrom drive if it exists at /media/cdrom
by Francois Gouget 01 Jun '06

01 Jun '06

On Thu, 1 Jun 2006, Mike McCormack wrote: > + ln -s /media/cdrom "$WINEPREFIX/dosdevices/m:" Wouldn't it be better to create it as the d: drive? That's usually where CD-ROM drives end up on Windows... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ War doesn't determine who's right. War determines who's left.

1 0

Re: svrapi: add stub implementation
by Robert Shearman 01 Jun '06

01 Jun '06

Vitaly Lipatov wrote: >svrapi.dll is exist on Win9X OS and used in some programs. > > What programs? Is it still used even with the winver set to win2k? -- Rob Shearman

2 1

Re: wineconsole: Store the font as a DWORD_PTR.
by Detlef Riekenberg 31 May '06

31 May '06

Am Mittwoch, den 31.05.2006, 16:28 +0900 schrieb Mike McCormack: > index 169f4e1..73a0987 100644 > --- a/programs/wineconsole/dialog.c > +++ b/programs/wineconsole/dialog.c > + return GetWindowLongPtr(hWnd, 0); > + HFONT hFont = (HFONT)GetWindowLongPtr(hWnd, 0L); Are 0 and 0L always the same ? (32bit and 64bit) -- By By ... ... Detlef

1 0

Re: crypt32: implement CryptBinaryToStringA and CryptStringToBinaryA
by Detlef Riekenberg 31 May '06

31 May '06

Hi Juan Lang. > ChangeLog: implement CryptBinaryToStringA and CryptStringToBinaryA based > on Kai Blin's base64 encoder/decoder The Functions are not Present in every crypt_32.dll. The test will crash on win9x. (The Results from GetProcAddress are not tested) -- By By ... ... Detlef

1 0

file timestamps in a git tree
by Saulius Krasuckas 31 May '06

31 May '06

I make an ugly hack in a branch at my git tree. Then I run after following after some git updates: $ git rebase master ugly_hack $ make Makefile is older than Makefile.in configure, please rerun ./configure make: *** [Makefile] Error 1 $ git checkout master $ make Makefile is older than Makefile.in configure, please rerun ./configure make: *** [Makefile] Error 1 Is this behaviour intended? I thought git would reset all the file timestamps once I switch to another (master) branch... Am I wrong?

3 3

Re: getuname: add stub implementation [try 2]
by Robert Shearman 31 May '06

31 May '06

Vitaly Lipatov wrote: >+/*********************************************************************** >+ * GetUName [ 2000 / XP ] >+ * >+ * undocumented fn: GetUName() >+ * The information is not available by API. The thing MS did >+ * here -- parsing the data from nameslist.txt in the Unicode Character >+ * Database (UCD). >+ * See >+ * http://groups.google.com/groups?hl=en&threadm=ODVecQBoBHA.2416%40tkmsftngp02 >+ * RETURNS >+ * unknown >+ */ >+void WINAPI GetUName(void) >+{ >+ FIXME("stub\n"); >+} > > You should add a test for this function and document at least the number of parameters of the function. Presumably it should take some parameters or return something, or the DLL is useless. If the former is incorrect then the stack will be trashed after the call. -- Rob Shearman

1 0

Re: getuname: add stub implementation [try 2]
by Alexandre Julliard 31 May '06

31 May '06

Vitaly Lipatov <lav(a)etersoft.ru> writes: > +/*********************************************************************** > + * GetUName [ 2000 / XP ] > + * > + * undocumented fn: GetUName() > + * The information is not available by API. The thing MS did > + * here -- parsing the data from nameslist.txt in the Unicode Character > + * Database (UCD). > + * See > + * http://groups.google.com/groups?hl=en&threadm=ODVecQBoBHA.2416%40tkmsftngp02 > + * RETURNS > + * unknown > + */ > +void WINAPI GetUName(void) > +{ > + FIXME("stub\n"); > +} If you don't know the parameters you should leave the function as stub in the spec file, at least this way it will crash cleanly. Also you have to make the dll handle the PREATTACH value to prevent it from getting loaded if native is present. Look at how other stub dlls are doing it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Use FindMimeFromData to determine MIME type.
by Alexandre Julliard 31 May '06

31 May '06

Jacek Caban <jacek(a)codeweavers.com> writes: > dlls/urlmon/binding.c | 25 ++++++++++++++++++++----- > 1 files changed, 20 insertions(+), 5 deletions(-) This breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:401: Test failed: unexpected call OnProgress_MIMETYPEAVAILABLE url.c:401: Test failed: unexpected call OnProgress_MIMETYPEAVAILABLE make[1]: *** [url.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Re: World of Warcraft (WoW) patch/more address space layout stuff
by fenix＠club-internet.fr 31 May '06

31 May '06

----Message d'origine---- >Date: Tue, 30 May 2006 16:08:42 +0200 >De: Tomas Carnecky <tom(a)dbservice.com> >A: Mike Hearn <mike(a)plan99.net> >Copie à: wine-devel(a)winehq.com, n0dalus <n0dalus(a)gmail.com> >Sujet: Re: World of Warcraft (WoW) patch/more address space layout stuff > >Mike Hearn wrote: >> It's a bug in WoW itself, it relies upon the exact way NT maps memory >> which is different to how Linux does it. I guess they are storing >> information in the high bits of a pointer somewhere or some similar >> trick. >> > >Since WoW also runs on MacOSX, how does the memory layout on MacOSX >differ from NT and Linux? Maybe that's the reason why they won't do a >Linux port: because they rely on a certain memory layout and the code >can't be changed that easily. No, they have added this regressions after a little patch-set. So they can fix it. And as we can't download a playable demo ... Regards, Raphael

5 4

--without-opengl problems
by Saulius Krasuckas 31 May '06

31 May '06

If I compile Wine by starting with "./configure", it builds dlls/wined3d/wined3d.dll.so file. Then If I run some Ogre (d3d) game, I get all video setup stuff OK. If I connect to my tightvnc server after and run the game here, I get Xlib errors in the output (about missing GLX on :1.0 or a like). Then I decide to disable OpenGL support in Wine and start with "./configure --without-opengl". After this the wined3d.dll.so is left on the disk. And if later I run the game again via vnc server, I get weird errors and see Wine crashing in wined3d.dll (and sometimes wineprefixcreate crashes inside shlwapi.dll or opengl.dll). Isn't this behaviour strange a bit? Shouldn't configure delete dlls/wined3d/wined3d.dll.so or unlink dlls/wined3d.dll.so or at least define code don't try loading wined3d.dll when "--without-opengl" option is given to it? IOW, "make clean" shouldn't be necessary here, right? Well, I just may be missing some information... TIA

4 4

Re: [PATCH] dnsapi: Missing lock release on error path (found by Smatch)
by Hans Leidekker 31 May '06

31 May '06

On Tuesday 30 May 2006 23:39, Michael Stefaniuc wrote: > it looks like the function returns on the error path with the lock held. > Is it supposed to do that? If not the attached patch fixes it. No, that's a bug. Thanks. -Hans

1 0

Re: rpcrt4: Implement NdrClientContext(Un)Marshall.
by Saveliy Tretiakov 31 May '06

31 May '06

NdrClientContext(Un)Marshall shuold add size of context handle to pStubMsg->Buffer and raise exceptions in some cases. NDRCContext(Un)marshall shouldn't, that's the difference. You can see this from my testcases (attached). And this was already implemented in my patch. I can't understand why are you trying to reimplement it. Mike McCormack wrote: > --- > > dlls/rpcrt4/ndr_marshall.c | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) > > ------------------------------------------------------------------------ > > e834795f1d24b26411d76ba725975216867ae58e > diff --git a/dlls/rpcrt4/ndr_marshall.c b/dlls/rpcrt4/ndr_marshall.c > index 06ce04a..edd1eb2 100644 > --- a/dlls/rpcrt4/ndr_marshall.c > +++ b/dlls/rpcrt4/ndr_marshall.c > @@ -4296,7 +4296,10 @@ void WINAPI NdrClientContextMarshall(PMI > NDR_CCONTEXT ContextHandle, > int fCheck) > { > - FIXME("(%p, %p, %d): stub\n", pStubMsg, ContextHandle, fCheck); > + TRACE("(%p, %p, %d): stub\n", pStubMsg, ContextHandle, fCheck); > + /* FIXME: what does fCheck do? */ > + return NDRCContextMarshall(ContextHandle, > + pStubMsg->Buffer); > } > > /*********************************************************************** > @@ -4306,7 +4309,11 @@ void WINAPI NdrClientContextUnmarshall(P > NDR_CCONTEXT * pContextHandle, > RPC_BINDING_HANDLE BindHandle) > { > - FIXME("(%p, %p, %p): stub\n", pStubMsg, pContextHandle, BindHandle); > + TRACE("(%p, %p, %p): stub\n", pStubMsg, pContextHandle, BindHandle); > + return NDRCContextUnmarshall(pContextHandle, > + BindHandle, > + pStubMsg->Buffer, > + pStubMsg->RpcMsg->DataRepresentation); > } > > void WINAPI NdrServerContextMarshall(PMIDL_STUB_MESSAGE pStubMsg, > > > ------------------------------------------------------------------------ > > >

2 6

how to edit wiki?
by mark cox 31 May '06

31 May '06

When i search in google for 'cxtest', one of the hits is from winenq, but when i open the page http://wiki.winehq.org/CxTest, i get the message '*This page does not exist yet. You can create a new empty page, or use one of the page templates. Before creating the page, please check if a similar page already exists.'. and an option to 'create a new empty page'. If i choose to create a new page, i get the message '*You are not allowed to edit this page.'. No indication is given as to how to sign in or what to do. Most wiki's have an option to 'sign in', or 'create a new account'. I thought that the idea of wiki's was that were meant to be accessible without jumping through hoops, so what's going on? Regards, mark. * *

3 4

Re: Mac OS X Audio driver
by Robert Reif 30 May '06

30 May '06

Emmanuel Maillard wrote: > Hi, > > This patch is the initial Audio Driver for Mac OS X, quiet big > (contain all winecoreaudio dir) tell me if you want i split this in > separated patches. > > Thanks > > Emmanuel > > Authors: > Ken Thomases <ken at codeweavers dot com> > Emmanuel Maillard <mahanuu at opendarwin dot org> > > Changelog: > Initial Audio Driver for Mac OS X. > Could you add this to winecfg? Should be a one line patch.

1 0

Re: Wine 1.0 Tasks
by Dan Kegel 30 May '06

30 May '06

On 5/30/06, Brian Vincent <brian.vincent(a)gmail.com> wrote: > On 5/30/06, Dan Kegel <dank(a)kegel.com> wrote: > > I guess there are two main use cases: > > 1) developer wants to debug an app that misbehaves on Linux/Wine but > > not on Windows > > 2) manager or clueless pundit who are into VB or VC++ wants to say > > Wine is useless, > > and by supporting Visual Studio we convince them otherwise > > 3) Source code management lives in Visual Source Safe and VS .NET or > MSVC++ 6.0 is needed to access it. Oh, good point. Yes, we should include Visual Sourcesafe integration support in our Visual Studio testing. (I used VSS for years with Wine; see http://kegel.com/wine/vss-howto.html, but I seldom used the GUI and never used Visual Studio.) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: wine.inf: Add user "Shell Folders\Font" entry.
by Alexandre Julliard 30 May '06

30 May '06

Vitaliy Margolen <wine-patch(a)kievinfo.com> writes: > ChangeLog: > wine.inf: Add user "Shell Folders\Font" entry. This should go with the other shell folder registration stuff in shell32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [WINMM] always check for open and close enents in wave test
by Alexandre Julliard 30 May '06

30 May '06

Robert Reif <reif(a)earthlink.net> writes: > Fix CreateThread/waveOutOpen race by forcing parent thread to sleep > which allows background thread to run and block before waveOutOpen is > called. If the background thread has to run for things to work, you need to add a real synchronisation mechanism. A Sleep is not fixing anything, it's just making the race condition less likely. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: building win32/wine .exe's
by Dan Kegel 30 May '06

30 May '06

Nik wrote: > [I build my Windows apps on Win2k. How can I do it on Linux? > winegcc doesn't seem the right way.] Depends. If your apps use C++, and you need to be able to access non-COM C++ DLLs compiled by other folks, I bet the best way to go is just run the same development tools you used on Win2k under Wine. You might be able to just run the Visual C++ setup under Wine and get the IDE running. Or if the commandline is enough for you, see http://kegel.com/wine/cl-howto.html for how I used to set that up. Or, if you can get away with using Mingw instead of Microsoft's compiler, see http://www.winehq.com/site/docs/winedev-guide/cross-compiling-tests for info about how to set up a mingw cross-compiler. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

World of Warcraft (WoW) patch/more address space layout stuff
by Nick Law 30 May '06

30 May '06

Opening up the debate again on the World of Warcraft ( WoW ) memory patch. Some facts about WoW that may explain why the AppDB page is pretty active and the wow patch for wine 0.9.12 was downloaded over 1000 times from the Appdb page during a 4 week period.... Wow has approximately 6 million players that each pay about $90/year for the priviledge of connecting to a WoW server (Realm). Assuming this figure is broadly correct, Blizzard therefore receives $500,000,000/year just from this game in subscriptions. ( This doesn't include the cost of buying the game in the first place ). Perhaps Blizzard would like to employee a programmer fulltime just to work on the wine project to help make Wow run 100% ?. Anyway with the popularity of this game in mind, you can see why there is a lot of interest in making this patch a thing of the past, so the thousands of gamers who play this game on wine don't have to keep applying a special patch. I would be grateful for any suggestions as to how we could incorporate this patch so that it is no longer necessary. I know we can't simply include the patch, but there must be some way around this problem ? Below is an email regarding this partiicular problem, I would be grateful for any comments that I can pass back to Jan Riewe. Thanks Regards Nick Law Appdb Maintainer - World of Warcraft 1.10.x Any feedback is much appreciated. Comment for 'World of Warcraft 1.10.x' added by jan riewe ------------------------------------------------------- To reply to this email please use the link provided below. DO NOT reply via your email client as it will not reach the person who wrote the comment http://appdb.winehq.org/appview.php?versionId=4031&mode=nested#Comment-12086 Subject: RE: is this a workaround or a real patch? is it posible to make a workaround with the user.reg? in the transgaming forum i`ve found something like : [Software\\Wine\\AppDefaults\\WoW.exe\\Memory] 1148134976 "MemoryLayoutOverride"="0x10000000" does it make sense on wine? (i am not so familiar to the wine syntax *shame on me*) is this perhaps the key to get rid of the patches and make the binary build of wine working with WoW also fine? if this is a posibility perhaps you can post a full "user.reg" fix for those of us, who love the update feature. and i just want to thank you ... your service this really great! wow is one of the biggest steps at the moment for gaming society to move more and more to an opensource system. ---- --- wine/libs/wine/mmap.c.orig 2006-05-11 17:02:13.000000000 +0100 +++ wine/libs/wine/mmap.c 2006-05-19 22:08:03.000000000 +0100 @@ -183,7 +183,26 @@ #endif /* (__svr4__ || __NetBSD__) && !MAP_TRYFIXED */ +static void *get_anon_mmap_null_address(size_t size) +{ + static int got_override = 0; + static void *low_alloc_ptr = NULL; + void * current_low_alloc_ptr; + + if (!got_override) + { + low_alloc_ptr = (void*)0x10000000; + got_override = 1; + } + + current_low_alloc_ptr = low_alloc_ptr; + + if (low_alloc_ptr) + low_alloc_ptr += size; + return current_low_alloc_ptr; + } + /*********************************************************************** * wine_anon_mmap * @@ -213,6 +232,8 @@ return start; #endif } + if ((start == NULL) && !(flags & MAP_FIXED)) + start = get_anon_mmap_null_address(size); return mmap( start, size, prot, flags, get_fdzero(), 0 ); } --- wine/loader/preloader.c.orig 2006-05-11 17:02:13.000000000 +0100 +++ wine/loader/preloader.c 2006-05-19 22:14:22.000000000 +0100 @@ -109,8 +109,8 @@ static struct wine_preload_info preload_info[] = { { (void *)0x00000000, 0x00110000 }, /* DOS area */ - { (void *)0x7ffe0000, 0x01020000 }, /* shared user data + shared heap */ - { (void *)0x00110000, 0x1fef0000 }, /* PE exe range (may be set with WINEPRELOADRESERVE), defaults to 512mb */ + { (void *)0x80000000, 0x01000000 }, /* shared user data + shared heap */ + { (void *)0x10000000, 0x00f00000 }, /* PE exe range (may be set with WINEPRELOADRESERVE), defaults to 512mb */ { 0, 0 } /* end of list */ }; -- Regards Nick Law Mobile: 07736 022165 Email: nick.law(a)mic-nucmed.co.uk Medical Imaging Consultancy Ltd (M.I.C) Sales and Service of ADAC and IS2 Products http://www.mic-nucmed.co.uk

5 7

Re: comctl32_tests: Janitorial: write-strings warning fix
by Vitaliy Margolen 30 May '06

30 May '06

Saturday, May 27, 2006, 11:57:33 AM, Andrew Talbot wrote: > Changelog: > comctl32_tests: Janitorial: write-strings warning fix. > diff -urN a/dlls/comctl32/tests/tab.c b/dlls/comctl32/tests/tab.c > --- a/dlls/comctl32/tests/tab.c 2006-05-27 17:25:57.000000000 +0100 > +++ b/dlls/comctl32/tests/tab.c 2006-05-27 18:45:43.000000000 +0100 > @@ -57,6 +57,9 @@ > { > HWND handle; > TCITEM tcNewTab; > + static char text1[] = "Tab 1", > + text2[] = "Wide Tab 2", > + text3[] = "T 3"; > handle = CreateWindow ( > WC_TABCONTROLA, > @@ -71,13 +74,13 @@ > SendMessage (handle, WM_SETFONT, 0, (LPARAM) hFont); > tcNewTab.mask = mask; > - tcNewTab.pszText = "Tab 1"; > + tcNewTab.pszText = text1; > tcNewTab.iImage = 0; > SendMessage (handle, TCM_INSERTITEM, 0, (LPARAM) &tcNewTab); > - tcNewTab.pszText = "Wide Tab 2"; > + tcNewTab.pszText = text2; > tcNewTab.iImage = 1; > SendMessage (handle, TCM_INSERTITEM, 1, (LPARAM) &tcNewTab); > - tcNewTab.pszText = "T 3"; > + tcNewTab.pszText = text3; > tcNewTab.iImage = 2; > SendMessage (handle, TCM_INSERTITEM, 2, (LPARAM) &tcNewTab); What warning are you talking about here? It's ascii constant text. It should not be ever written to. Nor I ever seen a single warning from this code. Vitaliy Margolen

4 6

Re: wineconsole: Improve 64bit compatibility.
by Alexandre Julliard 30 May '06

30 May '06

Mike McCormack <mike(a)codeweavers.com> writes: > @@ -153,7 +153,7 @@ static LRESULT WINAPI WCUSER_FontPreview > SetWindowLong(hWnd, 0, 0); > break; > case WM_GETFONT: > - return GetWindowLong(hWnd, 0); > + return GetWindowLongPtr(hWnd, 0); > case WM_SETFONT: > SetWindowLong(hWnd, 0, wParam); > if (LOWORD(lParam)) You should fix all the Get/SetWindowLong calls that set the same value, changing only half will make things worse. You also have to reserve the proper size in the window class. -- Alexandre Julliard julliard(a)winehq.org

1 0

wined3d: GLSL shader status
by Jason Green 30 May '06

30 May '06

I'm working on the conversion from DirectX pixel and vertex shaders to GLSL function and have made a good bit of progress this weekend. At the moment, I'm able to run just about every simple vertex shader (version <= 1.4, and a few 2.0's) that I can find which already works on ARB_vertex_program (the current way that Wine handles this). I'm having a bit more trouble with pixel shaders, but I haven't really dug into it yet. Some of the really simple ones work, but I believe I'm missing a step in the texture binding code somewhere. I've posted a patch to enable this shader generation here: http://cmhousing.net/wine/glsl_hack4.diff If you want to try this and help debug things, you'll have to apply the patch (it's against the current git tree as of 2:00 AM EST, May 30th). Plus, you'll need a video card and driver capable of using GLSL (type 'glxinfo' and look for "GL_ARB_shading_language_100") . You'll also have to set a new registry key in your Wine installation (it is case sensitve): HKEY_CURRENT_USER\Software\Wine\Direct3D\UseGLSL = "enabled" Here are a few comparison screenshots (note, yes, they should be identical ;-): http://www.cmhousing.net/wine/aniso_arb.png (vanilla wine, or with UseGLSL != "enabled") http://www.cmhousing.net/wine/aniso_glsl.png (using GLSL) http://www.cmhousing.net/wine/grass_arb.png http://www.cmhousing.net/wine/grass_glsl.png http://www.cmhousing.net/wine/dolphin2_glsl.png (DX8 SDK dolphin sample) http://www.cmhousing.net/wine/civ4_glsl.png (not *quite* there yet ;-) In theory, once this all works, we'll be able to support shader model 2.0+, which a lot of newer games either require or strongly suggest (aka prettier graphics). Now, there are plenty of other bugs to be worked out in wined3d, so this isn't the holy grail of patches or anything, but it will take us that much closer to supporting new games. Please lend a hand if you're able to. Thanks! (by the way, many thanks to the entire #winehackers crew for all the help along the way so far, it's been fun)

3 2

Compiling wine on an x86-64 system
by Pavel Troller 30 May '06

30 May '06

Hi! I would like to ask for a help with wine compilation on an x86_64 system. Today I successfully did the compilation, but the result is totally unusable. I've supplied -m32 switch to both CFLAGS and LDFLAGS (I have to specify my own C/LDFLAGS because of custom -I/-L options to find various packages). gcc as well as winegcc correctly generated 32bit output. There was just one error during compilation - it attempted to compile dlls/ntdll/signal_i386.c, which suffered from __NR_sigaction being undefined. Because my kernel headers are set up for a 64bit system, there is not such a define. __NR_rt_sigaction is defined instead. I'm not sure whether it's ok that wine tried to compile this file (it compiled signal_x86_64.c too, with no problems). I also don't know how to hack the kernel includes to define it correctly (I have just vanilla, unmodified set of native kernel headers for 2.6.17-rc5 set up). So I hacked it by copying the appropriate #define from asm-i386/unistd.h kernel header directly to signal_i386.c. wine then compiled and installed without a glitch. However, any attempt to run it ends up with immediate return without any diagnosis. It even doesn't output its usage help. I've already compiled a lot of "normal" programs for 32bit systems on my x86_64 system. However, wine resists. What am I doing wrong ? What's the correct way ? With regards, Pavel Trolle

4 4

server: Return an error for invalid requests instead of killing the client process.
by Mike Hearn 30 May '06

30 May '06

Hi Alexandre, I'm curious as to what the reason behind this change was. I was under the impression an invalid request must always mean a corrupted/destabilised client. Please give me insight! :) thanks -mike

2 1

building win32/wine .exe's
by NikNot 30 May '06

30 May '06

I am running wine (including winelib development packages) un Ubuntu 6.x beta, and I'd like, if possible, to migrate my Win32 development from Win2k to Ubuntu (where most of my development is done). Further to winelib information found in http://www.winehq.org/site/winelib and makefile examples from http://www.computersciencelab.com/Petzold.htm, I came to the conclusion that it should be possible to build, under Linux, a single .exe file that would run under both wine on Linux and on win2k. One of the simplest examples in ...Petzold.htm above (clover.c) can be compiled and linked as: winegcc -c -mno-cygwin clover.c winegcc -o clover.exe clover.o -mno-cygwin -mwindows -lcomctl32 -lcomdlg32 -lwinmm -ladvapi32 -lwinspool Both steps run with no errors, but the result is clover.exe.so and a shell script clover. Either will run under Ubuntu/wine, but .so is of course not a win32 executable. Is my assumption that it is possible to build a win32 executable using winegcc on Linux correct? If yes, I must be missing something rather obvious: any pointer will be appreciated. TIA, Nik N.

1 0

Release Information on Fedora Extras!
by Neal Gompa 29 May '06

29 May '06

I have noticed that since my post about how Fedora packages are inaccessible, you have added the string "Currently official Fedora packages lag behind, but you can get Wine-0.9.10 by running yum install wine from Fedora Extras<http://fedoraproject.org/extras/4/i386/repodata/repoview/W.group.html>." Well, that is not totally correct. Usually about a week after Wine Project releases a version, Fedora Extras updates to the newest version! Currently, it is at Wine-0.9.13. I believe it will be a week before Fedora Extras releases Wine-0.9.14 packages... I will reply when Wine packages are updated you that an accurate guage is made of the lag... Note: For Wine-0.9.13, and it only took 3 days after Wine official release to release it on Fedora Extras. It is a good idea to assume anywhere from 3-5 days for Wine to be updated in Fedora Extras. The links below are to the webview of Fedora Extras: -=Repositories for i386=- Fedora Extras for Fedora Core 5: http://download.fedora.redhat.com/pub/fedora/linux/extras/5/i386/repodata/r… Fedora Extras for Fedora Core 4: http://download.fedora.redhat.com/pub/fedora/linux/extras/4/i386/repodata/r… Fedora Extras for Fedora Core 3: http://download.fedora.redhat.com/pub/fedora/linux/extras/3/i386/repodata/r… -=Repositories for x86_64=- Fedora Extras for Fedora Core 5: http://download.fedora.redhat.com/pub/fedora/linux/extras/5/x86_64/repodata… <http://download.fedora.redhat.com/pub/fedora/linux/extras/5/i386/repodata/r…> Fedora Extras for Fedora Core 4: http://download.fedora.redhat.com/pub/fedora/linux/extras/4/x86_64/repodata… Fedora Extras for Fedora Core 3: http://download.fedora.redhat.com/pub/fedora/linux/extras/3/x86_64/repodata… Note that it is viewing the alphabet group of "W". Scroll down a bit and you will see Wine packages. Please keep download form updated, you make people believe that Wine is not being updated by Fedora Extras, when in fact it is...

2 3

AppBar support
by Paul Chitescu 29 May '06

29 May '06

Hello! I plan to add proper SHAppBarMessage support in wine. I'm using as base some old code I've written to extend Win32s so it shouldn't be very difficult. I have however to choose a window to manage all appbars. It will have to receive WM_COPYDATA messages, much like currently Shell_NotifyIcon does with "Shell_TrayWnd". Obviously it has to reside somewhere in the explorer.exe as it's shared among running programs. The most obvious choice would be to use the desktop window itself as its geometry has to be used anyway. I am however afraid that programs may blindly send a WM_COPYDATA to it, so an option may be to create another, invisible window. What do you think about this? Do you know many applications that use the desktop window as an universal junk receiver? The /dev/null of the GUI world ;-) Regards, Paul Chitescu

1 0

winmm/joystick/joystick.c: Name Clash ("SW_MAX")
by Andrew Talbot 29 May '06

29 May '06

There seems to be a name conflict in this file. "SW_MAX" is defined in linux/input.h as a switch event, with value 0x0f. But our winuser.h has it defined as a ShowWindow() code, with value 11 (decimal). This joystick.c file includes linux/input.h and linux/joystick.h (which, in turn, includes linux/input.h). Does anyone wish to take this up, and should I create a bug report in the meantime? Thanks, -- Andy.

1 1

Bug 5124
by Tom Booker 29 May '06

29 May '06

http://bugs.winehq.org/show_bug.cgi?id=5124 There is a solution in the bug.. Could someone please look and let the person know if that would be something that AJ would commit? If so, could you assist him with deriving a patch from his solution so that he can submit it to wine-patches. I would, but the lights are flickering at my place due to storms and so I need to turn off the comp.

1 0

Myst IV Installer breakage
by Ulrich Dobramysl 29 May '06

29 May '06

Hello! On wine-users I was told I should go here for my problem. So here it is: The game "Myst IV - Revelation" by Cyan Worlds / Ubisoft installed fine in earlier versions of wine (although it was and is not playable). Recently I tried again, and the setup crashed just before the copying of files would start. I was able to isolate the patch that caused the regression (with git bisect). Here is the commit message: >commit 19fad8e71032707cb036239f69f085e1b0249d01 >Author: Robert Shearman <rob(a)codeweavers.com> >Date: Fri May 19 16:03:13 2006 +0100 > > rpcrt4: Don't set the memory pointer to NULL before calling >PointerUnmarshall. > > Call it with fMustAlloc set to TRUE instead to achieve the same >result > without side-effects. The output of wine is here: fixme:ole:ITypeInfo_fnRelease destroy child objects err:ole:get_unmarshaler_from_stream Failed to read common OBJREF header, 0x00000001 fixme:ole:NdrClearOutParameters (0x7c5fd6a0,0x7c174212,0x7c5fd7d4): stub fixme:win:SetWindowTextA setting text "TITLE_CAPTIONBAR" of other process window (nil) should not use SendMessage fixme:win:SetWindowTextA setting text "Myst IV - Revelation - InstallShield Wizard" of other process window (nil) should not use SendMessage fixme:win:SetWindowTextA setting text "TITLE_CAPTIONBAR" of other process window (nil) should not use SendMessage fixme:win:SetWindowTextA setting text "Myst IV - Revelation - InstallShield Wizard" of other process window (nil) should not use SendMessage fixme:x11drv:X11DRV_SetWindowRgn not supported on other thread window 0x3002c err:ole:get_unmarshaler_from_stream Failed to read common OBJREF header, 0x00000001 err:ole:get_unmarshaler_from_stream Failed to read common OBJREF header, 0x00000001 err:ole:marshal_object object doesn't expose interface {be6115a1-7de5-48dc-ad2a-25060e00fce2}, failing with error 0x80004002 err:ole:ClientIdentity_QueryMultipleInterfaces IRemUnknown_RemQueryInterface failed with error 0x80004002 err:ole:xCall RpcChannelBuffer SendReceive failed, 8007000e err:ole:xCall Failed to serialize param, hres 8007000e err:ole:xCall RpcChannelBuffer GetBuffer failed, 8007000e err:ole:xCall Failed to serialize param, hres 8007000e err:ole:xCall RpcChannelBuffer GetBuffer failed, 8007000e err:ole:xCall Failed to serialize param, hres 8007000e ... The last two lines are repeated very often. I would fix it myself but my insight in the wine code is limited. Ulrich Dobramysl

1 0

How do fonts work ?
by Robert Lunnon 29 May '06

29 May '06

Hmm, more on the Google earth saga, I have been looking at the font traces and get things like the following but freetype doesn't support these tags (except GSUB) ??? trace:font:WineEngGetFontData Can't find table 4a535446. This is tag JSTF trace:font:WineEngGetFontData font=7ff405d8, table=534f5047, offset=00000000, buf=0, cbData=0 trace:font:WineEngGetFontData Can't find table 47504f53. Tag GPOS trace:font:WineEngGetFontData font=7ff405d8, table=42555347, offset=00000000, buf=0, cbData=0 trace:font:WineEngGetFontData Can't find table 47535542. Tag GSUB trace:font:WineEngGetFontData font=7ff405d8, table=46454447, offset=00000000, buf=0, cbData=0 trace:font:WineEngGetFontData Can't find table 47444546. Tag GDEF Should freetype be able to find these tables ?

2 1

user32,x11drv: window maximization issues / sending WM_SIZE
by Juris Smotrovs 29 May '06

29 May '06

In an attempt to solve bug 4964, I found several issues where Wine behaves incorrectly (e.g. not sending the messages it should send) or simply differently (e.g. not sending messages where Windows sends them, but perhaps there is no real reason in Wine case to send them) than Windows during window maximization/restoration. I wrote a patch correcting these issues and making succeed 10 of the TODO tests in dlls/user/tests/msg.c related with window maximization/restoration, however it was not accepted, possibly due to its size and dealing with several issues at once. Thus, I ask your opinion on a patch correcting the first issue, the actual reason of bug 4964. Namely, as specified in documentation, the WM_SIZE message should be sent when the window is being resized (i.e. when its width or height is changed) *or* when it changes state between maximized/minimized/restored. However, in dlls/user/defwnd.c, DEFWND_HandleWindowPosChanged(...) Wine looks only for client width and height changes (signaled by flag SWP_NOCLIENTSIZE). There is another flag, 0x8000 signaling exactly the window state change. The patch consists of: 1. Introducing a constant for the flag 0x8000, since it is going to be used in several places. 2. Replacing 0x8000 with the constant in the place where the flag is set. 3. Using the flag in DEFWND_HandleWindowPosChanged to send WM_SIZE also at state change. Now, when the WM_SIZE message is sent at maximization, the testcase WmMaximizeMDIchildInvisibleParentSeq in msg test, written especially for this problem, proceeds further than before patch, however stucks to another issue: though being a test marked with TODO, it produces error messages, because in the message sequence expected default window procedure messages coincide with actual non-defwinproc messages (which are expected later), and for such collision the checking for TODO flag is not written. Therefore, the patch also 4. Adds checking for TODO flag in the case of the defwinproc collision. What is your opinion of the patch? Is there anything wrong with it? Cheers, Juris

1 0

Test results for ddraw patches
by Alexander Nicolaysen Sørnes 29 May '06

29 May '06

Greetings, My testing reveals that a large number of ddraw games crash with the new ddraw patch. These ran fine with the version from 8th April. Games that crash on startup - Heroes of Might and Magic IV - Heroes of Might and Magic III Complete - Stronghold - Warlords Battlecry - Warlords Battlecry II Age of Empires II crashes when starting a game, and I have attached its console output to this message. The version of Wine I used to test with was a fresh CVS checked out a few hours after the patch announcement, then patched with the new ddraw patch. It is available here http://www.thehandofagony.com/alex/wine-wd3dp/ Regards, Alexander N. Sørnes

2 1

Google earth mysteries
by Robert Lunnon 29 May '06

29 May '06

I am having a look at a google earth problem where Google earth says "Google earth has a problem and needs to close, sorry for the inconvenience". Seems to be font related, here is the relay dump just prior to the crash. The exception occurs in Application code. Any guesses would be appreciated... 0009:Call kernel32.98(7fba4e60) ret=7fb67b9d 0009:Call ntdll.NtCurrentTeb() ret=7fe18dc3 0009:Ret ntdll.NtCurrentTeb() retval=7ffe0000 ret=7fe18dc3 0009:Call ntdll.RtlLeaveCriticalSection(7fba4e60) ret=7fe18f01 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=7fe18f01 0009:Ret kernel32.98() retval=00000000 ret=7fb67b9d 0009:Ret gdi32.GetDeviceCaps() retval=00000060 ret=7301ef64 0009:Call gdi32.GetDeviceCaps(00000468,00000058) ret=7301ef76 0009:Call kernel32.97(7fba4e60) ret=7fb67a2c 0009:Call ntdll.NtCurrentTeb() ret=7fe18dc3 0009:Ret ntdll.NtCurrentTeb() retval=7ffe0000 ret=7fe18dc3 0009:Call ntdll.RtlEnterCriticalSection(7fba4e60) ret=7fe18d06 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=7fe18d06 0009:Ret kernel32.97() retval=7fea6580 ret=7fb67a2c 0009:Call winex11.drv.GetDeviceCaps(7ff44e40,00000058) ret=7fb40b62 0009:Ret winex11.drv.GetDeviceCaps() retval=00000060 ret=7fb40b62 0009:Call kernel32.98(7fba4e60) ret=7fb67b9d 0009:Call ntdll.NtCurrentTeb() ret=7fe18dc3 0009:Ret ntdll.NtCurrentTeb() retval=7ffe0000 ret=7fe18dc3 0009:Call ntdll.RtlLeaveCriticalSection(7fba4e60) ret=7fe18f01 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=7fe18f01 0009:Ret kernel32.98() retval=00000000 ret=7fb67b9d 0009:Ret gdi32.GetDeviceCaps() retval=00000060 ret=7301ef76 0009:Call kernel32.MulDiv(000001e0,0000000b,000001e0) ret=7301ef7d 0009:Ret kernel32.MulDiv() retval=0000000b ret=7301ef7d 0009:Call ntdll.RtlLeaveCriticalSection(73052204) ret=7301f47b 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=7301f47b 0009:Call gdi32.GetCharABCWidthsI(00000468,00000000,00000040,00000000,7fd7f29c) ret=7301f288 0009:Call kernel32.97(7fba4e60) ret=7fb67a2c 0009:Call ntdll.NtCurrentTeb() ret=7fe18dc3 0009:Ret ntdll.NtCurrentTeb() retval=7ffe0000 ret=7fe18dc3 0009:Call ntdll.RtlEnterCriticalSection(7fba4e60) ret=7fe18d06 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=7fe18d06 0009:Ret kernel32.97() retval=7fea6580 ret=7fb67a2c 0009:Call kernel32.98(7fba4e60) ret=7fb67b9d 0009:Call ntdll.NtCurrentTeb() ret=7fe18dc3 0009:Ret ntdll.NtCurrentTeb() retval=7ffe0000 ret=7fe18dc3 0009:Call ntdll.RtlLeaveCriticalSection(7fba4e60) ret=7fe18f01 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=7fe18f01 0009:Ret kernel32.98() retval=00000000 ret=7fb67b9d 0009:Ret gdi32.GetCharABCWidthsI() retval=00000001 ret=7301f288

1 0

re: [RICHED20] Implement some methods of ITextInterfaces
by Dan Kegel 29 May '06

29 May '06

Say, whatever happened to Maarten Lankhorst from Feb 2, http://www.winehq.org/pipermail/wine-patches/2006-February/023911.html that implemented part of what's needed for windowless RichEdit support? Was it too much of a stub? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Picasa for Linux available!
by Smith, Leo 28 May '06

28 May '06

Since Wine runs under OS X do you think this build of Picasa would work? Leo Smith City of Concord Information Technology Department 1950 Parkside Dr. Concord, CA 94519 925 671 3277 lsmith(a)ci.concord.ca.us

1 0

return void function
by David Anderson 28 May '06

28 May '06

Your comment about return RpcRaiseException(hr); is quite interesting, but, IMO, it's not a good choice. RpcRaiseException(hr); return; is c-like whereas return RpcRaiseException(hr); is a (slightly arcane) C++-ism which, I gather, really only came about because template/generic programming sort of forces it to be legal else various templates could not be written. The original ANSI C expressly forbids your return statement under 'constraints' of section 6.6.6.4 (ISO/IEC 9899 section numbering in this sentence). I think the original questions demonstrate that it would be better written as simpler C as I suggest (and others hinted). David Anderson: just making a suggestion here. (author of the (first-ever-shipped, possibly) full ANSI C compilation environment, shipped by SGI in 1990 (only usable on SGI MIPS/IRIX machines)).

1 0

Re: DBGHELP: Implement SymGetSymFromAddr64
by Eric Pouech 28 May '06

28 May '06

Thomas Weidenmueller wrote: >The attached patch implements SymGetSymFromAddr64, called by steam. > > a couple of coments: >@@ -996,7 +996,8 @@ > sym = pair.effective->addr_sorttab[idx]; > > symt_fill_sym_info(&pair, &sym->symt, Symbol); >- *Displacement = Address - Symbol->Address; >+ if (Displacement) >+ *Displacement = Address - Symbol->Address; > return TRUE; > } > > > why do you need this ? >@@ -1053,6 +1054,31 @@ > return TRUE; > } > >+/****************************************************************** >+ * SymGetSymFromAddr (DBGHELP.@) >+ * >+ */ >+BOOL WINAPI SymGetSymFromAddr64(HANDLE hProcess, DWORD64 Address, >+ PDWORD64 Displacement, PIMAGEHLP_SYMBOL64 Symbol) >+{ >+ char buffer[sizeof(SYMBOL_INFO) + MAX_SYM_NAME]; >+ SYMBOL_INFO*si = (SYMBOL_INFO*)buffer; >+ size_t len; >+ >+ if (Symbol->SizeOfStruct < sizeof(*Symbol)) return FALSE; >+ si->SizeOfStruct = sizeof(*si); >+ si->MaxNameLen = MAX_SYM_NAME; >+ if (!SymFromAddr(hProcess, Address, &Displacement, si)) > > - you should test that Address can be casted down to a 32 bit entity (see other functions for how to do it) - &Displacement looks pretty wrong: you need a local 32 bit dword, pass its address, and then convert the local 32 bit value into the 64 bit pointer (Displacement) >+ return FALSE; >+ >+ Symbol->Address = si->Address; >+ Symbol->Size = si->Size; >+ Symbol->Flags = si->Flags; >+ len = min(Symbol->MaxNameLength, si->MaxNameLen); >+ lstrcpynA(Symbol->Name, si->Name, len); >+ return TRUE; >+} >+ > static BOOL find_name(struct process* pcs, struct module* module, const char* name, > SYMBOL_INFO* symbol) > { > > >------------------------------------------------------------------------ > > > >

2 2

Re: secur32: Cleaning up the authentication tests.
by Kai Blin 28 May '06

28 May '06

* Kai Blin <kai.blin(a)gmail.com> [27/05/06, 15:45:57]: > + trace("blub\n"); That one slipped me. I'll send an amended patch shortly. Kai -- Kai Blin, (blin at gmx dot net) In spite of everything, I still believe that people are good at heart. -- Ann Frank

1 0

Lotus Notes R7 on Wine
by Roland Kaeser 28 May '06

28 May '06

Hello I currently trying to run the Domino Client (Lotus Notes R7) on Wine 0.9.14 but couldn't get success yet. Does somebody has experience about running the R7 on Wine? I tried a lot of diffrent WINEDLLOVERRIDES settings but all I get is that Lotus brings the crash dialog (which creates a crash error message). I would be very appreciative for any hint. Roland Kaeser

1 0

Re: wined3d: fix R8G8B8 texture upload
by Ivan Gyurdiev 28 May '06

28 May '06

> diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index 77b6b33..d15520b 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -1741,7 +1741,7 @@ GLenum D3DFmt2GLFmt(IWineD3DDeviceImpl* > /* color buffer */ > case WINED3DFMT_R3G3B2: retVal = GL_RGB; break; > case WINED3DFMT_R5G6B5: retVal = GL_RGB; break; > - case WINED3DFMT_R8G8B8: retVal = GL_RGB; break; > + case WINED3DFMT_R8G8B8: retVal = GL_BGR; break; > case WINED3DFMT_A1R5G5B5: retVal = GL_BGRA; break; > case WINED3DFMT_X1R5G5B5: retVal = GL_BGRA; break; > case WINED3DFMT_A4R4G4B4: retVal = GL_BGRA; break; > Careful, you're getting out-of-sync with surface.c. That should probably be changed also [ UnlockRect ].

1 0

void dispatch_rpc() returns a value
by Bang Jun-Young 27 May '06

27 May '06

Hi, I wonder how this has been possible so far: static void __RPC_STUB dispatch_rpc(RPC_MESSAGE *msg) { struct dispatch_params *params; APARTMENT *apt; IPID ipid; HRESULT hr; RpcBindingInqObject(msg->Handle, &ipid); TRACE("ipid = %s, iMethod = %d\n", debugstr_guid(&ipid), msg->ProcNum); params = HeapAlloc(GetProcessHeap(), 0, sizeof(*params)); if (!params) return RpcRaiseException(E_OUTOFMEMORY); hr = ipid_get_dispatch_params(&ipid, &apt, &params->stub, &params->chan); if (hr != S_OK) { ERR("no apartment found for ipid %s\n", debugstr_guid(&ipid)); return RpcRaiseException(hr); } dispatch_rpc() shouldn't return anything since it's a void function, but it actually does. Jun-Young

3 3

Re: winspool/tests: Use 0xdeadbeef as magic Value
by Andreas Mohr 27 May '06

27 May '06

Hi, On Sat, May 27, 2006 at 12:35:02AM +0200, Detlef Riekenberg wrote: > > I was using 0x00dead00 before, but Dmitry suggested 0xdeadbeef, as this > is used in most Places in wine. First, then you should really write it as such... Second, why does it *ALWAYS* have to be 0xdeadbeef? In that case there's quite some probability that you have to go on a frantic search for the *actual* place that caused Wine to crash with a 0xdeadbeef value that's being used *everywhere*... (noooooo, of couuuuurse that never happened to me...) [andi@rhlx01 wine]$ find 2>/dev/null|xargs cat 2>/dev/null|grep 0xdeadbeef|wc -l 1632 !!! Some alternatives: 0xdeadbee0 . . . 0xdeadbee9 0xcafebabe 0xcafed00d 0xdeaddead 0xc001cafe OK, as an invalid error value during winetests there is no way to mix it up, but with vtable values and many, many other places that use it that *is* an issue. Andreas -- No programming skills!? Why not help translate many Linux applications! https://launchpad.ubuntu.com/rosetta (or alternatively buy nicely packaged Linux distros/OSS software to help support Linux developers creating shiny new things for you?)

3 2

Release Information on Fedora Extras!
by Neal Gompa 27 May '06

27 May '06

I have noticed that since my post about how Fedora packages are inaccessible, you have added the string "Currently official Fedora packages lag behind, but you can get Wine-0.9.10 by running yum install wine from Fedora Extras<http://fedoraproject.org/extras/4/i386/repodata/repoview/W.group.html>." Well, that is not totally correct. Usually about a week after Wine Project releases a version, Fedora Extras updates to the newest version! Currently, it is at Wine-0.9.13. I believe it will be a week before Fedora Extras releases Wine-0.9.14 packages... I will reply when Wine packages are updated you that an accurate guage is made of the lag... The links below are to the webview of Fedora Extras: Fedora Extras for Fedora Core 5: http://download.fedora.redhat.com/pub/fedora/linux/extras/5/i386/repodata/r… Fedora Extras for Fedora Core 4: http://download.fedora.redhat.com/pub/fedora/linux/extras/4/i386/repodata/r… Fedora Extras for Fedora Core 3: http://download.fedora.redhat.com/pub/fedora/linux/extras/3/i386/repodata/r… Note that it is viewing the alphabet group of "W". Scroll down a bit and you will see Wine packages. Please keep download form updated, you make people believe that Wine is not being updated by Fedora Extras, when in fact it is...

1 2

config.status: WARNING: Make.rules.in seems to ignore the --datarootdir setting
by Gerald Pfeifer 27 May '06

27 May '06

Starting last night, or the night before, I believe, my automated testers now issue the following warning on SUSE Linux 10.1/i386, and others: config.status: WARNING: Make.rules.in seems to ignore the --datarootdir setting Is this possibly related to the following? date: 2006-05-25 21:19:35 +0200; author: julliard; state: Exp; lines: +4816 -3937 Alexandre Julliard <julliard(a)winehq.org> configure: Regenerated with autoconf 2.59d. And should we worry about it, or is there a way to disable it? Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 0

Re: DEVELOPER-HINTS: Some directories are renamed / removed / added
by Jacek Caban 27 May '06

27 May '06

Hi Detlef, Detlef Riekenberg wrote: > Changelog: > > DEVELOPER-HINTS: Some directories are renamed / removed / added > > > @@ -192,11 +194,15 @@ DLLs (under dlls/): > Winelib programs (under programs/): > ----------------------------------- > > - avitools/ - AVI information viewer and player > clock/ - Graphical clock > cmdlgtst/ - Common dialog tests > control/ - Control panel > + eject/ - Unmount and eject removable Media > expand/ - Decompress Lempel-Ziv compressed archive > + explorer/ - Desktop/Systray/HAL-Manager, Winefile-wrapper > + hh/ - Viewer for old Helpfiles > Perhaps it's not something really new, but HTML help files are newer than help files viewed by winhelp so I wouldn't call it 'old'. How about 'HTML Help viewer'? > + icinfo/ - List/Configure installed Video Compressors > + iexplore/ - Webbrowser frontend (mshtml/shdocvw) > How about 'Internet Explorer replacement'? > msiexec/ - Microsoft Installer frontend > notepad/ - Notepad replacement > progman/ - Program manager > @@ -210,6 +216,7 @@ Winelib programs (under programs/): > view/ - Metafile viewer > wcmd/ - Command line interface > wineboot/ - Wine bootstrap process > + winebrowser/ - Frontend for Webbrowsers on the Host > winecfg/ - Wine configuration utility > wineconsole/ - Console > winedbg/ - Debugger > @@ -221,6 +228,7 @@ Winelib programs (under programs/): > winevdm/ - Wine virtual DOS machine > winhelp/ - Help viewer > winver/ - Windows Version Program > + wordpad/ - Wordpad replacement skeleton > > Thanks, Jacek

1 0

[AppDB] Resend: Fix typos and grammatical errors on test result pages
by "Alexander N. Sørnes" 27 May '06

27 May '06

Is there any reason why this patch was rejected? I am not used to sending AppDB patches, so please let me know if there is something wrong with it. This patch fixes some typos reported by Rich, and a few grammatical errors I found while fixing it. Regards, Alexander N. Sørnes Index: testResults.php =================================================================== RCS file: /home/wine/appdb/testResults.php,v retrieving revision 1.3 diff -u -p -r1.3 testResults.php --- testResults.php 23 Jan 2006 02:10:31 -0000 1.3 +++ testResults.php 30 Apr 2006 11:48:05 -0000 @@ -1,6 +1,6 @@ <?php /**************************************************/ -/* code to submit, view and resubmit Test Results */ +/* Code to submit, view and resubmit Test Results */ /**************************************************/ include("path.php"); @@ -111,10 +111,10 @@ if ($_REQUEST['sub']) //help - echo "<p>This is the Screen for imputting testing information so that others looking at the database will know \n"; - echo "what was working or a particular release of Wine.</p>\n"; + echo "<p>This is the screen for inputting testing information so that others looking at the database will know \n"; + echo "what was working in a particular release of Wine.</p>\n"; echo "<p>Please be as detailed as you can.</p>\n"; - echo "<p>If you can not find your distribution on the list of existing Distributions please add it add it in the \n"; + echo "<p>If you can not find your distribution in the list of existing Distributions, please add it in the \n"; echo "field provided.</p>\n\n"; if(!empty($errors)) @@ -177,7 +177,7 @@ else // if ($_REQUEST['sub']) is not def { // help echo "<div align=center><table width='90%' border=0 cellpadding=3 cellspacing=0><tr><td>\n\n"; - echo "<p>This is the list of Test Results waiting for submition, or to be deleted.</p>\n"; + echo "<p>This is the list of Test Results waiting for submission, or to be deleted.</p>\n"; echo "<p>To view a submission, click on its name. From that page you can delete or edit and\n"; echo "re-submit it into the AppDB .<br>\n"; echo "</td></tr></table></div>\n\n"; @@ -200,7 +200,7 @@ else // if ($_REQUEST['sub']) is not def echo "<div align=center><table width='90%' border=0 cellpadding=3 cellspacing=0><tr><td>\n\n"; echo "<p>This is the list of Rejected Test Results waiting for re-submition or deletion.</p>\n"; echo "<p>To view a submission, click on its name. From that page you can delete or edit and re-submit it into \n"; - echo "the AppDB .<br>\n"; + echo "the AppDB.<br>\n"; echo "</td></tr></table></div>\n\n"; $oTest->ShowListofTests($hResult,"Rejected Testing Results");

3 3

patch submission
by EA Durbin 27 May '06

27 May '06

Is there any way to expedite the patch submission process. I submitted a patch to wine-patches quite a while ago for the AppDB TestResulsts.php page as outlined in bug 5155. How long does this take to implement?

3 2

InstallFiles() MSI
by EA Durbin 27 May '06

27 May '06

I forgot to assign my previousDiskID Last Sequence in the last example, which is the most important part. it should be fairly easy to rewrite the installer to work the correct way and Install the files in the correct order. This should also make it feasable to write the Disk Prompt and have it in the right location as it will traverse the Install media in the correct order. I'm going to work on it this weekend some time, but I'll need help cleaning up my code to make it wine worthy as this will be my first attempt at a patch. Here is some pseudo code, explaining how I think it should work. Let me know if I'm wrong or you have any suggestions. In InstallFiles() it will need to execute step 1 and create the folders as it currently does. Then for step 2 do the following - 1. initialize the DiskId to 1. Initialize the previous diskId-lastSequence to 0. 2. Query the total number or DiskIds from the media table. 3. Loop through DiskId until Total Disk Id is reached. foreach ( DiskId ) { select * from media where DiskId == DiskId initialize LastSequence to that of LastSequence column in Media Table cabinet = cabinet column print out, changing media to "Name of Cabinet" - Disk Prompt Here for the current DiskId check to make sure the lastSequence is > previous diskId sequence if ( lastSequence < previousDiskIdSeq ) { skip this install media next DiskId } else { Here call a function to iterate current install Medium IterateInstallMedia(LastSeq, cabinet); --in this function select * from file table where Sequence < lastSequence order by Sequence then iterate through the file table for the current install medium and extract the files from the cabinet and copy files. } previous-DiskIDSequnce = LastSequence. DiskId++; }

1 0

MSI Installfiles rewrite
by EA Durbin 27 May '06

27 May '06

it should be fairly easy to rewrite the installer to work the correct way and Install the files in the correct order. This should also make it feasable to write the Disk Prompt and have it in the right location as it will traverse the Install media in the correct order. I'm going to work on it this weekend some time, but I'll need help cleaning up my code to make it wine worthy as this will be my first attempt at a patch. Here is some pseudo code, explaining how I think it should work. Let me know if I'm wrong or you have any suggestions. In InstallFiles() it will need to execute step 1 and create the folders as it currently does. Then for step 2 do the following - 1. initialize the DiskId to 1. Initialize the previous diskId-lastSequence to 0. 2. Query the total number or DiskIds from the media table. 3. Loop through DiskId until Total Disk Id is reached. foreach ( DiskId ) { select * from media where DiskId == DiskId initialize LastSequence to that of LastSequence column in Media Table cabinet = cabinet column print out, changing media to "Name of Cabinet" - Disk Prompt Here for the current DiskId check to make sure the lastSequence is > previous diskId sequence if ( lastSequence < previousDiskIdSeq ) { DiskId++ } else { Here call a function to iterate current install Medium IterateInstallMedia(LastSeq, cabinet); --in this function select * from file table where Sequence < lastSequence order by Sequence then iterate through the file table for the current install medium and extract the files from the cabinet and copy files. } DiskId++; }

1 0

d3d "regression suite"
by Louis. Lenders 26 May '06

26 May '06

Hi, i got a bit tired of testing all the samples from DX8 SDK, and www.codesampler.com and more , over and over again, so i'll try to put them all together in one 'automated' suite. Here's first attempt with about 15 samples from DX8 SDK: http://www.yousendit.com/transfer.php?action=check_download&ufid=6E564CD823… I recompiled the samples so they will run for about 3 secs (one takes a lot more time) Goal is to look for regressions: if samples start crashing i can search the log for unhandled page faults, and if samples throw up messageboxes , the suite will just stop. For visual regressions you'd just have to watch them :(. By hitting escape you can walk through the samples just quickly, if you do nothing it takes about 2 minutes to rush through the samples. I'll add codesamplers dx8 samples next, any additions from others appreciated! (to test just do sh test.sh). If others find it usefull i can put it up somewhere else... --------------------------------- Try the all-new Yahoo! Mail . "The New Version is radically easier to use" The Wall Street Journal

1 0

Re: Picasa for Linux available!
by Nick Law 26 May '06

26 May '06

Another quick note.... just saw the mistake I made with the URL, so here it is again ... This URL will display the pages in English but will not allow the download to take place ... so read about it here .... http://www.freeproxy.us/index.php?q=aHR0cDovL3BpY2FzYS5nb29nbGUuY29tL2xpbnV… then click on this link to download the same thing in French but this URL will allow the download .. http://translate.google.com/translate?u=http%3A%2F%2Fpicasa.google.com%2Fli… Nick Law wrote: > Thanks Dan, impressive program. That link seems to be down though, as > of 26/May/06 11:00GMT, however I downloaded and installed the latest > version of Picasa for windows and ran it on wine 0.9.14 and it seems > to run very well, there is a few fixme's but so far everything seems > to work although I haven't by any means used all it's features > (there's a lot of them). > > On the google picasa group, > http://groups.google.com/group/Google-Labs-Picasa-for-Linux?lnk=srg > there is also some mention of the link being down but only for outside > the US, so here's a backdoor if the link doesn't work for you and your > not in the US. > http://groups.google.com/group/Google-Labs-Picasa-for-Linux?lnk=srg > (It's a bit slow but seemed to work, just give it time) > > Nick > > > Dan Kegel wrote: >> Google has indeed been working on Picasa, and it's finally available for >> download at >> http://labs.google.com/ >> >> For the curious, here are a few tidbits about how it came to be. >> >> When Google wanted to port Picasa to Linux, they faced a >> problem: the Picasa team was busy working on new projects, and >> having them also do a native port would have taken a while. >> As an experiment, Google decided to give Wine a try. >> A quick look showed that much of Picasa already worked, >> but key features were missing: the IWebBrowser API, SSL, >> scanner/camera support, removable media notification (so you can >> insert a flash drive and have Windows notice it right away), >> and change notification (so Windows can notify apps when new >> files are created), among others. Fortunately, Wine was >> already halfway to having an implementation of IWebBrowser >> thanks to Jacek Caban's Summer of Code 2005 project. And all >> that other stuff couldn't be *that* hard, right? :-) So >> Google engaged Codeweavers to add those features and fix any >> other bugs. This resulted in tons of improvements to Wine (see >> the list at code.google.com/wine.html), all of which are now in >> the public tree at winehq.org. >> >> Many people assume that when porting a Windows app to Linux >> using Wine, the best thing to do is link Winelib into the >> application to create a native Linux application. Not so! >> It's just as effective, and a heck of a lot easier, to run >> the same binary on both Windows and Wine. So that's what the >> Picasa team did. Picasa for Linux uses slightly different >> text messages, but the .exe file is identical for both Windows >> and Linux. >> >> Toward the very end, everything was looking great except >> that the initial assumption that most cameras emulate storage >> devices turned out to be wrong. Fortunately, Marcus Meissner >> just happened to decide to implement libgphoto support; his >> patch appeared at the perfect moment, and now Picasa supports >> both common flavors of cameras. >> >> Two features left out of the Linux version were CD-ROM >> burning (the driver Picasa uses is hard to support under Wine) >> and movie playback (Wine doesn't have the necessary codecs). >> Both are potentially fixable in a future version, but were >> beyond the scope of this first port. >> >> One interesting challenge when shipping commercial apps for >> Linux is packaging -- do you choose RPM or Debian packages, >> or do you use a WIndows-style installer? The Picasa for >> Linux team chose all three, in hopes of pleasing everybody. >> (Let's see how well *that* works :-) The Windows-style >> installer was implemented using the open-source Loki installer, >> and a few patches were contributed back for that, too. >> >> The Picasa for Linux team had a blast. It's not often you >> get to pour resources into a vital open source project to help >> ship a commercial application! We hope we get to do it again >> sometime soon, and we hope the results are good enough to >> encourage other companies to give Wine a try. >> >> Thanks to the Wine community for a very capable platform! >> - Dan >> >> >> >> > >

3 11

bug irony - bug in firefox or xorg
by EA Durbin 26 May '06

26 May '06

While browsing the bug database I discovered a bug, in which my x server crashes when i use the side horizontal scrollbar in firefox. I was browsing this attachment in firefox http://bugs.winehq.org/attachment.cgi?id=2517&action=view Can anyone replicate this bug?, I'm not sure whether to submit this bug to firefox or xorg. It crashes at the same point every time, when I try to use the horizontal scrollbar on this page. I opened firefox in the console and output the text to a file, upon logging back in to x i opened this file and had a message saying firefox lost the x session. I don't know if the bug resides in firefox or X?

4 3

Multiple copies of a single message...
by Saulius Krasuckas 26 May '06

26 May '06

Someone long ago asked for a copies of email msgs (from the list) which repeats in a row. Now I've got ~7 of them from Jason Green addressed for wine-devel@. (2nd of them deleted before I saw the rest) Now, may the masters of email administration look at the attached stuff and find out the reason for this is happening? Please somebody :)

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel