- wine-devel - winehq.org

Re: x11drv fix for bug#4506: page fault on read access
by Alexandre Julliard 02 Mar '06

02 Mar '06

Rein Klazes <wijn(a)wanadoo.nl> writes: > Fixing bug #4506: unaligned 32bit access, can access one byte beyond the > pixel buffer. > > Changelog: > dlls/x11drv : dib_convert.c > Avoid unaligned 32 bit reads, and reads beyond the input pixel buffer in > the convert_888_to_0888_* functions. This will badly hurt performance, you don't want to check alignment on every pixel. You should only check on the first one and copy 1 to 3 pixels as needed to align things properly, then do the 4 pixels at a time thing. -- Alexandre Julliard julliard(a)winehq.org

3 2

[wined3d] glStencilOpSeparate & glStencilFuncSeparate symbol errors
by Aric Cyr 02 Mar '06

02 Mar '06

The recent patch: http://winehq.org/pipermail/wine-patches/2006-February/024656.html can cause linker errors for the two symbols glStencilOpSeparate and glStencilFuncSeparate. The reason being that these are only exported in OpenGL 2.0 compatible libraries, and in particular, are not present in ATI's binary driver. This causes wined3d to fail to build (compiles fine but linking fails). I suspect that Vitaly is already working on fixing this, but thought I'd mention it anyways since other might run into the same problem. Cheers, Aric

1 0

Re: [PATCH 2/3] [Dnsapi.dll] Implement Dnsapi.dll
by Mike McCormack 02 Mar '06

02 Mar '06

MattK wrote: > +BOOL WINAPI DnsNameCompare_A(LPSTR pName1, LPSTR pName2) > +{ > + TRACE("(%s %s)\n",pName1, pName2); > + > + LPSTR name1 = pName1; > + LPSTR name2 = pName2; > + > + RemovePeriods(name1); > + RemovePeriods(name2); > + > + int equal; > + > + equal = lstrcmpiA(name1,name2); > + > + return !equal; > +} This is still not correct. You can't modify name1, and name2 in place. You shouldn't use inline declarations (ie. the "int equal" should be after the bracket.) There's also no in assigning pName1 to name1, it doesn't make a copy of the string as you suspect, it makes a copy of the pointer to the string. > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} You SetLastError or return an error code, not both. > diff -Nu dlls/dnsapi/utils.c dlls/dnsapi/utils.c There's no need to make a seperate file for this. > +LPSTR RemovePeriods(LPSTR string) > +{ > + if(string == NULL) > + return NULL; > + DWORD d = 0; > + > + while(string[d] == '.') > + { > + string--; > + } > + > + return string; > +} This won't work at all... If you wrote some better test cases you would discover these problems. How about testing: DnsNameCompare_A(NULL, NULL) DnsNameCompare_A("", ".") DnsNameCompare_A("..........", "..........") DnsNameCompare_A(".a.b.c.d.e.", "abcde") DnsNameCompare_A("a.com.","a.com") DnsNameCompare_A("A.com", "a.com") DnsNameCompare_A(".A.com", "a.com") DnsNameCompare_A("Acom", "acom") etc. Mike

1 0

Re: wined3d: Fix compile for older OpenGL headers.
by H. Verbeet 01 Mar '06

01 Mar '06

Although #ifdef GL_VERSION_2_0 will make compilation work with older OpenGl headers, it's not the way to fix this. Basically, wined3d should check for functionallity during runtime with GL_SUPPORT and call extensions with GL_EXTCALL. The issue has come up a few times before with patches from the same author, and I think he should be aware of the issue by now.

3 3

Re: Alexandre Julliard : configure: Use --rpath if supported when building binaries to point to
by Vitaly Lipatov 01 Mar '06

01 Mar '06

We need a --disable-rpath option in configure for rpath disable. Rpaths is not useful when WINE building for distribution. Will I add --disable-rpath of there is a better suggestion? В сообщении от 20 февраля 2006 14:40 Alexandre Julliard написал(a): ... > configure: Use --rpath if supported when building binaries to point to > the relative location of the wine libraries. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

4 11

Re: [PATCH 1/4] [WineDbg]: main_loop
by Alexandre Julliard 01 Mar '06

01 Mar '06

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > - split dbg_main_loop in two parts (one for finishing the debuggee > attachment, the second one really for handling the main loop) > - removed now longer needed dbg_main_loop Auto mode is still broken with this patch... did you really test it? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wined3d: Implemented WINED3DRS_DEPTHBIAS
by H. Verbeet 01 Mar '06

01 Mar '06

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > + glPolygonOffset(*((float*)&This->stateBlock->renderState[WINED3DRS_SLOPESCALEDEPTHBIAS]), tmpvalue.f); Does this compile?

1 0

Re: wined3d: Add function pointers to glSupportOpSeparate and glSupportFuncSeparate
by H. Verbeet 01 Mar '06

01 Mar '06

On 01/03/06, Vitaly Budovski <vbudovsk(a)cs.rmit.edu.au> wrote: > wined3d: Add function pointers to glSupportOpSeparate and > glSupportFuncSeparate > That's not going to help much if you don't actually use them. Also, you probably want to be able to detect if the functions are actually available, instead of just dereferencing a NULL pointer if they aren't.

1 0

Re: riched20: EM_AUTOURLDETECT/EM_GETAUTOURLDETECT implementation
by Alexandre Julliard 01 Mar '06

01 Mar '06

Brandon Woodmansee <bwood(a)ucla.edu> writes: > + case EM_AUTOURLDETECT: > + { > + if (wParam==1) > + { > + editor->AutoURLDetect_bEnable=1; > + return 0; > + } > + > + if (wParam==0) > + { > + editor->AutoURLDetect_bEnable=0; > + return 0; > + } > + return E_INVALIDARG; E_INVALIDARG is a pretty strange return value for a window procedure. Do you have a test case for that? -- Alexandre Julliard julliard(a)winehq.org

1 0

libxml2 use in Wine?
by Gerald Pfeifer 01 Mar '06

01 Mar '06

A user reported that when he has libxml2 installed when building Wine, "some apps" work fine whereas without libxml2 he get's warning and errors and reduce functionality. And indeed the configure code and some other part of Wine do refer to libxml2. However, there is now documentation (as verified via `grep -ri libxml2`) that mentions libxml2 in any way. Is there any specific reason, or is this just an omission, and a patch to wine/README would be welcome? Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

3 3

[Dnsapi.dll] Implement Dnsapi.dll
by MattK 28 Feb '06

28 Feb '06

> Please submit a seperate patch for the windns.h header file. In order for the patch to compile you need the windns.h header. > Hmmm. The Windows Platform SDK doesn't define this function as WINAPI. In WinDNS.h in the PSDK include directory, it is declared as BOOL WINAPI. > Maybe cdecl instead, if the Platform SDK header is right? Nope. WINAPI is just another name for __stdcall. I'll do everything you suggested. If you want to compile the patch you will need the separate patch for windns.h.

1 0

Improving WineFile
by Evgeny F 28 Feb '06

28 Feb '06

Hi there! Does anybody working on winefile right now? I would like to implement some features, currently reported as unimplemented. (for example create directory dialog) If anybody is doing it right now, please contact to avoid duplicated efforts. Yours truly, Evgeny F

2 1

WineFile improvements
by John Len 28 Feb '06

28 Feb '06

Hi there! Is anybody working on winefile right now? I would like to implement some of its features currently marked as unimplemented (like Create Directory). So if anybody is working on it, please contact me in order to avoid duplicating efforts. Yours truly, Evgeny F

1 0

(no subject)
by W.M. Horst 28 Feb '06

28 Feb '06

I was installing "ls2004.exe" (Lan Suite) from http://www.software602.com on a Slackware Linux 10.2 system using wine 0.98 from your website when at the end of the installation this error was coming up ! Error Code: -5011 : 0x80020005 Error Information: >Kernel\TextSubstitution.cpp (292) >SetupDLL\SetupDLL.cpp (524) PAPP:602LAN SUITE PVENDOR:Software602 (www.software602.com) PGUID:40302AB2-A711-11D7-B6B5-0003476E88E5 $7.1.100.1248PAK @Windows 2000 Service Pack 4 (2195) BT_OTHER 30065.16410 I hope you can download and install and test this Lan Suite so that it will work in wine-1.0 WMH

2 1

Re : wine ls2004.exe
by W.M. Horst 28 Feb '06

28 Feb '06

Here is the command line captur of ls2004.exe installation that failed right at the end ! Using Slackware 10.2 and Wine-0.98, hope you can fix it for the Wine-1.0 root@wmh:~# wine ls2004.exe fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:RpcChannelBuffer_GetDestCtx (0x4230f198,0x4230f19c), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x4230f194,0x4230f198), stub! fixme:win:SetWindowTextA setting text "Software602" of other process window (nil) should not use SendMessage fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd508,0x406bd50c), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd3e8,0x406bd3ec), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bdaac,0x406bdab0), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd98c,0x406bd990), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd794,0x406bd798), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd674,0x406bd678), stub! fixme:x11drv:X11DRV_SetWindowRgn not supported on other thread window 0x30022 fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd910,0x406bd914), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd7f0,0x406bd7f4), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd910,0x406bd914), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd7f0,0x406bd7f4), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd910,0x406bd914), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd7f0,0x406bd7f4), stub! fixme:win:SetWindowTextA setting text "602LAN SUITE 2004 (2004.0.05.0803) " of other pr ocess window (nil) should not use SendMessage fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bdab8,0x406bdabc), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd998,0x406bd99c), stub! fixme:ole:VARIANT_UserFree handle unknown complex type fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bdab8,0x406bdabc), stub! fixme:ole:RpcChannelBuffer_GetDestCtx (0x406bd998,0x406bd99c), stub! err:ole:marshal_object object doesn't expose interface {be6115a1-7de5-48dc-ad2a-25060e00f ce2}, failing with error 0x80004002 err:ole:ClientIdentity_QueryMultipleInterfaces IRemUnknown_RemQueryInterface failed with error 0x80004002 err:ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_VARIANT from VT_BSTR wine: Unhandled page fault on read access to 0x00300030 at address 0x300030 (thread 000b) Well hope it can be usefull for your team ! WMH

1 0

cvs build fails
by Christian Gmeiner 28 Feb '06

28 Feb '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 make[2]: Entering directory `/home/austriancoder/development/wine/dlls/wined3d' ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./wined3d.spec basetexture.o cubetexture.o device.o directx.o drawprim.o indexbuffer.o pixelshader.o query.o resource.o stateblock.o surface.o swapchain.o texture.o utils.o vertexbuffer.o vertexdeclaration.o vertexshader.o volume.o volumetexture.o wined3d_main.o -o wined3d.dll.so -L../../dlls -L../../dlls/user32 - -L../../dlls/gdi32 -L../../dlls/advapi32 -L../../dlls/kernel32 -luser32 - -lgdi32 -ladvapi32 -lkernel32 -L../../libs/wine -lwine -luuid -lSM - -lICE -lXxf86dga -lXxf86vm -lXext -lX11 -lGL -lGLU -L../../libs/port - -lwine_port device.o: In function `IWineD3DDeviceImpl_SetRenderState': /home/austriancoder/development/wine/dlls/wined3d/device.c:3770: undefined reference to `glStencilOpSeparate' /home/austriancoder/development/wine/dlls/wined3d/device.c:3799: undefined reference to `glStencilFuncSeparate' collect2: ld gab 1 als Ende-Status zurÃ¼ck - -- Christian Gmeiner - student of computer science http://dxr3plugin.sf.net http://itb04.ath.cx http://javamill.ath.cx -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFEBGGdDwe2AbwGBA8RAik/AJ9KYo38XkVojj6klecVd7NzMsAUuACeIm7z 3gkx7axC0uKtlFbZm1wstVw= =Z3Kf -----END PGP SIGNATURE-----

2 1

A small problem that should be fixed ASAP
by Neal Gompa 28 Feb '06

28 Feb '06

The Win32 programs that come with Wine, with the exception of the Task Manager, seems to take on Windows's info box instead of using its own... AND it says "Microsoft(R) WINE".... That is definitely not good.... Check it out by downloading the Windows binaries off the download page.... They need to be fixed...

2 1

error 3633
by Martin Jorge Bayo 28 Feb '06

28 Feb '06

---------- Forwarded message ---------- From: Martin Jorge Bayo <martin.bayo(a)gmail.com> Date: 28-feb-2006 8:15 Subject: error 3633 To: wine-users(a)winehq.org Hi, Any can help me fixme:ole:CoRegisterMessageFilter stub fixme:heap:RtlCompactHeap stub fixme:heap:RtlCompactHeap stub fixme:heap:RtlCompactHeap stub fixme:heap:RtlCompactHeap stub fixme:heap:RtlCompactHeap stub wine: Unhandled page fault on write access to 0x414b03f1 at address 0x41c3b051 (thread 000d), starting debugger... WineDbg starting on pid 0xc Unhandled exception: page fault on write access to 0x414b03f1 in 32-bit code (0x41c3b051). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:41c3b051 ESP:406dfa8c EBP:406dfadc EFLAGS:00210206( - 00 - RIP1) EAX:403b8368 EBX:414b03b0 ECX:41c3e969 EDX:414b0b98 ESI:740d5478 EDI:414b0b38 Stack dump: 0x00000000: 00000000 00000000 00000000 00000000 0x00000010: 00000000 00000000 00000000 00000000 0x00000020: 00000000 00000000 00000000 00000000 0x00000030: 00000000 00000000 00000000 00000000 0x00000040: 00000000 00000000 00000000 00000000 0x00000050: 00000000 00000000 00000000 00000000 Backtrace: =>1 0x41c3b051 (0x41c3b051) fixme:dbghelp:sffip_cb NIY on 'msvbvm50.pdb' 2 0x740e3277 in msvbvm50 (+0x23277) (0x740e3277) 3 0x740f6f85 in msvbvm50 (+0x36f85) (0x740f6f85) 4 0x740d44dc in msvbvm50 (+0x144dc) (0x740d44dc) 5 0x7410347f in msvbvm50 (+0x4347f) (0x7410347f) 6 0x740c3ac3 in msvbvm50 (+0x3ac3) (0x740c3ac3) 7 0x740c37ef in msvbvm50 (+0x37ef) (0x740c37ef) 8 0x4079f2da WINPROC_wrapper in user32 (0x4079f2da) 9 0x4079fd3a in user32 (+0x9fd3a) (0x4079fd3a) 10 0x407a5ea5 CallWindowProcA in user32 (0x407a5ea5) 11 0x4076d009 in user32 (+0x6d009) (0x4076d009) 12 0x407731bb SendMessageTimeoutA in user32 (0x407731bb) 13 0x407733fc SendMessageA in user32 (0x407733fc) 14 0x740d6ef1 in msvbvm50 (+0x16ef1) (0x740d6ef1) 15 0x740cff9d in msvbvm50 (+0xff9d) (0x740cff9d) 16 0x740ca583 in msvbvm50 (+0xa583) (0x740ca583) 17 0x00000003 (0x00000003) 0x41c3b051: andl %ecx,0x41(%ebx) Modules: Module Address Debug info Name (87 modules) PE 0x00400000-00ee9000 Deferred sigae_desktop PE 0x0f640000-0f65c000 Deferred vb5es PE 0x10000000-100b8000 Deferred ares~mvy PE 0x1b740000-1b7c8000 Deferred dao360 ELF 0x40000000-40018000 Deferred ld-linux.so.2 ELF 0x4002c000-40046000 Deferred libwine.so.1 ELF 0x40046000-40058000 Deferred libpthread.so.0 ELF 0x40058000-40171000 Deferred libc.so.6 ELF 0x40171000-40175000 Deferred libdl.so.2 ELF 0x40176000-401f3000 Deferred ntdll<elf> \-PE 0x40190000-401f3000 \ ntdll ELF 0x40206000-402fc000 Deferred libwine_unicode.so.1 ELF 0x402fc000-4031f000 Deferred libm.so.6 ELF 0x40470000-40578000 Deferred kernel32<elf> \-PE 0x40490000-40578000 \ kernel32 ELF 0x406e0000-40811000 Export user32<elf> \-PE 0x40700000-40811000 \ user32 ELF 0x40811000-41208000 Deferred gdi32<elf> \-PE 0x40830000-41208000 \ gdi32 ELF 0x412d9000-412e1000 Deferred libgcc_s.so.1 ELF 0x412e1000-41322000 Deferred advapi32<elf> \-PE 0x412f0000-41322000 \ advapi32 ELF 0x41322000-413b7000 Deferred ole32<elf> \-PE 0x41340000-413b7000 \ ole32 ELF 0x413b7000-41402000 Deferred rpcrt4<elf> \-PE 0x413d0000-41402000 \ rpcrt4 ELF 0x41402000-41420000 Deferred iphlpapi<elf> \-PE 0x41410000-41420000 \ iphlpapi ELF 0x41420000-414ba000 Deferred oleaut32<elf> \-PE 0x41440000-414ba000 \ oleaut32 ELF 0x414cd000-4153c000 Deferred libfreetype.so.6 ELF 0x4153c000-4156a000 Deferred libfontconfig.so.1 ELF 0x4156a000-41589000 Deferred libexpat.so.0 ELF 0x41589000-4160d000 Deferred winex11<elf> \-PE 0x415a0000-4160d000 \ winex11 ELF 0x4160d000-4160f000 Deferred xlcutf8load.so.2 ELF 0x41620000-41628000 Deferred libsm.so.6 ELF 0x41628000-41640000 Deferred libice.so.6 ELF 0x41640000-41646000 Deferred libxxf86dga.so.1 ELF 0x41646000-4164b000 Deferred libxxf86vm.so.1 ELF 0x4164b000-41659000 Deferred libxext.so.6 ELF 0x41659000-41755000 Deferred libx11.so.6 ELF 0x41755000-417c2000 Deferred libgl.so.1 ELF 0x417c2000-417ca000 Deferred libxrender.so.1 ELF 0x417ca000-417ce000 Deferred libxrandr.so.2 ELF 0x417ce000-417ed000 Deferred ximcp.so.2 ELF 0x4183d000-4185a000 Deferred imm32<elf> \-PE 0x41840000-4185a000 \ imm32 ELF 0x4186d000-41876000 Deferred libxcursor.so.1 ELF 0x41c03000-41c22000 Deferred libjpeg.so.62 ELF 0x41da3000-41e2c000 Deferred winmm<elf> \-PE 0x41db0000-41e2c000 \ winmm ELF 0x41e2c000-41eca000 Deferred comdlg32<elf> \-PE 0x41e40000-41eca000 \ comdlg32 ELF 0x41eca000-41f9a000 Deferred shell32<elf> \-PE 0x41ee0000-41f9a000 \ shell32 ELF 0x41f9a000-41ff7000 Deferred shlwapi<elf> \-PE 0x41fb0000-41ff7000 \ shlwapi ELF 0x41ff7000-420b8000 Deferred comctl32<elf> \-PE 0x42000000-420b8000 \ comctl32 ELF 0x420b8000-420e4000 Deferred winspool<elf> \-PE 0x420c0000-420e4000 \ winspool ELF 0x420e4000-420f8000 Deferred olepro32<elf> \-PE 0x420f0000-420f8000 \ olepro32 ELF 0x420f8000-42140000 Deferred wininet<elf> \-PE 0x42100000-42140000 \ wininet ELF 0x42140000-4215f000 Deferred mpr<elf> \-PE 0x42150000-4215f000 \ mpr ELF 0x4215f000-421a4000 Deferred wineoss<elf> \-PE 0x42170000-421a4000 \ wineoss ELF 0x421a4000-421bc000 Deferred msacm<elf> \-PE 0x421b0000-421bc000 \ msacm ELF 0x421bc000-421e3000 Deferred msacm32<elf> \-PE 0x421c0000-421e3000 \ msacm32 ELF 0x42300000-42315000 Deferred midimap<elf> \-PE 0x42310000-42315000 \ midimap ELF 0x42315000-42347000 Deferred uxtheme<elf> \-PE 0x42320000-42347000 \ uxtheme ELF 0x423b3000-423d0000 Deferred libcups.so.2 ELF 0x423d0000-42400000 Deferred libssl.so.0.9.7 ELF 0x42400000-424f3000 Deferred libcrypto.so.0.9.7 ELF 0x424f3000-424fd000 Deferred libnss_files.so.2 ELF 0x427a8000-427ab000 Deferred iso8859-1.so ELF 0x427ab000-4280d000 Deferred msvcrt<elf> \-PE 0x427c0000-4280d000 \ msvcrt PE 0x740c0000-7420d000 Export msvbvm50 ELF 0x7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 0000000c (D) Y:\.wine\drive_c\Archivos de programa\Sigae\SIGAE_Desktop.exe 0000000d 0 <== WineDbg terminated on pid 0xc

2 1

Re: [PATCH 5/8] [WineDbg]: main_loop
by Alexandre Julliard 28 Feb '06

28 Feb '06

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > - split dbg_main_loop in two parts (one for finishing the debuggee > attachment, the second one really for handling the main loop) > - removed now longer needed dbg_main_loop This doesn't compile, you still have references to dbg_main_loop. -- Alexandre Julliard julliard(a)winehq.org

1 0

./configure message
by dmitry serpokryl 28 Feb '06

28 Feb '06

configure: WARNING: linux/capi.h: present but cannot be compiled configure: WARNING: linux/capi.h: check for missing prerequisite headers? configure: WARNING: linux/capi.h: see the Autoconf documentation configure: WARNING: linux/capi.h: section "Present But Cannot Be Compiled" configure: WARNING: linux/capi.h: proceeding with the preprocessor's result configure: WARNING: linux/capi.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## SuSE 10 x86-64, gcc-4.0.2 (release)

4 4

Re: [Dnsapi.dll] Implement Dnsapi.dll
by Mike McCormack 28 Feb '06

28 Feb '06

MattK wrote: > This is a patch to implement Dnsapi.dll. It contains "bare bones". Please submit a seperate patch for the windns.h header file. > @@ -1193,6 +1193,7 @@ AC_CHECK_FUNCS(\ > strcasecmp \ > strerror \ > strncasecmp \ > + strsep \ Adding strsep here doesn't guarantee that it will exist. You need to check usage with #ifdef HAVE_STRSEP, or just assume it's always there and remove the configure check (prefered). Looks like that code is using tab indent too, so if this was needed, you should use the same to keep it consistent. > RCS file: /home/wine/wine/dlls/Makefile.in,v This is automatically generated. No patch is needed. > +DNS_STATUS WINAPI DnsValidateName_A(LPCSTR pszName, DNS_NAME_FORMAT); Hmmm. The Windows Platform SDK doesn't define this function as WINAPI. > +# Generated from /mnt/windows/windows/system32/dnsapi.dll by winedump This comment is unnecessary. > +107 stdcall DnsValidateName_A(str long) Maybe cdecl instead, if the Platform SDK header is right? > +EXTRALIBS = -lc Pretty sure libc is linked by default, so you don't need to add it. > + /* The Platform SDK documentation for this says that it ignores all periods. */ > + /* So there's gonna be no periods! */ > + > + if(dots1 && dots2) > + { > + strsep(&name1,dots1); > + strsep(&name2,dots2); > + pName1 = name1; > + pName2 = name2; > + } This ignores the first period and everything after it. It also modifies the input (ie. the program's copy of the string). > + equal = strcmp(pName1,pName2); Probably better to use lstrcmpA to use the Wine codepage. > + if(equal == 0) > + { > + return TRUE; > + } > + > + if(equal > 0 || equal < 0) > + { > + return FALSE; > + } > +} How about "return !equal;" ? It would be nice if you could write a test case for DnsNameCompare_A. If you do, please submit it seperately from the rest of the patch. Thanks for the patch! Mike

1 0

Re: [PATCH 06/12] [WineDbg]: rewrite auto mode
by Alexandre Julliard 27 Feb '06

27 Feb '06

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > @@ -880,7 +861,14 @@ enum dbg_start dbg_active_launch(int > */ > enum dbg_start dbg_active_auto(int argc, char* argv[]) > { > + HANDLE hFile; > + > argc--; argv++; > - dbg_action_mode = automatic_mode; > - return dbg_active_attach(argc, argv); > + hFile = parser_generate_command_file("echo Modules:", "info share", > + "echo Threads:", "info threads", > + NULL); > + if (hFile == INVALID_HANDLE_VALUE || !dbg_active_attach(argc, argv)) > + return FALSE; > + dbg_main_loop(hFile); > + return TRUE; > } This completely breaks auto mode, because dbg_active_attach returns an enum dbg_start, not a boolean. There's the same mistake in the next patch too. -- Alexandre Julliard julliard(a)winehq.org

2 1

CRYPT32: iod.c compile problem (gcc 2.95)
by Vitaly Lipatov 27 Feb '06

27 Feb '06

I try compile last version with gcc 2.95 and get it failed: $ make gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_CRYPT32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -O2 -march=i586 -o oid.o oid.c oid.c: In function `init_oid_info': oid.c:940: structure has no member named `Algid' oid.c:969: structure has no member named `Algid' oid.c: In function `CryptFindOIDInfo': oid.c:1037: structure has no member named `Algid' oid.c:1089: structure has no member named `Algid' oid.c: In function `CertOIDToAlgId': oid.c:1126: structure has no member named `Algid' There is unnamed union, and such construction does no recognized old the compiler. What the best way to fix it? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Early warning: kernel address space change
by Andreas Mohr 27 Feb '06

27 Feb '06

Hi, FYI (just in case it happens to affect Wine): http://lkml.org/lkml/2006/2/27/159 Andreas

2 1

[Dnsapi.dll] Implement Dnsapi.dll
by MattK 27 Feb '06

27 Feb '06

This is a patch to implement Dnsapi.dll. It contains "bare bones". This was done mainly to help with Bug 4323 <http://bugs.winehq.org/show_bug.cgi?id=4323>. This patch has the DllMain entry point, a function and a stub, header files, implementation into the tree, and a .spec file. Please tell me how to correct anything if there is a problem.

1 0

DirectX 8 test: Gothic 2 on wine
by Olaf Leidinger 27 Feb '06

27 Feb '06

Hello List! Gothic2 seems to start working with wine. Well - as long as you disable sound in system/gothic.ini. There are some issues with DirectDraw/Direct3D I'd like to report (not sure if they are known): - most textures are missing - everything is really dark (I have to set gamma to 2.5 (via xgamma -gamma 2.5) ) - fonts are missing/crippled I took some pictures and put it together with a log on a simple webpage. Please have a look at http://leidola.newcon.de/gothic2 Thanks a lot for your attention, Ciao, Olaf Leidinger

5 9

ddraw.dll
by "Alexander N. Sørnes" 26 Feb '06

26 Feb '06

Hello, I have found that some Westwood installers, such as the ones for Nox, C&C Tiberian Sun, C&C Yuri's Revenge and C&C Tiberain Sun: Firestorm require ddraw.dll to be present in the windows/system 32 directory; if not, they give a message saying they failed to initialize DirectX. Can someone submit a patch so this file is created by wineprefixcreate? ddraw.dll is present system directories of both Windows 98SE and Windows XP. Regards, Alexander N. Sørnes

2 1

Windows Device driver for NTFS
by Gerold J. Wucherpfennig 25 Feb '06

25 Feb '06

Can anybody help me to code a little driver for a virtual hard disk drive for examination of undocumented NTFS filesystem stuctures i.e. the $LOGFILE (journaling of NTFS)? The data should be written to e.g. C:\image.bin, filesize e.g. 50MB which will correspond to a drive e.g. Z:, drive size 50MB. After every write the driver should be paused to examine the C:\image.bin to get the undocumented structure of the file $LOGFILE? Can anybody help me? I'm a little confused by the windows DDK documentation and tutorials found on the internet. I've already downloaded the windows DDK. Please CC me and excuse me for crossposting. Regards, Gerold

2 1

Re: [PATCH] please commit this FCI work
by Detlef Riekenberg 25 Feb '06

25 Feb '06

Am Freitag, den 24.02.2006, 14:28 +0100 schrieb Gerold J. Wucherpfennig: > Please commit. I have no knowledge about fci, but some code is strange: +#define fci_set_error(A,B,C) \ + p_fci_internal->perf->erfOper = A; \ + p_fci_internal->perf->erfType = B; \ + p_fci_internal->perf->fError = C; + You use SetLastError() for B almost everywhere following the Macro. Why not add this statement to the Macro? Exceptions where you did not use SetLastError(): Macro-Parameter B is 0 - Did you mean NO_ERROR / ERROR_SUCCESS? - Does Windows use a SetLastError(NO_ERROR) in this case? (Tests for cabinet.dll are only in one file: "extract.c". can you add tests for fci/compress?) When windows does a SetLastError(NO_ERROR): append "SetLastError(B)" to the Macro When windows does not do a SetLastError(NO_ERROR): append "if (B) SetLastError(B)" to the Macro + /* write error */ + fci_set_error( FCIERR_TEMP_FILE, ERROR_WRITE_FAULT, TRUE ); + p_fci_internal->perf->erfType = ERROR_WRITE_FAULT; + p_fci_internal->perf->fError = TRUE; + SetLastError(ERROR_WRITE_FAULT); the two p_pci_* - lines are duplicates (already done in the Macro) btw: What should be added to the changelog? cabinet/fci: cleanup error-handling with a MACRO -- By By ... ... Detlef

2 1

Diffrent behaviours of wine apps on diffrent distros
by Roland Kaser 25 Feb '06

25 Feb '06

Hello As I reported earlier I ascertained some windows apps does have diffrent behaviours on the same wine version but on diffrent linux distros. Its not fully clear to me whats the exact reason of this behaviour. Whouldn't it be a good idea to create some reference installation images (VMWare player or similar) where the application maintainers can test whose applications to have defined sandbox for reporting bugs etc? Regards Roland Kaeser

1 0

Re: D3D8 -> WineD3D ('rest')
by Stefan Dösinger 25 Feb '06

25 Feb '06

Hi, > The other two files need to be added to the d3d8 directory and replace the > current shader code. You can add new files with a patch if you do a diff -u /dev/null /dlls/d3d8/vertexshader.c.

1 0

OLE32: OpenStorage related question
by Vitaly Lipatov 25 Feb '06

25 Feb '06

I try to improve WINE's storage support for compatibility with program. I guess StgOpenStorageOnILockBytes function creates file in temp dir and mapping? ILockBytes contents to it. I can't discover case when StgOpenStorageOnILockBytes has such behaviour. Have anyone some thoughts about the topic? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

RE: [PATCH] Implement GetCurrentHwProfileA() fully
by Rolf Kalbermatter 25 Feb '06

25 Feb '06

>2. Add default registry entries for the HWLK\*\IDConfigDB\* values. > >This still results in a default profile GUID. If anyone knows a way to >generate a value for this during wineboot, that's probably the best >solution. Ole32 has a function CoCreateGuid, (basically forwarding to rpcrt4.UuidCreate that generates a (pseudo)random GUID. To mimick Windows I would say this should be done at wineinstall (or self-registration of the advapi DLL?). Rolf Kalbermatter

1 0

Re: riched20: Implements FR_MATCHCASE for EM_FINDTEXT
by Phil Krylov 25 Feb '06

25 Feb '06

On Tue, 21 Feb 2006 14:08:38 -0800 Lei Zhang <leiz(a)ucla.edu> wrote: > On Tuesday 21 February 2006 12:42 pm, you wrote: > > On Tue, 21 Feb 2006 10:19:01 -0800 > > > > Lei Zhang <leiz(a)ucla.edu> wrote: > > > - while (pCurItem && > > > pCurItem->member.run.strText->szData[nCurEnd - nMatched - 1] == > > > text[nLen - nMatched - 1]) + while > > > (ME_CharCompare(pCurItem->member.run.strText->szData[nCurEnd - > > > nMatched - 1], text[nLen - nMatched - 1], (flags & FR_MATCHCASE))) > > > > You've dropped pCurItem NULL check here. Probably just a typo... > > > > -- Ph. > > Hi Phil, > > Ya, it's a typo. Thanks for catching it. Could you kindly fix it then? As this patch was accepted unfixed. -- Ph.

3 5

getwinegit.sh 0.2
by Christian Lachner 25 Feb '06

25 Feb '06

I decided to make this release a bit more complete than the other ones i did before. Bugfree (i hope ;)) and with readme. current version is 0.2. this is the readme's content: getwinegit.sh-README :: Intro getwinegit is a script which was designed to download/update, compile and install the current wine-git-source-tree. :: Usage Usage: /usr/bin/getwinegit.sh -mode modes: -0 update the local source-tree -1 + compile the source -2 + install -3 no update; just compile the local source-tree and install -h help ;) :: Install Just copy getwinegit.sh wherever you want, make it executable and create a softlink at /usr/bin. Then (or before) configure the script by editing the variables in the head with your favourite editor. (minimum is to set ENABLE="yes") :: Changes 0.2 first stable release. :: Future? Tell me what you need and i will implement it... maybe :D :: Where are you at home? gladiac.onetrix.net :: Bugs? Report them to gladiac at gmail dot com ;) Thanks for reading, bye glad

2 4

Debugging
by Rich Gilson 24 Feb '06

24 Feb '06

I'm kind of new to the Wine schene. I've dabled in it from time to time; but, seeing the progress it has made I am making a serious effort to get my applications running through Wine rather than VMWare. As such, I'm looking for a little advice on debugging issues when apps don't work (yes, I've read what's on winehq.) I have the application KeePass (keepass.sourceforge.net) which installs just fine. When I go to run it, it just drops me right back to the prompt. With WINEDEBUG, I've tried monitoring the fixme (no results at all), ole, dll, loaddll, system, ntdll, oledlg, olerelay, and rundll32, none of which produced any output that seemed to inducate a problem. I suppose that if Wine sent it a value that it didn't like and they have really good error trapping, the apps could have just shut itself down, but I would think that something must be going wrong somewhere in Wine, but I'm at a loss as to how to find it. I have tried it with the version set to win98 as wekk as win2k and I'm running Wine 0.9.8 (without Winetools), with IE6 installed as per the instructions on appdb.winehq.com. Any advise as to what I can try next or what I should be looking for would be greatly appreciated. -- -- In a world without fences, who needs Gates?

2 2

Re: Prepare the unicodification of advpack.dll
by James Hawkins 24 Feb '06

24 Feb '06

On 2/24/06, Francois Gouget <fgouget(a)free.fr> wrote: > > All functions that manipulate strings should have an Ansi and a > Unicode variant. Does it matter that native advpack only has Ansi functions? I think we should leave it the way it is, because any application that uses advpack will only know of Ansi API and adding unicode handling adds more complexity and chances for error. -- James Hawkins

2 2

WineD3D refcounting fun part II :)
by Roderick Colenbrander 24 Feb '06

24 Feb '06

Hi, During the d3d8 -> wined3d transition I noticed one huge refcounting issue which affects both d3d8 and d3d9. The issue is illustrated by running http://www.codesampler.com/source/dx9_multitexture.zip (the same demo is available for dx8) and then modify wined3d's globalChangeGlRam in wined3d_main.c to let it output how it adjusts the memory. If you run the test on d3d9 or using oliver's full d3d8 patch, you'll notice that not all memory is returned when quitting the program. (In 3dmark2001 this is a big issue as because of this we are out of memory after running a few demos) The problem appears that wined3d surfaces contain a reference to the wined3d device. So when you run a game the d3d8 and wined3d device refcounts are out of sync (the wined3d refcount is a lot higher because of all the refcounts from the surfaces). At the moment you quit a game the d3d8 device refcount nicely becomes zero and the object tries to kill itself. The release function also calls the wined3d device release function but the wined3d device object won't kill itself because its refcount doesn't become zero due to all the surfaces which still contain a reference to it. (the surfaces which useally are front-, backbuffers and more are normally released in the wined3d device release call when the refcount becomes zero) One way to 'fix' the problem is to let d3d8/d3d9 handle the reference counts (remove the refcounts from wined3d; and let d3d8/d3d9 call some cleanup function to remove the garbage in case its refcount becomes zero) Does anyone have a better solution? Roderick

4 7

Palm Desktop conduits through Wine?
by Rich Gilson 24 Feb '06

24 Feb '06

Has there every been any luck/attempts at running Palm Desktop conduits through wine? I'd drop Palm Desktop altogether, but I have Documents-To-Go and Passwords Plus, which both only run through Palm Desktop. From what I can gather from searching around, I'm not going to get Palm Desktop to work on Wine right now, so I'm looking for other alternatives. Thanks. -- -- In a world without fences, who needs Gates?

2 1

AOL
by TWhaymand05＠aol.com 24 Feb '06

24 Feb '06

Would AOL work on WINE? I would be really greatful if you could e-mail back directly because I plaining to move to Linux within the next few days Sincely Toby

3 2

Re: Fix ExitWindows()
by Robert Shearman 24 Feb '06

24 Feb '06

Francois Gouget wrote: > >- if (SendMessageTimeoutW( *phwnd, WM_QUERYENDSESSION, 0, 0, send_flags, INFINITE, &result) && !result) break; >+ if (SendMessageTimeoutW( *phwnd, WM_QUERYENDSESSION, 0, 0, send_flags, 0, &result)) > > Was this change deliberate to remove the check of result? If so, I don't see where else the result of the message can be properly checked. -- Rob Shearman

2 2

re: Problems with Sockets and TCL
by Dan Kegel 24 Feb '06

24 Feb '06

You wrote: >I've found a bug that can be reproduced with two lines of TCL: Great! Can you post a bug report at http://bugs.winehq.org and cc me on it? Be sure to include a full recipe for reproducing the bug, especially the version of tcl and where to download it. I'm glad to see an ISV interested in supporting Wine like this! Is this official interest, or just something you're trying on the side? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

[PATCH] Implement GetCurrentHwProfileA() fully
by Ben Collins 24 Feb '06

24 Feb '06

I setup Wine mainly to make use of some online poker clients that I use a lot. I experienced some known bugs related to advapi32.dll, specifically GetCurrentHwProfileA()'s semi-stub. The first issue was that the szHwProfileGuid was being set to a string that was one byte too long. This resulted in it actually being a concantenation of szHwProfileGuid and szHwProfileName. Fixing that, programs like FullTiltPoker.exe were able to work. The website suggested changing the return value to 0 (false), but that was just so things got ignored. The second issue with this function was more related to the hard coding of the GUID. Some sites, such as PacificPoker and ParadisePoker, can and will kill user access to the site. They do not do this by username, but but the Profile GUID (I didn't realize this till I started reading bug reports, and checking things). Presumably, this reduces the chance that someone simply changes their username. They pretty much block the user's system, unless they reinstall, or manually change the GUID. Because of this, all wine installs by default are not allowed to login to these sites (it only took one person to get kicked before the GUID was dead). So, to get things done to my liking, I just bit the bullet and implemented GetCurrentHwProfileA() correctly. The patch below has two parts 1. Implement GetCurrentHwProfileA() fully. It will read the current profile (0x0000 value), and obtain the values from this profile for docking state, profile name, and profile GUID. 2. Add default registry entries for the HWLK\*\IDConfigDB\* values. This still results in a default profile GUID. If anyone knows a way to generate a value for this during wineboot, that's probably the best solution. diff -urN wine-0.9.6/dlls/advapi32/advapi.c wine-0.9.6-ben/dlls/advapi32/advapi.c --- wine-0.9.6/dlls/advapi32/advapi.c 2006-01-19 14:13:51.000000000 +0000 +++ wine-0.9.6-ben/dlls/advapi32/advapi.c 2006-02-24 02:18:26.000000000 +0000 @@ -116,11 +116,57 @@ */ BOOL WINAPI GetCurrentHwProfileA(LPHW_PROFILE_INFOA pInfo) { - FIXME("(%p) semi-stub\n", pInfo); - pInfo->dwDockInfo = DOCKINFO_DOCKED; - strcpy(pInfo->szHwProfileGuid,"{12340001-1234-1234-1234-1233456789012}"); - strcpy(pInfo->szHwProfileName,"Wine Profile"); - return 1; + CHAR profile[32]; + DWORD type; + DWORD size; + DWORD ret; + DWORD val; + HKEY hkey; + BOOL profile_result = 0; + + ret = RegOpenKeyA(HKEY_LOCAL_MACHINE, "System\\CurrentControlSet\\Control\\IDConfigDB", + &hkey); + + if (ret != ERROR_SUCCESS) + goto profile_error; + + ret = RegGetValueA(hkey, NULL, "CurrentConfig", RRF_RT_DWORD, + &type, &val, &size); + if (ret != ERROR_SUCCESS || size != 4 || type != REG_DWORD) + goto profile_error; + + /* At least, I think the profile names are hex */ + sprintf(profile, "Hardware Profiles\\%04x", (WORD)(val & 0xffff)); + + /* Set the profile name */ + size = MAX_PROFILE_LEN; + ret = RegGetValueA(hkey, profile, "FriendlyName", RRF_RT_REG_SZ, + &type, pInfo->szHwProfileName, &size); + + if (ret != ERROR_SUCCESS || type != REG_SZ) + goto profile_error; + + /* Now get the GUID of this profile */ + size = HW_PROFILE_GUIDLEN; + ret = RegGetValueA(hkey, profile, "HwProfileGuid", RRF_RT_REG_SZ, + &type, pInfo->szHwProfileGuid, &size); + + if (ret != ERROR_SUCCESS || type != REG_SZ) + goto profile_error; + + /* And finally the docking state */ + ret = RegGetValueA(hkey, "CurrentDockInfo", "DockingState", RRF_RT_DWORD, + &type, &pInfo->dwDockInfo, &size); + + if (ret != ERROR_SUCCESS || size != 4 || type != REG_DWORD) + goto profile_error; + + /* Success */ + profile_result = 1; + +profile_error: + RegCloseKey(hkey); + return profile_result; } /****************************************************************************** diff -urN wine-0.9.6/tools/wine.inf wine-0.9.6-ben/tools/wine.inf --- wine-0.9.6/tools/wine.inf 2006-01-19 14:14:43.000000000 +0000 +++ wine-0.9.6-ben/tools/wine.inf 2006-02-24 02:19:19.000000000 +0000 @@ -211,6 +211,23 @@ HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"windir",,"%10%" HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"winsysdir",,"%11%" +[IDConfigDB] +HKLM,System\CurrentControlSet\Control\IDConfigDB,"CurrentConfig",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB,"UserWaitInterval",,0x0000001e +HKLM,System\CurrentControlSet\Control\IDConfigDB,"IsPortable",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"DockingState",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"Capabilities",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"DockID",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"SerialNumber",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Alias\0000,"ProfileNumber",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles,"Unknown",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"PreferenceOrder",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"FriendlyName",,"Wine Profile" +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"Aliasable",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"Cloned",,0x00000000 +HKLM,System\CurrentControlSet\Control\IDConfigDB\Hardware Profiles\0000,"HwProfileGuid",,"{12340001-1234-1234-1234-123345678901}" + + [Fonts] HKLM,%FontSubStr%,"Arial CE,238",,"Arial,238" HKLM,%FontSubStr%,"Arial CYR,204",,"Arial,204" -- Ubuntu - http://www.ubuntu.com/ Debian - http://www.debian.org/ Linux 1394 - http://www.linux1394.org/ SwissDisk - http://www.swissdisk.com/

2 1

Re: Server Requirements
by Tony Lambregts 24 Feb '06

24 Feb '06

Gomez, Felix wrote: > Hello... > > Does Wine run on CentOS 4 (RHEL4) for IBM zSeries/s390? > You may be able to compile wine on this architecture and run Winelib applications ( http://www.winehq.org/site/docs/winelib-guide/index ) but running regular windows applications is a different matter ( http://www.winehq.org/site/docs/wine-faq/index#UNDER-WHAT-PLATFORMS-WILL-WI… ). Bochs ( http://bochs.sourceforge.net/ ) is your best bet for getting windows applications running I am not sure if anyone has actually tried to get Wine to compile on IBM zSeries/s390, you may be the first. I for one am curious about the results of an attempt. If you do try to compile wine on this machine please let us know the results. -- Tony Lambregts

1 0

Re: advpack [1/3]: Factor out loading the advpack API [RESEND]
by Alexandre Julliard 24 Feb '06

24 Feb '06

"James Hawkins" <truiken(a)gmail.com> writes: > @@ -256,21 +268,9 @@ static void translateinfstring_test() > > START_TEST(advpack) > { > - HMODULE hdll; > - > - hdll = LoadLibraryA("advpack.dll"); > - if (!hdll) > - return; > - > - pGetVersionFromFile = (void*)GetProcAddress(hdll, "GetVersionFromFile"); > - pDelNode = (void*)GetProcAddress(hdll, "DelNode"); > - pTranslateInfString = (void*)GetProcAddress(hdll, "TranslateInfString"); > - if (!pGetVersionFromFile || !pDelNode || !pTranslateInfString) > - return; > + init_function_pointers(); Why are you removing the pointer checks? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Debugging
by Juan Lang 24 Feb '06

24 Feb '06

> I appreciate the tip about falling back on the relay debug channel, > but may I ask how you know the problem is with BlockInput not existing? > Is there something from the output that I'm not understanding, or do > you just know that because you're familiar with the kernel32.dll > code? Molle's right--it just looks suspicious, since it's the last thing that's called before ExitProcess. I didn't copy-paste any more of the log, but there were a whole bunch of GetProcAddress calls prior to this that succeeded, which raises the probability that this was the cause. And, as Molle suggested, a quick glance at the kernel32 code shows that BlockInput is missing. As far as how did I spot this in the log--well, that's just experience. You can learn it pretty quickly though, especially when an app dies early. I just scroll through a log from the end toward the beginning, and look for a change in pattern on the screen. Different things are starting to happen there, so I slow down for a closer look. If it looks like normal shutdown code--and there's usually hundreds of lines of this stuff--I ignore it and move on. As far as how to deal with this, try modifying kernel32.spec to add a stub for BlockInput, like: @ stub BlockInput and see if the program gets any further. Chances are it'll crash somewhere else down the line, so you'll have to do the usual wash-rinse-repeat. You should also take a look through KeePass's source code and try to find out what's going on. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Re: Debugging
by Juan Lang 24 Feb '06

24 Feb '06

Hi Rich, the key one to use is relay. WINEDEBUG=relay tells you every API function that's called. It can be a bit overwhelming, but it's what you fall back on when nothing else is working. I downloaded and tried it, and scanned backwards in my relay trace a good distance till I saw some failure. Here's what I think it is: 0009:Call kernel32.GetProcAddress(20290000,0052b895 "BlockInput") ret=0052cc6a 0009:Call ntdll.RtlInitAnsiString(73ccfe20,0052b895 "BlockInput") ret=201d2c3e 0009:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=201d2c3e 0009:Call ntdll.LdrGetProcedureAddress(20290000,73ccfe20,00000000,73ccfe1c) ret=201d2c4d 0009:Ret ntdll.LdrGetProcedureAddress() retval=c000007a ret=201d2c4d 0009:Call ntdll.RtlNtStatusToDosError(c000007a) ret=201d2c7d 0009:Ret ntdll.RtlNtStatusToDosError() retval=0000007f ret=201d2c7d 0009:Ret kernel32.GetProcAddress() retval=00000000 ret=0052cc6a 0009:Call kernel32.ExitProcess(0052cb10) ret=0052cc7b That is, somebody's trying to get the function BlockInput from kernel32.dll, and it isn't there, so the program exits. I don't know if this is in MFC somewhere, or in the program's source. Luckily the source is available, so you might be able to proceed. Hope that helps, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Hotkey
by Christian Gmeiner 24 Feb '06

24 Feb '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all. I want to fix the hotkey stuff in user.dll. Now i have asked at xorg mail list and thy told me that i should use acpid to do hotkey stuff. Now i think we should to hotkey stuff internal in wine: Have a hash list to save hotkeys and check every time a user presses a button, if there are some pressed other too. If this is also true, look if it is a hotkey and send to the correct window the correct message. What do you think about this? Thanks, Christian - -- Christian Gmeiner - student of computer science http://dxr3plugin.sf.net http://itb04.ath.cx http://javamill.ath.cx -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFD/mWCDwe2AbwGBA8RArAOAJ9mfjNBHsdyafLp2exPmY5idH/iFwCfQUjV 4volZ4aoTZNXNxQUtLQCszw= =W3ub -----END PGP SIGNATURE-----

1 0

Guitar Rig 2 in Linux/Wine
by Michael Ost 23 Feb '06

23 Feb '06

We are interested in getting the new Guitar Rig 2 USB foot controller supported in Linux/Wine. It's described here: http://www.native-instruments.com/index.php?id=guitarrig2_us I assume from looking at it, that a USB driver would be required and then perhaps some Wine tweaks to let the plugin open the USB driver. Anyone interested in taking this on? We are hoping to do this as a trade --- like you do this work and get a Receptor and/or some VST plugins for your time. BTW, we also have a job opening, posted here: http://www.craigslist.org/pen/sof/132110028.html Thanks ... mo =================================== Michael Ost, Software Architect Muse Research, Inc. most(a)museresearch.com

2 2

Idea for reducing the number of duplicate bugs
by Tom Spear 23 Feb '06

23 Feb '06

---------- Forwarded message ---------- From: Tom Spear <speeddymon(a)gmail.com> Date: Feb 23, 2006 3:46 PM Subject: Re: Idea for reducing the number of duplicate bugs To: n0dalus <n0dalus+wine(a)gmail.com> Ok ok, maybe not an alert. I still think something saying to check the appdb would help, cause then when they read the appdb, they can see that there is already a bug filed for that specific issue, and can post notes to that bug instead of filing a new one.. Sure some users will still file a new one, not paying attention, but it will cut down.. Another thing I think we should do, for the users that do read the docs, is to put a comprehensive guide to searching for a bug in either the FAQ and/or the wine/developer userguide(s), as the bug search form does look a little intimidating. Tom On 2/23/06, n0dalus <n0dalus+wine(a)gmail.com> wrote: > > On 2/24/06, Tom Spear <speeddymon(a)gmail.com> wrote: > > > > Something like <h2><font color=red>Please check the AppDB to see if > there is > > a workaround for a problem you are encountering with a specific > > program.</font></h2> should work for all but the main bug submit page, > and > > there we should put javascript:alert('Please check the AppDB to see if > there > > is a workaround for a problem you are encountering with a specific > > program.'); into the body so that it shows each time they load the > page.. > > Maybe we could make is a question pop up when they hit the submit button > > instead, and if thye hit yes, then it submits the bug, if not, it either > > redirects them to the appdb, or back to the bug submit page. > > > > Hopefully most of you will agree and it will get put in. > > > > I really don't think this would reduce bug duplicates. For one thing, > bugs are bugs and should be filed in the database. Even if there's a > workaround in the AppDB that says how to get a program working, it > doesn't mean that the underlying issue shouldn't be fixed. > > I also think that having any kind of popup in the way will just annoy > people, and most people will ignore it anyway > > n0dalus. >

1 0

Problems with Sockets and TCL
by Ryan Miller 23 Feb '06

23 Feb '06

Hello, I have an app running under Wine called Auctionpay Event Software. It's currently using TCL to implement a SOAP interface. I've found a bug that can be reproduced with two lines of TCL: package require http http::geturl http://www.google.com <http://www.google.com/> -timeout 0 -query "asdf" 9 times out of 10 this command will fail to return a page. Sometimes the command works. I've traced it down the write event not being received by TCL. Looking into Wine, it appears upon connecting to a socket a user message is sent (WM_USER+2). In the handler WSAAsyncSelect is being called. WSAAsyncSelect somehow is triggering the message loop again (possibly in a different thread?!), and the write event seems to be processed before the original WM_USER+2 is completed. This leads to no write event, which leads to no query being posted to the socket, and finally leading to both computers just sitting there until the server drops the socket. Yet 1/10, it seems that the interrupting message processor interrupts the main message loop as WM_USER+2 message handler has exited/is exiting, and the write message is properly processed and the operation works fine. I have been having a terrible time working with winedbg and setting breakpoints (seems to cause crashes). Is there someone interested in working on this bug or possible just shedding some light on just what might be going on to cause the main message loop to be interrupted in a race condition like this? Thanks, Ryan

1 0

Idea for reducing the number of duplicate bugs
by Tom Spear 23 Feb '06

23 Feb '06

Hi guys, I just wanted to share an idea I just had that could reduce the number of duplicate bugs and ones that have a workaround in the appdb. Many people dont read the documentation, as much as we ask them to, so why dont we, on several pages throughout the website put something that is fairly noticable saying to check the appdb for a workaround/fix before posting a problem to bugzilla, or any of the mailing lists? I think the most helpful places, if we agree to do this, would be the main wine page, the main bugzilla page, the bug submit page, and the main mailing list page.. Something like <h2><font color=red>Please check the AppDB to see if there is a workaround for a problem you are encountering with a specific program.</font></h2> should work for all but the main bug submit page, and there we should put javascript:alert('Please check the AppDB to see if there is a workaround for a problem you are encountering with a specific program.'); into the body so that it shows each time they load the page.. Maybe we could make is a question pop up when they hit the submit button instead, and if thye hit yes, then it submits the bug, if not, it either redirects them to the appdb, or back to the bug submit page. Hopefully most of you will agree and it will get put in. Tom

2 1

wine-0.9.8 and Lotus Notes 6.5.1
by Rainer Dorsch 23 Feb '06

23 Feb '06

Hello, just wanted to report my wine experience with Lotus Notes 6.5.1: I run Lotus Notes with wine since a long time. What I notices with wine-0.9.8 (though this was present in a few releases before but not in all releases): -> Wine is noticalby faster than the snapshot 200412xx -> I need to select win98 to get the file select box working -> I need to set WINEDLLOVERRIDES="usp10=n" -> Cut and paste between X and wine applications works only when selecting the appropriate entry in KDE's klipper. Previously, that worked transparently, when specifying "UsePrimary" = "1" in the [Clipboard] config stanza -> The file select box shows for folders the symbol of files, e.g. Compare rd@silverboxy:~/test$ ls -l insgesamt 4 drwxr-xr-x 2 rd rd 4096 2006-02-23 17:08 dir -rw-r--r-- 1 rd rd 0 2006-02-23 17:08 file rd@silverboxy:~/test$ with the attachment, which shows a screenshot of the file select box. Regards, Rainer -- Rainer Dorsch Alzentalstr. 28 D-71083 Herrenberg 07032-919495 Icq: 32550367

2 1

Want fun? Try qemu.exe on wine
by Detlef Riekenberg 23 Feb '06

23 Feb '06

Hi. SDLVIDEODRIVER=windib wine qemu.exe -L . -hda reactos_0.2.8.img winefile starts inside reactos :-) -- By By ... ... Detlef

1 1

explorer.exe is a child of new process
by Paul Vriens 23 Feb '06

23 Feb '06

Hi, with current git/cvs I can see that there is now a new explorer.exe process running when I start process explorer. What is strange though, is that explorer.exe is a child of procexp.exe. Is this supposed to be like that? Cheers, Paul.

2 1

Re: D3D8 caps -> wined3d
by Stefan Dösinger 23 Feb '06

23 Feb '06

Hi, > + /* Optimization */ > + BOOL modelview_valid; > + BOOL proj_valid; > + BOOL view_ident; > + BOOL last_was_rhw; > + GLenum tracking_parm; > ... Are you sure that this is the latest version of IWineD3DDeviceImpl? I think my patch which added a viewport_changed member here was applied to CVS. I don't have CVS access right now, but I think that the structure you added is out of date.

2 1

Cross-Machine COM-Calls under Wine... (RePost from wine.user)
by Olaf Schmidt 23 Feb '06

23 Feb '06

are working here, using our own implementation of a COM-based RPC-Server. Its speciality is the hosting of COM-Binaries, that don't have to be registered, to instantiate Classes and invoke Methods on them. If you want to test a Server/Client-Pair - here's our free Download: www.datenhaus.de/Downloads/dh_RPC.zip For a successful test under Wine, you have to Install the Redistributables of an actual VB6-Runtime and some ADO-Distributable >=2.5 first. I've tested the whole thing under a Debian-Sid with a somewhat older Kernel (2.6.9), but with a new "apt-getted" Wine-Version (0.97). The Installation of the VB6-Runtime and the ADO-Redist was not possible, until I figured out, that a prior install of IE6 was helpful, to install the two above mentioned packages. After installing these prerequisites, I removed the IE6-ProgramFolder, unpacked our ZIP to c:\dh_RPC, started the Server and the Client - eh voilà - all was working fine (Linux->Linux and XP->Linux). The complete set of COM-DemoCalls was working "OutOfTheBox", even the "Disconnected ADO-Recordset"-Call was successful. (For the Linuxers, that are serialized DB-Resultsets, wich are often used in distributed COM-Scenarios). No Memory-Leaking, even under Stress (the server was able, to deliver max. 700 small COMRequsest per second, stressed from multiple Clients (XP-Box, comparable Hardware, reached ca. 2000). So Wine has ca. 3 times the Call-Overhead, regarding Object-Instantiation and Method-Invoking-By-Name. But the more realistic Recordset-Call was finished after 14ms, where the XP-Box needed 9ms - so for realistic Calls, we now see only factor 1.5 under Wine. And in the "Large-String- Reflection-Test" (2MB Up- and 4MB-Download) - Wine was a little bit faster than XP - good job, regarding your socket-bindings. Minimizing to the "KDE-SysTray", all was working; I was impressed. Now the bad news: ;-) Not working was: 1. Running as Service (Service-Registering was successful, but ...) (Ok, no big problem, running as UserProcess was working, but are there plans, to simulate the Win-ServiceControlmanager?) 2. Win-Authentication and -Impersonation (LogonUser- and ImpersonateLoggedOnUser-APIs - already mapped to...?) 3. "Global ServerSingletons" using ROT-Entries with FileMoniker-Binding 4. "RPCServer-internal Singletons" (CoMarshalInterThreadInterfaceInStream and CoGetInterfaceAndReleaseStream against the IUnknown-Interface). Any Ideas, especially for 3. and 4.?--> a good working X-Process-, respective X-Thread-Marshaling would be important, to take COM- Hosting under Linux/Wine seriously into account. My attempts, to get any useful information per WineDebug were not successful. It would be great, if anybody with more "Wine-Debugging-Experience" could look at the appropriate Calls using our free Server-Download. Thanks. Olaf Schmidt P.S. As Dan Kegel has recommended in 'wine.user', I will try to isolate the Problems 3. und 4. in separate Binaries and post a link later.

2 2

Re: gdi32: Fallback to StretchDIBits if the driver doesn't support BitBlt
by Alexandre Julliard 23 Feb '06

23 Feb '06

Huw D M Davies <h.davies1(a)physics.ox.ac.uk> writes: > + if ((dcSrc = DC_GetDCUpdate( hdcSrc ))) > + { > + dcDst = DC_GetDCPtr( hdcDst ); > + TRACE("hdcSrc=%p %d,%d -> hdcDest=%p %d,%d %dx%d rop=%06lx\n", > + hdcSrc, xSrc, ySrc, hdcDst, xDst, yDst, width, height, rop); > + > ret = dcDst->funcs->pBitBlt( dcDst->physDev, xDst, yDst, width, height, > dcSrc ? dcSrc->physDev : NULL, xSrc, ySrc, rop ); This is wrong, dcSrc doesn't always need to be valid for BitBlt. -- Alexandre Julliard julliard(a)winehq.org

1 0

comm & Win98
by Eric Pouech 23 Feb '06

23 Feb '06

could someone with a Win98 box test the attached test (it's a diff to dlls/kernel/tests/comm.c) ? the test passes on XP, I want to be sure it does as well on Win9x before I remove the offending code TIA -- Eric Pouech

2 1

Re: [MSI 5/5] Fix Stack Buffer Overflow in MSI_ProcessMessage
by Alexandre Julliard 22 Feb '06

22 Feb '06

Robert Shearman <rob(a)codeweavers.com> writes: > ChangeLog: > Fix a theoretical stack buffer overflow if the number was greater than > one digit. Then the buffer should be larger, silently truncating the number is not that much better than a stack overflow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: WineFile: [PATCH] Implement part of Save Settings to registry
by Detlef Riekenberg 22 Feb '06

22 Feb '06

Am Montag, den 20.02.2006, 12:57 -0500 schrieb Jason Green: > > This patch adds the ability to save your window position to the > > registry when using winefile. > +static const WCHAR registry_key[] = { 'S','o','f','t','w','a','r','e','\\', >+ 'W','i','n','e','\\','W','i','n','e','F','i','l','e','\0'}; Native winfile uses winfile.ini on win9x and this is mapped to the registry in WinNT. (IniFileMapping does not work in wine yet http://www.microsoft.com/resources/documentation/windowsnt/4/workstation/re… ). Can we make the settings compatible? +static windowOptions load_registry_settings() +{ + windowOptions opts; + + return opts; +} BANG. You used a struct on the stack. That Memory is not valid after the return. Use a pointer to the your struct as Parameter: ...(windowOptions * opts) -- By By ... ... Detlef

1 0

Re: OLEAUT32: Fix regression in OLEFontImpl_Clone
by Alex Villacís Lasso 22 Feb '06

22 Feb '06

Alex Villacís Lasso wrote: > Lately, all VB6 applications crash on exit. This weekend, I found the > cause. Apparently the VB6 runtime creates a standard OLEFont object, > and then calls IFont::clone() on it to get a second object. At exit, > the VB6 runtime disposes of both objects. However, the recent OLEFont > changes introduced a bug in which the cloning fails to clone the > connection points associated with the object. Therefore the dispose of > one of the objects frees the connection points, and the dispose of the > second object crashes on attempt to dispose an already-freed object. > > Changelog: > > * Create new empty connection points on clone of OLEFont > > Alex Villacís Lasso > ------------------------------------------------------------------------ > > --- wine-0.9.8-cvs/dlls/oleaut32/olefont.c 2006-02-14 10:38:35.000000000 -0500 > +++ wine-0.9.8-cvs-patch/dlls/oleaut32/olefont.c 2006-02-18 18:40:01.000000000 -0500 > @@ -1113,6 +1113,19 @@ > /* The cloned object starts with a reference count of 1 */ > newObject->ref = 1; > > + /* We need to clone the connection points too. */ > + /* FIXME: should we just add a reference to the (shared) connection points? */ > + newObject->pPropertyNotifyCP = NULL; > + newObject->pFontEventsCP = NULL; > + CreateConnectionPoint((IUnknown*)newObject, &IID_IPropertyNotifySink, &newObject->pPropertyNotifyCP); > + CreateConnectionPoint((IUnknown*)newObject, &IID_IFontEventsDisp, &newObject->pFontEventsCP); > + > + if (!newObject->pPropertyNotifyCP || !newObject->pFontEventsCP) > + { > + OLEFontImpl_Destroy(newObject); > + return E_OUTOFMEMORY; > + } > + > *ppfont = (IFont*)newObject; > > return S_OK; > > Is there anything wrong with this patch? Not applied, and nobody has commented on it either. Alex Villacís Lasso

1 0

WineD3D / D3D8 color format issues
by Roderick Colenbrander 22 Feb '06

22 Feb '06

Hi, Today I tested Max Payne which uses D3D8. Before I started the D3D8 -> WineD3D transistion the game worked fine. Right now it doesn't work correct anymore when you let the game use 16bit textures in its setup menu. Right now all textures are missing. The problem appears to be a glTexImage2D call in wined3d's LoadTexture (surface.c) which results in a 'invalid operation'. Similar code worked fine before the d3d8 transition. After analysing the functions it appears that in 16bit the game wants to use D3DFORMAT_R5G6B5. In case of d3d8 this is translated into GL_RGB while in case of wined3d GL_BGR is used. (Oliver changed it at some stage, he changed other formats too claiming those were incorrect but no more explanation than that) I'm using the latest nvidia drivers and the GL_EXT_BGRA extension is present so in theory GL_BGR should work but for some reason. (Perhaps it is a driver bug as I found similar issues on google regarding both the drivers from ati and nvidia. I wasn't able to find a solution) If I change GL_BGR into GL_RGB I don't get an invalid operation and the game works fine (the textures look well too). According to MSDN the format is just the internal format. Someone in #winehackers told me that Windows prefers BGR because it is more efficient. The format is for internal use and second the opengl driver does the conversion for us anyway. http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… What shall I do, just change the behaviour back to GL_RGB which works? Second the issue likely appears for some other formats which Oliver changed. Regards, Roderick

2 1

Window discovering
by Cyril Margorin 22 Feb '06

22 Feb '06

Hello, Under Windows, there is a tool, that comes with Visual Studio - "Spy++". This tool allows to select window object, get its information (class, styles, etc.) and its messages. Unfortunately, I was unable to start this application (probably it requires some COM object to be register, or something else). I've tried to google for any similar tools, and found one, named WinSpector (http://www.windows-spy.com). But it doesn't allow to select any window from separate process. Is there any tool, that allows to do such things, that works with wine, or probably I need any special settings to run this application? -- Cyril Margorin

1 0

suse linux 9.3
by melvin qiuntin 22 Feb '06

22 Feb '06

I tried to install your new .98 rpm and it is listing unsatisfied dependancies. V3 DSA signature, Libwine so.1, no key Key ID0175623e. I am not sure if that is a o or a 0. Please explain. __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Cross-Machine COM-Calls under Wine... (RePost from wine.user)
by Schmidt 21 Feb '06

21 Feb '06

are working here, using our own implementation of a COM-based RPC-Server. Its speciality is the hosting of COM-Binaries, that don't have to be registered, to instantiate Classes and invoke Methods on them. If you want to test a Server/Client-Pair - here's our free Download: www.datenhaus.de/Downloads/dh_RPC.zip For a successful test under Wine, you have to Install the Redistributables of an actual VB6-Runtime and some ADO-Distributable >=2.5 first. I've tested the whole thing under a Debian-Sid with a somewhat older Kernel (2.6.9), but with a new "apt-getted" Wine-Version (0.97). The Installation of the VB6-Runtime and the ADO-Redist was not possible, until I figured out, that a prior install of IE6 was helpful, to install the two above mentioned packages. After installing these prerequisites, I removed the IE6-ProgramFolder, unpacked our ZIP to c:\dh_RPC, started the Server and the Client - eh voilà - all was working fine (Linux->Linux and XP->Linux). The complete set of COM-DemoCalls was working "OutOfTheBox", even the "Disconnected ADO-Recordset"-Call was successful. (For the Linuxers, that are serialized DB-Resultsets, wich are often used in distributed COM-Scenarios). No Memory-Leaking, even under Stress (the server was able, to deliver max. 700 small COMRequsest per second, stressed from multiple Clients (XP-Box, comparable Hardware, reached ca. 2000). So Wine has ca. 3 times the Call-Overhead, regarding Object-Instantiation and Method-Invoking-By-Name. But the more realistic Recordset-Call was finished after 14ms, where the XP-Box needed 9ms - so for realistic Calls, we now see only factor 1.5 under Wine. And in the "Large-String- Reflection-Test" (2MB Up- and 4MB-Download) - Wine was a little bit faster than XP - good job, regarding your socket-bindings. Minimizing to the "KDE-SysTray", all was working; I was impressed. Now the bad news: ;-) Not working was: 1. Running as Service (Service-Registering was successful, but ...) (Ok, no big problem, running as UserProcess was working, but are there plans, to simulate the Win-ServiceControlmanager?) 2. Win-Authentication and -Impersonation (LogonUser- and ImpersonateLoggedOnUser-APIs - already mapped to...?) 3. "Global ServerSingletons" using ROT-Entries with FileMoniker-Binding 4. "RPCServer-internal Singletons" (CoMarshalInterThreadInterfaceInStream and CoGetInterfaceAndReleaseStream against the IUnknown-Interface). Any Ideas, especially for 3. and 4.?--> a good working X-Process-, respective X-Thread-Marshaling would be important, to take COM- Hosting under Linux/Wine seriously into account. My attempts, to get any useful information per WineDebug were not successful. It would be great, if anybody with more "Wine-Debugging-Experience" could look at the appropriate Calls using our free Server-Download. Thanks. Olaf Schmidt

1 0

Re: riched20: Implements FR_MATCHCASE for EM_FINDTEXT
by Phil Krylov 21 Feb '06

21 Feb '06

On Tue, 21 Feb 2006 10:19:01 -0800 Lei Zhang <leiz(a)ucla.edu> wrote: > - while (pCurItem && pCurItem->member.run.strText->szData[nCurEnd - nMatched - 1] == text[nLen - nMatched - 1]) > + while (ME_CharCompare(pCurItem->member.run.strText->szData[nCurEnd - nMatched - 1], text[nLen - nMatched - 1], (flags & FR_MATCHCASE))) You've dropped pCurItem NULL check here. Probably just a typo... -- Ph.

1 0

Mozilla ActiveX download busted?
by Dan Kegel 21 Feb '06

21 Feb '06

Trying to install Oregon Trail from cnet download, http://www.download.com/Oregon-Trail-5th-Edition/3000-7502_4-10301783.html Cnet has you download a tiny .exe that invokes IE via ActiveX to do the real download. This pops up Wine's Mozilla ActiveX downloader dialog (great) which then downloads the ActiveX wrapper (great) but stores it in c:\windows\temp\mozactivex (note the lack of a .exe, uh-oh), and shortly thereafter prints wine: could not load L"C:\\windows\\temp\\mozactivex" as Win32 binary Wine's Mozilla ActiveX downloader dialog just sits there forever, it doesn't seem to notice the problem. Renaming mozactivex to mozactivex.exe and then running it manually got me past that little problem -- I'm no longer prompted to download wine's mozilla activex wrapper. This worked better a month or two ago - what changed? (I'd do a regression test myself, but can't afford to type too much...) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

6 5

Design Decision? Code, Clone or Translate
by Uwe Bonnes 21 Feb '06

21 Feb '06

Hallo, as stated by some bug entries, the msvcrt implementation of strtod() understands 'd' and 'D' in addition to 'e' and 'E'. I have stumbled apon places, where this is needed. The gnu implementation doesn't understand 'd' and 'D', so we need out own implemenation in msvcrt. I see three possibilities. Which is best suited? - Code it ourself - Clone the implemention from glibc or another open source libc with suitable license and make this cloned code understand d/D - Or clone the string, substitute d/D for e/E and call standard libc Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Winelib
by Michael King 21 Feb '06

21 Feb '06

Hi, I'm looking into porting our graphic application language to Linux usign WineLib but having some trouble just getting started. I downloaded and installed wine-0.9.8-SuSELinux92.i586.rpm for our SUSE 9.2 system and then tried to create the 'notepad' program using the instructions given on http://www.winehq.org/site/docs/winelib-guide/winelib-getting-started . Unfortunately after following the instructions I ended up with a 'notepad.exe.so' not a simple ./notepad file. Our goal is to create a true executable file, not a ".so" library that needs to be invoked using Wine. Have the build instructions changed? Michael F. King PVX Plus Technologies, Ltd. www.pvxplus.com

5 8

Re: dinput: Create single thread for mouse and keyboard hook procs. [try 2]
by Robert Shearman 21 Feb '06

21 Feb '06

Vitaliy Margolen wrote: >+static DWORD WINAPI hook_thread_proc(void *param) >+{ >+ static const WCHAR classW[]={'H','o','o','k','_','L','L','_','C','L',0}; >+ MSG msg; >+ WNDCLASSEXW wcex; >+ HWND hwnd; >+ >+ memset(&wcex, 0, sizeof(wcex)); >+ wcex.cbSize = sizeof(wcex); >+ wcex.lpfnWndProc = (WNDPROC)dinput_hook_WndProc; > > Don't case the function pointer here. >+ wcex.lpszClassName = classW; >+ wcex.hInstance = GetModuleHandleW(0); >+ >+ if (!RegisterClassExW(&wcex)) ERR("Error registering window class\n"); >+ hwnd = CreateWindowExW(0, classW, NULL, 0, 0, 0, 0, 0, HWND_MESSAGE, NULL, NULL, 0); >+ *(HWND*)param = hwnd; >+ >+ SetEvent(signal_event); >+ if (hwnd) >+ { >+ while (GetMessageW(&msg, 0, 0, 0)) >+ { >+ TranslateMessage(&msg); >+ DispatchMessageW(&msg); >+ } >+ } >+ else ERR("Error creating message window\n"); >+ >+ DestroyWindow(hwnd); >+ UnregisterClassW(wcex.lpszClassName, wcex.hInstance); >+ return 0; >+} >+ > > >+static HWND get_thread_hwnd(void) >+{ >+ static HANDLE hook_thread; >+ static HWND hook_thread_hwnd; >+ >+ if (!hook_thread) >+ { >+ HANDLE thread; >+ DWORD tid; >+ HWND hwnd; >+ >+ thread = CreateThread(NULL, 0, hook_thread_proc, &hwnd, CREATE_SUSPENDED, &tid); >+ if (InterlockedCompareExchangePointer((PVOID)&hook_thread, thread, 0) != 0) >+ { >+ /* someone beat us here... */ >+ TerminateThread(thread, 0); >+ WaitForSingleObject(thread, INFINITE); >+ CloseHandle(thread); >+ } >+ else >+ { >+ signal_event = CreateEventW(NULL, FALSE, FALSE, NULL); >+ ResumeThread(thread); >+ WaitForSingleObject(signal_event, INFINITE); >+ CloseHandle(signal_event); >+ >+ if (!(hook_thread_hwnd = hwnd)) >+ { >+ /* Thread failed to create window - reset things so we could >+ try again later */ >+ CloseHandle(thread); >+ hook_thread = 0; >+ } >+ } >+ } >+ return hook_thread_hwnd; >+} > > This looks racy. You try to clean up in the case where the thread was already created, yet some resource like the thread stack won't be cleanup up. IMHO, you are better off putting a critical section around the accesses to hook_thread and hook_thread_hwnd so you can simplify the code a bit. -- Rob Shearman

1 0

Re: riched20: implement EM_SCROLL and its tests
by Alexandre Julliard 21 Feb '06

21 Feb '06

adlr(a)ucla.edu writes: > @@ -2055,6 +2054,51 @@ > } > return 0; > } > + case EM_SCROLL: /* partially copied from WM_VSCROLL */ You should be using the same code for both instead of duplicating it. -- Alexandre Julliard julliard(a)winehq.org

1 0

[usp10] Add ScriptShape functionality
by Vijay Kiran Kamuju 21 Feb '06

21 Feb '06

unable to compile this patch /oracle/git/wine-git/dlls/usp10/usp10.c:333: undefined reference to `GetGlyphIndicesW' with todays git. Please resend the correct patch

2 3

ntdll: Avoid commpile - Error, caused by a single Quote
by Detlef Riekenberg 21 Feb '06

21 Feb '06

Am Dienstag, den 21.02.2006, 00:25 +0100 schrieb Stefan Leichter: > current cvs does not build for me on SuSE 9.0 > gcc -c -I../../../wine/dlls/ntdll -I. -I../../../wine/include -I../../include > -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe > -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o > signal_i386.o ../../../wine/dlls/ntdll/signal_i386.c > ../../../wine/dlls/ntdll/signal_i386.c:108:83: missing terminating ' character > make[2]: *** [signal_i386.o] Fehler 1 Hi. I have the same Problem here, caused by this patch: http://www.winehq.org/pipermail/wine-cvs/2006-February/021180.html And the fix: Changelog: - Avoid commpile - Error, caused by a single Quote -- By By ... ... Detlef ______________________________________________________________ Verschicken Sie romantische, coole und witzige Bilder per SMS! Jetzt bei WEB.DE FreeMail: http://f.web.de/?mc=021193

1 0

cvs build failure
by Stefan Leichter 21 Feb '06

21 Feb '06

Hello, current cvs does not build for me on SuSE 9.0 Bye Stefan gcc -c -I../../../wine/dlls/ntdll -I. -I../../../wine/include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o signal_i386.o ../../../wine/dlls/ntdll/signal_i386.c ../../../wine/dlls/ntdll/signal_i386.c:108:83: missing terminating ' character make[2]: *** [signal_i386.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/ntdll' make[1]: *** [ntdll] Fehler 2 make[1]: Leaving directory `/usr/src/wine/wine-build/dlls' make: *** [dlls] Fehler 2

2 1

Regression in wine-0.9.8
by Daniel Skorka 20 Feb '06

20 Feb '06

Hi, wine-0.9.8 has a regression with the Max Payne demo. The demo worked fine in 0.9.7, however the following is broken in 0.9.8: Once you have started the application and begun playing (by selecting Tutorial or New Game or Load) the game crashes as soon as you hit 'Esc' (to get to the menu) or 'F5' (to do a quicksave). Here are the relevant logs: a) If you hit 'Esc': --- snip --- daniel@iapetus:~/.wine/drive_c/max payne demo$ wine maxpaynedemo.exe ALSA lib seq_hw.c:446:(snd_seq_hw_open) open /dev/snd/seq failed: No such device fixme:quartz:Filtergraph_QueryInterface unknown interface {56a868b2-0ad4-11ce-b03a-0020af0ba770} fixme:d3d:IWineD3DImpl_CreateDevice (0x7fdf6578) Incomplete stub for d3d8 fixme:d3d:IWineD3DDeviceImpl_GetAvailableTextureMem (0x7cdc8fc8) : stub, emulating 64Mib for now, returning 64Mib fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_VERSION ("1.3 Mesa 6.4.1")->(0x00000009) fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_RENDERER ("Mesa DRI Intel(R) 915GM 20050225 x86/MMX/SSE2")->(0x0000) fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(128,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(129,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(130,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(131,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(132,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(133,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(134,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(135,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(162,-1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(163,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(164,1065353216) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(165,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(172,3) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(173,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(164,1065353216) not handled yet err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=26620 < primary_done=26624) fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=26620 < primary_done=26624) err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 13338, block size = 4 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 fixme:d3d:IDirect3DDevice8Impl_ResourceManagerDiscardBytes (0x7cd88eb8) : stub fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x7cd88eb8) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetFrontBuffer (0x7cd88eb8) : Should return whole screen, only returns GL context window in top left corner wine: Unhandled page fault on read access to 0x00000008 at address 0x7d7ff62a (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x7d7ff62a). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7d7ff62a ESP:7f9cfb38 EBP:7f9cfb80 EFLAGS:00210202( - 00 - -RI1) EAX:00000000 EBX:7d82eab0 ECX:795b8b68 EDX:00000000 ESI:7f9cfbc8 EDI:6dc1bd38 Stack dump: 0x00000000: 00000000 00000000 00000000 00000000 0x00000010: 00000000 00000000 00000000 00000000 0x00000020: 00000000 00000000 00000000 00000000 0x00000030: 00000000 00000000 00000000 00000000 0x00000040: 00000000 00000000 00000000 00000000 0x00000050: 00000000 00000000 00000000 00000000 Backtrace: =>1 0x7d7ff62a IDirect3DSurface8Impl_LockRect+0x7a(iface=0x6dc1bd38, pLockedRect=0x7f9cfbc0, pRect=0x7f9cfbc8, Flags=0x0) [/home/daniel/src/wine-0.9.8/dlls/d3d8/surface.c:149] in d3d8 (0x7d7ff62a) 2 0x7d7d8a90 IDirect3DDevice8Impl_GetFrontBuffer+0x70(iface=0x7cd88eb8, pDestSurface=0x6dc1bd38) [/home/daniel/src/wine-0.9.8/dlls/d3d8/device.c:1088] in d3d8 (0x7d7d8a90) fixme:dbghelp:sffip_cb NIY on 'C:\remedy\e2\lib\drivers\e2_d3d8_driver_mfc.pdb' 3 0x7d859e61 in e2_d3d8_driver_mfc (+0x29e61) (0x7d859e61) 4 0x7f582d4a in e2mfc (+0x32d4a) (0x7f582d4a) 5 0x7f582cfa in e2mfc (+0x32cfa) (0x7f582cfa) 6 0x8a64a801 (0x8a64a801) 7 0x004179e0 in maxpaynedemo (+0x179e0) (0x004179e0) 0x7d7ff62a IDirect3DSurface8Impl_LockRect+0x7a [/home/daniel/src/wine-0.9.8/dlls/d3d8/surface.c:149] in d3d8: movl 0x8(%eax),%eax 149 if (This == D3D8_SURFACE_GET_DEVICE(This)->backBuffer || This == D3D8_SURFACE_GET_DEVICE(This)->renderTarget || This == D3D8_SURFACE_GET_DEVICE(This)->frontBuffer || D3D8_SURFACE_GET_DEVICE(This)->depthStencilBuffer) { Modules: Module Address Debug info Name (100 modules) PE 0x00400000-008cb000 Export maxpaynedemo PE 0x10000000-10067000 Deferred rlmfc PE 0x5f400000-5f4f2000 Deferred mfc42 PE 0x780a0000-780b2000 Deferred msvcirt PE 0x780c0000-78121000 Deferred msvcp60 ELF 0x7bf00000-7bf03000 Deferred <wine-loader> ELF 0x7cc10000-7ccaa000 Deferred oleaut32<elf> \-PE 0x7cc30000-7ccaa000 \ oleaut32 ELF 0x7ccaa000-7ccbe000 Deferred lz32<elf> \-PE 0x7ccb0000-7ccbe000 \ lz32 ELF 0x7ccbe000-7ccd7000 Deferred version<elf> \-PE 0x7ccc0000-7ccd7000 \ version ELF 0x7ccd7000-7ccfe000 Deferred msvfw32<elf> \-PE 0x7cce0000-7ccfe000 \ msvfw32 ELF 0x7ccfe000-7cd60000 Deferred quartz<elf> \-PE 0x7cd10000-7cd60000 \ quartz ELF 0x7d5e7000-7d67f000 Deferred wined3d<elf> \-PE 0x7d600000-7d67f000 \ wined3d ELF 0x7d739000-7d7b3000 Deferred libglu.so.1 ELF 0x7d7b3000-7d830000 Stabs d3d8<elf> \-PE 0x7d7d0000-7d830000 \ d3d8 PE 0x7d830000-7d8c4000 Export e2_d3d8_driver_mfc ELF 0x7d917000-7d920000 Deferred libgcc_s.so.1 ELF 0x7d930000-7d962000 Deferred uxtheme<elf> \-PE 0x7d940000-7d962000 \ uxtheme ELF 0x7d9db000-7d9f0000 Deferred midimap<elf> \-PE 0x7d9e0000-7d9f0000 \ midimap ELF 0x7db03000-7db2b000 Deferred msacm32<elf> \-PE 0x7db10000-7db2b000 \ msacm32 ELF 0x7db2b000-7db43000 Deferred msacm<elf> \-PE 0x7db30000-7db43000 \ msacm ELF 0x7db43000-7dbf6000 Deferred libasound.so.2 ELF 0x7dbf6000-7dc21000 Deferred winealsa<elf> \-PE 0x7dc00000-7dc21000 \ winealsa ELF 0x7e38b000-7e394000 Deferred libxcursor.so.1 ELF 0x7e39e000-7e3bb000 Deferred imm32<elf> \-PE 0x7e3b0000-7e3bb000 \ imm32 ELF 0x7e3bb000-7e3d9000 Deferred ximcp.so.2 ELF 0x7e3d9000-7e3e2000 Deferred libxrender.so.1 ELF 0x7ece2000-7eeed000 Deferred i915_dri.so ELF 0x7eeed000-7ef54000 Deferred libgl.so.1 ELF 0x7ef54000-7f020000 Deferred libx11.so.6 ELF 0x7f020000-7f038000 Deferred libice.so.6 ELF 0x7f038000-7f0bc000 Deferred winex11<elf> \-PE 0x7f050000-7f0bc000 \ winex11 ELF 0x7f0bc000-7f0dc000 Deferred libexpat.so.1 ELF 0x7f0dc000-7f10b000 Deferred libfontconfig.so.1 ELF 0x7f10b000-7f11d000 Deferred libz.so.1 ELF 0x7f11d000-7f18a000 Deferred libfreetype.so.6 ELF 0x7f18a000-7f1cc000 Deferred dinput<elf> \-PE 0x7f1a0000-7f1cc000 \ dinput ELF 0x7f1cc000-7f290000 Deferred comctl32<elf> \-PE 0x7f1e0000-7f290000 \ comctl32 ELF 0x7f290000-7f2ed000 Deferred shlwapi<elf> \-PE 0x7f2a0000-7f2ed000 \ shlwapi ELF 0x7f2ed000-7f3be000 Deferred shell32<elf> \-PE 0x7f300000-7f3be000 \ shell32 ELF 0x7f3be000-7f3dc000 Deferred iphlpapi<elf> \-PE 0x7f3d0000-7f3dc000 \ iphlpapi ELF 0x7f3dc000-7f426000 Deferred rpcrt4<elf> \-PE 0x7f3f0000-7f426000 \ rpcrt4 ELF 0x7f426000-7f4bc000 Deferred ole32<elf> \-PE 0x7f440000-7f4bc000 \ ole32 ELF 0x7f4bc000-7f510000 Deferred dsound<elf> \-PE 0x7f4d0000-7f510000 \ dsound PE 0x7f510000-7f528000 Deferred sndmfc PE 0x7f530000-7f548000 Deferred grphmfc ELF 0x7f54c000-7f550000 Deferred libxrandr.so.2 PE 0x7f550000-7f5be000 Export e2mfc ELF 0x7f5d3000-7f635000 Deferred msvcrt<elf> \-PE 0x7f5e0000-7f635000 \ msvcrt ELF 0x7f635000-7f675000 Deferred advapi32<elf> \-PE 0x7f640000-7f675000 \ advapi32 ELF 0x7f675000-7f706000 Deferred gdi32<elf> \-PE 0x7f690000-7f706000 \ gdi32 ELF 0x7f706000-7f837000 Deferred user32<elf> \-PE 0x7f720000-7f837000 \ user32 ELF 0x7f837000-7f8c0000 Deferred winmm<elf> \-PE 0x7f840000-7f8c0000 \ winmm ELF 0x7f9d2000-7f9e0000 Deferred libxext.so.6 ELF 0x7f9e4000-7f9e9000 Deferred libxxf86vm.so.1 ELF 0x7fbe9000-7fcf0000 Deferred kernel32<elf> \-PE 0x7fc00000-7fcf0000 \ kernel32 ELF 0x7fe00000-7fe06000 Deferred libxxf86dga.so.1 ELF 0x7fe06000-7fe0f000 Deferred libsm.so.6 ELF 0x7fe0f000-7fe19000 Deferred libnss_files.so.2 ELF 0x7fe19000-7fe22000 Deferred libnss_nis.so.2 ELF 0x7fe22000-7fe36000 Deferred libnsl.so.1 ELF 0x7fe36000-7fe3e000 Deferred libnss_compat.so.2 ELF 0x7fe42000-7fe45000 Deferred iso8859-15.so ELF 0x7fe45000-7fe48000 Deferred xlcdef.so.2 ELF 0x7fe4b000-7fe6d000 Deferred libm.so.6 ELF 0x7fe6d000-7ff63000 Deferred libwine_unicode.so.1 ELF 0x7ff63000-7ffe0000 Deferred ntdll<elf> \-PE 0x7ff70000-7ffe0000 \ ntdll ELF 0xb7e3a000-b7e3d000 Deferred libdl.so.2 ELF 0xb7e3d000-b7f72000 Deferred libc.so.6 ELF 0xb7f72000-b7f81000 Deferred libpthread.so.0 ELF 0xb7f82000-b7f9c000 Deferred libwine.so.1 ELF 0xb7fa7000-b7fbe000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000008 (D) C:\max payne demo\maxpaynedemo.exe 0000000b 2 0000000a 15 00000009 1 <== WineDbg terminated on pid 0x8 --- snip --- b) This is what happens if you hit 'F5' --- snip --- daniel@iapetus:~/.wine/drive_c/max payne demo$ wine maxpaynedemo.exe ALSA lib seq_hw.c:446:(snd_seq_hw_open) open /dev/snd/seq failed: No such device fixme:quartz:Filtergraph_QueryInterface unknown interface {56a868b2-0ad4-11ce-b03a-0020af0ba770} fixme:d3d:IWineD3DImpl_CreateDevice (0x7fdf6578) Incomplete stub for d3d8 fixme:d3d:IWineD3DDeviceImpl_GetAvailableTextureMem (0x7cdc8fc8) : stub, emulating 64Mib for now, returning 64Mib fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_VERSION ("1.3 Mesa 6.4.1")->(0x00000009) fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_RENDERER ("Mesa DRI Intel(R) 915GM 20050225 x86/MMX/SSE2")->(0x0000) fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(128,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(129,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(130,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(131,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(132,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(133,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(134,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(135,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(162,-1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(163,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(164,1065353216) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(165,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(172,3) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(173,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x7cd88eb8)->(164,1065353216) not handled yet err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 13254, block size = 4 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 14286, block size = 4 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7ba093d8 fixme:dsound:DSOUND_MixOne problem with underrun detection (mixlen=22524 < primary_done=22528) err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 13298, block size = 4 err:dsound:DSOUND_PhaseCancel length not a multiple of block size, len = 1394, block size = 4 fixme:d3d:IDirect3DDevice8Impl_ResourceManagerDiscardBytes (0x7cd88eb8) : stub fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x7cd88eb8) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetFrontBuffer (0x7cd88eb8) : Should return whole screen, only returns GL context window in top left corner wine: Unhandled page fault on read access to 0x63657269 at address 0x7f5f47f6 (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x63657269 in 32-bit code (0x7f5f47f6). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7f5f47f6 ESP:7f9ced90 EBP:7f9cedb8 EFLAGS:00210216( - 00 -RIAP1) EAX:63657269 EBX:7f61f200 ECX:00807110 EDX:00000000 ESI:7ffdf048 EDI:008070f8 Stack dump: 0x00000000: 00000000 00000000 00000000 00000000 0x00000010: 00000000 00000000 00000000 00000000 0x00000020: 00000000 00000000 00000000 00000000 0x00000030: 00000000 00000000 00000000 00000000 0x00000040: 00000000 00000000 00000000 00000000 0x00000050: 00000000 00000000 00000000 00000000 Backtrace: =>1 0x7f5f47f6 find_caught_type+0x26(exc_type=0x7ffdf048, catchblock=0x807110) [/home/daniel/src/wine-0.9.8/dlls/msvcrt/cppexcept.c:149] in msvcrt (0x7f5f47f6) 2 0x7f5f502f call_catch_block+0xaf(rec=0x7f9cf9a4, frame=0x7f9cfe3c, descr=0x807068, nested_trylevel=0x0, info=0x7ffdf048) [/home/daniel/src/wine-0.9.8/dlls/msvcrt/cppexcept.c:281] in msvcrt (0x7f5f502f) 3 0x7f5f4d26 cxx_frame_handler(rec=0x7f9cf39c, frame=0x7f9cfe3c, context=0x7f9cf030, dispatch=0x7f9cef48, descr=0x807068, nested_frame=0x0, nested_trylevel=0x0) [/home/daniel/src/wine-0.9.8/dlls/msvcrt/cppexcept.c:383] in msvcrt (0x7f5f4d26) 4 0x7f5f4e9a __CxxFrameHandler+0x1a in msvcrt (0x7f5f4e9a) 5 0x7ffb6369 EXC_CallHandler+0x1d in ntdll (0x7ffb6369) 6 0x7ff91762 call_stack_handlers+0x82(rec=0x7f9cf39c, context=0x7f9cf030) [/home/daniel/src/wine-0.9.8/dlls/ntdll/exception.c:270] in ntdll (0x7ff91762) 7 0x7ff91896 raise_exception(rec=0x7f9cf39c, context=0x7f9cf030, first_chance=0x1) [/home/daniel/src/wine-0.9.8/dlls/ntdll/exception.c:343] in ntdll (0x7ff91896) 8 0x7ff91bd2 __regs_RtlRaiseException+0x32(rec=0x7f9cf39c, context=0x7f9cf030) [/home/daniel/src/wine-0.9.8/dlls/ntdll/exception.c:383] in ntdll (0x7ff91bd2) 9 0x7ffc2a43 __wine_call_from_32_regs in ntdll (0x7ffc2a43) 10 0x7ff91c0e RtlRaiseException in ntdll (0x7ff91c0e) 11 0x7f5f4eec _CxxThrowException(object=0x0, type=0x0) [/home/daniel/src/wine-0.9.8/dlls/msvcrt/cppexcept.c:417] in msvcrt (0x7f5f4eec) 12 0x0044cbc6 in maxpaynedemo (+0x4cbc6) (0x0044cbc6) 13 0x00601600 in maxpaynedemo (+0x201600) (0x00601600) 0x7f5f47f6 find_caught_type+0x26 [/home/daniel/src/wine-0.9.8/dlls/msvcrt/cppexcept.c:149] in msvcrt: cmpl 0x0(%eax),%edx 149 for (i = 0; i < exc_type->type_info_table->count; i++) Modules: Module Address Debug info Name (100 modules) PE 0x00400000-008cb000 Export maxpaynedemo PE 0x10000000-10067000 Deferred rlmfc PE 0x5f400000-5f4f2000 Deferred mfc42 PE 0x780a0000-780b2000 Deferred msvcirt PE 0x780c0000-78121000 Deferred msvcp60 ELF 0x7bf00000-7bf03000 Deferred <wine-loader> ELF 0x7cc10000-7ccaa000 Deferred oleaut32<elf> \-PE 0x7cc30000-7ccaa000 \ oleaut32 ELF 0x7ccaa000-7ccbe000 Deferred lz32<elf> \-PE 0x7ccb0000-7ccbe000 \ lz32 ELF 0x7ccbe000-7ccd7000 Deferred version<elf> \-PE 0x7ccc0000-7ccd7000 \ version ELF 0x7ccd7000-7ccfe000 Deferred msvfw32<elf> \-PE 0x7cce0000-7ccfe000 \ msvfw32 ELF 0x7ccfe000-7cd60000 Deferred quartz<elf> \-PE 0x7cd10000-7cd60000 \ quartz ELF 0x7d5e7000-7d67f000 Deferred wined3d<elf> \-PE 0x7d600000-7d67f000 \ wined3d ELF 0x7d739000-7d7b3000 Deferred libglu.so.1 ELF 0x7d7b3000-7d830000 Deferred d3d8<elf> \-PE 0x7d7d0000-7d830000 \ d3d8 PE 0x7d830000-7d8c4000 Deferred e2_d3d8_driver_mfc ELF 0x7d917000-7d920000 Deferred libgcc_s.so.1 ELF 0x7d930000-7d962000 Deferred uxtheme<elf> \-PE 0x7d940000-7d962000 \ uxtheme ELF 0x7d9db000-7d9f0000 Deferred midimap<elf> \-PE 0x7d9e0000-7d9f0000 \ midimap ELF 0x7db03000-7db2b000 Deferred msacm32<elf> \-PE 0x7db10000-7db2b000 \ msacm32 ELF 0x7db2b000-7db43000 Deferred msacm<elf> \-PE 0x7db30000-7db43000 \ msacm ELF 0x7db43000-7dbf6000 Deferred libasound.so.2 ELF 0x7dbf6000-7dc21000 Deferred winealsa<elf> \-PE 0x7dc00000-7dc21000 \ winealsa ELF 0x7e38b000-7e394000 Deferred libxcursor.so.1 ELF 0x7e39e000-7e3bb000 Deferred imm32<elf> \-PE 0x7e3b0000-7e3bb000 \ imm32 ELF 0x7e3bb000-7e3d9000 Deferred ximcp.so.2 ELF 0x7e3d9000-7e3e2000 Deferred libxrender.so.1 ELF 0x7ece2000-7eeed000 Deferred i915_dri.so ELF 0x7eeed000-7ef54000 Deferred libgl.so.1 ELF 0x7ef54000-7f020000 Deferred libx11.so.6 ELF 0x7f020000-7f038000 Deferred libice.so.6 ELF 0x7f038000-7f0bc000 Deferred winex11<elf> \-PE 0x7f050000-7f0bc000 \ winex11 ELF 0x7f0bc000-7f0dc000 Deferred libexpat.so.1 ELF 0x7f0dc000-7f10b000 Deferred libfontconfig.so.1 ELF 0x7f10b000-7f11d000 Deferred libz.so.1 ELF 0x7f11d000-7f18a000 Deferred libfreetype.so.6 ELF 0x7f18a000-7f1cc000 Deferred dinput<elf> \-PE 0x7f1a0000-7f1cc000 \ dinput ELF 0x7f1cc000-7f290000 Deferred comctl32<elf> \-PE 0x7f1e0000-7f290000 \ comctl32 ELF 0x7f290000-7f2ed000 Deferred shlwapi<elf> \-PE 0x7f2a0000-7f2ed000 \ shlwapi ELF 0x7f2ed000-7f3be000 Deferred shell32<elf> \-PE 0x7f300000-7f3be000 \ shell32 ELF 0x7f3be000-7f3dc000 Deferred iphlpapi<elf> \-PE 0x7f3d0000-7f3dc000 \ iphlpapi ELF 0x7f3dc000-7f426000 Deferred rpcrt4<elf> \-PE 0x7f3f0000-7f426000 \ rpcrt4 ELF 0x7f426000-7f4bc000 Deferred ole32<elf> \-PE 0x7f440000-7f4bc000 \ ole32 ELF 0x7f4bc000-7f510000 Deferred dsound<elf> \-PE 0x7f4d0000-7f510000 \ dsound PE 0x7f510000-7f528000 Deferred sndmfc PE 0x7f530000-7f548000 Deferred grphmfc ELF 0x7f54c000-7f550000 Deferred libxrandr.so.2 PE 0x7f550000-7f5be000 Deferred e2mfc ELF 0x7f5d3000-7f635000 Stabs msvcrt<elf> \-PE 0x7f5e0000-7f635000 \ msvcrt ELF 0x7f635000-7f675000 Deferred advapi32<elf> \-PE 0x7f640000-7f675000 \ advapi32 ELF 0x7f675000-7f706000 Deferred gdi32<elf> \-PE 0x7f690000-7f706000 \ gdi32 ELF 0x7f706000-7f837000 Deferred user32<elf> \-PE 0x7f720000-7f837000 \ user32 ELF 0x7f837000-7f8c0000 Deferred winmm<elf> \-PE 0x7f840000-7f8c0000 \ winmm ELF 0x7f9d2000-7f9e0000 Deferred libxext.so.6 ELF 0x7f9e4000-7f9e9000 Deferred libxxf86vm.so.1 ELF 0x7fbe9000-7fcf0000 Deferred kernel32<elf> \-PE 0x7fc00000-7fcf0000 \ kernel32 ELF 0x7fe00000-7fe06000 Deferred libxxf86dga.so.1 ELF 0x7fe06000-7fe0f000 Deferred libsm.so.6 ELF 0x7fe0f000-7fe19000 Deferred libnss_files.so.2 ELF 0x7fe19000-7fe22000 Deferred libnss_nis.so.2 ELF 0x7fe22000-7fe36000 Deferred libnsl.so.1 ELF 0x7fe36000-7fe3e000 Deferred libnss_compat.so.2 ELF 0x7fe45000-7fe48000 Deferred iso8859-15.so ELF 0x7fe4b000-7fe6d000 Deferred libm.so.6 ELF 0x7fe6d000-7ff63000 Deferred libwine_unicode.so.1 ELF 0x7ff63000-7ffe0000 Stabs ntdll<elf> \-PE 0x7ff70000-7ffe0000 \ ntdll ELF 0xb7da0000-b7da3000 Deferred xlcdef.so.2 ELF 0xb7da4000-b7da7000 Deferred libdl.so.2 ELF 0xb7da7000-b7edc000 Deferred libc.so.6 ELF 0xb7edc000-b7eeb000 Deferred libpthread.so.0 ELF 0xb7eec000-b7f06000 Deferred libwine.so.1 ELF 0xb7f11000-b7f28000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000008 (D) C:\max payne demo\maxpaynedemo.exe 0000000b 2 0000000a 15 00000009 1 <== WineDbg terminated on pid 0x8 Script done on Mon Feb 20 13:09:50 2006 --- snip --- That's all so far. Keep up the good work! Daniel

3 5

Re: Patch: fix for bug #4436 with associated fixes for stream reference counting
by Mike McCormack 20 Feb '06

20 Feb '06

Dr J A Gow wrote: > FROM: Dr J A Gow > PATCH: Provides fix for bug 4436, some reference counting fixes, and > now the IStorage correctly handles the following: > - Stream opening when storage was opened in transacted mode > - Stream methods called after parent object has been closed > correctly return STG_E_REVERTED > - Adds conformance test for stream opening in transacted > mode Looks great, however we usually try to keep seperate fixes seperate so that regression testing is easier, and to reduce the size and complexity of each patch. If you could split these two patches into one for the transacted storage/stream permissions problem, and one for the reference counting problem I'm think they'll be committed without further trouble. thanks, Mike

2 1

Re: advpack: Load the LDIDs of an install section in TranslateInfString [RESEND]
by Alexandre Julliard 20 Feb '06

20 Feb '06

"James Hawkins" <truiken(a)gmail.com> writes: > Is there anything wrong with this patch? > > Changelog: > * Load the LDIDs of an install section in TranslateInfString. Is there a reason you can't use SetupGetStringField instead of getting the whole line and duplicating the parsing that setupapi already does? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dinput: Corrected bug where mouse clicks were not passed to window
by Vitaliy Margolen 20 Feb '06

20 Feb '06

Monday, February 20, 2006, 3:21:56 AM, Vitaly Budovski wrote: > dinput: Corrected bug where mouse clicks were not passed to window > with DISCL_EXCLUSIVE flag set. > dlls/dinput/mouse.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > - if (dwCoop & DISCL_NONEXCLUSIVE) { > + if (dwCoop & DISCL_EXCLUSIVE) { > /* Pass the events down to previous handlers (e.g. win32 input) */ > ret = CallNextHookEx( This->hook, code, wparam, lparam ); > } else { No this is not correct. I think you should try to test this one, but I really doubt that we should stop LL mouse hook callback chain. Especially in none exclusive mode. If anything we should always call CallNextHookEx. Vitaliy Margolen

1 0

Re: [Corrected] NTDLL/loader.c: Remove spaces at end of name in import_dll
by Robert Shearman 20 Feb '06

20 Feb '06

Uwe Bonnes wrote: >@@ -470,6 +480,7 @@ > WCHAR *ptr = RtlAllocateHeap( GetProcessHeap(), 0, len * sizeof(WCHAR) ); > if (!ptr) return NULL; > ascii_to_unicode( ptr, name, len ); >+ skip_spaces(buffer, len); > status = load_dll( load_path, ptr, 0, &wmImp ); > RtlFreeHeap( GetProcessHeap(), 0, ptr ); > This patch still needs work. I don't think you mean to pass in buffer to skip_spaces. -- Rob Shearman

1 0

winsock: add check for sin6_scope_id (use CHECK_MEMBERS)
by Vitaly Lipatov 20 Feb '06

20 Feb '06

On old systems sin6_scopy_id was not exist. I add a check for it in configure.ac and ifdefs in c file. Rewrite with AC_CHECK_MEMBERS Changelog: add check for sin6_scope_id is exist -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: Resend: SetWinMetaFileBits: Scale the picture to the whole device surface if lpmfp == NULL
by Alexandre Julliard 20 Feb '06

20 Feb '06

Michael Kaufmann <hallo(a)michael-kaufmann.ch> writes: > SetWinMetaFileBits: > - Isotropic/Anisotropic mapping mode: Scale the picture to the whole > device surface if lpmfp == NULL (current implementation doesn't set > the window and viewport extents in this case, leading to upside-down > images or other strange effects). Also use the whole device surface if > the x extent or the y extent is zero or negative (MSDN says something > about aspect ratios, but that is not implemented in Windows) > - Other mapping modes: Ignore the specified extents (let the GDI > calculate them) This fails make test for me: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so metafile.c && touch metafile.ok metafile.c:1050: Test failed: (0,0)->(1,1), expected (0,0)->(18,67) -- Alexandre Julliard julliard(a)winehq.org

1 0

Anyone else seeing problems with 0.9.8 on FreeBSD-6.x ???
by Jukka A. Ukkonen 20 Feb '06

20 Feb '06

Hello all, I have seen some potential regressions in Wine-0.9.8 on FreeBSD-6.x. - Winefile draws garbage in the minimize, full-screen, and close buttons in the upper right corner of its windows. - Wine (and obviously also winefile) fail to start a native windows setup.exe program. Has anyone else seen similar problems? Is there a known fix? Could this be somehow depending on real parallelism on a two processor system? The program I used to test wine was setup.exe from the game Pharaoh by Sierra. It is a relatively long time since I tried wine the previous time, and the last time I tried was with FreeBSD-4.11 at which time the threads in wine did not work at all. So, I cannot really know whether these things I have now seen failing have ever really worked OK on FreeBSD, but assume as much. Maybe there are regressions of some sort. Cheers, // jau

3 2

Re: winsock: add check for sin6_scope_id
by Alexandre Julliard 20 Feb '06

20 Feb '06

Vitaly Lipatov <lav(a)etersoft.ru> writes: > On old systems sin6_scopy_id was not exist. > I add a check for it in configure.ac and ifdefs in c file. > > Changelog: > add check for sin6_scope_id is exist You should use AC_CHECK_MEMBERS for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advpack: Load the LDIDs of an install section in TranslateInfString [RESEND]
by James Hawkins 20 Feb '06

20 Feb '06

On 2/19/06, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > Is there anything wrong with this patch? > > Changelog: > * Load the LDIDs of an install section in TranslateInfString. > The two new tests that are failing now are because our SetupSetDirectoryId stores user LDIDs globally. My hypothesis is that native setupapi stores user LDIDs per hinf. I'm going to submit tests for this behavior, but in the meantime, this functionality (loading LDIDs) is used for the IE install, and this patch helps it get a little further. -- James Hawkins

1 0

Site: Broken links
by Vitaly Lipatov 20 Feb '06

20 Feb '06

At page http://winehq.com/site/sending_patches too many broken links pointed to http://winehq.com/site/forums (it page does not exists at all) -- Lav Vitaly Lipatov Saint-Petersburg, Etersoft www.etersoft.ru GNU! ALT Linux Team! WINE! LaTeX! LyX!

2 1

re:slackware download
by hippy hip 20 Feb '06

20 Feb '06

huh- well.. i only have 3 accounts on this computer- root, the one i usually use & guest. when i go into the one i usually use- i get this page.... http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=6301 ...when i log in as 'guest' the page shows up just fine. I just downloaded it. Well- sorry about that. I guess the problem was on my end. I thought you might have a broken link or something. Thanks alot. um... weird. lol. thanks -shannon __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

re:slackware download
by hippy hip 20 Feb '06

20 Feb '06

click on- http://www.winehq.org/site/download click on 'slackware' to download wine-0.9.8 for slackware. see the problem?- it's been like that for 4 days now. Is the link wrong or is the page down? I can't seem to find the slackware package for wine-0.9.8 anywhere else. Hope this is the right place to post this. thank you for your time. -shannon __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

slackware download
by hippy hip 20 Feb '06

20 Feb '06

hiya- sorry if this is the wrong place to post this - wasn't sure where to send it- anyway- if you go to your webpage- click on 'download' -then go to slackware to get the install file for slack... you get a error page telling you the servers down. this has been going on for the last 3 days now. has the page actually been down the last 3 days? or is the link to the page wrong? just letting you know. -want to check out 0.9.8 ;) thanks for your time- __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Wine graphics backends
by Segin 19 Feb '06

19 Feb '06

I wans wondering, have any of you ever attepted to make a Wine graphics backend? I thought about making one for either SDL or DirectFB, it would be useful, cause you could do Wine without the drugery of X11. (has anyone read the X Windows Disaster recently?) Also, using the Linux framebuffer would also have a number of advantages, in areas od speed and memory size

1 0

Re: add configure options to control support of misc packages
by Mike McCormack 19 Feb '06

19 Feb '06

Mike Frysinger wrote: > this patch adds a bunch of --without-FOO options to configure ... some are > very simple (like the sane/xml checks) while some others are slightly more > involved What's the point of crippling Wine like this? Mike

2 8

GL mipmap question
by Stefan Dösinger 19 Feb '06

19 Feb '06

Hi, I'm trying to get the Mipmap example of the DX7 sdk running, and I've run into a problem: OpenGL requires mipmap levels down to 1x1 (according to the red book), but DirectX can provide less levels, e.g. the smallest with 16x16. If I use such a mipmaped texture from d3d in opengl, this results in a white texture image. I've verified this with a GL-only program. Is there any way to such a texture with opengl, or do I need other tricks? I could use gluBuild2DMipmaps() to create the smaller textures, but I dislike that way. Stefan

1 1

Re: NTDLL/loader.c: Remove spaces at end of name in import_dll
by Vitaliy Margolen 18 Feb '06

18 Feb '06

Saturday, February 18, 2006, 11:16:10 AM, Uwe Bonnes wrote: > Changelog: > ntdll/loader.c import_dll() > Remove spaces at end of name retrieved with get_rva( module, > descr->>Name ) > +/* Overwrite spaces at end of buffer with NULL */ > +inline static void skip_spaces(WCHAR *buffer, size_t len) > +{ > + while (buffer[len -2] == (WCHAR)' ') > + { > + buffer[len -2] = 0; > + len --; > + } > +} This is wrong (number of errors). It should look something like this: while (len > sizeof(WCHAR)&& buffer[len/sizeof(WCHAR) - 1] == ' ') { len -= sizeof(WCHAR); buffer[len/sizeof(WCHAR)] = 0; } Vitaliy Margolen

2 2

Re: D3D8 Texture -> WineD3D
by Stefan Dösinger 18 Feb '06

18 Feb '06

> This patch (based on Oliver Stieber his d3d8 code) moves d3d8's texturing > code over to WineD3D. The patch adds new datatypes, replaces a few texture > creation calls with wined3d code and updates code to work with the new > datatypes. Unfortunately the patch is quite big because there's one texture > base type of which all other texture types are instances. Just one question: Wouldn't it be a better idea to replace the d3d8 directory in one go? I know that it's against the rule of sending small patches, but I think an interface for interface move makes more troubles than it solves(like the header inclusion, for example). If a game breaks during that move, I'm afraid we have to fully debug it with WineD3D in any case. The reason why I'm asking this is the ddraw move. I plan to make some wined3d_types.h additions in small patches, then some wined3d additions(small patches too) and then replace the whole ddraw directory in one patch, because the original code and the new ddraw code don't have much in common. This saves a lot of hassle without provocing troubles which wouldn't appear otherwise. Stefan

2 1

Re: menu drawing fixes -- RESENT
by Alexandre Julliard 18 Feb '06

18 Feb '06

Rein Klazes <wijn(a)wanadoo.nl> writes: > Updating drawing of menu items with bitmaps and/or strings: > - implemented MNS_NOCHECK menu style; > - support HBMMENU_CALLBACK bitmaps in menu bars; > - replaced some #defined constants by values calculated from windows > metrics; > - added a lot of tests on menu item sizes and the position of the bitmap > and making them pass on Wine. Could you please send separate fixes as separate patches? -- Alexandre Julliard julliard(a)winehq.org

1 0

Possibly crazy idea to deal with memory layout problems once and for all
by Troy Rollo 18 Feb '06

18 Feb '06

I have been looking at a problem that has arisen in recent versions, particularly when using some D3D games, in which the virtual address space above TASK_UNMAPPED_BASE becomes fragmented to the extent that eventually you get an out of memory condition, even though you still have well over a gigabyte free (even in a contiguous block!). This has led to some people using the attached hack (first attachment) to get their D3D games to work. After considering a lot of approaches to this problem that did not seem to get anywhere productive, it seemed that the only way to resolve it would be to get in between the application and any libraries, and the kernel. The solution I came up with is somewhat rude, but if we assume that any libraries that Wine uses only call mmap() and associated calls via the C library, then it may well do the trick, plus make it possible to implement other virtual memory APIs more effectively (and in a couple of cases eliminate calls to wineserver). If wine_preloader were extended to have its own implementation of all the friends of mmap(), and to have its own implementation of the dynamic linker, then in principle it could make sure only its mmap (and not the C library's) is called. An even more aggressive approach might be to load the C library and stick jumps into its mmap that redirect to the preloader's versions. The preloader's mmap would keep track of mappings on its own and when it receives an mmap with a start address of "NULL", decides on its own what base address to use. Any thoughts?

2 2

Re: fixup previous DESTDIR commit
by Alexandre Julliard 17 Feb '06

17 Feb '06

Mike Frysinger <vapier(a)gentoo.org> writes: > the previous commit which added DESTDIR support to cvs was not exactly the > same patch i posted ... this was both good and bad because on one hand an > additional line i missed in programs/make_progs was fixed but on the other > the programs/Makefile.in file now generates an incorrect link What's incorrect about the link? -- Alexandre Julliard julliard(a)winehq.org

2 3

DreamWeaver 8 Issues
by Ian Kellogg 17 Feb '06

17 Feb '06

I tried to install DreamWeaver 8 with WINE 0.9.8 and I get quite alot of errors. [ian@minuet Desktop]$ wine Dreamweaver8-en.exe fixme:msi:MsiInstallProductW L"C:\\windows\\Downloaded Installations\\Macromedia Dreamweaver 8\\Macromedia_Dreamweaver_8.msi" L"" fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:sync:SetNamedPipeHandleState 0xdc 0x61853a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xdc 0x4b520a98 (nil) (nil) fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:sync:SetNamedPipeHandleState 0xe0 0x61853a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xd0 0x61853a98 (nil) (nil) fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:sync:SetNamedPipeHandleState 0xd4 0x8122a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xf4 0x378cba98 (nil) (nil) fixme:ole:RpcChannelBuffer_GetDestCtx (0x4b520734,0x4b520738), stub! fixme:sync:SetNamedPipeHandleState 0xf4 0x5b17a98 (nil) (nil) fixme:ole:NdrConvert (pStubMsg == ^0x92240c, pFormat == ^0x2d841ba): stub. fixme:ole:NdrConvert (pStubMsg == ^0x4b5206c0, pFormat == ^0x2d841ba): stub. err:ole:get_unmarshaler_from_stream Failed to read common OBJREF header, 0x00000000 fixme:ole:RpcChannelBuffer_GetDestCtx (0x4b520730,0x4b520734), stub! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:sync:SetNamedPipeHandleState 0x80 0x378cba98 (nil) (nil) fixme:ole:NdrConvert (pStubMsg == ^0x922408, pFormat == ^0x2d841c8): stub. fixme:ole:NdrConvert (pStubMsg == ^0x4b5206bc, pFormat == ^0x2d841c8): stub. fixme:sync:SetNamedPipeHandleState 0x80 0x5b17a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xc8 0x1e301a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xc8 0x8122a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xd4 0x8122a98 (nil) (nil) fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0092ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f80ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0092ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f80ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f80ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f80ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0092ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f80ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f82ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f80ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 0092ffff fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0xb) 7f82ffff fixme:sync:SetNamedPipeHandleState 0xd0 0x8122a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xd0 0x5b17a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xd0 0x1e301a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0xd0 0x8122a98 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0x94 0x1e301a98 (nil) (nil) fixme:ole:RpcChannelBuffer_GetDestCtx (0x4b520778,0x4b52077c), stub! fixme:sync:SetNamedPipeHandleState 0xfc 0x5b17a98 (nil) (nil) fixme:ole:NdrConvert (pStubMsg == ^0x92f2c0, pFormat == ^0x2d841da): stub. fixme:sync:SetNamedPipeHandleState 0x11c 0x50ae4a98 (nil) (nil) err:ntdll:RtlpWaitForCriticalSection section 0x7f7a4048 "compobj.c: apartment" wait timed out in thread 0012, blocked by 002c, retrying (60 sec) err:rpc:I_RpcReceive we got fault packet with status 6be err:ole:ifproxy_release_public_refs IRemUnknown_RemRelease failed with error 0xc0000194 fixme:ole:NdrConvert (pStubMsg == ^0x4b520704, pFormat == ^0x2d841da): stub. err:msi:ACTION_ProcessUISequence Execution halted due to error (1603) fixme:sync:SetNamedPipeHandleState 0xa4 0x61853a98 (nil) (nil) Not sure what is with all the Hex but hopefully someone will know what to do with the information

4 3

x11drv: [PATCH] for X_SetClipRectangles clipping crash
by Jason Green 17 Feb '06

17 Feb '06

While running Quickbooks Pro 99, WINE would crash every time I changed an existing transaction and clicked "Next" or "Prev", then answered Yes to save changes. It gave the following error: X Error of failed request: BadMatch (invalid parameter attributes) Major opcode of failed request: 59 (X_SetClipRectangles) Serial number of failed request: 83724 [<--- that number changed every time] Current serial number in output stream: 87435 [<--- that number changed every time, too] (it also still gives quite a few of these errors elsewhere in the app, but I don't know if it's related): err:x11drv:X11DRV_CreateWindow invalid window height -2 The line it was crashing on was in x11drv/clipping.c: XSetClipRectangles( gdi_display, physDev->gc, physDev->org.x, physDev->org.y, (XRectangle *)data->Buffer, data->rdh.nCount, YXBanded ); After digging around a little, I found this Xlib programming manual entry: http://tronche.com/gui/x/xlib/GC/convenience-functions/XSetClipRectangles.h… Here's what it has to say on the last argument about clipping rectangle sorting: "If known by the client, ordering relations on the rectangles can be specified with the ordering argument. This may provide faster operation by the server. If an incorrect ordering is specified, the X server may generate a BadMatch error, but it is not required to do so. If no error is generated, the graphics results are undefined. Unsorted means the rectangles are in arbitrary order. YSorted means that the rectangles are nondecreasing in their Y origin. YXSorted additionally constrains YSorted order in that all rectangles with an equal Y origin are nondecreasing in their X origin. YXBanded additionally constrains YXSorted by requiring that, for every possible Y scanline, all rectangles that include that scanline have an identical Y origins and Y extents." Changing that last parameter from YXBanded to Unsorted has completely resolved my problem, and it doesn't seem to have broken anything else that I've noticed (Firefox, Mozilla-suite, winefile all seem to run just as well as before). However, I'm sure you all know more than I do about how that particular function works. The code for that function hasn't changed at least since the 20031212 CVS. Either way, I'm submitting a small one-line patch. Please let me know if you think this will cause issues elsewhere. Thanks!

2 1

PATCH/RFC: imagelist rewrite to use N x M grid
by Marcus Meissner 17 Feb '06

17 Feb '06

Hi, This patch is a rewrite of the imagelist handling to not use a Nx1 grid, but a NxM grid with M definable in the source (currently 4). I have tested against winrar, "file open" and "make check". It is not completely regression tested, so I am not wanting to submit it right now. But I welcome comments. :) Ciao, Marcus Index: dlls/comctl32/imagelist.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/imagelist.c,v retrieving revision 1.101 diff -u -r1.101 imagelist.c --- dlls/comctl32/imagelist.c 14 Nov 2005 11:20:10 -0000 1.101 +++ dlls/comctl32/imagelist.c 28 Nov 2005 06:21:43 -0000 @@ -55,6 +55,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(imagelist); +#define PER_ROW 4 #define MAX_OVERLAYIMAGE 15 @@ -84,6 +85,12 @@ return himl && himl->magic == IMAGELIST_MAGIC; } +static DWORD index2x(INT index, INT cx) { return cx*(index/PER_ROW); } +static DWORD index2y(INT index, INT cy) { return cy*(index%PER_ROW); } + +static DWORD count2x(INT count, INT cx) { + return cx*((count+PER_ROW-1)/PER_ROW); +} /************************************************************************* * IMAGELIST_InternalExpandBitmaps [Internal] @@ -93,6 +100,8 @@ * PARAMS * himl [I] handle to image list * nImageCount [I] number of images to add + * cx [I] width of image + * cy [I] height of image * * RETURNS * nothing @@ -113,21 +122,22 @@ if (cy == 0) cy = himl->cy; nNewCount = himl->cCurImage + nImageCount + himl->cGrow; - nNewWidth = nNewCount * himl->cx; + nNewWidth = count2x(nNewCount,himl->cx); - TRACE("Create expanded bitmaps : himl=%p x=%d y=%d count=%d\n", himl, nNewWidth, cy, nNewCount); + TRACE("Create expanded bitmaps : himl=%p x=%d y=%d count=%d\n", himl, + nNewWidth, cy*PER_ROW, nNewCount); hdcBitmap = CreateCompatibleDC (0); - hbmNewBitmap = ImageList_CreateImage(hdcBitmap, himl, nNewWidth, cy); + hbmNewBitmap = ImageList_CreateImage(hdcBitmap, himl, nNewWidth, cy*PER_ROW); if (hbmNewBitmap == 0) - ERR("creating new image bitmap (x=%d y=%d)!\n", nNewWidth, cy); + ERR("creating new image bitmap (x=%d y=%d)!\n", nNewWidth, cy*PER_ROW); if(himl->cCurImage) { hbmNull = SelectObject (hdcBitmap, hbmNewBitmap); - BitBlt (hdcBitmap, 0, 0, himl->cCurImage * himl->cx, cy, - himl->hdcImage, 0, 0, SRCCOPY); + BitBlt (hdcBitmap, 0, 0, count2x(himl->cCurImage,himl->cx), + cy*PER_ROW, himl->hdcImage, 0, 0, SRCCOPY); SelectObject (hdcBitmap, hbmNull); } SelectObject (himl->hdcImage, hbmNewBitmap); @@ -136,7 +146,7 @@ if (himl->flags & ILC_MASK) { - hbmNewBitmap = CreateBitmap (nNewWidth, cy, 1, 1, NULL); + hbmNewBitmap = CreateBitmap (nNewWidth, cy*PER_ROW, 1, 1, NULL); if (hbmNewBitmap == 0) ERR("creating new mask bitmap!\n"); @@ -144,8 +154,8 @@ if(himl->cCurImage) { hbmNull = SelectObject (hdcBitmap, hbmNewBitmap); - BitBlt (hdcBitmap, 0, 0, himl->cCurImage * himl->cx, cy, - himl->hdcMask, 0, 0, SRCCOPY); + BitBlt (hdcBitmap, 0, 0, count2x(himl->cCurImage,himl->cx), + cy*PER_ROW, himl->hdcMask, 0, 0, SRCCOPY); SelectObject (hdcBitmap, hbmNull); } SelectObject (himl->hdcMask, hbmNewBitmap); @@ -179,7 +189,7 @@ { HDC hdcBitmap; INT nFirstIndex, nImageCount; - INT nStartX; + INT i; BITMAP bmp; HBITMAP hOldBitmap; @@ -192,43 +202,42 @@ IMAGELIST_InternalExpandBitmaps (himl, nImageCount, bmp.bmWidth, bmp.bmHeight); - nStartX = himl->cCurImage * himl->cx; - hdcBitmap = CreateCompatibleDC(0); - hOldBitmap = SelectObject(hdcBitmap, hbmImage); - /* Copy result to the imagelist - */ - BitBlt (himl->hdcImage, nStartX, 0, bmp.bmWidth, bmp.bmHeight, - hdcBitmap, 0, 0, SRCCOPY); - - if(himl->hbmMask) - { - HDC hdcTemp; - HBITMAP hOldBitmapTemp; - - hdcTemp = CreateCompatibleDC(0); - hOldBitmapTemp = SelectObject(hdcTemp, hbmMask); + for (i=himl->cCurImage;i<himl->cCurImage+nImageCount;i++) { + /* Copy result to the imagelist */ + BitBlt (himl->hdcImage, index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, hdcBitmap, himl->cx*(i-himl->cCurImage), 0, SRCCOPY); - BitBlt (himl->hdcMask, - nStartX, 0, bmp.bmWidth, bmp.bmHeight, - hdcTemp, - 0, 0, - SRCCOPY); + if(himl->hbmMask) + { + HDC hdcTemp; + HBITMAP hOldBitmapTemp; - SelectObject(hdcTemp, hOldBitmapTemp); - DeleteDC(hdcTemp); + hdcTemp = CreateCompatibleDC(0); + hOldBitmapTemp = SelectObject(hdcTemp, hbmMask); - /* Remove the background from the image - */ - BitBlt (himl->hdcImage, - nStartX, 0, bmp.bmWidth, bmp.bmHeight, - himl->hdcMask, - nStartX, 0, - 0x220326); /* NOTSRCAND */ + BitBlt (himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, + hdcTemp, + himl->cx*(i-himl->cCurImage), 0, + SRCCOPY); + + SelectObject(hdcTemp, hOldBitmapTemp); + DeleteDC(hdcTemp); + + /* Remove the background from the image + */ + BitBlt (himl->hdcImage, + index2x(i,himl->cx), index2y(i,himl->cy), + bmp.bmWidth, bmp.bmHeight, + himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + 0x220326); /* NOTSRCAND */ + } } - SelectObject(hdcBitmap, hOldBitmap); DeleteDC(hdcBitmap); @@ -278,12 +287,12 @@ INT WINAPI ImageList_AddMasked (HIMAGELIST himl, HBITMAP hBitmap, COLORREF clrMask) { - HDC hdcMask, hdcBitmap; - INT nIndex, nImageCount, nMaskXOffset=0; + HDC hdcBitmap; + INT nIndex, nImageCount; BITMAP bmp; HBITMAP hOldBitmap; - HBITMAP hMaskBitmap=0; COLORREF bkColor; + int i; TRACE("himl=%p hbitmap=%p clrmask=%lx\n", himl, hBitmap, clrMask); if (!is_valid(himl)) @@ -292,6 +301,8 @@ if (!GetObjectA (hBitmap, sizeof(BITMAP), &bmp)) return -1; + TRACE("bitmap is %d x %d, himl is %d x %d\n", + bmp.bmWidth, bmp.bmHeight, himl->cx, himl->cy); if (himl->cx > 0) nImageCount = bmp.bmWidth / himl->cx; else @@ -304,67 +315,55 @@ hdcBitmap = CreateCompatibleDC(0); - hOldBitmap = SelectObject(hdcBitmap, hBitmap); - if(himl->hbmMask) - { - hdcMask = himl->hdcMask; - nMaskXOffset = nIndex * himl->cx; - } - else - { - /* - Create a temp Mask so we can remove the background of - the Image (Windows does this even if there is no mask) - */ - hdcMask = CreateCompatibleDC(0); - hMaskBitmap = CreateBitmap(bmp.bmWidth, bmp.bmHeight, 1, 1, NULL); - SelectObject(hdcMask, hMaskBitmap); - nMaskXOffset = 0; - } + /* create monochrome image to the mask bitmap */ bkColor = (clrMask != CLR_DEFAULT) ? clrMask : GetPixel (hdcBitmap, 0, 0); - SetBkColor (hdcBitmap, bkColor); - BitBlt (hdcMask, - nMaskXOffset, 0, bmp.bmWidth, bmp.bmHeight, - hdcBitmap, 0, 0, - SRCCOPY); - SetBkColor(hdcBitmap, RGB(255,255,255)); - /*Remove the background from the image - */ - /* - WINDOWS BUG ALERT!!!!!! - The statement below should not be done in common practice - but this is how ImageList_AddMasked works in Windows. - It overwrites the original bitmap passed, this was discovered - by using the same bitmap to iterate the different styles - on windows where it failed (BUT ImageList_Add is OK) - This is here in case some apps rely on this bug - */ - BitBlt(hdcBitmap, - 0, 0, bmp.bmWidth, bmp.bmHeight, - hdcMask, - nMaskXOffset, 0, - 0x220326); /* NOTSRCAND */ - /* Copy result to the imagelist - */ - BitBlt (himl->hdcImage, - nIndex * himl->cx, 0, bmp.bmWidth, bmp.bmHeight, - hdcBitmap, - 0, 0, - SRCCOPY); + for (i=nIndex; i<himl->cCurImage; i++) { + if (himl->hbmMask) { + SetBkColor (hdcBitmap, bkColor); + + BitBlt (himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, + hdcBitmap, himl->cx*(i-nIndex), 0, + SRCCOPY); + + SetBkColor(hdcBitmap, RGB(255,255,255)); + /*Remove the background from the image + */ + /* + WINDOWS BUG ALERT!!!!!! + The statement below should not be done in common practice + but this is how ImageList_AddMasked works in Windows. + It overwrites the original bitmap passed, this was discovered + by using the same bitmap to iterate the different styles + on windows where it failed (BUT ImageList_Add is OK) + This is here in case some apps rely on this bug + */ + BitBlt(hdcBitmap, + himl->cx*(i-nIndex), 0, himl->cx, himl->cy, + himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + 0x220326); /* NOTSRCAND */ + } + /* Copy result to the imagelist + */ + BitBlt (himl->hdcImage, + index2x(i,himl->cx), index2y(i,himl->cy), + himl->cx, himl->cy, + hdcBitmap, + himl->cx*(i-nIndex), 0, + SRCCOPY); + } + /* Clean up */ + SelectObject(hdcBitmap, hOldBitmap); DeleteDC(hdcBitmap); - if(!himl->hbmMask) - { - DeleteObject(hMaskBitmap); - DeleteDC(hdcMask); - } - return nIndex; } @@ -478,19 +477,20 @@ /* image */ SelectObject (hdcBmp, hbmTempImage); StretchBlt (hdcBmp, 0, 0, himlSrc->cx, himlSrc->cy, - himlDst->hdcImage, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - SRCCOPY); + himlDst->hdcImage, index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), + himlDst->cx, himlDst->cy, SRCCOPY); /* mask */ SelectObject (hdcBmp, hbmTempMask); StretchBlt (hdcBmp, 0, 0, himlSrc->cx, himlSrc->cy, - himlDst->hdcMask, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - SRCCOPY); + himlDst->hdcMask, index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), + himlDst->cx, himlDst->cy, SRCCOPY); /* copy (and stretch) source to destination */ /* image */ - StretchBlt (himlDst->hdcImage, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - himlSrc->hdcImage, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, - SRCCOPY); + StretchBlt (himlDst->hdcImage, index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), + himlDst->cx, himlDst->cy, + himlSrc->hdcImage, index2x(iSrc,himlSrc->cx), index2y(iSrc,himlSrc->cy), + himlSrc->cx, himlSrc->cy, SRCCOPY); /* mask */ StretchBlt (himlDst->hdcMask, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, himlSrc->hdcMask, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, @@ -511,13 +511,17 @@ } else { /* copy image */ - StretchBlt (himlDst->hdcImage, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - himlSrc->hdcImage, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, + StretchBlt (himlDst->hdcImage, + index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), himlDst->cx, himlDst->cy, + himlSrc->hdcImage, + index2x(iSrc,himlSrc->cx), index2y(iSrc,himlSrc->cy), himlSrc->cx, himlSrc->cy, SRCCOPY); /* copy mask */ - StretchBlt (himlDst->hdcMask, iDst * himlDst->cx, 0, himlDst->cx, himlDst->cy, - himlSrc->hdcMask, iSrc * himlSrc->cx, 0, himlSrc->cx, himlSrc->cy, + StretchBlt (himlDst->hdcMask, + index2x(iDst,himlDst->cx), index2y(iDst,himlDst->cy), himlDst->cx, himlDst->cy, + himlSrc->hdcMask, + index2x(iSrc,himlSrc->cx), index2y(iSrc,himlSrc->cy), himlSrc->cx, himlSrc->cy, SRCCOPY); } @@ -597,15 +601,15 @@ himl->uBitsPixel = (UINT)GetDeviceCaps (himl->hdcImage, BITSPIXEL); if (himl->cMaxImage > 0) { - himl->hbmImage = ImageList_CreateImage(himl->hdcImage, himl, cx * himl->cMaxImage, cy); + himl->hbmImage = ImageList_CreateImage(himl->hdcImage, himl, + count2x(himl->cMaxImage,cx), cy*PER_ROW); SelectObject(himl->hdcImage, himl->hbmImage); } else himl->hbmImage = 0; if ((himl->cMaxImage > 0) && (himl->flags & ILC_MASK)) { - himl->hbmMask = - CreateBitmap (himl->cx * himl->cMaxImage, himl->cy, - 1, 1, NULL); + himl->hbmMask = CreateBitmap (count2x(himl->cMaxImage,himl->cx), + himl->cy * PER_ROW, 1, 1, NULL); if (himl->hbmMask == 0) { ERR("Error creating mask bitmap!\n"); goto cleanup; @@ -1053,7 +1057,7 @@ */ BOOL WINAPI -ImageList_DrawIndirect (IMAGELISTDRAWPARAMS *pimldp) +ImageList_DrawIndirect (IMAGELISTDRAWPARAMS *pimldp) { INT cx, cy, lx, ly, nOvlIdx; DWORD fState, dwRop; @@ -1068,8 +1072,8 @@ if (!is_valid(himl)) return FALSE; if ((pimldp->i < 0) || (pimldp->i >= himl->cCurImage)) return FALSE; - lx = himl->cx * pimldp->i + pimldp->xBitmap; - ly = pimldp->yBitmap; + lx = index2x(pimldp->i,himl->cx) + pimldp->xBitmap; + ly = index2y(pimldp->i,himl->cy) + pimldp->yBitmap; fState = pimldp->cbSize < sizeof(IMAGELISTDRAWPARAMS) ? ILS_NORMAL : pimldp->fState; fStyle = pimldp->fStyle & ~ILD_OVERLAYMASK; @@ -1187,10 +1191,11 @@ if ( (nOvlIdx >= 1) && (nOvlIdx <= MAX_OVERLAYIMAGE)) { nOvlIdx = himl->nOvlIdx[nOvlIdx - 1]; if ((nOvlIdx >= 0) && (nOvlIdx < himl->cCurImage)) { - const INT ox = himl->cx * nOvlIdx + pimldp->xBitmap; + const INT ox = index2x(nOvlIdx,himl->cx) + pimldp->xBitmap; + const INT oy = index2y(nOvlIdx,himl->cy) + pimldp->yBitmap; if (himl->hbmMask && !(fStyle & ILD_IMAGE)) - BitBlt (hImageDC, 0, 0, cx, cy, hMaskListDC, ox, ly, SRCAND); - BitBlt (hImageDC, 0, 0, cx, cy, hImageListDC, ox, ly, SRCPAINT); + BitBlt (hImageDC, 0, 0, cx, cy, hMaskListDC, ox, oy, SRCAND); + BitBlt (hImageDC, 0, 0, cx, cy, hImageListDC, ox, oy, SRCPAINT); } } @@ -1259,11 +1264,13 @@ if (himlDst) { - BitBlt (himlDst->hdcImage, 0, 0, himlSrc->cCurImage * himlSrc->cx, himlSrc->cy, + BitBlt (himlDst->hdcImage, 0, 0, + count2x(himlSrc->cCurImage,himlSrc->cx), himlSrc->cy*PER_ROW, himlSrc->hdcImage, 0, 0, SRCCOPY); if (himlDst->hbmMask) - BitBlt (himlDst->hdcMask, 0, 0, himlSrc->cCurImage * himlSrc->cx, himlSrc->cy, + BitBlt (himlDst->hdcMask, 0, 0, + count2x(himlSrc->cCurImage,himlSrc->cx), himlSrc->cy*PER_ROW, himlSrc->hdcMask, 0, 0, SRCCOPY); himlDst->cCurImage = himlSrc->cCurImage; @@ -1421,7 +1428,9 @@ hOldDstBitmap = SelectObject (hdcDst, ii.hbmMask); if (himl->hbmMask) { BitBlt (hdcDst, 0, 0, himl->cx, himl->cy, - himl->hdcMask, i * himl->cx, 0, SRCCOPY); + himl->hdcMask, + index2x(i,himl->cx), index2y(i,himl->cy), + SRCCOPY); } else PatBlt (hdcDst, 0, 0, himl->cx, himl->cy, BLACKNESS); @@ -1429,7 +1438,8 @@ /* draw image*/ SelectObject (hdcDst, ii.hbmColor); BitBlt (hdcDst, 0, 0, himl->cx, himl->cy, - himl->hdcImage, i * himl->cx, 0, SRCCOPY); + himl->hdcImage, + index2x(i,himl->cx), index2y(i,himl->cy), SRCCOPY); /* * CreateIconIndirect requires us to deselect the bitmaps from @@ -1531,11 +1541,10 @@ pImageInfo->hbmImage = himl->hbmImage; pImageInfo->hbmMask = himl->hbmMask; - pImageInfo->rcImage.top = 0; - pImageInfo->rcImage.bottom = himl->cy; - pImageInfo->rcImage.left = i * himl->cx; - pImageInfo->rcImage.right = (i+1) * himl->cx; - + pImageInfo->rcImage.top = index2y(i,himl->cy); + pImageInfo->rcImage.bottom = index2y(i,himl->cy)+himl->cy; + pImageInfo->rcImage.left = index2x(i,himl->cx); + pImageInfo->rcImage.right = index2x(i,himl->cx)+himl->cx; return TRUE; } @@ -1566,11 +1575,10 @@ if ((i < 0) || (i >= himl->cCurImage)) return FALSE; - lpRect->left = i * himl->cx; - lpRect->top = 0; + lpRect->left = index2x(i,himl->cx); lpRect->right = lpRect->left + himl->cx; - lpRect->bottom = himl->cy; - + lpRect->top = index2y(i,himl->cy); + lpRect->bottom = lpRect->top + himl->cy; return TRUE; } @@ -1724,7 +1732,6 @@ HIMAGELIST himlDst = NULL; INT cxDst, cyDst; INT xOff1, yOff1, xOff2, yOff2; - INT nX1, nX2; TRACE("(himl1=%p i1=%d himl2=%p i2=%d dx=%d dy=%d)\n", himl1, i1, himl2, i2, dx, dy); @@ -1768,25 +1775,29 @@ if (himlDst) { - nX1 = i1 * himl1->cx; - nX2 = i2 * himl2->cx; + int x1, x2, y1, y2; + + x1 = index2x(i1,himl1->cx); + y1 = index2y(i1,himl1->cy); + x2 = index2x(i2,himl2->cx); + y2 = index2y(i2,himl2->cy); /* copy image */ BitBlt (himlDst->hdcImage, 0, 0, cxDst, cyDst, himl1->hdcImage, 0, 0, BLACKNESS); if (i1 >= 0 && i1 < himl1->cCurImage) - BitBlt (himlDst->hdcImage, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcImage, nX1, 0, SRCCOPY); + BitBlt (himlDst->hdcImage, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcImage, x1, y1, SRCCOPY); if (i2 >= 0 && i2 < himl2->cCurImage) { - BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask , nX2, 0, SRCAND); - BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcImage, nX2, 0, SRCPAINT); + BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask , x2, y2, SRCAND); + BitBlt (himlDst->hdcImage, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcImage, x2, y2, SRCPAINT); } /* copy mask */ BitBlt (himlDst->hdcMask, 0, 0, cxDst, cyDst, himl1->hdcMask, 0, 0, WHITENESS); if (i1 >= 0 && i1 < himl1->cCurImage) - BitBlt (himlDst->hdcMask, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcMask, nX1, 0, SRCCOPY); + BitBlt (himlDst->hdcMask, xOff1, yOff1, himl1->cx, himl1->cy, himl1->hdcMask, x1, y1, SRCCOPY); if (i2 >= 0 && i2 < himl2->cCurImage) - BitBlt (himlDst->hdcMask, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask, nX2, 0, SRCAND); + BitBlt (himlDst->hdcMask, xOff2, yOff2, himl2->cx, himl2->cy, himl2->hdcMask, x2, y2, SRCAND); himlDst->cCurImage = 1; } @@ -1862,6 +1873,7 @@ nheight = cy; nRows = (height/cy); + FIXME("nwidth %d, nheight %d, cy %d\n", nwidth, nheight, cy); if (bitsperpixel==1) hbitmap = CreateBitmap(nwidth,nheight,1,1,NULL); else @@ -2048,36 +2060,36 @@ for (nCount = 0; nCount < MAX_OVERLAYIMAGE; nCount++) himl->nOvlIdx[nCount] = -1; - hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, himl->cMaxImage * himl->cx, himl->cy); + hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, + count2x(himl->cMaxImage,himl->cx), himl->cy*PER_ROW); SelectObject (himl->hdcImage, hbmNewImage); DeleteObject (himl->hbmImage); himl->hbmImage = hbmNewImage; if (himl->hbmMask) { - hbmNewMask = CreateBitmap (himl->cMaxImage * himl->cx, himl->cy, + hbmNewMask = CreateBitmap (count2x(himl->cMaxImage,himl->cx), himl->cy*PER_ROW, 1, 1, NULL); SelectObject (himl->hdcMask, hbmNewMask); DeleteObject (himl->hbmMask); himl->hbmMask = hbmNewMask; } - } - else { + } else { /* delete one image */ TRACE("Remove single image! %d\n", i); /* create new bitmap(s) */ nCount = (himl->cCurImage + himl->cGrow - 1); - cxNew = nCount * himl->cx; + cxNew = count2x(nCount , himl->cx); TRACE(" - Number of images: %d / %d (Old/New)\n", himl->cCurImage, himl->cCurImage - 1); TRACE(" - Max. number of images: %d / %d (Old/New)\n", himl->cMaxImage, himl->cCurImage + himl->cGrow - 1); - hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, cxNew, himl->cy); + hbmNewImage = ImageList_CreateImage(himl->hdcImage, himl, cxNew, himl->cy*PER_ROW); if (himl->hbmMask) - hbmNewMask = CreateBitmap (cxNew, himl->cy, 1, 1, NULL); + hbmNewMask = CreateBitmap (cxNew, himl->cy*PER_ROW, 1, 1, NULL); else hbmNewMask = 0; /* Just to keep compiler happy! */ @@ -2085,31 +2097,45 @@ /* copy all images and masks prior to the "removed" image */ if (i > 0) { - TRACE("Pre image copy: Copy %d images\n", i); + int n = count2x(i,1); - SelectObject (hdcBmp, hbmNewImage); - BitBlt (hdcBmp, 0, 0, i * himl->cx, himl->cy, - himl->hdcImage, 0, 0, SRCCOPY); - - if (himl->hbmMask) { - SelectObject (hdcBmp, hbmNewMask); - BitBlt (hdcBmp, 0, 0, i * himl->cx, himl->cy, - himl->hdcMask, 0, 0, SRCCOPY); + TRACE("Pre image copy: Copy %d images\n", i); + if (n) { /* copy started rows */ + SelectObject (hdcBmp, hbmNewImage); + BitBlt (hdcBmp, 0, 0, n * himl->cx, himl->cy * PER_ROW, + himl->hdcImage, 0, 0, SRCCOPY); + + if (himl->hbmMask) { + SelectObject (hdcBmp, hbmNewMask); + BitBlt (hdcBmp, 0, 0, n * himl->cx, himl->cy * PER_ROW, + himl->hdcMask, 0, 0, SRCCOPY); + } } + /* this might copy some images more. But we will + * overwrite them right afterwards */ } /* copy all images and masks behind the removed image */ if (i < himl->cCurImage - 1) { + int j; + TRACE("Post image copy!\n"); - SelectObject (hdcBmp, hbmNewImage); - BitBlt (hdcBmp, i * himl->cx, 0, (himl->cCurImage - i - 1) * himl->cx, - himl->cy, himl->hdcImage, (i + 1) * himl->cx, 0, SRCCOPY); + + /* copy the post-i images one-by-one */ + SelectObject (hdcBmp, hbmNewImage); + for (j=i;j<himl->cCurImage -1;j++) + BitBlt (hdcBmp, index2x(j,himl->cx), index2y(j,himl->cy), himl->cx, himl->cy, + himl->hdcImage, index2x(j+1,himl->cx), index2y(j+1,himl->cy), SRCCOPY); if (himl->hbmMask) { SelectObject (hdcBmp, hbmNewMask); - BitBlt (hdcBmp, i * himl->cx, 0, - (himl->cCurImage - i - 1) * himl->cx, - himl->cy, himl->hdcMask, (i + 1) * himl->cx, 0, SRCCOPY); + for (j=i;j<himl->cCurImage -1;j++) + BitBlt (hdcBmp, + index2x(j,himl->cx), index2y(j,himl->cy), + himl->cx, himl->cy, + himl->hdcMask, + index2x(j+1,himl->cx), index2y(j+1,himl->cy), + SRCCOPY); } } @@ -2290,12 +2316,16 @@ SetBkColor (himl->hdcImage, RGB(255,255,255)); hbmOldSrc = SelectObject (hdcImage, ii.hbmColor); - StretchBlt (himl->hdcImage, nIndex * himl->cx, 0, himl->cx, himl->cy, - hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, SRCCOPY); + StretchBlt (himl->hdcImage, + index2x(nIndex,himl->cx), index2y(nIndex,himl->cy), + himl->cx, himl->cy, + hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, SRCCOPY); if (himl->hbmMask) { SelectObject (hdcImage, ii.hbmMask); - StretchBlt (himl->hdcMask, nIndex * himl->cx, 0, himl->cx, himl->cy, + StretchBlt (himl->hdcMask, + index2x(nIndex,himl->cx), index2y(nIndex,himl->cy), + himl->cx, himl->cy, hdcImage, 0, 0, bmp.bmWidth, bmp.bmHeight, SRCCOPY); }

2 1

wininet useragent implementation
by Vijay Kiran Kamuju 17 Feb '06

17 Feb '06

Hi, If anyone has enough patience, please look into my wininet useragent patch. It adds InternetSetOption and InternetQueryOption for INTERNET_OPTION_USER_AGENT. It is still not complete, it still has some bugs. Please fix/improve the implementation and submit it to the wine-patches I will not be available for a week or more. (a month) I have submitted some new tests for wininet. Thanks and Regards, Vijay

1 0

Re: ntdll: Don't Use wine_sigaction on systems without SYS_sigaction
by Alexandre Julliard 17 Feb '06

17 Feb '06

Robert Shearman <rob(a)codeweavers.com> writes: > ChangeLog: > Some systems don't define SYS_sigaction as they use realtime > signals. On these systems wine_sigaction shouldn't be needed as it is > there to work around bugs with missing sigaltstack support in glibc, > so make the usage of wine_sigaction depend on SYS_sigaction being > defined. Do you really have a platform that doesn't define it? The only case I know about is building on x86_64 with the wrong kernel headers, and in that case we very much want it to fail. -- Alexandre Julliard julliard(a)winehq.org

1 0

GL texture problems
by Stefan Dösinger 17 Feb '06

17 Feb '06

Hello, I'm trying to change IWineD3DSurface::UnlockRect for rendertargets to avoid glDrawPixels. Instead, I'd like to load the image from memory into an OpenGL texture, and draw that texture with a textured quad onto the front / back buffer. The problem I have is that the texture(or better, the resulting image) only has a solid color: The color of the first pixel in the source memory. I've read the texture section of the GL programming guide, but I didn't find a solution. I've attached a patch with my changes. The reason why I want to make this change is that glDrawPixels and glReadPixels are horribly slow on radeon cards, they take a few secounds for a 1024x768 image. The current code doesn't work for the open source driver at any color depth(mesa software acceleration doesn't work eighter), and it's broken for some color depths with the fglrx driver.

4 8

Re: winspool: Add SetDefaultPrinterA/W, with tests and doc
by James Hawkins 17 Feb '06

17 Feb '06

On 2/16/06, Detlef Riekenberg <wine.dev(a)web.de> wrote: > > Split the Patch does not work: wine will crash on unimplemented function > I don't know if the patch hasn't been accepted because of size or what, but if it is size, the best way to split the patch up is: 1) Add a stub for the new function, with documentation 2) Add the tests 3) Send in the implementation, changing the passing tests accordingly -- James Hawkins

1 0

Re: What to do??? -- WINE 0.9.3-0.9.7 and Photoshop 7
by Aleksey 16 Feb '06

16 Feb '06

K, Photoshop 7 works good like it used to with 0.9.2 now, no visible difference yet. I think I'll unsubscribe from wine-devel on this email and sign up with my other email, it won't cause any cofusion, will it? Oops, sorry Hiji, I meant to send it to the list and sent it to you. Second time I've done this. Argh. On 2/16/06, Aleksey <anime4christ(a)gmail.com> wrote: > K, Photoshop 7 works good like it used to with 0.9.2 now, no visible > difference yet. > I think I'll unsubscribe from wine-devel on this email and sign up > with my other email, it won't cause any cofusion, will it? > > On 2/15/06, Hiji <hijinio(a)yahoo.com> wrote: > > > > On Tuesday 14 February 2006 22:12, Hiji wrote: > > > > > Can anybody help? > > > > > > > > Did you try latest CVS? I don't have PS7, but this > > > > patch went in on Saturday > > > > and might be related (If I recall correctly, > > > Martin > > > > mentioned the PS7 > > > > breakage): > > > > > http://source.winehq.org/git/?p=wine.git;a=commit;h=c362d7c35ba3c02d68a9b7e… > > > > > > Martin just replied to me. I don't pull out of CVS; > > > so, I'll wait for the next release! > > > > > > If it doesn't work out, then I'll report back. > > > > > > Thanks! > > > Hijinio > > > > > > Thumbs up! Photoshop 7 runs once again via 0.9.8. > > Though, I didn't try installing it (I just carried > > over my .wine folder.) > > > > Thanks to everyone! MANY people will be happy again! > > > > Hiji > > > > __________________________________________________ > > Do You Yahoo!? > > Tired of spam? Yahoo! Mail has the best spam protection around > > http://mail.yahoo.com > > > > > > >

1 0

re: What would most aid WINE development?
by Daniel Kegel 16 Feb '06

16 Feb '06

Susheel Daswani wrote: > For my 'Antitrust & IP' course this semester I am writing a brief > about why I think the remedy in the Microsoft antitrust case was > inadequate. Back in the day, I wrote an essay about this; it's online at http://kegel.com/remedy/ in particular, http://www.usdoj.gov/atr/cases/ms_tuncom/major/mtc-00028571.htm I now think my essay was naive, but hey, I was young :-) It would be interesting to see the complaints sent to the Technical Committee ( http://www.thetc.org/ ) but I doubt they're public. You might also want to read http://www.lessig.org/content/testimony/msft/msft.pdf if you haven't already. > So my question for the WINE developers is "What materials from > Microsoft would most aid the development of WINE"? The Windows API is > of course public, so my guess is that isn't a huge bar to creating > WINE. So what are the bars? Is it simply the scope of the project? > Is there information that MS could divulge that would greatly aid the > WINE effort? Would open sourcing part of Windows help? As others have noted, the Windows API is not completely public nor particularly well-defined. This makes things harder, but it's not really the main obstacle. Here are a few things a judge could order Microsoft to do that would help Wine: * order them to break up into two companies, one for operating systems and .net, one for everything else * donate gobs of cash to Wine * offer a perpetual, transferrable, royalty-free, GPL-compatible license for its protocols and data formats * support ODF in Microsoft Office That last item is kind of indirect. It would make it much easier for everybody to switch to OpenOffice, which would make it much easier for everybody to switch to Linux, which is the whole point of Wine. - Dan -- Wonder why Aunt Tilly still won't use Linux? See http://kegel.com/linux/comfort

9 12

riched20_crosstest.exe does not build (-lriched20)
by Detlef Riekenberg 16 Feb '06

16 Feb '06

Hi. While testing for bug #4567 ( http://bugs.winehq.org/show_bug.cgi?id=4567 ): riched20_crosstest.exe does not Build: /usr/lib/gcc/i586-mingw32msvc/3.4.2/../../../../i586-mingw32msvc/bin/ld: cannot find -lriched20 Is this the same Problem for "winetest-latest.*" still dated 10.Feb ? -- By By ... ... Detlef

2 1

Re: WINE 0.9.3 and Photoshop 7 & CS
by Aleksey 16 Feb '06

16 Feb '06

The patch has been found that breaks Photoshop, but 0.9.6 still brakes PS. On 1/6/06, Aleksey <anime4christ(a)gmail.com> wrote: > Great! Thanks! > > On 1/1/06, Elvis Pranskevichus <elprans(a)gmail.com> wrote: > > Aleksey wrote: > > > Yesterday I upgraded to WINE 0.9.3, and then tried running Photoshop > > > 7. Photoshop gave me a hardware error. I thought, no problem, I'll > > > just reinstall it, same result. Then I reconfigured WINE using > > > winetools and tried again, same thing. Here is what I got in the > > > Terminal when running Photoshop 7: > > > > > > fixme:actctx:QueryActCtxW stub! > > > fixme:font:WineEngRemoveFontResourceEx :stub > > > fixme:win:EnumDisplayDevicesW ((null),0,0x7fa7de2c,0x00000000), stub! > > > fixme:win:EnumDisplayDevicesW > > > (L"\\\\.\\DISPLAY1",0,0x7fa7de2c,0x00000000), stub! > > > fixme:mscms:EnumColorProfilesA ( (nil), 0x7fa7e694, 0x7fa7e1ac, > > > 0x7fa7e6f4, 0x7fa7e704 ) stub > > > fixme:win:EnumDisplayDevicesW ((null),0,0x7fa7de34,0x00000000), stub! > > > fixme:win:EnumDisplayDevicesW > > > (L"\\\\.\\DISPLAY1",0,0x7fa7de34,0x00000000), stub! > > > fixme:mscms:EnumColorProfilesA ( (nil), 0x7fa7e69c, 0x7fa7e1b4, > > > 0x7fa7e6fc, 0x7fa7e70c ) stub > > > err:shell:HCR_GetFolderAttributes HCR_GetFolderAttributes should be > > > called for simple PIDL's only! > > > fixme:font:WineEngRemoveFontResourceEx :stub > > > fixme:font:WineEngRemoveFontResourceEx :stub > > > > > > Then I tried installing Photoshop CS, knowing that it worked fine with > > > 0.9.2. Photoshop CS told me that certain required files was missing, > > > but I forgot to get down the results from the Terminal. After that I > > > downgraded to WINE 0.9.2 and both versions of Photoshop work great. > > > > > > A little side note: ImageReady 7 works great under 0.9.3, I did not > > > test ImageReady CS. ImageReady 7 works great under 0.9.2 also, but > > > ImageReady CS crashes. > > > > > > God Bless. > > > - Aleksey > > > > > > > > > > Hi, > > > > I've found the patch that breaks the thing. GIT commit-ish is 0b17529332b0ef5ee57873afd4ded6f359e76781. (http://source.winehq.org/git/?p=wine.git;a=commit;h=0b17529332b0ef5ee57873a…). > > > > I haven't looked at it deeply, just done some git bisect's. > > > > -- > > Elvis Pranskevichus - elprans(a)gmail.com > > > > >

3 6

Small and Fast (was: Re: Add InitializeSecurityContext for schannel)
by Detlef Riekenberg 15 Feb '06

15 Feb '06

Am Dienstag, den 14.02.2006, 17:34 +0530 schrieb Vijay Kiran Kamuju: > Add InitializeSecurityContext for schannel in secur32.dll +static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW( + PCredHandle phCredential, PCtxtHandle phContext, SEC_WCHAR *pszTargetName, + ULONG fContextReq, ULONG Reserved1, ULONG TargetDataRep, + PSecBufferDesc pInput,ULONG Reserved2, PCtxtHandle phNewContext, + PSecBufferDesc pOutput, ULONG *pfContextAttr, PTimeStamp ptsExpiry) +{ I Remembered a statement from fefe (diet-libc => www.fefe.de) about "Writing Small and Fast Software": It is still clear, what each Argument does, when you remove the Variable-Names from the Declaration? - Yes: Efficient Design. - No: Your Interface is to generic == bloated static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW( PCredHandle, PCtxtHandle, SEC_WCHAR *, ULONG, ULONG, ULONG, PSecBufferDesc, ULONG, PCtxtHandle, PSecBufferDesc, ULONG, PTimeStamp) { We all should thank the People who did such a Design :-) -- By By ... ... Detlef

2 2

Small and Fast (was: Re: Add InitializeSecurityContext for schannel)
by Vijay Kiran Kamuju 15 Feb '06

15 Feb '06

Hi all, I copied it from the negotiate.c In other places like ntlm.c, its like that only. Im not the one who actually designed secur32 ;) :P If i did anything worng please correct me. bye, Vijay On 2/15/06, Marcus Meissner <marcus(a)jet.franken.de> wrote: > On Tue, Feb 14, 2006 at 11:22:09PM +0100, Detlef Riekenberg wrote: > > Am Dienstag, den 14.02.2006, 17:34 +0530 schrieb Vijay Kiran Kamuju: > > > > > Add InitializeSecurityContext for schannel in secur32.dll > > > > +static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW( > > + PCredHandle phCredential, PCtxtHandle phContext, SEC_WCHAR > > *pszTargetName, > > + ULONG fContextReq, ULONG Reserved1, ULONG TargetDataRep, > > + PSecBufferDesc pInput,ULONG Reserved2, PCtxtHandle phNewContext, > > + PSecBufferDesc pOutput, ULONG *pfContextAttr, PTimeStamp ptsExpiry) > > +{ > > > > I Remembered a statement from fefe (diet-libc => www.fefe.de) about > > "Writing Small and Fast Software": > > > > It is still clear, what each Argument does, when you remove the > > Variable-Names from the Declaration? > > - Yes: Efficient Design. > > - No: Your Interface is to generic == bloated > > > > static SECURITY_STATUS SEC_ENTRY schan_InitializeSecurityContextW( > > PCredHandle, PCtxtHandle, SEC_WCHAR *, ULONG, ULONG, ULONG, > > PSecBufferDesc, ULONG, PCtxtHandle, PSecBufferDesc, ULONG, PTimeStamp) > > { > > > > We all should thank the People who did such a Design :-) > > However, this only works in newer C compilers as far as I know... ;) > > Ciao, Marcus >

3 2

winspool: EnumMonitorsA/W implemented
by Detlef Riekenberg 15 Feb '06

15 Feb '06

Am Mittwoch, den 08.02.2006, 23:33 +0100 schrieb Detlef Riekenberg: > Changelog: > > - EnumMonitorsA/W implemented > - Registry-Entry for "Local Port" added (NT) > Return the Monitor-Entry for "Local Port" also, when the dll > failed to load (we do the work of localspl.dll in our winspool.drv) http://www.winehq.org/pipermail/wine-patches/2006-February/024172.html Anything wrong with this Patch? (Still applies and works in wine-0.9.8) -- By By ... ... Detlef

1 0

winspool/tests: Add tests for EnumMonitors()
by Detlef Riekenberg 15 Feb '06

15 Feb '06

Am Mittwoch, den 08.02.2006, 22:36 +0100 schrieb Detlef Riekenberg: > Changelog: > > - Add tests for EnumMonitors() > http://www.winehq.org/pipermail/wine-patches/2006-February/024171.html Anything wrong with this? (Still apply and works on wine-0.9.8) -- By By ... ... Detlef

1 0

Appdb thoughts
by Dan Kegel 15 Feb '06

15 Feb '06

Hi all, I've been using the Appdb a fair bit in the last couple months, maintaining a couple apps and their bug links, and doing some quick testing of apps I'm not the appdb maintainer for. Mostly I find the appdb adequate and usable, but I've noticed a few things that bug me. Here's a quick dump of what's on my mind: 1) The top 10 platinum, gold, and silver lists on the front page is helpful but appear to be manually maintained. It'd be helpful if there was a way to use the ratings while browsing or searching the appdb. 2) The links between bugzilla and the appdb are great. I really like seeing the list of bugs for each app. But the app db's orientation towards detailed rich text info about apps makes me wonder. I often do quick testing of apps for obvious bugs (like crashes) without really getting to know the app, and I don't feel qualified to say much about the app; I just want to link a bug to it. But the app db gets upset unless I fill in all sorts of info about the app. And unless I'm willing to be the app db maintainer for an app, that info is going to quickly get out of date. So I'd like a way to create an app db entry without filling in any info about the app besides a bug number. 3) It'd be nice if, when entering bugs in bugzilla, the web interface let me enter an appdb app id somehow. Not sure how to do that nicely. Anyway, that's what's on my mind. Tony disagrees with me about #2; he thinks once I've filed a bugzilla report for an app, I have everything I need to create a fully populated appdb entry. I can't quite put my finger on why I disagree with him. Comments, anyone? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

4 5

Wine and Font-Rendering, copy/paste (partial solution)
by Roland Kaser 15 Feb '06

15 Feb '06

Hello As seen on My previous post about copy/paste and font rendering, both functions does work on some systems but not on other. I made some test installations with SuSE 10 and wine 0.9.7 (the rpm version form Marcus) and found a partial solution: It seems that the font-rendering and copy/paste works on SuSE 10 (original installed system, without and SuSE online update). As soon the first SuSE Online Update was made, the font-rendering and copy/paste refuses to work. I'm currently not sure whats the exact reason for this behaviour. Does eventually somebody has close contacts to the SuSE developers and can discuss it with them? The Error is definitively reproducable on diffrent hardware types. Kind regards Roland Kaeser

1 0

Re: [RESENT] Don't duplicate handles for _get_osfhandle
by Alexandre Julliard 15 Feb '06

15 Feb '06

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Changelog: > wine/dlls/msvcrt/file.c: _get_osfhandle > Don't duplicate handles, otherwise they leak > > This time with test case that fails without the patch (but succeed with > native msvcrt). It would be nice to also add a test for the case that the DuplicateHandle was supposed to fix, so that we can avoid reintroducing that bug. -- Alexandre Julliard julliard(a)winehq.org

2 1

Startup time of OOo2, Firefox 1.5. Some surprises.
by Dan Kegel 15 Feb '06

15 Feb '06

To see how reasonable it might be to use OOo 2.0.1 and Firefox 1.5 under Wine routinely, I benchmarked their startup time on a Fedora Core 5 test 2 system under four conditions: native vs. with wine from cvs, and with 416MB RAM vs. 96 MB RAM (by booting with mem=96M; this was to simulate running on one of those cheapo 128MB boxes that uses shared video RAM). This was on a zippy Compaq Presario 3000 Athlon 64 3000+. All apps were downloaded from openoffice.org and mozilla.com. Results for first run of app after booting (1st column is startup time): 5 Firefox run1 native 416MB 12 Firefox run1 wine 416MB 11 Firefox run1 native 96MB 15 Firefox run1 wine 96MB 11 ooo run1 native 416MB 15 ooo run1 wine 416MB 60 ooo run1 native 96MB 37 ooo run1 wine 96MB So wine is 1.4 to 2.5 times slower at app startup generally, but when ram is really short, win32 openoffice starts up with wine 1.5 times *faster* than the native linux version! (Maybe because the Microsoft tools are better at avoiding I/O or relocations during loading?) I then measured how long it took to start up the app the second time, when the cache was nice and hot: 3 Firefox run2 native 416MB 4 Firefox run2 wine 416MB 4 ooo run2 native 416MB 6 ooo run2 wine 416MB 4 Firefox run2 native 96MB 6 Firefox run2 wine 96MB 36 ooo run2 native 96MB 28 ooo run2 wine 96MB The times are uniformly faster on the second run, but the patter holds, i.e. wine is 1.4-1.5 times slower than native generally, but win32 openoffice under wine is 1.5 times *faster* than the native version when starved for RAM. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 12

[d3d8] question about "bogus" code
by Christoph Frick 15 Feb '06

15 Feb '06

hiho as with newer versions more and more games i try no longer work (which worked with wine around 0.9.0) i try to find the reasons. i stumbled over this code in dlls/d3d8/surface.c: date: 2006-02-14 17:05:35 +0000; author: julliard; state: Exp; lines: +202 -319 Roderick Colenbrander <thunderbird2k(a)gmx.net> d3d8: Move d3d8 surface over to wined3d (based on the work of Oliver Stieber). 149 1.48 (julliard 14-Feb-06): if (This == D3D8_SURFACE_GET_DEVICE(This)->backBuffer || This == D3D8_SURFACE_GET_DEVICE(This)->renderTarget || This == D3D8_SURFACE_GET_DEVICE(This)->frontBuffer || D3D8_SURFACE_GET_DEVICE(This)->depthStencilBuffer) { 150 1.48 (julliard 14-Feb-06): if (This == D3D8_SURFACE_GET_DEVICE(This)->backBuffer) { 151 1.48 (julliard 14-Feb-06): TRACE("(%p, backBuffer) : rect@%p flags(%08lx), output lockedRect@%p, memory@%p\n", This, pRect, Flags, pLockedRect, D3D8_SURFACE(This)->resource.allocatedMemory); 152 1.48 (julliard 14-Feb-06): } else if (This == D3D8_SURFACE_GET_DEVICE(This)->frontBuffer) { 153 1.48 (julliard 14-Feb-06): TRACE("(%p, frontBuffer) : rect@%p flags(%08lx), output lockedRect@%p, memory@%p\n", This, pRect, Flags, pLockedRect, D3D8_SURFACE(This)->resource.allocatedMemory); 154 1.48 (julliard 14-Feb-06): } else if (This == D3D8_SURFACE_GET_DEVICE(This)->renderTarget) { 155 1.48 (julliard 14-Feb-06): TRACE("(%p, renderTarget) : rect@%p flags(%08lx), output lockedRect@%p, memory@%p\n", This, pRect, Flags, pLockedRect, D3D8_SURFACE(This)->resource.allocatedMemory); 156 1.48 (julliard 14-Feb-06): } else if (This == D3D8_SURFACE_GET_DEVICE(This)->depthStencilBuffer) { 157 1.48 (julliard 14-Feb-06): TRACE("(%p, stencilBuffer) : rect@%p flags(%08lx), output lockedRect@%p, memory@%p\n", This, pRect, Flags, pLockedRect, D3D8_SURFACE(This)->resource.allocatedMemory); 158 1.9 (julliard 17-May-03): } 159 1.9 (julliard 17-May-03): } else { 160 1.48 (julliard 14-Feb-06): TRACE("(%p) : rect@%p flags(%08lx), output lockedRect@%p, memory@%p\n", This, pRect, Flags, pLockedRect, D3D8_SURFACE(This)->resource.allocatedMemory); 161 1.9 (julliard 17-May-03): } why is in line 149 for the depthStencilBuffer check not comparing against This like in three checks before? if there is a reason, if would be good to have a comment there - otherwise it looks like an error. -- cu

4 3

DSOUND bugs
by Tomas Carnecky 15 Feb '06

15 Feb '06

I'm really wondering why nobody has fixed the DSOUND buffer underrun bugs.. I get lots of these message when I run World of Warcraft: err:wave:wodPlayer_ProcessMessages pcm_pause failed: Input/output error err:dsound:DSOUND_MixOne underrun on sound buffer 0x7fda2038 I can fix these buffer underruns partially by playing with the buffer size in asoundrc, but it never disappears completely. It gets worse if I also start TeamSpeak (which btw. uses 50% of the CPU)), but I can play videos using totem or mplayer or listen to music without any xruns. is it really unknown where the bug is? because I'm willing to test patches and helm looking where the bug might be.. tom

3 5

crosstool-0.40 status 2
by Dan Kegel 15 Feb '06

15 Feb '06

Since I'm developing on ubuntu, where the default compiler is gcc-4.0.x, I'm running into a lot of little problems (glibc-2.3.2 unhappy about gcc-4.0 during initial header installation, binutils-2.15 incomplete array type errors). Fortunately, having waited forever to do this update, googling for the errors is turning up proposed fixes. I've also included a few of the cygwin and mac doc fixes and one or two other little fixes people have contributed. I should have something for people to play with in a day or so. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 1

Wine Font Rendering
by Roland Kaser 14 Feb '06

14 Feb '06

Hello Sorry, this is the second post for this reason, but it's important for me to sort this problem out. Can somebody try to get a answer? I noticed a strange behavior of the Font/Vector objects functionality of Corel Draw on diffrent SuSE 10 Systems. On one system Rotated Text works fine (without any failure) on a other system, rotated fonts became invisible on the screen. At pdf export, the fonts are normally visible. So it seems to be a graphics subsystem error. No winedebug output at all. Can somebody tell me which system libraries used for the font rendering functions? So that I can compare the two systems to find out where the font-rendering error cames from. Many thanks Roland Kaeser

4 3

Re: Appdb thoughts
by Chris Morgan 14 Feb '06

14 Feb '06

> Unfortunately, I'm not volunteering since I know nothing about the codebase > for either project, but it is really just a matter of creating a new table > and adding a field or two to the existing tables (and updating the > interface, of course). Its written in php and the source is available through cvs if you are interested in taking a look. We can always use help. Chris

1 0

Refcounting fun
by H. Verbeet 14 Feb '06

14 Feb '06

I've run into a somewhat annoying problem with d3d9/wined3d recently. It appears that on d3d9 on Windows a surface either forwards its AddRef / Release calls to its container if it has one, or just shares the refcount directly. Either way, it comes down to the same thing. Calling AddRef on the surface increases the texture's refcount and calling AddRef on the texture increases the surface's refcount. Same thing for Release. As a consequence, on Windows, it's perfectly legal to do something like this: /* Create a texture */ IDirect3DDevice9_CreateTexture() /* Get a surface. Adds a reference to the surface/texture combination */ IDirect3DTexture9_GetSurfaceLevel() /* Release the texture. Note that the texture isn't freed yet, because we still hold a reference to the surface */ IDirect3DTexture9_Release() <Do some stuff with the surface, perhaps call GetContainer, etc> /* Release the surface. The texture and all of it's surfaces will now be released. */ IDirect3DSurface9_Release() In wine, the call to IDirect3DTexture9_Release() frees the texture. (It also calls Release on it's surfaces, but since the surface had an extra reference from the call to GetSurfaceLevel the surface is still ok). Calling any function on the surface that needs access to the container will now have undefines results, most likely a crash. Naively, I tried to fix this by having the surface keep a reference to it's container. That keeps the code above from crashing, but only because it creates a circular reference between the surface and the container. Oops. Fixing the problem for wined3d is probably not even that hard. Just separate the Release code from the Cleanup code, then have WineD3DSurface forward its AddRef / Release calls to the container, if it has one. The container can then call the Cleanup code for its surfaces when it gets deleted. However, there is another problem, related to the way d3d9 (and ddraw/d3d7/d3d8, when their respective rewrites are finished) wraps wined3d. After fixing the problem for wined3d as above, the relation between IDirect3DSurface9 and IDirect3DTexture9 in wine would look roughly like this: |-------------------| |-------------------| | IDirect3DSurface9 | | IDirect3DTexture9 | |-------------------| |-------------------| ^ ^ | | |----------------| |----------------| | WineD3DSurface |<--------->| WineD3DTexture | |----------------| |----------------| WineD3DSurface and WineD3DTexture "share" reference counts, IDirect3DSurface9 keeps a reference to WineD3DSurface, and IDirect3DTexture keeps a reference to WineD3DTexture. WineD3DSurface and WineD3DTexture don't keep references to their parents (and can't, without creating circular references). So releasing the texture before the surface would still not work, since the d3d9 texture still has only 1 reference, the one it got when it was created. That means that in the call to IDirect3DTexture9_Release the d3d9 texture gets freed, while the wined3d texture doesn't. When we do something with the d3d9 surface that needs the container, the wined3d surface correctly returns its container, but when d3d9 then tries to get the parent of that container it still dies. One way to solve this would be to have wined3d handle the reference counting for d3d7/8/9 as well, so that their AddRef/Release calls just call AddRef/Release on the wined3d object they wrap. That would also mean we need to pass a pointer to the d3d7/8/9 object's cleanup function. (Releasing a d3d9 surface to 0 should cause a d3d9 texture to be freed). Note that for creating a texture, currently a similair construction is used, in that IWineD3DDeviceImpl_CreateTexture gets passed a pointer to a d3d9 surface create function, in order to create the texture's surfaces. Obviously doing all that would be quite a change in the way d3d is setup in wine, and would also have some implications for the d3d7 and d3d8 rewrites. I'm wondering if this solution would be acceptable, and whether perhaps there are other, better solutions. Anyone care to comment?

2 14

WINEMP3: increase factor from 4 to 12 in MPEG3_StreamSize
by Alex Villacís Lasso 14 Feb '06

14 Feb '06

This is a summary of what I have been doing with winemp3 over the weekend. First, the idea of a GStreamer wrapper for wine is a no-go because 1) would not solve the jittering problem (more on this later), 2) I have not found yet a streaming source for raw memory buffers (as opposed to file/network streaming), 3) although GStreamer is LGPL, some of the codecs might be proprietary, and this might cause legal problems later on. I fired the ACMAPP.EXE demo program from MSDN (the one I used to improve the msacm implementation), and noticed that MP3-encoded WAV files play almost normally with this app. This means that the codec itself is not the problem - the most likely source is the (odd?) use of msacm by dsound, which is in turn invoked by native quartz.dll. Before reaching this conclusion, I found that ACMAPP.EXE played the files without jittering, but it stopped playing a few moments before the end of the song. How much before depends on the actual length of the song but this was annoying enough to be worth investigating. For example, one sample song stopped playing 30 seconds before the actual end. However, according to the app, playback was already at the end of the song. It turns out that mpglib has a queue of undecoded data in its decoding structure. On every call to the decodeMP3() function of mpglib, the caller specifies either a buffer of new data, or NULL to use the remaining data from a previous invocation. The buffer grows and shrinks dynamically with the amount of unencoded data passed by the caller. What was going on was the following: - Caller (winmm) computes required output buffer for encoded input buffer. This uses acmStreamSize, which in turn invokes MPEG3_StreamSize. - MPEG3_StreamSize return a factor 4X for the size of the output buffer (in my tests, a 2333-byte encoded buffer expands into (at most) 9332 bytes of output, or so reports winemp3). - winmm happily calls acmStreamConvert() with a 2333 source buffer and a 9332 destination buffer. - mpglib decodes as much as it can into the 9332-byte buffer. However, in almost all cases, 9332 bytes is not enough to decode 2333 bytes of MP3 data. This is important to note, because it means a non-trivial amount of the MP3 data remains in the mpglib queue. - acmStreamConvert() is called over and over, with a 2333 source buffer and a 9332 destination buffer. The output buffer is always too small, so the undecoded data in the mpglib buffers accumulates. - winmm sends the last encoded buffer. Supposedly this means that decoding is complete, but it isn't, because mpglib has a backlog of undecoded data which has not been played. However, winmm stops there, and the user notices the cut in the middle of the song. In the same situation, L3CODECA.ACM reports a non-integer factor for the output buffer, a little under 12X. Therefore L3CODECA.ACM always has enough space to consume the full source buffer and therefore does not cut the song in the middle. The ideal solution would be to dynamically compute the expansion factor based on the input and output bitrates. The attached patch raises the expansion factor instead to 12X to ensure that mpglib can always decode all the input data without running out of output space. Changelog: * Increase size factor from 4 to 12 in MPEG_StreamSize, otherwise mpglib buffer queue grows * Add TRACE of mpglib buffer queue for conversion. Alex Villacís Lasso

2 1

Copy / Paste with complex Objects
by Roland Kaser 14 Feb '06

14 Feb '06

Hello Sorry, this is the second post for this reason, but it's important for me to sort this problem out. Can somebody try to get a answer? I noticed a strange behavior of the copy/paste functionality of Corel Draw on diffrent SuSE 10 Systems. On one system copy/paste works fine (without any failure) on a other system there is no function at all. (itss storage error). Can somebody tell me which system libraries used for the copy/paste functions? So that I can compare the two systems to find out where the copy/paste error cames from. Many thanks Roland Kaeser

1 0

Re: WINMM: prevent division by zero in mciwave
by Eric Pouech 14 Feb '06

14 Feb '06

Alex Villacís Lasso wrote: > This was found while digging for the source of the mp3 jittering > problem. Both native L3CODECA.ACM and winemp3 trigger this > division-by-zero exception with ACMAPP.EXE demonstration program from > MSDN when using the Player! menu item with a MP3-encoded .WAV file > unless this patch is applied. > > Changelog: > > * Prevent division-by-zero exception on codecs that do not report > bits-per-sample. > > Alex Villacís Lasso > > > ------------------------------------------------------------------------ > > diff -ur wine-0.9.7-cvs/dlls/winmm/mciwave/mciwave.c wine-0.9.7-cvs-patch/dlls/winmm/mciwave/mciwave.c > --- wine-0.9.7-cvs/dlls/winmm/mciwave/mciwave.c 2005-12-06 16:28:17.000000000 -0500 > +++ wine-0.9.7-cvs-patch/dlls/winmm/mciwave/mciwave.c 2006-02-12 11:52:25.000000000 -0500 > @@ -205,7 +205,7 @@ > ret = val; > break; > case MCI_FORMAT_SAMPLES: /* FIXME: is this correct ? */ > - ret = (val * 8) / wmw->lpWaveFormat->wBitsPerSample; > + ret = (val * 8) / (wmw->lpWaveFormat->wBitsPerSample ? wmw->lpWaveFormat->wBitsPerSample : 1); > break; I think the overall fix is wrong. The computation is correct for PCM files, not for MP3 (and any other non linear compression format). You should check how native mciavi32 behaves here. A+ -- Eric Pouech

1 0

msvcrt: portable printf integer conversions
by Jesse Allen 14 Feb '06

14 Feb '06

I've been trying to get some functionality to the %I64 printf size specifier. My last patch was rejected because it was non-portible. Therefore, I've written an internal function, pf_integer_conv, to handle the conversion of integers only -- not floats. The patch tries to not impact the current printf infrastructure as much as possible, therefore it only forwards %I64 sizes. However, it could be possible to foward all integer types as I wrote it to handle them all, and this is probably the way to go. There are a couple of problems I have discovered in our printf. One is that if flags->Precision is zero, then it is unused. But according to man 3 printf, precision can be explicitly defined as zero. Therefore, we do not handle "zero" precision. The next problem is when we rebuild our format string to handle the integer and floats, and call printf from libc to handle it. It happens to print to a fixed buffer of 40 without checking. If we ever get called to print a number with a field length greater than 40 or whatever large combination, libc will happily print beyond the end of the buffer. These are problems in the current infrastructure and will need to be addressed. Any comments? I'd like to have a better idea on restructuring the printf to handle number conversions before we move forward. I still need to work on floating point too, as of yet. Jesse

1 1

Re: usp10: [RESEND] Add ScriptItemize, ScriptShape and ScriptPlace functionality
by James Hawkins 14 Feb '06

14 Feb '06

On 2/13/06, Jeff L <lats(a)yless4u.com.au> wrote: > This patch is a resend that contains the correct file that combines the > code and the tests, sent previously as two patches, into one patch. It > also has the .cvsignore for dlls/usp10/tests and fixes some issues with > comments and dead code. > You'll have more luck getting this accepted if you send each function implementation in separate patches. Some comments about the patch: if (psc) *psc = NULL; return 0; + HeapFree ( GetProcessHeap(), 0, *psc); + *psc = NULL; You should keep the if (psc), because the user can send in a NULL psc. - FIXME("%p,%p\n",ppSp,piNumScripts); + FIXME("%p,%p,%p\n",ppSp, *ppSp, piNumScripts); If this function is now implemented, it should be a TRACE and not a FIXME. If ppSp is NULL, this call to FIXME will cause a crash (see next comment.) - if (piNumScripts) *piNumScripts = 0; +/* Set up a sensible default and intialise pointers */ + *piNumScripts = MAX_SCRIPTS; + *ppSp = (SCRIPT_PROPERTIES *)Global_Script; Same as above, need to keep the if (ptr) checks. + TRACE("ppSp:%p, *ppSp:%p, **ppSp:%p, %d\n", ppSp, *ppSp, **ppSp, + *piNumScripts); If you *really* need to see all the values of these pointers, then you have to check that each pointer above it is not NULL. + FIXME("(%p,%p,%p,%s,%d,%d, %p, %d, %p, %d): stub\n", hdc, psc, pwcChars, I dont know what this function is supposed to do, but it looks like you've added quite a bit of functionality to this function. If it's not completely implemented, I would change it to semi-stub, so we know it at least does something. Same thing for the rest of the functions. A good first step is to send the tests in the first patch, adding todo_wine's where appropriate. Next send each function implementation in separate patches afterwards, removing todo_wine's from tests that now pass. -- James Hawkins

1 0

Re: user: Fix return type of GetDlgItemText{A,W}
by Troy Rollo 14 Feb '06

14 Feb '06

On Tuesday 14 February 2006 11:59, Troy Rollo wrote: > ChangeLog: > user: Fix return type of GetDlgItemText{A,W} Please disregard this one - the argument types are wrong too. I will follow up with a consolidated patch fixing both -- Troy Rollo - wine(a)troy.rollo.name

1 0

Re: StretchDIBits function problem.
by Cyril Margorin 13 Feb '06

13 Feb '06

Hello, According the patches, I've send before: I've got two small questions: 1) Shouldn't the Shared Memory XImage created in X11DRV_DIB_SetImageBits/X11DRV_DIB_GetImageBits functions? Or creating shared memory image takes too long? 2) Shouldn't XImage be passed to X11DRV_DIB_SetImageBits, and useShm field correctly in X11DRV_SetDIBits? Why it was NULL in X11DRV_GetDIBits and is NULL in X11DRV_SetDIBits, with useShm hardcoded to FALSE? -- Cyril Margorin

1 0

Re: When possible, use tgkill instead of tkill syscall on Linux.
by Robert Shearman 13 Feb '06

13 Feb '06

Eric Pouech wrote: >diff --git a/server/context_x86_64.c b/server/context_x86_64.c >index c102510..e5d8fc2 100644 >--- a/server/context_x86_64.c >+++ b/server/context_x86_64.c >@@ -271,12 +271,12 @@ int get_thread_single_step( struct threa > } > > /* send a signal to a specific thread */ >-int tkill( int pid, int sig ) >+int tkill( int tgid, int pid, int sig ) > { > #ifdef __linux__ > int ret; > __asm__( "syscall" : "=a" (ret) >- : "0" (200) /*SYS_tkill*/, "D" (pid), "S" (sig) ); >+ : "0" (200) /*SYS_tkill*/, "D" (tid), "S" (sig) ); > > Shouldn't this line change "pid" to "tgid" instead of "tid"? -- Rob Shearman

1 0

[winecfg] Localize app specific title
by Paul Vriens 13 Feb '06

13 Feb '06

Hi, the title shown in winecfg is always in English when configuring stuff for an specific application. Any remarks on the patch? Would this work for every language? (I mean will the name of the app always be after the IDS_WINECFG_TITLE_APP) Cheers, Paul. diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc index 22bdeb0..6d5594d 100644 --- a/programs/winecfg/En.rc +++ b/programs/winecfg/En.rc @@ -199,6 +199,7 @@ BEGIN IDS_TAB_AUDIO "Audio" IDS_TAB_ABOUT "About" IDS_WINECFG_TITLE "Wine configuration" + IDS_WINECFG_TITLE_APP "Wine configuration for" IDS_THEMEFILE "Theme files" IDS_THEMEFILE_SELECT "Select a theme file" IDS_AUDIO_MISSING "There is no audio driver currently specified in the registry.\n\nA recommended driver has been selected for you.\nYou can use this driver or select another driver if available.\n\nYou must click Apply for the selection to take effect." diff --git a/programs/winecfg/resource.h b/programs/winecfg/resource.h index 4fac41f..85bf11c 100644 --- a/programs/winecfg/resource.h +++ b/programs/winecfg/resource.h @@ -39,6 +39,7 @@ #define IDS_WINECFG_TITLE 13 #define IDS_THEMEFILE 14 #define IDS_THEMEFILE_SELECT 15 +#define IDS_WINECFG_TITLE_APP 16 /* App specific title */ #define IDD_MAINDLG 101 #define IDB_WINE 104 #define IDD_ABOUTCFG 107 diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c index df2b05f..f87ccf0 100644 --- a/programs/winecfg/winecfg.c +++ b/programs/winecfg/winecfg.c @@ -53,23 +53,22 @@ HMENU hPopupMenus = 0; */ void set_window_title(HWND dialog) { - char *newtitle; + char newtitle[1024]; /* update the window title */ if (current_app) { - const char *template = "Wine Configuration for %s"; - newtitle = HeapAlloc(GetProcessHeap(), 0, strlen(template) + strlen(current_app) + 1); - sprintf(newtitle, template, current_app); + char prefix[1024]; + LoadString(GetModuleHandle(NULL), IDS_WINECFG_TITLE_APP, prefix, 1024); + sprintf(newtitle, "%s %s", prefix, current_app); } else { - newtitle = strdupA("Wine Configuration"); + LoadString(GetModuleHandle(NULL), IDS_WINECFG_TITLE, newtitle, 1024); } WINE_TRACE("setting title to %s\n", newtitle); SendMessage(GetParent(dialog), PSM_SETTITLE, 0, (LPARAM) newtitle); - HeapFree(GetProcessHeap(), 0, newtitle); }

2 1

todo_wine help
by Phil Lodwick 13 Feb '06

13 Feb '06

I have a test in msvcrt/file.c that requires there be no TMP environment variable. I thought I would just do a _putenv("TMP="), but this seems to interfere with todo_wine. Basically, static void test_todo( void ) { todo_wine { ok((1 == 1), "This shows up correctly\n"); } _putenv("TMP="); todo_wine { ok((1 == 1), "This does not show\n"); } } My quick search has not turned up anything obvious. Can somebody help me understand what is going on here? Assuming TMP is actually required by somebody else, how do I correctly do my test and check with no TMP environment variable? Thanks, Phil

1 0

Re: Startup time of OOo2, Firefox 1.5. Some surprises.
by Dan Kegel 13 Feb '06

13 Feb '06

On 2/13/06, Dan Kegel <dank(a)kegel.com> wrote: > It's 4 or 6 seconds for me, too, if I run with 96 MB ram. gaah, I meant "it's fast for me too if I use 400MB of ram". -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: [TWAIN] Reconcile sane's long names to TWAIN's 32 byte limit
by Robert Shearman 13 Feb '06

13 Feb '06

Jeremy White wrote: >libsane can return arbitrarily long names, but TWAIN supports only a maximum of 32. >Further, the name is a unique identifier, and so must be returned to libsane for processing. > >This algorithm tries to convert a long libsane name into a more reasonable short name, >but adds a crude signature process in an attempt to ensure a unique short identifier. > > > >------------------------------------------------------------------------ > > > dlls/twain/dsm_ctrl.c | 85 ++++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 73 insertions(+), 12 deletions(-) > >eabadf1c3584adda1a36b199f82bc6bbb17b71da >diff --git a/dlls/twain/dsm_ctrl.c b/dlls/twain/dsm_ctrl.c >index f744939..6d1318d 100644 >--- a/dlls/twain/dsm_ctrl.c >+++ b/dlls/twain/dsm_ctrl.c >@@ -22,6 +22,7 @@ > > #include <stdlib.h> > #include <stdarg.h> >+#include <stdio.h> > > #define NONAMELESSUNION > #define NONAMELESSSTRUCT >@@ -33,6 +34,14 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(twain); > >+inline static LPSTR TWAIN_strdup( LPCSTR str ) >+{ >+ LPSTR ret = HeapAlloc( GetProcessHeap(), 0, strlen(str) + 1 ); >+ if (ret) strcpy( ret, str ); >+ return ret; >+} >+ >+ > /* DG_CONTROL/DAT_IDENTITY/MSG_CLOSEDS */ > TW_UINT16 TWAIN_CloseDS (pTW_IDENTITY pOrigin, TW_MEMREF pData) > { >@@ -83,6 +92,38 @@ TW_UINT16 TWAIN_CloseDS (pTW_IDENTITY pO > #endif > } > >+/* Sane returns device names that are longer than the 32 bytes allowed >+ by TWAIN. However, it colon separates them, and the last bit is >+ the most interesting. So we use the last bit, and add a signature >+ to ensure uniqueness */ >+static char * get_sane_short_name(const char *in) >+{ >+ char *p; >+ LPSTR ret; >+ int signature = 0; >+ >+ if (strlen(in) <= 32) >+ return TWAIN_strdup((char *) in); >+ >+ for (p = (char *) in; *p; p++) >+ signature += *p; > > These casts from const char * to char * shouldn't be necessary. -- Rob Shearman

1 1

Direct3D Z order question
by Stefan Dösinger 13 Feb '06

13 Feb '06

Hello, I have written a small Direct3D7 test application which draws two overlapping triangles, a red one and a blue one. The red triangle has the z value 0.0 (closest to the viewer), the blue one 1.0(far away). Strangely, the blue triangle overlaps the red one on Windows. The same happens on the current ddraw implementation, but in WineD3D the red triangle overlaps the blue one, which is mathematically correct. I've studied the ddraw and wined3d drawing code over and over, but I couldn't find any difference. It seems that on Windows, the triangle that is drawn last overlaps the other one in the output, and the z value seems to be ignored completely. Can someone explain me what's going on here???? The reason for this is the Direct3D mode of Half-Life 1. I've got it working with WineD3D after a long struggle with IDirect3DVertexBuffer::ProcessVertices, except of the HUD, which is hidden. If I force the z value in the [0.0, 1.0] range, it is shown, but the rest is broken obviously. How to run my test program: I've attached a source file and a Makefile which builds a .exe with mingw, and a precompiled exe file. When you run it, it shows a black screen, and if you click anywhere, it draws the triangles. I've some bug in the flipping code, so you have to click two times actually. Pressing esc exits. Thanks, Stefan PS: If anyone needs the d3d7->wined3d code to look at, I can send patches. But it's quite messy now ;)

3 10

Re: GDI: Don't crash when copying to an EMF from a NULL bitmap.
by Alexandre Julliard 13 Feb '06

13 Feb '06

Mike McCormack <mike(a)codeweavers.com> writes: > @@ -84,9 +84,14 @@ static BOOL EMFDRV_BitBlockTransfer( > BITMAP BM; > WORD nBPP; > LPBITMAPINFOHEADER lpBmiH; > - EMFDRV_PDEVICE* physDevSrc = (EMFDRV_PDEVICE*)devSrc; > - HBITMAP hBitmap = GetCurrentObject(physDevSrc->hdc, OBJ_BITMAP); > + EMFDRV_PDEVICE* physDevSrc; > + HBITMAP hBitmap; > > + physDevSrc = (EMFDRV_PDEVICE*)devSrc; > + if (!devSrc) > + return TRUE; You still need to generate the EMF record, you can't just ignore it and return TRUE. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: usp10: [RESEND] Add ScriptItemize, ScriptShape and ScriptPlace functionality
by Robert Shearman 13 Feb '06

13 Feb '06

lats wrote: >Index: dlls/usp10/usp10.c >=================================================================== >RCS file: /home/wine/wine/dlls/usp10/usp10.c,v >retrieving revision 1.7 >diff -u -r1.7 usp10.c >--- dlls/usp10/usp10.c 9 Jan 2006 19:55:03 -0000 1.7 >+++ dlls/usp10/usp10.c 12 Feb 2006 05:25:09 -0000 >@@ -39,6 +39,42 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(uniscribe); > >+#define MAX_SCRIPTS 8 >+ >+/* Set up a default for ScriptGetProperties */ >+const SCRIPT_PROPERTIES Default_Script_0 = {0, 0, 0, 0, 0, 0, 0, 0, >+ 0, 0, 0, 0, 0, 0, 0}; > > This can be "static const" instead of just "const". >@@ -69,9 +108,13 @@ > */ > HRESULT WINAPI ScriptGetProperties(const SCRIPT_PROPERTIES ***ppSp, int *piNumScripts) > { >- FIXME("%p,%p\n",ppSp,piNumScripts); >+ FIXME("%p,%p,%p\n",ppSp, *ppSp, piNumScripts); > >- if (piNumScripts) *piNumScripts = 0; >+/* Set up a sensible default and intialise pointers */ >+ *piNumScripts = MAX_SCRIPTS; >+ *ppSp = (SCRIPT_PROPERTIES *)Global_Script; >+ TRACE("ppSp:%p, *ppSp:%p, **ppSp:%p, %d\n", ppSp, *ppSp, **ppSp, >+ *piNumScripts); > return 0; > } > > > The identation of the comment is unusual. >@@ -129,7 +172,60 @@ > if (!pwcInChars || !cInChars || !pItems || cMaxItems < 2) > return E_INVALIDARG; > >- *pcItems = 0; >+/* Set a sensible default */ >+/* Set SCRIPT_ITEM */ >+ pItems[0].iCharPos = 0; >+/* Set the SCRIPT_ANALYSIS */ >+// pItems[0].a.eScript = SCRIPT_UNDEFINED; >+ pItems[0].a.eScript = 2; > > Which is it, SCRIPT_UNDEFINED or 2? Decide this and remove the dead code. -- Rob Shearman

2 1

Czech language resources encoding fix
by Petr Tesarik 13 Feb '06

13 Feb '06

Hi everyone, On 8 Feb I sent a patch to fix the encoding of Czech resources in Wine (see wine-patches), but nothing seems to have happened. Is something wrong with the patch? Of course, I double-checked the "Sending patches" page: # Include a ChangeLog entry with your name, email address and a description of what your patch does. There is a ChangeLog entry and a (IMO concise) description of what the patch does. # Keep the patch small and the point of the change clear. # Submit one fix or group of related changes per patch. Well, OK, I could possibly break the patch into numerous smaller ones, each fixing only one of the resource files. Is that what you expect? # Generate your patch against the latest version of Wine from the WineHQ CVS (see below). It applies cleanly against latest CVS. # Test your patch, and if possible write a test case demonstrating it is correct. Umgh. Does changing a resource string need writing a test case? # Be careful to not corrupt the patch through line-wrapping. Not the case. # Avoid unnecessarily changing the formatting of the code. No. # Use standard C, avoid C++ comments and inline variable declarations. They'r resource files. No C/C++ comments at all. # Read the diff and make sure it contains only what you want in it. Done. Thanks for any clue, Petr Tesarik

2 2

Wine console windows vs. [x]terminal
by Segin 13 Feb '06

13 Feb '06

Hi, I notice that Wine opens a Windows-like console window for console apps if they are started using the 'winedbg' loader. Is it possible to get all console apps to run like this without using winedbg? There is a Windows console program using pdcurses that I am trying to check for compatability, and having to startup winedbg to get the program to function is a bit much. It should also be noted that I do not read the wine-users mailing list at this time, but I do read wine-devel.

3 2

bugzilla account
by Michael Jung 12 Feb '06

12 Feb '06

Hi, I would like to change the status of bug 4322 to FIXED, but I'm not 'empowered' to do it. Whom do I have to talk to? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

3 2

Representation of virtual hardware in desktop managers [Was Bug 4551]
by Tom Spear (Dustin Booker, Dustin Navea) 12 Feb '06

12 Feb '06

Forwarded from Bugzilla bug 4551. Nowadays on Linux you do not see your virtual wine hardware drives in KDE or GNOME because they are not recognized. You have to open "invisible" folder "$HOME/.wine". Many users will not be able to do this. Maybe one could work out some standard with freedesktop.org so that users can easily access their virtual drive C:\ ? Who's work would that be? I am not sure about that, so sorry if this is not the right "inbox". I would liek to suggest to extend this standard to other virtual machines like Xen or Vmware. Thilo Pfennig

1 0

Re: Small CVS-Update-Script
by Christian Lachner 12 Feb '06

12 Feb '06

I know that there is something like my script out there but i did (again) spend some time on rewriting my own one since i like it better ;). This one is compeltely different from my first one - it works the same, but does some checks before doing anything , the code is written nicer and cleaner and the output is also very nice now :D. Have fun with this piece of code! On 10/2/05, Andreas Schneider <andreas.schneider(a)linux-gamers.net> wrote: > Hi gladiac, > > take a look at > > http://winecvs.linux-gamers.net/ > > Cheers, > > -- andreas > > Gladiac Spark wrote: > > This is nothing special but may be useful for some people out there > > having problems updating their cvs-trees or being lazy writing some > > commands in their console. Copy the 'getwinecvs' to /usr/src or wherever > > you want (don't forget to edit the SRC=Variable if you're doing so) and > > chmod it to give you x-rights. (e.g.: 'chmod 750 getwinecvs' without quotes) > > > > By running it, it will search for an existing wine-tree... if there is > > one, it will be cleaned and then updated; if not, the complete tree will > > be downloaded. > > When using -c as parameter for getwinecvs, it will automatically begin > > to compile after getting all the updates and then install. > > To see what it exactly does, have a look at the source. > > > > Even if it is called General CVS-Updater by gladiac it has been written > > FOR wine. I hope it is helpful for others. I know it's not very nerdy > > but.... who cares ;). > > > > > > ------------------------------------------------------------------------ > > > > > > -- > http://www.linux-gamers.net - your online gaming resource > >

3 9

Re: WINED3D: Fix a couple of FIXMEs
by Alexandre Julliard 12 Feb '06

12 Feb '06

"H. Verbeet" <hverbeet(a)gmail.com> writes: > The output of glGetString(GL_PROGRAM_ERROR_STRING_ARB) can get too > large for a normal FIXME. Use fprintf to stderr instead. You should use debugstr_a. fprintf will mess up the output. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Localize ShellFolder display names [1/3] advapi32: Implemented RegLoadMUIString[AW]
by Dmitry Timoshkov 11 Feb '06

11 Feb '06

On Sat, 2006-02-11 at 18:06 +0100, Michael Jung wrote: > ChangeLog: > Implemented RegLoadMUIString[AW] > -IMPORTS = kernel32 ntdll > +IMPORTS = user32 kernel32 ntdll I'd suggest to add user32 as a delayload import to not create circular dependency at load time. -- Dmitry.

1 0

[usp10] Add ScriptItemize, ScriptShape and ScriptPlace functionality
by Jeff L 11 Feb '06

11 Feb '06

Is there anything wrong with this patch? It does not seem to have been applied. Jeff L

4 3

Font Rendering
by Roland Kaser 11 Feb '06

11 Feb '06

Hello I noticed a strange behavior of the Font/Vector objects functionality of Corel Draw on diffrent SuSE 10 Systems. On one system Rotated Text works fine (without any failure) on a other system, rotated fonts became invisible on the screen. At pdf export, the fonts are normally visible. So it seems to be a graphics subsystem error. No winedebug output at all. Can somebody tell me which system libraries used for the font rendering functions? So that I can compare the two systems to find out where the font-rendering error cames from. Many thanks Roland Kaeser

1 0

Copy/Paste
by Roland Kaser 11 Feb '06

11 Feb '06

Hello I noticed a strange behavior of the copy/paste functionality of Corel Draw on diffrent SuSE 10 Systems. On one system copy/paste works fine (without any failure) on a other system there is no function at all. (itss storage error). Can somebody tell me which system libraries used for the copy/paste functions? So that I can compare the two systems to find out where the copy/paste error cames from. Many thanks Roland Kaeser

1 0

Re: localtime should accept any positive time value
by Rein Klazes 11 Feb '06

11 Feb '06

On Fri, 10 Feb 2006 22:10:29 -0600, you wrote: >- ULONGLONG time = *secs * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; >+ /* time < 0 means a date before midnight of January 1, 1970 */ >+ if (*secs < 0) return NULL; I think the comment is incorrect: it should be *secs < 0; >- if (st.wYear < 1970) return NULL; >+ if (st.wYear < 1970) >+ { >+ /* if this happens it means that the sequence above does something wrong */ >+ FIXME("seconds since 1970 %ld => %d/%d/%d %02d:%02d:%02d\n", *secs, >+ st.wDay, st.wMonth, st.wYear, st.wHour, st.wMinute, st.wSecond); >+ } If *secs < 3600, in time zones on the western hemisphere it is still 1969. Rein.

1 0

STROKEPATH and STROKEANDFILLPATH emf problem
by Terry_Higgins＠cimmetry.com 11 Feb '06

11 Feb '06

Since upgrading to Wine-20040914, we've noticed that a bug has been introduced in gdi32.dll that causes certain pen strokes to be drawn with thickness that is far too wide. The problem is in wine's handling of the STROKEPATH and the STROKEANDFILLPATH emf records when playing enhanced metafiles. Specifically, there seems to be a problem with an interaction between wine's temporary setting of a world transform and a pen selection that happens during processing of the record. In cvs on the Wine HQ site, we notice that a SelectObject() for the pen was inserted in function DC_UpdateXforms() in dlls/gdi/dc.c in revision 1.2 as follows: =================================================================== RCS file: /home/wine/wine/dlls/gdi/dc.c,v retrieving revision 1.1 retrieving revision 1.2 diff -u -p -r1.1 -r1.2 --- wine/dlls/gdi/dc.c 2004/07/21 04:07:28 1.1 +++ wine/dlls/gdi/dc.c 2004/09/13 18:03:44 1.2 @@ -262,10 +262,13 @@ void DC_UpdateXforms( DC *dc ) dc->vport2WorldValid = DC_InvertXform( &dc->xformWorld2Vport, &dc->xformVport2World ); - /* Reselect the font back into the dc so that the font size + /* Reselect the font and pen back into the dc so that the size gets updated. */ if(memcmp(&oldworld2vport, &dc->xformWorld2Vport, sizeof(oldworld2vport))) + { SelectObject(dc->hSelf, GetCurrentObject(dc->hSelf, OBJ_FONT)); + SelectObject(dc->hSelf, GetCurrentObject(dc->hSelf, OBJ_PEN)); + } } The pen is set after the call that modifies the world transform to the identity and before it is reset back to its normal values. If we remove the call to SelectObject that selects the pen (shown in the code above), the bug disappears. Advice on the best way to proceed would be greatly appreciated. 1) Why was this change made? 2) Is the best fix simply to undo this change or is there a better solution (e.g. fix the strokepath implementation)?

2 3

Re: wine on Intel Xeon processor
by Tom Spear (Dustin Booker, Dustin Navea) 11 Feb '06

11 Feb '06

Hi, sorry I didnt reply all so it would go to the wine list. Is your Xeon a dual core, or possibly even 64-bit? I doubt that 64-bit compared to 32-bit would make a difference, but if the Xeon is a dc, it might, as I recall another thread here saying that they were having problems with a dual core system being slower. The only other thing I can think of (of course I'm not that far along with my programming skill, and I doubt it will make much difference anyway) is what kind of machine the application and the dll were compiled on. If you have the source for either of those, and have access to a xeon that is running windows (2003 server?) and can compile, i'd suggest trying that, otherwise, I have no clue. HTH Tom Ananth M wrote: > > > On 2/10/06, *Ananth M* <mekaananth(a)gmail.com > <mailto:mekaananth@gmail.com>> wrote: > > The wine source code was compiled in the Xeon processor > > We had'nt recompiled the kernel with Xeon Processor , we are using > the same that is coming with RHEL 4.0 > > > > Now I compiled the kernel again and used the new kernel Image. > Still I am getting the same timings > > > > On 2/9/06, *Tom Spear (Dustin Booker, Dustin Navea)* < > speeddymon(a)gmail.com <mailto:speeddymon@gmail.com>> wrote: > > Are the wine binaries on the Xeon server precompiled (even > copied from > the P4 machine), or are they compiled on the Xeon server itself? > > Also, has the kernel been recompiled with explicit support for > the Xeon, > or is it the stock kernel that comes with RHEL 4? > > Tom > > Ananth M wrote: > > Hi All > > > > I have a windows application that calls a > function ( > > approximately 10000 times) exported by a third party DLL. > > I have two machines ( one with Intel pentium 4 > > processor and > > other with Intel Xeon processor ) with RHEL 4.0 installed > on both > > of these > > machine. > > If I execute the windows application on the first > > machine (one > > with Intel pentium 4 processor ) using WINE, the execution > time is > > almost > > equal to the execution time in windows machine. > > But, if I execute the same application on the > second > > machine > > (Intel Xeon processor ), the execution time is almost 6 > times to > > the first > > machine. > > I am using WINE-0.9.2 and wine is installed by > > downloading the > > wine source code from winehq.org <http://winehq.org/> < > http://winehq.org/> > > Is it a known issue (or ) > > Do I need to do any additional configuration > setting to > > work with > > Intel Xeon processor ? > > > > Regards > > Ajay > > ------------------------------------------------------------------------ > > > > > > > > >

4 3

"Windows Everywhere" foresaw Wine back in 1993?
by Dan Kegel 11 Feb '06

11 Feb '06

Back in 1993, OS/2 advocate Richard E. Hodges disagreed enough with a June 1993 Byte magazine article by John Udell "Windows, Windows Everywhere?" that he wrote a lengthy reply, and posted it widely; it was forwarded to comp.os.os2.misc, and said in part --- snip --- To lure Independent Software Vendors, "Windows Everywhere" offers a kind of "magic dust" that will end their cross-platform support problems. Microsoft claims that Windows programs will run on any computer with nothing but a simple recompile. Windows programs will run under Unix through an emulator. "Wings" will let you recompile into a native Macintosh application. --- snip --- Did Microsoft really talk up the idea of Unix being able to run Win32 apps via emulation on Unix, or was Hodges referring to things like Sun's WABI, which was announced in May '93? - Dan p.s. the original message can be seen in two parts, May 31st or June 2 1993 (usenet was slow back then!), "A Letter to Byte Magazine", http://groups.google.com/group/comp.os.os2.misc/msg/6180333e77f4a147 http://groups.google.com/group/comp.os.os2.misc/msg/e31a54eb9a3e1389 And the WABI announcement seems to be at http://groups.google.com/group/comp.unix.questions/msg/b4a8e8fc829b2ab7 -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 4

StretchDIBits function problem.
by Cyril Margorin 10 Feb '06

10 Feb '06

Hello, I've discovered, that using of GetDIBits after StretchDIBits doesn't return correct data. More then - all pixels that it returns are black. In attachment the test function. Changelog: Cyril Margorin <comargo(a)gmail.com> add test of StretchDIBits()/GetDIBits() bunch to gdi/test/bitmap.c -- Cyril Margorin

4 4

Fact check for wine talk
by Dan Kegel 10 Feb '06

10 Feb '06

Hi all, I'm giving a talk about Wine tomorrow. The slides are up at http://kegel.com/wine/scale4/ If you find any errors in the side, please let me know! Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 6

Re: localtime should accept any positive time value
by Marcelo Duarte 10 Feb '06

10 Feb '06

Dmitry Timoshkov escreveu: > Hello, > Hello, > --- cvs/hq/wine/dlls/msvcrt/time.c 2006-01-23 20:50:58.000000000 -0600 > +++ wine/dlls/msvcrt/time.c 2006-02-10 12:51:30.000000000 -0600 > @@ -152,8 +152,12 @@ struct MSVCRT_tm* MSVCRT_localtime(const > SYSTEMTIME st; > DWORD tzid; > TIME_ZONE_INFORMATION tzinfo; > + ULONGLONG time; > > - ULONGLONG time = *secs * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; > + /* time < 0 means a date before midnight of January 1, 1970 */ > + if (time < 0) return NULL; > + > + time = *secs * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; > You compared the "time" before it has a assigned value... > > ft.dwHighDateTime = (UINT)(time >> 32); > ft.dwLowDateTime = (UINT)time; > @@ -161,7 +165,12 @@ struct MSVCRT_tm* MSVCRT_localtime(const > FileTimeToLocalFileTime(&ft, &lft); > FileTimeToSystemTime(&lft, &st); > > - if (st.wYear < 1970) return NULL; > + if (st.wYear < 1970) > + { > + /* if this happens it means that the sequence above does something wrong */ > + FIXME("seconds since 1970 %ld => %d/%d/%d %02d:%02d:%02d\n", *secs, > + st.wDay, st.wMonth, st.wYear, st.wHour, st.wMinute, st.wSecond); > + } > > data->time_buffer.tm_sec = st.wSecond; > data->time_buffer.tm_min = st.wMinute; > > ------------------------------------------------------------------------ > > >

1 0

Changes to Wine Status Pages
by Tom Wickline 10 Feb '06

10 Feb '06

Hello, I plan to remove ttydrv from our dlls status page as it has been removed. And also remove Wine Installer (wineinstall) as it has been replaced by wineprefixcreate. Are there any comments on this before I remove these two components. Tom

2 1

Re: sfc: Add minimal sfc.dll
by Robert Shearman 10 Feb '06

10 Feb '06

Detlef Riekenberg wrote: >+/***************************************************** >+ * DllMain >+ */ >+BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) >+{ >+ TRACE("(%p, %ld, %p)\n",hinstDLL, fdwReason, lpvReserved); >+ /* For the moment, do nothing here. */ >+ return TRUE; >+} > > You should call DisableThreadLibraryCalls here for performance reasons. -- Rob Shearman

1 0

Re: USER32: Hide cursor when calling SetCursor with NULL HCURSOR
by Andreas Mohr 10 Feb '06

10 Feb '06

Hi, On Fri, Feb 03, 2006 at 07:50:51PM -0500, Justin Chevrier wrote: > Changelog: > Hide cursor if SetCursor is called with a NULL HCURSOR Which obviously implies the question: What if the program does a SetCursor(something) later? Should it then re-show a cursor previously hidden by a NULL handle? And if so, does Wine handle that re-showing properly? I'd better have a program with duplicate cursor than one without any cursor any more at all ;) Andreas

2 1

Re: Wine with multiple threads on Dual processor - any suggestions please
by Juan Lang 10 Feb '06

10 Feb '06

Hi Ananth, > Is there any isses with wine on Dual processor machines ( Intel > Xeon processor ) w.r.t multi threaded programming? There can be, if there is a lot of inter-thread synchronization. Only if each thread is CPU-bound are you likely to see any improvement in performance as you move to multiple threads. If there is a lot of inter-thread synchronization, you'll be slowed down by calls into wineserver, and short of some hack this isn't going to change anytime soon. Regarding your other email, how do you know it's wine that's causing the difference in speed between the two machines? The machines are different. Different machines perform differently on different applications. Anyway, to investigate both of these problems, consider using oprofile. It was covered in wwn here: http://www.winehq.com/?issue=249#oprofile%20&%20Wine --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

MSACM: winemp3 codec crashes on seek, reimplement with libmad?
by Alex Villacís Lasso 09 Feb '06

09 Feb '06

I was trying to exercise the winemp3 builtin codec using a Visual Basic control that essentially implements the Windows Media Player look (MSDXM.OCX). After specifying native quartz.dll for this app, I tested a few AVIs with mp3-encoded soundtracks. What I can notice is that the sound has very annoying jitters, and in addition, it crashes on a seek. Some people have noticed the jitters too (http://bugs.winehq.org/show_bug.cgi?id=3853). However, rather than trying to fix the wine fork of mpeglib, I was toying with the idea of reimplementing the codec as a libmad (GPL) wrapper. Are there any issues I should take into account before trying this? Alex Villacís Lasso

2 7

error: length() does not define an explicit binding handle!
by Uwe Bonnes 09 Feb '06

09 Feb '06

Hello, a recent CVS checkout gives ../tools/widl/widl -I. -I. -I../include -I../include -h \ -H mshtml.h mshtml.idl error: length() does not define an explicit binding handle! make[1]: *** [mshtml.h] Fehler 2 Any hints? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Regression problems in app - help with debugging?
by Dr J A Gow 09 Feb '06

09 Feb '06

Hello All, I have some regression problems relating to Wine in a commercial ECAD app 'Easy-PC' version 9.0, available from http://www.numberone.com The application was quite usable on Crossover Office 4.2, with just some minor dialog corruption. Alpha versions of Wine available at the same time (can not exactly remember which ones) could also run it successfully. However, under the latest Wine 0.9.6, Wine CVS and CXO 5.0.1 it does not work. Note that it does not crash, it errors out cleanly with a dialog box message. I have been debugging the problems in this app for some time now. It is a critical app for me as I use it in a production environment, but I do not want to pay Microsoft for the privilege of exposing my machine to malware. I am thus prepared to help debug Wine to get this application running. However, my Windows programming experience is limited to device drivers, not apps (although fluent C/C++ systems programming on other platforms), I have hit a brick wall, possibly due to my limited knowledge of how the Windows API works and I will need some help with this. If anyone would like to help me debug this app (hope springs eternal!), a demo version of the app is available free of charge from the web site address above, and this version exhibits the same problems as the full version. Background ------------- The system: Dual physical processor (not dual core) Opteron running SuSE 10.0 x86_64 SMP. Wine: Latest 0.9.6 release, up to CVS grabbed a week or so ago. The application installs OK and when run, puts up a GUI as expected. However, when you try to create a new PCB or schematic, an error dialog box is displayed indicating that the app can not read the technology file Default.stf (schematic) or Default.ptf (pcb). This is _not_ a permissions problem, all files are actually present and the same install will work under CXO 4.2. I generated and analyzed several hundred MB of logfiles over many days, added extra debug statements to the Wine code and analyzed the application's operation. The problem actually appears to have two causes, and this is what I have come up with so far. Problem 1 ----------- Application calls StgOpenStorage with a grfMode flag of 0x10020 (STGM_TRANSACTED | STGM_SHARE_DENY_WRITE). Immediately afterwards it calls StorageBaseImpl_OpenStream with a grfMode of 0x12 (STGM_SHARE_EXCLUSIVE | STGM_READWRITE). This second call fails with an access denied error code, after which the logs show an easily traced error handling sequence leading to display of the error dialog mentioned above: 0009:Call ole32.StgOpenStorage(59693db0 L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.ptf",00000000,00010020,00000000,00000000,5821f850) ret=1022e7f0 ... ... trace:storage:StgOpenStorage <-- 00000000, IStorage 0x5b3465f8 0009:Ret ole32.StgOpenStorage() retval=00000000 ret=1022e7f0 ... ... trace:storage:StorageBaseImpl_OpenStream (0x5b3465f8, L"\0005FileType", (nil), 12, 0, 0x5821f848) fixme:storage:StorageBaseImpl_OpenStream STORAGE ACCESS DENIED - parent 0, this 2 Note that the last fixme is one I added to find out exactly what was going on here. Now, logic would dictate that the grfMode of the OpenStream method call is indeed incompatible with that of its parent storage object. However, I would have thought that the application coders would most likely have hard-coded the grfMode flags in the application. If so, it would seem that the app is buggy, yet this application works on Windows! Either the app is buggy and the Win32 OLE32 implementation behaves differently, or I am missing something here. Ok, so with no obvious solution to this problem, I decided to bypass it. I modified the storage32.c implementation in the following way to bypass the grfMode check: parent_grfMode = STGM_ACCESS_MODE( This->ancestorStorage->base.openFlags ); *if* ( STGM_ACCESS_MODE( grfMode ) > STGM_ACCESS_MODE( parent_grfMode ) ) { FIXME("StorageBase_OpenStream called with grfMode mismatch - parent %d, this %d\n", parent_grfMode,STGM_ACCESS_MODE(grfMode)); ///res = STG_E_ACCESSDENIED;/ ///goto end;/ } Obviously not a viable fix, but a hack to get it working. After implementing this, the OpenStream call succeeded, as did subsequent stream access. However, the app _still_ errored out in exactly the same manner and at the same time. After more log searching, this led to the discovery of the second problem. Problem 2 ----------- During its loading and setup, the application repeatedly calls StgOpenStorage on the .stf/.ptf files in question, calls OpenStream, reads from the stream, and then finally closes the storage. I placed tell-tales in useful locations in the file open/close handlers in the wineserver, and could clearly see the files being opened and subsequently closed. This open/read/close occurs correctly and in sequence up to a certain point. At this point in the execution, the app calls StgOpenStorage on the technology file, with the following call. It is opened correctly, with grfMode of STGM_TRANSACTED | STGM_SHARED_DENY_WRITE | STGM_READWRITE: 0009:Call ole32.StgOpenStorage(5821f754 L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.ptf",00000000,00010022,00000000,00000000,5821f7f4) ret=7c17eabc trace:storage:StgOpenStorage (L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.ptf", (nil), 10022, (nil), 0, 0x5821f7f4) ... ... ... trace:storage:StorageBaseImpl_AddRef (0x5b3465f8) AddRef to 1 trace:storage:StgOpenStorage <-- 00000000, IStorage 0x5b3465f8 0009:Ret ole32.StgOpenStorage() retval=00000000 ret=7c17eabc Almost immediately, the app opens three streams in this object and starts to access them, all successfully. There follows a whole slew of logging statements, all of which appear sensible However, what is strange about this access is that soon we seem to be frantically increasing the storage object's reference pointer. This sequence appears frequently in the code, closely spaced but interspersed with what seems quite logical and successful calls to seek functions and memory allocation functions: 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000030) ret=584e498b 0009:Ret ntdll.RtlAllocateHeap() retval=55926480 ret=584e498b trace:storage:StorageBaseImpl_AddRef (0x5b3465f8) AddRef to 9 trace:storage:StorageImpl_ReadProperty storage name: L"\0005SummaryInformation" 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000008) ret=584e7ab3 0009:Ret ntdll.RtlAllocateHeap() retval=5594d108 ret=584e7ab3 The storage object's reference pointer is so incremented up to 19: 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000030) ret=584e498b 0009:Ret ntdll.RtlAllocateHeap() retval=559250f8 ret=584e498b trace:storage:StorageBaseImpl_AddRef (0x5b3465f8) AddRef to 19 trace:storage:StorageImpl_ReadProperty storage name: L"\0005SummaryInformation" 0009:Call ntdll.RtlAllocateHeap(55890000,00000000,00000008) ret=584e7ab3 0009:Ret ntdll.RtlAllocateHeap() retval=55925130 ret=584e7ab3 Finally, the code executes a trace:storage:StgStreamImpl_Destroy (0x5b34b7e0) trace:storage:StorageBaseImpl_Release (0x5b3465f8) ReleaseRef to 18 There follows a lot more log file, mostly concerned with set up and so on. What I am highligting here is that between this point, and the point of actual failure which I am going to describe shortly, there appears to be no attempt to close the Default.ptf file, unlike the attempts further up the logs closer to program start. I am wondering about this: is the reference counter being incorrectly incremented here, preventing the 'Release' function from destroying the storage object and thus closing the file? I am not sufficiently familiar with the COM storage object stuff in Windows to know what _should_ happen here. Anyway. I will now describe the point of failure. Further down the log, there are several more successful opens/closes of the technology file, with the correct mode flags. Then, finally, the app tries to re-open the technology file with a grfMode of STGM_TRANSACTED | STGM_SHARE_DENY_WRITE. This call fails with a sharing violation (remember it had been left open from the previous call) 0009:Call ole32.StgOpenStorage(5971bec8 L"c:\\Program Files\\Number One Systems\\Easy-PC\\Technology\\Default.stf",00000000,00010020,00000000,00000000,5821e69c) ret=1022e7f0 .... .... 0009:Ret kernel32.CreateFileW() retval=ffffffff ret=584edc8b trace:storage:StgOpenStorage <-- 80030020, IStorage (nil) There then follows the same error handling sequence leading to display of the dialog. I then thought about a simple test. I overrode the sharing mode detection in fd.c/check_sharing() in the wineserver (again, not a real solution). Note there are some minor differences in the code - I used a return code so I could easily check it: /// if ((access & FILE_UNIX_READ_ACCESS) && !(existing_sharing & FILE_SHARE_READ))/ /// rc=0;/ /// if ((access & FILE_UNIX_WRITE_ACCESS) && !(existing_sharing & FILE_SHARE_WRITE))/ /// rc=0;/ /// if ((existing_access & FILE_UNIX_READ_ACCESS) && !(sharing & FILE_SHARE_READ)) rc=0;/ /// if ((existing_access & FILE_UNIX_WRITE_ACCESS) && !(sharing & FILE_SHARE_WRITE)) rc=0;/ *if* (fd->closed->unlink[0] && !(existing_sharing & FILE_SHARE_DELETE)) rc=0; *if* (unlink && !(sharing & FILE_SHARE_DELETE)) rc=0; *if*(rc==0) { fprintf(stderr,"FILEDESC - sharing mode invalid\n"); rc=1; } *return* rc; and the application worked! Not only worked, but worked perfectly! The minor dialog corruption of previous versions had completely gone! I would like to thank the hard working people who have been working to correct problems in Wine, and in doing so had fixed this minor dialog problem. The only issue of note then is that the top-right hand buttons of a maximized MDI child window do not appear until you resize the frame. This is a minor issue though, and not of importance here. However, what I did does not represent a real solution - I just hacked around the problem, which itself seems subtle in nature. I looked closely at the Microsoft documentation and the logic in check_sharing(), even writing a program in Windows to check that at the CreateFile level that the sharing logic in Wine is correct. It seems to be. I am now stumped, I would really like to get this app working properly under Wine, without bad hacks. I would appreciate any guidance from those more experienced with the user-land Windows API. If you got this far, many thanks for taking the time to read this long message. I have provided only small excerpts from logs, but I can provide other parts of the files on request if necessary. John.

2 3

Problems compiling latest git version
by Paul Vriens 09 Feb '06

09 Feb '06

Hi, with the latest git version (is that the correct naming?) I'm getting: make[1]: Entering directory `/wine/wine-git/include' ../tools/widl/widl -I. -I. -I../include -I../include -h -H mshtml.h mshtml.idl error: length() does not define an explicit binding handle! make[1]: *** [mshtml.h] Error 2 make[1]: Leaving directory `/wine/wine-git/include' make: *** [include] Error 2 any ideas? Paul.

3 2

wine on Intel Xeon processor
by Ananth M 09 Feb '06

09 Feb '06

Hi All I have a windows application that calls a function ( approximately 10000 times) exported by a third party DLL. I have two machines ( one with Intel pentium 4 processor and other with Intel Xeon processor ) with RHEL 4.0 installed on both of these machine. If I execute the windows application on the first machine (one with Intel pentium 4 processor ) using WINE, the execution time is almost equal to the execution time in windows machine. But, if I execute the same application on the second machine (Intel Xeon processor ), the execution time is almost 6 times to the first machine. I am using WINE-0.9.2 and wine is installed by downloading the wine source code from winehq.org Is it a known issue (or ) Do I need to do any additional configuration setting to work with Intel Xeon processor ? Regards Ajay

1 0

Re: Implement DVD_ReadStructure
by Detlef Riekenberg 09 Feb '06

09 Feb '06

Am Sonntag, den 05.02.2006, 22:01 +1100 schrieb Troy Rollo: > ChangeLog: > Implement DVD_ReadStructure > --- /dev/null 2006-02-03 18:20:42.451563144 +1100 > +++ wine-git/include/ntddcdvd.h 2006-02-05 21:50:39.000000000 +1100 Please use "include/ddk/" -- By By ... ... Detlef

7 11

wine on Intel Xeon Processor
by Ananth M 09 Feb '06

09 Feb '06

Hi I have a windows application that calls a function ( approximately 10000 times) exported by a third party DLL. I have two machines ( one with Intel pentium 4 processor and other with Intel Xeon processor ) with RHEL 4.0 installed on both of these machine. If I execute the windows application on the first machine (one with Intel pentium 4 processor ) using WINE, the execution time is almost equal to the execution time in windows machine. But, if I execute the same application on the second machine (Intel Xeon processor ), the execution time is almost 6 times to the first machine. I am using WINE-0.9.2 and wine is installed by downloading the wine source code from winehq.org Is it a known issue (or ) Do I need to do any additional configuration setting to work with Intel Xeon processor ? Any suggestions please Thank you Ajay

1 0

Directx 8 and wined3d
by Christian Gmeiner 09 Feb '06

09 Feb '06

Hi all. I have here a directx 8 game - first splinter cell - and i get this fixme: fixme:d3d_surface:IDirect3DSurface8Impl_UnlockRect Unsupported Format 22 in locking func So i looked at wine source and found out that format 22 (WINED3DFMT_X8R8G8B8) is supported in wined3d. Will directx8 converted to use wined3d or is it a good idea to write a patch for it? Thanks, Chiristian -- Christian Gmeiner - student of computer science http://dxr3plugin.sf.net http://itb04.ath.cx

2 3

dx9 and shaders
by Coleman Kane 09 Feb '06

09 Feb '06

Hi, What is the status on Shader support for DX9 in the latest WINE cvs, and the future projections of support in this area? I am working on a transition project, and am curious how far off support for this is in the WINE project, and perhaps where work needs to be done. Are there any people organizing this effort here? -- Coleman Kane

8 15

[wined3d] support for WINED3DFMT_A8B8G8R8
by Christoph Frick 09 Feb '06

09 Feb '06

attempt #3: this patch fixes several texture bugs with the demos of OGRE. License: LGPL ChangeLog: 2006-02-08 Christoph Frick <rid(a)zefix.tv> - dlls/wined3d/utils.c support for WINED3DFMT_A8B8G8R8 -- cu Index: dlls/wined3d/utils.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/utils.c,v retrieving revision 1.18 diff -u -r1.18 utils.c --- dlls/wined3d/utils.c 23 Nov 2005 19:29:20 -0000 1.18 +++ dlls/wined3d/utils.c 8 Feb 2006 12:23:00 -0000 @@ -35,6 +35,7 @@ FMT_TO_STR(WINED3DFMT_UNKNOWN); FMT_TO_STR(WINED3DFMT_R8G8B8); FMT_TO_STR(WINED3DFMT_A8R8G8B8); + FMT_TO_STR(WINED3DFMT_A8B8G8R8); FMT_TO_STR(WINED3DFMT_X8R8G8B8); FMT_TO_STR(WINED3DFMT_R5G6B5); FMT_TO_STR(WINED3DFMT_X1R5G5B5); @@ -1611,6 +1612,7 @@ case WINED3DFMT_A4R4G4B4: retVal = GL_RGBA4; break; case WINED3DFMT_X4R4G4B4: retVal = GL_RGB4; break; case WINED3DFMT_A8R8G8B8: retVal = GL_RGBA8; break; + case WINED3DFMT_A8B8G8R8: retVal = GL_RGBA8; break; case WINED3DFMT_A2R10G10B10: retVal = GL_RGBA8; break; case WINED3DFMT_X8R8G8B8: retVal = GL_RGB; break; /* to see */ @@ -1676,6 +1678,7 @@ case WINED3DFMT_A4R4G4B4: retVal = GL_BGRA; break; case WINED3DFMT_X4R4G4B4: retVal = GL_BGRA; break; case WINED3DFMT_A8R8G8B8: retVal = GL_BGRA; break; + case WINED3DFMT_A8B8G8R8: retVal = GL_RGBA; break; case WINED3DFMT_A2R10G10B10: retVal = GL_BGRA; break; case WINED3DFMT_X8R8G8B8: retVal = GL_BGRA; break; /* to see */ @@ -1738,6 +1741,7 @@ case WINED3DFMT_A4R4G4B4: retVal = GL_UNSIGNED_SHORT_4_4_4_4_REV; break; case WINED3DFMT_X4R4G4B4: retVal = GL_UNSIGNED_SHORT_4_4_4_4_REV; break; case WINED3DFMT_A8R8G8B8: retVal = GL_UNSIGNED_INT_8_8_8_8_REV; break; + case WINED3DFMT_A8B8G8R8: retVal = GL_UNSIGNED_INT_8_8_8_8_REV; break; case WINED3DFMT_A2R10G10B10: retVal = GL_UNSIGNED_INT_2_10_10_10_REV; break; case WINED3DFMT_X8R8G8B8: retVal = GL_UNSIGNED_INT_8_8_8_8_REV; break; /* to see */ @@ -1781,6 +1785,7 @@ case WINED3DFMT_A4R4G4B4: retVal = 2; break; case WINED3DFMT_X4R4G4B4: retVal = 2; break; case WINED3DFMT_A8R8G8B8: retVal = 4; break; + case WINED3DFMT_A8B8G8R8: retVal = 4; break; case WINED3DFMT_A2R10G10B10: retVal = 4; break; case WINED3DFMT_X8R8G8B8: retVal = 4; break; /* Paletted */

3 3

Fwd: game "Knights and Merchants" deadlocks
by James Trotter 09 Feb '06

09 Feb '06

On 2/4/06, Joris Huizer <jorishuizer(a)planet.nl> wrote: > > Hello, > > I have this question: I have a game called "Knights and Merchants" which > I sometimes play; I find it deadlocks each time after playing for an > hour or so > it seems it isn't a complete deadlock, sometimes some of sound comes > through between intervals of minutes or so; harddisk activity seems > extreme - the light is burning constantly. > I then usually decide to kill the program; as it opens fullscreen I > can't get to the xterm that launched it, so I try to get to a console; > The system is so slow that it takes some time to get to a console > <ctrl-alt-f1>, and login in may time out a few times before finaly > getting in (the cure to that one is simple: login before starting the > game...) - then it takes another minute or so to run ps and kill the > wine process > > is there a way to find what is causing the deadlock? I can log the > output wine gives using `script`, but as deadlocks only occur after a > lot of time running the game with lots of logging active would be a pain > > will log the output at least next time I play; for now, has somebody > ideas how to log without getting major slowdown (otherwise there's no > playing in it)? > > thanks, > > Joris > > > This really sounds like a memory leak to me. Usually I'd use valgrind ( http://valgrind.org/) to find memory leaks and such. Valgrind 3.1.0 works with wine, but it produces alot of output you'd have to look through and the program will run insanely slow. It might be worth a try.

3 6

Re: Wine and Intel Macs
by Steven Edwards 09 Feb '06

09 Feb '06

Hi, On 2/8/06, Eric W. Triplett <ewt(a)ufl.edu> wrote: > Does Wine work with the new Macs that contain Intel processors? If > so, which distribution should I download and install? It should compile out of the box. Beware you may need a few patches from the darwine mailing list to get some win32 apps running. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Somewhat disappointing experiences with Winelib and WTL
by Claus Fischer 08 Feb '06

08 Feb '06

Hi Wine developers and users! Over the last few days, I have been trying to find out whether the combination of WTL and Winelib could be a promising inter-platform GUI solution. While I have made some progress and got some new knowledge, I believe I have now come to a dead end where I'll have to give up that attempt. In case you are interested, here's my summary report. It might be useful to others. Regards, Claus *********************************************************** The Goal: ********* WTL on Windows gives me: - compact executables: small and fast - easy-to-install executables: no DLLs needed - programs easy to maintain and deploy - mature GUI The goal is to combine WTL/ATL (no COM) with Winelib to create a Linux-application with the same look and feel and roughly the same qualities: no DLL's, shared libraries, C++ ABI hassles, etc. Just one binary linked to libc. 1. ATL/WTL ********** ATL 3.0 (from my MSVC 6 compiler) and WTL 7.5 (from sourceforge) can be made to work. Issues are: - GCC 4 is very picky with templates and would need lots of template prototypes; I have used GCC 3.3.5 - Some template prototypes are still needed - Some MSVC-specific pragmas etc. need to be ifdef'd - A few pack pragmas need to be replaced by Wine's pack headers - Everything related to _get_uuid(class) I've commented out; I need no COM stuff - Some GCC warnings need to be turned off, or alternatively code changes need to be made - Various small changes - As more parts of WTL get used (i.e. instantiated), more changes will be required Basically, ATL+WTL can reach a state where they compile with GCC 3 and the changes are still mostly cosmetic. Some of the changes might even be incorporated in the official WTL, now that it's free. I have read the mails of Boaz Harrosh' previous changes; apparently he has had to invest much more work because of COM. With the modified ATL/WTL, I was able to compile the wizard-created sample SDI application on Linux. 2. Winelib "as is" ****************** After some digging through the Web, I've been able to link the sample SDI application against Winelib. It took somewhat longer than it should have due to (a) WTL's habit of just ATLASSERT()ing things and (b) the rather elaborate work of finding those places with wine-dbg and/or ATLTRACE()s plus WINEDEBUG=+relay. Since I'm not familiar with the Wine debugger, it would have been very helpful to be able to use gdb on the resulting executable. However, gdb reported that it didn't know the file format. ==> Wishlist to Wine: - Make gdb work on Winelib programs - Document Winelib and the build process better (the documentation is outdated, though the tools are good). All in all a reasonably successful endeavour, and the application runs stable and looks fine except for the font (that probably can be configured better). BUT: ... BIG SHOCK: That's not a single ELF executable, it's a weird mixture of PE and ELF and a .so file and a wrapper program that apparently starts wine in the background ... That doesn't fulfill my goals of building a native Linux exe with no dependencies except libc. It's also quite slow when loading. 3. Winelib statically linked **************************** Apparently Wine has made a decision a few years ago: that support for native Windows apps with all the infrastructure they need (Wine server, registry, resources, multithreading, etc.) is more important than support for porting applications to native Linux apps. That decision is obviously correct, given the large number of Windows applications that are only available as binaries and require much infrastructure. I'm aware of that, but I've still decided to give my dream of a native Linux app a try. I tried the following method: (a) Get and compile Wine 0.9.7 (b) Add rules to Makedll.rules to pack the objects into .a libraries (c) Attempt to link my program's objects against those static libs (d) Make changes and corrections and repeat I first made a reduced WTL application that does not use a resource file. I don't know if this was a good decision. The following changes were necessary to Wine: - Comment out a lot of DLLMain functions - Comment out some 16-bit functions that have name collisions - Turn on debug mode (-O0 -g) - Write a startup function main() (Wine's libwinecrt0.a didn't work for me) That might be the reason for more trouble - Link to all of libs/unicode - Link to some objects in libs/wine (I didn't link to loader, don't know if that's good) This is where the heavy trouble started: - Replace the assembly stuff in critical sections (due to the debug mode) ... my app is single-threaded - Somehow set up code pages for ansi/Unix (LocaleInit() failed, see below) - Comment out some calls to the registry where the run-time environment is registered What eventually caused me to stop is: - Somehow fake Wine Server or do the equivalent stuff or just jump over (Basically Register Class as atoms) - Somehow fake a lot of initial resources (E.g. GetSystemCursor etc.) - Overall too many modifications in interacting systems - Altogether not a "robust" feeling This is where I stopped. I don't know whether I'm "so close" or miles away, but my random code editing seemed to get out of hand. 4. What is needed ***************** What would be needed to support static linking against Winelib (if that's decided to be a supportworthy goal): - Infrastructure to build static libs - separate out DllMain - separate out some 16 bit functions - Possibility to provide heap based allocation through straight malloc() - Infrastructure to fake loading resources (for those resources that come from Winelib/system) - Infrastructure for proper initialization of modules e.g. through one setup function for each DLL and one common setup function that calls the others in some natural order The overall initialization function should be configurable so that programs that need only a few DLL's (user, gdi, crtdll, kernel, ntdll) don't need to link everything - Infrastructure to allow faking registry calls for those calls initiated by Winelib internal stuff (and possibly also ATL/WTL internal stuff) - Infrastructure to handle Window class registration etc. (i.e. reduced Wine server support in the app) What I specifically don't need/want through Winelib: - networking - filesystem access - loading of external DLL's or other libraries - C++ runtime library support *********************************************************** This is, in keywords, my experience with WTL and static Winelib linking. I'll be apreciative of any responses. Please CC: my mail address. Also, if anyone is interested in hosting patches to ATL/WTL or even just looking at them, I'll gladly provide them. Regards, Claus -- Claus Fischer <claus.fischer(a)clausfischer.com> http://www.clausfischer.com/

6 10

Wine and Intel Macs
by Eric W. Triplett 08 Feb '06

08 Feb '06

Does Wine work with the new Macs that contain Intel processors? If so, which distribution should I download and install? Thanks, Eric -- ___________________________________________ Professor Eric W. Triplett, Chair Department of Microbiology and Cell Science Institute of Food and Agricultural Sciences University of Florida P.O. Box 110700 Gainesville, FL 32611-0700 1-352-392-5430 (phone) 1-352-392-5922 (fax) ewt(a)ufl.edu ___________________________________________

1 0

gethostbyname call with 0 length arg
by Phil Goss 08 Feb '06

08 Feb '06

Hi, Is it a bug in the WINE gethostbyname (WS_gethostbyname) implementation, where if the arg name is of string length 0, then it returns unsuccessful. I have experience this issue with a Windows program (Onkyo Nettune) where the hostname passed to gethostbyname is of length 0. (This seems to be a bug in the program itself). However, the program works okay in native Windows. There seems to be a check in the gethostbyname for a NULL arg name ... if(!name) ... But no check for ... if(!strlen(name)) .... I have tested the strlen check and it seems to work and satisfies the Windows program. Does the above make sense, as I am not a programmer? Not sure if this s bug in wine even though it implementation should be matching Windows native. Thanks, Phil -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/

4 9

Wine with multiple threads on Dual processor - any suggestions please
by Ananth M 08 Feb '06

08 Feb '06

Hi, I am having an application with the processing can be done paralally using multiple threads. If I compile (with one thread ) and execute this application in Linux , on a Dual processor machine , I am getting execution time ~600 sec. If I compile ( with 2 threads ), and execute this application in Linux on a Dual processor machine , I am getting execution time ~300 sec. If I compile the same program (with One thread) using wineg++ and execute the program ,I am getting execution time as ~500 sec If I compile the same program ( with 2 threads ) using wineg++ and execute the program , I am getting the same execution time ~500 sec. Is there any isses with wine on Dual processor machines ( Intel Xeon processor ) w.r.t multi threaded programming? Does any one got this type of problem ? Any suggestions please.... Thank you, Regards Ajay

1 0

Re: VC++ demangling tool
by Eric Pouech 08 Feb '06

08 Feb '06

Michael Stefaniuc wrote: > Hello! > > winedump has a VC++ symbol demangling function but that is bitrotting as > it is a copy of the msvcrt.__unDname . As i wanted to use the newer > msvcrt.__unDname funtion i have written a quick and dirty program that > is basicaly only a wrapper around UnDecorateSymbolName(). Most importand > feature is that it runs on the command line. > I'm not expecting it to go into Wine but others might find it usefull. > After applying the patch configure needs to be regenerated. actually, there's a tool in the MS SDK called undname that does exactly this... it has also a couple of other options (like demangling all symbols listed in a text file)... but what should be done is to port back the code from msvcrt into winedump A+ -- Eric Pouech

6 8

Re: Add missing LANG_xxx and SUBLANG_xxx macros
by Alexandre Julliard 08 Feb '06

08 Feb '06

Francois Gouget <fgouget(a)free.fr> writes: > On Tue, 7 Feb 2006, Huw D M Davies wrote: > [...] >> Why is WELSH in between TIBETAN and TIGRIGNA ? > > No idea. Must be a bug in the sort algorithm ;-) > Here's a corrected patch. ... > +#define LANG_YORUBA 0x6a > +#define LANG_WELSH 0x52 > +#define LANG_ZULU 0x35 The sort algorithm still needs some work ;-) On a more serious note, you'll need to fix the registry entries in wine.inf, otherwise the tests fail. -- Alexandre Julliard julliard(a)winehq.org

1 0

[dinput] dynamic handling of buttons of a device
by Christoph Frick 08 Feb '06

08 Feb '06

attempt #2: this patch detects and maps the buttons dynamically instead of the hardcoded way it was before. this fixes the problems with devices, that report events in the joystick _and_ gamepad range of button events License: LGPL ChangeLog: 2006-02-08 Christoph Frick <rid(a)zefix.tv> - dlls/dinput/joystick_linuxinput.c dynamic assignment of buttons on a device -- cu Index: dlls/dinput/joystick_linuxinput.c =================================================================== RCS file: /home/wine/wine/dlls/dinput/joystick_linuxinput.c,v retrieving revision 1.35 diff -u -r1.35 joystick_linuxinput.c --- dlls/dinput/joystick_linuxinput.c 23 Nov 2005 19:29:19 -0000 1.35 +++ dlls/dinput/joystick_linuxinput.c 8 Feb 2006 12:22:53 -0000 @@ -120,7 +120,9 @@ int ff_state; /* data returned by the EVIOCGABS() ioctl */ - int axes[ABS_MAX+1][5]; + int axes[ABS_MAX][5]; + /* LUT for KEY_ to offset in rgbButtons */ + BYTE buttons[KEY_MAX]; #define AXE_ABS 0 #define AXE_ABSMIN 1 @@ -457,7 +459,7 @@ */ static HRESULT WINAPI JoystickAImpl_Acquire(LPDIRECTINPUTDEVICE8A iface) { - int i; + int i,buttons; JoystickImpl *This = (JoystickImpl *)iface; char buf[200]; BOOL readonly = TRUE; @@ -529,7 +531,7 @@ if (test_bit(This->absbits,i)) { if (-1==ioctl(This->joyfd,EVIOCGABS(i),&(This->axes[i]))) continue; - FIXME("axe %d: cur=%d, min=%d, max=%d, fuzz=%d, flat=%d\n", + TRACE("axe %d: cur=%d, min=%d, max=%d, fuzz=%d, flat=%d\n", i, This->axes[i][AXE_ABS], This->axes[i][AXE_ABSMIN], @@ -541,7 +543,14 @@ This->havemax[i] = This->axes[i][AXE_ABSMAX]; } } - MESSAGE("\n"); + buttons = 0; + for (i=0;i<KEY_MAX;i++) { + if (test_bit(This->keybits,i)) { + TRACE("button %d: %d\n", i, buttons); + This->buttons[i] = 0x80 | buttons; + buttons++; + } + } fake_current_js_state(This); @@ -661,6 +670,7 @@ struct timeval tv; fd_set readfds; struct input_event ie; + int btn; if (This->joyfd==-1) return; @@ -680,76 +690,14 @@ TRACE("input_event: type %d, code %d, value %d\n",ie.type,ie.code,ie.value); switch (ie.type) { case EV_KEY: /* button */ - switch (ie.code) { - case BTN_TRIGGER: /* normal flight stick */ - case BTN_A: /* gamepad */ - case BTN_1: /* generic */ - This->js.rgbButtons[0] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(0),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_THUMB: - case BTN_B: - case BTN_2: - This->js.rgbButtons[1] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(1),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_THUMB2: - case BTN_C: - case BTN_3: - This->js.rgbButtons[2] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(2),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_TOP: - case BTN_X: - case BTN_4: - This->js.rgbButtons[3] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(3),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_TOP2: - case BTN_Y: - case BTN_5: - This->js.rgbButtons[4] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(4),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_PINKIE: - case BTN_Z: - case BTN_6: - This->js.rgbButtons[5] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(5),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + btn = This->buttons[ie.code]; + TRACE("(%p) %d -> %d\n", This, ie.code, btn); + if (btn&0x80) { + btn &= 0x7F; + This->js.rgbButtons[btn] = ie.value?0x80:0x00; + GEN_EVENT(DIJOFS_BUTTON(btn),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + } break; - case BTN_BASE: - case BTN_TL: - case BTN_7: - This->js.rgbButtons[6] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(6),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_BASE2: - case BTN_TR: - case BTN_8: - This->js.rgbButtons[7] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(7),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_BASE3: - case BTN_TL2: - case BTN_9: - This->js.rgbButtons[8] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(8),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_BASE4: - case BTN_TR2: - This->js.rgbButtons[9] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(9),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - case BTN_BASE5: - case BTN_SELECT: - This->js.rgbButtons[10] = ie.value?0x80:0x00; - GEN_EVENT(DIJOFS_BUTTON(10),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); - break; - default: - FIXME("unhandled joystick button %x, value %d\n",ie.code,ie.value); - break; - } - break; case EV_ABS: switch (ie.code) { case ABS_X: @@ -794,6 +742,9 @@ This->ff_state = ie.value; break; #endif + case EV_SYN: + /* there is nothing to do */ + break; default: FIXME("joystick cannot handle type %d event (code %d)\n",ie.type,ie.code); break; @@ -1141,7 +1092,7 @@ if ((dwFlags == DIDFT_ALL) || (dwFlags & DIDFT_BUTTON)) { - int i; + int i, btncount=0; /*The DInput SDK says that GUID_Button is only for mouse buttons but well*/ @@ -1149,74 +1100,10 @@ for (i = 0; i < KEY_MAX; i++) { if (!test_bit(This->keybits,i)) continue; - - switch (i) { - case BTN_TRIGGER: - case BTN_A: - case BTN_1: - ddoi.dwOfs = DIJOFS_BUTTON(0); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 0) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_THUMB: - case BTN_B: - case BTN_2: - ddoi.dwOfs = DIJOFS_BUTTON(1); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 1) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_THUMB2: - case BTN_C: - case BTN_3: - ddoi.dwOfs = DIJOFS_BUTTON(2); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 2) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_TOP: - case BTN_X: - case BTN_4: - ddoi.dwOfs = DIJOFS_BUTTON(3); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 3) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_TOP2: - case BTN_Y: - case BTN_5: - ddoi.dwOfs = DIJOFS_BUTTON(4); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 4) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_PINKIE: - case BTN_Z: - case BTN_6: - ddoi.dwOfs = DIJOFS_BUTTON(5); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 5) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_BASE: - case BTN_TL: - case BTN_7: - ddoi.dwOfs = DIJOFS_BUTTON(6); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 6) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_BASE2: - case BTN_TR: - case BTN_8: - ddoi.dwOfs = DIJOFS_BUTTON(7); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 7) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_BASE3: - case BTN_TL2: - case BTN_9: - ddoi.dwOfs = DIJOFS_BUTTON(8); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 8) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_BASE4: - case BTN_TR2: - ddoi.dwOfs = DIJOFS_BUTTON(9); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 9) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - case BTN_BASE5: - case BTN_SELECT: - ddoi.dwOfs = DIJOFS_BUTTON(10); - ddoi.dwType = DIDFT_MAKEINSTANCE((0x0001 << 10) << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; - break; - } - sprintf(ddoi.tszName, "%d-Button", i); + ddoi.dwOfs = DIJOFS_BUTTON(btncount); + ddoi.dwType = DIDFT_MAKEINSTANCE(btncount << WINE_JOYSTICK_BUTTON_BASE) | DIDFT_PSHBUTTON; + sprintf(ddoi.tszName, "%d-Button", btncount); + btncount++; _dump_OBJECTINSTANCEA(&ddoi); if (lpCallback(&ddoi, lpvRef) != DIENUM_CONTINUE) { /* return to unaquired state if that's where we were */

1 0

[wined3d] better warn/fixme for query handling
by Christoph Frick 08 Feb '06

08 Feb '06

hiho, this is one of three patches i still have in my cvs-tree that are not supplied. like the following i tired to submit several times - except for this one i never got a feedback, whats wrong. Licence: LGPL ChangeLog: 2006-02-08 Christoph Frick <rid(a)zefix.tv> - dlls/wined3d/device.c more granular handling of errors for queries -- cu Index: dlls/wined3d/device.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/device.c,v retrieving revision 1.125 diff -u -r1.125 device.c --- dlls/wined3d/device.c 7 Feb 2006 16:02:51 -0000 1.125 +++ dlls/wined3d/device.c 8 Feb 2006 12:23:00 -0000 @@ -1095,8 +1095,14 @@ if (NULL == ppQuery) { /* Just a check to see if we support this type of query */ HRESULT hr = D3DERR_NOTAVAILABLE; - /* Lie and say everything is good (we can return ok fake data from a stub) */ switch(Type) { + case WINED3DQUERYTYPE_OCCLUSION: + TRACE("(%p) occlusion query\n", This); + if (GL_SUPPORT(ARB_OCCLUSION_QUERY) || GL_SUPPORT(NV_OCCLUSION_QUERY)) + hr = D3D_OK; + else + WARN("Unsupported in local OpenGL implementation: ARB_OCCLUSION_QUERY/NV_OCCLUSION_QUERY\n"); + break; case WINED3DQUERYTYPE_VCACHE: case WINED3DQUERYTYPE_RESOURCEMANAGER: case WINED3DQUERYTYPE_VERTEXSTATS: @@ -1110,16 +1116,11 @@ case WINED3DQUERYTYPE_PIXELTIMINGS: case WINED3DQUERYTYPE_BANDWIDTHTIMINGS: case WINED3DQUERYTYPE_CACHEUTILIZATION: - break; - case WINED3DQUERYTYPE_OCCLUSION: - TRACE("(%p) occlusion query\n", This); - if (GL_SUPPORT(ARB_OCCLUSION_QUERY) || GL_SUPPORT(NV_OCCLUSION_QUERY)) - hr = D3D_OK; - break; + FIXME("(%p) Unsupported query type %d\n", This, Type); + break; default: - FIXME("(%p) Unhandled query type %d\n",This , Type); + FIXME("(%p) Unhandled query type %d\n", This, Type); } - FIXME("(%p) : Stub request for query type %d returned %ld\n", This, Type, hr); return hr; }

1 0

re: riched20 conformance test + find fix [bug 4479]
by Dan Kegel 07 Feb '06

07 Feb '06

Thomas Kho wrote in http://www.winehq.org/pipermail/wine-patches/2006-February/023959.html : > ... fixes bug 4479 (find has a bounds bug). > Additionally, this patch adds a conformance test for rich edit with > tests for EM_FINDTEXT and EM_FINDTEXTEX. Tommy, your haystack[] variable is long and complex. Can you get the same testing out of a shorter sample string? Can you add a comment for each little check, translating it into english? All your tests seem to use the FR_MATCHCASE and FR_DOWN flags, could you also test without those flags a bit more? How sure are you about the bugfix? Are there other places in the source where a similar off-by-one error is made? Otherwise this looks great. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: server: allow OpenClipboard to succeed when already open
by Eric Frias 07 Feb '06

07 Feb '06

James Hawkins wrote: > On 2/7/06, Eric Frias <efrias(a)syncad.com> wrote: > >> I think I submitted a version >> of this patch a year or two back, but it wasn't accepted. > > You should add a unit test for this case in Wine's test suite. It > would be pretty easy to write, and it would verify this information, > making your fix more likely to be accepted. Yeah, I didn't write a test on first go-around and I didn't follow up, so I'm not entirely surprised that the patch didn't get accepted. This is the first time I've tried to write a test, and I was pleased to find out that it was easy to do and the documentation on test-writing and compiling was accurate. Eric

1 0

wined3d: CheckDeviceMultiSampleType
by Vitaly Budovski 07 Feb '06

07 Feb '06

Can I have some feedback on the attached patch? I'm not entirely sure it's correct. Thanks, Vitaly diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 7aa8d5d..8394362 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1245,6 +1245,13 @@ HRESULT WINAPI IWineD3DImpl_CheckDeviceM BOOL Windowed, D3DMULTISAMPLE_TYPE MultiSampleType, DWORD* pQualityLevels) { IWineD3DImpl *This = (IWineD3DImpl *)iface; + HDC deviceContext; + Display * pDisplay; + GLXFBConfig * pConfig; + int attributeList[5] = {GLX_SAMPLE_BUFFERS_ARB, 1, GLX_SAMPLES_ARB, MultiSampleType, 0}; + int configCount; + int attributeValue; + TRACE_(d3d_caps)("(%p)-> (STUB) (Adptr:%d, DevType:(%x,%s), SurfFmt:(%x,%s), Win?%d, MultiSamp:%x, pQual:%p)\n", This, Adapter, @@ -1267,7 +1274,32 @@ HRESULT WINAPI IWineD3DImpl_CheckDeviceM *pQualityLevels = 1; /* Guess at a value! */ } - if (D3DMULTISAMPLE_NONE == MultiSampleType) return D3D_OK; + if(D3DMULTISAMPLE_NONE == MultiSampleType) return D3D_OK; + + /* Get the display */ + deviceContext = GetDC(0); + pDisplay = get_display(deviceContext); + + ENTER_GL(); + + pConfig = glXChooseFBConfig(pDisplay, 0, attributeList, &configCount); + if(pConfig) { + if(!glXGetFBConfigAttrib(pDisplay, *pConfig, GLX_SAMPLES, &attributeValue)) { + XFree(pConfig); + + LEAVE_GL(); + ReleaseDC(0, deviceContext); + + return D3D_OK; + } + } else { + FIXME("Error retrieving FBConfig\n"); + } + XFree(pConfig); + + LEAVE_GL(); + ReleaseDC(0, deviceContext); + return D3DERR_NOTAVAILABLE; }

2 1

Re: server: allow OpenClipboard to succeed when already open
by James Hawkins 07 Feb '06

07 Feb '06

On 2/7/06, Eric Frias <efrias(a)syncad.com> wrote: > When OpenClipboard is called twice in a row with the same HWND as a > parameter, wine lets the first call succeed, but the second call fails > because the clipboard was already locked. Although it's not specified > in the docs, Windows allows the second call to succeed (and something > deep inside of our app depends on this). I think I submitted a version > of this patch a year or two back, but it wasn't accepted. > You should add a unit test for this case in Wine's test suite. It would be pretty easy to write, and it would verify this information, making your fix more likely to be accepted. -- James Hawkins

3 3

Re: shell32: SHELL32_GetItemAttributes()
by Martin Fuchs 07 Feb '06

07 Feb '06

is there anything wrong with this patch to get Photoshop launching again? On 31.01.2006 22:58:34 Martin Fuchs wrote: > Changelog: > - retrieve file attributes using SHGetPathFromIDListW() when they are not already > present in the internal PIDL structures > - correct documentation which incorrectly claimed not to set any attribute bits

1 0

Re: msvcrt: Handle data types B,R,S in C++ symbol demangling
by Eric Pouech 07 Feb '06

07 Feb '06

Michael Stefaniuc wrote: > Hello, > > found while trying to demangle some mfc42 symbols. Tested against native > msvcrt with my small demangle.exe tool. actually, it would be good to add them to the test part as well A+ -- Eric Pouech

2 1

Re: Remove %1 from [http|htmlfile]\shell\open\command
by Michael Ost 07 Feb '06

07 Feb '06

While you're playing with wine's default registry, could you create a registry entry for https? It can be just the same as the http rule, e.g. HKEY_CLASSES_ROOT/https/shell/open/command = winebrowser %1 (or whatever the http rule ends up being. I have an app that assumes that entry exists and it exists in my windows XP registry, tho I am not sure who created it. Thanks... mo

1 0

Re: Add missing LANG_xxx and SUBLANG_xxx macros
by Huw D M Davies 07 Feb '06

07 Feb '06

On Tue, Feb 07, 2006 at 07:08:58PM +0100, Francois Gouget wrote: > Index: include/winnt.h > =================================================================== > RCS file: /home/wine/wine/include/winnt.h,v > retrieving revision 1.227 > diff -u -p -r1.227 winnt.h > --- include/winnt.h 3 Feb 2006 18:04:06 -0000 1.227 > +++ include/winnt.h 7 Feb 2006 16:44:07 -0000 > #define LANG_TELUGU 0x4a > #define LANG_THAI 0x1e > +#define LANG_TIBETAN 0x51 > +#define LANG_WELSH 0x52 > +#define LANG_TIGRIGNA 0x73 > +#define LANG_TSWANA 0x32 > #define LANG_TURKISH 0x1f Why is WELSH in between TIBETAN and TIGRIGNA ? Huw.

1 0

*** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so',
by Rainer Dorsch 07 Feb '06

07 Feb '06

Hello, I compiled the last few wine releases. 0.9.6 gives me a compile error: make[2]: Entering directory `/home/rd/SW.nobackup/wine-0.9.6/programs/winetest' make[2]: *** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so', needed by `d3d9_test.exe.so'. Stop. Any hints are welcome. Thanks, Rainer

5 9

RE: select behavior different with wine
by Phil Lodwick 07 Feb '06

07 Feb '06

I have attached a patch that fixes this problem for me. Does anybody want to comment on it before I submit it. Is there a better way? Thanks, Phil -----Original Message----- From: wine-devel-bounces(a)winehq.org [mailto:wine-devel-bounces@winehq.org] On Behalf Of Phil Lodwick Sent: Wednesday, February 01, 2006 4:14 PM To: wine-devel(a)winehq.org Subject: select behavior different with wine Greetings, I ran across a problem that the following code demonstrates. I believe it is due to the different definition of select on Windows vs Linux. Before I start to think about how to fix this in Wine, I was wondering if anybody has already thought about the problem. #include "stdafx.h" #include <winsock2.h> int _tmain(int argc, _TCHAR* argv[]) { SOCKET fd; WORD wVersionRequested; WSADATA wsaData; wVersionRequested = MAKEWORD( 2, 2 ); WSAStartup(wVersionRequested, &wsaData); fd = socket(AF_INET, SOCK_STREAM, 0); if (fd != INVALID_SOCKET) { fd_set readfds; struct timeval select_timeout ; FD_ZERO(&readfds); FD_SET(fd, &readfds) ; select_timeout.tv_sec=2 ; select_timeout.tv_usec=0 ; if (select((int) fd+1, &readfds, NULL, NULL, &select_timeout) != SOCKET_ERROR) { if(FD_ISSET(fd, &readfds)) printf("THIS IS WINE\n"); else printf("THIS IS WINDOWS\n"); } else printf("got a socket error\n"); closesocket(fd); } return 0; }

1 0

Re: [Fwd: Re: [AppDB] modify installs and runs fields]
by Tony Lambregts 07 Feb '06

07 Feb '06

Mike McCormack wrote: > > If you've already got a way of showing what works "out of the box" > that's great! It wasn't obvious to me. > > I had to dig around the appdb pages to figure out where you define what > "gold" is, and there's also no way to search for "gold" apps. > > So what I really want is a way to list all the apps that run out of the > box. How can I do that? > > If we can get people to concentrate on getting applications to "gold" > and then testing them like that, I think it would be a good thing. > The current situation is that we lack a query page in the AppDB. This needs to be rectified. One of the main reasons I have not addressed this because as soon as it is created it will be called inadequate, and no matter the amount of work put into it it will continue to be a source of complaints. (Yes thats cinical but it's from experience based on the complaints about the query page for bugzilla ). So I know it should be done but am personaly not motivated to do it. ;^{ -- Tony Lambregts

1 0

Re: *** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so',
by H. Verbeet 07 Feb '06

07 Feb '06

On 07/02/06, Rainer Dorsch <rdorsch(a)web.de> wrote: > ...but the test fails: > > make[2]: Entering directory > `/home/rd/SW.nobackup/wine-0.9.7/programs/winetest' > make[2]: *** No rule to make target `../../dlls/d3d9/tests/d3d9_test.exe.so', > needed by `d3d9_test.exe.so'. Stop. - Does making the tests in dlls/d3d9/tests work? ie, rd@silverboxy:~/SW.nobackup/wine-0.9.7/dlls/d3d9/tests$ make - The d3d9 tests are on top of the Makefile for winetest. Does making other tests work? eg, rd@silverboxy:~/SW.nobackup/wine-0.9.7/programs/winetest$ make ntdll_test.exe.so

2 1

game "Knights and Merchants" deadlocks
by Joris Huizer 07 Feb '06

07 Feb '06

Hello, I have this question: I have a game called "Knights and Merchants" which I sometimes play; I find it deadlocks each time after playing for an hour or so it seems it isn't a complete deadlock, sometimes some of sound comes through between intervals of minutes or so; harddisk activity seems extreme - the light is burning constantly. I then usually decide to kill the program; as it opens fullscreen I can't get to the xterm that launched it, so I try to get to a console; The system is so slow that it takes some time to get to a console <ctrl-alt-f1>, and login in may time out a few times before finaly getting in (the cure to that one is simple: login before starting the game...) - then it takes another minute or so to run ps and kill the wine process is there a way to find what is causing the deadlock? I can log the output wine gives using `script`, but as deadlocks only occur after a lot of time running the game with lots of logging active would be a pain will log the output at least next time I play; for now, has somebody ideas how to log without getting major slowdown (otherwise there's no playing in it)? thanks, Joris

2 4

Meaning of error message
by Segin 07 Feb '06

07 Feb '06

II have recently recieved the following message during the installation of a program with the instantaneous termination of the installer: wine-pthread: stack smashing attack in function RichEditANSIWndProc() Does this mean that there is a bug in the installer or the function RichEditANSIWndProc()?

2 2

Regarding java in wine....
by fu ke 07 Feb '06

07 Feb '06

Hi all, I've been trying out wine for sometimes, and I notice that, there is still no satisfied solution regarding java support in wine. Please correct me if I'm wrong. I've been wondering after reading the wine FAQ (see below), if it is possible to "delegate" java "request" to native java under linux. What we need are: - wine application to delegate java requests to native java under linux transparently. - browser plugins for "java applet", which uses native java under linux transparently too. Since I'm not (yet) wine developer, I would like to know, if these possibilities are feasible or not. Thank you. BTW: since I'm not (yet) on the wine-devel list, please be kind and CC me on reply :) best regards, -fuke Wine - FAQ: --- http://www.winehq.org/site/docs/wine-faq/index#CAN-I-LAUNCH-UNIX-APP-FROM-W… 6.8. Can I launch a Unix program from a Windows program? Sure, Wine supports that. Just enter the unix program name wherever a program has something that it's supposed to execute, and it should just work. --- _/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/ _/ love is eternal ... _/ _/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/ _/ the bible told me. _/ _/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/- fUke(a)hotmail.com -_/

1 0

Re: Remove %1 from [http|htmlfile]\shell\open\command
by Vitaliy Margolen 07 Feb '06

07 Feb '06

Tuesday, January 31, 2006, 8:55:02 PM, Dmitry Timoshkov wrote: > Hello, > > the app I'm working on does: > > RegCreateKeyEx(HKCR, "http\shell\open\command", &hkey); > RegQueryValueEx(hkey, cmd); > ShellExecute(cmd, "http://host/url"); > > Currently it fails under Wine because we have "winebrowser %1" > as the command name in the registry. > > A simple 5 lines long test under Windows shows that if the command > passed to ShellExecute contains %1 after executable name it fails > as well. Moreover, registry under Windows doesn't have %1 in > the command name specified in http\shell\open\command. > > I've also verified that it's true for htmlfile\shell\open\command as well, > although mailto\shell\open\command has the %1 appendix in Windows. > > This patch fixes my application. > > Changelog: > Remove %1 from [http|htmlfile]\shell\open\command. Well this patch broke functionality with other applications. And I'm not sure that this program doing the right thing as on win2k with FireFox installed I have @=C:\PROGRA~1\MOZILL~1\FIREFOX.EXE -url "%1" So we need to decide which programs do we want to brake and which programs we want to have working. Vitaliy Margolen

3 6

Exec-Shield / Prelinking Issue - Please help =/
by Joey Robinson 07 Feb '06

07 Feb '06

Greetings, I'm experiencing in issue with the latest Wine on Fedora Core 4, latest kernel and all latest drivers available. I'm attempting to run World of Warcraft, after compiling a custom build of wine, with instructions outlined at http://wiki.kaspersandberg.com/doku.php?id=howtos:wine:worldofwarcraft Everything compiles fine, and I'm able to run wine to generat the ~/home/user/.wine directory The problem comes when I try to run the mozilla patcher, I receive an error that says: [inferno@localhost ~]$ cd .wine/drive_c/Program\ Files/World\ of\ Warcraft/ [inferno@localhost World of Warcraft]$ wine WoW.exe -opengl err:virtual:map_image Image was mapped at 0xda0000: standard load address for a Win32 program (0x00400000) not available err:virtual:map_image Do you have exec-shield or prelink active? wine: could not load L"C:\\Program Files\\World of Warcraft\\WoW.exe" as Win32 binary [inferno@localhost World of Warcraft]$ -- I've checked all available settings, and I have fully disabled Prelinking and Exec-Shield to the best of my knowledge. I've added b /usr/lib{,64}/wine to /etc/prelink.conf I've set prelink to no in /sysconfig/prelink and restarted prelink And I did a set kernel.exec-shield = 0 in sysctl.conf The issue persists, I've also tried manually installing the Mozilla files from a different library which worked fine, but I continue to get the error even when trying to run "wine -WoW.exe -opengl" Does anyone have any advice? I would be eternally grateful for a direction to go in. Cedega will not work for WoW for me, as it has a persistant D3D issue and bad OpenGL support. Wine is my only option. Thank you very much in advance!

2 1

Re: usp10: Resend of tests for usp10
by Stefan Leichter 06 Feb '06

06 Feb '06

Am Montag, 6. Februar 2006 12:51 schrieb Jeff L: > Have combined the files into one file. The SUBDIR = tests entry is in > the earlier file with usp10 functionality for ScritpItemize, ScriptShape > and ScriptPlace. > > Jeff Latimer Hi Jeff, looks like i confuse you a little. With +++ usp10.c -> +++ dlls/usp10/tests/usp10.c a meant you should put the path in front of the filename. Also i hopefully did not tell you to remove the /dev/ null line. The start of the patch of the file usp10.c should look like: --- /dev/null 2006-02-04 22:24:13.994829600 +1100 +++ dlls/usp10/tests/usp10.c 2006-02-05 13:56:46.000000000 +1100 The same for Makefile.in in the tests directory. And please include a patch to the Makefile.in in the dlls/usp10 directory. It should look like: --- dlls/usp10/Makefile +++ dlls/usp10/Makefile @@ -14,6 +14,8 @@ C_SRCS = \ usp10.c +SUBDIRS = tests + @MAKE_DLL_RULES@ ### Dependencies: The patch is written by hand, don't be surprised if it does not apply. Bye Stefan

1 0

Re: [AppDB] modify installs and runs fields
by Tony Lambregts 06 Feb '06

06 Feb '06

Mike McCormack wrote: > > Actually it appears other share my altered sense of reality. > > World Of Warcraft 1.3.0 is the top ranking "Gold" application, yet it > requires mfc42, msvcp60.dll and possibly some patches to run. > > MS Money is also in the Gold list and requires DCOM95 and IE6. > > Are you really sure people understand what your definition of Gold is? > > Mike > Crap!!! Well http://appdb.winehq.org/help/?topic=maintainer_ratings spells it out that gold is just that. An application can be rated as Gold if it installs and runs "out of the box". Some maintainers may have a distorted or over optimistic opinion of their application. So we need to clean that up and change these "False Gold" applications to "Silver" If anyone else knows of any other "False Gold" applications please let us know. appdb(a)winehq.org -- Tony Lambregts

2 1

LostWages: Status pages update #6 resend
by Tom Wickline 06 Feb '06

06 Feb '06

Hello, The first #6 is incorrect, please use this one Tom Changelog: move msacm.dll to Multimedia DLLs

1 0

Report this to wine-devel@winehq.org
by Daniel Rivera 06 Feb '06

06 Feb '06

Hello, I got this while compiling (for the first time) WINE on Xandros Linux. configure: WARNING: linux/capi.h: check for missing prerequisite headers? configure: WARNING: linux/capi.h: see the Autoconf documentation configure: WARNING: linux/capi.h: section "Present But Cannot Be Compiled" configure: WARNING: linux/capi.h: proceeding with the preprocessor's result configure: WARNING: linux/capi.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## Regards, Daniel

1 0

website bug
by Segin 06 Feb '06

06 Feb '06

I was trying to read WWN 303 but there appears to be a XML error on line 597. Mozilla verifies this by giving an error on the same line of the raw XML source. The actual Mozilla output is shown below: XML Parsing Error: mismatched tag. Expected: </br>. Location: http://winehq.org/wwn/wn20060122_303.xml Line Number 597, Column 62: doesn't seem to be able to get a hold of SEGFAULTs.</li></ul> ---------------------------------------------------^ appearantly </br> was expected where </li> was. Odd.

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel