- wine-devel - winehq.org

re: Another day, another compile error.
by Dan Kegel 10 Jun '05

10 Jun '05

Hans wrote: > dialog.c:516: internal compiler error: in gimple_add_tmp_var, at gimplify.c:532 > > I am running Fedora Core 4 Test3 with gcc-4.0.0-11 ... > > The preprocessed source is an 1MB file, so I will send it to > anyone that request it via direct email. You might try seeing whether gcc-4.0.1-rc1 still fails. See http://gcc.gnu.org/ml/gcc/2005-06/msg00270.html gcc's quite easy to build from sources. If rc1 still crashes on that source, please offer your preprocessed source to the folks at http://gcc.gnu.org/PR20103 who are fixing what might be a related problem. (Or better yet, verify you can repeat the problem with just the preprocessed source, then remove every part of the source you can while still causing the crash. Once you've whittled it down to under 1000 lines, the gcc developers will be very happy to see it.) Thanks! - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Wine does not build (preloader.c, line 863, a_ptr union)
by Ivan Gyurdiev 10 Jun '05

10 Jun '05

I hate bothering the -devel list with compile errors, but they don't seem to get fixed, so I start wondering if anyone else besides me is using gcc4 at all.. preloader.c: In function ‘is_in_preload_range’: preloader.c:863: error: ‘union <anonymous>’ has no member named ‘a_ptr’ preloader.c:864: error: ‘union <anonymous>’ has no member named ‘a_ptr’ make[1]: *** [preloader.o] Error 1 make[1]: Leaving directory `/home/phantom/src/wine/loader' make: *** [loader] Error 2 -- Ivan Gyurdiev <ivg2(a)cornell.edu> Cornell University

4 8

Wine on x86 OS/X
by Steven Edwards 10 Jun '05

10 Jun '05

Hi All, So what are everyone's thoughts on doing it? If there are any darwine people lurking I am interested in knowning if any of you are registered developers and will be getting a copy of the preview release and evaluation hardware. Thanks Steven __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

4 3

Wine 20050310 redraw problems (specifically with Paint Shop Pro 7)
by Jules Richardson 09 Jun '05

09 Jun '05

I remember posting about this quite a while ago but decided to revisit it, and it seems like it's still an issue in the 20050310 build of wine. Wine has real trouble with refreshing drawing surface windows in Paint Shop Pro 7: - the background in a new image window isn't cleared - tools that display tooltips (such as the colour selector control) leave tooltip debris all over the drawing surface when they're moved around. - drawing surface isn't refreshed if partially / totally obscured by other windows and then made visible again. Normal windows, dialogs etc. are working fine (and tooltips work fine too above normal controls) - it would seem that the drawing surfaces in PSP7 are handled differently (presumably for speed reasons) and wine is having some serious problems handling them. Any ideas for a workaround / patch, or is this bug known about and in the pipeline to be sorted out? I've exhausted various options in the Wine config file to do with display output; the problem seems to be in core code somewhere. I get the following error message at startup as follows: fixme:ole:CoRegisterMessageFilter stub followed by several: err:region:CombineRgn Invalid rgn=(nil) ... the latter used to happen an awful lot in earlier wine builds whilst the app was being used, but note that it's *not* happening with the 20050310 build whilst I try and use the app; only at startup time. (In other words, it's quite possibly not related to the redraw issues at all) Any ideas? PSP7 is so "almost there" that it'd be a shame if it wasn't 100%... Happy to provide further details if someone gives me instructions as to what to look at! cheers Jules

5 20

Re: Soliciting suggestions for AppDB
by Juan Lang 09 Jun '05

09 Jun '05

Hi Mitchell, > Does anybody have any features they'd like added to the AppDB? I do: I'd like to see it integrated with CXtest. I think it'd be really cool to be able to maintain a regression test for an app, so maintainers might be able to catch regressions more quickly and easily. A CXtest test isn't anything more than a shell script, so I don't think it would be that tough. --Juan __________________________________ Discover Yahoo! Stay in touch with email, IM, photo sharing and more. Check it out! http://discover.yahoo.com/stayintouch.html

2 2

notes651 error with viewing some mail with attachments
by Grant Williamson 09 Jun '05

09 Jun '05

Hi, seen this problem with current wine-cvs-20050609 When I try and view some internet mail, notes hangs with the folllowing error. err:heap:HEAP_ValidateInUseArena Heap 77c20000: in-use arena 77d1cb98 next block has PREV_FREE flag err:seh:setup_exception stack overflow 176 bytes in thread 000b eip 77ebde11 esp 777c0f50 stack 0x777c0000-0x778c0000 err:ntdll:RtlpWaitForCriticalSection section 0x77c2001c "?" wait timed out in thread 0010, blocked by 000b, retrying (60 sec) Anyone have any idea what is causing this, or what debug info would you need? Grant.

1 0

Re: config check for videodev.h
by Juan Lang 09 Jun '05

09 Jun '05

Hi Adrian, > Do I need to do anything special for a configure.ac patch - > does Alexandre re-run autoconf on commit, or do I need to do that > and include the patch to configure too? I've seen patches both ways. Try it and see :) __________________________________ Discover Yahoo! Use Yahoo! to plan a weekend, have fun online and more. Check it out! http://discover.yahoo.com/

1 0

Re: Another day, another compile error.
by Juan Lang 09 Jun '05

09 Jun '05

Hi Hans, > dialog.c:516: internal compiler error: in gimple_add_tmp_var, at > gimplify.c:532 > Please submit a full bug report, > with preprocessed source if appropriate. As the error implies, this is a bug in gcc, not in Wine. Please report to the gcc folks. --Juan __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

Another day, another compile error.
by Hans Kristian Rosbach 09 Jun '05

09 Jun '05

gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o dialog.o dialog.c dialog.c: In function ‘msi_dialog_scrolltext_control’: dialog.c:516: internal compiler error: in gimple_add_tmp_var, at gimplify.c:532 Please submit a full bug report, with preprocessed source if appropriate. See <URL:http://bugzilla.redhat.com/bugzilla> for instructions. Preprocessed source stored into /tmp/ccClgjYu.out file, please attach this to your bugreport. make[2]: *** [dialog.o] Error 1 make[2]: Leaving directory `/usr/src/wine-cvs/wine/dlls/msi' make[1]: *** [msi] Error 2 make[1]: Leaving directory `/usr/src/wine-cvs/wine/dlls' make: *** [dlls] Error 2 I am running Fedora Core 4 Test3 with libgcc-4.0.0-11 gcc-4.0.0-11 gcc-java-4.0.0-11 gcc-c++-4.0.0-11 Compiling and checking out current cvs like this: make clean && cd .. && cvs -z3 update -CdR wine && cd wine && ./configure --prefix=/usr/wine && make depend && make Still haven't been able to compile any recent wine snapshot or cvs checkouts under FC4. The preprocessed source is an 1MB file, so I will send it to anyone that request it via direct email. -HK

2 1

Re: WININET: declare some missing functions
by Jonathan Wilson 09 Jun '05

09 Jun '05

> +BOOLAPI FtpCommandA(HINTERNET, BOOL, DWORD, LPCSTR, DWORD_PTR, HINTERNET *); > +BOOLAPI FtpCommandW(HINTERNET, BOOL, DWORD, LPCWSTR, DWORD_PTR, HINTERNET *); Was it intentional that FtpCommand doesnt have a WINELIB_NAME_AW #define?

1 0

Google Summer of code - rc files translator proposition
by Piotr Caban 09 Jun '05

09 Jun '05

Hello. I'm interested in Google Summer of code. My cousin, Jacek, has wrote here about it. I'm going to write a translator to rc files. I was thinking about how should it look like. In my opinion it has to have its own rc parser (I can integrate the wrc parser). I think this tool should have: - Listed every string that has to be translated - Preview of dialogs so that user can change its parameters characteristic for the language version (like size of controls) - RC files upgrading options - Nice UI with some useful options that makes translating easier Because rc files have very different syntax than po files and we need some specific options, I don't think using tools like poEdit is good choice. It won't make translations comfortable for users. This tool has to be as easy as possible, so users that have no coding experience can use it. Translating cannot expect user to know anything about syntax of rc files. Thanks, Piotrek

1 0

msvcmaker has stopped working
by Saulius Krasuckas 09 Jun '05

09 Jun '05

Any quick ideas? $ tools/winapi/msvcmaker dlls/ntdll/ntdll.dsp (file 119 of 213)Can't open file './misc/ntdll_misc.dsp.tmp' at tools/winapi/util.pm line 114. $ mkdir misc $ tools/winapi/msvcmaker wine.dswUse of uninitialized value in pattern match (m//) at tools/winapi/msvcmaker line 1047. Use of uninitialized value in pattern match (m//) at tools/winapi/msvcmaker line 1047. Use of uninitialized value in pattern match (m//) at tools/winapi/msvcmaker line 1047. Use of uninitialized value in pattern match (m//) at tools/winapi/msvcmaker line 1057. Use of uninitialized value in pattern match (m//) at tools/winapi/msvcmaker line 1057. Use of uninitialized value in pattern match (m//) at tools/winapi/msvcmaker line 1057. Use of uninitialized value in concatenation (.) or string at tools/winapi/msvcmaker line 987. Use of uninitialized value in concatenation (.) or string at tools/winapi/msvcmaker line 994. $ rmdir misc rmdir: `misc': Directory not empty $ ll misc/ total 4 -rw-rw-r-- 1 s2 s2 2333 Jun 9 11:01 ntdll_misc.dsp $ rm -rf misc/ $ And yes, it works OK with "--no-wine": $ tools/winapi/msvcmaker --no-wine $ A bug?

2 1

Re: config check for videodev.h
by Juan Lang 09 Jun '05

09 Jun '05

Replying to you both.. Adrian wrote: > The following patch fixes it for me, but I have little knowledge of > autoconf, so I'm not sure if I've done the right thing? That looks correct to me.. Dustin wrote: > I don't think that would be appropriate, as systems that have > sys/time.h may not always have sys/types.h .. Actually, during the configure check, HAVE_SYS_TYPES will not be defined. He's really only checking for the presence of <linux/videodev.h>, so on systems that don't have <sys/types.h>, <linux/videodev.h> won't exist either (it's always present on Linux.) So if the configure check fails for either reason, HAVE_LINUX_VIDEODEV won't be defined--and that's what he wants. --Juan __________________________________ Discover Yahoo! Have fun online with music videos, cool games, IM and more. Check it out! http://discover.yahoo.com/online.html

2 1

Re: ntdll: Implement and test RtlAnsiCharToUnicodeChar
by Alexandre Julliard 09 Jun '05

09 Jun '05

James Hawkins <truiken(a)gmail.com> writes: > +/************************************************************************** > + * RtlAnsiCharToUnicodeChar (NTDLL.@) > + * > + * Converts an ansi character to a unicode character. > + * > + * PARAMS > + * ansi [I/O] Pointer to the ansi string. > + * > + * RETURNS > + * Success: Unicode representation of the first character in the ansi string. > + * Failure: NULL. > + * > + * NOTES > + * Upon successful completion, the char pointer ansi points to is > + * incremented by one. It should be incremented by two for multi-byte characters. -- Alexandre Julliard julliard(a)winehq.org

1 0

Problems in bitblt (in x11drv)
by David Albrecht 09 Jun '05

09 Jun '05

Sorry about the resend, but I used an old copy of the source inadvertently. I'm new to wine and relatively new to windows programming being mostly a unix hack. Just for yucks I thought I'd get a relatively simple app emu48 to work. Turns out emu48 is not so simple (multi-threaded, etc.). First task towards functionality is to get the boot up display to look right and a BitBlt didn't seem to be functioning correctly. Much investigation later it turns out that in the file dib.c: /* if the source bitmap is 8bpp or less, we're supposed to use the * DC's palette for color conversion (not the DIB color table) */ is NOT true at least not for my case where the DC containing the bitmap has one palette and the colormap for the bitmap is not the same. If I disable the hPalette tests as I did below and always use the DIB colormap it boots up with the correct display otherwise the color mapping doesn't match the DIB bits and I get garbage. if (dib.dsBm.bmBitsPixel <= 8) { HPALETTE hPalette = GetCurrentObject( physDevSrc->hdc, OBJ_PAL ); if (/*!hPalette || (hPalette == GetStockObject(DEFAULT_PALETTE))*/1) { /* HACK: no palette has been set in the source DC, * use the DIB colormap instead - this is necessary in some * cases since we need to do depth conversion in some places * where real Windows can just copy data straight over */ colorMap = physBitmap->colorMap; nColorMap = physBitmap->nColorMap; } else { colorMap = X11DRV_DIB_BuildColorMap( physDevSrc, (WORD)-1, dib.dsBm.bmBitsPixel, (BITMAPINFO*)&dib.dsBmih, &nColorMap ); if (colorMap) aColorMap = TRUE; } } Not knowing the full ramifications of this code I thought I'd pass this along so that someone more familiar with it can reassess it. The DC and bitmap are created thusly (nLcdDoubled == 2): #define B 0x00000000 #define W 0x00FFFFFF #define I 0xFFFFFFFF static struct { BITMAPINFOHEADER Lcd_bmih; DWORD dwColor[64]; } bmiLcd = { {0x28,0/*x*/,0/*y*/,1,8,BI_RGB,0,0,0,64,0}, { W,B,B,B,B,B,B,B,B,B,B,B,B,B,B,B, B,B,B,B,B,B,B,B,B,B,B,B,B,B,B,B, I,I,I,I,I,I,I,I,I,I,I,I,I,I,I,I, I,I,I,I,I,I,I,I,I,I,I,I,I,I,I,I } }; VOID CreateLcdBitmap(VOID) { // create LCD bitmap _ASSERT(nLcdDoubled == 1 || nLcdDoubled == 2 || nLcdDoubled == 4); bmiLcd.Lcd_bmih.biWidth = LCD1_ROW * nLcdDoubled; bmiLcd.Lcd_bmih.biHeight = -64 * nLcdDoubled; hLcdDC = CreateCompatibleDC(hWindowDC); _ASSERT(hLcdDC != NULL); hLcdBitmap = CreateDIBSection(hLcdDC, (BITMAPINFO*)&bmiLcd,DIB_RGB_COLORS, (LPVOID*)&pbyLcd, NULL, 0); _ASSERT(hLcdBitmap != NULL); hOldLcdBitmap = SelectObject(hLcdDC, hLcdBitmap); _ASSERT(hPalette != NULL); SelectPalette(hLcdDC, hPalette, FALSE); // set palette for LCD DC RealizePalette(hLcdDC); // realize palette UpdateContrast(Chipset.contrast); } In the new source update contrast doesn't do a SetDIBColorTable it just plays with the pattern used to write to the dib. static DWORD Pattern[16]; VOID UpdateContrast(BYTE byContrast) { DWORD c = byContrast; DWORD b = byContrast + 0x20; if (bmiLcd.dwColor[b] == 0xFFFFFFFF) b = 0; _ASSERT(nLcdDoubled == 1 || nLcdDoubled == 2 || nLcdDoubled == 4); if (nLcdDoubled == 1) { WORD i,j; for (i=0; i<16; ++i) { Pattern[i] = 0; for (j=8; j>0; j>>=1) { Pattern[i] = (Pattern[i] << 8) | ((i&j) ? c : b); } } return; } c = (c<<8) | c; b = (b<<8) | b; if (nLcdDoubled == 2) { Pattern[0] = (b<<16)|b; Pattern[1] = (b<<16)|c; Pattern[2] = (c<<16)|b; Pattern[3] = (c<<16)|c; return; } c = (c<<16) | c; b = (b<<16) | b; if (nLcdDoubled == 4) { Pattern[0] = b; Pattern[1] = c; } return; } The BitBlt: static BYTE Buf[36]; VOID UpdateMainDisplay(VOID) { UINT x, y, nLines; DWORD d = Chipset.start1; BYTE *p = pbyLcd; #if defined DEBUG_DISPLAY { TCHAR buffer[256]; wsprintf(buffer,_T("%.5lx: Update Main Display\n"),Chipset.pc); OutputDebugString(buffer); } #endif _ASSERT(nLcdDoubled == 1 || nLcdDoubled == 2 || nLcdDoubled == 4); if (!Chipset.dispon) { nLines = 64; ZeroMemory(pbyLcd, LCD1_ROW * nLcdDoubled * nLines * nLcdDoubled); } else { nLines = LINES(Chipset.lcounter); // main display lines if (nLcdDoubled == 4) { for (y = 0; y < nLines; ++y) { Npeek(Buf,d,36); for (x=0; x<36; x++) { *(((DWORD*)p)++)=Pattern[Buf[x]&1]; *(((DWORD*)p)++)=Pattern[(Buf[x]>>1) & 1]; *(((DWORD*)p)++)=Pattern[(Buf[x]>>2) & 1]; *(((DWORD*)p)++)=Pattern[(Buf[x]>>3) & 1]; } CopyMemory(p, p-LCD3_ROW, LCD3_ROW); p+=LCD3_ROW; CopyMemory(p, p-LCD3_ROW*2, LCD3_ROW*2); p+=LCD3_ROW*2; d+=Chipset.width; } } if (nLcdDoubled == 2) { for (y = 0; y < nLines; ++y) { Npeek(Buf,d,36); for (x=0; x<36; x++) { *(((DWORD*)p)++)=Pattern[Buf[x]&3]; *(((DWORD*)p)++)=Pattern[Buf[x]>>2]; } CopyMemory(p, p-LCD2_ROW, LCD2_ROW); p+=LCD2_ROW; d+=Chipset.width; } } if (nLcdDoubled == 1) { for (y = 0; y < nLines; ++y) { Npeek(Buf,d,36); for (x=0; x<36; x++) *(((DWORD*)p)++)=Pattern[Buf[x]]; d+=Chipset.width; } } } EnterCriticalSection(&csGDILock); // solving NT GDI problems { BitBlt(hWindowDC, nLcdX, nLcdY, 131*nLcdDoubled, nLines*nLcdDoubled, hLcdDC, Chipset.boffset*nLcdDoubled, 0, SRCCOPY); GdiFlush(); } LeaveCriticalSection(&csGDILock); return; } As emu48 still doesn't work I'll probably have more things I find in likely much different areas later. Dave

2 2

Re: Add a couple of CloseHandle calls
by Alexandre Julliard 09 Jun '05

09 Jun '05

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > (is this file supposed to have 2002 as a copyright year?) Yes, that's when I wrote it. It only took me 3 years to get around to making the code pass the tests ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Alpha Status ?
by Tom Wickline 09 Jun '05

09 Jun '05

Hello All, Can we change Wine from Alpha to Beta Status? Or is this scheduled for the 0.9 release ? Tom

1 0

Re: wcmd: Remove user32 dependencies
by Marcelo Duarte 09 Jun '05

09 Jun '05

James Hawkins escreveu: >Hi, > >This patch is in responese to Bug #1982 'Can't SSH into a computer and >use "wine cmd" or wineconsole' > >http://bugs.winehq.org/show_bug.cgi?id=1982 > >The problem as identified by Marcus is that wcmd is importing user32 >which brings in the x11 driver causing the ssh'ed wcmd to fail: > >(~)> wine cmd >x11drv: Can't open display: > > The command "wine wcmd" or "wcmd" produces to me the same results and I do not see the errors described in bug1892. Only the keyboard input is bad, but the message above is not displayed to me. The command "wineconsole wcmd" functions. My terminal is 80x50 and it display on top 40x50. >I couldn't figure out any other way to get rid of LoadString. It's >pretty essential since we're loading multilingual help strings from >resource files. > >Changelog >* Dynamically call LoadString from user32. >* Remove all direct user32 dependencies. >* Don't import user32. > > > I dont think that this is necessary. This is not the cause of bug 1892. Maybe export DISPLAY

1 0

Re: Remove user32 dependencies
by Dmitry Timoshkov 09 Jun '05

09 Jun '05

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * Dynamically call LoadString from user32. > * Remove all direct user32 dependencies. > * Don't import user32. > --- programs/wcmd/Makefile.in 9 Mar 2004 04:54:07 -0000 1.22 > +++ programs/wcmd/Makefile.in 9 Jun 2005 00:20:31 -0000 > @@ -4,7 +4,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = wcmd.exe > APPMODE = -mconsole > -IMPORTS = shell32 user32 kernel32 > +IMPORTS = shell32 kernel32 wcmd still indirectly depends on user32 due to the fact that shell32 imports user32, and that's unavoidable. -- Dmitry.

1 0

Re: [msvcrt] Implement %I types for printf
by Alexandre Julliard 09 Jun '05

09 Jun '05

Jesse Allen <the3dfxdude(a)gmail.com> writes: > @@ -191,11 +191,14 @@ > } buf; > } pf_output; > > +#define INTEGERSIZE_LONG 1 > +#define INTEGERSIZE_LONGLONG 2 > + > typedef struct pf_flags_t > { > char Sign, LeftAlign, Alternate, PadZero; > char FieldLength, Precision; > - char IntegerLength, IntegerDouble; > + char IntegerLength, IntegerDouble, IntegerSize; The IntegerDouble field was supposed to be used for that already, no need to add another one. > @@ -384,6 +387,16 @@ > sprintf(p, ".%d", flags->Precision); > p += strlen(p); > } > + if( flags->IntegerLength == 'I' ) > + { > + sprintf(p, "l"); > + p++; > + } > + if( flags->IntegerSize == INTEGERSIZE_LONGLONG ) > + { > + sprintf(p, "l"); > + p++; > + } This assumes that the system printf supports %ll formats, that's not portable. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: MSI: action.c more RegisterProduct work
by Mike McCormack 09 Jun '05

09 Jun '05

Aric Stewart wrote: > @@ -6033,6 +6042,21 @@ > size = strlenW(buffer)*sizeof(WCHAR); > RegSetValueExW(hukey,szProductName,0,REG_SZ, (LPSTR)buffer,size); > HeapFree(GetProcessHeap(),0,buffer); > + > + buffer = load_dynamic_property(package,szProductLanguage,NULL); > + size = sizeof(DWORD); > + langid = atoiW(buffer); > + RegSetValueExW(hukey,szLanguage,0,REG_DWORD, (LPSTR)&langid,size); > + > + buffer = load_dynamic_property(package,szARPProductIcon,NULL); > + if (buffer) > + { > + LPWSTR path; > + build_icon_path(package,buffer,&path); > + size = strlenW(path) * sizeof(WCHAR); > + RegSetValueExW(hukey,szProductIcon,0,REG_SZ, (LPSTR)path,size); > + } > + > FIXME("Need to write more keys to the user registry\n"); > > hDb= alloc_msihandle( &package->db->hdr ); Since load_dynamic_property allocates memory, you leak "buffer" here twice... Mike

1 0

Re: Combine WINE_WAVEOUT and WINE_WAVEIN into single structure
by Robert Reif 08 Jun '05

08 Jun '05

Jeremy White wrote: > This combines the WINE_WAVEOUT and WINE_WAVEIN structures into > a single WINE_WAVECOMMON structure, as most of the fields were > duplicated anyways. This patch should not change any > functionality, but will allow for some elimination > of duplicate code in an upcoming patch. > > (Credit Alexandre for suggestion the combination into a single > structure). > >+} WINE_WAVECOMMON; > > Could you call it WINE_WAVEDEV or WINE_WAVEDEVICE?

1 0

dlls/shell32/shv_item_cmenu.c regression
by Gerald Pfeifer 08 Jun '05

08 Jun '05

After last night's updates, I'm no seeing the following warning in dlls/shell32/shv_item_cmenu.c shv_item_cmenu.c:203: warning: assignment discards qualifiers from pointer target type The last two changes to this file were revision 1.32 date: 2005/06/07 20:30:30; author: julliard; state: Exp; lines: +1 -1 Warning fixes for -Wmissing-declarations and -Wwrite-strings. ---------------------------- revision 1.31 date: 2005/06/06 19:50:36; author: julliard; state: Exp; lines: +3 -3 Make remaining OLE interface vtables const. and I'm pretty sure it's the latter (revision 1.32) which causes this problem. Would you mind fixing this? Thanks, Gerald

1 0

Re: Asynchronous Named Pipes
by Uwe Bonnes 08 Jun '05

08 Jun '05

>>>>> "Robert" == Robert Shearman <rob(a)codeweavers.com> writes: Robert> Hi, This patch depends on "Small RPC Bug Fixes" for the ole32 Robert> tests to pass. I hope people don't think of me as a PITA, but here again my RFT (Request for Tests): Rob, can you please add a testcase in dlls/kernel/tests/pipe.c showing the usage and the functionality of your patch? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Tests and window versions
by Paul Vriens 08 Jun '05

08 Jun '05

Hi, I've just finished another test for NtQuerySystemInformatio. In this test I test the structure SYSTEM_PROCESS_INFORMATION. The structure is however different for NT4. If I add an osversion (> 4) check I can check the structure for W2K/WinXP and W2K3 and skip this structure-check for NT4 (for now). Wine however defaults to Win98 unless I put in the config: [AppDefaults\\ntdll_test.exe.so\\Version] "Windows" = "winxp" Is there another approach or will this test be accepted as is ? Cheers, Paul.

2 1

Re: [PATCH] FCI work for cabinet.dll [cabinet-fci-patch-02b.diff]
by Alexandre Julliard 08 Jun '05

08 Jun '05

"Gerold J. Wucherpfennig" <gjwucherpfennig(a)gmx.net> writes: > --- dlls/cabinet/cabinet.h 14 May 2005 11:06:10 -0000 1.12 > +++ dlls/cabinet/cabinet.h 8 Jun 2005 14:05:42 -0000 > @@ -89,11 +89,17 @@ typedef UINT32 cab_off_t; > #define cffoldCOMPTYPE_QUANTUM (0x0002) > #define cffoldCOMPTYPE_LZX (0x0003) > #define cfheadPREV_CABINET (0x0001) > +#define cfhdrPREV_CABINET (0x0001) /* original name defined by MS */ > #define cfheadNEXT_CABINET (0x0002) > +#define cfhdrNEXT_CABINET (0x0002) /* original name defined by MS */ > #define cfheadRESERVE_PRESENT (0x0004) > +#define cfhdrRESERVE_PRESENT (0x0004) /* original name defined by MS */ > #define cffileCONTINUED_FROM_PREV (0xFFFD) > +#define ifoldCONTINUED_FROM_PREV (0xFFFD) /* original name defined by MS */ > #define cffileCONTINUED_TO_NEXT (0xFFFE) > +#define ifoldCONTINUED_TO_NEXT (0xFFFE) /* original name defined by MS */ > #define cffileCONTINUED_PREV_AND_NEXT (0xFFFF) > +#define ifoldCONTINUED_PREV_AND_NEXT (0xFFFF) /* original name defined by MS */ If these are the names defined by MS you should get rid of the others, there's no sense in having two different names for the same thing. > --- include/fci.h 28 Aug 2003 21:43:35 -0000 1.3 > +++ include/fci.h 8 Jun 2005 14:05:54 -0000 > @@ -112,15 +113,15 @@ typedef unsigned short TCOMP; > */ > > typedef enum { > - FCIERR_NONE, > - FCIERR_OPEN_SRC, > - FCIERR_READ_SRC, > - FCIERR_ALLOC_FAIL, > - FCIERR_TEMP_FILE, > - FCIERR_BAD_COMPR_TYPE, > - FCIERR_CAB_FILE, > - FCIERR_USER_ABORT, > - FCIERR_MCI_FAIL, > + FCIERROR_NONE, > + FCIERROR_OPEN_SRC, > + FCIERROR_READ_SRC, > + FCIERROR_ALLOC_FAIL, > + FCIERROR_TEMP_FILE, > + FCIERROR_BAD_COMPR_TYPE, > + FCIERROR_CAB_FILE, > + FCIERROR_USER_ABORT, > + FCIERROR_MCI_FAIL, The SDK header uses FCIERR, not FCIERROR. Why are you changing it? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Restructure WINE_WAVEOUT/WINE_WAVEIN
by Alexandre Julliard 08 Jun '05

08 Jun '05

Jeremy White <jwhite(a)codeweavers.com> writes: > @@ -228,12 +205,20 @@ > > /* DirectSound stuff */ > DSDRIVERDESC ds_desc; > - DSCDRIVERCAPS ds_caps; > -} WINE_WAVEIN; > + DSDRIVERCAPS ds_caps; > + > + union { > + WINE_WAVEOUT out; > + WINE_WAVEIN in; > + }; You need to give a name to the union, anonymous unions are not portable. Though considering how few fields remain in the in/out structure you might just as well merge them into the common structure and use a single structure for everything. -- Alexandre Julliard julliard(a)winehq.org

1 0

Known regressions affectiong IE++ remain unfixed?
by René Rebe 08 Jun '05

08 Jun '05

Hi all, I played a bit more with wine the last days and stumbled over this sidenet site which also has some FAQ points: http://sidenet.ddo.jp/winetips/config.html I experienced the same "IE installer crashing" with wine >= 200412xx - I wonder why such a long known regression takes so long to get fixed again. Currently the common way seems to be to install an over half a year old wine just to update it after the IE installation ... Aside from that, keep up your good work! Yours, -- René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany) http://www.exactcode.de | http://www.t2-project.org +49 (0)30 255 897 45

1 0

Re: sysparams: Read the entire logfont from the registry if it's present
by Rein Klazes 08 Jun '05

08 Jun '05

On Wed, 8 Jun 2005 12:32:27 +0100, you wrote: > > /*********************************************************************** > + * reg_get_logfont > + * > + * Tries to retrieve logfont info from the specified key and value > + */ > +static BOOL reg_get_logfont(LPCWSTR key, LPCWSTR value, LOGFONTW *lf) > +{ My guess is that this is not going to work for me. In my user.reg: | "MenuFont"=hex:0c,00,00,00,00,00,00,00,90,01,00,00,00,00,00,00,00,00,41,72,69,\ | 61,6c,00,40,65,9a,c2,ac,1c,00,01,00,00,00,00,01,00,00,00,6c,f8,56,00,01,00,\ | 00,00,8a,2d IOW it may be stored as a LOGFONT16 (as Win9x does) or a LOGFONTW and maybe a LOGFONTA somewhere as well. Rein..

1 0

Work being done at the File Creation Interface of Cabinet.DLL
by Gerold J. Wucherpfennig 08 Jun '05

08 Jun '05

I just want to let you know that I'm working at the FCI functions of CABINET.DLL. I had a look at this a few years ago, but gave up soon. Two weeks ago I made a new attempt and next weekend I should be able I post a patch which implements all FCI functions and will work with spanning cabinets. Real file compression will not be implemented at that point of time as I still have to write missing parts and complete error handling first. This work took me longer than expected so let's see if I can adhere to my schedule. Regards, Gerold

2 2

config check for videodev.h
by Adrian Harvey 08 Jun '05

08 Jun '05

I have been trying to test out the new webcam support with MSN, and have been having some trouble getting it to work. I have traced my problems back to an error in configure failing to compile the test for videodev.h, and therefore thinking that I have no v4l support. /usr/include/linux/videodev.h:55: error: syntax error before "ulong" /usr/include/linux/videodev.h:71: error: syntax error before '}' token The following patch fixes it for me, but I have little knowledge of autoconf, so I'm not sure if I've done the right thing? sys/time.h includes bits/types.h, and bits/types.h says it should not be included directly - and to use sys/types.h --- configure.ac.080605 2005-06-08 21:56:04.000000000 +1200 +++ configure.ac 2005-06-08 21:56:42.000000000 +1200 @@ -1226,6 +1226,7 @@ AC_CHECK_HEADERS(linux/videodev.h,,, [#ifdef HAVE_SYS_TIME_H #include <sys/time.h> +#include <sys/types.h> #endif #ifdef HAVE_ASM_TYPES_H #include <asm/types.h> The webcam support is truly amazing BTW - I never expected something like that to work so well in wine! Cheers, Adrian

2 1

wine-systray problem
by Pashok 08 Jun '05

08 Jun '05

Hi all! i have trouble with wine-systray. I run windows program called "FCat". Wine-systray work correctly only under xfce-4.2.2. Under openbox-3.2 systray looks as small window on screen. Not in systray. Why? -- Sorry, im still using windows...

4 4

RE: setupapi - Danish and Swedish Translations
by Casper Hornstrup 08 Jun '05

08 Jun '05

+COPYFILEDLGORD DIALOG LOADONCALL MOVEABLE DISCARDABLE 20, 20, 208, 105 +STYLE DS_MODALFRAME | DS_SETFONT | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "Overførere Filer..." +FONT 8, "MS Shell Dlg" +BEGIN Should be: +CAPTION "Overfører Filer..." > -----Original Message----- > From: wine-patches-admin(a)winehq.org [mailto:wine-patches-admin@winehq.org] On Behalf Of Steven > Edwards > Sent: 8. juni 2005 00:33 > To: wine-patches(a)winehq.org > Subject: setupapi - Danish and Swedish Translations > > Changelog: > Danish translation by Thomas Larsen <sikker2004(a)yahoo.com> > Swdish translations by Anders Bergh <anders1(a)gmail.com> proofread by Andreas Bjerkeholt > <harteex(a)gmail.com> > > > > __________________________________ > Discover Yahoo! > Stay in touch with email, IM, photo sharing and more. Check it out! > http://discover.yahoo.com/stayintouch.html

1 0

Turning off the exception dialog
by Robert Lunnon 08 Jun '05

08 Jun '05

The latest build of wine I am getting a dialog telling me about an exception rather than wine just dumping core. gdb can't catch the point of the exception allowing me to debug the problem. From memory there is a way to turn off this "feature" no ? Bob

1 0

[Resent]Request: Detect a broken pipe
by Uwe Bonnes 08 Jun '05

08 Jun '05

Hallo, Alexandre just added my testcase to wine-patches, fingerpointing at a todo_wine() with wine not seeing a broken pipe. This still keeps Altera Quartus from starting up. I tried to fix for myself for some time , but to no avail. Any help/patches welcome. Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Problems in bitblt (in x11drv)
by David Albrecht 08 Jun '05

08 Jun '05

I'm new to wine and relatively new to windows programming being mostly a unix hack. Just for yucks I thought I'd get a relatively simple app emu48 to work. Turns out emu48 is not so simple (multi-threaded, etc.). First task towards functionality is to get the boot up display to look right and a BitBlt didn't seem to be functioning correctly. Much investigation later it turns out that in the file dib.c: /* if the source bitmap is 8bpp or less, we're supposed to use the * DC's palette for color conversion (not the DIB color table) */ is NOT true at least not for my case where the DC containing the bitmap has one palette and the colormap for the bitmap is not the same. If I disable the hPalette tests as I did below and always use the DIB colormap it boots up with the correct display otherwise the color mapping doesn't match the DIB bits and I get garbage. if (dib.dsBm.bmBitsPixel <= 8) { HPALETTE hPalette = GetCurrentObject( physDevSrc->hdc, OBJ_PAL ); if (/*!hPalette || (hPalette == GetStockObject(DEFAULT_PALETTE))*/1) { /* HACK: no palette has been set in the source DC, * use the DIB colormap instead - this is necessary in some * cases since we need to do depth conversion in some places * where real Windows can just copy data straight over */ colorMap = physBitmap->colorMap; nColorMap = physBitmap->nColorMap; } else { colorMap = X11DRV_DIB_BuildColorMap( physDevSrc, (WORD)-1, dib.dsBm.bmBitsPixel, (BITMAPINFO*)&dib.dsBmih, &nColorMap ); if (colorMap) aColorMap = TRUE; } } Not knowing the full ramifications of this code I thought I'd pass this along so that someone more familiar with it can reassess it. The DC and bitmap are created thusly: #if defined GRAYSCALE #define NOCOLORS 8 #else #define NOCOLORS 2 #endif static struct { BITMAPINFOHEADER Lcd_bmih; RGBQUAD bmiColors[NOCOLORS]; } bmiLcd = { {0x28,0/*x*/,0/*y*/,1,8,BI_RGB,0,0,0,NOCOLORS,0} }; VOID CreateLcdBitmap(VOID) { // create LCD bitmap _ASSERT(nLcdDoubled == 1 || nLcdDoubled == 2 || nLcdDoubled == 4); bmiLcd.Lcd_bmih.biWidth = LCD_ROW * nLcdDoubled; bmiLcd.Lcd_bmih.biHeight = -64 * nLcdDoubled; _ASSERT(hLcdDC == NULL); hLcdDC = CreateCompatibleDC(hWindowDC); _ASSERT(hLcdDC != NULL); hLcdBitmap = CreateDIBSection(hLcdDC, (BITMAPINFO*)&bmiLcd,DIB_RGB_COLORS, (LPVOID*)&pbyLcd, NULL, 0); _ASSERT(hLcdBitmap != NULL); hOldLcdBitmap = SelectObject(hLcdDC, hLcdBitmap); _ASSERT(hPalette != NULL); SelectPalette(hLcdDC, hPalette, FALSE); // set palette for LCD DC RealizePalette(hLcdDC); // realize palette BuildPattern(); // build Nibble -> DIB mask pattern UpdateContrast(Chipset.contrast); return; } Note that update contrast doe a SetDIBColorTable: VOID UpdateContrast(BYTE byContrast) { #if defined GRAYSCALE INT i; RGBQUAD c = *(RGBQUAD*)&dwKMLColor[byContrast]; // pixel on color RGBQUAD b = *(RGBQUAD*)&dwKMLColor[byContrast+32]; // pixel off color if ((Chipset.IORam[BITOFFSET] & DON) == 0 || I == *(DWORD*)&b) b = *(RGBQUAD*)&dwKMLColor[0]; // fill color palette of bitmap for (i = 0; i < ARRAYSIZEOF(bmiLcd.bmiColors); ++i) { const INT nCAdj[] = { 0, 1, 1, 2, 1, 2, 2, 3 }; _ASSERT(i < ARRAYSIZEOF(bmiLcd.bmiColors)); _ASSERT(i < ARRAYSIZEOF(nCAdj)); bmiLcd.bmiColors[i] = b; bmiLcd.bmiColors[i].rgbRed += (((INT) c.rgbRed - (INT) b.rgbRed) * nCAdj[i] / 3); bmiLcd.bmiColors[i].rgbGreen += (((INT) c.rgbGreen - (INT) b.rgbGreen) * nCAdj[i] / 3); bmiLcd.bmiColors[i].rgbBlue += (((INT) c.rgbBlue - (INT) b.rgbBlue) * nCAdj[i] / 3); } #else bmiLcd.bmiColors[1] = *(RGBQUAD*)&dwKMLColor[byContrast]; // pixel on color bmiLcd.bmiColors[0] = *(RGBQUAD*)&dwKMLColor[byContrast+32]; // pixel off color if ((Chipset.IORam[BITOFFSET] & DON) == 0 || I == *(DWORD*)&bmiLcd.bmiColors[0]) bmiLcd.bmiColors[0] = *(RGBQUAD*)&dwKMLColor[0]; #endif // update palette information _ASSERT(hLcdDC); SetDIBColorTable(hLcdDC,0,ARRAYSIZEOF(bmiLcd.bmiColors),bmiLcd.bmiColors); return; } The BitBlt: BitBlt(hWindowDC, nLcdX, nLcdY, 131*nLcdDoubled, nLines*nLcdDoubled, hLcdDC, Chipset.boffset*nLcdDoubled, 0, SRCCOPY); As emu48 still doesn't work I'll probably have more things I find in likely much different areas later. Dave

1 0

CPU Emulation
by Robert Lunnon 07 Jun '05

07 Jun '05

Has any consideration been given to hooking a CPU emulation into wine to allow non x86 derivative CPUs execute native Windows binaries. For example it aught to be possible to hook qmu into the wine loader. Would this make a good Google Summer of Code project ? Wine could become Wine Is Now an Emulator Bob

4 3

Re: Fix our waveout tests by adjusting for underrun conditions
by Duane Clark 07 Jun '05

07 Jun '05

Jeremy White wrote: > On my VIA8237 sound card at work, the Wave tests for winmm > have been failing for me with Alsa. > > > Now, this patch Works For Me (TM), on both of my systems, > but turning off the xrun mode seems like a big step to me; > I'd appreciate testing by any concerned parties. This seems to cause severe problems for VirtualDub: http://virtualdub.sourceforge.net/ Here is the movie I am using: http://ftp.pub.cri74.org/pub/win9x/video/SampleMovie/ If you open and run the movie, it plays ok, including sound. But try clicking stop in the middle of playing. Or when the movie gets to the end, everything is stuck; it appears the program cannot tell that the movie has ended. This is on current CVS, with winealsa (I think, at least that is what is set in my config file), and RH9.

1 0

Re: wine-systray problem
by Andreas Mohr 07 Jun '05

07 Jun '05

[Darn, forgot group reply] Hi, On Tue, Jun 07, 2005 at 10:15:02PM +0600, Pashok wrote: > Andreas Mohr wrote: > > > >Maybe openbox-3.2 doesn't (fully?) support systray desktop guidelines > >(see freedesktop.org?) and thus Wine falls back to using a popup window > >instead? > > Maybe, but Openbox "was written first to comply with standards and to > work properly".... Hmm, then it should have worked if that fully was the case. > So i can't change this? I must use xfce??? I like openbox.... :( You are using Linux. You can change *EVERYTHING*. > -- > Sorry, im still using windows... Oh wait, you aren't... ;) If systray integration doesn't work despite openbox advertising standards compliance, then use some relevant Wine debug channel (it's probably dlls/shell32/systray.c, so it's WINEDEBUG=+shell) to find out what it tries to do and what doesn't work there. Andreas Mohr

1 0

List settings
by Robert Lunnon 07 Jun '05

07 Jun '05

It appears the mailing list isn't quite right. When I reply-all I seem to get the list twice, once as recipient and once as CC, can this be fixed ? This seems to be affecting more than just me. Bob

5 6

Re: ViaVoice (98) in Wine
by René Rebe 07 Jun '05

07 Jun '05

Hi, On Tuesday 07 June 2005 02:37, you wrote: > >No problem - a log with my normal setup, and one without the module for > > the 10 channel card loaded attached (I wanted to see for myself if that > > makes a significant difference in the behaviour of Wine). > > > >Yours, > > OSS thinks your sound card doesn't support volume control on the input. > Not much you can do about that. I assume this is OSS on ALSA? Then it's > an ALSA OSS emulation issue (assuming the card really does support it). > The peak meter issue is not a problem because most drivers don't support > it. > > Does the software really refuse to work because of no record volume > control? That shouldn't be a fatal error. Maybe - since ViaVoice is quite agressive to tweak the microphone gain ... Have you seen the invalid handle in the log? trace:msacm:acmDriverDetailsA ((nil), 0x504840, 00000000) trace:msacm:acmDriverDetailsW ((nil), 0x77a7eebc, 00000000) trace:msacm:acmDriverOpen (0x77a7e3e4, (nil), 00000000) warn:msacm:acmDriverOpen invalid handle trace:msacm:acmDriverOpen (0x504c94, (nil), 00000000) warn:msacm:acmDriverOpen invalid handle Maybe via voice fails due to that ... at least it matches what I found in the speech engines log (oh - I mistyped the wine list address of the mail containing this information, yesterday - resent it now): AudMME: Set Audio Input --------------------------------- [Jun 06 12:29:1 2005] Using record device # 0 which is a Analog Devices AD1980 AUDMME will use device # 0 for recording AUDMME will use device # 0 for playback PCM Device WAV Audio Adapter Default Record Device WAV Audio Default Playback Device WAV Audio Adapter acmDriverDetails failed, rc = 5 acmDriverOpen failed, rc = 5 acmDriverDetails failed, rc = 5 acmDriverOpen failed, rc = 5 Alphabet/Language/Codepage: R Gr_GR 850 a returncode of 5 seems to be: #define MMSYSERR_INVALHANDLE (MMSYSERR_BASE + 5) Yours, -- René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany) http://www.exactcode.de | http://www.t2-project.org +49 (0)30 255 897 45

2 1

ViaVoice (98) in Wine
by René Rebe 07 Jun '05

07 Jun '05

Hi all, over the weekend I tried to get ViaVoice (98) running in Wine (20050524). The installation goes smooth - even the embedded videos how to handle the microsfone, etc. are displayed ,-) However after the installation some "audio setup" tool is run to adjust the mixer level and maybe more like capture channel. This tools does just print an error that it can not find "mixer elements / devices" (translation from the german text I had on screen). I tried a few install and wine config variations, including switching from OSS to ALSA - however without success. I then tried to copy my trained profile from a real Windows box in order to skip this audio setup stuff. However the real applications then also complain about no mixer found. Capturing from my mic with some "proof of concept" and tiny audio recorder as shipped with ViaVoice (snwave.exe IIRC) did work. Injecting all the windows partition content into the wine folder did also not help. Are there some holes in some kind of mixer interface implementation? Is there some kind of tracing I can enable in order to take a look what kind of call did fail? Any help appreciated. Yours, -- René Rebe - Rubensstr. 64 - 12157 Berlin (Europe / Germany) http://www.exactcode.de | http://www.t2-project.org +49 (0)30 255 897 45

4 8

SetTextJustification() fix
by Keith Dunwoody 07 Jun '05

07 Jun '05

Hi, A little while ago I sent a fix for bug #50 (PrgWin95: Text justification needs beefing up), in which SetTextJustification() wasn't spacing text lines out properly. I was wondering why my patch was rejected. Thanks, -- Keith __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 3

Re: Resubmit SetWindowTextA() patch
by Mike McCormack 07 Jun '05

07 Jun '05

Jason Campbell wrote: > +/* > FIXME( "cannot set text %s of other process window %p\n", > debugstr_a(lpString), hwnd ); > SetLastError( ERROR_ACCESS_DENIED ); > return FALSE; > +*/ > + FIXME( "not allowed by MSDN but some apps programmed this way" ); > } > return (BOOL)SendMessageA( hwnd, WM_SETTEXT, 0, (LPARAM)lpString ); > } Hi Jason, I think the fixme is not Wine enforcing a limitation imposed by MSDN, but preventing a problem from occuring because it's not supported properly by Wine, so though the above may work for a few applications, it doesn't seem like a solution that will work for everything. To do this the "right way" you'd need to write a test case to show what happens on Windows when somebody tries to set the title of another window. If this now works, you shouldn't just comment out the code in the if() statement, but instead remove the if() statement and FIXME all together. I suspect that it won't work correctly if the window has a visible caption bar. Mike

2 2

Summer of Code applications so far
by Dan Kegel 06 Jun '05

06 Jun '05

Google hasn't sent out any applications to the mentoring organizations (e.g. Wine) yet, but they did just release a breakdown of the number of proposals recieved for each project. The count for Wine is at 77! No idea how many of those will make it through the selection process, but at least a few ought to be good. Here's the full breakdown from http://groups-beta.google.com/group/summer-discuss/msg/fd9e7ed643a3514d : 424 google 263 asf 213 gnome 209 gaim 204 other 156 psf 156 mono 126 ubuntu 90 freebsd 84 nmap 78 gallery 77 wine <------ 58 mambo 53 kde 49 svn 40 tpl 39 internet2 37 oo 35 fedoracore 33 lj 32 drupal 31 mozdev 29 handhelds 26 blender 25 winlibre 23 netbsd 23 codehaus 21 samba 21 jxta 18 xwiki 16 inkscape 15 plg 15 horde 14 semedia 13 jabber 12 asterisk 10 lispnyc 7 monotone 5 psu 5 oscar 5 ohiolink 5 bricolage TOTAL: 2795 -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [QUARTZ] More fixes
by Robert Shearman 06 Jun '05

06 Jun '05

Christian Costa wrote: >Index: dlls/quartz/parser.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/parser.c,v >retrieving revision 1.16 >diff -u -r1.16 parser.c >--- dlls/quartz/parser.c 6 Jun 2005 19:50:36 -0000 1.16 >+++ dlls/quartz/parser.c 6 Jun 2005 20:48:12 -0000 >@@ -221,6 +221,8 @@ > > TRACE("()\n"); > >+ if (This->state == State_Stopped) return S_OK; >+ > EnterCriticalSection(&This->csFilter); > { > hr = PullPin_StopProcessing(This->pInputPin); >@@ -239,6 +241,8 @@ > > TRACE("()\n"); > >+ if (This->state == State_Paused) return S_OK; >+ > EnterCriticalSection(&This->csFilter); > { > bInit = (This->state == State_Stopped); > > > These changes aren't thread safe. You should do the comparisons inside of the critical section. -- Rob Shearman

1 0

[RESEND] [d3d] Light management API test cases
by Antoine Chavasse 06 Jun '05

06 Jun '05

ChangeLog: - Test cases for the direct3d7 light api. Index: dlls/ddraw/tests/.cvsignore =================================================================== RCS file: /home/wine/wine/dlls/ddraw/tests/.cvsignore,v retrieving revision 1.3 diff -u -p -r1.3 .cvsignore --- dlls/ddraw/tests/.cvsignore 30 May 2005 11:11:34 -0000 1.3 +++ dlls/ddraw/tests/.cvsignore 6 Jun 2005 18:13:18 -0000 @@ -1,4 +1,5 @@ Makefile ddrawmodes.ok dsurface.ok +d3d7light.ok testlist.c Index: dlls/ddraw/tests/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/ddraw/tests/Makefile.in,v retrieving revision 1.4 diff -u -p -r1.4 Makefile.in --- dlls/ddraw/tests/Makefile.in 30 May 2005 11:11:34 -0000 1.4 +++ dlls/ddraw/tests/Makefile.in 6 Jun 2005 18:13:18 -0000 @@ -3,11 +3,12 @@ TOPOBJDIR = ../../.. SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = ddraw.dll -IMPORTS = ddraw user32 gdi32 kernel32 +IMPORTS = ddraw dxguid user32 gdi32 kernel32 CTESTS = \ ddrawmodes.c \ - dsurface.c + dsurface.c \ + d3d7light.c @MAKE_TEST_RULES@ --- /dev/null 1970-01-01 01:00:00.000000000 +0100 +++ dlls/ddraw/tests/d3d7light.c 2005-06-06 20:10:12.998103616 +0200 @@ -0,0 +1,185 @@ +/* + * Some unit tests for direct3d7 light functions + * + * Copyright (C) 2005 Antoine Chavasse (a.chavasse(a)gmail.com) + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <assert.h> +#include "wine/test.h" +#include "ddraw.h" +#include "d3d.h" + +static LPDIRECTDRAW7 lpDD = NULL; +static LPDIRECT3D7 lpD3D = NULL; +static LPDIRECTDRAWSURFACE7 lpDDS = NULL; +static LPDIRECT3DDEVICE7 lpD3DDevice = NULL; + +static void CreateDirect3D() +{ + HRESULT rc; + DDSURFACEDESC2 ddsd; + + rc = DirectDrawCreateEx(NULL, (void**)&lpDD, + &IID_IDirectDraw7, NULL); + ok(rc==DD_OK, "DirectDrawCreateEx returned: %lx\n", rc); + + rc = IDirectDraw_SetCooperativeLevel(lpDD, NULL, DDSCL_NORMAL); + ok(rc==DD_OK, "SetCooperativeLevel returned: %lx\n", rc); + + rc = IDirectDraw7_QueryInterface(lpDD, &IID_IDirect3D7, (void**) &lpD3D); + ok(rc==DD_OK, "QueryInterface returned: %lx\n", rc); + + memset(&ddsd, 0, sizeof(ddsd)); + ddsd.dwSize = sizeof(ddsd); + ddsd.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT; + ddsd.ddsCaps.dwCaps = DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE; + ddsd.dwWidth = 256; + ddsd.dwHeight = 256; + rc = IDirectDraw7_CreateSurface(lpDD, &ddsd, &lpDDS, NULL); + ok(rc==DD_OK, "CreateSurface returned: %lx\n", rc); + + rc = IDirect3D7_CreateDevice(lpD3D, &IID_IDirect3DTnLHalDevice, lpDDS, + &lpD3DDevice); + ok(rc==D3D_OK, "CreateDevice returned: %lx\n", rc); +} + +static void ReleaseDirect3D() +{ + if (lpD3DDevice != NULL) + { + IDirect3DDevice7_Release(lpD3DDevice); + lpD3DDevice = NULL; + } + + if (lpDDS != NULL) + { + IDirectDrawSurface_Release(lpDDS); + lpDDS = NULL; + } + + if (lpD3D != NULL) + { + IDirect3D7_Release(lpD3D); + lpD3D = NULL; + } + + if (lpDD != NULL) + { + IDirectDraw_Release(lpDD); + lpDD = NULL; + } +} + +static void LightTest() +{ + HRESULT rc; + D3DLIGHT7 light; + D3DLIGHT7 defaultlight; + BOOL bEnabled = FALSE; + + + /* Set a few lights with funky indices. */ + memset(&light, 0, sizeof(light)); + light.dltType = D3DLIGHT_DIRECTIONAL; + light.dcvDiffuse.r = 0.5f; + light.dcvDiffuse.g = 0.6f; + light.dcvDiffuse.b = 0.7f; + light.dvDirection.y = 1.f; + + rc = IDirect3DDevice7_SetLight(lpD3DDevice, 5, &light); + ok(rc==D3D_OK, "SetLight returned: %lx\n", rc); + rc = IDirect3DDevice7_SetLight(lpD3DDevice, 10, &light); + ok(rc==D3D_OK, "SetLight returned: %lx\n", rc); + rc = IDirect3DDevice7_SetLight(lpD3DDevice, 45, &light); + ok(rc==D3D_OK, "SetLight returned: %lx\n", rc); + + + /* Try to retrieve a light beyond the indices of the lights that have + been set. */ + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 50, &light); + ok(rc==DDERR_INVALIDPARAMS, "GetLight returned: %lx\n", rc); + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 2, &light); + ok(rc==DDERR_INVALIDPARAMS, "GetLight returned: %lx\n", rc); + + + /* Try to retrieve one of the lights that have been set */ + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 10, &light); + ok(rc==D3D_OK, "GetLight returned: %lx\n", rc); + + + /* Enable a light that have been previously set. */ + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 10, TRUE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + + + /* Enable some lights that have not been previously set, and verify that + they have been initialized with proper default values. */ + memset(&defaultlight, 0, sizeof(D3DLIGHT7)); + defaultlight.dltType = D3DLIGHT_DIRECTIONAL; + defaultlight.dcvDiffuse.r = 1.f; + defaultlight.dcvDiffuse.g = 1.f; + defaultlight.dcvDiffuse.b = 1.f; + defaultlight.dvDirection.z = 1.f; + + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 20, TRUE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + memset(&light, 0, sizeof(D3DLIGHT7)); + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 20, &light); + ok(rc==D3D_OK, "GetLight returned: %lx\n", rc); + ok(!memcmp(&light, &defaultlight, sizeof(D3DLIGHT7)), + "light data doesn't match expected default values\n" ); + + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 50, TRUE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + memset(&light, 0, sizeof(D3DLIGHT7)); + rc = IDirect3DDevice7_GetLight(lpD3DDevice, 50, &light); + ok(rc==D3D_OK, "GetLight returned: %lx\n", rc); + ok(!memcmp(&light, &defaultlight, sizeof(D3DLIGHT7)), + "light data doesn't match expected default values\n" ); + + + /* Disable one of the light that have been previously enabled. */ + rc = IDirect3DDevice7_LightEnable(lpD3DDevice, 20, FALSE); + ok(rc==D3D_OK, "LightEnable returned: %lx\n", rc); + + /* Try to retrieve the enable status of some lights */ + /* Light 20 is supposed to be disabled */ + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 20, &bEnabled ); + ok(rc==D3D_OK, "GetLightEnable returned: %lx\n", rc); + ok(!bEnabled, "GetLightEnable says the light is enabled\n"); + + /* Light 10 is supposed to be enabled */ + bEnabled = FALSE; + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 10, &bEnabled ); + ok(rc==D3D_OK, "GetLightEnable returned: %lx\n", rc); + ok(bEnabled, "GetLightEnable says the light is disabled\n"); + + /* Light 80 has not been set */ + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 80, &bEnabled ); + ok(rc==DDERR_INVALIDPARAMS, "GetLightEnable returned: %lx\n", rc); + + /* Light 23 has not been set */ + rc = IDirect3DDevice7_GetLightEnable(lpD3DDevice, 23, &bEnabled ); + ok(rc==DDERR_INVALIDPARAMS, "GetLightEnable returned: %lx\n", rc); +} + +START_TEST(d3d7light) +{ + CreateDirect3D(); + LightTest(); + ReleaseDirect3D(); +}

1 0

[RESEND] [d3d] Light management API fix to handle an unlimited number of lights
by Antoine Chavasse 06 Jun '05

06 Jun '05

Resend of http://www.winehq.org/hypermail/wine-patches/2005/06/0103.html, adapted to Christian's reorganisation of ddraw directory, and as attachment to avoid gmail word-wrapping the patch :) ChangeLog: - Rewrote the light management API to allow for an unlimited amount of lights to be set, and only a subset of them to be enabled.

1 0

Re: Google "Summer of Code"
by Jesse Allen 06 Jun '05

06 Jun '05

Mike Hearn said: We need more people working on app compatibility! :) Maybe we can choose some apps that are "nearly there" and get people to solve the last few bugs or alternatively make one of the projects "Bring any 3 apps up to Gold status in the appdb". Stefan DÃ¶singer said: I've a few app suggestions: Half-Life 1 (+Mods like Counter-Strike) Star Wars Jedi Knight Jedi Academy Star Wars Jedi Knight Jedi Outcast Warcraft III Microsoft Visual Basic Microsoft Visual C++ UltraISO Quicktime player Anno 1602 I am a super maintainer for Warcraft III. I *know* everything that needs to be fixed. In fact, I have been working on it for a long time. I just need a little more motivation to get the last major issues fixed. Now here's the deal. I need something to do this summer, and my job at IBM may be going away. I'm also a student at a local college here, and have been itching to do something. I've helped wine a bit before so I'm not a total new-comer. I know C, but can use more practice. So I'm willing to work to get three applications to gold status. Jedi Acadamy is probably doable as well, from what I've seen. But if anyone has suggestions I'm willing to look. I could help Ivan to get Safedisc to work too. So maybe if I can get a list of goals to reach, I will apply for it. Jesse

6 13

Re: [include/winternl.h #7] SYSTEM_PROCESS_INFORMATION
by Alexandre Julliard 06 Jun '05

06 Jun '05

Paul Vriens <Paul.Vriens(a)xs4all.nl> writes: > I removed the __WINESRC__ bit as it will never be used and it makes the > (coming) tests look better (no private structure needed). > The Windows struct part in SYSTEM_PROCESS_INFORMATION is wrong anyway > (both by size and members). Actually in most cases the non __WINESRC__ case is the one you want to keep, since it comes from the Microsoft headers. You can replace the Reserved things with better names but you should keep at least the fields that have explicit names in the MS headers. If you have to change the layout more than that something is seriously wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Delete version sniffing logic
by Stefan Dösinger 06 Jun '05

06 Jun '05

> The rationale for this change is simple: the version sniffing > code is unreliable and gets it wrong frequently. Out of the box, > you can't run "WINEDLLOVERRIDES=msi,msiexec.exe=n wine InstMsiA.exe" > because of this code. You just get silence. It turns out that even > though this is the Win98 version of the installer, it's detected > as a Windows XP binary. > > It's a lot simpler to have a single, sane default. This makes it > easier for users to understand, easier for us to control, and avoids > the case where different processes in the same program get different > version information. > > This patch defaults us to Win98 mode. Shouldn't we default to WinXP? I know no apps except Win98 specific system files like InstMsiA.exe and dcom98.exe which fail with Winver=winxp. Contrary many apps need winver=winxp(or win2k or nt40) to work, like the setup programs for MS Visual Studio and Microsoft Office 2003. Anyone who has an app which doesn't work with winver=winxp but works with real Windows XP? I think we should at least target Winver=winxp and fix broken apps. Stefan

4 4

Re: Wine on Sparc
by Chuck Hall 06 Jun '05

06 Jun '05

> Chuck Hall wrote: >> Well it looks good. I did get a few failures on the patching, but it >> wnet >> through 'make depend' without a problem. >> >> Now I run into the problem in kthread.c: >> sed -e 's,@bindir\@,/usr/local/bin,g' -e >> 's,@dlldir\@,/usr/local/lib/wine,g' -e 's,@PACKAGE_STRING\@,Wine >> 20050524,g' ./wine.man.in >wine.man || (rm -f wine.man && false) >> gcc -c -I. -I. -I../include -I../include -Wall -pipe >> -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o kthread.o >> kthread.c >> kthread.c:322:3: #error You must implement wine_pthread_init_current_teb >> for your platform >> kthread.c:361:3: #error wine_pthread_get_current_teb not defined for >> this >> architecture >> kthread.c: In function `wine_pthread_get_current_teb': >> kthread.c:340: warning: 'ret' might be used uninitialized in this >> function >> *** Error code 1 >> make: Fatal error: Command failed for target `kthread.o' >> Current working directory /tmp/wine-20050524/loader >> *** Error code 1 >> The following command caused the error: >> cd loader && make >> make: Fatal error: Command failed for target `loader' >> >> Guess this is the next problem to work on :) > > Sounds like configure isn't detecting things properly. It should be > detecting '_lwp_create' and '_lwp_self', thus defining HAVE__LWP_CREATE > and HAVE__LWP_SELF (in addition to HAVE_SYS_LWP_H). Check your > config.log to see what's going on. > > I did have problems with this stuff in older versions of wine, and I > actually hacked the configure scripts to use wine-pthread instead of > wine-kthread. I don't recall the exact reasons, but it wine-kthread > seems to be working fine for me now. Started to go through this and found something intresting. lwp.h does exist and is found, so HAVE_SYS_LWP_H is defined. The test for _lwp_create fails. Looking a bit deeper I found that the lwp.h for Solaris 9 is different from the one in Solaris 10 (which is what I am using). Based on this and something I read awhile ago, I belive that Sun is attempting to phase out the lwp stuff on Solaris. It looks like a workaround will need to be created for _lwp_create. I will look into this and see what is the "official" way to write the code now, if any. Also a workaround will need to be made for all other _lwp_* calls that no longer exist. Have Fun! Chuck Hall

3 3

Re: [OLE #94] Correctly marshal NULL ppUnk refptrs in NdrPointerMarshall
by Robert Shearman 06 Jun '05

06 Jun '05

Mike Hearn wrote: >This corrects an attempt to demarshal garbage during InstallShield10 >startup. For full InstallShield 10 support we need a stdole2.tlb > >Mike Hearn <mh(a)codeweavers.com> >Correctly marshal NULL ppUnk refptrs in NdrPointerMarshall > >Index: dlls/rpcrt4/ndr_marshall.c >=================================================================== >RCS file: /home/wine/wine/dlls/rpcrt4/ndr_marshall.c,v >retrieving revision 1.24 >diff -u -p -d -u -r1.24 ndr_marshall.c >--- dlls/rpcrt4/ndr_marshall.c 1 Jun 2005 11:04:03 -0000 1.24 >+++ dlls/rpcrt4/ndr_marshall.c 5 Jun 2005 22:03:11 -0000 >@@ -575,19 +575,19 @@ void WINAPI PointerMarshall(PMIDL_STUB_M > TRACE("(%p,%p,%p,%p)\n", pStubMsg, Buffer, Pointer, pFormat); > TRACE("type=0x%x, attr=", type); dump_pointer_attr(attr); > pFormat += 2; >+ > if (attr & RPC_FC_P_SIMPLEPOINTER) desc = pFormat; > else desc = pFormat + *(const SHORT*)pFormat; >+ > if (attr & RPC_FC_P_DEREF) { >+ if (!Pointer) >+ RpcRaiseException(RPC_X_NULL_REF_POINTER); > Pointer = *(unsigned char**)Pointer; > TRACE("deref => %p\n", Pointer); > } > > switch (type) { >- case RPC_FC_RP: /* ref pointer (always non-null) */ >-#if 0 /* this causes problems for InstallShield so is disabled - we need more tests */ >- if (!Pointer) >- RpcRaiseException(RPC_X_NULL_REF_POINTER); >-#endif >+ case RPC_FC_RP: /* ref pointer (always non-null but may point to null) */ > break; > case RPC_FC_UP: /* unique pointer */ > case RPC_FC_OP: /* object pointer - same as unique here */ > > > This looks wrong. A ref pointer shouldn't be treated as a unique pointer in any circumstances AFAIK. I'll add this case to my mini test suite to confirm or deny this hypothesis. -- Rob Shearman

2 3

Re: spi.pszProcessName should be UNICODE_STRING
by Paul Vriens 06 Jun '05

06 Jun '05

On Mon, 2005-06-06 at 12:15, Felix Nawothnig wrote: > This lets the taskname appear in WinXP's taskmgr.exe. > > ChangeLog: > Make SYSTEM_THREAD_INFORMATION.pszProcessName an UNICODE_STRING > > ______________________________________________________________________ Thanks for the fix. The change is however done to the SYSTEM_PROCESS_INFORMATION struct :-). The process name now shows nicely in Process Explorer as well. I saw it's committed so I'll build on that one. Paul.

1 0

Re: Temp fix for SetWindowTextA()
by Christoph Frick 06 Jun '05

06 Jun '05

On Sun, Jun 05, 2005 at 02:26:40PM -0400, Jason Campbell wrote: > A possible better patch may be to see if D2 is a child of the D2 bot > (since most bots can load D2) and allow the title change if it is and > not allow it if it's not a parent/child. there are no stupid questions, so i ask: i doubt that windows has there some "if d2 bot, then remove restrictions"... either this software overwrites this data in the process it spawns (many trainers or actually even mods (Grand Prix Legends) work this way. or windows allows changing the title for the spaning process. so the best thing to do is write a test for this, try it in windows and wine and do the correct thing then? -- cu

1 0

Re: [msvcrt] Implement %I types for printf
by Dmitry Timoshkov 06 Jun '05

06 Jun '05

"Jesse Allen" <the3dfxdude(a)gmail.com> wrote: > + if( flags->IntegerLength == 'I' ) > + { > + sprintf(p, "l"); > + p++; > + } > + if( flags->IntegerSize == INTEGERSIZE_LONGLONG ) > + { > + sprintf(p, "l"); > + p++; > + } sprintf is very inefficient here, why not use simple strcpy instead? -- Dmitry.

2 1

Half Life 2 error -- err:mmio:MMIO_ParseExtA
by J. Grant 06 Jun '05

06 Jun '05

Hello, I am getting this error when trying to run Half Life2 in err:mmio:MMIO_ParseExtA. Could someone tell me if this is a problem in in WINE, or a problem in my setup? Or not an error at all..? Also if there is already a document on setting up Half Life2 could someone direct me to it please, I could not find one already. $ wcmd Invoking /usr/lib/wine/wine.bin wcmd.exe ... WCMD Version 0.17 Z:\home\now3d>cd C:\opt\games\steam\ C:\opt\games\steam>C:\opt\games\steam\Steam.exe -applaunch 220 C:\opt\games\steam>err:dc:CreateDCW no driver found for L"WINEPS" fixme:winspool:AddPrinterW DocumentPropertiesW on printer 'L"deskjet930c"' fails err:dc:CreateDCW no driver found for L"WINEPS" err:dc:CreateDCW no driver found for L"WINEPS" fixme:winspool:AddPrinterW DocumentPropertiesW on printer 'L"hp930c"' fails err:dc:CreateDCW no driver found for L"WINEPS" err:mmio:MMIO_ParseExtA No . in szFileName: "" err:mmio:MMIO_ParseExtA No . in szFileName: "C:\\opt\\games\\steam\\" You need to install the Mozilla ActiveX control to use Wine's builtin CLSID_WebBrowser from SHDOCVW.DLL fixme:ole:CoCreateInstance no instance created for interface {00000000-0000-0000-c000-000000000046} of class {8856f961-340a-11d0-a96b-00c04fd705a2},hres is 0x80040111 fixme:debug_buffer:RtlCreateQueryDebugBuffer (0, 0): stub fixme:debug_buffer:RtlCreateQueryDebugBuffer (96, 0): returning 0x40473b08 fixme:debug_buffer:RtlQueryProcessDebugInformation (11, 80000001, 0x40473b08): stub fixme:debug_buffer:RtlDestroyQueryDebugBuffer (0x40473b08): stub C:\opt\games\steam> C:\opt\games\steam> C:\opt\games\steam>Shutting down. . . 30client callback thread error C:\opt\games\steam>STEAM.exe "steam://open/registerproduct/220" C:\opt\games\steam>err:mmio:MMIO_ParseExtA No . in szFileName: "" err:mmio:MMIO_ParseExtA No . in szFileName: "C:\\opt\\games\\steam\\" fixme:sync:CreateIoCompletionPort (0xffffffff, (nil), 00000000, 00000000): stub. fixme:crypt:CRYPT_VerifyImage (rsaenh.dll, 0x4046b9a0): not verifying image Shutting down. . . 1completionportmanager.cpp (28) : Assertion Failed: m_hIOCP C:\opt\games\steam>exit -- Homepage: http://jguk.org/ Blog: http://jguk.org/blog.rss Radio: http://jguk.org/#radio

4 7

Re: shell32: BindToObject should fail, if called with empty pidl
by Uwe Bonnes 06 Jun '05

06 Jun '05

>>>>> "Michael" == Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: Michael> This fixes the problem in DVD Shrink's SHBrowseForFolder Michael> dialog, reported by Wolfgang Scherer. Can you perhaps provide a testcase? I pays off the long term... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

WWN #277 correction.
by Chuck Hall 06 Jun '05

06 Jun '05

In the WWN #277 there is mention that I am using Solaris 9 while attempting to get Wine to work. I am actually using Solaris 10 not Solaris 9. What I did was compare what was different between Solaris 9 and Solaris 10 so I could figure out what the problem is/was. -- Have Fun! Chuck Hall

1 0

Re: wine/ include/wine/server.h dlls/ntdll/server. ...
by Robert Shearman 05 Jun '05

05 Jun '05

Alexandre Julliard wrote: >Index: wine/include/wine/server.h >diff -u -p wine/include/wine/server.h:1.21 wine/include/wine/server.h:1.22 >--- wine/include/wine/server.h:1.21 Sun Jun 5 20:45:53 2005 >+++ wine/include/wine/server.h Sun Jun 5 20:45:53 2005 >@@ -55,6 +55,7 @@ extern void wine_server_send_fd( int fd > extern int wine_server_fd_to_handle( int fd, unsigned int access, int inherit, obj_handle_t *handle ); > extern int wine_server_handle_to_fd( obj_handle_t handle, unsigned int access, int *unix_fd, int *flags ); > extern void wine_server_release_fd( obj_handle_t handle, int unix_fd ); >+extern void DECLSPEC_NORETURN wine_server_exit_thread( int status ); > > /* do a server call and set the last error code */ > inline static unsigned int wine_server_call_err( void *req_ptr ) > >Index: wine/dlls/ntdll/server.c >diff -u -p wine/dlls/ntdll/server.c:1.21 wine/dlls/ntdll/server.c:1.22 >--- wine/dlls/ntdll/server.c:1.21 Sun Jun 5 20:45:53 2005 >+++ wine/dlls/ntdll/server.c Sun Jun 5 20:45:53 2005 >@@ -119,6 +119,40 @@ static void fatal_perror( const char *er > > > /*********************************************************************** >+ * wine_server_exit_thread (NTDLL.@) >+ */ >+void wine_server_exit_thread( int status ) >+{ >+ struct wine_pthread_thread_info info; >+ ULONG size; >+ >+ RtlAcquirePebLock(); >+ RemoveEntryList( &NtCurrentTeb()->TlsLinks ); >+ RtlReleasePebLock(); >+ >+ info.stack_base = NtCurrentTeb()->DeallocationStack; >+ info.teb_base = NtCurrentTeb(); >+ info.teb_sel = wine_get_fs(); >+ info.exit_status = status; >+ >+ size = 0; >+ NtFreeVirtualMemory( GetCurrentProcess(), &info.stack_base, &size, MEM_RELEASE | MEM_SYSTEM ); >+ info.stack_size = size; >+ >+ size = 0; >+ NtFreeVirtualMemory( GetCurrentProcess(), &info.teb_base, &size, MEM_RELEASE | MEM_SYSTEM ); >+ info.teb_size = size; >+ >+ sigprocmask( SIG_BLOCK, &block_set, NULL ); >+ close( NtCurrentTeb()->wait_fd[0] ); >+ close( NtCurrentTeb()->wait_fd[1] ); >+ close( NtCurrentTeb()->reply_fd ); >+ close( NtCurrentTeb()->request_fd ); >+ wine_pthread_exit_thread( &info ); >+} >+ >+ >+/*********************************************************************** > * server_abort_thread > */ > void server_abort_thread( int status ) > >Index: wine/dlls/ntdll/ntdll.spec >diff -u -p wine/dlls/ntdll/ntdll.spec:1.182 wine/dlls/ntdll/ntdll.spec:1.183 >--- wine/dlls/ntdll/ntdll.spec:1.182 Sun Jun 5 20:45:53 2005 >+++ wine/dlls/ntdll/ntdll.spec Sun Jun 5 20:45:53 2005 >@@ -1027,6 +1027,7 @@ > @ cdecl wine_server_handle_to_fd(long long ptr ptr) > @ cdecl wine_server_release_fd(long long) > @ cdecl wine_server_send_fd(long) >+@ cdecl wine_server_exit_thread(long) > > # Codepages > @ cdecl __wine_init_codepages(ptr ptr ptr) > >Index: wine/dlls/kernel/thread.c >diff -u -p wine/dlls/kernel/thread.c:1.23 wine/dlls/kernel/thread.c:1.24 >--- wine/dlls/kernel/thread.c:1.23 Sun Jun 5 20:45:53 2005 >+++ wine/dlls/kernel/thread.c Sun Jun 5 20:45:53 2005 >@@ -24,7 +24,6 @@ > #include <assert.h> > #include <fcntl.h> > #include <stdarg.h> >-#include <signal.h> > #include <sys/types.h> > #ifdef HAVE_SYS_TIMES_H > #include <sys/times.h> >@@ -238,45 +237,8 @@ void WINAPI ExitThread( DWORD code ) /* > } > else > { >- struct wine_pthread_thread_info info; >- sigset_t block_set; >- ULONG size; >- > LdrShutdownThread(); >- RtlAcquirePebLock(); >- RemoveEntryList( &NtCurrentTeb()->TlsLinks ); >- RtlReleasePebLock(); >- >- info.stack_base = NtCurrentTeb()->DeallocationStack; >- info.teb_base = NtCurrentTeb(); >- info.teb_sel = wine_get_fs(); >- info.exit_status = code; >- >- size = 0; >- NtFreeVirtualMemory( GetCurrentProcess(), &info.stack_base, &size, MEM_RELEASE | MEM_SYSTEM ); >- info.stack_size = size; >- >- size = 0; >- NtFreeVirtualMemory( GetCurrentProcess(), &info.teb_base, &size, MEM_RELEASE | MEM_SYSTEM ); >- info.teb_size = size; >- >- /* block the async signals */ >- sigemptyset( &block_set ); >- sigaddset( &block_set, SIGALRM ); >- sigaddset( &block_set, SIGIO ); >- sigaddset( &block_set, SIGINT ); >- sigaddset( &block_set, SIGHUP ); >- sigaddset( &block_set, SIGUSR1 ); >- sigaddset( &block_set, SIGUSR2 ); >- sigaddset( &block_set, SIGTERM ); >- sigprocmask( SIG_BLOCK, &block_set, NULL ); >- >- close( NtCurrentTeb()->wait_fd[0] ); >- close( NtCurrentTeb()->wait_fd[1] ); >- close( NtCurrentTeb()->reply_fd ); >- close( NtCurrentTeb()->request_fd ); >- >- wine_pthread_exit_thread( &info ); >+ wine_server_exit_thread( code ); > } > } > > > > Couldn't wine_server_exit_thread be merged into LdrShutdownThread to avoid this Wine-specific export? -- Rob Shearman

2 1

Regression : Current CVS gives me a Segmentation Fault
by Paul Vriens 05 Jun '05

05 Jun '05

Hi, the current cvs (2005/06/05 14:19:50) gives me a Segmentation Fault on a simple 'wine' command. Regression testing is not ended yet, but the problem wasn't there this morning (with Saturday's CVS). It appears to be http://cvs.winehq.org/patch.py?id=17949 but I'm not a 100% sure on that one yet. Any ideas, or does someone have the same problem ? Cheers, Paul.

3 2

Re: [d3d] Light management API fix to handle an unlimited number of lights
by Christian Costa 05 Jun '05

05 Jun '05

Antoine Chavasse wrote: >Direct3D allows to set any number of light, and limits the number of >lights that can be active at the same time. > >The current wine code allows to setup only 16 lights. It made Anarchy >Online crash, because it tried to setup more lights than that and >didn't like to get returned an error when doing so. > >This patch is a rewrite of the d3d light management api and some related code. > >Another patch with test cases for the light api will follow. > >ChangeLog: > - Rewrote the light management API to allow for an unlimited amount >of lights to be set, > and only a subset of them to be enabled. > > > Hi Antoine, May I ask you to wait a little until I finish reorganizing the DDraw directory? This task involves file renaming so if your patch is aplly later, we can save the history of your modifications. :-) Bye, Christian

2 1

Re: [OLE #93] Disconnect IRemUnknown proxy after the others (resend)
by Robert Shearman 05 Jun '05

05 Jun '05

Mike Hearn wrote: >On Sun, 05 Jun 2005 11:32:14 -0500, Robert Shearman wrote: > > >>The IRemUnknown proxy shouldn't be disconnected at all. Can you try this >>patch for me? >> >> > >Yes, that works too. This patch is simpler and equivalent though? > > > Yes it is. -- Rob Shearman

1 0

Re: [OLE #93] Disconnect IRemUnknown proxy after the others (resend)
by Robert Shearman 05 Jun '05

05 Jun '05

Mike Hearn wrote: >Oops, I forgot to unapply various patches that aren't ready yet or will >be submitted separately. Here it is on its own. > >This fixes the FunFlash Polaroid installer. > >ChangeLog: >Disconnect IRemUnknown proxy after the others. Add some tracing. > > The IRemUnknown proxy shouldn't be disconnected at all. Can you try this patch for me? Changelog: Don't disconnect proxies flagged with SORFP_NOLIFETIMEMGMT. It makes no sense and only causes trouble for proxies that depend on these proxies being available. -- Rob Shearman

1 0

[QUARTZ] Several fixes
by Rolf Kalbermatter 05 Jun '05

05 Jun '05

>@@ -135,7 +154,7 @@ > IEnumMediaTypesImpl *This = (IEnumMediaTypesImpl *)iface; > ULONG refCount = InterlockedIncrement(&This->refCount); > >- TRACE("()\n"); >+ TRACE("(%p)->() Release from %ld\n", iface, refCount + 1); ^^^^^^^^^^ This is in AddRef so the comment (and calculation of refCount to report) seems wrong to me. > > return refCount; > } Rolf Kalbermatter

1 0

Error in make install
by Andrew Neil Ramage 05 Jun '05

05 Jun '05

Since I do not know which part is relevant, I have placed as much of the output from a wine build at http://www.anr1963.pwp.blueyonder.co.uk as was available on the terminal window. Below are the last few lines. /usr/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_ADVAPI32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o security.o security.c {standard input}: Assembler messages: {standard input}:19402: Error: invalid character (0x8) in operand 2 make[2]: *** [security.o] Error 1 make[2]: Leaving directory `/home/andrew/Download/Software/wine/dlls/advapi32' make[1]: *** [advapi32/__install-lib__] Error 2 make[1]: Leaving directory `/home/andrew/Download/Software/wine/dlls' make: *** [dlls/__install-lib__] Error 2 -- Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 2

Steam with Wine
by Andreas 'GlaDiaC' Schneider 05 Jun '05

05 Jun '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, I have updated our Steam How-To. It is possible to get Steam working without Internet Explorer. You need only 3 dll files. HL2 doesn't work very well at the moment. I hope Oliver will release a new patchset soon. You can find the howto here: http://www.linux-gamers.net/modules/wfsection/article.php?articleid=17 Comments are welcome. -- andreas - -- http://www.linux-gamers.net - your online gaming resource -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCojH5f94+j/M+P8YRAsZWAJ9R6GQEF4zKODmtT26fXmMfVzDCoQCfe3Qq /R28bLjrykGftpnvIhhsOaQ= =TtmQ -----END PGP SIGNATURE-----

3 2

Possible regression
by Robert Lunnon 04 Jun '05

04 Jun '05

Something has changed in the last couple of weeks, running the sidenet installer under solaris crashes Xorg, Under the Xsun Xserver I get an unhandled exception dialog at the same point and now the wmp7 installer just hangs there. Starting points anyone ?

1 0

Re: typelib test: test only stdole32.tlb as we don't have olepro32.dll in Wine
by Jacek Caban 04 Jun '05

04 Jun '05

This time with patch... Changelog: Test only stdole32.tlb as we don't have olepro32.dll in Win Index: dlls/oleaut32/tests/typelib.c =================================================================== RCS file: /home/wine/wine/dlls/oleaut32/tests/typelib.c,v retrieving revision 1.1 diff -u -p -r1.1 typelib.c --- dlls/oleaut32/tests/typelib.c 19 Aug 2004 20:29:16 -0000 1.1 +++ dlls/oleaut32/tests/typelib.c 4 Jun 2005 22:49:34 -0000 @@ -58,9 +58,6 @@ void ref_count_test(LPCWSTR type_lib) START_TEST(typelib) { - static const WCHAR type_lib_olepro32[] = {'o','l','e','p','r','o','3','2','.','d','l','l',0}; static const WCHAR type_lib_stdole32[] = {'s','t','d','o','l','e','3','2','.','t','l','b',0}; - - ref_count_test(type_lib_olepro32); ref_count_test(type_lib_stdole32); }

1 0

Google "Summer of Code"
by Daniel Kegel 04 Jun '05

04 Jun '05

Google is offering students summer stipends to contribute to open source projects! To qualify for a stipend, you have to submit a proposal by June 24th, and the proposal has to be approved. See http://code.google.com/summerofcode.html It would be cool if the Wine project put together a list of suggested projects for students to work on. It would be like http://www.winehq.org/site/contributing#devel but perhaps with a bit more guidance, and oriented around things the students can finish (and get past Alexandre!) by September 1st.

21 32

Requ: Detect a broken pipe
by Uwe Bonnes 04 Jun '05

04 Jun '05

Hallo, I just mailed a testcase to wine-patches, fingerpointing at a todo_wine() with wine not seeing a broken pipe. This still keeps Altera Quartus from starting up. I tried to fix for myself for some time , but to no avail. Any help/patches welcome. Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

safedisc stuff
by Ivan Leo Puoti 04 Jun '05

04 Jun '05

Hi guys, Mike Hearn asked me to send the work in progress stuff, so here it is (some stuff has been removed for legal reasons, so you can't run it in a debugger). Some of it sucks (See QueryServiceStatus for the worst hack ever, that doesn't even usually work), but the design should be more or less ok. It needs lots of cleanup and optimisation. Ivan.

3 4

Bug 3002: regression in serial port
by Duane Clark 04 Jun '05

04 Jun '05

Howdy, Just forwarding to the list... in bug 3002 http://bugs.winehq.org/show_bug.cgi?id=3002 the reporter has found a regression in serial port handling, and narrowed it down to this CVS commit from January: http://www.winehq.org/hypermail/wine-cvs/2005/01/0378.html Log message: - got rid of include/async.h - fixed some overlapped issues in socket handling - moved kernel32.CancelIo implementation to ntdll The bug includes a description of where to get the app and how to run it.

1 0

WWN Issue #277
by Tom Wickline 04 Jun '05

04 Jun '05

5,000 X 200 = 1,000,000 not 2,000,000 Tom

1 0

Wiki and links problem
by Christian Costa 03 Jun '05

03 Jun '05

Hi, The Wiki sometimes interprets words as a links. Is this normal? If so, how can I prevent this to happen? Bye, Christian

2 2

Re: Wine does not build.
by gslink 03 Jun '05

03 Jun '05

There were a number of update rpms recently posted for gcc. One way to cause this problem is to omit loading one of them. This happened to me and I believe that one of the updates was not posted with the others. All the updates are there now. The easiest way to check for this problem is to set up a kernel source. If that shows errors when you run rpmbuild then this is the likely cause.

2 2

Re: ntdll.dll: mark dirlink as REPARSE_POINT
by Dimi Paun 03 Jun '05

03 Jun '05

On Tue, 2005-05-31 at 00:00 +0200, Detlef Riekenberg wrote: > - if (S_ISDIR( st.st_mode ) && !show_dir_symlinks) return NULL; > + if (S_ISDIR( st.st_mode )) > + { > + if (!show_dir_symlinks) > + { > + return NULL; > + }else > + { > + name_is_link = FILE_ATTRIBUTE_REPARSE_POINT; > + } > + } Minor point, but it would be more in the Wine style to code above as: + if (S_ISDIR( st.st_mode )) + { + if (!show_dir_symlinks) return NULL; + name_is_link = FILE_ATTRIBUTE_REPARSE_POINT; + } -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

3 5

Re: tab: Shift selected tab text up instead of down [RESEND]
by Alexandre Julliard 03 Jun '05

03 Jun '05

James Hawkins <truiken(a)gmail.com> writes: > Hi, > > Is there anything wrong with this patch? Same as last time, you need to fix the other branch of the if too (and probably share some common code between the two). -- Alexandre Julliard julliard(a)winehq.org

1 0

server/snapshot.c and next_process
by Paul Vriens 03 Jun '05

03 Jun '05

Hi, I'm busy fixing up NtQuerySystemInformation. I've added a trace statement at line 694: TRACE("Processname : (%s), size(%d)\n", wine_dbgstr_w(procname)); This is because I want to change procname into a unicode string later on and just wanted to see what the content of procname is. The trace shows: trace:ntdll:NtQuerySystemInformation Processname : (L"Z:\\data\\install\\windows\\SysInternals\\process_explorer\\NT\\V9.11\\procexp.exe\n") Can somebody tell me where the extra '\n' comes from ? Cheers, Paul.

2 1

Google Summer of Code - Website maintenance
by Ed Mack 03 Jun '05

03 Jun '05

Hello, I'm terribly sorry if this is the wrong forum to ask my question, if it is please redirect me :) But, I think I'm in the right from poking in the archives. Anyway, I'm really interested in maintaining the Wine site as per http://www.winehq.org/site/contributing , and would love some more info on the the responsibilities and aims. I have pretty good knowledge of PHP, and enjoy web-design. I've worked with MySQL, but not any of the other commercial databases. My little homepage http://www.edmack.com has many little sites I've built up for various games. My day-to-day language is C++ (games development with openGL), although I originally learnt C. Thanks for your time, Ed Mack

6 8

Re: Wine on Sparc
by Michael Lin 03 Jun '05

03 Jun '05

Hi Chuck, >Well the patches worked, I did need to change the first one slightly to >make it work. > >Now I'm running into the problem of OpenGL, but I think this is solveable >by pointing to Mesa instead of the native GL system. Not that I really >need OpenGL through a terminal window... Haven't heard from you for a few days. How did you go in trying to compile wine on sparc? I have been following this thread and trying to compile wine on sparc myself. I am on Solaris 9 and have ran into some similar problem you had. I finally got wine compiled and installed (with some libraries disabled). However, I can't get it to run winelib application such as notepad yet. Just wondering if you have better luck than me on this topic. Thanks, Michael

1 0

Re: Feasible google summer of code project?
by Juan Lang 02 Jun '05

02 Jun '05

Mike wrote: > In order of difficulty from easy to hard I'd say: > - Linking Desktop/My Documents to the real locations <snip> > Linking Desktop/My Documents to the real locations shouldn't be too hard I finally fixed that.. it should be super easy now ;) --Juan __________________________________ Discover Yahoo! Use Yahoo! to plan a weekend, have fun online and more. Check it out! http://discover.yahoo.com/

1 0

Hello, everybody
by chsoft＠gmail.com 02 Jun '05

02 Jun '05

I'm new to here. I hope to contribute to the wine project such as wine directshow or wined3d. I have about one year development experience in designing directshow filters on winxp platform.Then try to port simple directshow architecture on embedded system with my colleagues. I want to know the development procedure of wine dshow or wined3d to see how i can of any help. Sorry for my poor english. 3x.

3 2

Re: PATCH: Re: Wine does not build (preloader.c, line 863, a_ptr union)
by Mike Hearn 02 Jun '05

02 Jun '05

On Thu, 02 Jun 2005 09:58:39 +0200, Andreas Mohr wrote: > But OTOH projects have to do binary incompatible changes a bit before > the release of the next major version, otherwise there won't be any testing. > And perhaps glibc is in such a version change phase right now... No, it's just a totally screwed project from the perspective of versioning. You know they're making it harder and harder to access LinuxThreads, and it's scheduled for deletion from Fedora Core entirely? thanks -mike

1 0

Re: [include/winternl.h #6] SYSTEM_PROCESS_INFORMATION
by Robert Shearman 02 Jun '05

02 Jun '05

Paul Vriens wrote: >Hi, > > Hi Paul, >the first bigger change to SYSTEM_PROCESS_INFORMATION. The structure now >contains VM_COUNTERS (which had to move up in the file) instead of all >the single (wrong) items, and IO_COUNTERS. I also added 2 extra FILETIME >items (well actually I changed dwUnknown2[5]). > >This structure now has the correct size for W2K/WinXP and W2K3. NT >doesn't have the IO_COUNTERS part, but for now I'm not to worried about >dealing with that (unless somebody tells me to). > >I also had to change ntdll/nt.c because of this. I removed all the >single sets to 0 as this is done by the memset anyway. > >Next patches will change the struct (and related files) to use >UNICODE_STRING for the process name, but I'm having a few issues with >that. > >Next patches will also contain tests to prove the above. Can anybody >(who's not tired of reading until now) tell me if we really need the >__WINESRC__ in that structure, the Windows structure shown is wrong >anyway > We shouldn't need the __WINESRC__ ifdef. No code that is designed to be portable to Microsoft's headers should be using winternl.h. >and how can I check 'my' struct in a test (for now I've copied it >to the test and renamed it to something non-existent)? > > I think that is the only way to do it. -- Rob Shearman

1 0

Re: [moniker 2] Fix FileMoniker::Load/Save
by Robert Shearman 02 Jun '05

02 Jun '05

On Thursday 02 June 2005 09:47, Richard Cohen wrote: > Changelog > - Base FileMonikerImpl_Save() on XP > - Correct handling of Unicode strings & multibyte locales > - More error checking > - Change ERR to WARN > - Match Windows quick & dirty estimate for GetSizeMax() Hi Richard, Well done for fixing the Load & Save functions. However, there is one problem that isn't still fixed - paths that exist are saved with the Unicode version of their path name, but paths that don't are saved without. I'll make a patch to fix this if you think it's outside the scope of your current moniker fixes. Thanks, Rob

2 1

Re: fixes for -Wmissing-declarations and -Wwrite-strings warnings
by Pouech Eric DMI AEI CAEN 02 Jun '05

02 Jun '05

returning a pointer to something on the stack is something I call an error (how do you ensure that the buffer will not get overwritten by another function call ?) A+ > Message du 02/06/05 15:25 > De : "Dimi Paun" > A : pouech-eric(a)wanadoo.fr, wine-devel(a)winehq.org > Copie à : > Objet : Re: fixes for -Wmissing-declarations and -Wwrite-strings warnings > > From: "Pouech Eric DMI AEI CAEN" > > looking at the patch, I saw something in the code that made me sick: > > char *audioAutoDetect(void) > > { > > [snip] > > char *driversFound[10]; > > [snip] > > return driversFound[0]; > > [snip] > > } > > > > can someone fix that broken code ? > > Yeah, it's not pretty, but just by looking at this snippet there is no > obvious error in the above AFAICT.

3 2

Re: [moniker 2] Fix FileMoniker::Load/Save
by Mike McCormack 02 Jun '05

02 Jun '05

Nice patch, and nice test case. > - DWORD constant1 = 0xDEADFFFF; /* these constants are detected after analysing the data structure written by */ > - WORD constant2 = 0x3; /* FileMoniker_Save function in a windows program system */ > + DWORD DEADFFFF = 0xDEADFFFF; /* Constants */ > + DWORD ZERO = 0; > + WORD THREE = 0x3; In C, variables are traditionally lower case, and macros are upper case. Mike

1 0

Feasible google summer of code project?
by Joseph Garvin 02 Jun '05

02 Jun '05

I asked in #winehq where I should ask about this, and I was sent here. So no flames if they were horribly wrong, I tried ;) I'm an undergraduate CS student, and I've been reading the wine newsletter for a while now because I find the project rather cool to watch. When I started using Linux a year ago wine didn't run my screenwriting software at all -- it's now fully functional. That's just flippin' sweet :) So, naturally, I'm excited at the idea of maybe hacking on wine. I'm not a super experienced C programmer. I know Standard C but have never actually worked on a large project in it before. I pick up new languages rather quickly though, and I've worked in Java, C, C++, Matlab, Lisp, and Python (my current favorite). But because I'm not a low level C guru (yet), I looked for things I could contribute to that weren't frightening -- some of the suggestions on the Wiki summer of code page look like they're meant for people already familiar with the wine codebase. That said, I'm interested in picking up the desktop integration areas that wine currently lacks. Working trash, my documents, autorun, xdg menu support (adding start menu items to the K-menu for instance), winebrowser, and icon themes. Basically a good chunk of stuff on the fun projects page. Two questions: 1. My understanding is the mentor organizations get to choose who they want. Is the wine project still interested in someone with my relatively low C/wine code base experience or should I just look elsewhere? 2. Is this something feasible for a proposal? Could it realistically be completed over the summer, say with 10 (insert your realistic number here) hours a week of work? You guys know the code better than I do :)

4 3

Copy Protection & WINE
by Jonathan Wilson 02 Jun '05

02 Jun '05

From what I understand, there are 3 ways to do copy protection in WINE (at least for copy protection that needs a kernel driver to work): 1.Implement a WINE implementation of that kernel driver (in the same way various stock windows kernel drivers have been implemented). Problem with this is that there is a big DMCA risk (which is why AFAIK its been rejected) 2.Implement a fake NTOSKRNL that has just the entrypoints for accessing and loading copy protection drivers (the set of kernel calls needed by the copy protection drivers is only a very small subset of the total set of kernel calls and AFAIK none of them are hardware related) or 3.Implement a proper kernel driver loader (i.e. one that would sit in the windows kernel and do the same sort of thing as that ndiswrapper and that ntfs.sys loader do) What is the current state of copy protection work for WINE? Which of these 3 options do the developers intend to follow? (I remember someone posted some actual code for option 2 but I dont remember if anything happened with it)

2 1

Re: fixes for -Wmissing-declarations and -Wwrite-strings warnings
by Pouech Eric DMI AEI CAEN 02 Jun '05

02 Jun '05

looking at the patch, I saw something in the code that made me sick: char *audioAutoDetect(void) { [snip] char *driversFound[10]; [snip] return driversFound[0]; [snip] } can someone fix that broken code ? that would be another nice janitorial task to check whether this kind of error exists somewhere else (I'd bet it does) A+

2 1

Re: fixes for -Wmissing-declarations and -Wwrite-strings warnings
by Andreas Mohr 02 Jun '05

02 Jun '05

Hi, On Thu, Jun 02, 2005 at 08:31:36PM +0900, Mike McCormack wrote: > ChangeLog: > * fixes for -Wmissing-declarations and -Wwrite-strings warnings Argh, this is what I had done recently but didn't manage to submit yet. (I told in a mail that I had done programs/ and tools/) > -static char *ignored_fstypes[] = { > +static const char *ignored_fstypes[] = { > "devpts", > "tmpfs", > "proc", > @@ -61,7 +61,7 @@ static char *ignored_fstypes[] = { > NULL > }; Imperfect - it should be static const char * const ignored_fstypes[] since otherwise the ignored_fstypes pointer is still non-const (objdump -x) which it doesn't need to be (may mark more memory pages as read-write than necessary). Sure, your objective was to fix all strict compiler warnings which that patch probably did successfully, but why not go that extra mile... Andreas Mohr

2 1

Winelib MFC app crashes after printing
by Eugene Aksenov 02 Jun '05

02 Jun '05

Hello, I have a small MFC app ported to winelib which uses MFC compiled with winelib. Really, it is just an App-Wizard generated application. I always have a crash of the application after printing. The page is printed ok but after that the app crashes. I use LPD for printing and my command line from wine is 'lpr -P<myprinter>'. I also try to print without MFC support i.e creating the printer DC by hand etc - the crash is the same, it follows EndDoc() call. There is no crash like this at the same linux configuration using in a 'pure' Win32 simple application without MFC though the code for printing is the same. When i print to file, all is ok. So , my current workaround is printing to a temp file and then send the file to lpr. I use RH9.0, wine20050419. My [spooler] section in config is the default from the wine installation. Did anybody meet a problem like that ? Is it MFC that has some impact here ? Thanks a lot for any hints.

2 2

dlls/kernel/tests/locale.c warning regression
by Gerald Pfeifer 02 Jun '05

02 Jun '05

The following change to dlls/kernel/tests/locale.c revision 1.36 date: 2005/05/31 09:30:46; author: julliard; state: Exp; lines: +4 -4 Mike McCormack <mike(a)codeweavers.com> Some warning fixes for the regression tests. actually doesn't fix any warning on FreeBSD 4.x, but adds the following one: locale.c:763: warning: `test_EnumTimeFormats' defined but not used Would you mind looking into that? Thanks, Gerald

1 0

Weirdness in the makefile
by Scott Ritchie 02 Jun '05

02 Jun '05

Can someone explain the significance of these targets in the makefile: manpages: $(MKINSTALLDIRS) $(TOPOBJDIR)/documentation/man3w cd dlls && $(MAKE) man htmlpages: $(MKINSTALLDIRS) $(TOPOBJDIR)/documentation/html cd dlls && $(MAKE) doc-html sgmlpages: $(MKINSTALLDIRS) $(TOPOBJDIR)/documentation/api-guide cd dlls && $(MAKE) doc-sgml Do they do anything? Those don't seem to be valid directories anymore. Thanks, Scott Ritchie

1 0

Re: PATCH: Re: Wine does not build (preloader.c, line 863, a_ptr union)
by Andreas Mohr 02 Jun '05

02 Jun '05

Hi, On Thu, Jun 02, 2005 at 09:10:10AM +0200, Marcus Meissner wrote: > On Thu, Jun 02, 2005 at 03:22:01PM +0900, Mike McCormack wrote: > > > > Ivan Gyurdiev wrote: > > >I hate bothering the -devel list with compile errors, but > > >they don't seem to get fixed, so I start wondering > > >if anyone else besides me is using gcc4 at all.. > > > > > >preloader.c: In function ???is_in_preload_range???: > > >preloader.c:863: error: ???union <anonymous>??? has no member named > > >???a_ptr??? > > >preloader.c:864: error: ???union <anonymous>??? has no member named > > >???a_ptr??? > > > > This is more likely to be a problem with your headers than with gcc. > > No, this is the start of this years approach to break WINE from our friends at glibc. > > a_un.a_ptr no longer exists in the elf aux vector struct. Darn, can't they use a magic keyword or similar mechanisms to mark elements scheduled for clean removal right before the next major version?? (and not out of sudden within almost the same version number) OK, some changes in that area might be non-trivial, so they do it when they feel like doing it, but I really doubt that this is the majority. But OTOH projects have to do binary incompatible changes a bit before the release of the next major version, otherwise there won't be any testing. And perhaps glibc is in such a version change phase right now... Andreas Mohr

1 0

Re: Age of Empires 2 splash screen
by Jesse Allen 01 Jun '05

01 Jun '05

On 6/1/05, Ivan Leo Puoti <ivanleo(a)gmail.com> wrote: > I actually got this for the first time a few days ago, but I thought I > might as well share it as I think it's cool. AFAIK DMCA compliant code > has never got this far with safedisc 1. > http://www003.portalis.it/115/download/aoe.png > > Ivan. > > > Was this with the current wine tree?

2 1

DCOM and Google's Summer of Code
by Ivan Pechorin 01 Jun '05

01 Jun '05

Hello! I'm in trouble trying to estimate effort needed to implement marshalling interoperable with MS. Is it a right task for 2-2.5 months of Google's "Summer of Code"? Best regards, Ivan Pechorin.

5 8

Re: Add a window station server object
by Robert Shearman 01 Jun '05

01 Jun '05

Robert Shearman wrote: > Changelog: > Add a window station server object. Alexandre, Do you want me to flesh out the window station object and add some server calls before committing this work or is there something else? -- Rob Shearman

2 1

Re: dlls/gdi/dib.c GetDIBits
by Uwe Bonnes 01 Jun '05

01 Jun '05

>>>>> "Ulrich" == Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes: Ulrich> This patch fixes a regression that happened quite sometime Ulrich> ago. We don't always fill in the BITMAPINFO struct fields on the Ulrich> way out and this broke my app because it uses these values to Ulrich> allocate enough memory to hold the bits. Ullrich, I see a lot of indentation change and only 2 or 3 lines of real code change. Can you perhaps resent with the real code change better visible? I have a problem with CopyImage, maybe it is affected by the regression you fix. Tagging the changes for debugging can help me to be sure about the change. Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Age of Empires 2 splash screen
by Ivan Leo Puoti 01 Jun '05

01 Jun '05

I actually got this for the first time a few days ago, but I thought I might as well share it as I think it's cool. AFAIK DMCA compliant code has never got this far with safedisc 1. http://www003.portalis.it/115/download/aoe.png Ivan.

1 0

Re: Borland C++ 4.5
by gslink 01 Jun '05

01 Jun '05

This started happening on FC3 with the 2.6.11 kernels in programs running under the Sun 1.42 jre. I was using the Nvidia driver supplied with the kernel. I changed to the driver posted on the Nvidia web site and have had no further trouble. I tried to duplicate the problem but it happened so infrequently that I could never quite find it. I am not sure that this problem is with Wine.

2 1

Print unicode strings in tests
by Paul Vriens 01 Jun '05

01 Jun '05

Hi, I'd like to print unicode-strings in some tests (for debugging purposes). The following however does not show nice output on wine (it does on windows): static const WCHAR dataW[] = {'S','o','m','e',' ','d','a','t','a',0}; UNICODE_STRING usdata = { sizeof(dataW)-sizeof(WCHAR), sizeof(dataW), (LPWSTR)dataW }; trace("Length is %d\n", usdata.Length); trace("Maximum Length is %d\n", usdata.MaximumLength); trace("The strings is %ls\n", usdata.Buffer); Our trace doesn't seem to be able to cope with %ls (or %S). Any ideas ? Cheers, Paul.

3 2

Re: Optionally map the unix filesystem instead of drive letters into the shell namespace
by Michael Jung 01 Jun '05

01 Jun '05

Hi Michael, On Friday 27 May 2005 03:03, Michael Lin wrote: > Just a few things with this approach. > As I mentioned before .. with a global flag in the registry. > User can't run a winelib application with unix path and a Windows > application on Wine with dos path at the same time. Please consider the configure based global flag only an option. That's actually what I said several times. It could be a per application option as well. And there is no problem in activating it via a wine-specific API, which would override the config on a per process basis. > Ok ... I know your approach is base everything on dos path and the > global flag is simply a display mode. > But what about the parsing of the file name editbox in the file dialog? > The user is browsing unix file system, but does the user enter unix or > dos path? > I believe I can modify your solution to accept unix file path, but it > have to accept dos path as well. Modifying shfldr_unixfs to parse unix path in addition to dos paths is trivial: Just remove the (pUnixFolder->m_dwPathMode == PATHMODE_UNIX) test in line 339. The real problem is the test for invalid chars in the filedialog, which '/' is one of. The solution is obvious: If wine is configured to display unix paths, then accept '/' as a valid char in paths in comdlg32. You will have to do this for your solution as well, don't you? > Then there is also the issue of having to have the unix root mapped to a > dos drive. That's true. Actually, we are tackling two slightly different problems here: I would like to have existend applications, for which I don't have the source, to display unix paths instead of dos paths in their file dialogs. So I want MS Office to display unix paths in it's file dialogs. IMHO there is not way to achieve this without the requirement to map one of the dos drives to '/'. At least not if the user should be able to access every file on his filesystem. This solution can also be applied to winelib applications. If you want to use the native posix file functions (which, frankly, I don't see a reason to do, because the user doesn't care how filenames look in the core dump, but only how they look on the screen) then just map the paths coming out of the file dialog to unix with the wine_nt_to_unix_path function. I do understand that there are some shortcomings of this approach for winelib applications, which can not possibly be addressed this way. But it seems equaly obvious to me that your approach can never achieve the goal I laid out above (To make native apps display the unix paths in file dialogs). So perhaps there might be demand for both solutions. Or perhaps I'm totaly off the point and the only person on the planet who likes to see unix paths in his native windows applications on wine. Which would mean your solution might be the only one people are interested in. What I meant to say is, please fell free to implement your solution the way you like it and let the wine community decide on it. But please don't modify shfldr_unixfs in a way that breaks my solution (Conceptually, that is. Bugs, of course, are unavoidable.) > Troy, Alexandre and I have been discussing other possible solutions to > this problem offline. I don't want to offend, but I think this just isn't fair. I have contributed a lot of my free time working on this stuff, and I think I would have deserved to be informed on discussions and decisions in this matter. Above that, this kind of discussion should take place on wine-devel, so that the community at large can take part in it. To me this gives the impression that you avoided discussing it on wine-devel, because you didn't want to be convinced. Sorry. Ok, nuff said, going back to the technological stuff. > One solution I have implemented and waiting on Alexandre's verdict is > the following. > > Create a new library called wineunixfs. All additional entry point > should be in that library. > All exported function call should be of the same signiture as one in the > core library such as GetOpenFileNameA(), GetOpenFileNameW() etc. > To use the library, simply let winelib application link it before all > the other core libraries. > > My Changes to the core libraries are contained within shell32. There is > only one extra exported functions SHUnixFSGetDesktopFolder() being > added. This function return the desktop folder in unix mode. > > Currenlt wineunixfs duplicates filedlg.c, filedlgbrowser.* and their > dependent files from commdlg. > I have attached the diff file for the rest of the changes that's on the > core libraries. I'm not the one to judge, but in my opinion this is pretty heavy weight. Ciao, -- Michael Jung mjung(a)iss.tu-darmstadt.de

2 3

Re: Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs
by Robert Shearman 01 Jun '05

01 Jun '05

Evan Deaubl wrote: >ChangeLog: > * Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs > > I cleaned up the patch a little. Does this still work for you? Changelog: Evan Deaubl <wine(a)warpedview.com> Robert Shearman <rob(a)codeweavers.com> - Implement RtlGetControlSecurityDescriptor - Fix NtAccessCheck so it works with relative SECURITY_DESCRIPTORs -- Rob Shearman

2 1

Borland C++ 4.5
by Andrew Neil Ramage 31 May '05

31 May '05

When I tried to install BC++ 4.5, the installation proceeded normally. However, when I clicked "Finish", it trashed my X server, causing the system to stop responding to key presses and the mouse. I could not even kill the X server, and so had to pull the power cord out. Is this a known problem, and will I still be able to use my Development identity ? -- Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

7 9

Re: wine/dlls/setupapi parser.c
by Robert Shearman 31 May '05

31 May '05

Alexandre Julliard wrote: >Index: wine/dlls/setupapi/parser.c >diff -u -p wine/dlls/setupapi/parser.c:1.15 wine/dlls/setupapi/parser.c:1.16 >--- wine/dlls/setupapi/parser.c:1.15 Tue May 31 17:10:06 2005 >+++ wine/dlls/setupapi/parser.c Tue May 31 17:10:06 2005 >@@ -852,7 +852,9 @@ static DWORD parse_buffer( struct inf_fi > struct parser parser; > const WCHAR *pos = buffer; > >- parser.start = buffer; >+ if (*pos == 0xfeff) pos++; /* skip Unicode BOM signature */ >+ >+ parser.start = pos; > parser.end = end; > parser.file = file; > parser.line = NULL; > This shouldn't be necessary. The Unicode BOM (or Zero Width Non-Breaking Space) has CT_CTYPE1 of C1_SPACE | C1_BLANK so it should be skipped just like any other whitespace character. -- Rob Shearman

2 1

Re: Default setting for RelayExclude
by Mike Hearn 31 May '05

31 May '05

On Thu, 26 May 2005 01:15:45 +0100, Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Default setting for RelayExclude Alexandre, any reason this didn't get in? thanks -mike

2 2

Re: Fix implicit loading of 16bit GDI & USER
by Alexandre Julliard 31 May '05

31 May '05

Richard Cohen <richard(a)daijobu.co.uk> writes: > Changelog > Implicitly loaded 16bit GDI & USER need an EXE extension This is wrong, the EXE extension is present in the module filename, the loader shouldn't need to know about it. The problem is probably that GDI isn't pre-loaded, which is the case for 32-bit apps now that GDI no longer needs the local heap. What app is causing the problem? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [Fwd: Re: Extending File Dialog to include unix file paths]
by Michael Lin 31 May '05

31 May '05

Hi Alexandre, I haven't got a reply from you on this issue yet. Please let me know what you think of the patch. Thanks, Michael Michael Lin wrote: > Hi Alexandre, > > I have made the changes as you suggested to put all the entry point in > one single library. > > Basically, I have created a new library called wineunixfs. > It currently contain modified version of filedlg.c and > filedlgbrowser.* and all their dependent files from commdlg. > > I have attached the diff file for the rest of the changes that's on > the core libraries. > I didn't attach the files in wineunixfs as you seems ok with > duplicating code there and modify it there. > > Most of the changes are contained within shell32 libraries to make it > aware of whether it is in unix or dos path mode. > There is only one exported function been added and that is > SHUnixFSGetDesktopFolder() in shell32. > > Could you please take a look at the patch and let me know if this is > "clean" and acceptable. > > Thanks, > Michael >

2 1

Re: tab: Shift selected tab text up instead of down [RESEND]
by Mike McCormack 31 May '05

31 May '05

> + if (iItem == infoPtr->iSelected) > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) - infoPtr->uVItemPadding) / 2; > + else > + center_offset_v = ((drawRect->bottom - drawRect->top) - (rcText.bottom - rcText.top) + infoPtr->uVItemPadding) / 2; Wouldn't it be clearer as: center_offset_v = (drawRect->bottom - drawRect->top) + (rcText.bottom - rcText.top); if (iItem == infoPtr->iSelected) center_offset_v -= infoPtr->uVItemPadding; else center_offset_v += infoPtr->uVItemPadding; center_offset_v /= 2; That breaks up the long lines, and eliminates the common sub-expressions... Mike

1 0

generic.ppd isn't installed anymore
by Vincent Béron 31 May '05

31 May '05

Hi, wineps/generic.ppd isn't installed anymore since a couple weeks ago (didn't had time yet to pinpoint exact patch). I think it's because only __install-lib__ and __install-dev__ is done in dlls/ now, and not __install__, which is the target actually installing wineps/generic.ppd. A quick'n dirty way is to run make -C dlls/wineps install after make install but it should really be fixed properly I guess. Vincent

1 0

Re: wine/dlls/x11drv keyboard.c
by Francois Gouget 31 May '05

31 May '05

On Sun, 29 May 2005, Alexandre Julliard wrote: [...] > Log message: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Fix Estonian keyboard layout to better match the X11 one. I have noticed that we get a steady trickle of these. Shouldn't it be possible to get the definitions of all keyboards from the XFree sources and find some way to automatically import them? The other trickle we're seeing is with timezones. So in a similar way maybe we could get the data from the site below and import it all: http://www.timeanddate.com/library/abbreviations/timezones/ Would this make sense? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

3 2

Re: OLEAUT32 (resend) Floating point locale, no negative zero
by Alex Villacís Lasso 30 May '05

30 May '05

Alexandre Julliard wrote: > Alex Villacis Lasso <a_villacis(a)palosanto.com> writes: > > > >> Changelog: >> * Force Single|Double conversion to BSTR to use the decimal separator >> defined by the current locale, because that is what native oleaut32 >> does, and to be consistent with later parsing of floating-point >> numbers, which uses current locale. Failure to apply this patch causes >> vartype test to fail in non-US locales with a decimal separator other >> than a period. >> * The number form "-0" is *not* allowed to be returned in a >> Single|Double conversion to BSTR in case of numeric undeflow, use >> unsigned zero instead. Some applications depend on this. Test included. >> > > > That's ugly, I think we really want to do our own formatting instead > of using the system printf and hacking the string afterwards. > > > By "our own formatting", do you mean to reimplement the %f and %lf functionality of the system printf() in a Wine-specific function? It can be done, of course, but I thought there was a good reason for the original code to rely on the system printf() for the floating-point formatting. Then there is the question of whether the potential patch is still allowed to use GetNumberFormatW for the (dwFlags & LOCALE_USE_NLS) case. This function seems to relay on the decimal separator being a period (as built by sprintfW). A more recent patch I sent used GetNumberFormatW for the non-NLS case to achieve the substitution of the period for whatever the decimal separator was in the current locale. However, GetNumberFormatW() cannot do anything about the negative zero issue, so that was still handled in the VARIANT_BstrFromReal() function of vartype.c. How much formatting should the new formatting function do? Is it enough to handle the negative zero and the decimal separator, and use sprintfW() for the LOCALE_USE_NLS case (as the current code does), or does it have to reimplement the functionality currently delegated to GetNumberFormatW()? I will start making a patch assuming the first scenario (use new function just for non-NLS case). Please answer if anybody thinks it should be done otherwise. Alex Villacís Lasso

1 0

CryptUnprotectData undeclared - cannot compile
by Pavel Troller 30 May '05

30 May '05

Hi! For some time, about 10 - 14 days, I cannot compile wine from CVS anymore. The reason is as follows: make[3]: Entering directory `/usr/src/emul/wine/dlls/crypt32/tests' ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole protectdata.o testlist.o -o crypt32_test.exe.so -L../../../libs/port -lwine_port -L../../../dlls -L../../../dlls/crypt32 -L../../../libs -lcrypt32 -s -L/opt/ungif/lib protectdata.o(.text+0x3b5): In function `test_cryptunprotectdata': /usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:114: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x42f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:120: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x4b9):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:129: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x54f):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:140: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x702):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:160: undefined reference to `CryptUnprotectData' protectdata.o(.text+0x782):/usr/src/emul/wine/dlls/crypt32/tests/protectdata.c:167: more undefined references to `CryptUnprotectData' follow collect2: ld returned 1 exit status The same reported another user on the user's list, but nobody noticed it. It would be nice to fix this problem to be able to compile wine again. With regards, Pavel Troller

4 7

Hint for Wine + Type1 + FrameMaker / Update for the Font HOWTO
by Dag Wieers 30 May '05

30 May '05

Hi Avi, Having spend endless hours looking for how to make Wine and Type1 fonts working together. I finally decided to convert my Type1 fonts to Truetype (after a hint by someone that Wine does not have Type1/Adobe support). Note: I'm not sure if this is true since there is a wine [afmdirs] section in the wine config. Wine still had troubles with (at least) some of the files. Converting Type1 fonts to Truetype fonts was easy and Framemaker actually has a hidden feature to find out which fonts are missing. When you load your FrameMaker document and you have missing fonts, it wants to reformat your file. After you allow that, just look at the available fonts, suddenly you have a few extra ones in the list that have been disabled. These are the fonts FrameMaker requires and couldn't find. Note down the names as they appear in the list, quit the document without saving (!), then go look for the Type1 fonts that match the name using grep. Open them in fontforge (http://fontforge.sourceforge.net/), if necessary change the Family Name to what you wrote down and safe it as a Truetype font. If you do that for all the files involved, everything works fine. I added this explanation to my document bits (for google) http://dag.wieers.com/howto/bits/wine-framemaker-type1.php So fontforge should definitely be part of the Font HOWTO and maybe something about Wine and Type1 support (and FrameMaker) too ? PS I included the Wine list too, as I looked there for answers first. I bet some more people will do the same and come across this thread. Hope this helps and thanks for a great resource, -- dag wieers, dag(a)wieers.com, http://dag.wieers.com/ -- [all I want is a warm bed and a kind word and unlimited power]

1 0

Re: tab: Shift selected tab text up instead of down
by Vitaliy Margolen 30 May '05

30 May '05

Sunday, May 29, 2005, 2:17:12, Vitaliy Margolen wrote: > Hi, > Changelog > * Shift selected tab text up instead of down. >- drawRect->>bottom += 3; >+ drawRect->>bottom -= 3; This does not shift tab up. This will shrink tab text area instead of growing it. Also you missed note above about keeping TAB_DrawItem in sync with this part. All these numbers had been verified against native, including custom drawn tabs (see WM_DRAWITEM message). Vitaliy.

3 2

Re: [DSOUND]multiple DIRECTSOUND object support
by Alexandre Julliard 30 May '05

30 May '05

Robert Reif <reif(a)earthlink.net> writes: > Add multiple DIRECTSOUND object support (multiple sound cards can play > at the same time). > Fix CoCreateInstance when no sound card is present. > Fix create bug found by Mike Hearn. This is causing major trouble with make test for me: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so ds3d.c && touch ds3d.ok wine: Unhandled exception (thread 003c), starting debugger... WineDbg starting on pid 0x3a Unhandled exception: page fault on read access to 0x88d9a3d0 in 32-bit code (0x779a6b3b). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:779a6b3b ESP:7292809c EBP:729280ac EFLAGS:00010a13( - 00 ROIA1C) EAX:11154d54 EBX:779bfc58 ECX:0063006c EDX:3bad4fe3 ESI:779bfb48 EDI:77c453e0 Stack dump: 0x7292809c: 00000020 779bfc58 00000019 77c453e0 0x729280ac: 729280c8 779a7349 77c453e0 ff9cff99 0x729280bc: 77978600 00008000 779a71d4 729280f0 0x729280cc: 7795c80b 00008000 000003bd 77c453e0 0x729280dc: 77c45500 00000000 72ad5e00 000003bd 0x729280ec: 72ad8b40 72928120 72ab84d8 779a71d4 Backtrace: =>1 0x779a6b3b DSOUND_WaveQueue+0x9b(device=0x77c453e0, mixq=0xff9cff99) [/home/julliard/wine/wine/dlls/dsound/mixer.c:931] in dsound (0x729280ac) 2 0x779a7349 DSOUND_callback+0x175(hwo=0x8000, msg=0x3bd, dwUser=0x77c453e0, dw1=0x77c45500, dw2=0x0) [/home/julliard/wine/wine/dlls/dsound/mixer.c:1168] in dsound (0x729280c8) 3 0x7795c80b DriverCallback+0x1a3(dwCallBack=0x779a71d4, uFlags=0x3, hDev=0x8000, wMsg=0x3bd, dwUser=0x77c453e0, dwParam1=0x77c45500, dwParam2=0x0) [/home/julliard/wine/wine/dlls/winmm/driver.c:521] in winmm (0x729280f0) 4 0x72ab84d8 wodNotifyClient(wwo=0x72ad8b40, wMsg=0x3bd, dwParam1=0x77c45500, dwParam2=0x0) [/home/julliard/wine/wine/dlls/winmm/wineoss/audio.c:1330] in wineoss.drv (0x72928120) 5 0x72ab8a16 wodPlayer_NotifyCompletions+0xea(wwo=0x72ad8b40, force=0x1) [/home/julliard/wine/wine/dlls/winmm/wineoss/audio.c:1561] in wineoss.drv (0x72928144) 6 0x72ab8aa2 wodPlayer_Reset(wwo=0x72ad8b40, reset=0x1) [/home/julliard/wine/wine/dlls/winmm/wineoss/audio.c:1610] in wineoss.drv (0x7292817c) 7 0x72ab8d3e wodPlayer_ProcessMessages(wwo=0x72ad8b40) [/home/julliard/wine/wine/dlls/winmm/wineoss/audio.c:1701] in wineoss.drv (0x729281b0) 8 0x72ab8fe5 wodPlayer(pmt=0x0) [/home/julliard/wine/wine/dlls/winmm/wineoss/audio.c:1795] in wineoss.drv (0x729281dc) 9 0x77bd8867 THREAD_Start(ptr=0x77c45500) [/home/julliard/wine/wine/dlls/kernel/thread.c:107] in kernel32 (0x729282a8) 10 0x77ee09aa start_thread+0x142(info=0x77c45520) [/home/julliard/wine/wine/dlls/ntdll/thread.c:204] in ntdll (0x72928ad8) 11 0xb7fb1b63 start_thread+0x93 in libpthread.so.0 (0x72928b4c) 12 0xb7f5018a __clone+0x5a in libc.so.6 (0x00000000) 0x779a6b3b DSOUND_WaveQueue+0x9b [/home/julliard/wine/wine/dlls/dsound/mixer.c:931] in dsound: pushl 0x29c(%eax,%edi,1) 931 waveOutWrite(device->hwo, device->pwave[device->pwwrite], sizeof(WAVEHDR)); -- Alexandre Julliard julliard(a)winehq.org

1 0

CRYPTPROTECT_LOCAL_MACHINE in CryptProtectData
by Michael Jung 30 May '05

30 May '05

Hi Kees, rsaenh uses your Crypt[Un]ProtectData functions for protecting the user's private keys, which are stored in the registry. For machine key pairs (which are keys that belong to the machine instead of a certain user), rsaenh needs support for the CRYPTPROTECT_LOCAL_MACHINE flag. On possible implementation would be to derive the key from the computer name (GetComputerName) instead of from the user's login name, if the flag is set. Would you mind implementing something like this? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: Make more of the OLE interface vtables const
by Andreas Mohr 30 May '05

30 May '05

Hi, On Sun, May 29, 2005 at 07:05:49PM +0900, Dmitry Timoshkov wrote: > Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Make more of the OLE interface vtables const. You do know that those will *not* end up const? filemoniker.c:static const IClassFactoryVtbl FileMonikerCFVtbl = objdump -x ole32.dll.so: 0008efb0 l O .data 00000014 FileMonikerCFVtbl My suspicion is that this is due to winegcc compile, all other binaries with normal compile (e.g. winedump, ...) have all their const data in .rodata segment... So, does anybody know what seems to be wrong with winegcc or why it chose to do that? BTW, I already completely constified programs/ and tools/, will send a patch soon. Andreas

4 3

Re: rundll32.exe shell32.dll,SHHelpShortcuts_RunDLL
by Dmitry Timoshkov 30 May '05

30 May '05

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > Changelog: > Partial Implementation of shell32/SHHelpShortcuts_RunDLL > Connect and Disconnect: Forwarded to mpr.dll > AddPrinter: Forwarded to printui.dll > +static int shrundll_compare(const void *p1, const void *p2) > +{ > + struct shrundll_entry *e1 = (struct shrundll_entry *) p1; > + struct shrundll_entry *e2 = (struct shrundll_entry *) p2; > + > +/* > + TRACE("(%p:%p (%ld:%ld) %s:%s)\n",e1, e2, (e1 == NULL) ? 0 : e1->my_id, (e2 == NULL) ? 0 : e2->my_id, debugstr_w((e1 == NULL) ? NULL : e1->name), debugstr_w((e2 == NULL) ? NULL : e2->name)); > +*/ > + > + if((e1 == NULL) | (e2 == NULL)) > + { > + return -1; > + } > + > + return StrCmpW(e1->name, e2->name); I strongly suspect that this comparison should be case insensitive. -- Dmitry.

2 1

Re: question about standalone tests
by Dan Kegel 30 May '05

30 May '05

The STANDALONE stuff is my creation; apologies to anyone offended by it. It does fill a real need, but belongs in wine/test.h, not in each test, I agree. I was being lazy. Now, on to Alexandre's claim: On Tue, May 24, 2005 at 05:24:11PM +0200, Alexandre Julliard wrote: > You should be able to build by simply copying over wine/test.h Tried that. $ wget -O lzexpand_main.c 'http://cvs.winehq.org/cvsweb/~checkout~/wine/dlls/lzexpand/tests/lzexpand_m…' $ mkdir wine $ wget -O wine/test.h 'http://cvs.winehq.org/cvsweb/~checkout~/wine/include/wine/test.h?rev=1.14' $ cl -I. -DWINETEST_WANT_MAIN -D_X86_ lzexpand_main.c Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 13.10.3077 for 80x86 Copyright (C) Microsoft Corporation 1984-2002. All rights reserved. lzexpand_main.c h:\demo\x\wine\test.h(128) : error C2065: 'stdout' : undeclared identifier ... Adding #include <stdio.h> to wine/test.h fixes that first problem, but leaves h:\demo\x\wine\test.h(264) : error C2065: 'winetest_testlist' : undeclared identifier ... So including wine/test.h isn't enough at the moment. Maybe there needs to be a #ifdef STANDALONE ... #endif section in wine/test.h that defines winetest_testlist, etc. I just looked, and it's probably easy to do, but somewhat beyond what I want to do at 2 in the morning. (Besides, I'm not supposed to be typing, my wrists are sore.) - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Re: UT2003 Regression - Patch at last :-))
by Alexandre Julliard 29 May '05

29 May '05

"Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: > Index: painting.c > =================================================================== > RCS file: /home/wine/wine/dlls/user/painting.c,v > retrieving revision 1.29 > diff -u -r1.29 painting.c > --- painting.c 13 May 2005 14:03:06 -0000 1.29 > +++ painting.c 20 May 2005 20:26:24 -0000 > @@ -344,7 +344,7 @@ > if ((hrgn = send_ncpaint( child, NULL, &erase_flags ))) > send_erase( child, erase_flags, hrgn, NULL, NULL ); > > - prev = 0; > + break; The problem is that this will cause children to be skipped too. What you really need is to repaint every window only once, but still recurse for children. Unfortunately that's a bit tricky to do with a stateless interface... -- Alexandre Julliard julliard(a)winehq.org

4 5

dlls/oleaut32/olepicture.c won't compile
by Joris Huizer 29 May '05

29 May '05

Hello, I wanted to try netscape 8 but it's bugging about gif support being unavailable; so I got the gif library - but now wine won't recompile: ... make[2]: Entering directory `/home/jorishuizer/.wine-source/wine/dlls/oleaut32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o olepicture.o olepicture.c olepicture.c:938: error: `DGifOpen' undeclared here (not in a function) olepicture.c:938: warning: type defaults to `int' in declaration of `pDGifOpen' olepicture.c: In function `_gif_inputfunc': olepicture.c:970: error: structure has no member named `UserData' olepicture.c: In function `OLEPictureImpl_Load': olepicture.c:1080: error: called object is not a function olepicture.c:1110: error: structure has no member named `Function' make[2]: *** [olepicture.o] Error 1 make[2]: Leaving directory `/home/jorishuizer/.wine-source/wine/dlls/oleaut32' make[1]: *** [oleaut32] Error 2 make[1]: Leaving directory `/home/jorishuizer/.wine-source/wine/dlls' make: *** [dlls] Error 2 I think this is related to the configure change... please help, thanks, Joris

3 6

err:dsound:DSOUND_MixOne underrun on sound buffer 0x40407e50
by J. Grant 29 May '05

29 May '05

Hi, I am getting this underrun when running Call of Duty v1.5. fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. err:dsound:DSOUND_MixOne underrun on sound buffer 0x40407e50 It turned out there were some processes hanging around, wine server and also /usr/lib/wine/wine-preloader /usr/lib/wine/wine-pthread ./CoDMP.exe Killing them and re-starting allowed it to work. I wonder if that err a WINE problem? as CoDMP.exe has workd flawlessly since. Maybe something to do with the existing wine-preloader left running? (Is that process left running a known problem..?) Kind regards JG -- Homepage: http://jguk.org/ Blog: http://jguk.org/blog.rss Radio: http://jguk.org/#radio

1 0

Re: [ddraw] Mipmap creation with DDSCAPS_COMPLEX, DDSCAPS_MIPMAP, and no mipmap count
by Lionel Ulmer 29 May '05

29 May '05

As already said by Mike, nice patch (and also nice test script). I think I was the one who added the previous comment (and it's true that I only tested it without the COMPLEX bit set). The only (minor) gripe I would have with this patch is the use of the 'log() / log()' to compute the mipmap count (I usually dislike floating point match - it's maybe my background in embedded programming where FPU are inexistant :-) )... I would have found it simpler to just have a 'while (min > 0) { min >>= 1; count += 1 }'. Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 1

Re: [ddraw] Mipmap creation with DDSCAPS_COMPLEX, DDSCAPS_MIPMAP, and no mipmap count
by Mike Hearn 29 May '05

29 May '05

On Sat, 28 May 2005 23:36:52 +0200, Antoine Chavasse wrote: > I don't know if I did this right, any comment is welcome. I can't comment on the DirectX side of things, but this looks like a textbook case of how to do a patch correct. Unified diff from the source root, test cases, clear explanation, good comments, no extra changes ... good going! We need every patch to be like this! (And I say that as somebody who breaks those rules a lot ;)

1 0

Re: [DPlay] Added keys for the various DPlay service providers
by Stefan Dösinger 29 May '05

29 May '05

Hi Lionel, > Some games crash if we do not enumerate properly the various DPlay service > providers. So install the registry keys to please them :-) > > Lionel > > Changelog: > - added keys to install all known DPlay service providers Will this work without the service provider dlls like dpwsockx.dll and dpmodemx.dll? Stefan

3 3

Re: msiexec
by Sven Paschukat 28 May '05

28 May '05

This patch breaks installation of Microsofts MSI 2.0, InstMsiA.exe. During install with WINEDLLOVERRIDES="msiexec.exe=n,b" wine InstMsiA.exe there comes the error: "Installer besitzt keine ausreichenden Berechtigungen, um diese Datei zu verändern: C:\Config.Msi\658-rbf." The file is: sven@linux:~/wine/tools> ls -l ~/.wine/drive_c/Config.Msi/ insgesamt 4 -rw-r--r-- 1 sven users 677 2005-05-24 02:03 657.rbs lrwxrwxrwx 1 sven users 34 2005-05-24 02:00 658.rbf -> /usr/local/lib/wine/msiexec.exe.so I think it tries to modify/remove the linked file. Sven Stefan Leichter schrieb: > ChangeLog > -------------- > create link for msiexec.exe in system directory > > > ------------------------------------------------------------------------ > > --- ../wine/tools/wineprefixcreate.in 2005-04-20 19:26:37.000000000 +0200 > +++ tools/wineprefixcreate.in 2005-05-18 21:48:15.000000000 +0200

6 7

Getting back into the swing of things...
by Gregory M. Turner 28 May '05

28 May '05

Hello, as you may recall I would like to start playing with SEH macros for winelib (and maybe wine). I have not done any wine development for a year or so, and have not followed the mailing list very carefully. Anyone have any advice for me wrt getting up-to-speed? I am aware of the wiki and will peruse it carefully. Also, I will look through winehq and try to see what is new there. Please let me know if you think of anything else I should definitely be looking at. Also, it seems that my work may involve some autoconf tinkering... I have tried to study up on autoconf in the past, with disappointing results. Does anyone know what is a good beginner's resource for learning the gnu auto.* tools? Thanks! -- gmt

2 1

Re: [RESENT] MSVCRT: Use DuplicateHandle for CONOUT too
by Eric Pouech 28 May '05

28 May '05

Uwe Bonnes a écrit : > Changelog: > dlls/msvcrt/console.c: msvcrt_init_console > Use DuplicateHandle for STDOUT too ( CreateFileA("CONOUT$" failed) > Bump up error reporting of missing console handles that's that's not a correct fix... this handles must be to the console itself, whatever the input / output handles are (from process inheritance) the issue you have is that you run your program without being attached to a (wine) console... you're facing the corner cases of running wine with the "fake" console as being inherited from the unix stdin/stdout streams the correct fix would be to let OpenConsoleW work in those cases A+ -- Eric Pouech

2 2

Re: extracting window icons
by Steven Edwards 27 May '05

27 May '05

Hi, --- Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: > On Fri, May 27, 2005 at 03:00:05PM -0600, Brian Vincent wrote: > > Is there a way to extract an icon from a DLL? Wine seems to do this > > automatically when programs are installed, I just can't figure out how. Is > > there a way to do it from the commandline? Winemenubuilder is able to extract the resource file and make it a xpm. I think bin2res in wine/tools can do it as well. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new Resources site http://smallbusiness.yahoo.com/resources/

2 1

[wintest] tests not executed
by Stefan Leichter 27 May '05

27 May '05

Hello, since this week i get a lot more messages "Can't parse subtest output of .." when runnning winetest-latest.exe. The reason seems to be that the test executables with only one test target (e.g advapi32_test.exe) do not longer list its targets when started without target. Now the single target is performed. What is the reason for this change ? Bye Stefan

2 2

winetests running on win98, qemu
by Joris Huizer 27 May '05

27 May '05

Hello, I installed windows 98 inside qemu (couldn't get windows xp working) It seems there are a lot of problems, ending with a crash somewhere in msacm (the last line in the created temporary file says acmDriverDetails failed) should I do something? install ie6 & windows updates ? something else? how can I make winetest continue where it crashed? is it ok to run tests with qemu? I should think no functional differences should exist with "real windows" but... I'd really prefer not to have to reboot, or use the other computer, to run tests under windows thanks, regards, Joris

1 0

Re: SHELL32: rewrite shelllink vtable handling
by Lionel Ulmer 27 May '05

27 May '05

On Fri, May 27, 2005 at 09:14:13PM +0900, Mike McCormack wrote: > The idea is to store the of the vtable into the object offset with each > vtable, so that the object pointer can be calculated without having to > known which interface we're being called from. The down side is that it > uses a bit of casting... We once proposed something like this for the various DirectX COM objects (basically, all the different versions of the same object) but got the patch refused and had to resort to thunks... We will see if you will be more lucky than us :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

PokerStars Client
by MagicMan 27 May '05

27 May '05

I thought I would send you the errors I received while testing PokerStars with the new version of WINE. I hope that its helpful. BTW, Thank you for making PokerStars work as well as it does. :-) MagicMan Wine 20050524 - PokerStars Client Errors during clean install (Fluxbox 0.9.13): err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink Errors during clean install (Xfce 4.2.2/KDE 3.3.2): err:menubuilder:extract_icon32 LoadLibraryExW (L"c:\\Program Files\\PokerStars\\Uninstall.EXE") failed, error 126 err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink Errors during manual upgrade (Fluxbox 0.9.13): err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink No Errors during manual upgrade (Xfce 4.2.2/KDE 3.3.2) No Errors using PokerStarsUpdate (Fluxbox 0.9.13/Xfce 4.2.2/KDE 3.3.2) Errors while runing PokerStars (Fluxbox 0.9.13/Xfce 4.2.2/KDE 3.3.2): fixme:resource:GetGuiResources (0xffffffff,1): stub fixme:resource:GetGuiResources (0xffffffff,0): stub fixme:toolhelp:Heap32ListFirst : stub fixme:resource:GetGuiResources (0xffffffff,1): stub fixme:resource:GetGuiResources (0xffffffff,0): stub fixme:resource:GetGuiResources (0xffffffff,1): stub fixme:resource:GetGuiResources (0xffffffff,0): stub fixme:resource:GetGuiResources (0xffffffff,1): stub fixme:resource:GetGuiResources (0xffffffff,0): stub Desktop icon doesn't work (KDE 3.3.2) (PokerStars will not work after first use of icon): Error: 3 Path not found File: Gx\update.bmp

3 2

Re: odbccp32. ODBCCPlApplet stub
by Andreas Mohr 27 May '05

27 May '05

Hi, On Thu, May 26, 2005 at 03:26:54PM +0200, Rein Klazes wrote: > Hi, > > Changelog: > > dlls/odbccp32 : odbccp32.spec, odbccp32.c > include : odbcinst.h > > Add a stub for odbccp32.ODBCCPlApplet. > +BOOLEAN WINAPI ODBCCPlApplet( LONG i, LONG j, LONG * p1, LONG * p2) Sounds suspiciously like searching for "CplApplet" gives an answer to that one... http://msdn.microsoft.com/library/default.asp?url=/library/en-us/apippc/htm… http://www.bellamyjc.net/fr/windows9x.html http://www.funducode.com/weeklyupdate/Dec_16/Dec_16.htm Andreas Mohr

1 0

ics08jlz in wine-20050524
by Fernando Chmilelewsky 27 May '05

27 May '05

Hi there, I'm Fernando Chmielewsky, maintainer of the 'ICS08jlz development kit 1.53' I'm submitting a regression in with wine-20050524, the program used to work with the serial port, now just hangs when entering the applications that use it (the programmer, in circuit debugger, etc) In the remaining issues, the program runs real faster and better, it compiles 4 to 5 times as fast as in 20041019, and the simulation is almost as fast as it has to be Regards, Fernando

1 0

Serious Legal question - TLB(S)
by Boaz Harrosh 26 May '05

26 May '05

Lets say I have an open source tool that I can compile with MinGW. That can open a COM DLL extract it's TLB and make an .IDL file out of it. Very similar to #import in msvc++ but to .IDL instead of a .H Let's say I use this tool on a component of a Commercial program Like for example Norton Anti Virus. Or any other product and/or component. Let's say I am a legal user of this component. Now what am I allowed to do with this .idl file: (??) 1. Nothing I must delete it and never do that again. 2. Use this idl to make a program that can interface that component, and I can also distribute such a program, as long as the user has a legal copy for that component. 3. I can use this idl to make my own implementation of that component. As long as I do not violate any patents on the way. And I can distribute that alternative implementation of that component. 4. I can Publish the component form 2 including the idl with an OSS compatible License. 5. I can Publish the component form 3 including the idl with an OSS compatible License What do you guys think. A TLB in a DLL is that making things public? Does any one know if this is at all addressed in EULA(s)? What does the law say if nothing is mentioned? what is the default? can I go up to a car Extract from the manual the size of the wheels and use third party wheels in it stead? Can I make My own cars that use the same wheels? Free Life Boaz

3 3

Re: msi: hook up dialogs and control events (big)
by Stefan Dösinger 26 May '05

26 May '05

Am Donnerstag, 26. Mai 2005 17:57 schrieb Aric Stewart: > Hook up the dialog code, get a basic UI and handle basic control events. <snip> + if( r == ERROR_IO_PENDING ) + r = ERROR_SUCCESS; + + return r; + There seems to be a '{' missing. This causes a syntaxt error during compilation. Stefan

2 1

msi dialogs, events and office 2003
by Aric Stewart 26 May '05

26 May '05

Hi Stefan, We have been concentrating alot of effort on Office 2003 and specifically on getting office 2003 to install and come up properly. We would love to work more directly with you and the whole wine community in this goal. With this patch I have enabled the dialog code that Mike has put into wine and started a basic structure for handling ControlEvents sent to and from various dialog controls. Alot of this code is still pretty hacky and incorrect but the basic functionality and structure is there. It also should allow you to actually start installing Office. With the current CVS tip Office2003 fails to install due to actions relating to MSXML failing but that is where our effort is now focused. You can get around that by changing the ACTION_ProcessExecSequence(package,FALSE) in ACTION_ExecuteAction() to ACTION_ProcessExecSequence(package,TRUE), then at least Office 2003 will be able to install its basic functions and come up. We here at CodeWeavers are constantly trying to work closer with the wine community. I am bad about keeping up on wine-devel, so you can always e-mail me directly with MSI related things, and i know Mike McCormack and a number of other are very good at keeping up on the mailing list. I also hang out in the irc channel quite a bit. With some work and some luck we should be able to get office 2003 looking pretty good. -aric Index: dlls/msi/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/msi/Makefile.in,v retrieving revision 1.26 diff -u -r1.26 Makefile.in --- dlls/msi/Makefile.in 9 May 2005 14:42:33 -0000 1.26 +++ dlls/msi/Makefile.in 26 May 2005 16:16:03 -0000 @@ -16,6 +16,7 @@ delete.c \ dialog.c \ distinct.c \ + events.c \ format.c \ handle.c \ insert.c \ Index: dlls/msi/action.c =================================================================== RCS file: /home/wine/wine/dlls/msi/action.c,v retrieving revision 1.123 diff -u -r1.123 action.c --- dlls/msi/action.c 26 May 2005 16:08:58 -0000 1.123 +++ dlls/msi/action.c 26 May 2005 16:16:06 -0000 @@ -685,6 +685,21 @@ HeapFree(GetProcessHeap(),0,package->CommitAction); HeapFree(GetProcessHeap(),0,package->PackagePath); + + /* cleanup control event subscriptions */ + ControlEvent_CleanupSubscriptions(package); +} + +static void ce_actiontext(MSIPACKAGE* package, LPCWSTR action) +{ + static const WCHAR szActionText[] = + {'A','c','t','i','o','n','T','e','x','t',0}; + MSIRECORD *row; + + row = MSI_CreateRecord(1); + MSI_RecordSetStringW(row,1,action); + ControlEvent_FireSubscribedEvent(package,szActionText, row); + msiobj_release(&row->hdr); } static void ui_progress(MSIPACKAGE *package, int a, int b, int c, int d ) @@ -714,6 +729,8 @@ MSIQUERY * view; MSIRECORD * row = 0; DWORD size; + static const WCHAR szActionData[] = + {'A','c','t','i','o','n','D','a','t','a',0}; if (!package->LastAction || strcmpW(package->LastAction,action)) { @@ -764,6 +781,9 @@ MSI_RecordSetStringW(row,1,message); MSI_ProcessMessage(package, INSTALLMESSAGE_ACTIONDATA, row); + + ControlEvent_FireSubscribedEvent(package,szActionData, row); + msiobj_release(&row->hdr); } @@ -1403,6 +1423,7 @@ { if (strcmpW(StandardActions[i].action, action)==0) { + ce_actiontext(package, action); ui_actioninfo(package, action, TRUE, 0); ui_actionstart(package, action); if (StandardActions[i].handler) @@ -1427,15 +1448,11 @@ { BOOL ret = FALSE; - /* - * for the UI when we get that working - * if (ACTION_DialogBox(package,dialog) == ERROR_SUCCESS) { *rc = package->CurrentInstallState; ret = TRUE; } - */ return ret; } Index: dlls/msi/action.h =================================================================== RCS file: /home/wine/wine/dlls/msi/action.h,v retrieving revision 1.9 diff -u -r1.9 action.h --- dlls/msi/action.h 26 May 2005 16:08:58 -0000 1.9 +++ dlls/msi/action.h 26 May 2005 16:16:06 -0000 @@ -196,3 +196,8 @@ int get_loaded_feature(MSIPACKAGE* package, LPCWSTR Feature ); int get_loaded_file(MSIPACKAGE* package, LPCWSTR file); int track_tempfile(MSIPACKAGE *package, LPCWSTR name, LPCWSTR path); + +/* control event stuff */ +VOID ControlEvent_FireSubscribedEvent(MSIPACKAGE *package, LPCWSTR event, + MSIRECORD *data); +VOID ControlEvent_CleanupSubscriptions(MSIPACKAGE *package); Index: dlls/msi/msipriv.h =================================================================== RCS file: /home/wine/wine/dlls/msi/msipriv.h,v retrieving revision 1.58 diff -u -r1.58 msipriv.h --- dlls/msi/msipriv.h 26 May 2005 12:24:28 -0000 1.58 +++ dlls/msi/msipriv.h 26 May 2005 16:16:06 -0000 @@ -226,6 +226,7 @@ LPWSTR next_dialog; BOOL ExecuteSequenceRun; + struct _subscriptions *EventSubscriptions; } MSIPACKAGE; typedef struct tagMSIPREVIEW --- /dev/null 2005-03-17 08:20:53.000000000 -0600 +++ dlls/msi/events.c 2005-05-26 10:31:14.000000000 -0500 @@ -0,0 +1,506 @@ +/* + * Implementation of the Microsoft Installer (msi.dll) + * + * Copyright 2005 Aric Stewart for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + + +/* +http://msdn.microsoft.com/library/default.asp?url=/library/en-us/msi/setup/controlevent_overview.asp +*/ + +#include <stdarg.h> +#include <stdio.h> + +#define COBJMACROS + +#include "windef.h" +#include "winbase.h" +#include "winerror.h" +#include "winreg.h" +#include "wine/debug.h" +#include "fdi.h" +#include "msi.h" +#include "msiquery.h" +#include "msvcrt/fcntl.h" +#include "objbase.h" +#include "objidl.h" +#include "msipriv.h" +#include "winnls.h" +#include "winuser.h" +#include "shlobj.h" +#include "wine/unicode.h" +#include "ver.h" +#include "action.h" + +WINE_DEFAULT_DEBUG_CHANNEL(msi); + +typedef void (*EVENTHANDLER)(MSIPACKAGE*,LPCWSTR,msi_dialog *); + +struct _events{ + LPSTR event; + EVENTHANDLER handler; +}; + +struct _subscriber{ + LPWSTR control; + LPWSTR attribute; + struct _subscriber *next; +}; + +struct _subscription_chain { + LPWSTR event; + struct _subscriber *chain; +}; + +struct _subscriptions { + DWORD chain_count; + struct _subscription_chain* chain; +}; + +static VOID ControlEvent_EndDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_NewDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_SpawnDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_SpawnWaitDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_DoAction(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_AddLocal(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_Remove(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); +static VOID ControlEvent_AddSource(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog); + +struct _events Events[] = { + { "EndDialog",ControlEvent_EndDialog}, + { "NewDialog",ControlEvent_NewDialog}, + { "SpawnDialog",ControlEvent_SpawnDialog}, + { "SpawnWaitDialog",ControlEvent_SpawnWaitDialog}, + { "DoAction",ControlEvent_DoAction}, + { "AddLocal",ControlEvent_AddLocal}, + { "Remove",ControlEvent_Remove}, + { "AddSource",ControlEvent_AddSource}, + { NULL,NULL}, + }; + +VOID ControlEvent_HandleControlEvent(MSIPACKAGE *package, LPCWSTR event, + LPCWSTR argument, msi_dialog* dialog) +{ + int i = 0; + + TRACE("Handling Control Event %s\n",debugstr_w(event)); + if (!event) + return; + + while( Events[i].event != NULL) + { + LPWSTR wevent = strdupAtoW(Events[i].event); + if (strcmpW(wevent,event)==0) + { + HeapFree(GetProcessHeap(),0,wevent); + Events[i].handler(package,argument,dialog); + return; + } + HeapFree(GetProcessHeap(),0,wevent); + i++; + } + FIXME("UNHANDLED control event %s arg(%s)\n",debugstr_w(event), + debugstr_w(argument)); +} + + +/* + * Create a dialog box and run it if it's modal + */ +static UINT event_do_dialog( MSIPACKAGE *package, LPCWSTR name ) +{ + msi_dialog *dialog; + UINT r; + + /* kill the current modeless dialog */ + if( package->dialog ) + msi_dialog_destroy( package->dialog ); + package->dialog = NULL; + + /* create a new dialog */ + dialog = msi_dialog_create( package, name, + ControlEvent_HandleControlEvent ); + if( dialog ) + { + /* modeless dialogs return an error message */ + r = msi_dialog_run_message_loop( dialog ); + if( r == ERROR_SUCCESS ) + msi_dialog_destroy( dialog ); + else + package->dialog = dialog; + } + else + r = ERROR_FUNCTION_FAILED; + + return r; +} + + +/* + * End a modal dialog box + */ +static VOID ControlEvent_EndDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szExit[] = { + 'E','x','i','t',0}; + static const WCHAR szRetry[] = { + 'R','e','t','r','y',0}; + static const WCHAR szIgnore[] = { + 'I','g','n','o','r','e',0}; + static const WCHAR szReturn[] = { + 'R','e','t','u','r','n',0}; + + if (strcmpW(argument,szExit)==0) + package->CurrentInstallState = ERROR_INSTALL_USEREXIT; + else if (strcmpW(argument, szRetry) == 0) + package->CurrentInstallState = ERROR_INSTALL_SUSPEND; + else if (strcmpW(argument, szIgnore) == 0) + package->CurrentInstallState = -1; + else if (strcmpW(argument, szReturn) == 0) + package->CurrentInstallState = ERROR_SUCCESS; + else + { + ERR("Unknown argument string %s\n",debugstr_w(argument)); + package->CurrentInstallState = ERROR_FUNCTION_FAILED; + } + + msi_dialog_end_dialog( dialog ); +} + +/* + * transition from one modal dialog to another modal dialog + */ +static VOID ControlEvent_NewDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog *dialog) +{ + /* store the name of the next dialog, and signal this one to end */ + package->next_dialog = strdupW(argument); + msi_dialog_end_dialog( dialog ); +} + +/* + * Create a new child dialog of an existing modal dialog + */ +static VOID ControlEvent_SpawnDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog *dialog) +{ + event_do_dialog( package, argument ); + if( package->CurrentInstallState != ERROR_SUCCESS ) + msi_dialog_end_dialog( dialog ); +} + +/* + * Creates a dialog that remains up for a period of time + * based on a condition + */ +static VOID ControlEvent_SpawnWaitDialog(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + FIXME("Doing Nothing\n"); +} + +static VOID ControlEvent_DoAction(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + ACTION_PerformAction(package,argument); +} + +static VOID ControlEvent_AddLocal(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szAll[] = {'A','L','L',0}; + int i; + + if (strcmpW(szAll,argument)) + { + MSI_SetFeatureStateW(package,argument,INSTALLSTATE_LOCAL); + } + else + { + for (i = 0; i < package->loaded_features; i++) + { + package->features[i].ActionRequest = INSTALLSTATE_LOCAL; + package->features[i].Action = INSTALLSTATE_LOCAL; + } + ACTION_UpdateComponentStates(package,argument); + } + +} + +static VOID ControlEvent_Remove(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szAll[] = {'A','L','L',0}; + int i; + + if (strcmpW(szAll,argument)) + { + MSI_SetFeatureStateW(package,argument,INSTALLSTATE_ABSENT); + } + else + { + for (i = 0; i < package->loaded_features; i++) + { + package->features[i].ActionRequest = INSTALLSTATE_ABSENT; + package->features[i].Action= INSTALLSTATE_ABSENT; + } + ACTION_UpdateComponentStates(package,argument); + } +} + +static VOID ControlEvent_AddSource(MSIPACKAGE* package, LPCWSTR argument, + msi_dialog* dialog) +{ + static const WCHAR szAll[] = {'A','L','L',0}; + int i; + + if (strcmpW(szAll,argument)) + { + MSI_SetFeatureStateW(package,argument,INSTALLSTATE_SOURCE); + } + else + { + for (i = 0; i < package->loaded_features; i++) + { + package->features[i].ActionRequest = INSTALLSTATE_SOURCE; + package->features[i].Action = INSTALLSTATE_SOURCE; + } + ACTION_UpdateComponentStates(package,argument); + } +} + + +/* + * Subscribed events + */ +static void free_subscriber(struct _subscriber *who) +{ + HeapFree(GetProcessHeap(),0,who->control); + HeapFree(GetProcessHeap(),0,who->attribute); + HeapFree(GetProcessHeap(),0,who); +} + +VOID ControlEvent_SubscribeToEvent(MSIPACKAGE *package, LPCWSTR event, + LPCWSTR control, LPCWSTR attribute) +{ + int i; + struct _subscription_chain *chain; + struct _subscriber *subscriber, *ptr; + + if (!package->EventSubscriptions) + { + package->EventSubscriptions = HeapAlloc(GetProcessHeap(), 0, + sizeof(struct _subscriptions)); + package->EventSubscriptions->chain_count = 0; + } + + chain = NULL; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + if (strcmpiW(package->EventSubscriptions->chain[i].event,event)==0) + { + chain = &package->EventSubscriptions->chain[i]; + break; + } + } + + if (chain == NULL) + { + if (package->EventSubscriptions->chain_count) + chain = HeapReAlloc(GetProcessHeap(), 0, + package->EventSubscriptions->chain, + (package->EventSubscriptions->chain_count + 1) * + sizeof (struct _subscription_chain)); + else + chain= HeapAlloc(GetProcessHeap(),0, sizeof (struct + _subscription_chain)); + + package->EventSubscriptions->chain = chain; + chain = &package->EventSubscriptions->chain[ + package->EventSubscriptions->chain_count]; + package->EventSubscriptions->chain_count++; + memset(chain,0,sizeof(struct _subscription_chain)); + chain->event = strdupW(event); + } + + subscriber = ptr = chain->chain; + while (ptr) + { + subscriber = ptr; + ptr = ptr->next; + } + + ptr = HeapAlloc(GetProcessHeap(),0,sizeof(struct _subscriber)); + ptr->control = strdupW(control); + ptr->attribute = strdupW(attribute); + ptr->next = NULL; + + if (subscriber) + subscriber->next = ptr; + else + chain->chain = ptr; +} + +VOID ControlEvent_UnSubscribeToEvent(MSIPACKAGE *package, LPCWSTR event, + LPCWSTR control, LPCWSTR attribute) +{ + int i; + + if (!package->EventSubscriptions) + return; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + if (strcmpiW(package->EventSubscriptions->chain[i].event,event)==0) + { + struct _subscriber *who; + struct _subscriber *prev=NULL; + who = package->EventSubscriptions->chain[i].chain; + while (who) + { + if (strcmpiW(who->control,control)==0 + && strcmpiW(who->attribute,attribute)==0) + { + if (prev) + prev->next = who->next; + else + package->EventSubscriptions->chain[i].chain = who->next; + + free_subscriber(who); + } + else + { + prev = who; + who = who->next; + } + } + break; + } + } +} + +VOID ControlEvent_FireSubscribedEvent(MSIPACKAGE *package, LPCWSTR event, + MSIRECORD *data) +{ + int i; + + TRACE("Firing Event %s\n",debugstr_w(event)); + + if (!package->dialog) + return; + + if (!package->EventSubscriptions) + return; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + if (strcmpiW(package->EventSubscriptions->chain[i].event,event)==0) + { + struct _subscriber *who; + who = package->EventSubscriptions->chain[i].chain; + while (who) + { + ERR("Should Fire event for %s %s\n", + debugstr_w(who->control), debugstr_w(who->attribute)); + /* + msi_dialog_fire_subscribed_event(package->dialog, who->control, + who->attribute, data); + */ + who = who->next; + } + break; + } + } +} + +VOID ControlEvent_CleanupSubscriptions(MSIPACKAGE *package) +{ + int i; + + if (!package->EventSubscriptions) + return; + + for (i = 0; i < package->EventSubscriptions->chain_count; i++) + { + struct _subscriber *who; + struct _subscriber *ptr; + who = package->EventSubscriptions->chain[i].chain; + while (who) + { + ptr = who; + who = who->next; + free_subscriber(ptr); + } + HeapFree(GetProcessHeap(), 0, + package->EventSubscriptions->chain[i].event); + } + HeapFree(GetProcessHeap(),0,package->EventSubscriptions->chain); + HeapFree(GetProcessHeap(),0,package->EventSubscriptions); + package->EventSubscriptions = NULL; +} + + + +/* + * ACTION_DialogBox() + * + * Return ERROR_SUCCESS if dialog is process and ERROR_FUNCTION_FAILED + * if the given parameter is not a dialog box + */ +UINT ACTION_DialogBox( MSIPACKAGE* package, LPCWSTR szDialogName ) +{ + UINT r = ERROR_SUCCESS; + + if( package->next_dialog ) + ERR("Already a next dialog... ignoring it\n"); + package->next_dialog = NULL; + + /* + * Dialogs are chained by filling in the next_dialog member + * of the package structure, then terminating the current dialog. + * The code below sees the next_dialog member set, and runs the + * next dialog. + * We fall out of the loop below if we come across a modeless + * dialog, as it returns ERROR_IO_PENDING when we try to run + * its message loop. + */ + r = event_do_dialog( package, szDialogName ); + while( r == ERROR_SUCCESS && package->next_dialog ) + { + LPWSTR name = package->next_dialog; + + package->next_dialog = NULL; + r = event_do_dialog( package, name ); + HeapFree( GetProcessHeap(), 0, name ); + } + + if( r == ERROR_IO_PENDING ) + r = ERROR_SUCCESS; + + return r; +

1 0

Winedocs and Po4a dependencies
by Francois Gouget 26 May '05

26 May '05

For the Wine project we are trying to make it as easy as possible for Wine contributors to modify and rebuild the Wine documentation. The Po4a dependencies have caused some concern in this regard: for each dependency the contributor will have to track down which package to install for his distribution and this makes the initial setup significantly harder. Po4a being not very widespread we have checked it in the Winedocs CVS (http://cvs.sourceforge.net/viewcvs.py/wine/docs/). But Po4a has quite a few dependencies so this does not help very much. So now we are hoping to make it possible to reduce the number of po4a dependencies. Here is the list I came up with, together with some notes for each of them: * Locale::gettext (perl module) Needed by po4a for localization. Provided by liblocale-gettext-perl on Debian, perl-Locale-gettext on Mandrake and Fedora Core(DAG), perl-gettext on SUSE. Would you be open to a patch that acted as a wrapper around Locale::gettext so that po4a would continue to work untranslated if that module was missing? The idea we would add a 'Po4aGettext' module that would export gettext() and dgettext() functions. These would try to load Locale::gettext in an eval function and use it if that succeeds. Otherwise the Po4aGettext would simply return the untranslated strings. The only changes to the other Po4a modules would be replacing 'use Locale::gettext' with 'use Po4aGettext'. * Text::WrapI18N (perl module) Pure perl (so easy to check in) but depends on Text::CharWidth which is not pure perl. Provided by libtext-wrapi18n-perl on Debian. Found no RPM packages providing it. Text::WrapI18N was not used in po4a 0.16.2. I initially thought it was used to wrap the text being output to the .po and .sgml files but in fact it seems to only be used to print messages, warnings and errors. Why is it needed? Doesn't a simple print work fine? * Term::ReadKey (perl module) Provided by libterm-readkey-perl on Debian, perl-Term-ReadKey on Mandrake and Fedora Core(DAG), perl-TermReadKey on SUSE. This module is used to determine the size of the terminal. This information is then used by the wrap functions. * SGMLS (perl module) Needed by po4a to interface with the nsgmls parser. Pure perl (so easy to check in). Provided by libsgmls-perl on Debian, perl-SGMLSpm on Mandrake and Fedora Core, perl-SGMLS on SUSE. This is an essential part of po4a. The easiest way to remove this dependency would be to check it into the Winedocs repository. So no action needed on the Po4a side. * nsgmls (command line tool) Needed by po4a to parse the Sgml files. Provided by sp on Debian, sgml-tools or openjade on Mandrake and Fedora Core, opensp on SUSE. This is an essential part of po4a. So it will have to remain as a dependency which is reasonable. -- Francois Gouget fgouget(a)codeweavers.com

1 0

Nice work Mike M, and others
by Jeremy White 26 May '05

26 May '05

Folks, I saw the following blog entry: http://outflux.net/blog/archives/2005/05/25/ask-a-stupid-question/ (a Wine newbie praising the responsiveness of Wine developers) And I have to say that I thought it was one of the best testaments to our community I'd seen in a while. And I further have to say that it seems to me that a lot of folks (including many of them named Mike or Michael and many others too numerous to list), have really started going out of their way to help others to contribute to Wine. So I thought I'd simply say: Well done! Lord knows we can use all the help we can get <grin>. Cheers, Jeremy

1 0

Re: Write problem with MS Office 2003
by Juan Lang 26 May '05

26 May '05

Hi Stefan, --- Stefan D�siner <stefandoesinger(a)gmx.at> wrote: > How do I handle apidl == NULL? As far as I understand, apidl specifies a > list > of folders/files to be checked, right? If apidl == 0, what folder should > I > check. Is there some 'current folder' in the IShellFolder class? I > didn't > find any. Right, apidl can't be NULL if cidl is nonzero. If cidl is zero, you probably need the check to be in the caller. E.g. in shfldr_fs.c, the current folder is what calls SHELL32_GetItemAttributes, from IShellFolder_fnGetAttributesOf. Perhaps the dwAttributes member that's passed to InitializeEx sets the correct attributes for the current folder? I'm not sure. --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new Resources site http://smallbusiness.yahoo.com/resources/

4 14

IShellFolder::GetDisplayNameOf vs. SHGetPathFromIDList
by Michael Jung 26 May '05

26 May '05

Hi Alexandre, could you please give me a hint on this one: http://www.winehq.org/hypermail/wine-patches/2005/05/0567.html My guess is that you want me to write a test, showing that windows' comdlg32 does it this way. The problem is, I don't know how. We would have to temporarily register a shell namespace extension on Windows, then call one of the file dialogs and show that the GetDisplayNameOf method is called with the SHGDN_FORPARSING flag set, when the user selects a path from the extension. This would be a pretty complex test, which includes user interaction and thus doesn't fit into wine's test framework (or am I wrong?). Could you (or anybody on wine-devel) give me a hint? Thanks, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: MSXML: add some idl definitions (exposes a widl bug)
by Alexandre Julliard 26 May '05

26 May '05

Mike McCormack <mike(a)codeweavers.com> writes: > This patch demonstrates a problem with widl. This following > declaration fails to parse correctly, as "async" is detected as a > keyword, and disallowed as the name of a method in an interface. > > [propget, id(DISPID_XMLDOM_DOCUMENT_ASYNC)] > HRESULT async( [out,retval] VARIANT_BOOL *isAsync ); > > For the moment, I've hacked this by renaming "async" to "async_". Yes, keyword handling is broken. You can probably work around it by adding async to the list of keywords supported by the ident: token, but it would certainly be nice to fix this properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: docs/. configure.ac
by Francois Gouget 26 May '05

26 May '05

Dimi Paun wrote: [...] > Modified files: > . : configure.ac > > Log message: > Francois Gouget <fgouget(a)codeweavers.com> > Warn the user if docbook2html is missing. Offer hints as to which > packages he needs to install. > > > Old revision New revision Changes Path > 1.2 1.3 +12 -0 docs/configure.ac Hmm, you forgot to regenerate the configure script. The problem is my autoconf version is a bit different which results in extra changes. So I prefer not to send my configure diff and let you regenerate it... -- Francois Gouget fgouget(a)codeweavers.com

2 1

Re: avoid msvfw32 crash
by Alexandre Julliard 26 May '05

26 May '05

luis lenders <lgvlenders(a)yahoo.co.uk> writes: > Index: wine/dlls/msvideo/drawdib.c > =================================================================== > RCS file: /home/wine/wine/dlls/msvideo/drawdib.c,v > retrieving revision 1.24 > diff -u -p -r1.24 drawdib.c > --- wine/dlls/msvideo/drawdib.c 17 Jan 2005 15:33:43 -0000 1.24 > +++ wine/dlls/msvideo/drawdib.c 24 May 2005 19:09:28 -0000 > @@ -242,7 +242,10 @@ BOOL VFWAPI DrawDibBegin(HDRAWDIB hdd, > TRACE("Not compressed!\n"); > dwSize = lpbi->biSize + num_colours(lpbi)*sizeof(RGBQUAD); > whdd->lpbiOut = HeapAlloc(GetProcessHeap(), 0, dwSize); > - memcpy(whdd->lpbiOut, lpbi, dwSize); > + if (whdd->lpbiOut) > + memcpy(whdd->lpbiOut, lpbi, dwSize); > + else > + ret=FALSE; Sounds like we need a check that the number of colors is reasonable. The HeapAlloc shouldn't normally fail except if the size is bogus. -- Alexandre Julliard julliard(a)winehq.org

1 0

MSI gui questions
by Stefan Dösinger 26 May '05

26 May '05

Hello, The native windows installer has support for a gui, but Wine's msi doesn't (yet). I had a look at this, and it seems that there are already some functions in dlls/msi/dialog.c which are for GUI handling. I had a look at the msi documentation in the MSDN. It appears to me that most dialogs are implemented in the msi file. Well, I tried to implement the PreActionDialog ACTION. I had no problem in adding a new function for that action. According to my observations, I have to call msi_dialog_create with the name of the dialog I want to create. Is there any reference about the dialogs' names? Do I have to write those dialogs(create the GUI), or is this done by the code in the .msi file? Thanks for your help, Stefan

2 1

Re: check for mkdir mode
by Dmitry Timoshkov 26 May '05

26 May '05

"Steven Edwards" <steven_ed4153(a)yahoo.com> wrote: > +int sys_mkdir(const char *path, mode_t mode) > +{ > +#ifdef HAVE_MKDIR_MODE > + return mkdir(path, mode); > +#else > + return mkdir(path); > +#endif > +} Wouldn't it be better to emulate mkdir(path, mode); with mkdir(path); chmod(path, mode); -- Dmitry.

2 1

Wine on Sparc
by Chuck Hall 26 May '05

26 May '05

Greetings, I have heard that people are using Wine on Solaris. I would like to know if they are using Wine on the SPARC version or the x86 version of Solaris? There does seem to be code within Wine to have it run on SPARC machines, but it currently does not seem to compile, at least on the Solaris version. I have attached a small patch that allows me to get throught the 'make depend' section of the compile. Since it is my first patch, please look at and let me know what I did wrong :) Have Fun! Chuck Hall

5 10

Question about advapi32/eventlog.c
by David Hemmo 25 May '05

25 May '05

Hello The stubs in eventlog.c return an odd value (0xcafe4242) instead of NULL. For example, in RegisterEventSourceW, NULL would be an error and would mean the register did not work. The current value doesn't tell the application that it didn't work. Is there a reason ? Thanks David Hemmo

2 1

Re: Fix Sparse Warnings for server/ (Try 2)
by Alexandre Julliard 25 May '05

25 May '05

Robert Shearman <rob(a)codeweavers.com> writes: > --- server/fd.c 24 Apr 2005 17:35:52 -0000 1.37 > +++ server/fd.c 24 May 2005 18:37:28 -0000 > @@ -898,18 +898,6 @@ static void remove_lock( struct file_loc > release_object( lock ); > } > > -/* remove all locks owned by a given process */ > -void remove_process_locks( struct process *process ) > -{ > - struct list *ptr; > - > - while ((ptr = list_head( &process->locks ))) > - { > - struct file_lock *lock = LIST_ENTRY( ptr, struct file_lock, proc_entry ); > - remove_lock( lock, 1 ); /* this removes it from the list */ > - } > -} > - Something's not right, that function should be used somewhere. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Resend: Fix ole32:moniker test for NT4
by Alexandre Julliard 25 May '05

25 May '05

Richard Cohen <richard(a)daijobu.co.uk> writes: > Rediffed against HEAD > > Richard Cohen wrote: > > ... and almost certainly Win9x, 2k, XP > > Changelog: > > + IEnum::Clone shouldn't do a Reset. > > + Don't assume the ROT is already empty when testing The tests fail here: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so moniker.c && touch moniker.ok moniker.c:139: Test failed: Number of matches should be equal to 2 not 0 moniker.c:146: Test failed: Number of matches should be equal to 2 not 0 make[3]: *** [moniker.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: DirectX 9 patches
by Andreas 'GlaDiaC' Schneider 25 May '05

25 May '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, it was playable (with models) with -dxlevel 90 on Wine 20040310 and it is simple to install with installshield :) MSI: http://www.frankscorner.org/index.php?p=ishield http://www.frankscorner.org/index.php?p=msi HL2 Shots: http://www.cynapses.org/tmp/hl2_shots/ The _problem_ will be always Steam :) My Steam doesn't work since the last Steam update. Cheers, -- andreas > Okay, more info and screenshots over here: > > http://ivan.ivg2.net/hl2/ > > It's not playable, but it's exciting that > it gets this far in the first place! > > ...it has to be installed through Steam (since msi won't work). > > -- > > Ivan Gyurdiev <ivg2_at_cornell.edu> > Cornell University - -- http://www.linux-gamers.net - your online gaming resource -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFClGSFf94+j/M+P8YRAglpAKCLGaA92PoeqIQHvPcd0WyRfd/EAgCcCBIW Nbnr8xwdz+y2tksCpTBekkk= =hHXs -----END PGP SIGNATURE-----

1 0

Release notes
by Mike Hearn 25 May '05

25 May '05

Hi guys, Raphael pointed out on IRC that the great OpenGL work that went into the last release wasn't mentioned in the "What's new" list that goes out with each snapshot. As it's unreasonable to expect Alexandre to remember or mention every large piece of work that goes into any given release, how about we use the Wiki to note big items as they are checked into CVS. By "big item" I mean either: - Large improvements to a particular subsystem - Adding "gold" compatibility with a well known app - Some other end-user interesting feature For instance, I'd say "header cleanups" are less interesting to users than "OpenGL improvements for Warcraft". That's not a criticism of Alexandre, it's totally reasonable that he puts things in that he can quickly remember and as he's closer to parts of the system like import libraries and headers it's natural that this is what springs to mind first. But we can do better. If people think it's a good idea, I'll create a scratchpad page on the Wiki we can use for the next release. Anybody should be able to add things that are "big", then when doing a release Alexandre can pick and choose the ones he thinks are best to put in What's New. Thoughts? thanks -mike

2 2

Bug 469 - Application can not read from serial port
by Dustin Navea 25 May '05

25 May '05

Hey guys, this one was (obviously) reported a while back, and the offending patch was found a while back as well, but it appears that mike (at codeweavers dot com) never was able to get around to it.. Basically it is an issue that a solar panel reading application cant retrieve information via the serial port. I have requested that someone test it (the demo of the app is attached to the bug) on a recent wine build. So hopefully it is working now, and if not, maybe it will be trivial? Either way, the name of the program looks to be SunGoXL, and perhaps there is a more recent version of the program that allows it to run in wine, if the older one doesn't work. The changelog for the patch is: cvs log files/file.c Mike McCormack <mike_mccormack(a)start.com.au> Read data immediately in overlapped ReadFile if possible. From the most recent traces we have that show the problem, it looks as though the GetOverlappedResult function is waiting on something (probably the solar equipment) to be returned, but it never does, so maybe at the time (if not still now) wine was unable to use the serial port for whatever reason? Other people could test the program, but if it is something to do with serial communication with solar equipment, it wouldn't make any sense, unless that someone else has the same equipment and issue... Maybe the reporter still checks that email, and can test it out... If theres no activity on the bug in 1 month, I will resolve it abandoned.. Dustin

3 2

Bug 2977 - Homeworld 2 wont launch
by Dustin Navea 25 May '05

25 May '05

Hey guys, this bug was reported, but recently (without updating wine from what I can tell), the reporter updated the kernel with yum.. After doing so, the game launches perfectly (except for the copy protection getting in the way).. Any comments on why this might happen? The reporter should be subscribing shortly, so he can probably post info about it. Dustin

1 0

Re: [dbghelp] dwarf2 support progress step 5
by Alexandre Julliard 24 May '05

24 May '05

Raphael <fenix(a)club-internet.fr> writes: > Hi, > > This times symt model construction seems good :) > > But for debug lines, i don't really understand the sm/regs concept :( > > Changelog: > - implement dwarf2_find_symt_by_ref and dwarf2_add_symt_ref using hashtables > - some debug lines defines > - handle forwards references (ie dwarf2_find_symt_by_ref returns NULL) using > ref hashtable > - better traces It doesn't compile, you probably forgot part of the diff: elf_module.c: In function `elf_load_debug_info_from_map': elf_module.c:901: too few arguments to function `dwarf2_parse' make: *** [elf_module.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Help with winelib and development
by Afkhampour, Cyrus 24 May '05

24 May '05

Hi I am trying to learn how to use winelib/wine as I am trying to port a piece of code from windows to Linux and was told that wine might be the tool to use. I have downloaded wine and begna the winelib tutorial but now I can not find the winemaker file to save my life. Can someone explain what I am missing?

2 1

Compiling with winelib
by antonio.fernandez.moreno＠dmr-consulting.com 24 May '05

24 May '05

Hello, Im trying to compile with winelib the notepad following the steps in the user guide. When I run the make command, the compiler gives me errors with the .rc files. Then I try to compile without these files and the compiler gives me the next error: bash-2.03$ make gcc -c -I. -I/usr/local/include/wine/windows -g -O2 -fPIC -D_REENTRANT -o dialog.o dialog.c LD_LIBRARY_PATH=":$LD_LIBRARY_PATH" /usr/local/bin/winebuild -fPIC -o notepad2.exe.spec.c --exe notepad2.exe -mgui License_En.o dialog.o license.o main.o notepad.exe.dbg.o -L/usr/local/lib -L/usr/local/lib/wine -ladvapi32 -lcomdlg32 -lgdi32 -lkernel32 -lodbc32 -lole32 -loleaut32 -lshell32 -luser32 -lwinspool gcc -c -I. -I/usr/local/include/wine/windows -g -O2 -fPIC -D_REENTRANT -o notepad2.exe.spec.o notepad2.exe.spec.c gcc -shared -Wl,-Bsymbolic -o notepad2.exe.so License_En.o dialog.o license.o main.o notepad.exe.dbg.o notepad2.exe.spec.o -lwine -lwine_unicode -lwine_uuid -lsocket -lw -lm dialog.o: In function `DIALOG_FilePrint': /opt/cfw/wine/programs/notepad2/dialog.c:380: undefined reference to `strcpy' /opt/cfw/wine/programs/notepad2/dialog.c:381: undefined reference to `strlen' dialog.o: In function `DIALOG_SelectFont': /opt/cfw/wine/programs/notepad2/dialog.c:675: undefined reference to `memcpy' /opt/cfw/wine/programs/notepad2/dialog.c:688: undefined reference to `memcpy' dialog.o: In function `DIALOG_Search': /opt/cfw/wine/programs/notepad2/dialog.c:697: undefined reference to `memset' main.o: In function `NOTEPAD_InitData': /opt/cfw/wine/programs/notepad2/main.c:100: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:102: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:104: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:106: undefined reference to `strlen' main.o: In function `HandleCommandLine': /opt/cfw/wine/programs/notepad2/main.c:205: undefined reference to `printf' /opt/cfw/wine/programs/notepad2/main.c:221: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:231: undefined reference to `strlen' /opt/cfw/wine/programs/notepad2/main.c:231: undefined reference to `strcmp' /opt/cfw/wine/programs/notepad2/main.c:238: undefined reference to `strncpy' /opt/cfw/wine/programs/notepad2/main.c:239: undefined reference to `strcat' main.o: In function `WinMain': /opt/cfw/wine/programs/notepad2/main.c:276: undefined reference to `memset' test -f notepad2 || install wineapploader notepad2 find: no es posible abrir notepad2: No existe tal archivo o directorio find: no es posible seguir enlace simbólico /etc/wtmpx: No existe tal archivo o directorio install: wineapploader was not found anywhere! make: *** [notepad2.exe.so] Error 2 This error appears because I have not the include <string.h> line. Wont winelib must link with this file when I compile? Im using this version of Wine: Wine-20030618.tar.gz in a Solaris 8 (SPARC) How can I know if winelib is correctly installed? Thank you. Antonio Fernández.

2 1

Bugzilla wiki
by Dustin Navea 24 May '05

24 May '05

Hey everyone, I've just finished the bugzilla wiki.. If anyone has any comments or changes, go ahead and post them. Alexandre, Jeremy, is there any chance that a link to the bugzilla wiki could be put into the sidebars for the winehq main page and the bugzilla main page? That way people can read that, as it has some preferred guidelines on posting (including initial bug reports). If we can get a link there, or at least in the docs, it should cut down on some of the dupes I have been getting, and also make it easier to diagnose bugs. Todo: * find out _every_ valid flag that can be passed to wine via the WINEDEBUG= variable * post them into a separate wiki * post a link from the bugzilla wiki to that new wiki If anyone wants to start emailing me flags and what they do or can be useful for tracing, feel free, and I will get the wiki page started either tonight or tomorrow. Dustin

2 1

Re: ITSS Conformance Test Patch
by Dimi Paun 24 May '05

24 May '05

From: "Chris Watmore" <chris.watmore(a)gmail.com> > This patch adds tests for the itss dll. Please no Perl or Shell scripts -- they will not run on Windows, where we ship tests via winetest. Just code them in C, it shouldn't be too hard. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 1

question about standalone tests
by Kees Cook 24 May '05

24 May '05

Hi! My crypt32 protectdata tests were just added to CVS (thanks!) but they were added without the #ifndef STANDALONE stuff that exists in the recommended example from the lzexpand test code. The steps here: http://www.winehq.com/site/docs/wine-devel/testing-windows don't have a method for doing the build with the free-of-charge windows CLI compiler (which the "STANDALONE" stuff works fine with). Is there some new way to build standalone tests, or should I send a patch for re-including the #ifndef STANDALONE stuff for the tests? -- Kees Cook @outflux.net

3 3

PowerPaint not working
by Andrew Neil Ramage 24 May '05

24 May '05

I installed PowerPaint (free on thw Net, somewhere) OK, but when I try to run it I get a message box telling me the installation is corrupt, and the following output from Wine. andrew@zeus:~/.wine/drive_c/Program Files/FLISoft/PowerPaint> wine PowerPaint.exe fixme:shell:SHGetFileInfoW set icon to shell size, stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoCreateInstance no classfactory created for CLSID {47ad7e45-ba98-47e4-887f-9ab7a07f7d4d}, hres is 0x80040150 fixme:ole:CoRegisterMessageFilter stub I am using the latest CVS of Wine. -- Andrew You can be the captain I will draw the chart Sailing into destiny Closer to the heart Closer to the Heart by Rush (A Farewell to Kings, 1977) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 0

qcap/avicap and driver models
by Maarten Lankhorst 24 May '05

24 May '05

Hi Alexandre, I implemented a driver model in qcap now, but avicap32 still uses my old #ifdef LINUX_VIDEODEV_H, since some people might be interested in writing capcreatecapturewindow, I think we should move out the drivers from qcap to our own vfwwine dll/driver, windows uses a similar model for it, as rolf kalbermatter pointed out in http://www.winehq.com/?issue=274#Video%20Capture%20in%20Windows For the qcap drivers, I used some kind of COM model typedef struct capturefunctions { ... Video_SetMediaType SetFormat; ... void *pMine; } Capture; First, it tries to initialise, and lets the constructor function fill this struct, then if something is needed, it just calls Capture->SetFormat(Capture->pMine, parameters..), this is the qcap implementation, but I'm sure that if I write some parts of it so it will be DirectShow indepent, it can be used by avicap and qcap, I'm not really interested in avicap, but in the very least capgetdriverdescription should use the same code as qcap, because writing the same twice would mean a huge overhead. So basically, I'm just wondering what to do, should I go ahead with the seperate driver dll or should I do something else? Maarten

3 2

Re: [dbghelp] dwarf2 support progress step 5
by Pouech Eric DMI AEI CAEN 24 May '05

24 May '05

> > > > Changelog: > > - implement dwarf2_find_symt_by_ref and dwarf2_add_symt_ref using hashtables > > - some debug lines defines > > - handle forwards references (ie dwarf2_find_symt_by_ref returns NULL) using > > ref hashtable > > - better traces > > It doesn't compile, you probably forgot part of the diff: > > elf_module.c: In function `elf_load_debug_info_from_map': > elf_module.c:901: too few arguments to function `dwarf2_parse' > make: *** [elf_module.o] Error 1 I also would like to review in details the patch (especially why we need to change the inner interfaces in types.c and symbol.c) [there are forward declarations in MSC and stabs parsing and we don't need the hack included here] A+

1 0

Re: [RESENT] MSVCRT: Lower Error level of _spawnve
by Alexandre Julliard 24 May '05

24 May '05

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > @@ -448,7 +448,9 @@ > const char *fullname = name; > int ret = -1; > > - FIXME(":not translating name %s to locate program\n",fullname); > + /* Is this really a WARN? Native msvcrt doesn't seem to translate the argumentsd neither > + bon(a)elektron.ikp.physik.tu-darmstadt.de 050516 */ > + WARN(":not translating name %s to locate program\n",fullname); Yes, native does transformations on the program name, like looking for .bat, .cmd etc. if there is no extension. That FIXME should remain until this is fixed properly. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winedump: Print file offset instead of obscure 'prefix' while dumping data
by Pouech Eric DMI AEI CAEN 24 May '05

24 May '05

> > > Print file offset instead of obscure 'prefix' while dumping data. > > prefix is used to properly indent the output of the dump, so you do want to keep > > the prefix (this doesn't prevent you from adding the offsets for dumps) > > The offset is going to replace the prefix, not to coexist with it. > Are you objecting to it? yes, you're loosing the identation of the data-dump that prefix provided A+

1 0

Bug 2660
by Dustin Navea 24 May '05

24 May '05

This is more directed toward Jason, but I figure everyone should see it. As comments 9-11 note in this bug, the notes mentioned in http://www.winehq.org/hypermail/wine-devel/2005/05/0420.html and the resulting patch that was attached to the bug do fix the problem. I'm not sure if the patch has been committed to CVS, but if it hasn't it probably should before the next wine release... If it has, please post a note to the bug and I will resolve it, referencing to get the next wine release when it comes out, or CVS if someone can't wait.. Dustin

4 3

XEmbed embeder support in Wine
by Jacek Caban 24 May '05

24 May '05

Hello. As I'm working on getting MSHTML to work using Linux Gecko, I need support of XEmbed embedding in Wine. It can be also useful for Winelib applications (and maybe in future for some other parts of Wine) to show the X11 windows in Wine. My current version of XEmbed patch and a simple test application that creates gtk button inside Wine window is attached. Using this patch I can display Gecko in the Wine window (now only in my test application, but I'm working on integrating it with MSHTML). The way I want to do it is: 1. Wine application creates window of "_XEMBED" class 2. Embedding window can be done in two ways (as in specification): - Wine application sends _WM_ATTACH_WINDOW message passing X11 Window (not yet implemented) or - Client window is created as a child window of Wine window 3. Window is displayed and Wine communicates with X11 window using XEmbed protocol I know my patch needs some polishing and more implementations (focus, activating, handling unmapping of window....), but I'd like to know if the way I do it is proper? What needs to be done for the first patch to be accepted? Thanks, Jacek ? dlls/x11drv/diff ? dlls/x11drv/xembed.c Index: dlls/x11drv/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/x11drv/Makefile.in,v retrieving revision 1.43 diff -u -p -r1.43 Makefile.in --- dlls/x11drv/Makefile.in 6 May 2005 19:38:50 -0000 1.43 +++ dlls/x11drv/Makefile.in 23 May 2005 19:26:25 -0000 @@ -40,6 +40,7 @@ C_SRCS = \ xdnd.c \ xfont.c \ xim.c \ + xembed.c \ xrandr.c \ xrender.c \ xvidmode.c Index: dlls/x11drv/event.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/event.c,v retrieving revision 1.54 diff -u -p -r1.54 event.c --- dlls/x11drv/event.c 24 Mar 2005 20:41:28 -0000 1.54 +++ dlls/x11drv/event.c 23 May 2005 19:26:27 -0000 @@ -98,7 +98,7 @@ static struct event_handler handlers[MAX /* GraphicsExpose */ /* NoExpose */ /* VisibilityNotify */ - /* CreateNotify */ + { CreateNotify, X11DRV_CreateNotify }, /* DestroyNotify */ { UnmapNotify, X11DRV_UnmapNotify }, { MapNotify, X11DRV_MapNotify }, @@ -875,7 +875,6 @@ static void handle_dnd_protocol( HWND hw EVENT_DropURLs(hwnd, event); } - struct client_message_handler { int atom; /* protocol atom */ @@ -889,7 +888,8 @@ static const struct client_message_handl { XATOM_XdndEnter, X11DRV_XDND_EnterEvent }, { XATOM_XdndPosition, X11DRV_XDND_PositionEvent }, { XATOM_XdndDrop, X11DRV_XDND_DropEvent }, - { XATOM_XdndLeave, X11DRV_XDND_LeaveEvent } + { XATOM_XdndLeave, X11DRV_XDND_LeaveEvent }, + { XATOM__XEMBED, X11DRV_XEmbed_protocol } }; Index: dlls/x11drv/window.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/window.c,v retrieving revision 1.108 diff -u -p -r1.108 window.c --- dlls/x11drv/window.c 26 Apr 2005 08:16:17 -0000 1.108 +++ dlls/x11drv/window.c 23 May 2005 19:26:28 -0000 @@ -97,6 +97,8 @@ static const char * const atom_names[NB_ "XdndSelection", "XdndTarget", "XdndTypeList", + "_XEMBED", + "_XEMBED_INFO", "WCF_DIB", "image/gif", "text/html", @@ -183,7 +185,8 @@ static int get_window_attributes( struct attr->event_mask = (ExposureMask | PointerMotionMask | ButtonPressMask | ButtonReleaseMask | EnterWindowMask | KeyPressMask | KeyReleaseMask | StructureNotifyMask | - FocusChangeMask | KeymapStateMask); + FocusChangeMask | KeymapStateMask | + SubstructureNotifyMask); return (CWOverrideRedirect | CWSaveUnder | CWEventMask | CWColormap | CWCursor); } Index: dlls/x11drv/x11drv.h =================================================================== RCS file: /home/wine/wine/dlls/x11drv/x11drv.h,v retrieving revision 1.72 diff -u -p -r1.72 x11drv.h --- dlls/x11drv/x11drv.h 21 Apr 2005 17:31:50 -0000 1.72 +++ dlls/x11drv/x11drv.h 23 May 2005 19:26:28 -0000 @@ -288,6 +288,9 @@ extern void X11DRV_XDND_PositionEvent( H extern void X11DRV_XDND_DropEvent( HWND hWnd, XClientMessageEvent *event ); extern void X11DRV_XDND_LeaveEvent( HWND hWnd, XClientMessageEvent *event ); +extern void X11DRV_XEmbed_protocol(HWND, XClientMessageEvent*); +extern void X11DRV_XEmbed_Init(); + /* exported dib functions for now */ /* DIB Section sync state */ @@ -586,6 +589,8 @@ enum x11drv_atoms XATOM_XdndSelection, XATOM_XdndTarget, XATOM_XdndTypeList, + XATOM__XEMBED, + XATOM__XEMBED_INFO, XATOM_WCF_DIB, XATOM_image_gif, XATOM_text_html, @@ -621,6 +626,7 @@ extern void X11DRV_MappingNotify( HWND h extern void X11DRV_DGAMotionEvent( HWND hwnd, XEvent *event ); extern void X11DRV_DGAButtonPressEvent( HWND hwnd, XEvent *event ); extern void X11DRV_DGAButtonReleaseEvent( HWND hwnd, XEvent *event ); +extern void X11DRV_CreateNotify( HWND hwnd, XEvent *event ); extern DWORD EVENT_x11_time_to_win32_time(Time time); Index: dlls/x11drv/x11drv_main.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/x11drv_main.c,v retrieving revision 1.103 diff -u -p -r1.103 x11drv_main.c --- dlls/x11drv/x11drv_main.c 21 Apr 2005 17:31:50 -0000 1.103 +++ dlls/x11drv/x11drv_main.c 23 May 2005 19:26:29 -0000 @@ -384,6 +384,9 @@ static BOOL process_attach(void) X11DRV_InitKeyboard(); + /* initialize XEmbed */ + X11DRV_XEmbed_Init(); + return TRUE; } @@ -483,7 +486,6 @@ struct x11drv_thread_data *x11drv_init_t if (desktop_tid) AttachThreadInput( GetCurrentThreadId(), desktop_tid, TRUE ); return data; } - /*********************************************************************** * X11DRV initialisation routine ? dlls/user/diff Index: dlls/user/user_main.c =================================================================== RCS file: /home/wine/wine/dlls/user/user_main.c,v retrieving revision 1.83 diff -u -p -r1.83 user_main.c --- dlls/user/user_main.c 6 May 2005 19:38:50 -0000 1.83 +++ dlls/user/user_main.c 23 May 2005 19:26:39 -0000 @@ -260,6 +260,9 @@ static BOOL process_attach(void) /* some Win9x dlls expect keyboard to be loaded */ if (GetVersion() & 0x80000000) LoadLibrary16( "keyboard.drv" ); + /* Initialize built-in window classes */ + CLASS_RegisterBuiltinClasses(); + /* Load the graphics driver */ if (!load_driver()) return FALSE; @@ -268,9 +271,6 @@ static BOOL process_attach(void) /* Setup palette function pointers */ palette_init(); - - /* Initialize built-in window classes */ - CLASS_RegisterBuiltinClasses(); /* Initialize menus */ if (!MENU_Init()) return FALSE; --- /dev/null 1970-01-01 01:00:00.000000000 +0100 +++ dlls/x11drv/xembed.c 2005-05-23 21:23:42.000000000 +0200 @@ -0,0 +1,385 @@ +/* + * Copyright 2005 Jacek Caban + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include "config.h" + +#include <X11/Xlib.h> + +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "wine/debug.h" + +#include "x11drv.h" + +#define XEMBED_EMBEDDED_NOTIFY 0 +#define XEMBED_WINDOW_ACTIVATE 1 +#define XEMBED_WINDOW_DEACTIVATE 2 +#define XEMBED_REQUEST_FOCUS 3 +#define XEMBED_FOCUS_IN 4 +#define XEMBED_FOCUS_OUT 5 +#define XEMBED_FOCUS_NEXT 6 +#define XEMBED_FOCUS_PREV 7 +#define XEMBED_MODALITY_ON 10 +#define XEMBED_MODALITY_OFF 11 +#define XEMBED_REGISTER_ACCELERATOR 12 +#define XEMBED_UNREGISTER_ACCELERATOR 13 +#define XEMBED_ACTIVATE_ACCELERATOR 14 + +#define XEMBED_FOCUS_CURRENT 0 +#define XEMBED_FOCUS_FIRST 1 +#define XEMBED_FOCUS_LAST 2 + +#define XEMBED_MAPPED 1 + +#define _WM_ATTACH_WINDOW WM_USER+600 + +WINE_DEFAULT_DEBUG_CHANNEL(xembed); + +typedef struct wnd_list_t { + HWND hwnd; + struct wnd_list_t *next; +} wnd_list_t; + +static wnd_list_t *wnd_list = NULL; + +static void wnd_list_add(HWND hwnd) +{ + wnd_list_t *new = HeapAlloc(GetProcessHeap(), 0, sizeof(wnd_list_t)); + new->hwnd = hwnd; + new->next = wnd_list; + wnd_list = new; +} + +static void wnd_list_remove(HWND hwnd) +{ + wnd_list_t *iter = wnd_list; + + if(!iter) + return; + + if(iter->hwnd == hwnd) { + wnd_list = iter->next; + HeapFree(GetProcessHeap(), 0, iter); + }else { + while(iter->next && iter->next->hwnd != hwnd) + iter = iter->next; + if(iter->next) { + wnd_list_t *tmp = iter->next; + iter->next = tmp->next; + HeapFree(GetProcessHeap(), 0, tmp); + } + } +} + +BOOL check_xembed_info(Display *display, Window win, unsigned long *version, long unsigned *flags) +{ + Atom type; + int format, res; + unsigned long nitems, bytes_after, *data; + + wine_tsx11_lock(); + res = XGetWindowProperty(display, win, x11drv_atom(_XEMBED_INFO), 0, 2, False, + x11drv_atom(_XEMBED_INFO), &type, &format, &nitems, &bytes_after, (unsigned char**)&data); + wine_tsx11_unlock(); + + if(res != Success || !format) { + TRACE("Could not get _XEMBED_INFO\n"); + XFree(data); + return FALSE; + } + + *version = data[0]; + *flags = data[1]; + + XFree(data); + + TRACE("got version=%08lx flags=%08lx\n", *version, *flags); + return TRUE; +} + +static void xembed_client_show(Display *display, HWND hwnd, BOOL show) +{ + Window window = (Window)GetPropA(hwnd, "__wine_x11_client_window"); + + TRACE("(%p %p %x) window=%08lx\n", display, hwnd, show, window); + + if(!window) + return; + + if(!display) + display = ((struct x11drv_thread_data*)NtCurrentTeb()->driver_data)->display; + + wine_tsx11_lock(); + if(show) + XMapWindow(display, window); + else + XUnmapWindow(display, window); + wine_tsx11_unlock(); +} + +static void xembed_client_set_position(Display *display, HWND hwnd) +{ + Window window = (Window)GetPropA(hwnd, "__wine_x11_client_window"); + HWND parent = (HWND)GetPropA(hwnd, "__wine_x11_embedder_window_hwnd"); + WINDOWINFO wininfo, parent_wininfo; + + TRACE("(%p %p) window=%08lx, parent=%p\n", display, hwnd, window, parent); + + if(!window) + return; + + if(!display) + display = ((struct x11drv_thread_data*)NtCurrentTeb()->driver_data)->display; + + wininfo.cbSize = sizeof(WINDOWINFO); + parent_wininfo.cbSize = sizeof(WINDOWINFO); + GetWindowInfo(hwnd, &wininfo); + GetWindowInfo(parent, &parent_wininfo); + + wine_tsx11_lock(); + XMoveWindow(display, window, + wininfo.rcClient.left - parent_wininfo.rcClient.left, + wininfo.rcClient.top - parent_wininfo.rcClient.top); + wine_tsx11_unlock(); +} + +static void xembed_client_set_size(Display *display, HWND hwnd) +{ + Window window = (Window)GetPropA(hwnd, "__wine_x11_client_window"); + RECT rect; + + TRACE("(%p %p) window=%08lx\n", display, hwnd, window); + + if(!window) + return; + + if(!display) + display = ((struct x11drv_thread_data*)NtCurrentTeb()->driver_data)->display; + + GetClientRect(hwnd, &rect); + + wine_tsx11_lock(); + XResizeWindow(display, window, rect.right, rect.bottom); + wine_tsx11_unlock(); +} + +static void send_xembed_event(Display *display, Window window, int message, + unsigned long detail, unsigned long data1, unsigned long data2) +{ + XClientMessageEvent event; + + event.type = ClientMessage; + event.window = window; + event.message_type = x11drv_atom(_XEMBED); + event.format = 32; + event.data.l[0] = 0; /* FIXME */ + event.data.l[1] = message; + event.data.l[2] = detail; + event.data.l[3] = data1; + event.data.l[4] = data2; + + wine_tsx11_lock(); + XSendEvent(display, window, False, NoEventMask, (XEvent*)&event); + wine_tsx11_unlock(); +} + +static LRESULT attach_window(HWND hwnd, Window window) { + struct x11drv_thread_data *data = NtCurrentTeb()->driver_data; + unsigned long version = 0, flags = XEMBED_MAPPED; + + TRACE("(%p %lx)\n", hwnd, window); + + SetPropA(hwnd, "__wine_x11_client_window", (LPVOID)window); + + check_xembed_info(data->display, window, &version, &flags); + + /* FIXME: handle XEmbed version correctly (until there is only version 0 it's not really important) */ + send_xembed_event(data->display, window, XEMBED_EMBEDDED_NOTIFY, 0, + (Window)GetPropA(hwnd, "__wine_x11_embedder_window"), 0); + + if(!(flags & XEMBED_MAPPED)) { + unsigned int prop[] = {0, XEMBED_MAPPED}; + XChangeProperty(data->display, window, x11drv_atom(_XEMBED_INFO), + XA_CARDINAL, 32, PropModeReplace, + (unsigned char*)prop, 2); + } + + xembed_client_set_position(data->display, hwnd); + xembed_client_set_size(data->display, hwnd); + + if(IsWindowVisible(hwnd)) + xembed_client_show(data->display, hwnd, TRUE); + + send_xembed_event(data->display, window, XEMBED_WINDOW_ACTIVATE, 0, 0, 0); + send_xembed_event(data->display, window, XEMBED_FOCUS_IN, XEMBED_FOCUS_FIRST, 0, 0); + + return 0; +} + +HWND find_hwnd_for_window(Window parent) +{ + wnd_list_t *iter; + + TRACE("(%08lx)\n", parent); + + /* + * FIXME: + * We attach the window to the first HWND on the list. It would be better + * to have some kind of a filter (callback function or a message to parent?) + * determining which HWND to select. + */ + for(iter = wnd_list; iter; iter = iter->next) { + if(!GetPropA(iter->hwnd, "__wine_x11_client_window") + && (Window)GetPropA(iter->hwnd, "__wine_x11_embedder_window") == parent) + break; + } + + if(!iter) { + WARN("Not found embedder window\n"); + return NULL; + } + + TRACE("Fount hwnd %p\n", iter->hwnd); + return iter->hwnd; +} + +/********************************************************************** + * X11DRV_CreateNotify + */ +void X11DRV_CreateNotify(HWND hwnd, XEvent *event) +{ + HWND embed_hwnd; + + TRACE("(%p %p) window = %lx\n", hwnd, event, event->xcreatewindow.window); + + embed_hwnd = find_hwnd_for_window(event->xcreatewindow.parent); + if(embed_hwnd) + attach_window(embed_hwnd, event->xcreatewindow.window); +} + +/********************************************************************** + * X11DRV_XEmbed_protocol + */ +void X11DRV_XEmbed_protocol(HWND hwnd, XClientMessageEvent *event) { + switch(event->data.l[1]) { + case XEMBED_EMBEDDED_NOTIFY: + TRACE("XEMBED_EMBEDDED_NOTIFY\n"); + break; + case XEMBED_WINDOW_ACTIVATE: + TRACE("XEMBED_WINDOW_ACTIVATE\n"); + break; + case XEMBED_WINDOW_DEACTIVATE: + TRACE("XEMBED_WINDOW_DEACTIVATE\n"); + break; + case XEMBED_REQUEST_FOCUS: + TRACE("XEMBED_REQUEST_FOCUS\n"); + break; + case XEMBED_FOCUS_IN: + TRACE("XEMBED_FOCUS_IN\n"); + break; + case XEMBED_FOCUS_OUT: + TRACE("XEMBED_FOCUS_OUT\n"); + break; + case XEMBED_FOCUS_NEXT: + TRACE("XEMBED_FOCUS_NEXT\n"); + break; + case XEMBED_FOCUS_PREV: + TRACE("XEMBED_FOCUS_PREV\n"); + break; + case XEMBED_MODALITY_ON: + TRACE("XEMBED_MODALITY_ON\n"); + break; + case XEMBED_MODALITY_OFF: + TRACE("XEMBED_MODALITY_OFF\n"); + break; + case XEMBED_REGISTER_ACCELERATOR: + TRACE("XEMBED_REGISTER_ACCELERATOR\n"); + break; + case XEMBED_UNREGISTER_ACCELERATOR: + TRACE("XEMBED_UNREGISTER_ACCELERATOR\n"); + break; + case XEMBED_ACTIVATE_ACCELERATOR: + TRACE("XEMBED_ACTIVATE_ACCELERATOR\n"); + break; + }; +} + +/********************************************************************** + * XEmbed_WndProc + */ +static LRESULT WINAPI XEmbed_WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) +{ + switch(msg) { + case WM_CREATE: { + HWND parent; + Window window; + + TRACE("(%p) WM_CREATE\n", hwnd); + parent = hwnd; + + while(!(window = (Window)GetPropA(parent, "__wine_x11_whole_window"))) + parent = GetParent(parent); + + TRACE("x11 window = %08lx\n", window); + + SetPropA(hwnd, "__wine_x11_embedder_window", (LPVOID)window); + SetPropA(hwnd, "__wine_x11_embedder_window_hwnd", (LPVOID)parent); + wnd_list_add(hwnd); + break; + } + case WM_DESTROY: + TRACE("(%p) WM_DESTROY\n", hwnd); + wnd_list_remove(hwnd); + break; + case WM_SHOWWINDOW: + xembed_client_show(NULL, hwnd, wParam); + break; + case WM_MOVE: + xembed_client_set_position(NULL, hwnd); + break; + case WM_SIZE: + xembed_client_set_size(NULL, hwnd); + break; + case _WM_ATTACH_WINDOW: + WARN("_WM_ATTACH_WINDOW\n"); + }; + + return DefWindowProcW(hwnd, msg, wParam, lParam); +} + +/********************************************************************** + * X11DRV_XEmbed_Init + */ +void X11DRV_XEmbed_Init() +{ + static const WCHAR wszXEMBED[] = {'_','X','E','M','B','E','D',0}; + static WNDCLASSEXW wndclass = { + sizeof(WNDCLASSEXW), + 0, + XEmbed_WndProc, + 0, 0, NULL, NULL, NULL, NULL, NULL, + wszXEMBED, + NULL + }; + + TRACE("()\n"); + + RegisterClassExW(&wndclass); +} #include <assert.h> #include <unistd.h> #include <stdio.h> #include <gtk/gtk.h> #include <gdk/gdkx.h> #include <windows.h> static GdkNativeWindow xwindow; static HINSTANCE hInst; static DWORD WINAPI make_plug(LPVOID arg) { GtkWidget *plug, *button; assert(xwindow); gtk_init(NULL, NULL); plug = gtk_plug_new(xwindow); assert(plug); gtk_widget_show(plug); button = gtk_button_new(); gtk_container_add((GtkContainer*)plug, button); gtk_widget_show(button); gtk_main(); } static LRESULT WINAPI WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch(msg) { case WM_CREATE: xwindow = (GdkNativeWindow)GetPropA(hwnd, "__wine_x11_whole_window"); HWND xembed_hwnd = CreateWindowExA(0, "_XEMBED", NULL, WS_CHILD | WS_CLIPSIBLINGS | WS_CLIPCHILDREN, 0, 0, 300, 300, hwnd, NULL, hInst, NULL); ShowWindow(xembed_hwnd, TRUE); xwindow = (GdkNativeWindow)GetPropA(xembed_hwnd, "__wine_x11_embedder_window"); CreateThread(NULL, 0, make_plug, NULL, 0, NULL); break; case WM_DESTROY: PostQuitMessage(0); break; } return DefWindowProc(hwnd, msg, wParam, lParam); } int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInst, LPSTR cmdline, int cmdshow) { MSG msg; HWND hwnd; static char appName[] = "XEmbed Test"; WNDCLASSEX wndclass; if(!hPrevInst) { hInst = hInstance; wndclass.cbSize = sizeof(wndclass); wndclass.style = CS_HREDRAW | CS_VREDRAW; wndclass.lpfnWndProc = WndProc; wndclass.cbClsExtra = 0; wndclass.cbWndExtra = 0; wndclass.hInstance = hInstance; wndclass.hIcon = LoadIcon(NULL,IDI_APPLICATION); wndclass.hCursor = LoadCursor(NULL,IDC_ARROW); wndclass.hbrBackground = 0; wndclass.lpszMenuName = NULL; wndclass.lpszClassName = appName; wndclass.hIconSm = LoadIcon(NULL,IDI_APPLICATION); if(!RegisterClassEx(&wndclass)) return FALSE; } hwnd = CreateWindow(appName, appName, WS_OVERLAPPEDWINDOW, 0, 0, 300, 300, NULL, NULL, hInstance, NULL); assert(hwnd); ShowWindow(hwnd,cmdshow); while(GetMessage(&msg,NULL,0,0)) { TranslateMessage(&msg); DispatchMessage(&msg); } return msg.wParam; }

2 2

[RESEND] commdlg: use shell32's ILGetDisplayName instead of SHGetPathFromIDList
by Michael Jung 24 May '05

24 May '05

Hi Alexandre, could you please give a short comment on this one: http://www.winehq.org/hypermail/wine-patches/2005/05/0533.html Thanks, -- Michael Jung mjung(a)iss.tu-darmstadt.de

2 1

Re: Corrected the determination of capturing inside EDIT_WM_MouseMove function.
by Dimitrie Paun 24 May '05

24 May '05

> Corrected the determination of capturing inside EDIT_WM_MouseMove function. > - if (GetCapture() != es->hwndSelf) > + if (GetCapture() != es->hwndSelf || !es->bCaptureState) Can we have GetCapture() == es->hwndSelf && !es->bCaptureState If so, isn't this an invalid state? How do we get there? -- Dimi.

2 5

Change of email addr?
by Ann and Jason Edmeades 24 May '05

24 May '05

Hiya, Is there any way to change the email address I am registered with for the wine mailing lists, bug tracking, Changelog etc, or is the best way just to reregister for them all with a different id? Jason

3 2

Write problem with MS Office 2003
by Stefan Dösinger 23 May '05

23 May '05

Hello, I'm doing a few test with Microsoft Office 2003, and one of the problems I notice is that any app(word, excel, powerpoint, access tested) refuses to save new files. Whenever I try to save a file Office tells me that the folder is write-protected. Opening an existing file and saving it again works. I looked at a +shell log and 2 interesting lines are: trace:shell:IShellFolder_fnGetAttributesOf (0x77c403a0)->(cidl=0 apidl=(nil) mask=0x77a820fc (0x00040000)) trace:shell:IShellFolder_fnGetAttributesOf -- result=0x00040000 The result 0x00040000 means SFGAO_READONLY, which the folder isn't, I veryfied that I can write it. As far as I understand Office tries to read the SFGAO_READONLY attribute passing 0x00040000 rgfInOut. But cidl and apidl are set to 0, so Wine's IShellFolder_fnGetAttributesOf doesn't check anything and just returns SFGAO_READONLY. There's a check for this case: if (cidl && !apidl) return E_INVALIDARG; MSDN doesn't give me a hint what to do if cidl is set to 0. If I change the if line to "if (!cidl && !apidl)" (so E_INVALIDARG is returned to office), saving the file works. Should this line be "if (!cidl || !apidl)", or is there a special case for cidl==0? Stefan

1 0

rundll32.exe - interface: SHHelpShortcuts_RunDLL
by Detlef Riekenberg 23 May '05

23 May '05

Hi. While implementing this Functions, I have some Question for the Interface of: shell32.dll SHHelpShortcuts_RunDLL* 1. HWND hwnd 2. DWORD dwArg2 3. LTCSTR szCommand / LPCWSTR wszCommand 4. DWORD dwArg4 Question for 2: What is this Parameter for? (Seems to always be 0x77d8000. => last ptr for winvdm.exe) Question for 3: What Parameter / Which Commands did you knew? FontsFolder PrintersFolder AddPrinter PrintTestPage Connect Disconnect Question for 4: What is this Flags-Parameter for? (Seems to always be 0xa.) -- By By ... ... Detlef

2 2

Re: Write problem with MS Office 2003
by Juan Lang 23 May '05

23 May '05

Stefan wrote: > There's a check for this case: > if (cidl && !apidl) > return E_INVALIDARG; > > MSDN doesn't give me a hint what to do if cidl is set to 0. If I > change the if line to "if (!cidl && !apidl)" (so E_INVALIDARG is > returned to office), saving the file works. Should this line be > "if (!cidl || !apidl)", or is there a special case for cidl==0? There is a special case for cidl == 0, some apps expect to be able to call GetAttributesOf with cidl == 0, apidl == NULL. See the patch that introduced it here: http://www.winehq.org/hypermail/wine-patches/2005/05/0156.html The special case, in particular, is to handle SFGAO_VALIDATE, described on the MSDN page for IShellFolder::GetAttributesOf. I'm guessing this bit is what the app writers were reading when they decided to call GetAttributesOf with cidl == 0: "When used with the file system folder, SFGAO_VALIDATE instructs the folder to discard cached properties retrieved by clients of IShellFolder2::GetDetailsEx that may have accumulated for the specified items." The correct fix is to modify SHELL32_GetItemAttributes to clear SFGAO_READONLY if the file is not read-only. --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new Resources site http://smallbusiness.yahoo.com/resources/

1 0

Re: Blame ExpandEnvironmentStringsA for the failing NT4 test in shlwapi:shreg
by Alexandre Julliard 23 May '05

23 May '05

Richard Cohen <richard(a)daijobu.co.uk> writes: > This is failing because ExpandEnvironmentStringsA is returning twice > the number of characters it should. > > I would like to mark this test (and some others) as todo(nt40), but > the testing framework isn't flexible enough to let me do that (the > only real options seem to be "wine" and "windows"). > > Would a patch to extend the framework to allow a bit mask, something > like todo(win9x|winxp), be acceptable? A todo is supposed to mark something that will need to be addressed later on. Obviously we can't fix the Windows code, so that's not a todo, it's just a behavior of the API that should either be handled by the test, or simply not tested at all if the results are not reliable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: install launcher for taskmgr
by Alexandre Julliard 23 May '05

23 May '05

Brian Vincent <vinn(a)theshell.com> writes: > like msiexec, taskmgr didn't have have a launcher script It's really a namespace issues, we don't want to pollute the global /usr/bin with more apps than strictly necessary. Unlike msiexec, taskmgr isn't Windows-specific enough IMO to export it this way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fix Sparse Warnings for server/
by Alexandre Julliard 23 May '05

23 May '05

Robert Shearman <rob(a)codeweavers.com> writes: > Changelog: > Fix sparse warnings. sparse should be taught that 0 is a perfectly fine value (and IMO preferable to NULL) for handles. -- Alexandre Julliard julliard(a)winehq.org

3 3

RESEND: Get AdjustWindowRect working better
by Richard Cohen 23 May '05

23 May '05

Richard Cohen wrote: > >> This fixes a longstanding bug whereby winemine would move 1 pixel down >> the screen for every new game. >> > Changelog: - Fix off-by-one in menu height calculation (& therefore AdjustWindowRect) + test

1 0

RASENH and Crypt Functions and ADVAPI32
by Uwe Bonnes 23 May '05

23 May '05

Michael, comments in rsaenh show that you duplicated code from advapi32. With SystemFunction036 there is another duplicated functionality. Is there any reason why you don't use the advapi functions direct? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: winedump: Print file offset instead of obscure 'prefix' while dumping data
by Eric Pouech 23 May '05

23 May '05

Dmitry Timoshkov a écrit : > Hello, > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Print file offset instead of obscure 'prefix' while dumping data. prefix is used to properly indent the output of the dump, so you do want to keep the prefix (this doesn't prevent you from adding the offsets for dumps) A+ -- Eric Pouech

2 1

Re: urlmon: Prevent possible use of freed memory
by Jacek Caban 22 May '05

22 May '05

Troy Rollo wrote: >This fixes Bugzilla bug 2969 <http://bugs.winehq.org/show_bug.cgi?id=2969> > >ChangeLog: > Prevent a URLMonikerImpl from being freed before its work in > BindToStorage is done. > > >------------------------------------------------------------------------ > >Index: dlls/urlmon/umon.c >=================================================================== >RCS file: /home/wine/wine/dlls/urlmon/umon.c,v >retrieving revision 1.52 >diff -u -r1.52 umon.c >--- dlls/urlmon/umon.c 5 May 2005 09:50:46 -0000 1.52 >+++ dlls/urlmon/umon.c 21 May 2005 23:57:36 -0000 >@@ -456,6 +456,13 @@ > *ppvObject = (void *) This->pstrCache; > IStream_AddRef((IStream *) This->pstrCache); > >+ /* We are about to start calling back into the application. It is >+ * possible that the application will release its reference to us in >+ * these callbacks, so we need to add a reference to This to make sure the >+ * URLMonikerImpl is not freed before we reach the end of this method. >+ */ > > The right solution is separating IBinding and IMoniker interfaces. They shouldn't be implemented in the same object. I'll send the patch. Jacek

2 1

Re: urlmon/umon.c: Fix corruption
by Jacek Caban 22 May '05

22 May '05

Uwe Bonnes wrote: >Changelog: > dlls/urlmon/umon.c: URLMonikerImpl_Release() > Release structure elements before Freeing structure > > My patch I sent today fixes this too. > Changelog: > wine/dlls/urlmon/umon.c:URLMonikerImpl_BindToStorage() > Don't use a HeapAllocated pointer for other purposes ... > + if (path) > + HeapFree(GetProcessHeap(), 0, path); You don't need this check. > Changelog: > dlls/wininet/internet.c: CrackURL, dlls/wininet/tests/http.c > Add some escape/unescape cases and code thor that cases ... > + ok(InternetCrackUrlA(TEST_URL3, 0, ICU_DECODE, &urlComponents),"InternetCrackUrl failed with GLE 0x%lx\n",GetLastError()); > + fprintf(stderr,"BON:%*s\n", (int)urlComponents.dwUrlPathLength, urlComponents.lpszUrlPath); > > } You shouldn't use fprintf() here. Use trace() instead. Jacek

1 0

Re: [OLE #90] Marshal Objects & Monikers into the ROT
by Alexandre Julliard 22 May '05

22 May '05

Robert Shearman <rob(a)codeweavers.com> writes: > Changelog: > - Marshal objects & monikers into the ROT. > - Test for this behaviour. This fails make test here: ../../../tools/runtest -q -P wine -M ole32.dll -T ../../.. -p ole32_test.exe.so moniker.c && touch moniker.ok fixme:ole:MkParseDisplayName (0x77c518a0, L"clsid:20D04FE0-3AEA-1069-A2D8-08002B30309D:", 0x77acfe68, (nil)): stub. err:ole:CoUnmarshalInterface IMarshal::UnmarshalInterface failed, 0x80004005 moniker.c:145: Test failed: Number of monikers should be equal to 2 not 0 err:ole:CoUnmarshalInterface IMarshal::UnmarshalInterface failed, 0x80004005 moniker.c:164: Test failed: Number of monikers should be equal to 2 not 0 fixme:ole:CreateClassMoniker {0002e005-0000-0000-c000-000000000046} err:ole:get_unmarshaler_from_stream Failed to read common OBJREF header, 0x00000001 make[3]: *** [moniker.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

WineHQ css; binfmt && Mono && wine
by Brian Vincent 22 May '05

22 May '05

Something broke on WineHQ. For some reason <br /> tags aren't getting parsed right - see this week's WWN for an example. It's displaying "<BR>". I haven't looked into it at all, but I figured someone (Dimi?) might remember messing with this stuff recently. Also, anyone happen to know if Wine can be used in conjunction with binfmt alongside Mono? Are there any unique C# identifiers in the first 128 bits of a .Net executable that could identify it? It appears the Mono guys recommend looking for the magic MZ bytes, which is exactly what Wine requires also. We can't look for "PE" since binfmt can only look at the first 127 bytes of a file. -Brian

8 10

console behaviour of tty vs. x11 driver
by Kuba Ober 22 May '05

22 May '05

Hi, I'm running vc.net as a cross-compiler under wine. Everything looks very nice when you run it with X server running. Yet, when there's no X present, winetty driver kicks in and corrupts the console output. Is there a simple remedy? Here are the problems that I observe: 1. Pointless Xlib error message about it not being able to connect to the X server -- this wastes 2 lines of screen real estate and the apps in question are console-only *anyway* It'd be nice to have an environment variable or a registry setting to disable showing of this message. 2. Winetty seems to use ncurses for simple line-oriented output where winex11 did the right thing and didn't wrap the output with escape sequences in such a weird way 3. Winetty clears the screen upon startup (due to ncurses maybe), so e.g. running things from nmake.exe makes the screen get wiped everytime a compile/link step is invoked. This has a nasty side effect: with winetty driver a simple wine foo.exe > log gives you corrupt output with escape sequences that weren't reallyoutput by foo.exe , whereas with winex11 wine foo.exe > log gives you the *correct* output capture. I will file a bug for it if it's not just something weird on my side. Kuba

2 1

WineConf todo list
by Francois Gouget 21 May '05

21 May '05

I'm trying to gather a list of stuff we said needed to be done at WineConf. Of course the initial list is going to be horribly incomplete but I'm sure others will contribute the missing pieces. * Wine Wiki This seems to be done already. It's available there: http://wiki.winehq.org/ * Add a list of companies providing Wine services and support This discussion/flameware is in full swing. * Putting the videos online Done. Maybe some retouching / cleanup to do if we find someone knowledgeable and willing. * Moving the Wine doc to SourceForge The documentation, i.e. the SGML files in documentation/, uses completely different tools from the rest of Wine. Also Alexandre does not want to deal with its translations. So move the SGML documentation to its own CVS repository, winedoc, which we could host on SourceForge. The English version would go in the en subdirectory so we can easily add translations. * Check in the French translation and corresponding infrastructure. The translation will go in the fr subdirectory of the winedoc CVS repository. At the same time the infrastructure for adding other translations should be put in place. * Make an easy to use cxtest script. The idea is to have a script which could be put in a crontab so it can be run entirely automatically and which would: - checkout / update and recompile CXTest - checkout / update and recompile the latest Wine - run regression tests using Wine's Winelib applications - maybe download some free applications and run tests to make sure they install and start up Jozef Stefanka is planning to work on this. * Get rid of the configuration file Well that's the 0.9 todo list. Maybe it's best to keep it separate from this list. * Find a way to document the registry I had a discussion with Alexandre and lamented that, now that we're going to move things out of the configuration, we won't be able to put comments describing what each setting does. However we already have the problem with all of the Windows settings. Furthermore he noted that it's hard to find where a given setting is used in the Wine code (because the registry path is encoded as a Unicode string?). And the problem is compounded by the lack of proper documentation for registry settings in MSDN. So the idea is to create a way to document each registry setting in the source code so it can be extracted with a tool similar to c2man.pl (or with a hacked c2man.pl). -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.

4 3

Re: dwarf2 support progress step 4
by Mike Hearn 21 May '05

21 May '05

On Fri, 20 May 2005 23:16:12 +0200, Raphael wrote: > We only have to build a correct symt model to get it working perfectly What exactly will this work allow - will winedbg get better as a result? At the moment backtraces already give function information... thanks -mike

4 3

Serialization of DEBUGMSG needed
by Uwe Bonnes 21 May '05

21 May '05

Hallo, running CVS wine on my dual pentium machine with debugmessages enabled, I now see that both CPUs spit out debug output at the same time, leading to garbled output, like: 000b:Call gdi32.GetCurrentObject(0000136c,00000005) ret=7f0013:Ca000b:Ret gdi32.GetCurrentObject() retval=00000044 ret=7fef3e40 0013:Ret ntdll.NtUnmapViewOfSection() retval=00000000 ret=77b000b:R0013:Ret kernel32.UnmapViewOfFile() retval=00000001 re000b:Call g0013 :Ret wininet.CommitUrlCacheEntryW() re000b:Ret gdi32.GDI_ReleaseObj() retval=00000000 ret=7fef3f1d Is this an artefact of my machine or a wine problem? In the latter case, as Hyperthreading amd Multicore machines will get more available with time, a fix would be appreciated. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

[RFC] upmfs - page-unaligned mmap() for Linux
by Dan Aloni 21 May '05

21 May '05

Hello All, I'd like to bring this to your attention and review, hopefully to spawn some constructive discussions. The code was a result of experiments I've been doing lately concering some new idea not especially related to WINE. To quote myself from http://wiki.winehq.org/UnalignedMmap: ---- Large majority of PE executables have sections that are page-aligned in memory but not in the PE file image. Linux's mmap() doesn't support mappings that are not aligned to page boundries with regard to file offsets. Currently it forces wineserver to fake mmap() by allocating anonymous pages and using read() to load the sections. In dlls/ntdll/virtual.c, comment above map_file_into_view() says: "Linux kernels before 2.4.x can support non page-aligned offsets, as long as the offset is aligned to the filesystem block size. This is a big performance gain so we want to take advantage of it." These days are long gone, we are now using Linux 2.6, and it doesn't support unaligned mmap(). Enter upmfs. This simple kernel module exports this function to userspace using '/proc': * int mmap_offset(int fd, unsigned long offset); Given an fd and an offset, a new fd is returned. Using mmap() on that new fd, the mapping will be aligned with the given offset, which can be smaller than PAGE_SIZE. A wineserver implementation can check the existance of that module in the kernel (i.e "/proc/upmfs/interface" exists) and use its functionality. ---- The code for the upmfs source package is attached to this post. -- Dan Aloni da-x(a)colinux.org

1 0

environment-priority
by Detlef Riekenberg 21 May '05

21 May '05

Hi While working with wine, I found the way how wine handles the environment. example for "TMP": 1. HCU\Environment\TMP 2. HKLM\System\CurrentControlSet\Control\Session Manager\Environment\TMP 3. $WINETMP 4. $WINEPREFIX/config (TEMP) 5. Buildin Default (c:\windows\temp) During "wineprefixcreate", "TMP" and "TEMP" are created for entry 2 (HKLM\..) from entry 4 ($WINEPREFIX/config : TEMP) with a fallback to entry 5 (c:\windows\temp), but entry 3 ($WINETMP) is ignored. When I delete the entry 2 (HKLM\..), then entry 3 is used ($WINETMP). IMHO, "$WINETMP" should overwrite all other locations. PS: Tested only "WINETMP", but there are also $WINETEMP, WINEHOME and WINEPATH. -- By By ... ... Detlef

1 0

[WINEDOCS] WINEPREFIX and other variables
by Detlef Riekenberg 21 May '05

21 May '05

Hi While reading the source to learn how wine works internal, i found some things not found in the documentation (wine-user.pdf, wine-devel.pdf or winelib-user.pdf): environment: WINEPATH WINEHOME WINETEMP WINETMP "WINEPREFIX" is not new for me (working with wineprefixcreate), but the documentation is "rare". I found many references for "~/.wine" (winetools is worst case in this). Is someone working on the documentation for this? Target-Documentation for this ? [IMHO: (wine|winelib)-(user|devel)] PS: sgml is a black hole for me atm. -- By By ... ... Detlef

3 2

Re: Detecting ulimit problem
by Daniel Kegel 21 May '05

21 May '05

efrias(a)syncad.com wrote: > http://bugs.winehq.org/show_bug.cgi?id=2609 > [Proposed fix:] > struct rlimit address_limits; > int required_address_space = 1024 * 1024 * 1400; /* 1400M */ > getrlimit(RLIMIT_AS, &address_limits); > if (address_limits.rlim_max < required_address_space) > WINE_WARN("Your virtual memory limit is set to %dk, which > will\nprobably prevent wine from loading correctly. If you get an > error,\nincrease the limit with 'ulimit -v' to at least %dk.\n", > address_limits.rlim_max / 1024, required_address_space / 1024); Looks groovy to me. But it will completely annoy people using 2.4 kernels, which by default have only 896MB of user address space, won't it? (I may be confused here, but that's what I remember.) See e.g. http://mail.nl.linux.org/kernelnewbies/2004-12/msg00073.html + On a system with 1 gigabyte of memory, you may get 896 MB of + "user memory" and 128 megabytes of "high memory" with this + selection. This is the usual setting. So I'd encourage you to submit a patch to do this, but only after testing on Red Hat 9.0 to make sure I'm wrong :-)

5 5

Re: Implement RegNotifyChangeKeyValue on top of NtNotifyChangeKey
by Dimitrie Paun 21 May '05

21 May '05

> This patch removes the last server call from advapi32 and we should keep > it free from server calls to reduce the effects of the changing of a > server interface. Nice. BTW, what DLLs make server calls? Any other that shoudn't but still do? -- Dimi.

3 2

Re: crypt32 [4/4]: (un)protectdata test suite
by Alexandre Julliard 20 May '05

20 May '05

Kees Cook <kees(a)outflux.net> writes: > ChangeLog: > Create basic test suite for CryptProtectData/CryptUnprotectData. The tests fail here: ../../../tools/runtest -q -P wine -M crypt32.dll -T ../../.. -p crypt32_test.exe.so protectdata.c && touch protectdata.ok err:crypt:CryptProtectData CryptAcquireContextW failed protectdata.c:89: Test failed: Encrypting without entropy. protectdata.c:91: Test failed: Wrong (2148073494) GetLastError seen err:crypt:CryptProtectData CryptAcquireContextW failed protectdata.c:99: Test failed: Encrypting with entropy. protectdata.c:101: Test failed: Wrong (2148073494) GetLastError seen err:crypt:CryptProtectData CryptAcquireContextW failed protectdata.c:111: Test failed: Encrypting with entropy and no description. protectdata.c:113: Test failed: Wrong (2148073494) GetLastError seen protectdata.c:127: Test failed: CryptProtectData failed to run, so I can't test its output make[3]: *** [protectdata.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [QCAP] Final patch
by Dimi Paun 20 May '05

20 May '05

On Fri, 2005-05-20 at 00:42 +0200, Maarten Lankhorst wrote: > m3h, v4l driver for vfwcapture.. please leave the ERR notice on > initialisation intact, thank you :) I think you've overusing ERR(). ERR() should be called to signal an internal error such as inconsistent state, not something that the function is designed to handle. > + capBox->grab_buf = CoTaskMemAlloc(sizeof(struct video_mmap) * capBox->buffers); > + if(!capBox->grab_buf) { > + ERR("Out of memory?\n"); > + munmap(capBox->pmap, capBox->gb_buffers.size); > + return E_OUTOFMEMORY; > + } The function knows how to deal with this condition gracefully, just get rid of the ERR(). > + if (!capBox->grab_data) > + { > + ERR("%p: Out of memory?\n", capBox); > + return E_OUTOFMEMORY; > + } Ditto. Also the code is more clear if you just do: if (!capBox->grab_data) return E_OUTOFMEMORY; > + if (!capBox) { > + ERR("Out of memory\n"); > + return E_OUTOFMEMORY; > + } Ditto. > + if (stat (device, &st) == -1) { > + ERR("%s: %s\n", device, strerror(errno)); > + CoTaskMemFree(capBox); > + return E_FAIL; > + } Why is this a ERR()? > + > + if (!S_ISCHR (st.st_mode)) { > + ERR("%s: Not a device\n", device); > + CoTaskMemFree(capBox); > + return E_FAIL; > + } And why this? > + > + capBox->fd = open(device, O_RDWR | O_NONBLOCK); > + if (capBox->fd == -1) { > + ERR("%s: Failed to open: %s\n", device, strerror(errno)); > + CoTaskMemFree(capBox); > + return E_FAIL; > + } This is a TRACE or WARN at most. > + ERR("Tinkerer detected? Thou shalt not define HAVE_V4L2\n"); > + CoTaskMemFree(capBox); > + close(capBox->fd); > + return E_FAIL; This is a FIXME. And so on... -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

4 6

Q for AJ? Re: UT2003 Windowing Regression - Yet Another nights effort...
by Ann and Jason Edmeades 20 May '05

20 May '05

Ok, I need advice on this one... I have been purely testing on windows, no wine involvement, to see what happens when I do various things. My test program doesn't do anything in the WM_PAINT handler at all. This results in the machine sitting at 100% CPU processing WM_PAINT messages. 1. Changing the WM_PAINT process to post another user message, results in alternating message posted and WM_PAINT messages, ie normal user message processing is occurring 2. Posting a user message inside the user message handler, results in WM_PAINT being driven, followed by looping processing the user messages - ie WM_PAINT messages are not on the message queue 3. RedrawWindow with update now jumps straight into the message routine with a WM_PAINT, but if we do nothing in that routine, it does indeed proceed to the line after the RedrawWindow call. Wine never leaves the updatenow processing because it loops until the whole region is validated. I believe staying in the updatenow code in wine is incorrect. I think what happens is that when the message dispatch loop gets an empty queue and the window has an invalid region, then a WM_PAINT is returned. So... Can we / I please remove the loop? :-)) What other tests can I do under windows to confirm the behaviour? Jason

2 4

Re: [OLE #90] Marshal Objects & Monikers into the ROT
by Mike Hearn 20 May '05

20 May '05

On Fri, 20 May 2005 14:57:49 +0100, Robert Shearman wrote: > +static inline HRESULT WINAPI > +IrotRegister(DWORD *cookie) > +{ > + static DWORD last_cookie = 1; > + *cookie = InterlockedIncrement(&last_cookie); > + return S_OK; > +} I'm sure there's a good reason for this, but why isn't the last cookie an object member of the ROT? And what are all the Irot* methods given that this is a static inline? Could the need for these functions be documented? thanks -mike

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel