- wine-devel - winehq.org

How to format a IMediaSample?
by Maarten Lankhorst 13 Apr '05

13 Apr '05

I'm having troubles sending a media sample over the graph, I'm wondering wether that is because of the receiving filter or my own fault. the thing I'm trying to send is a uncompressed 24 bit image, the bitmap info header data of it is pretty much as this: mediatype: BI_RGB24 Width: 320 Height: 240 Bitcount: 24 Size of the image in bytes: 230400 compression: BI_RGB so my questions about it are: - What should I do with the ALLOCATOR_PROPERTIES - What do I have to put in IMediaSample SetActualDataLength - How can I fill the pointer returned by IMediaSample GetPointer so that the sample gets accepted?

3 4

Problems posting to wine-patches
by Duane Clark 13 Apr '05

13 Apr '05

Sorry about posting here, but... I seem to be having problems posting to wine-patches, and don't seem to be able to get through to Jeremy Newman either. Other people seem to be getting through okay. Am I the only one? Any ideas why? I know they are not getting stuck in the moderation queue; they seem to be disappearing without a trace that I can find.

1 0

Re: dib fixes
by Rein Klazes 13 Apr '05

13 Apr '05

Hi Eric, I am looking into a couple of crashes in dlls/x11drv/dib.c caused by a patch from you. The patch (attached) is only 5 years old, I am sure you remember all the details ;) To be precise, I get X-errors in the calls to XGetSubImage caused by out of range parameters. Fixing this by some parameter checking is not the big problem, but I wonder if it is still necessary to have those calls there. You call it a "quick hack", would it not be better to remove it now and properly fix any problems that may surface? The patch that I sent in yesterday ( "fix decoding compressed dibs") is an example of such problem.. Rein.

3 10

Re: Out-of-tree compilation and running
by Detlef Riekenberg 13 Apr '05

13 Apr '05

On Mi, 30.03.2005, 23:04 +0100 Paul Millar wrote in wine-patches: > I've tested this with an in-tree and out-of-tree compilation. Seems to work OK > for me in both cases. I'm working at wineprefixcreate also and while looking at your Patch, i found a race-condition when the user started wineprefixcreate: wine.inf is searched first in "$datadir" and then in "$srcdatadir". "$datadir" is "from the binary wine-tree" when wineprefixcreate was called with "--use-wine-tree" but it could also come from "the installed wine-version", when the option "--use-wine-tree" was not used. wine.inf could be from a different wine-version in this case! my modifications are: before parsing the options: + topdir="" + srcdatadir="" while parsing "--use-wine-tree": - datadir="$topdir/tools" and later: # Copy the .inf script and run it if [ -n "$topdir$srcdatadir" ] then for dir in "$topdir" "$srcdatadir"; do if [ -n "$dir" -a -e "$dir/tools/wine.inf" ]; then cp "$dir/tools/wine.inf" "$CROOT/windows/inf/wine.inf" break fi else cp "$datadir/wine.inf" "$CROOT/windows/inf/wine.inf" fi ---------- I moved srcdatadir one dir-level up to use the same level as "$topdir" and to make my life more easy, because i need "$srcdatadir/documentation/samples/config" for my patches. Sorry, no diff here because I changed much more in my version. (Bug 2844 and Bug 2845). -- by by ... ... Detlef

3 3

Started on TrashCan implementation
by Steven Edwards 13 Apr '05

13 Apr '05

Hi, This is my first real attempt to add a new feature so its going to take quite some time. My long term goal is to implement the RecycleBin for ReactOS and for Wine to make it interface with the FreeDesktop.org draft trashcan spec. The latter might require a extension to Wines or some other process to move files out of the C:\Recycled folder and in to the users ~/Desktop/Trash I have started by adding a little support for the FOF_ALLOWUNDO flag in SHFileOperationW. Windows can use either Drive:\Recycled or Drive:\Recycler depending on if the TrashCan is on a NTFS drive or not so I am not sure how we want to handle it in Wine. With my first patch if you delete a file with this flag it will move the file to C:\Trash which is a file not a directory. I am using the sample programs here to reverse how its supposed to work http://www.maddogsw.com/cmdutils/ If anyone would like to help they can start working on the namespace stuff needed for the RecycleBin. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: Cross-building went wrong
by Juan Lang 13 Apr '05

13 Apr '05

Hi Paul, > Anyone have a suitable patch against mingw that adds > StgCreatePropSetStg? Well, I haven't a patch, but adding the line "StgCreatePropSetStg@12" to w32api/lib/ole32.def ought to do it. --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 2

Re: shell32/brsfolder.c
by Michael Jung 12 Apr '05

12 Apr '05

Hi Wolfgang, On Tuesday 12 April 2005 22:30, you wrote: > As you might have guessed, I don't have too much knowledge about > Windows programming. All I wanted to do in the first place was getting > the DVD Shrink dialog to work ;-) I didn't mean to bash your patch. If DVD Shrink doesn't work as on Windows then obviously there something is not correctly implemented in wine. I'm not that familiar with the Windows API either, but I do have two more comments on your patch. > So in order to fix the DVD Shrink failure, only the following change is > needed: > > # -----8<-----(snip)---------- > @@ -100,6 +100,13 @@ > ILRemoveLastID(pidlParent); > pidlChild = ILClone(ILFindLastID(root)); > > + /* This is needed to avoid duplication of the Desktop GUID, > + when an empty PIDL is passed in! */ > + if (_ILIsDesktop(pidlChild)) { > + ILFree( pidlChild ); > + pidlChild = NULL; > + } > + > if (_ILIsDesktop(pidlParent)) { > hr = SHGetDesktopFolder(&lpsfParent); > } else { > # ----->8-----(snap)---------- > > I still like the BFFM_SETSELECTION feature though. You should probably split this up into two individual patches, then. This would make it easier to find misbehaving code later on. > + { > + /* Always show selection */ > + LONG_PTR dlg_style; > + dlg_style = GetWindowLongPtrW(hwndTreeView, GWL_STYLE); > + dlg_style |= TVS_SHOWSELALWAYS; > + SetWindowLongPtrW(hwndTreeView, GWL_STYLE, dlg_style ); > + } > + This probably belongs into the shell32_*.rc files (look for SHBRSFORFOLDER_MSGBOX). Unfortunately, you have to fix it for all the localized versions. I (and I'm sure all of the wine folks, too) do appreciate your effort. Please go ahead and submit to wine-patches. Alexandre will decide if it's ready for inclusion. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

[NtQuerySystemInformation #1] Fixes + tests (second round)
by Paul Vriens 12 Apr '05

12 Apr '05

Hi, this is a second go at some unit tests and related fixes for NtQuerySystemInformation. The ultimate goal is to get SysInternal's Process Explorer running. I welcome suggestions and remarks. If none I will submit this to wine-patches and start the further works. The differences between this one and the first is that I've tried to get the needed length regardless of the passed Length. This is how SystemProcessInformation and some others work and how MSDN tells us it should be implemented. I've also found that M$ doesn't always do this. The patch after this one will add so more unit tests. For example SystemTimeOfDayInformation will always return STATUS_SUCCESS even if the given buffer is too small. Cheers, Paul Vriens. Changelog Start of unit tests for NtQuerySystemInformation Return STATUS_INVALID_INFO_CLASS for non-implemented classes Return len regardless of given Length Return STATUS_INFO_LENGTH_MISMATCH if given length is not sufficient Return STATUS_ACCESS_VIOLATION if no buffer given

1 0

shell32/brsfolder.c
by Michael Jung 12 Apr '05

12 Apr '05

Hi Wolfgang, @@ -400,24 +423,41 @@ static LRESULT MsgNotify(HWND hWnd, UIN break; lptvid=(LPTV_ITEMDATA)pnmtv->itemNew.lParam; - if (SUCCEEDED(IShellFolder_BindToObject(lptvid->lpsfParent, lptvid->lpi,0, (REFIID)&IID_IShellFolder,(LPVOID *)&lpsf2))) - { FillTreeView( lpsf2, lptvid->lpifq, pnmtv->itemNew.hItem,lptvid->pEnumIL); + if ( _ILIsDesktop( lptvid->lpi )) + { + /* Always fill Desktop node without binding to object */ + FillTreeView( lptvid->lpsfParent, lptvid->lpifq, pnmtv->itemNew.hItem, lptvid->pEnumIL); + } + else if (SUCCEEDED(IShellFolder_BindToObject( + lptvid->lpsfParent, lptvid->lpifq, ^^^^^ In TV_ITEMDATA variables, lpsfParent is the IDL of the parent, lpi is the relative IDL to the child and lpifq is the fully qualified IDL to the child. So what you are doing here effectively is to concatenate the parent's IDL with the fully qualified IDL. Replacing this with "lptvid->lpi" fixes the problem in winecfg. There are several occurences of "_ILIsDesktop( lptvid->lpi )" in your patch, which semantically doesn't make much sense to me, since lpi is only the relative IDL. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Cross-building went wrong
by Paul Millar 12 Apr '05

12 Apr '05

Hi all, [yawn] One of the new tests broke winetest build (see below). Anyone have a suitable patch against mingw that adds StgCreatePropSetStg? Cheers, Paul. [paul@quisquiliae tests]$ make i686-mingw32msvc-gcc marshal.o moniker.o propvariant.o stg_prop.o storage32.o testlist.o -o ole32_test.exe -loleaut32 -lole32 -luser32 -lkernel32 -lntdll -luuid stg_prop.o(.text+0xe8): In function `testProps': /home/paul/Production/wine-cross-source/dlls/ole32/tests/stg_prop.c:55: undefined reference to `StgCreatePropSetStg@12' stg_prop.o(.text+0xdef):/home/paul/Production/wine-cross-source/dlls/ole32/tests/stg_prop.c:217:undefined reference to `StgCreatePropSetStg@12' distcc[2034] ERROR: compile on localhost failed make: *** [ole32_test.exe] Error 1

1 0

Rough Draft
by Andrew Neil Ramage 12 Apr '05

12 Apr '05

Rough Draft is a useful Windows word processor that natively saves files in .RTF format. Unfortunately, when installing it I got the following errors: fixme:richedit:RichEditANSIWndProc EM_AUTOURLDETECT: stub fixme:richedit:RichEditANSIWndProc WM_SETFONT: stub fixme:richedit:RichEditANSIWndProc EM_LIMITTEXT: stub fixme:richedit:RichEditANSIWndProc EM_EXLIMITTEXT: stub fixme:richedit:ME_ReleaseStyle all style references freed (good!) err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink err:menubuilder:InvokeShellLinker failed to fork and exec wineshelllink fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:SLTG_ProcessDispatch memh.cbExtra is 4320 fixme:ole:SLTG_ProcessDispatch offset 0 0x4a fixme:ole:SLTG_ProcessDispatch memh.cbExtra is 376 fixme:ole:SLTG_ProcessDispatch offset 0 0x4a fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects Anyone know why I get all the fixme's ? -- Andrew Beneath the noble bird Between the proudest words Behind the beauty, cracks appear Once with heads held high They sang out to the sky Why do their shadows bow in fear? Beneath, Between and Behind by Rush (Fly By Night, 1975) ---------------------------------------

2 1

Re: Fix for shell32.SHBrowseForFolder (proper Desktop tree + BFFM_SETSELECTION implemented)
by Michael Jung 12 Apr '05

12 Apr '05

Hi Wolfgang, On Tuesday 12 April 2005 01:03, Wolfgang Scherer wrote: > Solution > -------- > Fix TreeView setup behavior. Implement BFFM_SETSELECTION > functionality. I've tried your patch and it breaks the SHBrowseForFolder usage in winecfg's drive mapping property sheet. I don't have time now, but will look into it soon (hopefully this evening). The last patch, which was applied to this code is http://www.winehq.org/hypermail/wine-cvs/2005/03/0017.html Would you mind to try if this one broke DVD Shrink 3.2? (patch -R) Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: lostwages/templates/en status_ui.template
by Jacek Caban 12 Apr '05

12 Apr '05

Log message: Dimitrie O. Paun <dpaun(a)rogers.com <mailto:dpaun@rogers.com?Subject=Re:%20lostwages/templates/en%20status_ui.template>> * Work is ongoing on richedit * Audit of Syslink * We've done all we can on shdocvw.dll for now ... - <td class="pct25">25%: implement shdocvw.dll</td> + <td class="pct100">100%: We forward to Mozilla, but more work is needed on Mozilla for compatibility.</td> I completely disagree. We can do much more than there is done right now. shdocvw is more than WebBrowser control and we can inplement those areas, but WebBrowser needs a lot of work as well. Mozilla ActiveX Control seems not to be systematically developed and the compability we need is not their aim. We need an implementation of WebBrowser based on MSHTML, which will be possible when I finish my work on it. This way we'll be able to implement shdocvw correctly (eg. it'll be possible to implement Internet Explorer OLE Automation), but now it's far, far away from it and really far from 100% complete.

5 9

shell32, ntdll tests
by Aaron Arvey 11 Apr '05

11 Apr '05

Is anyone currently working (or have feedback) on tests for ntdll/loader.c, ntdll/virtual.c, shell32/folder.c, shell32/shlexec.c, or shell32/shell_main.c? More specifically, is it worth the time to write tests for ntdll/loader.c and ntdll/virtual.c? It seems that these files would be used to load any program, so if there were any bugs, I'm guessing they would become apparent immediately and thus having formal tests would be somewhat pointless. Please correct (or reaffirm) me as I am going to write some tests in my spare time and I want to make sure that they'd be useful to the wine project. I'm looking at these specific files because they have code which is run by google's picasa 2, but not by the wine test suite. Thanks! Aaron

2 1

Re: OLEAUT32: Don't crash on divide by zero
by Marcus Meissner 11 Apr '05

11 Apr '05

On Mon, Apr 11, 2005 at 12:47:22PM -0700, Daniel Remenak wrote: > Changelog: > Return DISP_E_DIVBYZERO instead of crashing when asked to divide a > variant by zero. You cannot really compare floats against 0 I think. Ciao, Marcus

2 1

CVS Checkout: Wineowner's lock???
by Jan Schiefer 11 Apr '05

11 Apr '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 When I try to checkout wine's cvs I get: ... cvs server: [13:54:51] waiting for wineowner's lock in /home/wine/wine/dlls/shell32 I got no idea about his one...??? Greetings, Jan Schiefer! -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCWshmzC00UKXFdVcRAqqeAJsGRLvbeb2Y+IA5DLyeFtqwiAdZXgCgl389 XguDPLoWPG0oHjKPldx1PSA= =8bZH -----END PGP SIGNATURE-----

1 0

ntoskrnl and safedisk
by Ivan Leo Puoti 11 Apr '05

11 Apr '05

I won't have much time to work on this stuff for a while, so I thought I might as well post it here. I've got a ntoskrnl.exe that can load, unload and initialise drivers successfully (Well, I've only tried with a few builds of safedisk but that doesn't matter), it can also dispatch io requests received from DispatchDeviceControl to the driver. However safedisk fails by returning STATUS_UNSUCCESSFUL in the IRP's IoStatus.Status member, I haven't been able to debug this because winedbg refuses to step trough the code properly, however I will try again when I have time to do so. In the mean time you can download and build this stuff yourself, the patch that teaches wine to interact with ntoskrnl is at http://spazioinwind.libero.it/nonsolomicrosoft/public/patch.diff , ntoskrnl itself is here http://spazioinwind.libero.it/nonsolomicrosoft/public/ntoskrnl.tar.bz you'll also need http://spazioinwind.libero.it/nonsolomicrosoft/public/ntoskrnl_protocol.h , put it in include/wine. A full ./configure && make depend && make is needed to build this stuff into wine after patching. Comments/ideas/fixes welcome. Note that ntoskrnl isn't thread safe ATM and probably can't handle more than one driver at any one time. Ivan.

1 0

Alexandre is back!
by Jakob Eriksson 11 Apr '05

11 Apr '05

Send in more patches, everybody! :-)

2 1

Re: lostwages/templates/en status_ui.template
by Steven Edwards 11 Apr '05

11 Apr '05

Hi, --- Mike McCormack <mike(a)codeweavers.com> wrote: > Actually, I'd be interested to see how much of Gecko we'd need to > import/port so that Wine could render HTML. It seems pretty obvious to > me from my experiments with the Mozilla Active X control that nobody is > using it as it is. The ReactOS guys are using the Wine code mostly as is. There is still some issue preventing Mozilla from drawing so Martin Fuchs has made a lightwieght Webbrowser that is a wrapper around the currently implementation that installs the Control. It would be nice to not have to download any additional stuff to have Gecko support but I don't think its worth the massive amount of trouble to import plus I doubt Julliard would ever let it in the Wine tree anyway. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: Re2: Pushing up data through the stream in quartz
by Robert Shearman 11 Apr '05

11 Apr '05

Maarten Lankhorst wrote: > HRESULT Capture_Run(CaptureBox * capBox, FILTER_STATE *state) > { > HRESULT hr; > IMediaSample *pSample = NULL; > LPBYTE pointer; > hr = OutputPin_GetDeliveryBuffer((OutputPin *)capBox->pOut, > &pSample, NULL, NULL, 0); > TRACE("Meat 1: %lx - %p\n", hr, pSample); > hr = IMediaSample_GetPointer(pSample, &pointer); > TRACE("Meat 2\n"); > IMediaSample_SetActualDataLength(pSample, 320*240*3); > TRACE("Meat 3\n"); > ZeroMemory(pointer, 320*240*3); > TRACE("Meat 4\n"); > OutputPin_SendSample((OutputPin *)capBox->pOut, pSample); > FIXME("%p -> (%p) stub\n", capBox, state); > return S_OK; > } > > I get E_VFW_NOT_COMMITTED after trying GetDeliveryBuffer, what's the > cause? > This error is due to a memory allocator needing to be committed before it can be used (see dlls/quartz/memallocator.c). You should call IMemAllocator_Commit in the Run implementation of your filter and then push one sample downstream. IIRC, you should also call IMemAllocator_Decommit in the Stop implementation of your filter, but this isn't done for the implementation I referred to (dlls/quartz/transform.c). Rob

2 1

real SetProcessClass and SetThreadPriority support
by Robert Reif 11 Apr '05

11 Apr '05

Are there any plans or is anyone working on mapping Windows SetProcessClass and SetThreadPriority support to linux process priorities on kernels that support CAP_SYS_NICE?

5 8

Re: Reduce __attribute__(x) to nothing if __GNUC__ is unset
by Alexandre Julliard 11 Apr '05

11 Apr '05

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > This lets us get rid of various #ifdef __GNUC__, as well as use > DECLSPEC_NORETURN at least everywhere winnt.h is included, without fear > of conflicts. This doesn't really help, because we want the code to build with the Microsoft headers too, so you still can't use __attribute__ without ifdefs. And really the use of __attribute__ should be kept to a minimum, your other patches are adding it in a lot of places where it's not necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

stubbed powrprof.dll
by Benjamin Cutler 11 Apr '05

11 Apr '05

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This is my first attempt at contributing anything to the Wine tree, so if I've made any common 'newbie' mistakes, that's probably why. I've been experimenting with dx9wine to see if I can get Planetside working (that game is the only reason I'd even consider going back to windows), but the program requires one function from powrprof.dll, which, unless I'm blind, doesn't seem to exist in the wine tree at present. So I spent a few hours looking at the source tree and looking up info on the functions provided by powrprof.dll, and wrote up a header and a .c file that includes stubbed out functions so that applications that use powrprof will at least load (they of course might not run properly). Attached you'll find the result of that work, including a patch to configure.ac and dlls/Makefile.in, and a tarball containing dlls/powrprof/ and include/powrprof.h. Note that powrprof.h contains several struct and enum definitions that really belong in winnt.h, but I wasn't sure where in winnt.h I should place them, so I simply stuck them in powrprof.h for now. After compiling powrprof.dll.so and placing it in /usr/lib/dx9wine/lib/wine/, I was able to get the Planetside exe to load, but it promptly bombed out because it thought my graphics card was only 16 megs (it's 128, but I'm sure I just need to fix a config variable), so I think I'm on the right track. Thank you for your time. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCWJNy3ZWQ5WzMh1oRAupIAJ9tOd4krieCMN5xBm1ypbqfxk8m7gCgj3Rr 52ZhgBcks8jKFkuWF+mElT4= =EEgB -----END PGP SIGNATURE-----

3 7

Re: [Wine]Turining off Fixme Errors
by Brouard Nicolas 11 Apr '05

11 Apr '05

Le dimanche 10 avril 2005 à 23:00 +0200, TimeFX a écrit : > WINEDEBUG=fixme-all wine program.exe > > see http://www.winehq.com/site/docs/wine-user/x1824#AEN1826 This page is outdated concerning the Wine Developer's Guide, and refers to a codeweaver no more existing page. See and the wrong URL: "For more details about debug channels, check out the The Wine Developer's Guide." Nicolas > ----- Original Message ----- > From: "Phillip Bruce" <pbbruce(a)mindspring.com> > To: "wine-users" <wine-users(a)winehq.com> > Sent: Sunday, April 10, 2005 10:21 PM > Subject: [Wine]Turining off Fixme Errors > > > > Hi, > > > > I hate asking for this as somone did provide me the answer > > earlier. But what is the winedebug syntax for turning off > > all fixme errors? > > > > Thanks. > > > > Phillip > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users -- Brouard Nicolas <nicolas.brouard(a)libertysurf.fr>

1 0

Mismatch in winternl.h for SYSTEM_*_INFORMATION structs
by Paul Vriens 11 Apr '05

11 Apr '05

Hi, I'm busy fixing up NtQuerySystemInformation as this is needed for my 'Get Processor Explorer running' project. I've found that (at least) 2 structs are wrongly sized: /* System Information Class 0x03 */ typedef struct _SYSTEM_TIMEOFDAY_INFORMATION { #ifdef __WINESRC__ LARGE_INTEGER liKeBootTime; LARGE_INTEGER liKeSystemTime; LARGE_INTEGER liExpTimeZoneBias; ULONG uCurrentTimeZoneId; DWORD dwReserved; #else BYTE Reserved1[48]; #endif } SYSTEM_TIMEOFDAY_INFORMATION, *PSYSTEM_TIMEOFDAY_INFORMATION; /* was SYSTEM_TIME_INFORMATION */ In the __WINESRC__ case it's 32 bytes and 48 otherwise. The same is true for the _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION struct, where in the __WINESRC__ case it's 48 bytes and 44 bytes otherwise. So my questions are: 1. Is there a reason for this, or is it a bug. 2. Why do we have separate structs for the WINE and the NOT-WINE case. Is this because most of it is undocumented? Cheers, Paul Vriens.

1 0

LISTVIEW_SetItemState problem in FlashFXP (and other applications)
by Rolf Kalbermatter 11 Apr '05

11 Apr '05

I was just discussing the problem with FlashFXP on Wine and did some Google search on this. It turned out that back in 2003 this problem was already noticed by one of the developers of FlashFXP and also somehow documented as follows: > http://forum.ru-board.com/topic.cgi?forum=5&topic=0132&start=240: > > 1. FlashFXP is no longer compatible with WINE, Switching to the OwnerData > listview has broken compatiblity, it's unlikely that WINE will be supported. > WINE needs to be made more compatible with FlashFXP. > |- After reviewing the wine source code I believe the problem is located here > http://source.winehq.org/source/dlls/comctl32/listview.c line 2971 & 2972 > 2971 for (i = nFirst; i <= nLast; i++) > 2972 LISTVIEW_SetItemState(infoPtr,i,&item); > The Problem: In OwnerData mode the OnData event is triggered when the > ItemState changes. However in the OnData event we set the item state. > > I suspect this causes an infinite loop. > This probably is very close to the actual problem. Looking at current listview.c in CVS I see following at about this location: > 2979 /* FIXME: this is not correct LVS_OWNERDATA > 2980 * setting the item states individually will generate > 2981 * a LVN_ITEMCHANGED notification for each one. Instead, > 2982 * we have to send a LVN_ODSTATECHANGED notification. > 2983 * See MSDN documentation for LVN_ITEMCHANGED. > 2984 */ > 2985 for (i = nFirst; i <= nLast; i++) > 2986 LISTVIEW_SetItemState(infoPtr,i,&item); Of course there are people here much more familiar with Common Controls than me, so I will probably not be able to do a quick fix to this myself. Just thought I would point out my findings so that others can confirm or reject the probable cause of the endless loop in FlashFXP and other applications. Rolf Kalbermatter

2 1

Pushing up data through the stream in quartz
by Maarten Lankhorst 11 Apr '05

11 Apr '05

I'm trying to figure out how to do this, but I can't find anything on the subject. From what I can tell, you have to make a media sample, then use outputpin_sendsample to deliver it, so, how do I fill up a media sample with a single frame? For now, just with NULL data would be sufficient..

2 1

Wine msn webcam patch (Attempt 2)
by Maarten Lankhorst 11 Apr '05

11 Apr '05

I've been trying to get msn webcam to work again, and I found out that WINEDEBUG=+quartz gives a crash when msn creates a pin, and then does some stuff with it, I can only presume some TRACE or WARNING causes the error, but the effect is I can't use those commands, this patch currently allows MSN preview screen to become gray, but it's not actually sending any information (not even fake images) to msn's webcam pin, if someone can find where exactly it crashes, it would help a lot, and make it a lot easier for me to actually implement a working webcam (Right now it will probably only work for msn messenger, but I can imagine other programs will work with this too in a future version) This file makes changes to qcap, but they are not needed for the process as far as I know DLL Overrides: "devenum" = "builtin" "quartz" = "builtin" just make sure to do regsvr32 devenum and regsvr32 quartz AFTER you applied the patches.. diff -Nru wine-old/dlls/devenum/createdevenum.c wine-new/dlls/devenum/createdevenum.c --- wine-old/dlls/devenum/createdevenum.c 2005-01-25 11:56:39.000000000 +0100 +++ wine-new/dlls/devenum/createdevenum.c 2005-04-09 16:10:47.000000000 +0200 @@ -117,6 +117,7 @@ if (IsEqualGUID(clsidDeviceClass, &CLSID_AudioRendererCategory) || IsEqualGUID(clsidDeviceClass, &CLSID_AudioInputDeviceCategory) || + IsEqualGUID(clsidDeviceClass, &CLSID_VideoInputDeviceCategory) || IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory)) { hbasekey = HKEY_CURRENT_USER; @@ -142,6 +143,7 @@ { if (IsEqualGUID(clsidDeviceClass, &CLSID_AudioRendererCategory) || IsEqualGUID(clsidDeviceClass, &CLSID_AudioInputDeviceCategory) || + IsEqualGUID(clsidDeviceClass, &CLSID_VideoInputDeviceCategory) || IsEqualGUID(clsidDeviceClass, &CLSID_MidiRendererCategory)) { HRESULT hr = DEVENUM_CreateSpecialCategories(); @@ -413,6 +415,7 @@ CoTaskMemFree(pTypes); } } + res = DEVENUM_CreateAMCategoryKey(&CLSID_VideoInputDeviceCategory); } if (pMapper) diff -Nru wine-old/dlls/devenum/devenum_main.c wine-new/dlls/devenum/devenum_main.c --- wine-old/dlls/devenum/devenum_main.c 2004-12-07 15:37:11.000000000 +0100 +++ wine-new/dlls/devenum/devenum_main.c 2005-04-09 16:10:47.000000000 +0200 @@ -122,7 +122,7 @@ {&CLSID_AudioCompressorCategory, acmcat, TRUE}, {&CLSID_VideoCompressorCategory, vidcat, TRUE}, {&CLSID_LegacyAmFilterCategory, filtcat, TRUE}, - {&CLSID_VideoInputDeviceCategory, vfwcat, FALSE}, + {&CLSID_VideoInputDeviceCategory, vfwcat, TRUE}, {&CLSID_AudioInputDeviceCategory, wavein, FALSE}, {&CLSID_AudioRendererCategory, waveout, FALSE}, {&CLSID_MidiRendererCategory, midiout, FALSE}, @@ -156,7 +156,7 @@ pMapper = (IFilterMapper2*)mapvptr; - IFilterMapper2_CreateCategory(pMapper, &CLSID_VideoInputDeviceCategory, MERIT_DO_NOT_USE, friendlyvidcap); + IFilterMapper2_CreateCategory(pMapper, &CLSID_VideoInputDeviceCategory, MERIT_NORMAL, friendlyvidcap); IFilterMapper2_CreateCategory(pMapper, &CLSID_LegacyAmFilterCategory, MERIT_NORMAL, friendlydshow); IFilterMapper2_CreateCategory(pMapper, &CLSID_VideoCompressorCategory, MERIT_DO_NOT_USE, friendlyvidcomp); IFilterMapper2_CreateCategory(pMapper, &CLSID_AudioInputDeviceCategory, MERIT_DO_NOT_USE, friendlyaudcap); diff -Nru wine-old/dlls/qcap/main.c wine-new/dlls/qcap/main.c --- wine-old/dlls/qcap/main.c 1970-01-01 01:00:00.000000000 +0100 +++ wine-new/dlls/qcap/main.c 2005-04-09 16:11:33.000000000 +0200 @@ -0,0 +1,244 @@ +/* DirectShow Capture Functions (QCap.DLL) + * + * Copyright 2005 Maarten Lankhorst + * Based on quartz' dll + * + * This file contains the (internal) driver registration functions, + * driver enumeration APIs and capture functions. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include "config.h" +#include "wine/debug.h" + +#include "qcap_private.h" + +WINE_DEFAULT_DEBUG_CHANNEL(qcap); + +static DWORD dll_ref = 0; + +/* For the moment, do nothing here. */ +BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) +{ + switch(fdwReason) { + case DLL_PROCESS_ATTACH: + DisableThreadLibraryCalls(hInstDLL); + break; + case DLL_PROCESS_DETACH: + break; + } + return TRUE; +} + +/****************************************************************************** + * DirectShow ClassFactory + */ +typedef struct { + IClassFactory ITF_IClassFactory; + + DWORD ref; + HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, LPVOID *ppObj); +} IClassFactoryImpl; + +struct object_creation_info +{ + const CLSID *clsid; + HRESULT (*pfnCreateInstance)(IUnknown *pUnkOuter, LPVOID *ppObj); +}; + +static const struct object_creation_info object_creation[] = +{ +}; + +static HRESULT WINAPI +DSCF_QueryInterface(LPCLASSFACTORY iface,REFIID riid,LPVOID *ppobj) +{ + IClassFactoryImpl *This = (IClassFactoryImpl *)iface; + + if (IsEqualGUID(riid, &IID_IUnknown) + || IsEqualGUID(riid, &IID_IClassFactory)) + { + IClassFactory_AddRef(iface); + *ppobj = This; + return S_OK; + } + + WARN("(%p)->(%s,%p),not found\n",This,debugstr_guid(riid),ppobj); + return E_NOINTERFACE; +} + +static ULONG WINAPI DSCF_AddRef(LPCLASSFACTORY iface) +{ + IClassFactoryImpl *This = (IClassFactoryImpl *)iface; + return InterlockedIncrement(&This->ref); +} + +static ULONG WINAPI DSCF_Release(LPCLASSFACTORY iface) +{ + IClassFactoryImpl *This = (IClassFactoryImpl *)iface; + + ULONG ref = InterlockedDecrement(&This->ref); + + if (ref == 0) + HeapFree(GetProcessHeap(), 0, This); + + return ref; +} + + +static HRESULT WINAPI DSCF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pOuter, + REFIID riid, LPVOID *ppobj) +{ + IClassFactoryImpl *This = (IClassFactoryImpl *)iface; + HRESULT hres; + LPUNKNOWN punk; + + TRACE("(%p)->(%p,%s,%p)\n",This,pOuter,debugstr_guid(riid),ppobj); + + *ppobj = NULL; + hres = This->pfnCreateInstance(pOuter, (LPVOID *) &punk); + if (SUCCEEDED(hres)) { + hres = IUnknown_QueryInterface(punk, riid, ppobj); + IUnknown_Release(punk); + } + return hres; +} + +static HRESULT WINAPI DSCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) +{ + IClassFactoryImpl *This = (IClassFactoryImpl *)iface; + FIXME("(%p)->(%d),stub!\n",This,dolock); + return S_OK; +} + +static IClassFactoryVtbl DSCF_Vtbl = +{ + DSCF_QueryInterface, + DSCF_AddRef, + DSCF_Release, + DSCF_CreateInstance, + DSCF_LockServer +}; + +/******************************************************************************* + * DllGetClassObject [QCAP.@] + * Retrieves class object from a DLL object + * + * NOTES + * Docs say returns STDAPI + * + * PARAMS + * rclsid [I] CLSID for the class object + * riid [I] Reference to identifier of interface for class object + * ppv [O] Address of variable to receive interface pointer for riid + * + * RETURNS + * Success: S_OK + * Failure: CLASS_E_CLASSNOTAVAILABLE, E_OUTOFMEMORY, E_INVALIDARG, + * E_UNEXPECTED + */ +DWORD WINAPI QCAP_DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) +{ + unsigned int i; + IClassFactoryImpl *factory; + + TRACE("(%s,%s,%p)\n", debugstr_guid(rclsid), debugstr_guid(riid), ppv); + + if ( !IsEqualGUID( &IID_IClassFactory, riid ) + && ! IsEqualGUID( &IID_IUnknown, riid) ) + return E_NOINTERFACE; + + for (i=0; i < sizeof(object_creation)/sizeof(object_creation[0]); i++) + { + if (IsEqualGUID(object_creation[i].clsid, rclsid)) + break; + } + + if (i == sizeof(object_creation)/sizeof(object_creation[0])) + { + FIXME("%s: no class found.\n", debugstr_guid(rclsid)); + return CLASS_E_CLASSNOTAVAILABLE; + } + + factory = HeapAlloc(GetProcessHeap(), 0, sizeof(*factory)); + if (factory == NULL) return E_OUTOFMEMORY; + + factory->ITF_IClassFactory.lpVtbl = &DSCF_Vtbl; + factory->ref = 1; + + factory->pfnCreateInstance = object_creation[i].pfnCreateInstance; + + *ppv = &(factory->ITF_IClassFactory); + return S_OK; +} + +/*********************************************************************** + * DllCanUnloadNow (QCAP.@) + */ +HRESULT WINAPI QCAP_DllCanUnloadNow() +{ + return dll_ref != 0 ? S_FALSE : S_OK; +} + + +#define OUR_GUID_ENTRY(name, l, w1, w2, b1, b2, b3, b4, b5, b6, b7, b8) \ + { { l, w1, w2, { b1, b2, b3, b4, b5, b6, b7, b8 } } , #name }, + +static struct { + const GUID riid; + const char *name; +} InterfaceDesc[] = +{ +#include "uuids.h" + { { 0, 0, 0, {0, 0, 0, 0, 0, 0, 0, 0} }, NULL } +}; + +/*********************************************************************** + * qcdebugstr_guid (internal) + * + * Gives a text version of Capture GUIDs if possible + */ +const char * qcdebugstr_guid( const GUID * id ) +{ + int i; + char * name = NULL; + + for (i=0;InterfaceDesc[i].name && !name;i++) { + if (IsEqualGUID(&InterfaceDesc[i].riid, id)) return InterfaceDesc[i].name; + } + return debugstr_guid(id); +} + +/*********************************************************************** + * qcdebugstr_State (internal) + * + * Gives a text version of the FILTER_STATE enumeration + */ +const char * qcdebugstr_State(FILTER_STATE state) +{ + switch (state) + { + case State_Stopped: + return "State_Stopped"; + case State_Running: + return "State_Running"; + case State_Paused: + return "State_Paused"; + default: + return "State_Unknown"; + } +} + diff -Nru wine-old/dlls/qcap/Makefile.in wine-new/dlls/qcap/Makefile.in --- wine-old/dlls/qcap/Makefile.in 2004-05-14 23:37:32.000000000 +0200 +++ wine-new/dlls/qcap/Makefile.in 2005-04-09 16:11:33.000000000 +0200 @@ -3,8 +3,11 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = qcap.dll +IMPORTS = msvfw32 ole32 oleaut32 user32 advapi32 kernel32 +EXTRALIBS = -lstrmiids -luuid $(LIBUNICODE) +EXTRAINCL = -C_SRCS = qcap_main.c +C_SRCS = main.c regsvr.c capturegraph.c RC_SRCS = version.rc diff -Nru wine-old/dlls/qcap/qcap_main.c wine-new/dlls/qcap/qcap_main.c --- wine-old/dlls/qcap/qcap_main.c 2004-05-21 22:54:48.000000000 +0200 +++ wine-new/dlls/qcap/qcap_main.c 1970-01-01 01:00:00.000000000 +0100 @@ -1,43 +0,0 @@ -/* - * Qcap implementation - * - * Copyright (C) 2003 Dominik Strasser - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - */ - -#include "wine/debug.h" -#include "winerror.h" - - -WINE_DEFAULT_DEBUG_CHANNEL(qcap); - -/*********************************************************************** - * DllRegisterServer (QCAP.@) - */ -HRESULT WINAPI QCAP_DllRegisterServer() -{ - FIXME("(): stub\n"); - return 0; -} - -/*********************************************************************** - * DllGetClassObject (QCAP.@) - */ -HRESULT WINAPI QCAP_DllGetClassObject(REFCLSID rclsid, REFIID iid, LPVOID *ppv) -{ - FIXME("\n\tCLSID:\t%s,\n\tIID:\t%s\n",debugstr_guid(rclsid),debugstr_guid(iid)); - return CLASS_E_CLASSNOTAVAILABLE; -} diff -Nru wine-old/dlls/qcap/qcap_private.h wine-new/dlls/qcap/qcap_private.h --- wine-old/dlls/qcap/qcap_private.h 1970-01-01 01:00:00.000000000 +0100 +++ wine-new/dlls/qcap/qcap_private.h 2005-04-09 16:11:33.000000000 +0200 @@ -0,0 +1,41 @@ +/* DirectShow private interfaces (QCap.DLL) + * All classes & functions are related to capture + * + * Copyright 2005 + * + * This file contains the (internal) driver registration functions, + * driver enumeration APIs and DirectDraw creation functions. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#ifndef __QCAP_PRIVATE_INCLUDED__ +#define __QCAP_PRIVATE_INCLUDED__ + +#include <stdarg.h> + +#define COBJMACROS + +#include "windef.h" +#include "winbase.h" +#include "wtypes.h" +#include "wingdi.h" +#include "winuser.h" +#include "dshow.h" + +const char * qcdebugstr_guid( const GUID * id ); + +#endif /* __QCAP_PRIVATE_INCLUDED__ */ + diff -Nru wine-old/dlls/qcap/qcap.spec wine-new/dlls/qcap/qcap.spec --- wine-old/dlls/qcap/qcap.spec 2003-07-30 05:48:55.000000000 +0200 +++ wine-new/dlls/qcap/qcap.spec 2005-04-09 16:11:33.000000000 +0200 @@ -1,4 +1,4 @@ -@ stub DllCanUnloadNow +@ stdcall -private DllCanUnloadNow() QCAP_DllCanUnloadNow @ stdcall -private DllGetClassObject(ptr ptr ptr) QCAP_DllGetClassObject @ stdcall -private DllRegisterServer() QCAP_DllRegisterServer -@ stub DllUnregisterServer +@ stdcall -private DllUnregisterServer() QCAP_DllUnregisterServer diff -Nru wine-old/dlls/qcap/regsvr.c wine-new/dlls/qcap/regsvr.c --- wine-old/dlls/qcap/regsvr.c 1970-01-01 01:00:00.000000000 +0100 +++ wine-new/dlls/qcap/regsvr.c 2005-04-09 16:11:34.000000000 +0200 @@ -0,0 +1,922 @@ +/* + * self-registerable dll functions for qcap.dll + * + * Copyright (C) 2003 John K. Hohm + * Modified by Maarten Lankhorst to work with V4W (Video for wine) + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#define NONAMELESSUNION +#define NONAMELESSSTRUCT +#define COBJMACROS +#define COM_NO_WINDOWS_H +#include <stdarg.h> +#include <string.h> + +#include "windef.h" +#include "winbase.h" +#include "winuser.h" +#include "winreg.h" +#include "winerror.h" + +#include "ole2.h" +#include "uuids.h" +#include "strmif.h" + +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(qcap); + +/* + * Near the bottom of this file are the exported DllRegisterServer and + * DllUnregisterServer, which make all this worthwhile. + */ + +/*********************************************************************** + * interface for self-registering + */ +struct regsvr_interface +{ + IID const *iid; /* NULL for end of list */ + LPCSTR name; /* can be NULL to omit */ + IID const *base_iid; /* can be NULL to omit */ + int num_methods; /* can be <0 to omit */ + CLSID const *ps_clsid; /* can be NULL to omit */ + CLSID const *ps_clsid32; /* can be NULL to omit */ +}; + +static HRESULT register_interfaces(struct regsvr_interface const *list); +static HRESULT unregister_interfaces(struct regsvr_interface const *list); + +struct regsvr_coclass +{ + CLSID const *clsid; /* NULL for end of list */ + LPCSTR name; /* can be NULL to omit */ + LPCSTR ips; /* can be NULL to omit */ + LPCSTR ips32; /* can be NULL to omit */ + LPCSTR ips32_tmodel; /* can be NULL to omit */ + LPCSTR progid; /* can be NULL to omit */ + LPCSTR viprogid; /* can be NULL to omit */ + LPCSTR progid_extra; /* can be NULL to omit */ +}; + +static HRESULT register_coclasses(struct regsvr_coclass const *list); +static HRESULT unregister_coclasses(struct regsvr_coclass const *list); + +struct regsvr_mediatype_parsing +{ + CLSID const *majortype; /* NULL for end of list */ + CLSID const *subtype; + LPCSTR line[11]; /* NULL for end of list */ +}; + +static HRESULT register_mediatypes_parsing(struct regsvr_mediatype_parsing const *list); +static HRESULT unregister_mediatypes_parsing(struct regsvr_mediatype_parsing const *list); + +struct regsvr_mediatype_extension +{ + CLSID const *majortype; /* NULL for end of list */ + CLSID const *subtype; + LPCSTR extension; +}; + +struct mediatype +{ + CLSID const *majortype; /* NULL for end of list */ + CLSID const *subtype; + DWORD fourcc; +}; + +struct pin +{ + DWORD flags; /* 0xFFFFFFFF for end of list */ + struct mediatype mediatypes[11]; +}; + +struct regsvr_filter +{ + CLSID const *clsid; /* NULL for end of list */ + CLSID const *category; + WCHAR name[50]; + DWORD merit; + struct pin pins[11]; +}; + +static HRESULT register_mediatypes_extension(struct regsvr_mediatype_extension const *list); +static HRESULT unregister_mediatypes_extension(struct regsvr_mediatype_extension const *list); + +static HRESULT register_filters(struct regsvr_filter const *list); +static HRESULT unregister_filters(struct regsvr_filter const *list); + +/*********************************************************************** + * static string constants + */ +static WCHAR const interface_keyname[10] = { + 'I', 'n', 't', 'e', 'r', 'f', 'a', 'c', 'e', 0 }; +static WCHAR const base_ifa_keyname[14] = { + 'B', 'a', 's', 'e', 'I', 'n', 't', 'e', 'r', 'f', 'a', 'c', + 'e', 0 }; +static WCHAR const num_methods_keyname[11] = { + 'N', 'u', 'm', 'M', 'e', 't', 'h', 'o', 'd', 's', 0 }; +static WCHAR const ps_clsid_keyname[15] = { + 'P', 'r', 'o', 'x', 'y', 'S', 't', 'u', 'b', 'C', 'l', 's', + 'i', 'd', 0 }; +static WCHAR const ps_clsid32_keyname[17] = { + 'P', 'r', 'o', 'x', 'y', 'S', 't', 'u', 'b', 'C', 'l', 's', + 'i', 'd', '3', '2', 0 }; +static WCHAR const clsid_keyname[6] = { + 'C', 'L', 'S', 'I', 'D', 0 }; +static WCHAR const curver_keyname[7] = { + 'C', 'u', 'r', 'V', 'e', 'r', 0 }; +static WCHAR const ips_keyname[13] = { + 'I', 'n', 'P', 'r', 'o', 'c', 'S', 'e', 'r', 'v', 'e', 'r', + 0 }; +static WCHAR const ips32_keyname[15] = { + 'I', 'n', 'P', 'r', 'o', 'c', 'S', 'e', 'r', 'v', 'e', 'r', + '3', '2', 0 }; +static WCHAR const progid_keyname[7] = { + 'P', 'r', 'o', 'g', 'I', 'D', 0 }; +static WCHAR const viprogid_keyname[25] = { + 'V', 'e', 'r', 's', 'i', 'o', 'n', 'I', 'n', 'd', 'e', 'p', + 'e', 'n', 'd', 'e', 'n', 't', 'P', 'r', 'o', 'g', 'I', 'D', + 0 }; +static char const tmodel_valuename[] = "ThreadingModel"; +static WCHAR const mediatype_name[11] = { + 'M', 'e', 'd', 'i', 'a', ' ', 'T', 'y', 'p', 'e', 0 }; +static WCHAR const subtype_valuename[8] = { + 'S', 'u', 'b', 't', 'y', 'p', 'e', 0 }; +static WCHAR const sourcefilter_valuename[14] = { + 'S', 'o', 'u', 'r', 'c', 'e', ' ', 'F', 'i', 'l', 't', 'e', 'r', 0 }; +static WCHAR const extensions_keyname[11] = { + 'E', 'x', 't', 'e', 'n', 's', 'i', 'o', 'n', 's', 0 }; + +/*********************************************************************** + * static helper functions + */ +static LONG register_key_guid(HKEY base, WCHAR const *name, GUID const *guid); +static LONG register_key_defvalueW(HKEY base, WCHAR const *name, + WCHAR const *value); +static LONG register_key_defvalueA(HKEY base, WCHAR const *name, + char const *value); +static LONG register_progid(WCHAR const *clsid, + char const *progid, char const *curver_progid, + char const *name, char const *extra); +static LONG recursive_delete_key(HKEY key); +static LONG recursive_delete_keyA(HKEY base, char const *name); +static LONG recursive_delete_keyW(HKEY base, WCHAR const *name); + +/*********************************************************************** + * register_interfaces + */ +static HRESULT register_interfaces(struct regsvr_interface const *list) +{ + LONG res = ERROR_SUCCESS; + HKEY interface_key; + + res = RegCreateKeyExW(HKEY_CLASSES_ROOT, interface_keyname, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &interface_key, NULL); + if (res != ERROR_SUCCESS) goto error_return; + + for (; res == ERROR_SUCCESS && list->iid; ++list) { + WCHAR buf[39]; + HKEY iid_key; + + StringFromGUID2(list->iid, buf, 39); + res = RegCreateKeyExW(interface_key, buf, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &iid_key, NULL); + if (res != ERROR_SUCCESS) goto error_close_interface_key; + + if (list->name) { + res = RegSetValueExA(iid_key, NULL, 0, REG_SZ, + (CONST BYTE*)(list->name), + strlen(list->name) + 1); + if (res != ERROR_SUCCESS) goto error_close_iid_key; + } + + if (list->base_iid) { + register_key_guid(iid_key, base_ifa_keyname, list->base_iid); + if (res != ERROR_SUCCESS) goto error_close_iid_key; + } + + if (0 <= list->num_methods) { + static WCHAR const fmt[3] = { '%', 'd', 0 }; + HKEY key; + + res = RegCreateKeyExW(iid_key, num_methods_keyname, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &key, NULL); + if (res != ERROR_SUCCESS) goto error_close_iid_key; + + wsprintfW(buf, fmt, list->num_methods); + res = RegSetValueExW(key, NULL, 0, REG_SZ, + (CONST BYTE*)buf, + (lstrlenW(buf) + 1) * sizeof(WCHAR)); + RegCloseKey(key); + + if (res != ERROR_SUCCESS) goto error_close_iid_key; + } + + if (list->ps_clsid) { + register_key_guid(iid_key, ps_clsid_keyname, list->ps_clsid); + if (res != ERROR_SUCCESS) goto error_close_iid_key; + } + + if (list->ps_clsid32) { + register_key_guid(iid_key, ps_clsid32_keyname, list->ps_clsid32); + if (res != ERROR_SUCCESS) goto error_close_iid_key; + } + + error_close_iid_key: + RegCloseKey(iid_key); + } + +error_close_interface_key: + RegCloseKey(interface_key); +error_return: + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * unregister_interfaces + */ +static HRESULT unregister_interfaces(struct regsvr_interface const *list) +{ + LONG res = ERROR_SUCCESS; + HKEY interface_key; + + res = RegOpenKeyExW(HKEY_CLASSES_ROOT, interface_keyname, 0, + KEY_READ | KEY_WRITE, &interface_key); + if (res == ERROR_FILE_NOT_FOUND) return S_OK; + if (res != ERROR_SUCCESS) goto error_return; + + for (; res == ERROR_SUCCESS && list->iid; ++list) { + WCHAR buf[39]; + + StringFromGUID2(list->iid, buf, 39); + res = recursive_delete_keyW(interface_key, buf); + } + + RegCloseKey(interface_key); +error_return: + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * register_coclasses + */ +static HRESULT register_coclasses(struct regsvr_coclass const *list) +{ + LONG res = ERROR_SUCCESS; + HKEY coclass_key; + + res = RegCreateKeyExW(HKEY_CLASSES_ROOT, clsid_keyname, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &coclass_key, NULL); + if (res != ERROR_SUCCESS) goto error_return; + + for (; res == ERROR_SUCCESS && list->clsid; ++list) { + WCHAR buf[39]; + HKEY clsid_key; + + StringFromGUID2(list->clsid, buf, 39); + res = RegCreateKeyExW(coclass_key, buf, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &clsid_key, NULL); + if (res != ERROR_SUCCESS) goto error_close_coclass_key; + + if (list->name) { + res = RegSetValueExA(clsid_key, NULL, 0, REG_SZ, + (CONST BYTE*)(list->name), + strlen(list->name) + 1); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + } + + if (list->ips) { + res = register_key_defvalueA(clsid_key, ips_keyname, list->ips); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + } + + if (list->ips32) { + HKEY ips32_key; + + res = RegCreateKeyExW(clsid_key, ips32_keyname, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, + &ips32_key, NULL); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + + res = RegSetValueExA(ips32_key, NULL, 0, REG_SZ, + (CONST BYTE*)list->ips32, + lstrlenA(list->ips32) + 1); + if (res == ERROR_SUCCESS && list->ips32_tmodel) + res = RegSetValueExA(ips32_key, tmodel_valuename, 0, REG_SZ, + (CONST BYTE*)list->ips32_tmodel, + strlen(list->ips32_tmodel) + 1); + RegCloseKey(ips32_key); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + } + + if (list->progid) { + res = register_key_defvalueA(clsid_key, progid_keyname, + list->progid); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + + res = register_progid(buf, list->progid, NULL, + list->name, list->progid_extra); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + } + + if (list->viprogid) { + res = register_key_defvalueA(clsid_key, viprogid_keyname, + list->viprogid); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + + res = register_progid(buf, list->viprogid, list->progid, + list->name, list->progid_extra); + if (res != ERROR_SUCCESS) goto error_close_clsid_key; + } + + error_close_clsid_key: + RegCloseKey(clsid_key); + } + +error_close_coclass_key: + RegCloseKey(coclass_key); +error_return: + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * unregister_coclasses + */ +static HRESULT unregister_coclasses(struct regsvr_coclass const *list) +{ + LONG res = ERROR_SUCCESS; + HKEY coclass_key; + + res = RegOpenKeyExW(HKEY_CLASSES_ROOT, clsid_keyname, 0, + KEY_READ | KEY_WRITE, &coclass_key); + if (res == ERROR_FILE_NOT_FOUND) return S_OK; + if (res != ERROR_SUCCESS) goto error_return; + + for (; res == ERROR_SUCCESS && list->clsid; ++list) { + WCHAR buf[39]; + + StringFromGUID2(list->clsid, buf, 39); + res = recursive_delete_keyW(coclass_key, buf); + if (res != ERROR_SUCCESS) goto error_close_coclass_key; + + if (list->progid) { + res = recursive_delete_keyA(HKEY_CLASSES_ROOT, list->progid); + if (res != ERROR_SUCCESS) goto error_close_coclass_key; + } + + if (list->viprogid) { + res = recursive_delete_keyA(HKEY_CLASSES_ROOT, list->viprogid); + if (res != ERROR_SUCCESS) goto error_close_coclass_key; + } + } + +error_close_coclass_key: + RegCloseKey(coclass_key); +error_return: + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * register_mediatypes_parsing + */ +static HRESULT register_mediatypes_parsing(struct regsvr_mediatype_parsing const *list) +{ + LONG res = ERROR_SUCCESS; + HKEY mediatype_key; + WCHAR buf[39]; + int i; + + res = RegCreateKeyExW(HKEY_CLASSES_ROOT, mediatype_name, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &mediatype_key, NULL); + if (res != ERROR_SUCCESS) return HRESULT_FROM_WIN32(res); + + for (; res == ERROR_SUCCESS && list->majortype; ++list) { + HKEY majortype_key = NULL; + HKEY subtype_key = NULL; + + StringFromGUID2(list->majortype, buf, 39); + res = RegCreateKeyExW(mediatype_key, buf, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &majortype_key, NULL); + if (res != ERROR_SUCCESS) goto error_close_keys; + + StringFromGUID2(list->subtype, buf, 39); + res = RegCreateKeyExW(majortype_key, buf, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &subtype_key, NULL); + if (res != ERROR_SUCCESS) goto error_close_keys; + + StringFromGUID2(&CLSID_AsyncReader, buf, 39); + res = RegSetValueExW(subtype_key, sourcefilter_valuename, 0, REG_SZ, (CONST BYTE*)buf, + (lstrlenW(buf) + 1) * sizeof(WCHAR)); + if (res != ERROR_SUCCESS) goto error_close_keys; + + for(i = 0; list->line[i]; i++) { + char buffer[3]; + wsprintfA(buffer, "%d", i); + res = RegSetValueExA(subtype_key, buffer, 0, REG_SZ, (CONST BYTE*)list->line[i], + lstrlenA(list->line[i])); + if (res != ERROR_SUCCESS) goto error_close_keys; + } + +error_close_keys: + if (majortype_key) + RegCloseKey(majortype_key); + if (subtype_key) + RegCloseKey(subtype_key); + } + + RegCloseKey(mediatype_key); + + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * register_mediatypes_extension + */ +static HRESULT register_mediatypes_extension(struct regsvr_mediatype_extension const *list) +{ + LONG res = ERROR_SUCCESS; + HKEY mediatype_key; + HKEY extensions_root_key = NULL; + WCHAR buf[39]; + + res = RegCreateKeyExW(HKEY_CLASSES_ROOT, mediatype_name, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &mediatype_key, NULL); + if (res != ERROR_SUCCESS) return HRESULT_FROM_WIN32(res); + + res = RegCreateKeyExW(mediatype_key, extensions_keyname, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &extensions_root_key, NULL); + if (res != ERROR_SUCCESS) goto error_return; + + for (; res == ERROR_SUCCESS && list->majortype; ++list) { + HKEY extension_key; + + res = RegCreateKeyExA(extensions_root_key, list->extension, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &extension_key, NULL); + if (res != ERROR_SUCCESS) break; + + StringFromGUID2(list->majortype, buf, 39); + res = RegSetValueExW(extension_key, mediatype_name, 0, REG_SZ, (CONST BYTE*)buf, + (lstrlenW(buf) + 1) * sizeof(WCHAR)); + if (res != ERROR_SUCCESS) goto error_close_key; + + StringFromGUID2(list->subtype, buf, 39); + res = RegSetValueExW(extension_key, subtype_valuename, 0, REG_SZ, (CONST BYTE*)buf, + (lstrlenW(buf) + 1) * sizeof(WCHAR)); + if (res != ERROR_SUCCESS) goto error_close_key; + + StringFromGUID2(&CLSID_AsyncReader, buf, 39); + res = RegSetValueExW(extension_key, sourcefilter_valuename, 0, REG_SZ, (CONST BYTE*)buf, + (lstrlenW(buf) + 1) * sizeof(WCHAR)); + if (res != ERROR_SUCCESS) goto error_close_key; + +error_close_key: + RegCloseKey(extension_key); + } + +error_return: + RegCloseKey(mediatype_key); + if (extensions_root_key) + RegCloseKey(extensions_root_key); + + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * unregister_mediatypes_parsing + */ +static HRESULT unregister_mediatypes_parsing(struct regsvr_mediatype_parsing const *list) +{ + LONG res; + HKEY mediatype_key; + HKEY majortype_key; + WCHAR buf[39]; + + res = RegOpenKeyExW(HKEY_CLASSES_ROOT, mediatype_name, 0, + KEY_READ | KEY_WRITE, &mediatype_key); + if (res == ERROR_FILE_NOT_FOUND) return S_OK; + if (res != ERROR_SUCCESS) return HRESULT_FROM_WIN32(res); + + for (; res == ERROR_SUCCESS && list->majortype; ++list) { + StringFromGUID2(list->majortype, buf, 39); + res = RegOpenKeyExW(mediatype_key, buf, 0, + KEY_READ | KEY_WRITE, &majortype_key); + if (res == ERROR_FILE_NOT_FOUND) { + res = ERROR_SUCCESS; + continue; + } + if (res != ERROR_SUCCESS) break; + + StringFromGUID2(list->subtype, buf, 39); + res = recursive_delete_keyW(majortype_key, buf); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; + + /* Removed majortype key if there is no more subtype key */ + res = RegDeleteKeyW(majortype_key, 0); + if (res == ERROR_ACCESS_DENIED) res = ERROR_SUCCESS; + + RegCloseKey(majortype_key); + } + + RegCloseKey(mediatype_key); + + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * unregister_mediatypes_extension + */ +static HRESULT unregister_mediatypes_extension(struct regsvr_mediatype_extension const *list) +{ + LONG res; + HKEY mediatype_key; + HKEY extensions_root_key = NULL; + + res = RegOpenKeyExW(HKEY_CLASSES_ROOT, mediatype_name, 0, + KEY_READ | KEY_WRITE, &mediatype_key); + if (res == ERROR_FILE_NOT_FOUND) return S_OK; + if (res != ERROR_SUCCESS) return HRESULT_FROM_WIN32(res); + + res = RegOpenKeyExW(mediatype_key, extensions_keyname, 0, + KEY_READ | KEY_WRITE, &extensions_root_key); + if (res == ERROR_FILE_NOT_FOUND) + res = ERROR_SUCCESS; + else if (res == ERROR_SUCCESS) + for (; res == ERROR_SUCCESS && list->majortype; ++list) { + res = recursive_delete_keyA(extensions_root_key, list->extension); + if (res == ERROR_FILE_NOT_FOUND) res = ERROR_SUCCESS; + } + + RegCloseKey(mediatype_key); + if (extensions_root_key) + RegCloseKey(extensions_root_key); + + return res != ERROR_SUCCESS ? HRESULT_FROM_WIN32(res) : S_OK; +} + +/*********************************************************************** + * register_filters + */ +static HRESULT register_filters(struct regsvr_filter const *list) +{ + HRESULT hr; + IFilterMapper2* pFM2 = NULL; + + CoInitialize(NULL); + hr = CoCreateInstance(&CLSID_FilterMapper2, NULL, CLSCTX_INPROC_SERVER, &IID_IFilterMapper2, (LPVOID*)&pFM2); + + if (SUCCEEDED(hr)) { + for (; SUCCEEDED(hr) && list->clsid; ++list) { + REGFILTER2 rf2; + REGFILTERPINS2* prfp2; + int i; + + for (i = 0; list->pins[i].flags != 0xFFFFFFFF; i++) ; + rf2.dwVersion = 2; + rf2.dwMerit = list->merit; + rf2.u.s1.cPins2 = i; + rf2.u.s1.rgPins2 = prfp2 = (REGFILTERPINS2*) CoTaskMemAlloc(i*sizeof(REGFILTERPINS2)); + if (!prfp2) { + hr = E_OUTOFMEMORY; + break; + } + for (i = 0; list->pins[i].flags != 0xFFFFFFFF; i++) { + REGPINTYPES* lpMediatype; + CLSID* lpClsid; + int j, nbmt; + + for (nbmt = 0; list->pins[i].mediatypes[nbmt].majortype; nbmt++) ; + /* Allocate a single buffer for regpintypes struct and clsids */ + lpMediatype = (REGPINTYPES*) CoTaskMemAlloc(nbmt*(sizeof(REGPINTYPES) + 2*sizeof(CLSID))); + if (!lpMediatype) { + hr = E_OUTOFMEMORY; + break; + } + lpClsid = (CLSID*) (lpMediatype + nbmt); + for (j = 0; j < nbmt; j++) { + (lpMediatype + j)->clsMajorType = lpClsid + j*2; + memcpy(lpClsid + j*2, list->pins[i].mediatypes[j].majortype, sizeof(CLSID)); + (lpMediatype + j)->clsMinorType = lpClsid + j*2 + 1; + if (list->pins[i].mediatypes[j].subtype) + memcpy(lpClsid + j*2 + 1, list->pins[i].mediatypes[j].subtype, sizeof(CLSID)); + else { + /* Subtype are often a combination of major type + fourcc/tag */ + memcpy(lpClsid + j*2 + 1, list->pins[i].mediatypes[j].majortype, sizeof(CLSID)); + *(DWORD*)(lpClsid + j*2 + 1) = list->pins[i].mediatypes[j].fourcc; + } + } + prfp2[i].dwFlags = list->pins[i].flags; + prfp2[i].cInstances = 0; + prfp2[i].nMediaTypes = j; + prfp2[i].lpMediaType = lpMediatype; + prfp2[i].nMediums = 0; + prfp2[i].lpMedium = NULL; + prfp2[i].clsPinCategory = NULL; + } + + if (FAILED(hr)) { + ERR("failed to register with hresult 0x%lx\n", hr); + CoTaskMemFree(prfp2); + break; + } + + hr = IFilterMapper2_RegisterFilter(pFM2, list->clsid, list->name, NULL, list->category, NULL, &rf2); + + while (i) { + CoTaskMemFree((REGPINTYPES*)prfp2[i-1].lpMediaType); + i--; + } + CoTaskMemFree(prfp2); + } + } + + if (pFM2) + IFilterMapper2_Release(pFM2); + + CoUninitialize(); + + return hr; +} + +/*********************************************************************** + * unregister_filters + */ +static HRESULT unregister_filters(struct regsvr_filter const *list) +{ + HRESULT hr; + IFilterMapper2* pFM2; + + CoInitialize(NULL); + + hr = CoCreateInstance(&CLSID_FilterMapper2, NULL, CLSCTX_INPROC_SERVER, &IID_IFilterMapper2, (LPVOID*)&pFM2); + + if (SUCCEEDED(hr)) { + for (; SUCCEEDED(hr) && list->clsid; ++list) + hr = IFilterMapper2_UnregisterFilter(pFM2, list->category, NULL, list->clsid); + IFilterMapper2_Release(pFM2); + } + + CoUninitialize(); + + return hr; +} + +/*********************************************************************** + * regsvr_key_guid + */ +static LONG register_key_guid(HKEY base, WCHAR const *name, GUID const *guid) +{ + WCHAR buf[39]; + + StringFromGUID2(guid, buf, 39); + return register_key_defvalueW(base, name, buf); +} + +/*********************************************************************** + * regsvr_key_defvalueW + */ +static LONG register_key_defvalueW( + HKEY base, + WCHAR const *name, + WCHAR const *value) +{ + LONG res; + HKEY key; + + res = RegCreateKeyExW(base, name, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &key, NULL); + if (res != ERROR_SUCCESS) return res; + res = RegSetValueExW(key, NULL, 0, REG_SZ, (CONST BYTE*)value, + (lstrlenW(value) + 1) * sizeof(WCHAR)); + RegCloseKey(key); + return res; +} + +/*********************************************************************** + * regsvr_key_defvalueA + */ +static LONG register_key_defvalueA( + HKEY base, + WCHAR const *name, + char const *value) +{ + LONG res; + HKEY key; + + res = RegCreateKeyExW(base, name, 0, NULL, 0, + KEY_READ | KEY_WRITE, NULL, &key, NULL); + if (res != ERROR_SUCCESS) return res; + res = RegSetValueExA(key, NULL, 0, REG_SZ, (CONST BYTE*)value, + lstrlenA(value) + 1); + RegCloseKey(key); + return res; +} + +/*********************************************************************** + * regsvr_progid + */ +static LONG register_progid( + WCHAR const *clsid, + char const *progid, + char const *curver_progid, + char const *name, + char const *extra) +{ + LONG res; + HKEY progid_key; + + res = RegCreateKeyExA(HKEY_CLASSES_ROOT, progid, 0, + NULL, 0, KEY_READ | KEY_WRITE, NULL, + &progid_key, NULL); + if (res != ERROR_SUCCESS) return res; + + if (name) { + res = RegSetValueExA(progid_key, NULL, 0, REG_SZ, + (CONST BYTE*)name, strlen(name) + 1); + if (res != ERROR_SUCCESS) goto error_close_progid_key; + } + + if (clsid) { + res = register_key_defvalueW(progid_key, clsid_keyname, clsid); + if (res != ERROR_SUCCESS) goto error_close_progid_key; + } + + if (curver_progid) { + res = register_key_defvalueA(progid_key, curver_keyname, + curver_progid); + if (res != ERROR_SUCCESS) goto error_close_progid_key; + } + + if (extra) { + HKEY extra_key; + + res = RegCreateKeyExA(progid_key, extra, 0, + NULL, 0, KEY_READ | KEY_WRITE, NULL, + &extra_key, NULL); + if (res == ERROR_SUCCESS) + RegCloseKey(extra_key); + } + +error_close_progid_key: + RegCloseKey(progid_key); + return res; +} + +/*********************************************************************** + * recursive_delete_key + */ +static LONG recursive_delete_key(HKEY key) +{ + LONG res; + WCHAR subkey_name[MAX_PATH]; + DWORD cName; + HKEY subkey; + + for (;;) { + cName = sizeof(subkey_name) / sizeof(WCHAR); + res = RegEnumKeyExW(key, 0, subkey_name, &cName, + NULL, NULL, NULL, NULL); + if (res != ERROR_SUCCESS && res != ERROR_MORE_DATA) { + res = ERROR_SUCCESS; /* presumably we're done enumerating */ + break; + } + res = RegOpenKeyExW(key, subkey_name, 0, + KEY_READ | KEY_WRITE, &subkey); + if (res == ERROR_FILE_NOT_FOUND) continue; + if (res != ERROR_SUCCESS) break; + + res = recursive_delete_key(subkey); + RegCloseKey(subkey); + if (res != ERROR_SUCCESS) break; + } + + if (res == ERROR_SUCCESS) res = RegDeleteKeyW(key, 0); + return res; +} + +/*********************************************************************** + * recursive_delete_keyA + */ +static LONG recursive_delete_keyA(HKEY base, char const *name) +{ + LONG res; + HKEY key; + + res = RegOpenKeyExA(base, name, 0, KEY_READ | KEY_WRITE, &key); + if (res == ERROR_FILE_NOT_FOUND) return ERROR_SUCCESS; + if (res != ERROR_SUCCESS) return res; + res = recursive_delete_key(key); + RegCloseKey(key); + return res; +} + +/*********************************************************************** + * recursive_delete_keyW + */ +static LONG recursive_delete_keyW(HKEY base, WCHAR const *name) +{ + LONG res; + HKEY key; + + res = RegOpenKeyExW(base, name, 0, KEY_READ | KEY_WRITE, &key); + if (res == ERROR_FILE_NOT_FOUND) return ERROR_SUCCESS; + if (res != ERROR_SUCCESS) return res; + res = recursive_delete_key(key); + RegCloseKey(key); + return res; +} + +/*********************************************************************** + * coclass list + */ +static struct regsvr_coclass const coclass_list[] = { + { NULL } /* list terminator */ +}; + +/*********************************************************************** + * interface list + */ + +static struct regsvr_interface const interface_list[] = { + { NULL } /* list terminator */ +}; + +/*********************************************************************** + * mediatype list + */ + +static struct regsvr_mediatype_parsing const mediatype_parsing_list[] = { + { NULL } /* list terminator */ +}; + +/*********************************************************************** + * mediatype list + */ + +static struct regsvr_mediatype_extension const mediatype_extension_list[] = { + { NULL } /* list terminator */ +}; + +/*********************************************************************** + * filter list + */ +static struct regsvr_filter const filter_list[] = { + { NULL } /* list terminator */ +}; + +/*********************************************************************** + * DllRegisterServer (QCAP.@) + */ +HRESULT WINAPI QCAP_DllRegisterServer(void) +{ + HRESULT hr; + + TRACE("\n"); + + hr = register_coclasses(coclass_list); + if (SUCCEEDED(hr)) + hr = register_interfaces(interface_list); + if (SUCCEEDED(hr)) + hr = register_mediatypes_parsing(mediatype_parsing_list); + if (SUCCEEDED(hr)) + hr = register_mediatypes_extension(mediatype_extension_list); + if (SUCCEEDED(hr)) + hr = register_filters(filter_list); + return hr; +} + +/*********************************************************************** + * DllUnregisterServer (QCAP.@) + */ +HRESULT WINAPI QCAP_DllUnregisterServer(void) +{ + HRESULT hr; + + TRACE("\n"); + + hr = unregister_filters(filter_list); + if (SUCCEEDED(hr)) + hr = unregister_coclasses(coclass_list); + if (SUCCEEDED(hr)) + hr = unregister_interfaces(interface_list); + if (SUCCEEDED(hr)) + hr = unregister_mediatypes_parsing(mediatype_parsing_list); + if (SUCCEEDED(hr)) + hr = unregister_mediatypes_extension(mediatype_extension_list); + return hr; +} diff -Nru wine-old/dlls/quartz/capturegraph.c wine-new/dlls/quartz/capturegraph.c --- wine-old/dlls/quartz/capturegraph.c 1970-01-01 01:00:00.000000000 +0100 +++ wine-new/dlls/quartz/capturegraph.c 2005-04-09 16:11:36.000000000 +0200 @@ -0,0 +1,202 @@ +/* Copyright 2005 Maarten Lankhorst, Goal is to get MSN's webcam function to work.. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include "config.h" + +#define NONAMELESSSTRUCT +#define NONAMELESSUNION +#include "quartz_private.h" + +#include "uuids.h" +#include "mmreg.h" +#include "vfwmsgs.h" +#include "amvideo.h" +#include "windef.h" +#include "winbase.h" +#include "dshow.h" +#include "evcode.h" +#include "strmif.h" +#include "ddraw.h" + +#include "wine/unicode.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(quartz); + +static const WCHAR wcsInputPinName[] = {'i','n','p','u','t',' ','p','i','n',0}; + +static const ICaptureGraphBuilderVtbl Builder_Vtbl; + +typedef struct CaptureGraphImpl +{ + const ICaptureGraphBuilderVtbl * lpVtbl; + IGraphBuilder *mygraph; + + ULONG refCount; + CRITICAL_SECTION csFilter; +} CaptureGraphImpl; + +HRESULT CaptureGraphBuilder_create(IUnknown * pUnkOuter, LPVOID * ppv) +{ + CaptureGraphImpl * pCapture; + TRACE("(%p, %p)\n", pUnkOuter, ppv); + *ppv = NULL; + if (pUnkOuter) return CLASS_E_NOAGGREGATION; + pCapture = CoTaskMemAlloc(sizeof(CaptureGraphImpl)); + pCapture->lpVtbl = &Builder_Vtbl; + pCapture->refCount = 1; + pCapture->mygraph = NULL; + InitializeCriticalSection(&pCapture->csFilter); + *ppv = (LPVOID)pCapture; + return S_OK; +} + +static HRESULT WINAPI CaptureGraphBuilder_QueryInterface(ICaptureGraphBuilder * iface, REFIID riid, LPVOID * ppv) +{ + struct CaptureGraphImpl *This = (CaptureGraphImpl *)iface; + TRACE("(%p/%p)->(%s, %p)\n", This, iface, qzdebugstr_guid(riid), ppv); + *ppv = NULL; + if (IsEqualIID(riid, &IID_IUnknown)) + *ppv = (LPVOID)This; + else if (IsEqualIID(riid, &IID_ICaptureGraphBuilder)) + { + *ppv = (LPVOID)This; + TRACE("Asking for myself?\n"); + } + + if (*ppv) + { + IUnknown_AddRef((IUnknown *)(*ppv)); + return S_OK; + } + + FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); + return E_NOINTERFACE; +} + +static ULONG WINAPI CaptureGraphBuilder_AddRef(ICaptureGraphBuilder * iface) +{ + CaptureGraphImpl *This = (CaptureGraphImpl *)iface; + ULONG refCount = InterlockedIncrement(&This->refCount); + + TRACE("(%p/%p)->() AddRef from %ld\n", This, iface, refCount - 1); + return refCount; +} + +static ULONG WINAPI CaptureGraphBuilder_Release(ICaptureGraphBuilder * iface) +{ + CaptureGraphImpl *This = (CaptureGraphImpl *)iface; + ULONG refCount = InterlockedDecrement(&This->refCount); + + TRACE("(%p/%p)->() Release from %ld\n", This, iface, refCount + 1); + + if (!refCount) { + FIXME("Release IGraphFilter or w/e\n"); + DeleteCriticalSection(&This->csFilter); + This->lpVtbl = NULL; + if (This->mygraph != NULL) + IGraphBuilder_Release((IGraphBuilder *)This->mygraph); + CoTaskMemFree(This); + return 0; + } + else return refCount; +} + +static HRESULT WINAPI CaptureGraphBuilder_SetFilterGraph(ICaptureGraphBuilder * iface, IGraphBuilder *pfg) +{ +/* The graph builder will automatically create a filter graph if you don't call this method. If you call this method after the graph builder has created its own filter graph, the call will fail. */ + struct CaptureGraphImpl *This = (CaptureGraphImpl *)iface; + if (This->mygraph != NULL) return E_FAIL; + This->mygraph = pfg; + IGraphBuilder_AddRef((IGraphBuilder *)This->mygraph); + TRACE("%p: %p\n", iface, pfg); + return S_OK; +} + +static HRESULT WINAPI CaptureGraphBuilder_GetFilterGraph(ICaptureGraphBuilder * iface, IGraphBuilder **pfg) +{ + struct CaptureGraphImpl *This = (CaptureGraphImpl *)iface; + FIXME("%p: Make our own filtergraph if we haven't got one already\n", iface); + if (This->mygraph == NULL) return E_FAIL; + + *pfg = This->mygraph; + IGraphBuilder_AddRef((IGraphBuilder *)This->mygraph); + + TRACE("%p: %p\n", iface, *pfg); + return S_OK; +} + +static HRESULT WINAPI CaptureGraphBuilder_SetOutputFileName(ICaptureGraphBuilder * iface, const GUID *pType, LPCOLESTR lpstrFile,IBaseFilter **ppf, IFileSinkFilter **ppSink) +{ + FIXME("%p: %p, %p, %p, %p - stub\n", iface, pType, lpstrFile, *ppf, *ppSink); + return E_FAIL; +} + +static HRESULT WINAPI CaptureGraphBuilder_FindInterface(ICaptureGraphBuilder * iface, const GUID *pCategory, IBaseFilter *pf, REFIID riid, void **ppint) +{ + struct CaptureGraphImpl *This = (CaptureGraphImpl *)iface; + TRACE("%p: %s .. %p .. %s .. %p - unwanted untested unguaranteed unwarranted unreliable stub workaround!\n", iface, qzdebugstr_guid(pCategory), pf, qzdebugstr_guid(riid), *ppint); + return IBaseFilter_QueryInterface(pf, riid, ppint); + /* Looks for the specified interface on the filter, upstream and downstream from the filter, and, optionally, only on the output pin of the given category. */ +} + +/* [call_as(FindInterface)] HRESULT RemoteFindInterface( + [in, unique] const GUID *pCategory, + [in] IBaseFilter *pf, + [in] REFIID riid, + [out] IUnknown **ppint); + ^- What is this? */ + +static HRESULT WINAPI CaptureGraphBuilder_RenderStream(ICaptureGraphBuilder * iface, const GUID *pCategory, IUnknown *pSource, IBaseFilter *pfCompressor, IBaseFilter *pfRenderer) +{ + FIXME("%p: .. Stub? !!! -- SHOULD NORMALLY WORK!!..\n", iface); + return E_FAIL; +} + +static HRESULT WINAPI CaptureGraphBuilder_ControlStream(ICaptureGraphBuilder * iface, const GUID *pCategory, IBaseFilter *pFilter, REFERENCE_TIME *pstart, REFERENCE_TIME *pstop, WORD wStartCookie, WORD wStopCookie) +{ + FIXME("%p: .. Stub? !!! ..\n", iface); + return E_FAIL; +} + +static HRESULT WINAPI CaptureGraphBuilder_AllocCapFile(ICaptureGraphBuilder * iface, LPCOLESTR lpstr, DWORDLONG dwlSize) +{ + FIXME("%p: .. Stub? !!! ..\n", iface); + return E_FAIL; +} + +static HRESULT WINAPI CaptureGraphBuilder_CopyCaptureFile(ICaptureGraphBuilder * iface, LPOLESTR lpwstrOld, LPOLESTR lpwstrNew, int fAllowEscAbort, IAMCopyCaptureFileProgress *pCallback) +{ + FIXME("%p: .. Stub? !!! ..\n", iface); + return E_FAIL; +} + +static const ICaptureGraphBuilderVtbl Builder_Vtbl = +{ + CaptureGraphBuilder_QueryInterface, + CaptureGraphBuilder_AddRef, + CaptureGraphBuilder_Release, + CaptureGraphBuilder_SetFilterGraph, + CaptureGraphBuilder_GetFilterGraph, + CaptureGraphBuilder_SetOutputFileName, + CaptureGraphBuilder_FindInterface, + CaptureGraphBuilder_RenderStream, + CaptureGraphBuilder_ControlStream, + CaptureGraphBuilder_AllocCapFile, + CaptureGraphBuilder_CopyCaptureFile +}; + diff -Nru wine-old/dlls/quartz/filesource.c wine-new/dlls/quartz/filesource.c --- wine-old/dlls/quartz/filesource.c 2005-01-06 20:36:47.000000000 +0100 +++ wine-new/dlls/quartz/filesource.c 2005-04-09 16:11:35.000000000 +0200 @@ -663,17 +663,6 @@ FileSource_GetCurFile }; - -/* the dwUserData passed back to user */ -typedef struct DATAREQUEST -{ - IMediaSample * pSample; /* sample passed to us by user */ - DWORD_PTR dwUserData; /* user data passed to us */ - OVERLAPPED ovl; /* our overlapped structure */ - - struct DATAREQUEST * pNext; /* next data request in list */ -} DATAREQUEST; - void queue(DATAREQUEST * pHead, DATAREQUEST * pItem) { DATAREQUEST * pCurrent; diff -Nru wine-old/dlls/quartz/filtergraph.c wine-new/dlls/quartz/filtergraph.c --- wine-old/dlls/quartz/filtergraph.c 2005-03-02 11:12:12.000000000 +0100 +++ wine-new/dlls/quartz/filtergraph.c 2005-04-09 16:11:35.000000000 +0200 @@ -40,7 +40,6 @@ #include "evcode.h" #include "wine/unicode.h" - WINE_DEFAULT_DEBUG_CHANNEL(quartz); typedef struct { diff -Nru wine-old/dlls/quartz/main.c wine-new/dlls/quartz/main.c --- wine-old/dlls/quartz/main.c 2005-03-02 13:23:22.000000000 +0100 +++ wine-new/dlls/quartz/main.c 2005-04-09 16:11:35.000000000 +0200 @@ -71,7 +71,9 @@ { &CLSID_AVIDec, AVIDec_create }, { &CLSID_SystemClock, &QUARTZ_CreateSystemClock }, { &CLSID_ACMWrapper, &ACMWrapper_create }, - { &CLSID_WAVEParser, &WAVEParser_create } + { &CLSID_VfwCapture, &VfwCapture_create }, + { &CLSID_WAVEParser, &WAVEParser_create }, + { &CLSID_CaptureGraphBuilder, &CaptureGraphBuilder_create } }; static HRESULT WINAPI diff -Nru wine-old/dlls/quartz/Makefile.in wine-new/dlls/quartz/Makefile.in --- wine-old/dlls/quartz/Makefile.in 2005-02-10 18:13:18.000000000 +0100 +++ wine-new/dlls/quartz/Makefile.in 2005-04-09 16:11:35.000000000 +0200 @@ -28,6 +28,8 @@ systemclock.c \ transform.c \ videorenderer.c \ + v4wsource.c \ + capturegraph.c \ waveparser.c RC_SRCS = version.rc diff -Nru wine-old/dlls/quartz/quartz_private.h wine-new/dlls/quartz/quartz_private.h --- wine-old/dlls/quartz/quartz_private.h 2005-02-10 18:13:18.000000000 +0100 +++ wine-new/dlls/quartz/quartz_private.h 2005-04-09 16:11:35.000000000 +0200 @@ -52,6 +52,8 @@ HRESULT QUARTZ_CreateSystemClock(IUnknown * pUnkOuter, LPVOID * ppv); HRESULT ACMWrapper_create(IUnknown * pUnkOuter, LPVOID * ppv); HRESULT WAVEParser_create(IUnknown * pUnkOuter, LPVOID * ppv); +HRESULT VfwCapture_create(IUnknown * pUnkOuter, LPVOID * ppv); +HRESULT CaptureGraphBuilder_create(IUnknown * pUnkOuter, LPVOID * ppv); HRESULT EnumMonikerImpl_Create(IMoniker ** ppMoniker, ULONG nMonikerCount, IEnumMoniker ** ppEnum); @@ -80,4 +82,14 @@ BOOL CompareMediaTypes(const AM_MEDIA_TYPE * pmt1, const AM_MEDIA_TYPE * pmt2, BOOL bWildcards); void dump_AM_MEDIA_TYPE(const AM_MEDIA_TYPE * pmt); +typedef struct DATAREQUEST +{ + IMediaSample * pSample; /* sample passed to us by user */ + DWORD_PTR dwUserData; /* user data passed to us */ + OVERLAPPED ovl; /* our overlapped structure */ + + struct DATAREQUEST * pNext; /* next data request in list */ +} DATAREQUEST; + +void queue(DATAREQUEST * pHead, DATAREQUEST * pItem); #endif /* __QUARTZ_PRIVATE_INCLUDED__ */ diff -Nru wine-old/dlls/quartz/regsvr.c wine-new/dlls/quartz/regsvr.c --- wine-old/dlls/quartz/regsvr.c 2005-02-10 18:13:18.000000000 +0100 +++ wine-new/dlls/quartz/regsvr.c 2005-04-09 16:11:35.000000000 +0200 @@ -922,6 +922,18 @@ "quartz.dll", "Both" }, + { &CLSID_VfwCapture, + "Video for wine capture interface", + NULL, + "quartz.dll", + "Both" + }, + { &CLSID_CaptureGraphBuilder, + "Capture Graph Builder", + NULL, + "quartz.dll", + "Both" + }, { NULL } /* list terminator */ }; @@ -1112,6 +1124,18 @@ { 0xFFFFFFFF }, } }, + { &CLSID_VfwCapture, + &CLSID_VideoInputDeviceCategory, + {'V','i','d','e','o',' ','F','o','r',' ','W','i','n','e',' ','(','V','4','W',')', 0}, + 0x800000, + { { REG_PINFLAG_B_OUTPUT, + { { &MEDIATYPE_Stream, &GUID_NULL }, + { NULL } + }, + }, + { 0xFFFFFFFF }, + } + }, /* This creates a fake device for us with an ugly name */ { NULL } /* list terminator */ }; diff -Nru wine-old/dlls/quartz/v4wsource.c wine-new/dlls/quartz/v4wsource.c --- wine-old/dlls/quartz/v4wsource.c 1970-01-01 01:00:00.000000000 +0100 +++ wine-new/dlls/quartz/v4wsource.c 2005-04-09 16:11:36.000000000 +0200 @@ -0,0 +1,703 @@ +/* Video For Windows Steering structure + * + * Copyright 2005 Maarten Lankhorst + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * LETS SING IT ALL TOGETHER NOW! ON MY MARK! + * COM SUCKS ASS! + */ + +#define NONAMELESSSTRUCT +#define NONAMELESSUNION +#include "quartz_private.h" +#include "control_private.h" +#include "pin.h" + +#include "uuids.h" +#include "mmreg.h" +#include "vfwmsgs.h" +#include "amvideo.h" +#include "fourcc.h" +#include "windef.h" +#include "winbase.h" +#include "dshow.h" +#include "strmif.h" +#include "ddraw.h" + +#include "wine/unicode.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(quartz); + +static const IBaseFilterVtbl VfwCapture_Vtbl; +static const IAMStreamConfigVtbl IAMStreamConfig_VTable; +static const IPinVtbl VfwPin_Vtbl; + +static HRESULT VfwPin_Construct(IBaseFilter * pBaseFilter, LPCRITICAL_SECTION pCritSec, IPin ** ppPin); +static const WCHAR wszOutputPinName[] = { 'O','u','t','p','u','t',0 }; + +typedef struct VfwCapture +{ + const struct IBaseFilterVtbl * lpVtbl; + const struct IAMStreamConfigVtbl * IAMStreamConfig_vtbl; + + ULONG refCount; + FILTER_INFO filterInfo; + FILTER_STATE state; + CRITICAL_SECTION csFilter; + + IPin * pOutputPin; + AM_MEDIA_TYPE * pmt; +} VfwCapture; + +HRESULT VfwCapture_create(IUnknown * pUnkOuter, LPVOID * ppv) +{ + VfwCapture *pVfwCapture; + HRESULT hr; + + if (pUnkOuter) + return CLASS_E_NOAGGREGATION; + + pVfwCapture = CoTaskMemAlloc(sizeof(VfwCapture)); + + if (!pVfwCapture) + return E_OUTOFMEMORY; + + pVfwCapture->lpVtbl = &VfwCapture_Vtbl; + pVfwCapture->IAMStreamConfig_vtbl = &IAMStreamConfig_VTable; + pVfwCapture->refCount = 1; + pVfwCapture->filterInfo.achName[0] = '\0'; + pVfwCapture->filterInfo.pGraph = NULL; + InitializeCriticalSection(&pVfwCapture->csFilter); + hr = VfwPin_Construct((IBaseFilter *)&pVfwCapture->lpVtbl, &pVfwCapture->csFilter, &pVfwCapture->pOutputPin); + if (!SUCCEEDED(hr)) + { + CoTaskMemFree(pVfwCapture); + return E_OUTOFMEMORY; + } + + pVfwCapture->pmt = NULL; + + *ppv = (LPVOID)pVfwCapture; + TRACE("-- created at %p\n", pVfwCapture); + + return S_OK; +} + +static HRESULT WINAPI VfwCapture_QueryInterface(IBaseFilter * iface, REFIID riid, LPVOID * ppv) +{ + VfwCapture *This = (VfwCapture *)iface; + TRACE("(%s, %p)\n", qzdebugstr_guid(riid), ppv); + *ppv = NULL; + + if (IsEqualIID(riid, &IID_IUnknown)) + *ppv = (LPVOID)This; + else if (IsEqualIID(riid, &IID_IPersist)) + *ppv = (LPVOID)This; + else if (IsEqualIID(riid, &IID_IMediaFilter)) + *ppv = (LPVOID)This; + else if (IsEqualIID(riid, &IID_IBaseFilter)) + *ppv = (LPVOID)This; + else if (IsEqualIID(riid, &IID_IAMStreamConfig)) + *ppv = (LPVOID)&(This->IAMStreamConfig_vtbl); + + if (*ppv) + { + IUnknown_AddRef((IUnknown *)(*ppv)); + return S_OK; + } + + FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); + return E_NOINTERFACE; +} + +static ULONG WINAPI VfwCapture_AddRef(IBaseFilter * iface) +{ + VfwCapture *This = (VfwCapture *)iface; + ULONG refCount = InterlockedIncrement(&This->refCount); + + TRACE("(%p/%p)->() AddRef from %ld\n", This, iface, refCount - 1); + + return refCount; +} + +static ULONG WINAPI VfwCapture_Release(IBaseFilter * iface) +{ + VfwCapture *This = (VfwCapture *)iface; + ULONG refCount = InterlockedDecrement(&This->refCount); + TRACE("(%p/%p)->() Release from %ld\n", This, iface, refCount + 1); + + if (!refCount) + { + if (This->pOutputPin) + IPin_Release(This->pOutputPin); + DeleteCriticalSection(&This->csFilter); + This->lpVtbl = NULL; + CoTaskMemFree(This); + } + return refCount; +} + +/** IPersist methods **/ + +static HRESULT WINAPI VfwCapture_GetClassID(IBaseFilter * iface, CLSID * pClsid) +{ + TRACE("(%p)\n", pClsid); + *pClsid = CLSID_VfwCapture; + return S_OK; +} + +/** IMediaFilter methods **/ + +static HRESULT WINAPI VfwCapture_Stop(IBaseFilter * iface) +{ + VfwCapture *This = (VfwCapture *)iface; + TRACE("()\n"); + This->state = State_Stopped; + return S_OK; +} + +static HRESULT WINAPI VfwCapture_Pause(IBaseFilter * iface) +{ + VfwCapture *This = (VfwCapture *)iface; + TRACE("()\n"); + This->state = State_Paused; + return S_OK; +} + +static HRESULT WINAPI VfwCapture_Run(IBaseFilter * iface, REFERENCE_TIME tStart) +{ + VfwCapture *This = (VfwCapture *)iface; + TRACE("(%lx%08lx)\n", (ULONG)(tStart >> 32), (ULONG)tStart); + This->state = State_Running; + return S_OK; +} + +static HRESULT WINAPI VfwCapture_GetState(IBaseFilter * iface, DWORD dwMilliSecsTimeout, FILTER_STATE *pState) +{ + VfwCapture *This = (VfwCapture *)iface; + TRACE("(%lu, %p)\n", dwMilliSecsTimeout, pState); + *pState = This->state; + return S_OK; +} + +static HRESULT WINAPI VfwCapture_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) +{ +/* VfwCapture *This = (VfwCapture *)iface; */ + TRACE("(%p)\n", pClock); + return S_OK; +} + +static HRESULT WINAPI VfwCapture_GetSyncSource(IBaseFilter * iface, IReferenceClock **ppClock) +{ +/* VfwCapture *This = (VfwCapture *)iface; */ + TRACE("(%p)\n", ppClock); + return S_OK; +} + +/** IBaseFilter methods **/ + +static HRESULT WINAPI VfwCapture_EnumPins(IBaseFilter * iface, IEnumPins **ppEnum) +{ + ENUMPINDETAILS epd; + VfwCapture *This = (VfwCapture *)iface; + + TRACE("(%p)\n", ppEnum); + + epd.cPins = This->pOutputPin ? 1 : 0; + epd.ppPins = &This->pOutputPin; + return IEnumPinsImpl_Construct(&epd, ppEnum); +} + +static HRESULT WINAPI VfwCapture_FindPin(IBaseFilter * iface, LPCWSTR Id, IPin **ppPin) +{ + FIXME("(%s, %p) - stub\n", debugstr_w(Id), ppPin); + return E_NOTIMPL; +} + +static HRESULT WINAPI VfwCapture_QueryFilterInfo(IBaseFilter * iface, FILTER_INFO *pInfo) +{ + VfwCapture *This = (VfwCapture *)iface; + + TRACE("(%p)\n", pInfo); + + strcpyW(pInfo->achName, This->filterInfo.achName); + pInfo->pGraph = This->filterInfo.pGraph; + + if (pInfo->pGraph) + IFilterGraph_AddRef(pInfo->pGraph); + return S_OK; +} + +static HRESULT WINAPI VfwCapture_JoinFilterGraph(IBaseFilter * iface, IFilterGraph *pGraph, LPCWSTR pName) +{ + VfwCapture *This = (VfwCapture *)iface; + + TRACE("(%p, %s)\n", pGraph, debugstr_w(pName)); + + if (pName) + strcpyW(This->filterInfo.achName, pName); + else + *This->filterInfo.achName = 0; + This->filterInfo.pGraph = pGraph; /* NOTE: do NOT increase ref. count */ + + return S_OK; +} + +static HRESULT WINAPI VfwCapture_QueryVendorInfo(IBaseFilter * iface, LPWSTR *pVendorInfo) +{ + FIXME("(%p)\n", pVendorInfo); + return E_NOTIMPL; +} + +static const IBaseFilterVtbl VfwCapture_Vtbl = +{ + VfwCapture_QueryInterface, + VfwCapture_AddRef, + VfwCapture_Release, + VfwCapture_GetClassID, + VfwCapture_Stop, + VfwCapture_Pause, + VfwCapture_Run, + VfwCapture_GetState, + VfwCapture_SetSyncSource, + VfwCapture_GetSyncSource, + VfwCapture_EnumPins, + VfwCapture_FindPin, + VfwCapture_QueryFilterInfo, + VfwCapture_JoinFilterGraph, + VfwCapture_QueryVendorInfo +}; + +/* AMStreamConfig interface, we only need to implement {G,S}etFormat */ +static HRESULT WINAPI AMStreamConfig_QueryInterface(IAMStreamConfig * iface, REFIID riid, LPVOID * ppv) +{ + FIXME("%p: stub, not worth the effort\n", iface); + return S_OK; +} + +static ULONG WINAPI AMStreamConfig_AddRef(IAMStreamConfig * iface) +{ + FIXME("%p: stub, not worth the effort\n", iface); + return 1; +} + +static ULONG WINAPI AMStreamConfig_Release(IAMStreamConfig * iface) +{ + FIXME("%p: stub, not worth the effort\n", iface); + return 1; +} + +static HRESULT WINAPI AMStreamConfig_SetFormat(IAMStreamConfig *iface, + AM_MEDIA_TYPE *pmt) { + ERR("%p: %p stub !!\n", iface, pmt); + return E_NOTIMPL; +} + +static HRESULT WINAPI AMStreamConfig_GetFormat(IAMStreamConfig *iface, + AM_MEDIA_TYPE **pmt) { + ERR("%p: %p stub !!\n", iface, pmt); + // FIXME: The stuff below is just there so it contains something + + VIDEOINFOHEADER *pvi; + + pmt[0] = CoTaskMemAlloc(sizeof (AM_MEDIA_TYPE)); + memcpy (&pmt[0]->formattype, &FORMAT_VideoInfo, sizeof (GUID)); + memcpy (&pmt[0]->majortype, &MEDIATYPE_Video, sizeof (GUID)); + memcpy (&pmt[0]->subtype, &MEDIASUBTYPE_RGB24, sizeof (GUID)); + pmt[0]->bTemporalCompression = 0; + pmt[0]->bFixedSizeSamples = 1; + pmt[0]->lSampleSize = 1; + + pmt[0]->cbFormat = sizeof(VIDEOINFOHEADER); + pmt[0]->pbFormat = CoTaskMemAlloc(pmt[0]->cbFormat); + ZeroMemory(pmt[0]->pbFormat, pmt[0]->cbFormat); + pvi = (VIDEOINFOHEADER *)pmt[0]->pbFormat; + pvi->rcSource.right = 640; pvi->rcSource.bottom = 480; + pvi->rcTarget.right = 640; pvi->rcTarget.bottom = 480; + pvi->dwBitRate = 10; + pvi->dwBitErrorRate = 0; + pvi->AvgTimePerFrame = (LONGLONG)(10000000.0 / 25); // 25 is hardcoded + + // FIXME: The stuff below is just there so it contains something + + pvi->bmiHeader.biWidth = 640; + pvi->bmiHeader.biHeight = 480; + pvi->bmiHeader.biBitCount = 24; + pvi->bmiHeader.biCompression = BI_RGB; + pvi->bmiHeader.biSizeImage = 0; + pvi->bmiHeader.biXPelsPerMeter = 640; + pvi->bmiHeader.biYPelsPerMeter = 480; + pvi->bmiHeader.biClrUsed = 0; + pvi->bmiHeader.biClrImportant = 0; + + return S_OK; +} + +typedef struct _VIDEO_STREAM_CONFIG_CAPS { + GUID guid; + ULONG VideoStandard; + SIZE InputSize; + SIZE MinCroppingSize; + SIZE MaxCroppingSize; + int CropGranularityX; + int CropGranularityY; + int CropAlignX; + int CropAlignY; + SIZE MinOutputSize; + SIZE MaxOutputSize; + int OutputGranularityX; + int OutputGranularityY; + int StretchTapsX; + int StretchTapsY; + int ShrinkTapsX; + int ShrinkTapsY; + LONGLONG MinFrameInterval; + LONGLONG MaxFrameInterval; + LONG MinBitsPerSecond; + LONG MaxBitsPerSecond; +} VIDEO_STREAM_CONFIG_CAPS; + +static HRESULT WINAPI AMStreamConfig_GetNumberOfCapabilities(IAMStreamConfig *iface, int *piCount, int *piSize) +{ + TRACE("%p: %p %p - stub! Should be harmless\n", iface, piCount, piSize); + *piCount = 1; + *piSize = sizeof(VIDEO_STREAM_CONFIG_CAPS); + return S_OK; /* Not implemented for this interface, but who cares =) */ +} + +static HRESULT WINAPI AMStreamConfig_GetStreamCaps(IAMStreamConfig *iface, +int iIndex, AM_MEDIA_TYPE **pmt, BYTE *pSCC) +{ + TRACE("%p: %d %p %p\n", iface, iIndex, pmt, pSCC); + + VIDEOINFOHEADER *pvi; + VIDEO_STREAM_CONFIG_CAPS *vsc; + + pmt[0] = CoTaskMemAlloc(sizeof (AM_MEDIA_TYPE)); + memcpy (&pmt[0]->formattype, &FORMAT_VideoInfo, sizeof (GUID)); + memcpy (&pmt[0]->majortype, &MEDIATYPE_Video, sizeof (GUID)); + memcpy (&pmt[0]->subtype, &MEDIASUBTYPE_RGB24, sizeof (GUID)); + pmt[0]->bTemporalCompression = 0; + pmt[0]->bFixedSizeSamples = 1; + pmt[0]->lSampleSize = 1; + + // FIXME: The stuff below is just there so it contains something + + pmt[0]->cbFormat = sizeof(VIDEOINFOHEADER); + pmt[0]->pbFormat = CoTaskMemAlloc(pmt[0]->cbFormat); + ZeroMemory(pmt[0]->pbFormat, pmt[0]->cbFormat); + pvi = (VIDEOINFOHEADER *)pmt[0]->pbFormat; + pvi->rcSource.right = 640; pvi->rcSource.bottom = 480; + pvi->rcTarget.right = 640; pvi->rcTarget.bottom = 480; + pvi->dwBitRate = 10; + pvi->dwBitErrorRate = 0; + pvi->AvgTimePerFrame = (LONGLONG)(10000000.0 / 25); // 25 is hardcoded + + // FIXME: The stuff below is just there so it contains something + + pvi->bmiHeader.biWidth = 640; + pvi->bmiHeader.biHeight = 480; + pvi->bmiHeader.biBitCount = 24; + pvi->bmiHeader.biCompression = BI_RGB; + pvi->bmiHeader.biSizeImage = 0; + pvi->bmiHeader.biXPelsPerMeter = 640; + pvi->bmiHeader.biYPelsPerMeter = 480; + pvi->bmiHeader.biClrUsed = 0; + pvi->bmiHeader.biClrImportant = 0; + + // FIXME: Blahblahblah + + vsc = (VIDEO_STREAM_CONFIG_CAPS *)pSCC; + memcpy (&vsc->guid, &FORMAT_VideoInfo, sizeof (GUID)); + vsc->VideoStandard = 0; + vsc->InputSize.cx = 640; vsc->InputSize.cy = 480; + vsc->MinCroppingSize.cx = 320; vsc->MinCroppingSize.cy = 240; + vsc->MaxCroppingSize.cx = 640; vsc->MaxCroppingSize.cy = 480; + vsc->CropGranularityX = 10; + vsc->CropGranularityY = 10; + vsc->CropAlignX = 0; + vsc->CropAlignY = 0; + vsc->MinOutputSize.cx = 320; vsc->MinOutputSize.cy = 240; + vsc->MaxOutputSize.cx = 640; vsc->MaxOutputSize.cy = 480; + vsc->OutputGranularityX = 10; + vsc->OutputGranularityY = 10; + vsc->StretchTapsX = 1; + vsc->StretchTapsY = 1; + vsc->ShrinkTapsX = 1; + vsc->ShrinkTapsY = 1; + vsc->MinFrameInterval = (LONGLONG)(10000000.0 / 25); + vsc->MaxFrameInterval = (LONGLONG)(10000000.0 / 25); + vsc->MinBitsPerSecond = 24; + vsc->MaxBitsPerSecond = 24; + + return S_OK; /* Not implemented for this interface */ +} + +static const IAMStreamConfigVtbl IAMStreamConfig_VTable = +{ + AMStreamConfig_QueryInterface, + AMStreamConfig_AddRef, + AMStreamConfig_Release, + AMStreamConfig_SetFormat, + AMStreamConfig_GetFormat, + AMStreamConfig_GetNumberOfCapabilities, + AMStreamConfig_GetStreamCaps +}; + +/* IKsPropertySet interface */ +static HRESULT WINAPI KSP_QueryInterface(IKsPropertySet * iface, REFIID riid, LPVOID * ppv) +{ + TRACE("%p: stub, not worth the effort\n", iface); + return S_OK; +} + +static ULONG WINAPI KSP_AddRef(IKsPropertySet * iface) +{ + TRACE("%p: stub, not worth the effort\n", iface); + return 1; +} + +static ULONG WINAPI KSP_Release(IKsPropertySet * iface) +{ + TRACE("%p: stub, not worth the effort\n", iface); + return 1; +} + +static HRESULT WINAPI KSP_Set(IKsPropertySet * iface, REFGUID guidPropSet, DWORD dwPropID, LPVOID pInstanceData, DWORD cbInstanceData, LPVOID pPropData, DWORD cbPropData) +{ + return E_NOTIMPL; +} + +static HRESULT WINAPI KSP_Get(IKsPropertySet * iface, REFGUID guidPropSet, DWORD dwPropID, LPVOID pInstanceData, DWORD cbInstanceData, LPVOID pPropData, DWORD cbPropData, DWORD *pcbReturned) +{ + TRACE("()\n"); + if (!IsEqualIID(guidPropSet, &AMPROPSETID_Pin)) + return E_PROP_SET_UNSUPPORTED; +/* if (dwPropID != AMPROPERTY_PIN_CATEGORY) + return E_PROP_ID_UNSUPPORTED; + */if (pPropData == NULL && pcbReturned == NULL) + return E_POINTER; + if (pcbReturned) + *pcbReturned = sizeof(GUID); + if (pPropData == NULL) + return S_OK; + if (cbPropData < sizeof(GUID)) + return E_UNEXPECTED; + *(GUID *)pPropData = PIN_CATEGORY_PREVIEW; + TRACE("() Returning CaP\n"); + return S_OK; +} + +static HRESULT WINAPI KSP_QuerySupported(IKsPropertySet * iface, REFGUID guidPropSet, DWORD dwPropID, DWORD *pTypeSupport) +{ + TRACE("%p: stub\n", iface); + return E_NOTIMPL; +} + +static IKsPropertySetVtbl KSP_VTable = +{ + KSP_QueryInterface, + KSP_AddRef, + KSP_Release, + KSP_Set, + KSP_Get, + KSP_QuerySupported +}; + +/* VfwPin implementation */ +typedef struct VfwPinImpl +{ + OutputPin pin; + + IKsPropertySetVtbl * KSP_VT; + HANDLE hEvent; + BOOL bFlushing; + DATAREQUEST * pHead; /* head of data request list */ + CRITICAL_SECTION csList; /* critical section to protect operations on list */ +} VfwPinImpl; + +static HRESULT AcceptProcAFR(LPVOID iface, const AM_MEDIA_TYPE *pmt) +{ + VfwPinImpl *This = (VfwPinImpl *)iface; + FIXME("%p: %p\n", This, pmt); + return S_FALSE; +} + +static HRESULT VfwPin_ConnectSpecific(IPin * iface, IPin * pReceivePin, const AM_MEDIA_TYPE * pmt) +{ + OutputPin *This = (OutputPin *)iface; + HRESULT hr; + WCHAR *fuckay; + + TRACE("(%p, %p)\n", pReceivePin, pmt); + /* FIXME: call queryacceptproc */ + This->pin.pConnectedTo = pReceivePin; + IPin_AddRef(pReceivePin); + CopyMediaType(&This->pin.mtCurrent, pmt); + IPin_QueryId(pReceivePin, (LPWSTR *)&fuckay); + dump_AM_MEDIA_TYPE(pmt); + + FIXME("Before crash: %p %p %p - %s\n", pReceivePin, iface, pmt, debugstr_w(fuckay)); + ERR("This *WILL* crash if WINEDEBUG contains quartz.. SOMEONE PLEASE HELP ME OUT!"); + hr = IPin_ReceiveConnection(pReceivePin, iface, pmt); + + if (FAILED(hr)) + { + ERR("Failed!"); + IPin_Release(This->pin.pConnectedTo); + This->pin.pConnectedTo = NULL; + } + + FIXME(" -- %lx\n", hr); + return hr; +} + +static HRESULT VfwPin_Construct(IBaseFilter * pBaseFilter, LPCRITICAL_SECTION pCritSec, IPin ** ppPin) +{ + VfwPinImpl * pPinImpl; + PIN_INFO piOutput; + + pPinImpl = CoTaskMemAlloc(sizeof(*pPinImpl)); + if (!pPinImpl) + return E_OUTOFMEMORY; + + piOutput.dir = PINDIR_OUTPUT; + piOutput.pFilter = pBaseFilter; + strcpyW(piOutput.achName, wszOutputPinName); + + if (SUCCEEDED(OutputPin_Init(&piOutput, NULL, pBaseFilter, AcceptProcAFR, pCritSec, &pPinImpl->pin))) + { + ERR("Success\n"); + pPinImpl->KSP_VT = &KSP_VTable; + pPinImpl->pin.pin.lpVtbl = &VfwPin_Vtbl; + pPinImpl->hEvent = CreateEventW(NULL, 0, 0, NULL); + pPinImpl->bFlushing = FALSE; + pPinImpl->pHead = NULL; + pPinImpl->pin.pConnectSpecific = VfwPin_ConnectSpecific; + InitializeCriticalSection(&pPinImpl->csList); + *ppPin = (IPin *)(&pPinImpl->pin.pin.lpVtbl); + return S_OK; + } + return E_FAIL; +} + +static HRESULT WINAPI VfwPin_QueryInterface(IPin * iface, REFIID riid, LPVOID * ppv) +{ + VfwPinImpl *This = (VfwPinImpl *)iface; + TRACE("%s %p\n", qzdebugstr_guid(riid), ppv); + *ppv = NULL; + if (IsEqualIID(riid, &IID_IUnknown)) + *ppv = (LPVOID)This; + else if (IsEqualIID(riid, &IID_IPin)) + *ppv = (LPVOID)This; + else if (IsEqualIID(riid, &IID_IKsPropertySet)) + *ppv = (LPVOID)&(This->KSP_VT); + + if (*ppv) + { + IUnknown_AddRef((IUnknown *)(*ppv)); + return S_OK; + } + + FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); + return E_NOINTERFACE; +} + +static ULONG WINAPI VfwPin_Release(IPin * iface) +{ + VfwPinImpl *This = (VfwPinImpl *)iface; + ULONG refCount = InterlockedDecrement(&This->pin.pin.refCount); + TRACE("()\n"); + + if (!refCount) + { + DATAREQUEST * pCurrent; + DATAREQUEST * pNext; + for (pCurrent = This->pHead; pCurrent; pCurrent = pNext) + { + pNext = pCurrent->pNext; + CoTaskMemFree(pCurrent); + } + CloseHandle(This->hEvent); + CoTaskMemFree(This); + return 0; + } + return refCount; +} + +static HRESULT WINAPI VfwPin_EnumMediaTypes(IPin * iface, IEnumMediaTypes ** ppEnum) +{ + ENUMMEDIADETAILS emd; + AM_MEDIA_TYPE q[1]; + int x = 0; + + VfwPinImpl *This = (VfwPinImpl *)iface; + FIXME("(%p) - stub!\n", ppEnum); + emd.cMediaTypes = 1; + for (; x < 1; x++) { + VIDEOINFOHEADER *pvi; + CopyMemory(&q[x].majortype, &MEDIATYPE_Video, sizeof (GUID)); + CopyMemory(&q[x].subtype, &MEDIASUBTYPE_RGB24, sizeof (GUID)); + q[x].bFixedSizeSamples = TRUE; + q[x].bTemporalCompression = FALSE; + q[x].lSampleSize = 0; + CopyMemory(&q[x].formattype, &FORMAT_VideoInfo, sizeof (GUID)); + q[x].cbFormat = sizeof(VIDEOINFOHEADER); + q[x].pbFormat = CoTaskMemAlloc(q[x].cbFormat); + pvi = (VIDEOINFOHEADER *)q[x].pbFormat; + pvi->rcSource.right = 640; pvi->rcSource.bottom = 480; + pvi->rcTarget.right = 640; pvi->rcTarget.bottom = 480; + pvi->dwBitRate = 10; + pvi->dwBitErrorRate = 0; + pvi->AvgTimePerFrame = (LONGLONG)(10000000.0 / 25); + pvi->bmiHeader.biWidth = 640; + pvi->bmiHeader.biPlanes = 1; + pvi->bmiHeader.biHeight = 480; + pvi->bmiHeader.biBitCount = 24; + pvi->bmiHeader.biCompression = BI_RGB; + pvi->bmiHeader.biSizeImage = 1000000; + pvi->bmiHeader.biXPelsPerMeter = 640; + pvi->bmiHeader.biYPelsPerMeter = 480; + pvi->bmiHeader.biClrUsed = 65536; + pvi->bmiHeader.biClrImportant = 0; + } + emd.pMediaTypes = q; + return IEnumMediaTypesImpl_Construct(&emd, ppEnum); +} + +static const IPinVtbl VfwPin_Vtbl = +{ + VfwPin_QueryInterface, + IPinImpl_AddRef, + VfwPin_Release, + OutputPin_Connect, + OutputPin_ReceiveConnection, + IPinImpl_Disconnect, + IPinImpl_ConnectedTo, + IPinImpl_ConnectionMediaType, + IPinImpl_QueryPinInfo, + IPinImpl_QueryDirection, + IPinImpl_QueryId, + IPinImpl_QueryAccept, + VfwPin_EnumMediaTypes, + IPinImpl_QueryInternalConnections, + OutputPin_EndOfStream, + OutputPin_BeginFlush, + OutputPin_EndFlush, + OutputPin_NewSegment +}; + diff -Nru wine-old/include/axextend.idl wine-new/include/axextend.idl --- wine-old/include/axextend.idl 2003-07-01 06:33:35.000000000 +0200 +++ wine-new/include/axextend.idl 2005-04-09 16:12:13.000000000 +0200 @@ -69,6 +69,23 @@ interface IQualityControl; interface ISeekingPassThru; +/***************************************************************************** + * IAMStreamConfig interface + */ +[ + object, + uuid(c6e13340-30ac-11d0-a18c-00a0c9118956), + pointer_default(unique) +] +interface IAMStreamConfig : IUnknown +{ + HRESULT SetFormat( [in] AM_MEDIA_TYPE *pmt); + HRESULT GetFormat( [in] AM_MEDIA_TYPE **pmt); + HRESULT GetNumberOfCapabilities( [out] int *piCount, [out] int *piSize); + HRESULT GetStreamCaps( [in] int iIndex, [out] AM_MEDIA_TYPE **pmt, + [out] BYTE *pSCC); +} + typedef struct { CLSID Clsid;

3 2

Planetside running at about 80%
by Benjamin Cutler 10 Apr '05

10 Apr '05

After hacking away at powrprof.dll to the point where stubs exist (see my previous post), I was able to get Planetside to launch and run to the point where I could actually get into the game. However, the textures were hit and miss. Some worked, but some were blanked out white. Also, onne you got in game the UI was washed out with white and almost unusuable. This even affected the Server/Character selection screens (but only AFTER you'd been logged into the world). Given that there were quite a few fixme messages related to d3d in the logs, I imagine this means the support isn't quite up there just yet (though it's very impressive). The patcher, however, crashes shortly after startup (but runs fine on Cedega 4.3), so you have to patch on Cedega at the very least. The sound was pretty much perfect, however if the game loses focus while in full screen mode, it won't gain mouse control when it regains focus, unless Wine is run in desktop mode. This was all using the CVS as of April 9, 2005, plus my powrprof patches (sent to wine-patches earlier today), plus changing two lines in dlls/ddraw/ddraw/user.c (User_DirectDraw_Construct) to return 96 megs of video memory (this source file is hard-coded to return 16 megs, but Planetside won't run unless it sees at least 32). Also, the game triggers an exception when it quits. http://www.cs.colostate.edu/~cutler/planetside1.jpg - Running around in NC Sanctuary http://www.cs.colostate.edu/~cutler/planetside2.jpg - Demonstrating "wash out" problem on map screen Attachment 1: "~/Planetside/Sony/Planetside$ wine 2>planetside.training.trace planetside.exe -off" Offline training mode, SIGINT after loading since it won't let you quit in the middle of training. Attachment 2: "~/Planetside/Sony/Planetside$ wine 2>planetside.online.trace planetside.exe /K:<encrypted>" Online mode, encrypted being the login info passed from the patcher/launcher, encoded in some way I can't decipher. Attachment 3: "~/Planetside/Sony/Station$ wine 2>launcher.trace Launcher.exe /game:planetside" Patcher/Launcher. If the Mozilla ActiveX control is not installed, it crashes out shortly after startup. With it installed, a Message Box with the warning "c is not a registered protocol" pops up, and wine locks up and requires a kill -9 to close. I suspect the error is from the ActiveX control not handling local files without "file:///" in front, but that's a different problem. Other than the problems mentioned, performance was quite nice, exactly what I'd expect out of this machine if it were running Windows. Kudos to the Wine devs for getting it this far! err:font:ReadFontDir Can't open directory "/usr/X11R6/lib/X11/fonts/TT" err:font:ReadFontDir Can't open directory "/usr/share/fonts/TT" fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:powrprof:CallNtPowerInformation (18, (nil), 0, 0x77adf894, 76) stub! fixme:powrprof:CallNtPowerInformation (19, (nil), 0, 0x77adf848, 76) stub! fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_VERSION ("1.5.3 NVIDIA 71.74")->(0x00471c06) fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_RENDERER ("GeForce FX 5900XT/AGP/SSE/3DNOW!")->(0x0250) fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(40,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(128,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(129,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(130,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(131,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(132,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(133,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(134,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(135,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(156,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(161,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(162,-1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(163,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(164,1065353216) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(165,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(172,3) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7d98)->(173,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:process:SetProcessWorkingSetSize (0xffffffff,536870912,805306368): stub - harmless fixme:process:SetProcessWorkingSetSize (0xffffffff,469762048,805306368): stub - harmless fixme:keyboard:X11DRV_ActivateKeyboardLayout 0x4090409, 0100: stub! fixme:imm:ImmGetIMEFileNameA (0x4090409, 0x77adef68, 1023): stub fixme:imm:ImmGetIMEFileNameA (0x4090409, 0x77adf36c, 260): stub fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:d3d:IDirect3DDevice8Impl_Reset (0x77cd7d98) : stub fixme:d3d:IDirect3DDevice8Impl_Reset (0x77cd7d98) : stub fixme:d3d:GetSrcAndOpFromValue Unhandled texture arg D3DTA_SPECULAR fixme:d3d:GetSrcAndOpFromValue Unhandled texture arg D3DTA_SPECULAR fixme:d3d:GetSrcAndOpFromValue Unhandled texture arg D3DTA_SPECULAR fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7d98) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7d98) : stub, calling idirect3d for now err:font:ReadFontDir Can't open directory "/usr/X11R6/lib/X11/fonts/TT" err:font:ReadFontDir Can't open directory "/usr/share/fonts/TT" fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:powrprof:CallNtPowerInformation (18, (nil), 0, 0x77adf894, 76) stub! fixme:powrprof:CallNtPowerInformation (19, (nil), 0, 0x77adf848, 76) stub! fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_VERSION ("1.5.3 NVIDIA 71.74")->(0x00471c06) fixme:d3d_caps:IDirect3D8Impl_FillGLCaps found GL_RENDERER ("GeForce FX 5900XT/AGP/SSE/3DNOW!")->(0x0250) fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(40,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(128,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(129,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(130,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(131,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(132,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(133,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(134,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(135,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(156,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(161,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(162,-1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(163,0) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(164,1065353216) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(165,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(172,3) not handled yet fixme:d3d:IDirect3DDevice8Impl_SetRenderState (0x77cd7e08)->(173,1) not handled yet fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:process:SetProcessWorkingSetSize (0xffffffff,536870912,805306368): stub - harmless fixme:process:SetProcessWorkingSetSize (0xffffffff,469762048,805306368): stub - harmless fixme:keyboard:X11DRV_ActivateKeyboardLayout 0x4090409, 0100: stub! fixme:imm:ImmGetIMEFileNameA (0x4090409, 0x77adef68, 1023): stub fixme:imm:ImmGetIMEFileNameA (0x4090409, 0x77adf36c, 260): stub fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:d3d:IDirect3DDevice8Impl_Reset (0x77cd7e08) : stub fixme:winsock:convert_sockopt Unknown IPPROTO_IP optname 0x7 fixme:winsock:convert_sockopt Unknown IPPROTO_IP optname 0x7 fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_Reset (0x77cd7e08) : stub fixme:d3d:GetSrcAndOpFromValue Unhandled texture arg D3DTA_SPECULAR fixme:d3d:GetSrcAndOpFromValue Unhandled texture arg D3DTA_SPECULAR fixme:d3d:GetSrcAndOpFromValue Unhandled texture arg D3DTA_SPECULAR fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_SetTextureStageState Unhandled D3DTSS_MAGFILTER value of 5 fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetDeviceCaps (0x77cd7e08) : stub, calling idirect3d for now fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:set_tex_op Unhandled texture operation 17 fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetFrontBuffer (0x77cd7e08) : Should return whole screen, only returns GL context window in top left corner fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetFrontBuffer (0x77cd7e08) : Should return whole screen, only returns GL context window in top left corner fixme:d3d:IDirect3DDevice8Impl_GetDisplayMode (0x77cd7e08) : returning w(1024) h(768) rr(85) fmt(21,D3DFMT_A8R8G8B8) fixme:d3d:IDirect3DDevice8Impl_GetFrontBuffer (0x77cd7e08) : Should return whole screen, only returns GL context window in top left corner fixme:d3d:IDirect3DDevice8Impl_Reset (0x77cd7e08) : stub fixme:winsock:convert_sockopt Unknown IPPROTO_IP optname 0x7 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7c145ca8 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7c145ca8 err:dsound:DSOUND_MixOne underrun on sound buffer 0x7c145ca8 fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum fixme:mmtime:timeEndPeriod Stub; we set our timer resolution at minimum MeInfo{0}: Autodetecting CPU for SSE MeInfo{0}: Using SSE Optimizations wine: Unhandled exception (thread 0013), starting debugger... err:font:ReadFontDir Can't open directory "/usr/X11R6/lib/X11/fonts/TT" err:font:ReadFontDir Can't open directory "/usr/share/fonts/TT" err:font:ReadFontDir Can't open directory "/usr/X11R6/lib/X11/fonts/TT" err:font:ReadFontDir Can't open directory "/usr/share/fonts/TT" fixme:advapi:LookupAccountSidA ((null),sid=0x77c58b68,0x7eec0178,0x77acf5bc(256),0x7eec0278,0x77acf5c0(256),0x77acf568): semi-stub fixme:wininet:INET_QueryOptionHelper Stub! 38 fixme:wininet:INET_QueryOptionHelper Stub! 38 fixme:wininet:INET_QueryOptionHelper Stub! 38 fixme:ole:CoCreateInstance no classfactory created for CLSID {4991d34b-80a1-4291-83b6-3328366b9097}, hres is 0x80040150 fixme:ole:CoCreateInstance no classfactory created for CLSID {4991d34b-80a1-4291-83b6-3328366b9097}, hres is 0x80040150 fixme:wininet:INET_QueryOptionHelper Stub! 38 fixme:process:SetProcessWorkingSetSize (0xffffffff,-1,-1): stub - harmless fixme:process:SetProcessWorkingSetSize (0xffffffff,-1,-1): stub - harmless fixme:storage:StgCreateDocfile Transacted mode not implemented. fixme:ole:OleCreate {8856f961-340a-11d0-a96b-00c04fd705a2} {00000112-0000-0000-c000-000000000046} semi-stub! fixme:ole:CoCreateInstance no classfactory created for CLSID {4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154 fixme:process:SetProcessWorkingSetSize (0xffffffff,-1,-1): stub - harmless fixme:imm:ImmGetContext (0x10030): stub fixme:imm:ImmNotifyIME (0x77c6a578, 21, 1, 0): stub fixme:imm:ImmReleaseContext (0x10030, 0x77c6a578): stub fixme:imm:ImmGetContext (0x10038): stub fixme:imm:ImmNotifyIME (0x77c6a578, 21, 1, 0): stub fixme:imm:ImmReleaseContext (0x10038, 0x77c6a578): stub fixme:imm:ImmGetContext (0x1003a): stub fixme:imm:ImmNotifyIME (0x77c6a578, 21, 1, 0): stub fixme:imm:ImmReleaseContext (0x1003a, 0x77c6a578): stub fixme:process:SetProcessWorkingSetSize (0xffffffff,-1,-1): stub - harmless fixme:process:SetProcessWorkingSetSize (0xffffffff,-1,-1): stub - harmless

1 0

dib.c problem, and Solution to winmm deadlocking problem
by Robert Lunnon 10 Apr '05

10 Apr '05

After weeks of searching I have finally found my deadlock problem. Its actually not related to audio at all it's a ddraw problem with poor error handling, the surface wasn't released properly when the error "Application gave us bad source rectangle for Blt." occurs Also the DIB_DirectDrawSurface_Blt fuction doesn't return error status captured during execution properly, preferring to return DD_OK all the time. I propose the following patch ================================cut here=========================== Index: dib.c =================================================================== RCS file: /home/wine/wine/dlls/ddraw/dsurface/dib.c,v retrieving revision 1.48 diff -u -3 -p -r1.48 dib.c --- dib.c 24 Mar 2005 21:01:39 -0000 1.48 +++ dib.c 9 Apr 2005 23:17:43 -0000 @@ -581,7 +581,8 @@ DIB_DirectDrawSurface_Blt(LPDIRECTDRAWSU (xsrc.right > sdesc.dwWidth) || (xsrc.right < 0) || (xsrc.right < xsrc.left) || (xsrc.bottom < xsrc.top))) { WARN("Application gave us bad source rectangle for Blt.\n"); - return DDERR_INVALIDRECT; + ret = DDERR_INVALIDRECT; + goto release; } /* For the Destination rect, it can be out of bounds on the condition that a clipper is set for the given surface. @@ -593,7 +594,8 @@ DIB_DirectDrawSurface_Blt(LPDIRECTDRAWSU (xdst.right > ddesc.dwWidth) || (xdst.right < 0) || (xdst.right < xdst.left) || (xdst.bottom < xdst.top))) { WARN("Application gave us bad destination rectangle for Blt without a clipper set.\n"); - return DDERR_INVALIDRECT; + ret = DDERR_INVALIDRECT; + goto release; } /* Now handle negative values in the rectangles. Warning: only supported for now @@ -959,7 +961,7 @@ error: release: IDirectDrawSurface7_Unlock(iface,NULL); if (src) IDirectDrawSurface7_Unlock(src,NULL); - return DD_OK; + return ret; } /* BltBatch: generic, unimplemented */

2 1

Native windows dll, proxy methods, Unsupported Dwarf2 information for...
by Stephen Crowley 10 Apr '05

10 Apr '05

Hi, I have a win32 dll which exports about 30 functions. I've used winedump with the -f and -I flags to create stub/proxy functions which use LoadLibrary. Please CC my on all responses as I am not subscribed to the list. It generates functions like so.. HGTBSESSION __stdcall GTBAPI_gtbCreateSession(HWND hParent, GTBSessionCallback * lpCallBack, void * lpParam) { HGTBSESSION (__stdcall *pFunc)(HWND, const GTBSessionCallback *, void *); HGTBSESSION retVal; pFunc=(void*)GetProcAddress(hDLL,"gtbCreateSession"); TRACE("((HWND)%p,(GTBSessionCallback *)%p,(void *)%p): forward\n",hParent,lpCallBack,lpParam); retVal = pFunc(hParent,lpCallBack,lpParam); TRACE("Returned (%p)\n",retVal); return retVal; } For compatibility with existing code I removed the GTBAPI_ from the function and switched back to the native prototype. GTAPIB_EXTERN HGTBSESSION WINAPI gtbCreateSession(HWND hParent, const GTBSessionCallback *lpCallBack, void *lpParam) Compiled and linked like so. gcc -shared GTAPIB_main.c -I/usr/include/wine/windows -I../GenSrc/API/GTAPIB -o ../lib/libgtapib.so /usr/lib/wine/kernel32.dll.so Then I have a small test app that I compile/link: winegcc TestAPIB.c -I/usr/include/wine/windows -I ../../../GenSrc/API/GTAPIB -L../../../lib -lgtapib -lkernel32 -o TestAPIB Running ./TestAPIB throws the following error WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00000000). In 32 bit mode. ..... Backtrace: =>1 0x00000000 (0x406efe60) fixme:dbghelp:elf_load_debug_info_from_map Unsupported Dwarf2 information for testapib<elf> 2 0x405e5276 WinMain in testapib (0x406efe90) 3 0x405e5173 __wine_exe_main in testapib (0x406eff20) 4 0x404e0de2 in kernel32 (+0x50de2) (0x406efff4) 5 0x4001d181 wine_switch_to_stack in libwine.so.1 (0x00000000) 0x00000000: addb %al,0x0(%eax) My wine version is 20050310 Any tips would be greatly appreciated. Thanks, Stephen

2 1

Re: fyi your wine forum post
by peter＠piments.com 10 Apr '05

10 Apr '05

I would gladly share the fix if I had one. Since wine is inherently unstable with very little support I cant even be bothered to waste my time looking for now. It broke and I get told off for even asking why. I will go and work on some more worth while part of my system. As and when I come back to this and work out why simply rebuilding wine blows out my basic working config I will be sure to let you know. However I had better make sure I do not post here or I shall get shot down in flames for misusing the mailing list. Hope you dont get in trouble for repling. ;) On Sat, 09 Apr 2005 11:40:31 +0200, Joseph Black <josephhenryblack(a)yahoo.co.nz> wrote: > While reading in the forum: > Subject: Re: user broken ? > Date: Thu, 7 Apr 2005 15:02:49 +0200 > Warning: the specified Windows directory L"c:\\windows" is not > accessible. >> Warning: the specified System directory L"c:\\windows\\system" is not .. > > Hi, > glad you asked the question - I wondered how you test using cvs. I read > on the > wiki about regression testing but hesitated to try myself. > > Could you share what was the fix? did you need to re-install wine? > I would like to add it to the wiki under troubleshooting... > Link: > http://wiki.jswindle.com/index.php/Wine_Developer_Regression_Testing > > Kind regards > > Joseph Black > user of wine for years, but never of cvs. > ps. unless you wish otherwise, I can attribute your name as the source > of the fix.. -- Using Opera e-mail on Gentoo Linux

3 2

Deadlocking problems in winmm
by Robert Lunnon 09 Apr '05

09 Apr '05

Since early this year I have been having difficulties with winmm in that my test application seems to deadlock if an audio driver is set up in the config. Without a defined audio driver or if the audio device is busy, the app works fine. For what it's worth here is a dump of +winmm +mmtime. After deadlocking, top says wine is using 98% of cpu time about 70% of which is in syscalls. The remaining 28% is split about 50/50 between wine and wine-server. Is there a good way to spy on the wineserver comms to find out why the deadlock? Note that the debugger isn't even close to working on Solaris so solutions involving the debugger are not possible. All hints gratefully received... Bob fixme:file:get_default_drive_device auto detection of DOS devices not supported on this platform fixme:ntdll:NtQueryVolumeInformationFile device info not properly supported on this platform err:heap:HEAP_CreateSystemHeap system heap base address 80000000 not available Fontconfig warning: line 381: invalid edit binding "same" Fontconfig warning: line 393: invalid edit binding "same" Minimum Stack Set to 1048576 overhead allowance = 0 Allocated thread at 1000 Allocated stack of 2097152 Bytes trace:winmm:DllMain 7f5c0000 0x1 1 trace:winmm:WINMM_CreateIData Created IData (7ff1cdb8) trace:winmm:MMDRV_Init () trace:winmm:MMDRV_Install ('wineaudioio.drv', 'wineaudioio.drv', mapper=N); trace:winmm:MMDRV_Install Got 32 bit func 'wodMessage' trace:winmm:MMDRV_GetDescription32 (7fd8fab8, 7fd8f7e8, 128) trace:winmm:MMDRV_GetDescription32 Can't find file wineaudioio.drv trace:winmm:MMDRV_Install wineaudioio.drv => No description trace:winmm:MMDRV_InitPerType (7f6402e0, 0000, 0003) trace:winmm:MMDRV_InitPerType (7f6402e0, 0001, 0001) trace:winmm:MMDRV_InitPerType (7f6402e0, 0002, 0035) trace:winmm:MMDRV_InitPerType (7f6402e0, 0003, 0001) trace:winmm:MMDRV_InitPerType (7f6402e0, 0004, 0032) trace:winmm:MMDRV_InitPerType (7f6402e0, 0005, 0003) trace:winmm:MMDRV_InitPerType DRVM_INIT => MMSYSERR_NOERROR trace:winmm:MMDRV_InitPerType Got 1 dev for (wineaudioio.drv:WaveOut) trace:winmm:MMDRV_InitPerType Setting min=0 max=1 (ttop=1) for (wineaudioio.drv:WaveOut) trace:winmm:MMDRV_InitPerType WaveOut:Trans[0] -> wineaudioio.drv trace:winmm:MMDRV_Install ('wavemapper', 'msacm.drv', mapper=Y); trace:winmm:MMDRV_Install Got 32 bit func 'widMessage' trace:winmm:MMDRV_Install Got 32 bit func 'wodMessage' trace:winmm:MMDRV_GetDescription32 (7fd8f9b8, 7fd8f7e8, 128) trace:winmm:MMDRV_GetDescription32 Can't find file msacm.drv trace:winmm:MMDRV_Install msacm.drv => No description trace:winmm:MMDRV_InitPerType (7f640334, 0000, 0003) trace:winmm:MMDRV_InitPerType (7f640334, 0001, 0001) trace:winmm:MMDRV_InitPerType (7f640334, 0002, 0035) trace:winmm:MMDRV_InitPerType (7f640334, 0003, 0001) trace:winmm:MMDRV_InitPerType (7f640334, 0004, 0032) trace:winmm:MMDRV_InitPerType DRVM_INIT => MMSYSERR_NOERROR trace:winmm:MMDRV_InitPerType Got 1 dev for (wavemapper:WaveIn) trace:winmm:MMDRV_InitPerType Setting min=0 max=0 (ttop=0) for (wavemapper:WaveIn) trace:winmm:MMDRV_InitPerType WaveIn:Trans[-1] -> wavemapper trace:winmm:MMDRV_InitPerType (7f640334, 0005, 0003) trace:winmm:MMDRV_InitPerType DRVM_INIT => MMSYSERR_NOERROR trace:winmm:MMDRV_InitPerType Got 1 dev for (wavemapper:WaveOut) trace:winmm:MMDRV_InitPerType Setting min=0 max=0 (ttop=1) for (wavemapper:WaveOut) trace:winmm:MMDRV_InitPerType WaveOut:Trans[-1] -> wavemapper trace:winmm:MMDRV_InitPerType WaveOut:Trans[0] -> wineaudioio.drv trace:winmm:MMDRV_Install ('midimapper', 'midimap.drv', mapper=Y); trace:winmm:MMDRV_GetNum (0003) trace:winmm:MMDRV_Install Got 32 bit func 'modMessage' trace:winmm:MMDRV_GetDescription32 (7fd8f8b8, 7fd8f7e8, 128) trace:winmm:MMDRV_GetDescription32 Can't find file midimap.drv trace:winmm:MMDRV_Install midimap.drv => No description trace:winmm:MMDRV_InitPerType (7f640388, 0000, 0003) trace:winmm:MMDRV_InitPerType (7f640388, 0001, 0001) trace:winmm:MMDRV_InitPerType (7f640388, 0002, 0035) trace:winmm:MMDRV_InitPerType (7f640388, 0003, 0001) trace:winmm:MMDRV_InitPerType DRVM_INIT => MMSYSERR_NOERROR trace:winmm:MMDRV_InitPerType Got 1 dev for (midimapper:MidiOut) trace:winmm:MMDRV_InitPerType Setting min=0 max=0 (ttop=0) for (midimapper:MidiOut) trace:winmm:MMDRV_InitPerType MidiOut:Trans[-1] -> midimapper trace:winmm:MMDRV_InitPerType (7f640388, 0004, 0032) trace:winmm:MMDRV_InitPerType (7f640388, 0005, 0003) fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (7ff2e1c0)->(00010024,00000008) Minimum Stack Set to 1048576 overhead allowance = 0 Allocated thread at 1000 Allocated stack of 2097152 Bytes trace:winmm:MMDRV_GetNum (0005) trace:winmm:waveOutMessage (0, 2068, 2144926836, 0) trace:winmm:MMDRV_Get (0, 0005, N) trace:winmm:MMDRV_Get (0, 0005, Y) trace:winmm:MMDRV_GetByID (0000, 0005) trace:winmm:MMDRV_PhysicalFeatures (7ff1ce8c, 0814, 7fd8fc74, 00000000) trace:winmm:MMDRV_Message (WaveOut 0 2068 0x00000000 0x7fd8fc74 0x00000000 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=2068 usr=0x00000000 p1=0x7fd8fc74 p2=0x00000000) err:wave:wodDsCreate DirectSound flag not set This sound card's driver does not support direct access The (slower) DirectSound HEL mode will be used instead. trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:WAVE_Open (7ff3122c, 0, Out, 7ff30b50, 7F57327E, 7FF30F90, 00030080, 32); trace:winmm:WAVE_Open wFormatTag=1, nChannels=2, nSamplesPerSec=22050, nAvgBytesPerSec=44100, nBlockAlign=2, wBitsPerSample=8 trace:winmm:MMDRV_Alloc (28, 0005, 7fd8fbb8, 7fd8fbe0, 7fd8fbd8, 7fd8fbdc, Y) trace:winmm:MMDRV_GetNum (0005) trace:winmm:WAVE_Open cb=7f5cf0aa trace:winmm:MMDRV_Open (7ff30ba0, 0005, 0x7fd8fb90, 0x00030080) trace:winmm:MMDRV_Open Setting mmdIndex to 0 trace:winmm:MMDRV_Message (WaveOut 0 5 0x7fd8fb50 0x7fd8fb90 0x00030080 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=5 usr=0x7fd8fb50 p1=0x7fd8fb90 p2=0x00030080) Open Audio inf.play.eof=0 inf.play.buffer_size=0 inf.play.samples=0 inf.play.pause=0 inf.play.sample_rate=8000 inf.play.precision=8 inf.play.channels=1 inf.play.encoding=1 inf.play.port=5 inf.play.gain=147 inf.play.error=0 inf.play.waiting=0 inf.play.balance=32 inf.play.active=0 inf.play.open=0 inf.play.avail_ports=7 inf.play.mod_ports=7 inf.record.eof=0 inf.record.buffer_size=0 inf.record.samples=0 inf.record.pause=0 inf.record.sample_rate=8000 inf.record.precision=8 inf.record.channels=1 inf.record.encoding=1 inf.record.port=1 inf.record.gain=127 inf.record.error=0 inf.record.waiting=0 inf.record.balance=32 inf.record.active=0 inf.record.open=0 inf.record.avail_ports=119 inf.record.mod_ports=119 Playback Sample Rate forced to 44100 Playback Channels forced to 2 Playback Precision forced to 16 Recording Sample Rate forced to 44100 Recording Channels forced to 2 Recording Precision forced to 16 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 Playback Sample Rate forced to 44100 Playback Channels forced to 2 Playback Precision forced to 16 Recording Sample Rate forced to 44100 Recording Channels forced to 2 Recording Precision forced to 16 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 Open Audio inf.play.eof=0 inf.play.buffer_size=0 inf.play.samples=0 inf.play.pause=0 inf.play.sample_rate=44100 inf.play.precision=16 inf.play.channels=2 inf.play.encoding=3 inf.play.port=5 inf.play.gain=147 inf.play.error=0 inf.play.waiting=0 inf.play.balance=32 inf.play.active=0 inf.play.open=1 inf.play.avail_ports=7 inf.play.mod_ports=7 inf.record.eof=0 inf.record.buffer_size=0 inf.record.samples=0 inf.record.pause=0 inf.record.sample_rate=8000 inf.record.precision=8 inf.record.channels=1 inf.record.encoding=1 inf.record.port=1 inf.record.gain=127 inf.record.error=0 inf.record.waiting=0 inf.record.balance=32 inf.record.active=0 inf.record.open=0 inf.record.avail_ports=119 inf.record.mod_ports=119 Playback Sample Rate forced to 22050 Playback Channels forced to 2 Playback Precision forced to 8 Recording Sample Rate forced to 22050 Recording Channels forced to 2 Recording Precision forced to 8 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 Playback Sample Rate forced to 22050 Playback Channels forced to 2 Playback Precision forced to 8 Recording Sample Rate forced to 22050 Recording Channels forced to 2 Recording Precision forced to 8 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 CPU Endian forced to 2 Data Type forced to 0 Minimum Stack Set to 1048576 overhead allowance = 0 Allocated thread at 1000 Allocated stack of 2097152 Bytes trace:winmm:MMDRV_Callback CB (*7f57327e)(8000 000003bb 7ff30f90 00000000 00000000 trace:winmm:MMDRV_Message => MMSYSERR_NOERROR trace:winmm:WAVE_Open dwRet = MMSYSERR_NOERROR trace:winmm:WAVE_Open => MMSYSERR_NOERROR hWave=8000 trace:winmm:waveOutGetDevCapsW (0 7fd8fb94 84)! trace:winmm:MMDRV_Get (0, 0005, Y) trace:winmm:MMDRV_GetByID (0000, 0005) trace:winmm:MMDRV_Message (WaveOut 0 4 0x00000000 0x7fd8fb94 0x00000054 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=4 usr=0x00000000 p1=0x7fd8fb94 p2=0x00000054) trace:winmm:MMDRV_Message => MMSYSERR_NOERROR trace:winmm:waveOutPause (8000); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 10 0x7fd8fb74 0x00000000 0x00000000 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=10 usr=0x7fd8fb74 p1=0x00000000 p2=0x00000000) trace:winmm:MMDRV_Message => MMSYSERR_NOERROR trace:winmm:waveOutPrepareHeader (8000, 7ff30c40, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30c40 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30c40 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30c68, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30c68 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30c68 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30c90, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30c90 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30c90 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30cb8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30cb8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30cb8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30ce0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30ce0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30ce0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30d08, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30d08 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30d08 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30d30, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30d30 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30d30 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30d58, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30d58 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30d58 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30d80, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30d80 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30d80 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30da8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30da8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30da8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30dd0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30dd0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30dd0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30df8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30df8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30df8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30e20, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30e20 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30e20 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff30e48, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff30e48 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff30e48 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41420, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41420 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41420 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41448, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41448 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41448 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41470, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41470 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41470 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41498, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41498 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41498 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff414c0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff414c0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff414c0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff414e8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff414e8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff414e8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41510, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41510 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41510 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41538, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41538 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41538 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41560, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41560 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41560 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41588, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41588 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41588 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff415b0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff415b0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff415b0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff415d8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff415d8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff415d8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41600, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41600 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41600 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41628, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41628 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41628 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41650, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41650 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41650 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41678, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41678 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41678 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff416a0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff416a0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff416a0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff416c8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff416c8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff416c8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff416f0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff416f0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff416f0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41718, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41718 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41718 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41740, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41740 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41740 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41768, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41768 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41768 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41790, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41790 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41790 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff417b8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff417b8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff417b8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff417e0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff417e0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff417e0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41808, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41808 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41808 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41830, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41830 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41830 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41858, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41858 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41858 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41880, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41880 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41880 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff418a8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff418a8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff418a8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff418d0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff418d0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff418d0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff418f8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff418f8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff418f8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41920, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41920 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41920 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutPrepareHeader (8000, 7ff41948, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 7 0x7fd8fb74 0x7ff41948 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=7 usr=0x7fd8fb74 p1=0x7ff41948 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOTSUPPORTED trace:winmm:waveOutWrite (8000, 7ff30c40, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 9 0x7fd8fb74 0x7ff30c40 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=9 usr=0x7fd8fb74 p1=0x7ff30c40 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOERROR trace:winmm:waveOutWrite (8000, 7ff30c68, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 9 0x7fd8fb74 0x7ff30c68 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=9 usr=0x7fd8fb74 p1=0x7ff30c68 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOERROR trace:winmm:waveOutWrite (8000, 7ff30c90, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 9 0x7fd8fb74 0x7ff30c90 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=9 usr=0x7fd8fb74 p1=0x7ff30c90 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOERROR trace:winmm:waveOutWrite (8000, 7ff30cb8, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 9 0x7fd8fb74 0x7ff30cb8 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=9 usr=0x7fd8fb74 p1=0x7ff30cb8 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOERROR trace:winmm:waveOutWrite (8000, 7ff30ce0, 32); trace:winmm:MMDRV_Get (8000, 0005, N) trace:winmm:MMDRV_Message (WaveOut 0 9 0x7fd8fb74 0x7ff30ce0 0x00000020 Y) trace:winmm:MMDRV_Message Calling message(dev=0 msg=9 usr=0x7fd8fb74 p1=0x7ff30ce0 p2=0x00000020) trace:winmm:MMDRV_Message => MMSYSERR_NOERROR fixme:mmtime:timeBeginPeriod Stub; we set our timer resolution at minimum trace:mmtime:TIME_SetEventInternal (10, 10, 7f5730e2, 7FF30F90, 0081); Minimum Stack Set to 1048576 overhead allowance = 0 Allocated thread at 1000 Allocated stack of 2097152 Bytes trace:mmtime:TIME_SetEventInternal => 1 trace:mmtime:TIME_MMSysTimeThread Starting main winmm thread trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3200(delta 5) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3210(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3220(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3230(delta 6) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3240(delta 3) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3250(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3260(delta 1) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3270(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3280(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3290(delta 0) fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or DDBLT_ASYNC: can't handle right now. trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3300(delta 30) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3310(delta 20) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3320(delta 10) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3330(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3340(delta 40) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3350(delta 30) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3360(delta 20) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3370(delta 10) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3380(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3390(delta 40) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3400(delta 30) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3410(delta 20) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3420(delta 10) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3430(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3440(delta 35) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3450(delta 25) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3460(delta 15) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3470(delta 5) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3480(delta 52) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3490(delta 42) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3500(delta 32) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3510(delta 22) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3520(delta 12) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3530(delta 2) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3540(delta 1) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3550(delta 1) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3560(delta 1) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3570(delta 10) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3580(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3590(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3600(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3610(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3620(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3630(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3640(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3650(delta 10) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3660(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3670(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3680(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3690(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3700(delta 9) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3710(delta 1) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3720(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3730(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3740(delta 0) trace:mmtime:TIME_TriggerCallBack 000d:CallBack => lpFunc=7f5730e2 wTimerID=0001 dwUser=7FF30F90 dwTriggerTime 3750(delta 0) ...

2 4

Re: Problem with CyberKnex Programmer program and direct LPT1 port access
by Juan Lang 09 Apr '05

09 Apr '05

Hey Terry, update: according to my registry on WinXP, "Ports" should return the GUID {4D36E978-E325-11CE-BFC1-08002BE10318}. This is also known as GUID_DEVINTERFACE_SERENUM_BUS_ENUMERATOR. Right now that GUID used with SetupDiGetClassDevs returns serial ports, and it should return both serial ports and parallel ports. Hope that helps, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Wine and USB scanner access ?
by Barbara Post 09 Apr '05

09 Apr '05

Hi, I'm using latest Wine (20050310) with Debian sid (kernel 2.6.11). I own an USB 1.1 scanner : Agfa SnapScan 1212U. I successfully installed ScanWise software provided by the vendor (2.0.0.9 version) but when I launch it, it behaves as if the scanner's light wasn't on, or it was unplugged : it asks for me to connect the scanner. Below is the debugging info. I also tried to launch Xsane in order to load the firmware into the scanner, then launched ScanWise. I even tried to let Xsane open when launching ScanWise. I have the same unsuccess in all cases. Would something be misconfigured with USB ports detection/access ? Thank you very much for any hint. Barbara Post BTW - does the repeated message about setting screen resolution really bug ? Trace : barbara@babs1:/data3$ WINEDEBUG=+twain,+loaddll wine ./fake_windows/Program\ Files/Agfa/ScanWise\ 2_00/scanwise.exe Invoking /usr/lib/wine/wine.bin ./fake_windows/Program Files/Agfa/ScanWise 2_00/scanwise.exe ... trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\advapi32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\gdi32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\user32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\MSVCRT.dll" : native trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\MSVCIRT.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\satbase.dll" : native trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\iphlpapi.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\ws2_32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\wsock32.dll" : builtin trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\satproc.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\satapi.dll" : native trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\rpcrt4.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\ole32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\shlwapi.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\comctl32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\shell32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\oleaut32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\lz32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\version.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\adomps.dll" : native trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\MFC42.DLL" : native trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\MSVCP60.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\ScanWise.dll" : native trace:loaddll:MODULE_LoadModule16 Loaded module "krnl386.exe" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "system.drv" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "GDI.EXE" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "USER.EXE" : builtin trace:loaddll:MODULE_LoadModule16 Loaded module "keyboard.drv" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\x11drv.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\imm32.dll" : builtin Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:ole:CoRegisterMessageFilter stub trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\mscms.dll" : builtin trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\satscan.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\satscansrv.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\CMS313.DLL" : native fixme:palette:GetICMProfileA (0xa74, 0x7791f908, 0x7791f800): partial stub trace:loaddll:MODULE_FlushModrefs Unloaded module L"C:\\Windows\\System\\mscms.dll" : builtin fixme:user:EnumDisplayDevicesA ((nil),0,0x7fa4f0a4,0x00000000), stub! trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:MODULE_FlushModrefs Unloaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agbmp313.dll" : native trace:loaddll:MODULE_FlushModrefs Unloaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agbmp313.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agfpx2.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agfpx313.dll" : native trace:loaddll:MODULE_FlushModrefs Unloaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agfpx313.dll" : native trace:loaddll:MODULE_FlushModrefs Unloaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agfpx2.dll" : native trace:loaddll:load_dll Loaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agpct313.dll" : native trace:loaddll:MODULE_FlushModrefs Unloaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\agpct313.dll" : native trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:MODULE_FlushModrefs Unloaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\wnaspi32.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:MODULE_FlushModrefs Unloaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:load_dll Loaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:MODULE_FlushModrefs Unloaded module L"C:\\Windows\\System\\sti.dll" : builtin trace:loaddll:MODULE_FlushModrefs Unloaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\CMS313.DLL" : native trace:loaddll:MODULE_FlushModrefs Unloaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\satscansrv.dll" : native trace:loaddll:MODULE_FlushModrefs Unloaded module L"Z:\\data3\\fake_windows\\Program Files\\Agfa\\ScanWise 2_00\\satscan.dll" : native fixme:ole:CoRegisterMessageFilter stub Wine exited with a successful status -- "The illiterate of the 21st century will not be those who cannot read and write, but those who cannot learn, unlearn, and relearn." Alvin Toffler

2 1

Re: Problem with CyberKnex Programmer program and direct LPT1 port access
by Juan Lang 09 Apr '05

09 Apr '05

Hi Terry, I'll jump in on this if you don't mind. > It appears that my program, in the "setupapi", calls > SetupDiClassGuidsFromNameExA with the name "Ports". So I presume > this is trying to get a handle for the "Ports" driver which looks > like it is not implemented. Almost. I think it's trying to get the GUID of all devices that full under the "Ports" class. This includes serial and parallel ports. I suspect it will then try to enumerate devices of that class, using e.g. SetupDiGetClassDevsA. Right now a very hackish implementation of SetupDiGetClassDevsA/W exists for serial ports, but not for parallel ports. > I note it trys to get some info on a > ControlClass key from the registry. This fails. Yep, this appears to be missing from the registry. Some keys probably should be added to tools/wine.inf, there isn't much point in searching the registry for these keys if they're never added. Both of these should be addressed, but you can probably hack something for the moment: have SetupDiGetClassGuidsFromNameExA return some GUID you make up for "Ports", and see how far your app gets. If if then calls some other SetupDi function with that GUID, hack up that function to return something. I'm not suggesting that should go into Wine, but you can probably coax the app into getting farther. > 1. How well does wine generally work when "windows=winxp" ? Depends on the app. > 3. I note that the device NtDeviceIoControlFile ioctl interface in > ntdll only supports CDROM devices. Also there does not seem > to be a way of dynamically attaching devices. Should I just > hard code a "Ports" driver in ntdll ? CDROM_DeviceIoControl will fail if it's not a CDROM device, so you can try a parallel port ioctl afterward if you like. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250

1 0

Problem with CyberKnex Programmer program and direct LPT1 port access
by Terry Barnaby 09 Apr '05

09 Apr '05

Hi, I am trying to get the K'nex CyberKnex Programmer Windows program working under wine on Fedora 3. It appears to be generally working but this program needs direct access to the LPT1 parallel port to drive an external "flash key" programmer. I am using wine 20050310. If I try this I get an error stating that the program cannot access the LPT1 parallel port. I note an error message, from wine, stating: "fixme:vxd:VXD_Open Unknown/unsupported VxD L"driverx.vxd". Try setting Windows version to 'nt40' or 'win31'" I have tried setting the "Windows" parameter to "winxp" and setting "export WINEDEBUG=+io,+int,+vxd;". This still does not work I get the error messages: fixme:setupapi:SetupDiClassGuidsFromNameExA trace:vxd:DeviceIoControl (0xffffffff,222074,0x7e8e00b4,4,(nil),0,0x72c9f57c,(nil)) I understand, from reading mailing lists and looking at the program, that the program is using a DLL which has the capability of loading an embedded VXD driver to access the LPT1 port. Some questions: 1. Should this VXD driver loaded when the window system is set to "winxp" ? 2. Is there any way I can get this program to communicate with the LPT1 port ? Cheers Terry

3 5

Re: ole32: add IPropertyStorage tests
by Dmitry Timoshkov 09 Apr '05

09 Apr '05

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > +#define UNICODE_CP 1200 IMO it's better to name it CP_UNICODE as dlls/mlang/mlang.c has. It's a more consistent value with what include/ddeml.h: #define CP_WINUNICODE 1200 and PSDK's mimeole.idl: const CODEPAGEID CP_UNICODE = 1200; have. Moreover, it sounds more natural to define it that way since we already have CP_ACP, CP_OEMCP, CP_MACCP. -- Dmitry.

1 0

wine_init from elf executable
by Stephen Crowley 08 Apr '05

08 Apr '05

Can someone provide a quick example of how to link a an app and initialize wine via wine_init myself? I've tried the stuff from mono and also libfst.. I really need this to work, it isn't an option to run from a winelib app because I need to access a non-managed dll via the mono runtime. #0 0x4030ed68 in server_init_process () from /usr/lib/wine/ntdll.dll.so #1 0x4031339e in thread_init () from /usr/lib/wine/ntdll.dll.so #2 0x402face8 in __wine_process_init () from /usr/lib/wine/ntdll.dll.so #3 0x4018c9a2 in wine_init () from /usr/lib/libwine.so.1 Thanks, Stephen

1 0

Problem with new info.c in ntdll/tests
by Paul Vriens 08 Apr '05

08 Apr '05

Hi, I am busy generating some new tests for ntdll's *Information* calls. I started with query.c and that was OK. I then thought info.c would be a better name. doing a make depend && make fails. In tried information.c and make depend && make fails again with: make[3]: Entering directory `/data/install/linux/wine-src/wine/dlls/ntdll/tests' gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o information.o information.c gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o testlist.o testlist.c ../../../tools/winegcc/winegcc -B../../../tools/winebuild -mconsole env.o error.o generated.o information.o large_int.o path.o reg.o rtl.o rtlbitmap.o rtlstr.o string.o time.o testlist.o -o ntdll_test.exe.so -L../../../libs/port -lwine_port -L../../../dlls -L../../../libs -lkernel32 testlist.o(.data.rel.ro+0x1c): In function `get_tls_data': /data/install/linux/wine-src/wine/dlls/ntdll/tests/../../../include/wine/test.h:116: undefined reference to `func_information' collect2: ld returned 1 exit status winegcc: gcc failed. make[3]: *** [ntdll_test.exe.so] Error 2 make[3]: Leaving directory `/data/install/linux/wine-src/wine/dlls/ntdll/tests' make[2]: *** [tests] Error 2 make[2]: Leaving directory `/data/install/linux/wine-src/wine/dlls/ntdll' make[1]: *** [ntdll] Error 2 make[1]: Leaving directory `/data/install/linux/wine-src/wine/dlls' make: *** [dlls] Error 2 with info.c I see: undefined reference to `func_info' If I rename the file back to query.c (and of course change the Makefile.in) everything is fine again. Any idea what's wrong? Cheers, Paul.

2 2

Wine and Process Explorer
by Paul Vriens 08 Apr '05

08 Apr '05

Hi, I was just wondering if it's worthwhile to get Process Explorer running on Wine. It contains a lot of 'under-the-hood' stuff which is maybe not needed anywhere else (except the taskmgr, maybe). There are lots of unimplemented calls and lots of undocumented as well. I've found some documentation on CodeGuru and Reactos seems to have some parts implemented. I've started adding things but get into lots of new exceptions. It will at least broaden my knowledge about Wine/Windows. Cheers, Paul.

2 1

Re: [Wine]wine 20041019 for ubuntu
by Scott Ritchie 07 Apr '05

07 Apr '05

On Thu, 2005-04-07 at 14:27 +0200, Dripple wrote: > Hi all, > > I'm planning testing ubuntu, but I need to install Lotus Notes on it, > and for this, the last good wine version was 20041019. > > Anyplace where I can get binaries of this ? > > Thanks. > > Dripple > I thought the latest version fixed it... Anyway, you can find them on my webspace here: http://tuzakey.com/~scott/apt/binary/old/ You'll have to download and install them by hand, though. -Scott Ritchie

1 0

Re: [Wine]Re: ie5, ie6 won't install
by Damnation 07 Apr '05

07 Apr '05

i am trying to get ie6 installed, i looked at the aol boards and they suggested. that i get Ie6 winetools aol communicator. aol communicator will allow me to get online with my aol account. unfortunatly as i try to install ie6 it complains about ole missing. unfortunatly i cannot get online to download the missing files through linux. because i need aol communicator working to get online(think of it as a custom dialer) so any help would be great. i've used: wine-20050111-mdk.i586.rpm Cedega-20041223-cvs.i586.rpm winetools-211jo.tar.gz wine-20050310-mdk.i586.rpm i am using mandrake linux 10.1

4 7

ative windows dll, proxy methods, Unsupported Dwarf2 information for...
by Stephen Crowley 07 Apr '05

07 Apr '05

Hi, I have a win32 dll which exports about 30 functions. I've used winedump with the -f and -I flags to create stub/proxy functions which use LoadLibrary. Please CC my on all responses as I am not subscribed to the list. It generates functions like so.. HGTBSESSION __stdcall GTBAPI_gtbCreateSession(HWND hParent, GTBSessionCallback * lpCallBack, void * lpParam) { HGTBSESSION (__stdcall *pFunc)(HWND, const GTBSessionCallback *, void *); HGTBSESSION retVal; pFunc=(void*)GetProcAddress(hDLL,"gtbCreateSession"); TRACE("((HWND)%p,(GTBSessionCallback *)%p,(void *)%p): forward\n",hParent,lpCallBack,lpParam); retVal = pFunc(hParent,lpCallBack,lpParam); TRACE("Returned (%p)\n",retVal); return retVal; } For compatibility with existing code I removed the GTBAPI_ from the function and switched back to the native prototype. GTAPIB_EXTERN HGTBSESSION WINAPI gtbCreateSession(HWND hParent, const GTBSessionCallback *lpCallBack, void *lpParam) Compiled and linked like so. gcc -shared GTAPIB_main.c -I/usr/include/wine/windows -I../GenSrc/API/GTAPIB -o ../lib/libgtapib.so /usr/lib/wine/kernel32.dll.so Then I have a small test app that I compile/link: winegcc TestAPIB.c -I/usr/include/wine/windows -I ../../../GenSrc/API/GTAPIB -L../../../lib -lgtapib -lkernel32 -o TestAPIB Running ./TestAPIB throws the following error WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00000000). In 32 bit mode. ..... Backtrace: =>1 0x00000000 (0x406efe60) fixme:dbghelp:elf_load_debug_info_from_map Unsupported Dwarf2 information for testapib<elf> 2 0x405e5276 WinMain in testapib (0x406efe90) 3 0x405e5173 __wine_exe_main in testapib (0x406eff20) 4 0x404e0de2 in kernel32 (+0x50de2) (0x406efff4) 5 0x4001d181 wine_switch_to_stack in libwine.so.1 (0x00000000) 0x00000000: addb %al,0x0(%eax) My wine version is 20050310 Any tips would be greatly appreciated. Thanks, Stephen

1 0

cvs broken ?
by wino＠piments.com 07 Apr '05

07 Apr '05

I jsut rebuilt wine0cvs and now nothing will run even what ran 5 min before. prof@newsys ~/.wine/c $ wine N*/P*/nat* Warning: the specified Windows directory L"c:\\windows" is not accessible. Warning: the specified System directory L"c:\\windows\\system" is not accessible. Warning: could not find DOS drive for current working directory '/home/prof/.wine/c', starting in the Windows directory. wine: cannot find 'NatSpeak/Program/natspeak.exe' Help?

2 1

Re: AJ on vacation?
by Steven Edwards 07 Apr '05

07 Apr '05

Hi, --- Tom Wickline <twickline(a)gmail.com> wrote: > Has AJ taken a vacation? I think he is out till tomorrow or Friday. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Personals - Better first dates. More second dates. http://personals.yahoo.com

2 1

Remote debugging
by David Hemmo 07 Apr '05

07 Apr '05

Hello, I am new to wine. I try to get a PC software (I have the source code) to run on Linux but as the project may take a while, I try to prepare a development environement that will make my life easier. I have Wine from CVS, and msvcmon (the remote part of Visual studio) running on Linux. I can launch the software from my windows machine, and I can break on my source code running un Linux. But step doesn't work. Would someone have an idea of where in wine source code I should have a look ? Is there any document that you know that could help me to understand how it works, and the architecture ? Thanks David Hemmo

3 2

compiling msvcrt with gcc4
by James Hawkins 07 Apr '05

07 Apr '05

Hi, I just installed FC4 test1 with gcc4, gcc (GCC) 4.0.0 20050405 (Red Hat 4.0.0-0.40) Compiling msvcrt produces these errors: ../../../include/msvcrt/io.h:179: error: 'open' aliased to external symbol '_open' ../../../include/msvcrt/io.h:180: error: 'sopen' aliased to undefined symbol '_sopen' ../../../include/msvcrt/process.h:129: error: 'execl' aliased to undefined symbol '_execl' ../../../include/msvcrt/process.h:130: error: 'execle' aliased to undefined symbol '_execle' ../../../include/msvcrt/process.h:131: error: 'execlp' aliased to undefined symbol '_execlp' ../../../include/msvcrt/process.h:132: error: 'execlpe' aliased to undefined symbol '_execlpe' ../../../include/msvcrt/process.h:133: error: 'spawnl' aliased to undefined symbol '_spawnl' ../../../include/msvcrt/process.h:134: error: 'spawnle' aliased to undefined symbol '_spawnle' ../../../include/msvcrt/process.h:135: error: 'spawnlp' aliased to undefined symbol '_spawnlp' ../../../include/msvcrt/process.h:136: error: 'spawnlpe' aliased to undefined symbol '_spawnlpe' Is this a gcc4 problem or something we can fix? -- James Hawkins

1 1

Re: Add mousewheel support to riched20
by Joris Huizer 06 Apr '05

06 Apr '05

Hannu Valtonen wrote: > Hi, > > This patch adds mousewheel support to the rapidly maturing riched20. > > Changelog: > Add mousewheel support to riched20 > > - Hannu Valtonen > + case WM_MOUSEWHEEL: > + { > + int gcWheelDelta = 0, nPos = editor->nScrollPosY; > + UINT pulScrollLines; > + > + SystemParametersInfoW(SPI_GETWHEELSCROLLLINES,0, &pulScrollLines, 0); > + gcWheelDelta -= GET_WHEEL_DELTA_WPARAM(wParam); > + if (abs(gcWheelDelta) >= WHEEL_DELTA && pulScrollLines) > + nPos += pulScrollLines * (gcWheelDelta / WHEEL_DELTA) * 8; Why not like > + SystemParametersInfoW(SPI_GETWHEELSCROLLLINES,0, &pulScrollLines, 0); > + gcWheelDelta = GET_WHEEL_DELTA_WPARAM(wParam); > + if (gcWheelDelta >= WHEEL_DELTA && pulScrollLines) > + nPos += pulScrollLines * (-gcWheelDelta / WHEEL_DELTA) * 8; just seems simpler; regards, Joris

2 1

ie5, ie6 won't install
by Wesley Parish 06 Apr '05

06 Apr '05

[wparish@localhost inex5]$ wine --version Wine 20040813 That was a Mandrake 10.0 rpm installation, over which I installed Wine-20050211.tar.gz This is the relevant history: [wparish@localhost wine-hdd]$ cd ie6 [wparish@localhost ie6]$ ls ADVAUTH.CAB* IECIF.CAB* IEMIL_2.CAB* IEW2K_1.CAB* OEEXCEP.CAB* AOLSUPP.CAB* IEDATA.CAB* IEMIL_3.CAB* IEW2K_2.CAB* README.CAB* AXA3.CAB* IEDOM.CAB* IEMIL_4.CAB* IEW2K_3.CAB* SCAIME.CAB* AXA.CAB* IEEXINST.CAB* IENT_S1.CAB* IEW2K_4.CAB* SCR56EN.CAB* BRANDING.CAB* IE_EXTRA.CAB* IENT_S2.CAB* JAAIME.CAB* SCRIPTEN.CAB* CRLUPD.CAB* IELPKAD.CAB* IENT_S3.CAB* KOAIME.CAB* SETUPNT.CAB* DXDDEX.CAB* IELPKAR.CAB* IENT_S4.CAB* MAILNEWS.CAB* SETUPW95.CAB* FONTCORE.CAB* IELPKIW.CAB* IENT_S5.CAB* MDAC_IE5.CAB* SWFLASH.CAB* FONTSUP.CAB* IELPKJA.CAB* IENT_S6.CAB* MOBILE95.CAB* TCAIME.CAB* GSETUP95.CAB* IELPKKO.CAB* IE_S1.CAB* MOBILENT.CAB* TS95.CAB* GSETUPNT.CAB* IELPKPE.CAB* IE_S2.CAB* MPCDCS.CAB* TSNT.CAB* HELPCONT.CAB* IELPKTH.CAB* IE_S3.CAB* MPLAY2A.CAB* USP10.CAB* HHUPD.CAB* IELPKVI.CAB* IE_S4.CAB* MPLAY2U.CAB* VGX.CAB* ICW.CAB* IELPKZHC.CAB* IE_S5.CAB* MPLAYER2.CAB* WAB.CAB* ICWCON.CAB* IELPKZHT.CAB* IE_S6.CAB* MSN_AUTH.CAB* ie6setup.exe* IEMIL_1.CAB* iesetup.ini* OAINST.CAB* [wparish@localhost ie6]$ wine ie6setup.exe fixme:cursor:CURSORICON_SimulateLoadingFromResourceW Animated icons not correctly implemented! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon entry found! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon size ok. offset=0x41370074 fixme:setupapi:SETUPX_CreateStandardLDDs LDID_SRCPATH: what exactly do we have to do here ? fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0705, 0000, 00000000, 403eb45c) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070f, 0000, 00000000, 403eb45c) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0710, 0000, 00000000, 403eb45c) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070b, 0000, 00000000, 403eb45c) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070c, 0000, 00000000, 403eb45c) - semi-stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:dc:GetLayout (0x758): stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:cursor:CURSORICON_SimulateLoadingFromResourceW Animated icons not correctly implemented! 0x41dc0000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon entry found! 0x41dc0000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon size ok. offset=0x41dc0074 fixme:shell:Stream_WriteLocationInfo writing empty location info fixme:shell:SHELL32_DllCanUnloadNow (void): stub fixme:shell:SHELL32_DllCanUnloadNow (void): stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS0086A2.tmp\\w95inf16.dll" -> "c: \\windows\\system\\w95inf16.dll" err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS0086A2.tmp\\w95inf32.dll" -> "c: \\windows\\system\\w95inf32.dll" fixme:setupapi:do_file_copyW Notify that target version is greater.. err:setupapi:SetupDefaultQueueCallbackA copy error 0 "C: \\windows\\msdownld.tmp\\AS0086A2.tmp\\cabinet.dll" -> "c: \\windows\\system\\cabinet.dll" err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS0086A2.tmp\\regsvr32.exe" -> "c: \\windows\\system\\regsvr32.exe" fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH err:setupapi:SetupDefaultQueueCallbackA copy error 32 "C: \\windows\\msdownld.tmp\\AS008A4E.tmp\\OLEAUT32.DLL" -> "c: \\windows\\system\\OLEAUT32.DLL" fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO [wparish@localhost ie6]$ wine ie6setup.exe fixme:cursor:CURSORICON_SimulateLoadingFromResourceW Animated icons not correctly implemented! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon entry found! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon size ok. offset=0x41370074 fixme:setupapi:SETUPX_CreateStandardLDDs LDID_SRCPATH: what exactly do we have to do here ? fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0705, 0000, 00000000, 403de0b4) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070f, 0000, 00000000, 403de0b4) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0710, 0000, 00000000, 403de0b4) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070b, 0000, 00000000, 403de0b4) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070c, 0000, 00000000, 403de0b4) - semi-stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:dc:GetLayout (0x758): stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:cursor:CURSORICON_SimulateLoadingFromResourceW Animated icons not correctly implemented! 0x416b0000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon entry found! 0x416b0000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon size ok. offset=0x416b0074 fixme:shell:Stream_WriteLocationInfo writing empty location info fixme:shell:SHELL32_DllCanUnloadNow (void): stub fixme:shell:SHELL32_DllCanUnloadNow (void): stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS005742.tmp\\w95inf16.dll" -> "c: \\windows\\system\\w95inf16.dll" err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS005742.tmp\\w95inf32.dll" -> "c: \\windows\\system\\w95inf32.dll" fixme:setupapi:do_file_copyW Notify that target version is greater.. err:setupapi:SetupDefaultQueueCallbackA copy error 0 "C: \\windows\\msdownld.tmp\\AS005742.tmp\\cabinet.dll" -> "c: \\windows\\system\\cabinet.dll" err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS005742.tmp\\regsvr32.exe" -> "c: \\windows\\system\\regsvr32.exe" fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH err:setupapi:SetupDefaultQueueCallbackA copy error 32 "C: \\windows\\msdownld.tmp\\AS005AEE.tmp\\OLEAUT32.DLL" -> "c: \\windows\\system\\OLEAUT32.DLL" fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO [wparish@localhost ie6]$ wine ie6setup.exe fixme:cursor:CURSORICON_SimulateLoadingFromResourceW Animated icons not correctly implemented! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon entry found! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon size ok. offset=0x41370074 fixme:setupapi:SETUPX_CreateStandardLDDs LDID_SRCPATH: what exactly do we have to do here ? fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0705, 0000, 00000000, 403de044) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070f, 0000, 00000000, 403de044) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0710, 0000, 00000000, 403de044) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070b, 0000, 00000000, 403de044) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070c, 0000, 00000000, 403de044) - semi-stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:dc:GetLayout (0x758): stub wine: Unhandled exception (thread 000b), starting debugger... fixme:console:SetConsoleCtrlHandler (0x406205b0,1) - no error checking or testing yet WineDbg starting on pid 0xa Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00000000). In 32 bit mode. 0x00000000: addb %al,0x0(%eax) Wine-dbg> Ctrl-C Ctrl-C: stopping debuggee [wparish@localhost ie6]$ WineDbg terminated on pid 0xa [wparish@localhost ie6]$ cd .. [wparish@localhost wine-hdd]$ rm -rf ie6/ [wparish@localhost wine-hdd]$ ls /home/wparish/.wine/d dosdevices drive_c [wparish@localhost wine-hdd]$ ls /home/wparish/.wine/drive_c/ autoexec.bat Local Settings/ Program Files/ temp@ windows/ config.sys My Documents/ Programme@ tmp@ [wparish@localhost wine-hdd]$ ls /home/wparish/.wine/drive_c/windows/ Active Setup Log.BAK Favorites/ profiles/ system.ini Active Setup Log.txt fonts/ Recent/ temp/ All Users/ History/ regedit.exe@ Temporary Internet Files/ Application Data/ iextract.exe* regtlib.exe* uninstall.exe@ AppPatch/ inf/ rundll32.exe@ winebrowser.exe@ command/ Installer/ SendTo/ winhelp.exe@ Cookies/ msdownld.tmp/ ShellNew/ winhlp32.exe.wine@ Cursors/ NetHood/ Start Menu/ win.ini Desktop/ notepad.exe@ Sysbckup/ extract.exe* PrintHood/ system/ [wparish@localhost wine-hdd]$ ls /home/wparish/.wine/drive_c/Pr Program Files Programme [wparish@localhost wine-hdd]$ ls /home/wparish/.wine/drive_c/Program\ Files/ Common Files/ Internet Explorer/ Uninstall Information/ [wparish@localhost wine-hdd]$ ls /home/wparish/.wine/drive_c/Program\ Files/Internet\ Explorer/ iedetect.dll iesetup.cif Uninstall Information/ [wparish@localhost wine-hdd]$ mkdir inex5 [wparish@localhost wine-hdd]$ cd inex5/ [wparish@localhost inex5]$ ls advauth.cab* gsetupnt.cab* ie_extra.cab* ient_s1.cab* jaaime.cab* aolsupp.cab* helpcont.cab* ielpkad.cab* ient_s2.cab* koaime.cab* axa2.cab* helpinst.exe* ielpkar.cab* ient_s3.cab* mailnews.cab* axa3.cab* hhupd.cab* ielpkiw.cab* ient_s4.cab* mdac_ie5.cab* axa.cab* icw.cab* ielpkja.cab* ient_s5.cab* mmssetup.cab* branding.cab* icwcon.cab* ielpkko.cab* ie_s1.cab* mnewsw2k.cab* dcom95.exe* ie4mfc40.cab* ielpkpe.cab* ie_s2.cab* mobile95.cab* dxddex.cab* ie501dom.exe* ielpkth.cab* ie_s3.cab* mobilent.cab* dxmini.cab* ie5comp.exe* ielpkvi.cab* ie_s4.cab* mpcdcs.cab* fontcore.cab* ie5setup.exe* ielpkzhc.cab* ie_s5.cab* mplayer2.cab* fontsup.cab* iecif.cab* ielpkzht.cab* iesetup.ini* msn_auth.cab* fpesetup.cab* iedata.cab* iemil_1.cab* iew2k_1.cab* nm30.cab* fullsw.cab* iedataja.cab* iemil_2.cab* iew2k_2.cab* oainst.exe* gsetup95.cab* ieexinst.cab* iemil_3.cab* iew2k_3.cab* [wparish@localhost inex5]$ ls *.exe dcom95.exe* ie501dom.exe* ie5setup.exe* vrml2c.exe* helpinst.exe* ie5comp.exe* oainst.exe* [wparish@localhost inex5]$ wine ie5 ie501dom.exe ie5comp.exe ie5setup.exe [wparish@localhost inex5]$ wine ie5setup.exe fixme:cursor:CURSORICON_SimulateLoadingFromResourceW Animated icons not correctly implemented! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon entry found! 0x41370000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon size ok. offset=0x41370074 fixme:setupapi:SETUPX_CreateStandardLDDs LDID_SRCPATH: what exactly do we have to do here ? fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0705, 0000, 00000000, 403ebe84) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070f, 0000, 00000000, 403ebe84) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 0710, 0000, 00000000, 403ebe84) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070b, 0000, 00000000, 403ebe84) - semi-stub fixme:setupapi:vcpUICallbackProc16 (0xbb60, 070c, 0000, 00000000, 403ebe84) - semi-stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:do_file_copyW Notify that target version is greater.. err:setupapi:SetupDefaultQueueCallbackA copy error 0 "T: \\IXP006.TMP\\INSENG.DLL" -> "c:\\windows\\system\\INSENG.DLL" fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:cursor:CURSORICON_SimulateLoadingFromResourceW Animated icons not correctly implemented! 0x422d0000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon entry found! 0x422d0000 fixme:cursor:CURSORICON_SimulateLoadingFromResourceW icon size ok. offset=0x422d0074 fixme:shell:Stream_WriteLocationInfo writing empty location info fixme:shell:SHELL32_DllCanUnloadNow (void): stub fixme:shell:SHELL32_DllCanUnloadNow (void): stub fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_REGSRCPATH err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS086A37.tmp\\w95inf16.dll" -> "c: \\windows\\system\\w95inf16.dll" err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS086A37.tmp\\w95inf32.dll" -> "c: \\windows\\system\\w95inf32.dll" fixme:setupapi:do_file_copyW Notify that target version is greater.. err:setupapi:SetupDefaultQueueCallbackA copy error 0 "C: \\windows\\msdownld.tmp\\AS086A37.tmp\\cabinet.dll" -> "c: \\windows\\system\\cabinet.dll" err:setupapi:SetupDefaultQueueCallbackA copy error 5 "C: \\windows\\msdownld.tmp\\AS086A37.tmp\\regsvr32.exe" -> "c: \\windows\\system\\regsvr32.exe" fixme:setupapi:GenInstall16 unsupported flag: GENINSTALL_DO_CFGAUTO err:setupapi:SetupDefaultQueueCallbackA copy error 32 "T: \\IXP007.TMP\\OLEAUT32.DLL" -> "c:\\windows\\system\\OLEAUT32.DLL" fixme:setupapi:do_file_copyW Notify that target version is greater.. err:setupapi:SetupDefaultQueueCallbackA copy error 0 "T: \\IXP007.TMP\\OLEPRO32.DLL" -> "c:\\windows\\system\\OLEPRO32.DLL" fixme:setupapi:do_file_copyW Notify that target version is greater.. err:setupapi:SetupDefaultQueueCallbackA copy error 0 "T: \\IXP007.TMP\\ASYCFILT.DLL" -> "c:\\windows\\system\\ASYCFILT.DLL" fixme:setupapi:do_file_copyW Notify that target version is greater.. err:setupapi:SetupDefaultQueueCallbackA copy error 0 "T: \\IXP007.TMP\\STDOLE2.TLB" -> "c:\\windows\\system\\STDOLE2.TLB" wine: Unhandled exception (thread 0011), starting debugger... fixme:console:SetConsoleCtrlHandler (0x406205b0,1) - no error checking or testing yet WineDbg starting on pid 0x10 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00000000). In 32 bit mode. 0x00000000: addb %al,0x0(%eax) Wine-dbg>[wparish@localhost inex5]$ Make what you will of it. I can't make head or tail of it. Wesley Parish -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

3 2

AJ on vacation?
by Tom Wickline 06 Apr '05

06 Apr '05

Has AJ taken a vacation?

2 1

Crash due to edit.c patch (was: Regression: origin6 crashes with 20050310 (20050211 works))
by Tobias Burnus 06 Apr '05

06 Apr '05

Hello, as described in http://bugs.winehq.org/show_bug.cgi?id=2813 , Origin6 crashes with the edit.c patch, implementing !ES_AUTO[HV]SCROLL (http://www.winehq.org/hypermail/wine-cvs/2005/02/0506.html). A rather concise but hopefully complete enough trace can be found attached to the bug. Unfortunally, the edit.c patch is too big for me to see anything obvious. Since Origin is of some importance to me, I'm also also willing to pay some bounty for it. Tobias PS: I think there is a further problem burried since even without that patch it won't work - though it doesn't crash (but endless-loops) and proceeds a bit further. I'm trying to nail down the other patch as well (it should be around the same day; unfortunally compiling Wine takes quite long).

2 1

Re: crypt32: CryptProtectData/CryptUnprotectData take 3
by Dmitry Timoshkov 06 Apr '05

06 Apr '05

"Kees Cook" <kees(a)outflux.net> wrote: > diff -u -p -u -p -r1.19 crypt32.spec > --- dlls/crypt32/crypt32.spec 10 Nov 2004 01:31:50 -0000 1.19 > +++ dlls/crypt32/crypt32.spec 6 Apr 2005 05:52:55 -0000 > @@ -133,6 +133,7 @@ > @ stub CryptMsgUpdate > @ stub CryptMsgVerifyCountersignatureEncoded > @ stdcall CryptProtectData(ptr wstr ptr ptr ptr long ptr) > +@ stdcall CryptUnprotectData(ptr ptr ptr ptr ptr long ptr) > @ stdcall CryptRegisterDefaultOIDFunction(long str long wstr) > @ stdcall CryptRegisterOIDFunction(long str str wstr str) > @ stub CryptRegisterOIDInfo > @@ -149,7 +150,6 @@ > @ stub CryptSignHashU > @ stub CryptSignMessage > @ stub CryptSignMessageWithKey > -@ stub CryptUnprotectData > @ stub CryptUnregisterDefaultOIDFunction > @ stub CryptUnregisterOIDFunction > @ stub CryptUnregisterOIDInfo It's better to keep alphabetical order of .spec file entries. > +#include "config.h" > +#include <stdarg.h> > +#include <stdio.h> > +#include <string.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "wincrypt.h" > +#include "winreg.h" > +#include "winnls.h" > +#include "mssip.h" > +#include "wine/debug.h" > + > +WINE_DEFAULT_DEBUG_CHANNEL(crypt); if you are not going to conditionally include headers using '#ifdef HAVE_xxx' there is no need to include config.h. > + r = RegCreateKeyExW(hkeyMap, wszIndexKey, 0, NULL, REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, NULL, &hkeyOpen, &dwDisposition); > + if (r != ERROR_SUCCESS) > + continue; > + if (dwDisposition == REG_OPENED_EXISTING_KEY) > + { > + /* already exists, skip */ > + CloseHandle(hkeyOpen); Registry keys should be closed by RegCloseKey, not CloseHandle (here and everywhere else). > + entropy.pbData=(void*)key; > + entropy.cbData=strlen(key)+1; > + > + protected = CryptProtectData(NULL,desc,NULL,NULL,NULL,0,&cipher); > + ok(!protected, "Encrypting without plain data source.\n"); > + r = GetLastError(); > + ok2(r == ERROR_INVALID_PARAMETER, "Wrong (%lu) GetLastError seen\n",r); If you are going to test last error value after an API call it's a usual practice to set the error first to some invalid value, 0xdeadbeef works fine. -- Dmitry.

2 1

Starting up
by David Gümbel 06 Apr '05

06 Apr '05

Hello everybody, - a while ago we were debating an initiative named "Wine-Probe"[1] (which would roughly equal "Wine-tasting" in english) on wine-devel that was in the making between Wirtschaftsförderung Region Stuttgart GmbH and us (ITOMIG). Its goal is to make local software vendors aware of the potential bussiness opportunity in a Wine-based port or a Wine/Linux version of their software. It's also designed to be beneficial for the Wine project as a whole, e.g. by providing AppDB entries and success stories. This is to let you know that we've officially launched the initiative by today. It has already made it into several (german speaking) news sites[2], so I'd say things look promising. We're looking forward to the interest and feedback we'll get in the weeks to come. Cheers, David P.S. Apologies to whomever suggested "PortWine" as an alternative name - after some discussion we've finally decided to stay with the "old" name ;) [1] http://www.winehq.com/site?issue=254#WINEprobe%20Initiative [2] http://www.golem.de/0504/37335.html http://www.pro-linux.de/news/2005/7996.html http://www.pc-magazin.de/common/nws/einemeldung.php?id=37335

1 0

Remote debugging
by David Hemmo 06 Apr '05

06 Apr '05

Hello, I am new to wine. I try to get a PC software (I have the source code) to run on Linux but as the project may take a while, I try to prepare a development environement that will make my life easier. I have Wine from CVS, and msvcmon (the remote part of Visual studio) running on Linux. I can launch the software from my windows machine, and I can break on my source code running un Linux. But step doesn't work. Would someone have an idea of where in wine source code I should have a look ? Is there any document that you know that could help me to understand how it works, and the architecture ? Thanks David Hemmo PS: This is a repost, it looks like my first post didn't got through :-(

1 0

Re: crypt32: CryptProtectData/CryptUnprotectData take 2
by Mike McCormack 06 Apr '05

06 Apr '05

Kees Cook wrote: > ChangeLog: > Black-box implementation of CryptProtectData/CryptUnprotectData. > > Here is an updated patch with various recommendations implemented. Hi Kees, The new patch looks good. I should have mentioned before that writing a test case will help your patch be accepted. Did you have any test code about that you could turn into a test case for your newly implemented functions? thanks, Mike

4 5

Notes on adding a test
by Dan Kegel 06 Apr '05

06 Apr '05

Thomas Kho mentioned that http://www.geekymedia.com/twiki/bin/view.cgi/WineDev/AddingMakefile was helpful to him. Since the webmaster there says he's taking down that wiki soon, here's a copy for posterity. -- snip -- Topic: AddingMakefile (as part of a new Wine test) Follow the example of the lzexpand test patch: http://www.winehq.com/hypermail/wine-patches/2004/11/0182.html Basic steps. (you'll have to chmod mod most of the files to 644 before you can edit them) 1. In your tests directory, look over wine/dlls/lzexpand/Makefile.in and wine/dlls/lzexpand/tests/Makefile.in 2. Now look at the Makefile.in in your dll directory. Copy it into your tests dir and change the list of .c files to your test .c file 3. Edit the Makefile.in file in your dll directory to add a subdirs line (see lzexpand/Makefile.in for an example) 4. In your wine directory, chmod 644 configure.ac 5. Edit configure.ac, find your dll directory in the AC_CONFIG_FILES and then add the path to your tests directory after it. 6. In your wine directory, run autoconf. Make sure you have 2.53 installed (autoconf --version). 7. Run configure. Your Makefile should be listed at the end now. -- snip -- -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

Re: [MSVCRT] implement _mbsbtype
by Juan Lang 06 Apr '05

06 Apr '05

Raphael wrote: > + if (!*str) { /** TODO: check *str validity */ > + return -1; /** _MBC_ILLEGAL */ > + } > + if (start == str && MSVCRT_isleadbyte(*str)) { > + return 1; /** _MBC_LEAD */ > + } > + if (start == str && MSVCRT_isleadbyte(str[-1])) { > + return 2; /**_MBC_TRAIL */ > + } > + > + return 0; /** _MBC_SINGLE */ Cool. How about patching mbctype.h with these constants too? --Juan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

3 4

Re: Remove reference to nonexistant strmif.h
by Kees Cook 05 Apr '05

05 Apr '05

On Mon, Apr 04, 2005 at 10:24:53PM -0400, Dimitrie O. Paun wrote: > ChangeLog > Remove reference to nonexistant strmif.h > +++ include/Makefile.in 5 Apr 2005 02:23:26 -0000 > - strmif.h \ /src/wine-cvs/include$ ls strmif.h strmif.h ? it's there for me. :) -- Kees Cook @outflux.net

2 1

Press: medical records software works with Wine
by Brian Vincent 05 Apr '05

05 Apr '05

Here's an interesting story about some medical software that works with Wine and CrossOver Office: http://www.linuxmednews.com/linuxmednews/1112336432/index_html quote: "He finally succeeded in running the CPRS client on Linux with only a few problems. Previous releases of WINE could not run the client at all, but last fall things started to improve when William Wong, a colleague from Malaysia's PCDOM organization, was able to launch CPRS for the first time using WINE. According to Joseph Dal Molin: 'Something changed under the covers of WINE that made it possible. A few releases ago, this did not work. Now it does.' scary statistic: " As many as 98,000 people die each year as a result of preventable medical errors" -Brian

1 0

Wayne and twin
by Brouard Nicolas 05 Apr '05

05 Apr '05

Hi, I haven't seen recent information on wine and twain. I already sent a similar mail to wine-users and, in a second step to wine-devel, but without any information back until now. May be the trick "Wine and twain" to "Wayne and twin" will give me more chance to be listen. Or may be my question is really stupid? >From a recent mail that I got, the problem is of interest for at least another people too. To be honest, she was at an earlier stage of installing Fine Reader and nothing came up for her wine installation. My problem is accessing the scanner from Fine Reader. I am not a specialist of Wine and simply use Winetools basic installation to install my fake drive, and then use standard wine to install all my Windows programs, including Noteworthy Composer recently (with timidity as midi synthesiser as reported on apps-db) and Fine Reader. Here is the question: I am trying to test a Finereader Office (version 5) with an USB scanner. Everything seems working. But I get scanner not ready when searching for scanner. Sane, gimp or whatever program using sane are working well with my scanner. Doing WINEDEBUG=+loaddll wine finereader.exe I get: ... trace:loaddll:load_dll Loaded module L"C:\\program files\\abbyy finereader 5.0 office\\scan\\scanman0.dll" : native trace:loaddll:load_dll Loaded module L"c:\\windows\\system\ \msvcrt.dll" : builtin trace:loaddll:MODULE_FlushModrefs Unloaded module L"c:\\windows\\system\ \msvcrt.dll" : builtin err:module:load_builtin_dll loaded .so for L"Twain.dll" but got L"twain_32.dll" instead - probably 16-bit dll trace:loaddll:MODULE_LoadModule16 Loaded module "c:\\windows\ \Twain.dll" : builtin Scanning driver not ready. But the scanner is ready: # sane-find-scanner -v searching for USB scanners: checking /dev/usb/scanner... failed to open (Invalid argument) checking /dev/usb/scanner0... failed to open (Invalid argument) ... checking /dev/usbscanner15... failed to open (Invalid argument) found USB scanner (vendor=0x03f0 [hp], product=0xb402 [photosmart 7700 series]) at libusb:002:002 found USB scanner (vendor=0x04b8 [EPSON], product=0x010f [EPSON Scanner 010F], chip=LM9832/3) at libusb:001:003 # scanimage -L device `plustek:libusb:001:003' is a Epson Perfection 1250/Photo USB flatbed scanner device `net:localhost:plustek:libusb:001:003' is a Epson Perfection 1250/Photo USB flatbed scanner Thus the device is something like "plustek:libusb:001:003" and # scanimage -d plustek:libusb:001:003 >foo.pnm works. Is there any wine test (windows exe) in order to test twain? What can I do to go further Regards, Nicolas -- Brouard Nicolas <nicolas.brouard(a)libertysurf.fr>

2 2

Re: comctl32: tab unicodification
by Dmitry Timoshkov 05 Apr '05

05 Apr '05

"Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > infoPtr = (TAB_INFO *)Alloc (sizeof(TAB_INFO)); > > - SetWindowLongA(hwnd, 0, (DWORD)infoPtr); > + SetWindowLongPtrW(hwnd, 0, (DWORD_PTR)infoPtr); If you change it here ... > @@ -2975,7 +2952,7 @@ > KillTimer(infoPtr->hwnd, TAB_HOTTRACK_TIMER); > > Free (infoPtr); > - SetWindowLongA(infoPtr->hwnd, 0, 0); > + SetWindowLongW(infoPtr->hwnd, 0, 0); ... it would be better to change it here to SetWindowLongPtrW as well. I think that moving Free (infoPtr); below of SetWindowLong would be appropriate as well. Dimi please add -p to your default diff flags, it makes the diffs much more readable. -- Dmitry.

2 1

redirecting text to standard out
by Raphael Clifford 05 Apr '05

05 Apr '05

Hi, I am running a windows app under wine that prints text to the screen. This can be copied and pasted into wine's notepad. Is there any way to get wine to simply output all text written by the app to standard out? This would save me a lot of hassle :) I don't mind if it outputs far too much (text from buttons etc) as I am planning on filtering the information in any case. It has been suggested to me to edit TextOut (or ExtTextOut) in dlls/gdi somewhere and simply add a printf. I had a look but this is the first time I have ever looked at wine source and I am completely baffled. Any help is very much appreciated. Cheers, Raphael

4 5

Should all A functions forward to their respective W's?
by James Hawkins 05 Apr '05

05 Apr '05

Hi, In the current state of wine, we have several A/W functions. Sometimes both the A and W functions are separately implemented with an ansi and unicode implementation respectively. Other A/W functions have the A forward to the W, converting the ansi to unicode. For all the functions that can, should we forward all A to their W counterparts? When it comes to the conformance test suite, this would be ideal. Only the A functions would have to be tested and in doing so, we test the A/W conversion and the functionality of the W functions (we're striving for all-unicode internally anyway). This would reduce the number of bugs, and the time it takes to fix current bugs. When both A and W are implemented and we find a bug in one of them, we have to remember to fix the same bug in the other function. For most of the functions, converting ansi to unicode is boilerplate code. This process could even be a janitorial project. What do you think? -- James Hawkins

3 3

PGP signing party
by Shachar Shemesh 05 Apr '05

05 Apr '05

Last year's raving success (I exchanged keys with Marcus) gives appetite for more. So, if you always wanted to have a PGP key that most of the free software will know [1]. If you wanted to be able to carry out encrypted secure conversations online. Or if you just want a chance to brag about what well connected key you have [2]. We will (try) to hold a PGP key signing party at wineconf this year. In order to participate, it is positively absolutely necessary that you: 1. Have a PGP key. You can generate one for yourself using gpg. 2. Send the PGP key finger print to me AT LEAST A WEEK BEFORE THE CONFERENCE. Any later then that, and it is not certain that we'll manage to get your key on the printed piece of paper that is necessary for carrying out the party. 3. Bring a copy you can trust to wineconf, to make sure other people are really signing your key (i.e. - that I'm not pulling anybody's leg). 4. Bring an identifying ID to wineconf. Two is preferable. Passport or a driver license in a language people can read. If you can only bring one, a passport is definitely preferable. The full details of what a key signing party is, why are the procedures as they are, and what's so important about *not* signing the keys with your laptop at the party can be found at http://www.cryptnet.net/fdp/crypto/gpg-party.html Note: No aliases on PGP keys. If your PGP key says "lord master of compiler optimization", then your passport had better say the same or no one will be able to sign your key. Shachar [1] My key is signed by RMS himself (http://pgp.mit.edu:11371/pks/lookup?op=vindex&search=0xCDBDBCE2). This means that any key that I sign is just two keys away from the very inventor of free software. [2] See [1] -- Shachar Shemesh Lingnu Open Source Consulting ltd. Have you backed up today's work? http://www.lingnu.com/backup.html

1 1

Re: KERNEL: Implement undocumented SetCPGlobal API call
by Dmitry Timoshkov 05 Apr '05

05 Apr '05

"Troy Rollo" <wine(a)troy.rollo.name> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) What app does depend on it? -- Dmitry.

3 5

Re: Wine device drivers proposal
by Damjan Jovanovic 05 Apr '05

05 Apr '05

--- Mike McCormack <mike(a)codeweavers.com> wrote: > > Damjan Jovanovic wrote: > > > I've been trying to add STI (still image) support > to > > Wine, and I've made some progress. However, I see > a > > deep and unsurmountable need to add (at least > > user-space) device drivers to Wine, and I would > like > > some feedback on these ideas. > > Drivers belong in the kernel. If there's no Linux > driver for a device, > then Wine cannot support it. In that case, the > first step is to write a > Linux device driver for it, which has the added > advantage that other > native linux applications can use the hardware. > > The interface from user space to kernel space should > be done via > standard Linux mechanisms, such as ioctl. The > Video4Linux API already > offers such an interface. > > You can't load a Windows driver that accesses > hardware in Wine, as Wine > is a user-space application with no I/O privileges. I am not trying to _load_ a Windows driver (that either requires kernel support for the Windows DDK, like ndiswrapper has, or emulation of an entire x86, like bochs does). What I am trying to do is _replace_ a Windows driver with equivalent libusb functionality, getting, in effect, something like this: Application (eg. the Gimp) | v special SANE backend | v SANE to TWAIN converter | v Windows user-space TWAIN driver (by manufacturer) | v STI | v Wine (with "drivers") | v Wine (user-space) driver | v libusb | v kernel > Mike Damjan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

5 6

Re: Fix GDI_PAL_COLORS crash.
by Dmitry Timoshkov 04 Apr '05

04 Apr '05

"Glenn Wurster" <gwurster(a)scs.carleton.ca> wrote: > GDI_PAL_COLORS is composed of 16 bit indexes, we only got the first > 256 colours. Instead of making a copy of possibly 65535 different > palette entries in the logical palette, get a pointer and build up the > dib colours as needed. Yes, the % is how windows works. Yes, > conformance tests are in the queue of patches to be submitted. GDI_GetObjPtr/GDI_ReleaseObj are the DLL separation hacks and will be removed eventually from GDI32 exports. You need to make a copy of all palette entries anyway. Perhaps the following code is a better solution: colors = GetPaletteEntries(hpal, 0, 0, NULL); pal_ents = HeapAlloc(GetProcessHeap(), 0, colors * sizeof(*pal_ents)); colors = GetPaletteEntries(hpal, 0, colors, pal_ents); for(i = 0; i < colors; i++, index++) { ... } HeapFree(GetProcessHeap(), 0, pal_ents); -- Dmitry.

1 0

registry: order of insertion of values
by James Hawkins 04 Apr '05

04 Apr '05

Hi, I've been fixing tests that fail on all of Win9x/XP/2003, and I've found a difference between the way we insert new values. What happens in advapi32/tests/registry.c - test_enum_value is that we already have 3 values created under the key Wine\\Test before the test starts. Then we make four calls to RegSetValueExA with 'Test' as the name of the value to set. Since this value does not exist, it is created. After these four calls, here are all the values under the test key: Environment Variables: %LONGSYSTEMVAR% = "bar" %FOO% = "ImARatherLongButIndeedNeededString" value: Test type: REG_SZ data: foobar data_count: 7, strlen("foobar") + 1 value: Test1 type: REG_EXPAND_SZ data: %LONGSYSTEMVAR%\subdir1 data_count: 24, same as above value: Test2 type: REG_SZ data: %LONGSYSTEMVAR%\subdir1 data_count: 24 value: Test3 type: REG_EXPAND_SZ data: %FOO%\subdir1 data_count: 14 We then go on to query RegEnumValueA with value index 0. In wine the key that is queried is Test because we insert new keys in alphabetical order and Test is before Test1..3. On all versions of windows, querying value index 0 returns information for Test1. I added another RegEnumValueA with value index 3 and it turns out that this is the index for Test, leading me to believe that windows just inserts the keys in order of creation. It says on msdn that "because values are not ordered, any new value will have an arbitrary index", but should we also store new values in creation order? If you remove the initial RegSetValueEx calls creating the 'Test' value and match the results of wine with those from windows, all the tests pass of wine and windows. I will be sending a patch to remove these RegSetValueEx tests, because they really should be in their own test (as seen by this bug), but it did give me the chance to raise the question of whether we should store new values in creation order or not. What's the verdict? -- James Hawkins

2 5

[riched20/list.c] Exception in ME_DumpDocument
by Paul Vriens 04 Apr '05

04 Apr '05

Hi, After I found that one of the files still contained a debugchannel for riched20 (instead of richedit), I added both to see a trace (just for the fun of it). This however raised an exception in ME_DumpDocument: trace:riched20:ME_DumpDocument Start Paragraph(ofs=0) - StartRow - A-LOT-OF-TEXT Paragraph(ofs=266) - StartRow - A-LOT-OF-TEXT Paragraph(ofs=316) - StartRow - Run("L"\00b6"", 0) wine_dbg_vprintf: debugstr buffer overflow (contents: 'A-LOT-OF-TEXT') First chance exception: assertion failed in 32-bit code (0x001117a2). backtrace: Wine-dbg>bt Backtrace: =>1 0x001117a2 (0x00809b30) 2 0x0027d882 (0x00809c5c) 3 0x00157023 NTDLL_dbg_vprintf(format=0x112f5c48, args=0x809cd8) [/data/install/linux/wine-src/wine/dlls/ntdll/debugtools.c:267] in ntdll (0x00809c84) 4 0x001570c8 NTDLL_dbg_vlog+0x44(cls=0x3, channel=0x112ff48c, function=0x112f5c38, format=0x112f5c48, args=0x809cd8) [/data/install/linux/wine-src/wine/dlls/ntdll/debugtools.c:303] in ntdll (0x00809ca0) 5 0x0023f880 wine_dbg_log+0x28(cls=0x3, channel=0x112ff48c, func=0x112f5c38, format=0x112f5c48) [/data/install/linux/wine-src/wine/libs/wine/debug.c:234] in libwine.so.1 (0x00809cc0) 6 0x112ebca6 ME_DumpDocument(buffer=0x7f370510) [list.c:174] in riched20 (0x00809ce8) Questions: - Could the exception be because of the length of the TRACE string? - Is there a particular reason for the 'different' debugchannel? - Is ME_DumpDocument used just for debugging? The first line says: /* FIXME this is useless, */ Cheers, Paul.

2 2

Hints needed for riched20/scroll bug solving
by Paul Vriens 04 Apr '05

04 Apr '05

Hi, When starting the Zoo Tycoon 1 demo for the first time, the license agreement appears. I know that nobody reads this ;-) but hey. When I click in the scrollbar (page down) the page goes down 1 page and the scrollbar changes. When I however click the down-arrow in the scrollbar, the page goes down (2 lines) but the scrollbar doesn't change. Who/what is responsible for this scrollbar? I've tried (extra) tracing for riched20 and scroll but nothing so far. Cheers, Paul.

2 2

Re: black-box implementation of CryptProtectData/CryptUnprotectData
by Mike McCormack 04 Apr '05

04 Apr '05

Kees Cook wrote: > This patch implements a functional replacement for crypt32.dll's > CryptProtectData and CryptUnprotectData. It does _not_ perform any > encrypt/decryption, but rather tracks the cipher/entropy/plain triplets > so that programs depending on the calls will operate correctly. Perhaps you could make it work "right" by using a key stored in ssh-agent? > diff -u -p -u -p -r1.92 ChangeLog Just writing a ChangeLog entry like this is OK: ChangeLog: * Added black-box implementation of CryptProtectData/CryptUnprotectData. You don't need to try patch ChangeLog, because it's going to change alot as patches are applied. Just write the message you want to put in there. > + hr = HRESULT_FROM_WIN32(RegOpenKeyExW(HKEY_CURRENT_USER, wszProtectDataMap, 0, KEY_READ, &hkeyMap)); > + if (!SUCCEEDED(hr)) Why do you convert the error code to a HRESULT here? Since you don't do it elsewhere in your code, why not compare the returned value to ERROR_SUCCESS, like you do below? > + if (RegEnumKeyExW(hkeyMap, dwIndex, wszIndexKey, &dwIndexKeyLength, NULL, NULL, NULL, NULL) != ERROR_SUCCESS) > + break; Personally, I prefer the following, as it makes the lines shorter, makes it easier to add a printf("%ld\n",r); and makes the comparison more obvious. r = RegEnumKeyExW(hkeyMap, ... if( r != ERROR_SUCCES ) break; > + if (WINE_TRACE_ON(crypt)) > + wine_dbg_printf("\tChecking Map Index %s\n", debugstr_w(wszIndexKey)); You don't need the WINE_TRACE_ON() check, because TRACE already does that for the default debug channel, so the following is the same: TRACE("\tChecking Map Index %s\n", debugstr_w(wszIndexKey); > + if (!bFound) { > + TRACE("no matches\n"); > + } Sometimes you used K&R style brackets and indenting, sometimes you used ANSI C style. It's better to choose one or the other and stick to it. > + return SUCCEEDED(RegSetValueExW(hkeyOpen,wszName,0,dwType, > + pData.pbData,pData.cbData)); The SUCCEEDED() macro is only for HRESULT values, so the above is going to succeed in alot of cases where it shouldn't. > + } > + > + DWORD dwDisposition; In an effort to maintain portability, we don't use C99 style variable declarations. Mike

3 5

WineConf Agenda
by Brian Vincent 04 Apr '05

04 Apr '05

I'm going to start this off with a huge apology - there's a very real chance I've asked someone to do a presentation and it's not on this list. If so, you need to email me to remind me. If you were definitely planning on presenting something because I emailed you, let me know - there's lots of space available. I know this only affects 2 or 3 people, but I tossed around a few ideas and didn't want to leave any loose ends. (Any of those items would make nice topics.) This is the initial agenda for WineConf. I hope to add a few more items, but Jeremy suggested I pull the trigger and announce it. I agree - there's enough here to fill two days and leave a lot of time for people to get together in small groups. Only the first two items are in any formal order: Alexandre - Keynote (He said he's reusing last year's slides.) Dimi - to do list / status update Steven Edwards and the ReactOS crew Charles W Stevenson - Winelib / Winelib porting / and a commercial perspective Andrew Barlett / Samba team? - Samba 4, authentication, lots of intelligent ideas Juan Lang - Wine's RPC + Samba or something like that :) Jeremy White - CXTest Jason Edmeades - DirectX 9 / wined3d / eye candy I think a full agenda would be about 11 items. If you would like to present something let me know - there's definitely space available. If you've been wondering, "There's a neat project I'd like to do if I could only get a few more people interested", well, this is the perfect time to bring it up. If there's something strategic to Wine development, this is a great time to discuss it. For example, we've had mixed feelings regarding revision control and its been suggested to bring it up as a topic. Would anyone find it useful to discuss subversion vs. arch vs. cvs? We could probably get Mike Hearn to show off how he manages patches with SVK and then let him arm wrestle Alexandre about whether arch is better. Friday night we will have an informal dinner after meeting up at the hotel. The conference will kick off Saturday morning on campus around 8am. Lunch will be provided on Saturday and Sunday as well as dinner on Saturday. There will definitely be a lot of time for informal discussion. For the Samba guys - I think there's a great opportunity to share some knowledge to prevent anyone from reinventing the wheel. If there's any topic you'd find interesting, let me know. If you'd just like to hear a specific topic from the Wine folks, we can arrange that. For travel arrangements, please join wineconf(a)winehq.org ( http://www.winehq.org/mailman/listinfo/wineconf ) For instance, I'm actually flying into Frankfurt on April 23rd and it'd be cool to hang out with anyone arriving early. If you haven't made reservations at a hotel, don't worry too much. There's still rooms available as Mr. Schmid described here: http://www.winehq.com/hypermail/wine-devel/2005/03/1119.html If you haven't signed up on the RSVP list, please do so. It can be found on the WineConf page: http://www.winehq.com/site/wineconf Lastly, if you have any questions / comments / criticisms let me know. -Brian PS. Dimi owes me a beer from last year, so we're all obligated to go out Friday night. I'm looking forward to seeing everyone in Stuttgart!

8 15

Re: [SERVER] fix potential leak on window.c (bug2849)
by Dimitrie O. Paun 04 Apr '05

04 Apr '05

On Mon, Apr 04, 2005 at 09:38:40AM +0200, Raphael wrote: > Hi, > > changelog: > - fix potential leak on window.c as seen in bug2849 + { + free_region( tmp ); + goto error; + } Can you please use 4-spaces indentation, like the rest of the file? -- Dimi.

1 0

Re: Wine device drivers proposal
by Damjan Jovanovic 04 Apr '05

04 Apr '05

--- Kuba Ober <kuba(a)mareimbrium.org> wrote: > > > I've been trying to add STI (still image) > support to > > > Wine, and I've made some progress. However, I > see a > > > deep and unsurmountable need to add (at least > > > user-space) device drivers to Wine, and I would > like > > > some feedback on these ideas. > > > > Drivers belong in the kernel. > > Not necessarily. In fact, only the part that > directly touches the hardware > really belongs there. There's nothing wrong with > doing rest of the processing > (i.e. the non time-critical parts) in the userspace. > In fact, that likely > makes the kernel a safer place. > > > If there's no Linux driver for a device, > > then Wine cannot support it. > > That would be stupid. > > > In that case, the first step is to write a > > Linux device driver for it, which has the added > advantage that other > > native linux applications can use the hardware. > > Huh? What about sane? It can e.g. use libusb quite > nicely and *portably* to > say access usb scanners. I.e. it flies on both > windows *and* linux. > > > You can't load a Windows driver that accesses > hardware in Wine, as Wine > > is a user-space application with no I/O > privileges. > > You could, with help of a special kernel driver to > forward the requests > between hardware and userspace. libusb and usbfs do > that already for usb, > i.e. at the current point in time wine can be able > to natively support any > usb device minidriver that doesn't use a class > driver. Class drivers can be > easily developed by snatching code from linux > kernel, as long as licenses are > fine of course. All that without touching the kernel > in any way. And I mean > here full support for *any* usb device, rain or > shine. Network adapters > (visible in wine only, but so what?), scanners, > cheap webcams whose > manufacturers don't care enough to release the > specs, and the list goes on. > > Cheers, Kuba > I agree, Kuba. Which of the approaches I suggested (or any new ones) do you propose? Bye Damjan __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

Wine device drivers proposal
by Damjan Jovanovic 04 Apr '05

04 Apr '05

Hi I've been trying to add STI (still image) support to Wine, and I've made some progress. However, I see a deep and unsurmountable need to add (at least user-space) device drivers to Wine, and I would like some feedback on these ideas. Basically, many Windows device drivers are really trivial, but required for many apps. A scanner driver typically just accepts commands from a user-space app, does minimal processing, and forwards that to Windows. I've already hacked up Wine to get the same functionality, and it works - partially. I propose adding a driver loading system to Wine that works as follows: -CreateFile() gets a device filename, like (in my case) \\.\MiiScan0 -Currently, Wine's behaviour for such a filename is to try load a VXD. -In the case of VXD loading failure, a search is performed in (Wine's) C:\Windows\System32\Drivers (or somewhere else?) for a matching driver. The driver is then loaded and used for (at least): ReadFile() WriteFile() DeviceIoControl() CloseHandle() The problem is, how is a handle mapped to the appropriate driver? I've thought about it, and come up with 3 solutions. The first 3 don't require changes to the wineserver but aren't pretty. 1. Make the driver a true Linux kernel mode driver, and the handle its device file handle. Since ReadFile() and WriteFile() just do read() and write() system calls, this can be done. The problem is, DeviceIoControl() has to be implemented using ioctl(), and that's dangerous (sending the right codes to the wrong device can be catastrophic). Also, it's not portable to other OS's, and requires writing a kernel module (which isn't fun). 2. The driver is a file giving a process to start and some IPC method to use. Wine starts the process and uses the IPC method to communicate with the driver. This is good as far as Wine's current ReadFile() and WriteFile() go, since they don't have to know they're not writing to an actual file. The problem here is, which IPC method supports both read() and write() on the same file descriptor, preserves message boundaries, and carries out-of-band data for DeviceIoControl()? I was thinking TCP sockets, but they don't preserve message boundaries. 3. KERNEL32.DLL and / or NTDLL.DLL keep their own handle table so they know which handles are driver handles and deal with those appropriately. Having to look up these tables for every call to ReadFile(), WriteFile() and DeviceIoControl() might be very inefficient, though. 4. Use an in-process solution, like a winelib DLL that has exports for dealing with ReadFile(), WriteFile() and DeviceIoControl(). This could be the most efficient, but then again, you need an efficient way to test a handle for being a driver handle, find the appropriate driver, and call the right exported function, which likely means the wineserver needs to have knowledge of these drivers and provide functionality for testing a handle for being a driver handle and have a way to find the driver. Let me know what you think. Bye Damjan __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

6 6

Re: black-box implementation of CryptProtectData/CryptUnprotectData
by James Hawkins 04 Apr '05

04 Apr '05

On Apr 3, 2005 10:12 PM, Kees Cook <kees(a)outflux.net> wrote: > To store the triplets, these functions use the registry: > > Registry Layout: > HKEY_CURRENT_USER\Software\Wine\Crypt\ProtectData\Map\[index] > Cipher: HEX string > Entropy: HEX string > DataDescription: WCHAR > Plain: HEX string > I'll have to be honest that I haven't looked over the code yet, but I do have a concern. Do these values have to be stored under Software\Wine? That location is for wine-specific configuration options and not api use, unless I'm mistaken. Do we know if this data is stored in the registry in windows, and if so where is it stored? (because I know it's not Software\Wine ;-) -- James Hawkins

2 4

Re: WineConf Agenda
by Steven Edwards 04 Apr '05

04 Apr '05

--- Andrew Tridgell <tridge(a)osdl.org> wrote: > Finally, if we have time, I'd like to discuss cooperation on IDL files > and MSRPC interfaces. Yes I would like to discuss this as well. Eirc Kohl has made quite a lot of changes to WIDL for ReactOS to support our MSRPC and PLug and Pray implementation and I would like to see these changes merged back in for Wine and Samba so we can adopt a common IDL compiler. Thanks Steven __________________________________ Yahoo! Messenger Show us what our next emoticon should look like. Join the fun. http://www.advision.webevents.yahoo.com/emoticontest

2 2

Re: dsound: fix test to compile on vs
by Dimitrie O. Paun 03 Apr '05

03 Apr '05

On Sun, Apr 03, 2005 at 01:25:22PM -0500, James Hawkins wrote: > Changelog > * LPLPVOID is unknown to Visual Studio, use LPVOID * instead. If so, how come it's defined in our headers? We should remove the definition if it's not standard. -- Dimi.

2 1

Re: [WAVEMAP] waveOutGetPosition bug
by Robert Reif 03 Apr '05

03 Apr '05

Robert Reif wrote: > dlls/winmm/wavemap/wavemap.c > Correctly handle where waveOutGetPosition changes timepos.wType > because the requested type is not supported. > > dlls/winmm/tests/wave.c > Changed regression test to make sure position is correctly > checked when a different type is returned. > > > This revised patch adds the following: dlls/winmm/wavemap/wavemap.c Adds Jeremy White's waveOutGetPosition fix to waveInGetPosition. dlls/winmm/tests/capture.c Adds Jeremy White's WAVE_FORMAT_DIRECT/WAVE_MAPPER fix. Adds waveInGetPosition checks. Index: dlls/winmm/tests/capture.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/tests/capture.c,v retrieving revision 1.15 diff -u -p -r1.15 capture.c --- dlls/winmm/tests/capture.c 3 Nov 2004 22:13:44 -0000 1.15 +++ dlls/winmm/tests/capture.c 3 Apr 2005 17:30:59 -0000 @@ -50,6 +50,87 @@ static const char * wave_in_error(MMRESU return long_msg; } +static void check_position(int device, HWAVEIN win, DWORD bytes, + LPWAVEFORMATEX pwfx ) +{ + MMTIME mmtime; + DWORD samples; + double duration; + MMRESULT rc; + DWORD returned; + + samples=bytes/(pwfx->wBitsPerSample/8*pwfx->nChannels); + duration=((double)samples)/pwfx->nSamplesPerSec; + + mmtime.wType = TIME_BYTES; + rc=waveInGetPosition(win, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveInGetPosition(%s): rc=%s\n",dev_name(device),wave_in_error(rc)); + if (mmtime.wType != TIME_BYTES && winetest_debug > 1) + trace("waveInGetPosition(%s): TIME_BYTES not supported, returned %s\n", + dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveInGetPosition(%s): returned %ld bytes, " + "should be %ld\n", dev_name(device), returned, bytes); + + mmtime.wType = TIME_SAMPLES; + rc=waveInGetPosition(win, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveInGetPosition(%s): rc=%s\n",dev_name(device),wave_in_error(rc)); + if (mmtime.wType != TIME_SAMPLES && winetest_debug > 1) + trace("waveInGetPosition(%s): TIME_SAMPLES not supported, " + "returned %s\n",dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveInGetPosition(%s): returned %ld samples, " + "should be %ld\n", dev_name(device), bytes_to_samples(returned, pwfx), + bytes_to_samples(bytes, pwfx)); + + mmtime.wType = TIME_MS; + rc=waveInGetPosition(win, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveInGetPosition(%s): rc=%s\n",dev_name(device),wave_in_error(rc)); + if (mmtime.wType != TIME_MS && winetest_debug > 1) + trace("waveInGetPosition(%s): TIME_MS not supported, returned %s\n", + dev_name(device), wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveInGetPosition(%s): returned %ld ms, " + "should be %ld\n", dev_name(device), bytes_to_ms(returned, pwfx), + bytes_to_ms(bytes, pwfx)); + + mmtime.wType = TIME_SMPTE; + rc=waveInGetPosition(win, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveInGetPosition(%s): rc=%s\n",dev_name(device),wave_in_error(rc)); + if (mmtime.wType != TIME_SMPTE && winetest_debug > 1) + trace("waveInGetPosition(%s): TIME_SMPTE not supported, returned %s\n", + dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveInGetPosition(%s): SMPTE test failed\n", + dev_name(device)); + + mmtime.wType = TIME_MIDI; + rc=waveInGetPosition(win, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveInGetPosition(%s): rc=%s\n",dev_name(device),wave_in_error(rc)); + if (mmtime.wType != TIME_MIDI && winetest_debug > 1) + trace("waveInGetPosition(%s): TIME_MIDI not supported, returned %s\n", + dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveInGetPosition(%s): MIDI test failed\n", + dev_name(device)); + + mmtime.wType = TIME_TICKS; + rc=waveInGetPosition(win, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveInGetPosition(%s): rc=%s\n",dev_name(device),wave_in_error(rc)); + if (mmtime.wType != TIME_TICKS && winetest_debug > 1) + trace("waveInGetPosition(%s): TIME_TICKS not supported, returned %s\n", + dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveInGetPosition(%s): TICKS test failed\n", + dev_name(device)); +} + static void wave_in_test_deviceIn(int device, LPWAVEFORMATEX pwfx, DWORD format, DWORD flags, LPWAVEINCAPS pcaps) { HWAVEIN win; @@ -107,6 +188,9 @@ static void wave_in_test_deviceIn(int de pwfx->nSamplesPerSec, pwfx->wBitsPerSample, pwfx->nChannels, nSamplesPerSec, wBitsPerSample, nChannels); + /* Check that the position is 0 at start */ + check_position(device, win, 0, pwfx); + frag.lpData=malloc(pwfx->nAvgBytesPerSec); frag.dwBufferLength=pwfx->nAvgBytesPerSec; frag.dwBytesRecorded=0; @@ -131,6 +215,9 @@ static void wave_in_test_deviceIn(int de ok(rc==MMSYSERR_NOERROR,"waveInAddBuffer(%s): rc=%s\n", dev_name(device),wave_in_error(rc)); + /* Check that the position is 0 at start */ + check_position(device, win, 0, pwfx); + rc=waveInStart(win); ok(rc==MMSYSERR_NOERROR,"waveInStart(%s): rc=%s\n", dev_name(device),wave_in_error(rc)); @@ -141,6 +228,7 @@ static void wave_in_test_deviceIn(int de ok(frag.dwBytesRecorded==pwfx->nAvgBytesPerSec, "frag.dwBytesRecorded=%ld, should=%ld\n", frag.dwBytesRecorded,pwfx->nAvgBytesPerSec); + /* stop playing on error */ if (res!=WAIT_OBJECT_0) { rc=waveInStop(win); @@ -316,11 +404,12 @@ static void wave_in_test_device(int devi format.nAvgBytesPerSec=format.nSamplesPerSec*format.nBlockAlign; format.cbSize=0; wave_in_test_deviceIn(device,&format,win_formats[f][0],0, &capsA); - wave_in_test_deviceIn(device,&format,win_formats[f][0], - WAVE_FORMAT_DIRECT, &capsA); - if (device != WAVE_MAPPER) + if (device != WAVE_MAPPER) { + wave_in_test_deviceIn(device,&format,win_formats[f][0], + WAVE_FORMAT_DIRECT, &capsA); wave_in_test_deviceIn(device,&format,win_formats[f][0], WAVE_MAPPED, &capsA); + } } /* Try a PCMWAVEFORMAT aligned next to an unaccessible page for bounds @@ -342,11 +431,12 @@ static void wave_in_test_device(int devi pwfx->nBlockAlign=pwfx->nChannels*pwfx->wBitsPerSample/8; pwfx->nAvgBytesPerSec=pwfx->nSamplesPerSec*pwfx->nBlockAlign; wave_in_test_deviceIn(device,pwfx,WAVE_FORMAT_2M08,0, &capsA); - wave_in_test_deviceIn(device,pwfx,WAVE_FORMAT_2M08, - WAVE_FORMAT_DIRECT, &capsA); - if (device != WAVE_MAPPER) + if (device != WAVE_MAPPER) { + wave_in_test_deviceIn(device,pwfx,WAVE_FORMAT_2M08, + WAVE_FORMAT_DIRECT, &capsA); wave_in_test_deviceIn(device,pwfx,WAVE_FORMAT_2M08, WAVE_MAPPED, &capsA); + } } VirtualFree(twoPages, 2 * dwPageSize, MEM_RELEASE); } Index: dlls/winmm/tests/wave.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/tests/wave.c,v retrieving revision 1.50 diff -u -p -r1.50 wave.c --- dlls/winmm/tests/wave.c 18 Mar 2005 10:25:48 -0000 1.50 +++ dlls/winmm/tests/wave.c 3 Apr 2005 17:31:00 -0000 @@ -303,7 +303,7 @@ static const char * wave_out_caps(DWORD #undef ADD_FLAG } -static const char * wave_time_format(UINT type) +const char * wave_time_format(UINT type) { static char msg[32]; #define TIME_FORMAT(f) case f: return #f @@ -373,6 +373,34 @@ const char * get_format_str(WORD format) return msg; } +DWORD bytes_to_samples(DWORD bytes, LPWAVEFORMATEX pwfx) +{ + return bytes / pwfx->nBlockAlign; +} + +DWORD bytes_to_ms(DWORD bytes, LPWAVEFORMATEX pwfx) +{ + return bytes_to_samples(bytes, pwfx) * 1000 / pwfx->nSamplesPerSec; +} + +DWORD time_to_bytes(LPMMTIME mmtime, LPWAVEFORMATEX pwfx) +{ + if (mmtime->wType == TIME_BYTES) + return mmtime->u.cb; + else if (mmtime->wType == TIME_SAMPLES) + return mmtime->u.sample * pwfx->nBlockAlign; + else if (mmtime->wType == TIME_MS) + return mmtime->u.ms * pwfx->nAvgBytesPerSec / 1000; + else if (mmtime->wType == TIME_SMPTE) + return ((mmtime->u.smpte.hour * 60.0 * 60.0) + + (mmtime->u.smpte.min * 60.0) + + (mmtime->u.smpte.sec) + + (mmtime->u.smpte.frame / 30.0)) * pwfx->nAvgBytesPerSec; + + trace("FIXME: time_to_bytes() type not supported\n"); + return -1; +} + static void check_position(int device, HWAVEOUT wout, DWORD bytes, LPWAVEFORMATEX pwfx ) { @@ -380,6 +408,7 @@ static void check_position(int device, H DWORD samples; double duration; MMRESULT rc; + DWORD returned; samples=bytes/(pwfx->wBitsPerSample/8*pwfx->nChannels); duration=((double)samples)/pwfx->nSamplesPerSec; @@ -388,60 +417,69 @@ static void check_position(int device, H rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); ok(rc==MMSYSERR_NOERROR, "waveOutGetPosition(%s): rc=%s\n",dev_name(device),wave_out_error(rc)); - if (mmtime.wType == TIME_BYTES) - ok(mmtime.u.cb==bytes, - "waveOutGetPosition(%s): returned %ld bytes, should be %ld\n", - dev_name(device),mmtime.u.cb, bytes); - else + if (mmtime.wType != TIME_BYTES && winetest_debug > 1) trace("waveOutGetPosition(%s): TIME_BYTES not supported, returned %s\n", dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveOutGetPosition(%s): returned %ld bytes, " + "should be %ld\n", dev_name(device), returned, bytes); mmtime.wType = TIME_SAMPLES; rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); ok(rc==MMSYSERR_NOERROR, "waveOutGetPosition(%s): rc=%s\n",dev_name(device),wave_out_error(rc)); - if (mmtime.wType == TIME_SAMPLES) - ok(mmtime.u.sample==samples, - "waveOutGetPosition(%s): returned %ld samples, should be %ld\n", - dev_name(device), mmtime.u.sample, samples); - else + if (mmtime.wType != TIME_SAMPLES && winetest_debug > 1) trace("waveOutGetPosition(%s): TIME_SAMPLES not supported, " "returned %s\n",dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveOutGetPosition(%s): returned %ld samples, " + "should be %ld\n", dev_name(device), bytes_to_samples(returned, pwfx), + bytes_to_samples(bytes, pwfx)); mmtime.wType = TIME_MS; rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); ok(rc==MMSYSERR_NOERROR, "waveOutGetPosition(%s): rc=%s\n",dev_name(device),wave_out_error(rc)); - if (mmtime.wType == TIME_MS) - ok(mmtime.u.ms==floor(duration*1000.0), - "waveOutGetPosition(%s): returned %ld ms, should be %ld\n", - dev_name(device), mmtime.u.ms, (long)floor(duration*1000.0)); - else + if (mmtime.wType != TIME_MS && winetest_debug > 1) trace("waveOutGetPosition(%s): TIME_MS not supported, returned %s\n", - dev_name(device),wave_time_format(mmtime.wType)); + dev_name(device), wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveOutGetPosition(%s): returned %ld ms, " + "should be %ld\n", dev_name(device), bytes_to_ms(returned, pwfx), + bytes_to_ms(bytes, pwfx)); mmtime.wType = TIME_SMPTE; rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); ok(rc==MMSYSERR_NOERROR, "waveOutGetPosition(%s): rc=%s\n",dev_name(device),wave_out_error(rc)); - if (mmtime.wType == TIME_SMPTE) - { - BYTE frames=(BYTE)ceil(fmod(duration*mmtime.u.smpte.fps, mmtime.u.smpte.fps)); - ok(mmtime.u.smpte.hour==(BYTE)(floor(duration/(60*60))) && - mmtime.u.smpte.min==(BYTE)(fmod(floor(duration/60), 60)) && - mmtime.u.smpte.sec==(BYTE)(fmod(duration,60)) && - mmtime.u.smpte.frame==frames, - "waveOutGetPosition(%s): returned %d:%d:%d %d, " - "should be %d:%d:%d %d\n", dev_name(device), mmtime.u.smpte.hour, - mmtime.u.smpte.min, mmtime.u.smpte.sec, mmtime.u.smpte.frame, - (BYTE)(floor(duration/(60*60))), - (BYTE)(fmod(floor(duration/60), 60)), - (BYTE)(fmod(duration,60)), - frames); - } - else + if (mmtime.wType != TIME_SMPTE && winetest_debug > 1) trace("waveOutGetPosition(%s): TIME_SMPTE not supported, returned %s\n", dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveOutGetPosition(%s): SMPTE test failed\n", + dev_name(device)); + + mmtime.wType = TIME_MIDI; + rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveOutGetPosition(%s): rc=%s\n",dev_name(device),wave_out_error(rc)); + if (mmtime.wType != TIME_MIDI && winetest_debug > 1) + trace("waveOutGetPosition(%s): TIME_MIDI not supported, returned %s\n", + dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveOutGetPosition(%s): MIDI test failed\n", + dev_name(device)); + + mmtime.wType = TIME_TICKS; + rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); + ok(rc==MMSYSERR_NOERROR, + "waveOutGetPosition(%s): rc=%s\n",dev_name(device),wave_out_error(rc)); + if (mmtime.wType != TIME_TICKS && winetest_debug > 1) + trace("waveOutGetPosition(%s): TIME_TICKS not supported, returned %s\n", + dev_name(device),wave_time_format(mmtime.wType)); + returned = time_to_bytes(&mmtime, pwfx); + ok(returned == bytes, "waveOutGetPosition(%s): TICKS test failed\n", + dev_name(device)); } static void wave_out_test_deviceOut(int device, double duration, @@ -1030,7 +1068,7 @@ static void wave_out_tests() "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " "expected, got %s\n",dev_name(WAVE_MAPPER),mmsys_error(rc)); else - ok(rc==MMSYSERR_BADDEVICEID || rc==MMSYSERR_NODRIVER || + ok(rc==MMSYSERR_BADDEVICEID || rc==MMSYSERR_NODRIVER || rc==MMSYSERR_NOTSUPPORTED, "waveOutGetDevCapsW(%s): MMSYSERR_BADDEVICEID or MMSYSERR_NODRIVER " " or MMSYSERR_NOTSUPPORTED expected, got %s\n", Index: dlls/winmm/tests/winmm_test.h =================================================================== RCS file: /home/wine/wine/dlls/winmm/tests/winmm_test.h,v retrieving revision 1.8 diff -u -p -r1.8 winmm_test.h --- dlls/winmm/tests/winmm_test.h 19 Aug 2004 01:13:58 -0000 1.8 +++ dlls/winmm/tests/winmm_test.h 3 Apr 2005 17:31:00 -0000 @@ -72,3 +72,7 @@ extern const char* wave_open_flags(DWORD extern const char* mmsys_error(MMRESULT); extern const char* wave_out_error(MMRESULT); extern const char* get_format_str(WORD format); +extern const char* wave_time_format(UINT type); +extern DWORD bytes_to_samples(DWORD bytes, LPWAVEFORMATEX pwfx); +extern DWORD bytes_to_ms(DWORD bytes, LPWAVEFORMATEX pwfx); +extern DWORD time_to_bytes(LPMMTIME mmtime, LPWAVEFORMATEX pwfx); Index: dlls/winmm/wavemap/wavemap.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/wavemap/wavemap.c,v retrieving revision 1.42 diff -u -p -r1.42 wavemap.c --- dlls/winmm/wavemap/wavemap.c 15 Mar 2005 15:39:18 -0000 1.42 +++ dlls/winmm/wavemap/wavemap.c 3 Apr 2005 17:31:01 -0000 @@ -428,9 +428,10 @@ static DWORD wodGetPosition(WAVEMAPDATA* if (lpTime->wType == TIME_MS) timepos.wType = TIME_BYTES; + /* This can change timepos.wType if the requested type is not supported */ val = waveOutGetPosition(wom->u.out.hInnerWave, &timepos, dwParam2); - if (lpTime->wType == TIME_BYTES || lpTime->wType == TIME_MS) + if (timepos.wType == TIME_BYTES) { DWORD dwInnerSamplesPerOuter = wom->nSamplesPerSecInner / wom->nSamplesPerSecOuter; if (dwInnerSamplesPerOuter > 0) @@ -464,10 +465,12 @@ static DWORD wodGetPosition(WAVEMAPDATA* /* Once we have the TIME_BYTES right, we can easily convert to TIME_MS */ if (lpTime->wType == TIME_MS) - lpTime->u.cb = MulDiv(lpTime->u.cb, 1000, wom->avgSpeedOuter); + lpTime->u.ms = MulDiv(lpTime->u.cb, 1000, wom->avgSpeedOuter); + else + lpTime->wType = TIME_BYTES; } - else if (lpTime->wType == TIME_SAMPLES) - lpTime->u.cb = MulDiv(timepos.u.cb, wom->nSamplesPerSecOuter, wom->nSamplesPerSecInner); + else if (lpTime->wType == TIME_SAMPLES && timepos.wType == TIME_SAMPLES) + lpTime->u.sample = MulDiv(timepos.u.sample, wom->nSamplesPerSecOuter, wom->nSamplesPerSecInner); else /* other time types don't require conversion */ lpTime->u = timepos.u; @@ -962,15 +965,62 @@ static DWORD widUnprepare(WAVEMAPDATA* w static DWORD widGetPosition(WAVEMAPDATA* wim, LPMMTIME lpTime, DWORD dwParam2) { DWORD val; - + MMTIME timepos; TRACE("(%p %p %08lx)\n", wim, lpTime, dwParam2); - val = waveInGetPosition(wim->u.in.hInnerWave, lpTime, dwParam2); - if (lpTime->wType == TIME_BYTES) - lpTime->u.cb = MulDiv(lpTime->u.cb, wim->avgSpeedOuter, wim->avgSpeedInner); - if (lpTime->wType == TIME_SAMPLES) - lpTime->u.cb = MulDiv(lpTime->u.cb, wim->nSamplesPerSecOuter, wim->nSamplesPerSecInner); - /* other time types don't require conversion */ + memcpy(&timepos, lpTime, sizeof(timepos)); + + /* For TIME_MS, we're going to recalculate using TIME_BYTES */ + if (lpTime->wType == TIME_MS) + timepos.wType = TIME_BYTES; + + /* This can change timepos.wType if the requested type is not supported */ + val = waveInGetPosition(wim->u.in.hInnerWave, &timepos, dwParam2); + + if (timepos.wType == TIME_BYTES) + { + DWORD dwInnerSamplesPerOuter = wim->nSamplesPerSecInner / wim->nSamplesPerSecOuter; + if (dwInnerSamplesPerOuter > 0) + { + DWORD dwInnerBytesPerSample = wim->avgSpeedInner / wim->nSamplesPerSecInner; + DWORD dwInnerBytesPerOuterSample = dwInnerBytesPerSample * dwInnerSamplesPerOuter; + DWORD remainder = 0; + + /* If we are up sampling (going from lower sample rate to higher), + ** we need to make a special accomodation for times when we've + ** written a partial output sample. This happens frequently + ** to us because we use msacm to do our up sampling, and it + ** will up sample on an unaligned basis. + ** For example, if you convert a 2 byte wide 8,000 'outer' + ** buffer to a 2 byte wide 48,000 inner device, you would + ** expect 2 bytes of input to produce 12 bytes of output. + ** Instead, msacm will produce 8 bytes of output. + ** But reporting our position as 1 byte of output is + ** nonsensical; the output buffer position needs to be + ** aligned on outer sample size, and aggressively rounded up. + */ + remainder = timepos.u.cb % dwInnerBytesPerOuterSample; + if (remainder > 0) + { + timepos.u.cb -= remainder; + timepos.u.cb += dwInnerBytesPerOuterSample; + } + } + + lpTime->u.cb = MulDiv(timepos.u.cb, wim->avgSpeedOuter, wim->avgSpeedInner); + + /* Once we have the TIME_BYTES right, we can easily convert to TIME_MS */ + if (lpTime->wType == TIME_MS) + lpTime->u.ms = MulDiv(lpTime->u.cb, 1000, wim->avgSpeedOuter); + else + lpTime->wType = TIME_BYTES; + } + else if (lpTime->wType == TIME_SAMPLES && timepos.wType == TIME_SAMPLES) + lpTime->u.sample = MulDiv(timepos.u.sample, wim->nSamplesPerSecOuter, wim->nSamplesPerSecInner); + else + /* other time types don't require conversion */ + lpTime->u = timepos.u; + return val; }

1 0

Riched20: thanks + regression "beta" not shown
by Tobias Burnus 03 Apr '05

03 Apr '05

Hello, first I'd really like to thank the riched20 workers, notably Krzysztof Foltman and Phil Krylov. For the application Diamond it made a big difference: Instead of "[[Aring]]" etc. one sees the proper symbol and it looks much nicer. But the biggest advantage is that one can now copy or save the text; before the app was simply crashing when attempting to do so. Regression: One of the later riched20 patches, possibly http://cvs.winehq.org/patch.py?id=16672, caused a regression with the richedit control in Diamond. Before it showed a beta character from the Symbol font, now it only shows a box ("[]"). If one saves the output (rtf export) one sees ------------------- {\rtf1\ansi\ansicpg1252\uc1\deff0\deflang1031\deflangfe1031{\fonttbl{\f0 Times New Roman;} {\f1\fcharset0 System;} {\f2\fcharset2 Symbol;} }{\*\generator Wine Riched20 2.0.????;}\pard\li0\fi0\ri0{\b\fs18\ul Bibliographic data} \par\pard\li0\fi0\ri0 [...] \par\pard\li0\fi0\ri0{\fs18 }{\i\fs18 b}{\fs18 = 5.8312(2) \'c5} \par\pard\li0\fi0\ri0{\fs18 }{\i\fs18 c}{\fs18 = 7.9564(2) \'c5} \par\pard\li0\fi0\ri0{\fs18 }{\fs18\f2 \u61538?}{\fs18 = 100.77(0) \u176?} ------------------- In the last line, after the \f2 (Symbol font), there should be a beta ("b" + Symbol font). Trace (starting from the "b = 5.8312(2)"): ------------ trace:richedit:ME_CheckCharOffsets run, real ofs = 1 (+ofsp = 177), counted = 177, len = 1, txt = "L"b"", flags=00000000, fx&mask = 44000002 trace:richedit:ME_CheckCharOffsets run, real ofs = 2 (+ofsp = 178), counted = 178, len = 14, txt = "L" = 5.8312(2) \00c5"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 16 (+ofsp = 192), counted = 192, len = 1, txt = "L"\00b6"", flags=00100000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets para, real ofsp = 193, counted = 193 trace:richedit:ME_CheckCharOffsets run, real ofs = 0 (+ofsp = 193), counted = 193, len = 1, txt = "L"\t"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 1 (+ofsp = 194), counted = 194, len = 1, txt = "L"c"", flags=00000000, fx&mask = 44000002 trace:richedit:ME_CheckCharOffsets run, real ofs = 2 (+ofsp = 195), counted = 195, len = 14, txt = "L" = 7.9564(2) \00c5"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 16 (+ofsp = 209), counted = 209, len = 1, txt = "L"\00b6"", flags=00100000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets para, real ofsp = 210, counted = 210 trace:richedit:ME_CheckCharOffsets run, real ofs = 0 (+ofsp = 210), counted = 210, len = 1, txt = "L"\t"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 1 (+ofsp = 211), counted = 211, len = 1, txt = "L"\f062"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 2 (+ofsp = 212), counted = 212, len = 14, txt = "L" = 100.77(0) \00b0"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 16 (+ofsp = 226), counted = 226, len = 1, txt = "L"\00b6"", flags=00100000, fx&mask = 44000000 ------------ * * * * One feature request: Currently, tabs are shown as box ("[]"), how about replacing them with a simple space - that would increase the readability a lot. Currently, one gets (WINE-CVS): http://www.physik.fu-berlin.de/~tburnus/wine/diamond3.png (Windows: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list.png) Tobias

6 7

wineps: rewriting in terms of 32-bit functions
by Dimitrie O. Paun 03 Apr '05

03 Apr '05

Hi Huw, Currenty wineps.dll is one of the worse offenders in terms of using non-standard, 16-bit entry points. Namely, wineps makes use of the following 16-bit functions: CloseJob16() DrvGetPrinterData16() DrvSetPrinterData16() OpenJob16() SelectVisRgn16() WriteSpool16() I was wondering if there's anything that holds us back from using 32-bit APIs instead of the 16-bit ones like so: CloseJob16() --> ClosePrinter() DrvGetPrinterData16() --> GetPrinterDataEx() DrvSetPrinterData16() --> SetPrinterDataEx() OpenJob16() --> OpenPrinter() SelectVisRgn16() --> ? WriteSpool16() --> WritePrinter() I haven't looked too deeply into the problem, but given that you probably know the code inside out, maybe you can help me put this into perspective... -- Dimi.

1 0

Wine and twain
by Brouard Nicolas 02 Apr '05

02 Apr '05

Hi, I haven't seen recent information on wine and twain. I already sent a similar mail to wine-users two weeks ago without answer. I am trying to test a Finereader Office (version 5) with an USB scanner. Everything seems working. But I get scanner not ready when searching for scanner. Sane, gimp or whatever are working well with my scanner. Doing WINEDEBUG=+loaddll wine finereader.exe I get: ... trace:loaddll:load_dll Loaded module L"C:\\program files\\abbyy finereader 5.0 office\\scan\\scanman0.dll" : native trace:loaddll:load_dll Loaded module L"c:\\windows\\system\ \msvcrt.dll" : builtin trace:loaddll:MODULE_FlushModrefs Unloaded module L"c:\\windows\\system\ \msvcrt.dll" : builtin err:module:load_builtin_dll loaded .so for L"Twain.dll" but got L"twain_32.dll" instead - probably 16-bit dll trace:loaddll:MODULE_LoadModule16 Loaded module "c:\\windows\ \Twain.dll" : builtin Scanning driver not ready. But the scanner is ready: # sane-find-scanner -v searching for USB scanners: checking /dev/usb/scanner... failed to open (Invalid argument) checking /dev/usb/scanner0... failed to open (Invalid argument) ... checking /dev/usbscanner15... failed to open (Invalid argument) found USB scanner (vendor=0x03f0 [hp], product=0xb402 [photosmart 7700 series]) at libusb:002:002 found USB scanner (vendor=0x04b8 [EPSON], product=0x010f [EPSON Scanner 010F], chip=LM9832/3) at libusb:001:003 # scanimage -L device `plustek:libusb:001:003' is a Epson Perfection 1250/Photo USB flatbed scanner device `net:localhost:plustek:libusb:001:003' is a Epson Perfection 1250/Photo USB flatbed scanner Thus the device is something like "plustek:libusb:001:003" and # scanimage -d plustek:libusb:001:003 >foo.pnm works. Is there any wine test (windows exe) in order to test twain? Regards, Nicolas -- Brouard Nicolas <nicolas.brouard(a)libertysurf.fr>

1 0

Re: Improve the HHCTRL.OCX stub
by Jacek Caban 02 Apr '05

02 Apr '05

Hi. Two small suggestions. +static char *command_to_string(UINT command) It could be const char. +{ +#define X(x) case x: return #x + + switch (command) + { + X( HH_DISPLAY_TOPIC ); + X( HH_DISPLAY_TOC ); + X( HH_DISPLAY_INDEX ); + X( HH_DISPLAY_SEARCH ); + X( HH_SET_WIN_TYPE ); + X( HH_GET_WIN_TYPE ); + X( HH_GET_WIN_HANDLE ); + X( HH_ENUM_INFO_TYPE ); + X( HH_SET_INFO_TYPE ); + X( HH_SYNC ); + X( HH_RESERVED1 ); + X( HH_RESERVED2 ); + X( HH_RESERVED3 ); + X( HH_KEYWORD_LOOKUP ); + X( HH_DISPLAY_TEXT_POPUP ); + X( HH_HELP_CONTEXT ); + X( HH_TP_HELP_CONTEXTMENU ); + X( HH_TP_HELP_WM_HELP ); + X( HH_CLOSE_ALL ); + X( HH_ALINK_LOOKUP ); + X( HH_GET_LAST_ERROR ); + X( HH_ENUM_CATEGORY ); + X( HH_ENUM_CATEGORY_IT ); + X( HH_RESET_IT_FILTER ); + X( HH_SET_INCLUSIVE_FILTER ); + X( HH_SET_EXCLUSIVE_FILTER ); + X( HH_INITIALIZE ); + X( HH_UNINITIALIZE ); + X( HH_PRETRANSLATEMESSAGE ); + X( HH_SET_GLOBAL_PROPERTY ); + } + +#undef X +} If command is not one of specificed in switch, function won't return a valid string. Thanks, Jacek

1 0

Nearly all Installshield installers fail
by Joaquín Fernández 02 Apr '05

02 Apr '05

> With my application (Route 66), it enables me to start copying files, > however the progress bar never moves. However, the installer is doing > something but seems to be stuck somewhere. Maybe some deadlocks. Español: Yo tuve varios problemas con algunos programas que usan InstallShield como instalador (alrededor de 3 o 4) pero pude instalarlos usando WINEDLLOVERRIDES="ole32,oleaut32,rpcrt4=n,b". Puedes probar esto a ver si te funciona, para mí si funciona con estos programas en Wine 2004XXXX y 2005XXXX. Obviamente, verifica que tengas esas DLLs en el sistema. English: I have had many problems with InstallShield but i was able to install the programs (about 3 or 4 programs using InstallShield that i need) using WINEDLLOVERRIDES="ole32,oleaut32,rpcrt4=n,b". You can probe with this.. it worked for this programs in Wine 2004XXXX and 2005XXXX. Obviously, you must verify that this DLLs exist in the system dir. Regards Joaquin -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

2 1

Re: wine/dlls wininet/netconnection.c user/text.c ...
by Dimitrie O. Paun 02 Apr '05

02 Apr '05

On Tue, Mar 29, 2005 at 01:49:22PM -0600, Alexandre Julliard wrote: > Log message: > Peter Berg Larsen <pebl(a)math.ku.dk> > Janitorial: Get rid of strncpy/strncpyW. This is cool stuff. Now it would be nice if someone hacks winapi_check to ... check for strncpy() business so it doesn't sneak back in. Other than that, are all strncpy() instances gone? If so we should also nuke strncpyW() from wine/unicode.h too. -- Dimi.

2 1

discusion about a message loop in listview.c
by Dietrich Teickner 01 Apr '05

01 Apr '05

I have some weeks before reported, FlashFXP v3.02 loops with a message-loop in listview.c after login. It does this in Odin and in Wine. In Odin it stops in smaller time (deep 1000). Wine has a bigger stack, and so needs wine more time for this, bat I can see in the loog, the args for the function are more and more locatet at lower stack adresses. I have written this workarout for testing this problem in wine and in odin. with this FlashFXH 3.02 will display the contence of the server dir very fast at both environment. In the log I can see, that the message-loop was reported and stopped. I thing, we need a flag inside any item to report every function, that can called recursive, this item is in work (function-separart, or global ?), that can stop recursions of this type in the future or many programms. I have also found this try does also helps Agent 2.0 in the groups->defailt propertys (only odin-tested). This does also every crashs in earlyer builds with stack overflow in odin. Dietrich Index: wine/dlls/comctl32/listview.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/listview.c,v retrieving revision 1.406 diff -u -r1.406 listview.c --- wine/dlls/comctl32/listview.c 25 Mar 2005 20:49:00 -0000 1.406 +++ wine/dlls/comctl32/listview.c 29 Mar 2005 16:31:48 -0000 @@ -139,6 +139,7 @@ * WM_CREATE does not issue WM_QUERYUISTATE and associated registry * processing for "USEDOUBLECLICKTIME". */ +#define __T__ #include "config.h" #include "wine/port.h" @@ -7050,10 +7051,23 @@ * SUCCESS : TRUE * FAILURE : FALSE */ +#ifdef __T__ +static int zIndex = -2; +typedef struct { + PVOID lTol; + HWND cHwnd; + HWND cHwndParent; + INT cItem; + } SetItemStateLink, *PSetItemStateLink; +#endif static BOOL LISTVIEW_SetItemState(LISTVIEW_INFO *infoPtr, INT nItem, const LVITEMW *lpLVItem) { BOOL bResult = TRUE; LVITEMW lvItem; +#ifdef __T__ + int saveLastError = GetLastError(); + SetItemStateLink cTol = { NULL, infoPtr->hwndSelf, infoPtr->hwndNotify, nItem}; +#endif lvItem.iItem = nItem; lvItem.iSubItem = 0; @@ -7062,6 +7076,34 @@ lvItem.stateMask = lpLVItem->stateMask; TRACE("lvItem=%s\n", debuglvitem_t(&lvItem, TRUE)); +#ifdef __T__ + if (-2 == zIndex) + { + zIndex = TlsAlloc(); + SetLastError(saveLastError); + } /* endif */ + if (zIndex >= 0) + { + cTol.lTol = TlsGetValue(zIndex); + if (cTol.lTol < (PVOID)&cTol) + { + cTol.lTol = NULL; + } /* endif */ + SetLastError(saveLastError); + if (cTol.lTol + && (((PSetItemStateLink)cTol.lTol)->cHwnd == infoPtr->hwndSelf) + && (((PSetItemStateLink)cTol.lTol)->cHwndParent == infoPtr->hwndNotify) + && (((PSetItemStateLink)cTol.lTol)->cItem == nItem)) + { + TRACE_(listview)("(DT) Hwnd:%x,%x Parent:%x,%x Item:%d,%d, stop the recursion\n", infoPtr->hwndSelf, ((PSetItemStateLink)cTol.lTol)->cHwnd, + infoPtr->hwndNotify, ((PSetItemStateLink)cTol.lTol)->cHwndParent, + nItem, ((PSetItemStateLink)cTol.lTol)->cItem); + return TRUE; + } + TlsSetValue(zIndex,(LPVOID)&cTol); + SetLastError(saveLastError); + } +#endif if (nItem == -1) { /* apply to all items */ @@ -7070,6 +7112,14 @@ } else bResult = LISTVIEW_SetItemT(infoPtr, &lvItem, TRUE); +#ifdef __T__ + if (zIndex >= 0) + { + saveLastError = GetLastError(); + TlsSetValue(zIndex,(LPVOID)cTol.lTol); + SetLastError(saveLastError); + } +#endif /* *update selection mark

2 1

Nearly all Installshield installers fail
by Uwe Bonnes 01 Apr '05

01 Apr '05

Hello, nearly all recent install shield installer fail for me, similar like: ... fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:sync:SetNamedPipeHandleState 0x1f0 0x42ad30e0 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0x214 0x42ddc0e0 (nil) (nil) fixme:ole:RpcChannelBuffer_GetDestCtx (0x42551d8c,0x42551d90), stub! fixme:sync:SetNamedPipeHandleState 0x214 0x432080e0 (nil) (nil) fixme:ole:NdrConvert (pStubMsg == ^0x406cca80, pFormat == ^0x431041ba): stub. fixme:ole:NdrConvert (pStubMsg == ^0x42551d18, pFormat == ^0x431041ba): stub. err:ole:get_unmarshaler_from_stream Failed to read common OBJREF header, 0x00000000 fixme:ole:RpcChannelBuffer_GetDestCtx (0x42551d88,0x42551d8c), stub! fixme:sync:SetNamedPipeHandleState 0x1e8 0x42ff00e0 (nil) (nil) fixme:ole:NdrConvert (pStubMsg == ^0x406cca7c, pFormat == ^0x431041c8): stub. fixme:ole:NdrConvert (pStubMsg == ^0x42551d14, pFormat == ^0x431041c8): stub. fixme:sync:SetNamedPipeHandleState 0x1e4 0x432080e0 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0x1e4 0x42bd60e0 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0x1e4 0x42ad30e0 (nil) (nil) fixme:sync:SetNamedPipeHandleState 0x1ec 0x42bd60e0 (nil) (nil) fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion from 0x4003 -> 0x8) 42de13b4 Do I have some bogus registry entries, did I miss some dll registration or is this the expected behaviour? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

4 6

RE: WineConf Agenda
by Charles W. Stevenson 01 Apr '05

01 Apr '05

In presenting the commercial value of wine and why we chose to use it, etc. How much time do I have for the presentation? -----Original Message----- From: Jakob Eriksson [mailto:jakov@vmlinux.org] Sent: Thursday, March 31, 2005 11:20 PM To: wineconf(a)winehq.org Cc: Wine Devel; Charles.W.Stevenson(a)guptaworldwide.com Subject: Re: WineConf Agenda Brian Vincent wrote: >I think a full agenda would be about 11 items. If you would like to >present something let me know - there's definitely space available. >If you've been wondering, "There's a neat project I'd like to do if I >could only get a few more people interested", well, this is the >perfect time to bring it up. If there's something strategic to Wine >development, this is a great time to discuss it. > > I don't know if I can find the time to prepare a proper presentation, but if I do, I'd like talk about and get some input from you on the subject of testing. 1) I want the conformance tests done faster. (I have a clear idea how.) 2) What's almost never been brought up on wine-devel is the unit testing in the XP sense. 1 has been discussed on wine-devel quite a bit, so I'll skip it in this mail. regarding 2: CXTest is like application testing. This is good, high-level testing. The conformance tests test the Windows API. But in the case of a complicated API (and Windows is complicated) maybe we need to test the smaller units behind the API. So, the conformance tests often are somewhere between application testing and unit testing. Can we have an infrastructure for running unit tests of small units of code private to the implementation? I.e. these tests, we could call them "private tests", would not run on Windows, but during build of Wine. Would it be acceptable to just include extra test code in the implementation c file, surrounded by #ifdef COMPILE_PRIVATE_TESTS ? regards, Jakob

1 0

Re: wine/ windows/scroll.c dlls/x11drv/scroll.c dl ...
by Dimitrie O. Paun 01 Apr '05

01 Apr '05

On Fri, Mar 25, 2005 at 11:11:04AM -0600, Alexandre Julliard wrote: > Modified files: > windows : scroll.c > dlls/x11drv : scroll.c > dlls/user/tests: win.c msg.c > > Log message: > Rein Klazes <wijn(a)wanadoo.nl> > ScrollDC and X11DRV_SCROLLDC should scroll only pixels coming from > within the visible region, clipped to the clipping region if that > exists. Add the destination of pixels coming from the outside of this > region to the update region. With tests that depend on this. > > Patch: http://cvs.winehq.org/patch.py?id=16854 Unfortunately, this patch doesn't fix bug 1091: http://bugs.winehq.org/show_bug.cgi?id=1091 -- Dimi.

2 3

Fwd: Re: [Wine]winetest and winrash
by Mitchell Mebane 01 Apr '05

01 Apr '05

Ivan Leo Puoti wrote: > Mitchell Mebane wrote: > >> Hey there, >> >> I ran it on my XP Pro SP2 desktop and Windows Server 2003 under >> VMWare just fine, but when I ran it on Win2K Pro SP4 under VMWare, it >> told me the log was too large (6.4 MB > 1 MB) and it would only send >> partial results. Is there any reason this log would be almost an >> order of magnitude larger than the others? >> > From the log it appears to be a problem with the PathIsValidCharA API, > you may want to report this to wine-devel. > > Ivan. > > . > OK, I'll do so. Results are on this page: http://test.winehq.com/data/200503311000/ Specifically, this: http://test.winehq.com/data/200503311000/2000_mmebane/shlwapi:path.txt The OS setup I ran the test under is pretty much a bare-bones Win2K Pro SP4 install. If you want any more information about it, let me know. --Mitchell -- The roots of education are bitter, but the fruit is sweet. --Aristotle

1 0

Re: KERNEL: improve stubs for DnsHostnameToComputerName{A,W}
by Peter Berg Larsen 31 Mar '05

31 Mar '05

+BOOL WINAPI DnsHostnameToComputerNameA(LPCSTR hostname, + LPSTR computername, LPDWORD size) ... + DWORD len; + ... + if (!hostname || !size) return FALSE; + len = lstrlenW(hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*size < len) + { + *size = len; + return FALSE; + } + if (!computername) return FALSE; + + memcpy( computername, hostname, len ); + computername[len + 1] = 0; + return TRUE; + } I have seen at lot of these where the \0 termination is unspecified for the size parameter, but in this case msdn mentions it. >From msdn: -------- BOOL DnsHostnameToComputerName( LPCTSTR Hostname, LPTSTR ComputerName, LPDWORD nSize ); Parameters Hostname [in] Pointer to a string that specifies the DNS name. If the DNS name is not a valid, translatable name, the function fails. ComputerName [out] Pointer to a string buffer that receives the computer name. The buffer size should be large enough to contain MAX_COMPUTERNAME_LENGTH + 1 characters. nSize [in, out] On input, specifies the size of the buffer, in TCHARs. On output, receives the number of TCHARs copied to the destination buffer, not including the terminating null character. If the buffer is too small, the function fails, GetLastError returns ERROR_MORE_DATA, and nSize receives the required buffer size, not including the terminating null character. ----------- So at least the check should be: if (*size < len + 1) { ... } or you risk the computername[len+1] is invalid. Now the second question is, which might be a convention, where does is say that I cant set computerName size to 3*MAX_COMPUTERNAME_LENGTH and expect it to return the computername not truncated to MAX_COMPUTERNAME_LENGTH? Peter

1 1

Re: Implementation of EnumMoniker and Partial impl on MkParseDisplayName
by Robert Shearman 31 Mar '05

31 Mar '05

Jeff Latimer wrote: > This is the first installment of the implementation of > MkParseDisplayName. I would like feed back on style and usage. Ok, I'll happily add comments on the patch. > > I think the implementation of the EnumMoniker interface looks ok. > Comments appreciated. > > Jeff Latimer > >------------------------------------------------------------------------ > >Index: moniker.c >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/moniker.c,v >retrieving revision 1.38 >diff -u -r1.38 moniker.c >--- moniker.c 13 Dec 2004 21:19:02 -0000 1.38 >+++ moniker.c 28 Mar 2005 12:06:51 -0000 >@@ -29,7 +29,6 @@ > > #include <assert.h> > #include <stdarg.h> >-#include <string.h> > > #define COBJMACROS > >@@ -38,6 +37,7 @@ > #include "winbase.h" > #include "winuser.h" > #include "wtypes.h" >+#include "wine/unicode.h" > #include "wine/debug.h" > #include "ole2.h" > >@@ -50,11 +50,11 @@ > /* define the structure of the running object table elements */ > typedef struct RunObject{ > >- IUnknown* pObj; /* points on a running object*/ >- IMoniker* pmkObj; /* points on a moniker who identifies this object */ >+ IUnknown* pObj; /* points on a running object*/ >+ IMoniker* pmkObj; /* points on a moniker who identifies this object */ > FILETIME lastModifObj; >- DWORD identRegObj; /* registration key relative to this object */ >- DWORD regTypeObj; /* registration type : strong or weak */ >+ DWORD identRegObj; /* registration key relative to this object */ >+ DWORD regTypeObj; /* registration type : strong or weak */ > }RunObject; > > /* define the RunningObjectTableImpl structure */ >@@ -106,6 +106,55 @@ > RunningObjectTableImpl_EnumRunning > }; > >+/* define the EnumMonikerImpl structure */ >+typedef struct EnumMonikerImpl{ >+ >+ IEnumMonikerVtbl *lpVtbl; >+ ULONG ref; >+ >+ RunObject* TabMoniker; /* pointer to the first object in the table */ >+ DWORD TabSize; /* current table size */ >+ DWORD TabLastIndx; /* first free index element in the table. */ > > Since you asked for feedback on style, I'll say that you should try to keep the naming conventions consistent. >+ DWORD runObjTabRegister; /* registration key of the next registered object */ >+ DWORD currentPos; /* enum position in the list */ >+ >+} EnumMonikerImpl; >+ >+ >+/* IEnumMoniker prototype functions : */ >+/* IUnknown functions*/ >+static HRESULT WINAPI EnumMonikerImpl_QueryInterface(IEnumMoniker* iface,REFIID riid,void** ppvObject); >+static ULONG WINAPI EnumMonikerImpl_AddRef(IEnumMoniker* iface); >+static ULONG WINAPI EnumMonikerImpl_Release(IEnumMoniker* iface); >+/* IEnumMoniker functions */ >+static HRESULT WINAPI EnumMonikerImpl_Next(IEnumMoniker* iface, ULONG celt, IMoniker** rgelt, ULONG* pceltFetched); >+static HRESULT WINAPI EnumMonikerImpl_Skip(IEnumMoniker* iface, ULONG celt); >+static HRESULT WINAPI EnumMonikerImpl_Reset(IEnumMoniker* iface); >+static HRESULT WINAPI EnumMonikerImpl_Clone(IEnumMoniker* iface, IEnumMoniker** ppenum); > > If you put the vtable after the implementations of the functions then you don't need to declare the prototypes here. >+ >+/* Local functions*/ >+HRESULT WINAPI EnumMonikerImpl_Initialize(void); >+HRESULT WINAPI EnumMonikerImpl_CreateEnumROTMoniker(RunObject* runObjTab, >+ ULONG TabSize, >+ ULONG TabLastIndx, >+ ULONG currentPos, >+ IEnumMoniker ** ppenumMoniker); >+HRESULT WINAPI EnumMonikerImpl_UnInitialize(void); >+HRESULT WINAPI EnumMonikerImpl_Destroy(void); >+HRESULT WINAPI EnumMonikerImpl_GetObjectIndex(EnumMonikerImpl* This,DWORD identReg,IMoniker* pmk,DWORD *indx); > > Presumably, these should all be static since they are not used outside the file. >+ >+/* Virtual function table for the IEnumMoniker class. */ >+static IEnumMonikerVtbl VT_EnumMonikerImpl = >+{ >+ EnumMonikerImpl_QueryInterface, >+ EnumMonikerImpl_AddRef, >+ EnumMonikerImpl_Release, >+ EnumMonikerImpl_Next, >+ EnumMonikerImpl_Skip, >+ EnumMonikerImpl_Reset, >+ EnumMonikerImpl_Clone >+}; >+ > /*********************************************************************** > * RunningObjectTable_QueryInterface > */ >+/*********************************************************************** >+ * EnumMonikerImpl_CreateEnumROTMoniker >+ * Used by EnumRunning to create the structure and EnumClone >+ * to copy the structure >+ */ >+HRESULT WINAPI EnumMonikerImpl_CreateEnumROTMoniker(RunObject* TabMoniker, >+ ULONG TabSize, >+ ULONG TabLastIndx, >+ ULONG currentPos, >+ IEnumMoniker ** ppenumMoniker) >+{ >+ int i; >+ if (currentPos > TabSize) >+ return E_INVALIDARG; >+ >+ if (ppenumMoniker == 0) >+ return E_OUTOFMEMORY; > > This should probably be E_INVALIDARG. >+ >+ *ppenumMoniker = HeapAlloc(GetProcessHeap(), 0, sizeof(EnumMonikerImpl)); >+ > > if (!*ppenumMoniker) return E_OUTOFMEMORY; >+ void *vpThis=*ppenumMoniker; > > Variable used just for changing types?!?! >+ EnumMonikerImpl* This=0; > > Using NULL instead of 0 tends to make it clearer that you are using a pointer. >+ This=vpThis; > > All of these variable declarations need moving to the top of the block. >+ TRACE("(%p)\n",This); >+ /* initialize the virtual table function */ >+ This->lpVtbl = &VT_EnumMonikerImpl; >+ >+ /* the initial reference is set to "1" because if set to "0" it will be not practis when */ >+ /* the ROT referred many times not in the same time (all the objects in the ROT will */ >+ /* be removed every time the ROT is removed ) */ >+ This->ref = 1; /* set the ref count to one */ >+ This->currentPos=0; /* Set the list start posn to start */ >+ This->TabSize=TabSize; /* Need the same size table as ROT */ >+ This->TabLastIndx=TabLastIndx; /* end element */ >+ This->TabMoniker=HeapAlloc(GetProcessHeap(),0,This->TabSize*sizeof(RunObject)); >+ >+ if (This->TabMoniker==NULL) { >+ HeapFree(GetProcessHeap(), 0, This); >+ return E_OUTOFMEMORY; >+ } >+ for (i=0;i<This->TabLastIndx;i++){ >+ >+ This->TabMoniker[i]=TabMoniker[i]; >+ IMoniker_AddRef(TabMoniker[i].pmkObj); >+ } >+ >+ return S_OK; > } > > /*********************************************************************** >@@ -512,8 +621,180 @@ > return res; > } > >+/*********************************************************************** >+ * EnumMoniker_QueryInterface >+ */ >+HRESULT WINAPI EnumMonikerImpl_QueryInterface(IEnumMoniker* iface,REFIID riid,void** ppvObject) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ >+ TRACE("(%p,%p,%p)\n",This,riid,ppvObject); >+ >+ /* validate arguments */ >+ if (This==0) >+ return CO_E_NOTINITIALIZED; > > Remove this check. It is completely bogus. >+ >+ if (ppvObject==0) >+ return E_INVALIDARG; >+ >+ *ppvObject = 0; >+ >+ if (IsEqualIID(&IID_IUnknown, riid)) >+ *ppvObject = (IEnumMoniker*)This; >+ else >+ if (IsEqualIID(&IID_IEnumMoniker, riid)) >+ *ppvObject = (IEnumMoniker*)This; >+ >+ if ((*ppvObject)==0) >+ return E_NOINTERFACE; >+ >+ EnumMonikerImpl_AddRef(iface); >+ >+ return S_OK; >+} >+ >+/*********************************************************************** >+ * EnumMoniker_AddRef >+ */ >+ULONG WINAPI EnumMonikerImpl_AddRef(IEnumMoniker* iface) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ >+ TRACE("(%p)\n",This); >+ >+ return InterlockedIncrement(&This->ref); >+} >+ >+/*********************************************************************** >+ * EnumMoniker_Destroy >+ */ >+HRESULT WINAPI EnumMonikerImpl_Destroy() >+{ >+ TRACE("(?)\n"); >+ >+// if (enumMonikerInstance==NULL) >+// return E_INVALIDARG; >+ >+ /* free the enummoniker structure memory */ >+// HeapFree(GetProcessHeap(),0,enumMonikerInstance); >+ >+ return S_OK; >+} > > You are not using this function, so remove it. >+ >+/*********************************************************************** >+ * EnumMoniker_release >+ */ >+ULONG WINAPI EnumMonikerImpl_Release(IEnumMoniker* iface) >+{ >+ DWORD i; >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ ULONG ref; >+ >+ TRACE("(%p)\n",This); >+ >+ if (This==0) >+ return E_INVALIDARG; > > Another bogus This pointer check. >+ >+ ref = InterlockedDecrement(&This->ref); >+ >+ /* unitialize rot structure if there's no more reference to it*/ >+ if (ref == 0) { >+ >+ /* release all registered objects in Moniker list */ >+ for(i=0;i<This->TabLastIndx;i++) >+ { >+ IMoniker_Release(This->TabMoniker[i].pmkObj); >+ } >+ >+ /* there're no more elements in the table */ >+ >+ TRACE("(%p) Deleting\n",This); >+ HeapFree (GetProcessHeap(), 0, This->TabMoniker); // free Moniker list >+ HeapFree (GetProcessHeap(), 0, This); // free Enum Instance >+ >+ } >+ >+ return ref; >+} >+/*********************************************************************** >+ * EnmumMoniker_Next >+ */ >+HRESULT WINAPI EnumMonikerImpl_Next(IEnumMoniker* iface, ULONG celt, IMoniker** rgelt, ULONG * pceltFetched) >+{ >+// DWORD i; >+// ULONG ref; > > Remove these lines. >+ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ TRACE("(%p) currentPos %d Tablastindx %d\n",This, (int)This->currentPos, (int)This->TabLastIndx); >+ ULONG i; >+ >+ /* retrieve the requested number of moniker from the current position */ >+ for(i=0;((This->currentPos < This->TabLastIndx) && (i < celt));i++) >+ rgelt[i]=(IMoniker*)This->TabMoniker[This->currentPos++].pmkObj; >+ >+ if (pceltFetched!=NULL) >+ *pceltFetched= i; >+ >+ if (i==celt) >+ return S_OK; >+ else >+ return S_FALSE; >+ >+} >+ >+/*********************************************************************** >+ * EnmumMoniker_Skip >+ */ >+HRESULT WINAPI EnumMonikerImpl_Skip(IEnumMoniker* iface, ULONG celt) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ >+ TRACE("(%p)\n",This); >+ if (This==0) >+ return E_INVALIDARG; > > Another bogus check. I'll stop commenting about these now, but you should remove all of them. >+ >+ if ((This->currentPos+celt) >= This->TabLastIndx) >+ return S_FALSE; >+ >+ This->currentPos+=celt; >+ >+ return S_OK; >+} >+ >+/*********************************************************************** >+ * EnmumMoniker_Reset >+ */ >+HRESULT WINAPI EnumMonikerImpl_Reset(IEnumMoniker* iface) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ if (This==0) >+ return E_INVALIDARG; >+ >+ This->currentPos = 0; /* set back to start of list */ >+ >+ TRACE("(%p)\n",This); >+ >+ return S_OK; >+} >+ >+/*********************************************************************** >+ * EnmumMoniker_Clone >+ */ >+HRESULT WINAPI EnumMonikerImpl_Clone(IEnumMoniker* iface, IEnumMoniker ** ppenum) >+{ >+ EnumMonikerImpl *This = (EnumMonikerImpl *)iface; >+ if (This==0) >+ return E_INVALIDARG; >+ >+ TRACE("(%p)\n",This); >+ /* copy the enum structure */ >+ return EnumMonikerImpl_CreateEnumROTMoniker(This->TabMoniker, This->TabSize, >+ This->TabLastIndx, This->currentPos, >+ ppenum); >+} >+ > /****************************************************************************** >- * OleRun [OLE32.@] >+ * olerun [ole32.@] > > The name of the function really is OleRun, not olerun. Feel free to submit the change from OLE32->ole32 in another patch, but make sure you change every instance of this. > */ > HRESULT WINAPI OleRun(LPUNKNOWN pUnknown) > { >@@ -523,22 +804,142 @@ > > ret = IRunnableObject_QueryInterface(This,&IID_IRunnableObject,(LPVOID*)&runable); > if (ret) >- return 0; /* Appears to return no error. */ >+ return 0; /* appears to return no error. */ > ret = IRunnableObject_Run(runable,NULL); > IRunnableObject_Release(runable); > return ret; > } > > /****************************************************************************** >- * MkParseDisplayName [OLE32.@] >+ * MkParseDisplayName [ole32.@] > */ > HRESULT WINAPI MkParseDisplayName(LPBC pbc, LPCOLESTR szUserName, > LPDWORD pchEaten, LPMONIKER *ppmk) > { >- FIXME("(%p, %s, %p, %p): stub.\n", pbc, debugstr_w(szUserName), pchEaten, *ppmk); >+ int char_cnt = 0; >+ int usernamelen = 0; >+ HRESULT rc =0; >+ WCHAR username [2048]; // workspace to parse name into > > Please don't use C99 comments. Use "/* comment */" instead. >+ IRunningObjectTable * pprot; >+ IEnumMoniker *spEM; >+ IMoniker * spMoniker; >+// IUnknown * spUnk; >+ LPMALLOC * ppMalloc; >+ TRACE("(%p)\n", pbc); >+ rc = CoGetMalloc(1, (LPMALLOC *) &ppMalloc); > > You leak references to ppMalloc everywhere. Is it really necessary to use CoGetMalloc? > if (!(IsValidInterface((LPUNKNOWN) pbc))) > return E_INVALIDARG; >+ usernamelen = (int) lstrlenW(szUserName); // overall string len >+ > >+ if (szUserName[char_cnt] == (WCHAR) '@') { // This is a progid not a file name >+ FIXME("Progid not implemented\n"); >+ return MK_E_SYNTAX; >+ } else { >+ char_cnt = 0; >+ if (szUserName[char_cnt+1] == ':') { >+ if ((szUserName[char_cnt] < 'a' || szUserName[char_cnt] > 'z') && >+ (szUserName[char_cnt] < 'A' || szUserName[char_cnt] > 'Z')) { >+ FIXME("bad drive %c\n", szUserName[char_cnt]); > > This should be an ERR instead of FIXME, unless there is something you haven't implemented. If that is the case, please add a comment here as to what that could be. >+ return MK_E_SYNTAX; >+ } >+ username[0] = (WCHAR)szUserName[0]; >+ username[1] = szUserName[1]; >+ char_cnt += 2; // point past drive spec >+ } >+ for (; szUserName[char_cnt] != 0x0 && // until end of string or >+ szUserName[char_cnt] != '!' ; char_cnt++) { // end of component >+ FIXME("%c",szUserName[char_cnt]); > > Is this just a debugging statement? >+ if (szUserName[char_cnt] == '\\' && szUserName[char_cnt+1] == '\\') { >+ FIXME("badchar %c\n",szUserName[char_cnt]); >+ return MK_E_SYNTAX; >+ } >+ if (szUserName[char_cnt] == '/' || >+ szUserName[char_cnt] == '?' || >+ szUserName[char_cnt] == '<' || >+ szUserName[char_cnt] == '>' || >+ szUserName[char_cnt] == '*' || >+ szUserName[char_cnt] == '|' || >+ szUserName[char_cnt] == ':') >+ { >+ FIXME("badchar %c\n",szUserName[char_cnt]); >+ return MK_E_SYNTAX; >+ } >+ username[char_cnt] = (WCHAR) szUserName[char_cnt]; > > Shouldn't need a cast here. >+ } >+ FIXME("\n"); >+ username[char_cnt] = 0x0; // terminate the substring >+ TRACE("File name to be converted to Moniker: %s\n", debugstr_w(username)); >+ rc = IBindCtx_GetRunningObjectTable(pbc, &pprot); >+ if (!SUCCEEDED(rc)) >+ { >+ ERR("IBindCtx_GetRunningObjectTable failed %04x\n", (int) rc); > > This should be: + ERR("IBindCtx_GetRunningObjectTable failed 0x%08lx\n", rc); >+ return MK_E_SYNTAX; >+ } >+ rc = IRunningObjectTable_EnumRunning(pprot, &spEM); >+ TRACE("IRunningObjectTable_EnumRunning rc:%04x %p\n", (int)rc, spEM); > > >+ if (SUCCEEDED(rc)) >+ { >+ rc = MK_E_NOOBJECT; >+ while ((IEnumMoniker_Next(spEM, 1, &spMoniker, NULL)==S_OK) && >+ (*ppmk ==NULL)) >+ { >+ WCHAR *szDisplayn=NULL; >+ rc=IMoniker_GetDisplayName(spMoniker, pbc, NULL, >+ (LPOLESTR*) &szDisplayn); >+ TRACE("Display Name %s for Moniker %p\n", debugstr_w(szDisplayn), spMoniker); >+ if (SUCCEEDED(rc)) >+ { >+ TRACE("IMoniker_GetDisplayName succeeded, rc %08x ROT Name:%s, New name:%s\n", >+ (int)rc, debugstr_w(szDisplayn), debugstr_w(username)); >+ if (0==strcmpiW((WCHAR *)szDisplayn, (WCHAR *)username)) >+ { >+ TRACE("is Equal %p\n", spMoniker); >+ *ppmk = spMoniker; // we already have the Moniker, so use it >+ IMoniker_AddRef(spMoniker); // say we are reusing this Moniker >+ } >+ else >+ TRACE("Not Equal\n"); >+ >+ CoTaskMemFree(szDisplayn); >+ } >+ } >+// rc = IRunningObjectTable_GetObject(pprot, spMoniker, &spUnk); >+// if (!SUCCEEDED(rc)) >+// TRACE("ok\n"); >+ IEnumMoniker_Release(spEM); // Free Enum interface >+ IRunningObjectTable_Release(pprot); // Decrement ROT count >+ pprot = NULL; // Finished with ROT pointer >+ } >+ else >+ ERR("IRunningObjectTable_EnumRunning failed %04x\n", (int ) rc); >+ >+ if (*ppmk == NULL) >+ { >+ rc = CreateFileMoniker(username, ppmk); // convert to moniker >+ if (SUCCEEDED(rc)) >+ { >+ *pchEaten = (int) char_cnt; >+ if (usernamelen > char_cnt) // there is more to do and not implemented >+ { >+ TRACE("Username len %i exceeds parsed text %i\n", usernamelen, char_cnt); > > This should be a FIXME then. >+ return MK_E_SYNTAX; >+ } >+ TRACE(" CreateFileMoniker Succeeded %04x\n", (int) rc); >+ return (S_OK); >+ } else >+ { >+ TRACE("CreateFileMoniker Failed %04x\n", (int) rc); > > ERR >+ return(rc); >+ } >+ } >+ else >+ { >+ *pchEaten = (int) char_cnt; >+ TRACE(" Reused Moniker %p\n", *ppmk); >+ return (S_OK); >+ } >+ } > return MK_E_SYNTAX; > } > >Index: Makefile.in >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/Makefile.in,v >retrieving revision 1.43 >diff -u -r1.43 Makefile.in >--- Makefile.in 17 Mar 2005 20:50:35 -0000 1.43 >+++ Makefile.in 28 Mar 2005 12:06:52 -0000 >@@ -5,7 +5,7 @@ > VPATH = @srcdir@ > MODULE = ole32.dll > IMPORTS = advapi32 user32 gdi32 rpcrt4 kernel32 ntdll >-EXTRALIBS = -luuid $(LIBUNICODE) >+EXTRALIBS = -luuid $(LIBUNICODE) > > C_SRCS = \ > antimoniker.c \ > > Useless whitespace only change. >Index: tests/moniker.c >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/tests/moniker.c,v >retrieving revision 1.2 >diff -u -r1.2 moniker.c >--- tests/moniker.c 28 Jan 2005 12:39:13 -0000 1.2 >+++ tests/moniker.c 28 Mar 2005 12:06:56 -0000 >@@ -22,40 +22,166 @@ > #define COBJMACROS > > #include <stdarg.h> >+//#include <wchar.h> > > Remove this line. > > #include "windef.h" > #include "winbase.h" > #include "objbase.h" >+#include "objidl.h" > #include "comcat.h" > > #include "wine/test.h" > > #define ok_ole_success(hr, func) ok(hr == S_OK, #func " failed with error 0x%08lx\n", hr) > >+LPTSTR * prt(HRESULT hr, LPTSTR * lpMsgBuf); > > Not used anywhere. >+ > static void test_MkParseDisplayName() > { > IBindCtx * pbc = NULL; > HRESULT hr; >- IMoniker * pmk = NULL; > ULONG eaten; >- IUnknown * object = NULL; >+ int cnt; >+ > /* CLSID of My Computer */ >- static const WCHAR wszDisplayName[] = {'c','l','s','i','d',':', >+ static const WCHAR wszDisplayName1[] = {'@','c','l','s','i','d',':', >+ '2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-','A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D',':',0}; > > Does "clsid:..." without the "@" still work? I'd prefer to see that test still in there. >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ IMoniker *pmk1 = NULL; >+ hr = MkParseDisplayName(pbc, wszDisplayName1, &eaten, &pmk1); >+ todo_wine { ok(hr==0x800401e4, "MkParseDisplayName - Progid not implemented hr=%08x\n", (int) hr); } > > MK_E_SYNTAX. See the ok_ole_success macro for how to print out HRESULTs without casts. >+ >+ IBindCtx_Release(pbc); >+ >+ /* A bad drive */ >+ static const WCHAR wszDisplayName2[] = {'1',':','s','i','d',':', > '2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-','A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D',':',0}; > > hr = CreateBindCtx(0, &pbc); > ok_ole_success(hr, CreateBindCtx); >+ IMoniker *pmk2=NULL; >+ hr = MkParseDisplayName(pbc, wszDisplayName2, &eaten, &pmk2); >+ ok(hr==0x800401e4, "MkParseDisplayName hr=%08x\n", (int) hr); >+ >+ IBindCtx_Release(pbc); > >- hr = MkParseDisplayName(pbc, wszDisplayName, &eaten, &pmk); >- todo_wine { ok_ole_success(hr, MkParseDisplayName); } >+ /* A good drive, bad char */ >+ static const WCHAR wszDisplayName3[] = {'b',':','s','i','d',':', >+ '2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-','A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D',':',0}; >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ IMoniker *pmk3=NULL; >+ hr = MkParseDisplayName(pbc, wszDisplayName3, &eaten, &pmk3); >+ todo_wine { ok(hr==0x800401e4, "MkParseDisplayName hr=%08x\n", (int) hr); } >+ >+ IBindCtx_Release(pbc); >+ >+ // Good file name >+ static const WCHAR wszDisplayName4[] = {'c',':','\\','w','i','n','d', >+ 'o','w','s','\\','f','r','E','d','.','e','x','E',0x0}; >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ >+ IMoniker *pmk4=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName4, &eaten, &pmk4); >+ todo_wine { ok(hr==0, "MkParseDisplayName hr=%08x\n", (int) hr); } >+ >+ IBindCtx_Release(pbc); >+ >+ /* Good file name + item. This test is to see if the whole display >+ * name is consumed >+ */ >+ static const WCHAR wszDisplayName5[] = {'c',':','\\','w','i','n','d', >+ 'o','w','s','\\','f','r','E','d','.','e','x','E','!','m','a','r','k',0x0}; >+ >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); >+ >+ IMoniker *pmk5=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName5, &eaten, &pmk5); >+ ok(hr!=0, "MkParseDisplayName failed hr=%08x\n", (int) hr); >+ cnt = (int) lstrlenW(wszDisplayName5); // Get length of text >+ ok(eaten==cnt, "eaten %d string len %i\n", (int) eaten, cnt); // See if consiumed >+ >+ IBindCtx_Release(pbc); >+ >+ /* This test is to create a valid Moniker an then load a couple of >+ * entries into the ROT to test that MkParseDisplayName reuses the >+ * Moniker in the ROT. Currently using the EnumMoniker object as >+ * part of the Register call to satisfy the syntax >+ */ >+ >+ static const WCHAR wszDisplayName6[] = {'c',':','\\','P','r','o','g', >+ 'r','a','m',' ','F','i','l','e','s','\\','v','i','m','\\', >+ 'v','i','m','6','1','\\','g','v','i','m','.','e','x','e',0x0}; >+ hr = CreateBindCtx(0, &pbc); >+ ok_ole_success(hr, CreateBindCtx); > >- if (object) >- { >- hr = IMoniker_BindToObject(pmk, pbc, NULL, &IID_IUnknown, (LPVOID*)&object); >- ok_ole_success(hr, IMoniker_BindToObject); >+ IMoniker *pmk6=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName6, &eaten, &pmk6); >+ ok(hr==0, "MkParseDisplayName hr=%08x\n", (int) hr); >+ cnt = lstrlenW(wszDisplayName6); // Get length of text >+ ok(eaten==cnt, "eaten %d string len %i\n", (int) eaten, cnt); // See if consiumed >+ >+ IRunningObjectTable * pprot=NULL; >+ hr = IBindCtx_GetRunningObjectTable(pbc, &pprot); >+ todo_wine { ok(hr==0, "IBindCtx_GetRunningObjectTable hr=%08x\n", (int) hr); } >+ IEnumMoniker *spEM1=NULL; >+ hr = IRunningObjectTable_EnumRunning(pprot, &spEM1); >+ todo_wine { ok(hr==0, "IRunningObjectTable_EnumRunning hr=%08x\n", (int) hr);} >+ IUnknown *lpEM1; >+ hr = IEnumMoniker_QueryInterface(spEM1, &IID_IUnknown, (void*) &lpEM1); >+ todo_wine { ok(hr==0, "IEnumMoniker_QueryInterface hr %08x %p\n", (int) hr, lpEM1); } >+ DWORD pdwReg1=0; >+ DWORD grflags=0; >+ grflags= grflags | ROTFLAGS_REGISTRATIONKEEPSALIVE; >+ hr = IRunningObjectTable_Register(pprot, grflags, lpEM1, pmk5, &pdwReg1); >+ todo_wine { ok(hr==0, "IRunningObjectTable_Register hr=%08x %p %08x %p %p %d\n", >+ (int) hr, pprot, (int) grflags, lpEM1, pmk5, (int) pdwReg1); } >+ >+ DWORD pdwReg2=0; >+ grflags=0; >+ grflags= grflags | ROTFLAGS_REGISTRATIONKEEPSALIVE; >+ hr = IRunningObjectTable_Register(pprot, grflags, lpEM1, pmk6, &pdwReg2); >+ ok(hr==0, "IRunningObjectTable_Register hr=%08x %p %08x %p %p %d\n", (int) hr, >+ pprot, (int) grflags, lpEM1, pmk6, (int) pdwReg2); >+ >+ IEnumMoniker *spEM=NULL; >+ hr = IRunningObjectTable_EnumRunning(pprot, &spEM); >+ todo_wine { ok(hr==0, "IRunningObjectTable_EnumRunning hr=%08x\n", (int) hr); } >+ // Now see if the we get the same moniker after querying the ROT >+ IMoniker *pmk61=NULL; >+ eaten=0; >+ hr = MkParseDisplayName(pbc, wszDisplayName6, &eaten, &pmk61); >+ ok(pmk6==pmk61, "Moniker should be the same address %p != %p\n", pmk6, pmk61); >+ >+ IRunningObjectTable_Revoke(pprot,pdwReg1); >+ IRunningObjectTable_Revoke(pprot,pdwReg2); >+ IEnumMoniker_Release(spEM); >+ IEnumMoniker_Release(spEM1); >+ IRunningObjectTable_Release(pprot); >+ if (pmk61!=NULL) >+ IMoniker_Release(pmk61); >+ if (pmk6!=NULL) >+ IMoniker_Release(pmk6); >+ if (pmk5!=NULL) >+ IMoniker_Release(pmk5); >+ if (pmk4!=NULL) >+ IMoniker_Release(pmk4); >+ if (pmk3!=NULL) >+ IMoniker_Release(pmk3); >+ if (pmk2!=NULL) >+ IMoniker_Release(pmk2); >+ if (pmk1!=NULL) >+ IMoniker_Release(pmk1); > >- IUnknown_Release(object); >- } > IBindCtx_Release(pbc); > } > > > Rob

3 2

installing Win32 Compilers
by Wesley Parish 31 Mar '05

31 Mar '05

Installing MinGW32 together with msys-1.* and msysDTK was a breeze. I started installing lccwin32, only to find problems with the library compilation in the latter part of installation, with it hanging once it got to commandline.txt fdlibm.lib lcccrt0.obj libcrt0s.obj stdlib.idx complex.lib gdbmdll.lib lcccrt0s.obj libml.lib tcconio.lib daguid.lib gdbm.lib lcc.lib regexp.lib UUID.LIB dx8math.lib glaux.lib libc.lib scrnsave.lib weditres.lib dxguid.lib iostream.lib libcrt0.obj shell32.lib wizard/ until I stopped it. Consequently it hung on installing Sleepycat's db. I'll erase the installation and try again, this time saving the error messages. Wesley Parish PS But wow, it felt good, watching MinGW32 install _without_ a hitch! Well done! -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

1 0

Re: Wine Debugger
by Pouech Eric DMI AEI CAEN 31 Mar '05

31 Mar '05

use regedit at the beginning of your script to set the AeDebug key to a "" string (and you should have saved the key value before), and restore it at the end of your script > Message du 31/03/05 08:47 > De : "Cal Pierog" > A : wine-devel(a)winehq.org > Copie à : > Objet : Wine Debugger > > I am trying to write a script which, at one point, needs to run the wine > test suite, accomplished with: > > make -k test > > Even though this skips over bad tests, it does not prevent the debugger > from kicking in every once in a while and asking for user input. I would > like this script to be robust enough to run the test suite without user > input, even when one of the tests fails badly enough to call the debugger. > > So, is there any way to disable the debugger so that the script can just > continue on errors and not sit at a "Wine-dbg>" prompt? > > Thanks, > Cal Pierog > > > > >

2 1

Re: winetest: ask for a tag (take 2)
by Alexandre Julliard 31 Mar '05

31 Mar '05

Ferenc Wagner <wferi(a)tba.elte.hu> writes: > ChangeLog: Ask for a tag if one was not given on the command line. > > This patch incorporates the suggestions of Rob and Mike. > Some casts are still necessary to suppress the warnings, but > this code is hopefully 64-bit safe. Simply storing the string in a global variable would make things a lot easier and more readable... -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine Debugger
by Cal Pierog 31 Mar '05

31 Mar '05

I am trying to write a script which, at one point, needs to run the wine test suite, accomplished with: make -k test Even though this skips over bad tests, it does not prevent the debugger from kicking in every once in a while and asking for user input. I would like this script to be robust enough to run the test suite without user input, even when one of the tests fails badly enough to call the debugger. So, is there any way to disable the debugger so that the script can just continue on errors and not sit at a "Wine-dbg>" prompt? Thanks, Cal Pierog

2 1

Regression in comctl32 Treeview (breaks Filezilla)
by Hannu Valtonen 30 Mar '05

30 Mar '05

Hi, The following patch: ChangeSet ID: 15259 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/01/07 09:34:25 Modified files: dlls/comctl32 : treeview.c Log message: Crestez Leonard <cleonard(a)go.ro> Fix bug with Treeview_SelectItem reselecting the same item. Patch: http://cvs.winehq.org/patch.py?id=15259 Old revision New revision Changes Path 1.160 1.161 +0 -3 wine/dlls/comctl32/treeview.c Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The way to reproduce it is to go to the Site manager and click the "New site" button. (Doesn't work even with latest CVS) Without the check which the patch removes, if (prevSelect == newSelect) return FALSE; The dialog goes to an infinite loop. (you can exit it if you just hold the ESC-key down for long enough) I have no idea whether the rationale Leonard provided with his patch is correct, but it does break Filezilla. The binary file for Filezilla can be gotten from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?dow… and the source file from: http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?downl… I would appreciate it if some comctl32 messaging guru could step up and take look at this problem -- - Hannu Valtonen Hannu.Valtonen(a)hut.fi +358408030179

1 1

Re: ScrollWindow fix for windows with WS_CLIPCHILDREN style, with tests - version 2
by Alexandre Julliard 30 Mar '05

30 Mar '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > windows : scroll.c > dlls/user/tests : win.c > > If ScrollWindowEx is called with SW_SCROLLCHILDREN flags for a window > with a WS_CLIPCHILDREN style, then do not use the DCX_USESTYLE flag > option to get a DC for this window. With a couple of regression tests. DCX_USESTYLE has other effects, is it really correct to disable them all? And if so, wouldn't it be better to never use DCX_USESTYLE? -- Alexandre Julliard julliard(a)winehq.org

2 1

Fwd: Wine install fails on Gentoo with `SYS_sigaction' undeclared
by Ferenc Wagner 30 Mar '05

30 Mar '05

Hi, I think this message better fits here on the devel list. Cheers, Feri. -------------------- Start of forwarded message -------------------- From: "Jonathan Duncan" <googlegroups(a)nacnud.com> Newsgroups: comp.emulators.ms-windows.wine Date: 25 Mar 2005 10:26:46 -0800 Message-ID: <1111775206.112993.209430(a)f14g2000cwb.googlegroups.com> I downloaded "Wine-20050310.tar.gz" Untar/zipped it. Entered the directory "wine-20050310" Typed "./configure" -> Success Typed "make depend" -> Success Typed "make" -> The following is the last of the make process: ------------------------------------------------------------- gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o server.o server.c gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o signal_i386.o signal_i386.c signal_i386.c: In function `wine_sigaction': signal_i386.c:114: error: `SYS_sigaction' undeclared (first use in this function) signal_i386.c:114: error: (Each undeclared identifier is reported only once signal_i386.c:114: error: for each function it appears in.) make[2]: *** [signal_i386.o] Error 1 make[2]: Leaving directory `/home/jduncan/downloads/wine-20050310/dlls/ntdll' make[1]: *** [ntdll] Error 2 make[1]: Leaving directory `/home/jduncan/downloads/wine-20050310/dlls' make: *** [dlls] Error 2 ------------------------------------------------------------- I have tried this as a regualar user and as root. I have tried "./tools/wineinstall". I have tried "make distclean" and then reinstalling. I have tried deleting and recreating the install directory. I am using Gentoo with a linux kernel of 2.6.10 on a dual-Xeon 3.2ghz 64-bit system. Any other ideas would be helpful. Thank you. -------------------- End of forwarded message --------------------

4 3

Re: MSVCRT: implement _chsize
by Alexandre Julliard 30 Mar '05

30 Mar '05

Hans Leidekker <hans(a)it.vu.nl> writes: > int _chsize(int fd, long size) > { > - FIXME("(fd=%d, size=%ld): stub\n", fd, size); > - return -1; > + DWORD cur, pos; > + HANDLE handle; > + BOOL ret = FALSE; > + > + TRACE("(fd=%d, size=%ld)\n", fd, size); > + > + LOCK_FILES(); > + > + handle = msvcrt_fdtoh(fd); > + if (handle != INVALID_HANDLE_VALUE) > + { > + /* save the current file pointer */ > + cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); > + if (cur != INVALID_SET_FILE_POINTER) > + { > + pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); > + if (pos != INVALID_SET_FILE_POINTER) > + ret = SetEndOfFile(handle); > + > + /* restore the file pointer */ > + pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); > + } > + } > + > + UNLOCK_FILES(); > + return ret ? 0 : -1; > } SetFilePointer can return INVALID_SET_FILE_POINTER on success if the current pointer is 0xffffffff, you have to check last error in that case. Also you need to set errno on failure. It may be easier to use _lseek instead of SetFilePointer as it takes care of all that already. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: increase robustness for incorrect api usage
by Alexandre Julliard 30 Mar '05

30 Mar '05

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > When a context is released, the corresponding heap based struct variable is > zero'ed before being released. When the CryptDestroyHash function is called, > the corresponding context is checked if it was already being zero'ed out. > Note that a heap location is read, which has already been released. However, > this only happens in case of incorrect api usage. This is not guaranteed to > work, but it should be more robust. > > I suspect that windows does it in a similar way. Looking at the actual values > of HCRYPTHASH variables shows that those are addresses in WinXP SP2. > Considering this, I think that the only 100% clean way to implement this > behaviour would be to have a list of currently existing hash and key objects > in the context, which then would be marked invalid when the context is > released. I don't think there's any need to go that far, and I doubt Windows does either. The usual way to handle that is to store a magic number in the struct and clear it on destroy; this is more robust than simply zeroing the pointer since even if the block gets reused it's very unlikely that the proper magic number would get restored. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winetest: ask for a tag
by Robert Shearman 30 Mar '05

30 Mar '05

Ferenc Wagner wrote: >ChangeLog: Ask for a tag if one was not given on the command line. > >This patch depends on sizeof(int)==sizeof(char*) for >returning the buffer address from the dialog. If it should >be done differently, please tell me how. > > Use DialogBoxParam. Rob

1 0

Re: MSVCRT: implement _chsize
by Dmitry Timoshkov 30 Mar '05

30 Mar '05

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > int _chsize(int fd, long size) > { > - FIXME("(fd=%d, size=%ld): stub\n", fd, size); > - return -1; > + DWORD cur, pos; > + HANDLE handle; > + BOOL ret = FALSE; > + > + TRACE("(fd=%d, size=%ld)\n", fd, size); > + > + LOCK_FILES(); > + > + handle = msvcrt_fdtoh(fd); > + if (handle == INVALID_HANDLE_VALUE) goto exit; > + > + /* save the current file pointer */ > + cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); > + if (cur == INVALID_SET_FILE_POINTER) goto exit; > + > + pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); > + if (pos == INVALID_SET_FILE_POINTER) goto restore; > + > + ret = SetEndOfFile(handle); > + > +restore: > + /* restore the file pointer */ > + pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); > + > +exit: > + if (ret == FALSE) > + { UNLOCK_FILES(); return -1; } > + else > + { UNLOCK_FILES(); return 0; } > } This a pure coding style comment, just ignore it if you are not agree. In order to avoid goto's (absolutely not needed here IMO) and doubled UNLOCK_FILES(): LOCK_FILES(); handle = msvcrt_fdtoh(fd); if (handle != INVALID_HANDLE_VALUE) { /* save the current file pointer */ cur = SetFilePointer(handle, 0, NULL, FILE_CURRENT); if (cur != INVALID_SET_FILE_POINTER) { pos = SetFilePointer(handle, size, NULL, FILE_BEGIN); if (pos != INVALID_SET_FILE_POINTER) ret = SetEndOfFile(handle); /* restore the file pointer */ pos = SetFilePointer(handle, cur, NULL, FILE_BEGIN); } } UNLOCK_FILES(); return ret ? 0 : -1; -- Dmitry.

1 0

Regression: origin6 crashes with 20050310 (20050211 works)
by Tobias Burnus 30 Mar '05

30 Mar '05

Hello, I try to run a freshly installed Origin6.0 with 20050310, but it shows only the splash window and crashes then. Using the previous release 20050211 it runs just fine. While I don't mind compiling Wine and hunting for the patch which causes this problem, the number of patches is rather huge. Do you have some ideas which can shortcut the regression search? Tobias -------------Working-------------- wine-20050211-1.1.i586.rpm: > wine Origin60.exe fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window width -22 fixme:profile:GetPrivateProfileIntW result may be wrong! fixme:storage:StgCreateDocfile Transacted mode not implemented. fixme:storage:StgCreateDocfile Transacted mode not implemented. [...] ----------Crashing---------------- wine-20050310-0.1.i586.rpm: > wine Origin60.exe fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub fixme:ole:CoRegisterMessageFilter stub err:x11drv:X11DRV_CreateWindow invalid window width -22 fixme:msvcrt:_XcptFilter (-1073741819,0x406db1cc)semi-stub wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x20649124 in 32-bit code (0x40f27ca0). In 32 bit mode. Register dump: [...] Stack dump: [...] Backtrace: =>1 0x40f27ca0 cxx_frame_handler+0x1c0 in msvcrt (0x406db6e4) 2 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406db708) 3 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dba70) 4 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dbabc) 5 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dbb6c) 6 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dbb88) 7 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x406dbf78) 8 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406dbf9c) 9 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dc304) 10 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dc350) 11 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dc400) 12 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dc41c) 13 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x406dc80c) 14 0x40f284d1 MSVCRT__CxxFrameHandler+0x41 in msvcrt (0x406dc830) 15 0x401d9fc1 __wine_call_from_32_regs+0xb5 in ntdll (0x406dcb98) 16 0x40f278c5 __CxxFrameHandler+0x5 in msvcrt (0x406dcbe4) 17 0x401af1b2 EXC_RtlRaiseException+0x1e2 in ntdll (0x406dcc94) 18 0x401cf6cc raise_segv_exception+0x3c in ntdll (0x406dccb0) 19 0x401da030 __wine_call_from_32_restore_regs+0x0 in ntdll (0x40450358) 20 0x00000001 (0x00407244) 21 0x00401970 in origin60 (+0x1970) (0x00401910) 22 0x9090c300 (0x407190b8) 0x40f27ca0 cxx_frame_handler+0x1c0 in msvcrt: movl 0xc(%edi),%eax Modules:[...] +relay output: ---------------------- 000b:Call user32.CallWindowProcA(409def2c,00010084,00000111,050103e9,00010088) ret=5f401ee9 000b:Call window proc 0x409def2c (hwnd=0x10084,msg=WM_COMMAND,wp=050103e9,lp=00010088) 000b:Call window proc 0x5f4019fa (hwnd=0x10066,msg=WM_COMMAND,wp=ffff026e,lp=00010084) 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call user32.GetParent(0001003a) ret=5f401281 000b:Ret user32.GetParent() retval=00000000 ret=5f401281 000b:Call user32.SendMessageA(0001003a,00000111,ffff026e,00010084) ret=5f462ceb 000b:Call window proc 0x5f4019fa (hwnd=0x1003a,msg=WM_COMMAND,wp=ffff026e,lp=00010084) 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.TlsGetValue(00000004) ret=5f401018 000b:Ret kernel32.TlsGetValue() retval=403bc308 ret=5f401018 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.GetLastError() ret=40c82699 000b:Ret kernel32.GetLastError() retval=00000000 ret=40c82699 000b:Call kernel32.TlsGetValue(00000000) ret=40c826a7 000b:Ret kernel32.TlsGetValue() retval=41310098 ret=40c826a7 000b:Call kernel32.SetLastError(00000000) ret=40c826b8 000b:Ret kernel32.SetLastError() retval=00000000 ret=40c826b8 000b:Call kernel32.UnhandledExceptionFilter(406cd50c) ret=40c8f2b8 000b:Call ntdll.NtQueryVirtualMemory(ffffffff,000000b4,00000000,406cd410,0000001c,406cd3cc) ret=40532d52 000b:Ret ntdll.NtQueryVirtualMemory() retval=00000000 ret=40532d52 000b:Call ntdll.RtlImageDirectoryEntryToData(00000000,00000001,00000002,406cd40c) ret=404f6029 000b:Ret ntdll.RtlImageDirectoryEntryToData() retval=00000000 ret=404f6029 000b:Call ntdll.NtCreateEvent(406cd3d8,001f0003,406cd3dc,00000001,00000000) ret=404f5f79 000b:Ret ntdll.NtCreateEvent() retval=00000000 ret=404f5f79 wine: Unhandled exception (thread 000b), starting debugger..

1 1

specified Windows directory not accessible
by Wesley Parish 30 Mar '05

30 Mar '05

I get this response when I try to install the VCToolkit. [wparish@localhost wine-hdd]$ wine ./VCToolkitSetup.exe Warning: the specified Windows directory L"C:\\windows" is not accessible. Warning: the specified System directory L"C:\\windows\\system" is not accessible. Warning: could not find DOS drive for current working directory '/home/wparish/wine-hdd', starting in the Windows directory. wine: cannot find './VCToolkitSetup.exe' What have I missed, or misconfigured? (I'm officially running 20040813, though I compiled and installed 20050211 over it - I hadn't read that I should uninstall the previous wine installation before installing a new one. :) Wesley Parish -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

2 1

Autopackage 1.0
by Boaz Harrosh 29 Mar '05

29 Mar '05

now that Autopackage 1.0 is out does any one plan on a Wine Autopackage installer.

2 1

Regression in winealsa (message only?)
by Paul Vriens 29 Mar '05

29 Mar '05

Hi, after this patch: http://cvs.winehq.org/patch.py?id=16795 the installation of Zoo Tycoon 1 demo shows: ALSA lib control.c:654:(snd_ctl_open_noupdate) Invalid CTL plug:hw:0 my .config: ;"Drivers" = "wineoss.drv" ; default for most common configurations ;"Drivers" = "winearts.drv" ; for KDE "Drivers" = "winealsa.drv" ; for ALSA users ;"Drivers" = "winejack.drv" ; for Jack sound server ;"Drivers" = "winenas.drv" ; for NAS sound system ;"Drivers" = "wineaudioio.drv" ; for Solaris machines ;"Drivers" = "" ; to disable sound sound doesn't seem to be affected. Any idea's if this is serious enough? Paul.

3 5

Progress of work on MSHTML
by Jacek Caban 29 Mar '05

29 Mar '05

Hi. I decided that it's time to write here about my work. I'm working on an implementation of MSHTML using Gecko (Mozilla's engine) API. Results of this work you can see here: http://members.lycos.co.uk/merplayers/wine/ Yes, it is Internet Explorer on Mozilla's engine under Wine! At last... it doesn't work as nice as one can think looking at the picture... but it starts to work. I'd like to do it using Linux Mozilla, but to do it I'd need to pass GtkWidget to Gecko. So AFAIK there is no way to do it in an acceptable way for Wine. If there is, please let me know. Gecko API is based on XPCOM that is quite similar to MSCOM. We cannot use Gecko's headers as they are designed for C++, but I wrote idl files that can be used by widl to generate binary-compatibile headers. Fortunetly, excluding interfaces, we can do everything using only C functions. Currently Wine's implementayion uses Mozilla ActiveX Comtrol. It's enough for some applications using it as replacement of WebBrowser Control, yet I don't know anyone using it as replacement of HTMLDocument (and it won't work as this is control, not document). This code needs a lot of cleanup and I need to remove temporary hacks, but I think it's time to start sending patches. Unfortunetly I'll be out next week and this week I won't have much time. This week I'll send only some simple code, and later will come more. Just wanted let you know:) Jacek

1 0

Re: OLEPICTURE: Initialize [orig|himetric][Width|Height] for PICTYPE_ICON case
by Alexandre Julliard 29 Mar '05

29 Mar '05

Alex Villacis Lasso <a_villacis(a)palosanto.com> writes: > You are right. I did a copy&paste from the SerializeIcon code. What do > you think about this patch? Better, but note that there is a twist with GetIconInfo, if the icon is monochrome the color bitmap is 0 and you then need to get the info from hbmMask and divide the height by 2 (you can always count on Microsoft to design clean and intuitive APIs...) You also need to delete the bitmaps when done. Note also that GetDC(0) is preferable to CreateCompatibleDC, it avoids creating a new DC just to delete it again. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: OLEPICTURE: Initialize [orig|himetric][Width|Height] for PICTYPE_ICON case
by Marcelo Duarte 29 Mar '05

29 Mar '05

Alex Villacis Lasso escreveu: > Alexandre Julliard wrote: > >> >> This seems a bit overkill just to retrieve the bitmap size. Couldn't >> you simply do a GetObject on the bitmap? >> >> >> > You are right. I did a copy&paste from the SerializeIcon code. What do > you think about this patch? > > Changelog: > * Initialize [orig|himetric][Width|Height] for PICTYPE_ICON case ... >+ if(GetObjectA(infoIcon.hbmColor, sizeof(bm), &bm) != sizeof(bm)) { > > Maybe GetObjectW is more consistent (get rid w->A calls)?

1 0

Re: Dragon Naturally Speaking - working.
by Konstantin Goudkov 29 Mar '05

29 Mar '05

I got NS7 working on Debian Sid, after running Sidenet setup on Wine 20050310. It took me a while to figure out that I need to raise the Capture level, not just the Mic volume on ALSA. Without it, it looked like NS (and Wine) didn't not pick up the mic even though I could hear myself on the speakers. Also, sometimes not all buttons are clickable even through they should be, so try "Ctrl-S" during the user setup. -- Konstantin Goudkov

3 3

discusion about a message loop in listview.c
by Dietrich Teickner 29 Mar '05

29 Mar '05

Sorry, this helps Agent 2.0 only with a earlyer try, where I have directly checked the loop inside SendMessageTimeout. After moving this to LISTVIEW_SetItemState only FlashFXP 3.02 works. Agent 2.0 has also a meesageloop (veryfied in Odin), it is not the same as with LISTVIEW_SetItemState. Dietrich

1 0

Re: Resent^2 : Zero out return string in GetMenuStr
by Alexandre Julliard 29 Mar '05

29 Mar '05

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Anything wrong with this patch? > > Changelog: > dlls/user/menu.c: GetMenuStrA|W > Initialize return string as an empty string You need to take the specified length into account before writing to the string. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: OLEAUT32: fix detection of GIF palette index >= 128 for transparency
by Andreas Mohr 29 Mar '05

29 Mar '05

Hi, On Tue, Mar 29, 2005 at 12:43:38PM -0500, Alex Villacis Lasso wrote: > I traced this problem to a one-line bug in the GIF loading code. The > code is supposed to initialize a transparency flag to -1 when no > transparency is used, or else the palette index of the transparency > color. The sample image I was using indicates that the transparency > index is 255. Due to an unintended sign extension, the transparency > index (held in a Byte array of basic type "signed char") is > sign-extended to the variable "transparency" of basic type "signed int". > This causes the flag to be assigned the value -1, which happens to be > the same value used as a no-transparency indicator. So transparency was ....^^^^^^^^^^^^ Heh, 3 times "the transparency" in exactly the same line position, 4 times "transparency" in exactly the same position - what did you smoke?? ;-) (or worse, what did *I* smoke to recognize this?? :-) OK, I promise I'll stop that useless fun email here. Anyway, thanks for all those nice patches, Andreas Mohr

2 1

Re: OLEPICTURE: Initialize [orig|himetric][Width|Height] for PICTYPE_ICON case
by Alexandre Julliard 29 Mar '05

29 Mar '05

Alex Villacis Lasso <a_villacis(a)palosanto.com> writes: > + hdcRef = CreateCompatibleDC(0); > + pInfoBitmap = (BITMAPINFO *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(BITMAPINFOHEADER) + 256 * sizeof(RGBQUAD)); > + pInfoBitmap->bmiHeader.biSize = sizeof(pInfoBitmap->bmiHeader); > + GetDIBits(hdcRef, infoIcon.hbmColor, 0, 0, NULL, pInfoBitmap, DIB_RGB_COLORS); This seems a bit overkill just to retrieve the bitmap size. Couldn't you simply do a GetObject on the bitmap? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: MSVCRT: implement _chsize (RESEND)
by Alexandre Julliard 29 Mar '05

29 Mar '05

Hans Leidekker <hans(a)it.vu.nl> writes: > Anything wrong with this one? > > This should fix apps built with MinGW (bug report 2826). You should at least restore the file position before returning, though it would probably be better to not change the file position at all, this is not thread safe. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: KERNEL: improve stubs for DnsHostnameToComputerName{A,W} (RESEND)
by Dmitry Timoshkov 29 Mar '05

29 Mar '05

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > +BOOL WINAPI DnsHostnameToComputerNameA(LPCSTR hostname, > + LPSTR computername, LPDWORD size) > + for (i = 0; i <= len; i++) > + computername[i] = toupper(hostname[i]); You can't use toupper() from glibc on a name in a Windows encoding. Why not just call a W version to do the job? -- Dmitry.

2 1

BadDrawable and install shield.
by Oliver Stieber 29 Mar '05

29 Mar '05

Hi, I've been having a lot of problems with install shield and BadDrawables. 1: Does anyone know what's causing the problem? 2: Are there any plans to implement XSetErrorHandler and manager the errors better, even if it's an int3 that winedbg can catch. e.g. int myXErrorHandler(Display *display, XErrorEvent *xError){ switch(xError->type){ case BadDrawable: break; default: int3(); return XErrorHandler(NULL); } Xerror = xError->error_code; return 0; /* return value ignored */ } oid setErrorHandler(void){ XSetErrorHandler(myXErrorHandler); } void dosomething(void){ Xerror = 0; SomeXCall(); if(Xerror){ /* call failed, take appropriate action */ } } Some examples are.... http://www.download.com/Aliens-vs-Predator-2-single-player-demo/3000-7563_4… fixme:sync:SetNamedPipeHandleState 0xa8 0xb5bd50d4 (nil) (nil) wine: Unhandled exception (thread 002f), starting debugger... WineDbg starting on pid 0x11 X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 67 (X_PolyRectangle) Resource id in failed request: 0x6200007 Serial number of failed request: 989 Current serial number in output stream: 1049 http://games.softpedia.com/get/Games-Demo/Crazy-Taxi-Demo.shtml X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 62 (X_CopyArea) Resource id in failed request: 0x6000007 Serial number of failed request: 3252 Current serial number in output stream: 3258 http://www.download.com/1503-A-D-The-New-World-demo/3000-7485_4-10228730.ht… fixme:x11drv:X11DRV_SetWindowRgn not supported on other thread window 0x3002e X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 62 (X_CopyArea) Resource id in failed request: 0x5a00007 Serial number of failed request: 3152 Current serial number in output stream: 3158 http://www.download.com/Colin-McRae-Rally-2005-demo/3000-7531_4-10312485.ht… crashes at the end with fixme:propsheet:PROPSHEET_UnImplementedFlags PSH_RTLREADING X Error of failed request: BadDrawable (invalid Pixmap or Window parameter) Major opcode of failed request: 62 (X_CopyArea) Resource id in failed request: 0x6600007 Serial number of failed request: 28770 Current serial number in output stream: 28799 -- ICQ 169222899 MSN oliverthered(a)hotmail.com

2 2

Re: [PATCH] MapiSendMail() implementation
by Andreas Mohr 29 Mar '05

29 Mar '05

Hi, On Mon, Mar 07, 2005 at 11:54:56AM +0100, Jan Schiefer wrote: > This is an attempt of an basic MAPISendMail() implementation. > It does, what is should, it sends mails. > > Much more work is needed especially to clean it up and to implement more > features. ( Getting rid of printf's would be a good point to start... ) You mean much more work such as including mail.c in the patch? :) Andreas Mohr

6 7

Max Payne 2 IDirect3DDevice8Impl_ActiveRender error
by Tom Huckstep 29 Mar '05

29 Mar '05

Max Payne 2 works fine under the latest Wine CVS through all the 2D parts (menus), but as soon as I start a new game and it gets to a 3D bit the screen goes completely blank and I get lots of the following error on my terminal: err:d3d:IDirect3DDevice8Impl_ActiveRender cannot get valides GLXFBConfig for ... Does anyone have any idea why this is? Tom

2 4

Preloader Compiles with Coverage Flags
by Aaron Arvey 29 Mar '05

29 Mar '05

This is handy for when you want to compile entire wine source with gcov coverage analysis enabled. See http://www.winehq.org/hypermail/wine-patches/2005/02/0000.html for more information on how to compile wine with gcov support. Changelog: * loader/preloader.c adds empty __bb_init_func function Signed-off-by: Aaron Arvey <aarvey_at_cs.hmc.edu> Index: loader/preloader.c =================================================================== RCS file: /home/wine/wine/loader/preloader.c,v retrieving revision 1.13 diff -u -3 -p -r1.13 preloader.c --- loader/preloader.c 22 Mar 2005 16:42:25 -0000 1.13 +++ loader/preloader.c 29 Mar 2005 10:51:06 -0000 @@ -143,6 +143,12 @@ struct wld_link_map { ElfW(Addr) l_interp; }; +/* + * The __bb_init_func is an empty function only called when file + * is compiled with gcc flags "-fprofile-arcs -ftest-coverage". + * If using these flags, this function is necessary to compile. + */ +void __bb_init_func(){return;} /* * The _start function is the entry and exit point of this program

2 1

Re: winspool: some unicodification
by Huw D M Davies 29 Mar '05

29 Mar '05

On Tue, Mar 29, 2005 at 12:26:47AM -0500, Dimitrie O. Paun wrote: > ChangeLog > Unicodify WINSPOOL_OpenDriverReg(). > > > Index: dlls/winspool/info.c > =================================================================== > RCS file: /var/cvs/wine/dlls/winspool/info.c,v > retrieving revision 1.101 > diff -u -r1.101 info.c > --- dlls/winspool/info.c 21 Feb 2005 18:33:55 -0000 1.101 > +++ dlls/winspool/info.c 29 Mar 2005 05:23:05 -0000 > @@ -70,8 +70,13 @@ > > static const char Printers[] = > "System\\CurrentControlSet\\control\\Print\\Printers\\"; > -static const char Drivers[] = > -"System\\CurrentControlSet\\control\\Print\\Environments\\%s\\Drivers\\"; > + > +static const WCHAR DriversW[] = { 'S','y','s','t','e','m','\\','\\', > + 'C','u', 'r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\','\\', > + 'c','o','n','t','r','o','l','\\','\\', > + 'P','r','i','n','t','\\','\\', > + 'E','n','v','i','r','o','n','m','e','n','t','s','\\','\\', > + '%','s','\\','\\','D','r','i','v','e','r','s','\\','\\',0 }; > That's not quite right. I guess you need to tweak your unicodification macro ;-) Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: KERNEL32: implement CallNamedPipe
by Dmitry Timoshkov 29 Mar '05

29 Mar '05

"Mike McCormack" <mike(a)codeweavers.com> wrote: > ChangeLog: > * implement CallNamedPipe > + handle = CreateFileW( lpNamedPipeName, GENERIC_READ|GENERIC_WRITE, > + 0, NULL, OPEN_EXISTING, 0, NULL ); > + if( !handle ) > + return FALSE; CreateFile returns INVALID_HANDLE_VALUE on failure. -- Dmitry.

1 0

Re: Patch
by Dmitry Timoshkov 29 Mar '05

29 Mar '05

"Leonardo Krause" <leonardo.krause(a)serpro.gov.br> wrote: > + if ( ((keysym == 0xFF9F) || (keysym == 0x2C)) && (e->state & NumLockMask)) > + { > + if (keysym == 0xFF9F) > + return nonchar_key_vkey[keysym & 0xFF]; > + if (keysym == 0x2C) > + return keyc2vkey[0x3B]; > + } You need to at least use appropriate symbolic names instead of vague numbers. -- Dmitry.

1 0

Re: version: Use proper type for third parameter of VerQueryValue
by Dmitry Timoshkov 29 Mar '05

29 Mar '05

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * Use proper type for third parameter of VerQueryValue > -DWORD WINAPI VerQueryValueA(LPVOID,LPCSTR,LPVOID*,UINT*); > -DWORD WINAPI VerQueryValueW(LPVOID,LPCWSTR,LPVOID*,UINT*); > +BOOL WINAPI VerQueryValueA(const LPVOID,LPCSTR,UINT*,UINT*); > +BOOL WINAPI VerQueryValueW(const LPVOID,LPCWSTR,UINT*,UINT*); Where did you get it? PSDK agrees with current Wine definition on the 3rd param type. Also the 2nd param should not be 'const'. -- Dmitry.

3 3

AW: Hotel full again?
by Hans-Ulrich Schmid 29 Mar '05

29 Mar '05

Hi, there are only three rooms left in the Telekom Hotel (Mail adress: Rezeption.Tagungshotel-Stuttgart(a)telekom.de ) from April 29 - May 1. There is no way to get room there for April 28. The alternatives are: IB-HOTEL AM WALLGRABEN ib-hotel-stuttgart(a)internationaler-bund.de ++49.711-7876100 http://dsw.nethotels.com/smg/english/Hotels/ib_hotel_am_wallgraben_/default… Hotel Römerhof info(a)hotelroemerhof.de ++49.711-687880 http://www.hotelroemerhof.de/english/index.html See you in Stuttgart Hans-Ulrich Schmid Wirtschaftsförderung Region Stuttgart GmbH Stuttgart Region Economic Development Corporation FIR_st - Forum IT-Region Stuttgart Friedrichstr. 10 70174 Stuttgart www.first.region-stuttgart.de www.opensource.region-stuttgart.de www.competenzatlas.de www.region-stuttgart.de Tel ++49.711.22835 - 27 Tel mobil ++49.172.7310463 Fax ++49.711.22835 - 55 > -----Ursprüngliche Nachricht----- > Von: Andrew Bartlett [mailto:abartlet@samba.org] > Gesendet: Freitag, 25. März 2005 22:59 > An: Hans-Ulrich Schmid > Cc: wine-devel(a)winehq.org > Betreff: Hotel full again? > > > I tried to book a double room 28th April -> 1st May (sharing with > tridge), and it seems the hotel is all full again :-( > > There seems to be quite a contingent of Samba folk intending to come > along (from a poll on the samba team list), and given the number of > 'maybe' and 'probably' replies, I suspect I'm not the only > one without a > room... > > Andrew Bartlett > -- > Andrew Bartlett > http://samba.org/~abartlet/ > Authentication Developer, Samba Team http://samba.org > Student Network Administrator, Hawker College http://hawkerc.net >

1 0

Wine on slashdot
by Jonathan Ernst 29 Mar '05

29 Mar '05

http://games.slashdot.org/games/05/03/28/1843246.shtml?tid=203&tid=106 "WineCVS is an extensive script for automated installation of different versions of wine and Cedega. Today it has been updated to support wine installation with latest DX9 features. The latest patch level of the script now includes a profile for installing Wine with Oliver Stiebers Direct3D 9 patchset. A short installation instruction and some more detailed information can be found at linux-gamers.net."

2 1

Japanese 106 keyboard mapping bug + patch
by Aric Cyr 29 Mar '05

29 Mar '05

I was having a mysterious problem with my Japanese 106 keyboard in World of Warcraft. The keyboard worked just fine when logging into the game or typing messages in game, etc. However, using the macro keys for the quickbar (1 2 3 ... 0) each of the keys was off by one. The keys were mapped as: 1 = 1 2 = 1 3 = 2 4 = 3 5 = 4 ... Notice that the 1 and 2 key both mapped to one, and every key after that maps to the previous key. This only occured for the top keyboard row and text input fields all worked correctly (which was the mysterious part). Anyways, I tracked down the problem to the keyboard layout for jp106 in the x11drv/keyboard.c. For Japanese keyboards, the first printable character on the keyboard is '1' (as the shown in the main_key_JA_jp106[MAIN_LEN][4] array). However, the jp106 keyboard is defined to use the regular qwerty scan and vkey maps, which seem to define the first key as OEM, not '1'. I believe this was causing my off-by-one key problem, so created a new jp106 qwerty scan and vkey map to fix the problem. I have tested the patch with World of Warcraft, and indeed my keys are now all mapped correctly. I am not familiar with the keyboard stuff too much, so let me know if there are any problems with the patch, otherwise please commit it. I also created a bug for this, and attached the patch there as well: http://bugs.winehq.org/show_bug.cgi?id=2832 -- Aric Cyr <acyr at alumni dot uwaterloo dot ca> (http://acyr.net) gpg fingerprint: 943A 1549 47AC D766 B7F8 D551 6703 7142 C282 D542

1 0

Re: KERNEL: Implement undocumented SetCPGlobal API call
by James Hawkins 29 Mar '05

29 Mar '05

On Tue, 29 Mar 2005 11:37:43 +1100, Troy Rollo <wine(a)troy.rollo.name> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) A patch would be good :) -- James Hawkins

1 0

Re: KERNEL: Implement undocumented SetCPGlobal API call
by James Hawkins 29 Mar '05

29 Mar '05

On Tue, 29 Mar 2005 11:37:43 +1100, Troy Rollo <wine(a)troy.rollo.name> wrote: > SetCPGlobal is the undocumented partner of GetACP - it is used to set the > current ANSI code page. > > ChangeLog: > Implement SetCPGlobal (an undocumented Win32 API) A patch would be good :) -- James Hawkins

1 0

advapi: remove signature checking code.
by Michael Jung 28 Mar '05

28 Mar '05

Hi, Microsoft signs it's cryptographic service provider (csp) dlls with a private key. advapi32 will only load csp dlls with a valid signature. We will never be able to implement this, since this would mean having access to Microsoft's private keys. Above this, Microsofts scheme doesn't give real security, since there are instructions on the web to replace advapi32's _NSAKEY with an arbitrary private key (this is if you have write access to advapi32.dll), allowing you to load a csp signed by yourself. I would like to remove the (stubbed) signature checking code from advapi32. This would clean up advapi32 somewhat and remove a FIXME message, which bothers me for some time and which confused wine users in at least two occurences. Comments anyone? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: msi:Fix Typelib Registration
by Huw D M Davies 28 Mar '05

28 Mar '05

On Mon, Mar 28, 2005 at 10:39:48AM -0600, Aric Stewart wrote: > make sure the GUID of the typelib we are registering matches the guid > requested from MSI. if not search the given typelib file to find the > typelib requested to register. > > > Index: dlls/msi/action.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/action.c,v > retrieving revision 1.105 > diff -u -r1.105 action.c > --- dlls/msi/action.c 28 Mar 2005 14:17:52 -0000 1.105 > +++ dlls/msi/action.c 28 Mar 2005 16:33:23 -0000 > @@ -4097,7 +4101,39 @@ > continue; > } > > + guid = load_dynamic_stringW(row,1); > res = LoadTypeLib(package->files[index].TargetPath,&ptLib); > + ITypeLib_GetLibAttr(ptLib, &attr); > + CLSIDFromString(guid, &clsid); > + if (!IsEqualGUID(&clsid,&attr->guid)) > + { > + static const WCHAR fmt[] = {'%','s','\\','%','i',0}; > + int i; > + int sz; > + > + TRACE("Initial match failure\n"); > + > + sz = strlenW(package->files[index].TargetPath)+4; > + sz *= sizeof(WCHAR); > + > + for (i = 2; i < 10; i++) > + { > + path = HeapAlloc(GetProcessHeap(),0,sz); > + sprintfW(path,fmt,package->files[index].TargetPath, i); > + TRACE("trying %s\n", debugstr_w(path)); > + res = LoadTypeLib(path,&ptLib); > + ITypeLib_GetLibAttr(ptLib, &attr); > + CLSIDFromString(guid, &clsid); > + if (IsEqualGUID(&clsid,&attr->guid)) > + break; > + HeapFree(GetProcessHeap(),0,path); > + res = E_FAIL; > + > + } > + } > + else > + path = strdupW(package->files[index].TargetPath); > + > if (SUCCEEDED(res)) > { > LPWSTR help; This doesn't look right. Maybe you need to enumerate through the typelib resources here. What information are you actually given? You're also leaking ITypeLibs and TLIBATTRs Huw.

1 0

Re: [dlls/msi/*] Strncpy elimination.
by Jakob Eriksson 28 Mar '05

28 Mar '05

Good thing you sent these patches. I was just thinking, should I dig in? :-) Peter Berg Larsen wrote: >I have been checking the usage of strncpy, replacing where apropriate with >a memcpy or lstrcpyn[AW]. The first raw diff was 100kb, so there is bound >to be one or two slips. These are the first batch which I found to be >obvious, correct, and didnt need a special comment. Note with correct I >mean if there was a \0 bug before then it still there. > >Changelog: > Janitorial Task: Check the usage of strncpy/strncpyW. > >Index: dlls/msi/action.c >=================================================================== >RCS file: /home/wine/wine/dlls/msi/action.c,v >retrieving revision 1.104 >diff -u -r1.104 action.c >--- dlls/msi/action.c 24 Mar 2005 21:01:38 -0000 1.104 >+++ dlls/msi/action.c 26 Mar 2005 09:40:49 -0000 >@@ -922,7 +922,7 @@ > while (*ptr == ' ') ptr++; > len = ptr2-ptr; > prop = HeapAlloc(GetProcessHeap(),0,(len+1)*sizeof(WCHAR)); >- strncpyW(prop,ptr,len); >+ memcpy(prop,ptr,len*sizeof(WCHAR)); > prop[len]=0; > ptr2++; > >@@ -942,7 +942,7 @@ > len -= 2; > } > val = HeapAlloc(GetProcessHeap(),0,(len+1)*sizeof(WCHAR)); >- strncpyW(val,ptr2,len); >+ memcpy(val,ptr2,len*sizeof(WCHAR)); > val[len] = 0; > > if (strlenW(prop) > 0) >Index: dlls/msi/dialog.c >=================================================================== >RCS file: /home/wine/wine/dlls/msi/dialog.c,v >retrieving revision 1.9 >diff -u -r1.9 dialog.c >--- dlls/msi/dialog.c 24 Mar 2005 15:09:31 -0000 1.9 >+++ dlls/msi/dialog.c 26 Mar 2005 09:40:51 -0000 >@@ -131,7 +131,7 @@ > ret = HeapAlloc( GetProcessHeap(), 0, len*sizeof(WCHAR) ); > if( !ret ) > return ret; >- strncpyW( ret, p, len ); >+ memcpy( ret, p, len*sizeof(WCHAR) ); > ret[len-1] = 0; > return ret; > } >Index: dlls/msi/format.c >=================================================================== >RCS file: /home/wine/wine/dlls/msi/format.c,v >retrieving revision 1.8 >diff -u -r1.8 format.c >--- dlls/msi/format.c 16 Mar 2005 11:31:35 -0000 1.8 >+++ dlls/msi/format.c 26 Mar 2005 09:40:51 -0000 >@@ -252,7 +252,7 @@ > *key = HeapAlloc(GetProcessHeap(),0,i*sizeof(WCHAR)); > /* do not have the [] in the key */ > i -= 1; >- strncpyW(*key,&(*mark)[1],i); >+ memcpy(*key,&(*mark)[1],i*sizeof(WCHAR)); > (*key)[i] = 0; > > TRACE("Found Key %s\n",debugstr_w(*key)); > > > >

3 3

Re: [libs/wine/*] Strncpy elimination.
by Alexandre Julliard 28 Mar '05

28 Mar '05

Peter Berg Larsen <pebl(a)math.ku.dk> writes: > Changelog: > Janitorial Task: Check the usage of strncpy/strncpyW. You can't use lstrcpynA in the libs/ directory, you have to stick to Unix APIs. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: DDRAW: Surface locking patch, take 2
by Matthew Mastracci 28 Mar '05

28 Mar '05

Matthew Mastracci wrote: > This patch (correctly) fixes the locking problems in SimCity 3000. We > now check to see if the blit src and dest are the same surface and, if > so, we make sure to lock the surface only once and, in the case of > BltFast, re-adjust the surface pointers. This patch also makes sure the > surfaces are correctly unlocked if a bad rectangle is passed. > > ChangeLog > Correctly lock and unlock surface for a single-surface Blt() and > BltFast() call. I'm just pinging the list ot see if there's any reason why this patch hasn't been applied yet. AFAIK, it takes into account all the feedback received so far. Let me know how I can fix it if there is an issue. :) Matt.

2 1

Re: dbghelp: better module support
by Eric Pouech 28 Mar '05

28 Mar '05

Eric Pouech a écrit : > minidumps now contain more accurate information about modules, > especially information that will allow when reloading a minidump in a > debugger to check whether we're using the right modules (ELF & PE) > implemented also check for this information in SymFindFileInPath > A+ Please use this version instead (the previous had an un-wanted statement) A+ -- Eric Pouech

1 0

dbghelp: small fixes
by Eric Pouech 28 Mar '05

28 Mar '05

this patch fixes a couple of bugs in dbghelp A+ -- Eric Pouech

1 0

Re: OLE32, compositemoniker: remove function prototypes, make functions static
by James Hawkins 28 Mar '05

28 Mar '05

On Mon, 28 Mar 2005 14:48:40 +0900, Mike McCormack <mike(a)codeweavers.com> wrote: > > There's more work like this to be done. Anybody want to help out? > > Mike > > ChangeLog: > * remove function prototypes, make functions static Candidate for a janitorial project? :) -- James Hawkins

2 1

Re: Implementation of EnumMoniker and Partial impl on MkParseDisplayName
by Mike McCormack 28 Mar '05

28 Mar '05

Hi Jeff, Jeff Latimer wrote: > This is the first installment of the implementation of > MkParseDisplayName. I would like feed back on style and usage. > > I think the implementation of the EnumMoniker interface looks ok. > Comments appreciated. I like that you've taken the time to write a test case! I don't know alot about monikers, but seeing that you've tested it gives me confidence... The following comments are a crash course in Wine programming... > +/*********************************************************************** > + * EnmumMoniker_Next > + */ > +HRESULT WINAPI EnumMonikerImpl_Next(IEnumMoniker* iface, ULONG celt, IMoniker** rgelt, ULONG * pceltFetched) > +{ > +// DWORD i; > +// ULONG ref; We avoid C++ comments in Wine code to keep compatability with older compilers. > + EnumMonikerImpl *This = (EnumMonikerImpl *)iface; > + TRACE("(%p) currentPos %d Tablastindx %d\n",This, (int)This->currentPos, (int)This->TabLastIndx); > + ULONG i; You declared "i" above, but commented it out. Try avoid putting dead code in comments. If code isn't compiled, it will become stale and confuse people. > + rc = CoGetMalloc(1, (LPMALLOC *) &ppMalloc); > if (!(IsValidInterface((LPUNKNOWN) pbc))) > return E_INVALIDARG; > + usernamelen = (int) lstrlenW(szUserName); // overall string len > + > > + if (szUserName[char_cnt] == (WCHAR) '@') { // This is a progid not a file name That's alot of casts. I don't think you really need that many, do you? > + /* retrieve the requested number of moniker from the current position */ > + for(i=0;((This->currentPos < This->TabLastIndx) && (i < celt));i++) > + rgelt[i]=(IMoniker*)This->TabMoniker[This->currentPos++].pmkObj; Better to avoid tabs... and too many brackets. A space or two extra in the for( i=0; (This->... might make things look better. > + if (szUserName[char_cnt] == '/' || > + szUserName[char_cnt] == '?' || > + szUserName[char_cnt] == '<' || > + szUserName[char_cnt] == '>' || > + szUserName[char_cnt] == '*' || > + szUserName[char_cnt] == '|' || > + szUserName[char_cnt] == ':') Maybe that can be shortened to : if (strchr("/?<>*|:",szUserName[char_cnt])) > + todo_wine { ok(hr==0x800401e4, "MkParseDisplayName - Progid not implemented hr=%08x\n", (int) hr); } 0x800401e4 is defined as MK_E_SYNTAX. It would be clearer to use the define rather than a number. %08lx is probably what you want instead of casting hr to (int) to get rid of the printf parameter type warning. > + > + IBindCtx_Release(pbc); > + > + /* A bad drive */ > + static const WCHAR wszDisplayName2[] = {'1',':','s','i','d',':', > '2','0','D','0','4','F','E','0','-','3','A','E','A','-','1','0','6','9','-','A','2','D','8','-','0','8','0','0','2','B','3','0','3','0','9','D',':',0}; Again, for compatability, we avoid inline declarations, even though gcc can deal with them fine. Mike

1 0

Re: Two small scrollbar fixes
by Alexandre Julliard 28 Mar '05

28 Mar '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > dlls/user : scroll.c > dlls/user/tests : win.c > > - GetScrollRange should return an empty range, both upper and lower > limit zero, if the window has no scrollbars (msdn); > - GetScrollInfo's return value is FALSE if the window has no scrollbars; This breaks the message test: msg.c:2761: Test failed: GetScrollInfo error 5 msg.c:2761: Test failed: GetScrollInfo error 5 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Add a stdole2 typelib
by Huw D M Davies 28 Mar '05

28 Mar '05

On Sun, Mar 27, 2005 at 11:43:34PM -0500, Vincent Béron wrote: > Robert, Huw: Do you have something else to add before this one goes in, > or is Wine ready for it? > > Huw: I had to name the enum at line 181, else I'd get a SIGSEGV in widl. > Would you mind trying to make it accept > > typedef enum { > foo > } BAR; > > instead of > > typedef enum BAR { > foo > } BAR; > > please? Hi Vincent, Sorry I got distracted with other things before I had a chance to finish off the work on stdole2. I'll see if I can knock up something to get these typedefs to work. One remaining issue is the dispinterface FontEvents that is part of coclass StdFont and yet is not defined until right at the end of the typelib. There isn't a clean way to do this in idl and still maintain the original order of the typeinfos - it's clear that the native stdole2 is generated by a program rather than from idl. I guess we could introduce a Wine specific attribute that allows us to hack around this... Huw.

1 0

Encoding PSP movies with Wine.
by Joshua Walker 28 Mar '05

28 Mar '05

Encoding PSP movies with wine. Well, the Sony Playstation Portable (PSP) is out in the U.S, and one of the cool things you can do with it is encode movies for playback on the system. Sony hasn't released their encoder yet, but you can use a program called ffmpeg to convert videos to the quirky PSP Mpeg4 format... ...kinda The Linux version of ffmpeg can encode PSP movies, however the id tag is hardcoded, and you don't get any data about the Name of the movie or it's length or anything. (It's just called "-" in the browser. You have to pull from the cvs version, the homepage is here... http://ffmpeg.sourceforge.net/index.php There is a Japanese fork of ffmpeg for win32. As it's GPLed software, the source was released. This includes all kinds of cool hacks for better streaming and also support for the ID tag for the PSP. Sadly, the id tags require Unicode, (As it's a Japanese machine) , and the hack involves a call to MultiByteToWideChar() to convert the title to something the PSP can display. Last night I tried to backport the hack to the Linux version using mbtowc() and failed horribly. My code-fu is much too weak. The Japanese fork is here http://www.nurs.or.jp/~calcium/3gpp/sources/ffmpeg-050310-0.30.tar.gz and a patch to update it to .31 http://www.nurs.or.jp/~calcium/3gpp/sources/ffmpeg_patched_diff_031.tar.gz You can also grab a compiled win32 version here. http://www.nurs.or.jp/~calcium/3gpp/3GP_Converter031.zip The program is located in the /cores dir. So, I as I couldn't "fix" the Linux version, I gave wine a spin and came up dead in the water. I'm afraid I don't have the debug version of wine installed, but here's what I can give you as output halkun@dokkun:~/temp/3GP_Converter031/cores> wine ./ffmpeg.exe fixme:ver:VERSION_GetLinkedDllVersion Unknown EXE OS version 4.0, please report !! err:comm:GetCommState tcgetattr or ioctl error 'Invalid argument' fixme:ntdll:NtQueryObject Unsupported information class 1 fixme:ntdll:NtQueryObject Unsupported information class 1 fixme:ntdll:NtQueryObject Unsupported information class 1 Segmentation fault halkun@dokkun:~/temp/3GP_Converter031/cores> Well, ending on a segfault is pretty much writes that program off the list. I'm also noticing it's calling an undocumented function in ntdll. Anyone want to take a go at this to see what's happening? It would be nice to get PSP encoding to work right under Linux. Oh, my version of wine is 20050310. -Halkun

1 0

saving winrash
by Ivan Leo Puoti 28 Mar '05

28 Mar '05

Hello all, currently winrash users aren't returning any results from their testing. This is because we need tests to run on a visible desktop, better still in interactive mode. To save both the tests and winrash we need winrash to be somewhat similar to windows automatic updates, when new tests are available, winrash should pop up and say "new tests are available, run now?" and then give a yes/no, later option. Like this we can have interactive tests, and use winrash so people don't have to remember to download/run the tests. I do it but downloading the exe manually/opening a command line in the desktop/running the tests with the -t option/deleting the test.exe file isn't exactly user friendly. Maybe this task should go in the todo list, or should at least go on the web site somewhere, it would be an attractive task for newcomers with windows programming experience. Ivan.

6 9

Personal Family Assistant setup problem
by Andrew Neil Ramage 28 Mar '05

28 Mar '05

Trying to install PAF 5.1 produced these results. There was also a message box stating that the InstallShield engine could not be started. [andrew@localhost Default]$ wine PAF5EnglishSetup.exe fixme:ole:RegisterTypeLib Registering non-oleautomation interface! fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects fixme:ole:ITypeInfo_fnRelease destroy child objects err:ole:_get_funcdesc Did not find a typeinfo for reftype 0? err:ole:xCall Did not find typeinfo/funcdesc entry for method 0! err:ole:CoUnmarshalInterface Couldn't query for interface {91814ebf-b5f0-11d2-80b9-00104b1f6cea}, hr = 0x80004005 err:ole:_get_funcdesc Did not find a typeinfo for reftype 0? err:ole:xCall Did not find typeinfo/funcdesc entry for method 2! fixme:ole:CFProxy_CreateInstance CoMarshalInterface failed, 80004005 fixme:ole:CoCreateInstance no instance created for interface {91814ebf-b5f0-11d2-80b9-00104b1f6cea} of class {91814ec0-b5f0-11d2-80b9-00104b1f6cea}, hres is 0x80004005 [andrew@localhost Default]$ -- Andrew "Someone set a bad example makes surrender seem alright; The act of a noble warrior who's lost the will to fight And now you're trembling on a rocky ledge Staring out into a heartless sea Facing life on a razor's edge Nothing's what you thought it would be." ----------- Rush, The Pass (Presto, 1989)

2 1

Re: Rename the process back to wine on 2.6 kernels
by Boaz Harrosh 27 Mar '05

27 Mar '05

Mike Hearn wrote: >This makes us appear as "wine" again on 2.6 kernels, instead of appearing as >/usr/bin/wine-preloader. It works in ps, top, and killall which are the most >important. On kernels that don't support it, we will still appear as >wine-preloader though. > >If this patch is accepted I might do another to move the [pk]thread switch >into an env var instead of the command line. Then we'd be back to >"wine foobar.exe" just like the good old days ;) > > A "not so far" back, there was a patch that enabled embedding of the wineloader into the Winelib stub of a Winelib application. (That would than load itself). How would that patch affect these applications? Free Life Boaz

1 0

Re: ScrollWindow fix for windows with WS_CLIPCHILDREN style, with tests
by Dmitry Timoshkov 27 Mar '05

27 Mar '05

"Rein Klazes" <wijn(a)wanadoo.nl> wrote: > - hDC = GetDCEx( hwnd, 0, DCX_CACHE | DCX_USESTYLE ); > + if( !(flags & SW_SCROLLCHILDREN && > + GetWindowLongPtrW( hwnd, GWL_STYLE) & WS_CLIPCHILDREN)) Window style is a 32-bit entity in both Win32 and Win64, there is no need to use GetWindowLongPtr to retrieve it, GetWindowLong should work just fine. -- Dmitry.

1 0

visual regression in IE
by Joris Huizer 26 Mar '05

26 Mar '05

Hello, I tried to search for information on regressions on the winehq site but I couldn't find it (maybe it should be made visible on the documentation page?) Anyway, in internet explorer a visual regression happened: with my previous cvs build from 15 march, things were displayed correctly, but now (cvs build from 23 march) the 'address' and the 'links' fields are displayed incorrectly: they are bigger than they should be, and they are 'striked through' which should not happen; See also the attached screenshots - I'm sure it's clear what I mean; Could someone point me to the correct pages to find out what caused this? I'm sure someone will be fix this a lot faster than I could do but I want to learn how to solve such a problem :) regards, Joris

5 6

World of Warcraft: fixed?
by cyrix12＠cox.net 26 Mar '05

26 Mar '05

I applied the two patches from bugzilla (http://bugs.winehq.org/show_bug.cgi?id=2814#c8) which includes Raphael's opengl32 fbconf patch and another one from Tim Savannah which looks like this: --- wine2/dlls/x11drv/opengl.c 2005-03-24 20:51:16.000000000 -0500 +++ wine/dlls/x11drv/opengl.c 2005-03-24 20:50:14.000000000 -0500 @@ -268,9 +268,8 @@ if ((iPixelFormat > MAX_PIXELFORMATS) || (iPixelFormat > physDev->used_visuals + 1) || (iPixelFormat <= 0)) { - ERR("Wrong pixel format !\n"); - /* Should set error */ - return 0; + ERR("Wrong pixel format, trying default. !\n"); + iPixelFormat = physDev->used_visuals + 1; } if (iPixelFormat == physDev->used_visuals + 1) { I note two things when using these patches: 1) WoW works. Game loads and runs again. 2) The login/character select screen will occasionally be extremely choppy/slow. Sometimes it happens, sometimes it doesn't, and there seems to be no direct cause from what I can tell since the traces are identical. Once in the game it performs nicely from what I've seen, so it's really just a minor irritation. Some, however, have reported that these two patches don't solve the problem. As I am not one of those, I am unable to provide traces/details on this. If I find any issues occurring regularly on my end, I'll send in the appropriate info so that you guys can take a look at it. Thanks for the swift fixes! Darckness

2 2

"Black" Text
by Ian Bartelds! 26 Mar '05

26 Mar '05

Hey guy's my first time asking for support on wine so I will try and make it a quick one. Now I am having troubles with colours in text and behind text. I am trying to get a game to run correctly it's a MMORPG called legend of mir, now everything runs fine but the text box where you send and recieve messages all the "colors" behind the text is black all of the text is black is this a bug in wine? Thanks Kozuka P.S. Here's a screenshot so you can see what I am talking about wine doesn't return any errors.. http://img222.exs.cx/my.php?loc=img222&image=images049iv.jpg

9 13

Not Wine but
by Wesley Parish 26 Mar '05

26 Mar '05

has anyone seen the other Windows "emulator-cross-platform" library Twin around lately? I'm getting into Windows programming with theForger's Win32 Tutorial - got a personal project I want to fool around with - and while Winelib is a very satisfactory Win32 API library on Linux, I was wanting to have Yet Another Cross-Platform Implementation Thereof to test it against. I've just been hunting for it and www.willows.com seems to have vainshed off the face of the 'Net. Any ideas? Thanks Wesley Parish -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

2 1

BitTorrent
by Andrew Neil Ramage 26 Mar '05

26 Mar '05

Following up from the last message, when I tried to move beyond the stage described, I get the following: next Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:1e04e00f ESP:406ee804 EBP:406ee860 EFLAGS:00210246( - 00 -RIZP1) EAX:00000000 EBX:00000002 ECX:ffffffff EDX:a93c6858 ESI:406ee860 EDI:a93c6858 Stack dump: 0x406ee804: 4131a118 00000000 00000002 1e04dd4c 0x406ee814: 406ee860 406ee868 1e09ca68 406ee860 0x406ee824: 41300a64 00000000 1e04de36 406ee860 0x406ee834: 406ee868 00000029 00000002 1e0bcd75 0x406ee844: 00000029 1e09ca68 412b35e8 00000000 0x406ee854: 1e04dbec 406ee860 406ee868 1e0bcd76 Backtrace: =>1 0x1e04e00f PyCFunction_Call in python22 (0x406ee860) 2 0x1e04db8f PyCFunction_Call in python22 (0x1e0bcd76) 3 0x61640000 (0x0000297a) 4 0x00000000 (0x00000000) 0x1e04e00f PyCFunction_Call+0xc2f in python22: repne scasb %es:(%edi) Wine-dbg>First chance exception: page fault on read access to 0xa93c6858 in 32-bit code (0x1e04e00f). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:1e04e00f ESP:406ee804 EBP:406ee860 EFLAGS:00210246( - 00 -RIZP1) EAX:00000000 EBX:00000002 ECX:ffffffff EDX:a93c6858 ESI:406ee860 EDI:a93c6858 Stack dump: 0x406ee804: 4131a118 00000000 00000002 1e04dd4c 0x406ee814: 406ee860 406ee868 1e09ca68 406ee860 0x406ee824: 41300a64 00000000 1e04de36 406ee860 0x406ee834: 406ee868 00000029 00000002 1e0bcd75 0x406ee844: 00000029 1e09ca68 412b35e8 00000000 0x406ee854: 1e04dbec 406ee860 406ee868 1e0bcd76 Backtrace: =>1 0x1e04e00f PyCFunction_Call in python22 (0x406ee860) 2 0x1e04db8f PyCFunction_Call in python22 (0x1e0bcd76) 3 0x61640000 (0x0000297a) 4 0x00000000 (0x00000000) 0x1e04e00f PyCFunction_Call+0xc2f in python22: repne scasb %es:(%edi) Wine-dbg> Andrew "Someone set a bad example makes surrender seem alright; The act of a noble warrior who's lost the will to fight And now you're trembling on a rocky ledge Staring out into a heartless sea Facing life on a razor's edge Nothing's what you thought it would be." ----------- Rush, The Pass (Presto, 1989)

2 1

BitTorrent
by Andrew Neil Ramage 26 Mar '05

26 Mar '05

I tried downloading the BitTorrent client from [url] and executin -- Andrew "Someone set a bad example makes surrender seem alright; The act of a noble warrior who's lost the will to fight And now you're trembling on a rocky ledge Staring out into a heartless sea Facing life on a razor's edge Nothing's what you thought it would be." ----------- Rush, The Pass (Presto, 1989) [andrew@zeus andrew]$ wine $C/"Program Files"/BitTorrent/btdownloadgui.exe fixme:msvcrt:MSVCRT_signal (1 0x1):stub fixme:msvcrt:MSVCRT_signal (1 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (2 0x1):stub fixme:msvcrt:MSVCRT_signal (2 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (3 0x1):stub fixme:msvcrt:MSVCRT_signal (3 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (4 0x1):stub fixme:msvcrt:MSVCRT_signal (4 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (5 0x1):stub fixme:msvcrt:MSVCRT_signal (5 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (6 0x1):stub fixme:msvcrt:MSVCRT_signal (6 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (7 0x1):stub fixme:msvcrt:MSVCRT_signal (7 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (8 0x1):stub fixme:msvcrt:MSVCRT_signal (8 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (9 0x1):stub fixme:msvcrt:MSVCRT_signal (9 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (10 0x1):stub fixme:msvcrt:MSVCRT_signal (10 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (11 0x1):stub fixme:msvcrt:MSVCRT_signal (11 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (12 0x1):stub fixme:msvcrt:MSVCRT_signal (12 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (13 0x1):stub fixme:msvcrt:MSVCRT_signal (13 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (14 0x1):stub fixme:msvcrt:MSVCRT_signal (14 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (15 0x1):stub fixme:msvcrt:MSVCRT_signal (15 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (16 0x1):stub fixme:msvcrt:MSVCRT_signal (16 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (17 0x1):stub fixme:msvcrt:MSVCRT_signal (17 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (18 0x1):stub fixme:msvcrt:MSVCRT_signal (18 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (19 0x1):stub fixme:msvcrt:MSVCRT_signal (19 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (20 0x1):stub fixme:msvcrt:MSVCRT_signal (20 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (21 0x1):stub fixme:msvcrt:MSVCRT_signal (21 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (22 0x1):stub fixme:msvcrt:MSVCRT_signal (22 0xffffffff):stub fixme:msvcrt:_XcptFilter (-1073741819,0x406de3c4)semi-stub wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0xa93c6858 in 32-bit code (0x1e04e00f). In 32 bit mode. Second try [andrew@zeus andrew]$ WINEDEBUG=all [andrew@zeus andrew]$ winedbg $C/"Program Files"/BitTorrent/btdownloadgui.exe WineDbg starting on pid 0xa In 32 bit mode. 0x405045d2 start_process+0x102 in kernel32: jmp 0x405045c1 start_process+0xf1 in kernel32 Wine-dbg>next fixme:msvcrt:MSVCRT_signal (1 0x1):stub fixme:msvcrt:MSVCRT_signal (1 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (2 0x1):stub fixme:msvcrt:MSVCRT_signal (2 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (3 0x1):stub fixme:msvcrt:MSVCRT_signal (3 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (4 0x1):stub fixme:msvcrt:MSVCRT_signal (4 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (5 0x1):stub fixme:msvcrt:MSVCRT_signal (5 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (6 0x1):stub fixme:msvcrt:MSVCRT_signal (6 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (7 0x1):stub fixme:msvcrt:MSVCRT_signal (7 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (8 0x1):stub fixme:msvcrt:MSVCRT_signal (8 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (9 0x1):stub fixme:msvcrt:MSVCRT_signal (9 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (10 0x1):stub fixme:msvcrt:MSVCRT_signal (10 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (11 0x1):stub fixme:msvcrt:MSVCRT_signal (11 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (12 0x1):stub fixme:msvcrt:MSVCRT_signal (12 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (13 0x1):stub fixme:msvcrt:MSVCRT_signal (13 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (14 0x1):stub fixme:msvcrt:MSVCRT_signal (14 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (15 0x1):stub fixme:msvcrt:MSVCRT_signal (15 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (16 0x1):stub fixme:msvcrt:MSVCRT_signal (16 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (17 0x1):stub fixme:msvcrt:MSVCRT_signal (17 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (18 0x1):stub fixme:msvcrt:MSVCRT_signal (18 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (19 0x1):stub fixme:msvcrt:MSVCRT_signal (19 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (20 0x1):stub fixme:msvcrt:MSVCRT_signal (20 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (21 0x1):stub fixme:msvcrt:MSVCRT_signal (21 0xffffffff):stub fixme:msvcrt:MSVCRT_signal (22 0x1):stub fixme:msvcrt:MSVCRT_signal (22 0xffffffff):stub First chance exception: page fault on read access to 0xa93c6858 in 32-bit code (0x1e04e00f).

1 0

Hotel full again?
by Andrew Bartlett 25 Mar '05

25 Mar '05

I tried to book a double room 28th April -> 1st May (sharing with tridge), and it seems the hotel is all full again :-( There seems to be quite a contingent of Samba folk intending to come along (from a poll on the samba team list), and given the number of 'maybe' and 'probably' replies, I suspect I'm not the only one without a room... Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Student Network Administrator, Hawker College http://hawkerc.net

1 0

DirectDraw YUV overlays
by Matthew Mastracci 25 Mar '05

25 Mar '05

I've been investigating the YUV overlays used by Picasa and it seems like it would be a huge problem to tackle this sort of support without some sort of external YUV conversion library and/or hardware support. SDL has great support for transparent hardware/software YUV support; it might be possible to adopt some of the YUV hw/sw implementation code from SDL into Wine. Both projects are LGPL. Whatever the implementation, getting support into the DirectDraw layer for scaling YUV surfaces is a fairly large job. Matt.

4 3

Re: updown: proper handling for GWL_STYLE
by Robert Shearman 25 Mar '05

25 Mar '05

Dimitrie O. Paun wrote: >ChangeLog > Proper handling for GWL_STYLE. > Minor cleanups. > case WM_ENABLE: >- if (dwStyle & WS_DISABLED) UPDOWN_CancelMode (infoPtr); >+ if (infoPtr->dwStyle & WS_DISABLED) UPDOWN_CancelMode (infoPtr); > InvalidateRect (infoPtr->Self, NULL, FALSE); > break; > > You need to update infoPtr->dwStyle here. EnableWindow(FALSE) does not generate a WM_STYLECHANGED message. > >+ case WM_STYLECHANGED: >+ if (wParam == GWL_STYLE) { >+ infoPtr->dwStyle = ((LPSTYLESTRUCT)lParam)->styleNew; >+ InvalidateRect (infoPtr->Self, NULL, FALSE); >+ } >+ break; >+ > > Rob

1 0

Re: winetest: code reorder
by Dmitry Timoshkov 25 Mar '05

25 Mar '05

"Ferenc Wagner" <wferi(a)tba.elte.hu> wrote: > ChangeLog: Check desktop visibility after processing command > line arguments. Why do you need it? There is no point to proceed if the tests can not run in an appropriate environment. -- Dmitry.

2 4

Re: ipaddress: uniform naming
by Alexandre Julliard 25 Mar '05

25 Mar '05

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > I figured I might as well be consistent. The problem with LowerLimit > is the capital at the beginning, I don't remember where I got the (bad) > idea to name it like that. We don't use such naming anywhere, and I really > think I did a mistake when I went for it. Maybe lowerLimit is a more > acceptable solution? But do you really think it's worth having an exception > to the rule for a little 'n'? I don't think there's any point in trying to impose such silly rules on ourselves, and I really don't see what's wrong with starting with a capital letter. That's also the way Windows does it in most places where it doesn't have the Hungarian crap. Of course I think using all lowercase would be a lot more readable, but if you are going to use uppercase "LowerLimit" is much better than "lowerLimit". -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: LOSTWAGES: updates
by Dimitrie O. Paun 25 Mar '05

25 Mar '05

On Fri, Mar 25, 2005 at 09:48:48PM +0900, Mike McCormack wrote: > + <h2>Remove HeapAlloc casts</h2> Please make this a <h3>, all entries there are at that level. -- Dimi.

1 0

Re: ipaddress: uniform naming (take 2)
by Dimitrie O. Paun 25 Mar '05

25 Mar '05

On Fri, Mar 25, 2005 at 12:05:20PM +0000, Mike Hearn wrote: > Blah, consistency with past mistakes rather than fixing them is how Win32 > ended up being such a steaming pile in the first place. If you want to do > a mass search/replace why not un-hungarianize the whole file? Because out of 24 controls, only a few (maybe 2 or 3) don't use a consistent notation. And honestly, while I don't much care for the hungarian notation, I don't think it's that bad anymore to warrant such a huge renaming. And besides, the stuff that I'm renaming is code that I wrote, and so I'm sure I'm not upsetting anyone :). -- Dimi.

1 0

Re: advapi32: Implement NtLoadKey
by Mike McCormack 25 Mar '05

25 Mar '05

James Hawkins wrote: > +/* mount a key directly under HKLM or HKU */ > +static void mount_key(struct key *key, const WCHAR *subkey, obj_handle_t handle) > +{ > + if (!(f = fdopen(fd, "r"))) > + return; > + > + /* create the key */ > + newkey = create_key(key, subkey, NULL, KEY_DIRTY, 0, &created); > + if (!newkey) > + return; > + > + /* load the key */ > + load_keys(newkey, f, -1); > +} I think you leak the FILE * returned from fdopen here. Additionally, if dup() or fdopen() fails, no error code will be set, so the code will fail silently. In NtLoadKey(), you should close the file handle "hive" that you open. Can't you achieve the same effect using the original load_registry request, rather than creating a new request? If not, you can also remove the load_registry request from protocol.def as I think it's no longer used. Mike

2 1

Support for IDvdInfo2::GetDiscID
by James Courtier-Dutton 25 Mar '05

25 Mar '05

The Windows api method uses the function call IDvdInfo2::GetDiscID http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… This returns a unique 64bit ID for a DVD. Has anyone found out what exactly it does to create this 64bit ID. It would be nice to get linux DVD players to be able to use the same method. Cheers James

2 2

[WINEALSA] multiple sound card support patch review needed
by Robert Reif 25 Mar '05

25 Mar '05

This patch adds multiple sound card support to the ALSA driver. My system shows 3 sound devices: a builtin sound card, a builtin modem and a usb sound card. The wave regression tests have problems with the modem. I'm not sure it is an ALSA problem or a problem with this patch. Could someone familiar with ALSA look this patch over. I would also like feedback from any brave testers that have multiple sound cards. Thanks. Index: dlls/winmm/winealsa/audio.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/winealsa/audio.c,v retrieving revision 1.65 diff -u -p -r1.65 audio.c --- dlls/winmm/winealsa/audio.c 17 Mar 2005 18:54:20 -0000 1.65 +++ dlls/winmm/winealsa/audio.c 17 Mar 2005 20:51:58 -0000 @@ -74,8 +74,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(wave); snd_pcm_uframes_t _snd_pcm_mmap_hw_ptr(snd_pcm_t *pcm); -#define MAX_WAVEOUTDRV (1) -#define MAX_WAVEINDRV (1) +#define MAX_WAVEOUTDRV (6) +#define MAX_WAVEINDRV (6) /* state diagram for waveOut writing: * @@ -389,6 +389,7 @@ static int ALSA_InitializeVolumeCtl(WINE snd_hctl_elem_t * elem; int nCtrls; int i; + char device[8]; snd_ctl_card_info_alloca(&cardinfo); memset(cardinfo,0,snd_ctl_card_info_sizeof()); @@ -416,13 +417,15 @@ static int ALSA_InitializeVolumeCtl(WINE } \ } while(0) - EXIT_ON_ERROR( snd_ctl_open(&ctl,"hw",0) , "ctl open failed" ); + sprintf(device, "hw:%ld", ALSA_WodNumDevs); + + EXIT_ON_ERROR( snd_ctl_open(&ctl,device,0) , "ctl open failed" ); EXIT_ON_ERROR( snd_ctl_card_info(ctl, cardinfo), "card info failed"); EXIT_ON_ERROR( snd_ctl_elem_list(ctl, elemlist), "elem list failed"); nCtrls = snd_ctl_elem_list_get_count(elemlist); - EXIT_ON_ERROR( snd_hctl_open(&hctl,"hw",0), "hctl open failed"); + EXIT_ON_ERROR( snd_hctl_open(&hctl,device,0), "hctl open failed"); EXIT_ON_ERROR( snd_hctl_load(hctl), "hctl load failed" ); elem=snd_hctl_first_elem(hctl); @@ -636,21 +639,21 @@ static char* ALSA_strdup(char *s) { /****************************************************************** * ALSA_GetDeviceFromReg * - * Returns either "default" or reads the registry so the user can + * Returns either "plug:hw" or reads the registry so the user can * override the playback/record device used. */ static char *ALSA_GetDeviceFromReg(const char *value) { DWORD res; DWORD type; - HKEY playbackKey = 0; + HKEY key = 0; char *result = NULL; DWORD resultSize; - res = RegOpenKeyExA(HKEY_LOCAL_MACHINE, "Software\\Wine\\Wine\\Config\\ALSA", 0, KEY_QUERY_VALUE, &playbackKey); + res = RegOpenKeyExA(HKEY_LOCAL_MACHINE, "Software\\Wine\\Wine\\Config\\ALSA", 0, KEY_QUERY_VALUE, &key); if (res != ERROR_SUCCESS) goto end; - res = RegQueryValueExA(playbackKey, value, NULL, &type, NULL, &resultSize); + res = RegQueryValueExA(key, value, NULL, &type, NULL, &resultSize); if (res != ERROR_SUCCESS) goto end; if (type != REG_SZ) { @@ -659,11 +662,15 @@ static char *ALSA_GetDeviceFromReg(const } result = HeapAlloc(GetProcessHeap(), 0, resultSize); - res = RegQueryValueExA(playbackKey, value, NULL, NULL, result, &resultSize); + res = RegQueryValueExA(key, value, NULL, NULL, result, &resultSize); end: - if (!result) result = ALSA_strdup("default"); - if (playbackKey) RegCloseKey(playbackKey); + if (!result) + result = ALSA_strdup("plug:hw"); + + if (key) + RegCloseKey(key); + return result; } @@ -685,24 +692,7 @@ LONG ALSA_WaveInit(void) int err=0; WINE_WAVEOUT* wwo; WINE_WAVEIN* wwi; - static const WCHAR init_out[] = {'S','B','1','6',' ','W','a','v','e',' ','O','u','t',0}; - static const WCHAR init_in [] = {'S','B','1','6',' ','W','a','v','e',' ','I','n',0}; - - wwo = &WOutDev[0]; - - /* FIXME: use better values */ - wwo->device = ALSA_GetDeviceFromReg("PlaybackDevice"); - TRACE("using waveout device \"%s\"\n", wwo->device); - - snprintf(wwo->interface_name, sizeof(wwo->interface_name), "winealsa: %s", wwo->device); - - wwo->caps.wMid = 0x0002; - wwo->caps.wPid = 0x0104; - strcpyW(wwo->caps.szPname, init_out); - wwo->caps.vDriverVersion = 0x0100; - wwo->caps.dwFormats = 0x00000000; - wwo->caps.dwSupport = WAVECAPS_VOLUME; - strcpy(wwo->ds_desc.szDrvname, "winealsa.drv"); + int i; if (!wine_dlopen("libasound.so.2", RTLD_LAZY|RTLD_GLOBAL, NULL, 0)) { @@ -710,191 +700,226 @@ LONG ALSA_WaveInit(void) return -1; } - snd_pcm_info_alloca(&info); - snd_pcm_hw_params_alloca(&hw_params); + ALSA_WodNumDevs = 0; -#define EXIT_ON_ERROR(f,txt) do { int err; if ( (err = (f) ) < 0) { ERR(txt ": %s\n", snd_strerror(err)); if (h) snd_pcm_close(h); return -1; } } while(0) + for (i = 0; i < MAX_WAVEOUTDRV; i++) + { + char device[64]; + char * regdev; + WCHAR nameW[64]; + snd_pcm_format_mask_t * fmask; + snd_pcm_access_mask_t * acmask; - h = NULL; - ALSA_WodNumDevs = 0; - EXIT_ON_ERROR( snd_pcm_open(&h, wwo->device, SND_PCM_STREAM_PLAYBACK, SND_PCM_NONBLOCK) , "open pcm" ); - if (!h) return -1; - ALSA_WodNumDevs++; - - EXIT_ON_ERROR( snd_pcm_info(h, info) , "pcm info" ); - - TRACE("dev=%d id=%s name=%s subdev=%d subdev_name=%s subdev_avail=%d subdev_num=%d stream=%s subclass=%s \n", - snd_pcm_info_get_device(info), - snd_pcm_info_get_id(info), - snd_pcm_info_get_name(info), - snd_pcm_info_get_subdevice(info), - snd_pcm_info_get_subdevice_name(info), - snd_pcm_info_get_subdevices_avail(info), - snd_pcm_info_get_subdevices_count(info), - snd_pcm_stream_name(snd_pcm_info_get_stream(info)), - (snd_pcm_info_get_subclass(info) == SND_PCM_SUBCLASS_GENERIC_MIX ? "GENERIC MIX": "MULTI MIX")); + wwo = &WOutDev[ALSA_WodNumDevs]; - strcpy(wwo->ds_desc.szDesc, snd_pcm_info_get_name(info)); - EXIT_ON_ERROR( snd_pcm_hw_params_any(h, hw_params) , "pcm hw params" ); -#undef EXIT_ON_ERROR + regdev = ALSA_GetDeviceFromReg("PlaybackDevice"); + sprintf(device, "%s:%d", regdev, i); + HeapFree(GetProcessHeap(), 0, regdev); + wwo->device = HeapAlloc(GetProcessHeap(), 0, strlen(device)); + strcpy(wwo->device, device); + TRACE("using waveout device \"%s\"\n", wwo->device); + + snprintf(wwo->interface_name, sizeof(wwo->interface_name), "winealsa: %s", wwo->device); + + wwo->caps.wMid = 0x0002; + wwo->caps.wPid = 0x0104; + wwo->caps.vDriverVersion = 0x0100; + wwo->caps.dwFormats = 0x00000000; + wwo->caps.dwSupport = WAVECAPS_VOLUME; + strcpy(wwo->ds_desc.szDrvname, "winealsa.drv"); - err = snd_pcm_hw_params_get_rate_min(hw_params, &ratemin, &dir); - err = snd_pcm_hw_params_get_rate_max(hw_params, &ratemax, &dir); - err = snd_pcm_hw_params_get_channels_min(hw_params, &chmin); - err = snd_pcm_hw_params_get_channels_max(hw_params, &chmax); - if (TRACE_ON(wave)) - ALSA_TraceParameters(hw_params, NULL, TRUE); + snd_pcm_info_alloca(&info); + snd_pcm_hw_params_alloca(&hw_params); - { - snd_pcm_format_mask_t * fmask; +#define EXIT_ON_ERROR(f,txt) do { int err; if ( (err = (f) ) < 0) { ERR(txt ": %s\n", snd_strerror(err)); if (h) snd_pcm_close(h); return -1; } } while(0) + + h = NULL; + snd_pcm_open(&h, wwo->device, SND_PCM_STREAM_PLAYBACK, SND_PCM_NONBLOCK); + if (!h) + break; + + EXIT_ON_ERROR( snd_pcm_info(h, info) , "pcm info" ); + + TRACE("dev=%d id=%s name=%s subdev=%d subdev_name=%s subdev_avail=%d subdev_num=%d stream=%s subclass=%s \n", + snd_pcm_info_get_device(info), + snd_pcm_info_get_id(info), + snd_pcm_info_get_name(info), + snd_pcm_info_get_subdevice(info), + snd_pcm_info_get_subdevice_name(info), + snd_pcm_info_get_subdevices_avail(info), + snd_pcm_info_get_subdevices_count(info), + snd_pcm_stream_name(snd_pcm_info_get_stream(info)), + (snd_pcm_info_get_subclass(info) == SND_PCM_SUBCLASS_GENERIC_MIX ? "GENERIC MIX": "MULTI MIX")); + + strcpy(wwo->ds_desc.szDesc, snd_pcm_info_get_name(info)); + MultiByteToWideChar(CP_ACP, 0, wwo->ds_desc.szDesc, -1, nameW, sizeof(nameW)/sizeof(WCHAR)); + strcpyW(wwo->caps.szPname, nameW); + EXIT_ON_ERROR( snd_pcm_hw_params_any(h, hw_params) , "pcm hw params" ); +#undef EXIT_ON_ERROR + + err = snd_pcm_hw_params_get_rate_min(hw_params, &ratemin, &dir); + err = snd_pcm_hw_params_get_rate_max(hw_params, &ratemax, &dir); + err = snd_pcm_hw_params_get_channels_min(hw_params, &chmin); + err = snd_pcm_hw_params_get_channels_max(hw_params, &chmax); + if (TRACE_ON(wave)) + ALSA_TraceParameters(hw_params, NULL, TRUE); snd_pcm_format_mask_alloca(&fmask); snd_pcm_hw_params_get_format_mask(hw_params, fmask); #define X(r,v) \ - if ( (r) >= ratemin && ( (r) <= ratemax || ratemax == -1) ) \ - { \ - if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_U8)) \ - { \ + if ( (r) >= ratemin && ( (r) <= ratemax || ratemax == -1) ) \ + { \ + if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_U8)) \ + { \ if (chmin <= 1 && 1 <= chmax) \ wwo->caps.dwFormats |= WAVE_FORMAT_##v##M08; \ if (chmin <= 2 && 2 <= chmax) \ wwo->caps.dwFormats |= WAVE_FORMAT_##v##S08; \ - } \ - if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_S16_LE)) \ - { \ + } \ + if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_S16_LE)) \ + { \ if (chmin <= 1 && 1 <= chmax) \ wwo->caps.dwFormats |= WAVE_FORMAT_##v##M16; \ if (chmin <= 2 && 2 <= chmax) \ wwo->caps.dwFormats |= WAVE_FORMAT_##v##S16; \ - } \ - } - X(11025,1); - X(22050,2); - X(44100,4); - X(48000,48); - X(96000,96); + } \ + } + X(11025,1); + X(22050,2); + X(44100,4); + X(48000,48); + X(96000,96); #undef X - } - if ( chmin > 1) FIXME("-\n"); - wwo->caps.wChannels = chmax; - if (chmin <= 2 && 2 <= chmax) - wwo->caps.dwSupport |= WAVECAPS_LRVOLUME; + if (chmin > 1) + FIXME("-\n"); + wwo->caps.wChannels = chmax; + if (chmin <= 2 && 2 <= chmax) + wwo->caps.dwSupport |= WAVECAPS_LRVOLUME; - /* FIXME: always true ? */ - wwo->caps.dwSupport |= WAVECAPS_SAMPLEACCURATE; + /* FIXME: always true ? */ + wwo->caps.dwSupport |= WAVECAPS_SAMPLEACCURATE; - { - snd_pcm_access_mask_t * acmask; snd_pcm_access_mask_alloca(&acmask); snd_pcm_hw_params_get_access_mask(hw_params, acmask); /* FIXME: NONITERLEAVED and COMPLEX are not supported right now */ if ( snd_pcm_access_mask_test( acmask, SND_PCM_ACCESS_MMAP_INTERLEAVED ) ) wwo->caps.dwSupport |= WAVECAPS_DIRECTSOUND; - } - TRACE("Configured with dwFmts=%08lx dwSupport=%08lx\n", - wwo->caps.dwFormats, wwo->caps.dwSupport); + TRACE("Configured with dwFmts=%08lx dwSupport=%08lx\n", + wwo->caps.dwFormats, wwo->caps.dwSupport); - snd_pcm_close(h); + snd_pcm_close(h); - ALSA_InitializeVolumeCtl(wwo); + ALSA_InitializeVolumeCtl(wwo); - wwi = &WInDev[0]; + ALSA_WodNumDevs++; + } - /* FIXME: use better values */ - wwi->device = ALSA_GetDeviceFromReg("RecordDevice"); - TRACE("using wavein device \"%s\"\n", wwi->device); + ALSA_WidNumDevs = 0; - snprintf(wwi->interface_name, sizeof(wwi->interface_name), "winealsa: %s", wwi->device); + for (i = 0; i < MAX_WAVEINDRV; i++) + { + char device[64]; + char * regdev; + WCHAR nameW[64]; + snd_pcm_format_mask_t * fmask; + snd_pcm_access_mask_t * acmask; - wwi->caps.wMid = 0x0002; - wwi->caps.wPid = 0x0104; - strcpyW(wwi->caps.szPname, init_in); - wwi->caps.vDriverVersion = 0x0100; - wwi->caps.dwFormats = 0x00000000; - wwi->caps.dwSupport = WAVECAPS_VOLUME; - strcpy(wwi->ds_desc.szDrvname, "winealsa.drv"); + wwi = &WInDev[ALSA_WidNumDevs]; - snd_pcm_info_alloca(&info); - snd_pcm_hw_params_alloca(&hw_params); + regdev = ALSA_GetDeviceFromReg("CaptureDevice"); + sprintf(device, "%s:%d", regdev, i); + HeapFree(GetProcessHeap(), 0, regdev); + wwi->device = HeapAlloc(GetProcessHeap(), 0, strlen(device)); + strcpy(wwi->device, device); + + TRACE("using wavein device \"%s\"\n", wwi->device); + + snprintf(wwi->interface_name, sizeof(wwi->interface_name), "winealsa: %s", wwi->device); + + wwi->caps.wMid = 0x0002; + wwi->caps.wPid = 0x0104; + wwi->caps.vDriverVersion = 0x0100; + wwi->caps.dwFormats = 0x00000000; + wwi->caps.dwSupport = WAVECAPS_VOLUME; + strcpy(wwi->ds_desc.szDrvname, "winealsa.drv"); -#define EXIT_ON_ERROR(f,txt) do { int err; if ( (err = (f) ) < 0) { ERR(txt ": %s\n", snd_strerror(err)); if (h) snd_pcm_close(h); return -1; } } while(0) + snd_pcm_info_alloca(&info); + snd_pcm_hw_params_alloca(&hw_params); - h = NULL; - ALSA_WidNumDevs = 0; - EXIT_ON_ERROR( snd_pcm_open(&h, wwi->device, SND_PCM_STREAM_CAPTURE, SND_PCM_NONBLOCK) , "open pcm" ); - if (!h) return -1; - ALSA_WidNumDevs++; - - EXIT_ON_ERROR( snd_pcm_info(h, info) , "pcm info" ); - - TRACE("dev=%d id=%s name=%s subdev=%d subdev_name=%s subdev_avail=%d subdev_num=%d stream=%s subclass=%s \n", - snd_pcm_info_get_device(info), - snd_pcm_info_get_id(info), - snd_pcm_info_get_name(info), - snd_pcm_info_get_subdevice(info), - snd_pcm_info_get_subdevice_name(info), - snd_pcm_info_get_subdevices_avail(info), - snd_pcm_info_get_subdevices_count(info), - snd_pcm_stream_name(snd_pcm_info_get_stream(info)), - (snd_pcm_info_get_subclass(info) == SND_PCM_SUBCLASS_GENERIC_MIX ? "GENERIC MIX": "MULTI MIX")); +#define EXIT_ON_ERROR(f,txt) do { int err; if ( (err = (f) ) < 0) { ERR(txt ": %s\n", snd_strerror(err)); if (h) snd_pcm_close(h); return -1; } } while(0) - strcpy(wwi->ds_desc.szDesc, snd_pcm_info_get_name(info)); - EXIT_ON_ERROR( snd_pcm_hw_params_any(h, hw_params) , "pcm hw params" ); + h = NULL; + snd_pcm_open(&h, wwi->device, SND_PCM_STREAM_CAPTURE, SND_PCM_NONBLOCK); + if (!h) + break; + + EXIT_ON_ERROR( snd_pcm_info(h, info) , "pcm info" ); + + TRACE("dev=%d id=%s name=%s subdev=%d subdev_name=%s subdev_avail=%d subdev_num=%d stream=%s subclass=%s \n", + snd_pcm_info_get_device(info), + snd_pcm_info_get_id(info), + snd_pcm_info_get_name(info), + snd_pcm_info_get_subdevice(info), + snd_pcm_info_get_subdevice_name(info), + snd_pcm_info_get_subdevices_avail(info), + snd_pcm_info_get_subdevices_count(info), + snd_pcm_stream_name(snd_pcm_info_get_stream(info)), + (snd_pcm_info_get_subclass(info) == SND_PCM_SUBCLASS_GENERIC_MIX ? "GENERIC MIX": "MULTI MIX")); + + strcpy(wwi->ds_desc.szDesc, snd_pcm_info_get_name(info)); + MultiByteToWideChar(CP_ACP, 0, wwi->ds_desc.szDesc, -1, nameW, sizeof(nameW)/sizeof(WCHAR)); + strcpyW(wwi->caps.szPname, nameW); + EXIT_ON_ERROR( snd_pcm_hw_params_any(h, hw_params) , "pcm hw params" ); #undef EXIT_ON_ERROR - err = snd_pcm_hw_params_get_rate_min(hw_params, &ratemin, &dir); - err = snd_pcm_hw_params_get_rate_max(hw_params, &ratemax, &dir); - err = snd_pcm_hw_params_get_channels_min(hw_params, &chmin); - err = snd_pcm_hw_params_get_channels_max(hw_params, &chmax); + err = snd_pcm_hw_params_get_rate_min(hw_params, &ratemin, &dir); + err = snd_pcm_hw_params_get_rate_max(hw_params, &ratemax, &dir); + err = snd_pcm_hw_params_get_channels_min(hw_params, &chmin); + err = snd_pcm_hw_params_get_channels_max(hw_params, &chmax); - if (TRACE_ON(wave)) - ALSA_TraceParameters(hw_params, NULL, TRUE); - - { - snd_pcm_format_mask_t * fmask; + if (TRACE_ON(wave)) + ALSA_TraceParameters(hw_params, NULL, TRUE); snd_pcm_format_mask_alloca(&fmask); snd_pcm_hw_params_get_format_mask(hw_params, fmask); #define X(r,v) \ - if ( (r) >= ratemin && ( (r) <= ratemax || ratemax == -1) ) \ - { \ - if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_U8)) \ - { \ + if ( (r) >= ratemin && ( (r) <= ratemax || ratemax == -1) ) \ + { \ + if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_U8)) \ + { \ if (chmin <= 1 && 1 <= chmax) \ wwi->caps.dwFormats |= WAVE_FORMAT_##v##M08; \ if (chmin <= 2 && 2 <= chmax) \ wwi->caps.dwFormats |= WAVE_FORMAT_##v##S08; \ - } \ - if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_S16_LE)) \ - { \ + } \ + if (snd_pcm_format_mask_test( fmask, SND_PCM_FORMAT_S16_LE)) \ + { \ if (chmin <= 1 && 1 <= chmax) \ wwi->caps.dwFormats |= WAVE_FORMAT_##v##M16; \ if (chmin <= 2 && 2 <= chmax) \ wwi->caps.dwFormats |= WAVE_FORMAT_##v##S16; \ - } \ - } - X(11025,1); - X(22050,2); - X(44100,4); - X(48000,48); - X(96000,96); + } \ + } + X(11025,1); + X(22050,2); + X(44100,4); + X(48000,48); + X(96000,96); #undef X - } - if ( chmin > 1) FIXME("-\n"); - wwi->caps.wChannels = chmax; - if (chmin <= 2 && 2 <= chmax) - wwi->caps.dwSupport |= WAVECAPS_LRVOLUME; + if (chmin > 1) + FIXME("-\n"); + wwi->caps.wChannels = chmax; + if (chmin <= 2 && 2 <= chmax) + wwi->caps.dwSupport |= WAVECAPS_LRVOLUME; - /* FIXME: always true ? */ - wwi->caps.dwSupport |= WAVECAPS_SAMPLEACCURATE; + /* FIXME: always true ? */ + wwi->caps.dwSupport |= WAVECAPS_SAMPLEACCURATE; - { - snd_pcm_access_mask_t * acmask; snd_pcm_access_mask_alloca(&acmask); snd_pcm_hw_params_get_access_mask(hw_params, acmask); @@ -904,12 +929,14 @@ LONG ALSA_WaveInit(void) wwi->caps.dwSupport |= WAVECAPS_DIRECTSOUND; #endif } - } - TRACE("Configured with dwFmts=%08lx dwSupport=%08lx\n", - wwi->caps.dwFormats, wwi->caps.dwSupport); + TRACE("Configured with dwFmts=%08lx dwSupport=%08lx\n", + wwi->caps.dwFormats, wwi->caps.dwSupport); - snd_pcm_close(h); + snd_pcm_close(h); + + ALSA_WidNumDevs++; + } return 0; }

4 7

Attempt to make buttons themed
by Frank Richter 25 Mar '05

25 Mar '05

Hi, to see how easy (or not) it would be to make the controls use themes, I tried to get themed buttons; the result is the attached patch (to try it out, you need an .msstyles file and appropriate registry setup). It's probably not perfect as it is, comments/questions are welcome. Screenshot: http://img87.exs.cx/my.php?loc=img87&image=winewiththemedbuttons3xh.png Some funny side effect when theming is enabled: applications show up in standard colors, but as soon as the first button is created, the colors switch to the theme's colors. I guess opening the theme data in the button code triggers some uxtheme initialization that in turn changes the system colors. Also, all applications get themed buttons, which diverges from WinXPs behaviour and may or may not be desired for some apps. -f.r. Index: dlls/user/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/user/Makefile.in,v retrieving revision 1.88 diff -u -r1.88 Makefile.in --- dlls/user/Makefile.in 10 Mar 2005 15:47:53 -0000 1.88 +++ dlls/user/Makefile.in 21 Mar 2005 18:46:31 -0000 @@ -4,7 +4,7 @@ SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = user32.dll -IMPORTS = gdi32 advapi32 kernel32 ntdll +IMPORTS = gdi32 advapi32 kernel32 uxtheme ntdll EXTRALIBS = $(LIBUNICODE) SPEC_SRCS16 = \ Index: dlls/user/button.c =================================================================== RCS file: /home/wine/wine/dlls/user/button.c,v retrieving revision 1.6 diff -u -r1.6 button.c --- dlls/user/button.c 23 Dec 2004 17:21:05 -0000 1.6 +++ dlls/user/button.c 21 Mar 2005 18:46:32 -0000 @@ -71,6 +71,9 @@ #include "windef.h" #include "winbase.h" #include "wingdi.h" +#include "winuser.h" /* Indirectly required by uxtheme.h */ +#include "uxtheme.h" +#include "tmschema.h" #include "wine/winuser16.h" #include "controls.h" #include "user_private.h" @@ -79,7 +82,8 @@ #define STATE_GWL_OFFSET 0 #define HFONT_GWL_OFFSET (sizeof(LONG)) #define HIMAGE_GWL_OFFSET (HFONT_GWL_OFFSET+sizeof(HFONT)) -#define NB_EXTRA_BYTES (HIMAGE_GWL_OFFSET+sizeof(HANDLE)) +#define HTHEME_GWL_OFFSET (HIMAGE_GWL_OFFSET+sizeof(HANDLE)) +#define NB_EXTRA_BYTES (HTHEME_GWL_OFFSET+sizeof(HTHEME)) /* Button state values */ #define BUTTON_UNCHECKED 0x00 @@ -95,6 +99,7 @@ static UINT BUTTON_CalcLabelRect( HWND hwnd, HDC hdc, RECT *rc ); static void PB_Paint( HWND hwnd, HDC hDC, UINT action ); +static void PB_PaintThemed( HWND hwnd, HDC hDC, UINT action ); static void CB_Paint( HWND hwnd, HDC hDC, UINT action ); static void GB_Paint( HWND hwnd, HDC hDC, UINT action ); static void UB_Paint( HWND hwnd, HDC hDC, UINT action ); @@ -123,7 +128,7 @@ typedef void (*pfPaint)( HWND hwnd, HDC hdc, UINT action ); -static const pfPaint btnPaintFunc[MAX_BTN_TYPE] = +static const pfPaint btnUnthemedPaintFunc[MAX_BTN_TYPE] = { PB_Paint, /* BS_PUSHBUTTON */ PB_Paint, /* BS_DEFPUSHBUTTON */ @@ -139,6 +144,22 @@ OB_Paint /* BS_OWNERDRAW */ }; +static const pfPaint btnThemedPaintFunc[MAX_BTN_TYPE] = +{ + PB_PaintThemed, /* BS_PUSHBUTTON */ + PB_PaintThemed, /* BS_DEFPUSHBUTTON */ + CB_Paint, /* BS_CHECKBOX */ + CB_Paint, /* BS_AUTOCHECKBOX */ + CB_Paint, /* BS_RADIOBUTTON */ + CB_Paint, /* BS_3STATE */ + CB_Paint, /* BS_AUTO3STATE */ + GB_Paint, /* BS_GROUPBOX */ + UB_Paint, /* BS_USERBUTTON */ + CB_Paint, /* BS_AUTORADIOBUTTON */ + NULL, /* Not defined */ + OB_Paint /* BS_OWNERDRAW */ +}; + static HBITMAP hbitmapCheckBoxes = 0; static WORD checkBoxWidth = 0, checkBoxHeight = 0; @@ -183,9 +204,26 @@ return (window_style & 0x0f); } +inline static HTHEME get_button_theme( HWND hwnd ) +{ + return (HTHEME)GetWindowLongPtrW( hwnd, HTHEME_GWL_OFFSET ); +} + +inline static void set_button_theme( HWND hwnd, HTHEME theme ) +{ + SetWindowLongPtrW( hwnd, HTHEME_GWL_OFFSET, (ULONG_PTR)theme ); +} + +inline static const pfPaint* get_paint_funcs ( HWND hwnd ) +{ + HTHEME theme = get_button_theme( hwnd ); + return ( theme != NULL ) ? btnThemedPaintFunc : btnUnthemedPaintFunc; +} + /* paint a button of any type */ inline static void paint_button( HWND hwnd, LONG style, UINT action ) { + const pfPaint* btnPaintFunc = get_paint_funcs( hwnd ); if (btnPaintFunc[style] && IsWindowVisible(hwnd)) { HDC hdc = GetDC( hwnd ); @@ -215,6 +253,9 @@ UINT btn_type = get_button_type( style ); LONG state; HANDLE oldHbitmap; + static const WCHAR themeClass[] = { 'B','u','t','t','o','n',0 }; + HTHEME theme; + const pfPaint* btnPaintFunc = get_paint_funcs( hWnd ); pt.x = LOWORD(lParam); pt.y = HIWORD(lParam); @@ -249,8 +290,24 @@ if (btn_type >= MAX_BTN_TYPE) return -1; /* abort */ set_button_state( hWnd, BUTTON_UNCHECKED ); + theme = OpenThemeData( hWnd, themeClass ); + set_button_theme( hWnd, theme ); return 0; + + case WM_DESTROY: + theme = get_button_theme( hWnd ); + if ( theme != NULL ) + CloseThemeData ( theme ); + break; + case WM_THEMECHANGED: + theme = get_button_theme( hWnd ); + if ( theme != NULL ) + CloseThemeData ( theme ); + theme = OpenThemeData( hWnd, themeClass ); + set_button_theme( hWnd, theme ); + break; + case WM_ERASEBKGND: if (btn_type == BS_OWNERDRAW) { @@ -842,6 +899,39 @@ SetBkMode(hDC, oldBkMode); } +static void PB_PaintThemed( HWND hwnd, HDC hDC, UINT action ) +{ + LONG state = get_button_state( hwnd ); + LONG style = GetWindowLongW( hwnd, GWL_STYLE ); + BOOL pushedState = (state & BUTTON_HIGHLIGHTED); + HTHEME theme = get_button_theme( hwnd ); + int partID = BP_PUSHBUTTON; + int stateID; + RECT rc; + WCHAR *text = NULL; + BOOL disabledState = !IsWindowEnabled( hwnd ); + + GetClientRect( hwnd, &rc ); + if (disabledState) + stateID = PBS_DISABLED; + else if (pushedState) + stateID = PBS_PRESSED; + else if (( get_button_type(style) == BS_DEFPUSHBUTTON ) + || ( state & BUTTON_HASFOCUS )) + stateID = PBS_DEFAULTED; + else + stateID = PBS_NORMAL; + + DrawThemeBackground( theme, hDC, partID, stateID, &rc, NULL); + + if (( text = get_button_text( hwnd ) ) != NULL ) + { + if ((style & (BS_ICON|BS_BITMAP)) == BS_TEXT) + DrawThemeText( theme, hDC, partID, stateID, text, -1, + BUTTON_BStoDT(style), 0, &rc ); + } +} + /********************************************************************** * Check Box & Radio Button Functions */

12 27

Re: ipaddress: uniform naming
by Alexandre Julliard 25 Mar '05

25 Mar '05

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > I don't much like hungarian notation. I used to hate it. > Not so much anymore, but that's besides the point. > > Back in the day when I introduced these names they seemed > like a good idea. I was wrong, mea culpa. They are not > particulary good (why capitalize structure members?), > and they don't mix well with the rest of the naming > convention in the other controls. > > They irk me every time I see them, so I'd like to change > them to something saner. I can live with hwndSelf since that's pretty much used everywhere, but do you really need to add Hungarian line noise to the other variables? Exactly how is "nLowerLimit" saner than "LowerLimit"? -- Alexandre Julliard julliard(a)winehq.org

1 0

3DMark Bench Results
by Tom Wickline 25 Mar '05

25 Mar '05

Hello, Anyone here interested in seeing some 3DMark Bench Results? If so let me know and ill send yout the .3dp file or a shot. Tom

1 0

Re: Handle wParam in WM_PAINT properly
by Filip Navara 25 Mar '05

25 Mar '05

Dimitrie O. Paun wrote: >ChangeLog > Handle wParam in WM_PAINT properly: if non-null, > it is the hdc we are supposed to use to draw into. > > Hmm, MSDN says that the wParam of WM_PAINT is not used and I always believed it. Are you sure that you're not confusing it with WM_PRINTCLIENT? - Filip

2 1

extra copies of Windows DDK
by Brian Vincent 25 Mar '05

25 Mar '05

Ivan asked me if I could order the Windows DDK and bring it to Wineconf since it's cheaper to ship it here. Well, it seems it was the same price to order 5 copies instead of just one. That leaves 4 extra DDK's available. If you want one, and will be at WineConf, let me know and I'll bring one. -Brian

1 0

Re: saving winrash
by Steven Edwards 25 Mar '05

25 Mar '05

--- Chris Morgan <cmorgan(a)alum.wpi.edu> wrote: > I'm certainly open to having it imported into the wine tree if there is some > desire. Yes. I have enough CVS and SVN trees on my desk without having to manage another and manage dealing with keeping them in sync when they share code. If ReactOS is going to use Winetest and Winrash I really need the winrash sources to be in Winehq CVS or the ReactOS people with either A) fork it or B) write there own service. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Dos pgm loading question (Bug#440 ish)
by Ann and Jason Edmeades 24 Mar '05

24 Mar '05

Hiya, I was trying to confirm an old bug still existed and the bug #440 has a tar file with an exe in it which apparently used to run under wine and fails with some problems later on. Nowdays, it fails dismally when you try to launch it. Disclaimer#1 - I haven't tried a regression test but I have looked through the code at the point of the failure all the way back to before winedos existed (pre this problem report) and cant see how it ever worked. If anyone has a working 2002 version of wine and could try it, I'd appreciate it! Basically we look at the header, and see a # pages of 1, and a count of bytes in the last page of 107, and end up loading something like 38 bytes of the exe. The DOS exe starts with JMP 0x88, so a trap occurs Looking under windows, ntvdm does a load for the header, then a load for 464 bytes from the position where the code starts - For the life of me I cant see how that calculation occurs and where our code is wrong. I know its an extremely trivial problem for an ancient thing that no one will probably ever want running under wine, but it really bugs me - Does anyone have any idea why our calculation is wrong? Jason

2 2

Re: ntdll: Implement NtLoadKey
by Alexandre Julliard 24 Mar '05

24 Mar '05

James Hawkins <truiken(a)gmail.com> writes: > This implementation passes the registry tests. A new server function > is added, mount_key. mount_key is similar to load_registry except > that mount_key can only load a key under HKLM or HKU and the key is > created inside mount_key. To use load_registry, the subkey has to be > created and then passed in as a parameter. load_registry is no longer > used by anything, so if it should be remove, let me know. What you should have done is modify load_registry, there's no reason to create a new request that does the same thing. -- Alexandre Julliard julliard(a)winehq.org

2 3

About
by Giovanni Delvecchio 24 Mar '05

24 Mar '05

hello list, i noted that the patch provided ( http://www.winehq.org/hypermail/wine-devel/2005/03/0624.html ) to fix that problem isn't secure yet, because a symlink attack could be possible if /tmp is a mounted NFS file system. Indeed: 1)The name of the file in /tmp is easly predictable , it uses getpid(); 2)O_EXCL when used with O_CREAT, if the file already exists it is an error and the open will fail. O_EXCL is broken on NFS file systems, programs which rely on it for performing locking tasks will contain a race condition. Possible fix using tempnam() function to generate a psued-random string for tmp file name: _______________________________________________________________ --- misc/registry.c Thu Mar 24 13:36:43 2005 +++ misc/registry.c Thu Mar 24 13:46:46 2005 @@ -1222,12 +1222,11 @@ static LPSTR _get_tmp_fn(FILE **f) { LPSTR ret; - int tmp_fd,count; + int tmp_fd; - ret = _xmalloc(50); - for (count = 0;;) { - sprintf(ret,"/tmp/reg%lx%04x.tmp",(long)getpid(),count++); - if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0666)) != -1) break; + for (;;) { + ret = tempnam("/tmp", "reg"); + if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0600)) != -1) break; if (errno != EEXIST) { ERR("Unexpected error while open() call: %s\n",strerror(errno)); free(ret); _______________________________________________________________ Best regard, Giovanni Delvecchio -- ______________________________________________ Check out the latest SMS services @ http://www.linuxmail.org This allows you to send and receive SMS through your mailbox. Powered by Outblaze

2 1

About [ZH2005-02SA] Insecure tmp file creation in Wine
by Giovanni Delvecchio 24 Mar '05

24 Mar '05

hello list, i noted that the patch provided ( http://www.winehq.org/hypermail/wine-devel/2005/03/0624.html ) to fix that problem isn't secure yet, because a symlink attack could be possible if /tmp is a mounted NFS file system. Indeed: 1)The name of the file in /tmp is easly predictable , it uses getpid(); 2)O_EXCL when used with O_CREAT, if the file already exists it is an error and the open will fail. O_EXCL is broken on NFS file systems, programs which rely on it for performing locking tasks will contain a race condition. Possible fix using tempnam() function to generate a psued-random string for tmp file name: _______________________________________________________________ --- misc/registry.c Thu Mar 24 13:36:43 2005 +++ misc/registry.c Thu Mar 24 13:46:46 2005 @@ -1222,12 +1222,11 @@ static LPSTR _get_tmp_fn(FILE **f) { LPSTR ret; - int tmp_fd,count; + int tmp_fd; - ret = _xmalloc(50); - for (count = 0;;) { - sprintf(ret,"/tmp/reg%lx%04x.tmp",(long)getpid(),count++); - if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0666)) != -1) break; + for (;;) { + ret = tempnam("/tmp", "reg"); + if ((tmp_fd = open(ret,O_CREAT | O_EXCL | O_WRONLY,0600)) != -1) break; if (errno != EEXIST) { ERR("Unexpected error while open() call: %s\n",strerror(errno)); free(ret); _______________________________________________________________ Best regard, Giovanni Delvecchio -- ______________________________________________ Check out the latest SMS services @ http://www.linuxmail.org This allows you to send and receive SMS through your mailbox. Powered by Outblaze

1 0

Re: Treeview plus/minus
by Jon Griffiths 24 Mar '05

24 Mar '05

Hi George, >If I change the size to 18 the plus is drawn correctly >Does anybody knows anything about this ? The native controls draw a different kind of cross for large items, which looks a lot nicer. I added this but the initial threshold for deciding when to draw the large cross was too small, as reported by Ge Van Geldorp from the ReactOS crew - The thread starts here: http://www.winehq.com/hypermail/wine-devel/2004/10/0445.html The size was changed to 18 which seems to work (as you found yourself). I don't know what size or algorithm MS uses to determine when to switch the drawn style, but noone has reported an issue with this since then. You should maybe consider working with a more up to date Wine version, since that patch was committed over 2 months ago. Hope that helps, Jon "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Mail - Find what you need with new enhanced search. http://info.mail.yahoo.com/mail_250

1 0

Re: [OLE #84] Don't use IsBadStringPtr on NULL pointers
by Alexandre Julliard 24 Mar '05

24 Mar '05

Mike Hearn <mike(a)navi.cx> writes: > Don't use IsBadStringPtr on NULL pointers If the goal is to avoid exceptions, then it would be better to do that check directly in the IsBad* functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Treeview plus/minus
by George Ginden 24 Mar '05

24 Mar '05

Talking about the plus / minus symbols in the treeview control... Why with a size of 16 the plus symbol looks more like a small circle than a cross ? If I change the size to 18 the plus is drawn correctly Does anybody knows anything about this ? Regards. @@ -2329,7 +2330,7 @@ SelectObject(hdc, hOldPen); DeleteObject(hNewPen); - if (height < 16 || width < 16) + if (height < 18 || width < 18) {

1 0

[RFC] Pager: why do we implement WM_NCPAINT instead of WM_PAINT?
by Dimitrie O. Paun 24 Mar '05

24 Mar '05

Hi folks, Does anyone know why the Pager common control (dlls/comctl32/pager.c) implements WM_NCPAINT instead of WM_PAINT? It is the only exception to the rule, all other controls implement WM_PAINT. -- Dimi.

2 1

World of Warcraft
by cyrix12＠cox.net 24 Mar '05

24 Mar '05

Sorry to keep bugging you guys about this, but a recent patch broke the opengl mode of World of Warcraft again. It simply fails to start, similar to the d3d mode (except for the fact that I know why d3d mode doesn't work as of now). I was scanning through the traces and saw no errors though. Seemed odd to me, but I'm not a wine programmer so I'm not exactly sure what to look for anyway. If anyone wants me to send a any sort of debug log (if, for instance, you don't have copy of WoW to test on), let me know (include what you'd want to see as well, if you don't mind). Thanks in advance, Darckness

3 7

Segfault in X11DRV_DIB_BuildColorTable (DIB_PAL_COLORS)
by Jesse D Zbikowski 23 Mar '05

23 Mar '05

I am experiencing a crash during startup of an application (The Rosetta Stone 2.0.7a) under Wine. I reported this earlier on wine-users and after some debugging was advised to move to this list. The line causing a problem is dlls/x11drv/dib.c:425 417 HPALETTE hpal = GetCurrentObject(physDev->hdc, OBJ_PAL); 418 PALETTEENTRY pal_ents[256]; 419 WORD *index = (WORD*) ((LPBYTE) info + (WORD) info->bmiHeader.biSize); 420 421 GetPaletteEntries(hpal, 0, 256, pal_ents); 422 423 for(i = 0; i < colors; i++, index++) 424 { =>425 colorTable[i].rgbRed = pal_ents[*index].peRed; 426 colorTable[i].rgbGreen = pal_ents[*index].peGreen; 427 colorTable[i].rgbBlue = pal_ents[*index].peBlue; 428 colorTable[i].rgbReserved = 0; 429 } This happens when X11DRV_DIB_BuildColorTable() is called with coloruse==DIB_PAL_COLORS, meaning we use an 8-bit palette. It seems to me that (LPBYTE)info must be corrupt and is giving a corrupt value to (WORD)index. Wine-dbg>p i 0 Wine-dbg>p colorTable[i] {rgbBlue=0, rgbGreen=0, rgbRed=0, rgbReserved=0} Wine-dbg>p pal_ents {{peRed=0, peGreen=0, peBlue=0, peFlags=0}, ... } Wine-dbg>p pal_ents[0] {peRed=, peGreen= Exception c0000005 Wine-dbg>p index 0x77aaec20 Wine-dbg>p *index No type or type mismatch Wine-dbg>p info fixme:winedbg:print_value ---error Here is the backtrace. fixme:font:GetKerningPairsW (0x1a28,0,(nil)): almost empty stub! First chance exception: page fault on read access to 0x77ab71cc in 32-bit code (0x7fea1e53). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:7fea1e53 ESP:77aae66c EBP:77aaea98 EFLAGS:00010287( - 00 RISP1C) EAX:000022d0 EBX:7fef22c4 ECX:7786aee0 EDX:00000000 ESI:7e042900 EDI:77aaec20 Stack dump: 0x77aae66c: 00000044 00000000 00000100 77aae68c 0x77aae67c: 00000400 00000000 00000100 00000001 0x77aae68c: 00000000 00000080 00008000 00008080 0x77aae69c: 00800000 00800080 00808000 00c0c0c0 0x77aae6ac: 00c0dcc0 00f0caa6 00f0fbff 00a4a0a0 0x77aae6bc: 00808080 000000ff 0000ff00 0000ffff Backtrace: =>1 0x7fea1e53 X11DRV_DIB_BuildColorTable+0x173(physDev=0x7e042408, coloruse=0x1, depth=0x8, info=0x77aaebf8) [/home/jesse/wine/dlls/x11drv/dib.c:425] in x11drv (0x77aaea98) 2 0x7feaa20b X11DRV_DIB_CreateDIBSection+0x22b(physDev=0x7e042408, bmi=0x77aaebf8, usage=0x1, bits=0x7d7703ec, section=0x0, offset=0x0, ovr_pitch=0x0) [/home/jesse/wine/dlls/x11drv/dib.c:4749] in x11drv (0x77aaeb5c) 3 0x77824ab3 DIB_CreateDIBSection+0xa3(hdc=0x5b5c, bmi=0x77aaebf8, usage=0x1, bits=0x7d7703ec, section=0x0, offset=0x0, ovr_pitch=0x0) [/home/jesse/wine/dlls/gdi/dib.c:1107] in gdi32 (0x77aaeb90) 4 0x77824b28 CreateDIBSection+0x48(hdc=0x5b5c, bmi=0x77aaebf8, usage=0x1, bits=0x7d7703ec, section=0x0, offset=0x0) [/home/jesse/wine/dlls/gdi/dib.c:1125] in gdi32 (0x77aaebb8) 5 0x690323bb 1680 in iml32 (0x7b1c7b8c) 6 0x00000264 (0x00000010) 7 0x00000000 (0x00000000) 0x7fea1e53 X11DRV_DIB_BuildColorTable+0x173 [/home/jesse/wine/dlls/x11drv/dib.c:425] in x11drv: movzbl 0xfffffbf4(%ebp,%eax,4),%eax 425 colorTable[i].rgbRed = pal_ents[*index].peRed; I can add a breakpoint before we get here and try to step through, although the flow seems to skip around a bit. Wine-dbg>b X11DRV_DIB_BuildColorTable Breakpoint 1 at 0x7fea1d04 X11DRV_DIB_BuildColorTable+0x24 [/home/jesse/wine/dlls/x11drv/dib.c:377] in x11drv Wine-dbg>cond 1 (coloruse == 1) 417 HPALETTE hpal = GetCurrentObject(physDev->hdc, OBJ_PAL); Wine-dbg>n 419 WORD *index = (WORD*) ((LPBYTE) info + (WORD) info->bmiHeader.biSize); Wine-dbg>n 417 HPALETTE hpal = GetCurrentObject(physDev->hdc, OBJ_PAL); Wine-dbg>n 421 GetPaletteEntries(hpal, 0, 256, pal_ents); Wine-dbg>n 419 WORD *index = (WORD*) ((LPBYTE) info + (WORD) info->bmiHeader.biSize); Wine-dbg>n 421 GetPaletteEntries(hpal, 0, 256, pal_ents); Wine-dbg>n 423 for(i = 0; i < colors; i++, index++) Wine-dbg>n 421 GetPaletteEntries(hpal, 0, 256, pal_ents); Wine-dbg>n 423 for(i = 0; i < colors; i++, index++) Wine-dbg>n 425 colorTable[i].rgbRed = pal_ents[*index].peRed; Wine-dbg>s 868 switch(rec->ExceptionCode) Wine-dbg>s 867 { Wine-dbg>s 868 switch(rec->ExceptionCode) Wine-dbg>s 873 if (!(rec->ExceptionCode = VIRTUAL_HandleFault( (void *)rec->ExceptionInformation[1] ))) Wine-dbg>s 1125 DWORD ret = EXCEPTION_ACCESS_VIOLATION; I am using the latest Wine I built from CVS, after first encountering this problem in the 20050111 and 20050310 Gentoo ebuilds. I have a Linux 2.6.11 system with glibc 2.3.4 20040808 (including nptl), Xorg-x11 6.8.2-rc2 (Trident Cyberblade/i1 "trident_drv.o") @1024x768 16bpp. Also tried kernels 2.6.9 & 2.6.10 and 800x600 24bpp mode. Would appreciate any advice on how to proceed. http://www.winehq.org/hypermail/wine-users/2005/03/0293.html http://www.winehq.org/hypermail/wine-users/2005/03/0296.html http://appdb.winehq.org/appview.php?appId=1867 Thanks, Jesse Z.

2 2

[AppDB] Application queue: Getting ahead of me.
by Tony Lambregts 23 Mar '05

23 Mar '05

I will be unable to tend to the application queue for the next week and as a matter of fact I am already behind maintaining it. (sorry). If one of you good souls (with administrative rights) could take could take care of it for the next week I would really appreciate it. Thanks. -- Tony Lambregts

1 0

World of Warcraft
by cyrix12＠cox.net 23 Mar '05

23 Mar '05

What I meant to say in the previous message was something along the lines of "Here's an opengl trace; let me know if you need any others." Unfortunately, it seemed to come out in some other language which I am not familiar in. So here's the opengl trace. Darckness

1 0

Re: DDRAW: Surface locking patch, take 2
by Tony Lambregts 23 Mar '05

23 Mar '05

Matthew Mastracci wrote: > This patch (correctly) fixes the locking problems in SimCity 3000. We > now check to see if the blit src and dest are the same surface and, if > so, we make sure to lock the surface only once and, in the case of > BltFast, re-adjust the surface pointers. This patch also makes sure the > surfaces are correctly unlocked if a bad rectangle is passed. > > ChangeLog > Correctly lock and unlock surface for a single-surface Blt() and > BltFast() call. > Is there anything wrong with this patch. http://www.winehq.org/hypermail/wine-patches/2005/03/0113.html It works fine for me (and SimCity). and I was wondering why it was not applied. -- Tony Lambregts

1 0

Riched20: regression "beta" not shown; tab-wish
by Tobias Burnus 23 Mar '05

23 Mar '05

Hello, first I'd really like to thank the riched20 workers, notably Krzysztof Foltman and Phil Krylov. For the application Diamond it made a big difference: Instead of "[[Aring]]" etc. one sees the proper symbol and it looks much nicer. But the biggest advantage is that one can now copy or save the text; before the app was simply crashing! Regression: One of the later riched20 patches, possibly http://cvs.winehq.org/patch.py?id=16672, caused a regression with the richedit control in Diamond. Before it showed a beta character from the Symbol font, now it only shows a box ("[]"). If one saves the output (rtf export) one sees ------------------- {\rtf1\ansi\ansicpg1252\uc1\deff0\deflang1031\deflangfe1031{\fonttbl{\f0 Times New Roman;} {\f1\fcharset0 System;} {\f2\fcharset2 Symbol;} }{\*\generator Wine Riched20 2.0.????;}\pard\li0\fi0\ri0{\b\fs18\ul Bibliographic data} \par\pard\li0\fi0\ri0 [...] \par\pard\li0\fi0\ri0{\fs18 }{\i\fs18 b}{\fs18 = 5.8312(2) \'c5} \par\pard\li0\fi0\ri0{\fs18 }{\i\fs18 c}{\fs18 = 7.9564(2) \'c5} \par\pard\li0\fi0\ri0{\fs18 }{\fs18\f2 \u61538?}{\fs18 = 100.77(0) \u176?} ------------------- In the last line, after the \f2 (Symbol font), there should be a beta ("b" + Symbol font). Trace (starting from the "b = 5.8312(2)"): ------------ trace:richedit:ME_CheckCharOffsets run, real ofs = 1 (+ofsp = 177), counted = 177, len = 1, txt = "L"b"", flags=00000000, fx&mask = 44000002 trace:richedit:ME_CheckCharOffsets run, real ofs = 2 (+ofsp = 178), counted = 178, len = 14, txt = "L" = 5.8312(2) \00c5"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 16 (+ofsp = 192), counted = 192, len = 1, txt = "L"\00b6"", flags=00100000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets para, real ofsp = 193, counted = 193 trace:richedit:ME_CheckCharOffsets run, real ofs = 0 (+ofsp = 193), counted = 193, len = 1, txt = "L"\t"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 1 (+ofsp = 194), counted = 194, len = 1, txt = "L"c"", flags=00000000, fx&mask = 44000002 trace:richedit:ME_CheckCharOffsets run, real ofs = 2 (+ofsp = 195), counted = 195, len = 14, txt = "L" = 7.9564(2) \00c5"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 16 (+ofsp = 209), counted = 209, len = 1, txt = "L"\00b6"", flags=00100000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets para, real ofsp = 210, counted = 210 trace:richedit:ME_CheckCharOffsets run, real ofs = 0 (+ofsp = 210), counted = 210, len = 1, txt = "L"\t"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 1 (+ofsp = 211), counted = 211, len = 1, txt = "L"\f062"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 2 (+ofsp = 212), counted = 212, len = 14, txt = "L" = 100.77(0) \00b0"", flags=00000000, fx&mask = 44000000 trace:richedit:ME_CheckCharOffsets run, real ofs = 16 (+ofsp = 226), counted = 226, len = 1, txt = "L"\00b6"", flags=00100000, fx&mask = 44000000 ------------ * * * * One feature request: Currently, tabs are shown as box ("[]"), how about replacing them with a simple space - that would increase the readability a lot. Compare: WINE-CVS: http://www.physik.fu-berlin.de/~tburnus/wine/diamond3.png Windows: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list.png Tobias

1 0

Re: Native stack overlapping system heap base address on some systems
by Steven Edwards 23 Mar '05

23 Mar '05

Hi, --- Alexandre Julliard <julliard(a)winehq.org> wrote: > > Surprise surprise, 0x7fffb000 + (1024 * 20) == 0x80000000 This looks like what I have seen on some users systems running Suse 9.2. Some users see errors like this err:virtual:NtMapViewOfSection map_file_into_view 0x80000000 1000000 000000000 failed err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not available > No it doesn't overlap, a 20K mapping at 7fffb000 ends at > 7fffffff. Most likely that kernel is configured for a 2Gb virtual > address space. I will recompile a kernel with 2GB and see what happens. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

1 0

Re: lostwages/templates/en contributing.template j ...
by Jakob Eriksson 23 Mar '05

23 Mar '05

I submitted a patch for all casts I could find with that little grep: find . -name "*.[ch]" | xargs egrep "\) *Heap(Re)?Alloc" Jeremy Newman wrote: >ChangeSet ID: 16817 >CVSROOT: /opt/cvs-commit >Module name: lostwages >Changes by: jnewman(a)wine.codeweavers.com 2005/03/23 08:56:08 > >Modified files: > templates/en : contributing.template janitorial.template > resources.template sending_patches.template > status.template > >Log message: > Mike McCormack <mike(a)codeweavers.com> > * suggest janitoral project > * other updates and W3 fixes > >Patch: http://cvs.winehq.org/patch.py?id=16817 > >Old revision New revision Changes Path > 1.24 1.25 +3 -3 lostwages/templates/en/contributing.template > 1.73 1.74 +17 -7 lostwages/templates/en/janitorial.template > 1.11 1.12 +1 -1 lostwages/templates/en/resources.template > 1.11 1.12 +2 -0 lostwages/templates/en/sending_patches.template > 1.33 1.34 +1 -1 lostwages/templates/en/status.template > > >

1 0

Native stack overlapping system heap base address on some systems
by Mike Hearn 23 Mar '05

23 Mar '05

Hi, Bug #2741 comes from a user who was able to grab a dump of the VM mappings when the following error occurred: HEAP_CreateSystemHeap system heap base address 0x80000000 not available I know people have been seeing this intermittently for a while now, we have a few CodeWeavers support tickets with this problem too. The issue seems to be that the Linux native (main thread) stack was allocated here: 7fffb000 20K rwx-- [ stack ] Surprise surprise, 0x7fffb000 + (1024 * 20) == 0x80000000 Unfortunately I lack enough knowledge about the kernels VM algorithms to say why it's being allocated here. For comparison on my Fedora Core 3 machine: fef0d000 16K rwx-- [ stack ] One other thing I don't understand. It seems the stack and the system heap overlap by exactly 1 byte, otherwise the mmap would not fail. But, this area is (theoretically) being protected by the preloader: so how can this be? There is something I'm missing here, I suspect an off-by-one error in my arithmetic. thanks -mike

2 1

Re: Warn users who attempt to use native DirectDraw
by Andreas Mohr 23 Mar '05

23 Mar '05

Hi, On Tue, Mar 22, 2005 at 02:26:43PM +0000, Mike Hearn wrote: > + MESSAGE("**********************************************************************"); > + MESSAGE("* Native DirectDraw is not supported, please remove it and try again *"); > + MESSAGE("**********************************************************************"); For such a big message it's still rather unclear/misleading. What about something similar to: *************** Native DirectDraw is not supported by Wine! *************** ****** Please disable loading of any native DDraw DLLs and try again ****** Andreas Mohr

6 7

Re: fix wrc to parse some Borland dialog resources
by Michael Lin 23 Mar '05

23 Mar '05

Robert Shearman wrote: >Filip Navara wrote: > >> Michael Lin wrote: >> >>> * change wrc to parse '&' and '~' when specifying style >> >> >> I believe the attached patch would be better solution...you can use >> arbitrary expressions in the style definitions with Microsoft Resource >> Compiler... >In that case, "style '|' style" and "tNOT xpr" are already handled by >the xpr rules so this can be made a lot simpler. Hi all, Just want to bring up this topic again. From what Robert suggested, the style rule can be reduced to the following: style : xpr { $$ = new_style($1, 0); } ; However, this will render the style->and_mask useless as it is never used. In style expression, '~' and tNOT are treated differently. '~' is applied as it is parsed, ie from left to right like normal expressions. However, tNOT is applied at the very end, after all other or_mask are combined and I believe this is why there are or_mask and and_mask in style. xpr won't work here as it treats tNOT and '~' the same. So adding '&' and '~' might be a better solution here. Michael

1 0

Re: registry TODO
by Steven Edwards 23 Mar '05

23 Mar '05

Hi, --- Boaz Harrosh <boaz(a)hishome.net> wrote: > How is ReactOS's current (future) system? I think ReactOS's registry is binary compatible with NT4. It and the windows 2000 format was documented/reversed for samba and the linux ntchpwd bootdisk projects. If I remeber right Eirc Kohl offered to release some of his work to Wine for the binary format so you might want to ping him about the implementation details. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/

2 1

Re: dlls/user/button.c - fix AUTO3STATE with BS_OWNERDRAW (Resend)
by Alexandre Julliard 23 Mar '05

23 Mar '05

Michael Lin <mlin(a)corvu.com.au> writes: > inline static UINT get_button_type( LONG window_style ) > { > - return (window_style & 0x0f); > + if ((window_style & BS_OWNERDRAW) == BS_OWNERDRAW) > + return BS_OWNERDRAW; > + else > + return (window_style & 0x0f); BS_OWNERDRAW is not a bit mask, this won't work right. What is the problem you are trying to fix? -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: Warn users who attempt to use native DirectDraw
by Vincent Béron 22 Mar '05

22 Mar '05

Le mar 22/03/2005 à 09:26, Mike Hearn a écrit : [snip] > Index: dlls/gdi/gdi_main.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/gdi_main.c,v > retrieving revision 1.17 > diff -u -p -d -r1.17 gdi_main.c > --- dlls/gdi/gdi_main.c 15 Jan 2004 00:35:40 -0000 1.17 > +++ dlls/gdi/gdi_main.c 22 Mar 2005 14:15:33 -0000 > @@ -24,9 +24,12 @@ > #include "winbase.h" > #include "wingdi.h" > #include "wine/winbase16.h" > +#include <wine/debug.h> Please use "" instead of <> here. Vincent

1 0

msi.spec different parameter count of exported functions
by Stefan Leichter 22 Mar '05

22 Mar '05

Hello, when played with native msi.dll i found three functions with have a different parameter count between msi.spec of wine and the native dll. Here are the snoop logs of the native dll and wine: 0009:RET msi.MsiDatabaseImportA(00000000,00000000,00000000) retval=00000006 ret=004013fc 0009:RET msi.MsiDatabaseImportW(00000000,00000000,00000000) retval=00000006 ret=004013fc 0009:RET msi.MsiCreateAndVerifyInstallerDirectory(00000000) retval=00000000 ret=004013fc I have used the msi.dll version 2.6.2600.11833 for testing. The question now is: Can we trust the +snoop logging? Bye Stefan

2 2

Re: msi: WriteRegistryData advoid NULL data
by Alexandre Julliard 22 Mar '05

22 Mar '05

Aric Stewart <aric(a)codeweavers.com> writes: > Win9x RegSetValueExW does not deal with NULL data. so make the data an > empty string instead of null The value is freed later on so this will cause trouble. A better fix is probably to not specify REG_SZ if you are not passing a valid string. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Another one from last night: fix for dlls/kernel/tests/time.c on Windows 98
by Alexandre Julliard 22 Mar '05

22 Mar '05

Jakob Eriksson <jakov(a)vmlinux.org> writes: > + /* Windows 98 is a bit broken around these parts, it doesn't return FALSE as it should. */ > + /* If the resulting time is about 10000 AD, I consider the result invalid. */ > + ret = DosDateTimeToFileTime(0,0,&ft); > + years = ((unsigned)ft.dwHighDateTime * 120) / 24 / 365; That formula doesn't seem right to me. Could you please explain what you are doing here? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: More trace info - dlls/shlwapi/tests/shreg.c
by Paul Vriens 22 Mar '05

22 Mar '05

On Tue, 2005-03-22 at 17:16, Jakob Eriksson wrote: > http://test.winehq.org/data/200503181000/nt4/shlwapi:shreg.txt > > What's going on? > > > regards, > Jakob > > > ______________________________________________________________________ > Index: dlls/shlwapi/tests/shreg.c > =================================================================== > RCS file: /home/wine/wine/dlls/shlwapi/tests/shreg.c,v > retrieving revision 1.25 > diff -u -r1.25 shreg.c > --- dlls/shlwapi/tests/shreg.c 3 Feb 2005 19:38:58 -0000 1.25 > +++ dlls/shlwapi/tests/shreg.c 22 Mar 2005 16:15:56 -0000 > @@ -248,7 +248,7 @@ > todo_wine > { > ok( (0 == strcmp("", buf)) | (0 == strcmp(sEnvvar2, buf)), > - "Expected empty or first part of the string (win98), got (%s)\n", buf); > + "Expected empty or first part of the string \"%s\", got \"%s\"\n", sEnvvar2, buf); > } > > ok( dwSize >= nUsedBuffer2, "Buffer size (%lu) should be >= (%lu)\n", dwSize, nUsedBuffer2); Hi, one of the things that's strange about this system was reported by me on wine-devel a few days ago: http://www.winehq.org/hypermail/wine-devel/2005/03/0889.html any idea? Paul.

1 0

Broken winetest compilation
by Paul Millar 22 Mar '05

22 Mar '05

Hi, Building winetests is broken again (see errors at end of email). Is this the usual mingw missing functions again? Cheers, Paul. PS, actually there's another problem to do with a RAID system dying. I'll relocate the webpages to somewhere a bit better. i686-mingw32msvc-gcc db.o record.o suminfo.o testlist.o -o msi_test.exe -lmsi -lkernel32 suminfo.o(.text+0x405): In function `func_suminfo': /home/paul/Production/wine-cross-source/dlls/msi/tests/suminfo.c:111: undefinedreference to `MsiSummaryInfoSetPropertyA@24' suminfo.o(.text+0x473):/home/paul/Production/wine-cross-source/dlls/msi/tests/suminfo.c:114: undefined reference to `MsiSummaryInfoSetPropertyA@24' suminfo.o(.text+0x4dc):/home/paul/Production/wine-cross-source/dlls/msi/tests/suminfo.c:117: undefined reference to `MsiSummaryInfoSetPropertyA@24' suminfo.o(.text+0x545):/home/paul/Production/wine-cross-source/dlls/msi/tests/suminfo.c:120: undefined reference to `MsiSummaryInfoSetPropertyA@24' suminfo.o(.text+0x637):/home/paul/Production/wine-cross-source/dlls/msi/tests/suminfo.c:130: undefined reference to `MsiSummaryInfoSetPropertyA@24' suminfo.o(.text+0x69f):/home/paul/Production/wine-cross-source/dlls/msi/tests/suminfo.c:133: more undefined references to `MsiSummaryInfoSetPropertyA@24' follow suminfo.o(.text+0xea6): In function `func_suminfo': /home/paul/Production/wine-cross-source/dlls/msi/tests/suminfo.c:197: undefinedreference to `MsiSummaryInfoPersist@4' distcc[17612] ERROR: compile on localhost failed make: *** [msi_test.exe] Error 1

2 2

Re: Fix Win95 advapi crypt test - dlls/advapi32/tests/crypt.c
by Alexandre Julliard 22 Mar '05

22 Mar '05

Jakob Eriksson <jakov(a)vmlinux.org> writes: > --- dlls/advapi32/tests/crypt.c 15 Mar 2005 19:32:38 -0000 1.19 > +++ dlls/advapi32/tests/crypt.c 22 Mar 2005 15:31:55 -0000 > @@ -138,7 +138,10 @@ > hProv = 0; > SetLastError(0xdeadbeef); > result = pCryptAcquireContextA(&hProv, szKeySet, szRsaBaseProv, PROV_RSA_FULL, 0); > - ok(result && (GetLastError() == ERROR_ENVVAR_NOT_FOUND || GetLastError() == ERROR_SUCCESS || GetLastError() == ERROR_RING2_STACK_IN_USE || GetLastError() == NTE_FAIL), "%d/%ld\n", result, GetLastError()); > + ok(result && (GetLastError() == ERROR_ENVVAR_NOT_FOUND || GetLastError() == ERROR_SUCCESS || > + GetLastError() == ERROR_RING2_STACK_IN_USE || GetLastError() == NTE_FAIL || > + GetLastError() == ERROR_NOT_LOGGED_ON), > + "%d/%ld\n", result, GetLastError()); When there are more than 2 or 3 possible last error returns, we should simply get rid of the test. It's very unlikely that any app would rely on the value if it's different on every Windows install. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: KERNEL: PeekNamedPipe must check for zero-length buffer as well as for NULL buffer
by Jakob Eriksson 22 Mar '05

22 Mar '05

Alex Villacis Lasso wrote: > > Changelog: > * PeekNamedPipe now checks both for a NULL buffer and a zero-length > buffer before trying to recv() from the pipe Could you write a regression test? regards, Jakob

1 0

Re: NTDLL: teach wine about Mingw32 (RESUBMIT)
by Steven Edwards 22 Mar '05

22 Mar '05

Hi, --- "C. Scott Ananian" <cscott(a)cscott.net> wrote: > This patch seems to have gotten lost: it was sent last Thursday but hasn't > yet been applied or rejected (as far as I can tell). It's even got a > testimonial from a wine developer: Andreas Mohr says, "Nice patch." =) I don't understand why Mingw does not report the same value as the Windows compiler here. Do you know lcc or and other free compiler based application need this? If not maybe it should be fixed in mingw. Thanks Steven __________________________________ Do you Yahoo!? Make Yahoo! your home page http://www.yahoo.com/r/hs

2 1

Re: registry TODO
by Filip Navara 22 Mar '05

22 Mar '05

Boaz Harrosh wrote: > Thomas Weidenmueller wrote: > >>> How is ReactOS's current (future) system? >> >> See above > > I was Just asking what ReactOS is doing, not that they need change. > ReactOS is different in this respect, I agree. > Is ReactOS's format the same as Windows. or do you have your own > Binary format? We use the a Windows registry format, but since some field haven't been reversed yet it is not 100% compatible... ;-) The registry files are mapped as sections in memory along with some other control data stored in non-paged pool. - Filip

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel