- wine-devel - winehq.org

Re: [DPLAYX] fix bug 872
by Alexandre Julliard 09 Mar '05

09 Mar '05

Raphael <fenix(a)club-internet.fr> writes: > Hi, > > cf http://bugs.winehq.org/show_bug.cgi?id=872 > > Seems he have created events (hTemps) leaks no ? I'm not sure why that code uses global handles at all, since they get duplicated in the target process anyway; it seems to me you could simply get rid of the ConvertToGlobalHandle calls. If that doesn't work the code needs to be fixed, global handles are a Win9x abomination that should never be used. -- Alexandre Julliard julliard(a)winehq.org

3 3

re: Why not build wine server as a linux kernel module?
by Dan Kegel 09 Mar '05

09 Mar '05

su_hang_ab(a)163.com wrote: > May I ask you a question? > Why not build wine server as a linux kernel module? > I think the performance of a kernel module is better than a separate > process. > If anyone can give me a reasonable answer, I would really appreciate it. It's been tried. It will be tried again in the future, I'm sure. For the moment, though, just getting things working properly is a big enough challenge without involving the kernel. See e.g. http://www.winehq.com/site/?issue=178#Viva%20la%20Kernel%20Module%20Idea for previous discussions on the topic. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [winecfg] Audio device selection
by Alexandre Julliard 09 Mar '05

09 Mar '05

Paul van Schayck <polleke(a)gmail.com> writes: > This is a resend. Patch was rejected probably because we don't want > this kind of settings in winecfg. Let me explain myself closer. > The patch allows the alsa audio device to be changed from audio tab. > It will just use default otherwise. Which is just fine for most users. The main problem is that this option is completely obscure; what are you supposed to enter in there? It should be a drop down listing possible devices. -- Alexandre Julliard julliard(a)winehq.org

3 2

unixfs
by Michael Jung 09 Mar '05

09 Mar '05

Hello, Could you please tell me if you consider the unixfs shell namespace extension, which I've sent to wine-patches last week, a sensible way to go in order to access the unix filesystem from winecfg? I know that there is room for improvements, and I'm working on it. But if you think it is not the right thing to do, I will stop working on it and save some time for other stuff. Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

3 4

Re: WIDL - Sync to ReactOS 20050308
by Alexandre Julliard 08 Mar '05

08 Mar '05

Steven Edwards <steven_ed4153(a)yahoo.com> writes: > No one really got back to me on how handles should be done in the dcom.idl so I am going assume > this is correct. If this has gotten too big let me know and I can break it up in to smaller > patches over the next week. Yes please, every separate change should be a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

XML escaping problem in WWN 264
by Francois Gouget 08 Mar '05

08 Mar '05

In WWN 264 there's the following: <rant> ... </rant> But it does not get through in the HTML page because it's getting transformed into <rant>...</rant> which the browser is correctly ignoring. We've had this problem before but I don't remember what the fix is... Do you? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

5 4

Re: WIDL - Sync to ReactOS 20050308
by Rob Shearman 08 Mar '05

08 Mar '05

Steven Edwards wrote: >No one really got back to me on how handles should be done in the dcom.idl so I am going assume >this is correct. If this has gotten too big let me know and I can break it up in to smaller >patches over the next week. > > Sorry Steven, I meant to investigate this before but I forgot. >Index: dlls/ole32/dcom.idl >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/dcom.idl,v >retrieving revision 1.1 >diff -u -b -r1.1 dcom.idl >--- dlls/ole32/dcom.idl 22 May 2003 03:36:26 -0000 1.1 >+++ dlls/ole32/dcom.idl 8 Mar 2005 18:28:18 -0000 >@@ -217,6 +217,7 @@ > > cpp_quote("#if 0") > [ >+ explicit_handle, > uuid(99fcfec4-5260-101b-bbcb-00aa0021347a), > pointer_default(unique) > ] > > explicit_handle is an ACF attribute and not something that should normally be put in an IDL file. Furthermore, it is not necessary, as stated by MSDN: "If the *[explicit_handle]* attribute is not used, the application can still specify that an operation have an explicit handle (binding or serialization) directing the call." I think there is an MIDL command-line option to allow ACF attributes in IDL files though. Rob

1 0

Re: More implementation of IRecordInfo
by Maxime Bellengé 08 Mar '05

08 Mar '05

You have forgotten the patch :) On Tue, 2005-03-08 at 20:18 +0100, Jacek Caban wrote: > This patch makes IRecordInfo almost complete. > If anyone knows any application using it I could test on, > please let me know. > > Changelog: > More implementation of IRecordInfo > >

1 0

Re: [PATCH] Add search functionality to WINE regedit
by Oliver Stieber 08 Mar '05

08 Mar '05

--- Mike Hearn <mike(a)navi.cx> wrote: > Jan Schiefer wrote: > > It's already fully cleaned up and ready to go! I > know other people hate > > my coding style... :) > > Awww, it's not hate, you just need to be careful > about how the code is > laid out and what features you use. You'll need to > fix this patch in a > few places so here are some comments: > Also.. if(uMsg != 193) { // if uMsg == 193, tmpLen is always 0! no C++ style comments. try to use /* comment */ I use this a file containing ^[[:space:]]+# // /\*[^[:space:]]\w \w[^[:space:]]\*/ if\( )[[:alpha:]] with find -mtime -10 -iregex ".*\.[c | h]" -exec egrep --file="filewithchecks" "{}" -n \; -print add -wError and -Werror-implicit-function-declaration and -Wdeclaration-after-statement for gcc >= 3.4 to cflags in your Makefile. I'll post a patch so that the whole of wine can be built with -wError on gcc >=3.3 soon, for the brave use: (long long) for shift errors >> 32 is greater than .... programs/winehlp uses %x so the Makefile needs -Wno-format-y2k in it's CFLAGS and add register int src char * in libs/port/memmove.c Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Re: [PATCH] Add search functionality to WINE regedit
by Mike Hearn 08 Mar '05

08 Mar '05

Jan Schiefer wrote: > It's already fully cleaned up and ready to go! I know other people hate > my coding style... :) Awww, it's not hate, you just need to be careful about how the code is laid out and what features you use. You'll need to fix this patch in a few places so here are some comments: It's usually a good idea to submit the backend *first* and then the frontend, or better .. have them done all at once. Patches are supposed to be standalone, not stuff that'll only start working later (in the general case). For now I'd combine the two patches. > + GROUPBOX "Look at",IDC_FIND_GROUPBOX, 5, 25, 194, 46, BS_GROUPBOX > + CHECKBOX "Keys", IDC_CHECKBOX_KEYS, 10, 36, 60, 10 Try and keep alignment consistent, otherwise there's just extra visual noise for no good reason! > +LRESULT CALLBACK findedit_proc (HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam) { > +if(uMsg != 193) { // if uMsg == 193, tmpLen is always 0! > +int tmpLen = SendMessage(hWnd, EM_LINELENGTH, 0, 0); > +if(tmpLen != searchStringLen) { > +if(tmpLen > 0)EnableWindow(hFindButton, TRUE); > +else EnableWindow(hFindButton, FALSE); > +searchStringLen = tmpLen; > +} > +} > +return CallWindowProc ((WNDPROC) prevWndProcEdit, hWnd, uMsg, wParam, lParam); > +} I'm afraid that unless my mail client is playing up that type of code isn't acceptable. You need to use indenting! Also please try and space stuff out, eg rather than: if(tmpLen > 0)EnableWindow use if (tmpLen > 0) EnableWindow(....); > + > +INT_PTR CALLBACK searchingdlg_proc(HWND hWnd, UINT uMsg, WPARAM wParam,LPARAM lParam) { > + switch(uMsg) { > + case WM_INITDIALOG: > + //SearchRegistryRecrusively("",HKEY_CLASSES_ROOT,TRUE); No C++/C99 style comments unfortunately. Also please don't submit patches that have code commented out for no obvious reason. > + break; > + case WM_COMMAND: > + switch(LOWORD(wParam)) { > + case IDCANCEL: > + HeapFree(GetProcessHeap(),0,searchString); > + EndDialog(hWnd, 0); > + return(TRUE); > + break; > + } Indenting is good, but indenting consistently is even better! > + break; > + } > + > +return(FALSE); > +} > + > +INT_PTR CALLBACK finddlg_proc(HWND hWnd, UINT uMsg, WPARAM wParam,LPARAM lParam) { > + > + switch(uMsg) { > + case WM_INITDIALOG: > + hFindEdit = GetDlgItem(hWnd, IDC_FINDEDIT); > + hFindButton = GetDlgItem(hWnd, IDOK); > + prevWndProcEdit = SetWindowLongPtr (hFindEdit, GWLP_WNDPROC, (LONG_PTR) findedit_proc); > + EnableWindow(hFindButton, FALSE); > + CheckDlgButton( hWnd, IDC_CHECKBOX_KEYS, BST_CHECKED ); > + CheckDlgButton( hWnd, IDC_CHECKBOX_VALUES, BST_CHECKED ); > + CheckDlgButton( hWnd, IDC_CHECKBOX_DATA, BST_CHECKED ); > + return(TRUE); I think you may be mixing tabs and spaces or something here. Also making return look like a function is rather non-standard for C, use it as a statement: return TRUE; > + break; > + case WM_COMMAND: > + switch(LOWORD(wParam)) { > + case IDOK: > + searchString = (LPTSTR)HeapAlloc(GetProcessHeap(),0,searchStringLen + 1); > + GetWindowText(hFindEdit, searchString, searchStringLen + 1 ); > + > + searchForKeys = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_KEYS ) == BST_CHECKED); > + searchForValues = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_VALUES ) == BST_CHECKED); > + searchForData = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_DATA ) == BST_CHECKED); > + searchMatchWholeString = (IsDlgButtonChecked( hWnd, IDC_CHECKBOX_MATCHSTRING ) == BST_CHECKED); If you're going to fall through please put a comment like /* fall through */ otherwise it looks an awful lot like a mistake. thanks -mike

1 0

Suggestion For Wine Loader
by Jason Couture 08 Mar '05

08 Mar '05

How hard would it be to introduce a "Re-Compiler" instead of an interpreter? To convert PE -> ELF without having the source. The output would not have to be a user runnable file maybe just a cache? Possiable Speed up? To avoid copyright issues maybe the elf could require the pe to run? In my experience JIT Compiling or interpreting is much slower than a recompiled program... Let me know what you people think.

4 4

Gmail accounts
by Jason Couture 08 Mar '05

08 Mar '05

Sorry i know this seems like spam but it is an offer. Anyone who emails plaguethenet(a)gmail.com will recieve a gmail invite until i run out of invites. later

1 0

Voodoo3, Banshee and D3D
by Troy Rollo 08 Mar '05

08 Mar '05

---CONTEXT--- <http://dri.sourceforge.net/doc/dri_driver_features.phtml> The Voodoo3/Banshee driver reverts to software rendering under the following conditions: - Setting GL_LIGHT_MODEL_COLOR_CONTROL to GL_SEPARATE_SPECULAR_COLOR. - Enabling line stippling or polygon stippling. - Enabling point smoothing or polygon smoothing. - Enabling line smoothing when line width is not 1.0. That is, antialiased lines are done in hardware only when the line width is 1.0. - Using 1-D or 3-D texture maps. - Using the GL_BLEND texture environment. - Using stencil operations. - Using the accumulation buffer. - Using glBlendEquation(GL_LOGIC_OP). - Using glDrawBuffer(GL_FRONT_AND_BACK). - Using glPolygonMode(face, GL_POINT) or glPolygonMode(face, GL_LINE). - Using point size attenuation (i.e. GL_DISTANCE_ATTENUATION_EXT). - Using glColorMask(r, g, b, a) when r!=g or g!=b. ---END-CONTEXT--- Both wined3d/directx.c and d3d8/directx.c have an IWineD3DImpl_CreateDevice that includes the following call: glLightModeli(GL_LIGHT_MODEL_COLOR_CONTROL, GL_SEPARATE_SPECULAR_COLOR); In effect this prevents WINE from using the Voodoo3 for 3D rendering. Not only does this make D3D games intolerably slow (forget measuring FPS - start measuring FPM or worse), the result for many operations is just plain wrong. Commenting out the offending line makes it work much better (at least until it hits one of the other problems), but with a list of software fallbacks this large, and given that the Voodoo3 is over 5 years old now, there must be some question as to whether this is worth fixing. Is the response to people with this problem "just go pick up an old GeForce card for $30"?

3 3

[HELP] Quartz and FFMpeg question
by Christian Costa 08 Mar '05

08 Mar '05

Hi, I'm working on a video wrapper around libavcodec from FFMpeg. Currently I can play rle, msvideo1 and mjpeg movies. But before submitting anything I must handle the dependency with libavcodec (and maybe libavformat in the future). AFAIK there is no stable API so we need to incorporate FFMpeg source code into the wine tree and update it whenever it's needed. The difficulty here is to add these sources to the build process. There are several solutions : - reuse all FFMpeg build process (configure & makefile) or part of it (makefile only) - add all necessary files in the quartz makefile with slight modifications to FFMpeg sources (IIRC it's what was done in previous quartz code) Currently I use the second solution with all optimizations disabled. This is a bit hackish and not that portable I guess. Enabling optimizations and portability requires using our config.h in FFMpeg sources but also adding additionnal files depending on the platform which complicate things a bit. I'm not a makefile and autoconf expert and before digging deeper I would like some advices. Thansk in advance. Christian

2 1

Re: ScrollDC fixes.
by Alexandre Julliard 08 Mar '05

08 Mar '05

Rein Klazes <wijn(a)wanadoo.nl> writes: > + if(( size = GetRegionData( SrcRgn, 0, NULL )) && > + (rdata = HeapAlloc( GetProcessHeap(), 0, size ))) { > + GetRegionData( SrcRgn, size, rdata ); > + /* the rectangles in the region data are ordered top-to-bottom > + * So if the scrolling is downward, traverse the array backwards > + * to avoid touching pixels that have yet to be scrolled */ > + /* FIXME: implement something similar for left-to-right > + * scrolling. */ > + if( dydev < 0 ) { > + step = 1; > + rect = (RECT *)rdata->Buffer; > + } else { > + step = -1; > + rect = ((RECT *)rdata->Buffer) + rdata->rdh.nCount - 1; > + } > + for( i = 0; i < rdata->rdh.nCount; i++, rect += step) { > + DPtoLP(hdc, (LPPOINT)rect, 2); > + TRACE("Bit blitting %s to %ld,%ld\n", wine_dbgstr_rect(rect), > + rect->left + dx, rect->top + dy); > + BitBlt( hdc, rect->left + dx, rect->top + dy, > + rect->right - rect->left, rect->bottom -rect->top, > + hdc, rect->left, rect->top, SRCCOPY); > + } You really shouldn't need to scroll the region rectangle by rectangle. Selecting the proper clip region and then copying the whole area should have the same effect. > { > XEvent event; > > - XWindowEvent( gdi_display, physDev->drawable, ~0, &event ); > - if (event.type == NoExpose) break; > + if( !XCheckWindowEvent( gdi_display, physDev->drawable, ~0, &event )) > + break; > + if (event.type == NoExpose) continue; You can't use XCheckWindowEvent, you need to wait for the events that haven't arrived yet. -- Alexandre Julliard julliard(a)winehq.org

2 3

documentation for SERVER_START_REQ
by James Hawkins 08 Mar '05

08 Mar '05

Hi, I'm implementing NtLoadKey, but I can't find any documentation on making server requests, ie SERVER_START_REQ, the different tracing abilitites such as using fprintf(stderr,...) instead of the known TRACE, style of code etc. The latter two are not as important to me because I've picked them up while perusing the code, but it might be important to someone who hasn't looked through it before. I do need the semantics for SERVER_START_REQ, so if you could point me in the right direction or tell me I would really appreciate it. -- James Hawkins

3 3

Re: New uninstaller
by Mike McCormack 08 Mar '05

08 Mar '05

Jonathan Ernst wrote: > Here is the new uninstaller. > > I'll be away all this week so I send it already as it works well here > (no regressions found) and has already some more features than the > current one (so Iguess it can be safely committed, but I might be wrong > of course). > > With some help I'll be able to improve it (more unicodification, etc.) > when I'll come back. > > > Changelog: > - new uninstaller > - "find as you type" search > - use dialog instead of window > - internationalization > - more unicodification > - if the uninstaller cannot be found the user can choose to remove the > entry from the registry Hi Jonathan, You'll have more success getting this applied if you send each step as a seperate patch. I suggest starting by sending a single patch that converts the uninstaller to use a dialog instead of a window, adds a dialog resource in English and does nothing else. Once that patch is accepted, move onto the other tasks you have listed above. One step at a time makes the patch easier to review, and reduces the chance that a single line mistake will stop your entire patch from going in. Additionally, there's no need to change the name of main.c to uninstaller.c, that will just make it harder to see what has changed between versions. Mike

2 2

building programs
by Ivan Leo Puoti 08 Mar '05

08 Mar '05

I've got the impression that during program building (clock, notepad etc.) a spec file for them is created on the fly, can someone confirm/dispute this? Ivan.

5 11

Re:avicap32 patch
by luis lenders 08 Mar '05

08 Mar '05

Hi That patch won't work. You forgot to include the changes in the headers in vfw.h I've sent you, e.g. #define WM_CAP_START WM_USER #define WM_CAP_UNICODE_START (WM_USER +100) #define WM_CAP_DRIVER_CONNECT (WM_CAP_START+ 10) #define WM_CAP_DRIVER_DISCONNECT (WM_CAP_START+ 11) etcera and the macros #define capDriverConnect(hwnd, index) SendMessage((hwnd), WM_CAP_DRIVER_CONNECT, (index, 0)) etcetera etcetera furthermore all the v4l stuff has to go into a seperate driver file i think, as wine is also supposed to run on non-Linux distributions. this line in avicap_main : window = CreateWindowExW etc. and the registering of the window contains a lot of crap; i just copied it from a site somewhere on the internet. It was just to get a handle to the window Somehow the dwstyle has to get passed on, and few other things. Futhermore: no need to link to -lpng -ljpeg and -lnetpbm; they're not needed anymore in the code i've sent you. Better think, get more info and be more carefull before you send in a patch i think. Anyway, i smashed together some code with which i can grab an image from my cam, and save it as a DIB (capFileSaveDIB). also i wrote something for cappreview, which looks as if it would be easy to get it running. if someone's interested i could send you the code. Now my question is: maybe one of the developers could just help/hint/write the Capcreatecapturewindow part (that seems to me a very little job), then anyone who wants could try to write a macro; just a thought of me, any thoughts from someone else? Regards Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Discussion on Bug tracking database
by Ann and Jason Edmeades 08 Mar '05

08 Mar '05

Hello, I thought I'd try to start a discussion to try to encourage changes in the bug tracking, but it would both require agreement and someone (else) who could physically make the changes. Is it me or is our bug tracking database not really working the way it should? Firstly I'd like to thank Tony - he seems to do a lot of maintaining of the bug database and deserves a lot of credit. Until I started looking through them and monitoring the bug mailing list, I didn't realize how much he did. Bug database problems.. 1. Some problems reports start off as useless. Its not a bug report, its more a call for assistance. 2. Some bug reports are severely out of date. A large number of them have as a last update a request to test on a more recent cvs (which is a fair thing to do if the bugs are left idle for eg. 1 year! 3. We have a large number who due to our inactivity mean the person who raised it no longer cares, so any questions are a waste of time and come back unanswered 4. We have some where the email address of the raise has changed so even if they care they may not notice any changes to the bug report 5. Its hard to tell the bugs you can reproduce with downloadable freeware from those that require expensive software Suggestions.... 1. I would like to get implemented an AUTOMATIC timeout on the bug reports. If they are inactive for eg. 4 months then an automatic update is added to them asking to try latest cvs and confirm the problem still exists. If the problem is not updated within a month, the bug report gets automatically closed with a specific code (eg. CLOSED/inactivity). 2. I would like a clear way to identify if the problem can be reproduced with **free** downloadable software, eg a demo, freeware, shareware etc. This should be searchable for people wanting a quick bug fix 3. I would like there to be a transition from an initial state before being accepted, which basically allows rejection of a bug report if there is not enough information in it. Unfortunately someone would have to actively do this, so this would be a very had one to achieve. 4. I would also like a bug fixing period of time, when all wine developers are encouraged to work on bugs for eg. one day a month. Interestingly, even though most people seem to end up working in a particular area they may not handle bugs in that area (probably because they don't check for them!). How many of the wine developers would consider allocating time once a month (even if its just an hour!) to look at a bug report, perhaps try it or go back asking for appropriate traces etc. I know some of this can be achieved by 'proper' use of the bug states, keywords etc, but we don't...! Anyway, I thought I would start a discussion, so you know my thoughts - what are other peoples. Jason

5 6

Why not build wine server as a linux kernel module?
by 苏杭 08 Mar '05

08 Mar '05

Hi, May I ask you a question? Why not build wine server as a linux kernel module? I think the performance of a kernel module is better than a separate process. If anyone can give me a reasonable answer, I would really appreciate it. Hang Su

1 0

Re: advapi32 registry.c test failures on windows
by James Hawkins 07 Mar '05

07 Mar '05

On Mon, 7 Mar 2005 00:28:13 -0800 (PST), Aaron Arvey <aarvey(a)cs.hmc.edu> wrote: > There were 28 failures when I ran the advapi32 tests on windows. All these > were in registry.c. Please see > http://www.winehq.org/hypermail/wine-devel/2005/02/0045.html and the > following responses to find out where/when/why/how these bugs were > introduced. > > After patch is applied, the registry.c runs without errors on Windows XP > and 98. When ran in wine, there are now 28 todos. > > Aaron > > Changelog: > * dlls/advapi32/tests/registry.c > altered tests so that they run under windows > > Signed-off-by: Aaron Arvey <aarvey_at_cs.hmc.edu> > > Index: dlls/advapi32/tests/registry.c > =================================================================== > RCS file: /home/wine/wine/dlls/advapi32/tests/registry.c,v > retrieving revision 1.11 > diff -u -3 -p -u -r1.11 registry.c > --- dlls/advapi32/tests/registry.c 27 Jan 2005 11:15:00 -0000 1.11 > +++ dlls/advapi32/tests/registry.c 17 Feb 2005 04:00:13 -0000 > @@ -80,6 +80,7 @@ static void test_enum_value(void) > DWORD val_count, data_count, type; > static const WCHAR foobarW[] = {'f','o','o','b','a','r',0}; > static const WCHAR testW[] = {'T','e','s','t',0}; > + static const WCHAR test1W[] = {'T','e','s','t','1',0}; > static const WCHAR xxxW[] = {'x','x','x','x','x','x','x','x',0}; > > /* check NULL data with zero length */ > @@ -105,8 +106,12 @@ static void test_enum_value(void) > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 2, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !strcmp( value, "xxxxxxxxxx" ), "value set to '%s'\n", value ); > ok( !strcmp( data, "xxxxxxxxxx" ), "data set to '%s'\n", data ); > > @@ -120,8 +125,12 @@ static void test_enum_value(void) > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > /* Win9x returns 2 as specified by MSDN but NT returns 3... */ > ok( val_count == 2 || val_count == 3, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > #if 0 > /* v5.1.2600.0 (XP Home) does not touch value or data in this case */ > ok( !strcmp( value, "Te" ), "value set to '%s' instead of 'Te'\n", value ); > @@ -137,8 +146,12 @@ static void test_enum_value(void) > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 0, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !strcmp( value, "xxxxxxxxxx" ), "value set to '%s'\n", value ); > #if 0 > /* v5.1.2600.0 (XP Home) does not touch data in this case */ > @@ -154,8 +167,12 @@ static void test_enum_value(void) > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 20, "val_count set to %ld\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !strcmp( value, "xxxxxxxxxx" ), "value set to '%s'\n", value ); > ok( !strcmp( data, "xxxxxxxxxx" ), "data set to '%s'\n", data ); > > @@ -166,12 +183,25 @@ static void test_enum_value(void) > strcpy( value, "xxxxxxxxxx" ); > strcpy( data, "xxxxxxxxxx" ); > res = RegEnumValueA( hkey_main, 0, value, &val_count, NULL, &type, data, &data_count ); > - ok( res == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", res ); > - ok( val_count == 4, "val_count set to %ld instead of 4\n", val_count ); > - ok( data_count == 7, "data_count set to %ld instead of 7\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > - ok( !strcmp( value, "Test" ), "value is '%s' instead of Test\n", value ); > - ok( !strcmp( data, "foobar" ), "data is '%s' instead of foobar\n", data ); > + todo_wine{ > + ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > + } > + todo_wine{ > + ok( val_count == 20, "val_count set to %ld instead of 20\n", val_count ); > + } > + todo_wine{ > + ok( data_count == 24, "data_count set to %ld instead of 24\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > + todo_wine{ > + ok( !strcmp( value, "xxxxxxxxxx" ), "value is '%s' instead of xxxxxxxxxx\n", value ); > + } > + todo_wine{ > + ok( !strcmp( data, "xxxxxxxxxx" ), "data is '%s' instead of xxxxxxxxxx\n", data ); > + } > + > > /* Unicode tests */ > > @@ -190,8 +220,12 @@ static void test_enum_value(void) > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 2, "val_count set to %ld\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !memcmp( valueW, xxxW, sizeof(xxxW) ), "value modified\n" ); > ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > > @@ -204,8 +238,12 @@ static void test_enum_value(void) > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > ok( val_count == 3, "val_count set to %ld\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > ok( !memcmp( valueW, xxxW, sizeof(xxxW) ), "value modified\n" ); > ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > > @@ -217,10 +255,18 @@ static void test_enum_value(void) > memcpy( dataW, xxxW, sizeof(xxxW) ); > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > - ok( val_count == 4, "val_count set to %ld instead of 4\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > - ok( !memcmp( valueW, testW, sizeof(testW) ), "value is not 'Test'\n" ); > + todo_wine{ > + ok( val_count == 5, "val_count set to %ld instead of 5\n", val_count ); > + } > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > + todo_wine{ > + ok( !memcmp( valueW, test1W, sizeof(test1W) ), "value is not 'Test1'\n" ); > + } > ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > > /* no overflow */ > @@ -230,12 +276,25 @@ static void test_enum_value(void) > memcpy( valueW, xxxW, sizeof(xxxW) ); > memcpy( dataW, xxxW, sizeof(xxxW) ); > res = RegEnumValueW( hkey_main, 0, valueW, &val_count, NULL, &type, (BYTE*)dataW, &data_count ); > - ok( res == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", res ); > - ok( val_count == 4, "val_count set to %ld instead of 4\n", val_count ); > - ok( data_count == 7*sizeof(WCHAR), "data_count set to %ld instead of 7*sizeof(WCHAR)\n", data_count ); > - ok( type == REG_SZ, "type %ld is not REG_SZ\n", type ); > - ok( !memcmp( valueW, testW, sizeof(testW) ), "value is not 'Test'\n" ); > - ok( !memcmp( dataW, foobarW, sizeof(foobarW) ), "data is not 'foobar'\n" ); > + todo_wine{ > + ok( res == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %ld\n", res ); > + } > + todo_wine{ > + ok( val_count == 5, "val_count set to %ld instead of 5\n", val_count ); > + } > + todo_wine{ > + ok( data_count == 24*sizeof(WCHAR), "data_count set to %ld instead of 24*sizeof(WCHAR)\n", data_count ); > + } > + todo_wine{ > + ok( type == REG_EXPAND_SZ, "type %ld is not REG_EXPAND_SZ\n", type ); > + } > + todo_wine{ > + ok( !memcmp( valueW, test1W, sizeof(test1W) ), "value is not 'Test1'\n" ); > + } > + todo_wine{ > + ok( !memcmp( dataW, xxxW, sizeof(xxxW) ), "data modified\n" ); > + } > + > > CLEANUP: > /* cleanup */ > @@ -252,6 +311,12 @@ static void test_query_value_ex() > ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %ld\n", ret); > ok(size == strlen(sTestpath1) + 1, "(%ld,%ld)\n", (DWORD)strlen(sTestpath1) + 1, size); > ok(type == REG_SZ, "type %ld is not REG_SZ\n", type); > + > + > + > + ret = RegQueryValueExA(hkey_main, "TestStringNotIn", NULL, &type, NULL, &size); > + ok(ret == ERROR_FILE_NOT_FOUND, "expected ERROR_FILE_NOT_FOUND, got %ld\n", ret); > + > } > > START_TEST(registry) It would help wine if you could make these tests pass on wine. Also, have a look at the test results at test.winehq.org/data. I see that 26 of the tests fail on 95, 24 fail on 98, and 28 for >= nt4. If you have any questions fixing the reg tests, I'd be glad to help. Make sure to cc wine-devel. -- James Hawkins

1 0

Re: Resend : Implements MIIM_BITMAP state in menus
by Alexandre Julliard 07 Mar '05

07 Mar '05

Maxime Bellengé <maxime.bellenge(a)wanadoo.fr> writes: > + * drawhbmbitmap : True to draw the hbmbitmap(MIIM_BITMAP)/False to draw the MF_BITMAP > */ > -static void MENU_DrawBitmapItem( HDC hdc, MENUITEM *lpitem, const RECT *rect, BOOL menuBar ) > +static void MENU_DrawBitmapItem( HDC hdc, MENUITEM *lpitem, const RECT *rect, BOOL menuBar, BOOL drawhbmbitmap ) What's the point of passing the drawhbmbitmap flag since you always set it to TRUE? > @@ -762,14 +773,15 @@ > int h = rect->bottom - rect->top; > int bmp_xoffset = 0; > int left, top; > + HBITMAP swtch = (drawhbmbitmap)?lpitem->hbmpItem:(HBITMAP)lpitem->text; That's a strange variable name for a bitmap... > + /* New style MIIM_BITMAP */ > + if (lpitem->hbmpItem) > + { > + if (lpitem->hbmpItem == HBMMENU_CALLBACK) > + { > + MEASUREITEMSTRUCT measItem; > + measItem.CtlType = ODT_MENU; > + measItem.CtlID = 0; > + measItem.itemID = lpitem->wID; > + measItem.itemWidth = lpitem->rect.right - lpitem->rect.left; > + measItem.itemHeight = lpitem->rect.bottom - lpitem->rect.top; > + measItem.itemData = lpitem->dwItemData; > + > + SendMessageW( hwndOwner, WM_MEASUREITEM, lpitem->wID, (LPARAM)&measItem); > + > + /* Keep the size of the bitmap in callback mode to be able to draw it correctly */ > + lppop->bmpSize.cx = max(lppop->bmpSize.cx, measItem.itemWidth - (lpitem->rect.right - lpitem->rect.left)); > + lppop->bmpSize.cy = max(lppop->bmpSize.cy, measItem.itemHeight - (lpitem->rect.bottom - lpitem->rect.top)); Why do you store the bitmap size in the parent popup? What if there are multiple items with bitmaps? -- Alexandre Julliard julliard(a)winehq.org

2 2

Trace from Page Plus 5
by Andrew Neil Ramage 07 Mar '05

07 Mar '05

I tried to start Page Plus 5, a DTP program from Serif. I was presented with a dialog asking for me to select a printer. When I OK'ed that, with the splash screen still showing, wine crashed. Here is the trace. [andrew@zeus Program]$ wine pp.exe fixme:commdlg:PRINTDLG_OpenDefaultPrinter Could not open printer EPSONStylusC42?! fixme:commdlg:PRINTDLG_OpenDefaultPrinter Could not open printer EPSONStylusC42?! wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00447977). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:00447977 ESP:406aeadc EBP:406aeb00 EFLAGS:00210206( - 00 - RIP1) EAX:00000000 EBX:4056c508 ECX:00000002 EDX:406ae940 ESI:40361bfe EDI:00631c67 Stack dump: 0x406aeadc: 00000000 406aec5c 00001012 00000000 0x406aeaec: 00000000 406aec58 00631c67 40361bfe 0x406aeafc: 4056c508 406aecd4 0044988c 00000000 0x406aeb0c: 406aec5c 00000003 406aec58 00631c67 0x406aeb1c: 40361bfe 4056c508 406aeb40 406aeb84 0x406aeb2c: 00000040 406aec34 40045bd3 4020b864 Backtrace: =>1 0x00447977 in pp (+0x47977) (0x406aeb00) 2 0x0044988c in pp (+0x4988c) (0x406aecd4) 3 0x004c804b in pp (+0xc804b) (0x406af370) 4 0x0048a5c6 in pp (+0x8a5c6) (0x406af390) 5 0x0048a2f5 in pp (+0x8a2f5) (0x406af7c4) 6 0x0043acff in pp (+0x3acff) (0x406afe54) 7 0x0043b32f in pp (+0x3b32f) (0x406afe98) 8 0x00631d89 EntryPoint+0x122 in pp (0x406aff2c) 9 0x404d7db8 start_process+0xc8(arg=0x0) [/home/andrew/Download/Software/wine-20050211/dlls/kernel/process.c:1046] in kernel32 (0x406afff4) 10 0x40027dcd wine_pthread_abort_thread+0x2d(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x00447977: movl 0x0(%eax),%eax Wine-dbg> -- Andrew [hackcoughsniffle] Internal Virus Database corrupt

1 0

Re: fix wrc to parse some Borland dialog resources
by Filip Navara 07 Mar '05

07 Mar '05

Michael Lin wrote: > * change wrc to parse '&' and '~' when specifying style I believe the attached patch would be better solution...you can use arbitrary expressions in the style definitions with Microsoft Resource Compiler... Regards, Filip

2 1

Wine logo (the glass)
by Dimitrie O. Paun 07 Mar '05

07 Mar '05

Folks, do we have an .svg version of the logo? If so, where can I get it from? -- Dimi.

2 1

winebuild changes
by Dimitrie O. Paun 07 Mar '05

07 Mar '05

Hi Alexandre, Ivan found that on Windows .exe's can export functions, just like DLLs. He needs this for his work on ntoskrnl.exe. To support this, we need a bit of an interface change to winebuild. I've put together a simple patch to see if you are OK with such a change. If so, I'll finish it, and modify winegcc accordingly. So, thing will change as follows: OLD: winebuild --dll=mystuff.spec NEW: winebuild --dll -E mystuff.spec OLD: winebuild --def=mystuff.spec NEW: winebuild --def -E mystuff.spec OLD: winebuild --exe=myprog.exe NEW: winebuild --exe -F myprog.exe to build an .exe with arbitrary exports, we would do: winebuild --exe -F myprog.exe -E mystuff.spec Index: tools/winebuild/main.c =================================================================== RCS file: /var/cvs/wine/tools/winebuild/main.c,v retrieving revision 1.59 diff -u -r1.59 main.c --- tools/winebuild/main.c 7 Dec 2004 17:19:54 -0000 1.59 +++ tools/winebuild/main.c 7 Mar 2005 01:50:44 -0000 @@ -144,6 +144,7 @@ " -C --source-dir=DIR Look for source files in DIR\n" " -d --delay-lib=LIB Import the specified library in delayed mode\n" " -D SYM Ignored for C flags compatibility\n" +" -E --export=FILE Export the symbols defined in the .spec or .def file\n" " -e --entry=FUNC Set the DLL entry point function (default: DllMain)\n" " -f FLAGS Compiler flags (only -fPIC is supported)\n" " -F --filename=DLLFILE Set the DLL filename (default: from input file name)\n" @@ -165,9 +166,9 @@ " --version Print the version and exit\n" " -w --warnings Turn on warnings\n" "\nMode options:\n" -" --dll=FILE Build a .c file from a .spec or .def file\n" -" --def=FILE.SPEC Build a .def file from a spec file\n" -" --exe=NAME Build a .c file for the named executable\n" +" --dll Build a .c file from a .spec or .def file\n" +" --def Build a .def file from a spec file\n" +" --exe Build a .c file for the named executable\n" " --debug [FILES] Build a .c file with the debug channels declarations\n" " --relay16 Build the 16-bit relay assembly routines\n" " --relay32 Build the 32-bit relay assembly routines\n\n" @@ -204,6 +205,7 @@ /* aliases for short options */ { "source-dir", 1, 0, 'C' }, { "delay-lib", 1, 0, 'd' }, + { "export", 1, 0, 'E' }, { "entry", 1, 0, 'e' }, { "filename", 1, 0, 'F' }, { "help", 0, 0, 'h' }, @@ -248,6 +250,10 @@ case 'D': /* ignored */ break; + case 'E': + spec_file_name = xstrdup( optarg ); + set_dll_file_name( optarg, spec ); + break; case 'F': spec->file_name = xstrdup( optarg ); break; @@ -324,21 +330,12 @@ break; case LONG_OPT_DLL: set_exec_mode( MODE_DLL ); - spec_file_name = xstrdup( optarg ); - set_dll_file_name( optarg, spec ); break; case LONG_OPT_DEF: set_exec_mode( MODE_DEF ); - spec_file_name = xstrdup( optarg ); - set_dll_file_name( optarg, spec ); break; case LONG_OPT_EXE: set_exec_mode( MODE_EXE ); - if ((p = strrchr( optarg, '/' ))) p++; - else p = optarg; - spec->file_name = xmalloc( strlen(p) + 5 ); - strcpy( spec->file_name, p ); - if (!strchr( spec->file_name, '.' )) strcat( spec->file_name, ".exe" ); if (!spec->subsystem) spec->subsystem = IMAGE_SUBSYSTEM_WINDOWS_GUI; break; case LONG_OPT_DEBUG: -- Dimi.

2 1

Where are Wine's webserver logs?
by Scott Ritchie 07 Mar '05

07 Mar '05

I'd like to do some datamining around the Wine server logs to see where people are linked to from offsite the most, where they deadend, and such. But, I don't have any logs to mine. Can someone make the past few months logs available? Thanks, Scott Ritchie

2 1

Re: Re: [x11drv] Fix X11DRV_set_wm_hints
by Maxime BELLENGE 07 Mar '05

07 Mar '05

> Message du 07/03/05 06:01 > De : "Dmitry Timoshkov" <dmitry(a)baikal.ru> > A : "Maxime Bellengé" <maxime.bellenge(a)wanadoo.fr> > Copie à : wine-devel(a)winehq.com > Objet : Re: [x11drv] Fix X11DRV_set_wm_hints > > "Maxime Bellengé" <maxime.bellenge(a)wanadoo.fr> wrote: > > > I don't agree with you because, if the application don't call this with > > the HTCAPTION parameter > > > > PostMessage( WM_NCLBUTTONDOWN, HTCAPTION, MAKELPARAM( point.x, > > point.y)); > > > > but with HTLEFT, HTRIGHT ... the WM must resize the window I think. > > > > I wondered first if MWM_FUNC_RESIZE should be added but I think it is > > correct. > > If WS_THICKFRAME style is not set, then a window is not supposed to be > resized by WM, that's the point. SetWindowPos still will be able to resize > a window. > > -- > Dmitry. > Ok, I've re-read the docs and you're right. Sorry to have insisted wrongly and thanks for making me notice the problem. I will resend a correct patch. Maxime

1 0

FlashFXP v 3.01 and wine + Odin
by Dietrich Teickner 07 Mar '05

07 Mar '05

Currently I have tested FlashFXP v3.01 (ftp-client with ssl) with wine, after I found it chrashs in Odin with stack-overflow. And I found FlashFXP stops after the same actiom in wine. I think that is the same message-loop, that I found in odin. with SysListView 68000034 LVM_SETITEMSTATE in comctl32 and WM_NOTIFY in user32 t01 ( 4): (code=-150) t01 ( 4): USER32: GetWindowLongW 68000034 fffffff4 t01 ( 4): USER32: GetWindowLongW returned 68000034 t01 ( 4): USER32: SendMessageW 68000033 4e 68000034 12f25c t01 ( 5): SendMessageW WM_NOTIFY for 68000033 68000034 12f25c t01 ( 5): USER32: GetWindowThreadProcessId 68000034 12ee9c t01 ( 5): USER32: GetWindowThreadProcessId returned 27470001 t01 ( 5): KERNEL32: GetCurrentProcessId t01 ( 5): KERNEL32: GetCurrentProcessId returned 2747 t01 ( 5): USER32: GetPropA 68000034 f22b t01 ( 5): USER32: GetPropA returned 20035a04 t01 ( 5): USER32: SendMessageA 68000034 102b 0 12eb68 t01 ( 6): SendMessageA User Message 102B (WM_USER+3115) for 68000034 0 12eb68 t01 ( 7): USER32: GetWindowLongW 68000034 0 t01 ( 7): USER32: GetWindowLongW returned 2d45570 t01 ( 7): SysListView 68000034 LVM_SETITEMSTATE 0 12eb68 t01 ( 7): wvsnprintfA : 168D8038 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D804E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=2, t01 ( 7): lvItem={iItem=0, iSubItem=0, state=0, stateMask=2} t01 ( 7): wvsnprintfA : 168D8138 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D814E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=2, t01 ( 7): (lpLVItem={iItem=0, iSubItem=0, state=0, stateMask=2}, isW=1) t01 ( 7): () t01 ( 7): wvsnprintfA : 168D8238 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D824E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=ffffffff, t01 ( 7): wvsnprintfA : 168D826B 205 "lParam=%lx, " t01 ( 7): lParam=0, t01 ( 7): (lpLVItem={iItem=0, iSubItem=0, state=0, stateMask=ffffffff, lParam=0}, isW=1) t01 ( 7): wvsnprintfA : 168D8338 256 "{iItem=%d, iSubItem=%d, " t01 ( 7): {iItem=0, iSubItem=0, t01 ( 7): wvsnprintfA : 168D834E 234 "state=%x, stateMask=%x, " t01 ( 7): state=0, stateMask=f00, t01 ( 7): pdi->item={iItem=0, iSubItem=0, state=0, stateMask=f00} t01 ( 7): (code=-150) the child ask the parent, this ask the child, this ask the parrennt, this..... never end, only if the stack at end. Dietrich

2 1

Re: [x11drv] Fix X11DRV_set_wm_hints
by Dmitry Timoshkov 07 Mar '05

07 Mar '05

"Maxime Bellengé" <maxime.bellenge(a)wanadoo.fr> wrote: > This patch adds MWM_FUNC_MOVE | MWM_FUNC_RESIZE when WS_EX_APPWINDOW. > Now the windows are movable. I think that MWM_FUNC_RESIZE should be added only for windows with WS_THICKFRAME style set. -- Dmitry.

2 2

AUTO3STATE with BS_OWNERDRAW bug?
by Michael Lin 06 Mar '05

06 Mar '05

Hi all, I am having problem with AUTO3STATE control that have BS_OWNERDRAW style set. Dialogs with this control will not show at all. For example, I have a control AUTO3STATE "Text", 103, 10, 9, 149, 47, BS_OWNERDRAW | WS_CHILD | WS_VISIBLE | WS_TABSTOP in my dialog resource and the dialog won't show when it is called. But when I change it to CONTROL "Text", 103, "BUTTON", BS_OWNERDRAW | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 10, 9, 149, 47 the dialog works fine. This seems like a bug to me, does anyone else have seen this problem? Thanks, Michael

1 0

Config Problems ?
by Andrew Neil Ramage 06 Mar '05

06 Mar '05

I have downloaded and installed wine-20050211, but when I try to start a Windows program by clicking on it nothing happens. Starting it from the command line produces screens of output similar to the following: PatBlt (0x74, 0, 109, 472, 1, 15728673): stub fixme:ttydrv:TTYDRV_DC_PatBlt (0x74, 0, 110, 472, 2, 15728673): stub fixme:ttydrv:TTYDRV_DC_PatBlt (0x74, 0, 112, 472, 1, 15728673): stub fixme:ttydrv:TTYDRV_DC_PatBlt (0x74, 0, 113, 472, 1, 15728673): stub fixme:ttydrv:TTYDRV_DC_PatBlt (0x74, 0, 114, 472, 1, 15728673): stub fixme:ttydrv:TTYDRV_DC_PatBlt (0x74, 0, 115, 472, 2, 15728673): stub fixme:ttydrv:TTYDRV_DC_BitBlt (0x98c, 0, 0, 521, 130, 0x74, -24, 0, 13369376): stub fixme:ttydrv:TTYDRV_DC_StretchBlt (0x98c, 1, 0, 520, 86, 0x998, 0, 0, 520, 86, 8913094): stub fixme:ttydrv:TTYDRV_DC_StretchBlt (0x98c, 1, 0, 520, 86, 0x9a0, 0, 0, 520, 86, 15597702): stub fixme:ttydrv:TTYDRV_DC_BitBlt (0x74, -24, 0, 521, 130, 0x98c, 0, 0, 13369376): stub fixme:ttydrv:TTYDRV_DC_BitBlt (0x98c, 0, 0, 344, 40, 0x74, 64, 77, 13369376): stub fixme:ttydrv:TTYDRV_DC_BitBlt (0x74, 64, 77, 344, 40, 0 Anyone know what's wrong ? I am using Mandrake 10.0, Gnome 2.4 and wine-20050211. -- Andrew [hackcoughsniffle] Internal Virus Database corrupt

2 1

help wanted - testing "stuck Alt" patch
by Krzysztof Foltman 06 Mar '05

06 Mar '05

A few days ago I've sent this small patch to wine-patches: http://www.winehq.org/hypermail/wine-patches/2005/03/0091.html It's supposed to fix the long-existing (and annoying) problem where switching windows with Alt+TAB caused accelerator keys to work improperly (ie. pressing Ctrl+A was misrecognized as Ctrl+Alt+A). The patch seems to do its job (accelerator keys still work correctly after reactivating the app's window). However, I don't have many different configurations to test it. It would be nice if someone else applied it and tested if I haven't introduced a regression with this patch (it is possible, considering that it affects basic window management code used in all the GUI applications), and if it did the job. Any testing would be very helpful, regardless of whether the Alt+TAB problem existed on the particular machine or not. Although some people said that Alt+TAB problem doesn't exist in their configuration, I suspect that the problem is related to the particular usage patterns, and not configurations. Thanks in advance, Krzysztof

1 0

Running ZooTycoon 2 Demo
by Paul Vriens 06 Mar '05

06 Mar '05

Hi, I'm running current CVS with a fresh tools/wineinstall. Only changes to the config-file: "Drivers" = "winealsa.drv" "HardwareAcceleration" = "Emulation" ; Zoo Tycoon 2 Demo install [AppDefaults\\Zoo2Trial.exe\\Version] "Windows" = "winxp" ; Zoo Tycoon 2 Demo run [AppDefaults\\zt2demoretail.exe\\x11drv] "Desktop" = "800x600" installation of the app is fine (set version to winxp). When trying to run the demo it immediately fails: fixme:d3d9:IDirect3DDevice9Impl_CreateSurface (0x77e38ea8) call to IWineD3DDevice_CreateRenderTarget failed First chance exception: page fault on read access to 0x00000000 in 32-bit code (0x14a9481a). Fixed/circumvented that by: Index: dlls/wined3d/directx.c =================================================================== RCS file: /home/wine/wine/dlls/wined3d/directx.c,v retrieving revision 1.25 diff -u -p -r1.25 directx.c --- dlls/wined3d/directx.c 2 Mar 2005 13:44:58 -0000 1.25 +++ dlls/wined3d/directx.c 5 Mar 2005 16:11:45 -0000 @@ -1578,7 +1578,8 @@ HRESULT WINAPI IWineD3DImpl_CreateDevi object->render_ctx = object->glCtx; object->renderTarget = object->backBuffer; - IWineD3DSurface_AddRef((IWineD3DSurface *) object->renderTarget); + if (NULL != object->renderTarget) + IWineD3DSurface_AddRef((IWineD3DSurface *) object->renderTarget); /* TODO: Depth Stencil support object->stencilBufferTarget = object->depthStencilBuffer; if (NULL != object->stencilBufferTarget) { It comes a bit further now but fails again: trace:d3d:IWineD3DDeviceImpl_SetViewport glDepthRange call ok device.c / 1811 trace:d3d:IWineD3DDeviceImpl_SetViewport This->renderTarget : ((nil)) First chance exception: page fault on read access to 0x0000003c in 32-bit code (0x4658033a). The extra trace was added by me. Again this points to *->renderTarget being NULL. So there must be more to it. Any ideas? Oliver? Cheers, Paul.

2 3

Re: Picasa2- slideshow mode fixes [patch #1]
by Matthew Mastracci 06 Mar '05

06 Mar '05

Woohoo! With my patch from before and some extra hacking, I managed to get the slideshow working in Picasa by faking out some DirectDraw capabilities. Apparently, it requires the presence of the DDCAPS_OVERLAY and DDCAPS_OVERLAYSTRETCH to do its slideshow properly (and aborts silently if they aren't there). Adding the fake capabilities lets the slideshow run, though the images aren't stretched to the entire size of the window unless the slideshow overlay is showing at the bottom. It's hard to describe and a little jarring when you're interacting with the slideshow. Not sure if this is because of the lack of true overlay surface support, but this message seems to indicate so: trace:ddraw:Main_DirectDraw_CreateSurface App didn't request a valid surface type - assuming offscreenplain I don't know if I should submit this as part of a patch, since it doesn't implement the functionality. Here is the change, for those interested: Index: dlls/ddraw/ddraw/user.c =================================================================== RCS file: /home/wine/wine/dlls/ddraw/ddraw/user.c,v retrieving revision 1.22 diff -u -r1.22 user.c --- dlls/ddraw/ddraw/user.c 8 Sep 2004 01:50:37 -0000 1.22 +++ dlls/ddraw/ddraw/user.c 6 Mar 2005 07:04:29 -0000 @@ -143,7 +143,7 @@ #define BLIT_CAPS (DDCAPS_BLT | DDCAPS_BLTCOLORFILL | DDCAPS_BLTDEPTHFILL \ | DDCAPS_BLTSTRETCH | DDCAPS_CANBLTSYSMEM | DDCAPS_CANCLIP \ | DDCAPS_CANCLIPSTRETCHED | DDCAPS_COLORKEY \ - | DDCAPS_COLORKEYHWASSIST) + | DDCAPS_COLORKEYHWASSIST | DDCAPS_OVERLAY | DDCAPS_OVERLAYSTRETCH) #define CKEY_CAPS (DDCKEYCAPS_DESTBLT | DDCKEYCAPS_SRCBLT) #define FX_CAPS (DDFXCAPS_BLTALPHA | DDFXCAPS_BLTMIRRORLEFTRIGHT \ | DDFXCAPS_BLTMIRRORUPDOWN | DDFXCAPS_BLTROTATION90 \ Matthew Mastracci wrote: > I've been trying to get the slideshow mode in Picasa2 to work, but it > seems like it's relying on IDirectDrawSurface->Lock() to return > DDERR_SURFACEBUSY if the surface is already locked. If this call > doesn't return the error, it seems to keep hammering the function > until it does. It then proceeds to hit a stack overflow condition > somehow and dies. :) > > I think it's a bug in Picasa, but my ddraw-surface-lock.diff patch in > wine-patches fixes this behaviour (but not the feature, unfortunately). > > Note that now the slideshow mode now just terminates without error. > I'll keep on looking to see what's happening. > > Matt. >

2 2

Re: Re: [winedbg] Get expressions working again.
by Pouech Eric DMI AEI CAEN 06 Mar '05

06 Mar '05

> Ok, I'll take a look at this, but if where shouldn't > be using two pointer types we should be using > SymGetTypeInfo in all cases? the only (two things) you have to do are: - if one cannot find the pointer type in the pointee's module, then create a winedbg's type for the pointer type and store this type in a lookup table - in type_get_info, extend the types supported by also searching the lookup table for the pointers type. the lookup table should contain pointee type and module of pointee. You could also extend step 1 by not adding a pointer that already exists. A+

3 2

IP Address control broken
by Robert Reif 06 Mar '05

06 Mar '05

I am unable to edit the text in an IP Address control. I can select it and delete it with the mouse but typing into it causes the test to go to the window it was started in. Disabling the control does not change it's color. Is anyone working on this control?

3 7

Re: [winecfg] Audio device selection
by Robert Reif 06 Mar '05

06 Mar '05

Paul van Schayck wrote: >Changelog: >Let the audio device be changed from the audio tab > > OSS also supports multiple devices. When you have multiple audio devices in Windows, it provides the friendly names of all the devices and allows you to select one as the default. You can do this now in OSS.

1 0

re: [OLE #78] Run RPCs on a new thread client side
by Dan Kegel 06 Mar '05

06 Mar '05

Mike Hearn wrote: > Almost there .... Stay on target... [thinking of Skywalker's last bombing run] -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Regression in painting.c
by Ron Jensen 06 Mar '05

06 Mar '05

dlls/user/painting.c is getting caught in an infinite loop in the function update_now() I added two TRACE statements to try to figure out what is going on. Uncommenting the SendMessageW() line allows the loop to exit. See the attached win traces for the working and broken cases. I don't know enough about what this function is trying to do to fix it... The bug can be reproduced using Irfan View's ( www.irfanview.com ) slideshow functions. --- painting.c.orig 2005-02-28 12:01:55.000000000 -0700 +++ painting.c 2005-03-04 08:18:52.000000000 -0700 @@ -340,6 +340,7 @@ else if (rdw_flags & RDW_ALLCHILDREN) flags |= UPDATE_ALLCHILDREN; if (!get_update_flags( hwnd, &child, &flags )) break; +TRACE( "flags = %d, child = %d, prev = %d\n", flags, child , prev ); if (!flags) break; /* nothing more to do */ if (child == prev) /* same window again, didn't get repainted properly */ @@ -351,8 +352,10 @@ TRACE( "%p not repainted properly, erasing\n", child ); if ((hrgn = send_ncpaint( child, NULL, &erase_flags ))) { + TRACE( "hrgn = %p, deleting\n", hrgn ); send_erase( child, erase_flags, hrgn, &rect, NULL ); DeleteObject( hrgn ); +// SendMessageW( child, WM_PAINT, 0, 0 ); } } else

2 1

Re: Better test for visible desktop, should be working on all platforms.
by Dmitry Timoshkov 06 Mar '05

06 Mar '05

"Jakob Eriksson" <jakov(a)vmlinux.org> wrote: > I took this test from the gdi32 conformance tests, since it fails > reliably when run under a non visible desktop, regardless of platform. > > > It's not pretty, but I don't have an NT4 to test with, so I didn't want > to change > anything. Later I can refactor it into exactly the failing part. Did you consider implementing the approach Robert Shearman has pointed out? -- Dmitry.

3 3

winecfg
by Chris Morgan 06 Mar '05

06 Mar '05

I noticed that winecfg is still reporting that it "does not modify your configuration", and in winecfg.h WINE_KEY_ROOT isn't set to the configuration key. Is there some reason why we haven't enabled writing to the actual configuration yet? Are there some bugs or lack of features that need to be resolved before it goes active? Without a ~/.wine/config file it seems like winecfg is the only way to let users easily adjust their configuration. Chris

2 1

Regression in GetModuleHandle16
by Vitaliy Margolen 06 Mar '05

06 Mar '05

This patch http://cvs.winehq.org/patch.py?id=16245 broke my wine (changes to "winbase.h"). It fails to start. Could someone take a look at it? I'm sorry, my brain failing me this weekend too, and I couldn't find the cause myself. I tried running without ~/.wine - didn't help. I'm running wine from the tree without installing it. Could this be a reason why no one else seeing the problem? 0009:trace:module:load_dll Found loaded module L"c:\\windows\\system\\kernel32.dll" for L"kernel32.dll" at 0x404c0000, count=13 0009:trace:heap:RtlFreeHeap (0x40380000,00000002,40380f78): returning TRUE 0009:trace:module:GetModuleHandle16 (krnl386.exe) 0009:trace:module:MODULE_LoadModule16 Trying built-in 'krnl386.exe' 0009:trace:global:GLOBAL_Alloc 56 flags=0000 0009:trace:heap:RtlAllocateHeap (0x40380000,00000002,00000040): returning 40380f78 0009:trace:module:NE_InitResourceHandler InitResourceHandler[1026] 0009:trace:module:GetModuleHandle16 (KERNEL) 0009:trace:module:GetProcAddress16 0000 'DefResourceHandler' 0009:trace:loaddll:MODULE_LoadModule16 Loaded module "krnl386.exe" : builtin 0009:trace:module:GetModuleHandle16 (krnl386.exe) 0009:err:module:MODULE_LoadModule16 Serious trouble. Just loaded module 'krnl386.exe' (hinst=0x1026), but can't get module handle. Filename too long ? -- Best regards, Vitaliy

1 0

dbghelp problem
by Robert Reif 06 Mar '05

06 Mar '05

I can't get a stack trace with symbol information from an exe file and tracked the problem down to this. dbghelp tries to load the symbols for the executable file by looking up the file name without the .exe extension and fails because the file is not found. This patch adds the .exe back on to the file name and tries to look it up again before failing. I doubt this is the right solution but it works for me. --- pe_module.c 2005-03-01 06:20:19.000000000 -0500 +++ /mnt/floppy/pe_module.c 2005-03-04 11:06:30.000000000 -0500 @@ -332,6 +332,7 @@ HANDLE hMap; void* mapping; char loaded_name[MAX_PATH]; + TRACE("(%p %s %p %08lx %08lx)\n", pcs, name, hFile, base, size); loaded_name[0] = '\0'; if (!hFile) @@ -341,13 +342,22 @@ /* FIXME SetLastError */ return NULL; } - if ((hFile = FindExecutableImage(name, NULL, loaded_name)) == NULL) - return NULL; + if ((hFile = FindExecutableImage(name, NULL, loaded_name)) == NULL) { + char full_name[MAX_PATH]; + TRACE("file: %s not found\n", name); + strcpy(full_name, name); + strcat(full_name, ".exe"); + if ((hFile = FindExecutableImage(full_name, NULL, loaded_name)) == NULL) { + TRACE("file: %s not found\n", full_name); + return NULL; + } + } opened = TRUE; } else if (name) strcpy(loaded_name, name); else if (dbghelp_options & SYMOPT_DEFERRED_LOADS) FIXME("Trouble ahead (no module name passed in deferred mode)\n"); + TRACE("loaded_name = %s\n", loaded_name); if (!(module = module_find_by_name(pcs, loaded_name, DMT_PE)) && (hMap = CreateFileMappingA(hFile, NULL, PAGE_READONLY, 0, 0, NULL)) != NULL) {

2 1

Picasa2- slideshow mode fixes [patch #1]
by Matthew Mastracci 06 Mar '05

06 Mar '05

I've been trying to get the slideshow mode in Picasa2 to work, but it seems like it's relying on IDirectDrawSurface->Lock() to return DDERR_SURFACEBUSY if the surface is already locked. If this call doesn't return the error, it seems to keep hammering the function until it does. It then proceeds to hit a stack overflow condition somehow and dies. :) I think it's a bug in Picasa, but my ddraw-surface-lock.diff patch in wine-patches fixes this behaviour (but not the feature, unfortunately). Note that now the slideshow mode now just terminates without error. I'll keep on looking to see what's happening. Matt.

1 0

Re: More destinations for wineoss's mixer
by wino＠piments.com 06 Mar '05

06 Mar '05

On 05 Mar 2005 12:34:26 -0500, Vincent Béron <vberon(a)mecano.gme.usherb.ca> wrote: > According to MSDN, DST_HEADPHONES can be the same as DST_SPEAKERS, > DST_LINE and DST_VOICEIN as DST_WAVEIN. > > Peter, does this one helps Dragon NS 7? > > Changelog: > Make wineoss's mixer know about DST_HEADPHONES, DST_LINE and > DST_VOICEIN. > Use proper constants instead of 0 and 1. > > Vincent one more thing to add: it seems your patch has done some good since I now notice that entering the audio setup now sets the mike to zero just before it gets stuck. I went back to try NS4 and I did now manage to go through the mike setup routine and sig/noise check. Although the mike setting was not waiting for me to speak before returning. Another brick is in place. 8) -- Opera 7 mail on Linux

1 0

Re: More destinations for wineoss's mixer
by peter＠piments.com 06 Mar '05

06 Mar '05

On 05 Mar 2005 12:34:26 -0500, Vincent Béron <vberon(a)mecano.gme.usherb.ca> wrote: > According to MSDN, DST_HEADPHONES can be the same as DST_SPEAKERS, > DST_LINE and DST_VOICEIN as DST_WAVEIN. > > Peter, does this one helps Dragon NS 7? > > Changelog: > Make wineoss's mixer know about DST_HEADPHONES, DST_LINE and > DST_VOICEIN. > Use proper constants instead of 0 and 1. > > Vincent Thanks , that got rid of the errors but did not make it work, sadly. I can get it to install reliably using Installshield. What I thought was blocking it was that there is a OK/Cancel dlg coming up _behind_ the splash screen. This is obviously a bug in that the dlg is modal but not visible when it comes up. The trick is to move the splash to one side before clicking Next. The prog now starts and works as much as it can without sound and a speach profile , ie not much but it can close cleanly. Attempting to set the mike volume is still the killer but there are now no messages, the set up dlg hangs and I have to close it using the X button on the frame. I can then exit NS. Progress none the less Thanks again. -- Using Opera e-mail on Gentoo Linux

1 0

Re: MultiByteToWideCharacter problem with CP 950 (Traditional Chinese)
by Andreas Mohr 05 Mar '05

05 Mar '05

Hi, On Sun, Mar 06, 2005 at 04:49:13AM +0900, Mike McCormack wrote: > 1st problem: (pre-existing) No comments. > 2nd problem: (regression) > > There's another serious problem, which is a regression. Starting Office > 2000 (any language)with the Big5 code page as below, causes serious > trouble with my X server (X.org 6.7.0). The X cpu usage goes to 95%, > and the install hangs, more or less. > > LC_ALL=zh_TW.Big5 wine m:\setup > > The problem happens whether or not the Chinese truetype font is installed. This probably is the same issue that has prevented success for any attempt to use some relatively recent Wine versions on the notebook of my girlfriend (P3/450, Debian, Chinese simplified, non-Unicode setup: GB2312, XF86 4.3.x): whenever I started Wine, everything slowed to a crawl and I had veritable trouble trying to kill it (definitely points towards XF86 overload). I could offer to do some tests if need be. Haven't tried the new "non-official" Debian Wine packages, BTW. Andreas Mohr

1 0

Re: USER32: Error checking for sysparams tests
by Paul Vriens 05 Mar '05

05 Mar '05

On Sat, 2005-03-05 at 06:42, jchevrier(a)nexicom.net wrote: > As discussed on wine-devel there are a handful of calls in the > SystemParametersInfo tests that don't check for returned errors and continue > on with testing a given parameter. This patch ensures that all initial calls > to SystemParametersInfoA in each parameter test have their returned errors > checked. To ease adding more error cases and reduce code duplication I have > consolidated error message handling into a single function. > > Changelog: > > * Consolidate error message handling > * Add error checking to all initial SystemParametersInfoA calls in each > parameter test to make sure that if a given parameter isn't supported or has > failed in some other way that we return and don't continue on with the test > * Remove a couple of TABS and align registry keys/values at the top of the > file Hi Justin, what about the attached one? Added/changed the following: - Always set LastError before calling test_error_msg - SPI_{GET,SET}ICONTITLEWRAP is supported on Win98, but was clouded by an error that was set after a previous call failed. Changelog: Justin Chevrier <jchevrier(a)nexicom.net> * Consolidate error message handling * Add error checking to all initial SystemParametersInfoA calls in each parameter test to make sure that if a given parameter isn't supported or has failed in some other way that we return and don't continue on with the test * SetLastError before calling test_error_msg * Remove a couple of TABS and align registry keys/values at the top of the file * SPI_{GET,SET}ICONTITLEWRAP is supported on Win98 Cheers, Paul.

2 1

Any resources about threading problems?
by Bill Medland 05 Mar '05

05 Mar '05

Does anyone know any site or book or something with a decent discussion about the problems of the different threading models and their implementations? In the Developer's Guide in section 8.3 there are references to "the threading chapter". Is this a section that has not yet been written? As I understand it we (in the pthreads version) "override the native pthreads library". What does this mean? I am trying to research the issues associated with threading so that I understand the complications. The fact that Linux has two models and that Wine, FreeDCE and Samba (that I know of) seem to have found it necessary to bypass/hack/modify/override them indicates to me that there is something to understand. -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

2 3

installshield and Wine
by wino＠piments.com 05 Mar '05

05 Mar '05

What is the current state of play? It seems that InstallShield is pretty much and essential element in a working Wine env. But I tried to install Dragon NS 7 yesterday and it hung completely with a system wide modal in the middle of the screen. I had to kill the parent. There has been some regressions in Wine recently it seems , what would be the best wine version to install to get around this issue.? Thanks. -- Opera 7 mail on Linux

5 6

Dragon Naturally Speaking - working.
by wino＠piments.com 05 Mar '05

05 Mar '05

Good news and what looks like a first. Dragon Naturally Speaking 4 working under Wine. ======================================= reqd riched32 and comdlg32 native from 98SE Gentoo Linux , 2.6.10-nitro4 kernel wine-20050111 Fresh Wine installation installed IE6 using sidenet Install Dragon from CD no major issues. copy missing dll's ran up Dragon , enter user name , setup sticks at setting mike level but exits cleanly. #wine gentrain.exe picks up user name , dictated training text . It saves the vocab/voix profiles the drops out with 3 repeat errors but the profile is safe #wine natspeak.exe Can now dictate in stand-alone mode as in windoze. I now need some help with the guts of Wine to see if I can capture the keystrokes output by Dragon and pipe it to another Linux thread. Any suggestions on that? TIA :) -- Using Opera's revolutionary e-mail client: http://www.opera.com/m2/

3 3

Re: [user/tests/sysparams.c] More correct *MOUSEHOVER* tests (Don't apply)
by Paul Vriens 05 Mar '05

05 Mar '05

On Fri, 2005-03-04 at 21:39, Paul Vriens wrote: > Hi, > > current checks for only GetLastError()==ERROR_INVALID_SPI_VALUE) are > bogus, at least on Win98 as the LastError is not set. > > Changelog > LastError is not set on failure for *MOUSEHOVER* on Win98 > > Cheers, > > Paul. Hi, no need to apply this one. I shouldn't have checked for ERROR_CALL_NOT_IMPLEMENTED (maybe only at the very first test). Justin's patch seems to be on the right track. Cheers, Paul.

1 0

Re: USER32: Error checking for sysparams tests
by Paul Vriens 05 Mar '05

05 Mar '05

On Sat, 2005-03-05 at 06:42, jchevrier(a)nexicom.net wrote: > As discussed on wine-devel there are a handful of calls in the > SystemParametersInfo tests that don't check for returned errors and continue > on with testing a given parameter. This patch ensures that all initial calls > to SystemParametersInfoA in each parameter test have their returned errors > checked. To ease adding more error cases and reduce code duplication I have > consolidated error message handling into a single function. > > Changelog: > > * Consolidate error message handling > * Add error checking to all initial SystemParametersInfoA calls in each > parameter test to make sure that if a given parameter isn't supported or has > failed in some other way that we return and don't continue on with the test > * Remove a couple of TABS and align registry keys/values at the top of the > file Hi Justin, could you have a look at the patch I send in for *MOUSEHOVER* stuff. Apparently Win98SE returns 0 without setting last error for the *MOUSEHOVER* ones. Could you incorporate this into your patch? Mine is a bit 'overcomplete' as ERROR_CALL_NOT_IMPLEMENTED will probably never be returned (only for SystemParametersInfoA itself). Shouldn't we also always do a SetLastError(0xdeadbeef) before every call to SystemParametersInfoA? Cheers, Paul.

1 0

Drive detection stuff
by Mike Hearn 05 Mar '05

05 Mar '05

So, there are 4 obvious problems with our current drive management code: 1) We add links to the floppy drive. We should blacklist it, as it causes a big delay in the file open dialogs as we poll the drive which sits there spinning its motors naval-gazing. How many people still use floppy disks in 2005 anyway? I'm hoping the answer is "virtually none" 2) We don't add any device symlinks. Some programs need these eg d:: -> /dev/cdrom 3) The artwork in the file pickers sucks ass. Sorry, it does. It's ugly as sin and for some reason the Desktop icon is an arrow, not a desk. This doesn't matter when you only have C: and Z: drives. It does matter when you have 2 CD drives, 2 Windows drives, a floppy and a few other drives. Fixing this is theoretically easy but for some reason it never gets done. If any of you non-coders are reading this and want to contribute then this would be a good way to start. Good artwork already exists, it's just a case of finding it, converting it to the right format and getting the new bitmaps into CVS. 4) We don't detect new drives as they are mounted into the system, eg if I start a Windows program and then realize that my work is actually on a USB key, if I plug that key in Nautilus and GTK+ (and probably KDE) apps will detect it and see it, but we won't. Not even if I restart the app! This is bad. Fixing this is not, in theory, super hard. When HAL detects a new hotplug device it modifies the fstab file and mounts. If we watch the /etc/fstab file for changes and rerun drive detection therefore we can make this all magically work. Problems are: - Who triggers the resync? The wineserver is the obvious choice as there is only 1 per wineprefix but we'd need to integrate FAM support for that - How do we broadcast to apps that the drive definitions changed so we can update the UI, flush any caches etc? thanks -mike

13 21

Setting null region for window mask kills wine 20050112
by Kuba Ober 04 Mar '05

04 Mar '05

Hi, I was testing my Qt 3.3.4 application with wine, and it appears that setting a null widget mask via QWidget::setMask(QRegion()) puts wine into an endless loop. It continuously spews complaints that it ran out of gdi heap. I can reproduce it at home and send the actual error message if need be. I presume that this could be reproduced with the GPL qt-win32 port, but I didn't try. Cheers, Kuba Ober

1 0

Re: Account for permissions on Win2k - dlls/advapi32/tests/security.c
by Paul Vriens 04 Mar '05

04 Mar '05

On Fri, 2005-03-04 at 17:09, Jakob Eriksson wrote: > If we dont have permissions, we don't... > Checked for ERROR_NO_SUCH_PRIVILEGE > > Weirdly, Win2k does not recognize the last two, number 28 and 29. > > Evidence: > http://test.winehq.org/data/200503041000/2000_IDWASEMPTY/advapi32:security.… > It only fails for 1 w2k btw. The other 2 succeed, so it doesn't look like a general w2k problem. Couldn't it be a certain version of the dll? I've had the same issues with shlwapi/registry. Although the majority succeeds now, some 'old' dll's will still fail. Could it be an idea, to have every test (at least 1 in a dll test) tell the version of the tested dll? Or have a test within every dll that does exactly this (version checking). Cheers, Paul.

2 1

(no subject)
by Wine-devel 04 Mar '05

04 Mar '05

1 0

Should CDLGetLongPathName[AW] be exported by ordinal
by Francois Gouget 04 Mar '05

04 Mar '05

On Windows XP and 2003ES the CDLGetLongPathName[AW] ordinals are 4 and 5 respectively. On Windows 9x, NT4 and Windows 2000 they are 1 and 2 respectively. If Microsoft changed the ordinal of these APIs it means the ordinal does not matter so I'm tempted to post the following patch: Index: dlls/urlmon/urlmon.spec =================================================================== RCS file: /var/cvs/wine/dlls/urlmon/urlmon.spec,v retrieving revision 1.31 diff -u -p -r1.31 urlmon.spec --- dlls/urlmon/urlmon.spec 30 Nov 2004 21:14:21 -0000 1.31 +++ dlls/urlmon/urlmon.spec 23 Feb 2005 10:21:11 -0000 @@ -1,8 +1,8 @@ -1 stub CDLGetLongPathNameA -2 stub CDLGetLongPathNameW @ stub AsyncGetClassBits @ stub AsyncInstallDistributionUnit @ stub BindAsyncMoniker +@ stub CDLGetLongPathNameA +@ stub CDLGetLongPathNameW @ stub CoGetClassObjectFromURL @ stub CoInstall @ stdcall CoInternetCombineUrl(wstr wstr long wstr long ptr long) Yet in Windows 2000 Microsoft went out of its way to assign these ordinals to them so I suspect there is something more to this. Could it be that old versions of Internet Explorer import these APIs by ordinal and that since Windows XP and greater ships with a recent enough version of Internet Explorer Microsoft decided it was no longer necessary to keep the old ordinals for compatibility? What should we do if this turns out to be the case? Do we want to keep the ordinals anyway? I guess that the minimum would be to document this in the spec file. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

2 1

Wine MIDI Mapper
by Andrew Neil Ramage 04 Mar '05

04 Mar '05

In trying to get a Windows music composition program (www.noteworthycomposer.com) working, I have been unable to hear playbacks of music because the Wine MIDI Mapper does not open. Does anyone have any idea what is causing this problem, and if there is a fix available ? I am using Mandrake 10.0, Gnome 2.4 and Wine-20050211. -- Andrew [hackcoughsniffle] Internal Virus Database corrupt

1 0

Re: Drive detection stuff
by Oliver Stieber 04 Mar '05

04 Mar '05

> Ah, so this means that the directory change > notification mechanism > applies to volume notification as well? Or is it > still a somewhat separate > API? > > Nevermind, at least you just told us that this API > exists, so we should > try to get the hal/hotplug/fam stuff integratedf > towards this API. > On second thoughts additional, I was looking at doing something similar for linux installers using /dev/boot.ini and the registry. If you get anything working that way I'll take a look at making an installer that reads all the users settings from the windows registry for something like knopix and maybe look at implementing some of the windows settings in wine e.g. setting desktop wallpaper &co.. Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Re: Drive detection stuff
by Oliver Stieber 04 Mar '05

04 Mar '05

> Ah, so this means that the directory change > notification mechanism > applies to volume notification as well? Or is it > still a somewhat separate > API? > > Nevermind, at least you just told us that this API > exists, so we should > try to get the hal/hotplug/fam stuff integratedf > towards this API. > take a look at how ivman http://ivman.sourceforge.net/ does things. > Andreas Mohr > > Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

ESD sound support in Wine 20050111
by Kumaran Santhanam 04 Mar '05

04 Mar '05

I found a patch for ESD (Enlightenment Sound Daemon) support in Wine from July 2004. I modified this to work with Wine-20050111 and compiled the wineesd.drv.so driver. This driver works in both Wine and CrossOver 4.1. The patch and instructions are attached to this email. I have been using it for a few weeks and it seems to be working well. It would be great if it could be incorporated into the main Wine tree. Please let me know if you have any questions. Best Regards, Kumaran Wine Enlightenment Sound Daemon support --------------------------------------- [Jul 2004] Original driver code by Zhangrong Huang <hzhr(a)users.sourceforge.net> [Feb 2005] Ported to Wine 20050111 and CrossOver Office Professional 4.1 by Kumaran Santhanam <rhapsody(a)users.sourceforge.net> Instructions: 0) Make sure that esound-devel is installed. 1) Untar Wine-20050111.tar.gz 2) cd wine-20050111 3) patch -p1 <wineesd-20050111.patch 4) autoconf configure.ac >configure 5) ./configure 6) make depend 7) make Binary is built as dlls/winmm/wineesd/wineesd.drv.so

3 2

MSVCRT still hisshandling Exception
by Uwe Bonnes 04 Mar '05

04 Mar '05

Hallo, with a 2.6 kernel, _pn.exe from the Xilinx ISE suite crashes while loading the last process. With native MSVCRT, a message box pops up, reporting the error. With builtin msvcrt, the exception handling loops until a stack overflow happens. Find appended the beginning of the loop. With the second loop, trace:seh:EXC_CallHandler calling handler at 0x77ec1830 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 2 appears, with the third loop cointaining these lines doubled and so on. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- fixme:msvcrt:_setmbcp Unreal codepages (e.g. -3) not implemented fixme:ole:CoRegisterMessageFilter stub fixme:process:CreateProcessA BON: App "(null)" cmd ""C:\\ise-6.3\\bin\\nt\\findmgsg.exe"" err:comm:GetCommState tcgetattr or ioctl error 'Invalid argument' err:ole:CoGetClassObject couldn't load InprocServer32 dll C:\windows\system\vbscript.dll fixme:ole:CoCreateInstance no classfactory created for CLSID {3f4daca4-160d-11d2-a8e9-00104b365c9f}, hres is 0x80040150 err:x11drv:X11DRV_CreateWindow invalid window width -19 err:x11drv:X11DRV_CreateWindow invalid window width -19 fixme:msvcrt:MSVCRT__sopen : pmode 0x01b6 ignored trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x76726151 trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=44455359 trace:seh:EXC_RtlRaiseException eax=44455355 ebx=b7212480 ecx=b7542c88 edx=ffffffff esi=b7542ca4 edi=b7542c88 trace:seh:EXC_RtlRaiseException ebp=77428a70 esp=77aa09dc cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00010206 trace:seh:EXC_CallHandler calling handler at 0x76774e9f code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x76ccdea5 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661d92b code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661d93d code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661bb36 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661f3e5 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661c926 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661ce51 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661c590 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x76618114 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x45bef5 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x6c402ef3 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x6c402e0a code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x6c402d82 code=c0000005 flags=0 trace:seh:cxx_frame_handler handling C++ exception rec 0x77aa0984 frame 0x77aafce8 trylevel 0 descr 0x6c424f50 nested_frame (nil) exception type: flags 8508c483 destr 0x8a4275c0 handler 0x548d1a47 type info 0xe0831024 trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x7732567b trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=e0831024 trace:seh:EXC_RtlRaiseException eax=e0831024 ebx=77345620 ecx=00000000 edx=77eff031 esi=0a90274b edi=00000000 trace:seh:EXC_RtlRaiseException ebp=77aa0234 esp=77aa0198 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00010202 trace:seh:EXC_CallHandler calling handler at 0x77ec1830 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x76774e9f code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x76ccdea5 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661d92b code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661d93d code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661bb36 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661f3e5 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661c926 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661ce51 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x7661c590 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x76618114 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x45bef5 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x6c402ef3 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x6c402e0a code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 trace:seh:EXC_CallHandler calling handler at 0x6c402d82 code=c0000005 flags=10 trace:seh:cxx_frame_handler handling C++ exception rec 0x77aa0140 frame 0x77aafce8 trylevel 0 descr 0x6c424f50 nested_frame (nil) exception type: flags 5028 destr 0xb7fffb90 handler 0xb7ff49e0 type info 0xb7f38c90 0: code=c0000005 flags=0 addr=0x773256b1 trace:seh:EXC_RtlRaiseException info[0]=00000000 trace:seh:EXC_RtlRaiseException info[1]=244c8b14 trace:seh:EXC_RtlRaiseException eax=7734142d ebx=77345620 ecx=b7fd5140 edx=00000007 esi=244c8b10 edi=00000000 trace:seh:EXC_RtlRaiseException ebp=77a9f9f0 esp=77a9f954 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00010246 trace:seh:EXC_CallHandler calling handler at 0x77ec1830 code=c0000005 flags=0 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x77ec1830 code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 2 trace:seh:EXC_CallHandler calling handler at 0x76774e9f code=c0000005 flags=10 trace:seh:EXC_CallHandler handler returned 1 ... err:seh:setup_exception stack overflow 212 bytes in thread 0009 eip b7ec7425 esp 779b0f2c stack 0x779b0000-0x77ab0000

1 0

Re: Make QueryServiceConfigW return an empty string for empty dependencies
by James Hawkins 04 Mar '05

04 Mar '05

On Fri, 4 Mar 2005 13:54:34 +1100, Troy Rollo <wine(a)troy.rollo.name> wrote: > QueryServiceConfigW currently returns a NULL pointer for lpDependencies when > there are no dependencies. The documentation states that an empty string has > the same meaning, and at least one application (an MSIEXEC.EXE from the > Office XP CD) will SEGV if this is NULL. Using the empty string avoids this. > > ChangeLog: > Return an empty string for service dependencies when there are no > dependencies, rather than a NULL pointer, which causes some apps > to SEGV. Can you write test cases for this behaviour? -- James Hawkins

1 0

Re: Make QueryServiceConfigW return an empty string for empty dependencies
by James Hawkins 04 Mar '05

04 Mar '05

On Fri, 4 Mar 2005 13:54:34 +1100, Troy Rollo <wine(a)troy.rollo.name> wrote: > QueryServiceConfigW currently returns a NULL pointer for lpDependencies when > there are no dependencies. The documentation states that an empty string has > the same meaning, and at least one application (an MSIEXEC.EXE from the > Office XP CD) will SEGV if this is NULL. Using the empty string avoids this. > > ChangeLog: > Return an empty string for service dependencies when there are no > dependencies, rather than a NULL pointer, which causes some apps > to SEGV. Can you write test cases for this behaviour? -- James Hawkins

1 0

wine-user.pdf feedback 2
by Dan W. 04 Mar '05

04 Mar '05

Okay, now I found what I think is a more serious missing piece of info in wine-user.pdf. In page 20, last paragraph, it says one can start off by modifying the sample config file, which "can be found in the directory 'documentation/samples'... Problem is, I did a file search for 'documentation', and I get like 10 pages of hits I did a file search for samples, and same thing, or worse. In both cases I went through all those instances visually scanning for 'wine' or 'config' and found nothing at all. I know I ought to have the sources somewhere, because when I installed fc2, I said "install everything", and that included sources; but I have no idea where to look for the wine documentation folder. I have to give up on it for now. Far past my bedtime by now, anyways.. ;-) Cheers!

3 2

Re: MSI: Radio Buttons
by Dmitry Timoshkov 04 Mar '05

04 Mar '05

"Ulrich Czekalla" <ulrich.czekalla(a)utoronto.ca> wrote: > + if (control->hwnd) > + { > + WNDPROC oldproc = (WNDPROC) SetWindowLongPtrW(control->hwnd, GWLP_WNDPROC, > + (LONG)MSIRadioGroup_WndProc); Then it's better to cast to LONG_PTR instead of LONG. -- Dmitry.

1 0

Re: [ADVAPI] SetSecurityInfo
by Robert Shearman 03 Mar '05

03 Mar '05

Raphael wrote: >Hi, > > Changelog: > - simple implementation of SetSecurityInfo > >(seems to be needed by War3 frozen throne, cf >http://forums.gentoo.org/viewtopic-t-303306.html?sid=3f962c702ae58ad8902ca8…) > > I have made a few comments on the implementation below: > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = advapi32.dll >-IMPORTS = kernel32 ntdll >+IMPORTS = winspool kernel32 ntdll > > Should be in DELAYIMPORTS. We don't want to slow down the loading of all applications because of this one uncommon case. >@@ -1418,6 +1422,87 @@ > { > FIXME("(%s) : stub\n", debugstr_w(lpFileName) ); > return TRUE; >+} >+ >+/****************************************************************************** >+ * SetSecurityInfo [ADVAPI32.@] >+ */ >+BOOL WINAPI SetSecurityInfo(HANDLE handle, >+ SE_OBJECT_TYPE ObjectType, >+ SECURITY_INFORMATION SecurityInfo, >+ PSID psidOwner, >+ PSID psidGroup, >+ PACL pDacl, >+ PACL pSacl) >+{ >+ SECURITY_DESCRIPTOR sd; >+ BOOL test; >+ >+ TRACE("(%p, %x, %x, %p, %p, %p, %p) : alomst stub\n", handle, ObjectType, SecurityInfo, psidOwner, psidGroup, pDacl, pSacl); > > Remove the "almost stub" part of it and just print FIXME's for the parts that aren't implemented, otherwise the next person that comes along to this function will spend hours trying to work out what isn't implemented, if they even realise this function is to blame. >+ >+ test = InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION); >+ if (!test) return FALSE; >+ >+ if (SecurityInfo & DACL_SECURITY_INFORMATION) { >+ test = SetSecurityDescriptorDacl(&sd, TRUE, pDacl, TRUE); >+ } >+ if (SecurityInfo & SACL_SECURITY_INFORMATION) { >+ test = SetSecurityDescriptorSacl(&sd, TRUE, pSacl, TRUE); >+ } >+ if (SecurityInfo & GROUP_SECURITY_INFORMATION) { >+ if (NULL == psidGroup) { >+ SetLastError( ERROR_INVALID_PARAMETER ); >+ return FALSE; >+ } >+ test = SetSecurityDescriptorGroup(&sd, psidGroup, TRUE); >+ } >+ if (SecurityInfo & OWNER_SECURITY_INFORMATION) { >+ if (NULL == psidOwner) { >+ SetLastError( ERROR_INVALID_PARAMETER ); >+ return FALSE; >+ } >+ test = SetSecurityDescriptorOwner(&sd, psidOwner, TRUE); >+ } >+ >+ switch (ObjectType) { >+ case SE_KERNEL_OBJECT: >+ test = SetKernelObjectSecurity(handle, SecurityInfo, &sd); >+ break; >+ case SE_SERVICE: >+ test = SetServiceObjectSecurity(handle, SecurityInfo, &sd); >+ break; >+ case SE_REGISTRY_WOW64_32KEY: >+ case SE_REGISTRY_KEY: >+ test = RegSetKeySecurity(handle, SecurityInfo, &sd); >+ break; >+ case SE_LMSHARE: >+ /*test = NetShareSetInfo(handle, SecurityInfo, &sd); TODO: don't exit on netapi */ >+ break; >+ case SE_PRINTER: >+ { >+ PRINTER_INFO_2A pr_info; >+ memset(&pr_info, 0, sizeof(pr_info)); >+ /** maybe we should do GetPrinter before SetSecurityDesc* ? */ >+ test = GetPrinterA(handle, 2, (LPBYTE) &pr_info, 0, NULL); >+ pr_info.pSecurityDescriptor = &sd; >+ test = SetPrinterA(handle, 2, (LPBYTE) &pr_info, PRINTER_CONTROL_SET_STATUS); >+ break; >+ } >+ >+ case SE_FILE_OBJECT: >+ /*SetFileSecurity ? */ >+ case SE_WINDOW_OBJECT: > > Call SetUserObjectSecurity. >+ case SE_DS_OBJECT: >+ case SE_DS_OBJECT_ALL: >+ case SE_PROVIDER_DEFINED_OBJECT: >+ case SE_WMIGUID_OBJECT: >+ case SE_UNKNOWN_OBJECT_TYPE: >+ default: >+ WARN("unsupported ObjectType %d\n", ObjectType); > > Change this to a FIXME. >+ test = TRUE; >+ } >+ >+ return test; > > This function returns a DWORD error code, not a BOOL. > } > > /****************************************************************************** > > Rob

1 0

Re: ntdll: Add NtCreateKey tests
by Alexandre Julliard 03 Mar '05

03 Mar '05

James Hawkins <truiken(a)gmail.com> writes: > What are the steps I need to take to break registry initialisation? I > did wonder how anything in the real win32 registry could be created > though if you can't create a key directly under HKLM or HKU. If this > really does break initialisation, can we implement a different > create_key that has little restrictions and would only be used > internally, or would this just be scrapped entirely? I don't think there's any point in replicating that behavior. I doubt there's any such check on Windows either, it's most likely just a side effect of the way the registry files are "mounted" at different places in the tree. Once we have a proper implementation of RegLoadKey/RegUnloadKey we should get the same behavior automatically. -- Alexandre Julliard julliard(a)winehq.org

1 0

any way to unlink the symbolic link, not its target?
by Kuba Ober 03 Mar '05

03 Mar '05

Hi, I'm using wine to cross compile projects using vc7.1 from a software configuration tool called aegis (http://aegis.sf.net). I'm maintaining a symlinked baseline with source and derived (.obj, .exe, .pdb) files in it. A change only has copies of changed files. So, when the compiler tries to output something, it first tries to unlink the file. But that won't work as wine tries to unlink target of the symlink, instead of the symlink itself. Is there any switch somewhere to revert to deleting the symbolic links, or if not -- what source file should I look into to patch that? Thanks a lot, Kuba Ober

1 0

Re: ntdll: Add NtCreateKey tests
by Robert Shearman 03 Mar '05

03 Mar '05

James Hawkins wrote: >On 03 Mar 2005 11:02:24 +0100, Alexandre Julliard <julliard(a)winehq.org> wrote: > > >>James Hawkins <truiken(a)gmail.com> writes: >> >> >> >>>I've been discerning the behavior of RegCreateKey and NtCreateKey when >>>creating a key directly under HKLM or HKU, and this test reveals that >>>NtCreateKey does check for this case and returns a >>>STATUS_INVALID_PARAMETER. >>> >>> >>This is going to break registry initialisation. Do you really have an >>app that depends on that? >> >> >> > >What are the steps I need to take to break registry initialisation? I >did wonder how anything in the real win32 registry could be created >though if you can't create a key directly under HKLM or HKU. If this >really does break initialisation, can we implement a different >create_key that has little restrictions and would only be used >internally, or would this just be scrapped entirely? > > It looks like Windows only uses RegLoadKey to create keys under HKLM and HKU. Maybe we should do the same. Rob

2 4

Re: Wine cabinet.dll FDI Conformance Test Patch
by Dimitrie O. Paun 03 Mar '05

03 Mar '05

On Wed, Mar 02, 2005 at 03:41:21PM -0800, Rizwan Kassim wrote: Good stuff guys! Here are a few comments: +#ifndef STANDALONE +#include <wine/test.h> +#define ok2 ok +#else +/* To build outside Wine tree, compile with cl -DSTANDALONE -D_X86_ tvfs.c cabinet_fdi.c FDI.lib + These are only called if standalone are used, defining ok and START_TEST, which would normally be declared in winetree */ +#include <assert.h> +#include <stdio.h> +#define START_TEST(name) main(int argc, char **argv) +#define ok(condition, msg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__); \ + exit(1); \ + } } while(0) +#define ok2(condition, msg, arg) \ + do { if(!(condition)) { \ + fprintf(stderr,"failed at %d, msg:" msg "\n",__LINE__, arg); \ + exit(1); \ + } } while(0) +#define todo_wine Please get rid of this. It is useless in the Wine tree. If you need it, just put it in a private header file, and include it there. +#ifndef DEBUG_ALLOC +FNALLOC(final_alloc) { + return malloc(cb); +} +FNFREE(final_free) { + free(pv); + return; +} +#else +FNALLOC(final_alloc) { + trace(" FNALLOC just called with %d\n",cb); + return malloc(cb); +} +FNFREE(final_free) { + trace(" FNFREE just called with %d\n",pv); + free(pv); + return; +} +#endif No need for this either. It's a test after all, there's no big deal if you have a memory leak... :) +#ifdef VERBOSE + trace(" FNFDINOTIFY real just called with %d, %d \n",fdint,pfdin); +#endif Don't do it this way. Define trace such that you can use it unconditionally. In general, try to avoid using the preprocessor in the code. + trace(" Cabinet Data : cbC %d cF %d cFi %d si %d iC %d fr %d hp %d hn %d\n", + cabinfo.cbCabinet, + cabinfo.cFolders , + cabinfo.cFiles , + cabinfo.setID, + cabinfo.iCabinet, + cabinfo.fReserve , + cabinfo.hasprev , + cabinfo.hasnext ); These should fit on 2-3 lines, no? + ok2 ( cabinfo.cbCabinet == TcbCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFolders == TcFolders, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.cFiles == TcFiles, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.setID == TsetID, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.iCabinet == TiCabinet, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.fReserve == TfReserve, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasprev == Thasprev, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); + ok2 ( cabinfo.hasnext == Thasnext, "FDIIsCabinet,cabinfo %s data did not match! Failed!\n", cabname); Use ok() instead of ok2(). Also, it's probably better if the message contains the values of the variables that don't match, so we know why it failed. +#ifdef TVFS_DEBUG + trace("tvfs_create called with %s, %d, %d\n", fname, buf, len); +#endif Similar to the one above, do the test inside the body of trace(), not on every use. + switch(whither) { + case SEEK_SET: { + handles[h]->pos = whence; + break; + } + case SEEK_CUR: { + handles[h]->pos += whence; + break; + } This one needs a bit of indentation, no? +int tvfs_close(int h){ + int inode = handles[h]->inode; +#ifdef TVFS_DEBUG + trace("tvfs_close called with %d\n", h); +#endif + if (!files[inode]){ + return -1; + } + free(handles[h]); + /* Currently does NOT enabled open to reuse this handle */ + return 0; + } The formatting on this is funny. It needs indenting, spaces before '{', and the opening braket for the function on a new line. +main(){ Ditto. -- Dimi.

2 1

Re: MSI trouble with ALLUSERPROFILE
by Juan Lang 03 Mar '05

03 Mar '05

> I get err with %ALLUSERPROFILE during install program: <snip> > Where I will set this env variable? (I know I can do it in shell, but > what is the right way?) Hm.. I never did get this quite right. For consistency, it should be in wine.inf. That's where USERPROFILE is: HKLM,System\CurrentControlSet\Control\Session Manager\Environment,"USERPROFILE",,"%53%" But I don't think it can go here, because setupapi (which is what interprets those funny "%53" type strings) doesn't have a magic constant for this, and there isn't a CSIDL value for it. So maybe shell32 should set it in SHELL_RegisterShellFolders? --Juan __________________________________ Celebrate Yahoo!'s 10th Birthday! Yahoo! Netrospective: 100 Moments of the Web http://birthday.yahoo.com/netrospective/

1 0

Use of STLPort with winegcc
by Boaz Harrosh 03 Mar '05

03 Mar '05

Winegcc will prepend any of the command line switches with "-I wine/include/msvcrt" if the "-no-cygwin" flag is specified. This breaks STLPort because STLPort must be first on the search path, before the regular c-runtime of the compiler. This way it can do it's tricks of what to use and what not to use from the standard c-runtime. What is the current way to solve it. I could remove the "-no-cygwin" flag and Manually add the "-I wine/include/msvcrt" and "-D__MSVCRT__". But how do I add the "-dmsvcrt" on the Winebuild command line, as it is all internal to winegcc. What would be the right way to do it? I would submit a patch, but what should I do? Just append the "-I .../msvcrt" instead of prepend, or maybe use "-isystem .../msvcrt". The docs for gcc say that "-isystem" folders will be searched before the default gcc folders but after any -I folders. Free Life Boaz

2 1

Re: MSI: Radio Buttons
by Dmitry Timoshkov 03 Mar '05

03 Mar '05

"Ulrich Czekalla" <ulrich.czekalla(a)utoronto.ca> wrote: > + if (control->hwnd) > + { > + WNDPROC oldproc = (WNDPROC) SetWindowLongW(control->hwnd, GWLP_WNDPROC, > + (LONG)MSIRadioGroup_WndProc); I'd suggest to use SetWindowLongPtrW even it's just a macro in Win32 we still need to write 64-bit clean code. -- Dmitry.

1 0

Speach rec. on Wine
by wino＠piments.com 03 Mar '05

03 Mar '05

Hi, I am trying to get Dragon Naturally Speaking to run under Wine. I have got it installed successfully from CD, now I need to get it running. I have wine-20050111 installed , a 2.6.10 kernel and a current version of IE6 since Dragon apparently needs IE installed . Some advice please. Is there any fundemental problems which make this a no-hoper, has anyone got this working so far? Any a-priori conditions or advice I should know, like what sound model to use on Linux. Where should I search for detailed info on debugging something like this? There seems to be very little detailed help for Wine which I find surprising. Maybe I have just missed it Any other advice that could save me wasting lots of time. TIA .

2 1

Re: Add all MIME types
by Mike Hearn 03 Mar '05

03 Mar '05

On Wed, 02 Mar 2005 12:56:33 +0000, Mike Hearn wrote: > Oh my god, there are a lot of these! Wouldn't it be a better long term > solution to just get the desktop environments sorted out? They should be > sharing the same MIME database now right? So why are they not all > identifying EXEs as the same MIME type? By the way, that wasn't an objection to the patch. I think it should go in. It's trivial enough and doesn't have any bad consequences except slightly less "elegance" but we can fix that one day when all the desktops are fixed :)

1 0

http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz
by Grant Williamson 03 Mar '05

03 Mar '05

Hi, I am just wondering how much does the wine source located on http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz differ from 20040716. I guess its codeweavers internal patched version, I see changes in there dating to January. Are there any restrictions on using this source?

3 3

Re: imagelist: style fixes
by Alexandre Julliard 03 Mar '05

03 Mar '05

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > ChangeLog > Style fixes for consistent formatting. I knew I was going to regret applying Mike's indentation patches... Folks, please let's not start an indentation police, there's no reason to "fix" anything unless a file is really so messed up that it becomes unreadable. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [user/tests/sysparams.c] Added more SetLastError(0)'s
by Dmitry Timoshkov 03 Mar '05

03 Mar '05

"Paul Vriens" <Paul.Vriens(a)xs4all.nl> wrote: > as discussed a few times on wine-devel, there isa need to clear the > last error before calling a SPI_{GET|SET} routine. > > It appears that not every call resets the last error to 0 on succession > and thus errors will propagate and leave us in the dark. You have to set last error to some bogus value (usually 0xdeadbeef) in order to test whether an API really has changed it. -- Dmitry.

3 2

Re: MSI: Radio Buttons
by Alexandre Julliard 03 Mar '05

03 Mar '05

Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes: > const static WCHAR szStatic[] = { 'S','t','a','t','i','c',0 }; > +const static WCHAR szButton[] = { 'B','U','T','T','O','N', 0 }; > + > +const static WCHAR szButtonData = { 0 }; Did you really intend to use an empty string here for the button property? That doesn't seem right; though if you really need to redefine the winproc it would be much cleaner IMO to define a proper window class. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20 and test app
by Mike McCormack 03 Mar '05

03 Mar '05

Hi Krzysztof, Krzysztof Foltman wrote: > This is an attempt at starting a RichEdit 2.0 clone, plus a test app for > it (which I, for some reason, decided to call Wine WordPad). Cool. Looks like you've done alot of good work. > It lacks most essential functionality, and source formatting is not > exactly standard, but it has enough functionality to make a couple of > Wine developers convince me to release it now. Or weeks ago. Well, you wrote it, so you get to choose the formatting. I like that you've used lots of small functions, rather than monolithic 200 line globs. I like the asserts too. > The test app uses the Mike McCormack's test snippet to fill the control > with some fancy formatted text. > > Hope the patch is OK. Adding new DLL's and EXE's isn't an easy process. OK, now some suggestions: * submitting riched20 and the new wordpad program seperately would be a good idea. The bigger the patch, the longer it tends to hang round before it's committed. * instead of #ifndef __WINESRC__ ... printf ... #endif, how about using wine's debug macros TRACE, ERR, etc? Then you can just #define TRACE to printf when __WINESRC__ isn't defined * instead of XXXFK how about FIXME? * you probably should get rid of the _int3 macro in wrap.c, and replace it with DebugBreak() * ME_DumpParaStyle isn't used... maybe change it to use MESSAGE() rather than a message box. You can dump stuff by checking the condition WINE_TRACE_ON(richedit). You'll need to declare a WINE_DEFAULT_DEBUG_CHANNEL for that.. * maybe you want to add LGPL licenses on your header files? * keep the formatting in your Makefile.in the same as the other dlls. Julliard's a bit fussy about that, so he's probably going to change it anyway. Might as well save him the time. Mike

1 0

World of Warcraft - crash in game
by Alex Woods 03 Mar '05

03 Mar '05

Hi, World of Warcraft is working beautifully now apart from a crash that occurs seemingly randomly. The application is catching the crash, and giving a message like this: This application has encountered a critical error: ERROR #132 (0x85100084) Program: C:\Program Files\World of Warcraft\WoW.exe Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557102CD EAX=00000000 EBX=55BDFCA8 ECX=00000000 EDX=55BDFBB8 ESI=5E320308 EDI=00000000 EBP=55BDFC08 ESP=55BDFB9C EIP=557102CD FLG=00010212 CS =0023 DS =002B ES =002B SS =002B FS =005B GS=0063 I know this isn't really much use on it's own. I've tried turning on +relay logging, but it's proved futile - it seems to end up freezing up my system before a crash occurs. One thing that might be useful is that the access violation always seems to be around the same small area of memory each time, eg: Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:557103CD Exception: 0xC0000005 (ACCESS_VIOLATION) at 0023:5571025D Over the course of 13 (unlucky for me ;)) crashes, these are the only 3 addresses it has given. My question is what can I do to debug this? +relay logging is probably infeasible, but I'd be happy to hack around to get it to only log certain things - I'm not sure what I'd need to log. Also, the last time it crashed, I was lucky enough to have it leave me in winedbg, which I've left open. Is there anything worth my while poking around with in there while I have the chance? I guess I'll be running memtest on my machine too, but I'd like to do what I can in winedbg first ;) Cheers. -- Alex

4 6

MSI trouble with ALLUSERPROFILE
by Vitaly Lipatov 03 Mar '05

03 Mar '05

I get err with %ALLUSERPROFILE during install program: trace:msi:MSI_FormatRecordW (L"[%ALLUSERSPROFILE]") trace:msi:deformat_string_internal Starting with L"[%ALLUSERSPROFILE]" trace:msi:find_next_outermost_key Found Key L"%ALLUSERSPROFILE" trace:msi:deformat_string_internal Current (null) .. L"%ALLUSERSPROFILE" err:msi:deformat_environment Unknown environment variable trace:msi:deformat_string_internal after everything (null) Where I will set this env variable? (I know I can do it in shell, but what is the right way?) -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

%Fp printf format specifier
by Uwe Bonnes 03 Mar '05

03 Mar '05

Hallo, http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore98/H… uses a "%Fp" format spezifier. Running with native msvcrt, this seems to be the same as "%p". However builtin msvcrt stumbles about the "superfluous" 'F". Does anybody know what the meaning of the "F" is? I didn't find anything on the net. And b.t.w., how do I get Google to not ignore the '%' in a search for "%Fp"? And mingw/malloc.h has the definitions of _USEDENTRY and _FREEENTRY excahnged and misses more entries... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

6 12

Re: Use IsWindowVisible instead of GetWindowLong(GWL_STYLE) & WS_VISIBLE as a test for desktop visibility
by Ferenc Wagner 03 Mar '05

03 Mar '05

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > let's see if IsWindowVisible() better detects a not visible desktop. Ah, fine, this may put some momentum into the situation! -- Feri.

3 2

Printing in Wine (using "ttydrv" device)...
by Juergen Hammelmann 03 Mar '05

03 Mar '05

Hi All, we are developing a windows/wine app for automation of MS Word (serial printing in background to PS files with the WINEPS driver on SuSE 9.2 platform, wine-20050211). We want to run this application and Word in background as server, no graphical output should occur in this environment, we don't like to install a X11-/VNC-Server on the server: Using "ttydrv" device I found out that all graphical output is disabled and wine can run without a X11 Server / VNC Server, this is prefered: but here graphical output of printing is disabled, too! The PS files created are blank! Is there any way to configure functioning printing with "ttydrv" device? Ferenc Wagner told me, that printing and graphical output is done through GDI both, so ttydrv as GDI backend disable this all!? Is this the right explanation? Is there any way to enable this for printing again? Best Regards, Jürgen

1 0

Visual C++ 6.0 as a Winelib IDE?
by Ira Krakow 03 Mar '05

03 Mar '05

I have Visual C++ 6.0 running under Crossover Office 4.1, which of course means it's running under Wine. For one of the examples in the Wine/Winelib book, I decided to take the code produced by the VC++ Win32 "Hello World" wizard and see how to port it to Wine. Turns out, it's almost trivial. Create an empty directory, copy the *.c, *.rc, *.h, and *.ico files to it. VC++ produces tons of other files, but they're either used to maintain the Visual Studio environment, or are intermediate compilation files that aren't needed. Then run: $ winemaker . The Makefile that Winemaker generates _almost_ works. You need to delete the references to the mfc library and mfc.dll. After doing that, running make generates the .so file. Wine runs it flawlessly. I got to thinking - can I convert the code from the MFC application as easily? Seems like it's doable, because the generated code runs in VC++/Crossover Office 4.1. I tried the same steps as before, with Winemaker, but I couldn't figure out what Makefile modifications were needed. All of this got me to thinking - could Wine running Visual C++ be a viable IDE for porting? Maybe just linking VC++ with the Winelib libraries would do it. Maybe after tweaking Winemaker and publishing a HOWTO we could show that this is a viable path? It's certainly easier than for Visual Studio developers and could help attract them to Wine. Another benefit - we could use the Visual C++ sample programs as tests for Wine. The programs might exercise areas that haven't been tested thoroughly. What do you think? Ira

5 6

wine-user.pdf feedback
by Dan W. 02 Mar '05

02 Mar '05

I think I have the answer why feedback to the wine-user.pdf has so far been disappointing: It's too well written. No questions to ask, almost. Actually, probably 90% of users try to get by without reading it. I saw a posting somwhere today, someone advising someone else about running the wine install, without mentioning uninstalling any old versions. The blind leading the blind. You need to put a big README!!!.TXT file somewhere, where it should say: "You choose: Spend 1 day reading wine-user.pdf, and another day setting it up; or spend a week trying to set it up, a month asking questions at the forums, a year in depression, then finally a day reading wine-user.pdf, and another day setting it up." But probably, the lucky 10% who read it never have any questions, so you don't hear from them. In my case, though, combining a high IQ and being a complete helpless newbie to Linux, is a powerful combination that produces questions out of nowhere. In the chapter about installing and un-installing, one small detail got left out: "How does one KNOW whether wine is installed, and if so what version it is?" I'm sure it must sound like typical newbie crap questions to you, but to me it's a solid and tangible one. Well, I do know that I do have wine installed, because when I installed Fedora Core 2, I said "install everything". Besides, I tried.. "wine /mnt/C/windows/notepad.exe" and it worked!!!! :-) :-) :-) But as for the version of wine I have, I have no idea how to find out. In Windows, I'd check the Add/remove programs, to see if it mentions the version, or I'd look in the installation folder for a readme.txt file. In Linux, not so easy: Even after doing a file search for "wine", I still can't tell what folder it is installed in, if indeed it is installed in ONE folder, and not many. Looks like many, by the looks of it... Or at least two: One under /usr/local, which only contains two files, another for documentation, elsewhere, and I saw a folder somewhere with alotof.dll.so files. Anyways, thank you for the great work you've done and are doing. Some day Historians will remember you like today we remember Leonardo, or whoever: How Humanity rid itself of a great monopoli threat. As newbie as I am in Linux, I'm the expert here at work. If I can get our Windows apps to run on Linux, I might succeed at having the company switch over. Wish me luck.

3 2

vartest.c - major pain in the build process
by Krzysztof Foltman 02 Mar '05

02 Mar '05

Is there any reason for gcc 3.3.1 to spend several minutes on compiling dlls/oleaut32/tests/vartest.c ? I guess it can be explained by optimization stage going nuts on compiling long functions with many branches (contained in the macros), but there must be a way to speed this up. It's barely tolerable now, and upgrading gcc is not an option for everyone. Krzysztof

9 23

user/tests/sysparams.c : test_SPI_SETKEYBOARDPREF on win98
by Paul Vriens 02 Mar '05

02 Mar '05

Hi, I saw this test was recently added. It fails partly on my win98 box as this registry has the values in a different place. WinXP: [HKEY_CURRENT_USER\Control Panel\Accessibility\Keyboard Preference] "On"="0" Win98: [HKEY_CURRENT_USER\Control Panel\Accessibility] "Keyboard Preference"="0" What's the best(tm) way to cater for both? Just use: SPI_SETKEYBOARDPREF_REGKEY and SPI_SETKEYBOARDPREF_WIN98_REGKEY for example and have the test check the windows version? Or change test_reg_key to cope with 2 different sets? Cheers, Paul.

1 0

Re: Dump HeapWalk entries
by Dimitrie O. Paun 02 Mar '05

02 Mar '05

On Wed, Mar 02, 2005 at 05:52:45PM +0100, Uwe Bonnes wrote: > + if ((entry->wFlags & PROCESS_HEAP_ENTRY_BUSY ) > + && (entry->wFlags & PROCESS_HEAP_ENTRY_MOVEABLE)) > + { > + /* Treat as block */ > + DPRINTF( "BLOCK->hMem\t\t:%08lx\n", (DWORD)entry->u.Block.hMem); > + } Please don't introduce _another_ style of brackets, just use the one that's used in the file. Should be either: if (....) { .... } or if (....) { .... } -- Dimi.

1 0

DPLAYX_ConstructData error during tools/wineinstall
by Paul Vriens 02 Mar '05

02 Mar '05

Hi, I don't know when it started and if found I wasn't able to reproduce, but this is the message I sometimes get during a tools/wineinstall on a clean cvs install: Configuring Wine for a no-windows install in /data/wine-c... err:dplay:DPLAYX_ConstructData : unable to map static data into process memory space (487) /home/paul/.wine updated successfully. I can only say that I noticed this the last few (3?) weeks or so and haven't before. The first time I saw it, I did some regression testing, but as said, I wasn't able to reproduce at will. Is this a problem or can it be ignored (although it's an err). Or better yet, what could be the cause. Cheers, Paul.

1 0

CVS SERVER OUT OF SPACE?
by Oliver Stieber 02 Mar '05

02 Mar '05

Hi, It looks like cvs server has run out of diskspace. cvs update reports. cvs server: Updating . cvs server: failed to create lock directory for `/home/wine/wine' (/home/wine/wine/#cvs.lock): No space left on device cvs server: failed to obtain dir lock in repository `/home/wine/wine' cvs [server aborted]: read lock failed - giving up Send instant messages to your online friends http://uk.messenger.yahoo.com

4 5

Re: [winedbg] Get expressions working again.
by Pouech Eric DMI AEI CAEN 02 Mar '05

02 Mar '05

I don't think this patch should go in as it is: - I don't think it's a good idea to have two ways to express a pointer type in the debugger (one being the standard dbghelp's SymTagPointerType, the other one the new deref count you've introduced). It would be better to add dynamic winedbg types (in the contrary to the static one's we already use dbg_itype_*), when we cannot find one in a module. - the returned string (for internal types' name) should be HeapAllocate:d, not a static buffer - please, use the current style for parenthesis, braces... and don't add a new one A+ > Message du 01/03/05 18:28 > De : "Oliver Stieber" > A : wine-patches(a)winehq.com > Copie à : > Objet : [winedbg] Get expressions working again. > > Hi, > This patch starts to get expressions working again and > also allows derefrencing where there is no explicit > type for that dereference. e.g. > > (short)0x12356 now returns the correct value instead > of an error > > *((int *)0x23467) is now a valid expression. > and > ***((int ***)0x23467) should also work properly. > > This should also fix watches with expressions but I > haven't given it much testing. > > Send instant messages to your online friends http://uk.messenger.yahoo.com > > [ winedbg_expressions_os_1.patch (18.4 Ko) ]

2 1

Re: Add all MIME types
by Mike Hearn 02 Mar '05

02 Mar '05

Scott Ritchie wrote: > -MimeType=application/x-ms-dos-executable > +MimeType=application/x-ms-dos-executable;application/x-msdos-program;application/x-msdownload;application/exe;application/x-exe;application/dos-exe;vms/exe;application/x-winexe;application/msdos-windows;application/x-msdos-program;application/x-zip-compressed > NoDisplay=true Oh my god, there are a lot of these! Wouldn't it be a better long term solution to just get the desktop environments sorted out? They should be sharing the same MIME database now right? So why are they not all identifying EXEs as the same MIME type? thanks -mike

1 0

Re: Ignore msi/version.res
by Alexandre Julliard 02 Mar '05

02 Mar '05

Francois Gouget <fgouget(a)codeweavers.com> writes: > Francois Gouget <fgouget(a)codeweavers.com> > Ignore version.res. version.res is no longer generated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Help with winebuild/winegcc
by Ivan Leo Puoti 02 Mar '05

02 Mar '05

Hello, I'm trying to get a program in the programs/ directory to export symbols, I've added -shared path/to/spec/spec.c to the linker command, but I now get a segmentation fault at startup. Can someone knowledgeable about winegcc/winebuild give me a suggestion/solution? I'm really stuck because of this and can't get on with safedisc support. Ivan.

2 2

re: gcov and Wine (was: Re: Wine cabinet.dll FDI Conformace Test Patch)
by Dan Kegel 02 Mar '05

02 Mar '05

Mike Hearn wrote: > By the way, I talked to Alexandre about the GCOV stuff, basically he wants > us to find out why arc profiling borks the preloader. Then the idea is it > can be enabled just using CFLAGS. (You're confusing the UCLA guys with the Harvey Mudd guys, Mike!) Here's what aarvey(a)cs.hmc.edu wrote when he ran into the problem: > make[1]: Entering directory `/home/aarvey/winefromwinehqcvs/wine.patched/loader' > gcc -o wine-preloader -static -nostartfiles -nodefaultlibs -Wl,-Ttext=0x78000000 preloader.o -L../libs/port -lwine_port > preloader.o(.text+0x1929): In function `_GLOBAL__I_wld_startGCOV': > /home/aarvey/winefromwinehqcvs/wine.patched/loader/preloader.c:955: undefined reference to `__bb_init_func' > collect2: ld returned 1 exit status > make[1]: *** [wine-preloader] Error 1 > make[1]: Leaving directory > `/home/aarvey/winefromwinehqcvs/wine.patched/loader' > make: *** [loader] Error 2 > > I can compile the preloader just dandy as long as I get rid of the extra > compile flags (-ftest-coverage and -fprofile-arcs). You could provide a dummy implementation of __bb_init_func in the preloader, but that's uglier IMHO than just not passing those options when compiling the preloader. Mike also asked: > Until that happens though are you generating lcov output anywhere? Not yet, but I'll ask them to start doing periodic LCOV runs and putting them up on the web. I'd like to see this be a regular feature at winehq.org, not sure what the logistics would be. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

Re: Add new "nrelay" debug channel - useful for debugging GPFs in target applications
by Andreas Mohr 02 Mar '05

02 Mar '05

Hi, On Wed, Mar 02, 2005 at 04:09:36PM +1100, Troy Rollo wrote: > The nrelay ("native relay") debug channel acts to limit the output of the > relay debug channel, and only works if the relay debug channel is also on. > When "nrelay" is on, "relay" will not log calls made from one built-in > library to another built-in library, or within a built-in library. Thus each > call logged is a call made directly by the target application or by one of > the native DLLs it depends on. Yay!! Thanks a lot! This one is VERY important, since developer confusion by overwhelmingly big and mostly less useful relay logs in recent years has grown a lot, I'd say. One suggestion: maybe make *only* logging external relays the default, and add a wrelay channel to add back the logging of Wine inter-dll calls? This might make more sense even, since you're often not interested at all in Wine interactions, but what the target app does. Any suggestions about the average percentage where people are interested in app-only calls as opposed to a full relay log? That would then tell us which way to implement this limiting. I'm not sure about the percentage, since I haven't done much development in recent years. Andreas Mohr

2 1

Re: USER32: Sysparams unit tests fixes and additions
by Paul Vriens 02 Mar '05

02 Mar '05

On Tue, 2005-03-01 at 05:53, jchevrier(a)nexicom.net wrote: > Changelog: > > * Created SPI_{GET,SET}KEYBOARDPREF and SPI_{GET,SET}SCREENREADER unit tests > * Removed a trace that shouldn't have been there > * Add return checking to SPI_{GET,SET}WHEELSCROLLLINES and > SPI_{GET,SET}MENUSHOWDELAY unit tests so they no longer run on Windows 95 > where they aren't supported > * Changed minimum hovertime in SPI_{GET,SET}MOUSEHOVERTIME to 10 as Windows XP > defaults to 10 any value below that Hi, the extra trace was my doing :-(. I've added this and after that I realized that SPI_{GET|SET} doesn't clean the LastError after a correct call. That's why I think it's necessary to do a SetLastError(0) before every check of GetLastError. That's the reason I had these failures on win98 and SPI_GETICONTITLEWRAP. The Error was still set by one of the previous called functions (I think a ..W call, the ..A call was fine). That still leaves us with the questions, whether it would be good to check for ERROR_CALL_NOT_IMPLEMENTED after each call? Cheers, Paul Vriens.

2 1

Re: [wined3d] texture interface separation.
by Oliver Stieber 02 Mar '05

02 Mar '05

> wrote: > > > > Hi, > > > > This patch start to separate the interfaces > in > > > > wine3d3. Complete separation requires > > > queryInterface > > > > support which I'll send through soon, this > patch > > > has > > > > no dependencies but provides the final > interface > > > > needed by later revisions. > > > > > > > Hi Oliver, > > > > > > this patch couldn't be applied cleanly to CVS. > Just > > > to let you know, I > > > didn't check further. > > > > > > I'm wondering if AJ will have many comments on > the > > > patches. I hope not > > > as your work is going to make a lot of people > happy. > > It's a diff against CVS. But I think you need a diff > against CVS + your > previous patch. Or am I missing something ? > The patches aren't incremental, that way one can fail but it shouldn't affect the rest being merged. I have another couple of discrete patches to send in then the patches become dependant on some of the interface changes, but hopefully not the underlying functionality changes. I also don't have enough HDD space to keep incremental versions and check that they compile/work especially with all the interface/include changes. If anyone knows of a good tool for managing patches let me know (not cerversa!), there's a surprising lack of tools available. at the moment I'm using the following... #!/bin/bash #given a file, replace the first path with a new path #diff the two files stripedpath=$(echo $1 | grep -o "/.*") kdiff3 $1 "$2/$stripedpath"& kwrite $1 & kwrite "$2/$stripedpath"& -- diffdueo clean/wine/.... working Very 21st century. A tool for merging would be good too, e.g. merge patch1.patch patch2.patch > patch_merged.patch. if one doesn't exist I'll write it and put it on my site. Send instant messages to your online friends http://uk.messenger.yahoo.com

2 6

Re: [PATCH] Added 2 functions to shell32
by Jacek Caban 01 Mar '05

01 Mar '05

> I doubt shell32 function on windows does this check, also original windows shell32 > function is a lot more complicated and longer, I've compared the results between > real and my code and they are correct. I wrote a small test for this function showing that your implementation is almost correct. It failes in two cases: 1. If a path ends with '\' and is compared with one that doesn't, then it's length is less than the other one, but both are the same paths. 2. If a path doesn't end with '\' and is compared with a longer one that has the same first len chars, but is not the same, ex: c:\test c:\test123 Changelog: Added test for PathIsEqualOrSubFolder Index: dlls/shell32/tests/shellpath.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/tests/shellpath.c,v retrieving revision 1.6 diff -u -p -r1.6 shellpath.c --- dlls/shell32/tests/shellpath.c 10 Feb 2005 19:19:35 -0000 1.6 +++ dlls/shell32/tests/shellpath.c 28 Feb 2005 21:19:31 -0000 @@ -871,6 +871,55 @@ static void testNonExistentPath(void) userShellFolders); } +typedef BOOL (WINAPI*fnPathIsEqualOrSubFolder)(LPCWSTR path1, LPCWSTR path2); + +static void test_PathIsEqualOrSubFolder() +{ + fnPathIsEqualOrSubFolder pPathIsEqualOrSubFolder; + BOOL ret; + static const WCHAR path1[] = {'c',':','\\','t','e','s','t',0}; + static const WCHAR path2[] = {'c',':','\\','t','e','s','t','\\','t','e','s','t',0}; + static const WCHAR path3[] = {'c',':','\\','t','e','s','t','1','2','3',0}; + static const WCHAR path4[] = {'c',':','\\','t','e','s','t','\\',0}; + static const WCHAR path5[] = {'c',':','\\','t','e','s','t','\\','t','e','s','t','2', + '\\','.','.','\\','t','e','s','t',0}; + + pPathIsEqualOrSubFolder = GetProcAddress(hShell32, (LPSTR)755); + if(!pPathIsEqualOrSubFolder) + return; + +#define TEST_PATH(p1, p2, r) \ + ret = pPathIsEqualOrSubFolder(p1, p2); \ + ok(ret == r, "PathIsEqualOrSubFolder(" #p1 " " #p2 ") failed, expected: %x\n", r); + + TEST_PATH(path1, path1, TRUE); + TEST_PATH(path1, path2, TRUE); + TEST_PATH(path1, path3, FALSE); + TEST_PATH(path1, path4, TRUE); + TEST_PATH(path2, path1, FALSE); + TEST_PATH(path2, path2, TRUE); + TEST_PATH(path2, path3, FALSE); + TEST_PATH(path2, path4, FALSE); + TEST_PATH(path3, path1, FALSE); + TEST_PATH(path3, path2, FALSE); + TEST_PATH(path3, path3, TRUE); + TEST_PATH(path3, path4, FALSE); + TEST_PATH(path4, path1, TRUE); + TEST_PATH(path4, path2, TRUE); + TEST_PATH(path4, path3, FALSE); + TEST_PATH(path4, path4, TRUE); + TEST_PATH(path5, path1, FALSE); + TEST_PATH(path5, path2, FALSE); + TEST_PATH(path5, path3, FALSE); + TEST_PATH(path5, path4, FALSE); + TEST_PATH(path5, path5, TRUE); + TEST_PATH(NULL, path1, FALSE); + TEST_PATH(path1, NULL, FALSE); + TEST_PATH(NULL, NULL, FALSE); + +#undef TEST_PATH +} + START_TEST(shellpath) { if (!init()) return; @@ -892,5 +941,6 @@ START_TEST(shellpath) testWinDir(); testSystemDir(); testNonExistentPath(); + test_PathIsEqualOrSubFolder(); } }

3 2

New uninstaller
by Jonathan Ernst 01 Mar '05

01 Mar '05

As requested, I'm trying to make a new uninstaller using a dialog instead of a window. It's my first windows program and I have something working but there are still some issues. If someone could help with some of the following problems, I'd be very thanfull. 1) Strange problem with UpdateWindow uninstaller.c, line 264 I implemented a search/filter field and I want to repaint the window after each input in the EDITTEXT control. However, when I call UpdateWindow on this line, the value returned is 1 so that a WM_PAINT message should be sent right ? But strangly no message is sent and I have to make something else (like moving the dialog) to force the window to repaint and filter the entries. The funny thing is that UpdateWindow on line 279 works just fine. I guess it's a bug in my code and not in Wine so I'd be glad if you could help me. 2) Improve filter code Currently I filter the entries that match exactly the filter string. I would like to at least make a case insensitive strstr on the string. What's the best way to do it (See uninstaller.c, line 235) 3) Stringtables a)Is there a way to load localized strings without having to guess beforehand the size of the string in each language ? b)Is there a way to not call LoadString for each string ? c)Where is the best place to load every string of a stringtable ? in main(), just before calling DialogBox() ? 4) Please tell me if you see things that are bad in the attached code, so that I'll fix it before submitting a patch. Thanks you for your help

7 13

Regression in Rebar
by Maxime Bellengé 01 Mar '05

01 Mar '05

Hello This patch is causing a regression in emule, the rebar simply does not display. a+ Maxime Modified files: dlls/comctl32 : rebar.c Log message: Robert Shearman <rob(a)codeweavers.com> - Make row number be zero-based. - Improvements to dumping functions to not dump out fields that may not have been filled in.

2 4

Tools for identifying what a DLL provides?
by David D. Hagood 01 Mar '05

01 Mar '05

I have a DLL from a manufacturer that I don't have the source for, nor do I have the header or the import library for. Since Wine developers frequently have to reverse engineer what a given DLL provides, does anybody have a good recommendation for a tool that can scan the DLL and report what functions it exports, and their arg types and return types?

4 4

Re: [wined3d] texture interface separation.
by Oliver Stieber 01 Mar '05

01 Mar '05

2 1

Re: Wine cabinet.dll FDI Conformace Test Patch
by Daniel Kegel 01 Mar '05

01 Mar '05

Andreas wrote: > It's an unspoken rule that preprocessor directives (#ifdef, ...) > always start at the very beginning of a line to make sure one recognizes > immediately which parts of the code are being processed and which ones aren't. Good point. I should have caught that style violation when I reviewed their code for them this weekend. > AFAICS you're not using wine test suite infrastructure, e.g. ok() etc. > > Using printf() directly strikes me as being quite bad, too... I think they're using the wine test infrastructure properly everywhere. The only exception is the disabled self-test in tvfs.c, but I think that's fine. It's not even built, it was just used while developing the test harness. > Apart from that it appears to be very good. Cool! - Dan

2 1

Re: winedbg questions
by Pouech Eric DMI AEI CAEN 01 Mar '05

01 Mar '05

> I'm trying to use winedbg to run the direct sound regression > tests and have two questions: > > Execution stops when starting the first dsound.dll thread. Is > this normal? Is the stack trace with no symbol information > normal? no, because of this in your trace Couldn't initiate DbgHelp the only reason this fails is because dbghelp cannot get to the wine-loader in the running programm try to set the env var WINELOADER to the {pk}loader (full path) you're using and check again A+

1 0

winedbg questions
by Robert Reif 01 Mar '05

01 Mar '05

I'm trying to use winedbg to run the direct sound regression tests and have two questions: Execution stops when starting the first dsound.dll thread. Is this normal? Is the stack trace with no symbol information normal? Typing c continues to the exception I am interested in but the stack trace has no symbolic information. This is with a modified dsound.dll that does zeroing of memory before freeing. An unmodified dsound.dll stops at the start but does not get the second exception. This is with a standard RH9 with up to date erratas and this mornings cvs. typescript log attached. Why is winedbg stopping at the first thread creation? Why is there no symbolic stack information? [wine@dell tests]$ WINEDEBUG=+wave,+dsound,+tid winedbg "dsound_test.exe.so dsound" WineDbg starting on pid 0xa Couldn't initiate DbgHelp 000b:trace:wave:OSS_WaveInit () 000b:trace:wave:OSS_WaveOutInit (0x41765960) /dev/dsp 000b:trace:wave:OSS_OpenDevice (0x41765960,1,(nil),0,-1,-1,ffffffff) ... 000b:warn:wave:OSS_RawOpenDevice Couldn't open /dev/dsp5 (No such device) 000b:trace:wave:OSS_widMessage (0, DRVM_INIT, 00000000, 00000000, 00000000); 000b:trace:wave:OSS_widMessage (0, WIDM_GETNUMDEVS, 00000000, 00000000, 00000000); 000b:trace:wave:OSS_wodMessage (0, DRVM_INIT, 00000000, 00000000, 00000000); 000b:trace:wave:OSS_wodMessage (0, WODM_GETNUMDEVS, 00000000, 00000000, 00000000); 000b:trace:dsound:DllMain (0x40870000 0x1 0x1) 000b:trace:dsound:DllMain DLL_PROCESS_ATTACH 000f:trace:dsound:DllMain (0x40870000 0x2 (nil)) 000f:trace:dsound:DllMain DLL_THREAD_ATTACH In 32 bit mode. 0x40471f77: pushl %esi Wine-dbg>bt Backtrace: =>1 0x40471f77 (0x4085fff4) 2 0x400298f5 (0x00000000) Wine-dbg>c dsound.c:167:Testing IDirectSound 000b:trace:dsound:DSOUND_DllGetClassObject ({47d4d946-62e8-11cf-93bc-444553540000},{00000001-0000-0000-c000-000000000046},0x4085fe30) 000b:trace:dsound:DSCF_AddRef (0x408a586c) ref was 1 000b:trace:dsound:DSCF_CreateInstance (0x408a586c)->((nil),{279afa83-4981-11ce-a521-0020af0be560},0x4085fe6c) 000b:trace:dsound:DSOUND_Create ((null),0x4085fe6c,(nil)) ... 000b:trace:wave:wodOpen OSS_OpenDevice returned this format: 22050x8x2 000b:trace:wave:wodOpen got 32 2048 byte fragments (46 ms/fragment) 000b:trace:wave:wodOpen fd=16 fragstotal=32 fragsize=2048 BufferSize=65536 001a:trace:wave:wodPlayer_ProcessMessages calling ExitThread() 001a:trace:dsound:DllMain (0x40870000 0x3 (nil)) 001a:trace:dsound:DllMain DLL_THREAD_DETACH First chance exception: page fault on read access to 0x00000000 in 32-bit code (0x401a0d88). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0033 GS:005f EIP:401a0d88 ESP:419d4528 EBP:419d4540 EFLAGS:00210293( - 00 RISA1C) EAX:00000008 EBX:401d63c4 ECX:00000001 EDX:402f0038 ESI:00000000 EDI:00010000 Stack dump: 0x419d4528: 00000000 00000000 00000000 401d63c4 0x419d4538: 402f0000 00010000 419d456c 401a1819 0x419d4548: 402f0000 00010000 419d455c 00000000 0x419d4558: 402f0000 00000000 405036c8 00010000 0x419d4568: 00000000 419d4584 40457b3a 402f0000 0x419d4578: 00000002 00010000 405036c8 419d45b0 Backtrace: =>1 0x401a0d88 (0x419d4540) 2 0x401a1819 (0x419d456c) 3 0x40457b3a (0x419d4584) 4 0x404561d7 (0x419d45b0) 5 0x404562bd (0x419d45d0) 6 0x404918f5 (0x419d45e4) 7 0x4045ace9 (0x419d45fc) 8 0x4045b07b (0x419d4608) 9 0x4043a0e8 (0x419d4638) 10 0x401a2c9a (0x419d4650) 11 0x401a3dd3 (0x419d46c0) 12 0x401a41a3 (0x419d46e8) 13 0x40486c8f (0x419d47b8) 14 0x401ba077 (0x419d4ff4) 15 0x401116c7 (0x00000000) 0x401a0d88: movl 0x0(%esi),%eax Wine-dbg>q WineDbg terminated on pid 0xa

1 0

Re: wine/dlls/comctl32 status.c
by Thomas Weidenmueller 01 Mar '05

01 Mar '05

Alexandre Julliard wrote: >Log message: > Filip Navara <navaraf(a)reactos.com> > Implement SB_SETBORDERS. > > Just FYI: Win95, 98, 98SE, ME, NT4, NT5.0, NT5.1 and later do not support this message even though MS Office might try to use them. Best Regards, Thomas

1 0

Re: Patch for wsock32 conformance test
by Alexandre Julliard 01 Mar '05

01 Mar '05

Thomas Kho <thomaskho(a)gmail.com> writes: > We're working on a set of tests for wsock32.dll with guidance from Dan > Kegel. So far we've > completed a test of blocking network I/O with multiple threads. > Attached is a patch from our efforts. We look forward to suggestions. This stuff should be merged with the other winsock tests in dlls/winsock/tests/sock.c (assuming it does something that the current tests don't, I haven't checked this). There is no point in having duplicate tests for wsock32 since it just forwards everything to ws2_32. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [programs/regedit] Use Favorit* instead of Favourit*
by Robert Shearman 01 Mar '05

01 Mar '05

Paul Vriens wrote: >Hi, > >Our regedit displays Favourites in the menu. This patch changes that to >use Favorites. The patch also changes the variables with FAVOURITE in >the name. The reasoning is: > >a. Windows uses Favorite(s) all over the place. >b. We do too. > >That's the only reasoning and not if either one is better (UK/US etc..) > >No functional changes btw. > >Changelog > Change Favourite(s) into Favorite(s) > > Fair enough for strings in the English, US resources, as long as the strings in the English, Neutral resources are still spelt correctly. > Change variables containing FAVOURITE into FAVORITE > > Why do this? Rob

2 1

Crash in Polar Precision Performance Software
by Ron Jensen 28 Feb '05

28 Feb '05

Hello, This trace is from Polar's Precision Performance Software http://www.codeweavers.com/site/compatibility/browse/name?app_id=681 running on CVS wine. This crash happens with CVS wine, and wine I compiled from http://ftp.codeweavers.com/pub/crossover/office/source/office-src-4.1.0.tgz It does not happen with the precompiled binaries in CXOffice's Loki installer. Can someone give me a clue as to were to start looking to fix this? Thanks. /*******/ wineuser$wine 'C:\Program Files\Polar\Polar 32.exe' fixme:gdi:Escape16 unknown/unsupported 16-bit escape c03 (56,0x403815de,0x40381626 fixme:gdi:Escape16 unknown/unsupported 16-bit escape c03 (56,0x403815de,0x40381626 wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0xa84c73e0 in 32-bit code (0x00415809). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:00415809 ESP:4069e63c EBP:4069e6c4 EFLAGS:00010282( - 00 - RIS1) EAX:00000000 EBX:4082f8d4 ECX:a84c73e0 EDX:000004e7 ESI:4069f3f0 EDI:00020040 Stack dump: 0x4069e63c: 00414e23 4069f3f0 000004e7 00020040 0x4069e64c: 4069f3f0 4069e6c4 4082f8d4 004144c9 0x4069e65c: 00020040 4069f3f0 000004e7 0052c3ec 0x4069e66c: 00020040 00000638 00020040 000000a0 0x4069e67c: 00020040 408517a8 4069e6c4 4082f8d4 0x4069e68c: 403d6a28 403d6980 00000000 4007aa04 Backtrace: =>1 0x00415809 in polar 32 (+0x15809) (0x4069e6c4) 2 0x407ae6c0 WINPROC_CallWndProc+0x70(msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069e700) 3 0x407b393e CallWindowProcA+0xfe(func=0x408517a8, hwnd=0x20040, msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:2940] in user32 (0x4069e72c) 4 0x4078ff36 DefDlgProcA(hwnd=0x20040, msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/defdlg.c:453] in user32 (0x4069e75c) 5 0x407ae277 WINPROC_wrapper+0x17 in user32 (0x4069e780) 6 0x407ae6c0 WINPROC_CallWndProc+0x70(msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069e7bc) 7 0x407b3be4 CallWindowProcW+0x184(func=0x4085145a, hwnd=0x20040, msg=0x4e, wParam=0x0, lParam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:3053] in user32 (0x4069eca0) 8 0x407e1d13 call_window_proc+0xc3(wparam=0x0, lparam=0x4069edf0, unicode=0x1, same_thread=0x1) [/home/wineuser/src/wine/dlls/user/message.c:1475] in user32 (0x4069ed00) 9 0x407e1eef SendMessageTimeoutW+0x14f(hwnd=0x20040, msg=0x4e, wparam=0x0, lparam=0x4069edf0, flags=0x0, timeout=0xffffffff, res_ptr=0x4069ed80) [/home/wineuser/src/wine/dlls/user/message.c:1989] in user32 (0x4069ed5c) 10 0x407e1f35 SendMessageW(hwnd=0x20040, msg=0x4e, wparam=0x0, lparam=0x4069edf0) [/home/wineuser/src/wine/dlls/user/message.c:2070] in user32 (0x4069ed88) 11 0x406eee3b PROPSHEET_SetCurSel(skipdir=0x1, hpage=0x403e2cd0) [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:2102] in comctl32 (0x4069ee0c) 12 0x406f26c4 PROPSHEET_DialogProc(hwnd=0x4002e, uMsg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:3379] in comctl32 (0x4069f3f0) 13 0x407ae277 WINPROC_wrapper in user32 (0x4069f414) 14 0x407ae6c0 WINPROC_CallWndProc(msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069f450) 15 0x407b393e CallWindowProcA+0xfe(func=0x40851794, hwnd=0x4002e, msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:2940] in user32 (0x4069f47c) 16 0x4078ff36 DefDlgProcA(hwnd=0x4002e, msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/defdlg.c:453] in user32 (0x4069f4ac) 17 0x407ae277 WINPROC_wrapper+0x17 in user32 (0x4069f4d0) 18 0x407ae6c0 WINPROC_CallWndProc+0x70(msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:419] in user32 (0x4069f50c) 19 0x407b3be4 CallWindowProcW+0x184(func=0x4085145a, hwnd=0x4002e, msg=0x110, wParam=0x0, lParam=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/winproc.c:3053] in user32 (0x4069f9f0) 20 0x407e1d13 call_window_proc+0xc3(wparam=0x0, lparam=0x403e2328, unicode=0x1, same_thread=0x1) [/home/wineuser/src/wine/dlls/user/message.c:1475] in user32 (0x4069fa50) 21 0x407e1eef SendMessageTimeoutW+0x14f(hwnd=0x4002e, msg=0x110, wparam=0x0, lparam=0x403e2328, flags=0x0, timeout=0xffffffff, res_ptr=0x4069fad0) [/home/wineuser/src/wine/dlls/user/message.c:1989] in user32 (0x4069faac) 22 0x407e1f35 SendMessageW(hwnd=0x4002e, msg=0x110, wparam=0x0, lparam=0x403e2328) [/home/wineuser/src/wine/dlls/user/message.c:2070] in user32 (0x4069fad8) 23 0x4079427e DIALOG_CreateIndirect(owner=0x1004e, dlgProc=0x406f1780, param=0x403e2328, unicode=0x0, modal=0x1) [/home/wineuser/src/wine/dlls/user/../../windows/dialog.c:667] in user32 (0x4069fbe4) 24 0x407946d9 DialogBoxIndirectParamAorW+0x39(hInstance=0x400000, template=0x403e17a8, owner=0x1004e, dlgProc=0x406f1780, param=0x403e2328, flags=0x2) [/home/wineuser/src/wine/dlls/user/../../windows/dialog.c:841] in user32 (0x4069fc08) 25 0x4079476b DialogBoxIndirectParamA(hInstance=0x400000, template=0x403e17a8, owner=0x1004e, dlgProc=0x406f1780, param=0x403e2328) [/home/wineuser/src/wine/dlls/user/../../windows/dialog.c:852] in user32 (0x4069fc2c) 26 0x406edb53 PROPSHEET_CreateDialog [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:729] in comctl32 (0x4069fc5c) 27 0x406f0961 PropertySheetA+0x2d1(lppsh=0x4069fca4) [/home/wineuser/src/wine/dlls/comctl32/propsheet.c:2794] in comctl32 (0x4069fc80) 28 0x00414354 in polar 32 (+0x14354) (0x00000111) 29 0x00000000 (0x00000000) 0x00415809: cmpl %edx,0x0(%ecx) Wine-dbg>quit WineDbg terminated on pid 0x8

2 2

Help with winebuild/winegcc
by Ivan Leo Puoti 28 Feb '05

28 Feb '05

Hello, I'm trying to get a program in the programs/ directory to export symbols, I've added -shared path/to/spec/spec.c to the linker command, but I now get a segmentation fault at startup. Can someone knowledgeable about winegcc/winebuild give me a suggestion/solution? I'm really stuck because of this and can't get on with safedisc support. Ivan.

1 0

Re: Implements OleLoadPicturePath
by Robert Shearman 28 Feb '05

28 Feb '05

Maxime Bellengé wrote: >Hello, here is an implementation of OleLoadPicturePath. >The filename can be either a local file or an url. >In case of a url, I needed a user-agent for wininet. I put a dummy value >as I didn't find a default wine value. Is there a default value >somewhere for the whole project ? > >a+ > >Max > >ChangeLog: > * Implements OleLoadPicturePath > > > >------------------------------------------------------------------------ > >Index: wine/dlls/oleaut32/olepicture.c >=================================================================== >RCS file: /home/wine/wine/dlls/oleaut32/olepicture.c,v >retrieving revision 1.55 >diff -u -r1.55 olepicture.c >--- wine/dlls/oleaut32/olepicture.c 25 Feb 2005 14:07:57 -0000 1.55 >+++ wine/dlls/oleaut32/olepicture.c 27 Feb 2005 10:51:43 -0000 >@@ -71,7 +71,9 @@ > #include "olectl.h" > #include "oleauto.h" > #include "connpt.h" >+#include "wininet.h" > #include "wine/debug.h" >+#include "wine/unicode.h" > > #include "wine/wingdi16.h" > #include "cursoricon.h" >@@ -1998,11 +2000,122 @@ > DWORD dwReserved, OLE_COLOR clrReserved, REFIID riid, > LPVOID *ppvRet ) > { >- FIXME("(%s,%p,%ld,%08lx,%s,%p): stub\n", >+ static const WCHAR file[] = { 'f','i','l','e',':','/','/',0 }; >+ static const WCHAR name[] = { 'w','i','n','e','-','a','g','e','n','t',0}; >+ IPicture *ipicture; >+ HANDLE hFile; >+ DWORD dwFileSize; >+ HGLOBAL hGlobal = NULL; >+ DWORD dwBytesRead = 0; >+ IStream *stream; >+ BOOL bRead; >+ IPersistStream *pStream; >+ HRESULT hRes; >+ >+ TRACE("(%s,%p,%ld,%08lx,%s,%p): stub\n", > debugstr_w(szURLorPath), punkCaller, dwReserved, clrReserved, > debugstr_guid(riid), ppvRet); > >- return E_NOTIMPL; >+ if (!ppvRet) return E_POINTER; >+ >+ if (strncmpW(szURLorPath, file, 7) == 0) { >+ szURLorPath += 7; >+ >+ hFile = CreateFileW(szURLorPath, GENERIC_READ, 0, NULL, OPEN_EXISTING, >+ 0, NULL); >+ if (hFile == INVALID_HANDLE_VALUE) >+ return E_UNEXPECTED; >+ >+ dwFileSize = GetFileSize(hFile, NULL); >+ if (dwFileSize != INVALID_FILE_SIZE ) >+ { >+ hGlobal = GlobalAlloc(GMEM_FIXED,dwFileSize); >+ if ( hGlobal) >+ { >+ bRead = ReadFile(hFile, hGlobal, dwFileSize, &dwBytesRead, NULL); >+ if (!bRead) >+ { >+ GlobalFree(hGlobal); >+ hGlobal = 0; >+ } >+ } >+ } >+ CloseHandle(hFile); >+ } else { >+ HINTERNET hInternet; >+ BOOL res = FALSE; >+ >+ hInternet = InternetOpenW(name, INTERNET_OPEN_TYPE_PRECONFIG, NULL, >+ NULL, 0); >+ if (hInternet) >+ { >+ HINTERNET hFile; >+ hFile = InternetOpenUrlW(hInternet, szURLorPath, NULL, -1L, >+ INTERNET_FLAG_RESYNCHRONIZE, (DWORD_PTR)NULL); >+ if (hFile) >+ { >+ DWORD total = 4096; >+ DWORD nbRead; >+ >+ hGlobal = GlobalAlloc(GMEM_FIXED, 4096); >+ if (hGlobal) >+ { >+ do { >+ res = InternetReadFile(hFile, hGlobal, 4096, &nbRead); >+ if (res && (nbRead>0)) >+ { >+ HGLOBAL hNewGlobal; >+ hNewGlobal = GlobalReAlloc(hGlobal, total+4096, 0); >+ if (!hNewGlobal) >+ { >+ res = FALSE; >+ break; >+ } >+ } >+ } while (res && (nbRead>0)); >+ } >+ } >+ >+ InternetCloseHandle(hInternet); >+ } >+ if (!res) >+ { >+ GlobalFree(hGlobal); >+ } >+ } >+ >+ if (!hGlobal) >+ return E_UNEXPECTED; >+ >+ hRes = CreateStreamOnHGlobal(hGlobal, TRUE, &stream); >+ if (FAILED(hRes)) >+ { >+ if (stream != NULL) IStream_Release(stream); > > A valid stream will not be returned on failure, so no need for the extra check here. >+ GlobalFree(hGlobal); >+ return hRes; >+ } >+ >+ hRes = CoCreateInstance(&CLSID_StdPicture, punkCaller, CLSCTX_INPROC_SERVER, >+ &IID_IPicture, (LPVOID*)&ipicture); >+ if (hRes != S_OK) { > > Lack of cleanup code here. >+ return hRes; >+ } >+ >+ hRes = IPicture_QueryInterface(ipicture, &IID_IPersistStream, (LPVOID*)&pStream); >+ if (hRes) { >+ IPicture_Release(ipicture); > > And here. >+ return hRes; >+ } >+ >+ IPersistStream_Load(pStream, stream); > > You should probably check the return value from this function as it is kinda vital to the function you are implementing. >+ IPersistStream_Release(pStream); >+ IStream_Release(stream); >+ hRes = IPicture_QueryInterface(ipicture,riid,ppvRet); >+ if (hRes) >+ FIXME("Failed to get interface %s from IPicture.\n",debugstr_guid(riid)); >+ >+ IPicture_Release(ipicture); >+ return hRes; > } > > /******************************************************************************* > > >Index: wine/dlls/oleaut32/Makefile.in >=================================================================== >RCS file: /home/wine/wine/dlls/oleaut32/Makefile.in,v >retrieving revision 1.57 >diff -u -r1.57 Makefile.in >--- wine/dlls/oleaut32/Makefile.in 27 Oct 2004 00:47:53 -0000 1.57 >+++ wine/dlls/oleaut32/Makefile.in 27 Feb 2005 10:52:08 -0000 >@@ -4,7 +4,7 @@ > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = oleaut32.dll >-IMPORTS = ole32 rpcrt4 user32 gdi32 advapi32 kernel32 ntdll >+IMPORTS = ole32 rpcrt4 user32 gdi32 advapi32 kernel32 ntdll wininet > DELAYIMPORTS = comctl32 > EXTRALIBS = $(LIBUNICODE) -luuid > > I don't think oleaut32 should be importing from wininet for just the implementation of OleLoadPicturePath. It surprises me that there is not already an implementation of IStream for URLs that can be re-used. If there is no alternative, I think we should just make wininet a delayed import. Rob

2 1

Re: [QUARTZ] Handle End Of Stream notifications
by Robert Shearman 28 Feb '05

28 Feb '05

Christian Costa wrote: >Index: dlls/quartz/dsoundrender.c >=================================================================== >RCS file: /home/wine/wine/dlls/quartz/dsoundrender.c,v >retrieving revision 1.6 >diff -u -r1.6 dsoundrender.c >--- dlls/quartz/dsoundrender.c 6 Jan 2005 19:36:47 -0000 1.6 >+++ dlls/quartz/dsoundrender.c 27 Feb 2005 20:48:17 -0000 >@@ -550,8 +550,8 @@ > > static HRESULT WINAPI DSoundRender_JoinFilterGraph(IBaseFilter * iface, IFilterGraph *pGraph, LPCWSTR pName) > { >- HRESULT hr; > DSoundRenderImpl *This = (DSoundRenderImpl *)iface; >+ HRESULT hr = S_OK; > > TRACE("(%p/%p)->(%p, %s)\n", This, iface, pGraph, debugstr_w(pName)); > >@@ -563,7 +563,14 @@ > *This->filterInfo.achName = '\0'; > This->filterInfo.pGraph = pGraph; /* NOTE: do NOT increase ref. count */ > >- hr = IFilterGraph_QueryInterface(pGraph, &IID_IMediaEventSink, (LPVOID*)&This->pEventSink); >+ This->pEventSink = NULL; >+ if (pGraph) >+ { >+ /* Cache IMediaEventSink interface w/o increasing filtergraph refcount */ > > I appreciate that this works perfectly fine at the moment, but these kind of assumptions can lead to difficult to track memory corruptions, so it would be best to avoid caching the object here and querying for it when it's needed. >+ hr = IFilterGraph_QueryInterface(pGraph, &IID_IMediaEventSink, (LPVOID*)&This->pEventSink); >+ if (SUCCEEDED(hr)) >+ IMediaEventSink_Release(This->pEventSink); >+ } > } > LeaveCriticalSection(&This->csFilter); > > Rob

1 0

[SOLVED] Re: Picasa2- works great, one font issue
by Matthew Mastracci 28 Feb '05

28 Feb '05

Okay - I checked out the latest Wine from CVS and it seems to be fixed. I think this patch was the one that fixed it: revision 1.82 date: 2005/02/25 13:59:22; author: julliard; state: Exp; lines: +9 -9 TANABE Hiroshi <hirokun_dayomon(a)infoseek.to> wrote: Remove (buf && !buflen) checking. Fixed outline rendering with GGO_GRAY?_BITMAP option. Improved fixed-pitch fonts detection. Here's some screenshots from the program while running: http://www.grack.com/news/Picasa2underWine.html Note that clicking the "email" button in Picasa will crash it - probably the MAPI stubs that cause it: err:mapi:MAPILogon Stub fixme:seh:EXC_RtlRaiseException call (from 0x53e297) to unimplemented function mapi32.dll.MAPISendMail Thanks, Matt. Matthew Mastracci wrote: > I tried out the latest Picasa2 (picasa2-setup-1884.exe) on a whim > against the Wine 20050111 package and it works great. There don't > seem to be any major functionality issues and the app is very > responsive - it almost feels like a native gnome app. > > The one visual issue with the program is that certain fonts within the > program seem to be blitted incorrectly: > > http://www.grack.com/news/Picasa2underWine.html > > It appears that Picasa 2 might ship with some pre-computed > alpha-blended fonts in the form of ".ytf" files in the runtime > directory. When I move these fonts out of the way, all the fonts > (including those fonts used to create the > Import/Slideshow/Timeline/etc. buttons) within the program appear > screwed up like the album-title fonts do when those files are > present. Note that after copying the generated .ytf files from a > Windows '98 installation, all of the characters within Picasa are > rendered perfectly. > > Where might I start looking for the problem? I think it has something > to do with drawing to backbuffer that eventually gets flushed to disk, > since copying the cached font files from a standard Windows install > seems to fix the problem. WINEDEBUG=+gdi doesn't yield much, but I > think WINEDEBUG=+bitmap or WINEDEBUG=+font is where I'm supposed to be > looking. > > Matt. >

2 1

OpenGL _client regression with ATI.
by Oliver Stieber 28 Feb '05

28 Feb '05

Hi, after the whole _client, _window changes for VisualID's DirectX started displaying a bit of garbage at the top of the screen, which I toughed was because the window frames weren't taken into account in the view-port. This is sort of what's happening but it's worse. When I'm using ATI's driver, the viewport comes up as the whole screen, so as I move the window from the top left of my desktop so the clipping changes. It also affects non-DirectX stuff, e.g. with a desktop set in ~/.wine/config some windows come up centred as if the whole screen is taken into account and not just the desktop view, and sometimes a window that should be a given size resizes to the whole screen. With mesa the openGL problems don't appear. I haven't had any problems with any other openGL applications so I can only assume that it's a problem in wine. Send instant messages to your online friends http://uk.messenger.yahoo.com

1 0

Patch 16316 causes regression in Irfan View
by Ron Jensen 28 Feb '05

28 Feb '05

Patch 16316 causes regression in Irfan View. When I attempt to put Irfan View ( http://appdb.winehq.org/appview.php?appId=163 ) into slide show mode (Menu: File -> Slideshow, add some files and Play) Irfan View locks up and needs a control-c at the console to kill it. I will investigate further tomorrow... ChangeSet ID: 16316 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2005/02/24 13:42:08 Modified files: dlls/user : painting.c Log message: Repaint the non-client area to work around broken WM_PAINT handlers also when doing a synchronous update with RDW_UPDATENOW. Patch: http://cvs.winehq.org/patch.py?id=16316 Old revision New revision Changes Path 1.19 1.20 +19 -3 wine/dlls/user/painting.c ________________________________________________________________________

1 0

dsound questions
by Jeremy White 28 Feb '05

28 Feb '05

Okay, So I'm trying to clean up dsound before I make it run properly in different scheduling conditions, and I'm having a heck of a time with it; hoping for some advice/thoughts. First, I encountered two glitches in dsound/mixer.c that appear to be bugs, but I do not understand the code well enough to be sure. The attached diff addresses both. Case 1: In the first case, in DSOUND_MixOne, we compute a 'probably_valid_to' based on the 'write_pos', which seems quite wrong; I believe the logic should be testing whether or not there is sufficient data in the mixing buffer, not whether or not there is sufficient room in the buffer overall. Case 2: In DSOUND_PerformMix, I found that on my sound card, I frequently hit cases where 'inq' (afaict, amount mixed but yet to be played) was higher than the computed value of 'maxq' (maximum amount we're supposed to write). At best, the calculations for 'maxq' need to be corrected, and perhaps coupled directly to the code that limits the data. At worst, I suspect the entire block of code could be removed, but I know way too little to be sure. Then, to my great joy, I found two separate apparent OSS bugs on two different systems. In one, the result of DSP_GETOPTR would temporarily 'go backwards' when doing mmaped transfers; in the other, my laptop would just stop reading data out of an mmapped buffer, for no apparent reason. Questions: 1) Is there a good set of OSS test programs (particularly for mmap) I could/should use to simply validate that my system is rational wrt OSS? 2) Are the performance gains from DMA mmap really worthwhile? I wonder if mmap mode is buggy and if we wouldn't be better off swtiching to a pure 'write' approach. I'd appreciate any thoughts/feedback/wacks with a clue bat. Cheers, Jeremy

2 3

Wine cabinet.dll FDI Conformace Test Patch
by Rizwan Kassim 28 Feb '05

28 Feb '05

Folks, Aleksandr Liber and I have put together a set of tests for cabinet.dll. Before we submit them to wine-patches, can anyone offer any critiques/input? We plan to submit in a day or two. We're 4th+ year undergraduate students at the UCLA Computer Science program. We're among a group of students doing conformance tests as part of a software engineering course - more info can be found at http://www.geekymedia.com/wine Any advice you can offer will be greatly appreciated! -- Thank you, Rizwan Kassim ***** Patch message follows ***** Wine cabinet.dll FDI Conformace Test Patch (gzipped) Raw files available at : http://www.geekymedia.com/viewcvs/cgi/viewcvs.cgi/group3/wine/ This patch adds tests for the cabinet dll, specifically testing the functions FDICreate, FDIDestroy, FDICopy and FDIIsCabinet. As the FCI functions are still marked TODO in wine, they haven't been tested. The package is self containing, allowing additional cabinet features to be tested by preparing other cabinets in the same manner that ours were. A patch of -p1 will be needed. Changelog:' * configure.ac added dlls/cabinet/tests/Makefile to be generated * dlls/cabinet/Makefile.in added subdirectory reference * dlls/cabinet/tests/Makefile.in standard Makefile.in for tests * dlls/cabinet/tests/cabinet_fdi.c actual test code for FDICreate, FDIDestroy, FDIIsCabinet, FDICopy * dlls/cabinet/tests/data.h contains hex representations of the two test cabinets * dlls/cabinet/tests/tvfs.h * dlls/cabinet/tests/tvfs.c Trivial Virtual File System emulating _read, _write, _open, _lseek and _close * dlls/cabinet/tests/genfiles.sh Cabinet/data.h creation script used for simple.cab and complex.cab- current tests * tools/chexify.pl converts input files to C style arrays Signed-off-by: Rizwan Kassim <rizwank(a)geekymedia.com> Signed-off-by: Dan Kegel <dank(a)kegel.com> Signed-off-by: Aleksandr Liber <aliber(a)ucla.edu>

2 1

Use of Favourite instead a Favorite in our regedit
by Paul Vriens 28 Feb '05

28 Feb '05

Hi, while looking through some registries (via regedit) on several windows versions and Wine, I saw that we use Favourites/Favourite etc.. instead of Favorites/Favorite in our regedit implementation. Is this deliberate or should I create a patch for this? The patch will also change ID_FAVOURITES_MENU, ID_FAVOURITES_ADDTOFAVOURITES,ID_FAVOURITES_REMOVEFAVOURITE. I know it's not a functional change, but hey, one has to be busy. Cheers, Paul

1 0

Re: WIDL - Sync to ReactOS 20050227
by Steven Edwards 28 Feb '05

28 Feb '05

--- Steven Edwards <steven_ed4153(a)yahoo.com> wrote: > Changelog: > Eric Kohl <eric.kohl(a)t-online.de> > > Server stubs are void functions. > Fix a warning in the server stub descriptor. > Support multiple interfaces per idl file. > Support explicit binding handles. > Support remaining basic types (float, double, small, wchar_t and handle_t). I forgot to rebuild my whole tree after this patch and am getting a error so hold off. steven@steven:/usr/src/wine/dlls/ole32# ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLE32_ -DCOM_NO_WINDOWS_H -h -H dcom.h dcom.idl error: ResolveOxid() must not define a binding handle! Thanks Steven __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 1

free fonts
by Brian Vincent 28 Feb '05

28 Feb '05

The issue of fonts came up a while ago and I know some people are working on free replacements for some of the core fonts. Anyway, I stumbled on this resource tonight with a huge listing of fonts: http://cgm.cs.mcgill.ca/~luc/originalfonts.html Seems like there's got to be a few decent ones in there the authors would be willing to let us use and relicense. -Brian

1 0

Re: [PATCH] Added 2 functions to shell32
by Dmitry Timoshkov 28 Feb '05

28 Feb '05

"Gianluigi Tiesi" <sherpya(a)netfarm.it> wrote: > +BOOL WINAPI PathIsEqualOrSubFolder(LPCWSTR path1, LPCWSTR path2) > +{ > + int i; > + int len; > + if (!path1 || !path2) return FALSE; > + > + len = strlenW(path1); > + if (len > strlenW(path2)) return FALSE; > + > + for (i=0; i < len; i++) > + if (path1[i] != path2[i]) return FALSE; > + return TRUE; > +} You need to do a case insensitive comparison of paths. Also, if you could use a usual for Wine formatting style with 4 space indentation that would be very nice. -- Dmitry.

2 1

Re: comctl32 - SB_SETBORDERS
by Thomas Weidenmueller 28 Feb '05

28 Feb '05

Steven Edwards wrote: >Filip implemented this for me when I was testing Office97 under ReactOS and I never got around to >merging it to the ros tree. > > SB_SETBORDERS does not exist in current versions of NT. It might be a something from the old 3.x days. NT 5.0 and 5.1 for sure don't implement them. Even though Office tries to use them I oppose implementing it. Best Regards, Thomas

2 2

status of winetest.exe
by Stefan Leichter 28 Feb '05

28 Feb '05

Hello Paul, i have noticed that the winetest are not longer built since the middle of the week. Can you take a look if something is broken? Thanks Stefan

2 1

Re: shell32: formatting and unicodification
by Alexandre Julliard 27 Feb '05

27 Feb '05

Juan Lang <juan_lang(a)yahoo.com> writes: > Mike's formatting changes got in, so here's one of my own. > > ChangeLog: convert tabs to spaces, make indenting consistent, convert more > calls to Unicode Please don't mix formatting changes with other things, it makes it very painful to review. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: setupapi: enumerate serial ports
by Alexandre Julliard 27 Feb '05

27 Feb '05

Juan Lang <juan_lang(a)yahoo.com> writes: > + /* FIXME: it should be possible for more than four COM ports to exist, not > + * sure why we retain that limit, but winspool does too so go with it. > + */ > + for (i = 0, ret = 0; i < 4; i++) > + { > + if (SETUP_SerialPortExists(i)) > + ret++; > + } There's no reason to limit to 4 serial ports (and winspool should be fixed too). Probably the best way is to do a QueryDosDevice(NULL) which gets you a full device list and the return every COM device in that list. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fix a race condtition in the server startup
by Bill Medland 27 Feb '05

27 Feb '05

On February 26, 2005 03:43 pm, Francois Gouget wrote: > There is a race condition in the server startup code which arises if two > I propose the following fix: > > if (lstat( name, st ) == -1) > { > if (errno != ENOENT) fatal_perror( "lstat %s", name ); > if (mkdir( name, 0700 ) == -1 && errno != EEXIST) fatal_perror( > "mkdir %s", name ); > > Using the existing directory is ok because we then check its ownership, > permissions, etc. (which we have to do anyway in case it already existed). How about simply mkdir and if the error is already existed then fine.? Unchecked, but something like: if (mkdir (name, 0700) == -1) { if (errno != EEXIST) fatal_perror ("Ensuring directory %s", name) } > > > Changelog: > > * server/request.c > > Francois Gouget <fgouget(a)codeweavers.com> > Fix a race condition in create_dir(). -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

1 0

riched20 patch preview
by Krzysztof Foltman 27 Feb '05

27 Feb '05

I've finally managed to make my riched20 code usable (hardly) and compatible with Wine. It's probably not good enough to go to CVS, but, at least, it's something you can try out. Comments are welcome. It should work with all programs that load RICHED20.DLL directly. For programs that load RICHED32.DLL you need a native version of that DLL (which is a wrapper for RICHED20.DLL, providing compatibility with 1.0 version of the control, the most important thing it does is loading RICHED20.DLL, which registers 2.0 window classes). http://foltman.com/riched20.tar.gz http://foltman.com/richeditpatch.diff Note, that EM_STREAMIN and EM_STREAMOUT don't work, so if your program uses RTF to insert text to the control, it won't work ! WinXP WordPad doesn't work either, as it uses RICHEDIT50W window class (what I provide is RichEdit20W control, haven't tried to fake it's 5.0). Have fun! Krzysztof

1 1

Re: vartest.c - major pain in the build process
by Dmitry Timoshkov 27 Feb '05

27 Feb '05

"Krzysztof Foltman" <kfoltman(a)portal.onet.pl> wrote: > > Well, I'd argue that compilation time of full Wine tree is much longer > > than that single test. If you compile from source it's your choice. > > It's still an important percentage of the total compile time. And it's > not always possible to use binaries - particularly I'm not the best > candidate for that option, being a Wine hacker ;-) Then perhaps it's better to upgrade your hw/compiler/etc, or somehow schedule your development time to compile Wine while you are doing something else. > > Even more drastic route to go is to go and complain to gcc people, > > that's certainly not a Wine fault. > > Well, almost no other program triggers this misbehaviour, so it might be > useful to work around that bug. It's a very dubious statement. I'm certain that this is not a Wine bug since compiling that code with MSVC compiler works several times faster. > Or disable the test by default > completely. It could save hundreds of users from hours of wasted time. Ordinary users are not supposed to compile the code intented for developers only. > Looks like a pragmatic solution. It's not Wine's fault, but it's not the > user's fault either, so why punish him for gcc bugs if it's not necessary? Sure, that's why we have already compiled binaries for download. > It's a bit awkward to require everyone to upgrade a monster like gcc in > order to speed up a several minute long (10 minutes and more) > compilation of the module that has little use for most users and even > developers. Then just disable the code you don't want to compile in your tree before building Wine. Just do it locally, and not ask everybody to follow your preferences. -- Dmitry.

1 0

Problem using winelib to compile Std Lib strings
by Rob D 27 Feb '05

27 Feb '05

Ive undertaken the task of converting 2 rather large Win32 applications to run on Solaris 10. I have managed to tweak nearly all of the files so they will compile with wine after running winemaker. The files I cant seem to compile are ones that use std string. I get a few errors like the following: error: ::div has not been declared error: ::ldiv has not been declared And tons about /usr/include/pthread.h like the following: error: uintptr_t does not name a type error: caddr_t has not been declared error: caddr_t does not name a type error: pthread_attr_t was not declared in this scope The files in question have lines like the following: #include <string> using namespace std; Ive tried including various additional header files like <sys/types.h> and <dtrace/h>, with varying success, but still approx 200 errors when trying to compile these files. The error lines say they are from include/c++/3.4.2, so Im assuming that it is using the 3.4.2 compiler as opposed to the 2.95 one also installed on these machines. The development Ive been tasked with will move several people off of winblows machines and onto Solaris 10 if I can succeed, so it is even more critical in my mind to get this to work. Rob

2 1

winedbg hanging
by Alex Woods 26 Feb '05

26 Feb '05

Hello, When I try to run winedbg with the --gdb option, it simply hangs. I've tracked this down to dbg_get_debuggee_info returning false and then everything falling through to a wait(NULL). The callback that is getting passed SymEnumerateModules doesn't seem to be getting called at all. I've put traces into the SymEnumerateModules but they aren't spitting anything out. Here is the function getting called though: 0035:CALL dbghelp.SymEnumerateModules(<unknown, check return>(0x558b0000,00000002,00000040): returning 558c5de8) ret=55b1f6be 0035:RET dbghelp.SymEnumerateModules(0000003c,55b1f590,55c3f4b0) retval=00000001 ret=55b1f6be0 I'm not I believe that it is getting called, at least not the one in dbghelp/module.c. I've stuck an exit at the top of it, and it doesn't. I've noticed a SymEnumerateModules64 that is just a stub, and that's made me suspicious because I'm running a multilib compiled wine on an x86_64 platform. Also, could that be a problem, since gdb is compiled as 64-bit? I'm pretty sure I'm either being dense, or something is happening that I'm not aware of. Could someone point out which, please? ;) Cheers. -- Alex

1 1

Re: MSVCRT: Generating relay stubs for libc forwards/varargs
by Jon Griffiths 26 Feb '05

26 Feb '05

Hi Uwe, >I think it would be helpfull, if we could generate debug stubs for >these functions. Can anybody help? If you have the SDK headers, winedump in spec mode can generate this for you. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Mail - Easier than ever with enhanced search. Learn more. http://info.mail.yahoo.com/mail_250

2 2

MSVCRT: Generating relay stubs for libc forwards/varargs
by Uwe Bonnes 26 Feb '05

26 Feb '05

Hallo, in msvcrt a lot of functions are of type vararg (e.g. printf) or are forwards into the Linux libc (e.g. strstr) and so leave no trace in a +relay log. This makes it harder to debug. I think it would be helpfull, if we could generate debug stubs for these functions. Can anybody help? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Re: Relax test requirements to accomodate fuzz of msacm
by Robert Reif 26 Feb '05

26 Feb '05

Jeremy White wrote: > Robert has persuaded me that msacm on Windows does make 'fuzzy' > conversions; > an 8,000 byte buffer is up sampled to a 47,992 byte buffer instead of > the logical (and correct seeming) 48,000 byte buffer. This means that > when we go to get the position after playing the answer comes up as > 47992 instead of 48,000, which causes a winmm test failure. The real fix is to fix the wave mapper to do another conversion when the previous one is incomplete. We will have to do this anyway if we ever try to support non PCM formats.

2 3

Re: Problem using winelib to compile Std Lib strings
by Jon Griffiths 26 Feb '05

26 Feb '05

Hi Rob, >I get a few errors like the following: >error: ::div has not been declared >error: ::ldiv has not been declared div and ldiv may or may not be included in the std namespace. Try changing the calls to either remove the scope resolution from their calls or adding std before it. >And tons about /usr/include/pthread.h like the following: >error: uintptr_t does not name a type >error: caddr_t has not been declared You may need to rebuild your gcc supplied headers, check out: http://supportforum.sun.com/sunos/index.php?t=msg&th=2097&start=0&rid=0 for details. If you need/needed to make any fixes to Wine to get it working under Solaris, please consider sending any changes to wine-patches or documenting the process (AFAIK not many ppl are using Wine under solaris). Hope this helps, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Mail - Find what you need with new enhanced search. http://info.mail.yahoo.com/mail_250

1 0

Re: USER32: GetScrollBarInfo
by Alexandre Julliard 26 Feb '05

26 Feb '05

Vitaly Lipatov <lav(a)etersoft.ru> writes: > +static BOOL SCROLL_GetScrollBarInfo(HWND hwnd, LONG idObject, LPSCROLLBARINFO psbi) > +{ > + RECT rect; > + INT arrowSize, thumbSize, thumbPos, nBar, vertical; > + FIXME("check me"); This doesn't sound very encouraging... -- Alexandre Julliard julliard(a)winehq.org

2 1

Build on Fedora core 3 on AMD64
by Adrian Harvey 26 Feb '05

26 Feb '05

I am having trouble getting wine (latest CVS) to build on my AMD64 box runngin Fedora core3, and I was hoping some autoconf wizard might be able to help. To begin at the beginning, the issue that occurs during build is: gcc -m32 -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack- boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o ddraw.dll.dbg.o ddraw.dll.dbg.c .../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./ddraw.spec convert.o dclipper/main.o ddraw/hal.o ddraw/main.o ddraw/thunks.o ddraw/user.o dpalette/hal.o dpalette/main.o dsurface/dib.o dsurface/fakezbuffer.o dsurface/gamma.o dsurface/hal.o dsurface/main.o dsurface/thunks.o dsurface/user.o dsurface/wndproc.o helper.o main.o regsvr.o struct_convert.o ddraw.dll.dbg.o version.res -o ddraw.dll.so -L../../dlls -lole32 -luser32 -lgdi32 -ladvapi32 -lkernel32 - L../../libs/wine -lwine -ldxguid -luuid -L/usr/X11R6/lib64 -lXext - lX11 -L../../libs/port -lwine_port /usr/bin/ld: skipping incompatible /usr/X11R6/lib64/libXext.so when searching for -lXext /usr/bin/ld: skipping incompatible /usr/X11R6/lib64/libXext.a when searching for -lXext /usr/bin/ld: cannot find -lXext collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [ddraw.dll.so] Error 2 make[2]: Leaving directory `/home/adrian/wine/dlls/ddraw' make[1]: *** [ddraw] Error 2 make[1]: Leaving directory `/home/adrian/wine/dlls' make: *** [dlls] Error 2 So it seems that ld is finding the 64-bit version and failing to link it. It seems that the reason for this is that configure uses xmkmf/imake to locate the X11 library directory and that this is always returning the .../lib64 version. I have split out the Imakefile that configure generates, and tried various methods to prevent it seeing the system as 64 bit and handing out the lib64 directory instead of the lib one, but to no avail. running: setarch i386 imake -v -DUseInstalled -I/usr/X11R6/lib/X11/config (to emulate an xmkmf, but with verbosity, which xmkmf doesn't do) gives: gcc -I. -D__amd64__ -D__amd64__ -traditional -Dlinux -DUseInstalled - I/usr/X11R6/lib/X11/config -E -v Imakefile.c Reading specs from /usr/lib/gcc/x86_64-redhat-linux/3.4.2/specs Configured with: ../configure --prefix=/usr --mandir=/usr/share/man -- infodir=/usr/share/info --enable-shared --enable-threads=posix -- disable-checking --with-system-zlib --enable-__cxa_atexit --disable- libunwind-exceptions --enable-languages=c,c++,objc,java,f77 --enable- java-awt=gtk --host=x86_64-redhat-linux Thread model: posix gcc version 3.4.2 20041017 (Red Hat 3.4.2-6.fc3) /usr/libexec/gcc/x86_64-redhat-linux/3.4.2/cc1 -E -traditional-cpp - quiet -v -I. -I/usr/X11R6/lib/X11/config -D__amd64__ -D__amd64__ -Dlinux -DUseInstalled Imakefile.c -mtune=k8 ignoring nonexistent directory "/usr/lib/gcc/x86_64-redhat- linux/3.4.2/../../../../x86_64-redhat-linux/include" #include "..." search starts here: #include <...> search starts here: . /usr/X11R6/lib/X11/config /usr/local/include /usr/lib/gcc/x86_64-redhat-linux/3.4.2/include /usr/include End of search list. I can see that gcc is being passed -D__amd64__ but I can't trace where this is coming from... Am I hunting on the right lines, or is there somthing much simpler I have missed? Also, what do we need to change in the autoconf stuff to allow wine to build correctly on x86_64 multi-arch systems? (assuming that it is not just my system being broken somehow) Thanks for any help, Adrian

2 1

How do native win32 apps end up calling into x11drv?
by Adam Connell 25 Feb '05

25 Feb '05

Greetings, I'm trying to understand how windows drawing gets translated into X in wine and so I was looking at the {im,ex}ports of x11drv and gdi32. x11drv depends on gdi32 and just seems to export a good chunk of the api that gdi32 exports (BitBlt etc). gdi32 doesn't depend on x11drv or even Xlib. How do native win32 apps end up calling into x11drv? Cheers, Adam

2 1

Re: setupapi: enumerate serial ports
by Alexandre Julliard 25 Feb '05

25 Feb '05

Juan Lang <juan_lang(a)yahoo.com> writes: > +/* Based on code from winspool's info.c */ > +static UINT SETUP_CountSerialPorts(void) > +{ > + UINT i, ret; > + > + /* FIXME: it should be possible for more than four COM ports to exist, not > + * sure why we retain that limit, but winspool does too so go with it. > + */ > + for (i = 0, ret = 0; i < 4; i++) > + { > + if (SETUP_SerialPortExists(i)) > + ret++; > + } > + TRACE("returning %d\n", ret); > + return ret; > +} It would probably be better to use QueryDosDevice here. -- Alexandre Julliard julliard(a)winehq.org

2 2

using safe string functions in wine
by James Hawkins 25 Feb '05

25 Feb '05

Hey, While perusing msdn recently, I stumbled across string safe functions. These functions were created to replace the standard c string handling routines. The following are some design criteria of string safe functions (msdn): * Always NULL-terminate the string. * Always take a destination buffer size. * Always return consistent return codes (an HRESULT). * Support 32-bit and 64-bit environments. * Flexibility. http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dnsecure/h… What is your opinion on whether we should implement and use either the user-mode or kernel-mode (or both) string safe functions? Using these functions instead of the standard c string functions would promote consistency and security in the wine code base. On the other hand, using these functions adds another layer of calls to the code. What are other pro's and con's of using string safe functions? -- James Hawkins

3 2

Microsoft admits targeting Wine users
by Tom 25 Feb '05

25 Feb '05

Here is the link: http://news.zdnet.co.uk/0,39020330,39189180,00.htm Tom

3 2

While we're saying thanks, another thing that works is...
by Holly Bostick 25 Feb '05

25 Feb '05

... the Neverwinter Nights Toolset. Amazingly enough, after I had followed a whole lot of very complex instructions in order to download and compile some half-ancient version of WineX (3.3.2), patch it to nwwine (which is the common name of the patched version that is supposed to get the toolset working; it's in Portage and everything), and add Registry entries and native dlls, it turned out that the toolset ran 'perfectly well' under regular old Wine 20050211 (and in fact not very well under nwwine; couldn't use the menus, etc.). My wine is all hacked together atm, so I'll have to do a clean install to see if it needs anything special other than a couple of native dlls (that it might not need, but I had installed them to the program folder for nwwine) before attempting to add it to the appdb, but it definitely works. I've added custom content to all 7 of the Original Campaign modules using it (and the game is using the content properly, so it's correctly added). Oh, and by the way, thanks for the fix of the titlebars; it's really really nice to have the same window decorations in Wine programs as on the rest of the desktop. Just noticed it today (can't believe I didn't before) and wanted to let you know I appreciate it. Holly

1 0

WineConf agenda ideas
by Brian Vincent 25 Feb '05

25 Feb '05

Over the the past week or so I've harassed some folks about the agenda for WineConf. At this point there's a lot that remains to be filled in, but I need some feedback. Also, I need more ideas for presentations. Does anyone want to present something? It'd be great if someone would volunteer. I think what we're shooting for is a presentation followed by discussion all contained within about one hour. In total we'll have 10 - 12 different topics. Here's the items that are definitely going to be on the agenda: WRS intro Keynote - Alexandre Road to .9 and 1.0 - Dimi ReactOS update - all the ReactOS guys Wine / networking / Samba issues - Juan Lang We've also got some other items, but I need feedback as to whether any of you find this stuff interesting. (So reply and tell me if any of these items sound interesting.) Windows authentication - Andrew Bartlett (um.. haven't asked him yet though) Something else Samba related? - Samba guys Commercial port of a Winelib app and using Wine - an enterprise user CXTest and regression testing - someone from CodeWeavers Version control - Mike Hearn wearing a fire retardant suit DCOM work - Mike or Rob DirectX update - ? Also, if you need to make hotel reservations, there's just a few weeks left to do that. Check out the WineConf page for details: http://www.winehq.org/site/wineconf As people begin to figure out travel plans, the wineconf mailing list will pick up. How to join: http://www.winehq.org/mailman/listinfo/wineconf Let me know if you have any questions. -Brian

1 0

Space Empires: Starfury
by Adam Babcock 25 Feb '05

25 Feb '05

I have posted to the list before about this game. Anyway, a group of us over at the publisher's forum really want to see this game running, so we will be getting in #starfury on freenode this saturday to try and get it to run. We would really appreciate the help if anyone from the list with a more technical background on the inner workings of wine would join in and help. We've set a starting time of around 15h00 UTC, so if any of you wanted to join in, would be greatly appreciated.

2 1

Re: [winecfg] Drive autodetection
by Mike Hearn 25 Feb '05

25 Feb '05

Paul van Schayck wrote: > Changelog: > As last option for drive type detection we try the device node name. Looks good but please try and use the same code style as in the rest of the program. In particular note that winecfg doesn't use Hungarian notation anywhere, eg "szNode" would just be "node" or "nodename". thanks -mike

2 2

Re: wsock32 conformance test
by Juan Lang 25 Feb '05

25 Feb '05

Hey guys, nice work. Minor comments below: > +/* we often pass this size by reference */ > +int sizeofSOCKADDR_IN = sizeof(SOCKADDR_IN); When you pass it by reference, you don't reinitialize it after a call that might modify it, e.g. here: > + /* get port number */ > + getsockname(*sock, (SOCKADDR *) &tmpAddr, &sizeofSOCKADDR_IN); I think it'd be safer to declare a local int initialized to sizeof(SOCKADDR_IN) and pass this by ref instead. > + for (connIndex = 0; connIndex < NUM_CLIENTS; connIndex++) { > + /* accept connection */ > + tmpSock = accept(*sock, (SOCKADDR *) &tmpSockAddr, &sizeofSOCKADDR_IN); Your indenting's off here. (Do you have to use tabs? Ick.) > + connection->serverThread.Handle = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE) &BlockingServerConnection_Run, connection, 0, &connection->serverThread.ID); Please wrap long lines. > + const int numTests = 3; Might as well make that static too. Props for first post :) --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Re: SHELL32: implement loading and saving of MSI advertised shortcut info
by Juan Lang 25 Feb '05

25 Feb '05

Hi Mike, > + * in that string is parsed an stored. s/an/and/ > +typedef struct volume_info_t > +{ > + DWORD type; > + DWORD serial; > + WCHAR label[12]; /* assume 8.3 */ Shouldn't label's size be 13? 8+3+'.'+NULL? > + if( (buffer.magic&0xffff0000) != 0xa0000000 ) A symbolic constant would be nice here. Thanks, --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Compiling wine dlls for windows
by Michael Jung 25 Feb '05

25 Feb '05

Hello, I would like to test a wine dll I'm working on on windows. Could you please tell me how the wine dlls are build for windows ? (Or beat me to the the place where it is documented.) Thanks, -- Michael Jung mjung(a)iss.tu-darmstadt.de

4 4

Re: [RESEND2] Uninstaller localization
by Dmitry Timoshkov 25 Feb '05

25 Feb '05

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > Next I'll change the window to a dialog if I can. Thanks. > - wc.lpszClassName = appname; > + wc.lpszClassName = sAppname; > > if (!RegisterClass(&wc)) exit(1); > - hWnd = CreateWindow( appname, "Wine Application Uninstaller", > + hWnd = CreateWindow( sAppname, sAppname, Sorry for not pointing out to it earlier, but it's better to leave the window class name in ASCII. -- Dmitry.

1 0

Re: working installshield?
by Robert Shearman 25 Feb '05

25 Feb '05

Marcus Meissner wrote: >Hi, > >Is there any chance to have a working installshield at some time? > >I don't really want to fall back to the december or even earlier WINE >releases for our spring SUSE Linux product ;) > > I haven't been testing against InstallShield for a while, but last time I checked it was hanging because we do not process window messages during RPCs. If you want to implement this yourself, I can give you details on how to do this. I will get around to this eventually, but at the moment I have other priorities. If the worst happens and InstallShield is still not working, then you can still ship the December ole32 with the most recent Wine. Rob

2 2

WINE: Rendering in Diamond2.x works :-)
by Tobias Burnus 25 Feb '05

25 Feb '05

Hello, I'd like to thank the Winegrowers for providing such a nice flavoured Wine. With the current version, the program Diamond is even able to render the output (at least if one turns off the double buffering): w/o rendering: http://www.physik.fu-berlin.de/~tburnus/wine/diamond2.png w/ rendering: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_rend.png (somehow the menu/tool/status bars are not correctly redrawn and the rendering seems to be too low by the height of a toolbar, but rendering works :-) and hitting Shift-Ctrl-N now works as well (thanks to Dimitry!). Tobias

1 0

wsock32 conformance test
by Thomas Kho 25 Feb '05

25 Feb '05

Hi, We're working on a set of tests for wsock32.dll. So far we've completed a test of blocking network I/O with multiple threads. Before we post to wine-patches, we'd appreciate any critiques/input. Fredy, Doug, and I are UCLA undergraduates in a software engineering course. Thanks for your help, Thomas Kho cc: Fredy Garcia, Douglas Rosenberg (group members) Files available at: http://www.geekymedia.com/viewcvs/cgi/viewcvs.cgi/wine4/wine/dlls/wsock32/t…

1 0

Re: [RESEND] Uninstaller localization
by Dmitry Timoshkov 25 Feb '05

25 Feb '05

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > This time I didn't translate the WINE_ERR messages and translated another messagebox. It would be better to not touch WINE_ERR lines at all then. > Changelog: > - localization of uninstaller > + /* We load the strings */ > + LoadString( hInst, IDS_APPNAME, sAppname, sizeof(sAppname)); ... > - wc.hIcon = LoadIcon( hInst, appname ); > + wc.hIcon = LoadIcon( hInst, sAppname ); LoadIcon will always fail in the localized case. -- Dmitry.

1 0

Re: Fix recently introduced SEGV in DOCFILE IStorage implementation
by Troy Rollo 24 Feb '05

24 Feb '05

On Thursday 24 February 2005 20:39, Paul Vriens wrote: > Could you send the patch to wine-patches :-). Damn, another typo on my part (I meant it to go there in the first place) On Friday 25 February 2005 03:26, Mike McCormack wrote: > Thanks for finding this problem. I think the root cause of the problem > is that three structures that need to be the same require 3 seperate > tweaks. > > Can you confirm that this patch also fixes the problem for you? I probably could, but given the nature of your patch there's a much more efficient test that should give much greater confidence in it - compiling the affected source files without debugging information using your patch and mine should give identical object files (except for time stamps in the object file headers).

1 1

broken faq.sgml
by Vitaly Lipatov 24 Feb '05

24 Feb '05

Patch http://cvs.winehq.org/patch.py?id=16300 breaks faq.sgml in line <question id="Can-I-bundle-everything-in-one-huge-executable"> during compiling: jade:/home/lav/RPM/BUILD/wine-20050224/documentation/faq.sgml:1716:66:Q: length of name token must not exceed NAMELEN (44) -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Fix recently introduced SEGV in DOCFILE IStorage implementation
by Paul Vriens 24 Feb '05

24 Feb '05

On Thu, 2005-02-24 at 17:26, Mike McCormack wrote: > Troy Rollo wrote: > > After changing StorageBaseImpl, StorageInternalImpl was not updated to reflect > > the change. > > Thanks for finding this problem. I think the root cause of the problem > is that three structures that need to be the same require 3 seperate tweaks. > > Can you confirm that this patch also fixes the problem for you? > > thanks, > > Mike > Hi Mike, this fixes one of the problems I had with the Uru_Ages_Beyond_Myst_Demo. I still have problems with InstallShield but that's a known problem, and worked on ;-). Cheers, Paul.

1 0

Re: Child windows require IsWindowVisible() test in DestroyWindow()
by Dmitry Timoshkov 24 Feb '05

24 Feb '05

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > in the msg.c,test_DestroyWindow() test case adding WS_VISIBLE to all > windows except a parent shows that behaviour doesn't change for child > windows but a popup window starts to receive WM_WINDOWPOSCHANGING and > friends indicating that child windows require IsWindowVisible() test. > > I don't want to add that to the real test in order to keep the test > as simple as possible. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > A test shows that child windows require IsWindowVisible() test > in DestroyWindow() in order to suppress ShowWindow() call. Alexandre, please do not apply this patch, it's wrong. -- Dmitry.

1 0

Re: Uninstaller localization
by Dmitry Timoshkov 24 Feb '05

24 Feb '05

"Jonathan Ernst" <Jonathan(a)ErnstFamily.ch> wrote: > Changelog: > - localization of uninstaller You should not localize WINE_ERR messages, encoding of strings might be incompatible in Wine and underlying system. Also, is it possible to use normal dialog for uninstaller's main window? We could use conventional dialog templates in resources for different locales then. Right now localization will look ugly if lengths of strings in various locales are different. -- Dmitry.

1 0

Fwd: Invitation to the mediation manual
by Duane Clark 24 Feb '05

24 Feb '05

Oops, I inadvertently deleted this from the queue, sorry. Robert Schuster wrote: Dear Wine developers, I wrote some guidelines that should help FOSS projects getting more lively and lowering the barrier for new developers to join. You can find them in form of a small manual here http://projects.mi.fu-berlin.de/w/bin/view/SE/ThesisFOSSIMMediationManual. These ideas are the result of work for my bachelor thesis and have been used successfully at the GNU Classpath project. If the topic is of interest to you, I would be happy to receive criticism and comments concerning the manual or the general idea. For further discussion I have set up a mailing-list (use http://lists.spline.inf.fu-berlin.de/mailman/listinfo/mediation_manual to subscribe or mediation_manual(a)lists.spline.inf.fu-berlin.de to post unsubscribed). Please send your feedback to this list but if you have reasons to contact me directly then just reply to this mail. In case you answer to your project's mailing list please CC me. Best regards Robert Schuster

1 0

Re: Poor performance when using Texas Instruments code generation tools in Wine
by Jan Tore Korneliussen 24 Feb '05

24 Feb '05

We found a simple solution (workaround?) to make this application perform well under WINE. Typical running time of the linking process is down from 30min to 15sec (!). A short explanation: The TI linker allocates and frees a lot of small buffers, typical size 24-32 bytes - but we have not seen allocation of buffers smaller than 24 bytes. Due to fragmentation of the heap in WINE, the number of free buffers smaller than 24 bytes gradually increases. Since the free buffers are organized in 4 lists based on their size, the small (<24 bytes) buffers will go in the first list (which in the current version holds buffers of size <= 32), and each new allocation will have to search past these small buffers. After a while this consumes all processor time, due to the large number of allocations done by the linker. A sufficient fix for this particular application is to introduce a new free list for buffers smaller than 24 bytes. In this way the small buffers will simply be skipped for each allocation, keeping allocation time relatively constant. Note that this is a custom fix for this application, but maybe introducing more free list for small buffers can help other applications which allocate a lot of small buffers. I guess one has to collect data from a lot of apps to make a good tradeoff here. Anyway it was a good thing for us that the heap is "tunable". The diff is with respect to Wine-20050211.tar.gz dlls/ntdll/heap.c -- Jan Tore Korneliussen R&D Engineer TANDBERG Phone +47 6783 8514 mail jan.tore.korneliussen(a)tandberg.net 85c85 < #define HEAP_NB_FREE_LISTS 5 /* Number of free lists */ --- > #define HEAP_NB_FREE_LISTS 4 /* Number of free lists */ 90c90 < 0x10, 0x20, 0x80, 0x200, ~0UL --- > 0x20, 0x80, 0x200, ~0UL

1 0

Re: SHELL32: fix SHSimpleIDListFromPath to do the correct thing for non-existing pathes
by Alexandre Julliard 24 Feb '05

24 Feb '05

Mike McCormack <mike(a)codeweavers.com> writes: > ChangeLog: > * fix SHSimpleIDListFromPath to do the correct thing for non-existing pathes This is causing some test failures (and also some extra successes, I guess we are on the right track...) shelllink.c:177: Test succeeded inside todo block: path_to_pidl returned a NULL pidl shelllink.c:197: Test failed: GetPath returned 'C:\nonexistent\file' shelllink.c:234: Test succeeded inside todo block: GetIconLocation failed (0x00000000) shelllink.c:236: Test failed: GetIconLocation returned 'c:\windows\system\shell32.dll' shelllink.c:238: Test succeeded inside todo block: GetIconLocation returned 0 -- Alexandre Julliard julliard(a)winehq.org

1 0

Fix recently introduced SEGV in DOCFILE IStorage implementation
by Troy Rollo 24 Feb '05

24 Feb '05

After changing StorageBaseImpl, StorageInternalImpl was not updated to reflect the change. ChangeLog: Fix SEGV in IStorage implementation due to structure mismatch between StorageBaseImpl and StorageInternalImpl.

1 0

pcmconverter.c question
by Jeremy White 23 Feb '05

23 Feb '05

The attached patch fixes all remaining test failures in winmm when run in interactive mode on my box with Wineoss. It does so by making msacm conversions start aligned (which lets them finish aligned for my test cases). However, it's clear that Robert Reif intended them not to be aligned. My question is: why? Cheers, Jer

2 1

Re: Re: World Of Warcraft
by fenix＠club-internet.fr 23 Feb '05

23 Feb '05

----Message d'origine---- >De: Colin Wright <c.d.wright(a)tesco.net> >A: Raphael <fenix(a)club-internet.fr> >Sujet: Re: World Of Warcraft >Date: Mon, 21 Feb 2005 21:07:14 +0000 > >Raphael wrote: > >> Ouppsss >> >> better patch >> >> sorry >> >> Regards, >> Raphael >> >> On Monday 21 February 2005 09:58, Alex Woods wrote: >>> On Mon, Feb 21, 2005 at 09:33:29AM +0100, Raphael wrote: >>> > can you try this patch ? >>> >>> Yes, doesn't look any different though. I did notice that with either >>> patch I get this though: >>> >>> 0009:warn:opengl:wglGetProcAddress Did not find extension >>> wglGetExtensionsStringARB in either Wine or your OpenGL library. >>> >>> Whereas without the patches I get this: >>> >>> 0009:trace:opengl:wglGetProcAddress (wglGetExtensionsStringARB) >>> 0009:trace:opengl:wglGetProcAddress returning WGL function (0x561cbf90) >>> 0009:trace:opengl:wglGetCurrentDC () >>> 0009:trace:opengl:wglGetCurrentDC returning 0x7b8 (GL context 0x780d7fd8 >>> - Wine context 0x5593f478) 0009:trace:opengl:wglGetExtensionsStringARB () >>> returning "WGL_ARB_extensions_string WGL_EXT_extensions_string" >>> >>> So something must be broken ;) > >I have absolutely no understanding of this but in the list at the >end of your patch mailed to the list there is... > > { "wglGetSwapIntervalEXT", (void *) wglSwapIntervalEXT, NULL, NULL}, > >and 5 lines later > > { "wglSwapIntervalEXT", (void *) wglSwapIntervalEXT, NULL, NULL} > >Since it's the only entry where the string and >pointer/function/object/structure/whatever don't match I wondered it >"wglGetSwapIntervalEXT" ... wglSwapIntervalEXT might be a typo rather >than. > You are right Seems that lionel made a typo :) Thx Regards, Raphael

4 6

Cygwin X11 server, notepad and message boxes
by Krzysztof Foltman 23 Feb '05

23 Feb '05

I'm trying to run notepad on WINE, with DISPLAY environment variable pointing to Cygwin (X Server 6.7.0.0-12) running on my Windows XP machine. It works rather OK-ish, but when I try to close Notepad, it gets stuck in GetMessageW function call after displaying a "text changed, do you want to save ?" dialog box: trace:msg:GetMessageW (1117) mask=0000007f, bits=00000000, changed=00000000, waiting 0009:Call kernel32.ReleaseThunkLock(406ce6f8) ret=409b79a3 0009:Ret kernel32.ReleaseThunkLock() retval=00000000 ret=409b79a3 0009:Call x11drv.MsgWaitForMultipleObjectsEx(00000001,403893f4,ffffffff,00000000,00000000) ret=409b79c7 0009:Call kernel32.WaitForMultipleObjectsEx(00000001,403893f4,00000000,ffffffff,00000000) ret=40ce1838 0009:Call ntdll.NtWaitForMultipleObjects(00000001,406ce32c,00000000,00000000,00000000) ret=404e8989 I guess the bug is not in notepad, but in Wine message handling, as it's not the only program, that freezes after displaying a dialog box. It doesn't happen when MessageBox is called from WM_KEYDOWN handler, but it DOES happen when MessageBox is called from WM_CLOSE handler, but only if WM_CLOSE was sent by system after clicking Close or presing Alt+F4, and not sent or posted by application itself. http://foltman.com/wintest-dlginclose.zip Any idea what it may be ? deadlock ? The version of Wine I'm using was grabbed a couple of hours ago from anonymous CVS. Krzysztof

2 1

Re: rsabase: Make rsabase a wrapper around rsaenh
by Jonathan Ernst 23 Feb '05

23 Feb '05

Le mercredi 23 février 2005 à 13:50 +0100, Michael Jung a écrit : > Ok, that makes rsabase a really trivial dll. Please remove dlls/rsabase/main.c > from cvs (Is there any way to capture this in a diff?) diff -u dlls/rsabase/main.c /dev/null >> rsabase.diff

4 4

Wrong keycodes ?
by George Ginden 23 Feb '05

23 Feb '05

Hi do you guys know anything about that already ? It looks like some keys are not mapped correctly: grep -r VK_* * | grep include/winuser.h include/winuser.h:#define VK_LEFT 0x25 include/winuser.h:#define VK_UP 0x26 include/winuser.h:#define VK_RIGHT 0x27 include/winuser.h:#define VK_DOWN 0x28 These keys are the directional arrows, not the numpad keys... Now look at what wine thinks about those keys when block num is not kicked in: tail -f /projects/tmp/winetrace.log | grep keyboard trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0000 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 83 (0x53) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff96 trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0000 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 80 (0x50) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff97 trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0000 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 85 (0x55) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff98 trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0000 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 88 (0x58) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff99 Kickin'in the block num: trace:keyboard:X11DRV_ToUnicodeEx NumLockMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 100 (0x64) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff51 trace:keyboard:X11DRV_ToUnicodeEx NumLockMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 98 (0x62) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff52 trace:keyboard:X11DRV_ToUnicodeEx NumLockMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 102 (0x66) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff53 trace:keyboard:X11DRV_ToUnicodeEx NumLockMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx AltGrMask = 0010 trace:keyboard:X11DRV_ToUnicodeEx Found keycode 104 (0x68) trace:keyboard:KEYBOARD_MapDeadKeysym no character for dead keysym 0x0000ff54 What's wrong ? Oh, and this output is when using within a edit control. Last but not least, any test against VK_UP VK_DOWN, VK_LEFT, VK_RIGHT fails ... Regards.

2 4

Re: advapi32: Add RegCreate/DeleteKey tests and fixes
by Alexandre Julliard 23 Feb '05

23 Feb '05

James Hawkins <truiken(a)gmail.com> writes: > + /* a key cannot be created directly beneath HKEY_LOCAL_MACHINE or HKEY_USERS */ > + if ((hkey == HKEY_LOCAL_MACHINE || hkey == HKEY_USERS) && !strchr(name, '\\')) { > + *retkey = NULL; > + return ERROR_INVALID_PARAMETER; > + } > + if (!(ret = RegOpenKeyExW( hkey, name, 0, KEY_ENUMERATE_SUB_KEYS, &tmp ))) > { > + /* check for any subkeys > + * a key cannot be deleted if it has any subkeys > + */ > + RegQueryInfoKeyW(tmp, NULL, NULL, NULL, &numSubKeys, NULL, NULL, NULL, NULL, NULL, NULL, NULL); > + if (numSubKeys != 0) { > + if (*name) RegCloseKey(tmp); > + return ERROR_ACCESS_DENIED; > + } These kinds of checks should be done in the lower level functions, not in advapi32 (and in the case of the delete, are done already AFAICT). -- Alexandre Julliard julliard(a)winehq.org

2 4

unixfs.dll: shell namespace extension for the unix filesystem
by Michael Jung 23 Feb '05

23 Feb '05

Hi, this is a first rough cut version of a shell namespace extension to access the unix filesystem from wine. It's primary use-case is for winecfg's drive-mapping propery sheet. It already works for this purpose. It would be cool if 'the COM guys' could take a look at the code, since this is the first time I did something COM'ish. It would be nice if possible miss-conceptions could be found early on. Ciao, -- Michael Jung mjung(a)iss.tu-darmstadt.de

2 3

RE: [ros-dev] RE: Collection of wine tools on windows
by Rolf Kalbermatter 23 Feb '05

23 Feb '05

"Casper Hornstrup" <ch(a)csh-consult.dk> wrote: >Yes, but then you need to publish the sources for the non-free application under the LGPL. >When using headers to build your application, you create a derived work of those headers. > >http://www.fsf.org/licensing/licenses/lgpl.html > >"A "work based on the Library" means either the Library or any derivative work under copyright >law: that is to say, a work containing the Library or a portion of it, either verbatim or with >modifications and/or translated straightforwardly into another language. (Hereinafter, translation >is included without limitation in the term "modification".)" > >"4. You may copy and distribute the Library (or a portion or derivative of it, under Section 2) in >object code or executable form under the terms of Sections 1 and 2 above provided that you accompany >it with the complete corresponding machine-readable source code, which must be distributed under >the terms of Sections 1 and 2 above on a medium customarily used for software interchange." This is rubish. LGPL is understood by most in such a way, that you can use a library in a closed source application as long as you do not make that library a static dependency in your app, meaning that the user could replace that LGPLed library with a newer, compatible version of his and your app still works. Shared libs (or DLLs) clearly are not a static dependency. You are obliged to provide to users of your closed source app and other interested parties the (possibly modified) sources of the LGPL library only, either directly on the media where you distribute your app with or under reasonable terms on request. A download link to Wine seems a very reasonable term to me as long as you didn't make modifications to it, or took care to at least provide a patch with those modifications to the project in question. With public headers for a library, it could be argued that they do not really provide any code (in most cases) and therefore are even less protectable in the interest of portability and interoperation compatibility. If it wouldn't be that way nobody could possibly write a closed source application to run under Linux as the kernel and it's headers are under the even more "restrictive" GPL license and every app has to link to the OS kernel (and use the appropriate headers) in some ways to be operable. Rolf Kalbermatter

2 1

Re: winmm/wineoss: use DSP_POST to flush the frag buffers
by Jeremy White 23 Feb '05

23 Feb '05

Don't apply this; more survey of alternate sound cards shows that DSP_POST does not work as well as advertised everywhere. Jer Jeremy White wrote: > When we get down to the last fragment or two in our output > to the DSP, we should use the SND_DSP_POST ioctl to let the > sound card know to flush those fragments. This allows us to > precisely know when the buffer is empty, and fixes another > set of winmm tests. > > > ------------------------------------------------------------------------ > > Index: dlls/winmm/wineoss/audio.c > =================================================================== > RCS file: /home/wine/wine/dlls/winmm/wineoss/audio.c,v > retrieving revision 1.152 > diff -u -r1.152 audio.c > --- dlls/winmm/wineoss/audio.c 28 Jan 2005 17:21:07 -0000 1.152 > +++ dlls/winmm/wineoss/audio.c 22 Feb 2005 22:17:22 -0000 > @@ -1665,12 +1665,13 @@ > > /* input queue empty and output buffer with less than one fragment to play > * actually some cards do not play the fragment before the last if this one is partially feed > - * so we need to test for full the availability of 2 fragments > + * so we need to test for full the availability of 2 fragments ; the DSP_POST ioctl > + * will let the card know to play out the rest of the fragments > */ > if (!wwo->lpPlayPtr && wwo->dwBufferSize < availInQ + 2 * wwo->dwFragmentSize && > !wwo->bNeedPost) { > - TRACE("Run out of wavehdr:s...\n"); > - return INFINITE; > + TRACE("Run out of wavehdr's, requesting a POST...\n"); > + wwo->bNeedPost = TRUE; > } > > /* no more room... no need to try to feed */

1 0

ole/storage: Problems with 'Myst Uru Demo'
by Paul Vriens 23 Feb '05

23 Feb '05

Hi, eventhough Michael withdrew his patch (http://www.winehq.org/hypermail/wine-devel/2005/02/0687.html) I've tried it, and it crashes in the ole/storage area. I've added some TRACE's and this is the output: 000b:trace:storage:StorageBaseImpl_Release (0x77ece0f8/0x77ece0f8) decremented refcount to 8 000b:trace:storage:StorageBaseImpl_OpenStorage (0x77ece0f8, L"ID_9", (nil), 1012, (nil), 0, 0x28de68) 000b:trace:storage:StorageBaseImpl_OpenStorage Calling IEnumSTATSTGImpl_Construct 000b:trace:storage:IEnumSTATSTGImpl_Construct 0xa2f7c0 / 10680096 000b:trace:storage:IEnumSTATSTGImpl_Construct Calling IStorage_AddRef(0x77ece0f8) 000b:trace:storage:StorageBaseImpl_AddRef (0x77ece0f8) incremented refcount to 9 000b:trace:storage:IEnumSTATSTGImpl_Construct Calling IEnumSTATSTGImpl_Reset 000b:trace:storage:IEnumSTATSTGImpl_Destroy Calling IStorage_Release(0x77ece0f8) 000b:trace:storage:StorageBaseImpl_Release (0x77ece0f8/0x77ece0f8) decremented refcount to 8 000b:trace:storage:StorageBaseImpl_OpenStorage Calling StorageInternalImpl_Construct 000b:trace:storage:StorageInternalImpl_Construct Calling StorageBaseImpl_AddRef(0x77ece0f8) 000b:trace:storage:StorageBaseImpl_AddRef (0x77ece0f8) incremented refcount to 9 000b:trace:storage:StorageBaseImpl_OpenStorage Calling StorageBaseImpl_AddRef(0x77e96a80) 000b:trace:storage:StorageBaseImpl_AddRef (0x77e96a80) incremented refcount to 2012012793 000b:trace:storage:StorageBaseImpl_OpenStorage <-- 00000000 000b:trace:storage:StorageBaseImpl_AddRef (0x77e96a80) incremented refcount to 2012012794 000b:trace:storage:StorageBaseImpl_OpenStream (0x77e96a80, L"FEATURELOG_STDPROPS", (nil), 12, 0, 0x28dd14) 000b:trace:storage:StorageBaseImpl_OpenStream Calling IEnumSTATSTGImpl_Construct 000b:trace:storage:StorageBaseImpl_Release (0x77e96a80/0x77e96a80) decremented refcount to 2012012793 000b:trace:ole:GetErrorInfo (0, 0x28e12c, (nil)) 000b:fixme:crypt:CRYPT_VerifyImage (rsaenh.dll, 0x77e95528): not verifying image 000b:trace:storage:StorageBaseImpl_OpenStream (0x77e96a80, L"FEATURELOG_STDPROPS", (nil), 12, 0, 0x28df4c) 000b:trace:storage:StorageBaseImpl_OpenStream Calling IEnumSTATSTGImpl_Construct wine: Unhandled exception (thread 000b), starting debugger... the refcount with values of 2012012793 look a bit suspicious. Any ideas where to look? Cheers, Paul.

1 1

A call to fix the BeginPaint issue
by Nick Hornback 23 Feb '05

23 Feb '05

Alright, this is probably the last time I will bring it up before I realize that there is essentially no interest in fixing this, but this has been bothering me for quite some time now. A few others have brought it up over the past couple months as well. http://www.winehq.org/hypermail/wine-cvs/2004/10/0395.html As discussed (but nothing really done about it), this patch is directly known to break painting in at least the following applcations: DeusEx Trickstyle Foobar2000 Zoo Tycoon 1 demo This is because, as far as I'm aware, these applications don't send BeginPaint/EndPaint as they technically should, but they all work fine on native Windows. Now, before, it has simply been a matter of reversing the patch, no big deal. However, since the region handling has been moved to the server, that is not possible without a lot of tinkering, something that I just don't have the mad skillz to do. --Nick __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

6 8

Re: rsabase: Make rsabase a wrapper around rsaenh
by Alexandre Julliard 23 Feb '05

23 Feb '05

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > As suggested by Alexandre, I removed all implementation code from rsabase and > made it a pure wrapper around rsaenh. I've imitated the scheme used in wine's > unicows.dll to do so. You don't need that, you can forward directly in the spec file. Unicows has to do it differently because of the way it's loaded, but other dlls can use normal forwards. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Poor performance when using Texas Instruments code generation tools in Wine
by Dan Kegel 23 Feb '05

23 Feb '05

Anders wrote: > We have been using TI code generation tools (compiler and linker) on > Wine, and it has worked well. However, when we started evaluating newer > versions of the codegen tools, the linking time was dramatically > increased (from 20 sec to 30 minutes...). > > We have done some profiling using oprofile, and found that most of this > time (96%) is spent in the HEAP_FindFreeBlock* *function in the ntdll > module. The time needed to locate a free heap block increases gradually, > from a few iterations up to about 15000 in the project we are building. Wow, that's worth looking into! Can you write a small C program that has the same behavior? That would help us reproduce the problem and then solve it. Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

richedit (ro): "Select all" or "Copy" crashes wine
by Tobias Burnus 23 Feb '05

23 Feb '05

Hi, in Diamond 2.x (http://www.codeweavers.com/compatibility/browse/name?app_id=865) there is a structure-data richedit (read-only). (Under Windows: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_info.png; it's on the right side; Wine looks similar, but the background is grey and it is not that sleek.) I can flawlessly select some text using the mouse or the keyboard, but if I use the context menu and choose either of - "Select all" - "Copy" (after selecting something) it crashes with: wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x451e158b). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:451e158b ESP:406dfb98 EBP:406dfbb4 EFLAGS:00210246( - 00 -RIZP1) EAX:40425b70 EBX:451eecec ECX:40b77600 EDX:451f2c50 ESI:00000000 EDI:40425b70 Stack dump: 0x406dfb98: 4058a80e 4058a80e 451eecec 00000000 0x406dfba8: 451eecec 404240d8 00000111 406dfbe8 0x406dfbb8: 451e3ba8 40425b70 00000000 00000000 0x406dfbc8: 00000111 00000000 00000301 00000301 0x406dfbd8: 44b68a14 40b6a450 00000000 00020048 0x406dfbe8: 406dfc0c 40ae88f7 00020048 00000111 Backtrace: =>1 0x451e158b RTFSetEditStream in riched32 (0x406dfbb4) 2 0x451e3ba8 RICHED32_WindowProc in riched32 (0x406dfbe8) 3 0x40ae88f7 WINPROC_wrapper in user32 (0x406dfc0c) 4 0x40ae9c1b WINPROC_CallWndProc in user32 (0x406dfc50) 5 0x40aef2c5 CallWindowProcA in user32 (0x406dfc94) 6 0x00563a90fixme:dbghelp_msc:pe_load_debug_directory This guy has FPO information in diamond (+0x163a90) (0x406dfcb4) 7 0x005641c2 in diamond (+0x1641c2) (0x406dfcd4) 8 0x00562ed9 in diamond (+0x162ed9) (0x406dfd40) 9 0x005631e5 in diamond (+0x1631e5) (0x406dfd5c) 10 0x40ae88f7 WINPROC_wrapper in user32 (0x406dfd80) 11 0x40ae9c1b WINPROC_CallWndProc in user32 (0x406dfdc4) 12 0x40aef2c5 CallWindowProcA in user32 (0x406dfe08) 13 0x40ad26f2 DispatchMessageA in user32 (0x406dfe34) 14 0x00567cb7 in diamond (+0x167cb7) (0x005f3d50) 15 0x00000001 (0x005ab278) 16 0x00464520 in diamond (+0x64520) (0x00589f71) 0x451e158b RTFSetEditStream+0x2b in riched32: movl 0x0(%esi),%eax A WINEDEBUG=+relay,+seh,+tid gives the following (excerpt): (This is with Meissner's wine-20050211-1.1 and CXOffice-nightly 05-02-21 and occurs also with earlier versions of WINE. The excerpt below comes from wine-20050211-1.1 with "Select all".) [...] 0009:Call window proc 0x5631b9 (hwnd=0x20048,msg=WM_COMMAND,wp=000000b1,lp=00000000) 0009:Call kernel32._ConfirmSysLevel(40b77600) ret=40ade8c5 0009:Ret kernel32._ConfirmSysLevel() retval=00000000 ret=40ade8c5 0009:Call kernel32.TlsGetValue(00000007) ret=0058c6c9 0009:Ret kernel32.TlsGetValue() retval=403cdc08 ret=0058c6c9 0009:Call kernel32.TlsGetValue(00000007) ret=0058c6c9 0009:Ret kernel32.TlsGetValue() retval=403cdc08 ret=0058c6c9 0009:Call kernel32.TlsGetValue(00000007) ret=0058c6c9 0009:Ret kernel32.TlsGetValue() retval=403cdc08 ret=0058c6c9 0009:Call user32.CallWindowProcA(451e38b0,00020048,00000111,000000b1,00000000) ret=00563a90 0009:Call kernel32._EnterSysLevel(40b77600) ret=40ade890 0009:Call ntdll.RtlEnterCriticalSection(40b77600) ret=4050828b 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=4050828b 0009:Ret kernel32._EnterSysLevel() retval=4058a640 ret=40ade890 0009:Call kernel32._LeaveSysLevel(40b77600) ret=40ade920 0009:Call ntdll.RtlLeaveCriticalSection(40b77600) ret=40507fc1 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=40507fc1 0009:Ret kernel32._LeaveSysLevel() retval=4058a80e ret=40ade920 0009:Call kernel32._EnterSysLevel(40b77600) ret=40ade890 0009:Call ntdll.RtlEnterCriticalSection(40b77600) ret=4050828b 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=4050828b 0009:Ret kernel32._EnterSysLevel() retval=4058a640 ret=40ade890 0009:Call kernel32._LeaveSysLevel(40b77600) ret=40ade920 0009:Call ntdll.RtlLeaveCriticalSection(40b77600) ret=40507fc1 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=40507fc1 0009:Ret kernel32._LeaveSysLevel() retval=4058a80e ret=40ade920 0009:Call kernel32.GlobalGetAtomNameW(0000c043,406df99c,0000003c) ret=40aba1ba 0009:Ret kernel32.GlobalGetAtomNameW() retval=00000008 ret=40aba1ba 0009:Call kernel32._EnterSysLevel(40b77600) ret=40ade890 0009:Call ntdll.RtlEnterCriticalSection(40b77600) ret=4050828b 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=4050828b 0009:Ret kernel32._EnterSysLevel() retval=4058a640 ret=40ade890 0009:Call kernel32._LeaveSysLevel(40b77600) ret=40ade920 0009:Call ntdll.RtlLeaveCriticalSection(40b77600) ret=40507fc1 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=40507fc1 0009:Ret kernel32._LeaveSysLevel() retval=4058a80e ret=40ade920 0009:Call window proc 0x451e38b0 (hwnd=0x20048,msg=WM_COMMAND,wp=000000b1,lp=00000000) 0009:Call kernel32._ConfirmSysLevel(40b77600) ret=40ade8c5 0009:Ret kernel32._ConfirmSysLevel() retval=00000000 ret=40ade8c5 0009:Call user32.GetWindowLongW(00020048,00000004) ret=451e38e2 0009:Call kernel32._EnterSysLevel(40b77600) ret=40ade890 0009:Call ntdll.RtlEnterCriticalSection(40b77600) ret=4050828b 0009:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=4050828b 0009:Ret kernel32._EnterSysLevel() retval=4058a640 ret=40ade890 0009:Call kernel32._LeaveSysLevel(40b77600) ret=40ade920 0009:Call ntdll.RtlLeaveCriticalSection(40b77600) ret=40507fc1 0009:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=40507fc1 0009:Ret kernel32._LeaveSysLevel() retval=4058a80e ret=40ade920 0009:Ret user32.GetWindowLongW() retval=404240c0 ret=451e38e2 0009:trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x451e158b 0009:trace:seh:EXC_RtlRaiseException info[0]=00000000 0009:trace:seh:EXC_RtlRaiseException info[1]=00000000 0009:trace:seh:EXC_RtlRaiseException eax=40425b30 ebx=451eecec ecx=00000000 edx=451f2c50 esi=00000000 edi=40425b30 0009:trace:seh:EXC_RtlRaiseException ebp=406df9ec esp=406df9d0 cs=0073 ds=007b es=007b fs=003b gs=0033 flags=00210246 0009:trace:seh:EXC_CallHandler calling handler at 0x562f3e code=c0000005 flags=0 0009:Call kernel32.GetLastError() ret=00547758 0009:Ret kernel32.GetLastError() retval=00000000 ret=00547758 0009:Call kernel32.TlsGetValue(00000006) ret=00547766 0009:Ret kernel32.TlsGetValue() retval=44b60100 ret=00547766 0009:Call kernel32.SetLastError(00000000) ret=005477ba 0009:Ret kernel32.SetLastError() retval=00000000 ret=005477ba 0009:trace:seh:EXC_CallHandler handler returned 1 0009:trace:seh:EXC_CallHandler calling handler at 0x54c1e0 code=c0000005 flags=0 0009:Call kernel32.GetLastError() ret=00547758 0009:Ret kernel32.GetLastError() retval=00000000 ret=00547758 0009:Call kernel32.TlsGetValue(00000006) ret=00547766 0009:Ret kernel32.TlsGetValue() retval=44b60100 ret=00547766 0009:Call kernel32.SetLastError(00000000) ret=005477ba 0009:Ret kernel32.SetLastError() retval=00000000 ret=005477ba 0009:Call kernel32.UnhandledExceptionFilter(406df57c) ret=0054e15a 0009:Call kernel32.IsBadCodePtr(41036a10) ret=005503a1 0009:Ret kernel32.IsBadCodePtr() retval=00000000 ret=005503a1 0009:Call kernel32.IsBadCodePtr(1000a670) ret=410386a1 0009:Ret kernel32.IsBadCodePtr() retval=00000000 ret=410386a1 0009:Call ntdll.NtCreateEvent(406df240,001f0003,406df408,00000001,00000000) ret=404c574f 0009:Ret ntdll.NtCreateEvent() retval=00000000 ret=404c574f wine: Unhandled exception (thread 0009), starting debugger... 0009:Call ntdll.RtlInitUnicodeString(406df238,40568a80 L"Machine\\Software\\Microsoft\\Windows NT\\CurrentVersion\\AeDebug") ret=404c 57e0 [...] Tobias

1 0

Checking Wine's spec files
by Francois Gouget 23 Feb '05

23 Feb '05

The recent problems with -noname in shell32.spec got be to dig up an old script I had which reads spec and dumpbin files and processes them. I then retrofitted it so it could do some hopefully useful checks for this kind of issues. So this script works by comparing the output of winedump or dumpbin on the Windows dlls for as many platforms as are available (I have 7 so far) with the contents of Wine's spec files. It then applies a number of rules to try to detect problems. However the information we can extract from the Windows dlls is incomplete so this script uses heuristics. This means the problems it reports should be treated with a grain of salt. Running the check script To download and run the check script, see the instructions are on my web site: http://fgouget.free.fr/wine/checkspec-en.shtml Then you can run it as follows: ./check_spec --verbose ~/wine/dlls/shell32.spec And here is a description of the checks it performs so far, illustrated with the output for shell32.dll. Comments and suggestions for more checks or improvements are welcome. I'll wait a bit (and then start sending some patches unless someone else wants to tackle this (could be a nice janitorial project). Notes: * It would be nice if winedump could dump the Platform SDK's .lib files. These files must have an explicit mention of which entry points have the -noname property so this would give us a more reliable source of information than the heuristics in this script. * dumpbin will something special when an API is being forwarded: 40 [NONAME] (forwarded to shlwapi.PathIsRelativeW) But winedump prints nothing special. It would be nice to add this functionality to winedump. -noname vs. ordinal internal consistency ----------------------------------------- This check verifies that all APIs which have the '-noname' property, also have an explicit ordinal. This is the only check which does not depend on dumps of the Windows dlls. No problem found here. APIs which should not have an explicit ordinal ---------------------------------------------- The script scans the Wine spec file for APIs which have both a name and an explicit ordinal. For each of these, the script looks up the API by name on the Windows platforms and collates a list of the corresponding ordinals. If it finds more than one ordinal then it considers the API should not be given an explicit ordinal. In that case it reports how many times the API was found with the right ordinal on Windows, and how many different values were found. If the former is 0 or 1 then it's clear the API should not be given an explicit ordinal. If the latter is 2 then things are maybe not so clear. These 64 APIs should not have an ordinal: SHGetDataFromIDListA (correct 0 times, found 5 values) StrChrIW (correct 0 times, found 3 values) SheGetCurDrive (correct 0 times, found 5 values) ShellAboutW (correct 0 times, found 5 values) SheFullPathA (correct 0 times, found 5 values) DllGetClassObject (correct 0 times, found 5 values) SheGetDirA (correct 0 times, found 5 values) SheGetPathOffsetW (correct 0 times, found 5 values) SheGetDirW (correct 0 times, found 5 values) DragFinish (correct 0 times, found 5 values) StrCmpNW (correct 0 times, found 3 values) StrNCmpA (correct 0 times, found 3 values) StrCmpNIA (correct 0 times, found 3 values) ShellExecuteW (correct 0 times, found 5 values) SheChangeDirW (correct 0 times, found 5 values) Shell_NotifyIconW (correct 0 times, found 5 values) StrCpyNA (correct 0 times, found 3 values) SheRemoveQuotesW (correct 0 times, found 5 values) StrCmpNA (correct 0 times, found 3 values) ShellExecuteExA (correct 0 times, found 5 values) StrRStrIA (correct 0 times, found 3 values) StrStrA (correct 0 times, found 3 values) StrStrW (correct 0 times, found 3 values) StrChrA (correct 0 times, found 3 values) SheShortenPathA (correct 0 times, found 5 values) StrNCmpIW (correct 0 times, found 3 values) StrRChrIA (correct 0 times, found 3 values) StrChrIA (correct 0 times, found 3 values) SheConvertPathW (correct 0 times, found 5 values) StrNCpyW (correct 0 times, found 3 values) DragAcceptFiles (correct 0 times, found 5 values) StrRStrIW (correct 0 times, found 3 values) StrNCmpIA (correct 0 times, found 3 values) Shell_NotifyIconA (correct 0 times, found 5 values) ShellExecuteA (correct 0 times, found 5 values) ShellExecuteEx (correct 0 times, found 5 values) SheChangeDirA (correct 0 times, found 5 values) StrStrIA (correct 0 times, found 3 values) SheChangeDirExA (correct 0 times, found 5 values) ShellAboutA (correct 0 times, found 5 values) SheChangeDirExW (correct 0 times, found 5 values) ShellExecuteExW (correct 0 times, found 5 values) StrNCmpW (correct 0 times, found 3 values) StrChrW (correct 0 times, found 3 values) DragQueryFile (correct 0 times, found 5 values) StrRStrW (correct 0 times, found 3 values) StrCpyNW (correct 0 times, found 3 values) DragQueryFileA (correct 0 times, found 5 values) StrNCpyA (correct 0 times, found 3 values) DragQueryFileW (correct 0 times, found 5 values) Shell_NotifyIcon (correct 0 times, found 5 values) StrStrIW (correct 0 times, found 3 values) SHGetDataFromIDListW (correct 0 times, found 5 values) SheGetDirExW (correct 0 times, found 5 values) SheFullPathW (correct 0 times, found 5 values) SheRemoveQuotesA (correct 0 times, found 5 values) SheShortenPathW (correct 0 times, found 5 values) StrRStrA (correct 0 times, found 3 values) StrCmpNIW (correct 0 times, found 3 values) StrRChrW (correct 0 times, found 3 values) SheSetCurDrive (correct 0 times, found 5 values) StrRChrIW (correct 0 times, found 3 values) DragQueryPoint (correct 0 times, found 5 values) StrRChrA (correct 0 times, found 3 values) APIs which have the wrong ordinal --------------------------------- This check collates a list of Windows ordinals for the API exactly as above. But it emits a warning about the API only if it found a single ordinal value on Windows and that ordinal does not match Wine's ordinal. These 1 APIs have the wrong ordinal: ReadCabinetState (is 654 on api2003es) (may be best to ignore this one) APIs which should have the -noname property -------------------------------------------- Again this check concerns APIs which have both an explicit ordinal and a name. This time it counts the number of Windows platforms where the API is not exported by name but which still have an entry point with the right ordinal and no name. If more than one such platforms were found, the script considers the API should have the '-noname' property. These 28 APIs should have the -noname property: SHRegOpenKeyW (507 has no name on api95 api98 apint4) SHGetNetResource (69 has no name on all) DAD_SetDragImageFromListView (177 has no name on all) ReceiveAddToRecentDocs (647 has no name on api95 api98 apime apint4 api2000) SHRegQueryValueExW (511 has no name on api95 api98 apint4) PifMgr_GetProperties (10 has no name on api95 api98 apime apint4 api2000 apixp) SHChangeRegistrationReceive (646 has no name on all) RestartDialogEx (730 has no name on apixp) SHRegQueryValueA (508 has no name on api95 api98 apint4) SHWaitOp_Operate (648 has no name on all) SHNetConnectionDialog (160 has no name on all) InvalidateDriveType (65 has no name on all) SHRegCloseKey (505 has no name on api95 api98 apint4) SHHandleDiskFull (185 has no name on all) SHFindComputer (91 has no name on all) SHRegQueryValueW (510 has no name on api95 api98 apint4) SHGlobalDefect (197 has no name on all) PifMgr_OpenProperties (9 has no name on api95 api98 apime apint4 api2000 apixp) SHRegQueryValueExA (509 has no name on api95 api98 apint4) PifMgr_SetProperties (11 has no name on api95 api98 apime apint4 api2000 apixp) SHCreatePropSheetExtArrayEx (194 has no name on all) RealDriveTypeFlags (525 has no name on all) SHChangeNotifyReceive (643 has no name on all) SHRegOpenKeyA (506 has no name on api95 api98 apint4) SHIsBadInterfacePtr (84 has no name on all) SHRegDeleteKeyW (512 has no name on apint4) PifMgr_CloseProperties (13 has no name on api95 api98 apime apint4 api2000 apixp) DragQueryInfo (76 has no name on all) APIs which should not have the -noname property ------------------------------------------------ This the same check as above but with a different analysis of the results. Namely, the script considers the API should not have the -noname property if one of the following two conditions is met: * the API is exported by name on all platforms * the API's ordinal corresponds to another API on one of the platforms. These 33 APIs should not have the -noname property: FileMenu_AppendItem (115 has other names on apixp api2003es) FileMenu_Create (114 has other names on apixp api2003es) DragFinish FileMenu_DeleteItemByFirstID (141 has other names on apixp api2003es) FileMenu_DrawItem (105 has other names on apixp api2003es) FileMenu_DeleteAllItems (104 has other names on apixp api2003es) FileMenu_DeleteItemByCmd (117 has other names on apixp api2003es) FileMenu_DeleteItemByIndex (140 has other names on apixp api2003es) FileMenu_DeleteSeparator (142 has other names on apixp api2003es) FileMenu_ReplaceUsingPidl (113 has other names on apixp api2003es) FileMenu_MeasureItem (112 has other names on apixp api2003es) ILAppend (154 has other names on api2003es) FileMenu_AppendFilesForPidl (124 has other names on apixp api2003es) DragAcceptFiles FileMenu_InitMenuPopup (109 has other names on apixp api2003es) FileMenu_AbortInitMenu (120 has other names on apixp api2003es) FileMenu_GetLastSelectedItemPidls (107 has other names on apixp api2003es) FileMenu_EnableItemByCmd (143 has other names on apixp api2003es) FileMenu_HandleMenuChar (108 has other names on apixp api2003es) Shell_GetImageList (71 has other names on api2003es) FileMenu_GetItemExtent (144 has other names on apixp api2003es) FileMenu_TrackPopupMenuEx (116 has other names on apixp api2003es) DragQueryFile FileMenu_FindSubMenuByPidl (106 has other names on apixp api2003es) FileMenu_Invalidate (111 has other names on apixp api2003es) DragQueryFileA DragQueryFileW FileMenu_AddFilesForPidl (125 has other names on api95 api98 apime apint4 api2000 apixp api2003es) FileMenu_Destroy (118 has other names on apixp api2003es) ShellDDEInit (188 has other names on api95 api98 apint4) DragQueryPoint FileMenu_InsertUsingPidl (110 has other names on apixp api2003es) IsUserAdmin (680 has other names on api2003es) Missing APIs ------------ The script only reports an API as missing if it is present on all platforms but missing from Wine's spec file. That's per Wine's policy to not add APIs that are only present on newer platforms unless we have a good reason to. These 2 APIs are missing: SHInvokePrinterCommandW SHInvokePrinterCommandA -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ RFC 2549: ftp://ftp.isi.edu/in-notes/rfc2549.txt IP over Avian Carriers with Quality of Service

2 5

Re: Should winecfg drive detection create device symlinks
by Michael Jung 23 Feb '05

23 Feb '05

On Wednesday 23 February 2005 08:40, Paul van Schayck wrote: > <mjung(a)iss.tu-darmstadt.de> wrote: > > I think winecfg does this already. Take a look at the function > > apply_drive_functions in drive.c. Does'nt it work for you? > > As far as I can tell it does not. We do not store the device node path > in the detect functions so I see no way we make symlinks from > dosdevices/ to device nodes. Sorry, I misunderstood you. > Yeah, the auto detect works here just fine (symlinks are created). > Just one problem I haven't come up with a sollution yet. My floppy has > as fs type in fstab 'auto'. This means my floppy comes up as a fixed > harddrive. I have the same problem for my cdrom. As a heuristic, how about the following: If fs type is auto and the referenced device node is /dev/fd*, we assume it's a floppy. If fs type is auto and the referenced device node is not /dev/fd*, we assume it's a cdrom. Are floppies always mapped to /dev/fd* or are there other valid device nodes? How about BSD/Solaris? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: advapi32: Don't free csp dll when a container is deleted
by Michael Jung 23 Feb '05

23 Feb '05

On Wednesday 23 February 2005 00:04, Michael Jung wrote: > Changelog: > Don't unload Cryptographic Service Provider DLL when a key container is > deleted. There might still be open handles. Don't apply this patch, please. It fixes the crash in the "Uru Demo" installer only by coincidence. We really have to implement a reference counting scheme to solve this problem properly. Ciao, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

Re: msi: detect registry keypaths
by Alexandre Julliard 23 Feb '05

23 Feb '05

Aric Stewart <aric(a)codeweavers.com> writes: > - FIXME("Only working for installed files, not registry keys\n"); > - if ( GetFileAttributesW(path) != INVALID_FILE_ATTRIBUTES ) > - rrc = INSTALLSTATE_LOCAL; > + if (path[0]=='0') > + { > + FIXME("Registry entry.. check entry\n"); > + if (path[0]) > + rrc = INSTALLSTATE_LOCAL; > + else > + rrc = INSTALLSTATE_ABSENT; > + } Since path[0] is first checked against '0' this test doesn't seem to make much sense. What are you trying to do here? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: status of wine dll's
by Juan Lang 22 Feb '05

22 Feb '05

Alexandre wrote: > I'm not convinced we want to remove it completely, there just might be > an app somewhere that looks for it explicitly, and it doesn't cost > anything to keep it. If so, that app won't work on windows; most versions of windows only ship with rsaenh.dll. The only ones that have rsabase are really old versions, and those that are sold in the crypto-export-restricted countries. I think removal makes more sense, keeping rsabase costs a little confusion. --Juan __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

Re: dlls/gdi: fix GetGlyphOutline(resend)
by Huw Davies 22 Feb '05

22 Feb '05

On Tue, Feb 22, 2005 at 11:31:30PM +0900, TANABE Hiroshi wrote: > @@ -2903,7 +2901,8 @@ > TM.tmStruckOut = font->strikeout; > > /* Yes TPMF_FIXED_PITCH is correct; braindead api */ > - if(!FT_IS_FIXED_WIDTH(ft_face)) > + if(!FT_IS_FIXED_WIDTH(ft_face) && > + (pOS2->version == 0xFFFFU || pOS2->panose[3]!=9)) > TM.tmPitchAndFamily = TMPF_FIXED_PITCH; > else > TM.tmPitchAndFamily = 0; Isn't this a bug in FreeType? If we have to have this in Wine, could you use the defines in wingdi.h instead of the '3' and the '9'? Huw. -- Huw Davies huw(a)codeweavers.com

1 0

regression
by Oliver Stieber 22 Feb '05

22 Feb '05

Hi, I've had a regression with Creatures 2 between and 2005-02-03 and 2005-02-19.. Creatures 2 makes heavy use of out-of-process COM for it's components, the main screen used to work ok (but the components didn't). Now it starts up and I get the error. "err:virtual:NtMapViewOfSection Sizes larger than 4Gb not supported" I'll try to find out what patch caused the regression. 1 0x405168ec RaiseException 2 0x5f45394berr:virtual:NtMapViewOfSection Sizes larger than 4Gb not supported ?? in mfc42 (0x406ffcd8) 3 0x5f40d992 ?? in mfc42 (0x0047ceb8) ...stack missing. other threads are waiting for ConnectNamedPipe,sync.c:1311 RPCRT4_Receive,rpc_message.c:312 RPCRT4_process_packet,rpc_server.c:316 ... RPCRT4_server_thread, rpc_server.c:506 User_update_thread, dsurface/user.c:515 RPCRT4_worker_thread, rpc_server.c:353 ___________________________________________________________ ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

2 4

Poor performance when using Texas Instruments code generation tools in Wine
by Anders Rønningen 22 Feb '05

22 Feb '05

Hi ! We have some performance problems with Wine that we could use some help on.. Here's the story: We have been using TI code generation tools (compiler and linker) on Wine, and it has worked well. However, when we started evaluating newer versions of the codegen tools, the linking time was dramatically increased (from 20 sec to 30 minutes...). We have done some profiling using oprofile, and found that most of this time (96%) is spent in the HEAP_FindFreeBlock* *function in the ntdll module. The time needed to locate a free heap block increases gradually, from a few iterations up to about 15000 in the project we are building. We suspect that this may be due to fragmentation caused by the heap allocate/free algorithms. We do not have the same problem when building the code under Windows, so we tried to use the native ntdll.dll from Windows instead of ntdll.dll.so, hoping that this would solve the performance issue. We are aware that this is not recommended, but wanted to give it a try anyway. We added the dll file to the global dll-override section in the config file under ~/.wine/config, but it seems like Wine just looks for the builtin dll. We see from strace that we access the correct config file at startup. Is override of ntdll not supported, or have we missed something? If it is supported, is it likely that it is going to work? We have read some posts in the newsgroup about the heap issues. It seems that people agree that the heap should be improved, either by tweaking the existing code, or by using another heap implementation. Is any work planned on this? -- Regards / Mvh - Anders Rønningen Engineer R&D TANDBERG Phone: +47 67 125 125 Direct: +47 67 838 584 Mobile: +47 97 791 217 Fax: +47 67 125 234 mailto:anders.ronningen@tandberg.net http://www.tandberg.net

6 5

Re: SHELL32: cleanup, create unicode versions of some functions
by Dmitry Timoshkov 22 Feb '05

22 Feb '05

"Mike McCormack" <mike(a)codeweavers.com> wrote: > ChangeLog: > * cleanup, create unicode versions of _ILCreateFromPath, > _ILCreateGuidFromStr, and _ILCreateFromFindData > @@ -524,7 +516,7 @@ BOOL WINAPI ILIsEqual(LPCITEMIDLIST pidl > _ILSimpleGetText(pidltemp1, szData1, MAX_PATH); > _ILSimpleGetText(pidltemp2, szData2, MAX_PATH); > > - if (strcasecmp ( szData1, szData2 )!=0 ) > + if (strcasecmp( szData1, szData2 )) > return FALSE; > > pidltemp1 = ILGetNext(pidltemp1); > @@ -574,7 +566,7 @@ BOOL WINAPI ILIsParent(LPCITEMIDLIST pid > _ILSimpleGetText(pParent, szData1, MAX_PATH); > _ILSimpleGetText(pChild, szData2, MAX_PATH); > > - if (strcasecmp ( szData1, szData2 )!=0 ) > + if (strcasecmp( szData1, szData2 )) > return FALSE; As a common rule strcasecmp should never be used in Wine code, since it introduces problem with portability and unexpected side effects when locale of the underlying system differs from a Wine one. You could make it a part of your clean up as well :-) -- Dmitry.

3 4

Microsoft genuine downloads looking for wine
by Ivan Leo Puoti 22 Feb '05

22 Feb '05

As some of you may know, Microsoft is planning to totally restrict access to the Microsoft download center to all non-genuine windows users. So you would expect some check for pirated copies of windows to be involved. If you visit the download center with IE you get an activex control, but if you try with Firefox, you'll have to download a little program, that returns a code you have to copy into the download page, to get access to the download you selected. By quickly looking at the program, I noticed it looks for a registry key, this key is... SOFTWARE\Wine\Wine\Config the wine configuration key. the Windows Genuine Advantage program press release http://www.microsoft.com/presspass/press/2005/jan05/01-26GenuineAdvantagePR… says that in the second half of 2005, all users connecting to the Microsoft download center or to windows update will have to validate their copy of windows. Interestingly if you run the validation program on wine, and the version of windows you're emulating is prior to 2000 or is windows server 20003, you get a message saying a validation code couldn't be found, because of technical difficulties or because you're running an unsupported operating system. If you set winver to win2000, you'll get a validation code that doesn't work, this may be a bug in wine, or in the validation program. A valid and working code is returned if the version is set to xp. Still, even if this is only an initial attempt, they appear to want to discriminate wine users, while this may be acceptable for operating system components/updates, this is probably a violation of anti-trust law for all other downloads. It's also the first time Microsoft acknowledges the existence of Wine. Ivan Leo.

15 19

How do I extract the symbols from a pdb file?
by Fredrik �hrstr�m 22 Feb '05

22 Feb '05

Hi all! I am trying to to write a tool that uses the code in dbghelp to do this but I am unclear on which interface I should use to do this. Can I link to dbghlp.dll.so or do I have to write a tool inside Wine for this? I am going to use the symbol info to load a full minidump and extract information from it.... Thanks! Fredrik Öhrström _________________________________________________________________ Don't just search. Find. Check out the new MSN Search! http://search.msn.click-url.com/go/onm00200636ave/direct/01/

1 0

Collection of wine tools on windows
by Boaz Harrosh 22 Feb '05

22 Feb '05

There is a question at the end. Background: I'm putting up a Web-corner with ATL & MFC for other (gcc for now) Compilers. It will include tools, links, documentation, example makefiles, and so on to let people take an MSVC project and compile it under GCC. (+Winelib on other than windows platforms) My first release target is Windows/ReactOS MinGW-PE. What I did is take the work I've done on Linux and port it back to MinGW. At first, as I expected, it did not work at all. So what I did without hesitation is fetch the Wine headers set, + (yes) wine-msvcrt. Completely removed MinGW originally supplied headers put Wine on the Include path, and voila It was compiling Just like on Linux. (Well it didn't link, than it didn't run, because of the weak symbols thing but I fixed all that). I find 3 things bad about MinGW headers. (Please don't take this as flame. I have all the admiration for all involved and no offense is intended) 1) MinGW header-set are Evil - Because they are ugly, with this, no variables names, and all this style for machines guide. This I already carry for 10 years so here it is off my chest. 2) Win32 is not complete - I would say that MFC and ATL/WTL are a very good exercise for the completeness of the Win32 API. Well the wine stuff have every thing we need, MinGW does not 3) msvcrt - msvcrt compatibility is far from satisfactory on MinGW. Wine, since they had to re-implement msvcrt.dll had to have all these funny MS permutations of the c run time. Compiling on MinGW is almost like using wine without MBCS defined. MinGW headers are mainly derived from GCC c-runtime, with a few adjustments for the -mno-cygwin mode. But they are greatly missing all the esoteric stuff that is needed by MFC and ATL. Wine is perfect, thanks to CodeWeavers, need to run all these MFC apps out there. 4) (I know I said 3) It is time, that all projects collaborate on ONE set of headers and ReactOS is the bridge to that - It is a long time do, that Wine's Set of headers are adopted by all projects. MinGW concentrates on PE gcc compilers, and pass the Win32 project to wine. Wine will release a headers only package for every body to use. (This is what I'll do on first release of my project) [Question to the ReactOS team] The windres utility is insufficient for Most of the projects out there. For example one reason my project is not already on the air. (And hence my post) is that it refuses to compile my Toolbar resource tag. (And what is an MFC app with out a toolbar). I have seen some work done on porting wrc to PE is that work done and will you have a pre-compiled binary package for use to use on windows/ReactOS. Same applies to widl. ReactOS should adopt all these Wine tools as part of their regular tools portfolio. MinGW should adopt Wine's / ReactOS's leadership on all these technologies and supply-link to them by default. Go duplicate all these goodies the wine guys are preparing for us with widl. Again guys please let the passed be gone. And put our differences behind us. There are grate things happening, clearly Wine is the Leader here, lets do this sooner than later. Dimi I need your help here Free Life Boaz

5 8

Re: "bachelor project" with wine ?
by Dan Kegel 22 Feb '05

22 Feb '05

Joris Huizer wrote: > I'm supposed to choose a topic - and work it out - for a "bachelor > project"; > Now, at the moment I have no clue, and teachers are discussing what > topics to hand; in the mean time, I think maybe it might be interesting > to do some wine work in such a form that it's ok for this "bachelor > project" :) > > This project is supposed to be something like 308 hours; and of course, > it should be possible to show something interesting at the end of that. > About my background, I have a few years of (simple) programming > experience (in C and C++, mostly) and most of that was done under linux > -- just school programs most of the time; I don't have much experience > with X programming and *none at all* with winapi; > Is there a "project"/are there "projects" in wine, suitable for this? Absolutely. I'm sure others will suggest more ideas, but here's my suggestion: add some test cases to the Wine conformance test suite. I am mentoring about 14 college students doing this right now for college credit; four are doing it for a whole year, ten are doing it for a single semester. They are finding it appropriately challenging, and I think you will, too. See http://www.kegel.com/wine/sweng/ for the step-by-step instructions I wrote up for the semester class. (I'll be revising that as the semester continues to address issues found by the students.) Good luck, and feel free to write me with any questions! - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: Add new headers and changes in headers about security
by Alexandre Julliard 21 Feb '05

21 Feb '05

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > Move definitions from winerror.h to issperr.h. I don't think you want to do that, issperr.h is supposed to be an obsolete header. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Re: World Of Warcraft
by fenix＠club-internet.fr 21 Feb '05

21 Feb '05

Hi lionel, GL_VERSION isn't pertinent as it contains (only) provider and driver version while GLX_VERSION is really the version string of GLX impl. Regards, Raphael ----Message d'origine---- >De: Lionel Ulmer <lionel.ulmer(a)free.fr> >A: Raphael <fenix(a)club-internet.fr> >Copie à: Alex Woods <wine-devel(a)giblets.org>, wine-devel(a)winehq.org >Sujet: Re: World Of Warcraft >Date: Mon, 21 Feb 2005 21:44:31 +0100 > >On Mon, Feb 21, 2005 at 09:39:31PM +0100, Raphael wrote: >> Ouppsss >> >> better patch > >Why did you do this change: > >- const char *gl_version = (const char *) glGetString(GL_VERSION); >+ const char *gl_version = glXGetClientString(display, GLX_VERSION); > >I.e. replacing the GL version with the one of GLX ? Maybe the GLX version is >needed, but we could then log both of them and not replace GL by GLX. > > Lionel > >-- > Lionel Ulmer - http://www.bbrox.org/ > >

2 1

possibly new regression
by MightY 21 Feb '05

21 Feb '05

Hi, I'm new to the list, so please tell me if I do anything wrong ;). The update from wine-2005-01-11 to wine-2005-02-11 caused a regression with an application I'm trying to get to work. I identified the concrete patch that introduces the problem. It's this one made by Rein Klazes: http://www.winehq.org/hypermail/wine-cvs/2005/01/0612.html What I see happening is the following: sebi@mighty system $ wine gothic.exe wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: divide by zero in 32-bit code (0x00500280). In 32 bit mode. err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:00500280 ESP:7785fcdc EBP:7785fe1c EFLAGS:00010246( - 00 -RIZP1) EAX:5da7c456 EBX:00000000 ECX:7785fe14 EDX:01c516a3 ESI:77b13480 EDI:76e166c0 Stack dump: 0x7785fcdc: 77bf19fb 77bf19fa 00000000 6b636f4c 0x7785fcec: 544f475f 00434948 758a00b0 77b07720 0x7785fcfc: 7599ef50 00890668 0a93c21c 00000000 0x7785fd0c: 7785fe14 0a93c31a 7599ef50 0055d8da 0x7785fd1c: 7599ef50 004012b2 7599ef50 0000c028 0x7785fd2c: 0044cb88 77bf19fb 77bf19fa 007f56ec Backtrace: =>1 0x00500280 in gothic (+0x100280) (0x7785fe1c) 2 0x00500121 in gothic (+0x100121) (0x7785fe58) 3 0x0050005c in gothic (+0x10005c) (0x007f56ec) 4 0x0080b1d8 in gothic (+0x40b1d8) (0x0041daf0) 0x00500280: divl 0x00895c58,%eax Wine-dbg> No window is drawn (usually a splash screen appears...). Maybe you can make some sense of it. Surely I didn't provide a lot of information, but I'm not really sure what kind of info you will need. If you need any additional information on the problem, please tell me. -- Sebastian Schlingmann

3 4

Recent CVS update causes Quicken popup problem/Help please
by Carl Sopchak 21 Feb '05

21 Feb '05

I recently did a CVS update after a fairly long time without one. Afterwards, Quicken 2000 Deluxe has had a problem: When in an account register, as you type the description into a new record, Quicken will pop-up a window showing prior transactions that match what you type. (Quicken calls this Quick Fill. If you press Enter, the transaction is copied into the new record. A VERY nice feature!) The problem is that the pop-up never "goes away", which it should do if (a) your typing causes no prior transaction matches, or (b) you accept the match that is suggested. I have found in the wine debug log that Quicken tries to "get rid" of the popup by setting the popup's rectangle to {0,0;0,0}, which causes the server call to set_window_pos to return with "INVALID_PARAMETER {new_style=00000000}". After adding debug TRACE messages to dlls/x11drv/winpos.c, I have confirmed that the window style just prior to the server call is 94800007 (WS_POPUP | WS_VISIBLE | WS_CLIPSIBLINGS | WS_BORDER | WS_DLGMODALFRAME | WS_DRAGDETECT | WS_NOPARENTNOTIFY). After adding further debugging statements to server/window.c, I have found that the server handler for set_window_pos calls validate_window_rectangles(). Validate_window_rectangles fails because {0,0;0,0} is not within the client's rectangle ({1,1;479,20}), so set_window_pos never gets called. Now, I assume that using a rectangle size of {0,0;0,0} is a valid way to pop-down the popup. Even if not, that appears to be the way Quicken is doing it. I guess my problem is that I have NO CLUE as to how this SHOULD be handled. Should the style be set to (style & ~WS_VISIBLE) when the rectangle is {0,0;0,0}? Should {0,0;0,0} be considered a valid rectangle in validate_window_rectangles()? Should validate_window_rectangles() only get called if the rectangle is not {0,0;0,0}? Or, very possibly, is there something else that should happen? Just to see what happened, I commented out the call to validate_window_rectangles, and the popup disappeared as it should. If anyone has any hints as to what should be done here, I could implement and test this, and send a patch along... As an aside, I noticed on the winehq.org web site that the debugging "quick start" page specifically states that the Debug Channels are not used for the server but the developer's guide does not. And neither suggest how to add debugging messages to the server. Perhaps this could be explained in more detail somewhere? (I could add a section, if the sources of the manual is in CVS, and I knew where they were...) Thanks for the help, Carl

3 3

[PATCH] Add NZDT support to TZ_INFO
by Darryl Dixon 21 Feb '05

21 Feb '05

Adds support for NZDT (New Zealand Daylight Time) to TZ_INFO. Cheers, -- Darryl Dixon <esrever_otua(a)pythonhacker.is-a-geek.net>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel