- wine-devel - winehq.org

Re: My "Helping Applications Work" Guide
by Dan Kegel 22 Dec '04

22 Dec '04

Mike Hearn wrote: > This quote: "An alternative option, perhaps more effective and expensive, is to pay wine > developers for their work on your application, either directly through a > negotiated contract or indirectly by posting a bounty" ... could it have a > link to CodeWeavers please? I think it's fair to say that we're the number > one provider of these sorts of services by a long way, but currently we're > still quite dependent on people being able to find us, so additional links > and publicity is needed. Yeah, a link to http://codeweavers.com would be appropriate. You might want to link to a list of vendors who are willing to help update Wine to work with particular apps and contribute the fixes back to the winehq tree per the LGPL, e.g. http://codeweavers.com http://www.macadamian.com http://www.itomig.de Itomig's a newcomer, but what the heck, they seem to be interested in helping the Wine community. (Also maybe Transgaming, but I don't know if they're willing to work on the winehq tree anyore). - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [OLE #10] Make out of process COM work with OXID based marshal ids
by Robert Shearman 22 Dec '04

22 Dec '04

Mike Hearn wrote: >This patch makes InstallShield work again, and should let you get >further Bill. > >- Ensure all intermediate threads join the original apartment >- Make the listener thread fully apartment scoped (one per apt not per > process) >- Improve "already have mid" error message >- Rename _StubReaderThread to stub_dispatch_thread >- Improve tracing > > Sorry Mike, but we want to *remove* the current hacks for the RPC-runtime emulating named pipe code, not adding more. The correct approach for the crash in _LocalServerThread is to use table-strong marshaling once and then copy the contents of the stream to the pipe for each iteration in the loop, instead of marshaling each time. The correct approach for the crash in _StubReaderThread is to make it execute in the correct apartment - either by sending a window message to the STA window or by joining the MTA. I believe you had a patch for this in July or August when we last worked on this. Rob

4 12

Re: Add ntoskrnl.exe.so
by Steven Edwards 22 Dec '04

22 Dec '04

Hi, --- Ivan Leo Puoti <ivanleo(a)gmail.com> wrote: > Add ntoskrnl, only a few stub functions for now, so we have something to > work on. > All the functions needed by safedisc are in the spec, we can't implement > them all > as stubs ATM because for two of them we need defines from the ddk, > I'll be sending a patch to add ntddk.h in the near future. Check the ReactOS or w32api DDK. Its public domain. > +MODULE = ntoskrnl.exe > +IMPORTS = kernel32 > +DLLMODE = native kernel32 can't be a dependancy on ntoskrnl. We are going to need to redesign Wine if we are going to have a ntoskrnl implementation. > +BOOLEAN WINAPI PsGetVersion(PULONG MajorVersion OPTIONAL, PULONG MinorVersion OPTIONAL, > + PULONG BuildNumber OPTIONAL, PUNICODE_STRING CSDVersion > + OSVERSIONINFOA version; > + version.dwOSVersionInfoSize=sizeof(OSVERSIONINFOA); > + GetVersionExA(&version); We need to either duplicate or move the version code in to ntoskrnl.exe. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

1 0

Re: Re: AppDB TODO update: Templates
by Chris Morgan 22 Dec '04

22 Dec '04

I think you are covering the appropriate mailing lists. If you'd like to chat in real-time about hacking appdb, channel #winehackers on irc.freenode.net is a good place. Tony, Jon and myself are frequently there and chat at least every other day about appdb related things. About the templates, is this what Jeremy did in the lostwages archive(www.winehq.org/cvsweb/lostwages)? I wasn't too familiar with the changes he made and thought it would be good to discuss things prior to making such large changes to the appdb code. Anything that improves the design is more than welcome. Chris > > From: Stefan Pflüger <stefan(a)homepage4us.de> > Date: 2004/12/22 Wed PM 02:33:18 EST > To: wine-devel(a)winehq.org > CC: cmorgan(a)alum.WPI.EDU, appdb(a)winehq.org > Subject: Re: AppDB TODO update: Templates > > Basically, I'll implement a class that is able to read a template file > and that can assign content to special tags in there. > > The index.php would create an object of this class using a "main > template" that includes all parts of the page that are static (header, > footer, the main html tables). Depending on a GET variable, the > index.php calls a function whose returned data will be used as the main > content, it would be for example index.php?action=browseapps to get to > the "Browse Apps" page. > > The content of the sidebar, the banner ad etc. would also be created by > a function like it's already done (see banner_display() in > include/banner.php), but instead of just echo-ing this somewhere in the > right place, it would also be fed into the template engine that again > replaces the corresponding tags in the main template. Those functions > might also use the template class to implement their own sub-templates. > > In the end, the template class object in index.php should have the > complete output ready for sending it to the user. > > Hopefully, my short explanation was good enough to illustrate the concept. > > > Stefan > > PS.: What's the correct list/address to send mails concerning this > discussion to? I'm sending them to the wine-devel list atm, CCing to > Chris Morgan and appdb(a)winehq.org... > >

2 1

Re: AppDB TODO update: Templates
by Chris Morgan 22 Dec '04

22 Dec '04

Cool, thanks for claiming this so we don't have people stepping on each others toes. Would you mind showing a little bit of what you planned on changing? It would be nice to have agreement that this was the direction we wanted to go before a big patch was submitted. Chris > > From: Stefan Pflüger <stefan(a)homepage4us.de> > Date: 2004/12/22 Wed PM 01:05:06 EST > To: wine-devel(a)winehq.org > CC: appdb(a)winehq.org > Subject: AppDB TODO update: Templates > > Hello, > > the last update added > > +# incorporate templates into appdb to simplify code, Jeremy says we can > +borrow from lostwages(winehq.org/cvsweb/lostwages) for this > > to the TODO file. > > At the moment, I'm trying to use AppDB for another project and I already > planned on implementing templates. > If nobody else wants to do the job, I'll go ahead and send you a patch > as soon as I'm finished. > > Stefan Pflüger > >

2 1

Writing an app. using existing dll
by Per Arnold Blåsmo 22 Dec '04

22 Dec '04

Hi, I have a windows-dll and wants to make an app that runs on Linux under wine using this dll. I have the API description for this dll, but not the source code. I there any possibility for that using i.e. winelib and is there any howto to get me started. PerA.

2 1

AppDB TODO update: Templates
by Stefan Pflüger 22 Dec '04

22 Dec '04

Hello, the last update added +# incorporate templates into appdb to simplify code, Jeremy says we can +borrow from lostwages(winehq.org/cvsweb/lostwages) for this to the TODO file. At the moment, I'm trying to use AppDB for another project and I already planned on implementing templates. If nobody else wants to do the job, I'll go ahead and send you a patch as soon as I'm finished. Stefan Pflüger

2 1

Re: Implement DceErrorInqText
by Dmitry Timoshkov 22 Dec '04

22 Dec '04

"Bill Medland" <billmedland(a)mercuryspeed.com> wrote: > +RPC_STATUS RPC_ENTRY DceErrorInqTextW (unsigned long e, unsigned short *b) > +{ > + DWORD count; > + if (acceptable_rpc_code (e)) It would be much more natural to make FormatMessageW to decide whether a passed error code is valid or not, i.e. if it exists in the system message table. > + { > + count = FormatMessageW (FORMAT_MESSAGE_FROM_SYSTEM | > + FORMAT_MESSAGE_IGNORE_INSERTS, > + NULL, e, 0, b, /* I don't know!!! */ 65535, NULL); 256 (or 1024) is a reasonable margin I believe, at least messages in Wine are much shorter of even 256. > + } > + else > + count = 0; > + if (!count) > + { > + MultiByteToWideChar(CP_ACP, 0, cszInvalidCode, -1, b, 65535 /* ??? */); A message about invalid code should be localizable as well, so it should be either loaded by LoadString or even by FormatMessage for consistency IMO. winerror.h from PlatformSDK has the following definition which matches your error text ("The error specified is not a valid Windows RPC error code.\r\n"): // // MessageId: RPC_S_NOT_RPC_ERROR // // MessageText: // // The error specified is not a valid Windows RPC error code. // #define RPC_S_NOT_RPC_ERROR 1823L -- Dmitry.

3 5

Re: wine/dlls/cabinet cabextract.c
by Andreas Mohr 22 Dec '04

22 Dec '04

Hi, On Wed, Dec 22, 2004 at 11:11:32AM -0600, Alexandre Julliard wrote: > ChangeSet ID: 14986 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/12/22 11:11:32 > > Modified files: > dlls/cabinet : cabextract.c > > Log message: > Revert previous patch, that's not a leak. Nice, but... ;-) [get ready to read my usual "not commented" complaint] Why isn't there a comment nearby? 8 weeks later Joe Janitor 2's source code analyzer tool will strike gold again, and then you'll have fun with another patch "correcting" things that turn(ed) out shouldn't be corrected... Andreas Mohr

1 0

Re: Getting rid of async.h
by Alexandre Julliard 22 Dec '04

22 Dec '04

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > - we maintain on the client side whether there's still some pending > async op on the current thread (this is needed in optimizing some wait > operations) That part doesn't look right, you clear the flag when removing the last async operation on an fd, but this bears no relation to the number of async operations in the current thread. It seems to me this could instead be done entirely on the client side, since we need to allocate and free an async structure for each operation we should be able to maintain a counter of them on the client side. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll / kernel32: #52
by Alexandre Julliard 22 Dec '04

22 Dec '04

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > +/* FIXME: 0xFFFFFFFF is our shortcut for global table > + * we could also tweak init_atom_table request to get a handle to the > + * global table in wineserver > + */ > +#define GLOBAL_ATOM_TABLE ((void*)0xFFFFFFFF) Yes, you need to get a valid handle here, 0xffffffff is the current process pseudo-handle and we don't want to overload that meaning. Also your local table allocation is not thread-safe, it can potentially leak an atom table. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: test.h: problem with ok's argument evaluation order
by Alexandre Julliard 22 Dec '04

22 Dec '04

Rein Klazes <wijn(a)wanadoo.nl> writes: > --- wine/include/wine/test.h 2004-05-04 08:10:39.000000000 +0200 > +++ mywine/include/wine/test.h 2004-12-20 15:29:39.000000000 +0100 > @@ -53,7 +53,8 @@ extern void winetest_trace( const char * > > #endif /* __GNUC__ */ > > -#define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok > +#define winetest_ok_(cond, args...) (cond) ? winetest_ok(TRUE, args) : winetest_ok(FALSE, args) > +#define ok_(file, line) (winetest_set_location(file, line), 0) ? 0 : winetest_ok_ Unfortunately varargs macros are not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Merging the AppDB Documentation and the WineHQ documentation pages
by Scott Ritchie 21 Dec '04

21 Dec '04

Mike said this about my new "helping applications work" page: >Looks great! I'd suggest putting it in the Documentation section, and >then linking to it from the appdb page. This then prompted me to wonder "which documentation section?" This is kind of confusing: I click on documentation at the main wine page, and I get some useful stuff. I wander into the AppDB page, click on documentation, and I get some different stuff. Methinks we should just dump them all into one page. This has the added benefit of informing people without the wherewithal to click "Applications" that there is, in fact, an AppDB. On another note, it looks like the AppDB documentation is in PHP, rather than the normal template format like the rest of the website. Is this a good idea? Thanks, Scott Ritchie

1 0

Re: wine/dlls/cabinet cabextract.c
by Mike McCormack 21 Dec '04

21 Dec '04

This patch breaks IE6 install. Mike Alexandre Julliard wrote: > ChangeSet ID: 14647 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/12/02 11:55:41 > > Modified files: > dlls/cabinet : cabextract.c > > Log message: > James Hawkins <truiken(a)gmail.com> > Fix cabextract memory leak. > > Patch: http://cvs.winehq.org/patch.py?id=14647 > > Old revision New revision Changes Path > 1.15 1.16 +2 -0 wine/dlls/cabinet/cabextract.c

1 0

Some performance stats
by Dmitry Timoshkov 21 Dec '04

21 Dec '04

Hello all, while debugging one of applications I'm working on I noticed a lot of GetPrivateProfileString calls with the same file name but in different case causes profile code to open and parse system.ini again. I sent a patch which helps to find a cached file in that case and do not parse it again. I had a thought that another speed improvement might be to use FindFirstFileW instead of CreateFileW/GetFileTime to retrieve last modification time of a file. I wrote a test under Windows to see which of FindFirstFileW or CreateFileW is faster. The test is attached. Here are the results (for 10000 loops) running the same binaries in Wine and Windows 2000 SP4 (hard disks are the same in both systems): =================================================================== Win2k SP4/NTFS volume: test_CreateFileW: P3/1GHz time elapsed 363 ms test_FindFirstFileW: P3/1GHz time elapsed 547 ms Wine/ext3 volume: test_CreateFileW: P3/1GHz time elapsed 543 ms test_FindFirstFileW: P3/1GHz time elapsed 1650 ms =================================================================== CreateFileW is only 1.5 times slower in Wine than in Windows, that's really not bad (especially taking into account Wine boot time), but still there is a possibility for an improvement. FindFirstFileW is 3 times slower in Wine than CreateFileW, while it's only 1.5 times slower in Windows. This needs to be optimized. -- Dmitry.

1 0

wine-alsa gives compile errors
by Joris Huizer 21 Dec '04

21 Dec '04

Hello, I'm not sure where to post this, so posting to wine-users and wine-devel; I got wine sources from cvs and tried compiling it -- something seems to be wrong in the alsa code - it gives compile errors about functions getting too many arguments (I attached an error log) Hopefully this is fixed soon regards, Joris

1 0

Re: [OLE #3] Tests For COM Functions (Try 2)
by Dmitry Timoshkov 21 Dec '04

21 Dec '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > This differs from the previous send of this patch by not using some > functions that are not present on Win9x and without DCOM95 and by > disabling the out-of-process COM tests, which seems to need more work, > but is useful for me testing locally. Dmitry, you reported to me before > that Win95 w/o DCOM95 does not export CoResumeClassObjects, but MSDN > claims that it does. Is MSDN wrong? Just checked Win95 OSR2 again: ole32.dll does not export CoResumeClassObjects. That's a clean system, without MS Office, DCOM95 or something like that. -- Dmitry.

1 0

My "Helping Applications Work" Guide
by Scott Ritchie 21 Dec '04

21 Dec '04

I've recently finished up my "helping applications work" guide. It's meant to be something an end user with a problem application can read, and if he has the will to learn how to help. However, I'm not exactly sure where to put it on the winehq website. Perhaps it should be linked from the main page of the applications database, or from the support tab, or something. Anyway, I'm posting it here for peer review. I've also sent it to wine-patches, but as I said nothing yet links to it. Thanks, Scott Ritchie ----helping_applications.template---- <h1>How to help get applications working in Wine</h1> <p>If you want to help get an application working in Wine, the first thing you should do is register yourself in the applications database and use one of your votes to indicate that you'd like more effort to be spent on the application. Every once in a while, a wine developer will finish a project and look for something to do - combing through the higher voted apps to find one that people need work on is a great way to spend one's time and fill up a todo list.</p> <p>If the application that you want working is not listed in the applications database, there is an easy to use form available for you to add it.  If the application is in the database, but lacks a maintainer you should consider becoming one. If you are familiar with wine and have a desire to test the application and help get or keep it working, please apply by clicking the link in the application's page. Each application should have a supermaintainer, and, if different versions of the application are substantially different (such as in Internet Explorer), each subversion should have a maintainer. Please don't feel deterred by the need to apply to become a maintainer - the application form is largely a formality to prevent abuse and we can virtually guarantee your acceptance.</p> <p>If you are the developer or publisher of the application, you obviously have a very big incentive to help get your application working under wine. Fortunately, there are many options available to you other than reporting bugs and hoping someone will fix them. By far the easiest way is to simply send free copies of your software to wine developers and hope they'll take an interest in getting it working. You'd be amazed how effective this approach can be, particularly for games. An alternative option, perhaps more effective and expensive, is to pay wine developers for their work on your application, either directly through a negotiated contract or indirectly by posting a bounty. The most direct method, however, is to help develop wine itself and contribute code directly, which is exactly what Corel did for WordPerfect several years ago. In any case, making a post on the wine developers <a href="http://www.winehq.org/site/forums">email list</a> can go a long way. <h2>If your application doesn't work:</h2> <p>If your application experiences problems in a particular area, or fails to even run at all, there are a number of steps you can take to help us. The most important thing is to find out where exactly the application is failing. To diagnose application problems, the first step is to run the program from the console using wine, rather than from a gui shortcut. This will allow wine to output error messages to the console, the understanding of which are key to solving the problem and getting the application to work.</p> <p>An application may not work because Wine doesn't yet fully implement one of the DLL files the application is trying to use. If you encounter a DLL not found error, or see a lot of "FixMe:" messages while running the application in wine, this is likely the case. When this occurs, you can try using native (non-wine) DLL files in place of Wine's builtin ones. Check the application database page for the program. There may be special configuration options or instructions for installing native DLL files there that you can try to get the application working. For further configuration help, please see the <a href="http://www.winehq.org/site/docs/wine-user/running">Running Wine</a> section of the User Guide.</p> <p>If the application still doesn't work, it's probably due to a bug or deficiency in Wine and we'd like to hear about it. Please see the <a href="http://bugs.winehq.org/">reporting bugs</a> page for instructions on how to best report bugs with applications.</p> <h2>If your application does work, but with some difficulty:</h2> <p>Sometimes, applications run under wine but they don't function quite as smoothly as they do in windows. They may have display errors, a feature may be broken, or they may run unusually slow. These applications should receive a lower rating from their maintainers of between 2 and 4 stars in the Application's Database, depending on the degree of difficulty encountered.</p>  <p>If you have found a way to make an application work that is more complicated than simply installing it, please share that information by posting on the application's page in the database. If you are the maintainer for the application, please post the instructions in a "howto," which will appear inside green bars at the top of the application's page.</p> <h2>If your application used to work, but has since broken in a new version of wine:</h2> <p>Wine is a large and complex project, composed of many files written by different authors. Sometimes, an attempt to change a file and expand support for one application will unexpectedly cause another application to stop functioning. These changes are known as "regressions", and they are unfortunately sometimes found in the wine source code because the author of a patch that causes a regression is quite simply unaware of it. Since the wine developers can't possibly test every application with every patch, we have to rely on the community to inform us of when regressions occur so that the problem can be easily identified and ultimately fixed. Without community involvement, regressions can go unfixed for potentially very long periods of time.</p> <p>If your application has experienced a regression, please try and provide us with as much information as you can about when and how it broke. This allows us to isolate the exact thing we screwed up in the code and provide a fix. Please provide as much as you know about which version of wine worked, and which version didn't, including the version number and how you installed it (from source, binary packages, etc.) Finally, please post these things in the Application Database page for the app.</p> <p>If you wish to be extremely helpful, you can try to isolate the exact patch which broke your application. This takes quite a bit of time and effort, but it is quite simply the best way to get your application working again. When it comes to fixing regressions, the only thing more helpful to the wine developers than knowing exactly which patch caused a regression is receiving a fix for the patch itself. For help with isolating problem patches, please see the documentation on <a href="http://www.winehq.org/site/docs/wine-devel/x1375">regression testing</a>.</p>

2 1

Re: [LOSTWAGES]New short About blurb on the Front Page
by Scott Ritchie 21 Dec '04

21 Dec '04

http://www.winehq.org/hypermail/wine-patches/2004/12/0343.html Is there a reason why this little update hasn't been committed? I think it makes the front page a bit more user-friendly, as well as updating some of the links. Thanks, Scott Ritchie

1 0

Re: Make winetest.exe detect if it is running on a visible desktop. Now without the linewrap.
by Ferenc Wagner 20 Dec '04

20 Dec '04

Jakob Eriksson <jakov(a)vmlinux.org> writes: > Now without the linewrap. I hate to say this, but it's still wrapped... :( -- Feri.

1 0

Janitorial: HeapFree of NULL
by Michael Stefaniuc 20 Dec '04

20 Dec '04

Hello, there is a lot (my attached smatch script found 234 occurences) of code like if (this) HeapFree(GetProcessHeap(), 0, this); HeapFree(GetProcessHeap(), 0, that); which is redundant because after Win2000 (if i can trust the comment in RtlFreeHeap) freeing a NULL pointer isn't an error. I've checked it Win2000 and can confirm that. I've also checked Win95 and Win98 and both don't crash when HeapFree'ing a NULL but they return an error and SetLastError to 212 "ERROR_LOCKED". In the above code the return code of HeapFree isn't checked so this wouldn't matter if somebody would run the Wine code on that Win versions. So i propose to shorten that code to HeapFree(GetProcessHeap(), 0, this); HeapFree(GetProcessHeap(), 0, that); I've done this already for the wininet dll (see patch to wine-patches) and if it gets accepted i'll take care of the rest. Advantages: - less (redundant) code - more pleasant to the eye - for the wininet.dll it saves 1.1kB (FC2, gcc-3.3.3-7) in the generated code (ok, the wininet.dll.so is 1.6 MB but still) Disadvantages: - if the pointer is NULL it takes longer for that code path. But i don't think it matters cause this happens mostly only on the (unlikely) error path. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: OpenSCManager() bug
by Ivan Leo Puoti 20 Dec '04

20 Dec '04

>Hello, > >initially i tested this stuff under XP and it raised exception if lpDatabaseName >is invalid pointer. But after you noticed the bug i run the test under 2000 and >it has been returned ERROR_NOACCESS. > >Both versions return ERROR_INVALID_NAME if lpDatabaseName is empty string. > >I think the patch should look like this: In Age of Empires 2 lpDatabaseName is just an empty string, so I've sent a patch to wine-patches that allows the database name to be '\0'. Ivan.

1 0

Re: TopLevelWindow Maximize
by Dmitry Timoshkov 20 Dec '04

20 Dec '04

"Katia Maculan" <katia.maculan(a)isis-papyrus.com> wrote: > + switch (message) > + { > + case WM_SHOWWINDOW: > + case WM_SIZE: > + DefWindowProc(hWnd, message, wParam, lParam); > + PostMessage (hWnd, WM_PAINT, 0, 0); If you wish to schedule a WM_PAINT message you have to invalidate a window. -- Dmitry.

2 1

Re: OpenSCManager() bug
by Alexander Yaworsky 20 Dec '04

20 Dec '04

Hello, initially i tested this stuff under XP and it raised exception if lpDatabaseName is invalid pointer. But after you noticed the bug i run the test under 2000 and it has been returned ERROR_NOACCESS. Both versions return ERROR_INVALID_NAME if lpDatabaseName is empty string. I think the patch should look like this: @@ -750,6 +750,11 @@ if( lpDatabaseName ) { + if( IsBadStringPtrW( lpDatabaseName, -1 ) ) + { + SetLastError( ERROR_NOACCESS ); + return NULL; + } if( strcmpiW( lpDatabaseName, SERVICES_ACTIVE_DATABASEW ) == 0 ) { /* noop, all right */ On the other hand i think that all this stuff is a kind of masturbation. When i implemented this, i used some tests (i'm going to put them into shape of unit tests) to investigate the real behaviour. The last patch establishes that behaviour replacing fixme that was an eyesore, but in reality the database name is not used and IMO will never be used. Ivan Leo Puoti wrote: > This patch http://cvs.winehq.org/patch.py?id=14769 had caused a problem with Age > of Empires. The game uses a copy protection system that is installed as a > service, before your patch, the service tried to load the copy protection driver > (This fails, but that's another story), after your patch wine goes straight to > the debugger after calling OpenSCManager. I added a trace and found that this > code is executed > { > FIXME("ERROR_INVALID_NAME"); > return NULL; > } > and causes the crash. The value of lpDatabaseName that AoE passes to the > function is 1; also according to MSDN > http://msdn.microsoft.com/library/default.asp?url=/library/en-us/dllproc/ba… > lpDatabaseName can be NULL, and in this case SERVICES_ACTIVE_DATABASE is opened. > As it's late here the only idea I get at the moment is to print the value as a > FIXME or ERR or whatever, and not return NULL, as this doesn't appear to be the > correct behavior. As you've implemented this stuff and I don't know much about > it I would like to know what you think.

1 0

safedisc
by Ivan Leo Puoti 20 Dec '04

20 Dec '04

The attached patch is the first step towards supporting safedisc, it adds code sent from Marcus a few months ago to the current dlls/ntdll/virtual.c It allows us to successfully load the secdrv.sys file into memory. It has been tested with the copy of safedisc that comes with Age of Empires 2. I've just checked that it compiles without warnings and loads the file, there may be room for improvement, so I'm posting it here for review. The next step will be to merge Marcus's implementation of ntloskrnl.exe, that is needed because safedisc imports some functions from that file. Ivan.

1 0

Re: [AppDB] big AppDB refactoring
by tony_lambregts＠telusplanet.net 19 Dec '04

19 Dec '04

Jonathan Ernst wrote: > This patch is a big refactoring of the AppDB. Some files have been > moved and renamed, others were simply deleted and many where fixed and > improved. No functional differences (apart the fixed global vars). > > *The configuration (config.inc.php) has to be updated on the live server* > > CHANGELOG: > - moved functional code out of procedural code > - moved functional code out of object oriented code > - moved classes in /include/classes/ > - moved functions libraries in /includes/functions/ > - deleted some no more needed files (content was duplicate or included in other files) > - created a library for bugzilla related functions > - moved some code from one library to another library (db related in /include/db.php, etc.) > - improved the config file (using constants, ability to specify new parameters that would make it very easy to integrate the appdb on another site like ReactOS as they can replace references to winehq and bugs.winehq.org for example) > - the debug parameter of the config file is now taken into consideration in the code (function isdebugging() has been improved) > - fixed some obvious global vars bugs when encountered (so that the help system re-works and most broken admin functions are back) > - replaced apidb occurences with appdb as it's the name of the application > - replaced $apidb_root occurences with BASE constant because both were used and had the same value (so no more glbal $apidb_root needed) > - updated TODO and CODING_STANDARD regarding these changes > - overall improved security (because of global vars and using constants for the config so that it can't be changed using php injection) > > Files added: > - include/classes/application.php > - include/classes/menu.php > - include/classes/screenshot.php > - include/classes/tableve.php > - include/classes/category.php > - include/classes/query.php > - include/classes/session.php > - include/classes/user.php > - include/functions/appdb.php > - include/functions/date.php > - include/functions/maintainer.php > - include/functions/rating.php > - include/functions/util.php > - include/functions/banner.php > - include/functions/db.php > - include/functions/pn_buttons.php > - include/functions/sidebar_admin.php > - include/functions/vote.php > - include/functions/bugzilla.php > - include/functions/help.php > - include/functions/sidebar_login.php > - include/functions/comments.php > - include/functions/html.php > - include/functions/query.php > - include/functions/sidebar.php > > > Files deleted: > - include/appbyvendor_inc.php > - include/appdb.php > - include/application.php > - include/appversion_inc.php > - include/banner.php > - include/category.php > - include/comments.php > - include/db.php > - include/html.php > - include/maintainer.php > - include/menu.php > - include/parsedate.php > - include/pn_buttons.php > - include/qclass.php > - include/query_inc.php > - include/rating.php > - include/session.php > - include/sidebar.php > - include/sidebar_admin.php > - include/sidebar_login.php > - include/tableve.php > - include/user.php > - include/util.php > - include/vote.php > > File changed: > - CODING_STANDARD > - TODO > - account.php > - addcomment.php > - appbrowse.php > - appdbStats.php > - appsubmit.php > - appview.php > - bugs.php > - commentview.php > - deletecomment.php > - edituser.php > - index.php > - maintainerdelete.php > - maintainersubmit.php > - noteview.php > - preferences.php > - screenshots.php > - search.php > - stdquery.php > - support.php > - updaterating.php > - updatevote.php > - vendorview.php > - votestats.php > - admin/addAppFamily.php > - admin/addAppNote.php > - admin/addAppVersion.php > - admin/addCategory.php > - admin/addVendor.php > - admin/adminAppQueue.php > - admin/adminCommentView.php > - admin/adminMaintainerQueue.php > - admin/adminMaintainers.php > - admin/deleteAny.php > - admin/editAppFamily.php > - admin/editAppNote.php > - admin/editAppOwners.php > - admin/editAppVersion.php > - admin/editBundle.php > - admin/editCategory.php > - admin/editVendor.php > - admin/index.php > - admin/adminAppDataQueue.php > - help/index.php > - include/config.php.sample > - include/header.php > - include/incl.php > - include/query_users.php > <gack> you _can't_ be serious. - One patch to do one thing. For example each of the following should their own patch. Change apidb_header() and apidb_footer() to appdb_header() and appdb_footer() Change apidb_fullurl() to appdb_fullurl Move include/tableve.php to include/classes/tableve.php Move include/application.php to include/classes/application.php ... I know you probably will end up sending more than a dozen patches that way. However, I can't approve of a wholesale change, like this, in one go. </gack> The changes you propose are good ones. Just break them down. -- Tony Lambregts

3 3

Loading a .dll.so from current directory
by Frank Richter 19 Dec '04

19 Dec '04

Hi, I would like to load a .dll.so from the current directory, and I wonder what's the best way to accomplish this... I tried to set WINEDLLPATH, but it doesn't seem to have an effect (the .dll.so is still only tried to be loaded from /usr/lib, as I can see from the trace:module output). The .dll.so is loaded from a .dll that in turn is called by rundll32... could I perhaps "patch" the DllOverrides for rundll32 in the registry? -f.r.

1 0

Re: [AppDB] screenshot patch
by Chris Morgan 18 Dec '04

18 Dec '04

Please convert tabs to spaces. Chris On Saturday 11 December 2004 1:07 pm, Jonathan Ernst wrote: > This patch let user click on the random screenshot displayed for an app > so that he can see the whole gallery by version. The patch displays the > name of the application in the gallery as well (even if we choose a > particular gallery). > > Screenshot gallery's screenshot: http://ernstfamily.ch/screenshot.png > > File changed: > - appview.php > - screenshots.php

2 1

RE: Message Notify
by M.hearn 18 Dec '04

18 Dec '04

3 2

out-of-process COM design
by Bill Medland 18 Dec '04

18 Dec '04

Is there any chance of help here, please. For one reason or another I need to help get the ole32/oleaut32/rpcrt4 working for our application (the REG_EXPAND_SZ issue means that we don't work with wine after 200409 because of the mix of native dlls we use) I just tried running with the native ole32/oleaut32/rpcrt4 and the first thing I tripped over was (what I presume is) an out-of-process COM problem. The actual stack dump is that: _LocalServerThread (compobj.c) calls StdMarshalImpl_MarshalInterface (...) which has mid.oxid = COM_CurrentApt()->oxid; which throws a memory error because COM_CurrentApt is null because, presumably the thread hasn't yet initialised an apartment. Does anyone know anything about this? e.g. when starting a new thread where does the apartment get initialized? -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

4 15

Version Detection
by Florian Goth 18 Dec '04

18 Dec '04

Well, I also have a problem with the Windows Version, while trying to install a Windows Media Player. I have set the Windows Version in the config file to Win95 . The First Problem is, that I can't Install WMP 6.4. It says that a Version for Win2000 will be available sometime in the future. So I tried WMP 7.1. I get these Messages: fixme:font:load_VDMX No suitable ratio found fixme:ver:VERSION_GetLinkedDllVersion Unknown EXE OS version 4.0, please report !! fixme:propsheet:PROPSHEET_UnImplementedFlags PSH_RTLREADING fixme:font:load_VDMX No suitable ratio found fixme:font:load_VDMX No suitable ratio found fixme:font:load_VDMX No suitable ratio found fixme:ole:CoCreateInstance no classfactory created for CLSID {cfc399af-d876-11d0-9c10-00c04fc99c8e}, hres is 0x80040154 I can't install it also.It complains that it can't check the Internet for Updates.

3 2

Version Detection (this time for dcom98.exe)
by Paul Vriens 18 Dec '04

18 Dec '04

Hi, one of the first things I normally do after a fresh wine install is installing dcom98. This wasn't a problem before (use the correct overrides). Just tell me if I don't need this (anymore). Installing dcom98 with the current version checking is a different ballgame. Just running it with WINEDEBUG=+ver,+process shows the following versions: DCOM98.EXE trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") install.exe trace:ver:RtlGetVersion <-- Windows NT 4.0 (L"Service Pack 6a") rundll32.exe trace:ver:RtlGetVersion <-- Windows 95 (L"") in the trace. Simply overriding an application is not that easy anymore. dcom98 for examples launches 3 different executables. (I don't want to set the general OS override for now). Any ideas who to proceed with this (in general regarding versioning)? Cheers, Paul.

1 0

Version Problems
by Florian Goth 18 Dec '04

18 Dec '04

BTW, I have a CVS-Wine from friday evening. First occurence: trace:ver:GetFileVersionInfoA ("c: \\windows\\system\\SHDOCVW.DLL",0,size=848,data=0x40432bd8) trace:ver:VERSION_GetFileVersionInfo_PE L"c:\\windows\\system\\SHDOCVW.DLL" trace:ver:print_vffi_debug structversion=1.0, fileversion=5.50.0.0, productversion=5.50.0.0, flagmask=0x0, flags= trace:ver:print_vffi_debug ( OS=0x0.0x0 UNKNOWN(0x0),BASE) trace:ver:print_vffi_debug filetype=DLL, trace:ver:print_vffi_debug filedata=0x0.0x0 But I have no such DLL there(It's set in the config file to builtin) Second: trace:ver:VERSION_GetLinkedDllVersion L"MSVCRT.dll": 06.00/04.00/00.00/04.00 trace:ver:VERSION_GetLinkedDllVersion 06.16/04.00/07.00/04.00 fixme:ver:VERSION_GetLinkedDllVersion Unknown EXE OS version 4.0, please report !! trace:ver:RtlGetVersion <-- Windows 98 (L" A ") hmmm. I remember having copied it from my win98 Installation(It is set in my config file to native,builtin . The complete trace: sifff@Skynet:~> wine mp71.exe trace:ver:VERSION_Init getting version from L"AppDefaults\\mp71.exe\\Version" trace:ver:VERSION_Init getting default version trace:ver:VERSION_GetLinkedDllVersion L"mp71.exe": 05.0c/05.00/05.00/04.00 trace:ver:VERSION_GetLinkedDllVersion 05.0c/05.00/05.00/04.00 trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:GetFileVersionInfoSizeW (L"c: \\windows\\system\\SHDOCVW.DLL",0x4096fba0) trace:ver:VERSION_GetFileVersionInfo_PE L"c:\\windows\\system\\SHDOCVW.DLL" trace:ver:print_vffi_debug structversion=1.0, fileversion=5.50.0.0, productversion=5.50.0.0, flagmask=0x0, flags= trace:ver:print_vffi_debug ( OS=0x0.0x0 UNKNOWN(0x0),BASE) trace:ver:print_vffi_debug filetype=DLL, trace:ver:print_vffi_debug filedata=0x0.0x0 trace:ver:GetFileVersionInfoA ("c: \\windows\\system\\SHDOCVW.DLL",0,size=848,data=0x40432bd8) trace:ver:VERSION_GetFileVersionInfo_PE L"c:\\windows\\system\\SHDOCVW.DLL" trace:ver:print_vffi_debug structversion=1.0, fileversion=5.50.0.0, productversion=5.50.0.0, flagmask=0x0, flags= trace:ver:print_vffi_debug ( OS=0x0.0x0 UNKNOWN(0x0),BASE) trace:ver:print_vffi_debug filetype=DLL, trace:ver:print_vffi_debug filedata=0x0.0x0 trace:ver:ConvertVersionInfo32To16 Converting 0x40432bd8 to 0x40432bd8 trace:ver:ConvertVersionInfo32To16 wLength 848, wValueLength 52, bText0, value 0x40432c00, child 0x40432c34 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432bde to 0x40432bdc: "VS_VERSION_INFO" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432c00 to 0x40432bec: 52 bytes trace:ver:ConvertVersionInfo32To16 Converting 0x40432c34 to 0x40432c20 trace:ver:ConvertVersionInfo32To16 wLength 688, wValueLength 0, bText 0, value 0x40432c58, child 0x40432c58 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432c3a to 0x40432c24: "StringFileInfo" trace:ver:ConvertVersionInfo32To16 No value present trace:ver:ConvertVersionInfo32To16 Converting 0x40432c58 to 0x40432c34 trace:ver:ConvertVersionInfo32To16 wLength 652, wValueLength 0, bText 0, value 0x40432c70, child 0x40432c70 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432c5e to 0x40432c38: "040904E4" trace:ver:ConvertVersionInfo32To16 No value present trace:ver:ConvertVersionInfo32To16 Converting 0x40432c70 to 0x40432c44 trace:ver:ConvertVersionInfo32To16 wLength 52, wValueLength 10, bText 1, value 0x40432c90, child 0x40432ca4 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432c76 to 0x40432c48: "CompanyName" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432c90 to 0x40432c54: "Wine Team" trace:ver:ConvertVersionInfo32To16 Finished, length is 28 (0x40432c44 - 0x40432c60) trace:ver:ConvertVersionInfo32To16 Converting 0x40432ca4 to 0x40432c60 trace:ver:ConvertVersionInfo32To16 wLength 68, wValueLength 14, bText 1, value 0x40432ccc, child 0x40432ce8 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432caa to 0x40432c64: "FileDescription" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432ccc to 0x40432c74: "Wine core dll" trace:ver:ConvertVersionInfo32To16 Finished, length is 36 (0x40432c60 - 0x40432c84) trace:ver:ConvertVersionInfo32To16 Converting 0x40432ce8 to 0x40432c84 trace:ver:ConvertVersionInfo32To16 wLength 50, wValueLength 9, bText 1, value 0x40432d08, child 0x40432d1c trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432cee to 0x40432c88: "FileVersion" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432d08 to 0x40432c94: "5.50.0.0" trace:ver:ConvertVersionInfo32To16 Finished, length is 28 (0x40432c84 - 0x40432ca0) trace:ver:ConvertVersionInfo32To16 Converting 0x40432d1c to 0x40432ca0 trace:ver:ConvertVersionInfo32To16 wLength 34, wValueLength 1, bText 1, value 0x40432d3c, child 0x40432d40 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432d22 to 0x40432ca4: "InternalName" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432d3c to 0x40432cb4: "" trace:ver:ConvertVersionInfo32To16 Finished, length is 24 (0x40432ca0 - 0x40432cb8) trace:ver:ConvertVersionInfo32To16 Converting 0x40432d40 to 0x40432cb8 trace:ver:ConvertVersionInfo32To16 wLength 220, wValueLength 92, bText1, value 0x40432d64, child 0x40432e1c trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432d46 to 0x40432cbc: "LegalCopyright" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432d64 to 0x40432ccc: "Copyright (c) 1993-2004 the Wine project authors (see the file AUTHORS for a complete list)" trace:ver:ConvertVersionInfo32To16 Finished, length is 112 (0x40432cb8- 0x40432d28) trace:ver:ConvertVersionInfo32To16 Converting 0x40432e1c to 0x40432d28 trace:ver:ConvertVersionInfo32To16 wLength 64, wValueLength 12, bText 1, value 0x40432e44, child 0x40432e5c trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432e22 to 0x40432d2c: "OriginalFilename" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432e44 to 0x40432d40: "shdocvw.dll" trace:ver:ConvertVersionInfo32To16 Finished, length is 36 (0x40432d28 - 0x40432d4c) trace:ver:ConvertVersionInfo32To16 Converting 0x40432e5c to 0x40432d4c trace:ver:ConvertVersionInfo32To16 wLength 42, wValueLength 5, bText 1, value 0x40432e7c, child 0x40432e88 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432e62 to 0x40432d50: "ProductName" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432e7c to 0x40432d5c: "Wine" trace:ver:ConvertVersionInfo32To16 Finished, length is 24 (0x40432d4c - 0x40432d64) trace:ver:ConvertVersionInfo32To16 Converting 0x40432e88 to 0x40432d64 trace:ver:ConvertVersionInfo32To16 wLength 46, wValueLength 5, bText 1, value 0x40432eac, child 0x40432eb8 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432e8e to 0x40432d68: "ProductVersion" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432eac to 0x40432d78: "5.50" trace:ver:ConvertVersionInfo32To16 Finished, length is 28 (0x40432d64 - 0x40432d80) trace:ver:ConvertVersionInfo32To16 Converting 0x40432eb8 to 0x40432d80 trace:ver:ConvertVersionInfo32To16 wLength 42, wValueLength 1, bText 1, value 0x40432ee0, child 0x40432ee4 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432ebe to 0x40432d84: "OLESelfRegister" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432ee0 to 0x40432d94: "" trace:ver:ConvertVersionInfo32To16 Finished, length is 24 (0x40432d80 - 0x40432d98) trace:ver:ConvertVersionInfo32To16 Finished, length is 356 (0x40432c34- 0x40432d98) trace:ver:ConvertVersionInfo32To16 Finished, length is 376 (0x40432c20- 0x40432d98) trace:ver:ConvertVersionInfo32To16 Converting 0x40432ee4 to 0x40432d98 trace:ver:ConvertVersionInfo32To16 wLength 68, wValueLength 0, bText 0, value 0x40432f04, child 0x40432f04 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432eea to 0x40432d9c: "VarFileInfo" trace:ver:ConvertVersionInfo32To16 No value present trace:ver:ConvertVersionInfo32To16 Converting 0x40432f04 to 0x40432da8 trace:ver:ConvertVersionInfo32To16 wLength 36, wValueLength 4, bText 0, value 0x40432f24, child 0x40432f28 trace:ver:ConvertVersionInfo32To16 Copied key from 0x40432f0a to 0x40432dac: "Translation" trace:ver:ConvertVersionInfo32To16 Copied value from 0x40432f24 to 0x40432db8: 4 bytes trace:ver:ConvertVersionInfo32To16 Finished, length is 20 (0x40432da8 - 0x40432dbc) trace:ver:ConvertVersionInfo32To16 Finished, length is 36 (0x40432d98 - 0x40432dbc) trace:ver:ConvertVersionInfo32To16 Finished, length is 484 (0x40432bd8- 0x40432dbc) trace:ver:VerQueryValueA (0x40432bd8,"\\",0x4096fbac,0x4096fb9c) trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") fixme:font:load_VDMX No suitable ratio found fixme:font:load_VDMX No suitable ratio found fixme:font:load_VDMX No suitable ratio found trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:VERSION_Init getting version from L"AppDefaults\\setup_wm.exe\\Version" trace:ver:VERSION_Init getting default version trace:ver:VERSION_GetLinkedDllVersion L"setup_wm.exe": 06.16/04.00/07.00/04.00 trace:ver:VERSION_GetLinkedDllVersion L"MSVCRT.dll": 06.00/04.00/00.00/04.00 trace:ver:VERSION_GetLinkedDllVersion 06.16/04.00/07.00/04.00 fixme:ver:VERSION_GetLinkedDllVersion Unknown EXE OS version 4.0, please report !! trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:GetFileVersionInfoSizeW (L"c: \\windows\\system\\msdxm.ocx",0x4097f408) trace:ver:VERSION_GetFileVersionInfo_PE L"c:\\windows\\system\\msdxm.ocx" trace:ver:print_vffi_debug structversion=1.0, fileversion=6.4.7.1112,productversion=6.4.7.1112, flagmask=0x30003f, flags= trace:ver:print_vffi_debug ( OS=0x0.0x4 UNKNOWN(0x0),WIN32) trace:ver:print_vffi_debug filetype=DLL, trace:ver:print_vffi_debug filedata=0x0.0x0 trace:ver:GetFileVersionInfoA ("c: \\windows\\system\\msdxm.ocx",0,size=900,data=0x41f316f0) trace:ver:VERSION_GetFileVersionInfo_PE L"c:\\windows\\system\\msdxm.ocx" trace:ver:print_vffi_debug structversion=1.0, fileversion=6.4.7.1112,productversion=6.4.7.1112, flagmask=0x30003f, flags= trace:ver:print_vffi_debug ( OS=0x0.0x4 UNKNOWN(0x0),WIN32) trace:ver:print_vffi_debug filetype=DLL, trace:ver:print_vffi_debug filedata=0x0.0x0 trace:ver:ConvertVersionInfo32To16 Converting 0x41f316f0 to 0x41f316f0 trace:ver:ConvertVersionInfo32To16 wLength 900, wValueLength 52, bText0, value 0x41f31718, child 0x41f3174c trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f316f6 to 0x41f316f4: "VS_VERSION_INFO" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f31718 to 0x41f31704: 52 bytes trace:ver:ConvertVersionInfo32To16 Converting 0x41f3174c to 0x41f31738 trace:ver:ConvertVersionInfo32To16 wLength 740, wValueLength 0, bText 1, value 0x41f31770, child 0x41f31770 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f31752 to 0x41f3173c: "StringFileInfo" trace:ver:ConvertVersionInfo32To16 No value present trace:ver:ConvertVersionInfo32To16 Converting 0x41f31770 to 0x41f3174c trace:ver:ConvertVersionInfo32To16 wLength 704, wValueLength 0, bText 1, value 0x41f31788, child 0x41f31788 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f31776 to 0x41f31750: "040904E4" trace:ver:ConvertVersionInfo32To16 No value present trace:ver:ConvertVersionInfo32To16 Converting 0x41f31788 to 0x41f3175c trace:ver:ConvertVersionInfo32To16 wLength 76, wValueLength 22, bText 1, value 0x41f317a8, child 0x41f317d4 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f3178e to 0x41f31760: "CompanyName" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f317a8 to 0x41f3176c: "Microsoft Corporation" trace:ver:ConvertVersionInfo32To16 Finished, length is 40 (0x41f3175c - 0x41f31784) trace:ver:ConvertVersionInfo32To16 Converting 0x41f317d4 to 0x41f31784 trace:ver:ConvertVersionInfo32To16 wLength 118, wValueLength 39, bText1, value 0x41f317fc, child 0x41f3184c trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f317da to 0x41f31788: "FileDescription" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f317fc to 0x41f31798: "Windows Media Player 2 ActiveX Control" trace:ver:ConvertVersionInfo32To16 Finished, length is 60 (0x41f31784 - 0x41f317c0) trace:ver:ConvertVersionInfo32To16 Converting 0x41f3184c to 0x41f317c0 trace:ver:ConvertVersionInfo32To16 wLength 56, wValueLength 12, bText 1, value 0x41f3186c, child 0x41f31884 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f31852 to 0x41f317c4: "FileVersion" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f3186c to 0x41f317d0: "6.4.07.1112" trace:ver:ConvertVersionInfo32To16 Finished, length is 28 (0x41f317c0 - 0x41f317dc) trace:ver:ConvertVersionInfo32To16 Converting 0x41f31884 to 0x41f317dc trace:ver:ConvertVersionInfo32To16 wLength 52, wValueLength 10, bText 1, value 0x41f318a4, child 0x41f318b8 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f3188a to 0x41f317e0: "InternalName" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f318a4 to 0x41f317f0: "MSDXM.OCX" trace:ver:ConvertVersionInfo32To16 Finished, length is 32 (0x41f317dc - 0x41f317fc) trace:ver:ConvertVersionInfo32To16 Converting 0x41f318b8 to 0x41f317fc trace:ver:ConvertVersionInfo32To16 wLength 116, wValueLength 40, bText1, value 0x41f318dc, child 0x41f3192c trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f318be to 0x41f31800: "LegalCopyright" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f318dc to 0x41f31810: "Copyright (C) 1992-1999 Microsoft Corp." trace:ver:ConvertVersionInfo32To16 Finished, length is 60 (0x41f317fc - 0x41f31838) trace:ver:ConvertVersionInfo32To16 Converting 0x41f3192c to 0x41f31838 trace:ver:ConvertVersionInfo32To16 wLength 60, wValueLength 10, bText 1, value 0x41f31954, child 0x41f31968 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f31932 to 0x41f3183c: "OriginalFilename" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f31954 to 0x41f31850: "MSDXM.OCX" trace:ver:ConvertVersionInfo32To16 Finished, length is 36 (0x41f31838 - 0x41f3185c) trace:ver:ConvertVersionInfo32To16 Converting 0x41f31968 to 0x41f3185c trace:ver:ConvertVersionInfo32To16 wLength 54, wValueLength 11, bText 1, value 0x41f31988, child 0x41f319a0 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f3196e to 0x41f31860: "ProductName" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f31988 to 0x41f3186c: "DirectShow" trace:ver:ConvertVersionInfo32To16 Finished, length is 28 (0x41f3185c - 0x41f31878) trace:ver:ConvertVersionInfo32To16 Converting 0x41f319a0 to 0x41f31878 trace:ver:ConvertVersionInfo32To16 wLength 60, wValueLength 12, bText 1, value 0x41f319c4, child 0x41f319dc trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f319a6 to 0x41f3187c: "ProductVersion" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f319c4 to 0x41f3188c: "6.4.07.1112" trace:ver:ConvertVersionInfo32To16 Finished, length is 32 (0x41f31878 - 0x41f31898) trace:ver:ConvertVersionInfo32To16 Converting 0x41f319dc to 0x41f31898 trace:ver:ConvertVersionInfo32To16 wLength 42, wValueLength 7, bText 1, value 0x41f319f8, child 0x41f31a08 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f319e2 to 0x41f3189c: "DirectShow" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f319f8 to 0x41f318a8: "Filter" trace:ver:ConvertVersionInfo32To16 Finished, length is 24 (0x41f31898 - 0x41f318b0) trace:ver:ConvertVersionInfo32To16 Converting 0x41f31a08 to 0x41f318b0 trace:ver:ConvertVersionInfo32To16 wLength 40, wValueLength 0, bText 1, value 0x41f31a30, child 0x41f31a30 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f31a0e to 0x41f318b4: "OLESelfRegister" trace:ver:ConvertVersionInfo32To16 No value present trace:ver:ConvertVersionInfo32To16 Finished, length is 20 (0x41f318b0 - 0x41f318c4) trace:ver:ConvertVersionInfo32To16 Finished, length is 376 (0x41f3174c- 0x41f318c4) trace:ver:ConvertVersionInfo32To16 Finished, length is 396 (0x41f31738- 0x41f318c4) trace:ver:ConvertVersionInfo32To16 Converting 0x41f31a30 to 0x41f318c4 trace:ver:ConvertVersionInfo32To16 wLength 68, wValueLength 0, bText 1, value 0x41f31a50, child 0x41f31a50 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f31a36 to 0x41f318c8: "VarFileInfo" trace:ver:ConvertVersionInfo32To16 No value present trace:ver:ConvertVersionInfo32To16 Converting 0x41f31a50 to 0x41f318d4 trace:ver:ConvertVersionInfo32To16 wLength 36, wValueLength 4, bText 0, value 0x41f31a70, child 0x41f31a74 trace:ver:ConvertVersionInfo32To16 Copied key from 0x41f31a56 to 0x41f318d8: "Translation" trace:ver:ConvertVersionInfo32To16 Copied value from 0x41f31a70 to 0x41f318e4: 4 bytes trace:ver:ConvertVersionInfo32To16 Finished, length is 20 (0x41f318d4 - 0x41f318e8) trace:ver:ConvertVersionInfo32To16 Finished, length is 36 (0x41f318c4 - 0x41f318e8) trace:ver:ConvertVersionInfo32To16 Finished, length is 504 (0x41f316f0- 0x41f318e8) trace:ver:VerQueryValueA (0x41f316f0,"\\",0x4097f430,0x4097f410) fixme:propsheet:PROPSHEET_UnImplementedFlags PSH_RTLREADING fixme:font:load_VDMX No suitable ratio found trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") fixme:font:load_VDMX No suitable ratio found trace:ver:RtlGetVersion <-- Windows 98 (L" A ") fixme:font:load_VDMX No suitable ratio found trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") fixme:ole:CoCreateInstance no classfactory created for CLSID {cfc399af-d876-11d0-9c10-00c04fc99c8e}, hres is 0x80040154 trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:ver:RtlGetVersion <-- Windows 98 (L" A ") fixme:ole:CoCreateInstance no classfactory created for CLSID {cfc399af-d876-11d0-9c10-00c04fc99c8e}, hres is 0x80040154 trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4")

1 0

Encrypted document
by Rklazes 18 Dec '04

18 Dec '04

1 0

RE: Incoming Msg
by Rklazes 18 Dec '04

18 Dec '04

1 0

Re: Document
by M.hearn 18 Dec '04

18 Dec '04

1 0

MFC app and WineLib
by Serge S. Spiridonoff 17 Dec '04

17 Dec '04

Hi, When porting an MFC app to Linux using WineLib is it really necessary to recompile the MFC DLL from source? Can I take MFC42.dll from Windows and use it "as is" with an application compiled with WineLib? Thanks, Serge

3 4

Re: [dplobby.h] Define DirectPlayLobbyCreate with respect unicode
by Vincent Béron 17 Dec '04

17 Dec '04

Le ven 17/12/2004 à 11:20, Peter Berg Larsen a écrit : > > There might be a better way but I dont know it. > > Changelog: > Defines DirectPlayLobbyCreate to be either the W or A version depending > on the UNICODE. Needed for warzone 2100. > > Peter > > diff -u -r wine-20041201-org/include/dplobby.h wine-20041201/include/dplobby.h > --- wine-20041201-org/include/dplobby.h 2004-10-05 06:38:15.000000000 +0200 > +++ wine-20041201/include/dplobby.h 2004-12-12 11:45:00.000000000 +0100 > @@ -342,7 +342,11 @@ > > } DPAPPLICATIONDESC, *LPDPAPPLICATIONDESC; > > - > +#ifdef UNICODE > +# define DirectPlayLobbyCreate DirectPlayLobbyCreateW > +#else > +# define DirectPlayLobbyCreate DirectPlayLobbyCreateA > +#endif > > extern HRESULT WINAPI DirectPlayLobbyCreateW(LPGUID, LPDIRECTPLAYLOBBY*, IUnknown*, LPVOID, DWORD ); > extern HRESULT WINAPI DirectPlayLobbyCreateA(LPGUID, LPDIRECTPLAYLOBBYA*, IUnknown*, LPVOID, DWORD ); Use #define DirectPlayLobbyCreate WINELIB_NAME_AW(DirectPlayLobbyCreate) after the W and A declarations. That's the standard way in Wine of doing it. Vincent

1 0

Possible bug in Wine 20041201
by Ira Krakow 17 Dec '04

17 Dec '04

I did a fresh install of Wine from the Winehq CVS repository. I got the following message during the install: fixme:ver:VERSION_GetLinkedDllVersion Unknown EXE OS version 1.0, please report!! I checked bugzilla and didn't see that this bug is tracked. So I'm following instructions, and reporting it. The Wine version is 20041201. My computer is a Dell Dimension 4100 Pentium 3. I'm running Fedora Core 2. Is this a bug? If so, is there a patch for it? Should this be tracked? Ira Krakow ikrakow_1999(a)yahoo.com

2 3

Problems unveiled by the last version.c patch
by pvriens＠xs4all.nl 17 Dec '04

17 Dec '04

Hi, just started with a fresh wine install from CVS. I've tried to install vc6redistsetup_enu.exe and was not able to select a directory via the browse dialog. Some regression testing and debugging showed: before patch http://cvs.winehq.org/patch.py?id=14894 : trace:shell:BrsFolderDlgProc hwnd=0x1002e msg=0082 0x00000000 0x00000000 trace:shell:SHGetPathFromIDListAW (pidl=0x63f4f5b8,0x100b720) trace:ver:RtlGetVersion <-- Windows 98 (L" A ") trace:shell:SHGetPathFromIDListA (pidl=0x63f4f5b8,0x100b720) -------- pidl=0x63f4f5b8 [0x63f4f5b8] size=0020 type=1f attr=0x00000000 name="{20d04fe0-3aea-1069-a2d8-08002b30309d}" ((null),(null)) [0x63f4f5cc] size=0025 type=23 attr=0x00000000 name="F:\" ("F:\\",(null)) [0x63f4f5e5] size=0020 type=31 attr=0x00000010 name="temp" ("temp","") trace:pidl:_ILIsValue (0x63f4f5b8) trace:pidl:_ILIsFolder (0x63f4f5b8) trace:pidl:_ILGetGUIDPointer 0x63f4f5b8 trace:pidl:_ILGetGUIDPointer pdata->type 0x001f trace:pidl:_ILIsMyComputer (0x63f4f5b8) trace:pidl:ILGetNext 0x63f4f5b8 trace:pidl:ILGetNext -- 0x63f4f5cc trace:pidl:_ILIsSpecialFolder (0x63f4f5cc) trace:pidl:ILGetNext 0x63f4f5cc trace:pidl:ILGetNext -- 0x63f4f5e5 trace:shell:PathAddBackslashA ("F:\\") trace:pidl:_ILIsSpecialFolder (0x63f4f5e5) trace:pidl:ILGetNext 0x63f4f5e5 trace:pidl:ILGetNext -- 0x63f4f5f9 trace:shell:SHELL_GetPathFromIDListA -- F:\temp, 0x00000000 after the patch : trace:shell:BrsFolderDlgProc hwnd=0x1002e msg=0082 0x00000000 0x00000000 trace:shell:SHGetPathFromIDListAW (pidl=0x77e2dbe8,0x100b720) trace:ver:RtlGetVersion <-- Windows 2000 (L"Service Pack 4") trace:shell:SHGetPathFromIDListW (pidl=0x77e2dbe8,0x3f0472b4) -------- pidl=0x77e2dbe8 [0x77e2dbe8] size=0020 type=1f attr=0x00000000 name="{20d04fe0-3aea-1069-a2d8-08002b30309d}" ((null),(null)) [0x77e2dbfc] size=0025 type=23 attr=0x00000000 name="F:\" ("F:\\",(null)) [0x77e2dc15] size=0020 type=31 attr=0x00000010 name="temp" ("temp","") trace:pidl:_ILIsValue (0x77e2dbe8) trace:pidl:_ILIsFolder (0x77e2dbe8) trace:pidl:_ILGetGUIDPointer 0x77e2dbe8 trace:pidl:_ILGetGUIDPointer pdata->type 0x001f trace:pidl:_ILIsMyComputer (0x77e2dbe8) trace:pidl:ILGetNext 0x77e2dbe8 trace:pidl:ILGetNext -- 0x77e2dbfc trace:pidl:_ILIsSpecialFolder (0x77e2dbfc) trace:pidl:ILGetNext 0x77e2dbfc trace:pidl:ILGetNext -- 0x77e2dc15 trace:shell:PathAddBackslashW (L"F:\\") trace:pidl:_ILIsSpecialFolder (0x77e2dc15) trace:pidl:ILGetNext 0x77e2dc15 trace:pidl:ILGetNext -- 0x77e2dc29 trace:shell:SHELL_GetPathFromIDListW -- L"F:\\temp", 0x00000000 trace:shell:SHGetPathFromIDListW -- L"F:\\temp", 0x00000000 The main difference (apart from the A/W) is that SHGetPathFromIDListW returns an extra backslash compared to the A-counterpart. Any idea where to look next ? Cheers, Paul.

5 6

Re: Advapi32/service.c fix
by Dmitry Timoshkov 17 Dec '04

17 Dec '04

"Ivan Leo Puoti" <puoti(a)inwind.it> wrote: > - if( strcmpiW( lpDatabaseName, SERVICES_ACTIVE_DATABASEW ) == 0 ) > + if( (strcmpiW(lpDatabaseName, SERVICES_ACTIVE_DATABASEW)==0) || (lpDatabaseName[0]==(INT)NULL)) It's much simpler to use either !lpDatabaseName[0] or lpDatabaseName[0] == 0 instead of several levels of casting. -- Dmitry.

1 0

Build problems with GL_VERSION_1_2
by Bill Medland 17 Dec '04

17 Dec '04

(Jason?) Currently (after many weeks without concentrating) wine doesn't build; it fails in dlls/wined3d/drawprim.c line 594 with GL_TEXTURE0 undefined. That's because of the definition of GL_MULTITEXCOORD... in wined3d_private.h for the non-GL_VERSION_1_3 case. I can see a linguistically obvious fix that gets me thorugh the compilation but since I haven't the faintest idea about d3d and GL I don't know if it is correct, so I won't submit it. -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

2 2

Hang in usr1_handler (ptrace issue?)
by Mike Hearn 17 Dec '04

17 Dec '04

Hi, Lately I've been seeing hangs of this form: Backtrace: =>1 0x4df8e7a2 (0x659ffb54) 2 0x5246f507 NTDLL_wait_for_multiple_objects+0x387(count=0x0, handles=0x0, flags=0x8, timeout=0x659ffd10) [/source/wine/dlls/ntdll/sync.c:683] in ntdll (0x659ffcf8) 3 0x5246da88 usr1_handler+0x38(__signal=0xa, __context=0x33) [/source/wine/dlls/ntdll/signal_i386.c:1159] in ntdll (0x659ffd1c) 4 0x100238a8 (0x65bfc6cc) 5 0x5246f507 NTDLL_wait_for_multiple_objects+0x387(count=0x1, handles=0x65bfc8bc, flags=0x4, timeout=0x0) [/source/wine/dlls/ntdll/sync.c:683] in ntdll (0x65bfc870) 6 0x5246f5df NtWaitForMultipleObjects+0x4b(count=0x1, handles=0x65bfc8bc, wait_all=0x0, alertable=0x0, timeout=0x0) [/source/wine/dlls/ntdll/sync.c:713] in ntdll (0x65bfc898) 7 0x1894e4b3 WaitForMultipleObjectsEx+0xa3(count=0x1, handles=0x65bfc9f0, wait_all=0x0, timeout=0xffffffff, alertable=0x0) [/source/wine/dlls/kernel/sync.c:180] in kernel32 (0x65bfc9c8) in other words, whilst waiting on some server object it was suspended. I am running the FC3 kernel "2.6.9-1.681_FC3". Is this what the previously discussed ptrace change would look like? If so I may need to ask Red Hat to do an errata or something. I saw that in 2.6.10-rc3 another ptrace change went in, so it may be that it's now fixed. thanks -mike

4 5

Re: PATCH: dlls/oleaut32/tests/vartype.c
by Robert Shearman 16 Dec '04

16 Dec '04

Marcus Meissner wrote: >Hi, > >This fixes the currently last gcc4 problem. > >I had to split up MSVC / non-MSVC cases since glibc/sprintf >and msvcrt/sprintf disagree on how to print out 64bit integers. > > If you don't use the macro then you can use wine_dbgstr_longlong and not have to worry about compiler differences. Rob

1 0

<<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive
by Robert van Herk 16 Dec '04

16 Dec '04

Hi, I had some problems with my mail server, so I send in this patch again. If the previous one did arrive, please ignore this e-mail. ------------------------------------------------------------------------ Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed just for picking a Windows folder, was split up. It was to be found in brsfolder.c, but I split this in: brsfolder.c brsfolder.h brsfolder_windows.c brsfolder_windows.h brsfolder_unix.c brsfolder_unix.h unixTools.c unixTools.h, Otherwise I found the code to be incomprehendible. Furthermore, winecfg now uses the wine_shell_browse_for_UNIX_directoryA to let the user pick a UNIX directory as root for his virtual drive mappings. Regards, Robert van Herk

8 15

Re: Stubs in PE build
by Jon Griffiths 16 Dec '04

16 Dec '04

Hi, I had a patch which enabled stub generation for building native dlls last year (http://www.winehq.org/hypermail/wine-patches/2003/07/0176.html), that part was not accepted for the same reasons that are being mentioned in this thread. I would like to point out again that the VC linker will not generate a correct dll unless the ordinal stubs are present. Other native linkers may have the same problem. It seems very silly to me that we can't use M$'s own compiler/linker to build valid dlls (especially since these tools can be downloaded for free these days). M$ defined the dll format we are using, after all. If this is intentional, perhaps we should document it somewhere? Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

3 6

Re: Definition of IMessageFilter in objidl.h
by Dmitry Timoshkov 16 Dec '04

16 Dec '04

"Serge S. Spiridonoff" <sss(a)corbina.net> wrote: > Well, I've just noticed the following record in the ChangeLog... > > * include/objidl.h, include/objidl.idl: > Jake Hamby <jhamby(a)anobject.com> > IMessageFilter::HandleInComingCall() should be HandleIncomingCall(). > > Also, http://cvs.winehq.org/patch.py?id=12310 > > So I'm a bit confused now!? Since I'm new to Wine I'd like someone more > experienced to judge this collision. Apparently the patch above is wrong since microsoft headers have it in different case. The patch should be reverted. If you could send a patch which just reverts the above change that would be great. -- Dmitry.

1 0

dlls/gdi/tests/metafile.c warning about test_mf_PatternBrush
by Gerald Pfeifer 16 Dec '04

16 Dec '04

The following patch to dlls/gdi/tests/metafile.c revision 1.3 date: 2004/12/09 11:37:59; author: julliard; state: Exp; lines: +236 -0 Walt Ogburn <reuben(a)ugcs.caltech.edu> Added some tests for win-format metafiles. introduces the following warning: metafile.c:381: warning: `test_mf_PatternBrush' defined but not used Should we put #ifdefs around the definition, or enable the following code in the main test function? /* Crashes under wine: */ /* test_mf_PatternBrush(); */ Another option would be not to make this function static. Gerald

5 5

Re: Definition of IMessageFilter in objidl.h
by Dmitry Timoshkov 16 Dec '04

16 Dec '04

"Serge S. Spiridonoff" <sss(a)corbina.net> wrote: > IMessageFilter::HandleInComingCall is defined as HandleIncomingCall in > include/wine/windows/objidl.h (.idl) > Note the capital 'C' in 'InComing' in MS headers. > Is it a misprint? Yes. Please send a patch. -- Dmitry.

2 1

Definition of IMessageFilter in objidl.h
by Serge S. Spiridonoff 15 Dec '04

15 Dec '04

Hi, IMessageFilter::HandleInComingCall is defined as HandleIncomingCall in include/wine/windows/objidl.h (.idl) Note the capital 'C' in 'InComing' in MS headers. Is it a misprint? Thanks

1 0

Re: Should we get rid of the wine-license list?
by Ivan Leo Puoti 15 Dec '04

15 Dec '04

> OK, I'll take it down. Shall I remove the archives as well? Or simply > leave them for historical type purposes? IMHO we should keep the archives. Ivan. ____________________________________________________________ Regala e regalati Libero ADSL: 3 mesi gratis, navighi veloce e scarichi a 1.2 Mega. Abbonati subito senza costi di attivazione su http://www.libero.it

1 0

State of the Msi
by Aric Stewart 15 Dec '04

15 Dec '04

Hi all, Long time no post :) I just wanted to give an update that Mike M. and I have done alot of msi work over the first few weeks of December which caused a few significant changes to particularly action.c where we eliminated many of the static buffers for file paths and replaced them with dynamic buffers. Vitaly Lipatov's patchs reminded me that i should probably give you all a heads up about that. We where going to break them down and start submitting them but then Mike went off and got married and is on his Honeymoon. So when he gets back we are going to either break the changes down into smaller patches or try to get Alexandre to approve a big one. I will start trying to get some of the smaller ones broken down and submitted in the meantime. Vitaly Lipatov's patchs do not directly conflict with anything so we are just fine there. I will work them into our tree so that i can be sure they are not lost. But if anyone else is also doing msi work you may want to check in here so that we can make sure it all fits together ok. Thanks, -aric

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti 15 Dec '04

15 Dec '04

Upon further review, the patch works. Stupid me. William

1 0

Re: Include file cleanup : dce.h
by Alexandre Julliard 15 Dec '04

15 Dec '04

Rémi Assailly <remi.assailly(a)free.fr> writes: > Changelog: > * get rid of dce.h > --- dlls/x11drv/winpos.c 2004-12-09 19:10:35.000000000 +0100 > +++ dlls/x11drv/winpos.c 2004-12-11 19:46:03.000000000 +0100 > @@ -40,7 +40,6 @@ > #include "x11drv.h" > #include "win.h" > #include "winpos.h" > -#include "dce.h" > #include "cursoricon.h" > #include "nonclient.h" > > @@ -49,6 +48,8 @@ > > WINE_DEFAULT_DEBUG_CHANNEL(x11drv); > > +extern BOOL DCE_InvalidateDCE( HWND, const RECT* ); The goal of the header files cleanup is not to mechanically remove the #includes by duplicating the definitions, if we wanted to do that it would have been done long ago. The real goal is to get rid of the inter-dll dependencies, the global headers are really just a symptom of the problem. -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [winelib] Can't figure out a Winemaker error
by Michael Jung 15 Dec '04

15 Dec '04

Scott, On Wednesday 15 December 2004 06:32, Scott Ritchie wrote: > Global symbol "%directories" requires explicit package name > at /usr/bin/winemaker line 423. > Global symbol "%directories" requires explicit package name > at /usr/bin/winemaker line 441. > Execution of /usr/bin/winemaker aborted due to compilation errors. > > What's going on here? Did I screw something up, or was this broken in > that release? This is with the December release. This is a problem, which seems to have been introduced in the december release and which is already fixed in cvs. If you don't want to use cvs you can just patch the winemaker script: Move the "my %directories" global variable declaration (somewhere around line 1060) above the "get_directory_contents" function declaration (ca. line 400). Ciao, Michael

1 0

[winelib] Can't figure out a Winemaker error
by Scott Ritchie 15 Dec '04

15 Dec '04

As part of my effort to create a successful demonstration of how to port something, I tried out winelib. Unfortunately, I can't seem to get it working at all. I get this error whenever I run winemaker: Global symbol "%directories" requires explicit package name at /usr/bin/winemaker line 423. Global symbol "%directories" requires explicit package name at /usr/bin/winemaker line 441. Execution of /usr/bin/winemaker aborted due to compilation errors. What's going on here? Did I screw something up, or was this broken in that release? This is with the December release. Thanks, Scott Ritchie

2 1

Re: PATCH: revive FreeBSD support
by Alexandre Julliard 14 Dec '04

14 Dec '04

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > --- dlls/ntdll/virtual.c 11 Oct 2004 20:59:06 -0000 1.41 > +++ dlls/ntdll/virtual.c 3 Dec 2004 04:06:42 -0000 > @@ -119,6 +119,12 @@ static CRITICAL_SECTION csVirtual = { &c > /* Note: these are Windows limits, you cannot change them. */ > # define ADDRESS_SPACE_LIMIT ((void *)0xc0000000) /* top of the total available address space */ > # define USER_SPACE_LIMIT ((void *)0x80000000) /* top of the user address space */ > +# ifdef __FreeBSD__ > +# define LOW_SPACE_LIMIT ((void *)0x110000) /* lower address space limit */ > +# else > +# define LOW_SPACE_LIMIT NULL > +# endif > + > #else > static UINT page_shift; > static UINT page_mask; > @@ -600,7 +606,7 @@ static NTSTATUS map_view( struct file_vi > > for (;;) > { > - if ((ptr = wine_anon_mmap( NULL, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) > + if ((ptr = wine_anon_mmap( LOW_SPACE_LIMIT, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) Looks OK, but this is a job for wine_anon_mmap, it's supposed to abstract these sorts of platform dependencies so that the callers don't have to worry about it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Includes: x11drv
by Rémi Assailly 14 Dec '04

14 Dec '04

Jon Griffiths wrote : >Hi, > >x11drv: 8 includes removed. > >Cheers, >Jon > > +dlls/x11drv/text.c dlls/x11drv/window.c dlls/x11drv/winpos.c > dlls/x11drv/x11ddraw.c > Remove uneeded headers to reduce uneeded rebuilds. > > Hi Jon, As I am working on x11drv I can tell you some things : win.h is declared in x11drv.h so if you want to remove it, remove it from all files. But I think it is not a good idea : win.h is one of the header files which need to be moved so I think it is better to keep #include "win.h" where it is needed. It will be easier to find files which need definitions in win.h. For example you removed win.h from window.c which use the structure WND. I also noticed that you removed wingdi.h from x11ddraw.c. wingdi.h is declared in gdi.h which is a header file which need to be moved too ! So when we get rid of gdi.h we'll must redeclare wingdi.h in x11ddraw.c Regards Rémi

1 0

Re: Stubs in PE build
by Alexandre Julliard 14 Dec '04

14 Dec '04

Ge van Geldorp <gvg(a)reactos.com> writes: > Send for review to wine-devel: http://www.winehq.org/hypermail/wine-devel/2004/11/0658.html (no comments) > Submitted to wine-patch: http://www.winehq.org/hypermail/wine-patches/2004/11/0327.html > Resubmitting against current CVS > > Changelog: > Ge van Geldorp <gvg(a)reactos.com> > - Generate and export stubs specified in .spec files for PE builds I don't think we want to add a special mode just for stubs; they should really be replaced by proper functions (even if the functions are stubs themselves, at least they can print the parameters and try to return something meaningful instead of killing the app). You can view the lack of stubs support on PE as an encouragement to help us remove them from the spec files ;-) -- Alexandre Julliard julliard(a)winehq.org

7 13

Re: [AppDB] Remove borders=0 from img
by tony_lambregts＠telusplanet.net 14 Dec '04

14 Dec '04

Paul van Schayck wrote: > Ok, since we have img{border: 0;} in our stylesheet we can now remove > border=0 from all img elements. > > Changelog: > Remove border=0 from img tags > > A patch would be nice.. ;-) -- Tony Lambregts

1 0

"Debugging" a password dialog
by David Gümbel 14 Dec '04

14 Dec '04

Hi everybody, I am trying to get an application to run under Wine that requires a login with a username and a password. The program runs all fine, however I can't login with data that should work (and AFAIK works under Windows). Having entered the password, in the corresponding part of the dialog I only see "*****" (which is correct). However, when I change focus to some other part of that dialog afterwards, the password field shows "*************" (way more asterisks than before). The previous (i.e. correct) length of ****s is restored when setting the focus back onto the password field. I have reason to believe that the password I entered is not correctly passed on to the login procedure of the program. However, I am sort of badly lacking a nice idea how to efficiently debug this thingy and verify (falsify ;) that I'm right. So, does anybody have an idea? Bye, David

5 7

wineprefixcreate and config file
by Raul Dias 14 Dec '04

14 Dec '04

Hi, Shouldn't tools/wineprefixcreate copy a sample config file? Right now it does all the job to create a standalone wine environment, but with no config. I would suggest copying documentation/samples/config to tools/config, installing it at $(SRCDIR) and them just copying it during wineprefixcreate call. I can do that if no one disagrees with the change. Some rpms in the sourceforge does not even have the sample config file in it. -- Raul Dias

2 1

Dodgy NetBSD code in dlls/kernel/cpu.c?
by Jon Griffiths 14 Dec '04

14 Dec '04

Hi, in dlls/kernel/cpu.c, around line 430, is the following code for NetBSD: { int mib[2]; int value[2]; ... if (sysctl(mib, 2, value, value+1, NULL, 0) >= 0) if (value) PF[PF_FLOATING_POINT_EMULATED] = FALSE; else PF[PF_FLOATING_POINT_EMULATED] = TRUE; This looks dodgy, the "if (value)" test will always be true. I gather it should be "if (value[0])" or "if (value)[1]", but I'm no NetBSD guru. Also, there should be not need to set values to FALSE, since the flag array is cleared to 0 at the start of this function. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

1 0

Visual studio 6 build fix.
by Rein Klazes 14 Dec '04

14 Dec '04

Hi, MS Visual C++ v6, when invoking the compiler and other build tools does the following: create anonymous pipe; duplicate the pipes write handle; open's the file NUL calls CreateProcess starting vcspawn.exe with: startup info iohandles set to the 3 handles obtained above; the startup info flag STARTF_USESTDHANDLES set; create flag CREATE_NEW_CONSOLE set. the parent process reads from the pipe, and analyses the compiler and other messages that are obtained that way. Wine's console startup code is not really expecting this and insists on creating new stdio handles instead of inheriting them. The attached patch makes this work properly. Changelog: server : process.c dlls/kernel : console.c A starting process must obey the STARTF_USESTDHANDLES flag, even it is starting a new console. Rein. -- Rein Klazes rklazes(a)xs4all.nl

3 5

Re: Perform automatic bitmap font configuration based on the current locale
by Huw D M Davies 14 Dec '04

14 Dec '04

On Mon, Dec 13, 2004 at 11:39:58PM +0800, Dmitry Timoshkov wrote: > Hello, > > due to a GDI bug new values don't actually work, and that's another > thing I'm going to look at. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Perform automatic bitmap font configuration based on the current locale. > > diff -up cvs/hq/wine/dlls/kernel/locale.c wine/dlls/kernel/locale.c > --- cvs/hq/wine/dlls/kernel/locale.c 2004-11-22 17:52:19.000000000 +0800 > +++ wine/dlls/kernel/locale.c 2004-12-13 23:25:50.000000000 +0800 > @@ -5,6 +5,7 @@ > * Copyright 1998 David Lee Lambert > * Copyright 2000 Julio C?sar G?zquez > * Copyright 2002 Alexandre Julliard for CodeWeavers > + * Copyright 2003, 2004 Dmitry Timoshkov > * > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > @@ -226,25 +227,175 @@ inline static HKEY create_registry_key(v > { > static const WCHAR intlW[] = {'C','o','n','t','r','o','l',' ','P','a','n','e','l','\\', > 'I','n','t','e','r','n','a','t','i','o','n','a','l',0}; > - OBJECT_ATTRIBUTES attr; > - UNICODE_STRING nameW; > HKEY hkey; > > if (RtlOpenCurrentUser( KEY_ALL_ACCESS, &hkey ) != STATUS_SUCCESS) return 0; > > - attr.Length = sizeof(attr); > - attr.RootDirectory = hkey; > - attr.ObjectName = &nameW; > - attr.Attributes = 0; > - attr.SecurityDescriptor = NULL; > - attr.SecurityQualityOfService = NULL; > - RtlInitUnicodeString( &nameW, intlW ); > + return NLS_RegOpenSubKey( hkey, intlW ); > +} > > - if (NtCreateKey( &hkey, KEY_ALL_ACCESS, &attr, 0, NULL, 0, NULL ) != STATUS_SUCCESS) hkey = 0; > - NtClose( attr.RootDirectory ); > - return hkey; > +/*********************************************************************** > + * create_fonts_registry_key > + * > + * Create the HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion\\Fonts > + * registry subkey. > + */ > +inline static HKEY create_fonts_registry_key(void) > +{ > + static const WCHAR fontsW[] = { > + 'M','a','c','h','i','n','e','\\','S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\','W','i','n','d','o','w','s',' ','N','T','\\', > + 'C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\', > + 'F','o','n','t','s',0}; > + > + return NLS_RegOpenKey( 0, fontsW ); > } You should probably put them under HKLM\Software\Microsoft\Windows\CurrentVersion\Fonts too. (Or at least use this key for winver=win9x, since this is where we'll look if running in win9x mode). Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by Ivan Leo Puoti 14 Dec '04

14 Dec '04

>I just tried Ivan's patch on my program, and get the same insufficient >version >error that I was getting with the original, unpatched, version. My >original patch did not have this problem. Why don't you add a few traces to see what's going on? I've already explained that your orginal patch is wrong. Also check the versions of the dlls that the function is calling, and the winver setting. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti 14 Dec '04

14 Dec '04

I just tried Ivan's patch on my program, and get the same insufficient version error that I was getting with the original, unpatched, version. My original patch did not have this problem. William

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by Ivan Leo Puoti 13 Dec '04

13 Dec '04

> It was 4. Pehaps there is yet another bug someplace else. That's why in my updated patch I check the OS using the available info. It's here, you may want to try it out and check if it works for you app http://www.winehq.com/hypermail/wine-patches/2004/12/att-0275/01-wkivcf2.di… You patch was wrong because the fact that MajorSubsystemVersion is 4 and MinorOperatingSystemVersion is 0 doesn't mean the OS is win2k, it could be nt4 or win95, and returning win2000 when winver is set to win95 could cause problems. See http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/ba… Also it's better to use switch when comparing a variable to multiple values, it's more readable, and you added some useless braces. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

wine loader bug
by Ivan Leo Puoti 13 Dec '04

13 Dec '04

I've got this strange error wine-pthread: virtual.c:703: map_file_into_view: Assertion `start + size <= view->size' failed. Aborted the wine loader seems unable to load the binary into memory, I tried commenting out the code between line 701 and 719 with #if 0, but that just caused a few compiler warnings and a segfault. I think I'll leave this to someone more skilled than me, if you want the binary that causes this drop me a line (And no I am not posting it to the list) Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: VERSION_GetLinkedDllVersion bug fix
by William Lahti 13 Dec '04

13 Dec '04

I actually test-ran my version of the patch with VB .NET's installer, which requires 2K or higher, where the other version was only compile-tested. It fixed the problem of the installer saying that I needed WIN2K or higher. I had actually tried exactly what Andreas Mohr had before coming up with the version I submitted, and it didn't work. My config file was set to emulate XP, so I echoed what MajorSubsystemVersion was. It was 4. Pehaps there is yet another bug someplace else. William Lahti

1 0

appdb bug
by Ivan Leo Puoti 13 Dec '04

13 Dec '04

I can view the maintainers queue, and I can click on view, but I'm just redirected to the queue again and can't approve maintainers. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: A new systray patch
by Steven Edwards 13 Dec '04

13 Dec '04

Hi, --- Mike Hearn <mh(a)codeweavers.com> wrote: > - Add a wineshell process to stand in for Explorer > - Rewrite system tray code to be standards compliant Maybe we should just go ahead and call it explorer in case you plan on adding stuff later on or adapting parts of ReactOS explorer. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - Easier than ever with enhanced search. Learn more. http://info.mail.yahoo.com/mail_250

5 10

Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation
by Jonathan Gevaryahu 13 Dec '04

13 Dec '04

The CVS commit on 12/02 at 18:05:37 UTC causes the game "Total Annihilation" to cease functioning. Previously the game worked (although sounds don't work due to a seperate directsound issue), but since the aformentioned commit, the game changes resolution but does not ever display its titlescreen (it isn't invisible either, clicking where the exit button would be has no effect), and cpu usage is maxed out, suggesting an infinite loop. I did a trace using WINEDEBUG="err+all,warn+all,fixme+all,trace+ntdll,trace+kernel,trace+server" and got the following, repeated over and over with some small variation: ... 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102866572.849273 (+0.002667) , handles={0x10c} ) 000d: select() = PENDING 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000a: event_op( handle=0xc0, op=1 ) 000a: event_op() = 0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102866572.859131 (+0.005230) , handles={0x10c} ) 000d: select() = PENDING 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 0009: select( flags=4, cookie=0x4087f794, timeout=0, handles={0x10} ) 0009: select() = ACCESS_DENIED 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 ... This was tested on both normal and modified (no-CD crack) versions of total annihilation, and no difference in behavior was noted. Here is the information about the commit in question: CVS Commit 12/02 18:05:37 message: Eric Pouech <pouech-eric(a)wanadoo.fr> - moved event, semaphore, mutex implementation from kernel32 to ntdll - added mutant implementation in ntdll, and use it for mutex implementation in kernel32 - added access parameter on event, semaphore, timer creation in wineserver (as ntdll interface requires it) - added missing definitions in include/winternl.h Files modified by commit: dlls/kernel/sync.c dlls/ntdll/ntdll.spec dlls/ntdll/sync.c include/winternl.h include/wine/server_protocol.h server/event.c server/mutex.c server/protocol.def server/semaphore.c server/timer.c server/trace.c Jonathan Gevaryahu lord_nightmare(a)users.sf.net

3 5

Wine test suite (or winrash, don't know which one) - possible way to improve for some persons (with some antivirus or firewall software running)
by Tero Tamminen 13 Dec '04

13 Dec '04

Hi! I don't know if this is proper list to send this (well, I didn't find any mailinglist for the Wine test suite app and mailinglist in sf project for winrash was empty). So I thought that information would possibly reach developers of Wine test suite or winrash through this mailinglist. And as I said in the subject, I don't know if this message concerns wine test suite or winrash program or both. Because of that, I use winrash from now on, because it is much shorter to write. I have this winrash running on one of my computers, in windows 2003 server. There is a firewall program (ZoneAlarm Pro) installed to this computer. Some time ago, I upgraded Zonealarm to new version (5.5.062.004). This version has a feature, that checks if some programs are trying to execute new programs or something. It is possible to allow execution of new programs permanently (it saves directory and name of executable), but not in case of winrash. Winrahs starts its tests every time in temporary directory with new name. So every time a test starts, Zonealarm asks me if the execution of test is allowed. This is a problem for me, because it is annoying to click through all the messages, but it is also a problem for winrash, because I am not sitting in front of this computer very often and some tests might timeout because of that (and I think it has happened a couple of times already). So would it be possible to start all the tests from same directory (I mean, every version of the tests would start in same directory). It would save me some time because I wouldn't have to click through all the messages. Thanks! Tero Tamminen

4 9

Re: [AppDB] php config
by Jonathan Ernst 13 Dec '04

13 Dec '04

I forgot to mention that it should be checked if the used config.php file is using short tags (<?) if it is, it has to be replaced with longtags (<?php). thanks, -- Jonathan Ernst <Jonathan(a)ErnstFamily.ch>

2 1

Re: VERSION_GetLinkedDllVersion bug fix
by Andreas Mohr 13 Dec '04

13 Dec '04

On Mon, Dec 13, 2004 at 03:09:29PM +0100, Ivan Leo Puoti wrote: > > I fixed a bug in ntdll's VERSION_GetLinkedDllVersion which caused it to > > not be able to return any Windows version higher than WIN98. It has now been > > extended for WIN2K, WINXP, and WIN2K3. This function would eventually be > > called any time that kernel's GetVersionEx was called, which is a problem > > for any software requiring a version higher than WIN98, like Visual Basic > > .NET. > If MajorSubsystemVersion is 4 then the OS can never be win2k or higher, so your > patch can't be correct. > The attached patch should fix the bug you found. Compile tested only. Where's the FIXME message for the default case? ;) (things like this are the prime reason this version issue wasn't uncovered for such a long time!) Andreas Mohr

1 0

(LPVOID) NULL: unnecessary cast?
by Francois Gouget 13 Dec '04

13 Dec '04

I have noticed a lot of constructs of the form: HRESULT WINAPI DMUSIC_CreateDirectMusicScriptImpl (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) { IDirectMusicScriptImpl* obj; obj = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IDirectMusicScriptImpl)); if (NULL == obj) { *ppobj = (LPVOID) NULL; return E_OUTOFMEMORY; } What's the point of casting NULL to (LPVOID)? Isn't it already a void* anyway? Is it to fix a warning issued by ultra-recent gcc versions? (gcc 3.4.2 does not complain here) Similarly there are a lot of casts like this: *ppobj = (LPVOID)&This->UnknownVtbl; Again I thought any kind of pointer could be assigned to a void* pointer so is this cast really necessary? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

2 1

Re: Includes [4] shlwapi
by Juan Lang 13 Dec '04

13 Dec '04

Jon, are you sure about removing the winnls.h includes? This patch looks suspect: > diff -ur wine/dlls/shlwapi/url.c wine-develop/dlls/shlwapi/url.c > --- wine/dlls/shlwapi/url.c 2004-12-03 23:27:08.000000000 -0500 > +++ wine-develop/dlls/shlwapi/url.c 2004-12-06 15:42:34.000000000 -0500 > @@ -25,8 +25,6 @@ > #include <stdlib.h> > #include "windef.h" > #include "winbase.h" > -#include "winnls.h" > -#include "winerror.h" > #include "wine/unicode.h" > #include "wininet.h" > #include "winreg.h" > @@ -1416,7 +1414,7 @@ > * return the same digests for the same URL. > */ > WideCharToMultiByte(0, 0, pszUrl, -1, szUrl, MAX_PATH, 0, 0); > - HashData((PBYTE)szUrl, (int)strlen(szUrl), lpDest, nDestLen); > + HashData((const BYTE*)szUrl, (int)strlen(szUrl), lpDest, nDestLen); > return S_OK; > } winnls.h declares WideCharToMultiByte, and we just saw a compilation error on some systems because it was missing [1]. I haven't checked others, but this caught my eye. [1] http://www.winehq.org/hypermail/wine-cvs/2004/12/0091.html --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - Find what you need with new enhanced search. http://info.mail.yahoo.com/mail_250

3 9

Re: winsock:WS_setsockopt
by Rein Klazes 13 Dec '04

13 Dec '04

On Sun, 12 Dec 2004 12:42:55 +0200, you wrote: > It's a little bit...embracing :-) > > But the program is "Lanwatch". A nice little app, which makes a lot of > noise (if configured correctly) when the Internet connection goes down. > I used it for years, but now we've got rid of the last Windows here.... > > I have other network monitoring tools, but it's just the acoustical > waring, for which I used it...I'll just attach it to the mail, OK? > > It would be great, if there could be a fix for this....Also I contacted > the writer of the little app, but didn't got a answer... > > I think, that it just tries to open a socket (with correct or wrong > parameters), and than gets a back a error and reports (wrongly) that the > Internet connection is down...It might be easy to fix (or hack > workaround) for it, just if you can lead me to the solution? | fixme:winsock:convert_sockopt Unimplemented or unknown socket level | err:winsock:WS_setsockopt Invalid level (65407) or optname (128) | fixme:mpr:WNetGetUniversalNameA ("K:\\", 0x00000001, 0x779cf98c, 0x779cfd98): stub | fixme:winsock:convert_sockopt Unimplemented or unknown socket level | err:winsock:WS_setsockopt Invalid level (65407) or optname (128) | fixme:winsock:convert_sockopt Unknown SOL_SOCKET optname 0xff7f | err:winsock:WS_setsockopt Invalid level (1) or optname (65407) The same output as Space Empires 4. The unknown optname 65407 or 0xff7f, is suspiciously looking like the option SO_DONT_LINGER, 0xffffff7f, with the high bits chopped off. Both these calls fail under Windows (win2K). It is a good idea to ask the programmer, to see what he is trying to accomplish here. Also note that these errors may not be fatal at all if the program is just ignoring them. Letting the program going through I see a fair bit of data exchange, so communications seems to work, at least partly. Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 2

Re: Re: Wine regression caused by 12/02 18:05:37 UTC commit: breaks Total Annihilation
by Jonathan Gevaryahu 13 Dec '04

13 Dec '04

On Sunday 12 December 2004 02:54 pm, Eric Pouech wrote: > Jonathan Gevaryahu a écrit : > does this help? > A+ > > Index: sync.c > =================================================================== > RCS file: /home/cvs/cvsroot/wine/wine/dlls/kernel/sync.c,v > retrieving revision 1.64 > diff -u -u -r1.64 sync.c > --- sync.c 7 Dec 2004 14:23:03 -0000 1.64 > +++ sync.c 12 Dec 2004 19:53:14 -0000 > @@ -893,7 +893,7 @@ > OBJECT_ATTRIBUTES attr; > NTSTATUS status; > > - if (!is_version_nt()) access = SEMAPHORE_ALL_ACCESS; > + if (!is_version_nt()) access = TIMER_ALL_ACCESS; > > attr.Length = sizeof(attr); > attr.RootDirectory = 0; Unfortunately, your patch doesn't fix the problem. But I noticed something disturbing: in CVS (without your patch) occasionally Total Annihilation will run fine (it did ONCE), but almost all of the time it will not work, and give the previously mentioned trace result. Sometimes, it will give a different trace result: ... 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units\\CORDEV1.OVR" not found in /home/jon athan/.wine/dosdevices/g:/cavedog/totala/units warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units\\CORDEV1.OVR" not fou nd (c000003a) warn:file:CreateFileW Unable to create file L"units\\CORDEV1.OVR" (status c00000 3a) trace:ntdll:NtCreateFile handle=0x4087f7a4 access=80000000 name=L"\\??\\G:\\cave dog\\totala\\units-english\\CORDOOM.FBI" objattr=00000042 root=(nil) sec=(nil) i o=0x4087f7a8 alloc_size=(nil) attr=00000080 sharing=00000003 disp=1 options=00000050 ea=(nil).0x00000000 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.834956 (+0.003836) , handles={0x110} ) 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units-english\\CORDOOM.FBI" not found in / home/jonathan/.wine/dosdevices/g:/cavedog/totala warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units-english\\CORDOOM.FBI" not found (c000003a) warn:file:CreateFileW Unable to create file L"units-english\\CORDOOM.FBI" (statu s c000003a) trace:ntdll:NtCreateFile handle=0x4087f7c8 access=80000000 name=L"\\??\\G:\\cave dog\\totala\\units\\CORDOOM.FBI" objattr=00000042 root=(nil) sec=(nil) io=0x4087 f7cc alloc_size=(nil) attr=00000080 sharing=00000003 disp=1 options=00000050 ea=(nil).0x00000000 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.844670 (+0.005838) , handles={0x110} ) 000d: select() = PENDING warn:file:wine_nt_to_unix_file_name L"units\\CORDOOM.FBI" not found in /home/jon athan/.wine/dosdevices/g:/cavedog/totala/units warn:ntdll:NtCreateFile L"\\??\\G:\\cavedog\\totala\\units\\CORDOOM.FBI" not fou nd (c000003a) 000a: event_op( handle=0xc0, op=1 ) 000a: event_op() = 0 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.854135 (+0.007851) , handles={0x110} ) 000d: select() = PENDING warn:file:CreateFileW Unable to create file L"units\\CORDOOM.FBI" (status c00000 3a) 0009: get_handle_fd( handle=0xec, access=00000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f80c,0x44404668,0x00000200, (nil),(nil)),partial stub! 0009: get_handle_fd( handle=0xec, access=80000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } 000d: *wakeup* signaled=258 cookie=0x44f7f4a0 000d: select( flags=12, cookie=0x44f7f4a0, timeout=1102914722.864331 (+0.009845) , handles={0x110} ) 000d: select() = PENDING trace:ntdll:NtReadFile = 0x00000000 0009: get_handle_fd( handle=0xec, access=00000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f414,0x4506cf40,0x00000200, (nil),(nil)),partial stub! 0009: get_handle_fd( handle=0xec, access=80000000 ) 0009: get_handle_fd() = 0 { fd=24, flags=0 } trace:ntdll:NtReadFile = 0x00000000 trace:ntdll:NtReadFile (0xec,(nil),(nil),(nil),0x4087f404,0x44404668,0x00000200, (nil),(nil)),partial stub! ... And that trace means that it was actually working. If I hadn't Control-C terminated that trace, it would have run the game. Jonathan Gevaryahu lord_nightmare(a)users.sf.net

1 0

Baldur's Gate 2 randomly crashes ("Runtime error") with Wine-20041201
by Michal Kepien 12 Dec '04

12 Dec '04

Hi there, I've recently compiled Wine-20041201 and I'm trying to get Baldur's Gate II running. The installation sequence is fine, so is the main menu, character creation etc. The problem is, once inside the actual game, the application randomly crashes giving me: Runtime error c:\bg2\BGMain.exe abnormal program termination This happens often enough to render the gameplay quite unnerving. Especially when it happens 15 minutes after the last quicksave ;-) I haven't found out what makes the game crash. I'm quite sure it isn't a sound problem - I've turned sound off both in ~/.wine/config and in BGConfig.exe - not better at all. The only clue I've got is the message which appears in the system console after the game quits: err:ntdll:RtlpWaitForCriticalSection section 0x40689020 "?" wait timed out in thread 000f, blocked by 0009, retrying (60 sec) Whatever it means ;-) The same thing happened in Wine-20041019. I'd be grateful for any clues as right now I'm quite fed up with restarting the game every 3 minutes (or even worse). If you need any more debug messages, just ask. System specification: Toshiba Satellite Pro 4270 - Celeron 500, Savage/IX (8 MB), Yamaha sound card, 320 MB RAM. Slackware 10.0, kernel 2.4.27. X.org - 6.8.1.99 (CVS), CVS Savage driver. ALSA sound driver, using OSS emulation. Window manager: Fluxbox v0.9.10. Thanks in advance for any support, Michal Kepien

1 0

Re: winsock:WS_setsockopt
by Dan Kegel 12 Dec '04

12 Dec '04

You wrote: >>... the program is "Lanwatch". A nice little app, which makes a lot of >>noise (if configured correctly) when the Internet connection goes down. >>I used it for years, but now we've got rid of the last Windows here.... >> >>I have other network monitoring tools, but it's just the acoustical >>waring, for which I used it...I'll just attach it to the mail, OK? Do you have a URL for lanwatch, or a few more details that would let us identify it (e.g. vendor name, version number)? (There may be several programs by that name.) Is there a free demo download? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

[AppDB] login problem
by Jonathan Ernst 12 Dec '04

12 Dec '04

Hi guys, It's nearly 2 o'clock and I have to wake up early "tomorrow". I made a very big patch that cleans up a lot of code (thousands of tabs, bad indentation, etc. and follows the CODING_STANDARD we wrote together. Of course I didn't had time to clean up every single line of code (I didn't wanted to use any automated mean to do the cleanup to avoid problems). As for the login problem I re-read most of the code and I runned it with all compatibility options turned off and all warnigns turned on and it works very well on my local system. I think there is still one $current occurence somewhere but the problem doesn't come from here. As for the online version that doesn't work, I think that first thing would be to put a test page on the server with phpinfo() in it to know exactly what version of php and what options we are using. Then we have to understand why in function cmd_do_login() of file account.php we have something like: if($result == null) { $_SESSION['current'] = $user; addmsg("You are successfully logged in as '$user->username'.", "green"); redirect(apidb_fullurl("index.php")); } else { retry("login","Login failed ($result)"); $_SESSION['current'] = ""; } And when providing a wrong password we get the error message and when providing a good password we get no message at all ! The reason why it's buggy online and works locally using the latest cvs versions is still to be found... Finally there are still some register_globals to clean up and when we are done we can turn off the following options in php.ini: short_open_tag = Off session.bug_compat_42 = 0 register_globals = Off register_long_arrays = Off P.S. I send a copy to wine-devel in case someone finds out the solution before us.

2 3

Re: ntdll / kernel32: #52
by Robert Shearman 12 Dec '04

12 Dec '04

Eric Pouech wrote: > Moving atom implementation to: > - dlls/kernel32/atom16.c for the 16 bit part > - dlls/ntdll/ntdll.c for the 32 bit part > > A+ > >------------------------------------------------------------------------ > >Name: ntkrnl_52 >ChangeLog: > - moved 16 bit atom support in (16bit) dlls/kernel/atom16.c > - added atom support to NTDLL > - made 32 bit atom support in kernel32 call ntdll's brand new one > - copied the atom tests for global atom so that we can test local atoms too >License: X11 >GenDate: 2004/12/11 12:59:19 UTC >ModifiedFiles: dlls/kernel/Makefile.in dlls/kernel/atom.c dlls/kernel/tests/atom.c dlls/ntdll/Makefile.in dlls/ntdll/ntdll.spec include/winternl.h server/protocol.def server/atom.c >AddedFiles: dlls/kernel/atom16.c dlls/ntdll/atom.c > > ... >--- /dev/null 1970-01-01 01:00:00.000000000 +0100 >+++ dlls/ntdll/atom.c 2004-12-04 15:31:03.000000000 +0100 >@@ -0,0 +1,331 @@ >+/* >+ * Atom table functions >+ * >+ * Copyright 1993, 1994, 1995 Alexandre Julliard >+ * Copyright 2004 Eric Pouech >+ * >+ * This library is free software; you can redistribute it and/or >+ * modify it under the terms of the GNU Lesser General Public >+ * License as published by the Free Software Foundation; either >+ * version 2.1 of the License, or (at your option) any later version. >+ * >+ * This library is distributed in the hope that it will be useful, >+ * but WITHOUT ANY WARRANTY; without even the implied warranty of >+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >+ * Lesser General Public License for more details. >+ * >+ * You should have received a copy of the GNU Lesser General Public >+ * License along with this library; if not, write to the Free Software >+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA >+ */ >+ >+#include "config.h" >+#include "wine/port.h" >+ >+#include <stdlib.h> >+#include <stdarg.h> >+#include <stdio.h> >+#include <string.h> >+#include <ctype.h> >+ >+#include "windef.h" >+#include "winbase.h" >+#include "ntstatus.h" >+ >+#include "wine/server.h" >+#include "wine/unicode.h" >+ >+#include "wine/debug.h" >+ >+WINE_DEFAULT_DEBUG_CHANNEL(atom); >+ >+#define DEFAULT_ATOMTABLE_SIZE 37 >+#define MAX_ATOM_LEN 255 >+ >+/****************************************************************** >+ * is_integral_atom >+ * Returns STATUS_SUCCESS if integral atom and 'pAtom' is filled >+ * STATUS_INVALID_PARAMETER if 'atomstr' is too long >+ * STATUS_MORE_ENTRIES otherwise >+ */ >+static NTSTATUS is_integral_atom( LPCWSTR atomstr, ATOM* pAtom ) >+{ >+ ATOM atom; >+ >+ if (HIWORD( atomstr )) >+ { >+ const WCHAR* ptr = atomstr; >+ if (*ptr++ == '#') >+ { >+ atom = 0; >+ while (*ptr >= '0' && *ptr <= '9') >+ { >+ atom = atom * 10 + *ptr++ - '0'; >+ } >+ if (ptr > atomstr + 1 && !*ptr) goto done; >+ } >+ if (strlenW( atomstr ) > MAX_ATOM_LEN) return STATUS_INVALID_PARAMETER; >+ return STATUS_MORE_ENTRIES; >+ } >+ else atom = LOWORD( atomstr ); >+done: >+ if (atom >= MAXINTATOM) return STATUS_INVALID_PARAMETER; >+ *pAtom = atom; >+ return STATUS_SUCCESS; >+} >+ >+/****************************************************************** >+ * RtlDeleteAtomFromAtomTable (NTDLL.@) >+ */ >+NTSTATUS WINAPI RtlDeleteAtomFromAtomTable( void* table, ATOM atom ) >+{ >+ NTSTATUS status; >+ >+ TRACE( "%p %x\n", table, atom ); >+ SERVER_START_REQ( delete_atom ) >+ { >+ req->atom = atom; >+ req->table = table; >+ status = wine_server_call( req ); >+ } >+ SERVER_END_REQ; >+ return status; >+} > > Rtl* functions should generally avoid doing server calls. You should implement the Rtl* functions on top of the Nt* functions, not the other way around. ... >+/****************************************************************** >+ * NtDeleteAtom (NTDLL.@) >+ */ >+NTSTATUS WINAPI NtDeleteAtom(ATOM atom) >+{ >+ return RtlDeleteAtomFromAtomTable( GLOBAL_ATOM_TABLE, atom ); >+} > > Rob

3 5

winsock:WS_setsockopt
by MediaHost (TM) 12 Dec '04

12 Dec '04

Hi Wine-Devel, Is here anybody which knows what the following function is supposed to do and what needs to get implemented? I'm referring to this: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) Many thanks.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/>

2 1

Re: msacm: pcm compatibility patch
by Christian Costa 11 Dec '04

11 Dec '04

Hi Robert, Robert Reif wrote: > Makes the PCM conversion routines of msacm produce identical results > to the native dll. > Allow any PCM to PCM conversion, not just advertised ones. > > The algorithms used by Microsoft in this dll are very crude and > produce an output of much poorer quality than what is currently > in wine. This is unfortunate but unavoidable if we are to be compatible. I don't see how improving the quality of the conversion could cause problems. Is there an app out there that refuses to run or crashes because of that? The algorithms may have slightly changed across all versions of this dll. And if we can do better job than Microsoft, I think we should do it. > > I have a test program that was used to verify compatibility and can > make it available by request. I hope to integrate some of it into > the regression tests someday. > Bye, Christian

4 4

BeginPaint not called on WM_PAINT
by James Hawkins 11 Dec '04

11 Dec '04

I'm trying to get a program running called BZEdit. Under the latest cvs, the program shows a scrambled mess over the whole screen (I think that is a result of this patch http://cvs.winehq.org/patch.py?id=14725), but when I went back in time to 2004-10-12, the only part of the screen I cant see is the part of the screen where the map you're editing is shown. See http://www.artemisgames.com/BZEdit/ for screenshots. This is the error output I'm getting. err:msg:DispatchMessageA BeginPaint not called on WM_PAINT for hwnd 0x1002a! This message happens every time the editor needs a repaint like when it gets covered by another window. Any ideas about what's going on here? -- James Hawkins

4 7

Re: include file cleanup : another step
by Robert Shearman 11 Dec '04

11 Dec '04

Rémi Assailly wrote: > I moved some defines, ttydrv will not use gdi.h any longer. > I notice that some headers are declared twice, I removed useless > declarations. > > Changelog: > * moved some defines from gdi.h > >------------------------------------------------------------------------ > >--- dlls/gdi/palette.c~ 2004-10-18 23:18:58.000000000 +0200 >+++ dlls/gdi/palette.c 2004-12-09 14:14:52.000000000 +0100 >@@ -37,6 +37,11 @@ > #include "wine/debug.h" > #include "winerror.h" > >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >+ > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > static INT PALETTE_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > >--- include/gdi.h~ 2004-03-04 21:41:13.000000000 +0100 >+++ include/gdi.h 2004-12-09 19:01:20.154559672 +0100 >@@ -83,14 +83,6 @@ > SEGPTR segptr_bits; /* segptr to DIB bits */ > } BITMAPOBJ; > >-/* palette object */ >- >-#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >- >-#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >-#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ >-#define PC_SYS_MAPPED 0x10 /* logical palentry is a direct alias for system palentry */ >- > typedef struct tagPALETTEOBJ > { > GDIOBJHDR header; > >--- dlls/ttydrv/palette.c~ 2004-12-09 18:57:42.835597176 +0100 >+++ dlls/ttydrv/palette.c 2004-12-09 14:27:48.000000000 +0100 >@@ -22,10 +22,14 @@ > > #include <stdlib.h> > >-#include "gdi.h" >-#include "winbase.h" > #include "ttydrv.h" > #include "wine/debug.h" >+#include "wine/wingdi16.h" >+ >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > > WINE_DEFAULT_DEBUG_CHANNEL(ttydrv); > >--- dlls/x11drv/palette.c~ 2004-12-01 12:32:11.000000000 +0100 >+++ dlls/x11drv/palette.c 2004-12-09 19:03:03.933782832 +0100 >@@ -24,11 +24,16 @@ > #include <string.h> > > #include "gdi.h" >-#include "windef.h" > #include "winreg.h" > #include "x11drv.h" > #include "wine/debug.h" > >+/* palette object */ >+#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ >+ >+#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ >+#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ >+ > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > /* Palette indexed mode: > > Nice try, but I don't think we want three copies of the same defines. That's just asking for trouble with them getting out of sync. Rob

2 1

questionable code
by Eric Pouech 11 Dec '04

11 Dec '04

still toying with various compilers, here's two new questions (to whom it may concern): **** dlls/gdi/freetype.c line 1467 the test for "(offset < 0)" is always false. I'm not sure changing it into "offset == -1" is the right solution. *** dlls/ole32/hglobalstream.c line 602 the test "if (newPosition.QuadPart < 0)" is always false as QuadPart is unsigned A+

2 2

Re: [AppDB] TODO patch
by tony_lambregts＠telusplanet.net 11 Dec '04

11 Dec '04

Jonathan Ernst wrote: [snip] > Index: CODING_STANDARD > =================================================================== > RCS file: /home/wine/appdb/CODING_STANDARD,v > retrieving revision 1.1 > diff -u -r1.1 CODING_STANDARD > --- CODING_STANDARD 11 Dec 2004 03:42:43 -0000 1.1 > +++ CODING_STANDARD 11 Dec 2004 18:56:07 -0000 > @@ -62,4 +62,11 @@ > } > } > > +- use long php tags (<?php ?>) instead of short ones (<? ?>) as : > + 1) it could be removed from future versions of php > + 2) if conflicts with tags like <?xml version=1.0 ?> that are used in xhtml [snip] Should be it not if oops//: + 2) it conflicts with tags like <?xml version=1.0 ?> that are used in xhtml

1 0

Re: IME fixes
by Aric Stewart 11 Dec '04

11 Dec '04

You have a few places where variable declaration has moved from the top of the function to under your block. That should be fixed. It is hard to read through the whitespace changes for me. I though general convention was that you did not change whitespace (i seems to remember a small war over that) other than that things look ok. Have you tested this by setting your locale to ja_JP or zh_CN or ko_KR to make sure the fixme come back and such? thanks -aric Ivan Leo Puoti wrote: > We have 2 space, 4 space and 5 space indentation in ime.c, so fix that. > Also behave like windows if we're on a locale that doesn't support, by returning 0 > after setting last error to 120. > > Ivan.

3 2

Re: Includes [1] ntdll
by Andreas Mohr 11 Dec '04

11 Dec '04

Hi, On Tue, Dec 07, 2004 at 06:15:39AM -0800, Jon Griffiths wrote: > Hi, > > On the suspicion that my hacking on header files was causing too many > files to be rebuilt, I whipped up a quick perl script to identify > unneeded header files. This series of patches is the result. Nice stuff, but... where is it? The most important part, I mean: the perl script ;-) Note that some removed include files might be needed for different systems, so some breakage might/may/will follow this patch. (Gerald Pfeifer will *love* your "nice" work, I'm sure ;-) But I'd still vote strongly for including it, since it will remove lots of cruft. Thanks, Andreas Mohr

6 8

[AppDB] First step to integrating the AppDB with Bugzilla
by Tony Lambregts 11 Dec '04

11 Dec '04

Over two years ago this was disccused and the concensus at the time was that integrating the AppDB and Bugzilla would be a Good Idea (TM). This patch is my attempt to get it started. I am submitting this to wine devel first because I KNOW this patch can be controversial. I have tried to make this patch as small as possible but it still covers quite a few files. I am useing Globals and that should be improved. and I am sure there are other things that are wrong with it. ;^) Also the code in preferences.php does not do anything except show that this works. Finally in order for it to work Jeremy Newman will need to set up the include/config.php in the appdb directory. Please try it out and get back to me.. Change Log: Integrate AppDB with Bugzilla to use the versions table from Buzilla. Files changed: preferences.php include/config.php.sample include/util.php Files Added: tables/bugzilla_tables.sql tables/create_bugzilla_tables Index: preferences.php =================================================================== RCS file: /home/wine/appdb/preferences.php,v retrieving revision 1.2 diff -u -r1.2 preferences.php --- preferences.php 10 Dec 2004 01:07:45 -0000 1.2 +++ preferences.php 11 Dec 2004 04:45:44 -0000 @@ -50,6 +50,16 @@ $ext_email = $user->lookup_email($_SESSION['current']->userid); include(BASE."include/"."form_edit.php"); + $version = "unspecified"; + echo "<tr><td>  wine version </td><td>"; + make_bugzilla_version_list("version", $version); + echo "</td></tr>"; +/* <tr> + <td>   Email Address </td> + <td> <input type="text" name="ext_email" value="<?=$ext_email;?>"> </td> + </tr> +*/ + } if($HTTP_POST_VARS) Index: include/config.php.sample =================================================================== RCS file: /home/wine/appdb/include/config.php.sample,v retrieving revision 1.2 diff -u -r1.2 config.php.sample --- include/config.php.sample 24 Mar 2004 15:51:49 -0000 1.2 +++ include/config.php.sample 11 Dec 2004 04:45:45 -0000 @@ -24,4 +24,14 @@ $userdb_dbhost = "localhost"; $userdb_db = "apidb"; +/* + * Bugzilla database info + */ +$bugzilla_dbuser = "root"; +$bugzilla_dbpass = ""; +$bugzilla_dbhost = "localhost"; +$bugzilla_db = "bugs"; +/* $bugzilla_db_port = 3306; is this needed? I dont think so.*/ +$bugzilla_product_id = 1; + ?> Index: include/util.php =================================================================== RCS file: /home/wine/appdb/include/util.php,v retrieving revision 1.7 diff -u -r1.7 util.php --- include/util.php 10 Dec 2004 01:07:45 -0000 1.7 +++ include/util.php 11 Dec 2004 04:45:45 -0000 @@ -171,6 +171,69 @@ } } +/* bugzilla functions */ + +function openbugzilladb() +{ + global $bugzilla_dbuser, $bugzilla_dbpass, $bugzilla_dbhost, $bugzilla_db, $bugzilla_product_id; + global $dbcon, $dbref; + + $dbref++; + + if($dbcon) + return $dbcon; + + $dbcon = mysql_connect($bugzilla_dbhost, $bugzilla_dbuser, $bugzilla_dbpass); + if(!$dbcon) + { + echo "An error occurred: ".mysql_error()."<p>\n"; + exit; + } + mysql_select_db($bugzilla_db); + return $dbcon; +} + +function closebugzilladb() +{ + global $dbcon, $dbref; + + if(--$dbref) + return; + + mysql_close($adbcon); +} + +function make_bugzilla_version_list($varname, $cvalue) +{ + global $bugzilla_db, $bugzilla_product_id; + + $table = $bugzilla_db.".versions"; + $where = "WHERE product_id=".$bugzilla_product_id; + $query = "SELECT value FROM $table $where ORDER BY value"; + + openbugzilladb(); + + $result = mysql_query($query); + + if(!$result) + { + closebugzilladb(); + + return; // Oops + } + echo "<select name='$varname'>\n"; + echo "<option value=0>Choose ...</option>\n"; + while(list($value) = mysql_fetch_row($result)) + { + if($id == $cvalue) + echo "<option value=$value selected>$value\n"; + else + echo "<option value=$value>$value\n"; + } + echo "</select>\n"; + closebugzilladb(); +} + /* get the number of applications in the appQueue table */ function getQueuedAppCount() { --- /dev/null 2003-01-30 03:24:37.000000000 -0700 +++ tables/create_bugzilla_tables 2004-12-10 13:41:28.000000000 -0700 @@ -0,0 +1,4 @@ +#! /bin/sh + +echo Creating fake Bugzilla tables +mysql -u root < bugzilla_tables.sql --- /dev/null 2003-01-30 03:24:37.000000000 -0700 +++ tables/bugzilla_tables.sql 2004-12-10 14:10:49.000000000 -0700 @@ -0,0 +1,62 @@ +create database if not exists bugs; + +use bugs; + +drop table if exists versions; + + +/* + * versions information + */ +create table versions ( + value tinytext, + product_id smallint not null +); + +INSERT INTO versions VALUES ('unspecified', 1 ); +INSERT INTO versions VALUES ('20010112', 1 ); +INSERT INTO versions VALUES ('20010216', 1 ); +INSERT INTO versions VALUES ('20010305', 1 ); +INSERT INTO versions VALUES ('20010326', 1 ); +INSERT INTO versions VALUES ('20010418', 1 ); +INSERT INTO versions VALUES ('20010510', 1 ); +INSERT INTO versions VALUES ('20010629', 1 ); +INSERT INTO versions VALUES ('20010824', 1 ); +INSERT INTO versions VALUES ('20011004', 1 ); +INSERT INTO versions VALUES ('20011108', 1 ); +INSERT INTO versions VALUES ('20020228', 1 ); +INSERT INTO versions VALUES ('20020310', 1 ); +INSERT INTO versions VALUES ('20020411', 1 ); +INSERT INTO versions VALUES ('20020509', 1 ); +INSERT INTO versions VALUES ('20020605', 1 ); +INSERT INTO versions VALUES ('20020710', 1 ); +INSERT INTO versions VALUES ('20020804', 1 ); +INSERT INTO versions VALUES ('20020904', 1 ); +INSERT INTO versions VALUES ('20021007', 1 ); +INSERT INTO versions VALUES ('20021031', 1 ); +INSERT INTO versions VALUES ('20021125', 1 ); +INSERT INTO versions VALUES ('20021219', 1 ); +INSERT INTO versions VALUES ('20030115', 1 ); +INSERT INTO versions VALUES ('20030219', 1 ); +INSERT INTO versions VALUES ('20030318', 1 ); +INSERT INTO versions VALUES ('20030408', 1 ); +INSERT INTO versions VALUES ('20030508', 1 ); +INSERT INTO versions VALUES ('20030618', 1 ); +INSERT INTO versions VALUES ('20030709', 1 ); +INSERT INTO versions VALUES ('20030813', 1 ); +INSERT INTO versions VALUES ('20030911', 1 ); +INSERT INTO versions VALUES ('20031016', 1 ); +INSERT INTO versions VALUES ('20031118', 1 ); +INSERT INTO versions VALUES ('20031212', 1 ); +INSERT INTO versions VALUES ('20040121', 1 ); +INSERT INTO versions VALUES ('20040213', 1 ); +INSERT INTO versions VALUES ('20040309', 1 ); +INSERT INTO versions VALUES ('20040408', 1 ); +INSERT INTO versions VALUES ('20040505', 1 ); +INSERT INTO versions VALUES ('20040615', 1 ); +INSERT INTO versions VALUES ('20040716', 1 ); +INSERT INTO versions VALUES ('20040813', 1 ); +INSERT INTO versions VALUES ('20040914', 1 ); +INSERT INTO versions VALUES ('20041019', 1 ); +INSERT INTO versions VALUES ('20041201', 1 ); +INSERT INTO versions VALUES ('CVS', 1 ); Index: README =================================================================== RCS file: /home/wine/appdb/README,v retrieving revision 1.3 diff -u -r1.3 README --- README 25 Mar 2004 16:29:47 -0000 1.3 +++ README 11 Dec 2004 05:10:49 -0000 @@ -1,32 +1,70 @@ -WineHQ Application Database ------------------------------------------------------------------------- -Authors: - Jeremy Newman <jnewman(a)codeweavers.com> - Charles Leop <charles(a)codeweavers.com> - -Contributors: - Paul van Schayck <info(a)wwwdesign.tmfweb.nl> - Chris Morgan <cmorgan(a)alum.wpi.edu> +WineHQ Application Database +------------------------------------------------------------------------ +Authors: + Jeremy Newman <jnewman(a)codeweavers.com> + Charles Leop <charles(a)codeweavers.com> + +Contributors: + Paul van Schayck <info(a)wwwdesign.tmfweb.nl> + Chris Morgan <cmorgan(a)alum.wpi.edu> + + +To install locally for testing/hacking: +------------------------------------------------------------------------ + +- Symlink from /var/www to the appdb directory + +- Copy include/config.php.sample to include/config.php + +- Edit include/config.php as you see fit, the default name of the database + used in the table creation step below is "apidb", you'll have to modify + these files if you change this in config.php + +- cd tables, run ./create_tables to create the database tables + +- Try to open up localhost/appdb, if you get a directory listing + Edit your /etc/apache/httpd.conf "DirectoryIndex" to include index.php + so apache will open index.php after not finding index.html/index.htm etc + +- Check your /etc/php/php.ini to ensure that + 'register_globals = On' (variables won't get passed) + 'magic_quotes_gpc = Off' (you would end up with \ everywhere) + 'session.bug_compat_42' = On' (Problem with auto-globals and session variables) +------------------------------------------------------------------------ +You can create ether set up a real bugzilla database or a fake one + +- cd tables, run ./create_bugzilla_tables to create the fake bugzilla tables -To install locally for testing/hacking: ------------------------------------------------------------------------- +- installing a real bugzilla database (hope this helps) -- Symlink from /var/www to the appdb directory +# download buzilla (password for cvs is cvs) -- Copy include/config.php.sample to include/config.php +cd /var/www/html +export CVSROOT=:pserver:cvs@cvs.winehq.org:/home/wine +cvs login +cvs -z 0 checkout bugzilla -- Edit include/config.php as you see fit, the default name of the database - used in the table creation step below is "apidb", you'll have to modify - these files if you change this in config.php +# change directory to bugzilla and change the group ownership to apache. -- cd tables, run ./create_tables to create the database tables +cd bugzilla +chgrp -R apache . +chmod -R g+rX . -- Try to open up localhost/appdb, if you get a directory listing - Edit your /etc/apache/httpd.conf "DirectoryIndex" to include index.php - so apache will open index.php after not finding index.html/index.htm etc -- Check your /etc/php/php.ini to ensure that - 'register_globals = On' (variables won't get passed) - 'magic_quotes_gpc = Off' (you would end up with \ everywhere) - 'session.bug_compat_42' = On' (Problem with auto-globals and session variables) +# change to su and run ./checksetup.pl and fix up what it finds wrong. +# this may take several runs + +su +./checksetup.pl + +# in the /etc/httpd/conf/hppt.conf file find "AddHandler cgi-script .cgi" and add the following. + +<Directory "/var/www/html/bugzilla"> +Options ExecCGI +AllowOverride Limit +Order allow,deny +Allow from all +</Directory> + +# edit local config as nessary to allow access.

3 2

Re: Allow output in winedbg to be redirected to a file
by Eric Pouech 11 Dec '04

11 Dec '04

Jeremy White a écrit : > Changelog: > Allow > and >> output redirection on winedbg commands to capture > output to a file. again (it's my bad day for Jer), I think we should stick to gdb commands: see 'set logging' and friends. A+

2 2

some description for ExtTextOut
by Vitaly Lipatov 11 Dec '04

11 Dec '04

This patch adds description for ExtTextOut and missed constants. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

winsock:WS_setsockopt
by StartCom Ltd. 11 Dec '04

11 Dec '04

Hi Wine-Devel, Is here anybody which knows what the following function is supposed to do and what needs to get implemented? I'm referring to this: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) Many thanks.... -- Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org <http://www.startcom.org/> MediaHost^(TM) at www.mediahost.org <http://www.mediahost.org/> Skype: startcom <callto://startcom/>

1 0

Problems using WineDbg
by Bodo Thiesen 10 Dec '04

10 Dec '04

Ok, I'm trying to use winedbg to check, why a game doesn't work, but: $ /cd_autorun Zeus Using /cdimages/mnt/Zeus/AUTORUN.INF as Autorun.Inf Using Z:\autorun.exe as Autorun.Exe Setting WINEPREFIX to /.wine-Zeus Starting Z:\autorun.exe using cmdline /bin/wine Z:\autorun.exe Xlib: extension "GLX" missing on display "localhost:0.0". fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x40359328)->(0002002e,00000013) fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x40359328)->(0002002e,00000008) fixme:ddraw:Main_DirectDraw_SetCooperativeLevel (0x40359328)->(0002002e,00000013) fixme:ddraw:DIB_DirectDrawSurface_Blt dwFlags DDBLT_WAIT and/or DDBLT_ASYNC: can't handle right now. wine: Unhandled exception (thread 000f), starting debugger... WineDbg starting on pid 0xe Unhandled exception: page fault on read access to 0x5a202d28 in 32-bit code (0x21113913). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:007f EIP:21113913 ESP:4067f8b8 EBP:4067fcdc EFLAGS:00010206( - 00 - RIP1) EAX:00000000 EBX:41a54f80 ECX:5a202d28 EDX:00737565 ESI:403ae428 EDI:41a552e8 Stack dump: 0x4067f8b8: 41a55228 21103fa6 403ae428 41a55228 0x4067f8c8: 10029005 403ae428 0000ac44 00000000 0x4067f8d8: 100086c8 41a55228 0000ac44 00000010 0x4067f8e8: 00000002 08000000 41a54f80 4067fe0c 0x4067f8f8: 00000000 4051d10c 00000280 000001e0 0x4067f908: 00000e85 00000000 00000000 0000001e 0200: sel=1007 base=40016000 limit=00001f97 32-bit rw- Backtrace: =>1 0x21113913 in mss32 (+0x13913) (0x4067fcdc) 2 0x0042300b in zeus (+0x2300b) (0x4067fdbc) 3 0x00603f1f in zeus (+0x203f1f) (0x4067fe94) 4 0x0060f8ae EntryPoint+0xce in zeus (0x4067ff20) 5 0x40481a65 start_process+0x135(arg=0x0) [/wine/dlls/kernel/process.c:1046] in kernel32 (0x4067fff4) 6 0x4001d361 wine_pthread_abort_thread+0x31(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x21113913: cmpl $1,0x0(%ecx) Wine-dbg>info registers{PRESSED ENTER} Register dump: CS:0023 SS:002b DS:002b ES:002b FS:1007 GS:007f EIP:21113913 ESP:4067f8b8 EBP:4067fcdc EFLAGS:00010206( - 00 - RIP1) EAX:00000000 EBX:41a54f80 ECX:5a202d28 EDX:00737565 ESI:403ae428 EDI:41a552e8 Wine-dbg>bt{PRESSED ENTER} Backtrace: =>1 0x21113913 in mss32 (+0x13913) (0x4067fcdc) 2 0x0042300b in zeus (+0x2300b) (0x4067fdbc) 3 0x00603f1f in zeus (+0x203f1f) (0x4067fe94) 4 0x0060f8ae EntryPoint+0xce in zeus (0x4067ff20) 5 0x40481a65 start_process+0x135(arg=0x0) [/wine/dlls/kernel/process.c:1046] in kernel32 (0x4067fff4) 6 0x4001d361 wine_pthread_abort_thread+0x31(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) Wine-dbg>${PRESSED ENTER} )Syntax Error ( Wine-dbg>WineDbg terminated on pid 0xe {PRESSED ENTER} $ So, in the very first seconds, I still can interact with winedbg, but then it suddenly disappears, and I get back my shell. No chance to investigate the problem using winedbg this way. There are some other strage missbehaviors, like printing 10000 times 'Wine-dbg>' before being killed using kill -kill <wine-pids>, or even not printing the register dump + back trace in the first place like shown above (same application, startup phase). So not even every time I try winedbg, everything happens identical. I'm using wine-cvs just checked out and rebuild using command line: $ cvs up && ./configure -C --prefix=/ && make depend && make && make install Regards, Bodo

2 1

Re: [AppDB] remove blahblahblah from /include/comments.php
by Chris Morgan 10 Dec '04

10 Dec '04

Hahah. Oops.... Chris > > From: tony_lambregts(a)telusplanet.net > Date: 2004/12/10 Fri AM 01:09:35 EST > To: wine-patches(a)winehq.org > Subject: [AppDB] remove blahblahblah from /include/comments.php > > Change log: remove blahblahblah from /include/comments.php > > Files Changed: /include/comments.php > > > Index: include/comments.php =================================================================== RCS file: /home/wine/appdb/include/comments.php,v retrieving revision 1.7 diff -u -r1.7 comments.php --- include/comments.php 10 Dec 2004 01:07:45 -0000 1.7 +++ include/comments.php 10 Dec 2004 06:58:22 -0000 @@ -75,7 +75,6 @@ echo "<input type=hidden name='commentId' value=$ob->commentId>"; echo "<input type=hidden name='appId' value=$ob->appId>"; echo "<input type=hidden name='versionId' value=$ob->versionId></form></td>","\n"; - echo "blahblahblah $apidb_root"; echo "</td></tr>"; }

1 0

Patch to support VT_BYREF | VT_I4 in typelib.c _copy_arg
by Erich Hoover 10 Dec '04

10 Dec '04

dlls/oleaut32/typelib.c does not currently support VT_BYREF | VT_I4 in _copy_arg, this causes InstallShield to crash when attempting to install the demo for "Prince of Persia: Warrior Within" (and probably other InstallShield programs as well). Installation can complete with this fix under Win9x w/ Desktop (2K and XP options still fail due to "unimplemented function imagehlp.dll.StackWalk64" and non-Desktop fails for unknown reason).

3 2

current CVS broken.
by Ivan Leo Puoti 10 Dec '04

10 Dec '04

I believe this patch http://www.winehq.com/hypermail/wine-cvs/2004/12/0081.html is causing this compile error on my system. make[2]: Entering directory `/path/to/wine/source/dlls/winmm/winejack' gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o audio.o audio.c audio.c: In function `JACK_WaveInit': audio.c:902: warning: implicit declaration of function `wine_dlsym' audio.c:902: warning: assignment makes pointer from integer without a cast audio.c:903: warning: assignment makes pointer from integer without a cast audio.c:904: warning: assignment makes pointer from integer without a cast audio.c:905: warning: assignment makes pointer from integer without a cast audio.c:906: warning: assignment makes pointer from integer without a cast audio.c:907: warning: assignment makes pointer from integer without a cast audio.c:908: warning: assignment makes pointer from integer without a cast audio.c:909: warning: assignment makes pointer from integer without a cast audio.c:910: warning: assignment makes pointer from integer without a cast audio.c:911: warning: assignment makes pointer from integer without a cast audio.c:912: warning: assignment makes pointer from integer without a cast audio.c:913: warning: assignment makes pointer from integer without a cast audio.c:914: warning: assignment makes pointer from integer without a cast audio.c:915: warning: assignment makes pointer from integer without a cast audio.c:916: warning: assignment makes pointer from integer without a cast audio.c:934: warning: implicit declaration of function `strcpyW' audio.c:998: warning: implicit declaration of function `wine_dlclose' audio.c: In function `wodDevInterfaceSize': audio.c:1682: warning: implicit declaration of function `MultiByteToWideChar' audio.c:1682: error: `CP_ACP' undeclared (first use in this function) audio.c:1682: error: (Each undeclared identifier is reported only once audio.c:1682: error: for each function it appears in.) audio.c: In function `wodDevInterface': audio.c:1692: error: `CP_ACP' undeclared (first use in this function) audio.c: In function `widDevInterfaceSize': audio.c:2428: error: `CP_ACP' undeclared (first use in this function) audio.c: In function `widDevInterface': audio.c:2438: error: `CP_ACP' undeclared (first use in this function) make[2]: *** [audio.o] Error 1 make[2]: Leaving directory `/path/to/wine/source/wine/dlls/winmm/winejack' make[1]: *** [winmm/winejack] Error 2 make[1]: Leaving directory `/path/to/wine/source/wine/dlls' make: *** [dlls] Error 2 ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

3 6

Office2K and current Wine
by Igor Shmukler 09 Dec '04

09 Dec '04

Hello, We have problems running most programs including Office with latest wine (20041201) we built from sources on RH9. Following error message appears when running installer: $ fixme:msi:MsiEnableLogA 00000516 "c:\\windows\\temp\\Office 2000 SR-1 Premium Setup(0006)_MsiExec.txt" 00000000 fixme:msi:MsiInstallProductW L"Z:\\home\\ser\\.wine\\office\\data1.msi" L"" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"AppSearch" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"ResolveSource" fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting fixme:msi:HANDLE_CustomType1 DATABASE NOT THREADSAFE... not starting wine: Unhandled exception (thread 000b), starting debugger... Is this a known issue? Any pointers would be most welcome. Thank you in advance, Igor.

1 0

tools/wineinstall
by Christian Britz 09 Dec '04

09 Dec '04

Dear all, the script tools/wineinstall suggest to uninstall wine first if you update an existing installation. This makes senses but it is uncomfortable that the script doesn't offer the option to do that for the user. You always have to su before installing a new version Thx Christian

2 2

Re: include file cleanup : another step
by Vincent Béron 09 Dec '04

09 Dec '04

Le jeu 09/12/2004 à 15:47, Rémi Assailly a écrit : > I moved some defines, ttydrv will not use gdi.h any longer. > I notice that some headers are declared twice, I removed useless > declarations. > > Changelog: > * moved some defines from gdi.h > ---- > > --- dlls/gdi/palette.c~ 2004-10-18 23:18:58.000000000 +0200 > +++ dlls/gdi/palette.c 2004-12-09 14:14:52.000000000 +0100 > @@ -37,6 +37,11 @@ > #include "wine/debug.h" > #include "winerror.h" > > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > + > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > static INT PALETTE_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > > --- include/gdi.h~ 2004-03-04 21:41:13.000000000 +0100 > +++ include/gdi.h 2004-12-09 19:01:20.154559672 +0100 > @@ -83,14 +83,6 @@ > SEGPTR segptr_bits; /* segptr to DIB bits */ > } BITMAPOBJ; > > -/* palette object */ > - > -#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > - > -#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > -#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ > -#define PC_SYS_MAPPED 0x10 /* logical palentry is a direct alias for system palentry */ > - > typedef struct tagPALETTEOBJ > { > GDIOBJHDR header; > > --- dlls/ttydrv/palette.c~ 2004-12-09 18:57:42.835597176 +0100 > +++ dlls/ttydrv/palette.c 2004-12-09 14:27:48.000000000 +0100 > @@ -22,10 +22,14 @@ > > #include <stdlib.h> > > -#include "gdi.h" > -#include "winbase.h" > #include "ttydrv.h" > #include "wine/debug.h" > +#include "wine/wingdi16.h" > + > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > > WINE_DEFAULT_DEBUG_CHANNEL(ttydrv); > > --- dlls/x11drv/palette.c~ 2004-12-01 12:32:11.000000000 +0100 > +++ dlls/x11drv/palette.c 2004-12-09 19:03:03.933782832 +0100 > @@ -24,11 +24,16 @@ > #include <string.h> > > #include "gdi.h" > -#include "windef.h" > #include "winreg.h" > #include "x11drv.h" > #include "wine/debug.h" > > +/* palette object */ > +#define NB_RESERVED_COLORS 20 /* number of fixed colors in system palette */ > + > +#define PC_SYS_USED 0x80 /* palentry is used (both system and logical) */ > +#define PC_SYS_RESERVED 0x40 /* system palentry is not to be mapped to */ > + > WINE_DEFAULT_DEBUG_CHANNEL(palette); > > /* Palette indexed mode: Defining the same thing in multiple files is a clear indication an #include is needed. Vincent

1 0

Re: Visual studio 6 build fix.
by Juan Lang 09 Dec '04

09 Dec '04

> MS Visual C++ v6, when invoking the compiler and other build tools does > the following: > > create anonymous pipe; > duplicate the pipes write handle; > open's the file NUL > The attached patch makes this work properly. Ahh, cool, that might help with MinGW's windres.exe, too. It uses _popen, which I've implemented to do basically the same as above. _popen works for a silly little test program I wrote, but windres.exe isn't getting its output. I'll check it out. Thanks, --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - now with 250MB free storage. Learn more. http://info.mail.yahoo.com/mail_250

1 0

Re: visual studio 6 not happy?
by Dan Kegel 09 Dec '04

09 Dec '04

Jerry Geis wrote: > I am trying to use wine 12-01-04 release with Visual Studio. > I am getting the vcspawn error. Have you ever found a solution to that? > [http://www.winehq.com/hypermail/wine-devel/2003/02/0335.html] Nope. I didn't look very hard, though. > If not I am trying to use the command line nmake. I can export the make file > but how do I build it after that. I know 'wine nmake /f project.mak > CFG="project - Win32 Release"' but that > doesnt exactly do it. From what directory do you execute that? I did it > in the release directory. Have you read http://codingstyle.com/articles/using-ms-vcpp-with-gnu-wine.html ? It might explain that. I haven't really used nmake much, so I've forgotten how I ran it. I usually ignore the .mak file and just build things by hand, as described in http://kegel.com/wine/cl-howto.html, because I do such small things (Wine unit tests, mostly). - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

winelib problems
by Joris Huizer 09 Dec '04

09 Dec '04

Hello, I tried winemaker (just the notepad example explained at the page) but it doesn't work: - I had to comment out 'use strict' - otherwise winemaker would complain; - still no notepad2 executable is generated... Is it under active development, or is winemaker having bigger problems? regards, Joris

1 0

EnumCalendarInfo
by Vitaly Lipatov 09 Dec '04

09 Dec '04

Some months ago Ken Belleau done some implementation of EnumCalendarInfo. http://www.winehq.org/hypermail/wine-patches/2004/04/0170.html I can't find any discussion of this patch. It is possible to review it and apply now? I would like to write some tests for this functions later. P.S. Sorry for patches I send this list. Have I to resend it in wine-patches or not? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Another systray patch
by Alexandre Julliard 09 Dec '04

09 Dec '04

Mike Hearn <mike(a)navi.cx> writes: > There was a crash in the previous patch, here is a fixed version. > > - Add a new wineshell process, and put system tray handling in there > - Rewrite the shell32 systray handling to be out of process > - Support the freedesktop.org XEMBED protocol It would be nice to do the XEMBED stuff as a separate patch. Also I was hoping you would get rid of WS_EX_TRAYWINDOW instead of adding even more uses of it... > + /* we can't intern this with the rest as it depends on the screen we are connecting to */ > + systray_buffer = HeapAlloc(GetProcessHeap(), 0, sizeof(char)*20); > + sprintf(systray_buffer, "_NET_SYSTEM_TRAY_S%d", DefaultScreen(display)); The screen will be 0 in 99.9% of the cases, you should preallocate that one. > +void *xmalloc(unsigned int size) > +{ > + void *p = HeapAlloc(GetProcessHeap(), 0, size); > + > + if (!p) > + { > + fprintf(stderr, "wineshell: virtual memory exhausted\n"); > + exit(1); > + } > + > + ZeroMemory(p, size); exit(1) is not acceptable here, you should handle allocation failures properly. Also malloc doesn't clear the buffer so xmalloc shouldn't either, otherwise it's very confusing. > +struct request { > + NOTIFYICONDATAA ansi; > + NOTIFYICONDATAW wide; > + BOOL unicode; > + BYTE *copydata; Inter-process data should always be sent in Unicode. -- Alexandre Julliard julliard(a)winehq.org

2 2

add GetGlobalFontLinkObject in mlang
by Vitaly Lipatov 09 Dec '04

09 Dec '04

Changes stub to FIXME for GetGlobalFontLinkObject in mlang DLL The patch is attached. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Re: Another systray patch
by Mike Hearn 09 Dec '04

09 Dec '04

> Mike, > I tried saving the patch in various ways, maybe its me, but it would > appear its corrupted, can u resend as attachment, thanks. That's very strange. That was the first time I have tried sending a patch via the builtin emacs sendmail facility, it would be annoying if that mangles it somehow. I checked the web archive and my own inbox, and the patch *looked* fine. I wonder what is up with it. Still, here it is again as an attachment this time. - Add a new wineshell process, and put system tray handling in there - Rewrite the shell32 systray handling to be out of process - Support the freedesktop.org XEMBED protocol

1 1

problem reading dir's with fix
by Rein Klazes 09 Dec '04

09 Dec '04

hi, Since the change from readdir to getdents64 I cannot access certain files and dir's (including the one used for saving wine patches) with the common file dialog's. | 0009:Call ntdll.NtQueryDirectoryFile(00000010,00000000,00000000,00000000,77a6a070,77cc6b24,00002000,00000003,00000000,77cc6b10,00000000) ret=77b26174 | trace:file:NtQueryDirectoryFile (0x10 (nil) (nil) (nil) 0x77a6a070 0x77cc6b24 0x00002000 0x00000003 0x00000000 L"diffs" 0x00000000 | trace:file:append_entry long L"."... short L""... mask L"diffs" | trace:file:match_filename (L"."..., L"diffs") | trace:file:append_entry long L".."... short L""... mask L"diffs" | trace:file:match_filename (L".."..., L"diffs") [some 200 entries snipped] | trace:file:append_entry long L"freecell.ICO"... short L""... mask L"diffs" | trace:file:match_filename (L"freecell.ICO"..., L"diffs") | trace:file:NtQueryDirectoryFile => 80000006 (0) | 0009:Ret ntdll.NtQueryDirectoryFile() retval=80000006 ret=77b26174 | 0009:Call ntdll.RtlNtStatusToDosError(80000006) ret=77b261e1 | 0009:Ret ntdll.RtlNtStatusToDosError() retval=00000012 ret=77b261e1 | trace:file:FindFirstFileExW L"H:\\diffs" not found H:\ contains almost 400 entries, so it is clear not all are read. Looking through the code I notice that getdents64 is called only once, where readdir was called several times. Here is my solution that fixes the problem for me. Changelog: dlls/ntdll : directory.c If needed, keep calling getdents64() until no more entries are returned. Rein.

1 0

Re: wine/ windows/winproc.c programs/uninstaller/m ...
by Dimitrie O. Paun 09 Dec '04

09 Dec '04

On Thu, Dec 09, 2004 at 08:08:00AM -0600, Alexandre Julliard wrote: > Log message: > Janitorial: C booleans must not be compared against TRUE. Thank you! -- Dimi.

1 0

Re: Build also 20 ppem font size for wine_sserifee.fon
by Huw D M Davies 09 Dec '04

09 Dec '04

On Thu, Dec 09, 2004 at 05:33:01PM +0800, Dmitry Timoshkov wrote: > Hello, > > it seems that 20 ppem size for wine_sserifee was simply overlooked. > No, it's a different face than the 20 ppem for cp1251 and cp1252 and is actually the same face as one of the 120dpi ones. I believe this is a mistake by MS, but we have to follow suit. The good news is that I've already drawn such a beast, it just requires a little hack to sfnttofnt to distinguish it from the existing 20 ppem face. I'll try to post a patch soon. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

winedbg problems
by Michael Lin 09 Dec '04

09 Dec '04

Hi all, I am having problem with winedbg and a winelib application I am trying to debug. In the debugger it produce the following output when exception occured: Wine-dbg>cont First chance exception: page fault on read access to 0x00000000 in 32-bit code ( 0x401d4316). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:401d4316 ESP:41e4f7d4 EBP:41e4f7d4 EFLAGS:00210212( - 00 - RIA1) EAX:0000000a EBX:4059aee4 ECX:00000000 EDX:41e4fa3a ESI:00000104 EDI:41e4fa24 Stack dump: 0x41e4f7d4: 41e4fc40 405067c5 00000000 00000104 0x41e4f7e4: 403b67c4 00000001 0000001d 0000004c 0x41e4f7f4: 00000001 00000048 00690057 0065006e 0x41e4f804: 00500020 0073006f 00000000 00000000 0x41e4f814: 00700069 00200074 00720044 00760069 0x41e4f824: 00720065 00000000 4194e425 0000007a Backtrace: =>1 0x401d4316 RtlDetermineDosPathNameType_U+0x6(path=0x0) [/home/mlin/wine/dlls/ntdll/path.c:193] in ntdll (0x41e4f7d4) 2 0x405067c5 PROFILE_Open+0xf5(filename=0x0) [/home/mlin/wine/dlls/kernel/profile.c:751] in kernel32 (0x41e4fc40) 3 0x405087c6 WritePrivateProfileStringW+0x46(section=0x403c2998, entry=0x0, string=0x0, filename=0x0) [/home/mlin/wine/dlls/kernel/profile.c:1415] in kernel32 (0x41e4fc80) 4 0x4050897d WritePrivateProfileStringA+0xbd(section=0x4194ead8, entry=0x0, string=0x0, filename=0x0) [/home/mlin/wine/dlls/kernel/profile.c:1455] in kernel32 (0x41e4fcd0) 5 0x40aaf21ferr:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch PtrArrayWalker <> PtrArray_FIXME<Page> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Node <> ValList<String> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Node <> ValList<Forecasting err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch ConstIterator <> ValList<String> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Iterator <> ValList<String> ..................... err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Iterator <> ValList<String> err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch ConstIterator <> ValList<Forecasting err:dbghelp_stabs:stabs_pts_read_type_def Forward declaration name mismatch Iterator <> ValList<Forecasting Exception c0000005 Wine-dbg> Jon Griffiths reported a similar problem on Jun 21 2004. Does anyone else seen this problem? It seems like winedbg have some problem parsing stabs debug information on C++ templates. Any help would be really appreciated. Thanks, Michael

1 0

Re: shlwapi - forward SHSetTimerQueueTimer to kernel32.CreateTimerQueueTimer
by Robert Shearman 08 Dec '04

08 Dec '04

Steven Edwards wrote: >Hi, > >Msdn documents quite a bit about shlwapi functions that are wrappers around other functions: >http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl… > >But at the moment the application I am testing only depends on this function. > >Changelog: >Foward Shlwapi.SHSetTimerQueueTimer to kernel32.CreateTimerQueueTimer > > Then the application will crash and die in horrible ways with this patch. The function signature of SHSetTimerQueueTimer is not the same as CreateTimerQueueTimer. However, as the MSDN docs say, they are compatible. So, you just need to create an implementation of SHSetTimerQueueTimer that converts the parameters appropriately and calls CreateTimerQueueTimer. Note that this function is still a FIXME stub at the moment, although I plan on implementing this and the thread pooling functions because they will be useful for the COM work. Rob

1 0

Re: Genrate stdole32.tlb file, and install generated files
by Huw D M Davies 08 Dec '04

08 Dec '04

On Sat, Dec 04, 2004 at 01:38:59PM -0500, Vincent Béron wrote: > stdole32-generator.c file from Huw. > Invocation from wineprefixcreate from me. > > Changelog: > Automatically create c:\windows\system\stdole32.tlb. > > Vincent The native version of stdole32.tlb is actually a resource only dll that contains the typelib itself as TYPELIB resource #1. I think we probably want to do likewise. Huw. -- Huw Davies huw(a)codeweavers.com

5 6

Re: fix crash in painting.c
by Steven Edwards 08 Dec '04

08 Dec '04

Hi, --- Rein Klazes <wijn(a)wanadoo.nl> wrote: > Several app's crash with the re-organized region code. > > Changelog: > dlls/user : painting.c > GetUpdateRect can be called with rect is NULL. Just tested here and this does fix the IE6 regressions I was seeing. Thanks Steven __________________________________ Do you Yahoo!? Read only the mail you want - Yahoo! Mail SpamGuard. http://promotions.yahoo.com/new_mail

1 0

tooltips problem with server side update region handling
by Rein Klazes 08 Dec '04

08 Dec '04

Hi, There are now 4 little tooltips windows sticking on top of all windows and following me to every desktop I go :-(((. The problem seems to be that the call: SetWindowPos (hwnd, HWND_TOP, 0, 0, 0, 0, SWP_NOZORDER | SWP_HIDEWINDOW | SWP_NOACTIVATE); in TOOLTIPS_Hide() is ineffective (does not hide the tooltip). Here is a +tooltip,+win,+x11drv trace of the situation before: | trace:tooltips:TOOLTIPS_Hide Hide tooltip 5! (0x10042) | trace:win:SetWindowPos hwnd 0x10042, after (nil), 0,0 (0x0), flags 00000094 | trace:win:dump_winpos_flags flags: SWP_NOZORDER SWP_NOACTIVATE SWP_HIDEWINDOW | trace:x11drv:X11DRV_SetWindowPos hwnd 0x10042, after (nil), swp 0,0 0x0 flags 00000094 | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=46 wparam=0 lParam=77a6f514 | trace:x11drv:X11DRV_SetWindowPos current (187,92)-(324,112), style 94800000 | warn:x11drv:SWP_DoOwnedPopups (0x10042) hInsertAfter = (nil) | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=83 wparam=1 lParam=77a6f478 | trace:x11drv:SWP_DoNCCalcSize (1,1)-(1,1) | trace:x11drv:X11DRV_set_window_rectangles win 0x10042 window (0,0)-(0,0) client (1,1)-(1,1) | trace:win:RedrawWindow 0x10042 ((nil)) NULL 0,0-0,0 (nil) flags=08b8 | trace:win:dump_rdw_flags flags: RDW_VALIDATE RDW_NOINTERNALPAINT RDW_NOERASE RDW_ALLCHILDREN RDW_NOFRAME | trace:win:RDW_UpdateRgns hwnd 0x10042 [(nil)] -> hrgn [0x1], flags [08b8] compared to the situation after, with added some of the +server trace. | race:tooltips:TOOLTIPS_Hide Hide tooltip 5! (0x10042) | trace:win:SetWindowPos hwnd 0x10042, after (nil), 0,0 (0x0), flags 00000094 | trace:win:dump_winpos_flags flags: SWP_NOZORDER SWP_NOACTIVATE SWP_HIDEWINDOW | trace:x11drv:X11DRV_SetWindowPos hwnd 0x10042, after (nil), swp 0,0 0x0 flags 00000094 | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=46 wparam=0 lParam=77a6f514 | trace:x11drv:SWP_DoWinPosChanging hwnd 0x10042, after (nil), swp 0,0 0x0 flags 00001894 | trace:x11drv:SWP_DoWinPosChanging current (178,78)-(315,98) style 94800000 new (0,0)-(0,0) | warn:x11drv:SWP_DoOwnedPopups (0x10042) hInsertAfter = (nil) | 0009: get_window_children( parent=0x10020, atom=0000, tid=0000 ) | 0009: get_window_children() = 0 { count=7, children={0x10042,0x1002c,0x10044,0x10034,0x10022,0x10028,0x10026} } | 0009: start_hook_chain( id=4 ) | 0009: start_hook_chain() = 0 { handle=(nil), pid=0000, tid=0000, proc=(nil), unicode=0, module=L"" } | trace:tooltips:TOOLTIPS_WindowProc hwnd=0x10042 msg=83 wparam=1 lParam=77a6f498 | 0009: start_hook_chain( id=12 ) | 0009: start_hook_chain() = 0 { handle=(nil), pid=0000, tid=0000, proc=(nil), unicode=0, module=L"" } | trace:x11drv:SWP_DoNCCalcSize (1,1)-(1,1) | 0009: set_window_pos( handle=0x10042, top_win=0x10042, previous=(nil), flags=00000094, redraw_flags=00000000, window={0,0;0,0}, client={1,1;1,1} ) | 0009: set_window_pos() = INVALID_PARAMETER { new_style=00000000 } where it all ends. The INVALID_PARAMETER is, I think, the result of a failure of server function validate_window_rectangles(), choking on a window with size 0,0-0,0 and client 1,1-1,1. I guess the validation is too strict, right? Rein.

1 0

Re: [RESEND] Unicodified fontdlg (next try)
by Alexandre Julliard 08 Dec '04

08 Dec '04

Jacek Caban <jack(a)itma.pwr.wroc.pl> writes: > -INT_PTR CALLBACK FormatCharDlgProcA(HWND hDlg, UINT uMsg, WPARAM wParam, > +INT_PTR CALLBACK FormatCharDlgProc(HWND hDlg, UINT uMsg, WPARAM wParam, > LPARAM lParam) > { > - LPCHOOSEFONTA lpcf; > + LPCHOOSEFONTW lpcf; > INT_PTR res = FALSE; > > if (uMsg!=WM_INITDIALOG) > { > - lpcf=(LPCHOOSEFONTA)GetPropA(hDlg, WINE_FONTDATA); > - if (!lpcf && uMsg != WM_MEASUREITEM) > + lpcf=(LPCHOOSEFONTW)GetPropW(hDlg, strWineFontData); > + if (!lpcf) > return FALSE; > if (CFn_HookCallChk32(lpcf)) > - res=CallWindowProcA((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); > + res=CallWindowProcW((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); You cannot use the same dialog procedure for A and W here, since it will cause the hook to always be called with a W message, even if the app originally called ChooseFontA. You really need to keep both dialog procedures. -- Alexandre Julliard julliard(a)winehq.org

1 0

IMM_Register and Flight Simulator 98
by Robert Reif 08 Dec '04

08 Dec '04

Just tried to install Flight Simulator 98 with latest CVS and got this: [wine@dell cdrom1]$ wine setup.exe wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x000004d0 in 32-bit code (0x40e42e67). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0033 GS:004f EIP:40e42e67 ESP:4081f394 EBP:4081f3bc EFLAGS:00010212( - 00 - RIA1) EAX:00000000 EBX:40f0b1e4 ECX:40502a9f EDX:00000000 ESI:40e15a98 EDI:40322f50 Stack dump: 0x4081f394: 4081f3bc 409816e0 000000be 00000000 0x4081f3a4: 00000000 00000000 40e42e5b 40e11220 0x4081f3b4: 40e15a98 40322f50 4081f3e0 40dd85e3 0x4081f3c4: 00000000 000000b6 00000000 00000000 0x4081f3d4: 40997614 40322c28 40322e10 4081f67c 0x4081f3e4: 4095a025 0000004c 40322e28 4081f410 Backtrace: =>1 0x40e42e67 ?? +0x17 in libx11.so.6 (0x4081f3bc) 2 0x40dd85e3 X11DRV_CreateDC+0x87(hdc=0x4c, pdev=0x40322e28, driver=0x4081f410, device=0x0, output=0x0, initData=0x0) [/home/wine/wine/dlls/x11drv/init.c:153] in x11drv (0x4081f3e0) 3 0x4095a025 CreateDCW+0xed(driver=0x408d2f50, device=0x0, output=0x0, initData=0x0) [/home/wine/wine/dlls/gdi/dc.c:609] in gdi32 (0x4081f67c) 4 0x40861503 CURSORICON_CreateFromResource+0x65f(hModule=0x0, hObj=0x0, bits=0x408c5740, cbSize=0x134, bIcon=0x0, dwVersion=0x30000, width=0x20, height=0x20, loadflags=0x8040) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:711] in user32 (0x4081f70c) 5 0x408616eb CURSORICON_Load+0x12f(hInstance=0x0, name=0x7f00, width=0x0, height=0x0, colors=0x1, fCursor=0x1, loadflags=0x8040) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:971] in user32 (0x4081f75c) 6 0x4086390f LoadImageW+0x8b(hinst=0x0, name=0x7f00, type=0x2, desiredx=0x0, desiredy=0x0, loadflags=0x8040) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:2272] in user32 (0x4081f790) 7 0x40862a5e LoadCursorW+0x26(hInstance=0x0, name=0x7f00) [/home/wine/wine/dlls/user/../../windows/cursoricon.c:1715] in user32 (0x4081f7b4) 8 0x41747762 IMM_Register+0x5a [/home/wine/wine/dlls/imm32/imm.c:107] in imm32 (0x4081f800) 9 0x417478d8 DllMain+0x78(hInstDLL=0x41740000, fdwReason=0x1, lpReserved=0x0) [/home/wine/wine/dlls/imm32/imm.c:146] in imm32 (0x4081f814) 10 0x41746f88 __wine_dll_main+0x60 in imm32 (0x4081f844) 11 0x401a2cee call_dll_entry_point+0x12 in ntdll (0x4081f85c) 12 0x401a3d07 MODULE_InitDLL+0xe3(wm=0x40322b80, reason=0x1, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:741] in ntdll (0x4081f8cc) 13 0x401a3ee4 process_attach+0xf8(wm=0x40322b80, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:814] in ntdll (0x4081f8f0) 14 0x401a56e0 LdrLoadDll+0x84(path_name=0x40322ab8, flags=0x0, libname=0x4081f954, hModule=0x4081f934) [/home/wine/wine/dlls/ntdll/loader.c:1565] in ntdll (0x4081f914) 15 0x40466d73 load_library+0x4b(libname=0x4081f954, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:671] in kernel32 (0x4081f944) 16 0x40466e3a LoadLibraryExW+0x2e(libnameW=0x40014c00, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:726] in kernel32 (0x4081f964) 17 0x40466dfe LoadLibraryExA+0x2e(libname=0x40e0bfc4, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:707] in kernel32 (0x4081f97c) 18 0x40466e70 LoadLibraryA+0x1c(libname=0x40e0bfc4) [/home/wine/wine/dlls/kernel/module.c:746] in kernel32 (0x4081f994) 19 0x40df2064 LoadImmDll+0x1c [xim.c:78] in x11drv (0x4081f9a4) 20 0x40df29bb X11DRV_SetupXIM+0x127(display=0x7801c0b8, input_style=0x40e15978) [/home/wine/wine/dlls/x11drv/xim.c:440] in x11drv (0x4081f9d4) 21 0x40deb656 x11drv_init_thread_data+0x11a [/home/wine/wine/dlls/x11drv/x11drv_main.c:502] in x11drv (0x4081f9f0) 22 0x40dc41d1 X11DRV_create_desktop+0x289(desktop_vi=0x0, geometry=0x78020580) [/home/wine/wine/dlls/x11drv/desktop.c:251] in x11drv (0x4081fa78) 23 0x40deb3ac process_attach+0x150 [/home/wine/wine/dlls/x11drv/x11drv_main.c:395] in x11drv (0x4081fa9c) 24 0x40deb761 DllMain+0x39(hinst=0x40db0000, reason=0x1, reserved=0x0) [/home/wine/wine/dlls/x11drv/x11drv_main.c:524] in x11drv (0x4081faa8) 25 0x40dbb6d4 __wine_dll_main+0x60 in x11drv (0x4081fad8) 26 0x401a2cee call_dll_entry_point+0x12 in ntdll (0x4081faf0) 27 0x401a3d07 MODULE_InitDLL+0xe3(wm=0x40322978, reason=0x1, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:741] in ntdll (0x4081fb60) 28 0x401a3ee4 process_attach+0xf8(wm=0x40322978, lpReserved=0x0) [/home/wine/wine/dlls/ntdll/loader.c:814] in ntdll (0x4081fb84) 29 0x401a56e0 LdrLoadDll+0x84(path_name=0x403228a8, flags=0x0, libname=0x4081fbe8, hModule=0x4081fbc8) [/home/wine/wine/dlls/ntdll/loader.c:1565] in ntdll (0x4081fba8) 30 0x40466d73 load_library+0x4b(libname=0x4081fbe8, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:671] in kernel32 (0x4081fbd8) 31 0x40466e3a LoadLibraryExW+0x2e(libnameW=0x40014c00, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:726] in kernel32 (0x4081fbf8) 32 0x40466dfe LoadLibraryExA+0x2e(libname=0x4081fc44, hfile=0x0, flags=0x0) [/home/wine/wine/dlls/kernel/module.c:707] in kernel32 (0x4081fc10) 33 0x40466e70 LoadLibraryA+0x1c(libname=0x4081fc44) [/home/wine/wine/dlls/kernel/module.c:746] in kernel32 (0x4081fc28) 34 0x408c2c42 load_driver+0x7a [user_main.c:75] in user32 (0x4081fd60) 35 0x408c321f process_attach+0x47 [/home/wine/wine/dlls/user/user_main.c:180] in user32 (0x4081fd70) 36 0x408c33cc DllMain+0x50(inst=0x40840000, reason=0x1, reserved=0x1) [/home/wine/wine/dlls/user/user_main.c:260] in user32 (0x4081fd80) 37 0x40851218 __wine_dll_main+0x60 in user32 (0x4081fdb0) 38 0x401a2cee call_dll_entry_point+0x12 in ntdll (0x4081fdc8) 39 0x401a3d07 MODULE_InitDLL+0xe3(wm=0x402f0908, reason=0x1, lpReserved=0x1) [/home/wine/wine/dlls/ntdll/loader.c:741] in ntdll (0x4081fe38) 40 0x401a3ee4 process_attach+0xf8(wm=0x402f0908, lpReserved=0x1) [/home/wine/wine/dlls/ntdll/loader.c:814] in ntdll (0x4081fe5c) 41 0x401a3f13 process_attach+0x127(wm=0x402f07c8, lpReserved=0x1) [/home/wine/wine/dlls/ntdll/loader.c:806] in ntdll (0x4081fe7c) 42 0x401a5fe6 LdrInitializeThunk+0x1f2(main_file=0x0, unknown2=0x0, unknown3=0x0, unknown4=0x0) [/home/wine/wine/dlls/ntdll/loader.c:1902] in ntdll (0x4081ff20) 43 0x40471433 start_process+0x9b(arg=0x0) [/home/wine/wine/dlls/kernel/process.c:1036] in kernel32 (0x4081fff4) 44 0x400298f5 wine_pthread_abort_thread+0x29(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x40e42e67 ?? +0x17 in libx11.so.6: movl 0x4d0(%edx),%eax Wine-dbg>

2 1

Re: msvcrt: implement _pipe
by Alexandre Julliard 08 Dec '04

08 Dec '04

Juan Lang <juan_lang(a)yahoo.com> writes: > + fd = msvcrt_alloc_fd(readHandle, wxflags); > + if (fd != -1) > + { > + pfds[0] = fd; > + fd = msvcrt_alloc_fd(writeHandle, wxflags); > + if (fd != -1) > + pfds[1] = fd; > + } > + if (fd == -1) > + { > + CloseHandle(readHandle); > + CloseHandle(writeHandle); > + *MSVCRT__errno() = MSVCRT_EMFILE; > + ret = -1; > + } You need to free pfds[0] on failure if it was allocated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Problems with Managed Mode
by pvriens＠xs4all.nl 08 Dec '04

08 Dec '04

Hi, just compiled wine (CVS from yesterday 12/7/2004). Started with a clean wine environment. Running 'wine notepad.exe' works fine. Running the same command when the config-file shows: [AppDefaults\\notepad.exe\\x11drv] "Desktop" = "800x600" gives: wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 fixme:dbghelp:SymLoadModule should have successfully loaded some debug information for image C:\windows\notepad.exe Unhandled exception: page fault on read access to 0x000004d0 in 32-bit code (0x1028dc07). In 32 bit mode. Register dump: CS:0073 SS:007b DS:007b ES:007b FS:003b GS:0033 EIP:1028dc07 ESP:2d89f304 EBP:2d89f32c EFLAGS:00010202( - 00 - -RI1) EAX:00000000 EBX:1033d58c ECX:352ca5c3 EDX:00000000 ESI:6d98fdb4 EDI:77e13110 Stack dump: 0x2d89f304: 2d89f32c 3b843d0c 000000be 00000000 0x2d89f314: 00000000 00000000 6aa2d799 6d9895cc 0x2d89f324: 6d98fdb4 77e13110 2d89f350 6d958e1b 0x2d89f334: 00000000 00000060 00000000 00000000 0x2d89f344: 3b8522cc 0000004c 77e12fd0 2d89f5f0 0x2d89f354: 3b81ce89 0000004c 77e12fe8 2d89f384 Backtrace: =>1 0x1028dc07 (0x2d89f32c) 2 0x6d958e1b X11DRV_CreateDC+0x87(hdc=0x4c, pdev=0x77e12fe8, driver=0x2d89f384, device=0x0, output=0x0, initData=0x0) [/data/install/linux/wine-src/wine/dlls/x11drv/init.c:153] in x11drv (0x2d89f350) 3 0x3b81ce89 CreateDCW+0xed(driver=0x3b13e410, device=0x0, output=0x0, initData=0x0) [/data/install/linux/wine-src/wine/dlls/gdi/dc.c:609] in gdi32 (0x2d89f5f0) 4 0x3b0cf0aa CURSORICON_CreateFromResource+0x62e(hModule=0x0, hObj=0x0, bits=0x3b130e00, cbSize=0x134, bIcon=0x0, dwVersion=0x30000, width=0x20, height=0x20, loadflags=0x8040) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:711] in user32 (0x2d89f67c) 5 0x3b0cf290 CURSORICON_Load+0x134(hInstance=0x3b0b0000, name=0x7f00, width=0x0, height=0x0, colors=0x1, fCursor=0x1, loadflags=0x8040) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:971] in user32 (0x2d89f6c8) 6 0x3b0d1411 LoadImageW+0x91(hinst=0x0, name=0x7f00, type=0x2, desiredx=0x0, desiredy=0x0, loadflags=0x8040) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:2272] in user32 (0x2d89f6fc) 7 0x3b0d05b6 LoadCursorW+0x26(hInstance=0x0, name=0x7f00) [/data/install/linux/wine-src/wine/dlls/user/../../windows/cursoricon.c:1715] in user32 (0x2d89f720) 8 0x12a2175b IMM_Register+0x57 [/data/install/linux/wine-src/wine/dlls/imm32/imm.c:107] in imm32 (0x2d89f76c) 9 0x12a218cc DllMain+0x74(hInstDLL=0x12a10000, fdwReason=0x1, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/imm32/imm.c:146] in imm32 (0x2d89f780) 10 0x12a20f88 __wine_dll_main+0x60 in imm32 (0x2d89f7b0) 11 0x6aa37676 call_dll_entry_point+0x12 in ntdll (0x2d89f7c8) 12 0x6aa38673 MODULE_InitDLL+0xdf(wm=0x77e12d40, reason=0x1, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:741] in ntdll (0x2d89f838) 13 0x6aa387cd process_attach+0x81(wm=0x77e12d40, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:814] in ntdll (0x2d89f85c) 14 0x6aa39fb8 LdrLoadDll+0x84(path_name=0x77e12c68, flags=0x0, libname=0x2d89f8c4, hModule=0x2d89f8a4) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:1565] in ntdll (0x2d89f884) 15 0x35230e5b load_library+0x4b(libname=0x2d89f8c4, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:671] in kernel32 (0x2d89f8b4) 16 0x35230f1a LoadLibraryExW+0x2e(libnameW=0x385ccc00, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:726] in kernel32 (0x2d89f8d4) 17 0x35230ede LoadLibraryExA+0x2e(libname=0x6d985ff4, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:707] in kernel32 (0x2d89f8ec) 18 0x35230f50 LoadLibraryA+0x1c(libname=0x6d985ff4) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:746] in kernel32 (0x2d89f904) 19 0x6d972078 LoadImmDll+0x1c [xim.c:78] in x11drv (0x2d89f914) 20 0x6d972972 X11DRV_SetupXIM+0x102(display=0x7974c260, input_style=0x6d98fc50) [/data/install/linux/wine-src/wine/dlls/x11drv/xim.c:440] in x11drv (0x2d89f944) 21 0x6d96b806 x11drv_init_thread_data+0x11a [/data/install/linux/wine-src/wine/dlls/x11drv/x11drv_main.c:502] in x11drv (0x2d89f960) 22 0x6d944f11 X11DRV_create_desktop+0x291(desktop_vi=0x0, geometry=0x7973a9b8) [/data/install/linux/wine-src/wine/dlls/x11drv/desktop.c:251] in x11drv (0x2d89f9ec) 23 0x6d96b54c process_attach+0x148 [/data/install/linux/wine-src/wine/dlls/x11drv/x11drv_main.c:395] in x11drv (0x2d89fa14) 24 0x6d96b905 DllMain+0x35(hinst=0x6d930000, reason=0x1, reserved=0x0) [/data/install/linux/wine-src/wine/dlls/x11drv/x11drv_main.c:524] in x11drv (0x2d89fa20) 25 0x6d93c6d4 __wine_dll_main+0x60 in x11drv (0x2d89fa50) 26 0x6aa37676 call_dll_entry_point+0x12 in ntdll (0x2d89fa68) 27 0x6aa38673 MODULE_InitDLL+0xdf(wm=0x77e12ba0, reason=0x1, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:741] in ntdll (0x2d89fad8) 28 0x6aa387cd process_attach+0x81(wm=0x77e12ba0, lpReserved=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:814] in ntdll (0x2d89fafc) 29 0x6aa39fb8 LdrLoadDll+0x84(path_name=0x77e12ac0, flags=0x0, libname=0x2d89fb64, hModule=0x2d89fb44) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:1565] in ntdll (0x2d89fb24) 30 0x35230e5b load_library+0x4b(libname=0x2d89fb64, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:671] in kernel32 (0x2d89fb54) 31 0x35230f1a LoadLibraryExW+0x2e(libnameW=0x385ccc00, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:726] in kernel32 (0x2d89fb74) 32 0x35230ede LoadLibraryExA+0x2e(libname=0x2d89fbc0, hfile=0x0, flags=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:707] in kernel32 (0x2d89fb8c) 33 0x35230f50 LoadLibraryA+0x1c(libname=0x2d89fbc0) [/data/install/linux/wine-src/wine/dlls/kernel/module.c:746] in kernel32 (0x2d89fba4) 34 0x3b12e326 load_driver+0x76 [user_main.c:75] in user32 (0x2d89fcdc) 35 0x3b12e8fb process_attach+0x47 [/data/install/linux/wine-src/wine/dlls/user/user_main.c:180] in user32 (0x2d89fcec) 36 0x3b12eaa0 DllMain+0x4c(inst=0x3b0b0000, reason=0x1, reserved=0x1) [/data/install/linux/wine-src/wine/dlls/user/user_main.c:260] in user32 (0x2d89fcfc) 37 0x3b0bf218 __wine_dll_main+0x60 in user32 (0x2d89fd2c) 38 0x6aa37676 call_dll_entry_point+0x12 in ntdll (0x2d89fd44) 39 0x6aa38673 MODULE_InitDLL+0xdf(wm=0x77de0b60, reason=0x1, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:741] in ntdll (0x2d89fdb4) 40 0x6aa387cd process_attach+0x81(wm=0x77de0b60, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:814] in ntdll (0x2d89fdd8) 41 0x6aa38867 process_attach+0x11b(wm=0x77de09e0, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fdf8) 42 0x6aa38867 process_attach+0x11b(wm=0x77de0940, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe18) 43 0x6aa38867 process_attach+0x11b(wm=0x77de0858, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe38) 44 0x6aa38867 process_attach+0x11b(wm=0x77de0770, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe58) 45 0x6aa38867 process_attach+0x11b(wm=0x77de0678, lpReserved=0x1) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:806] in ntdll (0x2d89fe78) 46 0x6aa3a87a LdrInitializeThunk+0x1ea(main_file=0x0, unknown2=0x0, unknown3=0x0, unknown4=0x0) [/data/install/linux/wine-src/wine/dlls/ntdll/loader.c:1902] in ntdll (0x2d89ff20) 47 0x3523b109 start_process+0x99(arg=0x0) [/data/install/linux/wine-src/wine/dlls/kernel/process.c:1036] in kernel32 (0x2d89fff4) 48 0x100046a5 wine_pthread_abort_thread+0x29(status=0x0) [port.c:85] in libwine.so.1 (0x00000000) 0x1028dc07: movl 0x4d0(%edx),%eax Wine-dbg> Any idea what to do/try next ? Cheers, Paul Vriens.

1 0

Searching for an existing Windows installation
by Christian Britz 08 Dec '04

08 Dec '04

Dear all, because this step during the installation takes very long, I would suggest to make it optional. Mit freundlichen Grüßen Christian

4 3

Re: wine/ windows/win.c windows/painting.c server/ ...
by Dimitrie O. Paun 08 Dec '04

08 Dec '04

On Tue, Dec 07, 2004 at 11:31:53AM -0600, Alexandre Julliard wrote: > Log message: > Moved update region handling to the server. > > Patch: http://cvs.winehq.org/patch.py?id=14725 Cool stuff! Way to go Alexandre, this is really, really good news! -- Dimi.

3 3

Wine CVS still broken
by Florian Goth 08 Dec '04

08 Dec '04

I deleted my wine - folder and did a full cvs checkout today(23:00 CET ) But there's still a problem in winejack: The previously reported errors seem to be away gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -O2 -march=athlon-xp -m32 -mmmx -m3dnow -msse -ftracer -funroll-loops -fpeel-loops -funswitch-loops -fweb -funit-at-a-time -o winejack.drv.dbg.o winejack.drv.dbg.c ../../../tools/winegcc/winegcc -B../../../tools/winebuild -shared ./winejack.drv.spec audio.o jack.o winejack.drv.dbg.o -o winejack.drv.so -L../../../dlls -lwinmm -luser32 -lkernel32 -L../../../libs/wine -lwine -ldxguid -luuid -L../../../libs/port -lwine_port audio.o(.text+0x22fe): In function `JACK_WaveInit': /home/sifff/wine/dlls/winmm/winejack/audio.c:935: undefined reference to `strcpyW' audio.o(.text+0x23de):/home/sifff/wine/dlls/winmm/winejack/audio.c:969: undefined reference to `strcpyW' collect2: ld gab 1 als Ende-Status zurück winegcc: gcc failed. make[2]: *** [winejack.drv.so] Fehler 2 make[2]: Leaving directory `/home/sifff/wine/dlls/winmm/winejack' make[1]: *** [winmm/winejack] Fehler 2 make[1]: Leaving directory `/home/sifff/wine/dlls' make: *** [dlls] Fehler 2

2 1

Re: windows/win.c : add missing styles
by Dmitry Timoshkov 08 Dec '04

08 Dec '04

"Rémi Assailly" <remi.assailly(a)free.fr> wrote: > --- windows/win.c~ 2004-11-29 18:35:46.000000000 +0100 > +++ windows/win.c 2004-12-07 18:04:02.135332008 +0100 > @@ -872,7 +872,6 @@ > if(style & WS_MINIMIZEBOX) TRACE(" WS_MINIMIZEBOX"); > if(style & WS_MAXIMIZEBOX) TRACE(" WS_MAXIMIZEBOX"); > > - /* FIXME: Add dumping of BS_/ES_/SBS_/LBS_/CBS_/DS_/etc. styles */ Don't remove this line, your patch doesn't add dumping of those styles. > #define DUMPED_STYLES \ > (WS_POPUP | \ > WS_CHILD | \ > @@ -882,6 +881,7 @@ > WS_CLIPSIBLINGS | \ > WS_CLIPCHILDREN | \ > WS_MAXIMIZE | \ > + WS_CAPTION | \ This isn't a style you want to add here. > WS_BORDER | \ > WS_DLGFRAME | \ > WS_VSCROLL | \ > @@ -891,7 +891,94 @@ > WS_GROUP | \ > WS_TABSTOP | \ > WS_MINIMIZEBOX | \ > - WS_MAXIMIZEBOX) > + WS_MAXIMIZEBOX | \ > + BS_DEFPUSHBUTTON | \ > + BS_CHECKBOX | \ > + BS_AUTOCHECKBOX | \ > + BS_AUTOCHECKBOX | \ > + BS_3STATE | \ > + BS_AUTO3STATE | \ > + BS_GROUPBOX | \ > + BS_USERBUTTON | \ > + BS_AUTORADIOBUTTON | \ > + BS_OWNERDRAW | \ > + BS_LEFTTEXT | \ > + BS_ICON | \ > + BS_BITMAP | \ > + BS_LEFT | \ > + BS_RIGHT | \ > + BS_CENTER | \ > + BS_TOP | \ > + BS_BOTTOM | \ > + BS_VCENTER | \ > + BS_PUSHLIKE | \ > + BS_MULTILINE | \ > + BS_NOTIFY | \ > + BS_FLAT | \ > + ES_CENTER | \ > + ES_RIGHT | \ > + ES_MULTILINE | \ > + ES_UPPERCASE | \ > + ES_LOWERCASE | \ > + ES_PASSWORD | \ > + ES_AUTOVSCROLL | \ > + ES_AUTOHSCROLL | \ > + ES_NOHIDESEL | \ > + ES_COMBO | \ > + ES_OEMCONVERT | \ > + ES_READONLY | \ > + ES_WANTRETURN | \ > + ES_NUMBER | \ > + SBS_VERT | \ > + SBS_TOPALIGN | \ > + SBS_LEFTALIGN | \ > + SBS_BOTTOMALIGN | \ > + SBS_RIGHTALIGN | \ > + SBS_SIZEBOXTOPLEFTALIGN | \ > + SBS_SIZEBOXBOTTOMRIGHTALIGN | \ > + SBS_SIZEBOX | \ > + SBS_SIZEGRIP | \ > + LBS_NOSEL | \ > + LBS_COMBOBOX | \ > + LBS_STANDARD | \ > + CBS_SIMPLE | \ > + CBS_DROPDOWN | \ > + CBS_DROPDOWNLIST | \ > + CBS_OWNERDRAWFIXED | \ > + CBS_OWNERDRAWVARIABLE | \ > + CBS_AUTOHSCROLL | \ > + CBS_OEMCONVERT | \ > + CBS_SORT | \ > + CBS_HASSTRINGS | \ > + CBS_NOINTEGRALHEIGHT | \ > + CBS_DISABLENOSCROLL | \ > + CBS_UPPERCASE | \ > + CBS_LOWERCASE | \ > + DS_ABSALIGN | \ > + DS_SYSMODAL | \ > + DS_3DLOOK | \ > + DS_FIXEDSYS | \ > + DS_NOFAILCREATE | \ > + DS_LOCALEDIT | \ > + DS_SETFONT | \ > + DS_MODALFRAME | \ > + DS_NOIDLEMSG | \ > + DS_SETFOREGROUND | \ > + DS_CONTROL | \ > + DS_CENTER | \ > + DS_CENTERMOUSE | \ > + DS_CONTEXTHELP | \ > + SS_USERITEM | \ > + SS_LEFTNOWORDWRAP | \ > + SS_OWNERDRAW | \ > + SS_BITMAP | \ > + SS_ENHMETAFILE | \ > + SS_ETCHEDHORZ | \ > + SS_ETCHEDVERT | \ > + SS_ETCHEDFRAME | \ > + SS_TYPEMASK | \ > + SS_WORDELLIPSIS | \ > + SS_ELLIPSISMASK) And where do you dump all the above listed styles? (Just a hint: you can't dump them without looking at the class name, and it won't work for superclassed windows). -- Dmitry.

1 0

Feedback on user manual
by Ross Boylan 08 Dec '04

08 Dec '04

The manual lamented the lack of feedback, so I thought I'd give you some. 1.1.1 says "It tries to target both the new Wine user, by offering a step by step approach, and the experienced Wine user, by offering the reference material mentioned above." Ordinarily, I would expect the novice stuff, followed by reference material. But, judging from the table of contents, this isn't what you've done. It would be good to say how the stuff is arranged. Assuming the novice and expert stuff is interspersed, it might be better to separate them. Yes, I realize that's probably a lot of work. That's why this is only a though :) You might also want to put a date and version number on the documentation; at least on Debian, looking at the html, I don't see it. I'm using wine-doc 0.0.20040716-1.3. Thanks for your work on wine. -- Ross Boylan wk: (415) 502-4031 530 Parnassus Avenue (Library) rm 115-4 ross(a)biostat.ucsf.edu Dept of Epidemiology and Biostatistics fax: (415) 476-9856 University of California, San Francisco San Francisco, CA 94143-0840 hm: (415) 550-1062

3 3

Compiling wine fails
by Florian Goth 07 Dec '04

07 Dec '04

Patch: http://cvs.winehq.org/patch.py?id=14706 breaks compiling on my system(kernel-2.6.9; gcc 3.4.2 ) Reverting the patch fixes compiling. The patch produces the following Errors: make[2]: Entering directory `/home/sifff/wine/dlls/winmm/winejack' gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -O2 -march=athlon-xp -m32 -mmmx -m3dnow -msse -ftracer -funroll-loops -fpeel-loops -funswitch-loops -fweb -funit-at-a-time -o audio.o audio.c audio.c: In function `JACK_WaveInit': audio.c:902: Warnung: implizite Deklaration der Funktion »wine_dlsym« audio.c:902: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:903: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:904: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:905: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:906: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:907: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:908: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:909: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:910: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:911: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:912: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:913: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:914: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:915: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:916: Warnung: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung audio.c:934: Warnung: implizite Deklaration der Funktion »strcpyW« audio.c:998: Warnung: implizite Deklaration der Funktion »wine_dlclose« audio.c: In function `wodDevInterfaceSize': audio.c:1682: Warnung: implizite Deklaration der Funktion »MultiByteToWideChar« audio.c:1682: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) audio.c:1682: Fehler: (Jeder nicht deklarierte Bezeichner wird nur einmal aufgeführt audio.c:1682: Fehler: für jede Funktion in der er auftritt.) audio.c: In function `wodDevInterface': audio.c:1692: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) audio.c: In function `widDevInterfaceSize': audio.c:2428: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) audio.c: In function `widDevInterface': audio.c:2438: Fehler: »CP_ACP« nicht deklariert (erste Benutzung in dieser Funktion) make[2]: *** [audio.o] Fehler 1 make[2]: Leaving directory `/home/sifff/wine/dlls/winmm/winejack' make[1]: *** [winmm/winejack] Fehler 2 make[1]: Leaving directory `/home/sifff/wine/dlls' make: *** [dlls] Fehler 2

3 2

Fwd:[Fwd: [AppDB] Status Report]
by Ivan Leo Puoti 07 Dec '04

07 Dec '04

Can someone working on appdb fix this? Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: No more winrash?
by Ferenc Wagner 07 Dec '04

07 Dec '04

Jakob Eriksson <jakov(a)vmlinux.org> writes: > Do you agree, should we stop using winrash? > > "Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > >> "Jakob Eriksson" <jakov(a)vmlinux.org> wrote: >> >>> Well, I tried now marking the service as interactive, >>> but that didn't make any difference. >>> >>> So, what follows, deprecate Winrash? >> >> If it really breaks the tests then definitely yes. I think it does provide much useful information which would be largely lost if we resorted to manual testing. What's more, winetest is not really up to that, as it doesn't ask for a tag but relies on a command line option which people would tend to forget. What I propose: make winetest detect whether it's running on an interactive desktop or not, and include this info in the header just like bRunningUnderWine. Meanwhile add the tag dialog to winetest and separate or mark the different reports on the webpage for easier reference. That would bring us the best of both worlds. Or possibly tweak the sensitive tests (how many are there?) to make clear in the output that they were not run for this reason... That would probably require a new field in the final report (ie. success-failure-todo-skipped or similar). This could also signal WINETEST_INTERACTIVE tests so that they aren't forgotten about... That said, I don't know much of this desktop business, so I'm not sure how to put the detection logic in. The rest should not be hard, I hope I'll find the time for them if we decide to go this way. -- Feri.

4 3

Re: Shell about box
by Dmitry Timoshkov 07 Dec '04

07 Dec '04

"Ge van Geldorp" <gvg(a)reactos.com> wrote: > Changelog: > Klemens Friedl <frik85(a)hotmail.com> > - Design Shell About dialog more Windows-like The patch will not apply since it's utf-8 encoded. -- Dmitry.

1 0

Re: Implemented CreateAsyncBindCtx
by Alexandre Julliard 07 Dec '04

07 Dec '04

Jacek Caban <jack(a)itma.pwr.wroc.pl> writes: > It's my tiny bug. RegsterObjectParam can fail only with E_OUTOFMEMORY > here, so checking it's return is > really not important, but to be correct at all, hres should be just > returned. No, that's worse than before, now you return an error while still allocating the object. You need to cleanup the allocated context when returning a failure. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Help with some strange debugging.
by Jon Griffiths 07 Dec '04

07 Dec '04

Hi Oliver, >I've also got a little patch for oleaut/varient.c to >allow number-string comparisons. There are a couple of >undocumented assumptions I've made,like what to return >for an empty of if the string isn't a number, and the >only thing I've been able to test with is 1 vb >application as I don't have windows, should I post it >to this list or to patch? If you need to test how the native dll works, please write a unit test case for the comparasons you are interested in (there are a _huge_ number of variant tests already defined in the dlls/oleaut32/tests directory). Run the tests manually from the tests directory as: WINEDLLOVERRIDES="oleaut32=n" wine ./oleaut32test.exe.so <testname> To check out the native versions behaviour (of course you will need a native oleaut32.dll in your fake c:\windows\system dir). for the builtin version run: WINETEST_PLATFORM="wine" WINEDLLOVERRIDES="oleaut32=b" wine ./oleaut32test.exe.so <testname> This will catch any regressions from your patch and ensure that future changes don't break your changes in any way. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Re: Providing success stories
by Dan Kegel 07 Dec '04

07 Dec '04

Stefan Munz wrote: > In order to push the use of Open Source Software we plan a project with the > "Wirtschaftsförderung Region Stuttgart GmbH" ... to > find software producers who pay us for a wine compatibility test of their > software. ... What's the URL, by the way? Is it http://opensource.region-stuttgart.de/ ? > This project is starting at the moment. I thought a good idea to give > something back to the community is to provide some success stories i.e. for > use on winehq.com. Is this interesting? Yes. I don't see anything on winehq.com like that, but http://www.codeweavers.com/site/products/case_studies seems to be along the lines you're thinking of, maybe? Try just writing up a first draft of a success story on a web page somewhere, and post a link to wine-devel so we can see what you're thinking of. Then I'm sure getting it onto winehq.org will be easy. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

gdi/metafile tests
by Walt Ogburn 07 Dec '04

07 Dec '04

To Dmitry Timoshkov - I have started working on some tests (attached here) for metafile functions in gdi. If these seem reasonable, should I add them to your metafile.c test code, or move yours to enhmetafile.c and start a new metafile.h? Thanks, Walter

2 1

Re: msvcrt: implement _dup (take 2)
by Dmitry Timoshkov 07 Dec '04

07 Dec '04

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > + if (DuplicateHandle(GetCurrentProcess(), MSVCRT_fdesc[od].handle, > + GetCurrentProcess(), &handle, 0, > + !(MSVCRT_fdesc[od].wxflag & WX_DONTINHERIT), DUPLICATE_SAME_ACCESS)) > + { > + ret = msvcrt_alloc_fd(handle, MSVCRT_fdesc[od].wxflag); > + if (ret == -1) > + *MSVCRT__errno() = MSVCRT_EMFILE; > + } You need to close duplicated handle in the case of msvcrt_alloc_fd failure. -- Dmitry.

2 1

Re: stub implementation for GetLastInputInfo and SetLayeredWindowAttributes
by Dmitry Timoshkov 07 Dec '04

07 Dec '04

"Mike McCormack" <mike(a)codeweavers.com> wrote: > +BOOL WINAPI GetLastInputInfo(PLASTINPUTINFO); ... > diff -u -r1.90 user32.spec > --- dlls/user/user32.spec 19 Oct 2004 21:10:17 -0000 1.90 > +++ dlls/user/user32.spec 6 Dec 2004 18:01:17 -0000 > @@ -263,6 +263,7 @@ > @ stdcall GetKeyboardState(ptr) > @ stdcall GetKeyboardType(long) > @ stdcall GetLastActivePopup(long) > +@ stdcall GetLastInputInfo() Number of parameters in header and spec files mismatch and there is no stub implementation of GetLastInputInfo at all. -- Dmitry.

1 0

Fedora Core 2 VM layout
by Kenneth Porter 07 Dec '04

07 Dec '04

There's a thread going on the fedora-devel list about exec-shield, legacy_va_layout, and WINE: <https://www.redhat.com/archives/fedora-devel-list/2004-December/msg00132.ht…> Some WINE experts might want to weigh in over there. Are these still issues with the current WINE release?

2 1

[Regression] "Moved visible region calculation to the server" patch broked apllication
by Paul van Schayck 06 Dec '04

06 Dec '04

Hey everyone, Since the 23th of July the main opengl window of this application has been broken. It's not being drawn. You can find the application (MSI installer) here: http://www.meosource.com/firefox/asrc11.zip The patch that broked it can be found here: http://cvs.winehq.org/patch.py?id=12703 The CVS log entry can be found here: http://www.winehq.org/hypermail/wine-cvs/2004/06/0196.html Right after that patch nothing was being drawn. With current cvs checkouts the top menu is vissible again. Kind regards, Paul van Schayck

1 0

Re: [dx9-16] Basetexture support
by Robert Shearman 06 Dec '04

06 Dec '04

Ann and Jason Edmeades wrote: >This patch adds a parent class to the various types of textures > >Changelog > >Add BaseTexture class support, call from d3d9. > >Jason > >Note: This adds a new file, basetexture.c which is also part of the patch > > The ref-counting in this patch looks a bit suspicious. Does This->resource.parent point to an object that holds a ref-count on the IWineD3DBaseTextureImpl object? If so, then that would lead to a circular ref-count where neither object would be freed. Rob

2 1

Re: Another systray patch
by Grant Williamson 06 Dec '04

06 Dec '04

Mike, I tried saving the patch in various ways, maybe its me, but it would appear its corrupted, can u resend as attachment, thanks. [root@trax wine-20041201]# patch -p0 -i /usr/src/redhat/SOURCES/systray-20041206.patch patching file dlls/x11drv/event.c patching file dlls/x11drv/window.c patching file dlls/x11drv/x11drv.h patching file programs/wineshell/Makefile.in patching file programs/wineshell/wineshell.c patching file programs/wineshell/wineshell.h patching file programs/wineshell/systray.c patch: **** malformed patch at line 485:

1 0

Re: wine/dlls/ntdll directory.c
by Mike Hearn 06 Dec '04

06 Dec '04

On Mon, 06 Dec 2004 10:48:16 -0600, Alexandre Julliard wrote: > Log message: > Use a direct getdents syscall on Linux to avoid relying on > implementation details of seekdir/telldir. > > Patch: http://cvs.winehq.org/patch.py?id=14699 Does this fix the hang on Reiser4 by any chance? thanks -mike

2 1

Re: Turn off Antialiasing for Rendering with Palette - Take 2
by Dmitry Timoshkov 06 Dec '04

06 Dec '04

"Glenn Wurster" <glenn(a)electric.ath.cx> wrote: > ret = dc->funcs->pExtTextOut(dc->physDev,x,y,flags|ETO_IGNORELANGUAGE, > - lprect,lpReorderedString,count,lpDx,dc->breakExtra); > + lprect,lpReorderedString,count,lpDx,dc->breakExtra,antialias); I think that it should be the ExtTextOut's backend responsibility whether to use antialiasing or not, taking into account ANTIALIASED_QUALITY and CLEARTYPE_QUALITY value of the LOGFONT.lfQuality field. -- Dmitry.

2 1

Wine failed during HEAP_CreateSystemHeap
by Tobias Grosser 06 Dec '04

06 Dec '04

Hi, i tried to use the new FreeBSD Wine port und FreeBSD 5.3. And I am able to start wine, but while executing "wine ie6setup.exe" an error during CreateSystemHeap shows up. Unfortunately I am not able to solve this problem by myself, and need some advice how to debug this correct. Here the output, after which wine exits: fixme:file:get_default_drive_device auto detection of DOS devices not supported on this platform fixme:ntdll:NtQueryVolumeInformationFile device info not properly supported on this platform err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not availablefixme:ntdll:NtQueryVolumeInformationFile device info not properly supported on this platform err:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not availableerr:heap:HEAP_CreateSystemHeap system heap base address 0x80000000 not availableerr:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! err:heap:HEAP_GetPtr Invalid heap 0x0! I tried to change SYSTEM_HEAP_BASE to 0xC0000000 for testing, but this shows an equal output. If I open wine in gdb I am not able to set a breakpoint at line 96 "if(!(base = MapViewOfFileEx( map, FILE_MAP_ALL_ACCESS, 0, 0, 0, SYSTEM_HEAP_BASE )))" to start debugging. Starting at the beginning of the function throws me into inline assambler and some "valgrind" code, but nothing i can deal with. It would be great to give me some debugging advice. Thanks in advance Tobias

2 1

needing some help...
by MyComputer Store 06 Dec '04

06 Dec '04

Hey... I am just getting into this whole wine thing and I have already run into a problem. I am working on switching my Media Matrix servers over to linux, but the software that I need to run is still windows based. Here is the link to the software. http://mm.peavey.com/downloads/mware335.exe when I try to run this file with wine (20041201) it locks up before the installer has finished loading... any advise?? Caleb Miller

1 0

Re: mdi.c/MDI_ChildActivate query
by Jeremy White 06 Dec '04

06 Dec '04

Works nicely; thank you (and my schools chess club, soon to have a tourney, thanks you <grin>). Cheers, Jeremy Dmitry Timoshkov wrote: > "Jeremy White" <jwhite(a)codeweavers.com> wrote: > > >>When trying to run 'Swiss Perfect' (www.swissperfect.com, >>free download available), the app crashes and burns while >>processing a WM_MDIACTIVATE message when the prevWnd is 0. > > > This is due to a long standing hack in X11DRV_ShowWindow which > forces MDI child activation. > > Attached patch adds a couple of new MDI message tests using existing > message sequences for ordinary child windows and confirms that > ShowWindow does the same job for MDI children in respect to activation. > > This fixes a crash in Swiss Perfect. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > ShowWindow activates only a being maximized child window, > add a couple of message tests for MDI child activation. >

1 0

Kernel 2.6.10... and amd64
by Jose Alberto Reguero 06 Dec '04

06 Dec '04

I can't use wine with kernels 2.6.10-rc2.... With kernel 2.6.9 it works. My system is an amd64 linux. Thanks. Jose Alberto

1 2

IME question
by Ivan Leo Puoti 05 Dec '04

05 Dec '04

According to MSDN, windows creates an IME window and an input context for every thread, should wine do the same? Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Implemented CreateAsyncBindCtx
by Mike Hearn 05 Dec '04

05 Dec '04

On Fri, 03 Dec 2004 23:01:36 -0500, Jacek Caban wrote: > + hres = IBindCtx_RegisterObjectParam(bctx, (LPOLESTR)BSCBHolder, (IUnknown*)callback); > + > + *pbind = bctx; > + > + return S_OK; > } You don't do anything with hres here, is that intentional? Can RegisterObjectParam fail? thanks -mike

2 1

mdi.c/MDI_ChildActivate query
by Jeremy White 05 Dec '04

05 Dec '04

Hi, When trying to run 'Swiss Perfect' (www.swissperfect.com, free download available), the app crashes and burns while processing a WM_MDIACTIVATE message when the prevWnd is 0. If I modify the code as in the attached patch, everything works. I can't determine if the app is flawed or if this is a good change to Wine; I'm hoping an MDI expert can kibitz. Cheers, Jeremy

1 0

Wrapper for Winelib
by Sam Lauber 05 Dec '04

05 Dec '04

I *think* I've figured out a way to make regular Unix programs with winelib. My idea is, make winemaker generate a C file called "winelib-wrap.c" that contains: #include <stddef.h> int main(void) { return (int) WinMain(NULL, NULL, NULL, NULL); } Then link it with the EXE encapusulated in a .so, and it SHOULD work. I'll try it on the 01-stdole32.c. It gave me a SIGSEGV, but maybe someone would fix it. Samuel Lauber -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

2 1

Re: msvcrt: set mode bits in _fstati64
by Dmitry Timoshkov 05 Dec '04

05 Dec '04

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > + buf->st_mode = S_IFREG; > + if (!(hfi.dwFileAttributes & (FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM))) > + { > + buf->st_mode |= S_IREAD; > + if (!(hfi.dwFileAttributes & FILE_ATTRIBUTE_READONLY)) > + buf->st_mode |= S_IWRITE; > + } Why do you take into account (FILE_ATTRIBUTE_HIDDEN | FILE_ATTRIBUTE_SYSTEM) at all? They have nothing to do with an ability to read/write files. What you probably need to consider is a type of a file passed in. -- Dmitry.

2 5

questions dlls/d3d8/shader.c
by Eric Pouech 05 Dec '04

05 Dec '04

while toying with Intel compiler on Wine source, I came across a couple of interesting stuff. To whom it may concern. in dlls/d3d8/shader.c: vshader_m4x3 (and vsharer_m3x4) don't use correctly row & columns with respect to the matrice definition. I let the D3D folks decide whether the matrix definition, or the implementation is to blame IDirect3DVertexShaderImpl_ExecuteSW: you miss one in size of p_send (and likely p) in windows/sys_params.c SystemParametersInfoW, for the case SPI_GETLOWPOWERACTIVE, this index is out of the bounds of spi_loaded in dlls/shell32/shlview.c ShellView_OnNotify, case LVN_BEGINDRAG and LVN_BEGINRDRAG, the dwEffect value is not initialized before calling DoDragDrop !!! A+

2 1

Re: Mirroring support take 1
by Juan Lang 05 Dec '04

05 Dec '04

This doesn't look right: @@ -2071,6 +2077,7 @@ WIN_ReleasePtr( wndPtr ); return retval; } + break; /* fall through */ If the break is missing, why does the comment say fall through? I think it was intentional. If the break should be there, please remove the comment as well. --Juan __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

1 0

Re: Janitorial: WinMM conversion of 32 bit low level drivers to Unicode interface
by Eric Pouech 05 Dec '04

05 Dec '04

Eric Pouech a écrit : > This patch is based on work by Filip Navara from ReactOS. > He did the Winmm part (+wave & midi mapper), I did the rest (+ 16 > message mapping) > A+ well, another take (I forgot a couple of places...) I also removed the SB related code. What's missing it's the proper registry settings when a device is chosen, and we'd better do it either in winecfg or wine.inf, but not in the drivers themselves A+

1 0

Problem to draw a bitmap
by Rémi Assailly 05 Dec '04

05 Dec '04

I tested a program ( an other one, with source code this time ) On my Windows XP system I have no problem. When I use Wine I just get a window. ( where is my bitmap ? ) Then I tried this : "WINEDEBUG=gdi wine progtest" and as Wine is slower I could see my bitmap, which disappeared as fast as it appeared... Here the source code : > #include <windows.h> > #include <wingdi.h> > > void PrintBmp(HWND hWnd, char *filename) > { > HBITMAP hBmp; > HDC hDC; > hBmp=(HBITMAP)LoadImage(NULL,filename,IMAGE_BITMAP,0,0,LR_LOADFROMFILE); > hDC=GetDC(hWnd); > DrawState(hDC,NULL,NULL,(LPARAM)hBmp,NULL,0,0,0,0,DST_BITMAP); > DeleteObject(hBmp); > ReleaseDC(hWnd,hDC); > } > > /* Declare Windows procedure */ > LRESULT CALLBACK WindowProcedure (HWND, UINT, WPARAM, LPARAM); > > /* Make the class name into a global variable */ > char szClassName[ ] = "WindowsApp"; > > > int WINAPI > WinMain (HINSTANCE hThisInstance, > HINSTANCE hPrevInstance, > LPSTR lpszArgument, > int nFunsterStil) > > { > HWND hwnd; /* This is the handle for our window */ > MSG messages; /* Here messages to the application are saved */ > WNDCLASSEX wincl; /* Data structure for the windowclass */ > > /* The Window structure */ > wincl.hInstance = hThisInstance; > wincl.lpszClassName = szClassName; > wincl.lpfnWndProc = WindowProcedure; /* This function is called by windows */ > wincl.style = CS_DBLCLKS; /* Catch double-clicks */ > wincl.cbSize = sizeof (WNDCLASSEX); > > /* Use default icon and mouse-pointer */ > wincl.hIcon = LoadIcon (NULL, IDI_APPLICATION); > wincl.hIconSm = LoadIcon (NULL, IDI_APPLICATION); > wincl.hCursor = LoadCursor (NULL, IDC_ARROW); > wincl.lpszMenuName = NULL; /* No menu */ > wincl.cbClsExtra = 0; /* No extra bytes after the window class */ > wincl.cbWndExtra = 0; /* structure or the window instance */ > /* Use Windows's default color as the background of the window */ > wincl.hbrBackground = (HBRUSH) COLOR_BACKGROUND; > > /* Register the window class, and if it fails quit the program */ > if (!RegisterClassEx (&wincl)) > return 0; > > /* The class is registered, let's create the program*/ > hwnd = CreateWindowEx ( > 0, /* Extended possibilites for variation */ > szClassName, /* Classname */ > "Windows App", /* Title Text */ > WS_OVERLAPPEDWINDOW, /* default window */ > CW_USEDEFAULT, /* Windows decides the position */ > CW_USEDEFAULT, /* where the window ends up on the screen */ > 544, /* The programs width */ > 375, /* and height in pixels */ > HWND_DESKTOP, /* The window is a child-window to desktop */ > NULL, /* No menu */ > hThisInstance, /* Program Instance handler */ > NULL /* No Window Creation data */ > ); > > > /* Make the window visible on the screen */ > ShowWindow (hwnd, nFunsterStil); > PrintBmp(hwnd, "BOARD.bmp"); > /* Run the message loop. It will run until GetMessage() returns 0 */ > while (GetMessage (&messages, NULL, 0, 0)) > { > /* Translate virtual-key messages into character messages */ > TranslateMessage(&messages); > /* Send message to WindowProcedure */ > DispatchMessage(&messages); > } > > /* The program return-value is 0 - The value that PostQuitMessage() gave */ > return messages.wParam; > } > > > /* This function is called by the Windows function DispatchMessage() */ > > LRESULT CALLBACK > WindowProcedure (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam) > { > switch (message) /* handle the messages */ > { > case WM_DESTROY: > PostQuitMessage (0); /* send a WM_QUIT to the message queue */ > break; > default: /* for messages that we don't deal with */ > return DefWindowProc (hwnd, message, wParam, lParam); > } > > return 0; > }

3 4

RFC: Use editline in winedbg
by Jeremy White 05 Dec '04

05 Dec '04

Hi folks, The attached patch dynamically detects and uses the BSD licensed editline library (a pretty close replacement for readline), if it's available. This gives winedbg command line recall. This gets around readline's license requirements. I'm nervous because I wasn't sure if that was the only issue with readline, or if there were further issues. Wack me with a clue bat if this is wrong, otw, I'll submit it. Cheers, Jeremy

5 6

Re: Janitorial: WinMM conversion of 32 bit low level drivers to Unicode interface
by Steven Edwards 05 Dec '04

05 Dec '04

--- Eric Pouech <pouech-eric(a)wanadoo.fr> wrote: > This patch is based on work by Filip Navara from ReactOS. > He did the Winmm part (+wave & midi mapper), I did the rest (+ 16 message mapping) > A+ Eric I just want you to know you are my personal hero. Someday they will write songs about you that I will listen to under ReactOS <g>. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Re: Fix for winedbg; disassemble range was flawed
by Jeremy White 05 Dec '04

05 Dec '04

This updated version prevents an infinite loop in the (currently impossible) case of a poorly specified disassembly range. Truth is, this functions interface is a bit awkward. Jeremy White wrote: > Changelog: > Properly respect a disassemble x,y command > (prior behavior would do y-x instructions, no matter > how wide each instruction was) > > > ------------------------------------------------------------------------ > > Index: programs/winedbg/debugger.h > =================================================================== > RCS file: /cvstrees/crossover/office/wine/programs/winedbg/debugger.h,v > retrieving revision 1.17 > diff -u -r1.17 debugger.h > --- programs/winedbg/debugger.h 28 Nov 2004 16:23:50 -0000 1.17 > +++ programs/winedbg/debugger.h 5 Dec 2004 04:30:24 -0000 > @@ -317,7 +317,7 @@ > extern BOOL memory_get_current_frame(ADDRESS* address); > extern BOOL memory_get_string(HANDLE hp, void* addr, BOOL in_debuggee, BOOL unicode, char* buffer, int size); > extern BOOL memory_get_string_indirect(HANDLE hp, void* addr, BOOL unicode, char* buffer, int size); > -extern void memory_disassemble(const struct dbg_lvalue*, const struct dbg_lvalue*, int offset); > +extern void memory_disassemble(const struct dbg_lvalue*, const struct dbg_lvalue*, int instruction_count); > extern BOOL memory_disasm_one_insn(ADDRESS* addr); > extern void print_bare_address(const ADDRESS* addr); > extern void print_address(const ADDRESS* addr, BOOLEAN with_line); > Index: programs/winedbg/memory.c > =================================================================== > RCS file: /cvstrees/crossover/office/wine/programs/winedbg/memory.c,v > retrieving revision 1.1.1.13 > diff -u -r1.1.1.13 memory.c > --- programs/winedbg/memory.c 28 Nov 2004 15:36:39 -0000 1.1.1.13 > +++ programs/winedbg/memory.c 5 Dec 2004 04:30:24 -0000 > @@ -598,9 +598,11 @@ > } > > void memory_disassemble(const struct dbg_lvalue* xstart, > - const struct dbg_lvalue* xend, int offset) > + const struct dbg_lvalue* xend, int instruction_count) > { > static ADDRESS last = {0,0,0}; > + int stop = 0; > + int i; > > if (!xstart && !xend) > { > @@ -613,7 +615,10 @@ > last.Mode = AddrModeFlat; > last.Offset = types_extract_as_integer(xstart); > } > - if (xend) offset = types_extract_as_integer(xend) - last.Offset + 1; > + if (xend) > + stop = types_extract_as_integer(xend); > } > - while (offset-- > 0 && memory_disasm_one_insn(&last)); > + for (i = 0; (instruction_count == 0 || i < instruction_count) && > + (stop == 0 || last.Offset <= stop); i++) > + memory_disasm_one_insn(&last); > }

1 0

Re: COMCTL32: Minor corrections
by Robert Shearman 05 Dec '04

05 Dec '04

Filip Navara wrote: > Changelog: > - Tooltip icons must be destroyed with DestroyIcon and not with > DeleteObject. > - Don't use DrawEdge with NULL device context, it's invalid call and > sets last error. > >------------------------------------------------------------------------ > >Index: lib/comctl32/datetime.c >=================================================================== >RCS file: /CVS/ReactOS/reactos/lib/comctl32/datetime.c,v >retrieving revision 1.5 >diff -u -r1.5 datetime.c >--- lib/comctl32/datetime.c 19 Sep 2004 09:50:06 -0000 1.5 >+++ lib/comctl32/datetime.c 4 Dec 2004 22:59:42 -0000 >@@ -1170,10 +1170,10 @@ > > TRACE("Height=%ld, Width=%ld\n", infoPtr->rcClient.bottom, infoPtr->rcClient.right); > >- /* use DrawEdge to adjust the size of rcEdge to get rcDraw */ > memcpy((&infoPtr->rcDraw), (&infoPtr->rcClient), sizeof(infoPtr->rcDraw)); > >- DrawEdge(NULL, &(infoPtr->rcDraw), EDGE_SUNKEN, BF_RECT | BF_ADJUST); >+ /* subract the size of the edge drawn by DrawEdge */ >+ InflateRect(&infoPtr->rcDraw, -2, -2); > > Please use GetSystemMetrics(SM_CXEDGE) and GetSystemMetrics(SM_CYEDGE). > > /* set the size of the button that drops the calendar down */ > /* FIXME: account for style that allows button on left side */ >Index: lib/comctl32/tooltips.c >=================================================================== >RCS file: /CVS/ReactOS/reactos/lib/comctl32/tooltips.c,v >retrieving revision 1.9 >diff -u -r1.9 tooltips.c >--- lib/comctl32/tooltips.c 20 Oct 2004 08:36:55 -0000 1.9 >+++ lib/comctl32/tooltips.c 4 Dec 2004 23:18:56 -0000 >@@ -2818,7 +2818,7 @@ > TOOLTIPS_Unregister (void) > { > int i; >- for (i = 0; i < TTI_ERROR+1; i++) >- DeleteObject(hTooltipIcons[i]); >+ for (i = TTI_INFO; i <= TTI_ERROR; i++) >+ DestroyIcon(hTooltipIcons[i]); > UnregisterClassW (TOOLTIPS_CLASSW, NULL); > } > > Someone already sent a patch for this (and it is my buggy code, sorry). Not sure why it didn't go in, but it should. Rob

3 2

Re: implement DllCanUnloadNow for dmusic
by Robert Shearman 04 Dec '04

04 Dec '04

James Hawkins wrote: >Changelog > * properly implement DllCanUnloadNow ref counting > > > Sorry, still isn't correct. Please see my comments below. >------------------------------------------------------------------------ > >Index: dlls/dmusic/buffer.c >=================================================================== >RCS file: /home/wine/wine/dlls/dmusic/buffer.c,v >retrieving revision 1.8 >diff -u -r1.8 buffer.c >--- dlls/dmusic/buffer.c 6 Sep 2004 21:34:25 -0000 1.8 >+++ dlls/dmusic/buffer.c 4 Dec 2004 20:52:16 -0000 >@@ -38,6 +38,9 @@ > ULONG WINAPI IDirectMusicBufferImpl_AddRef (LPDIRECTMUSICBUFFER iface) { > IDirectMusicBufferImpl *This = (IDirectMusicBufferImpl *)iface; > TRACE("(%p): AddRef from %ld\n", This, This->ref); >+ >+ DMUSIC_LockModule(); >+ > return ++(This->ref); > } > >@@ -45,9 +48,13 @@ > IDirectMusicBufferImpl *This = (IDirectMusicBufferImpl *)iface; > ULONG ref = --This->ref; > TRACE("(%p): ReleaseRef to %ld\n", This, This->ref); >+ > if (ref == 0) { > HeapFree(GetProcessHeap(), 0, This); > } >+ >+ DMUSIC_UnlockModule(); >+ > return ref; > } > >@@ -160,6 +167,8 @@ > } > dmbuff->lpVtbl = &DirectMusicBuffer_Vtbl; > dmbuff->ref = 0; /* will be inited by QueryInterface */ >+ >+ DMUSIC_LockModule(); > > return IDirectMusicBufferImpl_QueryInterface ((LPDIRECTMUSICBUFFER)dmbuff, lpcGUID, ppobj); > } > > Ok, think about this sequence of events that should leave the DLL ref count at 0: 1. Create an IDirectMusicBufferImpl object. 1a. Calls LockModule. 1b. Calls QueryInterface which calls LockModule. 2. Call Release, which calls LockModule. The solution is to either remove the LockModule from the constructor, or to remove the LockModule from the AddRef and only call UnlockModule in the destructor part of Release. This issue is also present in the other files in your patch (not quoted here). I should have thought about this before when I commented on your last patch. I guess I need to put some tests together for this feature. Rob

2 2

DInput has been broken for about 6 months now
by Scott Ritchie 04 Dec '04

04 Dec '04

Well, one of my favorite games, Fallout 2, didn't work when I tried it. This is strange though, as it was working about 3 years ago. Looking through the AppDB page, http://appdb.winehq.org/appview.php?appId=194&versionId=319 - it looks like it's been broken since June. Specifically, here's the symptoms: "DXGRAB" = "Y" will cause the app to completely takeover and lockup the system, except no input into the app (mouse or keyboard) works. I have to ctrl-alt-f2 and killall -9 wine-preloader to get back to work. Turning off DXGRAB causes the app to respond to keyboard input, but the mouse still doesn't work. Some very strange things happened in gnome when I brought my email window in front of the app (the mouse would skip from the edge of the gnome window past the app, making it impossible to click on, and other wierdness. However, none of this translated into the in-game cursor moving) I'm running the app in Desktop=640x480 mode. Furthermore, it appears that some of the old problems listed in the AppsDB page are still there - the game is very slow at certain points (well, the loading and unloading I can do with the keyboard...), and I'm running a computer roughly 10 times as fast as was designed for the game. After asking about on the channel a bit, the finger was pointed at DINPUT. I think some of the problems with DINPUT would make a fairly good candidate for something to tackle on Sunday, although doing a >6 month regression test could be annoying. I personally know about 3 people I could get to switch to Wine entirely if we could get this working :) I haven't filed a bugzilla report yet, but if it helps I will. Thoughts? -Scott Ritchie

1 0

Re: New Canadian keyboard layout
by Dmitry Timoshkov 04 Dec '04

04 Dec '04

"Jean-Michel Dault" <jmdault(a)revolutionlinux.com> wrote: > I'm doing a pilot project for the Quebec government, and we have one > major problem: they have a keyboard layout that's unsupported by Wine, > though it was commited to XFree about 3 years ago. What do you mean by "unsupported by Wine", is that just a warning that you see? What exactly doesn't work without this patch? -- Dmitry.

4 4

Making the Documentation into help files
by Scott Ritchie 04 Dec '04

04 Dec '04

While making the Debian package, I had to do a special hack to compile wine's documentation because it's made seperately. This isn't a really big deal, but what I did realize is that Wine's documentation doesn't get installed to the help menu now coming standard on systems. When I select Applications->Help from the menu in Ubuntu, there's a whole list of documentation for available installed applications. I managed to get the install script to copy txt versions of the stuff in the documentation folder to the standard /usr/share/doc/wine, but this place remains bereft of wine documentation. So, how is this done? I presume there's a freedesktop.org standard for these things, as both Gnome and KDE have them in the same way, but currently we're not converting the documentation sgml files into these help files. Coincidentally, this might tie in very well to the desktop integration tasks suggested this week. Perhaps we should create a desktop integration tasklist or even append it onto the 1.0 todo? Trying to further improve usability, Scott Ritchie

3 2

Wine book
by Brian Vincent 04 Dec '04

04 Dec '04

Just wanted to give everyone a heads up.. I followed up with Jeremy's email a few months ago about a publisher wanting to put together a book on Wine. Yep, I have no life and 400 pages can't be that hard to write. Well, we started the ball rolling and now it looks like it's going to happen. I should be signing the contract in a few days. There's lots of details I thought you guys might be interested in. You'll find the chapter outlines[1] at the bottom of this email. This book is oriented at users and Winelib developers. It's not a book about how to hack Wine internals. One thing I'll try to keep in mind as I'm writing is how to entice people to get involved with development. I think it's important to try to get people involved in the community. I'm not going to be writing this alone. Ira Krakow, a Boston native, will be writing the Winelib parts. I didn't feel comfortable doing those and Ira had approached the publisher separately about doing a book on porting Windows apps. We've chatted a few times and I'm confident that given his experience he'll do well. I'm cc:ing him on this email by way of introduction and I'm sure at some point in the future he'll have a question or two (or 50.) The publisher is Prentice-Hall. Thus far they've been excellent to work with and they really seem to just "get it" when it comes to open source projects. Specifically, this book will fall into their Bruce Perens' Open Source Series [2]. After the book is published, it will be available for a short time only in a dead tree version. After a few months it will be available under the Open Publication License [3]. It's a good license and contains many things I think are important. Also, I'd like to thank everyone who reviewed the initial proposal. That process happened really fast and I wasn't even aware it had been sent out for review until after you guys got the emails. There was lots of good feedback in there and I incorporated a lot of it in the final proposal that got approved (you may even notice some changes in the chapters below as a result.) Some other things you guys mentioned aren't specifically in this chapter outline, but I made some notes as to what needs to be addressed. Thanks again. Anyone who didn't see that proposal, you didn't miss much. It was lots of marketspeak. The key is the chapter outline below, so if you have any comments about what I'm overlooking, _please_ let me know. [1] Chapter outlines: Title: "Wine: Running Windows Applications on Linux" [4] 1. Wine Introduction[15 pages] What is Wine? How Can Wine Help You? An Introduction to Windows Components Overview of Wine's Components Recent Changes to Wine A History of the Wine Project How Can You Get Wine? 2. Installing Wine [20 pages] System Requirements Bundled Versions Downloading Packaged Versions Accessing CVS Compiling and Installing Wine Uninstalling Wine 3. Configuring Wine [35 pages] Introduction to Winecfg Windows Versions Libraries: Native vs. Builtin Application Settings Drive Configuration Serial and Parallel Ports Network Shares Fonts Printing Database Access 4. Installing Applications [35 pages] Basic Installation Common Installation Pitfalls Resources to Help With Installation Adding Native Libraries Installing Games Copy Protection Pitfalls Using Native DirectX 5. Installing Common Programs [35 pages] Microsoft Office Adobe Photoshop File Utilities Peer-to-Peer Applications Further Help: The Wine Application Database 6. Linux, Wine, and Windows Integration [40 pages] Integrating with Desktop Environments KDE and GNOME Integration Wine Tools Introduction Wineshelllink Wineprefixcreate Regedit Understanding the Wine Registry Changing the Registry Importing an Existing Registry Using an Existing Windows Partition 7. Enterprise Deployment [30 pages] Licensing Considerations Understanding Windows and Wine Security Automating Deployment of Applications Scripting Wine Citrix Killer: Wine and the Linux Terminal Server Project Performance Tweaks Reporting Bugs and Working with Developers 8. Commercial Alternatives: CodeWeaver's CrossOver Office [25 pages] Introduction to CrossOver Office Downloading and Installing CrossOver Configuring CrossOver Installing Applications with CrossOver 9. Commercial Alternatives: TransGaming's Cedega [25 pages] Introduction to Cedega Downloading and Installing Cedega Configuring Cedega Installing Games with Cedega 10. Introduction to Winelib [20 pages] Introduction to Winelib Licensing Considerations Portability Considerations Getting Started Understanding the Winelib toolkit A Roadmap for Porting Installation of the MinGW Compiler 11. Using Winelib for Porting [45 pages] Installation of the MinGW compiler Moving From Visual Studio to MinGW Tips and Tricks for Changing Compilers Moving Development to Linux Using Winemaker Using the Wine Resource Compiler Using the Wine Message Compiler Linking it Together: winegcc Debugging with the Wine debugger 12. Case Study: Porting a To-Be-Determined Application [30 pages] 13. Advanced Porting Techniques [25 pages] C++ Problems Working with Microsoft Foundation Classes Working with Templates Moving From Visual Studio to MinGW 14. dvanced Library Techniques [20 pages] Getting Started: Why Share Libraries? Using Linux Libraries with Winelib Applications Using Windows Libraries with Winelib Applications Why Wine is not a Shared Library [2] Peren's Open Source Series info: http://phptr.com/promotion/1484?redir=1 [3] OPL license: http://www.opencontent.org/openpub/ a good discussion of it: http://lwn.net/Articles/108250/ [4] With regards to the title, I'll be sure to mention in Wine runs on other operating systems. PS. This still leaves the door open for someone to write an O'Reilly book. PPS. I'd like to think this won't affect WWN because I really have no life. However, that's not too realistic. Hopefully WWN won't suffer too much. - Brian Vincent

7 9

Re: [resend] shell32 tests
by Rolf Kalbermatter 04 Dec '04

04 Dec '04

>+static HMODULE hshell32; >+static int (WINAPI *pSHCreateDirectoryExA)(HWND, LPCSTR, LPSECURITY_ATTRIBUTES); >+ >+static void InitFunctionPointers(void) >+{ >+ hshell32 = GetModuleHandleA("shell32.dll"); >+ >+ if(hshell32) >+ pSHCreateDirectoryExA = (void*)GetProcAddress(hshell32, "SHCreateDirectoryExA"); >+} >+ > /* creates a file with the specified name for tests */ > void createTestFile(CHAR *name) > { >@@ -398,17 +409,19 @@ > int ret; > > set_curr_dir_path(path, "testdir2\\test4.txt\0"); >- ret = SHCreateDirectoryExA(NULL, path, NULL); >+ ret = pSHCreateDirectoryExA(NULL, path, NULL); I think this is not right. Implementing dynamic loading of functions in tests is supposedly because that function may not be available on some systems. But here you invoke the (maybe uninitialized, or NULL assigned) function pointer nevertheless without protecting for this. As such your patch does only allow loading the test on such systems but will create a nice crash when run. Rolf Kalbermatter

1 0

2nd attemp at DllCanUnloadNow
by James Hawkins 03 Dec '04

03 Dec '04

This time I respect heap-based objects, leaving there internal ref counts and respective HeapFree's. I also took Alexandre's suggestions and changed Un/LockServer to DMCOMPOS_LockServer etc and change cLocks to refCount. Let me know if this is any closer to what it needs to be. Thanks. -- James Hawkins

2 1

Re: Wine book
by Ivan Leo Puoti 03 Dec '04

03 Dec '04

> The 'high level' parts (like d3drm) should work too, No program or sdk sample I know of and uses this dll currently works on wine. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Register IME class at startup?
by Ivan Leo Puoti 03 Dec '04

03 Dec '04

On windows xp/2k the IME window class appears to be always registered, even if a program doesn't link to nor loads imm32, the class is registered. How should this be handled in wine, should the class be registered at startup? Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: wine-preloader defunct
by James Hawkins 03 Dec '04

03 Dec '04

On Thu, 02 Dec 2004 20:01:48 -0800, Kenneth Porter <shiva(a)sewingwitch.com> wrote: > I've now got several instances of "[wine-preloader] <defunct>" in my ps > listing from a game server that's died in some strange way. Anyone have > experience in clearing these short of bouncing the whole box? They're > holding onto a couple of TCP ports that I'd like to use. The ports are > stuck in CLOSE_WAIT, because the processes are stuck in memory so the > sockets can't close. > > Does 'kill -9 processnum' not work? -- James Hawkins

6 10

Re: Implement GetLayout
by Shachar Shemesh 03 Dec '04

03 Dec '04

Rémi Assailly wrote: > I added some things to my previous patch. > Please tell me if something seems incorrect or is missing > Thanks ;) > > Changelog: > * implement GetLayout Thanks for spotting another one for my growing heap of BiDi TODOs.... http://bugs.winehq.org/show_bug.cgi?id=2584 Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: rsaenh/implglue.c: Added missing break
by Marcus Meissner 03 Dec '04

03 Dec '04

On Fri, Dec 03, 2004 at 11:49:22AM +0100, Michael Jung wrote: > Greetings, > Michael > > Changelog: > Added a missing break in encrypt_block_impl > > Index: dlls/rsaenh/implglue.c JFYI, we (Novell) are now working on reapproving WINE for US export due to your cryptographic library import. I will keep you posted, but I expect approval. Actually, in the closest meaning of the export regulations, I am not even allowed to build RPMs for SourceForge anymore here at SUSE/Novell :( Fun without end, I had hoped we keep openssl dynamic linking ;) Ciao, Marcus

2 2

Providing success stories
by Stefan Munz 03 Dec '04

03 Dec '04

Hi, I already mailed with some developers a few days ago. Basicly wether and in which way the wine logo can be used to communicate wine compatibility for software producers (this is already solved). For those who didn't read it, i copied a passage of the orig. mail: --- In order to push the use of Open Source Software we plan a project with the "Wirtschaftsförderung Region Stuttgart GmbH" (I don't know whats the equivalent in english but its a public organization that promotes OSS and assists companies that resident in Stuttgart). Within this project we want to find software producers who pay us for a wine compatibility test of their software. --- This project is starting at the moment. I thought a good idea to give something back to the community is to provide some success stories i.e. for use on winehq.com. Is this interesting? If the answer is yes, who is responsible for something of the kind. Regards, Stefan Munz

1 0

Preliminary Darwine SDK Released
by Sanjay Connare 03 Dec '04

03 Dec '04

Hello All, I have released a preliminary version of the Darwine SDK version 0.1. Many people are interested in getting Darwine up and running so they can compile programs on OS X and this release should satisfy their curiosity. The SDK features the following: -source code for the current Darwine binary 20040820 -source code for WineHelper -Xcode Integration -Xcode Template -Updated Uninstaller The Xcode integration allows for a user to compile windows source code from within the Xcode IDE using the wine tools. Users may want to note that there are some changes to the way Darwine is installed and functions. Due to limitations in Xcode, the wine source tools such as winegcc, winemaker, winebuild are installed in the /usr/bin directory and not the /Library/Darwine/bin directory. This may be changed in a future release but was necessary so Xcode integration would work correctly. As a result there is an updated uninstaller as well. The uninstaller will remove everything except for the Xcode project template folder, which is moved to the trash and needs to be removed manually. To start a new Darwine project, simply launch Xcode, select new project, and select Darwine (Windows) Application. Currently in Xcode the "Build and Run" does not work, it will build the program but not launch. However, the Build button works as expected. When compiling a Darwine application for the first time Xcode may give the error: "ld: table of contents for archive: /Library/Darwine/lib/wine/lib<name>.a is out of date; rerun ranlib(1) (can't load from it)" Open a terminal and type the following command: "sudo ranlib /Library/Darwine/lib/wine/lib<name>.a" <name> being replaced by the name of the library whose table of contents is out of date. The source code should then compile fine. There are many examples of source in the wine source code "programs" folder which is located in the root of the source directory. Simple programs should compile fine. However, bigger programs that depend on more of the windows headers will probably not compile due to header incompatabitlies between the wine and OS X headers. You can download the preliminary release here http://prdownloads.sourceforge.net/darwine/Darwine_SDK0.1.dmg?download or through the Darwine web site http://darwine.opendarwin.org Post any comments, questions or concerns to the Darwine Mailing List "darwine-devel(a)lists.sourceforge.net" . Remember this is a preliminary release and there are many bugs and issues that need to be worked out and features that need to be implemented. More information will be posted on the Darwine website in the near feature. Last but not least enjoy. Sanjay Connare

1 0

wine-preloader defunct
by Kenneth Porter 03 Dec '04

03 Dec '04

I've now got several instances of "[wine-preloader] <defunct>" in my ps listing from a game server that's died in some strange way. Anyone have experience in clearing these short of bouncing the whole box? They're holding onto a couple of TCP ports that I'd like to use. The ports are stuck in CLOSE_WAIT, because the processes are stuck in memory so the sockets can't close.

1 0

Suggestions for fixing test?
by Jakob Eriksson 03 Dec '04

03 Dec '04

http://test.winehq.org/data/200412011000/xp_IDWASEMPTY/gdi32:metafile.txt Any suggestions for fixing this? regards, Jakob

2 5

Re: shell32: reduce version to win2k
by Dmitry Timoshkov 03 Dec '04

03 Dec '04

"Juan Lang" <juan_lang(a)yahoo.com> wrote: > I hope this removes the IE6 regression. No, it doesn't. It turned out that it's something different that causes a regression, lowering down version of shell32 changes nothing. It seems that a better solution is to add missing images to shell32. We need at least the following bitmaps to make IE display images on toolbars: id 230/231 - they are the same with different brightness, 20x20 1 image id 227/228 - they are the same with different brightness, 24x24 6 images id 204/205 - they are the same with different brightness, 24x24 16 images id 214/215 - they are the same with different brightness, 24x24 47 images id 240 - 22x22 50 vertical images (animated windows logo) -- Dmitry.

1 0

RE: Treeview +/-
by Ge van Geldorp 02 Dec '04

02 Dec '04

> From: Jon Griffiths > > >Maybe the height/width at which to switch to the Rectangle drawing > >algorithm needs a bit of tuning? > > Ge, Can you confirm this fixes the size for you? It works for > me if I change my system font to a larger one... Yes, this works for me. Thanks. Ge van Geldorp.

1 0

automatic tests screwed up again
by Ivan Leo Puoti 02 Dec '04

02 Dec '04

In the reports page the link to the tests points to http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-200411251000… and this is probably what the server tells winrash to download, but it returns a 404. The test actually is at http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-200411251000… can someone please fix this? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Re: [OLE #2] Provide Reference Implementation of DllCanUnloadNow
by Dmitry Timoshkov 02 Dec '04

02 Dec '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > -DWORD dll_ref = 0; > +LONG cLocks; ... > +/********************************************************************** > + * Dll lifetime tracking declaration > + */ > +void LockModule() > +{ > + InterlockedIncrement(&cLocks); > +} > + > +void UnlockModule() > +{ > + InterlockedDecrement(&cLocks); > +} Perhaps it would be better to prefix both a variable and lock/unlock interfaces with a module name, in this case "DEVENUM_" since they are global and externally visible. -- Dmitry.

4 5

Re: IME window class update
by Ivan Leo Puoti 02 Dec '04

02 Dec '04

> You mean 65535, in which case it'd be 0xffff? Nope, just doubled checked and with the value is 65553, or 0x10011. Ivan. ____________________________________________________________ Libero ADSL: 3 mesi gratis e navighi a 1.2 Mega, senza costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: IME window class update
by Andreas Mohr 02 Dec '04

02 Dec '04

Hi, On Thu, Dec 02, 2004 at 04:38:39PM +0100, Ivan Leo Puoti wrote: > This patch is based on the IME window class implemented in windows 2000 and xp. > On both OSes hCursor is 65553, but I don't know what that is, maybe it's a > custom IME cursor? You mean 65535, in which case it'd be 0xffff? No idea what kind of cursor that is, but it looks like an invalid/unused one... Andreas Mohr

1 0

attemp at implementing DllCanUnload now for dcompos
by James Hawkins 02 Dec '04

02 Dec '04

Hey all, It would really help me out if you could look over this patch and see if I've incorrectly implemented ref-counting and DllCanUnloadNow for dcompos. I used suggestions from Rob and a sample implementation written by him. The only concern I have is that I'm not sure if all of these classes are non-heap based. -- James Hawkins

3 3

Re: systray rewrite part 2
by Grant Williamson 02 Dec '04

02 Dec '04

Mike, ok the rewrite, applies & compiles cleanly on 20041019, however, running SIP Phone-lite, it does not show on the systray, the older patch did. I am running gnome-2.8 on rhel4, what program do you want us to test with it. Mike Hearn wrote: >Clearly, I need to figure out a system for generating patches. This time >with (hopefully) all the files in the patch. > >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > >------------------------------------------------------------------------ > > > >

2 3

SHBrowseForFolder
by Robert van Herk 02 Dec '04

02 Dec '04

Hi all, I am trying to implement the Browse button in the winecfg application, that would allow people to browse for a directory to use as their virtual c drive. In order to do so, I though I'd use the SHBrowseForFolder function from shlobj.h (see http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…). However, when I tried this in Wine, I get a compiler warning: In driveui.c I did: case IDC_BUTTON_BROWSE_PATH: SHBrowseForFolder(0); //MessageBox(dialog, "", "Write me!", MB_OK); break; Then, at compile time I get: driveui.c:589: warning: undefined reference to `SHBrowseForFolderA' I made sure that there is a line that says: #include <shlobj.h> When I try to launch the app, I get ./winecfg wine: could not load L"Z:\\home\\robert\\Documents\\devel\\wine\\programs\\winecfg\\winecfg.exe.so": /home/robert/.wine/dosdevices/z:/home/robert/Documents/devel/wine/programs/winecfg/winecfg.exe.so: undefined symbol: SHBrowseForFolderA Does this mean that the SHBrowseForFolder thing is not implemented? Probably it is, because I checked Wine's shlobj.h. What am I doing wrong? Thanks, Robert

9 33

Re: Implement GetLayout
by Shachar Shemesh 02 Dec '04

02 Dec '04

Rémi Assailly wrote: > Shachar Shemesh wrote : > >> Thanks for spotting another one for my growing heap of BiDi TODOs.... >> >> http://bugs.winehq.org/show_bug.cgi?id=2584 >> >> Shachar >> > I know that there is no effect... I'm sorry if I came off cynical. There was no cynicism in that comment. I opened 2584 as a result of seeing your patch. I was not aware of this particular missing functionality. I'm aiming for http://bugs.winehq.org/show_bug.cgi?id=609 to be the ultimate documentation of all BiDi APIs in Windows. Opening 2584 is a good thing, as it documents things that are still to be done. > What is wrong ? It seems that this flag reverses the meaning of several common conventions (left/right etc.). The idea is probably so that applications that are natively right to left not have to change their design too much. I can't tell you exactly what it means, however, as I don't know myself. It will probably be a matter of comparing behaviors to the real Windows. I have some doubts about whether anyone is even using this flag at all. Maybe on localized Hebrew Windows, where the whole window decorations are reversed (Ughh. My GF has localized XP Home installed. This thing is horrible, but I didn't spot any non-Windows native applications that were affected by it). > Tell me and I will help you, if you want... I'll gladly accept all the help I can get. Basically, this particular unimplemented bit requires writing small test programs on Windows, and then running them on Wine until they produce the same results. The idea is that you read the MSDN page for the function (linked from the bug). That page also links to http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/wi…, which gives more details on what this flag is supposed to mean. If you check out 2584 again, you will see I added this new information there. The steps one takes is to read all the relevant manuals, and try to understand what this means. Next, you write a small test program that does stuff with and without this flag, showing where this flag takes effect on Windows. Next, you move this test program to Wine and start tweaking Wine until it behaves the same there. There is also a last step, which is to make this program into a test suite, returning success or failure. I'm not sure, however, how that is supposed to be done for programs where success and failure are measured with graphical output. Hope this helps you help me help everyone..... :-) Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: [OLE #3] Tests For COM Functions
by Dmitry Timoshkov 02 Dec '04

02 Dec '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > I have only tried these tests on WinXP SP2. Please report > if they fail on Win9x. In order compile the tests with Platform SDK I applied the attached patch. Under win2k SP4 I got: marshal.c:898: Test failed: CoGetClassObject should have returned CO_E_SERVER_STOPPING instead of 0x80040154 Under Win95 the tests don't run due to missing APIs CoResumeClassObjects and CoInitializeEx. -- Dmitry.

1 1

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory;
by Rolf Kalbermatter 01 Dec '04

01 Dec '04

Robert van Herk wrote: >-LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) >+static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode aBrowseMode) >+{ >+ INT_PTR ret; >+ >+ browseMode = aBrowseMode; ^^^^^^^^^^ I may miss something here but this looks like a global variable and that would make these function theoretically thread unsafe. As long as only winecfg is going to use this functionality for the unix case it seems not a problem as there is probably not any chance that the native Windows version is called at that moment but this may of course change in the future. Rolf Kalbermatter

3 5

MAP_ANON support on HPUX
by Warren_Baird/CSI＠cimmetry.com 01 Dec '04

01 Dec '04

Hi All, I've just discovered that HP-UX's mmap implementation doesn't define MAP_ANON, it only defines MAP_ANONYMOUS. linux defined both, as does solaris (and solaris's manpage actually states that MAP_ANON is deprecated), but MacOS X seems to only define MAP_ANON MAP_ANON is only used in two source files: libs/wine/mmap.c and loader/preloader.c. My proposed patch involves slightly different changes in both places : in mmap.c, I just add a new #elif to handle the case, and in preloader.c I add a #ifdef block at the top to define MAP_ANON to be MAP_ANONYMOUS if MAP_ANON is undefined, but MAP_ANONYMOUS is defined. The other possible solution would be to put the #ifdef block from preloader.c into a common header... It's not obvious to me where to put it, though, which is why I'm proposing this patch. Should I rework it to use a common header? If so - any suggestions as to which header would be appropriate? Thanks, Warren

1 0

Bugzilla in CVS
by Jeremy Newman 01 Dec '04

01 Dec '04

http://cvs.winehq.org/cvsweb/bugzilla/ I have imported our buzilla into CVS for anyone to start submitting patches on. If I remember correctly, it is a fairly straight branch of version 2.17.4. All I modified was the templates in: /template/en/default/global Enjoy!

2 1

Fwd: Re: Bug Busters
by Peter Hartshorn 01 Dec '04

01 Dec '04

May I suggest that the times given are GMT and at least one days notice so everyone who wants to join in can, no matter where they are on the planet. On Wed, 1 Dec 2004 04:10 pm, James Hawkins wrote: > On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <adam(a)nemesys.ca> wrote: > > James Hawkins wrote: > > > I have a totally non-original idea for sessions called Bug Busters > > > where, at a designated time, a group of wine developers would get > > > together on #winehackers (or some other channel). We would pick a bug > > > (or maybe more) from wine's bug tracker and work together to fix the > > > bug(s). This would serve several good purposed. First, we would be > > > giving more attention to wine's bugzilla and getting rid of a lot of > > > those bugs. Second, many newcomers can witness and take part in the > > > wine development process. I'm sure everyone can remember how daunting > > > it is to jump into wine development. Anyway, if anyone has any ideas > > > or would like to take part in this, let me know and we'll get this > > > started. > > > > This is a good idea, same idea as Gentoo Bug Days, and those have been > > extremely successful. > > Awesome, I think it could be really successful with wine too. -------------------------------------------------------

1 0

Re: Resend [AppDB] show total number of maintainers and applications in the appMaintainers table
by Jeremy Newman 01 Dec '04

01 Dec '04

This patch fails to apply to the tip. Update and resend. On Sun, 2004-11-21 at 09:50 -0700, Tony Lambregts wrote: > There was a bug in last one, use this instead. > > Change Log: Show the total number of maintainers and applications in the > appMaintainers table in the admin menu > > Files Changed: include/sidebar_admin.php include/util.php > > > Index: include/sidebar_admin.php > =================================================================== > RCS file: /home/wine/appdb/include/sidebar_admin.php,v > retrieving revision 1.4 > diff -u -r1.4 sidebar_admin.php > --- include/sidebar_admin.php 10 Nov 2004 16:36:25 -0000 1.4 > +++ include/sidebar_admin.php 21 Nov 2004 07:50:43 -0000 > @@ -19,7 +19,7 @@ > $g->add("List Users", $apidb_root."admin/"); > $g->add("View App Queue (".getQueuedAppCount().")", $apidb_root."admin/adminAppQueue.php"); > $g->add("View Maintainer Queue (".getQueuedMaintainerCount().")", $apidb_root."admin/adminMaintainerQueue.php"); > - $g->add("View Maintainers", $apidb_root."admin/adminMaintainers.php"); > + $g->add("View Maintainers (".getMaintainerCount().")", $apidb_root."admin/adminMaintainers.php"); > $g->done(); > > } > Index: include/util.php > =================================================================== > RCS file: /home/wine/appdb/include/util.php,v > retrieving revision 1.4 > diff -u -r1.4 util.php > --- include/util.php 9 Nov 2004 22:51:38 -0000 1.4 > +++ include/util.php 21 Nov 2004 07:50:43 -0000 > @@ -189,4 +189,13 @@ > return $ob->queued_maintainers; > } > > +/* get the total number of maintainers and applications in the appMaintainers table */ > +function getMaintainerCount() > +{ > + $qstring = "SELECT count(*) as maintainers FROM appMaintainers"; > + $result = mysql_query($qstring); > + $ob = mysql_fetch_object($result); > + return $ob->maintainers; > +} > + > ?> > > > >

1 0

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does
by pvriens＠xs4all.nl 01 Dec '04

01 Dec '04

Hi, just wanted to mention the fact that after this fix, my ZooTycoon demo installs like a charm. It doesn't run yet, but I will look into this and hopefully come up with some answers/patches. I guess several Microsoft Game Installers will work as well now. Good stuff. Cheers, Paul Vriens.

1 0

Re: gdi/mfdrv BS_PATTERN brushes
by Huw D M Davies 01 Dec '04

01 Dec '04

On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote: > > This fixes the problem that Emanuele Gisi reported last month in the Aloha > problem. With this patch BS_PATTERN brushes get created correctly and > don't cause a locking problem. > > Changelog: > Fix creation of BS_PATTERN brushes in mfdrv > > > Index: dlls/gdi/mfdrv/objects.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v > retrieving revision 1.14 > diff -u -r1.14 objects.c > --- dlls/gdi/mfdrv/objects.c 22 Nov 2004 18:19:59 -0000 1.14 > +++ dlls/gdi/mfdrv/objects.c 30 Nov 2004 06:10:03 -0000 > - mr->rdFunction = META_DIBCREATEPATTERNBRUSH; > + mr->rdFunction = META_CREATEPATTERNBRUSH; Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record under Windows? Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Bug Busters
by James Hawkins 01 Dec '04

01 Dec '04

I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel). We would pick a bug (or maybe more) from wine's bug tracker and work together to fix the bug(s). This would serve several good purposed. First, we would be giving more attention to wine's bugzilla and getting rid of a lot of those bugs. Second, many newcomers can witness and take part in the wine development process. I'm sure everyone can remember how daunting it is to jump into wine development. Anyway, if anyone has any ideas or would like to take part in this, let me know and we'll get this started. -- James Hawkins

7 18

which classes support aggregation?
by James Hawkins 01 Dec '04

01 Dec '04

IClassFactory->CreateInstance aggregation check: "The CreateInstance method of IClassFactory takes pUnkOuter as the second member. This parameter must be null unless the class supports aggregation, which many don't." Where can I find out which classes support aggregation? -- James Hawkins

3 2

implementing DllCanUnloadNow questions
by James Hawkins 01 Dec '04

01 Dec '04

I sent this message a couple months ago, but I got no response so I'll try again. I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. Is LockServer(TRUE/FALSE) the same as this example? static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { IClassFactoryImpl *This = (IClassFactoryImpl *)iface; FIXME("(%p)->(%d),stub!\n",This,dolock); return S_OK; } If they are the same, what is needed to complete this stub? I would think that there would be a refCount variable that is incremented if dolock is true and decremented if dolock is false. Also, should the LockServer functions be listed in the spec files of the dlls? After implementing LockServer, it should be an easy matter to do a check for refCount == 0 to see if the dll can be unloaded or not. Am I heading in the right direction? -- James Hawkins

3 4

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does
by Robert Shearman 01 Dec '04

01 Dec '04

Dmitry Timoshkov wrote: >Hello, > >there is at least one application which crashes in CreateThread due >to a race between a creating thread and a newly created one. The problem >is that the tid address passed to CreateThread resides in the memory >block allocated with VirtualAlloc which gets freed once the newly created >thread starts running, and when CreateThread code attempts to store thread >id it crashes. > >It appears that Windows always creates suspended threads in CreateThread >and a created thread gets resumed later. Here is a snippet of the log >running a simple test program under NT strace (the test app just creates >a thread): > >hThread = CreateThread(NULL, 0, thread_proc, NULL, 0, &tid); >CloseHandle(hThread); > >... >117 796 792 NtCreateThread (0x1f03ff, 0x0, -1, 1243704, 1244568, 1, ... 60, {796, 800}, ) == 0x0 >118 796 792 NtRequestWaitReplyPort (40, {28, 52, new_msg, 0, 2013529912, 2147348480, 902, 2086471576} "\0\0\0\0\1\0\1\0x\1\23\0\320<\23\0<\0\0\0\34\3\0\0 \3\0\0" ... {28, 52, reply, 0, 796, 792, 2138, 0} "\0\0\0\0\1\0\1\0\0\0\0\0\320<\23\0<\0\0\0\34\3\0\0 \3\0\0" ) == 0x0 >119 796 792 NtResumeThread (60, ... 1, ) == 0x0 >120 796 792 NtClose (60, ... ) == 0x0 >... > >Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Always create a suspended thread in CreateThread and resume it > if CREATE_SUSPENDED flag is not set as Windows does. > >--- cvs/hq/wine/dlls/kernel/thread.c 2004-09-22 16:48:59.000000000 +0900 >+++ wine/dlls/kernel/thread.c 2004-12-01 18:04:52.000000000 +0800 >@@ -164,7 +164,7 @@ HANDLE WINAPI CreateRemoteThread( HANDLE > if (flags & STACK_SIZE_PARAM_IS_A_RESERVATION) stack_reserve = stack; > else stack_commit = stack; > >- status = RtlCreateUserThread( hProcess, NULL, (flags & CREATE_SUSPENDED) != 0, >+ status = RtlCreateUserThread( hProcess, NULL, TRUE, > NULL, stack_reserve, stack_commit, > THREAD_Start, info, &handle, &client_id ); > if (status == STATUS_SUCCESS) >@@ -172,6 +172,19 @@ HANDLE WINAPI CreateRemoteThread( HANDLE > if (id) *id = (DWORD)client_id.UniqueThread; > if (sa && (sa->nLength >= sizeof(*sa)) && sa->bInheritHandle) > SetHandleInformation( handle, HANDLE_FLAG_INHERIT, HANDLE_FLAG_INHERIT ); >+ if (!(flags & CREATE_SUSPENDED)) >+ { >+ DWORD ret; >+ >+ status = NtResumeThread( handle, &ret ); >+ if (status) >+ { >+ NtTerminateThread( handle, -1 ); >+ RtlFreeHeap( GetProcessHeap(), 0, info ); >+ SetLastError( RtlNtStatusToDosError(status) ); >+ handle = 0; >+ } >+ } > } > else > > I think you should close the thread handle in the error case, otherwise it will be leaked. Rob

1 0

Debian Packages Almost Ready
by Scott Ritchie 01 Dec '04

01 Dec '04

Debian packages are almost done. I have them up for testing. Add the following to /etc/apt/sources.list deb http://tuzakey.com/~scott/ binary/ deb-src http://tuzakey.com/~scott/ source/ My friend's webserver can't handle the huge bandwidth permanent hosting of packages like this will require, so if there's a way we could put them up on winehq it would be nice. I'd like to have an apt repository here, so installing the latest debian wine package would be as simple as adding something like the above line to sources.list and then doing things as normal. What would be ideal, of course, is if the package could be included in the Debian distribution itself. I've yet to hear back from Ove (the current maintainer of the package), and unless he's disappeared entirely there's really nothing that can be done until he decides to update the package or orphan it, as Debian maintainers have total control over their packages. Ubuntu is a different matter, however, and I may be able to get an Ubuntu version included much quicker. If you're a Debian/Ubuntu user, test out the packages and tell me if I left anything out. Thanks, Scott Ritchie

1 0

Small WinMM janitorial project
by Steven Edwards 01 Dec '04

01 Dec '04

Hi, With this patch it is possible to use a few Windows sound drivers under ReactOS but I have only submitted patches for one small part of this because its going to require a bit of rework of the existing WinMM code. This should fix 2 of the existing W->A CrossCall issues # dlls/winmm/winmm.c: winmm: waveInGetDevCapsW: illegal call to waveInGetDevCapsA # dlls/winmm/winmm.c: winmm: waveOutGetDevCapsW: illegal call to waveOutGetDevCapsA but before it can be merged we have to rewrite the Wine drivers to accept Unicode. I am planing on adding this as a subproject to the Janitorial page. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel