- wine-devel - winehq.org

Debugging of Windows App
by Bernard Gallet 30 Nov '04

30 Nov '04

I am trying to debug a Windows app on Wine. I have the source code, it is compiled with Visual Studio 2002. I have not yet been able to get Line/File info. It is my understanding that winedbg does not recognize pdb, however, I am unable to link without one! Can somebody help? T IA, - Bernard GALLET -

2 1

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage
by Mike McCormack 30 Nov '04

30 Nov '04

The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log. err:imagelist:ImageList_LoadImageW Error loading image! Mike Alexandre Julliard wrote: > ChangeSet ID: 14326 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/10/26 16:17:50 > > Modified files: > dlls/shell32/tests: shellpath.c > dlls/shell32 : version.h > > Log message: > Juan Lang <juan_lang(a)yahoo.com> > Update shell32's version to WinXP level. > > Patch: http://cvs.winehq.org/patch.py?id=14326 > > Old revision New revision Changes Path > 1.3 1.4 +0 -2 wine/dlls/shell32/tests/shellpath.c > 1.1 1.2 +4 -4 wine/dlls/shell32/version.h

6 6

Re: acmstream mem leak fix
by MichaelGuennewig＠gmx.de 30 Nov '04

30 Nov '04

James Hawkins <truiken(a)gmail.com> writes: > Unless I'm mistaken, we don't want to free allocated memory only when > the call fails. Sorry, but you are wrong. When you always free the memory you will run into a segmentation fault when the application uses the returned stream. The problem is the same as with the icmstream patch you made. The current implementation will work correctly in all cases although it doesn't look very COM-like as Mike already pointed out for the icmstream patch. The methods you analyzed are only called internally from IClassFactory_fnCreateInstance in the factory.c file. The memory block which is allocated by LocalAlloc in the AVIFILE_CreateICMStream and AVIFILE_CreateACMStream is only returned to the application if the IAVIStream_QueryInterface call doesn't return an error. So when you always free the memory block you will most probably run into a segmentation fault. The proposed patch from Mike for the icmstream.c file should be adapted to this file when you don't like the LocalFree call there, but I'm sure that then people will ask why we don't call LocalFree in this method. So it would be perhaps fine when also some comments would be added to prevent another discussion about what's wrong or correct. When you don't understand the code feel free to write me as I'm the one who has produced it. Regards Michael Günnewig

1 0

<<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive
by Robert van Herk 30 Nov '04

30 Nov '04

Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed just for picking a Windows folder, was split up. It was to be found in brsfolder.c, but I split this in: brsfolder.c brsfolder.h brsfolder_windows.c brsfolder_windows.h brsfolder_unix.c brsfolder_unix.h unixTools.c unixTools.h, Otherwise I found the code to be incomprehendible. Furthermore, winecfg now uses the wine_shell_browse_for_UNIX_directoryA to let the user pick a UNIX directory as root for his virtual drive mappings. Regards, Robert van Herk

1 0

Re: misc. crypt test mem leak fixes
by Dmitry Timoshkov 30 Nov '04

30 Nov '04

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * misc. crypt test mem leak fixes Apparently lines with LocalAlloc were added by mistake instead of LocalFree. -- Dmitry.

2 1

Problem with file dialog
by Stefan Dösinger 30 Nov '04

30 Nov '04

Hello, This patch breakes the file open/save dialog for me: http://www.winehq.org/hypermail/wine-cvs/2004/11/0086.html The 5 buttons(go up one folder, go to desktop, new folder, ...) appear above the directory selektor and have a height of only a few pixels, so the icons are not visible and it's hard to click the buttons(see the attached screenshot). Reversing lines 89-96 of the patch solves the problem. I don't send a patch, because I don't think simply reversing the lines is the correct solution. What is a correct fix for this? Cheers, Stefan

2 2

Porting SmartWin a Windows API GUI library...
by Thomas Hansen 30 Nov '04

30 Nov '04

I'm the admin of http://smartwin.sourceforge.net and I've been thinking that if this library (SmartWin) could be ported to WineLib that would be really awesome... I would definitely take it right into the CVS (unless it breaks everything) and I'd make it a definitely focus trying to keep the compatibility towards WineLib in later releases... I assume it would be a nice project to do too. (not too much code, only about 15 000 lines with LOTS of comments) Not to mention the benefit it would give the community having a Windows API library being ported to Wine... Comments sombody...? Thomas Hansen -- http://smartwin.sourceforge.net THE template based C++ Windows API GUI Abstraction Library

2 1

Re: icmstream mem leak fix
by Mike McCormack 30 Nov '04

30 Nov '04

Hi James, That looks kind of wrong, both the before and after... Interfaces should be released, not free'd... Secondly, freeing the interface if the Query works is almost definitely wrong, because ppv will likely point to the same memory as pstream. Mike James Hawkins wrote: > hr = IAVIStream_QueryInterface((IAVIStream*)pstream, riid, ppv); > - if (FAILED(hr)) > - LocalFree((HLOCAL)pstream); > + > + LocalFree((HLOCAL)pstream); > > return hr; > }

2 4

Re: Systray rewrite
by Grant Williamson 30 Nov '04

30 Nov '04

Hi Mike, patching is clean on 20041019, however .. fails with make[2]: Entering directory `/tmp/wine-20041019/dlls/shell32' ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./shell32.spec shell.spec.o shell.o authors.o autocomplete.o brsfolder.o changenotify.o classes.o clipboard.o control.o cpanelfolder.o dataobject.o debughlp.o dialogs.o dragdrophelper.o enumidlist.o folders.o iconcache.o memorystream.o pidl.o regsvr.o shell32_main.o shelllink.o shellole.o shellord.o shellpath.o shellreg.o shellstring.o shfldr_desktop.o shfldr_fs.o shfldr_mycomp.o shlexec.o shlfileop.o shlfolder.o shlfsbind.o shlmenu.o shlview.o shpolicy.o shv_bg_cmenu.o shv_item_cmenu.o systray.o shell32.dll.dbg.o shres.res version.res -o shell32.dll.so -L../../dlls -Wb,-dole32 -lshlwapi -lcomctl32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -L../../libs/wine -lwine -luuid -L../../libs/unicode -lwine_unicode -L../../libs/port -lwine_port shell32_main.o(.text+0x23c6): In function `DllMain': /usr/src/redhat/BUILD/wine-20041019/dlls/shell32/shell32_main.c:962: undefined reference to `SYSTRAY_Init' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [shell32.dll.so] Error 2 make[2]: Leaving directory `/tmp/wine-20041019/dlls/shell32' make[1]: *** [shell32] Error 2 make[1]: Leaving directory `/tmp/wine-20041019/dlls' make: *** [dlls] Error 2 Mike Hearn wrote: >Here it is, at last, just what the doctor ordered. All in a separate >wineshell process, and with cleaner code to boot. No thread safety >needed. Hopefully this is now satisfactory and can go in. > >The intention is that wineshell becomes a generic explorer-alike process >in terms of responsibility. For now, I have it being started >automatically by shell32 (to avoid the startup penalty), and shutting >down a few seconds after the last icon is gone like the wineserver. If >we start putting more stuff in there like a DDE server, we may have to >rethink that strategy. > >ChangeLog: >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > > >

1 0

Re: working together on stdole.tlb and a end to dcom9x
by Sam Lauber 30 Nov '04

30 Nov '04

Sure, send me both. The precompiled one would be useful to test OLE, and the source would be useful to test OLE, Winelib, and the Wine DLLs. Also, a few months ago, I did a web search for the OLE problem, and turned up an old thread on the Wine mailing list that actually had stdole32.odl. The URL is http://www.winehq.org/hypermail/wine-devel/2003/01/0858.html. I tried it with MS mktyplib (with Wine DLLs). Strangly, it produced the exact same FIXMEs that the C program generated, but generated a diffrent typelib. And more then two bytes differed. The two typelibs are attached. I'll try it with InstallShield. Samuel Lauber ----- Original Message ----- From: "Boaz Harrosh" <boaz(a)moeg.org> To: "Sam Lauber" <sam124(a)operamail.com> Subject: Re: working together on stdole.tlb and a end to dcom9x Date: Mon, 29 Nov 2004 10:18:43 +0200 > > Sam Lauber wrote: > > > Someone should develop a Wine testcase that tests typelibs. Does anyone know of a typelib testcase? > > > > > > > Last I checked wine with native ole would crash on any simple WTL > project hosting an OCX. It would crash at the point it was trying to > query for the typelibs and interface info inside the typelib. So first > thing I'd do is Just compile a simple WTL app hosting any OCX. > > Do you need that I send you one? Compiled on VC6 on windows? What OCX > can one use that would work with native ole? > Is source OK? or you also need a compiled exe with debug info (.pdb)? > > Free Life > Boaz > -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. From your mailbox to local or overseas cell phones. Powered by Outblaze

2 1

Changed IE6 install script to run IE6 completely out-of-box
by Hajime Segawa 30 Nov '04

30 Nov '04

As mentioned in WWN #250 : >If you dissect the script you'll notice a lot of what it does is install some proprietary DLL's. Specifically, DCOM98, MFC 4.0, >and Microsoft Installer. So yes, it's cheating and Wine isn't running these completely out of the box. However, you can run them. I changed the install script a bit and it does not depend on DCOM98, MFC4.0, etc... anymore. So, you can run IE6 completely out-of-box. New script is here : http://sidenet.ddo.jp/winetips/files/wine-config-sidenet-1.5.3.tgz

3 6

Re: Moved dll list from DEVELOPERS-HINTS into separated file
by Jon Griffiths 29 Nov '04

29 Nov '04

Hi, >I personally don't think it's really useful without more detailed >information on each dll, but in any case this belongs to one of the >sgml documents, not a stand-alone ASCII file. c2man.pl will generate a blurb for each dll in the source tree when building API docs, if one of the dlls source files contain a supplimental comment named after the dll. IMHO this is the best place to put a description of the dll. It appears in the generated docs above the list of exported functions and makes a natural lead-in to the dlls documentation page. The info is then also available by "man dllname" if the generated docs are installed. See the top comment in dlls/shlwapi/shlwapi_main.c for an example. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? All your favorites on one personal page � Try My Yahoo! http://my.yahoo.com

1 0

Re: Translate dir names into Spanish
by Juan Lang 29 Nov '04

29 Nov '04

Joaqu�n wrote: > I have some programs in spanish for windows but when i install it i have > problems with dir names, for example "Program Files" is "Archivos de > programa", "Common Files" is "Archivos comunes", and so. > > Can i translate this names in source and compiling without problem?? > which files i need update?? Yes, you can. You need to modify the file dlls/shell32/shell32_Es.rc. Look at dlls/shell32/shell32_En.rc. The end of the file as a stringtable with the comment /* shell folder path default values */. Copy this stringtable to shell32_Es.rc, and translate the names appropriately. Recompile and reinstall. Please send a patch with the updated translations to wine-patches(a)winehq.org, too. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

1 0

Re: working together on stdole.tlb and a end to dcom9x
by Sam Lauber 29 Nov '04

29 Nov '04

No. I used the InstallShield program for Flash MX, and it didn't work. Without stdole32.tlb, it whined like a baby about OLE. With stdole32.tlb, it (not the whole system) froze up during the "preparing" stage when it hit 100% and left a phantom window that was blank when and after I quit Wine. I think, for InstallShield, someone has to implement a special trap(s) for OLE calls. Also, a stdole32.tlb copied from a real Windows system didn't work. Clearly, it isn't a hole in InstallShield, but in Wine's typelib support. Someone should develop a Wine testcase that tests typelibs. Does anyone know of a typelib testcase? Samuel Lauber ----- Original Message ----- From: "Steven Edwards" <steven_ed4153(a)yahoo.com> To: "Vincent "Béron"" <vberon(a)mecano.gme.usherb.ca>, "Filip Navara" <xnavara(a)volny.cz> Subject: Re: working together on stdole.tlb and a end to dcom9x Date: Sun, 28 Nov 2004 17:54:48 -0800 (PST) > > Hi Vincent, > > --- Vincent Béron <vberon(a)mecano.gme.usherb.ca> wrote: > > Was the resulting stdole32.tlb file (generated on Wine) a suitable > > replacement for Microsoft's? IE, does InstallShield works better with > > this file than without any stdole32.tlb file? > > I think it will work. One thing we have discussed in ReactOS was using > the tools as part of our stage2 setup. If there is not a easy way to > implement these tools in WIDL like Alexandre wanted maybe making them > tools that are run via wineprefixcreate on first run is a acceptable > solution? > > Thanks > Steven > > > > > __________________________________ > Do you Yahoo!? > Read only the mail you want - Yahoo! Mail SpamGuard. > http://promotions.yahoo.com/new_mail > > -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

2 1

working together on stdole.tlb and a end to dcom9x
by Steven Edwards 29 Nov '04

29 Nov '04

Hello, Once again cross-posting because I would like to see if this is something we can work together on. What is left to do for us to be able to build and have a working implementation of stdole.tlb or any other type libs? I ask because it seems Wines DCOM implementaton is almost good enough for most apps except for this file and ReactOS is quickly getting to the point that it can run most of the same stuff Wine can without DCOM9x installed. Thanks Steven _______________________________ Do you Yahoo!? Win 1 of 4,000 free domain names from Yahoo! Enter now. http://promotions.yahoo.com/goldrush

7 14

Re: Winecfg -> browse for folder
by Ivan Leo Puoti 28 Nov '04

28 Nov '04

> Also runned ldconfig (don't know if that is > a must). It isn't, expecially if you run out of the source tree. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Fun desktop integration tasks
by Ivan Leo Puoti 28 Nov '04

28 Nov '04

Another task: Get xscreensaver to respect the registry LowPowerActive setting. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

listbox: selecting items
by Lauri Tulmin 28 Nov '04

28 Nov '04

I would like to know why http://www.winehq.com/hypermail/wine-patches/2004/11/0171.html hasn't been accepted.

1 0

No RichEdit20A window class
by Krzysztof Foltman 28 Nov '04

28 Nov '04

Just for the record, I'm still trying to develop a "proper" RichEdit control. I've written from scratch with RichEdit compatibility in mind, so I don't expect any copyright or suitability problems. At least, unless I screw something up or I'm less smart than I think. If someone isn't afraid of running closed-source .exe from barely known developer (or can run it in a controlled environment), you can find the latest binary at: http://foltman.com/riched.zip I'm not releasing the source yet, because I don't think it's hackable, until at least its architecture is complete. What's more, I'm planning to license a heavily modified derived product comercially to some company (a rich text viewer/editor tailored for a specific application), so any copyright-related problems are undesirable. What IS done: - basic text wrapping with support for proportional fonts and character formatting, no major known bugs (the only supported attribute is Bold, but the rest will be relatively easy to add) - simple editing (typing text, backspace, delete, no overwrite mode yet) - a very incomplete implementation of Shift-arrow selection (done in a few hours yesterday :-) ), mouse operations don't support selection yet - per-paragraph alignment - pitiful low-level style management - bold attribute - some basic optimizations (avoiding rewrapping unmodified paragraphs unless editor window is resized) - uses UNICODE internally (not necessarily a good thing) What isn't done: - RichEdit API (which is a mess; I'm taking care of it in order to ensure compatibility wrt how editing functions work, however, basic editing functionality is the number one priority, as it's more difficult to achieve) - RTF interface - Undo - Clipboard - tabs - bulleted lists - setting paragraph attributes (margins are implemented internally but can't be changed with current interface, setting alignment by Ctrl+L/E/R works) - all RichEdit f3 functionality - MBCS support (and it would be very hard to add) - BiDi and CTL support (ditto) - everything not mentioned in the first list Krzysztof

4 5

Fun desktop integration tasks
by Mike Hearn 28 Nov '04

28 Nov '04

Hi everybody, I'm sitting waiting for a couple of compiles to finish, so I thought I'd put together a list of fun/interesting tasks people might like to have a go at related to better integrating Wine with the native desktop. None of these should be especially hard, and so would provide a good intro to Wine development for anybody who has been lurking on the sidelines and wants to get involved. As usual no guarantees these patches would be accepted, that's Alexandres call. But they probably would be, and you'll learn something while doing them! :) Task 1: Map CSIDL_PERSONAL (My Documents) to the $HOME directory if mapped. See the _SHGetDefaultValue function in dlls/shell32/shellpath.c for an explanation of how to do this. I think it'd be ok to grab $HOME using the UNIX getenv() and then using the libwine APIs to map them to a Win32 path. If the mapping fails (ie $HOME is not accessible given the users dosdevices) then just fail with a WARN(). Task 2: This is similar to above but with some extra work. Map the contents of the ~/Desktop directory to the Windows virtual Desktop folder. In file pickers and Explorer, the filesystem root is represented by a magic Desktop folder. In real Windows this reflects the icons that are on the desktop and is mapped to a real directory at some arbitrary point in the filing system. On Linux we have no such virtual root, however it'd be nice if icons that appeared in the KDE/GNOME desktop were put in their proper place. That way users won't be confused by the file being on their desktop but unavailable from their Windows applications file picker. This should not be too hard. The Desktop folder is implemented by a COM object in dlls/shell32/shfldr_desktop.c. You just need to read the $HOME/Desktop folder and put the items you find in there inside. Ignore .desktop files for now, they are a bit tricker to map and aren't especially useful for us anyway. You also want to map CSIDL_DESKTOP in dlls/shell32/shellpath.c, _SHGetDefaultValue. See above. Bonus points for fixing the desktop icon while you're at it (an arrow??!) Task 3: The freedesktop.org icon theme specification shows us how to find icons for many different types of thing. Implement support for loading and using the following icons from the icon theme (it should be OK to use native libraries for this like GdkPixbuf, just fall back to the compiled in defaults if it's missing): - folder - desktop - computer - unknown document - any others?? Don't do file types, as native icon<->file type association is done by mime types not extensions, and it'd make our file dialogs even slower than they already are. You may be tempted to use eg, libpng to implement this. Don't! Use GdkPixbuf instead, stock icons are allowed to be in many formats including SVG. Task 4: Try updating the menu mapping code to support the new XDG menu specification. Don't bother trying to make this work everywhere, it's a total nightmare. Just try supporting the new standards. Be warned: not every desktop/distro supports this yet! This one might be quite hard. Task 5: Try improving the winebrowser script to take into account the users preferred applications. At the moment it just tries every browser it knows about in a hard coded order. Hint: in modern GNOME desktops you can use the "gnome-open" program to make this automatic. There is a KDE equivalent. Task 6: Integrate Wine with XScreensaver, so installing Win32 screensavers makes them automatically appear in the list. You may need to write patches for xscreensaver to make this really slick. Have fun! thanks -mike

6 8

Re: Moved dll list from DEVELOPERS-HINTS into separated file
by Dimitrie O. Paun 28 Nov '04

28 Nov '04

On Fri, Nov 26, 2004 at 10:04:49PM -0500, Jacek Caban wrote: > I saw in TODO list "Get rid of the list of DLLs, it's too big, and adds > too little information", > so I thought it could be moved into separated file dlls/DLL-LIST. I think this is a good idea: while I agree that the list is a bit much for DEVELOPERS-HINTS, it's still a nice overview of the dlls we have, and it would be a real pitty to lose. -- Dimi.

2 1

Adding debuginfo Support to Wine Makefiles
by Robert Shearman 28 Nov '04

28 Nov '04

Hi, I want to add support generating .debug files that are linked from .so files so that we can have one set of binaries, no matter whether a person is a developer or end-user and yet have no additional disk space or bandwidth costs. This is really just a RFC about changes I've made to the DLL makefiles, before I start copying and pasting them to the other areas. Am I on the right lines here? Do I need to add a configure check for objcopy? Do I need a configure check for the --add-gnu-debuglink option? Rob

3 5

Re: Resend: Re-implement MSVCRT *printf functions
by Aneurin Price 28 Nov '04

28 Nov '04

Any further comments on this?

4 6

Translate dir names into Spanish
by Joaquín Fernández 28 Nov '04

28 Nov '04

Hi I have some programs in spanish for windows but when i install it i have problems with dir names, for example "Program Files" is "Archivos de programa", "Common Files" is "Archivos comunes", and so. Can i translate this names in source and compiling without problem?? which files i need update?? Can i translate Wine into spanish?? How? Regards Joaquín -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

1 0

Re: Unicodified fontdlg (next try)
by Robert Shearman 26 Nov '04

26 Nov '04

Jacek Caban wrote: > Changelog: > Unicodified fontdlg > >------------------------------------------------------------------------ > >@@ -216,52 +213,60 @@ > */ > BOOL WINAPI ChooseFontA(LPCHOOSEFONTA lpChFont) > { >- LPCVOID template; >- HRSRC hResInfo; >- HINSTANCE hDlginst; >- HGLOBAL hDlgTmpl; >- >- if ( (lpChFont->Flags&CF_ENABLETEMPLATEHANDLE)!=0 ) >- { >- template=(LPCVOID)lpChFont->hInstance; >- } else >- { >- if ( (lpChFont->Flags&CF_ENABLETEMPLATE)!=0 ) >- { >- hDlginst=lpChFont->hInstance; >- if( !(hResInfo = FindResourceA(hDlginst, lpChFont->lpTemplateName, >- (LPSTR)RT_DIALOG))) >- { >- COMDLG32_SetCommDlgExtendedError(CDERR_FINDRESFAILURE); >- return FALSE; >- } >- } else >- { >- hDlginst=COMDLG32_hInstance; >- if (!(hResInfo = FindResourceA(hDlginst, "CHOOSE_FONT", (LPSTR)RT_DIALOG))) >- { >- COMDLG32_SetCommDlgExtendedError(CDERR_FINDRESFAILURE); >- return FALSE; >- } >- } >- if (!(hDlgTmpl = LoadResource(hDlginst, hResInfo )) || >- !(template = LockResource( hDlgTmpl ))) >- { >- COMDLG32_SetCommDlgExtendedError(CDERR_LOADRESFAILURE); >- return FALSE; >- } >+ CHOOSEFONTW chFontw; >+ LOGFONTW logFontw; >+ LPLOGFONTA lpLogFonta; >+ int len; >+ BOOL ret; >+ LPSTR lpszStyle; >+ LPCSTR lpTemplateName; >+ >+ memcpy(&chFontw, lpChFont, sizeof(CHOOSEFONTW)); >+ memcpy(&logFontw, lpChFont->lpLogFont, sizeof(LOGFONTA)); >+ chFontw.lpLogFont = &logFontw; >+ >+ MultiByteToWideChar(CP_ACP, 0, lpChFont->lpLogFont->lfFaceName, >+ LF_FACESIZE, chFontw.lpLogFont->lfFaceName, LF_FACESIZE); >+ >+ if(lpChFont->lpszStyle) { >+ len = MultiByteToWideChar(CP_ACP, 0, lpChFont->lpszStyle, -1, NULL, 0); >+ chFontw.lpszStyle = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len*sizeof(WCHAR)); > > Initialising the whole string to zero just before it is about to be overwritten seems needlessly wasteful on CPU cycles and memory bandwidth. You seem to do this in a few places. Yes, MultiByteToWideChar can, in some cases, leave the string without a null terminator, but that only happens when there is insufficient buffer. In this case, the only way that can happen is if another thread modifies the buffer between the previous MultiByteToWideChar and the next one here. If you wanted to be really careful, you could always add "chFontw.lpszStyle[len-1] = '\0';" after to call to MultiByteToWideChar. >+ MultiByteToWideChar(CP_ACP, 0, lpChFont->lpszStyle, -1, chFontw.lpszStyle, len); >+ HeapFree(GetProcessHeap(), 0, lpChFont->lpszStyle); > > You seem to be freeing a buffer that the user passed in. How do you know it was allocated with HeapAlloc? >+ } >+ >+ if(lpChFont->lpTemplateName) { >+ len = MultiByteToWideChar(CP_ACP, 0, lpChFont->lpTemplateName, -1, NULL, 0); >+ chFontw.lpTemplateName = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len*sizeof(WCHAR)); >+ MultiByteToWideChar(CP_ACP, 0, lpChFont->lpTemplateName, >+ -1, (LPWSTR)chFontw.lpTemplateName, len); >+ } >+ >+ ret = ChooseFontW(&chFontw); >+ >+ lpLogFonta = lpChFont->lpLogFont; >+ lpszStyle = lpChFont->lpszStyle; >+ lpTemplateName = lpChFont->lpTemplateName; >+ memcpy(lpChFont, &chFontw, sizeof(CHOOSEFONTA)); >+ lpChFont->lpLogFont = lpLogFonta; >+ lpChFont->lpszStyle = lpszStyle; >+ lpChFont->lpTemplateName = lpTemplateName; >+ memcpy(lpChFont->lpLogFont, &logFontw, sizeof(LOGFONTA)); >+ WideCharToMultiByte(CP_ACP, 0, logFontw.lfFaceName, >+ LF_FACESIZE, lpChFont->lpLogFont->lfFaceName, LF_FACESIZE, 0, 0); >+ >+ if(chFontw.lpszStyle) { >+ len = WideCharToMultiByte(CP_ACP, 0, chFontw.lpszStyle, -1, NULL, -1, 0, 0);; >+ WideCharToMultiByte(CP_ACP, 0, chFontw.lpszStyle, -1, lpChFont->lpszStyle, len, 0, 0); >+ HeapFree(GetProcessHeap(), 0, chFontw.lpszStyle); > } >- if (TRACE_ON(commdlg)) >- _dump_cf_flags(lpChFont->Flags); > >- if (lpChFont->Flags & (CF_SELECTSCRIPT | CF_NOVERTFONTS )) >- FIXME(": unimplemented flag (ignored)\n"); >+ if(chFontw.lpTemplateName) >+ HeapFree(GetProcessHeap(), 0, (LPBYTE)chFontw.lpTemplateName); > > You shouldn't need a cast here, unless lpTemplateName is a const. > >- return DialogBoxIndirectParamA(COMDLG32_hInstance, template, >- lpChFont->hwndOwner, FormatCharDlgProcA, (LPARAM)lpChFont ); >+ return ret; > } > >- > #define TEXT_EXTRAS 4 > #define TEXT_COLORS 16 > > > ... >@@ -1072,34 +1083,34 @@ > } > > /*********************************************************************** >- * FormatCharDlgProcA [internal] >+ * FormatCharDlgProc [internal] > */ >-INT_PTR CALLBACK FormatCharDlgProcA(HWND hDlg, UINT uMsg, WPARAM wParam, >+INT_PTR CALLBACK FormatCharDlgProc(HWND hDlg, UINT uMsg, WPARAM wParam, > LPARAM lParam) > { >- LPCHOOSEFONTA lpcf; >+ LPCHOOSEFONTW lpcf; > INT_PTR res = FALSE; > > if (uMsg!=WM_INITDIALOG) > { >- lpcf=(LPCHOOSEFONTA)GetPropA(hDlg, WINE_FONTDATA); >- if (!lpcf && uMsg != WM_MEASUREITEM) >+ lpcf=(LPCHOOSEFONTW)GetPropW(hDlg, strWineFontData); >+ if (!lpcf) > return FALSE; > if (CFn_HookCallChk32(lpcf)) >- res=CallWindowProcA((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); >+ res=CallWindowProcW((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); > > This isn't something wrong with your patch, but is in the original code too. We shouldn't need to cast here, because if lpfnHook isn't using the right calling conventions or doesn't have the same number of parameters then we shouldn't be using CallWindowProc to start with. > if (res) > return res; > } > else > { >- lpcf=(LPCHOOSEFONTA)lParam; >+ lpcf=(LPCHOOSEFONTW)lParam; > if (!CFn_WMInitDialog(hDlg, wParam, lParam, lpcf)) > { > TRACE("CFn_WMInitDialog returned FALSE\n"); > return FALSE; > } > if (CFn_HookCallChk32(lpcf)) >- return CallWindowProcA((WNDPROC)lpcf->lpfnHook,hDlg,WM_INITDIALOG,wParam,lParam); >+ return CallWindowProcW((WNDPROC)lpcf->lpfnHook,hDlg,WM_INITDIALOG,wParam,lParam); > } > switch (uMsg) > { > > Rob

1 0

Re: profiling GTA4. question about polling
by Brian Gunlogson 26 Nov '04

26 Nov '04

The patch you gave me is too incomplete to run GTA :( I can start a game, but once the loading screen says it is done, the game crashes. Looked at the console, it says, "fixme:drawStridedFast TODO". The crash happens at the end of drawStridedFast(), inside glDrawElements(). Your patch will really speed things up when it is finished. In a fresh CVS tree, I disabled drawStridedSlow and applied 2 polling patches submitted to wine-patches. The game works almost as fast as in Windows!! Brian G. --- Raphael <fenix(a)club-internet.fr> wrote: > Here is it. > > But i have some problems with hardware vertex buffers (using vbo extension) > i have some 'transparent" objects (ie graphics bugs) > Anyway, If you encounter same problems you can uncomment this line: > //useSoft |= (0 != (Usage & D3DUSAGE_WRITEONLY)); > (dls/d3d8/vertexbuffer.c at line 71) __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

2 2

Internet Explorer 6 Installer script
by Hajime Segawa 26 Nov '04

26 Nov '04

I wrote a tiny shell script that can install IE6sp1 and WMP7. I hope this script can help you. RealPlayer 10, MSN Messenger 6.4, Yahoo!Japan Messenger seem to work with this configuration. http://sidenet.ddo.jp/winetips/config.html I took some screenshots. http://sidenet.ddo.jp/winetips/files/

2 2

dlls/mscms/profile.c breakage
by Gerald Pfeifer 25 Nov '04

25 Nov '04

The following change to dlls/mscms/profile.c revision 1.6 date: 2004/11/21 15:48:18; author: julliard; state: Exp; lines: +135 -3 Implement and test GetColorProfileElementTag, GetCountColorProfileElements and IsColorProfileTagPresent. Stub GetStandardColorSpaceProfile{A,W}. breaks FreeBSD 4.10 (with XFree86-4.3.0) as follows: gmake[2]: Entering directory `/.amd_mnt/nashira/files5/test/wine/dlls/mscms' /sw/gcc-3.3.4/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o profile.o profile.c profile.c: In function `GetColorProfileElementTag': profile.c:142: error: `LCMSICCPROFILE' undeclared (first use in this function) profile.c:142: error: (Each undeclared identifier is reported only once profile.c:142: error: for each function it appears in.) profile.c:142: error: `cmsprofile' undeclared (first use in this function) profile.c:142: error: parse error before ')' token profile.c: In function `GetCountColorProfileElements': profile.c:174: error: `LCMSICCPROFILE' undeclared (first use in this function) profile.c:174: error: `cmsprofile' undeclared (first use in this function) profile.c:174: error: parse error before ')' token gmake[2]: *** [profile.o] Error 1 gmake[2]: Leaving directory `/.amd_mnt/nashira/files5/test/wine/dlls/mscms' Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

4 13

Major Winelib Problems
by Sam Lauber 25 Nov '04

25 Nov '04

I followed the tutorial for Winelib on my Linux system, building notepad. I examined the file "./notepad2" with readelf, and it said "Not an ELF file", and I do not have an a.out system. I opened it with my text editor (attached is the text I saw) and I was disappointed. Instead of a real "port", it was just a shell script that launches wine on a Windows program encapsulated in a ELF shared object file. I'm not happy. Samuel Lauber -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. From your mailbox to local or overseas cell phones. Powered by Outblaze

5 5

Wineconf committee
by Jeremy White 25 Nov '04

25 Nov '04

Hey folks, Brian, Alexandre, and I have been talking with some kind folks that are volunteering to help host Wineconf in Stuttgart; we're thinking late spring for Stuttgart. We've also had a generous offer to help set up a meeting in conjunction with LinuxTag in Karlruhe in mid to late June. This is all great, but I realized suddenly that the three of us were starting to consider things and make decisions on behalf of the broader Wine community. While I enjoy exercising dictatorial impunity, I prefer to have a cover group to make my imperiousness less obvious <grin>. Seriously, I'd like to ask for volunteers to serve on a Wineconf planning committee. I think the requirements for the position are as follows: 1. Able and willing to attend the next Wineconf in Germany 2. Able and willing to engage in and follow the planning and decision making process 3. Have a credible background in the Wine community (or live in the right part of Germany <grin>). 4. Be willing to help in ways that may be required, such as showing up a day early to help prepare, or bringing A/V equipment, or whatever way makes sense. (This isn't a requirement, but I really would like folks that are at least willing to contribute a little extra, if they are able.) To volunteer, please email me privately, and I'll build a chain of emails. If we don't get any volunteers, then Brian, Alexandre, and I will consider ourselves empowered, and will dictate that Marcus does all the work <grin>. Cheers, Jeremy

2 2

Re: SetForegroundWindow() from WM_ACTIVATE broken
by Jon Griffiths 25 Nov '04

25 Nov '04

Hi, More on this problem ... here what happens under native when the back window is clicked: Order of trace below is (msg, hwnd, wparam,lparam) The app is started, click on the client area of the background window WM_MOUSEACTIVATE back 001203aa 02010001 (MA_ACTIVATE) Front window is told its going inactive WM_NCACTIVATE front 00000000 back WM_ACTIVATE front WA_INACTIVE back SetWindowPos() is called to raise back window to the front of the zorder, nc client and background told to paint WM_WINDOWPOSCHANGING back 00000000 0012fea8 WM_NCPAINT back 00000001 00000000 WM_ERASEBKGND back 0101005a 00000000 WM_WINDOWPOSCHANGED back 00000000 0012fea8 Back window is told its going active WM_NCACTIVATE back 00000001 front WM_ACTIVATE back WA_CLICKACTIVE front Now the back window calls SetForegroundWindow(front), within its WM_ACTIVATE handler Back window is told its going inactive WM_NCACTIVATE back 00000000 front WM_ACTIVATE back 00000000 front Front window brought to the top of the z-order w/SetWindowPos WM_WINDOWPOSCHANGING front 00000000 0012fd0c WM_NCPAINT front 00000001 00000000 WM_ERASEBKGND front 0101005a 00000000 WM_WINDOWPOSCHANGED front 00000000 0012fd0c Front window is told its going active WM_NCACTIVATE front 00000001 back WM_ACTIVATE front 00000001 back Under wine the message stream doesn't have the SetWindowPos calls, and there are several hundred activate/ncactivate messages, ending with the back window in the front of the z-order, activated with the focus. Looking at the logic in dlls/user/focus.c, in set_active_window(), it seems that SetWindowPos() was not being called because the windows both have the WS_EX_MANAGED style set. Commenting out the line if (!(GetWindowLongW( hwnd, GWL_EXSTYLE ) & WS_EX_MANAGED)) Caused the front window to remain on top after clicking on the back window, as desired. However it did then not get the focus as it should, and titlebar clicks and double clicks in the client area still allow the back window to rise to the top of the z-order. I added a test to check if the window is the foreground window (i.e. that some other window hasn't been set in the interim) before setting the focus. This means my test app now appears to work just like native. The attached patch makes both of these changes. I'd be interested in any comments regarding whether the above is correct. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

1 0

Breakage on Debian Sarge
by Michael Jung 25 Nov '04

25 Nov '04

Hi, this patch (http://cvs.winehq.org/patch.py?id=14575) broke wine on a current Debian Sarge. Tested this on two machines. GUI applications do not respond any longer to mouse events. Tested regedit and winemine. Removing the patch solves the problem. Bye, Michael

3 2

Re: Adding debuginfo Support to Wine Makefiles
by Ivan Leo Puoti 25 Nov '04

25 Nov '04

> It is already there. I added support for it a few months ago. I've did debug packages for mdk the day after AJ commited your patch, but is there any easy way I can test to see if the debug info works with winedbg? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Winecfg -> browse for folder
by Rolf Kalbermatter 24 Nov '04

24 Nov '04

Robert van Herk <robert(a)robertvanherk.nl> wrote: >Also, I am having some troubles into tricking the SHBrowseForFolder >thingy into using a different root folder, since I guess I need to use >SHParseDisplayName >(http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…) >for that, but that doesn't seem to be implemented in Wine. This shouldn't be to difficult I guess. There are helper functions in shell32.pidl.c which should be close to what this function does actually. Something like this in pidl.c should do the trick: HRESULT WINAPI SHParseDisplayNameW(LPCWSTR pszName, IBindCtx *pbc, LPITEMIDLIST *ppidl, SFGAOF sfgaoIn, SFGAOF *psfgaoOut) { LPSHELLFOLDER sf; HRESULT ret = E_FAIL; TRACE("%s %p 0x%08lx\n", debugstr_w(pszName), ppidl, attributes ? *attributes : 0); if (SUCCEEDED (SHGetDesktopFolder(&sf))) { ret = IShellFolder_ParseDisplayName(sf, 0, pbc, (LPOLESTR)pszName, NULL, ppidl, &sfgaoIn); if (succeeded && psfgaoOut) *psfgaoOut = sfgaoIn; IShellFolder_Release(sf); } return ret; } Or you could probably use SHILCreateFromPathW() too for your purposes, which is similar. >Finally, I don't know how to free PIDLS. In the MSDN documentation they >use C++ calls for that, but I don't know how to port that to C. ILFree() exported as ordinal 155 from shell32 should be the function to use. It was undocumented in Windows for a long time but exists in shell32 since at least Win95. Rolf Kalbermatter

1 0

dinput - fix detection under Windows
by Steven Edwards 24 Nov '04

24 Nov '04

I am sending this to wine-devel as I would like a DirectInput hacker to comment on it. With this patch we are able to run some of the DirectX sample application using Wine dinput.dll on Windows. Changelog: Magnus Olsen <magnus(a)itkonsult-olsen.com> Add more polling of keyboard and mouse devices under DirectInput as Windows depends on this behavior. __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail

1 0

Stubs in PE build
by Ge van Geldorp 24 Nov '04

24 Nov '04

Stubs declared in .spec files were not generated or exported for PE (MinGW) builds. The patch below fixes that. It adds a new mode to winebuild, --pedll, which generates the stubs. Since it's a global change I'm sending it here for review first. Ge van Geldorp. Index: Make.rules.in =================================================================== RCS file: /home/wine/wine/Make.rules.in,v retrieving revision 1.179 diff -u -r1.179 Make.rules.in --- Make.rules.in 7 Oct 2004 03:12:44 -0000 1.179 +++ Make.rules.in 24 Nov 2004 20:49:51 -0000 @@ -104,7 +104,7 @@ api_manext = 3w conf_manext = 5 CLEAN_FILES = *.o *.a *.so *.ln *.$(LIBEXT) \\\#*\\\# *~ *% .\\\#* *.bak *.orig *.rej \ - *.flc *.spec.c *.spec.def *.dbg.c *.tab.c *.tab.h @LEX_OUTPUT_ROOT@.c core + *.flc *.spec.c *.spec.def *.dbg.c *.pedll.c *.tab.c *.tab.h @LEX_OUTPUT_ROOT@.c core OBJS = $(C_SRCS:.c=.o) $(EXTRA_OBJS) @@ -113,7 +113,7 @@ # Implicit rules -.SUFFIXES: .mc .rc .mc.rc .res .res.o .spec .spec.c .spec.def .idl .h .ok .sfd .ttf +.SUFFIXES: .mc .rc .mc.rc .res .res.o .spec .spec.c .spec.def .pedll.c .idl .h .ok .sfd .ttf .c.o: $(CC) -c $(ALLCFLAGS) -o $@ $< @@ -135,6 +135,9 @@ .spec.spec.def: $(WINEBUILD) -w $(DEFS) -o $@ --def $< + +.spec.pedll.c: + $(WINEBUILD) $(DEFS) -o $@ --pedll $< .idl.h: $(WIDL) $(IDLFLAGS) -h -H $@ $< Index: dlls/Makedll.rules.in =================================================================== RCS file: /home/wine/wine/dlls/Makedll.rules.in,v retrieving revision 1.69 diff -u -r1.69 Makedll.rules.in --- dlls/Makedll.rules.in 19 Oct 2004 23:06:12 -0000 1.69 +++ dlls/Makedll.rules.in 24 Nov 2004 20:49:53 -0000 @@ -31,8 +31,8 @@ # Rules for .dll files -$(MODULE): $(RCOBJS) $(OBJS) $(MODULE).dbg.o $(SPEC_DEF) $(IMPORTLIBS) Makefile.in - $(DLLWRAP) -k --def $(SPEC_DEF) -o $@ $(RCOBJS) $(OBJS) $(MODULE).dbg.o -L$(DLLDIR) $(DELAYIMPORTS:%=-l%) $(IMPORTS:%=-l%) $(ALL_LIBS) +$(MODULE): $(RCOBJS) $(OBJS) $(MODULE).dbg.o $(MODULE:%.dll=%).pedll.o $(SPEC_DEF) $(IMPORTLIBS) $(DLLDIR)/libntdll.$(IMPLIBEXT) Makefile.in + $(DLLWRAP) -k --def $(SPEC_DEF) -o $@ $(RCOBJS) $(OBJS) $(MODULE).dbg.o $(MODULE:%.dll=%).pedll.o -L$(DLLDIR) $(DELAYIMPORTS:%=-l%) $(IMPORTS:%=-l%) -lntdll $(ALL_LIBS) $(SPEC_DEF): $(WINEBUILD) Index: tools/winebuild/build.h =================================================================== RCS file: /home/wine/wine/tools/winebuild/build.h,v retrieving revision 1.54 diff -u -r1.54 build.h --- tools/winebuild/build.h 8 Oct 2004 21:11:18 -0000 1.54 +++ tools/winebuild/build.h 24 Nov 2004 20:50:34 -0000 @@ -185,6 +185,7 @@ extern void BuildSpec32File( FILE *outfile, DLLSPEC *spec ); extern void BuildDef32File( FILE *outfile, DLLSPEC *spec ); extern void BuildDebugFile( FILE *outfile, const char *srcdir, char **argv ); +extern void BuildPedllFile( FILE *outfile, DLLSPEC *spec ); extern int parse_spec_file( FILE *file, DLLSPEC *spec ); extern int parse_def_file( FILE *file, DLLSPEC *spec ); Index: tools/winebuild/main.c =================================================================== RCS file: /home/wine/wine/tools/winebuild/main.c,v retrieving revision 1.57 diff -u -r1.57 main.c --- tools/winebuild/main.c 19 Oct 2004 23:09:02 -0000 1.57 +++ tools/winebuild/main.c 24 Nov 2004 20:50:34 -0000 @@ -77,7 +77,8 @@ MODE_DEF, MODE_DEBUG, MODE_RELAY16, - MODE_RELAY32 + MODE_RELAY32, + MODE_PEDLL }; static enum exec_mode_values exec_mode = MODE_NONE; @@ -164,7 +165,8 @@ " --exe=NAME Build a .c file for the named executable\n" " --debug [FILES] Build a .c file with the debug channels declarations\n" " --relay16 Build the 16-bit relay assembly routines\n" -" --relay32 Build the 32-bit relay assembly routines\n\n" +" --relay32 Build the 32-bit relay assembly routines\n" +" --pedll Build a .c file for PE dll\n\n" "The mode options are mutually exclusive; you must specify one and only one.\n\n"; enum long_options_values @@ -178,7 +180,8 @@ LONG_OPT_RELAY16, LONG_OPT_RELAY32, LONG_OPT_SUBSYSTEM, - LONG_OPT_VERSION + LONG_OPT_VERSION, + LONG_OPT_PEDLL }; static const char short_options[] = "C:D:F:H:I:K:L:M:N:d:e:f:hi:kl:m:o:r:w"; @@ -195,6 +198,7 @@ { "relay32", 0, 0, LONG_OPT_RELAY32 }, { "subsystem",1, 0, LONG_OPT_SUBSYSTEM }, { "version", 0, 0, LONG_OPT_VERSION }, + { "pedll", 1, 0, LONG_OPT_PEDLL }, /* aliases for short options */ { "source-dir", 1, 0, 'C' }, { "delay-lib", 1, 0, 'd' }, @@ -356,6 +360,11 @@ case LONG_OPT_VERSION: printf( "winebuild version " PACKAGE_VERSION "\n" ); exit(0); + case LONG_OPT_PEDLL: + set_exec_mode( MODE_PEDLL ); + spec_file_name = xstrdup( optarg ); + set_dll_file_name( optarg, spec ); + break; case '?': usage(1); break; @@ -460,6 +469,11 @@ case MODE_RELAY32: if (argv[0]) fatal_error( "file argument '%s' not allowed in this mode\n", argv[0] ); BuildRelays32( output_file ); + break; + case MODE_PEDLL: + if (argv[0]) fatal_error( "file argument '%s' not allowed in this mode\n", argv[0] ); + if (!parse_input_file( spec )) break; + BuildPedllFile( output_file, spec ); break; default: usage(1); Index: tools/winebuild/spec32.c =================================================================== RCS file: /home/wine/wine/tools/winebuild/spec32.c,v retrieving revision 1.84 diff -u -r1.84 spec32.c --- tools/winebuild/spec32.c 18 Oct 2004 21:27:52 -0000 1.84 +++ tools/winebuild/spec32.c 24 Nov 2004 20:50:34 -0000 @@ -860,12 +860,10 @@ int is_data = 0; if (!odp) continue; - if (odp->flags & FLAG_REGISTER) continue; - if (odp->type == TYPE_STUB) continue; - if (odp->name) name = odp->name; + else if (odp->type == TYPE_STUB) name = make_internal_name( odp, spec, "stub" ); else if (odp->export_name) name = odp->export_name; - else continue; + else name = make_internal_name( odp, spec, "noname_export" ); fprintf(outfile, " %s", name); @@ -895,11 +893,37 @@ } break; } + case TYPE_STUB: + { + if (!kill_at) + { + const char *check = name + strlen(name); + while (name != check && + '0' <= check[-1] && check[-1] <= '9') + { + check--; + } + if (name != check && check != name + strlen(name) && + '@' == check[-1]) + { + fprintf(outfile, "%s", check - 1); + } + } + if (NULL != odp->name) + { + fprintf(outfile, "=%s", make_internal_name( odp, spec, "stub" )); + } + break; + } default: assert(0); } fprintf( outfile, " @%d", odp->ordinal ); +#if 0 /* MinGW binutils cannot handle this correctly */ if (!odp->name) fprintf( outfile, " NONAME" ); +#else + if (!odp->name && (odp->type == TYPE_STUB || odp->export_name)) fprintf( outfile, " NONAME" ); +#endif if (is_data) fprintf( outfile, " DATA" ); if (odp->flags & FLAG_PRIVATE) fprintf( outfile, " PRIVATE" ); fprintf( outfile, "\n" ); @@ -1005,4 +1029,25 @@ "}\n", prefix ); free( prefix ); +} + + +/******************************************************************* + * BuildPedllFile + * + * Build a PE DLL C file from a spec file. + */ +void BuildPedllFile( FILE *outfile, DLLSPEC *spec ) +{ + int nr_exports; + + nr_exports = spec->base <= spec->limit ? spec->limit - spec->base + 1 : 0; + output_standard_file_header( outfile ); + + if (nr_exports) + { + /* Output the stub functions */ + + output_stub_funcs( outfile, spec ); + } }

1 0

Clipping error
by Stefan Dösinger 24 Nov '04

24 Nov '04

Hello! I'm trying to run apple iTunes 4.7.0.42 in Winehq CVS and I'm getting this failure when I try to access the music store. Wine asks me to report this. err:local:LOCAL_GetBlock not enough space in GDI heap 10bf for 28 bytes err:region:CombineRgn Invalid rgn=(nil) err:local:LOCAL_GetBlock not enough space in GDI heap 10bf for 28 bytes err:clipping:CLIPPING_UpdateGCRegion hVisRgn is zero. Please report this. err:ntdll:RtlpWaitForCriticalSection section 0x407d7740 "gdiobj.c: GDI_level" wait timed out in thread 0070, blocked by 0075, retrying (60 sec) wine: Unhandled exception (thread 0070), starting debugger... Can't attach process 61: error 5 If it's interesting for you I can provide more infos, otherwise simply drop my mail. I'm just sending it because wine asks me to report this. The rest of iTunes seems to work somehow. The Gui opens and I can play music, but it's slow, with X eating 100% of my CPU time. I have to use a native setupapi.dll from WinXP. Stefan

2 1

read registry
by mammique 24 Nov '04

24 Nov '04

Hello, i'm looking for a lightweight way to read the windows regitry. I don't know windows, so i don't know how it's done. The goal in simply to check the windows network configuration of a machine from a live-cd, to use the same parameters on the running live-cd. Do i need wine api and dlls to do that, or is this the windows registry readable using lower-level way ? I would prefer not to use wine, then network detection could be done from ramdisk during boot. Wating for your ligths :-) Regards. Camille.

3 3

winecfg/drivedetect.c breaks portability (#include <mntent.h>)
by Gerald Pfeifer 24 Nov '04

24 Nov '04

The addition of winecfg/drivedetect.c via revision 1.1 date: 2004/11/23 13:50:23; author: julliard; state: Exp; Mike Hearn <mike(a)navi.cx> - More heapification. - Split drive code into core, UI and autodetect. - Implement drive autodetection. - Slight redesign of drive tab. - Code cleanup. broke FreeBSD 4.10 which does not have <mntent.h>: /sw/gcc-3.3.4/bin/gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o drivedetect.o drivedetect.c drivedetect.c:28:20: mntent.h: No such file or directory In fact, FreeBSD 4.10 does not have getmntent() at all which leads to further breakage even if you properly autoconf for <mntent.h>: drivedetect.c:206: warning: implicit declaration of function `getmntent' The Linux man page states SysV also has a getmntent() function but the calling sequence differs, and the returned structure is different. Under SysV /etc/mnttab is used. BSD 4.4 and Digital Unix have a routine getmntinfo(), a wrapper around the system call getfsstat(). http://www.gsp.com/cgi-bin/man.cgi?section=3&topic=getmntinfo has the man page for FreeBSD. Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 1

Problem roundup
by Mike Hearn 24 Nov '04

24 Nov '04

Hi, So, trolling linuxquestions.org reveals the following top 3 problems users are having with Wine currently: 1) The RH9 RPMs are apparently being compiled with epoll support linked in. This is causing user pain. We should really be using dlsym here, why are we not again? 2) Our bestest bestest friends over at InstallShield Corp have released a new version of their elegant and simple product, which refuses to start with builtin DCOM. 3) Some people still seem to be getting the "C:\\Windows\\System does not exist" message. thanks -mike

6 21

Packaging Questions, New Debian Package, Packagers Guide
by Scott Ritchie 24 Nov '04

24 Nov '04

The Debian packages have gotten rather out of date, and it looks like Ove's not going to be making them any more. I took the initiative and decided to try making one myself. I'm polishing off a new Debian package now. Some major things I noticed: 1) There were a lot of old hacks in the package that are probably no longer necessary, due to advancements in wine like wineprefixcreate and such. There was also the remenants of a very old problem with compiling using flex (which I remember experiencing the old days) in the form of a special exception for installing newer flex packages. 2) Very old packages like winesetuptk should now be officially obsoleted by making them conflicted and replaced. I also did the same to the libwine-* packages that weren't doing anything but making documentation folders, like libwine-alsa. 3) Making my package looks to be a lot simpler than what's implied in the (now year out of date) package makers guide. I found that documentation quite useless (and didn't even find it until I was about half way done anyway). Again, this is probably due to advancements in wine itself. 4) What I didn't find is a standard list of packages that aren't strictly required for wine (like libxt-dev and flex), but that wine can benefit from. A good example would be the alsa development files. These are all things that should be included in the build dependencies for the package. So far, my list of build dependant packages is the following: flex, bison, libx11-dev, libasound2-dev, libxt-dev, libicu28-dev However, I'm not sure if this means the wine binary package should depend on them, since it's compiled in. So, should I make libicu28 a dependancy for wine? Now, this leads to the question: is it worth even having a package maintainers guide? If so, who wants to update it? Thanks, Scott Ritchie

8 20

Fwd: Re: [Wine]DC++ crashes with current CVS wine
by Pavel Troller 24 Nov '04

24 Nov '04

Hi! I've sent the message below to wine-users mailing list and nobody has replied until now. So I subscribed do wine-devel and I'm posting the message here. Of course I cannot distinguish whether this problem is important enough to be fixed, but I think it's some problem with wine dlls so it can help other apps too.. With regards, Pavel Troller ----- Forwarded message from Pavel Troller <patrol(a)sinus.cz> ----- > Hi! > I have a problem, that DC++ client now crashes in wine. The problem is that it > crashes using its own exception handler, from the wine's point of view the app > is running OK. The client simply pops up a dialog box saying that it just > crashed and the debug info is placed in a file called exceptioninfo.txt. OK, the > file is really there and it really shows something important: > > Code: c0000005 > Version: 0.4034 > Major: 4 > Minor: 10 > Build: 67766446 > SP: 0 > Type: 0 > Time: 2004-11-21 08:09:57 > TTH: EJEUEI5NYOW2OQOXRJC7OHZ2ZUSLA5JF6IPD6TI > > c:\documents\vcprojects\dcplusplus\windows\transferview.cpp(195): ? > c:\documents\vcprojects\dcplusplus\windows\transferview.h(50): ? > c:\program files\vs.net 2003\vc7\atlmfc\include\atlwin.h(3017): ? > user32!0x666BABF7: ? > user32!0x666BAF39: ? > user32!0x666C0D29: ? > user32!0x666ED284: ? > user32!0x666EE099: ? > user32!0x666EE2D5: ? > comctl32!0x57758097: ? > comctl32!0x5775D2C5: ? > comctl32!0x5775DFAE: ? > comctl32!0x5775E518: ? > comctl32!0x577666D7: ? > comctl32!0x577675C7: ? > user32!0x666BABF7: ? > user32!0x666BAF39: ? > user32!0x666C0D29: ? > c:\program files\vs.net 2003\vc7\atlmfc\include\atlwin.h(3020): ? > user32!0x666BABF7: ? > user32!0x666BAF39: ? > user32!0x666C0D29: ? > user32!0x666A3996: ? > c:\documents\vcprojects\include\wtl-7.5.4196\atlapp.h(499): ? > c:\documents\vcprojects\dcplusplus\windows\main.cpp(270): ? > 0x1F83D6C8: ? > > Because user32 and comctl32 are both mentioned in the backtrace, I tried to > switch them to native, but the program then crashed in a much worse way, > ending at a wine-dbg> prompt. > This exception info is shown, when win98 is emulated. Normally I'm emulating > nt40, in which case the backtrace is missing but the crash is looking very > similar from the user's point of view. > No important information (like unimplemented call etc.) is shown in the > wine's stdout/stderr. > Is there a developer which can help with this problem ? > With regards, Pavel Troller Hi! I have a lot of news in this case: I've downloaded sources for DC++ unstable and looked onto them to see in which place the program crashes. I've found that it occurs when the download/upload progress bar is about to be drawn. I've also found that progress bar drawing can be disabled in advanced setting (oh yes, source is the best user's manual You can have :-) ). I did so and DC++ started to work for me. I think that it is a good starting point for a wine developer to find, what's happening there, it should be easy to find when the source code which exhibits the bug is available and exact location of bug invocation is known. Because I know windows at a zero level, I cannot help with this, but I hope that others can, and fixing this bug may help other apps too (and, even in DC++, the bars are a nice eye-candy :-) ). Should I post this message to wine-devel, or is it enough to post it here, in wine-users ? With regards, Pavel Troller ----- End forwarded message -----

1 0

Re: Implement OleDuplicateData
by Dmitry Timoshkov 24 Nov '04

24 Nov '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > + logpalette->palVersion = 1; /* FIXME: what should this be? */ All Microsoft and other samples I've seen initialize this filed to 0x300. -- Dmitry.

1 0

Re: Problem roundup
by Ivan Leo Puoti 23 Nov '04

23 Nov '04

> So perhaps it would be better to build the RPMs against "pure" installs of > each distro, from the CDs? As i think nobody wants buggy systems, this will mean using --force to install RPMs of old headers. I've never heard of such an update breaking my RPMs so I won't do any such thing without considerable proof that it is really necessary and there is no better option. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Version Resources
by Dan Kegel 23 Nov '04

23 Nov '04

Tom wrote: > I hope this patch looks better. :) > If anything is incorrect just let me know. FYI, please don't use # in patch filenames. Sometimes that's a comment character, and it gives us shell programmers the willies. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

System colors
by Kevin Koltzau 23 Nov '04

23 Nov '04

CreateBrushIndirect under Wine currently returns stock brushes if the brush requested matches the color. In gdi/brush.c the following comment is made: /* If a solid brush is created in a color matching one of the * stock brushes, native returns the stock object (GDI heap * optimisation). Some apps rely on this as they otherwise * would leak their brushes. */ However under both Windows 95 and Windows XP this does not seem to be the case. Under Windows, the following holds true, but fails under Wine GetStockObject(BLACK_BRUSH) != CreateSolidBrush(RGB(0,0,0)) This issue currently breaks applications making calls to SetSysColors as stock brushes are deleted as the new colors are added. Does anyone know why this was setup in this way? Or which version of Windows that exhibits the behavior mentioned in the comment? -Kevin

2 1

Problems with mailing list
by Robert van Herk 23 Nov '04

23 Nov '04

Hi all, Last month I moved, as did my ip address. Since then, I don't seem to get any messages from the wine devel mailing list, although I am still subscribed. I don't know whom to send this to, but can somebody (the admin of the list) please try to find out what is the problem? Thanx, Robert

2 1

Handles in GDI
by lats 23 Nov '04

23 Nov '04

I have been trying to track a problem in gdiobj.c where I had a handle of 0x107e. In GDI_GetObjPtr the handle & 2 is said to indicate a GDI Heap handle. From everything else I have read, that bit is supposed to indicate a Moveable handle. Is there something special about GDI handles that I should know about? Jeff

1 0

Configure missing a step
by Scott Ritchie 23 Nov '04

23 Nov '04

I managed to get past configure and then have a compile error due to a missing header file: intrinsic.h Configure should be checking for this file, like it checks for flex and bison and such. The package I needed to install was libxt-dev I'm on Ubuntu at the moment, but this should be true for all Debian systems. Could someone else clean this up? I'm scared to touch configure. -Scott Ritchie

1 0

Re: syscolors: do not delete stock brushes
by Kevin Koltzau 23 Nov '04

23 Nov '04

Please do not apply this patch On Thursday 11 November 2004 11:38 pm, Kevin Koltzau wrote: > This is a bit of a bad hack, but very bad things happen when a stock brush is deleted > > Changelog > Prevent deletion of stock brushes when system colors change >

1 0

Re: Resend: [dx9-12 next try] SetStreamSource changes
by Mike Hearn 23 Nov '04

23 Nov '04

On Mon, 22 Nov 2004 20:01:03 +0000, Ann and Jason Edmeades wrote: > Was there a problem with this one - Its really holding me up with progress, > so I need to ensure I resolve any issues asap. Apologies if this is still in > your list of patches to work through as I heard you have just moved If the problem is source control related (as opposed to technical direction related) you may want to look at svk, which lets you branch CVS repositories into a local repository then commit to your branch. Unlike arch it doesn't require a gateway and it isn't hard to set up or use. Hope that helps. thanks -mike

2 1

Re: profiling GTA4. question about polling
by Brian Gunlogson 23 Nov '04

23 Nov '04

--- Raphael <fenix(a)club-internet.fr> wrote: > Well, drawStriddedSlow is very very very slow (as function name :) ) > because is the software rendering path of wine d3d8 implementation > The only way to have good performances is to add needed support to hardware > rendering path (drawStriddedFast). > > Current version on hardware rendering path doesn't support (see > d3d8/drawprim.c:1590): > - pixel size (rarely used) > - blending weights (low use) > - diffuse color (highly used) > > In this cases the slow rendering path is used instead. > > I have a local "prototype" to have a better support of that cases (using > hardware vertex buffers) who have very good performances. > Ex: i have now a good framerate for UT2004 and Unreal2 (before i had ugly > lags) > > But, as Jason is currently doing a lot of work on splitting/moving code to > wined3d, we'll have to wait to commit it (and i should help him, when i'll > have time). Is this a tedious task or does it require knowledge of the codebase? I might be able to help. > Anyway, can you test what GTA4 want to use: diffuse, psize or/and blending ? > I'll try to send you a patched version of d3d8 to test after that :) GTA uses diffuse color exclusively. This was after playing the game for about 3 minutes on highest settings: pixel size: 0 diffuse: 745455 blending weights: 0 > Regards, > Raphael > > PS: > how have you done to use oprofile on wine ? > i'm very interested :) Just download the latest CVS from http://oprofile.sourceforge.net/download/ and see the README. I assume you know how to get it compiled and installed :) As root: # opcontrol --start # opcontrol --reset '--reset' clears out any old unwanted profiling data # opcontrol --separate=kernel '--separate=kernel' Seperates output by library and kernel [this is the hardest option to understand]. Profiling is on, run the application to profile and do not do anything else. When done: # opcontrol --dump '--dump' flushes remaining data to disk # opreport -l >./myreport.log Stores the flat profile in a file called myreport.log. Brian G __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

2 1

Re: epoll, LSB (was: Re: Problem roundup)
by Dan Kegel 22 Nov '04

22 Nov '04

Mike Hearn wrote: >> I'm not aware of e.g. an LSB-1.3 application that doesn't run properly >> on any system that supports LSB-1.3. Are you? > > I'm not aware of any LSB applications at all, actually. But let's take > RealPlayer for example. Let's pretend that Real had made it an LSB app. > > Would that have saved it from being broken by NPTL. No. LSB doesn't > specify (as far as I'm aware) that LSB apps must be linked > against LinuxThreads. Bzzt. In the real world, the distro vendor would have noticed this during LSB certification, and since the shared library loader for LSB 1.3 is /lib/ld-lsb.so.1 rather than /lib/ld-linux.so.2, the vendor can easily force libc to be linuxthreads based even if the default libc is NPTL based. I believe that as people start building LSB-compliant apps, they'll find it quite a useful way to avoid having to package ten different flavors of their apps just to be compatible. It's going to be a lot easier with LSB 3.0, since by that time the C++ ABI will have settled down, but I do think even LSB 2.0 is worth looking at for some applications. Yes, I know, you'll probably want to post something bitter and negative about LSB in response, but I'm going to put my hands over my ears and go "la la la", so I won't notice whether you actually do :-) - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 2

epoll, LSB (was: Re: Problem roundup)
by Dan Kegel 22 Nov '04

22 Nov '04

Mike Hearn: > 1) The RH9 RPMs are apparently being compiled with epoll support linked > in. This is causing user pain. We should really be using dlsym here, > why are we not again? Alexandre Julliard: > glibc is not backwards compatible, the RH9 RPMs should be built > against the RH9 glibc. There is nothing special about epoll, you can > have the same issue with any glibc symbol, and we can't start > dynamically loading them all. Mike Hearn: > We don't have to be over-general about it, just dynamically loading the > ones that cause problems would be fine (or using syscalls directly). The > vast majority of the symbols are always there and so it doesn't make sense > to use dlsym. Alexandre Julliard: > I think it's much better to ask packagers to build their packages > correctly, it will cause much less trouble in the long run. Or better yet, ask people to download the right package. I just downloaded http://prdownloads.sourceforge.net/wine/wine-20041019-1rh9winehq.i686.rpm and it worked fine on RH9. I wonder, though: the fact that somebody downloaded the wrong package means there are probably too many different versions at sourceforge to download. I count 24 packages! (OK, a few of them are srpms.) Shoot, can't we package Wine as an LSB package? I suspect Wine depends on nothing that isn't in the LSB. That'd make life a lot easier for the users... at least for those whose distros come with LSB support installed by default. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

12 28

Re: epoll, LSB (was: Re: Problem roundup)
by Ivan Leo Puoti 22 Nov '04

22 Nov '04

>> I know Dimi is against it, but that looks like a good thing to do to me. > >It's not that I'm against it, I don't much care for the sf.net download page, >really. If people are willing to work on something that is less confusing, >by all means, but let's try to not complicate our current download page, >it is rather nice :) Well, wine.sf.net just redirects to winehq.com, using it for a nvidia like download page instead would be cool. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

KERNEL32: add a test case for CompareStringW undocumented flag 0x10000000
by Mike McCormack 22 Nov '04

22 Nov '04

Hi All, I've written a regression test that shows what the undocumented flag 0x10000000 passed by shlwapi.StrIsIntlEqualW/A to CompareStringW/A does. I discovered the different by writing a short program that compared the output of CompareString with and without the flag for all unicode characters... it took a while to run :) The flag (0x10000000) passed to CompareString reverse the sort order of a number of unicode characters. I've got no idea why it would want to do that... maybe somebody can shed some light on what the reason behind this would be? Mike ChangeLog: * add a test case for CompareStringW undocumented flag 0x10000000 Index: dlls/kernel/tests/locale.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/tests/locale.c,v retrieving revision 1.33 diff -u -r1.33 locale.c --- dlls/kernel/tests/locale.c 21 Nov 2004 15:47:24 -0000 1.33 +++ dlls/kernel/tests/locale.c 21 Nov 2004 17:01:12 -0000 @@ -1410,6 +1410,76 @@ } #endif +static void test_CompareString_undoc(void) +{ + WCHAR table1[] = { + 0x0651, 0x3005, 0x3031, 0x3032, 0x309d, 0x309e, 0x30fc, 0x30fd, + 0x30fe, 0xfe7c, 0xfe7d, 0xff70 + }; + WCHAR table2[] = { + 0x02b9, 0x02ba, 0x02bb, 0x02bc, 0x02bd, 0x02be, 0x02bf, 0x02c0, + 0x02c1, 0x02c2, 0x02c3, 0x02c4, 0x02c5, 0x02c8, 0x02cc, 0x02cd, + 0x02ce, 0x02cf, 0x02d1, 0x02d2, 0x02d3, 0x02d4, 0x02d5, 0x02d6, + 0x02d7, 0x02de, 0x02e4, 0x02e5, 0x02e6, 0x02e7, 0x02e8, 0x02e9, + 0x0300, 0x0301, 0x0302, 0x0303, 0x0304, 0x0305, 0x0306, 0x0307, + 0x0308, 0x0309, 0x030a, 0x030b, 0x030c, 0x030d, 0x030e, 0x030f, + 0x0310, 0x0311, 0x0312, 0x0313, 0x0314, 0x0315, 0x0316, 0x0317, + 0x0318, 0x0319, 0x031a, 0x031b, 0x031c, 0x031d, 0x031e, 0x031f, + 0x0320, 0x0321, 0x0322, 0x0323, 0x0324, 0x0325, 0x0326, 0x0327, + 0x0328, 0x0329, 0x032a, 0x032b, 0x032c, 0x032d, 0x032e, 0x032f, + 0x0330, 0x0331, 0x0332, 0x0333, 0x0334, 0x0335, 0x0336, 0x0337, + 0x0338, 0x0339, 0x033a, 0x033b, 0x033c, 0x033d, 0x033e, 0x033f, + 0x0340, 0x0341, 0x0342, 0x0343, 0x0344, 0x0345, 0x0346, 0x0347, + 0x0348, 0x0370, 0x0371, 0x0372, 0x0483, 0x0484, 0x0485, 0x0486, + 0x0559, 0x055a, 0x0591, 0x0592, 0x0593, 0x0594, 0x0595, 0x0596, + 0x0597, 0x0598, 0x0599, 0x059a, 0x059b, 0x059c, 0x059d, 0x059e, + 0x059f, 0x05a0, 0x05a1, 0x05a2, 0x05a3, 0x05a4, 0x05a5, 0x05a6, + 0x05a7, 0x05a8, 0x05a9, 0x05aa, 0x05ab, 0x05ac, 0x05ad, 0x05ae, + 0x05af, 0x05b0, 0x05b1, 0x05b2, 0x05b3, 0x05b4, 0x05b5, 0x05b6, + 0x05b7, 0x05b8, 0x05b9, 0x05ba, 0x05bb, 0x05bc, 0x05bd, 0x05bf, + 0x05c0, 0x05c1, 0x05c2, 0x093c, 0x0951, 0x0952, 0x0953, 0x0954, + 0x0981, 0x09bc, 0x09c1, 0x09c2, 0x09c3, 0x09c4, 0x09cd, 0x09e2, + 0x09e3, 0x0a02, 0x0a3c, 0x0a41, 0x0a42, 0x0a47, 0x0a48, 0x0a4b, + 0x0a4c, 0x0a70, 0x0a71, 0x0a81, 0x0a82, 0x0abc, 0x0ac1, 0x0ac2, + 0x0ac3, 0x0ac4, 0x0ac5, 0x0ac7, 0x0ac8, 0x0acd, 0x0b01, 0x0b3c, + 0x0b3f, 0x0b41, 0x0b42, 0x0b43, 0x0b4d, 0x0bcd, 0x0c3e, 0x0c3f, + 0x0c40, 0x0c46, 0x0c47, 0x0c48, 0x0c4a, 0x0c4b, 0x0c4c, 0x0c4d, + 0x0c55, 0x0c56, 0x0cbf, 0x0cc6, 0x0ccd, 0x0d41, 0x0d42, 0x0d43, + 0x0d4d, 0x0e47, 0x0e48, 0x0e49, 0x0e4a, 0x0e4b, 0x0e4c, 0x0e4d, + 0x0eb1, 0x0eb4, 0x0eb5, 0x0eb6, 0x0eb7, 0x0eb8, 0x0eb9, 0x0ebb, + 0x0ebc, 0x0ec8, 0x0ec9, 0x0eca, 0x0ecb, 0x0ecc, 0x0ecd, 0x1026, + 0x1027, 0x1028, 0x1029, 0x102a, 0x102e, 0x1030, 0x1036, 0x1037, + 0x103b, 0x103d, 0x103e, 0x104b, 0x104c, 0x20d0, 0x20d1, 0x20d2, + 0x20d3, 0x20d4, 0x20d5, 0x20d6, 0x20d7, 0x20d8, 0x20d9, 0x20da, + 0x20db, 0x20dc, 0x20dd, 0x20de, 0x20df, 0x20e0, 0x20e1, 0x302a, + 0x302b, 0x302c, 0x302d, 0x302e, 0x302f, 0x3099, 0x309a, 0x309b, + 0x309c, 0xfb1e, 0xff9e, 0xff9f + }; + DWORD r,i,j; + WCHAR x[2],y[2]; + BOOL bPass = TRUE; + + x[1]=0; + y[1]=0; + for(i=0; bPass && (i<sizeof table1/sizeof table1[0]); i++) + { + x[0] = table1[i]; + for(j=0; bPass && (j<sizeof table2/sizeof table2[0]); j++ ) + { + y[0] = table2[2]; + r = CompareStringW(LOCALE_SYSTEM_DEFAULT, 0x10000000, x, 2, y, 2 ); + if (r!=CSTR_GREATER_THAN) + bPass = FALSE; + r = CompareStringW(LOCALE_SYSTEM_DEFAULT, 0, x, 2, y, 2 ); + if (r==CSTR_LESS_THAN) + bPass = FALSE; + } + } + todo_wine { + ok(bPass,"undocumented flag 0x10000000 test failed\n"); + } +} + static void test_FoldStringA(void) { int ret, i; @@ -2103,6 +2173,7 @@ test_GetCurrencyFormatA(); /* Also tests the W version */ test_GetNumberFormatA(); /* Also tests the W version */ test_CompareStringA(); + test_CompareString_undoc(); test_LCMapStringA(); test_LCMapStringW(); test_FoldStringA();

3 3

Re: epoll, LSB (was: Re: Problem roundup)
by Ivan Leo Puoti 22 Nov '04

22 Nov '04

>You're forgetting K6 and K6-2 users with i586. Also, RH never provided >i586 packages (except for kernel and glibc), so it'd be foreign to the >distro to offer only that. The why not just 386 and 686, that will fit all. And you could not build devel and srps packages, or build them but hide them, and put a links to them somewhre else than the main download page, so that people that want them can get them but end users who just want runtime stuff can get it easily. Or we could just build some download pages for winehq, and just host the files on sf.net, like that we could make them more user friendly. Or we could make some pages and put them on winehq.sf.net, so that packagers could edit them without having to touch the lostwages cvs. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 2

Re: epoll, LSB (was: Re: Problem roundup)
by Ivan Leo Puoti 21 Nov '04

21 Nov '04

> Could we show (our own pages) where users could choose distro, then > distro version, then actual package? Instead of pointing them to a few > screenful of files directly... We already partially have this, if you go to http://www.winehq.com/download and click on Red Hat you get this page http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=77396 that only contains RH packages. But I still think you should consider building fewer packages, probably an i586 build would do for almost all users. > Other ideas? Also have you ever tried building an RPM that runs on more than one version of RH? To run on 3 versions of mdk I only had to make very minor changes to the RPM. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

headers suggestion
by Jonathan Wilson 21 Nov '04

21 Nov '04

In light of e.g. http://reactos.com:8080/archives/public/ros-dev/2004-November/000658.html I would like to suggest the following header ideas. Currently MingW has: 1.A set of headers that contain a copy of part of the platform SDK 2.Some extra stuff (like that ntdll.h) 3.A set of headers that contain a copy of part of the windows DDK 4.Mabie again some extra stuff MS doesnt have (I dont know) 5.A set of headers that contain a copy of part of the visual C++ runtime library 6.Some extra stuff (mainly bits required to deal with differences between GCC and Visual C I think) WINE has: 1.A set of headers that are supposed to contain a copy of part of the platform SDK (although some things have been claimed to be wrong) 2.A set of headers that are supposed to contain a copy of part of the visual C++ runtime library (although again there may be things that are wrong) and 3.Extra definitions for stuff in both header sets microsoft doesnt define in the platform SDK (e.g. internal bits, functions microsoft doesnt document etc) ReactOS has: w32api (the ROS import of it) include/ddk (the ReactOS version of the windows DDK) include/wine (the WINE windows API headers) include/msvcrt (the MSVCRT headers ROS uses to build and link with msvcrt) include (various misc ReactOS specific headers) What I suggest for ReactOS (and I think some of this is already being done) is as follows: grab any headers from include/* that are public DDK headers (if there are any) and make sure they are all in include/ddk grab everything from the current WINE headers MingW is missing. Check that its all correct and stuff and add it to the ReactOS import of w32api. (if anything is found to be wrong in the wine headers, it should be fixed) grab anything from include itself and add to w32api as needed Get permission to relicence the stuff and contribute back to the main w32api tree. grab contents of include/msvcrt on ReactOS plus include/msvcrt on WINE and also mingw-runtime. Create one set of header files from the 3 sets such that it matches the microsoft headers as closely as possible. Merge w32api DDK headers with ROS DDK headers and create one set that, again, matches the MS headers. For w32api/mingw-runtime, the suggestion is that they look at all the "new stuff" generated by the merging of the 3 sets of msvcrt headers plus the ROS/WINE/w32api merger plus the DDK merger and look at acccepting it. For WINE, I suggest they start using the new "merged" headers if at all possible. Basicly, the idea is that mingw-runtime would become the "definitive" set of msvcrt.dll headers out there and that ReactOS, MingW and WINE would start using it for any case where you are talking to msvcrt.dll from the public side. both ROS and WINE would then have their own internal msvcrt headers as necessary to build their msvcrt* builds Then, w32api would become the "definitive" set of win32 api headers and would contain as much of the Microsoft Platform SDK as people have legally cloned. All userland components of ReactOS (as well as kernel-side bits that need the stuff in the userland headers e.g. win32k.sys) would use this. Be nice if WINE were to use this too but because of what WINE is and how it is built/used, there may be reasons for the WINE team not to use w32api as the build headers used to build WINE. And, there would be one "definitive" set of DDK headers which would be good enough for building ReactOS with. And for building any kernel-side stuff WINE decides to add (e.g. that stuff to load the device drivers for vaerious copy protection systems that was being worked on). And for anyone using MingW and MingW GCC to build kernel-mode stuff. Anything private or project specific would go into a set of private headers as needed for the different projects and sub-sections (dlls etc) within them Anything exported by microsoft but undocumented would go into a set of "undocumented" headers (which could then be shared between ReactOS and WINE since I dont think w32api would accept anything not documented in MSDN) Just suggestions btw, if they are good, say so If they are bad, say so (and say why) If there are issues with my idea, say what they are.

3 2

Re: epoll, LSB (was: Re: Problem roundup)
by Dan Kegel 21 Nov '04

21 Nov '04

Mike Hearn wrote: > [The LSB] really doesn't deal with anything useful at all that isn't already > stable and on every Linux system anyway. Correct. When a commonly-needed package becomes "stable", a snapshot of its interface specification is taken, and added to the LSB. LSB applications can then rely on that interface being available. That might sound like a no-op, but the painstaking attention to detail involved in nailing down the interfaces of the LSB offers a lot of stability. > The LSB is toothless while upstream > projects continue to treat platform stability as a trivial detail. I'm not aware of e.g. an LSB-1.3 application that doesn't run properly on any system that supports LSB-1.3. Are you? > Note: the LSB did nothing to avoid the NPTL fiasco The transition to NPTL, like many other transitions in Linux's history, was painful, but that's exactly the kind of pain the LSB saves applications from. > and it's doing nothing to > avoid the COMPOSITE ARGB mess despite both libc and Xlibs being a part of > the supposedly "stable" base. http://freedesktop.org/pipermail/xorg/2004-August/002326.html says "COMPOSITE is experimental, users of it should expect things to break." I believe that the COMPOSITE extension is not part of LSB, so any application using it is not LSB-conformant. Here again, applications that conform to the LSB are saved from the pain of unstable interfaces changing. > The LSB process moves so slowly though that there's > no chance of them ever having an up to date desktop specification. That's ok. All we need is that they have a useful, working desktop specification. Mike, I get the feeling you want the LSB to be something it's not. Relax, let the LSB folks do their thing. Yes, LSB applications will always be using stable old interfaces, but *that's the point*. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

[test.winehq.org] summary broken
by Stefan Leichter 21 Nov '04

21 Nov '04

Hello, i noticed something wrong in the summary of 200411201000. The main summary shows that the tests winspool.drv:info fails sometimes on the platform win2k, but in the summary of win2k (2000 differences) the line winspool.drv:info is not listed. Bye Stefan

2 1

GDI : implementation of GetLayout
by Rémi Assailly 21 Nov '04

21 Nov '04

I would like to know if my implementation of GetLayout is clean. I did not found any information about GetLayout16, I would like to know if it is correct too. Thanks Rémi

1 0

Re: epoll, LSB (was: Re: Problem roundup)
by Dan Kegel 21 Nov '04

21 Nov '04

Mike Hearn wrote: >> can't we package Wine as an LSB package? > > No, that's really not possible/sensible. > >> I suspect Wine depends on nothing that isn't in the LSB. > > I suspect it depends on a lot, for instance FreeType, OpenSSL, CUPS, > fontconfig, libasound/arts/jack, SANE, libjpeg etc etc. LSB 2.0 doesn't deal with sound, scanning, or printing (beyond lpr, anyway?), so an LSB 2.0 version of Wine would probably have to do without those. That'd be fine for me - I never use any of those features - but I realize that real users require themm. LSB 3, on the other hand, is going to add Gnome support, so they're at least thinking about the desktop now. (Your other objections - FreeType, fontconfig, libjpeg, OpenSSL, etc - could be packaged along with an LSB implementation of Wine, so they're not really an issue.) It would be worth doing an LSB 2.0 implementation of Wine as a demonstration of what's missing in the LSB; IMHO it would help put pressure on the LSB folks to include the missing bits in the next version. But remember, LSB can only standardize what has already stabilized in the field, and things like sound and printing are only now starting to not suck on Linux... - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Version information in hhctrl.ocx breaks hhupd.exe
by Sven.Paschukat＠t-online.de 21 Nov '04

21 Nov '04

Hello! I have noticed that in the last few days the native hhctrl.ocx doesn't installs anymore. Both the automatically installation in Internet Explorer and the manually start of Microsofts hhupd.exe fails with the message "This computer already has a newer version of HTML Help." I found out that integrating version information in the builtin hhctrl.ocx caused this effect. Look into the newest version of wine/dlls/hhctrl.ocx/Makefile.in and version.rc. Is this done wilfully or is it a bug? Thanks, Sven

6 14

SetForegroundWindow() from WM_ACTIVATE broken
by Jon Griffiths 21 Nov '04

21 Nov '04

Hi, I have an application that keeps a fullscreen back panel window open, with its current working windows always in front. The back panel and all working windows are parented to the desktop. On windows clicking anywhere on the back panel momentarily activates the back panel, then the working window is brought to the front. On wine the back panel is brought to the front and activated (title bar active), obscuring the working window. I have narrowed the cause of this down and created a tiny test app to demonstrate the problem. Under windows, Calling SetForegroundWindow(xxx) from within the WndProc (specifically, while handling the WM_ACTIVATE message), will cause the xxx window to become the foreground window and rise to the top of the z-order. On Wine the window that called SetForegroundWindow() rises to the top of the z-order and gets its titlebar activated. This makes the app rather unusable at present. Does anyone have an idea how to correct this behaviour? I have attached the test app and its source for testing in case that helps, and I'll post more info if I find anything more. Thanks, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

1 0

Re: epoll, LSB (was: Re: Problem roundup)
by Ivan Leo Puoti 20 Nov '04

20 Nov '04

> Do you think I should add an explicit dependancy on the redhat-release > (or fedora-release) package, so people don't install them on the wrong > distribution? Yes, it would be a good idea considering how many packages you build. > It's a mess, but Wine does some things so close to glibc that > it's difficult to provide a "one binary fits all" without compiling an a > very old setup I build on Mandrake 10.1, but the RPM works on 10.0 and 9.2, and I'm quite confident it will run on 10.2 with little or no changes. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: epoll, LSB (was: Re: Problem roundup)
by Ivan Leo Puoti 20 Nov '04

20 Nov '04

> I count 24 packages Well, I've got only one RPM that works on Mandrake 9.2, 10.0 and 10.1, and it runs on 9.1 too if you upgrade your glibc packages, so having fewer packages is porbably also possible for RH. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: (no subject)
by Dmitry Timoshkov 20 Nov '04

20 Nov '04

"Tom" twickline(a)sitestar.net wrote: > I changed the format to reflect the other version.rc files > +#define WINE_PRODUCTNAME_STR "winsock" You don't need to invent a product name, it's already defined in include/wine/wine_common_ver.rc. The product name is Wine. -- Dmitry.

2 2

TeleVantage client on Wine
by alexanderhenry＠cox.net 20 Nov '04

20 Nov '04

I am attempting to install the <a href="http://televantage.activelogic.com">TeleVantage Client</a> into wine. I have compiled Wine-20041019 from source. Upon running the installer, I get way too many errors: alexander@reservations:~$ wine .wine/drive_c/AppsPatches/netsetup/setup.exe fixme:msi:MsiGetProductInfoA "{8715D03E-39E4-4260-BB83-C63CA64D7660}" "PackageCode" 0x4069dbbc 0x4069dc2c fixme:msi:MsiGetProductInfoW L"{8715D03E-39E4-4260-BB83-C63CA64D7660}" L"PackageCode" 0x403b0118 0x4069dc2c err:dc:DCE_FreeWindowDCE [0x10026] GetDC() without ReleaseDC()! fixme:msi:MsiEnableLogA 00007fdf "c:\\windows\\wssetup.log" 00000000 fixme:msi:MsiInstallProductW L"Z:\\home\\alexander\\.wine\\drive_c\\AppsPatches\\netsetup\\Client.msi" L"SETUPEXEDIR=Z:\\home\\alexander\\.wine\\drive_c\\AppsPatches\\netsetup" err:msi:HANDLE_CustomType1 Unable to load library fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"AppSearch" fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"ValidateWorkstationSetupOSVersion") fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"FindRelatedProducts" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"ValidateProductID" err:msi:load_file Unfound Component L"MSXML.35210702_493B_42CA_BA13_865C5A8BDAC1" [.. above line x5] fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"IsolateComponents" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"ResolveSource" fixme:msi:ACTION_CostFinalize Version comparison.. [.. above line x10] fixme:msi:ACTION_CostFinalize cost should be diff in size fixme:msi:ACTION_CostFinalize Version comparison.. [.. above lines x3] alexander@reservations:~$ fixme:msi:ACTION_CostFinalize Version comparison.. fixme:msi:ACTION_CostFinalize Version comparison.. [.. above line x30] fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"ValidateIE5") fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"ValidateDCOM98") fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"GetWorkstationSetupInfo") fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"SetWorkstationSetupInstallPaths") fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"CacheWorkstationSetupSettings") fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"SetODBCFolders" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"MigrateFeatureStates" fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"SetWorkstationSetupFeatureStates") fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveExistingProducts" fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"RemoveReports") fixme:msi:ACTION_CustomAction UNHANDLED ACTION TYPE 5 (L"JScript" L"RemoveOldWorkstationSetupShortcuts") fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"AllocateRegistrySpace" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnpublishComponents" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"MsiUnpublishAssemblies" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnpublishFeatures" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnregisterComPlus" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"SelfUnregModules" err:msi:HANDLE_CustomType1 Unable to load library fixme:msi:store_binary_to_temp File Name in temp tracking collision err:msi:HANDLE_CustomType1 Unable to load library fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnregisterTypeLibraries" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveODBC" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnregisterFonts" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveRegistryValues" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnregisterClassInfo" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnregisterExtensionInfo" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnregisterProgIdInfo" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"UnregisterMIMEInfo" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveIniValues" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveShortcuts" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveEnvironmentStrings" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveDuplicateFiles" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveFiles" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"RemoveFolders" fixme:msi:ACTION_PerformAction UNHANDLED MSI ACTION L"MoveFiles" err:msi:extract_cabinet_file FDICopy failed err:msi:ACTION_InstallFiles Unable to ready media err:msi:ACTION_ProcessExecSequence Execution halted due to error (1627) Installation of Z:\home\alexander\.wine\drive_c\AppsPatches\netsetup\Client.msi (SETUPEXEDIR=Z:\home\alexander\.wine\drive_c\AppsPatches\netsetup) failed. so I figured that rather than getting the installer to run, I'd copy the files into wine and run it this way. I was able to copy from one PC to another with success, as long as the following libraries were present and registered: MSVBVM60.DLL TVW32.dll Tvlib.dll mfc71.dll msvcp71.dll msvcr71.dll ssinput1.ocx It is possible to regsvr32 files MSVBVM60.DLL, TVW32.dll, Tvlib.dll, ssinput1.ocx. It is not possible to regsvr32 files mfc71.dll, msvcp71.dll, msvcr71.dll. Files mfc71.dll, msvcp71.dll don't even appear in the registry. msvcr71.dll does, under .NET framework. Added the following to config: ;"MSVBVM60.DLL" = "builtin, native" ;"TVW32.dll" = "builtin, native" ;"Tvlib.dll" = "builtin, native" ;"mfc71.dll" = "native, builtin" ;"msvcp71.dll" = "native, builtin" ;"msvcr71.dll" = "native, builtin" ;"ssinput1.ocx" = "builtin, native" (tried different combos of commented, non-commented, builtin, native, with absolutely no effect) Upon doing this and attempting to run TeleVantage, I get these messages, and a black screen that appears on the first output message and dissapears on the last: alexander@reservations:~$ wine c:\\Program\ Files\\TeleVantage\\Client\\TVClient.exe fixme:ole:CoRegisterMessageFilter stub fixme:ole:GetRecordInfoFromGuids (0x425e80,1,1,1033,0x42626c,0x506274),stub! fixme:ole:CoRegisterMessageFilter stub I got this blank-in-blank-out problem when I did the PC to PC copy procedure as well. TeleVantage client just likes to quit with no errors if something is wrong. Per the registry entries mentioned above, I figured that installing .NET into wine would solve the problem. I just learned the hard way for the first time what this would entail. Installing windows version of mono into wine didn't solve the problem, and the msvcr71.dll didn't appear. Do you have any suggestions to help me install TeleVantage client on wine? Thanks --Alexander

2 1

Re: No RichEdit20A window class
by Michael Ost 20 Nov '04

20 Nov '04

I'm re'ing my own post, but I think there's a combination of (1) a wine bug and (2) user error at work here. (1) The wine bug (I think) is that riched32.dll is registering the wrong window class name. Here's a suggested patch: [root@ihop dlls]# diff -Naur richedit/richedit.c richedit.MUSE/richedit.c --- richedit/richedit.c 2004-11-18 12:28:53.000000000 -0800 +++ richedit.MUSE/richedit.c 2004-11-18 17:03:33.000000000 -0800 @@ -792,7 +792,11 @@ wndClass.cbWndExtra = RTFInfoOffset + sizeof(RTFControl_Info*); wndClass.hCursor = LoadCursorA(0, (LPSTR)IDC_ARROW); wndClass.hbrBackground = (HBRUSH)(COLOR_WINDOW + 1); +#if (_RICHEDIT_VER >= 0x0200 ) + wndClass.lpszClassName = RICHEDIT_CLASS20A; /* WC_RICHED32A; */ +#else wndClass.lpszClassName = RICHEDIT_CLASS10A; /* WC_RICHED32A; */ +#endif RegisterClassA (&wndClass); } Can any wise ones comment on this? (2) My user error is that Windows requires that RICHED32.DLL be manually loaded before use, it seems. At least that's what MFC requires, via its AfxInitRichEdit2() function. I called LoadLibrary("RICHED32.DLL") and, with my above patch, CreateWindow(RICHEDIT_CLASS,...) works fine. This isn't true for other DLLs... but, oh well, there it is. Cheers... mo

5 9

Re: Default System Colors
by William Poetra Yoga H 20 Nov '04

20 Nov '04

--- Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > The colors of your gnome/kde desktop don't map that nicely to windows > colors. Because of this the end-result won't allways be very nice. In the > future we might want something like this. The best way to add something like > this is to finish our uxtheme dll and add support for theming to all > controls. Then WineLook=win95 (or winxp) will give you the "classic" colors > and lets say "uxtheme" will give everything the look and feel of lets say > gtk/qt. (this is how windows xp does its theming too) > > Roderick > Please reply below the original post. Yeah, agreed. Your idea is good, and we just have to wait for uxtheme.dll to finish. But in the meantime is it ok for us to change the default colors? Because the Win95 colors are just too... dull. And my "gradient colors for caption bar" patch will make WINE's windows look nice if Win2K/XP colors are applied... _IF_ my gradient-colors-patch will ever get accepted, because until now it's not been applied yet... (but that's for another thread :-P) __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail

6 16

OK, this is off topic, but...
by William Poetra Yoga H 19 Nov '04

19 Nov '04

I read WWN #249 and found my name is spelled correctly :) But the strange thing is, my (outgoing) name has been truncated in my emails since about a month ago. I wasn't trying to hide anything; rather, Yahoo! Mail has a maximum length of 32 characters for the outgoing name, and the last 'o' in my name gets truncated. It makes me feel itchy, so I decided truncating it would be better. But when I saw my name being spelled in full, I felt proud (I have always felt proud of my somewhat-long full name :P). So just out of curiosity, how did you guys know my real name? Anyway, now I have signature so you all should be able to read it. In full. Not restricted by Yahoo! Mail anymore. :) ===== William Poetra Yoga Hadisoeseno __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Re: Thread-safe gethostbyname for WinInet
by Robert Shearman 19 Nov '04

19 Nov '04

Robert Shearman wrote: > Hi, > > I have seen an issue that could be attributed to using the > non-thread-safe gethostbyname in wininet, so I have converted it as > best as I could to be thread-safe. > > Rob > > Changelog: > Use a thread-safe version of gethostbyname. Ignore this patch, it isn't actually any safer than the current version (actually, it's a lot less safer). I'll fix it up and resend soon. Rob

1 0

Re: Re: Kernel 2.6.9 - Issue Found
by Pouech Eric DMI AEI CAEN 19 Nov '04

19 Nov '04

from what I read from Linus / Roland discussion on this topic (this night) on lkml, Linus only patched 1 out of 3 places which need to be patched (according to Roland). But I don't know yet if Linus will finish the job or not :-( IMO, what Linus proposes heads into the right direction (don't single step in signal handler if the process itself has set the TF flag, but do if the debugger has done it), however I cannot tell whether it's going to fix all issues. A+ > Message du 16/11/04 02:15 > De : "Jesse Allen" > A : wine-devel(a)winehq.org > Copie à : > Objet : Re: Kernel 2.6.9 - Issue Found > On Sun, Nov 14, 2004 at 08:45:00PM -0700, Jesse Allen wrote: > > On Sun, Nov 14, 2004 at 06:11:33PM -0800, Dan Kegel wrote: > > > I couldn't find the patch at either of the two > > > links Jesse posted, but I did see something similar here: > > > http://marc.theaimsgroup.com/?l=bk-commits-head&m=110048429304053&w=2 > > > > That's a brand new patch today. > > > > "x86: only single-step into signal handlers if the tracer asked for it." > > > > Looks like Linus may have been alerted by the problem and made this patch just > > in time for 2.6.10-rc2. Is this the "switch-off" we need? > > > > I'll be testing it shortly. > > > > It doesn't seem to fix the copy protection problem. So I'm wondering a few > things. Does wine need to be patched? This new patch seems to be related to > a chunk of code added in patch #2 mentioned in the original posting. I've > tried 2.6.10-rc2 with patch #1 reversed and patch 1+3 reversed. No difference > this time. > > Any idea will help. > > Jesse > >

3 2

Error while running wineprefixcreate
by ashok jani 19 Nov '04

19 Nov '04

Dear Developer(s), While I am trying to run wineprefixcreae command on redhat 9.0 professional personal desktop installation following error is generated. # wineprefixcreate /usr/bin/wineserver: relocation error: /usr/bin/wineserver: symbol epoll_create, version GLIBC_2.3.2 not defined in file libc.so.6 with link time reference What is the solution? Ashok __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

2 1

replace a wrong fixme in dlls/winmm/playsound.c
by Rémi Assailly 19 Nov '04

19 Nov '04

I tested a software ( a monopoly game ) and the error was that a sound was still playing so I think that is not a wine bug. Before submitting this patch to wine-patches I would like to know what do you think about it, what should be WARN, FIXME, if choosing ERR to all is correct or if some cases are useless.

3 3

wine - systray - gnome 2.8
by Grant Williamson 19 Nov '04

19 Nov '04

Hi, I am seeing in Gnome-2.8 on the beta of RHEL4, the KDE status icons dock & are displayed correctly on the gnome systray. I am wondering if it anyone has considered using this technique to display wined based status icons now in gnome?< i.e. lotus notes new mail notification. Or am I simply barking mad?

3 3

CVS updates?
by Christian Britz 19 Nov '04

19 Nov '04

Hi, sorry if this a stupid question, but I wonder why I get no new files anymore via cvs for about a week now (may be less or more). Are there really no updates or have I somehow misconfigured something? I'm used to get updates almost once a day... Thank you Christian

3 2

Win32 simulation
by Demoniak 19 Nov '04

19 Nov '04

Hi ! Currently, I try to develop a stress tool for Windows. My main problem is to "simulate" multiple Windows system on one machine because of mouse and keyboard, and because only one Desktop or one Station can be active at a time. I discover Wine and I wonder if it is possible to use it on Windows platform to launch mutliple Windows-like OS ? - on http://sourceforge.net/project/showfiles.php?group_id=6241 there is a Win32 package. Is it dedicated to install Wine on Win XP ? How can I install it (five zip) ? - is it possible to launch multiple Wine on Windows ? (typically each one in a different Window, easily to monitor ?) - does Wine support Windows hooks mechanism ? I think it is a good beginning if I can have all this answers ;-))) Thanks Demoniak (not my real name) --------------------------------- Demoniak http://www.quisque.com --------------------------------- --------------------------------- Créez gratuitement votre Yahoo! Mail avec 100 Mo de stockage ! Créez votre Yahoo! Mail Le nouveau Yahoo! Messenger est arrivé ! Découvrez toutes les nouveautés pour dialoguer instantanément avec vos amis.Téléchargez GRATUITEMENT ici !

2 1

Re: prevent peekmessage from crashing when msg == NULL
by Juan Lang 19 Nov '04

19 Nov '04

Eric wrote: > Somewhere, for some reason, our client code was calling > PeekMessage(NULL, ...), basically asking windows to > discard a single message without returning it. From the > MSDN docs, this seems like an illegal use of the function, > but Windows does the right thing when we do it and wine > crashes. This sounds like a good place to write a test case. --Juan p.s. and I'll call that bluff: how _do_ you know what happens when you have more than 500 printers defined? ;) __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

3 4

Up-to-date instructions for relay trace
by Bill Medland 19 Nov '04

19 Nov '04

Can someone please remind me; I can't find anything any longer in either the Wine User Guide or the Wine Developer's Guide I want to get a relay trace of all calls to functions in msvcrt.dll and in no other dlls. I thought all I'd have to do was set export WINEDEBUG=+relay and in the config file I set [Debug] "RelayFromInclude" = "msvcrt" ; everything else commented out However that also provides trace for a load of other stuff. Can I get just the msvcrt? (and, no I can't do it by getting everything and grepping the msvcrt; the program won't run with a full relay trace) -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

1 0

No RichEdit20A window class
by Michael Ost 19 Nov '04

19 Nov '04

Hi. My winelib application can't create a window of class RichEdit20A. It looks like the class is not being registered, because the DLL is not being loaded. Any clues why this might be? Turning on trace+richedit shows that dlls/richedit/richedit.c's RICHED32_Register and DllMain are not being called My test app tries to create a RICHEDIT_CLASS window and then it tries a TOOLTIP_CLASS window. Since both window classes are registered from their respective DLLInit I thought they would make a good comparison. The first fails; the other doesn't. Neither riched32.dll nor commctrl.dll show up in the exe.spec.c file, since winebuild finds none of their entry points in my code. But the commctrl DLL is loaded, while the riched32 one is not. Psuedo-code: #include <richedit.h> #include <tooltips.h> winmain(...) { CreateWindow(RICHEDIT_CLASS, ....) // Fails: I see err:win:CreateWindowExA bad class name "RichEdit20A" // on the console CreateWindow(TOOLTIP_CLASS, ...) // no complaint } Any help would be appreciated... mo =================================== Michael Ost, Software Architect Muse Research, Inc. most(a)museresearch.com

1 0

Fwd:providing app db entries
by Ivan Leo Puoti 18 Nov '04

18 Nov '04

Not sure what to answer, so I'm forwarding to wine-devel Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

RE: profiling GTA4. question about polling
by Ann and Jason Edmeades 18 Nov '04

18 Nov '04

Hi Brian, Firstly thanks for the profiling info - its something I have been waiting to try when I get through the d3d9 changes. We have always known that routine was bad (hence the name 'slow'!) but that confirms it. Re the splitting into wined3d - You asked "Is this a tedious task or does it require knowledge of the codebase?"... It's a bit of both. I am taking it slower because I am trying to ensure the patches get committed so I don't end up reworking things, and I only have limited time so I don't want to waste it. At the moment I am 'stuck' trying to get a particular patch in, which will dictate the future direction of lots of other patches, so it is important we get it right. Once that's done, I really hope to make a lot of progress relatively quickly, and once I get beyond a certain point, feel free to hack away. I hate the fact I am holding anyone back! Please do take Raphael's test patch and try again - I would be interested to know if it makes a significant difference (which I do believe it should). I would be very interested in any other profiling results, and if you feel like improving things in the code please go for it. One thing I always fancied doing was to profile the 3dMark2001SE utility, and see how close to windows performance we can get and identify the bottlenecks. Regards, Jason

1 0

Is it time to delete wineinstall?
by Dan Kegel 18 Nov '04

18 Nov '04

Is wineinstall needed anymore? README seems to indicate you can install Wine just fine without it. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

11 21

Re: dialogex resource loading on sparc
by Dmitry Timoshkov 18 Nov '04

18 Nov '04

"Eric Frias" <efrias(a)syncad.com> wrote: > --- windows/dialog.c (.../vendor/wine/current) (revision 29312) > +++ windows/dialog.c (.../branches/wine/2004.11.16-cvs-update) (revision 29312) > @@ -378,8 +378,10 @@ > { > const WORD *p = (const WORD *)template; > > - result->style = GET_DWORD(p); p += 2; > - if (result->style == 0xffff0001) /* DIALOGEX resource */ > + WORD signature = GET_WORD(p); p++; > + WORD dlgver = GET_WORD(p); p++; This won't compile with older C compilers, you are mixing data declarations with code. -- Dmitry.

2 1

replace a wrong fixme in dlls/winmm/playsound.c
by Rémi Assailly 18 Nov '04

18 Nov '04

I tested a software ( a monopoly game ) and the error was that a sound was still playing so I think that is not a wine bug. Before submitting this patch to wine-patches I would like to know what do you think about it, what should be WARN, FIXME, if choosing ERR to all is correct or if some cases are useless.

1 0

Re: Is it time to delete wineinstall?
by Ivan Leo Puoti 17 Nov '04

17 Nov '04

> Besides, on the wine-users alias, new users who > install RPMs have no idea there is a config file > because the RPMs don't create it for them. The config file is meant to go ASAP, so that is a good thing. Most users use RPMs and are quite happy with them, and it causes less support hassle. > It may be a redundant feature, but "configure/ make/ > make install" is definately not a replacement for > "ease of use." ;) Then as other have said wineinstall should just contain ./configure && make && su -c 'make install' Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

profiling GTA4. question about polling
by Brian Gunlogson 17 Nov '04

17 Nov '04

GTA4 (Grand Theft Auto: Vice City) runs on Wine with no additional tinkering! Albeit horribly slow. A profile of GTA shows that only one D3D function (drawStridedSlow) needs major optimization. According to the oprofile results, polling seems to be the major bottleneck. (the top of a flat profile generated with oprofile) samples % image name app name symbol name 2177620 14.0147 d3d8.dll.so wine-preloader drawStridedSlow 1681661 10.8228 vmlinux vmlinux do_pollfd 1025198 6.5980 vmlinux vmlinux pipe_poll 515461 3.3174 vmlinux vmlinux add_wait_queue 423342 2.7245 vmlinux vmlinux poll_freewait 423185 2.7235 vmlinux vmlinux __pollwait 354490 2.2814 vmlinux vmlinux fput 285473 1.8372 vmlinux vmlinux sys_poll I'd like to optimize this. Any hints? Brian G __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

1 0

wineprefixcreate hang
by Olive Esseret 17 Nov '04

17 Nov '04

I do not know if this question is appropriate here; so please excuse me if it is not (I have not had any answer elsewhere) On Mdk10.1 the following command (which is called by wineprefixcreate and so also by wineinstall) never terminate. wine rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf Although this happens most of the time, it does not appears every time and did not appeard on Mdk10.0. If it is not possible to make it works, anyone has an idea on how to do the things by hands? Olive

2 3

Supported Apps
by Tom 17 Nov '04

17 Nov '04

Hello All, Would anyone reject to the idea of changing "Tucows top" to "License" and listing the licence on the supported page? I was looking over this page and the Tucows rankings have changed, and some of the apps that we have listed are no longer in the top 100 ranking at Tucows. Tom

1 0

incomplete relay when accessed from winedbg
by Bill Medland 17 Nov '04

17 Nov '04

Guys Any chance of help on this? I am trying to figure out why some numbers are misformatted through Crystal Reports ToText function. (e.g. 6..0 instead of 599.95) I tried to turn +relay on from within winedbg so that I could see just what functions got called. All that relay gave me was "window proc", "hook proc" and wineps calls; no ntdll or anything else. Any idea why it isn't giving me everything? (wine 20040914) -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

access PE headers in winelib shared library
by Jia L Wu 17 Nov '04

17 Nov '04

Hi, Can somebody provide some example or information on how to access PE headers(e.g. PIMAGE_DOS_HEADER, PIMAGE_NT_HEADER) wrapped in winelib shared library(e.g. winelib dll)? Thanks a lot! Wu

3 2

appdb linux links
by James Hawkins 17 Nov '04

17 Nov '04

One of my conceptions of wine is as a stepping stone for users switching over to linux from windows that still only feel comfortable with windows apps or those that don't know what linux apps are available. What do you think about adding a 'Similar Linux Application' link or section to each windows app where applicable that would point them in the direction of the linux equivalent of the windows app and thus help with the transition process? They might not necessarily use the app, but at least they'll be more aware. What are some ideas about this? -- James Hawkins

4 7

wineprefixcreate (and so wineinstall) hang
by Olive Esseret 17 Nov '04

17 Nov '04

I do not know if this question is appropriate here; so please excuse me if it is not (I have not had any answer elsewhere) On Mdk10.1 and with wine-20041019 the following command (which is called by wineprefixcreate and so also by wineinstall) never terminate. wine rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf Although this happens most of the time, it does not appears every time and did not appeard on Mdk10.0 (although there does not seems to be essential differences between the two distributions) If it is not possible to make it works, anyone has an idea on how to do the things by hands? If you need more informations about my system configuration, please let me know (I have no idea what is appropriate...) Olive P.S. Please excuse if this message apperas twice; I had posted it two hours ago and it has still not appeared. __________________________________ Do you Yahoo!? The all-new My Yahoo! - Get yours free! http://my.yahoo.com

1 0

Winetest questions
by Dan Kegel 17 Nov '04

17 Nov '04

1. Why are all the archived posts to wine-test-results empty? See http://www.winehq.org/hypermail/wine-tests-results/2004/11 Every message body is empty! What's up with that? 2. The URL http://test.winehq.org/data/ appears to contain digests of all winetest results received by the server, but this information is not documented anywhere I could find at www.winehq.org. Seems like a top level page is in order. 3. winetest.exe currently assumes you're running under Windows. See main.c line 577: (putenv ("WINETEST_PLATFORM=windows") || Wouldn't it be useful to allow Linux results to be computed and reported via winetest, too? Presumably it could detect that it's running on Linux somehow. (perhaps by running uname -a...) - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 5

Install OCX over wine
by Francisco Nauber Bernardo Gois 17 Nov '04

17 Nov '04

I need install ocx file using wine.How i can do thist? Francisco Nauber Bernardo Gois Unidade de Relacionamento com Clientes Administração Financeira (SUNAF) Serviço Federal de Processamento de Dados (SERPRO) Fone: (85) 88443794

2 1

Could someone look at this simple code and explain why it doesnt work?
by luis lenders 16 Nov '04

16 Nov '04

Hi, i found this very simple app which just pops up a window: #include <windows.h> LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) { switch (msg) { case WM_DESTROY: PostQuitMessage(0); return 0; default: return DefWindowProc(hwnd, msg, wparam, lparam); } } int WINAPI WinMain(HINSTANCE instance, HINSTANCE prev, LPSTR cmdLine, int cmdShow) { WNDCLASSEX class; MSG msg; HWND window; /* this stuff is just boilerplate */ memset(&class, 0, sizeof(WNDCLASSEX)); class.cbSize = sizeof(WNDCLASSEX); class.hInstance = instance; class.lpszClassName = "MainWnd"; class.lpfnWndProc = WndProc; class.hbrBackground = (HBRUSH) COLOR_WINDOW + 1; if (!RegisterClassEx(&class)) { MessageBox(NULL, "Could not register window class", "", MB_OK | MB_ICONERROR); return 1; } window = CreateWindowEx(0, "MainWnd", "Main Window", WS_OVERLAPPEDWINDOW & ~WS_MAXIMIZEBOX, CW_USEDEFAULT, CW_USEDEFAULT, 200, 150, NULL, NULL, instance, NULL); ShowWindow(window, cmdShow); /* Every thread that creates a window must pump the message loop */ while (GetMessage(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessage(&msg); } return 0; } Now i tried to implement this in a dll (avicap32.dll) in capCreatecapturewindow like this: /*********************************************************************** * capCreateCaptureWindowW (AVICAP32.@) */ HWND VFWAPI capCreateCaptureWindowW(LPCWSTR lpszWindowName, DWORD dwStyle, INT x, INT y, INT nWidth, INT nHeight, HWND hWnd, INT nID) { HWND ret; HINSTANCE dummy; LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) { switch (msg) { case WM_DESTROY: PostQuitMessage(0); return 0; default: return DefWindowProcW(hwnd, msg, wparam, lparam); } } int WINAPI Try(HINSTANCE instance, HINSTANCE prev, LPSTR cmdLine, int cmdShow) { WNDCLASSEXW class; MSG msg; HWND window; /* this stuff is just boilerplate */ memset(&class, 0, sizeof(WNDCLASSEXW)); class.cbSize = sizeof(WNDCLASSEXW); class.hInstance = instance; dummy=instance; class.lpszClassName = "MainWnd"; class.lpfnWndProc = WndProc; class.hbrBackground = (HBRUSH) COLOR_WINDOW + 1; if (!RegisterClassExW(&class)) { MessageBoxW(NULL, "Could not register window class", "", MB_OK | MB_ICONERROR); return 1; } window = CreateWindowExW(0, "MainWnd", "Main Window", WS_OVERLAPPEDWINDOW & ~WS_MAXIMIZEBOX, CW_USEDEFAULT, CW_USEDEFAULT, 200, 150, NULL, NULL, instance, NULL); ret=window; ShowWindow(window, cmdShow); /* Every thread that creates a window must pump the message loop */ while (GetMessageW(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessageW(&msg);} return 0; } Try(dummy,NULL,NULL,0); return ret; } Now when capcreatecapturewindow is called no window shows up at all. What did i do wrong? Greetings Robbert : ___________________________________________________________ Moving house? Beach bar in Thailand? New Wardrobe? Win £10k with Yahoo! Mail to make your dream a reality. Get Yahoo! Mail www.yahoo.co.uk/10k

2 1

GradientFill revisited
by Arjen Nienhuis 16 Nov '04

16 Nov '04

I created a patch! Hooray! http://www.nienhuisbeheer.nl/~arjen/gradientfill.patch Does anyone have a test for this function. What is the best way to create a program to test these things? I've never written a windows program from scratch. Does anyone have a simple app, where I can insert some calls to GradientFill?

1 0

Re: Kernel 2.6.9 - Issue Found
by Dan Kegel 16 Nov '04

16 Nov '04

I couldn't find the patch at either of the two links Jesse posted, but I did see something similar here: http://marc.theaimsgroup.com/?l=bk-commits-head&m=110048429304053&w=2 -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 3

Re: Kernel 2.6.9 - Issue Found
by Paul Rupe 16 Nov '04

16 Nov '04

> It doesn't seem to fix the copy protection problem. So I'm wondering a few > things. Does wine need to be patched? This new patch seems to be related to > a chunk of code added in patch #2 mentioned in the original posting. I've > tried 2.6.10-rc2 with patch #1 reversed and patch 1+3 reversed. No difference > this time. No luck with Remedy either. I tried reversing all three patches and also tried 2.6.10-rc2. Same crash as before. -- Paul Rupe <prupe(a)myrealbox.com>

2 1

Developer Cheatsheet formatting...
by Dan Kegel 15 Nov '04

15 Nov '04

http://www.winehq.com/site/developer-cheatsheet is 1.5 times as wide as my screen in Firefox and Mozilla. Seems like it needs a bit of adjustment... -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

4 5

WINELIB Use References
by Dagan Shai 15 Nov '04

15 Nov '04

Hi, I'm new to WINE / WINELIB. We're considering using WINELIB in order to port a commercial telephony application (service node). I would appreciate some information from someone with experience porting commercial server-side applications with WINELIB regarding the problems that arise, resources used and recommendations. Anyone that can provide such information please contact me privately. Thanks, Shai Dagan

1 0

rsaenh.dll
by Michael Jung 15 Nov '04

15 Nov '04

Hi, the attached patch incorporates code from the public domain library LibTomCrypt (http://libtomcrypt.org) into rsaenh.dll. This allows us to get rid of the compile and run-time dependencies on OpenSSL, and - as far as I understand it - might solve some license problems for ReactOS (http://www.reactos.com:8080/pipermail/ros-general/2004-February/000706.html). It would be nice to get some comments on what remains to be done before I submit the patch to wine-patches. I renamed the implossl.[ch] (OpenSSL glue logic) files to the more neutral implglue.[ch]. How to I get diff to produce a patch that reflects this change? Greetings, Michael

1 0

How to port c++ program to linux using winelib
by Jia L Wu 15 Nov '04

15 Nov '04

Hi, I have a win32 program written in C++. I am trying to port it to linux using winelib. The software contanis one exe file and several dll files. I would like to keep this structure when moving them to linux. That is, I still would like to generate several corresponding shared libraries (instead of statically linking all files together) in llinux and they will be loaded at the runtime. However using winelib tools(winemaker, configure, make) for shared library generation, I get unresolved symbols error. It seems that I have to write a spec file for each dll to import(and export) functions provide by other dlls. However, since they all written in c++ and what need to be imported can either be class or class method, and parameters can be class either. SO I don't know how to handle this in spec file. Beside each dll file exports many functions or classes. It would be tedious to write a lengthy spec file manually. My question is that if it is possible that linking is not invoked during shared library generation under wine (but during the runtime)? How should I do it? Thanks. Wu

4 8

"Software Engineering with Wine" tutorial
by Dan Kegel 15 Nov '04

15 Nov '04

I'm putting together a mini-lab course on "Software Engineering with Wine". So far, it only shows how to build wine and run the conformance test, and troubleshoot common problems (in particular, the ones that caused hundreds of test failures when I ran them a couple weeks ago). It's at http://kegel.com/wine/sweng/ Comments welcome. (In particular, are there any other test suite gotchas I should tell the students about?) - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: Kernel 2.6.9
by Jerry Jenkins 15 Nov '04

15 Nov '04

Paul Rupe wrote: > On Friday November 12 2004 11:48 am, Michael Stefaniuc wrote: > > >>Btw. does wine crash only with Remedy or does winemine crash too? > > > Most apps (winemine included) are ok. When I get home I'll try to find a > downloadable app that reproduces the problem consistently. > > Usually wine just hangs until I kill -9 everything, but this time I managed > to get a stack trace. It looks like a recursive loop: > =>1 0x7759b155 cxx_frame_handler+0x401 in msvcrt (0x77927f90) > 2 0x7759b5c3 in msvcrt (+0xb5c3) (0x77927fb4) > 3 0x77ee7be1 __wine_call_from_32_regs+0xb5 in ntdll (0x7792831c) > 4 0x7759ac79 __CxxFrameHandler+0x5 in msvcrt (0x77928358) > 5 0x77ec63b8 EXC_RtlRaiseException+0x18c in ntdll (0x779283ec) > 6 0x77edf32b raise_segv_exception+0x2f in ntdll (0x77928408) > 7 0x77ee7c50 __wine_call_from_32_restore_regs+0x0 in ntdll (0x779287d4) > ... > 90 0x77edf32b raise_segv_exception+0x2f in ntdll (0x7792f7d8) > Frames 2-7 repeat all the way down to 90. This is after a 'make clean' and > a full rebuild of Wine, btw. > > Does increasing stack size help? For example: Index: dlls/kernel/process.c =================================================================== RCS file: /var/cvs/wine/dlls/kernel/process.c,v retrieving revision 1.80 diff -u -r1.80 process.c --- dlls/kernel/process.c 30 Oct 2004 02:11:33 -0000 1.80 +++ dlls/kernel/process.c 15 Nov 2004 11:36:47 -0000 @@ -1183,7 +1183,7 @@ set_library_wargv( __wine_main_argv ); if (!build_command_line( __wine_main_wargv )) goto error; - stack_size = RtlImageNtHeader(peb->ImageBaseAddress)->OptionalHeader.SizeOfStackReserve; + stack_size = 10 * 1024 * 1024; /* allocate main thread stack */ if (!THREAD_InitStack( NtCurrentTeb(), stack_size )) goto error; __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Last-chance deactivation of MDI Child before destruction
by Dmitry Timoshkov 15 Nov '04

15 Nov '04

"Zach Gorman" <zach(a)archetypeauction.com> wrote: > Changelog: > If, during destruction of an MDI child frame, the application > re-activates the window that is about to be destroyed, de-activate > it one last time. > > Background: > This resolves an obscure problem caused by a difference in Windows > and Wine behavior. I have an MDI MFC app in which one of the MDI > child frames forces itself to stay at the back of the Z-order by > responding to MDI Activate messages, and re-activating the old > window (yes I know this is nasty). When Wine tries to switch the > active MDI child during the active child's destruction, this causes > the about-to-be-destroyed window to become active again. Windows > will issue one last WM_MDIACTIVATE to deactivate the window that > will be destroyed in this case, but Wine won't. This patch corrects > that difference in behavior. What happens if that additional WM_MDIACTIVATE won't deactivate an MDI child either, or an app doesn't allow deactivation for some reason? Anyway, please add another MDI message test case showing what Windows does in that case because your change is not obvious at all. -- Dmitry.

2 1

Kernel 2.6.9 - Issue Found
by Jesse Allen 15 Nov '04

15 Nov '04

Hi, For the past two weeks I've been tracking an issue that I found with kernels greater than 2.6.8 / 2.6.8.1 and wine. Starting with kernel 2.6.9-rc1, Warcraft III copy protection would not work -- ie please insert disc. I found changes to the cdrom driver in rc1. Reversing them did not work. For a while I was lost to what could have changed. Then I had an idea: search for changes that could affect the way processes run. That led me to reverse changes related to ptrace, and I found a series of patches that break Warcraft III copy protection code. Patch 1: ptrace single-stepping fix Included in 2.6.9-rc1 By Davide Libenzi? http://linux.bkbits.net:8080/linux-2.6/cset@1.1803.1803.144.55 This change includes a note that it could break debuggers. Reversing this change would allow War3 to work in rc1, but kernels greater than rc1 would still not work. Patch 2: make single-step into signal delivery stop in handler Included in 2.6.9-rc2 By Roland McGrath http://linux.bkbits.net:8080/linux-2.6/cset@1.1832.59.196 The next patch may depend on patch #2 because it is a bug-fix based on 2. Patch 3: Fix PTRACE_CONT after single-step into signal delivery Also 2.6.9-rc2 By Roland McGrath http://linux.bkbits.net:8080/linux-2.6/cset@1.1847 Reversing patches 1, 2, and 3 in kernels 2.6.9-rc2 and greater (through 2.6.10-rc1) will allow War3 to work. I tried 1 & 3 without 2, but it failed leading me to believe that 1 & 2 are required. I didn't try 1 & 2 alone because I think reversing 2 would require 3 reversed. All the patch changes seem to be on ptrace single-stepping. However, there is at least one ptrace single-stepping patch that seems to make no difference at all: http://linux.bkbits.net:8080/linux-2.6/cset@1.1803.144.70 There are other single-stepping patches for different non-i386 architectures but I have no idea on these because I don't run the others. They are meaningless for wine anyways. Now that I've identified a problem, I'm curious where else it's cropping up. Paul Rupe, could you try reversing these patches to see if this fixes your crashing problem? And how about those people having trouble with debugging? Then I guess the next step is to find out if this is a wine bug or not. If it's not, then it may be a kernel bug and we should report it to the kernel devs. Jesse

4 5

"Crystallography programs under Wine"
by Dan Kegel 15 Nov '04

15 Nov '04

I just ran into http://www.ccp14.ac.uk/solution/wine/ which lists about ten free Windows apps used for crystalography, and how to run them under Wine. I guess these deserve an appdb entry; they don't seem to have one yet. That page describes workarounds needed to run with Wine as of about three years ago. Things may have progressed since then. For instance, the "you must rename files to have lower case" workaround no longer seems neccessary for the INDX program. I wrote the maintainer about that, haven't heard back from him yet. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: taskmodal messagebox implementation, take 3
by Ivan Leo Puoti 14 Nov '04

14 Nov '04

> No problem. I'll give a lengthy reply in the hope it can help other folks > dealing with this sort of thing too. Well, your code works, and I've made it into a patch. I've also removed what I beleive is a useless if check from MSGBOX_OnInit(). Due to my lame webmail client you code arrived with no indentation, so in the future please attach any code you send to me. If you think the attached patch is OK I'll forward it to wine-patches. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: [D3D] Some surfaces related fixes
by Christian Costa 14 Nov '04

14 Nov '04

Mike Hearn wrote: >On Sun, 14 Nov 2004 13:40:15 +0000, Christian Costa wrote: > > >>+ if ((pDDSD->dwFlags & DDSD_LPSURFACE) && (pDDSD->lpSurface == NULL)) { >>+ /* Frank Herbert's Dune specifies a null pointer for the surface, ignore the LPSURFACE field */ >>+ FIXME("Null surface pointer specified, ignore it!\n"); >>+ pDDSD->dwFlags &= ~DDSD_LPSURFACE; >>+ } >>+ >> >> > >Apps passing in bogus data should normally be a trace or warn at most, >unles there is actually something to fix here it doesn't make sense to use >a fixme as it'll inevitably get users asking about it .... > >thanks -mike > > > > > Your're right, Mike. :-) I will resend a patch for that. Thanks. Christian

1 0

Re: taskmodal messagebox implementation, take 3
by Juan Lang 14 Nov '04

14 Nov '04

Hi Ivan. --- Ivan Leo Puoti <puoti(a)inwind.it> wrote: > Please consider I'm no programming wiz and I'm learning as I go along. No problem. I'll give a lengthy reply in the hope it can help other folks dealing with this sort of thing too. > Now, I don't see how else I could get MSGBOX_EnumProc() to remember the > values > of those that now are static variables, apart from using the heap for > everything, that seems a bit inefficent as we know how much data we want > to > store, or global variables, do you think I should use global ones > instead? > If not suggestions are welcome. Globals are also not thread-safe. Generally for thread safety, I'd suggest the following: declare a structure that has all the data you want to modify in MSGBOX_EnumProc, something like: struct MsgBoxEnumProcParams { int pass; int counter1; int counter2; int heapcheck; HWND *handles; }; In MessageBoxIndirectW, create one of these and pass its address as the LPARAM value to EnumThreadWindows(). However, this ignores style issues. I have problems with names like "counter1" and "counter2"; they don't tell me what they mean. Also, I don't like the magic values 0, 1, 2, 3, 4 for the LPARAM value; at the least these should be symbolic constants. Pass 3 doesn't modify the parameters at all, so it really should get its own callback function. It looks like heapcheck's purpose is to see whether handles has in fact been allocated. You could instead make sure to set handles to NULL when it isn't allocated. Also, there's the possibility of a memory leak in pass 4. I'd suggest the caller should be responsible for memory allocation. With these suggestions, I've come up with the following changes. I haven't checked whether this code works (or even compiles), it's just my attempt at rewriting what you're trying to do: struct ThreadWindows { UINT numHandles; UINT handlesLen; HWND *handles; }; BOOL CALLBACK MSGBOX_CountDisabledThreadWindows(HWND hwnd, LPARAM lParam) { if (!lParam) return FALSE; if (!IsWindowEnabled(hwnd)) *(UINT *)lParam++; return TRUE; } BOOL CALLBACK MSGBOX_EnumDisabledThreadWindows(HWND hwnd, LPARAM lParam) { if (!lParam) return FALSE; if (!IsWindowEnabled(hwnd)) { struct ThreadWindows *threadWindows = (struct ThreadWindows *)lParam; if (threadWindows->numHandles < threadWindows->handlesLen) threadWindows->handles[threadWindows->numHandles++] = hwnd; } return TRUE; } INT WINAPI MessageBoxIndirectW( LPMSGBOXPARAMSW msgbox ) { LPVOID tmplate; HRSRC hRes; int ret; UINT i; struct ThreadWindows threadWindows = { 0, 0, 0 }; static const WCHAR msg_box_res_nameW[] = { 'M','S','G','B','O','X',0 }; if (!(hRes = FindResourceExW(user32_module, (LPWSTR)RT_DIALOG, msg_box_res_nameW, msgbox->dwLanguageId))) return 0; if (!(tmplate = (LPVOID)LoadResource(user32_module, hRes))) return 0; /*handle task modal message boxes*/ if ((msgbox->dwStyle & MB_TASKMODAL) && (msgbox->hwndOwner==NULL)) { EnumThreadWindows(GetCurrentThreadId(), MSGBOX_CountDisabledThreadWindows, (LPARAM)&threadWindows.numHandles); if (threadWindows.numHandles) { threadWindows.handles = (HWND *)HeapAlloc(GetProcessHeap(), 0, threadWindows.numHandles * sizeof(HWND)); if (threadWindows.handles) threadWindows.handlesLen = threadWindows.numHandles; threadWindows.numHandles = 0; } EnumThreadWindows(GetCurrentThreadId(), MSGBOX_EnumDisabledThreadWindows, (LPARAM)&threadWindows); for (i = 0; i < threadWindows.numHandles; i++) DIALOG_DisableOwner(threadWindows.handles[i]); } ret=DialogBoxIndirectParamW(msgbox->hInstance, tmplate, msgbox->hwndOwner, MSGBOX_DlgProc, (LPARAM)msgbox); if ((msgbox->dwStyle & MB_TASKMODAL) && (msgbox->hwndOwner==NULL)) { for (i = 0; i < threadWindows.numHandles; i++) DIALOG_EnableOwner(threadWindows.handles[i]); if (threadWindows.handles) HeapFree(GetProcessHeap(), 0, threadWindows.handles); } return ret; } The changes I've made: I've renamed counter1 and counter2 to numHandles and handlesLen. handlesLen is the allocated number of handles, while numHandles is the number of handles actually stored. (Your code already dealt with the possibility of their being different: well done!) I've also used handles as its own guard; if it's NULL, it's not allocated. Otherwise it is. Like I suggested, I pass a pointer as an LPARAM to the two EnumThreadWindows callback functions. It seems two calls to EnumThreadWindows were unnecessary, since we already knew the window handles, so I just iterate over the values in handles rather than calling EnumThreadWindows again. If I'm incorrect in my understanding, of course change it. And, the caller is always responsible for memory allocation and freeing. I think this is safer than having the callback function do it. > >Any reason you aren't using HeapAlloc instead? > As this heap is only used by MSGBOX_EnumProc(), is there any reason why > I should > use HeapAlloc? It's sometimes easier to debug memory problems with the Windows heaps than with the libc ones. --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

winzip 9 doesn't run under wine :-(
by Dan Kegel 14 Nov '04

14 Nov '04

While putting together a tutorial on how to contribute test cases to Wine (http://kegel.com/wine/sweng/), I noticed that the current version 9 of WinZip doesn't install under vanilla Wine; it aborts with the message WinZip was unable to locate a recent version of the Windows HTML help viewer, which is required to display WinZip help. ... Seems like a bit of a showstopper. What's the plan for addressing this? Is it a 0.9 feature? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

3 8

ListView DrawText Flags
by Zach Gorman 14 Nov '04

14 Nov '04

Dimitrie - You have a patch back in 2002 that cleans up the listview DrawText() code in comctl32. When calling DrawText from a single-line edit control, you don't pass DT_NOPREFIX. Is this intentional, or just an oversight? My testing on Windows shows that & characters do not get converted to _ even in the single-line edit control case (indicating that DT_NOPREFIX should be passed). Thanks, Zach

2 1

Missing file names in WINEDBG
by lats 14 Nov '04

14 Nov '04

In the last week WINEDBG has stopped outputting the file/path and linenumber of entries in the backtrace. Does anyone know what happened? Jeff

3 3

Re: taskmodal messagebox implementation, take 3
by Juan Lang 14 Nov '04

14 Nov '04

Ivan, a couple comments on this. You wrote: +BOOL CALLBACK MSGBOX_EnumProc(HWND hwnd, LPARAM lParam) +{ + static int counter1, counter2, heapcheck=0; + static HWND *handles; static variables aren't thread safe. Two threads attempting to do task modal dialogs (yes, this is probably strange) could result in weird failures. + handles=(HWND*)malloc(counter1*sizeof(HWND)); Any reason you aren't using HeapAlloc instead? --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

dlls/commdlg/fontdlg.c regression
by Gerald Pfeifer 13 Nov '04

13 Nov '04

The following change to dlls/commdlg/fontdlg.c revision 1.70 date: 2004/08/14 00:42:35; author: julliard; state: Exp; lines: +2 -5 Jacek Caban <jack(a)itma.pwr.wroc.pl> Fix a bug in passing parameters to CFn_WMInitDialog and CFn_WMCommand in FormatCharDlgProcW. causes the following warning with GCC 3.3.2 on FreeBSD 4.10: fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from incompatible pointer type Would you mind fixing this? Thanks, Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 3

Using a DIB to reduce number of calls to X
by Arjen Nienhuis 13 Nov '04

13 Nov '04

GradientFill can be implemented by drawing to a DIB, and then blting that DIB to the screen. This will reduce the number of calls to X from O(n) to O(1). 1. Is that a good idea? Any caveats? 2. Can that method be used elsewhere? I'll try to implement it right away. P.S. We do implement the alpha part of GradientFill the same as Windows. The comments might sugest otherwise.

2 1

For the appdb hackers
by Ivan Leo Puoti 13 Nov '04

13 Nov '04

It would be great if I could delete/approve apps and go to the next one without having to go back to adminAppQueue.php Thanks for the work you're doing, it was badly needed. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Kernel 2.6.9
by Paul Rupe 13 Nov '04

13 Nov '04

Has anyone tried Wine with Linux kernel 2.6.9? I'm getting crashes with this version that don't happen when I reboot back to 2.6.8.1. I haven't had much luck debugging it so far, but each time, ps shows a <defunct> wine-preloader process and wineserver still running. -- Paul Rupe <prupe(a)myrealbox.com>

7 10

Re: ws2tcpip.h: Define socklen_t
by felix.nawothnig＠t-online.de 13 Nov '04

13 Nov '04

On 11/13/2004 02:22:18 AM, I wrote: > We don't have socklen_t defined anywhere and that's the place where > it's defined in the official headers so... WASTE compiles fine now... > (I'm sure there is a reason why it isn't defined but I can't see it - > so tell me why this will be rejected... err... if it will be... :-) Ooops... WINE doesn't build anymore, I guess that's a good reason. :) Sorry... Anyway, what's the correct way to get socklen_t then? Would it make sense to do... #ifndef __socklen_t_defined typedef int socklen_t; # define __socklen_t_defined #endif ...or prefix it with WS() maybe? Or should I just include unistd.h in winelib apps? (Not sure if that's possible even since I'm using MSVCRT...) -flx

1 0

enhmfdrv: ExtSelectClipRgn
by Jon Griffiths 13 Nov '04

13 Nov '04

Hi, My app gives me a FIXME from dlls/gdi/enhmetafile.c at line 1144 complaining that ExtSelectClipRgn is not implemented (and then proceeds to draw rather corrupted looking pictures). Looking at the code there is an implementation, but its been #ifdef'd out. removing the #if 0 doesn't produce any noticable change in my app. Does any one have any idea why this was removed, or what is needed to make it work? Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Checking up header files ( take 2 : mmsystem.h )
by Eric Pouech 13 Nov '04

13 Nov '04

Rémi Assailly a écrit : > Changelog: > * set MAXERRORLENGTH to 256 > * set MMSYSERR_LASTERROR to (MMSYSERR_BASE + 20) > * set MIDIERR_LASTERROR to (MIDIERR_BASE + 7) > * add some structure tags I think it's worthless bumping the LASTERROR values if you don't add the missing error values in the .h file A+

1 0

Re: Toolbar: Cleanup Patch
by Dimitrie O. Paun 13 Nov '04

13 Nov '04

On Mon, Nov 08, 2004 at 11:27:44AM -0600, Robert Shearman wrote: > Changelog: > - bNtfUnicode is a dup' of bUnicode so remove it and fix the few places > where it was used. bUnicode is a bad name for this flag, bNtfUnicode would be better, as bUnicode is sometimes use to denote how the text is stored in the control, which is different from how notifications should be sent. -- Dimi.

2 2

Re: Kernel 2.6.9
by Ivan Leo Puoti 13 Nov '04

13 Nov '04

>What could possibly be different between our systems that would cause >this problem? Anything but wine and the kernel, could you try this binary package and see if it works? Like this you can find out if it's a runtime or compile time problem. http://prdownloads.sourceforge.net/wine/wine-20041019-mdk.i586.rpm?download Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

3 3

Re: just a little thing in dlls/winmm/lolvldrv.c
by Bill Medland 12 Nov '04

12 Nov '04

On November 12, 2004 12:17 pm, Rémi Assailly wrote: > Changelog: > * just replace all (sizeof(MM_MLDrvs) / sizeof(MM_MLDrvs[0]) by > MAX_MM_MLDRVS to be more readable. ( I think it is ) I think it isn't. (sizeof(a)/sizeof(a[0]) or (sizeof(a)/sizeof(*a)) is a standard statement that means "the number of elements in a". Some people make a macro such as COUNTOF(a) to make it more readable but the expanded version is quite standard. The altered version is less readable because one then has to go back to the definition of MAX_MM_MLDRVS and its uses to see that indeed it is (or at least is supposed to be) the number of elements in the array that the statements are protecting. -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

1 0

Re: Kernel 2.6.9
by Ivan Leo Puoti 12 Nov '04

12 Nov '04

> I forgot to mention that I'm using latest wine CVS. So am I and wine works fine, on mdk 10.1 kernel 2.6.8.1-12mdk. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: Dbghelp: enhance PDB support
by Dimitrie O. Paun 12 Nov '04

12 Nov '04

On Thu, Nov 11, 2004 at 09:25:46PM +0100, Eric Pouech wrote: > This (huge) patch does: > - apart from restructuring the code (COFF handling goes to new coff.c > file, Codeview and PDB defines and types to new mscvpdb.h file) ^^^^^^^^^ Shouldn't this be named msvcpdb.h? -- Dimi.

3 2

Tables For Standard Caption Buttons' Metrics?
by William Poetra Yoga H 12 Nov '04

12 Nov '04

In windows/nonclient.c, the captions on caption buttons are calculated (according to the button size, which is determined by some system metrics). This is due to the fact that we don't have a replacement for the Marlett font used in Windows. But simple formulae can't reproduce the captions correctly. I've taken some screenshots of the caption buttons in Windows XP (with the classic theme, so I think the results can be reproduced in earlier versions). I think we can reproduce Windows' behavior with a table. For every value of SM_CYCAPTION, we have one table entry. This way, we can save space (the table is a lot smaller than a table of bitmaps) and still reproduce correct behavior. Anyone has comments on this? __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

2 3

Enabling gcov patch not accepted
by Aaron Arvey 12 Nov '04

12 Nov '04

Hi, I recently sent in a patch concerning enabling gcov in wine (http://www.winehq.org/hypermail/wine-patches/2004/11/0136.html) and it doesn't seem to have been incorporated in the main cvs branch :(. I have never contributed to wine before so I'm not sure how to get feedback on my patch in order to improve it so that it is accepted. If either Alexandre or anyone else believes they know why my patch wasn't accepted, please let me know. I personally have found gcov to be very helpful and I think other developers may find that to be true too. If you would like to know more about gcov, please read the documentation included in my patch (url above). Thank you, Aaron

3 2

shreg tests on xp vs 95/98
by James Hawkins 12 Nov '04

12 Nov '04

I've been working on figuring out the behaviour of SHQueryValueEx using XP for testing. I know that on XP SHQueryValueEx just calls SHRegGetValue, so any results from testing SHQueryValueEx match those documented about SHRegGetValue and even those not documented. What I'm wondering is if SHQueryValueEx behaves the same on other platforms ie 95/98/NT etc. If you'd like to test it, run the attached test on your platform and report the results back. Thankyou for taking the time to help figure this one out. BTW you can ignore this error for now (I'll look into it after this): shreg.c:270: Test failed: didn't open copy -- James Hawkins

1 0

Cxbx
by Dimitrie O. Paun 12 Nov '04

12 Nov '04

Hi Folks, Willie Sippel suggested I port the Bxbx Xbox emulator to Winelib. And I did, patch attached. It seems like we need a multimon.h, any takers? More on the emulator: Home: http://www.caustik.com/cxbx/ http://sourceforge.net/projects/cxbx/ -- Dimi.

1 0

ODBC - MSSQL
by Pablo Szuster 11 Nov '04

11 Nov '04

Hi, i´m trying to access a MSSQL server (in a windows machine in the network) from a Visual Basic Application running under wine, using an ODBC driver. Since there aren´t any MSSQL drivers for linux i decided to use de native ones, so i installed mdac_typ.exe . Then i configured the DSN using odbcad32.exe but when i tested the connection (configured using tcp/ip) an error message appeared ("[Microsoft][ODBC SQL Server Driver][TCP/IP Sockets] General network error. Check your network documentation"). Do i have to install some network drivers for wine?? Has anyone been able to connect to a MSSQL server remotely using odbc under wine?? __________________________________________________ Todavía no tenés tu Ciudad Internet Mail? Obtenelo ahora! - http://webmail.ciudad.com.ar Descargá Gratis el nuevo Internet Explorer 6.0, el mejor software para actualizar tu PC. http://www.ciudad.com.ar/ar/servicios/ie/

2 1

How difficult would it be to make the equivalent of Windows Terminal Server with Wine?
by Andrew Quigley 11 Nov '04

11 Nov '04

What I would like to be able to deploy would be a system which runs multiple Win32 compatible desktops and multiple logins on a server, with the clients accessing the desktops via RDP or ICA protocols. How many of the pieces required to accomplish that already exist, and what pieces have yet to be built? A quick search on freshmeat shows me a few different rdp clients, so it looks like the protocol spec is known. What would be involved in creating a RDP server that shows up as a video driver as far as the win32 programs are concerned?

7 9

wine notes & /etc/resolv.conf
by Grant Williamson 11 Nov '04

11 Nov '04

Hi, is there a patch anywhere, which will allow wine to reread the /etc/resolv.conf file. i.e. application lotus notes a) start notes whilst connected to home network. /etc/resolv.conf gets populated by home dhcp server b) start vpn connection to work /etc/resolv.conf gets populated with extra name servers c) try and connect to work notes, server fails, as it cannot resolve named address If you start notes after the vpn connection is started, then /etc/resolv if correctly populated and the problem does not occur. Same issue happens when u suspend your machine and start in a different location. Does anyone have a patch or know how to get wine to reread /etc/resolv.conf periodically? Grant.

4 3

Re: Fix For Window Caption
by William Poetra Yoga H 11 Nov '04

11 Nov '04

--- William Poetra Yoga H <williampoetra(a)yahoo.com> wrote: > This fixes the bounding rectangle of the window caption. > > William > > Same as the one for the caption buttons, what needs to be improved for this patch? I meant to make the caption (text) bounding box smaller a bit so the text doesn't overflow over the caption buttons. And, this patch is somewhat related to the caption buttons patch, though not so closely, so I sent it as a separate patch. __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Fix For Caption Buttons
by William Poetra Yoga H 11 Nov '04

11 Nov '04

--- William Poetra Yoga H <williampoetra(a)yahoo.com> wrote: > This patch fixes the size and position of caption buttons (they were too > big). > > William > This patch wasn't committed. Anyone would like to point out to me something wrong with the patch? __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 0

Re: Fix For Menu Bar (resend)
by Alexandre Julliard 11 Nov '04

11 Nov '04

William Poetra Yoga H <williampoetra(a)yahoo.com> writes: > Index: dlls/user/menu.c > =================================================================== > RCS file: /home/wine/wine/dlls/user/menu.c,v > retrieving revision 1.8 > diff -u -r1.8 menu.c > --- dlls/user/menu.c 8 Nov 2004 22:12:42 -0000 1.8 > +++ dlls/user/menu.c 9 Nov 2004 14:26:09 -0000 > @@ -1441,8 +1441,6 @@ > if (lppop->Height == 0) > MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd); > > - lprect->bottom = lprect->top + lppop->Height; > - This doesn't look right at all, you cannot simply ignore the computed size of the menu bar, this is going to break owner drawn menus. -- Alexandre Julliard julliard(a)winehq.org

4 4

re: Latent memory corruption bug in widl, with workaround
by Dan Kegel 11 Nov '04

11 Nov '04

Here's the exact workaround, in case anyone runs into that crash again. I dare the author of widl to run it under valgrind :-) diff -Naur wine.orig/tools/widl/parser.l wine/tools/widl/parser.l --- wine.orig/tools/widl/parser.l Mon Oct 4 19:14:54 2004 +++ wine/tools/widl/parser.l Wed Nov 10 00:28:37 2004 @@ -123,7 +123,7 @@ yyerror("Malformed '#...' line-directive; missing terminating \""); *cptr = '\0'; line_number = lineno - 1; /* We didn't read the newline */ - free( input_name ); + //free( input_name ); input_name = xstrdup(fname); } \" yy_push_state(QUOTE); cbufidx = 0; -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: Fix For Menu Bar (resend)
by Ivan Leo Puoti 11 Nov '04

11 Nov '04

> I know this sounds a bit unethical (maybe impolite would be a better word), but > for practical reasons I think this is permittable. Or maybe I should > specifically state (at wine-patches) that I "allow anyone else to fix the patch > should it contain errors, and resubmit it"? If you licence the patch for inclusion with wine, you licence it under the LGPL, that does allow this, as it's free software. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Ekush
by Ivan Leo Puoti 11 Nov '04

11 Nov '04

> Ekush (http://www.ekush.com) published some binaries. At time of writing the hoster has taken them down. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: [AppDB] apidb_fullurl() does not act as expected...
by Jeremy Newman 10 Nov '04

10 Nov '04

No this will not work. You need to keep the paths relative. Do not use full URLs as then if you have a development/test server running, it will take you back to the production site. If you look at index.php, there is an include("path.php"), which defines the static BASE. If you always inclide path.php from the cwd, your scripts will get BASE, and you can use that for the relative path. On Tue, 2004-11-09 at 19:33 -0700, Tony Lambregts wrote: > apidb_fullurl() does not give the Full URL go figure.. > > Change log: fix up the notify for add and delete comment so it gives a proper back link > > files changed: addcomment.php > deletecomment.php > include/incl.php > > Index: addcomment.php > =================================================================== > RCS file: /home/wine/appdb/addcomment.php,v > retrieving revision 1.2 > diff -u -r1.2 addcomment.php > --- addcomment.php 9 Nov 2004 22:42:12 -0000 1.2 > +++ addcomment.php 10 Nov 2004 02:15:50 -0000 > @@ -49,7 +49,7 @@ > if($email) > { > $fullAppName = "Application: ".lookupAppName($appId)." Version: ".lookupVersionName($appId, $versionId); > - $ms .= apidb_fullurl("appview.php?appId=$appId&versionId=$versionId")."\n"; > + $ms .= APPDB_ROOT."appview.php?appId=$appId&versionId=$versionId"."\n"; > $ms .= "\n"; > $ms .= ($current->username ? $current->username : "Anonymous")." added comment to ".$fullAppName."\n"; > $ms .= "\n"; > Index: deletecomment.php > =================================================================== > RCS file: /home/wine/appdb/deletecomment.php,v > retrieving revision 1.3 > diff -u -r1.3 deletecomment.php > --- deletecomment.php 9 Nov 2004 22:42:12 -0000 1.3 > +++ deletecomment.php 10 Nov 2004 02:15:50 -0000 > @@ -65,7 +65,7 @@ > if($email) > { > $fullAppName = "Application: ".lookupAppName($appId)." Version: ".lookupVersionName($appId, $versionId); > - $ms .= apidb_fullurl("appview.php?appId=$appId&versionId=$versionId")."\n"; > + $ms .= APPDB_ROOT."appview.php?appId=$appId&versionId=$versionId"."\n"; > $ms .= "\n"; > $ms .= ($current->username ? $current->username : "Anonymous")." deleted comment from ".$fullAppName."\n"; > $ms .= "\n"; > Index: include/incl.php > =================================================================== > RCS file: /home/wine/appdb/include/incl.php,v > retrieving revision 1.3 > diff -u -r1.3 incl.php > --- include/incl.php 9 Nov 2004 22:42:13 -0000 1.3 > +++ include/incl.php 10 Nov 2004 02:15:51 -0000 > @@ -241,6 +241,7 @@ > define("STANDARD_NOTIFY_FOOTER","------- You are receiving this mail because: -------\n". > "You are an maintainer of this app or an appdb administrator\n". > "to change your preverences go to: http://appdb.winehq.org/preferences.php\n"); > +define("APPDB_ROOT", "http://appdb.winehq.org/"); > > > ?> > >

2 1

FW: [dx9-12 next try] SetStreamSource changes
by Ann and Jason Edmeades 10 Nov '04

10 Nov '04

Was there a problem with this one - Its really holding me up with progress, so I need to ensure I resolve any issues asap. Thanks Jason -----Original Message----- From: Ann and Jason Edmeades [mailto:us@the-edmeades.demon.co.uk] Sent: 06 November 2004 21:52 To: 'wine-patches(a)winehq.org' Subject: [dx9-12 next try] SetStreamSource changes This makes the change as per my previous note - Any better? >When I call addref the wined3dvb interface, I addref on the d3dvb >interface, and similarly on release, I release the d3d interface >from release on the wined3dvb? Let me know if there are any problems Changelog - Implement SetStreamSource - Ensure wined3d objects maintain a reference count of at least that of the d3dx version Jason

1 0

[setupx_main.c] SETUPX_CreateStandardLDDs: question about a FIXME
by Fabrice Ménard 10 Nov '04

10 Nov '04

Hi, In setupapi/setupx_main.c, function SETUPX_CreateStandardLDDs: There is a FIXME("LDID_SRCPATH: what exactly do we have to do here ?\n"). It concerns the registry value: SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Setup\\SourcePath. AFAIK, this value defines the location where the setup of windows was done. As we don't have a real windows installation, this key is naturally not set. I'm wondering if it will hurt to set it to a fallback string (maybe the most common one: "D:\\") and get rid of this FIXME. I think if a windows application need this value and don't find what it wants, it justs throw a message box asking for the correct CD (in fact it is very common to have this value set to a wrong path when you have more than one CD device). I know it is not so important, but I really enjoy having one less FIXME :-)) If you're ok with that, I'll send a tiny patch Fabrice Ménard menard.fabrice(a)wanadoo.fr

1 0

Ekush
by Ge van Geldorp 10 Nov '04

10 Nov '04

> From: Ge van Geldorp > > Ekush (http://www.ekush.com) published some binaries. > Surprise, surprise, it looks like ReactOS very much (Check > e.g. the radio buttons on the "Accept License" screen during > 2nd stage setup). > Some string searching in their binaries reveals: > > $ strings -a ver.dll | grep ReactOS > OS2 Images not supported under ReactOS at this time. Shortly after I sent this email to ros-dev yesterday the Ekush website went down. Today they are back, with a slightly changed set of binaries. The strings I reported yesterday are gone now (well, except for the CcRosInitializeFileCache and CcRosReleaseFileCache exports from NTOSKRNL, maybe changing the name of an exported symbol was too difficult???). There's still plenty of other evidence of the ReactOS heritage though. I guess since I only reported about ReactOS they forgot to remove the references to Wine (except ofcourse the copyright notices, those are gone). This pisses me off bigtime. I can only explain it as a deliberate attempt to use the work of Qemu, FreeType, Wine and ReactOS without giving credit. Gé van Geldorp.

2 1

Latent memory corruption bug in widl, with workaround
by Dan Kegel 10 Nov '04

10 Nov '04

I ran into the error Oops, segment violation while running make to build wine from cvs. It failed on the command ../tools/widl/widl -I../../wine/include -I. -I../../wine/include -I../include -h -H ocidl.h ../../wine/include/ocidl.idl Turning on logging showed that it happened while processing an import statement. Running under valgrind yielded output like this: ==10699== Invalid read of size 1 ==10699== at 0x4002273E: strlen (mac_replace_strmem.c:164) ==10699== by 0x805E0D1: pp_xstrdup (../../../wine/libs/wpp/preproc.c:108) ==10699== by 0x805E7B2: pp_add_define (../../../wine/libs/wpp/preproc.c:231) ==10699== by 0x805FB21: add_cmdline_defines (../../../wine/libs/wpp/wpp.c:48) ==10699== Address 0x41233334 is 0 bytes inside a block of size 29 free'd ==10699== at 0x40029961: free (vg_replace_malloc.c:231) ==10699== by 0x805B9B6: yylex (../../../wine/tools/widl/parser.l:126) ==10699== by 0x80548B3: yyparse (/usr/share/bison/bison.simple:573) ==10699== by 0x8054295: main (../../../wine/tools/widl/widl.c:265) Commenting out the free on line 126 of widl/parser.l solved the problem. Uncommenting it and building again, I couldn't reproduce the original crash, but running under valgrind revealed the problem was still there, just hidden. I tried tracing through why the free on line 126 of widl/parser.l was bad, but it was too late, and I was too tired. Can somebody else have a look? It was quite annoying to be dead in the water, unable to build wine... Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

1 0

Re: [lostwages] developer cheatsheet
by Jeremy Newman 10 Nov '04

10 Nov '04

Added this. The text in the <code> tag on line 78 is long. It needs a line break or something. And I fixed the url in documentation template. Otherwise it looks fine to me. On Fri, 2004-11-05 at 19:00 +0000, Mike Hearn wrote: > Add a developer getting started guide to the website. Hack to your > satisfaction, I probably did it totally wrong ;)

1 0

Thanks
by Frank v Waveren 09 Nov '04

09 Nov '04

I felt nostalgic for starcraft today, so for fun and kicks decided to see if wine was up to the task. Not only did it run, it worked perfectly, using RandR and everything. Very impressive, thanks for the wonderful work everyone! -- Frank v Waveren Fingerprint: 9106 FD0D fvw(a)[var.cx|stack.nl] ICQ#10074100 D6D9 3E7D FAF0 92D1 Public key: hkp://wwwkeys.pgp.net/8D54EB90 3931 90D6 8D54 EB90

1 0

Re: dlls/rsaenh/rsaenh.c
by Alexandre Julliard 09 Nov '04

09 Nov '04

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > Changelog: > CPAcquireContext: Set last error to ERROR_SUCCESS in case of success. There are very few functions that set last error on success, do you have a test demonstrating that Windows does it in this case? -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: drive detection and driveui rewrite
by Alexandre Julliard 09 Nov '04

09 Nov '04

Mike Hearn <mike(a)navi.cx> writes: > final part of winecfg work from september > > - Add drive detection and clean up the drive configuration code/UI It doesn't build, you probably forgot some files. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: implement dbghelp's C++ name undecoration on top of msvcrt's
by Eric Pouech 09 Nov '04

09 Nov '04

Eric Pouech a écrit : > see Changelog for the details > A+ with the patch this time. A+

2 1

Re: Convert the COLORREF to a real colour for ExtTextOut
by Alexandre Julliard 09 Nov '04

09 Nov '04

Glenn Wurster <gwurster(a)scs.carleton.ca> writes: > Index: dlls/x11drv/xrender.c > =================================================================== > RCS file: /home/wine/wine/dlls/x11drv/xrender.c,v > retrieving revision 1.48 > diff -u -r1.48 xrender.c > --- dlls/x11drv/xrender.c 27 Oct 2004 00:43:50 -0000 1.48 > +++ dlls/x11drv/xrender.c 8 Nov 2004 03:54:51 -0000 > @@ -1019,6 +1019,11 @@ > UINT align = GetTextAlign( hdc ); > COLORREF textColor = GetTextColor( hdc ); > > + textColor = X11DRV_PALETTE_ToPhysical( physDev, textColor ); > + textColor = ((textColor & 0xFF0000) >> 16) | > + (textColor & 0xFF00) | > + ((textColor & 0xFF) << 16); > + That color swapping looks very suspicious, you shouldn't need anything like that. And actually it seems to me you should simply be able to use physDev->textPixel instead, but maybe I'm missing something. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: fix delete_key in shlwapi/shreg test
by Bill Medland 09 Nov '04

09 Nov '04

On November 9, 2004 12:10 am, James Hawkins wrote: > oops one-letter typo. This is the correct version. > > On Tue, 9 Nov 2004 01:46:50 -0500, James Hawkins <truiken(a)gmail.com> wrote: > > the previous implementation of delete_key only deleted subkeys of a > > requested key to delete. this fixes that and also fixes test failures > > that crop up in advapi32/registry because of extraneous keys in > > Software\Wine\Test. > > > > Changelog > > * fix implementation of delete_key for shreg test Alternatively couldn't we just call SHDeleteKey, now it has been fixed. > > > > -- > > James Hawkins

3 4

[rsaenh] compilation problem
by Fabrice Ménard 09 Nov '04

09 Nov '04

Hi, I'd like to know wich version of openssl is used for rsaenh.dll. With openssl 0.9.6g, I can't compile rsaenh because of name clashs. For example where "DES_*" is used I've got "des_*"equivalent. Moreover, I don't have for example RSAPrivateKey_dup. If it's really a version problem, I think we should check that with autoconf. regards, -- Fabrice Ménard menard.fabrice(a)wanadoo.fr

2 1

Miscellaneous UI Fixes
by William Poetra Yoga H 09 Nov '04

09 Nov '04

OK, this is the first time I'm sending a patch as plaintext (I figured out I have to use .txt as the extension, otherwise it's sent as a normal attachment). I don't know if this method of sending works correctly so please try it and let me know. This patch fixes a number of things: 1. System menu icon (fix size and position) 2. Caption buttons (fix size and position) 3. Window caption (fix bounding rectangle) 4. Menu bar (fix size) 5. Popup menu (fix distance) By the way, I have this kind of code in my patch (I wrote this code, the original one doesn't look like this): rect.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; Is it OK to write so? What I mean by the code is, the size of the button is (GetSystemMetrics(SM_CXSIZE) - 2), and there's a 2-pixel space to the right of the button. Or should I just write: rect.right -= GetSystemMetrics(SM_CXSIZE); Which doesn't deliver the message clearly but is simpler. I have tested the patch against theForger's tutorial (I compared the screenshots to the actual apps running on my machine) and it doesn't generate new errors, although some things aren't fixed yet: 1. Popup menu items are still a bit (one pixel) taller than those in Windows. For this one I think I really need help. 2. Caption buttons' captions are still the old ones. I'll try to fix these after this patch is committed. 3. Caption bar is still single-color. I'll fix this after this patch, because it will intersect with this patch and possibly make an unclean patch, in the end the two gets messy and never gets committed. I haven't sent this to wine-patches yet. How should I do it? I mean, should I send it all at once (the two files), or one file per message, or one file per item (of the 5 items fixed, above)? I'm not sure (I've read the docs). Reasons for sending the patch: 1. all at once: the patches are a group of related fixes (as said in the website). 2. one file per message: I don't know :-P 3. one file per item: it's one fix per patch (as said in the website) I prefer #1, but is it OK actually? Comments, Alexandre? Guys? Gals? __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com Index: dlls/user/menu.c =================================================================== RCS file: /home/wine/wine/dlls/user/menu.c,v retrieving revision 1.7 diff -u -r1.7 menu.c --- dlls/user/menu.c 19 Oct 2004 21:10:17 -0000 1.7 +++ dlls/user/menu.c 7 Nov 2004 04:47:47 -0000 @@ -978,7 +978,7 @@ { lpitem = &lppop->items[start]; orgX = maxX; - orgY = 2; + orgY = 3; maxTab = maxTabWidth = 0; @@ -1043,7 +1043,7 @@ lprect->left, lprect->top, lprect->right, lprect->bottom); lppop->Width = lprect->right - lprect->left; lppop->Height = 0; - maxY = lprect->top+1; + maxY = lprect->top; start = 0; helpPos = -1; while (start < lppop->nItems) @@ -1077,7 +1077,7 @@ while (start < i) lppop->items[start++].rect.bottom = maxY; } - lprect->bottom = maxY; + lprect->bottom = maxY + 1; lppop->Height = lprect->bottom - lprect->top; /* Flush right all items between the MF_RIGHTJUSTIFY and */ @@ -1431,7 +1431,7 @@ lppop = MENU_GetMenu( hMenu ); if (lppop == NULL || lprect == NULL) { - return GetSystemMetrics(SM_CYMENU); + return GetSystemMetrics(SM_CYMENU) + 1; } if (suppress_draw) @@ -1441,8 +1441,6 @@ if (lppop->Height == 0) MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd); - lprect->bottom = lprect->top + lppop->Height; - if (hfontOld) SelectObject( hDC, hfontOld); return lppop->Height; } @@ -3765,7 +3763,7 @@ lppop = MENU_GetMenu( hMenu ); if (lppop == NULL || lprect == NULL) { - retvalue = GetSystemMetrics(SM_CYMENU); + retvalue = GetSystemMetrics(SM_CYMENU) + 1; goto END; } @@ -3776,17 +3774,17 @@ if (lppop->Height == 0) MENU_MenuBarCalcSize(hDC, lprect, lppop, hwnd); - lprect->bottom = lprect->top + lppop->Height; - FillRect(hDC, lprect, GetSysColorBrush(COLOR_MENU) ); +#if 0 SelectObject( hDC, SYSCOLOR_GetPen(COLOR_3DFACE)); MoveToEx( hDC, lprect->left, lprect->bottom, NULL ); LineTo( hDC, lprect->right, lprect->bottom ); +#endif if (lppop->nItems == 0) { - retvalue = GetSystemMetrics(SM_CYMENU); + retvalue = GetSystemMetrics(SM_CYMENU) + 1; goto END; } Index: windows/nonclient.c =================================================================== RCS file: /home/wine/wine/windows/nonclient.c,v retrieving revision 1.126 diff -u -r1.126 nonclient.c --- windows/nonclient.c 19 Oct 2004 22:54:24 -0000 1.126 +++ windows/nonclient.c 7 Nov 2004 04:56:16 -0000 @@ -400,7 +400,7 @@ winRect->top += MENU_GetMenuBarHeight( hwnd, winRect->right - winRect->left, - -tmpRect.left, -tmpRect.top ) + 1; + -tmpRect.left, -tmpRect.top ); } SetRect(&tmpRect, 0, 0, 0, 0); @@ -655,9 +655,9 @@ { RECT rect; NC_GetInsideRect( hwnd, &rect ); - DrawIconEx (hdc, rect.left + 1, rect.top + 1, hIcon, - GetSystemMetrics(SM_CXSIZE) - 1, - GetSystemMetrics(SM_CYSIZE) - 1, 0, 0, DI_NORMAL); + DrawIconEx (hdc, rect.left + 2, rect.top + 1, hIcon, + GetSystemMetrics(SM_CXSMICON), + GetSystemMetrics(SM_CYSMICON), 0, 0, DI_NORMAL); } return (hIcon != 0); } @@ -682,21 +682,21 @@ /* A tool window has a smaller Close button */ if (GetWindowLongA( hwnd, GWL_EXSTYLE ) & WS_EX_TOOLWINDOW) { - INT iBmpHeight = 11; /* Windows does not use SM_CXSMSIZE and SM_CYSMSIZE */ - INT iBmpWidth = 11; /* it uses 11x11 for the close button in tool window */ - INT iCaptionHeight = GetSystemMetrics(SM_CYSMCAPTION); + INT iCaptionHeight = GetSystemMetrics(SM_CYSMCAPTION) - 1; + INT iBmpHeight = iCaptionHeight - 4; + INT iBmpWidth = iCaptionHeight - 5; - rect.top = rect.top + (iCaptionHeight - 1 - iBmpHeight) / 2; - rect.left = rect.right - (iCaptionHeight + 1 + iBmpWidth) / 2; + rect.top += 2; + rect.right -= 2; rect.bottom = rect.top + iBmpHeight; - rect.right = rect.left + iBmpWidth; + rect.left = rect.right - iBmpWidth; } else { - rect.left = rect.right - GetSystemMetrics(SM_CXSIZE) - 1; - rect.bottom = rect.top + GetSystemMetrics(SM_CYSIZE) - 1; rect.top += 2; rect.right -= 2; + rect.bottom = rect.top + (GetSystemMetrics(SM_CYSIZE) - 4); + rect.left = rect.right - (GetSystemMetrics(SM_CXSIZE) - 2); } DrawFrameControl( hdc, &rect, DFC_CAPTION, (DFCS_CAPTIONCLOSE | @@ -722,12 +722,12 @@ flags = IsZoomed(hwnd) ? DFCS_CAPTIONRESTORE : DFCS_CAPTIONMAX; NC_GetInsideRect( hwnd, &rect ); - if (GetWindowLongA( hwnd, GWL_STYLE) & WS_SYSMENU) - rect.right -= GetSystemMetrics(SM_CXSIZE) + 1; - rect.left = rect.right - GetSystemMetrics(SM_CXSIZE); - rect.bottom = rect.top + GetSystemMetrics(SM_CYSIZE) - 1; rect.top += 2; + if (GetWindowLongA( hwnd, GWL_STYLE) & WS_SYSMENU) + rect.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; rect.right -= 2; + rect.bottom = rect.top + (GetSystemMetrics(SM_CYSIZE) - 4); + rect.left = rect.right - (GetSystemMetrics(SM_CXSIZE) - 2); if (down) flags |= DFCS_PUSHED; if (bGrayed) flags |= DFCS_INACTIVE; DrawFrameControl( hdc, &rect, DFC_CAPTION, flags ); @@ -750,14 +750,14 @@ return; NC_GetInsideRect( hwnd, &rect ); + rect.top += 2; if (style & WS_SYSMENU) - rect.right -= GetSystemMetrics(SM_CXSIZE) + 1; + rect.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; + rect.right -= 2; if (style & (WS_MAXIMIZEBOX|WS_MINIMIZEBOX)) rect.right -= GetSystemMetrics(SM_CXSIZE) - 2; - rect.left = rect.right - GetSystemMetrics(SM_CXSIZE); - rect.bottom = rect.top + GetSystemMetrics(SM_CYSIZE) - 1; - rect.top += 2; - rect.right -= 2; + rect.left = rect.right - (GetSystemMetrics(SM_CXSIZE) - 2); + rect.bottom = rect.top + (GetSystemMetrics(SM_CYSIZE) - 4); if (down) flags |= DFCS_PUSHED; if (bGrayed) flags |= DFCS_INACTIVE; DrawFrameControl( hdc, &rect, DFC_CAPTION, flags ); @@ -871,7 +871,7 @@ if ((style & WS_SYSMENU) && !(exStyle & WS_EX_TOOLWINDOW)) { if (NC_DrawSysButton (hwnd, hdc, FALSE)) - r.left += GetSystemMetrics(SM_CYCAPTION) - 1; + r.left += GetSystemMetrics(SM_CXSMICON) + 2; } if (style & WS_SYSMENU) @@ -885,18 +885,22 @@ /* Draw a grayed close button if disabled and a normal one if SC_CLOSE is not there */ NC_DrawCloseButton (hwnd, hdc, FALSE, ((((state & MF_DISABLED) || (state & MF_GRAYED))) && (state != 0xFFFFFFFF))); - r.right -= GetSystemMetrics(SM_CYCAPTION) - 1; + r.right -= (GetSystemMetrics(SM_CXSIZE) - 2) + 2; if ((style & WS_MAXIMIZEBOX) || (style & WS_MINIMIZEBOX)) { + /* There's a 2-pixel space between Maximize and Close buttons */ + + r.right -= 2; + /* In win95 the two buttons are always there */ /* But if the menu item is not in the menu they're disabled*/ NC_DrawMaxButton( hwnd, hdc, FALSE, (!(style & WS_MAXIMIZEBOX))); - r.right -= GetSystemMetrics(SM_CXSIZE) + 1; + r.right -= GetSystemMetrics(SM_CXSIZE) - 2; NC_DrawMinButton( hwnd, hdc, FALSE, (!(style & WS_MINIMIZEBOX))); - r.right -= GetSystemMetrics(SM_CXSIZE) + 1; + r.right -= GetSystemMetrics(SM_CXSIZE) - 2; } } @@ -915,6 +919,7 @@ else SetTextColor( hdc, GetSysColor( COLOR_INACTIVECAPTIONTEXT ) ); SetBkMode( hdc, TRANSPARENT ); r.left += 2; + r.right -= 2; DrawTextW( hdc, buffer, -1, &r, DT_SINGLELINE | DT_VCENTER | DT_NOPREFIX | DT_LEFT ); DeleteObject (SelectObject (hdc, hOldFont)); @@ -1010,12 +1015,12 @@ { RECT r = rect; if (dwExStyle & WS_EX_TOOLWINDOW) { - r.bottom = rect.top + GetSystemMetrics(SM_CYSMCAPTION); rect.top += GetSystemMetrics(SM_CYSMCAPTION); + r.bottom = rect.top; } else { - r.bottom = rect.top + GetSystemMetrics(SM_CYCAPTION); rect.top += GetSystemMetrics(SM_CYCAPTION); + r.bottom = rect.top; } if( !clip || IntersectRect( &rfuzz, &r, &rectClip ) ) NC_DrawCaption(hdc, &r, hwnd, dwStyle, dwExStyle, active); @@ -1029,7 +1034,7 @@ TRACE("Calling DrawMenuBar with rect (%ld, %ld)-(%ld, %ld)\n", r.left, r.top, r.right, r.bottom); - rect.top += MENU_DrawMenuBar( hdc, &r, hwnd, suppress_menupaint ) + 1; + rect.top += MENU_DrawMenuBar( hdc, &r, hwnd, suppress_menupaint ); } TRACE("After MenuBar, rect is (%ld, %ld)-(%ld, %ld).\n",

5 8

Re: [shellpath.c] Taking into account the profile value set in wine config file
by Juan Lang 09 Nov '04

09 Nov '04

You've exposed some softness in my thinking in this patch. Like I mentioned in the comments for it, _SHExpandEnvironmentVariables exists because the environment isn't actually set up during wine install time. I didn't think to look up the values in the registry. I also didn't register some of the "environment" variables that I use, and probably should have. You might rewrite it just to look at the registry. You probably want to look in HKLM\System\Current Control Set\Session Manager\Environment if the value you're looking for isn't in HKCU, and some variables should probably not be overridable in HKCU either (SystemRoot, for example). --Juan __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

3 5

Re: [Fwd: Re: dlls/winmm/tests/capture.c - yes, we can open a device in 2MHz...]
by Robert Reif 09 Nov '04

09 Nov '04

> > > How about this? > > > > regards, > Jakob > How about starting a blacklist framework. You could have a table with the function that fails and some caps info that identifies the driver. I would suspect that there is more than one buggy driver out there. You could then just add it's info to the table when it is found. You could then do: if (!inBlacklist(WAVE_IN_OPEN, &capsA)) { // do the test ... } else trace("blacklisted ..... \n"); There are modems that do strange things and the Remote Desktop Protocol driver and other third party sound rerouting pseudo drivers also do strange things. These will need to be added someday also. This could become a real maintenance nightmare if not done properly from the start.

2 1

Blocking automatic debugger launch
by Kenneth Porter 09 Nov '04

09 Nov '04

I've got an app that seems to be crashing during shutdown. (Tribes Vengeance dedicated server) I'm running it detached inside a screen session, and I don't want the debugger to automatically launch when the app crashes. I just want the thing to die when I send it a "quit" command. Currently I've hacked the registry setting and changed the debugger name to "true". Is there a cleaner way to accomplish this?

4 4

Re: dlls/winmm/tests/capture.c - yes, we can open a device in 2MHz...
by Robert Reif 09 Nov '04

09 Nov '04

Jakob Eriksson wrote: > > > As shown by: > http://test.winehq.org/data/200411021000/2000_IDWASEMPTY_1/winmm:capture.txt > > > capture.c:571:found 1 WaveIn devices > capture.c:302: 0: "Avance AC'97 Audio" > (\\?\pci#ven_1106&dev_3059&subsys_00000000&rev_10#3&61aaa01&0&8d#{6994ad04-93ef-11d0-a3cc-00a0c9223196}\wave) > 5.0 (1:101) > capture.c:305: channels=65535 formats=00fff > capture.c:364: Test failed: waveInOpen(0): opening the device with 2 > MHz sample rate should fail: rc=MMSYSERR_NOERROR(The specified > command was carried out.) That's a driver bug.

5 9

Update to flymake patch
by Mike Hearn 08 Nov '04

08 Nov '04

This adds support for the lovely flymake-mode, which compiles C as you write it in the background and highlights errors and warnings. It's an update to the patch I sent in about a year ago. Since then GNU Emacs has changed (in cvs) so I've attached the version of flymake-mode you need to make it all work. Not expecting this to get merged so it goes to wine-devel.

1 0

registry test incorrect for xp
by James Hawkins 08 Nov '04

08 Nov '04

I just completed building the wine conformance tests with Visual Studio .NET. When I ran the advapi32/security tests, there were 28 failures (compiled and tested on XP). The first error I looked at is: registry.c:93: Test failed: data_count set to 24 instead of 7 Looking at registry.c, this test calls RegEnumValue with an output data buffer that is too small, LONG RegEnumValue( HKEY hKey, DWORD dwIndex, LPTSTR lpValueName, LPDWORD lpcValueName, LPDWORD lpReserved, LPDWORD lpType, LPBYTE lpData, LPDWORD lpcbData ); so the lpcbData should contain the required size of the buffer on return. hKey is initialized to HKCU\Software\Wine\Test and dwIndex is 0, so we're reading this: Name: Test1 Type: REG_EXPAND_SZ Data: %LONGSYSTEMVAR%\subdir1 The current test expects RegEnumValue to expand the environment variable %LONGSYSTEMVAR%, leaving nothing since the variable doesn't exist. If this were the case then lpcbData would return the length of 'subdir1' which is 7, which is what the test expects, but testing shows that even though the type is REG_EXPAND_SZ, RegEnumValue does not expand the environment variable, so lpcbData contains the length of %LONGSYSTEMVAR%\subdir1 which is 24, and which is what is returned when called with XP. This is further clarified by msdn docs, "Your application should call ExpandEnvironmentStrings before attempting to read the value of a REG_EXPAND_SZ registry data type." http://msdn.microsoft.com/library/default.asp?url=/library/en-us/apcompat/a… While it never says that RegEnumValue doesn't expand REG_EXPAND_SZ, this evidence shows that this is the case. If anyone has any thoughts on this, please let me know. Otherwise I will be sending a patch that fixes this test and then checking the test in wine to see if our RegEnumValue needs to be fixed as well. -- James Hawkins

1 1

150 test failures. advapi32 test crashes.
by Dan Kegel 08 Nov '04

08 Nov '04

Hey folks, I pulled down sources from CVS this morning, and tried running the regression tests. There are about 150 failures. Here's a summary: $ grep "Test failed" log | sed 's/:.*//' | uniq -c | sort 1 filtergraph.c 1 rsaenh.c 1 shelllink.c 1 shreg.c 2 typelib.c 4 capture.c 4 wave.c 6 dsound8.c 6 dsound.c 7 vartype.c 8 path.c 15 crypt.c 43 metafile.c 51 shellpath.c Is this unusual? How many failures are most people seeing? For what it's worth, this is a Red Hat 9.0 system with two processors, and this was done with no pre-existing .wine directory. Also, there was a crash during the test. Here's that part of the log: ../../../../wine/tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so ../../../../wine/dlls/advapi32/tests/crypt.c && touch crypt.ok crypt.c:104: Test failed: -2146893799 crypt.c:117: Test failed: 0/-2146893799 crypt.c:126: Test failed: 0/-2146893801 crypt.c:457: Test failed: expected 234, got -2146893801 crypt.c:464: Test failed: expected 0, got 0 crypt.c:471: Test failed: expected (null), got crypt.c:472: Test failed: expected 0, got 0 crypt.c:491: Test failed: -2146893805 crypt.c:494: Test failed: -2146893805 crypt.c:502: Test failed: expected Microsoft Base Cryptographic Provider v1.0, got crypt.c:503: Test failed: expected 43, got 0 crypt.c:491: Test failed: -2146893805 crypt.c:494: Test failed: -2146893805 crypt.c:502: Test failed: expected Microsoft Base Cryptographic Provider v1.0, got crypt.c:503: Test failed: expected 43, got 0 wine: Unhandled exception (thread 0009), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x8dbe4073 in 32-bit code (0x403602e2). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:003b GS:0033 EIP:403602e2 ESP:4073f9d2 EBP:4073fa5e EFLAGS:00010202( - 00 - -RI1) EAX:8dbe4073 EBX:404174c8 ECX:40053500 EDX:401f0b20 ESI:4073fe26 EDI:77f01330 Stack dump: 0x4073f9d2: 00004001 00000000 00000000 d14c0000 0x4073f9e2: 0c884001 13304020 fa3477f0 020f4073 0x4073f9f2: fa340000 a5864073 fa644001 009b4073 0x4073fa02: d8940000 00004002 00000001 6c644008 0x4073fa12: ffff4041 e384ffff fa2c400c 68114073 0x4073fa22: 6c644008 74c84041 fa544041 e3844073 Backtrace: =>1 0x403602e2 INSTR_EmulateInstruction+0xda(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/kernel/instr.c:449] in kernel32 (0x4073fa5e) 2 0x403a441e vectored_handler+0x5e(ptrs=0x4073fa8e) [../../../wine/dlls/kernel/wowthunk.c:358] in kernel32 (0x4073fa7e) 3 0x4008bf89 call_vectored_handlers+0x5a(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/exception.c:196] in ntdll (0x4073faa2) 4 0x4008c30d EXC_RtlRaiseException+0x239(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/exception.c:252] in ntdll (0x4073fb2a) 5 0x400abe12 raise_segv_exception+0x8b(rec=0x4073fe26, context=0x4073fb5a) [../../../wine/dlls/ntdll/signal_i386.c:888] in ntdll (0x4073fb46) 0x403602e2 INSTR_EmulateInstruction+0xda [../../../wine/dlls/kernel/instr.c:449] in kernel32: movzbl 0x0(%eax),%eax Unable to open file ../../../wine/dlls/kernel/instr.c Modules: Module Address Debug info Name (17 modules) ELF 0x40000000-40016000 Deferred ld-linux.so.2 ELF 0x40017000-40030000 Deferred libwine.so.1 ELF 0x40032000-4003e000 Deferred libnss_files.so.2 ELF 0x40043000-40050000 Deferred libpthread.so.0 ELF 0x40050000-40053000 Deferred libdl.so.2 ELF 0x40054000-400d1000 Stabs ntdll<elf> \-PE 0x40070000-400d1000 \ ntdll ELF 0x400d1000-401c5000 Deferred libwine_unicode.so.1 ELF 0x401c5000-401e7000 Deferred libm.so.6 ELF 0x40300000-40419000 Stabs kernel32<elf> \-PE 0x40330000-40419000 \ kernel32 ELF 0x40621000-4063c000 Deferred advapi32_test<elf> \-PE 0x40630000-4063c000 \ advapi32_test ELF 0x40740000-4077b000 Deferred advapi32<elf> \-PE 0x40750000-4077b000 \ advapi32 ELF 0x42000000-42133000 Deferred libc.so.6 ELF 0x77f00000-77f03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\dank\demo\build\dlls\advapi32\tests\advapi32_test.exe 00000009 0 <== WineDbg terminated on pid 0x8 -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

5 11

Re: signaling unix threads
by Jukka Heinonen 08 Nov '04

08 Nov '04

Markus Amsler wrote: > There's a fundamental bug in winedos/dosvm. c[1]. SIGUSR2 is sent to the > current process, but it should be sent to the dosvm thread. This causes > various ugly bugs. > I found no way signaling a unix thread, without modifing the wineserver. > I have implemented a thread_kill command in the wineserver, this solves > my problem, but i'm quite sure it won't get applied. > > I'm really not a wineserver/threading expert. Have I missed something? Yep. If using Linux 2.6 kernel and recent pthread library, threads share the same pid and they must be signalled using tkill and not kill. The only place which knows how to correctly signal threads is send_thread_signal function in server/ptrace.c. So, the easy way to fix signalling is to use Windows thread identifier for identifying dosvm thread instead of pids (which don't work anyway) and add to wineserver a handler that just calls send_thread_signal, which I guess is what you have been doing, anyway. Now, I have tried this approach and it seems to work. I have some prototype implementation lying around but I was thinking about doing something more complicated at the time, like using SIGUSR2 handler for doing Win32 remote operations discussed earlier on wine-devel, because signal handler is probably running in the correct context for doing this kind of things but I guess locking issues are going to be pretty complicated so it is probably better to just fix dosvm issues with a simple mechanism and not worry about anything else. So, feel free to submit a patch, if it is simple enough it should get accepted or at least you should get some suggestions how to change the patch in order for it to get accepted. -- Jukka Heinonen <http://www.iki.fi/jhei>

4 5

Re: Fix DLL loader regression
by Mike Hearn 08 Nov '04

08 Nov '04

Any problem with this one Alexandre? On Thu, 04 Nov 2004 01:00:37 +0000, Mike Hearn wrote: > - Always add .dll extension when loading modules > > > Index: loader.c > =================================================================== > RCS file: /home/wine/wine/dlls/ntdll/loader.c,v > retrieving revision 1.78 > diff -u -p -r1.78 loader.c > --- loader.c 11 Oct 2004 20:59:06 -0000 1.78 > +++ loader.c 4 Nov 2004 00:56:48 -0000 > @@ -1432,12 +1432,18 @@ static NTSTATUS find_dll_file( const WCH > len = nt_name.Length - 4*sizeof(WCHAR); /* for \??\ prefix */ > if (len >= *size) goto overflow; > memcpy( filename, nt_name.Buffer + 4, len + sizeof(WCHAR) ); > + > + /* do we need to add the .dll extension? */ > if (file_part && !strchrW( file_part, '.' )) > { > len += sizeof(dllW) - sizeof(WCHAR); > if (len >= *size) goto overflow; > strcatW( filename, dllW ); > + RtlFreeUnicodeString( &nt_name ); > + if (!RtlDosPathNameToNtPathName_U( filename, &nt_name, &file_part, NULL )) > + return STATUS_NO_MEMORY; > } > + > if (!(*pwm = find_fullname_module( filename ))) > { > attr.Length = sizeof(attr);

2 1

Scrollbars
by Nicolai Kuntze 08 Nov '04

08 Nov '04

Hi, I have played with my continuing bug (#2302) but I have some problems understanding the meaning of the output: fixme:win:GetWindowModuleFileNameA GetWindowModuleFileNameA(hwnd 0x40032, lpszFileName 0x40670548, cchFileNameMax 80) stub! trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=1 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=1 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=2 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=2 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=3 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=3 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 If my blue bar in the list disappears pos Value counts how many lines under the window I am. I have added a little debug to follow the source ... From the developer I got the following snipplet: int SViewLow::ViewSetScrollY( int PPos, int PMax, int PPage) { SCROLLINFO Scroll; memset( &Scroll, 0, sizeof( Scroll)); Scroll.cbSize= sizeof( SCROLLINFO); Scroll.fMask= 0; if (PPos!=-1) Scroll.fMask|= SIF_POS; if (PMax!=-1) Scroll.fMask|= SIF_RANGE; if (PPage!=-1) Scroll.fMask|= SIF_PAGE; Scroll.nPos= PPos; Scroll.nPage= PPage; Scroll.nMax= PMax-1; return SetScrollInfo( (HWND)ViewGetHWND(), SB_VERT, &Scroll, TRUE); } Does anyone has an idea what this could be? Yours, Nicolai

2 1

Re: Re: Winetest questions
by Chris Morgan 08 Nov '04

08 Nov '04

> On Sun, Nov 07, 2004 at 02:01:13PM -0800, Dan Kegel wrote: > > 1. Why are all the archived posts to wine-test-results empty? > > See http://www.winehq.org/hypermail/wine-tests-results/2004/11 > > Every message body is empty! What's up with that? > > That's a good question. Chris, what's going on? > I suspect these are clients that have issues connecting to the net to upgrade their version of winrash since there are relatively few error reports compared to the number of test result submissions. We should really have the script ignore empty requests like this as they don't tell us anything and simply spam the mailing list every day. Chris

1 0

Re: Fix for metafile test
by Dan Kegel 08 Nov '04

08 Nov '04

jakov(a)vmlinux.org wrote: > This is from when I ran winetest.exe from the desktop: > > http://test.winehq.org/data/200411021000/2000/gdi32:metafile.txt : > > metafile.c:126:hdcDisplay 76010815 > metafile.c:154:hdcMetafile 202107C1 > metafile.c:40:hdc 76010815, emr->iType 1, emr->nSize 108, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 82, emr->nSize 368, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 84, emr->nSize 336, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 37, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 40, emr->nSize 12, param 0022FB58 > metafile.c:40:hdc 76010815, emr->iType 14, emr->nSize 20, param 0022FB58 > metafile: 151 tests executed, 0 marked as todo, 0 failures. Here's what I get when I run 'make test' on Wine: ../../../../wine/tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so ../../../../wine/dlls/gdi/tests/metafile.c && touch metafile.ok metafile.c:91: Test failed: pass 0: dx[0] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[1] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[2] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[3] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[4] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[5] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[6] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[7] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[8] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[9] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[10] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[11] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[12] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[13] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[14] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[15] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[16] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[17] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[18] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[19] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[20] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[21] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[22] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[23] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[24] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[25] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[26] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[27] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[28] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[29] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[30] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[31] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[32] (1081735508) didn't match 5 metafile.c:91: Test failed: pass 0: dx[33] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[34] (1081735508) didn't match 6 metafile.c:91: Test failed: pass 0: dx[35] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[36] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[37] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[38] (1081735508) didn't match 3 metafile.c:91: Test failed: pass 0: dx[39] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[40] (1081735508) didn't match 2 metafile.c:91: Test failed: pass 0: dx[41] (1081735508) didn't match 4 metafile.c:91: Test failed: pass 0: dx[42] (1081735508) didn't match 4 make[3]: *** [metafile.ok] Error 43 Is the metafile test supposed to be broken like this under Wine? - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 2

Re: wine/ tools/wine.inf include/config.h.in dlls/ ...
by Vincent Béron 08 Nov '04

08 Nov '04

Le jeu 04/11/2004 à 16:15, Alexandre Julliard a écrit : > Log message: > Michael Jung <mjung(a)iss.tu-darmstadt.de> > Implemented a substantial part of rsaenh.dll. > > Patch: http://cvs.winehq.org/patch.py?id=14412 The committed patch doesn't compile on RH8. OpenSSL doesn't use the same name for some datatypes/functions as the version used by Michael (actually the prototype is different as well). OpenSSL 0.9.7a (as found on FC1) will use OPENSSL_ENABLE_OLD_DES_SUPPORT by default which will #define the old names to the new ones for the DES functions. RSAPrivateKey_dup is only defined in x509.h in OpenSSL 0.9.6b, not in rsa.h. But pulling in x509.h also includes md4.h, md5.h and sha.h (via evp.h), which redefine MD4_CTX (and MD5 and SHA _CTX also) with an incompatible definition if the NO_MD4, etc. are not defined. Changelog: Allow rsaenh compilation with older (0.9.6b) OpenSSL version. Remove a cast from const to not-const. Vincent

2 1

Do we need one of those on our docs?
by Shachar Shemesh 08 Nov '04

08 Nov '04

From the samba developer's guide, http://us1.samba.org/samba/devel/ > *Important:* In order to avoid any potential licensing issues we > also ask that anyone who has signed the Microsoft CIFS Royalty > Free Agreement > <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/cifs/proto…> > not submit patches to Samba, nor base patches on the referenced > specification. We ask, too, that patches submitted to Samba not > infringe on any known patents. Finally, as with all GPL work, the > submitter should ensure that submitted patches do not conflict > with any third-party copyright. > > Do we need to put in something like that too? I'm not a lawyer (but I can probably get one). My understanding is that the "protocols" Microsoft policy don't really affect us. What may affect us is the wider and wider distribution of the Windows source code (Shared Source). We should not be highly affected by trade secrets: anyone publishing a trade secret is nullifying the secretness of it, and is the one bearing the responsibility for this action. However, copyright problems may be a problem for us. If someone takes a significant amount of code from MS and submits it, we may have some backtracking to do. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: signaling unix threads
by Dan Kegel 08 Nov '04

08 Nov '04

Mike Hearn wrote: > I quite liked Michaels idea of the RT signals. Is there some reason we > can't use them? I didn't see Michael's proposal. Can you point to it? Now, I don't pretend to understand the issues here, but reading your patch, http://www.winehq.org/hypermail/wine-patches/2004/11/att-0041/01-patch__cha… I see the comment * ... there is a race with SuspendThread(): the app * can call SuspendThread() then GetThreadContext() whilst the * target is processing SIGUSR1 but before it's been able to * override the thread context, ie the context returned would be * meaningless to the app (internals of Wine itself). I understand similar races are present in real Windows, too. e.g. http://blogs.msdn.com/cbrumme/archive/2003/08/20/51504.aspx says "[with SuspendThread,] there’s a significant risk of leaving a thread suspended at a “bad” spot. If you call SuspendThread while a thread is inside the OS heap lock, you better not try to allocate or free from that same heap. In a similar fashion, if you call SuspendThread while a thread holds the OS loader lock (e.g. while the thread is executing inside DllMain) then you better not call LoadLibrary, GetProcAddress, GetModuleHandle, or any of the other OS services that require that same lock. Even worse, if you call SuspendThread on a thread that is in the middle of exception dispatching inside the kernel, a subsequent GetThreadContext or SetThreadContext can actually produce a blend of the register state at the point of the suspension and the register state that was captured when the exception was triggered. If we attempt to modify a thread’s context (perhaps bashing the EIP – on X86 – to redirect the thread’s execution to somewhere it will synchronize with the GC or other managed suspension), our update to EIP might quietly get lost." I guess we just need to have races no worse than in Windows :-) About RT signals - I would tread carefully here. RT signals are a precious resource. The queue is not very deep, and it's *per system* on Linux IIRC. When I used RT signals for I/O, they overflowed the queue all the time -- and if any program in the system is doing that, it affects your program, since the queue is shared. - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

wine under cygwin
by James Hawkins 07 Nov '04

07 Nov '04

I'm trying to compile wine under cygwin, but I am getting this error: Entering directory `/home/James Hawkins/wine/dlls/dsound/tests' gcc capture.o ds3d.o ds3d8.o dsound.o dsound8.o propset.o testlist.o -o dsound_test.exe -ldsound -lole32 -luser32 -lkernel32 -ldxguid -luuid -ldxerr8 /usr/lib/w32api/libdxguid.a(dxguid.o)(.rdata+0x1f20):dxguid.c: multiple definition of `_DSPROPSETID_DirectSoundDevice' propset.o(.rdata+0x10):/home/James Hawkins/wine/dlls/dsound/tests/propset.c:62: first defined here /usr/lib/w32api/libdxguid.a(dxguid.o)(.rdata+0x1f30):dxguid.c: multiple definition of `_CLSID_DirectSoundPrivate' propset.o(.rdata+0x0):/home/James Hawkins/wine/dlls/dsound/tests/propset.c:61: first defined here collect2: ld returned 1 exit status make[3]: *** [dsound_test.exe] Error 1 make[3]: Leaving directory `/home/James Hawkins/wine/dlls/dsound/tests' make[2]: *** [tests] Error 2 make[2]: Leaving directory `/home/James Hawkins/wine/dlls/dsound' make[1]: *** [dsound] Error 2 make[1]: Leaving directory `/home/James Hawkins/wine/dlls' make: *** [dlls] Error 2 Has anyone successfully compiled wine under cygwin, or does anyone have an idea of what the problem is? -- James Hawkins

1 0

winipcfg.exe issues
by Saulius Krasuckas 07 Nov '04

07 Nov '04

[s2@katleriai antras]$ /sbin/ifconfig | grep ^[^\ ] eth0 Link encap:Ethernet HWaddr 00:50:22:80:F0:49 lo Link encap:Local Loopback ppp0 Link encap:Point-to-Point Protocol If run winipcfg with Wine, it lets me to change the adapter I want to inspect by selecting its name in combox (as usually). But if I hold the down-key pressed down for some seconds, Wine terminates the application: [s2@katleriai antras]$ wine /home/s2/cc/Program\ Files/winipcfg.exe wine client error:21: no fd received for handle 88 While the key is pressed, adapter info is being periodically refreshed. Does that means the app leaks some handle? Or is this a bug in Wine? What debug channel would you recommend to use to see more details on this?

1 0

SetupComm insize 1600 outsize 1600
by MediaHost (TM) 07 Nov '04

07 Nov '04

Hi Wine Developers, Question: I need to use a Win app on Linux and everything seams fine, except that the communication with the serialport doesn't work. Well, also here, everything seams fine to me, so I want to get your advice. The only thing I could see is the unimplemented stub for "SetupComm insize outsize". Can I set it by my own (setserial) or what's the meaning of it anyway? The output below seams to me pretty good...: fixme:comm:SetupComm insize 1600 outsize 1600 unimplemented stub trace:comm:GetCommState handle 0x54, ptr 0x778ef948 trace:comm:GetCommState OK trace:comm:GetCommState bytesize 8 baudrate 2400 fParity 0 Parity 0 stopbits 1 trace:comm:GetCommState ~IXON ~IXOFF trace:comm:GetCommState fOutxCtsFlow 0 fRtsControl 1 trace:comm:GetCommState fOutxDsrFlow 0 fDtrControl1 trace:comm:GetCommState ~CRTSCTS trace:comm:SetCommState handle 0x54, ptr 0x778ef948 trace:comm:SetCommState bytesize 8 baudrate 1200 fParity 0 Parity 0 stopbits 1 trace:comm:SetCommState ~IXON ~IXOFF trace:comm:SetCommState fOutxCtsFlow 0 fRtsControl 1 trace:comm:SetCommState fOutxDsrFlow 0 fDtrControl1 trace:comm:EscapeCommFunction handle 0x54, function=5 trace:comm:EscapeCommFunction SETDTR trace:comm:EscapeCommFunction handle 0x54, function=4 trace:comm:EscapeCommFunction CLRRTS trace:comm:SetCommTimeouts (0x54,0x778ef934) trace:comm:PurgeComm handle 0x54, flags 4 trace:comm:PurgeComm handle 0x54, flags 8 ]# cat /proc/tty/driver/serial serinfo:1.0 driver:5.05c revision:2001-07-08 0: uart:16550A port:3F8 irq:4 baud:2400 tx:11 rx:0 RTS Best Regards Signer: Eddy Nigg Company: StartCom Linux at www.startcom.org MediaHostT at www.mediahost.org Skype: startcom

2 2

Scrollbars
by Nicolai Kuntze 07 Nov '04

07 Nov '04

Hi, I have played with my continuing bug (#2302) but I have some problems understanding the meaning of the output: fixme:win:GetWindowModuleFileNameA GetWindowModuleFileNameA(hwnd 0x40032, lpszFileName 0x40670548, cchFileNameMax 80) stub! trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=1 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=1 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=2 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=2 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 trace:scroll:SetScrollInfo hwnd=0x10074 nBar=1 info=0x406715d4, bRedraw=1 trace:scroll:SCROLL_SetScrollInfo hwnd=0x10074 bar=1 mask=4 pos=3 trace:scroll:SCROLL_SetScrollInfo curVal=0 nPos=3 trace:scroll:SCROLL_SetScrollInfo new values: page=1 pos=0 min=0 max=0 trace:scroll:SCROLL_SetScrollInfo hide or disable trace:scroll:SCROLL_ShowScrollBar hwnd=0x10074 bar=1 horz=0, vert=0 If my blue bar in the list disappears pos Value counts how many lines under the window I am. I have added a little debug to follow the source ... From the developer I got the following snipplet: int SViewLow::ViewSetScrollY( int PPos, int PMax, int PPage) { SCROLLINFO Scroll; memset( &Scroll, 0, sizeof( Scroll)); Scroll.cbSize= sizeof( SCROLLINFO); Scroll.fMask= 0; if (PPos!=-1) Scroll.fMask|= SIF_POS; if (PMax!=-1) Scroll.fMask|= SIF_RANGE; if (PPage!=-1) Scroll.fMask|= SIF_PAGE; Scroll.nPos= PPos; Scroll.nPage= PPage; Scroll.nMax= PMax-1; return SetScrollInfo( (HWND)ViewGetHWND(), SB_VERT, &Scroll, TRUE); } Does anyone has an idea what this could be? Yours, Nicolai

1 0

Re: D3D8
by Ann and Jason Edmeades 07 Nov '04

07 Nov '04

All I can say is any assistance with the d3d8/9 stuff is very gratefully accepted! If you have any questions or want help, feel free to drop me a note or post on wine-devel, and I'll try to respond. As per Lionel's note, I'm trying to move all the code into wined3d and make d3d8 and d3d9 call it, effectively making only one place to maintain so there is a lot of churn at the moment. It should settle in a couple of months (Once I get my latest patch in, things will move faster as well, once I know the way to solve certain problems). If you want suggestions as to what to work on, there's enough areas :-) - One I would say needs doing at some point is to take eg. 3dMark2002se, and get figures for it (I'd be interested if someone has a dual boot windows/linux machine to get comparisons on time), and try some profiling to work out where the time is spent and speed things up! - Apart from that, pick a game, and get the graphics right! - Or search the web for d3d8 (or 9, when it's there) demos which don't work and you have the source as well to, as you then know where to target in Jason

1 0

STL with WINE problems
by Dagan Shai 07 Nov '04

07 Nov '04

Hi, I'm trying to compile a C++ file using WINE. The file includes STL's map. I am using STLPort with WINE. I get a long list of errors starting with: /starhome/iu/wine/include/wine/msvcrt/cstdlib:97: `div' not declared /starhome/iu/wine/include/wine/msvcrt/cstdlib:102: `ldiv' not declared /starhome/iu/wine/include/wine/msvcrt/cstdlib: In function `ldiv_t std::div(long int, long int)': /starhome/iu/wine/include/wine/msvcrt/cstdlib:122: `ldiv' undeclared (first use this function) /starhome/iu/wine/include/wine/msvcrt/cstdlib:122: (Each undeclared identifier is reported only once for each function it appears in.) /starhome/iu/wine/include/wine/msvcrt/cstdlib: At global scope: /starhome/iu/wine/include/wine/msvcrt/cstdlib:138: `lldiv_t' not declared /starhome/iu/wine/include/wine/msvcrt/cstdlib:139: `_Exit' not declared ... I'm using msvcrt as the C library. I saw a previous posting with the same problem, and I've tried the various solutions suggested (toggling -mno-cygwin, using STLPort) but that did not work. Suggestions welcome. Thanks, Shai Dagan

1 0

D3D8
by Joel Konkle-Parker 07 Nov '04

07 Nov '04

In trying to get Guild Wars to work, I've come across the lack of D3D8 support in Wine. I'd like to try to help on this front, but I'm not sure who to talk to or where to start. Cedega has D3D8 support, but I'm presuming that if I contribute there, my code won't migrate back to base Wine. Can anyone lead me in the right direction here? -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

4 4

Re: Frame and Button Edges
by Dan Kegel 07 Nov '04

07 Nov '04

williampoetra(a)yahoo.com wrote: > Patch submitted to wine-cvs. Hope it gets committed :) I hope you meant wine-patches. wine-cvs is only for things that have already been committed, I think... - Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

2 1

Countering arguments against Wine
by Dan Kegel 07 Nov '04

07 Nov '04

I've run into people several times who dislike the fact that I advocate or even work on the Wine project, because they feel that it takes focus away from working on the Linux desktop. I beg to differ, but I've never had a really snappy comeback for them. It happened again today, and this time it occurred to me I should write a page on the topic to organize my thoughts. Here it is: http://www.kegel.com/wine/why.html Comments welcome. Thanks, Dan -- Trying to get a job as a c++ developer? See http://kegel.com/academy/getting-hired.html

6 11

Re: MSIEXEC: Make installation of InstMsiA.exe possible
by Dmitry Timoshkov 06 Nov '04

06 Nov '04

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > @@ -523,6 +524,11 @@ > { > InstallUILevel = INSTALLUILEVEL_BASIC|INSTALLUILEVEL_PROGRESSONLY; > } > + else if(!strcasecmp(argv[i]+2, "b+!")) Please use lstrcmpiA instead of strcasecmp. A difference between unix system locale and current ANSI code page in Wine might lead to undesired side effects. -- Dmitry.

2 1

Re: MSIEXEC: Make installation of InstMsiA.exe possible
by Tobias Burnus 06 Nov '04

06 Nov '04

Hello, Hans Leidekker wrote: > I have an InstMsiA.exe that uses two undocumented msiexec command line > parameters: /m and /D and uses an undocumented modifier (!) with the /q > parameter. Our msiexec fails when it encounters these and responds with > a usage message. For /m I found the following, don't know whether it helps. Tobias According to http://safariexamples.informit.com/0321133455/ExecutiveSoftware/Diskeeper/D… msiexec /m MIF /qn /I DKMSI INSTALLDIR="C:\MyDir" Where MIF represents the Management Information File -- 8 characters maximum.

1 0

Re: keyboard: ISO_Left_Tab
by Andreas Mohr 06 Nov '04

06 Nov '04

Hi, On Sat, Nov 06, 2004 at 07:30:20AM -0800, Walt Ogburn wrote: > + /* Special case: X turns shift-tab into ISO_Left_Tab. */ > + /* Here we change it back. */ > + if ((ret == 0) && (keysym == XK_ISO_Left_Tab)) > + { > + ret = 1; > + lpChar[0] = 0x09; > + } > + > if (ret == 0) > { > BYTE dead_char; Two comments: a) A return value of 0 probably is much more common than the XK_ISO_Left_Tab keysym, so the XK_ISO_Left_Tab check should be first to not have to check both conditions in the event that ret is 0. (the compiler might do reordering according to check probability, though, but OTOH I doubt that it knows which one is more likely) b) there's another if (ret == 0) *right below*, so why not add the XK_ISO_Left_Tab check there? Again useless waste of resources... Thanks for this patch! Andreas Mohr

2 1

Re: winuser.h : remove a fixme and "add" some things
by Dmitry Timoshkov 06 Nov '04

06 Nov '04

"Rémi Assailly" <remi.assailly(a)free.fr> wrote: > Excuse me, > I did not want to write that ULONG_PTR is 32 in Win32 _and_ Win64, but I > wanted to write that ULONG_PTR and DWORD were the same. I was wrong here > : DWORD is always 32bits, no ? Right, DWORD is a 32-bit entity in both Win32 and Win64. > So, why there are a lot of ULONG_PTR instead of DWORD if it is not to be > ported in Win64 ? That's there exactly for that purpose - to be portable to Win64. That's a variable that can potentially hold a pointer or a handle value. Win64 is not binary compatible with Win32, but is aimed to be source compatible. Read some docs about porting to Win64 for further details. -- Dmitry.

1 0

err:keyboard:X11DRV_ToUnicodeEx Please report:
by Jon Griffiths 06 Nov '04

06 Nov '04

Hi, Duly reporting: err:keyboard:X11DRV_ToUnicodeEx Please report: no char for keysym FE20 (ISO_Left_Tab) : err:keyboard:X11DRV_ToUnicodeEx (virtKey=9,scanCode=F,keycode=17,state=1) This happens when I shift-tab in any Wine app. System is mdk 10.0/wine cvs and this message has been there for several months at least (when I first noticed). I'm happy to provide more info on request if someone knows how to fix this. Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

2 2

Frame and Button Edges
by William Poetra Yoga H 06 Nov '04

06 Nov '04

This is about frame edges and button edges on WINE... On Windows, the default behavior is the outer left-top edge of a frame is painted with COLOR_BTNFACE and the inner left-top is colored with something white (COLOR_BTNHILIGHT maybe???). But for caption buttons and push buttons, they are reversed. In WINE, the abovementioned edges, whether for a frame or for a button, are always: 1. outer left-top is COLOR_BTNFACE 2. inner left-top is white This is probably not so noticable, but it's actually quite disturbing if you ask me... For comparison, in ReactOS (0.2.4), caption buttons' edges, and toolbar buttons' edges are drawn correctly, but those of push buttons aren't. So the problem is: how do we reproduce Windows' default behavior? I have tried the styles for DrawEdge, and even made a program to try it out, but I can't seem to generate the correct edges for buttons. The source to edges.c is attached. I wanted to attach the executable but... Can I attach it? Oh, and this is off-topic: How do I use Tahoma as the default font for WINE, like in the screenshots? I think Bitstream Vera fonts look weird for Windows apps... I've searched google but found nothing that helped me... __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com

1 1

Re: winuser.h : remove a fixme and "add" some things
by Dmitry Timoshkov 06 Nov '04

06 Nov '04

"Rémi Assailly" <remi.assailly(a)free.fr> wrote: > There were a fixme warning us that a structure were not sure ( line 1898 ). > I checked it and it seems correct. The only differences I found are : > - ULONG_PTR dwItemData instead of DWORD dwItemData which is the same > thing with win32 and also win64 ( according to what I understood ) No, they are not the same. ULONG_PTR is a 64-bit entity in Win64, but 32-bit in Win32. -- Dmitry.

1 0

Public domain source in wine
by Michael Jung 06 Nov '04

06 Nov '04

Hello, I would like to use source code from LibTomCrypt (http://libtomcrypt.org) in my implementation of rsaenh.dll (which I still hope has a remote chance of being accepted into wine ;-), in order to get rid of the OpenSSL dependencies. LibTomCrypt is in the public domain. I have two questions: 1. What is the legaly correct way to do this? As I understand it, public domain source can simply be taken as is and re-licensed under the LGPL. Is this correct? Am I allowed to remove the headers in the original file, which state that the code is public domain? How do you generally acknowledge the original author? 2. A more technical question: LibTomCrypt's original sources are highly customizable (A lot of conditional compilation and hook-functions). Since we have fairly special requirements for rsaenh, I could cut down the source code a lot. However, this would make it harder to incorporate code from a newer version of libtomcrypt, once it becomes available. Which way is preferable? Having less code or beeing easily upgradeable? Greetings, Michael

4 3

RE: [dx9-12] Major change to design
by Ann and Jason Edmeades 05 Nov '04

05 Nov '04

Ha! Spot the half written note I started a week ago when I first was trying to word a reply, which was nicely hidden off the end of my previous note! - Sorry about that :-) Jason

1 0

Re: [dx9-12] Major change to desgin
by Alexandre Julliard 05 Nov '04

05 Nov '04

"Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: > I think this patch should keep you happy (It doesn't do any of the > IWineUserDevice stuff as the code isn't ready for it, but does the dual ref > count + adds Set/Get Stream source). Let me know if you have problems with > it. Looks much better yes, thanks. There's still something strange here: > + /* Not recording... */ > + if (oldSrc != NULL) { > + IWineD3DVertexBuffer_Release(oldSrc); > + IUnknown_Release((IUnknown *)((IWineD3DVertexBufferImpl *)oldSrc)->resource.parent); /* Released an internal reference to a VB */ > + } > + if (pStreamData != NULL) { > + IWineD3DVertexBuffer_AddRef(pStreamData); > + IUnknown_AddRef((IUnknown *)((IWineD3DVertexBufferImpl *)pStreamData)->resource.parent); /* Gained an internal reference to a VB */ > + } You shouldn't need to AddRef the parent, that's up to the object that holds the pointer (also you should do the AddRef before the Release in case old and new are the same object). -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: ez-cdda sleep
by Alexandre Julliard 05 Nov '04

05 Nov '04

Mike Hearn <mike(a)navi.cx> writes: > I've attached a patch which fixes this for me. It's not too tricky, if > you want me to explain it though I'm happy to do so. > > This feels like the sort of patch Alexandre will rewrite to his liking > anyway :) Actually I already did a similar hack in the Crossover tree; it's not merged because it's full of races (which at first glance seems to be the case with yours too). -- Alexandre Julliard julliard(a)winehq.org

5 6

disk-space ?
by Dietrich Teickner 05 Nov '04

05 Nov '04

0[N:\wine]cvs -z0 update -kb -dP ? .cvspass cvs server: Updating . cvs server: failed to create lock directory for `/home/wine' (/home/wine/#cvs.lo ck): No space left on device cvs server: failed to obtain dir lock in repository `/home/wine' cvs [server aborted]: read lock failed - giving up

2 1

Re: SEH docs
by Filip Navara 05 Nov '04

05 Nov '04

1 0

re: Wine dll testing state of affairs
by Daniel Kegel 05 Nov '04

05 Nov '04

Jakob Eriksson (jakov_at_vmlinux.org) wrote: > I looked around in the Wine dlls tree to see how many dlls had a "tests" > directory in them. > Quite a few had, but these did not: > ... > lzexpand > ... FWIW, I think someone's about to submit tests for lzexpand. - Dan

1 0

running an exe from within a wined exe
by Helder Carvalho 05 Nov '04

05 Nov '04

Hi, I'm using Wine to run on linux, an application build with vc++ 6.0. I've got no problems running it, except when i try to create a child process to call a a different executable that performs tasks needed to the main process, I get no error or system failure, the process simply fails to be created.. The code i've done to do this is shown below. Do i need to invoke wine on the command line (which i've done with no better results) again or is it something more complex? Thanks in advanced, Helder Carvalho //////////////////////////////////////CODE//////////////////////////////////////////////////////////// CString commandLine; commandLine = "\""+workingDirectory+"\\jpsec.exe\" -i "+textNameFolder+" -urng "+resultFile+""; // Converts CString to 'const char*' to further covert to LPSTR const char* comLine; int n = commandLine.GetLength(); comLine = commandLine.GetBuffer(n); // Start the child process. if( !CreateProcess(NULL, //Example "\"JPSecWin32\\jpsec.exe\" -i .\\..\\..\\JPSecWin32\\lenna_enc.jp2 -o .\\..\\..\\JPSecWin32\\temp5.jp2 -k .\\..\\..\\JPSecWin32\\keys.txt -dec", // No module name (use command line). LPSTR(comLine), // Command line. NULL, // Process handle not inheritable. NULL, // Thread handle not inheritable. FALSE, // Set handle inheritance to FALSE. 0, // No creation flags. NULL, // Use parent's environment block. NULL, // Use parent's starting directory. &si, // Pointer to STARTUPINFO structure. &pi ) // Pointer to PROCESS_INFORMATION structure. ) { AfxMessageBox("CreateProcess failed." ); } ________________________________________________ Message sent using UebiMiau 2.7.2

1 0

task modal messagebox implementation
by Ivan Leo Puoti 04 Nov '04

04 Nov '04

I'm trying to implement taskmodal message boxes, what I've done up to now is attached. The problem is that with my current implementation if a window is disabled before MessageBox*() is called, it is then enabled after the user closes the messagebox, and Lionel has tested this on win98 and this is not what window does. I use EnumThreadWindows to loop trough all the top level windows in the thread and disable them, ideally I should check the status of each window, save the handle of each window that is disabled before MessageBox was called, and not enable them after DialogBoxIndirectParamW has returned. But as the EnumThreadWndProc function has no way of returning information directly to the caller of EnumThreadWindows I'm unsure where I should save this data. Should I use a global variable, a temp reg key, or am I taking the wrong approach to this problem? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: gdi/dib.c GetDIBits
by Huw D M Davies 04 Nov '04

04 Nov '04

On Wed, Nov 03, 2004 at 09:24:08PM -0800, Walt Ogburn wrote: > > Changelog: > Take color info from existing hdc instead of creating a new memory HDC. > > > Index: dlls/gdi/dib.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/dib.c,v > retrieving revision 1.7 > diff -u -r1.7 dib.c > --- dlls/gdi/dib.c 2 Nov 2004 05:23:49 -0000 1.7 > +++ dlls/gdi/dib.c 4 Nov 2004 05:08:24 -0000 > @@ -563,7 +559,7 @@ > same color depth then get the color map from it */ > if (bmp->dib && bmp->dib->dsBm.bmBitsPixel == bpp) { > if(coloruse == DIB_RGB_COLORS) { > - HBITMAP oldbm = SelectObject(memdc, hbitmap); > + HBITMAP oldbm = SelectObject(hdc, hbitmap); > unsigned int colors = 1 << bpp; > > if (core_header) This won't always work since hdc does not necessarily have to be a memory dc. I think what you want to do is to store the dib colour table in the gdi bmp->dib structure rather than in the driver's (x11drv) one. Then retrieving the colour table can be done by simply accessing the data directly, rather than through a call to GetDIBColorTable. Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Re: Re: Fix for metafile test
by Chris Morgan 04 Nov '04

04 Nov '04

> Is that a service option or what? I don't really know > anything about Windows services. If you can fix this issue > in winrash please do so. > I've tried enabling this option and then popping up a dialog box and no dialog was displayed. It should be an easy change to re-enable this option. I'll try it tonight. What should I look for to see if this metafile test runs correctly? Chris

4 4

Re: Public domain source in wine
by Scott Ritchie 04 Nov '04

04 Nov '04

>1. What is the legaly correct way to do this? As I understand it, >public domain source can simply be taken as is and re-licensed under >the LGPL. Is this correct? Am I allowed to remove the headers in the >original file, which state that the code is public domain? How do you >generally acknowledge the original author? Actually, public domain is a legal term meaning without copyright, so we can do whatever we want with the code - change it, cut it into pieces, even claim we made it. There is no public domain license, so to speak, since something in the public can be used without a license. As a matter of courtesy, however, citing the author in the source is a good idea. This is, of course, assuming that the code actually is in the public domain, and not licensed under something like some forms of BSD, which require acknowledgement in the source somewhere. -Scott

1 0

Has anyone done this before?
by Bill Medland 04 Nov '04

04 Nov '04

I would be interested in knowing if anyone has succeeded with this before I start getting too carried away trying to fix the errors. When I tried I got an X error (BadWindow). I am sitting at a RedHat 8.0 computer with a VPN tunnel to a remote network (Microsoft VPN server) ssh through that VPN to a remote computer running RHEL3 (ES) Set DISPLAY back to my end of the VPN tunnel, to my display Prove it works by typing xterm in the ssh session Try running winemine After rebuilding the cached metrics it momentarily (in the non-American sense) opens something and then closes it and gives me the X error. Does this stand a chance of actually working? -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel