- wine-devel - winehq.org

Re: Revised Wine User Guide Introduction
by Dimitrie O. Paun 13 Oct '04

13 Oct '04

On Sat, Oct 09, 2004 at 06:30:19PM -0700, Scott Ritchie wrote: > The version 0.9 todo list (bug 85) specifies the need for a rewritten > intro to the Wine User Guide. > > This patch is that rewritten intro. It rewords things to make Wine > easier to understand for the new user, gives it a more professional > look, and removes some outdated information. Cool. Can you please also reformat the long lines in the spirit of the original format? It makes it much more pleasant to work with... -- Dimi.

3 2

window caption buttons
by William Poetra Yoga Hadisoesen 13 Oct '04

13 Oct '04

This is related to my last post. The buttons wine draw actually have wrong borders, like for example a normal window has this close button: ::::::::::::::::::::::::::::::00 :: 3300 :: 3300 :: #### #### 3300 :: #### #### 3300 :: ######## 3300 :: #### 3300 :: ######## 3300 :: #### #### 3300 :: #### #### 3300 :: 3300 :: 3300 ::333333333333333333333333333300 00000000000000000000000000000000 where: '::' is color ffffff '33' is color 808080 '00' is color 000000 (404040 in win2k & winxp, not sure about winme) ' ' is the background (default is c0c0c0, but d4d0c8 in win2k...) '##' is black but wine draws it as: ================================00 ==::::::::::::::::::::::::::::3300 ==:: 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: ######## 3300 ==:: #### 3300 ==:: ######## 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: #### #### 3300 ==:: 3300 ==33333333333333333333333333333300 0000000000000000000000000000000000 where '==' is some other color between '::' and ' ' There are two mistakes: 1. The borders aren't correct. For an active unpushed button, there should only be one "top-left edge". For a pushed button, there should be only one "bottom-right edge" (and inner/outer "top-left edge"s) 2. The 'X' should be drawn a bit more to the right and higher, and smaller. Smaller, because with the correct edges, we need to have (for an unpushed button) a spacing of 3, 2, 2, 2 pixels for the left, top, right, bottom sides respectively, between the 'X' and the edges (look at the correct example above). Higher and more to the right, because after making the 'X' smaller, it should have the correct spacing. Comments please... :) _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

3 4

Re: PATCH: dlls/comctl32/tests/imagelist.c
by Vincent Béron 13 Oct '04

13 Oct '04

Le mer 13/10/2004 à 04:39, Gerald Pfeifer a écrit : > Notice by my nightly builds. This function is not used at all, so > an alternative approach might be to completely yank it. It's used (in a #if 0'd) block to dump differences detected in a test, if the comparison fails. Yes it's not used currently, but I guess it is (or has been) useful in understanding why some tests failed. Maybe we can make the dumping not a compile-time choice but a runtime choice (and default on not doing it)... Vincent

1 0

Wine on Debian on sun4m
by Saulius Krasuckas 13 Oct '04

13 Oct '04

I've decided to try compiling Wine on the Sun SPARC station 4. This machine is running Debian Woody 3.0r2. I am first time Debian installer. Is it completely wrong idea? If no, then going next: I've chose "C and C++ development" task and finished it (by tasksel), so all the related packages were installed. Now, after the run of "./configure" I run "make depend" and get into trouble: s2@austechia:/usr/src/wine-20040914$ make depend cd ./tools && make `basename tools/makedep` make[1]: Entering directory `/usr/src/wine-20040914/tools' gcc -c -I. -I. -I../include -I../include -DLEX_OUTPUT_ROOT="\"lex.yy\"" -Wall -pipe -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o makedep.o makedep.c In file included from makedep.c:23: ../include/wine/port.h:53: conflicting types for `mode_t' /usr/include/sys/types.h:71: previous declaration of `mode_t' ../include/wine/port.h:56: conflicting types for `off_t' /usr/include/sys/types.h:89: previous declaration of `off_t' ../include/wine/port.h:59: warning: redefinition of `pid_t' /usr/include/sys/types.h:99: warning: `pid_t' previously declared here ../include/wine/port.h:71: conflicting types for `fsblkcnt_t' /usr/include/sys/types.h:247: previous declaration of `fsblkcnt_t' ../include/wine/port.h:74: conflicting types for `fsfilcnt_t' /usr/include/sys/types.h:251: previous declaration of `fsfilcnt_t' make[1]: *** [makedep.o] Error 1 make[1]: Leaving directory `/usr/src/wine-20040914/tools' make: *** [tools/makedep] Error 2 I would like to find the primary reason of this, but am not sure about all the possible combinations of header files. Should I post the output of running ./configure?

3 5

Re: [WineHQ] s/Forums/Mailing Lists/
by Jeremy Newman 13 Oct '04

13 Oct '04

I committed this, but when you go to the page it calls itself Forums still. My instinct was to s/Forums/Mailing Lists/g on forums.template. But I held off to see if anyone had a better idea on how to layout this page. As it stands right now, it does not make sense. On Mon, 2004-10-11 at 10:51, Dimitrie O. Paun wrote: > The latest cleanup patch seems to have reverted this change > that was discussed and implemented long ago. > > ChangeLog > s/Forums/Mailing Lists/ -- _ _ WebGeek/SysAdmin CodeWeavers -= http://www.codeweavers.com | \| |_____ __ ___ __ __ _ _ _ -= http://www.dracowulf.com | .` / -_) | | / ' \/ _` | ' \ -= mailto:jnewman@codeweavers.com |_|\_\___|\_/\_/|_|_|_\__,_|_||_| -= ICQ: 1711553 Yahoo: laxdragon

3 2

Re: winmm/time.c change
by Dmitry Timoshkov 13 Oct '04

13 Oct '04

"Jeremy White" <jwhite(a)codeweavers.com> wrote: > static void TIME_TriggerCallBack(LPWINE_TIMERENTRY lpTimer) > { > - TRACE("before CallBack => lpFunc=%p wTimerID=%04X dwUser=%08lX !\n", > - lpTimer->lpFunc, lpTimer->wTimerID, lpTimer->dwUser); > + TRACE("%04lx:CallBack => lpFunc=%p wTimerID=%04X dwUser=%08lX dwTriggerTime %ld(delta %ld)\n", > + GetCurrentThreadId(), lpTimer->lpFunc, lpTimer->wTimerID, lpTimer->dwUser, > + lpTimer->dwTriggerTime, GetTickCount() - lpTimer->dwTriggerTime); That "%04lx:"/GetCurrentThreadId() shouldn't be there, that's the job of +tid debug channel. -- Dmitry.

2 1

'make check' hangs after crash in msvcrt/tests?
by Dan Kegel 12 Oct '04

12 Oct '04

With this morning's cvs, 'make check' hangs after this point ... make[3]: Entering directory `/home/dank/winebuild/dlls/msvcrt/tests' ../../../../wine/tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so ../../../../wine/dlls/msvcrt/tests/cpp.c && touch cpp.ok fixme:msvcrt:__unDNameEx ((nil),.?AVtest1@@,0,0x40809010,0x40808fcc,(nil),2800) stub! wine: Unhandled exception (thread 005e), starting debugger... Usage: winedbg [--auto] [--gdb] cmdline Sounds like it's invoking winedbg wrong? Also, is there a way to say "I'm running these tests unattended, please don't wait for input"? - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

2 1

cvs update mystery
by Dan Kegel 12 Oct '04

12 Oct '04

Last night I did a cvs update and built, and got a build failure dlls/amstream/amstream.c:40: parse error before "AM_Vtbl" Evidently cvs update failed to update the files in dlls/amstream, as it failed to pick up that part of this change: 2004-08-12 Alexandre Julliard <julliard(a)winehq.com> * dlls/amstream/amstream.c, dlls/amstream/main.c, dlls/avifil32/acmstream.c, dlls/avifil32/avifile.c, ... dlls/winmm/wineaudioio/audio.c, dlls/winmm/wineoss/audio.c, include/objbase.h, include/rpcproxy.h: Get rid of the non-standard ICOM_VTABLE macro. Repeated 'cvs update's didn't fix it. cd'ing into dlls/amstream and doing a cvs update directly in that directory worked, though, and got me new versions of the files in that directory. How strange. Maybe I'll stop using this newfangled cvs system and fall back on the old reliable ... uh, wait, cvs *is* the old reliable one... grr... - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

3 2

Re: Added DWebBrowserEvents and WebBrowser declaration
by Robert Shearman 12 Oct '04

12 Oct '04

Jacek Caban wrote: > Changelog: > - Added dispinterfaces: DWebBrowserEvents and DWebBrowserEvents2 > - Added coclass: WebBrowser > - Added exdispid.h > You forgot the patch. Rob

1 0

COM inheritence
by Ann and Jason Edmeades 12 Oct '04

12 Oct '04

Hiya, If you havent noticed, I'm trying to port the d3d8 code into wined3d and make it common for use from d3d9, and this is all COM objects. I have come across something which in theory would enable me to tidy my code simply, but I cant see how to make it work in C. Now I have a class, for example FRED who implements some common functions, and all the code for it would be in fred.c. I also have a subclass, defined called JIM, which needs to have entrypoints as per fred, plus some more, and its code resides in jim.c. Still with me...? Now previously, inside jim, I have duplicated all the common functions, but I want to avoid this and just call the one definition. My plan was to change the Vtbl to look like: IJimVtbl Jim_Vtbl = { IJimImpl_QueryInterface, IJimImpl_AddRef, IJimImpl_Release, IFredImpl_CommonFunc1, IFredImpl_CommonFunc2, : IJimImpl_UniqueFunc1 etc } I was also ensuring the variable definitions in the IJimImpl structure map precisely over the IFredImpl structure, before any unique variables are defined (I think this is a necessity for emulating subclassing in C?). Now, obviously if the common funcs need changing I can copy in the code, and change the vtbl to have a local override but at the moment I dont need to (they are mostly stubs even in the d3d8 code today). However, doing this fails to compile - It wont allow me to have a vtbl in jim.c which includes pointers to functions which are in fred.c, even if I have extern prototypes defined. Basically this is because array initialization requires constant values. However, this would seem something which is so common - ie inheritence is used all over the place. How do people handle this? I've looked through a few places in the code and cant see how this can be done. I could 'pretend' by initializing the Vtbl as I create the com object and do some LoadLibrary type dynamic addressing but I really want link time resolution not load time resolution. One solution would be to put the common routines in a header file, and #include it, but code in headers or #including modules is uaually frowned upon! I cant see any sensible way of doing this and I'd rather not do lots of code duplication if avoidable as this common class is used in about 7 other classes! Jason

2 3

Re: Fix for bug 824 - proper handling of REG_MULTI_SZ
by Dimitrie O. Paun 12 Oct '04

12 Oct '04

> * - the modification time optionally follows the key name > - * - REG_EXPAND_SZ and REG_MULTI_SZ are saved as strings instead of hex > + * - REG_EXPAND_SZ are saved as strings instead of hex > + * - REG_MULTI_SZ are saved hex (as of 10/10/04 -- see Bug 824) > */ Well, I don't know if the fix is correct, but if it is, just remove the comment instead of saying it's fixed, otherwise we risk cluttering the real issues to the point where they are useless. -- Dimi.

1 0

Re: Fix for bug 824 - proper handling of REG_MULTI_SZ
by Chris Morgan 12 Oct '04

12 Oct '04

It would be useful to roll this test into the integrated winetests so we can check this behavior on all windows platforms and prevent it from breaking in the future. Chris > > From: Randy Galbraith <randy.galbraith(a)cox.net> > Date: 2004/10/11 Mon PM 09:19:42 EDT > To: wine-patches(a)winehq.org > Subject: Fix for bug 824 - proper handling of REG_MULTI_SZ > > This proposed patch addresses the concern raised by bug 824. This patch > changes the handling of REG_MULTI_SZ from REG_SZ to REG_BINARY. For > more details follow this URL: > > http://bugs.winehq.org/show_bug.cgi?id=824 > > To see a test program follow this URL: > > http://members.cox.net/~rgalbraith10/wine/bug824/demo824.c > http://members.cox.net/~rgalbraith10/wine/bug824/Makefile > > ===begin diff -u output of wine/server/registry.c 1.60=== > --- registry.c- 2004-10-10 10:46:15.000000000 -0700 > +++ registry.c 2004-10-10 12:26:35.000000000 -0700 > @@ -157,7 +157,8 @@ > * - strings and key names can contain \x escapes for Unicode > * - key names use escapes too in order to support Unicode > * - the modification time optionally follows the key name > - * - REG_EXPAND_SZ and REG_MULTI_SZ are saved as strings instead of hex > + * - REG_EXPAND_SZ are saved as strings instead of hex > + * - REG_MULTI_SZ are saved hex (as of 10/10/04 -- see Bug 824) > */ > > > static inline char to_hex( char ch ) > @@ -195,7 +196,6 @@ > { > case REG_SZ: > case REG_EXPAND_SZ: > - case REG_MULTI_SZ: > if (value->type != REG_SZ) fprintf( f, "str(%d):", value->type ); > fputc( '\"', f ); > if (value->data) dump_strW( (WCHAR *)value->data, value->len / > sizeof(WCHAR), f, "\"\"" ); > @@ -1123,7 +1123,7 @@ > { "\"", 1, REG_SZ, REG_SZ }, > { "str:\"", 5, REG_SZ, REG_SZ }, > { "str(2):\"", 8, REG_EXPAND_SZ, REG_SZ }, > - { "str(7):\"", 8, REG_MULTI_SZ, REG_SZ }, > + { "hex(7):", 8, REG_MULTI_SZ, REG_BINARY }, > { "hex:", 4, REG_BINARY, REG_BINARY }, > { "dword:", 6, REG_DWORD, REG_DWORD }, > { "hex(", 4, -1, REG_BINARY }, > ===end diff -u output=== > This is my first attempt at creating a patch for wine. Any feedback is > greatly appreciated. > > Kind regards, > -Randy Galbraith > > >

1 0

winetest fails enumerating test files
by Saulius Krasuckas 12 Oct '04

12 Oct '04

It shows some message-box telling: "Can't enumerate test files: 1813" Greping programs/winetest/main.c gives: | report (R_STATUS, "Counting tests"); | if (!EnumResourceNames (NULL, MAKEINTRESOURCE(TESTRES), | EnumTestFileProc, (LPARAM)&nr_of_files)) | report (R_FATAL, "Can't enumerate test files: %d", | GetLastError ()); | wine_tests = xmalloc (nr_of_files * sizeof wine_tests[0]); I guess this may be some regression (have been running winetest a whole month ago last time). Am I alone with this?

2 3

Re: wineserver contexts for Alpha
by Steven Edwards 12 Oct '04

12 Oct '04

Hi, --- Vincent B�ron <vberon(a)mecano.gme.usherb.ca> wrote: > There are two definitions of _CONTEXT for Alpha in winnt.h: one > protected by __ALPHA__ (added by Steven 2 years ago), and one > protected > by _ALPHA_, which is the same kind of protection as MSVC. Should we > dump > the __ALPHA__ one and change configure to define _ALPHA_ instead? Yes sorry dump the one I added. I totally missed it and did not have MSVC+PSDK installed then. Thanks Steven _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

1 0

tchar.h
by Martin Fuchs 11 Oct '04

11 Oct '04

Hello, can anyone explain to me, what's the exact reason for the following error message in wine/include/tchar.h: #if defined(_UNICODE) || defined(_MBCS) #error You must use msvcrt when building in Unicode/MBCS mode #endif It disallows inclusion of this <tchar.h> header file when using the _UNICODE define. Just a few lines later in this file there are the following definitions: /***************************************************************************** * tchar mappings */ #ifndef _UNICODE # ifndef _MBCS # include <string.h> # define WINE_tchar_routine(std,mbcs,unicode) std # else # include <mbstring.h> # define WINE_tchar_routine(std,mbcs,unicode) mbcs # endif #else /* _UNICODE */ # include <wchar.h> # define WINE_tchar_routine(std,mbcs,unicode) unicode #endif Again asking for "_UNICODE" ! So something can't be right with this. The <tchar.h> header should really define constants like _tcschr dependend on the _UNICODE define. But currently this doesn't work because of the error message described above. Either there should be a overriding "wine/include/msvcrt/tchar.h" file with different defintions. Or the error message "You must use msvcrt when building in Unicode/MBCS mode" is simply superfluous. Regards, Martin

2 1

Re: [Bug 2388] WM_NEXTDLGCTL changes the default button ID and does not restore default control identifier
by Alexandre Julliard 11 Oct '04

11 Oct '04

Katia Maculan <katia.maculan(a)isis-papyrus.com> writes: > part of the patch is not committed, is there a reason for that? Is > something wrong? It doesn't look right at all to do dialog management in the button code itself. Also, please submit a regression test showing that the proposed change is correct and that the current code is wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: wine-devel digest, Vol 1 #3011 - 15 msgs
by Rolf Kalbermatter 11 Oct '04

11 Oct '04

Vitaliy Margolen wrote: > Well, I tried to shuffle the order of creation of these > files. The results I got was as follows: > - On windows I was getting "sorted by name" order. > - On Linux I was getting creation order. Funny thing is I work on Suse Linux 9.0 with current wine CVS and IEnumIDList in the shelfolder test returns for me test.txt, testdir2, test1.txt, test2.txt, and test3.txt in that order. So I can't confirm the idea that Wine under Linux would always enumerate files in a directory nor in alphabetically order nor in order of creation. > I tested XP, 2003 and 98 all with same results. So my > assumption was that I would always get the "sorted by name" > order from windows no meter what. I could be wrong here. If > this is the case it has something to do with SHFolder's > heading information, that we currently ignore. If you mean the selected column in a shell folder view, that should not have any influence on the order of files returned for an IEnumIDList object. It does not and can't now about the column to use for ordering nor should it do any specific ordering AFAICS. This is supposed to be done by the IShellView through use of the IShellFolder's CompareIDs method Rolf Kalbermatter

3 2

Re: widl: added dispinterface and coclass
by Mike Hearn 11 Oct '04

11 Oct '04

Jacek Caban wrote: > Changelog: > - Added creation of dispinterface header > - Added creation of coclass header > - Added messages when fopen failes Cool! How far away are we from having widl generate the proxy/stub marshalling code? I started writing some COM test cases last night but it's really hard to test anything non-trivial without a test object that supports marshalling and I doubt Alexandre would want MIDL code in the test suite (or maybe he would, that is what we have to run after all ...) thanks -mike

2 4

RFC re winmm/time.c
by Jeremy White 11 Oct '04

11 Oct '04

Hi Folks, I ran into a problem with PowerPoint and winmm timer events, that has led me to radically alter this file. However, I'd appreciate a gut check from anyone more experienced with it than I. The fundamental problem is that Powerpoint does a timeBeginPeriod(1), trying to set timer resolution to 1 ms; we steadfastly discard that, and continue generating time updates and events on a roughly 10 ms interval, this can, in rare situations, lead to some awkward delays. Some investigation with a test program shows that most Windows systems start with a default resolution of 1 ms. This test program is attached; the 'average' reported at the top is the default resolution. Further, Windows seem to steadfastly ignore any timeBeginPeriod(x) where x > the current period. I surveyed about 6 systems; a mix on Win98/Win2k and Win XP. All but one rogue Win 2K system had a 1 ms timer interval (the rogue system had a 10 ms interval; why, I do not know). The MSDN pages suggest (but don't state clearly) that this is the expected behavior. This behavior essentially means that on most Windows systems the timer resolution of winmm is 1ms and can not be changed. So, question #1: anyone object if I fix the timer resolution at 1 ms? Next, if I make this change, it makes the code in time.c, which is fairly awkward imho, even less efficient. We'll basically be scanning a loop every ms for no particularly good reason. I couldn't stomach this, so I rewrote it. Question #2: anyone object to my change? I have tested it with my attached test program, and I appear to have gotten it right, but... Thoughts? Comments? Flames? Suggestions I go back to my day job? <grin> Cheers, Jeremy

3 5

Re: Warcraft 3 Copy Protection (regression?)
by Brian Gunlogson 11 Oct '04

11 Oct '04

Warcraft 3 will not run without a crack after the following commit: http://www.winehq.org/hypermail/wine-cvs/2004/03/0093.html If no one wants to tackle this immediately I'd like to fix it. Any ideas? Brian G. > > I don't know whether the difference was something about the version of WC3, or > > because I'd just upgraded to a 2.6 kernel, or because of the Wine > > version (20040309), but having upgraded Wine to 20040505 it no longer works. > Some work was done to load the copy protection drivers, it would be very nice to > get this working again. Can you try wine-20040408 to see if it works with that > version? You can then pinpoint the regression by running CVS regression testing, > instructions are at http://www.winehq.com/site/docs/wine-devel/cvs-regression > > Ivan. _______________________________ Do you Yahoo!? Express yourself with Y! Messenger! Free. Download now. http://messenger.yahoo.com

2 1

Preparing to do a Regression and Submitting Results
by Dan McGhee 11 Oct '04

11 Oct '04

I'm getting ready to do a regression on a situation for an application, Edit Studio 4, that I'm trying to get running in WINE. The description of the problem is difficult to put into words and I'd like to use a "before and after" set of screen shots plus the results of any appropriate traces. I'd like to post the results here for your consideration. However, I'm concerned about the size of the resultant files. Are there formal or informal limitations on the size of attachments for this list? Or is it more appropriate to use the information in a "bug report?" Thanks, Dan

2 2

winsock: errs and fixmes, unimplemented socket level
by Anssi Hannula 09 Oct '04

09 Oct '04

Hi! When I start Space Empires IV, I get the following lines: fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) fixme:winsock:convert_sockopt Unimplemented or unknown socket level err:winsock:WS_setsockopt Invalid level (65407) or optname (128) fixme:winsock:convert_sockopt Unknown SOL_SOCKET optname 0xff7f err:winsock:WS_setsockopt Invalid level (1) or optname (65407) The game does work otherwise perfectly, but the network playing is working correctly. I can create a server, and clients can connect to it, but when the server is supposed to send a game-file to the clients, nothing happens. This happens with the demo version too: http://www.shrapnelgames.com/downloads/SE4GoldDemo.exe Sincerely, Anssi Hannula

2 1

shlfolder test fails on my system
by Rolf Kalbermatter 09 Oct '04

09 Oct '04

I get among other failures in other dlls one at the recently added shlfolder test in shell32. It fails for the three cases where it probably is supposed to compare testdir with test1.txt, test2.txt, and test3.txt. While my first idea was a difference in character weighting and comparison I did some more investigations and it seems the test does make specific assumptions as to in which order IEnumIDList should return filenames. The test assumes they are returned in the order as they were created. IEnumIDList is basically creating that list through FindFirstFile and FindNextFile. Is FindFirstFile/FindNextFile really supposed to return items in a particular order or is the test making assumptions which happen to work for some systems accidentally? Rolf Kalbermatter

2 1

Strange behaviour of X Driver
by Robert Lunnon 09 Oct '04

09 Oct '04

I have some strange behaviour occurring on Solaris 10 I am getting XIO errors I Did a syscal trace and got this in part \ uname(0x7FD5EA54) = 1 uname(0x7FD5EB24) = 1 xstat(2, "/tmp/.X11-pipe/X0", 0x7FD5EF64) = 0 open("/tmp/.X11-pipe/X0", O_RDWR) = 11 ioctl(11, I_CANPUT, 0x00000000) = 1 uname(0x7FD5EA94) = 1 uname(0x7FD5EAC4) = 1 fcntl(11, F_SETFD, 0x00000001) = 0 access("/usr2/robert/.Xauthority", R_OK) = 0 open("/usr2/robert/.Xauthority", O_RDONLY) = 14 fstat64(14, 0x7FD5EC40) = 0 fstat64(14, 0x7FD5EB80) = 0 ioctl(14, TCGETA, 0x7FD5EC14) Err#25 ENOTTY read(14, "\0\0\004C0A80305\001 0\0".., 8192) = 1174 read(14, 0x080C413C, 8192) = 0 llseek(14, 0, SEEK_CUR) = 1174 close(14) = 0 writev(11, 0x7FD5F6F4, 4) = 48 fcntl(11, F_GETFL) = 2 fcntl(11, F_SETFL, FWRITE|FNONBLOCK) = 0 read(11, 0x7FD5F7AC, 8) Err#11 EAGAIN XIO: fatal IO error write(2, " X I O : f a t a l ".., 21) = 21 0 (write(2, " 0 (", 3) = 3 Error 0write(2, " E r r o r 0", 7) = 7 ) on X server "write(2, " ) o n X s e r v e".., 15) = 15 :0.0write(2, " : 0 . 0", 4) = 4 " write(2, " "\r\n", 3) = 3 after write(2, " a f t e r ", 12) = 12 0write(2, " 0", 1) = 1 requests (write(2, " r e q u e s t s (", 11) = 11 0write(2, " 0", 1) = 1 known processed) with write(2, " k n o w n p r o c e".., 23) = 23 0write(2, " 0", 1) = 1 events remaining. write(2, " e v e n t s r e m a".., 20) = 20 _exit(1) The last X IO operation before the fatal error was called was a read n the X pipe which return error EAGAIN The Man page for read(2) says the following When attempting to read from an empty pipe (or FIFO): o If no process has the pipe open for writing, read() returns 0 to indicate end-of-file. o If some process has the pipe open for writing and O_NDELAY is set, read() returns 0. o If some process has the pipe open for writing and O_NONBLOCK is set, read() returns -1 and sets errno to EAGAIN. So, Its quite possible, likely that the X Server has the pipe open for writing but the pipe is empty which would return EAGAIN, why is this then treated as an error ??? More later.... Bob

2 1

Re: [janitor] tools -Wwrite-strings cleanup
by Alexandre Julliard 09 Oct '04

09 Oct '04

Daniel Marmier <d.marmier(a)bluewin.ch> writes: > -static type_t std_bool = { "boolean" }; > -static type_t std_int = { "int" }; > -static type_t std_int64 = { "__int64" }; > -static type_t std_uhyper = { "MIDL_uhyper" }; > +static char name_bool[] = "boolean"; > +static char name_int[] = "int"; > +static char name_int64[] = "__int64"; > +static char name_uhyper[] = "MIDL_uhyper"; > + > +static type_t std_bool = { name_bool }; > +static type_t std_int = { name_int }; > +static type_t std_int64 = { name_int64 }; > +static type_t std_uhyper = { name_uhyper }; > + > +static char name_tagged_union[] = "tagged_union"; You should never need to declare non-const strings. If you need that, it's because some other types are not properly declared const, and this is what needs to be fixed. The only case where a non-const string would be appropriate is if the string itself really needs to be written to, but that's a very rare case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Fix InternetCrackUrlW
by Alexandre Julliard 09 Oct '04

09 Oct '04

Maxime Bellengé <maxime.bellenge(a)wanadoo.fr> writes: > An application I try to install calls InternetOpenUrlW with an url like > that : > > http://server/.\\path/file > > Under windows, it works but under wine , the result of such a request is > 404. > So my assumption is windows converts '\' to '/'. I tried that and now it > works perfectly under wine. > > Changelog: > * Convert \ to / in urls. You cannot do that, because InternetCrackUrl doesn't always make a copy of the path, it may return a pointer to the original buffer. The conversion may need to be done at some other level, or you may need to only do it when copying the path. Either way writing a test case would be a good idea. -- Alexandre Julliard julliard(a)winehq.org

1 0

Where has --debugmsg gone ?
by Robert Lunnon 08 Oct '04

08 Oct '04

Subject says it all..... How do I do a wine --debugmsg +relay these days Bob

2 2

Re: Remove winesetuptk and wineinstall from docs
by Ivan Leo Puoti 08 Oct '04

08 Oct '04

> I thought wineinstall handled loading the wine.inf? I think wineprefixcreate does that now. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Re: Remove winesetuptk and wineinstall from docs
by Steven Edwards 08 Oct '04

08 Oct '04

Hi, --- Vincent B�ron <vberon(a)mecano.gme.usherb.ca> wrote: > Winesetuptk hasn't been updated for a while (new drive scheme, etc.), > and it's not even listed on our sf.net download page anymore (where > it > was last seen). > tools/wineinstall doesn't do more than what wineprefixcreate does for > configuration, and needs a source tree while wineprefixcreate is > installed. Also, ./configure && make && make install works great now. I thought wineinstall handled loading the wine.inf? Thanks Steven _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

1 0

[OT] Anyone want to write a book on Wine?
by Jeremy White 08 Oct '04

08 Oct '04

Hey folks, I've had an editor approach me about writing a book on Wine; it's not something I or anyone around here expressed a strong interest in. However, she seems very nice, and so I offered to pass her query along and see if anyone else is interested. If you are, please contact her directly; I've obfuscated her email in down below. Cheers, Jeremy ---------------- Hi Jeremy, Please let me introduce myself. I am the editor at Prentice Hall PTR who has worked with John Terpstra and Chris Hertel on their respective books. They have both spoken to me about you. I am wondering if you would be interested in writing a book on the Wine project, or if you know of anyone who may be interested. It certainly seems to be a worthy topic, and a book would help both educate those interested in using it and spread the word. I would be happy to talk to you about the publishing process, or to anyone you think may be interested. Thanks in advance. Jill Jill Harry Executive Editor AW/PHPTR jill -dot- harry -isat - pearsoned -dot- com www.phptr.com

1 0

comm brokenness -- any plans to fix?
by Kuba Ober 08 Oct '04

08 Oct '04

Hi, is there anyone willing to fix the serial port borkedness (data going out, but not coming back in)? If not, I might have to do that as I wish to get a couple developer tools from Windows running under wine (namely Zilog's Developer Studio and Parallax's SX-KEY). Cheers, Kuba Ober

2 1

dbghelp functions are A only
by Vincent Béron 08 Oct '04

08 Oct '04

Hi, I noticed that dbghelp's functions are only implemented as A variant, while MSDN says they're available as either Unicode or Ascii variant. Should we rename the current ones A and create stub W before properly implementing in W and make the A call the W? Also, I noticed quite a lot of prototypes in dbghelp.dll from MSDN with PTSTR or PCTSTR types for strings instead of LPTSTR. Should the prototype in dbghelp.h and the actual implementation use PTSTR or LPTSTR? The origin of all this is because following email from François yesterday about wineapi_check, I wanted to add the types for each dll in win32.api to reduce the number of lines emitted by the tool, but I have questions as to how to do it properly. Vincent

3 3

Re: Correct wvsprintf16 in spec and definition
by Vincent Béron 08 Oct '04

08 Oct '04

Le ven 08/10/2004 à 11:32, Vincent Béron a écrit : > Changelog: > Correct the spec file and the definition for wvsprintf16. Please do not apply as is, it doesn't compile. Vincent

1 0

.so dependancies in winegcc
by Warren_Baird/CSI＠cimmetry.com 08 Oct '04

08 Oct '04

Hi all, I'm still working on getting wine going on hpux, and I thought I should submit patches for more of the changes I've made. There were a couple of places in winegcc where there were some assumptions made about .so being the shared library extension and .exe.so being the executable suffix - There was a partial fix to handle .dylib for MacOS, but it wasn't well unified... I've created defines for SHLIBSUFFIX and EXESUFFIX in utils.h, and changed the places where .so or .exe.so was used to use the right define. This does slightly change the logic of the code though --- the way it was written before, winegcc would have (partially) done the right thing given a .dylib file on linux, or given a .so file on MacOS... I think this was just an unintended side-effect of the way things were implemented- but I'm not 100% sure... I've attached the patches I came up with - does this look reasonable? Warren

1 0

Cross build failed, anyone else get this?
by Paul Millar 08 Oct '04

08 Oct '04

Hi, Looks like one of last night's patches broke cross-building (at least for me). ---------- Forwarded Message ---------- Subject: Cron <paulm@quisquiliae> $HOME/Production/cronCrossBuild 10:00 Date: Thursday 07 October 2004 11:27 From: root of quisquiliae <p.millar(a)physics.gla.ac.uk> To: p.millar(a)physics.gla.ac.uk Ran command "make depend", but it failed with following output: make[1]: Entering directory `/home/paulm/Production/wine-cross-pe/libs' make[2]: Entering directory `/home/paulm/Production/wine-cross-pe/libs/port' i686-mingw32msvc-gcc -c -I/home/paulm/Production/wine-cross-source/libs/port -I. -I/home/paulm/Production/wine-cross-source/include -I../../include -D__WINESRC__ -D_REENTRANT -Wall -pipe -fno-strength-reduce -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o fstatvfs.o /home/paulm/Production/wine-cross-source/libs/port/fstatvfs.c In file included from /home/paulm/Production/wine-cross-source/libs/port/fstatvfs.c:22: /home/paulm/Production/wine-cross-source/include/wine/port.h:286: warning: `struct timeval' declared inside parameter list /home/paulm/Production/wine-cross-source/include/wine/port.h:286: warning: its scope is only this definition or declaration, which is probably not what you want i686-mingw32msvc-gcc -c -I/home/paulm/Production/wine-cross-source/libs/port -I. -I/home/paulm/Production/wine-cross-source/include -I../../include -D__WINESRC__ -D_REENTRANT -Wall -pipe -fno-strength-reduce -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o futimes.o /home/paulm/Production/wine-cross-source/libs/port/futimes.c distcc[2412] ERROR: compile on melpomene failed In file included from /home/paulm/Production/wine-cross-source/libs/port/futimes.c:22: /home/paulm/Production/wine-cross-source/include/wine/port.h:286: warning: `struct timeval' declared inside parameter list /home/paulm/Production/wine-cross-source/include/wine/port.h:286: warning: its scope is only this definition or declaration, which is probably not what you want /home/paulm/Production/wine-cross-source/libs/port/futimes.c:31: warning: `struct timeval' declared inside parameter list /home/paulm/Production/wine-cross-source/libs/port/futimes.c:32: error: conflicting types for `futimes' /home/paulm/Production/wine-cross-source/include/wine/port.h:286: error: previous declaration of `futimes' make[2]: *** [futimes.o] Error 1 make[2]: Leaving directory `/home/paulm/Production/wine-cross-pe/libs/port' make[1]: *** [port] Error 2 make[1]: Leaving directory `/home/paulm/Production/wine-cross-pe/libs' make: *** [libs] Error 2 ERROR: make depend failed -------------------------------------------------------

2 1

Re: Add new types to win16.api and win32.api
by Vincent Béron 08 Oct '04

08 Oct '04

Le ven 08/10/2004 à 09:34, Vincent Béron a écrit : > Changelog: > Add new types to win16.api and win32.api to make winapi_check happier. Alexandre, I just noticed that this patch conflicts with my previous patch "Remove unused types from win{16,32}.api" (I just forgot it wasn't committed yet). Don't apply this one for now, I'll send another version which will be between (current cvs + remove unused) and (current cvs + remove unused + add new). Vincent

1 0

Re: Brush colors
by Filip Navara 08 Oct '04

08 Oct '04

Jon Griffiths wrote: > Hi, > > --- Filip Navara <xnavara(a)volny.cz> wrote: > >>palette as opposed to the system palette (RGB macro) and the value >>is constructed as (COLORREF)(0x2000000 | RGB(R, G, B)). > > Yes, its using this value. I have the source for the app and it seems > to imply that it will choose the closest color from the selected DC > palette in the event that it is not a true color DC. > > I don't know if we should pass the value unmodified to the graphics > driver and mask it out/deal with it there, But I'm sire someone will > pipe up if he patch isn't right :-) The X11 driver handles the brush color right way if it's created with PALETTEINDEX or PALLETTERGB. The relevant code is X11DRV:BRUSH_SelectSolidBrush + X11DRV:X11DRV_PALETTE_ToPhysical. So I think your patch isn't really correct, because it will break brushes created with PALETTEINDEX and match stock brushes with PALLETTERGB colors (which isn't right either on non-true color surfaces). Regards, Filip

1 0

Re: ImageList_Merge
by Francois Gouget 08 Oct '04

08 Oct '04

On Thu, 7 Oct 2004, Jon Griffiths wrote: > Hi, > > If you #define VISIBLE and run the modified tests you will see that > native and builtin produce slightly different output drawing some > merged images. IMHO it would be better to rely on the WINETEST_INTERACTIVE environment variable. WINETEST_INTERACTIVE is used by human beings to instruct the test to take special steps to ensure that they, the human beings, can check the test output. WINETEST_INTERACTIVE is already used by the sound tests so this would improve consistency. Another benefit would be the removal of #ifdefs. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

2 1

Install MSN Messenger
by Joaquín Fernández 07 Oct '04

07 Oct '04

Hello... somebody have installed successfully MSN Messenger 6.2 in Wine? I was not able to run it without problem. Some dll override or other thing? Regards Joaquín -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

1 0

build problems with/without alsa 0.9
by Dietrich Teickner 07 Oct '04

07 Oct '04

After buildproblems with alsa at my samba sserver (alsa 0.9) I have removed the sound, (hi works without). After them I have other problems. No rules for build. Can anyone help ? Dietrich make[2]: Verlassen des Verzeichnisses ?/home/sao2l02/Wine/wine/dlls/vwin32.vxd½ rm -f vwin32.vxd.so && ln -s vwin32.vxd/vwin32.vxd.so vwin32.vxd.so make[1]: *** Keine Regel vorhanden, um das Target ?winealsa.drv.so½, ben÷tigt von ?symlinks.so½, zu erstellen. Schluss. make[1]: Verlassen des Verzeichnisses ?/home/sao2l02/Wine/wine/dlls½ make: *** [dlls] Fehler 2

1 0

Re: MD{4,5}Final number of parameters
by Filip Navara 07 Oct '04

07 Oct '04

Vincent Béron wrote: >Hans, > >There seems to be a problem with the number of parameters MD{4,5}Final >expect (haven't checked SHA). > >advapi32.spec defines it as follow: >@ stdcall MD4Final(ptr ptr) >@ stdcall MD5Final(ptr ptr) > >But the actual implementation in crypt_md{4,5}.c are: >VOID WINAPI MD4Final( MD4_CTX *ctx ) >VOID WINAPI MD5Final( MD5_CTX *ctx ) > >Also, after a bit of googling I found >http://akson.sgh.waw.pl/~chopin/ssh/putty/SGH/src-0.53b/PAGEANT.C, which >uses MD5Final() with 2 parameters: >MD5Final(response_md5, &md5c); > >So which one is right? > > The one with two parameters. The first one is context and the second one is the result (array). Regards, Filip

1 0

Problem with some versions of Freecell
by gslink 07 Oct '04

07 Oct '04

One of the Freecell versions in my test suite began to fail with the September release. Freecell returns an out of memory error. The reason appears to be that it thinks the bitmap is oversize. The actual cause is a CreateCompatableBitmap with a width of 6291527. I could find no other case of this though several programs have been failing with the out of memory error since day 1.

2 1

Re: Winefile: fix "move file" implementation
by Dmitry Timoshkov 07 Oct '04

07 Oct '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> wrote: > - use TCHAR to make the code UNICODE compatible By using TCHAR you actually hide the problem and make the code very hard to maintain. What is the purpose of that in Wine or ReactOS? Why don't you use unicode directly? -- Dmitry.

4 12

Re: winuser.h
by Andreas Mohr 07 Oct '04

07 Oct '04

Hi, On Thu, Oct 07, 2004 at 07:24:07AM -0700, Jon Griffiths wrote: > Hi, > > Needed for part of my app to compile. Could someone with a recent SDK > find the correct values for ODS_NOACCEL & ODS_NOFOCUSRECT? ODS_NOACCEL 0x0100 ODS_NOFOCUSRECT 0x0200 both defined for _WIN32_WINNT >= 0x0500 only. Andreas Mohr

2 1

(no subject)
by Ivan Leo Puoti 07 Oct '04

07 Oct '04

> Maybe we should forbid TCHARs in the programs/ directory too... OK this is probably a lame question, but what does one do when he wants to implement a function that has a TCHAR parameter? Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

Re: iTunes, 1608: Unable to create InstallDriver instance
by Ivan Leo Puoti 07 Oct '04

07 Oct '04

> ok .. so I don't understand the whole implications of this, but, > probably, switching these famous patches to LGPL would help much people to > have their applications run under Wine. No, Wine is 100% LGPL now but TransGaming wanted some parts to be licenced under the X11. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

ez-cdda sleep
by James Hawkins 07 Oct '04

07 Oct '04

I'm trying to get ez-cdda extractor to run, but when I do run it it just sits there...nothing graphical shows up, no signs of life in the program. I did a trace+relay and found that after the program is started, it immediately starts suspending the program over and over again as seen in the attached log file. Does anyone have any clue about this? -- James Hawkins

6 15

Re: dlls/setupapi/parser.c
by Alexandre Julliard 07 Oct '04

07 Oct '04

Ge van Geldorp <gvg(a)reactos.com> writes: > Changelog: > Ge van Geldorp <gvg(a)reactos.com> > - GetFullPathName returns length without nul byte If it does that's a bug, it's supposed to count the terminating null. Or do you have evidence that it doesn't do that on Windows? -- Alexandre Julliard julliard(a)winehq.org

2 1

iTunes, 1608: Unable to create InstallDriver instance
by Olivier Kaloudoff 07 Oct '04

07 Oct '04

Hi, with a fresh clean install of wine, trying to run iTunesSetup.exe gives the error given in the subject. It's related to DCOM, so Microsoft recommands to download DCOM95 or DCOM98 ... crawling again and again ... It turns out that some DCOM patches have been written, and TransGaming is ready to give them away as LGPL, asking for some Wine people to change their license to LGPL, too, instead of pure GPL. http://www.kernel-traffic.org/wine/wn20020522_123_print.html ok .. so I don't understand the whole implications of this, but, probably, switching these famous patches to LGPL would help much people to have their applications run under Wine. Did this point evolve since 2002 ? Did someone try to start a rewrite of the relevant patches (I don't think this is the good way to proceed, I would propose some compensation for their work to the GPL code writers) ? Is there any light for the small users we are ? ;-) Regards, Olivier Kaloudoff LUG Linux Azur http://www.linux-azur.org FRANCE

1 0

MASK_FLAG_DDEWAIT in ShellExecuteExW32 ()
by Olivier Kaloudoff 07 Oct '04

07 Oct '04

Hi, Trying to run an unsupported application, I get the following error: fixme:exec:ShellExecuteExW32 flags ignored: 0x00000140 and the application gives me C:\windows\temp\MMIsnst, access denied... so two bits are set by the application, requesting MASK_FLAG_DDEWAIT and MASK_NOCLOSEPROCESS ... as far as I understand DDEWAIT, it should be trivial to implement, as it is just some kind of sleep() ... even with no C experience, I should be able to do this.. what about NOCLOSEPROCESS ? .... hmmm, crawling the web, it turns out that the writer of this application (MobileMaster.exe) probably made a call to a RunWait function ... in a language called LibertyBasic ... am I right ? http://libertybasic.conforums.com/index.cgi?board=tips&num=1079874405&actio… sub RunWait file$, para$, dir$ ' sub to open an application or file ' ' Usage: ' call RunWait {filename}, {parameters}, {startfolder} ' ' filename ...... full path to file or executable ' parameters .... if file is a document this should be empty ' if file is an executable any parameters ' that should be passed to it ' startfolder ... initial folder, can be empty SEE.MASK.NOCLOSEPROCESS = hexdec("40") SEE.MASK.FLAG.DDEWAIT = hexdec("100") struct ExecInfo, _ Size as long, _ fMask as long, _ hwnd as long, _ Verb$ as ptr, _ File$ as ptr, _ Parameters$ as ptr, _ Directory$ as ptr, _ Show as long, _ InstApp as long, _ IDList as long, _ Class$ as ptr, _ keyClass as long, _ HotKey as long, _ Icon as long, _ Process as long ExecInfo.fMask.struct = SEE.MASK.NOCLOSEPROCESS or SEE.MASK.FLAG.DDEWAIT ExecInfo.File$.struct = file$ + chr$(0) ExecInfo.Parameters$.struct = para$ + chr$(0) ExecInfo.Directory$.struct = dir$ + chr$(0) ExecInfo.Show.struct = _SW_SHOWNORMAL ExecInfo.Size.struct = len(ExecInfo.struct) calldll #shell32, "ShellExecuteExA", _ ExecInfo as struct, _ result as long if result <> 0 then Handle = ExecInfo.Process.struct Milliseconds = _INFINITE calldll #kernel32, "WaitForSingleObject", _ Handle as long, _ Milliseconds as long, _ result as long end if end sub

1 0

Re: Handle the case when an active MDI child is being hidden
by Alexandre Julliard 07 Oct '04

07 Oct '04

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Hello, > > with my last patch I introduced a regression with frame menu handling > when last maximized MDI child gets destroyed. Here is a better fix for > that problem. > > Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Handle the case when an active MDI child is being hidden. This is causing test failures here: msg.c:1591: Test failed: wrong focus window 0x90028 msg.c:1616: Test failed: wrong focus window 0x90028 msg.c:1622: Test failed: wrong active MDI child (nil) msg.c:1672: Test failed: wrong focus window 0x60026 msg.c:1678: Test failed: wrong focus window 0x60026 msg.c:1684: Test failed: wrong focus window 0x60026 msg.c:1746: Test failed: wrong focus window 0x90028 msg.c:1799: Test failed: wrong focus window 0x90028 -- Alexandre Julliard julliard(a)winehq.org

1 0

make depend on CVS fails due some widl error
by Saulius Krasuckas 06 Oct '04

06 Oct '04

It may be redundant info, but whatever. An excerpt from the output: | Configure finished. Do 'make depend && make' to compile Wine. | | cd include && make all | make[1]: Entering directory `/mnt/antras/usr/src/wine-cvs/wine/include' | ../tools/widl/widl -I. -I. -I../include -I../include -h -H exdisp.h | exdisp.idl | exdisp.idl:103: Error: parse error | make[1]: *** [exdisp.h] Error 1 :-/

3 3

I'm getting two of every email post
by Kevin R. Casper 06 Oct '04

06 Oct '04

I must have done something wrong when I signed up for this list as an email list. I'm getting two of every message. Any idea what's wrong? Kevin Casper

3 2

Martin Rasp/PTB ist außer Haus.
by Martin.Rasp＠ptb.de 06 Oct '04

06 Oct '04

Ich werde ab 06.10.2004 nicht im Büro sein. Ich kehre zurück am 22.10.2004. Vertreter: Herr Scheffler, Telefon 8419

1 0

Re: Small API documentation fix
by Francois Gouget 06 Oct '04

06 Oct '04

On Wed, 6 Oct 2004, Francois Gouget wrote: > > I found this one when examining the output of ./tools/winapi/winapi_check. > It turned out to be just a stroke of luck as winapi_check seems to complain > about the documentation of each and every function though I don't understand > what's wrong: > > $ ./tools/winapi/winapi_check > dlls/advapi32/advapi.c:53: advapi32: BOOL WINAPI GetUserNameA(LPSTR,LPDWORD): > documentation: GetUserNameA (ADVAPI32.@) wrong [...] > $ ./tools/winapi/winapi_check | grep documentation: | wc -l > 9489 You can ignore this. It turns out I had a bad patch in my tree. Now everything is back to normal (only 485 documentation-related issues). -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

1 0

Re: some console fixes (for ctrl-c handling)
by Ferenc Wagner 06 Oct '04

06 Oct '04

Eric Pouech <pouech-eric(a)wanadoo.fr> writes: > ChangeLog: > - ctrl-c enabling flag is now inherited > - fixed console-related fields in RTL_USER_PROCESS_PARAMETERS > - various clean-up in kernel32.SetConsoleCtrlHandler > - only send a console event once to a process and not to all the process' threads > [...] > + ok(GenerateConsoleCtrlEvent(CTRL_C_EVENT, 0), "Couldn't send ctrl-c event\n"); > + todo_wine ok(mch_count == 1, "Event isn't synchronous\n"); > + ok(WaitForSingleObject(mch_event, 3000) == WAIT_OBJECT_0, "event sending didn't work\n"); > + CloseHandle(mch_event); > + ok(SetConsoleCtrlHandler(NULL, TRUE), "Couldn't turn off ctrl-c handling\n"); > + mch_event = CreateEventA(NULL, TRUE, FALSE, NULL); > + mch_count = 0; > + ok(GenerateConsoleCtrlEvent(CTRL_C_EVENT, 0), "Couldn't send ctrl-c event\n"); Hi Eric, these Ctrl-C events kill off winetest under XP. You probably did your tests and found this OK, so I'm not sure what to do. Can you offer a solution? I commented those two lines out, which made it go through... -- Thanks, Feri.

2 1

winedbg - No debug info showing
by Ann and Jason Edmeades 06 Oct '04

06 Oct '04

Hiya, I just hit a trap in a d3d8 test I was running, and winedbg isnt showing the module information (I've put a manual DebugBreak in, and stepped through the call to a fixme, and I see no info!). This was on my temporary wine machine, so I dont know if its ever worked before, but I have a basic (cvs) install, no special info. I am sure winedbg used to show the d3d8 functions in the past. Note that because they are in COM routines, they dont have to be exports, but I dont know if they are or not. nm d3d8.dll.so does seem to show the entrypoints, so is there anything I am missing - configuration wise, setup wise etc? Jason

2 1

audio driver autodetection
by James Hawkins 06 Oct '04

06 Oct '04

>From Mike Hearn's winecfg post: > > - Obviously, once audio autodetection has been moved into the drivers we > > need to kill the audio tab. > > Still needs to be done. Not all that hard. I remember working on this a couple months ago. I put the driver detection in winmm.c, but that was wrong. I can't remember exactly what I was supposed to do to fix it...something like put the driver detection in each driver. I'm not really sure what that means or how it would work if it does what I think it does. Does it mean that we load one driver, and if it doesn't detect its *nix counterpart then it loads the next driver? I would like to get to work on this task, so if anyone has any pointers or ideas on this one, please let me know. -- James Hawkins

6 15

DllCanUnloadNow janitorial
by James Hawkins 06 Oct '04

06 Oct '04

Hi, I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. Is LockServer(TRUE/FALSE) the same as this example? static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { IClassFactoryImpl *This = (IClassFactoryImpl *)iface; FIXME("(%p)->(%d),stub!\n",This,dolock); return S_OK; } If they are the same, what is needed to complete this stub? I would think that there would be a refCount variable that is incremented if dolock is true and decremented if dolock is false. Also, should the LockServer functions be listed in the spec files of the dlls? After implementing LockServer, it should be an easy matter to do a check for refCount == 0 to see if the dll can be unloaded or not. Am I heading in the right direction? -- James Hawkins

1 0

kind of newbie question :)
by Carlo Bono 06 Oct '04

06 Oct '04

i report this post from comp.emulators.ms-windows.wine... hope i will not be boring, stupid or what. even if that's difficult :D first of all, excuse me for my bad english. but i hope it will be the worst thing that all of you will read here :)) i'm trying to port an industrial application on linux, some people suggested me to try to compile it using wine/winelib. i documented myself a bit on it, and i tried to build a sample application (as the user guide tells, winemine :D) but winemaker DOES NOT genreate any configure script! wine version is 14/9/2004 and was compiled from source on slackware 10.0 running on a via C3 (intel x86 100% compatibile). is there any suggestion or workaround, or maybe this is normal, or maybe then i'm forgetti something really stupid? (maybe not so stupid, don't think it makes a difference :D) i also tried to generate by myself a configure script, using tools as autoscan, autoheader and autoconf, and trying to "fine tune" the output script by hand, but i could not manage to get the application compile. something tells me i'm not on the right way to compile a greater, more complex program like i have to do :))) thanks anyway just for reading this post! have a nice day carlo

2 1

kind of newbie question :)
by Carlo Bono 06 Oct '04

06 Oct '04

first of all, excuse me for my bad english. but i hope it will be the worst thing that all of you will read here :)) i'm trying to port an industrial application on linux, some people suggested me to try to compile it using wine/winelib. i documented myself a bit on it, and i tried to build a sample application (as the user guide tells, winemine :D) but winemaker DOES NOT genreate any configure script! wine version is 14/9/2004 and was compiled from source on slackware 10.0 running on a via C3 (intel x86 100% compatibile). is there any suggestion or workaround, or maybe this is normal, or maybe then i'm forgetti something really stupid? (maybe not so stupid, don't think it makes a difference :D) i also tried to generate by myself a configure script, using tools as autoscan, autoheader and autoconf, and trying to "fine tune" the output script by hand, but i could not manage to get the application compile. something tells me i'm not on the right way to compile a greater, more complex program like i have to do :))) thanks anyway just for reading this post! have a nice day carlo

2 1

Re: How to deal with C++ APIs in wine spec file
by Jon Griffiths 06 Oct '04

06 Oct '04

Hi, > how can I call a class constructor (which is built form > another class) in spec file? Can anyone provide me an example? This is possible, although it is not immediately obvious. Here is the solution I use (I will document this one day but I'm very busy ATM): Scenario 1: App uses C++ dll, dll does not use win32 calls Solution: Compile as non wine dll (unix .so) and link. Scenario 2: App uses C++ dll, dll uses win32 calls Solution 1: Static link with the object files of the dll. Winebuild will resolve references to win32 calls. Solution 2: Use native .exe and dlls Solution 3: Compile as wine dll with one extern "C" dummy function that does nothing. Do _not_ attempt to export any C++ symbols. install the resulting .dll.so as: /usr/local/lib/wine/NAME.dll.so and place a soft link to it as /usr/local/lib/libNAME.dll.so Don't forget to install the .def file as: /usr/local/lib/wine/libNAME.def Link as a wine dll _and_ a unix .so. e.g: wineg++ -mwindows -o app.exe.so <opts> -lNAME -lNAME.dll In any dll or program that calls functions from the dll, place a call to your dummy function immediately after WinMain(). This will force winebuild to link to the dll and the loader to set up the Win32 function pointers in the dll. Due to dlopen magic the ctors/dtors for statics will only be called once. Be carefull with the order of static object initialisation, you may need to use gcc's attribute init_priority to ensure correct ordering, or defer static initialisation until after loading Hope this helps, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail

3 3

Re: Add a test case for accelerators, make the test pass on Wine. Take 3.
by Alexandre Julliard 05 Oct '04

05 Oct '04

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > I don't see why it's needed because there is no a visual hang, system > menu gets displayed. This is exactly the same behaviour as pressing > Left arrow on the most left item of a window menu, so I vote to remove > this code from the patch: But this is not how it's supposed to behave, on Windows the system menu doesn't get displayed in that case. And if we are going to be incompatible anyway, then not tracking the system menu at all is much better IMO. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine user guid (pdf)
by Daniel Richards Jr. 05 Oct '04

05 Oct '04

I am new to Linux (gettn tired of M$ so called operating systems) and just got a hold of your wine user guide. Thanks for putting the time in to put this together. Greatly detailed and just what I need to try and get some of my win based programs to run in Linux. As I get a the opportunity to setup wine while following the guide, I will let you know if I come across anything confusing etc. Thanks again for putting this together. Dan

2 1

audio.c - problems
by Dietrich Teickner 05 Oct '04

05 Oct '04

Knows anyone this problem ? I can not compile wine since some days.I have checked out all new and also start make clen after connfigure and some more. Any Ideas ? Dietrich make[2]: Wechsel in das Verzeichnis ?/home/sao2l02/Wine/wine/dlls/winmm/winealsa½ gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o audio.o audio.c audio.c: In function `ALSA_TraceParameters': audio.c:514: too many arguments to function `snd_pcm_hw_params_get_access' audio.c:515: too many arguments to function `snd_pcm_hw_params_get_format' audio.c:564: too many arguments to function `snd_pcm_hw_params_get_channels' audio.c:568: too many arguments to function `snd_pcm_hw_params_get_channels_min' audio.c:569: too many arguments to function `snd_pcm_hw_params_get_channels_max' audio.c:578: too many arguments to function `snd_pcm_hw_params_get_buffer_size' audio.c:582: too many arguments to function `snd_pcm_hw_params_get_buffer_size_min' audio.c:583: too many arguments to function `snd_pcm_hw_params_get_buffer_size_max' audio.c:605: too many arguments to function `snd_pcm_hw_params_get_rate' audio.c:605: too many arguments to function `snd_pcm_hw_params_get_rate_min' audio.c:605: too many arguments to function `snd_pcm_hw_params_get_rate_max' audio.c:606: too many arguments to function `snd_pcm_hw_params_get_buffer_time' audio.c:606: too many arguments to function `snd_pcm_hw_params_get_buffer_time_min' audio.c:606: too many arguments to function `snd_pcm_hw_params_get_buffer_time_max' audio.c:607: too many arguments to function `snd_pcm_hw_params_get_periods' audio.c:607: too many arguments to function `snd_pcm_hw_params_get_periods_min' audio.c:607: too many arguments to function `snd_pcm_hw_params_get_periods_max' audio.c:612: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:612: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c:616: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size_min' from incompatible pointer type audio.c:616: too many arguments to function `snd_pcm_hw_params_get_period_size_min' audio.c:617: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size_max' from incompatible pointer type audio.c:617: too many arguments to function `snd_pcm_hw_params_get_period_size_max' audio.c:624: too many arguments to function `snd_pcm_hw_params_get_period_time' audio.c:624: too many arguments to function `snd_pcm_hw_params_get_period_time_min' audio.c:624: too many arguments to function `snd_pcm_hw_params_get_period_time_max' audio.c:625: too many arguments to function `snd_pcm_hw_params_get_tick_time' audio.c:625: too many arguments to function `snd_pcm_hw_params_get_tick_time_min' audio.c:625: too many arguments to function `snd_pcm_hw_params_get_tick_time_max' audio.c: In function `ALSA_WaveInit': audio.c:744: too many arguments to function `snd_pcm_hw_params_get_rate_min' audio.c:745: too many arguments to function `snd_pcm_hw_params_get_rate_max' audio.c:746: too many arguments to function `snd_pcm_hw_params_get_channels_min' audio.c:747: too many arguments to function `snd_pcm_hw_params_get_channels_max' audio.c:851: too many arguments to function `snd_pcm_hw_params_get_rate_min' audio.c:852: too many arguments to function `snd_pcm_hw_params_get_rate_max' audio.c:853: too many arguments to function `snd_pcm_hw_params_get_channels_min' audio.c:854: too many arguments to function `snd_pcm_hw_params_get_channels_max' audio.c: In function `wodPlayer_DSPWait': audio.c:1200: too many arguments to function `snd_pcm_hw_params_get_period_time' audio.c: In function `wodOpen': audio.c:1721: warning: passing arg 3 of `snd_pcm_hw_params_set_rate_near' makes integer from pointer without a cast audio.c:1733: warning: passing arg 3 of `snd_pcm_hw_params_set_buffer_time_near' makes integer from pointer without a cast audio.c:1735: warning: passing arg 3 of `snd_pcm_hw_params_set_period_time_near' makes integer from pointer without a cast audio.c:1739: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:1739: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c:1740: too many arguments to function `snd_pcm_hw_params_get_buffer_size' audio.c: In function `DSDB_MMAPCopy': audio.c:2252: too many arguments to function `snd_pcm_hw_params_get_channels' audio.c:2253: too many arguments to function `snd_pcm_hw_params_get_format' audio.c:2255: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:2255: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c: In function `DSDB_CreateMMAP': audio.c:2306: too many arguments to function `snd_pcm_hw_params_get_format' audio.c:2307: too many arguments to function `snd_pcm_hw_params_get_buffer_size' audio.c:2308: too many arguments to function `snd_pcm_hw_params_get_channels' audio.c: In function `IDsDriverBufferImpl_GetPosition': audio.c:2463: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:2463: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c: In function `widOpen': audio.c:3211: warning: passing arg 3 of `snd_pcm_hw_params_set_rate_near' makes integer from pointer without a cast audio.c:3224: warning: passing arg 3 of `snd_pcm_hw_params_set_buffer_time_near' makes integer from pointer without a cast audio.c:3226: warning: passing arg 3 of `snd_pcm_hw_params_set_period_time_near' makes integer from pointer without a cast audio.c:3231: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:3231: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c:3232: too many arguments to function `snd_pcm_hw_params_get_buffer_size' make[2]: *** [audio.o] Fehler 1 make[2]: Verlassen des Verzeichnisses ?/home/sao2l02/Wine/wine/dlls/winmm/winealsa½ make[1]: *** [winmm/winealsa] Fehler 2 make[1]: Verlassen des Verzeichnisses ?/home/sao2l02/Wine/wine/dlls½ make: *** [dlls] Fehler 2 sao2l02@x2l:~/Wine/wine>

3 2

Re: Audit the buttons code
by Dmitry Timoshkov 05 Oct '04

05 Oct '04

"Dimitrie O. Paun" <dpaun(a)rogers.com> wrote: > + * This code was audited for completeness against the documented features > + * of Comctl32.dll version 6.0 on Oct. 3, 2004, by Dimitrie O. Paun. "Button" is a built-in user32 control and has nothing to do with comctl32 at all. Same for all other controls in the dlls/user/ subdirectory. -- Dmitry.

5 20

building on P3 for a P2
by Carl Karsten (435025) 05 Oct '04

05 Oct '04

I want to run wine on a P2 laptop that doesn't have compiler and such installed. I have a P3 box that does. I looked over the results of ./configure and didn't see anything that looked like it had turned on any P3 specific options. The plan is to compile on the p3 then on the P2 nfs mount the wine source dir and run make install. Is this a good plan? Carl Karsten -- http://www.personnelware.com/carl/resume.html

2 1

Re: Compiling Wine with MSVC
by Brian Vincent 05 Oct '04

05 Oct '04

On Tue, 05 Oct 2004 11:10:45 +0100, Martin Fuchs <martin-fuchs(a)gmx.net> wrote: > OK, here is the next problem. > The tool msvcmaker prints the following error messages: > > $ tools/winapi/msvcmaker > Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 52. I took a stab at this a few months ago, then Steven Edwards posted a patch that supposedly fixes it: http://www.winehq.com/hypermail/wine-devel/2004/05/0476.html I never got a chance to try it out, but if it works it's probably worth forwarding to wine-patches. -Brian

1 0

Compiling Wine with MSVC
by Martin Fuchs 05 Oct '04

05 Oct '04

OK, here is the next problem. The tool msvcmaker prints the following error messages: $ tools/winapi/msvcmaker Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 52. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 116. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 441. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 1031. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 1091. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 1141. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 1183. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 1220. Global symbol "$wine_dir" requires explicit package name at tools/winapi/msvcmaker line 1237. Execution of tools/winapi/msvcmaker aborted due to compilation errors. My perl version used is the current one of Cygwin: v5.8.5

2 2

Compiling Wine on Cygwin/with MSVC
by Martin Fuchs 05 Oct '04

05 Oct '04

Hello, when trying to compile WINE using Cygwin I am getting errors such as: (this example for wine/programs/notepad) gcc -c -I. -I. -I../../include -I../../include -I../../include/msvcrt -DNO_LIBWINE_PORT -D_REENTRANT -Wall -pipe -mprefe rred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o License_En.o License_En.c In file included from /usr/include/w32api/objfwd.h:7, from /usr/include/w32api/objidl.h:7, from ../../include/objbase.h:270, from ../../include/ole2.h:25, from ../../include/windows.h:77, from License_En.c:1: /usr/include/w32api/basetyps.h:124: error: Syntaxfehler before '*' token /usr/include/w32api/basetyps.h:125: error: Syntaxfehler before '*' token /usr/include/w32api/basetyps.h:127: error: Syntaxfehler before '*' token In file included from ../../include/objbase.h:270, from ../../include/ole2.h:25, from ../../include/windows.h:77, from License_En.c:1: /usr/include/w32api/objidl.h:10: error: Syntaxfehler before "LPOLESTR" I configured with "configure --disable-win16". When trying to compile parts of WINE using MSVC, I'm getting: Compiling... comctl32undoc.c d:\wine-msvc\include\windows.h(23) : fatal error C1189: #error : Wine should not include windows.h internally This all worked some months ago. Can someone explain, what's wrong here? Thanks, Martin

4 6

RE: fixed bug in shell32
by Rolf Kalbermatter 05 Oct '04

05 Oct '04

>@@ -163,10 +163,10 @@ > else > ret = (SHNotifyDeleteFileA(szTemp) == ERROR_SUCCESS); > } while (ret && FindNextFileA(hFind, &wfd)); >+ FindClose(hFind); >+ if (ret) >+ ret = (SHNotifyRemoveDirectoryA(pszDir) == ERROR_SUCCESS); > } >- FindClose(hFind); >- if (ret) >- ret = (SHNotifyRemoveDirectoryA(pszDir) == ERROR_SUCCESS); > return ret; > } This create a FindFile handle leak if the user chooses to abort the delete operation. Rolf Kalbermatter

1 0

Re: Contributing to WINE
by Shachar Shemesh 05 Oct '04

05 Oct '04

Hi Ronald, I cannot stress this point enough. Wine is a community project. Everyone involved in the Wine project would appreciate a chance to answer your questions, as well as hear what you have to say. Sometimes there is a need to establish private communication with certain people. As a rule, however, all technical guidance and discussions should be done on the mailing list. This way, everyone gets a chance to respond to your inquiries. Also, it appears that many participants of this list, as well as the web mail archive, are having problems with the format in which you send your emails. Please try to send mail to this list in plain text format. The format in which you sent me seems to be ok, but I cannot say for sure. Ronald Robin wrote: >Hi Shachar, thank you for your response to my post. I am sorry for several >things: First, that we have not tried posting to this mailing list before. >We thought before that it would be better to establish communications first >with the person who leads the project (i.e. Mr. Julliard). I guess that was >my mistake. Second, that it took me a long time to respond back to you. >You've been a great help. Thank you for the suggestions that you gave. I'm >sure it would be most helpful in case we would need to hire some more help >in the future. > >Anyway, I'd like to introduce myself again. I'm Ronald Robin of SpecOpS >Labs. I am the Project Manager for the David Project. I'm in charge of >managing the research and development efforts within our lab as well as >those done by our partner universities an institutions including the the >National Computer Center, De Lasalle University, and Ateneo de Manila >Univesity here in the Philippines. > >As mandated by our President & CEO, Frederick Lewis and our CTO, Peter >Valdez, we are glad to announce to you that one of my team's newer >objectives is to regularly contribute to the WINE Community. To get things >started with, I can assign some of our developers to focus working on >something we can proudly contribute to the WINE community. We may not be >able to dedicate a significant number of them, but it’s a start. > > Any development you can put towards the wine project would be appreciated and welcomed. >I was wondering, is it ok for me to ask you some more questions? > > Better yet, ask everyone the questions. This way, you will get answers even if I happen to be busy, or not know the answer. >I believe you're one of the best persons right now to help us get some ideas >as to what particular problem areas we can focus our contribution efforts >on. It would be really nice if my team can contribute something significant >to the community. > > While I thank you for the complement, this is not how things usually work in a free software project. As you may know, Wine has several areas that could use a developer's attention. We don't know much about your company, so it would be hard to know what areas would be best for you to contribute in. First off, we would all appreciate if you sent any code you happen to change in Wine while working on David anyways. This basic form of contribution is usually the easiest for you to do. As for general areas of improvements in Wine, there are a few. Development there had better be coordinated with the people already working on these things. Probably the area most needing tender love and care is DCOM. While people are currently working on it, we still depend on Microsoft's DLLs in that area, which is not a good thing. Another place that could use enhancement is MSI. Personally, I also want to see better BiDi support, but that's something not many of the list's members care about as much as I. I'm sure other list members will be happy to fill in other areas where your help would be most appreciated. >Thanks again. > > Any time. >Cheers! > >Ronald Robin > > Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

wctype
by Ge van Geldorp 05 Oct '04

05 Oct '04

I compared the results of CT_CTYPE1 GetStringTypeW() between Windows 2000 and Wine and found a lot of differences (about 12000 of them). Nothing really spectacular, e.g. codepoint 0x00b5 (MICRO SIGN) is classified C1_PUNCT in Win2k and (C1_ALPHA | C1_LOWER) in Wine. I noticed that the Wine table is generated from information on ftp.unicode.org, so I'm wondering if the table generation is correct or if Microsoft made some strange choices? Gé van Geldorp.

2 2

Thread not detaching?
by Duane Clark 04 Oct '04

04 Oct '04

I have an application that is hanging, apparently because a thread is not detaching: 000a:Call kernel32.ExitThread(00000000) ret=4077907f 000a:Call ntdll.LdrShutdownThread() ret=40376278 000a:Call PE DLL (proc=0x40ea2024,module=0x40ea0000 L"midimap.drv",reason=THREAD_DETACH,res=(nil)) 000a:Ret PE DLL (proc=0x40ea2024,module=0x40ea0000 L"midimap.drv",reason=THREAD_DETACH,res=(nil)) retval=1 000a:Call PE DLL (proc=0x40d4a02c,module=0x40d40000 L"msacm.drv",reason=THREAD_DETACH,res=(nil)) 000a:Ret PE DLL (proc=0x40d4a02c,module=0x40d40000 L"msacm.drv",reason=THREAD_DETACH,res=(nil)) retval=1 000a:Call PE DLL (proc=0x40d1405c,module=0x40d10000 L"wineoss.drv",reason=THREAD_DETACH,res=(nil)) 000a:Ret PE DLL (proc=0x40d1405c,module=0x40d10000 L"wineoss.drv",reason=THREAD_DETACH,res=(nil)) retval=1 000a:Call PE DLL (proc=0x407dc1d8,module=0x407d0000 L"user32.dll",reason=THREAD_DETACH,res=(nil)) 000a:Call ntdll.RtlAllocateHeap(401e0000,00000000,00000080) ret=4080a08c 000a:Ret ntdll.RtlAllocateHeap() retval=4026cfd8 ret=4080a08c err:ntdll:RtlpWaitForCriticalSection section 0x403f2580 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000a, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x408849c0 "../../windows/user.c: USER_SysLevel" wait timed out in thread 000a, blocked by 000b, retrying (60 sec) The place it is happening is in WIN_GetPtr(), in the call to USER_Lock(). It is getting to RtlpWaitForCriticalSection() and hanging forever: 000a:Call PE DLL (proc=0x407dc1d8,module=0x407d0000 L"user32.dll",reason=THREAD_DETACH,res=(nil)) trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlEnterCriticalSection done trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlEnterCriticalSection done trace:win:WIN_DestroyThreadWindows Destroying windows 000a:Call ntdll.RtlAllocateHeap(401e0000,00000000,00000080) ret=4080a08c trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlEnterCriticalSection done 000a:Ret ntdll.RtlAllocateHeap() retval=4026cff8 ret=4080a08c trace:win:WIN_DestroyThreadWindows Start trace:win:WIN_DestroyThreadWindows 0 : 0x10022 trace:win:WIN_IsCurrentThread here trace:win:WIN_GetPtr here trace:win:WIN_GetPtr 1 trace:syslevel:_EnterSysLevel (0x40885ae0, level 2): thread a count before 0 trace:ntdll:RtlEnterCriticalSection Here trace:ntdll:RtlEnterCriticalSection finished SpinCount trace:ntdll:RtlpWaitForCriticalSection Here err:ntdll:RtlpWaitForCriticalSection section 0x403f2580 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000a, retrying (60 sec) Any clues on what should be happening here?

2 5

Setting DllOverrides by script
by Bill Medland 04 Oct '04

04 Oct '04

I stopped concentrating for quite a few months and now the whole config system has changed.!! Any chance of some help? When we released the previous version of our product on Linux we included a couple of perl scripts etc. for setting up the Wine suitably, including adding a couple of drives, setting the path, modifying dll overrides. Now I am trying to figure out how to do it all with the new config system. Doing the drives is easy; a couple of symlinks. Doing the path is easy; regedit /s /E and regedit /s <filename> The problem I am having is with the DLL overrides. I see that they are now based on HKLM\Software\Wine\Wine\DllOverrides. How do I get them in? It seems to me that the only way that works is to edit the config itself and then restart the wineserver. Is that correct? (If so the no big deal) (I can't seem to import into the config using regedit nor can I actually edit the subtree under the GUI) -- Bill Medland mailto:billmedland@mercuryspeed.com http://webhome.idirect.com/~kbmed

3 4

Re: Tab control update
by Robert Shearman 04 Oct '04

04 Oct '04

Jon Griffiths wrote: >Hi, > >A fairly large update to the tab control. This makes it work as per >native in my app. > >Regards, >Jon > > +dlls/comctl32/tab.c dlls/comctl32/tests/tab.c > Items can be variable sized; use an accessor to retrieve them > Send WM_NOTIFYFORMAT/WM_QUERYUISTATE to match native messages > There is no point in sending WM_QUERYUISTATE. I believe it is only really used for the toolbar control, but the native comctl32 has a common framework that means it is sent for all controls. > Only create a scroll control when/if we need one (like native) > Dump tab extra data when tracing > Combine all Unicode/Ascii calls together > Pass infoPtr around instead of fetching it multiple times, store > hwnd and focus state in it too. > Calculate correct tab widths when TCS_FIXEDWIDTH is not given > Code simplifications/const correctness/formatting fixes > Add some new combinations to tests for correct tab sizes > > I haven't looked at the rest of the changes yet and I won't have a chance until Sunday, but the changelog looks sane enough. Is it possible to split the patch up to make it more easily reviewable? Rob

3 5

Re: small fix
by Mike Hearn 04 Oct '04

04 Oct '04

Hi, >Hi! >Here is a small patch for wine-20040914. >Summary: tool window with a caption are not managed. > This doesn't seem quite right - WS_EX_TOOLWINDOW & WS_CAPTION should be managed as we set the EWMH hints for this style later on in the code. What WM are you using Sergey? thanks -mike

1 0

Re: ez-cdda sleep
by Dan Kegel 03 Oct '04

03 Oct '04

Eric Pouech (pouech-eric(a)wanadoo.fr) wrote: > ... > But, the address we get in GetThreadContext is the one from where the > thread waits on the server (hence the 0xffffe410 address), not the > address it was suspended from (as it's supposed to be) > > I don't think it will be easy to fix. > > Possible ideas: > ... > - storing context in server while entering USR1 signal handler (to be > done without races, which will require some more work, as the server > doesn't synchronize with the USR1 handler) This one seems most natural. Maybe the server should wait for the context to be stored before returning from SuspendThread. I bet on Windows, the target thread is really suspended before SuspendThread returns, and this would ensure that behavior. Maybe if we do this right, we can get rid of the racy looking loop at the top of test_SuspendThread() in dlls/kernel/tests/thread.c ... or is that loop needed on Windows, too? - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

2 1

Re: systemparamatersw question
by Ivan Leo Puoti 03 Oct '04

03 Oct '04

>Write a program looping through the SPI values, then use regmon >to find the keys it accesses. Thanks, I'll give this a go. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

1 0

Regression to Get IE Help to Work after September Snapshot
by Dan McGhee 03 Oct '04

03 Oct '04

I could not get IE Help, or any application based on it, to work after the September snapshot. I did a regression and identified the commit of 20040824 16:00:16 CDT as causing the problem. This commit edits this patch: http://cvs.winehq.org/patch.py?id=13475 Among other things this patch changes wine/dlls/Makefile.in wine/configure.ac wine/configure I discovered during the regression that if I use ./tools/wineinstall and let wine set up my fake windows and .wine/config file I couldn't get IE Help to work. However, I used the September snapshot to test this, if I do "./configure, make depend && make" followed by install" and used a .wine generated by wine before the commit I identified, IE Help works. I also noticed when I found the patch that it was edited today to change the files that I noted above, but I can't tell if the changes address the subject of this post. I'm a real rookie when it comes to reading this patches and can suppy only information to this list. If it will help, I will be more than happy to create "diff" files from the "before and after" wine versions to help close in on the situation. Dan

2 5

Re: [Wine] Edit Windows XP registry with wines regedit?
by Saulius Krasuckas 03 Oct '04

03 Oct '04

On Sat, 2 Oct 2004, Martin Bammer wrote: > When I remove the Enum-key under hkey_local_machine then Windows redetects all > hardware. So a reinstall would not be needed. Wine has a regedit. But I don't > know how to tell wine that it uses the registry from the installed windows. For sure it would not be needed, but as for Wines regedit I am not sure. AFAIK, it can only read NT-system registry, but not write it. > Would be a nice "recovery" feature for Linux to be able to edit windows > registries, because a defective registry is often a problem in windows... You can always try using Offline NT Password & Registry Editor. It uses console UI and is more of command line editing, but whatever [1]. BTW, you or someone else can try merging both the ntreg library [1] and Wine registry editor code to make a GUI tool to suffice your needs. I hope there would be no license [2] collisions. [1] http://home.eunet.no/~pnordahl/ntpasswd/ [2] http://home.eunet.no/~pnordahl/ntpasswd/COPYING.txt

2 1

systemparamatersw question
by Ivan Leo Puoti 03 Oct '04

03 Oct '04

Are all SPI values in windows/sysparams.c,SystemInformationW() stored in the registry somewhere? If yes, is there a not to difficult way to find which registry key it is for a given SPI value? I have a few win boxes available to find this out. Ivan. ____________________________________________________________ Libero ADSL: navighi gratis a 1.2 Mega, senza canone e costi di attivazione. Abbonati subito su http://www.libero.it

2 1

TIME_GetTZAsStr problem with "UTC"
by Jacek Caban 02 Oct '04

02 Oct '04

Hi. I got this communicat: fixme:ntdll:TIME_GetTZAsStr Can't match system time zone name "UTC" to an entry in TZ_INFO fixme:ntdll:TIME_GetTZAsStr Please add appropriate entry to TZ_INFO and submit as patch to wine-patches so I wanted to send patch, but "UTC" is time convencion, not Local Time Zone. I've checked my Linux configuration: $ date sob paź 2 23:06:33 UTC 2004 It seems to be bad Linux configuration, but it's my default configuration (I use Fedora Core 2, my Local Time Zone is CEST). I think Wine should do something in this this case, but I don't know what. Any idea? Thanks, Jacek

2 1

Re: Tab control update
by Vitaliy Margolen 02 Oct '04

02 Oct '04

Looks ok to me with few exceptions: It would be really nice to separate formatting changes from other changes. It's hard to see what's got changed and what not. >+#define MIN_ICONTAB_WIDTH 54 /* Magic number, but it works */ >+ if (icon_width > MIN_ICONTAB_WIDTH) >+ curr->rect.right += icon_width; >+ else >+ curr->rect.right += MIN_ICONTAB_WIDTH; This is wrong (see below). >"Only create a scroll control when/if we need one (like native)" Nothing got changed. It's being created when needed, and hidden when not longed used. Is there something else I missed? > Combine all Unicode/Ascii calls together I'm not sure here, but should it be based on the unicode state of the whole control rather which message got sent to it? I can see how you can send ASCII message first and then send UNICODE message which will screw things up. >+/* Since items are variable sized, cannot directly access them */ >+#define TAB_GetItem(info,i) \ >+ ((TAB_ITEM*)((LPBYTE)info->items + (i) * TAB_ITEM_SIZE(info))) If this is the case we need to store pointers in array of pointers. >+ hwTab = create_tabcontrol(0, TCIF_TEXT|TCIF_IMAGE); >+ >+ trace_tab ("Testing non fixed width no imagelist...\n"); You missed insert items with text part inside create_tabcontrol. Besides as is it's failing for me. When I change text of the first tab "Tab 123" it's changing returned width. The reason why I didn't test this is because the width of the tab depends on it's text width. Which is kind of hard to test (different fonts, different font sizes etc.). Vitaliy Margolen Friday, October 1, 2004, 8:58:23 AM, Vitaliy Margolen wrote: > Hi, > A fairly large update to the tab control. This makes it work as per > native in my app. > Regards, > Jon > +dlls/comctl32/tab.c dlls/comctl32/tests/tab.c > Items can be variable sized; use an accessor to retrieve them > Send WM_NOTIFYFORMAT/WM_QUERYUISTATE to match native messages > Only create a scroll control when/if we need one (like native) > Dump tab extra data when tracing > Pass infoPtr around instead of fetching it multiple times, store > hwnd and focus state in it too. > Calculate correct tab widths when TCS_FIXEDWIDTH is not given > Code simplifications/const correctness/formatting fixes > Add some new combinations to tests for correct tab sizes > ===== > "Don't wait for the seas to part, or messiahs to come; > Don't you sit around and waste this chance..." - Live > jon_p_griffiths(a)yahoo.com > __________________________________ > Do you Yahoo!? > Yahoo! Mail Address AutoComplete - You start. We finish. > http://promotions.yahoo.com/new_mail

1 0

Re: Tab control update
by Dimitrie O. Paun 01 Oct '04

01 Oct '04

On Fri, Oct 01, 2004 at 07:58:23AM -0700, Jon Griffiths wrote: > Hi, > > A fairly large update to the tab control. This makes it work as per > native in my app. Nice. While you're at it (and have it fresh in your mind), can you please also provide an audit (and a list of TODOs) as per comctl 6.0? We're getting closer to having a full audit of the controls, and this one has not been audited: http://winehq.org/site/status_ui TIA, Dimi.

2 1

Re: COBJMACROS patch 3
by Dmitry Timoshkov 01 Oct '04

01 Oct '04

"Francois Gouget" <fgouget(a)free.fr> wrote: > COBJMACROS is very C unfriendly as it requires the caller to define it > if it wants to use COM objects. The following check is much better as > it does the right thing automagically: > > #if !defined (__cplusplus) || defined(CINTERFACE) > > So for internal interface, let's use the C friendly check instead of > COBJMACROS. This way we'll have fewer '#define COBJMACROS' to sprinkle > through the code. But that change makes Wine code not compilable with SDK and Mingw headers, I don't think it's an acceptable change. -- Dmitry.

2 3

Troubles with GetVarDesc function.
by MIKEL CARRASCO 01 Oct '04

01 Oct '04

Hi: Recently I've been having troubles with the GetVarDesc function. It's supposed to return the description of a COM server's property(given the property index), but instead, it returns the description of one of the methods of the COM server. I've realized that the varlist list of the ITypeInfo class is filled with the COM server methods, and it must be filled with properties. I think the problem is in MSFT_DoVars function, which is the responsible of the creation of varlist. I've fixed the problem just actualizing the offset variable to point to the begin of the variables description, instead of the begin of the functions description (the bold line below), I don't know if this is the right place to make the correction, but definitely It has solved my problem. .............................. offset = offset + (cFuncs*sizeof(INT)); for(i=0;i<cVars;i++){ .............................. I hope this could be of value for someone... Mikel.

1 0

RE: SystemFunction006
by Rolf Kalbermatter 01 Oct '04

01 Oct '04

Hans Leidekker wrote: +NTSTATUS WINAPI SystemFunction006( LPCSTR password, LPSTR hash ) +{ + unsigned char buffer[16]; + + hash = CRYPT_LMhash( buffer, password, strlen(password) ); + + return STATUS_SUCCESS; +} I don't think this will work properly. The returned pointer from CRYPT_LMHash() will never be passed out to the caller of the function. There should be probably a function call before the return of the function along the lines of memcpy(hash, buffer, 16); The question here would also be why use an intermediate buffer at all in the first place? Also the use of strcmp() for comparing a hash in the according test seems a little misplaced to me. Or is a DES hash guaranteed to never contain 0x00 bytes? It doesn't occur in the test case so it is not a big problem in this case but principially it seems not right to me. Rolf Kalbermatter

2 1

WINEDLLOVERRIDES for all dlls?
by James Hawkins 30 Sep '04

30 Sep '04

Hi, I'm working on getting ie6 sp1 to install without using any native dlls. The install is fine until about 78% of the way through installing the files, the installer loads a native advapi32 that it downloaded to a temp directory and then the install seems to pause as this message is continuously printed: fixme:thunk:CommonUnimpStub generic stub: ? I used WINEDLLOVERRIDES="advapi32=b" WINEDEBUG=+loaddll, and it still shows the downloaded native advapi32.dll being loaded. Does WINEDLLOVERRIDES only take dll's that are in the windows\system directory into account? I have a feeling that the install would go smoother if the builtin advapi32 was loaded instead of the native one. I'm guessing that the installer is calling LoadLibary("path to native advapi32")...that's just a guess though. -- James Hawkins

5 8

Problems with MSI installer
by Joaquín Fernández 30 Sep '04

30 Sep '04

Hello I am trying to install an EXE file packed with MSI. I installed InstMsiA before running the program, but the installer don't finish, stay in endless loop when copying the files, and progress bar is over 70%. I put WINEDEBUG=trace+all and show PENDING() when the installer stop. I ran wine with WINEDLLOVERRIDES="*advapi32=b", WINEDLLOVERRIDES="*advapi32=b;msi=n", WINEDLLOVERRIDES="*advapi32=b;msiexec.exe=n" and WINEDLLOVERRIDES="*advapi32=b;msi,msiexec.exe=n", only the last option let the installer advance but don't finish. So what event wait installer for to continue? Do i need override other(s) dlls when use MSI installer? Regards Joaquín -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

1 0

taking a stab at analyzing a debug log
by James Hawkins 30 Sep '04

30 Sep '04

Hi, I've been trying to get Easy CD Extractor to work for a while now, and the program ezcddax.exe is having some weird (possibly) scheduling and threading problems, so in the meantime I've looked at some of the other exe's that Easy Cd Extractor installed. One such exe is burn.exe. When I run this, it seemingly immediately exits. This is an interesting part of +relay: 0009:Call kernel32.GetModuleHandleA(00000000) ret=0040158a 0009:Ret kernel32.GetModuleHandleA() retval=00400000 ret=0040158a 0009:Call kernel32.GetModuleFileNameA(00400000,406cfc18,00000105) ret=0040114e 0009:Call ntdll.RtlAllocateHeap(40370000,00000000,0000020a) ret=404da841 0009:Ret ntdll.RtlAllocateHeap() retval=403a91d8 ret=404da841 0009:Call ntdll.LdrLockLoaderLock(00000000,00000000,406cfad4) ret=404eafce 0009:Ret ntdll.LdrLockLoaderLock() retval=00000000 ret=404eafce 0009:Call ntdll.LdrFindEntryForAddress(00400000,406cfad0) ret=404eafe0 0009:Ret ntdll.LdrFindEntryForAddress() retval=00000000 ret=404eafe0 0009:Call ntdll.LdrUnlockLoaderLock(00000000,00000009) ret=404eb02c 0009:Ret ntdll.LdrUnlockLoaderLock() retval=00000000 ret=404eb02c 0009:Call ntdll.RtlUnicodeToMultiByteN(406cfc18,00000105,406cfad4,403a91d8,00000 060) ret=404d2873 0009:Ret ntdll.RtlUnicodeToMultiByteN() retval=00000000 ret=404d2873 0009:Call ntdll.RtlFreeHeap(40370000,00000000,403a91d8) ret=404da871 0009:Ret ntdll.RtlFreeHeap() retval=00000001 ret=404da871 0009:Ret kernel32.GetModuleFileNameA() retval=00000030 ret=0040114e 0009:Call kernel32.ExitProcess(00000001) ret=00401454 0009:Call ntdll.LdrShutdownProcess() ret=404f5bd0 It seems that the last system call burn.exe makes before exiting is GetModuleFileNameA. I added an ERR in this function to see what filename it was getting, and it is: err:module:GetModuleFileNameA filename: L"C:\\Program Files\\Easy CD-DA Extractor 7\\burn.exe" which is the path of the program. After this call, burn.exe starts the exit process. Maybe burn.exe didn't like the results from GetModuleFileName? I'm not exactly experienced with analyzing debug logs, so I'm probably way off, but hopefully I'll get better. -- James Hawkins

1 0

Re: MSCMS: implement OpenColorProfile{A,W} and CloseColorProfile
by Hans Leidekker 30 Sep '04

30 Sep '04

On Saturday 25 September 2004 20:29, Hans Leidekker wrote: > Changelog: > Implement color profile handles. > Implement OpenColorProfile{A,W} and CloseColorProfile. Is there anything wrong with this patch? -Hans

1 0

How to deal with C++ APIs in wine spec file
by Dan Kegel 30 Sep '04

30 Sep '04

Jia L Wu (jwu(a)cc.helsinki.fi) wrote: > I have to write a spec file so that a winelib application can use a third > party dll. The problem is that APIs in third party dll are written in C++. > As c++ names and parameters are mangled, how can i call them in spec file? > For example, how can I call a class constructor (which is built form > another class) in spec file? Can anyone provide me an example? Thanks. Did you know that MSVC and g++ have completely incompatible C++ name mangling? In other words, you can only call third party C++ dlls if you're compiling with MSVC, as far as I know. And you can't compile winelib apps with MSVC, since MSCV only generates Windows apps, not Linux apps. So you may be out of luck. Can you write a windows app rather than a winelib app? If so, then you are in business; you can even build it on Linux (by running msvc under wine, which I do fairly often). - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

1 0

Problems with SpamAssassin
by Mike McCormack 30 Sep '04

30 Sep '04

Raphael is having some trouble sending mail to the lists winehq.org. Can we get him whitelisted? Mike

1 0

Strictify make_authors
by Francois Gouget 29 Sep '04

29 Sep '04

I'm not very familiar with this tool so all I can say is that it does not have compilation errors at startup and seems to behave rationally. Changelog: * tools/make_authors Switch to 'perl -w' and add 'use strict;'. Add prototypes to all functions. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Avoid the Gates of Hell - use Linux.

1 0

main menu bar problem
by Attila Csosz 29 Sep '04

29 Sep '04

Hi, We developed an application under windows with borland cbuilder 5 and now we want run under linux with wine (not using an windows partition). We have tried with the latest version ( compiled and installed from CVS ) under "debian testing" linux distribution. This is mainly an opengl application and almost everything works fine but the menu bar dont works, clicking to the menu bar but nothing happened. It seems there is a problem with opengl and the main window. We have tested an other application that uses opengl but with an MDI child window (this works, opengl area in MDI window, main menu in the main window). The original application doesn't have an MDI window. So I think the problem: the main menu is it in the opengl area. Is it possible? We've tested a third application : it has the same problem ( main menu cant be clicked, and this not an MDI application ) We have tried wine in debian-stable, debian-testing, CVS. Thanks for any help (no solution from wine-users) Attila

1 0

[Fwd: Problems installing IE6]
by Joaquín Fernández 29 Sep '04

29 Sep '04

Hello I am trying to install IE6 in wine but i can't. When the installer is over 70% then stop and not advance. I have made a clean fake disk the three times, i probed with WINEDLLOVERRIDES for each dll used by IE installation, i use winedebug for seeking an error but no error, the installer is refreshing the windows without errors but don't advance. I am using wine version 20040914 from CVS compiled in Mandrake 10.0 with cooker updates. I am not using config file because the wineprefixcreate don't make the file and i have seen that wine use now several parameters in the registry. I tryied the 3 methods in frankscorner.org but nothing, the first method using a script can't install it. When i probed the second and third method i made a simple config file with [Version] & [DllOverrides] sections only, but nothing, the program don't terminate the installation, stop after 70% (the % change between intents:70,73,76,81,96, etc) and only refresh the screen (i suppose that because the labels in form are blinking). Somebody can help me? Joaquín P.D.: I don't need IE6 but i need MDAC and MDAC need IE>=4. If somebody know how to install DAO components without installing IE, i am interested in a reply. -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

4 9

Re: Progress Bar: Fix Class Style & Repainting (resend2)
by Alexandre Julliard 29 Sep '04

29 Sep '04

Robert Shearman <rob(a)codeweavers.com> writes: > Changelog: > - Fix class style to include the hbrBackground member. > - Fix repainting issues introduced by this change. > - Add WM_ERASEBKGND handler and remove background drawing code from > the WM_PAINT handler. Isn't that going to cause a lot of flicker? This was the reason for the existing code, because otherwise it looks really bad with apps that update the progress bar a lot. -- Alexandre Julliard julliard(a)winehq.org

4 5

Re: Upgrade management
by Mike Hearn 29 Sep '04

29 Sep '04

[CCd wine-devel as I think you meant it to go there originally] Holly Bostick wrote: > Seems to me that whether or not 99% of users will forget is not your > responsibility as developers. Other than making very sure that users > know there is something to remember, further programming against the > possibility that they will forget what you told them not to is more work > for you, simply in order to absolve them of responsibility for their own > system and make things "look good" at all times to those who want > everything "click and run". > > Look at the problems that attitude (and the compensatory measures to > resolve it) has caused Microsoft. I would think that you all have better > things to do with your valuable development time-- namely developing the > actual application, not babysitting me (the user with the mind like a > sieve). Well, there are a couple of good reasons why automatic upgrades are good for us developers: 1) If we don't, we'll just get bug reports due to people not having full upgrades: we already get plenty of bizarre bug reports due to broken packaging, last thing we need is for people to fill bugzilla with even more. And yes some developers do tech support :) 2) We already do a ton of stuff automatically, and nobody ever notices. This strongly implies that automatic setup and configuration does benefit people: I can assure you they noticed when we didn't set up the wine config upstream! We want Wine to have a good reputation for reliability, but currently it doesn't - people run random Foo app, it crashes and burns maybe due to incorrect configuration and they walk away saying "Oh well, Wine is crap, what did I expect?". This happens quite a bit. Ensuring the user is cleanly and transparently upgraded makes things Just Work to a greater extent, which is good for everybody. I'm still not hugely convinced about the backup thing: if you want to back up your configuration before upgrading Wine it's very easy: cp -rv ~/.wine ~/.wine.old ... we could even do that as part of the upgrade process. Possibly we should back up the registry, but not the virtual drive C. The C drive is going to change a lot less than the registry will: a Wine upgrade typically means new DLLs and maybe new registry contents. It rarely means changes to the drive layout. thanks -mike

1 0

How to deal with C++ APIs in wine spec file
by Jia L Wu 29 Sep '04

29 Sep '04

Hi, I have to write a spec file so that a winelib application can use a third party dll. The problem is that APIs in third party dll are written in C++. As c++ names and parameters are mangled, how can i call them in spec file? For example, how can I call a class constructor (which is built form another class) in spec file? Can anyone provide me an example? Thanks. Wu

1 0

Re: Moved some local variables from StartServiceCtrlDispatcherA/W to service environment block
by Alexandre Julliard 29 Sep '04

29 Sep '04

"Alexander Yaworsky" <yaworsky(a)migusoft.ru> writes: > ChangeLog: > > Moved some local variables from StartServiceCtrlDispatcherA/W to service environment block. > Introduced helper function service_ctrl_dispatcher. I don't think you want to pass ASCII strings across processes, there's no guarantee that both processes are using the same codepage. Inter-process communication should always be done in Unicode. -- Alexandre Julliard julliard(a)winehq.org

2 1

Updated winecfg to do list
by Mike Hearn 29 Sep '04

29 Sep '04

OK, well assuming that Alexandre commits the last of my patches to winecfg at some point (I suspect there is a reason they aren't already ...), here is the updated todo list for winecfg based on my last email on the subject: http://www.winehq.org/hypermail/wine-devel/2004/08/0007.html I'm probably not going to do any more work on winecfg for a while. > You probably want to increase the size of the drive mappings list so it > fills the tab, currently there is just a lot of empty space at the top of > the pane now you removed the old stuff. If AJ commits the last two patches, this is done. In fact, the editing has been moved into the main tab, as there isn't much reason to have a separate window for this and it simplifies the UI and code somewhat. > Also we should kill the autodetect button. This is done by > wineprefixcreate these days, or should be. Getting there ... drive autodetection is implemented. The heuristics could perhaps be improved but they'll do for now. But, we need to call it from wineprefixcreate. This means adding code like so to main(): if (argv[0] is "--drive-detect") { gui_mode = FALSE; auto_detect_drives(); return apply_drive_changes(); } > - Drive editing seems broken. The list box only updates the second time I > hit edit. err:winecfg:applyDriveChanges unable to set volume label for > devicename of 'H:\', label of '' With my last two patches, this works for me. > - Browse in the "Add/Edit drive" dialog is a WRITEME Oh hum, good point. I suspect this still does nothing, I don't remember. We need to make sure / is mapped (there is a function to do this in drivedetect.c), trigger the shell directory select dialog, then if we had to map / automatically, unmap it again. Not too hard to implement. We can probably slide this for 0.9, it's not essential. > - Build system isn't right: I did a cvs update but the res files weren't > recreated properly. I had to do a make clean to get the gui updates. Probably my [ab]uses of make depend, can be ignored. > - "Add Application" has poor usability: we always use a file browser > dialog box even though the most common use case is just "foo.exe", ie > the user knows the name and doesn't care about the location. Worse we > start in the c:\windows\desktop folder for some reason, meaning users > might accidentally select a .lnk file! Well, we still use a file open dialog but at least it starts in c:\ now and is filtered on EXE files. If somebody wants to implement a natty dialog like the GNOME run window, go for it! This would be a nice usability improvement, especially if you implemented then used listview tile mode. > - The Add/Remove application buttons are *way* too big! Fixed > - Obviously, once audio autodetection has been moved into the drivers we > need to kill the audio tab. Still needs to be done. Not all that hard. > - Libraries tab just has generally poor usability, actually. The first > item in the radio group is "Builtin" meaning that's the one users are > most likely to select, it should be "builtin, native" followed by "native, > builtin" Lots of tweaks to this tab, I find it a lot more convenient to work with now. The main remaining problem is that enter always triggers OK in the applet itself, and when you're typing in a new DLL you want to add, you want enter to add it not close the window! Not sure how to fix this without messing up the property sheet API. > - We ask the user to understand a magic * symbol to set the default - what > is up with that? Fixed. > - There are no helpful default entries in the drop down box for setting a > DLL override, and when you add one the tree does not expand so to actually > *set* it you have to expand the tree then select the new override. It doesn't use a treeview anymore, but the combo box could definitely use some of the most common entries to give people a hint. > - We have way too many (eg, more than zero) tree controls in this app. Fixed. This simplifies the code enormously. I don't think there's really any problem with selecting the app you want to edit on the first tab and it means there aren't any wierd states anymore where you can have a selection in the treeview that doesn't actually mean anything. The titlebar now reflects the app you're editing. > - Drive mappings list is really unclear, there's no separation between the > "Drive X:" label and the unix path its mapped to. This is improved a bit now too but really I'd like to see us use the listview control with a header control here. So in summary the BIG things we need to do before we can consider winecfg good enough for 0.9 are: * Delete the audio tab and use autodetection at wine startup instead * Add a --drive-detect switch and use it from wineprefixcreate * Update the docs to reflect usage of the new tool (Brian is on this) After 0.9 we can look at more UI improvements, importing some artwork to make it prettier, maybe eliminating the property sheet as that's a big pain to work with (though, it may be also that our control is buggy :), and so on. Probably adding more prefs as well, for things like printing and fonts maybe. I'd like to see us get winecfg to some kind of finished, releasable 1.0 state before the end of the year though and then we can mark that task as done on the TODO list. thanks -mike

1 0

Upgrade management
by Mike Hearn 29 Sep '04

29 Sep '04

There are a bunch of different ways we may want to upgrade the users configuration: - Changes to $WINEPREFIX (~/.wine), for example: - Introducing faked DLL headers - Improved drive detection - Changing the way the registry is stored - Adding stuff to the virtual Windows drive - Modifying the registry - Adding new keys - Adding new appdefaults (default config options should be in the code itself). While we have a policy of not having app-specific hacks in Wine, some situations are very hard to resolve without custom overrides. The Internet Explorer installer does a bunch of things we really don't want it to do. The DCOM installer needs custom overrides to convince it to install. And so on. - Registering new COM DLLs (these all boil down to rerunning wine.inf) - Adding new binaries such as fonts, PE DLLs (think Moz AX control), and so on. These may be placed somewhere in the Wine install directory and then symlinked or copied (presumably linked) into drive C. This leads to the following questions: - How do we know when to upgrade the users wineprefix? - How do we avoid disturbing the users configuration? - What implementation do we use to upgrade it? One potential implementation for knowing when to upgrade the wineprefix is to version it in a similar manner to how we version the wineserver protocol: with a simple incrementing integer. This could be stored in the registry, and Wines initialization sequence changed to be: ... Does $WINEPREFIX exist? No, call wineprefixcreate - Continue with startup + Yes? Check the wineprefix version key, if it is < the + version compiled into the source run + "wineprefixcreate --upgrade $oldversion $newversion", which then + performs the upgrade. If it exits with a zero exit code, the + version key is set to the number compiled into the source. + Then continue with startup If registry access is too difficult here, a simpler implementation could be used: just store the number in a .version file. How do we avoid disturbing the users configuration? Alexandre already laid out the plan for this, which is to have HKLM (HKEY_LOCAL_MACHINE) devoted to the defaults we cunningly choose for maximum kewlness, and HKCU (HKEY_CURRENT_USER) is where the users settings are stored. These override the defaults, meaning we can change the default settings by altering wine.inf, then bumping the wineprefix version so triggering a remerge of the default registry contents. This means modifying each piece of code where we read the registry to figure out a user-configurable option. The algorithm becomes: * Check the relevant key in HKCU, if it exists use it * Otherwise, if it's an appdefault, check the same key in HKLM * Otherwise, use the hardcoded default In most cases, there's no point in duplicating the points at which we can control the defaults, doing it in the code is fine. So, it basically means grepping the source to find out where we read settings from, and changing them to use HKCU instead of HKLM, perhaps also reading HKLM depending on the context of the setting (settings that can be used in appdefaults should check both). I don't know how common these settings are but it might be worth having a utility function either in a DLL or inline in a header to do this. Registry code isn't complicated but it is tedious and easy to mess up, so we might as well reduce code duplication at the same time. I think the best implementation is to keep the code responsible for managing WINEPREFIX in wineprefixcreate, and simply extend this program to handle upgrades as well. OK, so the name will be a bit inaccurate but let's not change it - users are already discovering the new program and getting used to it, no need to modify it now especially as it's mostly an internal program. In the above example the old version and new version numbers were passed to wineprefixcreate but most of the time that information wouldn't be needed, for instance if we were to introduce fake DLL headers we could simply check if they already existed and skip that part if so. I think there's no harm in running wine.inf multiple times, so we could just do that every time for both creation and upgrade. I *think* this addresses most of the issues with upgrades, though I'm sure Alexandre can think of more :) Potential unresolved problems: - [How] do we lock wineprefix during upgrade so other processes that are run hang about until it's done? - Currently moving registry keys about is done actually in the code itself: we copy it across then print a message telling the user to delete the old setting manually. There's a fair bit of evidence that some users simply don't spot/understand these warnings. Also, we want to allow people to upgrade Wine with quite long intervals in between yet eventually this code gets deleted. Maybe a better solution is just to have wineprefixcreate understand how to move registry keys around in response to bumping the version. If the script gets too unwieldy, we could split particular upgrades into separate scripts in $prefix/share/wine. - Are there any wierd setups where parts of wineprefix are shared between different users/systems that we need to take into account? Thoughts? Comments? thanks -mike

4 8

WineHQ Downloads Page
by Adam Schreiber 28 Sep '04

28 Sep '04

Could whoever is responsible for updating the website please change the Download page(http://winehq.com/site/download) to read: "Slackware binary .tgz for Slackware" or "Slackware binary .tgz for Slackware 10" The reference to Slackware 9 is confusing users. Thanks, Adam Schreiber -- Why isn't all of your email encrypted? http://gnupg.org http://enigmail.mozdev.org

1 0

Re: urlmon: IInternetSecurityManager
by Mike McCormack 28 Sep '04

28 Sep '04

Huw D M Davies wrote: > Good catch. This classfactory code is fairly pervasive in Wine. I'll > submit a patch fixing all other occurrences of this in a moment. Maybe we should make a new janitorial task to turn all those class factories into singleton into objects too. It's not necessary to allocate a piece of memory at all for a class factory. Mike

4 5

Re: SystemFunction036 debugging problem
by James Hawkins 28 Sep '04

28 Sep '04

> Is this program linking to SystemFunction036 statically or dynamically? I'm not really sure. Is there another way to tell besides doing a trace+all? > If it is linking dynamically (i.e. with GetProcAddresa), one option to try > is to completly remove SystemFunction036 so it is not exported from > advapi32.dll. It might then be that the apps that call it will see that it > is not present and do something else. Actually I just added the stub to advapi32, because the program will crash when it tries to call an umimplemented function. The main problem is that the program is expecting some result from SystemFunction036 (Filip thinks it might be a random generator thing), but it's next to impossible (or so it seems) to implement it correctly without documentation of what it does. I wanted to be able to see which function calls this to see whether I can get in there and keep it from calling. On Tue, 28 Sep 2004 07:01:33 +0800, Jonathan Wilson <jonwil(a)tpgi.com.au> wrote: > Is this program linking to SystemFunction036 statically or dynamically? > > If it is linking dynamically (i.e. with GetProcAddresa), one option to try > is to completly remove SystemFunction036 so it is not exported from > advapi32.dll. It might then be that the apps that call it will see that it > is not present and do something else. > > Another option is to try to contact the author of the app in question > (MyPhotoCalendars or whatever it is) and ask them about the function. > > -- James Hawkins

2 1

SystemFunction036 debugging problem
by James Hawkins 28 Sep '04

28 Sep '04

It turns out that SystemFunction036 is actually required to do something for MyPhotoCalendars.exe to install correctly because the installer exits with a program-level exception (ie not wine) What I would like to do is run MyPhot...exe with winedbg and then set a breakpoint for SystemFunction036 so that execution will stop when that function is called so I can see who is calling it or something along those lines, but I set the break point and when SystemFunction036 is called, the program doesnt stop at all. winedbg MyPhotoCalendars.exe WineDbg starting on pid 0xa In 32 bit mode. 1249 static inline void WINAPI DbgBreakPoint(void) { __asm__ __volatile__("int3"); } Wine-dbg>break SystemFunction036 fixme:dbghelp:elf_load_debug_info Unsupported Dwarf2 information for ld-linux.so.2 Breakpoint 1 at 0x4089a670 SystemFunction036 [/home/truiken/wine/dlls/advapi32/crypt.c:1914] in advapi32 Wine-dbg>step 1019 ExitProcess( entry( peb ) ); Wine-dbg>step Single stepping until exit from function, which has no line number information. ......... fixme:crypt:SystemFunction036 ( _A)l@H¦X@`ùm@%!D, 256): stub fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE fixme:crypt:SystemFunction036 (H¦X@, 256): stub fixme:actctx:FindActCtxSectionGuid stub! Invalid address (0x00404aa2) for breakpoint 0, disabling it Invalid address (0x4089a670) for breakpoint 1, disabling it Process of pid=0x0000000a has terminated Wine-dbg>bt You must be attached to a process to run this command. Any thoughts? -- James Hawkins

2 1

missing advapi32 prototype: SystemFunction036
by James Hawkins 28 Sep '04

28 Sep '04

While trying to install MyPhotoCalendars, an exception is raised because of a call to the unimplemented function advapi32.dll.SystemFunction036. >From reading the following post, http://www.winehq.com/hypermail/wine-devel/2003/09/0265.html I can see that it won't be very easy to even stub this function because it's a hidden api. What methods could I use to track down any information about this function or its prototype? -- James Hawkins

4 9

Re: urlmon: IInternetSecurityManager
by Robert Shearman 28 Sep '04

28 Sep '04

Huw D M Davies wrote: > Huw Davies <huw(a)codeweavers.com> > Stub implementation of IInternetSecurityManager > Add a classfactory > Fix calling convention of CoInternetCreateSecurityManager > > >+ >+static ULONG WINAPI CF_AddRef(LPCLASSFACTORY iface) { >+ IClassFactoryImpl *This = (IClassFactoryImpl *)iface; >+ return ++(This->ref); >+} >+ > Please try to use Interlocked* functions for ref-counting as it is currently a janitorial task to clean up this type of code and I don't think they are desparate for more work. >+static HRESULT WINAPI CF_CreateInstance(LPCLASSFACTORY iface, LPUNKNOWN pOuter, >+ REFIID riid, LPVOID *ppobj) { >+ IClassFactoryImpl *This = (IClassFactoryImpl *)iface; >+ HRESULT hres; >+ LPUNKNOWN punk; >+ >+ TRACE("(%p)->(%p,%s,%p)\n",This,pOuter,debugstr_guid(riid),ppobj); >+ >+ hres = This->pfnCreateInstance(pOuter, (LPVOID *) &punk); >+ if (FAILED(hres)) { >+ *ppobj = NULL; >+ return hres; >+ } >+ hres = IUnknown_QueryInterface(punk, riid, ppobj); >+ if (FAILED(hres)) { >+ *ppobj = NULL; >+ return hres; > You leak a reference on failure here. >+ } >+ IUnknown_Release(punk); >+ return hres; >+} > >+/***************************************************************************** >+ * IInternetSecurityManager interface >+ */ >+cpp_quote("#define SID_SInternetSecurityManager IID_IInternetSecurityManager") >+ >+[ >+ object, >+ uuid(79eac9ee-baf9-11ce-8c82-00aa004ba90b), >+ pointer_default(unique) >+] >+interface IInternetSecurityManager : IUnknown >+{ >+ HRESULT SetSecuritySite( >+ [in, unique] IInternetSecurityMgrSite *pSite); >+ >+ HRESULT GetSecuritySite( >+ [out] IInternetSecurityMgrSite **ppSite); >+ >+ HRESULT MapUrlToZone( >+ [in] LPCWSTR pwszUrl, >+ [out] DWORD *pdwZone, >+ [in] DWORD dwFlags); >+ >+cpp_quote("#define MAX_SIZE_SECURITY_ID 512") > It is probably better to put this outside the interface declaration as I'm not sure if midl and widl are consistent about not outputting this twice. >+HRESULT SecManagerImpl_Construct(IUnknown *pUnkOuter, LPVOID *ppobj) >+{ >+ SecManagerImpl *This; > >+ >+ TRACE("(%p,%p)\n",pUnkOuter,ppobj); >+ This = HeapAlloc(GetProcessHeap(), 0, sizeof(*This)); > > The convention with COM interfaces is to use the CoTaskMemAlloc / CoTaskMemFree memory management functions instead of the Heap ones (even though they are the same). This is just a slight nit-pick. >+ >+ /* Initialize the virtual function table. */ >+ This->lpvtbl1 = &VT_SecManagerImpl; >+ This->ref = 1; >+ >+ *ppobj = This; >+ return S_OK; >+} > Rob

2 1

Re: PATCH: imagelist: change ERR to TRACE
by Andreas Mohr 28 Sep '04

28 Sep '04

Hi, On Tue, Sep 28, 2004 at 06:44:16AM +0200, Michael Stefaniuc wrote: > Hello, > > License: LGPL, X11 > Changelog: > Michael Stefaniuc <mstefani(a)redhat.com> > - native ImageList_Remove dosn't spit out an error message when > deleting an index out of range so don't do that either Probably true, but native ImageList_Remove doesn't have its whole Windows environment completely buggy either. ;-) IOW: this was perhaps meant for Wine code bug tracking purposes (AFAIK Wine uses imagelists a lot internally, e.g. shell code or so). While an ERR is too verbose, TRACE is ill-suited for that (a wrong index certainly is an anomaly); thus I'd say it should be a WARN. Greetings, Andreas Mohr

2 1

Re: MakeSureDirectoryPathExists improvement
by Alexandre Julliard 28 Sep '04

28 Sep '04

Wolfgang Schwotzer <wolfgang.schwotzer(a)gmx.net> writes: > @@ -91,13 +91,28 @@ > */ > BOOL WINAPI MakeSureDirectoryPathExists(LPCSTR DirPath) > { > - if (CreateDirectoryA(DirPath, NULL)) return TRUE; > - if (GetLastError() == ERROR_ALREADY_EXISTS) > + char path[MAX_PATH]; > + const char *p = DirPath; > + int n; > + > + if (strchr(p, ':') != NULL) > + p = strchr(p, ':'); > + while ((p = strchr(p, '\\')) != NULL) > { > - SetLastError(ERROR_SUCCESS); > - return TRUE; > + n = p - DirPath + 1; > + strncpy(path, DirPath, n); > + path[n] = '\0'; > + if( !CreateDirectoryA(path, NULL) && > + (GetLastError() != ERROR_ACCESS_DENIED) && > + (GetLastError() != ERROR_ALREADY_EXISTS)) > + return FALSE; > + p++; > } > - return FALSE; > + if (GetLastError() == ERROR_ACCESS_DENIED || > + (GetLastError() == ERROR_ALREADY_EXISTS)) > + SetLastError(ERROR_SUCCESS); > + > + return TRUE; I don't think you want to simply ignore ERROR_ACCESS_DENIED. You should fix your algorithm to not try to create the drive root and then ignore only ERROR_ALREADY_EXISTS. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Add Makefile rules to rebuild resource file when translations change
by Alexandre Julliard 28 Sep '04

28 Sep '04

Mike Hearn <mike(a)navi.cx> writes: > Add Makefile rules to rebuild resource file when translations change 'make depend' is a convenient way to do that, maybe you should give it a try ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: stub implementation SystemFunction036
by Filip Navara 28 Sep '04

28 Sep '04

James Hawkins wrote: >+ >+VOID WINAPI SystemFunction036(PCHAR Buffer, INT BufferSize) >+{ >+ FIXME("(%s, %i): stub\n", Buffer, BufferSize); >+} >+ > > If you really want to stub this function then please don't print the buffer contents. It's an output buffer and contains garbage (maybe the garbage means something, but still it's garbage). - Filip

2 1

Re: SystemFunction036 debugging problem
by James Hawkins 27 Sep '04

27 Sep '04

> Is the target (the thing calling SystemFunction036) available to download > anywhere? Yea. here's the link: http://www.download.com/redir?pid=10287361&merid=107235&mfgid=107235&lop=li… On Tue, 28 Sep 2004 07:29:14 +0800, Jonathan Wilson <jonwil(a)tpgi.com.au> wrote: > Is the target (the thing calling SystemFunction036) available to download > anywhere? > > -- James Hawkins

1 0

Problems installing office 2k.
by James Pellow 27 Sep '04

27 Sep '04

Hi List, I just installed wine from cvs as of this morning and am still having problems installing office. I get the following error when starting the installer with the msi debugging channel on: fixme:msi:MsiEnableLogA 00000516 "c:\\windows\\temp\\Office 2000 Professional Setup (0014)_MsiExec.txt" 00000000 trace:msi:MsiEnableLogW 00000516 L"c:\\windows\\temp\\Office 2000 Professional Setup (0014)_MsiExec.txt" 00000000 trace:msi:MsiInstallProductA "/I" "" fixme:msi:MsiInstallProductW L"/I" L"" trace:msi:MsiVerifyPackageW L"/I" trace:msi:MsiOpenDatabaseW L"/I" (null) 0x4055fd78 trace:msi:MSI_OpenDatabaseW L"/I" (null) fixme:msi:MSI_OpenDatabaseW open failed r = 80004005! trace:msi:MsiCloseHandle 405aa5aa Installation of /I () failed. Mike had suggested I not use the builtin msi.dll. Since no native msi system was installed, the office 2k installer to tried to install one resulting in the following error: fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to (nil) fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to 0x50 err:ntdll:NtQueryInformationToken Unhandled Token Information class 8! fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to 0x44 fixme:powermgnt:SetThreadExecutionState (0x80000001): stub, harmless. fixme:powermgnt:SetThreadExecutionState (0x80000000): stub, harmless. fixme:thread:NtSetInformationThread Set ThreadImpersonationToken handle to (nil) Installation of /i (REBOOT=REALLYSUPRESS) failed. It is suprising to me that nobody else has reported this office 2k msi problem. I guess everyone is using OpenOffice these days :) I really don't use wine much, but I have been following its progress over the years and compile and test it once in a while. I am happy to do a little more debugging if someone wanted to give me some pointers. Thanks. Cheers, James -- ***************************** James A. Pellow, President Alent Design Solutions www.alentdesignsolutions.com (509) 526-0682 *****************************

1 0

edonkey2000 dll err
by J. Grant 27 Sep '04

27 Sep '04

Hello, As this is an "err, I thought I should post the the devl list. I am using CVS build from 2004-09-20. I am using DLL's copied from working win2k install. It seems quite fatal, any ideas? Kind regards JG c:\opt\ed2k>edonkey2000.exe c:\opt\ed2k>err:module:import_dll No implementation for MSVCRT.dll.??_U@YAPAXI@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V@YAXPAX@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

3 3

Re: Getting winebuild to work on HP-UX
by Warren_Baird/CSI＠cimmetry.com 27 Sep '04

27 Sep '04

"Eric Frias" <efrias(a)syncad.com> wrote on 09/27/2004 09:52:12 AM: > I don't know if this made it through on Thursday; if not, here's a repeat: I saw it on the archive - sorry I didn't get a chance to respond on Friday. Thanks for the repeat, though - it saves me cutting and pasting from the browser. :-) > I'm afraid I won't be a lot of help right now, but I might be able to offer > some moral support. Well - at this point even moral support would be a good thing... > I've spent several weeks last year trying to get > winelib working on HPUX, but I don't really have anything to show for it. > Before I could get anything working, I had to abandon HPUX and work on > fixing up Linux and Solaris stuff because it was in higher demand. I'll > eventually need to get HPUX working also, but I won't be able to devote too > much time to it for at least a month. My timeline is probably tighter than that - I'm hoping to have winelib working within the next month... So you might be lucky. :-) > I was in the same situation as you are... very rusty at x86 assembly, able > to comprehend a little sparc assembly, but I didn't know a thing about > pa-risc. I was simply typing make, letting it run until it had some error > because HPUX wasn't supported, coming up with some fix for it, and > repeating. Some days I felt like I almost grasped what was going on and how > to fix it, and some days it felt like it was miles away. I never got all of > wine compiling, so I have no idea if any of the fixes I made were correct or > not. I'd be happy to share them with you, but seeing them might do you more > harm than good. Yeah, if you wouldn't mind, send me the patches --- It may give me some useful ideas, at least. > Anyway, good luck, and if you weren't looking for an excuse to learn pa-risc > assembly, well, you have my sympathies. I'm told it builds character :-) :-) then I guess my character is in for a bit of a work-out. <sigh> Thanks, Warren -- Warren Baird, Technical Group Leader warren_baird(a)cimmetry.com Cimmetry System Inc. 514 735 3219 x148

1 0

Wine User Guide changes (RFC)
by Brian Vincent 27 Sep '04

27 Sep '04

With Mike's recent Winecfg patches and the renewed hope we'll cut over to using Winecfg some day, I went through and began updating the Wine User Guide. The focus of the changes thus far was to remove references to the config file and discuss Winecfg instead. Without actually being able to use Winecfg these changes are useless, but it's probably worth looking this over to see whether these docs are headed in the right direction. For now, the biggest changes can be found in configuring.sgml (which translates into the "Configuring Wine" part of the guide.) A diff is available here: http://www.theshell.com/~vinn/wine-user-guide.diff However, this stuff is best looked at as a side-by-side comparison with the existing docs. You can find that here: http://www.theshell.com/~vinn/wine-user-guide.html (Not having looked at Mike's recent patches, I'm sure this will soon be out of date. Things like drive detection are missing. There's also parts that I left undone: such as the printing config, an appendix listing reg keys would be nice once we know what they all are. Other parts probably need a better explanation, such as font configuration. Anything you notice missing is probably worth telling me about, though it won't be hard to find lots of mistakes.) One of the big goals of all this is to reduce the amount of documentation and outdated stuff. Therefore, registry.sgml, printing.sgml, and fonts.sgml have been somewhat merged into configuring.sgml. fonts.sgml contained a lot of outdated info in it that probably caused more confusion than helped. Going forward, we have a lot of documentation in the User Guide about downloading Wine, compiling Wine, CVS, etc; mostly stuff that's already duplicated in some form or another on the web site. I'd like to see as much stuff like that removed from the User Guide as possible, we can simply refer people to WineHQ for more info. (I think the reason for the duplication is that the website docs simply didn't exist when the User Guide was written, now the website has superceded the User Guide.) When it's all said and done we should be left with the following sections: - Introduction - Configuration - Running - Troubleshooting At least, that's the direction I think it should go and at some point I could begin making those changes. Anyone disagree? Any thoughts, comments, concerns, criticisms? -Brian

2 1

tree/list-view slowness
by James Hawkins 27 Sep '04

27 Sep '04

I am currently working on making Kazaa Lite 2.4.3 more usable. The most major problem remaining is that when the user chooses to search for a file on the network, the program slows almost to a halt and becomes mostly unmanageable. The results are displayed in a tree/list-view in the right pane [1]. I've looked into both of the controls, and it seems like the slowness could be coming from their implementation, but even when I set comctl32 to native, the problem remains. Also, I've done a trace+treeview and a trace+listview and only treeview api's seem to be called and not listview. Would it be a possibility that they implemented their own listview? Can anyone describe a method I can use to track down the inefficiency? Thankyou for your help. [1] http://www.andrew.cmu.edu/user/jhawkins/klite.jpeg -- James Hawkins

2 1

Re: Listbox fixes
by Alexandre Julliard 27 Sep '04

27 Sep '04

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > +dlls/user/listbox.c > Draw background of the empty selected item in empty lists > Dont draw a focus rect if we do not have the focus > Dont select items on key up/down in multi-select lists This is causing a test failure: listbox.c:134: Test failed: style 0x8, step step, field selected: expected 2, got 1 listbox.c:134: Test succeeded inside todo block: style 0x8, step step, field selcount: expected 1, got 1 (the second one is a good thing of course...) -- Alexandre Julliard julliard(a)winehq.org

5 6

slovenian keyboard support
by Rok 26 Sep '04

26 Sep '04

I'm using slackware 10, KDE and Wine 20040914 (binary) and have problems using specific letters: ---cut-here--- err:keyboard:X11DRV_ToUniCodeEx Please report: no char for keysym 01E8 (ccaron) : err:keyboard:X11DRV_ToUniCodeEx (virtKey=E2,scanCode=62,keycode=2F,state=10) err:keyboard:X11DRV_ToUniCodeEx Please report: no char for keysym 01C8 (Ccaron) : err:keyboard:X11DRV_ToUniCodeEx (virtKey=E2,scanCode=62,keycode=2F,state=11) err:keyboard:X11DRV_ToUniCodeEx Please report: no char for keysym 01B9 (scaron) : err:keyboard:X11DRV_ToUniCodeEx (virtKey=E0,scanCode=60,keycode=22,state=10) ... ---cut-here--- I'd need letters [cCsSzZ]caron [cC]acute [dD]stroke. Is there any this can be resolved? Thanks! LP,Rok.

2 1

(no subject)
by Arda Ataerkil 26 Sep '04

26 Sep '04

hi. i m new user Linux redhat. jop is Graphic Desgner. i want to shot Win Xp enought for virus and all bad thinks. but i need to use photoshop, flash, and other soft working with Windows. and i learned yesterday "wine" is makeing work with linux this software. is it true. i try to download it . but couldent find anywhere. could you give mea link . where ami download it. At your site too much packages . could you give to me a link all packages at 1 download file. couse i m newer user to diffucult do set up and download it for me at now. Regards.

2 1

Re: wine/loader preloader.c
by Mike Hearn 26 Sep '04

26 Sep '04

Hi Alexandre! What's the reasoning for this change? I thought the preloader should not be built as a PIE because otherwise the kernel could map it into one of the areas we need to reserve. More to the point, the people trying to do this are thinking it will increase security. It won't, even though this code is loaded at a known offset it does not contain any code you could exploit in a return-to-libc type attack and anyway, exploits through Wine are far more likely to come in through the software being run on it than Wine itself. There is a patch in bugzilla (I guess you saw this) to ensure -fno-pie and -fno-stack-protector is passed to gcc for the preloader. thanks -mike > Log message: > Support compiling with -fPIC for people who somehow think this is a > good idea.

4 3

Missing dll's and wine says it is going into debugger
by J. Grant 25 Sep '04

25 Sep '04

Hello, I have installed eDonkey2000, the free version from www.overnet.com. I am using a one day old CVS build of WINE. Could there be a Debug/Retry option for dll loading? then I would have time to copy the dlls and press Retry. As it is, I have to restart the entire process for each dll missing. fixme:win:SetWindowTextA cannot set text "Output folder: C:\\opt\\ed2k" of other process window 0x2006a fixme:win:SetWindowTextA cannot set text "Execute: C:\\opt\\ed2k\\eDonkey2000.exe" of other process window 0x2006a wine: Unhandled exception (thread 000b), starting debugger... err:seh:EXC_DefaultHandling Unhandled exception code c0000005 flags 0 addr 0x401c88e8 err:module:import_dll Library MSVCP60.dll (which is needed by L"C:\\opt\\ed2k\\edonkey2000.exe") not found err:module:import_dll Library MSVCIRT.dll (which is needed by L"C:\\opt\\ed2k\\edonkey2000.exe") not found Usage: winedbg [--auto] [--gdb] cmdline err:module:LdrInitializeThunk Main exe initialization for L"C:\\opt\\ed2k\\edonkey2000.exe" failed, status c0000135 These are the two dlls which were displayed on my terminal. It did not end up in the debugger though, just the terminal after I pressed ESC <Enter>. After I copied these dlls, and restarted the process I get this text: c:\opt\ed2k>edonkey2000.exe c:\opt\ed2k>err:module:import_dll No implementation for MSVCRT.dll.??_U@YAPAXI@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V@YAXPAX@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef although it is an "err" the process continues to run... would you like me to try and probe this dll futher to get the missing impelementation name it is complaining about? (if that would help) I am not on this list, so please include my email address in replies. Kind regards JG -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

5 6

RE: Help with GetConsoleWindow()
by Ewert, Mark 25 Sep '04

25 Sep '04

Here's a more detailed dump: WineDbg starting on pid 0x8 Unhandled exception: page fault on write access to 0x41a41754 in 32-bit code (0x10007239). In 32 bit mode. 000f:err:dbghelp_msc:codeview_process_info Unknown CODEVIEW signature 53445352 in module xdb Register dump: CS:0023 SS:002b DS:002b ES:002b FS:121f GS:002f EIP:10007239 ESP:44b5008c EBP:44b500ac EFLAGS:00010206( - 00 - RIP1) EAX:412e01e0 EBX:412e0098 ECX:0064ffcc EDX:413f178c ESI:0000003f EDI:413f200c Stack dump: 0x44b5008c: 00000000 00000090 0000008c 00000000 0x44b5009c: 000000a0 412e0324 0064ffcc 00000000 0x44b500ac: 44b500e4 10008f98 412e0098 00000000 0x44b500bc: 00000002 4020521c 0000008c 00000000 0x44b500cc: 44b500b8 44b4fc70 44b50124 100072dc 0x44b500dc: 10012060 00000000 44b500f8 10004c39 0243: sel=121f base=405ab000 limit=00001fff 32-bit rw- Backtrace: =>1 0x10007239 (0x44b500ac) 2 0x10008f98 (0x44b500e4) 3 0x10004c39 (0x44b500f8) 4 0x10004ce6 EntryPoint+0x5d in xdb (0x44b50134) 5 0x401d3c66 call_dll_entry_point+0x12 in ntdll (0x44b5014c) 6 0x401d4c61 MODULE_InitDLL+0x121(wm=0x403b9830, reason=0x2, lpReserved=0x0) [/home/wine-20040914/dlls/ntdll/loader.c:741] in ntdll (0x44b501b8) 7 0x401d4f47 MODULE_DllThreadAttach+0x77(lpReserved=0x0) [/home/wine-20040914/dlls/ntdll/loader.c:894] in ntdll (0x44b501e0) 8 0x4053aea3 THREAD_Start+0x73(ptr=0x403f8df8) [/home/wine-20040914/dlls/kernel/thread.c:107] in kernel32 (0x44b502a8) 9 0x401e956b start_thread+0x14b(info=0x403f8420) [/home/wine-20040914/dlls/ntdll/thread.c:199] in ntdll (0x44b50ae4) 10 0x40048c3f pthread_start_thread+0x16f(arg=0x44b50be0) [/usr/src/build/230306-i686/BUILD/glibc-2.2.4/linuxthreads/manager.c:287] in libpthread.so.0 (0x44b50bd4) 11 0x40144b2a000f:fixme:dbghelp_symt:symt_set_udt_size Changing size for _IO_FILE from 148 to 76 __clone+0x3a in libc.so.6 (0x00000000) 0x10007239: movl %ecx,0xfffffffc(%ecx,%edx,1) -----Original Message----- From: Eric Pouech [mailto:pouech-eric@wanadoo.fr] Sent: Thursday, September 23, 2004 12:23 PM To: Ewert, Mark Cc: Saulius Krasuckas; wine-devel(a)winehq.org Subject: Re: Help with GetConsoleWindow() Ewert, Mark a écrit : > This is the trace just before the exception that is seen: > > 0017:trace:loaddll:load_dll Loaded module > L"c:\\windows\\system\\ws2_32.dll" : builtin > 0017:trace:loaddll:load_dll Loaded module > L"Z:\\home\\xscale_xactor\\sandbox\\MSVCR71.dll" : native > 0017:trace:loaddll:load_dll Loaded module > L"Z:\\home\\xscale_xactor\\sandbox\\MSVCP71.dll" : native > 0017:trace:loaddll:load_dll Loaded module > L"Z:\\home\\xscale_xactor\\sandbox\\CoSimClient.dll" : native > 0017:trace:loaddll:load_dll Loaded module > L"Z:\\home\\xscale_xactor\\sandbox\\plugin\\xscale\\ixpirqgui\\irqgui.dl > l" : native > wine: Unhandled exception (thread 001a), starting debugger... > > Is the problem in irqgui.dll maybe, but you cannot tell what does the stack backtrace give ? A+

2 1

Vincent Beron:"Re:dividsion by zero in winword"
by Robbert Xerox 25 Sep '04

25 Sep '04

> So maybe we should actually check for the FAT signature at buff[0x36] or > buff[0x52] first, and then do the calculations if we actually do find > one of them. > > Changelog: > Make sure we're really looking at a FAT before doing some calculations > based on the contents of the first sector of a partition. That doesn't solve the real issue, a FAT signature is not a guarantee that the rest of the block is valid, so we still need to check these values against zero. The code should not crash no matter what garbage the block contains. -- Alexandre Julliard Well, Vincent's Beron patch solves at least my problem, i.e. the error is gone and the programs work fine now.thx Robbert ___________________________________________________________ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

1 0

Error popop text not on terminal
by J. Grant 24 Sep '04

24 Sep '04

Hello, I am using eDonkey2000, installed on my CVS build. I installed with my config set to "win98", however I get the error in the attached popup when trying to run. I changed my config to "win2k" and I still have the problems, so I do not think that made any difference. Could the attached screenshot error text be displayed on the terminal with the other useful info please? (I normally see missing DLLs listed on the terminal, and occasionally also as a dialog. This error was only on a popup.) it is really hard to read the text on the popups, and I cannot copy paste into emails like this. If this popup could have only come from the program, I wonder if there is any way to log the program gui text from this msg box on the terminal? You can download the installer exe from this url if you would like to try yourself: http://www.overnet.com/downloads.php (the installer downloads and installs the program it seems) Over the course of several runs (restart of the process required for each missing dll), several popups I copied from my win2k install to get it working: kernel32.dll ntdll.dll user32.dll advapi32.dll rpcrt4.dll shell32.dll imm32.dll wsock32.dll ws2_32.dll ws2help.dll oleaut32.dll Into c:\windows\system as requested by the popups. On my win2k install these were in the "system32" dir. I wonder why is it hunting for them in "system" ? It does run though, see log attached. The screenshot shows the corrupted title bar, which cannot be moved. Any ideas how to solve this corruption problem? Also, perhaps there is a way to simplify the install of programs such as this which require so many dlls? Kind regards JG -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:font:WineEngCreateFontInstance just using first face for now WCMD Version 0.17 D:\>c:\>File not found c:\>c:\opt>c:\opt\ed2k>Volume in drive c is Volume Serial Number is 0000-0000 Directory of c:\opt\ed2k\ 20/09/2004 01:19 <DIR> . 20/09/2004 00:32 <DIR> .. 20/09/2004 01:15 418 5.html 20/09/2004 01:15 400 74.html 20/09/2004 00:32 11,504 contact.dat 20/09/2004 00:32 260 def.html 20/09/2004 01:19 <DIR> dis-plugins 20/09/2004 00:32 2,009,248 edonkey2000.exe 20/09/2004 01:19 0 filters.txt 20/09/2004 01:19 5 friend.met 20/09/2004 01:19 5 friend.met.bak 20/09/2004 01:19 5 known.met 20/09/2004 01:19 5 known.met.bak 20/09/2004 01:15 53 log.txt 20/09/2004 00:32 511 media.xml 07/12/1999 13:00 77,878 msvcirt.dll 29/08/2000 04:19 401,462 MSVCP60.DLL 20/09/2004 01:19 <DIR> Plugins 20/09/2004 01:19 1,233 pref.xml 20/09/2004 00:32 4,152 reg.jpg 20/09/2004 01:19 4,087 server.met 20/09/2004 01:19 4,087 server.met.bak 20/09/2004 01:19 39 share.dat 20/09/2004 01:19 39 share.dat.bak 20/09/2004 00:32 <DIR> Skins 20/09/2004 00:32 <DIR> temp 20/09/2004 00:32 37,125 uninstall_eDonkey2000.exe 21 files 2,552,516 bytes 6 directories 3,674,771,456 bytes free c:\opt\ed2k>c:\opt\ed2k>err:module:import_dll No implementation for MSVCRT.dll.??_U@YAPAXI@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef err:module:import_dll No implementation for MSVCRT.dll.??_V@YAXPAX@Z imported from L"C:\\opt\\ed2k\\MSVCIRT.dll", setting to 0xdeadbeef Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:font:WineEngCreateFontInstance just using first face for now fixme:ole:CoCreateInstance no classfactory created for CLSID {4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154 fixme:imm:ImmGetContext (0x10020): stub fixme:imm:ImmReleaseContext (0x10020, 0x40336368): stub ixme:imm:ImmReleaseContext (0x10020, 0x40336368): stub fixme:imm:ImmGetContext (0x501ca): stub fixme:imm:ImmReleaseContext (0x501ca, 0x40336360): stub fixme:imm:ImmGetContext (0x501ca): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x501ca, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406bda74): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406be104): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x5007a): stub fixme:imm:ImmReleaseContext (0x5007a, 0x40336360): stub fixme:imm:ImmGetContext (0x5007a): stub fixme:imm:ImmReleaseContext (0x5007a, 0x40336360): stub fixme:imm:ImmGetContext (0x5007a): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x5007a, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406bde84): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406be0e8): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406be0e8): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406be0e4): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406be0e4): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406be0e4): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x70254): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70254, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:system:SystemParametersInfoW Unimplemented action: 4100 (SPI_GETCOMBOBOXANIMATION) fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x6025e): stub fixme:imm:ImmReleaseContext (0x6025e, 0x40336360): stub fixme:imm:ImmGetContext (0x6025e): stub fixme:imm:ImmReleaseContext (0x6025e, 0x40336360): stub fixme:imm:ImmGetContext (0x6025e): stub fixme:imm:ImmReleaseContext (0x6025e, 0x40336360): stub fixme:imm:ImmGetContext (0x6025e): stub fixme:imm:ImmReleaseContext (0x6025e, 0x40336360): stub fixme:imm:ImmGetContext (0x6025e): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x6025e, 0x40336360): stub fixme:imm:ImmGetContext (0x6025e): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x6025e, 0x40336360): stub fixme:imm:ImmGetContext (0x6025e): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x6025e, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x702ae): stub fixme:imm:ImmReleaseContext (0x702ae, 0x40336360): stub fixme:imm:ImmGetContext (0x80254): stub fixme:imm:ImmReleaseContext (0x80254, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x50264): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50264, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406bdb8c): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub QPixmap::fromMimeSource: Cannot find pixmap "C:\opt\ed2k\skins\default\x-dis.png" in the mime source factory fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406be060): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmSetCompositionWindow STUB fixme:imm:ImmSetCandidateWindow (0x40336360, 0x406bdb20): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x70250): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x70250, 0x40336360): stub fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x502e6): stub fixme:imm:ImmReleaseContext (0x502e6, 0x40336360): stub fixme:system:SystemParametersInfoW Unimplemented action: 4098 (SPI_GETMENUANIMATION) fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:system:SystemParametersInfoW Unimplemented action: 4098 (SPI_GETMENUANIMATION) fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x50238): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50238, 0x40336360): stub fixme:imm:ImmGetContext (0x50228): stub fixme:imm:ImmReleaseContext (0x50228, 0x40336360): stub fixme:imm:ImmGetContext (0x50228): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50228, 0x40336360): stub fixme:imm:ImmGetContext (0x50228): stub fixme:imm:ImmReleaseContext (0x50228, 0x40336360): stub fixme:imm:ImmGetContext (0x50228): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50228, 0x40336360): stub fixme:imm:ImmGetContext (0x50228): stub fixme:imm:ImmReleaseContext (0x50228, 0x40336360): stub fixme:imm:ImmGetContext (0x50228): stub fixme:imm:ImmNotifyIME (0x40336360, 21, 4, 0): stub fixme:imm:ImmReleaseContext (0x50228, 0x40336360): stub fixme:imm:ImmGetContext (0x802c8): stub fixme:imm:ImmReleaseContext (0x802c8, 0x40336360): stub fixme:imm:ImmGetContext (0x502c2): stub fixme:imm:ImmReleaseContext (0x502c2, 0x40336360): stub

1 0

Re: Getting winebuild to work on HP-UX
by Warren_Baird/CSI＠cimmetry.com 24 Sep '04

24 Sep '04

(BTW, apologies for the Firewall/CSI thing in my previous message's "From:" line - they've been mucking about with our external mail server, and it messed something up - Hope people didn't get bounces if they tried replying directly - hopefully it'll be fixed for this message.) Alexandre Julliard wrote: > No, pretty much everything that can be done in C already is, the rest > really needs to be in assembly. It's a perfect opportunity to learn > PA-RISC assembly <g> I was afraid you'd say that -- 'cause I know as soon as I'm done the HP-UX port, I'm going to be asked to do an AIX port. Oh well - maybe I can piggyback off some of the MacOS stuff... I don't suppose there's any documentation around anywhere talking about exactly what the assembly code in winebuild is trying to accomplish, and why it can't be done in C? I'm afraid that my assembly is rough enough that I haven't been able to figure out what all of the import/export set up code is trying to do. Taking a description of what it's supposed to do, and then learning enough pa-risc assembly to do it will certainly be faster than reverse-engineering the assembly that's there and then trying to implement it for the pa-risc. Here's a brief summary of where I am: after making a few changes to various Makefile.in files to fix places where .so was used instead of $(LIBEXT), and fixing winegcc so that .so wasn't hardcoded in it either (patches will be forthcoming this aft), I'm at the point where the vast majority of the .c files compile (about 1470 - my linux build has 1596 .o files in it) - but nothing outside of libs/loader links, because of winebuild... So my next goal is really to get winebuild working... I guess I'll be cracking the pa-risc assembly language manual open soon... :-) Warren

2 1

Re: Get AdjustWindowRect working better
by Alexandre Julliard 24 Sep '04

24 Sep '04

Richard Cohen <richard(a)daijobu.co.uk> writes: > We shouldn't create a new file for *every single* test, but we should > do so for an unrelated test. How 'unmanageable' is adding 1 line to > Makefile.in? There are more than 700 APIs in user32 alone. If we create a new file for each one, that means 700 source files. Plus, with all the debug symbols, the smallest object file weighs in at least 100K, so that's a minimum of 70Mb of object files in that single directory. Multiply that by the 150 dlls we have and it should be obvious why it's unmanageable. > I would rather have the tests as *maintaineable*. If a test fails, > isn't it easier to look through 200 lines than 2000 lines ? No, since you get a line number with the failure message, you don't have to look through the whole file. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: Register Component Categories Manager
by Robert Shearman 24 Sep '04

24 Sep '04

Robert Shearman wrote: > Changelog: > Register component categories manager. Sorry, this patch is wrong. It seems it is already registered by comcat.dll, but some versions of the native ole32 seem to include the component categories manager. Rob

1 0

Re: Accept WM_SYSCHAR message for processsing in TranslateAcceleratorW
by Rein Klazes 24 Sep '04

24 Sep '04

On Thu, 16 Sep 2004 19:54:57 +0900, you wrote: > Hello, > Hi Dmitry, This patch is causing a regression in Agent (still existing in current CVS). If I use <alt>+W to access the Windows menu the program reacts as if I pressed just the 'W'. This is also an accelator key causing the current thread to be 'Watched'. Same thing with <ALT>+H, it should bring up the help menu. Now it causes the headers to display, normally behind the 'H' key. <ALT>-E works normal, probably because the 'E' is not accelerated. > this patch makes accelerator keys in my test MDI app (compiled with MSVC) > work under Wine. The problem is that Wine correctly generates WM_SYSKEY* > and WM_SYSCHAR messages when there is no focus window, but WM_SYSCHAR > is not considered by TranslateAcceleratorW as a valid input. Uhh, "The problem is that Wine correctly generates ...". Do you mean this is a hack? BTW. Your other patch "Make message flow for MDI ..." fixes the problem with maximized/restored MDI windows in Agent, thanks. Rein. -- Rein Klazes rklazes(a)xs4all.nl

2 8

Re: Support remote operations in wineserver
by Alexandre Julliard 24 Sep '04

24 Sep '04

"Alexander Yaworsky" <yaworsky(a)migusoft.ru> writes: > Hello > > I guess that original patch was too large. > I sent small pieces of it and they have been committed; however it seems that > this part cannot be downsized. Well, I'm not going to commit that part since it doesn't actually do anything with the remote operation, and it's not clear at all that the requests you added will be appropriate to whatever mechanism we use to do the remote operation. -- Alexandre Julliard julliard(a)winehq.org

4 5

Re: reading HEX and OCTAL numbers from input field
by James Hawkins 24 Sep '04

24 Sep '04

> Yes, I've put brown bag over my head Na, it's ok. You're new to the developemnt process of wine, and it can take a while to get a hang of the process. Just stick with it and things will be better in no time. On Thu, 23 Sep 2004 23:56:32 -0700, Primorec <igor.furlan(a)gmail.com> wrote: > Just forget my post.. I have not noticed that this feature was > already implemented. > > Yes, I've put brown bag over my head > > > > > On Thu, 23 Sep 2004 23:05:36 -0700, Primorec <igor.furlan(a)gmail.com> wrote: > > This patch allows user to enter HEX and/or OCTAL numbers into the form > > input field. > > > > This is my first patch and in the same time my second C program (first > > one was Hello World). > > So, please, have a mercy and be tolerant. > > > > Thanks > > > > Igor > > > > ? patch.diff > > Index: dlls/oleaut32/variant.c > > =================================================================== > > RCS file: /home/wine/wine/dlls/oleaut32/variant.c,v > > retrieving revision 1.102 > > diff -u -u -r1.102 variant.c > > --- dlls/oleaut32/variant.c 22 Sep 2004 19:12:18 -0000 1.102 > > +++ dlls/oleaut32/variant.c 24 Sep 2004 05:44:43 -0000 > > @@ -1556,6 +1556,8 @@ > > DWORD dwState = B_EXPONENT_START|B_INEXACT_ZEROS; > > int iMaxDigits = sizeof(rgbTmp) / sizeof(BYTE); > > int cchUsed = 0; > > + int value = 0; > > + OLECHAR first_element; > > > > TRACE("(%s,%ld,0x%08lx,%p,%p)\n", debugstr_w(lpszStr), lcid, > > dwFlags, pNumprs, rgbDig); > > > > @@ -1571,6 +1573,73 @@ > > pNumprs->nBaseShift = 0; > > pNumprs->nPwr10 = 0; > > > > + first_element = *lpszStr++; > > + > > + if ((first_element == '&') && (pNumprs->dwInFlags & NUMPRS_HEX_OCT)) > > + { > > + /* printf("TONY's hex string %s \n", debugstr_w(lpszStr)); */ > > + > > + first_element = *lpszStr++; > > + > > + if (first_element == 'h' || first_element == 'H') > > + { > > + pNumprs->nBaseShift = 4; /* hex number */ > > + first_element = *lpszStr++; > > + } > > + else > > + { > > + pNumprs->nBaseShift = 3; /* octal number */ > > + > > + if (first_element == 'o' || first_element == '0') > > + { > > + first_element = *lpszStr++; > > + } > > + } > > + > > + while (first_element == '0') > > + first_element = *lpszStr++; > > + > > + while (first_element != 0) > > + { > > + if (pNumprs->nBaseShift == 4) > > + { > > + if (first_element >= 'a' && first_element <= 'f') > > + value = first_element - 'a' + 10; /* making integer value > > out of hex character */ > > + else if (first_element >= 'A' && first_element <= 'F') > > + value = first_element - 'A' + 10; /* making integer value > > out of hex character */ > > + else if (first_element >= '0' && first_element <= '9') > > + value = first_element - '0'; > > + } > > + else > > + { > > + if (first_element >= '0' && first_element <= '7') > > + value = first_element - '0'; > > + } > > + rgbTmp[cchUsed] = value; > > + cchUsed++; /* count digits */ > > + first_element = *lpszStr++; > > + } > > + > > + if (cchUsed == 0) > > + { > > + value = 0; > > + rgbTmp[cchUsed] = value; > > + cchUsed = 1; > > + } > > + > > + pNumprs->cDig = cchUsed; > > + > > + memcpy(rgbDig, rgbTmp, pNumprs->cDig * sizeof(BYTE)); > > + return S_OK; > > + } > > + > > + if (!pNumprs || !rgbDig) > > + return E_INVALIDARG; > > + > > + if (pNumprs->cDig < iMaxDigits) > > + iMaxDigits = pNumprs->cDig; > > + > > + > > if (!lpszStr) > > return DISP_E_TYPEMISMATCH; > > > > @@ -1971,6 +2040,26 @@ > > > > if (pNumprs->nBaseShift) > > { > > + > > + /* we have to be sure that the number does not use more than 32 bits > > + * I am not sure if this is 100% valid - perhaps we should test for 64 ?? */ > > + int bitCount = (pNumprs->nBaseShift) * (pNumprs->cDig); > > + if (bitCount > 32) > > + return DISP_E_OVERFLOW; > > + > > + ULONG intValue = 0; > > + for ( ; pNumprs->cDig > 0; pNumprs->cDig--) > > + intValue = (intValue << (pNumprs->nBaseShift)) + *rgbDig++; > > + > > + FIXME("Only VTBIT_I2 implemented. Need to add other cases : > > VTBIT_I1, VTBIT_UI1 ... etc \n"); > > + if (dwVtBits & VTBIT_I2) > > + { > > + V_VT(pVarDst) = VT_I2; > > + V_I2(pVarDst) = intValue; > > + return S_OK; > > + } > > + > > + > > /* nBaseShift indicates a hex or octal number */ > > ULONG64 ul64 = 0; > > LONG64 l64; > > > > -- James Hawkins

1 0

Re: Contributing to WINE
by Dan Kegel 24 Sep '04

24 Sep '04

Alexandre Julliard wrote: > I got his mails and replied (even though they were sent as Word > documents which was a big pain to read). I imagine he never got the > replies, it seems your mail setup needs some work. Maybe you should fax your first reply to make sure he gets it. Specops fax # is, according to their web site, 632 532-5875. - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

1 0

Re: [dx9-2] Make d3d8 know about the wined3d device
by Alexandre Julliard 23 Sep '04

23 Sep '04

"Ann and Jason Edmeades" <us(a)the-edmeades.demon.co.uk> writes: > +/* No reference counting is required as there will be only one reference from > + Direct3DCreateX, and released when the reference count of that object gets to 0 */ > ULONG WINAPI IWineD3DImpl_AddRef(IWineD3D *iface) { > + IWineD3DImpl *This = (IWineD3DImpl *)iface; > + FIXME("(%p) : AddRef should never be called\n", This); > return 1; > } > > ULONG WINAPI IWineD3DImpl_Release(IWineD3D *iface) { > + IWineD3DImpl *This = (IWineD3DImpl *)iface; > + TRACE("(%p) : Releasing\n", This); > + HeapFree(GetProcessHeap(), 0, This); > return 0; > } If you are going to free the object on Release() then you should really do proper ref counting. It costs basically nothing and it will avoid a lot of headaches. Dummy refcounting is OK only if the count really doesn't matter, i.e. the object never gets released. -- Alexandre Julliard julliard(a)winehq.org

1 0

Janitorial Projects > COM objects
by Joris Huizer 23 Sep '04

23 Sep '04

Hello, Just to get started, I thought I could do some work of the Interlocking cleanup; The first patch wasn't applied yet so it's included in this patch as well I tried to do as suggested in the patch on the site and came up with this; I hope it's usefull... regards, Joris Index: dlls/ole32/antimoniker.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/antimoniker.c,v retrieving revision 1.21 diff -u -r1.21 antimoniker.c --- dlls/ole32/antimoniker.c 9 Sep 2004 21:03:58 -0000 1.21 +++ dlls/ole32/antimoniker.c 23 Sep 2004 20:35:17 -0000 @@ -186,7 +186,7 @@ TRACE("(%p)\n",This); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -195,19 +195,21 @@ ULONG WINAPI AntiMonikerImpl_Release(IMoniker* iface) { AntiMonikerImpl *This = (AntiMonikerImpl *)iface; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; + ref = InterlockedDecrement(&This->ref); + /* destroy the object if there's no more reference on it */ - if (This->ref==0){ + if (ref == 0){ AntiMonikerImpl_Destroy(This); return 0; } - return This->ref; + return ref; } /****************************************************************************** Index: dlls/ole32/bindctx.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/bindctx.c,v retrieving revision 1.28 diff -u -r1.28 bindctx.c --- dlls/ole32/bindctx.c 9 Sep 2004 21:03:58 -0000 1.28 +++ dlls/ole32/bindctx.c 23 Sep 2004 20:35:17 -0000 @@ -142,7 +142,7 @@ TRACE("(%p)\n",This); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -151,12 +151,13 @@ ULONG WINAPI BindCtxImpl_Release(IBindCtx* iface) { BindCtxImpl *This = (BindCtxImpl *)iface; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; + ref = InterlockedDecrement(&This->ref); - if (This->ref==0){ + if (ref == 0){ /* release all registered objects */ BindCtxImpl_ReleaseBoundObjects((IBindCtx*)This); @@ -165,7 +166,7 @@ return 0; } - return This->ref; + return ref; } Index: dlls/ole32/clipboard.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/clipboard.c,v retrieving revision 1.34 diff -u -r1.34 clipboard.c --- dlls/ole32/clipboard.c 9 Sep 2004 21:03:58 -0000 1.34 +++ dlls/ole32/clipboard.c 23 Sep 2004 20:35:19 -0000 @@ -1162,9 +1162,8 @@ TRACE("(%p)->(count=%lu)\n",This, This->ref); - This->ref++; + return InterlockedIncrement(&This->ref); - return This->ref; } /************************************************************************ @@ -1179,23 +1178,24 @@ * Declare "This" pointer */ OLEClipbrd *This = (OLEClipbrd *)iface; + ULONG ref; TRACE("(%p)->(count=%lu)\n",This, This->ref); /* * Decrease the reference count on this object. */ - This->ref--; + ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (This->ref==0) + if (ref == 0) { OLEClipbrd_Destroy(This); } - return This->ref; + return ref; } @@ -1651,7 +1651,7 @@ if (This->pUnkDataObj) IUnknown_AddRef(This->pUnkDataObj); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /************************************************************************ @@ -1663,13 +1663,15 @@ { IEnumFORMATETCImpl *This = (IEnumFORMATETCImpl *)iface; LPMALLOC pIMalloc; + ULONG ref; TRACE("(%p)->(count=%lu)\n",This, This->ref); if (This->pUnkDataObj) IUnknown_Release(This->pUnkDataObj); /* Release parent data object */ - if (!--(This->ref)) + ref = InterlockedDecrement(&This->ref); + if (!ref) { TRACE("() - destroying IEnumFORMATETC(%p)\n",This); if (SUCCEEDED(CoGetMalloc(MEMCTX_TASK, &pIMalloc))) @@ -1682,7 +1684,7 @@ return 0; } - return This->ref; + return ref; } /************************************************************************ Index: dlls/ole32/compositemoniker.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/compositemoniker.c,v retrieving revision 1.31 diff -u -r1.31 compositemoniker.c --- dlls/ole32/compositemoniker.c 9 Sep 2004 21:03:58 -0000 1.31 +++ dlls/ole32/compositemoniker.c 23 Sep 2004 20:35:20 -0000 @@ -243,7 +243,7 @@ TRACE("(%p)\n",This); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -253,13 +253,14 @@ { CompositeMonikerImpl *This = (CompositeMonikerImpl *)iface; ULONG i; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; + ref = InterlockedDecrement(&This->ref); /* destroy the object if there's no more reference on it */ - if (This->ref==0){ + if (ref == 0){ /* release all the components before destroying this object */ for (i=0;i<This->tabLastIndex;i++) @@ -269,7 +270,7 @@ return 0; } - return This->ref; + return ref; } /****************************************************************************** @@ -1527,7 +1528,7 @@ TRACE("(%p)\n",This); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } @@ -1537,14 +1538,14 @@ ULONG WINAPI EnumMonikerImpl_Release(IEnumMoniker* iface) { EnumMonikerImpl *This = (EnumMonikerImpl *)iface; - ULONG i - ; + ULONG i; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; + ref = InterlockedDecrement(&This->ref); /* destroy the object if there's no more reference on it */ - if (This->ref==0){ + if (ref == 0) { for(i=0;i<This->tabSize;i++) IMoniker_Release(This->tabMoniker[i]); @@ -1554,7 +1555,7 @@ return 0; } - return This->ref; + return ref; } /****************************************************************************** Index: dlls/ole32/datacache.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/datacache.c,v retrieving revision 1.26 diff -u -r1.26 datacache.c --- dlls/ole32/datacache.c 23 Aug 2004 19:39:50 -0000 1.26 +++ dlls/ole32/datacache.c 23 Sep 2004 20:35:21 -0000 @@ -968,10 +968,11 @@ IUnknown* iface) { _ICOM_THIS_From_NDIUnknown(DataCache, iface); + ULONG ref; - this->ref++; + ref = InterlockedIncrement(&this->ref); - return this->ref; + return ref; } /************************************************************************ @@ -986,23 +987,24 @@ IUnknown* iface) { _ICOM_THIS_From_NDIUnknown(DataCache, iface); + ULONG ref; /* * Decrease the reference count on this object. */ - this->ref--; + ref = InterlockedDecrement(&this->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (this->ref==0) + if (ref == 0) { DataCache_Destroy(this); return 0; } - return this->ref; + return ref; } /********************************************************* Index: dlls/ole32/defaulthandler.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/defaulthandler.c,v retrieving revision 1.19 diff -u -r1.19 defaulthandler.c --- dlls/ole32/defaulthandler.c 23 Aug 2004 19:39:50 -0000 1.19 +++ dlls/ole32/defaulthandler.c 23 Sep 2004 20:35:22 -0000 @@ -656,10 +656,11 @@ IUnknown* iface) { _ICOM_THIS_From_NDIUnknown(DefaultHandler, iface); + ULONG ref; - this->ref++; + ref = InterlockedIncrement(&this->ref); - return this->ref; + return ref; } /************************************************************************ @@ -674,23 +675,24 @@ IUnknown* iface) { _ICOM_THIS_From_NDIUnknown(DefaultHandler, iface); + ULONG ref; /* * Decrease the reference count on this object. */ - this->ref--; + ref = InterlockedDecrement(&this->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (this->ref==0) + if (ref == 0) { DefaultHandler_Destroy(this); return 0; } - return this->ref; + return ref; } /********************************************************* Index: dlls/ole32/filemoniker.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/filemoniker.c,v retrieving revision 1.38 diff -u -r1.38 filemoniker.c --- dlls/ole32/filemoniker.c 9 Sep 2004 21:03:58 -0000 1.38 +++ dlls/ole32/filemoniker.c 23 Sep 2004 20:35:23 -0000 @@ -194,7 +194,7 @@ TRACE("(%p)\n",iface); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -203,19 +203,20 @@ ULONG WINAPI FileMonikerImpl_Release(IMoniker* iface) { FileMonikerImpl *This = (FileMonikerImpl *)iface; + ULONG ref; TRACE("(%p)\n",iface); - This->ref--; + ref = InterlockedDecrement(&This->ref); /* destroy the object if there's no more reference on it */ - if (This->ref==0){ + if (ref == 0) { FileMonikerImpl_Destroy(This); return 0; } - return This->ref; + return ref; } /****************************************************************************** Index: dlls/ole32/hglobalstream.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/hglobalstream.c,v retrieving revision 1.25 diff -u -r1.25 hglobalstream.c --- dlls/ole32/hglobalstream.c 23 Aug 2004 19:39:50 -0000 1.25 +++ dlls/ole32/hglobalstream.c 23 Sep 2004 20:35:24 -0000 @@ -378,10 +378,11 @@ IStream* iface) { HGLOBALStreamImpl* const This=(HGLOBALStreamImpl*)iface; + ULONG ref; - This->ref++; + ref = InterlockedIncrement(&This->ref); - return This->ref; + return ref; } /*** @@ -392,12 +393,9 @@ IStream* iface) { HGLOBALStreamImpl* const This=(HGLOBALStreamImpl*)iface; - ULONG newRef; - This->ref--; - - newRef = This->ref; + newRef = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. Index: dlls/ole32/itemmoniker.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/itemmoniker.c,v retrieving revision 1.28 diff -u -r1.28 itemmoniker.c --- dlls/ole32/itemmoniker.c 9 Sep 2004 21:03:58 -0000 1.28 +++ dlls/ole32/itemmoniker.c 23 Sep 2004 20:35:25 -0000 @@ -193,7 +193,7 @@ TRACE("(%p)\n",This); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -202,19 +202,20 @@ ULONG WINAPI ItemMonikerImpl_Release(IMoniker* iface) { ItemMonikerImpl *This = (ItemMonikerImpl *)iface; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; + ref = InterlockedDecrement(&This->ref); /* destroy the object if there's no more reference on it */ - if (This->ref==0){ + if (ref == 0){ ItemMonikerImpl_Destroy(This); return 0; } - return This->ref; + return ref; } /****************************************************************************** Index: dlls/ole32/marshal.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/marshal.c,v retrieving revision 1.31 diff -u -r1.31 marshal.c --- dlls/ole32/marshal.c 9 Sep 2004 21:03:58 -0000 1.31 +++ dlls/ole32/marshal.c 23 Sep 2004 20:35:25 -0000 @@ -217,17 +217,20 @@ static ULONG WINAPI StdMarshalImpl_AddRef(LPMARSHAL iface) { StdMarshalImpl *This = (StdMarshalImpl *)iface; - This->ref++; - return This->ref; + ULONG ref; + ref = InterlockedIncrement(&This->ref); + return ref; } static ULONG WINAPI StdMarshalImpl_Release(LPMARSHAL iface) { StdMarshalImpl *This = (StdMarshalImpl *)iface; - This->ref--; + ULONG ref; + ref = InterlockedDecrement(&This->ref); - if (This->ref) - return This->ref; + /* why is this syntax so different ?? */ + if (ref) + return ref; HeapFree(GetProcessHeap(),0,This); return 0; } Index: dlls/ole32/memlockbytes.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/memlockbytes.c,v retrieving revision 1.20 diff -u -r1.20 memlockbytes.c --- dlls/ole32/memlockbytes.c 23 Aug 2004 19:39:50 -0000 1.20 +++ dlls/ole32/memlockbytes.c 23 Sep 2004 20:35:25 -0000 @@ -351,10 +351,11 @@ ULONG WINAPI HGLOBALLockBytesImpl_AddRef(ILockBytes* iface) { HGLOBALLockBytesImpl* const This=(HGLOBALLockBytesImpl*)iface; + ULONG ref; - This->ref++; + ref = InterlockedIncrement(&This->ref); - return This->ref; + return ref; } /****************************************************************************** @@ -365,21 +366,19 @@ { HGLOBALLockBytesImpl* const This=(HGLOBALLockBytesImpl*)iface; - ULONG newRef; + ULONG ref; - This->ref--; - - newRef = This->ref; + ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (newRef==0) + if (ref==0) { HGLOBALLockBytesImpl_Destroy(This); } - return newRef; + return ref; } /****************************************************************************** Index: dlls/ole32/memlockbytes16.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/memlockbytes16.c,v retrieving revision 1.8 diff -u -r1.8 memlockbytes16.c --- dlls/ole32/memlockbytes16.c 12 Aug 2004 23:00:55 -0000 1.8 +++ dlls/ole32/memlockbytes16.c 23 Sep 2004 20:35:26 -0000 @@ -277,12 +277,13 @@ ULONG WINAPI HGLOBALLockBytesImpl16_AddRef(ILockBytes16* iface) { HGLOBALLockBytesImpl16* const This=(HGLOBALLockBytesImpl16*)iface; + ULONG ref; TRACE("(%p)\n",This); - This->ref++; + ref = InterlockedIncrement(&This->ref); - return This->ref; + return ref; } /****************************************************************************** @@ -293,19 +294,17 @@ { HGLOBALLockBytesImpl16* const This=(HGLOBALLockBytesImpl16*)iface; - ULONG newRef; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; - - newRef = This->ref; + ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (newRef==0) + if (ref==0) HGLOBALLockBytesImpl16_Destroy(This); - return newRef; + return ref; } /****************************************************************************** Index: dlls/ole32/moniker.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/moniker.c,v retrieving revision 1.35 diff -u -r1.35 moniker.c --- dlls/ole32/moniker.c 9 Sep 2004 21:03:58 -0000 1.35 +++ dlls/ole32/moniker.c 23 Sep 2004 20:35:26 -0000 @@ -145,7 +145,7 @@ TRACE("(%p)\n",This); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /*********************************************************************** @@ -174,13 +174,14 @@ { DWORD i; RunningObjectTableImpl *This = (RunningObjectTableImpl *)iface; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; + ref = InterlockedDecrement(&This->ref); /* unitialize ROT structure if there's no more reference to it*/ - if (This->ref==0){ + if (ref == 0) { /* release all registered objects */ for(i=0;i<This->runObjTabLastIndx;i++) @@ -201,7 +202,7 @@ return 0; } - return This->ref; + return ref; } /*********************************************************************** Index: dlls/ole32/oleobj.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/oleobj.c,v retrieving revision 1.18 diff -u -r1.18 oleobj.c --- dlls/ole32/oleobj.c 9 Sep 2004 21:03:58 -0000 1.18 +++ dlls/ole32/oleobj.c 23 Sep 2004 20:35:27 -0000 @@ -189,17 +189,18 @@ LPOLEADVISEHOLDER iface) { OleAdviseHolderImpl *This = (OleAdviseHolderImpl *)iface; + ULONG ref; TRACE("(%p)->(ref=%ld)\n", This, This->ref); - This->ref--; + ref = InterlockedDecrement(&This->ref); - if (This->ref == 0) + if (ref == 0) { OleAdviseHolderImpl_Destructor(This); return 0; } - return This->ref; + return ref; } /****************************************************************************** @@ -523,10 +524,12 @@ IDataAdviseHolder* iface) { DataAdviseHolder *This = (DataAdviseHolder *)iface; + ULONG ref; + TRACE("(%p) (ref=%ld)\n", This, This->ref); - This->ref++; + ref = InterlockedIncrement(&This->ref); - return This->ref; + return ref; } /************************************************************************ @@ -538,24 +541,25 @@ IDataAdviseHolder* iface) { DataAdviseHolder *This = (DataAdviseHolder *)iface; + ULONG ref; TRACE("(%p) (ref=%ld)\n", This, This->ref); /* * Decrease the reference count on this object. */ - This->ref--; + ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (This->ref==0) + if (ref==0) { DataAdviseHolder_Destructor(This); return 0; } - return This->ref; + return ref; } /************************************************************************ Index: dlls/ole32/oleproxy.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/oleproxy.c,v retrieving revision 1.21 diff -u -r1.21 oleproxy.c --- dlls/ole32/oleproxy.c 9 Sep 2004 21:03:58 -0000 1.21 +++ dlls/ole32/oleproxy.c 23 Sep 2004 20:35:27 -0000 @@ -103,18 +103,20 @@ static ULONG WINAPI CFStub_AddRef(LPRPCSTUBBUFFER iface) { CFStub *This = (CFStub *)iface; + ULONG ref; - This->ref++; - return This->ref; + ref = InterlockedIncrement(&This->ref); + return ref; } static ULONG WINAPI CFStub_Release(LPRPCSTUBBUFFER iface) { CFStub *This = (CFStub *)iface; + ULONG ref; - This->ref--; - if (This->ref) - return This->ref; + ref = InterlockedDecrement(&This->ref); + if (ref) + return ref; HeapFree(GetProcessHeap(),0,This); return 0; } @@ -286,18 +288,19 @@ static ULONG WINAPI IRpcProxyBufferImpl_AddRef(LPRPCPROXYBUFFER iface) { ICOM_THIS_MULTI(CFProxy,lpvtbl_proxy,iface); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } static ULONG WINAPI IRpcProxyBufferImpl_Release(LPRPCPROXYBUFFER iface) { ICOM_THIS_MULTI(CFProxy,lpvtbl_proxy,iface); + ULONG ref = InterlockedDecrement(&This->ref); - if (!--(This->ref)) { + if (!ref) { IRpcChannelBuffer_Release(This->chanbuf);This->chanbuf = NULL; HeapFree(GetProcessHeap(),0,This); return 0; } - return This->ref; + return ref; } static HRESULT WINAPI IRpcProxyBufferImpl_Connect(LPRPCPROXYBUFFER iface,IRpcChannelBuffer* pRpcChannelBuffer) { @@ -330,16 +333,19 @@ } static ULONG WINAPI CFProxy_AddRef(LPCLASSFACTORY iface) { + ULONG ref; ICOM_THIS_MULTI(CFProxy,lpvtbl_cf,iface); - This->ref++; - return This->ref; + ref = InterlockedIncrement(&This->ref); + return ref; } static ULONG WINAPI CFProxy_Release(LPCLASSFACTORY iface) { + ULONG ref; ICOM_THIS_MULTI(CFProxy,lpvtbl_cf,iface); - This->ref--; - if (This->ref) - return This->ref; + + ref = InterlockedDecrement(&This->ref); + if (ref) + return ref; HeapFree(GetProcessHeap(),0,This); return 0; } Index: dlls/ole32/rpc.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/rpc.c,v retrieving revision 1.26 diff -u -r1.26 rpc.c --- dlls/ole32/rpc.c 9 Sep 2004 21:03:58 -0000 1.26 +++ dlls/ole32/rpc.c 23 Sep 2004 20:35:28 -0000 @@ -286,20 +286,22 @@ static ULONG WINAPI PipeBuf_AddRef(LPRPCCHANNELBUFFER iface) { PipeBuf *This = (PipeBuf *)iface; - This->ref++; - return This->ref; + ULONG ref; + ref = InterlockedIncrement(&This->ref); + return ref; } static ULONG WINAPI PipeBuf_Release(LPRPCCHANNELBUFFER iface) { PipeBuf *This = (PipeBuf *)iface; + ULONG ref; wine_rpc_disconnect_header header; HANDLE pipe; DWORD reqtype = REQTYPE_DISCONNECT; - This->ref--; - if (This->ref) - return This->ref; + ref = InterlockedDecrement(&This->ref); + if (ref) + return ref; FIXME("Free all stuff\n"); Index: dlls/ole32/stg_stream.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/stg_stream.c,v retrieving revision 1.21 diff -u -r1.21 stg_stream.c --- dlls/ole32/stg_stream.c 23 Aug 2004 19:39:50 -0000 1.21 +++ dlls/ole32/stg_stream.c 23 Sep 2004 20:35:28 -0000 @@ -222,9 +222,10 @@ { StgStreamImpl* const This=(StgStreamImpl*)iface; - This->ref++; + ULONG ref; + ref = InterlockedIncrement(&This->ref); - return This->ref; + return ref; } /*** @@ -236,21 +237,19 @@ { StgStreamImpl* const This=(StgStreamImpl*)iface; - ULONG newRef; + ULONG ref; - This->ref--; - - newRef = This->ref; + ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (newRef==0) + if (ref==0) { StgStreamImpl_Destroy(This); } - return newRef; + return ref; } /*** Index: dlls/ole32/storage.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/storage.c,v retrieving revision 1.42 diff -u -r1.42 storage.c --- dlls/ole32/storage.c 22 Sep 2004 02:46:40 -0000 1.42 +++ dlls/ole32/storage.c 23 Sep 2004 20:35:29 -0000 @@ -986,7 +986,7 @@ */ ULONG WINAPI IStream16_fnAddRef(IStream16* iface) { IStream16Impl *This = (IStream16Impl *)iface; - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -994,15 +994,16 @@ */ ULONG WINAPI IStream16_fnRelease(IStream16* iface) { IStream16Impl *This = (IStream16Impl *)iface; + ULONG ref; FlushFileBuffers(This->hf); - This->ref--; - if (!This->ref) { + ref = InterlockedDecrement(&This->ref); + if (!ref) { CloseHandle(This->hf); UnMapLS( This->thisptr ); HeapFree( GetProcessHeap(), 0, This ); return 0; } - return This->ref; + return ref; } /****************************************************************************** @@ -1480,7 +1481,7 @@ */ ULONG WINAPI IStream_fnAddRef(IStream* iface) { IStream32Impl *This = (IStream32Impl *)iface; - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -1488,14 +1489,15 @@ */ ULONG WINAPI IStream_fnRelease(IStream* iface) { IStream32Impl *This = (IStream32Impl *)iface; + ULONG ref; FlushFileBuffers(This->hf); - This->ref--; - if (!This->ref) { + ref = InterlockedDecrement(&This->ref); + if (!ref) { CloseHandle(This->hf); HeapFree( GetProcessHeap(), 0, This ); return 0; } - return This->ref; + return ref; } /* --- IStorage16 implementation */ @@ -1534,7 +1536,7 @@ */ ULONG WINAPI IStorage16_fnAddRef(IStorage16* iface) { IStorage16Impl *This = (IStorage16Impl *)iface; - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -1542,9 +1544,10 @@ */ ULONG WINAPI IStorage16_fnRelease(IStorage16* iface) { IStorage16Impl *This = (IStorage16Impl *)iface; - This->ref--; - if (This->ref) - return This->ref; + ULONG ref; + ref = InterlockedDecrement(&This->ref); + if (ref) + return ref; UnMapLS( This->thisptr ); HeapFree( GetProcessHeap(), 0, This ); return 0; Index: dlls/ole32/storage32.c =================================================================== RCS file: /home/wine/wine/dlls/ole32/storage32.c,v retrieving revision 1.59 diff -u -r1.59 storage32.c --- dlls/ole32/storage32.c 22 Sep 2004 02:46:40 -0000 1.59 +++ dlls/ole32/storage32.c 23 Sep 2004 20:35:34 -0000 @@ -291,9 +291,9 @@ IStorage* iface) { StorageBaseImpl *This = (StorageBaseImpl *)iface; - This->ref++; + ULONG ref = InterlockedIncrement(&This->ref); - return This->ref; + return ref; } /************************************************************************ @@ -311,12 +311,12 @@ /* * Decrease the reference count on this object. */ - This->ref--; + ULONG ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (This->ref==0) + if (ref == 0) { /* * Since we are using a system of base-classes, we want to call the @@ -328,7 +328,7 @@ return 0; } - return This->ref; + return ref; } /************************************************************************ @@ -3638,8 +3638,8 @@ { IEnumSTATSTGImpl* const This=(IEnumSTATSTGImpl*)iface; - This->ref++; - return This->ref; + ULONG ref = InterlockedIncrement(&This->ref); + return ref; } ULONG WINAPI IEnumSTATSTGImpl_Release( @@ -3649,8 +3649,7 @@ ULONG newRef; - This->ref--; - newRef = This->ref; + newRef = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. Index: dlls/oleaut32/connpt.c =================================================================== RCS file: /home/wine/wine/dlls/oleaut32/connpt.c,v retrieving revision 1.12 diff -u -r1.12 connpt.c --- dlls/oleaut32/connpt.c 9 Sep 2004 21:03:58 -0000 1.12 +++ dlls/oleaut32/connpt.c 23 Sep 2004 20:35:34 -0000 @@ -193,10 +193,11 @@ static ULONG WINAPI ConnectionPointImpl_AddRef(IConnectionPoint* iface) { ConnectionPointImpl *This = (ConnectionPointImpl *)iface; + ULONG ref; TRACE("(%p)->(ref=%ld)\n", This, This->ref); - This->ref++; + ref = InterlockedIncrement(&This->ref); - return This->ref; + return ref; } /************************************************************************ @@ -208,24 +209,25 @@ IConnectionPoint* iface) { ConnectionPointImpl *This = (ConnectionPointImpl *)iface; + ULONG ref; TRACE("(%p)->(ref=%ld)\n", This, This->ref); /* * Decrease the reference count on this object. */ - This->ref--; + ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (This->ref==0) + if (ref == 0) { ConnectionPointImpl_Destroy(This); return 0; } - return This->ref; + return ref; } /************************************************************************ @@ -473,10 +475,11 @@ static ULONG WINAPI EnumConnectionsImpl_AddRef(IEnumConnections* iface) { EnumConnectionsImpl *This = (EnumConnectionsImpl *)iface; + ULONG ref; TRACE("(%p)->(ref=%ld)\n", This, This->ref); - This->ref++; + ref = InterlockedIncrement(&This->ref); IUnknown_AddRef(This->pUnk); - return This->ref; + return ref; } /************************************************************************ @@ -487,6 +490,7 @@ static ULONG WINAPI EnumConnectionsImpl_Release(IEnumConnections* iface) { EnumConnectionsImpl *This = (EnumConnectionsImpl *)iface; + ULONG ref; TRACE("(%p)->(ref=%ld)\n", This, This->ref); IUnknown_Release(This->pUnk); @@ -494,19 +498,19 @@ /* * Decrease the reference count on this object. */ - This->ref--; + ref = InterlockedDecrement(&This->ref); /* * If the reference count goes down to 0, perform suicide. */ - if (This->ref==0) + if (ref == 0) { EnumConnectionsImpl_Destroy(This); return 0; } - return This->ref; + return ref; } /************************************************************************ Index: dlls/oleaut32/dispatch.c =================================================================== RCS file: /home/wine/wine/dlls/oleaut32/dispatch.c,v retrieving revision 1.20 diff -u -r1.20 dispatch.c --- dlls/oleaut32/dispatch.c 9 Sep 2004 21:03:58 -0000 1.20 +++ dlls/oleaut32/dispatch.c 23 Sep 2004 20:35:35 -0000 @@ -278,7 +278,7 @@ StdDispatch *This = (StdDispatch *)iface; TRACE("()\n"); - return ++This->ref; + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -289,18 +289,18 @@ static ULONG WINAPI StdDispatch_Release(LPDISPATCH iface) { StdDispatch *This = (StdDispatch *)iface; - ULONG ret; + ULONG ref; TRACE("(%p)->()\n", This); - ret = This->ref--; + ref = InterlockedDecrement(&This->ref); - if (This->ref == 0) + if (ref == 0) { ITypeInfo_Release(This->pTypeInfo); CoTaskMemFree(This); } - return ret; + return ref; } /****************************************************************************** Index: dlls/urlmon/umon.c =================================================================== RCS file: /home/wine/wine/dlls/urlmon/umon.c,v retrieving revision 1.41 diff -u -r1.41 umon.c --- dlls/urlmon/umon.c 22 Sep 2004 02:46:39 -0000 1.41 +++ dlls/urlmon/umon.c 23 Sep 2004 20:35:36 -0000 @@ -197,7 +197,7 @@ TRACE("(%p)\n",This); - return ++(This->ref); + return InterlockedIncrement(&This->ref); } /****************************************************************************** @@ -206,19 +206,20 @@ static ULONG WINAPI URLMonikerImpl_Release(IMoniker* iface) { URLMonikerImpl *This = (URLMonikerImpl *)iface; + ULONG ref; TRACE("(%p)\n",This); - This->ref--; + ref = InterlockedDecrement(&This->ref); /* destroy the object if there's no more reference on it */ - if (This->ref==0){ + if (ref == 0){ URLMonikerImpl_Destroy(This); return 0; } - return This->ref; + return ref; } /******************************************************************************

1 0

RE: patch: SHELL_ArgifyW expands env-vars - last try
by Jens Collin 23 Sep '04

23 Sep '04

I never get any response to my supplied patch. I assume that there's something more wrong with it, but I can't _guess_ what it is. Could anyone help me? /Jens -----Original Message----- From: wine-patches-admin(a)winehq.org [mailto:wine-patches-admin@winehq.org] On Behalf Of Jens Collin Sent: den 13 september 2004 20:15 To: wine-patches(a)winehq.org Subject: patch: SHELL_ArgifyW expands env-vars - last try Sorry for all the bouncing of email on this matter. All suggestions/corrections has been taken into consideration and applied to attached patch. Regards, Jens ---- changelog: * lookup of envoronment-vars in SHELL_ArgifyW in shell32.dll added. (Such as %SystemRoot%).

2 2

Getting winebuild to work on HP-UX
by Firewall/CSI＠cimmetry.com 23 Sep '04

23 Sep '04

Hi all, As I mentioned in a previous post, I'm working on getting winelib to run on an HP-UX / PA-RISC system. The biggest problem I'm facing right now is dealing with all of the assembly code that is put into the .spec file by winebuild. I'm not an expert at assembly of any form, and I know absolutely nothing about PA-RISC assembly. I guess my main question is: why is so much assembly needed there - can some or all of it be replaced by C code (at least on platforms where you never need to interact with real windows libs - like sparc/solaris and pa-risc/hpux)? Any suggestions on how to get this code working on hpux would be really helpful! Warren

3 2

Re: shlwapi: Implement PathSearchAndQualify
by Alexandre Julliard 23 Sep '04

23 Sep '04

Huw D M Davies <h.davies1(a)physics.ox.ac.uk> writes: > Implement PathSearchAndQualify and add a test. I think you need to throw a SearchPath() in there too. If you try with a simple file name without directory you'll see that the test fails. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Help with GetConsoleWindow()
by Ewert, Mark 23 Sep '04

23 Sep '04

This is the trace just before the exception that is seen: 0017:trace:loaddll:load_dll Loaded module L"c:\\windows\\system\\ws2_32.dll" : builtin 0017:trace:loaddll:load_dll Loaded module L"Z:\\home\\xscale_xactor\\sandbox\\MSVCR71.dll" : native 0017:trace:loaddll:load_dll Loaded module L"Z:\\home\\xscale_xactor\\sandbox\\MSVCP71.dll" : native 0017:trace:loaddll:load_dll Loaded module L"Z:\\home\\xscale_xactor\\sandbox\\CoSimClient.dll" : native 0017:trace:loaddll:load_dll Loaded module L"Z:\\home\\xscale_xactor\\sandbox\\plugin\\xscale\\ixpirqgui\\irqgui.dl l" : native wine: Unhandled exception (thread 001a), starting debugger... Is the problem in irqgui.dll? -----Original Message----- From: Saulius Krasuckas [mailto:saulius2@ar.fi.lt] Sent: Monday, September 20, 2004 1:17 PM To: Ewert, Mark Cc: wine-devel(a)winehq.org Subject: RE: Help with GetConsoleWindow() On Mon, 20 Sep 2004, Ewert, Mark wrote: > "wine: Unhandled exception (thread 000d), starting debugger... > WineDbg starting on pid 0x8 > Unhandled exception: page fault on write access to 0x41a417a4 in 32-bit > code (0x10007239). > In 32 bit mode." > > A window pops up that says: > > "Uhandled page fault on write access to 0x41a417a4 at address 0x10007239 > Do you wish to debug it?" Is this oming from another thread or even another process? IMHO, you should try running in some way similar to this: $ WINEDEBUG=+loaddll,+process,+tid wine ... to see more interesting info in the output of Wine. > When I click yes I get a dump of all the register/memory locations. Is > there anything in particular I should look for? IMO, no. Are you receiving an interactive prompt of "Wine-dbg>" in your console? If yes, better try typing command "bt" to get the backtrace, then. Maybe the "bt all" command would help more. My $.01, my $.01.

2 1

Moving some 16-bit code
by Ge van Geldorp 23 Sep '04

23 Sep '04

dlls/shell32/control.c contains some 16-bit code (function RunDLL_CallEntry16), which I would like to separate out. I wonder if the attached patch is the correct way to do that? On Win2k export 122 is just a stub. Maybe it would be ok to turn our export 122 into an empty function too? Ge van Geldorp. Index: control.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/control.c,v retrieving revision 1.20 diff -u -r1.20 control.c --- control.c 12 Jul 2004 19:50:56 -0000 1.20 +++ control.c 22 Sep 2004 19:28:18 -0000 @@ -456,30 +456,6 @@ return Control_FillCache_RunDLLW(hWnd, hModule, w, x); } - -/************************************************************************* - * RunDLL_CallEntry16 [SHELL32.122] - * the name is probably wrong - */ -void WINAPI RunDLL_CallEntry16( DWORD proc, HWND hwnd, HINSTANCE inst, - LPCSTR cmdline, INT cmdshow ) -{ - WORD args[5]; - SEGPTR cmdline_seg; - - TRACE( "proc %lx hwnd %p inst %p cmdline %s cmdshow %d\n", - proc, hwnd, inst, debugstr_a(cmdline), cmdshow ); - - cmdline_seg = MapLS( cmdline ); - args[4] = HWND_16(hwnd); - args[3] = MapHModuleLS(inst); - args[2] = SELECTOROF(cmdline_seg); - args[1] = OFFSETOF(cmdline_seg); - args[0] = cmdshow; - WOWCallback16Ex( proc, WCB16_PASCAL, sizeof(args), args, NULL ); - UnMapLS( cmdline_seg ); -} - /************************************************************************* * CallCPLEntry16 [SHELL32.166] * Index: shell.c =================================================================== RCS file: /home/wine/wine/dlls/shell32/shell.c,v retrieving revision 1.61 diff -u -r1.61 shell.c --- shell.c 15 Jun 2004 18:27:50 -0000 1.61 +++ shell.c 22 Sep 2004 19:28:18 -0000 @@ -657,3 +657,27 @@ return HINSTANCE_16(seiW.hInstApp); } + + +/************************************************************************* + * RunDLL_CallEntry16 [SHELL32.122] + * the name is probably wrong + */ +void WINAPI RunDLL_CallEntry16( DWORD proc, HWND hwnd, HINSTANCE inst, + LPCSTR cmdline, INT cmdshow ) +{ + WORD args[5]; + SEGPTR cmdline_seg; + + TRACE( "proc %lx hwnd %p inst %p cmdline %s cmdshow %d\n", + proc, hwnd, inst, debugstr_a(cmdline), cmdshow ); + + cmdline_seg = MapLS( cmdline ); + args[4] = HWND_16(hwnd); + args[3] = MapHModuleLS(inst); + args[2] = SELECTOROF(cmdline_seg); + args[1] = OFFSETOF(cmdline_seg); + args[0] = cmdshow; + WOWCallback16Ex( proc, WCB16_PASCAL, sizeof(args), args, NULL ); + UnMapLS( cmdline_seg ); +} Index: shell32.spec =================================================================== RCS file: /home/wine/wine/dlls/shell32/shell32.spec,v retrieving revision 1.87 diff -u -r1.87 shell32.spec --- shell32.spec 6 Sep 2004 20:24:10 -0000 1.87 +++ shell32.spec 22 Sep 2004 19:28:19 -0000 @@ -115,7 +115,6 @@ 119 stdcall IsLFNDrive(ptr) IsLFNDriveAW 120 stdcall FileMenu_AbortInitMenu () 121 stdcall SHFlushClipboard () - 122 stdcall -noname RunDLL_CallEntry16(long long long str long) #name wrong? 123 stdcall SHFreeUnusedLibraries () 124 stdcall FileMenu_AppendFilesForPidl(long ptr long) 125 stdcall FileMenu_AddFilesForPidl(long long long ptr long long ptr) Index: shell.spec =================================================================== RCS file: /home/wine/wine/dlls/shell32/shell.spec,v retrieving revision 1.10 diff -u -r1.10 shell.spec --- shell.spec 26 Sep 2003 04:32:20 -0000 1.10 +++ shell.spec 22 Sep 2004 19:28:19 -0000 @@ -29,6 +29,8 @@ 102 pascal -ret16 RegisterShellHook(word word) RegisterShellHook16 103 pascal ShellHookProc(word word long) ShellHookProc16 +122 pascal RunDLL_CallEntry16(long long long str long) #name wrong? + 157 stub RESTARTDIALOG # 166 PICKICONDLG

2 1

Promoting WINE
by Andreas Rosenberg 23 Sep '04

23 Sep '04

Hello Wine developers, perhaps some guys will remember me. I'm working for a small software company making a tool for FMEA and risk management. Late last year I managed to make our application work with Wine by submitting some patches. Our company held it's anual user meeting this week in Pforzheim (Germany) where about 150 people, working mostly for automotive companies (Daimler Crysler, BMW, BOSCH, VALEO, AUTOLIV, TRW etc.) attended. Since we had some requests for a Linux version of our software, I could arrange a short presenation of WINE in combination with our software. Two people talked to me after the presentation,indicating that they have a strong interest in this topic and asked for a german documentation how to install Wine. Perhaps this presentation has put a seed into certain heads and will show them ways to alternatives using software written for Windows. I thought, this might interest some of the developers. Regards Andy

1 0

Re: [4/5] GetWindowLongPtr: Windows
by Dmitry Timoshkov 23 Sep '04

23 Sep '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > - if (!(context.Eax = GetWindowWord( HWND_32(hwnd), GWL_HINSTANCE ))) context.Eax = context.SegDs; > + if (!(context.Eax = GetWindowWord( HWND_32(hwnd), GWLP_HINSTANCE ))) context.Eax = context.SegDs; GetWindowWord above probably should be replaced by GetWindowLongPtrW. And all appropriate ANSI variants of the GetWindowLongPtr call should have been replaced by a unicode one while you were at it. Of course that's not critical at all, just a nit pick. -- Dmitry.

3 2

winemaker/winelib problems
by Tim Ruehsen 23 Sep '04

23 Sep '04

Hi, i want to compile a small MFC based app using winelib/winemaker. The system is Debian SID (upto date, daily patched) (wine 20040716). As I understood from doc 'winelib-user/mfc-compiling' I have to compile MFC first. I copied dir 'atlmfc' from VC7 onto my machine, cd'ing into atlmfc/src/mfc und executing: winemaker --mfc . No errors. Now ./configure --with-wine=/usr/bin --with-wine-includes=/usr/include/wine/windows --with-wine-libraries=/usr/lib --with-wine-dlls=/usr/lib/wine --with-mfc=/usr/oms/atlmfc --with-atl-includes=/usr/oms/atlmfc/include says 'checking for libntdll.so... configure: error: Could not find the Wine dlls (libntdll.so)' And really: libntdll.so is not on my system, but I can find /usr/lib/wine/ntdll.dll.so Now I try to work around it by making a symbolic link ln -s /usr/lib/wine/ntdll.dll.so /usr/lib/wine/libntdll.so Again calling ./configure with the same options as above results in 'checking for atldef.h header... configure: error: Could not find the ATL includes' atldef.h does exist: -rwxr--r-- 1 oms users 7569 Sep 23 13:09 /usr/oms/atlmfc/include/atldef.h I played around with some other options to ./configure but the result stays the same. I edited configure to wrok around it, but I get similar errors with other includes (which exist as well). Can anyone give me a hint what to do? (Yes, I read the docs, but they are somewhat confusing... looks like something is missing there). Thanks for your patience! Tim

1 0

Re: icmp - allow building on MS_VC and Mingw
by Hans Leidekker 23 Sep '04

23 Sep '04

On Thursday 23 September 2004 06:02, Steven Edwards wrote: > Feel free to drop the gettimeofday part from this patch. There are 16 > other source files where we call gettimeofday in Wine and I am sure if > you dont accept it I can come up a good implementation in libwine. Why not use Windows time functions directly in ICMP? Reimplementing gettimeofday on top of Windows time fuctions doesn't seem like an ideal solution for ReactOS nor Wine. In Reactos you'd already have unnecessary loss of precision but even more so in Wine since we'd be doing: gettimeofday() -> GetSysTemTimeAsFileTime() -> gettimeofday(). Not to mention the maintenance burden of a Unix api in Reactos and Wine. -Hans

1 0

RFC: more Windows-NT like user directories?
by Juan Lang 23 Sep '04

23 Sep '04

Folks, I'm still working on the shell path functions, and I was thinking of changing the directory layout for the shell directories (desktop, start menu, my documents and whatnot) from the Windows 95-ish way to the NT-ish way. That is, rather than being children of c:\windows, they'd generally be children of c:\documents and settings\<username>. Any complaints? --Juan _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

7 17

Contributing to WINE
by Ronald Robin 23 Sep '04

23 Sep '04

0 *H÷ 010 +0 *H÷ $ÀContent-Type: multipart/alternative; boundary="----=_NextPart_000_0023_01C4A0DF.30188140" This is a multi-part message in MIME format. ------=_NextPart_000_0023_01C4A0DF.30188140 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi! My name is Ronald and I was wondering if any of you guys out there can help me get in touch with Mr. Alexander Julliard or any of the leaders here in the WINE community. We've been trying to get in touch with him for months now and we have consistently failed to receive a response. My company, SpecOps Labs, would like to discuss how we can contribute and work together with the WINE community. We believe we have a lot to contribute to the WINE community. However, without contact with any of the executives at WINEHQ, we are unable to do so. We want to engage in an initial dialog with Mr. Julliard. Our CTO has already tried emailing him twice. It's possible we don't have the right contact information. We'd greatly appreciate it if someone here could help us out. ------=_NextPart_000_0023_01C4A0DF.30188140 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:o=3D"urn:schemas-microsoft-com:office:office" = xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns=3D"http://www.w3.org/TR/REC-html40"> <head> <META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; = charset=3Dus-ascii"> <meta name=3DGenerator content=3D"Microsoft Word 11 (filtered medium)"> <style>  </style> </head> <body lang=3DEN-US link=3Dblue vlink=3Dpurple> <div class=3DSection1> Hi! My name is Ronald and I was wondering if any of = you guys out there can help me get in touch with Mr. Alexander Julliard or any of = the leaders here in the WINE community. We've been trying to get in touch = with him for months now and we have consistently failed to receive a = response.<o:p></o:p> <o:p> </o:p> My company, SpecOps Labs, would like to discuss how = we can contribute and work together with the WINE community. We believe we have = a lot to contribute to the WINE community. However, without contact with any = of the executives at WINEHQ, we are unable to do so. = <o:p></o:p> <o:p> </o:p> We want to engage in an initial dialog with Mr. = Julliard. Our CTO has already tried emailing him twice. It's possible we don't = have the right contact information. We'd greatly appreciate it if someone here = could help us out.<o:p></o:p> </div> </body> </html> ------=_NextPart_000_0023_01C4A0DF.30188140-- E0ú0c£0 *H÷ 0E10 UUS10U GTE Corporation10UGTE CyberTrust Root0 960223230100Z 060223235900Z0E10 UUS10U GTE Corporation10UGTE CyberTrust Root00 *H÷ 0žæOºÛ|q|¯D·ÓFÙdåÁBÇºI5-zçœå1YÆ±/ û§?¢ fV7)é~Ê¥õ£Õ¢FØhLÑ7h¯œø°³ð)õZ aw "%ÔOEªÇœåßùÔšBÌ$À'Jµmc9Ä¢^80 *H÷ ³uÆ_áaUÔK{1#cç=óùô6š»Ùã¥Mê+)àÖjsæÀ£Óñà¥¥"7cÂH ŽÛrãÈöÙ|Ÿ±¯SÚŽ!žÖÕãþNYb¶JùBÝo©qÿô rmmDóttšÕ4Ié^éŽzáåZ0Ó¥%Ø0È01 0 *H÷ 0E10 UUS10U GTE Corporation10UGTE CyberTrust Root0 020827190700Z 060223235900Z0Ü10 UGB10U Comodo Limited10UComodo Trust Network1F0DU=Terms and Conditions of use: http://www.comodo.net/repository10U(c)2002 Comodo Limited1,0*U#Comodo Class 3 Security Services CA0"0 *H÷ 0 ±`fàC'h/ÇßëÛeìÔIgz.ÍÜ,Ö¬òF:]À=,Z Y%B£rÀ(Ò<1âKû^ëš3Öi²Zê,IŠ&.LðÌ«@ÒªÞ,Nµº{ž\Ð{œGõÀÒÀä×GÛb@¯¡QÛžÐ»Ç<yê%d®&á<fGg{U«4ÂunÙ'ðÚk¢µêÏû9Cšð-÷,/áÐ±ÿ×YÄÍ@2ù×ÛQòARA±žÈ þ"GOË®à(Õ¬pG°%«¡8Bkújn_yøö)0€nFÔ]ª@8vÛ}å¥£§0£0EU>0<0: 8 64http://www.public-trust.com/cgi-bin/CRL/2006/cdp.crl0UöR"Y¿HŽ¹éþøf0U 00I *Høc0;09+-http://www.public-trust.com/CPS/OmniRoot.html0:+²10*0(+https://secure.comodo.net/CP0XU#Q0O¡I€G0E10 UUS10U GTE Corporation10UGTE CyberTrust Root£0+U$0"20020827190731Z20050223235900Z0Uÿæ0U0ÿ0 *H÷ ¶§°zqàº³62zÖñ«M9qZg Kå0@mµª±Çô Æ\é7ÞšÇÜÎÍqûtÜ_'SvÔ¹éÂwPÊÉ°ÂFDª\Ö ÙU2ŸVñêœ ãŒ :êÌûWíx¥6=VêÑçtÊ4ÃÏ±Qéà0w0_ e/y0áGÞ£ö0 *H÷ 0Ü10 UGB10U Comodo Limited10UComodo Trust Network1F0DU=Terms and Conditions of use: http://www.comodo.net/repository10U(c)2002 Comodo Limited1,0*U#Comodo Class 3 Security Services CA0 040922000000Z 050922235959Z0Ý1503U,Comodo Trust Network - PERSONA NOT VALIDATED1F0DU=Terms and Conditions of use: http://www.comodo.net/repository10U(c)2003 Comodo Limited10URonald Robin1$0" *H÷ robin@specopslabs.com00 *H÷ 0ŠYiFøÀeö Å¯êÁÔAùP9Êó1ªvØ-Õ1k·çâé¥aÃÂB'å£ÍkÔ 8JcIï/OñßeYÓkÃSÄ`¶ûË €7A°ðûôèJÄ(å3Þ?Ë¢JþmW £Ž0°0U#0öR"Y¿HŽ¹éþøf0U*fÇÆ55ÖÇ6Áv_Ü:*¬0Uÿ 0Uÿ00 U%0++²10FU ?0=0;+²10+0)+https://secure.comodo.net/CPS0°Uš0¥08 6 42http://crl.comodo.net/Class3SecurityServices_2.crl0: 8 64http://crl.comodoca.com/Class3SecurityServices_2.crl0- + )'Class3SecurityServices_2(a)crl.comodo.net0 `HøB 0 U0robin(a)specopslabs.com0 *H÷ ïN'z?·ÿxCRŒ9Z`iPCÖ!Š+€bÑŠÄe[»U¥ÜÂðuàçuyœZ~2ýroN"ÝwFãÍŽb³aîX¶î9 7òÊU×°V»;·¹¯uH>Û`<%Ü=òK0oA²£ž®á(?1 Ò!¬ÂÈ}0-ŒlT=vµŽÏbó·DÿýÅ.x6×ñQÐ³L£ð-O_Œßú*å7÷#Âò0~š\ý>ý Áà ,ÒkæC{ã8Ïøz ÙÔ¹·)tÆÍÅ¹ÎcßtuÇ<²i7Ù«1p0l0ñ0Ü10 UGB10U Comodo Limited10UComodo Trust Network1F0DU=Terms and Conditions of use: http://www.comodo.net/repository10U(c)2002 Comodo Limited1,0*U#Comodo Class 3 Security Services CAe/y0áGÞ£ö0 + Ô0 *H÷ 1 *H÷ 0 *H÷ 1 040922120311Z0# *H÷ 1Íñ€§wçÊŸÚÍ«Ž3nXº`ø¡!0g *H÷ 1Z0X0 *H÷ 0*H÷ 0 *H÷ @0+0 *H÷ (0+0 *H÷ 0 +71ô0ñ0Ü10 UGB10U Comodo Limited10UComodo Trust Network1F0DU=Terms and Conditions of use: http://www.comodo.net/repository10U(c)2002 Comodo Limited1,0*U#Comodo Class 3 Security Services CAe/y0áGÞ£ö0*H÷ 1ô ñ0Ü10 UGB10U Comodo Limited10UComodo Trust Network1F0DU=Terms and Conditions of use: http://www.comodo.net/repository10U(c)2002 Comodo Limited1,0*U#Comodo Class 3 Security Services CAe/y0áGÞ£ö0 *H÷ 0r²ž!&ÆÞj30<ì,ðB_5_°ÅO>&6ß»3ÁzÌÓÉÔ>ßZ/ÙNŠd0Ï[n;N³£JúPMçcìÎPû2œëS-ÕÖãÉ·ã[ÜÙ_×Þâ*¢æÍ?WþG>Y¡Éñ<KxåG&{=.trÈ

9 11

Re: Disable DPMI
by Robert Shearman 22 Sep '04

22 Sep '04

Jukka Heinonen wrote: >Robert Shearman: > > >>This patch disables DPMI. If sti has been executed beforehand and an >>instruction (such as an interrupt) must be emulated then it can cause an >>infinite loop around the enumation of the iret instruction in the DPMI >>call. Even after (probably rather poorly) hacking around this issue I >>still got unprivileged instruction exceptions from the iret instruction. >>Without more expert eyes being cast on this code the only thing I can >>suggest to fix non-DPMI applications with the above case is to disable >>DPMI event checking. >> >> > >Well, your patch actually just disables checking for asynchronous >events in DPMI mode, not the DPMI mode itself, which leaves open >whether you are trying to run a Win16 program or a DOS program >that does not need working IRQ handling in DPMI mode. > It is a Win16 program and I don't think it uses DPMI at all. >I'm sure DPMI >asynchronous event handling still has bugs and I guess disabling >it is acceptable if it looks like it causes problems and fixing >the bugs seems to require too much work. > I have tried to fix it in a sane way, but I don't have any more time to work on it. >However, the patch comment >and the quote above tell me next to nothing about the bug you are >seeing, more information would be required in order to have any >hope of fixing the bug. And I'm probably going to be quite busy, >anyway, so I'm not sure when I have time to look at this bug. > > I think the program does this: sti int 1a cli This seems to cause the problem after the "int 1a" has been emulated as it inserts an event check and then tries to emulate the iret instruction which then seems to cause another event check and so on. I would like to fix this in a sane way, but I don't really know what is going on in this area. Rob

2 1

division by zero in winword
by Robbert Xerox 22 Sep '04

22 Sep '04

Hi, in quite a few programs i can not browse the filesystem when opening a "listbox"; to be more clear: for example when i do in winword Open and the listbox appears, and i try to open the pull down menu winword just quits(without an error message in wine). In another program like "Camel join" it quits as soon as i go up to the level of "my computer" with a message "division by zero in Volme_ReadFATSuperblock. I was able to track the problem down to the following lines in volume.c (starting from line 502) nsect -= GETWORD(buff, 0x0e) + buff[0x10] * sz + (GETWORD(buff, 0x11) * 32 + (GETWORD(buff, 0x0b) - 1)) / GETWORD(buff, 0x0b); nclust = nsect / buff[0x0d]; when i change these into this: nsect -= GETWORD(buff, 0x0e) + buff[0x10] * sz + (GETWORD(buff, 0x11) * 32 + (GETWORD(buff, 0x0b) - 1)) / (GETWORD(buff, 0x0b)-1); nclust = nsect / (buff[0x0d]+1); i can (obviously) avoid the division by zero and everything (winword and camel join) just works fine. I'm not a programmer, so this solution obviously sucks, so my question is: how can this error be fixed, and do more people encounter this problem. PS i'm using the august version of wine, and in the april version this whole problem didn't show up! everything just worked fine there. Thanks in advance, Robbert ___________________________________________________________ALL-NEW Yahoo! Messenger - all new features - even more fun! http://uk.messenger.yahoo.com

4 3

Re: FW: [dx9-1] resent - this time with extra file!
by Robert Shearman 22 Sep '04

22 Sep '04

Ann and Jason Edmeades wrote: >>I think the direction is OK, now if you sent me the new directx.c file >>too I could actually apply the patch ;-) >> >> > >D'oh - I always forget about new files as cvs diff doesnt do it. I couldnt >work out how to do this in patch format, so the c file is attached. For >future reference, how can I put new files into either a cvs diff or patch >format please! > > diff -u /dev/null dlls/d3d9/directx.c >> dx9.1.patch Rob

1 0

Re: Get AdjustWindowRect working better
by Dmitry Timoshkov 22 Sep '04

22 Sep '04

"Richard Cohen" <richard(a)daijobu.co.uk> wrote: > Changelog: > + Improve AdjustWindowRect > + add a test dlls/user/tests/win.c already has AdjustWindowRect tests, see test_nonclient_area. If you could add your tests there that would be great. -- Dmitry.

3 2

Re: System font width
by Huw D M Davies 22 Sep '04

22 Sep '04

On Tue, Sep 21, 2004 at 07:40:17AM -0700, Jon Griffiths wrote: > Hi, > > I have an app that calls GetObject on SYSTEM_FONT and then uses the > returned LOGFONT.lfWidth in a calculation. Wine currently returns 0 > for the width, which causes a divide by zero error here. > > Testing under XP home shows that the returned with is 7 for the > system font. This patch changes the width specified in the stock font > list. Although this makes my app run and doesn't appear to have any > ill consequenses, it may be better to get some advice from a font > expert before committing this patch. This probably won't hurt anything. The correct way would be to load the system font and get its metrics. Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Re: Lostwages add seti@home link
by Ivan Leo Puoti 22 Sep '04

22 Sep '04

> mybe some > other place? Resources -> others ? I would say links -> others but we don't > have that :) If you know about a better place, I'm open to suggestions. Ivan.

3 2

load_dll: MODULE_GetLoadOrderW on filename versus libname
by Uwe Bonnes 22 Sep '04

22 Sep '04

Hallo, some installer (extracted from slvc009j.zip from Texas instruments (www.ti.com)) loaded the native msi.dll, also I gave WINEDLLOVERRIDES=msi=b on the command line. The program copies some msi.dll to some directory, and prepends that directory to the loadpath. Then it calls: 000d:Call kernel32.LoadLibraryA(010013f8 "msi.dll") ret=01004283 load_dll now does a find_dll_file and sees "L:\\temp\\IXP000.TMP\\msi.dll" . sets filename to "L:\\temp\\IXP000.TMP\\msi.dll" and compares "L:\\temp\\IXP000.TMP\\msi.dll" for the loadorder. 000d:Call ntdll.LdrLoadDll(403dc0e8 L"L:\\temp\\IXP000.TMP;.;c:\\nt4sp5g\\system32;c:\\nt4sp5g;d:\\wine95;d:\\ wine95\\system;c:\\cae\\pasic\\spde;f:;",00000000,4070f424,4070f404) ret=4052392b trace:module:load_dll looking for L"msi.dll" in L"L:\\temp\\IXP000.TMP;.;c:\\nt4sp5g\\system32;c:\\nt4sp5g;d:\ \wine95;d:\\wine95\\system;c:\\cae\\pasic\\spde;f:;" trace:module:MODULE_GetLoadOrderW looking for L"L:\\temp\\IXP000.TMP\\msi.dll" trace:module:open_app_key searching L"L:\\temp\\IXP000.TMP\\msi" in L"Machine\\Software\\Wine\\Wine\\Config\\A ppDefaults\\msiinst.exe\\DllOverrides" trace:module:MODULE_GetLoadOrderW got hardcoded path default "n,b" for L"L:\\temp\\IXP000.TMP\\msi.dll" trace:module:load_dll Trying native dll L"L:\\temp\\IXP000.TMP\\msi.dll" trace:module:load_native_dll loading L"L:\\temp\\IXP000.TMP\\msi.dll" This leads to the native dll getting loaded. Is this the right thing? Shouldn't MODULE_GetLoadOrderW compare for libname and not filename? Only if libname has an explicit path, we should compare for that path. Bye Index: wine/dlls/ntdll/loader.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/loader.c,v retrieving revision 1.77 diff -u -w -r1.77 loader.c --- wine/dlls/ntdll/loader.c 15 Sep 2004 18:02:49 -0000 1.77 +++ wine/dlls/ntdll/loader.c 22 Sep 2004 10:08:48 -0000 @@ -1507,7 +1507,7 @@ } main_exe = get_modref( NtCurrentTeb()->Peb->ImageBaseAddress ); - MODULE_GetLoadOrderW( loadorder, main_exe ? main_exe->ldr.BaseDllName.Buffer : NULL, filename ); + MODULE_GetLoadOrderW( loadorder, main_exe ? main_exe->ldr.BaseDllName.Buffer : NULL, libname ); nts = STATUS_DLL_NOT_FOUND; for (i = 0; i < LOADORDER_NTYPES; i++) -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 2

Bugzilla Bug 2075: *printf incompatibilities
by Aneurin Price 22 Sep '04

22 Sep '04

I've been looking at Warcraft III today, and had the problem of single player campaigns not showing up. The reason behind this is explained at http://bugs.winehq.org/show_bug.cgi?id=2075, and sure enough adding the special case described for the I64 argument type specification solves the problem in W3. Now I'm wondering how the problem should really be solved. Currently most (possibly all) of the *printf functions in msvcrt call MSVCRT_vsnprintfW. Should the same be done for vsnprintf, or should there be an independent MSVCRT_vsnprintfA? Either way I don't really know how the implementation would work. I was kind of hoping that this might be an okay place to start learning about WINE development, so if this in fact hinges on something far more complicated than I've been able to grasp, somebody please point this out to me :). Any pointers? Thanks, Aneurin Price

2 2

raw parallel port access
by BRC 22 Sep '04

22 Sep '04

After quite a few days of perusing wine doc/source/config/mailing lists, I have found very scant references to accessing the raw parallel ports using wine. I am running FC2 linux (up-to-date) and have confirmed I can access the parallel port (dongle) presented to VMWare running a Windows 2000 guest OS successfully ie. access to /dev/parport0 works. I can also run all the programs included with wine-20040914 as well as some tests I wrote with mingw as well as those I compiled with VC++. The latter just cannot access the parallel port as VMWARE can though it runs normally until it can't access the dongle on LPT1. I've tried running as root too to no avail. What am I missing? If no answer is available, can someone at least point to the relevant sources so I can puzzle it out further: I am determined. Running with WINEDEBUG=+io yields no output yet WINEDEBUG=+all spews the world as expected. The relevant setup options I've played with are: ln -s /dev/parport0 ~chris/.wine/dosdevices/lpt1 When I run as root, I symlink ~root/.wine -> ~chris/.wine for convenience. The config ( I go back and forth on [ports] as I've found different messages/doc professing both). [parallelports] "lpt1" = "/dev/lp0" [ppdev] ;; key: io-base of the emulated port ;; value : parport-device{,timeout} ;; timeout for auto closing an open device ( not yet implemented) "378" = "/dev/parport0" ;;"278" = "/dev/parport1" ;;"3bc" = "/dev/parport2" [spooler] "FILE:" = "tmp.ps" "LPT1:" = "|lpr" "LPT2:" = "|gs -sDEVICE=bj200 -sOutputFile=/tmp/fred -q -" "LPT3:" = "/dev/lp3" [ports] "read" = "0x779,0x379,0x280-0x2a0" "write" = "0x779,0x379,0x280-0x2a0" #"read" = "0x378,0x379,0x37a,0x37c,0x77a" #"write" = "0x378,0x379,0x37a,0x37c,0x77a" Thanks! Chris __________________________________ Do you Yahoo!? Yahoo! Mail - 50x more storage than other providers! http://promotions.yahoo.com/new_mail

5 6

"optimized" assembly functions in wine
by Rein Klazes 22 Sep '04

22 Sep '04

Hi, Just did not feel like chasing bugs the other day. I decided to have some fun with something that I wondering for a long time: the usefulness of inline i86 assembly in string functions. This is the test program as.c: ---------------------------------8<------------------------------------- #include <malloc.h> typedef unsigned short WCHAR, *PWCHAR; static inline WCHAR *strcpyW( WCHAR *dst, const WCHAR *src ) { #ifdef ASM int dummy1, dummy2, dummy3; __asm__ __volatile__( "cld\n" "1:\tlodsw\n\t" "stosw\n\t" "testw %%ax,%%ax\n\t" "jne 1b" : "=&S" (dummy1), "=&D" (dummy2), "=&a" (dummy3) : "0" (src), "1" (dst) : "memory" ); #else WCHAR *p = dst; while ((*p++ = *src++)); #endif return dst; } #define SZ 3000 main() { int i; PWCHAR s,d; s=malloc(SZ*sizeof(WCHAR)); d=malloc(SZ*sizeof(WCHAR)); memset(s,'x',SZ); s[SZ-1]=0; for(i=0;i<1000000;i++) strcpyW(d,s); } ---------------------------------8<------------------------------------- The function strcpyW is a copy from Wine with the #ifdef modified. I used the following commands gcc-3.3 -O2 as.c -o as -DASM ; time ./as;time ./as; time ./as and gcc-3.3 -O2 as.c -o as ; time ./as;time ./as; time ./as The resulting times are (all user time): test# asm C ----------------------- 1 15.970 15.899 2 15.966 15.943 3 15.959 15.941 ------ ------ ave 15.964 15.928 Notes: - tested on a PII 450 MHz; - I tested with gcc 2.95 and 3.4.2 as well, result are essentially the same. - size of main() is 0x7a (assembly) vs 0x82 (C-code) bytes; - I experimented with longer strings to see if there was any mem cache hit/miss effects and found none. Conclusions: 1. these routines are so fast that it is hard to imagine that these functions will be a bottleneck, justifying such optimization; 2. nothing shows here that inline assembly brings any advantage. Rein. -- Rein Klazes rklazes(a)xs4all.nl

4 4

Re: Epoll patch (rev 6)
by Marcus Meissner 22 Sep '04

22 Sep '04

On Wed, Sep 22, 2004 at 04:54:53PM +0900, Mike McCormack wrote: > > Updated epoll patch for the current cvs. > Shachar, take heart! One hunk of the epoll patch has been committed, > only 15 to go! :) > > Mike > > > ChangeLog: > * add support for using epoll instead of select to the wineserver > > Index: configure.ac > =================================================================== > RCS file: /home/wine/wine/configure.ac,v > retrieving revision 1.310 > diff -u -r1.310 configure.ac > --- configure.ac 22 Sep 2004 04:08:38 -0000 1.310 > +++ configure.ac 22 Sep 2004 06:15:27 -0000 > @@ -132,6 +132,10 @@ > AC_CHECK_LIB(xpg4,_xpg4_setrunelocale) > dnl Check for -lpoll for Mac OS X/Darwin > AC_CHECK_LIB(poll,poll) > +dnl Check for -lepoll > +AC_CHECK_LIB(epoll,epoll_create, > + [AC_SUBST(LIBEPOLL,-lepoll) > + AC_DEFINE(HAVE_LIBEPOLL)]) Newer glibc versions have epoll_create built-in, so better use something like: LIBEPOLL= AC_SUBST(LIBEPOLL) AC_CHECK_FUNC(epoll_create,[ AC_DEFINE(HAVE_LIBEPOLL) ], [ AC_CHECK_LIB(epoll,epoll_create,[ LIBEPOLL="-lepoll" AC_DEFINE(HAVE_LIBEPOLL) ] ) ] )

1 0

Re: winefile sync with ReactOS
by Alexandre Julliard 22 Sep '04

22 Sep '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > + if (order1 && order2) { > + order1 = fd1->cFileName[0]!='.'? 1: fd1->cFileName[1]=='.'? 2: fd1->cFileName[1]=='\0'? 3: 1; > + order2 = fd2->cFileName[0]!='.'? 1: fd2->cFileName[1]=='.'? 2: fd2->cFileName[1]=='\0'? 3: 1; You need to check that cFileName[2] == 0 too; but I'd suggest getting rid of the ?: operator abuse first, otherwise this is going to become totally unreadable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: fonts: 20 ppem Wine Sans Serif
by Dimitrie O. Paun 21 Sep '04

21 Sep '04

On Mon, Sep 20, 2004 at 11:51:24AM +0100, Huw D M Davies wrote: > Huw Davies <huw(a)codeweavers.com> > Add a 20 ppem strike with cp1252 coverage to Wine Sans Serif. > Add U+201a to all strikes. Huw, What's the current status for fonts. I think they deserve a section under the UI Status: http://www.winehq.org/site/status_ui What do we have currently, in what state, what's left to do? -- Dimi.

4 4

UpdateWindow vs. WM_PAINT
by Michael Kaufmann 21 Sep '04

21 Sep '04

Hi, I've noticed that many Windows controls don't wait for a WM_PAINT message. They redraw themselves immediately (with GetDC/ReleaseDC, UpdateWindow or RedrawWindow). This is necessary if a program is carrying out a lengthy operation without fetching messages. TextPad is such a program: Its progress control doesn't get updated in WINE while loading a file. To see the redraw differences between Windows and WINE, I've created this test program: http://www.michael-kaufmann.ch/WINE/ControlsRepaintTest.zip It changes properties of different controls and then calls Sleep() to simulate a lengthy operation. The big problem is that it's undocumented in which cases a control should wait for a WM_PAINT message and in which cases it should redraw itself immediately. I've observed that many controls redraw themselves immediately if an important property of the control gets changed (e.g. the position of a progress control, the text of a status bar) or if the user selects an item (ListBox, ListView, TreeView) or if he presses a key (Edit box). Most controls wait for WM_PAINT if the data that they display was modified. But sometimes it's just arbitrary. Examples (tested on Windows 2000): Edit Control: - Redraw immediately: WM_REPLACESEL, EM_SETSEL, WM_CLEAR, WM_PASTE, WM_CUT - Don't redraw immediately: WM_SETTEXT, EM_UNDO, other messages Listbox Control: - Redraw immediately: LB_SETCURSEL, LB_SETTOPINDEX - Don't redraw immediately: LB_SETSEL, LB_RESETCONTENT, LB_ADDSTRING, other messages I've created a patch which should work for most lazy programs. Please review it. Regards Michael Index: dlls/comctl32/progress.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/progress.c,v retrieving revision 1.38 diff -u -r1.38 progress.c --- dlls/comctl32/progress.c 25 Aug 2004 17:33:01 -0000 1.38 +++ dlls/comctl32/progress.c 19 Sep 2004 21:45:55 -0000 @@ -485,7 +485,7 @@ infoPtr->MinVal = low; infoPtr->MaxVal = high; PROGRESS_CoercePos(infoPtr); - InvalidateRect(infoPtr->Self, NULL, TRUE); + RedrawWindow(infoPtr->Self, NULL, NULL, RDW_ERASE | RDW_INVALIDATE | RDW_UPDATENOW); return res; } @@ -562,6 +562,7 @@ PROGRESS_CoercePos (infoPtr); TRACE("PBM_DELTAPOS: current pos changed from %d to %d\n", oldVal, infoPtr->CurVal); PROGRESS_Invalidate( infoPtr, oldVal, infoPtr->CurVal ); + UpdateWindow(infoPtr->Self); } return oldVal; } @@ -575,6 +576,7 @@ PROGRESS_CoercePos(infoPtr); TRACE("PBM_SETPOS: current pos changed from %d to %d\n", oldVal, infoPtr->CurVal); PROGRESS_Invalidate( infoPtr, oldVal, infoPtr->CurVal ); + UpdateWindow(infoPtr->Self); } return oldVal; } @@ -601,6 +603,7 @@ { TRACE("PBM_STEPIT: current pos changed from %d to %d\n", oldVal, infoPtr->CurVal); PROGRESS_Invalidate( infoPtr, oldVal, infoPtr->CurVal ); + UpdateWindow(infoPtr->Self); } return oldVal; } Index: dlls/comctl32/status.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/status.c,v retrieving revision 1.66 diff -u -r1.66 status.c --- dlls/comctl32/status.c 14 Sep 2004 00:45:26 -0000 1.66 +++ dlls/comctl32/status.c 19 Sep 2004 21:45:56 -0000 @@ -539,14 +539,14 @@ return TRUE; infoPtr->part0.hIcon = hIcon; if (infoPtr->simple) - InvalidateRect(infoPtr->Self, &infoPtr->part0.bound, FALSE); + RedrawWindow(infoPtr->Self, &infoPtr->part0.bound, NULL, RDW_INVALIDATE | RDW_UPDATENOW); } else { if (infoPtr->parts[nPart].hIcon == hIcon) /* same as - no redraw */ return TRUE; infoPtr->parts[nPart].hIcon = hIcon; if (!(infoPtr->simple)) - InvalidateRect(infoPtr->Self, &infoPtr->parts[nPart].bound, FALSE); + RedrawWindow(infoPtr->Self, &infoPtr->parts[nPart].bound, NULL, RDW_INVALIDATE | RDW_UPDATENOW); } return TRUE; } @@ -641,7 +641,7 @@ } } STATUSBAR_SetPartBounds (infoPtr); - InvalidateRect(infoPtr->Self, NULL, FALSE); + RedrawWindow(infoPtr->Self, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return TRUE; } @@ -708,7 +708,7 @@ Free (part->text); part->text = ntext; } - InvalidateRect(infoPtr->Self, &part->bound, FALSE); + RedrawWindow(infoPtr->Self, &part->bound, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return TRUE; } @@ -780,7 +780,8 @@ nmhdr.idFrom = GetWindowLongPtrW (infoPtr->Self, GWLP_ID); nmhdr.code = SBN_SIMPLEMODECHANGE; SendMessageW (infoPtr->Notify, WM_NOTIFY, 0, (LPARAM)&nmhdr); - InvalidateRect(infoPtr->Self, NULL, FALSE); + RedrawWindow(infoPtr->Self, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); + return TRUE; } @@ -839,9 +840,7 @@ i = SendMessageW(infoPtr->Notify, WM_NOTIFYFORMAT, (WPARAM)hwnd, NF_QUERY); infoPtr->NtfUnicode = (i == NFR_UNICODE); - GetClientRect (hwnd, &rect); - InvalidateRect (hwnd, &rect, 0); - UpdateWindow(hwnd); + RedrawWindow(hwnd, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); ZeroMemory (&nclm, sizeof(nclm)); nclm.cbSize = sizeof(nclm); @@ -1051,7 +1050,7 @@ } } - InvalidateRect(infoPtr->Self, &part->bound, FALSE); + RedrawWindow(infoPtr->Self, &part->bound, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return TRUE; } Index: dlls/comctl32/tab.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/tab.c,v retrieving revision 1.99 diff -u -r1.99 tab.c --- dlls/comctl32/tab.c 14 Sep 2004 00:44:26 -0000 1.99 +++ dlls/comctl32/tab.c 19 Sep 2004 21:45:58 -0000 @@ -236,6 +236,7 @@ infoPtr->iSelected=iItem; TAB_EnsureSelectionVisible(hwnd, infoPtr); TAB_InvalidateTabArea(hwnd, infoPtr); + UpdateWindow(hwnd); } return prevItem; } Index: dlls/comctl32/trackbar.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/trackbar.c,v retrieving revision 1.62 diff -u -r1.62 trackbar.c --- dlls/comctl32/trackbar.c 14 Sep 2004 00:45:26 -0000 1.62 +++ dlls/comctl32/trackbar.c 19 Sep 2004 21:45:59 -0000 @@ -375,12 +375,6 @@ TRACKBAR_CalcThumb(infoPtr, infoPtr->lPos, &infoPtr->rcThumb); } -static inline void -TRACKBAR_InvalidateAll(TRACKBAR_INFO * infoPtr) -{ - InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); -} - static void TRACKBAR_InvalidateThumb (TRACKBAR_INFO *infoPtr, LONG thumbPos) { @@ -951,7 +945,8 @@ infoPtr->lSelMax = 0; infoPtr->flags |= TB_SELECTIONCHANGED; - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -966,7 +961,8 @@ infoPtr->uNumTics = 0; } - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -1096,7 +1092,11 @@ infoPtr->lPos = infoPtr->lRangeMax; infoPtr->flags |= TB_THUMBPOSCHANGED; - if (fPosition) TRACKBAR_InvalidateThumbMove(infoPtr, oldPos, lPosition); + if (fPosition) + { + TRACKBAR_InvalidateThumbMove(infoPtr, oldPos, lPosition); + UpdateWindow(infoPtr->hwndSelf); + } return 0; } @@ -1121,7 +1121,8 @@ infoPtr->lPageSize = (infoPtr->lRangeMax - infoPtr->lRangeMin) / 5; if (infoPtr->lPageSize == 0) infoPtr->lPageSize = 1; - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -1139,7 +1140,8 @@ infoPtr->lPageSize = (infoPtr->lRangeMax - infoPtr->lRangeMin) / 5; if (infoPtr->lPageSize == 0) infoPtr->lPageSize = 1; - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -1157,7 +1159,8 @@ infoPtr->lPageSize = (infoPtr->lRangeMax - infoPtr->lRangeMin) / 5; if (infoPtr->lPageSize == 0) infoPtr->lPageSize = 1; - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -1178,7 +1181,8 @@ if (infoPtr->lSelMax > infoPtr->lRangeMax) infoPtr->lSelMax = infoPtr->lRangeMax; - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -1196,7 +1200,8 @@ if (infoPtr->lSelMax > infoPtr->lRangeMax) infoPtr->lSelMax = infoPtr->lRangeMax; - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -1214,7 +1219,8 @@ if (infoPtr->lSelMin < infoPtr->lRangeMin) infoPtr->lSelMin = infoPtr->lRangeMin; - if (fRedraw) TRACKBAR_InvalidateAll(infoPtr); + if (fRedraw) + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); return 0; } @@ -1226,7 +1232,7 @@ if (GetWindowLongW (infoPtr->hwndSelf, GWL_STYLE) & TBS_FIXEDLENGTH) { infoPtr->uThumbLen = iLength; infoPtr->flags |= TB_THUMBSIZECHANGED; - InvalidateRect (infoPtr->hwndSelf, &infoPtr->rcThumb, FALSE); + RedrawWindow(infoPtr->hwndSelf, &infoPtr->rcThumb, NULL, RDW_INVALIDATE | RDW_UPDATENOW); } return 0; @@ -1254,8 +1260,8 @@ } infoPtr->tics[infoPtr->uNumTics-1] = lPos; - TRACKBAR_InvalidateAll(infoPtr); - + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); + return TRUE; } @@ -1266,7 +1272,7 @@ if (GetWindowLongW (infoPtr->hwndSelf, GWL_STYLE) & TBS_AUTOTICKS) { infoPtr->uTicFreq = wFreq; TRACKBAR_RecalculateTics (infoPtr); - TRACKBAR_InvalidateAll(infoPtr); + RedrawWindow(infoPtr->hwndSelf, NULL, NULL, RDW_INVALIDATE | RDW_UPDATENOW); } return 0; @@ -1412,7 +1418,7 @@ { TRACE("\n"); infoPtr->bFocussed = FALSE; - TRACKBAR_InvalidateAll(infoPtr); + InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); return 0; } @@ -1496,7 +1502,7 @@ { TRACE("\n"); infoPtr->bFocussed = TRUE; - TRACKBAR_InvalidateAll(infoPtr); + InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); return 0; } Index: dlls/comctl32/treeview.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/treeview.c,v retrieving revision 1.151 diff -u -r1.151 treeview.c --- dlls/comctl32/treeview.c 13 Sep 2004 23:22:30 -0000 1.151 +++ dlls/comctl32/treeview.c 19 Sep 2004 21:46:02 -0000 @@ -4114,7 +4114,9 @@ TREEVIEW_Invalidate(infoPtr, NULL); break; } - + + UpdateWindow(infoPtr->hwnd); + TRACE("Leaving state %d\n", newSelect ? newSelect->state : 0); return TRUE; } Index: dlls/user/combo.c =================================================================== RCS file: /home/wine/wine/dlls/user/combo.c,v retrieving revision 1.1 diff -u -r1.1 combo.c --- dlls/user/combo.c 31 Aug 2004 01:10:08 -0000 1.1 +++ dlls/user/combo.c 19 Sep 2004 21:46:07 -0000 @@ -1141,9 +1141,9 @@ SWP_NOACTIVATE | SWP_SHOWWINDOW); - if( !(lphc->wState & CBF_NOREDRAW) ) - RedrawWindow( lphc->self, NULL, 0, RDW_INVALIDATE | - RDW_ERASE | RDW_UPDATENOW | RDW_NOCHILDREN ); + if( !(lphc->wState & CBF_NOREDRAW) && !IsRectEmpty(&lphc->buttonRect) ) + RedrawWindow ( lphc->self, &lphc->buttonRect, 0, RDW_INVALIDATE | + RDW_ERASE | RDW_UPDATENOW); EnableWindow( lphc->hWndLBox, TRUE ); if (GetCapture() != lphc->self) @@ -1314,7 +1314,7 @@ case (EN_CHANGE >> 8): /* * In some circumstances (when the selection of the combobox - * is changed for example) we don't wans the EN_CHANGE notification + * is changed for example) we don't want the EN_CHANGE notification * to be forwarded to the parent of the combobox. This code * checks a flag that is set in these occasions and ignores the * notification. @@ -1382,6 +1382,10 @@ CB_NOTIFY( lphc, CBN_SELCHANGE ); + /* FIXME: Calling this before CB_NOTIFY looks much nicer, + but Windows does it this way */ + UpdateWindow(lphc->self); + /* fall through */ case LBN_SETFOCUS: Index: dlls/user/edit.c =================================================================== RCS file: /home/wine/wine/dlls/user/edit.c,v retrieving revision 1.3 diff -u -r1.3 edit.c --- dlls/user/edit.c 16 Sep 2004 20:28:10 -0000 1.3 +++ dlls/user/edit.c 19 Sep 2004 21:46:11 -0000 @@ -229,7 +229,7 @@ static BOOL EDIT_EM_LineScroll(EDITSTATE *es, INT dx, INT dy); static BOOL EDIT_EM_LineScroll_internal(EDITSTATE *es, INT dx, INT dy); static LRESULT EDIT_EM_PosFromChar(EDITSTATE *es, INT index, BOOL after_wrap); -static void EDIT_EM_ReplaceSel(EDITSTATE *es, BOOL can_undo, LPCWSTR lpsz_replace, BOOL send_update, BOOL honor_limit); +static void EDIT_EM_ReplaceSel(EDITSTATE *es, BOOL can_undo, LPCWSTR lpsz_replace, BOOL send_update, BOOL honor_limit, BOOL drawImmediately); static LRESULT EDIT_EM_Scroll(EDITSTATE *es, INT action); static void EDIT_EM_ScrollCaret(EDITSTATE *es); static void EDIT_EM_SetHandle(EDITSTATE *es, HLOCAL hloc); @@ -237,7 +237,7 @@ static void EDIT_EM_SetLimitText(EDITSTATE *es, INT limit); static void EDIT_EM_SetMargins(EDITSTATE *es, INT action, INT left, INT right); static void EDIT_EM_SetPasswordChar(EDITSTATE *es, WCHAR c); -static void EDIT_EM_SetSel(EDITSTATE *es, UINT start, UINT end, BOOL after_wrap); +static void EDIT_EM_SetSel(EDITSTATE *es, UINT start, UINT end, BOOL after_wrap, BOOL drawImmediately); static BOOL EDIT_EM_SetTabStops(EDITSTATE *es, INT count, LPINT tabs); static BOOL EDIT_EM_SetTabStops16(EDITSTATE *es, INT count, LPINT16 tabs); static void EDIT_EM_SetWordBreakProc(EDITSTATE *es, LPARAM lParam); @@ -330,7 +330,7 @@ if(es->style & ES_READONLY) return; - EDIT_EM_ReplaceSel(es, TRUE, empty_stringW, TRUE, TRUE); + EDIT_EM_ReplaceSel(es, TRUE, empty_stringW, TRUE, TRUE, TRUE); } @@ -445,15 +445,15 @@ case EM_SETSEL16: if ((short)LOWORD(lParam) == -1) - EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE); + EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE, TRUE); else - EDIT_EM_SetSel(es, LOWORD(lParam), HIWORD(lParam), FALSE); + EDIT_EM_SetSel(es, LOWORD(lParam), HIWORD(lParam), FALSE, TRUE); if (!wParam) EDIT_EM_ScrollCaret(es); result = 1; break; case EM_SETSEL: - EDIT_EM_SetSel(es, wParam, lParam, FALSE); + EDIT_EM_SetSel(es, wParam, lParam, FALSE, TRUE); EDIT_EM_ScrollCaret(es); result = 1; break; @@ -608,7 +608,7 @@ MultiByteToWideChar(CP_ACP, 0, textA, -1, textW, countW); } - EDIT_EM_ReplaceSel(es, (BOOL)wParam, textW, TRUE, TRUE); + EDIT_EM_ReplaceSel(es, (BOOL)wParam, textW, TRUE, TRUE, TRUE); result = 1; if(!unicode) @@ -1813,7 +1813,7 @@ e--; } } - EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, FALSE); + EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, FALSE, TRUE); EDIT_EM_ScrollCaret(es); } @@ -1839,7 +1839,7 @@ e = EDIT_CharFromPos(es, x, y + es->line_height, &after_wrap); if (!extend) s = e; - EDIT_EM_SetSel(es, s, e, after_wrap); + EDIT_EM_SetSel(es, s, e, after_wrap, TRUE); EDIT_EM_ScrollCaret(es); } @@ -1860,7 +1860,7 @@ HIWORD(EDIT_EM_PosFromChar(es, es->selection_end, es->flags & EF_AFTER_WRAP)), &after_wrap); else e = strlenW(es->text); - EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, after_wrap); + EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, after_wrap, TRUE); EDIT_EM_ScrollCaret(es); } @@ -1883,7 +1883,7 @@ e += 2; } } - EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, FALSE); + EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, FALSE, TRUE); EDIT_EM_ScrollCaret(es); } @@ -1905,7 +1905,7 @@ HIWORD(EDIT_EM_PosFromChar(es, es->selection_end, es->flags & EF_AFTER_WRAP)), NULL); else e = 0; - EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, FALSE); + EDIT_EM_SetSel(es, extend ? es->selection_start : e, e, FALSE, TRUE); EDIT_EM_ScrollCaret(es); } @@ -1933,7 +1933,7 @@ &after_wrap); if (!extend) s = e; - EDIT_EM_SetSel(es, s, e, after_wrap); + EDIT_EM_SetSel(es, s, e, after_wrap, TRUE); EDIT_EM_ScrollCaret(es); } @@ -1961,7 +1961,7 @@ &after_wrap); if (!extend) s = e; - EDIT_EM_SetSel(es, s, e, after_wrap); + EDIT_EM_SetSel(es, s, e, after_wrap, TRUE); EDIT_EM_ScrollCaret(es); } @@ -1987,7 +1987,7 @@ e = EDIT_CharFromPos(es, x, y - es->line_height, &after_wrap); if (!extend) s = e; - EDIT_EM_SetSel(es, s, e, after_wrap); + EDIT_EM_SetSel(es, s, e, after_wrap, TRUE); EDIT_EM_ScrollCaret(es); } @@ -2019,7 +2019,7 @@ } if (!extend) s = e; - EDIT_EM_SetSel(es, s, e, FALSE); + EDIT_EM_SetSel(es, s, e, FALSE, TRUE); EDIT_EM_ScrollCaret(es); } @@ -2049,7 +2049,7 @@ } if (!extend) s = e; - EDIT_EM_SetSel(es, s, e, FALSE); + EDIT_EM_SetSel(es, s, e, FALSE, TRUE); EDIT_EM_ScrollCaret(es); } @@ -2897,7 +2897,7 @@ * FIXME: handle ES_NUMBER and ES_OEMCONVERT here * */ -static void EDIT_EM_ReplaceSel(EDITSTATE *es, BOOL can_undo, LPCWSTR lpsz_replace, BOOL send_update, BOOL honor_limit) +static void EDIT_EM_ReplaceSel(EDITSTATE *es, BOOL can_undo, LPCWSTR lpsz_replace, BOOL send_update, BOOL honor_limit, BOOL drawImmediately) { UINT strl = strlenW(lpsz_replace); UINT tl = strlenW(es->text); @@ -3009,7 +3009,7 @@ else EDIT_CalcLineWidth_SL(es); - EDIT_EM_SetSel(es, s, s, FALSE); + EDIT_EM_SetSel(es, s, s, FALSE, FALSE); es->flags |= EF_MODIFIED; if (send_update) es->flags |= EF_UPDATE; if (hrgn) @@ -3025,6 +3025,7 @@ /* force scroll info update */ EDIT_UpdateScrollInfo(es); + if (drawImmediately) UpdateWindow(es->hwndSelf); if(es->flags & EF_UPDATE) { @@ -3421,7 +3422,7 @@ * In other words: this handler is OK * */ -static void EDIT_EM_SetSel(EDITSTATE *es, UINT start, UINT end, BOOL after_wrap) +static void EDIT_EM_SetSel(EDITSTATE *es, UINT start, UINT end, BOOL after_wrap, BOOL drawImmediately) { UINT old_start = es->selection_start; UINT old_end = es->selection_end; @@ -3466,6 +3467,8 @@ } } else EDIT_InvalidateText(es, start, old_end); + + if (drawImmediately) UpdateWindow(es->hwndSelf); } @@ -3578,10 +3581,10 @@ TRACE("before UNDO:insertion length = %d, deletion buffer = %s\n", es->undo_insert_count, debugstr_w(utext)); - EDIT_EM_SetSel(es, es->undo_position, es->undo_position + es->undo_insert_count, FALSE); + EDIT_EM_SetSel(es, es->undo_position, es->undo_position + es->undo_insert_count, FALSE, FALSE); EDIT_EM_EmptyUndoBuffer(es); - EDIT_EM_ReplaceSel(es, TRUE, utext, TRUE, TRUE); - EDIT_EM_SetSel(es, es->undo_position, es->undo_position + es->undo_insert_count, FALSE); + EDIT_EM_ReplaceSel(es, TRUE, utext, TRUE, TRUE, FALSE); + EDIT_EM_SetSel(es, es->undo_position, es->undo_position + es->undo_insert_count, FALSE, FALSE); /* send the notification after the selection start and end are set */ EDIT_NOTIFY_PARENT(es, EN_CHANGE, "EN_CHANGE"); EDIT_EM_ScrollCaret(es); @@ -3616,7 +3619,7 @@ EDIT_MoveDown_ML(es, FALSE); } else { static const WCHAR cr_lfW[] = {'\r','\n',0}; - EDIT_EM_ReplaceSel(es, TRUE, cr_lfW, TRUE, TRUE); + EDIT_EM_ReplaceSel(es, TRUE, cr_lfW, TRUE, TRUE, TRUE); } } break; @@ -3624,7 +3627,7 @@ if ((es->style & ES_MULTILINE) && !(es->style & ES_READONLY)) { static const WCHAR tabW[] = {'\t',0}; - EDIT_EM_ReplaceSel(es, TRUE, tabW, TRUE, TRUE); + EDIT_EM_ReplaceSel(es, TRUE, tabW, TRUE, TRUE, TRUE); } break; case VK_BACK: @@ -3633,7 +3636,7 @@ EDIT_WM_Clear(es); else { /* delete character left of caret */ - EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE); + EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE, TRUE); EDIT_MoveBackward(es, TRUE); EDIT_WM_Clear(es); } @@ -3660,7 +3663,7 @@ WCHAR str[2]; str[0] = c; str[1] = '\0'; - EDIT_EM_ReplaceSel(es, TRUE, str, TRUE, TRUE); + EDIT_EM_ReplaceSel(es, TRUE, str, TRUE, TRUE, TRUE); } break; } @@ -3694,7 +3697,7 @@ EDIT_WM_Clear(es); break; case EM_SETSEL: - EDIT_EM_SetSel(es, 0, (UINT)-1, FALSE); + EDIT_EM_SetSel(es, 0, (UINT)-1, FALSE, TRUE); EDIT_EM_ScrollCaret(es); break; default: @@ -3792,7 +3795,7 @@ EDIT_EM_EmptyUndoBuffer(es); if (name && *name) { - EDIT_EM_ReplaceSel(es, FALSE, name, FALSE, TRUE); + EDIT_EM_ReplaceSel(es, FALSE, name, FALSE, TRUE, FALSE); /* if we insert text to the editline, the text scrolls out * of the window, as the caret is placed after the insert * pos normally; thus we reset es->selection... to 0 and @@ -4158,17 +4161,17 @@ } else { if (shift) { /* delete character left of caret */ - EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE); + EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE, TRUE); EDIT_MoveBackward(es, TRUE); EDIT_WM_Clear(es); } else if (control) { /* delete to end of line */ - EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE); + EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE, TRUE); EDIT_MoveEnd(es, TRUE); EDIT_WM_Clear(es); } else { /* delete character right of caret */ - EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE); + EDIT_EM_SetSel(es, (UINT)-1, 0, FALSE, TRUE); EDIT_MoveForward(es, TRUE); EDIT_WM_Clear(es); } @@ -4240,7 +4243,7 @@ ll = EDIT_EM_LineLength(es, e); s = li + EDIT_CallWordBreakProc(es, li, e - li, ll, WB_LEFT); e = li + EDIT_CallWordBreakProc(es, li, e - li, ll, WB_RIGHT); - EDIT_EM_SetSel(es, s, e, FALSE); + EDIT_EM_SetSel(es, s, e, FALSE, TRUE); EDIT_EM_ScrollCaret(es); return 0; } @@ -4264,7 +4267,7 @@ SetCapture(es->hwndSelf); EDIT_ConfinePoint(es, &x, &y); e = EDIT_CharFromPos(es, x, y, &after_wrap); - EDIT_EM_SetSel(es, (keys & MK_SHIFT) ? es->selection_start : e, e, after_wrap); + EDIT_EM_SetSel(es, (keys & MK_SHIFT) ? es->selection_start : e, e, after_wrap, TRUE); EDIT_EM_ScrollCaret(es); es->region_posx = es->region_posy = 0; SetTimer(es->hwndSelf, 0, 100, NULL); @@ -4323,7 +4326,7 @@ es->region_posx = (prex < x) ? -1 : ((prex > x) ? 1 : 0); es->region_posy = (prey < y) ? -1 : ((prey > y) ? 1 : 0); e = EDIT_CharFromPos(es, x, y, &after_wrap); - EDIT_EM_SetSel(es, es->selection_start, e, after_wrap); + EDIT_EM_SetSel(es, es->selection_start, e, after_wrap, TRUE); EDIT_SetCaretPos(es,es->selection_end,es->flags & EF_AFTER_WRAP); return 0; } @@ -4533,7 +4536,7 @@ OpenClipboard(es->hwndSelf); if ((hsrc = GetClipboardData(CF_UNICODETEXT))) { src = (LPWSTR)GlobalLock(hsrc); - EDIT_EM_ReplaceSel(es, TRUE, src, TRUE, TRUE); + EDIT_EM_ReplaceSel(es, TRUE, src, TRUE, TRUE, TRUE); GlobalUnlock(hsrc); } CloseClipboard(); @@ -4634,20 +4637,20 @@ MultiByteToWideChar(CP_ACP, 0, textA, -1, text, countW); } - EDIT_EM_SetSel(es, 0, (UINT)-1, FALSE); + EDIT_EM_SetSel(es, 0, (UINT)-1, FALSE, FALSE); if (text) { TRACE("%s\n", debugstr_w(text)); - EDIT_EM_ReplaceSel(es, FALSE, text, FALSE, FALSE); + EDIT_EM_ReplaceSel(es, FALSE, text, FALSE, FALSE, FALSE); if(!unicode) HeapFree(GetProcessHeap(), 0, text); } else { static const WCHAR empty_stringW[] = {0}; TRACE("<NULL>\n"); - EDIT_EM_ReplaceSel(es, FALSE, empty_stringW, FALSE, FALSE); + EDIT_EM_ReplaceSel(es, FALSE, empty_stringW, FALSE, FALSE, FALSE); } es->x_offset = 0; es->flags &= ~EF_MODIFIED; - EDIT_EM_SetSel(es, 0, 0, FALSE); + EDIT_EM_SetSel(es, 0, 0, FALSE, FALSE); /* Send the notification after the selection start and end have been set * edit control doesn't send notification on WM_SETTEXT * if it is multiline, or it is part of combobox @@ -4890,7 +4893,7 @@ /********************************************************************* * - * EDIT_UpdateText + * EDIT_UpdateTextRegion * */ static void EDIT_UpdateTextRegion(EDITSTATE *es, HRGN hrgn, BOOL bErase) Index: dlls/user/listbox.c =================================================================== RCS file: /home/wine/wine/dlls/user/listbox.c,v retrieving revision 1.1 diff -u -r1.1 listbox.c --- dlls/user/listbox.c 31 Aug 2004 01:10:08 -0000 1.1 +++ dlls/user/listbox.c 19 Sep 2004 21:46:13 -0000 @@ -2363,6 +2363,12 @@ descr->anchor_item = caret; LISTBOX_MoveCaret( hwnd, descr, caret, TRUE ); LISTBOX_SetSelection( hwnd, descr, caret, TRUE, FALSE); + + /* If the content has been scrolled, the new items + * need to be drawn immediately (Windows does it this way) + */ + UpdateWindow(hwnd); + if (descr->style & LBS_NOTIFY) { if( descr->lphc ) @@ -2712,7 +2718,9 @@ case LB_SETTOPINDEX16: case LB_SETTOPINDEX: - return LISTBOX_SetTopItem( hwnd, descr, wParam, TRUE ); + ret = LISTBOX_SetTopItem( hwnd, descr, wParam, TRUE ); + UpdateWindow(hwnd); /* Windows does this too */ + return ret; case LB_SETCOLUMNWIDTH16: case LB_SETCOLUMNWIDTH: @@ -2831,7 +2839,9 @@ case LB_SETCURSEL: if (IS_MULTISELECT(descr)) return LB_ERR; LISTBOX_SetCaretIndex( hwnd, descr, wParam, TRUE ); - return LISTBOX_SetSelection( hwnd, descr, wParam, TRUE, FALSE ); + ret = LISTBOX_SetSelection( hwnd, descr, wParam, TRUE, FALSE ); + UpdateWindow(hwnd); /* Windows does this too */ + return ret; case LB_GETSELCOUNT16: case LB_GETSELCOUNT: Index: dlls/user/static.c =================================================================== RCS file: /home/wine/wine/dlls/user/static.c,v retrieving revision 1.1 diff -u -r1.1 static.c --- dlls/user/static.c 31 Aug 2004 01:10:08 -0000 1.1 +++ dlls/user/static.c 19 Sep 2004 21:46:14 -0000 @@ -319,8 +319,6 @@ else lResult = DefWindowProcA( hwnd, WM_SETTEXT, wParam, lParam ); } - if (uMsg == WM_SETTEXT) - STATIC_TryPaintFcn( hwnd, full_style ); break; } default: @@ -331,9 +329,10 @@ else lResult = DefWindowProcA( hwnd, WM_SETTEXT, wParam, lParam ); } - if(uMsg == WM_SETTEXT) - InvalidateRect(hwnd, NULL, TRUE); } + + STATIC_TryPaintFcn( hwnd, full_style ); + return 1; /* success. FIXME: check text length */ case WM_SETFONT:

2 1

problem testing (winemine)
by Internet 21 Sep '04

21 Sep '04

Sorry if I write to this address (guess thousands of people do it :) ) but I've searched all the web for a solution and I wasn't able to find it, maybe it's just too stupid to be noticed by anyone :D I wish I could post it on any newsgroup, but I haven't access to newsservers from my workplace... I've found problems compiling one of the sample applications (winemine, as in user guide). After running winemaker I have no configure script generated, and just typing "make" gives me a parse error in De.rc Maybe there's something wrong with my installation? I'm running slackware 10.0 and I simply installed from source version 20040914, without any error. Is this a known problem? Thanks in advance for the attention and for all your work! Bono Carlo Re S.p.a. Controlli Industriali ARTD - Almost Re Technical Department internet(a)re-spa.com

1 0

Re: WIDL: use __RPC_FAR attribute for pointers in proxies
by Alexandre Julliard 21 Sep '04

21 Sep '04

Mike McCormack <mike(a)codeweavers.com> writes: > ChangeLog: > * use __RPC_FAR attribute for pointers in proxies Is this really useful? __RPC_FAR will always be an empty define, even when building on Windows, and I doubt we'll want to add 16-bit support to widl... -- Alexandre Julliard julliard(a)winehq.org

4 9

Re: MSCMS: new dll
by Robert Shearman 21 Sep '04

21 Sep '04

Hans Leidekker wrote: >Hi, > >Here's the beginnings of an MSCMS.DLL (color management) on top of the >LittleCMS library. I had to resort to some rather ugly preprocessor >trickery to be able to include lcms.h, since it happens to define basic >Windows types when not compiled on Windows ;-(. > > -Hans > >Changelog: > Beginnings of an MSCMS implementation based on LittleCMS. > > Is adding this to the Wine tree likely to break more apps than it fixes? How much work will you be doing on this library? Will we get into the same state as SHDOCVW where the DLL is essentially useless? Rob

11 21

Installing dot net framework 1.1 on wine
by Lara Joy Francia 21 Sep '04

21 Sep '04

I tried installing .net framework 1.1 on wine but it always fails. It says, "Microsoft .NET Framework 1.1 setup has ended prematurely.. ". Does anyone know what should be done like what are the dlls and configuration needed in order for it to finish installing? ________________________________________________________________________ Yahoo! Messenger - Communicate instantly..."Ping" your friends today! Download Messenger Now http://uk.messenger.yahoo.com/download/index.html

2 1

Re: security provider
by Juan Lang 21 Sep '04

21 Sep '04

Paul wrote: > I see there is a secur32 implementation but can see > no providers? Are there any providers anywhere? Is > there a sample? Is there a ms-kerberos clone? Are > there any docs on how to create a provider - or do I > just do it like a Windows one and it should just > work? There aren't any providers in Wine atm. The native ones should mostly work, if they don't depend on other undocumented or missing bits. There's a sample provider in the platform SDK. Do one just like a Windows one and it should work--post here or email me if you run into trouble. --Juan __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - 100MB free storage! http://promotions.yahoo.com/new_mail

1 0

\\ in paths causing problem, known bug?
by J. Grant 20 Sep '04

20 Sep '04

Hello, I just ran the eDonkey2000 Installer. The default install directory was invalid: C:\\Program Files\eDonkey2000 The extra \ was the problem. I think this is a WINE issue. Is this problem know about already? (Bugzilla does not contain this). I thought I would check before considering filing a bug report. Please include my email address in replies. You can download this exe from www.overnet.com, it is the free version of eDonkey2000 if you would like to test. Kind regards JG -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

1 0

Latest CVS config upgrade of drive letters problem
by J. Grant 20 Sep '04

20 Sep '04

Hello, I just built and installed CVS WINE using the work around for asla suggested by Ivan. However, the config file does not seem to have been converted correctly. I fixed the symbolic link manually. Read on if you are interested to know the details of this bug. Kind regards JG $ wcmd Created symlink /home/now3d/.wine/dosdevices/com1 -> /dev/ttyS0 Created symlink /home/now3d/.wine/dosdevices/com2 -> /dev/ttyS1 Created symlink /home/now3d/.wine/dosdevices/com3 -> /dev/ttyS2 Created symlink /home/now3d/.wine/dosdevices/com4 -> /dev/modem Created symlink /home/now3d/.wine/dosdevices/lpt1 -> /dev/lp0 Created symlink /home/now3d/.wine/dosdevices/c: -> /home/now3d/c Created symlink /home/now3d/.wine/dosdevices/d: -> ../${HOME} Created symlink /home/now3d/.wine/dosdevices/e: -> /tmp Created symlink /home/now3d/.wine/dosdevices/f: -> /mnt/cdrom2 Created symlink /home/now3d/.wine/dosdevices/g: -> /mnt/cdrom Created symlink /home/now3d/.wine/dosdevices/f:: -> /dev/scd0 Created symlink /home/now3d/.wine/dosdevices/g:: -> /dev/scd1 You can now remove the [SerialPorts], [ParallelPorts], and [Drive] sections in your configuration file, they are replaced by the above symlinks. Converted drive type to new entry HKLM\Software\Wine\Drives "C:" = L"hd" Converted drive type to new entry HKLM\Software\Wine\Drives "D:" = L"network" Converted drive type to new entry HKLM\Software\Wine\Drives "E:" = L"hd" Converted drive type to new entry HKLM\Software\Wine\Drives "F:" = L"cdrom" Converted drive type to new entry HKLM\Software\Wine\Drives "G:" = L"cdrom" Converted temp dir to new entry HKCU\Environment "TEMP" = L"e:\\" Converted path dir to new entry HKCU\Environment "PATH" = L"d:\\vs\\vc98\\bin;d:\\vs\\common\\msdev98\\bin;c:\\windows;c:\\windows\\system" Converted profile dir to new entry HKCU\Environment "USERPROFILE" = L"c:\\windows\\Profiles\\Administrator" Converted windows dir to new entry HKCU\Environment "windir" = L"c:\\windows" Converted system dir to new entry HKCU\Environment "winsysdir" = L"c:\\windows\\system" Warning: could not find DOS drive for current working directory '/home/now3d', starting in the Windows directory. Please use the registry key HKEY_CURRENT_CONFIG\Software\Fonts\LogPixels to set the screen resolution and remove the "Resolution" entry in the config file fixme:font:WineEngCreateFontInstance just using first face for now WCMD Version 0.17 C:\windows>ls File not found C:\windows>cd .. C:\>ver WCMD Version 0.17 C:\>d: Path not found C:\>d:\ Path not found C:\>cd d: Path not found This worked before I ugpraded. 10 Sep 20 00:13 d: -> ../${HOME} Thats a duff sym link, so I assume it was not evaluated correctly in that script..? Are these double links meant to be present? lrwxrwxrwx 1 now3d now3d 11 Sep 20 00:13 f: -> /mnt/cdrom2/ lrwxrwxrwx 1 now3d now3d 9 Sep 20 00:13 f:: -> /dev/scd0 lrwxrwxrwx 1 now3d now3d 10 Sep 20 00:13 g: -> /mnt/cdrom/ lrwxrwxrwx 1 now3d now3d 9 Sep 20 00:13 g:: -> /dev/scd1 lrwxrwxrwx 1 now3d now3d 10 Sep 20 00:13 com2 -> /dev/ttyS1 lrwxrwxrwx 1 now3d now3d 10 Sep 20 00:13 com3 -> /dev/ttyS2 these are also duff links, but maybe it will not effect anything. -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

2 3

security provider
by Paul Moore 20 Sep '04

20 Sep '04

I see there is a secur32 implementation but can see no providers? Are there any providers anywhere? Is there a sample? Is there a ms-kerberos clone? Are there any docs on how to create a provider - or do I just do it like a Windows one and it should just work?

1 0

fonts
by Ivan Leo Puoti 20 Sep '04

20 Sep '04

What is required to build /fonts? Ivan.

3 2

RE: Help with GetConsoleWindow()
by Ewert, Mark 20 Sep '04

20 Sep '04

I think you're right. The program seems to crash at a point much later than the GetConsoleWindow call. Here's what I see: "wine: Unhandled exception (thread 000d), starting debugger... WineDbg starting on pid 0x8 Unhandled exception: page fault on write access to 0x41a417a4 in 32-bit code (0x10007239). In 32 bit mode." A window pops up that says: "Uhandled page fault on write access to 0x41a417a4 at address 0x10007239 Do you wish to debug it?" When I click yes I get a dump of all the register/memory locations. Is there anything in particular I should look for? -----Original Message----- From: Eric Pouech [mailto:pouech-eric@wanadoo.fr] Sent: Saturday, September 18, 2004 12:12 AM To: Ewert, Mark Cc: wine-devel(a)winehq.org Subject: Re: Help with GetConsoleWindow() > Any ideas on what GetConsoleWindow() should actually return? it should return the handle of the window (user32) where the console actually runs (it is attached to a console). Anyway, are you sure the segfault you see is related to returning a non NULL value in GetConsoleWindow compared to another bug in Wine (because you are running on another codepath - the first one being the graphical display). Where does you program actually crash ? A+

2 1

Re: A couple of menu fixes
by Andreas Mohr 20 Sep '04

20 Sep '04

Hi, On Mon, Sep 20, 2004 at 07:03:47PM +0900, Dmitry Timoshkov wrote: > Hello, > > this patch fixes 2 problems with menu tracking: > 1. menu navigation keys do not work when there is no focus window, > i.e. menu code does not handle WM_SYSKEY*/WM_SYSCHAR messages. > 2. when a window owning a menu is being destroyed its menu loop > never unblocks. Pietrek's book mentions that it's the responsibility > of DestroyWindow to call EndMenu() in that case. Great! But... I'm currently working on some other menu aspects (ModifyMenu/InsertMenu), since Microsoft Works 2000 is horribly broken. I intend to submit some fixes soon, so it'd be useful if other people chose to not work in this area. I've been trying to simply "fix" these issues, but it's so confusing (if you fix one thing, then the next one fails) that I should have started with menu tests first... So I'll do extensive tests and try to fix everything that I find. Andreas Mohr

2 1

(no subject)
by lara joy Francia 20 Sep '04

20 Sep '04

I tried installing .net framework 1.1 on wine but it always fails. It says, "Microsoft .NET Framework 1.1 setup has ended prematurely.. ". Does anyone know what should be done like what are the dlls and configuration needed in order for it to finish installing? ________________________________________________________________________ Yahoo! Messenger - Communicate instantly..."Ping" your friends today! Download Messenger Now http://uk.messenger.yahoo.com/download/index.html

1 0

Internet Explorer 5.5 on wine (os version = "win2k")
by Lara Joy Francia 20 Sep '04

20 Sep '04

Does anyone know how to install internet explorer 5.5 on Linux with wine (os version = win2k)? I already tried installing ie5.5 on wine with os version as win98 and it worked however, I need to set the os version to win2k because it is the required os version of the other application that I'm trying install on wine. Thanks in advance. ________________________________________________________________________ Yahoo! Messenger - Communicate instantly..."Ping" your friends today! Download Messenger Now http://uk.messenger.yahoo.com/download/index.html

3 2

cdega question
by Jonathan Wilson 20 Sep '04

20 Sep '04

Does the transgaming WINE have anything above what stock WINE has when it comes to OpenGL apps/games?

2 1

Re: Latest CVS alsa problem
by J. Grant 19 Sep '04

19 Sep '04

Hi Ivan, Thanks for your quick response. on the 19/09/04 22:14, Ivan Leo Puoti wrote: >> libalsa2-devel-0.9.0-0.8rc2mdk > This package contains the alsa development headers, so unless you have some good > reason to keep this RPM installed (For example you develop an app that needs > these headers), you can just uninstall this package and wine will compile > without alsa support. Wine's OSS driver should work with alsa's oss emulation. Ok, I did as you suggested and it now works. However it was a bit of a pain, because I use this version of ALSA for SDL development, so I am going to have to reinstall those packages and their deps to let me work on that. Would you be able to consider adding ./configure --disable-alsa ? (a la MPlayer and other projects) Also perhaps the alsa detection could not set it up when only alsa 0.9.0 is installed if WINE requires 1.0.x alsa now..? Please include my email address in any replies. Kind regards JG -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

1 0

http://winehq.org/ - W3C validation problem at present
by J. Grant 19 Sep '04

19 Sep '04

[resent following direction from Ivan] Hello, There is a problem on this page at present: http://validator.w3.org/ 1. Line 317, column 12: an attribute value must be a literal unless it contains only name characters <a href=?issue=239>WWN Issue 239</a> was released today. You have used a character that is not considered a "name character" in an attribute value. Which characters are considered "name characters" varies between the different document types, but a good rule of thumb is that unless the value contains only lower or upper case letters in the range a-z you must put quotation marks around the value. In fact, unless you have extreme file size requirements it is a very very good idea to always put quote marks around your attribute values. It is never wrong to do so, and very often it is absolutely necessary. Kind regards JG -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

1 0

Latest CVS alsa problem
by J. Grant 19 Sep '04

19 Sep '04

Greetings, I am trying to build the latest CVS. My last build was from last year, I want to check if something works with a newer build. Unfortunately, the latest WINE cvs does not work with alsa shipped with mdk 9.0: libalsa2-0.9.0-0.8rc2mdk alsamixergui-0.9.0-0.5rc1_2mdk libalsa2-devel-0.9.0-0.8rc2mdk Is there any way I can ./configure --disable-alsa ? configure does not complain when I pass it --disable-alsa, however it is still broken whey I try and build. I wonder if there is OSS support in WINE? Should the ./configure script not have noticed that alsa was not working? It configured it all ok. This is the error log (below) if someone is interested. I am not on this list, so please include my email address in any replies. Kind regards JG ================================================================== gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o vwin32.vxd.dbg.o vwin32.vxd.dbg.c ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./vwin32.vxd.spec vwin32.o vwin32.vxd.dbg.o -o vwin32.vxd.so -L../../dlls -lwinedos -lkernel32 -L../../libs/wine -lwine -L../../libs/port -lwine_port make[2]: Leaving directory `/home/now3d/wine/wine/dlls/vwin32.vxd' rm -f vwin32.vxd.so && ln -s vwin32.vxd/vwin32.vxd.so vwin32.vxd.so make[2]: Entering directory `/home/now3d/wine/wine/dlls/winmm/winealsa' gcc -c -I. -I. -I../../../include -I../../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o audio.o audio.c audio.c: In function `ALSA_TraceParameters': audio.c:514: too many arguments to function `snd_pcm_hw_params_get_access' audio.c:515: too many arguments to function `snd_pcm_hw_params_get_format' audio.c:564: too many arguments to function `snd_pcm_hw_params_get_channels' audio.c:568: too many arguments to function `snd_pcm_hw_params_get_channels_min' audio.c:569: too many arguments to function `snd_pcm_hw_params_get_channels_max' audio.c:578: too many arguments to function `snd_pcm_hw_params_get_buffer_size' audio.c:582: too many arguments to function `snd_pcm_hw_params_get_buffer_size_min' audio.c:583: too many arguments to function `snd_pcm_hw_params_get_buffer_size_max' audio.c:605: too many arguments to function `snd_pcm_hw_params_get_rate' audio.c:605: too many arguments to function `snd_pcm_hw_params_get_rate_min' audio.c:605: too many arguments to function `snd_pcm_hw_params_get_rate_max' audio.c:606: too many arguments to function `snd_pcm_hw_params_get_buffer_time' audio.c:606: too many arguments to function `snd_pcm_hw_params_get_buffer_time_min' audio.c:606: too many arguments to function `snd_pcm_hw_params_get_buffer_time_max' audio.c:607: too many arguments to function `snd_pcm_hw_params_get_periods' audio.c:607: too many arguments to function `snd_pcm_hw_params_get_periods_min' audio.c:607: too many arguments to function `snd_pcm_hw_params_get_periods_max' audio.c:612: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:612: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c:616: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size_min' from incompatible pointer type audio.c:616: too many arguments to function `snd_pcm_hw_params_get_period_size_min' audio.c:617: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size_max' from incompatible pointer type audio.c:617: too many arguments to function `snd_pcm_hw_params_get_period_size_max' audio.c:624: too many arguments to function `snd_pcm_hw_params_get_period_time' audio.c:624: too many arguments to function `snd_pcm_hw_params_get_period_time_min' audio.c:624: too many arguments to function `snd_pcm_hw_params_get_period_time_max' audio.c:625: too many arguments to function `snd_pcm_hw_params_get_tick_time' audio.c:625: too many arguments to function `snd_pcm_hw_params_get_tick_time_min' audio.c:625: too many arguments to function `snd_pcm_hw_params_get_tick_time_max' audio.c: In function `ALSA_WaveInit': audio.c:744: too many arguments to function `snd_pcm_hw_params_get_rate_min' audio.c:745: too many arguments to function `snd_pcm_hw_params_get_rate_max' audio.c:746: too many arguments to function `snd_pcm_hw_params_get_channels_min' audio.c:747: too many arguments to function `snd_pcm_hw_params_get_channels_max' audio.c:851: too many arguments to function `snd_pcm_hw_params_get_rate_min' audio.c:852: too many arguments to function `snd_pcm_hw_params_get_rate_max' audio.c:853: too many arguments to function `snd_pcm_hw_params_get_channels_min' audio.c:854: too many arguments to function `snd_pcm_hw_params_get_channels_max' audio.c: In function `wodPlayer_DSPWait': audio.c:1200: too many arguments to function `snd_pcm_hw_params_get_period_time' audio.c: In function `wodOpen': audio.c:1717: warning: passing arg 3 of `snd_pcm_hw_params_set_rate_near' makes integer from pointer without a cast audio.c:1729: warning: passing arg 3 of `snd_pcm_hw_params_set_buffer_time_near' makes integer from pointer without a cast audio.c:1731: warning: passing arg 3 of `snd_pcm_hw_params_set_period_time_near' makes integer from pointer without a cast audio.c:1735: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:1735: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c:1736: too many arguments to function `snd_pcm_hw_params_get_buffer_size' audio.c: In function `DSDB_MMAPCopy': audio.c:2248: too many arguments to function `snd_pcm_hw_params_get_channels' audio.c:2249: too many arguments to function `snd_pcm_hw_params_get_format' audio.c:2251: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:2251: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c: In function `DSDB_CreateMMAP': audio.c:2302: too many arguments to function `snd_pcm_hw_params_get_format' audio.c:2303: too many arguments to function `snd_pcm_hw_params_get_buffer_size' audio.c:2304: too many arguments to function `snd_pcm_hw_params_get_channels' audio.c: In function `IDsDriverBufferImpl_GetPosition': audio.c:2459: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:2459: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c: In function `widOpen': audio.c:3205: warning: passing arg 3 of `snd_pcm_hw_params_set_rate_near' makes integer from pointer without a cast audio.c:3218: warning: passing arg 3 of `snd_pcm_hw_params_set_buffer_time_near' makes integer from pointer without a cast audio.c:3220: warning: passing arg 3 of `snd_pcm_hw_params_set_period_time_near' makes integer from pointer without a cast audio.c:3225: warning: passing arg 2 of `snd_pcm_hw_params_get_period_size' from incompatible pointer type audio.c:3225: too many arguments to function `snd_pcm_hw_params_get_period_size' audio.c:3226: too many arguments to function `snd_pcm_hw_params_get_buffer_size' make[2]: *** [audio.o] Error 1 make[2]: Leaving directory `/home/now3d/wine/wine/dlls/winmm/winealsa' make[1]: *** [winmm/winealsa] Error 2 make[1]: Leaving directory `/home/now3d/wine/wine/dlls' make: *** [dlls] Error 2 -- Homepage: http://jguk.org/ Blog: http://jguk.org/index.html#blog Radio: http://jguk.org/index.html#radio

1 0

Re: CreateDIBitmap fix
by Stefan Leichter 19 Sep '04

19 Sep '04

Am Montag, 13. September 2004 13:12 schrieb Huw D M Davies: > Michael Kaufmann <hallo(a)michael-kaufmann.ch> > Huw Davies <huw(a)codeweavers.com> > CreateDIBitmap should return bitmaps at the depth of the > supplied dc. > Add a test to exercise this behaviour. Hello, this patch broke my Freecell (the version shiped with the win32s extension). When starting the game i am get now these fixme's: fixme:bitmap:CreateCompatibleBitmap got bad width 6291527 or height 65537, please look for reason Grepping the logfile i found the values first in a call of CreateBitmap, but i have no idea where the values are created. I noticed that the lower word of the width is correct. Does anyone have a clue how to debug / fix this ? Bye Stefan

3 3

Re: MSCMS: new dll
by Dmitry Timoshkov 19 Sep '04

19 Sep '04

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > Here's the beginnings of an MSCMS.DLL (color management) on top of the > LittleCMS library. I had to resort to some rather ugly preprocessor > trickery to be able to include lcms.h, since it happens to define basic > Windows types when not compiled on Windows ;-(. Then perhaps it's better to make lcms.h think that it's used in a Windows environment (define WIN32 or whatever it wants to see before inclusion). That will help to completely avoid all the ugliness with redefined stuff. > +HPROFILE WINAPI OpenColorProfileA( PPROFILE profile, DWORD access, DWORD sharing, DWORD creation ) > +{ > + TRACE("stub ( %p, %lx, %lx, %lx )\n", profile, access, sharing, creation ); > + > + return NULL; > +} > + > +HPROFILE WINAPI OpenColorProfileW( PPROFILE profile, DWORD access, DWORD sharing, DWORD creation ) > +{ > + TRACE("stub ( %p, %lx, %lx, %lx )\n", profile, access, sharing, creation ); > + > + return NULL; > +} > + > +BOOL WINAPI CloseColorProfile( HPROFILE profile ) > +{ > + TRACE("stub ( %p )\n", profile ); > + > + return FALSE; > +} You have to use FIXMEs not TRACEs above to clearly indicate the status of the APIs. -- Dmitry.

3 3

Scrollbars and scrollwheel: -fomit-frame-pointer problems
by Diego 'Flameeyes' Pettenò 18 Sep '04

18 Sep '04

Hi, Seems like I found out which flags causes trouble with the scrollbars and the mouse's scrollwheel: building wine without -fomit-frame-pointer flag makes it work right. This fixes my problem ( http://article.gmane.org/gmane.comp.emulators.wine.devel/23780 ) and seems to fix (at least for me) the problem reported by Nguyen Tuan Anh ( http://article.gmane.org/gmane.comp.emulators.wine.user/7169 ). I actually don't know how to filter with autoconf and stuff the specified flag, I only know with gentoo's portage, but I hope there's a way to make this flag doesn't go to the gcc parameters. Regards, -- Diego "Flameeyes" Pettenò dgp85(a)users.sourceforge.net - http://flameeyes.web.ctonet.it/

6 10

Re: Added service database names
by Dmitry Timoshkov 18 Sep '04

18 Sep '04

"Alexander Yaworsky" <yaworsky(a)migusoft.ru> wrote: > +#ifdef UNICODE > +# define SERVICES_ACTIVE_DATABASE SERVICES_ACTIVE_DATABASEW > +#else > +# define SERVICES_ACTIVE_DATABASE SERVICES_ACTIVE_DATABASEA > +#endif Wine uses WINELIB_NAME_AW macro in order to simplify '#ifdef UNICODE' magic, so in the above case it would look like this: #define SERVICES_ACTIVE_DATABASE WINELIB_NAME_AW(SERVICES_ACTIVE_DATABASE) -- Dmitry.

2 1

Terminal Font
by pcunite＠fsmail.net 18 Sep '04

18 Sep '04

I have a windows app that works really well under wine. I have placed the fonts from my XP workstation to my Fedora 2 wine directory in "./wine/windows/fonts/" so that I could have more fonts available to the app. My problem is that the "Terminal" font is not showing up when using a windows API "Font Dialog". Where can I get this "Terminal dos/oem" font? Thank you Jason -- Whatever you Wanadoo: http://www.wanadoo.co.uk/time/ This email has been checked for most known viruses - find out more at: http://www.wanadoo.co.uk/help/id/7098.htm

2 1

Help with GetConsoleWindow()
by Ewert, Mark 18 Sep '04

18 Sep '04

I'm running an application that calls the stubbed out function GetConsoleWindow(). I want the application to stay in the dos console when it runs but unfortunately when it sees a NULL from GetConsoleWindow() it loads a graphical window. I tried hacking the function to return the value 1 and this gave me the result I had hoped where it did not call up a graphical window but at a later point I get the error: wine: Unhandled exception (thread 000d), starting debugger... Any ideas on what GetConsoleWindow() should actually return? Cheers, Mark

3 2

Wine-20040918 preblems in
by Green, Shaun E. 18 Sep '04

18 Sep '04

Wine does not function correctly under Yoper Linux with kernel 2.6.8.1-7 (this kernel has performance patches applied). It seems to build fine, but it does not run correctly and running MFC apps do not even open. I tried changing the /tmp link in dosdevices directory, etc but to no avail. I've tried previous Wine versions and stable May release, but same results. Codeweavers crossover office works, but it's too slow for my purposes. I've used Wine-20040818 successfully since it's release on Yoper Linux with kernel 2.4.26 vanilla, so that's why I'm betting it's a kernel 2.6.8.1 issue. Can anyone help? Shaun

2 1

Re: dinput header fixes
by Alexandre Julliard 18 Sep '04

18 Sep '04

Robert Reif <reif(a)earthlink.net> writes: > Add some more version checks. As a rule we avoid such version checks in Wine, they are not necessary and will only cause trouble since we compile our code with the same headers. I know there are some similar checks in there already but they should probably be removed. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: buffer: ref count cleanup
by Robert Reif 18 Sep '04

18 Sep '04

James Hawkins wrote: >Changelog > * Use InterlockedDecrement and InterlockedIncrement instead of ++/--. > > > That ref doesn't belong to a com object. I belongs to a duplicated memory buffer and should probably be protected by a lock someday.

1 0

[OT] AMD64 Implications
by Ann and Jason Edmeades 17 Sep '04

17 Sep '04

Hello, Slightly off topic, but I am looking at purchasing a new PC and intend to continue doing wine development on it (especially d3d9). Is there any wine implications to buying an AMD64 compared to a 'normal' 32 bit chip. Will I be able to continue my wine development, obviously for running emulation of 32 bit windows apps (games)? Would I need to ensure I use 32 bit kernels, or can I make use of any 64 bit ones (dont know if these exist even!). Sorry if this is an obvious question, but I didnt want to go so far and find I have caused myself problems Jason

2 1

Re: fonts: wine_marlett
by Ivan Leo Puoti 17 Sep '04

17 Sep '04

> That works but then we're maintaining two codepaths, one or other of > which will hardly be tested at all. Why not just check in the font > binaries? What is required to build the fonts? Should I install fontforge? I've been in hospital with appendicitis and haven't followed wine development recently. Ivan.

1 0

Re: olefont: ref count cleanup
by Robert Shearman 17 Sep '04

17 Sep '04

James Hawkins wrote: >Changelog > * Use InterlockedDecrement and InterlockedIncrement instead of ++/--. > > Again, all of these patches do not fix the whole point about using the Interlocked* functions, which is that the variable must always be used *atomically*. That means if you grep the file for uses of "This->ref" (or the equivalent) then they should all only be as parameters to Interlocked* functions. Rob

2 2

Re: InternetSetStatusCallback Fix (resend)
by Alexandre Julliard 17 Sep '04

17 Sep '04

Robert Shearman <rob(a)codeweavers.com> writes: > Any reason this patch wasn't applied? Yes, it doesn't apply. Could you please resend an updated patch? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: olepicture: ref count cleanup
by Alexandre Julliard 17 Sep '04

17 Sep '04

James Hawkins <truiken(a)gmail.com> writes: > Changelog > * Use InterlockedDecrement and InterlockedIncrement instead of ++/--. When making these changes please fix the rest of the function too, any place that uses This->ref directly is broken, it should use the return value of the Interlocked call instead. Otherwise there's no point in making the changes since it still won't be thread-safe. -- Alexandre Julliard julliard(a)winehq.org

1 0

autoconf issues on HP-UX
by Warren_Baird＠cimmetry.com 17 Sep '04

17 Sep '04

Hi all, I'm in the process of trying to get winelib working on an HP-UX / PA-RISC machine. The first issue I've come across is related to autoconf, and I'm afraid I'm far from an autoconf guru, so I wanted to post my proposed solution here before submitting a patch. The problem is that the current autoconf tests done to determine how to link a shared library aren't very good - they use WINE_TRY_CFLAGS, which builds a c file containing something like "void main() { } " and tries to link it. The problem is that this isn't a very good test about whether you can link a *shared library* - since you've got a main line defined. Unfortunately the gnu ld doesn't work on hpux, so I have to use the system linker, and the UnixWare link test succeed when it should fail - since the HPUX linker doesn't understand the arguments it is given, it goes on to link an executable and generates a warning about not being able to hide symbol "conftest.so.1.0". I believe that a better test is to try to link a shared lib from a C file containing "void myfunc() {}" - this way if the provided arguments don't convince the linker to create a shared lib, you'll get a error about "main" being undefined. My proposed solution is to define a new function "WINE_TRY_SHLIB" that does what I describe above, and then use it in the 3 existing places we're checking for shared libs, and add a new test specifically for hpux. I've attached my proposed patch file (although I'm still trying to sort out exactly what flags I need for hpux libs)... Does this seem reasonable? thanks, Warren (See attached file: patch.txt)

2 1

Re: fonts: wine_marlett
by Robert Shearman 17 Sep '04

17 Sep '04

Huw D M Davies wrote: > TransGaming > Add a Marlett replacement font > > Cool! Is there any policy for using it? E.g. a lot of the arrows and stuff in the native comctl32 are drawn using this font, so would we now be able to do this with our version of the common controls? Rob

5 5

Re: [DPNET] Cleanup/Correct
by Alexandre Julliard 17 Sep '04

17 Sep '04

Raphael <fenix(a)club-internet.fr> writes: > I'm back (after a long time without coding) and seems that many directx dlls > are brokens after COM "migrations" No, the dlls are fine, probably your tree has not been updated properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ADVAPI32: SHA functions
by Filip Navara 17 Sep '04

17 Sep '04

Filip Navara wrote: > Changelog: > Implement A_SHA* functions present in Windows XP and later systems. Now with a correct diff... Index: dlls/advapi32/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/advapi32/Makefile.in,v retrieving revision 1.19 diff -u -r1.19 Makefile.in --- dlls/advapi32/Makefile.in 11 Oct 2003 01:09:21 -0000 1.19 +++ dlls/advapi32/Makefile.in 16 Sep 2004 20:42:22 -0000 @@ -10,6 +10,7 @@ C_SRCS = \ advapi.c \ crypt.c \ + crypt_sha.c \ eventlog.c \ registry.c \ security.c \ Index: dlls/advapi32/advapi32.spec =================================================================== RCS file: /home/wine/wine/dlls/advapi32/advapi32.spec,v retrieving revision 1.56 diff -u -r1.56 advapi32.spec --- dlls/advapi32/advapi32.spec 16 Sep 2004 19:09:13 -0000 1.56 +++ dlls/advapi32/advapi32.spec 16 Sep 2004 20:42:07 -0000 @@ -1,6 +1,6 @@ -@ stub A_SHAFinal -@ stub A_SHAInit -@ stub A_SHAUpdate +@ stdcall A_SHAFinal(ptr str) +@ stdcall A_SHAInit(ptr) +@ stdcall A_SHAUpdate(ptr str long) @ stdcall AbortSystemShutdownA(ptr) @ stdcall AbortSystemShutdownW(ptr) @ stdcall AccessCheck(ptr long long ptr ptr ptr ptr ptr) Index: dlls/advapi32/tests/Makefile.in =================================================================== RCS file: /home/wine/wine/dlls/advapi32/tests/Makefile.in,v retrieving revision 1.4 diff -u -r1.4 Makefile.in --- dlls/advapi32/tests/Makefile.in 9 Aug 2004 18:47:22 -0000 1.4 +++ dlls/advapi32/tests/Makefile.in 17 Sep 2004 14:18:58 -0000 @@ -7,6 +7,7 @@ CTESTS = \ crypt.c \ + crypt_sha.c \ registry.c \ security.c --- /dev/null Fri Sep 17 17:41:26 2004 +++ dlls/advapi32/crypt_sha.c Thu Sep 16 22:34:13 2004 @@ -0,0 +1,188 @@ +/* + * Copyright 2004 Filip Navara + * Based on public domain SHA code by Steve Reid <steve(a)edmweb.com> + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <stdarg.h> +#include "windef.h" +#include "winbase.h" + +/* SHA Context Structure Declaration */ + +typedef struct { + ULONG Unknown[6]; + ULONG State[5]; + ULONG Count[2]; + UCHAR Buffer[64]; +} SHA_CTX, *PSHA_CTX; + +/* SHA1 Helper Macros */ + +#define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits)))) +/* FIXME: This definition of DWORD2BE is little endian specific! */ +#define DWORD2BE(x) (((x) >> 24) & 0xff) | (((x) >> 8) & 0xff00) | (((x) << 8) & 0xff0000) | (((x) << 24) & 0xff000000); +/* FIXME: This definition of blk0 is little endian specific! */ +#define blk0(i) (Block[i] = (rol(Block[i],24)&0xFF00FF00)|(rol(Block[i],8)&0x00FF00FF)) +#define blk1(i) (Block[i&15] = rol(Block[(i+13)&15]^Block[(i+8)&15]^Block[(i+2)&15]^Block[i&15],1)) +#define f1(x,y,z) (z^(x&(y^z))) +#define f2(x,y,z) (x^y^z) +#define f3(x,y,z) ((x&y)|(z&(x|y))) +#define f4(x,y,z) (x^y^z) +/* (R0+R1), R2, R3, R4 are the different operations used in SHA1 */ +#define R0(v,w,x,y,z,i) z+=f1(w,x,y)+blk0(i)+0x5A827999+rol(v,5);w=rol(w,30); +#define R1(v,w,x,y,z,i) z+=f1(w,x,y)+blk1(i)+0x5A827999+rol(v,5);w=rol(w,30); +#define R2(v,w,x,y,z,i) z+=f2(w,x,y)+blk1(i)+0x6ED9EBA1+rol(v,5);w=rol(w,30); +#define R3(v,w,x,y,z,i) z+=f3(w,x,y)+blk1(i)+0x8F1BBCDC+rol(v,5);w=rol(w,30); +#define R4(v,w,x,y,z,i) z+=f4(w,x,y)+blk1(i)+0xCA62C1D6+rol(v,5);w=rol(w,30); + +/* Hash a single 512-bit block. This is the core of the algorithm. */ +void SHA1Transform(ULONG State[5], CHAR Buffer[64]) +{ + ULONG a, b, c, d, e; + ULONG *Block; + + Block = (ULONG*)Buffer; + + /* Copy Context->State[] to working variables */ + a = State[0]; + b = State[1]; + c = State[2]; + d = State[3]; + e = State[4]; + + /* 4 rounds of 20 operations each. Loop unrolled. */ + R0(a,b,c,d,e, 0); R0(e,a,b,c,d, 1); R0(d,e,a,b,c, 2); R0(c,d,e,a,b, 3); + R0(b,c,d,e,a, 4); R0(a,b,c,d,e, 5); R0(e,a,b,c,d, 6); R0(d,e,a,b,c, 7); + R0(c,d,e,a,b, 8); R0(b,c,d,e,a, 9); R0(a,b,c,d,e,10); R0(e,a,b,c,d,11); + R0(d,e,a,b,c,12); R0(c,d,e,a,b,13); R0(b,c,d,e,a,14); R0(a,b,c,d,e,15); + R1(e,a,b,c,d,16); R1(d,e,a,b,c,17); R1(c,d,e,a,b,18); R1(b,c,d,e,a,19); + R2(a,b,c,d,e,20); R2(e,a,b,c,d,21); R2(d,e,a,b,c,22); R2(c,d,e,a,b,23); + R2(b,c,d,e,a,24); R2(a,b,c,d,e,25); R2(e,a,b,c,d,26); R2(d,e,a,b,c,27); + R2(c,d,e,a,b,28); R2(b,c,d,e,a,29); R2(a,b,c,d,e,30); R2(e,a,b,c,d,31); + R2(d,e,a,b,c,32); R2(c,d,e,a,b,33); R2(b,c,d,e,a,34); R2(a,b,c,d,e,35); + R2(e,a,b,c,d,36); R2(d,e,a,b,c,37); R2(c,d,e,a,b,38); R2(b,c,d,e,a,39); + R3(a,b,c,d,e,40); R3(e,a,b,c,d,41); R3(d,e,a,b,c,42); R3(c,d,e,a,b,43); + R3(b,c,d,e,a,44); R3(a,b,c,d,e,45); R3(e,a,b,c,d,46); R3(d,e,a,b,c,47); + R3(c,d,e,a,b,48); R3(b,c,d,e,a,49); R3(a,b,c,d,e,50); R3(e,a,b,c,d,51); + R3(d,e,a,b,c,52); R3(c,d,e,a,b,53); R3(b,c,d,e,a,54); R3(a,b,c,d,e,55); + R3(e,a,b,c,d,56); R3(d,e,a,b,c,57); R3(c,d,e,a,b,58); R3(b,c,d,e,a,59); + R4(a,b,c,d,e,60); R4(e,a,b,c,d,61); R4(d,e,a,b,c,62); R4(c,d,e,a,b,63); + R4(b,c,d,e,a,64); R4(a,b,c,d,e,65); R4(e,a,b,c,d,66); R4(d,e,a,b,c,67); + R4(c,d,e,a,b,68); R4(b,c,d,e,a,69); R4(a,b,c,d,e,70); R4(e,a,b,c,d,71); + R4(d,e,a,b,c,72); R4(c,d,e,a,b,73); R4(b,c,d,e,a,74); R4(a,b,c,d,e,75); + R4(e,a,b,c,d,76); R4(d,e,a,b,c,77); R4(c,d,e,a,b,78); R4(b,c,d,e,a,79); + + /* Add the working variables back into Context->State[] */ + State[0] += a; + State[1] += b; + State[2] += c; + State[3] += d; + State[4] += e; + + /* Wipe variables */ + a = b = c = d = e = 0; +} + + +/****************************************************************************** + * A_SHAInit [ADVAPI32.@] + * + * Initialize a SHA context structure. + */ +VOID WINAPI +A_SHAInit(PSHA_CTX Context) +{ + /* SHA1 initialization constants */ + Context->State[0] = 0x67452301; + Context->State[1] = 0xEFCDAB89; + Context->State[2] = 0x98BADCFE; + Context->State[3] = 0x10325476; + Context->State[4] = 0xC3D2E1F0; + Context->Count[0] = + Context->Count[1] = 0; +} + +/****************************************************************************** + * A_SHAUpdate [ADVAPI32.@] + * + * Update a SHA context with a hashed data from supplied buffer. + */ +VOID WINAPI +A_SHAUpdate(PSHA_CTX Context, PCHAR Buffer, UINT BufferSize) +{ + ULONG BufferContentSize; + + BufferContentSize = Context->Count[1] & 63; + Context->Count[1] += BufferSize; + if (Context->Count[1] < BufferSize) + Context->Count[0]++; + Context->Count[0] += (BufferSize >> 29); + + if (BufferContentSize + BufferSize < 64) + { + RtlCopyMemory(&Context->Buffer[BufferContentSize], Buffer, + BufferSize); + } + else + { + while (BufferContentSize + BufferSize >= 64) + { + RtlCopyMemory(Context->Buffer + BufferContentSize, Buffer, + 64 - BufferContentSize); + Buffer += 64 - BufferContentSize; + BufferSize -= 64 - BufferContentSize; + SHA1Transform(Context->State, Context->Buffer); + BufferContentSize = 0; + } + RtlCopyMemory(Context->Buffer + BufferContentSize, Buffer, BufferSize); + } +} + +/****************************************************************************** + * A_SHAUpdate [ADVAPI32.@] + * + * Finalize SHA context and return the resulting hash. + */ +VOID WINAPI +A_SHAFinal(PSHA_CTX Context, PULONG Result) +{ + INT Pad, Index; + UCHAR Buffer[72]; + ULONG *Count; + ULONG BufferContentSize, LengthHi, LengthLo; + + BufferContentSize = Context->Count[1] & 63; + if (BufferContentSize >= 56) + Pad = 56 + 64 - BufferContentSize; + else + Pad = 56 - BufferContentSize; + + LengthHi = (Context->Count[0] << 3) | (Context->Count[1] >> (32 - 3)); + LengthLo = (Context->Count[1] << 3); + + RtlZeroMemory(Buffer + 1, Pad - 1); + Buffer[0] = 0x80; + Count = (ULONG*)(Buffer + Pad); + Count[0] = DWORD2BE(LengthHi); + Count[1] = DWORD2BE(LengthLo); + A_SHAUpdate(Context, Buffer, Pad + 8); + + for (Index = 0; Index < 5; Index++) + Result[Index] = DWORD2BE(Context->State[Index]); + + A_SHAInit(Context); +} --- /dev/null Fri Sep 17 17:41:59 2004 +++ dlls/advapi32/tests/crypt_sha.c Fri Sep 17 16:20:32 2004 @@ -0,0 +1,85 @@ +/* + * Unit tests for SHA functions + * + * Copyright (c) 2004 Filip Navara + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#include <stdio.h> + +#include "wine/test.h" +#include "windef.h" +#include "winbase.h" +#include "winerror.h" + +typedef struct { + ULONG Unknown[6]; + ULONG State[5]; + ULONG Count[2]; + UCHAR Buffer[64]; +} SHA_CTX, *PSHA_CTX; + +typedef VOID (WINAPI *fnA_SHAInit)(PSHA_CTX Context); +typedef VOID (WINAPI *fnA_SHAUpdate)(PSHA_CTX Context, PCHAR Buffer, UINT BufferSize); +typedef VOID (WINAPI *fnA_SHAFinal)(PSHA_CTX Context, PULONG Result); + +fnA_SHAInit pA_SHAInit; +fnA_SHAUpdate pA_SHAUpdate; +fnA_SHAFinal pA_SHAFinal; + +#define ctxcmp(a,b) memcmp((char*)a, (char*)b, FIELD_OFFSET(SHA_CTX, Buffer)) + +void test_sha_ctx() +{ + PCHAR test_buffer = "In our Life there's If" + "In our beliefs there's Lie" + "In our business there is Sin" + "In our bodies, there is Die"; + ULONG test_buffer_size = strlen(test_buffer); + HMODULE hmod; + SHA_CTX ctx; + SHA_CTX ctx_initialized = {{0, 0, 0, 0, 0}, {0x67452301, 0xefcdab89, 0x98badcfe, 0x10325476, 0xc3d2e1f0}, {0, 0}}; + SHA_CTX ctx_update1 = {{0, 0, 0, 0, 0}, {0xdbe5eba8, 0x6b4335ca, 0xf7c94abe, 0xc9f34e31, 0x311023f0}, {0, 0x67}}; + SHA_CTX ctx_update2 = {{0, 0, 0, 0, 0}, {0x5ecc818d, 0x52498169, 0xf6758559, 0xd035a164, 0x871dd125}, {0, 0xce}}; + ULONG result[5]; + ULONG result_correct[5] = {0xe014f93, 0xe09791ec, 0x6dcf96c8, 0x8e9385fc, 0x1611c1bb}; + + hmod = LoadLibrary("advapi32.dll"); + pA_SHAInit = (fnA_SHAInit)GetProcAddress(hmod, "A_SHAInit"); + pA_SHAUpdate = (fnA_SHAUpdate)GetProcAddress(hmod, "A_SHAUpdate"); + pA_SHAFinal = (fnA_SHAFinal)GetProcAddress(hmod, "A_SHAFinal"); + + RtlZeroMemory(&ctx, sizeof(ctx)); + pA_SHAInit(&ctx); + ok(!ctxcmp(&ctx, &ctx_initialized), "invalid initialization\n"); + + pA_SHAUpdate(&ctx, test_buffer, test_buffer_size); + ok(!ctxcmp(&ctx, &ctx_update1), "update doesn't work correctly\n"); + + pA_SHAUpdate(&ctx, test_buffer, test_buffer_size); + ok(!ctxcmp(&ctx, &ctx_update2), "update doesn't work correctly\n"); + + pA_SHAFinal(&ctx, result); + ok(!ctxcmp(&ctx, &ctx_initialized), "context hasn't been reinitialized\n"); + ok(!memcmp(result, result_correct, sizeof(result)), "incorrect result\n"); + + FreeLibrary(hmod); +} + +START_TEST(crypt_sha) +{ + test_sha_ctx(); +}

1 0

Re: ADVAPI32: SHA functions
by Dmitry Timoshkov 17 Sep '04

17 Sep '04

"Filip Navara" <xnavara(a)volny.cz> wrote: > --- /dev/null Fri Sep 17 17:41:26 2004 > +++ dlls/advapi32/crypt_sha.c Thu Sep 16 22:34:13 2004 This is the first crypt_sha.c, with an API implementation. > --- /dev/null Fri Sep 17 17:41:59 2004 > +++ dlls/advapi32/crypt_sha.c Fri Sep 17 16:20:32 2004 This is the second crypt_sha.c, with an API test. It seems that this crypt_sha.c was supposed to go in the tests subdirectory. -- Dmitry.

1 0

Re: Lostwages add seti@home link
by hatky 17 Sep '04

17 Sep '04

May I ask in what way does a person running seti@home helps wine? Not that I am against the project but you make it sound as a needed contribution to wine, well I don't see it helping wine too much except some extra attention from random sources, and it isn't even open source, mybe some other place? Resources -> others ? I would say links -> others but we don't have that :) And another thing please update the seti@home group home page to winehq.org from the winehq.com it has, thanks. On Friday 17 September 2004 02:17, Ivan Leo Puoti wrote: > Add a link to our seti@home team in the contirbuting page. > > Ivan. -- Hatky, Worshiper of wine (http://www.winehq.org/), Impossible is only an opinion.

1 0

Re: Cryptographic functions
by Juan Lang 16 Sep '04

16 Sep '04

Patching advapi32.spec to add the stubs looks correct. Go ahead and submit to wine-patches. --Juan _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

4 6

Re: winedos:MCB implementation
by Alexandre Julliard 16 Sep '04

16 Sep '04

Markus Amsler <markus.amsler(a)oribi.org> writes: > Please let me know, if there's something wrong with the patch (design > problems, naming conventions, formating, ...). The main problem is that you now have both the MCB and the DOSMEM code trying to allocate memory in the same area, that won't work. What you probably want is to make the DOSMEM functions call out to the MCB ones. -- Alexandre Julliard julliard(a)winehq.org

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel