- wine-devel - winehq.org

winrash: some todos
by Sylvain Petreolle 01 Aug '04

01 Aug '04

Some suggestions for winrash: * Running Windows NT version >= 4.XY, we should check for the use of an administrator account... installing as normal user gave these results : no error message said the HKLM keys couldnt be created => UserID & mail not set => service install/run fails silently * http links : the 3 http links fail to open at the end of installation, this has already been reported on wine-users list. (the mouse arrow changes though) ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) Say NO to software patents Dites NON aux brevets logiciels "You believe it's the year 1984, when in fact, its closer to 2184"1984 / Matrix Vous manquez despace pour stocker vos mails ? Yahoo! Mail vous offre GRATUITEMENT 100 Mo ! Créez votre Yahoo! Mail sur http://fr.benefits.yahoo.com/ Le nouveau Yahoo! Messenger est arrivé ! Découvrez toutes les nouveautés pour dialoguer instantanément avec vos amis. A télécharger gratuitement sur http://fr.messenger.yahoo.com

1 0

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov 01 Aug '04

01 Aug '04

"James Hawkins" <truiken(a)gmail.com> wrote: > Fixed even more bugs spotted by Dmitry. > > Changelog > * cleanup cross-call functions The quality of the patch still is not good enough. -- Dmitry.

2 2

Re: cleanup a->w cross calls in commdlg/fontdlg.c
by Dmitry Timoshkov 01 Aug '04

01 Aug '04

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * fix cross-call functions > - return DialogBoxIndirectParamA(COMDLG32_hInstance, template, > + return DialogBoxIndirectParamW(COMDLG32_hInstance, template, > lpChFont->hwndOwner, FormatCharDlgProcA, (LPARAM)lpChFont ); You can't pass a not unicode dlgproc to DialogBoxIndirectParamW and hope that it will work. -- Dmitry.

1 0

Re: Question about mmap issues on FreeBSD/NetBSD
by Yorick Hardy 01 Aug '04

01 Aug '04

Try the patch below, I am not yet sure why this would be necessary. Perhaps it helps. >I've got some cross platform issues i cannot resolve. There are some >obvious issues like the assumption that round() is in the math library >and not linking in the math library itself. i've worked passed those. >Currently, I'm working with a patched version of the latest cvs source >on Solaris 9x86. After applying Robert Lunnon's patch kit to the latest >cvs course and substituting rint for the round function in >wine/dlls/dsound/mixer.c and add the math library to EXTRALIBS, I got a >clean compile. however running the wine binary results in the following: > >try_mmap_fixed: vfork: Resource temporarily unavailable > >I'm not intimately familiar with how wine manages it's memory so I >hesitate to guess what is going on. I've attached the output of the >truss if anyone has any ideas on what it going on or how to fix it >please let me know. Kind regards, -- Yorick Hardy --- libs/wine/mmap.c.orig Thu Jul 29 20:03:03 2004 +++ libs/wine/mmap.c Sun Aug 1 13:07:07 2004 @@ -135,6 +135,8 @@ has exited. Furthermore, Wine sets SIGCHLD to SIG_IGN, so we don't need to wait for the child. */ + waitpid(pid, &pagesize, 0); + return result == addr; } #endif /* (__svr4__ || __NetBSD__) && !MAP_TRYFIXED */

1 0

Re: [RESENT] Make wine work with freedesktop.org MIME system
by Mike Hearn 01 Aug '04

01 Aug '04

This was checked into CVS a few days ago, no need to resend. thanks -mike On Sun, 2004-08-01 at 11:35 +0200, Christian Neumair wrote: > Mike felt good enough to explain me on IRC where I should hook into the > wine build system. I've put up a tiny patch that works like a charm with > GNOME/shared-mime-info HEAD. It associates wine with the MIME type used > for DOS/Win32 binaries. > > regs, > Chris

1 0

Wine leaking GDI handles?
by Jon Griffiths 01 Aug '04

01 Aug '04

Hi, I am trying to track down some GDI leaks in a large application I am porting. To make things easier I added logging to GDI_AllocObject and GDI_FreeObject in order to find mismatches at program termination, and hacked a script to find allocations that weren't deallocated. The patch to dlls/gdi/gdiobj.c and the script used are both attached below. My first question is; Is this a valid approach to tracking leaks, or are some GDI objects deallocated in another way? i.e. Should there be a GDI_FreeObject call for every GDI_AllocObject call or not? I run this analysis by setting WINEDEBUG="+all" and executing my app redirecting the results to a file. I then run the matching script to generate a list of addresses from GDI_AllocObject that have no corresponding GDI_FreeObject, along with the line number in the trace that the allocation occurred. This produced a rather overwhelming list which has thus far enabled me to find several application bugs causing leaks. However investigating several of the calls makes me suspect that Wine itself may have some leaks. If you follow the directions above against Wines clock.exe it lists here 121 unmatched deallocations (winver has 126). Some of these are for things like stock objects which arguably aren't very important, since they are only created once. But it appears that window creation/destruction may have leaks which is of definite concern here since my app creates many windows while generating screens on the fly (I see in my app that when GetDC is called for the first time on a window, causing a CreateDCW call, a region is leaked, or at least thats what it looks like to me). I seems a good idea to attempt to diagnose the leaks on a simple program like clock/winver before trying a more complicated app. Could someone with more experience in GDI verify that these leaks are genuine? I am a little lost amongst the GDI/user code... Thanks, Jon p.s. The script below does not handle GDI realloc, but I have yet to see it in any of my traces yet. ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Mail is new and improved - Check it out! http://promotions.yahoo.com/new_mail

1 0

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov 01 Aug '04

01 Aug '04

"James Hawkins" <truiken(a)gmail.com> wrote: > Fixed more bugs spotted by Dmitry. > > Changelog > * cleanup cross-call functions If you could use 'static const' as everywhere else and not 'const static' that would be nice. > + size = sizeof(DWORD); > + r = RegQueryValueExW(key, nameW, NULL, &keytype, NULL, &size); Why did you add size initialization here? If that wasn't done before there was a reason for that. > + provNameLen = *pcbProvName * sizeof(WCHAR); > + if ( pszProvName && (str = CRYPT_Alloc(provNameLen * sizeof(WCHAR))) ) > + CRYPT_ReturnLastError(ERROR_NOT_ENOUGH_MEMORY); > + ret = CryptEnumProvidersW(dwIndex, pdwReserved, dwFlags, pdwProvType, str, &provNameLen); Remove double sizeof(WCHAR) multiplcation here and everywhere else. > - DWORD size = sizeof(DWORD); > + DWORD size = sizeof(pdwProvType); > HKEY subkey; > - if (RegEnumKeyA(hKey, dwIndex, pszProvName, *pcbProvName)) > + if (RegEnumKeyW(hKey, dwIndex, pszProvName, *pcbProvName)) RegEnumKeyW takes number of characters, not bytes. Why did you change that since your previous patch? Please read documentation first, otherwise you are wasting your and our time. -- Dmitry.

1 0

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov 01 Aug '04

01 Aug '04

"James Hawkins" <truiken(a)gmail.com> wrote: > Fixed bugs spotted by Dmitry > > Changelog > * cleanup cross-call functions Still there are bugs in the patch. 1. RegQueryValueExW/RegSetValueExW take bytes in the last parameter 2. Do not use 'strlen' as a name of the variable, that at least very confusing. -- Dmitry.

1 0

for whoever maintinas winrash
by Ivan Leo Puoti 01 Aug '04

01 Aug '04

We've had the following complaints on wine-users. > I installed this on a windows 98se box. I can't say I like having the DOS > window open all the time (it's ugly). Can this not be written as a windows > programme, and sit in the system tray? > > Also, during the installation process, after I entered my email address, the > installer removed what it called 'invalid characters' - i.e., underscores. >All my main email addresses contain underscores, so I was forced to enter an > old one that is not very reliable. Ivan.

4 5

Re: [Wine]starcraft fails right at the end of the install
by Michael Chang 31 Jul '04

31 Jul '04

On Sat, Jul 31, 2004 at 11:21:30AM +0000, cedric wrote: > Hi all i'm running wine 20040716, installed manualy, no wineinstall, blank > windows drive, only the right dirs are present there, as i couldn't get > regedit to make the default reg keys for me > > I tried to install starcraft, but right after it copied all the files it comes > up with this error screen: > Error: > Unable to create a link to E:\Help\Star.htm as C:\Windos\start > menu\programs\starcraft\help.lnk Installation aborted error 0: success at > LinkUndo.cpp line 165. I noticed this "error" with other programs. Apparently, wine (or at least this build) doesn't support creating links in the start menu, or something along those lines -- it makes sence when you consider that wine users shouldn't exactly see a point in "accessing" these windows shortcuts. However, your program's setup is finicky about being unable to create shortcuts for the program, so you can't continue. (Some installs complain, but allow you to continue...) Maybe wine-devel could consider creating a stub, or just falsely return true to these calls? Also, you might want to look at CVS code, to see if this has already been implemented. If all else fails, try looking at the M$ Windows binaries/patches for win95 - i.e. DCOM, and MSI stuff, etc. They *might* help, but correct me if I'm wrong. > After i click cancel all the starcraft files are deleted. After i tried again > i killed wine without pressing cancel. All the starcraft files remain, but > when i run the installer again it askes me to install the game instead of run, > so i guess not all the regestry keys have been created. Also, when i try to > run the game from the program files directory, sc complains about the cd not > being present. Setup Program probably creates shortcuts, then reg entries. But since it can't create shortcuts, it never creates the reg entries. That's my theory. (See above.) Most games are stupid in that they rely on their registry entries to tell them that the program is installed, as opposed to actually checking the filesystem. > > here are the errors wine gave me: > bash-2.05b$ cd /mnt/cdrom/ > bash-2.05b$ wine INSTALL.EXE Oh! One more thing. Your CD-Rom should be mounted to a dosdevice, and you should/can execute it from there, I think. So your first line should/might say "cd /home/<user>/.wine/dosdevices/<cd>:". (/home/cedric/.wine/dosdevices/e:) Also, note that windows never had case-sensitive names -- maybe bad program is causing errors by Linux/wine being case sensitive? > err:font:ReadFontDir Can't open directory > "/home/cedric/.wine/dosdevices/c:/windows/Fonts" > Fontconfig error: line 24: not well-formed (invalid token) > Fontconfig error: Cannot load default config file > fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy > fixme:bitblt:X11DRV_BitBlt potential optimization - client-side DIB copy > fixme:shell:Stream_WriteLocationInfo writing empty location info > err:font:ReadFontDir Can't open directory > "/home/cedric/.wine/dosdevices/c:/windows/Fonts" > Fontconfig error: line 24: not well-formed (invalid token) > Fontconfig error: Cannot load default config file > err:menubuilder:InvokeShellLinker failed to extract icon. > fixme:shell:Stream_WriteLocationInfo writing empty location info > err:font:ReadFontDir Can't open directory > "/home/cedric/.wine/dosdevices/c:/windows/Fonts" > Fontconfig error: line 24: not well-formed (invalid token) > Fontconfig error: Cannot load default config file > err:menubuilder:InvokeShellLinker failed to extract icon. > > And some random info: > bash-2.05b$ ls -l ~/.wine/dosdevices/ > total 0 > lrwxr-xr-x 1 cedric users 8 Jul 11 10:22 a:: -> /dev/fd0 > lrwxr-xr-x 1 cedric users 22 May 16 22:16 c: > -> /storage/windows-drive > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com1 -> /dev/ttyS0 > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com2 -> /dev/ttyS1 > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com3 -> /dev/ttyS2 > lrwxr-xr-x 1 cedric users 10 May 16 22:16 com4 -> /dev/modem > lrwxr-xr-x 1 cedric users 2 Jul 11 10:53 d: -> /d > lrwxr-xr-x 1 cedric users 11 Jul 11 18:25 e: -> /mnt/cdrom/ > lrwxr-xr-x 1 cedric users 12 May 16 22:16 f: -> /home/cedric > lrwxr-xr-x 1 cedric users 8 May 16 22:16 lpt1 -> /dev/lp0 > > bash-2.05b$ uname -a > Linux lfs 2.6.7 #1 Sat Jun 26 14:30:34 Local time zone must be set--see zic > manu i686 GenuineIntel unknown GNU/Linux > > bash-2.05b$ gcc -v > Reading specs from /usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.2/specs > Configured with: ../gcc-3.3.2/configure --prefix=/usr --enable-shared > --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu > --enable-languages=c,c++ : (reconfigured) ../gcc-3.3.2/configure --prefix=/usr > --enable-shared --enable-threads=posix --enable-__cxa_atexit > --enable-clocale=gnu --enable-languages=c,c+ > > Please CC me as i'm not a member of this list I hope you don't mind me putting you in the To: line instead. > > Regards, > cedric > -- > The only dumb question is the one omitted > > De enige domme vraag is degene die niet gesteld wordt > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users Just my two cents. Hope I helped in any way possible. Consider joining the wine-users/wine-devel lists, and taking part. It's a good idea, and using e-mail filtering software like POPFile is easy; even the most inexperienced users can just mention noticed behaviour in Wine. (Or, use internal filtering software in your e-mail client - 99% of wine e-mails already have [Wine] in their subject lines anyways.) Error messages are self-explainatory if you know how to read them. :) -Michael

1 0

Re: No go here (Re: [D3D] Added native and emulated S3TC support (take 2))
by Andreas Mohr 31 Jul '04

31 Jul '04

Hi, On Sat, Jul 31, 2004 at 02:32:41PM +0100, Christian Costa wrote: > Does this help? > > Changelog: > Moved libtxc_dxt definitions into ddraw headers. Yup, now it appears to compile through, thanks! Haven't tested Lionel's second patch yet, though (thanks, BTW!). Now running with Lionel patch 1 and this patch. Andreas Mohr

2 1

Re: Remove typelib ProxyStubClsid registration when no oleautomation interface is being registered
by Mike Hearn 31 Jul '04

31 Jul '04

On Sat, 31 Jul 2004 12:51:01 +0200, Jeroen Janssen wrote: > This change will make sure that if a proxy/stub dll was already registered, > it is not overwritten by the TypeLib Marshaller if we're not registering > an ole automation interface. > I think we (always?) want to use a 'real' available proxy/stub > implementation when available, instead of simply 'overruling' to the > typelib marshaller. Our current DCOM does not use RPC connection management so I'm not sure this will work. That hack is there for a reason: how many InstallShields did you verify this patch works with, and which versions were they?

1 0

Re: [Wine]Help the wine project
by Joshua Crawford 31 Jul '04

31 Jul '04

* Michael Chang <michael(a)cherryblossom.homelinux.com> [2004-07-30 13:12 -0400]: > On Fri, 30 Jul 2004 14:12:50 +1000, Joshua Crawford > <mortarn_lists(a)yahoo.com.au> wrote: > >* Ivan Leo Puoti <puoti(a)inwind.it> [2004-07-28 19:14 +0200]: > >>The wine developers have created a test sistem to check if wine works > >>like microsoft windows, but more users are needed to run the tests. > [snip] > >I installed this on a windows 98se box. I can't say I like having the DOS > >window open all the time (it's ugly). Can this not be written as a > >windows programme, and sit in the system tray? > Yes. I don't know how, but I know it's possible. You'd have to probably > find example code that allows this -- writing that kind of thing requires > knowledge of the Windows API for the systray. I think. Maybe send this > request to wine-devel? I don't know (how). One thing to point out though > - > if it ran in the system tray, then you wouldn't be able to run it within > wine. (Yes, I know that sounds stupid...) Cc: to wine-devel added. <snip console app vs. gui, and resizing window> > >Also, during the installation process, after I entered my email address, > >the installer removed what it called 'invalid characters' - i.e., > >underscores. > >All my main email addresses contain underscores, so I was forced to > >enter an old one that is not very reliable. > > How'd this happen? Underscores are very much valid characters in e-mails. > Was the installation check only accepting alpha-numeric characters as > the user part of the e-mail? Dashes should also be acceptable, in both > the username and the domain name. (Otherwise, how could we send e-mail > to the "wine-users" account of the mail server so the mailman service > could get to them?) It boggles me too. Something new: I just booted up that system for the first time since installing winrash (it's not used often), and Windows complained about it performing an illegal operation. Naturally, I tried repeating that by rebooting, and it didn't do it again. -- Joshua 'bruce' Crawford ... http://www.geocities.com/mortarn "Always be sincere, even when you don't mean it." -Irene Peter

2 1

Re: Wine isn't GUI user friendly
by Mike Hearn 31 Jul '04

31 Jul '04

Christian Neumair <chris(a)gnome-de.org> writes: > That reminds me of asking for nicer, GUI-driven error handling: > touch mustardandwiener.exe && > wine mustardandwiener.exe > returns > wine: cannot determine executable type for L"H:\\Desktop\\test.exe" > which is neither verbose enough nor user friendly, because it is simply > printed at a terminal. Modern desktop environments usually launch wine > from their file manager, i.e. without terminals. Well, as to the contents of the message itself, I don't know how it could be improved. You asked Wine to run an empty file and it said it can't figure out what kind of executable it is: why is this a problem? As to using message boxes for errors, well I have submitted patches to do this before and some were accepted, and some were not. The reasoning was that having all errors appear in message boxes would be annoying. Perhaps if there was a generic mechanism such that when a terminal was available the message was printed, and when it was not (like in a GUI) a message box was used, that would be more acceptable. I don't know how to tell if a console is available or not though. Plus to be convenient it'd need to be a new Wine API and we're trying to remove them rather than add to them :) > Can't we have popup dialogs for that kind of errors? As far as I know, > debian guys have build a shell/wrapper around wine that pops up if weird > things like these occur. Can't we have such a wrapper in stock wine? For > now, it would be enough to just catch the most common problems (binary > not found, binary can't be loaded, etc.). To be frank I still think displaying the output of stderr when a program launched from the GUI fails is the desktops job. All kinds of messages can be printed by Wine before we even have a chance to initialize the GUI subsystem - in fact the "cannot run exe" message may well be an example of that. Writing a patch to Gnome to make it do that wouldn't be hard and would solve a broad class of problems. thanks -mike

6 10

Re: No go here (Re: [D3D] Added native and emulated S3TC support (take 2))
by Andreas Mohr 31 Jul '04

31 Jul '04

Hi, On Sat, Jul 31, 2004 at 01:16:45PM +0200, Lionel Ulmer wrote: > Fixed in the attached patch... At least we know now that Alexandre finally > installed some OpenGL stuff on his development box :-) Works. :) Oh, wait... just when I *wanted* to say it works, I switched back to the console compiling Wine, and: make[2]: Entering directory `/usr/src/apps/CVS/wine/dlls/ddraw' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o main.o main.c main.c:123: error: parse error before "fetch_2d_texel_rgba_dxt1" main.c:123: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt1' main.c:123: warning: data definition has no type or storage class main.c:124: error: parse error before "fetch_2d_texel_rgba_dxt3" main.c:124: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt3' main.c:124: warning: data definition has no type or storage class main.c:123: error: parse error before "fetch_2d_texel_rgba_dxt1" main.c:123: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt1' main.c:123: warning: data definition has no type or storage class main.c:124: error: parse error before "fetch_2d_texel_rgba_dxt3" main.c:124: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt3' main.c:124: warning: data definition has no type or storage class main.c:125: error: parse error before "fetch_2d_texel_rgba_dxt5" main.c:125: warning: type defaults to `int' in declaration of `fetch_2d_texel_rgba_dxt5' main.c:125: warning: data definition has no type or storage class main.c: In function `DDRAW_bind_to_s3tc': main.c:148: warning: assignment makes integer from pointer without a cast main.c:148: warning: comparison between pointer and integer main.c:149: warning: assignment makes integer from pointer without a cast main.c:149: warning: comparison between pointer and integer main.c:150: warning: assignment makes integer from pointer without a cast main.c:150: warning: comparison between pointer and integer make[2]: *** [main.o] Error 1 make[2]: Leaving directory `/usr/src/apps/CVS/wine/dlls/ddraw' make[1]: *** [ddraw] Error 2 make[1]: Leaving directory `/usr/src/apps/CVS/wine/dlls' make: *** [dlls] Error 2 Take (more ;) care, Andreas

1 0

No go here (Re: [D3D] Added native and emulated S3TC support (take 2))
by Andreas Mohr 31 Jul '04

31 Jul '04

Hi, On Thu, Jul 29, 2004 at 11:49:33PM +0100, Christian Costa wrote: > Hi, > > This is the second version of my patch which take into account Lionel's > comments plus another fix. > > I've only mentionned the libtxc_dxtn.so library for software > decompression when the video card does not support S3TC. > Maybe Lionel can say if we can add more precise information i.e > reference to the DRI project. CVS compile bombs for me with: gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o ddraw/hal.o ddraw/hal.c gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o ddraw/main.o ddraw/main.c ddraw/main.c: In function `create_texture': ddraw/main.c:394: error: `GL_extensions' undeclared (first use in this function)ddraw/main.c:394: error: (Each undeclared identifier is reported only once ddraw/main.c:394: error: for each function it appears in.) make[2]: *** [ddraw/main.o] Error 1 make[2]: Leaving directory `/usr/src/apps/CVS/wine/dlls/ddraw' make[1]: *** [ddraw] Error 2 make[1]: Leaving directory `/usr/src/apps/CVS/wine/dlls' make: *** [dlls] Error 2 Command exited with non-zero status 2 /* Check if we can really support DXT1, DXT3 & DXT5 */ if ((ddsd.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) && !GL_extensions.s3tc_compressed_texture && !s3tc_initialized) { ERR("Trying to create DXT1, DXT3 or DXT5 texture which is not supported by the video card!!!\n"); ERR("However there is a library libtxc_dxtn.so that can be used to do the software decompression...\n"); return DDERR_INVALIDPIXELFORMAT; } ii xlibmesa-gl 4.3.0.dfsg.1-1 Mesa 3D graphics library [XFree86] ii xlibmesa-glu 4.3.0.dfsg.1-1 Mesa OpenGL utility library [XFree86] 01:00.0 VGA compatible controller: Matrox Graphics, Inc. MGA G400 AGP (rev 03) (shouldn't matter anyway) /* Define if the OpenGL headers define extension typedefs */ /* #undef HAVE_GLEXT_PROTOTYPES */ /* Define if the OpenGL library supports the glXGetProcAddressARB call */ /* #undef HAVE_GLX_GETPROCADDRESS */ /* Define to 1 if you have the <GL/glext.h> header file. */ /* #undef HAVE_GL_GLEXT_H */ /* Define to 1 if you have the <GL/glx.h> header file. */ /* #undef HAVE_GL_GLX_H */ /* Define to 1 if you have the <GL/gl.h> header file. */ /* #undef HAVE_GL_GL_H */ /* Define if OpenGL is present on the system */ /* #undef HAVE_OPENGL */ /* Define to the soname of the libGL library. */ #define SONAME_LIBGL "libGL.so" Good luck, Andreas Mohr

1 0

shell32 patch
by Jens Collin 31 Jul '04

31 Jul '04

Hi, I've made a small change in shell32.dll to enable one to type a myfile.txt from Start->Run dialog (for example). I've simply replaced the call to CreateProcess with ShellExecute. I've tested this change in reactos and it works nicely. It won't really work since there is something wrong with ShellExecute itself (or rather FindExecutable) but I've contacted Francois (fgouget(a)free.fr) to get some help on this. Anyway, it partially adds a tiny function and it doesn't break anything. Can someone commit this small patch for me please? Thanks in advance, Jens Collin

1 0

Re: USB?
by Ivan Leo Puoti 31 Jul '04

31 Jul '04

I don't think drivers are an issue, what we wants to do is use an app that uses the usb ports, and he wants to use this app from wine. So he wants to write an interface for wine, that would take driver calls from the program and forward them to ioctl(whatever) so the app will work with the usb ports, or at least thats how I think it may work. I don't think it's easy to find USB ports not supported by linux now days, but wine isn't usb-aware. Ivan.

1 0

Re: Question about mmap issues on FreeBSD/NetBSD
by Yorick Hardy 31 Jul '04

31 Jul '04

Thanks for the response. I must be doing something wrong, since wine-kthread gave the same error. Anything I may have missed? I copied wine-kthread from loader/wine-kthread. It does not appear to be correct, but is there any chance madvise(..., MADV_DONTNEED) could help? Also in libs/wine/mmap.c line 119 the result of mincore is never tested, should it not be if ( (mincore( (caddr_t)addr + i, pagesize, &vec ) != -1) && (vec&1) ) (with a slight variation for FreeBSD), although I think this will not resolve the current problem. >You need MAP_NORESERVE support otherwise we can't control the address >space correctly (unless you have a ton of virtual memory): if you run >wine-kthread directly it should still work though unless you have >execshield type address space randomisation active. > >On Thu, 29 Jul 2004 09:13:25 +0200, Yorick Hardy wrote: >> Just a question about the mmap issues experienced on FreeBSD, i.e. >> http://www.winehq.org/?issue=230#Wine%20on%20FreeBSD >> >> I encountered the same on NetBSD. It seems the error message is set from >> ld.elf_so in NetBSD and ld-elf.so.1 in FreeBSD, when the address space >> is mapped for the run time linking? Since MAP_NORESERVE is not documented >> (and not supported?) for mmap on FreeBSD and NetBSD, it would appear >> that wine and the ld.elf_so together require too much memory for all the mmap >> calls. Kind regards, -- Yorick Hardy

5 5

ms devel tools
by Ivan Leo Puoti 31 Jul '04

31 Jul '04

If anyone needs to test something out with m$ development tools for whatever reason, they are giving away free betas (It doesn't matter, all m$ software is alpha/beta) of the express development tools, so if you need one get it until you can. http://lab.msdn.microsoft.com/express/ I'm going to try and see how much of wine will build with visualc++. Ivan.

1 0

Re: [D3D] Added native and emulated S3TC support (take 2)
by Lionel Ulmer 30 Jul '04

30 Jul '04

> I've only mentionned the libtxc_dxtn.so library for software > decompression when the video card does not support S3TC. > Maybe Lionel can say if we can add more precise information i.e > reference to the DRI project. Well, the page where you can download it is the third Google link when searching for 'libtxc_dxtn'. So I think the information there is enough :-) Lionel PS: thanks for the edits, will be able to test the final version now that it's commited :-) -- Lionel Ulmer - http://www.bbrox.org/

1 0

regression
by Ivan Leo Puoti 30 Jul '04

30 Jul '04

The following patch http://www.winehq.com/hypermail/wine-cvs/2004/03/0434.html causes an infinite loop when installing the word97/2k viewer. A relay log from the loop is attached. Can someone please fix this? Ivan.

1 0

RPCRT4_NdrClientCall2 stub (fixme)?
by Jeroen Janssen 30 Jul '04

30 Jul '04

Hello, I have 'hit' upon a RPCRT4_NdrClientCall2 stub/fixme call. It seems some discussion on this has been happening in a the past few months? Can someone maybe explain the current status on this? (probably Rob or Mike, since they seem to be the Wine COM "gurus"?) Below is is a short snip of trace logging I get: trace:ole:COMPOBJ_DLLList_Add trace:ole:CStdPSFactory_QueryInterface (0x660cea80)->QueryInterface({d5f569d0-593b-101a-b569-08002b2dbf7a},0x4067faa4) trace:ole:CStdPSFactory_CreateProxy (0x660cea80)->CreateProxy((nil),{11ef83d1-553a-11d3-bb12-0004ac9658d6},0x4067faa0,0x4067fbfc) trace:ole:FindProxyInfo found: ProxyInfo 0x660cbc48 Index 65 trace:ole:StdProxy_Construct ((nil),0x660cd048,0x660cea80,0x4067faa0,0x4067fbfc) ICoKMFactoryManager trace:ole:StdProxy_Construct stubless=0x660c5230 trace:ole:StdProxy_Construct iid={11ef83d1-553a-11d3-bb12-0004ac9658d6} trace:ole:StdProxy_Construct vtbl=0x660cd050 trace:ole:StdProxy_Construct stubless thunks: count=6 trace:ole:StdProxy_Construct method 3: stacksize=12 trace:ole:StdProxy_Construct method 4: stacksize=16 trace:ole:StdProxy_Construct method 5: stacksize=4 trace:ole:CStdPSFactory_AddRef (0x660cea80)->AddRef() trace:ole:CStdPSFactory_Release (0x660cea80)->Release() trace:ole:StdProxy_Connect (0x4034f1f0)->Connect(0x4034f288) trace:ole:StdProxy_Release (0x4034f1f0)->Release() trace:ole:ObjectStubless (0x4034f1f4)->(3)([12 bytes]) ret=4067fc94 fixme:ole:RPCRT4_NdrClientCall2 (pStubDec == ^0x660c7c08,pFormat = ^0x660c7d30,...): stub trace:ole:IUnknown_Release_Proxy (0x4034f1f0)->Release() ICoKMFactoryManager wine: Unhandled exception (thread 0014), starting debugger... Best regards, Jeroen Janssen

5 8

Re: possible bug in wcmd
by Ivan Leo Puoti 30 Jul '04

30 Jul '04

It looks like a bug to me. [ivan@localhost wcmd]$ ./wcmd WCMD Version 0.17 Z:\home\ivan\Development\Wine\CVS\wine\wine\programs\wcmd>help for wine: Unhandled exception (thread 0009), starting debugger... fixme:console:SetConsoleCtrlHandler (0x405ec9e0,1) - no error checking or testing yet WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x20656854 in 32-bit code (0x400d2473). In 32 bit mode. 0x400d2473 strlen in libc.so.6: movl 0x0(%eax),%ecx Wine-dbg>bt Backtrace: =>1 0x400d2473 strlen+0x33 in libc.so.6 (0x406eed1c) 2 0x400ba8cb _IO_vsprintf+0x8b in libc.so.6 (0x406eede4) 3 0x405c9eeb WCMD_output+0x2b(format=0x406ef20c) [wcmdmain.c:741] in wcmd (0x406ef200) 4 0x405c7020 WCMD_give_help+0x80(command=0x4039b8a5) [builtins.c:352] in wcmd (0x406efa18) 5 0x405c9563 .L153+0x9 in wcmd (0x406efa58) 6 0x405c91d4 main+0x4f4(argc=0x1, argv=0xbffff49c) [wcmdmain.c:244] in wcmd (0x406efe9c) 7 0x405c6169 __wine_exe_main+0x169 in wcmd (0x406eff2c) 8 0x404e6a88 start_process+0xc8(arg=0x0) [process.c:995] in kernel32 (0x406efff4) 9 0x4001cd9d wine_switch_to_stack+0x11 in libwine.so.1 (0x00000000) Wine-dbg>quit WineDbg terminated on pid 0x8 [ivan@localhost wcmd]$

1 0

Re: RPCRT4_NdrClientCall2 stub (fixme)?
by Filip Navara 30 Jul '04

30 Jul '04

Alexandre Julliard wrote: > Mike Hearn <mike(a)navi.cx> writes: > >>> Yes, I have an implementation of NdrClientCall2 in my local tree, but >>> I'm a bit busy with other COM things at the moment. I'll send an >>> updated >>> patch to the list either tonight or sometime over the weekend. >>> >> >> Alexandre, why was this not merged when it was originally sent? >> > > No idea, please resubmit. > IIRC Robert said that the patch isn't cleaned up yet and so it shouldn't be commited. He also said that he hasn't tested it much except for simple tests and the complex types weren't tested at all. - Filip

3 4

possible bug in wcmd
by Henning Gerhardt 30 Jul '04

30 Jul '04

Hi, I discovered a possible bug in wcmd. If you run "help for" inside wcmd, wcmd crashed and the winedebugger is called. I used to confirm this bug on my machine the latest tarball and a CVS-snapshot from today. If anybody can confirm this bug I will be happy :) The following lines are only correct if this bug is true: The problem is that a single % letter inside the resource strings. Look for the for-help text in En.rc file and you find the sentence "The requirement to double the % sign when using FOR in a batch file does") get parsed and this single % caused the crash. I found the following solutions and I don't know what is the right solution: 1. replace the single % with a double %% in all resource files 2. replace in the function WCMD_give_help (builtins.c:330) WCMD_output with WCMD_output_asis (WCMD_output (wcmdmain.c:733) called WCMD_output_asis but make some stuff for possible dynamic parameters) 3. patch the function WCMD_output (wcmdmain.c:733) with the attached patch (Replace a single % with a double % and all later called system function are be happy) I prefer personal the second or third solution. Regards, Henning

1 0

Linking with dlls and Linux libs using winelib?
by James Supancic 30 Jul '04

30 Jul '04

I need to compile a Windows application under Linux. I need to use dlls and Linux librarys. No matter what I try I can't get winegcc to include the Linux librarys in the linking stage. What must I do to get winegcc to link with both the dlls and Linux libs? Thank you for your time, James Steven Supancic III _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today - it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

2 1

Re: Re: WineHQ:service.cgi: fix winrash option
by chmorgan＠charter.net 30 Jul '04

30 Jul '04

> <chmorgan(a)charter.net> writes: > > > Which errors are you referring to? The most frequent ones > > lately are the ones where the winetest package isn't > > available on the sourceforge osdn mirror. > > For example this: > > > Winrash version: winrash-0008-chris-msvc.exe > > [...] > > winetest = winetest-200407091000-kevin-mingw.zip > > winetest_history = > > Script: > > 8 total commands, current command is 6 > > 0: error_url http://test.winehq.org/error > > 1: error_sleep 3600 > > 2: download winetest-200407091000-kevin-mingw.zip http://osdn.dl.sourceforge.net/sourceforge/wine/winetest-200407091000-kevin… > > 3: cookie winetest winetest-200407091000-kevin-mingw.zip > > 4: cookie winetest_history > > 5: unzip winetest-200407091000-kevin-mingw.zip > > --> 6: run winetest-200407091000-kevin-mingw.exe -c -t Cogman -u http://osdn.dl.sourceforge.net/sourceforge/wine/winetest-200407091000-kevin… > > 7: sleep 300 > > Command in error: > > 6 > > Last error text: The system cannot find the file specified. > > Does the above mean that the download was unsuccessful? > Equally for "Last error text: %1 is not a valid Win32 > application."? Then we don't need these messages (which > could be improved at least). > Yep. I just tried that url and it worked. Many of the ones I've tried in the past haven't and the cause seems to be that the mirror chosen doesn't have the file. I'm not sure what a good solution is. Perhaps we should implement a way of providing a list of potential download sites for a file. I'm not sure how to detect that the download fails. Sourceforge provides a page that says that the file can't be found. This is what winrash probably downloaded in this case. Any ideas how to make the system more robust without making it much more complex? > Hmm, some still try to download winrash-0008 from the osdn > mirror, which has been obsoleted for a long time. Why? > I have no idea what the issue is here. The script should be telling the 0007 client to download 0009. I'm not sure if this is a bug or not. > And service.cgi shouldn't pass the -u option to winetest > anymore, I patched it out. At least I think so. > > > We are still asking people to download the tests from this > > location for particular test releases. I'd imagine the > > fix is simply to point the downloads at valid mirror for > > the file. > > By editing service.cgi's database? You could ask Jer, his > is very helpful if you can catch him on IRC. I wish there > was some logging feature in service.cgi... I'll go deeper > in a couple of days. > -- > Feri. Your help is much appreciated. This is a tricky issue it seems as SF isn't always reliable for downloads... Chris

7 9

formal standard for wine devel style
by James Hawkins 30 Jul '04

30 Jul '04

Is there a written formal standard specifying the style in which wine code is written? I remember a message a while back about how a patch couldn't be committed because it didn't meet the standards of wine coding style and that someone who knew the style could fix it. -- James Hawkins

3 2

Re: DCOM: Disconnect Proxies at COM Shutdown
by Robert Shearman 30 Jul '04

30 Jul '04

Robert Shearman wrote: > Changelog: > > Mike Hearn <mh(a)codeweavers.com> > Disconnect proxies at COM shutdown to release the corresponding stubs. Sorry, this one was an old patch. Rob

1 0

Bug in menu.c
by Dan Timis 30 Jul '04

30 Jul '04

Hi, The MS documentation on the structure MENUITEMINFO says that the field fMask indicates what fields to retrieve or set. Here is what it says about the value MIIM_TYPE: > Retrieves or sets the fType and dwTypeData members. Windows 98/Me, > Windows 2000/XP: MIIM_TYPE is replaced by MIIM_BITMAP, MIIM_FTYPE, > and MIIM_STRING. So if one wants to specify a text menu item in XP, one would use MIIM_STRING, not MIIM_TYPE. fType would also need to be MFT_STRING. In menu.c in GetMenuItemInfo_common(): /* copy the text string */ if ((lpmii->fMask & (MIIM_TYPE|MIIM_STRING)) && (MENU_ITEM_TYPE(menu->fType) == MF_STRING) && menu->text) { and so on... This works fine. It retrieves the text if either MIIM_TYPE or MIIM_STRING are set. But, in GetMenuItemInfo_common(): if (lpmii->fMask & MIIM_TYPE) { /* Get rid of old string. */ if (IS_STRING_ITEM(menu->fType) && menu->text) { HeapFree(GetProcessHeap(), 0, menu->text); menu->text = NULL; } /* make only MENU_ITEM_TYPE bits in menu->fType equal lpmii->fType */ menu->fType &= ~MENU_ITEM_TYPE(menu->fType); menu->fType |= MENU_ITEM_TYPE(lpmii->fType); menu->text = lpmii->dwTypeData; and so on... This sets the text only if MIIM_TYPE is set. I changed the first line to: if (lpmii->fMask & (MIIM_TYPE|MIIM_STRING)) { and menus that were drawing before as a long thin vertical line, started to show correctly. I'm not sure if this is the right way to fix this, but it works for me. I am using a wine version from 2004-04-08. BTW, I reported earlier a crash in menu.c. I did not hear anything back. Should I log this into Bugzilla? Thanks, Dan Timis Muse Research, Inc.

2 1

Re: cleanup a->w cross calls in advapi32/crypt.c
by Dmitry Timoshkov 30 Jul '04

30 Jul '04

"James Hawkins" <truiken(a)gmail.com> wrote: > This is a resubmit of my original patch that cleans up a->w cross > calls in crypt. > > Changelog > * cleanup a->w cross calls in advapi32/crypt.c > + static const WCHAR KEYSTR[] = { > + 'S','o','f','t','w','a','r','e','\\','\\', > + 'M','i','c','r','o','s','o','f','t','\\','\\', > + 'C','r','y','p','t','o','g','r','a','p','h','y','\\','\\', > + 'D','e','f','a','u','l','t','s','\\','\\', > + 'P','r','o','v','i','d','e','r','\\','\\',0 > + }; Remove double backslashes here and everywhere else. > - keyname = CRYPT_Alloc(strlen(KEYSTR) + strlen(pProvName) +1); > + keyname = CRYPT_Alloc(strlenW(KEYSTR) + strlenW(pProvName) + 1); Add '* sizeof(WCHAR)' and everywhere else where storage for unicode strings is allocated. > - keyname = CRYPT_Alloc( (user ? strlen(USERSTR) : strlen(MACHINESTR)) +1); > + keyname = CRYPT_Alloc( (user ? strlenW(USERSTR) : strlenW(MACHINESTR)) +1); Add '* sizeof(WCHAR)' > + static WCHAR nameW[] = {'N','a','m','e',0}; > + static WCHAR typeW[] = {'T','y','p','e',0}; > + static WCHAR imagePathW[] = {'I','m','a','g','e',' ','P','a','t','h',0}; > + static WCHAR signatureW[] = {'S','i','g','n','a','t','u','r','e',0}; > + static WCHAR sigInFileW[] = {'S','i','g','I','n','F','i','l','e',0}; Add 'const'. > - if ( !(provname = CRYPT_Alloc(strlen(pszProvider) +1)) ) > + if ( !(provname = CRYPT_Alloc(strlenW(pszProvider) +1)) ) Add '* sizeof(WCHAR)' > - len = ExpandEnvironmentStringsA(temp, NULL, 0); > + len = ExpandEnvironmentStringsW(temp, NULL, 0); > if ( !(imagepath = CRYPT_Alloc(len)) ) Add '* sizeof(WCHAR)' ... And lots of similar bugs. -- Dmitry.

1 0

Re: change the nt service pack version from 6 to 6a, correct win2k3 name
by Ivan Leo Puoti 30 Jul '04

30 Jul '04

>Easy, take several W2K3 system DLLs and kick them through winedump with what command line?

1 0

Re: add autodetect audio driver capability to winmm, second try
by Alexandre Julliard 29 Jul '04

29 Jul '04

James Hawkins <truiken(a)gmail.com> writes: > + /* try to detect arts */ > + argv_new[2] = "ps awx|grep artsd|grep -v grep|grep artsd > /dev/null"; > + if(!spawnvp(_P_WAIT, "/bin/sh", argv_new)) > + { > + driversFound[numFound] = "winearts.drv"; > + name[numFound] = "aRts"; > + numFound++; > + } This code does not belong in winmm. Autodetection in winmm should be done by having the drivers themselves fail to load if the corresponding support is missing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Test drive error
by sergio ojalvo 29 Jul '04

29 Jul '04

Hi I'm working on Debian Linux. I just install the wine packages and download sources for trying the test driver. Running Winemaker to winemine test project I note: that configure script was not created and Makefile is created instead of Makefile.in. (like wrote in the web page) I think is a new feature... I'm wrong? Anyway, I try to run make after that and that is the output: winebuild -o winemine.exe.dbg.c --debug -C. dialog.c main.c winegcc -c -mno-cygwin -I. -o winemine.exe.dbg.o winemine.exe.dbg.c winegcc -c -mno-cygwin -I. -o dialog.o dialog.c winegcc -c -mno-cygwin -I. -o main.o main.c wrc -I. -foEn.res En.rc En.rc:23:22: Error: syntax error make: *** [En.res] Error 1 After that I try with another 2 projects (win32 code) and I receive a lot of compilation errors like: In file included from /usr/include/c++/3.3/iosfwd:46, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/c++/3.3/i486-linux/bits/c++locale.h:53: error: `uselocale' was not declared in this scope In file included from /usr/include/c++/3.3/i486-linux/bits/c++io.h:35, from /usr/include/c++/3.3/bits/fpos.h:44, from /usr/include/c++/3.3/iosfwd:49, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/c++/3.3/cstdio:167: error: `snprintf' not declared /usr/include/c++/3.3/cstdio:168: error: `vfscanf' not declared /usr/include/c++/3.3/cstdio:169: error: `vscanf' not declared /usr/include/c++/3.3/cstdio:171: error: `vsscanf' not declared /usr/include/c++/3.3/cstdio:177: error: `snprintf' not declared /usr/include/c++/3.3/cstdio:178: error: `vfscanf' not declared /usr/include/c++/3.3/cstdio:179: error: `vscanf' not declared /usr/include/c++/3.3/cstdio:181: error: `vsscanf' not declared In file included from /usr/include/c++/3.3/i486-linux/bits/gthr-default.h:37, from /usr/include/c++/3.3/i486-linux/bits/gthr.h:98, from /usr/include/c++/3.3/i486-linux/bits/c++io.h:37, from /usr/include/c++/3.3/bits/fpos.h:44, from /usr/include/c++/3.3/iosfwd:49, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/pthread.h:651: error: type specifier omitted for parameter `clockid_t' /usr/include/pthread.h:651: error: parse error before `*' token In file included from /usr/include/c++/3.3/bits/fpos.h:45, from /usr/include/c++/3.3/iosfwd:49, from /usr/include/c++/3.3/ios:44, from /usr/include/c++/3.3/ostream:45, from /usr/include/c++/3.3/iostream:45, from midi2nokia.cpp:4: /usr/include/c++/3.3/cwchar:142: error: `fwide' not declared /usr/include/c++/3.3/cwchar:149: error: `mbsinit' not declared /usr/include/c++/3.3/cwchar:157: error: `vfwscanf' not declared /usr/include/c++/3.3/cwchar:159: error: `vswscanf' not declared /usr/include/c++/3.3/cwchar:161: error: `vwscanf' not declared /usr/include/c++/3.3/cwchar:176: error: `wcstof' not declared /usr/include/c++/3.3/cwchar:182: error: `wmemcmp' not declared /usr/include/c++/3.3/cwchar:183: error: `wmemcpy' not declared /usr/include/c++/3.3/cwchar:184: error: `wmemmove' not declared /usr/include/c++/3.3/cwchar:185: error: `wmemset' not declared /usr/include/c++/3.3/cwchar:213: error: `wmemchr' not declared /usr/include/c++/3.3/cwchar: In function `wchar_t* std::wmemchr(wchar_t*, wchar_t, unsigned int)': /usr/include/c++/3.3/cwchar:217: error: invalid conversion from `const wchar_t* ' to `wchar_t*' /usr/include/c++/3.3/cwchar: At global scope: /usr/include/c++/3.3/cwchar:233: error: `wcstold' not declared /usr/include/c++/3.3/cwchar:242: error: `wcstoll' not declared /usr/include/c++/3.3/cwchar:243: error: `wcstoull' not declared /usr/include/c++/3.3/cwchar:249: error: `wcstold' not declared /usr/include/c++/3.3/cwchar:250: error: `wcstoll' not declared /usr/include/c++/3.3/cwchar:251: error: `wcstoull' not declared etc, etc, etc.... I send you my gcc configuration: gcc -v Reading specs from /usr/lib/gcc-lib/i486-linux/3.3.4/specs Configured with: ../src/configure -v --enable-languages=c,c++,java,f77,pascal,objc,ada,treelang --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-gxx-include-dir=/usr/include/c++/3.3 --enable-shared --with-system-zlib --enable-nls --without-included-gettext --enable-__cxa_atexit --enable-clocale=gnu --enable-debug --enable-java-gc=boehm --enable-java-awt=xlib --enable-objc-gc i486-linux Thread model: posix gcc version 3.3.4 (Debian 1:3.3.4-4) Any suggestion? Thanks a lot for your help. -- ____________________________ ________ _______________________________ | Sergio Ojalvo \ \ / | | Senior System Analyst \ \/ To bring IN-OVATION turn to | | mailto:sergio@ximpo.com /\ \ your open source of solutions | | Phone: +972-545-558586 / \ \ | | Fax: +972-151-545-558586 -------- http://www.ximpo.com/ | |__________________________ Ximpo Group _____________________________|

3 4

Re: [D3D] Added native and emulated S3TC support
by Lionel Ulmer 29 Jul '04

29 Jul '04

I have just a few comments on the patch (yeah, it would not have been fun if I had commented on wine-d3d first :-) ). But anyway, great work ! > +static BOOL DDRAW_bind_to_s3tc( void ) > +{ > + const char *s3tcname = SONAME_LIBS3TC; > + > + s3tc_handle = wine_dlopen(s3tcname, RTLD_NOW, NULL, 0); > + if (!s3tc_handle) { > + printf("Wine cannot find the S3TC software decompression library (%s).\n",s3tcname); Why did you use 'printf' here instead of WARN or ERR ? Moreover, with this, we will print an error at DirectX loading when the users do not have this library installed ... even if the game does never request any compressed mode textures. Would it not be better to somehow print the error message when the application wants to create a DXTN texture (ie somehow remember that we do not support this feature and keep the error message for later). > + return FALSE; > + } > + > +#define API_FUNCTION(f) \ > + if((f = wine_dlsym(s3tc_handle, #f, NULL, 0)) == NULL) \ > + { \ > + printf("Can't find symbol %s\n", #f); \ Same printf comment here (but this one can be kept here :-) ). > + goto sym_not_found; \ > + } > + API_FUNCTION(fetch_2d_texel_rgba_dxt1); > + API_FUNCTION(fetch_2d_texel_rgba_dxt3); > + API_FUNCTION(fetch_2d_texel_rgba_dxt5); > +#undef API_FUNCTION > + > + return TRUE; > + > +sym_not_found: > + WARN("Wine cannot find functions that are necessary for S3TC decompression\n"); > + wine_dlclose(s3tc_handle, NULL, 0); > + s3tc_handle = NULL; > + return FALSE; > +} > + (...) > > + if (src_pf->dwFlags & DDPF_FOURCC) { > + GLenum retVal; > + int size = surf_ptr->surface_desc.u1.dwLinearSize; > + int width = surf_ptr->surface_desc.dwWidth; > + int height = surf_ptr->surface_desc.dwHeight; > + LPVOID buffer = surf_ptr->surface_desc.lpSurface; > + > + switch (src_pf->dwFourCC) { > + case MAKE_FOURCC('D','X','T','1'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT1_EXT; break; > + case MAKE_FOURCC('D','X','T','3'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT3_EXT; break; > + case MAKE_FOURCC('D','X','T','5'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT5_EXT; break; > + default: > + FIXME("FourCC Not supported\n"); > + return DD_OK; > + break; > + } > + GL_extensions.glCompressedTexImage2D(GL_TEXTURE_2D, current_level, retVal, width, height, 0, size, buffer); How are we sure that this code will never be called with the 'glCompressedTexImage2D' unset ? I.e. when we are in emulation mode, what happens here ? Is this because when we are in emulation mode, we do not advertise support for DTXN textures, this means that the application can create such textures, but will be automagically converted to RGB ones at Loading ? Anyway, I would still prefer a test here to prevent crashes for application which do not behave well :-) (...) > + if (current_surface->surface_desc.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) { > + GLint retVal; > + int size = current_surface->surface_desc.u1.dwLinearSize; > + int width_ = current_surface->surface_desc.dwWidth; > + int height_ = current_surface->surface_desc.dwHeight; > + LPVOID buffer = current_surface->surface_desc.lpSurface; > + > + switch (current_surface->surface_desc.u4.ddpfPixelFormat.dwFourCC) { > + case MAKE_FOURCC('D','X','T','1'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT1_EXT; break; > + case MAKE_FOURCC('D','X','T','3'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT3_EXT; break; > + case MAKE_FOURCC('D','X','T','5'): retVal = GL_COMPRESSED_RGBA_S3TC_DXT5_EXT; break; > + default: > + FIXME("Not supported\n"); > + return DD_OK; > + break; > + } > + /* GL_extensions.glCompressedTexSubImage2D(GL_TEXTURE_2D, current_level, xoffset, yoffset, width, height, retVal, (unsigned char*)temp_buffer); */ > + GL_extensions.glCompressedTexImage2D(GL_TEXTURE_2D, current_level, retVal, width_, height_, 0, size, buffer); Same here. > + } > + > + if (strstr(glExtensions, "GL_EXT_texture_compression_s3tc")) { > + TRACE(" - S3TC compression supported\n"); > + GL_extensions.s3tc_compressed_texture = TRUE; > + GL_extensions.glCompressedTexImage2D = pglXGetProcAddressARB("glCompressedTexImage2D"); > + GL_extensions.glCompressedTexSubImage2D = pglXGetProcAddressARB("glCompressedTexSubImage2D"); > } If I were pedantic, you should test for 'GL_ARB_texture_compression' to be able to get the 'glCompressedTexImage2DARB' and 'glCompressedTexSubImage2DARB' functions (which may be better than using the non-ARB versions which are, AFAIK, the ones in GL 1.4). And then to get 'GL_EXT_texture_compression_s3tc' to set 'GL_extensions.s3tc_compressed_texture' to TRUE. But as 'GL_EXT_texture_compression_s3tc' depends on 'GL_ARB_texture_compression', I will let you do this shortcut :-) > - /* We do not support for now compressed texture formats... */ > - if (ddsd.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) > + /* We support for now only DXT1, DXT3 & DXT5 compressed texture formats... */ > + if ((ddsd.u4.ddpfPixelFormat.dwFlags & DDPF_FOURCC) && > + (ddsd.u4.ddpfPixelFormat.dwFourCC != MAKE_FOURCC('D','X','T','1')) && > + (ddsd.u4.ddpfPixelFormat.dwFourCC != MAKE_FOURCC('D','X','T','3')) && > + (ddsd.u4.ddpfPixelFormat.dwFourCC != MAKE_FOURCC('D','X','T','5')) ) > { > return DDERR_INVALIDPIXELFORMAT; > } What to do here when neither hardware nor emulated support is present ? Maybe we should print an error (cf previous comment) and return INVALIDPIXELFORMAT, no ? Lionel (who goes testing NOFL :-) ) -- Lionel Ulmer - http://www.bbrox.org/

3 5

Re: Fix crash in dsound test
by Robert Reif 29 Jul '04

29 Jul '04

How did this fail in windows. Since it doesn't crash with wine, wine is doing something wrong. Lets try to figure out what is wrong and correct wine to have the same behavior as windows or at least notify someone that something is wrong. Is anyone working on getting direct sound into the windows port of our regression tests? Francois Gouget wrote: > > Changelog: > > * dlls/dsound/tests/dsound.c > > Francois Gouget <fgouget(a)codeweavers.com> > Call IDirectSound::Initialize() as per MSDN before using the > DirectSound object. Fixes a crash on Windows. > >------------------------------------------------------------------------ > >Index: dlls/dsound/tests/dsound.c >=================================================================== >RCS file: /var/cvs/wine/dlls/dsound/tests/dsound.c,v >retrieving revision 1.24 >diff -u -r1.24 dsound.c >--- dlls/dsound/tests/dsound.c 13 Jul 2004 23:35:09 -0000 1.24 >+++ dlls/dsound/tests/dsound.c 16 Jul 2004 16:23:51 -0000 >@@ -69,6 +69,9 @@ > if (rc==DS_OK) > IDirectSound8_Release(ds8); > >+ rc=IDirectSound_Initialize(dso,NULL); >+ ok(rc==DS_OK,"IDirectSound_Initialize(NULL) failed: %s\n",DXGetErrorString9(rc)); >+ > /* DSOUND: Error: Invalid caps buffer */ > rc=IDirectSound_GetCaps(dso,0); > ok(rc==DSERR_INVALIDPARAM,"GetCaps should have failed: %s\n",DXGetErrorString9(rc)); >@@ -168,6 +171,9 @@ > if (rc==DS_OK) > IDirectSound8_Release(ds8); > >+ rc=IDirectSound8_Initialize(dso,NULL); >+ ok(rc==DS_OK,"IDirectSound_Initialize(NULL) failed: %s\n",DXGetErrorString9(rc)); >+ > /* DSOUND: Error: Invalid caps buffer */ > rc=IDirectSound8_GetCaps(dso,0); > ok(rc==DSERR_INVALIDPARAM,"GetCaps should have failed: %s\n",DXGetErrorString9(rc)); > >

5 7

Question about mmap issues on FreeBSD/NetBSD
by Yorick Hardy 29 Jul '04

29 Jul '04

Just a question about the mmap issues experienced on FreeBSD, i.e. http://www.winehq.org/?issue=230#Wine%20on%20FreeBSD I encountered the same on NetBSD. It seems the error message is set from ld.elf_so in NetBSD and ld-elf.so.1 in FreeBSD, when the address space is mapped for the run time linking? Since MAP_NORESERVE is not documented (and not supported?) for mmap on FreeBSD and NetBSD, it would appear that wine and the ld.elf_so together require too much memory for all the mmap calls. Am I correct? Kind regards, -- Yorick Hardy

2 1

Re: Is bugzilla worth keeping?
by Dan Kegel 29 Jul '04

29 Jul '04

Mike Hearn wrote: > So are we misleading users by having a bugzilla into thinking that if > they file a bug there, it'll be fixed when it probably won't? Not at all. Just because not enough people are doing bug triage or fixing doesn't mean we should drop bugzilla. Somebody will eventually go through the bug reports, I think. > If we were to simply drop bugzilla, how would it impact the project? It would deprive us of long-term memory. For instance, I filed the bug report http://bugs.winehq.org/show_bug.cgi?id=1404 in January 2003 with a nice test case (but one that's hard to translate into a unit test). Without Bugzilla, we'd have a harder time remembering problems like that. (Unless cxtest really takes off, I suppose...) - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

3 3

Re: winetests/winrash
by Rolf Kalbermatter 29 Jul '04

29 Jul '04

Chris Morgan <cmorgan(a)alum.wpi.edu> wrote: >I wouldn't mind adding a systray icon. I wasn't really sure how that was >supposed to be done. I tried having the service add a systray icon without >much success, I don't believe services can interact with the desktop. That >may mean that a separate winrash monitor may have to be written that >communicates with the service. Services can interact with the desktop but not by default. It is a special option you specify when installing the service. The magic for this is in the dwServiceType parameter of the CreateService() to register a service object in the system. >From MSDN: SERVICE_FILE_SYSTEM_DRIVER File system driver service. SERVICE_KERNEL_DRIVER Driver service. SERVICE_WIN32_OWN_PROCESS Service that runs in its own process. SERVICE_WIN32_SHARE_PROCESS Service that shares a process with one or more other services. For more information, see Service Programs. If you specify either SERVICE_WIN32_OWN_PROCESS or SERVICE_WIN32_SHARE_PROCESS, and the service is running in the context of the LocalSystem account, you can also specify the following type. Type Meaning SERVICE_INTERACTIVE_PROCESS The service can interact with the desktop. Not sure how winrash is currently installed but if it is not through a small Win32 setup app but an InstallShield app, I'm sure it has according parameters to let it install as interactive service Rolf Kalbermatter

2 1

Fwd: Re: rsabase.dll
by Michael Jung 29 Jul '04

29 Jul '04

I'm sorry, if this mail appears three times on the wine-devel list. I've sent it twice already, but it doesn't seem to get forwarded to the wine-devel list. Is there a problem with the mailing list? Rob, could you give me a short notificaton, if you have received those mails? Thank, Michael ---------- Forwarded Message ---------- Subject: Re: rsabase.dll Date: Tuesday 27 July 2004 10:08 From: Michael Jung <mjung(a)iss.tu-darmstadt.de> To: wine-devel(a)winehq.org Cc: rob(a)codeweavers.com Rob, > I think there are many reasons to favour "real handles": If a long running > process is using rsabase (e.g. a webserver serving https: requests) with > many temporary connections and many keys, resource leakage is an issue. > Furthermore, since rsabase is a cryptographic service provider, it might be > important that a key, which is not referenced anymore is in fact destroyed > (and the > corresponding memory be nulled). I would think that otherwise you will > over time accumulate a lot of keys in your address space, which is probably > a security problem. Now, I'm aware that wine is not in a state today to be > used for security critical applications and first rsabase implementations > will probably have security issues more severe than this. However, sometime > I think rsabase will have to use real handles. Why not right from the > start? I've thought about this statement again and realized that I'm wrong and that I probably misunderstood you. I realized that one doesn't need "real handles" in user mode code at all to implement correct resource management. And I think I understand that one does need them in the kernel (aka wineserver) for objects, which are accessed from multiple threads. However, there are some instances of "real handle" implementations outside wineserver in wine (e.g. dlls/msi/handle.c). Do you (or anybody else on the mailing list) now what for? Some things, which I could imagine would still be easier to implement correctly with "real handles", are the INVALID_HANDLE_VALUE value, checking that a thread does not access a resource via an already released handle and in general checking in a precise manner if a handle value is valid (which, as I understand it, is often done in wine with a magic value at the beginning of the object.) Greetings, Michael -- Michael Jung, MSc Be liberal in what you accept, Integrated Circuits and Systems Lab and conservative in what you send. University of Technology, Darmstadt -- Jonathan Postel, Internet Pioneer phone: +49(6151)16-6692 / email: mjung(a)iss.tu-darmstadt.de

1 0

Is bugzilla worth keeping?
by Mike Hearn 29 Jul '04

29 Jul '04

One thing I notice about most other open source projects is that they have many more flamewars than we do. So, I thought I'd start one: It strikes me, looking at the wine-bugs list, that there is a huge disparity between the number of people maintaining it and the number of people filing bugs in it. It seems to be quite rare for communication on bugfixes to take place there, wine-devel is the more usual forum. So are we misleading users by having a bugzilla into thinking that if they file a bug there, it'll be fixed when it probably won't? If so, does it matter? If we were to simply drop bugzilla, how would it impact the project? Thoughts, anybody? thanks -mike

10 10

winetests/winrash
by James Hawkins 29 Jul '04

29 Jul '04

What is it exactly that winrash does? Is it running winetests using the native libraries of the Windows operating system that the user is running the tests on, or are the wine libraries being tested through some means? Is there a site where this information is readily available? I have one suggestion: users typically like to see results when they volunteer their computer time to a project such as this, which is understandable, so a future version might benefit from a system tray icon that can be opened up to see the test running and/or display results of the tests that have been run. -- James Hawkins

2 1

How do we handle unicode (utf-8) codepages?
by Shachar Shemesh 29 Jul '04

29 Jul '04

What do we do if the user requests a Unicode codepage? I've just had a conversation with a user on IRC where I believe things didn't work for him because LANG was set to es_ES.UTF-8. On one hand, I don't think we can force ANSI applications to work in Unicode. On the other hand, we cannot change the locale - it will mean noone (whether ANSI or not) will not be able to access non-ASCII file names and files. Comments? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: Re: WineHQ:service.cgi: fix winrash option
by chmorgan＠charter.net 28 Jul '04

28 Jul '04

Which errors are you referring to? The most frequent ones lately are the ones where the winetest package isn't available on the sourceforge osdn mirror. We are still asking people to download the tests from this location for particular test releases. I'd imagine the fix is simply to point the downloads at valid mirror for the file. Chris > > From: Ferenc Wagner <wferi(a)afavant.elte.hu> > Date: 2004/07/26 Mon AM 07:57:51 EDT > To: wine-devel(a)winehq.org > CC: <wine-patches(a)winehq.com>, <cmorgan(a)alum.WPI.EDU> > Subject: Re: WineHQ:service.cgi: fix winrash option > > <chmorgan(a)charter.net> writes: > > > What is the service doing with winrash options btw? The > > installer stops, installs and starts the winrash service. > > > > The installer uses /S for silent installs, otherwise it > > will try to popup windows. Are you sure the service isn't > > calling the installer with /S? > > You are right, I was wrong. This patch is rubbish. I can't > really understand the errors on wine-test-results. Have you > got an idea what may have gone wrong? Aren't any functional > winrash instances running? Is something broken in the > service script? The documentation is somewhat scarce so I'm > doing a slow start... > -- > Feri. > >

2 1

Re: DCOM: Fix Ref Counting in StdMarshalImpl_MarshalInterface
by Robert Shearman 28 Jul '04

28 Jul '04

Robert Shearman wrote: > Changelog: > > Mike Hearn <mh(a)codeweavers.com> > Fix ref counting in StdMarshalImpl_MarshalInterface for case where the > stub already exists. > >Index: wine/dlls/ole32/compobj_private.h >=================================================================== >RCS file: /home/wine/wine/dlls/ole32/compobj_private.h,v >retrieving revision 1.14 > Oops. Wrong patch. Rob

1 0

Re: COM RPC: Fix Infinite Loop
by Robert Shearman 28 Jul '04

28 Jul '04

Robert Shearman wrote: > Changelog: > Fix for infinite loop that could occur if _invoke_onereq failed. Please don't apply this patch. I'll submit a better and more complete one in a minute. Rob

1 0

Non-working patch for 3GB of memory allocation
by Shachar Shemesh 28 Jul '04

28 Jul '04

Ok, this patch would probably not be appropriate even if it did work. The surprising thing, however, is that it doesn't. The idea was simple. We use mmap as usual until mmap starts to fail with no memory. When that happens, we switch to allocating memory with malloc, which allegably knows how to use "brk" in order to allocate memory from the lower 1GB area. The patch is against 20040716. The attached program tries to repeatedly allocate ~100MB, until it fails. It is compiled for advanced server (i.e. - it has 3GB of address space, but that's besides the point). When actually run (through strace), one can see the mmaps being carried out and successful, and then the mmap that fails (no memory). Then malloc is attempted, which tries mmap, then brk, and then mmap again. All fail. This is the point where I stop understanding. Does anyone have any explanation as to why malloc fails? Does wine prevent large scale use of the lower area due to some reason? Any ideas would be appreciated. Shachar ? runconfig ? dlls/ntdll/.virtual.c.swp Index: dlls/ntdll/virtual.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/virtual.c,v retrieving revision 1.37 diff -u -r1.37 virtual.c --- dlls/ntdll/virtual.c 22 Jun 2004 03:02:35 -0000 1.37 +++ dlls/ntdll/virtual.c 26 Jul 2004 13:53:41 -0000 @@ -78,6 +78,7 @@ /* Per-view flags */ #define VFLAG_SYSTEM 0x01 /* system view (underlying mmap not under our control) */ #define VFLAG_VALLOC 0x02 /* allocated by VirtualAlloc */ +#define VFLAG_MALLOC 0x04 /* allocated using malloc */ /* Conversion from VPROT_* to Win32 flags */ static const BYTE VIRTUAL_Win32Flags[16] = @@ -168,9 +169,13 @@ DPRINTF( "View: %p - %p", addr, addr + view->size - 1 ); if (view->flags & VFLAG_SYSTEM) DPRINTF( " (system)\n" ); - else if (view->flags & VFLAG_VALLOC) - DPRINTF( " (valloc)\n" ); - else if (view->mapping) + else if (view->flags & VFLAG_VALLOC) { + DPRINTF( " (valloc" ); + if (view->flags & VFLAG_MALLOC) + DPRINTF( " using malloc)\n" ); + else + DPRINTF( ")\n" ); + } else if (view->mapping) DPRINTF( " %p\n", view->mapping ); else DPRINTF( " (anonymous)\n"); @@ -348,7 +353,12 @@ */ static void delete_view( struct file_view *view ) /* [in] View */ { - if (!(view->flags & VFLAG_SYSTEM)) unmap_area( view->base, view->size ); + if (!(view->flags & VFLAG_SYSTEM)) { + if( !(view->flags & VFLAG_MALLOC) ) + unmap_area( view->base, view->size ); + else + free( view->base ); + } list_remove( &view->entry ); if (view->mapping) NtClose( view->mapping ); free( view ); @@ -559,6 +569,7 @@ { void *ptr; NTSTATUS status; + int used_malloc=0; if (base) { @@ -602,7 +613,19 @@ { if ((ptr = wine_anon_mmap( NULL, view_size, VIRTUAL_GetUnixProt(vprot), 0 )) == (void *)-1) { - if (errno == ENOMEM) return STATUS_NO_MEMORY; + if (errno == ENOMEM) + { + /* mmap allocation failed. Let's see if we can try malloc, and whether it is going to be more lucky */ + FIXME("About to try malloc\n"); + if( /* Unix protection is not malloc compatible, or */ (ptr = malloc( size ))!=NULL ) + { + used_malloc=1; + goto memory_allocated; + } else { + FIXME("malloc failed\n"); + return STATUS_NO_MEMORY; + } + } return STATUS_INVALID_PARAMETER; } /* if we got something beyond the user limit, unmap it and retry */ @@ -623,8 +646,17 @@ munmap( (char *)ptr + size, view_size - size ); } +memory_allocated: status = create_view( view_ret, ptr, size, vprot ); - if (status != STATUS_SUCCESS) unmap_area( ptr, size ); + if( used_malloc && status==STATUS_SUCCESS ) + (*view_ret)->flags|=VFLAG_MALLOC; + else if (status != STATUS_SUCCESS) + { + if( !used_malloc ) + unmap_area( ptr, size ); + else + free( ptr ); + } return status; }

2 6

delayed unloading of .so in WINE
by Santosh Siddheshwar 28 Jul '04

28 Jul '04

Hi, Is there any way to specify in config file or any other place, a way to prevent/delay a shared object from being unloaded till the application using it terminates? In dlopen there is a flag RTLD_NODELETE which keeps the loaded shared object in memory even after dlclose is called. The shared object is unloaded only when the app exits. Do we have some way to do this in WINE? Or does any feature in Windows necessitate implementing this kind of behaviour in WINE? I can think of VC++ linker flags /DELAYLOAD and /DELAY:unload which might need the use of such mechanism. Regards Santosh Siddheshwar ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

generation date/version of the (online) wine documentation
by Jeroen Janssen 28 Jul '04

28 Jul '04

Hi, I have a few questions: * is it possible to add the date/version in the online wine documentation at http://www.winehq.com/site/documentation (for the user, devel docs) * when exactly are these pages generated? (nightly/daily/?) best regards, Jeroen

2 1

handling IUnknown/IRemUnknown for (outproc) objects
by Jeroen Janssen 28 Jul '04

28 Jul '04

Hello, After last weeks discussion on the "unhandled interface" message in CFProxy_QueryInterface I was getting, we concluded (if I'm correct) that this is part of the "IRemUnknown" handling that is not (yet) implemented correctly in the wine CVS tree. I'm trying to figure out exactly where in the (OLE) code, this should be handled. If someone could point me in the right direction I would appreciate it very much. I think it would also be helpfull if there was some "fixme" logging so other people can also see if they hit upon the same problem (since it took a while to finally figure out the problem). --- Jeroen

3 3

Re: change the nt service pack version from 6 to 6a, correct win2k3 name
by Ivan Leo Puoti 28 Jul '04

28 Jul '04

I've found this hex value in user32.dll 5e07c is this good or bad? Ivan.

1 0

Re: DCOM: Document wrong behaviour for IRunningObjectTable
by Robert Shearman 28 Jul '04

28 Jul '04

Robert Shearman wrote: > Changelog: > Document wrong behaviour for IRunningObjectTable. Sorry, the changelog for this patch should have been as follows: Mike Hearn <mh(a)codeweavers.com> Robert Shearman <rob(a)codeweavers.com> Document wrong behaviour for IRunningObjectTable.

1 0

Re: change the nt service pack version from 6 to 6a, correct win2k3 name
by Andreas Mohr 28 Jul '04

28 Jul '04

Hi, On Wed, Jul 28, 2004 at 11:39:30AM +0200, Ivan Leo Puoti wrote: > I'm not 100% sure this patch is correct, please let me know if it isn't. > BTW at line 342 of dlls/ntdll/version.c I read /* FIXME: Not sure, should be > verified with a Win2K3 dll */ > how can this be verified? Easy, take several W2K3 system DLLs and kick them through winedump (or pedump.exe) to verify whether their RtlImageNtHeader(hmod)->OptionalHeader.MajorOperatingSystemVersion value (i.e. their MajorOperatingSystemVersion value) is 7 like our Wine code assumes here. Otherwise you'll have to find out other characteristic DLL version number differences of these DLLs compared to WinXP to be able to properly return the WIN2K3 version for these AND ONLY these... Andreas Mohr

1 0

icons contribuition
by Marcio Esper 28 Jul '04

28 Jul '04

Hello, My name is Marcio Esper. The Ivan tell me than I can send to you using this e-mail some icons. >We could do with some better icons, email wine-devel(a)winehq.com if you >want to contribute I made a new icon to be used with wine. 128x128, 64x64, 48x48, 32x32, 16x16. I hope you like it. The icons are made in Kpovmodeler on Mandrake linux 10 AMD64 and you can use and spread it without any restrition just geve me credits puting my name in the readmes and or were you think a good place to talk about it. ;p If we whant more models and sizes, let me know. Best regards, Marcio Esper

3 5

RelayExclude
by Diego 'Flameeyes' Pettenò 28 Jul '04

28 Jul '04

Hi, I've a question about RelayExclude setting in [Debug] section of ~/.wine/config : I was trying to debug the load of ClrMamePro watching at the relay output, but there's a lot of call of ntdll.RtlEnterCriticalSection ntdll.RtlLeaveCriticalSection and so on. I already added them to RelayExclude last year when I debugged another app, but seems like now this setting is ignored. I also tried to add the complete ntdll.RtlEnterCriticalSection name, but nothing changed. Any suggestion? TIA, -- Diego "Flameeyes" Pettenò dgp85(a)users.sourceforge.net - http://flameeyes.web.ctonet.it/

4 3

Re: Make wine honor LC_CTYPE and LC_MESSAGES
by Dmitry Timoshkov 28 Jul '04

28 Jul '04

"Shachar Shemesh" <shachar(a)lingnu.com> wrote: > http://support.microsoft.com/default.aspx?scid=kb;en-us;258047 says you > are wrong. My personal experience says you are wrong too, but that's > besides the point. You are misinterpreting that MSDN article, especially part about user locale. Since there is no official API to change user locale, what they call user locale settings are registry overrides for locale data. I already mentioned that on my english win2k with locale in Control Panel set to russian both GetSystemDefaultLCID and GetUserDefaultLCID return 0419 (russian). That dismisses MSDN and your statements. Thread locale is completely unrelated thing. -- Dmitry.

2 1

AmigaOS4
by Manuel Fink 27 Jul '04

27 Jul '04

Hello I has here a small question. That appeared Amiga OS4 Prerelease for some time and it seems a good and stable system to be. will it give in the near future WINE also for the AmigaOS4? Greeting Manuel

1 0

MUI setup - preliminary conclusions
by Shachar Shemesh 27 Jul '04

27 Jul '04

Ok, here is the preliminary conclusions from Windows XP MUI: There are two setups in the system. One is the "language for the default user and new user accounts". It affects the language people get when they create a new user, and the language the login dialog is in. To change that one, you need to run the MUI setup program. A restart is needed to change this. The second is an extra dialog in the Regional Settings dialog under the "languages" tab, and it selects the language the current user will have. You need to log off and log on in order to change this one. At the moment, my system is set up with English, Hebrew and Italian installed. I'm trying to figure out what exactly is passed to FindResourceEx when FindResource is called. So far, it seems that "LANG_NEUTRAL, SUBLANG_NEUTRAL" is used, but it's not definite yet. One thing of interest, however, is that when LANG_NEUTRAL, SUBLANG_DEFAULT is passed, the lookup is for the language used in the second case (the user UI language), and when LANG_NEUTRAL, SUBLANG_SYS_DEFAULT, the first one is used. It seems to me that there is no need for wine to support two separate languages here. Does anyone disagree with this? Given the above settings, my current test program currently tests the order between English(US), English(UK), English(Neutral), Italian(Italy), Italian(Neutral), Hebrew(Default), Hebrew(Neutral), Neutral and Neutral(Default). Are there any other languages I should test for order by? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

Re: DCOM: Pass -Embedding switch to EXE servers, more tracing
by Jeroen Janssen 27 Jul '04

27 Jul '04

James Hawkins wrote: >WCHAR is a wide (unicode) character. sizeof(embedding)/sizeof(WCHAR) >will return the length of the strength in characters and not the size >of it if I'm not mistaken. > > Yes, and I think you will want to have the length in characters when declaring a (C) array in the example code below: With static const WCHAR embedding[] = { ' ', '-','E','m','b','e','d','d','i','n','g',0 }; You will want WCHAR command[MAX_PATH+(sizeof(embedding)/sizeof(WCHAR)+1]; instead of WCHAR command[MAX_PATH+sizeof(embedding)+1]; Because if sizeof(WCHAR) == 2, then command will be strlen(embedding) to large. >On Mon, 26 Jul 2004 18:24:48 +0200, Jeroen Janssen <japj(a)xs4all.nl> wrote: > > >>Mike Hearn wrote: >> >> >>>ChangeLog: >>>Pass -Embedding switch to EXE servers, more tracing >>> >>> >>>diff -u -p -r1.15 rpc.c >>>--- dlls/ole32/rpc.c 15 Jul 2004 22:07:44 -0000 1.15 >>>+++ dlls/ole32/rpc.c 21 Jul 2004 22:43:59 -0000 >>>@@ -471,8 +471,10 @@ create_server(REFCLSID rclsid) { >>> char buf[200]; >>> HRESULT hres = E_UNEXPECTED; >>> char xclsid[80]; >>>- WCHAR dllName[MAX_PATH+1]; >>>- DWORD dllNameLen = sizeof(dllName); >>>+ WCHAR exe[MAX_PATH+1]; >>>+ DWORD exelen = sizeof(exe); >>>+ static const WCHAR embedding[] = { ' ', '-','E','m','b','e','d','d','i','n','g',0 }; >>>+ WCHAR command[MAX_PATH+sizeof(embedding)+1]; >>> >>> >>On a side note, what exactly is a WCHAR? >>Is it a 'char' or a 'unicode char' (2bytes)? >> >>This in relation to sizeof(embedding) instead of >>sizeof(embedding)/sizeof(WCHAR)? >>--- >>Jeroen >> >> >> >> > > > >

2 2

Re: Make wine honor LC_CTYPE and LC_MESSAGES
by Shachar Shemesh 27 Jul '04

27 Jul '04

Following a discussion with Alexandre on IRC, here is a revised patch. This one doesn't touch the LC_MESSAGE, as these do not affect the user locale. Further work will be necessary on supporting MUI like language checking. Shachar Shemesh wrote: > Changelog: > Shachar Shemesh <winecode(a)shemesh.biz> > dlls/kernel/locale.c > > * System default locale in Windows determines the ANSI encoding > (LC_CTYPE on Unix) -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

5 18

dinput.dll: mouse didn't work
by Michael Schlüter 26 Jul '04

26 Jul '04

Hi, I've a small problem with wine (cvs from today) when trying to play a game that uses dinput.dll. The game starts fine, keyboard inputs works but the mouse cursor didn't move. I had a look at the source code of dinput/mouse.c and the trace messages of dinput. But there is one thing I don't understand. The callback function for the mouse (dinput_mouse_hook) is never called. The initialising look good: trace:dinput:SysMouseAImpl_Acquire (this=0x40269480) trace:hook:set_windows_hook WH_MOUSE_LL 0x40dd64e0 0 -> 0x20028 trace:dinput:SysMouseAImpl_Acquire Warping mouse to 512 - 384 trace:dinput:SysKeyboardAImpl_Unacquire (this=0x40269db8) trace:dinput:SysKeyboardAImpl_SetEventNotification (this=0x40269db8,0x00000124) trace:dinput:SysKeyboardAImpl_Acquire (this=0x40269db8) trace:dinput:SysKeyboardAImpl_Acquire (this=0x40269db8) trace:dinput:SysMouseAImpl_Acquire (this=0x40269480) ... And later when pressing a mouse button: trace:hook:HOOK_CallHooks calling hook in thread 0013 WH_MOUSE_LL code 0 wp 200 lp 4071d074 But then there is no other dinput message. Shouldn't there be a call of the mouse callback function? Bye, Michael

3 6

LockWindowUpdate status
by Diego 'Flameeyes' Pettenò 26 Jul '04

26 Jul '04

Hi, I was trying to debug wine while using ClrMamePro to fix the Bug #2387 I reported (the main windows doesn't reappear after it's hide). The way of ShowWindow() function seems not to be the right one, because it seems not to be called when the window should shown up after hide. So I started following the messages way, starting by fixme:dc:LockWindowUpdate ((nil)), partial stub! fixme:dc:LockWindowUpdate (0x4007a), partial stub! fixme:dc:LockWindowUpdate ((nil)), partial stub! which seems to be more likely to be wine error than err:dc:DCE_FreeWindowDCE [0x30094] GetDC() without ReleaseDC()! which seems (at a first sight) a program error. So I opened windows/dce.c to search for the function, and I found a Mike's comment: /* This function is fully implemented by the following patch: * * http://www.winehq.org/hypermail/wine-patches/2004/01/0142.html * * but in order to work properly, it needs the ability to invalidate * DCEs in other processes when the lock window is changed, which * isn't possible yet. * -mike */ at this point I downloaded the patch and tried to apply but seems not to be appliable automatically (I'll try to apply it by hand because I haven't time now). My question is if there's some update on the status of LockWindowUpdate, because Mike's comment seems to point out that the patch won't work properly. It this is unrelated to my problem, I think I'll start trying random things to found out where the problem is :) Regards, -- Diego "Flameeyes" Pettenò dgp85(a)users.sourceforge.net - http://flameeyes.web.ctonet.it/

2 1

Re: Localization of devenum and minor corrections
by Marcelo Duarte 26 Jul '04

26 Jul '04

Resend. Changelog: Marcelo Duarte <wine-devel(a)bol.com.br> Localization to Portuguese (devenum) and minor corrections (winmm, progman, winmine). Index: dlls/devenum/devenum.rc =================================================================== RCS file: /home/wine/wine/dlls/devenum/devenum.rc,v retrieving revision 1.7 diff -u -u -r1.7 devenum.rc --- dlls/devenum/devenum.rc 23 Jul 2004 19:08:44 -0000 1.7 +++ dlls/devenum/devenum.rc 26 Jul 2004 21:36:02 -0000 @@ -51,3 +51,12 @@ 9 "Dispositivo WaveOut di Default" 10 "Dispositivo MidiOut di Default" } + +STRINGTABLE DISCARDABLE +LANGUAGE LANG_PORTUGUESE, SUBLANG_DEFAULT +{ + 7 "DirectSound padrão" + 8 "DirectSound: %s" + 9 "Dispositivo padrão WaveOut" + 10 "Dispositivo padrão MidiOut" +} Index: dlls/winmm/winmm_res.rc =================================================================== RCS file: /home/wine/wine/dlls/winmm/winmm_res.rc,v retrieving revision 1.15 diff -u -u -r1.15 winmm_res.rc --- dlls/winmm/winmm_res.rc 13 Jul 2004 23:36:37 -0000 1.15 +++ dlls/winmm/winmm_res.rc 26 Jul 2004 21:36:10 -0000 @@ -1,4 +1,4 @@ -/* Multimedia resources (MMSYSTEM.DLL & WINMM.DLL +/* Multimedia resources (MMSYSTEM.DLL & WINMM.DLL) * * Copyright (c) 1999, Eric Pouech * Index: programs/progman/Pt.rc =================================================================== RCS file: /home/wine/wine/programs/progman/Pt.rc,v retrieving revision 1.5 diff -u -u -r1.5 Pt.rc --- programs/progman/Pt.rc 4 Oct 2003 04:21:19 -0000 1.5 +++ programs/progman/Pt.rc 26 Jul 2004 21:36:14 -0000 @@ -38,7 +38,7 @@ MENUITEM "Sai&r do Windows...", PM_EXIT } POPUP "&Opções" { - MENUITEM "&Autoorganizar", PM_AUTO_ARRANGE + MENUITEM "&Auto organizar", PM_AUTO_ARRANGE MENUITEM "&Minimizar na execução", PM_MIN_ON_RUN MENUITEM "&Salvar alterações ao sair", PM_SAVE_SETTINGS } Index: programs/winemine/rsrc.rc =================================================================== RCS file: /home/wine/wine/programs/winemine/rsrc.rc,v retrieving revision 1.15 diff -u -u -r1.15 rsrc.rc --- programs/winemine/rsrc.rc 19 Jul 2004 19:34:26 -0000 1.15 +++ programs/winemine/rsrc.rc 26 Jul 2004 21:36:18 -0000 @@ -32,14 +32,13 @@ #include "Ru.rc" #include "Si.rc" +LANGUAGE LANG_NEUTRAL,SUBLANG_NEUTRAL IDA_WINEMINE ACCELERATORS DISCARDABLE { VK_F2, IDM_NEW, VIRTKEY, NOINVERT "X", IDM_EXIT, VIRTKEY, ALT, NOINVERT } - -LANGUAGE LANG_NEUTRAL,SUBLANG_NEUTRAL /* BINRES winemine.ico */ WINEMINE ICON MOVEABLE winemine.ico

1 0

Re: server/context_i386.c
by Joe Gainey 26 Jul '04

26 Jul '04

here are the build errors I am seeing: make[2]: Leaving directory `/home/viper/d/jgainey/build/WINE/wine-20040716/programs/winhelp' make[2]: Entering directory `/home/viper/d/jgainey/build/WINE/wine-20040716/programs/winver' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/viper/d/jgainey/build/WINE/wine-20040716/programs/winver' make[1]: Leaving directory `/home/viper/d/jgainey/build/WINE/wine-20040716/programs' make[1]: Entering directory `/home/viper/d/jgainey/build/WINE/wine-20040716/server' gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o context_i386.o context_i386.c context_i386.c: In function `get_thread_context': context_i386.c:241: `PT_GETREGS' undeclared (first use in this function) context_i386.c:241: (Each undeclared identifier is reported only once context_i386.c:241: for each function it appears in.) context_i386.c:276: `PT_GETFPREGS' undeclared (first use in this function) context_i386.c: In function `set_thread_context': context_i386.c:295: `PT_GETREGS' undeclared (first use in this function) context_i386.c:322: `PT_SETREGS' undeclared (first use in this function) context_i386.c:332: `PT_SETFPREGS' undeclared (first use in this function) make[1]: *** [context_i386.o] Error 1 make[1]: Leaving directory `/home/viper/d/jgainey/build/WINE/wine-20040716/server' make: *** [server] Error 2

1 0

Re: DCOM: Pass -Embedding switch to EXE servers, more tracing
by Jeroen Janssen 26 Jul '04

26 Jul '04

Mike Hearn wrote: > ChangeLog: > Pass -Embedding switch to EXE servers, more tracing > diff -u -p -r1.15 rpc.c > --- dlls/ole32/rpc.c 15 Jul 2004 22:07:44 -0000 1.15 > +++ dlls/ole32/rpc.c 21 Jul 2004 22:43:59 -0000 > @@ -471,8 +471,10 @@ create_server(REFCLSID rclsid) { > char buf[200]; > HRESULT hres = E_UNEXPECTED; > char xclsid[80]; > - WCHAR dllName[MAX_PATH+1]; > - DWORD dllNameLen = sizeof(dllName); > + WCHAR exe[MAX_PATH+1]; > + DWORD exelen = sizeof(exe); > + static const WCHAR embedding[] = { ' ', '-','E','m','b','e','d','d','i','n','g',0 }; > + WCHAR command[MAX_PATH+sizeof(embedding)+1]; On a side note, what exactly is a WCHAR? Is it a 'char' or a 'unicode char' (2bytes)? This in relation to sizeof(embedding) instead of sizeof(embedding)/sizeof(WCHAR)? --- Jeroen

2 1

idl compiler & generating proxy/stub code?
by Jeroen Janssen 26 Jul '04

26 Jul '04

Hi, Is anyone aware of a (free) idl compiler that can also generate proxy/stub code for usage with wine? As far as I understand widl can not generate proxy/stub code (yet). Also, I'm wondering if it would be possible to translate idl to XML and then with XSLT 'transform' into proxy/stub code. --- Jeroen Janssen

1 0

rsabase.dll
by Michael Jung 26 Jul '04

26 Jul '04

Rob, as far as I can tell from looking at your patch, our work is pretty much non overlapping. I worked on the following aspects: - Implementation of "real handles", instead of "address-handles". - Separating OpenSSL dependend code from CSP code. I consider this beneficial, since there seem to be some license issues with OpenSSL (at least for the ReactOS project - there was a short discussion on this on the wine-devel list). If the OpenSSL code is cleanly separated, it will be easier to support GNUTLS or something later. - Basically, my code doesn't do any crypto stuff at all until now (Besides some first lines of code for MD5 hashing). I tried to get the MSDN CryptoAPI examples to compile and run, which only acquire contexts, hash data, derive keys, query CSP params and so on, but which never verify the results. So my code is mainly skin (but elephant skin), no guts. I've attached the current version of my patch. Do you have a certain application, which you want to get running? Would it be ok for you if we proceed as follows: I will wait until you submit your patch (It would be nice if you could add some unit-tests that test for behaviour you depend on). After this you give me a week or two to incorporate my work. Is there any area in rsabase, which you definitely will not implement in the near future and which I could work on until you submit your patch? Greetings, Michael

2 2

Re: WineHQ:service.cgi: fix winrash option
by Ferenc Wagner 26 Jul '04

26 Jul '04

<chmorgan(a)charter.net> writes: > What is the service doing with winrash options btw? The > installer stops, installs and starts the winrash service. > > The installer uses /S for silent installs, otherwise it > will try to popup windows. Are you sure the service isn't > calling the installer with /S? You are right, I was wrong. This patch is rubbish. I can't really understand the errors on wine-test-results. Have you got an idea what may have gone wrong? Aren't any functional winrash instances running? Is something broken in the service script? The documentation is somewhat scarce so I'm doing a slow start... -- Feri.

1 0

problems with lxr setup at winehq?
by Jeroen Janssen 26 Jul '04

26 Jul '04

Hi, I'm trying to use the lxr setup for wine at winehq, but it doesn't seem to work correctly (or I'm doing something wrong). I'm looking for all sourcefiles containing "ClassFactory", following this link: http://source.winehq.org/search?string=ClassFactory . The result I am getting is 'empty'. Does anyone with access to the lxr setup know what the problem is? (and maybe fix it?) --- Jeroen

1 0

Re: Scrollbars, an application bug or a wine regression ? (#2314)
by Dmitry Timoshkov 26 Jul '04

26 Jul '04

"George Marshall" <g.marshall(a)nospam.com> wrote: > > Does reverting of the following patch help? > > Yes it does make the application work as it did before > the June Release :-) Do you have a small application I could test with? -- Dmitry.

4 16

Re: add autodetect audio driver capability to winmm
by Marcus Meissner 26 Jul '04

26 Jul '04

On Sun, Jul 25, 2004 at 05:08:04PM -0500, James Hawkins wrote: > Changelog: > * take audio autodetection out of winecfg and put it in winmm > * if driver is not found in the registry or the driver fails to > load, then autodetect driver This would make artsd the default driver on KDE systems. Most are still using the OSS driver, which might be of a better state. Ciao, Marcus

1 0

Re: add autodetect audio driver capability to winmm
by Robert Shearman 26 Jul '04

26 Jul '04

James Hawkins wrote: >Changelog: > * take audio autodetection out of winecfg and put it in winmm > * if driver is not found in the registry or the driver fails to >load, then autodetect driver > > Thanks for another cool patch. It lessens the burden on the user. CC'ing ros-kernel as explained below. >Index: dlls/winmm/lolvldrv.c >=================================================================== >RCS file: /home/wine/wine/dlls/winmm/lolvldrv.c,v >retrieving revision 1.58 >diff -u -r1.58 lolvldrv.c >--- dlls/winmm/lolvldrv.c 1 Jun 2004 19:40:48 -0000 1.58 >+++ dlls/winmm/lolvldrv.c 25 Jul 2004 22:05:54 -0000 >@@ -30,6 +30,8 @@ > #include "winver.h" > #include "winemm.h" > #include "wine/debug.h" >+#include "config.h" >+#include "wine/port.h" > > WINE_DEFAULT_DEBUG_CHANNEL(winmm); > >@@ -711,6 +713,80 @@ > } > > /************************************************************************** >+ * MMDRV_AutoDetectDriver [internal] >+ * >+ * modified from programs/winecfg/audio.c >+ */ >+BOOL MMDRV_AutoDetectDriver(void) >+{ >+ struct stat buf; >+ const char *argv_new[4]; >+ int fd; >+ >+ char *driversFound[10]; >+ char *name[10]; >+ int numFound = 0; >+ >+ argv_new[0] = "/bin/sh"; > I think the ReactOS people may have a few comments to make on this, now that they are using this DLL in ReactOS. >+ argv_new[1] = "-c"; >+ argv_new[3] = NULL; >+ >+ /* try to detect arts */ >+ argv_new[2] = "ps awx|grep artsd|grep -v grep|grep artsd > /dev/null"; >+ if(!spawnvp(_P_WAIT, "/bin/sh", argv_new)) >+ { >+ driversFound[numFound] = "winearts.drv"; >+ name[numFound] = "aRts"; >+ numFound++; >+ } >+ >+ /* try to detect jack */ >+ argv_new[2] = "ps awx|grep jackd|grep -v grep|grep jackd > /dev/null"; >+ if(!spawnvp(_P_WAIT, "/bin/sh", argv_new)) >+ { >+ driversFound[numFound] = "winejack.drv"; >+ name[numFound] = "jack"; >+ numFound++; >+ } >+ >+ /* try to detect nas */ >+ /* TODO */ >+ >+ /* try to detect audioIO (solaris) */ >+ /* TODO */ >+ >+ /* try to detect alsa */ >+ if(!stat("/proc/asound", &buf)) >+ { >+ driversFound[numFound] = "winealsa.drv"; >+ name[numFound] = "Alsa"; >+ numFound++; >+ } >+ >+ /* try to detect oss */ >+ fd = open("/dev/dsp", O_WRONLY | O_NONBLOCK); >+ if(fd) >+ { >+ close(fd); >+ driversFound[numFound] = "wineoss.drv"; >+ name[numFound] = "OSS"; >+ numFound++; >+ } >+ >+ >+ if (numFound == 0) >+ { >+ TRACE("Could not detect any audio devices/servers"); >+ return FALSE; >+ } >+ >+ /* TODO: possibly smarter handling of multiple drivers? */ >+ TRACE("Found driver %s\n", name[0]); >+ >+ return MMDRV_Install(driversFound[0], driversFound[0], FALSE); >+} >+ >+/************************************************************************** > * MMDRV_InitFromRegistry [internal] > */ > static BOOL MMDRV_InitFromRegistry(void) >@@ -729,7 +805,9 @@ > } > > size = sizeof(buffer); >- if (!RegQueryValueExA(hKey, "Drivers", 0, &type, (LPVOID)buffer, &size)) { >+ BOOL keyQueried = !RegQueryValueExA(hKey, "Drivers", 0, &type, >+ (LPVOID)buffer, &size); > This is only available in C99. We try to make Wine compile with as many C compilers as possible, including gcc 2.95, which doesn't allow this sort of thing. >+ if (keyQueried) { > p1 = buffer; > while (p1) { > p2 = strchr(p1, ';'); >@@ -738,7 +816,11 @@ > p1 = p2; > } > } >- >+ >+ /* if no driver specified in reg or driver fails to load then autodetect */ >+ if (!keyQueried || !ret) >+ ret |= MMDRV_AutoDetectDriver(); >+ > /* finish with mappers */ > size = sizeof(buffer); > if (!RegQueryValueExA(hKey, "WaveMapper", 0, &type, (LPVOID)buffer, &size)) > > Rob

4 6

Support for Palm USB Hotsync
by Harald Milz 25 Jul '04

25 Jul '04

Hi, I am new to this list (albeit not to Wine :-) my Wine usage dates back to 1993 when I interviewed Bob Amstadt in his home... ) Anyway - I have a problem with Palm USB hotsync which could perhaps be solved on the userspace level. As you all know, the Linux USB kernel code creates an in-kernel device (in this case, ttyUSB1) only when a connected device actually talks. With a Palm, this is only the case if one presses the hotsync button. This keeps me from running Hotsync permanently which I need to sync my Palm against Lotus Notes. As soon as I start Hotsync, it complains that the device is not there at all. Even if I press "hotsync" and start Hotsync immediately after that, no communication takes place. (pilot-xfer -p /dev/ttyUSB1 works just fine) Now, for Wine / Cxoffice, ttyUSB is merely a serial device. Wouldn't it be possible to modify the Wine code in a way to fake the open() call and return success to the caller, poll the actual device and open it as soon as it actually comes up? I would be willing to hack this in but I have no real idea where to look regarding the sheer size of the code. I suspect it's in server/serial.c but I am not sure. Any hint is welcome. Or does somebody have an idea how to work around this problem? Until recently, I used a serial hotsync cable but my new notebook has no serial port any more... and carrying an USBserial converter isn't really an option on the road. (IrDA could be an alternative but I couldn't get this to work with my T41 either, at least not with FIR). -- Try to be the best of whatever you are, even if what you are is no good.

2 1

winecfg todo list
by Mike Hearn 25 Jul '04

25 Jul '04

So, I talked with Chris and here are some tasks remaining on winecfg. All of these are *easy* and can be done by anybody who has basic coding ability. For a few of them you don't even really need to know C! So come on lurkers, I know you're out there, step on up. Things that need to be done before we should switch to winecfg IMHO are: * Windows Look has no associated edit control. Who modifies this setting these days anyway? I vote for killing the label rather than adding the edit. * UseTakeFocus (FIXME) - why is this a setting in the UI? I don't even know what the UseTakeFocus protocol does, I've certainly never tweaked it. Does it need to be there? At the very least it needs to be rephrased into terms people can understand and the FIXME needs to be removed. * In the Drives tab, the top half is full of widgetry we probably don't want anymore. In particular "Use real windows drive" etc doesn't make much sense, you can just change the c: mapping to get that effect and it's not something we want to encourage anyway. Especially as most people these days seem to use XP rather than Win98 using a real windows drive is fast way to get an inoperable Wine as well as (possibly) a torched Windows install if it's on FAT32 and you can even pick up viruses from them. I kid you not, the other day I ran a program that had been sitting on my Windows XP partition for a few months and my virtual windows drive (I think the term virtual rather than fake sounds better) ended up infected with some W32.Bagle variant. Anyway the top half of this tab doesn't do anything, never did, doesn't make any sense and should just be removed. * We should probably merge the X11 Driver and Audio tabs together as they both have lots of empty space, and rename it to "Audio and Video" or something. I think the term "X11 Driver" doesn't make much sense to many people anyway. Minor cosmetic fix: remove the groupbox on the "about" tab, it doesn't provide any information at all. We also may want to stick the authors list in there, as it's a bit more visible than in the shell32 about box which is hardly ever shown. But obviously these things should not block us switching to it. Once those things are done we can apply the patch to switch Wine to using the registry entirely. Is it worth writing a migration tool? I'm not really sure, I guess some people would like their settings preserved but most of the settings people tweak are just check boxes in the new UI anyway and would take like 5 seconds to restore. AppDefaults are a bigger issue but do many people have lots of these? Oh, final thing, we need to double check that removing the config doesn't regress things. I've been running with no config file for a few months now and while there are a few minor things I don't think they are critical. I may well have missed things though. thanks -mike

2 2

Invalid path L"c:\\WINDOWS" for L"windows" directory: does not exist
by Andreas Davour 25 Jul '04

25 Jul '04

Hi! I try to use wine v.20040505 on FreeBSD5.2 and I just get the error in the subject line. I found another post about this and that OP was just told to check the "dosdevices" directly, since I have such a directory and I don't get any closer to a solution by staring uncomprehending at the files I thought maybe someone could give a wine newbie some more ideas on what to do? I didn't find any "C:" in that directory mentioned, and tried to make a c: synlink to a new directory without any more success. /andreas

3 3

Marshalling tutorial
by Mike Hearn 25 Jul '04

25 Jul '04

Hi guys, Here is the start of some notes on DCOM and OLE RPC. They're intended to help people like Duane who are hitting problems caused by it, and possibly to form the basis of some decent documentation for the developer guide. Things that only a few people understand make me nervous, getting this stuff into writing will maybe help increase the number of people working on Wine - at the very least it means when people move on we're not left stranded. Firstly, even though this is a reasonably high level overview it's not exactly bed time reading. DCOM is massively complex, and tends to abuse and duplicate terminology rampantly. If you read this and get confused or don't understand it DON'T PANIC! That's perfectly normal. I'll use the term "DCOM" to refer to all aspects of COM and OLE marshalling though other terms could certainly be used too. DCOM is a huge, sprawling part of the Windows API and it's impossible to cover it all in one email. If people find this helpful maybe I'll write some more. I'll assume a basic knowledge of COM (interfaces, IUnknown, refcounts etc). The basics are well documented and there are plenty of tutorials on the net. Secondly, my understanding is not 100% complete and is still improving. There may well be mistakes and omissions here. Hopefully Ove, Marcus, Huw or somebody with a better understanding than I, will review it and correct me. BASICS The basic idea behind DCOM is to take a COM object and make it location transparent. That means you can use it from other threads, processes and machines without having to worry about the fact that you can't just dereference the interface vtable pointer to call methods on it. You might be wondering about putting threads next to processes and machines in that last paragraph. You can access thread safe objects from multiple threads without DCOM normally, right? Why would you need RPC magic to do that? Well, the details of why you'd want to do that can be left until later. For now, suffice it to say that COM lets you "marshal" interfaces into other "apartments". An apartment (you may see it referred to as a context in modern versions of COM) can be thought of as a location, and contains objects. Every thread in a program that uses COM exists in an apartment. If a thread wishes to use an object from another apartment, marshalling and the whole DCOM infrastructure gets involved to make that happen behind the scenes. So. Each COM object resides in an apartment, and each apartment resides in a process, and each process resides in a machine, and each machine resides in a network. Allowing those objects to be used from *any* of these different places is what DCOM is all about. The process of marshalling refers to taking a function call in an apartment and actually performing it in another apartment. Let's say you have two machines, A and B, and on machine B there is an object sitting in a DLL on the hard disk. You want to create an instance of that object (activate it) and use it as if you had compiled it into your own program. This is hard, because the remote object is expecting to be called by code in its own address space - it may do things like accept pointers to linked lists and even return other objects. Very basic marshalling is easy enough to understand. You take a method on a remote interface, copy each of its parameters into a buffer, and send it to the remote computer. On the other end, the remote server reads each parameter from the buffer, calls the method, writes the result into another buffer and sends it back. The tricky part is exactly how to encode those parameters in the buffer, and how to convert standard stdcall/cdecl method calls to network packets and back again. This is the job of the RPCRT4.DLL file - or the Remote Procedure Call Runtime. The backbone of DCOM is this RPC runtime, which is an implementation of DCE RPC [1]. DCE RPC is not naturally object oriented, so this protocol is extended with some new constructs and by assigning new meanings to some of the packet fields, to produce ORPC or Object RPC. You might see it called MS-RPC as well. RPC packets contain a buffer containing marshalled data in NDR format. NDR is short for "Network Data Representation" and is similar the XDR format used in SunRPC (the closest native equivalent on Linux to DCE RPC). NDR/XDR are all based on the idea of graph serialization and were worked out during the 80s, meaning they are very powerful and can do things like marshal doubly linked lists and other rather tricky structures. In Wine, our DCOM implementation is *not* based on the RPC runtime, as while few programs use DCOM even fewer use RPC directly so it was developed some time after OLE32/OLEAUT32 were. Eventually this will have to be fixed, otherwise our DCOM will never be compatible with Microsofts. Bear this in mind as you read through the code however. PROXIES AND STUBS Manually marshalling and unmarshalling each method call using the NDR APIs (NdrConformantArrayMarshall etc) is very tedious work, so the Platform SDK ships with a tool called "midl" which is an IDL compiler. IDL or the "Interface Definition Language" is a tool designed specifically for describing interfaces in a reasonably language neutral fashion, though in reality it bears a close resemblence to C++. By describing the functions you want to expose via RPC in IDL therefore, it becomes possible to pass this file to MIDL which spits out a huge amount of C source code. That code defines functions which have the same prototype as the functions described in your IDL but which internally take each argument, marshal it using Ndr, send the packet, and unmarshal the return. Because this code proxies the code from the client to the server, the functions are called proxies. Easy, right? Of course, in the RPC server process at the other end, you need some way to unmarshal the RPCs, so you have functions also generated by MIDL which are the inverse of the proxies: they accept an NDR buffer, extract the parameters, call the real function then marshal the result back. They are called stubs, and stand in for the real calling code in the client process. The sort of marshalling/unmarshalling code that MIDL spits out can be seen in dlls/oleaut32/oaidl_p.c - it's not exactly what it would look like as that file contains DCOM proxies/stubs which are different, but you get the idea. Proxy functions take the arguments and feel them to the NDR marshallers (or picklers), invoke an NdrProxySendReceive and then convert the out parameters and return code. There's a ton of goop in there for dealing with buffer allocation, exceptions and so on - it's really ugly code. But, this is the basic concept behind DCE RPC. INTERFACE MARSHALLING Standard NDR only knows about C style function calls - they can accept and even return structures, but it has no concept of COM interfaces. Confusingly DCE RPC *does* have a concept of RPC interfaces which are just convenient ways to bundle function calls together into namespaces, but let's ignore that for now as it just muddies the water. The primary extension made by Microsoft to NDR then was the ability to take a COM interface pointer and marshal that into the NDR stream. The basic theory of proxies and stubs and IDL is still here, but it's been modified slightly. Whereas before you could define a bunch of functions in IDL, now a new "object" keyword has appeared. This tells MIDL that you're describing a COM interface, and as a result the proxies/stubs it generates are also COM objects. That's a very important distinction. When you make a call to a remote COM object you do it via a proxy object that COM has constructed on the fly. Likewise, a stub object on the remote end unpacks the RPC packet and makes the call. Because this is object-oriented RPC, there are a few complications: for instance, a call that goes via the same proxies/stubs may end up at a different object instance, so the RPC runtime keeps track of "this" and "that" in the RPC packets. This leads naturally onto the question of how we got those proxy/stub objects in the first place, and where they came from. You can use the CoCreateInstanceEx API to activate COM objects on a remote machine, this works like CoCreateInstance API. Behind the scenes, a lot of stuff is involved to do this (like IRemoteActivation, IOXIDResolver and so on) but let's gloss over that for now. When DCOM creates an object on a remote machine, the DCOM runtime on that machine activates the object in the usual way (by looking it up in the registry etc) and then marshals the requested interface back to the client. Marshalling an interface takes a pointer, and produces a buffer containing all the information DCOM needs to construct a proxy object in the client, a stub object in the server and link the two together. The structure of a marshalled interface pointer is somewhat complex. Let's ignore that too. The important thing is how COM proxies/stubs are loaded. COM PROXY/STUB SYSTEM COM proxies are objects that implement both the interfaces needing to be proxied and also IRpcProxyBuffer. Likewise, COM stubs implement IRpcStubBuffer and understand how to invoke the methods of the requested interface. You may be wondering what the word "buffer" is doing in those interface names. I'm not sure either, except that a running theme in DCOM is that interfaces which have nothing to do with buffers have the word Buffer appended to them, seemingly at random. Ignore it and *don't let it confuse you* :) This stuff is convoluted enough ... The IRpc[Proxy/Stub]Buffer interfaces are used to control the proxy/stub objects and are one of the many semi-public interfaces used in DCOM. DCOM is theoretically an internet RFC [2] and is specced out, but in reality the only implementation of it apart from ours is Microsofts, and as a result there are lots of interfaces which *can* be used if you want to customize or control DCOM but in practice are badly documented or not documented at all, or exist mostly as interfaces between MIDL generated code and COM itself. Don't pay too much attention to the MSDN definitions of these interfaces and APIs. COM proxies and stubs are like any other normal COM object - they are registered in the registry, they can be loaded with CoCreateInstance and so on. They have to be in process (in DLLs) however. They aren't activated directly by COM however, instead the process goes something like this: - COM receives a marshalled interface packet, and retrieves the IID of the marshalled interface from it - COM looks in HKEY_CLASSES_ROOT/Interface/{whatever-iid}/ProxyStubClsId32 to retrieve the CLSID of another COM object, which implements IPSFactoryBuffer. - IPSFactoryBuffer has only two methods, CreateProxy and CreateStub. COM calls whichever is appropriate: CreateStub for the server, CreateProxy for the client. MIDL will normally provide an implementation of this object for you in the code it generates. Once CreateProxy has been called, the resultant object is QId to IRpcProxyBuffer, which only has 1 method, IRpcProxyBuffer::Connect [4] This method only takes one parameter, the IRpcChannelBuffer object which encapsulates the "RPC Channel" between the client and server. On the server side, a similar process is performed - the PSFactoryBuffer is created, CreateStub is called, result is QId to IRpcStubBuffer, and IRpcStubBuffer::Connect is used to link it to the RPC channel. RPC CHANNELS Remember the RPC runtime? Well, that's not just responsible for marshalling stuff, it also controls the connection and protocols between the client and server. We can ignore the details of this for now, suffice it to say that an RPC Channel is a COM object that implements IRpcChannelBuffer, and it's basically an abstraction of different RPC methods. For instance, in the case of inter-thread marshalling (not covered here) the RPC connection code isn't used, only the NDR marshallers are, so IRpcChannelBuffer in that case isn't actually implemented by RPCRT4 but rather just by the COM/OLE DLLS (fixme: is this actually correct?). RPC channels are constructed on the fly by DCOM as part of the marshalling process. So, when you make a call on a COM proxy, it goes like this: Your code -> COM proxy object -> RPC Channel -> COM stub object -> Their code HOW THIS ACTUALLY WORKS IN WINE Right now, Wine does not use the NDR marshallers or RPC to implement its DCOM. When you marshal an interface in Wine, in the server process a _StubMgrThread thread is started. I haven't gone into the stub manager here. The important thing is that eventually a _StubReaderThread is started which accepts marshalled DCOM RPCs, and then passes them to IRpcStubBuffer::Invoke on the correct stub object which in turn demarshals the packet and performs the call. The threads started by our implementation of DCOM are never terminated, they just hang around until the process dies. Remember that I said our DCOM doesn't use RPC? Well, you might be thinking "but we use IRpcStubBuffer like we're supposed to ... isn't that provided by MIDL which generates code that uses the NDR APIs?". If so pat yourself on the back, you're still with me. Go get a cup of coffee. TYPELIB MARSHALLER In fact, the reason for the PSFactoryBuffer layer of indirection is because you not all interfaces are marshalled using MIDL generated code. Why not? Well, to understand *that* you have to see that one of the driving forces behind OLE and by extension DCOM was the development Visual Basic. Microsoft wanted VB developers to be first class citizens in the COM world, but things like writing IDL and compiling them with a C compiler into DLLs wasn't easy enough. So, type libraries were invented. Actually they were invented as part of a parallel line of COM development known as "OLE Automation", but let's not get into that here. Type libraries are basically binary IDL files, except that despite there being two type library formats neither of them can fully express everything expressable in IDL. Anyway, with a type library (which can be embedded as a resource into a DLL) you have another option beyond compiling MIDL output - you can set the ProxyStubClsId32 registry entry for your interfaces to the CLSID of the "type library marshaller" or "universal marshaller". Both terms are used, but in the Wine source it's called the typelib marshaller. The type library marshaller constructs proxy and stub objects on the fly. It does so by having generic marshalling glue which reads the information from the type libraries, and takes the parameters directly off the stack. The CreateProxy method actually builds a vtable out of blocks of assembly stitched together which pass control to _xCall, which then does the marshalling. You can see all this magic in dlls/oleaut32/tmarshal.c In the case of InstallShield, it actually comes with typelibs for all the interfaces it needs to marshal (fixme: is this right?), but they actually use a mix of MIDL and typelib marshalling. In order to cover up for the fact that we don't really use RPC they're all force to go via the typelib marshaller - that's what the 1 || hack is for and what the "Registering non-automation type library!" warning is about (I think). WRAPUP OK, so there are some (very) basic notes on DCOM. There's a ton of stuff I have not covered: - Format strings/MOPs - Apartments, threading models, inter-thread marshalling - OXIDs/OIDs, etc, IOXIDResolver - IRemoteActivation - Complex/simple pings, distributed garbage collection - Marshalling IDispatch - Structure of marshalled interface pointers (STDOBJREFs etc) - Runtime class object registration (CoRegisterClassObject), ROT - IRemUnknown - Exactly how InstallShield uses DCOM Then there's a bunch of stuff I still don't understand, like ICallFrame, interface pointer swizzling, exactly where and how all this stuff is actually implemented and so on. But for now that's enough. thanks -mike FURTHER READING Most of these documents assume you have knowledge only contained in other documents. You may have to reread them a few times for it all to make sense. Don't feel you need to read these to understand DCOM, you don't, you only need to look at them if you're planning to help implement it. [1] http://www.opengroup.org/onlinepubs/009629399/toc.htm [2] http://www.grimes.demon.co.uk/DCOM/DCOMSpec.htm [3] http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/cm… [4] http://msdn.microsoft.com/library/default.asp?url=/library/en-us/com/htm/cm… http://www.microsoft.com/msj/0398/dcom.aspx http://www.microsoft.com/ntserver/techresources/appserv/COM/DCOM/4_Connecti… http://www.idevresource.com/com/library/articles/comonlinux.asp (unfortunately part 2 of this article does not seem to exist anymore, if it was ever written)

5 8

Re: Is bugzilla worth keeping?
by Ivan Leo Puoti 25 Jul '04

25 Jul '04

> 2. The people entering bugs aren't always developers and don't always > have the skills to provide a good bug report. We have a tools for writing bug report, tools/bug_report.pl We should encourage people to use it to write bug reports. Also closing unmaintained bugs would be a good idea. Ivan.

1 0

Re: rsabase unit tests
by Michael Jung 25 Jul '04

25 Jul '04

Am Sonntag, 25. Juli 2004 13:56 schrieben Sie: > Michael Jung wrote: > >Greetings, > >Michael > > > >Changelog: > > Added unit tests for CPGenRandom API function of rsabase.dll > > You seem to be working on Crypto stuff, so I thought I'd better tell you > that I've got a patch pending that implements half of the functionality > in rsabase. > > Rob Thanks for the information. Indeed I've been working on rsabase.dll. When do you plan to submit your patch? I would like to see if at least some of my code can be incorporated, or if the work was in vain. Michael

1 0

location of mouse, scroll wheel handling
by James Hawkins 25 Jul '04

25 Jul '04

Does anyone know where most of the mouse and scroll wheel actions are being handled in the code? For example, say I am surfing the internet with Internet Explorere and WINE and I use my scroll wheel to move the page up and down. Where is the code that handles that? If anyone has any ideas whatsoever (or even if you can just say you don't know) I would really appreciate it. -- James Hawkins

2 1

Re: Support PBS_MARQUE for progress bars
by Thomas Weidenmueller 25 Jul '04

25 Jul '04

Sorry, this patch should compile. Index: dlls/comctl32/progress.c =================================================================== RCS file: /home/wine/wine/dlls/comctl32/progress.c,v retrieving revision 1.36 diff -u -r1.36 progress.c --- dlls/comctl32/progress.c 11 Mar 2004 00:39:53 -0000 1.36 +++ dlls/comctl32/progress.c 25 Jul 2004 12:26:33 -0000 @@ -26,9 +26,6 @@ * Unless otherwise noted, we believe this code to be complete, as per * the specification mentioned above. * If you discover missing features, or bugs, please note them below. - * - * TODO - * --support PBS_MARQUE * */ @@ -59,7 +56,9 @@ /* Control configuration constants */ -#define LED_GAP 2 +#define LED_GAP 2 +#define MARQUEE_LEDS 5 +#define ID_MARQUEE_TIMER 1 /*********************************************************************** * PROGRESS_Invalidate @@ -156,51 +155,215 @@ { if (dwStyle & PBS_VERTICAL) { - INT old_top = rect.top; - rect.top = rightBar; - FillRect(hdc, &rect, hbrBar); - rect.bottom = rect.top; - rect.top = old_top; - FillRect(hdc, &rect, hbrBk); + if (dwStyle & PBS_MARQUEE) + { + INT old_top, old_bottom; + old_top = rect.top; + old_bottom = rect.bottom; + + leds = rect.bottom - rect.top; + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + + if(ledMStart > 0) + { + rect.top = max(rect.bottom - ledMStart, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + } + if(infoPtr->MarqueePos > 0) + { + rect.top = max(old_bottom - infoPtr->MarqueePos, old_top); + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } + if(rect.top >= old_top) + { + rect.top = max(rect.bottom - MARQUEE_LEDS, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + } + if(rect.top >= old_top) + { + rect.top = old_top; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + INT old_top = rect.top; + rect.top = rightBar; + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top = old_top; + FillRect(hdc, &rect, hbrBk); + } } else { - INT old_right = rect.right; - rect.right = rightBar; - FillRect(hdc, &rect, hbrBar); - rect.left = rect.right; - rect.right = old_right; - FillRect(hdc, &rect, hbrBk); + if (dwStyle & PBS_MARQUEE) + { + INT old_left, old_right; + old_left = rect.left; + old_right = rect.right; + + leds = rect.right - rect.left; + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + rect.right = rect.left; + + if(ledMStart > 0) + { + rect.right = min(rect.left + ledMStart, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + } + if(infoPtr->MarqueePos > 0) + { + rect.right = min(old_left + infoPtr->MarqueePos, old_right); + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + if(rect.right < old_right) + { + rect.right = min(rect.left + MARQUEE_LEDS, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + } + if(rect.right < old_right) + { + rect.right = old_right; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + INT old_right = rect.right; + rect.right = rightBar; + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right = old_right; + FillRect(hdc, &rect, hbrBk); + } } } else { if (dwStyle & PBS_VERTICAL) { - while(rect.bottom > rightBar) { - rect.top = rect.bottom - ledWidth; - if (rect.top < rightMost) - rect.top = rightMost; - FillRect(hdc, &rect, hbrBar); - rect.bottom = rect.top; - rect.top -= LED_GAP; - if (rect.top <= rightBar) break; - FillRect(hdc, &rect, hbrBk); - rect.bottom = rect.top; + if (dwStyle & PBS_MARQUEE) + { + INT i, old_top, old_bottom; + old_top = rect.top; + old_bottom = rect.bottom; + + leds = ((rect.bottom - rect.top) + (ledWidth + LED_GAP) - 1) / (ledWidth + LED_GAP); + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + + while(ledMStart > 0) + { + rect.top = max(rect.bottom - ledWidth, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top -= LED_GAP; + if (rect.top <= old_top) break; + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + ledMStart--; + } + if(infoPtr->MarqueePos > 0) + { + rect.top = max(old_bottom - (infoPtr->MarqueePos * (ledWidth + LED_GAP)), old_top); + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } + for(i = 0; i < MARQUEE_LEDS && rect.top >= old_top; i++) + { + rect.top = max(rect.bottom - ledWidth, old_top); + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top -= LED_GAP; + if (rect.top <= old_top) break; + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } + if(rect.top >= old_top) + { + rect.top = old_top; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + while(rect.bottom > rightBar) { + rect.top = rect.bottom - ledWidth; + if (rect.top < rightMost) + rect.top = rightMost; + FillRect(hdc, &rect, hbrBar); + rect.bottom = rect.top; + rect.top -= LED_GAP; + if (rect.top <= rightBar) break; + FillRect(hdc, &rect, hbrBk); + rect.bottom = rect.top; + } } rect.top = rightMost; FillRect(hdc, &rect, hbrBk); } else { - while(rect.left < rightBar) { - rect.right = rect.left + ledWidth; - if (rect.right > rightMost) - rect.right = rightMost; - FillRect(hdc, &rect, hbrBar); - rect.left = rect.right; - rect.right += LED_GAP; - if (rect.right >= rightBar) break; + if (dwStyle & PBS_MARQUEE) + { + INT i, old_right, old_left; + old_left = rect.left; + old_right = rect.right; + + leds = ((rect.right - rect.left) + ledWidth - 1) / (ledWidth + LED_GAP); + ledMStart = (infoPtr->MarqueePos + MARQUEE_LEDS) - leds; + rect.right = rect.left; + + while(ledMStart > 0) + { + rect.right = min(rect.left + ledWidth, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right += LED_GAP; + if (rect.right > old_right) break; + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + ledMStart--; + } + if(infoPtr->MarqueePos > 0) + { + rect.right = min(old_left + (infoPtr->MarqueePos * (ledWidth + LED_GAP)), old_right); + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + for(i = 0; i < MARQUEE_LEDS && rect.right < old_right; i++) + { + rect.right = min(rect.left + ledWidth, old_right); + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right += LED_GAP; + if (rect.right > old_right) break; + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + if(rect.right < old_right) + { + rect.right = old_right; + FillRect(hdc, &rect, hbrBk); + } + } + else + { + while(rect.left < rightBar) { + rect.right = rect.left + ledWidth; + if (rect.right > rightMost) + rect.right = rightMost; + FillRect(hdc, &rect, hbrBar); + rect.left = rect.right; + rect.right += LED_GAP; + if (rect.right >= rightBar) break; + FillRect(hdc, &rect, hbrBk); + rect.left = rect.right; + } + rect.right = rightMost; FillRect(hdc, &rect, hbrBk); - rect.left = rect.right; } - rect.right = rightMost; - FillRect(hdc, &rect, hbrBk); } } @@ -229,6 +392,63 @@ /*********************************************************************** + * PROGRESS_Timer + * Handle the marquee timer messages + */ +static LRESULT PROGRESS_Timer (PROGRESS_INFO *infoPtr, INT idTimer) +{ + if(idTimer == ID_MARQUEE_TIMER) + { + LONG style = GetWindowLongW (infoPtr->Self, GWL_STYLE); + RECT rect; + int ledWidth, leds; + + GetClientRect (infoPtr->Self, &rect); + InflateRect(&rect, -1, -1); + + if(!(style & PBS_SMOOTH)) + { + int width, height; + + if(style & PBS_VERTICAL) + { + width = rect.bottom - rect.top; + height = rect.right - rect.left; + } + else + { + height = rect.bottom - rect.top; + width = rect.right - rect.left; + } + ledWidth = MulDiv (height, 2, 3); + leds = (width + ledWidth - 1) / (ledWidth + LED_GAP); + } + else + { + ledWidth = 1; + if(style & PBS_VERTICAL) + { + leds = rect.bottom - rect.top; + } + else + { + leds = rect.right - rect.left; + } + } + + /* increment the marquee progress */ + if(++infoPtr->MarqueePos >= leds) + { + infoPtr->MarqueePos = 0; + } + + InvalidateRect(infoPtr->Self, &rect, TRUE); + } + return 0; +} + + +/*********************************************************************** * PROGRESS_CoercePos * Makes sure the current position (CurVal) is within bounds. */ @@ -304,6 +524,8 @@ infoPtr->MaxVal = 100; infoPtr->CurVal = 0; infoPtr->Step = 10; + infoPtr->MarqueePos = 0; + infoPtr->Marquee = FALSE; infoPtr->ColorBar = CLR_DEFAULT; infoPtr->ColorBk = CLR_DEFAULT; infoPtr->Font = 0; @@ -326,6 +548,9 @@ case WM_PAINT: return PROGRESS_Paint (infoPtr, (HDC)wParam); + case WM_TIMER: + return PROGRESS_Timer (infoPtr, (INT)wParam); + case PBM_DELTAPOS: { INT oldVal; @@ -400,6 +625,19 @@ infoPtr->ColorBk = (COLORREF)lParam; InvalidateRect(hwnd, NULL, TRUE); return 0; + + case PBM_SETMARQUEE: + if(wParam != 0) + { + infoPtr->Marquee = TRUE; + SetTimer(infoPtr->Self, ID_MARQUEE_TIMER, (UINT)lParam, NULL); + } + else + { + infoPtr->Marquee = FALSE; + KillTimer(infoPtr->Self, ID_MARQUEE_TIMER); + } + return infoPtr->Marquee; default: if ((message >= WM_USER) && (message < WM_APP)) Index: include/commctrl.h =================================================================== RCS file: /home/wine/wine/include/commctrl.h,v retrieving revision 1.134 diff -u -r1.134 commctrl.h --- include/commctrl.h 6 Jul 2004 21:02:36 -0000 1.134 +++ include/commctrl.h 25 Jul 2004 12:13:28 -0000 @@ -456,10 +456,12 @@ #define PBM_GETRANGE (WM_USER+7) #define PBM_GETPOS (WM_USER+8) #define PBM_SETBARCOLOR (WM_USER+9) +#define PBM_SETMARQUEE (WM_USER+10) #define PBM_SETBKCOLOR CCM_SETBKCOLOR #define PBS_SMOOTH 0x01 #define PBS_VERTICAL 0x04 +#define PBS_MARQUEE 0x08 typedef struct {

1 0

how can I find what functions a dll file provides?
by James Hawkins 25 Jul '04

25 Jul '04

In what way can I list the API functions provided from a certain dll file? I seem to remember seeing somewhere that you could use a debugger, but I'm not sure. -- James Hawkins

4 3

Re: Implement StdMarshal::ReleaseMarshalData
by Jeroen Janssen 25 Jul '04

25 Jul '04

Mike Hearn wrote: > Mike Hearn <mh(a)codeweavers.com> > Rob Shearman <rob(a)codeweavers.com> > Implement StdMarshal::ReleaseMarshalData > + res = IRpcStubBuffer_Release(stub); I'm not sure but, is there a hypothical race condition here when a thread switch takes place and someone tries to reuse the stub while valid is not set to TRUE yet (but the stub has already been released)? > + stubs[i].valid = FALSE; --- Jeroen Janssen

3 4

(Quite) Slow Starcraft
by Maurizio Monge 25 Jul '04

25 Jul '04

It is now really *slow*, but a quite old 2d game such as starcraft that runs perfectly in a PII 300 under windows should also run perfectly on linux with an AMD64 3200 :-) It happens that using the nasty DGA hack on sourceforge.net/projects/starcraft-wine applied by hand to current cvs it does run (as root) perfectly. but even if X11 is a sucky architecture for games it should run perfectly too with accelerated X11+XShm. Instead it happens that *sometimes* it runs fast (as with DGA), and sometimes it becomes unacceptably slow (for little time, though). I started to give a look at wine source to understand why this strange thing happens, but i fould no place where DGA and X11 code paths could differ in this way... maybe with x11 there are such things as an additionl wine thread or boh... maybe you wine hackers are already aware of similar problems, or may help me to understand what's up (and i would like possibly to help fix it). Thanx Please CC monge(at)sns(dot)it as i'm not subscribed. -- Best Regards Maurizio Monge "..the triumph of evil is for good men to do nothing." (Edmond Burke)

1 0

status of advapi32
by James Hawkins 25 Jul '04

25 Jul '04

Hi all, Using Dependency Walker to extract the function names from the advapi32.dll, I have compiled a list of implemented, stubbed, semi-stubbed, missing, and questionable api functions of advapi32.dll. As for the percentage that is completed, using implemented / total * 100, advapi32.dll is 50% complete. With this format, developers can see what has already been done and what has yet to be done. It puts the whole process into a proper perspective. If anyone has any ideas about this or suggestions, let me know. -- James Hawkins

1 0

Re: Is bugzilla worth keeping?
by Ivan Leo Puoti 24 Jul '04

24 Jul '04

Of course we should keep it. It's a place to track bugs, and keep everything related to a non working application in the same place. And if we didn't have it, people would just flood the devel list with bug reports, or not report at all, and non of them seem a great idea. I've got a couple bugs fixed with bugzilla, and if wine will ever be finished then eventually all the bugs will be fixed. And not really we get messages on the patches list with patches that fix something in bugzilla. And it's a good place to send developers that aren't sure what to do next. Ivan.

3 2

out of sync (MSDN) web references in the wine code
by Jeroen Janssen 24 Jul '04

24 Jul '04

Hello, I'm wondering.. it seems there are a lot (MSDN) web references throughout the code. However, some of those links are out of date. Either the pages do not exist anymore, or moved to somewhere else. Is there any structural way to handle this? I mean, I want to look something up on the web based upon an url in the code, but the page doesn't exist anymore. So I could send in a patch to either remove the link, or find a correct one. But what is stopping (MSDN) people from moving things to a different location again, breaking the link again? --- Jeroen Janssen

2 1

Re: slightly OT: c expression evaluation order
by Diego 'Flameeyes' Pettenò 24 Jul '04

24 Jul '04

Michael Jung wrote: > I've always thought that the order in which subexpressions are evaluated > is not specified in the C language. Isn't there the danger of a NULL > pointer dereference given here? I don't think so. Order is expressed and is from left to right, so if you have two functions and do func1() && func2() if func1() will be evalutated as false, func2() will never be called. I saw code wrote without if statements and using directly the logic operators (also if I don't like this syntax) and also Gentoo's scripts (ebuilds and init.d) uses this syntax for some conditional statements. So it should be sure that there won't be a null pointer deference. Regards, -- Diego "Flameeyes" Pettenò dgp85(a)users.sourceforge.net - http://flameeyes.web.ctonet.it/

1 0

slightly OT: c expression evaluation order
by Michael Jung 24 Jul '04

24 Jul '04

Hello, this is slightly of topic for this mailing list. However, it would be nice if someone could answer my question. I've seen that Alexandre changed the if statement expression in one of my patches from if (pszProvider ? *pszProvider == '\0' : 1) to if (!pszProvider || !*pszProvider) I've always thought that the order in which subexpressions are evaluated is not specified in the C language. Isn't there the danger of a NULL pointer dereference given here? Thanks, Michael

2 1

dlls/winmm/wineoss/audio.c build failure
by Gerald Pfeifer 24 Jul '04

24 Jul '04

The following change to dlls/winmm/wineoss/audio.c revision 1.135 date: 2004/07/19 20:08:06; author: julliard; state: Exp; lines: +1 -1 Francois Gouget <fgouget(a)codeweavers.com> Use round() instead of ceil() in wodGetPosition(TIME_SMPTE). Fixes the corresponding winmm conformance test. causes the following build failure on FreeBSD 4.9: ../../../tools/winegcc/winegcc -B../../../tools/winebuild -shared ./wineoss.drv.spec audio.o midi.o midipatch.o mixer.o mmaux.o oss.o wineoss.drv.dbg.o -o wineoss.drv.so -L../../../dlls -lwinmm -luser32 -lkernel32 -L../../../libs/wine -lwine -ldxguid -luuid -L../../../libs/port -lwine_port audio.o: In function `wodGetPosition': /test/wine/dlls/winmm/wineoss/audio.c:2127: undefined reference to `round' collect2: ld returned 1 exit status winegcc: /sw/gcc-3.3.2/bin/gcc failed. gmake: *** [wineoss.drv.so] Error 2 Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 2

Re: wine/dlls/kernel locale.c
by Dmitry Timoshkov 24 Jul '04

24 Jul '04

"Alexandre Julliard" <julliard(a)winehq.org> wrote: > Log message: > Shachar Shemesh <wine-patches(a)shemesh.biz> > System default locale in Windows determines the ANSI encoding > (LC_CTYPE on Unix). I still think that this patch is wrong. On my english win2k with locale set to russian both GetSystemDefaultLCID and GetUserDefaultLCID return 0419. -- Dmitry.

1 0

Division by zero in snd_pcm_rate_sw_params()
by Francois Gouget 24 Jul '04

24 Jul '04

Hi, I am working on Wine and lately I have been tracking various sound related issues. One issue I noticed is a crash in Wine's winmm wave test when using the Alsa sound backend. More precisely: * if Wine's winmm wave test is the only application using the sound device, then it works * but if another application is already using the sound device (e.g. xmms), then Wine's winmm wave test crashes when trying to play the 96kHz test. The crash occurs when calling snd_pcm_sw_params(): EXIT_ON_ERROR( snd_pcm_sw_params(pcm, sw_params), MMSYSERR_ERROR, "unable to set sw params for playback"); See this URL for the exact source: http://source.winehq.org/source/dlls/winmm/winealsa/audio.c#L1602 Digging some more I found out that the division by zero happens in the snd_pcm_rate_sw_params() function pcm_rate.c. Here's why: * Wine sets xfer_align to 1: EXIT_ON_ERROR(snd_pcm_sw_params_set_xfer_align(pcm, sw_params, 1), MMSYSERR_ERROR, "unable to set xfer align"); * then it calls snd_pcm_sw_params() as shown above * eventually we get to snd_pcm_rate_sw_params() in src/pcm/pcm_rate.c. (http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-lib/src/pcm/pcm_rate.c?rev=…) * There we call recalc(): recalc(pcm, &sparams->xfer_align); * when more than one application uses the soundcard, recalc() ends up doing: *val = muldiv_near(*val, slave->period_size, pcm->period_size); * however in my case slave->period_size is less than half of pcm->period_size so I end up with xfer_align == *val == 0. * then, a few lines later in snd_pcm_rate_sw_params() we do: if (sparams->start_threshold > (slave->buffer_size / sparams->xfer_align) * sparams->xfer_align) sparams->start_threshold = (slave->buffer_size / sparams->xfer_align) * sparams->xfer_align; And we crash with a division by zero because now sparams->xfer_align==0. (these lines were added in CVS revision 1.83 of this file) Simply resetting xfer_align to 1 is it is zero after the call to recalc() (see attached patch) fixes the problem for me (no crash and the test tone plays correctly). However I don't know if this is the right fix, hence the following questions: Does my patch look ok? What is the proper procedure to get it applied? Is there further information I can provide to resolve this issue? My configuration: * Up to date Debian testing * Alsa 1.0.5a * cat /proc/asound/cards 0 [V8235 ]: VIA8233 - VIA 8235 VIA 8235 at 0xbc00, irq 5 -- Francois Gouget fgouget(a)codeweavers.com --- pcm_rate.c.orig 2004-07-24 03:19:41.000000000 +0200 +++ pcm_rate.c 2004-07-24 03:20:41.000000000 +0200 @@ -630,6 +638,8 @@ recalc(pcm, &sparams->avail_min); rate->orig_avail_min = sparams->avail_min; recalc(pcm, &sparams->xfer_align); + if (sparams->xfer_align==0) + sparams->xfer_align=1; recalc(pcm, &sparams->start_threshold); if (sparams->start_threshold <= slave->buffer_size) { if (sparams->start_threshold > (slave->buffer_size / sparams->avail_min) * sparams->avail_min)

1 0

Re: make crosstest fails
by Ivan Leo Puoti 24 Jul '04

24 Jul '04

> Or can we actually use this instead? > http://prdownloads.sourceforge.net/wine/wine-w32api-20040505.zip?download You should be able to use them, or I don't see the point of having them. Note that updated versions exist http://prdownloads.sourceforge.net/wine/wine-w32api-20040615.zip?download http://prdownloads.sourceforge.net/wine/wine-w32api-20040716.zip?download Ivan.

1 0

Re: devenum
by Ivan Leo Puoti 23 Jul '04

23 Jul '04

> Why you do not leave the neutral resources in the main archive? That's how it's done in other files, anyway, I'll send another patch that leaves the neutral resources in the main file. Ivan.

1 0

Re: Install msiexec in the bin dir while make install.
by Alexandre Julliard 23 Jul '04

23 Jul '04

Vincent Béron <vberon(a)mecano.gme.usherb.ca> writes: > Alexandre, what are the guidelines for installing winelib applications > in /foo/bin/? It should be restricted to apps that users will frequently run from the command-line on Windows so that they expect the same behavior on Wine, or else to apps prefixed with 'wine' as there isn't a risk of conflict in that case. I'm not sure msiexec qualifies; is it really something that end users are expected to use on Windows? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: French translation and other adjustments
by Francois Gouget 23 Jul '04

23 Jul '04

On Fri, 23 Jul 2004, Marcelo Duarte wrote: > Changelog: > Marcelo Duarte <wine-devel(a)bol.com.br> > French translation and other adjustments + IDS_RESTART_TITLE "Recommencer" + IDS_RESTART_PROMPT "Tu voulez simuler la remise du Windows?" + IDS_SHUTDOWN_TITLE "Débrancher" + IDS_SHUTDOWN_PROMPT "Tu voulez finir la session du Wine?" Urgh! Maybe you meant something like: + IDS_RESTART_TITLE "Recommencer" + IDS_RESTART_PROMPT "Voulez-vous simuler le redémarrage de Windows?" + IDS_SHUTDOWN_TITLE "Arrêter" + IDS_SHUTDOWN_PROMPT "Voulez-vous fermer la la session Wine?" Note: I not entirely sure about 'Arrêter'. Translation can be pretty tricky sometimes... -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Before you criticize someone, walk a mile in his shoes. That way, if he gets angry, he'll be a mile away - and barefoot.

2 1

Re: Add a WINEVER environment variable
by Andreas Mohr 23 Jul '04

23 Jul '04

Hi, I'm afraid I don't like the naming, since it's potentially confusing (plus, it somewhat goes against established rules, "WINE + function"). What about WINEWINVER instead? I for one like it much more. Also, this doesn't take into account that we're also able to set the DOS version. So what would that be called then? WINEVER, too? ;-) WINEWINVER and WINEDOSVER is a much better choice, IMHO. Greetings, Andreas

3 4

Re: COM outproc & CFProxy unhandled interface for IRunnableObject
by Mike Hearn 23 Jul '04

23 Jul '04

CCing to wine-devel as the original reply will be forwarded soon too by Jeroen .. On Fri, 2004-07-23 at 17:58 +0200, Jeroen Janssen wrote: > I had a short look at the 'world of com' patch, and it looks like there > is something in there that implements the IRemUnknown stuff. Is there > any easy way to determine if/how this can be 'ported' to the current wine? The "world of dcom" patch used to apply to WineHQ but it may not these days. Mike did a recent merge of it a month or two ago, maybe he has the latest copy? As to actually merging it into CVS, I'm not sure that's a good idea anymore. There's a lot of duplication there and we understand the code Marcus wrote better than Oves. Marcus is still a part of the project, whereas Ove basically isn't anymore. I think some of it is usable, and some of it is not, but merging it isn't a simple "make it apply cleanly and submit" I'm afraid.

2 1

Re: COM outproc & CFProxy unhandled interface for IRunnableObject
by Robert Shearman 23 Jul '04

23 Jul '04

Jeroen Janssen wrote: > Robert Shearman wrote: > >> Jeroen Janssen wrote: >> >>> Hello, >>> >>> I'm mailing the both of you with a small (com) example attached. >>> >>> It is a client/server/proxystub example (with binaries), so you need to >>> /RegServer the server and regsvr32 the proxy. >>> >>> Now I first manually start the server in a seperate console and then I >>> manually start the client. >>> >>> I modified the client to look for input, so there are basically two >>> paths >>> in the client: >>> >>> * you press: 1 <enter>; the normal path, goes OK >>> hr = >>> CoCreateInstance(CLSID_Calculate,NULL,CLSCTX_LOCAL_SERVER,IID_ICalculate,(void**) >>> >>> &pICalculate); >>> >>> * you press: 2 (or something else) <enter>; the other path, FAILURE >>> hr = >>> CoCreateInstance(CLSID_Calculate,NULL,CLSCTX_LOCAL_SERVER,IID_IUnknown,(void**) >>> >>> &pIUnknown); >>> hr = pIUnknown->QueryInterface(IID_ICalculate, (void **) &pICalculate); >>> >>> Now either there is something wrong with my sample, or there is >>> something >>> wrong in wine that causes this to fail. >>> >>> Can you verify that the client code path is ok (the very few above >>> mentioned lines that differentiate in scenario 1,2). If the client >>> code is >>> ok, then any idea what is actually causing the problem? >> >> >> >> Yes, I can see the problem. What happens with native OLE is that the >> IUnknown part of the object is handled by the proxy manager. What >> this basically means is that it is translated into IRemUnknown >> (remote unknown) calls that will do the appropriate thing. However, >> this is currently not implemented on Wine. >> I'm not sure we (Mike and I) will have time to properly implement >> this, but I could maybe write a quick hack for you sometime over the >> weekend. > > > Ok, thanks for this explanation (that explains why this is not working > yet on wine). > > I had a short look at the 'world of com' patch, and it looks like > there is something in there that implements the IRemUnknown stuff. Is > there any easy way to determine if/how this can be 'ported' to the > current wine? As Mike said, some of it is usable and some of it isn't. Try applying the patch, but YMMV - I ran the patch for a while and it seemed to cause more problems than it solved, particularly in IE. In particular, I don't think the IRemUnknown stuff will be merged as is, because I think the way it is implemented in the patch is not the way it is implemented in Windows (there is only one IRemUnkown interface per apartment) and we only want to write this code once! Rob

1 0

Re: COM outproc & CFProxy unhandled interface for IRunnableObject
by Jeroen Janssen 23 Jul '04

23 Jul '04

Forwarding this to the wine-devel mailinglist..... Robert Shearman wrote: > Jeroen Janssen wrote: > >> Hello, >> >> I'm mailing the both of you with a small (com) example attached. >> >> It is a client/server/proxystub example (with binaries), so you need to >> /RegServer the server and regsvr32 the proxy. >> >> Now I first manually start the server in a seperate console and then I >> manually start the client. >> >> I modified the client to look for input, so there are basically two >> paths >> in the client: >> >> * you press: 1 <enter>; the normal path, goes OK >> hr = >> CoCreateInstance(CLSID_Calculate,NULL,CLSCTX_LOCAL_SERVER,IID_ICalculate,(void**) >> >> &pICalculate); >> >> * you press: 2 (or something else) <enter>; the other path, FAILURE >> hr = >> CoCreateInstance(CLSID_Calculate,NULL,CLSCTX_LOCAL_SERVER,IID_IUnknown,(void**) >> >> &pIUnknown); >> hr = pIUnknown->QueryInterface(IID_ICalculate, (void **) &pICalculate); >> >> Now either there is something wrong with my sample, or there is >> something >> wrong in wine that causes this to fail. >> >> Can you verify that the client code path is ok (the very few above >> mentioned lines that differentiate in scenario 1,2). If the client >> code is >> ok, then any idea what is actually causing the problem? > > > Yes, I can see the problem. What happens with native OLE is that the > IUnknown part of the object is handled by the proxy manager. What this > basically means is that it is translated into IRemUnknown (remote > unknown) calls that will do the appropriate thing. However, this is > currently not implemented on Wine. > I'm not sure we (Mike and I) will have time to properly implement > this, but I could maybe write a quick hack for you sometime over the > weekend. Ok, thanks for this explanation (that explains why this is not working yet on wine). Btw, is it ok to forward this information to the mailinglist too? (I didn't want to sent the example attachment to everyone on the mailinglist, but this discussion seems interesting enough to have the "conclusion" posted on the wine development mailinglist. I had a short look at the 'world of com' patch, and it looks like there is something in there that implements the IRemUnknown stuff. Is there any easy way to determine if/how this can be 'ported' to the current wine? --- Jeroen

1 0

Building DLLs and other Qs
by Peter Riocreux 23 Jul '04

23 Jul '04

Before I get onto my questions I would just like to say: This mail is not intended to start a flame war ---------------------------------------------- It is intended in a spirit of understanding what is the current status. First the quick question - I want to install a built-from-CVS wine on multiple Fedora Core 1 machines. I can't find a spec file anywhere to make an RPM with - should I just pinch one from a FC1 Wine package, or is anyone maintaining a set of package-build scripts (RPM, dpkg, etc.)? Now the more complicated and possibly flame-inducing question. While looking round the source tree for a spec file I noticed that all the WINE DLLs seem to end up as .dll.so files. I assume this is because the native platform's gcc can't build a real DLL, so it is wrapped up as a .so and wine (the binary) loads them as such and them does a connect-the-dots exercise to make it look to the application as if it loaded a real DLL. My understanding is that a cross-compiled gcc would build real DLLs, and as wine is able to load them when given them, would there be any advantage to building them with a cross-compiling toolchain if one were available. I am thinking here of perhaps some kind of loading speed improvement (unlikely to be significant if any) or maybe some perverse custom installer that looks for specifically named files in specific places on the filesystem it sees. If there is no advantage, could the converse be true - that there would be some benefit to wrapping native DLLs in a .so shell for speed improvement - perhaps analysing the DLL on load is very hard work and if this were done once and the result saved as a .so ..... Peter

3 2

Re: COM outproc & CFProxy unhandled interface for IRunnableObject
by Jeroen Janssen 23 Jul '04

23 Jul '04

> From: Mike Hearn <mike(a)navi.cx> >> Maybe my 'real' problem is that based upon the logging, I also see a >> CFProxy Unhandled interface for the first interface that the client is >> trying to access (but I need to know more about how COM/wine deals with >> this). > > Are you sure you're using COM right? I have also written an outproc > server test and it works OK - at least I've been able to marshal a Hello > World RPC across. Well, it seems to work ok on Windows, so there must be something 'ok' about it. Also, I did not write the application myself. I'm just trying to get it run under wine. I am not sure, but there seems to be a difference in the outproc handling of the CoCreateInstance call? This goes ok: hr = CoCreateInstance(CLSID_Component1, NULL, clsctx, IID_IX, (void**)&pIX) ; However this seems to go wrong?: hr = CoCreateInstance(CLSID_Component1, NULL, clsctx, __uuidof(IUnknown), (void**)&pIUnknown); hr = pIUnknown->QueryInterface(IID_IX, (void **)&pIX); Summary: If you perform a CoCreateInstance for IUnknown (outproc), you get back the classfactory instead of the proxy to the object itself? Maybe you can check this behaviour? (I don't know exactly if this is indeed what seems to wrong or that I might have made a mistake with the simple test program). > Me and Rob are starting to scrape together a plan, I think, and as part of > working on other apps we're fixing bits as we go, but it's a long long > road we have ahead of us. Any help would certainly be welcome. Well, I'm trying get this application running with wine, I don't know what else I might walk into, but I surely hope to do some contributions to wine in the process. --- Jeroen Janssen

3 2

building COM client/server with proxy using winelib & widl?
by Jeroen Janssen 23 Jul '04

23 Jul '04

Hello, I was wondering whether there is a wine COM client/server application that makes use of winelib & widl (to generate a proxy/stub dll). Apparently I'm missing some #defines in wine's rpcproxy.h in order to be able build the proxy/stub dll? For instance: PROXYFILE_LIST_START PROXYFILE_LIST_END REFERENCE_PROXY_FILE It seems that these defines are present in the rpcproxy.h included with MinGW? I googled for it and found http://www.cs.up.ac.za/courses/EPE210/software/MinGW-1.1/include/rpcproxy.h On a side note can widl generate proxy/stub code yet? --- Jeroen Janssen

2 1

about wine dsound
by Magnus Olsen 23 Jul '04

23 Jul '04

HI My name are Magnus Olsen (call GreatLord at reactos channel) I am one of reactos devlooper I we are now trying get the sound working in reactos. I did start to port over wine dsound and find out it did have it own api layer, to get dsound guid, and other stuff. I did rewrite to thuse part to get it working under windows. Yes wine dsound with some modifaction are now working in windows. we need now do some modifaction to wine winmm get it windows / reactos compatible. the GetDeviceID in Dsound get the value from the windows / reactos system register now. and it works under windows 2k / XP write a api layer betwin dsound api call to WaveInMessage and WaveOutMessage DRV_QUERYDSOUNDGUID 100% support for windows and reactos) DRV_QUERYDSOUNDDESC 80% support for windows and reactos need to figut how to get some data from windows api) DRV_QUERYDSOUNDIFACE 0% force dsound to software emulation mode until I or some else fix it for windows or reactos

1 0

Re: Check Server Version From Client Dlls
by Andreas Mohr 23 Jul '04

23 Jul '04

Hi, On Thu, Jul 22, 2004 at 02:59:47PM +0100, Robert Shearman wrote: > > Changelog: > Check server version from x11drv, kernel32 and user32 to prevent > mismatches of installed dlls. Slight overkill, I'd say. Why not do: if (!wine_server_check_version( "x11drv", SERVER_PROTOCOL_VERSION )) ... if (ver != SERVER_PROTOCOL_VERSION) MESSAGE( "Error: server version mismatch.\n" "Your %s binary was not upgraded correctly\n" "or the wrong wineserver is still running.\n", dll_name ); return (ver == SERVER_PROTOCOL_VERSION); Greetings, Andreas Mohr

3 5

Re: PATCH: controls/menu.c case ranges
by Alexandre Julliard 22 Jul '04

22 Jul '04

Marcus Meissner <marcus(a)jet.franken.de> writes: > Another try on fixing the case range problems (WORD is unsigned, > HBMMENU_CALLBACK is -1, so out of range of the switch). I think this is revealing a deeper problem with that code, the magic value check should be done against the whole handle, not just the low word. -- Alexandre Julliard julliard(a)winehq.org

2 1

too many functions in msvcrt20.dll?
by Chipzz 22 Jul '04

22 Jul '04

I was looking at porting a small subset of msvcrt80.dll, and so I took a look at msvcrt20.dll. I first used a disassembler to get a list of the functions in the native windows dll, ran a script over that, and then ran another script over msvcrt20.spec. Much to my surprise, the wine implementation has more(!!) functions than the native dll. So, I was wondering, this screws up the index of these functions in the list, right? Does that index actually matter? The diff between the 2 files is attached. With kr, Chipzz AKA Jan Van Buggenhout -- ------------------------------------------------------------------------ UNIX isn't dead - It just smells funny Chipzz(a)ULYSSIS.Org ------------------------------------------------------------------------ "Baldric, you wouldn't recognize a subtle plan if it painted itself pur- ple and danced naked on a harpsicord singing 'subtle plans are here a- gain'."

2 1

daily wine cvs source snapshots?
by Jeroen Janssen 22 Jul '04

22 Jul '04

Hello, I was wondering since: 1) wine uses CVS (and not svn with httpwebdav) and 2) CVS doesn't go through the firewall at my work (and possible also not for other people) Would it be possible to have daily cvs snapshots (cvs export) of the wine HEAD tree? This makes tracking the latest HEAD possible for people that can't use CVS to access the repository. I know that the CVS repository itself is available, but that sounds a bit overkill to me. best regards, Jeroen Janssen

3 3

Re: devenum
by Marcelo Duarte 22 Jul '04

22 Jul '04

Ivan Leo Puoti wrote: > English resources moved to En.rc, language neutral resources moved to Xx.rc, > and italian resources added in It.rc > Licence: LGPL > > Ivan. Ivan, Why you do not leave the neutral resources in the main archive? Greetings, Marcelo

1 0

COM outproc & CFProxy unhandled interface for IRunnableObject
by Jeroen Janssen 22 Jul '04

22 Jul '04

Hello, I'm trying to run 2 programs: 1) is a COM server program 2) is a COM client program Now, program 2) tries to access a COM component from 1) (outproc). It seems some marshalling is being done, but eventually I get: fixme:ole:CFProxy_QueryInterface Unhandled interface: {00000126-0000-0000-c000-000000000046} This interface seems to be IRunnableObject. Now I'm not exactly sure how this is supposed to work, or even if this is the reason why my test currently fails. I can provide more logging/info if I know what exactly to provide. Note that I tried a small outproc client/server test that seems to go ok without this error, so the 'basic' outproc mechanism seems to work ok. Can someone provide more information on how wine deals with Outproc COM? On a side note, what are the main differences in COM implementation between wine and winex (if I understand correctly, Transgaming rewrote the COM implemenation for winex in order to better support the InstallShield installer?). Best regards, Jeroen Janssen

3 3

tests: safe MAPI init
by Ferenc Wagner 22 Jul '04

22 Jul '04

Hi (and sorry for the broken post), the mapi32 tests call scInitMapiUtil, which pops up an alert box saying something like (translating it) "Your default mailer application isn't capable of this operation, please ensure that Outlook is configured as the default mailer." This brings the tests to a halt, and even after clicking OK one gets 65536 failures bumping the logs above 5 MB. As a side note, most of the mapi tests are very careful about calling every function through a pointer acquired by GetProcAddr(), still the test executable is linked with -lmapi32. Does it make any sense? From winetest's perspective it isn't worth much, if a test can't run it's skipped altogether. Does it take care about different mapi versions? There are no recent reports on test.winehq.org/data, so something is obviously wrong. I'd be interested in hearing about people running Chris' winrash service. What happens if you run winetest directly? Don't forget to supply you tag with the -t option! Basically, winetest's own message boxes are OK, system message boxes are a problem. Thanks, Feri.

2 4

tests: safe MAPI init
by Ferenc Wagner 22 Jul '04

22 Jul '04

Hi, the mapi32 tests call scInitMapiUtil, which pops up an alert box

1 0

Serial port patch in 20040716
by Scott Snell 22 Jul '04

22 Jul '04

I installed 20040716 from an rpm and although most of it worked very well I had issues with the serial port. It would send out some characters at the start but I couldnt read any characters. After reading the thread "General serial communications issues" I found Eric Pouech's patch. I downloaded the source for 20040716 and applied the patch. I had to add #define for FD_FLAG_AVIALABLE in several files to get the project to compile. Unfortunately it doesnt solve my problem. Is there a particular version of the source I should apply the patch to? Does anyone have a patch for 20040716 source? Am I missing something fundamental with setting up serial ports? ta scott.

1 0

Localization status
by Marcelo Duarte 22 Jul '04

22 Jul '04

Hi, I modified a tool that Vincent Béron made and thus we can have the status of the translation of some languages. Case somebody wants that I add others I inform me. We can see that some languages are well complete, as the Portuguese ;) file:///home/mduarte/wine/tools/trans_html/index.html <cid:part1.03040507.04030402@bol.com.br>

1 0

Localization status
by DTM Informática 22 Jul '04

22 Jul '04

Hi, I modified a tool that Vincent Béron made and thus we can have the status of the translation of some languages. Case somebody wants that I add others I inform me. We can see that some languages are well complete, as the Portuguese ;) file:///home/mduarte/wine/tools/trans_html/index.html <cid:part1.04060404.05090008@bol.com.br>

1 0

Re: Avoid BadMatch Error
by Alexandre Julliard 22 Jul '04

22 Jul '04

Philip Dicke <Philip.Dicke(a)raytheon.com> writes: > Sometimes, when converting from a disabled pixmap for an icon in > x11drv/bitblt.c, an area is requested using XGetImage that is larger then > the actual drawable. This causes a X BadMatch error and wine immediately > exits. The submitted patch avoids this error by checking the size of the > requested area and the size of the drawable in BITBLT_GetSrcArea. That should not happen, the drawable size must have been taken into account when computing visRectSrc already. You'll need to find out why visRectSrc doesn't contain the proper size in your case. -- Alexandre Julliard julliard(a)winehq.org

1 0

pthread_mutex in a winelib dll called from a win32 application
by Shachar Shemesh 22 Jul '04

22 Jul '04

Hi all, Are there any restrictions in synchronizing wine generated threads (generated through the win32 api) using the pthreads library native calls? I have an app that is experiencing extremely slow performance (operation takes 17 seconds on native windows, over 3 minutes on Wine). One idea for solving this problem was to switch some of the synchronization operations over to native pthreads (it's using wine as part of a migration to Linux process). The problem is that when I try to call pthread_mutex_init, pthread_mutex_lock and friends, I get quite a few deadlocks, and even when not deadlocking, it still takes over 42 seconds. When doing the same without the mutexes (I'm locking write access to a pipe - I'm not sure it's even necessary, and it is working without the lock too), wine performs at 21-26 seconds. I don't think that obtaining a posix mutex should have such harsh effect on performance. Is it at all ok to try and synchronize threads created with "CreateThread" using posix constructs? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

5 7

crash in menu.c
by Dan Timis 21 Jul '04

21 Jul '04

One of the third party Windows software that we support is crashing when clicking on a popup menu that has separators. The author of the software send us a snippet of his code. It looks something like this: MENUITEMINFO mi; ZeroMemory(&mi, sizeof(mi)); mi.cbSize = sizeof(mi); mi.fType = MFT_SEPARATOR; InsertMenuItem(hMenu, index++, TRUE, &mi); The problem is obviously that mi.fMask does not have the MIIM_TYPE bit set. This code "works" on Windows; it draws a separator like the programmer intended, but not like the API would suggest this should work. I'm not sure what should be wine's behavior, but I don't think it should crash. The crash in wine happens when MENU_InitTracking calls MENU_ShowPopup, which in turn calls MENU_CalcItemSize: trace:menu:MENU_CalcItemSize dc=0x11ac owner=0x10025 (3,56) trace:menu:do_debug_print_menuitem MENU_CalcItemSize: menuitem: { ID=0x4, State=grey, Text=L"Save Preset As..." } trace:menu:MENU_CalcItemSize (3,56)-(148,74) trace:menu:MENU_CalcItemSize dc=0x11ac owner=0x10025 (3,74) trace:menu:do_debug_print_menuitem MENU_CalcItemSize: menuitem: { ID=0x0, Text=Null } wine: Unhandled exception (thread 0009), starting debugger... ... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x40de985c). ... 0x40de985c (MENU_CalcItemSize+0x13c [menu.c] in USER32.DLL): repne scasw^I%es:(%edi) Earlier, I get this trace: trace:menu:do_debug_print_menuitem MENU_SetItemInfo_common from: { ID=0x0, Text=Null } trace:menu:do_debug_print_menuitem SetMenuItemInfo_common to : { ID=0x4, State=grey, Text=L"Save Preset As..." } trace:menu:do_debug_print_menuitem MENU_SetItemInfo_common from: { ID=0x0, Text=Null } trace:menu:do_debug_print_menuitem SetMenuItemInfo_common to : { ID=0x0, Text=Null } I don't understand how this "from" and "to" works, but the ID of the menu item after "Save Preset As..." should be 0x5. I have a wine version from 2004-04-08. The author of the Windows software will fix the problem in his code and that should stop the crash, but maybe someone should fix this in wine too. Thanks, Dan Timis Muse Research, Inc.

1 0

Re: cleanup a->w cross calls in advapi32/crypt.c
by Alexandre Julliard 21 Jul '04

21 Jul '04

James Hawkins <truiken(a)gmail.com> writes: > - PCSTR KEYSTR = "Software\\Microsoft\\Cryptography\\Defaults\\Provider\\"; > - PSTR keyname; > + PCWSTR KEYSTR = (PCWSTR)"Software\\Microsoft\\Cryptography\\Defaults\\Provider\\"; > + PWSTR keyname; This is wrong, you need to declare Unicode strings, not typecast ASCII ones. -- Alexandre Julliard julliard(a)winehq.org

1 0

Problems with wizard code in COMCTL32
by Filip Navara 21 Jul '04

21 Jul '04

Hi, I took a quick look at the property sheet code in COMCTL32 in order to get the Mozilla Firefox setup working. The attached patch fixes some of the bugs, but the code is too messy for me to understand and fix the other problems: - Line ~1532. When PSH_USEHBMWATERMARK or PSH_USEHBMHEADER is set, the property sheet header is modified and the watermark/header bitmap is loaded using CreateMappedBitmap and injected into the hbmWatermark/hbmHeader field of the global property sheet info structure. This is done for every page in the property sheet. Since the names and bitmaps are stored as union at the same place in memory, on the second page the bitmap is already loaded and the original name is already lost, but the PSH_USEHBM* flag is still set and so the code tries to load the bitmap again passing the bitmap handle instead of the resource ID. I think the code for loading the watermark and header bitmaps should be moved to some other initialization routine, because AFAIK these bitmaps are identical for the whole wizard and not different on per page basis. - The watermark bitmap is displayed under the "dialog" with the controls on the property sheet. The "dialog" itself isn't transparent and so most of the watermark bitmap isn't visible. I thought that setting the window class background color of the "dialog" with controls would solve that, but it seems that the native version of COMCTL32 (from Windows XP) subclasses it. - Caption of the wizard window is never set. If anyone wants to look at these problems it would be great. Regards, Filip Changelog: - Properly calculate caption length when converting multi-byte string to wide character one. - Wizard contents shouldn't be moved by the size of watermark bitmap. - Fix PSH_WIZARD97_[NEW/OLD] checks. - Blit the watermark even if PSH_USEHBMWATERMARK flag isn't set and blit only the part that fits into the dialog. - Fix CreateMappedBitmap for palette-less bitmaps. Index: comctl32/propsheet.c =================================================================== --- comctl32/propsheet.c (revision 1) +++ comctl32/propsheet.c (working copy) @@ -173,7 +173,7 @@ static BOOL PROPSHEET_RemovePage(HWND hwndDlg, int index, HPROPSHEETPAGE hpage); -static void PROPSHEET_CleanUp(); +static void PROPSHEET_CleanUp(HWND hwndDlg); static int PROPSHEET_GetPageIndex(HPROPSHEETPAGE hpage, PropSheetInfo* psInfo); static void PROPSHEET_SetWizButtons(HWND hwndDlg, DWORD dwFlags); static PADDING_INFO PROPSHEET_GetPaddingInfoWizard(HWND hwndDlg, const PropSheetInfo* psInfo); @@ -308,10 +308,9 @@ { if (HIWORD(lppsh->pszCaption)) { - int len = strlen(lppsh->pszCaption); + int len = MultiByteToWideChar(CP_ACP, 0, lppsh->pszCaption, -1, NULL, 0); psInfo->ppshheader.pszCaption = HeapAlloc( GetProcessHeap(), 0, (len+1)*sizeof (WCHAR) ); MultiByteToWideChar(CP_ACP, 0, lppsh->pszCaption, -1, (LPWSTR) psInfo->ppshheader.pszCaption, len+1); - /* strcpy( (char *)psInfo->ppshheader.pszCaption, lppsh->pszCaption ); */ } } psInfo->nPages = lppsh->nPages; @@ -361,7 +360,7 @@ psInfo->ppshheader.pszCaption = NULL; else { - if (!(lppsh->dwFlags & INTRNL_ANY_WIZARD) && HIWORD(lppsh->pszCaption)) + if (HIWORD(lppsh->pszCaption)) { int len = strlenW(lppsh->pszCaption); psInfo->ppshheader.pszCaption = HeapAlloc( GetProcessHeap(), 0, (len+1)*sizeof(WCHAR) ); @@ -1511,7 +1510,6 @@ psInfo->proppage[index].hwndPage = hwndPage; if (psInfo->ppshheader.dwFlags & INTRNL_ANY_WIZARD) { - int offsetx = 0; int offsety = 0; HWND hwndChild; RECT r; @@ -1532,11 +1530,10 @@ pageWidth, pageHeight, padding.x, padding.y); /* If there is a watermark, offset the dialog items */ - if ( (psInfo->ppshheader.dwFlags & (PSH_WATERMARK | PSH_WIZARD97_NEW | PSH_WIZARD97_OLD)) && + if ( (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_NEW | PSH_WIZARD97_OLD)) && + (psInfo->ppshheader.dwFlags & PSH_WATERMARK) && ((index == 0) || (index == psInfo->nPages - 1)) ) { - BITMAP bm; - /* if PSH_USEHBMWATERMARK is not set, load the resource from pszbmWatermark and put the HBITMAP in hbmWatermark. Thus all the rest of the code always considers hbmWatermark as valid. */ @@ -1545,13 +1542,10 @@ ((PropSheetInfo *)psInfo)->ppshheader.u4.hbmWatermark = CreateMappedBitmap(ppshpage->hInstance, (INT)psInfo->ppshheader.u4.pszbmWatermark, 0, NULL, 0); } - - /* Compute the offset x */ - GetObjectA(psInfo->ppshheader.u4.hbmWatermark, sizeof(BITMAP), (LPVOID)&bm); - offsetx = bm.bmWidth; } - if (psInfo->ppshheader.dwFlags & (PSH_HEADER | PSH_WIZARD97_NEW | PSH_WIZARD97_OLD)) + if (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_NEW | PSH_WIZARD97_OLD) && + psInfo->ppshheader.dwFlags & PSH_HEADER) { /* Same behavior as for watermarks */ if (!(psInfo->ppshheader.dwFlags & PSH_USEHBMHEADER)) @@ -1567,21 +1561,10 @@ offsety = (ppshpage->dwFlags & PSP_HIDEHEADER)?0:r.bottom + 1; } - hwndChild = GetWindow(hwndPage, GW_CHILD); - while((offsetx!=0) && (hwndChild)) { - GetWindowRect(hwndChild, &r); - MapWindowPoints(0, hwndPage, (LPPOINT)&r, 2); - OffsetRect(&r, -offsetx, 0); - SetWindowPos(hwndChild, 0, r.left, r.top, - 0, 0, SWP_NOSIZE | SWP_NOZORDER); - - hwndChild = GetWindow(hwndChild, GW_HWNDNEXT); - } - SetWindowPos(hwndPage, HWND_TOP, - rc.left + padding.x/2 + offsetx, + rc.left + padding.x/2, rc.top + padding.y/2 + offsety, - pageWidth - offsetx, pageHeight - offsety, 0); + pageWidth, pageHeight - offsety, 0); } else { /* @@ -2926,7 +2909,8 @@ hOldPal = SelectPalette(hdc, psInfo->ppshheader.hplWatermark, FALSE); if ( (!(ppshpage->dwFlags & PSP_HIDEHEADER)) && - (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_NEW | PSH_HEADER)) ) + (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_OLD | PSH_WIZARD97_NEW)) && + (psInfo->ppshheader.dwFlags & PSH_HEADER) ) { RECT rzone; HWND hwndLineHeader = GetDlgItem(hwnd, IDC_SUNKEN_LINEHEADER); @@ -2982,35 +2966,33 @@ } if ( ((psInfo->active_page == 0) || (psInfo->active_page == psInfo->nPages - 1)) && - (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_NEW | PSH_WATERMARK)) ) + (psInfo->ppshheader.dwFlags & (PSH_WIZARD97_OLD | PSH_WIZARD97_NEW)) && + (psInfo->ppshheader.dwFlags & PSH_WATERMARK) ) { - if (psInfo->ppshheader.dwFlags & PSH_USEHBMWATERMARK ) - { - HWND hwndLine = GetDlgItem(hwnd, IDC_SUNKEN_LINE); + HWND hwndLine = GetDlgItem(hwnd, IDC_SUNKEN_LINE); - GetClientRect(hwndLine, &r); - MapWindowPoints(hwndLine, hwnd, (LPPOINT) &r, 2); + GetClientRect(hwndLine, &r); + MapWindowPoints(hwndLine, hwnd, (LPPOINT) &r, 2); - GetObjectA(psInfo->ppshheader.u4.hbmWatermark, sizeof(BITMAP), (LPVOID)&bm); - hbmp = SelectObject(hdcSrc, psInfo->ppshheader.u4.hbmWatermark); + GetObjectA(psInfo->ppshheader.u4.hbmWatermark, sizeof(BITMAP), (LPVOID)&bm); + hbmp = SelectObject(hdcSrc, psInfo->ppshheader.u4.hbmWatermark); - BitBlt(hdc, 0, offsety, bm.bmWidth, bm.bmHeight, - hdcSrc, 0, 0, SRCCOPY); + BitBlt(hdc, 0, offsety, min(bm.bmWidth, r.right), + min(bm.bmHeight, r.bottom), hdcSrc, 0, 0, SRCCOPY); - /* If the bitmap is not big enough, fill the remaining area - with the color of pixel (0,0) of bitmap - see MSDN */ - if (r.top > bm.bmHeight) { - r.bottom = r.top - 1; - r.top = bm.bmHeight; - r.left = 0; - r.right = bm.bmWidth; - hbr = CreateSolidBrush(GetPixel(hdcSrc, 0, 0)); - FillRect(hdc, &r, hbr); - DeleteObject(hbr); - } - - SelectObject(hdcSrc, hbmp); + /* If the bitmap is not big enough, fill the remaining area + with the color of pixel (0,0) of bitmap - see MSDN */ + if (r.top > bm.bmHeight) { + r.bottom = r.top - 1; + r.top = bm.bmHeight; + r.left = 0; + r.right = bm.bmWidth; + hbr = CreateSolidBrush(GetPixel(hdcSrc, 0, 0)); + FillRect(hdc, &r, hbr); + DeleteObject(hbr); } + + SelectObject(hdcSrc, hbmp); } if (psInfo->ppshheader.dwFlags & PSH_USEHPLWATERMARK) Index: comctl32/commctrl.c =================================================================== --- comctl32/commctrl.c (revision 1) +++ comctl32/commctrl.c (working copy) @@ -862,7 +862,12 @@ if (lpBitmap == NULL) return 0; - nColorTableSize = (1 << lpBitmap->biBitCount); + if (lpBitmap->biSize >= sizeof(BITMAPINFOHEADER) && lpBitmap->biClrUsed) + nColorTableSize = lpBitmap->biClrUsed; + else if (lpBitmap->biBitCount <= 8) + nColorTableSize = (1 << lpBitmap->biBitCount); + else + nColorTableSize = 0; nSize = lpBitmap->biSize + nColorTableSize * sizeof(RGBQUAD); lpBitmapInfo = (LPBITMAPINFOHEADER)GlobalAlloc (GMEM_FIXED, nSize); if (lpBitmapInfo == NULL) @@ -899,7 +904,7 @@ HDC hdcDst = CreateCompatibleDC (hdcScreen); HBITMAP hbmOld = SelectObject (hdcDst, hbm); LPBYTE lpBits = (LPBYTE)(lpBitmap + 1); - lpBits += (1 << (lpBitmapInfo->biBitCount)) * sizeof(RGBQUAD); + lpBits += nColorTableSize * sizeof(RGBQUAD); StretchDIBits (hdcDst, 0, 0, nWidth, nHeight, 0, 0, nWidth, nHeight, lpBits, (LPBITMAPINFO)lpBitmapInfo, DIB_RGB_COLORS, SRCCOPY);

1 0

RFC: API db
by David Miller 21 Jul '04

21 Jul '04

Hello, This is a request for comments relating to the API database at http://winedb.pavely.net. The backend database has been redesigned to improve database performance and produce more accurate results. It currently contains import/export and ordinal data for various windows versions as well as WINE. What I would like is some feedback from the WINE development community about what you would like to see in a front-end to the database. This could range from suggestions on presenting data in an easy-to-understand manner to adding additional data to the database. Current suggestions include the following: 1. Cross reference and compare windows versions and dll versions 2. List exports and imports for a given dll 3. create dependency tree for dlls 4. Determine which APIs are used by specific applications 5. Determine most used / least used APIs and dlls (pinpoint what functionality is important for many apps) 6. Compare ordinals across windows versions (helps determine when WINE should / should not export by ordinal)

2 1

Valgrind/Wine
by Zach Gorman 21 Jul '04

21 Jul '04

The latest build of valgrind that supports wine is now 8 months stale, and it doesn't seem to work on the wine head. Adam Gundy did some great work on this, and it would be a shame to see it go to waste. Is anyone out there able to pick up the torch on this? Zach

1 0

MFC and RtlpWaitForCriticalSection
by jake＠mail.nnov.ru 21 Jul '04

21 Jul '04

Hello, I.m trying to compile MFC with Winelib. I switched off some code in MFC ( richedit, oledb etc ) and have it a draft version compiled/linked but when trying to use it in a simple console or GUI app I have a .err: ntdll:RtlpWaitForCriticalSection section 0x78034120 "?" wait timed out in thread... message on start and the app hangs. Wine ( 04-2004 ) displays this message on LoadLibrary(MFC) in a generated wrapper code. I also compiled the similar .truncated. MFC version on win32 and all works ok there, at least for my simple apps. I.d really appreciate any hints how to debug it and why it may happen. Thanks -- Eugene

1 0

Fix DirectSound's primary buffer Volume and Pan handling
by Francois Gouget 21 Jul '04

21 Jul '04

Currently the way DirectSound handles Volume and Pan is wrong: * whenever a primary buffer is created (e.g. in DirectSoundCreate()) we initialize an internal variable that sets the volume to the max and pan to the center. * we also call IDsDriverBuffer_SetVolumePan() or waveOutSetVolume() to set the system volume to that value. On my machine this has the same effect as amixer set PCM 100% * we ignore changes in the volume or balance made outside of DirectSound. So if the user does: amixer set PCM 50% And then the application calls GetVolume() it will still get 0 (i.e. max volume) This is not what happens on Windows. On Windows primary buffers don't have their internal volume. Instead SetVolume()/SetPan() and GetVolume()/GetPan() query directly the underlying volume. I hacked the dsound.c test to verify this. Basically, now it does the following: * it calls GetVolume() and GetPan() and prints the results * it sleeps for 20 seconds * during these 20 seconds, start Windows' mixer control, and change the 'Wave Sound' (translated from French) volume and/or balance. * the test then calls GetVolume() and GetPan() and prints the results again Running the test we can see that the second time DierctSound returns the new volume: dsound.c:771:Primary volume=-566 pan=0 dsound.c:776:Primary volume=-566 pan=0 --- the test sleeps here while we change the volume --- dsound.c:782:Primary volume=-1438 pan=0 I attached the dsound.c test patch so this can be cross-checked. You will note that I also played with the secondary buffers to check the effect changing the volume on a secondary buffer would have on the system volume: it has none but Wine already does the right thing (a bit surprisingly). (for secondary buffers SetVolume() has a call to IDsDriverBuffer_SetVolumePan() but that branch is not taken so we do a DSOUND_ForceRemix() instead. I'm not sure if we should ever go through this IDsDriverBuffer_SetVolumePan() branch) I also patched DirectSound to fix the problem. The one thing that bothers me is that I did not find the equivalent of an IDsDriverBuffer_GetVolumePan(). I.e. we can use the driver to set the volume but not to query it. That's pretty strange. I wonder how DirectSound gets the system volume on Windows. In Wine what I did is simply use waveOutGetVolume() on dsound->hwo. Then I pass this through DSOUND_AmpFactorToVolPan() to convert these 'AmpFactors' into the regular Vol/Pan used by DirectSound. Comment and improvement suggestions welcome. If nobody objects I'll submit this to wine-patches tomorrow. -- Francois Gouget fgouget(a)codeweavers.com Index: dlls/dsound/tests/dsound.c =================================================================== RCS file: /var/cvs/wine/dlls/dsound/tests/dsound.c,v retrieving revision 1.30 diff -u -r1.30 dsound.c --- dlls/dsound/tests/dsound.c 21 Jul 2004 03:23:13 -0000 1.30 +++ dlls/dsound/tests/dsound.c 21 Jul 2004 12:27:48 -0000 @@ -745,11 +745,11 @@ primary=NULL; ZeroMemory(&bufdesc, sizeof(bufdesc)); bufdesc.dwSize=sizeof(bufdesc); - bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER|DSBCAPS_CTRLVOLUME; + bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER|DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN; rc=IDirectSound_CreateSoundBuffer(dso,&bufdesc,&primary,NULL); ok(rc==DS_OK && primary!=NULL,"CreateSoundBuffer failed to create a primary buffer: 0x%lx\n",rc); if (rc==DS_OK && primary!=NULL) { - LONG vol; + LONG vol,pan; /* Try to create a second primary buffer */ /* DSOUND: Error: The primary buffer already exists. Any changes made to the buffer description will be ignored. */ @@ -765,7 +765,21 @@ ok(rc!=DS_OK,"IDirectSound_DuplicateSoundBuffer primary buffer should have failed 0x%lx\n",rc); rc=IDirectSoundBuffer_GetVolume(primary,&vol); - ok(rc==DS_OK,"GetVolume failed: 0x%lx\n",rc); + ok(rc==DS_OK,"Primary GetVolume failed: %s\n",DXGetErrorString9(rc)); + rc=IDirectSoundBuffer_GetPan(primary,&pan); + ok(rc==DS_OK,"Primary GetPan failed: %s\n",DXGetErrorString9(rc)); + trace("Primary volume=%ld pan=%ld\n",vol,pan); + rc=IDirectSoundBuffer_SetVolume(primary,vol); + ok(rc==DS_OK,"Primary SetVolume failed: %s\n",DXGetErrorString9(rc)); + rc=IDirectSoundBuffer_SetPan(primary,pan); + ok(rc==DS_OK,"Primary SetPan failed: %s\n",DXGetErrorString9(rc)); + trace("Primary volume=%ld pan=%ld\n",vol,pan); + Sleep(20000); + rc=IDirectSoundBuffer_GetVolume(primary,&vol); + ok(rc==DS_OK,"Primary GetVolume failed: %s\n",DXGetErrorString9(rc)); + rc=IDirectSoundBuffer_GetPan(primary,&pan); + ok(rc==DS_OK,"Primary GetPan failed: %s\n",DXGetErrorString9(rc)); + trace("Primary volume=%ld pan=%ld\n",vol,pan); if (winetest_interactive) { @@ -828,7 +842,7 @@ ZeroMemory(&bufdesc, sizeof(bufdesc)); bufdesc.dwSize=sizeof(bufdesc); - bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER; + bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER|DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN; rc=IDirectSound_CreateSoundBuffer(dso,&bufdesc,&primary,NULL); ok(rc==DS_OK && primary!=NULL,"CreateSoundBuffer failed to create a primary buffer 0x%lx\n", rc); @@ -838,7 +852,7 @@ secondary=NULL; ZeroMemory(&bufdesc, sizeof(bufdesc)); bufdesc.dwSize=sizeof(bufdesc); - bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2; + bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2|DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN; bufdesc.dwBufferBytes=wfx.nAvgBytesPerSec*BUFFER_LEN/1000; bufdesc.lpwfxFormat=&wfx; trace(" Testing a secondary buffer at %ldx%dx%d\n", @@ -847,6 +861,27 @@ ok(rc==DS_OK && secondary!=NULL,"CreateSoundBuffer failed to create a secondary buffer 0x%lx\n",rc); if (rc==DS_OK && secondary!=NULL) { + LONG vol,pan; + + rc=IDirectSoundBuffer_GetVolume(secondary,&vol); + ok(rc==DS_OK,"GetVolume(secondary) failed: %s\n",DXGetErrorString9(rc)); + rc=IDirectSoundBuffer_GetPan(secondary,&pan); + ok(rc==DS_OK,"GetPan(secondary) failed: %s\n",DXGetErrorString9(rc)); + trace("Secondary volume=%ld pan=%ld\n",vol,pan); + vol=-1800; + rc=IDirectSoundBuffer_SetVolume(secondary,vol); + ok(rc==DS_OK,"SetVolume(secondary) failed: %s\n",DXGetErrorString9(rc)); + rc=IDirectSoundBuffer_GetVolume(secondary,&vol); + ok(rc==DS_OK,"GetVolume(secondary) failed: %s\n",DXGetErrorString9(rc)); + rc=IDirectSoundBuffer_GetPan(secondary,&pan); + ok(rc==DS_OK,"GetPan(secondary) failed: %s\n",DXGetErrorString9(rc)); + trace("Secondary volume=%ld pan=%ld\n",vol,pan); + rc=IDirectSoundBuffer_GetVolume(primary,&vol); + ok(rc==DS_OK,"Primary GetVolume failed: %s\n",DXGetErrorString9(rc)); + rc=IDirectSoundBuffer_GetPan(primary,&pan); + ok(rc==DS_OK,"Primary GetPan failed: %s\n",DXGetErrorString9(rc)); + trace("Primary volume=%ld pan=%ld\n",vol,pan); + test_buffer(dso,secondary,0,FALSE,0,FALSE,0,winetest_interactive,1.0,0,NULL,0,0); ref=IDirectSoundBuffer_Release(secondary); Index: dlls/dsound/dsound.c =================================================================== RCS file: /var/cvs/wine/dlls/dsound/dsound.c,v retrieving revision 1.6 diff -u -r1.6 dsound.c --- dlls/dsound/dsound.c 19 Jul 2004 20:06:22 -0000 1.6 +++ dlls/dsound/dsound.c 21 Jul 2004 09:34:19 -0000 @@ -892,10 +892,6 @@ pDS->drvcaps.dwPrimaryBuffers = 1; } - pDS->volpan.lVolume = 0; - pDS->volpan.lPan = 0; - DSOUND_RecalcVolPan(&(pDS->volpan)); - InitializeCriticalSection(&(pDS->mixlock)); RtlInitializeResource(&(pDS->lock)); Index: dlls/dsound/dsound_private.h =================================================================== RCS file: /var/cvs/wine/dlls/dsound/dsound_private.h,v retrieving revision 1.19 diff -u -r1.19 dsound_private.h --- dlls/dsound/dsound_private.h 21 Jul 2004 03:23:13 -0000 1.19 +++ dlls/dsound/dsound_private.h 21 Jul 2004 12:27:47 -0000 @@ -91,7 +91,6 @@ IDirectSoundBufferImpl** buffers; RTL_RWLOCK lock; CRITICAL_SECTION mixlock; - DSVOLUMEPAN volpan; PrimaryBufferImpl* primary; DSBUFFERDESC dsbd; DWORD speaker_config; @@ -450,6 +449,7 @@ extern IClassFactoryImpl DSOUND_FULLDUPLEX_CF; void DSOUND_RecalcVolPan(PDSVOLUMEPAN volpan); +void DSOUND_AmpFactorToVolPan(PDSVOLUMEPAN volpan); void DSOUND_RecalcFormat(IDirectSoundBufferImpl *dsb); /* primary.c */ Index: dlls/dsound/mixer.c =================================================================== RCS file: /var/cvs/wine/dlls/dsound/mixer.c,v retrieving revision 1.20 diff -u -r1.20 mixer.c --- dlls/dsound/mixer.c 12 Jan 2004 21:02:22 -0000 1.20 +++ dlls/dsound/mixer.c 21 Jul 2004 11:21:55 -0000 @@ -20,6 +20,7 @@ */ #include "config.h" +#define _GNU_SOURCE /* for round() in math.h */ #include <assert.h> #include <stdarg.h> #include <stdio.h> @@ -54,6 +55,7 @@ double temp; TRACE("(%p)\n",volpan); + TRACE("Vol=%ld Pan=%ld\n", volpan->lVolume, volpan->lPan); /* the AmpFactors are expressed in 16.16 fixed point */ volpan->dwVolAmpFactor = (ULONG) (pow(2.0, volpan->lVolume / 600.0) * 0xffff); /* FIXME: dwPan{Left|Right}AmpFactor */ @@ -67,6 +69,39 @@ TRACE("left = %lx, right = %lx\n", volpan->dwTotalLeftAmpFactor, volpan->dwTotalRightAmpFactor); } +void DSOUND_AmpFactorToVolPan(PDSVOLUMEPAN volpan) +{ + double left,right; + TRACE("(%p)\n",volpan); + + TRACE("left=%lx, right=%lx\n",volpan->dwTotalLeftAmpFactor,volpan->dwTotalRightAmpFactor); + if (volpan->dwTotalLeftAmpFactor==0) + left=-10000; + else + left=600 * log(((double)volpan->dwTotalLeftAmpFactor) / 0xffff) / log(2); + if (volpan->dwTotalRightAmpFactor==0) + right=-10000; + else + right=600 * log(((double)volpan->dwTotalRightAmpFactor) / 0xffff) / log(2); + if (left<right) + { + volpan->lVolume=round(right); + volpan->dwVolAmpFactor=volpan->dwTotalRightAmpFactor; + } + else + { + volpan->lVolume=round(left); + volpan->dwVolAmpFactor=volpan->dwTotalLeftAmpFactor; + } + if (volpan->lVolume < -10000) + volpan->lVolume=-10000; + volpan->lPan=round(right-left); + if (volpan->lPan < -10000) + volpan->lPan=-10000; + + TRACE("Vol=%ld Pan=%ld\n", volpan->lVolume, volpan->lPan); +} + void DSOUND_RecalcFormat(IDirectSoundBufferImpl *dsb) { DWORD sw; Index: dlls/dsound/primary.c =================================================================== RCS file: /var/cvs/wine/dlls/dsound/primary.c,v retrieving revision 1.25 diff -u -r1.25 primary.c --- dlls/dsound/primary.c 13 Jul 2004 23:35:09 -0000 1.25 +++ dlls/dsound/primary.c 21 Jul 2004 11:06:06 -0000 @@ -74,8 +74,6 @@ HRESULT err = DS_OK; TRACE("(%p)\n",This); - DSOUND_RecalcVolPan(&(This->volpan)); - /* are we using waveOut stuff? */ if (!This->driver) { LPBYTE newbuf; @@ -135,11 +133,6 @@ } if ((err == DS_OK) && (merr != DS_OK)) err = merr; - - if (!err) { - DWORD vol = (This->volpan.dwTotalLeftAmpFactor & 0xffff) | (This->volpan.dwTotalRightAmpFactor << 16); - err = mmErr(waveOutSetVolume(This->hwo, vol)); - } } else { if (!This->hwbuf) { err = IDsDriver_CreateSoundBuffer(This->driver,&(This->wfx), @@ -154,7 +147,6 @@ if (dsound->state == STATE_PLAYING) dsound->state = STATE_STARTING; else if (dsound->state == STATE_STOPPING) dsound->state = STATE_STOPPED; } - err = IDsDriverBuffer_SetVolumePan(This->hwbuf, &(This->volpan)); } return err; @@ -458,7 +450,8 @@ ) { ICOM_THIS(PrimaryBufferImpl,iface); IDirectSoundImpl* dsound = This->dsound; - LONG oldVol; + DWORD ampfactors; + DSVOLUMEPAN volpan; TRACE("(%p,%ld)\n",This,vol); @@ -475,24 +468,26 @@ /* **** */ EnterCriticalSection(&(dsound->mixlock)); - oldVol = dsound->volpan.lVolume; - dsound->volpan.lVolume = vol; - DSOUND_RecalcVolPan(&dsound->volpan); - - if (vol != oldVol) { - if (dsound->hwbuf) { - HRESULT hres; - hres = IDsDriverBuffer_SetVolumePan(dsound->hwbuf, &(dsound->volpan)); - if (hres != DS_OK) { - LeaveCriticalSection(&(dsound->mixlock)); - WARN("IDsDriverBuffer_SetVolumePan failed\n"); - return hres; - } - } else { - DWORD vol = (dsound->volpan.dwTotalLeftAmpFactor & 0xffff) | (dsound->volpan.dwTotalRightAmpFactor << 16); - waveOutSetVolume(dsound->hwo, vol); - } - } + waveOutGetVolume(dsound->hwo, &ampfactors); + volpan.dwTotalLeftAmpFactor=ampfactors & 0xffff; + volpan.dwTotalRightAmpFactor=ampfactors >> 16; + DSOUND_AmpFactorToVolPan(&volpan); + if (vol != volpan.lVolume) { + volpan.lVolume=vol; + DSOUND_RecalcVolPan(&volpan); + if (dsound->hwbuf) { + HRESULT hres; + hres = IDsDriverBuffer_SetVolumePan(dsound->hwbuf, &volpan); + if (hres != DS_OK) { + LeaveCriticalSection(&(dsound->mixlock)); + WARN("IDsDriverBuffer_SetVolumePan failed\n"); + return hres; + } + } else { + ampfactors = (volpan.dwTotalLeftAmpFactor & 0xffff) | (volpan.dwTotalRightAmpFactor << 16); + waveOutSetVolume(dsound->hwo, ampfactors); + } + } LeaveCriticalSection(&(dsound->mixlock)); /* **** */ @@ -504,6 +499,8 @@ LPDIRECTSOUNDBUFFER8 iface,LPLONG vol ) { ICOM_THIS(PrimaryBufferImpl,iface); + DWORD ampfactors; + DSVOLUMEPAN volpan; TRACE("(%p,%p)\n",This,vol); if (!(This->dsound->dsbd.dwFlags & DSBCAPS_CTRLVOLUME)) { @@ -516,7 +513,11 @@ return DSERR_INVALIDPARAM; } - *vol = This->dsound->volpan.lVolume; + waveOutGetVolume(dsound->hwo, &ampfactors); + volpan.dwTotalLeftAmpFactor=ampfactors & 0xffff; + volpan.dwTotalRightAmpFactor=ampfactors >> 16; + DSOUND_AmpFactorToVolPan(&volpan); + *vol = volpan.lVolume; return DS_OK; } @@ -769,7 +770,8 @@ ) { ICOM_THIS(PrimaryBufferImpl,iface); IDirectSoundImpl* dsound = This->dsound; - LONG oldPan; + DWORD ampfactors; + DSVOLUMEPAN volpan; TRACE("(%p,%ld)\n",This,pan); @@ -786,25 +788,27 @@ /* **** */ EnterCriticalSection(&(dsound->mixlock)); - oldPan = dsound->volpan.lPan; - dsound->volpan.lPan = pan; - DSOUND_RecalcVolPan(&dsound->volpan); - - if (pan != oldPan) { - if (dsound->hwbuf) { - HRESULT hres; - hres = IDsDriverBuffer_SetVolumePan(dsound->hwbuf, &(dsound->volpan)); - if (hres != DS_OK) { - LeaveCriticalSection(&(dsound->mixlock)); - WARN("IDsDriverBuffer_SetVolumePan failed\n"); - return hres; - } - } - else { - DWORD vol = (dsound->volpan.dwTotalLeftAmpFactor & 0xffff) | (dsound->volpan.dwTotalRightAmpFactor << 16); - waveOutSetVolume(dsound->hwo, vol); - } - } + waveOutGetVolume(dsound->hwo, &ampfactors); + volpan.dwTotalLeftAmpFactor=ampfactors & 0xffff; + volpan.dwTotalRightAmpFactor=ampfactors >> 16; + DSOUND_AmpFactorToVolPan(&volpan); + if (pan != volpan.lPan) { + volpan.lPan=pan; + DSOUND_RecalcVolPan(&volpan); + if (dsound->hwbuf) { + HRESULT hres; + hres = IDsDriverBuffer_SetVolumePan(dsound->hwbuf, &volpan); + if (hres != DS_OK) { + LeaveCriticalSection(&(dsound->mixlock)); + WARN("IDsDriverBuffer_SetVolumePan failed\n"); + return hres; + } + } + else { + ampfactors = (volpan.dwTotalLeftAmpFactor & 0xffff) | (volpan.dwTotalRightAmpFactor << 16); + waveOutSetVolume(dsound->hwo, ampfactors); + } + } LeaveCriticalSection(&(dsound->mixlock)); /* **** */ @@ -816,6 +820,8 @@ LPDIRECTSOUNDBUFFER8 iface,LPLONG pan ) { ICOM_THIS(PrimaryBufferImpl,iface); + DWORD ampfactors; + DSVOLUMEPAN volpan; TRACE("(%p,%p)\n",This,pan); if (!(This->dsound->dsbd.dwFlags & DSBCAPS_CTRLPAN)) { @@ -828,8 +834,11 @@ return DSERR_INVALIDPARAM; } - *pan = This->dsound->volpan.lPan; - + waveOutGetVolume(dsound->hwo, &ampfactors); + volpan.dwTotalLeftAmpFactor=ampfactors & 0xffff; + volpan.dwTotalRightAmpFactor=ampfactors >> 16; + DSOUND_AmpFactorToVolPan(&volpan); + *pan = volpan.lPan; return DS_OK; }

1 0

Serial port problem in 200407016
by jeremy＠fantasticfamily.net 21 Jul '04

21 Jul '04

I seem to be having trouble communicating with my serial device. I have a Garming Rino GPS connected on /dev/ttyS0 using Mandrake 10.0, wine build 200407016. I read on 6/14/04 that some serial port issues were solved. permissons on /dev/ttyS0 are set correct and I've used setserial to make the baud rate 9600. In MapSource v2.01, I've set it to com1, 9600 as well. The program runs great under wine, but the is the error I get when I try to transfer maps to the unit (from WINEDEBUG=+comm,+file, +ntdll): <clip> trace:file:GetOverlappedResult (0x6c 0x406cee6c 0x406cdfe0 0) trace:comm:ClearCommError handle 0x6c cbInQue = 0 cbOutQue = 0 trace:file:CreateFileW L"C:\\windows\\win.ini" GENERIC_READ FILE_SHARE_READ attributes 0x80 trace:file:RtlDosPathNameToNtPathName_U (L"C:\\windows\\win.ini",0x406cade8,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"C:\\windows\\win.ini" 520 0x406cab68 (nil)) trace:ntdll:NtCreateFile handle=0x406caddc access=80000000 name=L"\\??\\C:\\windows\\win.ini" objattr=00000040 root=(nil) sec=(nil) io=0x406cade0 alloc_size=(nil) attr=00000080 sharing=00000001 disp=1 options=00000050 ea=(nil).0x00000000 trace:file:wine_nt_to_unix_file_name L"\\??\\C:\\windows\\win.ini" -> "/root/.wine/dosdevices/c:/windows/win.ini" trace:file:CreateFileW returning 0x64 trace:ntdll:NtQueryInformationFile (0x64,0x406cadd8,0x406cade0,0x00000024,0x00000004) trace:file:CreateFileW L"C:\\windows\\win.ini" GENERIC_READ FILE_SHARE_READ OPEN_EXISTING attributes 0x80 trace:file:RtlDosPathNameToNtPathName_U (L"C:\\windows\\win.ini",0x406cad7c,(nil),(nil)) trace:file:RtlGetFullPathName_U (L"C:\\windows\\win.ini" 520 0x406caafc (nil)) trace:ntdll:NtCreateFile handle=0x406cad70 access=80000000 name=L"\\??\\C:\\windows\\win.ini" objattr=00000040 root=(nil) sec=(nil) io=0x406cad74 alloc_size=(nil) </clip> Any Ideas? If you need more output from debug, I'd be happy to get it. Thanks in advance! Jeremy

2 1

Re: Fix winmm's check_position() tests
by Francois Gouget 21 Jul '04

21 Jul '04

Robert Reif wrote: > I would just revert the patch and recalculate duration based on the > fragment size. You need to keep the double because of integer > overflow in the MS calculation Well, it won't overflow for the tones we play because they just last a few seconds. But it will start overflowing when we reach 11 seconds so you're right, we should try to avoid that. Rewriting the way we compute samples will fix the first place where we could get an integer overflow: samples=bytes/(pwfx->wBitsPerSample/8*pwfx->nChannels); And since both TIME_MS and TIME_SMPTE essentially use the duration, I added a calculation of the duration, as a double obviously, near the top of check_position(). This fixes the second place where we could potentially get an overflow. > and integer underflow in the SMPTE calculation. The SMPTE calculation is float-based so I don't see how we can get an 'integer underflow'. > We need to add a ceil to the frame calculation to round > up partial frames. That's done already. Changelog: * dlls/winmm/tests/wave.c Francois Gouget <fgouget(a)codeweavers.com> Make sure we won't get an overflow in check_position() even if we play longer test tones. -- Francois Gouget fgouget(a)codeweavers.com Index: dlls/winmm/tests/wave.c =================================================================== RCS file: /var/cvs/wine/dlls/winmm/tests/wave.c,v retrieving revision 1.34 diff -u -r1.34 wave.c --- dlls/winmm/tests/wave.c 20 Jul 2004 22:09:53 -0000 1.34 +++ dlls/winmm/tests/wave.c 20 Jul 2004 22:53:55 -0000 @@ -215,9 +230,11 @@ { MMTIME mmtime; DWORD samples; + double duration; MMRESULT rc; - samples=bytes*8/pwfx->wBitsPerSample/pwfx->nChannels; + samples=bytes/(pwfx->wBitsPerSample/8*pwfx->nChannels); + duration=((double)samples)/pwfx->nSamplesPerSec; mmtime.wType = TIME_BYTES; rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); @@ -246,9 +263,9 @@ ok(rc==MMSYSERR_NOERROR, "waveOutGetPosition: device=%s rc=%s\n",dev_name(device),wave_out_error(rc)); if (mmtime.wType == TIME_MS) - ok(mmtime.u.ms==samples*1000/pwfx->nSamplesPerSec, + ok(mmtime.u.ms==floor(duration*1000.0), "waveOutGetPosition returned %ld ms, should be %ld\n", - mmtime.u.ms, samples*1000/pwfx->nSamplesPerSec); + mmtime.u.ms, floor(duration*1000.0)); else trace("TIME_MS not supported, returned %s\n",wave_time_format(mmtime.wType)); @@ -258,7 +275,6 @@ "waveOutGetPosition: device=%s rc=%s\n",dev_name(device),wave_out_error(rc)); if (mmtime.wType == TIME_SMPTE) { - double duration=((double)samples)/pwfx->nSamplesPerSec; BYTE frames=ceil(fmod(duration*mmtime.u.smpte.fps, mmtime.u.smpte.fps)); ok(mmtime.u.smpte.hour==(BYTE)(floor(duration/(60*60))) && mmtime.u.smpte.min==(BYTE)(fmod(floor(duration/60), 60)) &&

1 0

help with building with winelib on Mac os x
by Jeff Cooper 20 Jul '04

20 Jul '04

I am trying to build a "Hello World" app with winelib on Mac os x I have done so by mimicking how winemine is built or modifying the winemine make file to work with the hello world app. This uses GCC to build correct?.. I then try winemaker to create a make file, and when trying to build with that makefile I get lots of errors. This uses winegcc correct?. I think that is where the problem is... Any Ideas? help? What am I missing? Error: winebuild -o main.exe.dbg.c --debug -C. main.c winegcc -c -mno-cygwin -o main.exe.dbg.o main.exe.dbg.c winegcc -c -mno-cygwin -o main.o main.c In file included from /usr/local/include/wine/windows/winnt.h:24, from /usr/local/include/wine/windows/windef.h:203, from /usr/local/include/wine/windows/windows.h:38, from main.c:1: /usr/local/include/wine/windows/basetsd.h:154:3: #error Unknown CPU architecture! In file included from /usr/local/include/wine/windows/winnt.h:29, from /usr/local/include/wine/windows/windef.h:203, from /usr/local/include/wine/windows/windows.h:38, from main.c:1: /usr/local/include/wine/msvcrt/string.h:58: warning: conflicting types for built-in function `memcmp' /usr/local/include/wine/msvcrt/string.h:59: warning: conflicting types for built-in function `memcpy' /usr/local/include/wine/msvcrt/string.h:61: warning: conflicting types for built-in function `memset' /usr/local/include/wine/msvcrt/string.h:70: warning: conflicting types for built-in function `strncat' /usr/local/include/wine/msvcrt/string.h:71: warning: conflicting types for built-in function `strncmp' /usr/local/include/wine/msvcrt/string.h:72: warning: conflicting types for built-in function `strncpy' In file included from /usr/local/include/wine/windows/windef.h:203, from /usr/local/include/wine/windows/windows.h:38, from main.c:1: /usr/local/include/wine/windows/winnt.h:1170:2: #error You need to define a CONTEXT for your CPU In file included from /usr/local/include/wine/windows/windef.h:203, from /usr/local/include/wine/windows/windows.h:38, from main.c:1: /usr/local/include/wine/windows/winnt.h:1173: error: parse error before '*' token /usr/local/include/wine/windows/winnt.h:1173: warning: data definition has no type or storage class /usr/local/include/wine/windows/winnt.h:1489: error: parse error before "PCONTEXT" /usr/local/include/wine/windows/winnt.h:1489: warning: no semicolon at end of struct or union /usr/local/include/wine/windows/winnt.h:1490: warning: data definition has no type or storage class /usr/local/include/wine/windows/winnt.h:1502: error: parse error before "PCONTEXT" /usr/local/include/wine/windows/winnt.h:1514: error: parse error before "ExceptionInfo" /usr/local/include/wine/windows/winnt.h:1514: warning: `__stdcall__' attribute directive ignored /usr/local/include/wine/windows/winnt.h:1515: error: parse error before "ExceptionInfo" /usr/local/include/wine/windows/winnt.h:1515: warning: `__stdcall__' attribute directive ignored /usr/local/include/wine/windows/winnt.h:1518: error: parse error before "epointers" /usr/local/include/wine/windows/winnt.h:1518: warning: `__stdcall__' attribute directive ignored ...{similar errors with more header files}.. /usr/local/include/wine/windows/imm.h:543: warning: `__stdcall__' attribute directive ignored main.c:7: warning: `__stdcall__' attribute directive ignored winegcc -mwindows -mno-cygwin -o main.exe.so main.o main.exe.dbg.o -lodbc32 -lole32 -loleaut32 -lwinspool -luuid ld: table of contents for archive: /usr/local/lib/wine/libuuid.a is out of date; rerun ranlib(1) (can't load from it) winebuild: ld -r failed with status 256 winegcc: winebuild failed. make: *** [main.exe.so] Error 2

2 2

bind() test fails
by James Hawkins 20 Jul '04

20 Jul '04

Hi, I ran the winsock tests and the only failure i received was from bind: sock.c:660: Test failed: bind() failed error: 10048 I checked msdn and error 10048 is WSAEADDRINUSE. The code for the test of this part is: rc = bind(s2, (struct sockaddr*)&saddr, sizeof(saddr)); ok(rc==SOCKET_ERROR, "bind() succeeded\n"); reuse = 1; rc = setsockopt(s2, SOL_SOCKET, SO_REUSEADDR, (char*)&reuse, sizeof(reuse)); ok(rc==0, "setsockopt() failed error: %d\n", WSAGetLastError()); todo_wine { rc = bind(s2, (struct sockaddr*)&saddr, sizeof(saddr)); ok(rc==0, "bind() failed error: %d\n", WSAGetLastError()); } For this part of the test, we bind an address, saddr, with a socket, s2, and then set the SO_REUSEADDR option to 1 so that we should be able to bind again, but we're getting the error WSAEADDRINUSE which means that the fact that we are allowing multiple binds with the SO_REUSEADDR option is being ignored somewhere. I looked at the function declarations for the win32 and linux setsockopt. win32: WS_setsockopt(SOCKET s, int level, int optname, const char *optval, int optlen) linux: setsockopt (int __fd, int __level, int __optname, __const void *__optval, socklen_t __optlen) At one point in WS_setsockopt we make a call to the linux setsockopt and im wondering if the problem is when we call this version. Is it not a problem that WS_setsockopt's optval parameter is of type const char * and setsockopt's optval parameter is __const void *? I've searched for a while about this problem and I can't seem to spot the fix. If i'm totally off the mark on this one, let me know as well. Thanks for the help. For further reference see: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/wi… http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/wi… -- James Hawkins

1 0

Re: Don't crash on NULL data in RegSetValueEx
by Andreas Mohr 20 Jul '04

20 Jul '04

Hi, On Tue, Jul 20, 2004 at 03:25:57PM +0100, Mike Hearn wrote: > I tested this on Win98. The platform SDK installer does this. Ah, right, my uncommitted patch from April 14. > + if (!data) return ERROR_INVALID_PARAMETER; > + > if (!is_version_nt()) /* win95 */ > { Are you sure this is correct? free-av.de called RegSetValueEx with a NULL value on Win9x setting only, so maybe NT handles this differently? (I thus placed the check into the win9x branch only) Andreas Mohr

1 0

Re: Fix winmm's check_position() tests
by Robert Reif 20 Jul '04

20 Jul '04

Please revert this patch. It is wrong and produces the following errors in windows xp: Francois Gouget wrote: > > I got errors when running the winmm test in interactive mode. Checking > it on Windows it turns out that waveOutGetPosition() is supposed to > return the number of samples played plus one, and not the number of > samples played as the test expected. The number of bytes also reflects > that extra sample. > So I modified it accordingly. > > > Changelog: > > * dlls/winmm/tests/wave.c > > Francois Gouget <fgouget(a)codeweavers.com> > Fix the check_position() test: on Windows waveOutGetPosition() > returns the number of samples played plus one (also one extra sample > for the byte count). > >------------------------------------------------------------------------ > >Index: dlls/winmm/tests/wave.c >=================================================================== >RCS file: /var/cvs/wine/dlls/winmm/tests/wave.c,v >retrieving revision 1.30 >diff -u -r1.30 wave.c >--- dlls/winmm/tests/wave.c 14 Jun 2004 17:54:45 -0000 1.30 >+++ dlls/winmm/tests/wave.c 19 Jul 2004 15:07:59 -0000 >@@ -204,18 +209,18 @@ > ok(rc==MMSYSERR_NOERROR, > "waveOutGetPosition: device=%s rc=%s\n",dev_name(device),wave_out_error(rc)); > if (mmtime.wType == TIME_BYTES) >- ok(mmtime.u.cb==duration*pwfx->nAvgBytesPerSec, >+ ok(mmtime.u.cb==duration*pwfx->nAvgBytesPerSec+pwfx->wBitsPerSample/8, > "waveOutGetPosition returned %ld bytes, should be %ld\n", >- mmtime.u.cb, (DWORD)(duration*pwfx->nAvgBytesPerSec)); >+ mmtime.u.cb, (DWORD)(duration*pwfx->nAvgBytesPerSec)+pwfx->wBitsPerSample/8); > > mmtime.wType = TIME_SAMPLES; > rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); > ok(rc==MMSYSERR_NOERROR, > "waveOutGetPosition: device=%s rc=%s\n",dev_name(device),wave_out_error(rc)); > if (mmtime.wType == TIME_SAMPLES) >- ok(mmtime.u.sample==duration*pwfx->nSamplesPerSec, >+ ok(mmtime.u.sample==duration*pwfx->nSamplesPerSec+1, > "waveOutGetPosition returned %ld samples, should be %ld\n", >- mmtime.u.sample, (DWORD)(duration*pwfx->nSamplesPerSec)); >+ mmtime.u.sample, (DWORD)(duration*pwfx->nSamplesPerSec)+1); > > mmtime.wType = TIME_MS; > rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); > > wave.c:514:found 4 WaveOut devices wave.c:403: 0: "SB Live! Audio [DEA0]" (\\?\pci#ven_1102&dev_0002&subsys_80651102&rev_0a#4&1c660dd6&0&18f0#{6994ad04-93ef-11d0-a3cc-00a0c9223196}\wavecyc) 5.10 (1:100): channels=65535 formats=bffff support=002c(WAVECAPS_VOLUME WAVECAPS_LRVOLUME WAVECAPS_SAMPLEACCURATE) wave.c:412:Playing a 5 seconds reference tone. wave.c:413:All subsequent tones should be identical to this one. wave.c:414:Listen for stutter, changes in pitch, volume, etc. wave.c:311:Playing 5 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=5031 wave.c:208: Test failed: waveOutGetPosition returned 110250 bytes, should be 110251 wave.c:217: Test failed: waveOutGetPosition returned 110250 samples, should be 110251 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1032 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 wave.c:326:sound duration=1032 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1032 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 WAVE_MAPPED wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 WAVE_MAPPED wave.c:326:sound duration=1032 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_MAPPED wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 WAVE_MAPPED wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x2 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x1 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x2 wave.c:326:sound duration=1032 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88201 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88201 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88201 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x1 WAVE_MAPPED wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x2 wave.c:326:sound duration=1032 wave.c:208: Test failed: waveOutGetPosition returned 176400 bytes, should be 176402 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 176400 bytes, should be 176402 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x2 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 176400 bytes, should be 176402 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x2 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x2 wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x2 wave.c:326:sound duration=1047 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1032 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x1 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x2 wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 384000 bytes, should be 384002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 384000 bytes, should be 384002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x2 WAVE_MAPPED wave.c:326:sound duration=1031 wave.c:208: Test failed: waveOutGetPosition returned 384000 bytes, should be 384002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:462:Testing invalid format: 11 bits per sample wave.c:483:Testing invalid format: 2 MHz sample rate wave.c:403: 1: "SB Audigy 2 ZS Audio [DEC0]" (\\?\pci#ven_1102&dev_0004&subsys_20021102&rev_04#4&1c660dd6&0&08f0#{6994ad04-93ef-11d0-a3cc-00a0c9223196}\wavepci) 5.10 (1:100): channels=65535 formats=bffff support=002c(WAVECAPS_VOLUME WAVECAPS_LRVOLUME WAVECAPS_SAMPLEACCURATE) wave.c:412:Playing a 5 seconds reference tone. wave.c:413:All subsequent tones should be identical to this one. wave.c:414:Listen for stutter, changes in pitch, volume, etc. wave.c:311:Playing 5 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=5000 wave.c:208: Test failed: waveOutGetPosition returned 110250 bytes, should be 110251 wave.c:217: Test failed: waveOutGetPosition returned 110250 samples, should be 110251 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 wave.c:326:sound duration=984 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 wave.c:326:sound duration=984 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=984 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=984 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=984 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88201 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88201 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88201 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 88200 bytes, should be 88202 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 176400 bytes, should be 176402 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 176400 bytes, should be 176402 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 44100x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 176400 bytes, should be 176402 wave.c:217: Test failed: waveOutGetPosition returned 44100 samples, should be 44101 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x1 wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 48000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 48000 samples, should be 48001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 96000 bytes, should be 96001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192001 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 192000 bytes, should be 192002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 384000 bytes, should be 384002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 384000 bytes, should be 384002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 96000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 384000 bytes, should be 384002 wave.c:217: Test failed: waveOutGetPosition returned 96000 samples, should be 96001 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:462:Testing invalid format: 11 bits per sample wave.c:483:Testing invalid format: 2 MHz sample rate wave.c:403: 2: "Creative Sound Blaster PCI" (\\?\pci#ven_1274&dev_5880&subsys_80011274&rev_04#4&1c660dd6&0&10f0#{6994ad04-93ef-11d0-a3cc-00a0c9223196}\wave) 5.10 (1:100): channels=65535 formats=bffff support=002c(WAVECAPS_VOLUME WAVECAPS_LRVOLUME WAVECAPS_SAMPLEACCURATE) wave.c:412:Playing a 5 seconds reference tone. wave.c:413:All subsequent tones should be identical to this one. wave.c:414:Listen for stutter, changes in pitch, volume, etc. wave.c:311:Playing 5 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=5000 wave.c:208: Test failed: waveOutGetPosition returned 110250 bytes, should be 110251 wave.c:217: Test failed: waveOutGetPosition returned 110250 samples, should be 110251 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 8000 bytes, should be 8001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 8000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 8000 samples, should be 8001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 16000 bytes, should be 16001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32001 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 32000 bytes, should be 32002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 16000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 64000 bytes, should be 64002 wave.c:217: Test failed: waveOutGetPosition returned 16000 samples, should be 16001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 12000x16x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 48000 bytes, should be 48002 wave.c:217: Test failed: waveOutGetPosition returned 12000 samples, should be 12001 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x1 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 11025 bytes, should be 11026 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x 8x2 WAVE_MAPPED wave.c:326:sound duration=1000 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22052 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 11025x16x2 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 11025 samples, should be 11026 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x1 WAVE_MAPPED wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 22050 bytes, should be 22051 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 WAVE_FORMAT_DIRECT wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x 8x2 WAVE_MAPPED wave.c:326:sound duration=1015 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44101 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 wave.c:326:sound duration=1016 wave.c:208: Test failed: waveOutGetPosition returned 44100 bytes, should be 44102 wave.c:217: Test failed: waveOutGetPosition returned 22050 samples, should be 22051 wave.c:311:Playing 1 second 440Hz tone at 22050x16x1 WAVE_FORMAT_DIRECT

3 3

winetest timeout question
by Robert Reif 20 Jul '04

20 Jul '04

I would like to change the wave tests to always play and record so all code paths can be exercised. A normal run for a single sound card takes over 2 minutes so the test times out before test completion. Has anyone considered changing the timeout logic to be reset every time something is printed? This would allow long tests that periodically output something to run more than 2 minutes. Timeout would only occur 2 minutes after the last output.

3 2

Re: winmm: Fix TIME_SMPTE test
by Robert Reif 20 Jul '04

20 Jul '04

SMPTE support in windows is not a hardware feature. winmm just takes the byte count read/written and converts it to a different format. Windows rounds up partial frames (hence ceil). I thought it was strange but thats what it does. There is also an off by one bug in msacm pcm conversions which triggers on certain conversions. The only way to confirm windows behaviors is to run the winmm test in interactive mode. winetest would need to be changes to run it that way and the tests could take longer than the timeout period when multiple sound cards are present. Could we please run the winmm tests in interactive mode by default and then make changes if necessary to duplicate windows behavior rather than just making untested changes. The winmm tests work fine on my hardware in windows xp as is and also in wine except for the msacm off by one bug with certain format conversions. Francois Gouget wrote: > > I got failures when running the winmm conformance test in Wine: > > wave.c:239: Test failed: waveOutGetPosition returned 0:0:5 1, should > be 0:0:5 0 > > This test checks that waveOutGetPosition() returns the correct value > when asked for the TIMP_SMPTE position but Wine would systematically > return 1 as the frame instead of 0. > > First I tried to check what Windows did in that case but I was not > able to find a Windows version that supports the TIME_SMPTE format > (tried Win95, Win98, NT4, WinXP). This means applications are unlikely > to actually ever use this... maybe this is a 16bit thing. > > The reason why Wine always returns 1 in the frame is a combination of > two factors: > > * we start from dwPlayedTotal which is always the number of played > samples plus 1. So if we played 1 second at 48000x8x1 we'd get 48004 > instead of 48000. > * then convert this into hours, minutes, seconds and the remainder > (8.3e-5) gives us the frames. But we use ceil() which converts that to 1! > > So I just modified each driver's implementation to use round() instead > of ceil(). IMO ceil() is the wrong tool for the job. With floats, > after a few operations you quickly end up with 1e-30 or -1e-30, but > never with big round 0. So ceil() is going to give you 0 or 1 > quasi-randomly. At least round() behaves sanely. > > Maybe we should also remove that one extra sample but given I have not > been able to confirm the Windows behavior I'd rather not worry about it. > I'm willing to change my mind if someone feels strongly about it or > can provide more data about how Windows really behaves. > > > Changelog: > > * dlls/winmm/winealsa/audio.c > dlls/winmm/winearts/audio.c > dlls/winmm/wineaudioio/audio.c > dlls/winmm/winejack/audio.c > dlls/winmm/winenas/audio.c > dlls/winmm/wineoss/audio.c > > Francois Gouget <fgouget(a)codeweavers.com> > Use round() instead of ceil() in wodGetPosition(TIME_SMPTE). > Fixes the corresponding winmm conformance test. > > >------------------------------------------------------------------------ > >Index: dlls/winmm/winealsa/audio.c >=================================================================== >RCS file: /var/cvs/wine/dlls/winmm/winealsa/audio.c,v >retrieving revision 1.45 >diff -u -r1.45 audio.c >--- dlls/winmm/winealsa/audio.c 14 Jun 2004 16:59:34 -0000 1.45 >+++ dlls/winmm/winealsa/audio.c 16 Jul 2004 23:11:24 -0000 >@@ -1873,7 +1873,7 @@ > time -= lpTime->u.smpte.min * 60; > lpTime->u.smpte.sec = time; > time -= lpTime->u.smpte.sec; >- lpTime->u.smpte.frame = ceil(time * 30); >+ lpTime->u.smpte.frame = round(time * 30); > lpTime->u.smpte.fps = 30; > TRACE("TIME_SMPTE=%02u:%02u:%02u:%02u\n", > lpTime->u.smpte.hour, lpTime->u.smpte.min, >Index: dlls/winmm/winearts/audio.c >=================================================================== >RCS file: /var/cvs/wine/dlls/winmm/winearts/audio.c,v >retrieving revision 1.20 >diff -u -r1.20 audio.c >--- dlls/winmm/winearts/audio.c 15 Jun 2004 20:25:11 -0000 1.20 >+++ dlls/winmm/winearts/audio.c 16 Jul 2004 23:11:36 -0000 >@@ -1427,7 +1427,7 @@ > time -= lpTime->u.smpte.min * 60; > lpTime->u.smpte.sec = time; > time -= lpTime->u.smpte.sec; >- lpTime->u.smpte.frame = ceil(time * 30); >+ lpTime->u.smpte.frame = round(time * 30); > lpTime->u.smpte.fps = 30; > TRACE("TIME_SMPTE=%02u:%02u:%02u:%02u\n", > lpTime->u.smpte.hour, lpTime->u.smpte.min, >Index: dlls/winmm/wineaudioio/audio.c >=================================================================== >RCS file: /var/cvs/wine/dlls/winmm/wineaudioio/audio.c,v >retrieving revision 1.12 >diff -u -r1.12 audio.c >--- dlls/winmm/wineaudioio/audio.c 1 Jun 2004 20:22:11 -0000 1.12 >+++ dlls/winmm/wineaudioio/audio.c 16 Jul 2004 23:11:48 -0000 >@@ -1121,7 +1121,7 @@ > time -= lpTime->u.smpte.min * 60; > lpTime->u.smpte.sec = time; > time -= lpTime->u.smpte.sec; >- lpTime->u.smpte.frame = ceil(time * 30); >+ lpTime->u.smpte.frame = round(time * 30); > lpTime->u.smpte.fps = 30; > TRACE("TIME_SMPTE=%02u:%02u:%02u:%02u\n", > lpTime->u.smpte.hour, lpTime->u.smpte.min, >Index: dlls/winmm/winejack/audio.c >=================================================================== >RCS file: /var/cvs/wine/dlls/winmm/winejack/audio.c,v >retrieving revision 1.12 >diff -u -r1.12 audio.c >--- dlls/winmm/winejack/audio.c 1 Jun 2004 20:22:11 -0000 1.12 >+++ dlls/winmm/winejack/audio.c 16 Jul 2004 23:12:01 -0000 >@@ -1591,7 +1591,7 @@ > time -= lpTime->u.smpte.min * 60; > lpTime->u.smpte.sec = time; > time -= lpTime->u.smpte.sec; >- lpTime->u.smpte.frame = ceil(time * 30); >+ lpTime->u.smpte.frame = round(time * 30); > lpTime->u.smpte.fps = 30; > TRACE("TIME_SMPTE=%02u:%02u:%02u:%02u\n", > lpTime->u.smpte.hour, lpTime->u.smpte.min, >Index: dlls/winmm/winenas/audio.c >=================================================================== >RCS file: /var/cvs/wine/dlls/winmm/winenas/audio.c,v >retrieving revision 1.14 >diff -u -r1.14 audio.c >--- dlls/winmm/winenas/audio.c 1 Jun 2004 20:22:11 -0000 1.14 >+++ dlls/winmm/winenas/audio.c 16 Jul 2004 23:13:14 -0000 >@@ -1165,7 +1165,7 @@ > time -= lpTime->u.smpte.min * 60; > lpTime->u.smpte.sec = time; > time -= lpTime->u.smpte.sec; >- lpTime->u.smpte.frame = ceil(time * 30); >+ lpTime->u.smpte.frame = round(time * 30); > lpTime->u.smpte.fps = 30; > TRACE("TIME_SMPTE=%02u:%02u:%02u:%02u\n", > lpTime->u.smpte.hour, lpTime->u.smpte.min, >Index: dlls/winmm/wineoss/audio.c >=================================================================== >RCS file: /var/cvs/wine/dlls/winmm/wineoss/audio.c,v >retrieving revision 1.134 >diff -u -r1.134 audio.c >--- dlls/winmm/wineoss/audio.c 14 Jul 2004 21:44:50 -0000 1.134 >+++ dlls/winmm/wineoss/audio.c 16 Jul 2004 23:08:18 -0000 >@@ -2123,7 +2123,7 @@ > time -= lpTime->u.smpte.min * 60; > lpTime->u.smpte.sec = time; > time -= lpTime->u.smpte.sec; >- lpTime->u.smpte.frame = ceil(time * 30); >+ lpTime->u.smpte.frame = round(time * 30); > lpTime->u.smpte.fps = 30; > TRACE("TIME_SMPTE=%02u:%02u:%02u:%02u\n", > lpTime->u.smpte.hour, lpTime->u.smpte.min, > >

2 3

Re: D3D8_GetCreationParameters fix
by Christian Costa 19 Jul '04

19 Jul '04

Jonathan Wilson wrote: >> This is the best things to do but the problem is not always obvious. >> If REing does not give significant result, I would suggest to check >> how the function behaves in windows >> and implement the same behaviour with maybe a big comment about >> ChessMaster 9000. > > I suggest that some kind of windows API hook (I have done direct3d > hooking before so I know it can be done) or API spy to find ouit just > what gets passed by chessmaster on windows would be a good idea. This would be great but how do you do with COM objects. What did you do for your direct3d hooking. BTW, I remember I had a problem with a registry key that was closed and read afterwards. I've never figured out why the app closes this key. API hooking would have been usefull. Is there something available for doing that? > > If chessmaster passes the same thing on windows, one can figure out > what to do with it. > If it doesnt, one can figure out why wine is being passed bad input... > >

3 3

Re: wine-pthread working on MacOSX
by Alexandre Julliard 19 Jul '04

19 Jul '04

emmanuel maillard <e.rsz(a)libertysurf.fr> writes: > This patch remove granularity check in NtAllocateVirtualMemory for > Darwin, because teb can be alloc at > address < granularity_mask (0xffff) This must be avoided, nothing should be allocated below 64K, the Windows API depends on that. You probably need to adapt the memory reservation code to reserve the low 64K on Darwin. -- Alexandre Julliard julliard(a)winehq.org

1 0

build problem
by Stefan Leichter 19 Jul '04

19 Jul '04

Hello, My problem is related to 'out of tree builds'. When i have a changed spec file for a dll in the build tree it does not get used. The spec file from the source tree is used. Can this be fixed? Thanks Stefan

2 3

urlmon missing InternetSecurityManager
by Jeroen Janssen 19 Jul '04

19 Jul '04

Hello, It seems urlmon is missing a (stubbed) IInternetSecurityManager Interface (see also http://msdn.microsoft.com/workshop/security/szone/reference/ifaces/iinterne… ). Since I am new to this, I was wondering how I can create a stubbed implementation. As far as I can tell I need to : * update the urlmon.idl (add IInternetSecurityManager) * create a stubbed implemenation in dlls/urlmon/; making sure the stubbed interface also gets registered during 'wineprefixcreate'. Are there any (wine) pointers on implementing a new (stubbed) COM interface? Best regards, Jeroen Janssen

4 4

Re: Reimplementation of CryptAcquireContextA
by Michael Jung 19 Jul '04

19 Jul '04

Am Montag, 19. Juli 2004 02:47 schrieb Robert Shearman: > Michael Jung wrote: > >Hello, > > > >The original CryptAcquireContextA had some issues with memory management > >in failure conditions, resulting in heap corruption under certain > >cirumstances. I've reimplemented this function, checking behaviour against > >Windows XP Prof. There is also a unit test included in the patch, which > >tests CryptAcquireContext and successfully runs to completion on > >both Windows XP and Wine. The patch looks worse than it is, since diff > >believes to have found similarities between my new implementation and the > >original CryptAcquireContextA. > > Alexandre has already modified CryptAcquireContextA to fix the original > problem, but I'll comment on the patch anyway. ... > Two comments: > 1. This seems like overkill - a new function *and* a new structure to go > with it? > 2. Use CRYPT_Free instead of HeapFree in case someone in the future > changes the memory to routines to some non-Heap* (or remove the CRYPT > memory routines altogether) > > > ... > > Your patch does highlight one issue though - we should be freeing all of > the resource from one path, not multiple paths and the best way to do > this is how it is currently done - by using a goto. > Maybe we could simplify the function by putting chunks into new > functions, but certainly not a new function just to release local > resources. > > Rob Hi Rob, The original CryptAcquireContextA had a couple of memory management issues and Alexandre's patch only takes care of one. Furthermore, the original implementation does not comply to Windows behaviour regarding error reporting. The unit test given in the patch succesfully runs to completion on both Windows XP Professional and Wine, but only with the new CryptAcquireContext. The function and the structure are used to keep the CryptAcquireContext function body more readable. As you pointed out, this could also be achieved with goto's and a labeled cleanup section (Though not as compact, since you still would have to do a "SetLastError(..); goto error;", which requires an additional pair of curly braces ;) ). Personally I don't like goto's, but this is perhaps a position too academic. So if the wine community favours the goto approach, I will be happy to modify the code. The patch uses the HeapAlloc function only for memory blocks, which are completely memory managed inside CryptAcquireContext. This means that the implementation of CRYPT_Free is irrelevant here. As far as I understand it, HeapAlloc is the way to go in new code. Am I correct here? Since I'm new to wine, I don't have a firm understanding of the coding conventions. Could some more people comment on the given patch, please? This would help me to get a better picture. Thanks and greetings, Michael

1 0

problem in dsound with DirectSoundCreate
by christoph kunz 19 Jul '04

19 Jul '04

hi all, i´m trying to get the djing app "native instruments traktor dj studio" to work under recent wine versions. i´m running fc2 with kernel 2.6.6.1-435 on a dell laptop. when only using one stereo channel, the app really runs fine, but for djing you need monitor support, which means to use 4 channels of a quadrophonic sound card (my one is a audigy nx, but same for the intenal card). the means using the ds subsystem, since mm is not capable of using 4 channels.. i recently posted this question to wine-users, but i traced the error a bit more and think its more of interest to developers. if you guys can give me some hints one the sourcecode, may be i´m able to fix the problem.. the problem is: djstudio when started up the first time wants to know which device and which driver to use. therefor a dropdown lists pops up, wher the devices and the available drivers are listed (eg. mm, ds, asio, etc..) when choosing a driver i can then assign audio channels for monitoring and master. now, with wine and wineoss driver djstudio correctly lists the audio-devices available, and with mm two channels are provided for either the master or monitor audio channel. but when i choose the "ds driver" no channels are supported. i think the problem is located in the lowlevel wineoss driver, where DirectSoundCreate is something confusing with GUIDs. detail: wine-20040615, WINEDEBUG=trace+dsound,warn+dsound lists <--snip--> trace:dsound:DirectSoundEnumerateA calling lpDSEnumCallback(NULL,"Primary Sound Driver","wineoss.drv",0x556efb1c) trace:dsound:DirectSoundEnumerateA calling lpDSEnumCallback({bd6dd71a-3deb-11d1-b171-00c04fc20000},"SigmaTel STAC9750/51","wineoss.drv",0x556efb1c) trace:dsound:DirectSoundCaptureEnumerateA (0x60ce54,0x556efb1c) trace:dsound:GetDeviceID (0x55bd1868,0x556ef818) trace:dsound:DirectSoundCaptureEnumerateA calling lpDSEnumCallback(NULL,"Primary Sound Capture Driver","wineoss.drv",0x556efb1c) trace:dsound:DirectSoundCaptureEnumerateA calling lpDSEnumCallback({bd6dd71b-3deb-11d1-b171-00c04fc20000},"SigmaTel STAC9750/51","wineoss.drv",0x556efb1c) trace:dsound:DirectSoundCreate8 ({58d80060-2a50-5ba7-b171-00c04038a75b},0x5ba71010,(nil)) trace:dsound:setup_dsound_options appname = [TraktorDJStudio2Demo.exe\dsound] warn:dsound:setup_dsound_options ds_hw_accel = Emulation (default=Full) trace:dsound:GetDeviceID (0x556ef818,0x556edb84) trace:dsound:DirectSoundCreate8 expecting GUID {58d80060-2a50-5ba7-b171-00c04038a75b}. trace:dsound:DirectSoundCreate8 got GUID {bd6dd71a-3deb-11d1-b171-00c04fc20000} for wod 0. warn:dsound:DirectSoundCreate8 No device found matching given ID - trying with default one ! <--snap--> trace:dsound:IDirectSoundImpl_SetCooperativeLevel (0x55241ce8,00010024,2(DSSCL_PRIORITY)) fixme:dsound:IDirectSoundImpl_SetCooperativeLevel level=DSSCL_PRIORITY not fully supported <--snap II> as you can see the internal hw device "SigmaTel STAC9750/51" of my laptop is listed. then tow problems occur 1) DirectSoundCreate8 receives a wrong GUID (whatever that meens??) 2) SetCooperativeLevel level is not fully supported (whatever that meens??) in wine-20040716 the SetCooperativeLevel seems to be fixed and DirectSoundCreate8 switched to DirectSoundCreate but also recieves a wrong GUID, which i think thats the main reason traktor won´t list channels. i think, traktor is checking, if the device is really there now, i read something about a related problem (http://www.winehq.org/hypermail/wine-devel/2004/05/0022.html) the patch, which is in the actual sourcecode, ... This->pDirectSound = (IDirectSound*) pDirectSound; IDirectSound_AddRef((LPDIRECTSOUND) This->pDirectSound); } else { DirectSoundCreate8(NULL, (LPDIRECTSOUND8*) &This->pDirectSound, NULL); ... i think always trys to get the default device with the NULL paramter.. am i right, i dont really know?? please, can you help i some way, why the GUID is wrong (maybe my setup) or where to experiment with the sourcecode ?? thankx in advance&all the best christoph ps: the djstudio demo is available at www.nativeinstruments.com -- dipl.-ing. christoph kunz fraunhofer institut fuer arbeitswirtschaft und organisation competence center softwaretechnik nobelstrasse 12 d-70569 stuttgart germany fon: +49 (0)711 - 970 2314 fax: +49 (0)711 - 970 2300 mail: christoph.kunz(a)iao.fhg.de icq#: 49335597 web: http://www.iao.fhg.de pgp#: 12AF7964(a)wwwkey.pgp.net

1 0

Re: dsound test: Remove unneeded Caps/3D test
by Robert Reif 19 Jul '04

19 Jul '04

Please don't apply this patch. The point of the test is to test the QueryInterface reference counting which you just removed. Please just fix the flag bug and not remove the point of the test. Francois Gouget wrote: > This fixes another dsound Windows crash: we first create a buffer > without DSBCAPS_CTRL3D, then we query the IDirectSound3DBuffer on it > which obviously fails so that we try to do an AddRef on a NULL pointer > (buffer3d). > > But this 3D buffer is not really needed for this test since we already > have the secondary buffer reference. Also MSDN recommends only using > CDSBCAPS_TRL3D when necessary because DirectSound can optimize things > when it's not specified. It may not yet be the case in Wine but I'd > prefer to keep the dsound.c test as simple as possible. So I removed > all references to this 3D buffer. I also went through the caps we > request on our buffers and remove all the unneeded ones. > > > Changelog: > > * dlls/dsound/tests/dsound.c > > Francois Gouget <fgouget(a)codeweavers.com> > Don't try to create a IDirectSound3DBuffer, partly to keep this > test simple and partly because it's going to fail since we did not > request DSBCAPS_CTRL3D. Fixes a crash on Windows. > Don't request unneeded caps. > >------------------------------------------------------------------------ > >Index: dlls/dsound/tests/dsound.c >=================================================================== >RCS file: /var/cvs/wine/dlls/dsound/tests/dsound.c,v >retrieving revision 1.24 >diff -u -r1.24 dsound.c >--- dlls/dsound/tests/dsound.c 13 Jul 2004 23:35:09 -0000 1.24 >+++ dlls/dsound/tests/dsound.c 16 Jul 2004 17:07:59 -0000 >@@ -336,18 +342,13 @@ > init_format(&wfx,WAVE_FORMAT_PCM,11025,8,1); > ZeroMemory(&bufdesc, sizeof(bufdesc)); > bufdesc.dwSize=sizeof(bufdesc); >- bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2; >- bufdesc.dwFlags|=(DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN); >+ bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2 | DSBCAPS_CTRLVOLUME; > bufdesc.dwBufferBytes=wfx.nAvgBytesPerSec*BUFFER_LEN/1000; > bufdesc.lpwfxFormat=&wfx; > rc=IDirectSound_CreateSoundBuffer(dso,&bufdesc,&secondary,NULL); > ok(rc==DS_OK && secondary!=NULL,"CreateSoundBuffer failed to create a secondary buffer 0x%lx\n", rc); > if (rc==DS_OK && secondary!=NULL) { >- LPDIRECTSOUND3DBUFFER buffer3d; >- rc=IDirectSound_QueryInterface(secondary, &IID_IDirectSound3DBuffer, (void **)&buffer3d); >- ok(rc==DS_OK && buffer3d!=NULL,"QueryInterface failed: %s\n",DXGetErrorString9(rc)); > /* add some more refs */ >- IDirectSound3DBuffer_AddRef(buffer3d); > IDirectSoundBuffer_AddRef(secondary); > } > /* release with buffer */ >@@ -459,18 +460,13 @@ > init_format(&wfx,WAVE_FORMAT_PCM,11025,8,1); > ZeroMemory(&bufdesc, sizeof(bufdesc)); > bufdesc.dwSize=sizeof(bufdesc); >- bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2; >- bufdesc.dwFlags|=(DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN); >+ bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2 | DSBCAPS_CTRLVOLUME; > bufdesc.dwBufferBytes=wfx.nAvgBytesPerSec*BUFFER_LEN/1000; > bufdesc.lpwfxFormat=&wfx; > rc=IDirectSound8_CreateSoundBuffer(dso,&bufdesc,&secondary,NULL); > ok(rc==DS_OK && secondary!=NULL,"CreateSoundBuffer failed to create a secondary buffer 0x%lx\n", rc); > if (rc==DS_OK && secondary!=NULL) { >- LPDIRECTSOUND3DBUFFER buffer3d; >- rc=IDirectSound8_QueryInterface(secondary, &IID_IDirectSound3DBuffer, (void **)&buffer3d); >- ok(rc==DS_OK && buffer3d!=NULL,"QueryInterface failed: %s\n",DXGetErrorString9(rc)); > /* add some more refs */ >- IDirectSound3DBuffer_AddRef(buffer3d); > IDirectSoundBuffer8_AddRef(secondary); > } > /* release with buffer */ >@@ -614,7 +617,6 @@ > ZeroMemory(&bufdesc, sizeof(bufdesc)); > bufdesc.dwSize=sizeof(bufdesc); > bufdesc.dwFlags=DSBCAPS_PRIMARYBUFFER; >- bufdesc.dwFlags|=(DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN); > rc=IDirectSound_CreateSoundBuffer(dso,&bufdesc,&primary,NULL); > ok(rc==DS_OK && primary!=NULL,"CreateSoundBuffer failed to create a primary buffer 0x%lx\n", rc); > >@@ -625,7 +627,6 @@ > ZeroMemory(&bufdesc, sizeof(bufdesc)); > bufdesc.dwSize=sizeof(bufdesc); > bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2; >- bufdesc.dwFlags|=(DSBCAPS_CTRLFREQUENCY|DSBCAPS_CTRLVOLUME|DSBCAPS_CTRLPAN); > bufdesc.dwBufferBytes=wfx.nAvgBytesPerSec*BUFFER_LEN/1000; > bufdesc.lpwfxFormat=&wfx; > trace(" Testing a secondary buffer at %ldx%dx%d\n", > >

2 2

Re: Reimplementation of CryptAcquireContextA
by Robert Shearman 19 Jul '04

19 Jul '04

Michael Jung wrote: >Hello, > >The original CryptAcquireContextA had some issues with memory management >in failure conditions, resulting in heap corruption under certain >cirumstances. I've reimplemented this function, checking behaviour against >Windows XP Prof. There is also a unit test included in the patch, which >tests CryptAcquireContext and successfully runs to completion on >both Windows XP and Wine. The patch looks worse than it is, since diff >believes to have found similarities between my new implementation and the >original CryptAcquireContextA. > > Alexandre has already modified CryptAcquireContextA to fix the original problem, but I'll comment on the patch anyway. >Index: dlls/advapi32/crypt.c >=================================================================== >RCS file: /home/wine/wine/dlls/advapi32/crypt.c,v >retrieving revision 1.39 >diff -u -r1.39 crypt.c >--- dlls/advapi32/crypt.c 16 Jul 2004 19:19:00 -0000 1.39 >+++ dlls/advapi32/crypt.c 18 Jul 2004 22:55:19 -0000 >@@ -239,6 +239,45 @@ > #undef CRYPT_GetProvFunc > #undef CRYPT_GetProvFuncOpt > >+struct acquire_context_resources { >+ HKEY hKey; >+ PCHAR pszProvKeyName; >+ PCHAR pszTemp; >+ PCHAR pszImagePath; >+ PBYTE pSignature; >+}; >+ >+/****************************************************************************** >+ * acquire_context_release_resources [Internal] >+ * >+ * Helper function for CryptAcquireContext. Releases the resources used by >+ * CryptAcquireContext, sets last error to error_code and returns TRUE if >+ * error_code == ERROR_SUCCESS, else FALSE. >+ * >+ * PARAMS >+ * resources [I] Pointer to an acquire_context_resources struct, which holds >+ * pointers to resources used by CryptAcquireContext >+ * error_code [I] Error code, which the "last error" is set to. >+ * >+ * RETURNS >+ * TRUE, iff error_code == ERROR_SUCCESS >+ * FALSE, otherwise >+ */ >+inline BOOL acquire_context_release_resources(struct acquire_context_resources *resources, DWORD error_code) >+{ >+ if (resources->hKey != (HKEY)INVALID_HANDLE_VALUE) >+ RegCloseKey(resources->hKey); >+ if (resources->pszProvKeyName != NULL) >+ HeapFree(GetProcessHeap(), 0, resources->pszProvKeyName); >+ if (resources->pszTemp != NULL) >+ HeapFree(GetProcessHeap(), 0, resources->pszTemp); >+ if (resources->pszImagePath != NULL) >+ HeapFree(GetProcessHeap(), 0, resources->pszImagePath); >+ if (resources->pSignature != NULL) >+ HeapFree(GetProcessHeap(), 0, resources->pSignature); >+ SetLastError(error_code); >+ return error_code == ERROR_SUCCESS; >+} > > Two comments: 1. This seems like overkill - a new function *and* a new structure to go with it? 2. Use CRYPT_Free instead of HeapFree in case someone in the future changes the memory to routines to some non-Heap* (or remove the CRYPT memory routines altogether) ... Your patch does highlight one issue though - we should be freeing all of the resource from one path, not multiple paths and the best way to do this is how it is currently done - by using a goto. Maybe we could simplify the function by putting chunks into new functions, but certainly not a new function just to release local resources. Rob

2 1

Re: dsound tests propset.c windows compile patch
by Robert Reif 19 Jul '04

19 Jul '04

Robert Reif wrote: > Fix so it compiles with VC7 on XP. > > > Here is the proper fix. Don't include dsconf IIDs in dxguid.lib. Index: dlls/dsound/tests/propset.c =================================================================== RCS file: /home/wine/wine/dlls/dsound/tests/propset.c,v retrieving revision 1.5 diff -u -r1.5 propset.c --- dlls/dsound/tests/propset.c 5 Sep 2003 23:08:38 -0000 1.5 +++ dlls/dsound/tests/propset.c 19 Jul 2004 04:14:11 -0000 @@ -29,9 +29,12 @@ #include "windef.h" #include "wingdi.h" #include "dsound.h" +#include "initguid.h" #include "dsconf.h" -#include "initguid.h" +#ifndef DSBCAPS_CTRLDEFAULT +#define DSBCAPS_CTRLDEFAULT DSBCAPS_CTRLFREQUENCY|DSBCAPS_CTRLPAN|DSBCAPS_CTRLVOLUME +#endif DEFINE_GUID(DSPROPSETID_VoiceManager,0x62A69BAE,0xDF9D,0x11D1,0x99,0xA6,0x00,0xC0,0x4F,0xC9,0x9D,0x46); DEFINE_GUID(DSPROPSETID_EAX20_ListenerProperties,0x306a6a8,0xb224,0x11d2,0x99,0xe5,0x0,0x0,0xe8,0xd8,0xc7,0x22); Index: dlls/dxguid/dxguid.c =================================================================== RCS file: /home/wine/wine/dlls/dxguid/dxguid.c,v retrieving revision 1.2 diff -u -r1.2 dxguid.c --- dlls/dxguid/dxguid.c 3 Jun 2004 00:03:23 -0000 1.2 +++ dlls/dxguid/dxguid.c 19 Jul 2004 04:14:11 -0000 @@ -37,7 +37,6 @@ #include "mmsystem.h" #include "dsound.h" #include "dsdriver.h" -#include "dsconf.h" #include "dmusici.h" #include "dmusics.h" #include "dplay.h"

1 0

Re: dsound tests propset.c windows compile patch
by Robert Reif 19 Jul '04

19 Jul '04

Please disregard this patch. It breaks wine compiles. I'll dig into a better fix that works for both wine and windows. Robert Reif wrote: > Fix so it compiles with VC7 on XP. > > >

1 0

Re: dsound test: Remove unneeded Caps/3D test
by Robert Reif 19 Jul '04

19 Jul '04

Francois Gouget wrote: > This fixes another dsound Windows crash: we first create a buffer > without DSBCAPS_CTRL3D, then we query the IDirectSound3DBuffer on it > which obviously fails so that we try to do an AddRef on a NULL pointer > (buffer3d). > Fixes the right bugs and keeps intent of test. Adds more reference count checks. Tested on XP with DX9. Index: dlls/dsound/tests/dsound.c =================================================================== RCS file: /home/wine/wine/dlls/dsound/tests/dsound.c,v retrieving revision 1.27 diff -u -r1.27 dsound.c --- dlls/dsound/tests/dsound.c 17 Jul 2004 00:04:17 -0000 1.27 +++ dlls/dsound/tests/dsound.c 19 Jul 2004 00:34:23 -0000 @@ -342,14 +342,21 @@ init_format(&wfx,WAVE_FORMAT_PCM,11025,8,1); ZeroMemory(&bufdesc, sizeof(bufdesc)); bufdesc.dwSize=sizeof(bufdesc); - bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2 | DSBCAPS_CTRLVOLUME; + bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2 | DSBCAPS_CTRL3D; bufdesc.dwBufferBytes=wfx.nAvgBytesPerSec*BUFFER_LEN/1000; bufdesc.lpwfxFormat=&wfx; rc=IDirectSound_CreateSoundBuffer(dso,&bufdesc,&secondary,NULL); ok(rc==DS_OK && secondary!=NULL,"CreateSoundBuffer failed to create a secondary buffer 0x%lx\n", rc); if (rc==DS_OK && secondary!=NULL) { - /* add some more refs */ - IDirectSoundBuffer_AddRef(secondary); + LPDIRECTSOUND3DBUFFER buffer3d; + rc=IDirectSound_QueryInterface(secondary, &IID_IDirectSound3DBuffer, (void **)&buffer3d); + ok(rc==DS_OK && buffer3d!=NULL,"QueryInterface failed: %s\n",DXGetErrorString9(rc)); + if (rc==DS_OK && buffer3d!=NULL) { + ref=IDirectSound3DBuffer_AddRef(buffer3d); + ok(ref==2,"IDirectSound3DBuffer_AddRef has %d references, should have 2\n",ref); + } + ref=IDirectSoundBuffer_AddRef(secondary); + ok(ref==2,"IDirectSoundBuffer_AddRef has %d references, should have 2\n",ref); } /* release with buffer */ ref=IDirectSound_Release(dso); @@ -460,14 +467,27 @@ init_format(&wfx,WAVE_FORMAT_PCM,11025,8,1); ZeroMemory(&bufdesc, sizeof(bufdesc)); bufdesc.dwSize=sizeof(bufdesc); - bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2 | DSBCAPS_CTRLVOLUME; + bufdesc.dwFlags=DSBCAPS_GETCURRENTPOSITION2 | DSBCAPS_CTRL3D; bufdesc.dwBufferBytes=wfx.nAvgBytesPerSec*BUFFER_LEN/1000; bufdesc.lpwfxFormat=&wfx; rc=IDirectSound8_CreateSoundBuffer(dso,&bufdesc,&secondary,NULL); ok(rc==DS_OK && secondary!=NULL,"CreateSoundBuffer failed to create a secondary buffer 0x%lx\n", rc); if (rc==DS_OK && secondary!=NULL) { - /* add some more refs */ - IDirectSoundBuffer8_AddRef(secondary); + LPDIRECTSOUND3DBUFFER buffer3d; + LPDIRECTSOUNDBUFFER8 buffer8; + rc=IDirectSound_QueryInterface(secondary, &IID_IDirectSound3DBuffer, (void **)&buffer3d); + ok(rc==DS_OK && buffer3d!=NULL,"QueryInterface failed: %s\n",DXGetErrorString9(rc)); + if (rc==DS_OK && buffer3d!=NULL) { + ref=IDirectSound3DBuffer_AddRef(buffer3d); + ok(ref==2,"IDirectSound3DBuffer_AddRef has %d references, should have 2\n",ref); + } + rc=IDirectSound_QueryInterface(secondary, &IID_IDirectSoundBuffer8, (void **)&buffer8); + if (rc==DS_OK && buffer8!=NULL) { + ref=IDirectSoundBuffer8_AddRef(buffer8); + ok(ref==3,"IDirectSoundBuffer8_AddRef has %d references, should have 3\n",ref); + } + ref=IDirectSoundBuffer_AddRef(secondary); + ok(ref==4,"IDirectSoundBuffer_AddRef has %d references, should have 4\n",ref); } /* release with buffer */ ref=IDirectSound8_Release(dso);

1 0

Yard sale windows app fun: Lotus SmartSuite '96. 1-2-3 works, WordPro doesn't.
by Dan Kegel 18 Jul '04

18 Jul '04

I went to a yard sale today, and that's always dangerous. Today I ended up buying a copy of Lotus SmartSuite '96. I then installed Wine-20040615.tar.gz and tried installing my new disc with $ wine d:\\install.exe It got all confused, started iterating through every file underneath my home directory, and printed out err:shell:SHGetFileInfoW pidl is null! for each one! On a hunch, I made my home directory look empty, $ mkdir .blort $ mv * .blort $ wine d:\\install.exe That seemed much better; Wine only printed out the SHGetFileInfoW error once, presumably for the lotustmp.000 directory it created in my home directory. The next problem was when a dialog box "Select a Program Group..." popped up. At about the same time, an error box with title "Setup Message" and body "Setup has encountered a problem. Please report File='COMMON\SYMTAB11.C',Line='618' to Microsoft Product Support Services." This looks a bit lot like http://support.microsoft.com/default.aspx?scid=kb;EN-US;113252 which happens when GetWindowsDirectory() returns a string with lowercase letters, but clicking OK let me past with no ill affects, and I was able to install. At least when all I installed was Word Pro. When I also tried installing 1-2-3 and ScreenCam, I got the error "Lotus Setup" : "Install encountered an error trying to start Regedit.exe." That popped up twice, after which install thought for a long time, then warned fixme:ole:CoCreateInstance no classfactory created for CLSID {00021401-0000-0000-c000-000000000046}, hres is 0x80040154 and seemed to get stuck. Still, things seemed to be more or less well installed, so I tried running two of the apps. $ cd c/lotus/123/programs $ wine 123w.exe worked quite nicely. (Well, it did say the date was 6/17/104, but nobody's perfect!) Next I tried Word Pro: $ cd ~/.wine/c/lotus/wordpro $ wine wordpro.exe That failed immediately, so quickly that WINEDEBUG=+all wine wordpro.exe was practical to run. Here's part of its output. It looks as if the very first instruction accesses a null pointer in a strange way. 0009:Starting process L"C:\\lotus\\wordpro\\wordpro.exe" (entryproc=0x7a6aee) 0009:trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x7a6aee 0009:trace:seh:EXC_RtlRaiseException info[0]=00000001 0009:trace:seh:EXC_RtlRaiseException info[1]=00000000 0009:trace:seh:EXC_RtlRaiseException eax=00000000 ebx=403f1668 ecx=400c0be8 edx=400c0c37 esi=400c1000 edi=007a6aee 0009:trace:seh:EXC_RtlRaiseException ebp=4070fff4 esp=4070ff30 cs=0023 ds=002b es=002b fs=003b gs=0033 flags=00010246 0009:trace:seh:EXC_CallHandler calling handler at 0x403e1708 code=c0000005 flags=0 0009:Call ntdll.NtQueryVirtualMemory(ffffffff,00000000,00000000,4070fac0,0000001c,4070fa84) ret=4037aeb8 0009:Ret ntdll.NtQueryVirtualMemory() retval=00000000 ret=4037aeb8 0009:Call ntdll.RtlImageDirectoryEntryToData(00000000,00000001,00000002,4070fabc) ret=4033fbbe 0009:trace:seh:EXC_RtlRaiseException code=c0000005 flags=0 addr=0x40091368 0009:trace:seh:EXC_RtlRaiseException info[0]=00000000 0009:trace:seh:EXC_RtlRaiseException info[1]=00000000 0009:trace:seh:EXC_RtlRaiseException eax=00000000 ebx=400beec4 ecx=00000001 edx=00000000 esi=00000000 edi=00000002 0009:trace:seh:EXC_RtlRaiseException ebp=4070f9e4 esp=4070f928 cs=0023 ds=002b es=002b fs=003b gs=0033 flags=00010246 0009:trace:seh:EXC_CallHandler calling handler at 0x40089948 code=c0000005 flags=0 0009:trace:seh:EXC_RtlUnwind code=c0000005 flags=2 0009:trace:seh:EXC_CallHandler calling handler at 0x40088fc0 code=c0000005 flags=2 0009:trace:seh:EXC_CallHandler handler returned 1 0009:Ret ntdll.RtlImageDirectoryEntryToData() retval=00000000 ret=4033fbbe 0009:Call ntdll.NtCreateEvent(4070fac0,001f0003,4070fac4,00000001,00000000) ret=4033f836 0009:Ret ntdll.NtCreateEvent() retval=00000000 ret=4033f836 wine: Unhandled exception (thread 0009), starting debugger... ... Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x007a6aee). In 32 bit mode. Register dump: CS:0023 SS:002b DS:002b ES:002b FS:003b GS:0033 EIP:007a6aee ESP:4070ff30 EBP:4070fff4 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:403f1668 ECX:400c0be8 EDX:400c0c37 ESI:400c1000 EDI:007a6aee Stack dump: 0x00000000: 00000000 00000000 00000000 00000000 0x00000010: 00000000 00000000 00000000 00000000 0x00000020: 00000000 00000000 00000000 00000000 0x00000030: 00000000 00000000 00000000 00000000 0x00000040: 00000000 00000000 00000000 00000000 0x00000050: 00000000 00000000 00000000 00000000 0x00000060: Backtrace: =>1 0x007a6aee (0x4070fff4) 2 0x4002e83d (0x00000000) 0x007a6aee: addb %al,0x0(%eax) Modules: 0x40070000-400c2000 Deferred ntdll 0x40320000-403f3000 Deferred kernel32 0x00400000-00888000 --none-- wordpro 0x402f0000-403f3000 Deferred kernel32<elf> 0x40019000-40025000 Deferred libnss_files.so.2 0x401b5000-401d7000 Deferred libm.so.6 0x400c2000-401b5000 Deferred libwine_unicode.so.1 0x40053000-400c2000 Deferred ntdll<elf> 0x40000000-40016000 Deferred ld-linux.so.2 0x4004f000-40052000 Deferred libdl.so.2 0x420155f0-841485f0 Deferred libc.so.6 0x40042000-4004f000 Deferred libpthread.so.0 0x4002a000-40042000 Sym libwine.so.1 0x420155f0-841485f0 Deferred libc.so.6 Module Address Debug info Name (14 modules) PE 0x00400000-00888000 --none-- wordpro ELF 0x40000000-40016000 Deferred ld-linux.so.2 ELF 0x40019000-40025000 Deferred libnss_files.so.2 ELF 0x4002a000-40042000 Sym libwine.so.1 ELF 0x40042000-4004f000 Deferred libpthread.so.0 ELF 0x4004f000-40052000 Deferred libdl.so.2 ELF 0x40053000-400c2000 Deferred ntdll<elf> \-PE 0x40070000-400c2000 Deferred ntdll ELF 0x400c2000-401b5000 Deferred libwine_unicode.so.1 ELF 0x401b5000-401d7000 Deferred libm.so.6 ELF 0x402f0000-403f3000 Deferred kernel32<elf> \-PE 0x40320000-403f3000 Deferred kernel32 ELF 0x420155f0-841485f0 Deferred libc.so.6 ELF 0x420155f0-841485f0 Deferred libc.so.6 Threads: process tid prio (all id:s are in hex) 0000000b (D) C:\lotus\wordpro\wordpro.exe 00000009 0 <== 00000010 00000011 0 WineDbg terminated on pid 0xb So I guess I got a couple hours worth of entertainment out of my $5, and I can now run Lotus 1-2-3 if I feel like it. Cool. - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

3 8

HttpOpenRequest: Who has to clean up lpszObjectName?
by Uwe Bonnes 18 Jul '04

18 Jul '04

Hallo, appended test fails with builtin wininet, but succeeds with native wininet. The failing call, triggered but the ending \r, seems to be caused by the www-server side handling. www.winehq.org seems to cope with the ending \r, so the test has to be carried out on the xilinx server. Ise webupdate fails caused by this error. What function has to clean up the ending \r? Thanks -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/wininet/tests/http.c =================================================================== RCS file: /home/wine/wine/dlls/wininet/tests/http.c,v retrieving revision 1.13 diff -u -r1.13 http.c --- wine/dlls/wininet/tests/http.c 23 Jan 2004 22:44:26 -0000 1.13 +++ wine/dlls/wininet/tests/http.c 18 Jul 2004 20:36:28 -0000 @@ -275,10 +275,30 @@ ok((strcmp(TEST_URL_PATH,path) == 0),"path cracked wrong\n"); } +void InternetOpenRequest_test() +{ + DWORD rc; + HINTERNET hi, hic = 0, hor = 0; + const char *types[2] = { "*/*", NULL }; + hi = InternetOpenA("",0x0,0x0,0x0,0x0); + ok((hi != 0x0),"InternetOpen Failed\n"); + trace("InternetOpenA -->\n"); + hic=InternetConnectA(hi,"www.xilinx.com",0x0, 0x0, 0x0, 0x3,0x0, 0xdeadbeef); + ok((hic != 0x0),"InternetConnect Failed\n"); + trace("InternetConnect Succeeded\n"); + hor = HttpOpenRequestA(hic, "GET", + "/direct/swhelp/series6/6.2i_latestservicepack.dat\r", + "HTTP/1.0", + 0x0,types,04000000,00000000); + rc= HttpSendRequestA(hor,0x0,0x0,0x0,0x0); + ok((rc != 0x0),"HttpSendRequestA Failed\n"); +} + START_TEST(http) { winapi_test(0x10000000); winapi_test(0x00000000); InternetCrackUrl_test(); InternetOpenUrlA_test(); + InternetOpenRequest_test(); }

1 0

Re: msiexec.exe replacement
by Robert Shearman 18 Jul '04

18 Jul '04

Vincent Béron wrote: >Note: Much functionnality is still absent, but it's already able to >begin the installation of iTunes.msi and netfx.msi. >I plan on updating this in the coming days. > > Nice work. >Changelog: >First draft for a msiexec.exe replacement. > >Vincent > > ... >+ printf("Dll %s does not implement function %s\n", DllName, ProcName); > > Minor nitpick: this (and similar messages) should be fprintf(stderr,...) >+static void DllRegisterServer(LPCSTR DllName) >+{ >+ HRESULT hr; >+ DLLREGISTERSERVER pfDllRegisterServer = NULL; >+ HMODULE DllHandle = NULL; >+ >+ pfDllRegisterServer = LoadProc(DllName, "DllRegisterServer", &DllHandle); >+ >+ hr = pfDllRegisterServer(); >+ if(FAILED(hr)) >+ { >+ printf("Failed to register dll %s\n", DllName); >+ ExitProcess(1); >+ } >+ printf("Successfully registered dll %s\n", DllName); >+ if(DllHandle) >+ FreeLibrary(DllHandle); >+} >+ >+static void DllUnregisterServer(LPCSTR DllName) >+{ >+ HRESULT hr; >+ DLLUNREGISTERSERVER pfDllUnregisterServer = NULL; >+ HMODULE DllHandle = NULL; >+ >+ pfDllUnregisterServer = LoadProc(DllName, "DllUnregisterServer", &DllHandle); >+ >+ hr = pfDllUnregisterServer(); >+ if(FAILED(hr)) >+ { >+ printf("Failed to unregister dll %s\n", DllName); >+ ExitProcess(1); >+ } >+ printf("Successfully unregistered dll %s\n", DllName); >+ if(DllHandle) >+ FreeLibrary(DllHandle); >+} >+ > > ... >+ >+ ExitProcess(0); >+ return 0; >+} > > The ExitProcess call should not be needed. Rob

1 0

Re: PATCH: msrel32 new compiler
by Dmitry Timoshkov 18 Jul '04

18 Jul '04

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > --- dlls/msrle32/msrle32.c 27 Feb 2004 21:51:13 -0000 1.8 > +++ dlls/msrle32/msrle32.c 16 Jul 2004 12:36:10 -0000 > @@ -572,7 +572,8 @@ > > /* add EOL -- end of line */ > lpbiOut->biSizeImage += 2; > - *((LPWORD)lpOut)++ = 0; > + *(LPWORD)lpOut = 0; > + lpOut += sizeof(DWORD); Shouldn't this one and others be lpOut += sizeof(WORD) and not DWORD? -- Dmitry.

2 1

Re: [Darwine] Remove multi implementation of NtCurrentTeb
by maillard.emmanuel＠libertysurf.fr 18 Jul '04

18 Jul '04

Sorry the problem with NtAllocateVirtualMemory is in RtlCreateUserThread. emmanuel > NB : creating thread with wine-pthread still not work, because calling > NtAllocateVirtualMemory in start_thread always return > STATUS_INVALID_PARAMETER.

1 0

Missing RPMs on SourceForge
by Shachar Shemesh 18 Jul '04

18 Jul '04

Hi all, It seems that the RPMs for Redhat (at least redhat 9) on sourceforge are a fiction. When I actually try to download any of them (src, i386 or i686), I get a notification that the file is not on the mirror. This happens regardless of what mirror I select (I tried at least 5). Is this a problem we can solve? Shachar

2 1

{00021401-0000-0000-c000-000000000046}
by Shachar Shemesh 18 Jul '04

18 Jul '04

Or "ShellCreateIcon", if I'm not mistaken (I likely am). It appears we don't have that OLE registered in our system. This strikes me as odd, as I know that some installers do actually create icons. How do they do that? If someone can point me to our current icon creating code, I may sit down and create this object. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

3 2

Ogre3D based game crashes on exit
by Saulius Krasuckas 18 Jul '04

18 Jul '04

The game [1] crashes when I select DX7 engine at its initial screen, go the gameplay and then simply exit. I have entered a new bug report to provide more details [2] on this issue. My attention was caught by the ending part of the output [3] (quite large, about 400kB in size): trace:module:LdrUnloadDll (L"RenderSystem_Direct3D9.dll") - START trace:module:MODULE_DecRefCount (L"RenderSystem_Direct3D9.dll") ldr.LoadCount: 0 trace:module:MODULE_DecRefCount (L"OgreMain.dll") ldr.LoadCount: 3 trace:module:MODULE_DecRefCount (L"d3d9.dll") ldr.LoadCount: 0 trace:module:MODULE_DecRefCount (L"user32.dll") ldr.LoadCount: 13 trace:module:MODULE_DecRefCount (L"gdi32.dll") ldr.LoadCount: 8 trace:module:MODULE_DecRefCount (L"kernel32.dll") ldr.LoadCount: 23 trace:module:MODULE_DecRefCount (L"kernel32.dll") ldr.LoadCount: 22 trace:module:MODULE_DecRefCount (L"user32.dll") ldr.LoadCount: 12 trace:module:MODULE_DecRefCount (L"gdi32.dll") ldr.LoadCount: 7 trace:module:MODULE_DecRefCount (L"advapi32.dll") ldr.LoadCount: 8 trace:module:MODULE_DecRefCount (L"MSVCP71.dll") ldr.LoadCount: 4 trace:module:MODULE_DecRefCount (L"MSVCR71.dll") ldr.LoadCount: 5 trace:module:MODULE_InitDLL (0x41ca0000 L"RenderSystem_Direct3D9.dll",PROCESS_DETACH,(nil)) - CALL trace:module:MODULE_InitDLL (0x41ca0000,PROCESS_DETACH,(nil)) - RETURN 1 trace:module:MODULE_InitDLL (0x41d30000 L"d3d9.dll",PROCESS_DETACH,(nil)) - CALL trace:module:MODULE_InitDLL (0x41d30000,PROCESS_DETACH,(nil)) - RETURN 1 trace:module:MODULE_FlushModrefs unloading L"F:\\spba\\pluginsr\\RenderSystem_Direct3D9.dll" trace:module:MODULE_FlushModrefs unloading L"c:\\windows\\system\\d3d9.dll" trace:module:LdrUnloadDll END wine: Unhandled exception (thread 0009), starting debugger... <skip /> WineDbg starting on pid 0x8 Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x430dc1e9). In 32 bit mode. 0x430dc1e9: sbbl %ebp,0x0(%ebx) Wine-dbg>Backtrace: =>1 0x430dc1e9 (0x4074fe86) Any ideas on how to investigate further on this crash? [1] http://lib.su.lt/~ramonas/spacebandits/ [2] http://bugs.winehq.org/show_bug.cgi?id=2365 [3] http://bugs.winehq.org/attachment.cgi?id=630&action=view

1 1

winetest files
by Ivan 18 Jul '04

18 Jul '04

In the future please avoid having 22 winetest packages set to active, it doubles the size of the sourceforge download page. Ivan.

1 0

PathSearchAndQualify patch (from 2003/12/22) not applied?
by Jeroen Janssen 17 Jul '04

17 Jul '04

Hello, I have an application that tries to use PathSearchAndQualify. However, since the current implementation is just stubbed (it contains only a FIXME + return FALSE), it doesn't work. Now searching in the gmane wine patch archive I found an email dated back to 2003/12/22 that contains a possible implementation for PathSearchAndQualify (see also at http://article.gmane.org/gmane.comp.emulators.wine.patches/6810/match=paths… ). However, it seems that this patch was never applied and I'm wondering why. Note that I haven't tried to apply this patch and test it locally. Can someone clarify if this patch is ok or not (and why it's not applied yet?) Best regards, Jeroen Janssen p.s. I hope this message does not appear multiple times, since I had some problems with gmane

2 1

Test contacts
by Mike Hearn 17 Jul '04

17 Jul '04

Hi, The test reports don't seem to include an email address for the reporters. I'd love to contact Nicolas Escuder or Dimitris Koukoravas to try and find out what their drive G: is and why it makes GetDiskFreeSpace fail. Does anybody know why the test system isn't getting their email addresses? thanks -mike

1 0

Re: TOOLBAR: TOOLBAR_DrawPattern
by Robert Shearman 17 Jul '04

17 Jul '04

Filip Navara wrote: > Changelog: > - Make the pattern drawing in TOOLBAR_DrawPattern look better. > > Filip Navara, navaraf(a)reactos.com > >------------------------------------------------------------------------ > >--- dlls/comctl32/toolbar.c 16 Jun 2004 06:46:13 -0000 1.15 >+++ dlls/comctl32/toolbar.c 16 Jul 2004 19:17:24 -0000 >@@ -634,7 +634,7 @@ > INT cy = lpRect->bottom - lpRect->top; > clrTextOld = SetTextColor(hdc, tbcd->clrBtnHighlight); > clrBkOld = SetBkColor(hdc, tbcd->clrBtnFace); >- PatBlt (hdc, lpRect->left, lpRect->top, cx, cy, PATCOPY); >+ PatBlt (hdc, lpRect->left + 2, lpRect->top + 2, cx - 4, cy - 4, PATCOPY); > SetBkColor(hdc, clrBkOld); > SetTextColor(hdc, clrTextOld); > SelectObject (hdc, hbr); > > This should use GetSystemMetrics(SM_CXEDGE and SM_CYEDGE). I'll submit a patch to fix this since it has already been committed. Rob

2 1

final fix collate icon behavior in printdlg
by James Hawkins 17 Jul '04

17 Jul '04

Hi, Sorry for the backtracking, but this patch conforms to the printer dialog in Windows, unlike the last patch i sent. The behavior is: Initially, Number of copies is 1 and collate is unchecked and shaded (icon is no_collate). If number of copies changes to > 1, collate becomes unshaded if collate is checked, icon changes to collate. if number of copies > 1 and you drop it to one, collate is shaded and does not check or uncheck so the icon stays the same as well. -- James Hawkins

1 0

Re: PrintDlg collate question
by J. Wesley Cleveland 17 Jul '04

17 Jul '04

Hi, With this patch, the behavior of the Copies section of the print dialog box is correct. The new behavior is: If number of copies is 1, collate option is unchecked and shaded because collate is not possible, and collate icon is removed whether it was set to collate or not collate. else if number of copies > 2, collate option is unchecked but not shaded, and no_collate icon is displayed. There is only one change that im not sure should go in or not, and that is when the collate option is checked and we drop the number of copies to one, should we uncheck the collate option as well as shade it? On my windows 2000 box, the collate option comes up checked and grayed as default, and the collate icon does not change as the number of copies is changed. The collate checkbox is grayed and ungrayed as the number of copies changes to and from 1, but the checked status remains whatever I set it to.

1 0

Re: fix collate icon behavior in printdlg
by Robert Shearman 16 Jul '04

16 Jul '04

James Hawkins wrote: >Hi, > > With this patch, the behavior of the Copies section of the print >dialog box is correct. The new behavior is: > >If number of copies is 1, > collate option is unchecked and shaded because collate is not possible, and > collate icon is removed whether it was set to collate or not collate. >else if number of copies > 2, > collate option is unchecked but not shaded, and > no_collate icon is displayed. > >There is only one change that im not sure should go in or not, and >that is when the collate option is checked and we drop the number of >copies to one, should we uncheck the collate option as well as shade >it? > > It is a nice touch that shows the user that the option doesn't mean anything in that state. However, if the user decreases the copies to 1 and then increases up to 2 their setting has been lost. Also, the dialog doesn't look right when in its default state of only 1 copy. There is a large gap where the collate image would have been. It would be nice if we could put another image there of say, only one sheet of paper, showing why the collate option is disabled. Rob

1 0

PrintDlg collate question
by James Hawkins 16 Jul '04

16 Jul '04

Hi, With this patch, the behavior of the Copies section of the print dialog box is correct. The new behavior is: If number of copies is 1, collate option is unchecked and shaded because collate is not possible, and collate icon is removed whether it was set to collate or not collate. else if number of copies > 2, collate option is unchecked but not shaded, and no_collate icon is displayed. There is only one change that im not sure should go in or not, and that is when the collate option is checked and we drop the number of copies to one, should we uncheck the collate option as well as shade it? -- James Hawkins

1 0

Debugger bugs
by Mike Hearn 16 Jul '04

16 Jul '04

Hi guys, I've got a few problems with various debuggers. Can anybody help? 1) gdb doesn't seem to catch signals to sent to Wine. In a crash, winedbg is invoked without gdb ever being aware of it. 2) winedbg can't locate files anymore, the paths seem to be stripped: 0x401cdb48 fixup_imports [loader.c:509] in ntdll: movl 0x0(%eax),%edx Unable to open file loader.c Wine-dbg>list Wine-dbg> 3) winedbg won't print the values of local variables: Wine-dbg>print i fixme:dbghelp:SymGetTypeInfo Someone didn't properly set ModBase (0x4078ebfc) fixme:winedbg:print_value ---error thanks -mike

2 3

DefPushButton management patch
by Katia Maculan 16 Jul '04

16 Jul '04

I found and fixed 2 problems in DEAFULTPUSHBUTTON management: 1) In function DIALOG_CreateControls32 if a default push button exists the dlgInfo->idResult is set with the DefPushButtonId. If I change the focus to other controls of the dialog with the TAB key, each time I change the focus the function DEFDLG_SetDefButton is called (and that is correct) and the dlgInfo->idResult is set with the new control id also if it is NOT a button (i.e. "edit control"). As a result, pressing the 'Enter'key, nothing happens. I reviewed the code and changed the following: 1. added a member in the DIALOGINFO structure (int OriDefButID) where the original default button ID is stored. 2. modified the DEFDG_SetDefButton function (windows/defdlg.c). 2) Pressing the Enter key in a Dialog without a default push-button, a wrong button ID is returned (always '1'). I modifiied the code (DIALOG_CreateControls32 function in ./windows/dialog.c), so that at least an existing button-ID is stored as a default. NB: I can't use CVS (for a login problem) -- Katia Maculan Developer ISIS Papyrus Italy Srl Tel: (+39) 0125 6455400 Fax: (+39) 0125 6455150 E-mail: katia.maculan(a)isis-papyrus.com Info: info(a)isis-papyrus.com Hotline: +43-2236-27551-111 Visit our Website: http://www.isis-papyrus.com diff -urN oldwinedir/dlls/user/controls.h newwinedir/dlls/user/controls.h --- oldwinedir/dlls/user/controls.h 2004-03-04 02:41:11.000000000 +0100 +++ newwinedir/dlls/user/controls.h 2004-07-15 14:05:44.000000000 +0200 @@ -126,6 +126,7 @@ INT idResult; /* EndDialog() result / default pushbutton ID */ UINT flags; /* EndDialog() called for this dialog */ HGLOBAL16 hDialogHeap; + INT OriDefButID; /* the original DEFPUSHBUTTON */ } DIALOGINFO; #define DF_END 0x0001 diff -urN oldwinedir/windows/defdlg.c newwinedir/windows/defdlg.c --- oldwinedir/windows/defdlg.c 2004-04-20 06:02:35.000000000 +0200 +++ newwinedir/windows/defdlg.c 2004-07-15 14:07:12.000000000 +0200 @@ -135,13 +135,27 @@ { DWORD dlgcode=0; /* initialize just to avoid a warning */ HWND hwndNew = GetDlgItem(hwndDlg, wParam); - - dlgInfo->idResult = wParam; + //more tests are necessary before save that id like a defpushbutton dlgInfo->idResult = wParam; if (hwndNew && !((dlgcode=SendMessageW(hwndNew, WM_GETDLGCODE, 0, 0 )) & (DLGC_UNDEFPUSHBUTTON | DLGC_BUTTON))) + { + //if destination is not a push button the original def push button is set like default + if (dlgInfo->idResult) + { + HWND hwndOld = GetDlgItem( hwndDlg, dlgInfo->idResult ); + if (hwndOld && (SendMessageA( hwndOld, WM_GETDLGCODE, 0, 0) & DLGC_DEFPUSHBUTTON)) + SendMessageA( hwndOld, BM_SETSTYLE, BS_PUSHBUTTON, TRUE ); + } + dlgInfo->idResult = dlgInfo->OriDefButID; + hwndNew = GetDlgItem (hwndDlg, dlgInfo->OriDefButID); + if (hwndNew) + SendMessageA( hwndNew, BM_SETSTYLE, BS_DEFPUSHBUTTON, TRUE ); return FALSE; /* Destination is not a push button */ + } + if (dlgInfo->idResult == wParam) //if new defbutton is the actual nothing change + return TRUE; if (dlgInfo->idResult) /* There's already a default pushbutton */ { HWND hwndOld = GetDlgItem( hwndDlg, dlgInfo->idResult ); @@ -150,8 +164,11 @@ } if (hwndNew) { - if(dlgcode==DLGC_UNDEFPUSHBUTTON) + if(dlgcode & DLGC_UNDEFPUSHBUTTON) //it is DLGC_UNDEFBUTTON && DLGC_BUTTON + { SendMessageA( hwndNew, BM_SETSTYLE, BS_DEFPUSHBUTTON, TRUE ); + dlgInfo->idResult = wParam; // now is correct to save the new def push button + } } return TRUE; } diff -urN oldwinedir/windows/dialog.c newwinedir/windows/dialog.c --- oldwinedir/windows/dialog.c 2004-05-18 22:45:22.000000000 +0200 +++ newwinedir/windows/dialog.c 2004-07-15 14:07:05.000000000 +0200 @@ -292,6 +292,7 @@ DLG_CONTROL_INFO info; HWND hwndCtrl, hwndDefButton = 0; INT items = dlgTemplate->nbItems; + DWORD dlgcode=0; //to have the control information TRACE(" BEGIN\n" ); while (items--) @@ -353,7 +354,8 @@ /* Send initialisation messages to the control */ if (dlgInfo->hUserFont) SendMessageA( hwndCtrl, WM_SETFONT, (WPARAM)dlgInfo->hUserFont, 0 ); - if (SendMessageA(hwndCtrl, WM_GETDLGCODE, 0, 0) & DLGC_DEFPUSHBUTTON) + dlgcode = SendMessageA(hwndCtrl, WM_GETDLGCODE, 0, 0); //save the result for future test + if (dlgcode & DLGC_DEFPUSHBUTTON) { /* If there's already a default push-button, set it back */ /* to normal and use this one instead. */ @@ -361,7 +363,21 @@ SendMessageA( hwndDefButton, BM_SETSTYLE, BS_PUSHBUTTON, FALSE ); hwndDefButton = hwndCtrl; dlgInfo->idResult = GetWindowLongA( hwndCtrl, GWL_ID ); + dlgInfo->OriDefButID = dlgInfo->idResult; //save the ID like the original DEFPUSHBUTTON } + else + { + // if no defpushbutton is found and the control is a normal pushbutton + // this button is set like defpushbutton + if ((dlgInfo->idResult == 0) && (dlgcode & DLGC_UNDEFPUSHBUTTON)) + { + hwndDefButton = hwndCtrl; + dlgInfo->idResult = GetWindowLongA( hwndCtrl, GWL_ID ); + dlgInfo->OriDefButID = dlgInfo->idResult; + SendMessageA( hwndDefButton, BM_SETSTYLE, BS_DEFPUSHBUTTON, FALSE ); + } + + } } TRACE(" END\n" ); return TRUE;

2 2

printdlg question
by truiken＠gmail.com 16 Jul '04

16 Jul '04

Hi, In the PRINTDLG_WMInitDialog() and PRINTDLG_SetUpPrinterListCombo() functions, what purpose does the 'name' variable server? I know it's the name of the current printer, but what role does it play in setting up the printer list combo? dlls/commdlg/printdlg.c Thanks, James Hawkins

1 0

Re: wine-pthread use the TEB register on PowerPC
by Alexandre Julliard 16 Jul '04

16 Jul '04

"Pierre d'Herbemont" <pidherbemont(a)opendarwin.org> writes: > This patch enables the use of wine-pthread on darwin, and more > generally on PowerPC hosts. > > Pierre. > > ChangeLog: > Use the TEB register on PowerPC hosts. The intent is that wine-pthread should use only portable pthread functions. Why do you need the TEB register to be setup when using wine-pthread? -- Alexandre Julliard julliard(a)winehq.org

1 0

wrong test results on test.winehq.org
by Stefan Leichter 15 Jul '04

15 Jul '04

Hello, is it right that the test result in the directory 200407111000 are build from cvs of the 11th July 2004? If no please delete the mail now ;-) Otherwise please take a look to the failing kernel:profile tests results of e.g win98 (http://test.winehq.org/data/200407111000/98se_JosephBooker/kernel32:profile…) you will see lines like profile.c:82: Test failed: test<01>: ret<0000000000> exp<4294967295> but if you check the source code of the tests (http://cvs.winehq.org/cvsweb/wine/dlls/kernel/tests/profile.c?rev=1.5&conte…) you will find that a second number must be displayed at the end of the line ok((res == profileInt[i].result) || (res == profileInt[i].result9x), "test<%02d>: ret<%010u> exp<%010u><%010u>\n", ^^^^^ here i, res, profileInt[i].result, profileInt[i].result9x); So either the test binary used old source files or the results are sorted into a wrong "wine version". Can please someone have a look Thanks Stefan

2 1

Re: Prevent heap corruption in CryptAcquireContext
by Alexandre Julliard 15 Jul '04

15 Jul '04

Michael Jung <mjung(a)iss.tu-darmstadt.de> writes: > this is a resubmit of a simple patch I've sent yesterday, but which was not > applied to cvs. I would like to give some detail on it: There is a section of > code labeled "error:" at the end of CryptAcquireContext, which releases > occupied resources in the case of an error. Amongst others, the allocated > memory pointed to by "keyname" is released. However, in some cases keyname is > released twice, once in the normal code and once in the error cleanup code. > CRYPT_Free uses LocalFree, which returns "NULL" if the memory was > successfully released. And it does basically nothing if it is called with a > "NULL" pointer. This means that by executing "keyname = > (PSTR)CRYPT_Free(keyname)" the second call to CRYPT_Free does basically > nothing, which is better than corrupting the heap ;) The patch is OK, but it would be better to really avoid calling CRYPT_Free twice, and also to fix all the other places in that function that have the same problem. -- Alexandre Julliard julliard(a)winehq.org

2 1

FMOD audio engine fails to initialize DirectMusic
by Saulius Krasuckas 15 Jul '04

15 Jul '04

I discovered it by running one simple game [1]: [s2@katleriai Tetris]$ wine Tetris.exe err:wave:OSS_RawOpenDevice ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed (Input/output error) fixme:dsound:IDirectSoundImpl_SetCooperativeLevel level=DSSCL_PRIORITY not fully supported fixme:dmime:IDirectMusicPerformance8Impl_Init (iface = 0x402a0748, dmusic = 0x100506e4, dsound = 0x4026c288, hwnd = (nil)) err:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_SetObject : couldn't parse descriptor MessageBox the pops up and says: "Data files missing or corrupt. Please reinstall." Querying the "dmloader" debug channel gives: [s2@katleriai Tetris]$ WINEDEBUG=+dmloader wine Tetris.exe err:wave:OSS_RawOpenDevice ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed (Input/output error) fixme:dsound:IDirectSoundImpl_SetCooperativeLevel level=DSSCL_PRIORITY not fully supported fixme:dmime:IDirectMusicPerformance8Impl_Init (iface = 0x40260600, dmusic = 0x100506e4, dsound = 0x4026c298, hwnd = (nil)) trace:dmloader:DMLOADER_DllGetClassObject (CLSID_DirectMusicLoader, IID_IClassFactory, 0x4074f39c) trace:dmloader:DMUSIC_CreateDirectMusicLoaderCF (IID_IClassFactory, 0x4074f39c, (nil)) trace:dmloader:IDirectMusicLoaderCF_QueryInterface (0x40260918, IID_IClassFactory, 0x4074f39c) trace:dmloader:IDirectMusicLoaderCF_AddRef (0x40260918): AddRef from 0 trace:dmloader:IDirectMusicLoaderCF_CreateInstance (0x40260918, (nil), IID_IDirectMusicLoader, 0x100506f0) trace:dmloader:DMUSIC_CreateDirectMusicLoaderImpl (IID_IDirectMusicLoader, 0x100506f0, (nil)) trace:dmloader:DMUSIC_InitLoaderSettings : (0x40260938) trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_SetObject (0x40260938, 0x4074f008): pDesc: DMUS_OBJECTDESC (0x4074f008): - dwSize = 0x00000350 - dwValidData = 0x00000033 ( DMUS_OBJ_OBJECT DMUS_OBJ_CLASS DMUS_OBJ_FILENAME DMUS_OBJ_FULLPATH ) - guidClass = CLSID_DirectMusicCollection - guidObject = {f17e8673-c3b4-11d1-870b-00600893b1bd} - wszFileName = L"c:\\windows\\system\\drivers\\gm.dls" trace:dmloader:DMUSIC_CreateDirectMusicLoaderFileStream (0x4074e868) trace:dmloader:IDirectMusicLoaderFileStream_IStream_QueryInterface (0x40262250, IID_IStream, 0x4074e868) trace:dmloader:IDirectMusicLoaderFileStream_IStream_AddRef (0x40262250): AddRef from 0 trace:dmloader:IDirectMusicLoaderFileStream_Attach (0x40262250, L"c:\\windows\\system\\drivers\\gm.dls", 0x40260938) trace:dmloader:IDirectMusicLoaderFileStream_Detach (0x40262250) warn:dmloader:IDirectMusicLoaderFileStream_Attach : failed err:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_SetObject : couldn't parse descriptor trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_QueryInterface (0x40260938, IID_IDirectMusicLoader, 0x100506f0) trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_AddRef (0x40260938): AddRef from 0 trace:dmloader:IDirectMusicLoaderCF_Release (0x40260918): ReleaseRef to 0 trace:dmloader:IDirectMusicLoaderImpl_IDirectMusicLoader_EnableCache (0x40260938, CLSID_DirectMusicSegment, 0) trace:dmloader:DMUSIC_GetLoaderSettings : (0x40260938, CLSID_DirectMusicSegment, (nil), 0x4074f3a4) trace:dmloader:DMUSIC_SetLoaderSettings : (0x40260938, CLSID_DirectMusicSegment, (nil), 0x4074f3c4) I think FMOD tries to open the "General MIDI collection of DLS instruments" called GM.DLS and fails to do so as Wine doesn't have it. Any ideas on the legal way to install it onto the Wine system? MS states [2] some stuff regarding GM.DLS collection: > You can use this collection with any DirectMusic Producer piece, and it > is available on all DirectMusic playback systems. > > The default GM.dls collection is available to all projects at all times, > and you should not add it to the project tree. > > The sounds in this DLS collection consist of the GM/GS Sound Set that > are licensed from Roland Corporation and are the same as those used for > Roland's Sound Canvas family of music synthesizers. > > Important > For more information about legal issues related to using the GM.dls., > click the copyright link at the bottom of this page. Does anyone knows or can explain the license MS mentions here? Am i allowed to copy the file from any web page or another place? Or another point: would it be sane to expect the Wine devs to implement simplified/different version of this collection in the future? TIA. [1] http://gamedev.kobra.ktu.lt/Downloads/TetrisMav/Tetris.zip [2] http://msdn.microsoft.com/library/shared/deeptree/asp/rightframe.asp?dtcfg=…

5 8

wgl prototypes missing from wingdi.h
by Tom Schutter 15 Jul '04

15 Jul '04

It appears that although support for binary apps using OpenGL exists in wine, you cannot compile a Windows OpenGL app using winelib, because none of the wgl prototypes exist in wingdi.h These prototypes exist in wgl.h, but that is not installed using "make install", nor is that where apps would expect them. -- Tom Schutter (mailto:tom@platte.com) Platte River Associates, Inc. (http://www.platte.com)

3 5

(no subject)
by corpseeater.xax＠centrum.cz 15 Jul '04

15 Jul '04

I have found a problem in wine,when I want to scroll in emulated apliccation.Wine crashes with an error message.And wine ask me if I want to debug crashed application.Please correct this problem in new version. --------------- VYHRAJ vlastní medaili ve sportovní aréně na http://ateny2004.centrum.cz

2 1

RFC: OpenSSL vs NSS
by Steven Edwards 15 Jul '04

15 Jul '04

Hello, I believe we have a licensing issue with the crypto implementation in Wine and would like feedback relating to this. I know that some of the OpenSSL developers monitor this list so please provide feedback. The first question is in regards to the following: Clause 3 of OpenSSL license: * 3. All advertising materials mentioning features or use of this * software must display the following acknowledgment: * "This product includes software developed by the OpenSSL Project * for use in the OpenSSL Toolkit. (http://www.openssl.org/)" This stipulation seems to introduce a incompatibility with the GPL. For normal Wine this is not a big deal but if someone wants to make a Winelib application that is GPL or if I want to take Wines Wininet and Adavapi32 code in to ReactOS this presents a problem. Am I correct in reading it this way? If I am correct and it is incompatible with with GPL then would any of the Wine developers object to changing out crypto implementation to use NSS from Mozilla? I have spoken with the developers of Network Security Services for Mozilla and it has recently been tri-licensed MPL/LGPL/GPL on CVS tip. http://www.mozilla.org/projects/security/pki/nss/ >From the what I understand this lib provides everything we need so all it really means is that our soft dependency on OpenSSL in now a soft dependency on Mozilla. If we want to use the webbrowser module in Wine then a Mozilla dependency will be there already so we might as well use the security implementation while we are at it. Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - 50x more storage than other providers! http://promotions.yahoo.com/new_mail

4 4

Re: FMOD audio engine fails to initialize DirectMusic
by Mike Hearn 14 Jul '04

14 Jul '04

On Tue, 13 Jul 2004 22:04:06 +0200, Saulius Krasuckas wrote: > I think FMOD tries to open the "General MIDI collection of DLS > instruments" called GM.DLS and fails to do so as Wine doesn't have it. > Any ideas on the legal way to install it onto the Wine system? If you have a Windows license you can just copy it across. > Does anyone knows or can explain the license MS mentions here? Am i > allowed to copy the file from any web page or another place? I guess so but it's like DCOM - only if you have a Windows license. > Or another point: would it be sane to expect the Wine devs to implement > simplified/different version of this collection in the future? TIA. No, definitely not, this sort of thing is like metrically-compatible fonts: they basically need to be donated (or we need to license them/equivalents ourselves from Roland or some other music company somehow).

1 0

[PATCH] Implement an Esd sound module
by Zhangrong Huang 14 Jul '04

14 Jul '04

Hi, all, I'm now using the GNOME desktop environment which uses esd as sound server, sometimes I need wine to run some Windows apps with sound support, but now wine has no esd sound module, so I have to killall esd before I start wine. I have searched the mailing list for solutions, found there is a bug about this: http://www.winehq.org/hypermail/wine-bugs/2002/12/0066.html http://bugs.winehq.com/show_bug.cgi?id=326 I have try esddsp, but it sometimes does not work, so, I decided to write the Esd sound module, it's based the Arts sound module, just replaced the arts calls with esd calls, and fixd some problems related to esd. It works fine for me, I attach the patch here, and if it works for the others, it may close the old bug #326. Test: $ wine sndrec32.exe See if it works. Thanks, I'm new to wine;-) ChangeLog: * configure, configure.ac, dlls/Makefile.in, dlls/winmm/wineesd/.cvsignore, dlls/winmm/wineesd/Makefile.in, dlls/winmm/wineesd/audio.c, dlls/winmm/wineesd/wineesd.drv.spec, dlls/winmm/wineesd/esound.c, dlls/winmm/wineesd/esound.h, documentation/multimedia.sgml, documentation/samples/config, include/config.h.in: Added wineesd.drv dll, part of winmm.

1 0

Re: Make wine honor LC_CTYPE and LC_MESSAGES
by Shachar Shemesh 14 Jul '04

14 Jul '04

Hi Alexandre, I was wondering whether there was a reason this patch was not applied. Shachar Shachar Shemesh wrote: > Changelog: > Shachar Shemesh <winecode(a)shemesh.biz> > dlls/kernel/locale.c > > * System default locale in Windows determines the ANSI encoding > (LC_CTYPE on Unix) > * User default locale determines the language in which the system > works (LC_MESSAGES on Unix). > > >------------------------------------------------------------------------ > >Index: dlls/kernel/locale.c >=================================================================== >RCS file: /home/sun/sources/cvs/wine/dlls/kernel/locale.c,v >retrieving revision 1.46 >diff -u -r1.46 locale.c >--- dlls/kernel/locale.c 7 Jul 2004 00:47:31 -0000 1.46 >+++ dlls/kernel/locale.c 8 Jul 2004 18:01:22 -0000 >@@ -505,13 +505,14 @@ > /*********************************************************************** > * init_default_lcid > */ >-static LCID init_default_lcid( UINT *unix_cp ) >+static LCID init_default_lcid( UINT *unix_cp, const char *env1, const char *env2 ) > { > char *buf, *lang,*country,*charset,*dialect,*next; > LCID ret = 0; > > if ((lang = getenv( "LC_ALL" )) || >- (lang = getenv( "LANGUAGE" )) || >+ (lang = getenv( env1 )) || >+ (env2 && (lang = getenv( env2 ))) || > (lang = getenv( "LANG" ))) > { > if (!strcmp(lang,"POSIX") || !strcmp(lang,"C")) goto done; >@@ -2483,11 +2484,13 @@ > const union cptable *unix_cp ); > > UINT ansi_cp = 1252, oem_cp = 437, mac_cp = 10000, unix_cp = ~0U; >- LCID lcid = init_default_lcid( &unix_cp ); >+ LCID lcid = init_default_lcid( &unix_cp, "LC_MESSAGES", "LANGUAGE" ); > >- NtSetDefaultLocale( FALSE, lcid ); > NtSetDefaultLocale( TRUE, lcid ); > >+ lcid = init_default_lcid( &unix_cp, "LC_CTYPE", NULL ); >+ NtSetDefaultLocale( FALSE, lcid ); >+ > ansi_cp = get_lcid_codepage(lcid); > GetLocaleInfoW( lcid, LOCALE_IDEFAULTMACCODEPAGE | LOCALE_RETURN_NUMBER, > (LPWSTR)&mac_cp, sizeof(mac_cp)/sizeof(WCHAR) ); > > -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

FW: Common "SaveAs" dialog box does not honor the user selected f ile extension.
by Krishna Murthy 13 Jul '04

13 Jul '04

Please let me know any update on this patch. Thanks, Krishna -----Original Message----- From: Krishna Murthy Sent: Wednesday, June 16, 2004 1:29 PM To: Krishna Murthy; 'wine-patches(a)winehq.org' Subject: Common "SaveAs" dialog box does not honor the user selected file extension. - Short Description: The "SaveAs" common dialog box does not save the file with the user selected extension even though the file type is chosen. - Long Description: Wine adds default extension to the file and ignores the selected extension from file type of "SaveAs" dialog box. Say the default extension is .txt, and other specified file extensions are .bmp and .app. Now if we enter the file name as xxx and select the filter extension as .bmp and perform the save, the saved file will be named as xxx.txt even though the selected filter was .bmp - Patch: filedlg.80361.patch.diff - Change log Entry: Add the selected extension from file type filter if file name does not contain the file extension. Krishna Gupta Technologies LLC TEL: (650) 596-4828 E-mail: Krishna.Murthy(a)guptaworldwide.com <mailto:Krishna.Murthy@guptaworldwide.com>

1 0

Re: Wininet Buffer Length Fixes
by Alexandre Julliard 13 Jul '04

13 Jul '04

Robert Shearman <rob(a)codeweavers.com> writes: > --- wine/dlls/wininet/http.c 4 Jul 2004 00:24:47 -0000 1.65 > +++ wine/dlls/wininet/http.c 13 Jul 2004 16:23:11 -0000 > @@ -1131,8 +1186,8 @@ > if( result ) > { > len = WideCharToMultiByte( CP_ACP,0, bufferW, len / sizeof(WCHAR), > - lpBuffer, *lpdwBufferLength, NULL, NULL ); > - *lpdwBufferLength = len * sizeof(WCHAR); > + lpBuffer, *lpdwBufferLength+1, NULL, NULL ); > + *lpdwBufferLength = (len-1) * sizeof(CHAR); It seems to me this would potentially write beyond the end of the buffer, that doesn't look right. -- Alexandre Julliard julliard(a)winehq.org

2 2

I can't the form's content while typing
by ericson 13 Jul '04

13 Jul '04

hi all! i have an app running perfectly, except for a bug that hides the words from the fields. if i commit the data filled it is stored as expected but i can't see it while i'm typing.. understand? in the debug messages we can see these lines when the form pops up: ... err:win:SetWindowPos detected negative window extents 355 x -5 fixme:win:SetWindowTextA cannot set text "" of other process window (nil) fixme:win:SetWindowTextA cannot set text "" of other process window (nil) fixme:win:SetWindowTextA cannot set text "" of other process window (nil) err:win:SetWindowPos detected negative window extents 47 x -5 err:win:SetWindowPos detected negative window extents 205 x -5 ... any idea? i've already tried the "Managed" windows mode, no success.. thanx for attention. cheers rxon

1 0

strange problem on mdk10
by Ivan 13 Jul '04

13 Jul '04

on my laptop wine just starts and doesn't do anything. In addition to this, ps -A, ctrl+c, ctrl+z, the kde system guard and all tools that popup a box to ask for root password all stop working. Attached is a relay log. Any ideas?

2 1

Re: Fix snprintfW Return Value
by Alexandre Julliard 12 Jul '04

12 Jul '04

Rob Shearman <rob(a)codeweavers.com> writes: > On Fri, 2004-07-09 at 19:55, Alexandre Julliard wrote: >> Actually, something does depend on it: it is used to implement >> _vsnwprintf in ntdll, so you can't change it. > > How about this updated patch then? No, vsnprintfW is used directly in ntdll.spec, you can't change it. And really, all the profile code uses it for is %s formats, it can easily be replaced by strcpy which would also avoid the need to build the string twice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: tests/vartype gcc fix
by Alexandre Julliard 12 Jul '04

12 Jul '04

Marcus Meissner <marcus(a)jet.franken.de> writes: > Illegal lvalue casts in tests/vartype.c spotted by new compiler. Also > the format strings were wrong for long longs. Long long format strings are not portable, they shouldn't be used. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: added API documentation to advapi32/crypt.c
by Mike Hearn 12 Jul '04

12 Jul '04

Wow, go truiken! This sort of stuff is really handy, it's so much easier to document wierd stuff in the Wine API docs than rely on MSDN and peoples memories. Good work! On Mon, 2004-07-12 at 02:44 -0500, truiken(a)gmail.com wrote: > Changelog > * Added API documentation to most crypt.c functions

1 0

Status of MSI
by Mike McCormack 12 Jul '04

12 Jul '04

Hi All, I've completed the merge of the work Aric and I have done to date on MSI. Some programs that use and do not package the MSI installer may start to work. We still have no implementation of msiexec.exe, so there is still no method to install .msi files directly, however not all MSI based installs require msiexec.exe. (It's fairly easy to implement if anybody wishes to volunteer...) Consider adding "msi" = "native, builtin" to your Wine configuration files, and not installing the MSI redistributables straight away when you encounter an installer that uses msi.dll :) Let us know what bugs that turns up. thanks, Mike

6 6

Stack blowout in _w95_dump_dke
by wine＠troy.rollo.name 12 Jul '04

12 Jul '04

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 _w95_dump_dke has code in it that processes sibling keys in the registry recursively. This results in a stack blowout for large registries (in my case in the Software\CLASSES key). It's trivial to stop the stack blowing out by changing this not to be recursive, but processing siblings recursively is such an unusual thing to do that I suspect it must have been done for a reason. Attached is the way I've "fixed" it, but this causes the keys to be output in the opposite order to the way they are output with the CVS code. Is there a reason this needs to be done in the order the CVS code is doing it? -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFA8bbd2IoBoXB5Q0kRAoJEAJ9IbtBVxkly+8t8LPL2ZmD/RVwq6wCdHG2t QxlBYcbU/VVdeXLx0QVgQlo= =ZSKw -----END PGP SIGNATURE-----

2 1

Re: Add a 16-bit pair DLL for TWAIN
by Andreas Mohr 11 Jul '04

11 Jul '04

On Thu, Jul 08, 2004 at 06:26:12PM +0100, Mike Hearn wrote: > This is probably wrong in some aspects as this is the first time I have > done a 16 bit pair DLL, but the Office XP installer never actually calls > it, it just loads it in order to get the version information. > > The main problem is that I can't find way to dump the exports of a 16 bit DLL. > winedump can't do that. So, as the 32 bit DLL has only one entry point, I assumed > it was the same for the 16 bit version. nedump.exe or exedump.exe or so. Greetings, Andreas Mohr

2 1

call to unimplemented function secur32.dll.GetComputerObjectNameW
by Saulius Krasuckas 11 Jul '04

11 Jul '04

I stuck at this while trying to install "Microsoft Visual C++ Express 2005 Beta" (large package for offline installation): trace:module:process_attach (L"secur32.dll",(nil)) - END fixme:seh:EXC_RtlRaiseException call to unimplemented function secur32.dll.GetComputerObjectNameW trace:module:GetModuleFileNameW L"D:\\msdownld.tmp\\IXP000.TMP\\install.exe" <skip /> trace:module:GetModuleFileNameW L"D:\\msdownld.tmp\\IXP000.TMP\\install.exe" err:seh:setup_exception nested exception on signal stack in thread 000d eip 400dddc6 esp 40015c6c stack 0x40660000-0x40760000 trace:module:LdrShutdownProcess () MS documents some things [1] about the GetComputerObjectNameW() function in the Platform SDK: * Header: Declared in Secext.h; include Security.h. AFAICS Wine has no "secext.h" file in its "include/" directory. Where should I declare this function and the enumeration it uses [2] would I start implementing the function? [1] http://msdn.microsoft.com/library/shared/deeptree/asp/rightframe.asp?dtcfg=… [2] http://msdn.microsoft.com/library/shared/deeptree/asp/rightframe.asp?dtcfg=…

1 0

Marshal bug
by Duane Clark 11 Jul '04

11 Jul '04

Howdy, This patch: http://www.winehq.org/hypermail/wine-cvs/2004/05/0283.html causes a crash within Actel Designer (commercial FPGA design software). Reverting the patch with current CVS fixes the application. A trace and crash dump look like > wine /c/Actel/bin/designer.exe trace:ole:DllMain 0x40ea0000 0x1 0x1 trace:ole:DllMain (0x41030000,1,0x1) trace:ole:OleInitialize ((nil)) trace:ole:CoInitializeEx ((nil), 2) trace:ole:CoInitializeEx () - Initializing the COM libraries trace:ole:RunningObjectTableImpl_Initialize () trace:ole:OleInitialize () - Initializing the OLE libraries trace:ole:OLEClipbrd_Initialize () fixme:ole:CoRegisterMessageFilter stub trace:ole:RegisterDragDrop (0x10040,0x41fc1ddc) trace:ole:UuidCreate {8b881308-d111-11d8-8790-002078041c53} trace:ole:__CLSIDFromStringA {A111826C-DB40-11d2-8D34-0008C7523E29} -> 0x4073f218 trace:ole:WINE_StringFromCLSID 0x4073f218->{A111826C-DB40-11D2-8D34-0008C7523E29} trace:ole:CoLoadLibrary (L"C:\\Actel/bin/comdesign.dll", 0) trace:ole:CoCreateFreeThreadedMarshaler (0x41fc6a60 0x41fc6a74) trace:ole:__CLSIDFromStringA {4B95E7E3-6EC5-11D2-BA21-0008C7A01E5D} -> 0x4073f870 trace:ole:WINE_StringFromCLSID 0x4073f870->{4B95E7E3-6EC5-11D2-BA21-0008C7A01E5D} trace:ole:CoLoadLibrary (L"C:\\Actel/bin/timingui.dll", 0) trace:ole:__CLSIDFromStringA {F70AA652-C79A-11d2-BA4B-0008C7A01E5D} -> 0x4073f66c trace:ole:WINE_StringFromCLSID 0x4073f66c->{F70AA652-C79A-11D2-BA4B-0008C7A01E5D} trace:ole:CoLoadLibrary (L"C:\\Actel/bin/taiming.dll", 0) err:toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 err:toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 err:toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 err:toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 trace:ole:CoMarshalInterThreadInterfaceInStream ({27a4f276-6452-11d2-ba1d-0008c7a01e5d}, 0x43932bf8, 0x4073f9e8) trace:ole:CoMarshalInterface (0x402b4180, {27a4f276-6452-11d2-ba1d-0008c7a01e5d}, 0x43932bf8, 3, (nil), 0) trace:ole:_StubMgrThread Stub Manager Thread starting on (\\.\pipe\WINE_OLE_StubMgr_00000008) trace:ole:CoCreateFreeThreadedMarshaler (0x41fc72f0 0x41fc7348) trace:ole:IiFTMUnknown_fnQueryInterface trace:ole:FTMarshalImpl_AddRef fixme:ole:FTMarshalImpl_GetUnmarshalClass (), stub! fixme:ole:FTMarshalImpl_MarshalInterface (), stub! trace:ole:FTMarshalImpl_Release trace:ole:CoInitializeEx ((nil), 2) trace:ole:CoGetInterfaceAndReleaseStream (0x402b4180, {27a4f276-6452-11d2-ba1d-0008c7a01e5d}, 0x46cb413c) trace:ole:CoUnmarshalInterface (0x402b4180,{27a4f276-6452-11d2-ba1d-0008c7a01e5d},0x46cb413c) trace:ole:WINE_StringFromCLSID 0x46cb4014->{402B4180-FA0C-40EE-EBF8-EE40F0CE5360} trace:ole:CoGetClassObject CLSID: {402b4180-fa0c-40ee-ebf8-ee40f0ce5360}, IID: {00000001-0000-0000-c000-000000000046} warn:ole:CoGetClassObject class {402B4180-FA0C-40EE-EBF8-EE40F0CE5360} not registred trace:ole:WINE_StringFromCLSID 0x46cb4014->{402B4180-FA0C-40EE-EBF8-EE40F0CE5360} trace:ole:WINE_StringFromCLSID 0x46cb4014->{402B4180-FA0C-40EE-EBF8-EE40F0CE5360} fixme:ole:CoCreateInstance no classfactory created for CLSID {402b4180-fa0c-40ee-ebf8-ee40f0ce5360}, hres is 0x80040150 fixme:ole:CoUnmarshalInterface Failed to create instance of unmarshaller {402b4180-fa0c-40ee-ebf8-ee40f0ce5360}. wine: Unhandled exception (thread 000d), starting debugger... fixme:console:SetConsoleCtrlHandler (0x4066a5e0,1) - no error checking or testing yet WineDbg starting on pid 0x8 Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x6051b58f). In 32 bit mode. err:dbghelp_msc:pdb_process_file -Unable to peruse .PDB file e:\users\ChiJ\objs\pc_4.0.3.5\timingui\msobj\timingui.pdb 0x6051b58f: movl 0x0(%eax),%ecx Wine-dbg>bt Backtrace: =>1 0x6051b58f (0x46cb4160) 2 0x40374e57 THREAD_Start+0xef(ptr=0x402b3dd8) [thread.c:107] in kernel32 (0x46cb4234) 3 0x400a2f23 start_thread+0x147(info=0x402b05e0) [thread.c:199] in ntdll (0x46cb4a70) 4 0x40043484 start_thread+0x64 in libpthread.so.0 (0x46cb4a94) 5 0x420df147 __clone+0x57 in libc.so.6 (0x00000000) Wine-dbg>

3 7

Missing SHLWAPI function
by Flameeyes 11 Jul '04

11 Jul '04

Hi, I was trying a small program wrote in Visual Basic by a friend of mine. A part from missing ActiveX he used to display data, it seems to work, but when it's closed, there's an unhandled exception, and there're some errors about SHLWAPI: err:module:import_dll No implementation for SHLWAPI.dll._SHGetInstanceExplorer@4 imported from L"C \\WINDOWS\\SYSTEM\\BROWSEUI.DLL", setting to 0xdeadbeef [...] fixme:seh:EXC_RtlRaiseException call to unimplemented function shlwapi.dll.IUnknown_GetSite wine: Unhandled exception (thread 0012), starting debugger... using native shlwapi, it doesn't crash at close, but the first message is printed anyway. There are still other errors and problems, I'm trying to search which native dlls are needed to run it quite correctly. Another problem I found is that scrolling down a richedit object (after put riched32 as native) throws an unhandled exception. If someone want's to give it a try and help me get it working, it's FileXplorer at www.sepham.com . -- Diego "Flameeyes" Pettenò dgp85(a)users.sourceforge.net - http://flameeyes.web.ctonet.it/

1 0

Re: New WNEGRAPHICSDRIVER env var
by Vincent Béron 10 Jul '04

10 Jul '04

Le sam 10/07/2004 à 11:37, Vincent Béron a écrit : > Changelog: > Create a WINEGRAPHICSDRIVER env var to override either the config value > or the default value (in user and gdi). Please disregard, there's a problem with the patch (changed the default value in gdi to ttydrv). I'll send an updated patch. Vincent

1 0

ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed
by Saulius Krasuckas 10 Jul '04

10 Jul '04

With thepatch [1] I am getting some this line from Wine: err:wave:OSS_RawOpenDevice ioctl(/dev/dsp, SNDCTL_DSP_SETDUPLEX) failed (Input/output error) Yes, my soundcard doesn't support full duplex, I believe (I have OPTi 82c931 chip with mad16 driver running here). But shouldn't the type of the message be WARN or TRACE instead of ERR then? [1] http://cvs.winehq.org/patch.py?id=12636

2 1

Re: Initial creation of directory and config with ttydrv
by Shachar Shemesh 10 Jul '04

10 Jul '04

brettholcomb(a)charter.net wrote: >Just run wine. The first time it will create the directory. > > > >>From: Shachar Shemesh <wine-devel(a)shemesh.biz> >>Date: 2004/07/08 Thu AM 11:35:21 GMT >>To: Wine Development <wine-devel(a)winehq.org> >>Subject: Initial creation of directory and config with ttydrv >> >>Hi all, >> >>I need to create the initial environment for wine (the .wine directory) >>in an environment where no X11 server is available. Once the directory >>is up (for example, if I copy it from somewhere), there is no problem to >>add a config file that chooses the ttydrv driver. However, I cannot >>create the initial directory. >> >>Is there any solution to this problem, or should I just copy the initial >>config from somewhere? >> >> Shachar >> >> Wine won't run if it is set to use the X11drv driver, and there is no X11 display. Then again, the only way I can tell it to use the ttydrv is by placing a config file in the .wine directory, which does not exist until I run wine once. Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

4 7

Re: D3D8_GetCreationParameters fix
by Andrei Barbu 10 Jul '04

10 Jul '04

MSDN says that if it's given an invalid pointer it should return D3DERR_INVALIDCALL, so that's what it does now. MSDN: http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c… So I'm guessing this is right now. I don't have a windows computer to check this against, but it does comply with the docs. Andrei On Fri, 2004-07-09 at 11:19, Mike McCormack wrote: > This patch is better than the first one, but... > > Windows doesn't usually check pointers like this. Can you try testing > the Windows implementation of IDirect3DDevice8->GetCreationParameters() > to see whether it crashes when passed an invalid pointer such as NULL or > 0x00000001? It may be that the invalid pointer is coming from somewhere > else in Wine's code, so you may be just hiding another bug. > > Mike > > Andrei Barbu wrote: > > And this is the correct patch. > > > @@ -380,6 +381,12 @@ > > HRESULT WINAPI IDirect3DDevice8Impl_GetCreationParameters(LPDIRECT3DDEVICE8 iface, D3DDEVICE_CREATION_PARAMETERS *pParameters) { > > ICOM_THIS(IDirect3DDevice8Impl,iface); > > TRACE("(%p) copying to %p\n", This, pParameters); > > + > > + if( IsBadWritePtr( pParameters , sizeof( D3DDEVICE_CREATION_PARAMETERS ) ) ) > > + { > > + WARN("(%p) : bad pointer in device caps (%p)\n", This, pParameters); > > + return D3DERR_INVALIDCALL; > > + } > > memcpy(pParameters, &This->CreateParms, sizeof(D3DDEVICE_CREATION_PARAMETERS)); > > return D3D_OK; > > } > >

4 7

Re: MSI: implement MsiVerifyPackage, cosmetic fixes (with the patch)
by Mike McCormack 09 Jul '04

09 Jul '04

Mike McCormack wrote: > > This is the last change required to sync up the CrossOver's current MSI > implementation with WineHQs. > > Mike > > > ChangeLog: > * implement MsiVerifyPackage, cosmetic fixes > diff -ur dlls/msi/action.c /home/mike/codeweavers/office/wine/dlls/msi/action.c --- dlls/msi/action.c 2004-07-09 14:07:57.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/action.c 2004-06-28 15:01:36.000000000 -0500 @@ -3023,7 +3023,7 @@ } /* - * components FeatureState defaults to FALSE. the idea is we want to + * Components FeatureState defaults to FALSE. The idea is we want to * enable the component is ANY feature that uses it is enabled to install */ for(i = 0; i < package->loaded_features; i++) @@ -3050,7 +3050,7 @@ if (override != NULL) HeapFree(GetProcessHeap(),0,override); /* - * so basically we ONLY want to install a component if its Enabled AND + * So basically we ONLY want to install a component if its Enabled AND * FeatureState are both TRUE */ return ERROR_SUCCESS; @@ -3303,10 +3303,10 @@ static UINT ACTION_RegisterTypeLibraries(MSIPACKAGE *package) { /* - * ok this is a bit confusting.. I am given a _Component key and i believe + * OK this is a bit confusing.. I am given a _Component key and I believe * that the file that is being registered as a type library is the "key file - * of that component" which i interpert to mean "The file in the KeyPath of - * that component" + * of that component" which I interpret to mean "The file in the KeyPath of + * that component". */ UINT rc; MSIQUERY * view; @@ -3388,8 +3388,8 @@ debugstr_w(package->files[index].TargetPath)); else { - /* yes the row has more fields than i need, but #1 is - correct and the only one i need. why make a new row */ + /* Yes the row has more fields than I need, but #1 is + correct and the only one I need. Why make a new row? */ ui_actiondata(package,szRegisterTypeLibraries,row); @@ -3533,8 +3533,8 @@ static UINT ACTION_RegisterClassInfo(MSIPACKAGE *package) { /* - * Again I am assuming the words, "Whose key file respesents" when refering - * to a Component as to mean the Components KeyPath file + * Again I am assuming the words, "Whose key file represents" when refering + * to a Component as to meaning that Components KeyPath file * * Also there is a very strong connection between ClassInfo and ProgID * that I am mostly glossing over. @@ -3811,12 +3811,12 @@ static UINT ACTION_RegisterProgIdInfo(MSIPACKAGE *package) { /* - * Sigh, here i am just brute force registering all progid + * Sigh, here I am just brute force registering all progids * this needs to be linked to the Classes that have been registerd * but the easiest way to do that is to load all these stuff into * memory for easy checking. * - * gives me something to continue to work toward + * Gives me something to continue to work toward. */ UINT rc; MSIQUERY * view; diff -ur dlls/msi/cond.y /home/mike/codeweavers/office/wine/dlls/msi/cond.y --- dlls/msi/cond.y 2004-07-09 13:34:00.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/cond.y 2004-06-28 14:58:46.000000000 -0500 @@ -57,8 +57,6 @@ static LPWSTR COND_GetString( struct cond_str *str ); static int COND_lex( void *COND_lval, COND_input *info); -UINT get_property(MSIHANDLE hPackage, const WCHAR* prop, WCHAR* value, - DWORD* size); typedef INT (*comp_int)(INT a, INT b); typedef INT (*comp_str)(LPWSTR a, LPWSTR b, BOOL caseless); diff -ur dlls/msi/package.c /home/mike/codeweavers/office/wine/dlls/msi/package.c --- dlls/msi/package.c 2004-07-09 14:15:00.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/package.c 2004-07-02 15:07:40.000000000 -0500 @@ -254,7 +254,7 @@ 'D','e','s','k','t','o','p','\\',0}; /* - * Other things i notice set + * Other things I notice set * ScreenY ScreenX --- dlls/msi/msi.c 2004-07-09 14:07:57.000000000 -0500 +++ /home/mike/codeweavers/office/wine/dlls/msi/msi.c 2004-06-28 15:06:37.000000000 -0500 @@ -1180,14 +1181,38 @@ UINT WINAPI MsiVerifyPackageA( LPCSTR szPackage ) { - FIXME("%s\n", debugstr_a(szPackage) ); - return ERROR_CALL_NOT_IMPLEMENTED; + UINT r, len; + LPWSTR szPack = NULL; + + TRACE("%s\n", debugstr_a(szPackage) ); + + if( szPackage ) + { + len = MultiByteToWideChar( CP_ACP, 0, szPackage, -1, NULL, 0 ); + szPack = HeapAlloc( GetProcessHeap(), 0, len*sizeof(WCHAR) ); + if( !szPack ) + return ERROR_OUTOFMEMORY; + MultiByteToWideChar( CP_ACP, 0, szPackage, -1, szPack, len ); + } + + r = MsiVerifyPackageW( szPack ); + + HeapFree( GetProcessHeap(), 0, szPack ); + + return r; } UINT WINAPI MsiVerifyPackageW( LPCWSTR szPackage ) { - FIXME("%s\n", debugstr_w(szPackage) ); - return ERROR_CALL_NOT_IMPLEMENTED; + MSIHANDLE handle; + UINT r; + + TRACE("%s\n", debugstr_w(szPackage) ); + + r = MsiOpenDatabaseW( szPackage, MSIDBOPEN_READONLY, &handle ); + MsiCloseHandle( handle ); + + return r; } INSTALLSTATE WINAPI MsiGetComponentPathA(LPCSTR szProduct, LPCSTR szComponent,

1 0

Re: Fix snprintfW Return Value
by Alexandre Julliard 09 Jul '04

09 Jul '04

Rob Shearman <rob(a)codeweavers.com> writes: > At present, if the size of the buffer passed to snprintfW is too small > then the function returns -1, as opposed to the required size of the > buffer (as per C snprintf). This greatly limits its usefulness and can > give incorrect results for those using the function that don't > explicitly check for -1 being returned. A grep of the source tree shows > that nothing depends on this behaviour. Actually, something does depend on it: it is used to implement _vsnwprintf in ntdll, so you can't change it. -- Alexandre Julliard julliard(a)winehq.org

2 2

support code for HANDLE tables
by Michael Jung 09 Jul '04

09 Jul '04

Hello, I'm currently playing around with the rsabase.dll implementation. Since this is the first time I'm writing wine code, I've got some questions: Is there support code for managing HANDLE tables? Or does every dll implementation provide it's own functions for doing this? Or do HANDLEs of each and every kind have to be administered by wineserver? The current CVS version of rsabase just casts between pointers and HCRYPTPROVs. Is this just a quick and dirty hack or common practice? Greetings and thanks, Michael -- Michael Jung, MSc Be liberal in what you accept, Integrated Circuits and Systems Lab and conservative in what you send. University of Technology, Darmstadt -- Jonathan Postel, Internet Pioneer phone: +49(6151)16-6692 / email: mjung(a)iss.tu-darmstadt.de

3 2

Re: D3D8_GetCreationParameters fix
by Andrei Barbu 09 Jul '04

09 Jul '04

I don't personally know enough about IsBadWritePtr to write a test case. Any suggestions? :P I'll check out the code later on, but for now it seems to be fine. What else could it use to validate that pointer? Andrei On Fri, 2004-07-09 at 15:02, Mike McCormack wrote: > Andrei Barbu wrote: > > > I think even if a wine bug might be generating that bad pointer, which I > > don't think it is since Chessmaster works fine after that, this is how > > DX works, so we should implement it. If it doesn't crash on windows, why > > should it in wine? > > It is rare that Windows uses IsBadWritePtr to validate arguments, so if > you believe it works that way, prove it by writing a test case and > running it on a Windows box. Somebody is going to be suprised by the > results ;) > > Mike >

2 1

Re: D3D8_GetCreationParameters fix
by Andrei Barbu 09 Jul '04

09 Jul '04

And this is the correct patch. Sorry about that, ignore the above. The above actually allocated the memory, this just returns that the op. didn't succeed which is the correct thing to do. Chessmaster seems to be happy too. On Thu, 2004-07-08 at 15:38, Andrei Barbu wrote: > Changelog: > > Fixes a memory access fault inside of D3D8_GetCreationParameters. > >

1 0

Fullscreening patch
by Mike Hearn 09 Jul '04

09 Jul '04

Hi Alexandre, Yes, it's that time again. Can you take another look at this patch? Getting it in is the first step towards fixing a bunch of "i typed but it appeared on the console instead of the game!" bugs (as well as improving a bunch of apps like IE, TightVNC etc). thanks -mike Index: dlls/x11drv/window.c =================================================================== RCS file: /cvstrees/crossover/office/wine/dlls/x11drv/window.c,v retrieving revision 1.49.2.1.2.2 diff -u -w -B -r1.49.2.1.2.2 window.c --- dlls/x11drv/window.c 28 Apr 2004 00:08:44 -0000 1.49.2.1.2.2 +++ dlls/x11drv/window.c 12 May 2004 13:57:38 -0000 @@ -78,6 +78,7 @@ "_MOTIF_WM_HINTS", "_KDE_NET_WM_SYSTEM_TRAY_WINDOW_FOR", "_NET_WM_STATE", + "_NET_WM_STATE_FULLSCREEN", "_NET_WM_STATE_MAXIMIZED_VERT", "_NET_WM_STATE_MAXIMIZED_HORZ", "_NET_WM_STATE_SKIP_TASKBAR", @@ -133,6 +134,7 @@ inline static BOOL is_window_managed( WND *win ) { if (!managed_mode) return FALSE; + /* tray window is always managed */ if (win->dwExStyle & WS_EX_TRAYWINDOW) return TRUE; /* tool windows *are* managed if we have mwm hints */ @@ -156,6 +158,8 @@ if (win->dwExStyle & WS_EX_TOOLWINDOW) return FALSE; /* windows with thick frame are managed */ if (win->dwStyle & WS_THICKFRAME) return TRUE; + /* windows with a system menu are managed */ + if (win->dwStyle & WS_SYSMENU) return TRUE; /* * CODEWEAVERS HACK @@ -189,13 +193,7 @@ /* application windows are managed */ if (win->dwExStyle & WS_EX_APPWINDOW) return TRUE; - /* full-screen popup windows are managed */ - if ((win->dwStyle & WS_POPUP) && - (win->rectWindow.right-win->rectWindow.left) == screen_width && - (win->rectWindow.bottom-win->rectWindow.top) == screen_height) - { - return TRUE; - } + /* default: not managed */ return FALSE; } @@ -435,7 +432,10 @@ size_hints->y = data->whole_rect.top; size_hints->flags = PWinGravity | PPosition; - if ( !(win->dwStyle & WS_THICKFRAME) ) + /* we only want to be able to resize windows with WS_THICKFRAME. + * in addition, metacity refuses to fullscreen non-resizable windows + */ + if ( !(win->dwStyle & WS_THICKFRAME) && !data->fullscreened) { size_hints->max_width = data->whole_rect.right - data->whole_rect.left; size_hints->max_height = data->whole_rect.bottom - data->whole_rect.top; @@ -590,7 +590,7 @@ if (win->dwStyle & WS_MINIMIZEBOX) mwm_hints.functions |= MWM_FUNC_MINIMIZE; if (win->dwStyle & WS_MAXIMIZEBOX) mwm_hints.functions |= MWM_FUNC_MAXIMIZE; if (win->dwStyle & WS_SYSMENU) mwm_hints.functions |= MWM_FUNC_CLOSE; - if ((win->dwStyle & WS_CAPTION) == WS_CAPTION) mwm_hints.decorations |= MWM_DECOR_TITLE; + if (((win->dwStyle & WS_CAPTION) == WS_CAPTION) && (!data->fullscreened)) mwm_hints.decorations |= MWM_DECOR_TITLE; if (win->dwExStyle & WS_EX_DLGMODALFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER; else if (win->dwStyle & WS_THICKFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER | MWM_DECOR_RESIZEH; else if ((win->dwStyle & (WS_DLGFRAME|WS_BORDER)) == WS_DLGFRAME) mwm_hints.decorations |= MWM_DECOR_BORDER; @@ -607,6 +607,15 @@ XChangeProperty( display, data->whole_window, x11drv_atom(XdndAware), XA_ATOM, 32, PropModeReplace, (unsigned char*)&dndVersion, 1 ); + /* for windows that are already mapped, toggle_fullscreen sends a message to the WM */ + if (data->fullscreened && !(win->dwStyle & WS_VISIBLE)) { + Atom newstate = x11drv_atom(_NET_WM_STATE_FULLSCREEN); + + TRACE("setting state to _NET_WM_STATE_FULLSCREEN\n"); + XChangeProperty( display, data->whole_window, x11drv_atom(_NET_WM_STATE), + XA_ATOM, 32, PropModeReplace, (unsigned char*)&newstate, 1 ); + } + wm_hints = XAllocWMHints(); wine_tsx11_unlock(); @@ -963,6 +972,8 @@ RECT rect; BOOL is_top_level = is_window_top_level( win ); + data->fullscreened = FALSE; + rect = win->rectWindow; X11DRV_window_to_X_rect( win, &rect ); Index: dlls/x11drv/winpos.c =================================================================== RCS file: /cvstrees/crossover/office/wine/dlls/x11drv/winpos.c,v retrieving revision 1.44.2.3.2.1 diff -u -w -B -r1.44.2.3.2.1 winpos.c --- dlls/x11drv/winpos.c 27 Apr 2004 22:38:15 -0000 1.44.2.3.2.1 +++ dlls/x11drv/winpos.c 12 May 2004 13:57:50 -0000 @@ -76,6 +76,45 @@ extern XContext winContext; /*********************************************************************** + * toggle_fullscreen + * + * Use the NETWM fullscreening protocol to toggle fullscreened state. This only + * works for mapped windows. + */ +static void toggle_fullscreen( HWND hwnd ) +{ + WND *win = WIN_GetPtr(hwnd); + struct x11drv_win_data *data = win->pDriverData; + XEvent xev; + + TRACE("hwnd=%p, current=%s\n", hwnd, data->fullscreened ? "true" : "false"); + data->fullscreened = !data->fullscreened; + + wine_tsx11_lock(); + + X11DRV_set_wm_hints(thread_display(), win); + if (win->dwStyle & WS_VISIBLE) { + TRACE("toggling fullscreen state\n"); + xev.xclient.type = ClientMessage; + xev.xclient.window = data->whole_window; + xev.xclient.message_type = x11drv_atom(_NET_WM_STATE); + xev.xclient.serial = 0; + xev.xclient.display = thread_display(); + xev.xclient.send_event = True; + xev.xclient.format = 32; + /* using _NET_WM_STATE_TOGGLE here does not work correctly with some WMs */ + xev.xclient.data.l[0] = (data->fullscreened ? _NET_WM_STATE_ADD : _NET_WM_STATE_REMOVE); + xev.xclient.data.l[1] = x11drv_atom(_NET_WM_STATE_FULLSCREEN); + xev.xclient.data.l[2] = 0; + XSendEvent(thread_display(), root_window, False, SubstructureRedirectMask | SubstructureNotifyMask, &xev); + TRACE("toggled\n"); + } + + wine_tsx11_unlock(); + WIN_ReleasePtr(win); +} + +/*********************************************************************** * clip_children * * Clip all children of a given window out of the visible region @@ -936,25 +976,44 @@ RECT newWindowRect, newClientRect; RECT oldWindowRect, oldClientRect; UINT wvrFlags = 0; - BOOL bChangePos; + BOOL bChangePos, fromXEvent; + struct x11drv_win_data *data; - TRACE( "hwnd %p, after %p, swp %d,%d %dx%d flags %08x\n", + TRACE("hwnd %p, insert-after %p, swp %d,%d %dx%d\n", winpos->hwnd, winpos->hwndInsertAfter, winpos->x, winpos->y, - winpos->cx, winpos->cy, winpos->flags); + winpos->cx, winpos->cy); + fromXEvent = winpos->flags & SWP_WINE_NOHOSTMOVE; bChangePos = !(winpos->flags & SWP_WINE_NOHOSTMOVE); winpos->flags &= ~SWP_WINE_NOHOSTMOVE; /* Check window handle */ if (winpos->hwnd == GetDesktopWindow()) return FALSE; + if (!(wndPtr = WIN_FindWndPtr( winpos->hwnd ))) return FALSE; + data = wndPtr->pDriverData; + if (!SWP_DoWinPosChanging( winpos, &newWindowRect, &newClientRect )) return FALSE; + if (data->fullscreened) { + + /* Windows has no concept of fullscreen, so to unfullscreen an app you just resize it or move it. + * Therefore we need to watch for this behaviour and release fullscreen mode so we can once again + * control our position. + */ + + if (!fromXEvent /* ignore spurious WM changes once we are fullscreened */ + && !(winpos->flags & (SWP_FRAMECHANGED|SWP_NOMOVE|SWP_NOSIZE|SWP_NOACTIVATE)) /* ignore SWP calls that aren't changing our geometry */ + && !((newWindowRect.left < 0) && (newWindowRect.top < 0))) /* probably moving us beyond the screen boundaries to hide the borders, ignore */ { + + TRACE("releasing fullscreen for %p\n", winpos->hwnd); + toggle_fullscreen( winpos->hwnd ); + } + } + /* Fix redundant flags */ if (!fixup_flags( winpos )) return FALSE; - if (!(wndPtr = WIN_FindWndPtr( winpos->hwnd ))) return FALSE; - TRACE(" current (%ld,%ld)-(%ld,%ld), client (%ld,%ld)-(%ld,%ld), style %08x\n", wndPtr->rectWindow.left, wndPtr->rectWindow.top, wndPtr->rectWindow.right, wndPtr->rectWindow.bottom, @@ -973,8 +1032,9 @@ } /* Common operations */ + wvrFlags = SWP_DoNCCalcSize( winpos, &newWindowRect, &newClientRect ); /* FIXME: this should only be called if the size is actually being changed, unless SWP_FRAMECHANGED is set */ - wvrFlags = SWP_DoNCCalcSize( winpos, &newWindowRect, &newClientRect ); + TRACE("after NC_CALCSIZE (%ld,%ld,%ld,%ld)\n", newWindowRect.left, newWindowRect.top, newWindowRect.right, newWindowRect.bottom); if(!(winpos->flags & SWP_NOZORDER) && winpos->hwnd != winpos->hwndInsertAfter) { @@ -1049,6 +1109,7 @@ XClearArea( display, get_whole_window(wndPtr), 0, 0, 0, 0, True ); winpos->flags |= SWP_FRAMECHANGED; } + if (winpos->flags & SWP_SHOWWINDOW) { set_visible_style( winpos->hwnd, TRUE ); @@ -1124,6 +1185,7 @@ SendMessageA( winpos->hwnd, WM_WINDOWPOSCHANGED, 0, (LPARAM)winpos ); /* WM_WINDOWPOSCHANGED is send even if SWP_NOSENDCHANGING is set */ + TRACE("done for %p\n", winpos->hwnd); return TRUE; } @@ -1206,6 +1265,7 @@ POINT size; LONG old_style; WINDOWPLACEMENT wpl; + struct x11drv_win_data* data; TRACE("%p %u\n", hwnd, cmd ); @@ -1224,9 +1284,12 @@ if (!(wndPtr = WIN_FindWndPtr( hwnd ))) return 0; + data = wndPtr->pDriverData; + size.x = wndPtr->rectWindow.left; size.y = wndPtr->rectWindow.top; + switch( cmd ) { case SW_MINIMIZE: @@ -1400,11 +1463,13 @@ BOOL X11DRV_ShowWindow( HWND hwnd, INT cmd ) { WND* wndPtr = WIN_FindWndPtr( hwnd ); + struct x11drv_win_data *data; BOOL wasVisible, showFlag, wmMaximize, wmMinimize; RECT newPos = {0, 0, 0, 0}; UINT swp = 0; if (!wndPtr) return FALSE; + data = wndPtr->pDriverData; hwnd = wndPtr->hwndSelf; /* make it a full handle */ TRACE("hwnd=%p, cmd=%d\n", hwnd, cmd); @@ -1539,11 +1604,18 @@ MAKELONG(wndPtr->rectClient.left, wndPtr->rectClient.top) ); } + if (!data->fullscreened && wmMaximize) { + /* we should fullscreen captionless windows on maximization (IE uses this) */ + if ((wndPtr->dwStyle & WS_CAPTION) != WS_CAPTION) { + if ((wmMaximize && data->fullscreened) || (cmd == SW_RESTORE && !data->fullscreened)) { + TRACE("toggling fullscreen due to %s of captionless window %p\n", wmMaximize ? "maximization" : "restoration", hwnd); + toggle_fullscreen( hwnd ); + } + } else /* ask the window manager to maximize this window for us */ - if( wmMaximize ) X11DRV_WMMaximizeWindow(wndPtr, TRUE); - else if ( wmMinimize ) - X11DRV_WMMinimizeWindow(wndPtr); + } else if (wmMinimize) X11DRV_WMMinimizeWindow(wndPtr); + END: WIN_ReleaseWndPtr(wndPtr); @@ -2191,8 +2263,10 @@ /* if nothing changed, don't do anything */ if (winpos.flags == (SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER | SWP_NOACTIVATE)) return; + TRACE("syncing window pos enter\n"); SetWindowPos( hwnd, winpos.hwndInsertAfter, winpos.x, winpos.y, winpos.cx, winpos.cy, winpos.flags | SWP_WINE_NOHOSTMOVE ); + TRACE("syncing window pos leave\n"); } Index: dlls/x11drv/x11drv.h =================================================================== RCS file: /cvstrees/crossover/office/wine/dlls/x11drv/x11drv.h,v retrieving revision 1.16.4.1 diff -u -w -B -r1.16.4.1 x11drv.h --- dlls/x11drv/x11drv.h 27 Apr 2004 22:38:15 -0000 1.16.4.1 +++ dlls/x11drv/x11drv.h 12 May 2004 13:57:54 -0000 @@ -420,6 +420,7 @@ XATOM__MOTIF_WM_HINTS, XATOM__KDE_NET_WM_SYSTEM_TRAY_WINDOW_FOR, XATOM__NET_WM_STATE, + XATOM__NET_WM_STATE_FULLSCREEN, XATOM__NET_WM_STATE_MAXIMIZED_VERT, XATOM__NET_WM_STATE_MAXIMIZED_HORZ, XATOM__NET_WM_STATE_SKIP_TASKBAR, @@ -555,6 +556,7 @@ XIC xic; /* X input context */ HBITMAP hWMIconBitmap; HBITMAP hWMIconMask; + BOOL fullscreened; /* does the window have a NETWM fullscreening hint set? */ }; typedef struct x11drv_win_data X11DRV_WND_DATA;

1 0

Re: Re: D3D8_GetCreationParameters fix
by Christian Costa 09 Jul '04

09 Jul '04

> Message du 09/07/04 10:46 > De : "Lionel Ulmer" > A : "Andrei Barbu" > Copie à : "Christian Costa" , "Marcus Meissner" , "Mike McCormack" , wine-devel(a)winehq.org > Objet : Re: D3D8_GetCreationParameters fix > On Thu, Jul 08, 2004 at 08:45:16PM -0400, Andrei Barbu wrote: > > I agree on the docs, interestingly enough though, > > Chessmaster 9000 gives an invalid pointer (0x1) > > and there's a memory access error. > > > > Works on Windows though, so I'm assuming DX might be > > allocating the memory on it's own. > > When you mean 'works on Windows' is it Chessmaser 9000 or the fact that > giving a bad pointer to this DX8 API call does not make the program crash ? > I think he means ChessMaster 9000. > Because to be sure to get your patch applied, the best way would be to > understand WHY CM9000 gives this 0x1 pointer to the DX8 function. It may be > due to a memory allocation error, some stack trashing, some other bugs in > Wine, ... Agreed. > > So I fear that only doing some REing of the CM9000 code would help here. > This is the best things to do but the problem is not always obvious. If REing does not give significant result, I would suggest to check how the function behaves in windows and implement the same behaviour with maybe a big comment about ChessMaster 9000. Bye, Christian

2 1

Re: Re: D3D8_GetCreationParameters fix
by Christian Costa 09 Jul '04

09 Jul '04

> Message du 09/07/04 00:57 > De : "Andrei Barbu" > A : "Christian Costa" > Copie à : "Marcus Meissner" , "Mike McCormack" , wine-devel(a)winehq.org > Objet : Re: D3D8_GetCreationParameters fix > Having given thought to the issue, you're right. > That was a bad solution, sorry. > > It should have failed with D3DERR_INVALIDCALL if it's a bad write > pointer. > Is this new patch ok? > Seems good. :-) Bye, Christian

1 0

Re: D3D8_GetCreationParameters fix
by Mike McCormack 09 Jul '04

09 Jul '04

You probably want to use a Windows method to allocate memory here, such as HeapAlloc() or CoTaskMemAlloc, as the caller is not going to use free() to free the memory... Mike Andrei Barbu wrote: > Changelog: > > Fixes a memory access fault inside of D3D8_GetCreationParameters. ... > HRESULT WINAPI IDirect3DDevice8Impl_GetCreationParameters(LPDIRECT3DDEVICE8 iface, D3DDEVICE_CREATION_PARAMETERS *pParameters) { > ICOM_THIS(IDirect3DDevice8Impl,iface); > TRACE("(%p) copying to %p\n", This, pParameters); > + > + pParameters = (D3DDEVICE_CREATION_PARAMETERS*) malloc( sizeof( D3DDEVICE_CREATION_PARAMETERS )); > memcpy(pParameters, &This->CreateParms, sizeof(D3DDEVICE_CREATION_PARAMETERS)); > return D3D_OK; > }

6 8

Initial creation of directory and config with ttydrv
by Shachar Shemesh 08 Jul '04

08 Jul '04

Hi all, I need to create the initial environment for wine (the .wine directory) in an environment where no X11 server is available. Once the directory is up (for example, if I copy it from somewhere), there is no problem to add a config file that chooses the ttydrv driver. However, I cannot create the initial directory. Is there any solution to this problem, or should I just copy the initial config from somewhere? Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

1 0

HKEY_DYN_DATA in win9x
by Robert Reif 08 Jul '04

08 Jul '04

I have a program that fails when it can't find HKEY_DYN_DATA\Config Manager\Enum in the registry. Any pointers on where to start?

2 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel