- wine-devel - winehq.org

OleDropTargetInterface prop on: RegisterDragDrop at: dlls/ole32/ole2.c
by Sebastian Wain (Hotmail) 01 Apr '04

01 Apr '04

Dear Wine Devel list, I was reading the Drag&Drop implementation in the Wine sources and didn't find a SetProp() of the handle with the property "OleDropTargetInterface" to the IDropTarget pointer. I think it's not a well documented property (not in MSDN) but it appears to be useful if somebody (sometime) will try to automate drag&drop operations. Cheers, Sebastian Wain -- http://swain.webframe.org

2 1

WineAdoptThread
by Paul Davis 01 Apr '04

01 Apr '04

(this is for review by people who know better than me :) [ some functions are replaced here by lower case versions because this code is not part of dlls/ntdll/thread.c. consequently, we have to dlopen() that library, and dlsym() the functions we need. if this ever makes it into Wine, this will go away ] /*********************************************************************** * adopt_thread - take an existing linux thread (of some kind) and make win32 aware of it */ int WineAdoptThread (void) { TEB *teb; void *addr; ULONG size; struct wine_pthread_thread_info thread_info; struct debug_info debug_info; int request_fd; int tid; debug_info.str_pos = debug_info.strings; debug_info.out_pos = debug_info.output; teb = shared_alloc_teb( &size ); teb->tibflags = TEBF_WIN32; teb->exit_code = STILL_ACTIVE; teb->request_fd = -1; teb->reply_fd = -1; teb->wait_fd[0] = -1; teb->wait_fd[1] = -1; teb->debug_info = &debug_info; teb->htask16 = NtCurrentTeb()->htask16; thread_info.stack_base = NULL; thread_info.stack_size = 0; thread_info.teb_base = teb; thread_info.teb_size = size; thread_info.teb_sel = teb->teb_sel; wine_pthread_init_current_teb( &thread_info ); SERVER_START_REQ( new_thread ) { size_t rsz = sizeof (*req); req->suspend = FALSE; req->inherit = 0; /* FIXME */ pthread_mutex_lock (&proxy_thread_lock); if (write (proxy_pipe_request[1], &__req, sizeof (__req)) != sizeof (__req) || read (proxy_pipe_status[0], &__req, sizeof (__req)) != sizeof (__req) || read (proxy_pipe_status[0], &request_fd, sizeof (request_fd)) != sizeof (request_fd)) { fst_error ("cannot read/write proxy thread request (%s)", strerror (errno)); } pthread_mutex_unlock (&proxy_thread_lock); if (request_fd >= 0) { tid = reply->tid; } fst_error ("request FD for adopted thread is %d\n", request_fd); } SERVER_END_REQ; if (request_fd < 0) goto error; teb->ClientId.UniqueProcess = (HANDLE)GetCurrentProcessId(); teb->ClientId.UniqueThread = (HANDLE)tid; teb->request_fd = request_fd; /* don't bother with signal initialization since we redirect all signals back to linux anyway. */ /* SIGNAL_Init(); */ /* server_*/ init_thread( thread_info.pid, thread_info.tid, NULL ); wine_pthread_init_thread( &thread_info ); /* create a memory view for the TEB */ ntallocatevm ( GetCurrentProcess(), &addr, teb, &size, MEM_SYSTEM, PAGE_EXECUTE_READWRITE ); /* allocate a memory view for the stack */ size = thread_info.stack_size; ntallocatevm ( GetCurrentProcess(), &teb->DeallocationStack, thread_info.stack_base, &size, MEM_SYSTEM, PAGE_EXECUTE_READWRITE ); /* limit is lower than base since the stack grows down */ teb->Tib.StackBase = (char *)thread_info.stack_base + thread_info.stack_size; teb->Tib.StackLimit = thread_info.stack_base; /* setup the guard page */ size = 1; ntprotectvm ( GetCurrentProcess(), &teb->DeallocationStack, &size, PAGE_EXECUTE_READWRITE | PAGE_GUARD, NULL ); acquirepeblock (); InsertHeadList( &tls_link_head, &teb->TlsLinks ); releasepeblock (); fprintf (stderr, "thread adopted\n"); return 0; error: shared_free_teb (teb); /* XXX deallocate VM */ /* close thread handle */ close (request_fd); return -1; }

2 1

Regression in file handleing.
by tony_lambregts＠telusplanet.net 01 Apr '04

01 Apr '04

Andrew Talbot reports a regression in icon handling in this bug report. http://bugs.winehq.org/show_bug.cgi?id=2135 apparently it was caused by this patch http://cvs.winehq.org/patch.py?id=11698 -- Tony Lambregts

2 1

Re: bug in winemine about box
by Blake Leverett 01 Apr '04

01 Apr '04

this seems to be broken on win2k3, even if run in compatibility mode. See attached screenshot. It's OK on wine, and I don't have other versions of windows to test. Ivan. Are you really running a windows version of winemine under XP running in Bochs? Or is the screen shot misleading? Blake

1 0

Fwd: Re: Source code visualization tools?
by Blake Leverett 01 Apr '04

01 Apr '04

Joel Konkle-Parker wrote: > Is there such a thing as a source code visualization tool that makes a > "map" of a program's source? Kind of like: > > main() > | > | > function1() > /\ > / \ > func2() func3() > | > | > func4() > > I'm basically looking for something that will help me "see" how a > program is laid out so that I can start working on it. > > Thanks in advance. > > I was looking for a similar thing a while back. One great tool for navigating the wine source is the etags program. In the wine source directory, type 'make etags'. This makes a file called TAGS. Then, start emacs, and type alt-x visit-tags-table, and load the tags file. You can navigate the source by function. See the tags manpage and the emacs manpage for the tags section for details. Blake `--------------- Forwarded message (end)

2 1

bug in winemine about box
by Ivan Leo Murray-Smith 01 Apr '04

01 Apr '04

this seems to be broken on win2k3, even if run in compatibility mode. See attached screenshot. It's OK on wine, and I don't have other versions of windows to test. Ivan.

2 1

Re: [patch] Wine 20040309: documentation patche
by Vincent Béron 01 Apr '04

01 Apr '04

Le mer 31/03/2004 à 11:49, Peter Hanecak a écrit : > Hello, > > while building Wine on "RedHat 9"-like system I encountered two typo in > Wine documentation which prevented me from "compiling" documentation with > docbook2html (docbook-utils-0.6.12-5). The fix is correct, but it's already been applied to cvs on March 11. Usually, it's best to confirm that the bug still exists in current cvs before writing/sending a fix, else there's a real probablitity to duplicate some work. And that probability goes up as time goes by. Vincent

1 0

Winelib Test Drive problem
by greensh＠knology.net 01 Apr '04

01 Apr '04

Hi, I'm starting to use the latest winelib (wine-20040309 release) to try eventually compiling an windows MFC app I wrote. Before attempting this however, I'm following all directions in the winelib user guide, but the Test Drive fails and so it tells me to post to this mailing list. I named my directory winemine2 and copied the source files to this. Then ran winemaker, but it did NOT create a configure script. So I tried make, but it fails with; winebuild -o winemine2.exe.dbg.c --debug -C. dialog.c main.c winegcc -c -mno-cygwin -I. -o winemine2.exe.dbg.o winemine2.exe.dbg.c winegcc -c -mno-cygwin -I. -o dialog.o dialog.c winegcc -c -mno-cygwin -I. -o main.o main.c wrc -I. -foEn.res En.rc En.rc:23:22: Error: syntax error make: *** [En.res] Error 1 I guess if this doesn't work, nothing else might not.

2 1

Re: opengl version.rc
by Alexandre Julliard 31 Mar '04

31 Mar '04

Tom <twickline(a)skybest.com> writes: > Sorry here it is again, Thanks to Ivan & Aric for there time! > If there is a problem with this patch can someone let me know ? :-) I put it in, but next time please send the Makefile changes too, and make the diff relative to the top-level directory. Thanks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: systray in desktop mode [unified resend]
by Mike Hearn 31 Mar '04

31 Mar '04

On Tue, 2004-03-30 at 06:08, Martin Fuchs wrote: > If you want to do exactly what native shell32 does, you can just drop > all the old (non-desktop mode) code and replace it with what my > patch wanted to do in desktop mode. Yes, I realise that. I guess you checked that these are the same messages native shell32.dll uses? > Your new implementation will also create such a message receiver > window. So you want to create your tray window at any startup of > Wine regardless if it will be used or not? May be a bit overkill, but > it would work. This is still an unanswered question. I wanted to special-case FindWindow so we get efficiency but I think Alexandre didn't like that, so I guess we have to always start it. Alexandre? > In the result it will look like this: > If there is no explorer application, the icons will show up in the > Linux systray. If there is an Explorer running, they will show up > _both_ in Linux' and Explorer's systray. That sounds OK thanks -mike

3 2

multiple constant definitions
by Warren Turkal 31 Mar '04

31 Mar '04

wt@braindead:~/src/wine/wine/include$ grep -ri 'c0000005' * ntstatus.h:#define STATUS_ACCESS_VIOLATION 0xC0000005 winnt.h:#define STATUS_ACCESS_VIOLATION 0xC0000005 I found this while searching for the cause of Empire Earth to not work. These are defined in multiple places. Would it not be better to just include ntstatus.h in winnt.h? wt -- Warren Turkal President, GOLUM, Inc. http://www.golum.org

4 4

'unicode' usage in x11drv/window.c (X11DRV_CreateWindow)
by pvriens＠xs4all.nl 31 Mar '04

31 Mar '04

Hi, while going through some of the code I saw that in the above mentioned function we sometimes do a SendMessage(A/W) depending on the setting of the unicode parameter. In the same function we do 3 SendMessageW's without checking unicode. Is this correct or is this not harmful ? Cheers, Paul Vriens.

2 1

Re: bounced patch
by Ivan Leo Murray-Smith 31 Mar '04

31 Mar '04

> It's a new file, how do I diff againt cvs if the file isn't in cvs ? You can diff a file even if it isn't in the CVS. Just run diff -urN wine/ new/ > patch.diff where wine is the current cvs code and new is the source tree with all the changes you've made. You can avoid duplicating the whole tree by only diffident a file or directory, for example diff -urN wine/dlls/opengl new/dlls/opengl > patch.diff in this case, the "new" directory only has to contain the dlls/opengl directory. > I thought maybe I should have set 2600 to just 26 ?? No, keep it at 2600. BTW the win2k3 build number is 3790, as it's the latest Microsoft release you may want to use that one instead. Ivan.

2 1

Re: bounced patch
by Ivan Leo Murray-Smith 31 Mar '04

31 Mar '04

> May I ask why this bounced ? Maybe because it isn't a diff file? Ivan.

2 1

bounced patch
by Tom 31 Mar '04

31 Mar '04

Hello, May I ask why this bounced ? http://www.winehq.org/hypermail/wine-patches/2004/03/0365.html Tom

1 0

Re: [kernel/user32] Some Specs
by Jonathan Wilson 31 Mar '04

31 Mar '04

BTW, implementations for WCSToMBEx and MBToWCSEx can be found here: http://article.gmane.org/gmane.comp.emulators.wine.patches/5049/ I dont have a usable setup to turn them into proper patches but if anyone wants to use them for WINE, go ahead and grab them. Not sure how usefull they would be but I suspect that they may bring WINE closer to the point where native WINIMM.DLL works.

1 0

filesystem changes break autofs patch
by Guido Draheim 31 Mar '04

31 Mar '04

To whoever is working on filesystem - let me remind you again (and again) that bsd autofs mountpoints do not exist until accessed - and they will not get created for removable media devices without a medium inserted, not even upon access / stat. Therefore, mapping "a:" to autofs'd "/vol/floppy" will not work in wine - any mapping to nonexistant mountpoint had been silently dropped in the past and btw one can not create a symlink to nonexistant point that easily. The unpatched wine has been unusable for autofs for a long time. I have been creating patches for a few years now integrating an option to ini file / registry but they were silently ignored. It is good if you are working again on the filesystem setup but please do not ignore autofs bsd-type automounter system! My patches do not work anymore, so I can not update to the lastest wine. I'll try to be patient and looking forward to your changes. -- guido http://google.de/search?q=guidod GCS/E/S/P C++/++++$ ULHS L++w- N++@ s+:a d(+-) r+@>+++ y++

1 0

RE: Handling dialogs created without using templates
by Santosh Siddheshwar 31 Mar '04

31 Mar '04

Hi, Do you have a solution to this issue? If yes, are you planning to introduce it soon? Thanks in advance. Regards Santosh Siddheshwar > -----Original Message----- > From: Dmitry Timoshkov [SMTP:dmitry@baikal.ru] > Sent: Tuesday, March 30, 2004 7:40 PM > To: Santosh Siddheshwar > Cc: wine-devel(a)winehq.com > Subject: Re: Handling dialogs created without using templates > > "Santosh Siddheshwar" <santosh.s(a)sonata-software.com> wrote: > > > Yes attached is a sample which is pretty similar to what I described > > below. > > Thanks. Now I see where the problem is. We have to hook dialog creation > code into common window creation code, something similar to what I've done > recently for MDI. Alexandre, are my thoughts correct? > > -- > Dmitry. ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

problem w/winebuild and '@' in names
by Jon Griffiths 31 Mar '04

31 Mar '04

Hi, winebuild doesn't support export names with an '@' correctly. When parsing the spec file, the @X is stripped. This causes names to be incorrectly listed as duplicates. I'm hitting this with mapi32.dll. Outlook 97 imports using get procaddress on the name including the '@', and some exports are given both with and without the '@' decoration. I'm working around this for mapi32 by commenting out remove_stdcall_decoration( odp->name ); at line 463 of parser.c. Is this a known problem, and is that the right solution? Cheers, Jon ===== "Don't wait for the seas to part, or messiahs to come; Don't you sit around and waste this chance..." - Live jon_p_griffiths(a)yahoo.com __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

4 4

Re: ALSA: Allow configuration of output devices to use and change standard output plugin requested to "default"
by felix.nawothnig＠t-online.de 30 Mar '04

30 Mar '04

On 03/26/2004 04:56:00 PM, Mike Hearn wrote: in ALSA_WaveInit(): > + wwo->device = ALSA_GetDeviceFromReg("PlaybackDevice"); in wodClose(): > + HeapFree(GetProcessHeap(), 0, wwo->device); and in widClose(): > + HeapFree(GetProcessHeap(), 0, wwi->device); Thats wrong. wods and wids can be reopened, ALSA_WaveInit is only called once. Caused... ALSA lib pcm.c:1906:(snd_pcm_open_noupdate) Unknown PCM 8ú<@ err:wave:wodOpen Error open: Success ALSA lib pcm.c:1906:(snd_pcm_open_noupdate) Unknown PCM 8ú<@ err:wave:wodOpen Error open: Inappropriate ioctl for device ...when my app. Commenting out the HeapFree()s fixes it. (I dunno where to put the HeapFree()s... but that's definitly the wrong place :)

2 1

Re: [LostWages] make winehq.org HTML 4.01 Transitional + XHTML 1.0 Transitional Valid
by Brian Vincent 30 Mar '04

30 Mar '04

> Dimi, I still don't get you, what you are saying is: > changing class=todo to class=done is considerably easier then > changing class="todo" to class="done" Rule #1: whoever is willing to do the thankless job of maintaining pages on the web site gets to tell anyone else how they'd like the formatting to be. Since this issue has directly affected me in the past I will point out a real argument for making this stuff compliant: If I copy and paste the HTML into a WWN it would be nice if I didn't have to do a ton of markup to make it well-formed. In fact, I almost never reference anything on WineHQ for that very reason. For example, in issue #143 I went through the markup for the original to-do list and corrected it (which is interesting to look at now, btw). Likewise, it's simple to copy things into the documentation. A good example of which is: http://www.winehq.com/site/status_options Parts of which may end up in the User Guide. But that's just me, and I ain't the one maintaining it. So if Dimi doesn't want it then I guess the best thing to do would be to resubmit with those parts left out. -brian

1 0

Re: [LostWages] make winehq.org HTML 4.01 Transitional + XHTML 1.0 Transitional Valid
by Dimitrie O. Paun 30 Mar '04

30 Mar '04

On Tue, 30 Mar 2004, hatky wrote: > Yes, this time with the patch... > > Change log: > Ofir Petruska <hatky(a)users.sf.net> > Validate the site as HTML 4.01 Transitional + XHTML 1.0 Transitional Valid > (still declaring declaring HTML 4.01 Transitional) > * Case fixes (all html tags should be lower case) > * Quote all attributes > * End empty tags as " />" Jeremy, Please don't apply this patch to the pages I maintain: TODO, Fun Projects, Janitorial, Winelib, Status | Options, Status | Porting As I've tried to explain in the past, these changes are totally unnecessary for manually maintained pages: it makes it harder to maintain, for the benefit of making it easier for the machine to parse. Bad tradeoff, especially given that we maintain these pages daily, and the machine has absolutely no problem parsing them. Thanks. -- Dimi.

2 1

RE: Handling dialogs created without using templates
by Santosh Siddheshwar 30 Mar '04

30 Mar '04

Hi, Yes attached is a sample which is pretty similar to what I described below. Regards Santosh Siddheshwar <<GetParent.zip>> > -----Original Message----- > From: Dmitry Timoshkov [SMTP:dmitry@baikal.ru] > Sent: Tuesday, March 30, 2004 12:51 PM > To: Santosh Siddheshwar > Cc: wine-devel(a)winehq.com > Subject: Re: Handling dialogs created without using templates > > "Santosh Siddheshwar" <santosh.s(a)sonata-software.com> wrote: > > > I have an application that creates dialogs without using any of the > Win32 > > Dialog creation APIs. I find that a lot of the > > functionality in DEFDLG_Proc (DM_SETDEFID, DM_GETDEFID & WM_NEXTDLGCTL) > is > > unavailable for use with > > dialogs created this way. This is because we allocate the DIALOGINFO > > structure only in the dialog creation APIs. Dialogs > > created without using these APIs have NULL DIALOGINFO structure. I also > find > > that allocating this structure and initializing > > the members of the structure will get around this problem. Does anyone > > visualize any problems with this approach? > > Also where would the best place to put such code? > > Do you have a small, self-contained sample code which demonstrates > what you have described? > > -- > Dmitry. ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

Handling dialogs created without using templates
by Santosh Siddheshwar 30 Mar '04

30 Mar '04

Hi, I have an application that creates dialogs without using any of the Win32 Dialog creation APIs. I find that a lot of the functionality in DEFDLG_Proc (DM_SETDEFID, DM_GETDEFID & WM_NEXTDLGCTL) is unavailable for use with dialogs created this way. This is because we allocate the DIALOGINFO structure only in the dialog creation APIs. Dialogs created without using these APIs have NULL DIALOGINFO structure. I also find that allocating this structure and initializing the members of the structure will get around this problem. Does anyone visualize any problems with this approach? Also where would the best place to put such code? Regards Santosh Siddheshwar ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

Re: [LostWages] make winehq.org HTML 4.01 Transitional + XHTML 1.0 Transitional Valid
by Maxime Bellengé 30 Mar '04

30 Mar '04

Hello, I think you forgot the patch On Tue, 2004-03-30 at 00:08, hatky wrote: > Change log: > Ofir Petruska <hatky(a)users.sf.net> > Validate the site as HTML 4.01 Transitional + XHTML 1.0 Transitional Valid > (still declaring declaring HTML 4.01 Transitional) > * Case fixes (all html tags should be lower case) > * Quote all attributes > * End empty tags as " />" -- Maxime Bellengé <maxime.bellenge(a)laposte.net>

2 1

Re: systray in desktop mode [unified resend]
by Mike Hearn 30 Mar '04

30 Mar '04

On Mon, 2004-03-29 at 22:19, Martin Fuchs wrote: > Then I don't see how you want to be able to handle shell applications > like Explorer and enable the systray icons in them. Explorer isn't really a useful app to run for us, so if systray handling doesn't work quite right for it we won't be losing sleep over it. However, we do want native shell32 to work, so it'll be using the same protocol. > Well, let's see how far Mike's upcoming rewritten systray can handle this. > I may have a look in the new code, and see if I it's possible to do it > without knowing about the desktop mode. Getting explorer/systray to work in Wine may not be easy, however ReactOS and Wine should be able to share the same shell32 which I think is the idea, yes?

2 1

kernel32 test failures under Cygwin
by Dmitry Timoshkov 30 Mar '04

30 Mar '04

Hello all, today I decided to play a bit with Wine compilation under Cygwin. This time I decided to run kernel32 tests as well. I've got the following failures: generated.c:542: Test failed: TYPE_ALIGNMENT(*(LPWIN32_STREAM_ID)0) == 8 (expected 4) generated: 842 tests executed, 0 marked as todo, 1 failure. * NOTE: the same test compiled by cl.exe (MS compiler) works as expected, * so that's most likely a gcc bug. (gcc version 3.3.1 (cygming special)) pipe: 5614 tests executed, 0 marked as todo, 4869 failures. * NOTE: the same test compiled by cl.exe hangs forever at: * pipe.c:285:Server done writing. process: 373 tests executed, 0 marked as todo, 97 failures * NOTE: the same test compiled by cl.exe gives different result: * process: 376 tests executed, 0 marked as todo, 10 failures. Since this is a fresh Cygwin install made from scratch I'd blame this particular Cygwin distribution. Cygwin1.dll marked as "1.5.7-cr-0x9e" in its version resources. Could anybody else with a relatively fresh Cygwin or MinGW installation try it and report the result? P.S. I have one more bug in Cygwin: it can't correctly handle makefiles. So 'make' for some reason doesn't want to call 'dlltool' to produce a .def file in dlls/d3d9 after it did run it in dlls/d3d8. Changing order of d3d9 and d3d8 in dlls/Makefile,SUBDIRS exchanges failure dirs. Manually chdir'ing to dlls/d3d9 and running 'make' there does help. An old Cygwin (1.3.17) from a backup does not have that nasty bug. -- Dmitry.

3 2

Re: [LostWages] make winehq.org HTML 4.01 Transitional + XHTML 1.0 Transitional Valid
by Vincent Béron 30 Mar '04

30 Mar '04

Le lun 29/03/2004 à 17:08, hatky a écrit : > Change log: > Ofir Petruska <hatky(a)users.sf.net> > Validate the site as HTML 4.01 Transitional + XHTML 1.0 Transitional Valid > (still declaring declaring HTML 4.01 Transitional) > * Case fixes (all html tags should be lower case) > * Quote all attributes > * End empty tags as " />" Would be better with the patch... Vincent

1 0

Re: [dx101] extensions fixes
by Vincent Béron 30 Mar '04

30 Mar '04

Le lun 29/03/2004 à 18:57, Raphael a écrit : > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi all, > > Changelog: > - more Extensions work (begin to detect ATI extensions) > - try to fix D3DTADDRESS_BORDER, D3DTADDRESS_MIRROR, D3DTADDRESS_MIRRORONCE > using OpenGL extensions > - better set_tex_op: now use Runtime Extension support (and not compile > support) Would be better with the patch... Vincent

1 0

Re: systray in desktop mode [unified resend]
by Mike Hearn 29 Mar '04

29 Mar '04

On Sat, 27 Mar 2004 15:17:20 +0100, Martin Fuchs wrote: > Changelog: > SHELL_NotifyIcon() implementation for Wine's desktop mode I'm not sure it makes any sense to do this: the system tray code is on my hit list for things to rewrite. It's already been mostly done, the work remaining is moving the code into a separate process then using the messages to poke wineshell. System tray in desktop mode is tricky anyway because we have no explorer/shell program - so where do they get put? thanks -mikek

3 3

resource information
by Ivan Leo Murray-Smith 29 Mar '04

29 Mar '04

When adding resource information to a wine file, what version should I use? the version string of winxp, win2k3, make it up? Ivan.

1 0

Re: Re: fix crash in winecfg's x11 dialog due to invalid "Desktop" settings
by Mike Hearn 29 Mar '04

29 Mar '04

On Mon, 29 Mar 2004 10:11:56 -0500, chmorgan wrote: > Yes, my bad. I'll send in a fixed patch. I still don't like the way the code > looks with the duplication of the default string to use but I couldn't > think of any way to fix it more elegantly. Ideas? Why not just have static char *desktop_default = "640x480" at the top of the function?

1 0

Source code visualization tools?
by Joel Konkle-Parker 29 Mar '04

29 Mar '04

Is there such a thing as a source code visualization tool that makes a "map" of a program's source? Kind of like: main() | | function1() /\ / \ func2() func3() | | func4() I'm basically looking for something that will help me "see" how a program is laid out so that I can start working on it. Thanks in advance. -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

3 3

Re: Re: fix crash in winecfg's x11 dialog due to invalid "Desktop" settings
by chmorgan＠charter.net 29 Mar '04

29 Mar '04

Yes, my bad. I'll send in a fixed patch. I still don't like the way the code looks with the duplication of the default string to use but I couldn't think of any way to fix it more elegantly. Ideas? Chris > > From: Mike Hearn <mh(a)codeweavers.com> > Date: 2004/03/29 Mon AM 06:07:03 EST > To: wine-patches(a)winehq.com > Subject: Re: fix crash in winecfg's x11 dialog due to invalid "Desktop" settings > > On Sun, 28 Mar 2004 13:31:15 -0500, Chris Morgan wrote: > > + if(!bufindex) /* handle invalid "Desktop" values */ > > + { > > + buf = strdup("640x480"); > > + bufindex = strchr(buf, 'x'); > > + } > > It's not a big deal but there's a memory leak there, you need to free buf > before strduping the default (which ideally should be a const str at the > top of the function so if/when we change the default it's only done in one > place). > > thanks -mike > > > >

1 0

Re: Re:bugzilla doesn't find bug
by brettholcomb＠charter.net 29 Mar '04

29 Mar '04

I'll try again. On other bugzilla systems I've used the status doesn't make a difference but maybe they default to different selections so I get all the bugs irregardless of status. Thanks. > > From: tony_lambregts(a)telusplanet.net > Date: 2004/03/29 Mon AM 06:45:51 GMT > To: wine-devel(a)winehq.org > CC: brettholcomb(a)charter.net > Subject: Re:bugzilla doesn't find bug > > Brett I. Holcomb wrote > > > If I tell bugzilla to find bugs with winealsa in the summary it does not > > find any at all. However, there is at least one bug - 2035 - with > > winealsa as the first word even! I think bugzilla's broken! > > Works for me. The problem probably that the default selection has unconfirmed > unselected. The one bug that has winealsa as the first word in the summary is > unconfirmed. When I look for winealsa in the comments for all status types I get > 11 bugs listed. > > -- > > Tony lambregts > >

1 0

Re: controls/scroll.c
by Dmitry Timoshkov 29 Mar '04

29 Mar '04

"Ge van Geldorp" <gvg(a)reactos.com> wrote: > Changelog: > Ge van Geldorp <gvg(a)reactos.com> > Remove CS_DBLCKS class style from scrollbar class since the > scrollbar doesn't handle double clicks anyway You can't remove it. Scrollbar in Windows has that style, and some applications which subclass it may depend on it. -- Dmitry.

2 4

Re: design problems with thread init code?
by Paul Davis 29 Mar '04

29 Mar '04

mike already fixed a bunch of my misunderstandings on IRC. but now i'm faced with the more challenging task of getting this "mono hack" to support threading properly. so feedback is still welcome :) --p

3 4

Re:bugzilla doesn't find bug
by tony_lambregts＠telusplanet.net 29 Mar '04

29 Mar '04

Brett I. Holcomb wrote > If I tell bugzilla to find bugs with winealsa in the summary it does not > find any at all. However, there is at least one bug - 2035 - with > winealsa as the first word even! I think bugzilla's broken! Works for me. The problem probably that the default selection has unconfirmed unselected. The one bug that has winealsa as the first word in the summary is unconfirmed. When I look for winealsa in the comments for all status types I get 11 bugs listed. -- Tony lambregts

1 0

Progress on msvcp60.dll?
by Joel Konkle-Parker 29 Mar '04

29 Mar '04

Is there any work at all on msvcp60.dll? I haven't seen much mention of it on the lists, and it's not listed on the dll status page. I've found at least one (and heard of more) that require this dll outright, though. Thoughts? -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

2 1

design problems with thread init code?
by Paul Davis 29 Mar '04

29 Mar '04

hello. i'm the main author of Ardour and JACK, projects those of you with audio/music leanings may be aware of. i'm in the middle of trying to add "native" windows/x86 VST plugin support to these systems, and i ran into some problems. #winehackers suggested to write this list. we are using a modified version of the Mono hack that allows use of winelib as a shared library. i got things working very well until i tried to use a VST plugin that appears to call RtlCreateUserThread. in tracking down why it wouldn't work, i discovered that server_init_thread() is called from the NT DLL for 2 reasons: 1) to initialize the first thread in a winelib-supported program 2) to initialize all later threads there appear to be some problems caused by this. server_init_thread() makes a rather basic assumption: the thread making the request is the target of the request. this is true for case (1) but not for case(2). in case (2), AFAICT, all (most?) instances of "current" need to be replaced by a struct thread* that points to the newly created (but not yet running) thread that is being initialized. it wouldn't suprise me if i have misunderstood things here, but i was able to fix the first problem i encountered (a complaint that the new thread was already running) by adding a kludgy hack based on my understanding. the next problem emerges because the new thread doesn't get its reply/wait fd's set up (instead, the operation is done on "current"). comments? thanks. --p

1 0

Re: Dos INT's
by Dmitry Timoshkov 29 Mar '04

29 Mar '04

"Florian Goth" <Captainsifff(a)gmx.de> wrote: > Added some more stubs. Could you resend the patch without white space changes and with only really added code in it? -- Dmitry.

1 0

Re: Remove references to winecheck from the documentation
by Andreas Mohr 29 Mar '04

29 Mar '04

Hi, On Sun, Mar 28, 2004 at 02:01:28PM -0500, Chris Morgan wrote: > * documentation/bugs.sgml, configuring.sgml > Chris Morgan <cmorgan(a)alum.wpi.edu> > Remove references to winecheck from the documentation and insert a TODO that > mentions that the functionality is to be moved into winecfg. > > Alexandre, are we all set to put winecheck into the attic? Yup, provided that there WILL be a suitable replacement tab in winecfg. So, any holy promises, anyone? ;-) Andreas Mohr

2 1

bugzilla doesn't find bug
by Brett I. Holcomb 28 Mar '04

28 Mar '04

If I tell bugzilla to find bugs with winealsa in the summary it does not find any at all. However, there is at least one bug - 2035 - with winealsa as the first word even! I think bugzilla's broken!

1 0

Problem with installing ZooTycoon (demo version)
by pvriens＠xs4all.nl 28 Mar '04

28 Mar '04

Hi, I've been trying to get the installation of ZooTycoon (demo downloadable from M$) to work. The installation stops at about 25% during the copying of files, right at the time a new background picture should be shown. I have some questions now (with some accompanying text): ZooTycoon creates a lot of windows that are all owned by the main thread (0x0009 in my case). Several messages are posted to several windows in several threads. Because the messages are send to a hwnd and all windows are owned by 0x0009, all messages end up in the message queue of the main thread. If a GetMessage or PeekMessage is done in the main thread everything is fine. When however a GetMessage or PeekMessage is done with a hwnd=0 (NULL) it all depends in which thread the Get or PeekMessage is done, if one (or more) message is retrieved. In my case all Get or PeekMessages done in all other threads but the main one (0x0009) end up with nothing (always PENDING status) It appears that on Windows the behaviour is different, in the ZooTycoon case, all GetMessages are done from the main thread (as seen by strace on Win2KProf). Maybe there is some logic that checks which thread own windows ? Can somebody confirm my findings for the WINE part ? And of course can somebody confirm my findings for the WINDOWS part ? It looks like I found the cause of my problem, now the fix ! If more info is needed, please let me know. cheers, Paul Vriens.

2 2

Re: cards.dll
by Steven Edwards 28 Mar '04

28 Mar '04

--- Sam <xasmx(a)optonline.net> wrote: > This is a clean room implementation of cards.dll. > While it is not really an official windows system dll, > it is almost always present, and several applications > depend on it. We have a cards.dll in the ReactOS tree that we wanted to merge with Winehq but the license of the bitmaps was GPL and not LGPL. Do you want to take a look at our implementation and see if there is anything you can use from it? http://cvs.reactos.com Thanks Steven __________________________________ Do you Yahoo!? Yahoo! Mail - More reliable, more storage, less spam http://mail.yahoo.com

13 18

Re: [Controls] Add tracing to the edit control.
by Dimitrie O. Paun 28 Mar '04

28 Mar '04

On March 28, 2004 5:22 am, Lionel Ulmer wrote: > +static const char *EditWndProc_dump_msg_name(UINT msg) That's a nice effort, but this is real long name... What about dbgstr_msg()? Also, this is a real useful function, I think we should have a standard dbgstr_msg() function that knows about all standard messages. -- Dimi.

2 3

Cards.dll improvements
by Sam 28 Mar '04

28 Mar '04

> On Sat, 27 Mar 2004 14:22:44 -0500, Sam wrote: > > This patch implements invisibleghost, deckx and decko > > drawing modes, and improves ghost drawing mode. > > It also includes graphics needed by these drawing modes. > > Hi, I'm sure you're doing the right thing but given the number of dodgy > attempts we've had at this DLL could you please state where you're getting > the artwork from? If you have already said this please forgive me, I don't > read everything on wine-devel :) Hi, for the artwork sent earlier, I already mentioned the source: http://www.jfitz.com/cards/index.html. For the three card images sent in the latest patch, I made them. > thanks -mike Regards, Sami Nopanen, xasmx(a)optonline.net

1 0

[Fwd: i810 audio fixes 1/2]
by Robert Reif 28 Mar '04

28 Mar '04

sorry, forgot to reply all.

2 4

Re: [Fwd: i810 audio fixes 1/2]
by Ivan Leo Murray-Smith 28 Mar '04

28 Mar '04

> Argh, this is confusing. How do you know what the next generation > of Windows (longhorn?!) will do in this regard, has it been published > anywhere? Yes, first longhorn, after that, blackcomb. You can ask Microsoft for a License, from the http://www.windowsbeta.microsoft.com web site You can also get it few with a MSDN universal subscription, that costs various thousands of dollars a year. lots of info about it at http://www.msdn.com/longhorn/ Ivan.

1 0

WINE on bug isolation monitor
by Charlie Lopez 28 Mar '04

28 Mar '04

Good Afternoon, I will like to congratulate you on such a fine job with WINE. I love this program. I was just able to run quicktime on my RH9 machine!!! I wanted to bring to your attention a idea I had. I installed on my machine a Bug Isolation Monitor by Berkeley University (http://www.cs.berkeley.edu/~liblit/sampler/learn-more/). Currently it tracks all bugs and errors with Ximian Evolution, GAIM Gnumeric, Nautilus and Rhythmbox. I though that perhaps WINE could get some kind of update software which will automatically send application feedback to your server. I will be willing to test this feature. Let me know what you think. Regards, Juan Lopez WebIT @email The information being send thru this e-mail is intended only for the person, persons and/or group/entity to which it is addressed to and may contain confidential and/or privileged content. Any retransmission, review, propagation or other use of this information by people or entities other than the intended recipient or recipients is prohibited and may be unlawful. If you received this email in error, please contact the sender and delete the email from any computer in which it was received.

2 1

Re: unicodify CreateMetaFile
by Dmitry Timoshkov 28 Mar '04

28 Mar '04

"Mike McCormack" <mike(a)codeweavers.com> wrote: > -HDC WINAPI CreateMetaFileW(LPCWSTR filename) > +HDC WINAPI CreateMetaFileA(LPCSTR filename) > { > - LPSTR filenameA; > + LPWSTR filenameW; > DWORD len; > HDC hReturnDC; > > - if (!filename) return CreateMetaFileA(NULL); > + if (!filename) return CreateMetaFileW(NULL); > > - len = WideCharToMultiByte( CP_ACP, 0, filename, -1, NULL, 0, NULL, NULL ); > - filenameA = HeapAlloc( GetProcessHeap(), 0, len ); > - WideCharToMultiByte( CP_ACP, 0, filename, -1, filenameA, len, NULL, NULL ); > + len = MultiByteToWideChar( CP_ACP, 0, filename, -1, NULL, 0 ); > + filenameW = HeapAlloc( GetProcessHeap(), 0, len ); > + MultiByteToWideChar( CP_ACP, 0, filename, -1, filenameW, len ); MultiByteToWideChar returns number of characters, not bytes. You have to allocate len * sizeof(WCHAR) bytes. -- Dmitry.

1 0

Appdb - Vendor list for user and vendor matching for admin
by Chris Morgan 28 Mar '04

28 Mar '04

This look alright? I'm still trying to learn php ;-) account.php, appsubmit.php, admin/adminAppQueue.php Chris Morgan <cmorgan(a)alum.wpi.edu> Add a dropdown list of vendors to the app submit page. Automatch the dropdown vendor selection on the admin side of there is an exact or partial name match. Clear out the vendor field if a match is found. Display username when logging in to the db. Chris

1 1

CVS release of wine's Bugzilla?
by tony_lambregts＠telusplanet.net 28 Mar '04

28 Mar '04

Judging from the success of releasing the source for the main website and the AppDB, I propose that we also release the source for our bugzilla database via CVS. -- Tony Lambregts

1 0

winetests.exe
by Jakob Eriksson 28 Mar '04

28 Mar '04

Mostly for fun I compiled another winetests.exe from Wine CVS 2004-03-28. http://vmlinux.org/jakov/Wine/ http://vmlinux.org/jakov/Wine/regrtest.exe I am unpatiently waiting for the Windows Testing Service, but wanted to see how the tests have developed since January. :-) Try it out in Windows, not quite so many tests are failing. (Some tests are not included at all though.) -- regards, Jakob

1 0

Game Testing Update Wine-20040309
by Mike Kost 27 Mar '04

27 Mar '04

I took a break for 20040213, but here's the latest edition of my testing efforts. Same rules still apply in my selection efforts: All games tested are freely available as demos or F/OSS games on the Internet and they don't work right. Since my last report: - Bugzilla bug #2011 on Austerlitz was closed - 2 patches were generated by Jason Edmeades - 3 Bugs Filed - - #2056 - Dominions II Demo Does Not Do Full Screen Correctly - - #2128 - Remote Assault Demo Fails To Run - - #2129 - Austerlitz Demo Generates Unhandled Exception Austerlitz Summary ------------------ http://www.breakawaygames.com/downloads/austerlitz_demo.exe With Jason's patches for bug #2011, Austerlitz runs but has revealed more bugs. There's a screen drawing/refresh error and it's possible to cause an unhandled exception. Full report here: http://www.tashcorp.net/Wine/Austerlitz/austerlitz-20040309.html Dominions II Summary -------------------- http://www.shrapnelgames.com/downloads/dominions2demo_install.exe Dominions II still has problems with full-screen mode where the KDE kicker bar is visible over the game and the mouse insistently returns to to the center of the screen when moved. Full report here: http://www.tashcorp.net/Wine/DominionsII/dominionsII-20040309.html Remote Assault Summary ---------------------- http://www.shrapnelgames.com/downloads/rad50.exe Remote Assault fails to run. I believe this is a downgrade of it's previous position. I owe a +loaddll,+relay log to the bug report. Full report here: http://www.tashcorp.net/Wine/RemoteAssault/remoteassault-20040309.html The War Engine Summary ---------------------- http://www.shrapnelgames.com/downloads/TWEDemo.exe It hangs on execution and I havn't figured out where to start filing bugs. Hopefully I'll figure out something better to do with when the next version of Wine is released. Mike K

3 3

Re: wine/ server/trace.c server/request.h server/p ...
by Dimitrie O. Paun 27 Mar '04

27 Mar '04

On March 26, 2004 8:48 pm, Alexandre Julliard wrote: > Use futimes() instead of utime() to implement SetFileTime, so that > it can be done on the client side. + if (atime) + { + sec = ((ULONGLONG)atime->dwHighDateTime << 32) | atime->dwLowDateTime; + sec = RtlLargeIntegerDivide( sec, 10000000, &nsec ); + tv[0].tv_sec = sec - SECS_1601_TO_1970; + tv[0].tv_usec = (UINT)nsec / 10; + } + if (mtime) + { + sec = ((ULONGLONG)mtime->dwHighDateTime << 32) | mtime->dwLowDateTime; + sec = RtlLargeIntegerDivide( sec, 10000000, &nsec ); + tv[0].tv_sec = sec - SECS_1601_TO_1970; + tv[0].tv_usec = (UINT)nsec / 10; + } ^^^^^ Shouldn't these be tv[1]? -- Dimi.

1 0

test - ignore
by hatky 27 Mar '04

27 Mar '04

-- Hatky, Worshiper of wine (http://www.winehq.org/), Impossible is only an opinion.

1 0

test - ignore
by hatky 27 Mar '04

27 Mar '04

-- Hatky, Worshiper of wine (http://www.winehq.org/), Impossible is only an opinion.

1 0

Re: shell32 patch 26
by Alexandre Julliard 27 Mar '04

27 Mar '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > /* process the IDList */ > - if ((sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) == SEE_MASK_INVOKEIDLIST) /*0x0c*/ > + if (sei_tmp.fMask & SEE_MASK_INVOKEIDLIST) /* 0x0c: includes SEE_MASK_IDLIST */ If you only care about the MASK_IDLIST flag you should check just that flag, otherwise the test is confusing since the 0x08 flag doesn't mean anything by itself. -- Alexandre Julliard julliard(a)winehq.org

2 1

Using Unix path names
by Duane Clark 26 Mar '04

26 Mar '04

After yesterdays CVS commits, I can no longer execute programs using a Unix path. > wine /c/Program\ Files/WinZip/WINZIP32 wine: cannot find '/c/Program Files/WinZip/WINZIP32' It has nothing to do with the space, either. > wine /c/downloads/xlViewer.exe wine: cannot find '/c/downloads/xlViewer.exe' It seems only dos paths work now. Is this a deliberate change, or is there some configuration change I missed?

2 1

RE:lostwages/ ./winehq_styles.css templates/en/fu ...
by tony_lambregts＠telusplanet.net 26 Mar '04

26 Mar '04

This cvs commit screwed up Vincent Béron's name on lostwages/templates/en/todo_lists.template ( http://www.winehq.org/site/todo_lists ) http://www.winehq.org/hypermail/wine-cvs/2004/03/0411.html I cannot submit a patch for this right now so if someone wants to fix it... -- Tony Lambregts

1 0

Call for kernel patch testing
by Mike Hearn 26 Mar '04

26 Mar '04

Hi guys, As part of the ongoing efforts to work nicely with execshield/prelink, the following kernel patch was developed (not by me I hasten to add): http://www.bitwagon.com/elfdiet/elfdiet.html However it needs testing so the kernel guys can be sure it'll not break stuff. If you are the type who runs their own kernel, please apply this patch and let us know the results! Everything should be fine, it's just a bugfix for the edge cases, but the elf loader is security critical so it needs widespread usage before it can be upstreamed. This was a public service announcement. thanks -mike

1 0

Get{Full|Long}PathNameA doesn't seems to be working
by Felipe W Damasio (Elipse Software) 26 Mar '04

26 Mar '04

Greetings wine hackers, Our company used wine-20030115 for a while now, to be able to run our windows product on top of the GNU/Linux OS. But since we updated to the latest wine (ie wine-20040309), our path conversion is wrong. The relevant bit of our .config looks as follows: [Drive F] "Path" = "%HOME%" "Type" = "network" Which was automatically generated by wineinstall, btw. Anyway, we used to use GetLongPathNameA to get the unix to window name conversion right (which was inspired by the winepath program). But in this latest version, GetLongPathNameA was replaced by GetFullPathNameA (in winepath)..but neither seems to work right. Please consider the attached code as an example. It retrieves the home directory of the current user, and tries to look up the windows version of it. In my case, I got: Unix format Home Directory: /home/felipewd GetFullPathNameA returned: F:\home\felipewd GetLongPathNameA returned: And the expected return was "F:\" in the windows version (GetLongPathNameA didn't even returned an entry)...am I right? So, if there's any more tests you'd like me to do, or if there's anything I can do to help fixing this, please let me know. Cheers, Felipe

2 2

Re: shell32 patch 24
by Dimitrie O. Paun 26 Mar '04

26 Mar '04

On Thu, 25 Mar 2004, Martin Fuchs wrote: > OK, now the patch including the "return S_FALSE". :-) This is why small patches are better than large ones :) -- Dimi.

3 2

Re: renewed: wine/dlls/d3d8/device.c cleanup-3
by Raphael 26 Mar '04

26 Mar '04

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi On Thursday 25 March 2004 21:47, hatky wrote: > Generate ERRs for implementations that exists only > with OpenGL extentions or versions that were not found > at compile time, other wise is is presnted as just > unimplemented > > > ChangeLog: > Â Â Ofir Petruska <hatky(a)users.sf.net> > Errs for implemented with an unavailable OpenGL ver > #else >- case D3DTADDRESS_MIRROR: /* Unsupported in OpenGL pre-1.4 > > */ >+ case D3DTADDRESS_MIRROR: ERR("Implemented with GL1.4 or an ARB >extention only\n"); /* Unsupported in OpenGL pre-1.4 */ > #endif Why you want to put an ERR here ? for me it should be a WARN but only for debug purpose. D3D games normally only use what we declare to support (using GetDeviceCaps) so i we say not supported ... #if defined(GL_VERSION_1_3) pCaps->TextureAddressCaps |= D3DPTADDRESSCAPS_MIRROR; #endif > +#else > + ERR("Implemented only with GL_EXT_paletted_texture defined\n"); > #endif Well, paletted textures are not supported by many cards and i don't think users will like scrolling of non-errors traces in some games (it can be a warning for devs but not an error). On windows you can call SetCurrentTexturePalette if you card don't support it (the function should return with an error) >+#else >+ ERR("Ipmlemented only for OpenGL 1.3 and up\n"); > #endi Here it should be a FIXME. It must be implemented using GLXPixmaps for olders GLX versions (see the function comment) Regards, Raphael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAY3qOp7NA3AmQTU4RAjQ0AJwNuhHeXKxnkDQ8I/7mn+ZyKdI13wCePyGt 7sS7J/45W6nMbG3CFD5jWfE= =QazV -----END PGP SIGNATURE-----

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky 25 Mar '04

25 Mar '04

>Also it would be really nice to sort the dlls >alphabetically as there >is quite many of them. Sent patch to remove non win api. It already sorts by module name. -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/), Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

WineHQ: Of </quote> and punctuations
by Francois Gouget 25 Mar '04

25 Mar '04

Ok, there's a problem with </quote> and punctuations. For instance in WWN 171 we have (see the 'Wine Tech Meeting' section): --- cut here --- mentioned ReactOS had one. He went on to discuss some future plans, My goal if the ReactOS guys can get more than winhello working is to have WINEs shell32 and comctl32 running for Linux world . All in all the meeting was quite successful and a lot of people were glad to be able to converse in real time about a lot of --- cut here --- See how we have a '.' all alone on a line? Check there for the original: http://www.winehq.org/?issue=171#Wine%20Tech%20Meeting The reason why we have this unsightly sight is that on the WineHQ web site '<quote>' creates a new indented paragraph so that any punctuation that follows '</quote>' ends up being on the next line, either all alone or just before the next sentence which is just as strange (see WWN 177 for an example). It's interesting to note that this problem does not occur in the Wine Kernel Cousin. That's because in the Kernel Cousin there are both inline quotes and 'standalone' quotes. So in the Kernel Cousin the above is an inline quote which gives us: --- cut here --- dsp2make utility would be a useful addition and Steven mentioned ReactOS had one. He went on to discuss some future plans, " My goal if the ReactOS guys can get more then winhello working is to have WINEs shell32 and comctl32 running for Linux world" . --- cut here --- So there are two ways (at least) to fix the issue: systematically move punctuations to before the </quote> tag (I can send a patch for that), or change the <quote> tag to behave like in the Wine Kernel Cousin. What's the preferred solution? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

2 2

Re: To Do A.11 - Integrate API status into WineHQ
by hatky 25 Mar '04

25 Mar '04

> does the script filter out the Wine-only dlls? Otherwise the global > statistics will be off. No, it dosen't currently: 1. Should we fillter them? a. Totaly b. Just from the Total c. Not at all > > Specifically, the following dlls should be ignored: > > ole2prox ? > ole2thk ? > psapi ? > twain_32 ? > wine* > x11drv > > I'm not sure anymore for the dlls marked with a question mark. I need a final list becouse I don't know what is wine only and what not... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/), Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

2 1

ALSA on i810 audio
by Mike Hearn 25 Mar '04

25 Mar '04

Hi, I'd like to improve the ALSA driver to work properly on my i810 soundcard. At the moment it just gives errors about not being able to resample. Eric - did you have any plans for the driver? Do you know of any problems? I already fixed one thing, the default pcm should be "default" not "hw" thanks -mike

2 1

Re: lostwages/include config.php
by Ferenc Wagner 25 Mar '04

25 Mar '04

Jeremy Newman <jnewman(a)winehq.org> writes: > Log message: > s/Forums/Mailing Lists/ Just two words: Thank You! -- Feri.

2 1

redirecting stdout with WineLib
by Ferenc Wagner 25 Mar '04

25 Mar '04

Hello, Hacking away on winetest I encountered the following problem: under Windows and Wine (running cross compiled binaries) it's possible to redirect the stdout of a child process with CreateProcess using STARTF_USESTDHANDLES. However, if I CreateProcess an .exe.so from the WineLib version, the redirection is ignored. The create_process function in process.c acts on this option in both cases, but I didn't investigate further. Does anybody have an idea why this happens? -- Feri.

5 7

Re: ALSA on i810 audio
by chmorgan＠charter.net 25 Mar '04

25 Mar '04

I've been working to debug one users problem with an i810 card. (n wodOpen() we try to set the format of the audio, 16 or 8bit. I believe the i810 only supports 16bit so we return MMSYS_ERR. I *think* we should be returning WAVERR_BADFORMAT instead so wine can try another format that may work. At least thats what I did with the jack driver for sample rates and formats that don't match the server as the jack server doesn't perform any of that conversion. Perhaps you want to return the same thing in your case? Chris > > From: Mike Hearn <mike(a)navi.cx> > Date: 2004/03/25 Thu PM 03:05:32 EST > To: wine-devel(a)winehq.com > Subject: ALSA on i810 audio > > Hi, > > I'd like to improve the ALSA driver to work properly on my i810 soundcard. > At the moment it just gives errors about not being able to resample. > > Eric - did you have any plans for the driver? Do you know of any problems? > I already fixed one thing, the default pcm should be "default" not "hw" > > thanks -mike > > > >

1 0

Re: Sorry. My first contribution. You can ignore this patch if u will.
by Alexandre Julliard 25 Mar '04

25 Mar '04

Urbez Santana <urbez(a)linuxupc.upc.es> writes: > 1. Make possible instal.lation programs win16 bits working. (Not finished) > *I have changed the protocol to obtain the Teb & the Peb of another process > in kernel32. You don't want to do that. We don't support low-level Win9x dlls anymore. > 2. Make possible all programs of Microsoft Developer Studio works. > *Spy++: works with external windows processes. I have changed the protocol > now to access with ReadProcessMemory to another window process information. This is wrong, it must go through server calls (and it mostly does already), you can't directly access system structures in other processes. > 3. Make possible use shell32.dll.so and shlwapi.dll builtin, and no more use > of native dlls. I need more time, for this, i have great work with shlwapi, > dissassemble and debug with the native dll, and interpret the assembler code > to obtain FDSA functions and another shlwapi functions that needed by HH.EXE You can't base your implementation on disassembled Microsoft code. I'm afraid we can't use your code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Tools] API status - fix module name size
by Ferenc Wagner 25 Mar '04

25 Mar '04

Seems like you forgot the patch. -- Feri.

1 0

Re: [Tools] API status - fix module name size
by Jeremy Newman 25 Mar '04

25 Mar '04

Nothing was attached. Please send the patch. Thanks! On Thu, 2004-03-25 at 06:51, hatky wrote: > Changelog: > Ofir Petruska <hatky(a)users.sf.net>: > Fix the module name cut to 5 chars bug - > Get a MODULE_LENGTH constant and pad Total to it -- Jeremy Newman <jnewman(a)winehq.org>

1 0

Re: NetBios
by Juan Lang 25 Mar '04

25 Mar '04

Flyker wrote: > Does wine NetBios can work with remote windows > application that use NetBios ? In limited circumstances, yes: - it supports only NetBIOS-over-TCPIP (NBT), not nbipx or netbeui - it only supports client sessions: it can't act as a NetBIOS server, nor does it support datagrams --Juan __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Re: Integrating Wine's AppDB with Bugzilla
by hatky 25 Mar '04

25 Mar '04

> I have had over two years to mull this over and this using the URL field is > the easiest solution. this requires the following > > 1. A link to the App from the bug in bugzilla (bug_file_loc (URL) = > http://appdb.winehq.org/appview.php?appId=ID) > > 2. A link to the bugs for the app in the appdb > (http://bugs.winehq.org/buglist.cgi? > product=Wine&bug_file_loc_type=substring&bug_file_loc=....) > > 3. A way to put the link into the bug when it is submitted. > > 4. someone has to link the old bugs (grunt work) > > I would like help to do items 2 and 3 You mean something like this: -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/), Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

2 1

Broken documentation links
by Vincent Béron 25 Mar '04

25 Mar '04

Hi, Rafael Wolf reported to me that the links on http://www.winehq.org/site/documentation for the Wine User Guide in PDF and PostScript format are broken. Vincent

2 1

Re: winetest: run with -mwindows
by Jakob Eriksson 25 Mar '04

25 Mar '04

Hmm... what is the problem with GUI and command line interface. I don't think there should be any particalur problems, what happens? Ferenc Wagner wrote: >Okay, it wasn't true, actually. So, this patch solves the >immediate problem, but is not the full solution. How do you >write a program which has both GUI and CUI? Is there any >way to use standard IO in a program compiled with -mwindows >but run from a console? > >ChangeLog: > Don't expect stdout be usable after exchanging file > descriptors under it. > >Index: main.c >=================================================================== >RCS file: /home/wine/wine/programs/winetest/main.c,v >retrieving revision 1.7 >diff -u -r1.7 main.c >--- main.c 20 Mar 2004 19:21:39 -0000 1.7 >+++ main.c 24 Mar 2004 13:30:26 -0000 >@@ -337,8 +337,6 @@ > SetErrorMode (SEM_FAILCRITICALERRORS); > > if (!(wineloader = getenv("WINELOADER"))) wineloader = "wine"; >- if (setvbuf (stdout, NULL, _IONBF, 0)) >- report (R_FATAL, "Can't unbuffer output."); > > tempdir = tempnam (0, "wct"); > if (!tempdir) >Index: util.c >=================================================================== >RCS file: /home/wine/wine/programs/winetest/util.c,v >retrieving revision 1.4 >diff -u -r1.4 util.c >--- util.c 19 Mar 2004 19:15:23 -0000 1.4 >+++ util.c 24 Mar 2004 13:30:26 -0000 >@@ -19,6 +19,7 @@ > * > */ > #include <windows.h> >+#include <unistd.h> > #include <errno.h> > > #include "winetest.h" >@@ -39,26 +40,14 @@ > return p; > } > >-void xprintf (const char *fmt, ...) >-{ >- va_list ap; >- >- va_start (ap, fmt); >- if (vprintf (fmt, ap) < 0) >- report (R_FATAL, "Can't write logs: %d", errno); >- va_end (ap); >-} >- >-char *vstrmake (size_t *lenp, va_list ap) >+char *vstrfmtmake (size_t *lenp, const char *fmt, va_list ap) > { >- char *fmt; > size_t size = 1000; > char *p, *q; > int n; > > p = malloc (size); > if (!p) return NULL; >- fmt = va_arg (ap, char*); > while (1) { > n = vsnprintf (p, size, fmt, ap); > if (n < 0) size *= 2; /* Windows */ >@@ -75,6 +64,14 @@ > return p; > } > >+char *vstrmake (size_t *lenp, va_list ap) >+{ >+ const char *fmt; >+ >+ fmt = va_arg (ap, const char*); >+ return vstrfmtmake (lenp, fmt, ap); >+} >+ > char *strmake (size_t *lenp, ...) > { > va_list ap; >@@ -85,6 +82,26 @@ > if (!p) report (R_FATAL, "Out of memory."); > va_end (ap); > return p; >+} >+ >+void xprintf (const char *fmt, ...) >+{ >+ va_list ap; >+ size_t size; >+ ssize_t written; >+ char *buffer, *head; >+ >+ va_start (ap, fmt); >+ buffer = vstrfmtmake (&size, fmt, ap); >+ head = buffer; >+ va_end (ap); >+ while ((written = write (1, head, size)) != size) { >+ if (written == -1) >+ report (R_FATAL, "Can't write logs: %d", errno); >+ head += written; >+ size -= written; >+ } >+ free (buffer); > } > > char * > > >

3 5

To Do A.11 - Integrate API status into WineHQ
by hatky 25 Mar '04

25 Mar '04

It looks complicated but it's all 3 mysql commands to get a complete table with whatever data you want from the winapi stats data in a nice table... Take the attached file (it just strips some text) , create user as mysql user that has a db called winapi with CREATE TEMPORARY TABLE and select rights then run: ./tools/winapi/winapi_extract --pseudo-stub-statistics --no-verbose --no-progress >winapi_stats.txt php winapi_stats.php > winapi_stats,dat mysql --execute=' CREATE TEMPORARY TABLE `winapi` ( `module` VARCHAR( 255 ) NOT NULL , `stubs` INT NOT NULL , `total_func` INT NOT NULL , `real_stub` INT NOT NULL , `psedo_stubs` INT NOT NULL , `forwards` INT NOT NULL , PRIMARY KEY ( `module` ) ); LOAD DATA LOCAL INFILE "winapi_stats,dat" REPLACE INTO TABLE winapi FIELDS TERMINATED BY "~" LINES TERMINATED BY "\n"; SELECT "Total" "Library", sum(total_func) "API Count", (sum(total_func) - sum(stubs)) / sum(total_func) *100 "% implemented", sum(stubs) "Total Stubs", sum(real_stub), sum(psedo_stubs) FROM winapi UNION ALL SELECT module "Library", total_func "API Count", ( total_func - stubs ) / total_func *100 "% implemented", stubs "Total Stubs", real_stub, psedo_stubs FROM winapi; ' -u user -D winapi -H >/lostwages/templates/en/winapi_stats.html comments? p.s. sorry for the yahoo and the linewrap mess my mail dosn't send latly... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/), Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

4 3

[PATCH] Small (visual) issue in generating html documentation
by pvriens＠xs4all.nl 25 Mar '04

25 Mar '04

Hi, Just a small contribution. Hey, have to start somewhere. When doing a 'make htmlpages' the resulting index.html has no ',' between Q and R for the Index pages. Attached path should fix that. Cheers, Paul

1 0

NetBios
by flyker 25 Mar '04

25 Mar '04

Does wine NetBios can work with remote windows application that use NetBios ?

1 0

Re: shell32 patch 24
by Alexandre Julliard 25 Mar '04

25 Mar '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > + if (This->bDirty) > + return S_OK; > + > return NOERROR; S_OK and NOERROR mean the same thing, so this doesn't look quite right. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32 patch 23e
by Alexandre Julliard 24 Mar '04

24 Mar '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > + /* Add double quotation marks unless we already have them (e.g.: "%1" %* for exefile) */ > + if (res != out && *(res - 1) == '"') > + { > + strcpyW(res, cmd); > + res += strlenW(cmd); > + } > + else > + { > + strcpyW(res, cmd); > + res += strlenW(cmd); > + } Shouldn't you be doing something different in the else branch? Otherwise that test doesn't seem very useful ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky 24 Mar '04

24 Mar '04

>I'd rather there wasn't a DB. I know it saved time >and effort coding >wise to do it this way. Future changes will require >updates to the db, >and that can't be automated the way the current >scripts are. option2 crontab this: mysql -u user -D winapi -H >winapi_stats.html < test.sql now test.sql is a file that can be changed and the user is the only thing hardcoded in the crontab.... -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

2 1

lostwages: add my irc nick
by Kevin Koltzau 24 Mar '04

24 Mar '04

Changelog Add my irc nick

1 0

Re: To Do A.11 - Integrate API status into WineHQ
by hatky 24 Mar '04

24 Mar '04

On Wednesday 24 March 2004 22:19, you wrote: > On Wed, 24 Mar 2004, hatky wrote: > > It looks complicated but it's all 3 mysql commands to > > get a complete table > > with whatever data you want from the winapi stats data > > in a nice table... > > [...] > > > comments? > > Yeah, there's no need for a database. Right now Francois' > soluions works perfectly fine without a DB, please don't > use one. I say this is not acceptable, but is up to > laxdragon, he's the website maintainer. It uses DB only for creating the file as a parser becouse it's 3 lines of code instade of 30 line parsing and very very flexable, I talked to laxdragon, he has not problem with it, he is still reviewing it... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/), Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Missing WWN issues
by Francois Gouget 24 Mar '04

24 Mar '04

Looking through the WINeHQ CVS I noticed that we are missing 4 WWN issues. Fortunately they seem to be available at the Wine Kernel Cousin web site... sort of. Would some kind soul volunteer for retrieving what can be retrieved? * WWN 88 and WWN 89 http://www.kerneltraffic.org/wine/wn20010314_88.html http://www.kerneltraffic.org/wine/wn20010315_89.html Unfortunately these two appear to be empty so there's not much to save. * WWN 90 http://www.kerneltraffic.org/wine/wn20010409_90.html Eric Pouech's call for a replacement. * WWN 91 http://www.kerneltraffic.org/wine/wn20010415_91.html Brian Vincent's first WWN. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

2 1

Re: winetest: add support for revision info
by Ferenc Wagner 24 Mar '04

24 Mar '04

This patch goes somewhat against Dimi's. Instead of invoking cvs, it extracts the working revision info from the CVS/Entries files resulting in speedy operation. Thus I incorporated all the stuff into maketest, executing unconditionally. Hope it is still portable. ChangeLog: - Extract revision info from CVS/Entries. - #include "winetest.rc" into gui.rc. MinGW can't link in more than one resource files. - Enlarge chunk size of network transfer. Index: Makefile.in =================================================================== RCS file: /home/wine/wine/programs/winetest/Makefile.in,v retrieving revision 1.23 diff -u -r1.23 Makefile.in --- Makefile.in 20 Mar 2004 19:21:39 -0000 1.23 +++ Makefile.in 22 Mar 2004 23:03:43 -0000 @@ -1,4 +1,5 @@ TOPSRCDIR = @top_srcdir@ +export TOPSRCDIR TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ @@ -13,8 +14,7 @@ util.c RC_SRCS = \ - gui.rc \ - winetest.rc + gui.rc RC_BINSRC = gui.rc RC_BINARIES = wine.ico @@ -46,9 +46,6 @@ winetest.rc: maketest Makefile.in $(SRCDIR)/maketest $(TESTBINS) > $@ || ( $(RM) $@ && exit 1 ) - -revision.info: - (cd $(TOPSRCDIR); for file in dlls/*/tests/*.c; do rev=`cvs stat "$$file" | grep "Working" | awk '{print $$3}'`; echo "$$file:$$rev"; done) > $@ || ( $(RM) $@ && exit 1 ) winetest.res: $(TESTBINS) Index: gui.rc =================================================================== RCS file: /home/wine/wine/programs/winetest/gui.rc,v retrieving revision 1.2 diff -u -r1.2 gui.rc --- gui.rc 2 Mar 2004 20:56:35 -0000 1.2 +++ gui.rc 22 Mar 2004 23:03:43 -0000 @@ -21,6 +21,7 @@ #include <windows.h> #include <winres.h> #include "guires.h" +#include "winetest.rc" /* for the MinGW cross-compiler */ IDD_STATUS DIALOG 0, 0, 160, 140 STYLE WS_OVERLAPPEDWINDOW Index: main.c =================================================================== RCS file: /home/wine/wine/programs/winetest/main.c,v retrieving revision 1.7 diff -u -r1.7 main.c --- main.c 20 Mar 2004 19:21:39 -0000 1.7 +++ main.c 22 Mar 2004 23:03:43 -0000 @@ -140,7 +140,6 @@ } snprintf(buffer, sizeof(buffer), "dlls/%s/tests/%s.c", test, subtest); - fprintf(stderr, "file=%s\n", buffer); return buffer; } @@ -149,36 +148,35 @@ const struct rev_info* rev; for(rev = rev_infos; rev->file; rev++) { - fprintf(stderr, " ?{%s:%s)\n", rev->file, rev->rev); if (strcmp(rev->file, file) == 0) return rev->rev; } - return ""; + return "-"; } void extract_rev_infos () { char revinfo[256], *p; - int size = 0, i = 0, len; + int size = 0, i, len; HMODULE module = GetModuleHandle (NULL); for (i = 0; TRUE; i++) { if (i >= size) { size += 100; - rev_infos = xrealloc(rev_infos, size); + rev_infos = xrealloc (rev_infos, size * sizeof (*rev_infos)); } memset(rev_infos + i, 0, sizeof(rev_infos[i])); len = LoadStringA (module, i + 30000, revinfo, sizeof(revinfo)); if (len == 0) break; /* end of revision info */ - if (len >= sizeof(revinfo)) + if (len >= sizeof(revinfo) - 1) report (R_FATAL, "Revision info too long."); if(!(p = strrchr(revinfo, ':'))) report (R_FATAL, "Revision info malformed (i=%d)", i); *p = 0; rev_infos[i].file = strdup(revinfo); rev_infos[i].rev = strdup(p + 1); - } while(1); + } } void* extract_rcdata (int id, DWORD* size) @@ -196,7 +194,7 @@ return addr; } -/* Fills out the name, is_elf and exename fields */ +/* Fills in the name, is_elf and exename fields */ void extract_test (struct wine_test *test, const char *dir, int id) { @@ -459,48 +457,45 @@ cmdLine = mystrtok (cmdLine); while (cmdLine) { - if (*cmdLine == '-') - if (cmdLine[2]) { - report (R_ERROR, "Not a single letter option: %s", - cmdLine); - usage (); - exit (2); - } - cmdLine++; - switch (*cmdLine) { - case 'c': - report (R_TEXTMODE); - break; - case 'h': - usage (); - exit (0); - case 'q': - report (R_QUIET); - break; - case 's': - submit = mystrtok (NULL); - if (tag) - report (R_WARNING, "ignoring tag for submit"); - send_file (submit); - break; - case 'o': - logname = mystrtok (NULL); - run_tests (logname, tag); - break; - case 't': - tag = mystrtok (NULL); - cp = badtagchar (tag); - if (cp) { - report (R_ERROR, "invalid char in tag: %c", *cp); - usage (); - exit (2); - } - break; - default: - report (R_ERROR, "invalid option: -%c", *cmdLine); + if (cmdLine[0] != '-' || cmdLine[2]) { + report (R_ERROR, "Not a single letter option: %s", cmdLine); + usage (); + exit (2); + } + switch (cmdLine[1]) { + case 'c': + report (R_TEXTMODE); + break; + case 'h': + usage (); + exit (0); + case 'q': + report (R_QUIET); + break; + case 's': + submit = mystrtok (NULL); + if (tag) + report (R_WARNING, "ignoring tag for submit"); + send_file (submit); + break; + case 'o': + logname = mystrtok (NULL); + run_tests (logname, tag); + break; + case 't': + tag = mystrtok (NULL); + cp = badtagchar (tag); + if (cp) { + report (R_ERROR, "invalid char in tag: %c", *cp); usage (); exit (2); } + break; + default: + report (R_ERROR, "invalid option: -%c", cmdLine[1]); + usage (); + exit (2); + } cmdLine = mystrtok (NULL); } if (!logname && !submit) { Index: maketest =================================================================== RCS file: /home/wine/wine/programs/winetest/maketest,v retrieving revision 1.4 diff -u -r1.4 maketest --- maketest 20 Mar 2004 19:21:39 -0000 1.4 +++ maketest 22 Mar 2004 23:03:43 -0000 @@ -16,13 +16,15 @@ echo "$i \"$test\"" done -if [ -f revision.info ]; then - i=0 - for line in `cat revision.info`; do - i=`expr $i + 1` - echo "$i+30000 \"$line\"" - done -fi +i=30000 +cd $TOPSRCDIR +for dir in dlls/*/tests; do + sed -ne "s|^/$[^.]*.c$/$[^/]*$.*|$dir/\1:\2|p" $dir/CVS/Entries 2>/dev/null +done |\ +while read; do + echo "$i \"$REPLY\"" + i=`expr $i + 1` +done echo "}" Index: send.c =================================================================== RCS file: /home/wine/wine/programs/winetest/send.c,v retrieving revision 1.7 diff -u -r1.7 send.c --- send.c 19 Mar 2004 19:15:23 -0000 1.7 +++ send.c 22 Mar 2004 23:03:43 -0000 @@ -158,7 +158,7 @@ report (R_STATUS, "Sending %u bytes of data", filesize); report (R_PROGRESS, 2, filesize); - while ((bytes_read = fread (buffer, 1, BUFLEN / 8, f))) { + while ((bytes_read = fread (buffer, 1, BUFLEN / 2, f))) { if (send_buf (s, buffer, bytes_read)) { report (R_WARNING, "Error sending body: %d, %d", errno, WSAGetLastError ());

2 4

appdb bug
by Ivan Leo Murray-Smith 24 Mar '04

24 Mar '04

On this page http://appdb.winehq.org/appview.php?appId=935&versionId=1229 there should be 6 comments, but only 2 are displayed, can someone hacking one the appdb code, or J.N. look into this? Ivan.

3 2

Appdb bug
by Ivan Leo Murray-Smith 24 Mar '04

24 Mar '04

The search from the admin pages returns a 404 error: The requested URL /admin/search.php was not found on this server. Can someone please fix this? Ivan.

2 1

Re: CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.
by Uwe Bonnes 24 Mar '04

24 Mar '04

>>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: C> Add minimal parameter validation to function C> CURSORICON_SimulateLoadingFromResourceW(...). We check that the icon Providing a test case for such special behaviour is a good idea... -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 4

Re: CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.
by Stefan Leichter 24 Mar '04

24 Mar '04

Hello Uwe, i fear your test will only test what you like to test if it is executed in the source directory. For "out of tree builds" your test case tests how LoadImageA behaves when the specified file does not exist. Bye Stefan Am Dienstag, 23. März 2004 21:29 schrieb Uwe Bonnes: > >>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: > > C> Uwe Bonnes wrote: > >>>>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: > > C> Add minimal parameter validation to function > C> CURSORICON_SimulateLoadingFromResourceW(...). We check that the icon > > >> Providing a test case for such special behaviour is a good idea... > > C> I created this patch as a result of consulting I performed at a > C> customer's site. I no longer have access to the winedbg info I had > > It this what you meant? > > The test succeeds on NT and crashes on wine

2 2

Re: Problem with code in WWN 214
by Brian Vincent (C) 24 Mar '04

24 Mar '04

> WWN 214 contains some sample code and in my browser I see: > There are two things that are wrong: > * The #include statements are incomplete. That's because the HTML looks > like this: Yeah, that's just a problem with the server side stuff. Newman - do you happen to know why? Seems like an XML parser thing. > ' ' results in two line feeds eventhough that may be a bug in There should not be a ... the real tag is which is both XML and HTML compliant. <pre> is an evil tag if you use CSS, it should never be used on WineHQ. This does bring up a good point, <code> displays weird on WineHQ, compare it to how Zack does it: http://www.kerneltraffic.org/wine/wn20040312_214.html I think the problem is for two reasons: 1) There's no CSS definition for BR. There should be and maybe it should look something like: { margin-bottom: 3px; margin-top: 3px } Likewise, I tend to use <ul> for doing indenting and it needs to have less whitespace above and below. Or, maybe <dl> could be changed and I can abuse that instead. 2) That particular instance has some markup problems, I put in a couple of extra tags in a few places. Corollary to Linus' feelings on backups: Proofreading is for wimps. Real men publish their writing to a news site and have everyone else spellcheck it. (Although, you'll notice since Newman set me up with CVS acces I do tend to do a quick once over after committing it and then fix obvious mistakes. If you have any scripts that automate this I should be able to easily automate it into the existing publishing system I have. XML doesn't lend itself to spellchecking too easily, so I've never pursued it.) --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

2 1

Re: Cards.dll improvements
by Filip Navara 24 Mar '04

24 Mar '04

Sam wrote: >This patch implements card drawing mode flag >for rounding card corners. > >Sami Nopanen, xasmx(a)optonline.net > > I know it was propably suggested earlier, but why don't you use (or adapt) my cards.dll implementation for ReactOS? http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/lib/cards/ Regards, Filip

1 0

Re: Win32 packages released on sourceforge
by Ivan Leo Murray-Smith 24 Mar '04

24 Mar '04

> I am kind of holding my breath for a regular build of winetest.exe - any > chance for that soon? :-) It depends on how you define regular. If you mean daily/weekly builds, I have no idea. But I can build winetest.exe when I build the win32 packages, when A.J. releases wine. Ivan.

9 30

Q: Linux environment for loading Windows drivers?
by Heiko Nardmann 24 Mar '04

24 Mar '04

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi! Is there a Linux environment available somewhere to load Windows drivers and run the hardware this way? Thanks in advance! - -- Heiko Nardmann (Dipl.-Ing. Technische Informatik) secunet Security Networks AG - Sicherheit in Netzwerken (www.secunet.de), Weidenauer Str. 223-225, D-57076 Siegen Tel. : +49 271 48950-13, Fax : +49 271 48950-50 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) iEYEARECAAYFAkBhk2QACgkQpm53PRScYyiwWACfQ08ax3dD2tIcyheyujpp1kmu Ge4An1JB72l6gZN4RJvTMeUlBhsAgZEQ =Jzoc -----END PGP SIGNATURE-----

2 1

Re: winpos.c & module.c - minor ms-windows compatibility
by Dimitrie O. Paun 24 Mar '04

24 Mar '04

On Mon, 22 Mar 2004, Boaz Harrosh wrote: > module.c > GetProcAdress will not "Fly" on a NULL module. It will Just return > with Error set to ERROR_PROC_NOT_FOUND (127). > Actually, I did a little check, On ms-windows any garbage HMODULE will > Just Return an error. Is there a ValidPointer/magic_number check we can > do before we "fly" here. A small test in dlls/kernel/tests/*.c for this would be perfect. In general, it's better to submit such a test, rather than write a throw-away one on your box only. -- Dimi.

4 7

linux build broken
by Ivan Leo Murray-Smith 24 Mar '04

24 Mar '04

The build of gdi.dll.so fails miserably, with the following error, maybe because of the dlls building with winegcc? gcc -c -I. -I. -I../../include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o printdrv.o printdrv.c ../../tools/winebuild/winebuild -D__WINESRC__ -D_GDI32_ -o gdi32.dll.dbg.c --debug -C. ../../objects/bitmap.c ../../objects/brush.c ../../objects/clipping.c ../../objects/dc.c ../../objects/dcvalues.c ../../objects/dib.c ../../objects/enhmetafile.c ../../objects/font.c ../../objects/gdiobj.c ../../objects/linedda.c ../../objects/metafile.c ../../objects/palette.c ../../objects/pen.c ../../objects/region.c ../../objects/text.c bidi.c bitblt.c driver.c enhmfdrv/bitblt.c enhmfdrv/dc.c enhmfdrv/graphics.c enhmfdrv/init.c enhmfdrv/mapping.c enhmfdrv/objects.c freetype.c gdi_main.c icm.c mapping.c mfdrv/bitblt.c mfdrv/dc.c mfdrv/graphics.c mfdrv/init.c mfdrv/mapping.c mfdrv/objects.c mfdrv/text.c painting.c path.c printdrv.c bidi16.c dispdib.c env.c gdi16.c wing.c gcc -c -I. -I. -I../../include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o gdi32.dll.dbg.o gdi32.dll.dbg.c ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./gdi32.spec dispdib.spec.o gdi.exe.spec.o wing.spec.o bidi16.o dispdib.o env.o gdi16.o wing.o ../../objects/bitmap.o ../../objects/brush.o ../../objects/clipping.o ../../objects/dc.o ../../objects/dcvalues.o ../../objects/dib.o ../../objects/enhmetafile.o ../../objects/font.o ../../objects/gdiobj.o ../../objects/linedda.o ../../objects/metafile.o ../../objects/palette.o ../../objects/pen.o ../../objects/region.o ../../objects/text.o bidi.o bitblt.o driver.o enhmfdrv/bitblt.o enhmfdrv/dc.o enhmfdrv/graphics.o enhmfdrv/init.o enhmfdrv/mapping.o enhmfdrv/objects.o freetype.o gdi_main.o icm.o mapping.o mfdrv/bitblt.o mfdrv/dc.o mfdrv/graphics.o mfdrv/init.o mfdrv/mapping.o mfdrv/objects.o mfdrv/text.o painting.o path.o printdrv.o gdi32.dll.dbg.o version.res -o gdi32.dll.so -L../../dlls -ladvapi32 -lkernel32 -lntdll -L../../libs/wine -lwine -L../../libs/unicode -lwine_unicode /usr/lib/libicuuc.a /usr/lib/libicudata.a -lstdc++ -lgcc_s -L../../libs/port -lwine_port -lm gcc: /usr/lib/libicuuc.a: linker input file unused because linking not done gcc: /usr/lib/libicudata.a: linker input file unused because linking not done libicuuc-JrTm9s.o is an empty file winegcc: ../../tools/winebuild/winebuild failed. make[2]: *** [gdi32.dll.so] Error 2 make[2]: Leaving directory `/home/ivan/Development/Wine/CVS/wine/wine/dlls/gdi' make[1]: *** [gdi] Error 2 make[1]: Leaving directory `/home/ivan/Development/Wine/CVS/wine/wine/dlls' make: *** [dlls] Error 2 [ivan@localhost wine]$ Ivan.

1 0

Problem with code in WWN 214
by Francois Gouget 24 Mar '04

24 Mar '04

WWN 214 contains some sample code and in my browser I see: #include #include #include #include #include static jmp_buf jmpbuf; int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpszCmdLine, int nCmdShow) [...] There are two things that are wrong: * The #include statements are incomplete. That's because the HTML looks like this: #include <wine/library.h> Of course the correct form would be: #include <wine/library.h> And yet the XML source seems correct since it contains </>. * The line spacing is wrong. That's because the HTML contains: #include <wine/library.h> ' ' results in two line feeds eventhough that may be a bug in Mozilla. This might come from the ' ' tags in the XML source. But maybe the best approach would be to side-step ' ' altogether and use <pre> to generate something like this: <pre> #include >wine/library.h< #include >stdio.h< #include >windows.h< ... But maybe the idea behind <code> is that it makes the lines wrappable. In that case we need to fix the issue. Maybe removing it altogether would work? I see the same problems in other issues of WWN such as 139, 149 and 155. WWN 102 has the same double interline for a diff and there's probably other issues that are affected. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

1 0

Re: [dinput/linux input] two fixes/added missing axis and button polling
by Christoph Frick 24 Mar '04

24 Mar '04

On Wed, Mar 24, 2004 at 12:58:21AM +0100, Christoph Frick wrote: hi, im terribly sorry and hope this patch is not yet submited. > - changed the mapping of the axis to a simplier formula, that ignores > the middle of an axis this code lacked the "shifting" of the result by ``wanted min'' also not stated on the first posting: this patch is LGPL licensed below you find the complete patch again with the fixed part. -- cu Index: joystick_linuxinput.c =================================================================== RCS file: /home/wine/wine/dlls/dinput/joystick_linuxinput.c,v retrieving revision 1.1 diff -u -r1.1 joystick_linuxinput.c --- joystick_linuxinput.c 12 Feb 2004 23:28:00 -0000 1.1 +++ joystick_linuxinput.c 24 Mar 2004 07:23:15 -0000 @@ -239,7 +239,12 @@ for (i=0;i<ABS_MAX;i++) { newDevice->wantmin[i] = -32768; newDevice->wantmax[i] = 32767; - newDevice->deadz[i] = 1024; /* guessing */ + /* TODO: + * direct input defines a default for the deadzone somewhere; but as long + * as in map_axis the code for the dead zone is commented out its no + * problem + */ + newDevice->deadz[i] = 0; } return newDevice; } @@ -412,8 +417,8 @@ This->axes[i][AXE_ABSFUZZ], This->axes[i][AXE_ABSFLAT] ); - This->havemax[i] = This->axes[i][AXE_ABSMIN]; - This->havemin[i] = This->axes[i][AXE_ABSMAX]; + This->havemin[i] = This->axes[i][AXE_ABSMIN]; + This->havemax[i] = This->axes[i][AXE_ABSMAX]; } } MESSAGE("\n"); @@ -460,12 +465,8 @@ if (xmin == xmax) return val; if ((hmin == hmax) || (hmax==xmid) || (hmin==xmid)) return val; - /* don't assume total linearity, but linearity starting from a zeropoint */ - if (val > xmid) { - ret = (val-xmid)*((wmax-wmin)/2)/(hmax-xmid)+0; - } else { - ret = (xmid-val)*((wmax-wmin)/2)/(hmin-xmid)+0; - } + /* map the value from the hmin-hmax range into the wmin-wmax range */ + ret = (val * (wmax-wmin)) / (hmax-hmin) + wmin; #if 0 /* deadzone doesn't work comfortably enough right now. needs more testing*/ @@ -519,8 +520,54 @@ GEN_EVENT(DIJOFS_BUTTON(2),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); This->js.rgbButtons[2] = ie.value?0x80:0x00; break; + case BTN_TOP: + case BTN_X: + case BTN_4: + GEN_EVENT(DIJOFS_BUTTON(3),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[3] = ie.value?0x80:0x00; + break; + case BTN_TOP2: + case BTN_Y: + case BTN_5: + GEN_EVENT(DIJOFS_BUTTON(4),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[4] = ie.value?0x80:0x00; + break; + case BTN_PINKIE: + case BTN_Z: + case BTN_6: + GEN_EVENT(DIJOFS_BUTTON(5),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[5] = ie.value?0x80:0x00; + break; + case BTN_BASE: + case BTN_TL: + case BTN_7: + GEN_EVENT(DIJOFS_BUTTON(6),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[6] = ie.value?0x80:0x00; + break; + case BTN_BASE2: + case BTN_TR: + case BTN_8: + GEN_EVENT(DIJOFS_BUTTON(7),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[7] = ie.value?0x80:0x00; + break; + case BTN_BASE3: + case BTN_TL2: + case BTN_9: + GEN_EVENT(DIJOFS_BUTTON(8),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[8] = ie.value?0x80:0x00; + break; + case BTN_BASE4: + case BTN_TR2: + GEN_EVENT(DIJOFS_BUTTON(9),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[9] = ie.value?0x80:0x00; + break; + case BTN_BASE5: + case BTN_SELECT: + GEN_EVENT(DIJOFS_BUTTON(10),ie.value?0x80:0x0,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.rgbButtons[10] = ie.value?0x80:0x00; + break; default: - FIXME("unhandled joystick axe %x, value %d\n",ie.code,ie.value); + FIXME("unhandled joystick button %x, value %d\n",ie.code,ie.value); break; } break; @@ -533,9 +580,22 @@ case ABS_Y: GEN_EVENT(DIJOFS_Y,ie.value,ie.time.tv_usec,(This->dinput->evsequence)++); This->js.lY = map_axis(This,1,ie.value); + break; case ABS_Z: GEN_EVENT(DIJOFS_Z,ie.value,ie.time.tv_usec,(This->dinput->evsequence)++); This->js.lZ = map_axis(This,2,ie.value); + break; + case ABS_RX: + GEN_EVENT(DIJOFS_RX,ie.value,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.lRx = map_axis(This,3,ie.value); + break; + case ABS_RY: + GEN_EVENT(DIJOFS_RY,ie.value,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.lRy = map_axis(This,4,ie.value); + break; + case ABS_RZ: + GEN_EVENT(DIJOFS_RZ,ie.value,ie.time.tv_usec,(This->dinput->evsequence)++); + This->js.lRz = map_axis(This,5,ie.value); break; default: FIXME("unhandled joystick axe event (code %d, value %d)\n",ie.code,ie.value);

1 0

RFC - Program to schedule download of winetest.exe
by Jakob Eriksson 24 Mar '04

24 Mar '04

I have hacked together a little program to download winetest.exe and run it every 24h. Here is the URL: http://vmlinux.org/jakov/Wine/testloader/ There are more binaries and stuff there too. I know this is not a windows service, but at least it is something. Keep this console aplication open and it will download winetest.exe every 24h, with some randomness, to go easy on the server. .----------------------------------. What the code looks like: #include <string> #include <stdlib.h> #include <stdio.h> #include <time.h> #include <windows.h> #include <io.h> #include <process.h> using namespace std; static void await(int hour) { int right_time = 0; do { time_t now = time(NULL); struct tm comp = *gmtime(&now); if (comp.tm_hour == hour) { Sleep((rand()%60) * 60000); // Introduce randomness right_time = 1; } else { Sleep(10000); } } while(!right_time); } #define WINETESTS "winetests.exe" #define TESTCOPY "testcopy.exe" static void runtest() { SetCurrentDirectory(getenv("TEMP")); _unlink(WINETESTS); system("wget --no-clobber http://vmlinux.org/jakov/Wine/" WINETESTS); // Validate GPG signature for winetest.exe -- TODO // silly wget makes file not executable if (!CopyFile(WINETESTS, TESTCOPY, FALSE)) { printf("Problem with file " WINETESTS "\n"); return; } _unlink(WINETESTS); rename(TESTCOPY, WINETESTS); printf("execl %s returns: %d\n", WINETESTS, _execl(WINETESTS, WINETESTS, NULL)); } int main(int argc, char **argv) { int run_once = 0; if (argc != 2) { printf("Usage:\n%s < hour_of_download | once >\n", argv[0]); return 0; } srand((unsigned int)time(NULL)); if (2 == argc) { if (string(argv[1]) == "once") { run_once = 1; } } if (run_once) { runtest(); return 0; } while (1) { await(atoi(argv[1])); runtest(); } return 0; }

1 0

winegcc: don't mess with the DLL ext
by Dimitrie O. Paun 23 Mar '04

23 Mar '04

ChangeLog Dimitrie O. Paun <dpaun(a)rogers.com> Don't adjust the extension for DLLs. Index: tools/winegcc/winegcc.c =================================================================== RCS file: /var/cvs/wine/tools/winegcc/winegcc.c,v retrieving revision 1.21 diff -u -r1.21 winegcc.c --- tools/winegcc/winegcc.c 23 Mar 2004 00:14:54 -0000 1.21 +++ tools/winegcc/winegcc.c 23 Mar 2004 18:00:24 -0000 @@ -348,7 +348,7 @@ strarray *spec_args, *comp_args, *link_args; char *output_file; const char *spec_c_name, *spec_o_name; - const char *output_name, *spec_file, *def_ext; + const char *output_name, *spec_file; const char* winebuild = getenv("WINEBUILD"); int generate_app_loader = 1; int j; @@ -378,11 +378,10 @@ generate_app_loader = 0; /* normalize the filename a bit: strip .so, ensure it has proper ext */ - def_ext = opts->shared ? ".dll" : ".exe"; if (strendswith(output_file, ".so")) output_file[strlen(output_file) - 3] = 0; - if(!strendswith(output_file, def_ext)) - output_file = strmake("%s%s", output_file, def_ext); + if (!opts->shared && !strendswith(output_file, ".exe")) + output_file = strmake("%s.exe", output_file); /* get the filename by the path, if present */ if ((output_name = strrchr(output_file, '/'))) output_name++; -- Dimi.

1 0

compile errors with glibc 2.3.3
by Nerijus Baliunas 23 Mar '04

23 Mar '04

Hello, trying to build wine-20040309 in separate build directory. ../wine-20040309/configure completed correctly, but running make depend gives me: cd ./tools && make `basename tools/makedep` make[1]: Entering directory `/usr/src/wine-build/tools' gcc -c -I../../wine-20040309/tools -I. -I../../wine-20040309/include -I../include -DLEX_OUTPUT_ROOT="\"lex.yy\"" -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o makedep.o ../../wine-20040309/tools/makedep.c In file included from ../../wine-20040309/tools/makedep.c:21: ../include/config.h:871:27: missing terminating " character config.h line 871 is: #define SONAME_LIBNCURSES "libncurses.so.5 (really missing terminating " here) configure output was: checking ncurses.h usability... yes checking ncurses.h presence... yes checking for ncurses.h... yes checking for waddch in -lncurses... yes ... checking for -lncurses soname... libncurses.so.5 libncurses.so.4 checking for -lcurses soname... libcurses.so I have both libncurses.so.4 and libncurses.so.5 on my system: # rpm -qf libncurses.so.4.0 libncurses.so.5.3 ncurses4-5.0-12 ncurses-5.3-9 After adding missing " I get the next error: In file included from ../../wine-20040309/tools/makedep.c:23: ../../wine-20040309/include/wine/port.h:53: error: conflicting types for `mode_t' /usr/include/sys/types.h:72: error: previous declaration of `mode_t' # rpm -qf /usr/include/sys/types.h glibc-headers-2.3.3-17 (from Fedora devel) types.h 71 line: #ifndef __mode_t_defined typedef __mode_t mode_t; # define __mode_t_defined #endif After commenting out lines 52-72 of include/wine/port.h make depend completed successfully, but make failed with more errors: In file included from ../../../wine-20040309/libs/port/getpagesize.c:22: ../../../wine-20040309/include/wine/port.h:251: error: conflicting types for `getpagesize' /usr/include/unistd.h:872: error: previous declaration of `getpagesize' ../../../wine-20040309/include/wine/port.h:259: error: conflicting types for `lstat' /usr/include/sys/stat.h:365: error: previous declaration of `lstat' ... After fixing these by commenting out more lines I got more errors and stopped here. Regards, Nerijus

1 0

Audit of comctl32 for the PSDK - listview.c
by Steven Edwards 22 Mar '04

22 Mar '04

Hello, Its time for another round of PSDK porting fixes. I am going to start on comctl32. Most of if builds fine except for some internal or non-documented defines that we need to figure out how to handle. The only big issue we have is listview... Compiling... listview.c C:\source\wine\dlls\comctl32\listview.c(503) : warning C4018: '<' : signed/unsigned mismatch C:\source\wine\dlls\comctl32\listview.c(503) : warning C4018: '<' : signed/unsigned mismatch C:\source\wine\dlls\comctl32\listview.c(1620) : warning C4018: '<' : signed/unsigned mismatch C:\source\wine\dlls\comctl32\listview.c(1655) : warning C4018: '<' : signed/unsigned mismatch C:\source\wine\dlls\comctl32\listview.c(2593) : error C2065: '__FUNCTION__' : undeclared identifier C:\source\wine\dlls\comctl32\listview.c(2593) : warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(2593) : warning C4024: 'ranges_assert' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(2635) : warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(2635) : warning C4024: 'ranges_assert' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(2704) : warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(2704) : warning C4024: 'ranges_assert' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(2708) : warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(2708) : warning C4024: 'ranges_assert' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(2718) : warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(2718) : warning C4024: 'ranges_assert' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(2776) : warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(2776) : warning C4024: 'ranges_assert' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(2780) : warning C4047: 'function' : 'const char *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(2780) : warning C4024: 'ranges_assert' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(3974) : warning C4244: '=' : conversion from 'long ' to 'unsigned short ', possible loss of data C:\source\wine\dlls\comctl32\listview.c(4008) : warning C4244: '=' : conversion from 'long ' to 'unsigned short ', possible loss of data C:\source\wine\dlls\comctl32\listview.c(4015) : warning C4244: '=' : conversion from 'long ' to 'unsigned short ', possible loss of data C:\source\wine\dlls\comctl32\listview.c(4017) : warning C4244: '=' : conversion from 'long ' to 'unsigned short ', possible loss of data C:\source\wine\dlls\comctl32\listview.c(5061) : warning C4013: 'offsetof' undefined; assuming extern returning int C:\source\wine\dlls\comctl32\listview.c(5061) : error C2143: syntax error : missing ')' before 'type' C:\source\wine\dlls\comctl32\listview.c(5066) : error C2143: syntax error : missing ')' before 'type' C:\source\wine\dlls\comctl32\listview.c(5242) : error C2061: syntax error : identifier 'LISTVIEW_GetItemExtT' C:\source\wine\dlls\comctl32\listview.c(5242) : error C2059: syntax error : ';' C:\source\wine\dlls\comctl32\listview.c(5242) : error C2059: syntax error : 'type' C:\source\wine\dlls\comctl32\listview.c(5600) : warning C4013: 'LISTVIEW_GetItemExtT' undefined; assuming extern returning int C:\source\wine\dlls\comctl32\listview.c(5648) : warning C4018: '==' : signed/unsigned mismatch C:\source\wine\dlls\comctl32\listview.c(5680) : warning C4013: 'ListView_FindItemW' undefined; assuming extern returning int C:\source\wine\dlls\comctl32\listview.c(6102) : error C2143: syntax error : missing ')' before 'type' C:\source\wine\dlls\comctl32\listview.c(6107) : error C2143: syntax error : missing ')' before 'type' C:\source\wine\dlls\comctl32\listview.c(6180) : error C2061: syntax error : identifier 'LISTVIEW_RedrawItems' C:\source\wine\dlls\comctl32\listview.c(6180) : error C2059: syntax error : ';' C:\source\wine\dlls\comctl32\listview.c(6180) : error C2059: syntax error : 'type' C:\source\wine\dlls\comctl32\listview.c(6458) : warning C4013: 'Header_GetItemW' undefined; assuming extern returning int C:\source\wine\dlls\comctl32\listview.c(6618) : warning C4013: 'Header_SetItemW' undefined; assuming extern returning int C:\source\wine\dlls\comctl32\listview.c(7389) : warning C4244: '=' : conversion from 'long ' to 'short ', possible loss of data C:\source\wine\dlls\comctl32\listview.c(7568) : warning C4146: unary minus operator applied to unsigned type, result still unsigned C:\source\wine\dlls\comctl32\listview.c(7671) : warning C4146: unary minus operator applied to unsigned type, result still unsigned C:\source\wine\dlls\comctl32\listview.c(7753) : warning C4018: '<' : signed/unsigned mismatch C:\source\wine\dlls\comctl32\listview.c(8293) : warning C4244: '=' : conversion from 'long ' to 'short ', possible loss of data C:\source\wine\dlls\comctl32\listview.c(8822) : error C2065: 'LPLVFINDINFOW' : undeclared identifier C:\source\wine\dlls\comctl32\listview.c(8822) : warning C4047: 'function' : 'const struct tagLVFINDINFOW *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(8822) : warning C4024: 'LISTVIEW_FindItemW' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(8822) : error C2146: syntax error : missing ')' before identifier 'lParam' C:\source\wine\dlls\comctl32\listview.c(8822) : error C2059: syntax error : ')' C:\source\wine\dlls\comctl32\listview.c(8825) : error C2065: 'LPLVFINDINFOA' : undeclared identifier C:\source\wine\dlls\comctl32\listview.c(8825) : warning C4047: 'function' : 'const struct tagLVFINDINFOA *' differs in levels of indirection from 'int ' C:\source\wine\dlls\comctl32\listview.c(8825) : warning C4024: 'LISTVIEW_FindItemA' : different types for formal and actual parameter 3 C:\source\wine\dlls\comctl32\listview.c(8825) : error C2146: syntax error : missing ')' before identifier 'lParam' C:\source\wine\dlls\comctl32\listview.c(8825) : error C2059: syntax error : ')' C:\source\wine\dlls\comctl32\listview.c(9007) : warning C4013: 'LISTVIEW_RedrawItems' undefined; assuming extern returning int __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Re: Pipe Tests corrected[Resent]
by Alexandre Julliard 22 Mar '04

22 Mar '04

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > +void test_CreatePipe(void) > +{ > + /* Adapted from the MSDN SDK example > + * "Creating a Child Process with Redirected Input and Output" > + */ You can't do that, MSDN examples are copyright Microsoft. You have to write your own code from scratch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Some DirectDraw stubs
by Alexandre Julliard 22 Mar '04

22 Mar '04

Mike Hearn <mh(a)codeweavers.com> writes: > The parameters for these functions have not been verified as in native ddraw.dll > they are some kind of circular forward, it's rather confusing. The proper way to determine the number of parameters is to check what the caller does. And if nobody calls them there's no point in adding them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine/dlls/d3d8/device.c cleanup
by Dimitrie O. Paun 22 Mar '04

22 Mar '04

On March 20, 2004 3:42 pm, hatky wrote: > tabs -> spaces (the cause of the bloated file) You got to be kindin', right? -- Dimi.

3 4

OFC ( MFC-like classes )
by Jakob Eriksson 22 Mar '04

22 Mar '04

I thought I should mention: http://cvs.sourceforge.net/viewcvs.py/ofc/ofc/test/ The OFC project actually has a few classes now. Might be of use to somebody porting stuff to Linux. Jakob

1 0

Link with ICU in documentation
by Boaz Harrosh 22 Mar '04

22 Mar '04

- Where is the official place to download the ICU library for support of BIDI? - Should we not have a BIDI section in documentation? - Is there a place on winehq with links to extra needed downloads? should ICU be there 2? Free Life Boaz

2 1

CDRoms & SCSI
by Robert Lunnon 22 Mar '04

22 Mar '04

Well you can ignore my last message, from the source it's pretty obvious why it doesn't work. Linuxisms ! At the very least it should be possible to declare a scsi device in the config file and have it set up, IE one could probe each disk device declared for scsi capability. Possibly this should be the only behaviour since this would allow the user/administrator to limit wine to only particular scsi devices rather than give it open slather over everything. Comments ?

2 2

Re: version.dll patch
by Alexandre Julliard 21 Mar '04

21 Mar '04

Steven Edwards <steven_ed4153(a)yahoo.com> writes: > We found quite a few problems using version.dll on ReactOS and Windows > XP. According to Royce there was a issue regarding ANSI converion that > was causing applications (Winzip) to fail to load. Also we found that > Microsoft doesnt support reading of the Win16 resources from the Win32 > APIs. I don't think that's true. The MSDN doc explicitly says that 16-bit resources are supported, and they work just fine on XP here. Also the whole file has been reformatted, making it impossible to see what changed. Please don't do that. -- Alexandre Julliard julliard(a)winehq.org

5 5

Re: [PATCH] Fix attribute naked
by Filip Navara 21 Mar '04

21 Mar '04

Jeff Muizelaar wrote: > The attached patch changes declspec(naked) to __attribute__(cdecl) > from __attribute__(naked) > As seen in the gcc documentation > (http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function%20Attri…), > > __attribute__(naked) does not do the same thing as declspec(naked) > instead __attribute__(cdecl) does. Sure, it does the same. > http://www.cs.cornell.edu/courses/cs412/2001sp/resources/microsoft-calling-… > This page is wrong. From MSDN: "The naked storage-class attribute is a Microsoft-specific extension to the C language. The compiler generates code without prolog and epilog code for functions declared with the naked storage-class attribute. Naked functions are useful when you need to write your own prolog/epilog code sequences using inline assembler code. Naked functions are useful for writing virtual device drivers." > -Jeff - Filip

1 0

Re: wine/dlls/d3d8/device.c cleanup
by Duane Clark 21 Mar '04

21 Mar '04

Unknown wrote: > > Sorry, seems like I need to take great care of my words, I already been told > to drop the "hop e you like it" part before it got in... (spamers like this > word or sentence? I didn't know that....) > Not spammers, viruses ;) "Here is a new game I just wrote. Hope you like it." I tend to glance very fast at emails when moderating, and such phrases are red flags for me, requiring that I spend extra time to verify that the email is legitimate. It is not a big deal, but I try to discourage such phrases.

1 0

Re: 3/4 patches for compilation of ATL & MFC
by Boaz Harrosh 21 Mar '04

21 Mar '04

Alexandre Julliard wrote: > >The i64 suffix is not portable. > Boaz Harrosh wrote: >oops the wrong file. >I do need it with "LL" (real 64bit constant). >If you want it protected by an ifdef. Is there an long long ifdef done >by configure? .. OK I'll look for it and send a fix. include/config.h (done by configure?) has an "HAVE_LONG_LONG". Now what should I do in msvcrt/limits.h. should I: #include <config.h> ?? or the user should include it in files before limits.h both options look bad to me. Free life Boaz

1 0

XFree 4.4
by Jørn Villesen Christensen 21 Mar '04

21 Mar '04

Hi I downbloaded the 20040309 release and tried to compile. As other users have experienced, I got the error gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC_ _ -DBINDIR="\"/usr/local/bin\"" -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack -boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o keyboard.o keyboard.c keyboard.c: In function `X11DRV_KEYBOARD_DetectLayout': keyboard.c:1288: warning: comparison between signed and unsigned keyboard.c: In function `X11DRV_MapVirtualKeyEx': keyboard.c:1746: warning: comparison between signed and unsigned keyboard.c:1755: warning: comparison between signed and unsigned keyboard.c:1784: warning: comparison between signed and unsigned keyboard.c:1787: warning: comparison between signed and unsigned keyboard.c: In function `X11DRV_ToUnicodeEx': keyboard.c:2089: warning: comparison between signed and unsigned keyboard.c:2092: warning: comparison between signed and unsigned keyboard.c:2128: error: `XK_EuroSign' undeclared (first use in this function) keyboard.c:2128: error: (Each undeclared identifier is reported only once keyboard.c:2128: error: for each function it appears in.) make[2]: *** [keyboard.o] Error 1 make[2]: Leaving directory `/home/jvc/Downloads/wine-20040213/dlls/x11drv' make[1]: *** [x11drv] Error 2 make[1]: Leaving directory `/home/jvc/Downloads/wine-20040213/dlls' make: *** [dlls] Error 2 Searched around and found http://www.winehq.org/hypermail/wine-users/2004/02/0130.html which stated that the error was in the kernel. But after searching for the NLS in the kernel, not finding it, I gave up and wanted to recompile the release I previously had installed (which was 20040213. I had to uninstall while trying some rpms of wine). The thing is, that this version could not compile either - it produced the same error. My guess is that the error is not related to the kernel (because I have not recompiled that since my last wine install that worked) but to my upgrading to XFree 4.4. Is my guess correct. And will it be fixed? Best regards Jørn Christensen Denmark PS: Note that the error dump above is from my compiling of 20040213 - not 20040309. I had removed the source code of 20040309, but the error is (as far as I remember it) identical. I can of course - if its nescesarry - download and try to comiled 20040309 again...

1 0

print 16-bit WCHAR
by Gibtsnich Gibtsauchnich 21 Mar '04

21 Mar '04

Hello! I was wondering if there is any way to use a 16-bit-unicode-string with wine's TRACE, ERR or FIXME. I was thinking about something like: WCHAR text={'b','l','a',0}; TRACE("%?s", text); However, I found that these functions are a quite complicated wrapper around vfprintf, wich only accepts ANSI or 32-bit-unicode-strings. So could you tell me if wine has some WCHAR2char_t function or will i haveto use WideCharToMultiByte? Thank you Fabian -- +++ NEU bei GMX und erstmalig in Deutschland: TÜV-geprüfter Virenschutz +++ 100% Virenerkennung nach Wildlist. Infos: http://www.gmx.net/virenschutz

2 1

Cdrom
by Robert Lunnon 20 Mar '04

20 Mar '04

I am working on a Solaris CDROM plugin, but can't seem to get past the configuration stage. I get ASPI_GetNumControllers Could not open HKEY_DYN_DATA\WineScsi How do I get wine to setup this key ? Thanks Bob

1 0

Re: [D3D] Improve D3D7 compatibility
by Lionel Ulmer 20 Mar '04

20 Mar '04

> This makes Summoner recognize our D3D7 driver. How did you find out ? Some R.E.ing of the game ? I ask this because I find it strange that a game would not be 'future proof' and that it would refuse to run on future hardware that supports HW transform and light. You sure it's not just the addition of the 'DRAWPRIMITIVE2EX' flag which is needed ? Could anyone having a Windows box and a card having HW T&L report what the caps give (there is a nice tool for that in the DX SDK) ? My Windows laptop 1) is at work right now and 2) has a crappy 3D card so I can't test. Lionel -- Lionel Ulmer - http://www.bbrox.org/

2 2

Re: Win32 packages released on sourceforge
by Ivan Leo Murray-Smith 20 Mar '04

20 Mar '04

> Bug in binutils. A fix by Dimitry is in latest binutils. OK, I'm rebuilding mingw with gcc-3.2.3-20030504-1, binutils-2.15.90-20040222-1-src, mingw-runtime-3.2 and w32api-2.5, it should all be up to date. > MinGW folks split up the headers as well, (in their w32api package), > and I think they are useful in and of themselves. Ivan? So what we want is wine-hdrs-<version>.zip (headers) wine-dlls-<version>[-mingw].zip (2 packages with stripped and unstripped dlls) wine-prgs-<version>[-mingw].zip (2 packages with stripped and unstripped progs) wine-w32api-<version>[-mingw].zip (2 packages with stripped and unstripped libs) right?

3 2

wine hangs in ddraw/d3dtexture.c (d3dtexture_create)
by Michael Schlüter 20 Mar '04

20 Mar '04

Hi, the whole yesterday I was hunting a problem when staring a program with wine. Now I'm at a point I don't know what to do next. May be somebody can give me an hint? Here are the last lines of the trace+ddraw output: trace:ddraw:Main_DirectDrawSurface_Lock (0x40405b50)->Lock((nil),0x408bf960,00000001,00000000) trace:ddraw:Main_DirectDrawSurface_Lock - locking flags : DDLOCK_WAIT trace:ddraw:d3ddevice_lock_update copying back buffer to main memory with rectangle (0x0) - (800x600). trace:ddraw:Main_DirectDrawSurface_Lock locked surface returning description : - DDSD_CAPS : DDSCAPS_BACKBUFFER DDSCAPS_COMPLEX DDSCAPS_FLIP DDSCAPS_3DDEVICE DDSCAPS_VIDEOMEMORY DDSCAPS_LOCALVIDMEM - DDSD_HEIGHT : 600 - DDSD_WIDTH : 800 - DDSD_PITCH : 1600 - DDSD_LPSURFACE : 0x5f0d0000 - DDSD_PIXELFORMAT : ( DDPF_RGB , RGB bits: 16, R f800 G 07e0 B 001f) trace:ddraw:Main_DirectDrawSurface_Unlock (0x40405b50)->Unlock((nil)) trace:ddraw:DIB_DirectDrawSurface_Blt (0x403f5768)->(0x61885c,0x40405b50,0x61886c,01000000,(nil)) trace:ddraw:DIB_DirectDrawSurface_Blt destrect :0x0-800x600 trace:ddraw:DIB_DirectDrawSurface_Blt srcrect :0x0-800x600 trace:ddraw:DIB_DirectDrawSurface_Blt flags: DDBLT_WAIT trace:ddraw:d3ddevice_blt using direct buffer to buffer copy. trace:ddraw:upload_surface_to_tex_memory_init initialized texture upload for level 0 with conversion 0. trace:ddraw:Main_DirectDraw_CreateSurface (0x403f5418)->(0x61741ba0,0x60d0aedc,(nil)) trace:ddraw:Main_DirectDraw_CreateSurface Requesting surface desc : - DDSD_CAPS : DDSCAPS_TEXTURE DDSCAPS2_TEXTUREMANAGE - DDSD_HEIGHT : 128 - DDSD_WIDTH : 256 - DDSD_PIXELFORMAT : ( DDPF_ALPHAPIXELS DDPF_RGB , RGB bits: 16, R 7c00 G 03e0 B 001f A 8000) trace:ddraw:HAL_DirectDrawSurface_Construct (0x60f501b8,0x403f5418,0x61741ac0) trace:ddraw:DIB_DirectDrawSurface_Construct (0x60f501b8)->(0x403f5418,0x60f503b4) trace:ddraw:Main_DirectDrawSurface_Construct (0x60f501b8)->(0x403f5418,0x60f503b4) trace:ddraw:DIB_DirectDrawSurface_Construct (256x128, pitch=512) trace:ddraw:create_dib DIBSection at : 0x62100000 trace:ddraw:d3dtexture_create GL texture created for surface 0x60f501b8 (private data at 0x60f50058) The appropriate source code: ENTER_GL(); if (surf->mipmap_level == 0) { glGenTextures(1, &(private->tex_name)); if (private->tex_name == 0) ERR("Error at creation of OpenGL texture ID !\n"); TRACE(" GL texture id is : %d.\n", private->tex_name); private->__global_dirty_flag = (at_creation == FALSE ? SURFACE_MEMORY_DIRTY : SURFACE_MEMORY); private->global_dirty_flag = &(private->__global_dirty_flag); } else { private->tex_name = ((IDirect3DTextureGLImpl *) (main->tex_private))->tex_name; TRACE(" GL texture id reusing id %d from surface %p (private at %p)).\n", private->tex_name, main, main->tex_private); private->global_dirty_flag = &(((IDirect3DTextureGLImpl *) (main->tex_private))->__global_dirty_flag); } LEAVE_GL(); A printf showed me, that the call of glGenTextures didn't come back. That's strage because d3dtexture_create and glGenTextures are called a lot of times before without problems? If I delete glGenTextures it works but... Bye, Michael

3 8

Re: Win32 packages released on sourceforge
by Ivan Leo Murray-Smith 19 Mar '04

19 Mar '04

> Can you please post the list of errors to wine-devel, so people are aware of the > problems (and hopefully send patches to fix them :))? Complete compile error log is attached. > Now that we have this build, can we get rid of: > Wine programs for Windows > from the "Support Files" package? Done. Ivan.

5 5

Re: urlmon: Implement FindMimeFromData
by Juan Lang 19 Mar '04

19 Mar '04

Kevin, you said: IMHO we should really keep the list that is checked to a minimum (being the list Windows checks) as this code is basically doing "If a web server reports a MIME type in this list, ignore it and make our own guess" which is totally wrong standards-wise and a major cause of many problems under IE on Windows.. (Apologies for the lack of quoting.) According to that appendix, IE should only be overriding MIME types that are text/plain, application/octet-stream, or empty. It does so because it considers these "ambiguous". I think your patch may be useful for the small set of types you suggest, but shouldn't you only override in these cases too? --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - More reliable, more storage, less spam http://mail.yahoo.com

3 2

wine.inf
by Ivan Leo Murray-Smith 18 Mar '04

18 Mar '04

Hi list, I've installed wine.inf, but the system.reg file is very short, it only contains font information and computer name, this isn't exactly what I got with winedefault.reg I need this because I'm going to release a new version of winesetuptk that doesn't add the "Filesystem" parameter to the drive config, as AJ has removed it, and the winesetuptk build tree wants system.reg, user.reg and userdef.reg. But system.reg, well, I've described it, userdef.reg is empty and user.reg only contains the Control Panel\\Colors and Control Panel\\International entries. Am I doing something wrong? Ivan.

1 0

urlmon: Implement FindMimeFromData
by Kevin Koltzau 18 Mar '04

18 Mar '04

Here is an implementation of FindMimeFromData, based off of MSDN http://msdn.microsoft.com/workshop/networking/moniker/overview/appendix_a.a… There is lots of debate on the 'net regarding this "feature" in IE, most of it suggesting this is a bad idea.. One possible change that would work more "standards compliant" rather then "Windows like" would be to return the proposed MIME type unchanged if one is given, otherwise go through the detection methods..let me know if that would be a preferred solution Changelog Implement FindMimeFromData

2 2

Re: [RESENT] TIME_GetBias
by Alexandre Julliard 18 Mar '04

18 Mar '04

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > Changelog: > wine/dlls/ntdll/time.c: TIME_GetBias > Calculate the Bias before calling gmtime This cannot be right, the bias is supposed to be the difference between local time and GMT, so you have to use gmtime() not localtime(). -- Alexandre Julliard julliard(a)winehq.org

5 15

Re: Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 18 Mar '04

18 Mar '04

> Message du 18/03/04 00:51 > De : Marcus Meissner > A : Christian Costa > Copie à : wined > Objet : Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec) > On Wed, Mar 17, 2004 at 10:37:01PM +0000, Christian Costa wrote: > > Hi, > > > > When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. > > After some investigations, I found that a part of the code uses the EBX > > register at one point without saving > > and restore it afterwards. Since this register contains the PLT pointer > > for standard unix functions like libc ones, this > > does not take a long time for Wine to crashing. > > I tested with the ugly hack attached that saves and restores the EBX > > register between the call to DllMain and that fixed the problem and > > the DLL works fine then. > > This might happen. That ebx can be scrapped? > > Your fix is not really ok, you must not modify the stackpointer in asm statements. > > Try using: > __asm__ __volatile__ ("":::"ebx"); > > after entry(), which tells the compiler that ebx has been scrapped. Thanks for this! :-) Christian

2 1

Re: Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 18 Mar '04

18 Mar '04

> Message du 18/03/04 00:50 > De : Mike Hearn > A : wine-devel(a)winehq.com > Copie à : > Objet : Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec) > On Wed, 17 Mar 2004 22:37:01 +0000, Christian Costa wrote: > > When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. > > After some investigations, I found that a part of the code uses the EBX > > register at one point without saving and restore it afterwards. > > What calling convention is the entrypoint declared with? How can I retreive this info from the dll? I guess it is stdcall like it should be. > I thought EBX was > a register that had to be saved/restored according to the ABI and the > windows compilers would always do that? > I don't know but that would explain what is happening altough if it was the case I wonder why noone has encountered this problem yet. Bye, Christian

2 1

Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 18 Mar '04

18 Mar '04

> Message du 18/03/04 01:02 > De : Alexandre Julliard > A : Christian Costa > Copie à : wined > Objet : Re: PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec) > Christian Costa writes: > > > When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. > > After some investigations, I found that a part of the code uses the > > EBX register at one point without saving > > and restore it afterwards. Since this register contains the PLT > > pointer for standard unix functions like libc ones, this > > does not take a long time for Wine to crashing. > > Is the dll really modifying ebx explicitly? Isn't it rather a > consequence of a stack overflow or some similar bug? Yes, ebx is modified explicity and not poped from the stack. There is no save/restore statements. Bye, Christian

1 0

wineinstall hangs
by Fabian Cenedese 18 Mar '04

18 Mar '04

Hi I just tried on a new computer to checkout wine from cvs and do a install. Compilation worked fine, but there was again a problem with the regedit: --- snip --- Preparing to install default Wine registry entries... Installing default Wine registry entries... Warning: Language 'us' was not recognized, defaulting to English. Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: Xlib: extension "GLX" missing on display ":1.0". fixme:urlmon:URLMON_DllRegisterServer (void): stub wine: Unhandled exception (thread 0009), starting debugger... Warning: Language 'us' was not recognized, defaulting to English. Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: (hang, CTRL-C) Registry entries successfully installed. err:seh:setup_exception nested exception on signal stack in thread 0009 eip 40108aa6 esp 40031c28 stack 0x405a0000-0x406a0000 Installation complete for now. Good luck (this is still alpha software). If you have problems with WINE, please read the documentation first, as many kinds of potential problems are explained there. --- snip --- But after that I could start wine regedit and the keys seem to have been generated. So I don't know what really failed. bye Fabi

3 4

Re: Avoid a possible deadlock when stopping playback
by Christian Costa 18 Mar '04

18 Mar '04

Hi Dmitry, Are you sure this is usefull. How can SetEvent cause a deadlock? Bye, Christian > Message du 16/03/04 14:54 > De : Dmitry Timoshkov > A : wine-patches(a)winehq.com > Copie à : > Objet : Avoid a possible deadlock when stopping playback > Hello, > > looks like it's a good idea to do the same when signalling hStopEvent. > > Changelog: > Dmitry Timoshkov > Avoid a possible deadlock when stopping playback. > > --- cvs/hq/wine/dlls/winmm/mciavi/mciavi.c 2004-03-16 18:37:03.000000000 +0800 > +++ wine/dlls/winmm/mciavi/mciavi.c 2004-03-16 19:38:42.000000000 +0800 > @@ -606,7 +606,9 @@ static DWORD MCIAVI_mciStop(UINT wDevID, > switch (wma->dwStatus) { > case MCI_MODE_PLAY: > case MCI_MODE_RECORD: > + LeaveCriticalSection(&wma->cs); > SetEvent(wma->hStopEvent); > + EnterCriticalSection(&wma->cs); > /* fall through */ > case MCI_MODE_PAUSE: > /* Since our wave notification callback takes the lock, > > > > >

2 3

Rundll32 needs X
by Vincent Béron 18 Mar '04

18 Mar '04

Hi folks, Since wine.inf is now used as the source for the default values for the registry (via rundll32), importing it absolutely needs X (whereas the older regedit method didn't when importing a .reg file). This can be a problem for people running wineinstall via ssh from a Windows box. Is there a reason rundll32 needs user32 and cannot delayimport it? Vincent

3 3

PLT pointer destroyed problem when loading IR32_32.DLL (Indeo codec)
by Christian Costa 17 Mar '04

17 Mar '04

Hi, When executing the DllMain of the native IR32_32.DLL (VFW), Wine crashes. After some investigations, I found that a part of the code uses the EBX register at one point without saving and restore it afterwards. Since this register contains the PLT pointer for standard unix functions like libc ones, this does not take a long time for Wine to crashing. I tested with the ugly hack attached that saves and restores the EBX register between the call to DllMain and that fixed the problem and the DLL works fine then. Can someone tell me what happens? Thanks in advance, Christian Index: loader.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/loader.c,v retrieving revision 1.66 diff -u -r1.66 loader.c --- loader.c 16 Mar 2004 03:10:07 -0000 1.66 +++ loader.c 17 Mar 2004 21:19:39 -0000 @@ -690,7 +690,9 @@ else TRACE("(%p %s,%s,%p) - CALL\n", module, debugstr_w(wm->ldr.BaseDllName.Buffer), reason_names[reason], lpReserved ); + __asm("push %ebx"); retv = entry( module, reason, lpReserved ); + __asm("pop %ebx"); /* The state of the module list may have changed due to the call to the dll. We cannot assume that this module has not been

4 3

Re: [AppDB] - Script the table creation, help users to setup local appdb
by Paul van Schayck 17 Mar '04

17 Mar '04

Chris, On Wednesday 17 March 2004 19:16, Chris Morgan wrote: > README now has some instructions on how to setup a local > appdb. You should also note that magic_quotes_gpc should be off. Otherwise you would end up inside your database with \ everywhere. And for development display_errors is very handy. And great work on those tables. I was already wondered wy I couldn't login. Regards, Paul

1 0

Win32 packages released on sourceforge
by Ivan Leo Murray-Smith 17 Mar '04

17 Mar '04

The win32 packages of wine are on sourceforge, you can get them from http://sourceforge.net/project/showfiles.php?group_id=6241 or to view the win32 packages only http://sourceforge.net/project/showfiles.php?group_id=6241&package_id=112520 Ivan.

2 1

Re: Stubs needed by some Windows Update Installs
by Dmitry Timoshkov 17 Mar '04

17 Mar '04

"Aric Stewart" <aric(a)codeweavers.com> wrote: > @@ -297,7 +297,7 @@ > @ stub SetupSetSourceListA > @ stub SetupSetSourceListW > @ stdcall SetupTermDefaultQueueCallback(ptr) > -@ stub SetupTerminateFileLog > +@ stdcall SetupTerminateFileLog(ptr) The argument here should be 'long'. -- Dmitry.

2 3

Current CVS msi build failure
by Ferenc Wagner 17 Mar '04

17 Mar '04

Hi, with current CVS I get: [...] bison -p SQL_ -d ../../../src/dlls/msi/sql.y -o sql.tab.c ../../../src/dlls/msi/sql.y contains 4 shift/reduce conflicts and 10 reduce/reduce conflicts. bison -p SQL_ -d ../../../src/dlls/msi/sql.y -o sql.tab.c ../../../src/dlls/msi/sql.y contains 4 shift/reduce conflicts and 10 reduce/reduce conflicts. gcc -c -I../../../src/dlls/msi -I. -I../../../src/include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o tokenize.o ../../../src/dlls/msi/tokenize.c ../../../src/dlls/msi/tokenize.c:58: `TK_CHAR' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:58: initializer element is not constant ../../../src/dlls/msi/tokenize.c:58: (near initialization for `aKeywordTable[12].tokenType') ../../../src/dlls/msi/tokenize.c:59: `TK_CHAR' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:59: initializer element is not constant ../../../src/dlls/msi/tokenize.c:59: (near initialization for `aKeywordTable[13].tokenType') ../../../src/dlls/msi/tokenize.c:90: `TK_HOLD' undeclared here (not in a function) ../../../src/dlls/msi/tokenize.c:90: initializer element is not constant [etc., similar ones for TK_INT, TK_LONG, TK_LONGCHAR, TK_OBJECT and TK_SHORT] These IDs are really missing from my sql.tab.h. Any clues? -- Feri.

2 2

Re: Stub for SignalObjectAndWait
by Mike Hearn 17 Mar '04

17 Mar '04

On Wed, 17 Mar 2004 01:50:40 +0100, Raphael wrote: > PS: i'm trying to get MSN Messenger working, how we can register some com dlls > into registry ? The app installer should do that for you (last time I tried MSN Messenger I didn't have any problems with missing registrations) but you can run regsvr32 on a DLL to reregister it if you want to. thanks -mike

1 0

Re: REBAR: prevent recursions with WM_SIZE reason
by Mike McCormack 17 Mar '04

17 Mar '04

Alexandre, please don't apply this patch... it doesn't work the right way. Juan Lang pointed out that I have a = instead of a |= ... and after fixing it, it doesn't do what it mean to do. thanks, Mike Mike McCormack wrote: > > ChangeLog: > * prevent recursions with WM_SIZE reason

1 0

Re: tools/winetest winetest.cron
by Ferenc Wagner 16 Mar '04

16 Mar '04

Jeremy Newman <jnewman(a)winehq.org> writes: > ChangeSet ID: 11483 > > Log message: > set the lang Did you check if it was needed? I thought my patch took care of this in a language/locale neutral way by opening the report file in :raw mode. I'd like to not if it's not the case. -- Feri.

2 1

Browsing the wine source
by Blake Leverett 16 Mar '04

16 Mar '04

Hello, I have been getting wine from CVS for a while now, and have been looking through the source. How do people who work with the wine code browse around in the source tree? I found that 'ctags -e -R' can be used with emacs, which works OK, but I was wondering if there is a better method. Thanks, Blake Leverett

2 1

Re: cards.dll improvements
by Tom 16 Mar '04

16 Mar '04

Sam wrote: > Improvements to cards.dll based on documentation at > http://www.microsoft.com/mind/0396/games.asp. > I'm not sure if you have read this post or not but here it is. http://www.winehq.com/hypermail/wine-devel/2003/07/0691.html Tom

1 0

how to call setupapi / wine.inf
by Marcus Meissner 16 Mar '04

16 Mar '04

Hi, I am trying to setup wine with wine.inf, with the following call: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 /usr/share/wine/wine.inf However, the /usr/share/wine/wine.inf path does not seem to be translated correctly. 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",00000000,00000000,00 000000) ret=40c8333c 0009:Ret kernel32.GetFullPathNameW() retval=0000001b ret=40c8333c 0009:Call ntdll.RtlAllocateHeap(40360000,00000000,00000036) ret=40c83542 0009:Ret ntdll.RtlAllocateHeap() retval=4039a0e0 ret=40c83542 0009:Call kernel32.GetFullPathNameW(406efb6e L"/usr/share/wine/wine.inf",0000001b,4039a0e0,00 000000) ret=40c83571 0009:Ret kernel32.GetFullPathNameW() retval=0000001a ret=40c83571 0009:Call kernel32.CreateFileW(4039a0e0 L"Y:\\usr\\share\\wine\\wine.inf",80000000,00000001,0 0000000,00000003,00000000,00000000) ret=40c835af 0009:Ret kernel32.CreateFileW() retval=ffffffff ret=40c835af The config script has: [Drive Y] "Type" = "network" "Path" = "%HOME%" [Drive Z] "Type" = "network" "Path" = "/" So it should have been using Z:\\ Is this a problem in GetFullPathName or should I better use: /usr/bin/rundll32 setupapi.dll,InstallHinfSection DefaultInstall 128 z:\\usr\\share\\wine\\wine.inf ? Ciao, Marcus

4 4

dlls/ntdll/directory.c portability breakage
by Gerald Pfeifer 16 Mar '04

16 Mar '04

The new file dlls/ntdll/directory.c added by date: 2004/03/16 01:32:02; author: julliard; state: Exp; Implemented NtQueryDirectoryFile (partly based on a patch by Eric Pouech). broke non-Linux platforms (like FreeBSD): /usr/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o directory.o directory.c directory.c: In function `NtQueryDirectoryFile': directory.c:446: error: `O_DIRECTORY' undeclared (first use in this function) directory.c:446: error: (Each undeclared identifier is reported only once directory.c:446: error: for each function it appears in.) There *is* code to #define O_DIRECTORY /* To avoid blocking on non-directories in DOSFS_OpenDir_VFAT*/ #ifndef O_DIRECTORY # define O_DIRECTORY 0200000 /* must be directory */ #endif but it's in #ifdef linux only! Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

1 0

Re: cards.dll
by Joerg Mayer 16 Mar '04

16 Mar '04

On Tue, Mar 16, 2004 at 12:09:24AM +0200, Shachar Shemesh wrote: > Can someone remind me again why we can't have GPL DLLs in the tree? > Doesn't the "call through documented interface blah blah blah not > derived work" argument cause the license for each two DLLs in Wine to be > independant? Basically it goes like this: LGPLed code can be run as a library, i.e. a function of an LGPLed dll can be called as a function call. GPLed code must be run as a (Unix) process if you want to use it from non-GPL-compatible code. See the GPL and especially the GPL FAQ for details. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

2 1

Re: shell32 patch 23 d [correction]
by Alexandre Julliard 15 Mar '04

15 Mar '04

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes: > Alexandre - is there any thing wrong with this patch? Yes there has to be something wrong, you create a sei_tmp structure but you never actually use it. I'm not sure what your intent was. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [resend] rebar.c: RBBS_HIDETITLE support
by Alexandre Julliard 15 Mar '04

15 Mar '04

Filip Navara <xnavara(a)volny.cz> writes: > I'm sending this patch second time. Is there any reason why it wasn't > commited previously or it just got lost? It will get in faster if you send a non wrapped version ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

dlls/glu32 compile error
by Peter Hyman 15 Mar '04

15 Mar '04

Kernel 2.6.4 gcc = 3.2.3 The following compile time error occurs: make[2]: Entering directory `/mnt/src/src/wine/dlls/glu32' gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o glu32.spec.o glu32.spec.c {standard input}: Assembler messages: {standard input}:274: Error: no such instruction: `yes "glu32.dll"' {standard input}:275: Error: no such instruction: `yes "gluBeginCurve"' {standard input}:276: Error: no such instruction: `yes "gluBeginPolygon"' {standard input}:277: Error: no such instruction: `yes "gluBeginSurface"' {standard input}:278: Error: no such instruction: `yes "gluBeginTrim"' {standard input}:279: Error: no such instruction: `yes "gluBuild1DMipmaps"' {standard input}:280: Error: no such instruction: `yes "gluBuild2DMipmaps"' {standard input}:281: Error: no such instruction: `yes "gluCheckExtension"' etc... The source file at this location is: "__wine_spec_exp_names:\n" "\tyes \"glu32.dll\"\n" "\tyes \"gluBeginCurve\"\n" "\tyes \"gluBeginPolygon\"\n" "\tyes \"gluBeginSurface\"\n" "\tyes \"gluBeginTrim\"\n" Seems like the \" is being taken as a literal ". Did you mean for a \ to occur? or a \glu... to occur? Regards -- Peter Hyman

2 1

Re: shell32 [was cards.dll]
by Martin Fuchs 15 Mar '04

15 Mar '04

On 15.03.2004 23:01:56 Martin Fuchs wrote: > Well to take up for the ReactOS folks.... Martin and Ge have done one hell > of a fine job on shell32 !! > And they have given every thing back.. Not once but twice! > As AJ was on vacation at the time and Martin & Ge spent alot of time > i'm sure spliting the patch up into smaller chunks so it would be > excepted here. .. and the merge is not yet finished. I hope it will ever be finished. But it takes a very long time by sending out those small patch pieces, waiting for the commit, and then go on... Currently I'm splitting the ShellExecute patch (aka "shell32 patch 23") into small pieces, and sending them separately since most of them depends on some another piece. On my list there are also patch nr. 1 and 22 without any answer from Alexandre or some one else. Is there really no possibility to speed this up a bit? If it's going on at the current speed it may be finished at next christmas day. ;-) Martin

1 0

static.c patch
by Filip Navara 15 Mar '04

15 Mar '04

Hi, I want to synchronize my change from ReactOS with the Wine tree. Unfortunetly I can't test it and I don't even know if it compiles under Wine. So if anyone want to take care of it, here it is. Regards, Filip --- static.c Tue Feb 10 20:09:04 2004 +++ static.c Mon Mar 15 21:34:06 2004 @@ -122,6 +122,7 @@ static HBITMAP STATIC_SetBitmap( HWND hwnd, HBITMAP hBitmap, DWORD style ) { HBITMAP hOldBitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); if ((style & SS_TYPEMASK) != SS_BITMAP) return 0; if (hBitmap && GetObjectType(hBitmap) != OBJ_BITMAP) { @@ -129,7 +130,7 @@ return 0; } hOldBitmap = (HBITMAP)SetWindowLongA( hwnd, HICON_GWL_OFFSET, (LONG)hBitmap ); - if (hBitmap) + if (hBitmap && !(full_style & SS_REALSIZEIMAGE)) { BITMAP bm; GetObjectW(hBitmap, sizeof(bm), &bm); @@ -559,6 +560,7 @@ HBRUSH hbrush; HDC hMemDC; HBITMAP hBitmap, oldbitmap; + LONG full_style = GetWindowLongA( hwnd, GWL_STYLE ); GetClientRect( hwnd, &rc ); hbrush = (HBRUSH)SendMessageW( GetParent(hwnd), WM_CTLCOLORSTATIC, @@ -573,8 +575,17 @@ if (!(hMemDC = CreateCompatibleDC( hdc ))) return; GetObjectW(hBitmap, sizeof(bm), &bm); oldbitmap = SelectObject(hMemDC, hBitmap); - BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, - SRCCOPY); + if (full_style & SS_CENTERIMAGE) + { + BitBlt(hdc, (rc.right - bm.bmWidth) >> 1, + (rc.bottom - bm.bmHeight) >> 1, + bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, SRCCOPY); + } + else + { + BitBlt(hdc, 0, 0, bm.bmWidth, bm.bmHeight, hMemDC, 0, 0, + SRCCOPY); + } SelectObject(hMemDC, oldbitmap); DeleteDC(hMemDC); }

1 0

Re:dlls/glu32 compile error
by Peter Hyman 15 Mar '04

15 Mar '04

Kernel 2.6.4 gcc = 3.2.3 The following compile time error occurs: clip... Needed to recheck from cvs. update did not work right. Now, however, I have the same problem as Tom Williams did with Kernel 2.6.3 and the include files using type __u32, etc. http://www.winehq.org/hypermail/wine-devel/2004/03/0093.html In fact, Configure is nice enough to note there is a problem with the test for cdrom.h, but does not abort. configure:16424: checking linux/cdrom.h usability configure:16436: gcc -c -g -O2 conftest.c >&5 In file included from /usr/include/linux/cdrom.h:14, from conftest.c:189: /usr/include/asm/byteorder.h:14: syntax error before "__u32" /usr/include/asm/byteorder.h:28: syntax error before "__u64" In file included from /usr/include/linux/byteorder/little_endian.h:11, from /usr/include/asm/byteorder.h:57, from /usr/include/linux/cdrom.h:14, from conftest.c:189: /usr/include/linux/byteorder/swab.h:133: syntax error before "__u16" /usr/include/linux/byteorder/swab.h:146: syntax error before "__u32" /usr/include/linux/byteorder/swab.h:160: syntax error before "__u64" configure:16442: $? = 1 configure: failed program was: | /* confdefs.h. */ | | #define PACKAGE_NAME "Wine" | #define PACKAGE_TARNAME "wine" | #define PACKAGE_VERSION "20040309" | #define PACKAGE_STRING "Wine 20040309" | #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" -- Peter Hyman

1 0

Replace SetConsoleCtrlHandler fixme with a comment
by Mike Hearn 15 Mar '04

15 Mar '04

This output can interfere with shell/wcmd processes, or at least make them harder to use. If we put every todo item in a fixme wine would be unusable anyway :) Mike Hearn <mh(a)codeweavers.com> Replace SetConsoleCtrlHandler fixme with a comment Index: dlls/kernel/console.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/console.c,v retrieving revision 1.26 diff -u -r1.26 console.c --- dlls/kernel/console.c 11 Mar 2004 22:46:27 -0000 1.26 +++ dlls/kernel/console.c 15 Mar 2004 13:44:22 -0000 @@ -1427,7 +1427,7 @@ { BOOL ret = TRUE; - FIXME("(%p,%i) - no error checking or testing yet\n", func, add); + /* FIXME: no error checking or testing yet */ if (!func) {

2 2

Debugger frontend
by Fabian Cenedese 15 Mar '04

15 Mar '04

Hi This project is a curses based frontend for gdb. Maybe there are some things useful for winedbg. The source view sure would make debugging easier. http://cgdb.sourceforge.net/ bye Fabi

2 1

Re: [AppDB] ID checks
by Tom 15 Mar '04

15 Mar '04

Paul van Schayck wrote: > Hey, > > A start to the AppDB. The whole system is using the strongly depreceated auto > registered globals. (The DB was made before this rule was made/enforced) > This patch will just fix that problem for the browsing trough the DB. > It will also check if we really have a numeric ID and not someone entering > evil SQL. > > Regards, > Paul van Schayck > Yah.... The first patch to the AppDB code! Tom

1 0

[Tools] Unshield from SynCE
by Uwe Bonnes 15 Mar '04

15 Mar '04

Hallo, perhaps out tool section should mention Unshield from SynCE http://synce.sourceforge.net/synce/ It allows to exctract IS 5|6 cabinet files Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

WineHQ AppDB Source
by Jeremy Newman 15 Mar '04

15 Mar '04

I have opened up the source to the WineHQ appdb. Anyone with spare time and some PHP skills is welcome to help improve it. The tree has not been touched in over a year. I did some work to clean it up for this import, and thats about it. I will be available to answer any questions on it. Check it out: cvs -d:pserver:cvs@cvs.winehq.org:/home/wine co appdb If there is interest, I plan to switch the online version to auto-update from CVS like the lostwages tree does. -- Jeremy Newman <jnewman(a)codeweavers.com> CodeWeavers, Inc.

1 0

Re: mdi: remove child activate optimization
by Huw D M Davies 15 Mar '04

15 Mar '04

On Mon, Mar 15, 2004 at 06:49:00PM +0300, Phil Krylov wrote: > Hello Huw, > > Monday, March 15, 2004, 2:27:41 PM, you wrote: > > HDMD> Hi Phil, > > HDMD> Could you send me a +relay,+message,+mdi log of this please? > > It's around 1M in size when bzipped; do you want me to send it to your > email at physics.ox.ac.uk? Sure, let's give that a go. Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: Toolbar: Tooltips
by Dimitrie O. Paun 15 Mar '04

15 Mar '04

On March 14, 2004 8:03 pm, Robert Shearman wrote: > + * This code was audited for completeness against the documented features > + * of Comctl32.dll version 6.0 on Mar. 14, 2004, by Robert Shearman. Nice! Right now I have toolbar listed at 70% completion. Should I change that (when I said 70%, I wasn't basing my estimation on reality as I didn't audit the code, so an informed option would be much appreciated :)). -- Dimi.

1 0

FW: Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Argh, forget my previous message. I must have been utterly distracted. Rolf Kalbermatter -----Original Message----- From: Rolf Kalbermatter [mailto:rolf.kalbermatter@citeng.com] Sent: Mon, March 15, 2004 1:04 PM To: 'wine-devel(a)winehq.com' Cc: 'bon(a)elektron.ikp.physik.tu-darmstadt.de' Subject: Re: Munge /r and /n in HTTP_HttpSendRequestA Uwe Bonnes wrote: >The test for nLen is a good idea. But >with nLen = strlen(lpwhr->lpszPath); lpwhr->lpszPath[nLen] should give the >terminating NULL to my understanding... > >Or am I off by one? According to my ANSI C book strlen() returns the number of characters in a string NOT including the zero termination character. So I think in that case you would be indeed off by one. Rolf Kalbermatter

2 1

Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Uwe Bonnes wrote: >The test for nLen is a good idea. But >with nLen = strlen(lpwhr->lpszPath); lpwhr->lpszPath[nLen] should give the >terminating NULL to my understanding... > >Or am I off by one? According to my ANSI C book strlen() returns the number of characters in a string NOT including the zero termination character. So I think in that case you would be indeed off by one. Rolf Kalbermatter

2 2

Re: mdi: remove child activate optimization
by Phil Krylov 15 Mar '04

15 Mar '04

Hello Huw, Tuesday, March 9, 2004, 1:46:20 PM, you wrote: HDMD> Huw Davies <huw(a)codeweavers.com> HDMD> We need to at least refresh the window menu in ChildActivate, HDMD> so for now remove the 'is already activated' optimization. This patch brings a regression: IBM Translation Manager enters an endless activation-switching loop when closing one of its MDI children (which is in some non-trivial way used as a parent for 4 more MDI children). -- Best regards, Phil mailto:phil@newstar.rinet.ru

2 1

Re: Munge /r and /n in HTTP_HttpSendRequestA
by Rolf Kalbermatter 15 Mar '04

15 Mar '04

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: >This makes Xilinx webupdate.exe see the Servicepack > >+ else >+ /* remove \r and \n*/ >+ { >+ int nLen = strlen(lpwhr->lpszPath); >+ while ((lpwhr->lpszPath[nLen-1] == '\r')||(lpwhr->lpszPath[nLen-1] == '\n')) >+ { >+ nLen--; >+ lpwhr->lpszPath[nLen]='\0'; >+ } Mmmh, what happens if the passed in path would only exist of \r\n? A for or while loop without a guaranteed termination condition always seems suspect to me. I guess this would crash with an access violation, and most probably overwrite a few bytes of memory with 0 before that happens. Not good I think although I think it couldn't be effectively exploited as buffer overrun! while (nLen > 0 && ((lpwhr->lpszPath[nLen-1] == '\r') || (lpwhr->lpszPath[nLen-1] == '\n'))) might be the better solution. Though I still wonder about the [nLen-1] in above term. It seems [nLen] instead would be actually the right thing to do here which would make it while (nLen >= 0 && ((lpwhr->lpszPath[nLen] == '\r') || (lpwhr->lpszPath[nLen] == '\n'))) Rolf Kalbermatter

2 1

Re: Updated debug delay patch
by Uwe Bonnes 15 Mar '04

15 Mar '04

>>>>> "Mike" == Mike Hearn <mh(a)codeweavers.com> writes: Mike> Here is the updated version of my debug delay patch, back by Mike> popular request (well, ok, one person asked for it :) Mike> Usage is simple: Mike> WINEDELAY=1 WINEDEBUG=+relay wine foobar.exe Mike> Hit f12 in any window to switch debug tracing on/off Mike, it looks like the patch dosen't turn on debugging for new processes that where started after debugging for the parent process was turned on... Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

2 1

Working otu what is happening in a network dependent app
by Peter Riocreux 15 Mar '04

15 Mar '04

I am trying to see if I can work out why an app that contacts a licensing daemon, doesn't. I am inexperienced at Wine debug stuff, so point me at docs if that is appropriate. 1. The host and port for the daemon are passed through an environment variable. I am *definitely* exporting this. Is there a noddy Wine app that will just print out all the environment it sees to I can be *absolutely* sure that my app is seeing it? 2. Is there a specific set of debug messages I can turn on to see (a) the app looking up the environment and (b) trying to open a network connection. tcpdump shows it is *not* sending *any* packets to the host/port that it *does* use when running in real WindowsXP. Regards, Peter

2 2

Fail load module
by flyker 15 Mar '04

15 Mar '04

Problem: The wphsesam.dll linked with libssvlux.so Contents libssvlux.def: LIBRARY libssvlux.so EXPORTS SSV_AllouerZoneMem@8 @1 SSV_ChargerLecteur@14 @2 SSV_FormaterFSE@29 @3 SSV_FormaterFichier@12 @4 SSV_FormaterLot@32 @5 SSV_InitTrace@11 @6 SSV_LibererZoneMem@4 @7 SSV_LireCartePS@20 @8 SSV_LireConfig@8 @9 SSV_LireDateLecteur@8 @10 SSV_LireDroitsVitale@32 @11 SSV_LireVITALE@20 @12 SSV_MajDateLecteur@8 @13 SSV_TraduireARL@18 @14 But when i load this module i have errors: err:module:import_dll Loading module (file) libssvlux.so (which is needed by L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll") failed (error c0000020). err:module:import_dll No implementation for libssvlux.so.SSV_AllouerZoneMem imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_ChargerLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterFSE imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterFichier imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_FormaterLot imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LibererZoneMem imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireCartePS imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireConfig imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireDateLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireDroitsVitale imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_LireVITALE imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_MajDateLecteur imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef err:module:import_dll No implementation for libssvlux.so.SSV_TraduireARL imported from L"C:\\WINDOWS\\SYSTEM\\wphsesam.dll", setting to 0xdeadbeef Help me please. What wrong here ?

1 0

Re: Updated debug delay patch
by Uwe Bonnes 14 Mar '04

14 Mar '04

>>>>> "Mike" == Mike Hearn <mh(a)codeweavers.com> writes: Mike> Here is the updated version of my debug delay patch, back by Mike> popular request (well, ok, one person asked for it :) Mike> Usage is simple: Mike> WINEDELAY=1 WINEDEBUG=+relay wine foobar.exe Mike> Hit f12 in any window to switch debug tracing on/off Mike, this patch comes like sent from heaven. However: > cat ../delay_debug | patch -s -p0 --dry-run 1 out of 3 hunks FAILED -- saving rejects to file dlls/ntdll/debugtools.c.rej 2 out of 3 hunks FAILED -- saving rejects to file libs/wine/debug.c.rej 1 out of 1 hunk FAILED -- saving rejects to file include/wine/debug.h.rej Looking at the rejects, I could see no cause for the rejection however. Appended patch applies clean -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- Index: wine/dlls/ntdll/debugtools.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/debugtools.c,v retrieving revision 1.37 diff -u -r1.37 debugtools.c --- wine/dlls/ntdll/debugtools.c 3 Mar 2004 21:34:13 -0000 1.37 +++ wine/dlls/ntdll/debugtools.c 14 Mar 2004 13:02:46 -0000 @@ -300,7 +300,7 @@ ret += wine_dbg_printf( "%s:%s:%s ", classes[cls], channel + 1, function ); } if (format) - ret += NTDLL_dbg_vprintf( format, args ); + ret += __wine_dbg_vprintf( format, args ); return ret; } @@ -313,5 +313,6 @@ __wine_dbgstr_wn = NTDLL_dbgstr_wn; __wine_dbg_vsprintf = NTDLL_dbg_vsprintf; __wine_dbg_vprintf = NTDLL_dbg_vprintf; + if (getenv("WINEDELAY")) wine_dbg_toggle_block(); __wine_dbg_vlog = NTDLL_dbg_vlog; } Index: wine/libs/wine/debug.c =================================================================== RCS file: /home/wine/wine/libs/wine/debug.c,v retrieving revision 1.3 diff -u -r1.3 debug.c --- wine/libs/wine/debug.c 5 Dec 2003 00:17:41 -0000 1.3 +++ wine/libs/wine/debug.c 14 Mar 2004 13:02:46 -0000 @@ -54,6 +54,9 @@ static const char * const debug_classes[] = { "fixme", "err", "warn", "trace" }; +static int disabled_dbg_vprintf( const char *format, va_list args ); +static void* old_vprintf = &disabled_dbg_vprintf; /* used when blocking debug output */ + static int cmp_name( const void *p1, const void *p2 ) { const char *name = p1; @@ -140,6 +143,16 @@ } } +static int disabled_dbg_vprintf( const char *format, va_list args ) { + return 0; +} + +/* prevents printing of debug messages temporarily */ +void wine_dbg_toggle_block() { + fprintf(stderr, "wine: toggling tracing\n"); + old_vprintf = interlocked_xchg_ptr((void**)&__wine_dbg_vprintf, old_vprintf); /* fixme: is this thread safe? */ +} + /* parse a set of debugging option specifications and add them to the option list */ int wine_dbg_parse_options( const char *str ) { @@ -412,3 +425,4 @@ { return __wine_dbgstr_wn( s, -1 ); } + Index: wine/libs/wine/wine.def =================================================================== RCS file: /home/wine/wine/libs/wine/wine.def,v retrieving revision 1.10 diff -u -r1.10 wine.def --- wine/libs/wine/wine.def 5 Feb 2004 02:01:35 -0000 1.10 +++ wine/libs/wine/wine.def 14 Mar 2004 13:02:46 -0000 @@ -9,6 +9,7 @@ __wine_dbgstr_an __wine_dbgstr_wn __wine_dll_register + wine_dbg_toggle_block __wine_main_argc __wine_main_argv __wine_main_environ Index: wine/libs/wine/wine.map =================================================================== RCS file: /home/wine/wine/libs/wine/wine.map,v retrieving revision 1.1 diff -u -r1.1 wine.map --- wine/libs/wine/wine.map 12 Feb 2004 22:54:00 -0000 1.1 +++ wine/libs/wine/wine.map 14 Mar 2004 13:02:46 -0000 @@ -6,6 +6,7 @@ __wine_dbg_vlog; __wine_dbg_vprintf; __wine_dbg_vsprintf; + wine_dbg_toggle_block; __wine_dbgstr_an; __wine_dbgstr_wn; __wine_dll_register; Index: wine/dlls/x11drv/keyboard.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/keyboard.c,v retrieving revision 1.49 diff -u -r1.49 keyboard.c --- wine/dlls/x11drv/keyboard.c 2 Mar 2004 20:55:57 -0000 1.49 +++ wine/dlls/x11drv/keyboard.c 14 Mar 2004 13:02:51 -0000 @@ -1171,6 +1171,11 @@ KEYBOARD_GenerateMsg( VK_CAPITAL, 0x3A, event->type, event_time ); TRACE("State after : %#.2x\n",pKeyStateTable[vkey]); break; + case VK_F12: + if ((event->type == KeyPress) && getenv("WINEDELAY")) { + /* we get this event repeatedly if we hold down the key (keyboard repeat) */ + wine_dbg_toggle_block(); + } default: /* Adjust the NUMLOCK state if it has been changed outside wine */ if (!(pKeyStateTable[VK_NUMLOCK] & 0x01) != !(event->state & NumLockMask)) Index: wine/include/wine/debug.h =================================================================== RCS file: /home/wine/wine/include/wine/debug.h,v retrieving revision 1.12 diff -u -r1.12 debug.h --- wine/include/wine/debug.h 18 Nov 2003 20:47:48 -0000 1.12 +++ wine/include/wine/debug.h 14 Mar 2004 13:02:52 -0000 @@ -145,6 +145,7 @@ extern int wine_dbg_printf( const char *format, ... ) __WINE_PRINTF_ATTR(1,2); extern int wine_dbg_log( unsigned int cls, const char *ch, const char *func, const char *format, ... ) __WINE_PRINTF_ATTR(4,5); +extern void wine_dbg_toggle_block(); static inline const char *wine_dbgstr_guid( const GUID *id ) {

2 1

Re: shell32 patch 23 d [correction]
by Martin Fuchs 14 Mar '04

14 Mar '04

Alexandre - is there any thing wrong with this patch? > Changelog: > - expand environment strings in command, parameter and directory strings of > ShellExecuteExW32() My follow-up patches are blocked by this not yet committed patch.

1 0

README update offer
by Christian Britz 13 Mar '04

13 Mar '04

Hi, I know that I was pointed to the README file for my first german translation "because it is pretty stable and no major overhauls are planned". ;-) Nevertheless, I refuse to not offer you a little bit of my time to update some parts of the README and README.de files (the other translators would have to follow because I don't speak their languages well enough). I have two major update favorites: 1) Fabian Cenedese and others have made some good remarks about parts of the README being not precise enough or a little bit wrong / outdated. I would like to work on these sections. 2) Someone on the ML of my local LUG asked a rather simple question that would fit to the "quick start" section IMO. He asked how to include original MS fonts into wine because some Windows application seems to demand them being present (physically). A short explanation of this and the possibility to use native DLL files would perfect to a README file I think. Using native files certainly is not a primary goal of wine development; on the other hand it could help new users or users with tricky applications a lot. I will wait for your positive or negative feedback before I will post to wine-patches. If updating the README at this time is not wanted at all, please let me also know. I would offer then my help later. Christian

3 5

Re: Documentation does not get installed with cvs sources?!
by Ivan Leo Murray-Smith 13 Mar '04

13 Mar '04

AFAIK ./configure make depend make has never built the docs, at least since I use wine. Ivan.

2 1

Re: Application database
by Ivan Leo Murray-Smith 13 Mar '04

13 Mar '04

> I've noticed that the application database hasn't been updated for quite > some time. I'm willing to help to keep it up to date or become the > maintainer. I can help on this, if it's needed, and as long as I aren't alone. Ivan.

1 0

Willing to help with animated icons/cursors
by Joel Konkle-Parker 13 Mar '04

13 Mar '04

If anyone out there is currently working on animated icons/cursors in cursoricon.c, I'd like to try to help in any way I can. I'm not really sure where to start on my own though. Thanks in advance. -- Joel Konkle-Parker Webmaster [Ballsome.com] E-mail [jjk3(a)msstate.edu]

3 3

Re: wine/dlls/comctl32 rebar.c
by Robert Shearman 13 Mar '04

13 Mar '04

On Sat, 2004-03-13 at 02:12, Mike McCormack wrote: > Btw. what is the problem? When i click "Search" or "Favourites" in IE6, > it seems to work for me. Which version of IE are you using, and what is > the exact problem you are seeing? It is v6.0.2800.1106 The problem is that all of the Search, Favorites, Media and History sidebars seem to open the rebar in a very tiny width (it depends on which is being displayed). For example, the rebar in the history sidebar has a width of 4 pixels. The Media sidebar (shown in attachment) is slightly better with a width of 16 pixels. BTW, it is definitely this patch. I have tried reversing the other rebar patch and it made absolutely no difference. > A screenshot maybe? Attached. Rob

1 0

Re: wine/ misc/options.c documentation/wine.man.in ...
by Uwe Bonnes 12 Mar '04

12 Mar '04

>>>>> "Alexandre" == Alexandre Julliard <julliard(a)winehq.org> writes: ... Alexandre> ... Start deprecating the --debugmsg option. Would a patch extending the wrapper to understand all those old but handy options ( --debugmsg , --dll) be acceptable? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

5 9

Re: wine/dlls/comctl32 rebar.c
by Robert Shearman 12 Mar '04

12 Mar '04

On Fri, 2004-03-12 at 20:23, Alexandre Julliard wrote: > ChangeSet ID: 11458 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/03/12 14:23:39 > > Modified files: > dlls/comctl32 : rebar.c > > Log message: > Mike McCormack <mike(a)codeweavers.com> > Don't calculate the redundant and unused REBAR_ROW structures. > > Patch: http://cvs.winehq.org/patch.py?id=11458 This patch causes big problems with the width of the sidebars in IE6. I recommend that it be reversed until this issue has been investigated and resolved. Rob

1 0

Re: Add debug SnoopFromInclude/SnoopFromExclude options
by Alexandre Julliard 12 Mar '04

12 Mar '04

Mike Hearn <mh(a)codeweavers.com> writes: > + if (!check_snoop_from_module(name)) { > + TRACE_(snoop)("skipping snoop for %s\n", name); > + return; > + } This will disable snoop for calls into that dll, this is not what FromInclude/Exclude should do, it should check the caller module. -- Alexandre Julliard julliard(a)winehq.org

1 0

In Vino Veritas!
by Mike Hearn 12 Mar '04

12 Mar '04

Hi guys, So, just to wind up Alexandre [1], I wrote the following script. If you enjoy, as I do, sugar and all things sweet, you may like it. It probably screws up parameter passing entirely, but most win32 apps don't use them so no problem! Usage: vino +snoop,-imm foobar.exe vino ole32,oleaut32,rpcrt4=n +relay whatever.exe 2>/tmp/log Have fun! thanks -mike [1] OK I admit, I wrote this script for myself before I read Alexandres reply. Obviously this is a developer only script, it's not intended to be a part of Wine itself.

2 2

DM_SETDEFID problems
by Santosh Siddheshwar 12 Mar '04

12 Mar '04

Hi Rob, Maybe I should have been more clear in my question. Is DM_SETDEFID message processing restricted to dialogs created using dialog template? Is there any scenario where the DIALOGINFO structure could be NULL thus preventing the message from being effectively handled? Regards Santosh S __________________________________ Do you Yahoo!? Yahoo! Search - Find what you�re looking for faster http://search.yahoo.com

2 1

Re: Application database
by chmorgan＠charter.net 12 Mar '04

12 Mar '04

Yes, I too think we need to support the appdb. Perhaps we should setup some kind of application submission interface where users can fill things in and provide links to screen captures and such. Maintainers could then go through and apply the changes to the db and copy the images to a local location to preserve them. Chris > > From: Frank Hendriksen <frank.hendriksen(a)franksworld.net> > Date: 2004/03/11 Thu PM 03:22:14 EST > To: wine-devel(a)winehq.org > Subject: Application database > > I've noticed that the application database hasn't been updated for quite > some time. I'm willing to help to keep it up to date or become the > maintainer. > > > > >

6 7

Re: Re: Application database
by chmorgan＠charter.net 12 Mar '04

12 Mar '04

Can you add me as a maintainer of the appdb as well? I'm often helping people in irc so I deal a lot with people trying to run all kinds of different apps, would be useful to start filling in some information on them so we have some kind of record of how well they run under wine. Thanks, Chris > > From: Jeremy Newman <jnewman(a)codeweavers.com> > Date: 2004/03/12 Fri AM 08:00:08 EST > To: wine-devel(a)winehq.org > Subject: Re: Application database > > Based on the size of the submission queue right now, it does not look > like anyone has approved an app for awhile now. > > We may need a few more volunteers to maintain the appdb. > > I'm also curious to find out if I opened up the appdb code base, (i.e > made a cvs module for it), if anyone would be interested in improving > it. I haven't patched a single line of code in it for over a year. > > Honestly, I've been worried about opening it up, as I have never had the > time to go through and look for vulnerabilities and so forth. > > On Thu, 2004-03-11 at 21:27, Tom Williams wrote: > > I just added a new application, called TweakPNG, to the app database. :) > > > > I don't know if my submission was accepted or not. > > > > > chmorgan(a)charter.net wrote: > > > > >Yes, I too think we need to support the appdb. > > > > > >Perhaps we should setup some kind of application submission interface where users can fill things in and provide links to screen captures and such. Maintainers could then go through and apply the changes to the db and copy the images to a local location to preserve them. > > > > > >>From: Frank Hendriksen <frank.hendriksen(a)franksworld.net> > > >>Date: 2004/03/11 Thu PM 03:22:14 EST > > >>To: wine-devel(a)winehq.org > > >>Subject: Application database > > >> > > >>I've noticed that the application database hasn't been updated for quite > > >>some time. I'm willing to help to keep it up to date or become the > > >>maintainer. > > -- > Jeremy Newman <jnewman(a)codeweavers.com> > CodeWeavers, Inc. > > > >

1 0

DM_SETDEFID problems
by Santosh Siddheshwar 12 Mar '04

12 Mar '04

Hi All, Does anyone know if WINE supports sending DM_SETDEFID to non-dialog windows? Regards Santosh S ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

2 1

3/4 patches for compilation of ATL & MFC
by Boaz Harrosh 12 Mar '04

12 Mar '04

PATCH 3 msvcrt.diff minor fixes to msvcrt - include/msvcrt/limits.h very much synced with MSVC, needed by MFC - include/msvcrt/math.h I'm not sure who submitted a broken empty math.h header. Just to show that no one is doing serious winlib work lately, or they are not reporting about it. This header is the one I have for use with STLPort, it will Just #include the standard lib one. If it is not acceptable than at least completely remove the one in now. - include/msvcrt/mbctype.h Some missing constants for the _setmbcp, used by MFC - include/msvcrt/wchar.h Some code was copy pasted from <sys/stat.h> and was protected by an #ifndef. The <sys/stat.h> added some newer definitions that where not added to wchar. This patch removes the old definitions and instead #includes <sys/stat.h>. It is the same way in ms-headers. In fact I had some code that presupposed stat.h included by wchar that would hence not compile under the old version. ? include/msvcrt/exception ? include/msvcrt/float.h ? include/msvcrt/new ? include/msvcrt/stdarg.h ? include/msvcrt/typeinfo Index: include/msvcrt/limits.h =================================================================== RCS file: /home/wine/wine/include/msvcrt/limits.h,v retrieving revision 1.1 diff -u -r1.1 limits.h --- include/msvcrt/limits.h 2 Sep 2003 00:58:21 -0000 1.1 +++ include/msvcrt/limits.h 10 Mar 2004 08:36:47 -0000 @@ -1,10 +1,32 @@ #ifndef __WINE_LIMITS_H #define __WINE_LIMITS_H -#define INT_MAX 2147483647 -#define INT_MIN (-2147483648) -#define SHRT_MAX 32767 -#define SHRT_MIN (-32768) +/*chars and mb's*/ +#define CHAR_BIT 8 +#define CHAR_MIN (-128) +#define CHAR_MAX 127 +#define SCHAR_MIN (-128) +#define SCHAR_MAX 127 +#define UCHAR_MIN 0 +#define UCHAR_MAX 0xff +#define MB_LEN_MAX 2 + +/*shorts ints longs*/ +#define SHRT_MIN 0x8000 +#define SHRT_MAX 0x0fff + +#define USHRT_MAX 0xffff +#define INT_MIN (-2147483647 - 1) +#define INT_MAX 2147483647 +#define UINT_MAX 0xffffffff +#define LONG_MIN (-2147483647L - 1) +#define LONG_MAX 2147483647L +#define ULONG_MAX 0xffffffffUL + +/* __int64 */ +#define _I64_MIN (-9223372036854775807i64 - 1) +#define _I64_MAX 9223372036854775807i64 +#define _UI64_MAX 0xffffffffffffffffui64 #ifdef __cplusplus extern "C" { Index: include/msvcrt/math.h =================================================================== RCS file: /home/wine/wine/include/msvcrt/math.h,v retrieving revision 1.1 diff -u -r1.1 math.h --- include/msvcrt/math.h 2 Sep 2003 00:58:21 -0000 1.1 +++ include/msvcrt/math.h 10 Mar 2004 08:36:47 -0000 @@ -1,12 +1,14 @@ -#ifndef __WINE_MATH_H -#define __WINE_MATH_H -#ifdef __cplusplus -extern "C" { -#endif +#include <../include/math.h> -#ifdef __cplusplus -} -#endif - -#endif /* __WINE_MATH_H */ Index: include/msvcrt/mbctype.h =================================================================== RCS file: /home/wine/wine/include/msvcrt/mbctype.h,v retrieving revision 1.4 diff -u -r1.4 mbctype.h --- include/msvcrt/mbctype.h 18 Jul 2003 22:57:15 -0000 1.4 +++ include/msvcrt/mbctype.h 10 Mar 2004 08:36:47 -0000 @@ -30,6 +30,12 @@ unsigned char* __p__mbctype(void); #define _mbctype (__p__mbctype()) +/* _setmbcp parameter defines */ +#define _MB_CP_SBCS 0 +#define _MB_CP_OEM -2 +#define _MB_CP_ANSI -3 +#define _MB_CP_LOCALE -4 + int _getmbcp(void); int _ismbbalnum(unsigned int); int _ismbbalpha(unsigned int); Index: include/msvcrt/wchar.h =================================================================== RCS file: /home/wine/wine/include/msvcrt/wchar.h,v retrieving revision 1.5 diff -u -r1.5 wchar.h --- include/msvcrt/wchar.h 18 Jul 2003 22:57:15 -0000 1.5 +++ include/msvcrt/wchar.h 10 Mar 2004 08:36:48 -0000 @@ -151,35 +151,7 @@ #endif /* MSVCRT_WFINDDATA_T_DEFINED */ #ifndef MSVCRT_STAT_DEFINED -#define MSVCRT_STAT_DEFINED - -struct _stat { - _dev_t st_dev; - _ino_t st_ino; - unsigned short st_mode; - short st_nlink; - short st_uid; - short st_gid; - _dev_t st_rdev; - MSVCRT(_off_t) st_size; - MSVCRT(time_t) st_atime; - MSVCRT(time_t) st_mtime; - MSVCRT(time_t) st_ctime; -}; - -struct _stati64 { - _dev_t st_dev; - _ino_t st_ino; - unsigned short st_mode; - short st_nlink; - short st_uid; - short st_gid; - _dev_t st_rdev; - __int64 st_size; - MSVCRT(time_t) st_atime; - MSVCRT(time_t) st_mtime; - MSVCRT(time_t) st_ctime; -}; +#include <sys/stat.h> #endif /* MSVCRT_STAT_DEFINED */ /* ASCII char classification table - binary compatible */

4 3

fixme:msvcrt:MSVCRT__sopen
by Erik de Castro Lopo 12 Mar '04

12 Mar '04

HI all, I have a console program which spits out messages along the lines of: fixme:msvcrt:MSVCRT__sopen : pmode 0x01a0 ignored Looking at the code to MSVCRT__sopen I find this: if(pmode & ~(_S_IREAD | _S_IWRITE)) FIXME(": pmode 0x%04x ignored\n", pmode); else WARN(": pmode 0x%04x ignored\n", pmode); Would it not be safe to just delete both the FIXME and the WARN or am I missing something? Cheers, Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo nospam(a)mega-nerd.com (Yes it's valid) +-----------------------------------------------------------+ "The X-files is too optimistic. The truth is not out there." -- Anthony Ord

1 0

NULL DIALOGINFO structure
by Santosh Siddheshwar 12 Mar '04

12 Mar '04

Hi All, Does anyone visualize a scenario where DIALOGINFO is going to be NULL and subsequently we cannot process DM_SETDEFID and DM_GETDEFID messages? Regards Santosh S ********************************************************************* Disclaimer: The information in this e-mail and any attachments is confidential / privileged. It is intended solely for the addressee or addressees. If you are not the addressee indicated in this message, you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to Internet email for messages of this kind. *********************************************************************

1 0

CreateFile problem (with patch)
by Stefan Leichter 12 Mar '04

12 Mar '04

Sorry, this time with patch attached Hello, i have a program that trys to open the serial port with CreateFile() like this: Call kernel32.CreateFileA(00422f7c "\\\\.\\COM1",c0000000,00000000, 00000000,00000003,00000080,00000000) The function call fail with current CVS. After debugging some time i found a fix for the problem. But my knowlodge of the CreateFile function an all its different usages is verry limited. Therefore i post the patch here for comment. Bye Stefan

4 4

Tracking of single files in cvs
by Christian Britz 12 Mar '04

12 Mar '04

Hi, This might be just a general cvs related question but hopefully someone of you could help; I don't think that I am the only interested person! Is there a simple way to get informed when ever a specified file in cvs changes (e.g. by mail)? In my case I would like to track the README file. Or will I have to write a script or something myself? Thank you Christian

2 2

Re: Notepad - Richedit Window
by Mike McCormack 12 Mar '04

12 Mar '04

Hi Steven, I still think it would be better to create a seperate write.exe and implement rtf support in that (using Richedit). My feeling is that extending notepad.exe past what it's meant to do is going to cause trouble. Sorry to discourage you from working on Richedit :( It could be a satistfying project if you were willing to stick with it ... Mike Steven Edwards wrote: > Hello, > I was thinking about doing some work on richedit until Mike McCormack > said it would take a year of work. That means it would take me two or > three and I am just not that interested. Anyway it was still good for > me to get to pratice writting something that really works for once, > even if it is worthless on WINE. This patch does make running notepad > on windows look much better though and has no effect on WINE that I can > tell. > > Thanks > Steven > > Changelog: > Use a richedit control in notepad

1 0

Documentation does not get installed with cvs sources?!
by Christian Britz 11 Mar '04

11 Mar '04

Hi, As far as I remember the Wine documentation tree always got installed to /usr/share/doc when I compiled from official releases. Since few days I install from the sources in cvs. Yesterday I noticed that they were not copied from the source tree to /usr/share/doc. Is this normal behaviour for builds from cvs? Sorry if I made just some stupid mistake. Christian

1 0

Application database
by Frank Hendriksen 11 Mar '04

11 Mar '04

I've noticed that the application database hasn't been updated for quite some time. I'm willing to help to keep it up to date or become the maintainer.

2 1

one more patches for compilation of ATL & MFC
by Boaz Harrosh 11 Mar '04

11 Mar '04

winegcc.diff I know I promised 4 but here is a 5th. - include/wine/winegccdef.h (new) This is an exact replica of what winegcc is doing (extracted from winegcc.c) it is for use by people like me that cannot use winegcc directly. I hope that some day winegcc will just do: "-include wine/winegccdef.h" and save space and time. One addition I have added is an NO_NO_WARNING_MODE option that will eliminate lots off warnings. The default is warning off. - winegcc.c needed missing stuff Dimi what should I do with the work I have done with STLPort compiled over wine-msvcrt (dynamic or static libraries). I have not received any response from STLPort. Should I prepare a patch against the Original STLPort? where do I than send it? Index: tools/winegcc/winegcc.c =================================================================== RCS file: /home/wine/wine/tools/winegcc/winegcc.c,v retrieving revision 1.19 diff -u -r1.19 winegcc.c --- tools/winegcc/winegcc.c 9 Mar 2004 04:49:42 -0000 1.19 +++ tools/winegcc/winegcc.c 10 Mar 2004 16:00:42 -0000 @@ -275,6 +275,7 @@ strarray_add(comp_args, "-D_cdecl=__attribute__((__cdecl__))"); strarray_add(comp_args, "-D_fastcall=__attribute__((__fastcall__))"); strarray_add(comp_args, "-D__declspec(x)=__declspec_##x"); + strarray_add(comp_args, "-D_declspec(x)=__declspec_##x"); strarray_add(comp_args, "-D__declspec_align(x)=__attribute__((aligned(x)))"); strarray_add(comp_args, "-D__declspec_allocate(x)=__attribute__((section(x)))"); strarray_add(comp_args, "-D__declspec_deprecated=__attribute__((deprecated))"); --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ include/wine/winegccdef.h 2004-03-10 17:40:19.000000000 +0200 @@ -0,0 +1,99 @@ +/* + * Definitions that are defined by the winegcc when invoked. + * It is listed here so it can be used by anyone who needs to use + * gcc directly + * + * Copyright 2004 wine project + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#ifndef __WINEGCCDEF_H +#define __WINEGCCDEF_H + +#ifndef _MSC_VER + +#define WIN32 +#define _WIN32 +#define __WIN32 +#define __WIN32__ +#define __WINNT +#define __WINNT__ + +#define __stdcall __attribute__((__stdcall__)) +#define __cdecl __attribute__((__cdecl__)) +#define __fastcall //__attribute__((__fastcall__)) +#define _stdcall __attribute__((__stdcall__)) +#define _cdecl __attribute__((__cdecl__)) +#define _fastcall __attribute__((__fastcall__)) + +/* Wine specific defines */ +#define __WINE__ +#define WINE_UNICODE_NATIVE +#define __int8 char +#define __int16 short +#define __int32 int +#define __int64 long long +#define __WINE_GCC__ /* using both wine & gcc for STLPort */ + + +#define __declspec(x) __declspec_##x +#define _declspec(x) __declspec_##x + +/* works well. Some times the exact placing veries with in the statment */ +#define __declspec_selectany __attribute__((weak)) + +/* ignored by GCC and is warned (supported by MinGW) */ +#ifndef _NO_NO_WINEGCC_WARNING +# define __declspec_dllexport +#else +# define __declspec_dllexport __attribute__((dllexport)) +#endif + +/* ignored by GCC and is warned (supported by MinGW) */ +#ifndef _NO_NO_WINEGCC_WARNING +# define __declspec_dllimport +#else +# define __declspec_dllimport __attribute__((dllimport)) +#endif + +/* works */ +#define __declspec_noreturn __attribute__ ((noreturn)) +/* works */ +#define __declspec_nothrow __attribute__ ((nothrow)) +/* works ?? */ +#define __declspec_naked __attribute__ ((naked)) + +/* GCC is more restrictive about placing. look for TLS in gcc & msdn documentation */ +#define __declspec_thread __thread +/* no paralle defined to nothing */ +#define __declspec_novtable +/* Gcc only suports code ?? */ +#define __declspec_allocate(segname) __attribute__ (( section(segname) )) + +/* property is supported thrugh the file pretty_com.h */ +/* property( get=get_func_name|, put=put_func_name ) */ + +/* _declspec( uuid() ) and __uuidof are supported with code changes */ +/* see uuidof.h */ +#define __declspec_uuid(ComObjectGUID) error_SEE__uuidof_h__for_use_of_uuid + +#define __declspec_align(x) __attribute__((aligned(x))) +#define __declspec_deprecated __attribute__((deprecated)) +#define __declspec_noinline __attribute__((noinline)) + +#endif //_MSC_VER + +#endif /* __WINEGCCDEF_H */

3 2

testing win32 apps with wine
by brian＠chrissyandbrian.com 11 Mar '04

11 Mar '04

Can anyone point me to a good read on testing win32 apps on linux with wine? I want to write scripts that automate mouse clicks on buttons, read output from text fields, and grab pixel colors. My language of choice is python. -- Brian Edwards <brian at chrissyandbrian.com>

3 2

4/4 patches for compilation of ATL & MFC
by Boaz Harrosh 11 Mar '04

11 Mar '04

PATCH 4 warning_off.diff some of these might be controversial but would eliminate 17 tons off warnings when compiling MFC/ATL and user code. I have found (the hard way) that GCC in some cases would produce none working code but will Just warn about it. Having thousands of warnings or turning warning off will eliminate the ability to catch these cases. I have found that most of the trivial warnings can be avoided with a few small tricks. here they are below. (for complete discussion of GCC's bad code please post me) - include/msvcrt/mbstring.h This one will eliminate 1000 warnings in MFC and any using code The actual issue is definitely a mal-practice in the code of CString. But since MSVC does not care it was never fixed by MS . In effect it does nothing. ( I think code looks better, but that is subjective). It lets me a way to avoid these warnings when compiling MFC with -D_MBCS. (I did not currently managed to compile it with out it. And I did not even get to Unicode). This single patch would be very hard to maintain outside of wine. If any one has other suggestions I would be happy to hear them. for now it is the best I could do. - include/msvcrt/stddef.h Lots of offsetof in MFC headers and code. GCC will automatically warn on use of this macro on c++ objects. Regardless if it is right or wrong to do so. (for a complete discussion of this topic just browse to www.gcc.org and search for "offsetof"). this patch will eliminate the warning. ( Maybe it is best to keep this patch separate) ? include/wine/winegccdef.h Index: include/msvcrt/mbstring.h =================================================================== RCS file: /home/wine/wine/include/msvcrt/mbstring.h,v retrieving revision 1.4 diff -u -r1.4 mbstring.h --- include/msvcrt/mbstring.h 18 Jul 2003 22:57:15 -0000 1.4 +++ include/msvcrt/mbstring.h 10 Mar 2004 08:36:47 -0000 @@ -36,6 +36,12 @@ #define MSVCRT_SIZE_T_DEFINED #endif +#ifdef MBCS_CHAR + typedef MBCS_CHAR mbs_char ; +#else + typedef unsigned char mbs_char ; +#endif + #ifndef MSVCRT_NLSCMP_DEFINED #define _NLSCMPERROR ((unsigned int)0x7fffffff) #define MSVCRT_NLSCMP_DEFINED @@ -64,66 +70,66 @@ unsigned int _mbbtombc(unsigned int); int _mbbtype(unsigned char,int); #define _mbccmp(_cpc1,_cpc2) _mbsncmp((_cpc1),(_cpc2),1) -void _mbccpy(unsigned char*,const unsigned char*); +void _mbccpy(mbs_char*,const mbs_char*); unsigned int _mbcjistojms(unsigned int); unsigned int _mbcjmstojis(unsigned int); -MSVCRT(size_t) _mbclen(const unsigned char*); +MSVCRT(size_t) _mbclen(const mbs_char*); unsigned int _mbctohira(unsigned int); unsigned int _mbctokata(unsigned int); unsigned int _mbctolower(unsigned int); unsigned int _mbctombb(unsigned int); unsigned int _mbctoupper(unsigned int); -int _mbsbtype(const unsigned char*,MSVCRT(size_t)); -unsigned char* _mbscat(unsigned char*,const unsigned char*); -unsigned char* _mbschr(const unsigned char*,unsigned int); -int _mbscmp(const unsigned char*,const unsigned char*); -int _mbscoll(const unsigned char*,const unsigned char*); -unsigned char* _mbscpy(unsigned char*,const unsigned char*); -MSVCRT(size_t) _mbscspn(const unsigned char*,const unsigned char*); -unsigned char* _mbsdec(const unsigned char*,const unsigned char*); -unsigned char* _mbsdup(const unsigned char*); -int _mbsicmp(const unsigned char*,const unsigned char*); -int _mbsicoll(const unsigned char*,const unsigned char*); -unsigned char* _mbsinc(const unsigned char*); -MSVCRT(size_t) _mbslen(const unsigned char*); -unsigned char* _mbslwr(unsigned char*); -unsigned char* _mbsnbcat(unsigned char*,const unsigned char*,MSVCRT(size_t)); -int _mbsnbcmp(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -int _mbsnbcoll(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -MSVCRT(size_t) _mbsnbcnt(const unsigned char*,MSVCRT(size_t)); -unsigned char* _mbsnbcpy(unsigned char*,const unsigned char* +int _mbsbtype(const mbs_char*,MSVCRT(size_t)); +mbs_char* _mbscat(mbs_char*,const mbs_char*); +mbs_char* _mbschr(const mbs_char*,unsigned int); +int _mbscmp(const mbs_char*,const mbs_char*); +int _mbscoll(const mbs_char*,const mbs_char*); +mbs_char* _mbscpy(mbs_char*,const mbs_char*); +MSVCRT(size_t) _mbscspn(const mbs_char*,const mbs_char*); +mbs_char* _mbsdec(const mbs_char*,const mbs_char*); +mbs_char* _mbsdup(const mbs_char*); +int _mbsicmp(const mbs_char*,const mbs_char*); +int _mbsicoll(const mbs_char*,const mbs_char*); +mbs_char* _mbsinc(const mbs_char*); +MSVCRT(size_t) _mbslen(const mbs_char*); +mbs_char* _mbslwr(mbs_char*); +mbs_char* _mbsnbcat(mbs_char*,const mbs_char*,MSVCRT(size_t)); +int _mbsnbcmp(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +int _mbsnbcoll(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +MSVCRT(size_t) _mbsnbcnt(const mbs_char*,MSVCRT(size_t)); +mbs_char* _mbsnbcpy(mbs_char*,const mbs_char* ,MSVCRT(size_t)); -int _mbsnbicmp(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -int _mbsnbicoll(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -unsigned char* _mbsnbset(unsigned char*,unsigned int,MSVCRT(size_t)) +int _mbsnbicmp(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +int _mbsnbicoll(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +mbs_char* _mbsnbset(mbs_char*,unsigned int,MSVCRT(size_t)) ; -unsigned char* _mbsncat(unsigned char*,const unsigned char*, +mbs_char* _mbsncat(mbs_char*,const mbs_char*, MSVCRT(size_t)); -MSVCRT(size_t) _mbsnccnt(const unsigned char*,MSVCRT(size_t)); -int _mbsncmp(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -int _mbsncoll(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -unsigned char* _mbsncpy(unsigned char*,const unsigned char*,MSVCRT(size_t)); -unsigned int _mbsnextc (const unsigned char*); -int _mbsnicmp(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -int _mbsnicoll(const unsigned char*,const unsigned char*,MSVCRT(size_t)); -unsigned char* _mbsninc(const unsigned char*,MSVCRT(size_t)); -unsigned char* _mbsnset(unsigned char*,unsigned int,MSVCRT(size_t)); -unsigned char* _mbspbrk(const unsigned char*,const unsigned char*); -unsigned char* _mbsrchr(const unsigned char*,unsigned int); -unsigned char* _mbsrev(unsigned char*); -unsigned char* _mbsset(unsigned char*,unsigned int); -MSVCRT(size_t) _mbsspn(const unsigned char*,const unsigned char*); -unsigned char* _mbsspnp(const unsigned char*,const unsigned char*); -unsigned char* _mbsstr(const unsigned char*,const unsigned char*); -unsigned char* _mbstok(unsigned char*,const unsigned char*); -unsigned char* _mbsupr(unsigned char*); +MSVCRT(size_t) _mbsnccnt(const mbs_char*,MSVCRT(size_t)); +int _mbsncmp(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +int _mbsncoll(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +mbs_char* _mbsncpy(mbs_char*,const mbs_char*,MSVCRT(size_t)); +unsigned int _mbsnextc (const mbs_char*); +int _mbsnicmp(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +int _mbsnicoll(const mbs_char*,const mbs_char*,MSVCRT(size_t)); +mbs_char* _mbsninc(const mbs_char*,MSVCRT(size_t)); +mbs_char* _mbsnset(mbs_char*,unsigned int,MSVCRT(size_t)); +mbs_char* _mbspbrk(const mbs_char*,const mbs_char*); +mbs_char* _mbsrchr(const mbs_char*,unsigned int); +mbs_char* _mbsrev(mbs_char*); +mbs_char* _mbsset(mbs_char*,unsigned int); +MSVCRT(size_t) _mbsspn(const mbs_char*,const mbs_char*); +mbs_char* _mbsspnp(const mbs_char*,const mbs_char*); +mbs_char* _mbsstr(const mbs_char*,const mbs_char*); +mbs_char* _mbstok(mbs_char*,const mbs_char*); +mbs_char* _mbsupr(mbs_char*); #ifndef MSVCRT_MBLEADTRAIL_DEFINED #define MSVCRT_MBLEADTRAIL_DEFINED int _ismbblead(unsigned int); int _ismbbtrail(unsigned int); -int _ismbslead(const unsigned char*,const unsigned char*); -int _ismbstrail(const unsigned char*,const unsigned char*); +int _ismbslead(const mbs_char*,const mbs_char*); +int _ismbstrail(const mbs_char*,const mbs_char*); #endif /* MSVCRT_MBLEADTRAIL_DEFINED */ #ifdef __cplusplus Index: include/msvcrt/stddef.h =================================================================== RCS file: /home/wine/wine/include/msvcrt/stddef.h,v retrieving revision 1.7 diff -u -r1.7 stddef.h --- include/msvcrt/stddef.h 18 Jul 2003 22:57:15 -0000 1.7 +++ include/msvcrt/stddef.h 10 Mar 2004 08:36:47 -0000 @@ -56,7 +56,7 @@ #endif #endif -#define offsetof(s,m) (size_t)&(((s*)NULL)->m) +#define offsetof(s,m) (((size_t)&(((s*)128)->m)) - 128 ) #ifdef __cplusplus

1 0

2/4 patches for compilation of ATL & MFC
by Boaz Harrosh 11 Mar '04

11 Mar '04

PATCH 2 ForAtlMfc.diff some fixes and additional files needed by ATL/MFC - include/Makefile.in Added some new .idl files, see below - include/expdisp.idl Add the DWebBrowserEvents + the IWebBrowser2 and events - include/expdispid.h (new) needed by expdisp.idl and ATL code - include/olectl.h the font constant will not compile. I think it should also be fixed for c but I can't be sure. It was written like in MS headers, MSVC will compile it, but GCC will not. The way I did it works for both. - include/mshtmhst.idl (new) other Interfaces related to IE that are not present in expdisp.idl - include/msstkppg.h (new) some GUIDs used by MFC - include/objsafe.idl (new) common Interface also used by ATL * Not all Interfaces needed by AT/MFC are included here. These are the more commons that I have found used in other places. I will have available Makefiles, extra headers, directory listings, documentation ,demo applications, that are needed to compile MFC/ATL. One could grab the missing Interfaces together with the MFC/ATL source code, from where ever he/she Legally got them. Index: include/Makefile.in =================================================================== RCS file: /home/wine/wine/include/Makefile.in,v retrieving revision 1.121 diff -u -r1.121 Makefile.in --- include/Makefile.in 9 Mar 2004 01:29:56 -0000 1.121 +++ include/Makefile.in 10 Mar 2004 08:36:46 -0000 @@ -23,7 +23,9 @@ strmif.idl \ unknwn.idl \ urlmon.idl \ - wtypes.idl + wtypes.idl \ + mshtmhst.idl \ + objsafe.idl IDL_INCLUDES = \ axcore.idl \ Index: include/exdisp.idl =================================================================== RCS file: /home/wine/wine/include/exdisp.idl,v retrieving revision 1.1 diff -u -r1.1 exdisp.idl --- include/exdisp.idl 4 Sep 2003 02:00:46 -0000 1.1 +++ include/exdisp.idl 10 Mar 2004 08:36:46 -0000 @@ -84,6 +84,81 @@ HRESULT get_Busy([out] VARIANT_BOOL *pBool); } +#include "exdispid.h" +/***************************************************************************** + * DWebBrowserEvents: This Interface is the Events from the IWebBrowser above + */ +[ + oleautomation, + uuid(EAB22AC2-30C1-11CF-A7EB-0000C05BAE0B) +] +dispinterface DWebBrowserEvents +{ + properties: + methods: + [id(DISPID_BEFORENAVIGATE)] + void BeforeNavigate([in] BSTR URL, long Flags, BSTR TargetFrameName, VARIANT * PostData, BSTR Headers, [in, out]VARIANT_BOOL * Cancel); + + [id(DISPID_NAVIGATECOMPLETE)] + void NavigateComplete([in] BSTR URL ); + + [id(DISPID_STATUSTEXTCHANGE)] + void StatusTextChange([in]BSTR Text); + + [id(DISPID_PROGRESSCHANGE)] + void ProgressChange([in] long Progress, [in] long ProgressMax); + + [id(DISPID_DOWNLOADCOMPLETE)] + void DownloadComplete(); + + [id(DISPID_COMMANDSTATECHANGE)] + void CommandStateChange([in] long Command, [in] VARIANT_BOOL Enable); + + [id(DISPID_DOWNLOADBEGIN)] + void DownloadBegin(); + + [id(DISPID_NEWWINDOW)] + void NewWindow([in] BSTR URL, [in] long Flags, [in] BSTR TargetFrameName, [in] VARIANT * PostData, [in] BSTR Headers, [in,out] VARIANT_BOOL * Processed); + + [id(DISPID_TITLECHANGE)] + void TitleChange([in]BSTR Text); + + [id(DISPID_FRAMEBEFORENAVIGATE)] + void FrameBeforeNavigate([in] BSTR URL, long Flags, BSTR TargetFrameName, VARIANT * PostData, BSTR Headers, [in, out]VARIANT_BOOL * Cancel); + + [id(DISPID_FRAMENAVIGATECOMPLETE)] + void FrameNavigateComplete([in] BSTR URL ); + + [id(DISPID_FRAMENEWWINDOW)] + void FrameNewWindow([in] BSTR URL, [in] long Flags, [in] BSTR TargetFrameName, [in] VARIANT * PostData, [in] BSTR Headers, [in,out] VARIANT_BOOL * Processed); + + + + [id(DISPID_QUIT)] + void Quit([in, out] VARIANT_BOOL * Cancel); + + [id(DISPID_WINDOWMOVE)] + void WindowMove(); + + [id(DISPID_WINDOWRESIZE)] + void WindowResize(); + + [id(DISPID_WINDOWACTIVATE)] + void WindowActivate(); + + [id(DISPID_PROPERTYCHANGE)] + void PropertyChange([in] BSTR Property); +} + +typedef +[ + uuid(34A226E0-DF30-11CF-89A9-00A0C9054129) +] +enum CommandStateChangeConstants { + CSC_UPDATECOMMANDS = 0xFFFFFFFF, + CSC_NAVIGATEFORWARD = 0x00000001, + CSC_NAVIGATEBACK = 0x00000002, +} CommandStateChangeConstants; /***************************************************************************** * IWebBrowserApp interface @@ -117,5 +192,138 @@ HRESULT put_FullScreen([in] VARIANT_BOOL bFullScreen); } +/***************************************************************************** + * IWebBrowser2 interface + */ +[ + object, + oleautomation, + dual, + uuid(D30C1661-CDAF-11d0-8A3E-00C04FC9E26E) +] +interface IWebBrowser2 : IWebBrowserApp +{ + [id(500)] + HRESULT Navigate2([in] VARIANT * URL, + [in] VARIANT * Flags, + [in] VARIANT * TargetFrameName, + [in] VARIANT * PostData, + [in] VARIANT * Headers); + + + [id(501)] + HRESULT QueryStatusWB([in] OLECMDID cmdID, [out, retval] OLECMDF * pcmdf); + [id(502)] + HRESULT ExecWB([in] OLECMDID cmdID, [in] OLECMDEXECOPT cmdexecopt, [in] VARIANT * pvaIn, [out, in] VARIANT * pvaOut); + [id(503)] + HRESULT ShowBrowserBar( [in] VARIANT * pvaClsid, + [in] VARIANT * pvarShow, + [in] VARIANT * pvarSize ); + + [id(DISPID_READYSTATE)] + HRESULT get_ReadyState([retval, out] READYSTATE * plReadyState); + + [id(550)] + HRESULT get_Offline([out, retval] VARIANT_BOOL * pbOffline); + [id(550)] + HRESULT put_Offline([in] VARIANT_BOOL bOffline); + + [id(551)] + HRESULT get_Silent([out, retval] VARIANT_BOOL * pbSilent); + [id(551)] + HRESULT put_Silent([in] VARIANT_BOOL bSilent); + + [id(552)] + HRESULT get_RegisterAsBrowser([out, retval] VARIANT_BOOL * pbRegister); + [id(552)] + HRESULT put_RegisterAsBrowser([in] VARIANT_BOOL bRegister); + + [id(553)] + HRESULT get_RegisterAsDropTarget([out, retval] VARIANT_BOOL * pbRegister); + [id(553)] + HRESULT put_RegisterAsDropTarget([in] VARIANT_BOOL bRegister); + + [id(554)] + HRESULT get_TheaterMode([out, retval] VARIANT_BOOL * pbRegister); + [id(554)] + HRESULT put_TheaterMode([in] VARIANT_BOOL bRegister); + + [id(555)] + HRESULT get_AddressBar([out, retval] VARIANT_BOOL * Value); + [id(555)] + HRESULT put_AddressBar([in] VARIANT_BOOL Value); + + [id(556)] + HRESULT get_Resizable([out, retval] VARIANT_BOOL * Value); + [id(556)] + HRESULT put_Resizable([in] VARIANT_BOOL Value); +} + +[ + oleautomation, + uuid(34A715A0-6587-11D0-924A-0020AFC7AC4D) +] +interface DWebBrowserEvents2 : IDispatch +{ + [id(DISPID_STATUSTEXTCHANGE)] + void StatusTextChange([in]BSTR Text); + + [id(DISPID_PROGRESSCHANGE)] + void ProgressChange([in] long Progress, [in] long ProgressMax); + + [id(DISPID_COMMANDSTATECHANGE)] + void CommandStateChange([in] long Command, [in] VARIANT_BOOL Enable); + + [id(DISPID_DOWNLOADBEGIN)] + void DownloadBegin(); + + [id(DISPID_DOWNLOADCOMPLETE)] + void DownloadComplete(); + + [id(DISPID_TITLECHANGE)] + void TitleChange([in] BSTR Text); + + [id(DISPID_PROPERTYCHANGE)] + void PropertyChange([in] BSTR szProperty); + + + + [id(DISPID_BEFORENAVIGATE2)] + void BeforeNavigate2([in] IDispatch* pDisp, + [in] VARIANT * URL, [in] VARIANT * Flags, [in] VARIANT * TargetFrameName, [in] VARIANT * PostData, [in] VARIANT * Headers, + [in,out] VARIANT_BOOL * Cancel); + + [id(DISPID_NEWWINDOW2)] + void NewWindow2([in, out] IDispatch** ppDisp, [in, out] VARIANT_BOOL * Cancel); + + [id(DISPID_NAVIGATECOMPLETE2)] + void NavigateComplete2([in] IDispatch* pDisp, [in] VARIANT * URL ); + + [id(DISPID_DOCUMENTCOMPLETE)] + void DocumentComplete([in] IDispatch* pDisp, [in] VARIANT * URL ); + + [id(DISPID_ONQUIT)] + void OnQuit(); + + [id(DISPID_ONVISIBLE)] + void OnVisible([in] VARIANT_BOOL Visible); + + [id(DISPID_ONTOOLBAR)] + void OnToolBar([in] VARIANT_BOOL ToolBar); + + [id(DISPID_ONMENUBAR)] + void OnMenuBar([in] VARIANT_BOOL MenuBar); + + [id(DISPID_ONSTATUSBAR)] + void OnStatusBar([in] VARIANT_BOOL StatusBar); + + [id(DISPID_ONFULLSCREEN)] + void OnFullScreen([in] VARIANT_BOOL FullScreen); + + [id(DISPID_ONTHEATERMODE)] + void OnTheaterMode([in] VARIANT_BOOL TheaterMode); +} + /* FIXME */ cpp_quote("DEFINE_GUID(CLSID_WebBrowser, 0x8856f961, 0x340a, 0x11d0, 0xa9, 0x6b, 0x00, 0xc0, 0x4f, 0xd7, 0x05, 0xa2);") +cpp_quote("DEFINE_GUID(CLSID_InternetExplorer, 0x0002DF01, 0x0000, 0x0000, 0xc0, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x46);") Index: include/olectl.h =================================================================== RCS file: /home/wine/wine/include/olectl.h,v retrieving revision 1.19 diff -u -r1.19 olectl.h --- include/olectl.h 5 Sep 2003 23:15:44 -0000 1.19 +++ include/olectl.h 10 Mar 2004 08:36:47 -0000 @@ -19,6 +19,8 @@ #ifndef __WINE_OLECTL_H #define __WINE_OLECTL_H +#if !defined(__WIDL__) + #include <ocidl.h> #ifdef __cplusplus @@ -97,7 +99,11 @@ BOOL fStrikethrough; } FONTDESC, *LPFONTDESC; -#define FONTSIZE(n) { n##0000, 0 } +#ifdef __cplusplus +# define FONTSIZE(n) { n##0000 } +#else +# define FONTSIZE(n) { n##0000, 0 } +#endif /*__cplusplus*/ #define PICTYPE_UNINITIALIZED (-1) #define PICTYPE_NONE 0 @@ -169,6 +175,8 @@ HRESULT WINAPI OleTranslateColor( OLE_COLOR clr, HPALETTE hpal, COLORREF* lpcolorref); + +#endif /*!defined(__WIDL__)*/ /* standard dispatch ID's */ #define DISPID_AUTOSIZE (-500) --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ include/mshtmhst.idl 2004-01-12 14:11:33.000000000 +0200 @@ -0,0 +1,223 @@ +/* + * Defines advanced COM interfaces and APIs related to the IE Web browser + * + * Copyright (C) 2004 wine project + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + + +cpp_quote("#define CONTEXT_MENU_DEFAULT 0") +cpp_quote("#define CONTEXT_MENU_IMAGE 1") +cpp_quote("#define CONTEXT_MENU_CONTROL 2") +cpp_quote("#define CONTEXT_MENU_TABLE 3") +cpp_quote("/* in browse mode*/") +cpp_quote("#define CONTEXT_MENU_TEXTSELECT 4") +cpp_quote("#define CONTEXT_MENU_ANCHOR 5") +cpp_quote("#define CONTEXT_MENU_UNKNOWN 6") +cpp_quote("#define CONTEXT_MENU_IMGDYNSRC 7") +cpp_quote("#define CONTEXT_MENU_IMGART 8") +cpp_quote("#define CONTEXT_MENU_DEBUG 9") + +cpp_quote("#define MENUEXT_SHOWDIALOG 0x1") + +cpp_quote("#define DOCHOSTUIFLAG_BROWSER DOCHOSTUIFLAG_DISABLE_HELP_MENU | DOCHOSTUIFLAG_DISABLE_SCRIPT_INACTIVE ") + +import "ocidl.idl"; +import "objidl.idl"; +import "oleidl.idl"; +import "oaidl.idl"; +import "docobj.idl"; +/*import "mshtml.idl";*/ + +/* FIXME +cpp_quote("EXTERN_C const GUID CGID_MSHTML;") +cpp_quote("#define CMDSETID_Forms3 CGID_MSHTML") +cpp_quote("#define SZ_HTML_CLIENTSITE_OBJECTPARAM L\"{d4db6850-5385-11d0-89e9-00a0c90a90ac}\"") +*/ + +cpp_quote("typedef HRESULT STDAPICALLTYPE SHOWHTMLDIALOGFN (HWND hwndParent, IMoniker *pmk, VARIANT *pvarArgIn, TCHAR* pchOptions, VARIANT *pvArgOut);") + +cpp_quote("STDAPI ShowHTMLDialog( ") +cpp_quote(" HWND hwndParent,") +cpp_quote(" IMoniker * pMk, ") +cpp_quote(" VARIANT * pvarArgIn, ") +cpp_quote(" TCHAR * pchOptions,") +cpp_quote(" VARIANT * pvarArgOut ") +cpp_quote("); ") + +/***************************************************************************** + * IDocHostUIHandler interface + */ + +typedef +enum tagDOCHOSTUITYPE { + DOCHOSTUITYPE_BROWSE = 0, + DOCHOSTUITYPE_AUTHOR = 1, +} DOCHOSTUITYPE; + +typedef enum tagDOCHOSTUIDBLCLK { + DOCHOSTUIDBLCLK_DEFAULT = 0, + DOCHOSTUIDBLCLK_SHOWPROPERTIES = 1, + DOCHOSTUIDBLCLK_SHOWCODE = 2, +} DOCHOSTUIDBLCLK ; + +typedef enum tagDOCHOSTUIFLAG { + DOCHOSTUIFLAG_DIALOG = 1, + DOCHOSTUIFLAG_DISABLE_HELP_MENU = 2, + DOCHOSTUIFLAG_NO3DBORDER = 4, + DOCHOSTUIFLAG_SCROLL_NO = 8, + DOCHOSTUIFLAG_DISABLE_SCRIPT_INACTIVE = 16, + DOCHOSTUIFLAG_OPENNEWWIN = 32, + DOCHOSTUIFLAG_DISABLE_OFFSCREEN = 64, + DOCHOSTUIFLAG_FLAT_SCROLLBAR = 128, + DOCHOSTUIFLAG_DIV_BLOCKDEFAULT = 256, + DOCHOSTUIFLAG_ACTIVATE_CLIENTHIT_ONLY = 512, + DOCHOSTUIFLAG_DISABLE_COOKIE = 1024, +} DOCHOSTUIFLAG ; + + +[ + object, + uuid(bd3f23c0-d43e-11cf-893b-00aa00bdce1a), + pointer_default(unique), + local +] +interface IDocHostUIHandler : IUnknown +{ + + typedef struct _DOCHOSTUIINFO + { + ULONG cbSize; + DWORD dwFlags; + DWORD dwDoubleClick; + } DOCHOSTUIINFO; + + HRESULT ShowContextMenu( + [in] DWORD dwID, + [in] POINT* ppt, + [in] IUnknown* pcmdtReserved, + [in] IDispatch* pdispReserved); + HRESULT GetHostInfo([in, out] DOCHOSTUIINFO * pInfo); + HRESULT ShowUI( + [in] DWORD dwID, + [in] IOleInPlaceActiveObject * pActiveObject, + [in] IOleCommandTarget * pCommandTarget, + [in] IOleInPlaceFrame * pFrame, + [in] IOleInPlaceUIWindow * pDoc); + HRESULT HideUI(); + HRESULT UpdateUI(); + HRESULT EnableModeless([in] BOOL fEnable); + HRESULT OnDocWindowActivate([in] BOOL fActivate); + HRESULT OnFrameWindowActivate([in] BOOL fActivate); + HRESULT ResizeBorder( + [in] LPCRECT prcBorder, + [in] IOleInPlaceUIWindow * pUIWindow, + [in] BOOL fRameWindow); + HRESULT TranslateAccelerator( + [in] LPMSG lpMsg, + [in] const GUID * pguidCmdGroup, + [in] DWORD nCmdID); + HRESULT GetOptionKeyPath([out] LPOLESTR * pchKey, [in] DWORD dw); + HRESULT GetDropTarget( + [in] IDropTarget * pDropTarget, + [out] IDropTarget ** ppDropTarget); + HRESULT GetExternal([out] IDispatch **ppDispatch); + HRESULT TranslateUrl([in]DWORD dwTranslate, [in]OLECHAR *pchURLIn, [out]OLECHAR **ppchURLOut); + HRESULT FilterDataObject([in]IDataObject *pDO, [out]IDataObject **ppDORet); +} + + +//------------------------------------------------------------------------- +// ICustomDoc +// +//------------------------------------------------------------------------- + +[ + object, + uuid(3050f3f0-98b5-11cf-bb82-00aa00bdce0b), + pointer_default(unique), + local +] +interface ICustomDoc : IUnknown +{ + HRESULT SetUIHandler( + [in] IDocHostUIHandler * pUIHandler); +} + +//------------------------------------------------------------------------- +// IDocHostShowUI +// +//------------------------------------------------------------------------- + +[ + object, + uuid(c4d244b0-d43e-11cf-893b-00aa00bdce1a), + pointer_default(unique), + local +] +interface IDocHostShowUI : IUnknown +{ + HRESULT ShowMessage( + [in] HWND hwnd, + [in] LPOLESTR lpstrText, + [in] LPOLESTR lpstrCaption, + [in] DWORD dwType, + [in] LPOLESTR lpstrHelpFile, + [in] DWORD dwHelpContext, + [out] LRESULT * plResult); + HRESULT ShowHelp( + [in] HWND hwnd, + [in] LPOLESTR pszHelpFile, + [in] UINT uCommand, + [in] DWORD dwData, + [in] POINT ptMouse, + [out] IDispatch * pDispatchObjectHit); +} + +/* +//------------------------------------------------------------------------- +// ICSSFilterSite +// +//------------------------------------------------------------------------- +[ + odl, + oleautomation, + dual, + uuid(3050f3ed-98b5-11cf-bb82-00aa00bdce0b) +] +interface ICSSFilterSite : IUnknown +{ + [] HRESULT GetElement([retval, out] IHTMLElement** ppElem); + [] HRESULT FireOnFilterChangeEvent(); +}; + + +//------------------------------------------------------------------------- +// ICSSFilter +// +//------------------------------------------------------------------------- +[ + odl, + oleautomation, + dual, + uuid(3050f3ec-98b5-11cf-bb82-00aa00bdce0b) +] +interface ICSSFilter : IUnknown +{ + [] HRESULT SetSite([in] ICSSFilterSite* pSink); + [] HRESULT OnAmbientPropertyChange([in] LONG dispid); +}; +*/ --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ include/msstkppg.h 2004-01-14 19:41:33.000000000 +0200 @@ -0,0 +1,33 @@ +/* + * CLSIDs for msprop32 property pages. + * + * Copyright (C) the Wine project + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#if !defined(WINE_MSSTKPPG_H) +#define WINE_MSSTKPPG_H + +/* {7EBDAAE0-8120-11cf-899F-00AA00688B10}*/ +DEFINE_GUID(CLSID_StockFontPage, 0x7ebdaae0, 0x8120, 0x11cf, 0x89, 0x9f, 0x0, 0xaa, 0x0, 0x68, 0x8b, 0x10); + +/* {7EBDAAE1-8120-11cf-899F-00AA00688B10}*/ +DEFINE_GUID(CLSID_StockColorPage, 0x7ebdaae1, 0x8120, 0x11cf, 0x89, 0x9f, 0x0, 0xaa, 0x0, 0x68, 0x8b, 0x10); + +/* {7EBDAAE2-8120-11cf-899F-00AA00688B10}*/ +DEFINE_GUID(CLSID_StockPicturePage, 0x7ebdaae2, 0x8120, 0x11cf, 0x89, 0x9f, 0x0, 0xaa, 0x0, 0x68, 0x8b, 0x10); + +#endif /* WINE_MSSTKPPG_H*/ --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ include/objsafe.idl 2004-03-10 11:44:43.000000000 +0200 @@ -0,0 +1,52 @@ +/* + * objsafe.idl + * Object Safety Interfaces + * + * Copyright (C) wine + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +cpp_quote("") +import "unknwn.idl"; +cpp_quote("") +cpp_quote("/* Masks used in IObjectSafety:*/") +cpp_quote("#define INTERFACESAFE_FOR_UNTRUSTED_CALLER 0x00000001" ) +cpp_quote("#define INTERFACESAFE_FOR_UNTRUSTED_DATA 0x00000002" ) +cpp_quote("#define INTERFACE_USES_DISPEX 0x00000004" ) +cpp_quote("#define INTERFACE_USES_SECURITY_MANAGER 0x00000008" ) +cpp_quote("") +cpp_quote("EXTERN_C GUID CATID_SafeForScripting;") +cpp_quote("EXTERN_C GUID CATID_SafeForInitializing;") +cpp_quote("") + +[ + object, + uuid(CB5BDC81-93C1-11cf-8F20-00805F2CD064) +] +interface IObjectSafety : IUnknown +{ + HRESULT GetInterfaceSafetyOptions( + [in] REFIID riid, + [out] DWORD * pdwSupportedOptions, + [out] DWORD * pdwEnabledOptions); + + HRESULT SetInterfaceSafetyOptions( + [in] REFIID riid, + [in] DWORD dwOptionSetMask, + [in] DWORD dwEnabledOptions); +} + +typedef [unique] IObjectSafety *LPOBJECTSAFETY; --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ include/exdispid.h 2004-03-10 12:57:25.000000000 +0200 @@ -0,0 +1,57 @@ +/* + * IDs used by exdisp.idl + * + */ + +#ifndef WINE_EXDISPID_H__ +#define WINE_EXDISPID_H__ + +#define DISPID_BEFORENAVIGATE 100 +#define DISPID_NAVIGATECOMPLETE 101 +#define DISPID_STATUSTEXTCHANGE 102 +#define DISPID_QUIT 103 +#define DISPID_DOWNLOADCOMPLETE 104 +#define DISPID_COMMANDSTATECHANGE 105 +#define DISPID_DOWNLOADBEGIN 106 +#define DISPID_NEWWINDOW 107 +#define DISPID_PROGRESSCHANGE 108 +#define DISPID_WINDOWMOVE 109 +#define DISPID_WINDOWRESIZE 110 +#define DISPID_WINDOWACTIVATE 111 +#define DISPID_PROPERTYCHANGE 112 +#define DISPID_TITLECHANGE 113 + +#define DISPID_FRAMEBEFORENAVIGATE 200 +#define DISPID_FRAMENAVIGATECOMPLETE 201 +#define DISPID_FRAMENEWWINDOW 204 + +#define DISPID_BEFORENAVIGATE2 250 +#define DISPID_NEWWINDOW2 251 +#define DISPID_NAVIGATECOMPLETE2 252 +#define DISPID_ONQUIT 253 +#define DISPID_ONVISIBLE 254 +#define DISPID_ONTOOLBAR 255 +#define DISPID_ONMENUBAR 256 +#define DISPID_ONSTATUSBAR 257 +#define DISPID_ONFULLSCREEN 258 +#define DISPID_DOCUMENTCOMPLETE 259 +#define DISPID_ONTHEATERMODE 260 +#define DISPID_ONADDRESSBAR 261 + +#define DISPID_SELECTIONCHANGED 200 + +#define DISPID_WINDOWREGISTERED 200 +#define DISPID_WINDOWREVOKED 201 + +#define DISPID_RESETFIRSTBOOTMODE 1 +#define DISPID_RESETSAFEMODE 2 +#define DISPID_REFRESHOFFLINEDESKTOP 3 +#define DISPID_ADDFAVORITE 4 +#define DISPID_ADDCHANNEL 5 +#define DISPID_ADDDESKTOPCOMPONENT 6 +#define DISPID_ISSUBSCRIBED 7 +#define DISPID_SHELLUIHELPERLAST 7 + +#define DISPID_READYSTATE (-525) + +#endif /* WINE_EXDISPID_H__*/

1 0

1/4 patches for compilation of ATL & MFC
by Boaz Harrosh 11 Mar '04

11 Mar '04

I'll send 4 patches here for review. Once the comments stop I'll send them to patches. Do I send patches to .h files or the .idl is enough? PATCH 1 uuidof.diff - enable use of some ms extensions - include/wine/uuidof.h (new) Lets GCC compiler use the uuidof MSVC++ extension used in ATL. See comments inside the file - include wine/pretty_com.h (new) Lets any C++ compiler use the __decelspec( property () ) MSVC++ extension. See comments inside the file - tools/pretty_com.pl A Perl script that changes __decelspec( property () ) declarations to the proper macros from pretty_com.h. see comments inside the file - include/unknwn.idl (updated) Adds a C++ only extension to the IUnknown Interface. This is to let ATL compile (use of uuidof.h) Index: include/unknwn.idl =================================================================== RCS file: /home/wine/wine/include/unknwn.idl,v retrieving revision 1.4 diff -u -r1.4 unknwn.idl --- include/unknwn.idl 12 Apr 2003 00:09:14 -0000 1.4 +++ include/unknwn.idl 10 Mar 2004 08:36:47 -0000 @@ -30,7 +30,6 @@ cpp_quote("#endif") /* Interfaces */ - [ local, object, @@ -46,7 +45,58 @@ [out, iid_is(riid)] void **ppvObject); ULONG AddRef(); ULONG Release(); + +cpp_quote("/*This is so we can add the Template QueryInterface for use by ATL*/") +cpp_quote("/*do a -D_WINE_NO_UUIDOF_ if your cplusplus compiler breaks on it*/") +cpp_quote("#if defined(__cplusplus) && !defined(_WINE_NO_UUIDOF_)") +cpp_quote("") +cpp_quote("#include <wine/uuidof.h>") +cpp_quote("#ifndef __IUnknown_INTERFACE_DEFINED__") +cpp_quote("#define __IUnknown_INTERFACE_DEFINED__") +cpp_quote("") +cpp_quote("DEFINE_GUID(IID_IUnknown, 0x00000000, 0x0000, 0x0000, 0xc0,0x00, 0x00,0x00,0x00,0x00,0x00,0x46);") +cpp_quote("") +cpp_quote("extern \"C++\" {") +cpp_quote("") +cpp_quote("#ifdef ICOM_USE_COM_INTERFACE_ATTRIBUTE") +cpp_quote("struct __attribute__((com_interface)) IUnknown") +cpp_quote("#else") +cpp_quote("struct IUnknown") +cpp_quote("#endif") +cpp_quote("{") +cpp_quote(" virtual HRESULT STDMETHODCALLTYPE QueryInterface(") +cpp_quote(" REFIID riid,") +cpp_quote(" void** ppvObject) = 0;") +cpp_quote("") +cpp_quote(" virtual ULONG STDMETHODCALLTYPE AddRef(") +cpp_quote(" ) = 0;") +cpp_quote("") +cpp_quote(" virtual ULONG STDMETHODCALLTYPE Release(") +cpp_quote(" ) = 0;") +cpp_quote("") +cpp_quote(" template <class Q>") +cpp_quote(" HRESULT STDMETHODCALLTYPE QueryInterface(Q** pp)") +cpp_quote(" {") +cpp_quote(" return QueryInterface(__uuidof(Q), (void**)pp);") +cpp_quote(" }") +cpp_quote("};") +cpp_quote("") +cpp_quote("} // extern \"C++\"") +cpp_quote("") +cpp_quote("#define IUnknown_METHODS \\") +cpp_quote(" ICOM_MSVTABLE_COMPAT_FIELDS \\") +cpp_quote(" /*** IUnknown methods ***/ \\") +cpp_quote(" STDMETHOD_(HRESULT,QueryInterface)(THIS_ REFIID riid, void** ppvObject) PURE; \\") +cpp_quote(" STDMETHOD_(ULONG,AddRef)(THIS) PURE; \\") +cpp_quote(" STDMETHOD_(ULONG,Release)(THIS) PURE;") +cpp_quote("") +cpp_quote("#endif //__IUnknown_INTERFACE_DEFINED__") +cpp_quote("#else /* defined(__cplusplus) && !defined(_WINE_NO_UUIDOF_) */") } + +cpp_quote("#endif /* defined(__cplusplus) && !defined(_WINE_NO_UUIDOF_) */") +cpp_quote("") +cpp_quote("") [ object, --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ include/wine/pretty_com.h 2004-02-25 21:21:18.000000000 +0200 @@ -0,0 +1,218 @@ +/* + * Add support for Microsoft extention + * __declspec( property (get= xxxx,put = yyyy) ) + * + * Copyright 2004 Boaz Harrosh boaz(a)ElectroZaur.com + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + + +#ifndef __pretty_com_h__ +#define __pretty_com_h__ + +#if !defined( __cplusplus ) +# error Use this file only for C++ compilation +#endif + +/* +explanation: + the ms-extention __declspec(property()) lets you associate a ?fake? variable name to + one or a pair of class member functions. So function calls will be made where in + code a variable assignment or access is made. This makes C++ syntax look more + like script or 4th generation language. + +For example: + class HasProperty{ + public: + __declspec( property ( get=GetFoo ,put=PutFoo ) ) + int Foo ; + + int GetFoo() ; + void PutFoo(int newVal) ; + } +will let you use code like: + HasProperty hp ; + int i = hp.Foo ; + hp.Foo = i * 17 ; + +In effect Line 2 above invokes GetFoo() (R-Value) +and Line 3 will invoke PutFoo(..) (L-Value) +Foo has no allocation in memory and HasProperty does not grow in any way +by the presence of Foo. + +Below code will let such code usage to be used by any standard C++ compiler. + __declspec declarations must change but source code can stay the same. + Same new declarations can than be used by both MSVC or other compilers. + +Use: + ALL_P( type, PropertyName ) + GET_P( type, PropertyName ) + PUT_P( type, PropertyName ) +if the Foo name will have a GetFoo/PutFoo corresponding members. + +Use: + ALL_PROP( type, PropertyName, GetFunction ,PutFunction ) + GET_PROP( type, PropertyName, GetFunction ) + PUT_PROP( type, PropertyName, PutFunction ) +if you need specific control on associated member function names + +Don't forget to use DECLARE_PROP_CLASS( classname ) anywhere in +the class before the first property. + +Note: + the pretty_com.pl program was written for code generated by the MSVC + #import directive. It will assume the simple GetFoo/PutFoo naming. + Feel free to submit fixes for a more general program +*/ + +#if defined( _GNUC_ ) +// original offsetof will warn on GCC so below will turn this warning off +// 128 is to avoid alignment fix ups. +# undef offsetof +# define offsetof(s,m) ( ((size_t)&( ((s*)128)->m )) - 128 ) +#endif + +#ifdef _MSC_EXTENSIONS +/*compiled under msvc with extentions turned on (default for msvc)*/ + +#define DECLARE_PROP_CLASS( aclass ) + +#define ALL_P( type ,name )\ +__declspec(property(get=Get##name,put=Put##name))\ +type name ; + +#define GET_P( type ,name )\ +__declspec(property(get=Get##name))\ +type name ; + +#define PUT_P( type ,name )\ +__declspec(property(put=Put##name))\ +type name ; + +#define ALL_PROP( type ,name ,get_f ,put_f)\ +__declspec(property(get=get_f,put=put_f))\ +type name ; + +#define GET_PROP( type ,name ,get_f)\ +__declspec(property(get=get_f))\ +type name ; + +#define PUT_PROP( type ,name ,put_f)\ +__declspec(property(put=put_f))\ +type name ; + +#else //_MSC_EXTENSIONS +/*compiled with other c++ (not msvc) compiler, or without extentions turned on */ + +#define DECLARE_PROP_CLASS( aclass ) typedef aclass __this_class__ ; + +#define ALL_P( type ,name )\ + class prop_func_##name{public: \ + __this_class__& MyClass() \ + { char* p = (char*)this - offsetof(__this_class__,name) ; \ + return *((__this_class__*)p) ; \ + } \ + operator type(){return MyClass().Get##name();} \ + type operator =(type val){MyClass().Put##name(val);return val;} \ + } name ; + +#define GET_P( type ,name )\ + class prop_func_##name{public: \ + __this_class__& MyClass() \ + { char* p = (char*)this - offsetof(__this_class__,name) ; \ + return *((__this_class__*)p) ; \ + } \ + operator type(){return MyClass().Get##name();} \ + } name ; + +#define PUT_P( type ,name )\ + class prop_func_##name{public: \ + __this_class__& MyClass() \ + { char* p = (char*)this - offsetof(__this_class__,name) ; \ + return *((__this_class__*)p) ; \ + } \ + type operator =(type val){MyClass().Put##name(val);return val;} \ + } name ; + +#define ALL_PROP( type ,name ,get_f ,put_f)\ + class prop_func_##name{public: \ + __this_class__& MyClass() \ + { char* p = (char*)this - offsetof(__this_class__,name) ; \ + return *((__this_class__*)p) ; \ + } \ + operator type(){return MyClass().get_f();} \ + type operator =(type val){MyClass().put_f(val);return val;} \ + } name ; + +#define GET_PROP( type ,name ,get_f)\ + class prop_func_##name{public: \ + __this_class__& MyClass() \ + { char* p = (char*)this - offsetof(__this_class__,name) ; \ + return *((__this_class__*)p) ; \ + } \ + operator type(){return MyClass().get_f();} \ + } name ; + +#define PUT_PROP( type ,name ,put_f)\ + class prop_func_##name{public: \ + __this_class__& MyClass() \ + { char* p = (char*)this - offsetof(__this_class__,name) ; \ + return *((__this_class__*)p) ; \ + } \ + type operator =(type val){MyClass().put_f(val);return val;} \ + } name ; + +#endif //_MSC_EXTENSIONS + +/* +Implementation notes: +1) + the trick is in the MyClass() member of each property. it will calculate + the containing class address from its own (this) address. + Since properties are size less - [Q] what will be the offset of such a property? + + Yes you guest right! always 0. where ever it will be declared inside the class and + as many as there are. So in effect above can Just be: "return this;". + and the all offset-of warnings can be avoided. Now, not that I think that any compiler + on any imaginable machine will ever produce a different code. Its Just that I do + Imagine a long class hierarchy that have special properties with none zero size. + So I'll leave the code as is. It is clearer this way and the optimizer will always + remove the -0 operation. So it is only for us programmers. + +2) + Originally I have tried to keep the __declspec( property (get=xxx,put=yyy) ) syntax + but since I absolutely needed a macro, and macros can not be overloaded + the only close syntax I could achieve was + __declspec( property ((get=xxx,put=yyy)) ) with double brackets on the inside. And I do + need the type inside the macro - something like: + __declspec( property<type_name> ((get=xxx,put=yyy)) ) + Since code had to be changed any way (and it is more complicated) I did it as above. + +[Q] Student exercise: + Original ms-extension will also let you define an Array of properties where the index + of the array is supplied as parameter to the function member. + +Example: + __declspec( property (get=GetArray) ) + double Array[117] ; + double GetArray(size_t index) ; + ... + double f = Foo.Array[17] ; +How would you extend the above to support such syntax? +(When I ever see such code used I'll supply a fix) +*/ + +#endif //__pretty_com_h__ --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ include/wine/uuidof.h 2004-02-09 14:55:24.000000000 +0200 @@ -0,0 +1,145 @@ +/* + * Description: + * + * __decelspec(uuid()) and __uuidof are Microsoft extensions to the C++ compiler that lets you attach + * a GUID (128 bit number) to a class/struct and than retrieve it by the use of __uuidof + * + * below code tries to do that. + * any code using __uuidof does not change and expected run time is identical to MSVC. + * declareations of the uuid has to change. There are two alternatives. + * 1) Leave __declspec(uuid(...)) has is. Which is #defined to nothing in wine. Than + collect all uuid classes used in your project into one .CPP file + and use the MAKE_UUIDOF??? macros to define them. + (other wise the linker will complain) + * 2) Use the pretty_com.pl script to change all __declspec(uuid(...)) to the __decelspec_uuid2(...,InterfaceName) + macro. That will do a similar thing to the above but can survive in an header. + (or change these declarations manually) + + * Copyright (C) the Wine project + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#ifndef WINE_UUIDOF_H_ +#define WINE_UUIDOF_H_ + +#if defined( __cplusplus ) && \ + !defined ( _WINE_NO_UUIDOF_ ) && \ + !defined (_MSC_VER) && \ + defined (__GNUC__) + +extern "C++" { + +/* + at first I tried to use macros but ATL, who all this work was for, + uses __uuidof in template parametrization, which forces me to use template too. + Any way with templates the solution becomes trivial, much simpler + than macros. (the ones I had) please send comments to boaz(a)hishome.net + I would love to talk about it. +*/ +template< class T> +struct hold_uuidof +{ + static GUID __IID ; +}; + +} /*extern C++*/ + +/* + this is a nice one. In MSVC++ u can do: + __uuidof(Foo) __uuidof(pointer2Foo) __uuidof(refranceofFoo) + and __uuidof(classAFoo). The GCC typeof() will take care of that + (get it: use one's extension to implement another) +*/ +#define __uuidof( Q ) hold_uuidof< typeof(Q) >::__IID + +/* + use this macro to assosiate a guid to a class/struct. +*/ +#define MAKE_UUIDOF_ID( class ,IID ) \ + template<> \ + GUID hold_uuidof<class>::__IID = IID; + +/* + This one is the same as above but: + presupposes an IID_Interface was already defined +*/ +#define MAKE_UUIDOF( class ) \ + MAKE_UUIDOF_ID(class, IID_##class) + + +/* + [Q] why add more macros to the mess? + + uuid uses a registry notation of the form: + "12345678-1234-1234-1234-123456789ABC" + + the classic DEFINE_GUID will use +(IID_NAME ,0x12345678, 0x1234, 0x1234, 0x12,0x34, 0x12,0x34,0x56,0x78,0x9A,0xBC); + + it was easier for me to write a pearl script (see pretty_com.pl) and is more readable + if it was of the form: + ( 0x12345678, 0x1234, 0x1234, 0x1234, 0x123456789ABCLL, class ) + + to add to all the mess Microsoft MIDL compiler will use 2 other macros + DECLSPEC_UUID(x) MIDL_INTERFACE(x) which are the same only the later imposes + a struct definition. They expect a registry notation as uuid above. + Wine steers away from these macros by defining them to nothing. + + pretty_com.pl will translate all __declspec( uuid(X) ) instances to __declspec_uuid2(x,InterfaceName) + defined below. + + An alternative to __declspec_uuid2 and pretty_com.pl can be to use below MAKE_XXX macros + + What is MinGW-gcc position on all this? + +*/ + +#include <pshpack1.h> +struct betterguid{ + unsigned long Data1; + unsigned short Data2; + unsigned short Data3; + unsigned short Data4; + unsigned short Data5; + unsigned long Data6; +} ; +#include <poppack.h> + +#define INSTANTIATE_BETTER_GUID(ld1 ,sd2 ,sd3 ,sd4 ,ll5) \ + { ld1,sd2,sd3,sd4,ll5>>32, ll5&0xffffffff } + +#define DEFINE_IID( ld1 ,sd2 ,sd3 ,sd4 ,ll5 ,class ) \ +__attribute__((weak)) betterguid a##class = INSTANTIATE_BETTER_GUID(ld1 ,sd2 ,sd3 ,sd4 ,ll5) ;\ +EXTERN_C const GUID IID_##class = *((GUID*)&a##class) ; + +#define DEFINE_CLSID( ld1 ,sd2 ,sd3 ,sd4 ,sd5 ,ld6 ,class ) \ + __attribute__((weak)) betterguid a##class = INSTANTIATE_BETTER_GUID(ld1 ,sd2 ,sd3 ,sd4 ,ll5) ;\ +EXTERN_C const GUID CLSID_##class = *((GUID*)&a##class) ; + +// make uuidof and IID_ in one shot +#define MAKE_IID( ld1 ,sd2 ,sd3 ,sd4 ,ll5 ,class ) \ +DEFINE_IID( ld1 ,sd2 ,sd3 ,sd4 ,ll5 ,class ) \ +MAKE_UUIDOF(class) ; + +#define __declspec_uuid2(ld1 ,sd2 ,sd3 ,sd4 ,ll5 ,class) + +// below is used by pretty_com.pl +#define __info_uuid( uuid_string ) + + +#endif /*defined( __cplusplus ) && !defined ( _WINE_NO_UUIDOF_ ) && !defined (_MSC_VER)*/ + +#endif /*ndef WINE_UUIDOF_H_*/ --- /dev/null 1970-01-01 02:00:00.000000000 +0200 +++ tools/pretty_com.pl 2004-02-10 15:47:21.000000000 +0200 @@ -0,0 +1,182 @@ +#!/usr/bin/perl -w + +# pretty_com.pl will try to crudely parse Microsoft C++ COM header files and fix them for compilation +# under GCC and other standard C++ compilers. + +# pretty_com.pl will change any occurrence of _declspec( property (get=,put=) ) +# to the proper macro invocation. An #include directive will be added to pretty_com.h where +# these macros are defined. +# +# pretty_com.pl will also take care of __declspec( uuid(?hhh-hhh?)). It will distinguish between 2 cases: +# 1) when it is a class declaration. - +# It will than change it to a __declspec_uuid2( 0xhhh,0xhhh ) macro compatible with uuidof.h header file. +# 2) when it is just a forward declaration. - +# It will change it to a __info_uuid(?hhh-hhh?) which is declared to nothing. +# +# (see ?pretty_com.h? and ?uuidof.h? for details.) + +# Usage: all arguments are filenames to be processed. +# Contents of "filename" will change. The old file will be saved in "filename.old" +# any file parsed is reported to stdout with a comment "changed" or "nothing to do" +# in the second case no .old file was created. +# [example:]> perl -w pretty_com.pl header1 [header2] .. +# + +# FIXME: Below code is made to cope with code generated by the #import directive of +# MSVC. I am afraid my scripting skills are very limited and a more robust approach +# should be used to cope with all variations of the declspec(property()) syntax. +# mainly it will rely on exactly 1 new-line between the __declspec(property()) and the variable declaration. +# Please some one with better scripting skills, check the code and remove this FIXME +# Free Life boaz(a)electrozaur.com + + +use warnings; + +$class_decl = "" ; +$newuuid = "" ; + +# input is in $class_decl - it is the string from "struct" | "class" all the way up to the "{" or ";" +# output is in $newuuid - comma delimited and 0x appended to each hive. +# Example: +# __declspec(uuid("12345678-1234-1234-1234-123456789ABC") +# changes to +# 0x12345678,0x1234,0x1234,0x1234,0x123456789ABCLL +sub ExtractUuid +{ + $newuuid = $class_decl ; + + if( $newuuid =~ s/^.*__declspec[\s]*$[\s]*uuid[\s]*\([\s]*\"(.*)\"[\s]*$[\s]*\)[\s]*(\w*)[\s]*.*/0x$1LL,$2/ ) + { + $newuuid =~ s/-/,0x/g ; + $newuuid =~ s/\n//g ; + $newuuid =~ s/{//g ; + $newuuid =~ s/;//g ; +# $newuuid = "0x" . $newuuid ; + print $newuuid . "\n"; + } +} + +# input - reference to Input-File as first param, $_ contains the first line containing the keyword struct|class +# output - +# return: +# true - A class declaration was found +# false - A forward declaration ending with ";" +# $class_decl: +# will contain all the class declaration from the key word class|struct up to including +# the "{" or ";" +# InFile: is positioned pass the "{" | ";" + +sub readUntilB +{ + $InFile = shift ; + $read_lines = "" ; + do { + if ( $_ =~ /{/ ) { + $pos_of_B = index($_ ,"{") ; + $offset_from_end = $pos_of_B - length($_) + 1; # we need a negative number + seek( $InFile ,$offset_from_end ,1 ) ; + $read_lines .= substr $_ ,0 , ($pos_of_B) + 1; + $class_decl = $read_lines ; + return 1 ; + } elsif ( $_ =~ /;/ ) { + $class_decl = $read_lines . $_ ; + return 0 ; + } else { + $read_lines .= $_ ; + } + }while ( <$InFile> ) +} + +foreach $InFileName (@ARGV) +{ + open( InFile ,$InFileName) or die "Cant open $InFileName !"; + print "Proccessing $InFileName - " ; + + $LastInclude = 0 ; + $curLine = 0 ; + $Has_property = 0 ; + $Include_pretty_com = "#include <pretty_com.h>" ; + + #first pass see if anything to do and find a good place for the #include statment + # which is after any include but before any uuid or property + while( <InFile> ) + { + $curLine += 1 ; + if( ! $Has_property ) { + $LastInclude = $curLine if(/#include/) ; + } + $Has_property = 1 if( (/__declspec[\s]*$[\s]*property/) || (/__declspec[\s]*\([\s]*uuid/)) ; + } + + if( $Has_property ) + { + $OutFileName = "$InFileName.new" ; + open( OutFile,">$OutFileName") or die "Cant open $OutFileName !" ; + + $curLine = 0 ; + seek( InFile ,0 ,0 ) ; + while( <InFile> ) + { + # if we find class or struct fix that up + if( ($_ =~ /struct/) || ($_ =~ /class/) ) { + if( readUntilB(\*InFile) ) { + ExtractUuid() ; + print OutFile "__declspec_uuid2" . "(" . $newuuid . ")\n" ; + $class_decl =~ s/__declspec[\s]*\([\s]*uuid[\s]*\([\s]*"(.*)"[\s]*$[\s]*\)//; + @decl_ = split ':' , $class_decl ; + $BaseClassname = pop @decl_ ; + $Classpart = pop @decl_ ; + if( !$Classpart ) { + $Classpart = substr($BaseClassname ,0 ,length($BaseClassname) - 1); + } + @ClassNameToks = split ' ', $Classpart ; + $Classname = pop @ClassNameToks ; + + print OutFile $class_decl ; + print OutFile "\nDECLARE_PROP_CLASS($Classname)" ; + } else { + ExtractUuid() ; + $class_decl =~ s/__declspec[\s]*$[\s]*uuid\((.*)$\)/__info_uuid($1)/; + print OutFile $class_decl ; + } + # if we find __declspec\(property fix that up + } elsif ($_ =~ /__declspec\(property/) { + chomp; + $decl = $_; + chop ($nextline = <InFile>); + $nextline =~ s/;//g; + @words = split ' ', $nextline; + $id = pop @words; + $type = join ' ', @words; + if (($decl =~ /get=/) and ($decl =~ /put=/)) { + print OutFile ("\tALL_P( $type\t, $id );\n"); + } + elsif ($decl =~ /get=/) { + print OutFile ("\tGET_P( $type\t, $id );\n"); + } + elsif ($decl =~ /put=/) { + print OutFile ("\tPUT_P( $type\t, $id );\n"); + } + # default copy lines to new file - put include in place + } else { + print OutFile $_ ; + $curLine += 1 ; + if( $curLine == $LastInclude ){ + print OutFile $Include_pretty_com ; + } + } + } + close(InFile) ; + close(OutFile) ; + + # until now Output was done to FileName.new rename orignal file to .old and make new one the file +# rename( $InFileName ,"$InFileName.old" ) or print "Cant rename $InFileName to .old\n" ; +# rename( $OutFileName ,$InFileName ) or print "Cant rename $OutFileName to $InFileName\n" ; + + print "changed!\n" ; + } + else { + print "nothing to do\n"; + } + +}

1 0

Re: wineinstall hangs
by Ivan Leo Murray-Smith 11 Mar '04

11 Mar '04

> I don't know but I thought that ./configure would pick up everything I have > or not and react accordingly. It's bad if the install fails before it's even finished. > What's GLX? It's not mentioned in my XF86Config and locate GLX only > produced two man entries. My graphic card is a Diamond Stealth 64 PCI. I'm no graphics expert, but IIRC GLX is a X extension that SGI invented so that X could use openGL. If it's missing, chances are you don't a have 3D driver for your card, or it isn't configured properly. Look for a good driver for your video card, or check the configuration. If you don't need 3D graphics, you can ignore the Xlib: extension "GLX" missing on display ":1.0". message, or use mesa (But it's very slow). Ivan.

1 0

Is Wine CVS broken?
by Erik de Castro Lopo 11 Mar '04

11 Mar '04

Hi all, I've been following Wine CVS for about a week now. I just did and "cvs checkout" and the resulting source tree no longer configures/compiles. The problems seem to relate to the following directories: dlls/amstream dlls/dxerr8 dlls/dxerr9 which seem to have been added or removed very recently. I tried hacking around in the configure script but couldn't get it to work. Cheers, Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo nospam(a)mega-nerd.com (Yes it's valid) +-----------------------------------------------------------+ I hack, therefore I am.

4 4

Contribution offer: Localization work
by Christian Britz 10 Mar '04

10 Mar '04

Hi, I am an enthusiastic wine user from Germany. You write on your website that you are looking for contributors that are willing to do localization work. I do have very good german language skills and I also have a good understanding of the english language. Although I do not have very good C programming skills I have good general understanding of general application development. I work as Java and ... VBA ... programmer and I also have some experience in the Unix environment and web development. Because I like writing, I offer to you to participate in the translation of wine documents to german. A good start would be the README I think. If you are interested in my help, please contact me! Regards and thank you for the good work! Christian Britz Germany

4 11

OT: How to patch?
by Fabian Cenedese 10 Mar '04

10 Mar '04

Hi Not directly wine related but I'm sure also useful to others. It was said on this list that the patches should be able to be applied with patch (-p1) patch.diff, hence the inlining in the mail. But the patch tool doesn't know anything about cvs. In the generated patch are infos about the diff'd versions. So for applying a patch in my view it would be best to update the sandbox to the version mentioned in the patch, apply the patch (which should work without error), then update to HEAD again. Because if you don't have the same file (maybe because the patch was from an older version) it won't apply anymore. I know that the unified format helps if there were small changes. Isn't there a way to do it with cvs? I mean it can generate diffs, maybe also apply (but I didn't find anything in the manual). Or general question: How do others work with patches? Always with the patch tool? Any switches I overlooked? (This problem came up as I'm trying to create and maintain a patch so it can be applied to the official distribution. But that's somehow useless if it won't work with newer versions than the one were the patch was created against, hence my idea with updating back and forth.) Thanks bye Fabi

1 0

Re: wine/. ANNOUNCE ChangeLog VERSION configure
by Vincent Béron 10 Mar '04

10 Mar '04

Le mar 09/03/2004 à 22:37, Alexandre Julliard a écrit : > ChangeSet ID: 11411 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/03/09 21:37:58 > > Modified files: > . : ANNOUNCE ChangeLog VERSION configure > > Log message: > Release 20040309. Unfortunately, I won't have time until the week-end to produce the binaries for various RH versions. Vincent

1 0

(fwd) Re: Serial port communication
by Rein Klazes 10 Mar '04

10 Mar '04

Hi, A bug reported in the users list. Because the reporter prefers just to work around the problem in his own code, I forward it here. In short: ReadFile reads a single byte alright from the serial port but at the same time returns an error GLE = ERROR_INVALID_PARAMETER. With multiple bytes there are no problems. There is a code snippet in the attached message. Rein. -- Rein Klazes rklazes(a)xs4all.nl

1 0

Re: [DMUSIC] Improve dmusic loading
by Alexandre Julliard 10 Mar '04

10 Mar '04

Raphael <fenix(a)club-internet.fr> writes: > Changelog: > - debugstr_DMUS_OBJECTDESC more readable (not more limited to the 200 > characters of wine_dbg_sprintf) You should make it a separate dumping function instead of returning a single string, if the info is too large. Using a static buffer is not thread-safe. -- Alexandre Julliard julliard(a)winehq.org

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel