wine-devel

wine-devel@winehq.org

9 participants
84457 discussions

Regarding Coverity
by Fabian Maurer 12 Dec '22

12 Dec '22

Hello, I'm sometimes working through the issues Coverity scan reported, and I come across a lot of issues that I consider false positives. I however am not 100% comfortable marking them as such, just in case I am wrong... What's the policy on that? Are those getting reviewed by other devs? Should I just mark them as false positives if I think they are? Regards, Fabian Maurer

2 1

Code freeze plans
by Alexandre Julliard 12 Dec '22

12 Dec '22

Folks, As you know, we are now in code freeze towards 8.0. This means that only reasonably small, targeted bug fixes can be accepted. As far as possible, please mention the bug number that the fix is for. We currently have 242 open regressions (cf. https://source.winehq.org/regressions) I'm hoping that we can release 8.0 with fewer open regressions than 7.0, which means we have to bring that number down to 150. All help is welcome! Fixes to the tests can always be accepted since they can't break apps, so this is also a good opportunity to fix some long-standing failures. The rc releases will be a bit more spread out than usual, because I'll be out during the Christmas break. My plan is to have rc2 on December 21, rc3 on January 6, and then resume weekly rc releases, with a final 8.0 towards the end of January. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine staging 8.0-rc1 release
by Alistair Leslie-Hughes 12 Dec '22

12 Dec '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.0-rc1 (473 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * winegstreamer: Implement MF_SD_LANGUAGE. Added: * None Updated: * none Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

3 3

Wine Source build on native wchar_t 4 bytes
by Mahin Pandya 05 Dec '22

05 Dec '22

Hello All, We are trying to build Wine Source on Linux with native wchar_t size 4 bytes (instead of 2 bytes), is there any way it can be done? I started with doing following changes: diff --git a/tools/winapi/winapi_test b/tools/winapi/winapi_test index b9628e8..91daac3 100644 --- a/tools/winapi/winapi_test +++ b/tools/winapi/winapi_test @@ -206,7 +206,11 @@ sub _find_align_kind_size($) { $align = 2; $kind = "signed"; $size = 2; - } elsif (/^(?:char16_t|wchar_t|USHORT|WCHAR|WORD)$/) { + } elsif (/^(?:wchar_t|WCHAR)$/) { + $align = 4; + $kind = "unsigned"; + $size = 4; + } elsif (/^(?:char16_t|USHORT|WORD|WCHAR_nt)$/) { $align = 2; $kind = "unsigned"; $size = 2; Also started changing some of headers e.g. winnt.h - removed "typedef unsigned short WCHAR;" Any pointers/suggestion are welcome. Thanking you. regards, Mahin

6 11

Re: [PATCH 1/1] mstask: Don't assume a ONCE trigger is on the current day.
by Dmitry Timoshkov 02 Dec '22

02 Dec '22

Sven Baars <wine(a)gitlab.winehq.org> wrote: > - if (CompareFileTime(&begin_ft, &trigger_ft) <= 0 && CompareFileTime(&trigger_ft, &end_ft) < 0) > + if (CompareFileTime(&trigger_ft, &current_ft) >= 0) > { > if (!have_best_time || CompareFileTime(&trigger_ft, &best_ft) < 0) > { Removing the trigger end time check doesn't look right. -- Dmitry.

1 0

Using comdlg32 functions in shell32
by Alex Henrie 02 Dec '22

02 Dec '22

Hello, Does anyone know why shell32 uses LoadLibrary and GetProcAddress to get pointers to GetOpenFileName[AW] in comdlg32, rather than simply importing the library? https://gitlab.winehq.org/wine/wine/-/blob/wine-7.22/dlls/shell32/shellord.… https://gitlab.winehq.org/wine/wine/-/blob/wine-7.22/dlls/shell32/dialogs.c… I was about to rip this code out, but I want to make sure that it exists only by historical accident and no longer has a purpose. -Alex

2 1

Can we use Windows Kits idl files?
by James McDonnell 29 Nov '22

29 Nov '22

Are the Windows Kits SDK WinRT .idl files acceptable to read-rework inside the wine source? They are akin to header files, no? I asked on the irc but didn't get any reply. There was a follow up comment asking about ReactOS headers as well: > on the topic of headers, are we allowed to look at ReactOS NDK headerS > s/headerS/headers/ > they contain internal structure definitions only, nothing else Thank you, James

2 2

Wine staging 7.22 release
by Alistair Leslie-Hughes 27 Nov '22

27 Nov '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.22 (474 patches are applied to wine vanilla) The number is quiet lower compared to the previous version due to the disabling of the nvidia dll patchesets. Upstreamed (Either directly from staging or fixed with a similar patch). * ntdll: Add support for FreeBSD style extended attributes. Added: * None Updated: * ntdll-DOS_Attributes Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Bug 52263 - Deadlock in dinput
by Fabian Maurer 20 Nov '22

20 Nov '22

Hello, you committed a fix for Bug 52263, but I think that only masks the issue, not really fixing it. Your fix is here: https://gitlab.winehq.org/wine/wine/-/commit/ 7e5eeecdfb5c90042945d9e84a3a9f8b2ed0036a I described what happens in https://bugs.winehq.org/show_bug.cgi?id=52314#c4 I think we can only time out in this wait, so this doesn't seem right. Could you please take a second look? Regards, Fabian Maurer

2 2

Cuda Applications on Wine - suggesting to merge wine-staging/patches/nvcuda-CUDA_Support patches into upstream wine.
by Alois Schlögl 16 Nov '22

16 Nov '22

I'd like suggesting to merge the 17 patches from wine-staging/patches/nvcuda-CUDA_Support patches into upstream wine for the following reasons: Currently Cuda applications for Windows do not run in native Wine. Such an application is Warpem (available for Windows only), and CUDA-Z for Windows. I assume there are other applications as well. This could be fixed by pulling in the 17 patches wine-staging/patches/nvcuda-CUDA_Support. Possible disadvantages: - build dependency to cuda - some distros might not want to have a build dependency on cuda.h That's the choice of the package manager, but this should be endorsed and recommended for the above reason. - run-time dependency on cuda wine does not have a runtime dependency on cuda (probably due to dynamic linking) e.g. cuda-z can be started under wine, and stops gracefully with a message the cuda is not available. - number of APIs to maintain is currently done anyway (by the wine-staging team) From a the perspective of some application, Cuda is part of the operating system should be provided by the platform (Wine in our case). Overall, it seems merging the nvcuda-CUDA_Support into upstream Wine are the right thing to do. Best regards, Alois

7 8

Wine 8.0 code freeze
by Alexandre Julliard 14 Nov '22

14 Nov '22

Folks, With the end of the year approaching, it will soon be time to start the code freeze towards Wine 8.0. My plan is to have another two development releases, and start code freeze with Wine 7.23, on December 9. So if there are things that you want in 8.0, you have another 4 weeks to get them upstreamed... -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine staging 7.21 release
by Alistair Leslie-Hughes 13 Nov '22

13 Nov '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.21 (495 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * mshtml: Add IHTMLLocation::hash property's getter implementation. * uxtheme: Protect CloseThemeData() from invalid input. * user32/tests: Add some tests to see when MessageBox gains WS_EX_TOPMOST style. * user32: MessageBox should be topmost when MB_SYSTEMMODAL style is set. Added: * None Updated: * eventfd_synchronization * ntdll-Syscall_Emulation * ntdll-ForceBottomUpAlloc Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

3 2

Upcoming vkd3d 1.6 release.
by Henri Verbeet 10 Nov '22

10 Nov '22

Hi all, We'd like to release vkd3d 1.6 in about 4 weeks. As we're nearing that date, the vkd3d tree is going to become progressively frozen, starting today. Now is the time to test your applications for any regressions, review any API changes since vkd3d 1.5, review and improve the API documentation, and so on. The next release, vkd3d 1.7, is tentatively planned for late March next year. Regards, Henri

1 0

Winelib stack overflow
by Vitor Ramos 07 Nov '22

07 Nov '22

Hello, I am not sure if this is the appropriate channel but here we go. I am trying to port a windows c++ application using winelib and I found an issue while using some c++ STL containers. Here is a minimal example: # winelib.dll.so ```c++ #include <windows.h> #include <unordered_map> #include <string> extern "C" int f1(long z) { std::unordered_map<int, std::string> y; return 10; } spec file ```c++ 2 stdcall f1(long) ``` # Building winelib.dll.so winemaker --console --dll . winebuild --implib -E winedll.spec -o libwinedll.a winebuild --fake-module --dll -E winedll.spec -o winedll.dll make cp libwinedll.a winedll.dll.so /usr/local/lib/wine/x86_64-unix cp winedll.dll /home/$USER/.wine/drive_c/windows/system32 win64 app ```c++ #include <iostream> extern "C"{ int f1(long z); } int main(){ int ret = f1(2); std::cout << ret << std::endl; } ``` # Building win64 app winemaker . -iwinedll make # Running wine64 win64app.exe.so # Output 0110:err:virtual:virtual_setup_exception stack overflow 2128 bytes in thread 0110 addr 0x17008c804 stack 0x207b0 (0x20000-0x21000-0x120000) If I remove the "std::unordered_map<int, std::string> y" from the custom lib it runs normally. I suspect that wine uses too much of the stack to construct the object, but it's just a wild guess. Does anybody know what the issue could be? Is it possible to increase the stack size? Thanks.

3 4

TestBot News
by Francois Gouget 07 Nov '22

07 Nov '22

* The TestBot has a new Windows 11 VM. It's a new Windows version so it has almost 40 extra failures. To avoid false positives it's only going to be running WineTest until the new failures have been flagged. But you can already select it in the list of available VMs to run tests on it. * There are now two PCI-Passthrough configurations: - w11pro64_amd -> AMD RX6600 GPU - w11pro64_nv -> NVIDIA RTX3050 GPU These have a surprising number of extra failures, about 12, when fgtb-w10pro64-rx550 only has about 2 extra failures. So I will recheck the configuration of the new VMs (on the AMD side it may have the clipboard problem again, but then a number of failures appeared to be in the d3d tests). These are also only running WineTest for now so as to not cause false positives but you can select them in the list of available VMs. -- Francois Gouget <fgouget(a)codeweavers.com>

1 2

invalid read errno bug
by xantares09＠hotmail.com 01 Nov '22

01 Nov '22

Hello, I'm hoping to get more attention for this bug report that have not been confirmed yet: https://bugs.winehq.org/show_bug.cgi?id=53677 Everything should be provided to ease reproducing, Regards

1 0

Wine staging 7.20 release
by Alistair Leslie-Hughes 01 Nov '22

01 Nov '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.20 (504 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * sapi: Implement ISpObjectToken OpenKey * sapi: EnumTokens setup enumeration members * sapi: Implement ISpObjectTokenEnumBuilder Item * sapi: Add default voice registry key * sapi: Return dump object in ISpObjectTokenEnumBuilder Next Added: * None Updated: * nvcuda-CUDA_Support * mfplat-streaming-support Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: ntdll: Fix build on systems without ENODATA (was: [PATCH] ntdll: Complete error case in get_initial_environment)
by Erich E. Hoover 19 Oct '22

19 Oct '22

On Wed, Oct 19, 2022 at 3:05 PM Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > > On Wed, 19 Oct 2022, Erich E. Hoover wrote: > >> https://gitlab.winehq.org/wine/wine/-/merge_requests/1097 > > It looks like this just got merged. Gerald, would you check and see > > if ENOATTR is defined on your system? > > I checked, and FreeBSD (12 and 14, so current and future versions) both > define ENOATTR guarded by #ifndef _POSIX_SOURCE, so generally available. > > > This commit removes the compile warning > > It actually was hard build error. Yes, sorry - I misspoke. > > but you're going to get a lot of unnecessary console warnings > > ("attribute does not exist" is not an error here). > > Is it possible Alexandre's adjusted version of my submission avoids this? > ... No. If the filesystem supports extended attributes (!ENOTSUP) then you will get an error if there aren't any xattr for the file. I suspect that we either want: === #ifdef ENODATA if (errno == ENODATA) return ret; #endif #ifdef ENOATTR if (errno == ENOATTR) return ret; #endif === Or we want to do something like this: === #ifndef ENOATTR #define ENOATTR ENODATA #endif === and then check against ENOATTR instead (little bit of research says that platforms that define both use ENOATTR in this case). Best, Erich

1 0

Re: [PATCH] ntdll: Complete error case in get_initial_environment
by Esme Povirk (any/all) 19 Oct '22

19 Oct '22

> That's more involved than the previous process, but I think I got it: > https://gitlab.winehq.org/gerald/wine/-/commit/2bdbfb583452a62c7d6acf7f416b… > > Is there anything else to do? I found the actual MR at https://gitlab.winehq.org/wine/wine/-/merge_requests/1097, and it looks right to me. Nothing else to do for now, hopefully someone will come along and review it. > PS: It shows the test-linux32 pipeline as failed, while the other two > succeeded; looks like a false positive to the, though. Yes, those errors have been showing up for every MR. -- https://my.pronouns.page/are/any

2 1

Wine staging 7.19 release
by Alistair Leslie-Hughes 17 Oct '22

17 Oct '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.19 (502 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * winegstreamer: Return S_OK from H264 decoder GetAttributes. * Implement retrieving DOS attributes in [fd_]get_file_info(). * ntdll: Implement storing DOS attributes in NtSetInformationFile. * ntdll: Implement storing DOS attributes in NtCreateFile. * sapi: Implement ISpObjectToken GetId * secur32: Input Parameter should be NULL on first call to InitializeSecurityContextW. * sapi: Implement ISpRegDataKey CreateKey * sapi: Implement ISpRegDataKey GetStringValue * ntdll: Improve stub of NtQueryEaFile. * winegstreamer: Reimplement AAC decoder using wg_transform. Added: * None Updated: * ntdll-DOS_Attributes * wined3d-bindless-texture * ntdll-Junction_Points Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: fixing some fixme code
by Jin-oh Kang 16 Oct '22

16 Oct '22

On Mon, Sep 12, 2022, 11:11 AM Owen Hogarth <gurenchan(a)gmail.com> wrote: > Hello guys, I am trying to get this program; R Trader Pro to work on Linux. > I installed winetricks and then I received some different errors. > > I would like to fix the problem but I would also like to avoid doing > unnecessary work, that's why I am asking on the development mailing list. > > Here's the new error log, is it possible to get the program working? > ... > An error occured while contacting the license server. > > Raised in : com.omnesys.omne.om.OMField > Method : OMsetData > Error : no data > Raised in : 31004 1 unknown host 20014 1 unknown addr > > Method : OMaddData > Error : create error > Please contact Omnesys Technologies Inc., at www.omnesys.com. > Please launch the application or the installer with the following command line (without angle brackets): export WINEPREFIX="$HOME/.wine-traderpro-test" # (or whatever wineprefix path you prefer) WINEDEBUG=+winsock wine <path to exe...> Also, please make sure you don't use native DLLs from winetricks when debugging or reporting a bug.

2 8

[PATCH 1/2] qedit/tests: Check the Sample Grabber's buffer during and after flushing.
by Gabriel Ivăncescu 04 Oct '22

04 Oct '22

Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/qedit/tests/samplegrabber.c | 234 +++++++++++++++++++++++++++++++ 1 file changed, 234 insertions(+) diff --git a/dlls/qedit/tests/samplegrabber.c b/dlls/qedit/tests/samplegrabber.c index 8e68e3e..e66180f 100644 --- a/dlls/qedit/tests/samplegrabber.c +++ b/dlls/qedit/tests/samplegrabber.c @@ -1036,6 +1036,239 @@ static void test_connect_pin(void) ok(!ref, "Got outstanding refcount %d.\n", ref); } +struct frame_thread_params +{ + IMemInputPin *sink; + IMediaSample *sample; + DWORD delay; +}; + +static DWORD WINAPI frame_thread(void *arg) +{ + struct frame_thread_params *params = arg; + HRESULT hr; + + if (params->delay) + { + if (winetest_debug > 1) trace("%04x: Sleeping %u ms.\n", GetCurrentThreadId(), params->delay); + Sleep(params->delay); + } + if (winetest_debug > 1) trace("%04x: Sending frame.\n", GetCurrentThreadId()); + hr = IMemInputPin_Receive(params->sink, params->sample); + if (winetest_debug > 1) trace("%04x: Returned %#x.\n", GetCurrentThreadId(), hr); + IMediaSample_Release(params->sample); + free(params); + return hr; +} + +static HANDLE send_frame_time(IMemInputPin *sink, REFERENCE_TIME start_time, unsigned char color, DWORD delay) +{ + struct frame_thread_params *params = malloc(sizeof(*params)); + IMemAllocator *allocator; + REFERENCE_TIME end_time; + IMediaSample *sample; + HANDLE thread; + HRESULT hr; + BYTE *data; + + hr = IMemInputPin_GetAllocator(sink, &allocator); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IMemAllocator_GetBuffer(allocator, &sample, NULL, NULL, 0); + if (hr == VFW_E_NOT_COMMITTED) + { + IMemAllocator_Commit(allocator); + hr = IMemAllocator_GetBuffer(allocator, &sample, NULL, NULL, 0); + } + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IMediaSample_GetPointer(sample, &data); + ok(hr == S_OK, "Got hr %#x.\n", hr); + memset(data, 0x55, 32 * 16 * 2); + + hr = IMediaSample_SetActualDataLength(sample, 32 * 16 * 2); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + start_time *= 10000000; + end_time = start_time + 10000000; + hr = IMediaSample_SetTime(sample, &start_time, &end_time); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + params->sink = sink; + params->sample = sample; + params->delay = delay; + thread = CreateThread(NULL, 0, frame_thread, params, 0, NULL); + + IMemAllocator_Release(allocator); + return thread; +} + +static HANDLE send_frame(IMemInputPin *sink, DWORD delay) +{ + return send_frame_time(sink, 0, 0x55, delay); /* purple */ +} + +static HRESULT join_thread_(int line, HANDLE thread) +{ + DWORD ret; + ok_(__FILE__, line)(!WaitForSingleObject(thread, 1000), "Wait failed.\n"); + GetExitCodeThread(thread, &ret); + CloseHandle(thread); + return ret; +} +#define join_thread(a) join_thread_(__LINE__, a) + +static void test_buffer_flush(void) +{ + AM_MEDIA_TYPE req_mt = + { + .majortype = MEDIATYPE_Video, + .subtype = MEDIASUBTYPE_RGB565, + .formattype = FORMAT_VideoInfo, + .bTemporalCompression = TRUE, + }; + LONG buf[(32 * 16 * 2) / sizeof(LONG)], size = sizeof(buf); + IPin *sink, *source, *renderer_pin; + struct testfilter testsource; + ISampleGrabber *grabber; + IMediaControl *control; + IFilterGraph2 *graph; + IMemInputPin *input; + IBaseFilter *filter; + OAFilterState state; + IMediaFilter *mf; + HANDLE thread; + DWORD ticks; + unsigned i; + HRESULT hr; + ULONG ref; + + testfilter_init(&testsource); + CoCreateInstance(&CLSID_FilterGraph, NULL, CLSCTX_INPROC_SERVER, + &IID_IFilterGraph2, (void **)&graph); + CoCreateInstance(&CLSID_NullRenderer, NULL, CLSCTX_INPROC_SERVER, + &IID_IBaseFilter, (void **)&filter); + IFilterGraph2_AddFilter(graph, filter, L"sink"); + IBaseFilter_FindPin(filter, L"In", &renderer_pin); + IBaseFilter_Release(filter); + + filter = create_sample_grabber(); + IFilterGraph2_AddFilter(graph, &testsource.filter.IBaseFilter_iface, L"source"); + IFilterGraph2_AddFilter(graph, filter, L"sample grabber"); + IBaseFilter_FindPin(filter, L"In", &sink); + IBaseFilter_FindPin(filter, L"Out", &source); + IBaseFilter_QueryInterface(filter, &IID_ISampleGrabber, (void **)&grabber); + IFilterGraph2_QueryInterface(graph, &IID_IMediaControl, (void **)&control); + IPin_QueryInterface(sink, &IID_IMemInputPin, (void **)&input); + + ISampleGrabber_SetMediaType(grabber, &req_mt); + ISampleGrabber_SetBufferSamples(grabber, TRUE); + + testsource.sink_mt = &req_mt; + hr = IFilterGraph2_ConnectDirect(graph, &testsource.source.pin.IPin_iface, sink, &req_mt); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = IFilterGraph2_ConnectDirect(graph, source, renderer_pin, &req_mt); + ok(hr == S_OK, "Got hr %#x.\n", hr); + IPin_Release(renderer_pin); + + IFilterGraph2_QueryInterface(graph, &IID_IMediaFilter, (void **)&mf); + IMediaFilter_SetSyncSource(mf, NULL); + IMediaFilter_Release(mf); + + hr = IMemInputPin_ReceiveCanBlock(input); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ok(hr == VFW_E_WRONG_STATE, "Got hr %#x.\n", hr); + + hr = IMediaControl_Pause(control); + ok(hr == S_FALSE, "Got hr %#x.\n", hr); + hr = IMediaControl_GetState(control, 0, &state); + ok(hr == VFW_S_STATE_INTERMEDIATE, "Got hr %#x.\n", hr); + + thread = send_frame(input, 0); + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(WaitForSingleObject(thread, 100) == WAIT_TIMEOUT, "Thread should block in Receive().\n"); + + for (i = 0; i < 3; i++) + { + ticks = GetTickCount(); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ticks = GetTickCount() - ticks; + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(ticks < 100, "Got %u ticks.\n", ticks); + ok(size == sizeof(buf), "Got size %d.\n", size); + } + + hr = IMediaControl_Stop(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = join_thread(thread); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(state == State_Stopped, "Got state %d.\n", state); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ok(hr == S_OK, "Got hr %#x.\n", hr); + + hr = IMediaControl_Pause(control); + ok(hr == S_FALSE, "Got hr %#x.\n", hr); + hr = IMediaControl_GetState(control, 0, &state); + ok(hr == VFW_S_STATE_INTERMEDIATE, "Got hr %#x.\n", hr); + + thread = send_frame(input, 0); + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(WaitForSingleObject(thread, 100) == WAIT_TIMEOUT, "Thread should block in Receive().\n"); + + for (i = 0; i < 3; i++) + { + ticks = GetTickCount(); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ticks = GetTickCount() - ticks; + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(ticks < 100, "Got %u ticks.\n", ticks); + ok(size == sizeof(buf), "Got size %d.\n", size); + } + + IPin_BeginFlush(sink); + hr = join_thread(thread); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ok(hr == S_OK, "Got hr %#x.\n", hr); + IPin_EndFlush(sink); + + hr = IMediaControl_GetState(control, 0, &state); + todo_wine ok(hr == VFW_S_STATE_INTERMEDIATE, "Got hr %#x.\n", hr); + + ticks = GetTickCount(); + thread = send_frame(input, 150); + hr = ISampleGrabber_GetCurrentBuffer(grabber, &size, buf); + ticks = GetTickCount() - ticks; + ok(hr == S_OK, "Got hr %#x.\n", hr); + ok(ticks < 100, "Got %u ticks.\n", ticks); + ok(size == sizeof(buf), "Got size %d.\n", size); + + hr = IMediaControl_GetState(control, 1000, &state); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = IMediaControl_Stop(control); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = join_thread(thread); + todo_wine ok(hr == S_OK, "Got hr %#x.\n", hr); + + IPin_Release(sink); + IPin_Release(source); + IMemInputPin_Release(input); + IMediaControl_Release(control); + ref = IFilterGraph2_Release(graph); + ok(!ref, "Got outstanding refcount %d.\n", ref); + ISampleGrabber_Release(grabber); + ref = IBaseFilter_Release(filter); + ok(!ref, "Got outstanding refcount %d.\n", ref); + ref = IBaseFilter_Release(&testsource.filter.IBaseFilter_iface); + ok(!ref, "Got outstanding refcount %d.\n", ref); +} + START_TEST(samplegrabber) { IBaseFilter *filter; @@ -1059,6 +1292,7 @@ START_TEST(samplegrabber) test_aggregation(); test_media_types(); test_connect_pin(); + test_buffer_flush(); CoUninitialize(); } -- 2.21.0

5 7

WineConf - starting next week!
by Jeremy White 29 Sep '22

29 Sep '22

Hi folks, We are excited to welcome you in person to the 2022 Wine Conference, held in conjunction with the X.org developers conference (XDC) and the FOSS XR conference. The XDC conference will start on Tuesday morning, October 4th. The program is here: https://indico.freedesktop.org/event/2/timetable/#all.detailed The official events start at 8:30 am, but we will have coffee and pastries available from 7:30 on Tuesday and 8 on Wednesday and Thursday. WineConf proper will start on Wednesday morning, October 5th, with Alexandre's keynote. We expect everyone attending to be vaccinated and to be respectful of people that are trying to avoid catching COVID. Masks are mandatory, except when presenting or eating. The plan is to gather at Brit's Pub, both Monday and Tuesday in the late afternoon to welcome arrivals. We’ll try to have a table with some sort of a sign, and folks can connect, have a drink, and then perhaps group up to explore alternate food. Note that if the weather is nice, we may be up on the roof, so explore far to find us. We will be on the Minneapolis campus of St. Thomas, which is a mildly confusing campus. We have given instructions and a picture to guide you here: https://indico.freedesktop.org/event/2/page/10-attending-xdc-wineconf-foss-… We are working on the remote experience, and expect to have streaming of all events available. The above page will have those details just as soon as they are finalized. We have a page of instructions for folks that will be presenting: https://indico.freedesktop.org/event/2/page/18-speaker-instructions We are also excited to announce the happy hour taking place on Wednesday, from 6:00 pm until 8:00 pm. The hope is that all three projects can mingle and socialize and enjoy the return of in person meetings. We will again use a Matrix chat room just for the conference. Matrix has a variety of apps, and Element, the default one is easy to configure on many devices, including mobile phones. The link to that channel is here: https://matrix.to/#/#xdc-wineconf-fossxr-2022:matrix.org We find the chat channel a good place to learn what restaurants and bars are chosen, and just a good way to track the social aspects of the conference. We look forward to seeing you next week! Cheers, Jeremy

1 0

Winelib portability on USB booted system
by Brent Burkholder 29 Sep '22

29 Sep '22

We had originally tried a software port using winelib 5, and it was just a no-go in functionality. Wine 7 is working a LOT better for what we're doing (Windows GUI with ability to do low level Linux hooks), so thank you all for all of the hard work! Unfortunately, even though the software is running great on our development machine, when I try to run it on another system (configured USB boot, should have the same version of wine, etc) it doesn't run at all with pretty much no feedback. Can anyone help me understand why, or what I need to be looking for? Both systems are starting with the same script (I've done a lot of variations, directly launching myself, and it doesn't seem to matter.) #!/bin/bash sudo env "PATH=/opt/wine-devel/bin:$PATH" /opt/wine-devel/bin/wine xerase.exe.so The compiling system starts right up. The USB boot system that I'm trying to run it on gives me 0078:fixme:wineusb:add_unix_device Interface 1 has 2 alternate settings; using the first one. Wine: failed to start L"F:\\home\\test\.wine\\drive_c\\XERASxlnx\\xerase.exe.so" Application could not be started, or no application associated with the specified file. ShellExecuteEx failed: File not found. If I do the command directly instead of through a script I get exactly the same thing. If I cut out the env path stuff (1), or keep the path but call just wine (2), or just call wine (bashrc has the path now) same results 1. sudo /opt/wine-devel/bin/wine xerase.exe.so 2. sudo env "PATH=/opt/wine-devel/bin:$PATH" wine xerase.exe.so 3. sudo wine xerase.exe.so 4. sudo wine /home/test/.wine/drive_c/XERASxlnx/xerase.exe.so 0078:fixme:wineusb:add_unix_device Interface 1 has 2 alternate settings; using the first one. Wine: failed to start L"F:\\home\\test\.wine\\drive_c\\XERASxlnx\\xerase.exe.so" Application could not be started, or no application associated with the specified file. ShellExecuteEx failed: File not found. So... observations... 1. Not sure where F: is coming from? C: I might understand (though frankly, I'd just as soon the program realize we're using the unix file structure, not any virtualized windows stuff for what we're doing) When I look at .wine/dosdevices on both systems... Build/working system: z: -> / c: -> ../drive_c <com devices> . .. Not working USB booted system: z: -> / c: -> ../drive_c d:: -> /dev/sda1 g:: -> /dev/sda f:: -> /dev/sd5 e:: -> /dev/sda2 <com devices> d: -> /boot/efi f: -> / . .. Any suggestions in changes to compilation or environmental variables to get wine to start running it? I guess I could delete d::, g::, f::, e::, d:, and f: and see if that makes a difference but figured I'd ask the question first Brent Burkholder Extreme Protocol Solutions bburk(a)extremeprotocol.com<mailto:bburk@extremeprotocol.com>

2 2

wine-7.0.1-rc1 Available
by Michael Stefaniuc 28 Sep '22

28 Sep '22

Hello, I have pushed wine-7.0.1-rc1 (217323fff7da7f318a30348b4665ace55d04c50b) to https://github.com/mstefani/wine-stable/tree/stable https://people.redhat.com/mstefani/wine/stable/ And created the draft merge request https://gitlab.winehq.org/wine/wine/-/merge_requests/955 Bugs and most other fixes are from the 7.1 to 7.8 era. Previous x.0.1 releases would include only stuff from x.1 to x.4 or x.5 devel versions to fill the "budget" of about 100 cherry picks. Also this is lowest amount of bugs fixed since 1.8.1. The "use long" commits were a major nuisance so I might have missed bugs due to the long patch dependency chains. If your favorite bug is missing please let me know. The rest of the commits picked are small and found by keywords in the commit message. The longer commit messages help here. There are a bunch of "newer" (> 7.8) commits and those are mostly there to fix the currently "broken in 7.0 too" tests. The usual plan is to wait for feedback for 7-10 days before the real 7.0.1 is released. There will be definitely a -rc2 as I need to cherry pick or backport some of the gitlab related commits. What's new in this release: - Various bug fixes - Translation updates ---------------------------------------------------------------- Bugs fixed in 7.0.1 (total 31): 12732 Nota Bene crashes on install 44202 undname.c fails to parse symbols with rvalue-reference semantics '&&' 45916 x64dbg fails to load debuggee, needs ThreadScheduler_ScheduleTask 50352 Maximum sockets per process is set very low 50370 Gothic 1 doesn't start correctly when screen resolution of the game matches display resolution 50433 'MsiBreak' custom action debugging aid should use custom action's name from 'CustomAction' table (currently uses 'Target' field) 50869 Killing Wine process in Wine 6.5 doesn't terminate the application because of the new use of start.exe 51163 WinOffice Pro 5.3 stops after splashscreen, needs WMI class SoftwareLicensingProduct 51619 advapi32:registry fails in Wine because French & German timezone name translations are too long 51900 regression: REAPER scrollbars flash between themed and non-themed 52163 postgresql-9.3 installer expects scrrun:filesys_GetTempName to return filename with TMP suffix 52298 Opening PPT with Freeoffice Presentations crashes on unimplemented function ole32.dll.OleConvertIStorageToOLESTREAMEx 52426 BCryptSignHash mishandles empty arguments 52434 Light Blue theme has rendering errors in tree views 52436 In Light Blue theme, checkable toggle buttons (BS_AUTOCHECKBOX) look unchecked when hovered 52446 Normal dlls with native subsystem id are no longer processed when importing system dlls with uppercase names 52476 QuickLOAD (VB5 app) input value is changed by factor 10 52494 shell32 progman_dde tests crash if run immediately after prefix creation 52510 alt:V mod for Grand Theft Auto V fails due to missing concrt140._Byte_reverse_table@details@Concurrency@@3QBEB 52562 advapi32:registry fails in Wine because some French timezone name translations are too long 52581 Internet MIDI crashes with Light Blue theme enabled 52583 ApiSetView does not display export ordinals correctly 52616 SteelSeries GG installer crashes on unimplemented function setupapi.dll.SetupQueryInfVersionInformationW 52618 32-bit EXEs do not launch from build dir on macOS 10.14 in WOW64 52626 MahjongSoul needs unimplemented function combase.dll.RoSetErrorReportingFlags 52667 DTS Master Audio Suite can't select save file location when wine's "Light" theme is used 52679 Anno 1602 / 1602 A.D. graphics too dark / black 52704 FreeHand 9 demo: invalid handle exception (0xc0000008) when attaching uxtheme.dll 52787 Invalid function prototype for "RegisterUserApiHook" when compiling for C++ 52953 GuiPy crashes on unimplemented function xmllite.dll.CreateXmlReaderInputWithEncodingCodePage 53430 urlmon:url fails due to unexpected redirection ---------------------------------------------------------------- Changes since 7.0: Alex Henrie (14): explorer: Only try to destroy the IShellWindows object if it exists. tzres: Inform translators of 31-character limit. po: Update Catalan translation. msi: Fix memory leak in get_fusion_filename (Coverity). winhttp: Fix memory leak on error path in WinHttpCrackUrl (Coverity). adsldp: Fix memory leak on error path in search_ExecuteSearch (Coverity). conhost: Fix memory leak on error path in create_screen_buffer (cppcheck). dbghelp: Fix memory leak on error path in dwarf2_read_range (cppcheck). ws2_32: Fix memory leak on error path in get_local_ips (cppcheck). ws2_32: Fix memory leaks on error paths in unix_gethostby* (scan-build). sane: Fix memory leak in create_item (Coverity). winspool: Fix memory leaks on error path in DeviceCapabilitiesA (Coverity). shell32: Fix sizeof argument in DoPaste (Coverity). mciwave: Fix bad free in MCI_SendCommandAsync (Coverity). Alexandre Julliard (9): user.exe: Make sure that the thunk selector doesn't get freed. makefiles: Disable printf format warnings for non-PE msvcrt modules. README: Mention Gitlab. kernel32/tests: Fix affinity test when there are too many CPUs. ntdll/tests: Fix affinity test when there are too many CPUs. secur32/tests: Update for new WineHQ certificate. urlmon/tests: Run tests against the gitlab server to avoid redirects. webservices/tests: Mark tests that fail on 64-bit as todo. wininet/tests: Update WineHQ certificate. Alistair Leslie-Hughes (1): msado15: Return valid object in Recordset::Clone. Andrey Gusev (1): d3d11: Implement the ID3DUserDefinedAnnotation interface. Aurimas Fišeras (1): po: Update Lithuanian translation. Bastien Orivel (1): ws2_32: Fix setsockopt(TCP_NODELAY) when optlen is less than 4. Ben Shefte (1): ntdll: Use case insensitive comparison in is_import_dll_system(). Bhavesh Davda (1): wined3d: Add GPU information for NVIDIA Ampere A10 and AMD Radeon Pro V620 GPUs. Brandon Moore (1): msadpm: Stop decoding instead of crashing for invalid adpcm data. Brendan Shanks (1): makefiles: On macOS, use @rpath instead of @loader_path when building Unix libs. David Kahurani (1): oleaut32: Do not skip the first decimal digit in VarParseNumFromStr(). Dmitry Timoshkov (2): ieframe: Clear a being invalidated history entry. ieframe: Initialize new history log entry. Eric Pouech (3): start: Wrap child inside a job so it gets killed when start.exe terminates. include/msvcrt: Redefine towlower* & towupper* with wint_t types. msacm32: Use extended structure definition for driver configuration. Fabian Maurer (4): printui: Use LocalFree for memory allocated by LocalAlloc (Coverity). mfplay: Prevent usage of uninitialized pointer in error case (Coverity). mfplat: Prevent use after free (Coverity). shell32: Prevent user after free in error case (Coverity). Floris Renaud (1): po: Update Dutch Translation. François Gouget (8): po: Fix the French translation of 'code page'. po: Fix backslash duplication in a French translation. po: Remove a space before a linefeed in the French translation. po: Remove spaces before linefeeds in the Spanish translation. po: Remove a space before a linefeed in the Chinese translation. po: Fix an accelerator shortcut in the Norwegian Bokmål translation. inetmib1: Avoid overflows in IPv4 address comparisons. inetmib1: Fix the IPv4 address network order for comparisons. Gabriel Ivăncescu (3): ddraw: Use WINED3D_SWAPCHAIN_NO_WINDOW_CHANGES only if window is not in foreground. jscript: Handle NULL return pointers in all constructors. mshtml: Fix leak on failure in return_nsstr. Gerald Pfeifer (1): iphlpapi: Zero-init prefix_len to avoid a compiler warning. Gijs Vermeulen (1): setupapi: Add SetupQueryInfVersionInformationA/W stub. Giovanni Mascellani (3): winegstreamer: Do not block forever if EOS races with command queue. mfplat: Avoid a race condition when releasing a tracked sample. mfmediaengine: Fix a memory leak. Hans Leidekker (1): msi: Use custom action name for MsiBreak handling. Henri Verbeet (2): d3d11/tests: Add some tests for ID3DUserDefinedAnnotation. wined3d: Add GPU information for NVIDIA Tesla T4. Kevin Puetz (1): winegcc: --out-implib needs to propagate -m32/-m64 to winebuild. Lauri Kenttä (2): po: Update Finnish translation. readme: Update Finnish translation. Louis Lenders (2): wbemprox: Add some properties of SoftwareLicensingProduct class. ole32: Add stub for OleConvertIStorageToOLESTREAMEx. Martin Storsjö (1): ntdll: Zero-initialize the syscall_frame used for starting threads on ARM/ARM64. Matteo Bruni (1): combase: Add RoSetErrorReportingFlags() stub. Michael Stefaniuc (1): tools: Get the ANNOUNCE bug list from the stable-notes git notes. Mohamad Al-Jaf (1): hid: Implement HidD_GetPhysicalDescriptor. Nikolay Sivov (4): comctl32/listview: Initialize subitem text buffer before drawing each subitem. uxtheme: Fix double free on registry key handle. xmllite/reader: Implement CreateXmlReaderInputWithEncodingCodePage(). evr/sample: Avoid a race condition when releasing a tracked sample. Paul Gofman (1): concrt140: Add ?_Byte_reverse_table@details@Concurrency@@3QBEB data export. Piotr Caban (2): ucrtbase: Add support for r-value demangling in unDName. msvcr100: Improve ThreadScheduler_ScheduleTask_loc stub. Piotr Kleski (1): bcrypt: Return BCryptSignHash len when only output is NULL. Robert Wilhelm (2): scrrun: Add test for GetTempName. scrrun: Generate temp name with tmp suffix. Rémi Bernon (1): mf: Handle MESourceSeeked and MEStreamSeeked state change events. Santino Mazza (2): ncrypt/tests: Test key import of an rsa key. ncrypt: Make NCryptOpenStorageProvider return a valid stub pointer. Saulius Krasuckas (1): ntdll: Check __WINE_PE_BUILD instead of compiler macros. Zebediah Figura (12): ws2_32/tests: Add tests for WSAStartup(). ws2_32: Always fill the WSADATA structure in WSAStartup(). ws2_32: Cap the negotiated winsock version to 1.1 or 2.2. ws2_32: Return 32767 or 0 in the iMaxSockets field. ws2_32: Return 65467 or 0 in the iMaxUdpDg field. ws2_32: Return WSAEFAULT instead of WSAEINVAL from WSAStartup() if "data" is NULL. configure: Fix the check for CAPI support. d3dx9: Don't mark annotation variables as dirty. winegstreamer: Release stream_cs on error in stream_thread(). setupapi: Avoid leaking subKey in SETUPDI_AddDeviceInterfaces(). server: Allocate enough space for the backslash in dup_nt_name() (Valgrind). tiff: Explictly link to zlib. Zhiyi Zhang (12): user32/tests: Test painting standard scroll bars in hovered state. user32: Draw standard scroll bars in hovered state only when they were previously painted by DefWinProc(). comctl32/button: Use pressed state when a pushlike checkbox or radio button is checked and hovered. comctl32/treeview: Do not draw client edge without WS_EX_CLIENTEDGE. light.msstyles: Do not use transparent treeview parts. uxtheme/tests: Add IsThemePartDefined() tests. uxtheme: Search parts of any state in IsThemePartDefined(). light.msstyles: Add Menu stub class. user32/tests: Test NUMCOLORS for display DCs. win32u: Return -1 for NUMCOLORS with 8-bit display DCs. include: Avoid a C++ keyword for RegisterUserApiHook(). light.msstyles: Use stretch sizing type for scroll bar arrow button background. -- Michael Stefaniuc mstefani(a)winehq.org

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel