wine-devel

wine-devel@winehq.org

2 participants
84469 discussions

Start a nNew thread

Re: [PATCH v8 2/8] scrrun: Check for null and empty arguments in MoveFolder.
by Marvin 26 Jul '22

26 Jul '22

1 0

Re: [PATCH v2 1/1] ntdll: Restore the timezone bias cache.
by Marvin 26 Jul '22

26 Jul '22

1 0

Re: [PATCH 1/1] ntdll: Restore the timezone bias cache.
by Marvin 26 Jul '22

26 Jul '22

1 0

Re: [Mingw-w64-public] How to fix error with macros in d3d12?
by Zebediah Figura 26 Jul '22

26 Jul '22

(+ wine-devel) On 6/11/22 13:26, LIU Hao wrote: > 在 2022-06-12 01:59, Zebediah Figura 写道: >>> The combination of `extern` with `__gnu_inline__` is necessary to suppress generation of a function >>> body if the attached function could not be inlined when compiling as C99. >> >> Why do we need that? >> > > Otherwise there would be errors about multiple definitions. > > >>> I don't think there is >>> anything we can do with these headers. Perhaps WIDL should not generate `static` for `FORCEINLINE` >>> functions; or, if that is not an option, `static __inline__` might be a better alternative. >> >> Is it legal to use 'static __forceinline' or 'extern __forceinline' with MSVC? If so I imagine we >> should find a solution that allows them. >> > > Yes, unfortunately. I don't think there is a solution. `extern inline` and `inline` are not > equivalent in C. > > Right, so, apparently MSVC treats both "inline" and "__forceinline" as magic bullets—they can both appear with or without 'static' and 'extern'; they'll always generate a function body but can also be defined in multiple source files (in fact, if the definition differs and the functions aren't static, an arbitrary one is picked and no warning is even printed.) And for good measure you can always take the address too. [So as far as I can tell there's no difference between "inline" and "extern inline" as far as MSVC is concerned.] I guess we can't do anything about that without modifying the language. But of course in lieu of that we should probably fix our headers. I see at least three options: (1) Use "FORCEINLINE" instead of "static FORCEINLINE" for these functions. MSVC never uses FORCEINLINE with static or extern, so this would be more consistent. The downside is we'd need to provide import library definitions for all of these functions, though, which seems less than ideal. (Unless combined with option 3 below.) (2) Use "static inline" for COM wrappers. This of course drops the __always_inline__ attribute. I'm inclined to assert that's a non-issue, but then again I never really saw the point of __always_inline__ anyway. [I guess it can be used to force the compiler to inline even when -finline isn't enough, but surely that would never be the case here...] (2b) Or use "static inline __attribute((__always_inline__))", and define a new macro to encapsulate that. (3) Define __forceinline as "static inline" rather than "extern inline". I have to assume there was a reason this wasn't done in the first place, but there's no documentation in the file and I couldn't easily find discussion about it. As far as I can tell this actually matches MSVC almost exactly, except that multiple definitions will be generated if something takes the function address. That is arguably a break in behaviour which is worse than just failing to link, though. I think my preferred solution is 2 (or 2b I guess). I'm planning to send the attached patch to winehq (since we need to sync widl from there), but I'd like to hear some feedback from the mingw-w64 project first. ἔρρωσθε, Zeb

4 4

Re: [PATCH v3 10/10] mshtml: Inform Gecko of progress done via OnProgress.
by Marvin 26 Jul '22

26 Jul '22

1 0

Re: [PATCH v3 1/3] riched20/tests: When selection is out of view, the scrollbar should move.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v3 07/10] mshtml: Implement ProgressEvent's lengthComputable prop.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v3 06/10] mshtml: Fix copy-paste mistake in test message.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v3 7/7] dinput/tests: Test GetObjectInfo() with three sliders and a proper format.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v3 6/7] dinput/tests: Assert that we can't get info about the third slider with c_dfDIJoystick2.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v3 1/7] dinput: Set correct object names for dials and sliders.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v2 7/7] dinput/tests: Test GetObjectInfo() with three sliders and a proper format.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v2 6/7] dinput/tests: Assert that we can't get info about the third slider with c_dfDIJoystick2.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v2 5/7] dinput: Use GUID_Slider type for dials.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v2 3/7] dinput/tests: Use helper for checking device object instances.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v4 2/2] mfplat/tests: Merge and reorganize image format tests.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v4 1/2] mfplat/tests: Mark some tests as broken on Win 8 and 10 v1507.
by Marvin 25 Jul '22

25 Jul '22

1 0

Re: [PATCH v2 09/10] mshtml: Implement ProgressEvent's total prop.
by Marvin 23 Jul '22

23 Jul '22

1 0

Testbot outage
by Jeremy White 23 Jul '22

23 Jul '22

Hi all, We are moving offices. As a result, the WineHQ testnet that powers testbot will be unavailable for some time, starting at 1:30 CDT. It will hopefully just be for the afternoon. Cheers, Jeremy

3 2

Re: [PATCH v2 07/10] mshtml: Implement ProgressEvent's lengthComputable prop.
by Marvin 22 Jul '22

22 Jul '22

1 0

Re: [PATCH v2 1/8] dlls/msvcrt: improve support for template in methods
by Marvin 22 Jul '22

22 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119463 Your paranoid android. === debian11 (32 bit report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit Arabic:Morocco report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit German report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit French report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit Hebrew:Israel report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit Hindi:India report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit Japanese:Japan report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit Chinese:China report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (32 bit WoW report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64" === debian11 (64 bit WoW report) === msvcrt: cpp.c:1310: Test failed: 136: Got name "public: __cdecl foo<double>::operator <int>int(void) __ptr64" cpp.c:1313: Test failed: 136: Expected "public: __cdecl foo<double>::operator<int> int(void) __ptr64"

1 0

Re: [PATCH 2/8] dinput/test: Print the expected values in check_ macros.
by Marvin 22 Jul '22

22 Jul '22

1 0

Re: [PATCH 2/3] shell32: Add SHBindToFolderIDListParent tests.
by Marvin 22 Jul '22

22 Jul '22

1 0

Re: [PATCH 8/8] dinput/tests: Test GetObjectInfo() with three sliders and a proper format.
by Marvin 22 Jul '22

22 Jul '22

1 0

Re: [PATCH 4/8] dinputs/tests: Use helper for checking device object instances.
by Marvin 22 Jul '22

22 Jul '22

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel