wine-devel

wine-devel@winehq.org

2 participants
84471 discussions

Re: advpack: Forward the remaining advpack.c ansi functions to their unicode counterparts
by Alexandre Julliard 23 Mar '06

23 Mar '06

"James Hawkins" <truiken(a)gmail.com> writes: > +HRESULT WINAPI SetPerUserSecValuesA(PERUSERSECTIONA* pPerUser) > +{ > + PERUSERSECTIONW perUserW; > + > + if (!pPerUser) > + return E_INVALIDARG; > + > + TRACE("(%p)\n", pPerUser); > + > + /* lengths copied from PERUSERSECTION structure definition */ > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szGUID, 59, perUserW.szGUID, 59); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szDispName, 128, perUserW.szDispName, 128); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szLocale, 10, perUserW.szLocale, 10); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szStub, MAX_PATH * 4, perUserW.szStub, MAX_PATH * 4); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szVersion, 32, perUserW.szVersion, 32); > + MultiByteToWideChar(CP_ACP, 0, pPerUser->szCompID, 128, perUserW.szCompID, 128); The source lengths are wrong, these are null-terminated strings. Also please use sizeof() instead of hardcoding the constants. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: winedbg: Fix stepping over
by Eric Pouech 22 Mar '06

22 Mar '06

Petr Tesarik wrote: > Hi, > > this patch fixes a bug in winedbg, which caused it to continue > execution at a wrong address when stepping over a function call. > The trouble was that if there was no breakpoint found, the code at the > end of break_should_continue reversed the PC adjustment and later the > debugger resumed program execution AFTER the INT3 instruction, which > is clearly wrong. > Index: break.c > =================================================================== > RCS file: /home/wine/wine/programs/winedbg/break.c,v > retrieving revision 1.17 > diff -u -r1.17 break.c > --- break.c 27 Jan 2006 15:22:15 -0000 1.17 > +++ break.c 21 Mar 2006 10:36:07 -0000 > @@ -731,9 +731,13 @@ > if (code == EXCEPTION_BREAKPOINT) > addr->Offset += be_cpu->adjust_pc_for_break(&dbg_context, TRUE); > > + dbg_curr_thread->stopped_xpoint = find_xpoint(addr, be_xpoint_break); > dbg_curr_process->bp[0].enabled = FALSE; /* disable the step-over breakpoint */ > > - dbg_curr_thread->stopped_xpoint = find_xpoint(addr, be_xpoint_break); this part looks correct > + /* Unconditionally stop on the step-over breakpoint */ > + if (dbg_curr_thread->stopped_xpoint == 0) > + return FALSE; > + but this doesn't... you don't handle the count here... what you should do is only compute dbg_curr_thread->stopped_xpoint (and do the appropriate handling) when its current value is -1 (not found) A+ -- Eric Pouech

1 0

Easy applications to write automated tests for?
by Dan Kegel 22 Mar '06

22 Mar '06

I noticed a probable regression in an app (kid pix 3) tonight. Which got me thinking: what are the easiest set of application regression tests we could throw together that go further than just verifying the installer runs? I'm thinking not just of things that could be automated with cxtest, but also stuff that might not fit into that framework. In the case of Kid Pix 3, a test that simply started the app, waited ten seconds, and made sure an error dialog didn't pop up would have detected the problem. ('Course, only a few people would be able to run that, as Kid Pix 3 is not a free download.) cxtest should be able to handle that. A bit more complex would be to launch WinZip, have it compress one file, and make sure the compressed file was as expected. It shouldn't be too hard to make cxtest handle that. And then on the somewhat ambitious end, now that Sun's JVM basically installs and runs trivial programs, we could run through the Java regression test suite at http://sourceware.org/mauve/ Heck, I might give that a shot myself. There's probably no reason to try to shove that into cxtest, is there? Or would it fit? And beyond the looking glass, one could imagine running the OpenOffice 2.0 automated test suite. (That's unlikely to work well at the moment, given that OpenOffice 2.0's open dialog locks up reliably.) That would probably flush out a few problems. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

4 11

Re: WIDL: Add missing ignore attribute. Check for inapplicable attributes in typedef.
by Alexandre Julliard 22 Mar '06

22 Mar '06

Saveliy Tretiakov <saveliyt(a)mail.ru> writes: > ChangeLog: > Saveliy Tretiakov <saveliyt(a)mail.ru> > - Add missing ignore attribute. > - Check for inapplicable attributes in typedef. Changed attribute > parsing in a way Mike McCormack suggested. > - Register type alias in typelib, if ATTR_PUBLIC is set. I think checking values explicitly is preferable to encoding them in the syntax, since it gives you a chance to provide meaningful errors. If you rely on the parser all you'll get is a generic "syntax error" with no clue to what you did wrong. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: advpack: Forward AddDelBackupEntryA to its unicode counterpart
by Alexandre Julliard 22 Mar '06

22 Mar '06

"James Hawkins" <truiken(a)gmail.com> writes: > + do > + { > + MultiByteToWideChar(CP_ACP, 0, ansi_list, len, ptr, len); > + > + ansi_list += len; > + ptr += len; > + > + len = lstrlenA(ansi_list) + 1; > + size += len * sizeof(WCHAR); > + list = HeapReAlloc(GetProcessHeap(), 0, list, size); > + } while (*ansi_list); You are assuming that A and W have the same length, that's wrong. Also it will be quite expensive to resize the list all the time. You should determine the full length of the list and then convert everything in one go. -- Alexandre Julliard julliard(a)winehq.org

1 0

linux mmap bug ? not filling in allocation gaps
by Geoff Brimhall 22 Mar '06

22 Mar '06

I've been debugging why an n64 emulator ( Project64 ) gets "Failed to allocate memory" errors under wine 9.9.10 on linux kernel 2.6. The program allocates a large chunk of size 0x20100000, which succeeds, and then another large 0x10100000 chunk, which fails. WINEDEBUG=+relay,+virtual eventually brought me to look at the linux /proc/<pid>/maps to see if the address space was really fully allocated. Here's what I noticed: Address start - end: 00400000-0554000 - Project64.exe address 00554000-20000000 ---p large mem allocation *** <gap> *** 55555000-573e0000 - loaded shared libraries 573e0000-774e0000 ---p mem alloc of 0x20100000 7bf00000-7c003000 - wine-pthread 7c003000-7c1ee000 - [heap] 7ffe0000-fffe0000 ---p large mem allocation ffff7000-fffff000 - [stack] Wrote a test mmap binary to fill a process address space, it created a similar gap between the executable load address and the loaded shared libraries, eventually failing mmap calls when it hit the stack address space. When I updated the test app to explicitly mmap in the gap area via specifying the aligned start address, the mmap call succeeded. I can't be the first person to notice this. Are there any TODO solutions for this ? One linux-centric solution would be to look for gaps like this in /proc/<pid>/maps in the libs/wine/mmap.c and take advantage of this. Or maybe another would be to keep a table of address spaces returned in wine_anon_mmap as a guide, then validate with try_mmap_fixed as to where a next-allocation should occur ( would this solution work outside linux ) ? Thanks, geoff Brimhall __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Re: Known issues area on main wiki page
by Tom Spear (Dustin Booker, Dustin Navea) 22 Mar '06

22 Mar '06

Tony Lambregts wrote: > Tom Spear wrote: >> On 3/21/06, *Vitaliy Margolen* <wine-devel(a)kievinfo.com >> <mailto:wine-devel@kievinfo.com>> wrote: >> >> I sure hope all users will go look at this page first. But some >> how I >> don't think they will. When we getting _exact_ duplicates with >> the same >> summary and almost identical comments. I don't think users will >> bother to >> look anywhere else. >> >> But that will add extra work on our side to keep this list in >> synch. On >> top of the usual stuff that we already do. >> >> Vitaliy. >> >> It wouldnt take much extra time outta my day to do it. 5 mins at max >> and only once I notice something is being reported rather >> frequently. I assume that these people who are reporting identical >> duplicates read some of the dodcumentation though, because otherwise >> they probably wouldn't have even known about winecfg. >> >> Tom >> > Keeping them around for a while even after they are fixed would be a > good idea since not everyone keeps up with the latest version of wine. > > Tony Lambregts > I didn't think about that, but you are right. I'll do something like Bug (x) - (Description) - Status: Resolved - Resolved as of wine v(x) Thanks Tom

1 0

Re: x11drv: (bug 4685) some ALT+key combos processed incorrectly
by Vitaliy Margolen 22 Mar '06

22 Mar '06

Tuesday, March 21, 2006, 3:49:53 PM, tkho(a)ucla.edu wrote: > Patch to recognize VK_LMENU and VK_RMENU in alt-key combos (bug 4685) > This patch looks for VK_LMENU and VK_RMENU in addition to VK_MENU when dealing > with ALT-key combo messages. This is the easiest way to add this functionality, > but arguably not the cleanest. > 2006-03-21 Thomas Kho <tkho(a)ucla.edu> > * dlls/x11drv/keyboard.c > x11drv: recognize VK_LMENU and VK_RMENU in ALT-key combos I'm sorry but this is further away from native, not closer. I just made some tests, and native sets/clears VM_MENU whenever right or left ALT is pressed/depressed. So we should be doing the same thing. Btw exactly the same thing happens with CONTROL & SHIFT. I will try to send these tests today-tomorrow. But you could try that yourself using SendInput(). Vitaliy Margolen

1 0

Re: opengl32: make the old code before the "sync the dibsection to its pixmap" patch be selectable at runtime
by Leon Freitag 21 Mar '06

21 Mar '06

P.S. Why thread-local variables? AFAIK OpenGL is single-threaded in its nature. I don't know if there are applications that draw opengl in multiple threads in different contents, and if current code would make any problems with these. Leon

4 5

re: WaitForMultipleObjectsEx will not take up to MAXIMUM_WAIT_OBJECTS
by Dan Kegel 21 Mar '06

21 Mar '06

Bryan Mayland wrote: > dlls/kernel/sync.c:173: > 176 if (count >= MAXIMUM_WAIT_OBJECTS) > 177 { > 178 SetLastError(ERROR_INVALID_PARAMETER); > 179 return WAIT_FAILED; > > Windows supports up to and including that number, wine only supports up > to that number. Congratulations, sounds like you found a bug in Wine! > Since the rest of the code actually does support the > full 64 wait objects, is there any reason this should not be changed to > 176 if (count > MAXIMUM_WAIT_OBJECTS) Looks like it should be changed. You've helped greatly with your post. You could help even more by posting a patch that modifies dlls/kernel/tests/sync.c to incorporate your test and also fixes the error. Feel up to it? Just yell if you need help. Thanks! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 4

Re: Wine and RDPRINT
by Frederico Bertucci 21 Mar '06

21 Mar '06

I try run this patch, but it not works still... some have another idea, or patch to run... with windows app works okay but with this specific application that uses rdprint, does not work... -- Frederico Bertucci e-mail / msn: fred(a)netbil.com.br www.netbil.com.br NetBil - Redes e Internet 18-3659-2444 XxX Linux for work Linux for fun XxX --------- Mensagem Original -------- De: Mariusz Kie³piñski <kielpi(a)poczta.onet.pl> Para: wine-devel(a)winehq.org <wine-devel(a)winehq.org> Assunto: Re: Wine and RDPRINT Data: 17/03/06 17:40 > > Dnia pi±tek, 17 marca 2006 14:35, Frederico Bertucci napisa³: > Hi > > Good morning guys > > > > I did my system works with wine no problem, but when I try print using > > then, doesnt work... if I print from any other aplication, works. > > > > I talked with my developer and he told me that are using a delphi componet > > called RDPRINT, this in windows, to create better graphics. > > > > So, Are there any way to print in wine, using this RDPRINT ?? any dll, any > > configuration > > > > I am using latest wine configured with winetools, the printer is a lx300. > > > > I am trying do this works since 2 weeks ago and not sucefull > > > > Tks guys > > > > > > try this patch > > > ================================= > > wine.15.03.06.19.02.59.diff > ? dlls/msvideo/Makefile > ? dlls/win32s/Makefile > ? dlls/winsock/Makefile > ? dlls/winsock/libws2_32.def > ? dlls/winsock/version.res > ? dlls/winsock/tests/Makefile > ? dlls/winsock/tests/testlist.c > Index: dlls/gdi/printdrv.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/printdrv.c,v > retrieving revision 1.46 > diff -u -p -1 -r1.46 printdrv.c > --- dlls/gdi/printdrv.c 12 Sep 2005 10:30:06 -0000 1.46 > +++ dlls/gdi/printdrv.c 15 Mar 2006 18:03:01 -0000 > @@ -471,3 +471,3 @@ static int CreateSpoolFile(LPCSTR pszOut > if (!psCmd[0] && !strncmp("LPR:",pszOutput,4)) > - sprintf(psCmd,"|lpr -P%s",pszOutput+4); > + sprintf(psCmd,"|lp -d'%s' ",pszOutput+4); > > > ======================================= > > > > > > > > > > > > > > ________________________________________________ :: NetBil :: :: A escolha certa em Internet ::

1 0

Re: edit: Only adjust margins if the edit control is above a certain size.
by Alexandre Julliard 21 Mar '06

21 Mar '06

Huw D M Davies <h.davies1(a)physics.ox.ac.uk> writes: > Huw Davies <huw(a)codeweavers.com> > edit: Only adjust the margins if the edit control is above a certain > size. This breaks the tests here: edit.c:788: Test failed: got 0 edit.c:789: Test failed: got 0 edit.c:802: Test failed: got 0 edit.c:808: Test failed: got 0 edit.c:809: Test failed: got 0 edit.c:813: Test failed: got 0 edit.c:814: Test failed: got 0 edit.c:817: Test failed: got 0 edit.c:818: Test failed: got 0 edit.c:840: Test failed: got 0 edit.c:841: Test failed: got 0 make[1]: *** [edit.ok] Error 11 -- Alexandre Julliard julliard(a)winehq.org

1 0

WaitForMultipleObjectsEx will not take up to MAXIMUM_WAIT_OBJECTS
by Bryan Mayland 21 Mar '06

21 Mar '06

I've been digging into why versions of uTorrent greater than 1.1.3 do not work under the latest wine and tracked it down to their use of WSAEventSelects to receive socket notifications. I created a small test application which mimics this behavior which works under WindowsXP but not wine. The problem is that they create MAXIMUM_WAIT_OBJECTS events and pass them to WaitForMultipleObjectsEx. That function bails out early due to dlls/kernel/sync.c:173: 176 if (count >= MAXIMUM_WAIT_OBJECTS) 177 { 178 SetLastError(ERROR_INVALID_PARAMETER); 179 return WAIT_FAILED; 180 } Windows supports up to and including that number, wine only supports up to that number. Since the rest of the code actually does support the full 64 wait objects, is there any reason this should not be changed to 176 if (count > MAXIMUM_WAIT_OBJECTS)

1 0

OLEAUT32: bug 4502 - request for comment before trying to fix
by Dan Kegel 21 Mar '06

21 Mar '06

Alex wrote: >It seems that I will have to wait until I code >enough of a test case for a *successful* ITypeInfo::Invoke() (there are >two tests of failing calls, but none of a successful one) I'm a complete COM newbie, but I've been reading "The Essence of COM" lately for entertainment; it almost describes that call. (FWIW, the example code for the book is at http://www.rollthunder.com/Books/OldBooksFrame.htm.) I went poking around online looking for examples of that call in C, and only found two :-( http://viewcvs.php.net/viewcvs.cgi/php-src/ext/com_dotnet/com_com.c http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ercp/org.eclipse.ercp.… I also found a muddled discussion here: http://www.codeproject.com/atl/multidisp.asp Good luck writing that test case! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 2

Re: [WINEDOCS] add question on Intel MacOS X
by Emmanuel Maillard 21 Mar '06

21 Mar '06

Hi, The plan for porting Darwine/ppc is to use qemu either Bochs. Thanks Emmanuel Le 21 mars 06 à 06:48, Brian Vincent a écrit : > Are there any other FAQ additions anyone wants to see? There's at > least one other one I was thinking of adding but have since forgotten. > > Changelog: > Brian Vincent > Explicitly address Intel Mac OS X. > > Index: en/wine-faq.sgml > =================================================================== > RCS file: /cvsroot/wine/docs/en/wine-faq.sgml,v > retrieving revision 1.15 > diff -u -u -r1.15 wine-faq.sgml > --- en/wine-faq.sgml 1 Feb 2006 04:47:04 -0000 1.15 > +++ en/wine-faq.sgml 21 Mar 2006 05:45:34 -0000 > @@ -591,9 +591,12 @@ > <para> > Mac OS X / Darwin: The <ulink > url="http://darwine.opendarwin.org/">Darwine</ulink> > project is > - currently working on porting Wine to the Darwin/x86 > platform. Their > - goal is to eventually make it possible to run x86 Windows > + currently working on porting Wine to the Darwin/x86 > platform. > + Their goal is to eventually make it possible to run x86 > Windows > applications on Darwin/PPC and then Mac OS X by using > Bochs. > + In addition, CodeWeavers has focused some of their > resources on > + Intel Mac OS X as well. With a little luck, Wine will > be running on > + it by the third quarter of 2006. > </para> > <para> > FreeBSD: This port is well maintained and should work with > @@ -606,7 +609,32 @@ > </para> > </answer> > </qandaentry> > - > + <qandaentry> > + <question id="Will-wine-run-on-macintel"> > + <para> > + I want to run Wine on an Intel Mac OS X (MacIntel) > system, will it > + work? > + </para> > + </question> > + <answer> > + <para> > + (Also see the previous question.) As of March, 2006, > simple > + applications are just beginning to to run on Intel Mac > OS X. > + It's possible in about 6 months we'll see applications > running > + similarly to how they do on Linux or FreeBSD. > + </para> > + <para> > + There are some complicated issues surrounding Wine on > Mac OS X. > + Working with low-level features, such as signal handling > and system > + registers, are quite different on Mac OS X. Further > hampering > + the issue are some bugs within the operating system. > Beyond > + that, integration on Mac OS X becomes difficult because > it is > + vastly different than a traditional *nix desktop. Menuing > + and graphics drivers are just two areas that require a > complete > + reimplementation in order to be functional. > + </para> > + </answer> > + </qanaentry> > <qandaentry> > <question id="What-minimum-CPU-must-I-have"> > <para> > >

1 0

Re: IAMMultiMediaStream::OpenFile
by Robert Shearman 21 Mar '06

21 Mar '06

Ivan Leo Puoti wrote: >@@ -282,9 +283,15 @@ > { > IAMMultiMediaStreamImpl *This = (IAMMultiMediaStreamImpl *)iface; > >- FIXME("(%p/%p)->(%s,%lx) stub!\n", This, iface, debugstr_w(pszFileName), dwFlags); >+ TRACE("(%p/%p)->(%s,%lx)\n", This, iface, debugstr_w(pszFileName), dwFlags); > >- return E_NOTIMPL; >+ /* We should check the file format and fail to open it if we can't reder it */ >+ >+ This->FileHandle = CreateFileW(pszFileName, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); >+ if(This->FileHandle == INVALID_HANLDE_VALUE) >+ return E_FAIL; >+ >+ return CoCreateInstance(&CLSID_FilterGraph, NULL, CLSCTX_INPROC_SERVER, &IID_IGraphBuilder, (LPVOID*)&This->pFilterGraph); > } > This is wrong. Here is the pseudo-code I sent to Peter Åstrand for the very same function: CoCreateInstance with IFileSourceFilter on CLSID_AsyncReader. Call IFileSourceFilter_Load. Get the output pin and stash it in This. Call IGraphBuilder_AddSourceFilter. Then IAMMultiMediaStreamImpl_Render should do the following: Call IGraphBuilder_Render using the pin previously stashed away. -- Rob Shearman

1 0

Re: IAMMultiMediaStream::OpenFile
by Dmitry Timoshkov 21 Mar '06

21 Mar '06

"Ivan Leo Puoti" <ivanleo(a)gmail.com> wrote: > + HANDLE FileHandle; > + This->FileHandle = CreateFileW(pszFileName, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, NULL); > + if(This->FileHandle == INVALID_HANLDE_VALUE) > + return E_FAIL; I guess that you need to close that file handle somewhere. -- Dmitry.

1 0

Re: winedbg: resend - add display for floating point status
by Eric Pouech 21 Mar '06

21 Mar '06

I'm getting picky, but there are a couple of things you still need to work on: - first, I don't think it's worthwhile to add another method to the CPU backend. Adding a boolean (as parameter) to print_context should do. - you also need to fix all the be_*.c files (for amd, ppc...) as well. Otherwise, they won't compile. The rule of thumb is never commit a patch that breaks compilation on some platforms. - one of the test looks suspicious (shouldn't it be if (!(ctx->loatSave.StatusWord & 0x00000001)) instead ?) > + if (!ctx->FloatSave.StatusWord & 0x00000001) A+ -- Eric Pouech

2 1

New Linux System calls (*at) in 2.6.16
by Troy Rollo 21 Mar '06

21 Mar '06

Google for these combined with keywords related to Wine didn't show anything, which surprised me since they seem ideal to solve a number of problems. A bunch of new calls have been added to the Linux kernel 2.6.16 <http://lwn.net/Articles/164887/> that are mirrors of the existing system calls but take a file descriptor for a directory that becomes the base point for relative paths. -- Troy Rollo - wine(a)troy.rollo.name

2 1

disallow networking flag
by rauschenimweltnetz＠web.de 21 Mar '06

21 Mar '06

Ahoi! I think it would be very usefull to disallow an application started with wine to connect to the network/internet by an options flag. I'm new to this list and my coding skills are in its fledgling stages. So my part in this whole thing probably would be to watch and learn... :) Unless somebody would help me to find out what I have to change... So I would try it by myself. But in consideration of the fact that I need this feature as soon as possible I would better like to just watch and learn... ;) rauschi ______________________________________________________________ Verschicken Sie romantische, coole und witzige Bilder per SMS! Jetzt bei WEB.DE FreeMail: http://f.web.de/?mc=021193

3 2

function counting script, memcheck.sh
by Segin 20 Mar '06

20 Mar '06

Attached is version 0.2 of this script, with a lot of additional functionality. You will need to be able to write to /tmp and make a file /tmp/grep to use the extended functionality (default functionality needs none of that, and is unmodified.) For those that are intested, you can fetch memcheck.sh from my project CVS tree: cvs -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/overdose login (when propted for a password, simply push enter) cvs -z3 -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/overdose co overdose You'll find the memcheck.sh script in the CVS checkout. Could someone tell me how to checkout just a single CVS file? Anyways, there's the docs, which you should read (failure to do so will get a reply of RTFM): ----------------------------------8<--------------------------------- memcheck.sh version 0.2 documentation To change the functions searched for, edit the file's top line. make sure all functions are space seperated and in quotes, to search for recv() and send() make sure that top line looks like this: FUNCTIONS="recv send"; Three are 2 command line arguments supported, they must be the only argument and verbatim to work, yada yada. -l List the line number with a code sample -C Like above, but with context. You need write access to /tmp to create, read, write and destroy files. Your grep implementation needs to be GNU grep or you need to edit the script. Most systems have given up using their own grep for GNU grep cause GNU grep kicks ass. ----------------------------------8<---------------------------------

2 2

Re: opengl32: make the old code before the "sync the dibsection to its pixmap" patch be selectable at runtime
by Leon Freitag 20 Mar '06

20 Mar '06

> Does that work any better? The patch works wonderfully! Thank you very much! The only thing is that you have to modify the Makefile.in in the opengl32 directory and add "ntdll" to the libs list. > Well, to make this work better, one would need a two-tiered approach: > = use thread-local variables to check if it's a 'special' buffer or not > (like this patch does) > = only do this check on GL APIs that actually modify or read from the frame > buffer (basically stuff like glClear, glEnd, gl(Read|Write)Buffer, ...). > The last is easy to do for 'core' stuff, a bit harder for extensions though. > But anyway, this is mandatory if one day we want to fix the 'windowed' > OpenGL code properly (whatever the method we choose as long as we do not > have the GLX extension exporting the clip list feature to the application). I don't think it would be that hard to realize. Right now we have the ENTER_GL() macro that gets called before each opengl call (see opengl_ext.c and norm.c) where the check and sync occurs. One solution would be to make two enter_gl functions -- one with the check and one without, and hardcode some database with the function list in the script that generates the files. This patch does already a great job for fixing Huw's regressions, and me and many Wine users would greatly appreciate its merge into Wine tree. Leon

2 1

Re: Vitaly Lipatov : gdi32: Look for ttf fonts in the Wine font dir.
by Vitaly Lipatov 20 Mar '06

20 Mar '06

В сообщении от 18 марта 2006 21:51 Alexandre Julliard написал(a): > + /* load the system truetype fonts */ > + data_dir = wine_get_data_dir(); > + if (data_dir && (unixname = HeapAlloc(GetProcessHeap(), 0, I did not use if (!data_dir) data_dir = wine_get_build_dir(); also for ttf mixing problem in fonts dir. What about to place source fonts and result (.fon, .ttf) in separate directories in source tree? -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

crt0.o versus crtdll.dll etc - suggestions?
by Wesley Parish 20 Mar '06

20 Mar '06

Hi. I've got some Clipper files I want to translate to C for incorporation into another program, and a program x2c to do the work. But it asks for crt0.o, which I don't have as such; I'm wondering which of the *crt* files in Wine are most suitable for aliasing or linking as crt0.o? Thanks Wesley Parish "Sharpened hands are happy hands. "Brim the tinfall with mirthful bands" - A Deepness in the Sky, Vernor Vinge "I me. Shape middled me. I would come out into hot!" I from the spicy that day was overcasked mockingly - it's a symbol of the other horizon. - emacs : meta x dissociated-press

2 2

Re: Prevent the use of windowsx.h with Wine source.
by Robert Shearman 20 Mar '06

20 Mar '06

Mike McCormack wrote: >+#ifdef __WINESRC__ >+/* This file contains macros that cause warnings on gcc 4.1, so avoid it. */ >+#error Please avoid use of windowsx.h in Wine source code. >+#endif >+ > Why don't we fix the macros as suggested by Francois, rather than preventing its use? It seems like a big waste of time to have submitted all of the patches to the files using windowsx.h when fixing the macros is necessary for Winelib anyway. -- Rob Shearman

5 7

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel