wine-devel

wine-devel@winehq.org

1 participants
84471 discussions

Re: WINED3D: Color fixups for vertex shaders
by Roderick Colenbrander 10 Mar '06

10 Mar '06

> Direct3D stores vertex color data in BGRA order, OpenGL stores it in > RGBA order. This causes red and blue to be swapped in d3d applications > when run under wine. This patch fixes this problem for vertex shaders > by enabling the flag that causes red and blue to be swapped in > vshader_program_add_input_param_swizzle, when appropriate. > > Changelog: > - Enable color fixups for vertex shaders > In my local tree I have some simple d3d8 shaders working. (See for instance http://roderick.student.utwente.nl/dolphin1.png and dolphin2.png on windows; there's some color issue but apart from that it works). This patch causes in combination with the other vshader patch you sent some drawing issues. Check http://roderick.student.utwente.nl/dolphin3.png Regards, Roderick -- "Feel free" mit GMX FreeMail! Monat f�r Monat 10 FreeSMS inklusive! http://www.gmx.net

2 5

DDraw->WineD3D refcounting hack
by Stefan Dösinger 10 Mar '06

10 Mar '06

Hello, I have a a question regarding some code that might be rejected by Alexandre when I submit it. The problem is that I have to do an refcount hack in my new ddraw code to destroy textures properly. I CC this mail to AJ because it's him who has the last word ;) WineD3D and Direct3D7 have different ideas about handling mipmap textures. In d3d7 they are complex surfaces - a bunch of surfaces with a root and sublevels. All surfaces in the compound have their own refcount, but they are all destroyed when the root is destroyed. In WineD3D there's the texture as a container, and the surfaces in the container have their refcount linked to the container(See the patch H. Verbeet sent a few days ago). In d3d7 the application destroys the first surface to release the whole texture. My first idea was to Release the WineD3DTexture. It would then call the Release method of all the sublevel ddraw surfaces, which would destroy them. This works for a correctly written application, but applications call GetAttachedSurface for the sublevels, which addrefs, and many do not Release the sublevels after GetAttachedSurface(). This leaves the sublevel surfaces with a refcount of 2 or more when the root is destroyed. To make sure that they are destroyed, I set their refcount to 1 when the root is destroyed. When the last reference to the WineD3D Texture is released, wineD3D will destroy the sublevel surfaces. Is such a thing acceptable for Wine? Does anyone have a better solution? If you need some code to look at, I'll upload an updated patch to my homepage later. Thanks, Stefan

2 2

Trying to fix bug 2400 - delete and comma
by agaro agaro 10 Mar '06

10 Mar '06

Hi all, I'm trying to fix bug 2400 - removes one char and puts comma simultaneously. My guess: this old bug is in dlls/x11drv/keyboard.c or dlls/user/message.c, something about dead keys implementation. Can somebody help me with a little explanation or documentation? I don't know what scancode, keycode and vkey mean. Thanks, agaro

4 4

Re: Use a property for the colour dialog's information.
by Robert Shearman 10 Mar '06

10 Mar '06

Mike McCormack wrote: >@@ -1217,7 +1220,7 @@ static INT_PTR CALLBACK ColorDlgProc( HW > DeleteDC(lpp->hdcMem); > DeleteObject(lpp->hbmMem); > HeapFree(GetProcessHeap(), 0, lpp); >- SetWindowLongPtrW(hDlg, DWLP_USER, 0); /* we don't need it anymore */ >+ SetPropW( hDlg, szColourDialogProp, lpp ); > > SetPropW( hDlg, szColourDialogProp, lpp ) should be SetPropW( hDlg, szColourDialogProp, NULL ). -- Rob Shearman

2 1

Re: dinput: Create single thread for mouse and keyboard hook procs. [try 3]
by Vitaliy Margolen 10 Mar '06

10 Mar '06

Any problems with this patch? I have not received any additional comments. And it does fix at least two games in question (see bug reports). And I have not seen any side-affects from it either. Vitaliy Margolen Wednesday, February 22, 2006, 8:10:16 AM, Vitaliy Margolen wrote: > ChangeLog: > dinput: Create single thread for mouse and keyboard hooks. > Put keyboard & mouse hook callbacks into separate thread. > Move few global variables into object. Delete no longer used crit section. > For hooks to work properly hook callback have to be in a thread > with message loop. Some games create separate threads just to handle > mouse and/or keyboard events that do not have message loop. This patch fixes > such games (Bug 4264) - mouse and (Bug 2981) - keyboard. > Try#2 (based on suggestions from Alexandre): > Using a message window in a dedicated thread with normal message loop. > Hooks are installed and removed using SendMessage to this window. > Only one mouse and one keyboard hook is permitted. > Hook handles are managed by dedicated thread and not given back to > caller. > Try#3 (with Robs suggestions) > Use critical section. > dlls/dinput/device.c | 132 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/dinput/device_private.h | 2 + > dlls/dinput/keyboard.c | 130 > ++++++++++++++++------------------------- > dlls/dinput/mouse.c | 33 ++++------- > 4 files changed, 195 insertions(+), 102 deletions(-)

1 0

Re: x11drv: Fix one case of "glXChooseFBConfig returns NULL" problem.
by Vitaliy Margolen 10 Mar '06

10 Mar '06

Anything wrong with this patch? According to MSDN ChoosePixelFormat should pick closest mode, but not fail. Vitaliy Margolen Saturday, March 4, 2006, 10:27:11 PM, Vitaliy Margolen wrote: > ChangeLog: > x11drv: Fix one case of "glXChooseFBConfig returns NULL" problem. Using alpha bits >> 8 makes this function fail, while it should not. > dlls/x11drv/opengl.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-)

1 0

ChangeDisplaySettings
by Jan Dvorak 09 Mar '06

09 Mar '06

While trying to run Scratches game, the game tries to set fullscreen resolution but fails - heres the log: trace:x11settings:X11DRV_EnumDisplaySettingsEx mode -1 (current) -- getting current mode (desktop) trace:x11settings:X11DRV_EnumDisplaySettingsEx mode 0 -- 800x600x32bpp (desktop) trace:x11settings:X11DRV_ChangeDisplaySettingsEx ((null),0x406bf9cc, (nil),0x00000004,(nil)) trace:x11settings:X11DRV_ChangeDisplaySettingsEx flags=FULLSCREEN trace:x11settings:X11DRV_ChangeDisplaySettingsEx DM_fields=BITSPERPEL,PELSWIDTH,PELSHEIGHT,DISPLAYFREQUENCY trace:x11settings:X11DRV_ChangeDisplaySettingsEx width=0 height=0 bpp=32 freq=0 (desktop) err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found! (desktop) it's the second game i encountered trying to do this (calling changedisplaysettings with PELSWIDTH and PELSHEIGHT masks set but setting the values of width and height itself to 0 ). It is buggy application ? Or some undocumented hack in winapi? Or error in wine ? And if it is, what can we do about it (as the games itself runs perfectly otherwise , just windowed ) ? Thanks. JD

1 0

Re: WINED3D: Implement GetCreationParameters
by Ivan Gyurdiev 09 Mar '06

09 Mar '06

> + if (!pParameters) { > + ERR("(%p) : Called with a NULL pParameters\n", This); > + } > + > + *pParameters = This->createParms; > This is dereferencing a NULL pointer.

10 20

WINE's way to find out about MS headers?
by Christoph Frick 09 Mar '06

09 Mar '06

hiho after reading the SetProperty documentation on MSDN about the direct input interface, i found out about four "defines" that are not yet included in the dinput.h of WINE. #define DIPROP_APPDATA MAKEDIPROP(?) #define DIPROP_CPOINTS MAKEDIPROP(?) #define DIPROP_INSTANCENAME MAKEDIPROP(?) #define DIPROP_PRODUCTNAME MAKEDIPROP(?) i guess the ids they represend are not documented anywhere but the dinput.h from Microsoft. what is the "best practise" for cases like this, to add them to wine's headers? -- cu

1 0

Re: WINED3D: Implement GetCreationParameters
by Rolf Kalbermatter 09 Mar '06

09 Mar '06

Alexandre Julliard schrieb: >I fail to see in how far returning an error is hiding a bug. >Imho if the library detects an error[*] it should pass the >information to the application and let the application handle >it. The library doesn't know if the application maybe can cope >with it. Just ultimately crash is a bad idea imo. Many applications ignore returned error codes (especially if you have to call GetLastError()) if the programmer was under the assumption that there will be never a possibility to cause an error. While this assumption may be true on Windows (or at least a certain Windows version the programmer has tested on) it is certainly not necessarily true in Wine. There could have been a Wine call just before, that was wrongly implemented, returning an invalid pointer or such. Just returning an error may hide that error for many lines, to crash in some much more unrelated area eventually. Tracking such dependant error causes is already hard enough and hiding an invalid pointer access or other invalid parameter by checking for its validness makes it even harder if an application doesn't ridicully check every possible error condition and believe me I haven't seen many programs that really do that. Crashing may be not what most end users very much like but it is in my opinion just as fine than displaying a dialog box that an unrecoverable error has occurred and that it must shut down and much better than relying on the application to actually do proper error checking, but it makes the life of every Wine programmer just a little bit easier and Wine still being far from a release state can use any help on the programmer side. Wine's policy is to do parameter checking only if Windows is doing it in all versions too and sometimes even then only when there is at least one application that depends on it to work properly. Lets look at the example at hand. There is a function that does not check the pointer in Windows. If an application crashes in that function because of that, this means basically that the application did not do proper pointer checking already and then it is very questionable that it would check the error indication of that function at all, since it wouldn't get such an error indication on Windows anyhow. Also this application will either crash on Windows too, and then it is the programmers problem to make this application behave better or it does not crash on Windows because some previous function does behave differently than the Wine equivalent and then every wine programmer would like to know as soon as possible that this error occurres, not 5000 lines further down the program. If you would talk about a stable and final Wine release (which with Wine chasing the Windows API propably never will be) this might be a little different but we talk about a software project heavily under development. Rolf Kalbermatter

2 2

Grand Theft Auto... requires mscoree?
by Ivan Gyurdiev 09 Mar '06

09 Mar '06

Grand Theft Auto... the never ending struggle to get it working. First I thought it was broken because of OLE...subsequently found out the installer was freezing, because of hidden message boxes. Now I've managed to install it in Desktop mode, but it dies when ran, with no output of any kind... Investigating shows: 000b:Call kernel32.SetUnhandledExceptionFilter(2027f1a8) ret=0115fbe9 000b:Ret kernel32.SetUnhandledExceptionFilter() retval=0115fb7c ret=0115fbe9 000b:Call kernel32.GetModuleHandleA(015459f4 "mscoree.dll") ret=0115ae6b 000b:Call ntdll.RtlInitAnsiString(7fcaf528,015459f4 "mscoree.dll") ret=2018d4fc 000b:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=2018d4fc 000b:Call ntdll.RtlAnsiStringToUnicodeString(7fffcbf8,7fcaf528,00000000) ret=2018d55b 000b:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=2018d55b 000b:Call ntdll.RtlInitUnicodeString(7fcaf52c,7fffcc00 L"mscoree.dll") ret=201a554d 000b:Ret ntdll.RtlInitUnicodeString() retval=00000018 ret=201a554d 000b:Call ntdll.LdrGetDllHandle(00000000,00000000,7fcaf52c,7fcaf534) ret=201a555b 000b:Ret ntdll.LdrGetDllHandle() retval=c0000135 ret=201a555b 000b:Call ntdll.RtlNtStatusToDosError(c0000135) ret=201a558a 000b:Ret ntdll.RtlNtStatusToDosError() retval=0000007e ret=201a558a 000b:Ret kernel32.GetModuleHandleA() retval=00000000 ret=0115ae6b 000b:Call kernel32.ExitProcess(00000001) ret=0115ae8f 000b:Call ntdll.LdrShutdownProcess() ret=201b03bd Looks like it doesn't like the missing mscoree.dll. I thought the .NET framework was not a core windows dll? Why would it require it? Also, installing a native dll doesn't seem to help...

2 3

BF2 demo
by Ivan Gyurdiev 09 Mar '06

09 Mar '06

H. Verbeet wrote: > Currently pixel shaders get created, but not used. This patch enables > OpenGL fragment programs if pixel shaders are enabled and the harware > supports it. Makes fonts readable in the menu for the BF2 demo. This > patch should be applied after the one that removes the FIXME in > drawPrimitiveDrawStrided. > You were able to get the BF2 demo to show something? Is this with native d3dx9_25.dll ? Did you run into this bug at all? http://bugs.winehq.org/show_bug.cgi?id=4745

2 2

Wine and OS X
by Obchod id 09 Mar '06

09 Mar '06

Hi, There could be at least mention in FAQ about possible OS x version or whether there is no plan. Best wishes Frantisek -- !!! Nová prodejna v Plzni. Od 9.11. otevíráme druhou prodejnu na Náměstí Republiky 21, v 1. patře přímo nad kanceláří Annonce, na zastávce tramvaje směr Slovany. Tel: 377 331 256!!! >>>Stesticko.cz - pro radostny a naplneny zivot. http://www.stesticko.cz > Knihkupectvi, internetovy a zásilkovy obchod http://shop.stesticko.cz >> Pecujeme o vase telo i dusi Knihy pro osobni rust, duchovno, esoteriku, hudba, tarot. karty, feng-shui Americka 20, Plzen, Po-Pa 9-18, So 10-12 h,tel: 377 91 91 73, 777 263 352 Namesti Republiky 21, Plzen, Po-Pa 10-18 h tel: 377 331 256, 608 702 719 > Alternativni knihovna a antikvariat http://www.stesticko.cz/knihovna/ >>> http://sweb.cz/wingmakers - Tvurci kridel - WingMakers.com <<<

3 4

Re: fixme:commdlg:GetFileName95 Flags 0x00900000 not yet implemented
by Rainer Dorsch 08 Mar '06

08 Mar '06

Am Montag, 6. März 2006 09:34 schrieben Sie: > On Sunday 05 March 2006 21:50, you wrote: > > I went to 'Arbeitsplatz' in the Shell and then 'C'. MyDocuments was shown > > as a file, not a folder. I.e. the problem persists. > > I don't quite understand, since MyDocuments is on the Desktop, not on > 'Arbeitsplatz'. Could you please browse to 'Arbeitsplatz\C:\windows'? The hierarchy I see is Desktop->Arbeitsplatz->C:->windows > Just to be sure: In notepad the filedialog works fine, right? Yes, that works fine. Thanks, Rainer -- Rainer Dorsch Alzentalstr. 28 D-71083 Herrenberg 07032-919495 Icq: 32550367

1 0

Re: ntdll: Fix Directory Searching when VFAT_IOCTL_READDIR_BOTH returns an invalid d_reclen
by Alexandre Julliard 08 Mar '06

08 Mar '06

Robert Shearman <rob(a)codeweavers.com> writes: > --- a/dlls/ntdll/directory.c > +++ b/dlls/ntdll/directory.c > @@ -1245,7 +1245,11 @@ static NTSTATUS find_file_in_dir( char * > unix_name[pos - 1] = '/'; > for (;;) > { > - if (!de[0].d_reclen) break; > + if (!de[0].d_reclen) > + { > + unix_name[pos - 1] = 0; > + break; We should probably have a 'goto not_found' here instead. -- Alexandre Julliard julliard(a)winehq.org

2 2

System wide registry
by Vitaly Lipatov 08 Mar '06

08 Mar '06

In WINE user guide I read int the System Administration Tips about global registry files (f.i. /usr/local/etc/wine.systemreg) But I can't find any code in WINE about it. It is obsoleted now? Is it possible to use system wide registry now? -- Lav Vitaly Lipatov Saint-Petersburg, Etersoft www.etersoft.ru GNU! ALT Linux Team! WINE! LaTeX! LyX!

2 1

linking errors in Winelib code (version 0.9.9) on Solaris 10
by Arun Kumar Khandelwal 08 Mar '06

08 Mar '06

I am compiling Winelib (version 0.9.9) on Solaris 10 machine. I am getting below linking errors: gcc -c -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wpointer-arith -g -O2 -o main.o main.c Undefined first referenced symbol in file GetStartupInfoA ../../dlls/libwinecrt0.a(exe_main.o) GetModuleHandleA ../../dlls/libwinecrt0.a(exe_main.o) GetCommandLineA ../../dlls/libwinecrt0.a(exe_main.o) WinMain ../../dlls/libwinecrt0.a(exe_main.o) ld: warning: Symbol referencing errors Please suggest how to get rid of these errors. Thanks and Regards, Arun Khandelwal

2 1

Re: Can't run DirectX games on x86_64 biarch Linux
by Christian Schneider 08 Mar '06

08 Mar '06

Am Dienstag, den 07.03.2006, 16:39 -0700 schrieb Jesse Allen: > On 3/7/06, Christian Schneider <mail(a)chrschn.de> wrote: > > Hi all. > > > > About half a year ago I replaced my old desktop by an AMD64 box and my > > previous x86 Linux from Scratch (LFS) installation by a x86_64 multilib > > LFS. And since then I'm not able to run any DirectX title anymore that > > used to work before. > > > > > Try disabling the sound in winecfg. I tried, but it didn't help. I've also tried different audio outputs (ALSA and OSS), but the error messages are the same. Anyways, thanks for your reply. Cheers, Christian Schneider

3 3

ole:ITypeInfo_fnInvoke, failed to convert param 0
by Tomas Carnecky 08 Mar '06

08 Mar '06

I got this when the WoW patcher started: err:ole:CoGetClassObject class {4955dd33-b159-11d0-8fcf-00aa006bcc59} not registered err:ole:CoGetClassObject no class object {4955dd33-b159-11d0-8fcf-00aa006bcc59} could be created for for context 0x1 fixme:ole:CoCreateInstance no classfactory created for CLSID {4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154 err:ole:ITypeInfo_fnInvoke failed to convert param 0 to VT_VARIANT|VT_BYREF from VT_VARIANT|VT_BYREF and the last line doesn't make sense to me, the patcher runs fine though... tom

1 0

Problem while compiling wine-0.9.9 source on solaris
by Vikas Gera 08 Mar '06

08 Mar '06

I tried to build Wine Library on Solaris 10 platform today. It gave error while compiling dll/dxerr8 module. The error message says "Don't know how to make target: install-lib" I compared the Makefiles and added the target "install-lib" for dxerr8 module, like below: Makefile: install install-lib:: install_lib $(WIN16_INSTALL) install_lib: $(MODULE) $(MKINSTALLDIRS) $(DESTDIR)$(dlldir) $(INSTALL_PROGRAM) $(MODULE) $(DESTDIR)$(dlldir)/$(MODULE) It was able to build the dxerr8 module. But similar error message is getting repeated for other modules as well. I would like to fix it in one shot, probably a fix in the configure script is needed. Has anybody faced this problem and fixed it? Please suggest. regards, Vikas Gera

2 1

Re: GDI32: [4/5] freetype.c add more font selecting&linking mechanism support.
by Huw D M Davies 08 Mar '06

08 Mar '06

On Tue, Mar 07, 2006 at 09:29:14PM +0900, Byeong-Sik Jeon wrote: > ChangeLog: > Improved create_child_font_list(), get_nearest_charset(), more using > font-linking mechanism. > > If lfCharSet == DEFAULT_CHARSET, then ALL font(LOGFONT) can see current > locale letter, (have to exist least one font corresponding current > locale ). > > > - If lfCharSet == DEFAULT_CHARSET then use the current locale codepage. > > and If selected font is not support current ansi codepage, then it fixup > > the problem in "create_child_font_list()" function. > > > I'm slightly confused about what you're trying to do here. Could you try to explain it again please? > --- 003/dlls/gdi/freetype.c 2006-03-07 20:29:58.000000000 +0900 > +++ 004/dlls/gdi/freetype.c 2006-03-07 20:30:31.000000000 +0900 > + if(!TranslateCharsetInfo((DWORD*)(INT)font->charset, &csi, TCI_SRCCHARSET)) > + return FALSE; > > + TRACE("found entry in system list\n"); > + > + fs.fsCsb[0] = fs.fsCsb[1] = 0; > LIST_FOR_EACH_ENTRY(font_link, &system_links, SYSTEM_LINKS, entry) > { > - if(!strcmpW(font_link->font_name, font->name)) > + if(!strcmpiW(font_link->font_name, font->name)) > { > - TRACE("found entry in system list\n"); Moving this TRACE is clearly not correct. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

2 2

valgrinding mozilla on wine
by Dan Kegel 07 Mar '06

07 Mar '06

I'm trying to track down a wine crash in firefox (http://bugs.winehq.org/show_bug.cgi?id=4762) and thought valgrind might be helpful. So, following http://wiki.winehq.org/Wine_and_Valgrind I installed valgrind-3.1.0 and ran valgrind --trace-children=yes /home/dank/wine/wine /home/dank/.wine/drive_c/Program\ Files/Mozilla\ Firefox/firefox.exe This got as far as putting up a window (but not filling it in) before croaking, so I guess valgrind still has some ways to go. Before it bailed, it printed out a few interesting warnings: ... ==16329== Warning: noted but unhandled ioctl 0x30B with no size/direction hints ==16329== This could cause spurious value errors to appear. ==16329== See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing a proper wrapper. ==16329== ==16329== Syscall param writev(vector[...]) points to uninitialised byte(s) ==16329== at 0x20000772: (within /lib/ld-2.3.5.so) ==16329== by 0x202D2BD8: wine_server_call (in /home/dank/wine/dlls/ntdll/ntdll.dll.so) ==16329== by 0x202C85D3: NtSetValueKey (reg.c:755) ==16329== by 0x205BFFF8: create_scsi_entry (oldconfig.c:170) ==16329== by 0x205C07BD: convert_old_config (oldconfig.c:400) ==16329== by 0x205C482E: __wine_kernel_init (process.c:751) ==16329== by 0x202C0BB2: __wine_process_init (loader.c:2276) ==16329== by 0x2002448E: wine_init (loader.c:600) ==16329== by 0x7BF01001: main (main.c:58) ==16329== Address 0xBEBF0874 is on thread 1's stack ... err:ole:CoGetClassObject class {4955dd33-b159-11d0-8fcf-00aa006bcc59} not registered err:ole:CoGetClassObject no class object {4955dd33-b159-11d0-8fcf-00aa006bcc59} could be created for for context 0x1 fixme:ole:CoCreateInstance no classfactory created for CLSID {4955dd33-b159-11d0-8fcf-00aa006bcc59}, hres is 0x80040154 ==16329== ==16329== Invalid read of size 4 ==16329== at 0x600195C4: ??? ==16329== Address 0x208BE16C is not stack'd, malloc'd or (recently) free'd ==16329== ==16329== Conditional jump or move depends on uninitialised value(s) ==16329== at 0x463876: ??? ==16329== ==16329== Invalid read of size 4 ==16329== at 0x603514C4: ??? ==16329== Address 0x208BCC70 is not stack'd, malloc'd or (recently) free'd ... err:seh:segv_handler Got unexpected trap 0 err:seh:segv_handler Got unexpected trap 0 err:seh:segv_handler Got unexpected trap 0 ... -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 3

wine 0.9.9 vs. Ned For Speed V -- already better
by Samium Gromoff 07 Mar '06

07 Mar '06

Here goes the log for running NFS5: PU, in win 0.9.9, the first version which manages to allow NFS to initialize the video mode, apparently. The wine debug output is attached.

3 3

problem in configure/make wine 0.9.9
by Lalit Aggarwal 07 Mar '06

07 Mar '06

When I rum make command it shows the following error, can somebody please help me in to come out of this. Undefined first referenced symbol in file GetStartupInfoA ../../dlls/libwinecrt0.a(exe_main.o) GetCommandLineA ../../dlls/libwinecrt0.a(exe_main.o) WinMain ../../dlls/libwinecrt0.a(exe_main.o) ld: warning: Symbol referencing errors Tried editing /var/installs/wine-0.9.9/dlls/ddraw/Makefile at line number 367 and put the /var/installs/wine-0.9.9/dlls/kernel/environ.o after -o option, it build the shared object successfully. Can anybody suggest how to fix this in configure or config.status script so the environ.o file is automatically included in the Makefile. Thanks -Lalit

1 0

Re: GDI32: [1/5] freetype.c add more font selecting&linking mechanism support.
by Huw D M Davies 07 Mar '06

07 Mar '06

On Tue, Mar 07, 2006 at 09:10:12PM +0900, Byeong-Sik Jeon wrote: > ChangeLog: > init_system_links support .ttc file. > add "Tahoma" registry value for CJK font link. > find_face_from_filename support .ttc file > I think you could spilt out the 'add Tahoma registry value' bit from this patch to make it a little smaller. > --- 000/dlls/gdi/freetype.c 2006-03-07 19:09:53.000000000 +0900 > +++ 001/dlls/gdi/freetype.c 2006-03-07 20:28:14.000000000 +0900 > @@ -909,14 +935,16 @@ > SYSTEM_LINKS *font_link, *system_font_link; > CHILD_FONT *child_font; > static const WCHAR Tahoma[] = {'T','a','h','o','m','a',0}; > - static const WCHAR tahoma_ttf[] = {'t','a','h','o','m','a','.','t','t','f',0}; > - static const WCHAR System[] = {'S','y','s','t','e','m',0}; > + static const char Tahoma_ttf[] = {'t','a','h','o','m','a','.','t','t','f',0}; Why don't you just use "tahoma.ttf" in the code where you call find_face_from_filename, there's no point in initializing a char string like this. > @@ -990,15 +1046,15 @@ > that Tahoma has */ > > system_font_link = HeapAlloc(GetProcessHeap(), 0, sizeof(*system_font_link)); > - system_font_link->font_name = strdupW(System); > + system_font_link->font_name = strdupW(defSystem); Please don't use defSystem here. That's supposed to be a fallback for System. Please leave it as it was. -- Huw Davies huw(a)codeweavers.com

2 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel