wine-devel

wine-devel@winehq.org

84471 discussions

LoadImage (4bpp) / CopyImage() crashing
by Cyril Margorin 26 Jan '06

26 Jan '06

Hello, During research the crashing application I've found a problem that can be easily reproduced by test. (http://www.winehq.org/pipermail/wine-patches/2005-November/022384.html) By investigation of problem I've found that original DIB bit depth is 4bpp, Physical pixmap bit depth is (equal to screen) 24bpp. In x11drv/bitmap.c X11_GetBitmapBits takes in account just only bit depth of physical pixmap, and copies it to provided buffer as-is. I.e. it tries to fill buffer with size (e.g.) 48x48x4bpp with 48x48x24bpp that causes buffer overrun and late falling in SetBitmapBits function. The current work-around to stop falling is Index: dlls/x11drv/bitmap.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/bitmap.c,v retrieving revision 1.18 diff -u -r1.18 bitmap.c --- dlls/x11drv/bitmap.c 26 Sep 2005 11:04:12 -0000 1.18 +++ dlls/x11drv/bitmap.c 25 Nov 2005 09:29:12 -0000 @@ -186,7 +186,19 @@ /* copy XImage to 16 bit padded image buffer with real bitsperpixel */ startline = buffer; - switch (physBitmap->pixmap_depth) + + /********************************************************************** + * CoMargo: the switching for physBitmap->pixmap_depth is not correct. + * It should take both physBitmap->pixmap_depth and bitmap.bmBitsPixel + * and convert from one bitdepth to another. + * Otherwise we meet buffer overrun. + */ + if(physBitmap->pixmap_depth != bitmap.bmBitsPixel) + { + FIXME("Pixel conversion from %d bitdepth to %d bitdepth MUST be done!\n",physBitmap->pixmap_depth,bitmap.bmBitsPixel); + } +/* switch (physBitmap->pixmap_depth) */ + switch(bitmap.bmBitsPixel) { case 1: for (h=0;h<height;h++) =================================================================== -- Cyril Margorin

6 15

Re: OLEAUT32: add additional condition for creation of interface
by Robert Shearman 26 Jan '06

26 Jan '06

Alex Villacís Lasso wrote: >diff -ur wine-0.9.6-cvs/dlls/oleaut32/typelib.c wine-0.9.6-cvs-patch/dlls/oleaut32/typelib.c >--- wine-0.9.6-cvs/dlls/oleaut32/typelib.c 2006-01-16 16:08:20.000000000 -0500 >+++ wine-0.9.6-cvs-patch/dlls/oleaut32/typelib.c 2006-01-24 21:53:48.000000000 -0500 >@@ -5567,10 +5567,31 @@ > ITypeInfo_AddRef(*ppTInfo); > result = S_OK; > } >- else if (hRefType == -1 && >- (((ITypeInfoImpl*) This)->TypeAttr.typekind == TKIND_DISPATCH) && >- (((ITypeInfoImpl*) This)->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL)) >+ else if ( >+ ( >+ hRefType == -1 && >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL) >+ ) >+ || >+ ( >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDISPATCHABLE) >+ ) >+ ) > { >+ /* Report whether we are here because of the DBGRID32.OCX fix */ >+ if (!( >+ hRefType == -1 && >+ (This->TypeAttr.typekind == TKIND_DISPATCH) && >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDUAL) >+ )) >+ { >+ FIXME("ignoring hRefType = %d, TYPEFLAG_FDISPATCHABLE is %s\n", >+ hRefType, >+ (This->TypeAttr.wTypeFlags & TYPEFLAG_FDISPATCHABLE) ? "set" : "not set"); >+ } >+ > /* when we meet a DUAL dispinterface, we must create the interface > * version of it. > */ > > This doesn't look right to me. We need tests for this situation that will tell us whether we are adding a dirty hack or whether this behaviour is correct. I can send you a test suite I have already built for typelibs if you want to add to it. >@@ -5598,8 +5619,47 @@ > if(pRefType->reference == hRefType) > break; > } >- if(!pRefType) >- FIXME("Can't find pRefType for ref %lx\n", hRefType); >+ if(!pRefType) { >+ static const char * descTKIND[TKIND_MAX] = { >+ "TKIND_ENUM", >+ "TKIND_RECORD", >+ "TKIND_MODULE", >+ "TKIND_INTERFACE", >+ "TKIND_DISPATCH", >+ "TKIND_COCLASS", >+ "TKIND_ALIAS", >+ "TKIND_UNION", >+ }; >+ static const char * descTypeFlags[15] = { >+ "TYPEFLAG_FAPPOBJECT", >+ "TYPEFLAG_FCANCREATE", >+ "TYPEFLAG_FLICENSED", >+ "TYPEFLAG_FPREDECLID", >+ "TYPEFLAG_FHIDDEN", >+ "TYPEFLAG_FCONTROL", >+ "TYPEFLAG_FDUAL", >+ "TYPEFLAG_FNONEXTENSIBLE", >+ "TYPEFLAG_FOLEAUTOMATION", >+ "TYPEFLAG_FRESTRICTED", >+ "TYPEFLAG_FAGGREGATABLE", >+ "TYPEFLAG_FREPLACEABLE", >+ "TYPEFLAG_FDISPATCHABLE", >+ "TYPEFLAG_FREVERSEBIND", >+ "TYPEFLAG_FPROXY", >+ }; >+ int i; >+ >+ FIXME("Can't find pRefType for ref %lx\n", hRefType); >+ FIXME("\ttypekind is %s\n", descTKIND[This->TypeAttr.typekind]); >+ FIXME("\twTypeFlags are:"); >+ for (i = 0; i < 15; i++) { >+ if (This->TypeAttr.wTypeFlags & (1 << i)) >+ FIXME(" %s", descTypeFlags[i]); >+ } >+ if (This->TypeAttr.wTypeFlags & 0xFFFF8000) >+ FIXME(" %08x", This->TypeAttr.wTypeFlags & 0xFFFF8000); >+ FIXME("\n"); >+ } > if(pRefType && hRefType != -1) { > ITypeLib *pTLib = NULL; > > This clutters the code too much. There are already functions for dumping the typelib that would work here instead, although I think they don't use the FIXME channel. -- Rob Shearman

2 1

Re: Problems with references to drive Z: in registry's User Shell Folders
by Juan Lang 26 Jan '06

26 Jan '06

> when shell32.dll is registered during wineprefixcreate, it puts a > lot of paths based on Z:\ in HKLM/HKCU > Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User > Shell Folders. This is due to resolving CIDL_PERSONAL to the DOS > path corresponding to $HOME. > > If people remove the Z: drive afterwards, this leads to a lot > problems (One being that the Desktop shellfolder won't initialize > any more, which breaks the complete shell namespace and thus the file > dialogs). Yeah, that is painful. > I'm proposing to add two more environment variables: %PERSONAL%, > which would be expanded to the DOS path corresponding to $HOME if > this exists, or to %USERPROFILE%\\My Documents if not (with "My > Documents" resource based, of course). And %DESKTOP%, which would > be expanded to DOS_PATH_OF($HOME)\\Desktop if existent and to > %USERPROFILE%\\Desktop, if not. So the environment variable expansion would be based on shell32? Ouch. I don't think that'll fly. I'm of the opinion that all this fancy CSIDL_PERSONAL mapping doesn't belong in shell32, even though I put it there. shell32 should default to creating paths that are part of the profiles directory if nothing else exists, since the shell won't work without them. But creating Linux-environment-friendly defaults should perhaps go in wineprefixcreate. I actually rather liked the idea of putting it in winecfg, and launching winecfg in a GUI-less mode from wineprefixcreate. The advantage is that the drive mappings and shell folder creation would be in the same app, and so would have some hope of staying consistent. If a user breaks it through direct registry manipulation, his fault. If she breaks it through normal use of our tools, our fault. --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 8

Re: TAPE 5/5: add implementation of kernel tape functions #2
by Robert Shearman 26 Jan '06

26 Jan '06

Hans Leidekker wrote: >+static DWORD set_error_from_status( NTSTATUS status ) >+{ >+ DWORD error; >+ >+ switch (status) >+ { >+ case STATUS_SUCCESS: error = ERROR_SUCCESS; break; >+ case STATUS_DISK_FULL: error = ERROR_END_OF_MEDIA; break; >+ case STATUS_DEVICE_NOT_READY: error = ERROR_NO_MEDIA_IN_DRIVE; break; >+ case STATUS_ACCESS_DENIED: error = ERROR_WRITE_PROTECT; break; >+ case STATUS_DEVICE_BUSY: error = ERROR_BUSY; break; >+ case STATUS_INVALID_PARAMETER: error = ERROR_INVALID_PARAMETER; break; >+ case STATUS_NOT_SUPPORTED: >+ case STATUS_UNSUCCESSFUL: >+ default: error = ERROR_NOT_SUPPORTED; break; >+ } >+ >+ SetLastError( error ); >+ return error; >+} > > You're duplicating RtlNtStatusToDosError. -- Rob Shearman

3 2

Problems with graphics
by Curro Amores 26 Jan '06

26 Jan '06

Hi: i have an access application and i haved tried to emulate it with wine and crossoffice as well. I have a problem when i want to display reports which have graphics. They are well displayed but when i close it, application fonts (menu) make bigger and take a white background. Has anybody seen any problem similar to it. Thanks all!

2 1

wine and jack => segfault? / wine and OSS not working
by Joachim Förster 26 Jan '06

26 Jan '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, some days ago I sent some mails to the wine-users list. My problem: the JACK output driver of wine does not work => wine segfaults; and the OSS output driver does not work, too. Windows Media Player (used for testing) says, it cannot find the audio hardware. Since then, nobody on the wine-users list had any idea what could be wrong, so now I am posting this here (3 mails): - --------------------------------- Hi, I am new to this list and just wanted to ask a question regarding Wine and JACK: I'm running JACK as my sound daemon and today I installed Wine (from the APT-Repository). I setup my .wine directory with the help of winetools. So far everything works fine, except sound output (tested with wmplayer and a simple wav file). So I selected "jack" as Audio driver. But wine segfaults with wmplayer as soon as opening the wav file: $ wine .wine/c/Programme/Windows\ Media\ Player/mplayer2.exe fixme:process:SetProcessPriorityBoost (0xffffffff,1): stub fixme:powermgnt:SetThreadExecutionState (0x2): stub, harmless. fixme:powermgnt:SetThreadExecutionState (0x80000000): stub, harmless. This sound card's driver does not support direct access The (slower) DirectSound HEL mode will be used instead. Segmentation fault I started qjackctl to see what the JACK says: 20:01:39.052 Audio connection graph change. 20:01:39.136 Audio connection change. 20:01:39.314 XRUN callback (1). 20:01:39.317 Audio connection graph change. So, I assume there was an "connection" established between Wine and JACK? Does anybody know something about this problem? Tell me if I have to provide more (log/debug) output etc. ... I am running Ubuntu Breezy (breezy kernel 2.6.12-10-686). Thanks, Joachim PS: Direct output to ALSA works (with jackd not running). - --------------------------------- Hi all, Does really nobody now something about the issue I described? Meanwhile I have done some further tests: Using the alsa-output driver works, but then I would have to kill the jack daemon, since jackd blocks the sound device, although I am running alsa with dmix. Then a ran Wine with the OSS-output driver while using a tool called oss2jack (makes a kernel device and re-routes all OSS connections to the jack daemon). Surprisingly that does NOT work, too. Although other OSS apps (skype, et, vlc, cedega (oss) ...) run really *very good* over oss2jack. There is one difference then: Using OSS-output driver, Wine does not segfault! The M$ Media Player just tells me, that it cannot access audio hardware. - --------------------------------- Hi all, obviously there is no one on this list who has similar problems? Would it be a good idea to post the problem into the dev mailing list? Anyway, yesterday again I made some tests and I think, that the OSS-output driver of Wine has a bug. Yesterday I used plain OSS (no alsa, no sound server, nothing) and again Windows Media Player (I use it to test sound) said it couldn't use the audio hardware. So there definitely has to be something wrong here. Any ideas? Short summary: Wine@alsa: works Wine@jack: segfault !! I think this is cleary a bug, or not? Wine@oss: WMPlayer couldn't use the audio hardware. Displays an error. System: Ubuntu Breezy (breezy kernel 2.6.12-10-686). - --------------------------------- Thanks, Joachim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFD1JfBZY86bR8HqNwRAn6FAJ4jZNodTT5STF1Tg3i4kwnJLllRkQCdGwkw hepaKlpjNzFdU1NS6mkUWg8= =cJdT -----END PGP SIGNATURE-----

4 6

Re: Third party downloads
by Tony Lambregts 26 Jan '06

26 Jan '06

On 1/26/06, Joachim von Thadden <thadden(a)web.de> wrote: > Am Thu, Jan 26, 2006 at 07:27:00AM -0700 schrieb Tony Lambregts: > > Tom Wickline wrote: > > >Hello, > > > > > >I see the "note" in the third party downloads section as problematic.. > > >We should say something to the effect of "please report problems back > > >to the authors of WineTools" > > > > > >The way its currently worded WineTools users will feel left out in the > > >dark if they > > >should have any complications. > > > > > > > > It would be helpfull to have a link then, somewhere to direct them to and > > #winehq, bugs.winehq.org wine-devel and wine-users(a)winehq.org are not the > > place. Is it OK to direct them to Joachim directly <thadden(a)web.de>? > > For me it's OK. What about the following: > > Note: WineTools is only recommended if installation or operability of > Windows software failed on pure Wine. Since WineTools radically alters > your Wine configuration please do not report bugs in programs with > WineTools installed to the wine developers. Instead contact the author > of WineTools. > I will try to remember to submit a patch tonight. -- Tony Lambregts

1 0

Third party downloads
by Tom Wickline 26 Jan '06

26 Jan '06

Hello, I see the "note" in the third party downloads section as problematic.. We should say something to the effect of "please report problems back to the authors of WineTools" The way its currently worded WineTools users will feel left out in the dark if they should have any complications. Tom

2 2

Re: TAPE 5/5: add implementation of kernel tape functions
by Alexandre Julliard 26 Jan '06

26 Jan '06

Hans Leidekker <hans(a)it.vu.nl> writes: > + status = NtDeviceIoControlFile( device, NULL, NULL, NULL, &io, > + IOCTL_TAPE_CREATE_PARTITION, &part, sizeof(TAPE_CREATE_PARTITION), NULL, 0 ); > > - return FALSE; > + return (DWORD)status; > } All these functions should return Win32 error codes, not NT status codes. You probably want to set last error too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: make menu tests pass on Win 9x/ME -- RESENT
by Alexandre Julliard 26 Jan '06

26 Jan '06

Rein Klazes <wijn(a)wanadoo.nl> writes: > Changelog: > dlls/user : menu.c > dlls/user/tests : menu.c > > - make menu tests pass on Win9x/ME; > - rename the macro IS_STRING_ITEM to IS_STRING_ITEM_ONLY, which better > reflects what it is doing: absence of other item type flags. You should not check the Windows version, you should only check the actual behavior. Also I think IS_STRING_ITEM is fine, there's no reason to add _ONLY since there's no other macro that would do a less specific test. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Patch to limit testing results in AppDB
by Chris Morgan 26 Jan '06

26 Jan '06

Oooh a new appdb hacker. Welcome :-) > // Show the Test results for a application version > function ShowVersionsTestingTable($iVersionId, $iCurrentTest, $link) > { The maximum number of versions to show should be a parameter to this function. > - $hResult = query_appdb("SELECT * > + global $showAll; We don't want to use globals. Looking at $_REQUEST['showAll'] should work. > + > + $hResult = query_appdb("SELECT * > + FROM testResults > + WHERE versionId = '".$iVersionId."' > + ORDER BY testedDate DESC;"); > + if(mysql_num_rows($hResult) <= 5 || is_string($showAll)) { > + $hResult = query_appdb("SELECT * > FROM testResults > WHERE versionId = '".$iVersionId."' > ORDER BY testedDate DESC;"); > + } > + else{ > + $hResult = query_appdb("SELECT * > + FROM testResults > + WHERE versionId = '".$iVersionId."' > + ORDER BY testedDate DESC LIMIT 0,5;"); > + } This is simplier if you do: $sQuery = "select * from testResults WHERE versionId = '".$iVersionId."' ORDER BY testedDate DESC"; if(!$showAll) $sQuery.=" LIMIT 0,"$maxEntries; It saves a db query and reduces duplicate code. > if(!$hResult || mysql_num_rows($hResult) == 0) > return; > echo '<p><span class="title">Testing Results</span><br />',"\n"; > @@ -379,7 +394,9 @@ > if ($oTest->iTestingId == $iCurrentTest) > echo ' <td align="center" > class="color2"><b>Current</b></td>',"\n"; > else > - echo ' <td align="center" class="color2">[<a > href="'.$link.$oTest->iTestingId.'">Show</a>]</td>',"\n"; > + echo ' <td align="center" class="color2">[<a > href="'.$link.$oTest->iTestingId; > + if(is_string($showAll)) echo > '&showAll='.$showAll.'">Show</a>]</td>',"\n"; > + else echo '">Show</a>]</td>',"\n"; > echo ' <td>',"\n"; > echo '<a href="'.BASE.'distributionView.php > ?iDistributionId='.$oTest->iDistributionId.'">',"\n"; > echo $oDistribution->sName.'</a>',"\n"; > @@ -393,6 +410,20 @@ > } > > echo '</table>',"\n"; > + > + if(mysql_num_rows($hResult) >= 5 AND !is_string($showAll)) { > + echo '<form method=get action="'.$PHP_SELF.'">'; > + echo '<input name="versionId" type=hidden value="',$iVersionId,'" > />'; > + echo '<input class="button" name="showAll" type=submit value="Show > All Tests" />'; > + echo '</form>'; > + } > + if(is_string($showAll)) { > + echo '<form method=get action="'.$PHP_SELF.'">'; > + echo '<input name="versionId" type=hidden value="',$iVersionId,'" > />'; > + echo '<input class="button" name="hideAll" type=submit > value="Limit to 5 Tests" />'; > + echo '</form>'; > + unset($showAll); > + } > The common code should be factored out of these conditionals. The only line that differs appears to be the one that generates the form button. Oh, and can you attach the patch to the email? It came through as inlined here which makes it difficult to save to a file, although maybe I just don't know what I'm doing with kmail. Chris

1 0

Re: DINPUT: Enforce single mouse acquire
by Dmitry Timoshkov 26 Jan '06

26 Jan '06

On Wed, 2006-01-25 at 17:32 -0500, Alex Villacís Lasso wrote: > + if (This == NULL) { > + ERR("mouse hook called with no current lock!\n"); > + return 0; > + } > + > if (code != HC_ACTION) return CallNextHookEx( This->hook, code, wparam, lparam ); You need to call CallNextHookEx in any case, otherwise it might break other hooks in the chain. Probably just add a check for This being NULL in the same place as the code checks for HC_ACTION. -- Dmitry.

2 6

Re: HW address w/o connection in iphlpapi
by Michael Ost 25 Jan '06

25 Jan '06

> Hi Michael, > >> When you boot a linux box without an ethernet connection, and eth0 >> configuration fails, GetAdaptersInfo does not return MAC address info >> for eth0. >> The problem seems to be that enumerateInterfaces (in >> dlls/iphlpapi/ifenum.c) doesn't create a record for eth0, because >> SIOCGIFCONF doesn't return one. > > Mmm. Yeah, I think an alternative to SIOCGIFCONF might be the thing. Wait. This works better than getifaddrs. It successfully returns info for "down" devices on my RH8 based linux box, with my creaky old wine-20050419. get_ifaddrs makes the same calls that you were, in its implementation. So it has the same problem. But it's alot easier to program with than the ioctl you used. You made comments in the source about if_indextoname having issues. So perhaps this patch won't be useful to you. But it works for us, so I'll apply it to our wine sources unless/until something better comes along. Have at it! Cheers... mo

3 10

commdlg patch
by Turkin, Andrey 25 Jan '06

25 Jan '06

Hi! Here is quick&dirty (TM :) patch (against wine-0.9.6) that changes explorer-like Open/Save file dialogs to be more 3.11-like dialog/Windows compatible: 1) set view window control id to 1121 2) set inner list window control id to 1 instead of 2000 (anyone know why 2000 was chosen?) This patch is really not very good because of my 1) implementation, but it fixes Macromedia Director cast import! I've done 1) by placing SetWindowLong(hwndView,GWLP_ID, lst2) after each IShellBrowser_BrowseObject call. Better approach is to set view vindow's control id inside of IShellBrowser_BrowseObject but I don't sure if it safe. Regards, Andrey Turkin. diff -cr wine-0.9.6/dlls/commdlg/filedlg.c wine-0.9.6p/dlls/commdlg/filedlg.c *** wine-0.9.6/dlls/commdlg/filedlg.c 2006-01-19 17:13:54.000000000 +0300 --- wine-0.9.6p/dlls/commdlg/filedlg.c 2006-01-25 19:37:26.000000000 +0300 *************** *** 1486,1491 **** --- 1486,1492 ---- /* Browse to the initial directory */ IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser,pidlItemId, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); /* Free pidlItem memory */ COMDLG32_SHFree(pidlItemId); *************** *** 1997,2002 **** --- 1998,2004 ---- if( ! COMDLG32_PIDL_ILIsEqual(pidlCurrent, fodInfos->ShellInfos.pidlAbsCurrent)) { IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidlCurrent, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); } else if( nOpenAction == ONOPEN_SEARCH ) { *************** *** 2260,2265 **** --- 2262,2268 ---- NULL, SBSP_PARENT))) { + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); return TRUE; } *************** *** 2282,2287 **** --- 2285,2291 ---- SHGetSpecialFolderLocation(0,CSIDL_DESKTOP,&pidl); hres = IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser, pidl, SBSP_ABSOLUTE); + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); COMDLG32_SHFree(pidl); return SUCCEEDED(hres); *************** *** 2758,2763 **** --- 2762,2768 ---- tmpFolder->pidlItem, SBSP_ABSOLUTE))) { + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE); return TRUE; } *************** *** 3435,3440 **** --- 3440,3446 ---- ' ','n','o','t',' ','e','x','i','s','t',0}; MessageBoxW( hwnd, notexist, fodInfos->title, MB_OK | MB_ICONEXCLAMATION ); } + SetWindowLongA(fodInfos->ShellInfos.hwndView, GWLP_ID, lst2); bBrowseSelFolder = TRUE; SendCustomDlgNotificationMessage(hwnd,CDN_FOLDERCHANGE); } diff -cr wine-0.9.6/dlls/shell32/shlview.c wine-0.9.6p/dlls/shell32/shlview.c *** wine-0.9.6/dlls/shell32/shlview.c 2006-01-19 17:14:17.000000000 +0300 --- wine-0.9.6p/dlls/shell32/shlview.c 2006-01-25 19:37:45.000000000 +0300 *************** *** 146,152 **** #define IDM_VIEW_IDW (FCIDM_SHVIEWFIRST + 0x501) #define IDM_MYFILEITEM (FCIDM_SHVIEWFIRST + 0x502) ! #define ID_LISTVIEW 2000 #define SHV_CHANGE_NOTIFY WM_USER + 0x1111 --- 146,152 ---- #define IDM_VIEW_IDW (FCIDM_SHVIEWFIRST + 0x501) #define IDM_MYFILEITEM (FCIDM_SHVIEWFIRST + 0x502) ! #define ID_LISTVIEW 1 #define SHV_CHANGE_NOTIFY WM_USER + 0x1111

1 0

Fwd: Re: Fwd: MBR was destroyed
by Oliver Stieber 25 Jan '06

25 Jan '06

> On Sun, Nov 20, 2005 at 05:30:39PM +0100, seorge wrote: > > Hi, > > > > Since I'm not a developerr and therefore can't take part in any discussion > > here may I ask you to discuss the bug I reported, because Dustin Navea asked > > me to join this list. Or if nobody really need my presence here, please let > > me know and I will unsubscribe. > > If you run WINE only as user (not as root) this just cannot happen. > > Did you run WINE as root? I've just tried at it appears to have wiped my MBR logged in as a normal User in wheel group. If this is the problem then I purchsed a new drive because of it last month. Oliver. > > Ciao, Marcus > > > > > > > ___________________________________________________________ > Yahoo! Model Search 2005 - Find the next catwalk superstars - > http://uk.news.yahoo.com/hot/model-search/ > ___________________________________________________________ To help you stay safe and secure online, we've developed the all new Yahoo! Security Centre. http://uk.security.yahoo.com

11 21

Can't compile with vc7: oleauto.h(229) : error C2719: 'function-parameter': formal parameter with __declspec(align('8')) won't be aligned
by Dan Kegel 25 Jan '06

25 Jan '06

A UCLA student trying to compile wine conformance tests on Windows ran into this: > [Compiling wine tests with VC7 or > the server 2003 sdk gets] this error when compiling. > > ..\..\..\include\oleauto.h(229) : error C2719: 'function-parameter': > formal parameter with __declspec(align('8')) won't be aligned (See http://msdn2.microsoft.com/en-us/library/373ak2y1.aspx ) Examining oleauto.h line 229, I saw the bad parameter was of type DOUBLE. I then went looking for the typedef for DOUBLE: ~/wine/include$ grep 'typedef.*DOUBLE' *.h The interesting hit was: wtypes.h:typedef double DECLSPEC_ALIGN(8) DOUBLE; The patch that introduced the change was http://www.winehq.com/hypermail/wine-cvs/2004/05/0027.html I told him to try replacing DOUBLE and DATE with double and date in the formal parameters in oleauto.h for now. Is that generally the right thing to do? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

CVS build error
by Peter Åstrand 25 Jan '06

25 Jan '06

I can't build the CVS version anymore, I get: gcc -g -O2 -o widl client.o hash.o header.o proxy.o server.o typegen.o typelib.o utils.o widl.o write_msft.o parser.tab.o lex.yy.o -L../../libs -lwpp -lwine_port -lfl ../../libs/libwpp.a(lex.yy.o)(.text+0x624): In function `_yy_dummy_uses_of_static_functions_b2f4_517d_02ff_b30c_3e5a_47d7_aaa3_3b5d_': /home/peter/wine/libs/wpp/lex.yy.c:3357: multiple definition of `_yy_dummy_uses_of_static_functions_b2f4_517d_02ff_b30c_3e5a_47d7_aaa3_3b5d_' lex.yy.o(.text+0x58c):/home/peter/wine/tools/widl/lex.yy.c:1796: first defined here collect2: ld returned 1 exit status make[2]: *** [widl] Error 1 make[2]: Leaving directory `/home/peter/wine/tools/widl' Any ideas? -- Peter Åstrand ThinLinc Chief Developer Cendio www.cendio.se Teknikringen 3 583 30 Linköping Phone: +46-13-21 46 00

2 1

Re: d3d8: CreateDevice should try the parent if the current window fails
by H. Verbeet 25 Jan '06

25 Jan '06

On 24/01/06, Jan Zerebecki <jan.wine(a)zerebecki.de> wrote: > Changelog: > d3d8: CreateDevice should try the parent if the current window fails > because it doesn't have the property __wine_x11_whole_window . > Fixes bug #4341 . Does that happen in wined3d as well? If so, it's probably usefull to fix wined3d as well, considering the idea is to make d3d8 use wined3d eventually.

2 1

Problems with references to drive Z: in registry's User Shell Folders
by Michael Jung 25 Jan '06

25 Jan '06

Hi, when shell32.dll is registered during wineprefixcreate, it puts a lot of paths based on Z:\ in HKLM/HKCU Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders. This is due to resolving CIDL_PERSONAL to the DOS path corresponding to $HOME. If people remove the Z: drive afterwards, this leads to a lot problems (One being that the Desktop shellfolder won't initialize any more, which breaks the complete shell namespace and thus the file dialogs). I'm proposing to add two more environment variables: %PERSONAL%, which would be expanded to the DOS path corresponding to $HOME if this exists, or to %USERPROFILE%\\My Documents if not (with "My Documents" resource based, of course). And %DESKTOP%, which would be expanded to DOS_PATH_OF($HOME)\\Desktop if existent and to %USERPROFILE%\\Desktop, if not. Does someone see a problem with this approach? Bye, -- Michael Jung mjung(a)iss.tu-darmstadt.de

1 0

[Lostwages] Re: lostwages/templates/en download.template
by Tony Lambregts 25 Jan '06

25 Jan '06

Jeremy Newman wrote: > ChangeSet ID: 22527 > CVSROOT: /opt/cvs-commit > Module name: lostwages > Changes by: jnewman(a)winehq.org 2006/01/24 14:26:23 > > Modified files: > templates/en : download.template > > Log message: > based on patch from: Sven Paschukat <Sven.Paschukat(a)t-online.de> > add a note to the WineTools link > > Patch: http://cvs.winehq.org/patch.py?id=22527 > > Old revision New revision Changes Path > 1.72 1.73 +8 -3 lostwages/templates/en/download.template > > Index: lostwages/templates/en/download.template > diff -u -p lostwages/templates/en/download.template:1.72 lostwages/templates/en/download.template:1.73 > --- lostwages/templates/en/download.template:1.72 24 Jan 2006 20:26:23 -0000 > +++ lostwages/templates/en/download.template 24 Jan 2006 20:26:23 -0000 > @@ -122,13 +122,18 @@ for post-installation instructions.</b>< > </a> > </td> > <td align=left bgcolor="#ffffff"> > - > <b><a href="http://www.von-thadden.de/Joachim/WineTools/">Wine Tools</a></b> - > WineTools is a menu driven installer for installing Windows programs. > This software lets you install the following Windows software: DCOM98, > IE6, Windows Core Fonts, Windows System Software, Office & Office Viewer, > - Adobe Photoshop 7, Illustrator 9 and many other programs. > - By <a href="http://www.von-thadden.de/Joachim/WineTools/">Joachim von Thadden</a>. > + Adobe Photoshop 7, Illustrator 9 and many other programs.<br /> > + By <a href="http://www.von-thadden.de/Joachim/WineTools/">Joachim von > + Thadden</a>.<br /> > + <div style="margin: 10px; padding: 5px; border: 1px solid #C0C0C0; background-color: #F0F0F0;"> > + <b>Note:</b> WineTools only recommended if installation or operability of > + Windows software failed on pure Wine or because the Wine developers need > + your feedback from testing. > + </div> > </td> > </tr> > </table> > > > Wine developers do not want feed back of bugs in programs with winetools installed Change Log: update note to the WineTools link Files Changed: lostwages/templates/en download.template Index: templates/en/download.template =================================================================== RCS file: /home/wine/lostwages/templates/en/download.template,v retrieving revision 1.73 diff -u -r1.73 download.template --- templates/en/download.template 24 Jan 2006 20:26:23 -0000 1.73 +++ templates/en/download.template 25 Jan 2006 03:27:01 -0000 @@ -131,8 +131,9 @@ Thadden</a>.<br /> <div style="margin: 10px; padding: 5px; border: 1px solid #C0C0C0; background-color: #F0F0F0;"> <b>Note:</b> WineTools only recommended if installation or operability of - Windows software failed on pure Wine or because the Wine developers need - your feedback from testing. + Windows software failed on pure Wine. Since winetools radically alters your + Wine configuration please do not report bugs in programs with WineTools + installed. </div> </td> </tr>

1 0

Re: [Fwd: WineTools is in need of some major house cleaning!]
by Joachim von Thadden 25 Jan '06

25 Jan '06

Dear developers and all others reading this list, from Sven Paschukat I was informed about the discussion of removing the WineTools link from the winehq website. I read all remarks made to that hotly discussed topic and I am willing to tell you all a bit about the purpose and history of WineTools as well as I will answer the questions made by Tom Wickline. So this will be a little longish mail and I beg your pardon for that and hope you have enough patience to read it all. To start from the beginning, I took over the remainings of a project winetools initially started by Frank Hendriksen <frank(a)frankscorner.org> which was somehow orphaned. The very reason I did that was that in autumn 2004 I had to write an article in the well known German computer magazine c't. After fiddling with wine for a long time only to install a stable IE6 or Office, I found that it was so absolute complicated to describe all the steps needed only to install the IE6 (which is much better now) and that also following these steps was very erroneous, that I started to rewrite the winetools script for the readers of this article. I never meant it to become so famous and wide spread, but the download statistics after only two month showed me that there was a massive demand for such a tool. So this is how it started and it shows very clearly that it was always an installer to make certain important applications easily usable under Linux. It was never meant for testing or developing. It was always meant for the end user being able to use his software. At the time of the first releases it was almost impossible to install or work with many applications without using native DCOM and/or many of the builtin DLLs that come with the IE6. To find a configuration for as many apps as possible was one of the goals. Not to force users (with very low skills) to have many different wine installations *and* many wine user directories was a second goal. So this is the reason why, until now, everything in WineTools is based on this native M$ software (DCOM, IE6). And believe me, no one would be more happy to wipe this DCOM, IE6 and MSI stuff completely from his harddisk than me! So as so many programs rely on parts of M$ software (MFC, VB and MDAC are other important examples) and because to install and use this software leads to so many restrictions in the wine usage, I had to pin wine to the emulation of Win98 and also had to massively tamper around with DLLOverrides. The goal was to built up an environment, that can install and use as many Windows programs as possible. This did in no way regard to the fact that it is not very helpful for the wine developers. It was just a practical decision. >From time to time, Sven Paschukat and me are testing wine versions to figure out, whether we can skip some of the M$ stuff. We have not been very successful with that until now, so this is why there are so many remainings of the first start of the project in the concept. But again: This tool is for the average windows user. And believe me, I tested this with my brothers, who are just normal users. And they never ever got a piece of windows software running with wine without my heavy intervention. With WineTools they just need to click on some buttons and got their software downloaded, installed and configured. With an amount of many thousand downloads a month, not calculating the distribution inclusions of WineTools, I get almost the same number of direct mails about problems with the software as are coming into the list. And I get massive positive resonance from users who were for a long time trying to get their stuff running with plain wine and are now happy that it just works with WineTools. I must admit, that there raise problems out of the fact, that the same users are trying to install not WineTools-tested software with the setup of WineTools and coming then to the list. And your are right that this is an undebuggable situation. The only way around that is to smoothly migrate WineTools to more and more builtin features as long as this does not make the programs uninstallable or unusable. > Betreff: WineTools is in need of some major house cleaning! > Datum: Fri, 30 Dec 2005 03:31:43 -0500 > Von: Tom Wickline <twickline(a)gmail.com> > An: wine-devel <wine-devel(a)winehq.org> > > Hello Everyone, > > Anyone who reads the posting on this list already knows that I stood up for > the wineTools project and almost made a couple enemies... But me and Vitaliy > came to a half way agreement on whether or not we should keep the link > on our downloads page to WineTools.... > > I feel I need to ask a couple questions here about the future of WineTools. > > 1) Are the concerns that Vitaliy brought up being looked into? Sven Paschukat suggested to implement a mode for WineTools to install without native components and without that tampering in the registry. This allows automatic installations *and* insight for developers if something goes wrong. We can also add a debugging mode to enable the logging of wines debug channels, to make a mailable report of bugs. Also the other suggested corrections will be looked over and changed if applicable. > 2) On sourceforge there are still downloads of version 1.30 from > December 3, 2003 why is this? and do you plan to cancel this project > or at least update it? > sourceforge site: > http://sourceforge.net/project/showfiles.php?group_id=61341 > > 3 )Freshmeat list WineTools latest version at 2.1.0 and last updated 1 > year, 4 months ago > do you plan to update this site and list new versions as there released? > http://freshmeat.net/projects/winetools/?branch_id=51159&release_id=164227 I personally had never anything to do with these versions. The one on Sourceforge is Frank Hendriksen's. He was already contacted by Sven Paschukat to remove the project, but Sourceforge does not allow to remove projects. So instead he already pointed a link to the official WineTools site. I don't see what we can do more here. The one on Freshmeat was taken over and is maintained by Sven Paschukat. Also Freshmeat does not allow the removal of projects. But Sven will update the versions there and we will try to keep it uptodate. We might also move the whole download section to Freshmeat to unburden my download server. > 4) Could the maintainers of WineTools help new users in #winehq on > irc? or start a new channel #wine-tools (or something to that effect) > and help WineTools users? Can you list either the #winehq channel or a > new channel on your site and ask experienced users to help new users? I am very astonished about this request. If you look through the mailing list you will find, that Sven and me are already giving support on the wine-users mailing list. That we will not and can not maintain a channel should be clear as we are not earning our money by looking at channels. Also the demand by Vitaly to provide rapid fixes to requests on such a channel or the list is something that can be only meant as a joke!!! If Vitaly is a man of independent means it is nice for him but we are a free time project and can only work for WineTools, as the name suggests, in our *free* time. And we have also a family, friends, mistresses and other hobbies... > I am not trying to be critical..... I hope winehq keeps the link to > your project but you guys may need help more on winehq, and also keep > information sites more up to date for this to take place. and also > look in to Vitaliy's concerns. Well, we also do not like winehq to remove the project's link. As for the support I already wrote a line above about that. Note that there is a massive amount of users using Wine via WineTools. Almost all users coming from Windows are using this software if they like to use their programs. This might lead to more and more end user questions on the list. As a possible solution for that, if you think this gets the upper hand, I would suggest to have a new mailing list wine-winetools and to redirect all users to that one. We will propagate then this list in the readmes and on the WineTools sites. And for sure we will sit on this list like spiders lurking for our prey... At least I want to thank all wine developers for their absolute fantastic work! In my opinion this is one of the most interesting and most ambitious projects in the community of open source software. And it really works astonishingly good. Regards Joachim von Thadden -- "Never touch a running system! Never run a touching system? Never run a touchy system!!!"

3 3

Should the AppDB make public the number of unique page views each app gets?
by Scott Ritchie 25 Jan '06

25 Jan '06

This was an idea we discussed in IRC for a short bit, and I think it would be good to bring it up here. Essentially, if the AppDB displayed the number of page views each app got it would go a long way towards estimating the demand for particular applications, whether they work or not. It seems fair to say that someone looking an app up in the AppDB either wants to run it in Wine or wants to know if it's doable should he switch to Wine. Coincidentally, this also helps solve the voting problem - since votes for gold apps are supposed to be replaced with votes for apps that work should be done on, we now have a mechanism to sort the Gold list other than by votes. Sorting the gold list by page views would also greatly help navigation from the front page of the AppDB, as it would place the most popular applications at the top. Then again, maybe there's something I've overlooked. Thoughts? -Scott Ritchie

4 3

Re: [Fwd: WineTools is in need of some major house cleaning!]
by Juan Lang 25 Jan '06

25 Jan '06

Hm. Felt I needed to offer a counterpoint to Vitaliy's rather enthusiastic response. I support winetools, though I don't use it myself. Not only as a matter of principle (this is open source we're talking about, and one of the beauties is we don't get to constrain how it's used.) Also because it's in line with the aims of the Wine project: run Windows apps. Wine is nice in that it doesn't require you to have any MS license to run Windows apps, but it can use MS software if you have a licensed copy. So winetools offers folks with MS licenses a relatively easy way to get apps to run. Still, while that's nice for the users, it's not so nice for us Wine developers, because it's hard to get widespread testing of things we're improving if they're not being widely used. So, as Vitaliy suggested, it would be nice for us if you guys, who know what problems you encounter running with builtin DLLs, could file bug reports in bugzilla for us. That way at least we have a chance to say, hey, that problem's now fixed, consider using builtin OLE (or whatever) in the next release of winetools. Now for specifics. For instance, you use native advpack in all cases, but that's seen some more work recently. What bugs do you encounter if you use builtin instead? Same with ole32. Ideally, each of the apps that has a native override should have a bug report associated with it, what goes wrong if you use the builtin version instead. Also, the default override, "*"="native,builtin" seems wrong. If we don't have a DLL at all, we use a native version of course. I don't think it should be the policy to assume the Wine version isn't up to snuff by default. This could even cause problems, e.g. I don't believe any native version of netapi32.dll will work on Wine, yet you don't specify to use the builtin version. Also, you direct users to http://winehq.org/site/forums. That's fine since this is community support anyway, and it is often the case that winetools knowledgeable people are around (like you guys.) But it would be nicer if you could be clearer about it. Like, that we developers had nothing to do with it, and may be unfriendly to it if we're in a bad mood, or it's a Tuesday :) It'd also be nice (for us, even though no one actually reads anything these days) if you could be clearer about what it does. That it installs MS components, that it uses these instead of the builtin versions sometimes, that you can change how it does this using winecfg, etc. That'd make it easier for us to help folks that have only used winetools that want support, because often the first question we ask is, what version of wine, and what DLLs are you using? --Juan __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Problem with WineD3D Surface Locking
by Stefan Dösinger 24 Jan '06

24 Jan '06

Hello, I've spotted a bug in WineD3D's surface locking, and I have no clue how to fix this. The problem is that unlocking the back buffer causes it to become completely black, no matter what's written to it's memory or what has been there before. I have written a small D3D9 test app which shows this behavior: Compile it with "winemaker .", followed by make, and run it. Pressing ESC will cause it to quit, pressing any other keys makes IDirect3DDevice9::Clear call on the back buffer, with a color value based on the pressed keys. A click anywhere will LockRect() the whole backbuffer, write 0xff into the whole locked memory, and UnlockRect() it. The screen should become completely white, but instead it goes black. With the fglrx driver and 24 bit color depth it shows the correct behavior, but with any other driver(radeon, software rendering) or 16 bit color depth, it doesn't work. The bug is somehow related to some GL calls in UnlockRect(glPixelZoom and glOrtho), but I couldn't find anything specific. I hope you can help me, I am quite stuck here, Stefan

2 4

Winelib debugging with eclipse in fc4
by Michael Ost 24 Jan '06

24 Jan '06

A while back I posted a question about how to get debugging working with eclipse in fedora 4. I am having some success, so if anyone else out there is interested here's how it is set up. In regedit: * disabled auto winedbg by renaming AeDebug I changed HKEY_LOCAL_MACHINE/Software/Microsoft/Windows NT/Current Version/AeDebug to AeDebug-DISABLED. Without this gdb doesn't seem to be able to get a hold of SEGFAULTs. In eclipse's Run/Debug dialog box: * set the c/c++ application to WINE_SRC/loader/wine-pthread WINE_SRC points to a compiled version of wine. For me, I got the wine src rpm and ran rpmbuild -bb. This is where main() is, which eclipse looks for at start up. * put your .exe.so file on the Arguments tab * choose the GDB Debugger on the Debugger tab * add WINE_SRC on the Source tab as a "Filesystem directory with subdirectories" The only weirdness so far is that sometimes (not always) the debugger suspends when a new thread is created. I just resume (F8) past that. And I am not sure what impact bypassing wine-preload's exec-shield workaround will have on me. More on that if I learn more. But I gotta say that having a functioning IDE with integrated debugging on Linux is a major relief and, for me at least, a long time coming! ... mo PS: I installed FC4, and then did yum update. eclipse is version 3.1.1 updated from the eclipse UI from the version that came with FC4.

2 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel